Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c3ca24d4 12011-11-14 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d
PE
2
3 Standardize on VIRT_ADDR_VARIES behavior; otherwise, valgrind
4 does not work on some platforms. Problem reported by Andreas Schwab in
5 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7 is set, removing the need for VIRT_ADDRESS_VARIES.
8 (PURE_P): Use a more-efficient implementation that needs just one
9 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
10 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
11 to 4 (xorl, subq, cmpq, setbe).
12 * alloc.c (pure): Always extern now, since that's the
13 VIRT_ADDR_VARIES behavior.
14 (PURE_POINTER_P): Use a single comparison, not two, for
15 consistency with the new puresize.h.
16 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
17 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
18 Remove VIRT_ADDR_VARIES no longer needed.
19
1e5b2111
EZ
202011-11-12 Eli Zaretskii <eliz@gnu.org>
21
7ef3cbd5
EZ
22 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
23 with user-defined heap size. Bump the default size of the temacs
24 heap to 27MB, to avoid memory warning when running temacs.
25 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
26
1e5b2111
EZ
27 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
28 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
29 (verify_row_hash) [XASSERTS]: New function.
30 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
31 that the hash value of glyph rows is correct.
1e5b2111 32
89d61221
MR
332011-11-12 Martin Rudalics <rudalics@gmx.at>
34
35 * window.h (window): Remove splits slot.
36 * window.c (Fwindow_splits, Fset_window_splits): Remove.
37 (Fdelete_other_windows_internal, make_parent_window)
38 (make_window, Fsplit_window_internal, Fdelete_window_internal)
39 (Fset_window_configuration, save_window_save): Don't deal with
40 split status of windows.
41 (saved_window): Remove splits slot.
42 (Vwindow_splits): Rewrite doc-string.
43
97f18cc8
JD
442011-11-11 Jan Djärv <jan.h.d@swipnet.se>
45
46 * xfns.c (unwind_create_frame):
47 * nsfns.m (unwind_create_frame):
48 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
49 Vframe_list (Bug#9999).
50
22a648b4
DA
512011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
52
53 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
54
659afede
KH
552011-11-11 Kenichi Handa <handa@m17n.org>
56
57 * callproc.c (Fcall_process): Set the member dst_multibyte of
58 process_coding.
59
9ac0394b
KH
602011-11-11 Johan Bockgård <bojohan@gnu.org>
61
62 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
63 avoid a crash (bug#9496).
64
2fbdc249
CY
652011-11-09 Chong Yidong <cyd@gnu.org>
66
67 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
68 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
69
ac6b1f81
PE
702011-11-08 Paul Eggert <eggert@cs.ucla.edu>
71
72 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
73
09db192c
PE
742011-11-08 Paul Eggert <eggert@cs.ucla.edu>
75
76 Avoid some portability problems by eschewing 'extern inline' functions.
77 The trivial performance wins aren't worth the portability hassles; see
78 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
79 et seq.
80 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
81 (window_box_width, window_box_left, window_box_left_offset)
82 (window_box_right, window_box_right_offset): Undo previous change,
83 by removing the "extern"s.
84 * intervals.c (adjust_intervals_for_insertion)
85 (adjust_intervals_for_deletion): Undo previous change,
86 making these static again.
87 (offset_intervals, temp_set_point_both, temp_set_point)
88 (copy_intervals_to_string): No longer inline.
89 * xdisp.c (window_text_bottom_y, window_box_width)
90 (window_box_height, window_box_left_offset)
91 (window_box_right_offset, window_box_left, window_box_right)
92 (window_box): No longer inline.
93
105216ed
CY
942011-11-08 Chong Yidong <cyd@gnu.org>
95
96 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
97 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
98 an error if not a live window.
99 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
100 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
101
ae9e237f
JB
1022011-11-07 Juanma Barranquero <lekktu@gmail.com>
103
104 * lisp.h (syms_of_abbrev): Remove declaration.
105 Reported by CHENG Gao <chenggao@royau.me>.
106
c7aa8333
EZ
1072011-11-07 Eli Zaretskii <eliz@gnu.org>
108
109 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
110 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
111 of temacs in GUI mode.
112
be7f5545
MR
1132011-11-07 Martin Rudalics <rudalics@gmx.at>
114
115 * window.h: Declare delete_all_child_windows instead of
116 delete_all_subwindows.
117 * window.c (Fwindow_nest, Fset_window_nest)
118 (Fset_window_new_total, Fset_window_new_normal)
119 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
120 (delete_all_subwindows): Rename to delete_all_child_windows.
121 (Fdelete_other_windows_internal, Fset_window_configuration):
122 Call delete_all_child_windows instead of delete_all_subwindows.
123 * frame.c (delete_frame): Call delete_all_child_windows instead
124 of delete_all_subwindows.
125
ca78dc43
PE
1262011-11-07 Paul Eggert <eggert@cs.ucla.edu>
127
128 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
129 This is also needed for porting to any host where GC_MARK_STACK is
130 not GC_MAKE_GCPROS_NOOPS.
131 (which_symbols): Use it.
132
a0241d01
KH
1332011-11-07 Kenichi Handa <handa@m17n.org>
134
135 * coding.c (coding_set_destination): Check coding->src_pos only
136 when coding->src_object is a buffer (bug#9910).
137
138 * process.c (send_process): Set the member src_multibyte of coding
139 to 0 (bug#9911) when sending a unibyte text.
140
141 * callproc.c (Fcall_process): Set the member src_multibyte of
142 process_coding to 0 (bug#9912).
143
a64bfdfa 1442011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
145
146 * xmenu.c (cleanup_widget_value_tree): New function.
147 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
148 calling free_menubar_widget_value_tree directly (Bug#9830).
149
cb41b32a
PE
1502011-11-06 Paul Eggert <eggert@cs.ucla.edu>
151
152 Fix some portability problems with 'inline'.
153 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
154 (window_box_width, window_box_left, window_box_left_offset)
155 (window_box_right, window_box_right_offset): Declare extern.
156 Otherwise, these inline functions do not conform to C99 and
157 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
158 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
159 * intervals.c (adjust_intervals_for_insertion)
160 (adjust_intervals_for_deletion): Now extern, because otherwise the
161 extern inline functions 'offset_intervals' couldn't refer to it.
162 (static_offset_intervals): Remove.
163 (offset_intervals): Rewrite using the old contents of
164 static_offset_intervals. The old version didn't conform to C99
165 because an extern inline function contained a reference to an
166 identifier with static linkage.
167
b7041366
AS
1682011-11-06 Andreas Schwab <schwab@linux-m68k.org>
169
170 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
171 GC.
172
88a37c4d
EZ
1732011-11-06 Eli Zaretskii <eliz@gnu.org>
174
175 * xdisp.c (init_iterator, reseat_to_string): Don't set the
176 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
177 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
178 return Qleft_to_right.
179
49745b39
CY
1802011-11-06 Chong Yidong <cyd@gnu.org>
181
182 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
183 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
184 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
185 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
186 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
187 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
188 (Fwindow_vscroll): Doc fix.
189 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
190 argument, since it makes no sense to pass a live window and for
191 consistency with window-child.
192
1f05cd82
CS
1932011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
194
195 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
196 support MSVC.
197
22610910
JR
1982011-11-05 Jason Rumney <jasonr@gnu.org>
199
200 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
201 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
202 fonts (Bug#6029).
203 (add_font_entity_to_list): Fix logic errors in mixed boolean and
204 bitwise arithmetic preventing use of unicode-sip and non-truetype
205 opentype fonts.
206
a06776b2
EZ
2072011-11-05 Eli Zaretskii <eliz@gnu.org>
208
3ad924ba
EZ
209 * s/ms-w32.h (fstat, stat, utime): Move redirections to
210 "emacs"-only part.
211
a06776b2
EZ
212 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
213 initialization code to keep similarity to xfns.c after changes
214 from 2011-11-05.
215
c9e7db78
JD
2162011-11-05 Jan Djärv <jan.h.d@swipnet.se>
217
a97f8f3f
JD
218 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
219 (unwind_create_frame): New function (Bug#9943).
220 (Fx_create_frame): Restructure code to be more similar to the one in
221 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
222 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
223 Move terminal->reference_count++ just before making the frame official
224 (Bug#9943).
225
226 * nsterm.m (x_free_frame_resources): New function.
227 (x_destroy_window): Move code to x_free_frame_resources.
228
c9e7db78
JD
229 * xfns.c (unwind_create_frame): Fix comment.
230 (Fx_create_frame, x_create_tip_frame): Move
231 terminal->reference_count++ just before making the frame
232 official. Move initialization of image_cache_refcount and
233 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
234
a6fc3b5c
EZ
2352011-11-05 Eli Zaretskii <eliz@gnu.org>
236
237 Support MSVC build with newer versions of Visual Studio.
238 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
239 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
240 nt/gmake.defs.
241
242 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
243 which are not supported by MSVC.
244 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
245 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
246 bitfields.
247 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
248 types in bitfields.
249 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
250
251 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
252
2532011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
254
255 Support MSVC build with newer versions of Visual Studio.
256 * w32.c: Don't include w32api.h for MSVC.
257 (init_environment) [_MSC_VER]: Call sys_access, not _access.
258
259 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
260 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
261 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
262 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
263 e_* cousins.
264 (alloca) [_MSC_VER]: Define to _alloca.
265
266 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
267
268 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
269
a58c13ed
EZ
2702011-11-04 Eli Zaretskii <eliz@gnu.org>
271
272 * xdisp.c (note_mouse_highlight): If either of
273 previous/next-single-property-change returns nil, treat that as
274 the beginning or the end of the buffer. (Bug#9955)
275
fe0b6370
JD
2762011-11-04 Jan Djärv <jan.h.d@swipnet.se>
277
a58c13ed 278 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
279 label is not null (Bug#9951).
280 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
281 may be NULL.
282
89bd5ee1
EZ
2832011-11-04 Eli Zaretskii <eliz@gnu.org>
284
285 * window.c (Fwindow_body_size): Mention in the doc string that the
286 return value is in frame's canonical units. (Bug#9949)
287
84c3edb9
EZ
2882011-11-03 Eli Zaretskii <eliz@gnu.org>
289
4e2fb5c7
EZ
290 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
291
84c3edb9 292 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 293 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 294 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 295
bc17a887
EZ
2962011-11-01 Eli Zaretskii <eliz@gnu.org>
297
298 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
299 Don't stop backward scan on the continuation glyph, even though
300 its CHARPOS is positive.
26b46e51
EZ
301 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
302 cover_string to disp_string.
bc17a887 303
4ee88440
MR
3042011-11-01 Martin Rudalics <rudalics@gmx.at>
305
306 * window.c (temp_output_buffer_show): Don't use
307 Vtemp_buffer_show_specifiers.
308 (Vtemp_buffer_show_specifiers): Remove unused variable.
309
c2ff3c02
EZ
3102011-10-30 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
313 past the beginning of the current glyph matrix.
314
6e56383b
JD
3152011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
316
317 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
318 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
319 HAVE_GTK3 (Bug#9869).
b77a6a7f 320
3b574623
JD
321 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
322 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
323
b77a6a7f
JD
324 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
325
326 * xterm.c: Declare x_handle_net_wm_state to return int.
327 (handle_one_xevent): Check if we are iconified but don't have
328 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
329 (get_current_wm_state): Return non-zero if not hidden,
330 check for _NET_WM_STATE_HIDDEN (Bug#9893).
331 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
332 (x_handle_net_wm_state): Return what get_current_wm_state returns.
333 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
334
196e41e4
PE
3352011-10-29 Paul Eggert <eggert@cs.ucla.edu>
336
337 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
338 so that this new function doesn't get optimized away by a
339 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
340
021f2e1a
AS
3412011-10-29 Andreas Schwab <schwab@linux-m68k.org>
342
343 * frame.h (MOUSE_HL_INFO): Remove excess parens.
344
8b058d44
EZ
3452011-10-29 Eli Zaretskii <eliz@gnu.org>
346
347 Fix the `xbytecode' command.
348 * .gdbinit (xprintbytestr): New command.
349 (xwhichsymbols): Renamed from `which'; all callers changed.
350 (xbytecode): Print the byte-code string as well.
351
4452fb80
EZ
3522011-10-29 Kim Storm <storm@cua.dk>
353
8b058d44
EZ
354 * alloc.c (which_symbols): New function.
355
21b72067
AS
3562011-10-29 Andreas Schwab <schwab@linux-m68k.org>
357
358 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
359 line. (Bug#9903)
360
83ed7b5c
GM
3612011-10-29 Glenn Morris <rgm@gnu.org>
362
363 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
364 Not clear what it was for, and it causes various bugs. (Bug#9839)
365
5a7a728b
EZ
3662011-10-28 Eli Zaretskii <eliz@gnu.org>
367
368 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
369 possible random value that matches one of those tested as
370 condition to clear the mouse face.
371
d3d0842f
CY
3722011-10-28 Chong Yidong <cyd@gnu.org>
373
374 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
375
31b39d13
DN
3762011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
377
378 * window.c (make_window): Initialize phys_cursor_on_p.
379
9aba6043
SM
3802011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * lisp.h (struct Lisp_Symbol): Update comments.
383
c20992f4
JB
3842011-10-28 Juanma Barranquero <lekktu@gmail.com>
385
386 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
387
db4f02f2
EZ
3882011-10-28 Eli Zaretskii <eliz@gnu.org>
389
390 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
391 <oslsachem@gmail.com> for helping to debug this.
392
393 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
394 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
395 (g_b_init_get_glyph_outline_w): New static variables.
396 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
397 (GetGlyphOutlineW_Proc): New typedefs.
398 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
399 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
400 New functions.
401 (w32font_open_internal, compute_metrics):
402 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
403 instead of calling the "wide" APIs directly.
404
405 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
406
407 * w32.h (syms_of_w32font): Add prototype.
408
87e68db4
JB
4092011-10-27 Juanma Barranquero <lekktu@gmail.com>
410
411 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
412 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
413 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
414 (Fmove_to_window_line): Doc fix.
415
435c1d67
CY
4162011-10-27 Chong Yidong <cyd@gnu.org>
417
418 * process.c (make_process): Set gnutls_state to NULL.
419
420 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
421 non-NULL, regardless of GNUTLS_INITSTAGE.
422 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
423 an error. Set process slots as soon as we allocate them.
424
425 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
426
9c6c6f49
CY
4272011-10-27 Chong Yidong <cyd@gnu.org>
428
9aba6043
SM
429 * gnutls.c (emacs_gnutls_deinit): New function.
430 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
431 (Fgnutls_deinit, Fgnutls_boot): Use it.
432
433 * process.c (make_process): Initialize GnuTLS credentials to NULL.
434 (deactivate_process): Call emacs_gnutls_deinit.
435
657d08d3
JB
4362011-10-27 Juanma Barranquero <lekktu@gmail.com>
437
438 * image.c (x_create_x_image_and_pixmap):
439 * w32.c (sys_rename, w32_delayed_load):
440 * w32font.c (fill_in_logfont):
441 * w32reg.c (x_get_string_resource): Silence compiler warnings.
442
5430d399
JB
4432011-10-26 Juanma Barranquero <lekktu@gmail.com>
444
445 * w32fns.c (w32_default_color_map): New function,
446 extracted from Fw32_default_color_map.
a7ef684b 447 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 448
fe0055fa
PE
4492011-10-25 Paul Eggert <eggert@cs.ucla.edu>
450
451 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
452
e6346438
SM
4532011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
454
455 * keyboard.c (test_undefined): New function (bug#9751).
456 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
457
e112cc37
ET
4582011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
459
460 * sysdep.c (init_sys_modes): Fix the check for the controlling
461 terminal (Bug#6649).
462
7b5d6677
EZ
4632011-10-20 Eli Zaretskii <eliz@gnu.org>
464
465 * dispextern.h (struct bidi_it): New member next_en_type.
466
467 * bidi.c (bidi_line_init): Initialize the next_en_type member.
468 (bidi_resolve_explicit_1): When next_en_pos is valid for the
469 current character, check also for next_en_type being WEAK_EN.
470 (bidi_resolve_weak): Don't enter the expensive loop if the current
471 position is before next_en_pos. Record the bidi type of the first
472 non-ET, non-BN character we find, in addition to its position.
473 (bidi_level_of_next_char): Invalidate next_en_type when
474 next_en_pos is over-stepped.
475
7da0b018
PE
4762011-10-20 Paul Eggert <eggert@cs.ucla.edu>
477
478 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
479 * editfns.c: Rewrite current-time-zone so that it invokes
480 the equivalent of (format-time-string "%Z") to get the time zone name.
481 This fixes a bug when the time zone name contains characters that
482 need converting from the system time locale to Emacs internal format.
483 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
484 that patch fixed format-time-string to do the conversion, but
485 I forgot to fix current-time-zone.
486 (format_time_string): New function, containing most of
487 what Fformat_time_string used to contain.
488 (Fformat_time_string): Rewrite in terms of format_time_string.
489 This doesn't change this function's behavior.
490 (current-time-zone): Rewrite to use format_time_string.
491 This fixes the bug reported by Michael Schierl in
492 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
493 Jason Rumney's 2007-06-07 change worked around this bug, but
494 didn't fix it.
495 * systime.h (tzname, timezone): Remove no-longer-used declarations.
496
8547b010
EZ
4972011-10-19 Eli Zaretskii <eliz@gnu.org>
498
499 * xdisp.c (start_display): If the character at POS is displayed
500 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
501 (try_window_reusing_current_matrix): If a line ends in a display
502 vector or the next line starts in a display vector, continue
503 redrawing the window even though the character position of
504 start_row was reached.
8547b010
EZ
505 (Bug#9771, part 2)
506
4e948d15
CY
5072011-10-18 Chong Yidong <cyd@gnu.org>
508
509 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
510 with nobreak-char-display too.
511
4787455f
EZ
5122011-10-18 Eli Zaretskii <eliz@gnu.org>
513
514 Fix part 3 of bug#9771.
515 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
516 (bidi_resolve_neutral): Don't enter the expensive loop looking for
517 non-neutral characters if the current character is a paragraph
518 separator (a.k.a. Newline). This avoids running the same
519 expensive loop twice, once when we consume the preceding newline
520 and the other time when the line actually needs to be displayed.
521 Avoid the loop when we see neutrals on the base embedding level
522 following a character whose directionality is the same as the
523 paragraph's. This avoids running the expensive loop when a line
524 ends in a long sequence of neutrals, like control characters.
525 Add assertion against STRONG_AL type. Slightly rearrange code
526 that determines the type of a neutral given the first non-neutral
527 that follows it.
528 (bidi_level_of_next_char): Set next_en_pos to zero when
529 invalidating its info.
530
2c91f553
EZ
5312011-10-17 Eli Zaretskii <eliz@gnu.org>
532
533 * xdisp.c (push_display_prop): Determine whether to record string
534 or buffer position by IT->string, not by IT->method. Allow
535 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
536 (move_it_vertically_backward): Don't look for character position
537 immediately after the newline when in a continuation line.
538 (Bug#9771, part 1)
2c91f553 539
c7b08b0d
MR
5402011-10-15 Martin Rudalics <rudalics@gmx.at>
541
542 * window.c (coordinates_in_window): Rewrite and delabelize
543 vertical border check. (Bug#5357) (Bug#9618)
544
6b02f655
SM
5452011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
546
547 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
548 errors in XSetWindowBorder (bug#9310).
549
81d40c92
DA
5502011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
551
552 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
553 avoid crash when xmalloc overrun checking is enabled.
554
d4172c3b
EZ
5552011-10-13 Eli Zaretskii <eliz@gnu.org>
556
557 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
558 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
559 cursor motion with <left> and <right> arrow keys.
560
561 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
562 some callers set that themselves.
563
b00eea75
EZ
5642011-10-12 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
567 display string and the previous row comes from the same string and
568 is empty. (Bug#9739) (Bug#9738)
569
8fe012c4
SM
5702011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
571
572 * doc.c (get_doc_string): Encode file name (bug#9735).
573
0074aef2
EZ
5742011-10-12 Eli Zaretskii <eliz@gnu.org>
575
79beb178
EZ
576 * bidi.c (bidi_level_of_next_char):
577 * xdisp.c (get_visually_first_element): Remove old incorrect
578 comments regarding the Unicode Line Separator character.
579
0074aef2
EZ
580 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
581
6e4b3fbe
DA
5822011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
583
584 * alloc.c (Fgc_status): Do not access beyond zombies array
585 boundary if nzombies > MAX_ZOMBIES.
586 * alloc.c (dump_zombies): Add missing format specifier.
587
0324f3af
PE
5882011-10-12 Paul Eggert <eggert@cs.ucla.edu>
589
b5525cac
PE
590 * xdisp.c (set_cursor_from_row): Simplify conditionals,
591 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
592
0324f3af
PE
593 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
594 Some packages use them to denote characters with modifiers.
595
e9b5f888
AS
5962011-10-11 Andreas Schwab <schwab@linux-m68k.org>
597
598 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
599 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
600 matching a pp-number. Rename parameter var to var1.
601
127827c0
SM
6022011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
603
604 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
605
c8fd3bd0
GM
6062011-10-08 Glenn Morris <rgm@gnu.org>
607
608 * callint.c (Fcall_interactively): Give a more explicit error for the
609 'c' case with a non-character input. (Bug#8479)
610
352ec8ff
EZ
6112011-10-08 Eli Zaretskii <eliz@gnu.org>
612
03669ccb
EZ
613 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
614 lines.
7061c986
EZ
615 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
616 lines that are hscrolled on the left.
03669ccb 617
352ec8ff
EZ
618 * dispnew.c (buffer_posn_from_coords): Account for a possible
619 presence of header-line. (Bug#4426)
620
a66cfb1c
SM
6212011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
622
6b02f655
SM
623 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
624 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 625
7c5ee88e
PE
6262011-10-07 Paul Eggert <eggert@cs.ucla.edu>
627
628 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
629 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
630 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
631 this makes Emacs dump core during garbage collection on rare
632 occasions. sizeof is obviously inferior to offsetof here, so
633 stick with offsetof.
634 (GC_POINTER_ALIGNMENT): New macro.
635 (mark_memory): Omit 3rd (offset) arg; caller changed.
636 Don't assume EMACS_INT alignment is the same as pointer alignment.
637
df1bbe5b
SM
6382011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
639
640 * keyboard.c (read_key_sequence_remapped): New var.
641 (read_key_sequence): Compute remapping in the right buffer.
642 (command_loop_1): Use read_key_sequence's remapping directly.
643
51553db6
SM
6442011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
645
32c1fffd
SM
646 * dired.c (file_name_completion): Don't expand file name.
647 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
648 before checking file name handler.
649
51553db6
SM
650 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
651 they've been requested explicitly (bug#9591).
652
b6bd1599 6532011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
654
655 * keymap.c (Fsingle_key_description): Use make_specified_string
656 instead of build_string to build string from push_key_description.
657 (Bug#5193)
658
f701dc2a
PE
6592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
660
4222c55d
PE
661 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
662 This fixes a Y2038 bug on 64-bit hosts.
663 * buffer.c (reset_buffer):
664 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
665 (Fclear_buffer_auto_save_failure):
666 Use 0, not -1, to represent an unset failure time, since time_t
667 might not be signed.
668
f701dc2a
PE
669 Remove dependency on glibc malloc internals.
670 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
671 Move back here from lisp.h, but with their new implementations.
672 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
673 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
674 * charset.c (charset_table_init): New static var.
675 (syms_of_charset): Use it instead of xmalloc. This removes a
676 dependency on glibc malloc internals. See Eli Zaretskii's comment in
677 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
678 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
679 Move back to alloc.c.
680 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
681 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
682
9ceebf39
JD
6832011-09-30 Jan Djärv <jan.h.d@swipnet.se>
684
685 * nsterm.m (windowDidResize): Call x_set_window_size only when
686 ns_in_resize is true. Otherwise set pixelwidth/height and
687 call change_frame_size (Bug#9628).
688
cb993c58
PE
6892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
690
3930c88b
PE
691 Port --enable-checking=all to Fedora 14 x86-64.
692 * charset.c (syms_of_charset): Also account for glibc malloc's
693 internal overhead when calculating the initial malloc maximum.
694
cb993c58
PE
695 Port --enable-checking=all to Fedora 14 x86.
696 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
697 Move to lisp.h.
698 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
699 (overrun_check_realloc, overrun_check_free):
700 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
701 That way, xmalloc returns a properly-aligned pointer even if
702 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
703 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
704 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
705 into account when calculating the initial malloc maximum.
706 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
707 Move here from alloc.c, so that charset.c can use it too.
708 Properly align; the old code wasn't right for common 32-bit hosts
709 when configured with --enable-checking=all.
710 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
711 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
712
31bed486
EZ
7132011-09-29 Eli Zaretskii <eliz@gnu.org>
714
04c70788 715 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
716 use EDOM.
717
fbcaa2f3
EZ
7182011-09-28 Eli Zaretskii <eliz@gnu.org>
719
720 * xdisp.c (compute_display_string_end): If there's no display
721 string at CHARPOS, return -1.
722
723 * bidi.c (bidi_fetch_char): When compute_display_string_end
724 returns a negative value, treat the character as a normal
725 character not covered by a display string. (Bug#9624)
726
a239d4e9
JB
7272011-09-28 Juanma Barranquero <lekktu@gmail.com>
728
729 * lread.c (Fread_from_string): Fix typo in docstring.
730
88652fd5
EZ
7312011-09-27 Eli Zaretskii <eliz@gnu.org>
732
733 * xdisp.c (handle_invisible_prop): If invisible text ends on a
734 newline, reseat the iterator instead of bidi-iterating there one
735 character at a time. (Bug#9610)
32c1fffd
SM
736 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
737 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 738
ed497dd4
AS
7392011-09-27 Andreas Schwab <schwab@linux-m68k.org>
740
741 * lread.c (readevalloop): Use correct code for NBSP.
742 (read1): Likewise. (Bug#9608)
743
b2bf61aa
MA
7442011-09-25 Michael Albinus <michael.albinus@gmx.de>
745
746 * dbusbind.c (Fdbus_register_signal): When service is not
747 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
748
32bbb17c
GM
7492011-09-25 Glenn Morris <rgm@gnu.org>
750
751 * buffer.c (truncate-lines): Doc fix.
752
94e0933e
CY
7532011-09-24 Chong Yidong <cyd@stupidchicken.com>
754
755 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
756 (Fset_window_next_buffers): Doc fix.
757
cddde921
GM
7582011-09-24 Glenn Morris <rgm@gnu.org>
759
760 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
761
1260aef1
PE
7622011-09-24 Paul Eggert <eggert@cs.ucla.edu>
763
25b4bfa0
PE
764 Fix minor problems found by static checking.
765 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
766 * indent.c (Fvertical_motion): Fix == vs = typo.
767
e3cbd34b
EZ
7682011-09-24 Eli Zaretskii <eliz@gnu.org>
769
a66cfb1c
SM
770 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
771 Default value is now t. Doc fix.
6bf7006f 772
e3cbd34b 773 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 774 logic when moving up, not only when moving down. Fix the
e3cbd34b 775 confusing name and values of the it_overshoot_expected variable;
32c1fffd 776 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
777
778 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
779 CHARPOS is covered by a display string which includes newlines.
780 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
781 is covered by a display string with embedded newlines.
782
a3de0cbd
MA
7832011-09-24 Michael Albinus <michael.albinus@gmx.de>
784
785 * dbusbind.c (Fdbus_register_signal): Add match rule to
786 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
787 (Fdbus_register_method, Vdbus_registered_objects_table):
788 Fix docstring.
a3de0cbd 789
b260039d
JM
7902011-09-24 Jim Meyering <meyering@redhat.com>
791
32c1fffd 792 do not ignore write error for any output size
b260039d
JM
793 The previous change was incomplete.
794 While it makes emacs --batch detect the vast majority of stdout
795 write failures, errors were still ignored whenever the output size is
796 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
797 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
798 && echo FAIL: ignored write error
799 FAIL: ignored write error
800 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
801 && echo FAIL: ignored write error
802 FAIL: ignored write error
803 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
804
8eca8a7c
AS
8052011-09-23 Andreas Schwab <schwab@linux-m68k.org>
806
807 * emacs.c (Fkill_emacs): In noninteractive mode exit
808 non-successfully if a write error occurred on stdout. (Bug#9574)
809
3341db62
EZ
8102011-09-21 Eli Zaretskii <eliz@gnu.org>
811
812 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
813 the xassert test.
814
815 * dispextern.h (struct it): Update the comment documenting what
816 can it->OBJECT be.
817
8c203dbf
EZ
8182011-09-20 Eli Zaretskii <eliz@gnu.org>
819
820 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
821 a display string, extend search for cursor position to end of row.
822 (find_row_edges): If the row ends in a newline from a display
823 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
824 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
825 (Fcurrent_bidi_paragraph_direction): Fix search for previous
826 non-empty line. Fixes confusing cursor motion with arrow keys at
827 the beginning of a line that starts with whitespace.
8c203dbf 828
a4824228
LMI
8292011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
830
831 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
832 (bug#9493).
833
33ed493b
CY
8342011-09-18 Chong Yidong <cyd@stupidchicken.com>
835
836 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
837 boolean (Bug#9154).
838
56cd55c8
EZ
8392011-09-18 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (display_line): Record maximum and minimum buffer
842 positions even if no glyphs were produced (e.g., by a zero-width
843 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
844 buffer positions that will be removed from the glyph row because
845 they don't fit.
c02dcedf
EZ
846 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
847 column is beyond frame width: don't subtract 1 "pixel" when
848 computing width of the stretch.
3e62b7e0
EZ
849 (reseat_at_next_visible_line_start): Undo the change made on
850 2011-09-17 that saved paragraph information and restored it after
851 the call to `reseat'. (Bug#9545)
56cd55c8 852
5ed99d36 8532011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
854
855 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
856 and turn window cursor on if cleared (Bug#9415).
857
5ed99d36 8582011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
859
860 * search.c (boyer_moore): Take unibyte characters from pattern
861 literally. (Bug#9458)
862
9bade7b2
EZ
8632011-09-18 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
866
e5e9d610
PE
8672011-09-18 Paul Eggert <eggert@cs.ucla.edu>
868
87e4427a
PE
869 Fix minor problem found by static checking.
870 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
871 initialized, to pacify gcc -Wuninitialized.
872
e5e9d610
PE
873 * fileio.c: Report proper errno when syscall falls.
874 (Finsert_file_contents): Save and restore errno,
875 so that report_file_error outputs the correct diagnostic.
876 (Fwrite_region) [CLASH_DETECTION]: Likewise.
877
a1674f0b
EZ
8782011-09-18 Eli Zaretskii <eliz@gnu.org>
879
880 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
881
fbfb6dd4
EZ
8822011-09-17 Eli Zaretskii <eliz@gnu.org>
883
884 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
885 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
886
bb187662
EZ
8872011-09-17 Eli Zaretskii <eliz@gnu.org>
888
1137e8b8 889 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 890 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
891
892 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
893 (bidi_find_paragraph_start): Search back for paragraph beginning
894 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
895 (bidi_move_to_visually_next): Only trigger paragraph-related
896 computations when the last character is a newline or at EOB, not
897 just any NEUTRAL_B. (Bug#9470)
898
bb187662
EZ
899 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
900 truncated lines if point is covered by a display string. (Bug#9524)
901
2e621251
PE
9022011-09-16 Paul Eggert <eggert@cs.ucla.edu>
903
904 * xselect.c: Relax test for outgoing X longs (Bug#9498).
905 (cons_to_x_long): New function.
906 (lisp_data_to_selection_data): Use it. Correct the test for
907 short-versus-long data; it was negated. Break out of vector
908 loop, for efficiency, when a long datum is discovered.
909
91a15bc6
SM
9102011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
911
912 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
913
b41c3a35
EZ
9142011-09-16 Eli Zaretskii <eliz@gnu.org>
915
916 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
917 GCC PR/17406) by declaring this function with external scope.
918
7812ba2d
PE
9192011-09-15 Paul Eggert <eggert@cs.ucla.edu>
920
921 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
922 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
923
cf7edc2a
AS
9242011-09-15 Andreas Schwab <schwab@linux-m68k.org>
925
926 * editfns.c (Fformat): Correctly handle text properties on "%%".
927
bd01620e
EZ
9282011-09-15 Eli Zaretskii <eliz@gnu.org>
929
930 * xterm.c (x_draw_composite_glyph_string_foreground):
931 * w32term.c (x_draw_composite_glyph_string_foreground):
932 * term.c (encode_terminal_code):
933 * composite.c (composition_update_it, get_composition_id):
934 * xdisp.c (get_next_display_element)
935 (fill_composite_glyph_string): Add comments about special meaning
936 of TAB characters in a composition.
937
a02719a3
PE
9382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
939
940 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
941 This occurs when processing a multibyte format.
942 Problem reported by Wolfgang Jenker.
a02719a3 943
72589a3c
JB
9442011-09-15 Johan Bockgård <bojohan@gnu.org>
945
946 * xdisp.c (try_cursor_movement): Only check for exact match if
947 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
948
1c14176c
PE
9492011-09-14 Paul Eggert <eggert@cs.ucla.edu>
950
951 Remove unused external symbols.
952 * dispextern.h (calc_pixel_width_or_height): Remove decl.
953 * xdisp.c (calc_pixel_width_or_height): Now static.
954 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
955 * indent.c (check_display_width):
956 * w32term.c: Fix comment to match code.
957 * xterm.c, xterm.h (x_catching_errors): Remove.
958
d2eea5b5
PE
9592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
960
961 * xselect.c: Use signed conversions more consistently (Bug#9498).
962 (selection_data_to_lisp_data): Assume incoming selection data are
963 signed integers, not unsigned. This is to be consistent with
964 outgoing selection data, which was modified to use signed integers
965 in as part of the fix to Bug#9196 in response to Jan D.'s comment
966 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
967 expects long, not unsigned long.
968
46888499
EZ
9692011-09-14 Eli Zaretskii <eliz@gnu.org>
970
971 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
972 computation of loop end. Reported by Johan Bockgård
973 <bojohan@gnu.org>.
974
ef8ef9fb
CY
9752011-09-13 Chong Yidong <cyd@stupidchicken.com>
976
977 * frame.c (Fother_visible_frames_p): Function deleted.
978
fa819fed
EZ
9792011-09-12 Eli Zaretskii <eliz@gnu.org>
980
981 * indent.c (compute_motion): Process display vector front to back
982 rather than the other way around. (Bug#2496)
983
2ba8e008
SM
9842011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
985
986 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
987
20f53c69
CY
9882011-09-11 Chong Yidong <cyd@stupidchicken.com>
989
990 * minibuf.c (Fread_from_minibuffer): Doc fix.
991
d562d7a4
EZ
9922011-09-11 Eli Zaretskii <eliz@gnu.org>
993
994 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
995 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
996
1c4d7f3d
LMI
9972011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
998
999 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1000 value for non-existent files.
1001
b885bf36
EZ
10022011-09-11 Eli Zaretskii <eliz@gnu.org>
1003
1004 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1005 set its "size" to -1. This will set the modtime_size field of
1006 the corresponding buffer to -1, which is what
1007 verify-visited-file-modtime expects for files that do not exist.
1008 (Bug#9139)
1009
6612f0bf
PE
10102011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1013 here ...
1014 * lisp.h: ... from here. push_key_description is no longer
1015 defined in keyboard.c, so its declaration should not be in
1016 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1017 logically belongs with push_key_description.
1018
dfb3f755
PE
10192011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 * buffer.h: Include <sys/types.h> instead of <time.h>.
1022 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1023 Problem reported by Herbert J. Skuhra.
1024
3134906c
LMI
10252011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1026
1027 * xml.c (parse_region): Make the parsing work for
1028 non-comment-starting XML files again (bug#9144).
1029
8d903f4e
AS
10302011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1031
1032 * image.c (gif_load): Fix calculation of bottom and right corner.
1033 (Bug#9468)
1034
80ad64f4
EZ
10352011-09-10 Eli Zaretskii <eliz@gnu.org>
1036
1037 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1038 redisplay in small windows.
1039
208a048d
EZ
10402011-09-09 Eli Zaretskii <eliz@gnu.org>
1041
1042 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1043
9b1c252e
MR
10442011-09-08 Martin Rudalics <rudalics@gmx.at>
1045
1046 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1047 Operate on live windows only.
1048
2949f33b
JB
10492011-09-08 Juanma Barranquero <lekktu@gmail.com>
1050
1051 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1052
e08dcafd
EZ
10532011-09-07 Eli Zaretskii <eliz@gnu.org>
1054
1055 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1056 only under bidi iteration.
1057
115b96bd
JD
10582011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1059
1060 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1061
c8199d0f
PE
10622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1065 Without this fix, the command to link temacs failed due to an
1066 undefined symbol __builtin_isnan. This is because
1067 /usr/include/iso/math_c99.h #defines isnan(x) to
1068 __builtin_isnan(x), but the bundled gcc, which identifies itself
1069 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1070 a __builtin_isnan.
1071 * floatfns.c (isnan): #undef, and then #define to a clone of
1072 what's in data.c.
1073 (Fisnan): Always define, since it's always available now.
1074 (syms_of_floatfns): Always define isnan at the Lisp level.
1075
e39b275c 10762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1077
1078 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1079
b2db44d9 10802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1081
f4af5137 1082 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1083 The previous code assumed that file offsets (off_t values) fit in
1084 EMACS_INT variables, which is not true on typical 32-bit hosts.
1085 The code messed up by falsely reporting buffer overflow in cases
1086 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1087 when "big" contains more than 2**29 bytes, even though this
1088 inserts just one byte and does not overflow the buffer.
1089 (Finsert_file_contents): Store file offsets as off_t
1090 values, not as EMACS_INT values. Check for overflow when
1091 converting between EMACS_INT and off_t. When checking for
1092 buffer overflow or for overlap, take the offsets into account.
1093 Don't use EMACS_INT for small values where int suffices.
1094 When checking for overlap, fix a typo: ZV was used where
1095 ZV_BYTE was intended.
1096 (Fwrite_region): Don't assume off_t fits into 'long'.
1097 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1098
ecfc0a49
MA
10992011-09-05 Michael Albinus <michael.albinus@gmx.de>
1100
1101 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1102
6511acf2 11032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1104
0999621a 1105 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1106
1107 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1108 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1109 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1110 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1111 (modify_event_symbol): Do not assume that the length of
1112 name_alist_or_stem is safe to alloca and fits in int.
1113 (Fexecute_extended_command): Likewise for function name and binding.
1114 (Frecursion_depth): Wrap around reliably on integer overflow.
1115 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1116 since some callers pass EMACS_INT values.
1117 (Fsingle_key_description): Don't crash if symbol name contains more
1118 than MAX_ALLOCA bytes.
1119 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1120 (get_minibuffer): Arg is now EMACS_INT, not int.
1121 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1122 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1123 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1124
2be7d702
PE
1125 * dbusbind.c (signature_cat): New function.
1126 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1127 Do not overrun buffer; instead, report string overflow.
1128
9d1df220
PE
1129 * dispnew.c (add_window_display_history): Don't overrun buffer.
1130 Truncate instead; this is OK since it's just a log.
1131
33ef5c64
PE
1132 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1133 even if the time zone offset is outlandishly large.
1134 Don't mishandle offset == INT_MIN.
1135
66c6fdd5
PE
1136 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1137 when creating daemon; the previous buffer-overflow check was incorrect.
1138
d749b01b
PE
1139 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1140 which has the guts of the old verror function.
1141
b5cd1905
PE
1142 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1143 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1144
6e1a67fb
PE
1145 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1146 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1147 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1148 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1149 length of string rather than counting it via multiple sprintfs;
1150 that's simpler and more reliable.
c21721cc
PE
1151 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1152 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1153 sprintf, in case result does not fit in int.
1154
c57b67fc
PE
1155 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1156 (fontset_from_font): Print it.
1157
8a401434
PE
1158 * frame.c (tty_frame_count): Now printmax_t, not int.
1159 (make_terminal_frame, set_term_frame_name): Print it.
1160 (x_report_frame_params): In X, window IDs are unsigned long,
1161 not signed long, so print them as unsigned.
1162 (validate_x_resource_name): Check for implausibly long names,
1163 and don't assume name length fits in 'int'.
1164 (x_get_resource_string): Don't blindly alloca invocation name;
1165 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1166 not fit in int.
1167
6e1a67fb
PE
1168 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1169 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1170 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1171
0df02bf3
PE
1172 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1173 Use esprintf, not sprintf, in case result does not fit in int.
1174
48e30793
PE
1175 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1176 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1177 it as a large positive number.
1178 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1179 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1180
a66ff6d8
PE
1181 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1182 in case result does not fit in int.
1183
aca216ff
PE
1184 * print.c (float_to_string): Detect width overflow more reliably.
1185 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1186 buffer overrun. Don't assume list length fits in 'int'. Treat
1187 print length of 0 as 0, not as infinity; to be consistent with other
1188 uses of print length in this function. Don't overflow print length
1189 index. Don't assume hash table size fits in 'long', or that
1190 vectorlike size fits in 'unsigned long'.
1191
31c286f7
PE
1192 * process.c (make_process): Use printmax_t, not int, to format
1193 process-name gensyms.
1194
55e5faa1
PE
1195 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1196
80f2e268
PE
1197 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1198 to avoid potential buffer overrun.
1199
670741ab
PE
1200 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1201 if X resource line is longer than 512 bytes.
1202
b7163a50
PE
1203 * xfns.c (x_window): Make sprintf buffer a bit bigger
1204 to avoid potential buffer overrun.
1205
ae58ff1f
PE
1206 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1207
c43c8a6a
PE
1208 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1209
3f8236f4
PE
12102011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1211
53e9fe90 1212 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1213 Without these, Emacs silently mishandles large integers sometimes.
1214 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1215 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1216
6511acf2
PE
1217 * xdisp.c (try_window_id): Check Emacs fixnum range before
1218 converting to 'int'.
806add1d 1219
6511acf2 1220 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1221 Check that an Emacs fixnum is in range before assigning it to 'int'.
1222 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1223 values converted from Emacs fixnums.
1224 (Frecenter): Don't wrap around a line count if it is out of 'int'
1225 range; instead, treat it as an extreme value.
1226 (Fset_window_configuration, compare_window_configurations):
1227 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1228
6511acf2
PE
1229 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1230 that can exceed INT_MAX. Check that EMACS_INT value is in range
1231 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1232 (match_limit): Don't assume that a fixnum can fit in 'int'.
1233
6511acf2 1234 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1235 exceed INT_MAX.
1236
6511acf2 1237 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1238 (Fvertical_motion): Don't wrap around LINES values that don't fit
1239 in 'int'. Instead, treat them as extreme values. This is good
1240 enough for windows, which can't have more than INT_MAX lines anyway.
1241
fcb901a7
LMI
12422011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1243
0f2f6b6d
LMI
1244 * Require libxml/parser.h to avoid compilation warning.
1245
fcb901a7
LMI
1246 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1247
1248 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1249 since this reportedly can destroy thread storage.
1250
6e20a0d4
CY
12512011-08-30 Chong Yidong <cyd@stupidchicken.com>
1252
1253 * syntax.c (find_defun_start): Update all cache variables if
1254 exiting early (Bug#9401).
1255
148ae00e
EZ
12562011-08-30 Eli Zaretskii <eliz@gnu.org>
1257
f6cfbd8f
EZ
1258 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1259
148ae00e
EZ
1260 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1261 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1262 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1263
1264 * term.c (tty_append_glyph): New function.
1265 (produce_stretch_glyph): Static function and its prototype deleted.
1266
a66cfb1c
SM
1267 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1268 Add prototypes.
148ae00e 1269
c4a07a4c
PE
12702011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1273 when checking :margin (Bug#9390).
1274 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1275 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1276 so that the name doesn't mislead. All uses changed.
1277
6bc8cd65
JB
12782011-08-28 Johan Bockgård <bojohan@gnu.org>
1279
1280 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1281 set_tty_hooks.
1282
dca4927e
EZ
12832011-08-27 Eli Zaretskii <eliz@gnu.org>
1284
1285 * xdisp.c (move_it_to): Don't bail out early when reaching
1286 position beyond to_charpos, if we are scanning backwards.
1287 (move_it_vertically_backward): When DY == 0, make sure we get to
1288 the first character in the line after the newline.
1289
f2cad773
PE
12902011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1293 (ccl_driver): Do not generate an out-of-range pointer.
1294 (Fccl_execute_on_string): Remove unnecessary check for
1295 integer overflow, noted by Stefan Monnier in
1296 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1297 Remove a FIXME that didn't need fixing.
1298 Simplify the newly-introduced buffer reallocation code.
1299
0cae2cdb
JB
13002011-08-27 Juanma Barranquero <lekktu@gmail.com>
1301
1302 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1303
5fc295a4 13042011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1305
70c60eb2 1306 Integer and memory overflow issues (Bug#9196).
726e0ab1 1307
d31850da
PE
1308 * doc.c (get_doc_string): Rework so that
1309 get_doc_string_buffer_size is the actual buffer size, rather than
1310 being 1 less than the actual buffer size; this makes xpalloc more
1311 convenient.
1312
a69fbedb
PE
1313 * image.c (x_allocate_bitmap_record, cache_image):
1314 * xselect.c (Fx_register_dnd_atom):
1315 Simplify previous changes by using xpalloc.
1316
fe5c5d37
PE
1317 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1318 since either will do and ptrdiff_t is convenient with xpalloc.
1319
0065d054
PE
1320 * charset.c (charset_table_size)
1321 (struct charset_sort_data.priority): Now ptrdiff_t.
1322 (charset_compare): Don't overflow if priorities differ greatly.
1323 (Fsort_charsets): Don't assume list length fits in int.
1324 Check for size-calculation overflow when allocating sort data.
1325 (syms_of_charset): Allocate an initial charset table that is
1326 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1327
1328 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1329
1330 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1331 The actual value is always <= INT_MAX, and leaving it unsigned made
1332 overflow checking harder.
1333
1334 * dispextern.h (struct glyph_matrix.rows_allocated)
1335 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1336 with xpalloc. The values are still always <= INT_MAX.
1337
1338 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1339
1340 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1341 (SAFE_NALLOCA): New macro.
1342
1343 * region-cache.c (struct boundary.pos, find_cache_boundary)
1344 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1345 (set_cache_region, invalidate_region_cache)
1346 (revalidate_region_cache, know_region_cache, region_cache_forward)
1347 (region_cache_backward, pp_cache):
1348 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1349 so that ptrdiff_t * can be passed to xpalloc.
1350 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1351 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1352 (pp_cache): Don't assume cache_len fits in int.
1353 * region-cache.h: Adjust extern decls to match.
1354
1355 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1356 EMACS_INT, since either will do, for xpalloc.
1357
1358 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1359 (xnmalloc, xnrealloc, xpalloc): New functions.
1360
726e0ab1
PE
1361 * bidi.c (bidi_shelve_header_size): New constant.
1362 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1363 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1364
51f30bc5 1365 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1366 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1367 (overlay_strings):
1368 Don't update size of array until after memory allocation succeeds,
1369 because xmalloc/xrealloc may not return.
0065d054
PE
1370 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1371 now that we have proper integer overflow checking.
1372 (record_overlay_string, overlay_strings): Catch overflows when
1373 calculating size of overlay_str_buf.
726e0ab1 1374
0065d054
PE
1375 * callproc.c (Fcall_process): Check for size overflow when
1376 calculating size of args2.
1377 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1378 Normally we prefer signed values, but sticking with ptrdiff_t would
1379 require adding more-complicated checks.
726e0ab1
PE
1380
1381 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1382 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1383 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1384 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1385
1386 * character.c (Fstring): Check for size-calculation overflow.
1387
1388 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1389 unnecessary integer overflow. Check for size overflow.
1390 (encode_coding_object): Don't update size until xmalloc succeeds.
1391
1392 * composite.c (get_composition_id): Check for overflow in glyph
1393 length calculations.
1394
1395 Integer and memory overflow fixes for display code.
1396 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1397 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1398 (scrolling_window): Check for overflow in size calculations.
1399 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1400 Don't assume glyph table len fits in int.
1401 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1402 (row_table_size): Now ptrdiff_t, not int.
1403 (scrolling_window): Avoid overflow in size calculations.
1404 Don't update size until allocation succeeds.
1405 * fns.c (concat): Check for overflow in size calculations.
1406 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1407 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1408 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1409
1410 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1411 (get_doc_string): Check for size calculation overflow.
1412 Don't update size until allocation succeeds.
1413 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1414 EMACS_INT, where ptrdiff_t will do.
1415 (Fsubstitute_command_keys): Check for string overflow.
1416
1417 * editfns.c (set_time_zone_rule): Don't assume environment length
1418 fits in int.
1419 (message_length): Now ptrdiff_t, not int.
1420 (Fmessage_box): Don't update size until allocation succeeds.
1421 Don't assume message length fits in int.
1422 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1423
0065d054
PE
1424 * emacs.c (main): Do not reallocate argv, since there is a null at
1425 the end that can be overwritten, and this way there's no need to
1426 worry about size-calculation overflow.
1427 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1428
1429 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1430 alloc succeeds.
1431 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1432
1433 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1434 (x_set_scroll_bar_width, x_figure_window_size):
1435 Check for integer overflow.
1436 (x_set_alpha): Do not assume XINT fits in int.
1437
1438 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1439 This is for the members text_lines, text_cols, total_lines, total_cols,
1440 where the system imposes an 'int' limit.
1441
1442 * fringe.c (Fdefine_fringe_bitmap):
1443 Don't update size until alloc works.
1444
1445 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1446 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1447
1448 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1449 Check for size-calculation overflow.
1450 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1451 do, as we prefer signed integers.
1452 (id_to_widget.max_size, id_to_widget.used)
1453 (xg_store_widget_in_map, xg_remove_widget_from_map)
1454 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1455 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1456 Use and return ptrdiff_t, not int.
1457 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1458 * gtkutil.h: Change prototypes to match the above.
1459
1460 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1461 are duplicate now that they've been promoted to lisp.h.
1462 (x_allocate_bitmap_record, x_alloc_image_color)
1463 (make_image_cache, cache_image, xpm_load):
1464 Don't update size until alloc is done.
1465 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1466 (x_detect_edges):
3256efce 1467 Check for size calculation overflow.
726e0ab1
PE
1468 (ct_colors_allocated_max): New constant.
1469 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1470 overflow.
3256efce 1471
726e0ab1
PE
1472 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1473 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1474 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1475 Use ptrdiff_t, not int, to count maps.
1476 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1477 calculations. Don't update size until allocation succeeds.
1478 Redo calculations to avoid overflow.
726e0ab1
PE
1479 * keyboard.h: Change prototypes to match the above.
1480
1481 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1482 to count maps.
1483 (current_minor_maps): Check for size calculation overflow.
1484 * keymap.h: Change prototypes to match the above.
1485
1486 * lread.c (read1, init_obarray): Don't update size until alloc done.
1487
1488 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1489 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1490
726e0ab1
PE
1491 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1492 Now ptrdiff_t, not int.
1493 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1494 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1495
1496 * process.c (Fnetwork_interface_list): Check for overflow
1497 in size calculation.
1498
1499 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1500
1501 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1502 overflow. Don't bother calling xmalloc when xrealloc will do.
1503
1504 * search.c (Freplace_match): Check for size calculation overflow.
1505 (Fset_match_data): Don't assume list lengths fit in 'int'.
1506
1507 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1508 for command line length. Do not attempt to address one before the
1509 beginning of an array, as that's not portable.
1510
1511 * term.c (max_frame_lines): Remove; unused.
1512 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1513 not int.
1514 (encode_terminal_code, calculate_costs): Check for size
1515 calculation overflow.
1516 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1517 table lengths and related sizes. Don't update size until alloc
1518 done. Redo calculations to avoid overflow.
1519 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1520
1521 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1522 subtracting pointers.
1523 (gobble_line): Check for overflow more carefully. Don't update size
1524 until alloc done.
1525
1526 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1527 Don't update size until alloc done.
1528 Redo size calculations to avoid overflow.
1529 Check for size calculation overflow.
0065d054 1530 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1531
1532 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1533 Use ptrdiff_t, not int, for sizes.
1534 (store_mode_line_noprop_char): Don't update size until alloc done.
1535
0065d054
PE
1536 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1537 Use ptrdiff_t, not int, for sizes.
1538 (Finternal_make_lisp_face, cache_face):
1539 Check for size calculation overflow.
1540 (cache_face): Treat size calculation overflows as if they were
1541 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1542
1543 * xfns.c (x_encode_text, x_set_name_internal)
1544 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1545 sizes, since they can exceed INT_MAX in size. Check for size
1546 calculation overflow.
1547
0065d054
PE
1548 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1549 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1550 Don't update size until alloc done.
1551
0065d054 1552 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1553 as sprintf is limited to int lengths.
1d526e2f 1554
252c5ee1
PE
1555 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1556 (X_LONG_MIN): New macros.
864d7ce7
PE
1557 Use them to make the following changes clearer.
1558 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1559 This change doesn't affect the value now, but it may help remind
1560 future maintainers not to raise the value too much later.
1561 (SELECTION_QUANTUM): Remove, replacing with ...
1562 (selection_quantum): ... new function, which avoids overflow.
1563 All uses changed.
1564 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1565 assumption that selection length fits in 'int'.
1566 (x_reply_selection_request, x_handle_selection_request)
1567 (x_get_window_property, receive_incremental_selection)
1568 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1569 (lisp_data_to_selection_data, clean_local_selection_data):
1570 Use ptrdiff_t, not int, to record length of selection.
1571 (x_reply_selection_request, x_get_window_property)
1572 (receive_incremental_selection, x_property_data_to_lisp):
1573 Redo calculations to avoid overflow.
1574 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1575 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1576 something.
1577 (x_get_window_property, receive_incremental_selection)
1578 (lisp_data_to_selection_data, x_property_data_to_lisp):
1579 Check for size-calculation overflow.
1580 (x_get_window_property, receive_incremental_selection)
1581 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1582 Don't store size until memory allocation succeeds.
1583 (x_get_window_property): Plug memory leak on memory exhaustion.
1584 Don't double-block input; malloc is safe here. Don't assume 2**34
1585 - 4 fits in unsigned long. Add an xassert to check
1586 XGetWindowProperty overflow. Be more careful about overflow
1587 calculations, and distinguish size from memory overflow better.
1588 (receive_incremental_selection): When tracing, don't assume
1589 unsigned int is less than INT_MAX.
1590 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1591 harmful) conversions of unsigned short to int.
1592 (lisp_data_to_selection_data): Don't assume that integers
1593 in the range -65535 through -1 fit in an X unsigned short.
1594 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1595 result parameters unless successful. Rely on cons_to_unsigned
1596 to report problems with elements; the old code wasn't right anyway.
1597 (x_check_property_data): Check for int overflow; we cannot use
1598 a wider type due to X limits.
1599 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1600
726e0ab1 1601 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1602
0065d054
PE
1603 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1604 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1605 (x_color_cells): Don't store size until memory allocation succeeds.
1606 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1607 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1608 (x_term_init): Don't assume length fits in int (sprintf is limited
1609 to int size).
bc18e09d 1610
ebfa62c0
PE
1611 Use ptrdiff_t for composition IDs.
1612 * character.c (lisp_string_width):
1613 * composite.c (composition_table_size, n_compositions)
1614 (get_composition_id, composition_gstring_from_id):
1615 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1616 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1617 * window.c (Frecenter):
1618 Use ptrdiff_t, not int, for composition IDs.
1619 * composite.c (get_composition_id): Check for integer overflow.
1620 * composite.h: Adjust prototypes to match the above changes.
1621
d3411f89
PE
1622 Use ptrdiff_t for hash table indexes.
1623 * category.c (hash_get_category_set):
1624 * ccl.c (ccl_driver):
1625 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1626 * coding.c (coding_system_charset_list, detect_coding_system):
1627 * coding.h (struct coding_system.id):
1628 * composite.c (get_composition_id, gstring_lookup_cache):
1629 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1630 * image.c (xpm_get_color_table_h):
1631 * lisp.h (hash_lookup, hash_put):
1632 * minibuf.c (Ftest_completion):
1633 Use ptrdiff_t for hash table indexes, not int (which is too
1634 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1635 32-bit --with-wide-int hosts).
1636
e097a6fa
PE
1637 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1638 Add a FIXME comment about memory leaks.
1639 (syms_of_charset): Don't assume xmalloc returns.
1640
5637687f
PE
1641 Don't assume that stated character widths fit in int.
1642 * character.c (Fchar_width, c_string_width, lisp_string_width):
1643 * character.h (CHAR_WIDTH):
1644 * indent.c (MULTIBYTE_BYTES_WIDTH):
1645 Use sanitize_char_width to avoid undefined and/or bad behavior
1646 with outlandish widths.
a66cfb1c 1647 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1648 now that we have two such functions. All uses changed.
1649 (sanitize_char_width): New inline function.
1650
a2271ba2
PE
1651 Don't assume that tab-width fits in int.
1652 * character.h (sanitize_width): New inline function.
1653 (SANE_TAB_WIDTH): New macro.
1654 (ASCII_CHAR_WIDTH): Use it.
1655 * indent.c (sane_tab_width): Remove. All uses replaced by
1656 SANE_TAB_WIDTH (current_buffer).
1657 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1658
18c52557
PE
1659 * fileio.c: Integer overflow issues with file modes.
1660 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1661
caeeedc1
PE
1662 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1663 Remove unreachable code.
1664 (read_hex, load_charset_map_from_file): Check for integer overflow.
1665
50849c52
PE
1666 * xterm.c: don't go over XClientMessageEvent limit
1667 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1668 (x_send_scroll_bar_event): Likewise. Check that the size does not
1669 exceed limits imposed by XClientMessageEvent, as well as the usual
1670 ptrdiff_t and size_t limits.
1671
b13995db
PE
1672 * keyboard.c: Overflow, signedness and related fixes.
1673 (make_lispy_movement): Use same integer type in forward decl
1674 that is used in the definition.
1675 (read_key_sequence, keyremap_step):
1676 Change bufsize argument back to int, undoing my 2011-03-30 change.
1677 We prefer signed types, and int is wide enough here.
1678 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1679 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1680 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1681 length, not size_t. Use ptrdiff_t for index, not int.
1682 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1683 possibility of integer overflow.
1684
13464394
PE
1685 Overflow, signedness and related fixes for images.
1686
1687 * dispextern.h (struct it.stack[0].u.image.image_id)
1688 (struct_it.image_id, struct image.id, struct image_cache.size)
1689 (struct image_cache.used, struct image_cache.ref_count):
1690 * gtkutil.c (update_frame_tool_bar):
1691 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1692 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1693 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1694 * nsmenu.m (update_frame_tool_bar):
1695 * xdisp.c (calc_pixel_width_or_height):
1696 * xfns.c (image_cache_refcount):
1697 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1698 on typical 64-bit hosts.
1699
1700 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1701 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1702 Omit unnecessary casts to int.
1703 (parse_image_spec): Check that integers fall into 'int' range
1704 when the callers expect that.
1705 (image_ascent): Redo ascent calculation to avoid int overflow.
1706 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1707 (lookup_image): Remove unnecessary tests.
1708 (xbm_image_p): Locals are now of int, not EMACS_INT,
1709 since parse_image_check makes sure they fit into int.
1710 (png_load, gif_load, svg_load_image):
1711 Prefer int to unsigned where either will do.
1712 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1713 old tiff_error_handler and tiff_warning_handler.
1714 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1715 stack buffer overflows. It uses only the features of vsnprintf
1716 that are common to both POSIX and native Microsoft.
1717 (tiff_error_handler, tiff_warning_handler): Use it.
1718 (tiff_load, gif_load, imagemagick_load_image):
1719 Don't assume :index value fits in 'int'.
1720 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1721 (imagemagick_load_image): Check that crop parameters fit into
1722 the integer types that MagickCropImage accepts. Don't assume
1723 Vimagemagick_render_type has a nonnegative value. Don't assume
1724 size_t fits in 'long'.
1725 (gs_load): Use printmax_t to print the widest integers possible.
1726 Check for integer overflow when computing image height and width.
1727
c11821d4
EZ
17282011-08-26 Eli Zaretskii <eliz@gnu.org>
1729
1730 * xdisp.c (redisplay_window): Don't force window start if point
1731 will be invisible in the resulting window. (Bug#9324)
1732
0c95fcf7
EZ
17332011-08-25 Eli Zaretskii <eliz@gnu.org>
1734
1735 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1736 the display spec is of the form `(space ...)'.
1737 (handle_display_spec): Return the value returned by
1738 handle_single_display_spec, not just 1 or zero.
1739 (handle_single_display_spec): If the display spec is of the form
1740 `(space ...)', and specifies display in the text area, return 2
1741 rather than 1.
fee65a97 1742 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1743 accurately, and prefer exact match for point under bidi.
1744 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1745
1746 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1747 into disp_prop; all users changed.
1748
1749 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1750 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1751 for the text covered by the display property.
1752
e4ed06f1
CY
17532011-08-25 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1756 Change return value to nil.
1757 (Frecord_buffer): Delete unused function.
1758
f67cdd7f
EZ
17592011-08-24 Eli Zaretskii <eliz@gnu.org>
1760
5980d4c6
EZ
1761 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1762 buffers, return left-to-right.
8610fe8b
EZ
1763 (set_cursor_from_row): Consider candidate row a win if its glyph
1764 represents a newline and point is on that newline. Fixes cursor
1765 positioning on the newline at EOL of R2L text within L2R
1766 paragraph, and vice versa.
1767 (try_cursor_movement): Check continued rows, in addition to
1768 continuation rows. Fixes unwarranted scroll when point enters a
1769 continued line of R2L text within an L2R paragraph, or vice versa.
1770 (cursor_row_p): Consider the case of point being equal to
1771 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1772 from the end of a short line to the beginning of a continued line
1773 of R2L text within L2R paragraph.
1774 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1775 composed characters.
5980d4c6 1776
f67cdd7f
EZ
1777 * bidi.c (bidi_check_type): Use xassert.
1778 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1779 members.
1780
bca633fb
EZ
17812011-08-23 Eli Zaretskii <eliz@gnu.org>
1782
1783 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1784 a character.
1785
4a5885a7
CY
17862011-08-23 Chong Yidong <cyd@stupidchicken.com>
1787
1788 * nsfont.m (ns_otf_to_script): Fix typo.
1789
0902a04e
KH
17902011-08-22 Kenichi Handa <handa@m17n.org>
1791
1792 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1793 extra slot even if the purpose is char-code-property-table.
1794
1a2e6670
EZ
17952011-08-23 Eli Zaretskii <eliz@gnu.org>
1796
8ddde651
EZ
1797 * xdisp.c (redisplay_window): When computing centering_position,
1798 account for the height of the header line. (Bug#8874)
1799
425cc014
EZ
1800 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1801 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1802 candidate is selected by the mouse, and that candidate has a
1803 composed character under the mouse.
1804
1a2e6670
EZ
1805 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1806 coordinates reported by pos-visible-in-window-p for a composed
1807 character in column zero.
1808
8b76d6f8
SM
18092011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1810
1811 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1812
dac347dd
EZ
18132011-08-22 Eli Zaretskii <eliz@gnu.org>
1814
1815 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1816 consider it a hit if to_charpos is anywhere in the range of the
1817 composed buffer positions.
1818
e013fb34
CY
18192011-08-22 Chong Yidong <cyd@stupidchicken.com>
1820
1821 * image.c (gif_load): Don't assume that each subimage has the same
1822 dimensions as the base image. Handle disposal method that is
1823 "undefined" by the gif spec (Bug#9335).
1824
bd1ba3e8
CY
18252011-08-20 Chong Yidong <cyd@stupidchicken.com>
1826
1827 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1828 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1829
54a1215b
EZ
18302011-08-19 Eli Zaretskii <eliz@gnu.org>
1831
823564e5
EZ
1832 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1833 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1834 from an Org mode buffer to a Speedbar frame.
1835
54a1215b
EZ
1836 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1837 a composition, take its buffer position from IT->cmp_it.charpos.
1838 Fixes cursor positioning at the beginning of a line that begins
1839 with a composed character.
1840
9778ebcc
EZ
18412011-08-18 Eli Zaretskii <eliz@gnu.org>
1842
0be6ee06
EZ
1843 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1844 character bidirectional type, use STRONG_L instead. Fixes crashes
1845 in a buffer produced by `describe-categories'.
1846
9778ebcc
EZ
1847 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1848 members before the level stack, so they would be saved and
1849 restored when copying iterator state. Fixes incorrect reordering
1850 around TABs covered by display properties.
1851
156bffbe
AS
18522011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1853
6b02f655 1854 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1855
72ad093b
CY
18562011-08-17 Chong Yidong <cyd@stupidchicken.com>
1857
1858 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1859 (internal_condition_case_2, internal_condition_case_n):
1860 Remove unnecessary aborts (Bug#9081).
72ad093b 1861
35774242
EZ
18622011-08-17 Eli Zaretskii <eliz@gnu.org>
1863
1864 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1865 has no `load' handler, try opening the file locally. (Bug#9311)
1866
db76dd85
KB
18672011-08-16 Ken Brown <kbrown@cornell.edu>
1868
1869 * gmalloc.c: Expand comment.
1870
b215eee5
EZ
18712011-08-16 Eli Zaretskii <eliz@gnu.org>
1872
1873 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1874 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1875
a4579d33
KB
18762011-08-16 Ken Brown <kbrown@cornell.edu>
1877
1878 Fix memory allocation problems in Cygwin build (Bug#9273).
1879
1880 * unexcw.c ( __malloc_initialized): Declare external variable.
1881 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1882
8b76d6f8
SM
1883 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1884 New variables.
a4579d33
KB
1885 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1886 dumped emacs.
1887 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1888 in the static heap.
1889 [CYGWIN] (special_realloc): New function.
1890 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1891 requests to realloc storage in the static heap.
1892
3ebec551
PE
18932011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * bidi.c (bidi_initialize): Remove unused local.
1896
9fd8be00
EZ
18972011-08-15 Eli Zaretskii <eliz@gnu.org>
1898
6b02f655
SM
1899 * bidimirror.h:
1900 * biditype.h: Remove file.
1901 * makefile.w32-in ($(BLD)/bidi.$(O)):
1902 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1903
1904 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1905
1906 * chartab.c: Improve commentary for the uniprop_table API.
1907
32413314
EZ
1908 * bidi.c (bidi_paragraph_init): Support zero value of
1909 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1910 (bidi_initialize): Use uniprop_table instead of including
1911 biditype.h and bidimirror.h.
32413314 1912
9fd8be00
EZ
1913 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1914 coordinates of the iterator when restoring from ppos_it.
1915 (Bug#9296)
1916
5cf2b69b
KH
19172011-08-14 Kenichi Handa <handa@m17n.org>
1918
1919 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1920 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1921
daf17d00
EZ
19222011-08-14 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (move_it_in_display_line_to): Don't invoke
1925 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1926 ppos_it. Fixes vertical cursor motion when line beginning is
1927 covered by an image. (Bug#9296)
1928
08e3161a
JD
19292011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1930
1931 * nsterm.h (ns_run_ascript): Declare.
1932 (NSAPP_DATA2_RUNASSCRIPT): Define.
1933
1934 * nsfns.m (as_script, as_result, as_status): New static variables.
1935 (ns_run_ascript): New function.
5e617bc2 1936 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1937 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1938 the event loop. Get status from as_status (Bug#7276).
1939
1940 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1941 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1942 the event loop (Bug#7276).
1943
a3720aa2
AS
19442011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1945
1946 * gnutls.c (QCgnutls_bootprop_priority)
1947 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1948 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1949 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1950 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1951 (QCgnutls_bootprop_verify_hostname_error)
1952 (QCgnutls_bootprop_callbacks_verify): Rename from
1953 Qgnutls_bootprop_..., all uses changed.
1954
1955 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1956 uses changed.
1957
0a0d27fb
PE
19582011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1959
19d5c50c
PE
1960 * xfaces.c (Qframe_set_background_mode): Now static.
1961 * dispextern.h (Qframe_set_background_mode): Remove decl.
1962
0a0d27fb
PE
1963 * process.c (Fnetwork_interface_info): Declare local only if needed.
1964
377538cb
JD
19652011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1966
1967 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1968 (Fnetwork_interface_list): Allocate in increments of bytes instead
1969 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1970 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1971 sockaddr.
1972 (struct ifflag_def): notrailers is smart on OSX.
1973 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1974 Get hardware address with getifaddrs if available.
1975
08fff70c
EZ
19762011-08-12 Eli Zaretskii <eliz@gnu.org>
1977
1978 * xdisp.c (iterate_out_of_display_property): xassert that
1979 IT->position is set to within IT->object's boundaries. Break from
1980 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1981 when IT->position is set up wrongly due to some bug.
1982 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1983 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1984 entry. Force push_it to save on the stack the current
1985 buffer/string position, to be restored by pop_it. Fix flags in
1986 the iterator structure wrt the object coming from a display
1987 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1988 properties. (Bug#9284)
1989
7be1c708 19902011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1991
7be1c708
CY
1992 * fontset.c (fontset_get_font_group): Add proper type checks.
1993 (Bug#9172)
aac0c6e3 1994
7be1c708 19952011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1996
7be1c708
CY
1997 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1998 and LC_VERSION_MIN_MACOSX.
1999 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2000 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2001
97bb72a6
EZ
20022011-08-08 Eli Zaretskii <eliz@gnu.org>
2003
2004 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2005 no-display-properties-and-no-overlays under bidi display.
2006 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2007 properties and overlays.
97bb72a6 2008
d5617611
CY
20092011-08-08 Chong Yidong <cyd@stupidchicken.com>
2010
37e11a63
CY
2011 * editfns.c (Fset_time_zone_rule): Document relationship with the
2012 setenv function.
2013
d5617611
CY
2014 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2015 the font entity extracted from the cache (Bug#8109).
2016
58872834
CY
20172011-08-07 Chong Yidong <cyd@stupidchicken.com>
2018
2019 * composite.c (autocmp_chars): Don't reset point. That is done by
2020 restore_point_unwind (Bug#5984).
2021
75bfc667
JL
20222011-08-07 Juri Linkov <juri@jurta.org>
2023
2024 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2025 to show the arg `TIME' instead of `TIMEVAL'.
2026
d1410150
EZ
20272011-08-06 Eli Zaretskii <eliz@gnu.org>
2028
2029 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2030 display property strides EOL and includes a newline, as in
2031 longlines-mode. (Bug#9254)
75b771e4
EZ
2032 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2033 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2034
2035 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2036 is non-zero, even if the data buffer is NULL. Fixes a crash in
2037 vertical-motion with longlines-mode. (Bug#9254)
2038
35928349
EZ
20392011-08-05 Eli Zaretskii <eliz@gnu.org>
2040
ec7cc85b
EZ
2041 * bidi.c <bidi_cache_total_alloc>: Now static.
2042 (bidi_initialize): Initialize bidi_cache_total_alloc.
2043
8b76d6f8 2044 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2045 cache. (Bug#9221)
2046
2047 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2048 amount allocated this far in `bidi_cache_total_alloc'.
2049 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2050 non-zero, only free the data buffer without restoring the cache
2051 contents. All callers changed.
2052
2053 * dispextern.h (bidi_unshelve_cache): Update prototype.
2054
2055 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2056 (move_it_in_display_line, move_it_to)
2057 (move_it_vertically_backward, move_it_by_lines): Replace the call
2058 to xfree to an equivalent call to bidi_unshelve_cache.
2059 (move_it_in_display_line_to): Fix logic of returning
412b6358 2060 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2061
e2e2423b
EZ
20622011-08-05 Eli Zaretskii <eliz@gnu.org>
2063
2064 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2065 came from a string character with a `cursor' property. (Bug#9229)
2066
ae9e757a
JD
20672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2068
2069 * Makefile.in (LIB_PTHREAD): New variable.
2070 (LIBES): Add LIB_PTHREAD (Bug#9216).
2071
2072 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2073 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2074
213bd7f2
AS
20752011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2076
6b02f655 2077 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2078
99aaf75f
JD
20792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2080
2081 * xterm.c (x_find_topmost_parent): New function.
2082 (x_set_frame_alpha): Find topmost parent window with
2083 x_find_topmost_parent and set the property there also (bug#9181).
2084 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2085
c74e9d86
PE
20862011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2087
2088 * callproc.c (Fcall_process): Avoid vfork clobbering
2089 the local vars buffer, coding_systems, current_dir.
2090
640c8776
SM
20912011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2092
2093 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2094
f26d0e4c
PE
20952011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2096
8a10d76c
PE
2097 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2098 so that it is not optimized away.
2099
f26d0e4c
PE
2100 * xdisp.c (compute_display_string_pos): Remove unused local.
2101
55439c61
EZ
21022011-08-02 Eli Zaretskii <eliz@gnu.org>
2103
2104 Fix slow cursor motion and scrolling in large buffers with
2105 selective display, like Org Mode buffers. (Bug#9218)
2106
2107 * dispextern.h (struct bidi_it): New member disp_prop_p.
2108
2109 * xdisp.c: Remove one-slot cache of display string positions.
2110 (compute_display_string_pos): Accept an additional argument
5e617bc2 2111 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2112 for a display string or property. If found, set DISP_PROP_P
2113 non-zero.
2114
2115 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2116 DISP_PROP_P, and pass it to compute_display_string_pos.
2117 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2118 non-zero. All callers of bidi_fetch_char changed.
2119
fb33fa43
SM
21202011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2121
2122 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2123
b099e063
DM
21242010-12-03 Don March <don@ohspite.net>
2125
2126 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2127 last character M-[char] is translated to ESC [char] (bug#7541).
2128
5cc7f7af
KH
21292011-08-02 Kenichi Handa <handa@m17n.org>
2130
d0fffa3f 2131 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2132
2133 * chartab.c (uniprop_table): Make it non-static.
2134
525d5e6e
EZ
21352011-08-01 Eli Zaretskii <eliz@gnu.org>
2136
2137 * xdisp.c (forward_to_next_line_start): Accept additional argument
2138 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2139 on the newline.
2140 (reseat_at_next_visible_line_start): Use the bidi iterator state
2141 returned by forward_to_next_line_start to restore the state of
2142 it->bidi_it after backing up to previous newline. (Bug#9212)
2143
31011111
AS
21442011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2145
2146 * regex.c (re_comp): Protoize.
2147 (re_exec): Fix return type.
2148 (regexec): Fix type of `ret'. (Bug#9203)
2149
476371c4
PE
21502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2151
e5d76069
PE
2152 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2153 This is needed if max-image-size is a floating-point number.
2154
9a79b20c
AS
21552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2156
2157 * print.c (print_object): Print empty symbol as ##.
2158
2159 * lread.c (read1): Read ## as empty symbol.
2160
d8c2fa78
AA
21612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2162
2163 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2164 setting frame foreground color (Bug#9175).
2165 (x_set_background_color): Likewise.
2166
ffe57a7a
AA
2167 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2168 contents (Bug#9176).
2169 (EmacsTooltip -init): Remove bezels and add shadows to
2170 tooltip windows.
2171
bf3492a5
AA
2172 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2173 or scroll bar (Bug#8470).
2174
d55e9c53
AA
2175 * nsfont.m (nsfont_open): Remove assignment to voffset and
2176 unnecessary vars hshink, expand, hd, full_height, min_height.
2177 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2178
2179 * nsterm.h (nsfont_info): Remove voffset field.
2180
d8c2fa78 21812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2182
2183 Implement strike-through and overline on NextStep (Bug#8863).
2184
2185 * nsfont.m (nsfont_open): Use underline position provided by font,
2186 instead of hard-coded value of 2.
2187 (nsfont_draw): Call ns_draw_text_decoration instead.
2188
2189 * nsterm.h: Add declaration for ns_draw_text_decoration.
2190
2191 * nsterm.m (ns_draw_text_decoration): New function for drawing
2192 underline, overline, and strike-through.
2193 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2194 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2195 accommodate underlining, etc.
4843aac3 2196
4cc60b9b
EZ
21972011-07-28 Eli Zaretskii <eliz@gnu.org>
2198
bc7ece87
EZ
2199 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2200 default.
4cc60b9b 2201
476371c4
PE
22022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2203
66606eea
PE
2204 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2205 Without this fix, if a signal arrives just after memory fills up,
2206 'malloc' might be invoked reentrantly.
2207
476371c4
PE
2208 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2209 In other words, assume that every image size is allowed, on non-X
2210 hosts. This assumption is probably wrong, but it lets Emacs compile.
2211
f3fcc40d
AS
22122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2213
2214 * regex.c (re_iswctype): Convert return values to boolean.
2215
350c992f
EZ
22162011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2217
2218 * xdisp.c (compute_display_string_pos): Don't use cached display
2219 string position if the buffer had its restriction changed.
2220 (Bug#9184)
2221
5266b4bb
PE
22222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2223
2224 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2225
2573a837 22262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2227
41f55ccd 2228 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2229
39e378da
PE
2230 * bidi.c: Integer size and overflow fixes.
2231 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2232 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2233 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2234 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2235 (bidi_find_other_level_edge):
2236 Use ptrdiff_t instead of EMACS_INT where either will do.
2237 This works better on 32-bit hosts configured --with-wide-int.
2238 (bidi_cache_ensure_space): Check for size-calculation overflow.
2239 Use % rather than repeated addition, for better worst-case speed.
2240 Don't set bidi_cache_size until after xrealloc returns, because it
2241 might not return.
2242 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2243 (bidi_cache_ensure_space): Also check that the bidi cache size
2244 does not exceed that of the largest Lisp string or buffer. See Eli
2245 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2246
5e927815
PE
2247 * alloc.c (__malloc_size_t): Remove.
2248 All uses replaced by size_t. See Andreas Schwab's note
2249 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2250
ca4aa935
PE
2251 * image.c: Improve checking for integer overflow.
2252 (check_image_size): Assume that f is nonnull, since
2253 it is always nonnull in practice. This is one less thing to
2254 worry about when checking for integer overflow later.
2255 (x_check_image_size): New function, which checks for integer
2256 overflow issues inside X.
2257 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2258 This removes the need for a memory_full check.
2259 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2260 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2261 (xbm_read_bitmap_data): Change locals back to 'int', since
2262 their values must fit in 'int'.
2263 (xpm_load_image, png_load, tiff_load):
2264 Invoke x_create_x_image_and_pixmap earlier,
2265 to avoid much needless work if the image is too large.
2266 (tiff_load): Treat overly large images as if
2267 x_create_x_image_and_pixmap failed, not as malloc failures.
2268 (gs_load): Use x_check_image_size.
2269
5f8f9cc2
PE
2270 * gtkutil.c: Omit integer casts.
2271 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2272 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2273
5adf60bc
PE
2274 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2275
c8907a93
PE
2276 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2277 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2278 would wrongly return t on a 64-bit host.
2279
e3c25c68
PE
2280 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2281 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2282 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2283 and therefore cause GCC to emit a bogus diagnostic in some cases.
2284
3f791afe
PE
2285 * image.c: Integer signedness and overflow and related fixes.
2286 This is not an exhaustive set of fixes, but it's time to
2287 record what I've got.
2288 (lookup_pixel_color, check_image_size): Remove redundant decls.
2289 (check_image_size): Don't assume that arbitrary EMACS_INT values
2290 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2291 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2292 (tiff_load, imagemagick_load_image):
2293 Check for overflow in size calculations.
2294 (x_create_x_image_and_pixmap): Remove unnecessary test for
2295 xmalloc returning NULL; that can't happen.
2296 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2297 (xpm_color_bucket): Use better integer hashing function.
2298 (xpm_cache_color): Don't possibly over-allocate memory.
2299 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2300 (gif_memory_source):
2301 Use ptrdiff_t, not int or size_t, to record sizes.
2302 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2303 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2304 either works, as we prefer signed integers.
2305 (tiff_read_from_memory, tiff_write_from_memory):
2306 Return tsize_t, not size_t, since that's what the TIFF API wants.
2307 (tiff_read_from_memory): Don't fail simply because the read would
2308 go past EOF; instead, return a short read.
2309 (tiff_load): Omit no-longer-needed casts.
2310 (Fimagemagick_types): Don't assume size fits into 'int'.
2311
3cc5a532
PE
2312 Improve hashing quality when configured --with-wide-int.
2313 * fns.c (hash_string): New function, taken from sxhash_string.
2314 Do not discard information about ASCII character case; this
2315 discarding is no longer needed.
2316 (sxhash-string): Use it. Change sig to match it. Caller changed.
2317 * lisp.h: Declare it.
2318 * lread.c (hash_string): Remove, since we now use fns.c's version.
2319 The fns.c version returns a wider integer if --with-wide-int is
2320 specified, so this should help the quality of the hashing a bit.
2321
b312a492
PE
2322 * emacs.c: Integer overflow minor fix.
2323 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2324 Define only if GNU_LINUX.
2325 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2326
dfd153ae
PE
2327 * dispnew.c: Integer signedness and overflow fixes.
2328 Remove unnecessary forward decls, that were a maintenance hassle.
2329 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2330 All uses changed.
2331 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2332 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2333 (prepare_desired_row, line_draw_cost):
2334 Use int, not unsigned, where either works.
2335 (save_current_matrix, restore_current_matrix):
2336 Use ptrdiff_t, not size_t, where either works.
2337 (init_display): Check for overflow more accurately, and without
2338 relying on undefined behavior.
2339
a81d11a3
PE
2340 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2341 Remove, replacing with the new symbols in lisp.h. All uses changed.
2342 * fileio.c (make_temp_name):
2343 * filelock.c (lock_file_1, lock_file):
2344 * xdisp.c (message_dolog):
2345 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2346 Use pMd etc. instead.
2347 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2348 replacing the pWIDE etc. symbols removed from editfns.c.
2349
3300e6fd
PE
2350 * keyboard.h (num_input_events): Now uintmax_t.
2351 This is (very slightly) less likely to mess up due to wraparound.
2352 All uses changed.
2353
fd05c7e9
PE
2354 * buffer.c: Integer signedness fixes.
2355 (alloc_buffer_text, enlarge_buffer_text):
2356 Use ptrdiff_t rather than size_t when either will do, as we prefer
2357 signed integers.
2358
903fe15d
PE
2359 * alloc.c: Integer signedness and overflow fixes.
2360 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2361 (__malloc_size_t): Default to size_t, not to int.
2362 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2363 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2364 Prefer ptrdiff_t to size_t when either would do, as we prefer
2365 signed integers.
2366 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2367 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2368 Now const. Initialize with values that are in range even if char
2369 is signed.
2370 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2371 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2372 These functions do the right thing with sizes > 2**32.
2373 (check_depth): Now ptrdiff_t, not int.
2374 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2375 Adjust to new way of storing sizes. Check for size overflow bugs
2376 in rest of code.
2377 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2378 slightly wrong anyway, as it missed one instance of
2379 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2380 (refill_memory_reserve): Omit needless cast to size_t.
2381 (mark_object_loop_halt): Mark as externally visible.
2382
ac82cc6a
PE
2383 * xselect.c: Integer signedness and overflow fixes.
2384 (Fx_register_dnd_atom, x_handle_dnd_message):
2385 Use ptrdiff_t, not size_t, since we prefer signed.
2386 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2387 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2388 x_dnd_atoms_size and x_dnd_atoms_length.
2389
c2d1e36d
PE
2390 * doprnt.c: Prefer signed to unsigned when either works.
2391 * eval.c (verror):
2392 * doprnt.c (doprnt):
2393 * lisp.h (doprnt):
2394 * xdisp.c (vmessage):
2395 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2396 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2397 prefer signed arithmetic to avoid comparison confusion.
2398 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2399 but is a bit tricky.
2400
0e926e56
PE
2401 Assume freestanding C89 headers, string.h, stdlib.h.
2402 * data.c, doprnt.c, floatfns.c, print.c:
2403 Include float.h unconditionally.
2404 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2405 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2406 * regex.c: Likewise for stddef.h, string.h.
2407 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2408 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2409 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2410 (STDC_HEADERS): Remove obsolete defines.
2411 * sysdep.c: Include limits.h unconditionally.
2412
9cfdb3ec
PE
2413 Assume support for memcmp, memcpy, memmove, memset.
2414 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2415 * regex.c (memcmp, memcpy):
2416 Remove; we assume C89 now.
2417
2418 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2419 (__malloc_safe_bcopy): Remove; no longer needed.
2420
cf950e6b 2421 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2422 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2423 well either way, and we prefer signed to unsigned.
2424
dbf38e02
LMI
24252011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2426
2427 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2428 closes the connection while we're reading (bug#9182).
2429
d6f0886c 24302011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2431
d6f0886c
JD
2432 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2433 are specified (Bug#9168).
24e0f6b1 2434
2eb1f9e6
PE
24352011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2438 Found by GCC static checking and --with-wide-int on a 32-bit host.
2439
22381272 24402011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2441
2442 * xdisp.c (compute_display_string_pos): Fix logic of caching
2443 previous display string position. Initialize cached_prev_pos to
2444 -1. Fixes slow-down at the beginning of a buffer.
2445
f25e39b4
EZ
24462011-07-24 Eli Zaretskii <eliz@gnu.org>
2447
2448 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2449 for attrs[LFACE_FONTSET_INDEX].
2450
04c4b52e
PE
24512011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 * xml.c (parse_region): Remove unused local
2454 that was recently introduced.
2455
c1734fbd
EZ
24562011-07-23 Eli Zaretskii <eliz@gnu.org>
2457
be18c5a5
EZ
2458 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2459 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2460
c1734fbd
EZ
2461 * xdisp.c (move_it_in_display_line_to): Record the best matching
2462 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2463 exit if none of the characters scanned was an exact match.
2464 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2465 when exact match is impossible due to invisible text, and the
2466 lines are truncated.
2467
a258d627
JD
24682011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2469
2470 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2471 for OSX >= 10.7.
2472
b6d5a689
EZ
24732011-07-22 Eli Zaretskii <eliz@gnu.org>
2474
0f74f785
EZ
2475 Fix a significant slow-down of cursor motion with C-n, C-p,
2476 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2477 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2478 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2479 (next_element_from_buffer): Call compute_stop_pos_backwards to
2480 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2481 base_level_stop.
2482 (reseat): Don't look for prev_stop, as that could mean a very long
2483 run.
2484 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2485 <cached_disp_overlay_modiff>: Cache for last found display string
2486 position.
551918c1 2487 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2488 about the same buffer in the same area of character positions, and
2489 the buffer wasn't changed since the time the display string
2490 position was cached.
551918c1 2491
b2d0c91a
EZ
24922011-07-22 Eli Zaretskii <eliz@gnu.org>
2493
2494 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2495 is an integer, which is important for empty lines. (Bug#9149)
2496
043604ee
CY
24972011-07-22 Chong Yidong <cyd@stupidchicken.com>
2498
2499 * frame.c (Fmodify_frame_parameters): In tty case, update the
2500 default face if necessary (Bug#4238).
2501
da4adb04
CY
25022011-07-21 Chong Yidong <cyd@stupidchicken.com>
2503
2504 * editfns.c (Fstring_to_char): No need to explain what a character
2505 is in the docstring (Bug#6576).
2506
9abd0532
LMI
25072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2508
2509 * xml.c (parse_region): Make sure we always return a tree.
2510
36881d16
HK
25112011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2512
2513 * xml.c (parse_region): If a document contains only comments,
2514 return that, too.
2515
1e98674d
LMI
25162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2517
2518 * xml.c (make_dom): Return comments, too.
2519
590bd467
PE
25202011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 Port to OpenBSD.
2523 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2524 and the surrounding thread.
2525 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2526 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2527 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2528 timer goes off.
2529 * s/openbsd.h (BROKEN_SIGIO): Define.
2530 * unexelf.c (unexec) [__OpenBSD__]:
2531 Don't update the .mdebug section of the Alpha COFF symbol table.
2532
f41628b2
LMI
25332011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2534
2535 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2536 (bug#8460).
2537
b59b67c5
PE
25382011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2539
15e3a074
PE
2540 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2541 This fixes some race conditions on the permissions of any newly
2542 created file.
2543
41bed37d
PE
2544 * alloc.c (valid_pointer_p): Use pipe, not open.
2545 This fixes some permissions issues when debugging.
2546
b59b67c5
PE
2547 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2548 If fchown fails to set both uid and gid, try to set just gid,
2549 as that is sometimes allowed. Adjust the file's mode to eliminate
2550 setuid or setgid bits that are inappropriate if fchown fails.
2551
925a6be7
SM
25522011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2553
2554 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2555 to compare Lisp_Objects.
2556 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2557 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2558 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2559
52968808
AS
25602011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2561
0a6a104b
AS
2562 * lread.c (read_integer): Unread even EOF character.
2563 (read1): Likewise. Properly record start position of symbol.
2564
52968808
AS
2565 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2566 symbol character follows.
2567
9e381cdd
PE
25682011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2569
2570 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2571 This works around a problem with the previous change to Fcopy_file.
2572 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2573 and without this change, GCC might complain about discarding
2574 fchown's return value.
2575
b5641435
JB
25762011-07-16 Juanma Barranquero <lekktu@gmail.com>
2577
2578 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2579
a8031457
PE
25802011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2581
2582 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2583
dd889327
LMI
25842011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2585
750c33f7
LMI
2586 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2587 it's used from the C level.
2588
dd889327
LMI
2589 * process.c: Use the same condition for POLL_FOR_INPUT in both
2590 keyboard.c and process.c (bug#1858).
2591
87e86684
LM
25922011-07-09 Lawrence Mitchell <wence@gmx.li>
2593
2594 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2595 (Fgnutls_boot): Use it.
2596
64348f40
AS
25972011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2598
2599 * doc.c (Fsubstitute_command_keys): Revert last change.
2600
1d698799
LMI
26012011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2602
f863868c
LMI
2603 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2604 quotes the next character, and doesn't affect other longer
2605 sequences (bug#8935).
2606
1d698799
LMI
2607 * lread.c (syms_of_lread): Clarify that is isn't only
2608 `eval-buffer' and `eval-defun' that's affected by
2609 `lexical-binding' (bug#8460).
2610
aa4b6df6
EZ
26112011-07-15 Eli Zaretskii <eliz@gnu.org>
2612
2613 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2614 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2615
5d856da6
PE
26162011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2617
ad6042bb
PE
2618 Fix minor problems found by static checking.
2619 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2620 (elsz): Now a signed constant, not a size_t var. We prefer signed
2621 types to unsigned, to avoid integer comparison confusion. Without
2622 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2623 "cannot optimize loop, the loop counter may overflow", a symptom
2624 of the confusion.
f00bbb22 2625 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2626 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2627
6468f31c
LMI
26282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2629
49080b10
LMI
2630 * search.c (Fre_search_backward): Mention `case-fold-search' in
2631 all the re_search_* functions (bug#8138).
2632
6468f31c
LMI
2633 * keyboard.c (Fopen_dribble_file): Document when the file is
2634 closed (bug#8056).
2635
c965adc5
EZ
26362011-07-14 Eli Zaretskii <eliz@gnu.org>
2637
df9733bf
EZ
2638 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2639 bidi_cache_idx.
2640
0bb23927
EZ
2641 Support bidi reordering of display and overlay strings.
2642 * xdisp.c (compute_display_string_pos)
2643 (compute_display_string_end): Accept additional argument STRING.
2644 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2645 (reseat_to_string): Initialize bidi_it->string.s and
2646 bidi_it->string.schars.
2647 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2648 NULL (avoids a crash in bidi_paragraph_init).
2649 Initialize itb.string.lstring.
0bb23927
EZ
2650 (init_iterator): Call bidi_init_it only of a valid
2651 buffer position was specified. Initialize paragraph_embedding to
2652 L2R.
2653 (reseat_to_string): Initialize the bidi iterator.
2654 (display_string): If we need to ignore text properties of
2655 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2656 original value of -1 will not work with bidi.)
2657 (compute_display_string_pos): First arg is now struct
2658 `text_pos *'; all callers changed. Support display properties on
2659 Lisp strings.
2660 (compute_display_string_end): Support display properties on Lisp
2661 strings.
2662 (init_iterator, reseat_1, reseat_to_string): Initialize the
2663 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2664 when iterating on a string not from display properties).
640c8776
SM
2665 (compute_display_string_pos, compute_display_string_end):
2666 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2667 arrow keys.
2668 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2669 base_level_stop; instead, set base_level_stop to BEGV.
2670 Fixes crashes in vertical-motion.
0bb23927
EZ
2671 (next_element_from_buffer): Improve commentary for when
2672 the iterator is before prev_stop.
2673 (init_iterator): Initialize bidi_p from the default value of
2674 bidi-display-reordering, not from buffer-local value. Use the
2675 buffer-local value only if initializing for buffer iteration.
2676 (handle_invisible_prop): Support invisible properties on strings
2677 that are being bidi-reordered.
2678 (set_iterator_to_next): Support bidi reordering of C strings and
2679 Lisp strings.
2680 (next_element_from_string): Support bidi reordering of Lisp
2681 strings.
2682 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2683 (display_string): Support display of R2L glyph rows.
2684 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2685 (init_iterator): Don't initialize it->bidi_p for strings
2686 here.
2687 (reseat_to_string): Initialize it->bidi_p for strings here.
2688 (next_element_from_string, next_element_from_c_string)
2689 (next_element_from_buffer): Add xassert's for correspondence
2690 between IT's object being iterated and it->bidi_it.string
2691 structure.
2692 (face_before_or_after_it_pos): Support bidi iteration.
2693 (next_element_from_c_string): Handle the case of the first string
2694 character that is not the first one in the visual order.
2695 (get_visually_first_element): New function, refactored from common
2696 parts of next_element_from_buffer, next_element_from_string, and
2697 next_element_from_c_string.
2698 (tool_bar_lines_needed, redisplay_tool_bar)
2699 (display_menu_bar): Force left-to-right direction. Add a FIXME
2700 comment for making that be controlled by a user option.
2701 (push_it, pop_it): Save and restore the state of the
2702 bidi iterator. Save and restore the bidi_p flag.
2703 (pop_it): Iterate out of display property for string iteration as
2704 well.
2705 (iterate_out_of_display_property): Support iteration over strings.
2706 (handle_single_display_spec): Set up it->bidi_it for iteration
2707 over a display string, and call bidi_init_it.
2708 (handle_single_display_spec, next_overlay_string)
2709 (get_overlay_strings_1, push_display_prop): Set up the bidi
2710 iterator for displaying display or overlay strings.
2711 (forward_to_next_line_start): Don't use the shortcut if
2712 bidi-iterating.
2713 (back_to_previous_visible_line_start): If handle_display_prop
2714 pushed the iterator stack, restore the internal state of the bidi
2715 iterator by calling bidi_pop_it same number of times.
2716 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2717 and we are bidi-iterating, don't decrement the iterator position;
2718 instead, set the first_elt flag in the bidi iterator, to produce
2719 the same effect.
2720 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2721 (push_display_prop): xassert that we are iterating a buffer.
2722 (push_it, pop_it): Save and restore paragraph_embedding member.
2723 (handle_single_display_spec, next_overlay_string)
2724 (get_overlay_strings_1, reseat_1, reseat_to_string)
2725 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2726 correctly. Don't assume unibyte strings are not bidi-reordered.
2727 (compute_display_string_pos)
2728 (compute_display_string_end): Fix handling the case of C string.
2729 (push_it, pop_it): Save and restore from_disp_prop_p.
2730 (handle_single_display_spec, push_display_prop): Set the
2731 from_disp_prop_p flag.
2732 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2733 (pop_it): Call iterate_out_of_display_property only if we are
2734 popping after iteration over a string that came from a display
2735 property. Fix a typo in popping stretch info. Add an assertion
2736 for verifying that the iterator position is in sync with the bidi
2737 iterator.
2738 (handle_single_display_spec, get_overlay_strings_1)
2739 (push_display_prop): Fix initialization of paragraph direction for
2740 string when that of the parent object is not yet determined.
2741 (reseat_1): Call bidi_init_it to resync the bidi
2742 iterator with IT's position. (Bug#7616)
2743 (find_row_edges): If ROW->start.pos gives position
2744 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2745 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2746 Reset the from_disp_prop_p flag.
2747 (SAVE_IT, RESTORE_IT): New macros.
2748 (pos_visible_p, face_before_or_after_it_pos)
2749 (back_to_previous_visible_line_start)
2750 (move_it_in_display_line_to, move_it_in_display_line)
2751 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2752 (try_scrolling, redisplay_window, display_line): Use them when
2753 saving a temporary copy of the iterator and restoring it back.
2754 (back_to_previous_visible_line_start, reseat_1)
2755 (init_iterator): Empty the bidi cache "stack".
2756 (move_it_in_display_line_to): If iterator ended up at
2757 EOL, but we never saw any buffer positions smaller than
2758 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2759 motion in bidi-reordered lines.
2760 (move_it_in_display_line_to): Record prev_method and prev_pos
2761 immediately before the call to set_iterator_to_next. Fixes cursor
2762 motion in bidi-reordered lines with stretch glyphs and strings
2763 displayed in margins. (Bug#8133) (Bug#8867)
2764 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2765 TO_CHARPOS.
640c8776
SM
2766 (pos_visible_p): Support positions in bidi-reordered lines.
2767 Save and restore bidi cache.
0bb23927
EZ
2768
2769 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2770 (bidi_paragraph_info): Delete unused struct.
2771 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2772 (bidi_cache_start): New variable.
2773 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2774 to zero.
2775 (bidi_cache_fetch_state, bidi_cache_search)
2776 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2777 (bidi_cache_find, bidi_peek_at_next_level)
2778 (bidi_level_of_next_char, bidi_find_other_level_edge)
2779 (bidi_move_to_visually_next): Compare cache index with
2780 bidi_cache_start rather than with zero.
2781 (bidi_fetch_char): Accept new argument STRING; all callers
2782 changed. Support iteration over a string. Support strings with
2783 display properties. Support unibyte strings. Fix the type of
2784 `len' according to what STRING_CHAR_AND_LENGTH expects.
2785 (bidi_paragraph_init, bidi_resolve_explicit_1)
2786 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2787 (bidi_level_of_next_char, bidi_move_to_visually_next):
2788 Support iteration over a string.
0bb23927
EZ
2789 (bidi_set_sor_type, bidi_resolve_explicit_1)
2790 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2791 can now be zero (for strings); special values 0 and -1 were
2792 changed to -1 and -2, respectively.
2793 (bidi_char_at_pos): New function.
2794 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2795 Call it instead of FETCH_MULTIBYTE_CHAR.
2796 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2797 initialized to valid values.
2798 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2799 values.
2800 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2801 the test for valid cached positions. Fix the logic for looking up
2802 the sentinel state in the cache. GCPRO the Lisp string we are
2803 iterating.
2804 (bidi_push_it, bidi_pop_it): New functions.
2805 (bidi_initialize): Initialize the bidi cache start stack pointer.
2806 (bidi_cache_ensure_space): New function, refactored from part of
2807 bidi_cache_iterator_state. Don't assume the required size is just
2808 one BIDI_CACHE_CHUNK away.
2809 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2810 (bidi_count_bytes, bidi_char_at_pos): New functions.
2811 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2812 always valid if bidi_cache_idx is valid.
2813 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2814 is valid if it's going to be used.
2815 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2816 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2817 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2818 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2819 (bidi_find_other_level_edge, bidi_cache_start_stack):
2820 All variables related to cache indices are now EMACS_INT.
c965adc5 2821
0bb23927
EZ
2822 * dispextern.h (struct bidi_string_data): New structure.
2823 (struct bidi_it): New member `string'. Make flag members be 1-bit
2824 fields, and put them last in the struct.
640c8776
SM
2825 (compute_display_string_pos, compute_display_string_end):
2826 Update prototypes.
0bb23927
EZ
2827 (bidi_push_it, bidi_pop_it): Add prototypes.
2828 (struct iterator_stack_entry): New members bidi_p,
2829 paragraph_embedding, and from_disp_prop_p.
2830 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2831 (bidi_shelve_cache, bidi_unshelve_cache):
2832 Declare prototypes.
0bb23927
EZ
2833
2834 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2835 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2836 and vector-like objects.
2837
2838 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2839 cache around display iteration.
2840
2841 * window.c (Fwindow_end, window_scroll_pixel_based)
2842 (displayed_window_lines, Frecenter): Save and restore the bidi
2843 cache around display iteration.
2844
3bbd2265
LMI
28452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2846
2847 * editfns.c (Fdelete_region): Clarify the use of the named
2848 parameters (bug#6788).
2849
adc47434
MR
28502011-07-14 Martin Rudalics <rudalics@gmx.at>
2851
2852 * indent.c (Fvertical_motion): Set and restore w->pointm when
2853 saving and restoring the window's buffer (Bug#9006).
2854
837c31f8
LMI
28552011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2856
2857 * editfns.c (Fstring_to_char): Clarify just what is returned
2858 (bug#6576). Text by Eli Zaretskii.
2859
ac389d0c
JB
28602011-07-13 Juanma Barranquero <lekktu@gmail.com>
2861
2862 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2863
0be0ce47
EZ
28642011-07-13 Eli Zaretskii <eliz@gnu.org>
2865
2866 * buffer.c (mmap_find): Fix a typo.
2867
cd18e7e3
JB
28682011-07-13 Johan Bockgård <bojohan@gnu.org>
2869
2870 Fix execution of x selection hooks.
2871 * xselect.c (Qx_lost_selection_functions)
2872 (Qx_sent_selection_functions): New vars.
2873 (syms_of_xselect): DEFSYM them.
2874 (x_handle_selection_request): Pass Qx_sent_selection_functions
2875 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2876 (x_handle_selection_clear,x_clear_frame_selections):
2877 Pass Qx_lost_selection_functions rather than
2878 Vx_lost_selection_functions to Frun_hook_with_args.
2879
47ea7f44
PE
28802011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2881
ac389d0c 2882 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2883 The old code sometimes used this field without initializing it.
2884
47ea7f44
PE
2885 * alloc.c (gc_sweep): Don't read past end of array.
2886 In theory, the old code could also have corrupted Emacs internals,
2887 though it'd be very unlikely.
2888
bc985c87
AS
28892011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2890
2891 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2892 argument. (Bug#4026)
bc985c87 2893
0cf34688
LMI
28942011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2895
b3dadd76
LMI
2896 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2897 key" (bug#4257).
2898
0cf34688
LMI
2899 * window.c (Fset_window_start): Doc fix (bug#4199).
2900 (Fset_window_hscroll): Ditto.
2901
270768cd
PE
29022011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2903
077e3dda 2904 Fix minor new problems caught by GCC 4.6.1.
270768cd 2905 * term.c (init_tty): Remove unused local.
490011a6 2906 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2907 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2908 not used otherwise.
270768cd 2909
b1f58454
CY
29102011-07-12 Chong Yidong <cyd@stupidchicken.com>
2911
2912 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2913
22b9578d
LMI
29142011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2915
6e70ab07
LMI
2916 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2917 are the mini-buffer and the echo area (bug#3320).
2918
22b9578d
LMI
2919 * term.c (init_tty): Remove support for supdup, c10 and perq
2920 terminals, which are no longer supported (bug#1482).
2921
8974cc9f
JB
29222011-07-10 Johan Bockgård <bojohan@gnu.org>
2923
2924 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2925
a560d974
JD
29262011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2927
2928 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2929 for non-popups (Bug#3642).
2930
1dae0f0a
AS
29312011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2932
268c2c36 2933 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2934 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2935 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2936 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2937 * data.c (fmod): Likewise.
2938 * dispnew.c (swap_glyphs_in_rows): Likewise.
2939 * emacs.c (memory_warning_signal): Likewise.
2940 * floatfns.c (float_error): Likewise.
2941 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2942 (otf_open, font_otf_capability, generate_otf_features)
2943 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2944 Likewise.
2945 * image.c (pbm_read_file): Likewise.
2946 * indent.c (string_display_width): Likewise.
2947 * intervals.c (check_for_interval, search_for_interval)
2948 (inc_interval_count, count_intervals, root_interval)
2949 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2950 * lread.c (defalias): Likewise.
268c2c36 2951 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2952 * regex.c (set_image_of_range_1, set_image_of_range)
2953 (regex_grow_registers): Likewise.
2954 * sysdep.c (strerror): Likewise.
2955 * termcap.c (valid_filename_p, tprint, main): Likewise.
2956 * tparam.c (main): Likewise.
2957 * unexhp9k800.c (run_time_remap, save_data_space)
2958 (update_file_ptrs, read_header, write_header, calculate_checksum)
2959 (copy_file, copy_rest, display_header): Likewise.
2960 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2961 Likewise.
2962 * xdisp.c (check_it): Likewise.
2963 * xfaces.c (register_color, unregister_color, unregister_colors):
2964 Likewise.
2965 * xfns.c (print_fontset_result): Likewise.
2966 * xrdb.c (member, fatal, main): Likewise.
2967
99033785
PE
29682011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 Fix minor problems found by static checking (Bug#9031).
2971 * chartab.c (char_table_set_range, map_sub_char_table):
2972 Remove unused locals.
2973 (uniprop_table): Now static.
2974 * composite.c (_work_char): Remove unused static var.
2975
9cb2ac56
JB
29762011-07-09 Juanma Barranquero <lekktu@gmail.com>
2977
2978 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2979
f25661f0
JD
29802011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2981
2982 * gtkutil.c (qttip_cb): Remove code without function.
2983
8278c4fe
EZ
29842011-07-09 Eli Zaretskii <eliz@gnu.org>
2985
2986 * w32.c (pthread_sigmask): New stub.
2987
1692ae2d 29882011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2989
8a6ebd58 2990 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2991 sigprocmask is portable only for single-threaded applications, and
2992 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2993 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2994 (LIBES): Use it.
2995 * callproc.c (Fcall_process):
2996 * process.c (create_process):
2997 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2998 Use pthread_sigmask, not sigprocmask.
123403e4 2999
1b854618
JD
30002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3001
3002 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3003 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3004 wrong (Bug#8591).
3005
3fe4b549
JD
30062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3007
0ce7e563
JD
3008 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3009 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3010 (xg_hide_tooltip): Fix comment.
3011
3fe4b549
JD
3012 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3013 in registerServicesMenuSendTypes.
3014 (validRequestorForSendType): Don't check ns_return_types.
3015
3016 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3017 ns_return_type.
3018
5df75e47
JR
30192011-07-08 Jason Rumney <jasonr@gnu.org>
3020
22610910
JR
3021 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3022 SH_SHOW for hidden windows (Bug#5482).
3023
5df75e47
JR
3024 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3025 frame struct members of non-existent frames (Bug#6284).
3026
699c10bd
JD
30272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3028
4393663b
JD
3029 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3030 variable firstTime not needed on OSX >= 10.6.
3031 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3032 >= 10.5. Use setKnobProportion, setDoubleValue.
3033
3034 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3035 (MAC_OS_X_VERSION_10_5): Define if not defined.
3036 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3037 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3038 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3039
3040 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3041 cString and lossyCString on OSX >= 10.4
3042
3043 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3044 sizeToFit on OSX >= 10.2.
3045
3046 * nsimage.m (allocInitFromFile): Don't use deprecated method
3047 bestRepresentationForDevice on OSX >= 10.6.
3048
3049 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3050 to avoid warning.
3051
3052 * emacs.c: Declare unexec_init_emacs_zone.
3053
a63e0781
JD
3054 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3055
699c10bd
JD
3056 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3057
3058 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3059 on svcsMenu (Bug#8842).
3060
3061 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3062 ns_return_types.
3063 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3064
3065 * nsterm.m (QUTF8_STRING): Declare.
3066 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3067 (validRequestorForSendType): Return type is (id).
3068 Change indexOfObjectIdenticalTo to indexOfObject.
3069 Check if we have local selection before returning self (Bug#8842).
3070 (writeSelectionToPasteboard): Put local selection into paste board
3071 if we have a local selection (Bug#8842).
3072 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3073
3074 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3075 (ns_get_local_selection): Declare.
3076
54e10184
LMI
30772011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3078
9888ff71
LMI
3079 * keymap.c (describe_map_tree): Don't insert a double newline at
3080 the end of the buffer (bug#1169) and return whether we inserted
3081 something.
3082
54e10184
LMI
3083 * callint.c (Fcall_interactively): Change "reading args" to
3084 "providing args" to try to clarify what it does (bug#1010).
3085
15fa4783
KH
30862011-07-07 Kenichi Handa <handa@m17n.org>
3087
3088 * composite.c (composition_compute_stop_pos): Ignore a static
3089 composition starting before CHARPOS (Bug#8915).
3090
3091 * xdisp.c (handle_composition_prop): Likewise.
3092
a8815b00
EZ
30932011-07-07 Eli Zaretskii <eliz@gnu.org>
3094
3095 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3096 (Bug#9015)
3097
ef7b981d 30982011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3099
3100 * character.h (unicode_category_t): New enum type.
3101
3102 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3103 (Qchar_code_property_table): New variable.
3104 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3105 (UNIPROP_COMPRESSED_FORM_P): New macros.
3106 (char_table_ascii): Uncompress the compressed values.
3107 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3108 Uncompress the compressed values.
ac389d0c 3109 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3110 (char_table_ref_and_range): Uncompress the compressed values.
3111 (sub_char_table_set): New arg is_uniprop. Callers changed.
3112 Uncompress the compressed values.
3113 (sub_char_table_set_range): Args changed. Callers changed.
3114 (char_table_set_range): Adjuted for the above change.
3115 (map_sub_char_table): Delete args default_val and parent. Add arg
3116 top. Give decoded values to a Lisp function.
640c8776 3117 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3118 values to a Lisp function. Gcpro more variables.
3119 (uniprop_table_uncompress)
3120 (uniprop_decode_value_run_length): New functions.
3121 (uniprop_decoder, uniprop_decoder_count): New variables.
3122 (uniprop_get_decoder, uniprop_encode_value_character)
3123 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3124 New functions.
3125 (uniprop_encoder, uniprop_encoder_count): New variables.
3126 (uniprop_get_encoder, uniprop_table)
3127 (Funicode_property_table_internal, Fget_unicode_property_internal)
3128 (Fput_unicode_property_internal): New functions.
3129 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3130 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3131 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3132 char-code-property-alist.
3133
640c8776 3134 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3135 Vunicode_category_table.
3136
640c8776 3137 * font.c (font_range): Adjust for the change of
c805dec0
KH
3138 Vunicode_category_table.
3139
76b397fb
DN
31402011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3141
3142 * m/iris4d.h: Remove file, move contents ...
3143 * s/irix6-5.h: ... here.
3144
22b4128e
PE
31452011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3146
3147 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3148 * alloc.c (mark_buffer):
3149 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3150 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3151 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3152 This isn't true in general, and it's particularly not true
3153 if Emacs is configured with --with-wide-int.
3154 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3155 New macros, used in the buffer.c change.
3156
869795d6
JD
31572011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3158
3159 * xsettings.c: Use both GConf and GSettings if both are available.
3160 (store_config_changed_event): Add comment.
3161 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3162 (store_tool_bar_style_changed): New functions.
5e617bc2 3163 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3164 (struct xsettings): Move font inside HAVE_XFT.
3165 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3166 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3167 Move inside HAVE_XFT.
640c8776 3168 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3169 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3170 also.
3171 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3172 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3173 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3174 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3175 (parse_settings): Move check for font inside HAVE_XFT.
3176 (read_settings, apply_xft_settings): Add comment.
3177 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3178 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3179 call store_font_name_changed.
3180 (xft_settings_event): Add comment.
3181 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3182 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3183 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3184 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3185 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3186 (xsettings_get_system_font, xsettings_get_system_normal_font):
3187 Add comment.
869795d6 3188
d8ed26bd
PE
31892011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 Random fixes. E.g., (random) never returned negative values.
3192 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3193 subseconds part to the entropy, as that's a bit more random.
3194 Prefer signed to unsigned, since the signedness doesn't matter and
3195 in general we prefer signed. When given a limit, use a
3196 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3197 latter isn't right if USE_2_TAGS_FOR_INTS.
3198 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3199 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3200
cabf1cac
SM
32012011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3202
3203 * textprop.c (text_property_stickiness):
3204 Obey Vtext_property_default_nonsticky.
3205 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3206 * w32fns.c (syms_of_w32fns):
3207 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3208
6e9b2be9
PE
32092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3210
3211 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3212 This is more efficient than Ffile_directory_p and avoids a minor race.
3213
90186c68
LMI
32142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3215
7c301272
LMI
3216 * buffer.c (Foverlay_put): Say what the return value is
3217 (bug#7835).
3218
c4f2d8d4
LMI
3219 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3220 is a directory before asking whether to use the file name
3221 (bug#7564).
ad637907
LMI
3222 (barf_or_query_if_file_exists): Make the "File is a directory"
3223 error be more correct.
c4f2d8d4 3224
90186c68
LMI
3225 * fns.c (Frequire): Remove the mention of the .gz files, since
3226 that's installation-specific, but keep the mention of
3227 `get-load-suffixes'.
3228
da64016e
PE
32292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3232 Report string overflow if the output is too long.
3233
7d47b580
JB
32342011-07-04 Juanma Barranquero <lekktu@gmail.com>
3235
a555cb87
JB
3236 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3237 (syms_of_gnutls): Remove duplicate DEFSYM for
3238 Qgnutls_bootprop_verify_hostname_error, an error for
3239 Qgnutls_bootprop_verify_error (which is no longer used).
3240
7d47b580
JB
3241 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3242 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3243 Also (re)move comments that are misplaced or no longer relevant.
3244
1e49bfab
LMI
32452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3246
3247 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3248
1485f4c0
CY
32492011-07-03 Chong Yidong <cyd@stupidchicken.com>
3250
3251 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3252 and background color parameters if they have been changed.
3253
a9ab721e
LMI
32542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3255
3256 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3257
cf7cff57
PE
32582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3259
2e13213d
PE
3260 * xsettings.c (SYSTEM_FONT): Define only when used.
3261 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3262
cf7cff57
PE
3263 * keymap.c (access_keymap_1): Now static.
3264
7a8e04f7
CY
32652011-07-02 Chong Yidong <cyd@stupidchicken.com>
3266
3267 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3268 leave any prefix arg for the up event (Bug#1586).
3269
61352f62
LMI
32702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3271
69bb1ef7
LMI
3272 * lread.c (syms_of_lread): Mention single symbols defined by
3273 `defvar' or `defconst' (bug#7154).
3274
61352f62 3275 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3276 (Frequire): Mention get-load-suffixes.
61352f62 3277
28545e04
MR
32782011-07-02 Martin Rudalics <rudalics@gmx.at>
3279
3280 * window.h (window): Remove clone_number slot.
3281 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3282 Remove.
3283 (make_parent_window, make_window, saved_window)
3284 (Fset_window_configuration, save_window_save): Don't deal with
3285 clone numbers.
3286 * buffer.c (Qclone_number): Remove declaration.
3287 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3288
3349e122
SM
32892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3290
3291 Add multiple inheritance to keymaps.
3292 * keymap.c (Fmake_composed_keymap): New function.
3293 (Fset_keymap_parent): Simplify.
3294 (fix_submap_inheritance): Remove.
3295 (access_keymap_1): New function extracted from access_keymap to handle
3296 embedded parents and handle lists of maps.
3297 (access_keymap): Use it.
3298 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3299 (Fcopy_keymap): Handle embedded parents.
3300 (Fcommand_remapping, define_as_prefix): Simplify.
3301 (Fkey_binding): Simplify.
3302 (syms_of_keymap): Move minibuffer-local-completion-map,
3303 minibuffer-local-filename-completion-map,
3304 minibuffer-local-must-match-map, and
3305 minibuffer-local-filename-must-match-map to Elisp.
3306 (syms_of_keymap): Defsubr make-composed-keymap.
3307 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3308 (parse_menu_item): Trivial simplification.
3309
3279eb87
GM
33102011-07-01 Glenn Morris <rgm@gnu.org>
3311
3312 * Makefile.in (SETTINGS_LIBS): Fix typo.
3313
4550efdf
KI
33142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3315
3316 * coding.c (Fencode_coding_string): Record the last coding system
3317 used, as the function doc string says (bug#8738).
3318
0949d2b6
JD
33192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3320
3321 * xsettings.c (store_monospaced_changed): Take new font as arg and
3322 check for change against current_mono_font.
3323 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3324 (emacs_settings_constructor, emacs_settings_get_property)
3325 (emacs_settings_set_property, emacs_settings_class_init)
3326 (emacs_settings_init, gsettings_obj): Remove.
3327 (something_changedCB): New function for HAVE_GSETTINGS.
3328 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3329 with value as argument.
3330 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3331 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3332 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3333 "changed".
3334
3335 * xgselect.c: Add defined (HAVE_GSETTINGS).
3336 (xgselect_initialize): Ditto.
3337
3338 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3339 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3340 xg_select.
3341
bbc6b304
PE
33422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3343
3344 * eval.c (struct backtrace): Simplify and port the data structure.
3345 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3346 signed bit field, as this assumption is not portable and it makes
3347 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3348 "char debug_on_exit : 1" as this is not portable either; instead,
3349 use the portable "unsigned int debug_on_exit : 1". Remove unused
3350 member evalargs. Remove obsolete comments about cc bombing out.
3351
9851bfc5
JD
33522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3353
51bb811f 3354 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3355 Let HAVE_GSETTINGS override HAVE_GCONF.
3356 (store_monospaced_changed): New function.
3357 (EMACS_SETTINGS): A new type derived from GObject to handle
3358 GSettings notifications.
3359 (emacs_settings_constructor, emacs_settings_get_property)
3360 (emacs_settings_set_property, emacs_settings_class_init):
3361 New functions.
3362 (gsettings_client, gsettings_obj): New variables.
3363 (GSETTINGS_SCHEMA): New define.
3364 (something_changedCB): Call store_monospaced_changed.
3365 (init_gsettings): New function.
3366 (xsettings_initialize): Call init_gsettings.
3367 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3368 to NULL.
3369
640c8776 3370 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3371 GCONF_CFLAGS/LIBS.
3372
5386012d
MR
33732011-06-29 Martin Rudalics <rudalics@gmx.at>
3374
3375 * window.c (resize_root_window, grow_mini_window)
3376 (shrink_mini_window): Rename Qresize_root_window to
3377 Qwindow_resize_root_window and Qresize_root_window_vertically to
3378 Qwindow_resize_root_window_vertically.
3379
f13e0b08
PE
33802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3383
94515237
JB
33842011-06-27 Juanma Barranquero <lekktu@gmail.com>
3385
3386 * makefile.w32-in: Redesign dependencies so they reflect more
3387 clearly which files are directly included by each source file,
3388 and not through other includes.
3389
e43b6e43
MR
33902011-06-27 Martin Rudalics <rudalics@gmx.at>
3391
3392 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3393 (sort_overlays, overlay_strings): When an overlay's clone number
3394 matches the window's clone number process the overlay even if
3395 the overlay's window property doesn't match the current window.
3396
d68443dc
MR
3397 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3398 (Fwindow_hchild): Rename to Fwindow_left_child.
3399 (Fwindow_next): Rename to Fwindow_next_sibling.
3400 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3401 (resize_window_check): Rename to window_resize_check.
3402 (resize_window_apply): Rename to window_resize_apply.
3403 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3404 (Fdelete_other_windows_internal, resize_frame_windows)
3405 (Fsplit_window_internal, Fdelete_window_internal)
3406 (grow_mini_window, shrink_mini_window)
3407 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3408
c7e73be5
JD
34092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3410
3411 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3412 (emacs_fixed_set_min_size): Remove.
3413 (emacs_fixed_new): Take frame as argument.
3414
3415 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3416 (_EmacsFixedPrivate): Remove minwidth/height.
3417 Add struct frame *f.
3418 (emacs_fixed_init): Initialize priv->f.
3419 (get_parent_class, emacs_fixed_set_min_size): Remove.
3420 (emacs_fixed_new): Set priv->f to argument.
3421 (emacs_fixed_get_preferred_width)
3422 (emacs_fixed_get_preferred_height): Use min_width/height from
3423 frames size_hint to set minimum and natural (Bug#8919).
3424 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3425 and use min_width/height from frames size_hint to set
3426 min_width/height (Bug#8919).
3427
3428 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3429 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3430 Fix indentation.
c7e73be5 3431
cf99dcf8
EZ
34322011-06-26 Eli Zaretskii <eliz@gnu.org>
3433
3434 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3435 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3436 called at ZV.
3437
029529ac
CY
34382011-06-26 Chong Yidong <cyd@stupidchicken.com>
3439
3440 * process.c (wait_reading_process_output): Bypass select if
3441 waiting for a cell while ignoring keyboard input, and input is
3442 pending. Suggested by Jan Djärv (Bug#8869).
3443
7a7ef429
PE
34442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3445
3446 Use gnulib's dup2 module instead of rolling our own.
3447 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3448
11fdef7d 34492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3450
3451 * dispnew.c (scrolling_window): Before scrolling, turn off a
3452 mouse-highlight in the window being scrolled.
3453
cd3520a4
JB
34542011-06-24 Juanma Barranquero <lekktu@gmail.com>
3455
3456 Move DEFSYM to lisp.h and use everywhere.
3457
3458 * character.h (DEFSYM): Move declaration...
3459 * lisp.h (DEFSYM): ...here.
3460
3461 * gnutls.c:
3462 * minibuf.c:
3463 * w32menu.c:
3464 * w32proc.c:
3465 * w32select.c: Don't include character.h.
3466
3467 * alloc.c (syms_of_alloc):
3468 * buffer.c (syms_of_buffer):
3469 * bytecode.c (syms_of_bytecode):
3470 * callint.c (syms_of_callint):
3471 * casefiddle.c (syms_of_casefiddle):
3472 * casetab.c (init_casetab_once):
3473 * category.c (init_category_once, syms_of_category):
3474 * ccl.c (syms_of_ccl):
3475 * cmds.c (syms_of_cmds):
3476 * composite.c (syms_of_composite):
3477 * dbusbind.c (syms_of_dbusbind):
3478 * dired.c (syms_of_dired):
3479 * dispnew.c (syms_of_display):
3480 * doc.c (syms_of_doc):
3481 * editfns.c (syms_of_editfns):
3482 * emacs.c (syms_of_emacs):
3483 * eval.c (syms_of_eval):
3484 * fileio.c (syms_of_fileio):
3485 * fns.c (syms_of_fns):
3486 * frame.c (syms_of_frame):
3487 * fringe.c (syms_of_fringe):
3488 * insdel.c (syms_of_insdel):
3489 * keymap.c (syms_of_keymap):
3490 * lread.c (init_obarray, syms_of_lread):
3491 * macros.c (syms_of_macros):
3492 * msdos.c (syms_of_msdos):
3493 * print.c (syms_of_print):
3494 * process.c (syms_of_process):
3495 * search.c (syms_of_search):
3496 * sound.c (syms_of_sound):
3497 * syntax.c (init_syntax_once, syms_of_syntax):
3498 * terminal.c (syms_of_terminal):
3499 * textprop.c (syms_of_textprop):
3500 * undo.c (syms_of_undo):
3501 * w32.c (globals_of_w32):
3502 * window.c (syms_of_window):
3503 * xdisp.c (syms_of_xdisp):
3504 * xfaces.c (syms_of_xfaces):
3505 * xfns.c (syms_of_xfns):
3506 * xmenu.c (syms_of_xmenu):
3507 * xsettings.c (syms_of_xsettings):
3508 * xterm.c (syms_of_xterm): Use DEFSYM.
3509
4228cf16
TZ
35102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3511
cd3520a4 3512 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3513
7fcccf1e
PE
35142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3515
7efb4e0e
PE
3516 Integer and buffer overflow fixes (Bug#8873).
3517
ff5844ad
PE
3518 * print.c (printchar, strout): Check for string overflow.
3519 (PRINTPREPARE, printchar, strout):
3520 Don't set size unless allocation succeeds.
3521
90532f02
PE
3522 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3523 for sizes. Check for string overflow more accurately.
3524 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3525
6d84508d
PE
3526 * macros.c: Integer and buffer overflow fixes.
3527 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3528 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3529 Use ptrdiff_t, not int, for sizes.
3530 Don't increment bufsize until after realloc succeeds.
3531 Check for size-calculation overflow.
3532 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3533
437b2cb4
PE
3534 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3535
8b9ac8b4
PE
3536 * lread.c: Integer overflow fixes.
3537 (read_integer): Radix is now EMACS_INT, not int,
3538 to improve quality of diagnostics for out-of-range radices.
3539 Calculate buffer size correctly for out-of-range radices.
3540 (read1): Check for integer overflow in radices, and in
3541 read-circle numbers.
82cb60d3
PE
3542 (read_escape): Avoid int overflow.
3543 (Fload, openp, read_buffer_size, read1)
3544 (substitute_object_recurse, read_vector, read_list, map_obarray):
3545 Use ptrdiff_t, not int, for sizes.
3546 (read1): Use EMACS_INT, not int, for sizes.
20270765 3547 Check for size overflow.
8b9ac8b4 3548
7fcccf1e
PE
3549 * image.c (cache_image): Check for size arithmetic overflow.
3550
bfbbd7e7
PE
3551 * lread.c: Integer overflow issues.
3552 (saved_doc_string_size, saved_doc_string_length)
3553 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3554 Now ptrdiff_t, not int.
3555 (read1): Don't assume doc string length fits in int. Check for
3556 out-of-range doc string lengths.
3557 (read_list): Don't assume file position fits in int.
39019e54 3558 (read_escape): Check for hex character overflow.
bfbbd7e7 3559
4e323265
LL
35602011-06-22 Leo Liu <sdl.web@gmail.com>
3561
3562 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3563 Move to minibuffer.el.
3564
85fece3e
PE
35652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3566
20b84ce9 3567 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3568 The following patches are for when GLYPH_DEBUG && !XASSERT.
3569 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3570 * dispnew.c (flush_stdout):
3571 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3572 Mark as externally visible.
3573 * dispnew.c (check_window_matrix_pointers): Now static.
3574 * dispnew.c (window_to_frame_vpos):
3575 * xfns.c (unwind_create_frame):
3576 * xterm.c (x_check_font): Remove unused local.
3577 * scroll.c (CHECK_BOUNDS):
3578 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3579 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3580 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3581 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3582 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3583 Now static.
3584 (debug_method_add): Use va_list and vsprintf rather than relying
3585 on undefined behavior with wrong number of arguments.
3586 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3587 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3588 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3589 since we're not interested in debugging glyphs with old libraries.
3590 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3591 GCC 4.6.0's static checking.
3592
0766b489
PE
35932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3594
31fd4b32
PE
3595 Integer overflow and signedness fixes (Bug#8873).
3596 A few related buffer overrun fixes, too.
3597
b79e8648
PE
3598 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3599
0766b489
PE
3600 * dispextern.h (struct face.stipple):
3601 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3602 (x_bitmap_mask, x_allocate_bitmap_record)
3603 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3604 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3605 (x_create_bitmap_from_xpm_data):
3606 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3607 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3608 (.bitmaps_last):
3609 * xfaces.c (load_pixmap):
3610 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3611 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3612 (.bitmaps_last, struct x_output.icon_bitmap):
3613 Use ptrdiff_t, not int, for bitmap indexes.
3614 (x_allocate_bitmap_record): Check for size overflow.
3615 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3616
b081724f
PE
3617 Use ptrdiff_t, not int, for overlay counts.
3618 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3619 * editfns.c (overlays_around, get_pos_property):
3620 * textprop.c (get_char_property_and_overlay):
3621 * xdisp.c (next_overlay_change, note_mouse_highlight):
3622 * xfaces.c (face_at_buffer_position):
21514da7
PE
3623 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3624 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3625 (Fnext_overlay_change, Fprevious_overlay_change)
3626 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3627 Use ptrdiff_t, not int, for sizes.
21514da7 3628 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3629
3de73e5e
PE
3630 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3631
2606c57b
PE
3632 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3633 (x_session_initialize): Do not assume string length fits in int.
3634
aaafe47a
PE
3635 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3636 This is unlikely, but can occur if DPI is outlandish.
3637
2674ddc8 3638 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3639 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3640
28154962
PE
3641 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3642 * xrdb.c (magic_file_p, search_magic_path):
3643 Omit last arg SUFFIX; it was always 0. All callers changed.
3644 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3645
7de51af5
PE
3646 * xfont.c (xfont_match): Avoid need for strlen.
3647
25ed6cc3
PE
3648 * xfns.c: Don't assume strlen fits in int.
3649 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3650
4eab31dd
PE
3651 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3652 not unsigned long, as we prefer signed integers. All callers changed.
3653 Detect integer overflow in repeat count.
3654 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3655 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3656
171e2a58
PE
3657 * termcap.c: Don't assume sizes fit in int and never overflow.
3658 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3659 (gobble_line): Check for size-calculation overflow.
3660
ad39faca 3661 * minibuf.c (Fread_buffer):
6e5bb2dc 3662 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3663 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3664 Don't assume string length fits in int.
3665
52c61c22 3666 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3667 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3668
b5b8c9e5
PE
3669 * font.c: Don't assume string length fits in int.
3670 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3671 Use ptrdiff_t, not int.
ccd6111c
PE
3672 (font_intern_prop): Don't assume string length fits in int.
3673 Don't assume integer property fits in fixnum.
3674 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3675
882f0d81 3676 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3677 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3678 Reformulate so as not to need the command string.
3679 Invoke gzip -cd rather than gunzip, as it's more portable.
3680 (lock_info_type, lock_file_1, lock_file):
3681 Don't assume pid_t and time_t fit in unsigned long.
3682 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3683 (current_lock_owner): Prefer signed type for sizes.
3684 Use memcpy, not strncpy, where memcpy is what is really wanted.
3685 Don't assume (via atoi) that time_t and pid_t fit in int.
3686 Check for time_t and/or pid_t out of range, e.g., via a network share.
3687 Don't alloca where an auto var works fine.
3688
93f4cf88
PE
3689 * fileio.c: Fix some integer overflow issues.
3690 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3691 Don't assume string length fits in int.
3692 (directory_file_name): Don't assume string length fits in long.
3693 (make_temp_name): Don't assume pid fits in int, or that its print
3694 length is less than 20.
3695
f3e92b69
PE
3696 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3697
1bfdaf10
PE
3698 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3699
35016e9a
PE
3700 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3701
3d1e65a1
PE
3702 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3703 We prefer signed integers, even for size calculations.
3704
0b963a93
PE
3705 * emacs.c: Don't assume string length fits in 'int'.
3706 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3707 (main): Don't invoke strlen when not needed.
3708
573f4b54
PE
3709 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3710 (XD_DEBUG_MESSAGE): Don't waste a byte.
3711
989f33ba
PE
3712 * callproc.c (getenv_internal_1, getenv_internal)
3713 (Fgetenv_internal):
965d34eb
PE
3714 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3715
e4d29b33
PE
3716 * lread.c (invalid_syntax): Omit length argument.
3717 All uses changed. This doesn't fix a bug, but it simplifies the
3718 code away from its former Hollerith-constant appearance, and it's
3719 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3720 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3721
eb49b136
PE
3722 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3723 This didn't break anything, but it didn't help either.
3724 It's confusing to put a bogus integer in a place where the actual
3725 value does not matter.
9f62aeb1 3726 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3727 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3728
15375a22
PE
3729 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3730 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3731 implementation.
b61cc01c
PE
3732 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3733 We prefer signed types, and the value cannot exceed the EMACS_INT
3734 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3735 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3736 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3737 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3738
53b2623d
PE
3739 * indent.c (sane_tab_width): New function.
3740 (current_column, scan_for_column, Findent_to, position_indentation)
3741 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3742 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3743
51cab52b 3744 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3745
f2ed8a70
PE
3746 * lisp.h (lint_assume): New macro.
3747 * composite.c (composition_gstring_put_cache):
3748 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3749
abe80cc6
PE
3750 * editfns.c, insdel.c:
3751 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3752
b02c740e
PE
3753 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3754
ebc96716
PE
3755 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3756
b4e50fa0 3757 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3758 Use much-faster test for byte-length change.
311d5d7c 3759 Don't assume string byte-length fits in 'int'.
a4cf38e4 3760 Check that character arg fits in 'int'.
85461888 3761 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3762
c0c1ee9f
PE
3763 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3764
a498d7f4
PE
3765 * fns.c (concat): Catch string overflow earlier.
3766 Do not rely on integer wraparound.
3767
51cab52b
PE
3768 * dispextern.h (struct it.overlay_strings_charpos)
3769 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3770 * xdisp.c (forward_to_next_line_start)
3771 (back_to_previous_visible_line_start)
3772 (reseat_at_next_visible_line_start, next_element_from_buffer):
3773 Don't arbitrarily truncate the value of 'selective' to int.
3774
76031fad
PE
3775 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3776
5eb55db9
PE
3777 * composite.c: Don't truncate sizes to 'int'.
3778 (composition_gstring_p, composition_reseat_it)
3779 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3780 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3781 not EMACS_UINT, for indexes.
5eb55db9 3782
0703a717
PE
3783 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3784
d6202519
PE
3785 * buffer.c: Include <verify.h>.
3786 (struct sortvec.priority, struct sortstr.priority):
8961a454 3787 Now EMACS_INT, not int.
c20998a7 3788 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3789 (struct sortstr.size, record_overlay_string)
3790 (struct sortstrlist.size, struct sortlist.used):
3791 Don't truncate size to int.
3792 (record_overlay_string): Check for size-calculation overflow.
d6202519 3793 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3794
d5a19415
JM
37952011-06-22 Jim Meyering <meyering@redhat.com>
3796
029529ac 3797 Don't leak an XBM-image-sized buffer
d5a19415
JM
3798 * image.c (xbm_load): Free the image buffer after using it.
3799
a9041e6c
PE
38002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3801
3802 Port to Sun C.
3803 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3804 that Sun C diagnosed.
3805 * fns.c (secure_hash): Fix pointer signedness issue.
3806 * intervals.c (static_offset_intervals): New function.
3807 (offset_intervals): Use it.
3808
7f3f739f
LL
38092011-06-21 Leo Liu <sdl.web@gmail.com>
3810
3811 * deps.mk (fns.o):
3812 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3813 sha512.h.
3814
3815 * fns.c (secure_hash): Rename from crypto_hash_function and change
3816 the first arg to accept symbols.
5b66d427 3817 (Fsecure_hash): New primitive.
7f3f739f
LL
3818 (syms_of_fns): New symbols.
3819
76147d94
DD
38202011-06-20 Deniz Dogan <deniz@dogan.se>
3821
3822 * process.c (Fset_process_buffer): Clarify return value in
3823 docstring.
3824
7d7d0045
CY
38252011-06-18 Chong Yidong <cyd@stupidchicken.com>
3826
3827 * dispnew.c (add_window_display_history): Use BVAR.
3828
3829 * xdisp.c (debug_method_add): Use BVAR.
3830 (check_window_end, dump_glyph_matrix, dump_glyph)
3831 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3832
3833 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3834 Likewise.
3835
3836 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3837 check till after the cache is created in init_frame_faces.
3838
ff2bc410
SM
38392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3840
3841 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3842
28177add
PE
38432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3844
dd3482fe
PE
3845 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3846 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3847 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3848
393d71f3 3849 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3850 * fileio.c (Finsert_file_contents):
3851 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3852 Remove the old (too-loose) buffer overflow checks.
3853 They weren't needed, since make_gap checks for buffer overflow.
3854 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3855 The old code merely checked for Emacs fixnum overflow, and relied
3856 on undefined (wraparound) behavior. The new code avoids undefined
3857 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3858
2e6813b0 3859 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3860 Tune. Don't use wider integers than needed. Don't use alloca.
3861 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3862
599a9e4f
PE
3863 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3864
99561444
PE
3865 * insdel.c, lisp.h (buffer_overflow): New function.
3866 (insert_from_buffer_1, replace_range, replace_range_2):
3867 * insdel.c (make_gap_larger):
3868 * editfns.c (Finsert_char):
3869 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3870
28177add
PE
3871 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3872
e69dafad
PE
38732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3874
a7af7fde 3875 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3876
b1c46f02
PE
3877 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3878 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3879
e69dafad
PE
3880 * fileio.c: Don't assume EMACS_INT fits in off_t.
3881 (emacs_lseek): New static function.
3882 (Finsert_file_contents, Fwrite_region): Use it.
3883 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3884
566684ea
PE
3885 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3886
e6966cd6
PE
3887 * fns.c: Don't overflow int when computing a list length.
3888 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3889 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3890 truncation on 64-bit hosts. Check for QUIT every
3891 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3892 faster and is responsive enough.
3893 (Flength): Report an error instead of overflowing an integer.
3894 (Fsafe_length): Return a float if the value is not representable
3895 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3896 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3897 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3898
dd0b0efb
PE
3899 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3900 (header_size, word_size): New constants.
3901 (allocate_vectorlike): Don't check size overflow here.
3902 (allocate_vector): Check it here instead, since this is the only
3903 caller of allocate_vectorlike that could cause overflow.
3904 Check that the new vector's length is representable as a fixnum.
3905
86fe5cfe
PE
3906 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3907 The previous code was bogus. For example, next_almost_prime (32)
3908 returned 39, which is undesirable as it is a multiple of 3; and
3909 next_almost_prime (24) returned 25, which is a multiple of 5 so
3910 why was the code bothering to check for multiples of 7?
3911
80e88859
PE
3912 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3913
4a2f0ad6
PE
3914 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3915
f66c7cf8
PE
3916 Variadic C functions now count arguments with ptrdiff_t.
3917 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3918 Back then I didn't know that the Emacs coding style prefers signed int.
3919 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3920 were being counted with int, which may truncate counts on 64-bit
3921 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3922 * lisp.h (struct Lisp_Subr.function.aMANY)
3923 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3924 Arg counts are now ptrdiff_t, not size_t.
3925 All variadic functions and their callers changed accordingly.
3926 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3927 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3928 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3929 * callint.c (Fcall_interactively): Check arg count for overflow,
3930 to avoid potential buffer overrun. Use signed char, not 'int',
3931 for 'varies' array, so that we needn't bother to check its size
3932 calculation for overflow.
3933 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3934 * eval.c (apply_lambda):
3935 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3936 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3937 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3938
a1759b76
PE
3939 * callint.c (Fcall_interactively): Don't use index var as event count.
3940
d96be9fc
PE
3941 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3942 * mem-limits.h (SIZE): Remove; no longer used.
3943
a690a978 3944 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3945
578c21e6
PE
3946 Remove unnecessary casts.
3947 * xterm.c (x_term_init):
3948 * xfns.c (x_set_border_pixel):
3949 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3950 These aren't needed now that we assume ANSI C.
3951
96f53c6c
PE
3952 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3953 It's more likely to cause problems (due to unsigned overflow)
3954 than to cure them.
3955
83c77d31
PE
3956 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3957
ee2079f1
PE
3958 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3959
6da65536
PE
3960 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3961
7147c4a4
PE
3962 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3963
193e32d9
PE
3964 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3965
e5533da6
PE
3966 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3967
9910e595
PE
3968 GLYPH_CODE_FACE returns EMACS_INT, not int.
3969 * dispextern.h (merge_faces):
3970 * xfaces.c (merge_faces):
01103c44
PE
3971 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3972 Don't assume EMACS_INT fits in int.
9910e595 3973
2638320e
PE
3974 * character.h (CHAR_VALID_P): Remove unused parameter.
3975 * fontset.c, lisp.h, xdisp.c: All uses changed.
3976
045eb8d9
PE
3977 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3978
c1f134b5
PE
3979 * fns.c (concat): Minor tuning based on overflow analysis.
3980 This doesn't fix any bugs. Use int to hold character, instead
3981 of constantly refetching from Emacs object. Use XFASTINT, not
3982 XINT, for value known to be a character. Don't bother comparing
3983 a single byte to 0400, as it's always less.
3984
395fcb93 3985 * floatfns.c (Fexpt):
327eeec8
PE
3986 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3987
abbd3d23
PE
3988 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3989 for characters.
3990
684a03ef
PE
3991 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3992
0fed43f3
PE
3993 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3994 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3995 incorrectly succeed when S was a string, because 4294967386 was
3996 truncated before it was used.
3997
8fd02eb7
PE
3998 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3999 Otherwise, an out-of-range integer could cause undefined behavior
4000 on a 64-bit host.
4001
f8c86b69
PE
4002 * composite.c: Use int, not EMACS_INT, for characters.
4003 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4004 EMACS_INT, for values that are known to be in character range.
4005 This doesn't fix any bugs but is the usual style inside Emacs and
4006 may generate better code on 32-bit machines.
4007
34206dd2
PE
4008 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4009 This is for reasons similar to the recent CHAR_STRING fix.
4010 * charset.c (Fencode_char): Check that character arg is actually
4011 a character. Pass an int to ENCODE_CHAR.
4012 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4013 wider than 'int', as a compile-time check to prevent future regressions
4014 in this area.
4015
c5958d4c 4016 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4017
4018 Make sure a 64-bit char is never passed to CHAR_STRING.
4019 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4020 by silently ignoring the top 32 bits, allowing some values
4021 that were far too large to be valid characters.
4022 * character.h: Include <verify.h>.
4023 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4024 arguments are no wider than unsigned, as a compile-time check
4025 to prevent future regressions in this area.
4026 * data.c (Faset):
01103c44 4027 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4028 (Fsubst_char_in_region):
4029 * fns.c (concat):
4030 * xdisp.c (decode_mode_spec_coding):
4031 Adjust to CHAR_STRING's new requirement.
4032 * editfns.c (Finsert_char, Fsubst_char_in_region):
4033 * fns.c (concat): Check that character args are actually
4034 characters. Without this test, these functions did the wrong
4035 thing with wildly out-of-range values on 64-bit hosts.
4036
d37ca623
PE
4037 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4038 These casts should not be needed on 32-bit hosts, either.
4039 * keyboard.c (read_char):
4040 * lread.c (Fload): Remove casts to unsigned.
4041
ea204efb
PE
4042 * lisp.h (UNSIGNED_CMP): New macro.
4043 This fixes comparison bugs on 64-bit hosts.
4044 (ASCII_CHAR_P): Use it.
4045 * casefiddle.c (casify_object):
01103c44 4046 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4047 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4048 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4049 * dispextern.h (FACE_FROM_ID):
4050 * keyboard.c (read_char): Use UNSIGNED_CMP.
4051
41cb286c
PE
4052 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4053 not to EMACS_INT, to avoid GCC warning.
4054
4a1b9832
PE
4055 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4056
55daad71
PE
4057 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4058 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4059 isn't needed on 32-bit machines.
8f95c75c 4060
01103c44
PE
4061 * buffer.c (Fgenerate_new_buffer_name):
4062 Use EMACS_INT for count, not int.
0ceccced 4063 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4064
4065 * data.c (Qcompiled_function): Now static.
4066
c6f072e7
PE
4067 * window.c (window_body_lines): Now static.
4068
20ce5912
PE
4069 * image.c (gif_load): Rename local to avoid shadowing.
4070
9c4c5f81
PE
4071 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4072 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4073 * alloc.c (make_save_value): Integer argument is now of type
4074 ptrdiff_t, not int.
4075 (mark_object): Use ptrdiff_t, not int.
4076 * lisp.h (pD): New macro.
4077 * print.c (print_object): Use it.
4078
c0c5c8ae
PE
4079 * alloc.c: Use EMACS_INT, not int, to count objects.
4080 (total_conses, total_markers, total_symbols, total_vector_size)
4081 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4082 (total_free_floats, total_floats, total_free_intervals)
4083 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4084 Now EMACS_INT, not int. All uses changed.
4085 (Fgarbage_collect): Compute overall total using a double, so that
4086 integer overflow is less likely to be a problem. Check for overflow
4087 when converting back to an integer.
5a25e253
PE
4088 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4089 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4090 These were 'int' variables that could overflow on 64-bit hosts;
4091 they were never used, so remove them instead of repairing them.
211a0b2a 4092 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4093 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4094 Previously, this ceilinged at INT_MAX, but that doesn't work on
4095 64-bit machines.
e46bb31a 4096 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4097
c78baabf 4098 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4099 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4100 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4101 when a (possibly-narrower) signed value would do just as well.
4102 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4103
c9d624c6
PE
4104 * alloc.c: Catch some string size overflows that we were missing.
4105 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4106 for convenience in STRING_BYTES_MAX.
4107 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4108 The definition here is exact; the one in lisp.h was approximate.
4109 (allocate_string_data): Check for string overflow. This catches
4110 some instances we weren't catching before. Also, it catches
4111 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4112 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4113 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4114
c9d624c6
PE
4115 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4116 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4117 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4118
353032ce
PE
4119 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4120
2bccce07
PE
4121 * alloc.c (Fmake_string): Check for out-of-range init.
4122
0ac30604
SM
41232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4124
4125 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4126
c195f2de
JD
41272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4128
4129 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4130 xg_get_default_scrollbar_width.
4131
4132 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4133 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4134 (style_changed_cb): Call update_theme_scrollbar_width and call
4135 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4136 all frames (Bug#8505).
4137 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4138 Call gtk_window_set_resizable if HAVE_GTK3.
4139 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4140 and height if HAVE_GTK3 (Bug#8505).
4141 (scroll_bar_width_for_theme): New variable.
4142 (update_theme_scrollbar_width): New function.
4143 (xg_get_default_scrollbar_width): Move code to
4144 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4145 (xg_initialize): Call update_theme_scrollbar_width.
4146
4147 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4148
4149 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4150
e10ac9f1
MR
41512011-06-12 Martin Rudalics <rudalics@gmx.at>
4152
4153 * frame.c (make_frame): Call other_buffer_safely instead of
4154 other_buffer.
4155
4156 * window.c (temp_output_buffer_show): Call display_buffer with
4157 second argument Vtemp_buffer_show_specifiers and reset latter
4158 immediately after the call.
4159 (Vtemp_buffer_show_specifiers): New variable.
4160 (auto_window_vscroll_p, next_screen_context_lines)
4161 (Vscroll_preserve_screen_position): Remove leading asterisks from
4162 doc-strings.
4163
2d3c217e 41642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4165
7b7f97e8 4166 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4167 * buffer.c (Qclone_number): Remove for now, as it's unused.
4168 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4169 (record_buffer): Remove unused local.
4170 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4171 (set_frame_buffer_list): Remove; unused.
4172 * frame.h (other_visible_frames): Remove decl.
4173 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4174 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4175 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4176 if HAVE_GPM.
4177 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4178 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4179 Define only if HAVE_GPM.
4180 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4181 (update_hints_inhibit): Remove; never set. All uses removed.
4182 * widgetprv.h (emacsFrameClassRec): Remove decl.
4183 * window.c (delete_deletable_window): Now returns void, since it
4184 wasn't returning anything.
4185 (compare_window_configurations): Remove unused locals.
4186 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4187 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4188 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4189 the same widths as pointers. This follows up on the 2011-05-06 patch.
4190 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4191 * xterm.h: Likewise.
4192 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4193
1384b89e
JB
41942011-06-12 Juanma Barranquero <lekktu@gmail.com>
4195
4196 * makefile.w32-in: Update dependencies.
4197 (LISP_H): Add lib/intprops.h.
4198
1100a63c
CY
41992011-06-11 Chong Yidong <cyd@stupidchicken.com>
4200
4201 * image.c (gif_load): Add animation frame delay to the metadata.
4202 (syms_of_image): Use DEFSYM. New symbol `delay'.
4203
6198ccd0
MR
42042011-06-11 Martin Rudalics <rudalics@gmx.at>
4205
4206 * window.c (delete_deletable_window): Re-add.
4207 (Fset_window_configuration): Rewrite to handle dead buffers and
4208 consequently deletable windows.
4209 (window_tree, Fwindow_tree): Remove. Supply functionality in
4210 window.el.
4211 (compare_window_configurations): Simplify code.
4212
b6e3633c
AS
42132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4214
1ab0dee5
AS
4215 * image.c (imagemagick_load_image): Fix type mismatch.
4216 (Fimagemagick_types): Likewise.
4217
b6e3633c
AS
4218 * window.h (replace_buffer_in_windows): Declare.
4219
9397e56f
MR
42202011-06-11 Martin Rudalics <rudalics@gmx.at>
4221
4222 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4223 Qclone_number. Remove external declaration of Qdelete_window.
4224 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4225 code.
640c8776
SM
4226 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4227 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4228 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4229 buffer list implementation.
4230 (other_buffer_safely): New function.
4231 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4232 calls to replace_buffer_in_windows and
4233 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4234 if allowed.
4235 (record_buffer): Inhibit quitting and rewrite using quittable
4236 functions. Run Qbuffer_list_update_hook if allowed.
4237 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4238 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4239 Move switch-to-buffer to window.el.
9397e56f
MR
4240 (bury-buffer): Move to window.el.
4241 (Vbuffer_list_update_hook): New variable.
4242
4243 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4244 section.
4245
4246 * window.h (resize_frame_windows): Move up in code.
4247 (Fwindow_frame): Remove EXFUN.
4248 (replace_buffer_in_all_windows): Remove prototype.
4249 (replace_buffer_in_windows_safely): Add prototype.
4250
4251 * window.c: Declare Qdelete_window static again. Move down
4252 declaration of select_count.
4253 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4254 (Fother_window): Move to window.el.
4255 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4256 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4257 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4258 window.el.
4259 (replace_buffer_in_windows): Implement by calling
4260 Qreplace_buffer_in_windows.
4261 (replace_buffer_in_all_windows): Remove with some functionality
4262 moved into replace_buffer_in_windows_safely.
4263 (replace_buffer_in_windows_safely): New function.
4264 (select_window_norecord, select_frame_norecord): Move in front
4265 of run_window_configuration_change_hook. Remove now obsolete
4266 declarations.
640c8776
SM
4267 (Fset_window_buffer): Rewrite doc-string.
4268 Call Qrecord_window_buffer.
9397e56f
MR
4269 (keys_of_window): Move binding for other-window to window.el.
4270
b50691aa
CY
42712011-06-11 Chong Yidong <cyd@stupidchicken.com>
4272
4273 * dispextern.h (struct image): Replace data member, whose int_val
4274 and ptr_val fields were not used by anything, with a single
4275 lisp_val object.
4276
4277 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4278 (gif_clear_image, gif_load, imagemagick_load_image)
4279 (gs_clear_image, gs_load): Callers changed.
4280
3f754b86
PE
42812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4282
cca69397
PE
4283 * buffer.h: Include <time.h>, for time_t.
4284 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4285
109e28d0
PE
4286 Fix minor problems found by static checking.
4287
60737f02
PE
4288 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4289
4b66faf3
PE
4290 Make identifiers static if they are not used in other modules.
4291 * data.c (Qcompiled_function, Qframe, Qvector):
4292 * image.c (QimageMagick, Qsvg):
4293 * minibuf.c (Qmetadata):
4294 * window.c (resize_window_check, resize_root_window): Now static.
4295 * window.h (resize_window_check, resize_root_window): Remove decls.
4296
109e28d0
PE
4297 * window.c (window_deletion_count, delete_deletable_window):
4298 Remove; unused.
46a4ce9e
PE
4299 (window_body_lines): Now static.
4300 (Fdelete_other_windows_internal): Mark vars as initialized.
4301 Make sure 'resize_failed' is initialized.
4302 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4303 (resize_window_apply): Remove unused local.
4304 * window.h (delete_deletable_window): Remove decl.
4305
109e28d0 4306 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4307 (imagemagick_load_image): Fix pointer signedness problem by changing
4308 last arg from unsigned char * to char *. All uses changed.
4309 Also, fix a local for similar reasons.
4310 Remove unused locals. Remove locals to avoid shadowing.
4311 (fn_rsvg_handle_free): Remove; unused.
4312 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4313 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4314
3f754b86
PE
4315 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4316
2547adb1
CY
43172011-06-10 Chong Yidong <cyd@stupidchicken.com>
4318
4319 * image.c (gif_load): Fix omitted cast error introduced by
4320 2011-06-06 change.
4321
2c8e37d4
MR
43222011-06-10 Martin Rudalics <rudalics@gmx.at>
4323
4324 * window.h (resize_proportionally, orig_total_lines)
4325 (orig_top_line): Remove from window structure.
4326 (set_window_height, set_window_width, change_window_heights)
4327 (Fdelete_window): Remove prototypes.
4328 (resize_frame_windows): Remove duplicate declaration.
4329
440a42e3
EZ
43302011-06-10 Eli Zaretskii <eliz@gnu.org>
4331
4332 * window.h (resize_frame_windows, resize_window_check)
4333 (delete_deletable_window, resize_root_window)
4334 (resize_frame_windows): Declare prototypes.
4335
4336 * window.c (resize_window_apply): Make definition be "static" to
4337 match the prototype.
4338
562dd5e9
MR
43392011-06-10 Martin Rudalics <rudalics@gmx.at>
4340
4341 * window.c: Remove declarations of Qwindow_size_fixed,
4342 window_min_size_1, window_min_size_2, window_min_size,
4343 size_window, window_fixed_size_p, enlarge_window, delete_window.
4344 Remove static from declaration of Qdelete_window, it's
4345 temporarily needed by Fbury_buffer.
4346 (replace_window): Don't assign orig_top_line and
4347 orig_total_lines.
4348 (Fdelete_window, delete_window): Remove. Window deletion is
4349 handled by window.el.
640c8776
SM
4350 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4351 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4352 (Fdelete_other_windows): Remove. Deleting other windows is
4353 handled by window.el.
4354 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4355 handled in window.el.
4356 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4357 Window minimum sizes are handled in window.el.
4358 (shrink_windows, size_window, set_window_height)
4359 (set_window_width, change_window_heights, window_height)
4360 (window_width, CURBEG, CURSIZE, enlarge_window)
4361 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4362 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4363 handled in window.el.
4364 (make_dummy_parent): Rename to make_parent_window and give it a
4365 second argument horflag.
4366 (make_window): Don't set resize_proportionally any more.
4367 (Fsplit_window): Remove. Windows are split in window.el.
4368 (save_restore_action, save_restore_orig_size)
4369 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4370 Resize mini windows in window.el.
4371 (grow_mini_window, shrink_mini_window): Implement by calling
4372 Qresize_root_window_vertically, resize_window_check and
4373 resize_window_apply.
640c8776
SM
4374 (saved_window, Fset_window_configuration, save_window_save):
4375 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4376 resize_proportionally.
4377 (window_min_height, window_min_width): Move to window.el.
4378 (keys_of_window): Move bindings for delete-other-windows,
4379 split-window, delete-window and enlarge-window to window.el.
4380
4381 * buffer.c: Temporarily extern Qdelete_window.
4382 (Fbury_buffer): Temporarily call Qdelete_window instead of
4383 Fdelete_window (Fbury_buffer will move to window.el soon).
4384
4385 * frame.c (set_menu_bar_lines_1): Remove code handling
4386 orig_top_line and orig_total_lines.
4387
4388 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4389 set_window_height but set heights directly.
4390 (change_frame_size_1): Use resize_frame_windows.
4391
4392 * xdisp.c (init_xdisp): Don't use set_window_height but set
4393 heights directly.
4394
640c8776
SM
4395 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4396 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4397 run_window_configuration_change_hook.
4398
4399 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4400 instead of change_window_heights and run
4401 run_window_configuration_change_hook.
4402
1a13852e
MR
44032011-06-09 Martin Rudalics <rudalics@gmx.at>
4404
4405 * window.c (replace_window): Rename second argument REPLACEMENT to
4406 NEW. New third argument SETFLAG. Rewrite.
4407 (delete_window, make_dummy_parent): Call replace_window with
4408 third argument 1.
4409 (window_list_1): Move down in code.
4410 (run_window_configuration_change_hook): Move set_buffer part
4411 before select_frame_norecord part in order to unwind correctly.
4412 Rename count1 to count.
4413 (recombine_windows, delete_deletable_window, resize_root_window)
4414 (Fdelete_other_windows_internal)
4415 (Frun_window_configuration_change_hook, make_parent_window)
4416 (resize_window_check, resize_window_apply, Fresize_window_apply)
4417 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4418 (Fdelete_window_internal, Fresize_mini_window_internal):
4419 New functions.
1a13852e
MR
4420 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4421
f3d1777e
MR
44222011-06-08 Martin Rudalics <rudalics@gmx.at>
4423
496e208e
MR
4424 * window.h (window): Add some new members to window structure -
4425 normal_lines, normal_cols, new_total, new_normal, clone_number,
4426 splits, nest, prev_buffers, next_buffers.
4427 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4428 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4429
f3d1777e
MR
4430 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4431 Remove.
496e208e
MR
4432 (make_dummy_parent): Set new members of windows structure.
4433 (make_window): Move down in code. Handle new members of window
4434 structure.
4435 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4436 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4437 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4438 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4439 (Fset_window_next_buffers, Fset_window_clone_number):
4440 New functions.
496e208e
MR
4441 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4442 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4443 Doc-string fixes.
4444 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4445 Argument WINDOW can be now internal window too.
4446 (Fwindow_use_time): Move up in code.
4447 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4448 Rewrite doc-string.
4449 (Fset_window_configuration, saved_window)
4450 (Fcurrent_window_configuration, save_window_save): Handle new
4451 members of window structure.
b9e809c2
MR
4452 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4453 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4454 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4455 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4456 Qget_mru_window, Qresize_root_window,
4457 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4458 Qauto_buffer_name; staticpro them.
f3d1777e 4459
abde8f8c
MR
44602011-06-07 Martin Rudalics <rudalics@gmx.at>
4461
4462 * window.c (Fwindow_total_size, Fwindow_left_column)
4463 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4464 (Fwindow_list_1): New functions.
4465 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4466 (Fwindow_width, Fscroll_left, Fscroll_right):
4467 Use window_body_cols instead of window_box_text_cols.
4468 (delete_window, Fset_window_configuration):
4469 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4470 (delete_all_subwindows): Take a window as argument and not a
4471 structure. Rewrite.
190b47e6
MR
4472 (window_loop): Remove handling of GET_LRU_WINDOW and
4473 GET_LARGEST_WINDOW.
4474 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4475
4476 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4477 window_box_text_cols. delete_all_subwindows now takes a
4478 Lisp_Object as argument.
abde8f8c 4479
640c8776
SM
4480 * indent.c (compute_motion, Fcompute_motion):
4481 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4482
fa8a67e6
MR
4483 * frame.c (delete_frame): Call delete_all_subwindows with root
4484 window as argument.
4485
a54e3482
DC
44862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4487
4488 * fns.c (Fputhash): Document return value.
4489
60002bf5
CY
44902011-06-06 Chong Yidong <cyd@stupidchicken.com>
4491
4492 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4493
0c671da6 44942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4495
b862a52a 4496 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4497
be44ca6c
PE
4498 Check for overflow when converting integer to cons and back.
4499 * charset.c (Fdefine_charset_internal, Fdecode_char):
4500 Use cons_to_unsigned to catch overflow.
4501 (Fencode_char): Use INTEGER_TO_CONS.
4502 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4503 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4504 * data.c (long_to_cons, cons_to_long): Remove.
4505 (cons_to_unsigned, cons_to_signed): New functions.
4506 These signal an error for invalid or out-of-range values.
4507 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4508 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4509 * font.c (Ffont_variation_glyphs):
4510 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4511 * lisp.h: Include <intprops.h>.
4512 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4513 (cons_to_signed, cons_to_unsigned): New decls.
4514 (long_to_cons, cons_to_long): Remove decls.
4515 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4516 (Fprimitive_undo): Use CONS_TO_INTEGER.
4517 * xfns.c (Fx_window_property): Likewise.
4518 * xselect.c: Include <limits.h>.
4519 (x_own_selection, selection_data_to_lisp_data):
4520 Use INTEGER_TO_CONS.
4521 (x_handle_selection_request, x_handle_selection_clear)
4522 (x_get_foreign_selection, Fx_disown_selection_internal)
4523 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4524 (lisp_data_to_selection_data): Use cons_to_unsigned.
4525 (x_fill_property_data): Use cons_to_signed.
4526 Report values out of range.
4527
d1f3d2af
PE
4528 Check for buffer and string overflow more precisely.
4529 * buffer.h (BUF_BYTES_MAX): New macro.
4530 * lisp.h (STRING_BYTES_MAX): New macro.
4531 * alloc.c (Fmake_string):
4532 * character.c (string_escape_byte8):
4533 * coding.c (coding_alloc_by_realloc):
4534 * doprnt.c (doprnt):
4535 * editfns.c (Fformat):
4536 * eval.c (verror):
4537 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4538 since they may not be the same number.
4539 * editfns.c (Finsert_char):
4540 * fileio.c (Finsert_file_contents):
4541 Likewise for BUF_BYTES_MAX.
4542
dd52fcea
PE
4543 * image.c: Use ptrdiff_t, not int, for sizes.
4544 (slurp_file): Switch from int to ptrdiff_t.
4545 All uses changed.
4546 (slurp_file): Check that file size fits in both size_t (for
4547 malloc) and ptrdiff_t (for sanity and safety).
4548
7f9bbdbb
PE
4549 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4550 if b->modtime has its maximal value.
4551
dfe18f82
PE
4552 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4553
84acfcf0
PE
4554 Don't assume time_t can fit into int.
4555 * buffer.h (struct buffer.modtime): Now time_t, not int.
4556 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4557 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4558
ccd9a01a
PE
4559 Minor fixes for signed vs unsigned integers.
4560 * character.h (MAYBE_UNIFY_CHAR):
4561 * charset.c (maybe_unify_char):
4562 * keyboard.c (read_char, reorder_modifiers):
4563 XINT -> XFASTINT, since the integer must be nonnegative.
4564 * ftfont.c (ftfont_spec_pattern):
4565 * keymap.c (access_keymap, silly_event_symbol_error):
4566 XUINT -> XFASTINT, since the integer must be nonnegative.
4567 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4568 since it makes no difference and we prefer signed.
4569 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4570 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4571 nonnegative.
4572
d6d100dd
SM
45732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4574
4575 * window.h (Fwindow_frame): Declare.
4576
2b6148e4
PE
45772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4578
4579 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4580 (SPARE_MEMORY): Always define.
4581 (LARGE_REQUEST): Remove.
4582 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4583
f230ecc9
MR
45842011-06-06 Martin Rudalics <rudalics@gmx.at>
4585
727e958e
MR
4586 * lisp.h: Move EXFUNS for Fframe_root_window,
4587 Fframe_first_window and Fset_frame_selected_window to window.h.
4588
4589 * window.h: Move EXFUNS for Fframe_root_window,
4590 Fframe_first_window and Fset_frame_selected_window here from
4591 lisp.h.
4592
4593 * frame.c (Fwindow_frame, Fframe_first_window)
4594 (Fframe_root_window, Fframe_selected_window)
4595 (Fset_frame_selected_window): Move to window.c.
4596 (Factive_minibuffer_window): Move to minibuf.c.
4597 (Fother_visible_frames_p): New function.
4598
4599 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4600
f230ecc9
MR
4601 * window.c (decode_window, decode_any_window): Move up in code.
4602 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4603 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4604 (Fwindow_buffer): Move up and rewrite doc-string.
4605 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4606 (Fwindow_prev): New functions.
727e958e
MR
4607 (Fwindow_frame): Move here from frame.c. Accept any window as
4608 argument.
4609 (Fframe_root_window, Fframe_first_window)
4610 (Fframe_selected_window): Move here from frame.c. Accept frame
4611 or arbitrary window as argument. Update doc-strings.
4612 (Fminibuffer_window): Move up in code.
4613 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4614 (Fset_frame_selected_window): Move here from frame.c.
4615 Marginal rewrite.
727e958e
MR
4616 (Fselected_window, select_window, Fselect_window): Move up in
4617 code. Minor doc-string fixes.
f230ecc9 4618
4d09bcf6
PE
46192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4620
4621 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4622 Do not assume that spare memory exists; that assumption is valid
4623 only if SYSTEM_MALLOC.
4624 (LARGE_REQUEST): New macro, so that the issue of large requests
4625 is separated from the issue of spare memory.
4626
810928a2
AS
46272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4628
172418ad
AS
4629 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4630 format. (Bug#8806)
4631
43f862f7
AS
4632 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4633
810928a2
AS
4634 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4635 before statements.
4636
a059fe24
JD
46372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4638
4639 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4640
4641 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4642
4643 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4644 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4645
989bf368
JB
46462011-06-05 Juanma Barranquero <lekktu@gmail.com>
4647
4648 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4649
4b80f674
CY
46502011-06-04 Chong Yidong <cyd@stupidchicken.com>
4651
4652 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4653 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4654 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4655 New error handlers.
4b80f674
CY
4656 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4657 Obey Vx_select_enable_clipboard_manager. Catch errors in
4658 x_clipboard_manager_save (Bug#8779).
4659 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4660 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4661
99a33b77 46622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4663
4664 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4665
99a33b77 46662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4667
4668 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4669 in the current matrix if keep_current_p is non-zero.
4670
8264569d
EZ
46712011-06-04 Eli Zaretskii <eliz@gnu.org>
4672
4673 * bidi.c (bidi_level_of_next_char): Fix last change.
4674
57f97249
EZ
46752011-06-03 Eli Zaretskii <eliz@gnu.org>
4676
fec2107c 4677 Support bidi reordering of text covered by display properties.
57f97249 4678
fec2107c
EZ
4679 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4680 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4681 (bidi_cache_search, bidi_cache_iterator_state)
4682 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4683 (bidi_level_of_next_char, bidi_move_to_visually_next):
4684 Support character positions inside a run of characters covered by a
fec2107c
EZ
4685 display string.
4686 (bidi_paragraph_init, bidi_resolve_explicit_1)
4687 (bidi_level_of_next_char): Call bidi_fetch_char and
4688 bidi_fetch_char_advance instead of FETCH_CHAR and
4689 FETCH_CHAR_ADVANCE.
4690 (bidi_init_it): Initialize new members.
4691 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4692 definitions.
4693 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4694 instead of using explicit *_CHAR codes.
d6d100dd
SM
4695 (bidi_resolve_explicit, bidi_resolve_weak):
4696 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4697 bidirectional text is supported only in multibyte buffers.
4698 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4699 it to initialize the frame_window_p member of struct bidi_it.
4700 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4701 (bidi_resolve_explicit, bidi_resolve_weak)
4702 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4703 bidi_it->nchars is non-positive.
4704 (bidi_level_of_next_char): Don't try to lookup the cache for the
4705 next/previous character if nothing is cached there yet, or if we
4706 were just reseat()'ed to a new position.
c40e2fb2 4707
0e14fe90
EZ
4708 * xdisp.c (set_cursor_from_row): Set start and stop points
4709 according to the row's direction when priming the loop that looks
4710 for the glyph on which to display cursor.
4711 (single_display_spec_intangible_p): Function deleted.
4712 (display_prop_intangible_p): Reimplement to call
4713 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4714 Accept 3 additional arguments needed by handle_display_spec.
4715 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4716 values: lists, `(when COND...)' forms, etc.
4717 (single_display_spec_string_p): Support property values that are
4718 lists with the argument STRING its top-level element.
4719 (display_prop_string_p): Fix the condition for processing a
4720 property that is a list to be consistent with handle_display_spec.
fec2107c 4721 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4722 last portion of handle_display_prop.
4723 (compute_display_string_pos): Accept additional argument
4724 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4725 value of a `display' property is a "replacing spec".
4726 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4727 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4728 the display property, but just return a value indicating whether
4729 the display property will replace the characters it covers.
4730 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4731 frame_window_p members of struct bidi_it.
d6d100dd
SM
4732 (compute_display_string_pos, compute_display_string_end):
4733 New functions.
fec2107c
EZ
4734 (push_it): Accept second argument POSITION, where pop_it should
4735 jump to continue iteration.
4736 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4737
fec2107c
EZ
4738 * keyboard.c (adjust_point_for_property): Adjust the call to
4739 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4740
4741 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4742 (bidi_init_it): Update prototypes.
4743 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4744 (compute_display_string_pos, compute_display_string_end):
4745 Declare prototypes.
fec2107c
EZ
4746 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4747 EMACS_INT.
fc6f18ce 4748
40087514 47492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4750
57f53182
PE
4751 Malloc failure behavior now depends on size of allocation.
4752 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4753 * lisp.h: Change signatures accordingly.
4754 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4755 All callers changed. (Bug#8762)
4756
4757 * gnutls.c: Use Emacs's memory allocators.
4758 Without this change, the gnutls library would invoke malloc etc.
4759 directly, which causes problems on non-SYNC_INPUT hosts, and which
4760 runs afoul of improving memory_full behavior. (Bug#8761)
4761 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4762 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4763 xfree instead of the default malloc, realloc, free.
4764 (Fgnutls_boot): No need to check for memory allocation failure,
4765 since xmalloc does that for us.
4766
ac32cd99 4767 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4768 * category.c (hash_get_category_set):
4769 * ccl.c (ccl_driver):
4770 * charset.c (Fdefine_charset_internal):
4771 * charset.h (struct charset.hash_index):
4772 * composite.c (get_composition_id, gstring_lookup_cache)
4773 (composition_gstring_put_cache):
4774 * composite.h (struct composition.hash_index):
4775 * dispextern.h (struct image.hash):
4776 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4777 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4778 (hashfn_equal, hashfn_user_defined, make_hash_table)
4779 (maybe_resize_hash_table, hash_lookup, hash_put)
4780 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4781 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4782 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4783 * image.c (make_image, search_image_cache, lookup_image)
4784 (xpm_put_color_table_h):
4785 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4786 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4787 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4788 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4789 * alloc.c (allocate_vectorlike):
4790 Check for overflow in vector size calculations.
4791 * ccl.c (ccl_driver):
4792 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4793 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4794 need to be updated by these changes.
40087514
PE
4795 * fns.c (make_hash_table, maybe_resize_hash_table):
4796 Check for integer overflow with large hash tables.
0de4bb68
PE
4797 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4798 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4799 (SXHASH_REDUCE): New macro.
4800 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4801 Use it instead of discarding useful hash info with large hash values.
4802 (sxhash_float): New function.
4803 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4804 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4805 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4806 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4807 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4808 Adjust signatures to match updated version of code.
4809 (consing_since_gc): Now EMACS_INT, since a single hash table can
4810 use more than INT_MAX bytes.
4811
698d32e2
DN
48122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4813
4814 Make it possible to build with GCC-4.6+ -O2 -flto.
4815
4816 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4817
fd6fa53f
SM
48182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4819
4820 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4821 Call minibuffer-inactive-mode.
4822
864db017
JB
48232011-05-31 Juanma Barranquero <lekktu@gmail.com>
4824
4825 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4826 Update dependencies.
4827
2ad0baf4
DN
48282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4829
4830 * data.c (init_data): Remove code for UTS, this system is not
4831 supported anymore.
4832
4fcc2638
DN
48332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4834
4835 Don't force ./temacs to start in terminal mode.
4836
4837 * frame.c (make_initial_frame): Initialize faces in all cases, not
4838 only when CANNOT_DUMP is defined.
4839 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4840
c56e0fd5
DN
48412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4842
4843 * dispnew.c (add_window_display_history): Use const for the string
4844 pointer. Remove declaration, not needed.
4845
333d54da 48462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4847
55d4c1b2 4848 Use 'inline', not 'INLINE'.
333d54da 4849 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4850 * alloc.c, fontset.c (INLINE): Remove.
4851 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4852 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4853 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4854 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4855 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4856
738db178
DN
48572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4858
4859 Make it possible to run ./temacs.
4860
4861 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4862 syms_of_callproc does the same thing. Remove test for
4863 "initialized", do it in the caller.
4864 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4865
620c53a6
SM
48662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4867
4868 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4869 (read_minibuf): Use get_minibuffer.
4870 (syms_of_minibuf): Use DEFSYM.
4871 (Qmetadata): New var.
4872 * data.c (Qbuffer): Don't make it static.
4873 (syms_of_data): Use DEFSYM.
4874
e003a292
PE
48752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4876
4877 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4878 (CCL_CODE_MIN): New macro.
4879
ed008a6d
PE
48802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4881
3687c2ef
PE
4882 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4883
ed008a6d
PE
4884 * eval.c (Qdebug): Now static.
4885 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4886 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4887 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4888
d66c4c7c
CY
48892011-05-29 Chong Yidong <cyd@stupidchicken.com>
4890
4891 * image.c: Various fixes to ImageMagick code comments.
4892 (Fimagemagick_types): Doc fix.
4893
5fbc2025
PE
48942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4895
0196f88a
PE
4896 Minor fixes prompted by GCC 4.6.0 warnings.
4897
4898 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4899
5fbc2025
PE
4900 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4901 (x_clipboard_manager_save_all): Move extern decl to ...
4902 * xterm.h: ... here, so that it can be checked for consistency.
4903
1dd3c2d9
CY
49042011-05-29 Chong Yidong <cyd@stupidchicken.com>
4905
4906 * xselect.c (x_clipboard_manager_save_frame)
4907 (x_clipboard_manager_save_all): New functions.
4908 (Fx_clipboard_manager_save): Lisp function deleted.
4909
4910 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4911 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4912
4913 * xterm.h: Update prototype.
4914
5ba6571d
WX
49152011-05-28 William Xu <william.xwl@gmail.com>
4916
4917 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4918 exiting (Bug#8239).
4919
3eaff834
JM
49202011-05-28 Jim Meyering <meyering@redhat.com>
4921
e1900994 4922 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4923 * fns.c (to_uchar): Define.
4924 (crypto_hash_function): Use it to convert some newly-signed
4925 variables to unsigned, to avoid sign-extension bugs. For example,
4926 without this change, (md5 "truc") would evaluate to
4927 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4928 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4929 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4930
0f6990a7
PE
49312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4932
4933 Integer overflow fixes.
c8a9ca5a 4934
08686060
PE
4935 * dbusbind.c: Serial number integer overflow fixes.
4936 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4937 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4938 to hold a serial number that is too large for a fixnum.
4939 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4940 Check for serial numbers out of range. Decode any serial number
59568bf0 4941 that was so large that it became a float. (Bug#8722)
08686060 4942
2d1fc3c7
PE
4943 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4944 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4945 Use XFASTINT rather than XUINT when numbers are nonnegative.
4946 (xd_append_arg, Fdbus_method_return_internal):
4947 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4948 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4949 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4950 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4951 (Bug#8722)
2d1fc3c7 4952
c8a9ca5a
PE
4953 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4954
519e1d69
PE
4955 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4956
30569699
PE
4957 ccl: add integer overflow checks
4958 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4959 (IN_INT_RANGE): New macros.
4960 (ccl_driver): Use them to check for integer overflow when
4961 decoding a CCL program. Many of the new checks are whether XINT (x)
4962 fits in int; it doesn't always, on 64-bit hosts. The new version
4963 doesn't catch all possible integer overflows, but it's an
847044ea 4964 improvement. (Bug#8719)
30569699 4965
c11285dc
PE
4966 * alloc.c (make_event_array): Use XINT, not XUINT.
4967 There's no need for unsigned here.
4968
fdccd48e
PE
4969 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4970 This follows up to the 2011-05-06 change that substituted uintptr_t
4971 for EMACS_INT. This case wasn't caught back then.
4972
37910ab2
PE
4973 Rework Fformat to avoid integer overflow issues.
4974 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4975 now (part of C89). Include <verify.h>.
4976 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4977 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4978 (Fformat): Avoid the prepass trying to compute sizes; it was only
4979 approximate and thus did not catch overflow reliably. Instead, walk
4980 through the format just once, formatting and computing sizes as we go,
4981 checking for integer overflow at every step, and allocating a larger
4982 buffer as needed. Keep track separately whether the format is
4983 multibyte. Keep only the most-recently calculated precision, rather
4984 than them all. Record whether each argument has been converted to
4985 string. Use EMACS_INT, not int, for byte and char and arg counts.
4986 Support field widths and precisions larger than INT_MAX. Avoid
4987 sprintf's undefined behavior with conversion specifications such as %#d
4988 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4989 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4990 formatting out-of-range floating point numbers with int
9173deec 4991 formats. (Bug#8668)
37910ab2 4992
2e6578fb
PE
4993 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4994
0ae6bdee
PE
4995 * data.c: Avoid integer truncation in expressions involving floats.
4996 * data.c: Include <intprops.h>.
4997 (arith_driver): When there's an integer overflow in an expression
4998 involving floating point, convert the integers to floating point
4999 so that the resulting value does not suffer from catastrophic
5000 integer truncation. For example, on a 64-bit host (* 4
5001 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5002 Do not rely on undefined behavior after integer overflow.
5003
de883a70
PE
5004 merge count_size_as_multibyte, parse_str_to_multibyte
5005 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5006 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5007 Check for integer overflow.
5008 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5009 since it's now a duplicate of the other. This is more of
5010 a character than a buffer op, so better that it's in character.c.
5011 * fns.c, print.c: Adjust to above changes.
5012
2ff916cb
PE
50132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5014
5015 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5016
f1b54466
PE
50172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5018
fb1ac845
PE
5019 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5020 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5021 (x_clipboard_manager_save): Now static.
5022 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5023
f1b54466
PE
5024 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5025 (crypto_hash_function): Now static.
5026 Fix pointer signedness problems. Avoid unnecessary initializations.
5027
a9f737ee
CY
50282011-05-27 Chong Yidong <cyd@stupidchicken.com>
5029
5030 * termhooks.h (Vselection_alist): Make it terminal-local.
5031
5032 * terminal.c (create_terminal): Initialize it.
5033
5034 * xselect.c: Support for clipboard managers.
5035 (Vselection_alist): Move to termhooks.h as terminal-local var.
5036 (LOCAL_SELECTION): New macro.
5037 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5038 (symbol_to_x_atom): Remove gratuitous arg.
5039 (x_handle_selection_request, lisp_data_to_selection_data)
5040 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5041 (x_own_selection, x_get_local_selection, x_convert_selection):
5042 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5043 (some_frame_on_display): Delete unused function.
5044 (Fx_own_selection_internal, Fx_get_selection_internal)
5045 (Fx_disown_selection_internal, Fx_selection_owner_p)
5046 (Fx_selection_exists_p): New optional frame arg.
5047 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5048 (x_handle_selection_clear): Don't treat other terminals with the
5049 same keyboard specially. Use the terminal-local Vselection_alist.
5050 (x_clear_frame_selections): Use Frun_hook_with_args.
5051
5052 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5053
5054 * xterm.h: Add support for those atoms.
5055
e067f0c1
CY
50562011-05-26 Chong Yidong <cyd@stupidchicken.com>
5057
5058 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5059 (converted_selections, conversion_fail_tag): New global variables.
5060 (x_selection_request_lisp_error): Free the above.
5061 (x_get_local_selection): Remove unnecessary code.
5062 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5063 of converted selections stored in converted_selections.
5064 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5065 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5066 (x_convert_selection): New function.
5067 (x_handle_selection_event): Simplify.
5068 (x_get_foreign_selection): Don't ignore incoming requests while
5069 waiting for an answer; this will fail when we implement
5070 SAVE_TARGETS, and seems unnecessary anyway.
5071 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5072 (Vx_sent_selection_functions): Doc fix.
5073
0f4aebc0
LL
50742011-05-26 Leo Liu <sdl.web@gmail.com>
5075
5076 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5077
e61124cd
YM
50782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5079
5080 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5081
5082 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5083 for fringe update if it has periodic bitmap.
ac389d0c 5084 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5085 and fringe_bitmap_periodic_p.
5086
5087 * fringe.c (get_fringe_bitmap_data): New function.
5088 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5089 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5090 row. Mark glyph row for fringe update if periodicity changed.
5091
5092 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5093 for fringe update unless it has periodic bitmap.
5094
f16d9837
KH
50952011-05-25 Kenichi Handa <handa@m17n.org>
5096
5097 * xdisp.c (get_next_display_element): Set correct it->face_id for
5098 a static composition.
5099
e1b90ef6
LL
51002011-05-24 Leo Liu <sdl.web@gmail.com>
5101
5102 * deps.mk (fns.o):
5103 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5104
5105 * fns.c (crypto_hash_function, Fsha1): New function.
5106 (Fmd5): Use crypto_hash_function.
5107 (syms_of_fns): Add Ssha1.
5108
7400048f
PE
51092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5110
5111 * gnutls.c: Remove unused macros.
5112 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5113 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5114 Remove macros that are defined and never used.
5115 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5116
abb71cf4
CY
51172011-05-22 Chong Yidong <cyd@stupidchicken.com>
5118
5119 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5120 (Fx_get_selection_internal): Minor cleanup.
5121 (Fx_own_selection_internal): Rename arguments for consistency with
5122 select.el.
5123
6307db39
PE
51242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5125
5126 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5127
f3d4e0a4
CY
51282011-05-22 Chong Yidong <cyd@stupidchicken.com>
5129
5130 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5131
4d8ade89
YM
51322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5133
5134 * dispnew.c (scrolling_window): Don't exclude the case that the
5135 last enabled row in the desired matrix touches the bottom boundary.
5136
32078c8d
GM
51372011-05-21 Glenn Morris <rgm@gnu.org>
5138
5139 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5140 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5141 and add some more files.
32078c8d 5142
7285dc67
EZ
51432011-05-20 Eli Zaretskii <eliz@gnu.org>
5144
5145 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5146 report_file_error introduced by the change from 2011-05-07.
5147
89d1bd22
PE
51482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5149
5150 * systime.h (Time): Define only if emacs is defined.
5151 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5152 where the include path doesn't have X11/X.h by default. See
5153 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5154
e23640bb 51552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5156
5157 * composite.c (find_automatic_composition): Fix previous change.
5158
b9704ad9
GM
51592011-05-20 Glenn Morris <rgm@gnu.org>
5160
5161 * lisp.mk: New file, split from Makefile.in.
5162 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5163 (shortlisp): Remove.
5164 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5165
4a720484
GM
51662011-05-19 Glenn Morris <rgm@gnu.org>
5167
5168 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5169 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5170 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5171 (lisp): Set the order to that of loadup.el.
5172 (shortlisp): Make it a copy of $lisp.
5173 (SOME_MACHINE_LISP): Remove.
5174 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5175 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5176
a28d4396
KH
51772011-05-18 Kenichi Handa <handa@m17n.org>
5178
5179 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5180 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5181 (find_automatic_composition): Mostly rewrite for efficiency.
5182
a2b1fa8e
JB
51832011-05-18 Juanma Barranquero <lekktu@gmail.com>
5184
5185 * makefile.w32-in: Update dependencies.
5186
8e1f5610
CS
51872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5188
5189 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5190 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5191
7025ee00 51922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5193
cdfa6eab
PE
5194 Fix some integer overflow issues, such as string length overflow.
5195
06d6db33
PE
5196 * insdel.c (count_size_as_multibyte): Check for string overflow.
5197
2b4560a8
PE
5198 * character.c (lisp_string_width): Check for string overflow.
5199 Use EMACS_INT, not int, for string indexes and lengths; in
5200 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5201 the resulting string length overflows an EMACS_INT; instead,
5202 report a string overflow if no precision given. When checking for
5203 precision exhaustion, use a check that cannot possibly have
5204 integer overflow. (Bug#8675)
5205 * character.h (lisp_string_width): Adjust to new signature.
5206
cb93f9be
PE
5207 * alloc.c (string_overflow): New function.
5208 (Fmake_string): Use it. This doesn't change behavior, but saves
5209 a few bytes and will simplify future changes.
5210 * character.c (string_escape_byte8): Likewise.
5211 * lisp.h (string_overflow): New decl.
5212
1a1f3366
PE
5213 Fixups, following up to the user-interface timestamp change.
5214 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5215 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5216 * msdos.c (mouse_get_pos): Likewise.
5217 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5218 * w32gui.h (Time): Define by including "systime.h" rather than by
5219 declaring it ourselves. (Bug#8664)
5220
d4e3e4d3
PE
5221 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5222 * image.c (clear_image_cache): Likewise.
5223
f6a24d19
PE
5224 * term.c (term_mouse_position): Don't assume time_t wraparound.
5225
08dc5ae6
PE
5226 Be more systematic about user-interface timestamps.
5227 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5228 and sometimes 'EMACS_UINT', to represent these timestamps.
5229 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5230 This makes the code easier to follow, and makes it easier to catch
5231 integer overflow bugs such as Bug#8664.
5232 * frame.c (Fmouse_position, Fmouse_pixel_position):
5233 Use Time, not unsigned long, for user-interface timestamps.
5234 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5235 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5236 * keyboard.h (last_event_timestamp): Likewise.
5237 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5238 * menu.h (xmenu_show): Likewise.
5239 * term.c (term_mouse_position): Likewise.
5240 * termhooks.h (struct input_event.timestamp): Likewise.
5241 (struct terminal.mouse_position_hook): Likewise.
5242 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5243 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5244 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5245 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5246 what it was before.
5247 * menu.h, termhooks.h: Include "systime.h", for Time.
5248
8e55734a
PE
5249 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5250 Don't assume that the difference between two unsigned long values
5251 can fit into an integer. At this point, we know button_down_time
5252 <= event->timestamp, so the difference must be nonnegative, so
5253 there's no need to cast the result if double-click-time is
5254 nonnegative, as it should be; check that it's nonnegative, just in
5255 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5256 apart (about 25 days). (Bug#8664)
8e55734a 5257
841f1b75 5258 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5259 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5260
3e26f69c
PE
5261 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5262 that always fit in int. Use a sentinel instead of a counter, to
5263 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5264 * frame.h (struct frame): Use int for menu_bar_items_used
5265 instead of EMACS_INT, since it always fits in int.
3e26f69c 5266
5cc152c0
PE
5267 * menu.c (grow_menu_items): Check for int overflow.
5268
d89eb65e
PE
5269 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5270
5235bd3e
PE
5271 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5272 Before, the code was not consistent. These values cannot exceed
5273 2**31 - 1 so there's no need to make them unsigned.
5274 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5275 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5276 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5277 as modifiers.
5278 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5279
bc827e23
PE
5280 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5281 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5282 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5283 presumably because the widths might not match.
5284
78eb494e
PE
5285 * window.c (size_window): Avoid needless test at loop start.
5286
04f2d78b
CB
52872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5288
5289 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5290
d2fc7e3d 52912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5292
5293 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5294
d2fc7e3d 52952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5296
5297 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5298 `width' to `bar_area_x' and `bar_area_width', respectively.
5299 (x_scroll_run): Take account of fringe background extension.
5300
04f2d78b
CB
5301 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5302 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5303 `bar_area_width', respectively.
5304 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5305 background extension.
5306
79b70037
GM
53072011-05-10 Jim Meyering <meyering@redhat.com>
5308
5309 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5310
2f142cc5
JB
53112011-05-10 Juanma Barranquero <lekktu@gmail.com>
5312
5313 * image.c (Finit_image_library): Return t for built-in image types,
5314 like pbm and xbm. (Bug#8640)
5315
57679c86
AS
53162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5317
5318 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5319
888c9e86
EZ
53202011-05-07 Eli Zaretskii <eliz@gnu.org>
5321
b0512a1d
EZ
5322 * w32console.c (Fset_screen_color): Doc fix.
5323 (Fget_screen_color): New function.
5324 (syms_of_ntterm): Defsubr it.
5325
7285dc67
EZ
5326 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5327 unlink the temporary file if Fcall_process didn't create it in the
5328 first place.
5329 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5330 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5331 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5332 cue to call_process_cleanup not to close that handle.
5333
4d3fcc8e
BK
53342011-05-07 Ben Key <bkey76@gmail.com>
5335
5336 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5337 one of two shell specific rules, either bootstrap-temacs-CMD or
5338 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5339 to the previous implementation of the bootstrap-temacs rule.
5340 The bootstrap-temacs-CMD rule is similar to the previous
5341 implementation of the bootstrap-temacs rule except that it
5342 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5343 variable.
5344
5345 These changes, along with some changes to nt/configure.bat,
5346 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5347 earlier fix to add support for --cflags and --ldflags options
5348 that include quotes so that it works whether make uses cmd or
5349 sh as the shell.
5350
b4289b64
MA
53512011-05-06 Michael Albinus <michael.albinus@gmx.de>
5352
5353 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5354 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5355 is a constant.
5356 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5357 a string. Handle both cases.
5358 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5359 (Fdbus_register_method): Use Qinvalid_function.
5360
af4c0e28
JB
53612011-05-06 Juanma Barranquero <lekktu@gmail.com>
5362
5363 * makefile.w32-in: Update dependencies.
5364 (LISP_H): Add inttypes.h and stdin.h.
5365 (PROCESS_H): Add unistd.h.
5366
c51453d9
EZ
53672011-05-06 Eli Zaretskii <eliz@gnu.org>
5368
5369 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5370 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5371
8ff0ac3c 53722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5373
4c4b566b
PE
5374 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5375
aab2b9b5
PE
5376 * term.c (vfatal): Remove stray call to va_end.
5377 It's not needed and the C Standard doesn't allow it here anyway.
5378
c378da0b
PE
5379 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5380 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5381
288b08c7
PE
5382 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5383 bytes.
5384
e3601888
PE
5385 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5386
db6c0e74
PE
5387 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5388
dd5963ea
PE
5389 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5390
88c9450f
PE
5391 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5392
2f9442b8
PE
5393 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5394
c032b5f8
PE
5395 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5396 * charset.c (Fdefine_charset_internal): Don't initialize
5397 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5398 32-bit int (Bug#8600).
a108c10b
PE
5399
5400 * lread.c (read_integer): Be more consistent with string-to-number.
5401 Use string_to_number to do the actual conversion; this avoids
5402 rounding errors and fixes some other screwups. Without this fix,
5403 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5404 (digit_to_number): Move earlier, for benefit of read_integer.
5405 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5406 not a digit in any supported base. (Bug#8602)
a108c10b 5407
ad5f9eea
PE
5408 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5409
aec1708a
PE
5410 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5411 to match comment at start of function. This also removes a
5412 GCC warning about overflow in a 32+64-bit port.
5413
47be4ab5
PE
5414 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5415
371cac43
PE
5416 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5417 Reported by Stefan Monnier in
5418 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5419 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5420 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5421
d01a7826
PE
5422 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5423 (EMACS_UINTPTR): Likewise, with uintptr_t.
5424
7fd47d5c
PE
5425 * lisp.h: Prefer 64-bit EMACS_INT if available.
5426 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5427 on 32-bit hosts that have 64-bit int, so that they can access
5428 large files.
122b0c86
PE
5429 However, temporarily disable this change unless the temporary
5430 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5431
8727937b
PE
5432 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5433
8ac068ac
PE
5434 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5435 This removes an assumption that EMACS_INT and long are the same
5436 width as pointers. The assumption is true for Emacs porting targets
5437 now, but we want to make other targets possible.
5438 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5439 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5440 In the rest of the code, change types of integers that hold casted
5441 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5442 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5443 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5444 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5445 No need to cast type when ORing.
5446 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5447 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5448 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5449 assume EMACS_INT is the same width as char *.
5450 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5451 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5452 Remove no-longer-needed casts.
5453 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5454 (xg_tool_bar_help_callback, xg_make_tool_item):
5455 Use EMACS_INTPTR to hold an integer
5456 that will be cast to void *; this can avoid a GCC warning
5457 if EMACS_INT is not the same width as void *.
5458 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5459 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5460 (current_message_1, set_message_1):
5461 Use a local to convert to proper width without a cast.
5462 * xmenu.c (dialog_selection_callback): Likewise.
5463
ede49d71
PE
5464 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5465 Also, don't assume VALBITS / RAND_BITS is less than 5,
5466 and don't rely on undefined behavior when shifting a 1 left into
5467 the sign bit.
5468 * lisp.h (get_random): Change signature to match.
5469
2f30ecd0
PE
5470 * lread.c (hash_string): Use size_t, not int, for hash computation.
5471 Normally we prefer signed values; but hashing is special, because
5472 it's better to use unsigned division on hash table sizes so that
5473 the remainder is nonnegative. Also, size_t is the natural width
5474 for hashing into memory. The previous code used 'int', which doesn't
5475 retain enough info to hash well into very large tables.
5476 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5477
2a866e7b
PE
5478 * dbusbind.c: Don't possibly lose pointer info when converting.
5479 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5480 Use XPNTR rather than XHASH, so that the high-order bits of
5481 the pointer aren't lost when converting through void *.
5482
51639eac
PE
5483 * eval.c (Fautoload): Don't double-shift a pointer.
5484
92394119
PE
5485 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5486
dbdb9a7c
JB
54872011-05-06 Juanma Barranquero <lekktu@gmail.com>
5488
5489 * gnutls.c (DEF_GNUTLS_FN):
5490 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5491
db7a0b4f
AS
54922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5493
5494 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5495 marker. (Bug#8610)
5496
f7ff1b0f 54972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5498
5499 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5500 New version that can reserve upto 2GB of heap space.
5501
f7ff1b0f 55022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5503
5504 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5505
639c109b
TZ
55062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5507
5508 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5509 `gnutls_certificate_set_x509_key_file'.
5510
d2127135
JB
55112011-05-05 Juanma Barranquero <lekktu@gmail.com>
5512
5513 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5514 Update dependencies.
5515
e968f4f3
JB
55162011-05-04 Juanma Barranquero <lekktu@gmail.com>
5517
5518 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5519 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5520 Remove unused parameter `fildes'.
5521 * process.c (read_process_output, send_process): Don't pass it.
5522
84d358f0
JB
55232011-05-04 Juanma Barranquero <lekktu@gmail.com>
5524
5525 Fix previous change: the library cache is defined in w32.c.
5526 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5527 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5528
0898ca10
JB
55292011-05-04 Juanma Barranquero <lekktu@gmail.com>
5530
5531 Implement dynamic loading of GnuTLS on Windows.
5532
5533 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5534 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5535 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5536 Declare.
5537
5538 * gnutls.c (Qgnutls_dll): Define.
5539 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5540 (gnutls_*): Declare function pointers.
5541 (init_gnutls_functions): New function to initialize function pointers.
5542 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5543 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5544 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5545 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5546 (emacs_gnutls_write, emacs_gnutls_read)
5547 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5548 (Fgnutls_available_p): New function.
5549 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5550 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5551 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5552
5553 * image.c: Include w32.h.
5554 (Vimage_type_cache): Delete.
5555 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5556 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5557 (w32_delayed_load): Move to w32.c.
5558
5559 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5560
5561 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5562 (w32_delayed_load): Move from image.c. When loading a library, record
5563 its filename in the :loaded-from property of the library id.
5564 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5565 Initialize and staticpro them.
5566 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5567
5568 * process.c: Include lisp.h before w32.h, not after.
5569 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5570 instead of gnutls_record_check_pending.
5571
5572 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5573
ff4de4aa
TZ
55742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5575
5576 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5577 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5578 as passed in.
5579
abe95abb
JD
55802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5581
5582 * xterm.c (x_set_frame_alpha): Do not set property on anything
5583 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5584
e16e55d4
JB
55852011-05-02 Juanma Barranquero <lekktu@gmail.com>
5586
5587 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5588
bafcf6a5
JB
55892011-05-02 Juanma Barranquero <lekktu@gmail.com>
5590
5591 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5592 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5593 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5594 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5595 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5596 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5597 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5598 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5599 (Qgnutls_bootprop_callbacks_verify): Make static.
5600
e7a6747f
AS
56012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5602
19ed11ba
AS
5603 * callproc.c: Indentation fixup.
5604
e7a6747f 5605 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5606 (wait_for_termination, interruptible_wait_for_termination):
5607 Move after wait_for_termination_1.
e7a6747f 5608
1ef14cb4
LMI
56092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5610
5611 * sysdep.c (interruptible_wait_for_termination): New function
5612 which is like wait_for_termination, but allows keyboard
5613 interruptions.
5614
5615 * callproc.c (Fcall_process): Add (:file "file") as an option for
5616 the STDOUT buffer.
5617 (Fcall_process_region): Ditto.
5618
330d880c
EZ
56192011-04-30 Eli Zaretskii <eliz@gnu.org>
5620
8db90b73
EZ
5621 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5622 rather than `XVECTOR (FOO)->size'.
5623
330d880c
EZ
5624 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5625 inttypes.h, as a gnulib replacement is used if it not available in
5626 system headers.
5627
15cbd324
EZ
56282011-04-21 Eli Zaretskii <eliz@gnu.org>
5629
5630 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5631 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5632 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5633
5634 * coding.c (coding_alloc_by_realloc): Error out if destination
5635 will grow beyond MOST_POSITIVE_FIXNUM.
5636 (decode_coding_emacs_mule): Abort if there isn't enough place in
5637 charbuf for the composition carryover bytes. Reserve an extra
5638 space for up to 2 characters produced in a loop.
5639 (decode_coding_iso_2022): Abort if there isn't enough place in
5640 charbuf for the composition carryover bytes.
5641
56422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5643
ae940cca
EZ
5644 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5645 aborting when %lld or %lll format is passed.
5646 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5647 %llo or %llx format is passed. (Bug#8545)
5648
03ab8921
EZ
5649 * window.c (window_scroll_line_based): Use a marker instead of
5650 simple variables to record original value of point. (Bug#7952)
5651
afda1437
EZ
5652 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5653 produced by %s or %c overflows available buffer space. (Bug#8545)
5654
f76dee0c
PE
56552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5656
5657 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5658 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5659
fdc5744d
JB
56602011-04-28 Juanma Barranquero <lekktu@gmail.com>
5661
5662 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5663
638f053a
JB
56642011-04-28 Juanma Barranquero <lekktu@gmail.com>
5665
5666 * keyboard.c (Qdelayed_warnings_hook): Define.
5667 (command_loop_1): Run `delayed-warnings-hook'
5668 if Vdelayed_warnings_list is non-nil.
5669 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5670 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5671
d178f871
EZ
56722011-04-28 Eli Zaretskii <eliz@gnu.org>
5673
5674 * doprnt.c (doprnt): Don't return value smaller than the buffer
5675 size if the message was truncated. (Bug#8545).
5676
b124fd93
JB
56772011-04-28 Juanma Barranquero <lekktu@gmail.com>
5678
5679 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5680 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5681
e810457d
PE
56822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5683
5684 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5685
ea51cceb
JB
56862011-04-27 Juanma Barranquero <lekktu@gmail.com>
5687
5688 * makefile.w32-in: Update dependencies.
5689
94dcfacf
EZ
56902011-04-27 Eli Zaretskii <eliz@gnu.org>
5691
5692 Improve `doprnt' and its usage. (Bug#8545)
5693 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5694 `format_end'. Remove support for %l as a conversion specifier.
5695 Don't use xrealloc. Improve diagnostics when the %l size modifier
5696 is used. Update the commentary.
5697
5698 * eval.c (verror): Simplify calculation of size_t.
5699
5700 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5701 messages.
5702
f61f41d7
PE
57032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5704
5705 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5706 change.
5707
96fb4434
PE
57082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5709
5710 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5711 This makes this file independent of the recent pseudovector change.
5712
671875da 57132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5714
69e9b5a3
PE
5715 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5716
b5f869a7 5717 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5718 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5719 Remove unused local.
c8926152 5720 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5721
841a1577 5722 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5723 GCC 4.6.0 optimizes based on type-based alias analysis.
5724 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5725 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5726 != &v->size, and therefore "v->size = 1; b->size = 2; return
5727 v->size;" must therefore return 1. This assumption is incorrect
5728 for Emacs, since it type-puns struct Lisp_Vector * with many other
5729 types. To fix this problem, this patch adds a new type struct
f904488f 5730 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5731 and pseudovectors, and helps optimizing compilers not get fooled
5732 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5733 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5734 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5735 the size member.
eab3844f
PE
5736 (XSETPVECTYPE): Rewrite in terms of new macro.
5737 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5738 This is a bit clearer, and further avoids the possibility of
5739 undesirable aliasing.
5740 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5741 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5742 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5743 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5744 (ASIZE): Now uses header.size rather than size.
5745 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5746 to avoid the hassle of writing XVECTOR (foo)->header.size.
5747 (struct vectorlike_header): New type.
eab3844f
PE
5748 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5749 object, to help avoid aliasing.
5750 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5751 (SUBRP): Likewise, since Lisp_Subr is a special case.
5752 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5753 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5754 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5755 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5756 changed to be "header.size" and "header.next".
5757 * buffer.h (struct buffer): Likewise.
5758 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5759 * frame.h (struct frame): Likewise.
5760 * process.h (struct Lisp_Process): Likewise.
5761 * termhooks.h (struct terminal): Likewise.
5762 * window.c (struct save_window_data, struct saved_window): Likewise.
5763 * window.h (struct window): Likewise.
5764 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5765 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5766 * buffer.c (init_buffer_once): Likewise.
5767 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5768 special case.
5769 * process.c (Fformat_network_address): Use local var for size,
5770 for brevity.
5771
0df1eac5
PE
5772 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5773
847ab9d1 5774 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5775 * data.c (atof): Remove decl; no longer used or needed.
5776 (digit_to_number): Move to lread.c.
5777 (Fstring_to_number): Use new string_to_number function, to be
5778 consistent with how the Lisp reader treats infinities and NaNs.
5779 Do not assume that floating-point numbers represent EMACS_INT
5780 without losing information; this is not true on most 64-bit hosts.
5781 Avoid double-rounding errors, by insisting on integers when
5782 parsing non-base-10 numbers, as the documentation specifies.
5783 * lisp.h (string_to_number): New decl, replacing ...
5784 (isfloat_string): Remove.
bc0a5c13 5785 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5786 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5787 appears to have been a coding error. Similarly, do not accept
5788 strings like +-1e0 as floating point numbers. Do not report
5789 overflow for integer overflows unless the base is not 10 which
5790 means we have no simple and reliable way to continue.
5791 Break out the floating-point parsing into a new
5792 function string_to_number, so that Fstring_to_number parses
5793 floating point numbers consistently with the Lisp reader.
04f2d78b 5794 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5795 (E_CHAR, EXP_INT): Remove, replacing with ...
5796 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5797 (string_to_number): New function, replacing isfloat_string.
5798 This function checks for valid syntax and produces the resulting
5799 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5800 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5801 so that overflow for non-base-10 numbers is reported only when
5802 there's no portable and simple way to convert to floating point.
452f4150 5803
67769ffc
PE
5804 * textprop.c (set_text_properties_1): Rewrite for clarity,
5805 and to avoid GCC warning about integer overflow.
5806
c20db43f
PE
5807 * intervals.h (struct interval): Use EMACS_INT for members
5808 where EMACS_UINT might cause problems. See
5809 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5810 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5811 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5812 All uses changed.
37aa2f85
PE
5813 (offset_intervals): Tell GCC not to worry about length overflow
5814 when negating a negative length.
c20db43f 5815
2538aa2f
PE
5816 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5817 (overrun_check_free): Likewise.
5818
f2d3008d
PE
5819 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5820 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5821 word size.
5822
ec8df744
PE
5823 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5824 (gnutls_make_error): Rename local to avoid shadowing.
5825 (gnutls_emacs_global_deinit): ifdef out; not used.
5826 (Fgnutls_boot): Use const for pointer to readonly storage.
5827 Comment out unused local. Fix pointer signedness problems.
5828
640ee02d
PE
5829 * lread.c (openp): Don't stuff size_t into an 'int'.
5830 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5831 about possible signed overflow.
5832
6048fb2a
PE
5833 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5834 (GDK_KEY_g): Don't define if already defined.
5835 (xg_prepare_tooltip): Avoid pointer signedness problem.
5836 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5837
fa3c87e1
PE
5838 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5839 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5840
2172544b
PE
5841 * xfns.c (Fx_window_property): Simplify a bit,
5842 to make a bit faster and to avoid GCC 4.6.0 warning.
5843 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5844
9b821a21
PE
5845 * fns.c (internal_equal): Don't assume size_t fits in int.
5846
3c616cfa
PE
5847 * alloc.c (compact_small_strings): Tighten assertion a little.
5848
c2982e87
PE
5849 Replace pEd with more-general pI, and fix some printf arg casts.
5850 * lisp.h (pI): New macro, generalizing old pEd macro to other
5851 conversion specifiers. For example, use "...%"pI"d..." rather
5852 than "...%"pEd"...".
5853 (pEd): Remove. All uses replaced with similar uses of pI.
5854 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5855 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5856 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5857 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5858 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5859 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5860 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5861 64-bit hosts.
5862 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5863 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5864 * print.c (safe_debug_print, print_object): Likewise.
5865 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5866 to int.
6f04d126
PE
5867 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5868 avoiding the 0 flag, which is not portable.
c2982e87
PE
5869 * process.c (Fmake_network_process): Use pI to avoid cast.
5870 * region-cache.c (pp_cache): Likewise.
5871 * xdisp.c (decode_mode_spec): Likewise.
5872 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5873 behavior on 64-bit hosts with printf arg.
6f04d126 5874 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5875 (x_stop_queuing_selection_requests): Likewise.
5876 (x_get_window_property): Don't truncate byte count to an 'int'
5877 when tracing.
0b432f21 5878
5e073ec7
PE
5879 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5880 here, since it parses constructs like leading '-' and spaces,
5881 which are not wanted; and it overflows with large numbers.
5882 Instead, simply match F[0-9]+, which is what is wanted anyway.
5883
36372bf9
PE
5884 * alloc.c: Remove unportable assumptions about struct layout.
5885 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5886 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5887 (allocate_vectorlike, make_pure_vector): Use the new macros,
5888 plus offsetof, to remove unportable assumptions about struct layout.
5889 These assumptions hold on all porting targets that I know of, but
5890 they are not guaranteed, they're easy to remove, and removing them
5891 makes further changes easier.
5892
0b432f21
PE
5893 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5894 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5895 (string_overrun_cookie): Now const. Use initializers that
5896 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5897 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5898 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5899 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5900 multiple of sizeof (EMACS_INT); it need not be, if
5901 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5902 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5903
895009e1
JB
59042011-04-26 Juanma Barranquero <lekktu@gmail.com>
5905
5906 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5907
6a7a1b0b
TZ
59082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5909
5910 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5911 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5912 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5913
841a1577 59142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5915
5916 * lisp.h (Qdebug): List symbol.
895009e1 5917 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5918 * keyboard.c (debug-on-event): New variable.
5919 (handle_user_signal): Break into debugger when debug-on-event
5920 matches the current signal symbol.
5921
f2d3ba6f
DN
59222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5923
5924 * alloc.c (check_sblock, check_string_bytes)
5925 (check_string_free_list): Convert to standard C.
5926
42ce4c63
TZ
59272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5928
5929 * w32.c (emacs_gnutls_push): Fix typo.
5930
825cd63c
EZ
59312011-04-25 Eli Zaretskii <eliz@gnu.org>
5932
fb11d64d
EZ
5933 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5934 "cast to pointer from integer of different size".
5935
825cd63c
EZ
5936 Improve doprnt and its use in verror. (Bug#8545)
5937 * doprnt.c (doprnt): Document the set of format control sequences
5938 supported by the function. Use SAFE_ALLOCA instead of always
5939 using `alloca'.
5940
5941 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5942 is one byte too soon. Don't use xrealloc; instead xfree and
5943 xmalloc anew.
5944
e061a11b
TZ
59452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5946
5947 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5948 callbacks stage.
5949
5950 * gnutls.c: Renamed global_initialized to
5951 gnutls_global_initialized. Added internals for the
5952 :verify-hostname-error, :verify-error, and :verify-flags
5953 parameters of `gnutls-boot' and documented those parameters in the
5954 docstring. Start callback support.
9173deec
JB
5955 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5956 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5957 on error. Return error code.
e061a11b
TZ
5958 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5959 (emacs_gnutls_read): Likewise.
5960 (Fgnutls_boot): Return handshake error code.
5961 (emacs_gnutls_handle_error): New function.
5962 (wsaerror_to_errno): Likewise.
5963
5964 * w32.h (emacs_gnutls_pull): Add prototype.
5965 (emacs_gnutls_push): Likewise.
5966
5967 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5968 (emacs_gnutls_push): Likewise.
5969
59702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5971
5972 * process.c (wait_reading_process_output): Check if GnuTLS
5973 buffered some data internally if no FDs are set for TLS
5974 connections.
5975
5976 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5977 (LIBS): Link to USER_LIBS.
5978 ($(BLD)/gnutls.$(0)): New target.
5979
fa6996bc
EZ
59802011-04-24 Eli Zaretskii <eliz@gnu.org>
5981
eb35682e
EZ
5982 * xdisp.c (handle_single_display_spec): Rename the
5983 display_replaced_before_p argument into display_replaced_p, to
5984 make it consistent with the commentary. Fix typos in the
5985 commentary.
5986
e2ad650c
EZ
5987 * textprop.c (syms_of_textprop): Remove dead code.
5988 (copy_text_properties): Delete obsolete commentary about an
5989 interface that was deleted long ago. Fix typos in the description
5990 of arguments.
5991
1b2de274
EZ
5992 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5993 to changes in oldXMenu/XMenu.h from 2011-04-16.
5994 <menu_help_message, prev_menu_help_message>: Constify.
5995 (IT_menu_make_room): menu->help_text is now `const char **';
5996 adjust.
5997
5998 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5999 to changes in oldXMenu/XMenu.h from 2011-04-16.
6000 (struct XMenu): Declare `help_text' `const char **'.
6001
6002 * xfaces.c <Qunspecified>: Make extern again.
6003
6004 * syntax.c: Include sys/types.h before including regex.h, as
6005 required by Posix.
6006
762b15be
EZ
6007 * doc.c (get_doc_string): Improve the format passed to `error'.
6008
6009 * doprnt.c (doprnt): Improve commentary.
6010
6011 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6012
6013 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6014 them with etags.
6015
f1052e5d
EZ
6016 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6017 changes in globals.h immediately force recompilation.
762b15be
EZ
6018 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6019 $(CURDIR)/s/ms-w32.h.
6020 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6021
fa6996bc
EZ
6022 * character.c (Fchar_direction): Function deleted.
6023 (syms_of_character): Don't defsubr it.
6024 <char-direction-table>: Deleted.
6025
e6c3da20
EZ
60262011-04-23 Eli Zaretskii <eliz@gnu.org>
6027
6028 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6029 * doprnt.c: Include limits.h.
6030 (SIZE_MAX): New macro.
04f2d78b
CB
6031 (doprnt): Return a size_t value. 2nd arg is now size_t.
6032 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6033 Improve overflow protection. Support `l' modifier for integer
6034 conversions. Support %l conversion. Don't assume an EMACS_INT
6035 argument for integer conversions and for %c.
6036
6037 * lisp.h (doprnt): Restore prototype.
6038
6039 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6040 $(SRC)/character.h.
6041
6042 * Makefile.in (base_obj): Add back doprnt.o.
6043
6044 * deps.mk (doprnt.o): Add back prerequisites.
6045 (callint.o): Depend on character.h.
6046
6047 * eval.c (internal_lisp_condition_case): Include the handler
6048 representation in the error message.
6049 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6050 when breaking from the loop.
6051
6052 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6053
6054 * callint.c (Fcall_interactively): When displaying error message
6055 about invalid control letter, pass the character's codepoint, not
6056 a pointer to its multibyte form. Improve display of the character
6057 in octal and display also its hex code.
6058
6059 * character.c (char_string): Use %x to display the (unsigned)
6060 codepoint of an invalid character, to avoid displaying a bogus
6061 negative value.
6062
6063 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6064 `error', not SYMBOL_NAME itself.
6065
6066 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6067 character arguments to `error'.
6068
6069 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6070 to `error' in error message about FINAL_CHAR argument. Make sure
6071 FINAL_CHAR is a character, and use %c when it is passed as
6072 argument to `error'.
6073
4ffd0d6b 60742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6075
6076 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6077
6078 * w32.c: Include <time.h>.
6079 (sys_localtime): New function.
6080
4ffd0d6b 60812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6082
6083 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6084
4ffd0d6b 6085 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6086
4ffd0d6b 60872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6088
4ffd0d6b
GM
6089 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6090 zombies (Bug#8467).
aac0c6e3 6091
04c56954
EZ
60922011-04-19 Eli Zaretskii <eliz@gnu.org>
6093
6094 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6095 gl_state.e_property when gl_state.object is Qt.
6096
6097 * insdel.c (make_gap_larger): Remove limitation of buffer size
6098 to <= INT_MAX.
6099
16a43933
CY
61002011-04-18 Chong Yidong <cyd@stupidchicken.com>
6101
6102 * xdisp.c (lookup_glyphless_char_display)
6103 (produce_glyphless_glyph): Handle cons cell entry in
6104 glyphless-char-display.
6105 (Vglyphless_char_display): Document it.
6106
6107 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6108 glyphless-char-display.
6109
4581706e
CY
61102011-04-17 Chong Yidong <cyd@stupidchicken.com>
6111
6112 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6113
6114 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6115
6116 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6117 definition for no-X builds.
6118
4887c6e2 61192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6120
fd35b6f9
PE
6121 Static checks with GCC 4.6.0 and non-default toolkits.
6122
5c1ccb01
PE
6123 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6124
006c5daa
PE
6125 * process.c (keyboard_bit_set): Define only if SIGIO.
6126 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6127 (send_process): Repair possible setjmp clobbering.
6128
efc736d3
PE
6129 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6130
4e2fe2e6
PE
6131 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6132
f97334a2
PE
6133 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6134
4e75f29d
PE
6135 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6136 Define only if needed.
6137
90efadd1
PE
6138 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6139 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6140 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6141
3c647824
PE
6142 * dispextern.h (struct redisplay_interface): Rename param
6143 to avoid shadowing.
e264f262 6144 * termhooks.h (struct terminal): Likewise.
761383f4 6145 * xterm.c (xembed_send_message): Likewise.
3c647824 6146
b58c5c4a
PE
6147 * insdel.c (make_gap_smaller): Define only if
6148 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6149
cad59032
PE
6150 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6151 it.
6152
c339dc2e
PE
6153 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6154 so that we aren't warned about unused symbols.
6155
91a3e27b
PE
6156 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6157
399c71d3 6158 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6159
8ffc96f5
PE
6160 * xfns.c (x_real_positions): Mark locals as initialized.
6161
eef9bc79
PE
6162 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6163
098db9dd
PE
6164 * xterm.c: Fix problems found by static analysis with other toolkits.
6165 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6166 (x_dispatch_event): Declare static if USE_GTK, and
6167 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6168 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6169 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6170 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6171 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6172
eb18f6cc
PE
6173 * xmenu.c (menu_help_callback): Pointer type fixes.
6174 Use const pointers when pointing at readonly data. Avoid pointer
6175 signedness clashes.
6176 (FALSE): Remove unused macro.
6177 (update_frame_menubar): Remove unused decl.
6178
1fe72bf8
PE
6179 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6180
60d9e1db
PE
6181 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6182 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6183 (single_menu_item): Rename local to avoid shadowing.
6184
39261c26
PE
6185 * keyboard.c (make_lispy_event): Remove unused local var.
6186
018c5e19
PE
6187 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6188 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6189
63d2b86e
PE
6190 * bitmaps: Change bitmaps from unsigned char back to the X11
6191 compatible char. Avoid the old compiler warnings about
6192 out-of-range initializers by using, for example, '\xab' rather
6193 than 0xab.
6194
aefd87e1
PE
6195 * xgselect.c (xgselect_initialize): Check vs interface
6196 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6197
bf501fb9
PE
6198 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6199
e9829fdf
PE
6200 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6201 to read-only memory.
6202
1086c095
PE
6203 * fns.c (vector): Remove; this old hack is no longer needed.
6204
2baccd04 6205 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6206 Remove unused var.
dde42981 6207 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6208
72391843 6209 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6210
436c16df 6211 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6212 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6213 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6214
92bb796d 6215 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6216 (x_term_init): Remove local to avoid shadowing.
92bb796d 6217
764430a3 6218 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6219
6220 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6221 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6222
d1dfb56c
EZ
62232011-04-16 Eli Zaretskii <eliz@gnu.org>
6224
c4354cb4
EZ
6225 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6226
d1dfb56c
EZ
6227 Fix regex.c, syntax.c and friends for buffers > 2GB.
6228 * syntax.h (struct gl_state_s): Declare character position members
6229 EMACS_INT.
6230
6231 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6232
04f2d78b
CB
6233 * textprop.c (verify_interval_modification, interval_of):
6234 Declare arguments EMACS_INT.
d1dfb56c
EZ
6235
6236 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6237 EMACS_INT.
6238
6239 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6240
6241 * indent.c (Fvertical_motion): Local variable it_start is now
6242 EMACS_INT.
6243
6244 * regex.c (re_match, re_match_2, re_match_2_internal)
6245 (bcmp_translate, regcomp, regexec, print_double_string)
6246 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6247 (re_compile_pattern, re_exec): Declare arguments and local
6248 variables `size_t' and `ssize_t' and return values `regoff_t', as
6249 appropriate.
6250 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6251 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6252 <compile_stack_type>: `size' and `avail' are now `size_t'.
6253
6254 * regex.h <regoff_t>: Use ssize_t, not int.
6255 (re_search, re_search_2, re_match, re_match_2): Arguments that
6256 specify buffer/string position and length are now ssize_t and
6257 size_t. Return type is regoff_t.
6258
613052cd
BK
62592011-04-16 Ben Key <bkey76@gmail.com>
6260
6261 * nsfont.m: Fixed bugs in ns_get_family and
6262 ns_descriptor_to_entity that were caused by using free to
6263 deallocate memory blocks that were allocated by xmalloc (via
6264 xstrdup). This caused Emacs to crash when compiled with
6265 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6266 --enable-checking=xmallocoverrun). xfree is now used to
6267 deallocate these memory blocks.
6268
4170f62f 62692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6270
71b41406
PE
6271 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6272
9587a89d
PE
6273 emacs_write: Accept and return EMACS_INT for sizes.
6274 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6275 et seq.
6276 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6277 Accept and return EMACS_INT.
6278 (emacs_gnutls_write): Return the number of bytes written on
6279 partial writes.
6280 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6281 (emacs_read, emacs_write): Remove check for negative size, as the
6282 Emacs source code has been audited now.
9587a89d
PE
6283 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6284 (emacs_read, emacs_write): Use it.
273a5f82
PE
6285 * process.c (send_process): Adjust to the new signatures of
6286 emacs_write and emacs_gnutls_write. Do not attempt to store
6287 a byte offset into an 'int'; it might overflow.
9587a89d 6288 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6289
3e047f51
PE
6290 * sound.c: Don't assume sizes fit in 'int'.
6291 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6292 Return EMACS_INT, not int.
3e047f51 6293 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6294 Accept EMACS_INT, not int.
6295 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6296 record read return values.
6297
cc39a9db
BK
62982011-04-15 Ben Key <bkey76@gmail.com>
6299
c9d0ec6d
JB
6300 * keyboard.c (Qundefined): Don't declare static since it is used
6301 in nsfns.m.
6302 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6303 static since they are used in nsfont.m.
cc39a9db 6304
6c60eb9f
SM
63052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6306
6307 * process.c (Qprocessp): Don't declare static.
6308 * lisp.h (Qprocessp): Declare again.
6309
7990b61a
JB
63102011-04-15 Juanma Barranquero <lekktu@gmail.com>
6311
6312 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6313
5d4cb038
PE
63142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6315
8bd7b830 6316 Improve C-level modularity by making more things 'static'.
cd64ea1d 6317
e3b27b31
PE
6318 Don't publish debugger-only interfaces to other modules.
6319 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6320 (verify_bytepos, count_markers): Move decls to the only modules
6321 that need them.
6322 * region-cache.h (pp_cache): Likewise.
6323 * window.h (check_all_windows): Likewise.
6324 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6325
5d4cb038
PE
6326 * sysdep.c (croak): Now static, if
6327 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6328 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6329
6330 * alloc.c (refill_memory_reserve): Now static if
6331 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6332 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6333
e87b6180
PE
6334 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6335 Define only if USE_LUCID.
6336
ac64929e
PE
6337 * xrdb.c (x_customization_string, x_rm_string): Now static.
6338
6f37259d
PE
6339 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6340 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6341
1683e3ab
PE
6342 * xdisp.c (draw_row_with_mouse_face): Now static.
6343 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6344
de9c2632
PE
6345 * window.h (check_all_windows): Mark externally visible.
6346
2b96acb7
PE
6347 * window.c (window_deletion_count): Now static.
6348
6349 * undo.c: Make symbols static if they're not exported.
6350 (last_undo_buffer, last_boundary_position, pending_boundary):
6351 Now static.
6352
50436f33
PE
6353 * textprop.c (interval_insert_behind_hooks): Now static.
6354 (interval_insert_in_front_hooks): Likewise.
6355
64520e5c
PE
6356 * term.c: Make symbols static if they're not exported.
6357 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6358 (max_frame_lines, tty_set_terminal_modes):
6359 (tty_reset_terminal_modes, tty_turn_off_highlight):
6360 (get_tty_terminal): Now static.
6361 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6362 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6363 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6364 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6365 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6366
1fa53021
PE
6367 * sysdep.c: Make symbols static if they're not exported.
6368 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6369 Now static.
6370 (sigprocmask_set, full_mask): Remove; unused.
6371 (wait_debugging): Mark as visible.
6372 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6373 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6374
d4b43b22
PE
6375 * syntax.c (syntax_temp): Define only if !__GNUC__.
6376
b7c513d0
PE
6377 * sound.c (current_sound_device, current_sound): Now static.
6378
989b29ad
PE
6379 * search.c (searchbufs, searchbuf_head): Now static.
6380
13a55a78
PE
6381 * scroll.c (scroll_cost): Remove; unused.
6382 * dispextern.h (scroll_cost): Remove decl.
6383
de68a1fc
PE
6384 * region-cache.h (pp_cache): Mark as externally visible.
6385
40ccffa6
PE
6386 * process.c: Make symbols static if they're not exported.
6387 (process_tick, update_tick, create_process, chan_process):
6388 (Vprocess_alist, proc_buffered_char, datagram_access):
6389 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6390 (deactivate_process): Mark defn as static, as well as decl.
6391 * lisp.h (create_process): Remove decl.
6392 * process.h (chan_process, Vprocess_alist): Remove decls.
6393
ad64fc97
PE
6394 * print.c: Make symbols static if they're not exported.
6395 (print_depth, new_backquote_output, being_printed, print_buffer):
6396 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6397 (print_interval, print_number_index, initial_stderr_stream):
6398 Now static.
6399 * lisp.h (Fprinc): Remove decl.
6400 (debug_output_compilation_hack): Mark as externally visible.
6401
adddb265
PE
6402 * sysdep.c (croak): Move decl from here to syssignal.h.
6403 * syssignal.h (croak): Put it here, so the API can be checked when
6404 'croak' is called from dissociate_if_controlling_tty.
6405
1717ede2
PE
6406 * minibuf.c: Make symbols static if they're not exported.
6407 (minibuf_save_list, choose_minibuf_frame): Now static.
6408 * lisp.h (choose_minibuf_frame): Remove decl.
6409
fa5fb2bc
PE
6410 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6411
1e3890d1
PE
6412 * lread.c: Make symbols static if they're not exported.
6413 (read_objects, initial_obarray, oblookup_last_bucket_number):
6414 Now static.
6415 (make_symbol): Remove; unused.
6416 * lisp.h (initial_obarray, make_symbol): Remove decls.
6417
8a1414fa
PE
6418 * keyboard.c: Make symbols static if they're not exported.
6419 (single_kboard, recent_keys_index, total_keys, recent_keys):
6420 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6421 (this_single_command_key_start, echoing, last_auto_save):
6422 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6423 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6424 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6425 (Vlispy_mouse_stem, double_click_count):
6426 Now static.
6427 (force_auto_save_soon): Define only if SIGDANGER.
6428 (ignore_mouse_drag_p): Now static if
6429 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6430 (print_help): Remove; unused.
6431 (stop_character, last_timer_event): Mark as externally visible.
6432 * keyboard.h (ignore_mouse_drag_p): Declare only if
6433 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6434 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6435 * lisp.h (echoing): Remove decl.
6436 (force_auto_save_soon): Declare only if SIGDANGER.
6437 * xdisp.c (redisplay_window): Simplify code, to make it more
6438 obvious that ignore_mouse_drag_p is not accessed if !defined
6439 USE_GTK && !defined HAVE_NS.
6440
93ea6e8f
PE
6441 * intervals.c: Make symbols static if they're not exported.
6442 (merge_properties_sticky, merge_interval_right, delete_interval):
6443 Now static.
6444 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6445
77382fcc
PE
6446 * insdel.c: Make symbols static if they're not exported.
6447 However, leave prepare_to_modify_buffer alone. It's never
6448 called from outside this function, but that appears to be a bug.
6449 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6450 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6451 (adjust_after_replace_noundo): Remove; unused.
6452 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6453 (signal_before_change): Remove decls.
77382fcc 6454
9306c32e
PE
6455 * indent.c (val_compute_motion, val_vmotion): Now static.
6456
cd44d2eb
PE
6457 * image.c: Make symbols static if they're not exported.
6458 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6459 if USE_GTK.
6460 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6461 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6462
ad9a7a06
PE
6463 * fringe.c (standard_bitmaps): Now static.
6464 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6465
81626931
PE
6466 * frame.c: Make symbols static if they're not exported.
6467 (x_report_frame_params, make_terminal_frame): Now static.
6468 (get_frame_param): Now static, unless HAVE_NS.
6469 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6470 (x_get_resource_string): Remove; not used.
6471 * frame.h (make_terminal_frame, x_report_frame_params):
6472 (x_get_resource_string); Remove decls.
6473 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6474 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6475
239f9db9
PE
6476 * font.c, fontset.c: Make symbols static if they're not exported.
6477 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6478 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6479 * font.c (font_close_object): Now static.
6480 * font.h (font_close_object): Remove.
6481 * fontset.c (FONTSET_OBJLIST): Remove.
6482 (free_realized_fontset) #if-0 the body, which does nothing.
6483 (face_suitable_for_char_p): #if-0, as it's never called.
6484 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6485 * xfaces.c (face_at_string_position):
6486 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6487 since 0 is always ASCII.
6488
dfcf3579
PE
6489 * fns.c (weak_hash_tables): Now static.
6490
5045092b
PE
6491 * fileio.c: Make symbols static if they're not exported.
6492 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6493 (Vwrite_region_annotation_buffers): Now static.
6494
57a96f5c
PE
6495 * eval.c: Make symbols static if they're not exported.
6496 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6497 * lisp.h (backtrace_list): Remove decl.
6498
35f08c38
PE
6499 * emacs.c: Make symbols static if they're not exported.
6500 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6501 (fatal_error_code, fatal_error_signal_hook, standard_args):
6502 Now static.
6503 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6504 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6505 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6506 * lisp.h (fatal_error_signal_hook): Remove decl.
6507 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6508
f44bd759
PE
6509 * editfns.c: Move a (normally-unused) function to its only use.
6510 * editfns.c, lisp.h (get_operating_system_release): Remove.
6511 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6512 worth the hassle of breaking this out.
6513
b532497d
PE
6514 * xterm.c: Make symbols static if they're not exported.
6515 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6516 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6517 (x_destroy_window, x_delete_display):
6518 Now static.
6519 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6520 (x_mouse_leave): Remove; unused.
6521 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6522 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6523 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6524 Remove decls.
6525 (x_mouse_leave): Declare only if WINDOWSNT.
6526 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6527 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6528 USE_X_TOOLKIT.
6529
1675728f
PE
6530 * ftxfont.c: Make symbols static if they're not exported.
6531 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6532 HAVE_FREETYPE.
6533 * font.h (ftxfont_driver): Likewise.
6534
e4cebfca
PE
6535 * xfns.c: Make symbols static if they're not exported.
6536 (x_last_font_name, x_display_info_for_name):
6537 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6538 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6539 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6540 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6541 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6542 (last_show_tip_args): Now static.
6543 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6544 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6545 (x_screen_planes): Remove; unused.
6546 * dispextern.h (x_screen_planes): Remove decl.
6547
5bf46f05
PE
6548 * dispnew.c: Make symbols static if they're not exported.
6549 * dispextern.h (redraw_garbaged_frames, scrolling):
6550 (increment_row_positions): Remove.
6551 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6552 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6553 Now static.
6554 (redraw_garbaged_frames): Remove; unused.
6555
435f4c28
PE
6556 * xfaces.c: Make symbols static if they're not exported.
6557 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6558 Remove decls.
6559 * xterm.h (defined_color): Remove decls.
6560 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6561 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6562 (menu_face_changed_default, defined_color, free_realized_face):
6563 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6564 (ascii_face_of_lisp_face): Remove; unused.
6565
8524aef3
PE
6566 * xdisp.c: Make symbols static if they're not exported.
6567 * dispextern.h (scratch_glyph_row, window_box_edges):
6568 (glyph_to_pixel_coords, set_cursor_from_row):
6569 (get_next_display_element, set_iterator_to_next):
6570 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6571 (show_mouse_face): Remove decls
6572 * frame.h (message_buf_print): Likewise.
6573 * lisp.h (pop_message, set_message, check_point_in_composition):
6574 Likewise.
6575 * xterm.h (set_vertical_scroll_bar): Likewise.
6576 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6577 (message_buf_print, scratch_glyph_row, displayed_buffer):
6578 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6579 (get_next_display_element, show_mouse_face, window_box_edges):
6580 (frame_to_window_pixel_xy, check_point_in_composition):
6581 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6582 (glyph_to_pixel_coords): Remove; unused.
6583
16390cd2
PE
6584 * dired.c (file_name_completion): Now static.
6585
6586 * dbusbind.c (xd_in_read_queued_messages): Now static.
6587
a25f4dfa
PE
6588 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6589 * data.c (circular_list_error): Remove.
6590
14a9c8df
PE
6591 * commands.h (last_point_position, last_point_position_buffer):
6592 (last_point_position_window): Remove decls.
6593 * keyboard.c: Make these variables static.
6594
04f2d78b
CB
6595 * coding.h (coding, code_convert_region, encode_coding_gap):
6596 Remove decls.
74ab6df5
PE
6597 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6598 (iso_code_class, detect_coding, code_convert_region): Now static.
6599 (encode_coding_gap): Remove; unused.
6600
38dfbee1
PE
6601 * chartab.c (chartab_chars, chartab_bits): Now static.
6602
a2cb4e63
PE
6603 * charset.h (charset_iso_8859_1): Remove decl.
6604 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6605 Now static.
6606
127198fd
PE
6607 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6608 * ccl.c (Vccl_program_table): Now static.
6609 (check_ccl_update): Remove; unused.
6610
d85b608f
PE
6611 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6612 * category.h: ... from here.
6613 * category.c (check_category_table, set_category_set): Now static.
6614
31cd66f3
PE
6615 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6616 * lisp.h: Remove these decls.
6617
c358e587
PE
6618 * buffer.c (buffer_count): Remove unused var.
6619
e78aecca
PE
6620 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6621 so that it's not optimized away.
6622 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6623 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6624 exported only to the debugger.
6625
e192d7d3 6626 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6627 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6628
92470028
PE
6629 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6630 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6631 was inaccessible from Lisp.
6632 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6633 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6634
244ed907
PE
6635 alloc.c: Import and export fewer symbols, and remove unused items.
6636 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6637 is defined.
6638 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6639 it's not optimized away by whole-program optimization.
6640 (message_enable_multibyte, free_misc): Remove.
6641 (catchlist, handlerlist, mark_backtrace):
6642 Declare only if BYTE_MARK_STACK.
6643 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6644 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6645 (message_enable_multibyte): Remove decl.
6646 (free_misc, interval_free_list, float_block, float_block_index):
6647 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6648 (cons_free_list, last_marked_index):
6649 Now static.
6650 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6651 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6652 (mark_backtrace): Define only if BYTE_MARK_STACK.
6653 * xdisp.c (message_enable_multibyte): Now static.
6654
61c2b50e 6655 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6656 This makes it easier for human readers (and static analyzers)
6657 to see whether these variables are used from other modules.
6658 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6659 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6660 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6661 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6662 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6663 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6664 * xmenu.c, xselect.c:
6665 Declare Q* vars static if they are not used in other modules.
6666 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6667 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6668 Remove decls of unexported vars.
6669 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6670
95c82688
PE
6671 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6672
16a97296
PE
6673 Make Emacs functions such as Fatom 'static' by default.
6674 This makes it easier for human readers (and static analyzers)
6675 to see whether these functions can be called from other modules.
6676 DEFUN now defines a static function. To make the function external
6677 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6678 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6679 (Finit_image_library):
16a97296
PE
6680 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6681 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6682 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6683 Remove decls, since these functions are now static.
6684 (Funintern, Fget_internal_run_time): New decls, since these functions
6685 were already external.
95c82688 6686
16a97296
PE
6687 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6688 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6689 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6690 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6691 * keyboard.c, keymap.c, lread.c:
6692 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6693 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6694 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6695 Mark functions with DEFUE instead of DEFUN,
6696 if they are used in other modules.
6697 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6698 decls for now-static functions.
6699 * buffer.h (Fdelete_overlay): Remove decl.
6700 * callproc.c (Fgetenv_internal): Mark as internal.
6701 * composite.c (Fremove_list_of_text_properties): Remove decl.
6702 (Fcomposition_get_gstring): New forward static decl.
6703 * composite.h (Fcomposite_get_gstring): Remove decl.
6704 * dired.c (Ffile_attributes): New forward static decl.
6705 * doc.c (Fdocumntation_property): New forward static decl.
6706 * eval.c (Ffetch_bytecode): New forward static decl.
6707 (Funintern): Remove extern decl; now in .h file where it belongs.
6708 * fileio.c (Fmake_symbolic_link): New forward static decl.
6709 * image.c (Finit_image_library): New forward static decl.
6710 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6711 * intervals.h (Fprevious_property_change):
6712 (Fremove_list_of_text_properties): Remove decls.
6713 * keyboard.c (Fthis_command_keys): Remove decl.
6714 (Fcommand_execute): New forward static decl.
6715 * keymap.c (Flookup_key): New forward static decl.
6716 (Fcopy_keymap): Now static.
6717 * keymap.h (Flookup_key): Remove decl.
6718 * process.c (Fget_process): New forward static decl.
6719 (Fprocess_datagram_address): Mark as internal.
6720 * syntax.c (Fsyntax_table_p): New forward static decl.
6721 (skip_chars): Remove duplicate decl.
6722 * textprop.c (Fprevious_property_change): New forward static decl.
6723 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6724 Now internal.
6725 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6726 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6727
785bbd42
PE
6728 * editfns.c (Fformat): Remove unreachable code.
6729
8b913b57
AS
67302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6731
6732 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6733 change. (Bug#8496)
6734
a6744a35
EZ
67352011-04-13 Eli Zaretskii <eliz@gnu.org>
6736
6737 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6738 when at ZV. (Bug#8487)
6739
e7974947
AS
67402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6741
baad03f0
AS
6742 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6743 (Bug#8437)
6744 * keyboard.c (parse_tool_bar_item): Likewise.
6745 * sound.c (sound_cleanup, alsa_close): Likewise.
6746 * termcap.c (tgetent): Likewise.
6747 * xfns.c (x_default_font_parameter): Likewise.
6748 * xsettings.c (read_and_apply_settings): Likewise.
6749
e7974947
AS
6750 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6751 (overrun_check_free): Protoize.
6752
28272684
PE
67532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6754
6755 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6756 since callers should never pass a negative size.
6757 Change the signature to match that of plain 'read' and 'write'; see
6758 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6759 * lisp.h: Update prototypes of emacs_write and emacs_read.
6760
11997c76
EZ
67612011-04-11 Eli Zaretskii <eliz@gnu.org>
6762
6763 * xdisp.c (redisplay_window): Don't try to determine the character
6764 position of the scroll margin if the window start point w->startp
e896f03c 6765 is outside the buffer's accessible region. (Bug#8468)
11997c76 6766
8a2cbd72
EZ
67672011-04-10 Eli Zaretskii <eliz@gnu.org>
6768
6769 Fix write-region and its subroutines for buffers > 2GB.
6770 * fileio.c (a_write, e_write): Modify declaration of arguments and
6771 local variables to support buffers larger than 2GB.
6772 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6773
6774 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6775 argument, local variables, and return value.
6776
6777 * lisp.h: Update prototypes of emacs_write and emacs_read.
6778
6779 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6780
4073e537 67812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6782
1ebfdcb6
PE
6783 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6784
b2ded58d
PE
6785 Fix more problems found by GCC 4.6.0's static checks.
6786
7d66342c
PE
6787 * xdisp.c (vmessage): Use a better test for character truncation.
6788
bbf47d44
PE
6789 * charset.c (load_charset_map): <, not <=, for optimization,
6790 and to avoid potential problems with integer overflow.
9248994d 6791 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6792 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6793 * editfns.c (Fformat): Likewise.
1e69125e 6794 * syntax.c (skip_chars): Likewise.
3befa583 6795
e3019616
PE
6796 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6797 This also lets GCC 4.6.0 generate slightly better loop code.
6798
becfa255
PE
6799 * callint.c (Fcall_interactively): <, not <=, for optimization.
6800 (Fcall_interactively): Count the number of arguments produced,
6801 not the number of arguments given. This is simpler and lets GCC
6802 4.6.0 generate slightly better code.
6803
dae0cd48
PE
6804 * ftfont.c: Distingish more carefully between FcChar8 and char.
6805 The previous code passed unsigned char * to a functions like
6806 strlen and xstrcasecmp that expect char *, which does not
6807 conform to the C standard.
6808 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6809 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6810 char * when the C standard requires it.
6811
76032d70
PE
6812 * keyboard.c (read_char): Remove unused var.
6813
eb3f1cc8
PE
6814 * eval.c: Port to Windows vsnprintf (Bug#8435).
6815 Include <limits.h>.
6816 (SIZE_MAX): Define if the headers do not.
6817 (verror): Do not give up if vsnprintf returns a negative count.
6818 Instead, grow the buffer. This ports to Windows vsnprintf, which
6819 does not conform to C99. Problem reported by Eli Zaretskii.
6820 Also, simplify the allocation scheme, by avoiding the need for
6821 calling realloc, and removing the ALLOCATED variable.
6822
70476b54
PE
6823 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6824
12020a9e
PE
6825 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6826 But keep the doprint source code for now, as we might revamp it
6827 and use it again (Bug#8435).
ea6c7ae6
PE
6828 * lisp.h (doprnt): Remove.
6829 * Makefile.in (base_obj): Remove doprnt.o.
6830 * deps.mk (doprnt.o): Remove.
6831
5fdb398c
PE
6832 error: Print 32- and 64-bit integers portably (Bug#8435).
6833 Without this change, on typical 64-bit hosts error ("...%d...", N)
6834 was used to print both 32- and 64-bit integers N, which relied on
6835 undefined behavior.
6836 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6837 New macro.
6838 * lisp.h (error, verror): Mark as printf-like functions.
6839 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6840 Report overflow in size calculations when allocating printf buffer.
6841 Do not truncate output string at its first null byte.
6842 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6843 Truncate the output at a character boundary, since vsnprintf does not
6844 do that.
6845 * charset.c (check_iso_charset_parameter): Convert internal
6846 character to string before calling 'error', since %c now has the
6847 printf meaning.
6848 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6849 overflow when computing char to be passed to 'error'. Do not
6850 pass Lisp_Object to 'error'; pass the integer instead.
6851 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6852 formatted with plain %d.
6853
b189fa66
PE
6854 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6855
bff87ef0
PE
6856 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6857
7e2cac20
PE
6858 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6859
ce4d90b5
PE
6860 * xterm.c (x_catch_errors): Remove duplicate declaration.
6861
266c9547
PE
6862 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6863
79c49ad2
PE
6864 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6865
368f4090
JM
68662011-04-10 Jim Meyering <meyering@redhat.com>
6867
6868 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6869 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6870 return ssize_t not "int", and use size_t as the buffer length.
6871 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6872 * gnutls.h: Update declarations.
6873 * process.c (read_process_output): Use ssize_t, to match.
6874 (send_process): Likewise.
6875
a32d4040
CY
68762011-04-09 Chong Yidong <cyd@stupidchicken.com>
6877
6878 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6879
8546720e 68802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6881
04f2d78b
CB
6882 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6883 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6884
8546720e
GM
6885 * xterm.c (handle_one_xevent):
6886 * xmenu.c (create_and_show_popup_menu):
6887 * xselect.c (x_decline_selection_request)
6888 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6889
0a2f5c1a 68902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6891
6892 Fix some uses of `int' instead of EMACS_INT.
6893 * search.c (string_match_1, fast_string_match)
6894 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6895 (scan_buffer, find_next_newline_no_quit)
6896 (find_before_next_newline, search_command, Freplace_match)
6897 (Fmatch_data): Make some `int' variables be EMACS_INT.
6898
6899 * xdisp.c (display_count_lines): 3rd argument and return value now
6900 EMACS_INT. All callers changed.
6901 (pint2hrstr): Last argument is now EMACS_INT.
6902
6903 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6904 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6905 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6906 (decode_coding_utf_16, decode_coding_emacs_mule)
6907 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6908 (decode_coding_ccl, decode_coding_charset)
6909 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6910 (decode_coding_iso_2022, decode_coding_emacs_mule)
6911 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6912 <char_offset, last_offset>: Declare EMACS_INT.
6913 (encode_coding_utf_8, encode_coding_utf_16)
6914 (encode_coding_emacs_mule, encode_invocation_designation)
6915 (encode_designation_at_bol, encode_coding_iso_2022)
6916 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6917 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6918 Declare EMACS_INT.
6919 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6920 (encode_invocation_designation): Last argument P_NCHARS is now
6921 EMACS_INT.
6922 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6923 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6924
6925 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6926 All users changed.
6927
6928 * ccl.c (Fccl_execute_on_string): Declare some variables
6929 EMACS_INT.
6930
8546720e 69312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6932
6933 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6934
4e19a977
CS
69352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6936
6937 * process.c (Fformat_network_address): Doc fix.
6938
87302331
R
69392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6940
6941 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6942
cbb59342
CY
69432011-04-08 Chong Yidong <cyd@stupidchicken.com>
6944
6945 * keyboard.c (read_char): Call Lisp function help-form-show,
6946 instead of using internal_with_output_to_temp_buffer.
6947 (Qhelp_form_show): New var.
e0d38eeb 6948 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6949
6950 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6951
6952 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6953
e67a13ab
CY
69542011-04-06 Chong Yidong <cyd@stupidchicken.com>
6955
04f2d78b
CB
6956 * process.c (Flist_processes): Remove to Lisp.
6957 (list_processes_1): Delete.
e67a13ab 6958
973f782d
EZ
69592011-04-06 Eli Zaretskii <eliz@gnu.org>
6960
7c106b1e
EZ
6961 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6962
973f782d
EZ
6963 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6964
41cf7d1a 69652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6966
ca23cc88
PE
6967 Fix more problems found by GCC 4.6.0's static checks.
6968
f390e2d5
PE
6969 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6970
42eea0d0
PE
6971 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6972
b69769da 6973 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6974
f9541e84
PE
6975 * xdisp.c (vmessage): Mark as a printf-like function.
6976
13841b55
PE
6977 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6978
c136c10f
PE
6979 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6980
5e2d4a30
PE
6981 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6982 printf-like functions.
6983 (tiff_load): Add casts to remove these marks before passing them
6984 to system-supplied API.
6985
583f48b9
PE
6986 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6987
b25d760e
PE
6988 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6989 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6990 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6991 directly, rather than having caller test rule sign. This avoids
6992 some unnecessary tests.
6993 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6994 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6995 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6996
bc7b6697 6997 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6998 (xfont_open): Avoid unnecessary tests.
bc7b6697 6999
27ccc379
PE
7000 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7001
dcd5c89a
PE
7002 * composite.h, composite.c (composition_gstring_put_cache):
7003 Use EMACS_INT, not int, for length.
7004
b13a45c6
PE
7005 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7006 breaking out part of COMPOSITION_DECODE_RULE.
7007 (COMPOSITION_DECODE_RULE): Use it.
7008 * composite.c (get_composition_id): Remove unused local vars,
7009 by using the new macro.
7010
1e792e4d
PE
7011 * textprop.c (set_text_properties_1): Change while to do-while,
7012 since the condition is always true at first.
7013
dc6c6455 7014 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7015 (interval_deletion_adjustment): Return unsigned value.
7016 All uses changed.
dc6c6455 7017
aba7731a
PE
7018 * process.c (list_processes_1, create_pty, read_process_output):
7019 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7020 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7021 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7022 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7023 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7024
fdfc4bf3
PE
7025 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7026
fca8fe46 7027 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7028 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7029
06a0259a 7030 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7031 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7032 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7033
e7b9e80f
PE
7034 * print.c (print_error_message): Avoid int overflow.
7035
56201685
PE
7036 * font.c (font_list_entities): Redo for clarity,
7037 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7038
78834453 7039 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7040 (font_score): Avoid potential overflow in diff calculation.
78834453 7041
0bc0b309 7042 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7043 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7044
e610eaca
PE
7045 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7046
b895abce
PE
7047 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7048 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7049 can always succeed if overflow has undefined behavior.
7050
1f1d9321 7051 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7052 (wordify): Omit three unnecessary tests.
1f1d9321 7053
c59478bc
PE
7054 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7055 All callers changed. This avoids the need for an unused var.
7056
79b73827
PE
7057 * casefiddle.c (casify_region): Remove var that is set but not used.
7058
a4db5dfe
PE
7059 * dired.c (file_name_completion): Remove var that is set but not used.
7060
43aae36e
PE
7061 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7062
2a47c44d 7063 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7064 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7065
a37c69bf
PE
7066 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7067 Check for integer overflow on size calculations.
7068
328ab8e7
PE
7069 * buffer.c (Fprevious_overlay_change): Remove var that is set
7070 but not used.
7071
e5a2a5cb
PE
7072 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7073 Remove vars that are set but not used.
8d84a6eb 7074 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7075 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7076
a60e5f68
PE
7077 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7078
f661cb61 7079 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7080 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7081
f0397f5a
PE
7082 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7083 that are set but not used.
7084
8664db06 7085 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7086 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7087
6abdaa4a
PE
7088 * xselect.c (x_get_local_selection, x_handle_property_notify):
7089 Remove vars that are set but not used.
7090
0ce7538d 7091 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7092 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7093
9ae848fc
PE
7094 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7095 Remove var that is set but not used.
0b918413
PE
7096 (scroll_bar_windows_size): Now size_t, not int.
7097 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7098 Check for overflow.
9ae848fc 7099
a5a62657
PE
7100 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7101 (map_tty_color) [!defined MSDOS]: Likewise.
7102
5c5cdd39
PE
7103 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7104
66ebf983
PE
7105 * coding.c: Remove vars that are set but not used.
7106 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7107 All callers changed.
7108 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7109 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7110 (decode_coding_charset): Remove vars that are set but not used.
7111
1be4d761
PE
7112 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7113 that is set but not used.
7114
47553fa8
PE
7115 * print.c (print_object): Remove var that is set but not used.
7116
1f7196bf 7117 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7118 The gnulib version avoids calling malloc in the usual case,
7119 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7120 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7121 * filelock.c (current_lock_owner): Likewise.
7122 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7123 * sysdep.c: Include allocator.h, careadlinkat.h.
7124 (emacs_no_realloc_allocator): New static constant.
7125 (emacs_readlink): New function.
fdb61804
PE
7126 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7127 ../lib/careadlinkat.h.
d1fdcab7 7128
f84c17c7
SM
71292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7130
7131 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7132 first non-nil return value).
7133
ef3862ad
JD
71342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7135
7136 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7137 if not defined (Bug#8403).
7138
376a7006
JB
71392011-04-02 Juanma Barranquero <lekktu@gmail.com>
7140
7141 * xdisp.c (display_count_lines): Remove parameter `start',
7142 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7143 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7144 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7145 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7146 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7147 and thereabouts. All callers changed.
7148 (get_per_char_metric): Remove parameter `f', unused since
7149 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7150
6ca3801d
JM
71512011-04-02 Jim Meyering <meyering@redhat.com>
7152
7153 do not dereference NULL upon failed strdup
7154 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7155 (ns_get_family): Likewise.
7156
d8e2b5ba
JB
71572011-04-02 Juanma Barranquero <lekktu@gmail.com>
7158
7159 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7160
8c74fcbd
JD
71612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7162
7163 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7164 later (Bug#8403).
7165
7200d79c
SM
71662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7167
03408648 7168 Add lexical binding.
7200d79c 7169
03408648
SM
7170 * window.c (Ftemp_output_buffer_show): New fun.
7171 (Fsave_window_excursion):
7172 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7173
7174 * lread.c (lisp_file_lexically_bound_p): New function.
7175 (Fload): Bind Qlexical_binding.
7176 (readevalloop): Remove `evalfun' arg.
7177 Bind Qinternal_interpreter_environment.
7178 (Feval_buffer): Bind Qlexical_binding.
7179 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7180 Mark as dynamic.
7181 (syms_of_lread): Declare `lexical-binding'.
7182
7183 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7184
7185 * keyboard.c (eval_dyn): New fun.
7186 (menu_item_eval_property): Use it.
ca105506
SM
7187
7188 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7189
03408648
SM
7190 * fns.c (concat, mapcar1): Accept byte-code-functions.
7191
7192 * eval.c (Fsetq): Handle lexical vars.
7193 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7194 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7195 (FletX, Flet): Obey lexical binding.
7196 (Fcommandp): Handle closures.
7197 (Feval): New `lexical' arg.
7198 (eval_sub): New function extracted from Feval. Use it almost
7199 everywhere where Feval was used. Look up vars in lexical env.
7200 Handle closures.
7201 (Ffunctionp): Move from subr.el.
7202 (Ffuncall): Handle closures.
7203 (apply_lambda): Remove `eval_flags'.
7204 (funcall_lambda): Handle closures and new byte-code-functions.
7205 (Fspecial_variable_p): New function.
7206 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7207 but without exporting it to Lisp.
23aba0ea 7208
23aba0ea 7209 * doc.c (Fdocumentation, store_function_docstring):
03408648 7210 * data.c (Finteractive_form): Handle closures.
23aba0ea 7211
03408648
SM
7212 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7213 interactive spec.
ba83908c 7214
04f2d78b
CB
7215 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7216 New byte-codes.
03408648
SM
7217 (exec_byte_code): New function extracted from Fbyte_code to handle new
7218 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7219
03408648 7220 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7221
03408648 7222 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7223
e2abce01
JB
72242011-03-31 Juanma Barranquero <lekktu@gmail.com>
7225
7226 * xdisp.c (redisplay_internal): Fix prototype.
7227
63696a73 72282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7229
63696a73 7230 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7231 (try_scrolling): Use it when setting scroll_limit.
7232 Limit scrolling to 100 screen lines.
63696a73
EZ
7233 (redisplay_window): Even when falling back on "recentering",
7234 position point in the window according to scroll-conservatively,
7235 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7236
7237 (try_scrolling): When point is above the window, allow searching
7238 as far as scroll_max, or one screenful, to compute vertical
7239 distance from PT to the scroll margin position. This prevents
7240 try_scrolling from unnecessarily failing when
7241 scroll-conservatively is set to a value slightly larger than the
7242 window height. Clean up the case of PT below the margin at bottom
7243 of window: scroll_max can no longer be INT_MAX. When aggressive
7244 scrolling is in use, don't let point enter the opposite scroll
7245 margin as result of the scroll.
7246 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7247 threshold of 100 lines for never-recentering scrolling.
7248
e4cc2dfc
JB
72492011-03-31 Juanma Barranquero <lekktu@gmail.com>
7250
7251 * dispextern.h (move_it_by_lines):
7252 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7253 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7254 (message_log_check_duplicate): Remove parameters `prev_bol' and
7255 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7256 (redisplay_internal): Remove parameter `preserve_echo_area',
7257 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7258
7259 * indent.c (Fvertical_motion):
7260 * window.c (window_scroll_pixel_based, Frecenter):
7261 Don't pass `need_y_p' to `move_it_by_lines'.
7262
1c470562
SM
72632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7264
44f230aa
SM
7265 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7266 steal a few bits to be more compact.
7267 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7268 Remove unneeded casts.
7269
1c470562
SM
7270 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7271
888adce9
ZK
72722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7273
7274 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7275 binding" message (bug#7967).
7276
f838ed7b
PE
72772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7278
77861b95
PE
7279 Fix more problems found by GCC 4.6.0's static checks.
7280
de6dbc14
PE
7281 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7282 Remove unused local var.
7283
f838ed7b
PE
7284 * editfns.c (Fmessage_box): Remove unused local var.
7285
792c7b2b
PE
7286 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7287 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7288 Omit unused local vars.
c499e557 7289 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7290 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7291 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7292 Omit unused local var.
7293
ba0165e1
PE
7294 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7295 Don't assume string length fits in int.
32ad8845 7296 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7297 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7298
3c59b4c9
PE
7299 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7300 instead of alloca (Bug#8344).
7301
a3eed478 7302 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7303 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7304
eb4d412d
PE
7305 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7306
1658b401
PE
7307 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7308 concerns.
7309
7310 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7311
7312 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7313
9a2c6e05
PE
7314 * keyboard.c (syms_of_keyboard): Use the same style as later
7315 in this function when indexing through an array. This also
7316 works around GCC bug 48267.
7317
03d0a109
PE
7318 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7319
44f730c8
PE
7320 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7321
fe75f926
PE
7322 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7323 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7324
ffa8c828
PE
7325 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7326 This avoids undefined behavior on integer overflow, and is a bit
7327 more convenient anyway since it is compared to a size_t variable.
7328
c5101a77
PE
7329 Variadic C functions now count arguments with size_t, not int.
7330 This avoids an unnecessary limitation on 64-bit machines, which
7331 caused (substring ...) to crash on large vectors (Bug#8344).
7332 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7333 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7334 All variadic functions and their callers changed accordingly.
c5101a77
PE
7335 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7336 * data.c (arith_driver, float_arith_driver): Likewise.
7337 * editfns.c (general_insert_function): Likewise.
7338 * eval.c (struct backtrace.nargs, interactive_p)
7339 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7340 (funcall_lambda, mark_backtrace): Likewise.
7341 * fns.c (concat): Likewise.
7342 * frame.c (x_set_frame_parameters): Likewise.
7343 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7344 0 if not found, not -1. All callers changed.
7345
dd3f25f7
PE
7346 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7347 (stack_copy_size): Now size_t, not int.
7348 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7349
461c2ab9
JB
73502011-03-28 Juanma Barranquero <lekktu@gmail.com>
7351
7352 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7353 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7354 All callers changed.
7355
7356 * lisp.h (multibyte_char_to_unibyte):
7357 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7358 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7359 * character.h (CHAR_TO_BYTE8):
7360 * cmds.c (internal_self_insert):
7361 * editfns.c (general_insert_function):
7362 * keymap.c (push_key_description):
7363 * search.c (Freplace_match):
7364 * xdisp.c (message_dolog, set_message_1): All callers changed.
7365
f6d62986
SM
73662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7367
7368 * keyboard.c (safe_run_hook_funcall): New function.
7369 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7370 don't set the hook to nil, but remove the offending function instead.
7371 (Qcommand_hook_internal): Remove, unused.
7372 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7373 Vcommand_hook_internal.
7374
7375 * eval.c (enum run_hooks_condition): Remove.
7376 (funcall_nil, funcall_not): New functions.
7377 (run_hook_with_args): Call each function through a `funcall' argument.
7378 Remove `cond' argument, now redundant.
7379 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7380 (Frun_hook_with_args_until_failure): Adjust accordingly.
7381 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7382
1db5b1ad
JB
73832011-03-28 Juanma Barranquero <lekktu@gmail.com>
7384
7385 * dispextern.h (string_buffer_position): Remove declaration.
7386
7387 * print.c (strout): Remove parameter `multibyte', unused since
7388 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7389
7390 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7391 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7392 All callers changed.
7393
7394 * w32.c (_wsa_errlist): Use braces for struct initializers.
7395
7396 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7397 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7398 All callers changed.
7399 (string_buffer_position): Likewise. Also, make static (it's never
7400 used outside xdisp.c).
7401 (cursor_row_p): Remove parameter `w', unused since
7402 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7403 (decode_mode_spec): Remove parameter `precision', introduced during
7404 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7405 All callers changed.
7406
5ffb62aa
JD
74072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7408
7409 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7410
461c2ab9 74112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7412
7413 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7414 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7415 (ns_update_auto_hide_menu_bar): New functions.
7416 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7417 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7418 ns_constrain_all_frames.
7419 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7420 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7421
5c380ffb
JD
74222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7423
7424 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7425
9af30bdf
GM
74262011-03-27 Glenn Morris <rgm@gnu.org>
7427
7428 * syssignal.h: Replace RETSIGTYPE with void.
7429 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7430 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7431 Replace SIGTYPE with void everywhere.
7432 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7433 * s/template.h (SIGTYPE): Remove commented out definition.
7434
e2abce01
JB
74352011-03-26 Eli Zaretskii <eliz@gnu.org>
7436
7437 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7438 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7439
f868cd8a
JB
74402011-03-26 Juanma Barranquero <lekktu@gmail.com>
7441
59eb0929
JB
7442 * w32.c (read_unc_volume): Use parameter `henum', instead of
7443 global variable `wget_enum_handle'.
7444
7445 * keymap.c (describe_vector): Remove parameters `indices' and
7446 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7447 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7448
f868cd8a
JB
7449 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7450
7451 * keyboard.c (timer_check): Remove parameter `do_it_now',
7452 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7453 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7454 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7455
7456 * keyboard.c (read_char):
7457 * w32menu.c (w32_menu_display_help):
7458 * xmenu.c (show_help_event, menu_help_callback):
7459 Adjust calls to `show_help_echo'.
7460
7461 * gtkutil.c (xg_maybe_add_timer):
7462 * keyboard.c (readable_events):
7463 * process.c (wait_reading_process_output):
7464 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7465
7466 * insdel.c (adjust_markers_gap_motion):
7467 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7468 (gap_left, gap_right): Don't call it.
7469
2ecf6fdb
CY
74702011-03-25 Chong Yidong <cyd@stupidchicken.com>
7471
7472 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7473 incurred during fontification.
7474
6b1f9ba4
JB
74752011-03-25 Juanma Barranquero <lekktu@gmail.com>
7476
7477 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7478 (DEFVAR_PER_BUFFER): Don't pass it.
7479
7480 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7481 (scrolling_window): Don't pass it.
7482
0f4a96b5
JB
74832011-03-25 Juanma Barranquero <lekktu@gmail.com>
7484
7485 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7486
7487 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7488 and `suffix'.
7489 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7490 of variables specific to SELinux and computation of `encoded_absname'.
7491
7492 * image.c (XPutPixel): Remove unused variable `height'.
7493
7494 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7495
7496 * unexw32.c (get_section_info): Remove unused variable `section'.
7497
7498 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7499 (system_process_attributes): Remove unused variable `sess'.
7500 (sys_read): Remove unused variable `err'.
7501
7502 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7503 (w32_wnd_proc): Remove unused variable `isdead'.
7504 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7505 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7506 (x_create_tip_frame): Remove unused variable `tem'.
7507
7508 * w32inevt.c (w32_console_read_socket):
7509 Remove unused variable `no_events'.
7510
7511 * w32term.c (x_draw_composite_glyph_string_foreground):
7512 Remove unused variable `width'.
7513
1149507c
JB
75142011-03-24 Juanma Barranquero <lekktu@gmail.com>
7515
7516 * w32term.c (x_set_glyph_string_clipping):
7517 Don't pass uninitialized region to CombineRgn.
7518
9c88f339
JB
75192011-03-23 Juanma Barranquero <lekktu@gmail.com>
7520
7521 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7522 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7523 (Fx_close_connection): Remove unused variable `i'.
7524
7525 * w32font.c (w32font_draw): Return number of glyphs.
7526 (w32font_open_internal): Remove unused variable `i'.
7527 (w32font_driver): Add missing initializer.
7528
7529 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7530 (fill_in_menu): Remove unused variable `items_added'.
7531
7532 * w32term.c (last_mouse_press_frame): Remove static global variable.
7533 (w32_clip_to_row): Remove unused variable `f'.
7534 (x_delete_terminal): Remove unused variable `i'.
7535
7536 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7537 (NOTHING): Remove unused static global variable.
7538 (uniscribe_check_otf): Remove unused variable `table'.
7539 (uniscribe_font_driver): Add missing initializers.
7540
dee091a3
JD
75412011-03-23 Julien Danjou <julien@danjou.info>
7542
7543 * term.c (Fsuspend_tty, Fresume_tty):
7544 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7545 * window.c (temp_output_buffer_show):
7546 * insdel.c (signal_before_change):
7547 * frame.c (Fhandle_switch_frame):
7548 * fileio.c (Fdo_auto_save):
7549 * emacs.c (Fkill_emacs):
7550 * editfns.c (save_excursion_restore):
7551 * cmds.c (internal_self_insert):
7552 * callint.c (Fcall_interactively):
7553 * buffer.c (Fkill_all_local_variables):
7554 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7555 Use Frun_hooks.
0f4a96b5 7556 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7557 unconditionnaly since it does the check itself.
7558
2c520ab5 75592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7560
c9c49752
PE
7561 Fix more problems found by GCC 4.5.2's static checks.
7562
8abc3f12
PE
7563 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7564 the first time through the loop, since we know p0 < p1 then.
7565 This also avoids a gcc -Wstrict-overflow warning.
7566
a2d26660
PE
7567 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7568 leading to a memory leak, possible in functions like
7569 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7570 of objects (Bug#8318).
a2d26660 7571
916c72e9
PE
7572 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7573 that could (at least in theory) be that large.
7574
19ab8a18
PE
7575 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7576 This is less likely to overflow, and avoids undefined behavior if
7577 overflow does occur. All callers changed. Use strtoul to scan
7578 for the unsigned long integer.
b7cbbd6f
PE
7579 (pint2hrstr): Simplify and tune code slightly.
7580 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7581
f0641eff
PE
7582 * scroll.c (do_scrolling): Work around GCC bug 48228.
7583 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7584
7f650bb9
PE
7585 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7586 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7587 (validate_x_resource_name): Simplify count usage.
7588 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7589
37dd57d1
PE
7590 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7591 fail (Bug#8306).
81e56e61 7592
699979fc 7593 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7594
401bf9b4
PE
7595 * process.c (Fmake_network_process): Use socklen_t, not int,
7596 where POSIX says socklen_t is required in portable programs.
7597 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7598 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7599 (Fmake_network_process, server_accept_connection):
7600 (wait_reading_process_output, read_process_output):
7601 Likewise.
7602
b93aacde
PE
7603 * process.c: Rename or move locals to avoid shadowing.
7604 (list_processes_1, Fmake_network_process):
7605 (read_process_output_error_handler, exec_sentinel_error_handler):
7606 Rename or move locals.
4dc343ee 7607 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7608 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7609 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7610 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7611 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7612
af8a867c 7613 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7614 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7615 Include tparam.h instead, since it declares them.
af8a867c
PE
7616 * cm.h (PC): Remove extern decl; tparam.h now does this.
7617 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7618 * terminfo.c: Include tparam.h, to check interfaces.
7619 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7620 (tparam): Adjust signature to match interface in tparam.h;
7621 this removes some undefined behavior. Check that outstring and len
7622 are zero, which they always are with Emacs.
7623 * tparam.h (PC, BC, UP): New extern decls.
7624
0248044d 7625 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7626 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7627
8ff096c1 7628 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7629 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7630 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7631 (ftfont_list): Remove unused local.
49eaafba
PE
7632 (get_adstyle_property, ftfont_pattern_entity):
7633 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7634 Rename locals to avoid shadowing.
8ff096c1 7635
e2be39f6
PE
7636 * xfont.c (xfont_list_family): Mark var as initialized.
7637
c9735e30
PE
7638 * xml.c (make_dom): Now static.
7639
8f5201ae
PE
7640 * composite.c (composition_compute_stop_pos): Rename local to
7641 avoid shadowing.
b246f932
PE
7642 (composition_reseat_it): Remove unused locals.
7643 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7644 (composition_update_it): Mark var as initialized.
11b61122
PE
7645 (find_automatic_composition): Mark vars as initialized,
7646 with a FIXME (Bug#8290).
8f5201ae 7647
760fbc2c
PE
7648 character.h: Rename locals to avoid shadowing.
7649 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7650 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7651 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7652 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7653 to avoid shadowing.
7654
ff08eb85
PE
7655 * textprop.c (property_change_between_p): Remove; unused.
7656
fc7bf025
PE
7657 * intervals.c (interval_start_pos): Now static.
7658
235d7abc
PE
7659 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7660
44f230aa
SM
7661 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7662 Rename locals to avoid shadowing.
3e7d6594 7663
50060332
PE
7664 * sound.c (wav_play, au_play, Fplay_sound_internal):
7665 Fix pointer signedness.
d01f234b 7666 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7667 (wav_play): Initialize a variable to 0, to prevent undefined
7668 behavior (Bug#8278).
50060332 7669
c4fc4e30
PE
7670 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7671
918436ed
PE
7672 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7673
c939f91b
PE
7674 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7675 clobbering (Bug#8298).
b9c7f648
PE
7676 * sysdep.c (sys_subshell): Likewise.
7677 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7678
6bd8c144
PE
7679 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7680 This should get cleaned up, so that child_setup has the
7681 same signature on all platforms.
7682
7710357c 7683 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7684 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7685
c59da222
CY
76862011-03-22 Chong Yidong <cyd@stupidchicken.com>
7687
7688 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7689 not to be necessary, and produces flickering.
7690
66b87493
GM
76912011-03-20 Glenn Morris <rgm@gnu.org>
7692
7693 * config.in: Remove file.
7694
45b6f6d5
JB
76952011-03-20 Juanma Barranquero <lekktu@gmail.com>
7696
7697 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7698 are now in src/globals.h.
7699 (syms_of_minibuf): Remove spurious & from previous change.
7700
3ec03f7e
LL
77012011-03-20 Leo <sdl.web@gmail.com>
7702
7703 * minibuf.c (completing-read-function): New variable.
7704 (completing-read-default): Rename from completing-read.
7705 (completing-read): Call completing-read-function.
7706
b14e3e21
CY
77072011-03-19 Juanma Barranquero <lekktu@gmail.com>
7708
7709 * xfaces.c (Fx_load_color_file):
7710 Read color file from absolute filename (bug#8250).
7711
f2b726e6
JB
77122011-03-19 Juanma Barranquero <lekktu@gmail.com>
7713
7714 * makefile.w32-in: Update dependencies.
7715
09f6ff02
EZ
77162011-03-17 Eli Zaretskii <eliz@gnu.org>
7717
7718 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7719
29a6015a
PE
77202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7721
a3a6c54e
PE
7722 Fix more problems found by GCC 4.5.2's static checks.
7723
b766f867
PE
7724 * process.c (make_serial_process_unwind, send_process_trap):
7725 (sigchld_handler): Now static.
7726
be02381c
PE
7727 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7728 That way, the code declares only the vars that it needs.
7729 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7730 * s/cygwin.h (PTY_ITERATION): Likewise.
7731 * s/darwin.h (PTY_ITERATION): Likewise.
7732 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7733
57048744
PE
7734 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7735 * process.c (allocate_pty): Don't declare stb unless it's needed.
7736
7914961c 7737 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7738 (CONSTANTLIM): Remove; unused.
7739 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7740 Define only if needed.
7914961c 7741
b3967b18
PE
7742 * unexelf.c (unexec): Name an expression,
7743 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7744 Use a different way to cause a compilation error if anyone uses
7745 n rather than nn, a way that does not involve shadowing.
73366a00 7746 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7747
29a6015a
PE
7748 * deps.mk (unexalpha.o): Remove; unused.
7749
43cfc33e 7750 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7751 * unexec.h: New file.
ce701a33
PE
7752 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7753 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7754 Depend on unexec.h.
7755 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7756 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7757 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7758 Change as necessary to match prototype in unexec.h.
ce701a33 7759
01f44d5a
PE
7760 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7761 shadowing.
4f63c6bb 7762 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7763
a6670b0b
PE
7764 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7765 Rename locals to avoid shadowing.
7766
cef2010d 7767 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7768 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7769
d4d7173a
PE
7770 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7771
f08b802a
PE
7772 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7773 warning when compiling print.c.
7774
3ddb0639
PE
7775 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7776 instead of using an uninitialized var.
5ad03b97 7777 (font_sort_entities): Mark var as initialized.
3ddb0639 7778
170a2692
PE
7779 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7780
e663c700
PE
7781 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7782 pointers to constants.
89bc529a 7783 (font_parse_fcname): Remove unused vars.
7b81e2d0 7784 (font_delete_unmatched): Now static.
ea838e10 7785 (font_get_spec): Remove; unused.
13a547c6
PE
7786 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7787 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7788 Rename or move locals to avoid shadowing.
e663c700 7789
2a80c887 7790 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7791 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7792
1384fa33 7793 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7794 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7795
8b2c52e9
PE
7796 * alloc.c (mark_backtrace): Move decl from here ...
7797 * lisp.h: ... to here, so that it can be checked.
7798
475545b5 7799 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7800 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7801 (lisp_indirect_variable): Name an expression,
7802 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7803 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7804
b1349114 7805 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7806 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7807 Use const pointer when appropriate.
b1349114 7808
a2928364
PE
7809 * lisp.h (get_system_name, get_operating_system_release):
7810 Move decls here, to check interfaces.
7811 * process.c (get_operating_system_release): Move decl to lisp.h.
7812 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7813 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7814 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7815 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7816 (Fformat_time_string, Fencode_time, Finsert_char):
7817 (Ftranslate_region_internal, Fformat):
7818 Rename or remove local vars to avoid shadowing.
9710023e 7819 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7820
a415e694
PE
7821 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7822 avoid shadowing.
7823
8ef4622d
PE
7824 * lisp.h (eassert): Check that the argument compiles, even if
7825 ENABLE_CHECKING is not defined.
7826
946f9a5b
PE
7827 * data.c (Findirect_variable): Name an expression, to avoid
7828 gcc -Wbad-function-cast warning.
112396d6 7829 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7830 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7831 (Fmake_variable_buffer_local, Fmake_local_variable):
7832 Mark variables as initialized.
52746918 7833 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7834
e5aab7e7 7835 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7836 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7837 Rename locals to avoid shadowing.
dff45157
PE
7838 (mark_stack): Move local variables into the #ifdef region where
7839 they're used.
7bc26fdb
PE
7840 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7841 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7842 needed otherwise.
7843 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7844 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7845 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7846
e5aab7e7
PE
7847 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7848 avoids undefined behavior in theory.
7849
4da60324
PE
7850 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7851
88043301
PE
7852 Use functions, not macros, for up- and down-casing (Bug#8254).
7853 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7854 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7855 to use the following functions instead of these macros.
7856 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7857 EMACS_INT, since callers assume the returned value fits in int.
7858 (upcase1): Likewise, for UPCASE_TABLE.
7859 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7860 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7861 the race-condition problem in the old DOWNCASE.
88043301 7862
19ed5445
PE
7863 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7864 Rename locals to avoid shadowing.
7865 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7866 (regex_compile, re_search_2, re_match_2_internal):
7867 Remove unused local vars.
952db0d7
PE
7868 (FREE_VAR): Rewrite so as not to use empty "else",
7869 which gcc can warn about.
da053e48 7870 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7871 (RETALLOC_IF): Define only if needed.
7872 (WORDCHAR_P): Likewise. This one is never needed, but is used
7873 only in a comment talking about a compiler bug, so put inside
7874 the #if 0 of that comment.
7875 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7876 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7877 Remove; unused.
19ed5445 7878
1f3561e4 7879 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7880 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7881 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7882
ded6f8f7
PE
7883 * search.c (simple_search): Remove unused var.
7884
dbd37a95
PE
7885 * dired.c (compile_pattern): Move decl from here ...
7886 * lisp.h: ... to here, so that it can be checked.
7887 (struct re_registers): New forward decl.
7888
7e47afad
PE
7889 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7890
85f24f61
PE
7891 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7892 All uses changed.
7893 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7894 Rename locals to avoid shadowing.
5671df8f 7895 (Fvertical_motion): Mark locals as initialized.
85f24f61 7896
181aa2be 7897 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7898 (casify_region): Mark local as initialized.
181aa2be 7899
930d429c
PE
7900 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7901
7082eac6
PE
7902 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7903 New macros, so that the caller can use some names other than
7904 gcpro1, gcpro2, etc.
7905 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7906 of the new macros.
7907 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7908 argument, for consistency with GCPRO2_VAR, etc: it is now the
7909 prefix of the variable, not the variable itself. All uses
7910 changed.
38b2c076
PE
7911 * dired.c (directory_files_internal, file_name_completion):
7912 Rename locals to avoid shadowing.
7913
15206ed9
PE
7914 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7915 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7916 dired.c's scmp function, had undefined behavior.
7917 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7918 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7919 * buffer.h: ... to here, because these macros use current_buffer,
7920 and the new implementation with inline functions needs to have
7921 current_buffer in scope now, rather than later when the macros
7922 are used.
7923 (downcase, upcase1): New static inline functions.
7924 (DOWNCASE, UPCASE1): Reimplement using these functions.
7925 This avoids undefined behavior in expressions like
7926 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7927 from race conditions in accessing the global variables
7928 case_temp1 and case_temp2.
7929 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7930 * lisp.h (case_temp1, case_temp2): Remove their decls.
7931 * character.h (ASCII_CHAR_P): Move from here ...
7932 * lisp.h: ... to here, so that the inline functions mentioned
7933 above can use them.
7934
4a6bea26
PE
7935 * dired.c (directory_files_internal_unwind): Now static.
7936
f14b7e14
PE
7937 * fileio.c (file_name_as_directory, directory_file_name):
7938 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7939 Now static.
2893f146
PE
7940 (file_name_as_directory): Use const pointers when appropriate.
7941 (Fexpand_file_name): Likewise. In particular, newdir might
7942 point at constant storage, so make it a const pointer.
fd4ead52 7943 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7944 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7945 signedness issues.
f839df0c
PE
7946 (Fset_file_times, Finsert_file_contents, auto_save_error):
7947 Rename locals to avoid shadowing.
f14b7e14 7948
5716756e 7949 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7950 (Ftry_completion, Fall_completions): Rename or remove locals
7951 to avoid shadowing.
5716756e 7952
b4c3046a
PE
7953 * marker.c (bytepos_to_charpos): Remove; unused.
7954
b45db522
PE
7955 * lisp.h (verify_bytepos, count_markers): New decls,
7956 so that gcc does not warn that these functions aren't declared.
7957
85876d07
PE
7958 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7959 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7960 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7961 (copy_text): Remove unused local var.
85876d07 7962
03d78a21 7963 * filelock.c (within_one_second): Now static.
b3dd38ab 7964 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7965
5df8f01b
PE
7966 * buffer.c (fix_overlays_before): Mark locals as initialized.
7967 (fix_start_end_in_overlays): Likewise. This function should be
7968 simplified by using pointers-to-pointers, but that's a different
7969 matter.
b1d876f1 7970 (switch_to_buffer_1): Now static.
8f54f30a
PE
7971 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7972 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7973
a70072c9 7974 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7975 Fix pointer signedness issue.
edced198
PE
7976 (sys_subshell): Mark local as volatile if checking for lint,
7977 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7978 (MAXPATHLEN): Define only if needed.
a70072c9 7979
a0977c44
PE
7980 * process.c (serial_open, serial_configure): Move decls from here ...
7981 * systty.h: ... to here, so that they can be checked.
7982
a884fdcc
PE
7983 * fns.c (get_random, seed_random): Move extern decls from here ...
7984 * lisp.h: ... to here, so that they can be checked.
7985
604efe86 7986 * sysdep.c (reset_io): Now static.
b8950c94 7987 (wait_for_termination_signal): Remove; unused.
604efe86 7988
38fc62d9
PE
7989 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7990 (copy_keymap_item, append_key, push_text_char_description):
7991 Now static.
1004a21a 7992 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7993 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7994 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7995 (describe_map_tree):
7996 Rename locals to avoid shadowing.
38fc62d9 7997
2f2650da
PE
7998 * keyboard.c: Declare functions static if they are not used elsewhere.
7999 (echo_char, echo_dash, cmd_error, top_level_2):
8000 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8001 (read_char, kbd_buffer_get_event, make_lispy_position):
8002 (make_lispy_event, make_lispy_movement, apply_modifiers):
8003 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8004 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8005 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8006 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8007 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8008
a053e86c 8009 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8010 (mark_kboards): Move decl here ...
8011 * alloc.c (mark_kboards): ... from here.
a053e86c 8012
4752793e
PE
8013 * lisp.h (force_auto_save_soon): New decl.
8014
74f10ca7 8015 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8016 (DEFINE_DUMMY_FUNCTION): New macro.
8017 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8018 Use it.
c03cd23f
PE
8019 (main): Add casts to avoid warnings
8020 if GCC considers string literals to be constants.
74f10ca7 8021
022e70d4
PE
8022 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8023
59d6fe83
PE
8024 * dbusbind.c: Pointer signedness fixes.
8025 (xd_signature, xd_append_arg, xd_initialize):
8026 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8027 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8028 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8029 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8030
78320123
PE
8031 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8032 if GCC considers string literals to be constants.
49cebcca 8033 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8034
35ac2a97
SM
80352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8036
fb103ca9
SM
8037 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8038 (print_preprocess, print_object): New macro to fix last change.
8039
35ac2a97
SM
8040 * print.c (print_preprocess): Don't forget font objects.
8041
62973b41
JB
80422011-03-16 Juanma Barranquero <lekktu@gmail.com>
8043
8044 * emacs.c (USAGE3): Doc fixes.
8045
0e48bb22
AS
80462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8047
8048 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8049 structure.
8050
7684e57b
JB
80512011-03-14 Juanma Barranquero <lekktu@gmail.com>
8052
8053 * lisp.h (VWindow_system, Qfile_name_history):
8054 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8055 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8056 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8057
8058 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8059 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8060
8061 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8062 * w32console.c (detect_input_pending, read_input_pending)
8063 (encode_terminal_code):
8064 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8065 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8066 (w32_system_caret_y, Qfile_name_history):
8067 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8068 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8069 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8070 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8071 * w32proc.c (Qlocal, report_file_error):
8072 * w32term.c (Vwindow_system, updating_frame):
8073 * w32uniscribe.c (initialized, uniscribe_font_driver):
8074 Remove unneeded extern declarations.
8075
2aa46d6c
CY
80762011-03-14 Chong Yidong <cyd@stupidchicken.com>
8077
c96bbc66 8078 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8079
cffc6f3b
CY
80802011-03-13 Chong Yidong <cyd@stupidchicken.com>
8081
8082 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8083 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8084 These macros can no longer be used for assignment.
8085
44f230aa
SM
8086 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8087 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8088 (record_buffer_markers, fetch_buffer_markers): New functions for
8089 recording and fetching special buffer markers.
8090 (set_buffer_internal_1, set_buffer_temp): Use them.
8091
8092 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8093
8094 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8095
8096 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8097 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8098
8099 * xdisp.c (hscroll_window_tree):
8100 (reconsider_clip_changes): Use PT instead of BUF_PT.
8101
d251f04b
EZ
81022011-03-13 Eli Zaretskii <eliz@gnu.org>
8103
8104 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8105 $(EMACS_ROOT)/lib/intprops.h.
8106
f0c77cd1
PE
81072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8108
3eca4629
PE
8109 Fix more problems found by GCC 4.5.2's static checks.
8110
7c86ee98
PE
8111 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8112 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8113 (xg_free_frame_widgets): Make it clear that a local variable is
8114 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8115 (gdk_window_get_screen): Make it clear that this macro is needed
8116 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8117 (int_gtk_range_get_value): New function, which avoids a diagnostic
8118 from gcc -Wbad-function-cast.
8119 (xg_set_toolkit_scroll_bar_thumb): Use it.
8120 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8121 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8122 (get_utf8_string, xg_get_file_with_chooser):
8123 Rename locals to avoid shadowing.
8124 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8125
41729b81
PE
8126 * xgselect.c (xg_select): Remove unused var.
8127
f0c77cd1
PE
8128 * image.c (four_corners_best): Mark locals as initialized.
8129 (gif_load): Initialize transparent_p to zero (Bug#8238).
8130 Mark another local as initialized.
ec6cf4c6 8131 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8132
ce0ad53d 8133 * image.c (clear_image_cache): Now static.
d5d5a617 8134 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8135 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8136 (x_edge_detection): Remove unnecessary cast that
8137 gcc -Wbad-function-cast diagnoses.
2037898d 8138 (gif_load): Fix pointer signedness.
6ae141d6
PE
8139 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8140 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8141
33383987 81422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8143
d32df629
PE
8144 Improve quality of tests for time stamp overflow.
8145 For example, without this patch (encode-time 0 0 0 1 1
8146 1152921504606846976) returns the obviously-bogus value (-948597
8147 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8148 reports time overflow. See
8149 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8150 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8151 * editfns.c: Include limits.h and intprops.h.
8152 (TIME_T_MIN, TIME_T_MAX): New macros.
8153 (time_overflow): Move earlier, to before first use.
8154 (hi_time, lo_time): New functions, for an accurate test for
8155 out-of-range times.
8156 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8157 (Fget_internal_run_time): Don't assume time_t fits in int.
8158 (make_time): Use list2 instead of Fcons twice.
8159 (Fdecode_time): More accurate test for out-of-range times.
8160 (check_tm_member): New function.
8161 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8162 (lisp_time_argument): Don't rely on undefined left-shift and
8163 right-shift behavior when checking for time stamp overflow.
8be6f318 8164
fe31d94c
PE
8165 * editfns.c (time_overflow): New function, refactoring common code.
8166 (Fformat_time_string, Fdecode_time, Fencode_time):
8167 (Fcurrent_time_string): Use it.
8168
8be6f318
PE
8169 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8170 * dired.c (make_time): Move to ...
8171 * editfns.c (make_time): ... here.
8172 * systime.h: Note the move.
8173
09d9db2c 81742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8175
126bc0dc
YM
8176 * fringe.c (update_window_fringes): Remove unused variables.
8177
c47cbdfd
YM
8178 * unexmacosx.c (copy_data_segment): Also copy __got section.
8179 (Bug#8223)
8180
7ac80be9
EZ
81812011-03-12 Eli Zaretskii <eliz@gnu.org>
8182
c96bbc66 8183 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8184 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8185 Constify `char *' arguments and their references according to
8186 prototypes in tparam.h.
8187
ecb0f94d 8188 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8189
7ac80be9
EZ
8190 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8191 Adapt all references accordingly.
8192
8193 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8194
ef1fd07e
TT
81952011-03-11 Tom Tromey <tromey@redhat.com>
8196
8197 * buffer.c (syms_of_buffer): Remove obsolete comment.
8198
7ef4b50c
EZ
81992011-03-11 Eli Zaretskii <eliz@gnu.org>
8200
8201 * termhooks.h (encode_terminal_code): Declare prototype.
8202
8203 * msdos.c (encode_terminal_code): Don't declare prototype.
8204
8205 * term.c (encode_terminal_code): Now external again, used by
8206 w32console.c and msdos.c.
8207
44f230aa
SM
8208 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8209 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8210
4b1ec863 82112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8212
1714f52b 8213 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8214
4b1ec863
PE
8215 * fringe.c (update_window_fringes): Mark locals as initialized
8216 (Bug#8227).
8217 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8218
524c7aa6
PE
8219 * alloc.c (mark_fringe_data): Move decl from here ...
8220 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8221 to check its interface.
8222 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8223
a5c0af81 8224 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8225 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8226 (fontset_font): Mark local as initialized.
a9a06e0b 8227 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8228
b4716021
PE
8229 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8230
811e9bac 8231 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8232 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8233 (x_own_selection, Fx_disown_selection_internal): Rename locals
8234 to avoid shadowing.
8235 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8236
7e3ab302
PE
8237 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8238 so that the caller can use some name other than gcpro1.
8239 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8240 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8241 (Fx_backspace_delete_keys_p):
8242 Use them to avoid shadowing, and rename vars to avoid shadowing.
8243 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8244 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8245 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8246 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8247 Remove unused locals.
7e3ab302
PE
8248 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8249 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8250 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8251 macros.
f78faa98 8252
e2b13473
PE
8253 * xterm.h (x_mouse_leave): New decl.
8254
77f23912
PE
8255 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8256 Remove unused functions.
cdf4ba58
PE
8257 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8258 (x_calc_absolute_position): Now static.
7411c686 8259 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8260 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8261 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8262 unless they are used.
38d0b34a
PE
8263 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8264 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8265 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8266 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8267 (x_error_catcher, x_connection_closed, x_error_handler):
8268 (x_error_quitter, xembed_send_message, x_iconify_frame):
8269 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8270 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8271 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8272
44f230aa
SM
8273 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8274 Rename or move locals to avoid shadowing.
6b463e58 8275 (tty_defined_color, merge_face_heights): Now static.
5967d051 8276 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8277 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8278 does not deduce is never used uninitialized.
73719eba
PE
8279 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8280 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8281
426994c3 8282 * terminal.c (store_terminal_param): Now static.
5489860b 8283
032f1620 8284 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8285 (set_frame_menubar): Remove unused local.
d4323972 8286 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8287 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8288 since they might point to immutable storage.
281585b0
PE
8289 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8290 since it's unused otherwise.
032f1620 8291
367c19e5 8292 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8293 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8294 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8295 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8296 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8297 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8298 does not deduce are never used uninitialized.
70739cbe 8299
07b48fa9
PE
8300 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8301
8868a238 8302 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8303 * window.c (window_loop, size_window):
8304 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8305
7e5cf297 8306 * window.c (display_buffer): Now static.
d6550a9f
PE
8307 (size_window): Mark variables that gcc -Wuninitialized
8308 does not deduce are never used uninitialized.
a586633d
PE
8309 * window.h (check_all_windows): New decl, to forestall
8310 gcc -Wmissing-prototypes diagnostic.
5b555da1 8311 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8312
f6095868
PE
8313 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8314 shadowing.
8315 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8316 Include <limits.h>.
8317 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8318 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8319 (load_charset_map): Mark variables that gcc -Wuninitialized
8320 does not deduce are never used uninitialized.
53df7c11 8321 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8322
f38b440c
PE
8323 * coding.c (coding_set_source, coding_set_destination):
8324 Use "else { /* comment */ }" rather than "else /* comment */;"
8325 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8326 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8327 a block, when the outer 'i' will do.
8328 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8329 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8330 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8331 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8332 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8333 Rename locals to avoid shadowing.
8334 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8335 * coding.c (emacs_mule_char, encode_invocation_designation):
8336 Now static, since they're not used elsewhere.
413bb2db 8337 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8338 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8339 (decode_coding_emacs_mule): Mark variables that gcc
8340 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8341 (detect_coding_iso_2022): Initialize a local variable that might
8342 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8343 this initialization is needed. (Bug#8211)
5f58e762
PE
8344 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8345 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8346 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8347 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8348 Remove unused macros.
f38b440c 8349
232b38b9 8350 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8351 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8352 * character.c (string_count_byte8): Likewise.
232b38b9 8353
fb90da1b
PE
8354 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8355 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8356
fb93dbc2
PE
8357 * chartab.c (copy_sub_char_table): Now static, since it's not used
8358 elsewhere.
5c156ace
PE
8359 (sub_char_table_ref_and_range, char_table_ref_and_range):
8360 Rename locals to avoid shadowing.
bbcd0949 8361 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8362
7d3b3862 8363 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8364 (BIDI_BOB): Remove unused macro.
7d3b3862 8365
6be7d3da
PE
8366 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8367 deduce are never used uninitialized.
c2ed9c8b 8368 * term.c (encode_terminal_code): Likewise.
6be7d3da 8369
75f8807f 8370 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8371
50938595
PE
8372 * tparam.h: New file.
8373 * term.c, tparam.h: Include it.
8374 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8375 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8376 Move these decls to tparam.h, and make them agree with what
8377 is actually in tparam.c. The previous trick of using incompatible
8378 decls in different modules does not conform to the C standard.
8379 All callers of tparam changed to use tparam's actual API.
8380 * tparam.c (tparam1, tparam, tgoto):
8381 Use const pointers where appropriate.
8382
fbceeba2
PE
8383 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8384 * cm.h (struct cm): Likewise.
8385 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8386 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8387 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8388 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8389 (turn_on_face, init_tty): Likewise.
8390 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8391
7f3f1250
PE
8392 * term.c (term_mouse_position): Rename local to avoid shadowing.
8393
e6ca6543
PE
8394 * alloc.c (mark_ttys): Move decl from here ...
8395 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8396
c40f8d15
AS
83972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8398
8399 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8400
cfe0661d
JB
84012011-03-09 Juanma Barranquero <lekktu@gmail.com>
8402
8403 * search.c (compile_pattern_1): Remove argument regp, unused since
8404 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8405 (compile_pattern): Don't pass it.
8406
0afb4571
J
84072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8408
8409 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8410 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8411 for ! HAVE_GTK3.
8412 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8413
8414 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8415
8416 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8417 gdk_window_get_screen, gdk_window_get_geometry,
8418 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8419 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8420 (xg_get_pixbuf_from_pixmap): New function.
8421 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8422 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8423 Call xg_get_pixbuf_from_pixmap instead of
8424 gdk_pixbuf_get_from_drawable.
8425 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8426 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8427 (xg_check_special_colors): Use GtkStyleContext and its functions
8428 for HAVE_GTK3.
8429 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8430 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8431 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8432 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8433 Call gtk_widget_get_preferred_size.
0afb4571
J
8434 (xg_frame_resized): gdk_window_get_geometry only takes 5
8435 parameters.
44f230aa
SM
8436 (xg_win_to_widget, xg_event_is_for_menubar):
8437 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8438 (xg_set_widget_bg): New function.
8439 (delete_cb): New function.
895009e1 8440 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8441 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8442 (xg_set_background_color): Call xg_set_widget_bg.
8443 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8444 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8445 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8446 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8447 if ! HAVE_GTK3.
8448 (update_frame_tool_bar): Call gtk_widget_hide.
8449 (xg_initialize): Use GDK_KEY_g.
8450
8451 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8452 if ! HAVE_GTK3
8453 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8454
8455 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8456 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8457 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8458
1c2cc4ef
JB
84592011-03-08 Juanma Barranquero <lekktu@gmail.com>
8460
8461 * w32xfns.c (select_palette): Check success of RealizePalette against
8462 GDI_ERROR, not zero.
8463
33383987 8464See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8465
8466;; Local Variables:
8467;; coding: utf-8
aac0c6e3
MR
8468;; End:
8469
33383987 8470 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8471
8472 This file is part of GNU Emacs.
8473
8474 GNU Emacs is free software: you can redistribute it and/or modify
8475 it under the terms of the GNU General Public License as published by
8476 the Free Software Foundation, either version 3 of the License, or
8477 (at your option) any later version.
8478
8479 GNU Emacs is distributed in the hope that it will be useful,
8480 but WITHOUT ANY WARRANTY; without even the implied warranty of
8481 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8482 GNU General Public License for more details.
8483
8484 You should have received a copy of the GNU General Public License
8485 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.