* keyboard.c (make_lispy_event): Remove unused local var.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
39261c26
PE
3 * keyboard.c (make_lispy_event): Remove unused local var.
4
018c5e19
PE
5 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7
63d2b86e
PE
8 * bitmaps: Change bitmaps from unsigned char back to the X11
9 compatible char. Avoid the old compiler warnings about
10 out-of-range initializers by using, for example, '\xab' rather
11 than 0xab.
12
aefd87e1
PE
13 * xgselect.c (xgselect_initialize): Check vs interface
14 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
15
bf501fb9
PE
16 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
17
e9829fdf
PE
18 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
19 to read-only memory.
20
1086c095
PE
21 * fns.c (vector): Remove; this old hack is no longer needed.
22
2baccd04 23 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 24 Remove unused var.
dde42981 25 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 26
72391843 27 * xrdb.c (x_load_resources): Omit unused local.
3565b346 28
436c16df 29 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 30 (x_window): Rename locals to avoid shadowing.
dc5ddd85 31 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 32
92bb796d 33 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 34 (x_term_init): Remove local to avoid shadowing.
92bb796d 35
764430a3 36 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
37
38 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
39 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
40
4170f62f 412011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 42
71b41406
PE
43 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
44
9587a89d
PE
45 emacs_write: Accept and return EMACS_INT for sizes.
46 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
47 et seq.
48 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
49 Accept and return EMACS_INT.
50 (emacs_gnutls_write): Return the number of bytes written on
51 partial writes.
52 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
53 (emacs_read, emacs_write): Remove check for negative size, as the
54 Emacs source code has been audited now.
9587a89d
PE
55 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
56 (emacs_read, emacs_write): Use it.
273a5f82
PE
57 * process.c (send_process): Adjust to the new signatures of
58 emacs_write and emacs_gnutls_write. Do not attempt to store
59 a byte offset into an 'int'; it might overflow.
9587a89d 60 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 61
3e047f51
PE
62 * sound.c: Don't assume sizes fit in 'int'.
63 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 64 Return EMACS_INT, not int.
3e047f51 65 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
66 Accept EMACS_INT, not int.
67 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
68 record read return values.
69
cc39a9db
BK
702011-04-15 Ben Key <bkey76@gmail.com>
71
72 * keyboard.c (Qundefined): Don't declare static since it is
73 used in nsfns.m.
74 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
75 declare static since they are used in nsfont.m.
76
6c60eb9f
SM
772011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
78
79 * process.c (Qprocessp): Don't declare static.
80 * lisp.h (Qprocessp): Declare again.
81
7990b61a
JB
822011-04-15 Juanma Barranquero <lekktu@gmail.com>
83
84 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
85
5d4cb038
PE
862011-04-14 Paul Eggert <eggert@cs.ucla.edu>
87
8bd7b830 88 Improve C-level modularity by making more things 'static'.
cd64ea1d 89
e3b27b31
PE
90 Don't publish debugger-only interfaces to other modules.
91 * lisp.h (safe_debug_print, debug_output_compilation_hack):
92 (verify_bytepos, count_markers): Move decls to the only modules
93 that need them.
94 * region-cache.h (pp_cache): Likewise.
95 * window.h (check_all_windows): Likewise.
96 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
97
5d4cb038
PE
98 * sysdep.c (croak): Now static, if
99 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
100 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
101
102 * alloc.c (refill_memory_reserve): Now static if
103 !defined REL_ALLOC || defined SYSTEM_MALLOC.
104 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 105
e87b6180
PE
106 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
107 Define only if USE_LUCID.
108
ac64929e
PE
109 * xrdb.c (x_customization_string, x_rm_string): Now static.
110
6f37259d
PE
111 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
112 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
113
1683e3ab
PE
114 * xdisp.c (draw_row_with_mouse_face): Now static.
115 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
116
de9c2632
PE
117 * window.h (check_all_windows): Mark externally visible.
118
2b96acb7
PE
119 * window.c (window_deletion_count): Now static.
120
121 * undo.c: Make symbols static if they're not exported.
122 (last_undo_buffer, last_boundary_position, pending_boundary):
123 Now static.
124
50436f33
PE
125 * textprop.c (interval_insert_behind_hooks): Now static.
126 (interval_insert_in_front_hooks): Likewise.
127
64520e5c
PE
128 * term.c: Make symbols static if they're not exported.
129 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
130 (max_frame_lines, tty_set_terminal_modes):
131 (tty_reset_terminal_modes, tty_turn_off_highlight):
132 (get_tty_terminal): Now static.
133 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
134 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 135 HAVE_WINDOW_SYSTEM.
64520e5c
PE
136 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
137 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
138
1fa53021
PE
139 * sysdep.c: Make symbols static if they're not exported.
140 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
141 Now static.
142 (sigprocmask_set, full_mask): Remove; unused.
143 (wait_debugging): Mark as visible.
144 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
145 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
146
d4b43b22
PE
147 * syntax.c (syntax_temp): Define only if !__GNUC__.
148
b7c513d0
PE
149 * sound.c (current_sound_device, current_sound): Now static.
150
989b29ad
PE
151 * search.c (searchbufs, searchbuf_head): Now static.
152
13a55a78
PE
153 * scroll.c (scroll_cost): Remove; unused.
154 * dispextern.h (scroll_cost): Remove decl.
155
de68a1fc
PE
156 * region-cache.h (pp_cache): Mark as externally visible.
157
40ccffa6
PE
158 * process.c: Make symbols static if they're not exported.
159 (process_tick, update_tick, create_process, chan_process):
160 (Vprocess_alist, proc_buffered_char, datagram_access):
161 (fd_callback_data, send_process_frame, process_sent_to): Now static.
162 (deactivate_process): Mark defn as static, as well as decl.
163 * lisp.h (create_process): Remove decl.
164 * process.h (chan_process, Vprocess_alist): Remove decls.
165
ad64fc97
PE
166 * print.c: Make symbols static if they're not exported.
167 (print_depth, new_backquote_output, being_printed, print_buffer):
168 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
169 (print_interval, print_number_index, initial_stderr_stream):
170 Now static.
171 * lisp.h (Fprinc): Remove decl.
172 (debug_output_compilation_hack): Mark as externally visible.
173
adddb265
PE
174 * sysdep.c (croak): Move decl from here to syssignal.h.
175 * syssignal.h (croak): Put it here, so the API can be checked when
176 'croak' is called from dissociate_if_controlling_tty.
177
1717ede2
PE
178 * minibuf.c: Make symbols static if they're not exported.
179 (minibuf_save_list, choose_minibuf_frame): Now static.
180 * lisp.h (choose_minibuf_frame): Remove decl.
181
fa5fb2bc
PE
182 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
183
1e3890d1
PE
184 * lread.c: Make symbols static if they're not exported.
185 (read_objects, initial_obarray, oblookup_last_bucket_number):
186 Now static.
187 (make_symbol): Remove; unused.
188 * lisp.h (initial_obarray, make_symbol): Remove decls.
189
8a1414fa
PE
190 * keyboard.c: Make symbols static if they're not exported.
191 (single_kboard, recent_keys_index, total_keys, recent_keys):
192 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
193 (this_single_command_key_start, echoing, last_auto_save):
194 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
195 (command_loop, echo_now, keyboard_init_hook, help_char_p):
196 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
197 (Vlispy_mouse_stem, double_click_count):
198 Now static.
199 (force_auto_save_soon): Define only if SIGDANGER.
200 (ignore_mouse_drag_p): Now static if
201 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
202 (print_help): Remove; unused.
203 (stop_character, last_timer_event): Mark as externally visible.
204 * keyboard.h (ignore_mouse_drag_p): Declare only if
205 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
206 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
207 * lisp.h (echoing): Remove decl.
208 (force_auto_save_soon): Declare only if SIGDANGER.
209 * xdisp.c (redisplay_window): Simplify code, to make it more
210 obvious that ignore_mouse_drag_p is not accessed if !defined
211 USE_GTK && !defined HAVE_NS.
212
93ea6e8f
PE
213 * intervals.c: Make symbols static if they're not exported.
214 (merge_properties_sticky, merge_interval_right, delete_interval):
215 Now static.
216 * intervals.h (merge_interval_right, delete_interval): Remove decls.
217
77382fcc
PE
218 * insdel.c: Make symbols static if they're not exported.
219 However, leave prepare_to_modify_buffer alone. It's never
220 called from outside this function, but that appears to be a bug.
221 (combine_after_change_list, combine_after_change_buffer):
4889fc82 222 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
223 (adjust_after_replace_noundo): Remove; unused.
224 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 225 (signal_before_change): Remove decls.
77382fcc 226
9306c32e
PE
227 * indent.c (val_compute_motion, val_vmotion): Now static.
228
cd44d2eb
PE
229 * image.c: Make symbols static if they're not exported.
230 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
231 if USE_GTK.
232 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
233 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
234
ad9a7a06
PE
235 * fringe.c (standard_bitmaps): Now static.
236 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
237
81626931
PE
238 * frame.c: Make symbols static if they're not exported.
239 (x_report_frame_params, make_terminal_frame): Now static.
240 (get_frame_param): Now static, unless HAVE_NS.
241 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
242 (x_get_resource_string): Remove; not used.
243 * frame.h (make_terminal_frame, x_report_frame_params):
244 (x_get_resource_string); Remove decls.
245 (x_fullscreen_adjust): Declare only if WINDOWSNT.
246 * lisp.h (get_frame_param): Declare only if HAVE_NS.
247
239f9db9
PE
248 * font.c, fontset.c: Make symbols static if they're not exported.
249 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
250 (FACE_SUITABLE_FOR_CHAR_P): Use it.
251 * font.c (font_close_object): Now static.
252 * font.h (font_close_object): Remove.
253 * fontset.c (FONTSET_OBJLIST): Remove.
254 (free_realized_fontset) #if-0 the body, which does nothing.
255 (face_suitable_for_char_p): #if-0, as it's never called.
256 * fontset.h (face_suitable_for_char_p): Remove decl.
257 * xfaces.c (face_at_string_position): Use
258 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
259 since 0 is always ASCII.
260
dfcf3579
PE
261 * fns.c (weak_hash_tables): Now static.
262
5045092b
PE
263 * fileio.c: Make symbols static if they're not exported.
264 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
265 (Vwrite_region_annotation_buffers): Now static.
266
57a96f5c
PE
267 * eval.c: Make symbols static if they're not exported.
268 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
269 * lisp.h (backtrace_list): Remove decl.
270
35f08c38
PE
271 * emacs.c: Make symbols static if they're not exported.
272 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
273 (fatal_error_code, fatal_error_signal_hook, standard_args):
274 Now static.
275 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
276 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
277 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
278 * lisp.h (fatal_error_signal_hook): Remove decl.
279 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
280
f44bd759
PE
281 * editfns.c: Move a (normally-unused) function to its only use.
282 * editfns.c, lisp.h (get_operating_system_release): Remove.
283 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
284 worth the hassle of breaking this out.
285
b532497d
PE
286 * xterm.c: Make symbols static if they're not exported.
287 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
288 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
289 (x_destroy_window, x_delete_display):
290 Now static.
291 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
292 (x_mouse_leave): Remove; unused.
293 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
294 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
295 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
296 Remove decls.
297 (x_mouse_leave): Declare only if WINDOWSNT.
298 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
299 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
300 USE_X_TOOLKIT.
301
1675728f
PE
302 * ftxfont.c: Make symbols static if they're not exported.
303 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
304 HAVE_FREETYPE.
305 * font.h (ftxfont_driver): Likewise.
306
e4cebfca
PE
307 * xfns.c: Make symbols static if they're not exported.
308 (x_last_font_name, x_display_info_for_name):
309 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
310 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
311 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
312 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
313 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
314 (last_show_tip_args): Now static.
315 (xic_defaut_fontset, xic_create_fontsetname): Define only if
316 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
317 (x_screen_planes): Remove; unused.
318 * dispextern.h (x_screen_planes): Remove decl.
319
5bf46f05
PE
320 * dispnew.c: Make symbols static if they're not exported.
321 * dispextern.h (redraw_garbaged_frames, scrolling):
322 (increment_row_positions): Remove.
323 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
324 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
325 Now static.
326 (redraw_garbaged_frames): Remove; unused.
327
435f4c28
PE
328 * xfaces.c: Make symbols static if they're not exported.
329 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
330 Remove decls.
331 * xterm.h (defined_color): Remove decls.
332 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
333 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
334 (menu_face_changed_default, defined_color, free_realized_face):
335 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
336 (ascii_face_of_lisp_face): Remove; unused.
337
8524aef3
PE
338 * xdisp.c: Make symbols static if they're not exported.
339 * dispextern.h (scratch_glyph_row, window_box_edges):
340 (glyph_to_pixel_coords, set_cursor_from_row):
341 (get_next_display_element, set_iterator_to_next):
342 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
343 (show_mouse_face): Remove decls
344 * frame.h (message_buf_print): Likewise.
345 * lisp.h (pop_message, set_message, check_point_in_composition):
346 Likewise.
347 * xterm.h (set_vertical_scroll_bar): Likewise.
348 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
349 (message_buf_print, scratch_glyph_row, displayed_buffer):
350 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
351 (get_next_display_element, show_mouse_face, window_box_edges):
352 (frame_to_window_pixel_xy, check_point_in_composition):
353 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
354 (glyph_to_pixel_coords): Remove; unused.
355
16390cd2
PE
356 * dired.c (file_name_completion): Now static.
357
358 * dbusbind.c (xd_in_read_queued_messages): Now static.
359
a25f4dfa
PE
360 * lisp.h (circular_list_error, FOREACH): Remove; unused.
361 * data.c (circular_list_error): Remove.
362
14a9c8df
PE
363 * commands.h (last_point_position, last_point_position_buffer):
364 (last_point_position_window): Remove decls.
365 * keyboard.c: Make these variables static.
366
74ab6df5
PE
367 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
368 decls.
369 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
370 (iso_code_class, detect_coding, code_convert_region): Now static.
371 (encode_coding_gap): Remove; unused.
372
38dfbee1
PE
373 * chartab.c (chartab_chars, chartab_bits): Now static.
374
a2cb4e63
PE
375 * charset.h (charset_iso_8859_1): Remove decl.
376 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
377 Now static.
378
127198fd
PE
379 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
380 * ccl.c (Vccl_program_table): Now static.
381 (check_ccl_update): Remove; unused.
382
d85b608f
PE
383 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
384 * category.h: ... from here.
385 * category.c (check_category_table, set_category_set): Now static.
386
31cd66f3
PE
387 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
388 * lisp.h: Remove these decls.
389
c358e587
PE
390 * buffer.c (buffer_count): Remove unused var.
391
e78aecca
PE
392 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
393 so that it's not optimized away.
394 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
395 * dispextern.h (bidi_dump_cached_states): Remove, since it's
396 exported only to the debugger.
397
e192d7d3
PE
398 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
399 * atimer.h (run_all_atimers): Removed; not exported.
400
92470028
PE
401 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
402 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
403 was inaccessible from Lisp.
404 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
405 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
406
244ed907
PE
407 alloc.c: Import and export fewer symbols, and remove unused items.
408 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
409 is defined.
410 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
411 it's not optimized away by whole-program optimization.
412 (message_enable_multibyte, free_misc): Remove.
413 (catchlist, handlerlist, mark_backtrace):
414 Declare only if BYTE_MARK_STACK.
415 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
416 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
417 (message_enable_multibyte): Remove decl.
418 (free_misc, interval_free_list, float_block, float_block_index):
419 (n_float_blocks, float_free_list, cons_block, cons_block_index):
420 (cons_free_list, last_marked_index):
421 Now static.
422 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
423 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
424 (mark_backtrace): Define only if BYTE_MARK_STACK.
425 * xdisp.c (message_enable_multibyte): Now static.
426
955cbe7b
PE
427 Declare Lisp_Object Q* variables to be 'static' if not exproted.
428 This makes it easier for human readers (and static analyzers)
429 to see whether these variables are used from other modules.
430 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
431 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
432 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
433 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
434 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
435 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
436 * xmenu.c, xselect.c:
437 Declare Q* vars static if they are not used in other modules.
438 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
439 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
440 Remove decls of unexported vars.
441 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
442
95c82688
PE
443 * lisp.h (DEFINE_FUNC): Make sname 'static'.
444
16a97296
PE
445 Make Emacs functions such as Fatom 'static' by default.
446 This makes it easier for human readers (and static analyzers)
447 to see whether these functions can be called from other modules.
448 DEFUN now defines a static function. To make the function external
449 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
450 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
451 (Finit_image_library):
16a97296
PE
452 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
453 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
454 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
455 Remove decls, since these functions are now static.
456 (Funintern, Fget_internal_run_time): New decls, since these functions
457 were already external.
95c82688 458
16a97296
PE
459 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
460 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
461 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
462 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
463 * keyboard.c, keymap.c, lread.c:
464 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
465 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
466 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
467 Mark functions with DEFUE instead of DEFUN,
468 if they are used in other modules.
469 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
470 decls for now-static functions.
471 * buffer.h (Fdelete_overlay): Remove decl.
472 * callproc.c (Fgetenv_internal): Mark as internal.
473 * composite.c (Fremove_list_of_text_properties): Remove decl.
474 (Fcomposition_get_gstring): New forward static decl.
475 * composite.h (Fcomposite_get_gstring): Remove decl.
476 * dired.c (Ffile_attributes): New forward static decl.
477 * doc.c (Fdocumntation_property): New forward static decl.
478 * eval.c (Ffetch_bytecode): New forward static decl.
479 (Funintern): Remove extern decl; now in .h file where it belongs.
480 * fileio.c (Fmake_symbolic_link): New forward static decl.
481 * image.c (Finit_image_library): New forward static decl.
482 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
483 * intervals.h (Fprevious_property_change):
484 (Fremove_list_of_text_properties): Remove decls.
485 * keyboard.c (Fthis_command_keys): Remove decl.
486 (Fcommand_execute): New forward static decl.
487 * keymap.c (Flookup_key): New forward static decl.
488 (Fcopy_keymap): Now static.
489 * keymap.h (Flookup_key): Remove decl.
490 * process.c (Fget_process): New forward static decl.
491 (Fprocess_datagram_address): Mark as internal.
492 * syntax.c (Fsyntax_table_p): New forward static decl.
493 (skip_chars): Remove duplicate decl.
494 * textprop.c (Fprevious_property_change): New forward static decl.
495 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
496 Now internal.
497 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
498 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
499
785bbd42
PE
500 * editfns.c (Fformat): Remove unreachable code.
501
8b913b57
AS
5022011-04-14 Andreas Schwab <schwab@linux-m68k.org>
503
504 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
505 change. (Bug#8496)
506
a6744a35
EZ
5072011-04-13 Eli Zaretskii <eliz@gnu.org>
508
509 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
510 when at ZV. (Bug#8487)
511
e7974947
AS
5122011-04-12 Andreas Schwab <schwab@linux-m68k.org>
513
baad03f0
AS
514 * charset.c (Fclear_charset_maps): Use xfree instead of free.
515 (Bug#8437)
516 * keyboard.c (parse_tool_bar_item): Likewise.
517 * sound.c (sound_cleanup, alsa_close): Likewise.
518 * termcap.c (tgetent): Likewise.
519 * xfns.c (x_default_font_parameter): Likewise.
520 * xsettings.c (read_and_apply_settings): Likewise.
521
e7974947
AS
522 * alloc.c (overrun_check_malloc, overrun_check_realloc)
523 (overrun_check_free): Protoize.
524
28272684
PE
5252011-04-12 Paul Eggert <eggert@cs.ucla.edu>
526
527 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
528 since callers should never pass a negative size.
529 Change the signature to match that of plain 'read' and 'write'; see
530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
531 * lisp.h: Update prototypes of emacs_write and emacs_read.
532
11997c76
EZ
5332011-04-11 Eli Zaretskii <eliz@gnu.org>
534
535 * xdisp.c (redisplay_window): Don't try to determine the character
536 position of the scroll margin if the window start point w->startp
e896f03c 537 is outside the buffer's accessible region. (Bug#8468)
11997c76 538
8a2cbd72
EZ
5392011-04-10 Eli Zaretskii <eliz@gnu.org>
540
541 Fix write-region and its subroutines for buffers > 2GB.
542 * fileio.c (a_write, e_write): Modify declaration of arguments and
543 local variables to support buffers larger than 2GB.
544 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
545
546 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
547 argument, local variables, and return value.
548
549 * lisp.h: Update prototypes of emacs_write and emacs_read.
550
551 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
552
4073e537 5532011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 554
1ebfdcb6
PE
555 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
556
b2ded58d
PE
557 Fix more problems found by GCC 4.6.0's static checks.
558
7d66342c
PE
559 * xdisp.c (vmessage): Use a better test for character truncation.
560
bbf47d44
PE
561 * charset.c (load_charset_map): <, not <=, for optimization,
562 and to avoid potential problems with integer overflow.
9248994d 563 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 564 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 565 * editfns.c (Fformat): Likewise.
1e69125e 566 * syntax.c (skip_chars): Likewise.
3befa583 567
e3019616
PE
568 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
569 This also lets GCC 4.6.0 generate slightly better loop code.
570
becfa255
PE
571 * callint.c (Fcall_interactively): <, not <=, for optimization.
572 (Fcall_interactively): Count the number of arguments produced,
573 not the number of arguments given. This is simpler and lets GCC
574 4.6.0 generate slightly better code.
575
dae0cd48
PE
576 * ftfont.c: Distingish more carefully between FcChar8 and char.
577 The previous code passed unsigned char * to a functions like
578 strlen and xstrcasecmp that expect char *, which does not
579 conform to the C standard.
580 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
581 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
582 char * when the C standard requires it.
583
76032d70
PE
584 * keyboard.c (read_char): Remove unused var.
585
eb3f1cc8
PE
586 * eval.c: Port to Windows vsnprintf (Bug#8435).
587 Include <limits.h>.
588 (SIZE_MAX): Define if the headers do not.
589 (verror): Do not give up if vsnprintf returns a negative count.
590 Instead, grow the buffer. This ports to Windows vsnprintf, which
591 does not conform to C99. Problem reported by Eli Zaretskii.
592 Also, simplify the allocation scheme, by avoiding the need for
593 calling realloc, and removing the ALLOCATED variable.
594
70476b54
PE
595 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
596
12020a9e
PE
597 Remove invocations of doprnt, as Emacs now uses vsnprintf.
598 But keep the doprint source code for now, as we might revamp it
599 and use it again (Bug#8435).
ea6c7ae6
PE
600 * lisp.h (doprnt): Remove.
601 * Makefile.in (base_obj): Remove doprnt.o.
602 * deps.mk (doprnt.o): Remove.
603
5fdb398c
PE
604 error: Print 32- and 64-bit integers portably (Bug#8435).
605 Without this change, on typical 64-bit hosts error ("...%d...", N)
606 was used to print both 32- and 64-bit integers N, which relied on
607 undefined behavior.
608 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
609 New macro.
610 * lisp.h (error, verror): Mark as printf-like functions.
611 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
612 Report overflow in size calculations when allocating printf buffer.
613 Do not truncate output string at its first null byte.
614 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
615 Truncate the output at a character boundary, since vsnprintf does not
616 do that.
617 * charset.c (check_iso_charset_parameter): Convert internal
618 character to string before calling 'error', since %c now has the
619 printf meaning.
620 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
621 overflow when computing char to be passed to 'error'. Do not
622 pass Lisp_Object to 'error'; pass the integer instead.
623 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
624 formatted with plain %d.
625
b189fa66
PE
626 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
627
bff87ef0
PE
628 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
629
7e2cac20
PE
630 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
631
ce4d90b5
PE
632 * xterm.c (x_catch_errors): Remove duplicate declaration.
633
266c9547
PE
634 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
635
79c49ad2
PE
636 * xdisp.c, lisp.h (message_nolog): Remove; unused.
637
368f4090
JM
6382011-04-10 Jim Meyering <meyering@redhat.com>
639
640 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
641 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
642 return ssize_t not "int", and use size_t as the buffer length.
643 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
644 * gnutls.h: Update declarations.
645 * process.c (read_process_output): Use ssize_t, to match.
646 (send_process): Likewise.
647
a32d4040
CY
6482011-04-09 Chong Yidong <cyd@stupidchicken.com>
649
650 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
651
8546720e 6522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 653
8546720e
GM
654 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
655 unsigned char, to match FcChar8 type definition.
aac0c6e3 656
8546720e
GM
657 * xterm.c (handle_one_xevent):
658 * xmenu.c (create_and_show_popup_menu):
659 * xselect.c (x_decline_selection_request)
660 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 661
0a2f5c1a 6622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
663
664 Fix some uses of `int' instead of EMACS_INT.
665 * search.c (string_match_1, fast_string_match)
666 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
667 (scan_buffer, find_next_newline_no_quit)
668 (find_before_next_newline, search_command, Freplace_match)
669 (Fmatch_data): Make some `int' variables be EMACS_INT.
670
671 * xdisp.c (display_count_lines): 3rd argument and return value now
672 EMACS_INT. All callers changed.
673 (pint2hrstr): Last argument is now EMACS_INT.
674
675 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
676 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
677 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
678 (decode_coding_utf_16, decode_coding_emacs_mule)
679 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
680 (decode_coding_ccl, decode_coding_charset)
681 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
682 (decode_coding_iso_2022, decode_coding_emacs_mule)
683 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
684 <char_offset, last_offset>: Declare EMACS_INT.
685 (encode_coding_utf_8, encode_coding_utf_16)
686 (encode_coding_emacs_mule, encode_invocation_designation)
687 (encode_designation_at_bol, encode_coding_iso_2022)
688 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
689 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
690 Declare EMACS_INT.
691 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
692 (encode_invocation_designation): Last argument P_NCHARS is now
693 EMACS_INT.
694 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
695 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
696
697 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
698 All users changed.
699
700 * ccl.c (Fccl_execute_on_string): Declare some variables
701 EMACS_INT.
702
8546720e 7032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
704
705 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
706
4e19a977
CS
7072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
708
709 * process.c (Fformat_network_address): Doc fix.
710
87302331
R
7112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
712
713 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
714
cbb59342
CY
7152011-04-08 Chong Yidong <cyd@stupidchicken.com>
716
717 * keyboard.c (read_char): Call Lisp function help-form-show,
718 instead of using internal_with_output_to_temp_buffer.
719 (Qhelp_form_show): New var.
e0d38eeb 720 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
721
722 * print.c (internal_with_output_to_temp_buffer): Function deleted.
723
724 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
725
e67a13ab
CY
7262011-04-06 Chong Yidong <cyd@stupidchicken.com>
727
728 * process.c (Flist_processes): Removed to Lisp.
729 (list_processes_1): Deleted.
730
973f782d
EZ
7312011-04-06 Eli Zaretskii <eliz@gnu.org>
732
7c106b1e
EZ
733 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
734
973f782d
EZ
735 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
736
41cf7d1a 7372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 738
ca23cc88
PE
739 Fix more problems found by GCC 4.6.0's static checks.
740
f390e2d5
PE
741 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
742
42eea0d0
PE
743 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
744
b69769da 745 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 746
f9541e84
PE
747 * xdisp.c (vmessage): Mark as a printf-like function.
748
13841b55
PE
749 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
750
c136c10f
PE
751 * sound.c (sound_warning): Don't crash if arg contains a printf format.
752
5e2d4a30
PE
753 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
754 printf-like functions.
755 (tiff_load): Add casts to remove these marks before passing them
756 to system-supplied API.
757
583f48b9
PE
758 * eval.c (Fsignal): Remove excess argument to 'fatal'.
759
b25d760e
PE
760 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
761 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
762 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
763 directly, rather than having caller test rule sign. This avoids
764 some unnecessary tests.
765 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
766 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
767 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 768
bc7b6697 769 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 770 (xfont_open): Avoid unnecessary tests.
bc7b6697 771
27ccc379
PE
772 * composite.c (composition_gstring_put_cache): Use unsigned integer.
773
dcd5c89a
PE
774 * composite.h, composite.c (composition_gstring_put_cache):
775 Use EMACS_INT, not int, for length.
776
b13a45c6
PE
777 * composite.h (COMPOSITION_DECODE_REFS): New macro,
778 breaking out part of COMPOSITION_DECODE_RULE.
779 (COMPOSITION_DECODE_RULE): Use it.
780 * composite.c (get_composition_id): Remove unused local vars,
781 by using the new macro.
782
1e792e4d
PE
783 * textprop.c (set_text_properties_1): Change while to do-while,
784 since the condition is always true at first.
785
dc6c6455 786 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
787 (interval_deletion_adjustment): Return unsigned value.
788 All uses changed.
dc6c6455 789
aba7731a
PE
790 * process.c (list_processes_1, create_pty, read_process_output):
791 (exec_sentinel): Remove vars that were set but not used.
afd4052b 792 (create_pty): Remove unnecessary "volatile"s.
bc57d757 793 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 794 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 795 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 796
fdfc4bf3
PE
797 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
798
fca8fe46 799 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 800 (update_syntax_table): Use unsigned instead of int.
fca8fe46 801
06a0259a 802 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 803 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 804 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 805
e7b9e80f
PE
806 * print.c (print_error_message): Avoid int overflow.
807
56201685
PE
808 * font.c (font_list_entities): Redo for clarity,
809 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
810
78834453 811 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 812 (font_score): Avoid potential overflow in diff calculation.
78834453 813
0bc0b309 814 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 815 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 816
e610eaca
PE
817 * eval.c (funcall_lambda): Rename local to avoid shadowing.
818
b895abce
PE
819 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
820 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
821 can always succeed if overflow has undefined behavior.
822
1f1d9321 823 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 824 (wordify): Omit three unnecessary tests.
1f1d9321 825
c59478bc
PE
826 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
827 All callers changed. This avoids the need for an unused var.
828
79b73827
PE
829 * casefiddle.c (casify_region): Remove var that is set but not used.
830
a4db5dfe
PE
831 * dired.c (file_name_completion): Remove var that is set but not used.
832
43aae36e
PE
833 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
834
2a47c44d 835 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 836 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 837
a37c69bf
PE
838 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
839 Check for integer overflow on size calculations.
840
328ab8e7
PE
841 * buffer.c (Fprevious_overlay_change): Remove var that is set
842 but not used.
843
e5a2a5cb
PE
844 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
845 Remove vars that are set but not used.
8d84a6eb 846 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 847 (timer_check_2): Mark vars as initialized.
e5a2a5cb 848
a60e5f68
PE
849 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
850
f661cb61 851 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 852 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 853
f0397f5a
PE
854 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
855 that are set but not used.
856
8664db06 857 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 858 if XCreateBitmapFromData fails (Bug#8410).
8664db06 859
6abdaa4a
PE
860 * xselect.c (x_get_local_selection, x_handle_property_notify):
861 Remove vars that are set but not used.
862
0ce7538d 863 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 864 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 865
9ae848fc
PE
866 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
867 Remove var that is set but not used.
0b918413
PE
868 (scroll_bar_windows_size): Now size_t, not int.
869 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
870 Check for overflow.
9ae848fc 871
a5a62657
PE
872 * xfaces.c (realize_named_face): Remove vars that are set but not used.
873 (map_tty_color) [!defined MSDOS]: Likewise.
874
5c5cdd39
PE
875 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
876
66ebf983
PE
877 * coding.c: Remove vars that are set but not used.
878 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
879 All callers changed.
880 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
881 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
882 (decode_coding_charset): Remove vars that are set but not used.
883
1be4d761
PE
884 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
885 that is set but not used.
886
47553fa8
PE
887 * print.c (print_object): Remove var that is set but not used.
888
1f7196bf 889 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
890 The gnulib version avoids calling malloc in the usual case,
891 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
892 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
893 * filelock.c (current_lock_owner): Likewise.
894 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
895 * sysdep.c: Include allocator.h, careadlinkat.h.
896 (emacs_no_realloc_allocator): New static constant.
897 (emacs_readlink): New function.
fdb61804
PE
898 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
899 ../lib/careadlinkat.h.
d1fdcab7 900
f84c17c7
SM
9012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
902
903 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
904 first non-nil return value).
905
ef3862ad
JD
9062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
907
908 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
909 if not defined (Bug#8403).
910
376a7006
JB
9112011-04-02 Juanma Barranquero <lekktu@gmail.com>
912
913 * xdisp.c (display_count_lines): Remove parameter `start',
914 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
915 (get_char_face_and_encoding): Remove parameter `multibyte_p',
916 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
917 (fill_stretch_glyph_string): Remove parameters `row' and `area',
918 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
919 and thereabouts. All callers changed.
920 (get_per_char_metric): Remove parameter `f', unused since
921 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
922
6ca3801d
JM
9232011-04-02 Jim Meyering <meyering@redhat.com>
924
925 do not dereference NULL upon failed strdup
926 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
927 (ns_get_family): Likewise.
928
d8e2b5ba
JB
9292011-04-02 Juanma Barranquero <lekktu@gmail.com>
930
931 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
932
8c74fcbd
JD
9332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
934
935 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
936 later (Bug#8403).
937
7200d79c
SM
9382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
939
03408648 940 Add lexical binding.
7200d79c 941
03408648
SM
942 * window.c (Ftemp_output_buffer_show): New fun.
943 (Fsave_window_excursion):
944 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
945
946 * lread.c (lisp_file_lexically_bound_p): New function.
947 (Fload): Bind Qlexical_binding.
948 (readevalloop): Remove `evalfun' arg.
949 Bind Qinternal_interpreter_environment.
950 (Feval_buffer): Bind Qlexical_binding.
951 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
952 Mark as dynamic.
953 (syms_of_lread): Declare `lexical-binding'.
954
955 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
956
957 * keyboard.c (eval_dyn): New fun.
958 (menu_item_eval_property): Use it.
ca105506
SM
959
960 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 961
03408648
SM
962 * fns.c (concat, mapcar1): Accept byte-code-functions.
963
964 * eval.c (Fsetq): Handle lexical vars.
965 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
966 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
967 (FletX, Flet): Obey lexical binding.
968 (Fcommandp): Handle closures.
969 (Feval): New `lexical' arg.
970 (eval_sub): New function extracted from Feval. Use it almost
971 everywhere where Feval was used. Look up vars in lexical env.
972 Handle closures.
973 (Ffunctionp): Move from subr.el.
974 (Ffuncall): Handle closures.
975 (apply_lambda): Remove `eval_flags'.
976 (funcall_lambda): Handle closures and new byte-code-functions.
977 (Fspecial_variable_p): New function.
978 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
979 but without exporting it to Lisp.
23aba0ea 980
23aba0ea 981 * doc.c (Fdocumentation, store_function_docstring):
03408648 982 * data.c (Finteractive_form): Handle closures.
23aba0ea 983
03408648
SM
984 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
985 interactive spec.
ba83908c 986
03408648
SM
987 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
988 byte-codes.
989 (exec_byte_code): New function extracted from Fbyte_code to handle new
990 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 991
03408648 992 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 993
03408648 994 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 995
e2abce01
JB
9962011-03-31 Juanma Barranquero <lekktu@gmail.com>
997
998 * xdisp.c (redisplay_internal): Fix prototype.
999
63696a73 10002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1001
63696a73
EZ
1002 * xdisp.c (SCROLL_LIMIT): New macro.
1003 (try_scrolling): Use it when setting scroll_limit. Limit
1004 scrolling to 100 screen lines.
1005 (redisplay_window): Even when falling back on "recentering",
1006 position point in the window according to scroll-conservatively,
1007 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1008
1009 (try_scrolling): When point is above the window, allow searching
1010 as far as scroll_max, or one screenful, to compute vertical
1011 distance from PT to the scroll margin position. This prevents
1012 try_scrolling from unnecessarily failing when
1013 scroll-conservatively is set to a value slightly larger than the
1014 window height. Clean up the case of PT below the margin at bottom
1015 of window: scroll_max can no longer be INT_MAX. When aggressive
1016 scrolling is in use, don't let point enter the opposite scroll
1017 margin as result of the scroll.
1018 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1019 threshold of 100 lines for never-recentering scrolling.
1020
e4cc2dfc
JB
10212011-03-31 Juanma Barranquero <lekktu@gmail.com>
1022
1023 * dispextern.h (move_it_by_lines):
1024 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1025 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1026 (message_log_check_duplicate): Remove parameters `prev_bol' and
1027 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1028 (redisplay_internal): Remove parameter `preserve_echo_area',
1029 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1030
1031 * indent.c (Fvertical_motion):
1032 * window.c (window_scroll_pixel_based, Frecenter):
1033 Don't pass `need_y_p' to `move_it_by_lines'.
1034
1c470562
SM
10352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1036
44f230aa
SM
1037 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1038 steal a few bits to be more compact.
1039 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1040 Remove unneeded casts.
1041
1c470562
SM
1042 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1043
888adce9
ZK
10442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1045
1046 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1047 binding" message (bug#7967).
1048
f838ed7b
PE
10492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1050
77861b95
PE
1051 Fix more problems found by GCC 4.6.0's static checks.
1052
de6dbc14
PE
1053 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1054 Remove unused local var.
1055
f838ed7b
PE
1056 * editfns.c (Fmessage_box): Remove unused local var.
1057
792c7b2b
PE
1058 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1059 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1060 Omit unused local vars.
c499e557 1061 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1062 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1063 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1064 Omit unused local var.
1065
ba0165e1
PE
1066 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1067 Don't assume string length fits in int.
32ad8845 1068 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1069 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1070
3c59b4c9
PE
1071 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1072 instead of alloca (Bug#8344).
1073
a3eed478 1074 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1075 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1076
eb4d412d
PE
1077 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1078
1658b401
PE
1079 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1080 concerns.
1081
1082 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1083
1084 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1085
9a2c6e05
PE
1086 * keyboard.c (syms_of_keyboard): Use the same style as later
1087 in this function when indexing through an array. This also
1088 works around GCC bug 48267.
1089
03d0a109
PE
1090 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1091
44f730c8
PE
1092 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1093
fe75f926
PE
1094 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1095 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1096
ffa8c828
PE
1097 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1098 This avoids undefined behavior on integer overflow, and is a bit
1099 more convenient anyway since it is compared to a size_t variable.
1100
c5101a77
PE
1101 Variadic C functions now count arguments with size_t, not int.
1102 This avoids an unnecessary limitation on 64-bit machines, which
1103 caused (substring ...) to crash on large vectors (Bug#8344).
1104 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1105 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1106 All variadic functions and their callers changed accordingly.
c5101a77
PE
1107 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1108 * data.c (arith_driver, float_arith_driver): Likewise.
1109 * editfns.c (general_insert_function): Likewise.
1110 * eval.c (struct backtrace.nargs, interactive_p)
1111 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1112 (funcall_lambda, mark_backtrace): Likewise.
1113 * fns.c (concat): Likewise.
1114 * frame.c (x_set_frame_parameters): Likewise.
1115 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1116 0 if not found, not -1. All callers changed.
1117
dd3f25f7
PE
1118 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1119 (stack_copy_size): Now size_t, not int.
1120 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1121
461c2ab9
JB
11222011-03-28 Juanma Barranquero <lekktu@gmail.com>
1123
1124 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1125 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1126 All callers changed.
1127
1128 * lisp.h (multibyte_char_to_unibyte):
1129 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1130 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1131 * character.h (CHAR_TO_BYTE8):
1132 * cmds.c (internal_self_insert):
1133 * editfns.c (general_insert_function):
1134 * keymap.c (push_key_description):
1135 * search.c (Freplace_match):
1136 * xdisp.c (message_dolog, set_message_1): All callers changed.
1137
f6d62986
SM
11382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1139
1140 * keyboard.c (safe_run_hook_funcall): New function.
1141 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1142 don't set the hook to nil, but remove the offending function instead.
1143 (Qcommand_hook_internal): Remove, unused.
1144 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1145 Vcommand_hook_internal.
1146
1147 * eval.c (enum run_hooks_condition): Remove.
1148 (funcall_nil, funcall_not): New functions.
1149 (run_hook_with_args): Call each function through a `funcall' argument.
1150 Remove `cond' argument, now redundant.
1151 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1152 (Frun_hook_with_args_until_failure): Adjust accordingly.
1153 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1154
1db5b1ad
JB
11552011-03-28 Juanma Barranquero <lekktu@gmail.com>
1156
1157 * dispextern.h (string_buffer_position): Remove declaration.
1158
1159 * print.c (strout): Remove parameter `multibyte', unused since
1160 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1161
1162 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1163 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1164 All callers changed.
1165
1166 * w32.c (_wsa_errlist): Use braces for struct initializers.
1167
1168 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1169 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1170 All callers changed.
1171 (string_buffer_position): Likewise. Also, make static (it's never
1172 used outside xdisp.c).
1173 (cursor_row_p): Remove parameter `w', unused since
1174 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1175 (decode_mode_spec): Remove parameter `precision', introduced during
1176 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1177 All callers changed.
1178
5ffb62aa
JD
11792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1182
461c2ab9 11832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1184
1185 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1186 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1187 (ns_update_auto_hide_menu_bar): New functions.
1188 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1189 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1190 ns_constrain_all_frames.
1191 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1192 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1193
5c380ffb
JD
11942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1195
1196 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1197
9af30bdf
GM
11982011-03-27 Glenn Morris <rgm@gnu.org>
1199
1200 * syssignal.h: Replace RETSIGTYPE with void.
1201 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1202 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1203 Replace SIGTYPE with void everywhere.
1204 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1205 * s/template.h (SIGTYPE): Remove commented out definition.
1206
e2abce01
JB
12072011-03-26 Eli Zaretskii <eliz@gnu.org>
1208
1209 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1210 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1211
f868cd8a
JB
12122011-03-26 Juanma Barranquero <lekktu@gmail.com>
1213
59eb0929
JB
1214 * w32.c (read_unc_volume): Use parameter `henum', instead of
1215 global variable `wget_enum_handle'.
1216
1217 * keymap.c (describe_vector): Remove parameters `indices' and
1218 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1219 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1220
f868cd8a
JB
1221 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1222
1223 * keyboard.c (timer_check): Remove parameter `do_it_now',
1224 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1225 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1226 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1227
1228 * keyboard.c (read_char):
1229 * w32menu.c (w32_menu_display_help):
1230 * xmenu.c (show_help_event, menu_help_callback):
1231 Adjust calls to `show_help_echo'.
1232
1233 * gtkutil.c (xg_maybe_add_timer):
1234 * keyboard.c (readable_events):
1235 * process.c (wait_reading_process_output):
1236 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1237
1238 * insdel.c (adjust_markers_gap_motion):
1239 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1240 (gap_left, gap_right): Don't call it.
1241
2ecf6fdb
CY
12422011-03-25 Chong Yidong <cyd@stupidchicken.com>
1243
1244 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1245 incurred during fontification.
1246
6b1f9ba4
JB
12472011-03-25 Juanma Barranquero <lekktu@gmail.com>
1248
1249 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1250 (DEFVAR_PER_BUFFER): Don't pass it.
1251
1252 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1253 (scrolling_window): Don't pass it.
1254
0f4a96b5
JB
12552011-03-25 Juanma Barranquero <lekktu@gmail.com>
1256
1257 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1258
1259 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1260 and `suffix'.
1261 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1262 of variables specific to SELinux and computation of `encoded_absname'.
1263
1264 * image.c (XPutPixel): Remove unused variable `height'.
1265
1266 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1267
1268 * unexw32.c (get_section_info): Remove unused variable `section'.
1269
1270 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1271 (system_process_attributes): Remove unused variable `sess'.
1272 (sys_read): Remove unused variable `err'.
1273
1274 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1275 (w32_wnd_proc): Remove unused variable `isdead'.
1276 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1277 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1278 (x_create_tip_frame): Remove unused variable `tem'.
1279
1280 * w32inevt.c (w32_console_read_socket):
1281 Remove unused variable `no_events'.
1282
1283 * w32term.c (x_draw_composite_glyph_string_foreground):
1284 Remove unused variable `width'.
1285
1149507c
JB
12862011-03-24 Juanma Barranquero <lekktu@gmail.com>
1287
1288 * w32term.c (x_set_glyph_string_clipping):
1289 Don't pass uninitialized region to CombineRgn.
1290
9c88f339
JB
12912011-03-23 Juanma Barranquero <lekktu@gmail.com>
1292
1293 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1294 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1295 (Fx_close_connection): Remove unused variable `i'.
1296
1297 * w32font.c (w32font_draw): Return number of glyphs.
1298 (w32font_open_internal): Remove unused variable `i'.
1299 (w32font_driver): Add missing initializer.
1300
1301 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1302 (fill_in_menu): Remove unused variable `items_added'.
1303
1304 * w32term.c (last_mouse_press_frame): Remove static global variable.
1305 (w32_clip_to_row): Remove unused variable `f'.
1306 (x_delete_terminal): Remove unused variable `i'.
1307
1308 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1309 (NOTHING): Remove unused static global variable.
1310 (uniscribe_check_otf): Remove unused variable `table'.
1311 (uniscribe_font_driver): Add missing initializers.
1312
dee091a3
JD
13132011-03-23 Julien Danjou <julien@danjou.info>
1314
1315 * term.c (Fsuspend_tty, Fresume_tty):
1316 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1317 * window.c (temp_output_buffer_show):
1318 * insdel.c (signal_before_change):
1319 * frame.c (Fhandle_switch_frame):
1320 * fileio.c (Fdo_auto_save):
1321 * emacs.c (Fkill_emacs):
1322 * editfns.c (save_excursion_restore):
1323 * cmds.c (internal_self_insert):
1324 * callint.c (Fcall_interactively):
1325 * buffer.c (Fkill_all_local_variables):
1326 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1327 Use Frun_hooks.
0f4a96b5 1328 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1329 unconditionnaly since it does the check itself.
1330
2c520ab5 13312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1332
c9c49752
PE
1333 Fix more problems found by GCC 4.5.2's static checks.
1334
8abc3f12
PE
1335 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1336 the first time through the loop, since we know p0 < p1 then.
1337 This also avoids a gcc -Wstrict-overflow warning.
1338
a2d26660
PE
1339 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1340 leading to a memory leak, possible in functions like
1341 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1342 of objects (Bug#8318).
a2d26660 1343
916c72e9
PE
1344 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1345 that could (at least in theory) be that large.
1346
19ab8a18
PE
1347 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1348 This is less likely to overflow, and avoids undefined behavior if
1349 overflow does occur. All callers changed. Use strtoul to scan
1350 for the unsigned long integer.
b7cbbd6f
PE
1351 (pint2hrstr): Simplify and tune code slightly.
1352 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1353
f0641eff
PE
1354 * scroll.c (do_scrolling): Work around GCC bug 48228.
1355 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1356
7f650bb9
PE
1357 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1358 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1359 (validate_x_resource_name): Simplify count usage.
1360 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1361
37dd57d1
PE
1362 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1363 fail (Bug#8306).
81e56e61 1364
699979fc 1365 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1366
401bf9b4
PE
1367 * process.c (Fmake_network_process): Use socklen_t, not int,
1368 where POSIX says socklen_t is required in portable programs.
1369 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1370 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1371 (Fmake_network_process, server_accept_connection):
1372 (wait_reading_process_output, read_process_output):
1373 Likewise.
1374
b93aacde
PE
1375 * process.c: Rename or move locals to avoid shadowing.
1376 (list_processes_1, Fmake_network_process):
1377 (read_process_output_error_handler, exec_sentinel_error_handler):
1378 Rename or move locals.
4dc343ee 1379 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1380 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1381 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1382 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1383 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1384
af8a867c 1385 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1386 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1387 Include tparam.h instead, since it declares them.
af8a867c
PE
1388 * cm.h (PC): Remove extern decl; tparam.h now does this.
1389 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1390 * terminfo.c: Include tparam.h, to check interfaces.
1391 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1392 (tparam): Adjust signature to match interface in tparam.h;
1393 this removes some undefined behavior. Check that outstring and len
1394 are zero, which they always are with Emacs.
1395 * tparam.h (PC, BC, UP): New extern decls.
1396
0248044d 1397 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1398 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1399
8ff096c1 1400 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1401 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1402 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1403 (ftfont_list): Remove unused local.
49eaafba
PE
1404 (get_adstyle_property, ftfont_pattern_entity):
1405 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1406 Rename locals to avoid shadowing.
8ff096c1 1407
e2be39f6
PE
1408 * xfont.c (xfont_list_family): Mark var as initialized.
1409
c9735e30
PE
1410 * xml.c (make_dom): Now static.
1411
8f5201ae
PE
1412 * composite.c (composition_compute_stop_pos): Rename local to
1413 avoid shadowing.
b246f932
PE
1414 (composition_reseat_it): Remove unused locals.
1415 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1416 (composition_update_it): Mark var as initialized.
11b61122
PE
1417 (find_automatic_composition): Mark vars as initialized,
1418 with a FIXME (Bug#8290).
8f5201ae 1419
760fbc2c
PE
1420 character.h: Rename locals to avoid shadowing.
1421 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1422 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1423 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1424 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1425 to avoid shadowing.
1426
ff08eb85
PE
1427 * textprop.c (property_change_between_p): Remove; unused.
1428
fc7bf025
PE
1429 * intervals.c (interval_start_pos): Now static.
1430
235d7abc
PE
1431 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1432
44f230aa
SM
1433 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1434 Rename locals to avoid shadowing.
3e7d6594 1435
50060332
PE
1436 * sound.c (wav_play, au_play, Fplay_sound_internal):
1437 Fix pointer signedness.
d01f234b 1438 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1439 (wav_play): Initialize a variable to 0, to prevent undefined
1440 behavior (Bug#8278).
50060332 1441
c4fc4e30
PE
1442 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1443
918436ed
PE
1444 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1445
c939f91b
PE
1446 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1447 clobbering (Bug#8298).
b9c7f648
PE
1448 * sysdep.c (sys_subshell): Likewise.
1449 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1450
6bd8c144
PE
1451 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1452 This should get cleaned up, so that child_setup has the
1453 same signature on all platforms.
1454
7710357c 1455 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1456 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1457
c59da222
CY
14582011-03-22 Chong Yidong <cyd@stupidchicken.com>
1459
1460 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1461 not to be necessary, and produces flickering.
1462
66b87493
GM
14632011-03-20 Glenn Morris <rgm@gnu.org>
1464
1465 * config.in: Remove file.
1466
45b6f6d5
JB
14672011-03-20 Juanma Barranquero <lekktu@gmail.com>
1468
1469 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1470 are now in src/globals.h.
1471 (syms_of_minibuf): Remove spurious & from previous change.
1472
3ec03f7e
LL
14732011-03-20 Leo <sdl.web@gmail.com>
1474
1475 * minibuf.c (completing-read-function): New variable.
1476 (completing-read-default): Rename from completing-read.
1477 (completing-read): Call completing-read-function.
1478
b14e3e21
CY
14792011-03-19 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * xfaces.c (Fx_load_color_file):
1482 Read color file from absolute filename (bug#8250).
1483
f2b726e6
JB
14842011-03-19 Juanma Barranquero <lekktu@gmail.com>
1485
1486 * makefile.w32-in: Update dependencies.
1487
09f6ff02
EZ
14882011-03-17 Eli Zaretskii <eliz@gnu.org>
1489
1490 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1491
29a6015a
PE
14922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1493
a3a6c54e
PE
1494 Fix more problems found by GCC 4.5.2's static checks.
1495
b766f867
PE
1496 * process.c (make_serial_process_unwind, send_process_trap):
1497 (sigchld_handler): Now static.
1498
be02381c
PE
1499 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1500 That way, the code declares only the vars that it needs.
1501 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1502 * s/cygwin.h (PTY_ITERATION): Likewise.
1503 * s/darwin.h (PTY_ITERATION): Likewise.
1504 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1505
57048744
PE
1506 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1507 * process.c (allocate_pty): Don't declare stb unless it's needed.
1508
7914961c 1509 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1510 (CONSTANTLIM): Remove; unused.
1511 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1512 Define only if needed.
7914961c 1513
b3967b18
PE
1514 * unexelf.c (unexec): Name an expression,
1515 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1516 Use a different way to cause a compilation error if anyone uses
1517 n rather than nn, a way that does not involve shadowing.
73366a00 1518 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1519
29a6015a
PE
1520 * deps.mk (unexalpha.o): Remove; unused.
1521
43cfc33e 1522 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1523 * unexec.h: New file.
ce701a33
PE
1524 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1525 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1526 Depend on unexec.h.
1527 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1528 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1529 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1530 Change as necessary to match prototype in unexec.h.
ce701a33 1531
01f44d5a
PE
1532 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1533 shadowing.
4f63c6bb 1534 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1535
a6670b0b
PE
1536 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1537 Rename locals to avoid shadowing.
1538
cef2010d 1539 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1540 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1541
d4d7173a
PE
1542 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1543
f08b802a
PE
1544 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1545 warning when compiling print.c.
1546
3ddb0639
PE
1547 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1548 instead of using an uninitialized var.
5ad03b97 1549 (font_sort_entities): Mark var as initialized.
3ddb0639 1550
170a2692
PE
1551 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1552
e663c700
PE
1553 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1554 pointers to constants.
89bc529a 1555 (font_parse_fcname): Remove unused vars.
7b81e2d0 1556 (font_delete_unmatched): Now static.
ea838e10 1557 (font_get_spec): Remove; unused.
13a547c6
PE
1558 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1559 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1560 Rename or move locals to avoid shadowing.
e663c700 1561
2a80c887 1562 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1563 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1564
1384fa33 1565 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1566 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1567
8b2c52e9
PE
1568 * alloc.c (mark_backtrace): Move decl from here ...
1569 * lisp.h: ... to here, so that it can be checked.
1570
475545b5 1571 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1572 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1573 (lisp_indirect_variable): Name an expression,
1574 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1575 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1576
b1349114 1577 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1578 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1579 Use const pointer when appropriate.
b1349114 1580
a2928364
PE
1581 * lisp.h (get_system_name, get_operating_system_release):
1582 Move decls here, to check interfaces.
1583 * process.c (get_operating_system_release): Move decl to lisp.h.
1584 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1585 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1586 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1587 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1588 (Fformat_time_string, Fencode_time, Finsert_char):
1589 (Ftranslate_region_internal, Fformat):
1590 Rename or remove local vars to avoid shadowing.
9710023e 1591 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1592
a415e694
PE
1593 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1594 avoid shadowing.
1595
8ef4622d
PE
1596 * lisp.h (eassert): Check that the argument compiles, even if
1597 ENABLE_CHECKING is not defined.
1598
946f9a5b
PE
1599 * data.c (Findirect_variable): Name an expression, to avoid
1600 gcc -Wbad-function-cast warning.
112396d6 1601 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1602 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1603 (Fmake_variable_buffer_local, Fmake_local_variable):
1604 Mark variables as initialized.
52746918 1605 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1606
e5aab7e7 1607 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1608 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1609 Rename locals to avoid shadowing.
dff45157
PE
1610 (mark_stack): Move local variables into the #ifdef region where
1611 they're used.
7bc26fdb
PE
1612 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1613 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1614 needed otherwise.
1615 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1616 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1617 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1618
e5aab7e7
PE
1619 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1620 avoids undefined behavior in theory.
1621
4da60324
PE
1622 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1623
88043301
PE
1624 Use functions, not macros, for up- and down-casing (Bug#8254).
1625 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1626 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1627 to use the following functions instead of these macros.
1628 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1629 EMACS_INT, since callers assume the returned value fits in int.
1630 (upcase1): Likewise, for UPCASE_TABLE.
1631 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1632 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1633 the race-condition problem in the old DOWNCASE.
88043301 1634
19ed5445
PE
1635 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1636 Rename locals to avoid shadowing.
1637 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1638 (regex_compile, re_search_2, re_match_2_internal):
1639 Remove unused local vars.
952db0d7
PE
1640 (FREE_VAR): Rewrite so as not to use empty "else",
1641 which gcc can warn about.
da053e48 1642 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1643 (RETALLOC_IF): Define only if needed.
1644 (WORDCHAR_P): Likewise. This one is never needed, but is used
1645 only in a comment talking about a compiler bug, so put inside
1646 the #if 0 of that comment.
1647 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1648 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1649 Remove; unused.
19ed5445 1650
1f3561e4 1651 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1652 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1653 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1654
ded6f8f7
PE
1655 * search.c (simple_search): Remove unused var.
1656
dbd37a95
PE
1657 * dired.c (compile_pattern): Move decl from here ...
1658 * lisp.h: ... to here, so that it can be checked.
1659 (struct re_registers): New forward decl.
1660
7e47afad
PE
1661 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1662
85f24f61
PE
1663 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1664 All uses changed.
1665 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1666 Rename locals to avoid shadowing.
5671df8f 1667 (Fvertical_motion): Mark locals as initialized.
85f24f61 1668
181aa2be 1669 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1670 (casify_region): Mark local as initialized.
181aa2be 1671
930d429c
PE
1672 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1673
7082eac6
PE
1674 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1675 New macros, so that the caller can use some names other than
1676 gcpro1, gcpro2, etc.
1677 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1678 of the new macros.
1679 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1680 argument, for consistency with GCPRO2_VAR, etc: it is now the
1681 prefix of the variable, not the variable itself. All uses
1682 changed.
38b2c076
PE
1683 * dired.c (directory_files_internal, file_name_completion):
1684 Rename locals to avoid shadowing.
1685
15206ed9
PE
1686 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1687 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1688 dired.c's scmp function, had undefined behavior.
1689 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1690 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1691 * buffer.h: ... to here, because these macros use current_buffer,
1692 and the new implementation with inline functions needs to have
1693 current_buffer in scope now, rather than later when the macros
1694 are used.
1695 (downcase, upcase1): New static inline functions.
1696 (DOWNCASE, UPCASE1): Reimplement using these functions.
1697 This avoids undefined behavior in expressions like
1698 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1699 from race conditions in accessing the global variables
1700 case_temp1 and case_temp2.
1701 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1702 * lisp.h (case_temp1, case_temp2): Remove their decls.
1703 * character.h (ASCII_CHAR_P): Move from here ...
1704 * lisp.h: ... to here, so that the inline functions mentioned
1705 above can use them.
1706
4a6bea26
PE
1707 * dired.c (directory_files_internal_unwind): Now static.
1708
f14b7e14
PE
1709 * fileio.c (file_name_as_directory, directory_file_name):
1710 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1711 Now static.
2893f146
PE
1712 (file_name_as_directory): Use const pointers when appropriate.
1713 (Fexpand_file_name): Likewise. In particular, newdir might
1714 point at constant storage, so make it a const pointer.
fd4ead52 1715 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1716 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1717 signedness issues.
f839df0c
PE
1718 (Fset_file_times, Finsert_file_contents, auto_save_error):
1719 Rename locals to avoid shadowing.
f14b7e14 1720
5716756e 1721 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1722 (Ftry_completion, Fall_completions): Rename or remove locals
1723 to avoid shadowing.
5716756e 1724
b4c3046a
PE
1725 * marker.c (bytepos_to_charpos): Remove; unused.
1726
b45db522
PE
1727 * lisp.h (verify_bytepos, count_markers): New decls,
1728 so that gcc does not warn that these functions aren't declared.
1729
85876d07
PE
1730 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1731 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1732 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1733 (copy_text): Remove unused local var.
85876d07 1734
03d78a21 1735 * filelock.c (within_one_second): Now static.
b3dd38ab 1736 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1737
5df8f01b
PE
1738 * buffer.c (fix_overlays_before): Mark locals as initialized.
1739 (fix_start_end_in_overlays): Likewise. This function should be
1740 simplified by using pointers-to-pointers, but that's a different
1741 matter.
b1d876f1 1742 (switch_to_buffer_1): Now static.
8f54f30a
PE
1743 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1744 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1745
a70072c9 1746 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1747 Fix pointer signedness issue.
edced198
PE
1748 (sys_subshell): Mark local as volatile if checking for lint,
1749 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1750 (MAXPATHLEN): Define only if needed.
a70072c9 1751
a0977c44
PE
1752 * process.c (serial_open, serial_configure): Move decls from here ...
1753 * systty.h: ... to here, so that they can be checked.
1754
a884fdcc
PE
1755 * fns.c (get_random, seed_random): Move extern decls from here ...
1756 * lisp.h: ... to here, so that they can be checked.
1757
604efe86 1758 * sysdep.c (reset_io): Now static.
b8950c94 1759 (wait_for_termination_signal): Remove; unused.
604efe86 1760
38fc62d9
PE
1761 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1762 (copy_keymap_item, append_key, push_text_char_description):
1763 Now static.
1004a21a 1764 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1765 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1766 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1767 (describe_map_tree):
1768 Rename locals to avoid shadowing.
38fc62d9 1769
2f2650da
PE
1770 * keyboard.c: Declare functions static if they are not used elsewhere.
1771 (echo_char, echo_dash, cmd_error, top_level_2):
1772 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1773 (read_char, kbd_buffer_get_event, make_lispy_position):
1774 (make_lispy_event, make_lispy_movement, apply_modifiers):
1775 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1776 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1777 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1778 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1779 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1780
a053e86c 1781 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1782 (mark_kboards): Move decl here ...
1783 * alloc.c (mark_kboards): ... from here.
a053e86c 1784
4752793e
PE
1785 * lisp.h (force_auto_save_soon): New decl.
1786
74f10ca7 1787 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1788 (DEFINE_DUMMY_FUNCTION): New macro.
1789 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1790 Use it.
c03cd23f
PE
1791 (main): Add casts to avoid warnings
1792 if GCC considers string literals to be constants.
74f10ca7 1793
022e70d4
PE
1794 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1795
59d6fe83
PE
1796 * dbusbind.c: Pointer signedness fixes.
1797 (xd_signature, xd_append_arg, xd_initialize):
1798 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1799 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1800 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1801 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1802
78320123
PE
1803 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1804 if GCC considers string literals to be constants.
49cebcca 1805 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1806
35ac2a97
SM
18072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1808
fb103ca9
SM
1809 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1810 (print_preprocess, print_object): New macro to fix last change.
1811
35ac2a97
SM
1812 * print.c (print_preprocess): Don't forget font objects.
1813
62973b41
JB
18142011-03-16 Juanma Barranquero <lekktu@gmail.com>
1815
1816 * emacs.c (USAGE3): Doc fixes.
1817
0e48bb22
AS
18182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1819
1820 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1821 structure.
1822
7684e57b
JB
18232011-03-14 Juanma Barranquero <lekktu@gmail.com>
1824
1825 * lisp.h (VWindow_system, Qfile_name_history):
1826 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1827 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1828 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1829
1830 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1831 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1832
1833 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1834 * w32console.c (detect_input_pending, read_input_pending)
1835 (encode_terminal_code):
1836 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1837 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1838 (w32_system_caret_y, Qfile_name_history):
1839 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1840 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1841 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1842 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1843 * w32proc.c (Qlocal, report_file_error):
1844 * w32term.c (Vwindow_system, updating_frame):
1845 * w32uniscribe.c (initialized, uniscribe_font_driver):
1846 Remove unneeded extern declarations.
1847
2aa46d6c
CY
18482011-03-14 Chong Yidong <cyd@stupidchicken.com>
1849
c96bbc66 1850 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1851
cffc6f3b
CY
18522011-03-13 Chong Yidong <cyd@stupidchicken.com>
1853
1854 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1855 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1856 These macros can no longer be used for assignment.
1857
44f230aa
SM
1858 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1859 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1860 (record_buffer_markers, fetch_buffer_markers): New functions for
1861 recording and fetching special buffer markers.
1862 (set_buffer_internal_1, set_buffer_temp): Use them.
1863
1864 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1865
1866 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1867
1868 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1869 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1870
1871 * xdisp.c (hscroll_window_tree):
1872 (reconsider_clip_changes): Use PT instead of BUF_PT.
1873
d251f04b
EZ
18742011-03-13 Eli Zaretskii <eliz@gnu.org>
1875
1876 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1877 $(EMACS_ROOT)/lib/intprops.h.
1878
f0c77cd1
PE
18792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1880
3eca4629
PE
1881 Fix more problems found by GCC 4.5.2's static checks.
1882
7c86ee98
PE
1883 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1884 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1885 (xg_free_frame_widgets): Make it clear that a local variable is
1886 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1887 (gdk_window_get_screen): Make it clear that this macro is needed
1888 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1889 (int_gtk_range_get_value): New function, which avoids a diagnostic
1890 from gcc -Wbad-function-cast.
1891 (xg_set_toolkit_scroll_bar_thumb): Use it.
1892 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1893 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1894 (get_utf8_string, xg_get_file_with_chooser):
1895 Rename locals to avoid shadowing.
1896 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1897
41729b81
PE
1898 * xgselect.c (xg_select): Remove unused var.
1899
f0c77cd1
PE
1900 * image.c (four_corners_best): Mark locals as initialized.
1901 (gif_load): Initialize transparent_p to zero (Bug#8238).
1902 Mark another local as initialized.
ec6cf4c6 1903 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1904
ce0ad53d 1905 * image.c (clear_image_cache): Now static.
d5d5a617 1906 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1907 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1908 (x_edge_detection): Remove unnecessary cast that
1909 gcc -Wbad-function-cast diagnoses.
2037898d 1910 (gif_load): Fix pointer signedness.
6ae141d6
PE
1911 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1912 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1913
33383987 19142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1915
d32df629
PE
1916 Improve quality of tests for time stamp overflow.
1917 For example, without this patch (encode-time 0 0 0 1 1
1918 1152921504606846976) returns the obviously-bogus value (-948597
1919 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1920 reports time overflow. See
1921 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1922 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1923 * editfns.c: Include limits.h and intprops.h.
1924 (TIME_T_MIN, TIME_T_MAX): New macros.
1925 (time_overflow): Move earlier, to before first use.
1926 (hi_time, lo_time): New functions, for an accurate test for
1927 out-of-range times.
1928 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1929 (Fget_internal_run_time): Don't assume time_t fits in int.
1930 (make_time): Use list2 instead of Fcons twice.
1931 (Fdecode_time): More accurate test for out-of-range times.
1932 (check_tm_member): New function.
1933 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1934 (lisp_time_argument): Don't rely on undefined left-shift and
1935 right-shift behavior when checking for time stamp overflow.
8be6f318 1936
fe31d94c
PE
1937 * editfns.c (time_overflow): New function, refactoring common code.
1938 (Fformat_time_string, Fdecode_time, Fencode_time):
1939 (Fcurrent_time_string): Use it.
1940
8be6f318
PE
1941 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1942 * dired.c (make_time): Move to ...
1943 * editfns.c (make_time): ... here.
1944 * systime.h: Note the move.
1945
09d9db2c 19462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1947
126bc0dc
YM
1948 * fringe.c (update_window_fringes): Remove unused variables.
1949
c47cbdfd
YM
1950 * unexmacosx.c (copy_data_segment): Also copy __got section.
1951 (Bug#8223)
1952
7ac80be9
EZ
19532011-03-12 Eli Zaretskii <eliz@gnu.org>
1954
c96bbc66 1955 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1956 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1957 Constify `char *' arguments and their references according to
1958 prototypes in tparam.h.
1959
ecb0f94d 1960 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1961
7ac80be9
EZ
1962 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1963 Adapt all references accordingly.
1964
1965 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1966
ef1fd07e
TT
19672011-03-11 Tom Tromey <tromey@redhat.com>
1968
1969 * buffer.c (syms_of_buffer): Remove obsolete comment.
1970
7ef4b50c
EZ
19712011-03-11 Eli Zaretskii <eliz@gnu.org>
1972
1973 * termhooks.h (encode_terminal_code): Declare prototype.
1974
1975 * msdos.c (encode_terminal_code): Don't declare prototype.
1976
1977 * term.c (encode_terminal_code): Now external again, used by
1978 w32console.c and msdos.c.
1979
44f230aa
SM
1980 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1981 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1982
4b1ec863 19832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1984
1714f52b 1985 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1986
4b1ec863
PE
1987 * fringe.c (update_window_fringes): Mark locals as initialized
1988 (Bug#8227).
1989 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1990
524c7aa6
PE
1991 * alloc.c (mark_fringe_data): Move decl from here ...
1992 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1993 to check its interface.
1994 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1995
a5c0af81 1996 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1997 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1998 (fontset_font): Mark local as initialized.
a9a06e0b 1999 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2000
b4716021
PE
2001 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2002
811e9bac 2003 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2004 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2005 (x_own_selection, Fx_disown_selection_internal): Rename locals
2006 to avoid shadowing.
2007 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2008
7e3ab302
PE
2009 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2010 so that the caller can use some name other than gcpro1.
2011 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2012 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2013 (Fx_backspace_delete_keys_p):
2014 Use them to avoid shadowing, and rename vars to avoid shadowing.
2015 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2016 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2017 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2018 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2019 Remove unused locals.
7e3ab302
PE
2020 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2021 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2022 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2023 macros.
f78faa98 2024
e2b13473
PE
2025 * xterm.h (x_mouse_leave): New decl.
2026
77f23912
PE
2027 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2028 Remove unused functions.
cdf4ba58
PE
2029 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2030 (x_calc_absolute_position): Now static.
7411c686 2031 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2032 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2033 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2034 unless they are used.
38d0b34a
PE
2035 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2036 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2037 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2038 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2039 (x_error_catcher, x_connection_closed, x_error_handler):
2040 (x_error_quitter, xembed_send_message, x_iconify_frame):
2041 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2042 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2043 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2044
44f230aa
SM
2045 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2046 Rename or move locals to avoid shadowing.
6b463e58 2047 (tty_defined_color, merge_face_heights): Now static.
5967d051 2048 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2049 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2050 does not deduce is never used uninitialized.
73719eba
PE
2051 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2052 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2053
426994c3 2054 * terminal.c (store_terminal_param): Now static.
5489860b 2055
032f1620 2056 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2057 (set_frame_menubar): Remove unused local.
d4323972 2058 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2059 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2060 since they might point to immutable storage.
281585b0
PE
2061 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2062 since it's unused otherwise.
032f1620 2063
367c19e5 2064 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2065 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2066 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2067 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2068 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2069 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2070 does not deduce are never used uninitialized.
70739cbe 2071
07b48fa9
PE
2072 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2073
8868a238 2074 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2075 * window.c (window_loop, size_window):
2076 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2077
7e5cf297 2078 * window.c (display_buffer): Now static.
d6550a9f
PE
2079 (size_window): Mark variables that gcc -Wuninitialized
2080 does not deduce are never used uninitialized.
a586633d
PE
2081 * window.h (check_all_windows): New decl, to forestall
2082 gcc -Wmissing-prototypes diagnostic.
5b555da1 2083 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2084
f6095868
PE
2085 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2086 shadowing.
2087 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2088 Include <limits.h>.
2089 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2090 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2091 (load_charset_map): Mark variables that gcc -Wuninitialized
2092 does not deduce are never used uninitialized.
53df7c11 2093 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2094
f38b440c
PE
2095 * coding.c (coding_set_source, coding_set_destination):
2096 Use "else { /* comment */ }" rather than "else /* comment */;"
2097 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2098 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2099 a block, when the outer 'i' will do.
2100 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2101 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2102 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2103 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2104 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2105 Rename locals to avoid shadowing.
2106 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2107 * coding.c (emacs_mule_char, encode_invocation_designation):
2108 Now static, since they're not used elsewhere.
413bb2db 2109 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2110 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2111 (decode_coding_emacs_mule): Mark variables that gcc
2112 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2113 (detect_coding_iso_2022): Initialize a local variable that might
2114 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2115 this initialization is needed. (Bug#8211)
5f58e762
PE
2116 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2117 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2118 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2119 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2120 Remove unused macros.
f38b440c 2121
232b38b9 2122 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2123 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2124 * character.c (string_count_byte8): Likewise.
232b38b9 2125
fb90da1b
PE
2126 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2127 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2128
fb93dbc2
PE
2129 * chartab.c (copy_sub_char_table): Now static, since it's not used
2130 elsewhere.
5c156ace
PE
2131 (sub_char_table_ref_and_range, char_table_ref_and_range):
2132 Rename locals to avoid shadowing.
bbcd0949 2133 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2134
7d3b3862 2135 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2136 (BIDI_BOB): Remove unused macro.
7d3b3862 2137
6be7d3da
PE
2138 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2139 deduce are never used uninitialized.
c2ed9c8b 2140 * term.c (encode_terminal_code): Likewise.
6be7d3da 2141
75f8807f 2142 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2143
50938595
PE
2144 * tparam.h: New file.
2145 * term.c, tparam.h: Include it.
2146 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2147 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2148 Move these decls to tparam.h, and make them agree with what
2149 is actually in tparam.c. The previous trick of using incompatible
2150 decls in different modules does not conform to the C standard.
2151 All callers of tparam changed to use tparam's actual API.
2152 * tparam.c (tparam1, tparam, tgoto):
2153 Use const pointers where appropriate.
2154
fbceeba2
PE
2155 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2156 * cm.h (struct cm): Likewise.
2157 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2158 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2159 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2160 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2161 (turn_on_face, init_tty): Likewise.
2162 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2163
7f3f1250
PE
2164 * term.c (term_mouse_position): Rename local to avoid shadowing.
2165
e6ca6543
PE
2166 * alloc.c (mark_ttys): Move decl from here ...
2167 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2168
c40f8d15
AS
21692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2170
2171 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2172
cfe0661d
JB
21732011-03-09 Juanma Barranquero <lekktu@gmail.com>
2174
2175 * search.c (compile_pattern_1): Remove argument regp, unused since
2176 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2177 (compile_pattern): Don't pass it.
2178
0afb4571
J
21792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2180
2181 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2182 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2183 for ! HAVE_GTK3.
2184 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2185
2186 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2187
2188 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2189 gdk_window_get_screen, gdk_window_get_geometry,
2190 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2191 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2192 (xg_get_pixbuf_from_pixmap): New function.
2193 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2194 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2195 Call xg_get_pixbuf_from_pixmap instead of
2196 gdk_pixbuf_get_from_drawable.
2197 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2198 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2199 (xg_check_special_colors): Use GtkStyleContext and its functions
2200 for HAVE_GTK3.
2201 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2202 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2203 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2204 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2205 Call gtk_widget_get_preferred_size.
0afb4571
J
2206 (xg_frame_resized): gdk_window_get_geometry only takes 5
2207 parameters.
44f230aa
SM
2208 (xg_win_to_widget, xg_event_is_for_menubar):
2209 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2210 (xg_set_widget_bg): New function.
2211 (delete_cb): New function.
2212 (xg_create_frame_widgets): connect delete-event to delete_cb.
2213 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2214 (xg_set_background_color): Call xg_set_widget_bg.
2215 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2216 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2217 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2218 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2219 if ! HAVE_GTK3.
2220 (update_frame_tool_bar): Call gtk_widget_hide.
2221 (xg_initialize): Use GDK_KEY_g.
2222
2223 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2224 if ! HAVE_GTK3
2225 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2226
2227 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2228 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2229 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2230
1c2cc4ef
JB
22312011-03-08 Juanma Barranquero <lekktu@gmail.com>
2232
2233 * w32xfns.c (select_palette): Check success of RealizePalette against
2234 GDI_ERROR, not zero.
2235
33383987 2236See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2237
2238;; Local Variables:
2239;; coding: utf-8
aac0c6e3
MR
2240;; End:
2241
33383987 2242 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2243
2244 This file is part of GNU Emacs.
2245
2246 GNU Emacs is free software: you can redistribute it and/or modify
2247 it under the terms of the GNU General Public License as published by
2248 the Free Software Foundation, either version 3 of the License, or
2249 (at your option) any later version.
2250
2251 GNU Emacs is distributed in the hope that it will be useful,
2252 but WITHOUT ANY WARRANTY; without even the implied warranty of
2253 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2254 GNU General Public License for more details.
2255
2256 You should have received a copy of the GNU General Public License
2257 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.