* data.c (Fcdr, Fcar): Revert the last change, since it didn't really clarify much.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6468f31c
LMI
12011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
2fd0959d
LMI
3 * data.c (Fcdr, Fcar): Revert the last change, since it didn't
4 really clarify much.
5
49080b10
LMI
6 * search.c (Fre_search_backward): Mention `case-fold-search' in
7 all the re_search_* functions (bug#8138).
8
6468f31c
LMI
9 * keyboard.c (Fopen_dribble_file): Document when the file is
10 closed (bug#8056).
11
c965adc5
EZ
122011-07-14 Eli Zaretskii <eliz@gnu.org>
13
df9733bf
EZ
14 * bidi.c (bidi_dump_cached_states): Fix format of displaying
15 bidi_cache_idx.
16
0bb23927
EZ
17 Support bidi reordering of display and overlay strings.
18 * xdisp.c (compute_display_string_pos)
19 (compute_display_string_end): Accept additional argument STRING.
20 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
21 (reseat_to_string): Initialize bidi_it->string.s and
22 bidi_it->string.schars.
23 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
24 NULL (avoids a crash in bidi_paragraph_init). Initialize
25 itb.string.lstring.
26 (init_iterator): Call bidi_init_it only of a valid
27 buffer position was specified. Initialize paragraph_embedding to
28 L2R.
29 (reseat_to_string): Initialize the bidi iterator.
30 (display_string): If we need to ignore text properties of
31 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
32 original value of -1 will not work with bidi.)
33 (compute_display_string_pos): First arg is now struct
34 `text_pos *'; all callers changed. Support display properties on
35 Lisp strings.
36 (compute_display_string_end): Support display properties on Lisp
37 strings.
38 (init_iterator, reseat_1, reseat_to_string): Initialize the
39 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
40 when iterating on a string not from display properties).
41 (compute_display_string_pos, compute_display_string_end): Fix
42 calculation of the object to scan. Fixes an error when using
43 arrow keys.
44 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
45 base_level_stop; instead, set base_level_stop to BEGV. Fixes
46 crashes in vertical-motion.
47 (next_element_from_buffer): Improve commentary for when
48 the iterator is before prev_stop.
49 (init_iterator): Initialize bidi_p from the default value of
50 bidi-display-reordering, not from buffer-local value. Use the
51 buffer-local value only if initializing for buffer iteration.
52 (handle_invisible_prop): Support invisible properties on strings
53 that are being bidi-reordered.
54 (set_iterator_to_next): Support bidi reordering of C strings and
55 Lisp strings.
56 (next_element_from_string): Support bidi reordering of Lisp
57 strings.
58 (handle_stop_backwards): Support Lisp strings as well.
59 (display_string): Support display of R2L glyph rows. Use
60 IT_STRING_CHARPOS when displaying from a Lisp string.
61 (init_iterator): Don't initialize it->bidi_p for strings
62 here.
63 (reseat_to_string): Initialize it->bidi_p for strings here.
64 (next_element_from_string, next_element_from_c_string)
65 (next_element_from_buffer): Add xassert's for correspondence
66 between IT's object being iterated and it->bidi_it.string
67 structure.
68 (face_before_or_after_it_pos): Support bidi iteration.
69 (next_element_from_c_string): Handle the case of the first string
70 character that is not the first one in the visual order.
71 (get_visually_first_element): New function, refactored from common
72 parts of next_element_from_buffer, next_element_from_string, and
73 next_element_from_c_string.
74 (tool_bar_lines_needed, redisplay_tool_bar)
75 (display_menu_bar): Force left-to-right direction. Add a FIXME
76 comment for making that be controlled by a user option.
77 (push_it, pop_it): Save and restore the state of the
78 bidi iterator. Save and restore the bidi_p flag.
79 (pop_it): Iterate out of display property for string iteration as
80 well.
81 (iterate_out_of_display_property): Support iteration over strings.
82 (handle_single_display_spec): Set up it->bidi_it for iteration
83 over a display string, and call bidi_init_it.
84 (handle_single_display_spec, next_overlay_string)
85 (get_overlay_strings_1, push_display_prop): Set up the bidi
86 iterator for displaying display or overlay strings.
87 (forward_to_next_line_start): Don't use the shortcut if
88 bidi-iterating.
89 (back_to_previous_visible_line_start): If handle_display_prop
90 pushed the iterator stack, restore the internal state of the bidi
91 iterator by calling bidi_pop_it same number of times.
92 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
93 and we are bidi-iterating, don't decrement the iterator position;
94 instead, set the first_elt flag in the bidi iterator, to produce
95 the same effect.
96 (reseat_1): Remove redundant setting of string_from_display_prop_p.
97 (push_display_prop): xassert that we are iterating a buffer.
98 (push_it, pop_it): Save and restore paragraph_embedding member.
99 (handle_single_display_spec, next_overlay_string)
100 (get_overlay_strings_1, reseat_1, reseat_to_string)
101 (push_display_prop): Set up the `unibyte' member of bidi_it.string
102 correctly. Don't assume unibyte strings are not bidi-reordered.
103 (compute_display_string_pos)
104 (compute_display_string_end): Fix handling the case of C string.
105 (push_it, pop_it): Save and restore from_disp_prop_p.
106 (handle_single_display_spec, push_display_prop): Set the
107 from_disp_prop_p flag.
108 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
109 (pop_it): Call iterate_out_of_display_property only if we are
110 popping after iteration over a string that came from a display
111 property. Fix a typo in popping stretch info. Add an assertion
112 for verifying that the iterator position is in sync with the bidi
113 iterator.
114 (handle_single_display_spec, get_overlay_strings_1)
115 (push_display_prop): Fix initialization of paragraph direction for
116 string when that of the parent object is not yet determined.
117 (reseat_1): Call bidi_init_it to resync the bidi
118 iterator with IT's position. (Bug#7616)
119 (find_row_edges): If ROW->start.pos gives position
120 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
121 (handle_stop, back_to_previous_visible_line_start, reseat_1):
122 Reset the from_disp_prop_p flag.
123 (SAVE_IT, RESTORE_IT): New macros.
124 (pos_visible_p, face_before_or_after_it_pos)
125 (back_to_previous_visible_line_start)
126 (move_it_in_display_line_to, move_it_in_display_line)
127 (move_it_to, move_it_vertically_backward, move_it_by_lines)
128 (try_scrolling, redisplay_window, display_line): Use them when
129 saving a temporary copy of the iterator and restoring it back.
130 (back_to_previous_visible_line_start, reseat_1)
131 (init_iterator): Empty the bidi cache "stack".
132 (move_it_in_display_line_to): If iterator ended up at
133 EOL, but we never saw any buffer positions smaller than
134 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
135 motion in bidi-reordered lines.
136 (move_it_in_display_line_to): Record prev_method and prev_pos
137 immediately before the call to set_iterator_to_next. Fixes cursor
138 motion in bidi-reordered lines with stretch glyphs and strings
139 displayed in margins. (Bug#8133) (Bug#8867)
140 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
141 TO_CHARPOS.
142 (pos_visible_p): Support positions in bidi-reordered lines. Save
143 and restore bidi cache.
144
145 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
146 (bidi_paragraph_info): Delete unused struct.
147 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
148 (bidi_cache_start): New variable.
149 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
150 to zero.
151 (bidi_cache_fetch_state, bidi_cache_search)
152 (bidi_cache_find_level_change, bidi_cache_iterator_state)
153 (bidi_cache_find, bidi_peek_at_next_level)
154 (bidi_level_of_next_char, bidi_find_other_level_edge)
155 (bidi_move_to_visually_next): Compare cache index with
156 bidi_cache_start rather than with zero.
157 (bidi_fetch_char): Accept new argument STRING; all callers
158 changed. Support iteration over a string. Support strings with
159 display properties. Support unibyte strings. Fix the type of
160 `len' according to what STRING_CHAR_AND_LENGTH expects.
161 (bidi_paragraph_init, bidi_resolve_explicit_1)
162 (bidi_resolve_explicit, bidi_resolve_weak)
163 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
164 iteration over a string.
165 (bidi_set_sor_type, bidi_resolve_explicit_1)
166 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
167 can now be zero (for strings); special values 0 and -1 were
168 changed to -1 and -2, respectively.
169 (bidi_char_at_pos): New function.
170 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
171 Call it instead of FETCH_MULTIBYTE_CHAR.
172 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
173 initialized to valid values.
174 (bidi_init_it): Don't initialize charpos and bytepos with invalid
175 values.
176 (bidi_level_of_next_char): Allow the sentinel "position" to pass
177 the test for valid cached positions. Fix the logic for looking up
178 the sentinel state in the cache. GCPRO the Lisp string we are
179 iterating.
180 (bidi_push_it, bidi_pop_it): New functions.
181 (bidi_initialize): Initialize the bidi cache start stack pointer.
182 (bidi_cache_ensure_space): New function, refactored from part of
183 bidi_cache_iterator_state. Don't assume the required size is just
184 one BIDI_CACHE_CHUNK away.
185 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
186 (bidi_count_bytes, bidi_char_at_pos): New functions.
187 (bidi_cache_search): Don't assume bidi_cache_last_idx is
188 always valid if bidi_cache_idx is valid.
189 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
190 is valid if it's going to be used.
191 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
192 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
193 (bidi_cache_find_level_change, bidi_cache_ensure_space)
194 (bidi_cache_iterator_state, bidi_cache_find)
195 (bidi_find_other_level_edge, bidi_cache_start_stack): All
196 variables related to cache indices are now EMACS_INT.
197
0bb23927
EZ
198 * dispextern.h (struct bidi_string_data): New structure.
199 (struct bidi_it): New member `string'. Make flag members be 1-bit
200 fields, and put them last in the struct.
201 (compute_display_string_pos, compute_display_string_end): Update
202 prototypes.
203 (bidi_push_it, bidi_pop_it): Add prototypes.
204 (struct iterator_stack_entry): New members bidi_p,
205 paragraph_embedding, and from_disp_prop_p.
206 (struct it): Member bidi_p is now a bit field 1 bit wide.
207 (bidi_shelve_cache, bidi_unshelve_cache): Declare
208 prototypes.
209
210 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
211 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
212 and vector-like objects.
213
214 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
215 cache around display iteration.
216
217 * window.c (Fwindow_end, window_scroll_pixel_based)
218 (displayed_window_lines, Frecenter): Save and restore the bidi
219 cache around display iteration.
220
3bbd2265
LMI
2212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
222
223 * editfns.c (Fdelete_region): Clarify the use of the named
224 parameters (bug#6788).
225
adc47434
MR
2262011-07-14 Martin Rudalics <rudalics@gmx.at>
227
228 * indent.c (Fvertical_motion): Set and restore w->pointm when
229 saving and restoring the window's buffer (Bug#9006).
230
837c31f8
LMI
2312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
232
233 * editfns.c (Fstring_to_char): Clarify just what is returned
234 (bug#6576). Text by Eli Zaretskii.
235
ac389d0c
JB
2362011-07-13 Juanma Barranquero <lekktu@gmail.com>
237
238 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
239
0be0ce47
EZ
2402011-07-13 Eli Zaretskii <eliz@gnu.org>
241
242 * buffer.c (mmap_find): Fix a typo.
243
cd18e7e3
JB
2442011-07-13 Johan Bockgård <bojohan@gnu.org>
245
246 Fix execution of x selection hooks.
247 * xselect.c (Qx_lost_selection_functions)
248 (Qx_sent_selection_functions): New vars.
249 (syms_of_xselect): DEFSYM them.
250 (x_handle_selection_request): Pass Qx_sent_selection_functions
251 rather than Vx_sent_selection_functions to Frun_hook_with_args.
252 (x_handle_selection_clear,x_clear_frame_selections):
253 Pass Qx_lost_selection_functions rather than
254 Vx_lost_selection_functions to Frun_hook_with_args.
255
47ea7f44
PE
2562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
257
ac389d0c 258 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
259 The old code sometimes used this field without initializing it.
260
47ea7f44
PE
261 * alloc.c (gc_sweep): Don't read past end of array.
262 In theory, the old code could also have corrupted Emacs internals,
263 though it'd be very unlikely.
264
bc985c87
AS
2652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
266
267 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 268 argument. (Bug#4026)
bc985c87 269
0cf34688
LMI
2702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
271
b3dadd76
LMI
272 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
273 key" (bug#4257).
274
0cf34688
LMI
275 * window.c (Fset_window_start): Doc fix (bug#4199).
276 (Fset_window_hscroll): Ditto.
277
270768cd
PE
2782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
279
077e3dda 280 Fix minor new problems caught by GCC 4.6.1.
270768cd 281 * term.c (init_tty): Remove unused local.
490011a6 282 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 283 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 284 not used otherwise.
270768cd 285
b1f58454
CY
2862011-07-12 Chong Yidong <cyd@stupidchicken.com>
287
288 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
289
22b9578d
LMI
2902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
291
6e70ab07
LMI
292 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
293 are the mini-buffer and the echo area (bug#3320).
294
22b9578d
LMI
295 * term.c (init_tty): Remove support for supdup, c10 and perq
296 terminals, which are no longer supported (bug#1482).
297
8974cc9f
JB
2982011-07-10 Johan Bockgård <bojohan@gnu.org>
299
300 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
301
a560d974
JD
3022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
303
304 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
305 for non-popups (Bug#3642).
306
1dae0f0a
AS
3072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
308
268c2c36 309 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 310 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
311 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
312 * cm.c (losecursor): Likewise.
1dae0f0a
AS
313 * data.c (fmod): Likewise.
314 * dispnew.c (swap_glyphs_in_rows): Likewise.
315 * emacs.c (memory_warning_signal): Likewise.
316 * floatfns.c (float_error): Likewise.
317 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
318 (otf_open, font_otf_capability, generate_otf_features)
319 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
320 Likewise.
321 * image.c (pbm_read_file): Likewise.
322 * indent.c (string_display_width): Likewise.
323 * intervals.c (check_for_interval, search_for_interval)
324 (inc_interval_count, count_intervals, root_interval)
325 (adjust_intervals_for_insertion, make_new_interval): Likewise.
326 * lread.c (defalias): Likewise.
268c2c36 327 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
328 * regex.c (set_image_of_range_1, set_image_of_range)
329 (regex_grow_registers): Likewise.
330 * sysdep.c (strerror): Likewise.
331 * termcap.c (valid_filename_p, tprint, main): Likewise.
332 * tparam.c (main): Likewise.
333 * unexhp9k800.c (run_time_remap, save_data_space)
334 (update_file_ptrs, read_header, write_header, calculate_checksum)
335 (copy_file, copy_rest, display_header): Likewise.
336 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
337 Likewise.
338 * xdisp.c (check_it): Likewise.
339 * xfaces.c (register_color, unregister_color, unregister_colors):
340 Likewise.
341 * xfns.c (print_fontset_result): Likewise.
342 * xrdb.c (member, fatal, main): Likewise.
343
99033785
PE
3442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
345
346 Fix minor problems found by static checking (Bug#9031).
347 * chartab.c (char_table_set_range, map_sub_char_table):
348 Remove unused locals.
349 (uniprop_table): Now static.
350 * composite.c (_work_char): Remove unused static var.
351
9cb2ac56
JB
3522011-07-09 Juanma Barranquero <lekktu@gmail.com>
353
354 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
355
f25661f0
JD
3562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
357
358 * gtkutil.c (qttip_cb): Remove code without function.
359
8278c4fe
EZ
3602011-07-09 Eli Zaretskii <eliz@gnu.org>
361
362 * w32.c (pthread_sigmask): New stub.
363
1692ae2d 3642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 365
8a6ebd58 366 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
367 sigprocmask is portable only for single-threaded applications, and
368 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
369 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
370 (LIBES): Use it.
371 * callproc.c (Fcall_process):
372 * process.c (create_process):
373 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
374 Use pthread_sigmask, not sigprocmask.
123403e4 375
1b854618
JD
3762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
377
378 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
379 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
380 wrong (Bug#8591).
381
3fe4b549
JD
3822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
383
0ce7e563
JD
384 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
385 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
386 (xg_hide_tooltip): Fix comment.
387
3fe4b549
JD
388 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
389 in registerServicesMenuSendTypes.
390 (validRequestorForSendType): Don't check ns_return_types.
391
392 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
393 ns_return_type.
394
5df75e47
JR
3952011-07-08 Jason Rumney <jasonr@gnu.org>
396
397 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
398 frame struct members of non-existent frames (Bug#6284).
399
699c10bd
JD
4002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
401
4393663b
JD
402 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
403 variable firstTime not needed on OSX >= 10.6.
404 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
405 >= 10.5. Use setKnobProportion, setDoubleValue.
406
407 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
408 (MAC_OS_X_VERSION_10_5): Define if not defined.
409 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
410 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
411 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
412
413 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
414 cString and lossyCString on OSX >= 10.4
415
416 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
417 sizeToFit on OSX >= 10.2.
418
419 * nsimage.m (allocInitFromFile): Don't use deprecated method
420 bestRepresentationForDevice on OSX >= 10.6.
421
422 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
423 to avoid warning.
424
425 * emacs.c: Declare unexec_init_emacs_zone.
426
a63e0781
JD
427 * nsgui.h: Fix compiler warning about gnulib redefining verify.
428
699c10bd
JD
429 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
430
431 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
432 on svcsMenu (Bug#8842).
433
434 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
435 ns_return_types.
436 (Fns_list_services): Just return Qnil on 10.6, code not working there.
437
438 * nsterm.m (QUTF8_STRING): Declare.
439 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
440 (validRequestorForSendType): Return type is (id).
441 Change indexOfObjectIdenticalTo to indexOfObject.
442 Check if we have local selection before returning self (Bug#8842).
443 (writeSelectionToPasteboard): Put local selection into paste board
444 if we have a local selection (Bug#8842).
445 (syms_of_nsterm): DEFSYM QUTF8_STRING.
446
447 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
448 (ns_get_local_selection): Declare.
449
54e10184
LMI
4502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
451
9888ff71
LMI
452 * keymap.c (describe_map_tree): Don't insert a double newline at
453 the end of the buffer (bug#1169) and return whether we inserted
454 something.
455
54e10184
LMI
456 * callint.c (Fcall_interactively): Change "reading args" to
457 "providing args" to try to clarify what it does (bug#1010).
458
15fa4783
KH
4592011-07-07 Kenichi Handa <handa@m17n.org>
460
461 * composite.c (composition_compute_stop_pos): Ignore a static
462 composition starting before CHARPOS (Bug#8915).
463
464 * xdisp.c (handle_composition_prop): Likewise.
465
a8815b00
EZ
4662011-07-07 Eli Zaretskii <eliz@gnu.org>
467
468 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
469 (Bug#9015)
470
ef7b981d 4712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
472
473 * character.h (unicode_category_t): New enum type.
474
475 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
476 (Qchar_code_property_table): New variable.
477 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
478 (UNIPROP_COMPRESSED_FORM_P): New macros.
479 (char_table_ascii): Uncompress the compressed values.
480 (sub_char_table_ref): New arg is_uniprop. Callers changed.
481 Uncompress the compressed values.
ac389d0c 482 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
483 (char_table_ref_and_range): Uncompress the compressed values.
484 (sub_char_table_set): New arg is_uniprop. Callers changed.
485 Uncompress the compressed values.
486 (sub_char_table_set_range): Args changed. Callers changed.
487 (char_table_set_range): Adjuted for the above change.
488 (map_sub_char_table): Delete args default_val and parent. Add arg
489 top. Give decoded values to a Lisp function.
490 (map_char_table): Adjusted for the above change. Give decoded
491 values to a Lisp function. Gcpro more variables.
492 (uniprop_table_uncompress)
493 (uniprop_decode_value_run_length): New functions.
494 (uniprop_decoder, uniprop_decoder_count): New variables.
495 (uniprop_get_decoder, uniprop_encode_value_character)
496 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
497 New functions.
498 (uniprop_encoder, uniprop_encoder_count): New variables.
499 (uniprop_get_encoder, uniprop_table)
500 (Funicode_property_table_internal, Fget_unicode_property_internal)
501 (Fput_unicode_property_internal): New functions.
502 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
503 Sunicode_property_table_internal, Sget_unicode_property_internal,
504 and Sput_unicode_property_internal. Defvar_lisp
505 char-code-property-alist.
506
507 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
508 Vunicode_category_table.
509
510 * font.c (font_range): Adjusted for the change of
511 Vunicode_category_table.
512
76b397fb
DN
5132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
514
515 * m/iris4d.h: Remove file, move contents ...
516 * s/irix6-5.h: ... here.
517
22b4128e
PE
5182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
519
520 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
521 * alloc.c (mark_buffer):
522 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
523 (clone_per_buffer_values): Don't assume that
22b4128e
PE
524 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
525 This isn't true in general, and it's particularly not true
526 if Emacs is configured with --with-wide-int.
527 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
528 New macros, used in the buffer.c change.
529
869795d6
JD
5302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
531
532 * xsettings.c: Use both GConf and GSettings if both are available.
533 (store_config_changed_event): Add comment.
534 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
535 (store_tool_bar_style_changed): New functions.
536 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
537 (struct xsettings): Move font inside HAVE_XFT.
538 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
539 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
540 Move inside HAVE_XFT.
541 (something_changed_gsettingsCB): Renamed from something_changedCB.
542 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
543 also.
544 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
545 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
546 (something_changed_gconfCB): Renamed from something_changedCB.
547 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
548 (parse_settings): Move check for font inside HAVE_XFT.
549 (read_settings, apply_xft_settings): Add comment.
550 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
551 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
552 call store_font_name_changed.
553 (xft_settings_event): Add comment.
554 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
555 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
556 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
557 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
558 (xsettings_initialize): Call init_gsettings last.
559 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
560 comment.
561
d8ed26bd
PE
5622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
563
564 Random fixes. E.g., (random) never returned negative values.
565 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
566 subseconds part to the entropy, as that's a bit more random.
567 Prefer signed to unsigned, since the signedness doesn't matter and
568 in general we prefer signed. When given a limit, use a
569 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
570 latter isn't right if USE_2_TAGS_FOR_INTS.
571 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
572 not 0..VALMASK. Don't discard "excess" bits that random () returns.
573
cabf1cac
SM
5742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
575
576 * textprop.c (text_property_stickiness):
577 Obey Vtext_property_default_nonsticky.
578 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
579 * w32fns.c (syms_of_w32fns):
580 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
581
6e9b2be9
PE
5822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
583
584 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
585 This is more efficient than Ffile_directory_p and avoids a minor race.
586
90186c68
LMI
5872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
588
7c301272
LMI
589 * buffer.c (Foverlay_put): Say what the return value is
590 (bug#7835).
591
c4f2d8d4
LMI
592 * fileio.c (barf_or_query_if_file_exists): Check first if the file
593 is a directory before asking whether to use the file name
594 (bug#7564).
ad637907
LMI
595 (barf_or_query_if_file_exists): Make the "File is a directory"
596 error be more correct.
c4f2d8d4 597
90186c68
LMI
598 * fns.c (Frequire): Remove the mention of the .gz files, since
599 that's installation-specific, but keep the mention of
600 `get-load-suffixes'.
601
da64016e
PE
6022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
603
604 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
605 Report string overflow if the output is too long.
606
7d47b580
JB
6072011-07-04 Juanma Barranquero <lekktu@gmail.com>
608
a555cb87
JB
609 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
610 (syms_of_gnutls): Remove duplicate DEFSYM for
611 Qgnutls_bootprop_verify_hostname_error, an error for
612 Qgnutls_bootprop_verify_error (which is no longer used).
613
7d47b580
JB
614 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
615 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
616 Also (re)move comments that are misplaced or no longer relevant.
617
1e49bfab
LMI
6182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
619
620 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
621
1485f4c0
CY
6222011-07-03 Chong Yidong <cyd@stupidchicken.com>
623
624 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
625 and background color parameters if they have been changed.
626
a9ab721e
LMI
6272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
628
629 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
630
cf7cff57
PE
6312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
632
2e13213d
PE
633 * xsettings.c (SYSTEM_FONT): Define only when used.
634 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
635
cf7cff57
PE
636 * keymap.c (access_keymap_1): Now static.
637
7a8e04f7
CY
6382011-07-02 Chong Yidong <cyd@stupidchicken.com>
639
640 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
641 leave any prefix arg for the up event (Bug#1586).
642
61352f62
LMI
6432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
644
69bb1ef7
LMI
645 * lread.c (syms_of_lread): Mention single symbols defined by
646 `defvar' or `defconst' (bug#7154).
647
61352f62 648 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 649 (Frequire): Mention get-load-suffixes.
61352f62 650
28545e04
MR
6512011-07-02 Martin Rudalics <rudalics@gmx.at>
652
653 * window.h (window): Remove clone_number slot.
654 * window.c (Fwindow_clone_number, Fset_window_clone_number):
655 Remove.
656 (make_parent_window, make_window, saved_window)
657 (Fset_window_configuration, save_window_save): Don't deal with
658 clone numbers.
659 * buffer.c (Qclone_number): Remove declaration.
660 (sort_overlays, overlay_strings): Don't deal with clone numbers.
661
3349e122
SM
6622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
663
664 Add multiple inheritance to keymaps.
665 * keymap.c (Fmake_composed_keymap): New function.
666 (Fset_keymap_parent): Simplify.
667 (fix_submap_inheritance): Remove.
668 (access_keymap_1): New function extracted from access_keymap to handle
669 embedded parents and handle lists of maps.
670 (access_keymap): Use it.
671 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
672 (Fcopy_keymap): Handle embedded parents.
673 (Fcommand_remapping, define_as_prefix): Simplify.
674 (Fkey_binding): Simplify.
675 (syms_of_keymap): Move minibuffer-local-completion-map,
676 minibuffer-local-filename-completion-map,
677 minibuffer-local-must-match-map, and
678 minibuffer-local-filename-must-match-map to Elisp.
679 (syms_of_keymap): Defsubr make-composed-keymap.
680 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
681 (parse_menu_item): Trivial simplification.
682
3279eb87
GM
6832011-07-01 Glenn Morris <rgm@gnu.org>
684
685 * Makefile.in (SETTINGS_LIBS): Fix typo.
686
4550efdf
KI
6872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
688
689 * coding.c (Fencode_coding_string): Record the last coding system
690 used, as the function doc string says (bug#8738).
691
0949d2b6
JD
6922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
693
694 * xsettings.c (store_monospaced_changed): Take new font as arg and
695 check for change against current_mono_font.
696 (EMACS_TYPE_SETTINGS): Remove this and related defines.
697 (emacs_settings_constructor, emacs_settings_get_property)
698 (emacs_settings_set_property, emacs_settings_class_init)
699 (emacs_settings_init, gsettings_obj): Remove.
700 (something_changedCB): New function for HAVE_GSETTINGS.
701 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
702 with value as argument.
703 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
704 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 705 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
706 "changed".
707
708 * xgselect.c: Add defined (HAVE_GSETTINGS).
709 (xgselect_initialize): Ditto.
710
711 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
712 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
713 xg_select.
714
bbc6b304
PE
7152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
716
717 * eval.c (struct backtrace): Simplify and port the data structure.
718 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
719 signed bit field, as this assumption is not portable and it makes
720 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
721 "char debug_on_exit : 1" as this is not portable either; instead,
722 use the portable "unsigned int debug_on_exit : 1". Remove unused
723 member evalargs. Remove obsolete comments about cc bombing out.
724
9851bfc5
JD
7252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
726
51bb811f 727 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
728 Let HAVE_GSETTINGS override HAVE_GCONF.
729 (store_monospaced_changed): New function.
730 (EMACS_SETTINGS): A new type derived from GObject to handle
731 GSettings notifications.
732 (emacs_settings_constructor, emacs_settings_get_property)
733 (emacs_settings_set_property, emacs_settings_class_init):
734 New functions.
735 (gsettings_client, gsettings_obj): New variables.
736 (GSETTINGS_SCHEMA): New define.
737 (something_changedCB): Call store_monospaced_changed.
738 (init_gsettings): New function.
739 (xsettings_initialize): Call init_gsettings.
740 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
741 to NULL.
742
743 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
744 GCONF_CFLAGS/LIBS.
745
5386012d
MR
7462011-06-29 Martin Rudalics <rudalics@gmx.at>
747
748 * window.c (resize_root_window, grow_mini_window)
749 (shrink_mini_window): Rename Qresize_root_window to
750 Qwindow_resize_root_window and Qresize_root_window_vertically to
751 Qwindow_resize_root_window_vertically.
752
f13e0b08
PE
7532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
754
755 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
756
94515237
JB
7572011-06-27 Juanma Barranquero <lekktu@gmail.com>
758
759 * makefile.w32-in: Redesign dependencies so they reflect more
760 clearly which files are directly included by each source file,
761 and not through other includes.
762
e43b6e43
MR
7632011-06-27 Martin Rudalics <rudalics@gmx.at>
764
765 * buffer.c (Qclone_number): Declare static and DEFSYM it.
766 (sort_overlays, overlay_strings): When an overlay's clone number
767 matches the window's clone number process the overlay even if
768 the overlay's window property doesn't match the current window.
769
d68443dc
MR
770 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
771 (Fwindow_hchild): Rename to Fwindow_left_child.
772 (Fwindow_next): Rename to Fwindow_next_sibling.
773 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
774 (resize_window_check): Rename to window_resize_check.
775 (resize_window_apply): Rename to window_resize_apply.
776 (Fresize_window_apply): Rename to Fwindow_resize_apply.
777 (Fdelete_other_windows_internal, resize_frame_windows)
778 (Fsplit_window_internal, Fdelete_window_internal)
779 (grow_mini_window, shrink_mini_window)
780 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 781
c7e73be5
JD
7822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
783
784 * emacsgtkfixed.h: State that this is only used with Gtk+3.
785 (emacs_fixed_set_min_size): Remove.
786 (emacs_fixed_new): Take frame as argument.
787
788 * emacsgtkfixed.c: State that this is only used with Gtk+3.
789 (_EmacsFixedPrivate): Remove minwidth/height.
790 Add struct frame *f.
791 (emacs_fixed_init): Initialize priv->f.
792 (get_parent_class, emacs_fixed_set_min_size): Remove.
793 (emacs_fixed_new): Set priv->f to argument.
794 (emacs_fixed_get_preferred_width)
795 (emacs_fixed_get_preferred_height): Use min_width/height from
796 frames size_hint to set minimum and natural (Bug#8919).
797 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
798 and use min_width/height from frames size_hint to set
799 min_width/height (Bug#8919).
800
801 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
802 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
803 Fix indentation.
c7e73be5 804
cf99dcf8
EZ
8052011-06-26 Eli Zaretskii <eliz@gnu.org>
806
807 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
808 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
809 called at ZV.
810
029529ac
CY
8112011-06-26 Chong Yidong <cyd@stupidchicken.com>
812
813 * process.c (wait_reading_process_output): Bypass select if
814 waiting for a cell while ignoring keyboard input, and input is
815 pending. Suggested by Jan Djärv (Bug#8869).
816
7a7ef429
PE
8172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
818
819 Use gnulib's dup2 module instead of rolling our own.
820 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
821
11fdef7d 8222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
823
824 * dispnew.c (scrolling_window): Before scrolling, turn off a
825 mouse-highlight in the window being scrolled.
826
cd3520a4
JB
8272011-06-24 Juanma Barranquero <lekktu@gmail.com>
828
829 Move DEFSYM to lisp.h and use everywhere.
830
831 * character.h (DEFSYM): Move declaration...
832 * lisp.h (DEFSYM): ...here.
833
834 * gnutls.c:
835 * minibuf.c:
836 * w32menu.c:
837 * w32proc.c:
838 * w32select.c: Don't include character.h.
839
840 * alloc.c (syms_of_alloc):
841 * buffer.c (syms_of_buffer):
842 * bytecode.c (syms_of_bytecode):
843 * callint.c (syms_of_callint):
844 * casefiddle.c (syms_of_casefiddle):
845 * casetab.c (init_casetab_once):
846 * category.c (init_category_once, syms_of_category):
847 * ccl.c (syms_of_ccl):
848 * cmds.c (syms_of_cmds):
849 * composite.c (syms_of_composite):
850 * dbusbind.c (syms_of_dbusbind):
851 * dired.c (syms_of_dired):
852 * dispnew.c (syms_of_display):
853 * doc.c (syms_of_doc):
854 * editfns.c (syms_of_editfns):
855 * emacs.c (syms_of_emacs):
856 * eval.c (syms_of_eval):
857 * fileio.c (syms_of_fileio):
858 * fns.c (syms_of_fns):
859 * frame.c (syms_of_frame):
860 * fringe.c (syms_of_fringe):
861 * insdel.c (syms_of_insdel):
862 * keymap.c (syms_of_keymap):
863 * lread.c (init_obarray, syms_of_lread):
864 * macros.c (syms_of_macros):
865 * msdos.c (syms_of_msdos):
866 * print.c (syms_of_print):
867 * process.c (syms_of_process):
868 * search.c (syms_of_search):
869 * sound.c (syms_of_sound):
870 * syntax.c (init_syntax_once, syms_of_syntax):
871 * terminal.c (syms_of_terminal):
872 * textprop.c (syms_of_textprop):
873 * undo.c (syms_of_undo):
874 * w32.c (globals_of_w32):
875 * window.c (syms_of_window):
876 * xdisp.c (syms_of_xdisp):
877 * xfaces.c (syms_of_xfaces):
878 * xfns.c (syms_of_xfns):
879 * xmenu.c (syms_of_xmenu):
880 * xsettings.c (syms_of_xsettings):
881 * xterm.c (syms_of_xterm): Use DEFSYM.
882
4228cf16
TZ
8832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
884
cd3520a4 885 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 886
7fcccf1e
PE
8872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
888
7efb4e0e
PE
889 Integer and buffer overflow fixes (Bug#8873).
890
ff5844ad
PE
891 * print.c (printchar, strout): Check for string overflow.
892 (PRINTPREPARE, printchar, strout):
893 Don't set size unless allocation succeeds.
894
90532f02
PE
895 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
896 for sizes. Check for string overflow more accurately.
897 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
898
6d84508d
PE
899 * macros.c: Integer and buffer overflow fixes.
900 * keyboard.h (struct keyboard.kbd_macro_bufsize):
901 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
902 Use ptrdiff_t, not int, for sizes.
903 Don't increment bufsize until after realloc succeeds.
904 Check for size-calculation overflow.
905 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
906
437b2cb4
PE
907 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
908
8b9ac8b4
PE
909 * lread.c: Integer overflow fixes.
910 (read_integer): Radix is now EMACS_INT, not int,
911 to improve quality of diagnostics for out-of-range radices.
912 Calculate buffer size correctly for out-of-range radices.
913 (read1): Check for integer overflow in radices, and in
914 read-circle numbers.
82cb60d3
PE
915 (read_escape): Avoid int overflow.
916 (Fload, openp, read_buffer_size, read1)
917 (substitute_object_recurse, read_vector, read_list, map_obarray):
918 Use ptrdiff_t, not int, for sizes.
919 (read1): Use EMACS_INT, not int, for sizes.
20270765 920 Check for size overflow.
8b9ac8b4 921
7fcccf1e
PE
922 * image.c (cache_image): Check for size arithmetic overflow.
923
bfbbd7e7
PE
924 * lread.c: Integer overflow issues.
925 (saved_doc_string_size, saved_doc_string_length)
926 (prev_saved_doc_string_size, prev_saved_doc_string_length):
927 Now ptrdiff_t, not int.
928 (read1): Don't assume doc string length fits in int. Check for
929 out-of-range doc string lengths.
930 (read_list): Don't assume file position fits in int.
39019e54 931 (read_escape): Check for hex character overflow.
bfbbd7e7 932
4e323265
LL
9332011-06-22 Leo Liu <sdl.web@gmail.com>
934
935 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
936 Move to minibuffer.el.
937
85fece3e
PE
9382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
939
20b84ce9 940 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
941 The following patches are for when GLYPH_DEBUG && !XASSERT.
942 * dispextern.h (trace_redisplay_p, dump_glyph_string):
943 * dispnew.c (flush_stdout):
944 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
945 Mark as externally visible.
946 * dispnew.c (check_window_matrix_pointers): Now static.
947 * dispnew.c (window_to_frame_vpos):
948 * xfns.c (unwind_create_frame):
949 * xterm.c (x_check_font): Remove unused local.
950 * scroll.c (CHECK_BOUNDS):
951 * xfaces.c (cache_fache): Rename local to avoid shadowing.
952 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
953 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
954 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
955 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
956 Now static.
957 (debug_method_add): Use va_list and vsprintf rather than relying
958 on undefined behavior with wrong number of arguments.
959 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
960 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
961 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
962 since we're not interested in debugging glyphs with old libraries.
963 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
964 GCC 4.6.0's static checking.
965
0766b489
PE
9662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
967
31fd4b32
PE
968 Integer overflow and signedness fixes (Bug#8873).
969 A few related buffer overrun fixes, too.
970
b79e8648
PE
971 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
972
0766b489
PE
973 * dispextern.h (struct face.stipple):
974 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
975 (x_bitmap_mask, x_allocate_bitmap_record)
976 (x_create_bitmap_from_data, x_create_bitmap_from_file)
977 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
978 (x_create_bitmap_from_xpm_data):
979 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
980 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
981 (.bitmaps_last):
982 * xfaces.c (load_pixmap):
983 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
984 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
985 (.bitmaps_last, struct x_output.icon_bitmap):
986 Use ptrdiff_t, not int, for bitmap indexes.
987 (x_allocate_bitmap_record): Check for size overflow.
988 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
989
b081724f
PE
990 Use ptrdiff_t, not int, for overlay counts.
991 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
992 * editfns.c (overlays_around, get_pos_property):
993 * textprop.c (get_char_property_and_overlay):
994 * xdisp.c (next_overlay_change, note_mouse_highlight):
995 * xfaces.c (face_at_buffer_position):
21514da7
PE
996 * buffer.c (OVERLAY_COUNT_MAX): New macro.
997 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
998 (Fnext_overlay_change, Fprevious_overlay_change)
999 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1000 Use ptrdiff_t, not int, for sizes.
21514da7 1001 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1002
3de73e5e
PE
1003 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1004
2606c57b
PE
1005 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1006 (x_session_initialize): Do not assume string length fits in int.
1007
aaafe47a
PE
1008 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1009 This is unlikely, but can occur if DPI is outlandish.
1010
2674ddc8 1011 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1012 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1013
28154962
PE
1014 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1015 * xrdb.c (magic_file_p, search_magic_path):
1016 Omit last arg SUFFIX; it was always 0. All callers changed.
1017 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1018
7de51af5
PE
1019 * xfont.c (xfont_match): Avoid need for strlen.
1020
25ed6cc3
PE
1021 * xfns.c: Don't assume strlen fits in int.
1022 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1023
4eab31dd
PE
1024 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1025 not unsigned long, as we prefer signed integers. All callers changed.
1026 Detect integer overflow in repeat count.
1027 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1028 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1029
171e2a58
PE
1030 * termcap.c: Don't assume sizes fit in int and never overflow.
1031 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1032 (gobble_line): Check for size-calculation overflow.
1033
ad39faca 1034 * minibuf.c (Fread_buffer):
6e5bb2dc 1035 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1036 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1037 Don't assume string length fits in int.
1038
52c61c22 1039 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1040 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1041
b5b8c9e5
PE
1042 * font.c: Don't assume string length fits in int.
1043 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1044 Use ptrdiff_t, not int.
ccd6111c
PE
1045 (font_intern_prop): Don't assume string length fits in int.
1046 Don't assume integer property fits in fixnum.
1047 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1048
882f0d81 1049 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1050 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1051 Reformulate so as not to need the command string.
1052 Invoke gzip -cd rather than gunzip, as it's more portable.
1053 (lock_info_type, lock_file_1, lock_file):
1054 Don't assume pid_t and time_t fit in unsigned long.
1055 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1056 (current_lock_owner): Prefer signed type for sizes.
1057 Use memcpy, not strncpy, where memcpy is what is really wanted.
1058 Don't assume (via atoi) that time_t and pid_t fit in int.
1059 Check for time_t and/or pid_t out of range, e.g., via a network share.
1060 Don't alloca where an auto var works fine.
1061
93f4cf88
PE
1062 * fileio.c: Fix some integer overflow issues.
1063 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1064 Don't assume string length fits in int.
1065 (directory_file_name): Don't assume string length fits in long.
1066 (make_temp_name): Don't assume pid fits in int, or that its print
1067 length is less than 20.
1068
f3e92b69
PE
1069 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1070
1bfdaf10
PE
1071 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1072
35016e9a
PE
1073 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1074
3d1e65a1
PE
1075 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1076 We prefer signed integers, even for size calculations.
1077
0b963a93
PE
1078 * emacs.c: Don't assume string length fits in 'int'.
1079 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1080 (main): Don't invoke strlen when not needed.
1081
573f4b54
PE
1082 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1083 (XD_DEBUG_MESSAGE): Don't waste a byte.
1084
989f33ba
PE
1085 * callproc.c (getenv_internal_1, getenv_internal)
1086 (Fgetenv_internal):
965d34eb
PE
1087 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1088
e4d29b33
PE
1089 * lread.c (invalid_syntax): Omit length argument.
1090 All uses changed. This doesn't fix a bug, but it simplifies the
1091 code away from its former Hollerith-constant appearance, and it's
1092 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1093 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1094
eb49b136
PE
1095 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1096 This didn't break anything, but it didn't help either.
1097 It's confusing to put a bogus integer in a place where the actual
1098 value does not matter.
9f62aeb1 1099 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1100 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1101
15375a22
PE
1102 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1103 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1104 implementation.
b61cc01c
PE
1105 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1106 We prefer signed types, and the value cannot exceed the EMACS_INT
1107 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1108 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1109 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1110 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1111
53b2623d
PE
1112 * indent.c (sane_tab_width): New function.
1113 (current_column, scan_for_column, Findent_to, position_indentation)
1114 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1115 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1116
51cab52b 1117 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1118
f2ed8a70
PE
1119 * lisp.h (lint_assume): New macro.
1120 * composite.c (composition_gstring_put_cache):
1121 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1122
abe80cc6
PE
1123 * editfns.c, insdel.c:
1124 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1125
b02c740e
PE
1126 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1127
ebc96716
PE
1128 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1129
b4e50fa0 1130 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1131 Use much-faster test for byte-length change.
311d5d7c 1132 Don't assume string byte-length fits in 'int'.
a4cf38e4 1133 Check that character arg fits in 'int'.
85461888 1134 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1135
c0c1ee9f
PE
1136 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1137
a498d7f4
PE
1138 * fns.c (concat): Catch string overflow earlier.
1139 Do not rely on integer wraparound.
1140
51cab52b
PE
1141 * dispextern.h (struct it.overlay_strings_charpos)
1142 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1143 * xdisp.c (forward_to_next_line_start)
1144 (back_to_previous_visible_line_start)
1145 (reseat_at_next_visible_line_start, next_element_from_buffer):
1146 Don't arbitrarily truncate the value of 'selective' to int.
1147
76031fad
PE
1148 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1149
5eb55db9
PE
1150 * composite.c: Don't truncate sizes to 'int'.
1151 (composition_gstring_p, composition_reseat_it)
1152 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1153 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1154 not EMACS_UINT, for indexes.
5eb55db9 1155
0703a717
PE
1156 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1157
d6202519
PE
1158 * buffer.c: Include <verify.h>.
1159 (struct sortvec.priority, struct sortstr.priority):
8961a454 1160 Now EMACS_INT, not int.
c20998a7 1161 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1162 (struct sortstr.size, record_overlay_string)
1163 (struct sortstrlist.size, struct sortlist.used):
1164 Don't truncate size to int.
1165 (record_overlay_string): Check for size-calculation overflow.
d6202519 1166 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1167
d5a19415
JM
11682011-06-22 Jim Meyering <meyering@redhat.com>
1169
029529ac 1170 Don't leak an XBM-image-sized buffer
d5a19415
JM
1171 * image.c (xbm_load): Free the image buffer after using it.
1172
a9041e6c
PE
11732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 Port to Sun C.
1176 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1177 that Sun C diagnosed.
1178 * fns.c (secure_hash): Fix pointer signedness issue.
1179 * intervals.c (static_offset_intervals): New function.
1180 (offset_intervals): Use it.
1181
7f3f739f
LL
11822011-06-21 Leo Liu <sdl.web@gmail.com>
1183
1184 * deps.mk (fns.o):
1185 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1186 sha512.h.
1187
1188 * fns.c (secure_hash): Rename from crypto_hash_function and change
1189 the first arg to accept symbols.
5b66d427 1190 (Fsecure_hash): New primitive.
7f3f739f
LL
1191 (syms_of_fns): New symbols.
1192
76147d94
DD
11932011-06-20 Deniz Dogan <deniz@dogan.se>
1194
1195 * process.c (Fset_process_buffer): Clarify return value in
1196 docstring.
1197
7d7d0045
CY
11982011-06-18 Chong Yidong <cyd@stupidchicken.com>
1199
1200 * dispnew.c (add_window_display_history): Use BVAR.
1201
1202 * xdisp.c (debug_method_add): Use BVAR.
1203 (check_window_end, dump_glyph_matrix, dump_glyph)
1204 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1205
1206 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1207 Likewise.
1208
1209 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1210 check till after the cache is created in init_frame_faces.
1211
ff2bc410
SM
12122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1213
1214 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1215
28177add
PE
12162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1217
dd3482fe
PE
1218 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1219 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1220 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1221
393d71f3 1222 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1223 * fileio.c (Finsert_file_contents):
1224 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1225 Remove the old (too-loose) buffer overflow checks.
1226 They weren't needed, since make_gap checks for buffer overflow.
1227 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1228 The old code merely checked for Emacs fixnum overflow, and relied
1229 on undefined (wraparound) behavior. The new code avoids undefined
1230 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1231
2e6813b0 1232 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1233 Tune. Don't use wider integers than needed. Don't use alloca.
1234 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1235
599a9e4f
PE
1236 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1237
99561444
PE
1238 * insdel.c, lisp.h (buffer_overflow): New function.
1239 (insert_from_buffer_1, replace_range, replace_range_2):
1240 * insdel.c (make_gap_larger):
1241 * editfns.c (Finsert_char):
1242 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1243
28177add
PE
1244 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1245
e69dafad
PE
12462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1247
a7af7fde 1248 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1249
b1c46f02
PE
1250 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1251 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1252
e69dafad
PE
1253 * fileio.c: Don't assume EMACS_INT fits in off_t.
1254 (emacs_lseek): New static function.
1255 (Finsert_file_contents, Fwrite_region): Use it.
1256 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1257
566684ea
PE
1258 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1259
e6966cd6
PE
1260 * fns.c: Don't overflow int when computing a list length.
1261 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1262 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1263 truncation on 64-bit hosts. Check for QUIT every
1264 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1265 faster and is responsive enough.
1266 (Flength): Report an error instead of overflowing an integer.
1267 (Fsafe_length): Return a float if the value is not representable
1268 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1269 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1270 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1271
dd0b0efb
PE
1272 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1273 (header_size, word_size): New constants.
1274 (allocate_vectorlike): Don't check size overflow here.
1275 (allocate_vector): Check it here instead, since this is the only
1276 caller of allocate_vectorlike that could cause overflow.
1277 Check that the new vector's length is representable as a fixnum.
1278
86fe5cfe
PE
1279 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1280 The previous code was bogus. For example, next_almost_prime (32)
1281 returned 39, which is undesirable as it is a multiple of 3; and
1282 next_almost_prime (24) returned 25, which is a multiple of 5 so
1283 why was the code bothering to check for multiples of 7?
1284
80e88859
PE
1285 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1286
4a2f0ad6
PE
1287 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1288
f66c7cf8
PE
1289 Variadic C functions now count arguments with ptrdiff_t.
1290 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1291 Back then I didn't know that the Emacs coding style prefers signed int.
1292 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1293 were being counted with int, which may truncate counts on 64-bit
1294 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1295 * lisp.h (struct Lisp_Subr.function.aMANY)
1296 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1297 Arg counts are now ptrdiff_t, not size_t.
1298 All variadic functions and their callers changed accordingly.
1299 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1300 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1301 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1302 * callint.c (Fcall_interactively): Check arg count for overflow,
1303 to avoid potential buffer overrun. Use signed char, not 'int',
1304 for 'varies' array, so that we needn't bother to check its size
1305 calculation for overflow.
1306 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1307 * eval.c (apply_lambda):
1308 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1309 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1310 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1311
a1759b76
PE
1312 * callint.c (Fcall_interactively): Don't use index var as event count.
1313
d96be9fc
PE
1314 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1315 * mem-limits.h (SIZE): Remove; no longer used.
1316
a690a978 1317 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1318
578c21e6
PE
1319 Remove unnecessary casts.
1320 * xterm.c (x_term_init):
1321 * xfns.c (x_set_border_pixel):
1322 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1323 These aren't needed now that we assume ANSI C.
1324
96f53c6c
PE
1325 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1326 It's more likely to cause problems (due to unsigned overflow)
1327 than to cure them.
1328
83c77d31
PE
1329 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1330
ee2079f1
PE
1331 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1332
6da65536
PE
1333 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1334
7147c4a4
PE
1335 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1336
193e32d9
PE
1337 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1338
e5533da6
PE
1339 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1340
9910e595
PE
1341 GLYPH_CODE_FACE returns EMACS_INT, not int.
1342 * dispextern.h (merge_faces):
1343 * xfaces.c (merge_faces):
01103c44
PE
1344 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1345 Don't assume EMACS_INT fits in int.
9910e595 1346
2638320e
PE
1347 * character.h (CHAR_VALID_P): Remove unused parameter.
1348 * fontset.c, lisp.h, xdisp.c: All uses changed.
1349
045eb8d9
PE
1350 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1351
c1f134b5
PE
1352 * fns.c (concat): Minor tuning based on overflow analysis.
1353 This doesn't fix any bugs. Use int to hold character, instead
1354 of constantly refetching from Emacs object. Use XFASTINT, not
1355 XINT, for value known to be a character. Don't bother comparing
1356 a single byte to 0400, as it's always less.
1357
395fcb93 1358 * floatfns.c (Fexpt):
327eeec8
PE
1359 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1360
abbd3d23
PE
1361 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1362 for characters.
1363
684a03ef
PE
1364 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1365
0fed43f3
PE
1366 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1367 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1368 incorrectly succeed when S was a string, because 4294967386 was
1369 truncated before it was used.
1370
8fd02eb7
PE
1371 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1372 Otherwise, an out-of-range integer could cause undefined behavior
1373 on a 64-bit host.
1374
f8c86b69
PE
1375 * composite.c: Use int, not EMACS_INT, for characters.
1376 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1377 EMACS_INT, for values that are known to be in character range.
1378 This doesn't fix any bugs but is the usual style inside Emacs and
1379 may generate better code on 32-bit machines.
1380
34206dd2
PE
1381 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1382 This is for reasons similar to the recent CHAR_STRING fix.
1383 * charset.c (Fencode_char): Check that character arg is actually
1384 a character. Pass an int to ENCODE_CHAR.
1385 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1386 wider than 'int', as a compile-time check to prevent future regressions
1387 in this area.
1388
c5958d4c 1389 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1390
1391 Make sure a 64-bit char is never passed to CHAR_STRING.
1392 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1393 by silently ignoring the top 32 bits, allowing some values
1394 that were far too large to be valid characters.
1395 * character.h: Include <verify.h>.
1396 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1397 arguments are no wider than unsigned, as a compile-time check
1398 to prevent future regressions in this area.
1399 * data.c (Faset):
01103c44 1400 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1401 (Fsubst_char_in_region):
1402 * fns.c (concat):
1403 * xdisp.c (decode_mode_spec_coding):
1404 Adjust to CHAR_STRING's new requirement.
1405 * editfns.c (Finsert_char, Fsubst_char_in_region):
1406 * fns.c (concat): Check that character args are actually
1407 characters. Without this test, these functions did the wrong
1408 thing with wildly out-of-range values on 64-bit hosts.
1409
d37ca623
PE
1410 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1411 These casts should not be needed on 32-bit hosts, either.
1412 * keyboard.c (read_char):
1413 * lread.c (Fload): Remove casts to unsigned.
1414
ea204efb
PE
1415 * lisp.h (UNSIGNED_CMP): New macro.
1416 This fixes comparison bugs on 64-bit hosts.
1417 (ASCII_CHAR_P): Use it.
1418 * casefiddle.c (casify_object):
01103c44 1419 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1420 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1421 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1422 * dispextern.h (FACE_FROM_ID):
1423 * keyboard.c (read_char): Use UNSIGNED_CMP.
1424
41cb286c
PE
1425 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1426 not to EMACS_INT, to avoid GCC warning.
1427
4a1b9832
PE
1428 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1429
55daad71
PE
1430 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1431 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1432 isn't needed on 32-bit machines.
8f95c75c 1433
01103c44
PE
1434 * buffer.c (Fgenerate_new_buffer_name):
1435 Use EMACS_INT for count, not int.
0ceccced 1436 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1437
1438 * data.c (Qcompiled_function): Now static.
1439
c6f072e7
PE
1440 * window.c (window_body_lines): Now static.
1441
20ce5912
PE
1442 * image.c (gif_load): Rename local to avoid shadowing.
1443
9c4c5f81
PE
1444 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1445 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1446 * alloc.c (make_save_value): Integer argument is now of type
1447 ptrdiff_t, not int.
1448 (mark_object): Use ptrdiff_t, not int.
1449 * lisp.h (pD): New macro.
1450 * print.c (print_object): Use it.
1451
c0c5c8ae
PE
1452 * alloc.c: Use EMACS_INT, not int, to count objects.
1453 (total_conses, total_markers, total_symbols, total_vector_size)
1454 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1455 (total_free_floats, total_floats, total_free_intervals)
1456 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1457 Now EMACS_INT, not int. All uses changed.
1458 (Fgarbage_collect): Compute overall total using a double, so that
1459 integer overflow is less likely to be a problem. Check for overflow
1460 when converting back to an integer.
5a25e253
PE
1461 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1462 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1463 These were 'int' variables that could overflow on 64-bit hosts;
1464 they were never used, so remove them instead of repairing them.
211a0b2a 1465 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1466 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1467 Previously, this ceilinged at INT_MAX, but that doesn't work on
1468 64-bit machines.
e46bb31a 1469 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1470
c78baabf 1471 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1472 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1473 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1474 when a (possibly-narrower) signed value would do just as well.
1475 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1476
c9d624c6
PE
1477 * alloc.c: Catch some string size overflows that we were missing.
1478 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1479 for convenience in STRING_BYTES_MAX.
1480 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1481 The definition here is exact; the one in lisp.h was approximate.
1482 (allocate_string_data): Check for string overflow. This catches
1483 some instances we weren't catching before. Also, it catches
1484 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1485 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1486 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1487
c9d624c6
PE
1488 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1489 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1490 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1491
353032ce
PE
1492 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1493
2bccce07
PE
1494 * alloc.c (Fmake_string): Check for out-of-range init.
1495
0ac30604
SM
14962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1497
1498 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1499
c195f2de
JD
15002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1501
1502 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1503 xg_get_default_scrollbar_width.
1504
1505 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1506 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1507 (style_changed_cb): Call update_theme_scrollbar_width and call
1508 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1509 all frames (Bug#8505).
1510 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1511 Call gtk_window_set_resizable if HAVE_GTK3.
1512 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1513 and height if HAVE_GTK3 (Bug#8505).
1514 (scroll_bar_width_for_theme): New variable.
1515 (update_theme_scrollbar_width): New function.
1516 (xg_get_default_scrollbar_width): Move code to
1517 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1518 (xg_initialize): Call update_theme_scrollbar_width.
1519
1520 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1521
1522 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1523
e10ac9f1
MR
15242011-06-12 Martin Rudalics <rudalics@gmx.at>
1525
1526 * frame.c (make_frame): Call other_buffer_safely instead of
1527 other_buffer.
1528
1529 * window.c (temp_output_buffer_show): Call display_buffer with
1530 second argument Vtemp_buffer_show_specifiers and reset latter
1531 immediately after the call.
1532 (Vtemp_buffer_show_specifiers): New variable.
1533 (auto_window_vscroll_p, next_screen_context_lines)
1534 (Vscroll_preserve_screen_position): Remove leading asterisks from
1535 doc-strings.
1536
2d3c217e 15372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1538
7b7f97e8 1539 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1540 * buffer.c (Qclone_number): Remove for now, as it's unused.
1541 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1542 (record_buffer): Remove unused local.
1543 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1544 (set_frame_buffer_list): Remove; unused.
1545 * frame.h (other_visible_frames): Remove decl.
1546 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1547 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1548 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1549 if HAVE_GPM.
1550 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1551 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1552 Define only if HAVE_GPM.
1553 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1554 (update_hints_inhibit): Remove; never set. All uses removed.
1555 * widgetprv.h (emacsFrameClassRec): Remove decl.
1556 * window.c (delete_deletable_window): Now returns void, since it
1557 wasn't returning anything.
1558 (compare_window_configurations): Remove unused locals.
1559 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1560 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1561 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1562 the same widths as pointers. This follows up on the 2011-05-06 patch.
1563 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1564 * xterm.h: Likewise.
1565 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1566
1384b89e
JB
15672011-06-12 Juanma Barranquero <lekktu@gmail.com>
1568
1569 * makefile.w32-in: Update dependencies.
1570 (LISP_H): Add lib/intprops.h.
1571
1100a63c
CY
15722011-06-11 Chong Yidong <cyd@stupidchicken.com>
1573
1574 * image.c (gif_load): Add animation frame delay to the metadata.
1575 (syms_of_image): Use DEFSYM. New symbol `delay'.
1576
6198ccd0
MR
15772011-06-11 Martin Rudalics <rudalics@gmx.at>
1578
1579 * window.c (delete_deletable_window): Re-add.
1580 (Fset_window_configuration): Rewrite to handle dead buffers and
1581 consequently deletable windows.
1582 (window_tree, Fwindow_tree): Remove. Supply functionality in
1583 window.el.
1584 (compare_window_configurations): Simplify code.
1585
b6e3633c
AS
15862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1587
1ab0dee5
AS
1588 * image.c (imagemagick_load_image): Fix type mismatch.
1589 (Fimagemagick_types): Likewise.
1590
b6e3633c
AS
1591 * window.h (replace_buffer_in_windows): Declare.
1592
9397e56f
MR
15932011-06-11 Martin Rudalics <rudalics@gmx.at>
1594
1595 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1596 Qclone_number. Remove external declaration of Qdelete_window.
1597 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1598 code.
1599 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1600 Qbuffer_list_update_hook if allowed.
1601 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1602 buffer list implementation.
1603 (other_buffer_safely): New function.
1604 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1605 calls to replace_buffer_in_windows and
1606 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1607 if allowed.
1608 (record_buffer): Inhibit quitting and rewrite using quittable
1609 functions. Run Qbuffer_list_update_hook if allowed.
1610 (Frecord_buffer, Funrecord_buffer): New functions.
1611 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1612 switch-to-buffer to window.el.
1613 (bury-buffer): Move to window.el.
1614 (Vbuffer_list_update_hook): New variable.
1615
1616 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1617 section.
1618
1619 * window.h (resize_frame_windows): Move up in code.
1620 (Fwindow_frame): Remove EXFUN.
1621 (replace_buffer_in_all_windows): Remove prototype.
1622 (replace_buffer_in_windows_safely): Add prototype.
1623
1624 * window.c: Declare Qdelete_window static again. Move down
1625 declaration of select_count.
1626 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1627 (Fother_window): Move to window.el.
1628 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1629 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1630 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1631 window.el.
1632 (replace_buffer_in_windows): Implement by calling
1633 Qreplace_buffer_in_windows.
1634 (replace_buffer_in_all_windows): Remove with some functionality
1635 moved into replace_buffer_in_windows_safely.
1636 (replace_buffer_in_windows_safely): New function.
1637 (select_window_norecord, select_frame_norecord): Move in front
1638 of run_window_configuration_change_hook. Remove now obsolete
1639 declarations.
1640 (Fset_window_buffer): Rewrite doc-string. Call
1641 Qrecord_window_buffer.
1642 (keys_of_window): Move binding for other-window to window.el.
1643
b50691aa
CY
16442011-06-11 Chong Yidong <cyd@stupidchicken.com>
1645
1646 * dispextern.h (struct image): Replace data member, whose int_val
1647 and ptr_val fields were not used by anything, with a single
1648 lisp_val object.
1649
1650 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1651 (gif_clear_image, gif_load, imagemagick_load_image)
1652 (gs_clear_image, gs_load): Callers changed.
1653
3f754b86
PE
16542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1655
cca69397
PE
1656 * buffer.h: Include <time.h>, for time_t.
1657 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1658
109e28d0
PE
1659 Fix minor problems found by static checking.
1660
60737f02
PE
1661 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1662
4b66faf3
PE
1663 Make identifiers static if they are not used in other modules.
1664 * data.c (Qcompiled_function, Qframe, Qvector):
1665 * image.c (QimageMagick, Qsvg):
1666 * minibuf.c (Qmetadata):
1667 * window.c (resize_window_check, resize_root_window): Now static.
1668 * window.h (resize_window_check, resize_root_window): Remove decls.
1669
109e28d0
PE
1670 * window.c (window_deletion_count, delete_deletable_window):
1671 Remove; unused.
46a4ce9e
PE
1672 (window_body_lines): Now static.
1673 (Fdelete_other_windows_internal): Mark vars as initialized.
1674 Make sure 'resize_failed' is initialized.
1675 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1676 (resize_window_apply): Remove unused local.
1677 * window.h (delete_deletable_window): Remove decl.
1678
109e28d0 1679 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1680 (imagemagick_load_image): Fix pointer signedness problem by changing
1681 last arg from unsigned char * to char *. All uses changed.
1682 Also, fix a local for similar reasons.
1683 Remove unused locals. Remove locals to avoid shadowing.
1684 (fn_rsvg_handle_free): Remove; unused.
1685 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1686 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1687
3f754b86
PE
1688 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1689
2547adb1
CY
16902011-06-10 Chong Yidong <cyd@stupidchicken.com>
1691
1692 * image.c (gif_load): Fix omitted cast error introduced by
1693 2011-06-06 change.
1694
2c8e37d4
MR
16952011-06-10 Martin Rudalics <rudalics@gmx.at>
1696
1697 * window.h (resize_proportionally, orig_total_lines)
1698 (orig_top_line): Remove from window structure.
1699 (set_window_height, set_window_width, change_window_heights)
1700 (Fdelete_window): Remove prototypes.
1701 (resize_frame_windows): Remove duplicate declaration.
1702
440a42e3
EZ
17032011-06-10 Eli Zaretskii <eliz@gnu.org>
1704
1705 * window.h (resize_frame_windows, resize_window_check)
1706 (delete_deletable_window, resize_root_window)
1707 (resize_frame_windows): Declare prototypes.
1708
1709 * window.c (resize_window_apply): Make definition be "static" to
1710 match the prototype.
1711
562dd5e9
MR
17122011-06-10 Martin Rudalics <rudalics@gmx.at>
1713
1714 * window.c: Remove declarations of Qwindow_size_fixed,
1715 window_min_size_1, window_min_size_2, window_min_size,
1716 size_window, window_fixed_size_p, enlarge_window, delete_window.
1717 Remove static from declaration of Qdelete_window, it's
1718 temporarily needed by Fbury_buffer.
1719 (replace_window): Don't assign orig_top_line and
1720 orig_total_lines.
1721 (Fdelete_window, delete_window): Remove. Window deletion is
1722 handled by window.el.
1723 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1724 Fdelete_window calls with calls to Qdelete_window.
1725 (Fdelete_other_windows): Remove. Deleting other windows is
1726 handled by window.el.
1727 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1728 handled in window.el.
1729 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1730 Window minimum sizes are handled in window.el.
1731 (shrink_windows, size_window, set_window_height)
1732 (set_window_width, change_window_heights, window_height)
1733 (window_width, CURBEG, CURSIZE, enlarge_window)
1734 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1735 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1736 handled in window.el.
1737 (make_dummy_parent): Rename to make_parent_window and give it a
1738 second argument horflag.
1739 (make_window): Don't set resize_proportionally any more.
1740 (Fsplit_window): Remove. Windows are split in window.el.
1741 (save_restore_action, save_restore_orig_size)
1742 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1743 Resize mini windows in window.el.
1744 (grow_mini_window, shrink_mini_window): Implement by calling
1745 Qresize_root_window_vertically, resize_window_check and
1746 resize_window_apply.
1747 (saved_window, Fset_window_configuration, save_window_save): Do
1748 not handle orig_top_line, orig_total_lines, and
1749 resize_proportionally.
1750 (window_min_height, window_min_width): Move to window.el.
1751 (keys_of_window): Move bindings for delete-other-windows,
1752 split-window, delete-window and enlarge-window to window.el.
1753
1754 * buffer.c: Temporarily extern Qdelete_window.
1755 (Fbury_buffer): Temporarily call Qdelete_window instead of
1756 Fdelete_window (Fbury_buffer will move to window.el soon).
1757
1758 * frame.c (set_menu_bar_lines_1): Remove code handling
1759 orig_top_line and orig_total_lines.
1760
1761 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1762 set_window_height but set heights directly.
1763 (change_frame_size_1): Use resize_frame_windows.
1764
1765 * xdisp.c (init_xdisp): Don't use set_window_height but set
1766 heights directly.
1767
1768 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1769 resize_frame_windows instead of change_window_heights and run
1770 run_window_configuration_change_hook.
1771
1772 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1773 instead of change_window_heights and run
1774 run_window_configuration_change_hook.
1775
1a13852e
MR
17762011-06-09 Martin Rudalics <rudalics@gmx.at>
1777
1778 * window.c (replace_window): Rename second argument REPLACEMENT to
1779 NEW. New third argument SETFLAG. Rewrite.
1780 (delete_window, make_dummy_parent): Call replace_window with
1781 third argument 1.
1782 (window_list_1): Move down in code.
1783 (run_window_configuration_change_hook): Move set_buffer part
1784 before select_frame_norecord part in order to unwind correctly.
1785 Rename count1 to count.
1786 (recombine_windows, delete_deletable_window, resize_root_window)
1787 (Fdelete_other_windows_internal)
1788 (Frun_window_configuration_change_hook, make_parent_window)
1789 (resize_window_check, resize_window_apply, Fresize_window_apply)
1790 (resize_frame_windows, Fsplit_window_internal)
1791 (Fdelete_window_internal, Fresize_mini_window_internal): New
1792 functions.
1793 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1794
f3d1777e
MR
17952011-06-08 Martin Rudalics <rudalics@gmx.at>
1796
496e208e
MR
1797 * window.h (window): Add some new members to window structure -
1798 normal_lines, normal_cols, new_total, new_normal, clone_number,
1799 splits, nest, prev_buffers, next_buffers.
1800 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1801 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1802
f3d1777e
MR
1803 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1804 Remove.
496e208e
MR
1805 (make_dummy_parent): Set new members of windows structure.
1806 (make_window): Move down in code. Handle new members of window
1807 structure.
1808 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1809 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1810 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1811 (Fset_window_prev_buffers, Fwindow_next_buffers)
1812 (Fset_window_next_buffers, Fset_window_clone_number): New
1813 functions.
1814 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1815 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1816 Doc-string fixes.
1817 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1818 Argument WINDOW can be now internal window too.
1819 (Fwindow_use_time): Move up in code.
1820 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1821 Rewrite doc-string.
1822 (Fset_window_configuration, saved_window)
1823 (Fcurrent_window_configuration, save_window_save): Handle new
1824 members of window structure.
b9e809c2
MR
1825 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1826 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1827 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1828 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1829 Qget_mru_window, Qresize_root_window,
1830 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1831 Qauto_buffer_name; staticpro them.
f3d1777e 1832
abde8f8c
MR
18332011-06-07 Martin Rudalics <rudalics@gmx.at>
1834
1835 * window.c (Fwindow_total_size, Fwindow_left_column)
1836 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1837 (Fwindow_list_1): New functions.
1838 (window_box_text_cols): Replace with window_body_cols.
1839 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1840 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1841 (delete_window, Fset_window_configuration): Call
1842 delete_all_subwindows with window as argument.
1843 (delete_all_subwindows): Take a window as argument and not a
1844 structure. Rewrite.
190b47e6
MR
1845 (window_loop): Remove handling of GET_LRU_WINDOW and
1846 GET_LARGEST_WINDOW.
1847 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1848
1849 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1850 window_box_text_cols. delete_all_subwindows now takes a
1851 Lisp_Object as argument.
abde8f8c
MR
1852
1853 * indent.c (compute_motion, Fcompute_motion): Use
1854 window_body_cols instead of window_box_text_cols.
1855
fa8a67e6
MR
1856 * frame.c (delete_frame): Call delete_all_subwindows with root
1857 window as argument.
1858
a54e3482
DC
18592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1860
1861 * fns.c (Fputhash): Document return value.
1862
60002bf5
CY
18632011-06-06 Chong Yidong <cyd@stupidchicken.com>
1864
1865 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1866
0c671da6 18672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1868
b862a52a 1869 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1870
be44ca6c
PE
1871 Check for overflow when converting integer to cons and back.
1872 * charset.c (Fdefine_charset_internal, Fdecode_char):
1873 Use cons_to_unsigned to catch overflow.
1874 (Fencode_char): Use INTEGER_TO_CONS.
1875 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1876 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1877 * data.c (long_to_cons, cons_to_long): Remove.
1878 (cons_to_unsigned, cons_to_signed): New functions.
1879 These signal an error for invalid or out-of-range values.
1880 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1881 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1882 * font.c (Ffont_variation_glyphs):
1883 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1884 * lisp.h: Include <intprops.h>.
1885 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1886 (cons_to_signed, cons_to_unsigned): New decls.
1887 (long_to_cons, cons_to_long): Remove decls.
1888 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1889 (Fprimitive_undo): Use CONS_TO_INTEGER.
1890 * xfns.c (Fx_window_property): Likewise.
1891 * xselect.c: Include <limits.h>.
1892 (x_own_selection, selection_data_to_lisp_data):
1893 Use INTEGER_TO_CONS.
1894 (x_handle_selection_request, x_handle_selection_clear)
1895 (x_get_foreign_selection, Fx_disown_selection_internal)
1896 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1897 (lisp_data_to_selection_data): Use cons_to_unsigned.
1898 (x_fill_property_data): Use cons_to_signed.
1899 Report values out of range.
1900
d1f3d2af
PE
1901 Check for buffer and string overflow more precisely.
1902 * buffer.h (BUF_BYTES_MAX): New macro.
1903 * lisp.h (STRING_BYTES_MAX): New macro.
1904 * alloc.c (Fmake_string):
1905 * character.c (string_escape_byte8):
1906 * coding.c (coding_alloc_by_realloc):
1907 * doprnt.c (doprnt):
1908 * editfns.c (Fformat):
1909 * eval.c (verror):
1910 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1911 since they may not be the same number.
1912 * editfns.c (Finsert_char):
1913 * fileio.c (Finsert_file_contents):
1914 Likewise for BUF_BYTES_MAX.
1915
dd52fcea
PE
1916 * image.c: Use ptrdiff_t, not int, for sizes.
1917 (slurp_file): Switch from int to ptrdiff_t.
1918 All uses changed.
1919 (slurp_file): Check that file size fits in both size_t (for
1920 malloc) and ptrdiff_t (for sanity and safety).
1921
7f9bbdbb
PE
1922 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1923 if b->modtime has its maximal value.
1924
dfe18f82
PE
1925 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1926
84acfcf0
PE
1927 Don't assume time_t can fit into int.
1928 * buffer.h (struct buffer.modtime): Now time_t, not int.
1929 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1930 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1931
ccd9a01a
PE
1932 Minor fixes for signed vs unsigned integers.
1933 * character.h (MAYBE_UNIFY_CHAR):
1934 * charset.c (maybe_unify_char):
1935 * keyboard.c (read_char, reorder_modifiers):
1936 XINT -> XFASTINT, since the integer must be nonnegative.
1937 * ftfont.c (ftfont_spec_pattern):
1938 * keymap.c (access_keymap, silly_event_symbol_error):
1939 XUINT -> XFASTINT, since the integer must be nonnegative.
1940 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1941 since it makes no difference and we prefer signed.
1942 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1943 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1944 nonnegative.
1945
d6d100dd
SM
19462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1947
1948 * window.h (Fwindow_frame): Declare.
1949
2b6148e4
PE
19502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1953 (SPARE_MEMORY): Always define.
1954 (LARGE_REQUEST): Remove.
1955 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1956
f230ecc9
MR
19572011-06-06 Martin Rudalics <rudalics@gmx.at>
1958
727e958e
MR
1959 * lisp.h: Move EXFUNS for Fframe_root_window,
1960 Fframe_first_window and Fset_frame_selected_window to window.h.
1961
1962 * window.h: Move EXFUNS for Fframe_root_window,
1963 Fframe_first_window and Fset_frame_selected_window here from
1964 lisp.h.
1965
1966 * frame.c (Fwindow_frame, Fframe_first_window)
1967 (Fframe_root_window, Fframe_selected_window)
1968 (Fset_frame_selected_window): Move to window.c.
1969 (Factive_minibuffer_window): Move to minibuf.c.
1970 (Fother_visible_frames_p): New function.
1971
1972 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1973
f230ecc9
MR
1974 * window.c (decode_window, decode_any_window): Move up in code.
1975 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1976 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1977 (Fwindow_buffer): Move up and rewrite doc-string.
1978 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1979 (Fwindow_prev): New functions.
727e958e
MR
1980 (Fwindow_frame): Move here from frame.c. Accept any window as
1981 argument.
1982 (Fframe_root_window, Fframe_first_window)
1983 (Fframe_selected_window): Move here from frame.c. Accept frame
1984 or arbitrary window as argument. Update doc-strings.
1985 (Fminibuffer_window): Move up in code.
1986 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1987 (Fset_frame_selected_window): Move here from frame.c.
1988 Marginal rewrite.
727e958e
MR
1989 (Fselected_window, select_window, Fselect_window): Move up in
1990 code. Minor doc-string fixes.
f230ecc9 1991
4d09bcf6
PE
19922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1995 Do not assume that spare memory exists; that assumption is valid
1996 only if SYSTEM_MALLOC.
1997 (LARGE_REQUEST): New macro, so that the issue of large requests
1998 is separated from the issue of spare memory.
1999
810928a2
AS
20002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2001
172418ad
AS
2002 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2003 format. (Bug#8806)
2004
43f862f7
AS
2005 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2006
810928a2
AS
2007 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2008 before statements.
2009
a059fe24
JD
20102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2011
2012 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2013
2014 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2015
2016 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2017 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2018
989bf368
JB
20192011-06-05 Juanma Barranquero <lekktu@gmail.com>
2020
2021 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2022
4b80f674
CY
20232011-06-04 Chong Yidong <cyd@stupidchicken.com>
2024
2025 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2026 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2027 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2028 New error handlers.
4b80f674
CY
2029 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2030 Obey Vx_select_enable_clipboard_manager. Catch errors in
2031 x_clipboard_manager_save (Bug#8779).
2032 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2033 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2034
99a33b77 20352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2036
2037 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2038
99a33b77 20392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2040
2041 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2042 in the current matrix if keep_current_p is non-zero.
2043
8264569d
EZ
20442011-06-04 Eli Zaretskii <eliz@gnu.org>
2045
2046 * bidi.c (bidi_level_of_next_char): Fix last change.
2047
57f97249
EZ
20482011-06-03 Eli Zaretskii <eliz@gnu.org>
2049
fec2107c 2050 Support bidi reordering of text covered by display properties.
57f97249 2051
fec2107c
EZ
2052 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2053 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2054 (bidi_cache_search, bidi_cache_iterator_state)
2055 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2056 (bidi_level_of_next_char, bidi_move_to_visually_next):
2057 Support character positions inside a run of characters covered by a
fec2107c
EZ
2058 display string.
2059 (bidi_paragraph_init, bidi_resolve_explicit_1)
2060 (bidi_level_of_next_char): Call bidi_fetch_char and
2061 bidi_fetch_char_advance instead of FETCH_CHAR and
2062 FETCH_CHAR_ADVANCE.
2063 (bidi_init_it): Initialize new members.
2064 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2065 definitions.
2066 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2067 instead of using explicit *_CHAR codes.
d6d100dd
SM
2068 (bidi_resolve_explicit, bidi_resolve_weak):
2069 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2070 bidirectional text is supported only in multibyte buffers.
2071 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2072 it to initialize the frame_window_p member of struct bidi_it.
2073 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2074 (bidi_resolve_explicit, bidi_resolve_weak)
2075 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2076 bidi_it->nchars is non-positive.
2077 (bidi_level_of_next_char): Don't try to lookup the cache for the
2078 next/previous character if nothing is cached there yet, or if we
2079 were just reseat()'ed to a new position.
c40e2fb2 2080
0e14fe90
EZ
2081 * xdisp.c (set_cursor_from_row): Set start and stop points
2082 according to the row's direction when priming the loop that looks
2083 for the glyph on which to display cursor.
2084 (single_display_spec_intangible_p): Function deleted.
2085 (display_prop_intangible_p): Reimplement to call
2086 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2087 Accept 3 additional arguments needed by handle_display_spec.
2088 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2089 values: lists, `(when COND...)' forms, etc.
2090 (single_display_spec_string_p): Support property values that are
2091 lists with the argument STRING its top-level element.
2092 (display_prop_string_p): Fix the condition for processing a
2093 property that is a list to be consistent with handle_display_spec.
fec2107c 2094 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2095 last portion of handle_display_prop.
2096 (compute_display_string_pos): Accept additional argument
2097 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2098 value of a `display' property is a "replacing spec".
2099 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2100 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2101 the display property, but just return a value indicating whether
2102 the display property will replace the characters it covers.
2103 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2104 frame_window_p members of struct bidi_it.
d6d100dd
SM
2105 (compute_display_string_pos, compute_display_string_end):
2106 New functions.
fec2107c
EZ
2107 (push_it): Accept second argument POSITION, where pop_it should
2108 jump to continue iteration.
2109 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2110
fec2107c
EZ
2111 * keyboard.c (adjust_point_for_property): Adjust the call to
2112 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2113
2114 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2115 (bidi_init_it): Update prototypes.
2116 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2117 (compute_display_string_pos, compute_display_string_end):
2118 Declare prototypes.
fec2107c
EZ
2119 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2120 EMACS_INT.
fc6f18ce 2121
40087514 21222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2123
57f53182
PE
2124 Malloc failure behavior now depends on size of allocation.
2125 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2126 * lisp.h: Change signatures accordingly.
2127 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2128 All callers changed. (Bug#8762)
2129
2130 * gnutls.c: Use Emacs's memory allocators.
2131 Without this change, the gnutls library would invoke malloc etc.
2132 directly, which causes problems on non-SYNC_INPUT hosts, and which
2133 runs afoul of improving memory_full behavior. (Bug#8761)
2134 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2135 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2136 xfree instead of the default malloc, realloc, free.
2137 (Fgnutls_boot): No need to check for memory allocation failure,
2138 since xmalloc does that for us.
2139
ac32cd99 2140 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2141 * category.c (hash_get_category_set):
2142 * ccl.c (ccl_driver):
2143 * charset.c (Fdefine_charset_internal):
2144 * charset.h (struct charset.hash_index):
2145 * composite.c (get_composition_id, gstring_lookup_cache)
2146 (composition_gstring_put_cache):
2147 * composite.h (struct composition.hash_index):
2148 * dispextern.h (struct image.hash):
2149 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2150 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2151 (hashfn_equal, hashfn_user_defined, make_hash_table)
2152 (maybe_resize_hash_table, hash_lookup, hash_put)
2153 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2154 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2155 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2156 * image.c (make_image, search_image_cache, lookup_image)
2157 (xpm_put_color_table_h):
2158 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2159 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2160 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2161 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2162 * alloc.c (allocate_vectorlike):
2163 Check for overflow in vector size calculations.
2164 * ccl.c (ccl_driver):
2165 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2166 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2167 need to be updated by these changes.
40087514
PE
2168 * fns.c (make_hash_table, maybe_resize_hash_table):
2169 Check for integer overflow with large hash tables.
0de4bb68
PE
2170 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2171 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2172 (SXHASH_REDUCE): New macro.
2173 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2174 Use it instead of discarding useful hash info with large hash values.
2175 (sxhash_float): New function.
2176 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2177 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2178 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2179 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2180 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2181 Adjust signatures to match updated version of code.
2182 (consing_since_gc): Now EMACS_INT, since a single hash table can
2183 use more than INT_MAX bytes.
2184
698d32e2
DN
21852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2186
2187 Make it possible to build with GCC-4.6+ -O2 -flto.
2188
2189 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2190
fd6fa53f
SM
21912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2192
2193 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2194 Call minibuffer-inactive-mode.
2195
864db017
JB
21962011-05-31 Juanma Barranquero <lekktu@gmail.com>
2197
2198 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2199 Update dependencies.
2200
2ad0baf4
DN
22012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2202
2203 * data.c (init_data): Remove code for UTS, this system is not
2204 supported anymore.
2205
4fcc2638
DN
22062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2207
2208 Don't force ./temacs to start in terminal mode.
2209
2210 * frame.c (make_initial_frame): Initialize faces in all cases, not
2211 only when CANNOT_DUMP is defined.
2212 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2213
c56e0fd5
DN
22142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2215
2216 * dispnew.c (add_window_display_history): Use const for the string
2217 pointer. Remove declaration, not needed.
2218
333d54da 22192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2220
55d4c1b2 2221 Use 'inline', not 'INLINE'.
333d54da 2222 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2223 * alloc.c, fontset.c (INLINE): Remove.
2224 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2225 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2226 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2227 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2228 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2229
738db178
DN
22302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2231
2232 Make it possible to run ./temacs.
2233
2234 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2235 syms_of_callproc does the same thing. Remove test for
2236 "initialized", do it in the caller.
2237 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2238
620c53a6
SM
22392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2240
2241 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2242 (read_minibuf): Use get_minibuffer.
2243 (syms_of_minibuf): Use DEFSYM.
2244 (Qmetadata): New var.
2245 * data.c (Qbuffer): Don't make it static.
2246 (syms_of_data): Use DEFSYM.
2247
e003a292
PE
22482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2249
2250 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2251 (CCL_CODE_MIN): New macro.
2252
ed008a6d
PE
22532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2254
3687c2ef
PE
2255 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2256
ed008a6d
PE
2257 * eval.c (Qdebug): Now static.
2258 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2259 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2260 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2261
d66c4c7c
CY
22622011-05-29 Chong Yidong <cyd@stupidchicken.com>
2263
2264 * image.c: Various fixes to ImageMagick code comments.
2265 (Fimagemagick_types): Doc fix.
2266
5fbc2025
PE
22672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2268
0196f88a
PE
2269 Minor fixes prompted by GCC 4.6.0 warnings.
2270
2271 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2272
5fbc2025
PE
2273 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2274 (x_clipboard_manager_save_all): Move extern decl to ...
2275 * xterm.h: ... here, so that it can be checked for consistency.
2276
1dd3c2d9
CY
22772011-05-29 Chong Yidong <cyd@stupidchicken.com>
2278
2279 * xselect.c (x_clipboard_manager_save_frame)
2280 (x_clipboard_manager_save_all): New functions.
2281 (Fx_clipboard_manager_save): Lisp function deleted.
2282
2283 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2284 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2285
2286 * xterm.h: Update prototype.
2287
5ba6571d
WX
22882011-05-28 William Xu <william.xwl@gmail.com>
2289
2290 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2291 exiting (Bug#8239).
2292
3eaff834
JM
22932011-05-28 Jim Meyering <meyering@redhat.com>
2294
e1900994 2295 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2296 * fns.c (to_uchar): Define.
2297 (crypto_hash_function): Use it to convert some newly-signed
2298 variables to unsigned, to avoid sign-extension bugs. For example,
2299 without this change, (md5 "truc") would evaluate to
2300 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2301 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2302 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2303
0f6990a7
PE
23042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 Integer overflow fixes.
c8a9ca5a 2307
08686060
PE
2308 * dbusbind.c: Serial number integer overflow fixes.
2309 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2310 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2311 to hold a serial number that is too large for a fixnum.
2312 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2313 Check for serial numbers out of range. Decode any serial number
59568bf0 2314 that was so large that it became a float. (Bug#8722)
08686060 2315
2d1fc3c7
PE
2316 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2317 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2318 Use XFASTINT rather than XUINT when numbers are nonnegative.
2319 (xd_append_arg, Fdbus_method_return_internal):
2320 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2321 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2322 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2323 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2324 (Bug#8722)
2d1fc3c7 2325
c8a9ca5a
PE
2326 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2327
519e1d69
PE
2328 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2329
30569699
PE
2330 ccl: add integer overflow checks
2331 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2332 (IN_INT_RANGE): New macros.
2333 (ccl_driver): Use them to check for integer overflow when
2334 decoding a CCL program. Many of the new checks are whether XINT (x)
2335 fits in int; it doesn't always, on 64-bit hosts. The new version
2336 doesn't catch all possible integer overflows, but it's an
847044ea 2337 improvement. (Bug#8719)
30569699 2338
c11285dc
PE
2339 * alloc.c (make_event_array): Use XINT, not XUINT.
2340 There's no need for unsigned here.
2341
fdccd48e
PE
2342 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2343 This follows up to the 2011-05-06 change that substituted uintptr_t
2344 for EMACS_INT. This case wasn't caught back then.
2345
37910ab2
PE
2346 Rework Fformat to avoid integer overflow issues.
2347 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2348 now (part of C89). Include <verify.h>.
2349 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2350 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2351 (Fformat): Avoid the prepass trying to compute sizes; it was only
2352 approximate and thus did not catch overflow reliably. Instead, walk
2353 through the format just once, formatting and computing sizes as we go,
2354 checking for integer overflow at every step, and allocating a larger
2355 buffer as needed. Keep track separately whether the format is
2356 multibyte. Keep only the most-recently calculated precision, rather
2357 than them all. Record whether each argument has been converted to
2358 string. Use EMACS_INT, not int, for byte and char and arg counts.
2359 Support field widths and precisions larger than INT_MAX. Avoid
2360 sprintf's undefined behavior with conversion specifications such as %#d
2361 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2362 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2363 formatting out-of-range floating point numbers with int
9173deec 2364 formats. (Bug#8668)
37910ab2 2365
2e6578fb
PE
2366 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2367
0ae6bdee
PE
2368 * data.c: Avoid integer truncation in expressions involving floats.
2369 * data.c: Include <intprops.h>.
2370 (arith_driver): When there's an integer overflow in an expression
2371 involving floating point, convert the integers to floating point
2372 so that the resulting value does not suffer from catastrophic
2373 integer truncation. For example, on a 64-bit host (* 4
2374 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2375 Do not rely on undefined behavior after integer overflow.
2376
de883a70
PE
2377 merge count_size_as_multibyte, parse_str_to_multibyte
2378 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2379 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2380 Check for integer overflow.
2381 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2382 since it's now a duplicate of the other. This is more of
2383 a character than a buffer op, so better that it's in character.c.
2384 * fns.c, print.c: Adjust to above changes.
2385
2ff916cb
PE
23862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2387
2388 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2389
f1b54466
PE
23902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2391
fb1ac845
PE
2392 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2393 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2394 (x_clipboard_manager_save): Now static.
2395 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2396
f1b54466
PE
2397 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2398 (crypto_hash_function): Now static.
2399 Fix pointer signedness problems. Avoid unnecessary initializations.
2400
a9f737ee
CY
24012011-05-27 Chong Yidong <cyd@stupidchicken.com>
2402
2403 * termhooks.h (Vselection_alist): Make it terminal-local.
2404
2405 * terminal.c (create_terminal): Initialize it.
2406
2407 * xselect.c: Support for clipboard managers.
2408 (Vselection_alist): Move to termhooks.h as terminal-local var.
2409 (LOCAL_SELECTION): New macro.
2410 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2411 (symbol_to_x_atom): Remove gratuitous arg.
2412 (x_handle_selection_request, lisp_data_to_selection_data)
2413 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2414 (x_own_selection, x_get_local_selection, x_convert_selection):
2415 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2416 (some_frame_on_display): Delete unused function.
2417 (Fx_own_selection_internal, Fx_get_selection_internal)
2418 (Fx_disown_selection_internal, Fx_selection_owner_p)
2419 (Fx_selection_exists_p): New optional frame arg.
2420 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2421 (x_handle_selection_clear): Don't treat other terminals with the
2422 same keyboard specially. Use the terminal-local Vselection_alist.
2423 (x_clear_frame_selections): Use Frun_hook_with_args.
2424
2425 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2426
2427 * xterm.h: Add support for those atoms.
2428
e067f0c1
CY
24292011-05-26 Chong Yidong <cyd@stupidchicken.com>
2430
2431 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2432 (converted_selections, conversion_fail_tag): New global variables.
2433 (x_selection_request_lisp_error): Free the above.
2434 (x_get_local_selection): Remove unnecessary code.
2435 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2436 of converted selections stored in converted_selections.
2437 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2438 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2439 (x_convert_selection): New function.
2440 (x_handle_selection_event): Simplify.
2441 (x_get_foreign_selection): Don't ignore incoming requests while
2442 waiting for an answer; this will fail when we implement
2443 SAVE_TARGETS, and seems unnecessary anyway.
2444 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2445 (Vx_sent_selection_functions): Doc fix.
2446
0f4aebc0
LL
24472011-05-26 Leo Liu <sdl.web@gmail.com>
2448
2449 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2450
e61124cd
YM
24512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2452
2453 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2454
2455 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2456 for fringe update if it has periodic bitmap.
ac389d0c 2457 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2458 and fringe_bitmap_periodic_p.
2459
2460 * fringe.c (get_fringe_bitmap_data): New function.
2461 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2462 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2463 row. Mark glyph row for fringe update if periodicity changed.
2464
2465 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2466 for fringe update unless it has periodic bitmap.
2467
f16d9837
KH
24682011-05-25 Kenichi Handa <handa@m17n.org>
2469
2470 * xdisp.c (get_next_display_element): Set correct it->face_id for
2471 a static composition.
2472
e1b90ef6
LL
24732011-05-24 Leo Liu <sdl.web@gmail.com>
2474
2475 * deps.mk (fns.o):
2476 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2477
2478 * fns.c (crypto_hash_function, Fsha1): New function.
2479 (Fmd5): Use crypto_hash_function.
2480 (syms_of_fns): Add Ssha1.
2481
7400048f
PE
24822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 * gnutls.c: Remove unused macros.
2485 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2486 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2487 Remove macros that are defined and never used.
2488 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2489
abb71cf4
CY
24902011-05-22 Chong Yidong <cyd@stupidchicken.com>
2491
2492 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2493 (Fx_get_selection_internal): Minor cleanup.
2494 (Fx_own_selection_internal): Rename arguments for consistency with
2495 select.el.
2496
6307db39
PE
24972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2500
f3d4e0a4
CY
25012011-05-22 Chong Yidong <cyd@stupidchicken.com>
2502
2503 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2504
4d8ade89
YM
25052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2506
2507 * dispnew.c (scrolling_window): Don't exclude the case that the
2508 last enabled row in the desired matrix touches the bottom boundary.
2509
32078c8d
GM
25102011-05-21 Glenn Morris <rgm@gnu.org>
2511
2512 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2513 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2514 and add some more files.
32078c8d 2515
7285dc67
EZ
25162011-05-20 Eli Zaretskii <eliz@gnu.org>
2517
2518 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2519 report_file_error introduced by the change from 2011-05-07.
2520
89d1bd22
PE
25212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2522
2523 * systime.h (Time): Define only if emacs is defined.
2524 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2525 where the include path doesn't have X11/X.h by default. See
2526 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2527
e23640bb 25282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2529
2530 * composite.c (find_automatic_composition): Fix previous change.
2531
b9704ad9
GM
25322011-05-20 Glenn Morris <rgm@gnu.org>
2533
2534 * lisp.mk: New file, split from Makefile.in.
2535 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2536 (shortlisp): Remove.
2537 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2538
4a720484
GM
25392011-05-19 Glenn Morris <rgm@gnu.org>
2540
2541 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2542 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2543 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2544 (lisp): Set the order to that of loadup.el.
2545 (shortlisp): Make it a copy of $lisp.
2546 (SOME_MACHINE_LISP): Remove.
2547 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2548 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2549
a28d4396
KH
25502011-05-18 Kenichi Handa <handa@m17n.org>
2551
2552 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2553 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2554 (find_automatic_composition): Mostly rewrite for efficiency.
2555
a2b1fa8e
JB
25562011-05-18 Juanma Barranquero <lekktu@gmail.com>
2557
2558 * makefile.w32-in: Update dependencies.
2559
8e1f5610
CS
25602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2561
2562 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2563 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2564
7025ee00 25652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2566
cdfa6eab
PE
2567 Fix some integer overflow issues, such as string length overflow.
2568
06d6db33
PE
2569 * insdel.c (count_size_as_multibyte): Check for string overflow.
2570
2b4560a8
PE
2571 * character.c (lisp_string_width): Check for string overflow.
2572 Use EMACS_INT, not int, for string indexes and lengths; in
2573 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2574 the resulting string length overflows an EMACS_INT; instead,
2575 report a string overflow if no precision given. When checking for
2576 precision exhaustion, use a check that cannot possibly have
2577 integer overflow. (Bug#8675)
2578 * character.h (lisp_string_width): Adjust to new signature.
2579
cb93f9be
PE
2580 * alloc.c (string_overflow): New function.
2581 (Fmake_string): Use it. This doesn't change behavior, but saves
2582 a few bytes and will simplify future changes.
2583 * character.c (string_escape_byte8): Likewise.
2584 * lisp.h (string_overflow): New decl.
2585
1a1f3366
PE
2586 Fixups, following up to the user-interface timestamp change.
2587 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2588 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2589 * msdos.c (mouse_get_pos): Likewise.
2590 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2591 * w32gui.h (Time): Define by including "systime.h" rather than by
2592 declaring it ourselves. (Bug#8664)
2593
d4e3e4d3
PE
2594 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2595 * image.c (clear_image_cache): Likewise.
2596
f6a24d19
PE
2597 * term.c (term_mouse_position): Don't assume time_t wraparound.
2598
08dc5ae6
PE
2599 Be more systematic about user-interface timestamps.
2600 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2601 and sometimes 'EMACS_UINT', to represent these timestamps.
2602 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2603 This makes the code easier to follow, and makes it easier to catch
2604 integer overflow bugs such as Bug#8664.
2605 * frame.c (Fmouse_position, Fmouse_pixel_position):
2606 Use Time, not unsigned long, for user-interface timestamps.
2607 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2608 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2609 * keyboard.h (last_event_timestamp): Likewise.
2610 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2611 * menu.h (xmenu_show): Likewise.
2612 * term.c (term_mouse_position): Likewise.
2613 * termhooks.h (struct input_event.timestamp): Likewise.
2614 (struct terminal.mouse_position_hook): Likewise.
2615 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2616 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2617 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2618 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2619 what it was before.
2620 * menu.h, termhooks.h: Include "systime.h", for Time.
2621
8e55734a
PE
2622 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2623 Don't assume that the difference between two unsigned long values
2624 can fit into an integer. At this point, we know button_down_time
2625 <= event->timestamp, so the difference must be nonnegative, so
2626 there's no need to cast the result if double-click-time is
2627 nonnegative, as it should be; check that it's nonnegative, just in
2628 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2629 apart (about 25 days). (Bug#8664)
8e55734a 2630
841f1b75 2631 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2632 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2633
3e26f69c
PE
2634 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2635 that always fit in int. Use a sentinel instead of a counter, to
2636 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2637 * frame.h (struct frame): Use int for menu_bar_items_used
2638 instead of EMACS_INT, since it always fits in int.
3e26f69c 2639
5cc152c0
PE
2640 * menu.c (grow_menu_items): Check for int overflow.
2641
d89eb65e
PE
2642 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2643
5235bd3e
PE
2644 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2645 Before, the code was not consistent. These values cannot exceed
2646 2**31 - 1 so there's no need to make them unsigned.
2647 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2648 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2649 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2650 as modifiers.
2651 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2652
bc827e23
PE
2653 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2654 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2655 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2656 presumably because the widths might not match.
2657
78eb494e
PE
2658 * window.c (size_window): Avoid needless test at loop start.
2659
04f2d78b
CB
26602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2661
2662 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2663
d2fc7e3d 26642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2665
2666 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2667
d2fc7e3d 26682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2669
2670 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2671 `width' to `bar_area_x' and `bar_area_width', respectively.
2672 (x_scroll_run): Take account of fringe background extension.
2673
04f2d78b
CB
2674 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2675 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2676 `bar_area_width', respectively.
2677 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2678 background extension.
2679
79b70037
GM
26802011-05-10 Jim Meyering <meyering@redhat.com>
2681
2682 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2683
2f142cc5
JB
26842011-05-10 Juanma Barranquero <lekktu@gmail.com>
2685
2686 * image.c (Finit_image_library): Return t for built-in image types,
2687 like pbm and xbm. (Bug#8640)
2688
57679c86
AS
26892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2690
2691 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2692
888c9e86
EZ
26932011-05-07 Eli Zaretskii <eliz@gnu.org>
2694
b0512a1d
EZ
2695 * w32console.c (Fset_screen_color): Doc fix.
2696 (Fget_screen_color): New function.
2697 (syms_of_ntterm): Defsubr it.
2698
7285dc67
EZ
2699 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2700 unlink the temporary file if Fcall_process didn't create it in the
2701 first place.
2702 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2703 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2704 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2705 cue to call_process_cleanup not to close that handle.
2706
4d3fcc8e
BK
27072011-05-07 Ben Key <bkey76@gmail.com>
2708
2709 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2710 one of two shell specific rules, either bootstrap-temacs-CMD or
2711 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2712 to the previous implementation of the bootstrap-temacs rule.
2713 The bootstrap-temacs-CMD rule is similar to the previous
2714 implementation of the bootstrap-temacs rule except that it
2715 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2716 variable.
2717
2718 These changes, along with some changes to nt/configure.bat,
2719 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2720 earlier fix to add support for --cflags and --ldflags options
2721 that include quotes so that it works whether make uses cmd or
2722 sh as the shell.
2723
b4289b64
MA
27242011-05-06 Michael Albinus <michael.albinus@gmx.de>
2725
2726 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2727 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2728 is a constant.
2729 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2730 a string. Handle both cases.
2731 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2732 (Fdbus_register_method): Use Qinvalid_function.
2733
af4c0e28
JB
27342011-05-06 Juanma Barranquero <lekktu@gmail.com>
2735
2736 * makefile.w32-in: Update dependencies.
2737 (LISP_H): Add inttypes.h and stdin.h.
2738 (PROCESS_H): Add unistd.h.
2739
c51453d9
EZ
27402011-05-06 Eli Zaretskii <eliz@gnu.org>
2741
2742 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2743 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2744
8ff0ac3c 27452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2746
4c4b566b
PE
2747 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2748
aab2b9b5
PE
2749 * term.c (vfatal): Remove stray call to va_end.
2750 It's not needed and the C Standard doesn't allow it here anyway.
2751
c378da0b
PE
2752 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2753 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2754
288b08c7
PE
2755 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2756 bytes.
2757
e3601888
PE
2758 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2759
db6c0e74
PE
2760 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2761
dd5963ea
PE
2762 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2763
88c9450f
PE
2764 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2765
2f9442b8
PE
2766 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2767
c032b5f8
PE
2768 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2769 * charset.c (Fdefine_charset_internal): Don't initialize
2770 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2771 32-bit int (Bug#8600).
a108c10b
PE
2772
2773 * lread.c (read_integer): Be more consistent with string-to-number.
2774 Use string_to_number to do the actual conversion; this avoids
2775 rounding errors and fixes some other screwups. Without this fix,
2776 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2777 (digit_to_number): Move earlier, for benefit of read_integer.
2778 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2779 not a digit in any supported base. (Bug#8602)
a108c10b 2780
ad5f9eea
PE
2781 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2782
aec1708a
PE
2783 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2784 to match comment at start of function. This also removes a
2785 GCC warning about overflow in a 32+64-bit port.
2786
47be4ab5
PE
2787 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2788
371cac43
PE
2789 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2790 Reported by Stefan Monnier in
2791 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2792 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2793 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2794
d01a7826
PE
2795 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2796 (EMACS_UINTPTR): Likewise, with uintptr_t.
2797
7fd47d5c
PE
2798 * lisp.h: Prefer 64-bit EMACS_INT if available.
2799 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2800 on 32-bit hosts that have 64-bit int, so that they can access
2801 large files.
122b0c86
PE
2802 However, temporarily disable this change unless the temporary
2803 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2804
8727937b
PE
2805 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2806
8ac068ac
PE
2807 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2808 This removes an assumption that EMACS_INT and long are the same
2809 width as pointers. The assumption is true for Emacs porting targets
2810 now, but we want to make other targets possible.
2811 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2812 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2813 In the rest of the code, change types of integers that hold casted
2814 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2815 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2816 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2817 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2818 No need to cast type when ORing.
2819 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2820 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2821 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2822 assume EMACS_INT is the same width as char *.
2823 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2824 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2825 Remove no-longer-needed casts.
2826 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2827 (xg_tool_bar_help_callback, xg_make_tool_item):
2828 Use EMACS_INTPTR to hold an integer
2829 that will be cast to void *; this can avoid a GCC warning
2830 if EMACS_INT is not the same width as void *.
2831 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2832 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2833 (current_message_1, set_message_1):
2834 Use a local to convert to proper width without a cast.
2835 * xmenu.c (dialog_selection_callback): Likewise.
2836
ede49d71
PE
2837 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2838 Also, don't assume VALBITS / RAND_BITS is less than 5,
2839 and don't rely on undefined behavior when shifting a 1 left into
2840 the sign bit.
2841 * lisp.h (get_random): Change signature to match.
2842
2f30ecd0
PE
2843 * lread.c (hash_string): Use size_t, not int, for hash computation.
2844 Normally we prefer signed values; but hashing is special, because
2845 it's better to use unsigned division on hash table sizes so that
2846 the remainder is nonnegative. Also, size_t is the natural width
2847 for hashing into memory. The previous code used 'int', which doesn't
2848 retain enough info to hash well into very large tables.
2849 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2850
2a866e7b
PE
2851 * dbusbind.c: Don't possibly lose pointer info when converting.
2852 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2853 Use XPNTR rather than XHASH, so that the high-order bits of
2854 the pointer aren't lost when converting through void *.
2855
51639eac
PE
2856 * eval.c (Fautoload): Don't double-shift a pointer.
2857
92394119
PE
2858 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2859
dbdb9a7c
JB
28602011-05-06 Juanma Barranquero <lekktu@gmail.com>
2861
2862 * gnutls.c (DEF_GNUTLS_FN):
2863 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2864
db7a0b4f
AS
28652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2866
2867 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2868 marker. (Bug#8610)
2869
f7ff1b0f 28702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2871
2872 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2873 New version that can reserve upto 2GB of heap space.
2874
f7ff1b0f 28752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2876
2877 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2878
639c109b
TZ
28792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2880
2881 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2882 `gnutls_certificate_set_x509_key_file'.
2883
d2127135
JB
28842011-05-05 Juanma Barranquero <lekktu@gmail.com>
2885
2886 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2887 Update dependencies.
2888
e968f4f3
JB
28892011-05-04 Juanma Barranquero <lekktu@gmail.com>
2890
2891 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2892 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2893 Remove unused parameter `fildes'.
2894 * process.c (read_process_output, send_process): Don't pass it.
2895
84d358f0
JB
28962011-05-04 Juanma Barranquero <lekktu@gmail.com>
2897
2898 Fix previous change: the library cache is defined in w32.c.
2899 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2900 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2901
0898ca10
JB
29022011-05-04 Juanma Barranquero <lekktu@gmail.com>
2903
2904 Implement dynamic loading of GnuTLS on Windows.
2905
2906 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2907 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2908 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2909 Declare.
2910
2911 * gnutls.c (Qgnutls_dll): Define.
2912 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2913 (gnutls_*): Declare function pointers.
2914 (init_gnutls_functions): New function to initialize function pointers.
2915 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2916 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2917 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2918 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2919 (emacs_gnutls_write, emacs_gnutls_read)
2920 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2921 (Fgnutls_available_p): New function.
2922 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2923 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2924 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2925
2926 * image.c: Include w32.h.
2927 (Vimage_type_cache): Delete.
2928 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2929 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2930 (w32_delayed_load): Move to w32.c.
2931
2932 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2933
2934 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2935 (w32_delayed_load): Move from image.c. When loading a library, record
2936 its filename in the :loaded-from property of the library id.
2937 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2938 Initialize and staticpro them.
2939 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2940
2941 * process.c: Include lisp.h before w32.h, not after.
2942 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2943 instead of gnutls_record_check_pending.
2944
2945 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2946
ff4de4aa
TZ
29472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2948
2949 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2950 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2951 as passed in.
2952
abe95abb
JD
29532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2954
2955 * xterm.c (x_set_frame_alpha): Do not set property on anything
2956 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2957
e16e55d4
JB
29582011-05-02 Juanma Barranquero <lekktu@gmail.com>
2959
2960 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2961
bafcf6a5
JB
29622011-05-02 Juanma Barranquero <lekktu@gmail.com>
2963
2964 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2965 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2966 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2967 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2968 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2969 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2970 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2971 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2972 (Qgnutls_bootprop_callbacks_verify): Make static.
2973
e7a6747f
AS
29742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2975
19ed11ba
AS
2976 * callproc.c: Indentation fixup.
2977
e7a6747f 2978 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2979 (wait_for_termination, interruptible_wait_for_termination):
2980 Move after wait_for_termination_1.
e7a6747f 2981
1ef14cb4
LMI
29822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2983
2984 * sysdep.c (interruptible_wait_for_termination): New function
2985 which is like wait_for_termination, but allows keyboard
2986 interruptions.
2987
2988 * callproc.c (Fcall_process): Add (:file "file") as an option for
2989 the STDOUT buffer.
2990 (Fcall_process_region): Ditto.
2991
330d880c
EZ
29922011-04-30 Eli Zaretskii <eliz@gnu.org>
2993
8db90b73
EZ
2994 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2995 rather than `XVECTOR (FOO)->size'.
2996
330d880c
EZ
2997 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2998 inttypes.h, as a gnulib replacement is used if it not available in
2999 system headers.
3000
15cbd324
EZ
30012011-04-21 Eli Zaretskii <eliz@gnu.org>
3002
3003 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3004 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3005 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3006
3007 * coding.c (coding_alloc_by_realloc): Error out if destination
3008 will grow beyond MOST_POSITIVE_FIXNUM.
3009 (decode_coding_emacs_mule): Abort if there isn't enough place in
3010 charbuf for the composition carryover bytes. Reserve an extra
3011 space for up to 2 characters produced in a loop.
3012 (decode_coding_iso_2022): Abort if there isn't enough place in
3013 charbuf for the composition carryover bytes.
3014
30152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3016
ae940cca
EZ
3017 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3018 aborting when %lld or %lll format is passed.
3019 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3020 %llo or %llx format is passed. (Bug#8545)
3021
03ab8921
EZ
3022 * window.c (window_scroll_line_based): Use a marker instead of
3023 simple variables to record original value of point. (Bug#7952)
3024
afda1437
EZ
3025 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3026 produced by %s or %c overflows available buffer space. (Bug#8545)
3027
f76dee0c
PE
30282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3031 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3032
fdc5744d
JB
30332011-04-28 Juanma Barranquero <lekktu@gmail.com>
3034
3035 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3036
638f053a
JB
30372011-04-28 Juanma Barranquero <lekktu@gmail.com>
3038
3039 * keyboard.c (Qdelayed_warnings_hook): Define.
3040 (command_loop_1): Run `delayed-warnings-hook'
3041 if Vdelayed_warnings_list is non-nil.
3042 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3043 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3044
d178f871
EZ
30452011-04-28 Eli Zaretskii <eliz@gnu.org>
3046
3047 * doprnt.c (doprnt): Don't return value smaller than the buffer
3048 size if the message was truncated. (Bug#8545).
3049
b124fd93
JB
30502011-04-28 Juanma Barranquero <lekktu@gmail.com>
3051
3052 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3053 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3054
e810457d
PE
30552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3058
ea51cceb
JB
30592011-04-27 Juanma Barranquero <lekktu@gmail.com>
3060
3061 * makefile.w32-in: Update dependencies.
3062
94dcfacf
EZ
30632011-04-27 Eli Zaretskii <eliz@gnu.org>
3064
3065 Improve `doprnt' and its usage. (Bug#8545)
3066 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3067 `format_end'. Remove support for %l as a conversion specifier.
3068 Don't use xrealloc. Improve diagnostics when the %l size modifier
3069 is used. Update the commentary.
3070
3071 * eval.c (verror): Simplify calculation of size_t.
3072
3073 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3074 messages.
3075
f61f41d7
PE
30762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3077
3078 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3079 change.
3080
96fb4434
PE
30812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3084 This makes this file independent of the recent pseudovector change.
3085
671875da 30862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3087
69e9b5a3
PE
3088 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3089
b5f869a7 3090 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3091 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3092 Remove unused local.
c8926152 3093 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3094
841a1577 3095 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3096 GCC 4.6.0 optimizes based on type-based alias analysis.
3097 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3098 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3099 != &v->size, and therefore "v->size = 1; b->size = 2; return
3100 v->size;" must therefore return 1. This assumption is incorrect
3101 for Emacs, since it type-puns struct Lisp_Vector * with many other
3102 types. To fix this problem, this patch adds a new type struct
f904488f 3103 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3104 and pseudovectors, and helps optimizing compilers not get fooled
3105 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3106 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3107 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3108 the size member.
eab3844f
PE
3109 (XSETPVECTYPE): Rewrite in terms of new macro.
3110 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3111 This is a bit clearer, and further avoids the possibility of
3112 undesirable aliasing.
3113 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3114 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3115 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3116 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3117 (ASIZE): Now uses header.size rather than size.
3118 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3119 to avoid the hassle of writing XVECTOR (foo)->header.size.
3120 (struct vectorlike_header): New type.
eab3844f
PE
3121 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3122 object, to help avoid aliasing.
3123 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3124 (SUBRP): Likewise, since Lisp_Subr is a special case.
3125 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3126 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3127 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3128 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3129 changed to be "header.size" and "header.next".
3130 * buffer.h (struct buffer): Likewise.
3131 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3132 * frame.h (struct frame): Likewise.
3133 * process.h (struct Lisp_Process): Likewise.
3134 * termhooks.h (struct terminal): Likewise.
3135 * window.c (struct save_window_data, struct saved_window): Likewise.
3136 * window.h (struct window): Likewise.
3137 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3138 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3139 * buffer.c (init_buffer_once): Likewise.
3140 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3141 special case.
3142 * process.c (Fformat_network_address): Use local var for size,
3143 for brevity.
3144
0df1eac5
PE
3145 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3146
847ab9d1 3147 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3148 * data.c (atof): Remove decl; no longer used or needed.
3149 (digit_to_number): Move to lread.c.
3150 (Fstring_to_number): Use new string_to_number function, to be
3151 consistent with how the Lisp reader treats infinities and NaNs.
3152 Do not assume that floating-point numbers represent EMACS_INT
3153 without losing information; this is not true on most 64-bit hosts.
3154 Avoid double-rounding errors, by insisting on integers when
3155 parsing non-base-10 numbers, as the documentation specifies.
3156 * lisp.h (string_to_number): New decl, replacing ...
3157 (isfloat_string): Remove.
bc0a5c13 3158 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3159 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3160 appears to have been a coding error. Similarly, do not accept
3161 strings like +-1e0 as floating point numbers. Do not report
3162 overflow for integer overflows unless the base is not 10 which
3163 means we have no simple and reliable way to continue.
3164 Break out the floating-point parsing into a new
3165 function string_to_number, so that Fstring_to_number parses
3166 floating point numbers consistently with the Lisp reader.
04f2d78b 3167 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3168 (E_CHAR, EXP_INT): Remove, replacing with ...
3169 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3170 (string_to_number): New function, replacing isfloat_string.
3171 This function checks for valid syntax and produces the resulting
3172 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3173 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3174 so that overflow for non-base-10 numbers is reported only when
3175 there's no portable and simple way to convert to floating point.
452f4150 3176
67769ffc
PE
3177 * textprop.c (set_text_properties_1): Rewrite for clarity,
3178 and to avoid GCC warning about integer overflow.
3179
c20db43f
PE
3180 * intervals.h (struct interval): Use EMACS_INT for members
3181 where EMACS_UINT might cause problems. See
3182 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3183 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3184 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3185 All uses changed.
37aa2f85
PE
3186 (offset_intervals): Tell GCC not to worry about length overflow
3187 when negating a negative length.
c20db43f 3188
2538aa2f
PE
3189 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3190 (overrun_check_free): Likewise.
3191
f2d3008d
PE
3192 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3193 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3194 word size.
3195
ec8df744
PE
3196 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3197 (gnutls_make_error): Rename local to avoid shadowing.
3198 (gnutls_emacs_global_deinit): ifdef out; not used.
3199 (Fgnutls_boot): Use const for pointer to readonly storage.
3200 Comment out unused local. Fix pointer signedness problems.
3201
640ee02d
PE
3202 * lread.c (openp): Don't stuff size_t into an 'int'.
3203 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3204 about possible signed overflow.
3205
6048fb2a
PE
3206 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3207 (GDK_KEY_g): Don't define if already defined.
3208 (xg_prepare_tooltip): Avoid pointer signedness problem.
3209 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3210
fa3c87e1
PE
3211 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3212 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3213
2172544b
PE
3214 * xfns.c (Fx_window_property): Simplify a bit,
3215 to make a bit faster and to avoid GCC 4.6.0 warning.
3216 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3217
9b821a21
PE
3218 * fns.c (internal_equal): Don't assume size_t fits in int.
3219
3c616cfa
PE
3220 * alloc.c (compact_small_strings): Tighten assertion a little.
3221
c2982e87
PE
3222 Replace pEd with more-general pI, and fix some printf arg casts.
3223 * lisp.h (pI): New macro, generalizing old pEd macro to other
3224 conversion specifiers. For example, use "...%"pI"d..." rather
3225 than "...%"pEd"...".
3226 (pEd): Remove. All uses replaced with similar uses of pI.
3227 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3228 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3229 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3230 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3231 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3232 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3233 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3234 64-bit hosts.
3235 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3236 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3237 * print.c (safe_debug_print, print_object): Likewise.
3238 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3239 to int.
6f04d126
PE
3240 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3241 avoiding the 0 flag, which is not portable.
c2982e87
PE
3242 * process.c (Fmake_network_process): Use pI to avoid cast.
3243 * region-cache.c (pp_cache): Likewise.
3244 * xdisp.c (decode_mode_spec): Likewise.
3245 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3246 behavior on 64-bit hosts with printf arg.
6f04d126 3247 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3248 (x_stop_queuing_selection_requests): Likewise.
3249 (x_get_window_property): Don't truncate byte count to an 'int'
3250 when tracing.
0b432f21 3251
5e073ec7
PE
3252 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3253 here, since it parses constructs like leading '-' and spaces,
3254 which are not wanted; and it overflows with large numbers.
3255 Instead, simply match F[0-9]+, which is what is wanted anyway.
3256
36372bf9
PE
3257 * alloc.c: Remove unportable assumptions about struct layout.
3258 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3259 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3260 (allocate_vectorlike, make_pure_vector): Use the new macros,
3261 plus offsetof, to remove unportable assumptions about struct layout.
3262 These assumptions hold on all porting targets that I know of, but
3263 they are not guaranteed, they're easy to remove, and removing them
3264 makes further changes easier.
3265
0b432f21
PE
3266 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3267 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3268 (string_overrun_cookie): Now const. Use initializers that
3269 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3270 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3271 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3272 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3273 multiple of sizeof (EMACS_INT); it need not be, if
3274 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3275 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3276
895009e1
JB
32772011-04-26 Juanma Barranquero <lekktu@gmail.com>
3278
3279 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3280
6a7a1b0b
TZ
32812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3282
3283 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3284 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3285 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3286
841a1577 32872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3288
3289 * lisp.h (Qdebug): List symbol.
895009e1 3290 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3291 * keyboard.c (debug-on-event): New variable.
3292 (handle_user_signal): Break into debugger when debug-on-event
3293 matches the current signal symbol.
3294
f2d3ba6f
DN
32952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3296
3297 * alloc.c (check_sblock, check_string_bytes)
3298 (check_string_free_list): Convert to standard C.
3299
42ce4c63
TZ
33002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3301
3302 * w32.c (emacs_gnutls_push): Fix typo.
3303
825cd63c
EZ
33042011-04-25 Eli Zaretskii <eliz@gnu.org>
3305
fb11d64d
EZ
3306 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3307 "cast to pointer from integer of different size".
3308
825cd63c
EZ
3309 Improve doprnt and its use in verror. (Bug#8545)
3310 * doprnt.c (doprnt): Document the set of format control sequences
3311 supported by the function. Use SAFE_ALLOCA instead of always
3312 using `alloca'.
3313
3314 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3315 is one byte too soon. Don't use xrealloc; instead xfree and
3316 xmalloc anew.
3317
e061a11b
TZ
33182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3319
3320 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3321 callbacks stage.
3322
3323 * gnutls.c: Renamed global_initialized to
3324 gnutls_global_initialized. Added internals for the
3325 :verify-hostname-error, :verify-error, and :verify-flags
3326 parameters of `gnutls-boot' and documented those parameters in the
3327 docstring. Start callback support.
9173deec
JB
3328 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3329 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3330 on error. Return error code.
e061a11b
TZ
3331 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3332 (emacs_gnutls_read): Likewise.
3333 (Fgnutls_boot): Return handshake error code.
3334 (emacs_gnutls_handle_error): New function.
3335 (wsaerror_to_errno): Likewise.
3336
3337 * w32.h (emacs_gnutls_pull): Add prototype.
3338 (emacs_gnutls_push): Likewise.
3339
3340 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3341 (emacs_gnutls_push): Likewise.
3342
33432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3344
3345 * process.c (wait_reading_process_output): Check if GnuTLS
3346 buffered some data internally if no FDs are set for TLS
3347 connections.
3348
3349 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3350 (LIBS): Link to USER_LIBS.
3351 ($(BLD)/gnutls.$(0)): New target.
3352
fa6996bc
EZ
33532011-04-24 Eli Zaretskii <eliz@gnu.org>
3354
eb35682e
EZ
3355 * xdisp.c (handle_single_display_spec): Rename the
3356 display_replaced_before_p argument into display_replaced_p, to
3357 make it consistent with the commentary. Fix typos in the
3358 commentary.
3359
e2ad650c
EZ
3360 * textprop.c (syms_of_textprop): Remove dead code.
3361 (copy_text_properties): Delete obsolete commentary about an
3362 interface that was deleted long ago. Fix typos in the description
3363 of arguments.
3364
1b2de274
EZ
3365 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3366 to changes in oldXMenu/XMenu.h from 2011-04-16.
3367 <menu_help_message, prev_menu_help_message>: Constify.
3368 (IT_menu_make_room): menu->help_text is now `const char **';
3369 adjust.
3370
3371 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3372 to changes in oldXMenu/XMenu.h from 2011-04-16.
3373 (struct XMenu): Declare `help_text' `const char **'.
3374
3375 * xfaces.c <Qunspecified>: Make extern again.
3376
3377 * syntax.c: Include sys/types.h before including regex.h, as
3378 required by Posix.
3379
762b15be
EZ
3380 * doc.c (get_doc_string): Improve the format passed to `error'.
3381
3382 * doprnt.c (doprnt): Improve commentary.
3383
3384 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3385
3386 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3387 them with etags.
3388
f1052e5d
EZ
3389 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3390 changes in globals.h immediately force recompilation.
762b15be
EZ
3391 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3392 $(CURDIR)/s/ms-w32.h.
3393 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3394
fa6996bc
EZ
3395 * character.c (Fchar_direction): Function deleted.
3396 (syms_of_character): Don't defsubr it.
3397 <char-direction-table>: Deleted.
3398
e6c3da20
EZ
33992011-04-23 Eli Zaretskii <eliz@gnu.org>
3400
3401 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3402 * doprnt.c: Include limits.h.
3403 (SIZE_MAX): New macro.
04f2d78b
CB
3404 (doprnt): Return a size_t value. 2nd arg is now size_t.
3405 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3406 Improve overflow protection. Support `l' modifier for integer
3407 conversions. Support %l conversion. Don't assume an EMACS_INT
3408 argument for integer conversions and for %c.
3409
3410 * lisp.h (doprnt): Restore prototype.
3411
3412 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3413 $(SRC)/character.h.
3414
3415 * Makefile.in (base_obj): Add back doprnt.o.
3416
3417 * deps.mk (doprnt.o): Add back prerequisites.
3418 (callint.o): Depend on character.h.
3419
3420 * eval.c (internal_lisp_condition_case): Include the handler
3421 representation in the error message.
3422 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3423 when breaking from the loop.
3424
3425 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3426
3427 * callint.c (Fcall_interactively): When displaying error message
3428 about invalid control letter, pass the character's codepoint, not
3429 a pointer to its multibyte form. Improve display of the character
3430 in octal and display also its hex code.
3431
3432 * character.c (char_string): Use %x to display the (unsigned)
3433 codepoint of an invalid character, to avoid displaying a bogus
3434 negative value.
3435
3436 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3437 `error', not SYMBOL_NAME itself.
3438
3439 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3440 character arguments to `error'.
3441
3442 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3443 to `error' in error message about FINAL_CHAR argument. Make sure
3444 FINAL_CHAR is a character, and use %c when it is passed as
3445 argument to `error'.
3446
4ffd0d6b 34472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3448
3449 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3450
3451 * w32.c: Include <time.h>.
3452 (sys_localtime): New function.
3453
4ffd0d6b 34542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3455
3456 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3457
4ffd0d6b 3458 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3459
4ffd0d6b 34602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3461
4ffd0d6b
GM
3462 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3463 zombies (Bug#8467).
aac0c6e3 3464
04c56954
EZ
34652011-04-19 Eli Zaretskii <eliz@gnu.org>
3466
3467 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3468 gl_state.e_property when gl_state.object is Qt.
3469
3470 * insdel.c (make_gap_larger): Remove limitation of buffer size
3471 to <= INT_MAX.
3472
16a43933
CY
34732011-04-18 Chong Yidong <cyd@stupidchicken.com>
3474
3475 * xdisp.c (lookup_glyphless_char_display)
3476 (produce_glyphless_glyph): Handle cons cell entry in
3477 glyphless-char-display.
3478 (Vglyphless_char_display): Document it.
3479
3480 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3481 glyphless-char-display.
3482
4581706e
CY
34832011-04-17 Chong Yidong <cyd@stupidchicken.com>
3484
3485 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3486
3487 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3488
3489 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3490 definition for no-X builds.
3491
4887c6e2 34922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3493
fd35b6f9
PE
3494 Static checks with GCC 4.6.0 and non-default toolkits.
3495
5c1ccb01
PE
3496 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3497
006c5daa
PE
3498 * process.c (keyboard_bit_set): Define only if SIGIO.
3499 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3500 (send_process): Repair possible setjmp clobbering.
3501
efc736d3
PE
3502 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3503
4e2fe2e6
PE
3504 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3505
f97334a2
PE
3506 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3507
4e75f29d
PE
3508 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3509 Define only if needed.
3510
90efadd1
PE
3511 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3512 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3513 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3514
3c647824
PE
3515 * dispextern.h (struct redisplay_interface): Rename param
3516 to avoid shadowing.
e264f262 3517 * termhooks.h (struct terminal): Likewise.
761383f4 3518 * xterm.c (xembed_send_message): Likewise.
3c647824 3519
b58c5c4a
PE
3520 * insdel.c (make_gap_smaller): Define only if
3521 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3522
cad59032
PE
3523 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3524 it.
3525
c339dc2e
PE
3526 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3527 so that we aren't warned about unused symbols.
3528
91a3e27b
PE
3529 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3530
399c71d3 3531 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3532
8ffc96f5
PE
3533 * xfns.c (x_real_positions): Mark locals as initialized.
3534
eef9bc79
PE
3535 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3536
098db9dd
PE
3537 * xterm.c: Fix problems found by static analysis with other toolkits.
3538 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3539 (x_dispatch_event): Declare static if USE_GTK, and
3540 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3541 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3542 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3543 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3544 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3545
eb18f6cc
PE
3546 * xmenu.c (menu_help_callback): Pointer type fixes.
3547 Use const pointers when pointing at readonly data. Avoid pointer
3548 signedness clashes.
3549 (FALSE): Remove unused macro.
3550 (update_frame_menubar): Remove unused decl.
3551
1fe72bf8
PE
3552 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3553
60d9e1db
PE
3554 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3555 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3556 (single_menu_item): Rename local to avoid shadowing.
3557
39261c26
PE
3558 * keyboard.c (make_lispy_event): Remove unused local var.
3559
018c5e19
PE
3560 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3561 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3562
63d2b86e
PE
3563 * bitmaps: Change bitmaps from unsigned char back to the X11
3564 compatible char. Avoid the old compiler warnings about
3565 out-of-range initializers by using, for example, '\xab' rather
3566 than 0xab.
3567
aefd87e1
PE
3568 * xgselect.c (xgselect_initialize): Check vs interface
3569 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3570
bf501fb9
PE
3571 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3572
e9829fdf
PE
3573 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3574 to read-only memory.
3575
1086c095
PE
3576 * fns.c (vector): Remove; this old hack is no longer needed.
3577
2baccd04 3578 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3579 Remove unused var.
dde42981 3580 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3581
72391843 3582 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3583
436c16df 3584 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3585 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3586 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3587
92bb796d 3588 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3589 (x_term_init): Remove local to avoid shadowing.
92bb796d 3590
764430a3 3591 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3592
3593 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3594 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3595
d1dfb56c
EZ
35962011-04-16 Eli Zaretskii <eliz@gnu.org>
3597
c4354cb4
EZ
3598 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3599
d1dfb56c
EZ
3600 Fix regex.c, syntax.c and friends for buffers > 2GB.
3601 * syntax.h (struct gl_state_s): Declare character position members
3602 EMACS_INT.
3603
3604 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3605
04f2d78b
CB
3606 * textprop.c (verify_interval_modification, interval_of):
3607 Declare arguments EMACS_INT.
d1dfb56c
EZ
3608
3609 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3610 EMACS_INT.
3611
3612 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3613
3614 * indent.c (Fvertical_motion): Local variable it_start is now
3615 EMACS_INT.
3616
3617 * regex.c (re_match, re_match_2, re_match_2_internal)
3618 (bcmp_translate, regcomp, regexec, print_double_string)
3619 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3620 (re_compile_pattern, re_exec): Declare arguments and local
3621 variables `size_t' and `ssize_t' and return values `regoff_t', as
3622 appropriate.
3623 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3624 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3625 <compile_stack_type>: `size' and `avail' are now `size_t'.
3626
3627 * regex.h <regoff_t>: Use ssize_t, not int.
3628 (re_search, re_search_2, re_match, re_match_2): Arguments that
3629 specify buffer/string position and length are now ssize_t and
3630 size_t. Return type is regoff_t.
3631
613052cd
BK
36322011-04-16 Ben Key <bkey76@gmail.com>
3633
3634 * nsfont.m: Fixed bugs in ns_get_family and
3635 ns_descriptor_to_entity that were caused by using free to
3636 deallocate memory blocks that were allocated by xmalloc (via
3637 xstrdup). This caused Emacs to crash when compiled with
3638 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3639 --enable-checking=xmallocoverrun). xfree is now used to
3640 deallocate these memory blocks.
3641
4170f62f 36422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3643
71b41406
PE
3644 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3645
9587a89d
PE
3646 emacs_write: Accept and return EMACS_INT for sizes.
3647 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3648 et seq.
3649 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3650 Accept and return EMACS_INT.
3651 (emacs_gnutls_write): Return the number of bytes written on
3652 partial writes.
3653 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3654 (emacs_read, emacs_write): Remove check for negative size, as the
3655 Emacs source code has been audited now.
9587a89d
PE
3656 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3657 (emacs_read, emacs_write): Use it.
273a5f82
PE
3658 * process.c (send_process): Adjust to the new signatures of
3659 emacs_write and emacs_gnutls_write. Do not attempt to store
3660 a byte offset into an 'int'; it might overflow.
9587a89d 3661 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3662
3e047f51
PE
3663 * sound.c: Don't assume sizes fit in 'int'.
3664 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3665 Return EMACS_INT, not int.
3e047f51 3666 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3667 Accept EMACS_INT, not int.
3668 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3669 record read return values.
3670
cc39a9db
BK
36712011-04-15 Ben Key <bkey76@gmail.com>
3672
c9d0ec6d
JB
3673 * keyboard.c (Qundefined): Don't declare static since it is used
3674 in nsfns.m.
3675 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3676 static since they are used in nsfont.m.
cc39a9db 3677
6c60eb9f
SM
36782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3679
3680 * process.c (Qprocessp): Don't declare static.
3681 * lisp.h (Qprocessp): Declare again.
3682
7990b61a
JB
36832011-04-15 Juanma Barranquero <lekktu@gmail.com>
3684
3685 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3686
5d4cb038
PE
36872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3688
8bd7b830 3689 Improve C-level modularity by making more things 'static'.
cd64ea1d 3690
e3b27b31
PE
3691 Don't publish debugger-only interfaces to other modules.
3692 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3693 (verify_bytepos, count_markers): Move decls to the only modules
3694 that need them.
3695 * region-cache.h (pp_cache): Likewise.
3696 * window.h (check_all_windows): Likewise.
3697 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3698
5d4cb038
PE
3699 * sysdep.c (croak): Now static, if
3700 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3701 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3702
3703 * alloc.c (refill_memory_reserve): Now static if
3704 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3705 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3706
e87b6180
PE
3707 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3708 Define only if USE_LUCID.
3709
ac64929e
PE
3710 * xrdb.c (x_customization_string, x_rm_string): Now static.
3711
6f37259d
PE
3712 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3713 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3714
1683e3ab
PE
3715 * xdisp.c (draw_row_with_mouse_face): Now static.
3716 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3717
de9c2632
PE
3718 * window.h (check_all_windows): Mark externally visible.
3719
2b96acb7
PE
3720 * window.c (window_deletion_count): Now static.
3721
3722 * undo.c: Make symbols static if they're not exported.
3723 (last_undo_buffer, last_boundary_position, pending_boundary):
3724 Now static.
3725
50436f33
PE
3726 * textprop.c (interval_insert_behind_hooks): Now static.
3727 (interval_insert_in_front_hooks): Likewise.
3728
64520e5c
PE
3729 * term.c: Make symbols static if they're not exported.
3730 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3731 (max_frame_lines, tty_set_terminal_modes):
3732 (tty_reset_terminal_modes, tty_turn_off_highlight):
3733 (get_tty_terminal): Now static.
3734 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3735 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3736 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3737 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3738 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3739
1fa53021
PE
3740 * sysdep.c: Make symbols static if they're not exported.
3741 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3742 Now static.
3743 (sigprocmask_set, full_mask): Remove; unused.
3744 (wait_debugging): Mark as visible.
3745 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3746 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3747
d4b43b22
PE
3748 * syntax.c (syntax_temp): Define only if !__GNUC__.
3749
b7c513d0
PE
3750 * sound.c (current_sound_device, current_sound): Now static.
3751
989b29ad
PE
3752 * search.c (searchbufs, searchbuf_head): Now static.
3753
13a55a78
PE
3754 * scroll.c (scroll_cost): Remove; unused.
3755 * dispextern.h (scroll_cost): Remove decl.
3756
de68a1fc
PE
3757 * region-cache.h (pp_cache): Mark as externally visible.
3758
40ccffa6
PE
3759 * process.c: Make symbols static if they're not exported.
3760 (process_tick, update_tick, create_process, chan_process):
3761 (Vprocess_alist, proc_buffered_char, datagram_access):
3762 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3763 (deactivate_process): Mark defn as static, as well as decl.
3764 * lisp.h (create_process): Remove decl.
3765 * process.h (chan_process, Vprocess_alist): Remove decls.
3766
ad64fc97
PE
3767 * print.c: Make symbols static if they're not exported.
3768 (print_depth, new_backquote_output, being_printed, print_buffer):
3769 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3770 (print_interval, print_number_index, initial_stderr_stream):
3771 Now static.
3772 * lisp.h (Fprinc): Remove decl.
3773 (debug_output_compilation_hack): Mark as externally visible.
3774
adddb265
PE
3775 * sysdep.c (croak): Move decl from here to syssignal.h.
3776 * syssignal.h (croak): Put it here, so the API can be checked when
3777 'croak' is called from dissociate_if_controlling_tty.
3778
1717ede2
PE
3779 * minibuf.c: Make symbols static if they're not exported.
3780 (minibuf_save_list, choose_minibuf_frame): Now static.
3781 * lisp.h (choose_minibuf_frame): Remove decl.
3782
fa5fb2bc
PE
3783 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3784
1e3890d1
PE
3785 * lread.c: Make symbols static if they're not exported.
3786 (read_objects, initial_obarray, oblookup_last_bucket_number):
3787 Now static.
3788 (make_symbol): Remove; unused.
3789 * lisp.h (initial_obarray, make_symbol): Remove decls.
3790
8a1414fa
PE
3791 * keyboard.c: Make symbols static if they're not exported.
3792 (single_kboard, recent_keys_index, total_keys, recent_keys):
3793 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3794 (this_single_command_key_start, echoing, last_auto_save):
3795 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3796 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3797 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3798 (Vlispy_mouse_stem, double_click_count):
3799 Now static.
3800 (force_auto_save_soon): Define only if SIGDANGER.
3801 (ignore_mouse_drag_p): Now static if
3802 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3803 (print_help): Remove; unused.
3804 (stop_character, last_timer_event): Mark as externally visible.
3805 * keyboard.h (ignore_mouse_drag_p): Declare only if
3806 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3807 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3808 * lisp.h (echoing): Remove decl.
3809 (force_auto_save_soon): Declare only if SIGDANGER.
3810 * xdisp.c (redisplay_window): Simplify code, to make it more
3811 obvious that ignore_mouse_drag_p is not accessed if !defined
3812 USE_GTK && !defined HAVE_NS.
3813
93ea6e8f
PE
3814 * intervals.c: Make symbols static if they're not exported.
3815 (merge_properties_sticky, merge_interval_right, delete_interval):
3816 Now static.
3817 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3818
77382fcc
PE
3819 * insdel.c: Make symbols static if they're not exported.
3820 However, leave prepare_to_modify_buffer alone. It's never
3821 called from outside this function, but that appears to be a bug.
3822 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3823 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3824 (adjust_after_replace_noundo): Remove; unused.
3825 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3826 (signal_before_change): Remove decls.
77382fcc 3827
9306c32e
PE
3828 * indent.c (val_compute_motion, val_vmotion): Now static.
3829
cd44d2eb
PE
3830 * image.c: Make symbols static if they're not exported.
3831 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3832 if USE_GTK.
3833 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3834 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3835
ad9a7a06
PE
3836 * fringe.c (standard_bitmaps): Now static.
3837 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3838
81626931
PE
3839 * frame.c: Make symbols static if they're not exported.
3840 (x_report_frame_params, make_terminal_frame): Now static.
3841 (get_frame_param): Now static, unless HAVE_NS.
3842 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3843 (x_get_resource_string): Remove; not used.
3844 * frame.h (make_terminal_frame, x_report_frame_params):
3845 (x_get_resource_string); Remove decls.
3846 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3847 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3848
239f9db9
PE
3849 * font.c, fontset.c: Make symbols static if they're not exported.
3850 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3851 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3852 * font.c (font_close_object): Now static.
3853 * font.h (font_close_object): Remove.
3854 * fontset.c (FONTSET_OBJLIST): Remove.
3855 (free_realized_fontset) #if-0 the body, which does nothing.
3856 (face_suitable_for_char_p): #if-0, as it's never called.
3857 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3858 * xfaces.c (face_at_string_position):
3859 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3860 since 0 is always ASCII.
3861
dfcf3579
PE
3862 * fns.c (weak_hash_tables): Now static.
3863
5045092b
PE
3864 * fileio.c: Make symbols static if they're not exported.
3865 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3866 (Vwrite_region_annotation_buffers): Now static.
3867
57a96f5c
PE
3868 * eval.c: Make symbols static if they're not exported.
3869 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3870 * lisp.h (backtrace_list): Remove decl.
3871
35f08c38
PE
3872 * emacs.c: Make symbols static if they're not exported.
3873 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3874 (fatal_error_code, fatal_error_signal_hook, standard_args):
3875 Now static.
3876 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3877 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3878 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3879 * lisp.h (fatal_error_signal_hook): Remove decl.
3880 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3881
f44bd759
PE
3882 * editfns.c: Move a (normally-unused) function to its only use.
3883 * editfns.c, lisp.h (get_operating_system_release): Remove.
3884 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3885 worth the hassle of breaking this out.
3886
b532497d
PE
3887 * xterm.c: Make symbols static if they're not exported.
3888 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3889 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3890 (x_destroy_window, x_delete_display):
3891 Now static.
3892 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3893 (x_mouse_leave): Remove; unused.
3894 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3895 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3896 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3897 Remove decls.
3898 (x_mouse_leave): Declare only if WINDOWSNT.
3899 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3900 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3901 USE_X_TOOLKIT.
3902
1675728f
PE
3903 * ftxfont.c: Make symbols static if they're not exported.
3904 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3905 HAVE_FREETYPE.
3906 * font.h (ftxfont_driver): Likewise.
3907
e4cebfca
PE
3908 * xfns.c: Make symbols static if they're not exported.
3909 (x_last_font_name, x_display_info_for_name):
3910 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3911 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3912 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3913 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3914 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3915 (last_show_tip_args): Now static.
3916 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3917 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3918 (x_screen_planes): Remove; unused.
3919 * dispextern.h (x_screen_planes): Remove decl.
3920
5bf46f05
PE
3921 * dispnew.c: Make symbols static if they're not exported.
3922 * dispextern.h (redraw_garbaged_frames, scrolling):
3923 (increment_row_positions): Remove.
3924 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3925 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3926 Now static.
3927 (redraw_garbaged_frames): Remove; unused.
3928
435f4c28
PE
3929 * xfaces.c: Make symbols static if they're not exported.
3930 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3931 Remove decls.
3932 * xterm.h (defined_color): Remove decls.
3933 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3934 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3935 (menu_face_changed_default, defined_color, free_realized_face):
3936 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3937 (ascii_face_of_lisp_face): Remove; unused.
3938
8524aef3
PE
3939 * xdisp.c: Make symbols static if they're not exported.
3940 * dispextern.h (scratch_glyph_row, window_box_edges):
3941 (glyph_to_pixel_coords, set_cursor_from_row):
3942 (get_next_display_element, set_iterator_to_next):
3943 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3944 (show_mouse_face): Remove decls
3945 * frame.h (message_buf_print): Likewise.
3946 * lisp.h (pop_message, set_message, check_point_in_composition):
3947 Likewise.
3948 * xterm.h (set_vertical_scroll_bar): Likewise.
3949 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3950 (message_buf_print, scratch_glyph_row, displayed_buffer):
3951 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3952 (get_next_display_element, show_mouse_face, window_box_edges):
3953 (frame_to_window_pixel_xy, check_point_in_composition):
3954 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3955 (glyph_to_pixel_coords): Remove; unused.
3956
16390cd2
PE
3957 * dired.c (file_name_completion): Now static.
3958
3959 * dbusbind.c (xd_in_read_queued_messages): Now static.
3960
a25f4dfa
PE
3961 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3962 * data.c (circular_list_error): Remove.
3963
14a9c8df
PE
3964 * commands.h (last_point_position, last_point_position_buffer):
3965 (last_point_position_window): Remove decls.
3966 * keyboard.c: Make these variables static.
3967
04f2d78b
CB
3968 * coding.h (coding, code_convert_region, encode_coding_gap):
3969 Remove decls.
74ab6df5
PE
3970 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3971 (iso_code_class, detect_coding, code_convert_region): Now static.
3972 (encode_coding_gap): Remove; unused.
3973
38dfbee1
PE
3974 * chartab.c (chartab_chars, chartab_bits): Now static.
3975
a2cb4e63
PE
3976 * charset.h (charset_iso_8859_1): Remove decl.
3977 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3978 Now static.
3979
127198fd
PE
3980 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3981 * ccl.c (Vccl_program_table): Now static.
3982 (check_ccl_update): Remove; unused.
3983
d85b608f
PE
3984 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3985 * category.h: ... from here.
3986 * category.c (check_category_table, set_category_set): Now static.
3987
31cd66f3
PE
3988 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3989 * lisp.h: Remove these decls.
3990
c358e587
PE
3991 * buffer.c (buffer_count): Remove unused var.
3992
e78aecca
PE
3993 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3994 so that it's not optimized away.
3995 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3996 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3997 exported only to the debugger.
3998
e192d7d3 3999 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4000 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4001
92470028
PE
4002 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4003 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4004 was inaccessible from Lisp.
4005 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4006 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4007
244ed907
PE
4008 alloc.c: Import and export fewer symbols, and remove unused items.
4009 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4010 is defined.
4011 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4012 it's not optimized away by whole-program optimization.
4013 (message_enable_multibyte, free_misc): Remove.
4014 (catchlist, handlerlist, mark_backtrace):
4015 Declare only if BYTE_MARK_STACK.
4016 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4017 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4018 (message_enable_multibyte): Remove decl.
4019 (free_misc, interval_free_list, float_block, float_block_index):
4020 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4021 (cons_free_list, last_marked_index):
4022 Now static.
4023 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4024 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4025 (mark_backtrace): Define only if BYTE_MARK_STACK.
4026 * xdisp.c (message_enable_multibyte): Now static.
4027
61c2b50e 4028 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4029 This makes it easier for human readers (and static analyzers)
4030 to see whether these variables are used from other modules.
4031 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4032 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4033 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4034 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4035 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4036 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4037 * xmenu.c, xselect.c:
4038 Declare Q* vars static if they are not used in other modules.
4039 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4040 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4041 Remove decls of unexported vars.
4042 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4043
95c82688
PE
4044 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4045
16a97296
PE
4046 Make Emacs functions such as Fatom 'static' by default.
4047 This makes it easier for human readers (and static analyzers)
4048 to see whether these functions can be called from other modules.
4049 DEFUN now defines a static function. To make the function external
4050 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4051 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4052 (Finit_image_library):
16a97296
PE
4053 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4054 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4055 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4056 Remove decls, since these functions are now static.
4057 (Funintern, Fget_internal_run_time): New decls, since these functions
4058 were already external.
95c82688 4059
16a97296
PE
4060 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4061 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4062 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4063 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4064 * keyboard.c, keymap.c, lread.c:
4065 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4066 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4067 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4068 Mark functions with DEFUE instead of DEFUN,
4069 if they are used in other modules.
4070 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4071 decls for now-static functions.
4072 * buffer.h (Fdelete_overlay): Remove decl.
4073 * callproc.c (Fgetenv_internal): Mark as internal.
4074 * composite.c (Fremove_list_of_text_properties): Remove decl.
4075 (Fcomposition_get_gstring): New forward static decl.
4076 * composite.h (Fcomposite_get_gstring): Remove decl.
4077 * dired.c (Ffile_attributes): New forward static decl.
4078 * doc.c (Fdocumntation_property): New forward static decl.
4079 * eval.c (Ffetch_bytecode): New forward static decl.
4080 (Funintern): Remove extern decl; now in .h file where it belongs.
4081 * fileio.c (Fmake_symbolic_link): New forward static decl.
4082 * image.c (Finit_image_library): New forward static decl.
4083 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4084 * intervals.h (Fprevious_property_change):
4085 (Fremove_list_of_text_properties): Remove decls.
4086 * keyboard.c (Fthis_command_keys): Remove decl.
4087 (Fcommand_execute): New forward static decl.
4088 * keymap.c (Flookup_key): New forward static decl.
4089 (Fcopy_keymap): Now static.
4090 * keymap.h (Flookup_key): Remove decl.
4091 * process.c (Fget_process): New forward static decl.
4092 (Fprocess_datagram_address): Mark as internal.
4093 * syntax.c (Fsyntax_table_p): New forward static decl.
4094 (skip_chars): Remove duplicate decl.
4095 * textprop.c (Fprevious_property_change): New forward static decl.
4096 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4097 Now internal.
4098 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4099 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4100
785bbd42
PE
4101 * editfns.c (Fformat): Remove unreachable code.
4102
8b913b57
AS
41032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4104
4105 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4106 change. (Bug#8496)
4107
a6744a35
EZ
41082011-04-13 Eli Zaretskii <eliz@gnu.org>
4109
4110 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4111 when at ZV. (Bug#8487)
4112
e7974947
AS
41132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4114
baad03f0
AS
4115 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4116 (Bug#8437)
4117 * keyboard.c (parse_tool_bar_item): Likewise.
4118 * sound.c (sound_cleanup, alsa_close): Likewise.
4119 * termcap.c (tgetent): Likewise.
4120 * xfns.c (x_default_font_parameter): Likewise.
4121 * xsettings.c (read_and_apply_settings): Likewise.
4122
e7974947
AS
4123 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4124 (overrun_check_free): Protoize.
4125
28272684
PE
41262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4127
4128 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4129 since callers should never pass a negative size.
4130 Change the signature to match that of plain 'read' and 'write'; see
4131 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4132 * lisp.h: Update prototypes of emacs_write and emacs_read.
4133
11997c76
EZ
41342011-04-11 Eli Zaretskii <eliz@gnu.org>
4135
4136 * xdisp.c (redisplay_window): Don't try to determine the character
4137 position of the scroll margin if the window start point w->startp
e896f03c 4138 is outside the buffer's accessible region. (Bug#8468)
11997c76 4139
8a2cbd72
EZ
41402011-04-10 Eli Zaretskii <eliz@gnu.org>
4141
4142 Fix write-region and its subroutines for buffers > 2GB.
4143 * fileio.c (a_write, e_write): Modify declaration of arguments and
4144 local variables to support buffers larger than 2GB.
4145 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4146
4147 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4148 argument, local variables, and return value.
4149
4150 * lisp.h: Update prototypes of emacs_write and emacs_read.
4151
4152 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4153
4073e537 41542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4155
1ebfdcb6
PE
4156 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4157
b2ded58d
PE
4158 Fix more problems found by GCC 4.6.0's static checks.
4159
7d66342c
PE
4160 * xdisp.c (vmessage): Use a better test for character truncation.
4161
bbf47d44
PE
4162 * charset.c (load_charset_map): <, not <=, for optimization,
4163 and to avoid potential problems with integer overflow.
9248994d 4164 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4165 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4166 * editfns.c (Fformat): Likewise.
1e69125e 4167 * syntax.c (skip_chars): Likewise.
3befa583 4168
e3019616
PE
4169 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4170 This also lets GCC 4.6.0 generate slightly better loop code.
4171
becfa255
PE
4172 * callint.c (Fcall_interactively): <, not <=, for optimization.
4173 (Fcall_interactively): Count the number of arguments produced,
4174 not the number of arguments given. This is simpler and lets GCC
4175 4.6.0 generate slightly better code.
4176
dae0cd48
PE
4177 * ftfont.c: Distingish more carefully between FcChar8 and char.
4178 The previous code passed unsigned char * to a functions like
4179 strlen and xstrcasecmp that expect char *, which does not
4180 conform to the C standard.
4181 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4182 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4183 char * when the C standard requires it.
4184
76032d70
PE
4185 * keyboard.c (read_char): Remove unused var.
4186
eb3f1cc8
PE
4187 * eval.c: Port to Windows vsnprintf (Bug#8435).
4188 Include <limits.h>.
4189 (SIZE_MAX): Define if the headers do not.
4190 (verror): Do not give up if vsnprintf returns a negative count.
4191 Instead, grow the buffer. This ports to Windows vsnprintf, which
4192 does not conform to C99. Problem reported by Eli Zaretskii.
4193 Also, simplify the allocation scheme, by avoiding the need for
4194 calling realloc, and removing the ALLOCATED variable.
4195
70476b54
PE
4196 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4197
12020a9e
PE
4198 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4199 But keep the doprint source code for now, as we might revamp it
4200 and use it again (Bug#8435).
ea6c7ae6
PE
4201 * lisp.h (doprnt): Remove.
4202 * Makefile.in (base_obj): Remove doprnt.o.
4203 * deps.mk (doprnt.o): Remove.
4204
5fdb398c
PE
4205 error: Print 32- and 64-bit integers portably (Bug#8435).
4206 Without this change, on typical 64-bit hosts error ("...%d...", N)
4207 was used to print both 32- and 64-bit integers N, which relied on
4208 undefined behavior.
4209 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4210 New macro.
4211 * lisp.h (error, verror): Mark as printf-like functions.
4212 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4213 Report overflow in size calculations when allocating printf buffer.
4214 Do not truncate output string at its first null byte.
4215 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4216 Truncate the output at a character boundary, since vsnprintf does not
4217 do that.
4218 * charset.c (check_iso_charset_parameter): Convert internal
4219 character to string before calling 'error', since %c now has the
4220 printf meaning.
4221 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4222 overflow when computing char to be passed to 'error'. Do not
4223 pass Lisp_Object to 'error'; pass the integer instead.
4224 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4225 formatted with plain %d.
4226
b189fa66
PE
4227 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4228
bff87ef0
PE
4229 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4230
7e2cac20
PE
4231 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4232
ce4d90b5
PE
4233 * xterm.c (x_catch_errors): Remove duplicate declaration.
4234
266c9547
PE
4235 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4236
79c49ad2
PE
4237 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4238
368f4090
JM
42392011-04-10 Jim Meyering <meyering@redhat.com>
4240
4241 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4242 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4243 return ssize_t not "int", and use size_t as the buffer length.
4244 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4245 * gnutls.h: Update declarations.
4246 * process.c (read_process_output): Use ssize_t, to match.
4247 (send_process): Likewise.
4248
a32d4040
CY
42492011-04-09 Chong Yidong <cyd@stupidchicken.com>
4250
4251 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4252
8546720e 42532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4254
04f2d78b
CB
4255 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4256 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4257
8546720e
GM
4258 * xterm.c (handle_one_xevent):
4259 * xmenu.c (create_and_show_popup_menu):
4260 * xselect.c (x_decline_selection_request)
4261 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4262
0a2f5c1a 42632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4264
4265 Fix some uses of `int' instead of EMACS_INT.
4266 * search.c (string_match_1, fast_string_match)
4267 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4268 (scan_buffer, find_next_newline_no_quit)
4269 (find_before_next_newline, search_command, Freplace_match)
4270 (Fmatch_data): Make some `int' variables be EMACS_INT.
4271
4272 * xdisp.c (display_count_lines): 3rd argument and return value now
4273 EMACS_INT. All callers changed.
4274 (pint2hrstr): Last argument is now EMACS_INT.
4275
4276 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4277 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4278 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4279 (decode_coding_utf_16, decode_coding_emacs_mule)
4280 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4281 (decode_coding_ccl, decode_coding_charset)
4282 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4283 (decode_coding_iso_2022, decode_coding_emacs_mule)
4284 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4285 <char_offset, last_offset>: Declare EMACS_INT.
4286 (encode_coding_utf_8, encode_coding_utf_16)
4287 (encode_coding_emacs_mule, encode_invocation_designation)
4288 (encode_designation_at_bol, encode_coding_iso_2022)
4289 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4290 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4291 Declare EMACS_INT.
4292 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4293 (encode_invocation_designation): Last argument P_NCHARS is now
4294 EMACS_INT.
4295 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4296 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4297
4298 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4299 All users changed.
4300
4301 * ccl.c (Fccl_execute_on_string): Declare some variables
4302 EMACS_INT.
4303
8546720e 43042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4305
4306 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4307
4e19a977
CS
43082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4309
4310 * process.c (Fformat_network_address): Doc fix.
4311
87302331
R
43122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4313
4314 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4315
cbb59342
CY
43162011-04-08 Chong Yidong <cyd@stupidchicken.com>
4317
4318 * keyboard.c (read_char): Call Lisp function help-form-show,
4319 instead of using internal_with_output_to_temp_buffer.
4320 (Qhelp_form_show): New var.
e0d38eeb 4321 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4322
4323 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4324
4325 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4326
e67a13ab
CY
43272011-04-06 Chong Yidong <cyd@stupidchicken.com>
4328
04f2d78b
CB
4329 * process.c (Flist_processes): Remove to Lisp.
4330 (list_processes_1): Delete.
e67a13ab 4331
973f782d
EZ
43322011-04-06 Eli Zaretskii <eliz@gnu.org>
4333
7c106b1e
EZ
4334 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4335
973f782d
EZ
4336 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4337
41cf7d1a 43382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4339
ca23cc88
PE
4340 Fix more problems found by GCC 4.6.0's static checks.
4341
f390e2d5
PE
4342 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4343
42eea0d0
PE
4344 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4345
b69769da 4346 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4347
f9541e84
PE
4348 * xdisp.c (vmessage): Mark as a printf-like function.
4349
13841b55
PE
4350 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4351
c136c10f
PE
4352 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4353
5e2d4a30
PE
4354 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4355 printf-like functions.
4356 (tiff_load): Add casts to remove these marks before passing them
4357 to system-supplied API.
4358
583f48b9
PE
4359 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4360
b25d760e
PE
4361 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4362 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4363 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4364 directly, rather than having caller test rule sign. This avoids
4365 some unnecessary tests.
4366 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4367 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4368 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4369
bc7b6697 4370 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4371 (xfont_open): Avoid unnecessary tests.
bc7b6697 4372
27ccc379
PE
4373 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4374
dcd5c89a
PE
4375 * composite.h, composite.c (composition_gstring_put_cache):
4376 Use EMACS_INT, not int, for length.
4377
b13a45c6
PE
4378 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4379 breaking out part of COMPOSITION_DECODE_RULE.
4380 (COMPOSITION_DECODE_RULE): Use it.
4381 * composite.c (get_composition_id): Remove unused local vars,
4382 by using the new macro.
4383
1e792e4d
PE
4384 * textprop.c (set_text_properties_1): Change while to do-while,
4385 since the condition is always true at first.
4386
dc6c6455 4387 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4388 (interval_deletion_adjustment): Return unsigned value.
4389 All uses changed.
dc6c6455 4390
aba7731a
PE
4391 * process.c (list_processes_1, create_pty, read_process_output):
4392 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4393 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4394 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4395 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4396 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4397
fdfc4bf3
PE
4398 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4399
fca8fe46 4400 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4401 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4402
06a0259a 4403 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4404 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4405 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4406
e7b9e80f
PE
4407 * print.c (print_error_message): Avoid int overflow.
4408
56201685
PE
4409 * font.c (font_list_entities): Redo for clarity,
4410 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4411
78834453 4412 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4413 (font_score): Avoid potential overflow in diff calculation.
78834453 4414
0bc0b309 4415 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4416 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4417
e610eaca
PE
4418 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4419
b895abce
PE
4420 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4421 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4422 can always succeed if overflow has undefined behavior.
4423
1f1d9321 4424 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4425 (wordify): Omit three unnecessary tests.
1f1d9321 4426
c59478bc
PE
4427 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4428 All callers changed. This avoids the need for an unused var.
4429
79b73827
PE
4430 * casefiddle.c (casify_region): Remove var that is set but not used.
4431
a4db5dfe
PE
4432 * dired.c (file_name_completion): Remove var that is set but not used.
4433
43aae36e
PE
4434 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4435
2a47c44d 4436 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4437 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4438
a37c69bf
PE
4439 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4440 Check for integer overflow on size calculations.
4441
328ab8e7
PE
4442 * buffer.c (Fprevious_overlay_change): Remove var that is set
4443 but not used.
4444
e5a2a5cb
PE
4445 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4446 Remove vars that are set but not used.
8d84a6eb 4447 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4448 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4449
a60e5f68
PE
4450 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4451
f661cb61 4452 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4453 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4454
f0397f5a
PE
4455 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4456 that are set but not used.
4457
8664db06 4458 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4459 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4460
6abdaa4a
PE
4461 * xselect.c (x_get_local_selection, x_handle_property_notify):
4462 Remove vars that are set but not used.
4463
0ce7538d 4464 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4465 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4466
9ae848fc
PE
4467 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4468 Remove var that is set but not used.
0b918413
PE
4469 (scroll_bar_windows_size): Now size_t, not int.
4470 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4471 Check for overflow.
9ae848fc 4472
a5a62657
PE
4473 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4474 (map_tty_color) [!defined MSDOS]: Likewise.
4475
5c5cdd39
PE
4476 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4477
66ebf983
PE
4478 * coding.c: Remove vars that are set but not used.
4479 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4480 All callers changed.
4481 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4482 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4483 (decode_coding_charset): Remove vars that are set but not used.
4484
1be4d761
PE
4485 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4486 that is set but not used.
4487
47553fa8
PE
4488 * print.c (print_object): Remove var that is set but not used.
4489
1f7196bf 4490 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4491 The gnulib version avoids calling malloc in the usual case,
4492 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4493 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4494 * filelock.c (current_lock_owner): Likewise.
4495 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4496 * sysdep.c: Include allocator.h, careadlinkat.h.
4497 (emacs_no_realloc_allocator): New static constant.
4498 (emacs_readlink): New function.
fdb61804
PE
4499 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4500 ../lib/careadlinkat.h.
d1fdcab7 4501
f84c17c7
SM
45022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4503
4504 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4505 first non-nil return value).
4506
ef3862ad
JD
45072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4508
4509 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4510 if not defined (Bug#8403).
4511
376a7006
JB
45122011-04-02 Juanma Barranquero <lekktu@gmail.com>
4513
4514 * xdisp.c (display_count_lines): Remove parameter `start',
4515 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4516 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4517 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4518 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4519 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4520 and thereabouts. All callers changed.
4521 (get_per_char_metric): Remove parameter `f', unused since
4522 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4523
6ca3801d
JM
45242011-04-02 Jim Meyering <meyering@redhat.com>
4525
4526 do not dereference NULL upon failed strdup
4527 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4528 (ns_get_family): Likewise.
4529
d8e2b5ba
JB
45302011-04-02 Juanma Barranquero <lekktu@gmail.com>
4531
4532 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4533
8c74fcbd
JD
45342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4535
4536 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4537 later (Bug#8403).
4538
7200d79c
SM
45392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4540
03408648 4541 Add lexical binding.
7200d79c 4542
03408648
SM
4543 * window.c (Ftemp_output_buffer_show): New fun.
4544 (Fsave_window_excursion):
4545 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4546
4547 * lread.c (lisp_file_lexically_bound_p): New function.
4548 (Fload): Bind Qlexical_binding.
4549 (readevalloop): Remove `evalfun' arg.
4550 Bind Qinternal_interpreter_environment.
4551 (Feval_buffer): Bind Qlexical_binding.
4552 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4553 Mark as dynamic.
4554 (syms_of_lread): Declare `lexical-binding'.
4555
4556 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4557
4558 * keyboard.c (eval_dyn): New fun.
4559 (menu_item_eval_property): Use it.
ca105506
SM
4560
4561 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4562
03408648
SM
4563 * fns.c (concat, mapcar1): Accept byte-code-functions.
4564
4565 * eval.c (Fsetq): Handle lexical vars.
4566 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4567 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4568 (FletX, Flet): Obey lexical binding.
4569 (Fcommandp): Handle closures.
4570 (Feval): New `lexical' arg.
4571 (eval_sub): New function extracted from Feval. Use it almost
4572 everywhere where Feval was used. Look up vars in lexical env.
4573 Handle closures.
4574 (Ffunctionp): Move from subr.el.
4575 (Ffuncall): Handle closures.
4576 (apply_lambda): Remove `eval_flags'.
4577 (funcall_lambda): Handle closures and new byte-code-functions.
4578 (Fspecial_variable_p): New function.
4579 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4580 but without exporting it to Lisp.
23aba0ea 4581
23aba0ea 4582 * doc.c (Fdocumentation, store_function_docstring):
03408648 4583 * data.c (Finteractive_form): Handle closures.
23aba0ea 4584
03408648
SM
4585 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4586 interactive spec.
ba83908c 4587
04f2d78b
CB
4588 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4589 New byte-codes.
03408648
SM
4590 (exec_byte_code): New function extracted from Fbyte_code to handle new
4591 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4592
03408648 4593 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4594
03408648 4595 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4596
e2abce01
JB
45972011-03-31 Juanma Barranquero <lekktu@gmail.com>
4598
4599 * xdisp.c (redisplay_internal): Fix prototype.
4600
63696a73 46012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4602
63696a73 4603 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4604 (try_scrolling): Use it when setting scroll_limit.
4605 Limit scrolling to 100 screen lines.
63696a73
EZ
4606 (redisplay_window): Even when falling back on "recentering",
4607 position point in the window according to scroll-conservatively,
4608 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4609
4610 (try_scrolling): When point is above the window, allow searching
4611 as far as scroll_max, or one screenful, to compute vertical
4612 distance from PT to the scroll margin position. This prevents
4613 try_scrolling from unnecessarily failing when
4614 scroll-conservatively is set to a value slightly larger than the
4615 window height. Clean up the case of PT below the margin at bottom
4616 of window: scroll_max can no longer be INT_MAX. When aggressive
4617 scrolling is in use, don't let point enter the opposite scroll
4618 margin as result of the scroll.
4619 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4620 threshold of 100 lines for never-recentering scrolling.
4621
e4cc2dfc
JB
46222011-03-31 Juanma Barranquero <lekktu@gmail.com>
4623
4624 * dispextern.h (move_it_by_lines):
4625 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4626 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4627 (message_log_check_duplicate): Remove parameters `prev_bol' and
4628 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4629 (redisplay_internal): Remove parameter `preserve_echo_area',
4630 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4631
4632 * indent.c (Fvertical_motion):
4633 * window.c (window_scroll_pixel_based, Frecenter):
4634 Don't pass `need_y_p' to `move_it_by_lines'.
4635
1c470562
SM
46362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4637
44f230aa
SM
4638 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4639 steal a few bits to be more compact.
4640 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4641 Remove unneeded casts.
4642
1c470562
SM
4643 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4644
888adce9
ZK
46452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4646
4647 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4648 binding" message (bug#7967).
4649
f838ed7b
PE
46502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4651
77861b95
PE
4652 Fix more problems found by GCC 4.6.0's static checks.
4653
de6dbc14
PE
4654 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4655 Remove unused local var.
4656
f838ed7b
PE
4657 * editfns.c (Fmessage_box): Remove unused local var.
4658
792c7b2b
PE
4659 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4660 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4661 Omit unused local vars.
c499e557 4662 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4663 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4664 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4665 Omit unused local var.
4666
ba0165e1
PE
4667 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4668 Don't assume string length fits in int.
32ad8845 4669 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4670 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4671
3c59b4c9
PE
4672 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4673 instead of alloca (Bug#8344).
4674
a3eed478 4675 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4676 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4677
eb4d412d
PE
4678 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4679
1658b401
PE
4680 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4681 concerns.
4682
4683 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4684
4685 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4686
9a2c6e05
PE
4687 * keyboard.c (syms_of_keyboard): Use the same style as later
4688 in this function when indexing through an array. This also
4689 works around GCC bug 48267.
4690
03d0a109
PE
4691 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4692
44f730c8
PE
4693 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4694
fe75f926
PE
4695 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4696 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4697
ffa8c828
PE
4698 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4699 This avoids undefined behavior on integer overflow, and is a bit
4700 more convenient anyway since it is compared to a size_t variable.
4701
c5101a77
PE
4702 Variadic C functions now count arguments with size_t, not int.
4703 This avoids an unnecessary limitation on 64-bit machines, which
4704 caused (substring ...) to crash on large vectors (Bug#8344).
4705 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4706 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4707 All variadic functions and their callers changed accordingly.
c5101a77
PE
4708 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4709 * data.c (arith_driver, float_arith_driver): Likewise.
4710 * editfns.c (general_insert_function): Likewise.
4711 * eval.c (struct backtrace.nargs, interactive_p)
4712 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4713 (funcall_lambda, mark_backtrace): Likewise.
4714 * fns.c (concat): Likewise.
4715 * frame.c (x_set_frame_parameters): Likewise.
4716 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4717 0 if not found, not -1. All callers changed.
4718
dd3f25f7
PE
4719 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4720 (stack_copy_size): Now size_t, not int.
4721 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4722
461c2ab9
JB
47232011-03-28 Juanma Barranquero <lekktu@gmail.com>
4724
4725 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4726 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4727 All callers changed.
4728
4729 * lisp.h (multibyte_char_to_unibyte):
4730 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4731 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4732 * character.h (CHAR_TO_BYTE8):
4733 * cmds.c (internal_self_insert):
4734 * editfns.c (general_insert_function):
4735 * keymap.c (push_key_description):
4736 * search.c (Freplace_match):
4737 * xdisp.c (message_dolog, set_message_1): All callers changed.
4738
f6d62986
SM
47392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4740
4741 * keyboard.c (safe_run_hook_funcall): New function.
4742 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4743 don't set the hook to nil, but remove the offending function instead.
4744 (Qcommand_hook_internal): Remove, unused.
4745 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4746 Vcommand_hook_internal.
4747
4748 * eval.c (enum run_hooks_condition): Remove.
4749 (funcall_nil, funcall_not): New functions.
4750 (run_hook_with_args): Call each function through a `funcall' argument.
4751 Remove `cond' argument, now redundant.
4752 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4753 (Frun_hook_with_args_until_failure): Adjust accordingly.
4754 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4755
1db5b1ad
JB
47562011-03-28 Juanma Barranquero <lekktu@gmail.com>
4757
4758 * dispextern.h (string_buffer_position): Remove declaration.
4759
4760 * print.c (strout): Remove parameter `multibyte', unused since
4761 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4762
4763 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4764 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4765 All callers changed.
4766
4767 * w32.c (_wsa_errlist): Use braces for struct initializers.
4768
4769 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4770 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4771 All callers changed.
4772 (string_buffer_position): Likewise. Also, make static (it's never
4773 used outside xdisp.c).
4774 (cursor_row_p): Remove parameter `w', unused since
4775 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4776 (decode_mode_spec): Remove parameter `precision', introduced during
4777 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4778 All callers changed.
4779
5ffb62aa
JD
47802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4781
4782 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4783
461c2ab9 47842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4785
4786 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4787 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4788 (ns_update_auto_hide_menu_bar): New functions.
4789 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4790 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4791 ns_constrain_all_frames.
4792 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4793 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4794
5c380ffb
JD
47952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4796
4797 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4798
9af30bdf
GM
47992011-03-27 Glenn Morris <rgm@gnu.org>
4800
4801 * syssignal.h: Replace RETSIGTYPE with void.
4802 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4803 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4804 Replace SIGTYPE with void everywhere.
4805 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4806 * s/template.h (SIGTYPE): Remove commented out definition.
4807
e2abce01
JB
48082011-03-26 Eli Zaretskii <eliz@gnu.org>
4809
4810 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4811 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4812
f868cd8a
JB
48132011-03-26 Juanma Barranquero <lekktu@gmail.com>
4814
59eb0929
JB
4815 * w32.c (read_unc_volume): Use parameter `henum', instead of
4816 global variable `wget_enum_handle'.
4817
4818 * keymap.c (describe_vector): Remove parameters `indices' and
4819 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4820 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4821
f868cd8a
JB
4822 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4823
4824 * keyboard.c (timer_check): Remove parameter `do_it_now',
4825 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4826 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4827 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4828
4829 * keyboard.c (read_char):
4830 * w32menu.c (w32_menu_display_help):
4831 * xmenu.c (show_help_event, menu_help_callback):
4832 Adjust calls to `show_help_echo'.
4833
4834 * gtkutil.c (xg_maybe_add_timer):
4835 * keyboard.c (readable_events):
4836 * process.c (wait_reading_process_output):
4837 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4838
4839 * insdel.c (adjust_markers_gap_motion):
4840 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4841 (gap_left, gap_right): Don't call it.
4842
2ecf6fdb
CY
48432011-03-25 Chong Yidong <cyd@stupidchicken.com>
4844
4845 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4846 incurred during fontification.
4847
6b1f9ba4
JB
48482011-03-25 Juanma Barranquero <lekktu@gmail.com>
4849
4850 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4851 (DEFVAR_PER_BUFFER): Don't pass it.
4852
4853 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4854 (scrolling_window): Don't pass it.
4855
0f4a96b5
JB
48562011-03-25 Juanma Barranquero <lekktu@gmail.com>
4857
4858 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4859
4860 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4861 and `suffix'.
4862 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4863 of variables specific to SELinux and computation of `encoded_absname'.
4864
4865 * image.c (XPutPixel): Remove unused variable `height'.
4866
4867 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4868
4869 * unexw32.c (get_section_info): Remove unused variable `section'.
4870
4871 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4872 (system_process_attributes): Remove unused variable `sess'.
4873 (sys_read): Remove unused variable `err'.
4874
4875 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4876 (w32_wnd_proc): Remove unused variable `isdead'.
4877 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4878 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4879 (x_create_tip_frame): Remove unused variable `tem'.
4880
4881 * w32inevt.c (w32_console_read_socket):
4882 Remove unused variable `no_events'.
4883
4884 * w32term.c (x_draw_composite_glyph_string_foreground):
4885 Remove unused variable `width'.
4886
1149507c
JB
48872011-03-24 Juanma Barranquero <lekktu@gmail.com>
4888
4889 * w32term.c (x_set_glyph_string_clipping):
4890 Don't pass uninitialized region to CombineRgn.
4891
9c88f339
JB
48922011-03-23 Juanma Barranquero <lekktu@gmail.com>
4893
4894 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4895 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4896 (Fx_close_connection): Remove unused variable `i'.
4897
4898 * w32font.c (w32font_draw): Return number of glyphs.
4899 (w32font_open_internal): Remove unused variable `i'.
4900 (w32font_driver): Add missing initializer.
4901
4902 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4903 (fill_in_menu): Remove unused variable `items_added'.
4904
4905 * w32term.c (last_mouse_press_frame): Remove static global variable.
4906 (w32_clip_to_row): Remove unused variable `f'.
4907 (x_delete_terminal): Remove unused variable `i'.
4908
4909 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4910 (NOTHING): Remove unused static global variable.
4911 (uniscribe_check_otf): Remove unused variable `table'.
4912 (uniscribe_font_driver): Add missing initializers.
4913
dee091a3
JD
49142011-03-23 Julien Danjou <julien@danjou.info>
4915
4916 * term.c (Fsuspend_tty, Fresume_tty):
4917 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4918 * window.c (temp_output_buffer_show):
4919 * insdel.c (signal_before_change):
4920 * frame.c (Fhandle_switch_frame):
4921 * fileio.c (Fdo_auto_save):
4922 * emacs.c (Fkill_emacs):
4923 * editfns.c (save_excursion_restore):
4924 * cmds.c (internal_self_insert):
4925 * callint.c (Fcall_interactively):
4926 * buffer.c (Fkill_all_local_variables):
4927 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4928 Use Frun_hooks.
0f4a96b5 4929 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4930 unconditionnaly since it does the check itself.
4931
2c520ab5 49322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4933
c9c49752
PE
4934 Fix more problems found by GCC 4.5.2's static checks.
4935
8abc3f12
PE
4936 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4937 the first time through the loop, since we know p0 < p1 then.
4938 This also avoids a gcc -Wstrict-overflow warning.
4939
a2d26660
PE
4940 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4941 leading to a memory leak, possible in functions like
4942 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4943 of objects (Bug#8318).
a2d26660 4944
916c72e9
PE
4945 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4946 that could (at least in theory) be that large.
4947
19ab8a18
PE
4948 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4949 This is less likely to overflow, and avoids undefined behavior if
4950 overflow does occur. All callers changed. Use strtoul to scan
4951 for the unsigned long integer.
b7cbbd6f
PE
4952 (pint2hrstr): Simplify and tune code slightly.
4953 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4954
f0641eff
PE
4955 * scroll.c (do_scrolling): Work around GCC bug 48228.
4956 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4957
7f650bb9
PE
4958 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4959 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4960 (validate_x_resource_name): Simplify count usage.
4961 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4962
37dd57d1
PE
4963 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4964 fail (Bug#8306).
81e56e61 4965
699979fc 4966 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4967
401bf9b4
PE
4968 * process.c (Fmake_network_process): Use socklen_t, not int,
4969 where POSIX says socklen_t is required in portable programs.
4970 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4971 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4972 (Fmake_network_process, server_accept_connection):
4973 (wait_reading_process_output, read_process_output):
4974 Likewise.
4975
b93aacde
PE
4976 * process.c: Rename or move locals to avoid shadowing.
4977 (list_processes_1, Fmake_network_process):
4978 (read_process_output_error_handler, exec_sentinel_error_handler):
4979 Rename or move locals.
4dc343ee 4980 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4981 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4982 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4983 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4984 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4985
af8a867c 4986 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4987 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4988 Include tparam.h instead, since it declares them.
af8a867c
PE
4989 * cm.h (PC): Remove extern decl; tparam.h now does this.
4990 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4991 * terminfo.c: Include tparam.h, to check interfaces.
4992 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4993 (tparam): Adjust signature to match interface in tparam.h;
4994 this removes some undefined behavior. Check that outstring and len
4995 are zero, which they always are with Emacs.
4996 * tparam.h (PC, BC, UP): New extern decls.
4997
0248044d 4998 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4999 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5000
8ff096c1 5001 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5002 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5003 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5004 (ftfont_list): Remove unused local.
49eaafba
PE
5005 (get_adstyle_property, ftfont_pattern_entity):
5006 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5007 Rename locals to avoid shadowing.
8ff096c1 5008
e2be39f6
PE
5009 * xfont.c (xfont_list_family): Mark var as initialized.
5010
c9735e30
PE
5011 * xml.c (make_dom): Now static.
5012
8f5201ae
PE
5013 * composite.c (composition_compute_stop_pos): Rename local to
5014 avoid shadowing.
b246f932
PE
5015 (composition_reseat_it): Remove unused locals.
5016 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5017 (composition_update_it): Mark var as initialized.
11b61122
PE
5018 (find_automatic_composition): Mark vars as initialized,
5019 with a FIXME (Bug#8290).
8f5201ae 5020
760fbc2c
PE
5021 character.h: Rename locals to avoid shadowing.
5022 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5023 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5024 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5025 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5026 to avoid shadowing.
5027
ff08eb85
PE
5028 * textprop.c (property_change_between_p): Remove; unused.
5029
fc7bf025
PE
5030 * intervals.c (interval_start_pos): Now static.
5031
235d7abc
PE
5032 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5033
44f230aa
SM
5034 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5035 Rename locals to avoid shadowing.
3e7d6594 5036
50060332
PE
5037 * sound.c (wav_play, au_play, Fplay_sound_internal):
5038 Fix pointer signedness.
d01f234b 5039 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5040 (wav_play): Initialize a variable to 0, to prevent undefined
5041 behavior (Bug#8278).
50060332 5042
c4fc4e30
PE
5043 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5044
918436ed
PE
5045 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5046
c939f91b
PE
5047 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5048 clobbering (Bug#8298).
b9c7f648
PE
5049 * sysdep.c (sys_subshell): Likewise.
5050 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5051
6bd8c144
PE
5052 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5053 This should get cleaned up, so that child_setup has the
5054 same signature on all platforms.
5055
7710357c 5056 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5057 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5058
c59da222
CY
50592011-03-22 Chong Yidong <cyd@stupidchicken.com>
5060
5061 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5062 not to be necessary, and produces flickering.
5063
66b87493
GM
50642011-03-20 Glenn Morris <rgm@gnu.org>
5065
5066 * config.in: Remove file.
5067
45b6f6d5
JB
50682011-03-20 Juanma Barranquero <lekktu@gmail.com>
5069
5070 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5071 are now in src/globals.h.
5072 (syms_of_minibuf): Remove spurious & from previous change.
5073
3ec03f7e
LL
50742011-03-20 Leo <sdl.web@gmail.com>
5075
5076 * minibuf.c (completing-read-function): New variable.
5077 (completing-read-default): Rename from completing-read.
5078 (completing-read): Call completing-read-function.
5079
b14e3e21
CY
50802011-03-19 Juanma Barranquero <lekktu@gmail.com>
5081
5082 * xfaces.c (Fx_load_color_file):
5083 Read color file from absolute filename (bug#8250).
5084
f2b726e6
JB
50852011-03-19 Juanma Barranquero <lekktu@gmail.com>
5086
5087 * makefile.w32-in: Update dependencies.
5088
09f6ff02
EZ
50892011-03-17 Eli Zaretskii <eliz@gnu.org>
5090
5091 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5092
29a6015a
PE
50932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5094
a3a6c54e
PE
5095 Fix more problems found by GCC 4.5.2's static checks.
5096
b766f867
PE
5097 * process.c (make_serial_process_unwind, send_process_trap):
5098 (sigchld_handler): Now static.
5099
be02381c
PE
5100 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5101 That way, the code declares only the vars that it needs.
5102 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5103 * s/cygwin.h (PTY_ITERATION): Likewise.
5104 * s/darwin.h (PTY_ITERATION): Likewise.
5105 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5106
57048744
PE
5107 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5108 * process.c (allocate_pty): Don't declare stb unless it's needed.
5109
7914961c 5110 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5111 (CONSTANTLIM): Remove; unused.
5112 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5113 Define only if needed.
7914961c 5114
b3967b18
PE
5115 * unexelf.c (unexec): Name an expression,
5116 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5117 Use a different way to cause a compilation error if anyone uses
5118 n rather than nn, a way that does not involve shadowing.
73366a00 5119 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5120
29a6015a
PE
5121 * deps.mk (unexalpha.o): Remove; unused.
5122
43cfc33e 5123 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5124 * unexec.h: New file.
ce701a33
PE
5125 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5126 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5127 Depend on unexec.h.
5128 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5129 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5130 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5131 Change as necessary to match prototype in unexec.h.
ce701a33 5132
01f44d5a
PE
5133 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5134 shadowing.
4f63c6bb 5135 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5136
a6670b0b
PE
5137 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5138 Rename locals to avoid shadowing.
5139
cef2010d 5140 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5141 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5142
d4d7173a
PE
5143 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5144
f08b802a
PE
5145 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5146 warning when compiling print.c.
5147
3ddb0639
PE
5148 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5149 instead of using an uninitialized var.
5ad03b97 5150 (font_sort_entities): Mark var as initialized.
3ddb0639 5151
170a2692
PE
5152 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5153
e663c700
PE
5154 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5155 pointers to constants.
89bc529a 5156 (font_parse_fcname): Remove unused vars.
7b81e2d0 5157 (font_delete_unmatched): Now static.
ea838e10 5158 (font_get_spec): Remove; unused.
13a547c6
PE
5159 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5160 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5161 Rename or move locals to avoid shadowing.
e663c700 5162
2a80c887 5163 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5164 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5165
1384fa33 5166 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5167 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5168
8b2c52e9
PE
5169 * alloc.c (mark_backtrace): Move decl from here ...
5170 * lisp.h: ... to here, so that it can be checked.
5171
475545b5 5172 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5173 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5174 (lisp_indirect_variable): Name an expression,
5175 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5176 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5177
b1349114 5178 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5179 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5180 Use const pointer when appropriate.
b1349114 5181
a2928364
PE
5182 * lisp.h (get_system_name, get_operating_system_release):
5183 Move decls here, to check interfaces.
5184 * process.c (get_operating_system_release): Move decl to lisp.h.
5185 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5186 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5187 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5188 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5189 (Fformat_time_string, Fencode_time, Finsert_char):
5190 (Ftranslate_region_internal, Fformat):
5191 Rename or remove local vars to avoid shadowing.
9710023e 5192 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5193
a415e694
PE
5194 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5195 avoid shadowing.
5196
8ef4622d
PE
5197 * lisp.h (eassert): Check that the argument compiles, even if
5198 ENABLE_CHECKING is not defined.
5199
946f9a5b
PE
5200 * data.c (Findirect_variable): Name an expression, to avoid
5201 gcc -Wbad-function-cast warning.
112396d6 5202 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5203 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5204 (Fmake_variable_buffer_local, Fmake_local_variable):
5205 Mark variables as initialized.
52746918 5206 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5207
e5aab7e7 5208 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5209 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5210 Rename locals to avoid shadowing.
dff45157
PE
5211 (mark_stack): Move local variables into the #ifdef region where
5212 they're used.
7bc26fdb
PE
5213 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5214 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5215 needed otherwise.
5216 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5217 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5218 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5219
e5aab7e7
PE
5220 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5221 avoids undefined behavior in theory.
5222
4da60324
PE
5223 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5224
88043301
PE
5225 Use functions, not macros, for up- and down-casing (Bug#8254).
5226 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5227 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5228 to use the following functions instead of these macros.
5229 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5230 EMACS_INT, since callers assume the returned value fits in int.
5231 (upcase1): Likewise, for UPCASE_TABLE.
5232 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5233 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5234 the race-condition problem in the old DOWNCASE.
88043301 5235
19ed5445
PE
5236 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5237 Rename locals to avoid shadowing.
5238 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5239 (regex_compile, re_search_2, re_match_2_internal):
5240 Remove unused local vars.
952db0d7
PE
5241 (FREE_VAR): Rewrite so as not to use empty "else",
5242 which gcc can warn about.
da053e48 5243 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5244 (RETALLOC_IF): Define only if needed.
5245 (WORDCHAR_P): Likewise. This one is never needed, but is used
5246 only in a comment talking about a compiler bug, so put inside
5247 the #if 0 of that comment.
5248 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5249 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5250 Remove; unused.
19ed5445 5251
1f3561e4 5252 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5253 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5254 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5255
ded6f8f7
PE
5256 * search.c (simple_search): Remove unused var.
5257
dbd37a95
PE
5258 * dired.c (compile_pattern): Move decl from here ...
5259 * lisp.h: ... to here, so that it can be checked.
5260 (struct re_registers): New forward decl.
5261
7e47afad
PE
5262 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5263
85f24f61
PE
5264 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5265 All uses changed.
5266 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5267 Rename locals to avoid shadowing.
5671df8f 5268 (Fvertical_motion): Mark locals as initialized.
85f24f61 5269
181aa2be 5270 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5271 (casify_region): Mark local as initialized.
181aa2be 5272
930d429c
PE
5273 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5274
7082eac6
PE
5275 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5276 New macros, so that the caller can use some names other than
5277 gcpro1, gcpro2, etc.
5278 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5279 of the new macros.
5280 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5281 argument, for consistency with GCPRO2_VAR, etc: it is now the
5282 prefix of the variable, not the variable itself. All uses
5283 changed.
38b2c076
PE
5284 * dired.c (directory_files_internal, file_name_completion):
5285 Rename locals to avoid shadowing.
5286
15206ed9
PE
5287 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5288 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5289 dired.c's scmp function, had undefined behavior.
5290 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5291 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5292 * buffer.h: ... to here, because these macros use current_buffer,
5293 and the new implementation with inline functions needs to have
5294 current_buffer in scope now, rather than later when the macros
5295 are used.
5296 (downcase, upcase1): New static inline functions.
5297 (DOWNCASE, UPCASE1): Reimplement using these functions.
5298 This avoids undefined behavior in expressions like
5299 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5300 from race conditions in accessing the global variables
5301 case_temp1 and case_temp2.
5302 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5303 * lisp.h (case_temp1, case_temp2): Remove their decls.
5304 * character.h (ASCII_CHAR_P): Move from here ...
5305 * lisp.h: ... to here, so that the inline functions mentioned
5306 above can use them.
5307
4a6bea26
PE
5308 * dired.c (directory_files_internal_unwind): Now static.
5309
f14b7e14
PE
5310 * fileio.c (file_name_as_directory, directory_file_name):
5311 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5312 Now static.
2893f146
PE
5313 (file_name_as_directory): Use const pointers when appropriate.
5314 (Fexpand_file_name): Likewise. In particular, newdir might
5315 point at constant storage, so make it a const pointer.
fd4ead52 5316 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5317 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5318 signedness issues.
f839df0c
PE
5319 (Fset_file_times, Finsert_file_contents, auto_save_error):
5320 Rename locals to avoid shadowing.
f14b7e14 5321
5716756e 5322 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5323 (Ftry_completion, Fall_completions): Rename or remove locals
5324 to avoid shadowing.
5716756e 5325
b4c3046a
PE
5326 * marker.c (bytepos_to_charpos): Remove; unused.
5327
b45db522
PE
5328 * lisp.h (verify_bytepos, count_markers): New decls,
5329 so that gcc does not warn that these functions aren't declared.
5330
85876d07
PE
5331 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5332 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5333 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5334 (copy_text): Remove unused local var.
85876d07 5335
03d78a21 5336 * filelock.c (within_one_second): Now static.
b3dd38ab 5337 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5338
5df8f01b
PE
5339 * buffer.c (fix_overlays_before): Mark locals as initialized.
5340 (fix_start_end_in_overlays): Likewise. This function should be
5341 simplified by using pointers-to-pointers, but that's a different
5342 matter.
b1d876f1 5343 (switch_to_buffer_1): Now static.
8f54f30a
PE
5344 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5345 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5346
a70072c9 5347 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5348 Fix pointer signedness issue.
edced198
PE
5349 (sys_subshell): Mark local as volatile if checking for lint,
5350 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5351 (MAXPATHLEN): Define only if needed.
a70072c9 5352
a0977c44
PE
5353 * process.c (serial_open, serial_configure): Move decls from here ...
5354 * systty.h: ... to here, so that they can be checked.
5355
a884fdcc
PE
5356 * fns.c (get_random, seed_random): Move extern decls from here ...
5357 * lisp.h: ... to here, so that they can be checked.
5358
604efe86 5359 * sysdep.c (reset_io): Now static.
b8950c94 5360 (wait_for_termination_signal): Remove; unused.
604efe86 5361
38fc62d9
PE
5362 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5363 (copy_keymap_item, append_key, push_text_char_description):
5364 Now static.
1004a21a 5365 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5366 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5367 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5368 (describe_map_tree):
5369 Rename locals to avoid shadowing.
38fc62d9 5370
2f2650da
PE
5371 * keyboard.c: Declare functions static if they are not used elsewhere.
5372 (echo_char, echo_dash, cmd_error, top_level_2):
5373 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5374 (read_char, kbd_buffer_get_event, make_lispy_position):
5375 (make_lispy_event, make_lispy_movement, apply_modifiers):
5376 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5377 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5378 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5379 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5380 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5381
a053e86c 5382 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5383 (mark_kboards): Move decl here ...
5384 * alloc.c (mark_kboards): ... from here.
a053e86c 5385
4752793e
PE
5386 * lisp.h (force_auto_save_soon): New decl.
5387
74f10ca7 5388 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5389 (DEFINE_DUMMY_FUNCTION): New macro.
5390 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5391 Use it.
c03cd23f
PE
5392 (main): Add casts to avoid warnings
5393 if GCC considers string literals to be constants.
74f10ca7 5394
022e70d4
PE
5395 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5396
59d6fe83
PE
5397 * dbusbind.c: Pointer signedness fixes.
5398 (xd_signature, xd_append_arg, xd_initialize):
5399 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5400 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5401 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5402 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5403
78320123
PE
5404 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5405 if GCC considers string literals to be constants.
49cebcca 5406 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5407
35ac2a97
SM
54082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5409
fb103ca9
SM
5410 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5411 (print_preprocess, print_object): New macro to fix last change.
5412
35ac2a97
SM
5413 * print.c (print_preprocess): Don't forget font objects.
5414
62973b41
JB
54152011-03-16 Juanma Barranquero <lekktu@gmail.com>
5416
5417 * emacs.c (USAGE3): Doc fixes.
5418
0e48bb22
AS
54192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5420
5421 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5422 structure.
5423
7684e57b
JB
54242011-03-14 Juanma Barranquero <lekktu@gmail.com>
5425
5426 * lisp.h (VWindow_system, Qfile_name_history):
5427 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5428 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5429 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5430
5431 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5432 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5433
5434 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5435 * w32console.c (detect_input_pending, read_input_pending)
5436 (encode_terminal_code):
5437 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5438 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5439 (w32_system_caret_y, Qfile_name_history):
5440 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5441 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5442 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5443 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5444 * w32proc.c (Qlocal, report_file_error):
5445 * w32term.c (Vwindow_system, updating_frame):
5446 * w32uniscribe.c (initialized, uniscribe_font_driver):
5447 Remove unneeded extern declarations.
5448
2aa46d6c
CY
54492011-03-14 Chong Yidong <cyd@stupidchicken.com>
5450
c96bbc66 5451 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5452
cffc6f3b
CY
54532011-03-13 Chong Yidong <cyd@stupidchicken.com>
5454
5455 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5456 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5457 These macros can no longer be used for assignment.
5458
44f230aa
SM
5459 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5460 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5461 (record_buffer_markers, fetch_buffer_markers): New functions for
5462 recording and fetching special buffer markers.
5463 (set_buffer_internal_1, set_buffer_temp): Use them.
5464
5465 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5466
5467 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5468
5469 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5470 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5471
5472 * xdisp.c (hscroll_window_tree):
5473 (reconsider_clip_changes): Use PT instead of BUF_PT.
5474
d251f04b
EZ
54752011-03-13 Eli Zaretskii <eliz@gnu.org>
5476
5477 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5478 $(EMACS_ROOT)/lib/intprops.h.
5479
f0c77cd1
PE
54802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5481
3eca4629
PE
5482 Fix more problems found by GCC 4.5.2's static checks.
5483
7c86ee98
PE
5484 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5485 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5486 (xg_free_frame_widgets): Make it clear that a local variable is
5487 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5488 (gdk_window_get_screen): Make it clear that this macro is needed
5489 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5490 (int_gtk_range_get_value): New function, which avoids a diagnostic
5491 from gcc -Wbad-function-cast.
5492 (xg_set_toolkit_scroll_bar_thumb): Use it.
5493 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5494 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5495 (get_utf8_string, xg_get_file_with_chooser):
5496 Rename locals to avoid shadowing.
5497 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5498
41729b81
PE
5499 * xgselect.c (xg_select): Remove unused var.
5500
f0c77cd1
PE
5501 * image.c (four_corners_best): Mark locals as initialized.
5502 (gif_load): Initialize transparent_p to zero (Bug#8238).
5503 Mark another local as initialized.
ec6cf4c6 5504 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5505
ce0ad53d 5506 * image.c (clear_image_cache): Now static.
d5d5a617 5507 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5508 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5509 (x_edge_detection): Remove unnecessary cast that
5510 gcc -Wbad-function-cast diagnoses.
2037898d 5511 (gif_load): Fix pointer signedness.
6ae141d6
PE
5512 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5513 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5514
33383987 55152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5516
d32df629
PE
5517 Improve quality of tests for time stamp overflow.
5518 For example, without this patch (encode-time 0 0 0 1 1
5519 1152921504606846976) returns the obviously-bogus value (-948597
5520 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5521 reports time overflow. See
5522 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5523 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5524 * editfns.c: Include limits.h and intprops.h.
5525 (TIME_T_MIN, TIME_T_MAX): New macros.
5526 (time_overflow): Move earlier, to before first use.
5527 (hi_time, lo_time): New functions, for an accurate test for
5528 out-of-range times.
5529 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5530 (Fget_internal_run_time): Don't assume time_t fits in int.
5531 (make_time): Use list2 instead of Fcons twice.
5532 (Fdecode_time): More accurate test for out-of-range times.
5533 (check_tm_member): New function.
5534 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5535 (lisp_time_argument): Don't rely on undefined left-shift and
5536 right-shift behavior when checking for time stamp overflow.
8be6f318 5537
fe31d94c
PE
5538 * editfns.c (time_overflow): New function, refactoring common code.
5539 (Fformat_time_string, Fdecode_time, Fencode_time):
5540 (Fcurrent_time_string): Use it.
5541
8be6f318
PE
5542 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5543 * dired.c (make_time): Move to ...
5544 * editfns.c (make_time): ... here.
5545 * systime.h: Note the move.
5546
09d9db2c 55472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5548
126bc0dc
YM
5549 * fringe.c (update_window_fringes): Remove unused variables.
5550
c47cbdfd
YM
5551 * unexmacosx.c (copy_data_segment): Also copy __got section.
5552 (Bug#8223)
5553
7ac80be9
EZ
55542011-03-12 Eli Zaretskii <eliz@gnu.org>
5555
c96bbc66 5556 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5557 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5558 Constify `char *' arguments and their references according to
5559 prototypes in tparam.h.
5560
ecb0f94d 5561 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5562
7ac80be9
EZ
5563 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5564 Adapt all references accordingly.
5565
5566 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5567
ef1fd07e
TT
55682011-03-11 Tom Tromey <tromey@redhat.com>
5569
5570 * buffer.c (syms_of_buffer): Remove obsolete comment.
5571
7ef4b50c
EZ
55722011-03-11 Eli Zaretskii <eliz@gnu.org>
5573
5574 * termhooks.h (encode_terminal_code): Declare prototype.
5575
5576 * msdos.c (encode_terminal_code): Don't declare prototype.
5577
5578 * term.c (encode_terminal_code): Now external again, used by
5579 w32console.c and msdos.c.
5580
44f230aa
SM
5581 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5582 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5583
4b1ec863 55842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5585
1714f52b 5586 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5587
4b1ec863
PE
5588 * fringe.c (update_window_fringes): Mark locals as initialized
5589 (Bug#8227).
5590 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5591
524c7aa6
PE
5592 * alloc.c (mark_fringe_data): Move decl from here ...
5593 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5594 to check its interface.
5595 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5596
a5c0af81 5597 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5598 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5599 (fontset_font): Mark local as initialized.
a9a06e0b 5600 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5601
b4716021
PE
5602 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5603
811e9bac 5604 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5605 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5606 (x_own_selection, Fx_disown_selection_internal): Rename locals
5607 to avoid shadowing.
5608 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5609
7e3ab302
PE
5610 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5611 so that the caller can use some name other than gcpro1.
5612 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5613 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5614 (Fx_backspace_delete_keys_p):
5615 Use them to avoid shadowing, and rename vars to avoid shadowing.
5616 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5617 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5618 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5619 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5620 Remove unused locals.
7e3ab302
PE
5621 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5622 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5623 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5624 macros.
f78faa98 5625
e2b13473
PE
5626 * xterm.h (x_mouse_leave): New decl.
5627
77f23912
PE
5628 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5629 Remove unused functions.
cdf4ba58
PE
5630 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5631 (x_calc_absolute_position): Now static.
7411c686 5632 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5633 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5634 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5635 unless they are used.
38d0b34a
PE
5636 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5637 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5638 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5639 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5640 (x_error_catcher, x_connection_closed, x_error_handler):
5641 (x_error_quitter, xembed_send_message, x_iconify_frame):
5642 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5643 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5644 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5645
44f230aa
SM
5646 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5647 Rename or move locals to avoid shadowing.
6b463e58 5648 (tty_defined_color, merge_face_heights): Now static.
5967d051 5649 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5650 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5651 does not deduce is never used uninitialized.
73719eba
PE
5652 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5653 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5654
426994c3 5655 * terminal.c (store_terminal_param): Now static.
5489860b 5656
032f1620 5657 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5658 (set_frame_menubar): Remove unused local.
d4323972 5659 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5660 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5661 since they might point to immutable storage.
281585b0
PE
5662 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5663 since it's unused otherwise.
032f1620 5664
367c19e5 5665 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5666 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5667 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5668 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5669 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5670 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5671 does not deduce are never used uninitialized.
70739cbe 5672
07b48fa9
PE
5673 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5674
8868a238 5675 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5676 * window.c (window_loop, size_window):
5677 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5678
7e5cf297 5679 * window.c (display_buffer): Now static.
d6550a9f
PE
5680 (size_window): Mark variables that gcc -Wuninitialized
5681 does not deduce are never used uninitialized.
a586633d
PE
5682 * window.h (check_all_windows): New decl, to forestall
5683 gcc -Wmissing-prototypes diagnostic.
5b555da1 5684 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5685
f6095868
PE
5686 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5687 shadowing.
5688 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5689 Include <limits.h>.
5690 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5691 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5692 (load_charset_map): Mark variables that gcc -Wuninitialized
5693 does not deduce are never used uninitialized.
53df7c11 5694 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5695
f38b440c
PE
5696 * coding.c (coding_set_source, coding_set_destination):
5697 Use "else { /* comment */ }" rather than "else /* comment */;"
5698 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5699 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5700 a block, when the outer 'i' will do.
5701 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5702 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5703 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5704 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5705 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5706 Rename locals to avoid shadowing.
5707 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5708 * coding.c (emacs_mule_char, encode_invocation_designation):
5709 Now static, since they're not used elsewhere.
413bb2db 5710 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5711 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5712 (decode_coding_emacs_mule): Mark variables that gcc
5713 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5714 (detect_coding_iso_2022): Initialize a local variable that might
5715 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5716 this initialization is needed. (Bug#8211)
5f58e762
PE
5717 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5718 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5719 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5720 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5721 Remove unused macros.
f38b440c 5722
232b38b9 5723 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5724 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5725 * character.c (string_count_byte8): Likewise.
232b38b9 5726
fb90da1b
PE
5727 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5728 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5729
fb93dbc2
PE
5730 * chartab.c (copy_sub_char_table): Now static, since it's not used
5731 elsewhere.
5c156ace
PE
5732 (sub_char_table_ref_and_range, char_table_ref_and_range):
5733 Rename locals to avoid shadowing.
bbcd0949 5734 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5735
7d3b3862 5736 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5737 (BIDI_BOB): Remove unused macro.
7d3b3862 5738
6be7d3da
PE
5739 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5740 deduce are never used uninitialized.
c2ed9c8b 5741 * term.c (encode_terminal_code): Likewise.
6be7d3da 5742
75f8807f 5743 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5744
50938595
PE
5745 * tparam.h: New file.
5746 * term.c, tparam.h: Include it.
5747 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5748 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5749 Move these decls to tparam.h, and make them agree with what
5750 is actually in tparam.c. The previous trick of using incompatible
5751 decls in different modules does not conform to the C standard.
5752 All callers of tparam changed to use tparam's actual API.
5753 * tparam.c (tparam1, tparam, tgoto):
5754 Use const pointers where appropriate.
5755
fbceeba2
PE
5756 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5757 * cm.h (struct cm): Likewise.
5758 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5759 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5760 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5761 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5762 (turn_on_face, init_tty): Likewise.
5763 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5764
7f3f1250
PE
5765 * term.c (term_mouse_position): Rename local to avoid shadowing.
5766
e6ca6543
PE
5767 * alloc.c (mark_ttys): Move decl from here ...
5768 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5769
c40f8d15
AS
57702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5771
5772 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5773
cfe0661d
JB
57742011-03-09 Juanma Barranquero <lekktu@gmail.com>
5775
5776 * search.c (compile_pattern_1): Remove argument regp, unused since
5777 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5778 (compile_pattern): Don't pass it.
5779
0afb4571
J
57802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5781
5782 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5783 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5784 for ! HAVE_GTK3.
5785 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5786
5787 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5788
5789 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5790 gdk_window_get_screen, gdk_window_get_geometry,
5791 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5792 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5793 (xg_get_pixbuf_from_pixmap): New function.
5794 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5795 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5796 Call xg_get_pixbuf_from_pixmap instead of
5797 gdk_pixbuf_get_from_drawable.
5798 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5799 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5800 (xg_check_special_colors): Use GtkStyleContext and its functions
5801 for HAVE_GTK3.
5802 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5803 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5804 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5805 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5806 Call gtk_widget_get_preferred_size.
0afb4571
J
5807 (xg_frame_resized): gdk_window_get_geometry only takes 5
5808 parameters.
44f230aa
SM
5809 (xg_win_to_widget, xg_event_is_for_menubar):
5810 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5811 (xg_set_widget_bg): New function.
5812 (delete_cb): New function.
895009e1 5813 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5814 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5815 (xg_set_background_color): Call xg_set_widget_bg.
5816 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5817 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5818 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5819 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5820 if ! HAVE_GTK3.
5821 (update_frame_tool_bar): Call gtk_widget_hide.
5822 (xg_initialize): Use GDK_KEY_g.
5823
5824 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5825 if ! HAVE_GTK3
5826 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5827
5828 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5829 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5830 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5831
1c2cc4ef
JB
58322011-03-08 Juanma Barranquero <lekktu@gmail.com>
5833
5834 * w32xfns.c (select_palette): Check success of RealizePalette against
5835 GDI_ERROR, not zero.
5836
33383987 5837See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5838
5839;; Local Variables:
5840;; coding: utf-8
aac0c6e3
MR
5841;; End:
5842
33383987 5843 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5844
5845 This file is part of GNU Emacs.
5846
5847 GNU Emacs is free software: you can redistribute it and/or modify
5848 it under the terms of the GNU General Public License as published by
5849 the Free Software Foundation, either version 3 of the License, or
5850 (at your option) any later version.
5851
5852 GNU Emacs is distributed in the hope that it will be useful,
5853 but WITHOUT ANY WARRANTY; without even the implied warranty of
5854 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5855 GNU General Public License for more details.
5856
5857 You should have received a copy of the GNU General Public License
5858 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.