Checked emacs.texi
[bpt/emacs.git] / src / ChangeLog
CommitLineData
310f5bd4
PE
12012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6 It's useless in that case, and it can cause problems on hosts
7 that allocate halves of EMACS_INT values separately.
8 Reported by Dan Horák. Diagnosed by Andreas Schwab in
9 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
10 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
11 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
12 it avoids undefined behavior on hosts where shifting right by more
13 than the word width has undefined behavior.
14
2375c96a
CY
152012-02-19 Chong Yidong <cyd@gnu.org>
16
17 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
18 (Funhandled_file_name_directory, Ffile_name_as_directory)
19 (Fdirectory_file_name, Fexpand_file_name)
20 (Fsubstitute_in_file_name): Protect against invalid file handler
21 return values (Bug#10845).
22
3eb49e71
EZ
232012-02-18 Eli Zaretskii <eliz@gnu.org>
24
25 * .gdbinit (pitx): Fix incorrect references to fields of the
26 iterator stack.
27
7b926f3f
CY
282012-02-17 Chong Yidong <cyd@gnu.org>
29
30 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
31
11273115
PE
322012-02-15 Paul Eggert <eggert@cs.ucla.edu>
33
34 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
35 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
36
c3a70e2b
CY
372012-02-15 Chong Yidong <cyd@gnu.org>
38
39 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
40 marked as special. Also, starting docstrings with * is obsolete.
41
0ca43699
AS
422012-02-13 Andreas Schwab <schwab@linux-m68k.org>
43
44 * gnutls.c (emacs_gnutls_write): Fix last change.
45
2e8f3c56
LI
462012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
47
48 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
49 send_process.
50
af70074f
SM
512012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
52
53 * keymap.c (Fsingle_key_description): Handle char ranges.
54
95986d52
CY
552012-02-12 Chong Yidong <cyd@gnu.org>
56
afd83bd1
CY
57 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
58 as that creates a dangerous corner case.
59
95986d52
CY
60 * window.c (Fdelete_window_internal): Invalidate the mouse
61 highlight (Bug#9904).
62
bd7da63e
GM
632012-02-12 Glenn Morris <rgm@gnu.org>
64
65 * xselect.c (Fx_own_selection_internal)
66 (Fx_get_selection_internal, Fx_disown_selection_internal)
67 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
68 * nsselect.m (Fx_own_selection_internal)
69 (Fx_disown_selection_internal, Fx_selection_exists_p)
70 (Fx_selection_owner_p, Fx_get_selection_internal):
71 Sync docs and argument specs with the xselect.c versions.
72
77abcbc2
LI
732012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
74
75 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
76
90b671e2
EZ
772012-02-11 Eli Zaretskii <eliz@gnu.org>
78
1c0ca0b7
EZ
79 * w32select.c (Fx_selection_exists_p): Sync doc string and
80 argument list with xselect.c. (Bug#10783)
81
82 * w16select.c (Fx_selection_exists_p): Sync doc string and
83 argument list with xselect.c. (Bug#10783)
90b671e2 84
49241268
GM
852012-02-10 Glenn Morris <rgm@gnu.org>
86
87 * fns.c (Fsecure_hash): Doc fix.
88
f998bbe7 892012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
90
91 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
92
0992bd9c
CY
932012-02-07 Chong Yidong <cyd@gnu.org>
94
95 * buffer.c (Fbuffer_local_variables)
96 (buffer_lisp_local_variables): Handle unbound vars correctly;
97 don't let Qunbound leak into Lisp.
98
af008560
GM
992012-02-07 Glenn Morris <rgm@gnu.org>
100
dd605cc4
GM
101 * image.c (Fimagemagick_types): Doc fix.
102
af008560
GM
103 * image.c (imagemagick-render-type): Change it from a lisp object
104 to an integer. Move the doc here from the lisp manual.
105 Treat all values not equal to 0 the same.
106
1449fa1d
CY
1072012-02-06 Chong Yidong <cyd@gnu.org>
108
109 * doc.c (store_function_docstring): Avoid applying docstring of
110 alias to base function (Bug#2603).
111
3723ec07
AS
1122012-02-04 Andreas Schwab <schwab@linux-m68k.org>
113
114 * .gdbinit (pp1, pv1): Remove redundant defines.
115 (pr): Use pp.
116
79c1cc1e
CY
1172012-02-04 Chong Yidong <cyd@gnu.org>
118
119 * nsterm.m: Declare a global (Bug#10694).
120
d7f29f8e
EZ
1212012-02-04 Eli Zaretskii <eliz@gnu.org>
122
123 * w32.c (get_emacs_configuration_options): Include
124 --enable-checking, if specified, in the return value.
125
3b95a6f9
MR
1262012-02-04 Martin Rudalics <rudalics@gmx.at>
127
128 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
129 after rounding frame sizes. (Bug#9723)
130
d6fa96a6
EZ
1312012-02-04 Eli Zaretskii <eliz@gnu.org>
132
133 * keyboard.c (adjust_point_for_property): Don't position point
134 before BEGV. (Bug#10696)
135
df0b2940
PE
1362012-02-03 Paul Eggert <eggert@cs.ucla.edu>
137
138 Handle overflow when computing char display width (Bug#9496).
139 * character.c (char_width): Return EMACS_INT, not int.
140 (char_width, c_string_width): Check for overflow when
141 computing the width; this is possible now that individual
142 characters can have unbounded width. Problem introduced
143 by merge from Emacs 23 on 2012-01-19.
144
6bee44d6
MA
1452012-02-02 Michael Albinus <michael.albinus@gmx.de>
146
147 * dbusbind.c (Fdbus_register_method): Mention the return value
148 :ignore in the docstring.
149
44f92739
GM
1502012-02-02 Glenn Morris <rgm@gnu.org>
151
1b9f60cc
GM
152 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
153
44f92739
GM
154 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
155 Unconditionally set to t. (Bug#10673)
156 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
157 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
158 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
159
c5d3843c
KH
1602012-02-02 Kenichi Handa <handa@m17n.org>
161
162 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
163 0, do not call append_composite_glyph.
164
159462d4 1652012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
166
167 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
168 NULL (Bug#6988).
169 (x_produce_glyphs): If the component of a composition is a null
170 string, set it->pixel_width to 1 to avoid zero-width glyph.
171
78cef877
EZ
1722012-02-01 Eli Zaretskii <eliz@gnu.org>
173
174 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
175 first 2 arguments are identical. This makes inserting large
176 output from a subprocess an order of magnitude faster on
177 MS-Windows, where all sbrk'ed memory is always contiguous.
178
97897668
GM
1792012-01-31 Glenn Morris <rgm@gnu.org>
180
181 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 182 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
183 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
184
31fd3586
GM
1852012-01-29 Glenn Morris <rgm@gnu.org>
186
187 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
188
0e24a8b2
CY
1892012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
190
191 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
192
cc0adcb0
CY
1932012-01-28 Chong Yidong <cyd@gnu.org>
194
195 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
196
acc28cb9
CY
1972012-01-26 Chong Yidong <cyd@gnu.org>
198
9c69cfb7
CY
199 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
200
acc28cb9
CY
201 * search.c (Fsearch_forward, Fsearch_backward): Document negative
202 repeat counts (Bug#10507).
203
48da7392
GM
2042012-01-26 Glenn Morris <rgm@gnu.org>
205
206 * lread.c (syms_of_lread): Doc fix.
207
14af5f7f
CY
2082012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
209
210 * coding.c (encode_designation_at_bol): Change return value to
211 EMACS_INT.
212
0b21c100
CY
2132012-01-25 Chong Yidong <cyd@gnu.org>
214
215 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
216
3c2907f7
CY
2172012-01-21 Chong Yidong <cyd@gnu.org>
218
219 * floatfns.c (Fcopysign): Make the second argument non-optional,
220 since nil is not allowed anyway.
221
959ad23f
AS
2222012-01-21 Andreas Schwab <schwab@linux-m68k.org>
223
224 * process.c (read_process_output): Use p instead of XPROCESS (proc).
225 (send_process): Likewise.
226
34a02f46
MR
2272012-01-19 Martin Rudalics <rudalics@gmx.at>
228
229 * window.c (save_window_save, Fcurrent_window_configuration)
230 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
231 doc-strings.
232
1259009a 2332012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
234
235 * character.c (char_width): New function.
70d4fdf6
GM
236 (Fchar_width, c_string_width, lisp_string_width):
237 Use char_width (Bug#9496).
25ed9e61 238
6a6ee00d
MR
2392012-01-16 Martin Rudalics <rudalics@gmx.at>
240
241 * window.c (Vwindow_persistent_parameters): New variable.
242 (Fset_window_configuration, save_window_save): Handle persistent
243 window parameters.
244
c85efaf7
EZ
2452012-01-14 Eli Zaretskii <eliz@gnu.org>
246
247 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
248 thrashing the stack of the thread. (Bug#9087)
249
5944709e
PE
2502012-01-12 Paul Eggert <eggert@cs.ucla.edu>
251
252 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
253
e71f5d99
EZ
2542012-01-11 Eli Zaretskii <eliz@gnu.org>
255
256 * xdisp.c (rows_from_pos_range): Handle the case where the
257 highlight ends on a newline. (Bug#10464)
258 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
259 he end column for display of highlight that ends on a newline
260 before a R2L line.
261
ce316182
GM
2622012-01-11 Glenn Morris <rgm@gnu.org>
263
264 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
265 from load-path also when installation-directory is nil. (Bug#10208)
266
5b43da69
GM
2672012-01-10 Glenn Morris <rgm@gnu.org>
268
74cc8ff9
GM
269 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
270
7d8d6e4e
GM
271 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
272 Update template values to be closer to their typical values these days.
5b43da69 273
a0db8d43
EZ
2742012-01-09 Eli Zaretskii <eliz@gnu.org>
275
276 * xdisp.c (rows_from_pos_range): Accept additional argument
277 DISP_STRING, and accept any glyph in a row whose object is that
278 string as eligible for mouse highlight. Fixes mouse highlight of
279 display strings from overlays. (Bug#10464)
280
9a0115ab 2812012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 282
b9110d6a 283 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
284 * fileio.c (auto_saving_dir_umask): New static var.
285 (Fmake_directory_internal): Use it.
286 (do_auto_save_make_dir): Set it, instead of invoking chmod after
287 creating the directory. The old code temporarily assigns
288 too-generous permissions to the directory.
289 (do_auto_save_eh): Clear it.
b9110d6a 290 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
291 that the var is always cleared.
292
6c1bd3f3
EZ
2932012-01-07 Eli Zaretskii <eliz@gnu.org>
294
295 * search.c (scan_buffer): Pass character positions to
296 know_region_cache, not byte positions. (Bug#6540)
297
069d2b50
L
2982012-01-07 LynX <_LynX@bk.ru> (tiny change)
299
300 * w32.c (sys_rename): Report EXDEV when rename of a directory
301 fails because the target is on another logical disk. (Bug#10284)
302
75bf0d33
DB
3032012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
304
305 * xterm.c (x_embed_request_focus): New function.
306
307 * xterm.h: Add prototype.
308
309 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
310
1c6e5a32
GM
3112012-01-05 Glenn Morris <rgm@gnu.org>
312
313 * emacs.c (emacs_copyright): Update short copyright year to 2012.
314
651e947e
EZ
3152012-01-01 Eli Zaretskii <eliz@gnu.org>
316
317 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
318 Load gnutls_transport_set_lowat only if GnuTLS version is below
319 2.11.1.
320 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
321 GnuTLS versions below 2.11.1.
322
3778cdd8
AL
3232011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
324
325 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
326 to the doc string advising against its use for altering the way
327 windows are scrolled.
328
0e5317f7
KH
3292011-12-28 Kenichi Handa <handa@m17n.org>
330
331 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
332 coding-system ASCII compatible only when it does not produce BOM
333 on encoding (Bug#10383).
334
93d5ca1f
JD
3352011-12-26 Jan Djärv <jan.h.d@swipnet.se>
336
337 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
338 can scroll.
339 (create_and_show_popup_menu): Always use menu_position_func for
340 Gtk3 (Bug#10361).
341
ca22b785
AS
3422011-12-24 Andreas Schwab <schwab@linux-m68k.org>
343
344 * callint.c (Fcall_interactively): Don't truncate prompt string.
345
d048e1e6
EZ
3462011-12-23 Eli Zaretskii <eliz@gnu.org>
347
348 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
349 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 350 resumed from there (after widening). (Bug#10360)
d048e1e6 351
5ccaba1f
JD
3522011-12-22 Jan Djärv <jan.h.d@swipnet.se>
353
354 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
355
204ee57f
JD
3562011-12-21 Jan Djärv <jan.h.d@swipnet.se>
357
b81d40f0
JB
358 * nsterm.m (x_free_frame_resources):
359 Release f->output_data.ns->miniimage.
204ee57f
JD
360 (ns_index_color): Fix indentation. Do not retain
361 color_table->colors[i].
362
363 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
364 before returning.
365
366 * nsfns.m (x_set_background_color): Assign return value from
367 ns_index_color to face-background instead of NSColor*.
368 (ns_implicitly_set_icon_type): Fix indentation.
369 Change assignment in for loop to comparison.
370
371 * emacs.c (ns_pool): New variable.
372 (main): Assign ns_pool.
373 (Fkill_emacs): Call ns_release_autorelease_pool.
374
375 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
376 autorelease fdesc, release fdAttrs and tdict.
377 (ns_get_covering_families): Release charset.
378 (ns_findfonts): Release NSFontDescriptor created with new.
379 (ns_uni_to_glyphs): Fix indentation.
380 (setString): Release attrStr before assigning new value.
381
c803b2b7
JD
3822011-12-18 Jan Djärv <jan.h.d@swipnet.se>
383
678f4426
JD
384 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
385 and NS_IMPL_COCOA.
386 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
387 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
388
cd394be1 3892011-12-18 David Reitter <reitter@cmu.edu>
678f4426 390
5fecd5fc
JD
391 * nsterm.m (ns_term_init): Subscribe for notifications
392 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
393 to method trackingNotification in EmacsMenu.
394
395 * nsmenu.m (trackingMenu): New variable.
3771cb17 396 (trackingNotification): New method (from Aquamacs).
5fecd5fc 397 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 398 from Aquamacs (Bug#7030).
678f4426
JD
399
4002011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 401
c803b2b7
JD
402 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
403 (symbol_to_nsstring): Fix indentation.
404 (ns_symbol_to_pb): New function.
405 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
406 (Fns_rotate_cut_buffers_internal): Removed.
407 (Fns_store_selection_internal): Renamed from
408 Fns_store_cut_buffer_internal.
409 (ns_get_foreign_selection, Fx_own_selection_internal)
410 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
411 (Fns_get_selection_internal, Fns_store_selection_internal):
412 Use ns_symbol_to_pb and check if return value is nil.
413 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
414 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
415 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
416 renamed to Sns_store_selection_internal.
417 (ns_handle_selection_request): Move code to Fx_own_selection_internal
418 and remove this function.
419 (ns_handle_selection_clear): Remove, never used.
420 (Fx_own_selection_internal): Move code from ns_handle_selection_request
421 here.
422
e1b01a3a
KB
4232011-12-17 Ken Brown <kbrown@cornell.edu>
424
425 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
426 GID is unknown (Bug#10257).
427
2adb6e85
PE
4282011-12-17 Paul Eggert <eggert@cs.ucla.edu>
429
430 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
431 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
432 which caused a build failure on GNU/Linux IA-64. This problem was
433 introduced by my 2011-10-07 patch.
434
d1d7b339
JL
4352011-12-15 Juri Linkov <juri@jurta.org>
436
437 * image.c (imagemagick_error): New function. (Bug#10112)
438 (imagemagick_load_image): Comment out `MagickSetResolution' call.
439 Use `imagemagick_error' where ImageMagick functions return
440 `MagickFalse'.
441 (Fimagemagick_types): Add `Fnreverse' to return the list in the
442 proper order.
443
100d5755
KH
4442011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
445
446 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
447 fill background (Bug#8992).
448
454592a6
MR
4492011-12-13 Martin Rudalics <rudalics@gmx.at>
450
451 * window.c (Vwindow_combination_resize)
452 (Vwindow_combination_limit): Use t instead of non-nil in
453 doc-strings.
61d4b438
MR
454 (Vrecenter_redisplay): Add first sentence of doc-string on
455 separate line.
53524d93 456 (Frecenter): Fix doc-string typo.
454592a6 457
3633e3aa
KH
4582011-12-11 Kenichi Handa <handa@m17n.org>
459
460 * coding.c (Funencodable_char_position): Pay attention to the
461 buffer text relocation (Bug#9389).
462
7b9d523a
JD
4632011-12-10 Jan Djärv <jan.h.d@swipnet.se>
464
465 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
466 gtk_init (Bug#10100).
467
b73189c6
EZ
4682011-12-10 Eli Zaretskii <eliz@gnu.org>
469
470 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
471 IT->string is nil. (Bug#10263)
472
f7dfe5d6
JD
4732011-12-10 Jan Djärv <jan.h.d@swipnet.se>
474
83faebb4
JD
475 * nsterm.h (x_free_frame_resources): Declare.
476
f7dfe5d6
JD
477 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
478 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
479
480 * nsterm.h (ns_get_defaults_value): Declare.
481
482 * nsterm.m (ns_default): Call ns_get_defaults_value.
483
7cd4e72c
EZ
4842011-12-09 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
487 (Bug#10170)
488
b34d7317
YM
4892011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
490
491 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
492 that where the value of an _OBJC_* symbol points to is in the .bss
493 section (Bug#10240).
494
76470ad1
KH
4952011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
496
497 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 498 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 499
745fff94
KH
5002011-12-08 Kenichi Handa <handa@m17n.org>
501
502 * ftfont.c (get_adstyle_property): Fix previous change
503 (Bug#10233).
504
6e44397c
JB
5052011-12-07 Juanma Barranquero <lekktu@gmail.com>
506
507 * w32.c (init_environment): If no_site_lisp, remove site-lisp
508 dirs from the default value of EMACSLOADPATH (bug#10208).
509
7efa6272
GM
5102011-12-07 Glenn Morris <rgm@gnu.org>
511
512 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
513 installation and source directories as well. (Bug#10208)
514
f6fc4d87
CY
5152011-12-06 Chong Yidong <cyd@gnu.org>
516
517 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
518
2bf26180
GM
5192011-12-06 Glenn Morris <rgm@gnu.org>
520
521 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
522 as an error, not just -1. (Bug#10217)
523
3a6ad4f0
CY
5242011-12-05 Chong Yidong <cyd@gnu.org>
525
526 * keyboard.c (process_special_events): New function.
527 (swallow_events, Finput_pending_p): Use it (Bug#10195).
528
75a3b399
PE
5292011-12-05 Paul Eggert <eggert@cs.ucla.edu>
530
531 * coding.c (encode_designation_at_bol): Don't use uninitialized
532 local variable (Bug#9318).
533
c3c9e25e
KH
5342011-12-05 Kenichi Handa <handa@m17n.org>
535
536 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
537 return Qnil (Bug#8046, Bug#10193).
538
5eb05ea3
KH
5392011-12-05 Kenichi Handa <handa@m17n.org>
540
541 * coding.c (encode_designation_at_bol): New args charbuf_end and
542 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
543 (coding_set_source): Return how many bytes coding->source was
544 relocated.
545 (coding_set_destination): Return how many bytes
546 coding->destination was relocated.
547 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
548 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
549
5502011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
551
552 * coding.c (CODING_CHAR_CHARSET_P): New macro.
553 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
554 macro (Bug#9318).
555
5562011-12-05 Andreas Schwab <schwab@linux-m68k.org>
557
558 The following changes are to fix Bug#9318.
559
a79703f5 560 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
561 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
562 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 563 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 564
7dbda6df
JB
5652011-12-05 Juanma Barranquero <lekktu@gmail.com>
566
567 * lisp.h (process_quit_flag): Fix external declaration.
568
6d5eb5b0
SM
5692011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
570
571 Don't macro-inline non-performance-critical code.
572 * eval.c (process_quit_flag): New function.
573 * lisp.h (QUIT): Use it.
574
a0c3fad0
JD
5752011-12-04 Jan Djärv <jan.h.d@swipnet.se>
576
577 * nsfns.m (get_geometry_from_preferences): New function.
578 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
579
6c07aac2
AS
5802011-12-04 Andreas Schwab <schwab@linux-m68k.org>
581
582 * emacs.c (Qkill_emacs): Define.
583 (syms_of_emacs): Initialize it.
584 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
585 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
586 (quit_throw_to_read_char): Add parameter `from_signal'.
587 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
588 * lisp.h (QUIT): Call Fkill_emacs if requested.
589
c052ead4
JD
5902011-12-03 Jan Djärv <jan.h.d@swipnet.se>
591
592 * widget.c (update_wm_hints): Return if wmshell is null.
593 (widget_update_wm_size_hints): New function.
594
595 * widget.h (widget_update_wm_size_hints): Declare.
596
597 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
598 widget_update_wm_size_hints (Bug#10104).
599
9e49252b
EZ
6002011-12-03 Eli Zaretskii <eliz@gnu.org>
601
602 * xdisp.c (handle_invisible_prop): If the invisible text ends just
603 before a newline, prepare the bidi iterator for consuming the
604 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 605 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 606
02b16839
JL
6072011-12-02 Juri Linkov <juri@jurta.org>
608
609 * search.c (Fword_search_regexp): New Lisp function created from
610 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
611 (Fword_search_backward, Fword_search_forward)
612 (Fword_search_backward_lax, Fword_search_forward_lax):
613 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
614 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
615
0068070e
SM
6162011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
617
618 * fileio.c (Finsert_file_contents): Move after-change-function call
619 to before the "handled:" label, since all "goto handled" appear in
620 cases where the *-change-functions have already been properly called
621 (bug#10117).
622
3360a3fc
AS
6232011-12-01 Andreas Schwab <schwab@linux-m68k.org>
624
625 * keyboard.c (interrupt_signal): Don't call kill-emacs when
626 waiting for input. (Bug#10169)
627
73d6c093
EZ
6282011-11-30 Eli Zaretskii <eliz@gnu.org>
629
630 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
631 verifies glyph row's hash code--we have just reallocated the
632 glyphs, so their contents can be complete garbage. (Bug#10164)
633
febe6bea
JB
6342011-11-30 Juanma Barranquero <lekktu@gmail.com>
635
636 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
637
801a4313
EZ
6382011-11-30 Eli Zaretskii <eliz@gnu.org>
639
640 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
641 attributes are tested _before_ calling verify_row_hash, to protect
642 against GCC re-ordering of the tests. (Bug#10164)
643
2b56b87e
JD
6442011-11-29 Jan Djärv <jan.h.d@swipnet.se>
645
646 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
647
648 * xterm.c (handle_one_xevent): Only set async_visible and friends
649 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 650 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
651 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
652
dbf31225
PE
6532011-11-28 Paul Eggert <eggert@cs.ucla.edu>
654
655 Remove GCPRO-related macros that exist only to avoid shadowing locals.
656 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
657 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
658 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
659 All uses changed to use GCPRO1 etc.
660 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
661 Revert to old implementation (i.e., before 2011-03-11).
662
1305621b
YM
6632011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
664
665 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
666 of scroll runs so as to avoid assigning disabled bogus rows and
667 unnecessary graphics copy operations.
668
8c9afb46
EZ
6692011-11-27 Eli Zaretskii <eliz@gnu.org>
670
671 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
672 (snprintf) [_MSC_VER]: Redirect to _snprintf.
673 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
674 (malloc, free, realloc, calloc): Redirect to e_* only when
675 compiling Emacs.
676
677 * lisp.h (GCTYPEBITS): Move before first use.
678 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
679 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
680 this macro definition.
681
682 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
683 _MSC_VER.
684
54e9e3bf
JD
6852011-11-27 Jan Djärv <jan.h.d@swipnet.se>
686
6d5eb5b0
SM
687 * gtkutil.c (xg_create_frame_widgets):
688 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
689 present with Gtk+ 2.0.
690
83aca1cb
PE
6912011-11-26 Paul Eggert <eggert@cs.ucla.edu>
692
693 * fileio.c (Finsert_file_contents): Undo previous change; see
694 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
695
5b76caa4
PE
6962011-11-26 Paul Eggert <eggert@cs.ucla.edu>
697
698 Rename locals to avoid shadowing.
699 * fileio.c (Finsert_file_contents):
700 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
701 * process.c (wait_reading_process_output):
702 Rename inner 'proc' to 'p' to avoid shadowing.
703 Indent for consistency with usual Emacs style.
704
8c535114
EZ
7052011-11-25 Eli Zaretskii <eliz@gnu.org>
706
707 * xdisp.c (redisplay_window): If cursor row is not fully visible
708 after recentering, and scroll-conservatively is set to a large
709 number, scroll window by a few more lines to make the cursor fully
710 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
711 (start_display): Don't move to the next line if the display should
712 start at a newline that is part of a display vector or an overlay
713 string. (Bug#10119)
8c535114 714
fa4fdb5c
JL
7152011-11-24 Juri Linkov <juri@jurta.org>
716
717 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
718 after the `MagickPingImage' call. (Bug#10112)
719
90ec88df
CY
7202011-11-23 Chong Yidong <cyd@gnu.org>
721
722 * window.c (Fcoordinates_in_window_p): Accept only live windows.
723
56e2e794
MR
7242011-11-23 Martin Rudalics <rudalics@gmx.at>
725
726 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
727 making another buffer current. (Bug#10114)
728
b6e64c41
GM
7292011-11-23 Glenn Morris <rgm@gnu.org>
730
731 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
732
6b21de18
CY
7332011-11-23 Chong Yidong <cyd@gnu.org>
734
735 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
736 using it (Bug#5984).
737
b12cd789
EZ
7382011-11-22 Eli Zaretskii <eliz@gnu.org>
739
740 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
741 and header-lines, as they don't have one computed for them.
742 (Bug#10098)
743
744 * .gdbinit (prow): Make displayed values more self-explaining.
745 Add row's hash code.
746
261b6fd4
LMI
7472011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
748
749 * process.c (wait_reading_process_output): Fix asynchrounous
750 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 751 (wait_reading_process_output): Add comment and URL.
261b6fd4 752
e7cfd277
JD
7532011-11-21 Jan Djärv <jan.h.d@swipnet.se>
754
755 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
756
a9b9b7f5
CY
7572011-11-21 Chong Yidong <cyd@gnu.org>
758
759 * window.c (Fnext_window, Fprevious_window): Doc fix.
760
b0d15b4f
SM
7612011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
762
763 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
764
fe7a3057
JB
7652011-11-20 Juanma Barranquero <lekktu@gmail.com>
766
767 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
768
d2999b1a
MR
7692011-11-20 Martin Rudalics <rudalics@gmx.at>
770
771 * window.c (Fset_window_combination_limit): Rename argument
772 STATUS to LIMIT.
773 (Vwindow_combination_limit): Remove "status" from doc-string.
774
d5ff9cd0
AS
7752011-11-20 Andreas Schwab <schwab@linux-m68k.org>
776
777 * m/ibms390.h: Remove.
778 * m/ibms390x.h: Don't include "ibms390.h".
779
a5bb9bd3
SM
7802011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
781
782 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
783 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
784
cd1181db
JB
7852011-11-20 Juanma Barranquero <lekktu@gmail.com>
786
787 * casetab.c (Fset_case_table):
788 * charset.c (Fcharset_after): Fix typos.
789
615a3b8d 7902011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 791
17e845af
PE
792 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
793 Otherwise, valgrind does not work on some platforms.
794 Problem reported by Andreas Schwab in
6a0bf43d
PE
795 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
796 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
797 is set, removing the need for VIRT_ADDRESS_VARIES.
798 (PURE_P): Use a more-efficient implementation that needs just one
799 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
800 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
801 to 4 (xorl, subq, cmpq, setbe).
802 * alloc.c (pure): Always extern now, since that's the
803 VIRT_ADDR_VARIES behavior.
804 (PURE_POINTER_P): Use a single comparison, not two, for
805 consistency with the new puresize.h.
806 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
807 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
808 Remove VIRT_ADDR_VARIES no longer needed.
809
f8fe6f96
EZ
8102011-11-19 Eli Zaretskii <eliz@gnu.org>
811
812 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
813 (erase_phys_cursor, update_window_cursor, show_mouse_face)
814 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
815 behave as if the cursor position were at the window margin.
816
817 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
818 and the cursor position is out of bounds, behave as if the cursor
819 position were at the window margin. (Bug#10075)
820
df05a53c
CY
8212011-11-18 Chong Yidong <cyd@gnu.org>
822
823 * window.c (Fwindow_combination_limit): Make first argument
824 non-optional, since it is meaningless for live windows like the
825 selected window.
826
2071918e
DA
8272011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
828
829 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
830
b50a28de
SM
8312011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
832
833 * intervals.c: Fix grafting over the whole buffer (bug#10071).
834 (graft_intervals_into_buffer): Simplify.
835
015137db
EZ
8362011-11-18 Eli Zaretskii <eliz@gnu.org>
837
838 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
839 hash values of the two rows.
840 (copy_row_except_pointers): Preserve the used[] arrays and the
841 hash values of the two rows. (Bug#10035)
68c95424 842 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
843
844 * xdisp.c (row_hash): New function, body extracted from
845 compute_line_metrics.
846 (compute_line_metrics): Call row_hash, instead of computing the
847 hash code inline.
848
849 * dispnew.c (verify_row_hash): Call row_hash for computing the
850 hash code of a row, instead of duplicating code from xdisp.c.
851
852 * dispextern.h (row_hash): Add prototype.
853
a2addb04
TH
8542011-11-18 Tassilo Horn <tassilo@member.fsf.org>
855
856 * frame.c (delete_frame): Don't delete the terminal when the last
857 X frame is closed if emacs is built with GTK toolkit.
858
df85d315
JB
8592011-11-17 Juanma Barranquero <lekktu@gmail.com>
860
861 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
862
a0c2d0ae
MR
8632011-11-17 Martin Rudalics <rudalics@gmx.at>
864
865 * window.c (Vwindow_splits): Rename to
866 Vwindow_combination_resize. Suggested by Juri Linkov.
867 (Fsplit_window_internal): Use Vwindow_combination_resize instead
868 of Vwindow_splits.
869
58179cce
JB
8702011-11-16 Juanma Barranquero <lekktu@gmail.com>
871
7877f373
JB
872 * nsfns.m (Fns_font_name):
873 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 874
b6f67890
MR
8752011-11-16 Martin Rudalics <rudalics@gmx.at>
876
877 * window.h (window): Rename slot "nest" to "combination_limit".
878 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
879 (Fset_window_nest): Rename to Fset_window_combination_limit.
880 (Vwindow_nest): Rename to Vwindow_combination_limit.
881 (recombine_windows, make_parent_window, make_window)
882 (Fsplit_window_internal, saved_window)
883 (Fset_window_configuration, save_window_save): Rename all
884 occurrences of window_nest to window_combination_limit.
885
c7015153
JB
8862011-11-15 Juanma Barranquero <lekktu@gmail.com>
887
888 * image.c (imagemagick_load_image): Fix typo.
889
322ad6ec
EZ
8902011-11-14 Eli Zaretskii <eliz@gnu.org>
891
892 * xdisp.c (display_line): Move the call to
893 highlight_trailing_whitespace before the call to
894 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
895 faces of all the glyphs to compute ROW's hash value.
896 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 897
f067b8ec
JB
8982011-11-14 Juanma Barranquero <lekktu@gmail.com>
899
900 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
901 just return (bug#10044).
902
1e5b2111
EZ
9032011-11-12 Eli Zaretskii <eliz@gnu.org>
904
7ef3cbd5
EZ
905 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
906 with user-defined heap size. Bump the default size of the temacs
907 heap to 27MB, to avoid memory warning when running temacs.
908 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
909
1e5b2111
EZ
910 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
911 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
912 (verify_row_hash) [XASSERTS]: New function.
913 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
914 that the hash value of glyph rows is correct.
1e5b2111 915
89d61221
MR
9162011-11-12 Martin Rudalics <rudalics@gmx.at>
917
918 * window.h (window): Remove splits slot.
919 * window.c (Fwindow_splits, Fset_window_splits): Remove.
920 (Fdelete_other_windows_internal, make_parent_window)
921 (make_window, Fsplit_window_internal, Fdelete_window_internal)
922 (Fset_window_configuration, save_window_save): Don't deal with
923 split status of windows.
924 (saved_window): Remove splits slot.
925 (Vwindow_splits): Rewrite doc-string.
926
97f18cc8
JD
9272011-11-11 Jan Djärv <jan.h.d@swipnet.se>
928
929 * xfns.c (unwind_create_frame):
930 * nsfns.m (unwind_create_frame):
931 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
932 Vframe_list (Bug#9999).
933
22a648b4
DA
9342011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
935
0b381c7e 936 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 937
659afede
KH
9382011-11-11 Kenichi Handa <handa@m17n.org>
939
940 * callproc.c (Fcall_process): Set the member dst_multibyte of
941 process_coding.
942
9ac0394b
KH
9432011-11-11 Johan Bockgård <bojohan@gnu.org>
944
945 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
946 avoid a crash (bug#9496).
947
2fbdc249
CY
9482011-11-09 Chong Yidong <cyd@gnu.org>
949
950 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
951 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
952
ac6b1f81
PE
9532011-11-08 Paul Eggert <eggert@cs.ucla.edu>
954
955 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
956
09db192c
PE
9572011-11-08 Paul Eggert <eggert@cs.ucla.edu>
958
959 Avoid some portability problems by eschewing 'extern inline' functions.
960 The trivial performance wins aren't worth the portability hassles; see
961 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
962 et seq.
963 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
964 (window_box_width, window_box_left, window_box_left_offset)
965 (window_box_right, window_box_right_offset): Undo previous change,
966 by removing the "extern"s.
967 * intervals.c (adjust_intervals_for_insertion)
968 (adjust_intervals_for_deletion): Undo previous change,
969 making these static again.
970 (offset_intervals, temp_set_point_both, temp_set_point)
971 (copy_intervals_to_string): No longer inline.
972 * xdisp.c (window_text_bottom_y, window_box_width)
973 (window_box_height, window_box_left_offset)
974 (window_box_right_offset, window_box_left, window_box_right)
975 (window_box): No longer inline.
976
105216ed
CY
9772011-11-08 Chong Yidong <cyd@gnu.org>
978
979 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
980 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
981 Signal an error if not a live window.
105216ed
CY
982 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
983 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
984
ae9e237f
JB
9852011-11-07 Juanma Barranquero <lekktu@gmail.com>
986
987 * lisp.h (syms_of_abbrev): Remove declaration.
988 Reported by CHENG Gao <chenggao@royau.me>.
989
c7aa8333
EZ
9902011-11-07 Eli Zaretskii <eliz@gnu.org>
991
992 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
993 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
994 of temacs in GUI mode.
995
be7f5545
MR
9962011-11-07 Martin Rudalics <rudalics@gmx.at>
997
998 * window.h: Declare delete_all_child_windows instead of
999 delete_all_subwindows.
1000 * window.c (Fwindow_nest, Fset_window_nest)
1001 (Fset_window_new_total, Fset_window_new_normal)
1002 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1003 (delete_all_subwindows): Rename to delete_all_child_windows.
1004 (Fdelete_other_windows_internal, Fset_window_configuration):
1005 Call delete_all_child_windows instead of delete_all_subwindows.
1006 * frame.c (delete_frame): Call delete_all_child_windows instead
1007 of delete_all_subwindows.
1008
ca78dc43
PE
10092011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1012 This is also needed for porting to any host where GC_MARK_STACK is
1013 not GC_MAKE_GCPROS_NOOPS.
1014 (which_symbols): Use it.
1015
a0241d01
KH
10162011-11-07 Kenichi Handa <handa@m17n.org>
1017
1018 * coding.c (coding_set_destination): Check coding->src_pos only
1019 when coding->src_object is a buffer (bug#9910).
1020
1021 * process.c (send_process): Set the member src_multibyte of coding
1022 to 0 (bug#9911) when sending a unibyte text.
1023
1024 * callproc.c (Fcall_process): Set the member src_multibyte of
1025 process_coding to 0 (bug#9912).
1026
a64bfdfa 10272011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1028
1029 * xmenu.c (cleanup_widget_value_tree): New function.
1030 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1031 calling free_menubar_widget_value_tree directly (Bug#9830).
1032
cb41b32a
PE
10332011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 Fix some portability problems with 'inline'.
1036 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1037 (window_box_width, window_box_left, window_box_left_offset)
1038 (window_box_right, window_box_right_offset): Declare extern.
1039 Otherwise, these inline functions do not conform to C99 and
1040 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1041 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1042 * intervals.c (adjust_intervals_for_insertion)
1043 (adjust_intervals_for_deletion): Now extern, because otherwise the
1044 extern inline functions 'offset_intervals' couldn't refer to it.
1045 (static_offset_intervals): Remove.
1046 (offset_intervals): Rewrite using the old contents of
1047 static_offset_intervals. The old version didn't conform to C99
1048 because an extern inline function contained a reference to an
1049 identifier with static linkage.
1050
b7041366
AS
10512011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1052
1053 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1054 GC.
1055
88a37c4d
EZ
10562011-11-06 Eli Zaretskii <eliz@gnu.org>
1057
1058 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1059 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1060 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1061 return Qleft_to_right.
1062
49745b39
CY
10632011-11-06 Chong Yidong <cyd@gnu.org>
1064
1065 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1066 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1067 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1068 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1069 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1070 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1071 (Fwindow_vscroll): Doc fix.
1072 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1073 argument, since it makes no sense to pass a live window and for
1074 consistency with window-child.
1075
1f05cd82
CS
10762011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1077
1078 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1079 support MSVC.
1080
22610910
JR
10812011-11-05 Jason Rumney <jasonr@gnu.org>
1082
1083 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1084 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1085 fonts (Bug#6029).
1086 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1087 bitwise arithmetic preventing use of unicode-sip and non-truetype
1088 opentype fonts.
1089
a06776b2
EZ
10902011-11-05 Eli Zaretskii <eliz@gnu.org>
1091
3ad924ba
EZ
1092 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1093 "emacs"-only part.
1094
a06776b2
EZ
1095 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1096 initialization code to keep similarity to xfns.c after changes
1097 from 2011-11-05.
1098
c9e7db78
JD
10992011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1100
a97f8f3f
JD
1101 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1102 (unwind_create_frame): New function (Bug#9943).
1103 (Fx_create_frame): Restructure code to be more similar to the one in
1104 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1105 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1106 Move terminal->reference_count++ just before making the frame official
1107 (Bug#9943).
1108
1109 * nsterm.m (x_free_frame_resources): New function.
1110 (x_destroy_window): Move code to x_free_frame_resources.
1111
c9e7db78 1112 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1113 (Fx_create_frame, x_create_tip_frame):
1114 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1115 official. Move initialization of image_cache_refcount and
1116 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1117
a6fc3b5c
EZ
11182011-11-05 Eli Zaretskii <eliz@gnu.org>
1119
1120 Support MSVC build with newer versions of Visual Studio.
1121 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1122 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1123 nt/gmake.defs.
1124
1125 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1126 which are not supported by MSVC.
1127 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1128 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1129 bitfields.
1130 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1131 types in bitfields.
1132 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1133
1134 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1135
58179cce 11362011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1137
1138 Support MSVC build with newer versions of Visual Studio.
1139 * w32.c: Don't include w32api.h for MSVC.
1140 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1141
1142 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1143 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1144 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1145 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1146 e_* cousins.
1147 (alloca) [_MSC_VER]: Define to _alloca.
1148
1149 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1150
1151 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1152
a58c13ed
EZ
11532011-11-04 Eli Zaretskii <eliz@gnu.org>
1154
1155 * xdisp.c (note_mouse_highlight): If either of
1156 previous/next-single-property-change returns nil, treat that as
1157 the beginning or the end of the buffer. (Bug#9955)
1158
fe0b6370
JD
11592011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1160
a58c13ed 1161 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1162 label is not null (Bug#9951).
1163 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1164 may be NULL.
1165
89bd5ee1
EZ
11662011-11-04 Eli Zaretskii <eliz@gnu.org>
1167
1168 * window.c (Fwindow_body_size): Mention in the doc string that the
1169 return value is in frame's canonical units. (Bug#9949)
1170
84c3edb9
EZ
11712011-11-03 Eli Zaretskii <eliz@gnu.org>
1172
4e2fb5c7
EZ
1173 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1174
84c3edb9 1175 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1176 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1177 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1178
bc17a887
EZ
11792011-11-01 Eli Zaretskii <eliz@gnu.org>
1180
1181 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1182 Don't stop backward scan on the continuation glyph, even though
1183 its CHARPOS is positive.
6d5eb5b0
SM
1184 (mouse_face_from_buffer_pos, note_mouse_highlight):
1185 Rename cover_string to disp_string.
bc17a887 1186
4ee88440
MR
11872011-11-01 Martin Rudalics <rudalics@gmx.at>
1188
1189 * window.c (temp_output_buffer_show): Don't use
1190 Vtemp_buffer_show_specifiers.
1191 (Vtemp_buffer_show_specifiers): Remove unused variable.
1192
c2ff3c02
EZ
11932011-10-30 Eli Zaretskii <eliz@gnu.org>
1194
1195 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1196 past the beginning of the current glyph matrix.
1197
58179cce 11982011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1199
1200 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1201 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1202 HAVE_GTK3 (Bug#9869).
b77a6a7f 1203
3b574623
JD
1204 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1205 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1206
b77a6a7f
JD
1207 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1208
1209 * xterm.c: Declare x_handle_net_wm_state to return int.
1210 (handle_one_xevent): Check if we are iconified but don't have
1211 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1212 (get_current_wm_state): Return non-zero if not hidden,
1213 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1214 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1215 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1216 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1217
196e41e4
PE
12182011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1221 so that this new function doesn't get optimized away by a
1222 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1223
021f2e1a
AS
12242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1225
1226 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1227
8b058d44
EZ
12282011-10-29 Eli Zaretskii <eliz@gnu.org>
1229
1230 Fix the `xbytecode' command.
1231 * .gdbinit (xprintbytestr): New command.
b50a28de 1232 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1233 (xbytecode): Print the byte-code string as well.
1234
4452fb80
EZ
12352011-10-29 Kim Storm <storm@cua.dk>
1236
8b058d44
EZ
1237 * alloc.c (which_symbols): New function.
1238
21b72067
AS
12392011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1240
1241 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1242 line. (Bug#9903)
1243
83ed7b5c
GM
12442011-10-29 Glenn Morris <rgm@gnu.org>
1245
1246 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1247 Not clear what it was for, and it causes various bugs. (Bug#9839)
1248
5a7a728b
EZ
12492011-10-28 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1252 possible random value that matches one of those tested as
1253 condition to clear the mouse face.
1254
d3d0842f
CY
12552011-10-28 Chong Yidong <cyd@gnu.org>
1256
1257 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1258
31b39d13
DN
12592011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1260
1261 * window.c (make_window): Initialize phys_cursor_on_p.
1262
9aba6043
SM
12632011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1264
1265 * lisp.h (struct Lisp_Symbol): Update comments.
1266
c20992f4
JB
12672011-10-28 Juanma Barranquero <lekktu@gmail.com>
1268
1269 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1270
db4f02f2
EZ
12712011-10-28 Eli Zaretskii <eliz@gnu.org>
1272
1273 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1274 <oslsachem@gmail.com> for helping to debug this.
1275
1276 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1277 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1278 (g_b_init_get_glyph_outline_w): New static variables.
1279 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1280 (GetGlyphOutlineW_Proc): New typedefs.
1281 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1282 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1283 New functions.
1284 (w32font_open_internal, compute_metrics):
1285 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1286 instead of calling the "wide" APIs directly.
1287
1288 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1289
1290 * w32.h (syms_of_w32font): Add prototype.
1291
87e68db4
JB
12922011-10-27 Juanma Barranquero <lekktu@gmail.com>
1293
1294 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1295 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1296 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1297 (Fmove_to_window_line): Doc fix.
1298
435c1d67
CY
12992011-10-27 Chong Yidong <cyd@gnu.org>
1300
1301 * process.c (make_process): Set gnutls_state to NULL.
1302
1303 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1304 non-NULL, regardless of GNUTLS_INITSTAGE.
1305 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1306 an error. Set process slots as soon as we allocate them.
1307
1308 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1309
9c6c6f49
CY
13102011-10-27 Chong Yidong <cyd@gnu.org>
1311
9aba6043
SM
1312 * gnutls.c (emacs_gnutls_deinit): New function.
1313 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1314 (Fgnutls_deinit, Fgnutls_boot): Use it.
1315
1316 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1317 (deactivate_process): Call emacs_gnutls_deinit.
1318
657d08d3
JB
13192011-10-27 Juanma Barranquero <lekktu@gmail.com>
1320
1321 * image.c (x_create_x_image_and_pixmap):
1322 * w32.c (sys_rename, w32_delayed_load):
1323 * w32font.c (fill_in_logfont):
1324 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1325
5430d399
JB
13262011-10-26 Juanma Barranquero <lekktu@gmail.com>
1327
1328 * w32fns.c (w32_default_color_map): New function,
1329 extracted from Fw32_default_color_map.
a7ef684b 1330 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1331
fe0055fa
PE
13322011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1335
e6346438
SM
13362011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1337
1338 * keyboard.c (test_undefined): New function (bug#9751).
1339 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1340
e112cc37
ET
13412011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1342
1343 * sysdep.c (init_sys_modes): Fix the check for the controlling
1344 terminal (Bug#6649).
1345
7b5d6677
EZ
13462011-10-20 Eli Zaretskii <eliz@gnu.org>
1347
1348 * dispextern.h (struct bidi_it): New member next_en_type.
1349
1350 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1351 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1352 current character, check also for next_en_type being WEAK_EN.
1353 (bidi_resolve_weak): Don't enter the expensive loop if the current
1354 position is before next_en_pos. Record the bidi type of the first
1355 non-ET, non-BN character we find, in addition to its position.
1356 (bidi_level_of_next_char): Invalidate next_en_type when
1357 next_en_pos is over-stepped.
1358
7da0b018
PE
13592011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1362 * editfns.c: Rewrite current-time-zone so that it invokes
1363 the equivalent of (format-time-string "%Z") to get the time zone name.
1364 This fixes a bug when the time zone name contains characters that
1365 need converting from the system time locale to Emacs internal format.
1366 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1367 that patch fixed format-time-string to do the conversion, but
1368 I forgot to fix current-time-zone.
1369 (format_time_string): New function, containing most of
1370 what Fformat_time_string used to contain.
1371 (Fformat_time_string): Rewrite in terms of format_time_string.
1372 This doesn't change this function's behavior.
1373 (current-time-zone): Rewrite to use format_time_string.
1374 This fixes the bug reported by Michael Schierl in
1375 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1376 Jason Rumney's 2007-06-07 change worked around this bug, but
1377 didn't fix it.
1378 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1379
8547b010
EZ
13802011-10-19 Eli Zaretskii <eliz@gnu.org>
1381
1382 * xdisp.c (start_display): If the character at POS is displayed
1383 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1384 (try_window_reusing_current_matrix): If a line ends in a display
1385 vector or the next line starts in a display vector, continue
1386 redrawing the window even though the character position of
1387 start_row was reached.
8547b010
EZ
1388 (Bug#9771, part 2)
1389
4e948d15
CY
13902011-10-18 Chong Yidong <cyd@gnu.org>
1391
1392 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1393 with nobreak-char-display too.
1394
4787455f
EZ
13952011-10-18 Eli Zaretskii <eliz@gnu.org>
1396
1397 Fix part 3 of bug#9771.
1398 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1399 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1400 non-neutral characters if the current character is a paragraph
1401 separator (a.k.a. Newline). This avoids running the same
1402 expensive loop twice, once when we consume the preceding newline
1403 and the other time when the line actually needs to be displayed.
1404 Avoid the loop when we see neutrals on the base embedding level
1405 following a character whose directionality is the same as the
1406 paragraph's. This avoids running the expensive loop when a line
1407 ends in a long sequence of neutrals, like control characters.
1408 Add assertion against STRONG_AL type. Slightly rearrange code
1409 that determines the type of a neutral given the first non-neutral
1410 that follows it.
1411 (bidi_level_of_next_char): Set next_en_pos to zero when
1412 invalidating its info.
1413
2c91f553
EZ
14142011-10-17 Eli Zaretskii <eliz@gnu.org>
1415
1416 * xdisp.c (push_display_prop): Determine whether to record string
1417 or buffer position by IT->string, not by IT->method. Allow
1418 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1419 (move_it_vertically_backward): Don't look for character position
1420 immediately after the newline when in a continuation line.
1421 (Bug#9771, part 1)
2c91f553 1422
c7b08b0d
MR
14232011-10-15 Martin Rudalics <rudalics@gmx.at>
1424
1425 * window.c (coordinates_in_window): Rewrite and delabelize
1426 vertical border check. (Bug#5357) (Bug#9618)
1427
6b02f655
SM
14282011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1429
1430 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1431 errors in XSetWindowBorder (bug#9310).
1432
81d40c92
DA
14332011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1434
1435 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1436 avoid crash when xmalloc overrun checking is enabled.
1437
d4172c3b
EZ
14382011-10-13 Eli Zaretskii <eliz@gnu.org>
1439
1440 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1441 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1442 cursor motion with <left> and <right> arrow keys.
1443
1444 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1445 some callers set that themselves.
1446
b00eea75
EZ
14472011-10-12 Eli Zaretskii <eliz@gnu.org>
1448
1449 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1450 display string and the previous row comes from the same string and
1451 is empty. (Bug#9739) (Bug#9738)
1452
8fe012c4
SM
14532011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1454
1455 * doc.c (get_doc_string): Encode file name (bug#9735).
1456
0074aef2
EZ
14572011-10-12 Eli Zaretskii <eliz@gnu.org>
1458
79beb178
EZ
1459 * bidi.c (bidi_level_of_next_char):
1460 * xdisp.c (get_visually_first_element): Remove old incorrect
1461 comments regarding the Unicode Line Separator character.
1462
0074aef2
EZ
1463 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1464
6e4b3fbe
DA
14652011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1466
1467 * alloc.c (Fgc_status): Do not access beyond zombies array
1468 boundary if nzombies > MAX_ZOMBIES.
1469 * alloc.c (dump_zombies): Add missing format specifier.
1470
0324f3af
PE
14712011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1472
b5525cac
PE
1473 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1474 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1475
0324f3af
PE
1476 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1477 Some packages use them to denote characters with modifiers.
1478
e9b5f888
AS
14792011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1480
1481 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1482 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1483 matching a pp-number. Rename parameter var to var1.
1484
127827c0
SM
14852011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1486
1487 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1488
c8fd3bd0
GM
14892011-10-08 Glenn Morris <rgm@gnu.org>
1490
1491 * callint.c (Fcall_interactively): Give a more explicit error for the
1492 'c' case with a non-character input. (Bug#8479)
1493
352ec8ff
EZ
14942011-10-08 Eli Zaretskii <eliz@gnu.org>
1495
03669ccb
EZ
1496 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1497 lines.
7061c986
EZ
1498 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1499 lines that are hscrolled on the left.
03669ccb 1500
352ec8ff
EZ
1501 * dispnew.c (buffer_posn_from_coords): Account for a possible
1502 presence of header-line. (Bug#4426)
1503
a66cfb1c
SM
15042011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1505
6b02f655
SM
1506 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1507 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1508
7c5ee88e
PE
15092011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1510
1511 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1512 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1513 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1514 this makes Emacs dump core during garbage collection on rare
1515 occasions. sizeof is obviously inferior to offsetof here, so
1516 stick with offsetof.
1517 (GC_POINTER_ALIGNMENT): New macro.
1518 (mark_memory): Omit 3rd (offset) arg; caller changed.
1519 Don't assume EMACS_INT alignment is the same as pointer alignment.
1520
df1bbe5b
SM
15212011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1522
1523 * keyboard.c (read_key_sequence_remapped): New var.
1524 (read_key_sequence): Compute remapping in the right buffer.
1525 (command_loop_1): Use read_key_sequence's remapping directly.
1526
51553db6
SM
15272011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1528
32c1fffd
SM
1529 * dired.c (file_name_completion): Don't expand file name.
1530 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1531 before checking file name handler.
1532
51553db6
SM
1533 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1534 they've been requested explicitly (bug#9591).
1535
b6bd1599 15362011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1537
1538 * keymap.c (Fsingle_key_description): Use make_specified_string
1539 instead of build_string to build string from push_key_description.
1540 (Bug#5193)
1541
f701dc2a
PE
15422011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1543
4222c55d
PE
1544 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1545 This fixes a Y2038 bug on 64-bit hosts.
1546 * buffer.c (reset_buffer):
1547 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1548 (Fclear_buffer_auto_save_failure):
1549 Use 0, not -1, to represent an unset failure time, since time_t
1550 might not be signed.
1551
f701dc2a
PE
1552 Remove dependency on glibc malloc internals.
1553 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1554 Move back here from lisp.h, but with their new implementations.
1555 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1556 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1557 * charset.c (charset_table_init): New static var.
1558 (syms_of_charset): Use it instead of xmalloc. This removes a
1559 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1560 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1561 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1562 Move back to alloc.c.
1563 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1564 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1565
9ceebf39
JD
15662011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1567
1568 * nsterm.m (windowDidResize): Call x_set_window_size only when
1569 ns_in_resize is true. Otherwise set pixelwidth/height and
1570 call change_frame_size (Bug#9628).
1571
cb993c58
PE
15722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1573
3930c88b
PE
1574 Port --enable-checking=all to Fedora 14 x86-64.
1575 * charset.c (syms_of_charset): Also account for glibc malloc's
1576 internal overhead when calculating the initial malloc maximum.
1577
cb993c58
PE
1578 Port --enable-checking=all to Fedora 14 x86.
1579 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1580 Move to lisp.h.
1581 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1582 (overrun_check_realloc, overrun_check_free):
1583 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1584 That way, xmalloc returns a properly-aligned pointer even if
1585 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1586 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1587 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1588 into account when calculating the initial malloc maximum.
1589 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1590 Move here from alloc.c, so that charset.c can use it too.
1591 Properly align; the old code wasn't right for common 32-bit hosts
1592 when configured with --enable-checking=all.
1593 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1594 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1595
31bed486
EZ
15962011-09-29 Eli Zaretskii <eliz@gnu.org>
1597
04c70788 1598 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1599 use EDOM.
1600
fbcaa2f3
EZ
16012011-09-28 Eli Zaretskii <eliz@gnu.org>
1602
1603 * xdisp.c (compute_display_string_end): If there's no display
1604 string at CHARPOS, return -1.
1605
1606 * bidi.c (bidi_fetch_char): When compute_display_string_end
1607 returns a negative value, treat the character as a normal
1608 character not covered by a display string. (Bug#9624)
1609
a239d4e9
JB
16102011-09-28 Juanma Barranquero <lekktu@gmail.com>
1611
1612 * lread.c (Fread_from_string): Fix typo in docstring.
1613
88652fd5
EZ
16142011-09-27 Eli Zaretskii <eliz@gnu.org>
1615
1616 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1617 newline, reseat the iterator instead of bidi-iterating there one
1618 character at a time. (Bug#9610)
32c1fffd
SM
1619 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1620 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1621
ed497dd4
AS
16222011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1623
1624 * lread.c (readevalloop): Use correct code for NBSP.
1625 (read1): Likewise. (Bug#9608)
1626
b2bf61aa
MA
16272011-09-25 Michael Albinus <michael.albinus@gmx.de>
1628
1629 * dbusbind.c (Fdbus_register_signal): When service is not
1630 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1631
32bbb17c
GM
16322011-09-25 Glenn Morris <rgm@gnu.org>
1633
1634 * buffer.c (truncate-lines): Doc fix.
1635
94e0933e
CY
16362011-09-24 Chong Yidong <cyd@stupidchicken.com>
1637
1638 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1639 (Fset_window_next_buffers): Doc fix.
1640
cddde921
GM
16412011-09-24 Glenn Morris <rgm@gnu.org>
1642
1643 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1644
1260aef1
PE
16452011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1646
25b4bfa0
PE
1647 Fix minor problems found by static checking.
1648 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1649 * indent.c (Fvertical_motion): Fix == vs = typo.
1650
e3cbd34b
EZ
16512011-09-24 Eli Zaretskii <eliz@gnu.org>
1652
a66cfb1c
SM
1653 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1654 Default value is now t. Doc fix.
6bf7006f 1655
e3cbd34b 1656 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1657 logic when moving up, not only when moving down. Fix the
e3cbd34b 1658 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1659 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1660
1661 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1662 CHARPOS is covered by a display string which includes newlines.
1663 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1664 is covered by a display string with embedded newlines.
1665
a3de0cbd
MA
16662011-09-24 Michael Albinus <michael.albinus@gmx.de>
1667
1668 * dbusbind.c (Fdbus_register_signal): Add match rule to
1669 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1670 (Fdbus_register_method, Vdbus_registered_objects_table):
1671 Fix docstring.
a3de0cbd 1672
b260039d
JM
16732011-09-24 Jim Meyering <meyering@redhat.com>
1674
32c1fffd 1675 do not ignore write error for any output size
b260039d
JM
1676 The previous change was incomplete.
1677 While it makes emacs --batch detect the vast majority of stdout
1678 write failures, errors were still ignored whenever the output size is
1679 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1680 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1681 && echo FAIL: ignored write error
1682 FAIL: ignored write error
1683 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1684 && echo FAIL: ignored write error
1685 FAIL: ignored write error
1686 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1687
8eca8a7c
AS
16882011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1689
1690 * emacs.c (Fkill_emacs): In noninteractive mode exit
1691 non-successfully if a write error occurred on stdout. (Bug#9574)
1692
3341db62
EZ
16932011-09-21 Eli Zaretskii <eliz@gnu.org>
1694
1695 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1696 the xassert test.
1697
1698 * dispextern.h (struct it): Update the comment documenting what
1699 can it->OBJECT be.
1700
8c203dbf
EZ
17012011-09-20 Eli Zaretskii <eliz@gnu.org>
1702
1703 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1704 a display string, extend search for cursor position to end of row.
1705 (find_row_edges): If the row ends in a newline from a display
1706 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1707 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1708 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1709 non-empty line. Fixes confusing cursor motion with arrow keys at
1710 the beginning of a line that starts with whitespace.
8c203dbf 1711
a4824228
LMI
17122011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1713
1714 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1715 (bug#9493).
1716
33ed493b
CY
17172011-09-18 Chong Yidong <cyd@stupidchicken.com>
1718
1719 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1720 boolean (Bug#9154).
1721
56cd55c8
EZ
17222011-09-18 Eli Zaretskii <eliz@gnu.org>
1723
1724 * xdisp.c (display_line): Record maximum and minimum buffer
1725 positions even if no glyphs were produced (e.g., by a zero-width
1726 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1727 buffer positions that will be removed from the glyph row because
1728 they don't fit.
c02dcedf
EZ
1729 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1730 column is beyond frame width: don't subtract 1 "pixel" when
1731 computing width of the stretch.
3e62b7e0
EZ
1732 (reseat_at_next_visible_line_start): Undo the change made on
1733 2011-09-17 that saved paragraph information and restored it after
1734 the call to `reseat'. (Bug#9545)
56cd55c8 1735
5ed99d36 17362011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1737
1738 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1739 and turn window cursor on if cleared (Bug#9415).
1740
5ed99d36 17412011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1742
1743 * search.c (boyer_moore): Take unibyte characters from pattern
1744 literally. (Bug#9458)
1745
9bade7b2
EZ
17462011-09-18 Eli Zaretskii <eliz@gnu.org>
1747
1748 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1749
e5e9d610
PE
17502011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1751
87e4427a
PE
1752 Fix minor problem found by static checking.
1753 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1754 initialized, to pacify gcc -Wuninitialized.
1755
e5e9d610
PE
1756 * fileio.c: Report proper errno when syscall falls.
1757 (Finsert_file_contents): Save and restore errno,
1758 so that report_file_error outputs the correct diagnostic.
1759 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1760
a1674f0b
EZ
17612011-09-18 Eli Zaretskii <eliz@gnu.org>
1762
1763 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1764
fbfb6dd4
EZ
17652011-09-17 Eli Zaretskii <eliz@gnu.org>
1766
1767 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1768 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1769
bb187662
EZ
17702011-09-17 Eli Zaretskii <eliz@gnu.org>
1771
1137e8b8 1772 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1773 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1774
1775 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1776 (bidi_find_paragraph_start): Search back for paragraph beginning
1777 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1778 (bidi_move_to_visually_next): Only trigger paragraph-related
1779 computations when the last character is a newline or at EOB, not
1780 just any NEUTRAL_B. (Bug#9470)
1781
bb187662
EZ
1782 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1783 truncated lines if point is covered by a display string. (Bug#9524)
1784
2e621251
PE
17852011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1788 (cons_to_x_long): New function.
1789 (lisp_data_to_selection_data): Use it. Correct the test for
1790 short-versus-long data; it was negated. Break out of vector
1791 loop, for efficiency, when a long datum is discovered.
1792
91a15bc6
SM
17932011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1794
1795 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1796
b41c3a35
EZ
17972011-09-16 Eli Zaretskii <eliz@gnu.org>
1798
1799 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1800 GCC PR/17406) by declaring this function with external scope.
1801
7812ba2d
PE
18022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1805 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1806
cf7edc2a
AS
18072011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1808
1809 * editfns.c (Fformat): Correctly handle text properties on "%%".
1810
bd01620e
EZ
18112011-09-15 Eli Zaretskii <eliz@gnu.org>
1812
1813 * xterm.c (x_draw_composite_glyph_string_foreground):
1814 * w32term.c (x_draw_composite_glyph_string_foreground):
1815 * term.c (encode_terminal_code):
1816 * composite.c (composition_update_it, get_composition_id):
1817 * xdisp.c (get_next_display_element)
1818 (fill_composite_glyph_string): Add comments about special meaning
1819 of TAB characters in a composition.
1820
a02719a3
PE
18212011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1824 This occurs when processing a multibyte format.
1825 Problem reported by Wolfgang Jenker.
a02719a3 1826
72589a3c
JB
18272011-09-15 Johan Bockgård <bojohan@gnu.org>
1828
1829 * xdisp.c (try_cursor_movement): Only check for exact match if
1830 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1831
1c14176c
PE
18322011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1833
1834 Remove unused external symbols.
1835 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1836 * xdisp.c (calc_pixel_width_or_height): Now static.
1837 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1838 * indent.c (check_display_width):
1839 * w32term.c: Fix comment to match code.
1840 * xterm.c, xterm.h (x_catching_errors): Remove.
1841
d2eea5b5
PE
18422011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 * xselect.c: Use signed conversions more consistently (Bug#9498).
1845 (selection_data_to_lisp_data): Assume incoming selection data are
1846 signed integers, not unsigned. This is to be consistent with
1847 outgoing selection data, which was modified to use signed integers
1848 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1849 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1850 expects long, not unsigned long.
1851
46888499
EZ
18522011-09-14 Eli Zaretskii <eliz@gnu.org>
1853
1854 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1855 computation of loop end. Reported by Johan Bockgård
1856 <bojohan@gnu.org>.
1857
ef8ef9fb
CY
18582011-09-13 Chong Yidong <cyd@stupidchicken.com>
1859
1860 * frame.c (Fother_visible_frames_p): Function deleted.
1861
fa819fed
EZ
18622011-09-12 Eli Zaretskii <eliz@gnu.org>
1863
1864 * indent.c (compute_motion): Process display vector front to back
1865 rather than the other way around. (Bug#2496)
1866
2ba8e008
SM
18672011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1868
1869 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1870
20f53c69
CY
18712011-09-11 Chong Yidong <cyd@stupidchicken.com>
1872
1873 * minibuf.c (Fread_from_minibuffer): Doc fix.
1874
d562d7a4
EZ
18752011-09-11 Eli Zaretskii <eliz@gnu.org>
1876
1877 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1878 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1879
1c4d7f3d
LMI
18802011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1881
1882 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1883 value for non-existent files.
1884
b885bf36
EZ
18852011-09-11 Eli Zaretskii <eliz@gnu.org>
1886
1887 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1888 set its "size" to -1. This will set the modtime_size field of
1889 the corresponding buffer to -1, which is what
1890 verify-visited-file-modtime expects for files that do not exist.
1891 (Bug#9139)
1892
6612f0bf
PE
18932011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1896 here ...
1897 * lisp.h: ... from here. push_key_description is no longer
1898 defined in keyboard.c, so its declaration should not be in
1899 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1900 logically belongs with push_key_description.
1901
dfb3f755
PE
19022011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * buffer.h: Include <sys/types.h> instead of <time.h>.
1905 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1906 Problem reported by Herbert J. Skuhra.
1907
3134906c
LMI
19082011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1909
1910 * xml.c (parse_region): Make the parsing work for
1911 non-comment-starting XML files again (bug#9144).
1912
8d903f4e
AS
19132011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1914
1915 * image.c (gif_load): Fix calculation of bottom and right corner.
1916 (Bug#9468)
1917
80ad64f4
EZ
19182011-09-10 Eli Zaretskii <eliz@gnu.org>
1919
1920 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1921 redisplay in small windows.
1922
208a048d
EZ
19232011-09-09 Eli Zaretskii <eliz@gnu.org>
1924
1925 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1926
9b1c252e
MR
19272011-09-08 Martin Rudalics <rudalics@gmx.at>
1928
1929 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1930 Operate on live windows only.
1931
2949f33b
JB
19322011-09-08 Juanma Barranquero <lekktu@gmail.com>
1933
1934 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1935
e08dcafd
EZ
19362011-09-07 Eli Zaretskii <eliz@gnu.org>
1937
1938 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1939 only under bidi iteration.
1940
115b96bd
JD
19412011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1942
1943 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1944
c8199d0f
PE
19452011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1948 Without this fix, the command to link temacs failed due to an
1949 undefined symbol __builtin_isnan. This is because
1950 /usr/include/iso/math_c99.h #defines isnan(x) to
1951 __builtin_isnan(x), but the bundled gcc, which identifies itself
1952 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1953 a __builtin_isnan.
1954 * floatfns.c (isnan): #undef, and then #define to a clone of
1955 what's in data.c.
1956 (Fisnan): Always define, since it's always available now.
1957 (syms_of_floatfns): Always define isnan at the Lisp level.
1958
e39b275c 19592011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1960
1961 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1962
b2db44d9 19632011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1964
f4af5137 1965 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1966 The previous code assumed that file offsets (off_t values) fit in
1967 EMACS_INT variables, which is not true on typical 32-bit hosts.
1968 The code messed up by falsely reporting buffer overflow in cases
1969 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1970 when "big" contains more than 2**29 bytes, even though this
1971 inserts just one byte and does not overflow the buffer.
1972 (Finsert_file_contents): Store file offsets as off_t
1973 values, not as EMACS_INT values. Check for overflow when
1974 converting between EMACS_INT and off_t. When checking for
1975 buffer overflow or for overlap, take the offsets into account.
1976 Don't use EMACS_INT for small values where int suffices.
1977 When checking for overlap, fix a typo: ZV was used where
1978 ZV_BYTE was intended.
1979 (Fwrite_region): Don't assume off_t fits into 'long'.
1980 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1981
ecfc0a49
MA
19822011-09-05 Michael Albinus <michael.albinus@gmx.de>
1983
1984 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1985
6511acf2 19862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1987
0999621a 1988 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1989
1990 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1991 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1992 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1993 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1994 (modify_event_symbol): Do not assume that the length of
1995 name_alist_or_stem is safe to alloca and fits in int.
1996 (Fexecute_extended_command): Likewise for function name and binding.
1997 (Frecursion_depth): Wrap around reliably on integer overflow.
1998 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1999 since some callers pass EMACS_INT values.
2000 (Fsingle_key_description): Don't crash if symbol name contains more
2001 than MAX_ALLOCA bytes.
2002 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2003 (get_minibuffer): Arg is now EMACS_INT, not int.
2004 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2005 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2006 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2007
2be7d702
PE
2008 * dbusbind.c (signature_cat): New function.
2009 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2010 Do not overrun buffer; instead, report string overflow.
2011
9d1df220
PE
2012 * dispnew.c (add_window_display_history): Don't overrun buffer.
2013 Truncate instead; this is OK since it's just a log.
2014
33ef5c64
PE
2015 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2016 even if the time zone offset is outlandishly large.
2017 Don't mishandle offset == INT_MIN.
2018
66c6fdd5
PE
2019 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2020 when creating daemon; the previous buffer-overflow check was incorrect.
2021
d749b01b
PE
2022 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2023 which has the guts of the old verror function.
2024
b5cd1905
PE
2025 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2026 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2027
6e1a67fb
PE
2028 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2029 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2030 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2031 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2032 length of string rather than counting it via multiple sprintfs;
2033 that's simpler and more reliable.
c21721cc
PE
2034 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2035 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2036 sprintf, in case result does not fit in int.
2037
c57b67fc
PE
2038 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2039 (fontset_from_font): Print it.
2040
8a401434
PE
2041 * frame.c (tty_frame_count): Now printmax_t, not int.
2042 (make_terminal_frame, set_term_frame_name): Print it.
2043 (x_report_frame_params): In X, window IDs are unsigned long,
2044 not signed long, so print them as unsigned.
2045 (validate_x_resource_name): Check for implausibly long names,
2046 and don't assume name length fits in 'int'.
2047 (x_get_resource_string): Don't blindly alloca invocation name;
2048 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2049 not fit in int.
2050
6e1a67fb
PE
2051 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2052 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2053 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2054
0df02bf3
PE
2055 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2056 Use esprintf, not sprintf, in case result does not fit in int.
2057
48e30793
PE
2058 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2059 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2060 it as a large positive number.
2061 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2062 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2063
a66ff6d8
PE
2064 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2065 in case result does not fit in int.
2066
aca216ff
PE
2067 * print.c (float_to_string): Detect width overflow more reliably.
2068 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2069 buffer overrun. Don't assume list length fits in 'int'. Treat
2070 print length of 0 as 0, not as infinity; to be consistent with other
2071 uses of print length in this function. Don't overflow print length
2072 index. Don't assume hash table size fits in 'long', or that
2073 vectorlike size fits in 'unsigned long'.
2074
31c286f7
PE
2075 * process.c (make_process): Use printmax_t, not int, to format
2076 process-name gensyms.
2077
55e5faa1
PE
2078 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2079
80f2e268
PE
2080 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2081 to avoid potential buffer overrun.
2082
670741ab
PE
2083 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2084 if X resource line is longer than 512 bytes.
2085
b7163a50
PE
2086 * xfns.c (x_window): Make sprintf buffer a bit bigger
2087 to avoid potential buffer overrun.
2088
ae58ff1f
PE
2089 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2090
c43c8a6a
PE
2091 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2092
3f8236f4
PE
20932011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2094
53e9fe90 2095 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2096 Without these, Emacs silently mishandles large integers sometimes.
2097 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2098 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2099
6511acf2
PE
2100 * xdisp.c (try_window_id): Check Emacs fixnum range before
2101 converting to 'int'.
806add1d 2102
6511acf2 2103 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2104 Check that an Emacs fixnum is in range before assigning it to 'int'.
2105 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2106 values converted from Emacs fixnums.
2107 (Frecenter): Don't wrap around a line count if it is out of 'int'
2108 range; instead, treat it as an extreme value.
2109 (Fset_window_configuration, compare_window_configurations):
2110 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2111
6511acf2
PE
2112 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2113 that can exceed INT_MAX. Check that EMACS_INT value is in range
2114 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2115 (match_limit): Don't assume that a fixnum can fit in 'int'.
2116
6511acf2 2117 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2118 exceed INT_MAX.
2119
6511acf2 2120 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2121 (Fvertical_motion): Don't wrap around LINES values that don't fit
2122 in 'int'. Instead, treat them as extreme values. This is good
2123 enough for windows, which can't have more than INT_MAX lines anyway.
2124
fcb901a7
LMI
21252011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2126
0f2f6b6d
LMI
2127 * Require libxml/parser.h to avoid compilation warning.
2128
fcb901a7
LMI
2129 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2130
2131 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2132 since this reportedly can destroy thread storage.
2133
6e20a0d4
CY
21342011-08-30 Chong Yidong <cyd@stupidchicken.com>
2135
2136 * syntax.c (find_defun_start): Update all cache variables if
2137 exiting early (Bug#9401).
2138
148ae00e
EZ
21392011-08-30 Eli Zaretskii <eliz@gnu.org>
2140
f6cfbd8f
EZ
2141 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2142
148ae00e
EZ
2143 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2144 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2145 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2146
2147 * term.c (tty_append_glyph): New function.
2148 (produce_stretch_glyph): Static function and its prototype deleted.
2149
a66cfb1c
SM
2150 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2151 Add prototypes.
148ae00e 2152
c4a07a4c
PE
21532011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2156 when checking :margin (Bug#9390).
2157 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2158 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2159 so that the name doesn't mislead. All uses changed.
2160
6bc8cd65
JB
21612011-08-28 Johan Bockgård <bojohan@gnu.org>
2162
2163 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2164 set_tty_hooks.
2165
dca4927e
EZ
21662011-08-27 Eli Zaretskii <eliz@gnu.org>
2167
2168 * xdisp.c (move_it_to): Don't bail out early when reaching
2169 position beyond to_charpos, if we are scanning backwards.
2170 (move_it_vertically_backward): When DY == 0, make sure we get to
2171 the first character in the line after the newline.
2172
f2cad773
PE
21732011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2174
2175 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2176 (ccl_driver): Do not generate an out-of-range pointer.
2177 (Fccl_execute_on_string): Remove unnecessary check for
2178 integer overflow, noted by Stefan Monnier in
2179 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2180 Remove a FIXME that didn't need fixing.
2181 Simplify the newly-introduced buffer reallocation code.
2182
0cae2cdb
JB
21832011-08-27 Juanma Barranquero <lekktu@gmail.com>
2184
2185 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2186
5fc295a4 21872011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2188
70c60eb2 2189 Integer and memory overflow issues (Bug#9196).
726e0ab1 2190
d31850da
PE
2191 * doc.c (get_doc_string): Rework so that
2192 get_doc_string_buffer_size is the actual buffer size, rather than
2193 being 1 less than the actual buffer size; this makes xpalloc more
2194 convenient.
2195
a69fbedb
PE
2196 * image.c (x_allocate_bitmap_record, cache_image):
2197 * xselect.c (Fx_register_dnd_atom):
2198 Simplify previous changes by using xpalloc.
2199
fe5c5d37
PE
2200 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2201 since either will do and ptrdiff_t is convenient with xpalloc.
2202
0065d054
PE
2203 * charset.c (charset_table_size)
2204 (struct charset_sort_data.priority): Now ptrdiff_t.
2205 (charset_compare): Don't overflow if priorities differ greatly.
2206 (Fsort_charsets): Don't assume list length fits in int.
2207 Check for size-calculation overflow when allocating sort data.
2208 (syms_of_charset): Allocate an initial charset table that is
2209 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2210
2211 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2212
2213 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2214 The actual value is always <= INT_MAX, and leaving it unsigned made
2215 overflow checking harder.
2216
2217 * dispextern.h (struct glyph_matrix.rows_allocated)
2218 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2219 with xpalloc. The values are still always <= INT_MAX.
2220
2221 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2222
2223 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2224 (SAFE_NALLOCA): New macro.
2225
2226 * region-cache.c (struct boundary.pos, find_cache_boundary)
2227 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2228 (set_cache_region, invalidate_region_cache)
2229 (revalidate_region_cache, know_region_cache, region_cache_forward)
2230 (region_cache_backward, pp_cache):
2231 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2232 so that ptrdiff_t * can be passed to xpalloc.
2233 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2234 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2235 (pp_cache): Don't assume cache_len fits in int.
2236 * region-cache.h: Adjust extern decls to match.
2237
2238 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2239 EMACS_INT, since either will do, for xpalloc.
2240
2241 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2242 (xnmalloc, xnrealloc, xpalloc): New functions.
2243
726e0ab1
PE
2244 * bidi.c (bidi_shelve_header_size): New constant.
2245 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2246 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2247
51f30bc5 2248 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2249 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2250 (overlay_strings):
2251 Don't update size of array until after memory allocation succeeds,
2252 because xmalloc/xrealloc may not return.
0065d054
PE
2253 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2254 now that we have proper integer overflow checking.
2255 (record_overlay_string, overlay_strings): Catch overflows when
2256 calculating size of overlay_str_buf.
726e0ab1 2257
0065d054
PE
2258 * callproc.c (Fcall_process): Check for size overflow when
2259 calculating size of args2.
2260 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2261 Normally we prefer signed values, but sticking with ptrdiff_t would
2262 require adding more-complicated checks.
726e0ab1
PE
2263
2264 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2265 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2266 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2267 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2268
2269 * character.c (Fstring): Check for size-calculation overflow.
2270
2271 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2272 unnecessary integer overflow. Check for size overflow.
2273 (encode_coding_object): Don't update size until xmalloc succeeds.
2274
2275 * composite.c (get_composition_id): Check for overflow in glyph
2276 length calculations.
2277
2278 Integer and memory overflow fixes for display code.
2279 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2280 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2281 (scrolling_window): Check for overflow in size calculations.
2282 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2283 Don't assume glyph table len fits in int.
2284 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2285 (row_table_size): Now ptrdiff_t, not int.
2286 (scrolling_window): Avoid overflow in size calculations.
2287 Don't update size until allocation succeeds.
2288 * fns.c (concat): Check for overflow in size calculations.
2289 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2290 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2291 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2292
2293 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2294 (get_doc_string): Check for size calculation overflow.
2295 Don't update size until allocation succeeds.
2296 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2297 EMACS_INT, where ptrdiff_t will do.
2298 (Fsubstitute_command_keys): Check for string overflow.
2299
2300 * editfns.c (set_time_zone_rule): Don't assume environment length
2301 fits in int.
2302 (message_length): Now ptrdiff_t, not int.
2303 (Fmessage_box): Don't update size until allocation succeeds.
2304 Don't assume message length fits in int.
2305 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2306
0065d054
PE
2307 * emacs.c (main): Do not reallocate argv, since there is a null at
2308 the end that can be overwritten, and this way there's no need to
2309 worry about size-calculation overflow.
2310 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2311
2312 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2313 alloc succeeds.
2314 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2315
2316 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2317 (x_set_scroll_bar_width, x_figure_window_size):
2318 Check for integer overflow.
2319 (x_set_alpha): Do not assume XINT fits in int.
2320
2321 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2322 This is for the members text_lines, text_cols, total_lines, total_cols,
2323 where the system imposes an 'int' limit.
2324
2325 * fringe.c (Fdefine_fringe_bitmap):
2326 Don't update size until alloc works.
2327
2328 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2329 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2330
2331 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2332 Check for size-calculation overflow.
2333 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2334 do, as we prefer signed integers.
2335 (id_to_widget.max_size, id_to_widget.used)
2336 (xg_store_widget_in_map, xg_remove_widget_from_map)
2337 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2338 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2339 Use and return ptrdiff_t, not int.
2340 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2341 * gtkutil.h: Change prototypes to match the above.
2342
2343 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2344 are duplicate now that they've been promoted to lisp.h.
2345 (x_allocate_bitmap_record, x_alloc_image_color)
2346 (make_image_cache, cache_image, xpm_load):
2347 Don't update size until alloc is done.
2348 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2349 (x_detect_edges):
3256efce 2350 Check for size calculation overflow.
726e0ab1
PE
2351 (ct_colors_allocated_max): New constant.
2352 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2353 overflow.
3256efce 2354
726e0ab1
PE
2355 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2356 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2357 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2358 Use ptrdiff_t, not int, to count maps.
2359 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2360 calculations. Don't update size until allocation succeeds.
2361 Redo calculations to avoid overflow.
726e0ab1
PE
2362 * keyboard.h: Change prototypes to match the above.
2363
2364 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2365 to count maps.
2366 (current_minor_maps): Check for size calculation overflow.
2367 * keymap.h: Change prototypes to match the above.
2368
2369 * lread.c (read1, init_obarray): Don't update size until alloc done.
2370
2371 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2372 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2373
726e0ab1
PE
2374 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2375 Now ptrdiff_t, not int.
2376 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2377 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2378
2379 * process.c (Fnetwork_interface_list): Check for overflow
2380 in size calculation.
2381
2382 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2383
2384 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2385 overflow. Don't bother calling xmalloc when xrealloc will do.
2386
2387 * search.c (Freplace_match): Check for size calculation overflow.
2388 (Fset_match_data): Don't assume list lengths fit in 'int'.
2389
2390 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2391 for command line length. Do not attempt to address one before the
2392 beginning of an array, as that's not portable.
2393
2394 * term.c (max_frame_lines): Remove; unused.
2395 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2396 not int.
2397 (encode_terminal_code, calculate_costs): Check for size
2398 calculation overflow.
2399 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2400 table lengths and related sizes. Don't update size until alloc
2401 done. Redo calculations to avoid overflow.
2402 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2403
2404 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2405 subtracting pointers.
2406 (gobble_line): Check for overflow more carefully. Don't update size
2407 until alloc done.
2408
2409 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2410 Don't update size until alloc done.
2411 Redo size calculations to avoid overflow.
2412 Check for size calculation overflow.
0065d054 2413 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2414
2415 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2416 Use ptrdiff_t, not int, for sizes.
2417 (store_mode_line_noprop_char): Don't update size until alloc done.
2418
0065d054
PE
2419 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2420 Use ptrdiff_t, not int, for sizes.
2421 (Finternal_make_lisp_face, cache_face):
2422 Check for size calculation overflow.
2423 (cache_face): Treat size calculation overflows as if they were
2424 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2425
2426 * xfns.c (x_encode_text, x_set_name_internal)
2427 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2428 sizes, since they can exceed INT_MAX in size. Check for size
2429 calculation overflow.
2430
0065d054
PE
2431 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2432 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2433 Don't update size until alloc done.
2434
0065d054 2435 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2436 as sprintf is limited to int lengths.
1d526e2f 2437
252c5ee1
PE
2438 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2439 (X_LONG_MIN): New macros.
864d7ce7
PE
2440 Use them to make the following changes clearer.
2441 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2442 This change doesn't affect the value now, but it may help remind
2443 future maintainers not to raise the value too much later.
2444 (SELECTION_QUANTUM): Remove, replacing with ...
2445 (selection_quantum): ... new function, which avoids overflow.
2446 All uses changed.
2447 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2448 assumption that selection length fits in 'int'.
2449 (x_reply_selection_request, x_handle_selection_request)
2450 (x_get_window_property, receive_incremental_selection)
2451 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2452 (lisp_data_to_selection_data, clean_local_selection_data):
2453 Use ptrdiff_t, not int, to record length of selection.
2454 (x_reply_selection_request, x_get_window_property)
2455 (receive_incremental_selection, x_property_data_to_lisp):
2456 Redo calculations to avoid overflow.
2457 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2458 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2459 something.
2460 (x_get_window_property, receive_incremental_selection)
2461 (lisp_data_to_selection_data, x_property_data_to_lisp):
2462 Check for size-calculation overflow.
2463 (x_get_window_property, receive_incremental_selection)
2464 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2465 Don't store size until memory allocation succeeds.
2466 (x_get_window_property): Plug memory leak on memory exhaustion.
2467 Don't double-block input; malloc is safe here. Don't assume 2**34
2468 - 4 fits in unsigned long. Add an xassert to check
2469 XGetWindowProperty overflow. Be more careful about overflow
2470 calculations, and distinguish size from memory overflow better.
2471 (receive_incremental_selection): When tracing, don't assume
2472 unsigned int is less than INT_MAX.
2473 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2474 harmful) conversions of unsigned short to int.
2475 (lisp_data_to_selection_data): Don't assume that integers
2476 in the range -65535 through -1 fit in an X unsigned short.
2477 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2478 result parameters unless successful. Rely on cons_to_unsigned
2479 to report problems with elements; the old code wasn't right anyway.
2480 (x_check_property_data): Check for int overflow; we cannot use
2481 a wider type due to X limits.
2482 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2483
726e0ab1 2484 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2485
0065d054
PE
2486 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2487 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2488 (x_color_cells): Don't store size until memory allocation succeeds.
2489 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2490 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2491 (x_term_init): Don't assume length fits in int (sprintf is limited
2492 to int size).
bc18e09d 2493
ebfa62c0
PE
2494 Use ptrdiff_t for composition IDs.
2495 * character.c (lisp_string_width):
2496 * composite.c (composition_table_size, n_compositions)
2497 (get_composition_id, composition_gstring_from_id):
2498 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2499 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2500 * window.c (Frecenter):
2501 Use ptrdiff_t, not int, for composition IDs.
2502 * composite.c (get_composition_id): Check for integer overflow.
2503 * composite.h: Adjust prototypes to match the above changes.
2504
d3411f89
PE
2505 Use ptrdiff_t for hash table indexes.
2506 * category.c (hash_get_category_set):
2507 * ccl.c (ccl_driver):
2508 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2509 * coding.c (coding_system_charset_list, detect_coding_system):
2510 * coding.h (struct coding_system.id):
2511 * composite.c (get_composition_id, gstring_lookup_cache):
2512 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2513 * image.c (xpm_get_color_table_h):
2514 * lisp.h (hash_lookup, hash_put):
2515 * minibuf.c (Ftest_completion):
2516 Use ptrdiff_t for hash table indexes, not int (which is too
2517 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2518 32-bit --with-wide-int hosts).
2519
e097a6fa
PE
2520 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2521 Add a FIXME comment about memory leaks.
2522 (syms_of_charset): Don't assume xmalloc returns.
2523
5637687f
PE
2524 Don't assume that stated character widths fit in int.
2525 * character.c (Fchar_width, c_string_width, lisp_string_width):
2526 * character.h (CHAR_WIDTH):
2527 * indent.c (MULTIBYTE_BYTES_WIDTH):
2528 Use sanitize_char_width to avoid undefined and/or bad behavior
2529 with outlandish widths.
a66cfb1c 2530 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2531 now that we have two such functions. All uses changed.
2532 (sanitize_char_width): New inline function.
2533
a2271ba2
PE
2534 Don't assume that tab-width fits in int.
2535 * character.h (sanitize_width): New inline function.
2536 (SANE_TAB_WIDTH): New macro.
2537 (ASCII_CHAR_WIDTH): Use it.
2538 * indent.c (sane_tab_width): Remove. All uses replaced by
2539 SANE_TAB_WIDTH (current_buffer).
2540 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2541
18c52557
PE
2542 * fileio.c: Integer overflow issues with file modes.
2543 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2544
caeeedc1
PE
2545 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2546 Remove unreachable code.
2547 (read_hex, load_charset_map_from_file): Check for integer overflow.
2548
6df6ae42 2549 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2550 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2551 (x_send_scroll_bar_event): Likewise. Check that the size does not
2552 exceed limits imposed by XClientMessageEvent, as well as the usual
2553 ptrdiff_t and size_t limits.
2554
b13995db
PE
2555 * keyboard.c: Overflow, signedness and related fixes.
2556 (make_lispy_movement): Use same integer type in forward decl
2557 that is used in the definition.
2558 (read_key_sequence, keyremap_step):
2559 Change bufsize argument back to int, undoing my 2011-03-30 change.
2560 We prefer signed types, and int is wide enough here.
2561 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2562 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2563 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2564 length, not size_t. Use ptrdiff_t for index, not int.
2565 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2566 possibility of integer overflow.
2567
13464394
PE
2568 Overflow, signedness and related fixes for images.
2569
2570 * dispextern.h (struct it.stack[0].u.image.image_id)
2571 (struct_it.image_id, struct image.id, struct image_cache.size)
2572 (struct image_cache.used, struct image_cache.ref_count):
2573 * gtkutil.c (update_frame_tool_bar):
2574 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2575 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2576 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2577 * nsmenu.m (update_frame_tool_bar):
2578 * xdisp.c (calc_pixel_width_or_height):
2579 * xfns.c (image_cache_refcount):
2580 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2581 on typical 64-bit hosts.
2582
2583 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2584 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2585 Omit unnecessary casts to int.
2586 (parse_image_spec): Check that integers fall into 'int' range
2587 when the callers expect that.
2588 (image_ascent): Redo ascent calculation to avoid int overflow.
2589 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2590 (lookup_image): Remove unnecessary tests.
2591 (xbm_image_p): Locals are now of int, not EMACS_INT,
2592 since parse_image_check makes sure they fit into int.
2593 (png_load, gif_load, svg_load_image):
2594 Prefer int to unsigned where either will do.
2595 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2596 old tiff_error_handler and tiff_warning_handler.
2597 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2598 stack buffer overflows. It uses only the features of vsnprintf
2599 that are common to both POSIX and native Microsoft.
2600 (tiff_error_handler, tiff_warning_handler): Use it.
2601 (tiff_load, gif_load, imagemagick_load_image):
2602 Don't assume :index value fits in 'int'.
2603 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2604 (imagemagick_load_image): Check that crop parameters fit into
2605 the integer types that MagickCropImage accepts. Don't assume
2606 Vimagemagick_render_type has a nonnegative value. Don't assume
2607 size_t fits in 'long'.
2608 (gs_load): Use printmax_t to print the widest integers possible.
2609 Check for integer overflow when computing image height and width.
2610
c11821d4
EZ
26112011-08-26 Eli Zaretskii <eliz@gnu.org>
2612
2613 * xdisp.c (redisplay_window): Don't force window start if point
2614 will be invisible in the resulting window. (Bug#9324)
2615
0c95fcf7
EZ
26162011-08-25 Eli Zaretskii <eliz@gnu.org>
2617
2618 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2619 the display spec is of the form `(space ...)'.
2620 (handle_display_spec): Return the value returned by
2621 handle_single_display_spec, not just 1 or zero.
2622 (handle_single_display_spec): If the display spec is of the form
2623 `(space ...)', and specifies display in the text area, return 2
2624 rather than 1.
fee65a97 2625 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2626 accurately, and prefer exact match for point under bidi.
2627 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2628
2629 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2630 into disp_prop; all users changed.
2631
2632 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2633 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2634 for the text covered by the display property.
2635
e4ed06f1
CY
26362011-08-25 Chong Yidong <cyd@stupidchicken.com>
2637
2638 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2639 Change return value to nil.
2640 (Frecord_buffer): Delete unused function.
2641
f67cdd7f
EZ
26422011-08-24 Eli Zaretskii <eliz@gnu.org>
2643
5980d4c6
EZ
2644 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2645 buffers, return left-to-right.
8610fe8b
EZ
2646 (set_cursor_from_row): Consider candidate row a win if its glyph
2647 represents a newline and point is on that newline. Fixes cursor
2648 positioning on the newline at EOL of R2L text within L2R
2649 paragraph, and vice versa.
2650 (try_cursor_movement): Check continued rows, in addition to
2651 continuation rows. Fixes unwarranted scroll when point enters a
2652 continued line of R2L text within an L2R paragraph, or vice versa.
2653 (cursor_row_p): Consider the case of point being equal to
2654 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2655 from the end of a short line to the beginning of a continued line
2656 of R2L text within L2R paragraph.
2657 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2658 composed characters.
5980d4c6 2659
f67cdd7f
EZ
2660 * bidi.c (bidi_check_type): Use xassert.
2661 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2662 members.
2663
bca633fb
EZ
26642011-08-23 Eli Zaretskii <eliz@gnu.org>
2665
2666 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2667 a character.
2668
4a5885a7
CY
26692011-08-23 Chong Yidong <cyd@stupidchicken.com>
2670
2671 * nsfont.m (ns_otf_to_script): Fix typo.
2672
0902a04e
KH
26732011-08-22 Kenichi Handa <handa@m17n.org>
2674
2675 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2676 extra slot even if the purpose is char-code-property-table.
2677
1a2e6670
EZ
26782011-08-23 Eli Zaretskii <eliz@gnu.org>
2679
8ddde651
EZ
2680 * xdisp.c (redisplay_window): When computing centering_position,
2681 account for the height of the header line. (Bug#8874)
2682
425cc014
EZ
2683 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2684 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2685 candidate is selected by the mouse, and that candidate has a
2686 composed character under the mouse.
2687
1a2e6670
EZ
2688 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2689 coordinates reported by pos-visible-in-window-p for a composed
2690 character in column zero.
2691
8b76d6f8
SM
26922011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2693
2694 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2695
dac347dd
EZ
26962011-08-22 Eli Zaretskii <eliz@gnu.org>
2697
2698 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2699 consider it a hit if to_charpos is anywhere in the range of the
2700 composed buffer positions.
2701
e013fb34
CY
27022011-08-22 Chong Yidong <cyd@stupidchicken.com>
2703
2704 * image.c (gif_load): Don't assume that each subimage has the same
2705 dimensions as the base image. Handle disposal method that is
2706 "undefined" by the gif spec (Bug#9335).
2707
bd1ba3e8
CY
27082011-08-20 Chong Yidong <cyd@stupidchicken.com>
2709
2710 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2711 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2712
54a1215b
EZ
27132011-08-19 Eli Zaretskii <eliz@gnu.org>
2714
823564e5
EZ
2715 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2716 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2717 from an Org mode buffer to a Speedbar frame.
2718
54a1215b
EZ
2719 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2720 a composition, take its buffer position from IT->cmp_it.charpos.
2721 Fixes cursor positioning at the beginning of a line that begins
2722 with a composed character.
2723
9778ebcc
EZ
27242011-08-18 Eli Zaretskii <eliz@gnu.org>
2725
0be6ee06
EZ
2726 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2727 character bidirectional type, use STRONG_L instead. Fixes crashes
2728 in a buffer produced by `describe-categories'.
2729
9778ebcc
EZ
2730 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2731 members before the level stack, so they would be saved and
2732 restored when copying iterator state. Fixes incorrect reordering
2733 around TABs covered by display properties.
2734
156bffbe
AS
27352011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2736
6b02f655 2737 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2738
72ad093b
CY
27392011-08-17 Chong Yidong <cyd@stupidchicken.com>
2740
2741 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2742 (internal_condition_case_2, internal_condition_case_n):
2743 Remove unnecessary aborts (Bug#9081).
72ad093b 2744
35774242
EZ
27452011-08-17 Eli Zaretskii <eliz@gnu.org>
2746
2747 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2748 has no `load' handler, try opening the file locally. (Bug#9311)
2749
db76dd85
KB
27502011-08-16 Ken Brown <kbrown@cornell.edu>
2751
2752 * gmalloc.c: Expand comment.
2753
b215eee5
EZ
27542011-08-16 Eli Zaretskii <eliz@gnu.org>
2755
2756 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2757 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2758
a4579d33
KB
27592011-08-16 Ken Brown <kbrown@cornell.edu>
2760
2761 Fix memory allocation problems in Cygwin build (Bug#9273).
2762
2763 * unexcw.c ( __malloc_initialized): Declare external variable.
2764 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2765
8b76d6f8
SM
2766 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2767 New variables.
a4579d33
KB
2768 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2769 dumped emacs.
2770 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2771 in the static heap.
2772 [CYGWIN] (special_realloc): New function.
2773 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2774 requests to realloc storage in the static heap.
2775
3ebec551
PE
27762011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2777
2778 * bidi.c (bidi_initialize): Remove unused local.
2779
9fd8be00
EZ
27802011-08-15 Eli Zaretskii <eliz@gnu.org>
2781
6b02f655
SM
2782 * bidimirror.h:
2783 * biditype.h: Remove file.
2784 * makefile.w32-in ($(BLD)/bidi.$(O)):
2785 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2786
2787 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2788
2789 * chartab.c: Improve commentary for the uniprop_table API.
2790
32413314
EZ
2791 * bidi.c (bidi_paragraph_init): Support zero value of
2792 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2793 (bidi_initialize): Use uniprop_table instead of including
2794 biditype.h and bidimirror.h.
32413314 2795
9fd8be00
EZ
2796 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2797 coordinates of the iterator when restoring from ppos_it.
2798 (Bug#9296)
2799
5cf2b69b
KH
28002011-08-14 Kenichi Handa <handa@m17n.org>
2801
2802 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2803 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2804
daf17d00
EZ
28052011-08-14 Eli Zaretskii <eliz@gnu.org>
2806
2807 * xdisp.c (move_it_in_display_line_to): Don't invoke
2808 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2809 ppos_it. Fixes vertical cursor motion when line beginning is
2810 covered by an image. (Bug#9296)
2811
08e3161a
JD
28122011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2813
2814 * nsterm.h (ns_run_ascript): Declare.
2815 (NSAPP_DATA2_RUNASSCRIPT): Define.
2816
2817 * nsfns.m (as_script, as_result, as_status): New static variables.
2818 (ns_run_ascript): New function.
5e617bc2 2819 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2820 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2821 the event loop. Get status from as_status (Bug#7276).
2822
2823 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2824 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2825 the event loop (Bug#7276).
2826
a3720aa2
AS
28272011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2828
2829 * gnutls.c (QCgnutls_bootprop_priority)
2830 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2831 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2832 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2833 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2834 (QCgnutls_bootprop_verify_hostname_error)
2835 (QCgnutls_bootprop_callbacks_verify): Rename from
2836 Qgnutls_bootprop_..., all uses changed.
2837
2838 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2839 uses changed.
2840
0a0d27fb
PE
28412011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2842
19d5c50c
PE
2843 * xfaces.c (Qframe_set_background_mode): Now static.
2844 * dispextern.h (Qframe_set_background_mode): Remove decl.
2845
0a0d27fb
PE
2846 * process.c (Fnetwork_interface_info): Declare local only if needed.
2847
377538cb
JD
28482011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2849
2850 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2851 (Fnetwork_interface_list): Allocate in increments of bytes instead
2852 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2853 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2854 sockaddr.
2855 (struct ifflag_def): notrailers is smart on OSX.
2856 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2857 Get hardware address with getifaddrs if available.
2858
08fff70c
EZ
28592011-08-12 Eli Zaretskii <eliz@gnu.org>
2860
2861 * xdisp.c (iterate_out_of_display_property): xassert that
2862 IT->position is set to within IT->object's boundaries. Break from
2863 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2864 when IT->position is set up wrongly due to some bug.
2865 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2866 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2867 entry. Force push_it to save on the stack the current
2868 buffer/string position, to be restored by pop_it. Fix flags in
2869 the iterator structure wrt the object coming from a display
2870 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2871 properties. (Bug#9284)
2872
7be1c708 28732011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2874
7be1c708
CY
2875 * fontset.c (fontset_get_font_group): Add proper type checks.
2876 (Bug#9172)
aac0c6e3 2877
7be1c708 28782011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2879
7be1c708
CY
2880 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2881 and LC_VERSION_MIN_MACOSX.
2882 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2883 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2884
97bb72a6
EZ
28852011-08-08 Eli Zaretskii <eliz@gnu.org>
2886
2887 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2888 no-display-properties-and-no-overlays under bidi display.
2889 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2890 properties and overlays.
97bb72a6 2891
d5617611
CY
28922011-08-08 Chong Yidong <cyd@stupidchicken.com>
2893
37e11a63
CY
2894 * editfns.c (Fset_time_zone_rule): Document relationship with the
2895 setenv function.
2896
d5617611
CY
2897 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2898 the font entity extracted from the cache (Bug#8109).
2899
58872834
CY
29002011-08-07 Chong Yidong <cyd@stupidchicken.com>
2901
2902 * composite.c (autocmp_chars): Don't reset point. That is done by
2903 restore_point_unwind (Bug#5984).
2904
75bfc667
JL
29052011-08-07 Juri Linkov <juri@jurta.org>
2906
2907 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2908 to show the arg `TIME' instead of `TIMEVAL'.
2909
d1410150
EZ
29102011-08-06 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2913 display property strides EOL and includes a newline, as in
2914 longlines-mode. (Bug#9254)
75b771e4
EZ
2915 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2916 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2917
2918 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2919 is non-zero, even if the data buffer is NULL. Fixes a crash in
2920 vertical-motion with longlines-mode. (Bug#9254)
2921
35928349
EZ
29222011-08-05 Eli Zaretskii <eliz@gnu.org>
2923
ec7cc85b
EZ
2924 * bidi.c <bidi_cache_total_alloc>: Now static.
2925 (bidi_initialize): Initialize bidi_cache_total_alloc.
2926
8b76d6f8 2927 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2928 cache. (Bug#9221)
2929
2930 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2931 amount allocated this far in `bidi_cache_total_alloc'.
2932 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2933 non-zero, only free the data buffer without restoring the cache
2934 contents. All callers changed.
2935
2936 * dispextern.h (bidi_unshelve_cache): Update prototype.
2937
2938 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2939 (move_it_in_display_line, move_it_to)
2940 (move_it_vertically_backward, move_it_by_lines): Replace the call
2941 to xfree to an equivalent call to bidi_unshelve_cache.
2942 (move_it_in_display_line_to): Fix logic of returning
412b6358 2943 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2944
e2e2423b
EZ
29452011-08-05 Eli Zaretskii <eliz@gnu.org>
2946
2947 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2948 came from a string character with a `cursor' property. (Bug#9229)
2949
ae9e757a
JD
29502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2951
2952 * Makefile.in (LIB_PTHREAD): New variable.
2953 (LIBES): Add LIB_PTHREAD (Bug#9216).
2954
2955 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2956 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2957
213bd7f2
AS
29582011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2959
6b02f655 2960 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2961
99aaf75f
JD
29622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2963
2964 * xterm.c (x_find_topmost_parent): New function.
2965 (x_set_frame_alpha): Find topmost parent window with
2966 x_find_topmost_parent and set the property there also (bug#9181).
2967 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2968
c74e9d86
PE
29692011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2970
2971 * callproc.c (Fcall_process): Avoid vfork clobbering
2972 the local vars buffer, coding_systems, current_dir.
2973
640c8776
SM
29742011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2975
2976 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2977
f26d0e4c
PE
29782011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2979
8a10d76c
PE
2980 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2981 so that it is not optimized away.
2982
f26d0e4c
PE
2983 * xdisp.c (compute_display_string_pos): Remove unused local.
2984
55439c61
EZ
29852011-08-02 Eli Zaretskii <eliz@gnu.org>
2986
2987 Fix slow cursor motion and scrolling in large buffers with
2988 selective display, like Org Mode buffers. (Bug#9218)
2989
2990 * dispextern.h (struct bidi_it): New member disp_prop_p.
2991
2992 * xdisp.c: Remove one-slot cache of display string positions.
2993 (compute_display_string_pos): Accept an additional argument
5e617bc2 2994 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2995 for a display string or property. If found, set DISP_PROP_P
2996 non-zero.
2997
2998 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2999 DISP_PROP_P, and pass it to compute_display_string_pos.
3000 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3001 non-zero. All callers of bidi_fetch_char changed.
3002
fb33fa43
SM
30032011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3004
3005 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3006
b099e063
DM
30072010-12-03 Don March <don@ohspite.net>
3008
3009 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3010 last character M-[char] is translated to ESC [char] (bug#7541).
3011
5cc7f7af
KH
30122011-08-02 Kenichi Handa <handa@m17n.org>
3013
d0fffa3f 3014 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3015
3016 * chartab.c (uniprop_table): Make it non-static.
3017
525d5e6e
EZ
30182011-08-01 Eli Zaretskii <eliz@gnu.org>
3019
3020 * xdisp.c (forward_to_next_line_start): Accept additional argument
3021 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3022 on the newline.
3023 (reseat_at_next_visible_line_start): Use the bidi iterator state
3024 returned by forward_to_next_line_start to restore the state of
3025 it->bidi_it after backing up to previous newline. (Bug#9212)
3026
31011111
AS
30272011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3028
3029 * regex.c (re_comp): Protoize.
3030 (re_exec): Fix return type.
3031 (regexec): Fix type of `ret'. (Bug#9203)
3032
476371c4
PE
30332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3034
e5d76069
PE
3035 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3036 This is needed if max-image-size is a floating-point number.
3037
9a79b20c
AS
30382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3039
3040 * print.c (print_object): Print empty symbol as ##.
3041
3042 * lread.c (read1): Read ## as empty symbol.
3043
d8c2fa78
AA
30442011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3045
3046 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3047 setting frame foreground color (Bug#9175).
3048 (x_set_background_color): Likewise.
3049
ffe57a7a
AA
3050 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3051 contents (Bug#9176).
3052 (EmacsTooltip -init): Remove bezels and add shadows to
3053 tooltip windows.
3054
bf3492a5
AA
3055 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3056 or scroll bar (Bug#8470).
3057
d55e9c53
AA
3058 * nsfont.m (nsfont_open): Remove assignment to voffset and
3059 unnecessary vars hshink, expand, hd, full_height, min_height.
3060 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3061
3062 * nsterm.h (nsfont_info): Remove voffset field.
3063
d8c2fa78 30642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3065
3066 Implement strike-through and overline on NextStep (Bug#8863).
3067
3068 * nsfont.m (nsfont_open): Use underline position provided by font,
3069 instead of hard-coded value of 2.
3070 (nsfont_draw): Call ns_draw_text_decoration instead.
3071
3072 * nsterm.h: Add declaration for ns_draw_text_decoration.
3073
3074 * nsterm.m (ns_draw_text_decoration): New function for drawing
3075 underline, overline, and strike-through.
3076 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3077 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3078 accommodate underlining, etc.
4843aac3 3079
4cc60b9b
EZ
30802011-07-28 Eli Zaretskii <eliz@gnu.org>
3081
bc7ece87
EZ
3082 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3083 default.
4cc60b9b 3084
476371c4
PE
30852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3086
66606eea
PE
3087 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3088 Without this fix, if a signal arrives just after memory fills up,
3089 'malloc' might be invoked reentrantly.
3090
476371c4
PE
3091 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3092 In other words, assume that every image size is allowed, on non-X
3093 hosts. This assumption is probably wrong, but it lets Emacs compile.
3094
f3fcc40d
AS
30952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3096
3097 * regex.c (re_iswctype): Convert return values to boolean.
3098
350c992f
EZ
30992011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3100
3101 * xdisp.c (compute_display_string_pos): Don't use cached display
3102 string position if the buffer had its restriction changed.
3103 (Bug#9184)
3104
5266b4bb
PE
31052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3106
3107 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3108
2573a837 31092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3110
41f55ccd 3111 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3112
39e378da
PE
3113 * bidi.c: Integer size and overflow fixes.
3114 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3115 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3116 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3117 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3118 (bidi_find_other_level_edge):
3119 Use ptrdiff_t instead of EMACS_INT where either will do.
3120 This works better on 32-bit hosts configured --with-wide-int.
3121 (bidi_cache_ensure_space): Check for size-calculation overflow.
3122 Use % rather than repeated addition, for better worst-case speed.
3123 Don't set bidi_cache_size until after xrealloc returns, because it
3124 might not return.
3125 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3126 (bidi_cache_ensure_space): Also check that the bidi cache size
3127 does not exceed that of the largest Lisp string or buffer. See Eli
3128 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3129
5e927815
PE
3130 * alloc.c (__malloc_size_t): Remove.
3131 All uses replaced by size_t. See Andreas Schwab's note
3132 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3133
ca4aa935
PE
3134 * image.c: Improve checking for integer overflow.
3135 (check_image_size): Assume that f is nonnull, since
3136 it is always nonnull in practice. This is one less thing to
3137 worry about when checking for integer overflow later.
3138 (x_check_image_size): New function, which checks for integer
3139 overflow issues inside X.
3140 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3141 This removes the need for a memory_full check.
3142 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3143 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3144 (xbm_read_bitmap_data): Change locals back to 'int', since
3145 their values must fit in 'int'.
3146 (xpm_load_image, png_load, tiff_load):
3147 Invoke x_create_x_image_and_pixmap earlier,
3148 to avoid much needless work if the image is too large.
3149 (tiff_load): Treat overly large images as if
3150 x_create_x_image_and_pixmap failed, not as malloc failures.
3151 (gs_load): Use x_check_image_size.
3152
5f8f9cc2
PE
3153 * gtkutil.c: Omit integer casts.
3154 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3155 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3156
5adf60bc
PE
3157 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3158
c8907a93
PE
3159 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3160 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3161 would wrongly return t on a 64-bit host.
3162
e3c25c68
PE
3163 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3164 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3165 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3166 and therefore cause GCC to emit a bogus diagnostic in some cases.
3167
3f791afe
PE
3168 * image.c: Integer signedness and overflow and related fixes.
3169 This is not an exhaustive set of fixes, but it's time to
3170 record what I've got.
3171 (lookup_pixel_color, check_image_size): Remove redundant decls.
3172 (check_image_size): Don't assume that arbitrary EMACS_INT values
3173 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3174 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3175 (tiff_load, imagemagick_load_image):
3176 Check for overflow in size calculations.
3177 (x_create_x_image_and_pixmap): Remove unnecessary test for
3178 xmalloc returning NULL; that can't happen.
3179 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3180 (xpm_color_bucket): Use better integer hashing function.
3181 (xpm_cache_color): Don't possibly over-allocate memory.
3182 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3183 (gif_memory_source):
3184 Use ptrdiff_t, not int or size_t, to record sizes.
3185 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3186 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3187 either works, as we prefer signed integers.
3188 (tiff_read_from_memory, tiff_write_from_memory):
3189 Return tsize_t, not size_t, since that's what the TIFF API wants.
3190 (tiff_read_from_memory): Don't fail simply because the read would
3191 go past EOF; instead, return a short read.
3192 (tiff_load): Omit no-longer-needed casts.
3193 (Fimagemagick_types): Don't assume size fits into 'int'.
3194
3cc5a532
PE
3195 Improve hashing quality when configured --with-wide-int.
3196 * fns.c (hash_string): New function, taken from sxhash_string.
3197 Do not discard information about ASCII character case; this
3198 discarding is no longer needed.
3199 (sxhash-string): Use it. Change sig to match it. Caller changed.
3200 * lisp.h: Declare it.
3201 * lread.c (hash_string): Remove, since we now use fns.c's version.
3202 The fns.c version returns a wider integer if --with-wide-int is
3203 specified, so this should help the quality of the hashing a bit.
3204
b312a492
PE
3205 * emacs.c: Integer overflow minor fix.
3206 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3207 Define only if GNU_LINUX.
3208 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3209
dfd153ae
PE
3210 * dispnew.c: Integer signedness and overflow fixes.
3211 Remove unnecessary forward decls, that were a maintenance hassle.
3212 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3213 All uses changed.
3214 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3215 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3216 (prepare_desired_row, line_draw_cost):
3217 Use int, not unsigned, where either works.
3218 (save_current_matrix, restore_current_matrix):
3219 Use ptrdiff_t, not size_t, where either works.
3220 (init_display): Check for overflow more accurately, and without
3221 relying on undefined behavior.
3222
a81d11a3
PE
3223 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3224 Remove, replacing with the new symbols in lisp.h. All uses changed.
3225 * fileio.c (make_temp_name):
3226 * filelock.c (lock_file_1, lock_file):
3227 * xdisp.c (message_dolog):
3228 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3229 Use pMd etc. instead.
3230 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3231 replacing the pWIDE etc. symbols removed from editfns.c.
3232
3300e6fd
PE
3233 * keyboard.h (num_input_events): Now uintmax_t.
3234 This is (very slightly) less likely to mess up due to wraparound.
3235 All uses changed.
3236
fd05c7e9
PE
3237 * buffer.c: Integer signedness fixes.
3238 (alloc_buffer_text, enlarge_buffer_text):
3239 Use ptrdiff_t rather than size_t when either will do, as we prefer
3240 signed integers.
3241
903fe15d
PE
3242 * alloc.c: Integer signedness and overflow fixes.
3243 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3244 (__malloc_size_t): Default to size_t, not to int.
3245 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3246 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3247 Prefer ptrdiff_t to size_t when either would do, as we prefer
3248 signed integers.
3249 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3250 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3251 Now const. Initialize with values that are in range even if char
3252 is signed.
3253 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3254 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3255 These functions do the right thing with sizes > 2**32.
3256 (check_depth): Now ptrdiff_t, not int.
3257 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3258 Adjust to new way of storing sizes. Check for size overflow bugs
3259 in rest of code.
3260 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3261 slightly wrong anyway, as it missed one instance of
3262 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3263 (refill_memory_reserve): Omit needless cast to size_t.
3264 (mark_object_loop_halt): Mark as externally visible.
3265
ac82cc6a
PE
3266 * xselect.c: Integer signedness and overflow fixes.
3267 (Fx_register_dnd_atom, x_handle_dnd_message):
3268 Use ptrdiff_t, not size_t, since we prefer signed.
3269 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3270 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3271 x_dnd_atoms_size and x_dnd_atoms_length.
3272
c2d1e36d
PE
3273 * doprnt.c: Prefer signed to unsigned when either works.
3274 * eval.c (verror):
3275 * doprnt.c (doprnt):
3276 * lisp.h (doprnt):
3277 * xdisp.c (vmessage):
3278 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3279 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3280 prefer signed arithmetic to avoid comparison confusion.
3281 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3282 but is a bit tricky.
3283
0e926e56
PE
3284 Assume freestanding C89 headers, string.h, stdlib.h.
3285 * data.c, doprnt.c, floatfns.c, print.c:
3286 Include float.h unconditionally.
3287 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3288 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3289 * regex.c: Likewise for stddef.h, string.h.
3290 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3291 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3292 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3293 (STDC_HEADERS): Remove obsolete defines.
3294 * sysdep.c: Include limits.h unconditionally.
3295
9cfdb3ec
PE
3296 Assume support for memcmp, memcpy, memmove, memset.
3297 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3298 * regex.c (memcmp, memcpy):
3299 Remove; we assume C89 now.
3300
3301 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3302 (__malloc_safe_bcopy): Remove; no longer needed.
3303
cf950e6b 3304 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3305 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3306 well either way, and we prefer signed to unsigned.
3307
dbf38e02
LMI
33082011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3309
3310 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3311 closes the connection while we're reading (bug#9182).
3312
d6f0886c 33132011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3314
d6f0886c
JD
3315 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3316 are specified (Bug#9168).
24e0f6b1 3317
2eb1f9e6
PE
33182011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3319
3320 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3321 Found by GCC static checking and --with-wide-int on a 32-bit host.
3322
22381272 33232011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3324
3325 * xdisp.c (compute_display_string_pos): Fix logic of caching
3326 previous display string position. Initialize cached_prev_pos to
3327 -1. Fixes slow-down at the beginning of a buffer.
3328
f25e39b4
EZ
33292011-07-24 Eli Zaretskii <eliz@gnu.org>
3330
3331 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3332 for attrs[LFACE_FONTSET_INDEX].
3333
04c4b52e
PE
33342011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 * xml.c (parse_region): Remove unused local
3337 that was recently introduced.
3338
c1734fbd
EZ
33392011-07-23 Eli Zaretskii <eliz@gnu.org>
3340
be18c5a5
EZ
3341 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3342 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3343
c1734fbd
EZ
3344 * xdisp.c (move_it_in_display_line_to): Record the best matching
3345 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3346 exit if none of the characters scanned was an exact match.
3347 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3348 when exact match is impossible due to invisible text, and the
3349 lines are truncated.
3350
a258d627
JD
33512011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3352
3353 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3354 for OSX >= 10.7.
3355
b6d5a689
EZ
33562011-07-22 Eli Zaretskii <eliz@gnu.org>
3357
0f74f785
EZ
3358 Fix a significant slow-down of cursor motion with C-n, C-p,
3359 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3360 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3361 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3362 (next_element_from_buffer): Call compute_stop_pos_backwards to
3363 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3364 base_level_stop.
3365 (reseat): Don't look for prev_stop, as that could mean a very long
3366 run.
3367 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3368 <cached_disp_overlay_modiff>: Cache for last found display string
3369 position.
551918c1 3370 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3371 about the same buffer in the same area of character positions, and
3372 the buffer wasn't changed since the time the display string
3373 position was cached.
551918c1 3374
b2d0c91a
EZ
33752011-07-22 Eli Zaretskii <eliz@gnu.org>
3376
3377 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3378 is an integer, which is important for empty lines. (Bug#9149)
3379
043604ee
CY
33802011-07-22 Chong Yidong <cyd@stupidchicken.com>
3381
3382 * frame.c (Fmodify_frame_parameters): In tty case, update the
3383 default face if necessary (Bug#4238).
3384
da4adb04
CY
33852011-07-21 Chong Yidong <cyd@stupidchicken.com>
3386
3387 * editfns.c (Fstring_to_char): No need to explain what a character
3388 is in the docstring (Bug#6576).
3389
9abd0532
LMI
33902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3391
3392 * xml.c (parse_region): Make sure we always return a tree.
3393
36881d16
HK
33942011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3395
3396 * xml.c (parse_region): If a document contains only comments,
3397 return that, too.
3398
1e98674d
LMI
33992011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3400
3401 * xml.c (make_dom): Return comments, too.
3402
590bd467
PE
34032011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3404
3405 Port to OpenBSD.
3406 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3407 and the surrounding thread.
3408 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3409 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3410 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3411 timer goes off.
3412 * s/openbsd.h (BROKEN_SIGIO): Define.
3413 * unexelf.c (unexec) [__OpenBSD__]:
3414 Don't update the .mdebug section of the Alpha COFF symbol table.
3415
f41628b2
LMI
34162011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3417
3418 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3419 (bug#8460).
3420
b59b67c5
PE
34212011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3422
15e3a074
PE
3423 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3424 This fixes some race conditions on the permissions of any newly
3425 created file.
3426
41bed37d
PE
3427 * alloc.c (valid_pointer_p): Use pipe, not open.
3428 This fixes some permissions issues when debugging.
3429
b59b67c5
PE
3430 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3431 If fchown fails to set both uid and gid, try to set just gid,
3432 as that is sometimes allowed. Adjust the file's mode to eliminate
3433 setuid or setgid bits that are inappropriate if fchown fails.
3434
925a6be7
SM
34352011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3436
3437 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3438 to compare Lisp_Objects.
3439 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3440 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3441 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3442
52968808
AS
34432011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3444
0a6a104b
AS
3445 * lread.c (read_integer): Unread even EOF character.
3446 (read1): Likewise. Properly record start position of symbol.
3447
52968808
AS
3448 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3449 symbol character follows.
3450
9e381cdd
PE
34512011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3452
3453 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3454 This works around a problem with the previous change to Fcopy_file.
3455 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3456 and without this change, GCC might complain about discarding
3457 fchown's return value.
3458
b5641435
JB
34592011-07-16 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3462
a8031457
PE
34632011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3464
3465 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3466
dd889327
LMI
34672011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3468
750c33f7
LMI
3469 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3470 it's used from the C level.
3471
dd889327
LMI
3472 * process.c: Use the same condition for POLL_FOR_INPUT in both
3473 keyboard.c and process.c (bug#1858).
3474
87e86684
LM
34752011-07-09 Lawrence Mitchell <wence@gmx.li>
3476
3477 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3478 (Fgnutls_boot): Use it.
3479
64348f40
AS
34802011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3481
3482 * doc.c (Fsubstitute_command_keys): Revert last change.
3483
1d698799
LMI
34842011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3485
f863868c
LMI
3486 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3487 quotes the next character, and doesn't affect other longer
3488 sequences (bug#8935).
3489
1d698799
LMI
3490 * lread.c (syms_of_lread): Clarify that is isn't only
3491 `eval-buffer' and `eval-defun' that's affected by
3492 `lexical-binding' (bug#8460).
3493
aa4b6df6
EZ
34942011-07-15 Eli Zaretskii <eliz@gnu.org>
3495
3496 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3497 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3498
5d856da6
PE
34992011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3500
ad6042bb
PE
3501 Fix minor problems found by static checking.
3502 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3503 (elsz): Now a signed constant, not a size_t var. We prefer signed
3504 types to unsigned, to avoid integer comparison confusion. Without
3505 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3506 "cannot optimize loop, the loop counter may overflow", a symptom
3507 of the confusion.
f00bbb22 3508 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3509 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3510
6468f31c
LMI
35112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3512
49080b10
LMI
3513 * search.c (Fre_search_backward): Mention `case-fold-search' in
3514 all the re_search_* functions (bug#8138).
3515
6468f31c
LMI
3516 * keyboard.c (Fopen_dribble_file): Document when the file is
3517 closed (bug#8056).
3518
c965adc5
EZ
35192011-07-14 Eli Zaretskii <eliz@gnu.org>
3520
df9733bf
EZ
3521 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3522 bidi_cache_idx.
3523
0bb23927
EZ
3524 Support bidi reordering of display and overlay strings.
3525 * xdisp.c (compute_display_string_pos)
3526 (compute_display_string_end): Accept additional argument STRING.
3527 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3528 (reseat_to_string): Initialize bidi_it->string.s and
3529 bidi_it->string.schars.
3530 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3531 NULL (avoids a crash in bidi_paragraph_init).
3532 Initialize itb.string.lstring.
0bb23927
EZ
3533 (init_iterator): Call bidi_init_it only of a valid
3534 buffer position was specified. Initialize paragraph_embedding to
3535 L2R.
3536 (reseat_to_string): Initialize the bidi iterator.
3537 (display_string): If we need to ignore text properties of
3538 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3539 original value of -1 will not work with bidi.)
3540 (compute_display_string_pos): First arg is now struct
3541 `text_pos *'; all callers changed. Support display properties on
3542 Lisp strings.
3543 (compute_display_string_end): Support display properties on Lisp
3544 strings.
3545 (init_iterator, reseat_1, reseat_to_string): Initialize the
3546 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3547 when iterating on a string not from display properties).
640c8776
SM
3548 (compute_display_string_pos, compute_display_string_end):
3549 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3550 arrow keys.
3551 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3552 base_level_stop; instead, set base_level_stop to BEGV.
3553 Fixes crashes in vertical-motion.
0bb23927
EZ
3554 (next_element_from_buffer): Improve commentary for when
3555 the iterator is before prev_stop.
3556 (init_iterator): Initialize bidi_p from the default value of
3557 bidi-display-reordering, not from buffer-local value. Use the
3558 buffer-local value only if initializing for buffer iteration.
3559 (handle_invisible_prop): Support invisible properties on strings
3560 that are being bidi-reordered.
3561 (set_iterator_to_next): Support bidi reordering of C strings and
3562 Lisp strings.
3563 (next_element_from_string): Support bidi reordering of Lisp
3564 strings.
3565 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3566 (display_string): Support display of R2L glyph rows.
3567 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3568 (init_iterator): Don't initialize it->bidi_p for strings
3569 here.
3570 (reseat_to_string): Initialize it->bidi_p for strings here.
3571 (next_element_from_string, next_element_from_c_string)
3572 (next_element_from_buffer): Add xassert's for correspondence
3573 between IT's object being iterated and it->bidi_it.string
3574 structure.
3575 (face_before_or_after_it_pos): Support bidi iteration.
3576 (next_element_from_c_string): Handle the case of the first string
3577 character that is not the first one in the visual order.
3578 (get_visually_first_element): New function, refactored from common
3579 parts of next_element_from_buffer, next_element_from_string, and
3580 next_element_from_c_string.
3581 (tool_bar_lines_needed, redisplay_tool_bar)
3582 (display_menu_bar): Force left-to-right direction. Add a FIXME
3583 comment for making that be controlled by a user option.
3584 (push_it, pop_it): Save and restore the state of the
3585 bidi iterator. Save and restore the bidi_p flag.
3586 (pop_it): Iterate out of display property for string iteration as
3587 well.
3588 (iterate_out_of_display_property): Support iteration over strings.
3589 (handle_single_display_spec): Set up it->bidi_it for iteration
3590 over a display string, and call bidi_init_it.
3591 (handle_single_display_spec, next_overlay_string)
3592 (get_overlay_strings_1, push_display_prop): Set up the bidi
3593 iterator for displaying display or overlay strings.
3594 (forward_to_next_line_start): Don't use the shortcut if
3595 bidi-iterating.
3596 (back_to_previous_visible_line_start): If handle_display_prop
3597 pushed the iterator stack, restore the internal state of the bidi
3598 iterator by calling bidi_pop_it same number of times.
3599 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3600 and we are bidi-iterating, don't decrement the iterator position;
3601 instead, set the first_elt flag in the bidi iterator, to produce
3602 the same effect.
3603 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3604 (push_display_prop): xassert that we are iterating a buffer.
3605 (push_it, pop_it): Save and restore paragraph_embedding member.
3606 (handle_single_display_spec, next_overlay_string)
3607 (get_overlay_strings_1, reseat_1, reseat_to_string)
3608 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3609 correctly. Don't assume unibyte strings are not bidi-reordered.
3610 (compute_display_string_pos)
3611 (compute_display_string_end): Fix handling the case of C string.
3612 (push_it, pop_it): Save and restore from_disp_prop_p.
3613 (handle_single_display_spec, push_display_prop): Set the
3614 from_disp_prop_p flag.
3615 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3616 (pop_it): Call iterate_out_of_display_property only if we are
3617 popping after iteration over a string that came from a display
3618 property. Fix a typo in popping stretch info. Add an assertion
3619 for verifying that the iterator position is in sync with the bidi
3620 iterator.
3621 (handle_single_display_spec, get_overlay_strings_1)
3622 (push_display_prop): Fix initialization of paragraph direction for
3623 string when that of the parent object is not yet determined.
3624 (reseat_1): Call bidi_init_it to resync the bidi
3625 iterator with IT's position. (Bug#7616)
3626 (find_row_edges): If ROW->start.pos gives position
3627 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3628 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3629 Reset the from_disp_prop_p flag.
3630 (SAVE_IT, RESTORE_IT): New macros.
3631 (pos_visible_p, face_before_or_after_it_pos)
3632 (back_to_previous_visible_line_start)
3633 (move_it_in_display_line_to, move_it_in_display_line)
3634 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3635 (try_scrolling, redisplay_window, display_line): Use them when
3636 saving a temporary copy of the iterator and restoring it back.
3637 (back_to_previous_visible_line_start, reseat_1)
3638 (init_iterator): Empty the bidi cache "stack".
3639 (move_it_in_display_line_to): If iterator ended up at
3640 EOL, but we never saw any buffer positions smaller than
3641 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3642 motion in bidi-reordered lines.
3643 (move_it_in_display_line_to): Record prev_method and prev_pos
3644 immediately before the call to set_iterator_to_next. Fixes cursor
3645 motion in bidi-reordered lines with stretch glyphs and strings
3646 displayed in margins. (Bug#8133) (Bug#8867)
3647 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3648 TO_CHARPOS.
640c8776
SM
3649 (pos_visible_p): Support positions in bidi-reordered lines.
3650 Save and restore bidi cache.
0bb23927
EZ
3651
3652 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3653 (bidi_paragraph_info): Delete unused struct.
3654 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3655 (bidi_cache_start): New variable.
3656 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3657 to zero.
3658 (bidi_cache_fetch_state, bidi_cache_search)
3659 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3660 (bidi_cache_find, bidi_peek_at_next_level)
3661 (bidi_level_of_next_char, bidi_find_other_level_edge)
3662 (bidi_move_to_visually_next): Compare cache index with
3663 bidi_cache_start rather than with zero.
3664 (bidi_fetch_char): Accept new argument STRING; all callers
3665 changed. Support iteration over a string. Support strings with
3666 display properties. Support unibyte strings. Fix the type of
3667 `len' according to what STRING_CHAR_AND_LENGTH expects.
3668 (bidi_paragraph_init, bidi_resolve_explicit_1)
3669 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3670 (bidi_level_of_next_char, bidi_move_to_visually_next):
3671 Support iteration over a string.
0bb23927
EZ
3672 (bidi_set_sor_type, bidi_resolve_explicit_1)
3673 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3674 can now be zero (for strings); special values 0 and -1 were
3675 changed to -1 and -2, respectively.
3676 (bidi_char_at_pos): New function.
3677 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3678 Call it instead of FETCH_MULTIBYTE_CHAR.
3679 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3680 initialized to valid values.
3681 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3682 values.
3683 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3684 the test for valid cached positions. Fix the logic for looking up
3685 the sentinel state in the cache. GCPRO the Lisp string we are
3686 iterating.
3687 (bidi_push_it, bidi_pop_it): New functions.
3688 (bidi_initialize): Initialize the bidi cache start stack pointer.
3689 (bidi_cache_ensure_space): New function, refactored from part of
3690 bidi_cache_iterator_state. Don't assume the required size is just
3691 one BIDI_CACHE_CHUNK away.
3692 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3693 (bidi_count_bytes, bidi_char_at_pos): New functions.
3694 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3695 always valid if bidi_cache_idx is valid.
3696 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3697 is valid if it's going to be used.
3698 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3699 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3700 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3701 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3702 (bidi_find_other_level_edge, bidi_cache_start_stack):
3703 All variables related to cache indices are now EMACS_INT.
c965adc5 3704
0bb23927
EZ
3705 * dispextern.h (struct bidi_string_data): New structure.
3706 (struct bidi_it): New member `string'. Make flag members be 1-bit
3707 fields, and put them last in the struct.
640c8776
SM
3708 (compute_display_string_pos, compute_display_string_end):
3709 Update prototypes.
0bb23927
EZ
3710 (bidi_push_it, bidi_pop_it): Add prototypes.
3711 (struct iterator_stack_entry): New members bidi_p,
3712 paragraph_embedding, and from_disp_prop_p.
3713 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3714 (bidi_shelve_cache, bidi_unshelve_cache):
3715 Declare prototypes.
0bb23927
EZ
3716
3717 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3718 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3719 and vector-like objects.
3720
3721 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3722 cache around display iteration.
3723
3724 * window.c (Fwindow_end, window_scroll_pixel_based)
3725 (displayed_window_lines, Frecenter): Save and restore the bidi
3726 cache around display iteration.
3727
3bbd2265
LMI
37282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3729
3730 * editfns.c (Fdelete_region): Clarify the use of the named
3731 parameters (bug#6788).
3732
adc47434
MR
37332011-07-14 Martin Rudalics <rudalics@gmx.at>
3734
3735 * indent.c (Fvertical_motion): Set and restore w->pointm when
3736 saving and restoring the window's buffer (Bug#9006).
3737
837c31f8
LMI
37382011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3739
3740 * editfns.c (Fstring_to_char): Clarify just what is returned
3741 (bug#6576). Text by Eli Zaretskii.
3742
ac389d0c
JB
37432011-07-13 Juanma Barranquero <lekktu@gmail.com>
3744
3745 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3746
0be0ce47
EZ
37472011-07-13 Eli Zaretskii <eliz@gnu.org>
3748
3749 * buffer.c (mmap_find): Fix a typo.
3750
cd18e7e3
JB
37512011-07-13 Johan Bockgård <bojohan@gnu.org>
3752
3753 Fix execution of x selection hooks.
3754 * xselect.c (Qx_lost_selection_functions)
3755 (Qx_sent_selection_functions): New vars.
3756 (syms_of_xselect): DEFSYM them.
3757 (x_handle_selection_request): Pass Qx_sent_selection_functions
3758 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3759 (x_handle_selection_clear,x_clear_frame_selections):
3760 Pass Qx_lost_selection_functions rather than
3761 Vx_lost_selection_functions to Frun_hook_with_args.
3762
47ea7f44
PE
37632011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3764
ac389d0c 3765 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3766 The old code sometimes used this field without initializing it.
3767
47ea7f44
PE
3768 * alloc.c (gc_sweep): Don't read past end of array.
3769 In theory, the old code could also have corrupted Emacs internals,
3770 though it'd be very unlikely.
3771
bc985c87
AS
37722011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3773
3774 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3775 argument. (Bug#4026)
bc985c87 3776
0cf34688
LMI
37772011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3778
b3dadd76
LMI
3779 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3780 key" (bug#4257).
3781
0cf34688
LMI
3782 * window.c (Fset_window_start): Doc fix (bug#4199).
3783 (Fset_window_hscroll): Ditto.
3784
270768cd
PE
37852011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3786
077e3dda 3787 Fix minor new problems caught by GCC 4.6.1.
270768cd 3788 * term.c (init_tty): Remove unused local.
490011a6 3789 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3790 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3791 not used otherwise.
270768cd 3792
b1f58454
CY
37932011-07-12 Chong Yidong <cyd@stupidchicken.com>
3794
3795 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3796
22b9578d
LMI
37972011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3798
6e70ab07
LMI
3799 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3800 are the mini-buffer and the echo area (bug#3320).
3801
22b9578d
LMI
3802 * term.c (init_tty): Remove support for supdup, c10 and perq
3803 terminals, which are no longer supported (bug#1482).
3804
8974cc9f
JB
38052011-07-10 Johan Bockgård <bojohan@gnu.org>
3806
3807 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3808
a560d974
JD
38092011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3810
3811 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3812 for non-popups (Bug#3642).
3813
1dae0f0a
AS
38142011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3815
268c2c36 3816 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3817 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3818 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3819 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3820 * data.c (fmod): Likewise.
3821 * dispnew.c (swap_glyphs_in_rows): Likewise.
3822 * emacs.c (memory_warning_signal): Likewise.
3823 * floatfns.c (float_error): Likewise.
3824 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3825 (otf_open, font_otf_capability, generate_otf_features)
3826 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3827 Likewise.
3828 * image.c (pbm_read_file): Likewise.
3829 * indent.c (string_display_width): Likewise.
3830 * intervals.c (check_for_interval, search_for_interval)
3831 (inc_interval_count, count_intervals, root_interval)
3832 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3833 * lread.c (defalias): Likewise.
268c2c36 3834 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3835 * regex.c (set_image_of_range_1, set_image_of_range)
3836 (regex_grow_registers): Likewise.
3837 * sysdep.c (strerror): Likewise.
3838 * termcap.c (valid_filename_p, tprint, main): Likewise.
3839 * tparam.c (main): Likewise.
3840 * unexhp9k800.c (run_time_remap, save_data_space)
3841 (update_file_ptrs, read_header, write_header, calculate_checksum)
3842 (copy_file, copy_rest, display_header): Likewise.
3843 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3844 Likewise.
3845 * xdisp.c (check_it): Likewise.
3846 * xfaces.c (register_color, unregister_color, unregister_colors):
3847 Likewise.
3848 * xfns.c (print_fontset_result): Likewise.
3849 * xrdb.c (member, fatal, main): Likewise.
3850
99033785
PE
38512011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 Fix minor problems found by static checking (Bug#9031).
3854 * chartab.c (char_table_set_range, map_sub_char_table):
3855 Remove unused locals.
3856 (uniprop_table): Now static.
3857 * composite.c (_work_char): Remove unused static var.
3858
9cb2ac56
JB
38592011-07-09 Juanma Barranquero <lekktu@gmail.com>
3860
3861 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3862
f25661f0
JD
38632011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3864
3865 * gtkutil.c (qttip_cb): Remove code without function.
3866
8278c4fe
EZ
38672011-07-09 Eli Zaretskii <eliz@gnu.org>
3868
3869 * w32.c (pthread_sigmask): New stub.
3870
1692ae2d 38712011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3872
8a6ebd58 3873 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3874 sigprocmask is portable only for single-threaded applications, and
3875 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3876 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3877 (LIBES): Use it.
3878 * callproc.c (Fcall_process):
3879 * process.c (create_process):
3880 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3881 Use pthread_sigmask, not sigprocmask.
123403e4 3882
1b854618
JD
38832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3884
3885 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3886 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3887 wrong (Bug#8591).
3888
3fe4b549
JD
38892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3890
0ce7e563
JD
3891 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3892 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3893 (xg_hide_tooltip): Fix comment.
3894
3fe4b549
JD
3895 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3896 in registerServicesMenuSendTypes.
3897 (validRequestorForSendType): Don't check ns_return_types.
3898
3899 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3900 ns_return_type.
3901
5df75e47
JR
39022011-07-08 Jason Rumney <jasonr@gnu.org>
3903
22610910
JR
3904 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3905 SH_SHOW for hidden windows (Bug#5482).
3906
5df75e47
JR
3907 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3908 frame struct members of non-existent frames (Bug#6284).
3909
699c10bd
JD
39102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3911
4393663b
JD
3912 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3913 variable firstTime not needed on OSX >= 10.6.
3914 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3915 >= 10.5. Use setKnobProportion, setDoubleValue.
3916
3917 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3918 (MAC_OS_X_VERSION_10_5): Define if not defined.
3919 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3920 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3921 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3922
3923 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3924 cString and lossyCString on OSX >= 10.4
3925
58179cce 3926 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3927 sizeToFit on OSX >= 10.2.
3928
3929 * nsimage.m (allocInitFromFile): Don't use deprecated method
3930 bestRepresentationForDevice on OSX >= 10.6.
3931
3932 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3933 to avoid warning.
3934
3935 * emacs.c: Declare unexec_init_emacs_zone.
3936
a63e0781
JD
3937 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3938
699c10bd
JD
3939 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3940
3941 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3942 on svcsMenu (Bug#8842).
3943
3944 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3945 ns_return_types.
3946 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3947
3948 * nsterm.m (QUTF8_STRING): Declare.
3949 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3950 (validRequestorForSendType): Return type is (id).
3951 Change indexOfObjectIdenticalTo to indexOfObject.
3952 Check if we have local selection before returning self (Bug#8842).
3953 (writeSelectionToPasteboard): Put local selection into paste board
3954 if we have a local selection (Bug#8842).
3955 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3956
3957 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3958 (ns_get_local_selection): Declare.
3959
54e10184
LMI
39602011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3961
9888ff71
LMI
3962 * keymap.c (describe_map_tree): Don't insert a double newline at
3963 the end of the buffer (bug#1169) and return whether we inserted
3964 something.
3965
54e10184
LMI
3966 * callint.c (Fcall_interactively): Change "reading args" to
3967 "providing args" to try to clarify what it does (bug#1010).
3968
15fa4783
KH
39692011-07-07 Kenichi Handa <handa@m17n.org>
3970
3971 * composite.c (composition_compute_stop_pos): Ignore a static
3972 composition starting before CHARPOS (Bug#8915).
3973
3974 * xdisp.c (handle_composition_prop): Likewise.
3975
a8815b00
EZ
39762011-07-07 Eli Zaretskii <eliz@gnu.org>
3977
3978 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3979 (Bug#9015)
3980
ef7b981d 39812011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3982
3983 * character.h (unicode_category_t): New enum type.
3984
3985 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3986 (Qchar_code_property_table): New variable.
3987 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3988 (UNIPROP_COMPRESSED_FORM_P): New macros.
3989 (char_table_ascii): Uncompress the compressed values.
3990 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3991 Uncompress the compressed values.
ac389d0c 3992 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3993 (char_table_ref_and_range): Uncompress the compressed values.
3994 (sub_char_table_set): New arg is_uniprop. Callers changed.
3995 Uncompress the compressed values.
3996 (sub_char_table_set_range): Args changed. Callers changed.
3997 (char_table_set_range): Adjuted for the above change.
3998 (map_sub_char_table): Delete args default_val and parent. Add arg
3999 top. Give decoded values to a Lisp function.
640c8776 4000 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4001 values to a Lisp function. Gcpro more variables.
4002 (uniprop_table_uncompress)
4003 (uniprop_decode_value_run_length): New functions.
4004 (uniprop_decoder, uniprop_decoder_count): New variables.
4005 (uniprop_get_decoder, uniprop_encode_value_character)
4006 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4007 New functions.
4008 (uniprop_encoder, uniprop_encoder_count): New variables.
4009 (uniprop_get_encoder, uniprop_table)
4010 (Funicode_property_table_internal, Fget_unicode_property_internal)
4011 (Fput_unicode_property_internal): New functions.
4012 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4013 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4014 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4015 char-code-property-alist.
4016
640c8776 4017 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4018 Vunicode_category_table.
4019
640c8776 4020 * font.c (font_range): Adjust for the change of
c805dec0
KH
4021 Vunicode_category_table.
4022
76b397fb
DN
40232011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4024
4025 * m/iris4d.h: Remove file, move contents ...
4026 * s/irix6-5.h: ... here.
4027
22b4128e
PE
40282011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4029
4030 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4031 * alloc.c (mark_buffer):
4032 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4033 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4034 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4035 This isn't true in general, and it's particularly not true
4036 if Emacs is configured with --with-wide-int.
4037 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4038 New macros, used in the buffer.c change.
4039
869795d6
JD
40402011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4041
4042 * xsettings.c: Use both GConf and GSettings if both are available.
4043 (store_config_changed_event): Add comment.
4044 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4045 (store_tool_bar_style_changed): New functions.
5e617bc2 4046 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4047 (struct xsettings): Move font inside HAVE_XFT.
4048 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4049 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4050 Move inside HAVE_XFT.
640c8776 4051 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4052 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4053 also.
4054 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4055 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4056 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4057 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4058 (parse_settings): Move check for font inside HAVE_XFT.
4059 (read_settings, apply_xft_settings): Add comment.
4060 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4061 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4062 call store_font_name_changed.
4063 (xft_settings_event): Add comment.
4064 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4065 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4066 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4067 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4068 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4069 (xsettings_get_system_font, xsettings_get_system_normal_font):
4070 Add comment.
869795d6 4071
d8ed26bd
PE
40722011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4073
4074 Random fixes. E.g., (random) never returned negative values.
4075 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4076 subseconds part to the entropy, as that's a bit more random.
4077 Prefer signed to unsigned, since the signedness doesn't matter and
4078 in general we prefer signed. When given a limit, use a
4079 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4080 latter isn't right if USE_2_TAGS_FOR_INTS.
4081 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4082 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4083
cabf1cac
SM
40842011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4085
4086 * textprop.c (text_property_stickiness):
4087 Obey Vtext_property_default_nonsticky.
4088 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4089 * w32fns.c (syms_of_w32fns):
4090 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4091
6e9b2be9
PE
40922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4093
4094 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4095 This is more efficient than Ffile_directory_p and avoids a minor race.
4096
90186c68
LMI
40972011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4098
7c301272
LMI
4099 * buffer.c (Foverlay_put): Say what the return value is
4100 (bug#7835).
4101
c4f2d8d4
LMI
4102 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4103 is a directory before asking whether to use the file name
4104 (bug#7564).
ad637907
LMI
4105 (barf_or_query_if_file_exists): Make the "File is a directory"
4106 error be more correct.
c4f2d8d4 4107
90186c68
LMI
4108 * fns.c (Frequire): Remove the mention of the .gz files, since
4109 that's installation-specific, but keep the mention of
4110 `get-load-suffixes'.
4111
da64016e
PE
41122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4113
4114 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4115 Report string overflow if the output is too long.
4116
7d47b580
JB
41172011-07-04 Juanma Barranquero <lekktu@gmail.com>
4118
a555cb87
JB
4119 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4120 (syms_of_gnutls): Remove duplicate DEFSYM for
4121 Qgnutls_bootprop_verify_hostname_error, an error for
4122 Qgnutls_bootprop_verify_error (which is no longer used).
4123
7d47b580
JB
4124 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4125 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4126 Also (re)move comments that are misplaced or no longer relevant.
4127
1e49bfab
LMI
41282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4129
4130 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4131
1485f4c0
CY
41322011-07-03 Chong Yidong <cyd@stupidchicken.com>
4133
4134 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4135 and background color parameters if they have been changed.
4136
a9ab721e
LMI
41372011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4138
4139 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4140
cf7cff57
PE
41412011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4142
2e13213d
PE
4143 * xsettings.c (SYSTEM_FONT): Define only when used.
4144 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4145
cf7cff57
PE
4146 * keymap.c (access_keymap_1): Now static.
4147
7a8e04f7
CY
41482011-07-02 Chong Yidong <cyd@stupidchicken.com>
4149
4150 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4151 leave any prefix arg for the up event (Bug#1586).
4152
61352f62
LMI
41532011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4154
69bb1ef7
LMI
4155 * lread.c (syms_of_lread): Mention single symbols defined by
4156 `defvar' or `defconst' (bug#7154).
4157
61352f62 4158 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4159 (Frequire): Mention get-load-suffixes.
61352f62 4160
28545e04
MR
41612011-07-02 Martin Rudalics <rudalics@gmx.at>
4162
4163 * window.h (window): Remove clone_number slot.
4164 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4165 Remove.
4166 (make_parent_window, make_window, saved_window)
4167 (Fset_window_configuration, save_window_save): Don't deal with
4168 clone numbers.
4169 * buffer.c (Qclone_number): Remove declaration.
4170 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4171
3349e122
SM
41722011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4173
4174 Add multiple inheritance to keymaps.
4175 * keymap.c (Fmake_composed_keymap): New function.
4176 (Fset_keymap_parent): Simplify.
4177 (fix_submap_inheritance): Remove.
4178 (access_keymap_1): New function extracted from access_keymap to handle
4179 embedded parents and handle lists of maps.
4180 (access_keymap): Use it.
4181 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4182 (Fcopy_keymap): Handle embedded parents.
4183 (Fcommand_remapping, define_as_prefix): Simplify.
4184 (Fkey_binding): Simplify.
4185 (syms_of_keymap): Move minibuffer-local-completion-map,
4186 minibuffer-local-filename-completion-map,
4187 minibuffer-local-must-match-map, and
4188 minibuffer-local-filename-must-match-map to Elisp.
4189 (syms_of_keymap): Defsubr make-composed-keymap.
4190 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4191 (parse_menu_item): Trivial simplification.
4192
3279eb87
GM
41932011-07-01 Glenn Morris <rgm@gnu.org>
4194
4195 * Makefile.in (SETTINGS_LIBS): Fix typo.
4196
4550efdf
KI
41972011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4198
4199 * coding.c (Fencode_coding_string): Record the last coding system
4200 used, as the function doc string says (bug#8738).
4201
0949d2b6
JD
42022011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4203
4204 * xsettings.c (store_monospaced_changed): Take new font as arg and
4205 check for change against current_mono_font.
4206 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4207 (emacs_settings_constructor, emacs_settings_get_property)
4208 (emacs_settings_set_property, emacs_settings_class_init)
4209 (emacs_settings_init, gsettings_obj): Remove.
4210 (something_changedCB): New function for HAVE_GSETTINGS.
4211 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4212 with value as argument.
4213 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4214 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4215 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4216 "changed".
4217
4218 * xgselect.c: Add defined (HAVE_GSETTINGS).
4219 (xgselect_initialize): Ditto.
4220
4221 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4222 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4223 xg_select.
4224
bbc6b304
PE
42252011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4226
4227 * eval.c (struct backtrace): Simplify and port the data structure.
4228 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4229 signed bit field, as this assumption is not portable and it makes
4230 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4231 "char debug_on_exit : 1" as this is not portable either; instead,
4232 use the portable "unsigned int debug_on_exit : 1". Remove unused
4233 member evalargs. Remove obsolete comments about cc bombing out.
4234
9851bfc5
JD
42352011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4236
51bb811f 4237 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4238 Let HAVE_GSETTINGS override HAVE_GCONF.
4239 (store_monospaced_changed): New function.
4240 (EMACS_SETTINGS): A new type derived from GObject to handle
4241 GSettings notifications.
4242 (emacs_settings_constructor, emacs_settings_get_property)
4243 (emacs_settings_set_property, emacs_settings_class_init):
4244 New functions.
4245 (gsettings_client, gsettings_obj): New variables.
4246 (GSETTINGS_SCHEMA): New define.
4247 (something_changedCB): Call store_monospaced_changed.
4248 (init_gsettings): New function.
4249 (xsettings_initialize): Call init_gsettings.
4250 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4251 to NULL.
4252
640c8776 4253 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4254 GCONF_CFLAGS/LIBS.
4255
5386012d
MR
42562011-06-29 Martin Rudalics <rudalics@gmx.at>
4257
4258 * window.c (resize_root_window, grow_mini_window)
4259 (shrink_mini_window): Rename Qresize_root_window to
4260 Qwindow_resize_root_window and Qresize_root_window_vertically to
4261 Qwindow_resize_root_window_vertically.
4262
f13e0b08
PE
42632011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4264
4265 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4266
94515237
JB
42672011-06-27 Juanma Barranquero <lekktu@gmail.com>
4268
4269 * makefile.w32-in: Redesign dependencies so they reflect more
4270 clearly which files are directly included by each source file,
4271 and not through other includes.
4272
e43b6e43
MR
42732011-06-27 Martin Rudalics <rudalics@gmx.at>
4274
4275 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4276 (sort_overlays, overlay_strings): When an overlay's clone number
4277 matches the window's clone number process the overlay even if
4278 the overlay's window property doesn't match the current window.
4279
d68443dc
MR
4280 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4281 (Fwindow_hchild): Rename to Fwindow_left_child.
4282 (Fwindow_next): Rename to Fwindow_next_sibling.
4283 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4284 (resize_window_check): Rename to window_resize_check.
4285 (resize_window_apply): Rename to window_resize_apply.
4286 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4287 (Fdelete_other_windows_internal, resize_frame_windows)
4288 (Fsplit_window_internal, Fdelete_window_internal)
4289 (grow_mini_window, shrink_mini_window)
4290 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4291
c7e73be5
JD
42922011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4293
4294 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4295 (emacs_fixed_set_min_size): Remove.
4296 (emacs_fixed_new): Take frame as argument.
4297
4298 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4299 (_EmacsFixedPrivate): Remove minwidth/height.
4300 Add struct frame *f.
4301 (emacs_fixed_init): Initialize priv->f.
4302 (get_parent_class, emacs_fixed_set_min_size): Remove.
4303 (emacs_fixed_new): Set priv->f to argument.
4304 (emacs_fixed_get_preferred_width)
4305 (emacs_fixed_get_preferred_height): Use min_width/height from
4306 frames size_hint to set minimum and natural (Bug#8919).
4307 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4308 and use min_width/height from frames size_hint to set
4309 min_width/height (Bug#8919).
4310
4311 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4312 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4313 Fix indentation.
c7e73be5 4314
cf99dcf8
EZ
43152011-06-26 Eli Zaretskii <eliz@gnu.org>
4316
4317 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4318 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4319 called at ZV.
4320
029529ac
CY
43212011-06-26 Chong Yidong <cyd@stupidchicken.com>
4322
4323 * process.c (wait_reading_process_output): Bypass select if
4324 waiting for a cell while ignoring keyboard input, and input is
4325 pending. Suggested by Jan Djärv (Bug#8869).
4326
7a7ef429
PE
43272011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4328
4329 Use gnulib's dup2 module instead of rolling our own.
4330 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4331
11fdef7d 43322011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4333
4334 * dispnew.c (scrolling_window): Before scrolling, turn off a
4335 mouse-highlight in the window being scrolled.
4336
cd3520a4
JB
43372011-06-24 Juanma Barranquero <lekktu@gmail.com>
4338
4339 Move DEFSYM to lisp.h and use everywhere.
4340
4341 * character.h (DEFSYM): Move declaration...
4342 * lisp.h (DEFSYM): ...here.
4343
4344 * gnutls.c:
4345 * minibuf.c:
4346 * w32menu.c:
4347 * w32proc.c:
4348 * w32select.c: Don't include character.h.
4349
4350 * alloc.c (syms_of_alloc):
4351 * buffer.c (syms_of_buffer):
4352 * bytecode.c (syms_of_bytecode):
4353 * callint.c (syms_of_callint):
4354 * casefiddle.c (syms_of_casefiddle):
4355 * casetab.c (init_casetab_once):
4356 * category.c (init_category_once, syms_of_category):
4357 * ccl.c (syms_of_ccl):
4358 * cmds.c (syms_of_cmds):
4359 * composite.c (syms_of_composite):
4360 * dbusbind.c (syms_of_dbusbind):
4361 * dired.c (syms_of_dired):
4362 * dispnew.c (syms_of_display):
4363 * doc.c (syms_of_doc):
4364 * editfns.c (syms_of_editfns):
4365 * emacs.c (syms_of_emacs):
4366 * eval.c (syms_of_eval):
4367 * fileio.c (syms_of_fileio):
4368 * fns.c (syms_of_fns):
4369 * frame.c (syms_of_frame):
4370 * fringe.c (syms_of_fringe):
4371 * insdel.c (syms_of_insdel):
4372 * keymap.c (syms_of_keymap):
4373 * lread.c (init_obarray, syms_of_lread):
4374 * macros.c (syms_of_macros):
4375 * msdos.c (syms_of_msdos):
4376 * print.c (syms_of_print):
4377 * process.c (syms_of_process):
4378 * search.c (syms_of_search):
4379 * sound.c (syms_of_sound):
4380 * syntax.c (init_syntax_once, syms_of_syntax):
4381 * terminal.c (syms_of_terminal):
4382 * textprop.c (syms_of_textprop):
4383 * undo.c (syms_of_undo):
4384 * w32.c (globals_of_w32):
4385 * window.c (syms_of_window):
4386 * xdisp.c (syms_of_xdisp):
4387 * xfaces.c (syms_of_xfaces):
4388 * xfns.c (syms_of_xfns):
4389 * xmenu.c (syms_of_xmenu):
4390 * xsettings.c (syms_of_xsettings):
4391 * xterm.c (syms_of_xterm): Use DEFSYM.
4392
4228cf16
TZ
43932011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4394
cd3520a4 4395 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4396
7fcccf1e
PE
43972011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4398
7efb4e0e
PE
4399 Integer and buffer overflow fixes (Bug#8873).
4400
ff5844ad
PE
4401 * print.c (printchar, strout): Check for string overflow.
4402 (PRINTPREPARE, printchar, strout):
4403 Don't set size unless allocation succeeds.
4404
90532f02
PE
4405 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4406 for sizes. Check for string overflow more accurately.
4407 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4408
6d84508d
PE
4409 * macros.c: Integer and buffer overflow fixes.
4410 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4411 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4412 Use ptrdiff_t, not int, for sizes.
4413 Don't increment bufsize until after realloc succeeds.
4414 Check for size-calculation overflow.
4415 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4416
437b2cb4
PE
4417 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4418
8b9ac8b4
PE
4419 * lread.c: Integer overflow fixes.
4420 (read_integer): Radix is now EMACS_INT, not int,
4421 to improve quality of diagnostics for out-of-range radices.
4422 Calculate buffer size correctly for out-of-range radices.
4423 (read1): Check for integer overflow in radices, and in
4424 read-circle numbers.
82cb60d3
PE
4425 (read_escape): Avoid int overflow.
4426 (Fload, openp, read_buffer_size, read1)
4427 (substitute_object_recurse, read_vector, read_list, map_obarray):
4428 Use ptrdiff_t, not int, for sizes.
4429 (read1): Use EMACS_INT, not int, for sizes.
20270765 4430 Check for size overflow.
8b9ac8b4 4431
7fcccf1e
PE
4432 * image.c (cache_image): Check for size arithmetic overflow.
4433
bfbbd7e7
PE
4434 * lread.c: Integer overflow issues.
4435 (saved_doc_string_size, saved_doc_string_length)
4436 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4437 Now ptrdiff_t, not int.
4438 (read1): Don't assume doc string length fits in int. Check for
4439 out-of-range doc string lengths.
4440 (read_list): Don't assume file position fits in int.
39019e54 4441 (read_escape): Check for hex character overflow.
bfbbd7e7 4442
4e323265
LL
44432011-06-22 Leo Liu <sdl.web@gmail.com>
4444
4445 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4446 Move to minibuffer.el.
4447
85fece3e
PE
44482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4449
20b84ce9 4450 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4451 The following patches are for when GLYPH_DEBUG && !XASSERT.
4452 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4453 * dispnew.c (flush_stdout):
4454 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4455 Mark as externally visible.
4456 * dispnew.c (check_window_matrix_pointers): Now static.
4457 * dispnew.c (window_to_frame_vpos):
4458 * xfns.c (unwind_create_frame):
4459 * xterm.c (x_check_font): Remove unused local.
4460 * scroll.c (CHECK_BOUNDS):
4461 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4462 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4463 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4464 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4465 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4466 Now static.
4467 (debug_method_add): Use va_list and vsprintf rather than relying
4468 on undefined behavior with wrong number of arguments.
4469 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4470 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4471 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4472 since we're not interested in debugging glyphs with old libraries.
4473 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4474 GCC 4.6.0's static checking.
4475
0766b489
PE
44762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4477
31fd4b32
PE
4478 Integer overflow and signedness fixes (Bug#8873).
4479 A few related buffer overrun fixes, too.
4480
b79e8648
PE
4481 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4482
0766b489
PE
4483 * dispextern.h (struct face.stipple):
4484 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4485 (x_bitmap_mask, x_allocate_bitmap_record)
4486 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4487 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4488 (x_create_bitmap_from_xpm_data):
4489 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4490 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4491 (.bitmaps_last):
4492 * xfaces.c (load_pixmap):
4493 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4494 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4495 (.bitmaps_last, struct x_output.icon_bitmap):
4496 Use ptrdiff_t, not int, for bitmap indexes.
4497 (x_allocate_bitmap_record): Check for size overflow.
4498 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4499
b081724f
PE
4500 Use ptrdiff_t, not int, for overlay counts.
4501 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4502 * editfns.c (overlays_around, get_pos_property):
4503 * textprop.c (get_char_property_and_overlay):
4504 * xdisp.c (next_overlay_change, note_mouse_highlight):
4505 * xfaces.c (face_at_buffer_position):
21514da7
PE
4506 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4507 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4508 (Fnext_overlay_change, Fprevious_overlay_change)
4509 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4510 Use ptrdiff_t, not int, for sizes.
21514da7 4511 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4512
3de73e5e
PE
4513 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4514
2606c57b
PE
4515 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4516 (x_session_initialize): Do not assume string length fits in int.
4517
aaafe47a
PE
4518 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4519 This is unlikely, but can occur if DPI is outlandish.
4520
2674ddc8 4521 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4522 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4523
28154962
PE
4524 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4525 * xrdb.c (magic_file_p, search_magic_path):
4526 Omit last arg SUFFIX; it was always 0. All callers changed.
4527 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4528
7de51af5
PE
4529 * xfont.c (xfont_match): Avoid need for strlen.
4530
25ed6cc3
PE
4531 * xfns.c: Don't assume strlen fits in int.
4532 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4533
4eab31dd
PE
4534 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4535 not unsigned long, as we prefer signed integers. All callers changed.
4536 Detect integer overflow in repeat count.
4537 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4538 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4539
171e2a58
PE
4540 * termcap.c: Don't assume sizes fit in int and never overflow.
4541 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4542 (gobble_line): Check for size-calculation overflow.
4543
ad39faca 4544 * minibuf.c (Fread_buffer):
6e5bb2dc 4545 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4546 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4547 Don't assume string length fits in int.
4548
52c61c22 4549 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4550 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4551
b5b8c9e5
PE
4552 * font.c: Don't assume string length fits in int.
4553 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4554 Use ptrdiff_t, not int.
ccd6111c
PE
4555 (font_intern_prop): Don't assume string length fits in int.
4556 Don't assume integer property fits in fixnum.
4557 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4558
882f0d81 4559 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4560 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4561 Reformulate so as not to need the command string.
4562 Invoke gzip -cd rather than gunzip, as it's more portable.
4563 (lock_info_type, lock_file_1, lock_file):
4564 Don't assume pid_t and time_t fit in unsigned long.
4565 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4566 (current_lock_owner): Prefer signed type for sizes.
4567 Use memcpy, not strncpy, where memcpy is what is really wanted.
4568 Don't assume (via atoi) that time_t and pid_t fit in int.
4569 Check for time_t and/or pid_t out of range, e.g., via a network share.
4570 Don't alloca where an auto var works fine.
4571
93f4cf88
PE
4572 * fileio.c: Fix some integer overflow issues.
4573 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4574 Don't assume string length fits in int.
4575 (directory_file_name): Don't assume string length fits in long.
4576 (make_temp_name): Don't assume pid fits in int, or that its print
4577 length is less than 20.
4578
f3e92b69
PE
4579 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4580
1bfdaf10
PE
4581 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4582
35016e9a
PE
4583 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4584
3d1e65a1
PE
4585 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4586 We prefer signed integers, even for size calculations.
4587
0b963a93
PE
4588 * emacs.c: Don't assume string length fits in 'int'.
4589 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4590 (main): Don't invoke strlen when not needed.
4591
573f4b54
PE
4592 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4593 (XD_DEBUG_MESSAGE): Don't waste a byte.
4594
989f33ba
PE
4595 * callproc.c (getenv_internal_1, getenv_internal)
4596 (Fgetenv_internal):
965d34eb
PE
4597 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4598
e4d29b33
PE
4599 * lread.c (invalid_syntax): Omit length argument.
4600 All uses changed. This doesn't fix a bug, but it simplifies the
4601 code away from its former Hollerith-constant appearance, and it's
4602 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4603 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4604
eb49b136
PE
4605 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4606 This didn't break anything, but it didn't help either.
4607 It's confusing to put a bogus integer in a place where the actual
4608 value does not matter.
9f62aeb1 4609 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4610 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4611
15375a22
PE
4612 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4613 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4614 implementation.
b61cc01c
PE
4615 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4616 We prefer signed types, and the value cannot exceed the EMACS_INT
4617 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4618 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4619 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4620 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4621
53b2623d
PE
4622 * indent.c (sane_tab_width): New function.
4623 (current_column, scan_for_column, Findent_to, position_indentation)
4624 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4625 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4626
51cab52b 4627 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4628
f2ed8a70
PE
4629 * lisp.h (lint_assume): New macro.
4630 * composite.c (composition_gstring_put_cache):
4631 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4632
abe80cc6
PE
4633 * editfns.c, insdel.c:
4634 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4635
b02c740e
PE
4636 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4637
ebc96716
PE
4638 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4639
b4e50fa0 4640 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4641 Use much-faster test for byte-length change.
311d5d7c 4642 Don't assume string byte-length fits in 'int'.
a4cf38e4 4643 Check that character arg fits in 'int'.
85461888 4644 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4645
c0c1ee9f
PE
4646 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4647
a498d7f4
PE
4648 * fns.c (concat): Catch string overflow earlier.
4649 Do not rely on integer wraparound.
4650
51cab52b
PE
4651 * dispextern.h (struct it.overlay_strings_charpos)
4652 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4653 * xdisp.c (forward_to_next_line_start)
4654 (back_to_previous_visible_line_start)
4655 (reseat_at_next_visible_line_start, next_element_from_buffer):
4656 Don't arbitrarily truncate the value of 'selective' to int.
4657
76031fad
PE
4658 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4659
5eb55db9
PE
4660 * composite.c: Don't truncate sizes to 'int'.
4661 (composition_gstring_p, composition_reseat_it)
4662 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4663 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4664 not EMACS_UINT, for indexes.
5eb55db9 4665
0703a717
PE
4666 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4667
d6202519
PE
4668 * buffer.c: Include <verify.h>.
4669 (struct sortvec.priority, struct sortstr.priority):
8961a454 4670 Now EMACS_INT, not int.
c20998a7 4671 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4672 (struct sortstr.size, record_overlay_string)
4673 (struct sortstrlist.size, struct sortlist.used):
4674 Don't truncate size to int.
4675 (record_overlay_string): Check for size-calculation overflow.
d6202519 4676 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4677
d5a19415
JM
46782011-06-22 Jim Meyering <meyering@redhat.com>
4679
029529ac 4680 Don't leak an XBM-image-sized buffer
d5a19415
JM
4681 * image.c (xbm_load): Free the image buffer after using it.
4682
a9041e6c
PE
46832011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 Port to Sun C.
4686 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4687 that Sun C diagnosed.
4688 * fns.c (secure_hash): Fix pointer signedness issue.
4689 * intervals.c (static_offset_intervals): New function.
4690 (offset_intervals): Use it.
4691
7f3f739f
LL
46922011-06-21 Leo Liu <sdl.web@gmail.com>
4693
4694 * deps.mk (fns.o):
4695 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4696 sha512.h.
4697
4698 * fns.c (secure_hash): Rename from crypto_hash_function and change
4699 the first arg to accept symbols.
5b66d427 4700 (Fsecure_hash): New primitive.
7f3f739f
LL
4701 (syms_of_fns): New symbols.
4702
76147d94
DD
47032011-06-20 Deniz Dogan <deniz@dogan.se>
4704
4705 * process.c (Fset_process_buffer): Clarify return value in
4706 docstring.
4707
7d7d0045
CY
47082011-06-18 Chong Yidong <cyd@stupidchicken.com>
4709
4710 * dispnew.c (add_window_display_history): Use BVAR.
4711
4712 * xdisp.c (debug_method_add): Use BVAR.
4713 (check_window_end, dump_glyph_matrix, dump_glyph)
4714 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4715
4716 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4717 Likewise.
4718
4719 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4720 check till after the cache is created in init_frame_faces.
4721
ff2bc410
SM
47222011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4723
4724 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4725
28177add
PE
47262011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4727
dd3482fe
PE
4728 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4729 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4730 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4731
393d71f3 4732 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4733 * fileio.c (Finsert_file_contents):
4734 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4735 Remove the old (too-loose) buffer overflow checks.
4736 They weren't needed, since make_gap checks for buffer overflow.
4737 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4738 The old code merely checked for Emacs fixnum overflow, and relied
4739 on undefined (wraparound) behavior. The new code avoids undefined
4740 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4741
2e6813b0 4742 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4743 Tune. Don't use wider integers than needed. Don't use alloca.
4744 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4745
599a9e4f
PE
4746 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4747
99561444
PE
4748 * insdel.c, lisp.h (buffer_overflow): New function.
4749 (insert_from_buffer_1, replace_range, replace_range_2):
4750 * insdel.c (make_gap_larger):
4751 * editfns.c (Finsert_char):
4752 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4753
28177add
PE
4754 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4755
e69dafad
PE
47562011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4757
4baa020d 4758 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4759
b1c46f02
PE
4760 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4761 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4762
e69dafad
PE
4763 * fileio.c: Don't assume EMACS_INT fits in off_t.
4764 (emacs_lseek): New static function.
4765 (Finsert_file_contents, Fwrite_region): Use it.
4766 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4767
566684ea
PE
4768 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4769
e6966cd6
PE
4770 * fns.c: Don't overflow int when computing a list length.
4771 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4772 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4773 truncation on 64-bit hosts. Check for QUIT every
4774 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4775 faster and is responsive enough.
4776 (Flength): Report an error instead of overflowing an integer.
4777 (Fsafe_length): Return a float if the value is not representable
4778 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4779 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4780 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4781
dd0b0efb
PE
4782 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4783 (header_size, word_size): New constants.
4784 (allocate_vectorlike): Don't check size overflow here.
4785 (allocate_vector): Check it here instead, since this is the only
4786 caller of allocate_vectorlike that could cause overflow.
4787 Check that the new vector's length is representable as a fixnum.
4788
86fe5cfe
PE
4789 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4790 The previous code was bogus. For example, next_almost_prime (32)
4791 returned 39, which is undesirable as it is a multiple of 3; and
4792 next_almost_prime (24) returned 25, which is a multiple of 5 so
4793 why was the code bothering to check for multiples of 7?
4794
80e88859
PE
4795 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4796
4a2f0ad6
PE
4797 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4798
f66c7cf8
PE
4799 Variadic C functions now count arguments with ptrdiff_t.
4800 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4801 Back then I didn't know that the Emacs coding style prefers signed int.
4802 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4803 were being counted with int, which may truncate counts on 64-bit
4804 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4805 * lisp.h (struct Lisp_Subr.function.aMANY)
4806 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4807 Arg counts are now ptrdiff_t, not size_t.
4808 All variadic functions and their callers changed accordingly.
4809 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4810 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4811 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4812 * callint.c (Fcall_interactively): Check arg count for overflow,
4813 to avoid potential buffer overrun. Use signed char, not 'int',
4814 for 'varies' array, so that we needn't bother to check its size
4815 calculation for overflow.
4816 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4817 * eval.c (apply_lambda):
4818 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4819 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4820 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4821
a1759b76
PE
4822 * callint.c (Fcall_interactively): Don't use index var as event count.
4823
d96be9fc
PE
4824 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4825 * mem-limits.h (SIZE): Remove; no longer used.
4826
a690a978 4827 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4828
578c21e6
PE
4829 Remove unnecessary casts.
4830 * xterm.c (x_term_init):
4831 * xfns.c (x_set_border_pixel):
4832 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4833 These aren't needed now that we assume ANSI C.
4834
96f53c6c
PE
4835 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4836 It's more likely to cause problems (due to unsigned overflow)
4837 than to cure them.
4838
83c77d31
PE
4839 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4840
ee2079f1
PE
4841 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4842
6da65536
PE
4843 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4844
7147c4a4
PE
4845 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4846
193e32d9
PE
4847 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4848
e5533da6
PE
4849 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4850
9910e595
PE
4851 GLYPH_CODE_FACE returns EMACS_INT, not int.
4852 * dispextern.h (merge_faces):
4853 * xfaces.c (merge_faces):
01103c44
PE
4854 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4855 Don't assume EMACS_INT fits in int.
9910e595 4856
2638320e
PE
4857 * character.h (CHAR_VALID_P): Remove unused parameter.
4858 * fontset.c, lisp.h, xdisp.c: All uses changed.
4859
045eb8d9
PE
4860 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4861
c1f134b5
PE
4862 * fns.c (concat): Minor tuning based on overflow analysis.
4863 This doesn't fix any bugs. Use int to hold character, instead
4864 of constantly refetching from Emacs object. Use XFASTINT, not
4865 XINT, for value known to be a character. Don't bother comparing
4866 a single byte to 0400, as it's always less.
4867
395fcb93 4868 * floatfns.c (Fexpt):
327eeec8
PE
4869 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4870
abbd3d23
PE
4871 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4872 for characters.
4873
684a03ef
PE
4874 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4875
0fed43f3
PE
4876 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4877 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4878 incorrectly succeed when S was a string, because 4294967386 was
4879 truncated before it was used.
4880
8fd02eb7
PE
4881 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4882 Otherwise, an out-of-range integer could cause undefined behavior
4883 on a 64-bit host.
4884
f8c86b69
PE
4885 * composite.c: Use int, not EMACS_INT, for characters.
4886 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4887 EMACS_INT, for values that are known to be in character range.
4888 This doesn't fix any bugs but is the usual style inside Emacs and
4889 may generate better code on 32-bit machines.
4890
34206dd2
PE
4891 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4892 This is for reasons similar to the recent CHAR_STRING fix.
4893 * charset.c (Fencode_char): Check that character arg is actually
4894 a character. Pass an int to ENCODE_CHAR.
4895 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4896 wider than 'int', as a compile-time check to prevent future regressions
4897 in this area.
4898
c5958d4c 4899 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4900
4901 Make sure a 64-bit char is never passed to CHAR_STRING.
4902 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4903 by silently ignoring the top 32 bits, allowing some values
4904 that were far too large to be valid characters.
4905 * character.h: Include <verify.h>.
4906 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4907 arguments are no wider than unsigned, as a compile-time check
4908 to prevent future regressions in this area.
4909 * data.c (Faset):
01103c44 4910 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4911 (Fsubst_char_in_region):
4912 * fns.c (concat):
4913 * xdisp.c (decode_mode_spec_coding):
4914 Adjust to CHAR_STRING's new requirement.
4915 * editfns.c (Finsert_char, Fsubst_char_in_region):
4916 * fns.c (concat): Check that character args are actually
4917 characters. Without this test, these functions did the wrong
4918 thing with wildly out-of-range values on 64-bit hosts.
4919
d37ca623
PE
4920 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4921 These casts should not be needed on 32-bit hosts, either.
4922 * keyboard.c (read_char):
4923 * lread.c (Fload): Remove casts to unsigned.
4924
ea204efb
PE
4925 * lisp.h (UNSIGNED_CMP): New macro.
4926 This fixes comparison bugs on 64-bit hosts.
4927 (ASCII_CHAR_P): Use it.
4928 * casefiddle.c (casify_object):
01103c44 4929 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4930 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4931 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4932 * dispextern.h (FACE_FROM_ID):
4933 * keyboard.c (read_char): Use UNSIGNED_CMP.
4934
41cb286c
PE
4935 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4936 not to EMACS_INT, to avoid GCC warning.
4937
4a1b9832
PE
4938 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4939
55daad71
PE
4940 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4941 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4942 isn't needed on 32-bit machines.
8f95c75c 4943
01103c44
PE
4944 * buffer.c (Fgenerate_new_buffer_name):
4945 Use EMACS_INT for count, not int.
0ceccced 4946 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4947
4948 * data.c (Qcompiled_function): Now static.
4949
c6f072e7
PE
4950 * window.c (window_body_lines): Now static.
4951
20ce5912
PE
4952 * image.c (gif_load): Rename local to avoid shadowing.
4953
9c4c5f81
PE
4954 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4955 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4956 * alloc.c (make_save_value): Integer argument is now of type
4957 ptrdiff_t, not int.
4958 (mark_object): Use ptrdiff_t, not int.
4959 * lisp.h (pD): New macro.
4960 * print.c (print_object): Use it.
4961
c0c5c8ae
PE
4962 * alloc.c: Use EMACS_INT, not int, to count objects.
4963 (total_conses, total_markers, total_symbols, total_vector_size)
4964 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4965 (total_free_floats, total_floats, total_free_intervals)
4966 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4967 Now EMACS_INT, not int. All uses changed.
4968 (Fgarbage_collect): Compute overall total using a double, so that
4969 integer overflow is less likely to be a problem. Check for overflow
4970 when converting back to an integer.
5a25e253
PE
4971 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4972 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4973 These were 'int' variables that could overflow on 64-bit hosts;
4974 they were never used, so remove them instead of repairing them.
211a0b2a 4975 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4976 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4977 Previously, this ceilinged at INT_MAX, but that doesn't work on
4978 64-bit machines.
e46bb31a 4979 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4980
c78baabf 4981 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4982 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4983 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4984 when a (possibly-narrower) signed value would do just as well.
4985 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4986
c9d624c6
PE
4987 * alloc.c: Catch some string size overflows that we were missing.
4988 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4989 for convenience in STRING_BYTES_MAX.
4990 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4991 The definition here is exact; the one in lisp.h was approximate.
4992 (allocate_string_data): Check for string overflow. This catches
4993 some instances we weren't catching before. Also, it catches
4994 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4995 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4996 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4997
c9d624c6
PE
4998 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4999 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5000 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5001
353032ce
PE
5002 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5003
2bccce07
PE
5004 * alloc.c (Fmake_string): Check for out-of-range init.
5005
0ac30604
SM
50062011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5007
5008 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5009
c195f2de
JD
50102011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5011
5012 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5013 xg_get_default_scrollbar_width.
5014
5015 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5016 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5017 (style_changed_cb): Call update_theme_scrollbar_width and call
5018 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5019 all frames (Bug#8505).
5020 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5021 Call gtk_window_set_resizable if HAVE_GTK3.
5022 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5023 and height if HAVE_GTK3 (Bug#8505).
5024 (scroll_bar_width_for_theme): New variable.
5025 (update_theme_scrollbar_width): New function.
5026 (xg_get_default_scrollbar_width): Move code to
5027 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5028 (xg_initialize): Call update_theme_scrollbar_width.
5029
5030 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5031
5032 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5033
e10ac9f1
MR
50342011-06-12 Martin Rudalics <rudalics@gmx.at>
5035
5036 * frame.c (make_frame): Call other_buffer_safely instead of
5037 other_buffer.
5038
5039 * window.c (temp_output_buffer_show): Call display_buffer with
5040 second argument Vtemp_buffer_show_specifiers and reset latter
5041 immediately after the call.
5042 (Vtemp_buffer_show_specifiers): New variable.
5043 (auto_window_vscroll_p, next_screen_context_lines)
5044 (Vscroll_preserve_screen_position): Remove leading asterisks from
5045 doc-strings.
5046
2d3c217e 50472011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5048
7b7f97e8 5049 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5050 * buffer.c (Qclone_number): Remove for now, as it's unused.
5051 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5052 (record_buffer): Remove unused local.
5053 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5054 (set_frame_buffer_list): Remove; unused.
5055 * frame.h (other_visible_frames): Remove decl.
5056 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5057 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5058 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5059 if HAVE_GPM.
5060 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5061 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5062 Define only if HAVE_GPM.
5063 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5064 (update_hints_inhibit): Remove; never set. All uses removed.
5065 * widgetprv.h (emacsFrameClassRec): Remove decl.
5066 * window.c (delete_deletable_window): Now returns void, since it
5067 wasn't returning anything.
5068 (compare_window_configurations): Remove unused locals.
5069 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5070 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5071 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5072 the same widths as pointers. This follows up on the 2011-05-06 patch.
5073 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5074 * xterm.h: Likewise.
5075 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5076
1384b89e
JB
50772011-06-12 Juanma Barranquero <lekktu@gmail.com>
5078
5079 * makefile.w32-in: Update dependencies.
5080 (LISP_H): Add lib/intprops.h.
5081
1100a63c
CY
50822011-06-11 Chong Yidong <cyd@stupidchicken.com>
5083
5084 * image.c (gif_load): Add animation frame delay to the metadata.
5085 (syms_of_image): Use DEFSYM. New symbol `delay'.
5086
6198ccd0
MR
50872011-06-11 Martin Rudalics <rudalics@gmx.at>
5088
5089 * window.c (delete_deletable_window): Re-add.
5090 (Fset_window_configuration): Rewrite to handle dead buffers and
5091 consequently deletable windows.
5092 (window_tree, Fwindow_tree): Remove. Supply functionality in
5093 window.el.
5094 (compare_window_configurations): Simplify code.
5095
b6e3633c
AS
50962011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5097
1ab0dee5
AS
5098 * image.c (imagemagick_load_image): Fix type mismatch.
5099 (Fimagemagick_types): Likewise.
5100
b6e3633c
AS
5101 * window.h (replace_buffer_in_windows): Declare.
5102
9397e56f
MR
51032011-06-11 Martin Rudalics <rudalics@gmx.at>
5104
5105 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5106 Qclone_number. Remove external declaration of Qdelete_window.
5107 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5108 code.
640c8776
SM
5109 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5110 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5111 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5112 buffer list implementation.
5113 (other_buffer_safely): New function.
5114 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5115 calls to replace_buffer_in_windows and
5116 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5117 if allowed.
5118 (record_buffer): Inhibit quitting and rewrite using quittable
5119 functions. Run Qbuffer_list_update_hook if allowed.
5120 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5121 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5122 Move switch-to-buffer to window.el.
9397e56f
MR
5123 (bury-buffer): Move to window.el.
5124 (Vbuffer_list_update_hook): New variable.
5125
5126 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5127 section.
5128
5129 * window.h (resize_frame_windows): Move up in code.
5130 (Fwindow_frame): Remove EXFUN.
5131 (replace_buffer_in_all_windows): Remove prototype.
5132 (replace_buffer_in_windows_safely): Add prototype.
5133
5134 * window.c: Declare Qdelete_window static again. Move down
5135 declaration of select_count.
5136 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5137 (Fother_window): Move to window.el.
5138 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5139 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5140 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5141 window.el.
5142 (replace_buffer_in_windows): Implement by calling
5143 Qreplace_buffer_in_windows.
5144 (replace_buffer_in_all_windows): Remove with some functionality
5145 moved into replace_buffer_in_windows_safely.
5146 (replace_buffer_in_windows_safely): New function.
5147 (select_window_norecord, select_frame_norecord): Move in front
5148 of run_window_configuration_change_hook. Remove now obsolete
5149 declarations.
640c8776
SM
5150 (Fset_window_buffer): Rewrite doc-string.
5151 Call Qrecord_window_buffer.
9397e56f
MR
5152 (keys_of_window): Move binding for other-window to window.el.
5153
b50691aa
CY
51542011-06-11 Chong Yidong <cyd@stupidchicken.com>
5155
5156 * dispextern.h (struct image): Replace data member, whose int_val
5157 and ptr_val fields were not used by anything, with a single
5158 lisp_val object.
5159
5160 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5161 (gif_clear_image, gif_load, imagemagick_load_image)
5162 (gs_clear_image, gs_load): Callers changed.
5163
3f754b86
PE
51642011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5165
cca69397
PE
5166 * buffer.h: Include <time.h>, for time_t.
5167 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5168
109e28d0
PE
5169 Fix minor problems found by static checking.
5170
60737f02
PE
5171 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5172
4b66faf3
PE
5173 Make identifiers static if they are not used in other modules.
5174 * data.c (Qcompiled_function, Qframe, Qvector):
5175 * image.c (QimageMagick, Qsvg):
5176 * minibuf.c (Qmetadata):
5177 * window.c (resize_window_check, resize_root_window): Now static.
5178 * window.h (resize_window_check, resize_root_window): Remove decls.
5179
109e28d0
PE
5180 * window.c (window_deletion_count, delete_deletable_window):
5181 Remove; unused.
46a4ce9e
PE
5182 (window_body_lines): Now static.
5183 (Fdelete_other_windows_internal): Mark vars as initialized.
5184 Make sure 'resize_failed' is initialized.
5185 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5186 (resize_window_apply): Remove unused local.
5187 * window.h (delete_deletable_window): Remove decl.
5188
109e28d0 5189 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5190 (imagemagick_load_image): Fix pointer signedness problem by changing
5191 last arg from unsigned char * to char *. All uses changed.
5192 Also, fix a local for similar reasons.
5193 Remove unused locals. Remove locals to avoid shadowing.
5194 (fn_rsvg_handle_free): Remove; unused.
5195 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5196 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5197
3f754b86
PE
5198 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5199
2547adb1
CY
52002011-06-10 Chong Yidong <cyd@stupidchicken.com>
5201
5202 * image.c (gif_load): Fix omitted cast error introduced by
5203 2011-06-06 change.
5204
2c8e37d4
MR
52052011-06-10 Martin Rudalics <rudalics@gmx.at>
5206
5207 * window.h (resize_proportionally, orig_total_lines)
5208 (orig_top_line): Remove from window structure.
5209 (set_window_height, set_window_width, change_window_heights)
5210 (Fdelete_window): Remove prototypes.
5211 (resize_frame_windows): Remove duplicate declaration.
5212
440a42e3
EZ
52132011-06-10 Eli Zaretskii <eliz@gnu.org>
5214
5215 * window.h (resize_frame_windows, resize_window_check)
5216 (delete_deletable_window, resize_root_window)
5217 (resize_frame_windows): Declare prototypes.
5218
5219 * window.c (resize_window_apply): Make definition be "static" to
5220 match the prototype.
5221
562dd5e9
MR
52222011-06-10 Martin Rudalics <rudalics@gmx.at>
5223
5224 * window.c: Remove declarations of Qwindow_size_fixed,
5225 window_min_size_1, window_min_size_2, window_min_size,
5226 size_window, window_fixed_size_p, enlarge_window, delete_window.
5227 Remove static from declaration of Qdelete_window, it's
5228 temporarily needed by Fbury_buffer.
5229 (replace_window): Don't assign orig_top_line and
5230 orig_total_lines.
5231 (Fdelete_window, delete_window): Remove. Window deletion is
5232 handled by window.el.
640c8776
SM
5233 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5234 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5235 (Fdelete_other_windows): Remove. Deleting other windows is
5236 handled by window.el.
5237 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5238 handled in window.el.
5239 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5240 Window minimum sizes are handled in window.el.
5241 (shrink_windows, size_window, set_window_height)
5242 (set_window_width, change_window_heights, window_height)
5243 (window_width, CURBEG, CURSIZE, enlarge_window)
5244 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5245 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5246 handled in window.el.
5247 (make_dummy_parent): Rename to make_parent_window and give it a
5248 second argument horflag.
5249 (make_window): Don't set resize_proportionally any more.
5250 (Fsplit_window): Remove. Windows are split in window.el.
5251 (save_restore_action, save_restore_orig_size)
5252 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5253 Resize mini windows in window.el.
5254 (grow_mini_window, shrink_mini_window): Implement by calling
5255 Qresize_root_window_vertically, resize_window_check and
5256 resize_window_apply.
640c8776
SM
5257 (saved_window, Fset_window_configuration, save_window_save):
5258 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5259 resize_proportionally.
5260 (window_min_height, window_min_width): Move to window.el.
5261 (keys_of_window): Move bindings for delete-other-windows,
5262 split-window, delete-window and enlarge-window to window.el.
5263
5264 * buffer.c: Temporarily extern Qdelete_window.
5265 (Fbury_buffer): Temporarily call Qdelete_window instead of
5266 Fdelete_window (Fbury_buffer will move to window.el soon).
5267
5268 * frame.c (set_menu_bar_lines_1): Remove code handling
5269 orig_top_line and orig_total_lines.
5270
5271 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5272 set_window_height but set heights directly.
5273 (change_frame_size_1): Use resize_frame_windows.
5274
5275 * xdisp.c (init_xdisp): Don't use set_window_height but set
5276 heights directly.
5277
640c8776
SM
5278 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5279 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5280 run_window_configuration_change_hook.
5281
5282 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5283 instead of change_window_heights and run
5284 run_window_configuration_change_hook.
5285
1a13852e
MR
52862011-06-09 Martin Rudalics <rudalics@gmx.at>
5287
5288 * window.c (replace_window): Rename second argument REPLACEMENT to
5289 NEW. New third argument SETFLAG. Rewrite.
5290 (delete_window, make_dummy_parent): Call replace_window with
5291 third argument 1.
5292 (window_list_1): Move down in code.
5293 (run_window_configuration_change_hook): Move set_buffer part
5294 before select_frame_norecord part in order to unwind correctly.
5295 Rename count1 to count.
5296 (recombine_windows, delete_deletable_window, resize_root_window)
5297 (Fdelete_other_windows_internal)
5298 (Frun_window_configuration_change_hook, make_parent_window)
5299 (resize_window_check, resize_window_apply, Fresize_window_apply)
5300 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5301 (Fdelete_window_internal, Fresize_mini_window_internal):
5302 New functions.
1a13852e
MR
5303 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5304
f3d1777e
MR
53052011-06-08 Martin Rudalics <rudalics@gmx.at>
5306
496e208e
MR
5307 * window.h (window): Add some new members to window structure -
5308 normal_lines, normal_cols, new_total, new_normal, clone_number,
5309 splits, nest, prev_buffers, next_buffers.
5310 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5311 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5312
f3d1777e
MR
5313 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5314 Remove.
496e208e
MR
5315 (make_dummy_parent): Set new members of windows structure.
5316 (make_window): Move down in code. Handle new members of window
5317 structure.
5318 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5319 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5320 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5321 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5322 (Fset_window_next_buffers, Fset_window_clone_number):
5323 New functions.
496e208e
MR
5324 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5325 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5326 Doc-string fixes.
5327 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5328 Argument WINDOW can be now internal window too.
5329 (Fwindow_use_time): Move up in code.
5330 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5331 Rewrite doc-string.
5332 (Fset_window_configuration, saved_window)
5333 (Fcurrent_window_configuration, save_window_save): Handle new
5334 members of window structure.
b9e809c2
MR
5335 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5336 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5337 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5338 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5339 Qget_mru_window, Qresize_root_window,
5340 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5341 Qauto_buffer_name; staticpro them.
f3d1777e 5342
abde8f8c
MR
53432011-06-07 Martin Rudalics <rudalics@gmx.at>
5344
5345 * window.c (Fwindow_total_size, Fwindow_left_column)
5346 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5347 (Fwindow_list_1): New functions.
5348 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5349 (Fwindow_width, Fscroll_left, Fscroll_right):
5350 Use window_body_cols instead of window_box_text_cols.
5351 (delete_window, Fset_window_configuration):
5352 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5353 (delete_all_subwindows): Take a window as argument and not a
5354 structure. Rewrite.
190b47e6
MR
5355 (window_loop): Remove handling of GET_LRU_WINDOW and
5356 GET_LARGEST_WINDOW.
5357 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5358
5359 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5360 window_box_text_cols. delete_all_subwindows now takes a
5361 Lisp_Object as argument.
abde8f8c 5362
640c8776
SM
5363 * indent.c (compute_motion, Fcompute_motion):
5364 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5365
fa8a67e6
MR
5366 * frame.c (delete_frame): Call delete_all_subwindows with root
5367 window as argument.
5368
a54e3482
DC
53692011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5370
5371 * fns.c (Fputhash): Document return value.
5372
60002bf5
CY
53732011-06-06 Chong Yidong <cyd@stupidchicken.com>
5374
5375 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5376
0c671da6 53772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5378
b862a52a 5379 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5380
be44ca6c
PE
5381 Check for overflow when converting integer to cons and back.
5382 * charset.c (Fdefine_charset_internal, Fdecode_char):
5383 Use cons_to_unsigned to catch overflow.
5384 (Fencode_char): Use INTEGER_TO_CONS.
5385 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5386 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5387 * data.c (long_to_cons, cons_to_long): Remove.
5388 (cons_to_unsigned, cons_to_signed): New functions.
5389 These signal an error for invalid or out-of-range values.
5390 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5391 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5392 * font.c (Ffont_variation_glyphs):
5393 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5394 * lisp.h: Include <intprops.h>.
5395 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5396 (cons_to_signed, cons_to_unsigned): New decls.
5397 (long_to_cons, cons_to_long): Remove decls.
5398 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5399 (Fprimitive_undo): Use CONS_TO_INTEGER.
5400 * xfns.c (Fx_window_property): Likewise.
5401 * xselect.c: Include <limits.h>.
5402 (x_own_selection, selection_data_to_lisp_data):
5403 Use INTEGER_TO_CONS.
5404 (x_handle_selection_request, x_handle_selection_clear)
5405 (x_get_foreign_selection, Fx_disown_selection_internal)
5406 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5407 (lisp_data_to_selection_data): Use cons_to_unsigned.
5408 (x_fill_property_data): Use cons_to_signed.
5409 Report values out of range.
5410
d1f3d2af
PE
5411 Check for buffer and string overflow more precisely.
5412 * buffer.h (BUF_BYTES_MAX): New macro.
5413 * lisp.h (STRING_BYTES_MAX): New macro.
5414 * alloc.c (Fmake_string):
5415 * character.c (string_escape_byte8):
5416 * coding.c (coding_alloc_by_realloc):
5417 * doprnt.c (doprnt):
5418 * editfns.c (Fformat):
5419 * eval.c (verror):
5420 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5421 since they may not be the same number.
5422 * editfns.c (Finsert_char):
5423 * fileio.c (Finsert_file_contents):
5424 Likewise for BUF_BYTES_MAX.
5425
dd52fcea
PE
5426 * image.c: Use ptrdiff_t, not int, for sizes.
5427 (slurp_file): Switch from int to ptrdiff_t.
5428 All uses changed.
5429 (slurp_file): Check that file size fits in both size_t (for
5430 malloc) and ptrdiff_t (for sanity and safety).
5431
7f9bbdbb
PE
5432 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5433 if b->modtime has its maximal value.
5434
dfe18f82
PE
5435 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5436
84acfcf0
PE
5437 Don't assume time_t can fit into int.
5438 * buffer.h (struct buffer.modtime): Now time_t, not int.
5439 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5440 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5441
ccd9a01a
PE
5442 Minor fixes for signed vs unsigned integers.
5443 * character.h (MAYBE_UNIFY_CHAR):
5444 * charset.c (maybe_unify_char):
5445 * keyboard.c (read_char, reorder_modifiers):
5446 XINT -> XFASTINT, since the integer must be nonnegative.
5447 * ftfont.c (ftfont_spec_pattern):
5448 * keymap.c (access_keymap, silly_event_symbol_error):
5449 XUINT -> XFASTINT, since the integer must be nonnegative.
5450 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5451 since it makes no difference and we prefer signed.
5452 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5453 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5454 nonnegative.
5455
d6d100dd
SM
54562011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5457
5458 * window.h (Fwindow_frame): Declare.
5459
2b6148e4
PE
54602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5461
5462 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5463 (SPARE_MEMORY): Always define.
5464 (LARGE_REQUEST): Remove.
5465 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5466
f230ecc9
MR
54672011-06-06 Martin Rudalics <rudalics@gmx.at>
5468
727e958e
MR
5469 * lisp.h: Move EXFUNS for Fframe_root_window,
5470 Fframe_first_window and Fset_frame_selected_window to window.h.
5471
5472 * window.h: Move EXFUNS for Fframe_root_window,
5473 Fframe_first_window and Fset_frame_selected_window here from
5474 lisp.h.
5475
5476 * frame.c (Fwindow_frame, Fframe_first_window)
5477 (Fframe_root_window, Fframe_selected_window)
5478 (Fset_frame_selected_window): Move to window.c.
5479 (Factive_minibuffer_window): Move to minibuf.c.
5480 (Fother_visible_frames_p): New function.
5481
5482 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5483
f230ecc9
MR
5484 * window.c (decode_window, decode_any_window): Move up in code.
5485 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5486 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5487 (Fwindow_buffer): Move up and rewrite doc-string.
5488 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5489 (Fwindow_prev): New functions.
727e958e
MR
5490 (Fwindow_frame): Move here from frame.c. Accept any window as
5491 argument.
5492 (Fframe_root_window, Fframe_first_window)
5493 (Fframe_selected_window): Move here from frame.c. Accept frame
5494 or arbitrary window as argument. Update doc-strings.
5495 (Fminibuffer_window): Move up in code.
5496 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5497 (Fset_frame_selected_window): Move here from frame.c.
5498 Marginal rewrite.
727e958e
MR
5499 (Fselected_window, select_window, Fselect_window): Move up in
5500 code. Minor doc-string fixes.
f230ecc9 5501
4d09bcf6
PE
55022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5503
5504 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5505 Do not assume that spare memory exists; that assumption is valid
5506 only if SYSTEM_MALLOC.
5507 (LARGE_REQUEST): New macro, so that the issue of large requests
5508 is separated from the issue of spare memory.
5509
810928a2
AS
55102011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5511
172418ad
AS
5512 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5513 format. (Bug#8806)
5514
43f862f7
AS
5515 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5516
810928a2
AS
5517 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5518 before statements.
5519
a059fe24
JD
55202011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5521
5522 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5523
5524 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5525
5526 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5527 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5528
989bf368
JB
55292011-06-05 Juanma Barranquero <lekktu@gmail.com>
5530
5531 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5532
4b80f674
CY
55332011-06-04 Chong Yidong <cyd@stupidchicken.com>
5534
5535 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5536 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5537 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5538 New error handlers.
4b80f674
CY
5539 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5540 Obey Vx_select_enable_clipboard_manager. Catch errors in
5541 x_clipboard_manager_save (Bug#8779).
5542 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5543 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5544
99a33b77 55452011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5546
5547 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5548
99a33b77 55492011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5550
5551 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5552 in the current matrix if keep_current_p is non-zero.
5553
8264569d
EZ
55542011-06-04 Eli Zaretskii <eliz@gnu.org>
5555
5556 * bidi.c (bidi_level_of_next_char): Fix last change.
5557
57f97249
EZ
55582011-06-03 Eli Zaretskii <eliz@gnu.org>
5559
fec2107c 5560 Support bidi reordering of text covered by display properties.
57f97249 5561
fec2107c
EZ
5562 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5563 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5564 (bidi_cache_search, bidi_cache_iterator_state)
5565 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5566 (bidi_level_of_next_char, bidi_move_to_visually_next):
5567 Support character positions inside a run of characters covered by a
fec2107c
EZ
5568 display string.
5569 (bidi_paragraph_init, bidi_resolve_explicit_1)
5570 (bidi_level_of_next_char): Call bidi_fetch_char and
5571 bidi_fetch_char_advance instead of FETCH_CHAR and
5572 FETCH_CHAR_ADVANCE.
5573 (bidi_init_it): Initialize new members.
5574 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5575 definitions.
5576 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5577 instead of using explicit *_CHAR codes.
d6d100dd
SM
5578 (bidi_resolve_explicit, bidi_resolve_weak):
5579 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5580 bidirectional text is supported only in multibyte buffers.
5581 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5582 it to initialize the frame_window_p member of struct bidi_it.
5583 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5584 (bidi_resolve_explicit, bidi_resolve_weak)
5585 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5586 bidi_it->nchars is non-positive.
5587 (bidi_level_of_next_char): Don't try to lookup the cache for the
5588 next/previous character if nothing is cached there yet, or if we
5589 were just reseat()'ed to a new position.
c40e2fb2 5590
0e14fe90
EZ
5591 * xdisp.c (set_cursor_from_row): Set start and stop points
5592 according to the row's direction when priming the loop that looks
5593 for the glyph on which to display cursor.
5594 (single_display_spec_intangible_p): Function deleted.
5595 (display_prop_intangible_p): Reimplement to call
5596 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5597 Accept 3 additional arguments needed by handle_display_spec.
5598 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5599 values: lists, `(when COND...)' forms, etc.
5600 (single_display_spec_string_p): Support property values that are
5601 lists with the argument STRING its top-level element.
5602 (display_prop_string_p): Fix the condition for processing a
5603 property that is a list to be consistent with handle_display_spec.
fec2107c 5604 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5605 last portion of handle_display_prop.
5606 (compute_display_string_pos): Accept additional argument
5607 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5608 value of a `display' property is a "replacing spec".
5609 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5610 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5611 the display property, but just return a value indicating whether
5612 the display property will replace the characters it covers.
5613 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5614 frame_window_p members of struct bidi_it.
d6d100dd
SM
5615 (compute_display_string_pos, compute_display_string_end):
5616 New functions.
fec2107c
EZ
5617 (push_it): Accept second argument POSITION, where pop_it should
5618 jump to continue iteration.
5619 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5620
fec2107c
EZ
5621 * keyboard.c (adjust_point_for_property): Adjust the call to
5622 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5623
5624 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5625 (bidi_init_it): Update prototypes.
5626 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5627 (compute_display_string_pos, compute_display_string_end):
5628 Declare prototypes.
fec2107c
EZ
5629 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5630 EMACS_INT.
fc6f18ce 5631
40087514 56322011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5633
57f53182
PE
5634 Malloc failure behavior now depends on size of allocation.
5635 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5636 * lisp.h: Change signatures accordingly.
5637 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5638 All callers changed. (Bug#8762)
5639
5640 * gnutls.c: Use Emacs's memory allocators.
5641 Without this change, the gnutls library would invoke malloc etc.
5642 directly, which causes problems on non-SYNC_INPUT hosts, and which
5643 runs afoul of improving memory_full behavior. (Bug#8761)
5644 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5645 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5646 xfree instead of the default malloc, realloc, free.
5647 (Fgnutls_boot): No need to check for memory allocation failure,
5648 since xmalloc does that for us.
5649
ac32cd99 5650 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5651 * category.c (hash_get_category_set):
5652 * ccl.c (ccl_driver):
5653 * charset.c (Fdefine_charset_internal):
5654 * charset.h (struct charset.hash_index):
5655 * composite.c (get_composition_id, gstring_lookup_cache)
5656 (composition_gstring_put_cache):
5657 * composite.h (struct composition.hash_index):
5658 * dispextern.h (struct image.hash):
5659 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5660 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5661 (hashfn_equal, hashfn_user_defined, make_hash_table)
5662 (maybe_resize_hash_table, hash_lookup, hash_put)
5663 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5664 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5665 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5666 * image.c (make_image, search_image_cache, lookup_image)
5667 (xpm_put_color_table_h):
5668 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5669 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5670 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5671 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5672 * alloc.c (allocate_vectorlike):
5673 Check for overflow in vector size calculations.
5674 * ccl.c (ccl_driver):
5675 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5676 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5677 need to be updated by these changes.
40087514
PE
5678 * fns.c (make_hash_table, maybe_resize_hash_table):
5679 Check for integer overflow with large hash tables.
0de4bb68
PE
5680 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5681 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5682 (SXHASH_REDUCE): New macro.
5683 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5684 Use it instead of discarding useful hash info with large hash values.
5685 (sxhash_float): New function.
5686 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5687 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5688 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5689 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5690 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5691 Adjust signatures to match updated version of code.
5692 (consing_since_gc): Now EMACS_INT, since a single hash table can
5693 use more than INT_MAX bytes.
5694
698d32e2
DN
56952011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5696
5697 Make it possible to build with GCC-4.6+ -O2 -flto.
5698
5699 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5700
fd6fa53f
SM
57012011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5702
5703 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5704 Call minibuffer-inactive-mode.
5705
864db017
JB
57062011-05-31 Juanma Barranquero <lekktu@gmail.com>
5707
5708 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5709 Update dependencies.
5710
2ad0baf4
DN
57112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5712
5713 * data.c (init_data): Remove code for UTS, this system is not
5714 supported anymore.
5715
4fcc2638
DN
57162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5717
5718 Don't force ./temacs to start in terminal mode.
5719
5720 * frame.c (make_initial_frame): Initialize faces in all cases, not
5721 only when CANNOT_DUMP is defined.
5722 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5723
c56e0fd5
DN
57242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5725
5726 * dispnew.c (add_window_display_history): Use const for the string
5727 pointer. Remove declaration, not needed.
5728
333d54da 57292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5730
55d4c1b2 5731 Use 'inline', not 'INLINE'.
333d54da 5732 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5733 * alloc.c, fontset.c (INLINE): Remove.
5734 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5735 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5736 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5737 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5738 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5739
738db178
DN
57402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5741
5742 Make it possible to run ./temacs.
5743
5744 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5745 syms_of_callproc does the same thing. Remove test for
5746 "initialized", do it in the caller.
5747 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5748
620c53a6
SM
57492011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5750
5751 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5752 (read_minibuf): Use get_minibuffer.
5753 (syms_of_minibuf): Use DEFSYM.
5754 (Qmetadata): New var.
5755 * data.c (Qbuffer): Don't make it static.
5756 (syms_of_data): Use DEFSYM.
5757
e003a292
PE
57582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5759
5760 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5761 (CCL_CODE_MIN): New macro.
5762
ed008a6d
PE
57632011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5764
3687c2ef
PE
5765 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5766
ed008a6d
PE
5767 * eval.c (Qdebug): Now static.
5768 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5769 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5770 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5771
d66c4c7c
CY
57722011-05-29 Chong Yidong <cyd@stupidchicken.com>
5773
5774 * image.c: Various fixes to ImageMagick code comments.
5775 (Fimagemagick_types): Doc fix.
5776
5fbc2025
PE
57772011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5778
0196f88a
PE
5779 Minor fixes prompted by GCC 4.6.0 warnings.
5780
5781 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5782
5fbc2025
PE
5783 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5784 (x_clipboard_manager_save_all): Move extern decl to ...
5785 * xterm.h: ... here, so that it can be checked for consistency.
5786
1dd3c2d9
CY
57872011-05-29 Chong Yidong <cyd@stupidchicken.com>
5788
5789 * xselect.c (x_clipboard_manager_save_frame)
5790 (x_clipboard_manager_save_all): New functions.
5791 (Fx_clipboard_manager_save): Lisp function deleted.
5792
5793 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5794 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5795
5796 * xterm.h: Update prototype.
5797
5ba6571d
WX
57982011-05-28 William Xu <william.xwl@gmail.com>
5799
5800 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5801 exiting (Bug#8239).
5802
3eaff834
JM
58032011-05-28 Jim Meyering <meyering@redhat.com>
5804
e1900994 5805 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5806 * fns.c (to_uchar): Define.
5807 (crypto_hash_function): Use it to convert some newly-signed
5808 variables to unsigned, to avoid sign-extension bugs. For example,
5809 without this change, (md5 "truc") would evaluate to
5810 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5811 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5812 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5813
0f6990a7
PE
58142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5815
5816 Integer overflow fixes.
c8a9ca5a 5817
08686060
PE
5818 * dbusbind.c: Serial number integer overflow fixes.
5819 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5820 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5821 to hold a serial number that is too large for a fixnum.
5822 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5823 Check for serial numbers out of range. Decode any serial number
59568bf0 5824 that was so large that it became a float. (Bug#8722)
08686060 5825
2d1fc3c7
PE
5826 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5827 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5828 Use XFASTINT rather than XUINT when numbers are nonnegative.
5829 (xd_append_arg, Fdbus_method_return_internal):
5830 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5831 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5832 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5833 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5834 (Bug#8722)
2d1fc3c7 5835
c8a9ca5a
PE
5836 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5837
519e1d69
PE
5838 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5839
6df6ae42 5840 ccl: Add integer overflow checks.
30569699
PE
5841 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5842 (IN_INT_RANGE): New macros.
5843 (ccl_driver): Use them to check for integer overflow when
5844 decoding a CCL program. Many of the new checks are whether XINT (x)
5845 fits in int; it doesn't always, on 64-bit hosts. The new version
5846 doesn't catch all possible integer overflows, but it's an
847044ea 5847 improvement. (Bug#8719)
30569699 5848
c11285dc
PE
5849 * alloc.c (make_event_array): Use XINT, not XUINT.
5850 There's no need for unsigned here.
5851
fdccd48e
PE
5852 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5853 This follows up to the 2011-05-06 change that substituted uintptr_t
5854 for EMACS_INT. This case wasn't caught back then.
5855
37910ab2
PE
5856 Rework Fformat to avoid integer overflow issues.
5857 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5858 now (part of C89). Include <verify.h>.
5859 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5860 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5861 (Fformat): Avoid the prepass trying to compute sizes; it was only
5862 approximate and thus did not catch overflow reliably. Instead, walk
5863 through the format just once, formatting and computing sizes as we go,
5864 checking for integer overflow at every step, and allocating a larger
5865 buffer as needed. Keep track separately whether the format is
5866 multibyte. Keep only the most-recently calculated precision, rather
5867 than them all. Record whether each argument has been converted to
5868 string. Use EMACS_INT, not int, for byte and char and arg counts.
5869 Support field widths and precisions larger than INT_MAX. Avoid
5870 sprintf's undefined behavior with conversion specifications such as %#d
5871 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5872 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5873 formatting out-of-range floating point numbers with int
9173deec 5874 formats. (Bug#8668)
37910ab2 5875
2e6578fb
PE
5876 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5877
0ae6bdee
PE
5878 * data.c: Avoid integer truncation in expressions involving floats.
5879 * data.c: Include <intprops.h>.
5880 (arith_driver): When there's an integer overflow in an expression
5881 involving floating point, convert the integers to floating point
5882 so that the resulting value does not suffer from catastrophic
5883 integer truncation. For example, on a 64-bit host (* 4
5884 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5885 Do not rely on undefined behavior after integer overflow.
5886
de883a70
PE
5887 merge count_size_as_multibyte, parse_str_to_multibyte
5888 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5889 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5890 Check for integer overflow.
5891 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5892 since it's now a duplicate of the other. This is more of
5893 a character than a buffer op, so better that it's in character.c.
5894 * fns.c, print.c: Adjust to above changes.
5895
2ff916cb
PE
58962011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5897
5898 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5899
f1b54466
PE
59002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5901
fb1ac845
PE
5902 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5903 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5904 (x_clipboard_manager_save): Now static.
5905 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5906
f1b54466
PE
5907 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5908 (crypto_hash_function): Now static.
5909 Fix pointer signedness problems. Avoid unnecessary initializations.
5910
a9f737ee
CY
59112011-05-27 Chong Yidong <cyd@stupidchicken.com>
5912
5913 * termhooks.h (Vselection_alist): Make it terminal-local.
5914
5915 * terminal.c (create_terminal): Initialize it.
5916
5917 * xselect.c: Support for clipboard managers.
5918 (Vselection_alist): Move to termhooks.h as terminal-local var.
5919 (LOCAL_SELECTION): New macro.
5920 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5921 (symbol_to_x_atom): Remove gratuitous arg.
5922 (x_handle_selection_request, lisp_data_to_selection_data)
5923 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5924 (x_own_selection, x_get_local_selection, x_convert_selection):
5925 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5926 (some_frame_on_display): Delete unused function.
5927 (Fx_own_selection_internal, Fx_get_selection_internal)
5928 (Fx_disown_selection_internal, Fx_selection_owner_p)
5929 (Fx_selection_exists_p): New optional frame arg.
5930 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5931 (x_handle_selection_clear): Don't treat other terminals with the
5932 same keyboard specially. Use the terminal-local Vselection_alist.
5933 (x_clear_frame_selections): Use Frun_hook_with_args.
5934
5935 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5936
5937 * xterm.h: Add support for those atoms.
5938
e067f0c1
CY
59392011-05-26 Chong Yidong <cyd@stupidchicken.com>
5940
5941 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5942 (converted_selections, conversion_fail_tag): New global variables.
5943 (x_selection_request_lisp_error): Free the above.
5944 (x_get_local_selection): Remove unnecessary code.
5945 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5946 of converted selections stored in converted_selections.
5947 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5948 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5949 (x_convert_selection): New function.
5950 (x_handle_selection_event): Simplify.
5951 (x_get_foreign_selection): Don't ignore incoming requests while
5952 waiting for an answer; this will fail when we implement
5953 SAVE_TARGETS, and seems unnecessary anyway.
5954 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5955 (Vx_sent_selection_functions): Doc fix.
5956
0f4aebc0
LL
59572011-05-26 Leo Liu <sdl.web@gmail.com>
5958
5959 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5960
e61124cd
YM
59612011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5962
5963 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5964
5965 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5966 for fringe update if it has periodic bitmap.
ac389d0c 5967 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5968 and fringe_bitmap_periodic_p.
5969
5970 * fringe.c (get_fringe_bitmap_data): New function.
5971 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5972 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5973 row. Mark glyph row for fringe update if periodicity changed.
5974
5975 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5976 for fringe update unless it has periodic bitmap.
5977
f16d9837
KH
59782011-05-25 Kenichi Handa <handa@m17n.org>
5979
5980 * xdisp.c (get_next_display_element): Set correct it->face_id for
5981 a static composition.
5982
e1b90ef6
LL
59832011-05-24 Leo Liu <sdl.web@gmail.com>
5984
5985 * deps.mk (fns.o):
5986 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5987
5988 * fns.c (crypto_hash_function, Fsha1): New function.
5989 (Fmd5): Use crypto_hash_function.
5990 (syms_of_fns): Add Ssha1.
5991
7400048f
PE
59922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5993
5994 * gnutls.c: Remove unused macros.
5995 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5996 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5997 Remove macros that are defined and never used.
5998 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5999
abb71cf4
CY
60002011-05-22 Chong Yidong <cyd@stupidchicken.com>
6001
6002 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6003 (Fx_get_selection_internal): Minor cleanup.
6004 (Fx_own_selection_internal): Rename arguments for consistency with
6005 select.el.
6006
6307db39
PE
60072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6008
6009 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6010
f3d4e0a4
CY
60112011-05-22 Chong Yidong <cyd@stupidchicken.com>
6012
6013 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6014
4d8ade89
YM
60152011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6016
6017 * dispnew.c (scrolling_window): Don't exclude the case that the
6018 last enabled row in the desired matrix touches the bottom boundary.
6019
32078c8d
GM
60202011-05-21 Glenn Morris <rgm@gnu.org>
6021
6022 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6023 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6024 and add some more files.
32078c8d 6025
7285dc67
EZ
60262011-05-20 Eli Zaretskii <eliz@gnu.org>
6027
6028 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6029 report_file_error introduced by the change from 2011-05-07.
6030
89d1bd22
PE
60312011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6032
6033 * systime.h (Time): Define only if emacs is defined.
6034 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6035 where the include path doesn't have X11/X.h by default. See
6036 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6037
cd394be1 60382011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6039
6040 * composite.c (find_automatic_composition): Fix previous change.
6041
b9704ad9
GM
60422011-05-20 Glenn Morris <rgm@gnu.org>
6043
6044 * lisp.mk: New file, split from Makefile.in.
6045 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6046 (shortlisp): Remove.
6047 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6048
4a720484
GM
60492011-05-19 Glenn Morris <rgm@gnu.org>
6050
6051 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6052 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6053 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6054 (lisp): Set the order to that of loadup.el.
6055 (shortlisp): Make it a copy of $lisp.
6056 (SOME_MACHINE_LISP): Remove.
6057 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6058 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6059
a28d4396
KH
60602011-05-18 Kenichi Handa <handa@m17n.org>
6061
6062 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6063 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6064 (find_automatic_composition): Mostly rewrite for efficiency.
6065
a2b1fa8e
JB
60662011-05-18 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * makefile.w32-in: Update dependencies.
6069
8e1f5610
CS
60702011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6071
6072 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6073 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6074
7025ee00 60752011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6076
cdfa6eab
PE
6077 Fix some integer overflow issues, such as string length overflow.
6078
06d6db33
PE
6079 * insdel.c (count_size_as_multibyte): Check for string overflow.
6080
2b4560a8
PE
6081 * character.c (lisp_string_width): Check for string overflow.
6082 Use EMACS_INT, not int, for string indexes and lengths; in
6083 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6084 the resulting string length overflows an EMACS_INT; instead,
6085 report a string overflow if no precision given. When checking for
6086 precision exhaustion, use a check that cannot possibly have
6087 integer overflow. (Bug#8675)
6088 * character.h (lisp_string_width): Adjust to new signature.
6089
cb93f9be
PE
6090 * alloc.c (string_overflow): New function.
6091 (Fmake_string): Use it. This doesn't change behavior, but saves
6092 a few bytes and will simplify future changes.
6093 * character.c (string_escape_byte8): Likewise.
6094 * lisp.h (string_overflow): New decl.
6095
1a1f3366
PE
6096 Fixups, following up to the user-interface timestamp change.
6097 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6098 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6099 * msdos.c (mouse_get_pos): Likewise.
6100 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6101 * w32gui.h (Time): Define by including "systime.h" rather than by
6102 declaring it ourselves. (Bug#8664)
6103
d4e3e4d3
PE
6104 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6105 * image.c (clear_image_cache): Likewise.
6106
f6a24d19
PE
6107 * term.c (term_mouse_position): Don't assume time_t wraparound.
6108
08dc5ae6
PE
6109 Be more systematic about user-interface timestamps.
6110 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6111 and sometimes 'EMACS_UINT', to represent these timestamps.
6112 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6113 This makes the code easier to follow, and makes it easier to catch
6114 integer overflow bugs such as Bug#8664.
6115 * frame.c (Fmouse_position, Fmouse_pixel_position):
6116 Use Time, not unsigned long, for user-interface timestamps.
6117 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6118 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6119 * keyboard.h (last_event_timestamp): Likewise.
6120 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6121 * menu.h (xmenu_show): Likewise.
6122 * term.c (term_mouse_position): Likewise.
6123 * termhooks.h (struct input_event.timestamp): Likewise.
6124 (struct terminal.mouse_position_hook): Likewise.
6125 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6126 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6127 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6128 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6129 what it was before.
6130 * menu.h, termhooks.h: Include "systime.h", for Time.
6131
8e55734a
PE
6132 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6133 Don't assume that the difference between two unsigned long values
6134 can fit into an integer. At this point, we know button_down_time
6135 <= event->timestamp, so the difference must be nonnegative, so
6136 there's no need to cast the result if double-click-time is
6137 nonnegative, as it should be; check that it's nonnegative, just in
6138 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6139 apart (about 25 days). (Bug#8664)
8e55734a 6140
841f1b75 6141 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6142 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6143
3e26f69c
PE
6144 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6145 that always fit in int. Use a sentinel instead of a counter, to
6146 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6147 * frame.h (struct frame): Use int for menu_bar_items_used
6148 instead of EMACS_INT, since it always fits in int.
3e26f69c 6149
5cc152c0
PE
6150 * menu.c (grow_menu_items): Check for int overflow.
6151
d89eb65e
PE
6152 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6153
5235bd3e
PE
6154 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6155 Before, the code was not consistent. These values cannot exceed
6156 2**31 - 1 so there's no need to make them unsigned.
6157 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6158 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6159 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6160 as modifiers.
6161 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6162
bc827e23
PE
6163 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6164 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6165 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6166 presumably because the widths might not match.
6167
78eb494e
PE
6168 * window.c (size_window): Avoid needless test at loop start.
6169
04f2d78b
CB
61702011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6171
6172 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6173
d2fc7e3d 61742011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6175
6176 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6177
d2fc7e3d 61782011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6179
6180 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6181 `width' to `bar_area_x' and `bar_area_width', respectively.
6182 (x_scroll_run): Take account of fringe background extension.
6183
04f2d78b
CB
6184 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6185 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6186 `bar_area_width', respectively.
6187 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6188 background extension.
6189
79b70037
GM
61902011-05-10 Jim Meyering <meyering@redhat.com>
6191
6192 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6193
2f142cc5
JB
61942011-05-10 Juanma Barranquero <lekktu@gmail.com>
6195
6196 * image.c (Finit_image_library): Return t for built-in image types,
6197 like pbm and xbm. (Bug#8640)
6198
57679c86
AS
61992011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6200
6201 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6202
888c9e86
EZ
62032011-05-07 Eli Zaretskii <eliz@gnu.org>
6204
b0512a1d
EZ
6205 * w32console.c (Fset_screen_color): Doc fix.
6206 (Fget_screen_color): New function.
6207 (syms_of_ntterm): Defsubr it.
6208
7285dc67
EZ
6209 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6210 unlink the temporary file if Fcall_process didn't create it in the
6211 first place.
6212 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6213 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6214 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6215 cue to call_process_cleanup not to close that handle.
6216
4d3fcc8e
BK
62172011-05-07 Ben Key <bkey76@gmail.com>
6218
6219 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6220 one of two shell specific rules, either bootstrap-temacs-CMD or
6221 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6222 to the previous implementation of the bootstrap-temacs rule.
6223 The bootstrap-temacs-CMD rule is similar to the previous
6224 implementation of the bootstrap-temacs rule except that it
6225 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6226 variable.
6227
6228 These changes, along with some changes to nt/configure.bat,
6229 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6230 earlier fix to add support for --cflags and --ldflags options
6231 that include quotes so that it works whether make uses cmd or
6232 sh as the shell.
6233
b4289b64
MA
62342011-05-06 Michael Albinus <michael.albinus@gmx.de>
6235
6236 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6237 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6238 is a constant.
6239 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6240 a string. Handle both cases.
6241 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6242 (Fdbus_register_method): Use Qinvalid_function.
6243
af4c0e28
JB
62442011-05-06 Juanma Barranquero <lekktu@gmail.com>
6245
6246 * makefile.w32-in: Update dependencies.
6247 (LISP_H): Add inttypes.h and stdin.h.
6248 (PROCESS_H): Add unistd.h.
6249
c51453d9
EZ
62502011-05-06 Eli Zaretskii <eliz@gnu.org>
6251
6252 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6253 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6254
8ff0ac3c 62552011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6256
4c4b566b
PE
6257 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6258
aab2b9b5
PE
6259 * term.c (vfatal): Remove stray call to va_end.
6260 It's not needed and the C Standard doesn't allow it here anyway.
6261
c378da0b
PE
6262 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6263 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6264
288b08c7
PE
6265 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6266 bytes.
6267
e3601888
PE
6268 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6269
db6c0e74
PE
6270 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6271
dd5963ea
PE
6272 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6273
88c9450f
PE
6274 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6275
2f9442b8
PE
6276 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6277
c032b5f8
PE
6278 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6279 * charset.c (Fdefine_charset_internal): Don't initialize
6280 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6281 32-bit int (Bug#8600).
a108c10b
PE
6282
6283 * lread.c (read_integer): Be more consistent with string-to-number.
6284 Use string_to_number to do the actual conversion; this avoids
6285 rounding errors and fixes some other screwups. Without this fix,
6286 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6287 (digit_to_number): Move earlier, for benefit of read_integer.
6288 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6289 not a digit in any supported base. (Bug#8602)
a108c10b 6290
ad5f9eea
PE
6291 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6292
aec1708a
PE
6293 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6294 to match comment at start of function. This also removes a
6295 GCC warning about overflow in a 32+64-bit port.
6296
47be4ab5
PE
6297 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6298
371cac43
PE
6299 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6300 Reported by Stefan Monnier in
6301 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6302 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6303 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6304
d01a7826
PE
6305 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6306 (EMACS_UINTPTR): Likewise, with uintptr_t.
6307
7fd47d5c
PE
6308 * lisp.h: Prefer 64-bit EMACS_INT if available.
6309 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6310 on 32-bit hosts that have 64-bit int, so that they can access
6311 large files.
122b0c86
PE
6312 However, temporarily disable this change unless the temporary
6313 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6314
8727937b
PE
6315 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6316
8ac068ac
PE
6317 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6318 This removes an assumption that EMACS_INT and long are the same
6319 width as pointers. The assumption is true for Emacs porting targets
6320 now, but we want to make other targets possible.
6321 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6322 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6323 In the rest of the code, change types of integers that hold casted
6324 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6325 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6326 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6327 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6328 No need to cast type when ORing.
6329 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6330 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6331 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6332 assume EMACS_INT is the same width as char *.
6333 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6334 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6335 Remove no-longer-needed casts.
6336 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6337 (xg_tool_bar_help_callback, xg_make_tool_item):
6338 Use EMACS_INTPTR to hold an integer
6339 that will be cast to void *; this can avoid a GCC warning
6340 if EMACS_INT is not the same width as void *.
6341 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6342 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6343 (current_message_1, set_message_1):
6344 Use a local to convert to proper width without a cast.
6345 * xmenu.c (dialog_selection_callback): Likewise.
6346
ede49d71
PE
6347 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6348 Also, don't assume VALBITS / RAND_BITS is less than 5,
6349 and don't rely on undefined behavior when shifting a 1 left into
6350 the sign bit.
6351 * lisp.h (get_random): Change signature to match.
6352
2f30ecd0
PE
6353 * lread.c (hash_string): Use size_t, not int, for hash computation.
6354 Normally we prefer signed values; but hashing is special, because
6355 it's better to use unsigned division on hash table sizes so that
6356 the remainder is nonnegative. Also, size_t is the natural width
6357 for hashing into memory. The previous code used 'int', which doesn't
6358 retain enough info to hash well into very large tables.
6359 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6360
2a866e7b
PE
6361 * dbusbind.c: Don't possibly lose pointer info when converting.
6362 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6363 Use XPNTR rather than XHASH, so that the high-order bits of
6364 the pointer aren't lost when converting through void *.
6365
51639eac
PE
6366 * eval.c (Fautoload): Don't double-shift a pointer.
6367
92394119
PE
6368 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6369
dbdb9a7c
JB
63702011-05-06 Juanma Barranquero <lekktu@gmail.com>
6371
6372 * gnutls.c (DEF_GNUTLS_FN):
6373 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6374
db7a0b4f
AS
63752011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6376
6377 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6378 marker. (Bug#8610)
6379
cd394be1 63802011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6381
6382 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6383 New version that can reserve upto 2GB of heap space.
6384
f7ff1b0f 63852011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6386
6387 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6388
639c109b
TZ
63892011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6390
6391 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6392 `gnutls_certificate_set_x509_key_file'.
6393
d2127135
JB
63942011-05-05 Juanma Barranquero <lekktu@gmail.com>
6395
6396 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6397 Update dependencies.
6398
e968f4f3
JB
63992011-05-04 Juanma Barranquero <lekktu@gmail.com>
6400
6401 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6402 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6403 Remove unused parameter `fildes'.
6404 * process.c (read_process_output, send_process): Don't pass it.
6405
84d358f0
JB
64062011-05-04 Juanma Barranquero <lekktu@gmail.com>
6407
6408 Fix previous change: the library cache is defined in w32.c.
6409 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6410 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6411
0898ca10
JB
64122011-05-04 Juanma Barranquero <lekktu@gmail.com>
6413
6414 Implement dynamic loading of GnuTLS on Windows.
6415
6416 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6417 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6418 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6419 Declare.
6420
6421 * gnutls.c (Qgnutls_dll): Define.
6422 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6423 (gnutls_*): Declare function pointers.
6424 (init_gnutls_functions): New function to initialize function pointers.
6425 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6426 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6427 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6428 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6429 (emacs_gnutls_write, emacs_gnutls_read)
6430 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6431 (Fgnutls_available_p): New function.
6432 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6433 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6434 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6435
6436 * image.c: Include w32.h.
6437 (Vimage_type_cache): Delete.
6438 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6439 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6440 (w32_delayed_load): Move to w32.c.
6441
6442 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6443
6444 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6445 (w32_delayed_load): Move from image.c. When loading a library, record
6446 its filename in the :loaded-from property of the library id.
6447 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6448 Initialize and staticpro them.
6449 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6450
6451 * process.c: Include lisp.h before w32.h, not after.
6452 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6453 instead of gnutls_record_check_pending.
6454
6455 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6456
ff4de4aa
TZ
64572011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6458
6459 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6460 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6461 as passed in.
6462
abe95abb
JD
64632011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6464
6465 * xterm.c (x_set_frame_alpha): Do not set property on anything
6466 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6467
e16e55d4
JB
64682011-05-02 Juanma Barranquero <lekktu@gmail.com>
6469
6470 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6471
bafcf6a5
JB
64722011-05-02 Juanma Barranquero <lekktu@gmail.com>
6473
6474 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6475 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6476 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6477 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6478 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6479 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6480 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6481 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6482 (Qgnutls_bootprop_callbacks_verify): Make static.
6483
e7a6747f
AS
64842011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6485
19ed11ba
AS
6486 * callproc.c: Indentation fixup.
6487
e7a6747f 6488 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6489 (wait_for_termination, interruptible_wait_for_termination):
6490 Move after wait_for_termination_1.
e7a6747f 6491
1ef14cb4
LMI
64922011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6493
6494 * sysdep.c (interruptible_wait_for_termination): New function
6495 which is like wait_for_termination, but allows keyboard
6496 interruptions.
6497
6498 * callproc.c (Fcall_process): Add (:file "file") as an option for
6499 the STDOUT buffer.
6500 (Fcall_process_region): Ditto.
6501
330d880c
EZ
65022011-04-30 Eli Zaretskii <eliz@gnu.org>
6503
8db90b73
EZ
6504 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6505 rather than `XVECTOR (FOO)->size'.
6506
330d880c
EZ
6507 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6508 inttypes.h, as a gnulib replacement is used if it not available in
6509 system headers.
6510
15cbd324
EZ
65112011-04-21 Eli Zaretskii <eliz@gnu.org>
6512
6513 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6514 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6515 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6516
6517 * coding.c (coding_alloc_by_realloc): Error out if destination
6518 will grow beyond MOST_POSITIVE_FIXNUM.
6519 (decode_coding_emacs_mule): Abort if there isn't enough place in
6520 charbuf for the composition carryover bytes. Reserve an extra
6521 space for up to 2 characters produced in a loop.
6522 (decode_coding_iso_2022): Abort if there isn't enough place in
6523 charbuf for the composition carryover bytes.
6524
65252011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6526
ae940cca
EZ
6527 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6528 aborting when %lld or %lll format is passed.
6529 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6530 %llo or %llx format is passed. (Bug#8545)
6531
03ab8921
EZ
6532 * window.c (window_scroll_line_based): Use a marker instead of
6533 simple variables to record original value of point. (Bug#7952)
6534
afda1437
EZ
6535 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6536 produced by %s or %c overflows available buffer space. (Bug#8545)
6537
f76dee0c
PE
65382011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6539
6540 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6541 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6542
fdc5744d
JB
65432011-04-28 Juanma Barranquero <lekktu@gmail.com>
6544
6545 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6546
638f053a
JB
65472011-04-28 Juanma Barranquero <lekktu@gmail.com>
6548
6549 * keyboard.c (Qdelayed_warnings_hook): Define.
6550 (command_loop_1): Run `delayed-warnings-hook'
6551 if Vdelayed_warnings_list is non-nil.
6552 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6553 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6554
d178f871
EZ
65552011-04-28 Eli Zaretskii <eliz@gnu.org>
6556
6557 * doprnt.c (doprnt): Don't return value smaller than the buffer
6558 size if the message was truncated. (Bug#8545).
6559
b124fd93
JB
65602011-04-28 Juanma Barranquero <lekktu@gmail.com>
6561
6562 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6563 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6564
e810457d
PE
65652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6566
6567 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6568
ea51cceb
JB
65692011-04-27 Juanma Barranquero <lekktu@gmail.com>
6570
6571 * makefile.w32-in: Update dependencies.
6572
94dcfacf
EZ
65732011-04-27 Eli Zaretskii <eliz@gnu.org>
6574
6575 Improve `doprnt' and its usage. (Bug#8545)
6576 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6577 `format_end'. Remove support for %l as a conversion specifier.
6578 Don't use xrealloc. Improve diagnostics when the %l size modifier
6579 is used. Update the commentary.
6580
6581 * eval.c (verror): Simplify calculation of size_t.
6582
6583 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6584 messages.
6585
f61f41d7
PE
65862011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6587
6588 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6589 change.
6590
96fb4434
PE
65912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6592
6593 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6594 This makes this file independent of the recent pseudovector change.
6595
671875da 65962011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6597
69e9b5a3
PE
6598 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6599
b5f869a7 6600 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6601 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6602 Remove unused local.
c8926152 6603 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6604
841a1577 6605 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6606 GCC 4.6.0 optimizes based on type-based alias analysis.
6607 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6608 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6609 != &v->size, and therefore "v->size = 1; b->size = 2; return
6610 v->size;" must therefore return 1. This assumption is incorrect
6611 for Emacs, since it type-puns struct Lisp_Vector * with many other
6612 types. To fix this problem, this patch adds a new type struct
f904488f 6613 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6614 and pseudovectors, and helps optimizing compilers not get fooled
6615 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6616 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6617 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6618 the size member.
eab3844f
PE
6619 (XSETPVECTYPE): Rewrite in terms of new macro.
6620 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6621 This is a bit clearer, and further avoids the possibility of
6622 undesirable aliasing.
6623 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6624 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6625 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6626 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6627 (ASIZE): Now uses header.size rather than size.
6628 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6629 to avoid the hassle of writing XVECTOR (foo)->header.size.
6630 (struct vectorlike_header): New type.
eab3844f
PE
6631 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6632 object, to help avoid aliasing.
6633 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6634 (SUBRP): Likewise, since Lisp_Subr is a special case.
6635 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6636 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6637 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6638 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6639 changed to be "header.size" and "header.next".
6640 * buffer.h (struct buffer): Likewise.
6641 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6642 * frame.h (struct frame): Likewise.
6643 * process.h (struct Lisp_Process): Likewise.
6644 * termhooks.h (struct terminal): Likewise.
6645 * window.c (struct save_window_data, struct saved_window): Likewise.
6646 * window.h (struct window): Likewise.
6647 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6648 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6649 * buffer.c (init_buffer_once): Likewise.
6650 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6651 special case.
6652 * process.c (Fformat_network_address): Use local var for size,
6653 for brevity.
6654
0df1eac5
PE
6655 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6656
847ab9d1 6657 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6658 * data.c (atof): Remove decl; no longer used or needed.
6659 (digit_to_number): Move to lread.c.
6660 (Fstring_to_number): Use new string_to_number function, to be
6661 consistent with how the Lisp reader treats infinities and NaNs.
6662 Do not assume that floating-point numbers represent EMACS_INT
6663 without losing information; this is not true on most 64-bit hosts.
6664 Avoid double-rounding errors, by insisting on integers when
6665 parsing non-base-10 numbers, as the documentation specifies.
6666 * lisp.h (string_to_number): New decl, replacing ...
6667 (isfloat_string): Remove.
bc0a5c13 6668 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6669 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6670 appears to have been a coding error. Similarly, do not accept
6671 strings like +-1e0 as floating point numbers. Do not report
6672 overflow for integer overflows unless the base is not 10 which
6673 means we have no simple and reliable way to continue.
6674 Break out the floating-point parsing into a new
6675 function string_to_number, so that Fstring_to_number parses
6676 floating point numbers consistently with the Lisp reader.
04f2d78b 6677 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6678 (E_CHAR, EXP_INT): Remove, replacing with ...
6679 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6680 (string_to_number): New function, replacing isfloat_string.
6681 This function checks for valid syntax and produces the resulting
6682 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6683 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6684 so that overflow for non-base-10 numbers is reported only when
6685 there's no portable and simple way to convert to floating point.
452f4150 6686
67769ffc
PE
6687 * textprop.c (set_text_properties_1): Rewrite for clarity,
6688 and to avoid GCC warning about integer overflow.
6689
c20db43f
PE
6690 * intervals.h (struct interval): Use EMACS_INT for members
6691 where EMACS_UINT might cause problems. See
6692 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6693 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6694 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6695 All uses changed.
37aa2f85
PE
6696 (offset_intervals): Tell GCC not to worry about length overflow
6697 when negating a negative length.
c20db43f 6698
2538aa2f
PE
6699 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6700 (overrun_check_free): Likewise.
6701
f2d3008d
PE
6702 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6703 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6704 word size.
6705
ec8df744
PE
6706 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6707 (gnutls_make_error): Rename local to avoid shadowing.
6708 (gnutls_emacs_global_deinit): ifdef out; not used.
6709 (Fgnutls_boot): Use const for pointer to readonly storage.
6710 Comment out unused local. Fix pointer signedness problems.
6711
640ee02d
PE
6712 * lread.c (openp): Don't stuff size_t into an 'int'.
6713 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6714 about possible signed overflow.
6715
6048fb2a
PE
6716 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6717 (GDK_KEY_g): Don't define if already defined.
6718 (xg_prepare_tooltip): Avoid pointer signedness problem.
6719 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6720
fa3c87e1
PE
6721 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6722 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6723
2172544b
PE
6724 * xfns.c (Fx_window_property): Simplify a bit,
6725 to make a bit faster and to avoid GCC 4.6.0 warning.
6726 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6727
9b821a21
PE
6728 * fns.c (internal_equal): Don't assume size_t fits in int.
6729
3c616cfa
PE
6730 * alloc.c (compact_small_strings): Tighten assertion a little.
6731
c2982e87
PE
6732 Replace pEd with more-general pI, and fix some printf arg casts.
6733 * lisp.h (pI): New macro, generalizing old pEd macro to other
6734 conversion specifiers. For example, use "...%"pI"d..." rather
6735 than "...%"pEd"...".
6736 (pEd): Remove. All uses replaced with similar uses of pI.
6737 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6738 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6739 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6740 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6741 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6742 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6743 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6744 64-bit hosts.
6745 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6746 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6747 * print.c (safe_debug_print, print_object): Likewise.
6748 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6749 to int.
6f04d126
PE
6750 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6751 avoiding the 0 flag, which is not portable.
c2982e87
PE
6752 * process.c (Fmake_network_process): Use pI to avoid cast.
6753 * region-cache.c (pp_cache): Likewise.
6754 * xdisp.c (decode_mode_spec): Likewise.
6755 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6756 behavior on 64-bit hosts with printf arg.
6f04d126 6757 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6758 (x_stop_queuing_selection_requests): Likewise.
6759 (x_get_window_property): Don't truncate byte count to an 'int'
6760 when tracing.
0b432f21 6761
5e073ec7
PE
6762 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6763 here, since it parses constructs like leading '-' and spaces,
6764 which are not wanted; and it overflows with large numbers.
6765 Instead, simply match F[0-9]+, which is what is wanted anyway.
6766
36372bf9
PE
6767 * alloc.c: Remove unportable assumptions about struct layout.
6768 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6769 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6770 (allocate_vectorlike, make_pure_vector): Use the new macros,
6771 plus offsetof, to remove unportable assumptions about struct layout.
6772 These assumptions hold on all porting targets that I know of, but
6773 they are not guaranteed, they're easy to remove, and removing them
6774 makes further changes easier.
6775
0b432f21
PE
6776 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6777 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6778 (string_overrun_cookie): Now const. Use initializers that
6779 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6780 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6781 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6782 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6783 multiple of sizeof (EMACS_INT); it need not be, if
6784 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6785 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6786
895009e1
JB
67872011-04-26 Juanma Barranquero <lekktu@gmail.com>
6788
6789 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6790
6a7a1b0b
TZ
67912011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6792
6793 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6794 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6795 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6796
841a1577 67972011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6798
6799 * lisp.h (Qdebug): List symbol.
895009e1 6800 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6801 * keyboard.c (debug-on-event): New variable.
6802 (handle_user_signal): Break into debugger when debug-on-event
6803 matches the current signal symbol.
6804
f2d3ba6f
DN
68052011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6806
6807 * alloc.c (check_sblock, check_string_bytes)
6808 (check_string_free_list): Convert to standard C.
6809
42ce4c63
TZ
68102011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6811
6812 * w32.c (emacs_gnutls_push): Fix typo.
6813
825cd63c
EZ
68142011-04-25 Eli Zaretskii <eliz@gnu.org>
6815
fb11d64d
EZ
6816 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6817 "cast to pointer from integer of different size".
6818
825cd63c
EZ
6819 Improve doprnt and its use in verror. (Bug#8545)
6820 * doprnt.c (doprnt): Document the set of format control sequences
6821 supported by the function. Use SAFE_ALLOCA instead of always
6822 using `alloca'.
6823
6824 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6825 is one byte too soon. Don't use xrealloc; instead xfree and
6826 xmalloc anew.
6827
e061a11b
TZ
68282011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6829
6830 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6831 callbacks stage.
6832
6833 * gnutls.c: Renamed global_initialized to
6834 gnutls_global_initialized. Added internals for the
6835 :verify-hostname-error, :verify-error, and :verify-flags
6836 parameters of `gnutls-boot' and documented those parameters in the
6837 docstring. Start callback support.
9173deec
JB
6838 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6839 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6840 on error. Return error code.
e061a11b
TZ
6841 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6842 (emacs_gnutls_read): Likewise.
6843 (Fgnutls_boot): Return handshake error code.
6844 (emacs_gnutls_handle_error): New function.
6845 (wsaerror_to_errno): Likewise.
6846
6847 * w32.h (emacs_gnutls_pull): Add prototype.
6848 (emacs_gnutls_push): Likewise.
6849
6850 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6851 (emacs_gnutls_push): Likewise.
6852
68532011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6854
6855 * process.c (wait_reading_process_output): Check if GnuTLS
6856 buffered some data internally if no FDs are set for TLS
6857 connections.
6858
6859 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6860 (LIBS): Link to USER_LIBS.
6861 ($(BLD)/gnutls.$(0)): New target.
6862
fa6996bc
EZ
68632011-04-24 Eli Zaretskii <eliz@gnu.org>
6864
eb35682e
EZ
6865 * xdisp.c (handle_single_display_spec): Rename the
6866 display_replaced_before_p argument into display_replaced_p, to
6867 make it consistent with the commentary. Fix typos in the
6868 commentary.
6869
e2ad650c
EZ
6870 * textprop.c (syms_of_textprop): Remove dead code.
6871 (copy_text_properties): Delete obsolete commentary about an
6872 interface that was deleted long ago. Fix typos in the description
6873 of arguments.
6874
1b2de274
EZ
6875 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6876 to changes in oldXMenu/XMenu.h from 2011-04-16.
6877 <menu_help_message, prev_menu_help_message>: Constify.
6878 (IT_menu_make_room): menu->help_text is now `const char **';
6879 adjust.
6880
6881 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6882 to changes in oldXMenu/XMenu.h from 2011-04-16.
6883 (struct XMenu): Declare `help_text' `const char **'.
6884
6885 * xfaces.c <Qunspecified>: Make extern again.
6886
6887 * syntax.c: Include sys/types.h before including regex.h, as
6888 required by Posix.
6889
762b15be
EZ
6890 * doc.c (get_doc_string): Improve the format passed to `error'.
6891
6892 * doprnt.c (doprnt): Improve commentary.
6893
6894 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6895
6896 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6897 them with etags.
6898
f1052e5d
EZ
6899 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6900 changes in globals.h immediately force recompilation.
762b15be
EZ
6901 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6902 $(CURDIR)/s/ms-w32.h.
6903 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6904
fa6996bc
EZ
6905 * character.c (Fchar_direction): Function deleted.
6906 (syms_of_character): Don't defsubr it.
6907 <char-direction-table>: Deleted.
6908
e6c3da20
EZ
69092011-04-23 Eli Zaretskii <eliz@gnu.org>
6910
6911 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6912 * doprnt.c: Include limits.h.
6913 (SIZE_MAX): New macro.
04f2d78b
CB
6914 (doprnt): Return a size_t value. 2nd arg is now size_t.
6915 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6916 Improve overflow protection. Support `l' modifier for integer
6917 conversions. Support %l conversion. Don't assume an EMACS_INT
6918 argument for integer conversions and for %c.
6919
6920 * lisp.h (doprnt): Restore prototype.
6921
6922 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6923 $(SRC)/character.h.
6924
6925 * Makefile.in (base_obj): Add back doprnt.o.
6926
6927 * deps.mk (doprnt.o): Add back prerequisites.
6928 (callint.o): Depend on character.h.
6929
6930 * eval.c (internal_lisp_condition_case): Include the handler
6931 representation in the error message.
6932 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6933 when breaking from the loop.
6934
6935 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6936
6937 * callint.c (Fcall_interactively): When displaying error message
6938 about invalid control letter, pass the character's codepoint, not
6939 a pointer to its multibyte form. Improve display of the character
6940 in octal and display also its hex code.
6941
6942 * character.c (char_string): Use %x to display the (unsigned)
6943 codepoint of an invalid character, to avoid displaying a bogus
6944 negative value.
6945
6946 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6947 `error', not SYMBOL_NAME itself.
6948
6949 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6950 character arguments to `error'.
6951
6952 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6953 to `error' in error message about FINAL_CHAR argument. Make sure
6954 FINAL_CHAR is a character, and use %c when it is passed as
6955 argument to `error'.
6956
4ffd0d6b 69572011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6958
6959 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6960
6961 * w32.c: Include <time.h>.
6962 (sys_localtime): New function.
6963
4ffd0d6b 69642011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6965
6966 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6967
4ffd0d6b 6968 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6969
4ffd0d6b 69702011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6971
4ffd0d6b
GM
6972 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6973 zombies (Bug#8467).
aac0c6e3 6974
04c56954
EZ
69752011-04-19 Eli Zaretskii <eliz@gnu.org>
6976
6977 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6978 gl_state.e_property when gl_state.object is Qt.
6979
6980 * insdel.c (make_gap_larger): Remove limitation of buffer size
6981 to <= INT_MAX.
6982
16a43933
CY
69832011-04-18 Chong Yidong <cyd@stupidchicken.com>
6984
6985 * xdisp.c (lookup_glyphless_char_display)
6986 (produce_glyphless_glyph): Handle cons cell entry in
6987 glyphless-char-display.
6988 (Vglyphless_char_display): Document it.
6989
6990 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6991 glyphless-char-display.
6992
4581706e
CY
69932011-04-17 Chong Yidong <cyd@stupidchicken.com>
6994
6995 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6996
6997 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6998
6999 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7000 definition for no-X builds.
7001
4887c6e2 70022011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7003
fd35b6f9
PE
7004 Static checks with GCC 4.6.0 and non-default toolkits.
7005
5c1ccb01
PE
7006 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7007
006c5daa
PE
7008 * process.c (keyboard_bit_set): Define only if SIGIO.
7009 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7010 (send_process): Repair possible setjmp clobbering.
7011
efc736d3
PE
7012 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7013
4e2fe2e6
PE
7014 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7015
f97334a2
PE
7016 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7017
4e75f29d
PE
7018 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7019 Define only if needed.
7020
90efadd1
PE
7021 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7022 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7023 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7024
3c647824
PE
7025 * dispextern.h (struct redisplay_interface): Rename param
7026 to avoid shadowing.
e264f262 7027 * termhooks.h (struct terminal): Likewise.
761383f4 7028 * xterm.c (xembed_send_message): Likewise.
3c647824 7029
b58c5c4a
PE
7030 * insdel.c (make_gap_smaller): Define only if
7031 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7032
cad59032
PE
7033 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7034 it.
7035
c339dc2e
PE
7036 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7037 so that we aren't warned about unused symbols.
7038
91a3e27b
PE
7039 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7040
399c71d3 7041 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7042
8ffc96f5
PE
7043 * xfns.c (x_real_positions): Mark locals as initialized.
7044
eef9bc79
PE
7045 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7046
098db9dd
PE
7047 * xterm.c: Fix problems found by static analysis with other toolkits.
7048 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7049 (x_dispatch_event): Declare static if USE_GTK, and
7050 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7051 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7052 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7053 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7054 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7055
eb18f6cc
PE
7056 * xmenu.c (menu_help_callback): Pointer type fixes.
7057 Use const pointers when pointing at readonly data. Avoid pointer
7058 signedness clashes.
7059 (FALSE): Remove unused macro.
7060 (update_frame_menubar): Remove unused decl.
7061
1fe72bf8
PE
7062 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7063
60d9e1db
PE
7064 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7065 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7066 (single_menu_item): Rename local to avoid shadowing.
7067
39261c26
PE
7068 * keyboard.c (make_lispy_event): Remove unused local var.
7069
018c5e19
PE
7070 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7071 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7072
63d2b86e
PE
7073 * bitmaps: Change bitmaps from unsigned char back to the X11
7074 compatible char. Avoid the old compiler warnings about
7075 out-of-range initializers by using, for example, '\xab' rather
7076 than 0xab.
7077
aefd87e1
PE
7078 * xgselect.c (xgselect_initialize): Check vs interface
7079 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7080
bf501fb9
PE
7081 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7082
e9829fdf
PE
7083 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7084 to read-only memory.
7085
1086c095
PE
7086 * fns.c (vector): Remove; this old hack is no longer needed.
7087
2baccd04 7088 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7089 Remove unused var.
dde42981 7090 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7091
72391843 7092 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7093
436c16df 7094 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7095 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7096 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7097
92bb796d 7098 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7099 (x_term_init): Remove local to avoid shadowing.
92bb796d 7100
764430a3 7101 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7102
7103 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7104 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7105
d1dfb56c
EZ
71062011-04-16 Eli Zaretskii <eliz@gnu.org>
7107
c4354cb4
EZ
7108 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7109
d1dfb56c
EZ
7110 Fix regex.c, syntax.c and friends for buffers > 2GB.
7111 * syntax.h (struct gl_state_s): Declare character position members
7112 EMACS_INT.
7113
7114 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7115
04f2d78b
CB
7116 * textprop.c (verify_interval_modification, interval_of):
7117 Declare arguments EMACS_INT.
d1dfb56c
EZ
7118
7119 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7120 EMACS_INT.
7121
7122 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7123
7124 * indent.c (Fvertical_motion): Local variable it_start is now
7125 EMACS_INT.
7126
7127 * regex.c (re_match, re_match_2, re_match_2_internal)
7128 (bcmp_translate, regcomp, regexec, print_double_string)
7129 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7130 (re_compile_pattern, re_exec): Declare arguments and local
7131 variables `size_t' and `ssize_t' and return values `regoff_t', as
7132 appropriate.
7133 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7134 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7135 <compile_stack_type>: `size' and `avail' are now `size_t'.
7136
7137 * regex.h <regoff_t>: Use ssize_t, not int.
7138 (re_search, re_search_2, re_match, re_match_2): Arguments that
7139 specify buffer/string position and length are now ssize_t and
7140 size_t. Return type is regoff_t.
7141
613052cd
BK
71422011-04-16 Ben Key <bkey76@gmail.com>
7143
7144 * nsfont.m: Fixed bugs in ns_get_family and
7145 ns_descriptor_to_entity that were caused by using free to
7146 deallocate memory blocks that were allocated by xmalloc (via
7147 xstrdup). This caused Emacs to crash when compiled with
7148 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7149 --enable-checking=xmallocoverrun). xfree is now used to
7150 deallocate these memory blocks.
7151
4170f62f 71522011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7153
71b41406
PE
7154 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7155
9587a89d
PE
7156 emacs_write: Accept and return EMACS_INT for sizes.
7157 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7158 et seq.
7159 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7160 Accept and return EMACS_INT.
7161 (emacs_gnutls_write): Return the number of bytes written on
7162 partial writes.
7163 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7164 (emacs_read, emacs_write): Remove check for negative size, as the
7165 Emacs source code has been audited now.
9587a89d
PE
7166 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7167 (emacs_read, emacs_write): Use it.
273a5f82
PE
7168 * process.c (send_process): Adjust to the new signatures of
7169 emacs_write and emacs_gnutls_write. Do not attempt to store
7170 a byte offset into an 'int'; it might overflow.
9587a89d 7171 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7172
3e047f51
PE
7173 * sound.c: Don't assume sizes fit in 'int'.
7174 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7175 Return EMACS_INT, not int.
3e047f51 7176 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7177 Accept EMACS_INT, not int.
7178 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7179 record read return values.
7180
cc39a9db
BK
71812011-04-15 Ben Key <bkey76@gmail.com>
7182
c9d0ec6d
JB
7183 * keyboard.c (Qundefined): Don't declare static since it is used
7184 in nsfns.m.
7185 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7186 static since they are used in nsfont.m.
cc39a9db 7187
6c60eb9f
SM
71882011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7189
7190 * process.c (Qprocessp): Don't declare static.
7191 * lisp.h (Qprocessp): Declare again.
7192
7990b61a
JB
71932011-04-15 Juanma Barranquero <lekktu@gmail.com>
7194
7195 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7196
5d4cb038
PE
71972011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7198
8bd7b830 7199 Improve C-level modularity by making more things 'static'.
cd64ea1d 7200
e3b27b31
PE
7201 Don't publish debugger-only interfaces to other modules.
7202 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7203 (verify_bytepos, count_markers): Move decls to the only modules
7204 that need them.
7205 * region-cache.h (pp_cache): Likewise.
7206 * window.h (check_all_windows): Likewise.
7207 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7208
5d4cb038
PE
7209 * sysdep.c (croak): Now static, if
7210 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7211 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7212
7213 * alloc.c (refill_memory_reserve): Now static if
7214 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7215 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7216
e87b6180
PE
7217 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7218 Define only if USE_LUCID.
7219
ac64929e
PE
7220 * xrdb.c (x_customization_string, x_rm_string): Now static.
7221
6f37259d
PE
7222 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7223 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7224
1683e3ab
PE
7225 * xdisp.c (draw_row_with_mouse_face): Now static.
7226 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7227
de9c2632
PE
7228 * window.h (check_all_windows): Mark externally visible.
7229
2b96acb7
PE
7230 * window.c (window_deletion_count): Now static.
7231
7232 * undo.c: Make symbols static if they're not exported.
7233 (last_undo_buffer, last_boundary_position, pending_boundary):
7234 Now static.
7235
50436f33
PE
7236 * textprop.c (interval_insert_behind_hooks): Now static.
7237 (interval_insert_in_front_hooks): Likewise.
7238
64520e5c
PE
7239 * term.c: Make symbols static if they're not exported.
7240 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7241 (max_frame_lines, tty_set_terminal_modes):
7242 (tty_reset_terminal_modes, tty_turn_off_highlight):
7243 (get_tty_terminal): Now static.
7244 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7245 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7246 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7247 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7248 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7249
1fa53021
PE
7250 * sysdep.c: Make symbols static if they're not exported.
7251 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7252 Now static.
7253 (sigprocmask_set, full_mask): Remove; unused.
7254 (wait_debugging): Mark as visible.
7255 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7256 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7257
d4b43b22
PE
7258 * syntax.c (syntax_temp): Define only if !__GNUC__.
7259
b7c513d0
PE
7260 * sound.c (current_sound_device, current_sound): Now static.
7261
989b29ad
PE
7262 * search.c (searchbufs, searchbuf_head): Now static.
7263
13a55a78
PE
7264 * scroll.c (scroll_cost): Remove; unused.
7265 * dispextern.h (scroll_cost): Remove decl.
7266
de68a1fc
PE
7267 * region-cache.h (pp_cache): Mark as externally visible.
7268
40ccffa6
PE
7269 * process.c: Make symbols static if they're not exported.
7270 (process_tick, update_tick, create_process, chan_process):
7271 (Vprocess_alist, proc_buffered_char, datagram_access):
7272 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7273 (deactivate_process): Mark defn as static, as well as decl.
7274 * lisp.h (create_process): Remove decl.
7275 * process.h (chan_process, Vprocess_alist): Remove decls.
7276
ad64fc97
PE
7277 * print.c: Make symbols static if they're not exported.
7278 (print_depth, new_backquote_output, being_printed, print_buffer):
7279 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7280 (print_interval, print_number_index, initial_stderr_stream):
7281 Now static.
7282 * lisp.h (Fprinc): Remove decl.
7283 (debug_output_compilation_hack): Mark as externally visible.
7284
adddb265
PE
7285 * sysdep.c (croak): Move decl from here to syssignal.h.
7286 * syssignal.h (croak): Put it here, so the API can be checked when
7287 'croak' is called from dissociate_if_controlling_tty.
7288
1717ede2
PE
7289 * minibuf.c: Make symbols static if they're not exported.
7290 (minibuf_save_list, choose_minibuf_frame): Now static.
7291 * lisp.h (choose_minibuf_frame): Remove decl.
7292
fa5fb2bc
PE
7293 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7294
1e3890d1
PE
7295 * lread.c: Make symbols static if they're not exported.
7296 (read_objects, initial_obarray, oblookup_last_bucket_number):
7297 Now static.
7298 (make_symbol): Remove; unused.
7299 * lisp.h (initial_obarray, make_symbol): Remove decls.
7300
8a1414fa
PE
7301 * keyboard.c: Make symbols static if they're not exported.
7302 (single_kboard, recent_keys_index, total_keys, recent_keys):
7303 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7304 (this_single_command_key_start, echoing, last_auto_save):
7305 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7306 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7307 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7308 (Vlispy_mouse_stem, double_click_count):
7309 Now static.
7310 (force_auto_save_soon): Define only if SIGDANGER.
7311 (ignore_mouse_drag_p): Now static if
7312 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7313 (print_help): Remove; unused.
7314 (stop_character, last_timer_event): Mark as externally visible.
7315 * keyboard.h (ignore_mouse_drag_p): Declare only if
7316 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7317 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7318 * lisp.h (echoing): Remove decl.
7319 (force_auto_save_soon): Declare only if SIGDANGER.
7320 * xdisp.c (redisplay_window): Simplify code, to make it more
7321 obvious that ignore_mouse_drag_p is not accessed if !defined
7322 USE_GTK && !defined HAVE_NS.
7323
93ea6e8f
PE
7324 * intervals.c: Make symbols static if they're not exported.
7325 (merge_properties_sticky, merge_interval_right, delete_interval):
7326 Now static.
7327 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7328
77382fcc
PE
7329 * insdel.c: Make symbols static if they're not exported.
7330 However, leave prepare_to_modify_buffer alone. It's never
7331 called from outside this function, but that appears to be a bug.
7332 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7333 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7334 (adjust_after_replace_noundo): Remove; unused.
7335 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7336 (signal_before_change): Remove decls.
77382fcc 7337
9306c32e
PE
7338 * indent.c (val_compute_motion, val_vmotion): Now static.
7339
cd44d2eb
PE
7340 * image.c: Make symbols static if they're not exported.
7341 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7342 if USE_GTK.
7343 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7344 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7345
ad9a7a06
PE
7346 * fringe.c (standard_bitmaps): Now static.
7347 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7348
81626931
PE
7349 * frame.c: Make symbols static if they're not exported.
7350 (x_report_frame_params, make_terminal_frame): Now static.
7351 (get_frame_param): Now static, unless HAVE_NS.
7352 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7353 (x_get_resource_string): Remove; not used.
7354 * frame.h (make_terminal_frame, x_report_frame_params):
7355 (x_get_resource_string); Remove decls.
7356 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7357 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7358
239f9db9
PE
7359 * font.c, fontset.c: Make symbols static if they're not exported.
7360 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7361 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7362 * font.c (font_close_object): Now static.
7363 * font.h (font_close_object): Remove.
7364 * fontset.c (FONTSET_OBJLIST): Remove.
7365 (free_realized_fontset) #if-0 the body, which does nothing.
7366 (face_suitable_for_char_p): #if-0, as it's never called.
7367 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7368 * xfaces.c (face_at_string_position):
7369 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7370 since 0 is always ASCII.
7371
dfcf3579
PE
7372 * fns.c (weak_hash_tables): Now static.
7373
5045092b
PE
7374 * fileio.c: Make symbols static if they're not exported.
7375 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7376 (Vwrite_region_annotation_buffers): Now static.
7377
57a96f5c
PE
7378 * eval.c: Make symbols static if they're not exported.
7379 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7380 * lisp.h (backtrace_list): Remove decl.
7381
35f08c38
PE
7382 * emacs.c: Make symbols static if they're not exported.
7383 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7384 (fatal_error_code, fatal_error_signal_hook, standard_args):
7385 Now static.
7386 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7387 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7388 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7389 * lisp.h (fatal_error_signal_hook): Remove decl.
7390 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7391
f44bd759
PE
7392 * editfns.c: Move a (normally-unused) function to its only use.
7393 * editfns.c, lisp.h (get_operating_system_release): Remove.
7394 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7395 worth the hassle of breaking this out.
7396
b532497d
PE
7397 * xterm.c: Make symbols static if they're not exported.
7398 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7399 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7400 (x_destroy_window, x_delete_display):
7401 Now static.
7402 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7403 (x_mouse_leave): Remove; unused.
7404 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7405 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7406 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7407 Remove decls.
7408 (x_mouse_leave): Declare only if WINDOWSNT.
7409 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7410 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7411 USE_X_TOOLKIT.
7412
1675728f
PE
7413 * ftxfont.c: Make symbols static if they're not exported.
7414 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7415 HAVE_FREETYPE.
7416 * font.h (ftxfont_driver): Likewise.
7417
e4cebfca
PE
7418 * xfns.c: Make symbols static if they're not exported.
7419 (x_last_font_name, x_display_info_for_name):
7420 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7421 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7422 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7423 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7424 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7425 (last_show_tip_args): Now static.
7426 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7427 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7428 (x_screen_planes): Remove; unused.
7429 * dispextern.h (x_screen_planes): Remove decl.
7430
5bf46f05
PE
7431 * dispnew.c: Make symbols static if they're not exported.
7432 * dispextern.h (redraw_garbaged_frames, scrolling):
7433 (increment_row_positions): Remove.
7434 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7435 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7436 Now static.
7437 (redraw_garbaged_frames): Remove; unused.
7438
435f4c28
PE
7439 * xfaces.c: Make symbols static if they're not exported.
7440 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7441 Remove decls.
7442 * xterm.h (defined_color): Remove decls.
7443 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7444 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7445 (menu_face_changed_default, defined_color, free_realized_face):
7446 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7447 (ascii_face_of_lisp_face): Remove; unused.
7448
8524aef3
PE
7449 * xdisp.c: Make symbols static if they're not exported.
7450 * dispextern.h (scratch_glyph_row, window_box_edges):
7451 (glyph_to_pixel_coords, set_cursor_from_row):
7452 (get_next_display_element, set_iterator_to_next):
7453 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7454 (show_mouse_face): Remove decls
7455 * frame.h (message_buf_print): Likewise.
7456 * lisp.h (pop_message, set_message, check_point_in_composition):
7457 Likewise.
7458 * xterm.h (set_vertical_scroll_bar): Likewise.
7459 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7460 (message_buf_print, scratch_glyph_row, displayed_buffer):
7461 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7462 (get_next_display_element, show_mouse_face, window_box_edges):
7463 (frame_to_window_pixel_xy, check_point_in_composition):
7464 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7465 (glyph_to_pixel_coords): Remove; unused.
7466
16390cd2
PE
7467 * dired.c (file_name_completion): Now static.
7468
7469 * dbusbind.c (xd_in_read_queued_messages): Now static.
7470
a25f4dfa
PE
7471 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7472 * data.c (circular_list_error): Remove.
7473
14a9c8df
PE
7474 * commands.h (last_point_position, last_point_position_buffer):
7475 (last_point_position_window): Remove decls.
7476 * keyboard.c: Make these variables static.
7477
04f2d78b
CB
7478 * coding.h (coding, code_convert_region, encode_coding_gap):
7479 Remove decls.
74ab6df5
PE
7480 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7481 (iso_code_class, detect_coding, code_convert_region): Now static.
7482 (encode_coding_gap): Remove; unused.
7483
38dfbee1
PE
7484 * chartab.c (chartab_chars, chartab_bits): Now static.
7485
a2cb4e63
PE
7486 * charset.h (charset_iso_8859_1): Remove decl.
7487 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7488 Now static.
7489
127198fd
PE
7490 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7491 * ccl.c (Vccl_program_table): Now static.
7492 (check_ccl_update): Remove; unused.
7493
d85b608f
PE
7494 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7495 * category.h: ... from here.
7496 * category.c (check_category_table, set_category_set): Now static.
7497
31cd66f3
PE
7498 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7499 * lisp.h: Remove these decls.
7500
c358e587
PE
7501 * buffer.c (buffer_count): Remove unused var.
7502
e78aecca
PE
7503 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7504 so that it's not optimized away.
7505 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7506 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7507 exported only to the debugger.
7508
e192d7d3 7509 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7510 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7511
92470028
PE
7512 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7513 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7514 was inaccessible from Lisp.
7515 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7516 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7517
244ed907
PE
7518 alloc.c: Import and export fewer symbols, and remove unused items.
7519 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7520 is defined.
7521 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7522 it's not optimized away by whole-program optimization.
7523 (message_enable_multibyte, free_misc): Remove.
7524 (catchlist, handlerlist, mark_backtrace):
7525 Declare only if BYTE_MARK_STACK.
7526 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7527 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7528 (message_enable_multibyte): Remove decl.
7529 (free_misc, interval_free_list, float_block, float_block_index):
7530 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7531 (cons_free_list, last_marked_index):
7532 Now static.
7533 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7534 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7535 (mark_backtrace): Define only if BYTE_MARK_STACK.
7536 * xdisp.c (message_enable_multibyte): Now static.
7537
61c2b50e 7538 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7539 This makes it easier for human readers (and static analyzers)
7540 to see whether these variables are used from other modules.
7541 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7542 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7543 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7544 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7545 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7546 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7547 * xmenu.c, xselect.c:
7548 Declare Q* vars static if they are not used in other modules.
7549 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7550 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7551 Remove decls of unexported vars.
7552 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7553
95c82688
PE
7554 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7555
16a97296
PE
7556 Make Emacs functions such as Fatom 'static' by default.
7557 This makes it easier for human readers (and static analyzers)
7558 to see whether these functions can be called from other modules.
7559 DEFUN now defines a static function. To make the function external
7560 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7561 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7562 (Finit_image_library):
16a97296
PE
7563 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7564 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7565 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7566 Remove decls, since these functions are now static.
7567 (Funintern, Fget_internal_run_time): New decls, since these functions
7568 were already external.
95c82688 7569
16a97296
PE
7570 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7571 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7572 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7573 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7574 * keyboard.c, keymap.c, lread.c:
7575 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7576 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7577 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7578 Mark functions with DEFUE instead of DEFUN,
7579 if they are used in other modules.
7580 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7581 decls for now-static functions.
7582 * buffer.h (Fdelete_overlay): Remove decl.
7583 * callproc.c (Fgetenv_internal): Mark as internal.
7584 * composite.c (Fremove_list_of_text_properties): Remove decl.
7585 (Fcomposition_get_gstring): New forward static decl.
7586 * composite.h (Fcomposite_get_gstring): Remove decl.
7587 * dired.c (Ffile_attributes): New forward static decl.
7588 * doc.c (Fdocumntation_property): New forward static decl.
7589 * eval.c (Ffetch_bytecode): New forward static decl.
7590 (Funintern): Remove extern decl; now in .h file where it belongs.
7591 * fileio.c (Fmake_symbolic_link): New forward static decl.
7592 * image.c (Finit_image_library): New forward static decl.
7593 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7594 * intervals.h (Fprevious_property_change):
7595 (Fremove_list_of_text_properties): Remove decls.
7596 * keyboard.c (Fthis_command_keys): Remove decl.
7597 (Fcommand_execute): New forward static decl.
7598 * keymap.c (Flookup_key): New forward static decl.
7599 (Fcopy_keymap): Now static.
7600 * keymap.h (Flookup_key): Remove decl.
7601 * process.c (Fget_process): New forward static decl.
7602 (Fprocess_datagram_address): Mark as internal.
7603 * syntax.c (Fsyntax_table_p): New forward static decl.
7604 (skip_chars): Remove duplicate decl.
7605 * textprop.c (Fprevious_property_change): New forward static decl.
7606 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7607 Now internal.
7608 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7609 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7610
785bbd42
PE
7611 * editfns.c (Fformat): Remove unreachable code.
7612
8b913b57
AS
76132011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7614
7615 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7616 change. (Bug#8496)
7617
a6744a35
EZ
76182011-04-13 Eli Zaretskii <eliz@gnu.org>
7619
7620 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7621 when at ZV. (Bug#8487)
7622
e7974947
AS
76232011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7624
baad03f0
AS
7625 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7626 (Bug#8437)
7627 * keyboard.c (parse_tool_bar_item): Likewise.
7628 * sound.c (sound_cleanup, alsa_close): Likewise.
7629 * termcap.c (tgetent): Likewise.
7630 * xfns.c (x_default_font_parameter): Likewise.
7631 * xsettings.c (read_and_apply_settings): Likewise.
7632
e7974947
AS
7633 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7634 (overrun_check_free): Protoize.
7635
28272684
PE
76362011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7637
7638 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7639 since callers should never pass a negative size.
7640 Change the signature to match that of plain 'read' and 'write'; see
7641 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7642 * lisp.h: Update prototypes of emacs_write and emacs_read.
7643
11997c76
EZ
76442011-04-11 Eli Zaretskii <eliz@gnu.org>
7645
7646 * xdisp.c (redisplay_window): Don't try to determine the character
7647 position of the scroll margin if the window start point w->startp
e896f03c 7648 is outside the buffer's accessible region. (Bug#8468)
11997c76 7649
8a2cbd72
EZ
76502011-04-10 Eli Zaretskii <eliz@gnu.org>
7651
7652 Fix write-region and its subroutines for buffers > 2GB.
7653 * fileio.c (a_write, e_write): Modify declaration of arguments and
7654 local variables to support buffers larger than 2GB.
7655 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7656
7657 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7658 argument, local variables, and return value.
7659
7660 * lisp.h: Update prototypes of emacs_write and emacs_read.
7661
7662 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7663
4073e537 76642011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7665
1ebfdcb6
PE
7666 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7667
b2ded58d
PE
7668 Fix more problems found by GCC 4.6.0's static checks.
7669
7d66342c
PE
7670 * xdisp.c (vmessage): Use a better test for character truncation.
7671
bbf47d44
PE
7672 * charset.c (load_charset_map): <, not <=, for optimization,
7673 and to avoid potential problems with integer overflow.
9248994d 7674 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7675 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7676 * editfns.c (Fformat): Likewise.
1e69125e 7677 * syntax.c (skip_chars): Likewise.
3befa583 7678
e3019616
PE
7679 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7680 This also lets GCC 4.6.0 generate slightly better loop code.
7681
becfa255
PE
7682 * callint.c (Fcall_interactively): <, not <=, for optimization.
7683 (Fcall_interactively): Count the number of arguments produced,
7684 not the number of arguments given. This is simpler and lets GCC
7685 4.6.0 generate slightly better code.
7686
dae0cd48
PE
7687 * ftfont.c: Distingish more carefully between FcChar8 and char.
7688 The previous code passed unsigned char * to a functions like
7689 strlen and xstrcasecmp that expect char *, which does not
7690 conform to the C standard.
7691 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7692 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7693 char * when the C standard requires it.
7694
76032d70
PE
7695 * keyboard.c (read_char): Remove unused var.
7696
eb3f1cc8
PE
7697 * eval.c: Port to Windows vsnprintf (Bug#8435).
7698 Include <limits.h>.
7699 (SIZE_MAX): Define if the headers do not.
7700 (verror): Do not give up if vsnprintf returns a negative count.
7701 Instead, grow the buffer. This ports to Windows vsnprintf, which
7702 does not conform to C99. Problem reported by Eli Zaretskii.
7703 Also, simplify the allocation scheme, by avoiding the need for
7704 calling realloc, and removing the ALLOCATED variable.
7705
70476b54
PE
7706 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7707
12020a9e
PE
7708 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7709 But keep the doprint source code for now, as we might revamp it
7710 and use it again (Bug#8435).
ea6c7ae6
PE
7711 * lisp.h (doprnt): Remove.
7712 * Makefile.in (base_obj): Remove doprnt.o.
7713 * deps.mk (doprnt.o): Remove.
7714
5fdb398c
PE
7715 error: Print 32- and 64-bit integers portably (Bug#8435).
7716 Without this change, on typical 64-bit hosts error ("...%d...", N)
7717 was used to print both 32- and 64-bit integers N, which relied on
7718 undefined behavior.
7719 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7720 New macro.
7721 * lisp.h (error, verror): Mark as printf-like functions.
7722 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7723 Report overflow in size calculations when allocating printf buffer.
7724 Do not truncate output string at its first null byte.
7725 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7726 Truncate the output at a character boundary, since vsnprintf does not
7727 do that.
7728 * charset.c (check_iso_charset_parameter): Convert internal
7729 character to string before calling 'error', since %c now has the
7730 printf meaning.
7731 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7732 overflow when computing char to be passed to 'error'. Do not
7733 pass Lisp_Object to 'error'; pass the integer instead.
7734 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7735 formatted with plain %d.
7736
b189fa66
PE
7737 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7738
bff87ef0
PE
7739 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7740
7e2cac20
PE
7741 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7742
ce4d90b5
PE
7743 * xterm.c (x_catch_errors): Remove duplicate declaration.
7744
266c9547
PE
7745 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7746
79c49ad2
PE
7747 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7748
368f4090
JM
77492011-04-10 Jim Meyering <meyering@redhat.com>
7750
7751 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7752 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7753 return ssize_t not "int", and use size_t as the buffer length.
7754 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7755 * gnutls.h: Update declarations.
7756 * process.c (read_process_output): Use ssize_t, to match.
7757 (send_process): Likewise.
7758
a32d4040
CY
77592011-04-09 Chong Yidong <cyd@stupidchicken.com>
7760
7761 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7762
8546720e 77632011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7764
04f2d78b
CB
7765 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7766 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7767
8546720e
GM
7768 * xterm.c (handle_one_xevent):
7769 * xmenu.c (create_and_show_popup_menu):
7770 * xselect.c (x_decline_selection_request)
7771 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7772
0a2f5c1a 77732011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7774
7775 Fix some uses of `int' instead of EMACS_INT.
7776 * search.c (string_match_1, fast_string_match)
7777 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7778 (scan_buffer, find_next_newline_no_quit)
7779 (find_before_next_newline, search_command, Freplace_match)
7780 (Fmatch_data): Make some `int' variables be EMACS_INT.
7781
7782 * xdisp.c (display_count_lines): 3rd argument and return value now
7783 EMACS_INT. All callers changed.
7784 (pint2hrstr): Last argument is now EMACS_INT.
7785
7786 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7787 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7788 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7789 (decode_coding_utf_16, decode_coding_emacs_mule)
7790 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7791 (decode_coding_ccl, decode_coding_charset)
7792 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7793 (decode_coding_iso_2022, decode_coding_emacs_mule)
7794 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7795 <char_offset, last_offset>: Declare EMACS_INT.
7796 (encode_coding_utf_8, encode_coding_utf_16)
7797 (encode_coding_emacs_mule, encode_invocation_designation)
7798 (encode_designation_at_bol, encode_coding_iso_2022)
7799 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7800 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7801 Declare EMACS_INT.
7802 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7803 (encode_invocation_designation): Last argument P_NCHARS is now
7804 EMACS_INT.
7805 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7806 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7807
7808 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7809 All users changed.
7810
7811 * ccl.c (Fccl_execute_on_string): Declare some variables
7812 EMACS_INT.
7813
8546720e 78142011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7815
7816 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7817
4e19a977
CS
78182011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7819
7820 * process.c (Fformat_network_address): Doc fix.
7821
87302331
R
78222011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7823
ee7683eb 7824 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7825
cbb59342
CY
78262011-04-08 Chong Yidong <cyd@stupidchicken.com>
7827
7828 * keyboard.c (read_char): Call Lisp function help-form-show,
7829 instead of using internal_with_output_to_temp_buffer.
7830 (Qhelp_form_show): New var.
e0d38eeb 7831 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7832
7833 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7834
7835 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7836
e67a13ab
CY
78372011-04-06 Chong Yidong <cyd@stupidchicken.com>
7838
04f2d78b
CB
7839 * process.c (Flist_processes): Remove to Lisp.
7840 (list_processes_1): Delete.
e67a13ab 7841
973f782d
EZ
78422011-04-06 Eli Zaretskii <eliz@gnu.org>
7843
7c106b1e
EZ
7844 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7845
973f782d
EZ
7846 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7847
41cf7d1a 78482011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7849
ca23cc88
PE
7850 Fix more problems found by GCC 4.6.0's static checks.
7851
f390e2d5
PE
7852 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7853
42eea0d0
PE
7854 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7855
b69769da 7856 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7857
f9541e84
PE
7858 * xdisp.c (vmessage): Mark as a printf-like function.
7859
13841b55
PE
7860 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7861
c136c10f
PE
7862 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7863
5e2d4a30
PE
7864 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7865 printf-like functions.
7866 (tiff_load): Add casts to remove these marks before passing them
7867 to system-supplied API.
7868
583f48b9
PE
7869 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7870
b25d760e
PE
7871 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7872 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7873 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7874 directly, rather than having caller test rule sign. This avoids
7875 some unnecessary tests.
7876 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7877 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7878 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7879
bc7b6697 7880 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7881 (xfont_open): Avoid unnecessary tests.
bc7b6697 7882
27ccc379
PE
7883 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7884
dcd5c89a
PE
7885 * composite.h, composite.c (composition_gstring_put_cache):
7886 Use EMACS_INT, not int, for length.
7887
b13a45c6
PE
7888 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7889 breaking out part of COMPOSITION_DECODE_RULE.
7890 (COMPOSITION_DECODE_RULE): Use it.
7891 * composite.c (get_composition_id): Remove unused local vars,
7892 by using the new macro.
7893
1e792e4d
PE
7894 * textprop.c (set_text_properties_1): Change while to do-while,
7895 since the condition is always true at first.
7896
dc6c6455 7897 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7898 (interval_deletion_adjustment): Return unsigned value.
7899 All uses changed.
dc6c6455 7900
aba7731a
PE
7901 * process.c (list_processes_1, create_pty, read_process_output):
7902 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7903 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7904 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7905 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7906 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7907
fdfc4bf3
PE
7908 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7909
fca8fe46 7910 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7911 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7912
06a0259a 7913 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7914 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7915 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7916
e7b9e80f
PE
7917 * print.c (print_error_message): Avoid int overflow.
7918
56201685
PE
7919 * font.c (font_list_entities): Redo for clarity,
7920 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7921
78834453 7922 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7923 (font_score): Avoid potential overflow in diff calculation.
78834453 7924
0bc0b309 7925 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7926 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7927
e610eaca
PE
7928 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7929
b895abce
PE
7930 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7931 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7932 can always succeed if overflow has undefined behavior.
7933
1f1d9321 7934 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7935 (wordify): Omit three unnecessary tests.
1f1d9321 7936
c59478bc
PE
7937 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7938 All callers changed. This avoids the need for an unused var.
7939
79b73827
PE
7940 * casefiddle.c (casify_region): Remove var that is set but not used.
7941
a4db5dfe
PE
7942 * dired.c (file_name_completion): Remove var that is set but not used.
7943
43aae36e
PE
7944 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7945
2a47c44d 7946 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7947 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7948
a37c69bf
PE
7949 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7950 Check for integer overflow on size calculations.
7951
328ab8e7
PE
7952 * buffer.c (Fprevious_overlay_change): Remove var that is set
7953 but not used.
7954
e5a2a5cb
PE
7955 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7956 Remove vars that are set but not used.
8d84a6eb 7957 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7958 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7959
a60e5f68
PE
7960 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7961
f661cb61 7962 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7963 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7964
f0397f5a
PE
7965 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7966 that are set but not used.
7967
8664db06 7968 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7969 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7970
6abdaa4a
PE
7971 * xselect.c (x_get_local_selection, x_handle_property_notify):
7972 Remove vars that are set but not used.
7973
0ce7538d 7974 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7975 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7976
9ae848fc
PE
7977 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7978 Remove var that is set but not used.
0b918413
PE
7979 (scroll_bar_windows_size): Now size_t, not int.
7980 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7981 Check for overflow.
9ae848fc 7982
a5a62657
PE
7983 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7984 (map_tty_color) [!defined MSDOS]: Likewise.
7985
5c5cdd39
PE
7986 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7987
66ebf983
PE
7988 * coding.c: Remove vars that are set but not used.
7989 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7990 All callers changed.
7991 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7992 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7993 (decode_coding_charset): Remove vars that are set but not used.
7994
1be4d761
PE
7995 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7996 that is set but not used.
7997
47553fa8
PE
7998 * print.c (print_object): Remove var that is set but not used.
7999
1f7196bf 8000 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8001 The gnulib version avoids calling malloc in the usual case,
8002 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8003 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8004 * filelock.c (current_lock_owner): Likewise.
8005 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8006 * sysdep.c: Include allocator.h, careadlinkat.h.
8007 (emacs_no_realloc_allocator): New static constant.
8008 (emacs_readlink): New function.
fdb61804
PE
8009 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8010 ../lib/careadlinkat.h.
d1fdcab7 8011
f84c17c7
SM
80122011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8013
8014 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8015 first non-nil return value).
8016
ef3862ad
JD
80172011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8018
8019 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8020 if not defined (Bug#8403).
8021
376a7006
JB
80222011-04-02 Juanma Barranquero <lekktu@gmail.com>
8023
8024 * xdisp.c (display_count_lines): Remove parameter `start',
8025 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8026 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8027 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8028 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8029 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8030 and thereabouts. All callers changed.
8031 (get_per_char_metric): Remove parameter `f', unused since
8032 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8033
6ca3801d
JM
80342011-04-02 Jim Meyering <meyering@redhat.com>
8035
8036 do not dereference NULL upon failed strdup
8037 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8038 (ns_get_family): Likewise.
8039
d8e2b5ba
JB
80402011-04-02 Juanma Barranquero <lekktu@gmail.com>
8041
8042 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8043
8c74fcbd
JD
80442011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8045
8046 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8047 later (Bug#8403).
8048
7200d79c
SM
80492011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8050
03408648 8051 Add lexical binding.
7200d79c 8052
03408648
SM
8053 * window.c (Ftemp_output_buffer_show): New fun.
8054 (Fsave_window_excursion):
8055 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8056
8057 * lread.c (lisp_file_lexically_bound_p): New function.
8058 (Fload): Bind Qlexical_binding.
8059 (readevalloop): Remove `evalfun' arg.
8060 Bind Qinternal_interpreter_environment.
8061 (Feval_buffer): Bind Qlexical_binding.
8062 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8063 Mark as dynamic.
8064 (syms_of_lread): Declare `lexical-binding'.
8065
8066 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8067
8068 * keyboard.c (eval_dyn): New fun.
8069 (menu_item_eval_property): Use it.
ca105506
SM
8070
8071 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8072
03408648
SM
8073 * fns.c (concat, mapcar1): Accept byte-code-functions.
8074
8075 * eval.c (Fsetq): Handle lexical vars.
8076 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8077 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8078 (FletX, Flet): Obey lexical binding.
8079 (Fcommandp): Handle closures.
8080 (Feval): New `lexical' arg.
8081 (eval_sub): New function extracted from Feval. Use it almost
8082 everywhere where Feval was used. Look up vars in lexical env.
8083 Handle closures.
8084 (Ffunctionp): Move from subr.el.
8085 (Ffuncall): Handle closures.
8086 (apply_lambda): Remove `eval_flags'.
8087 (funcall_lambda): Handle closures and new byte-code-functions.
8088 (Fspecial_variable_p): New function.
8089 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8090 but without exporting it to Lisp.
23aba0ea 8091
23aba0ea 8092 * doc.c (Fdocumentation, store_function_docstring):
03408648 8093 * data.c (Finteractive_form): Handle closures.
23aba0ea 8094
03408648
SM
8095 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8096 interactive spec.
ba83908c 8097
04f2d78b
CB
8098 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8099 New byte-codes.
03408648
SM
8100 (exec_byte_code): New function extracted from Fbyte_code to handle new
8101 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8102
03408648 8103 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8104
03408648 8105 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8106
e2abce01
JB
81072011-03-31 Juanma Barranquero <lekktu@gmail.com>
8108
8109 * xdisp.c (redisplay_internal): Fix prototype.
8110
63696a73 81112011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8112
63696a73 8113 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8114 (try_scrolling): Use it when setting scroll_limit.
8115 Limit scrolling to 100 screen lines.
63696a73
EZ
8116 (redisplay_window): Even when falling back on "recentering",
8117 position point in the window according to scroll-conservatively,
8118 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8119
8120 (try_scrolling): When point is above the window, allow searching
8121 as far as scroll_max, or one screenful, to compute vertical
8122 distance from PT to the scroll margin position. This prevents
8123 try_scrolling from unnecessarily failing when
8124 scroll-conservatively is set to a value slightly larger than the
8125 window height. Clean up the case of PT below the margin at bottom
8126 of window: scroll_max can no longer be INT_MAX. When aggressive
8127 scrolling is in use, don't let point enter the opposite scroll
8128 margin as result of the scroll.
8129 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8130 threshold of 100 lines for never-recentering scrolling.
8131
e4cc2dfc
JB
81322011-03-31 Juanma Barranquero <lekktu@gmail.com>
8133
8134 * dispextern.h (move_it_by_lines):
8135 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8136 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8137 (message_log_check_duplicate): Remove parameters `prev_bol' and
8138 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8139 (redisplay_internal): Remove parameter `preserve_echo_area',
8140 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8141
8142 * indent.c (Fvertical_motion):
8143 * window.c (window_scroll_pixel_based, Frecenter):
8144 Don't pass `need_y_p' to `move_it_by_lines'.
8145
1c470562
SM
81462011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8147
44f230aa
SM
8148 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8149 steal a few bits to be more compact.
8150 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8151 Remove unneeded casts.
8152
1c470562
SM
8153 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8154
888adce9
ZK
81552011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8156
8157 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8158 binding" message (bug#7967).
8159
f838ed7b
PE
81602011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8161
77861b95
PE
8162 Fix more problems found by GCC 4.6.0's static checks.
8163
de6dbc14
PE
8164 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8165 Remove unused local var.
8166
f838ed7b
PE
8167 * editfns.c (Fmessage_box): Remove unused local var.
8168
792c7b2b
PE
8169 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8170 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8171 Omit unused local vars.
c499e557 8172 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8173 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8174 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8175 Omit unused local var.
8176
ba0165e1
PE
8177 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8178 Don't assume string length fits in int.
32ad8845 8179 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8180 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8181
3c59b4c9
PE
8182 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8183 instead of alloca (Bug#8344).
8184
a3eed478 8185 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8186 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8187
eb4d412d
PE
8188 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8189
1658b401
PE
8190 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8191 concerns.
8192
8193 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8194
8195 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8196
9a2c6e05
PE
8197 * keyboard.c (syms_of_keyboard): Use the same style as later
8198 in this function when indexing through an array. This also
8199 works around GCC bug 48267.
8200
03d0a109
PE
8201 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8202
44f730c8
PE
8203 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8204
fe75f926
PE
8205 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8206 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8207
ffa8c828
PE
8208 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8209 This avoids undefined behavior on integer overflow, and is a bit
8210 more convenient anyway since it is compared to a size_t variable.
8211
c5101a77
PE
8212 Variadic C functions now count arguments with size_t, not int.
8213 This avoids an unnecessary limitation on 64-bit machines, which
8214 caused (substring ...) to crash on large vectors (Bug#8344).
8215 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8216 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8217 All variadic functions and their callers changed accordingly.
c5101a77
PE
8218 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8219 * data.c (arith_driver, float_arith_driver): Likewise.
8220 * editfns.c (general_insert_function): Likewise.
8221 * eval.c (struct backtrace.nargs, interactive_p)
8222 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8223 (funcall_lambda, mark_backtrace): Likewise.
8224 * fns.c (concat): Likewise.
8225 * frame.c (x_set_frame_parameters): Likewise.
8226 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8227 0 if not found, not -1. All callers changed.
8228
dd3f25f7
PE
8229 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8230 (stack_copy_size): Now size_t, not int.
8231 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8232
461c2ab9
JB
82332011-03-28 Juanma Barranquero <lekktu@gmail.com>
8234
8235 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8236 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8237 All callers changed.
8238
8239 * lisp.h (multibyte_char_to_unibyte):
8240 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8241 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8242 * character.h (CHAR_TO_BYTE8):
8243 * cmds.c (internal_self_insert):
8244 * editfns.c (general_insert_function):
8245 * keymap.c (push_key_description):
8246 * search.c (Freplace_match):
8247 * xdisp.c (message_dolog, set_message_1): All callers changed.
8248
f6d62986
SM
82492011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8250
8251 * keyboard.c (safe_run_hook_funcall): New function.
8252 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8253 don't set the hook to nil, but remove the offending function instead.
8254 (Qcommand_hook_internal): Remove, unused.
8255 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8256 Vcommand_hook_internal.
8257
8258 * eval.c (enum run_hooks_condition): Remove.
8259 (funcall_nil, funcall_not): New functions.
8260 (run_hook_with_args): Call each function through a `funcall' argument.
8261 Remove `cond' argument, now redundant.
8262 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8263 (Frun_hook_with_args_until_failure): Adjust accordingly.
8264 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8265
1db5b1ad
JB
82662011-03-28 Juanma Barranquero <lekktu@gmail.com>
8267
8268 * dispextern.h (string_buffer_position): Remove declaration.
8269
8270 * print.c (strout): Remove parameter `multibyte', unused since
8271 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8272
8273 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8274 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8275 All callers changed.
8276
8277 * w32.c (_wsa_errlist): Use braces for struct initializers.
8278
8279 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8280 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8281 All callers changed.
8282 (string_buffer_position): Likewise. Also, make static (it's never
8283 used outside xdisp.c).
8284 (cursor_row_p): Remove parameter `w', unused since
8285 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8286 (decode_mode_spec): Remove parameter `precision', introduced during
8287 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8288 All callers changed.
8289
5ffb62aa
JD
82902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8291
8292 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8293
461c2ab9 82942011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8295
8296 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8297 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8298 (ns_update_auto_hide_menu_bar): New functions.
8299 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8300 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8301 ns_constrain_all_frames.
8302 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8303 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8304
5c380ffb
JD
83052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8306
8307 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8308
9af30bdf
GM
83092011-03-27 Glenn Morris <rgm@gnu.org>
8310
8311 * syssignal.h: Replace RETSIGTYPE with void.
8312 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8313 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8314 Replace SIGTYPE with void everywhere.
8315 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8316 * s/template.h (SIGTYPE): Remove commented out definition.
8317
e2abce01
JB
83182011-03-26 Eli Zaretskii <eliz@gnu.org>
8319
8320 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8321 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8322
f868cd8a
JB
83232011-03-26 Juanma Barranquero <lekktu@gmail.com>
8324
59eb0929
JB
8325 * w32.c (read_unc_volume): Use parameter `henum', instead of
8326 global variable `wget_enum_handle'.
8327
8328 * keymap.c (describe_vector): Remove parameters `indices' and
8329 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8330 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8331
f868cd8a
JB
8332 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8333
8334 * keyboard.c (timer_check): Remove parameter `do_it_now',
8335 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8336 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8337 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8338
8339 * keyboard.c (read_char):
8340 * w32menu.c (w32_menu_display_help):
8341 * xmenu.c (show_help_event, menu_help_callback):
8342 Adjust calls to `show_help_echo'.
8343
8344 * gtkutil.c (xg_maybe_add_timer):
8345 * keyboard.c (readable_events):
8346 * process.c (wait_reading_process_output):
8347 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8348
8349 * insdel.c (adjust_markers_gap_motion):
8350 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8351 (gap_left, gap_right): Don't call it.
8352
2ecf6fdb
CY
83532011-03-25 Chong Yidong <cyd@stupidchicken.com>
8354
8355 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8356 incurred during fontification.
8357
6b1f9ba4
JB
83582011-03-25 Juanma Barranquero <lekktu@gmail.com>
8359
8360 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8361 (DEFVAR_PER_BUFFER): Don't pass it.
8362
8363 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8364 (scrolling_window): Don't pass it.
8365
0f4a96b5
JB
83662011-03-25 Juanma Barranquero <lekktu@gmail.com>
8367
8368 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8369
8370 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8371 and `suffix'.
8372 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8373 of variables specific to SELinux and computation of `encoded_absname'.
8374
8375 * image.c (XPutPixel): Remove unused variable `height'.
8376
8377 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8378
8379 * unexw32.c (get_section_info): Remove unused variable `section'.
8380
8381 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8382 (system_process_attributes): Remove unused variable `sess'.
8383 (sys_read): Remove unused variable `err'.
8384
8385 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8386 (w32_wnd_proc): Remove unused variable `isdead'.
8387 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8388 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8389 (x_create_tip_frame): Remove unused variable `tem'.
8390
8391 * w32inevt.c (w32_console_read_socket):
8392 Remove unused variable `no_events'.
8393
8394 * w32term.c (x_draw_composite_glyph_string_foreground):
8395 Remove unused variable `width'.
8396
1149507c
JB
83972011-03-24 Juanma Barranquero <lekktu@gmail.com>
8398
8399 * w32term.c (x_set_glyph_string_clipping):
8400 Don't pass uninitialized region to CombineRgn.
8401
9c88f339
JB
84022011-03-23 Juanma Barranquero <lekktu@gmail.com>
8403
8404 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8405 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8406 (Fx_close_connection): Remove unused variable `i'.
8407
8408 * w32font.c (w32font_draw): Return number of glyphs.
8409 (w32font_open_internal): Remove unused variable `i'.
8410 (w32font_driver): Add missing initializer.
8411
8412 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8413 (fill_in_menu): Remove unused variable `items_added'.
8414
8415 * w32term.c (last_mouse_press_frame): Remove static global variable.
8416 (w32_clip_to_row): Remove unused variable `f'.
8417 (x_delete_terminal): Remove unused variable `i'.
8418
8419 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8420 (NOTHING): Remove unused static global variable.
8421 (uniscribe_check_otf): Remove unused variable `table'.
8422 (uniscribe_font_driver): Add missing initializers.
8423
dee091a3
JD
84242011-03-23 Julien Danjou <julien@danjou.info>
8425
8426 * term.c (Fsuspend_tty, Fresume_tty):
8427 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8428 * window.c (temp_output_buffer_show):
8429 * insdel.c (signal_before_change):
8430 * frame.c (Fhandle_switch_frame):
8431 * fileio.c (Fdo_auto_save):
8432 * emacs.c (Fkill_emacs):
8433 * editfns.c (save_excursion_restore):
8434 * cmds.c (internal_self_insert):
8435 * callint.c (Fcall_interactively):
8436 * buffer.c (Fkill_all_local_variables):
8437 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8438 Use Frun_hooks.
0f4a96b5 8439 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8440 unconditionally since it does the check itself.
dee091a3 8441
2c520ab5 84422011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8443
c9c49752
PE
8444 Fix more problems found by GCC 4.5.2's static checks.
8445
8abc3f12
PE
8446 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8447 the first time through the loop, since we know p0 < p1 then.
8448 This also avoids a gcc -Wstrict-overflow warning.
8449
a2d26660
PE
8450 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8451 leading to a memory leak, possible in functions like
8452 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8453 of objects (Bug#8318).
a2d26660 8454
916c72e9
PE
8455 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8456 that could (at least in theory) be that large.
8457
19ab8a18
PE
8458 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8459 This is less likely to overflow, and avoids undefined behavior if
8460 overflow does occur. All callers changed. Use strtoul to scan
8461 for the unsigned long integer.
b7cbbd6f
PE
8462 (pint2hrstr): Simplify and tune code slightly.
8463 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8464
f0641eff
PE
8465 * scroll.c (do_scrolling): Work around GCC bug 48228.
8466 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8467
7f650bb9
PE
8468 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8469 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8470 (validate_x_resource_name): Simplify count usage.
8471 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8472
37dd57d1
PE
8473 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8474 fail (Bug#8306).
81e56e61 8475
699979fc 8476 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8477
401bf9b4
PE
8478 * process.c (Fmake_network_process): Use socklen_t, not int,
8479 where POSIX says socklen_t is required in portable programs.
8480 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8481 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8482 (Fmake_network_process, server_accept_connection):
8483 (wait_reading_process_output, read_process_output):
8484 Likewise.
8485
b93aacde
PE
8486 * process.c: Rename or move locals to avoid shadowing.
8487 (list_processes_1, Fmake_network_process):
8488 (read_process_output_error_handler, exec_sentinel_error_handler):
8489 Rename or move locals.
4dc343ee 8490 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8491 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8492 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8493 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8494 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8495
af8a867c 8496 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8497 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8498 Include tparam.h instead, since it declares them.
af8a867c
PE
8499 * cm.h (PC): Remove extern decl; tparam.h now does this.
8500 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8501 * terminfo.c: Include tparam.h, to check interfaces.
8502 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8503 (tparam): Adjust signature to match interface in tparam.h;
8504 this removes some undefined behavior. Check that outstring and len
8505 are zero, which they always are with Emacs.
8506 * tparam.h (PC, BC, UP): New extern decls.
8507
0248044d 8508 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8509 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8510
8ff096c1 8511 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8512 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8513 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8514 (ftfont_list): Remove unused local.
49eaafba
PE
8515 (get_adstyle_property, ftfont_pattern_entity):
8516 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8517 Rename locals to avoid shadowing.
8ff096c1 8518
e2be39f6
PE
8519 * xfont.c (xfont_list_family): Mark var as initialized.
8520
c9735e30
PE
8521 * xml.c (make_dom): Now static.
8522
8f5201ae
PE
8523 * composite.c (composition_compute_stop_pos): Rename local to
8524 avoid shadowing.
b246f932
PE
8525 (composition_reseat_it): Remove unused locals.
8526 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8527 (composition_update_it): Mark var as initialized.
11b61122
PE
8528 (find_automatic_composition): Mark vars as initialized,
8529 with a FIXME (Bug#8290).
8f5201ae 8530
760fbc2c
PE
8531 character.h: Rename locals to avoid shadowing.
8532 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8533 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8534 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8535 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8536 to avoid shadowing.
8537
ff08eb85
PE
8538 * textprop.c (property_change_between_p): Remove; unused.
8539
fc7bf025
PE
8540 * intervals.c (interval_start_pos): Now static.
8541
235d7abc
PE
8542 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8543
44f230aa
SM
8544 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8545 Rename locals to avoid shadowing.
3e7d6594 8546
50060332
PE
8547 * sound.c (wav_play, au_play, Fplay_sound_internal):
8548 Fix pointer signedness.
d01f234b 8549 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8550 (wav_play): Initialize a variable to 0, to prevent undefined
8551 behavior (Bug#8278).
50060332 8552
c4fc4e30
PE
8553 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8554
918436ed
PE
8555 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8556
c939f91b
PE
8557 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8558 clobbering (Bug#8298).
b9c7f648
PE
8559 * sysdep.c (sys_subshell): Likewise.
8560 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8561
6bd8c144
PE
8562 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8563 This should get cleaned up, so that child_setup has the
8564 same signature on all platforms.
8565
7710357c 8566 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8567 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8568
c59da222
CY
85692011-03-22 Chong Yidong <cyd@stupidchicken.com>
8570
8571 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8572 not to be necessary, and produces flickering.
8573
66b87493
GM
85742011-03-20 Glenn Morris <rgm@gnu.org>
8575
8576 * config.in: Remove file.
8577
45b6f6d5
JB
85782011-03-20 Juanma Barranquero <lekktu@gmail.com>
8579
8580 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8581 are now in src/globals.h.
8582 (syms_of_minibuf): Remove spurious & from previous change.
8583
cd394be1 85842011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8585
8586 * minibuf.c (completing-read-function): New variable.
8587 (completing-read-default): Rename from completing-read.
8588 (completing-read): Call completing-read-function.
8589
b14e3e21
CY
85902011-03-19 Juanma Barranquero <lekktu@gmail.com>
8591
8592 * xfaces.c (Fx_load_color_file):
8593 Read color file from absolute filename (bug#8250).
8594
f2b726e6
JB
85952011-03-19 Juanma Barranquero <lekktu@gmail.com>
8596
8597 * makefile.w32-in: Update dependencies.
8598
09f6ff02
EZ
85992011-03-17 Eli Zaretskii <eliz@gnu.org>
8600
8601 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8602
29a6015a
PE
86032011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8604
a3a6c54e
PE
8605 Fix more problems found by GCC 4.5.2's static checks.
8606
b766f867
PE
8607 * process.c (make_serial_process_unwind, send_process_trap):
8608 (sigchld_handler): Now static.
8609
be02381c
PE
8610 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8611 That way, the code declares only the vars that it needs.
8612 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8613 * s/cygwin.h (PTY_ITERATION): Likewise.
8614 * s/darwin.h (PTY_ITERATION): Likewise.
8615 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8616
57048744
PE
8617 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8618 * process.c (allocate_pty): Don't declare stb unless it's needed.
8619
7914961c 8620 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8621 (CONSTANTLIM): Remove; unused.
8622 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8623 Define only if needed.
7914961c 8624
b3967b18
PE
8625 * unexelf.c (unexec): Name an expression,
8626 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8627 Use a different way to cause a compilation error if anyone uses
8628 n rather than nn, a way that does not involve shadowing.
73366a00 8629 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8630
29a6015a
PE
8631 * deps.mk (unexalpha.o): Remove; unused.
8632
43cfc33e 8633 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8634 * unexec.h: New file.
ce701a33
PE
8635 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8636 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8637 Depend on unexec.h.
8638 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8639 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8640 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8641 Change as necessary to match prototype in unexec.h.
ce701a33 8642
01f44d5a
PE
8643 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8644 shadowing.
4f63c6bb 8645 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8646
a6670b0b
PE
8647 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8648 Rename locals to avoid shadowing.
8649
cef2010d 8650 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8651 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8652
d4d7173a
PE
8653 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8654
f08b802a
PE
8655 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8656 warning when compiling print.c.
8657
3ddb0639
PE
8658 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8659 instead of using an uninitialized var.
5ad03b97 8660 (font_sort_entities): Mark var as initialized.
3ddb0639 8661
170a2692
PE
8662 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8663
e663c700
PE
8664 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8665 pointers to constants.
89bc529a 8666 (font_parse_fcname): Remove unused vars.
7b81e2d0 8667 (font_delete_unmatched): Now static.
ea838e10 8668 (font_get_spec): Remove; unused.
13a547c6
PE
8669 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8670 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8671 Rename or move locals to avoid shadowing.
e663c700 8672
2a80c887 8673 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8674 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8675
1384fa33 8676 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8677 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8678
8b2c52e9
PE
8679 * alloc.c (mark_backtrace): Move decl from here ...
8680 * lisp.h: ... to here, so that it can be checked.
8681
475545b5 8682 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8683 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8684 (lisp_indirect_variable): Name an expression,
8685 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8686 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8687
b1349114 8688 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8689 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8690 Use const pointer when appropriate.
b1349114 8691
a2928364
PE
8692 * lisp.h (get_system_name, get_operating_system_release):
8693 Move decls here, to check interfaces.
8694 * process.c (get_operating_system_release): Move decl to lisp.h.
8695 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8696 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8697 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8698 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8699 (Fformat_time_string, Fencode_time, Finsert_char):
8700 (Ftranslate_region_internal, Fformat):
8701 Rename or remove local vars to avoid shadowing.
9710023e 8702 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8703
a415e694
PE
8704 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8705 avoid shadowing.
8706
8ef4622d
PE
8707 * lisp.h (eassert): Check that the argument compiles, even if
8708 ENABLE_CHECKING is not defined.
8709
946f9a5b
PE
8710 * data.c (Findirect_variable): Name an expression, to avoid
8711 gcc -Wbad-function-cast warning.
112396d6 8712 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8713 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8714 (Fmake_variable_buffer_local, Fmake_local_variable):
8715 Mark variables as initialized.
52746918 8716 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8717
e5aab7e7 8718 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8719 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8720 Rename locals to avoid shadowing.
dff45157
PE
8721 (mark_stack): Move local variables into the #ifdef region where
8722 they're used.
7bc26fdb
PE
8723 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8724 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8725 needed otherwise.
8726 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8727 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8728 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8729
e5aab7e7
PE
8730 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8731 avoids undefined behavior in theory.
8732
4da60324
PE
8733 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8734
88043301
PE
8735 Use functions, not macros, for up- and down-casing (Bug#8254).
8736 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8737 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8738 to use the following functions instead of these macros.
8739 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8740 EMACS_INT, since callers assume the returned value fits in int.
8741 (upcase1): Likewise, for UPCASE_TABLE.
8742 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8743 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8744 the race-condition problem in the old DOWNCASE.
88043301 8745
19ed5445
PE
8746 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8747 Rename locals to avoid shadowing.
8748 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8749 (regex_compile, re_search_2, re_match_2_internal):
8750 Remove unused local vars.
952db0d7
PE
8751 (FREE_VAR): Rewrite so as not to use empty "else",
8752 which gcc can warn about.
da053e48 8753 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8754 (RETALLOC_IF): Define only if needed.
8755 (WORDCHAR_P): Likewise. This one is never needed, but is used
8756 only in a comment talking about a compiler bug, so put inside
8757 the #if 0 of that comment.
8758 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8759 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8760 Remove; unused.
19ed5445 8761
1f3561e4 8762 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8763 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8764 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8765
ded6f8f7
PE
8766 * search.c (simple_search): Remove unused var.
8767
dbd37a95
PE
8768 * dired.c (compile_pattern): Move decl from here ...
8769 * lisp.h: ... to here, so that it can be checked.
8770 (struct re_registers): New forward decl.
8771
7e47afad
PE
8772 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8773
85f24f61
PE
8774 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8775 All uses changed.
8776 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8777 Rename locals to avoid shadowing.
5671df8f 8778 (Fvertical_motion): Mark locals as initialized.
85f24f61 8779
181aa2be 8780 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8781 (casify_region): Mark local as initialized.
181aa2be 8782
930d429c
PE
8783 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8784
7082eac6
PE
8785 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8786 New macros, so that the caller can use some names other than
8787 gcpro1, gcpro2, etc.
8788 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8789 of the new macros.
8790 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8791 argument, for consistency with GCPRO2_VAR, etc: it is now the
8792 prefix of the variable, not the variable itself. All uses
8793 changed.
38b2c076
PE
8794 * dired.c (directory_files_internal, file_name_completion):
8795 Rename locals to avoid shadowing.
8796
15206ed9
PE
8797 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8798 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8799 dired.c's scmp function, had undefined behavior.
8800 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8801 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8802 * buffer.h: ... to here, because these macros use current_buffer,
8803 and the new implementation with inline functions needs to have
8804 current_buffer in scope now, rather than later when the macros
8805 are used.
8806 (downcase, upcase1): New static inline functions.
8807 (DOWNCASE, UPCASE1): Reimplement using these functions.
8808 This avoids undefined behavior in expressions like
8809 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8810 from race conditions in accessing the global variables
8811 case_temp1 and case_temp2.
8812 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8813 * lisp.h (case_temp1, case_temp2): Remove their decls.
8814 * character.h (ASCII_CHAR_P): Move from here ...
8815 * lisp.h: ... to here, so that the inline functions mentioned
8816 above can use them.
8817
4a6bea26
PE
8818 * dired.c (directory_files_internal_unwind): Now static.
8819
f14b7e14
PE
8820 * fileio.c (file_name_as_directory, directory_file_name):
8821 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8822 Now static.
2893f146
PE
8823 (file_name_as_directory): Use const pointers when appropriate.
8824 (Fexpand_file_name): Likewise. In particular, newdir might
8825 point at constant storage, so make it a const pointer.
fd4ead52 8826 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8827 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8828 signedness issues.
f839df0c
PE
8829 (Fset_file_times, Finsert_file_contents, auto_save_error):
8830 Rename locals to avoid shadowing.
f14b7e14 8831
5716756e 8832 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8833 (Ftry_completion, Fall_completions): Rename or remove locals
8834 to avoid shadowing.
5716756e 8835
b4c3046a
PE
8836 * marker.c (bytepos_to_charpos): Remove; unused.
8837
b45db522
PE
8838 * lisp.h (verify_bytepos, count_markers): New decls,
8839 so that gcc does not warn that these functions aren't declared.
8840
85876d07
PE
8841 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8842 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8843 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8844 (copy_text): Remove unused local var.
85876d07 8845
03d78a21 8846 * filelock.c (within_one_second): Now static.
b3dd38ab 8847 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8848
5df8f01b
PE
8849 * buffer.c (fix_overlays_before): Mark locals as initialized.
8850 (fix_start_end_in_overlays): Likewise. This function should be
8851 simplified by using pointers-to-pointers, but that's a different
8852 matter.
b1d876f1 8853 (switch_to_buffer_1): Now static.
8f54f30a
PE
8854 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8855 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8856
a70072c9 8857 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8858 Fix pointer signedness issue.
edced198
PE
8859 (sys_subshell): Mark local as volatile if checking for lint,
8860 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8861 (MAXPATHLEN): Define only if needed.
a70072c9 8862
a0977c44
PE
8863 * process.c (serial_open, serial_configure): Move decls from here ...
8864 * systty.h: ... to here, so that they can be checked.
8865
a884fdcc
PE
8866 * fns.c (get_random, seed_random): Move extern decls from here ...
8867 * lisp.h: ... to here, so that they can be checked.
8868
604efe86 8869 * sysdep.c (reset_io): Now static.
b8950c94 8870 (wait_for_termination_signal): Remove; unused.
604efe86 8871
38fc62d9
PE
8872 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8873 (copy_keymap_item, append_key, push_text_char_description):
8874 Now static.
1004a21a 8875 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8876 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8877 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8878 (describe_map_tree):
8879 Rename locals to avoid shadowing.
38fc62d9 8880
2f2650da
PE
8881 * keyboard.c: Declare functions static if they are not used elsewhere.
8882 (echo_char, echo_dash, cmd_error, top_level_2):
8883 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8884 (read_char, kbd_buffer_get_event, make_lispy_position):
8885 (make_lispy_event, make_lispy_movement, apply_modifiers):
8886 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8887 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8888 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8889 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8890 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8891
a053e86c 8892 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8893 (mark_kboards): Move decl here ...
8894 * alloc.c (mark_kboards): ... from here.
a053e86c 8895
4752793e
PE
8896 * lisp.h (force_auto_save_soon): New decl.
8897
74f10ca7 8898 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8899 (DEFINE_DUMMY_FUNCTION): New macro.
8900 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8901 Use it.
c03cd23f
PE
8902 (main): Add casts to avoid warnings
8903 if GCC considers string literals to be constants.
74f10ca7 8904
022e70d4
PE
8905 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8906
59d6fe83
PE
8907 * dbusbind.c: Pointer signedness fixes.
8908 (xd_signature, xd_append_arg, xd_initialize):
8909 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8910 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8911 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8912 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8913
78320123
PE
8914 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8915 if GCC considers string literals to be constants.
49cebcca 8916 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8917
35ac2a97
SM
89182011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8919
fb103ca9
SM
8920 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8921 (print_preprocess, print_object): New macro to fix last change.
8922
35ac2a97
SM
8923 * print.c (print_preprocess): Don't forget font objects.
8924
62973b41
JB
89252011-03-16 Juanma Barranquero <lekktu@gmail.com>
8926
8927 * emacs.c (USAGE3): Doc fixes.
8928
0e48bb22
AS
89292011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8930
8931 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8932 structure.
8933
7684e57b
JB
89342011-03-14 Juanma Barranquero <lekktu@gmail.com>
8935
8936 * lisp.h (VWindow_system, Qfile_name_history):
8937 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8938 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8939 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8940
8941 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8942 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8943
8944 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8945 * w32console.c (detect_input_pending, read_input_pending)
8946 (encode_terminal_code):
8947 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8948 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8949 (w32_system_caret_y, Qfile_name_history):
8950 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8951 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8952 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8953 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8954 * w32proc.c (Qlocal, report_file_error):
8955 * w32term.c (Vwindow_system, updating_frame):
8956 * w32uniscribe.c (initialized, uniscribe_font_driver):
8957 Remove unneeded extern declarations.
8958
2aa46d6c
CY
89592011-03-14 Chong Yidong <cyd@stupidchicken.com>
8960
c96bbc66 8961 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8962
cffc6f3b
CY
89632011-03-13 Chong Yidong <cyd@stupidchicken.com>
8964
8965 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8966 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8967 These macros can no longer be used for assignment.
8968
44f230aa
SM
8969 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8970 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8971 (record_buffer_markers, fetch_buffer_markers): New functions for
8972 recording and fetching special buffer markers.
8973 (set_buffer_internal_1, set_buffer_temp): Use them.
8974
8975 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8976
8977 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8978
8979 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8980 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8981
8982 * xdisp.c (hscroll_window_tree):
8983 (reconsider_clip_changes): Use PT instead of BUF_PT.
8984
d251f04b
EZ
89852011-03-13 Eli Zaretskii <eliz@gnu.org>
8986
8987 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8988 $(EMACS_ROOT)/lib/intprops.h.
8989
f0c77cd1
PE
89902011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8991
3eca4629
PE
8992 Fix more problems found by GCC 4.5.2's static checks.
8993
7c86ee98
PE
8994 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8995 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8996 (xg_free_frame_widgets): Make it clear that a local variable is
8997 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8998 (gdk_window_get_screen): Make it clear that this macro is needed
8999 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9000 (int_gtk_range_get_value): New function, which avoids a diagnostic
9001 from gcc -Wbad-function-cast.
9002 (xg_set_toolkit_scroll_bar_thumb): Use it.
9003 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9004 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9005 (get_utf8_string, xg_get_file_with_chooser):
9006 Rename locals to avoid shadowing.
9007 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9008
41729b81
PE
9009 * xgselect.c (xg_select): Remove unused var.
9010
f0c77cd1
PE
9011 * image.c (four_corners_best): Mark locals as initialized.
9012 (gif_load): Initialize transparent_p to zero (Bug#8238).
9013 Mark another local as initialized.
ec6cf4c6 9014 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9015
ce0ad53d 9016 * image.c (clear_image_cache): Now static.
d5d5a617 9017 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9018 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9019 (x_edge_detection): Remove unnecessary cast that
9020 gcc -Wbad-function-cast diagnoses.
2037898d 9021 (gif_load): Fix pointer signedness.
6ae141d6
PE
9022 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9023 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9024
33383987 90252011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9026
d32df629
PE
9027 Improve quality of tests for time stamp overflow.
9028 For example, without this patch (encode-time 0 0 0 1 1
9029 1152921504606846976) returns the obviously-bogus value (-948597
9030 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9031 reports time overflow. See
9032 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9033 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9034 * editfns.c: Include limits.h and intprops.h.
9035 (TIME_T_MIN, TIME_T_MAX): New macros.
9036 (time_overflow): Move earlier, to before first use.
9037 (hi_time, lo_time): New functions, for an accurate test for
9038 out-of-range times.
9039 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9040 (Fget_internal_run_time): Don't assume time_t fits in int.
9041 (make_time): Use list2 instead of Fcons twice.
9042 (Fdecode_time): More accurate test for out-of-range times.
9043 (check_tm_member): New function.
9044 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9045 (lisp_time_argument): Don't rely on undefined left-shift and
9046 right-shift behavior when checking for time stamp overflow.
8be6f318 9047
fe31d94c
PE
9048 * editfns.c (time_overflow): New function, refactoring common code.
9049 (Fformat_time_string, Fdecode_time, Fencode_time):
9050 (Fcurrent_time_string): Use it.
9051
8be6f318
PE
9052 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9053 * dired.c (make_time): Move to ...
9054 * editfns.c (make_time): ... here.
9055 * systime.h: Note the move.
9056
09d9db2c 90572011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9058
126bc0dc
YM
9059 * fringe.c (update_window_fringes): Remove unused variables.
9060
c47cbdfd
YM
9061 * unexmacosx.c (copy_data_segment): Also copy __got section.
9062 (Bug#8223)
9063
7ac80be9
EZ
90642011-03-12 Eli Zaretskii <eliz@gnu.org>
9065
c96bbc66 9066 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9067 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9068 Constify `char *' arguments and their references according to
9069 prototypes in tparam.h.
9070
ecb0f94d 9071 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9072
7ac80be9
EZ
9073 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9074 Adapt all references accordingly.
9075
9076 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9077
ef1fd07e
TT
90782011-03-11 Tom Tromey <tromey@redhat.com>
9079
9080 * buffer.c (syms_of_buffer): Remove obsolete comment.
9081
7ef4b50c
EZ
90822011-03-11 Eli Zaretskii <eliz@gnu.org>
9083
9084 * termhooks.h (encode_terminal_code): Declare prototype.
9085
9086 * msdos.c (encode_terminal_code): Don't declare prototype.
9087
9088 * term.c (encode_terminal_code): Now external again, used by
9089 w32console.c and msdos.c.
9090
44f230aa
SM
9091 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9092 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9093
4b1ec863 90942011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9095
1714f52b 9096 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9097
4b1ec863
PE
9098 * fringe.c (update_window_fringes): Mark locals as initialized
9099 (Bug#8227).
9100 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9101
524c7aa6
PE
9102 * alloc.c (mark_fringe_data): Move decl from here ...
9103 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9104 to check its interface.
9105 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9106
a5c0af81 9107 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9108 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9109 (fontset_font): Mark local as initialized.
a9a06e0b 9110 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9111
b4716021
PE
9112 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9113
811e9bac 9114 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9115 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9116 (x_own_selection, Fx_disown_selection_internal): Rename locals
9117 to avoid shadowing.
9118 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9119
7e3ab302
PE
9120 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9121 so that the caller can use some name other than gcpro1.
9122 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9123 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9124 (Fx_backspace_delete_keys_p):
9125 Use them to avoid shadowing, and rename vars to avoid shadowing.
9126 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9127 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9128 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9129 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9130 Remove unused locals.
7e3ab302
PE
9131 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9132 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9133 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9134 macros.
f78faa98 9135
e2b13473
PE
9136 * xterm.h (x_mouse_leave): New decl.
9137
77f23912
PE
9138 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9139 Remove unused functions.
cdf4ba58
PE
9140 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9141 (x_calc_absolute_position): Now static.
7411c686 9142 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9143 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9144 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9145 unless they are used.
38d0b34a
PE
9146 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9147 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9148 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9149 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9150 (x_error_catcher, x_connection_closed, x_error_handler):
9151 (x_error_quitter, xembed_send_message, x_iconify_frame):
9152 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9153 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9154 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9155
44f230aa
SM
9156 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9157 Rename or move locals to avoid shadowing.
6b463e58 9158 (tty_defined_color, merge_face_heights): Now static.
5967d051 9159 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9160 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9161 does not deduce is never used uninitialized.
73719eba
PE
9162 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9163 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9164
426994c3 9165 * terminal.c (store_terminal_param): Now static.
5489860b 9166
032f1620 9167 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9168 (set_frame_menubar): Remove unused local.
d4323972 9169 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9170 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9171 since they might point to immutable storage.
281585b0
PE
9172 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9173 since it's unused otherwise.
032f1620 9174
367c19e5 9175 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9176 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9177 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9178 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9179 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9180 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9181 does not deduce are never used uninitialized.
70739cbe 9182
07b48fa9
PE
9183 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9184
8868a238 9185 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9186 * window.c (window_loop, size_window):
9187 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9188
7e5cf297 9189 * window.c (display_buffer): Now static.
d6550a9f
PE
9190 (size_window): Mark variables that gcc -Wuninitialized
9191 does not deduce are never used uninitialized.
a586633d
PE
9192 * window.h (check_all_windows): New decl, to forestall
9193 gcc -Wmissing-prototypes diagnostic.
5b555da1 9194 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9195
f6095868
PE
9196 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9197 shadowing.
9198 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9199 Include <limits.h>.
9200 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9201 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9202 (load_charset_map): Mark variables that gcc -Wuninitialized
9203 does not deduce are never used uninitialized.
53df7c11 9204 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9205
f38b440c
PE
9206 * coding.c (coding_set_source, coding_set_destination):
9207 Use "else { /* comment */ }" rather than "else /* comment */;"
9208 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9209 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9210 a block, when the outer 'i' will do.
9211 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9212 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9213 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9214 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9215 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9216 Rename locals to avoid shadowing.
9217 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9218 * coding.c (emacs_mule_char, encode_invocation_designation):
9219 Now static, since they're not used elsewhere.
413bb2db 9220 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9221 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9222 (decode_coding_emacs_mule): Mark variables that gcc
9223 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9224 (detect_coding_iso_2022): Initialize a local variable that might
9225 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9226 this initialization is needed. (Bug#8211)
5f58e762
PE
9227 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9228 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9229 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9230 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9231 Remove unused macros.
f38b440c 9232
232b38b9 9233 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9234 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9235 * character.c (string_count_byte8): Likewise.
232b38b9 9236
fb90da1b
PE
9237 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9238 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9239
fb93dbc2
PE
9240 * chartab.c (copy_sub_char_table): Now static, since it's not used
9241 elsewhere.
5c156ace
PE
9242 (sub_char_table_ref_and_range, char_table_ref_and_range):
9243 Rename locals to avoid shadowing.
bbcd0949 9244 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9245
7d3b3862 9246 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9247 (BIDI_BOB): Remove unused macro.
7d3b3862 9248
6be7d3da
PE
9249 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9250 deduce are never used uninitialized.
c2ed9c8b 9251 * term.c (encode_terminal_code): Likewise.
6be7d3da 9252
75f8807f 9253 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9254
50938595
PE
9255 * tparam.h: New file.
9256 * term.c, tparam.h: Include it.
9257 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9258 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9259 Move these decls to tparam.h, and make them agree with what
9260 is actually in tparam.c. The previous trick of using incompatible
9261 decls in different modules does not conform to the C standard.
9262 All callers of tparam changed to use tparam's actual API.
9263 * tparam.c (tparam1, tparam, tgoto):
9264 Use const pointers where appropriate.
9265
fbceeba2
PE
9266 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9267 * cm.h (struct cm): Likewise.
9268 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9269 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9270 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9271 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9272 (turn_on_face, init_tty): Likewise.
9273 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9274
7f3f1250
PE
9275 * term.c (term_mouse_position): Rename local to avoid shadowing.
9276
e6ca6543
PE
9277 * alloc.c (mark_ttys): Move decl from here ...
9278 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9279
c40f8d15
AS
92802011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9281
9282 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9283
cfe0661d
JB
92842011-03-09 Juanma Barranquero <lekktu@gmail.com>
9285
9286 * search.c (compile_pattern_1): Remove argument regp, unused since
9287 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9288 (compile_pattern): Don't pass it.
9289
0afb4571
J
92902011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9291
9292 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9293 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9294 for ! HAVE_GTK3.
9295 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9296
9297 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9298
9299 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9300 gdk_window_get_screen, gdk_window_get_geometry,
9301 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9302 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9303 (xg_get_pixbuf_from_pixmap): New function.
9304 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9305 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9306 Call xg_get_pixbuf_from_pixmap instead of
9307 gdk_pixbuf_get_from_drawable.
9308 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9309 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9310 (xg_check_special_colors): Use GtkStyleContext and its functions
9311 for HAVE_GTK3.
9312 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9313 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9314 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9315 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9316 Call gtk_widget_get_preferred_size.
0afb4571
J
9317 (xg_frame_resized): gdk_window_get_geometry only takes 5
9318 parameters.
44f230aa
SM
9319 (xg_win_to_widget, xg_event_is_for_menubar):
9320 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9321 (xg_set_widget_bg): New function.
9322 (delete_cb): New function.
895009e1 9323 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9324 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9325 (xg_set_background_color): Call xg_set_widget_bg.
9326 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9327 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9328 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9329 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9330 if ! HAVE_GTK3.
9331 (update_frame_tool_bar): Call gtk_widget_hide.
9332 (xg_initialize): Use GDK_KEY_g.
9333
9334 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9335 if ! HAVE_GTK3
9336 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9337
9338 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9339 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9340 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9341
1c2cc4ef
JB
93422011-03-08 Juanma Barranquero <lekktu@gmail.com>
9343
9344 * w32xfns.c (select_palette): Check success of RealizePalette against
9345 GDI_ERROR, not zero.
9346
33383987 9347See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9348
9349;; Local Variables:
9350;; coding: utf-8
aac0c6e3
MR
9351;; End:
9352
acaf905b 9353 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9354
9355 This file is part of GNU Emacs.
9356
9357 GNU Emacs is free software: you can redistribute it and/or modify
9358 it under the terms of the GNU General Public License as published by
9359 the Free Software Foundation, either version 3 of the License, or
9360 (at your option) any later version.
9361
9362 GNU Emacs is distributed in the hope that it will be useful,
9363 but WITHOUT ANY WARRANTY; without even the implied warranty of
9364 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9365 GNU General Public License for more details.
9366
9367 You should have received a copy of the GNU General Public License
9368 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.