Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f13e0b08
PE
12011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4
94515237
JB
52011-06-27 Juanma Barranquero <lekktu@gmail.com>
6
7 * makefile.w32-in: Redesign dependencies so they reflect more
8 clearly which files are directly included by each source file,
9 and not through other includes.
10
e43b6e43
MR
112011-06-27 Martin Rudalics <rudalics@gmx.at>
12
13 * buffer.c (Qclone_number): Declare static and DEFSYM it.
14 (sort_overlays, overlay_strings): When an overlay's clone number
15 matches the window's clone number process the overlay even if
16 the overlay's window property doesn't match the current window.
17
d68443dc
MR
18 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
19 (Fwindow_hchild): Rename to Fwindow_left_child.
20 (Fwindow_next): Rename to Fwindow_next_sibling.
21 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
22 (resize_window_check): Rename to window_resize_check.
23 (resize_window_apply): Rename to window_resize_apply.
24 (Fresize_window_apply): Rename to Fwindow_resize_apply.
25 (Fdelete_other_windows_internal, resize_frame_windows)
26 (Fsplit_window_internal, Fdelete_window_internal)
27 (grow_mini_window, shrink_mini_window)
28 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 29
c7e73be5
JD
302011-06-26 Jan Djärv <jan.h.d@swipnet.se>
31
32 * emacsgtkfixed.h: State that this is only used with Gtk+3.
33 (emacs_fixed_set_min_size): Remove.
34 (emacs_fixed_new): Take frame as argument.
35
36 * emacsgtkfixed.c: State that this is only used with Gtk+3.
37 (_EmacsFixedPrivate): Remove minwidth/height.
38 Add struct frame *f.
39 (emacs_fixed_init): Initialize priv->f.
40 (get_parent_class, emacs_fixed_set_min_size): Remove.
41 (emacs_fixed_new): Set priv->f to argument.
42 (emacs_fixed_get_preferred_width)
43 (emacs_fixed_get_preferred_height): Use min_width/height from
44 frames size_hint to set minimum and natural (Bug#8919).
45 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
46 and use min_width/height from frames size_hint to set
47 min_width/height (Bug#8919).
48
49 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
50 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
51 indentation.
52
cf99dcf8
EZ
532011-06-26 Eli Zaretskii <eliz@gnu.org>
54
55 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
56 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
57 called at ZV.
58
029529ac
CY
592011-06-26 Chong Yidong <cyd@stupidchicken.com>
60
61 * process.c (wait_reading_process_output): Bypass select if
62 waiting for a cell while ignoring keyboard input, and input is
63 pending. Suggested by Jan Djärv (Bug#8869).
64
7a7ef429
PE
652011-06-25 Paul Eggert <eggert@cs.ucla.edu>
66
67 Use gnulib's dup2 module instead of rolling our own.
68 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
69
11fdef7d 702011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
71
72 * dispnew.c (scrolling_window): Before scrolling, turn off a
73 mouse-highlight in the window being scrolled.
74
cd3520a4
JB
752011-06-24 Juanma Barranquero <lekktu@gmail.com>
76
77 Move DEFSYM to lisp.h and use everywhere.
78
79 * character.h (DEFSYM): Move declaration...
80 * lisp.h (DEFSYM): ...here.
81
82 * gnutls.c:
83 * minibuf.c:
84 * w32menu.c:
85 * w32proc.c:
86 * w32select.c: Don't include character.h.
87
88 * alloc.c (syms_of_alloc):
89 * buffer.c (syms_of_buffer):
90 * bytecode.c (syms_of_bytecode):
91 * callint.c (syms_of_callint):
92 * casefiddle.c (syms_of_casefiddle):
93 * casetab.c (init_casetab_once):
94 * category.c (init_category_once, syms_of_category):
95 * ccl.c (syms_of_ccl):
96 * cmds.c (syms_of_cmds):
97 * composite.c (syms_of_composite):
98 * dbusbind.c (syms_of_dbusbind):
99 * dired.c (syms_of_dired):
100 * dispnew.c (syms_of_display):
101 * doc.c (syms_of_doc):
102 * editfns.c (syms_of_editfns):
103 * emacs.c (syms_of_emacs):
104 * eval.c (syms_of_eval):
105 * fileio.c (syms_of_fileio):
106 * fns.c (syms_of_fns):
107 * frame.c (syms_of_frame):
108 * fringe.c (syms_of_fringe):
109 * insdel.c (syms_of_insdel):
110 * keymap.c (syms_of_keymap):
111 * lread.c (init_obarray, syms_of_lread):
112 * macros.c (syms_of_macros):
113 * msdos.c (syms_of_msdos):
114 * print.c (syms_of_print):
115 * process.c (syms_of_process):
116 * search.c (syms_of_search):
117 * sound.c (syms_of_sound):
118 * syntax.c (init_syntax_once, syms_of_syntax):
119 * terminal.c (syms_of_terminal):
120 * textprop.c (syms_of_textprop):
121 * undo.c (syms_of_undo):
122 * w32.c (globals_of_w32):
123 * window.c (syms_of_window):
124 * xdisp.c (syms_of_xdisp):
125 * xfaces.c (syms_of_xfaces):
126 * xfns.c (syms_of_xfns):
127 * xmenu.c (syms_of_xmenu):
128 * xsettings.c (syms_of_xsettings):
129 * xterm.c (syms_of_xterm): Use DEFSYM.
130
4228cf16
TZ
1312011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
132
cd3520a4 133 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 134
7fcccf1e
PE
1352011-06-23 Paul Eggert <eggert@cs.ucla.edu>
136
7efb4e0e
PE
137 Integer and buffer overflow fixes (Bug#8873).
138
ff5844ad
PE
139 * print.c (printchar, strout): Check for string overflow.
140 (PRINTPREPARE, printchar, strout):
141 Don't set size unless allocation succeeds.
142
90532f02
PE
143 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
144 for sizes. Check for string overflow more accurately.
145 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
146
6d84508d
PE
147 * macros.c: Integer and buffer overflow fixes.
148 * keyboard.h (struct keyboard.kbd_macro_bufsize):
149 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
150 Use ptrdiff_t, not int, for sizes.
151 Don't increment bufsize until after realloc succeeds.
152 Check for size-calculation overflow.
153 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
154
437b2cb4
PE
155 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
156
8b9ac8b4
PE
157 * lread.c: Integer overflow fixes.
158 (read_integer): Radix is now EMACS_INT, not int,
159 to improve quality of diagnostics for out-of-range radices.
160 Calculate buffer size correctly for out-of-range radices.
161 (read1): Check for integer overflow in radices, and in
162 read-circle numbers.
82cb60d3
PE
163 (read_escape): Avoid int overflow.
164 (Fload, openp, read_buffer_size, read1)
165 (substitute_object_recurse, read_vector, read_list, map_obarray):
166 Use ptrdiff_t, not int, for sizes.
167 (read1): Use EMACS_INT, not int, for sizes.
20270765 168 Check for size overflow.
8b9ac8b4 169
7fcccf1e
PE
170 * image.c (cache_image): Check for size arithmetic overflow.
171
bfbbd7e7
PE
172 * lread.c: Integer overflow issues.
173 (saved_doc_string_size, saved_doc_string_length)
174 (prev_saved_doc_string_size, prev_saved_doc_string_length):
175 Now ptrdiff_t, not int.
176 (read1): Don't assume doc string length fits in int. Check for
177 out-of-range doc string lengths.
178 (read_list): Don't assume file position fits in int.
39019e54 179 (read_escape): Check for hex character overflow.
bfbbd7e7 180
4e323265
LL
1812011-06-22 Leo Liu <sdl.web@gmail.com>
182
183 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
184 Move to minibuffer.el.
185
85fece3e
PE
1862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
187
20b84ce9 188 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
189 The following patches are for when GLYPH_DEBUG && !XASSERT.
190 * dispextern.h (trace_redisplay_p, dump_glyph_string):
191 * dispnew.c (flush_stdout):
192 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
193 Mark as externally visible.
194 * dispnew.c (check_window_matrix_pointers): Now static.
195 * dispnew.c (window_to_frame_vpos):
196 * xfns.c (unwind_create_frame):
197 * xterm.c (x_check_font): Remove unused local.
198 * scroll.c (CHECK_BOUNDS):
199 * xfaces.c (cache_fache): Rename local to avoid shadowing.
200 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
201 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
202 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
203 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
204 Now static.
205 (debug_method_add): Use va_list and vsprintf rather than relying
206 on undefined behavior with wrong number of arguments.
207 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
208 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
209 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
210 since we're not interested in debugging glyphs with old libraries.
211 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
212 GCC 4.6.0's static checking.
213
0766b489
PE
2142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
215
31fd4b32
PE
216 Integer overflow and signedness fixes (Bug#8873).
217 A few related buffer overrun fixes, too.
218
b79e8648
PE
219 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
220
0766b489
PE
221 * dispextern.h (struct face.stipple):
222 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
223 (x_bitmap_mask, x_allocate_bitmap_record)
224 (x_create_bitmap_from_data, x_create_bitmap_from_file)
225 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
226 (x_create_bitmap_from_xpm_data):
227 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
228 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
229 (.bitmaps_last):
230 * xfaces.c (load_pixmap):
231 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
232 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
233 (.bitmaps_last, struct x_output.icon_bitmap):
234 Use ptrdiff_t, not int, for bitmap indexes.
235 (x_allocate_bitmap_record): Check for size overflow.
236 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
237
b081724f
PE
238 Use ptrdiff_t, not int, for overlay counts.
239 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
240 * editfns.c (overlays_around, get_pos_property):
241 * textprop.c (get_char_property_and_overlay):
242 * xdisp.c (next_overlay_change, note_mouse_highlight):
243 * xfaces.c (face_at_buffer_position):
21514da7
PE
244 * buffer.c (OVERLAY_COUNT_MAX): New macro.
245 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
246 (Fnext_overlay_change, Fprevious_overlay_change)
247 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 248 Use ptrdiff_t, not int, for sizes.
21514da7 249 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 250
3de73e5e
PE
251 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
252
2606c57b
PE
253 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
254 (x_session_initialize): Do not assume string length fits in int.
255
aaafe47a
PE
256 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
257 This is unlikely, but can occur if DPI is outlandish.
258
2674ddc8 259 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
260 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
261
28154962
PE
262 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
263 * xrdb.c (magic_file_p, search_magic_path):
264 Omit last arg SUFFIX; it was always 0. All callers changed.
265 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
266
7de51af5
PE
267 * xfont.c (xfont_match): Avoid need for strlen.
268
25ed6cc3
PE
269 * xfns.c: Don't assume strlen fits in int.
270 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
271
4eab31dd
PE
272 * xdisp.c (message_log_check_duplicate): Return intmax_t,
273 not unsigned long, as we prefer signed integers. All callers changed.
274 Detect integer overflow in repeat count.
275 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 276 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 277
171e2a58
PE
278 * termcap.c: Don't assume sizes fit in int and never overflow.
279 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
280 (gobble_line): Check for size-calculation overflow.
281
ad39faca 282 * minibuf.c (Fread_buffer):
6e5bb2dc 283 * lread.c (intern, intern_c_string):
74ca2eb3
PE
284 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
285 Don't assume string length fits in int.
286
52c61c22 287 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
288 * gtkutil.c (style_changed_cb): Avoid need for strlen.
289
b5b8c9e5
PE
290 * font.c: Don't assume string length fits in int.
291 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
292 Use ptrdiff_t, not int.
ccd6111c
PE
293 (font_intern_prop): Don't assume string length fits in int.
294 Don't assume integer property fits in fixnum.
295 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 296
882f0d81 297 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 298 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
299 Reformulate so as not to need the command string.
300 Invoke gzip -cd rather than gunzip, as it's more portable.
301 (lock_info_type, lock_file_1, lock_file):
302 Don't assume pid_t and time_t fit in unsigned long.
303 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
304 (current_lock_owner): Prefer signed type for sizes.
305 Use memcpy, not strncpy, where memcpy is what is really wanted.
306 Don't assume (via atoi) that time_t and pid_t fit in int.
307 Check for time_t and/or pid_t out of range, e.g., via a network share.
308 Don't alloca where an auto var works fine.
309
93f4cf88
PE
310 * fileio.c: Fix some integer overflow issues.
311 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
312 Don't assume string length fits in int.
313 (directory_file_name): Don't assume string length fits in long.
314 (make_temp_name): Don't assume pid fits in int, or that its print
315 length is less than 20.
316
f3e92b69
PE
317 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
318
1bfdaf10
PE
319 * coding.c (make_subsidiaries): Don't assume string length fits in int.
320
35016e9a
PE
321 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
322
3d1e65a1
PE
323 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
324 We prefer signed integers, even for size calculations.
325
0b963a93
PE
326 * emacs.c: Don't assume string length fits in 'int'.
327 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
328 (main): Don't invoke strlen when not needed.
329
573f4b54
PE
330 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
331 (XD_DEBUG_MESSAGE): Don't waste a byte.
332
989f33ba
PE
333 * callproc.c (getenv_internal_1, getenv_internal)
334 (Fgetenv_internal):
965d34eb
PE
335 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
336
e4d29b33
PE
337 * lread.c (invalid_syntax): Omit length argument.
338 All uses changed. This doesn't fix a bug, but it simplifies the
339 code away from its former Hollerith-constant appearance, and it's
340 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 341 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 342
eb49b136
PE
343 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
344 This didn't break anything, but it didn't help either.
345 It's confusing to put a bogus integer in a place where the actual
346 value does not matter.
9f62aeb1 347 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 348 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 349
15375a22
PE
350 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
351 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
352 implementation.
b61cc01c
PE
353 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
354 We prefer signed types, and the value cannot exceed the EMACS_INT
355 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
356 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
357 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
358 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 359
53b2623d
PE
360 * indent.c (sane_tab_width): New function.
361 (current_column, scan_for_column, Findent_to, position_indentation)
362 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 363 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 364
51cab52b 365 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 366
f2ed8a70
PE
367 * lisp.h (lint_assume): New macro.
368 * composite.c (composition_gstring_put_cache):
369 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
370
abe80cc6
PE
371 * editfns.c, insdel.c:
372 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 373
b02c740e
PE
374 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
375
ebc96716
PE
376 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
377
b4e50fa0 378 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 379 Use much-faster test for byte-length change.
311d5d7c 380 Don't assume string byte-length fits in 'int'.
a4cf38e4 381 Check that character arg fits in 'int'.
85461888 382 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 383
c0c1ee9f
PE
384 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
385
a498d7f4
PE
386 * fns.c (concat): Catch string overflow earlier.
387 Do not rely on integer wraparound.
388
51cab52b
PE
389 * dispextern.h (struct it.overlay_strings_charpos)
390 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
391 * xdisp.c (forward_to_next_line_start)
392 (back_to_previous_visible_line_start)
393 (reseat_at_next_visible_line_start, next_element_from_buffer):
394 Don't arbitrarily truncate the value of 'selective' to int.
395
76031fad
PE
396 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
397
5eb55db9
PE
398 * composite.c: Don't truncate sizes to 'int'.
399 (composition_gstring_p, composition_reseat_it)
400 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
401 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
402 not EMACS_UINT, for indexes.
5eb55db9 403
0703a717
PE
404 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
405
d6202519
PE
406 * buffer.c: Include <verify.h>.
407 (struct sortvec.priority, struct sortstr.priority):
8961a454 408 Now EMACS_INT, not int.
c20998a7 409 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
410 (struct sortstr.size, record_overlay_string)
411 (struct sortstrlist.size, struct sortlist.used):
412 Don't truncate size to int.
413 (record_overlay_string): Check for size-calculation overflow.
d6202519 414 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 415
d5a19415
JM
4162011-06-22 Jim Meyering <meyering@redhat.com>
417
029529ac 418 Don't leak an XBM-image-sized buffer
d5a19415
JM
419 * image.c (xbm_load): Free the image buffer after using it.
420
a9041e6c
PE
4212011-06-21 Paul Eggert <eggert@cs.ucla.edu>
422
423 Port to Sun C.
424 * composite.c (find_automatic_composition): Omit needless 'return 0;'
425 that Sun C diagnosed.
426 * fns.c (secure_hash): Fix pointer signedness issue.
427 * intervals.c (static_offset_intervals): New function.
428 (offset_intervals): Use it.
429
7f3f739f
LL
4302011-06-21 Leo Liu <sdl.web@gmail.com>
431
432 * deps.mk (fns.o):
433 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
434 sha512.h.
435
436 * fns.c (secure_hash): Rename from crypto_hash_function and change
437 the first arg to accept symbols.
5b66d427 438 (Fsecure_hash): New primitive.
7f3f739f
LL
439 (syms_of_fns): New symbols.
440
76147d94
DD
4412011-06-20 Deniz Dogan <deniz@dogan.se>
442
443 * process.c (Fset_process_buffer): Clarify return value in
444 docstring.
445
7d7d0045
CY
4462011-06-18 Chong Yidong <cyd@stupidchicken.com>
447
448 * dispnew.c (add_window_display_history): Use BVAR.
449
450 * xdisp.c (debug_method_add): Use BVAR.
451 (check_window_end, dump_glyph_matrix, dump_glyph)
452 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
453
454 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
455 Likewise.
456
457 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
458 check till after the cache is created in init_frame_faces.
459
ff2bc410
SM
4602011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
461
462 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
463
28177add
PE
4642011-06-16 Paul Eggert <eggert@cs.ucla.edu>
465
dd3482fe
PE
466 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
467 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
468 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
469
393d71f3 470 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
471 * fileio.c (Finsert_file_contents):
472 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
473 Remove the old (too-loose) buffer overflow checks.
474 They weren't needed, since make_gap checks for buffer overflow.
475 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
476 The old code merely checked for Emacs fixnum overflow, and relied
477 on undefined (wraparound) behavior. The new code avoids undefined
478 behavior, and also checks for ptrdiff_t and/or size_t overflow.
479
2e6813b0 480 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
481 Tune. Don't use wider integers than needed. Don't use alloca.
482 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 483
599a9e4f
PE
484 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
485
99561444
PE
486 * insdel.c, lisp.h (buffer_overflow): New function.
487 (insert_from_buffer_1, replace_range, replace_range_2):
488 * insdel.c (make_gap_larger):
489 * editfns.c (Finsert_char):
490 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
491
28177add
PE
492 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
493
e69dafad
PE
4942011-06-15 Paul Eggert <eggert@cs.ucla.edu>
495
a7af7fde 496 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 497
b1c46f02
PE
498 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
499 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
500
e69dafad
PE
501 * fileio.c: Don't assume EMACS_INT fits in off_t.
502 (emacs_lseek): New static function.
503 (Finsert_file_contents, Fwrite_region): Use it.
504 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
505
566684ea
PE
506 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
507
e6966cd6
PE
508 * fns.c: Don't overflow int when computing a list length.
509 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
510 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
511 truncation on 64-bit hosts. Check for QUIT every
512 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
513 faster and is responsive enough.
514 (Flength): Report an error instead of overflowing an integer.
515 (Fsafe_length): Return a float if the value is not representable
516 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 517 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 518 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 519
dd0b0efb
PE
520 * alloc.c: Check that resized vectors' lengths fit in fixnums.
521 (header_size, word_size): New constants.
522 (allocate_vectorlike): Don't check size overflow here.
523 (allocate_vector): Check it here instead, since this is the only
524 caller of allocate_vectorlike that could cause overflow.
525 Check that the new vector's length is representable as a fixnum.
526
86fe5cfe
PE
527 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
528 The previous code was bogus. For example, next_almost_prime (32)
529 returned 39, which is undesirable as it is a multiple of 3; and
530 next_almost_prime (24) returned 25, which is a multiple of 5 so
531 why was the code bothering to check for multiples of 7?
532
80e88859
PE
533 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
534
4a2f0ad6
PE
535 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
536
f66c7cf8
PE
537 Variadic C functions now count arguments with ptrdiff_t.
538 This partly undoes my 2011-03-30 change, which replaced int with size_t.
539 Back then I didn't know that the Emacs coding style prefers signed int.
540 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
541 were being counted with int, which may truncate counts on 64-bit
542 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
543 * lisp.h (struct Lisp_Subr.function.aMANY)
544 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
545 Arg counts are now ptrdiff_t, not size_t.
546 All variadic functions and their callers changed accordingly.
547 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
548 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
549 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
550 * callint.c (Fcall_interactively): Check arg count for overflow,
551 to avoid potential buffer overrun. Use signed char, not 'int',
552 for 'varies' array, so that we needn't bother to check its size
553 calculation for overflow.
554 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
555 * eval.c (apply_lambda):
556 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
557 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
558 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
559
a1759b76
PE
560 * callint.c (Fcall_interactively): Don't use index var as event count.
561
d96be9fc
PE
562 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
563 * mem-limits.h (SIZE): Remove; no longer used.
564
a690a978 565 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 566
578c21e6
PE
567 Remove unnecessary casts.
568 * xterm.c (x_term_init):
569 * xfns.c (x_set_border_pixel):
570 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
571 These aren't needed now that we assume ANSI C.
572
96f53c6c
PE
573 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
574 It's more likely to cause problems (due to unsigned overflow)
575 than to cure them.
576
83c77d31
PE
577 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
578
ee2079f1
PE
579 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
580
6da65536
PE
581 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
582
7147c4a4
PE
583 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
584
193e32d9
PE
585 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
586
e5533da6
PE
587 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
588
9910e595
PE
589 GLYPH_CODE_FACE returns EMACS_INT, not int.
590 * dispextern.h (merge_faces):
591 * xfaces.c (merge_faces):
01103c44
PE
592 * xdisp.c (get_next_display_element, next_element_from_display_vector):
593 Don't assume EMACS_INT fits in int.
9910e595 594
2638320e
PE
595 * character.h (CHAR_VALID_P): Remove unused parameter.
596 * fontset.c, lisp.h, xdisp.c: All uses changed.
597
045eb8d9
PE
598 * editfns.c (Ftranslate_region_internal): Omit redundant test.
599
c1f134b5
PE
600 * fns.c (concat): Minor tuning based on overflow analysis.
601 This doesn't fix any bugs. Use int to hold character, instead
602 of constantly refetching from Emacs object. Use XFASTINT, not
603 XINT, for value known to be a character. Don't bother comparing
604 a single byte to 0400, as it's always less.
605
395fcb93 606 * floatfns.c (Fexpt):
327eeec8
PE
607 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
608
abbd3d23
PE
609 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
610 for characters.
611
684a03ef
PE
612 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
613
0fed43f3
PE
614 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
615 Without this fix, on a 64-bit host (aset S 0 4294967386) would
616 incorrectly succeed when S was a string, because 4294967386 was
617 truncated before it was used.
618
8fd02eb7
PE
619 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
620 Otherwise, an out-of-range integer could cause undefined behavior
621 on a 64-bit host.
622
f8c86b69
PE
623 * composite.c: Use int, not EMACS_INT, for characters.
624 (fill_gstring_body, composition_compute_stop_pos): Use int, not
625 EMACS_INT, for values that are known to be in character range.
626 This doesn't fix any bugs but is the usual style inside Emacs and
627 may generate better code on 32-bit machines.
628
34206dd2
PE
629 Make sure a 64-bit char is never passed to ENCODE_CHAR.
630 This is for reasons similar to the recent CHAR_STRING fix.
631 * charset.c (Fencode_char): Check that character arg is actually
632 a character. Pass an int to ENCODE_CHAR.
633 * charset.h (ENCODE_CHAR): Verify that the character argument is no
634 wider than 'int', as a compile-time check to prevent future regressions
635 in this area.
636
c5958d4c 637 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
638
639 Make sure a 64-bit char is never passed to CHAR_STRING.
640 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
641 by silently ignoring the top 32 bits, allowing some values
642 that were far too large to be valid characters.
643 * character.h: Include <verify.h>.
644 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
645 arguments are no wider than unsigned, as a compile-time check
646 to prevent future regressions in this area.
647 * data.c (Faset):
01103c44 648 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
649 (Fsubst_char_in_region):
650 * fns.c (concat):
651 * xdisp.c (decode_mode_spec_coding):
652 Adjust to CHAR_STRING's new requirement.
653 * editfns.c (Finsert_char, Fsubst_char_in_region):
654 * fns.c (concat): Check that character args are actually
655 characters. Without this test, these functions did the wrong
656 thing with wildly out-of-range values on 64-bit hosts.
657
d37ca623
PE
658 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
659 These casts should not be needed on 32-bit hosts, either.
660 * keyboard.c (read_char):
661 * lread.c (Fload): Remove casts to unsigned.
662
ea204efb
PE
663 * lisp.h (UNSIGNED_CMP): New macro.
664 This fixes comparison bugs on 64-bit hosts.
665 (ASCII_CHAR_P): Use it.
666 * casefiddle.c (casify_object):
01103c44 667 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
668 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
669 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
670 * dispextern.h (FACE_FROM_ID):
671 * keyboard.c (read_char): Use UNSIGNED_CMP.
672
41cb286c
PE
673 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
674 not to EMACS_INT, to avoid GCC warning.
675
4a1b9832
PE
676 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
677
55daad71
PE
678 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
679 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
680 isn't needed on 32-bit machines.
8f95c75c 681
01103c44
PE
682 * buffer.c (Fgenerate_new_buffer_name):
683 Use EMACS_INT for count, not int.
0ceccced 684 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
685
686 * data.c (Qcompiled_function): Now static.
687
c6f072e7
PE
688 * window.c (window_body_lines): Now static.
689
20ce5912
PE
690 * image.c (gif_load): Rename local to avoid shadowing.
691
9c4c5f81
PE
692 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
693 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
694 * alloc.c (make_save_value): Integer argument is now of type
695 ptrdiff_t, not int.
696 (mark_object): Use ptrdiff_t, not int.
697 * lisp.h (pD): New macro.
698 * print.c (print_object): Use it.
699
c0c5c8ae
PE
700 * alloc.c: Use EMACS_INT, not int, to count objects.
701 (total_conses, total_markers, total_symbols, total_vector_size)
702 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
703 (total_free_floats, total_floats, total_free_intervals)
704 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
705 Now EMACS_INT, not int. All uses changed.
706 (Fgarbage_collect): Compute overall total using a double, so that
707 integer overflow is less likely to be a problem. Check for overflow
708 when converting back to an integer.
5a25e253
PE
709 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
710 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
711 These were 'int' variables that could overflow on 64-bit hosts;
712 they were never used, so remove them instead of repairing them.
211a0b2a 713 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
714 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
715 Previously, this ceilinged at INT_MAX, but that doesn't work on
716 64-bit machines.
e46bb31a 717 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 718
c78baabf 719 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 720 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
721 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
722 when a (possibly-narrower) signed value would do just as well.
723 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 724
c9d624c6
PE
725 * alloc.c: Catch some string size overflows that we were missing.
726 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
727 for convenience in STRING_BYTES_MAX.
728 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
729 The definition here is exact; the one in lisp.h was approximate.
730 (allocate_string_data): Check for string overflow. This catches
731 some instances we weren't catching before. Also, it catches
732 size_t overflow on (unusual) hosts where SIZE_MAX <= min
733 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
734 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 735
c9d624c6
PE
736 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
737 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
738 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
739
353032ce
PE
740 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
741
2bccce07
PE
742 * alloc.c (Fmake_string): Check for out-of-range init.
743
0ac30604
SM
7442011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
745
746 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
747
c195f2de
JD
7482011-06-14 Jan Djärv <jan.h.d@swipnet.se>
749
750 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
751 xg_get_default_scrollbar_width.
752
753 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
754 (int_gtk_range_get_value): Move to the scroll bar part of the file.
755 (style_changed_cb): Call update_theme_scrollbar_width and call
756 x_set_scroll_bar_default_width and xg_frame_set_char_size for
757 all frames (Bug#8505).
758 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
759 Call gtk_window_set_resizable if HAVE_GTK3.
760 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
761 and height if HAVE_GTK3 (Bug#8505).
762 (scroll_bar_width_for_theme): New variable.
763 (update_theme_scrollbar_width): New function.
764 (xg_get_default_scrollbar_width): Move code to
765 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
766 (xg_initialize): Call update_theme_scrollbar_width.
767
768 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
769
770 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
771
e10ac9f1
MR
7722011-06-12 Martin Rudalics <rudalics@gmx.at>
773
774 * frame.c (make_frame): Call other_buffer_safely instead of
775 other_buffer.
776
777 * window.c (temp_output_buffer_show): Call display_buffer with
778 second argument Vtemp_buffer_show_specifiers and reset latter
779 immediately after the call.
780 (Vtemp_buffer_show_specifiers): New variable.
781 (auto_window_vscroll_p, next_screen_context_lines)
782 (Vscroll_preserve_screen_position): Remove leading asterisks from
783 doc-strings.
784
2d3c217e 7852011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 786
7b7f97e8 787 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
788 * buffer.c (Qclone_number): Remove for now, as it's unused.
789 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
790 (record_buffer): Remove unused local.
791 * frame.c (other_visible_frames, frame_buffer_list): Now static.
792 (set_frame_buffer_list): Remove; unused.
793 * frame.h (other_visible_frames): Remove decl.
794 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
795 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
796 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
797 if HAVE_GPM.
798 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
799 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
800 Define only if HAVE_GPM.
801 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
802 (update_hints_inhibit): Remove; never set. All uses removed.
803 * widgetprv.h (emacsFrameClassRec): Remove decl.
804 * window.c (delete_deletable_window): Now returns void, since it
805 wasn't returning anything.
806 (compare_window_configurations): Remove unused locals.
807 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
808 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
809 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
810 the same widths as pointers. This follows up on the 2011-05-06 patch.
811 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
812 * xterm.h: Likewise.
813 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
814
1384b89e
JB
8152011-06-12 Juanma Barranquero <lekktu@gmail.com>
816
817 * makefile.w32-in: Update dependencies.
818 (LISP_H): Add lib/intprops.h.
819
1100a63c
CY
8202011-06-11 Chong Yidong <cyd@stupidchicken.com>
821
822 * image.c (gif_load): Add animation frame delay to the metadata.
823 (syms_of_image): Use DEFSYM. New symbol `delay'.
824
6198ccd0
MR
8252011-06-11 Martin Rudalics <rudalics@gmx.at>
826
827 * window.c (delete_deletable_window): Re-add.
828 (Fset_window_configuration): Rewrite to handle dead buffers and
829 consequently deletable windows.
830 (window_tree, Fwindow_tree): Remove. Supply functionality in
831 window.el.
832 (compare_window_configurations): Simplify code.
833
b6e3633c
AS
8342011-06-11 Andreas Schwab <schwab@linux-m68k.org>
835
1ab0dee5
AS
836 * image.c (imagemagick_load_image): Fix type mismatch.
837 (Fimagemagick_types): Likewise.
838
b6e3633c
AS
839 * window.h (replace_buffer_in_windows): Declare.
840
9397e56f
MR
8412011-06-11 Martin Rudalics <rudalics@gmx.at>
842
843 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
844 Qclone_number. Remove external declaration of Qdelete_window.
845 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
846 code.
847 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
848 Qbuffer_list_update_hook if allowed.
849 (Fother_buffer): Rewrite doc-string. Major rewrite for new
850 buffer list implementation.
851 (other_buffer_safely): New function.
852 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
853 calls to replace_buffer_in_windows and
854 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
855 if allowed.
856 (record_buffer): Inhibit quitting and rewrite using quittable
857 functions. Run Qbuffer_list_update_hook if allowed.
858 (Frecord_buffer, Funrecord_buffer): New functions.
859 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
860 switch-to-buffer to window.el.
861 (bury-buffer): Move to window.el.
862 (Vbuffer_list_update_hook): New variable.
863
864 * lisp.h (other_buffer_safely): Add prototype in buffer.c
865 section.
866
867 * window.h (resize_frame_windows): Move up in code.
868 (Fwindow_frame): Remove EXFUN.
869 (replace_buffer_in_all_windows): Remove prototype.
870 (replace_buffer_in_windows_safely): Add prototype.
871
872 * window.c: Declare Qdelete_window static again. Move down
873 declaration of select_count.
874 (Fnext_window, Fprevious_window): Rewrite doc-strings.
875 (Fother_window): Move to window.el.
876 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
877 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
878 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
879 window.el.
880 (replace_buffer_in_windows): Implement by calling
881 Qreplace_buffer_in_windows.
882 (replace_buffer_in_all_windows): Remove with some functionality
883 moved into replace_buffer_in_windows_safely.
884 (replace_buffer_in_windows_safely): New function.
885 (select_window_norecord, select_frame_norecord): Move in front
886 of run_window_configuration_change_hook. Remove now obsolete
887 declarations.
888 (Fset_window_buffer): Rewrite doc-string. Call
889 Qrecord_window_buffer.
890 (keys_of_window): Move binding for other-window to window.el.
891
b50691aa
CY
8922011-06-11 Chong Yidong <cyd@stupidchicken.com>
893
894 * dispextern.h (struct image): Replace data member, whose int_val
895 and ptr_val fields were not used by anything, with a single
896 lisp_val object.
897
898 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
899 (gif_clear_image, gif_load, imagemagick_load_image)
900 (gs_clear_image, gs_load): Callers changed.
901
3f754b86
PE
9022011-06-10 Paul Eggert <eggert@cs.ucla.edu>
903
cca69397
PE
904 * buffer.h: Include <time.h>, for time_t.
905 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
906
109e28d0
PE
907 Fix minor problems found by static checking.
908
60737f02
PE
909 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
910
4b66faf3
PE
911 Make identifiers static if they are not used in other modules.
912 * data.c (Qcompiled_function, Qframe, Qvector):
913 * image.c (QimageMagick, Qsvg):
914 * minibuf.c (Qmetadata):
915 * window.c (resize_window_check, resize_root_window): Now static.
916 * window.h (resize_window_check, resize_root_window): Remove decls.
917
109e28d0
PE
918 * window.c (window_deletion_count, delete_deletable_window):
919 Remove; unused.
46a4ce9e
PE
920 (window_body_lines): Now static.
921 (Fdelete_other_windows_internal): Mark vars as initialized.
922 Make sure 'resize_failed' is initialized.
923 (run_window_configuration_change_hook): Rename local to avoid shadowing.
924 (resize_window_apply): Remove unused local.
925 * window.h (delete_deletable_window): Remove decl.
926
109e28d0 927 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
928 (imagemagick_load_image): Fix pointer signedness problem by changing
929 last arg from unsigned char * to char *. All uses changed.
930 Also, fix a local for similar reasons.
931 Remove unused locals. Remove locals to avoid shadowing.
932 (fn_rsvg_handle_free): Remove; unused.
933 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 934 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 935
3f754b86
PE
936 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
937
2547adb1
CY
9382011-06-10 Chong Yidong <cyd@stupidchicken.com>
939
940 * image.c (gif_load): Fix omitted cast error introduced by
941 2011-06-06 change.
942
2c8e37d4
MR
9432011-06-10 Martin Rudalics <rudalics@gmx.at>
944
945 * window.h (resize_proportionally, orig_total_lines)
946 (orig_top_line): Remove from window structure.
947 (set_window_height, set_window_width, change_window_heights)
948 (Fdelete_window): Remove prototypes.
949 (resize_frame_windows): Remove duplicate declaration.
950
440a42e3
EZ
9512011-06-10 Eli Zaretskii <eliz@gnu.org>
952
953 * window.h (resize_frame_windows, resize_window_check)
954 (delete_deletable_window, resize_root_window)
955 (resize_frame_windows): Declare prototypes.
956
957 * window.c (resize_window_apply): Make definition be "static" to
958 match the prototype.
959
562dd5e9
MR
9602011-06-10 Martin Rudalics <rudalics@gmx.at>
961
962 * window.c: Remove declarations of Qwindow_size_fixed,
963 window_min_size_1, window_min_size_2, window_min_size,
964 size_window, window_fixed_size_p, enlarge_window, delete_window.
965 Remove static from declaration of Qdelete_window, it's
966 temporarily needed by Fbury_buffer.
967 (replace_window): Don't assign orig_top_line and
968 orig_total_lines.
969 (Fdelete_window, delete_window): Remove. Window deletion is
970 handled by window.el.
971 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
972 Fdelete_window calls with calls to Qdelete_window.
973 (Fdelete_other_windows): Remove. Deleting other windows is
974 handled by window.el.
975 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
976 handled in window.el.
977 (window_min_size_2, window_min_size_1, window_min_size): Remove.
978 Window minimum sizes are handled in window.el.
979 (shrink_windows, size_window, set_window_height)
980 (set_window_width, change_window_heights, window_height)
981 (window_width, CURBEG, CURSIZE, enlarge_window)
982 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
983 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
984 handled in window.el.
985 (make_dummy_parent): Rename to make_parent_window and give it a
986 second argument horflag.
987 (make_window): Don't set resize_proportionally any more.
988 (Fsplit_window): Remove. Windows are split in window.el.
989 (save_restore_action, save_restore_orig_size)
990 (shrink_window_lowest_first, save_restore_orig_size): Remove.
991 Resize mini windows in window.el.
992 (grow_mini_window, shrink_mini_window): Implement by calling
993 Qresize_root_window_vertically, resize_window_check and
994 resize_window_apply.
995 (saved_window, Fset_window_configuration, save_window_save): Do
996 not handle orig_top_line, orig_total_lines, and
997 resize_proportionally.
998 (window_min_height, window_min_width): Move to window.el.
999 (keys_of_window): Move bindings for delete-other-windows,
1000 split-window, delete-window and enlarge-window to window.el.
1001
1002 * buffer.c: Temporarily extern Qdelete_window.
1003 (Fbury_buffer): Temporarily call Qdelete_window instead of
1004 Fdelete_window (Fbury_buffer will move to window.el soon).
1005
1006 * frame.c (set_menu_bar_lines_1): Remove code handling
1007 orig_top_line and orig_total_lines.
1008
1009 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1010 set_window_height but set heights directly.
1011 (change_frame_size_1): Use resize_frame_windows.
1012
1013 * xdisp.c (init_xdisp): Don't use set_window_height but set
1014 heights directly.
1015
1016 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1017 resize_frame_windows instead of change_window_heights and run
1018 run_window_configuration_change_hook.
1019
1020 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1021 instead of change_window_heights and run
1022 run_window_configuration_change_hook.
1023
1a13852e
MR
10242011-06-09 Martin Rudalics <rudalics@gmx.at>
1025
1026 * window.c (replace_window): Rename second argument REPLACEMENT to
1027 NEW. New third argument SETFLAG. Rewrite.
1028 (delete_window, make_dummy_parent): Call replace_window with
1029 third argument 1.
1030 (window_list_1): Move down in code.
1031 (run_window_configuration_change_hook): Move set_buffer part
1032 before select_frame_norecord part in order to unwind correctly.
1033 Rename count1 to count.
1034 (recombine_windows, delete_deletable_window, resize_root_window)
1035 (Fdelete_other_windows_internal)
1036 (Frun_window_configuration_change_hook, make_parent_window)
1037 (resize_window_check, resize_window_apply, Fresize_window_apply)
1038 (resize_frame_windows, Fsplit_window_internal)
1039 (Fdelete_window_internal, Fresize_mini_window_internal): New
1040 functions.
1041 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1042
f3d1777e
MR
10432011-06-08 Martin Rudalics <rudalics@gmx.at>
1044
496e208e
MR
1045 * window.h (window): Add some new members to window structure -
1046 normal_lines, normal_cols, new_total, new_normal, clone_number,
1047 splits, nest, prev_buffers, next_buffers.
1048 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1049 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1050
f3d1777e
MR
1051 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1052 Remove.
496e208e
MR
1053 (make_dummy_parent): Set new members of windows structure.
1054 (make_window): Move down in code. Handle new members of window
1055 structure.
1056 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1057 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1058 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1059 (Fset_window_prev_buffers, Fwindow_next_buffers)
1060 (Fset_window_next_buffers, Fset_window_clone_number): New
1061 functions.
1062 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1063 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1064 Doc-string fixes.
1065 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1066 Argument WINDOW can be now internal window too.
1067 (Fwindow_use_time): Move up in code.
1068 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1069 Rewrite doc-string.
1070 (Fset_window_configuration, saved_window)
1071 (Fcurrent_window_configuration, save_window_save): Handle new
1072 members of window structure.
b9e809c2
MR
1073 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1074 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1075 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1076 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1077 Qget_mru_window, Qresize_root_window,
1078 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1079 Qauto_buffer_name; staticpro them.
f3d1777e 1080
abde8f8c
MR
10812011-06-07 Martin Rudalics <rudalics@gmx.at>
1082
1083 * window.c (Fwindow_total_size, Fwindow_left_column)
1084 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1085 (Fwindow_list_1): New functions.
1086 (window_box_text_cols): Replace with window_body_cols.
1087 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1088 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1089 (delete_window, Fset_window_configuration): Call
1090 delete_all_subwindows with window as argument.
1091 (delete_all_subwindows): Take a window as argument and not a
1092 structure. Rewrite.
190b47e6
MR
1093 (window_loop): Remove handling of GET_LRU_WINDOW and
1094 GET_LARGEST_WINDOW.
1095 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1096
1097 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1098 window_box_text_cols. delete_all_subwindows now takes a
1099 Lisp_Object as argument.
abde8f8c
MR
1100
1101 * indent.c (compute_motion, Fcompute_motion): Use
1102 window_body_cols instead of window_box_text_cols.
1103
fa8a67e6
MR
1104 * frame.c (delete_frame): Call delete_all_subwindows with root
1105 window as argument.
1106
a54e3482
DC
11072011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1108
1109 * fns.c (Fputhash): Document return value.
1110
60002bf5
CY
11112011-06-06 Chong Yidong <cyd@stupidchicken.com>
1112
1113 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1114
0c671da6 11152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1116
b862a52a 1117 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1118
be44ca6c
PE
1119 Check for overflow when converting integer to cons and back.
1120 * charset.c (Fdefine_charset_internal, Fdecode_char):
1121 Use cons_to_unsigned to catch overflow.
1122 (Fencode_char): Use INTEGER_TO_CONS.
1123 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1124 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1125 * data.c (long_to_cons, cons_to_long): Remove.
1126 (cons_to_unsigned, cons_to_signed): New functions.
1127 These signal an error for invalid or out-of-range values.
1128 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1129 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1130 * font.c (Ffont_variation_glyphs):
1131 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1132 * lisp.h: Include <intprops.h>.
1133 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1134 (cons_to_signed, cons_to_unsigned): New decls.
1135 (long_to_cons, cons_to_long): Remove decls.
1136 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1137 (Fprimitive_undo): Use CONS_TO_INTEGER.
1138 * xfns.c (Fx_window_property): Likewise.
1139 * xselect.c: Include <limits.h>.
1140 (x_own_selection, selection_data_to_lisp_data):
1141 Use INTEGER_TO_CONS.
1142 (x_handle_selection_request, x_handle_selection_clear)
1143 (x_get_foreign_selection, Fx_disown_selection_internal)
1144 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1145 (lisp_data_to_selection_data): Use cons_to_unsigned.
1146 (x_fill_property_data): Use cons_to_signed.
1147 Report values out of range.
1148
d1f3d2af
PE
1149 Check for buffer and string overflow more precisely.
1150 * buffer.h (BUF_BYTES_MAX): New macro.
1151 * lisp.h (STRING_BYTES_MAX): New macro.
1152 * alloc.c (Fmake_string):
1153 * character.c (string_escape_byte8):
1154 * coding.c (coding_alloc_by_realloc):
1155 * doprnt.c (doprnt):
1156 * editfns.c (Fformat):
1157 * eval.c (verror):
1158 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1159 since they may not be the same number.
1160 * editfns.c (Finsert_char):
1161 * fileio.c (Finsert_file_contents):
1162 Likewise for BUF_BYTES_MAX.
1163
dd52fcea
PE
1164 * image.c: Use ptrdiff_t, not int, for sizes.
1165 (slurp_file): Switch from int to ptrdiff_t.
1166 All uses changed.
1167 (slurp_file): Check that file size fits in both size_t (for
1168 malloc) and ptrdiff_t (for sanity and safety).
1169
7f9bbdbb
PE
1170 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1171 if b->modtime has its maximal value.
1172
dfe18f82
PE
1173 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1174
84acfcf0
PE
1175 Don't assume time_t can fit into int.
1176 * buffer.h (struct buffer.modtime): Now time_t, not int.
1177 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1178 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1179
ccd9a01a
PE
1180 Minor fixes for signed vs unsigned integers.
1181 * character.h (MAYBE_UNIFY_CHAR):
1182 * charset.c (maybe_unify_char):
1183 * keyboard.c (read_char, reorder_modifiers):
1184 XINT -> XFASTINT, since the integer must be nonnegative.
1185 * ftfont.c (ftfont_spec_pattern):
1186 * keymap.c (access_keymap, silly_event_symbol_error):
1187 XUINT -> XFASTINT, since the integer must be nonnegative.
1188 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1189 since it makes no difference and we prefer signed.
1190 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1191 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1192 nonnegative.
1193
d6d100dd
SM
11942011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1195
1196 * window.h (Fwindow_frame): Declare.
1197
2b6148e4
PE
11982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1201 (SPARE_MEMORY): Always define.
1202 (LARGE_REQUEST): Remove.
1203 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1204
f230ecc9
MR
12052011-06-06 Martin Rudalics <rudalics@gmx.at>
1206
727e958e
MR
1207 * lisp.h: Move EXFUNS for Fframe_root_window,
1208 Fframe_first_window and Fset_frame_selected_window to window.h.
1209
1210 * window.h: Move EXFUNS for Fframe_root_window,
1211 Fframe_first_window and Fset_frame_selected_window here from
1212 lisp.h.
1213
1214 * frame.c (Fwindow_frame, Fframe_first_window)
1215 (Fframe_root_window, Fframe_selected_window)
1216 (Fset_frame_selected_window): Move to window.c.
1217 (Factive_minibuffer_window): Move to minibuf.c.
1218 (Fother_visible_frames_p): New function.
1219
1220 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1221
f230ecc9
MR
1222 * window.c (decode_window, decode_any_window): Move up in code.
1223 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1224 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1225 (Fwindow_buffer): Move up and rewrite doc-string.
1226 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1227 (Fwindow_prev): New functions.
727e958e
MR
1228 (Fwindow_frame): Move here from frame.c. Accept any window as
1229 argument.
1230 (Fframe_root_window, Fframe_first_window)
1231 (Fframe_selected_window): Move here from frame.c. Accept frame
1232 or arbitrary window as argument. Update doc-strings.
1233 (Fminibuffer_window): Move up in code.
1234 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1235 (Fset_frame_selected_window): Move here from frame.c.
1236 Marginal rewrite.
727e958e
MR
1237 (Fselected_window, select_window, Fselect_window): Move up in
1238 code. Minor doc-string fixes.
f230ecc9 1239
4d09bcf6
PE
12402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1241
1242 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1243 Do not assume that spare memory exists; that assumption is valid
1244 only if SYSTEM_MALLOC.
1245 (LARGE_REQUEST): New macro, so that the issue of large requests
1246 is separated from the issue of spare memory.
1247
810928a2
AS
12482011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1249
172418ad
AS
1250 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1251 format. (Bug#8806)
1252
43f862f7
AS
1253 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1254
810928a2
AS
1255 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1256 before statements.
1257
a059fe24
JD
12582011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1259
1260 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1261
1262 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1263
1264 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1265 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1266
989bf368
JB
12672011-06-05 Juanma Barranquero <lekktu@gmail.com>
1268
1269 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1270
4b80f674
CY
12712011-06-04 Chong Yidong <cyd@stupidchicken.com>
1272
1273 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1274 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1275 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1276 New error handlers.
4b80f674
CY
1277 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1278 Obey Vx_select_enable_clipboard_manager. Catch errors in
1279 x_clipboard_manager_save (Bug#8779).
1280 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1281 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1282
99a33b77 12832011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1284
1285 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1286
99a33b77 12872011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1288
1289 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1290 in the current matrix if keep_current_p is non-zero.
1291
8264569d
EZ
12922011-06-04 Eli Zaretskii <eliz@gnu.org>
1293
1294 * bidi.c (bidi_level_of_next_char): Fix last change.
1295
57f97249
EZ
12962011-06-03 Eli Zaretskii <eliz@gnu.org>
1297
fec2107c 1298 Support bidi reordering of text covered by display properties.
57f97249 1299
fec2107c
EZ
1300 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1301 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1302 (bidi_cache_search, bidi_cache_iterator_state)
1303 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1304 (bidi_level_of_next_char, bidi_move_to_visually_next):
1305 Support character positions inside a run of characters covered by a
fec2107c
EZ
1306 display string.
1307 (bidi_paragraph_init, bidi_resolve_explicit_1)
1308 (bidi_level_of_next_char): Call bidi_fetch_char and
1309 bidi_fetch_char_advance instead of FETCH_CHAR and
1310 FETCH_CHAR_ADVANCE.
1311 (bidi_init_it): Initialize new members.
1312 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1313 definitions.
1314 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1315 instead of using explicit *_CHAR codes.
d6d100dd
SM
1316 (bidi_resolve_explicit, bidi_resolve_weak):
1317 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1318 bidirectional text is supported only in multibyte buffers.
1319 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1320 it to initialize the frame_window_p member of struct bidi_it.
1321 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1322 (bidi_resolve_explicit, bidi_resolve_weak)
1323 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1324 bidi_it->nchars is non-positive.
1325 (bidi_level_of_next_char): Don't try to lookup the cache for the
1326 next/previous character if nothing is cached there yet, or if we
1327 were just reseat()'ed to a new position.
c40e2fb2 1328
0e14fe90
EZ
1329 * xdisp.c (set_cursor_from_row): Set start and stop points
1330 according to the row's direction when priming the loop that looks
1331 for the glyph on which to display cursor.
1332 (single_display_spec_intangible_p): Function deleted.
1333 (display_prop_intangible_p): Reimplement to call
1334 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1335 Accept 3 additional arguments needed by handle_display_spec.
1336 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1337 values: lists, `(when COND...)' forms, etc.
1338 (single_display_spec_string_p): Support property values that are
1339 lists with the argument STRING its top-level element.
1340 (display_prop_string_p): Fix the condition for processing a
1341 property that is a list to be consistent with handle_display_spec.
fec2107c 1342 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1343 last portion of handle_display_prop.
1344 (compute_display_string_pos): Accept additional argument
1345 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1346 value of a `display' property is a "replacing spec".
1347 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1348 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1349 the display property, but just return a value indicating whether
1350 the display property will replace the characters it covers.
1351 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1352 frame_window_p members of struct bidi_it.
d6d100dd
SM
1353 (compute_display_string_pos, compute_display_string_end):
1354 New functions.
fec2107c
EZ
1355 (push_it): Accept second argument POSITION, where pop_it should
1356 jump to continue iteration.
1357 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1358
fec2107c
EZ
1359 * keyboard.c (adjust_point_for_property): Adjust the call to
1360 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1361
1362 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1363 (bidi_init_it): Update prototypes.
1364 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1365 (compute_display_string_pos, compute_display_string_end):
1366 Declare prototypes.
fec2107c
EZ
1367 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1368 EMACS_INT.
fc6f18ce 1369
40087514 13702011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1371
57f53182
PE
1372 Malloc failure behavior now depends on size of allocation.
1373 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1374 * lisp.h: Change signatures accordingly.
1375 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1376 All callers changed. (Bug#8762)
1377
1378 * gnutls.c: Use Emacs's memory allocators.
1379 Without this change, the gnutls library would invoke malloc etc.
1380 directly, which causes problems on non-SYNC_INPUT hosts, and which
1381 runs afoul of improving memory_full behavior. (Bug#8761)
1382 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1383 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1384 xfree instead of the default malloc, realloc, free.
1385 (Fgnutls_boot): No need to check for memory allocation failure,
1386 since xmalloc does that for us.
1387
ac32cd99 1388 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1389 * category.c (hash_get_category_set):
1390 * ccl.c (ccl_driver):
1391 * charset.c (Fdefine_charset_internal):
1392 * charset.h (struct charset.hash_index):
1393 * composite.c (get_composition_id, gstring_lookup_cache)
1394 (composition_gstring_put_cache):
1395 * composite.h (struct composition.hash_index):
1396 * dispextern.h (struct image.hash):
1397 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1398 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1399 (hashfn_equal, hashfn_user_defined, make_hash_table)
1400 (maybe_resize_hash_table, hash_lookup, hash_put)
1401 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1402 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1403 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1404 * image.c (make_image, search_image_cache, lookup_image)
1405 (xpm_put_color_table_h):
1406 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1407 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1408 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1409 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1410 * alloc.c (allocate_vectorlike):
1411 Check for overflow in vector size calculations.
1412 * ccl.c (ccl_driver):
1413 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1414 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1415 need to be updated by these changes.
40087514
PE
1416 * fns.c (make_hash_table, maybe_resize_hash_table):
1417 Check for integer overflow with large hash tables.
0de4bb68
PE
1418 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1419 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1420 (SXHASH_REDUCE): New macro.
1421 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1422 Use it instead of discarding useful hash info with large hash values.
1423 (sxhash_float): New function.
1424 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1425 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1426 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1427 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1428 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1429 Adjust signatures to match updated version of code.
1430 (consing_since_gc): Now EMACS_INT, since a single hash table can
1431 use more than INT_MAX bytes.
1432
698d32e2
DN
14332011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1434
1435 Make it possible to build with GCC-4.6+ -O2 -flto.
1436
1437 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1438
fd6fa53f
SM
14392011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1440
1441 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1442 Call minibuffer-inactive-mode.
1443
864db017
JB
14442011-05-31 Juanma Barranquero <lekktu@gmail.com>
1445
1446 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1447 Update dependencies.
1448
2ad0baf4
DN
14492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1450
1451 * data.c (init_data): Remove code for UTS, this system is not
1452 supported anymore.
1453
4fcc2638
DN
14542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1455
1456 Don't force ./temacs to start in terminal mode.
1457
1458 * frame.c (make_initial_frame): Initialize faces in all cases, not
1459 only when CANNOT_DUMP is defined.
1460 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1461
c56e0fd5
DN
14622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1463
1464 * dispnew.c (add_window_display_history): Use const for the string
1465 pointer. Remove declaration, not needed.
1466
333d54da 14672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1468
55d4c1b2 1469 Use 'inline', not 'INLINE'.
333d54da 1470 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1471 * alloc.c, fontset.c (INLINE): Remove.
1472 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1473 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1474 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1475 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1476 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1477
738db178
DN
14782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1479
1480 Make it possible to run ./temacs.
1481
1482 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1483 syms_of_callproc does the same thing. Remove test for
1484 "initialized", do it in the caller.
1485 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1486
620c53a6
SM
14872011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1488
1489 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1490 (read_minibuf): Use get_minibuffer.
1491 (syms_of_minibuf): Use DEFSYM.
1492 (Qmetadata): New var.
1493 * data.c (Qbuffer): Don't make it static.
1494 (syms_of_data): Use DEFSYM.
1495
e003a292
PE
14962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1499 (CCL_CODE_MIN): New macro.
1500
ed008a6d
PE
15012011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1502
3687c2ef
PE
1503 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1504
ed008a6d
PE
1505 * eval.c (Qdebug): Now static.
1506 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1507 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1508 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1509
d66c4c7c
CY
15102011-05-29 Chong Yidong <cyd@stupidchicken.com>
1511
1512 * image.c: Various fixes to ImageMagick code comments.
1513 (Fimagemagick_types): Doc fix.
1514
5fbc2025
PE
15152011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1516
0196f88a
PE
1517 Minor fixes prompted by GCC 4.6.0 warnings.
1518
1519 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1520
5fbc2025
PE
1521 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1522 (x_clipboard_manager_save_all): Move extern decl to ...
1523 * xterm.h: ... here, so that it can be checked for consistency.
1524
1dd3c2d9
CY
15252011-05-29 Chong Yidong <cyd@stupidchicken.com>
1526
1527 * xselect.c (x_clipboard_manager_save_frame)
1528 (x_clipboard_manager_save_all): New functions.
1529 (Fx_clipboard_manager_save): Lisp function deleted.
1530
1531 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1532 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1533
1534 * xterm.h: Update prototype.
1535
5ba6571d
WX
15362011-05-28 William Xu <william.xwl@gmail.com>
1537
1538 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1539 exiting (Bug#8239).
1540
3eaff834
JM
15412011-05-28 Jim Meyering <meyering@redhat.com>
1542
e1900994 1543 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1544 * fns.c (to_uchar): Define.
1545 (crypto_hash_function): Use it to convert some newly-signed
1546 variables to unsigned, to avoid sign-extension bugs. For example,
1547 without this change, (md5 "truc") would evaluate to
1548 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1549 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1550 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1551
0f6990a7
PE
15522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 Integer overflow fixes.
c8a9ca5a 1555
08686060
PE
1556 * dbusbind.c: Serial number integer overflow fixes.
1557 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1558 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1559 to hold a serial number that is too large for a fixnum.
1560 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1561 Check for serial numbers out of range. Decode any serial number
59568bf0 1562 that was so large that it became a float. (Bug#8722)
08686060 1563
2d1fc3c7
PE
1564 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1565 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1566 Use XFASTINT rather than XUINT when numbers are nonnegative.
1567 (xd_append_arg, Fdbus_method_return_internal):
1568 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1569 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1570 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1571 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1572 (Bug#8722)
2d1fc3c7 1573
c8a9ca5a
PE
1574 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1575
519e1d69
PE
1576 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1577
30569699
PE
1578 ccl: add integer overflow checks
1579 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1580 (IN_INT_RANGE): New macros.
1581 (ccl_driver): Use them to check for integer overflow when
1582 decoding a CCL program. Many of the new checks are whether XINT (x)
1583 fits in int; it doesn't always, on 64-bit hosts. The new version
1584 doesn't catch all possible integer overflows, but it's an
847044ea 1585 improvement. (Bug#8719)
30569699 1586
c11285dc
PE
1587 * alloc.c (make_event_array): Use XINT, not XUINT.
1588 There's no need for unsigned here.
1589
fdccd48e
PE
1590 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1591 This follows up to the 2011-05-06 change that substituted uintptr_t
1592 for EMACS_INT. This case wasn't caught back then.
1593
37910ab2
PE
1594 Rework Fformat to avoid integer overflow issues.
1595 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1596 now (part of C89). Include <verify.h>.
1597 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1598 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1599 (Fformat): Avoid the prepass trying to compute sizes; it was only
1600 approximate and thus did not catch overflow reliably. Instead, walk
1601 through the format just once, formatting and computing sizes as we go,
1602 checking for integer overflow at every step, and allocating a larger
1603 buffer as needed. Keep track separately whether the format is
1604 multibyte. Keep only the most-recently calculated precision, rather
1605 than them all. Record whether each argument has been converted to
1606 string. Use EMACS_INT, not int, for byte and char and arg counts.
1607 Support field widths and precisions larger than INT_MAX. Avoid
1608 sprintf's undefined behavior with conversion specifications such as %#d
1609 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1610 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1611 formatting out-of-range floating point numbers with int
1612 formats. (Bug#8668)
1613
2e6578fb
PE
1614 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1615
0ae6bdee
PE
1616 * data.c: Avoid integer truncation in expressions involving floats.
1617 * data.c: Include <intprops.h>.
1618 (arith_driver): When there's an integer overflow in an expression
1619 involving floating point, convert the integers to floating point
1620 so that the resulting value does not suffer from catastrophic
1621 integer truncation. For example, on a 64-bit host (* 4
1622 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1623 Do not rely on undefined behavior after integer overflow.
1624
de883a70
PE
1625 merge count_size_as_multibyte, parse_str_to_multibyte
1626 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1627 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1628 Check for integer overflow.
1629 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1630 since it's now a duplicate of the other. This is more of
1631 a character than a buffer op, so better that it's in character.c.
1632 * fns.c, print.c: Adjust to above changes.
1633
2ff916cb
PE
16342011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1635
1636 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1637
f1b54466
PE
16382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1639
fb1ac845
PE
1640 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1641 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1642 (x_clipboard_manager_save): Now static.
1643 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1644
f1b54466
PE
1645 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1646 (crypto_hash_function): Now static.
1647 Fix pointer signedness problems. Avoid unnecessary initializations.
1648
a9f737ee
CY
16492011-05-27 Chong Yidong <cyd@stupidchicken.com>
1650
1651 * termhooks.h (Vselection_alist): Make it terminal-local.
1652
1653 * terminal.c (create_terminal): Initialize it.
1654
1655 * xselect.c: Support for clipboard managers.
1656 (Vselection_alist): Move to termhooks.h as terminal-local var.
1657 (LOCAL_SELECTION): New macro.
1658 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1659 (symbol_to_x_atom): Remove gratuitous arg.
1660 (x_handle_selection_request, lisp_data_to_selection_data)
1661 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1662 (x_own_selection, x_get_local_selection, x_convert_selection):
1663 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1664 (some_frame_on_display): Delete unused function.
1665 (Fx_own_selection_internal, Fx_get_selection_internal)
1666 (Fx_disown_selection_internal, Fx_selection_owner_p)
1667 (Fx_selection_exists_p): New optional frame arg.
1668 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1669 (x_handle_selection_clear): Don't treat other terminals with the
1670 same keyboard specially. Use the terminal-local Vselection_alist.
1671 (x_clear_frame_selections): Use Frun_hook_with_args.
1672
1673 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1674
1675 * xterm.h: Add support for those atoms.
1676
e067f0c1
CY
16772011-05-26 Chong Yidong <cyd@stupidchicken.com>
1678
1679 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1680 (converted_selections, conversion_fail_tag): New global variables.
1681 (x_selection_request_lisp_error): Free the above.
1682 (x_get_local_selection): Remove unnecessary code.
1683 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1684 of converted selections stored in converted_selections.
1685 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1686 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1687 (x_convert_selection): New function.
1688 (x_handle_selection_event): Simplify.
1689 (x_get_foreign_selection): Don't ignore incoming requests while
1690 waiting for an answer; this will fail when we implement
1691 SAVE_TARGETS, and seems unnecessary anyway.
1692 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1693 (Vx_sent_selection_functions): Doc fix.
1694
0f4aebc0
LL
16952011-05-26 Leo Liu <sdl.web@gmail.com>
1696
1697 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1698
e61124cd
YM
16992011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1700
1701 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1702
1703 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1704 for fringe update if it has periodic bitmap.
1705 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1706 and fringe_bitmap_periodic_p.
1707
1708 * fringe.c (get_fringe_bitmap_data): New function.
1709 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1710 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1711 row. Mark glyph row for fringe update if periodicity changed.
1712
1713 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1714 for fringe update unless it has periodic bitmap.
1715
f16d9837
KH
17162011-05-25 Kenichi Handa <handa@m17n.org>
1717
1718 * xdisp.c (get_next_display_element): Set correct it->face_id for
1719 a static composition.
1720
e1b90ef6
LL
17212011-05-24 Leo Liu <sdl.web@gmail.com>
1722
1723 * deps.mk (fns.o):
1724 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1725
1726 * fns.c (crypto_hash_function, Fsha1): New function.
1727 (Fmd5): Use crypto_hash_function.
1728 (syms_of_fns): Add Ssha1.
1729
7400048f
PE
17302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 * gnutls.c: Remove unused macros.
1733 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1734 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1735 Remove macros that are defined and never used.
1736 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1737
abb71cf4
CY
17382011-05-22 Chong Yidong <cyd@stupidchicken.com>
1739
1740 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1741 (Fx_get_selection_internal): Minor cleanup.
1742 (Fx_own_selection_internal): Rename arguments for consistency with
1743 select.el.
1744
6307db39
PE
17452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1746
1747 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1748
f3d4e0a4
CY
17492011-05-22 Chong Yidong <cyd@stupidchicken.com>
1750
1751 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1752
4d8ade89
YM
17532011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1754
1755 * dispnew.c (scrolling_window): Don't exclude the case that the
1756 last enabled row in the desired matrix touches the bottom boundary.
1757
32078c8d
GM
17582011-05-21 Glenn Morris <rgm@gnu.org>
1759
1760 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1761 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1762 and add some more files.
32078c8d 1763
7285dc67
EZ
17642011-05-20 Eli Zaretskii <eliz@gnu.org>
1765
1766 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1767 report_file_error introduced by the change from 2011-05-07.
1768
89d1bd22
PE
17692011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1770
1771 * systime.h (Time): Define only if emacs is defined.
1772 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1773 where the include path doesn't have X11/X.h by default. See
1774 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1775
e23640bb 17762011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1777
1778 * composite.c (find_automatic_composition): Fix previous change.
1779
b9704ad9
GM
17802011-05-20 Glenn Morris <rgm@gnu.org>
1781
1782 * lisp.mk: New file, split from Makefile.in.
1783 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1784 (shortlisp): Remove.
1785 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1786
4a720484
GM
17872011-05-19 Glenn Morris <rgm@gnu.org>
1788
1789 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1790 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1791 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1792 (lisp): Set the order to that of loadup.el.
1793 (shortlisp): Make it a copy of $lisp.
1794 (SOME_MACHINE_LISP): Remove.
1795 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1796 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1797
a28d4396
KH
17982011-05-18 Kenichi Handa <handa@m17n.org>
1799
1800 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1801 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1802 (find_automatic_composition): Mostly rewrite for efficiency.
1803
a2b1fa8e
JB
18042011-05-18 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * makefile.w32-in: Update dependencies.
1807
8e1f5610
CS
18082011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1809
1810 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1811 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1812
7025ee00 18132011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1814
cdfa6eab
PE
1815 Fix some integer overflow issues, such as string length overflow.
1816
06d6db33
PE
1817 * insdel.c (count_size_as_multibyte): Check for string overflow.
1818
2b4560a8
PE
1819 * character.c (lisp_string_width): Check for string overflow.
1820 Use EMACS_INT, not int, for string indexes and lengths; in
1821 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1822 the resulting string length overflows an EMACS_INT; instead,
1823 report a string overflow if no precision given. When checking for
1824 precision exhaustion, use a check that cannot possibly have
1825 integer overflow. (Bug#8675)
1826 * character.h (lisp_string_width): Adjust to new signature.
1827
cb93f9be
PE
1828 * alloc.c (string_overflow): New function.
1829 (Fmake_string): Use it. This doesn't change behavior, but saves
1830 a few bytes and will simplify future changes.
1831 * character.c (string_escape_byte8): Likewise.
1832 * lisp.h (string_overflow): New decl.
1833
1a1f3366
PE
1834 Fixups, following up to the user-interface timestamp change.
1835 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1836 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1837 * msdos.c (mouse_get_pos): Likewise.
1838 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1839 * w32gui.h (Time): Define by including "systime.h" rather than by
1840 declaring it ourselves. (Bug#8664)
1841
d4e3e4d3
PE
1842 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1843 * image.c (clear_image_cache): Likewise.
1844
f6a24d19
PE
1845 * term.c (term_mouse_position): Don't assume time_t wraparound.
1846
08dc5ae6
PE
1847 Be more systematic about user-interface timestamps.
1848 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1849 and sometimes 'EMACS_UINT', to represent these timestamps.
1850 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1851 This makes the code easier to follow, and makes it easier to catch
1852 integer overflow bugs such as Bug#8664.
1853 * frame.c (Fmouse_position, Fmouse_pixel_position):
1854 Use Time, not unsigned long, for user-interface timestamps.
1855 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1856 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1857 * keyboard.h (last_event_timestamp): Likewise.
1858 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1859 * menu.h (xmenu_show): Likewise.
1860 * term.c (term_mouse_position): Likewise.
1861 * termhooks.h (struct input_event.timestamp): Likewise.
1862 (struct terminal.mouse_position_hook): Likewise.
1863 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1864 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1865 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1866 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1867 what it was before.
1868 * menu.h, termhooks.h: Include "systime.h", for Time.
1869
8e55734a
PE
1870 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1871 Don't assume that the difference between two unsigned long values
1872 can fit into an integer. At this point, we know button_down_time
1873 <= event->timestamp, so the difference must be nonnegative, so
1874 there's no need to cast the result if double-click-time is
1875 nonnegative, as it should be; check that it's nonnegative, just in
1876 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1877 apart (about 25 days). (Bug#8664)
8e55734a 1878
841f1b75 1879 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1880 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1881
3e26f69c
PE
1882 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1883 that always fit in int. Use a sentinel instead of a counter, to
1884 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1885 * frame.h (struct frame): Use int for menu_bar_items_used
1886 instead of EMACS_INT, since it always fits in int.
3e26f69c 1887
5cc152c0
PE
1888 * menu.c (grow_menu_items): Check for int overflow.
1889
d89eb65e
PE
1890 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1891
5235bd3e
PE
1892 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1893 Before, the code was not consistent. These values cannot exceed
1894 2**31 - 1 so there's no need to make them unsigned.
1895 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1896 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1897 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1898 as modifiers.
1899 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1900
bc827e23
PE
1901 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1902 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1903 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1904 presumably because the widths might not match.
1905
78eb494e
PE
1906 * window.c (size_window): Avoid needless test at loop start.
1907
04f2d78b
CB
19082011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1909
1910 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1911
d2fc7e3d 19122011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1913
1914 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1915
d2fc7e3d 19162011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1917
1918 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1919 `width' to `bar_area_x' and `bar_area_width', respectively.
1920 (x_scroll_run): Take account of fringe background extension.
1921
04f2d78b
CB
1922 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1923 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1924 `bar_area_width', respectively.
1925 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1926 background extension.
1927
79b70037
GM
19282011-05-10 Jim Meyering <meyering@redhat.com>
1929
1930 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1931
2f142cc5
JB
19322011-05-10 Juanma Barranquero <lekktu@gmail.com>
1933
1934 * image.c (Finit_image_library): Return t for built-in image types,
1935 like pbm and xbm. (Bug#8640)
1936
57679c86
AS
19372011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1938
1939 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1940
888c9e86
EZ
19412011-05-07 Eli Zaretskii <eliz@gnu.org>
1942
b0512a1d
EZ
1943 * w32console.c (Fset_screen_color): Doc fix.
1944 (Fget_screen_color): New function.
1945 (syms_of_ntterm): Defsubr it.
1946
7285dc67
EZ
1947 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1948 unlink the temporary file if Fcall_process didn't create it in the
1949 first place.
1950 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1951 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1952 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1953 cue to call_process_cleanup not to close that handle.
1954
4d3fcc8e
BK
19552011-05-07 Ben Key <bkey76@gmail.com>
1956
1957 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1958 one of two shell specific rules, either bootstrap-temacs-CMD or
1959 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1960 to the previous implementation of the bootstrap-temacs rule.
1961 The bootstrap-temacs-CMD rule is similar to the previous
1962 implementation of the bootstrap-temacs rule except that it
1963 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1964 variable.
1965
1966 These changes, along with some changes to nt/configure.bat,
1967 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1968 earlier fix to add support for --cflags and --ldflags options
1969 that include quotes so that it works whether make uses cmd or
1970 sh as the shell.
1971
b4289b64
MA
19722011-05-06 Michael Albinus <michael.albinus@gmx.de>
1973
1974 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1975 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1976 is a constant.
1977 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1978 a string. Handle both cases.
1979 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1980 (Fdbus_register_method): Use Qinvalid_function.
1981
af4c0e28
JB
19822011-05-06 Juanma Barranquero <lekktu@gmail.com>
1983
1984 * makefile.w32-in: Update dependencies.
1985 (LISP_H): Add inttypes.h and stdin.h.
1986 (PROCESS_H): Add unistd.h.
1987
c51453d9
EZ
19882011-05-06 Eli Zaretskii <eliz@gnu.org>
1989
1990 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1991 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1992
8ff0ac3c 19932011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1994
4c4b566b
PE
1995 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1996
aab2b9b5
PE
1997 * term.c (vfatal): Remove stray call to va_end.
1998 It's not needed and the C Standard doesn't allow it here anyway.
1999
c378da0b
PE
2000 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2001 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2002
288b08c7
PE
2003 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2004 bytes.
2005
e3601888
PE
2006 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2007
db6c0e74
PE
2008 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2009
dd5963ea
PE
2010 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2011
88c9450f
PE
2012 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2013
2f9442b8
PE
2014 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2015
c032b5f8
PE
2016 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2017 * charset.c (Fdefine_charset_internal): Don't initialize
2018 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2019 32-bit int (Bug#8600).
a108c10b
PE
2020
2021 * lread.c (read_integer): Be more consistent with string-to-number.
2022 Use string_to_number to do the actual conversion; this avoids
2023 rounding errors and fixes some other screwups. Without this fix,
2024 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2025 (digit_to_number): Move earlier, for benefit of read_integer.
2026 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2027 not a digit in any supported base. (Bug#8602)
a108c10b 2028
ad5f9eea
PE
2029 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2030
aec1708a
PE
2031 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2032 to match comment at start of function. This also removes a
2033 GCC warning about overflow in a 32+64-bit port.
2034
47be4ab5
PE
2035 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2036
371cac43
PE
2037 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2038 Reported by Stefan Monnier in
2039 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2040 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2041 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2042
d01a7826
PE
2043 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2044 (EMACS_UINTPTR): Likewise, with uintptr_t.
2045
7fd47d5c
PE
2046 * lisp.h: Prefer 64-bit EMACS_INT if available.
2047 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2048 on 32-bit hosts that have 64-bit int, so that they can access
2049 large files.
122b0c86
PE
2050 However, temporarily disable this change unless the temporary
2051 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2052
8727937b
PE
2053 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2054
8ac068ac
PE
2055 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2056 This removes an assumption that EMACS_INT and long are the same
2057 width as pointers. The assumption is true for Emacs porting targets
2058 now, but we want to make other targets possible.
2059 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2060 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2061 In the rest of the code, change types of integers that hold casted
2062 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2063 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2064 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2065 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2066 No need to cast type when ORing.
2067 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2068 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2069 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2070 assume EMACS_INT is the same width as char *.
2071 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2072 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2073 Remove no-longer-needed casts.
2074 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2075 (xg_tool_bar_help_callback, xg_make_tool_item):
2076 Use EMACS_INTPTR to hold an integer
2077 that will be cast to void *; this can avoid a GCC warning
2078 if EMACS_INT is not the same width as void *.
2079 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2080 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2081 (current_message_1, set_message_1):
2082 Use a local to convert to proper width without a cast.
2083 * xmenu.c (dialog_selection_callback): Likewise.
2084
ede49d71
PE
2085 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2086 Also, don't assume VALBITS / RAND_BITS is less than 5,
2087 and don't rely on undefined behavior when shifting a 1 left into
2088 the sign bit.
2089 * lisp.h (get_random): Change signature to match.
2090
2f30ecd0
PE
2091 * lread.c (hash_string): Use size_t, not int, for hash computation.
2092 Normally we prefer signed values; but hashing is special, because
2093 it's better to use unsigned division on hash table sizes so that
2094 the remainder is nonnegative. Also, size_t is the natural width
2095 for hashing into memory. The previous code used 'int', which doesn't
2096 retain enough info to hash well into very large tables.
2097 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2098
2a866e7b
PE
2099 * dbusbind.c: Don't possibly lose pointer info when converting.
2100 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2101 Use XPNTR rather than XHASH, so that the high-order bits of
2102 the pointer aren't lost when converting through void *.
2103
51639eac
PE
2104 * eval.c (Fautoload): Don't double-shift a pointer.
2105
92394119
PE
2106 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2107
dbdb9a7c
JB
21082011-05-06 Juanma Barranquero <lekktu@gmail.com>
2109
2110 * gnutls.c (DEF_GNUTLS_FN):
2111 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2112
db7a0b4f
AS
21132011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2114
2115 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2116 marker. (Bug#8610)
2117
f7ff1b0f 21182011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2119
2120 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2121 New version that can reserve upto 2GB of heap space.
2122
f7ff1b0f 21232011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2124
2125 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2126
639c109b
TZ
21272011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2128
2129 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2130 `gnutls_certificate_set_x509_key_file'.
2131
d2127135
JB
21322011-05-05 Juanma Barranquero <lekktu@gmail.com>
2133
2134 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2135 Update dependencies.
2136
e968f4f3
JB
21372011-05-04 Juanma Barranquero <lekktu@gmail.com>
2138
2139 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2140 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2141 Remove unused parameter `fildes'.
2142 * process.c (read_process_output, send_process): Don't pass it.
2143
84d358f0
JB
21442011-05-04 Juanma Barranquero <lekktu@gmail.com>
2145
2146 Fix previous change: the library cache is defined in w32.c.
2147 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2148 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2149
0898ca10
JB
21502011-05-04 Juanma Barranquero <lekktu@gmail.com>
2151
2152 Implement dynamic loading of GnuTLS on Windows.
2153
2154 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2155 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2156 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2157 Declare.
2158
2159 * gnutls.c (Qgnutls_dll): Define.
2160 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2161 (gnutls_*): Declare function pointers.
2162 (init_gnutls_functions): New function to initialize function pointers.
2163 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2164 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2165 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2166 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2167 (emacs_gnutls_write, emacs_gnutls_read)
2168 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2169 (Fgnutls_available_p): New function.
2170 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2171 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2172 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2173
2174 * image.c: Include w32.h.
2175 (Vimage_type_cache): Delete.
2176 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2177 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2178 (w32_delayed_load): Move to w32.c.
2179
2180 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2181
2182 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2183 (w32_delayed_load): Move from image.c. When loading a library, record
2184 its filename in the :loaded-from property of the library id.
2185 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2186 Initialize and staticpro them.
2187 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2188
2189 * process.c: Include lisp.h before w32.h, not after.
2190 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2191 instead of gnutls_record_check_pending.
2192
2193 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2194
ff4de4aa
TZ
21952011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2196
2197 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2198 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2199 as passed in.
2200
abe95abb
JD
22012011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2202
2203 * xterm.c (x_set_frame_alpha): Do not set property on anything
2204 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2205
e16e55d4
JB
22062011-05-02 Juanma Barranquero <lekktu@gmail.com>
2207
2208 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2209
bafcf6a5
JB
22102011-05-02 Juanma Barranquero <lekktu@gmail.com>
2211
2212 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2213 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2214 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2215 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2216 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2217 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2218 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2219 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2220 (Qgnutls_bootprop_callbacks_verify): Make static.
2221
e7a6747f
AS
22222011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2223
19ed11ba
AS
2224 * callproc.c: Indentation fixup.
2225
e7a6747f 2226 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2227 (wait_for_termination, interruptible_wait_for_termination):
2228 Move after wait_for_termination_1.
e7a6747f 2229
1ef14cb4
LMI
22302011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2231
2232 * sysdep.c (interruptible_wait_for_termination): New function
2233 which is like wait_for_termination, but allows keyboard
2234 interruptions.
2235
2236 * callproc.c (Fcall_process): Add (:file "file") as an option for
2237 the STDOUT buffer.
2238 (Fcall_process_region): Ditto.
2239
330d880c
EZ
22402011-04-30 Eli Zaretskii <eliz@gnu.org>
2241
8db90b73
EZ
2242 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2243 rather than `XVECTOR (FOO)->size'.
2244
330d880c
EZ
2245 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2246 inttypes.h, as a gnulib replacement is used if it not available in
2247 system headers.
2248
15cbd324
EZ
22492011-04-21 Eli Zaretskii <eliz@gnu.org>
2250
2251 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2252 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2253 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2254
2255 * coding.c (coding_alloc_by_realloc): Error out if destination
2256 will grow beyond MOST_POSITIVE_FIXNUM.
2257 (decode_coding_emacs_mule): Abort if there isn't enough place in
2258 charbuf for the composition carryover bytes. Reserve an extra
2259 space for up to 2 characters produced in a loop.
2260 (decode_coding_iso_2022): Abort if there isn't enough place in
2261 charbuf for the composition carryover bytes.
2262
22632011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2264
ae940cca
EZ
2265 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2266 aborting when %lld or %lll format is passed.
2267 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2268 %llo or %llx format is passed. (Bug#8545)
2269
03ab8921
EZ
2270 * window.c (window_scroll_line_based): Use a marker instead of
2271 simple variables to record original value of point. (Bug#7952)
2272
afda1437
EZ
2273 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2274 produced by %s or %c overflows available buffer space. (Bug#8545)
2275
f76dee0c
PE
22762011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2277
2278 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2279 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2280
fdc5744d
JB
22812011-04-28 Juanma Barranquero <lekktu@gmail.com>
2282
2283 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2284
638f053a
JB
22852011-04-28 Juanma Barranquero <lekktu@gmail.com>
2286
2287 * keyboard.c (Qdelayed_warnings_hook): Define.
2288 (command_loop_1): Run `delayed-warnings-hook'
2289 if Vdelayed_warnings_list is non-nil.
2290 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2291 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2292
d178f871
EZ
22932011-04-28 Eli Zaretskii <eliz@gnu.org>
2294
2295 * doprnt.c (doprnt): Don't return value smaller than the buffer
2296 size if the message was truncated. (Bug#8545).
2297
b124fd93
JB
22982011-04-28 Juanma Barranquero <lekktu@gmail.com>
2299
2300 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2301 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2302
e810457d
PE
23032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2304
2305 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2306
ea51cceb
JB
23072011-04-27 Juanma Barranquero <lekktu@gmail.com>
2308
2309 * makefile.w32-in: Update dependencies.
2310
94dcfacf
EZ
23112011-04-27 Eli Zaretskii <eliz@gnu.org>
2312
2313 Improve `doprnt' and its usage. (Bug#8545)
2314 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2315 `format_end'. Remove support for %l as a conversion specifier.
2316 Don't use xrealloc. Improve diagnostics when the %l size modifier
2317 is used. Update the commentary.
2318
2319 * eval.c (verror): Simplify calculation of size_t.
2320
2321 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2322 messages.
2323
f61f41d7
PE
23242011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2325
2326 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2327 change.
2328
96fb4434
PE
23292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2332 This makes this file independent of the recent pseudovector change.
2333
671875da 23342011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2335
69e9b5a3
PE
2336 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2337
b5f869a7 2338 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2339 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2340 Remove unused local.
c8926152 2341 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2342
841a1577 2343 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2344 GCC 4.6.0 optimizes based on type-based alias analysis.
2345 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2346 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2347 != &v->size, and therefore "v->size = 1; b->size = 2; return
2348 v->size;" must therefore return 1. This assumption is incorrect
2349 for Emacs, since it type-puns struct Lisp_Vector * with many other
2350 types. To fix this problem, this patch adds a new type struct
f904488f 2351 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2352 and pseudovectors, and helps optimizing compilers not get fooled
2353 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2354 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2355 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2356 the size member.
eab3844f
PE
2357 (XSETPVECTYPE): Rewrite in terms of new macro.
2358 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2359 This is a bit clearer, and further avoids the possibility of
2360 undesirable aliasing.
2361 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2362 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2363 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2364 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2365 (ASIZE): Now uses header.size rather than size.
2366 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2367 to avoid the hassle of writing XVECTOR (foo)->header.size.
2368 (struct vectorlike_header): New type.
eab3844f
PE
2369 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2370 object, to help avoid aliasing.
2371 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2372 (SUBRP): Likewise, since Lisp_Subr is a special case.
2373 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2374 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2375 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2376 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2377 changed to be "header.size" and "header.next".
2378 * buffer.h (struct buffer): Likewise.
2379 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2380 * frame.h (struct frame): Likewise.
2381 * process.h (struct Lisp_Process): Likewise.
2382 * termhooks.h (struct terminal): Likewise.
2383 * window.c (struct save_window_data, struct saved_window): Likewise.
2384 * window.h (struct window): Likewise.
2385 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2386 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2387 * buffer.c (init_buffer_once): Likewise.
2388 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2389 special case.
2390 * process.c (Fformat_network_address): Use local var for size,
2391 for brevity.
2392
0df1eac5
PE
2393 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2394
847ab9d1 2395 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2396 * data.c (atof): Remove decl; no longer used or needed.
2397 (digit_to_number): Move to lread.c.
2398 (Fstring_to_number): Use new string_to_number function, to be
2399 consistent with how the Lisp reader treats infinities and NaNs.
2400 Do not assume that floating-point numbers represent EMACS_INT
2401 without losing information; this is not true on most 64-bit hosts.
2402 Avoid double-rounding errors, by insisting on integers when
2403 parsing non-base-10 numbers, as the documentation specifies.
2404 * lisp.h (string_to_number): New decl, replacing ...
2405 (isfloat_string): Remove.
bc0a5c13 2406 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2407 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2408 appears to have been a coding error. Similarly, do not accept
2409 strings like +-1e0 as floating point numbers. Do not report
2410 overflow for integer overflows unless the base is not 10 which
2411 means we have no simple and reliable way to continue.
2412 Break out the floating-point parsing into a new
2413 function string_to_number, so that Fstring_to_number parses
2414 floating point numbers consistently with the Lisp reader.
04f2d78b 2415 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2416 (E_CHAR, EXP_INT): Remove, replacing with ...
2417 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2418 (string_to_number): New function, replacing isfloat_string.
2419 This function checks for valid syntax and produces the resulting
2420 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2421 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2422 so that overflow for non-base-10 numbers is reported only when
2423 there's no portable and simple way to convert to floating point.
452f4150 2424
67769ffc
PE
2425 * textprop.c (set_text_properties_1): Rewrite for clarity,
2426 and to avoid GCC warning about integer overflow.
2427
c20db43f
PE
2428 * intervals.h (struct interval): Use EMACS_INT for members
2429 where EMACS_UINT might cause problems. See
2430 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2431 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2432 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2433 All uses changed.
37aa2f85
PE
2434 (offset_intervals): Tell GCC not to worry about length overflow
2435 when negating a negative length.
c20db43f 2436
2538aa2f
PE
2437 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2438 (overrun_check_free): Likewise.
2439
f2d3008d
PE
2440 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2441 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2442 word size.
2443
ec8df744
PE
2444 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2445 (gnutls_make_error): Rename local to avoid shadowing.
2446 (gnutls_emacs_global_deinit): ifdef out; not used.
2447 (Fgnutls_boot): Use const for pointer to readonly storage.
2448 Comment out unused local. Fix pointer signedness problems.
2449
640ee02d
PE
2450 * lread.c (openp): Don't stuff size_t into an 'int'.
2451 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2452 about possible signed overflow.
2453
6048fb2a
PE
2454 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2455 (GDK_KEY_g): Don't define if already defined.
2456 (xg_prepare_tooltip): Avoid pointer signedness problem.
2457 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2458
fa3c87e1
PE
2459 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2460 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2461
2172544b
PE
2462 * xfns.c (Fx_window_property): Simplify a bit,
2463 to make a bit faster and to avoid GCC 4.6.0 warning.
2464 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2465
9b821a21
PE
2466 * fns.c (internal_equal): Don't assume size_t fits in int.
2467
3c616cfa
PE
2468 * alloc.c (compact_small_strings): Tighten assertion a little.
2469
c2982e87
PE
2470 Replace pEd with more-general pI, and fix some printf arg casts.
2471 * lisp.h (pI): New macro, generalizing old pEd macro to other
2472 conversion specifiers. For example, use "...%"pI"d..." rather
2473 than "...%"pEd"...".
2474 (pEd): Remove. All uses replaced with similar uses of pI.
2475 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2476 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2477 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2478 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2479 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2480 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2481 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2482 64-bit hosts.
2483 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2484 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2485 * print.c (safe_debug_print, print_object): Likewise.
2486 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2487 to int.
6f04d126
PE
2488 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2489 avoiding the 0 flag, which is not portable.
c2982e87
PE
2490 * process.c (Fmake_network_process): Use pI to avoid cast.
2491 * region-cache.c (pp_cache): Likewise.
2492 * xdisp.c (decode_mode_spec): Likewise.
2493 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2494 behavior on 64-bit hosts with printf arg.
6f04d126 2495 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2496 (x_stop_queuing_selection_requests): Likewise.
2497 (x_get_window_property): Don't truncate byte count to an 'int'
2498 when tracing.
0b432f21 2499
5e073ec7
PE
2500 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2501 here, since it parses constructs like leading '-' and spaces,
2502 which are not wanted; and it overflows with large numbers.
2503 Instead, simply match F[0-9]+, which is what is wanted anyway.
2504
36372bf9
PE
2505 * alloc.c: Remove unportable assumptions about struct layout.
2506 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2507 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2508 (allocate_vectorlike, make_pure_vector): Use the new macros,
2509 plus offsetof, to remove unportable assumptions about struct layout.
2510 These assumptions hold on all porting targets that I know of, but
2511 they are not guaranteed, they're easy to remove, and removing them
2512 makes further changes easier.
2513
0b432f21
PE
2514 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2515 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2516 (string_overrun_cookie): Now const. Use initializers that
2517 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2518 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2519 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2520 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2521 multiple of sizeof (EMACS_INT); it need not be, if
2522 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2523 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2524
895009e1
JB
25252011-04-26 Juanma Barranquero <lekktu@gmail.com>
2526
2527 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2528
6a7a1b0b
TZ
25292011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2530
2531 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2532 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2533 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2534
841a1577 25352011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2536
2537 * lisp.h (Qdebug): List symbol.
895009e1 2538 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2539 * keyboard.c (debug-on-event): New variable.
2540 (handle_user_signal): Break into debugger when debug-on-event
2541 matches the current signal symbol.
2542
f2d3ba6f
DN
25432011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2544
2545 * alloc.c (check_sblock, check_string_bytes)
2546 (check_string_free_list): Convert to standard C.
2547
42ce4c63
TZ
25482011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2549
2550 * w32.c (emacs_gnutls_push): Fix typo.
2551
825cd63c
EZ
25522011-04-25 Eli Zaretskii <eliz@gnu.org>
2553
fb11d64d
EZ
2554 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2555 "cast to pointer from integer of different size".
2556
825cd63c
EZ
2557 Improve doprnt and its use in verror. (Bug#8545)
2558 * doprnt.c (doprnt): Document the set of format control sequences
2559 supported by the function. Use SAFE_ALLOCA instead of always
2560 using `alloca'.
2561
2562 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2563 is one byte too soon. Don't use xrealloc; instead xfree and
2564 xmalloc anew.
2565
e061a11b
TZ
25662011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2567
2568 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2569 callbacks stage.
2570
2571 * gnutls.c: Renamed global_initialized to
2572 gnutls_global_initialized. Added internals for the
2573 :verify-hostname-error, :verify-error, and :verify-flags
2574 parameters of `gnutls-boot' and documented those parameters in the
2575 docstring. Start callback support.
2576 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2577 unless a fatal error occured. Call gnutls_alert_send_appropriate
2578 on error. Return error code.
2579 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2580 (emacs_gnutls_read): Likewise.
2581 (Fgnutls_boot): Return handshake error code.
2582 (emacs_gnutls_handle_error): New function.
2583 (wsaerror_to_errno): Likewise.
2584
2585 * w32.h (emacs_gnutls_pull): Add prototype.
2586 (emacs_gnutls_push): Likewise.
2587
2588 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2589 (emacs_gnutls_push): Likewise.
2590
25912011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2592
2593 * process.c (wait_reading_process_output): Check if GnuTLS
2594 buffered some data internally if no FDs are set for TLS
2595 connections.
2596
2597 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2598 (LIBS): Link to USER_LIBS.
2599 ($(BLD)/gnutls.$(0)): New target.
2600
fa6996bc
EZ
26012011-04-24 Eli Zaretskii <eliz@gnu.org>
2602
eb35682e
EZ
2603 * xdisp.c (handle_single_display_spec): Rename the
2604 display_replaced_before_p argument into display_replaced_p, to
2605 make it consistent with the commentary. Fix typos in the
2606 commentary.
2607
e2ad650c
EZ
2608 * textprop.c (syms_of_textprop): Remove dead code.
2609 (copy_text_properties): Delete obsolete commentary about an
2610 interface that was deleted long ago. Fix typos in the description
2611 of arguments.
2612
1b2de274
EZ
2613 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2614 to changes in oldXMenu/XMenu.h from 2011-04-16.
2615 <menu_help_message, prev_menu_help_message>: Constify.
2616 (IT_menu_make_room): menu->help_text is now `const char **';
2617 adjust.
2618
2619 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2620 to changes in oldXMenu/XMenu.h from 2011-04-16.
2621 (struct XMenu): Declare `help_text' `const char **'.
2622
2623 * xfaces.c <Qunspecified>: Make extern again.
2624
2625 * syntax.c: Include sys/types.h before including regex.h, as
2626 required by Posix.
2627
762b15be
EZ
2628 * doc.c (get_doc_string): Improve the format passed to `error'.
2629
2630 * doprnt.c (doprnt): Improve commentary.
2631
2632 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2633
2634 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2635 them with etags.
2636
f1052e5d
EZ
2637 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2638 changes in globals.h immediately force recompilation.
762b15be
EZ
2639 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2640 $(CURDIR)/s/ms-w32.h.
2641 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2642
fa6996bc
EZ
2643 * character.c (Fchar_direction): Function deleted.
2644 (syms_of_character): Don't defsubr it.
2645 <char-direction-table>: Deleted.
2646
e6c3da20
EZ
26472011-04-23 Eli Zaretskii <eliz@gnu.org>
2648
2649 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2650 * doprnt.c: Include limits.h.
2651 (SIZE_MAX): New macro.
04f2d78b
CB
2652 (doprnt): Return a size_t value. 2nd arg is now size_t.
2653 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2654 Improve overflow protection. Support `l' modifier for integer
2655 conversions. Support %l conversion. Don't assume an EMACS_INT
2656 argument for integer conversions and for %c.
2657
2658 * lisp.h (doprnt): Restore prototype.
2659
2660 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2661 $(SRC)/character.h.
2662
2663 * Makefile.in (base_obj): Add back doprnt.o.
2664
2665 * deps.mk (doprnt.o): Add back prerequisites.
2666 (callint.o): Depend on character.h.
2667
2668 * eval.c (internal_lisp_condition_case): Include the handler
2669 representation in the error message.
2670 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2671 when breaking from the loop.
2672
2673 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2674
2675 * callint.c (Fcall_interactively): When displaying error message
2676 about invalid control letter, pass the character's codepoint, not
2677 a pointer to its multibyte form. Improve display of the character
2678 in octal and display also its hex code.
2679
2680 * character.c (char_string): Use %x to display the (unsigned)
2681 codepoint of an invalid character, to avoid displaying a bogus
2682 negative value.
2683
2684 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2685 `error', not SYMBOL_NAME itself.
2686
2687 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2688 character arguments to `error'.
2689
2690 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2691 to `error' in error message about FINAL_CHAR argument. Make sure
2692 FINAL_CHAR is a character, and use %c when it is passed as
2693 argument to `error'.
2694
4ffd0d6b 26952011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2696
2697 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2698
2699 * w32.c: Include <time.h>.
2700 (sys_localtime): New function.
2701
4ffd0d6b 27022011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2703
2704 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2705
4ffd0d6b 2706 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2707
4ffd0d6b 27082011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2709
4ffd0d6b
GM
2710 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2711 zombies (Bug#8467).
aac0c6e3 2712
04c56954
EZ
27132011-04-19 Eli Zaretskii <eliz@gnu.org>
2714
2715 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2716 gl_state.e_property when gl_state.object is Qt.
2717
2718 * insdel.c (make_gap_larger): Remove limitation of buffer size
2719 to <= INT_MAX.
2720
16a43933
CY
27212011-04-18 Chong Yidong <cyd@stupidchicken.com>
2722
2723 * xdisp.c (lookup_glyphless_char_display)
2724 (produce_glyphless_glyph): Handle cons cell entry in
2725 glyphless-char-display.
2726 (Vglyphless_char_display): Document it.
2727
2728 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2729 glyphless-char-display.
2730
4581706e
CY
27312011-04-17 Chong Yidong <cyd@stupidchicken.com>
2732
2733 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2734
2735 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2736
2737 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2738 definition for no-X builds.
2739
4887c6e2 27402011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2741
fd35b6f9
PE
2742 Static checks with GCC 4.6.0 and non-default toolkits.
2743
5c1ccb01
PE
2744 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2745
006c5daa
PE
2746 * process.c (keyboard_bit_set): Define only if SIGIO.
2747 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2748 (send_process): Repair possible setjmp clobbering.
2749
efc736d3
PE
2750 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2751
4e2fe2e6
PE
2752 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2753
f97334a2
PE
2754 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2755
4e75f29d
PE
2756 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2757 Define only if needed.
2758
90efadd1
PE
2759 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2760 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2761 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2762
3c647824
PE
2763 * dispextern.h (struct redisplay_interface): Rename param
2764 to avoid shadowing.
e264f262 2765 * termhooks.h (struct terminal): Likewise.
761383f4 2766 * xterm.c (xembed_send_message): Likewise.
3c647824 2767
b58c5c4a
PE
2768 * insdel.c (make_gap_smaller): Define only if
2769 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2770
cad59032
PE
2771 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2772 it.
2773
c339dc2e
PE
2774 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2775 so that we aren't warned about unused symbols.
2776
91a3e27b
PE
2777 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2778
399c71d3 2779 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2780
8ffc96f5
PE
2781 * xfns.c (x_real_positions): Mark locals as initialized.
2782
eef9bc79
PE
2783 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2784
098db9dd
PE
2785 * xterm.c: Fix problems found by static analysis with other toolkits.
2786 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2787 (x_dispatch_event): Declare static if USE_GTK, and
2788 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2789 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2790 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2791 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2792 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2793
eb18f6cc
PE
2794 * xmenu.c (menu_help_callback): Pointer type fixes.
2795 Use const pointers when pointing at readonly data. Avoid pointer
2796 signedness clashes.
2797 (FALSE): Remove unused macro.
2798 (update_frame_menubar): Remove unused decl.
2799
1fe72bf8
PE
2800 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2801
60d9e1db
PE
2802 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2803 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2804 (single_menu_item): Rename local to avoid shadowing.
2805
39261c26
PE
2806 * keyboard.c (make_lispy_event): Remove unused local var.
2807
018c5e19
PE
2808 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2809 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2810
63d2b86e
PE
2811 * bitmaps: Change bitmaps from unsigned char back to the X11
2812 compatible char. Avoid the old compiler warnings about
2813 out-of-range initializers by using, for example, '\xab' rather
2814 than 0xab.
2815
aefd87e1
PE
2816 * xgselect.c (xgselect_initialize): Check vs interface
2817 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2818
bf501fb9
PE
2819 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2820
e9829fdf
PE
2821 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2822 to read-only memory.
2823
1086c095
PE
2824 * fns.c (vector): Remove; this old hack is no longer needed.
2825
2baccd04 2826 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2827 Remove unused var.
dde42981 2828 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2829
72391843 2830 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2831
436c16df 2832 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2833 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2834 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2835
92bb796d 2836 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2837 (x_term_init): Remove local to avoid shadowing.
92bb796d 2838
764430a3 2839 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2840
2841 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2842 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2843
d1dfb56c
EZ
28442011-04-16 Eli Zaretskii <eliz@gnu.org>
2845
c4354cb4
EZ
2846 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2847
d1dfb56c
EZ
2848 Fix regex.c, syntax.c and friends for buffers > 2GB.
2849 * syntax.h (struct gl_state_s): Declare character position members
2850 EMACS_INT.
2851
2852 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2853
04f2d78b
CB
2854 * textprop.c (verify_interval_modification, interval_of):
2855 Declare arguments EMACS_INT.
d1dfb56c
EZ
2856
2857 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2858 EMACS_INT.
2859
2860 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2861
2862 * indent.c (Fvertical_motion): Local variable it_start is now
2863 EMACS_INT.
2864
2865 * regex.c (re_match, re_match_2, re_match_2_internal)
2866 (bcmp_translate, regcomp, regexec, print_double_string)
2867 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2868 (re_compile_pattern, re_exec): Declare arguments and local
2869 variables `size_t' and `ssize_t' and return values `regoff_t', as
2870 appropriate.
2871 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2872 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2873 <compile_stack_type>: `size' and `avail' are now `size_t'.
2874
2875 * regex.h <regoff_t>: Use ssize_t, not int.
2876 (re_search, re_search_2, re_match, re_match_2): Arguments that
2877 specify buffer/string position and length are now ssize_t and
2878 size_t. Return type is regoff_t.
2879
613052cd
BK
28802011-04-16 Ben Key <bkey76@gmail.com>
2881
2882 * nsfont.m: Fixed bugs in ns_get_family and
2883 ns_descriptor_to_entity that were caused by using free to
2884 deallocate memory blocks that were allocated by xmalloc (via
2885 xstrdup). This caused Emacs to crash when compiled with
2886 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2887 --enable-checking=xmallocoverrun). xfree is now used to
2888 deallocate these memory blocks.
2889
4170f62f 28902011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2891
71b41406
PE
2892 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2893
9587a89d
PE
2894 emacs_write: Accept and return EMACS_INT for sizes.
2895 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2896 et seq.
2897 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2898 Accept and return EMACS_INT.
2899 (emacs_gnutls_write): Return the number of bytes written on
2900 partial writes.
2901 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2902 (emacs_read, emacs_write): Remove check for negative size, as the
2903 Emacs source code has been audited now.
9587a89d
PE
2904 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2905 (emacs_read, emacs_write): Use it.
273a5f82
PE
2906 * process.c (send_process): Adjust to the new signatures of
2907 emacs_write and emacs_gnutls_write. Do not attempt to store
2908 a byte offset into an 'int'; it might overflow.
9587a89d 2909 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2910
3e047f51
PE
2911 * sound.c: Don't assume sizes fit in 'int'.
2912 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2913 Return EMACS_INT, not int.
3e047f51 2914 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2915 Accept EMACS_INT, not int.
2916 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2917 record read return values.
2918
cc39a9db
BK
29192011-04-15 Ben Key <bkey76@gmail.com>
2920
c9d0ec6d
JB
2921 * keyboard.c (Qundefined): Don't declare static since it is used
2922 in nsfns.m.
2923 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2924 static since they are used in nsfont.m.
cc39a9db 2925
6c60eb9f
SM
29262011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2927
2928 * process.c (Qprocessp): Don't declare static.
2929 * lisp.h (Qprocessp): Declare again.
2930
7990b61a
JB
29312011-04-15 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2934
5d4cb038
PE
29352011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2936
8bd7b830 2937 Improve C-level modularity by making more things 'static'.
cd64ea1d 2938
e3b27b31
PE
2939 Don't publish debugger-only interfaces to other modules.
2940 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2941 (verify_bytepos, count_markers): Move decls to the only modules
2942 that need them.
2943 * region-cache.h (pp_cache): Likewise.
2944 * window.h (check_all_windows): Likewise.
2945 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2946
5d4cb038
PE
2947 * sysdep.c (croak): Now static, if
2948 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2949 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2950
2951 * alloc.c (refill_memory_reserve): Now static if
2952 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2953 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2954
e87b6180
PE
2955 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2956 Define only if USE_LUCID.
2957
ac64929e
PE
2958 * xrdb.c (x_customization_string, x_rm_string): Now static.
2959
6f37259d
PE
2960 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2961 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2962
1683e3ab
PE
2963 * xdisp.c (draw_row_with_mouse_face): Now static.
2964 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2965
de9c2632
PE
2966 * window.h (check_all_windows): Mark externally visible.
2967
2b96acb7
PE
2968 * window.c (window_deletion_count): Now static.
2969
2970 * undo.c: Make symbols static if they're not exported.
2971 (last_undo_buffer, last_boundary_position, pending_boundary):
2972 Now static.
2973
50436f33
PE
2974 * textprop.c (interval_insert_behind_hooks): Now static.
2975 (interval_insert_in_front_hooks): Likewise.
2976
64520e5c
PE
2977 * term.c: Make symbols static if they're not exported.
2978 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2979 (max_frame_lines, tty_set_terminal_modes):
2980 (tty_reset_terminal_modes, tty_turn_off_highlight):
2981 (get_tty_terminal): Now static.
2982 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2983 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2984 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2985 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2986 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2987
1fa53021
PE
2988 * sysdep.c: Make symbols static if they're not exported.
2989 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2990 Now static.
2991 (sigprocmask_set, full_mask): Remove; unused.
2992 (wait_debugging): Mark as visible.
2993 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2994 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2995
d4b43b22
PE
2996 * syntax.c (syntax_temp): Define only if !__GNUC__.
2997
b7c513d0
PE
2998 * sound.c (current_sound_device, current_sound): Now static.
2999
989b29ad
PE
3000 * search.c (searchbufs, searchbuf_head): Now static.
3001
13a55a78
PE
3002 * scroll.c (scroll_cost): Remove; unused.
3003 * dispextern.h (scroll_cost): Remove decl.
3004
de68a1fc
PE
3005 * region-cache.h (pp_cache): Mark as externally visible.
3006
40ccffa6
PE
3007 * process.c: Make symbols static if they're not exported.
3008 (process_tick, update_tick, create_process, chan_process):
3009 (Vprocess_alist, proc_buffered_char, datagram_access):
3010 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3011 (deactivate_process): Mark defn as static, as well as decl.
3012 * lisp.h (create_process): Remove decl.
3013 * process.h (chan_process, Vprocess_alist): Remove decls.
3014
ad64fc97
PE
3015 * print.c: Make symbols static if they're not exported.
3016 (print_depth, new_backquote_output, being_printed, print_buffer):
3017 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3018 (print_interval, print_number_index, initial_stderr_stream):
3019 Now static.
3020 * lisp.h (Fprinc): Remove decl.
3021 (debug_output_compilation_hack): Mark as externally visible.
3022
adddb265
PE
3023 * sysdep.c (croak): Move decl from here to syssignal.h.
3024 * syssignal.h (croak): Put it here, so the API can be checked when
3025 'croak' is called from dissociate_if_controlling_tty.
3026
1717ede2
PE
3027 * minibuf.c: Make symbols static if they're not exported.
3028 (minibuf_save_list, choose_minibuf_frame): Now static.
3029 * lisp.h (choose_minibuf_frame): Remove decl.
3030
fa5fb2bc
PE
3031 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3032
1e3890d1
PE
3033 * lread.c: Make symbols static if they're not exported.
3034 (read_objects, initial_obarray, oblookup_last_bucket_number):
3035 Now static.
3036 (make_symbol): Remove; unused.
3037 * lisp.h (initial_obarray, make_symbol): Remove decls.
3038
8a1414fa
PE
3039 * keyboard.c: Make symbols static if they're not exported.
3040 (single_kboard, recent_keys_index, total_keys, recent_keys):
3041 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3042 (this_single_command_key_start, echoing, last_auto_save):
3043 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3044 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3045 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3046 (Vlispy_mouse_stem, double_click_count):
3047 Now static.
3048 (force_auto_save_soon): Define only if SIGDANGER.
3049 (ignore_mouse_drag_p): Now static if
3050 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3051 (print_help): Remove; unused.
3052 (stop_character, last_timer_event): Mark as externally visible.
3053 * keyboard.h (ignore_mouse_drag_p): Declare only if
3054 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3055 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3056 * lisp.h (echoing): Remove decl.
3057 (force_auto_save_soon): Declare only if SIGDANGER.
3058 * xdisp.c (redisplay_window): Simplify code, to make it more
3059 obvious that ignore_mouse_drag_p is not accessed if !defined
3060 USE_GTK && !defined HAVE_NS.
3061
93ea6e8f
PE
3062 * intervals.c: Make symbols static if they're not exported.
3063 (merge_properties_sticky, merge_interval_right, delete_interval):
3064 Now static.
3065 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3066
77382fcc
PE
3067 * insdel.c: Make symbols static if they're not exported.
3068 However, leave prepare_to_modify_buffer alone. It's never
3069 called from outside this function, but that appears to be a bug.
3070 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3071 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3072 (adjust_after_replace_noundo): Remove; unused.
3073 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3074 (signal_before_change): Remove decls.
77382fcc 3075
9306c32e
PE
3076 * indent.c (val_compute_motion, val_vmotion): Now static.
3077
cd44d2eb
PE
3078 * image.c: Make symbols static if they're not exported.
3079 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3080 if USE_GTK.
3081 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3082 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3083
ad9a7a06
PE
3084 * fringe.c (standard_bitmaps): Now static.
3085 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3086
81626931
PE
3087 * frame.c: Make symbols static if they're not exported.
3088 (x_report_frame_params, make_terminal_frame): Now static.
3089 (get_frame_param): Now static, unless HAVE_NS.
3090 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3091 (x_get_resource_string): Remove; not used.
3092 * frame.h (make_terminal_frame, x_report_frame_params):
3093 (x_get_resource_string); Remove decls.
3094 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3095 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3096
239f9db9
PE
3097 * font.c, fontset.c: Make symbols static if they're not exported.
3098 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3099 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3100 * font.c (font_close_object): Now static.
3101 * font.h (font_close_object): Remove.
3102 * fontset.c (FONTSET_OBJLIST): Remove.
3103 (free_realized_fontset) #if-0 the body, which does nothing.
3104 (face_suitable_for_char_p): #if-0, as it's never called.
3105 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3106 * xfaces.c (face_at_string_position):
3107 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3108 since 0 is always ASCII.
3109
dfcf3579
PE
3110 * fns.c (weak_hash_tables): Now static.
3111
5045092b
PE
3112 * fileio.c: Make symbols static if they're not exported.
3113 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3114 (Vwrite_region_annotation_buffers): Now static.
3115
57a96f5c
PE
3116 * eval.c: Make symbols static if they're not exported.
3117 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3118 * lisp.h (backtrace_list): Remove decl.
3119
35f08c38
PE
3120 * emacs.c: Make symbols static if they're not exported.
3121 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3122 (fatal_error_code, fatal_error_signal_hook, standard_args):
3123 Now static.
3124 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3125 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3126 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3127 * lisp.h (fatal_error_signal_hook): Remove decl.
3128 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3129
f44bd759
PE
3130 * editfns.c: Move a (normally-unused) function to its only use.
3131 * editfns.c, lisp.h (get_operating_system_release): Remove.
3132 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3133 worth the hassle of breaking this out.
3134
b532497d
PE
3135 * xterm.c: Make symbols static if they're not exported.
3136 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3137 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3138 (x_destroy_window, x_delete_display):
3139 Now static.
3140 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3141 (x_mouse_leave): Remove; unused.
3142 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3143 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3144 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3145 Remove decls.
3146 (x_mouse_leave): Declare only if WINDOWSNT.
3147 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3148 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3149 USE_X_TOOLKIT.
3150
1675728f
PE
3151 * ftxfont.c: Make symbols static if they're not exported.
3152 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3153 HAVE_FREETYPE.
3154 * font.h (ftxfont_driver): Likewise.
3155
e4cebfca
PE
3156 * xfns.c: Make symbols static if they're not exported.
3157 (x_last_font_name, x_display_info_for_name):
3158 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3159 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3160 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3161 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3162 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3163 (last_show_tip_args): Now static.
3164 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3165 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3166 (x_screen_planes): Remove; unused.
3167 * dispextern.h (x_screen_planes): Remove decl.
3168
5bf46f05
PE
3169 * dispnew.c: Make symbols static if they're not exported.
3170 * dispextern.h (redraw_garbaged_frames, scrolling):
3171 (increment_row_positions): Remove.
3172 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3173 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3174 Now static.
3175 (redraw_garbaged_frames): Remove; unused.
3176
435f4c28
PE
3177 * xfaces.c: Make symbols static if they're not exported.
3178 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3179 Remove decls.
3180 * xterm.h (defined_color): Remove decls.
3181 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3182 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3183 (menu_face_changed_default, defined_color, free_realized_face):
3184 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3185 (ascii_face_of_lisp_face): Remove; unused.
3186
8524aef3
PE
3187 * xdisp.c: Make symbols static if they're not exported.
3188 * dispextern.h (scratch_glyph_row, window_box_edges):
3189 (glyph_to_pixel_coords, set_cursor_from_row):
3190 (get_next_display_element, set_iterator_to_next):
3191 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3192 (show_mouse_face): Remove decls
3193 * frame.h (message_buf_print): Likewise.
3194 * lisp.h (pop_message, set_message, check_point_in_composition):
3195 Likewise.
3196 * xterm.h (set_vertical_scroll_bar): Likewise.
3197 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3198 (message_buf_print, scratch_glyph_row, displayed_buffer):
3199 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3200 (get_next_display_element, show_mouse_face, window_box_edges):
3201 (frame_to_window_pixel_xy, check_point_in_composition):
3202 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3203 (glyph_to_pixel_coords): Remove; unused.
3204
16390cd2
PE
3205 * dired.c (file_name_completion): Now static.
3206
3207 * dbusbind.c (xd_in_read_queued_messages): Now static.
3208
a25f4dfa
PE
3209 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3210 * data.c (circular_list_error): Remove.
3211
14a9c8df
PE
3212 * commands.h (last_point_position, last_point_position_buffer):
3213 (last_point_position_window): Remove decls.
3214 * keyboard.c: Make these variables static.
3215
04f2d78b
CB
3216 * coding.h (coding, code_convert_region, encode_coding_gap):
3217 Remove decls.
74ab6df5
PE
3218 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3219 (iso_code_class, detect_coding, code_convert_region): Now static.
3220 (encode_coding_gap): Remove; unused.
3221
38dfbee1
PE
3222 * chartab.c (chartab_chars, chartab_bits): Now static.
3223
a2cb4e63
PE
3224 * charset.h (charset_iso_8859_1): Remove decl.
3225 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3226 Now static.
3227
127198fd
PE
3228 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3229 * ccl.c (Vccl_program_table): Now static.
3230 (check_ccl_update): Remove; unused.
3231
d85b608f
PE
3232 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3233 * category.h: ... from here.
3234 * category.c (check_category_table, set_category_set): Now static.
3235
31cd66f3
PE
3236 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3237 * lisp.h: Remove these decls.
3238
c358e587
PE
3239 * buffer.c (buffer_count): Remove unused var.
3240
e78aecca
PE
3241 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3242 so that it's not optimized away.
3243 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3244 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3245 exported only to the debugger.
3246
e192d7d3 3247 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3248 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3249
92470028
PE
3250 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3251 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3252 was inaccessible from Lisp.
3253 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3254 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3255
244ed907
PE
3256 alloc.c: Import and export fewer symbols, and remove unused items.
3257 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3258 is defined.
3259 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3260 it's not optimized away by whole-program optimization.
3261 (message_enable_multibyte, free_misc): Remove.
3262 (catchlist, handlerlist, mark_backtrace):
3263 Declare only if BYTE_MARK_STACK.
3264 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3265 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3266 (message_enable_multibyte): Remove decl.
3267 (free_misc, interval_free_list, float_block, float_block_index):
3268 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3269 (cons_free_list, last_marked_index):
3270 Now static.
3271 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3272 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3273 (mark_backtrace): Define only if BYTE_MARK_STACK.
3274 * xdisp.c (message_enable_multibyte): Now static.
3275
61c2b50e 3276 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3277 This makes it easier for human readers (and static analyzers)
3278 to see whether these variables are used from other modules.
3279 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3280 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3281 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3282 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3283 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3284 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3285 * xmenu.c, xselect.c:
3286 Declare Q* vars static if they are not used in other modules.
3287 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3288 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3289 Remove decls of unexported vars.
3290 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3291
95c82688
PE
3292 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3293
16a97296
PE
3294 Make Emacs functions such as Fatom 'static' by default.
3295 This makes it easier for human readers (and static analyzers)
3296 to see whether these functions can be called from other modules.
3297 DEFUN now defines a static function. To make the function external
3298 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3299 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3300 (Finit_image_library):
16a97296
PE
3301 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3302 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3303 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3304 Remove decls, since these functions are now static.
3305 (Funintern, Fget_internal_run_time): New decls, since these functions
3306 were already external.
95c82688 3307
16a97296
PE
3308 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3309 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3310 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3311 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3312 * keyboard.c, keymap.c, lread.c:
3313 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3314 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3315 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3316 Mark functions with DEFUE instead of DEFUN,
3317 if they are used in other modules.
3318 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3319 decls for now-static functions.
3320 * buffer.h (Fdelete_overlay): Remove decl.
3321 * callproc.c (Fgetenv_internal): Mark as internal.
3322 * composite.c (Fremove_list_of_text_properties): Remove decl.
3323 (Fcomposition_get_gstring): New forward static decl.
3324 * composite.h (Fcomposite_get_gstring): Remove decl.
3325 * dired.c (Ffile_attributes): New forward static decl.
3326 * doc.c (Fdocumntation_property): New forward static decl.
3327 * eval.c (Ffetch_bytecode): New forward static decl.
3328 (Funintern): Remove extern decl; now in .h file where it belongs.
3329 * fileio.c (Fmake_symbolic_link): New forward static decl.
3330 * image.c (Finit_image_library): New forward static decl.
3331 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3332 * intervals.h (Fprevious_property_change):
3333 (Fremove_list_of_text_properties): Remove decls.
3334 * keyboard.c (Fthis_command_keys): Remove decl.
3335 (Fcommand_execute): New forward static decl.
3336 * keymap.c (Flookup_key): New forward static decl.
3337 (Fcopy_keymap): Now static.
3338 * keymap.h (Flookup_key): Remove decl.
3339 * process.c (Fget_process): New forward static decl.
3340 (Fprocess_datagram_address): Mark as internal.
3341 * syntax.c (Fsyntax_table_p): New forward static decl.
3342 (skip_chars): Remove duplicate decl.
3343 * textprop.c (Fprevious_property_change): New forward static decl.
3344 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3345 Now internal.
3346 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3347 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3348
785bbd42
PE
3349 * editfns.c (Fformat): Remove unreachable code.
3350
8b913b57
AS
33512011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3352
3353 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3354 change. (Bug#8496)
3355
a6744a35
EZ
33562011-04-13 Eli Zaretskii <eliz@gnu.org>
3357
3358 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3359 when at ZV. (Bug#8487)
3360
e7974947
AS
33612011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3362
baad03f0
AS
3363 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3364 (Bug#8437)
3365 * keyboard.c (parse_tool_bar_item): Likewise.
3366 * sound.c (sound_cleanup, alsa_close): Likewise.
3367 * termcap.c (tgetent): Likewise.
3368 * xfns.c (x_default_font_parameter): Likewise.
3369 * xsettings.c (read_and_apply_settings): Likewise.
3370
e7974947
AS
3371 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3372 (overrun_check_free): Protoize.
3373
28272684
PE
33742011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3375
3376 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3377 since callers should never pass a negative size.
3378 Change the signature to match that of plain 'read' and 'write'; see
3379 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3380 * lisp.h: Update prototypes of emacs_write and emacs_read.
3381
11997c76
EZ
33822011-04-11 Eli Zaretskii <eliz@gnu.org>
3383
3384 * xdisp.c (redisplay_window): Don't try to determine the character
3385 position of the scroll margin if the window start point w->startp
e896f03c 3386 is outside the buffer's accessible region. (Bug#8468)
11997c76 3387
8a2cbd72
EZ
33882011-04-10 Eli Zaretskii <eliz@gnu.org>
3389
3390 Fix write-region and its subroutines for buffers > 2GB.
3391 * fileio.c (a_write, e_write): Modify declaration of arguments and
3392 local variables to support buffers larger than 2GB.
3393 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3394
3395 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3396 argument, local variables, and return value.
3397
3398 * lisp.h: Update prototypes of emacs_write and emacs_read.
3399
3400 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3401
4073e537 34022011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3403
1ebfdcb6
PE
3404 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3405
b2ded58d
PE
3406 Fix more problems found by GCC 4.6.0's static checks.
3407
7d66342c
PE
3408 * xdisp.c (vmessage): Use a better test for character truncation.
3409
bbf47d44
PE
3410 * charset.c (load_charset_map): <, not <=, for optimization,
3411 and to avoid potential problems with integer overflow.
9248994d 3412 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3413 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3414 * editfns.c (Fformat): Likewise.
1e69125e 3415 * syntax.c (skip_chars): Likewise.
3befa583 3416
e3019616
PE
3417 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3418 This also lets GCC 4.6.0 generate slightly better loop code.
3419
becfa255
PE
3420 * callint.c (Fcall_interactively): <, not <=, for optimization.
3421 (Fcall_interactively): Count the number of arguments produced,
3422 not the number of arguments given. This is simpler and lets GCC
3423 4.6.0 generate slightly better code.
3424
dae0cd48
PE
3425 * ftfont.c: Distingish more carefully between FcChar8 and char.
3426 The previous code passed unsigned char * to a functions like
3427 strlen and xstrcasecmp that expect char *, which does not
3428 conform to the C standard.
3429 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3430 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3431 char * when the C standard requires it.
3432
76032d70
PE
3433 * keyboard.c (read_char): Remove unused var.
3434
eb3f1cc8
PE
3435 * eval.c: Port to Windows vsnprintf (Bug#8435).
3436 Include <limits.h>.
3437 (SIZE_MAX): Define if the headers do not.
3438 (verror): Do not give up if vsnprintf returns a negative count.
3439 Instead, grow the buffer. This ports to Windows vsnprintf, which
3440 does not conform to C99. Problem reported by Eli Zaretskii.
3441 Also, simplify the allocation scheme, by avoiding the need for
3442 calling realloc, and removing the ALLOCATED variable.
3443
70476b54
PE
3444 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3445
12020a9e
PE
3446 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3447 But keep the doprint source code for now, as we might revamp it
3448 and use it again (Bug#8435).
ea6c7ae6
PE
3449 * lisp.h (doprnt): Remove.
3450 * Makefile.in (base_obj): Remove doprnt.o.
3451 * deps.mk (doprnt.o): Remove.
3452
5fdb398c
PE
3453 error: Print 32- and 64-bit integers portably (Bug#8435).
3454 Without this change, on typical 64-bit hosts error ("...%d...", N)
3455 was used to print both 32- and 64-bit integers N, which relied on
3456 undefined behavior.
3457 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3458 New macro.
3459 * lisp.h (error, verror): Mark as printf-like functions.
3460 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3461 Report overflow in size calculations when allocating printf buffer.
3462 Do not truncate output string at its first null byte.
3463 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3464 Truncate the output at a character boundary, since vsnprintf does not
3465 do that.
3466 * charset.c (check_iso_charset_parameter): Convert internal
3467 character to string before calling 'error', since %c now has the
3468 printf meaning.
3469 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3470 overflow when computing char to be passed to 'error'. Do not
3471 pass Lisp_Object to 'error'; pass the integer instead.
3472 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3473 formatted with plain %d.
3474
b189fa66
PE
3475 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3476
bff87ef0
PE
3477 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3478
7e2cac20
PE
3479 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3480
ce4d90b5
PE
3481 * xterm.c (x_catch_errors): Remove duplicate declaration.
3482
266c9547
PE
3483 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3484
79c49ad2
PE
3485 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3486
368f4090
JM
34872011-04-10 Jim Meyering <meyering@redhat.com>
3488
3489 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3490 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3491 return ssize_t not "int", and use size_t as the buffer length.
3492 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3493 * gnutls.h: Update declarations.
3494 * process.c (read_process_output): Use ssize_t, to match.
3495 (send_process): Likewise.
3496
a32d4040
CY
34972011-04-09 Chong Yidong <cyd@stupidchicken.com>
3498
3499 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3500
8546720e 35012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3502
04f2d78b
CB
3503 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3504 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3505
8546720e
GM
3506 * xterm.c (handle_one_xevent):
3507 * xmenu.c (create_and_show_popup_menu):
3508 * xselect.c (x_decline_selection_request)
3509 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3510
0a2f5c1a 35112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3512
3513 Fix some uses of `int' instead of EMACS_INT.
3514 * search.c (string_match_1, fast_string_match)
3515 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3516 (scan_buffer, find_next_newline_no_quit)
3517 (find_before_next_newline, search_command, Freplace_match)
3518 (Fmatch_data): Make some `int' variables be EMACS_INT.
3519
3520 * xdisp.c (display_count_lines): 3rd argument and return value now
3521 EMACS_INT. All callers changed.
3522 (pint2hrstr): Last argument is now EMACS_INT.
3523
3524 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3525 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3526 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3527 (decode_coding_utf_16, decode_coding_emacs_mule)
3528 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3529 (decode_coding_ccl, decode_coding_charset)
3530 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3531 (decode_coding_iso_2022, decode_coding_emacs_mule)
3532 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3533 <char_offset, last_offset>: Declare EMACS_INT.
3534 (encode_coding_utf_8, encode_coding_utf_16)
3535 (encode_coding_emacs_mule, encode_invocation_designation)
3536 (encode_designation_at_bol, encode_coding_iso_2022)
3537 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3538 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3539 Declare EMACS_INT.
3540 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3541 (encode_invocation_designation): Last argument P_NCHARS is now
3542 EMACS_INT.
3543 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3544 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3545
3546 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3547 All users changed.
3548
3549 * ccl.c (Fccl_execute_on_string): Declare some variables
3550 EMACS_INT.
3551
8546720e 35522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3553
3554 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3555
4e19a977
CS
35562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3557
3558 * process.c (Fformat_network_address): Doc fix.
3559
87302331
R
35602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3561
3562 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3563
cbb59342
CY
35642011-04-08 Chong Yidong <cyd@stupidchicken.com>
3565
3566 * keyboard.c (read_char): Call Lisp function help-form-show,
3567 instead of using internal_with_output_to_temp_buffer.
3568 (Qhelp_form_show): New var.
e0d38eeb 3569 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3570
3571 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3572
3573 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3574
e67a13ab
CY
35752011-04-06 Chong Yidong <cyd@stupidchicken.com>
3576
04f2d78b
CB
3577 * process.c (Flist_processes): Remove to Lisp.
3578 (list_processes_1): Delete.
e67a13ab 3579
973f782d
EZ
35802011-04-06 Eli Zaretskii <eliz@gnu.org>
3581
7c106b1e
EZ
3582 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3583
973f782d
EZ
3584 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3585
41cf7d1a 35862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3587
ca23cc88
PE
3588 Fix more problems found by GCC 4.6.0's static checks.
3589
f390e2d5
PE
3590 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3591
42eea0d0
PE
3592 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3593
b69769da 3594 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3595
f9541e84
PE
3596 * xdisp.c (vmessage): Mark as a printf-like function.
3597
13841b55
PE
3598 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3599
c136c10f
PE
3600 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3601
5e2d4a30
PE
3602 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3603 printf-like functions.
3604 (tiff_load): Add casts to remove these marks before passing them
3605 to system-supplied API.
3606
583f48b9
PE
3607 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3608
b25d760e
PE
3609 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3610 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3611 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3612 directly, rather than having caller test rule sign. This avoids
3613 some unnecessary tests.
3614 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3615 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3616 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3617
bc7b6697 3618 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3619 (xfont_open): Avoid unnecessary tests.
bc7b6697 3620
27ccc379
PE
3621 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3622
dcd5c89a
PE
3623 * composite.h, composite.c (composition_gstring_put_cache):
3624 Use EMACS_INT, not int, for length.
3625
b13a45c6
PE
3626 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3627 breaking out part of COMPOSITION_DECODE_RULE.
3628 (COMPOSITION_DECODE_RULE): Use it.
3629 * composite.c (get_composition_id): Remove unused local vars,
3630 by using the new macro.
3631
1e792e4d
PE
3632 * textprop.c (set_text_properties_1): Change while to do-while,
3633 since the condition is always true at first.
3634
dc6c6455 3635 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3636 (interval_deletion_adjustment): Return unsigned value.
3637 All uses changed.
dc6c6455 3638
aba7731a
PE
3639 * process.c (list_processes_1, create_pty, read_process_output):
3640 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3641 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3642 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3643 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3644 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3645
fdfc4bf3
PE
3646 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3647
fca8fe46 3648 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3649 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3650
06a0259a 3651 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3652 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3653 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3654
e7b9e80f
PE
3655 * print.c (print_error_message): Avoid int overflow.
3656
56201685
PE
3657 * font.c (font_list_entities): Redo for clarity,
3658 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3659
78834453 3660 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3661 (font_score): Avoid potential overflow in diff calculation.
78834453 3662
0bc0b309 3663 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3664 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3665
e610eaca
PE
3666 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3667
b895abce
PE
3668 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3669 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3670 can always succeed if overflow has undefined behavior.
3671
1f1d9321 3672 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3673 (wordify): Omit three unnecessary tests.
1f1d9321 3674
c59478bc
PE
3675 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3676 All callers changed. This avoids the need for an unused var.
3677
79b73827
PE
3678 * casefiddle.c (casify_region): Remove var that is set but not used.
3679
a4db5dfe
PE
3680 * dired.c (file_name_completion): Remove var that is set but not used.
3681
43aae36e
PE
3682 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3683
2a47c44d 3684 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3685 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3686
a37c69bf
PE
3687 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3688 Check for integer overflow on size calculations.
3689
328ab8e7
PE
3690 * buffer.c (Fprevious_overlay_change): Remove var that is set
3691 but not used.
3692
e5a2a5cb
PE
3693 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3694 Remove vars that are set but not used.
8d84a6eb 3695 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3696 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3697
a60e5f68
PE
3698 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3699
f661cb61 3700 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3701 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3702
f0397f5a
PE
3703 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3704 that are set but not used.
3705
8664db06 3706 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3707 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3708
6abdaa4a
PE
3709 * xselect.c (x_get_local_selection, x_handle_property_notify):
3710 Remove vars that are set but not used.
3711
0ce7538d 3712 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3713 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3714
9ae848fc
PE
3715 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3716 Remove var that is set but not used.
0b918413
PE
3717 (scroll_bar_windows_size): Now size_t, not int.
3718 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3719 Check for overflow.
9ae848fc 3720
a5a62657
PE
3721 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3722 (map_tty_color) [!defined MSDOS]: Likewise.
3723
5c5cdd39
PE
3724 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3725
66ebf983
PE
3726 * coding.c: Remove vars that are set but not used.
3727 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3728 All callers changed.
3729 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3730 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3731 (decode_coding_charset): Remove vars that are set but not used.
3732
1be4d761
PE
3733 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3734 that is set but not used.
3735
47553fa8
PE
3736 * print.c (print_object): Remove var that is set but not used.
3737
1f7196bf 3738 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3739 The gnulib version avoids calling malloc in the usual case,
3740 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3741 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3742 * filelock.c (current_lock_owner): Likewise.
3743 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3744 * sysdep.c: Include allocator.h, careadlinkat.h.
3745 (emacs_no_realloc_allocator): New static constant.
3746 (emacs_readlink): New function.
fdb61804
PE
3747 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3748 ../lib/careadlinkat.h.
d1fdcab7 3749
f84c17c7
SM
37502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3751
3752 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3753 first non-nil return value).
3754
ef3862ad
JD
37552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3756
3757 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3758 if not defined (Bug#8403).
3759
376a7006
JB
37602011-04-02 Juanma Barranquero <lekktu@gmail.com>
3761
3762 * xdisp.c (display_count_lines): Remove parameter `start',
3763 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3764 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3765 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3766 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3767 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3768 and thereabouts. All callers changed.
3769 (get_per_char_metric): Remove parameter `f', unused since
3770 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3771
6ca3801d
JM
37722011-04-02 Jim Meyering <meyering@redhat.com>
3773
3774 do not dereference NULL upon failed strdup
3775 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3776 (ns_get_family): Likewise.
3777
d8e2b5ba
JB
37782011-04-02 Juanma Barranquero <lekktu@gmail.com>
3779
3780 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3781
8c74fcbd
JD
37822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3783
3784 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3785 later (Bug#8403).
3786
7200d79c
SM
37872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3788
03408648 3789 Add lexical binding.
7200d79c 3790
03408648
SM
3791 * window.c (Ftemp_output_buffer_show): New fun.
3792 (Fsave_window_excursion):
3793 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3794
3795 * lread.c (lisp_file_lexically_bound_p): New function.
3796 (Fload): Bind Qlexical_binding.
3797 (readevalloop): Remove `evalfun' arg.
3798 Bind Qinternal_interpreter_environment.
3799 (Feval_buffer): Bind Qlexical_binding.
3800 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3801 Mark as dynamic.
3802 (syms_of_lread): Declare `lexical-binding'.
3803
3804 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3805
3806 * keyboard.c (eval_dyn): New fun.
3807 (menu_item_eval_property): Use it.
ca105506
SM
3808
3809 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3810
03408648
SM
3811 * fns.c (concat, mapcar1): Accept byte-code-functions.
3812
3813 * eval.c (Fsetq): Handle lexical vars.
3814 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3815 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3816 (FletX, Flet): Obey lexical binding.
3817 (Fcommandp): Handle closures.
3818 (Feval): New `lexical' arg.
3819 (eval_sub): New function extracted from Feval. Use it almost
3820 everywhere where Feval was used. Look up vars in lexical env.
3821 Handle closures.
3822 (Ffunctionp): Move from subr.el.
3823 (Ffuncall): Handle closures.
3824 (apply_lambda): Remove `eval_flags'.
3825 (funcall_lambda): Handle closures and new byte-code-functions.
3826 (Fspecial_variable_p): New function.
3827 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3828 but without exporting it to Lisp.
23aba0ea 3829
23aba0ea 3830 * doc.c (Fdocumentation, store_function_docstring):
03408648 3831 * data.c (Finteractive_form): Handle closures.
23aba0ea 3832
03408648
SM
3833 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3834 interactive spec.
ba83908c 3835
04f2d78b
CB
3836 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3837 New byte-codes.
03408648
SM
3838 (exec_byte_code): New function extracted from Fbyte_code to handle new
3839 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3840
03408648 3841 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3842
03408648 3843 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3844
e2abce01
JB
38452011-03-31 Juanma Barranquero <lekktu@gmail.com>
3846
3847 * xdisp.c (redisplay_internal): Fix prototype.
3848
63696a73 38492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3850
63696a73 3851 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3852 (try_scrolling): Use it when setting scroll_limit.
3853 Limit scrolling to 100 screen lines.
63696a73
EZ
3854 (redisplay_window): Even when falling back on "recentering",
3855 position point in the window according to scroll-conservatively,
3856 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3857
3858 (try_scrolling): When point is above the window, allow searching
3859 as far as scroll_max, or one screenful, to compute vertical
3860 distance from PT to the scroll margin position. This prevents
3861 try_scrolling from unnecessarily failing when
3862 scroll-conservatively is set to a value slightly larger than the
3863 window height. Clean up the case of PT below the margin at bottom
3864 of window: scroll_max can no longer be INT_MAX. When aggressive
3865 scrolling is in use, don't let point enter the opposite scroll
3866 margin as result of the scroll.
3867 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3868 threshold of 100 lines for never-recentering scrolling.
3869
e4cc2dfc
JB
38702011-03-31 Juanma Barranquero <lekktu@gmail.com>
3871
3872 * dispextern.h (move_it_by_lines):
3873 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3874 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3875 (message_log_check_duplicate): Remove parameters `prev_bol' and
3876 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3877 (redisplay_internal): Remove parameter `preserve_echo_area',
3878 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3879
3880 * indent.c (Fvertical_motion):
3881 * window.c (window_scroll_pixel_based, Frecenter):
3882 Don't pass `need_y_p' to `move_it_by_lines'.
3883
1c470562
SM
38842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3885
44f230aa
SM
3886 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3887 steal a few bits to be more compact.
3888 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3889 Remove unneeded casts.
3890
1c470562
SM
3891 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3892
888adce9
ZK
38932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3894
3895 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3896 binding" message (bug#7967).
3897
f838ed7b
PE
38982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3899
77861b95
PE
3900 Fix more problems found by GCC 4.6.0's static checks.
3901
de6dbc14
PE
3902 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3903 Remove unused local var.
3904
f838ed7b
PE
3905 * editfns.c (Fmessage_box): Remove unused local var.
3906
792c7b2b
PE
3907 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3908 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3909 Omit unused local vars.
c499e557 3910 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3911 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3912 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3913 Omit unused local var.
3914
ba0165e1
PE
3915 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3916 Don't assume string length fits in int.
32ad8845 3917 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3918 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3919
3c59b4c9
PE
3920 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3921 instead of alloca (Bug#8344).
3922
a3eed478 3923 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3924 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3925
eb4d412d
PE
3926 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3927
1658b401
PE
3928 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3929 concerns.
3930
3931 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3932
3933 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3934
9a2c6e05
PE
3935 * keyboard.c (syms_of_keyboard): Use the same style as later
3936 in this function when indexing through an array. This also
3937 works around GCC bug 48267.
3938
03d0a109
PE
3939 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3940
44f730c8
PE
3941 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3942
fe75f926
PE
3943 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3944 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3945
ffa8c828
PE
3946 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3947 This avoids undefined behavior on integer overflow, and is a bit
3948 more convenient anyway since it is compared to a size_t variable.
3949
c5101a77
PE
3950 Variadic C functions now count arguments with size_t, not int.
3951 This avoids an unnecessary limitation on 64-bit machines, which
3952 caused (substring ...) to crash on large vectors (Bug#8344).
3953 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3954 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3955 All variadic functions and their callers changed accordingly.
c5101a77
PE
3956 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3957 * data.c (arith_driver, float_arith_driver): Likewise.
3958 * editfns.c (general_insert_function): Likewise.
3959 * eval.c (struct backtrace.nargs, interactive_p)
3960 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3961 (funcall_lambda, mark_backtrace): Likewise.
3962 * fns.c (concat): Likewise.
3963 * frame.c (x_set_frame_parameters): Likewise.
3964 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3965 0 if not found, not -1. All callers changed.
3966
dd3f25f7
PE
3967 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3968 (stack_copy_size): Now size_t, not int.
3969 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3970
461c2ab9
JB
39712011-03-28 Juanma Barranquero <lekktu@gmail.com>
3972
3973 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3974 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3975 All callers changed.
3976
3977 * lisp.h (multibyte_char_to_unibyte):
3978 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3979 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3980 * character.h (CHAR_TO_BYTE8):
3981 * cmds.c (internal_self_insert):
3982 * editfns.c (general_insert_function):
3983 * keymap.c (push_key_description):
3984 * search.c (Freplace_match):
3985 * xdisp.c (message_dolog, set_message_1): All callers changed.
3986
f6d62986
SM
39872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3988
3989 * keyboard.c (safe_run_hook_funcall): New function.
3990 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3991 don't set the hook to nil, but remove the offending function instead.
3992 (Qcommand_hook_internal): Remove, unused.
3993 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3994 Vcommand_hook_internal.
3995
3996 * eval.c (enum run_hooks_condition): Remove.
3997 (funcall_nil, funcall_not): New functions.
3998 (run_hook_with_args): Call each function through a `funcall' argument.
3999 Remove `cond' argument, now redundant.
4000 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4001 (Frun_hook_with_args_until_failure): Adjust accordingly.
4002 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4003
1db5b1ad
JB
40042011-03-28 Juanma Barranquero <lekktu@gmail.com>
4005
4006 * dispextern.h (string_buffer_position): Remove declaration.
4007
4008 * print.c (strout): Remove parameter `multibyte', unused since
4009 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4010
4011 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4012 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4013 All callers changed.
4014
4015 * w32.c (_wsa_errlist): Use braces for struct initializers.
4016
4017 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4018 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4019 All callers changed.
4020 (string_buffer_position): Likewise. Also, make static (it's never
4021 used outside xdisp.c).
4022 (cursor_row_p): Remove parameter `w', unused since
4023 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4024 (decode_mode_spec): Remove parameter `precision', introduced during
4025 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4026 All callers changed.
4027
5ffb62aa
JD
40282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4029
4030 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4031
461c2ab9 40322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4033
4034 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4035 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4036 (ns_update_auto_hide_menu_bar): New functions.
4037 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4038 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4039 ns_constrain_all_frames.
4040 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4041 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4042
5c380ffb
JD
40432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4044
4045 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4046
9af30bdf
GM
40472011-03-27 Glenn Morris <rgm@gnu.org>
4048
4049 * syssignal.h: Replace RETSIGTYPE with void.
4050 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4051 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4052 Replace SIGTYPE with void everywhere.
4053 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4054 * s/template.h (SIGTYPE): Remove commented out definition.
4055
e2abce01
JB
40562011-03-26 Eli Zaretskii <eliz@gnu.org>
4057
4058 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4059 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4060
f868cd8a
JB
40612011-03-26 Juanma Barranquero <lekktu@gmail.com>
4062
59eb0929
JB
4063 * w32.c (read_unc_volume): Use parameter `henum', instead of
4064 global variable `wget_enum_handle'.
4065
4066 * keymap.c (describe_vector): Remove parameters `indices' and
4067 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4068 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4069
f868cd8a
JB
4070 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4071
4072 * keyboard.c (timer_check): Remove parameter `do_it_now',
4073 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4074 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4075 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4076
4077 * keyboard.c (read_char):
4078 * w32menu.c (w32_menu_display_help):
4079 * xmenu.c (show_help_event, menu_help_callback):
4080 Adjust calls to `show_help_echo'.
4081
4082 * gtkutil.c (xg_maybe_add_timer):
4083 * keyboard.c (readable_events):
4084 * process.c (wait_reading_process_output):
4085 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4086
4087 * insdel.c (adjust_markers_gap_motion):
4088 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4089 (gap_left, gap_right): Don't call it.
4090
2ecf6fdb
CY
40912011-03-25 Chong Yidong <cyd@stupidchicken.com>
4092
4093 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4094 incurred during fontification.
4095
6b1f9ba4
JB
40962011-03-25 Juanma Barranquero <lekktu@gmail.com>
4097
4098 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4099 (DEFVAR_PER_BUFFER): Don't pass it.
4100
4101 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4102 (scrolling_window): Don't pass it.
4103
0f4a96b5
JB
41042011-03-25 Juanma Barranquero <lekktu@gmail.com>
4105
4106 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4107
4108 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4109 and `suffix'.
4110 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4111 of variables specific to SELinux and computation of `encoded_absname'.
4112
4113 * image.c (XPutPixel): Remove unused variable `height'.
4114
4115 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4116
4117 * unexw32.c (get_section_info): Remove unused variable `section'.
4118
4119 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4120 (system_process_attributes): Remove unused variable `sess'.
4121 (sys_read): Remove unused variable `err'.
4122
4123 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4124 (w32_wnd_proc): Remove unused variable `isdead'.
4125 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4126 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4127 (x_create_tip_frame): Remove unused variable `tem'.
4128
4129 * w32inevt.c (w32_console_read_socket):
4130 Remove unused variable `no_events'.
4131
4132 * w32term.c (x_draw_composite_glyph_string_foreground):
4133 Remove unused variable `width'.
4134
1149507c
JB
41352011-03-24 Juanma Barranquero <lekktu@gmail.com>
4136
4137 * w32term.c (x_set_glyph_string_clipping):
4138 Don't pass uninitialized region to CombineRgn.
4139
9c88f339
JB
41402011-03-23 Juanma Barranquero <lekktu@gmail.com>
4141
4142 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4143 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4144 (Fx_close_connection): Remove unused variable `i'.
4145
4146 * w32font.c (w32font_draw): Return number of glyphs.
4147 (w32font_open_internal): Remove unused variable `i'.
4148 (w32font_driver): Add missing initializer.
4149
4150 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4151 (fill_in_menu): Remove unused variable `items_added'.
4152
4153 * w32term.c (last_mouse_press_frame): Remove static global variable.
4154 (w32_clip_to_row): Remove unused variable `f'.
4155 (x_delete_terminal): Remove unused variable `i'.
4156
4157 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4158 (NOTHING): Remove unused static global variable.
4159 (uniscribe_check_otf): Remove unused variable `table'.
4160 (uniscribe_font_driver): Add missing initializers.
4161
dee091a3
JD
41622011-03-23 Julien Danjou <julien@danjou.info>
4163
4164 * term.c (Fsuspend_tty, Fresume_tty):
4165 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4166 * window.c (temp_output_buffer_show):
4167 * insdel.c (signal_before_change):
4168 * frame.c (Fhandle_switch_frame):
4169 * fileio.c (Fdo_auto_save):
4170 * emacs.c (Fkill_emacs):
4171 * editfns.c (save_excursion_restore):
4172 * cmds.c (internal_self_insert):
4173 * callint.c (Fcall_interactively):
4174 * buffer.c (Fkill_all_local_variables):
4175 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4176 Use Frun_hooks.
0f4a96b5 4177 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4178 unconditionnaly since it does the check itself.
4179
2c520ab5 41802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4181
c9c49752
PE
4182 Fix more problems found by GCC 4.5.2's static checks.
4183
8abc3f12
PE
4184 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4185 the first time through the loop, since we know p0 < p1 then.
4186 This also avoids a gcc -Wstrict-overflow warning.
4187
a2d26660
PE
4188 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4189 leading to a memory leak, possible in functions like
4190 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4191 of objects (Bug#8318).
a2d26660 4192
916c72e9
PE
4193 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4194 that could (at least in theory) be that large.
4195
19ab8a18
PE
4196 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4197 This is less likely to overflow, and avoids undefined behavior if
4198 overflow does occur. All callers changed. Use strtoul to scan
4199 for the unsigned long integer.
b7cbbd6f
PE
4200 (pint2hrstr): Simplify and tune code slightly.
4201 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4202
f0641eff
PE
4203 * scroll.c (do_scrolling): Work around GCC bug 48228.
4204 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4205
7f650bb9
PE
4206 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4207 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4208 (validate_x_resource_name): Simplify count usage.
4209 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4210
37dd57d1
PE
4211 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4212 fail (Bug#8306).
81e56e61 4213
699979fc 4214 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4215
401bf9b4
PE
4216 * process.c (Fmake_network_process): Use socklen_t, not int,
4217 where POSIX says socklen_t is required in portable programs.
4218 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4219 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4220 (Fmake_network_process, server_accept_connection):
4221 (wait_reading_process_output, read_process_output):
4222 Likewise.
4223
b93aacde
PE
4224 * process.c: Rename or move locals to avoid shadowing.
4225 (list_processes_1, Fmake_network_process):
4226 (read_process_output_error_handler, exec_sentinel_error_handler):
4227 Rename or move locals.
4dc343ee 4228 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4229 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4230 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4231 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4232 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4233
af8a867c 4234 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4235 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4236 Include tparam.h instead, since it declares them.
af8a867c
PE
4237 * cm.h (PC): Remove extern decl; tparam.h now does this.
4238 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4239 * terminfo.c: Include tparam.h, to check interfaces.
4240 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4241 (tparam): Adjust signature to match interface in tparam.h;
4242 this removes some undefined behavior. Check that outstring and len
4243 are zero, which they always are with Emacs.
4244 * tparam.h (PC, BC, UP): New extern decls.
4245
0248044d 4246 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4247 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4248
8ff096c1 4249 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4250 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4251 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4252 (ftfont_list): Remove unused local.
49eaafba
PE
4253 (get_adstyle_property, ftfont_pattern_entity):
4254 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4255 Rename locals to avoid shadowing.
8ff096c1 4256
e2be39f6
PE
4257 * xfont.c (xfont_list_family): Mark var as initialized.
4258
c9735e30
PE
4259 * xml.c (make_dom): Now static.
4260
8f5201ae
PE
4261 * composite.c (composition_compute_stop_pos): Rename local to
4262 avoid shadowing.
b246f932
PE
4263 (composition_reseat_it): Remove unused locals.
4264 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4265 (composition_update_it): Mark var as initialized.
11b61122
PE
4266 (find_automatic_composition): Mark vars as initialized,
4267 with a FIXME (Bug#8290).
8f5201ae 4268
760fbc2c
PE
4269 character.h: Rename locals to avoid shadowing.
4270 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4271 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4272 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4273 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4274 to avoid shadowing.
4275
ff08eb85
PE
4276 * textprop.c (property_change_between_p): Remove; unused.
4277
fc7bf025
PE
4278 * intervals.c (interval_start_pos): Now static.
4279
235d7abc
PE
4280 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4281
44f230aa
SM
4282 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4283 Rename locals to avoid shadowing.
3e7d6594 4284
50060332
PE
4285 * sound.c (wav_play, au_play, Fplay_sound_internal):
4286 Fix pointer signedness.
d01f234b 4287 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4288 (wav_play): Initialize a variable to 0, to prevent undefined
4289 behavior (Bug#8278).
50060332 4290
c4fc4e30
PE
4291 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4292
918436ed
PE
4293 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4294
c939f91b
PE
4295 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4296 clobbering (Bug#8298).
b9c7f648
PE
4297 * sysdep.c (sys_subshell): Likewise.
4298 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4299
6bd8c144
PE
4300 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4301 This should get cleaned up, so that child_setup has the
4302 same signature on all platforms.
4303
7710357c 4304 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4305 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4306
c59da222
CY
43072011-03-22 Chong Yidong <cyd@stupidchicken.com>
4308
4309 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4310 not to be necessary, and produces flickering.
4311
66b87493
GM
43122011-03-20 Glenn Morris <rgm@gnu.org>
4313
4314 * config.in: Remove file.
4315
45b6f6d5
JB
43162011-03-20 Juanma Barranquero <lekktu@gmail.com>
4317
4318 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4319 are now in src/globals.h.
4320 (syms_of_minibuf): Remove spurious & from previous change.
4321
3ec03f7e
LL
43222011-03-20 Leo <sdl.web@gmail.com>
4323
4324 * minibuf.c (completing-read-function): New variable.
4325 (completing-read-default): Rename from completing-read.
4326 (completing-read): Call completing-read-function.
4327
b14e3e21
CY
43282011-03-19 Juanma Barranquero <lekktu@gmail.com>
4329
4330 * xfaces.c (Fx_load_color_file):
4331 Read color file from absolute filename (bug#8250).
4332
f2b726e6
JB
43332011-03-19 Juanma Barranquero <lekktu@gmail.com>
4334
4335 * makefile.w32-in: Update dependencies.
4336
09f6ff02
EZ
43372011-03-17 Eli Zaretskii <eliz@gnu.org>
4338
4339 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4340
29a6015a
PE
43412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4342
a3a6c54e
PE
4343 Fix more problems found by GCC 4.5.2's static checks.
4344
b766f867
PE
4345 * process.c (make_serial_process_unwind, send_process_trap):
4346 (sigchld_handler): Now static.
4347
be02381c
PE
4348 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4349 That way, the code declares only the vars that it needs.
4350 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4351 * s/cygwin.h (PTY_ITERATION): Likewise.
4352 * s/darwin.h (PTY_ITERATION): Likewise.
4353 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4354
57048744
PE
4355 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4356 * process.c (allocate_pty): Don't declare stb unless it's needed.
4357
7914961c 4358 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4359 (CONSTANTLIM): Remove; unused.
4360 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4361 Define only if needed.
7914961c 4362
b3967b18
PE
4363 * unexelf.c (unexec): Name an expression,
4364 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4365 Use a different way to cause a compilation error if anyone uses
4366 n rather than nn, a way that does not involve shadowing.
73366a00 4367 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4368
29a6015a
PE
4369 * deps.mk (unexalpha.o): Remove; unused.
4370
43cfc33e 4371 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4372 * unexec.h: New file.
ce701a33
PE
4373 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4374 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4375 Depend on unexec.h.
4376 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4377 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4378 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4379 Change as necessary to match prototype in unexec.h.
ce701a33 4380
01f44d5a
PE
4381 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4382 shadowing.
4f63c6bb 4383 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4384
a6670b0b
PE
4385 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4386 Rename locals to avoid shadowing.
4387
cef2010d 4388 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4389 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4390
d4d7173a
PE
4391 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4392
f08b802a
PE
4393 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4394 warning when compiling print.c.
4395
3ddb0639
PE
4396 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4397 instead of using an uninitialized var.
5ad03b97 4398 (font_sort_entities): Mark var as initialized.
3ddb0639 4399
170a2692
PE
4400 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4401
e663c700
PE
4402 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4403 pointers to constants.
89bc529a 4404 (font_parse_fcname): Remove unused vars.
7b81e2d0 4405 (font_delete_unmatched): Now static.
ea838e10 4406 (font_get_spec): Remove; unused.
13a547c6
PE
4407 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4408 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4409 Rename or move locals to avoid shadowing.
e663c700 4410
2a80c887 4411 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4412 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4413
1384fa33 4414 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4415 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4416
8b2c52e9
PE
4417 * alloc.c (mark_backtrace): Move decl from here ...
4418 * lisp.h: ... to here, so that it can be checked.
4419
475545b5 4420 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4421 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4422 (lisp_indirect_variable): Name an expression,
4423 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4424 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4425
b1349114 4426 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4427 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4428 Use const pointer when appropriate.
b1349114 4429
a2928364
PE
4430 * lisp.h (get_system_name, get_operating_system_release):
4431 Move decls here, to check interfaces.
4432 * process.c (get_operating_system_release): Move decl to lisp.h.
4433 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4434 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4435 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4436 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4437 (Fformat_time_string, Fencode_time, Finsert_char):
4438 (Ftranslate_region_internal, Fformat):
4439 Rename or remove local vars to avoid shadowing.
9710023e 4440 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4441
a415e694
PE
4442 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4443 avoid shadowing.
4444
8ef4622d
PE
4445 * lisp.h (eassert): Check that the argument compiles, even if
4446 ENABLE_CHECKING is not defined.
4447
946f9a5b
PE
4448 * data.c (Findirect_variable): Name an expression, to avoid
4449 gcc -Wbad-function-cast warning.
112396d6 4450 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4451 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4452 (Fmake_variable_buffer_local, Fmake_local_variable):
4453 Mark variables as initialized.
52746918 4454 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4455
e5aab7e7 4456 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4457 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4458 Rename locals to avoid shadowing.
dff45157
PE
4459 (mark_stack): Move local variables into the #ifdef region where
4460 they're used.
7bc26fdb
PE
4461 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4462 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4463 needed otherwise.
4464 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4465 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4466 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4467
e5aab7e7
PE
4468 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4469 avoids undefined behavior in theory.
4470
4da60324
PE
4471 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4472
88043301
PE
4473 Use functions, not macros, for up- and down-casing (Bug#8254).
4474 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4475 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4476 to use the following functions instead of these macros.
4477 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4478 EMACS_INT, since callers assume the returned value fits in int.
4479 (upcase1): Likewise, for UPCASE_TABLE.
4480 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4481 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4482 the race-condition problem in the old DOWNCASE.
88043301 4483
19ed5445
PE
4484 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4485 Rename locals to avoid shadowing.
4486 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4487 (regex_compile, re_search_2, re_match_2_internal):
4488 Remove unused local vars.
952db0d7
PE
4489 (FREE_VAR): Rewrite so as not to use empty "else",
4490 which gcc can warn about.
da053e48 4491 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4492 (RETALLOC_IF): Define only if needed.
4493 (WORDCHAR_P): Likewise. This one is never needed, but is used
4494 only in a comment talking about a compiler bug, so put inside
4495 the #if 0 of that comment.
4496 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4497 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4498 Remove; unused.
19ed5445 4499
1f3561e4 4500 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4501 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4502 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4503
ded6f8f7
PE
4504 * search.c (simple_search): Remove unused var.
4505
dbd37a95
PE
4506 * dired.c (compile_pattern): Move decl from here ...
4507 * lisp.h: ... to here, so that it can be checked.
4508 (struct re_registers): New forward decl.
4509
7e47afad
PE
4510 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4511
85f24f61
PE
4512 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4513 All uses changed.
4514 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4515 Rename locals to avoid shadowing.
5671df8f 4516 (Fvertical_motion): Mark locals as initialized.
85f24f61 4517
181aa2be 4518 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4519 (casify_region): Mark local as initialized.
181aa2be 4520
930d429c
PE
4521 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4522
7082eac6
PE
4523 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4524 New macros, so that the caller can use some names other than
4525 gcpro1, gcpro2, etc.
4526 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4527 of the new macros.
4528 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4529 argument, for consistency with GCPRO2_VAR, etc: it is now the
4530 prefix of the variable, not the variable itself. All uses
4531 changed.
38b2c076
PE
4532 * dired.c (directory_files_internal, file_name_completion):
4533 Rename locals to avoid shadowing.
4534
15206ed9
PE
4535 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4536 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4537 dired.c's scmp function, had undefined behavior.
4538 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4539 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4540 * buffer.h: ... to here, because these macros use current_buffer,
4541 and the new implementation with inline functions needs to have
4542 current_buffer in scope now, rather than later when the macros
4543 are used.
4544 (downcase, upcase1): New static inline functions.
4545 (DOWNCASE, UPCASE1): Reimplement using these functions.
4546 This avoids undefined behavior in expressions like
4547 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4548 from race conditions in accessing the global variables
4549 case_temp1 and case_temp2.
4550 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4551 * lisp.h (case_temp1, case_temp2): Remove their decls.
4552 * character.h (ASCII_CHAR_P): Move from here ...
4553 * lisp.h: ... to here, so that the inline functions mentioned
4554 above can use them.
4555
4a6bea26
PE
4556 * dired.c (directory_files_internal_unwind): Now static.
4557
f14b7e14
PE
4558 * fileio.c (file_name_as_directory, directory_file_name):
4559 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4560 Now static.
2893f146
PE
4561 (file_name_as_directory): Use const pointers when appropriate.
4562 (Fexpand_file_name): Likewise. In particular, newdir might
4563 point at constant storage, so make it a const pointer.
fd4ead52 4564 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4565 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4566 signedness issues.
f839df0c
PE
4567 (Fset_file_times, Finsert_file_contents, auto_save_error):
4568 Rename locals to avoid shadowing.
f14b7e14 4569
5716756e 4570 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4571 (Ftry_completion, Fall_completions): Rename or remove locals
4572 to avoid shadowing.
5716756e 4573
b4c3046a
PE
4574 * marker.c (bytepos_to_charpos): Remove; unused.
4575
b45db522
PE
4576 * lisp.h (verify_bytepos, count_markers): New decls,
4577 so that gcc does not warn that these functions aren't declared.
4578
85876d07
PE
4579 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4580 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4581 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4582 (copy_text): Remove unused local var.
85876d07 4583
03d78a21 4584 * filelock.c (within_one_second): Now static.
b3dd38ab 4585 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4586
5df8f01b
PE
4587 * buffer.c (fix_overlays_before): Mark locals as initialized.
4588 (fix_start_end_in_overlays): Likewise. This function should be
4589 simplified by using pointers-to-pointers, but that's a different
4590 matter.
b1d876f1 4591 (switch_to_buffer_1): Now static.
8f54f30a
PE
4592 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4593 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4594
a70072c9 4595 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4596 Fix pointer signedness issue.
edced198
PE
4597 (sys_subshell): Mark local as volatile if checking for lint,
4598 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4599 (MAXPATHLEN): Define only if needed.
a70072c9 4600
a0977c44
PE
4601 * process.c (serial_open, serial_configure): Move decls from here ...
4602 * systty.h: ... to here, so that they can be checked.
4603
a884fdcc
PE
4604 * fns.c (get_random, seed_random): Move extern decls from here ...
4605 * lisp.h: ... to here, so that they can be checked.
4606
604efe86 4607 * sysdep.c (reset_io): Now static.
b8950c94 4608 (wait_for_termination_signal): Remove; unused.
604efe86 4609
38fc62d9
PE
4610 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4611 (copy_keymap_item, append_key, push_text_char_description):
4612 Now static.
1004a21a 4613 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4614 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4615 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4616 (describe_map_tree):
4617 Rename locals to avoid shadowing.
38fc62d9 4618
2f2650da
PE
4619 * keyboard.c: Declare functions static if they are not used elsewhere.
4620 (echo_char, echo_dash, cmd_error, top_level_2):
4621 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4622 (read_char, kbd_buffer_get_event, make_lispy_position):
4623 (make_lispy_event, make_lispy_movement, apply_modifiers):
4624 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4625 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4626 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4627 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4628 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4629
a053e86c 4630 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4631 (mark_kboards): Move decl here ...
4632 * alloc.c (mark_kboards): ... from here.
a053e86c 4633
4752793e
PE
4634 * lisp.h (force_auto_save_soon): New decl.
4635
74f10ca7 4636 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4637 (DEFINE_DUMMY_FUNCTION): New macro.
4638 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4639 Use it.
c03cd23f
PE
4640 (main): Add casts to avoid warnings
4641 if GCC considers string literals to be constants.
74f10ca7 4642
022e70d4
PE
4643 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4644
59d6fe83
PE
4645 * dbusbind.c: Pointer signedness fixes.
4646 (xd_signature, xd_append_arg, xd_initialize):
4647 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4648 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4649 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4650 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4651
78320123
PE
4652 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4653 if GCC considers string literals to be constants.
49cebcca 4654 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4655
35ac2a97
SM
46562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4657
fb103ca9
SM
4658 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4659 (print_preprocess, print_object): New macro to fix last change.
4660
35ac2a97
SM
4661 * print.c (print_preprocess): Don't forget font objects.
4662
62973b41
JB
46632011-03-16 Juanma Barranquero <lekktu@gmail.com>
4664
4665 * emacs.c (USAGE3): Doc fixes.
4666
0e48bb22
AS
46672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4668
4669 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4670 structure.
4671
7684e57b
JB
46722011-03-14 Juanma Barranquero <lekktu@gmail.com>
4673
4674 * lisp.h (VWindow_system, Qfile_name_history):
4675 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4676 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4677 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4678
4679 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4680 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4681
4682 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4683 * w32console.c (detect_input_pending, read_input_pending)
4684 (encode_terminal_code):
4685 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4686 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4687 (w32_system_caret_y, Qfile_name_history):
4688 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4689 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4690 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4691 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4692 * w32proc.c (Qlocal, report_file_error):
4693 * w32term.c (Vwindow_system, updating_frame):
4694 * w32uniscribe.c (initialized, uniscribe_font_driver):
4695 Remove unneeded extern declarations.
4696
2aa46d6c
CY
46972011-03-14 Chong Yidong <cyd@stupidchicken.com>
4698
c96bbc66 4699 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4700
cffc6f3b
CY
47012011-03-13 Chong Yidong <cyd@stupidchicken.com>
4702
4703 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4704 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4705 These macros can no longer be used for assignment.
4706
44f230aa
SM
4707 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4708 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4709 (record_buffer_markers, fetch_buffer_markers): New functions for
4710 recording and fetching special buffer markers.
4711 (set_buffer_internal_1, set_buffer_temp): Use them.
4712
4713 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4714
4715 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4716
4717 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4718 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4719
4720 * xdisp.c (hscroll_window_tree):
4721 (reconsider_clip_changes): Use PT instead of BUF_PT.
4722
d251f04b
EZ
47232011-03-13 Eli Zaretskii <eliz@gnu.org>
4724
4725 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4726 $(EMACS_ROOT)/lib/intprops.h.
4727
f0c77cd1
PE
47282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4729
3eca4629
PE
4730 Fix more problems found by GCC 4.5.2's static checks.
4731
7c86ee98
PE
4732 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4733 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4734 (xg_free_frame_widgets): Make it clear that a local variable is
4735 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4736 (gdk_window_get_screen): Make it clear that this macro is needed
4737 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4738 (int_gtk_range_get_value): New function, which avoids a diagnostic
4739 from gcc -Wbad-function-cast.
4740 (xg_set_toolkit_scroll_bar_thumb): Use it.
4741 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4742 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4743 (get_utf8_string, xg_get_file_with_chooser):
4744 Rename locals to avoid shadowing.
4745 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4746
41729b81
PE
4747 * xgselect.c (xg_select): Remove unused var.
4748
f0c77cd1
PE
4749 * image.c (four_corners_best): Mark locals as initialized.
4750 (gif_load): Initialize transparent_p to zero (Bug#8238).
4751 Mark another local as initialized.
ec6cf4c6 4752 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4753
ce0ad53d 4754 * image.c (clear_image_cache): Now static.
d5d5a617 4755 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4756 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4757 (x_edge_detection): Remove unnecessary cast that
4758 gcc -Wbad-function-cast diagnoses.
2037898d 4759 (gif_load): Fix pointer signedness.
6ae141d6
PE
4760 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4761 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4762
33383987 47632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4764
d32df629
PE
4765 Improve quality of tests for time stamp overflow.
4766 For example, without this patch (encode-time 0 0 0 1 1
4767 1152921504606846976) returns the obviously-bogus value (-948597
4768 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4769 reports time overflow. See
4770 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4771 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4772 * editfns.c: Include limits.h and intprops.h.
4773 (TIME_T_MIN, TIME_T_MAX): New macros.
4774 (time_overflow): Move earlier, to before first use.
4775 (hi_time, lo_time): New functions, for an accurate test for
4776 out-of-range times.
4777 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4778 (Fget_internal_run_time): Don't assume time_t fits in int.
4779 (make_time): Use list2 instead of Fcons twice.
4780 (Fdecode_time): More accurate test for out-of-range times.
4781 (check_tm_member): New function.
4782 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4783 (lisp_time_argument): Don't rely on undefined left-shift and
4784 right-shift behavior when checking for time stamp overflow.
8be6f318 4785
fe31d94c
PE
4786 * editfns.c (time_overflow): New function, refactoring common code.
4787 (Fformat_time_string, Fdecode_time, Fencode_time):
4788 (Fcurrent_time_string): Use it.
4789
8be6f318
PE
4790 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4791 * dired.c (make_time): Move to ...
4792 * editfns.c (make_time): ... here.
4793 * systime.h: Note the move.
4794
09d9db2c 47952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4796
126bc0dc
YM
4797 * fringe.c (update_window_fringes): Remove unused variables.
4798
c47cbdfd
YM
4799 * unexmacosx.c (copy_data_segment): Also copy __got section.
4800 (Bug#8223)
4801
7ac80be9
EZ
48022011-03-12 Eli Zaretskii <eliz@gnu.org>
4803
c96bbc66 4804 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4805 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4806 Constify `char *' arguments and their references according to
4807 prototypes in tparam.h.
4808
ecb0f94d 4809 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4810
7ac80be9
EZ
4811 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4812 Adapt all references accordingly.
4813
4814 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4815
ef1fd07e
TT
48162011-03-11 Tom Tromey <tromey@redhat.com>
4817
4818 * buffer.c (syms_of_buffer): Remove obsolete comment.
4819
7ef4b50c
EZ
48202011-03-11 Eli Zaretskii <eliz@gnu.org>
4821
4822 * termhooks.h (encode_terminal_code): Declare prototype.
4823
4824 * msdos.c (encode_terminal_code): Don't declare prototype.
4825
4826 * term.c (encode_terminal_code): Now external again, used by
4827 w32console.c and msdos.c.
4828
44f230aa
SM
4829 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4830 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4831
4b1ec863 48322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4833
1714f52b 4834 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4835
4b1ec863
PE
4836 * fringe.c (update_window_fringes): Mark locals as initialized
4837 (Bug#8227).
4838 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4839
524c7aa6
PE
4840 * alloc.c (mark_fringe_data): Move decl from here ...
4841 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4842 to check its interface.
4843 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4844
a5c0af81 4845 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4846 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4847 (fontset_font): Mark local as initialized.
a9a06e0b 4848 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4849
b4716021
PE
4850 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4851
811e9bac 4852 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4853 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4854 (x_own_selection, Fx_disown_selection_internal): Rename locals
4855 to avoid shadowing.
4856 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4857
7e3ab302
PE
4858 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4859 so that the caller can use some name other than gcpro1.
4860 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4861 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4862 (Fx_backspace_delete_keys_p):
4863 Use them to avoid shadowing, and rename vars to avoid shadowing.
4864 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4865 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4866 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4867 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4868 Remove unused locals.
7e3ab302
PE
4869 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4870 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4871 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4872 macros.
f78faa98 4873
e2b13473
PE
4874 * xterm.h (x_mouse_leave): New decl.
4875
77f23912
PE
4876 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4877 Remove unused functions.
cdf4ba58
PE
4878 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4879 (x_calc_absolute_position): Now static.
7411c686 4880 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4881 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4882 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4883 unless they are used.
38d0b34a
PE
4884 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4885 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4886 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4887 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4888 (x_error_catcher, x_connection_closed, x_error_handler):
4889 (x_error_quitter, xembed_send_message, x_iconify_frame):
4890 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4891 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4892 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4893
44f230aa
SM
4894 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4895 Rename or move locals to avoid shadowing.
6b463e58 4896 (tty_defined_color, merge_face_heights): Now static.
5967d051 4897 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4898 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4899 does not deduce is never used uninitialized.
73719eba
PE
4900 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4901 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4902
426994c3 4903 * terminal.c (store_terminal_param): Now static.
5489860b 4904
032f1620 4905 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4906 (set_frame_menubar): Remove unused local.
d4323972 4907 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4908 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4909 since they might point to immutable storage.
281585b0
PE
4910 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4911 since it's unused otherwise.
032f1620 4912
367c19e5 4913 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4914 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4915 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4916 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4917 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4918 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4919 does not deduce are never used uninitialized.
70739cbe 4920
07b48fa9
PE
4921 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4922
8868a238 4923 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4924 * window.c (window_loop, size_window):
4925 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4926
7e5cf297 4927 * window.c (display_buffer): Now static.
d6550a9f
PE
4928 (size_window): Mark variables that gcc -Wuninitialized
4929 does not deduce are never used uninitialized.
a586633d
PE
4930 * window.h (check_all_windows): New decl, to forestall
4931 gcc -Wmissing-prototypes diagnostic.
5b555da1 4932 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4933
f6095868
PE
4934 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4935 shadowing.
4936 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4937 Include <limits.h>.
4938 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4939 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4940 (load_charset_map): Mark variables that gcc -Wuninitialized
4941 does not deduce are never used uninitialized.
53df7c11 4942 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4943
f38b440c
PE
4944 * coding.c (coding_set_source, coding_set_destination):
4945 Use "else { /* comment */ }" rather than "else /* comment */;"
4946 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4947 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4948 a block, when the outer 'i' will do.
4949 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4950 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4951 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4952 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4953 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4954 Rename locals to avoid shadowing.
4955 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4956 * coding.c (emacs_mule_char, encode_invocation_designation):
4957 Now static, since they're not used elsewhere.
413bb2db 4958 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4959 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4960 (decode_coding_emacs_mule): Mark variables that gcc
4961 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4962 (detect_coding_iso_2022): Initialize a local variable that might
4963 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4964 this initialization is needed. (Bug#8211)
5f58e762
PE
4965 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4966 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4967 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4968 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4969 Remove unused macros.
f38b440c 4970
232b38b9 4971 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4972 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4973 * character.c (string_count_byte8): Likewise.
232b38b9 4974
fb90da1b
PE
4975 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4976 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4977
fb93dbc2
PE
4978 * chartab.c (copy_sub_char_table): Now static, since it's not used
4979 elsewhere.
5c156ace
PE
4980 (sub_char_table_ref_and_range, char_table_ref_and_range):
4981 Rename locals to avoid shadowing.
bbcd0949 4982 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4983
7d3b3862 4984 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4985 (BIDI_BOB): Remove unused macro.
7d3b3862 4986
6be7d3da
PE
4987 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4988 deduce are never used uninitialized.
c2ed9c8b 4989 * term.c (encode_terminal_code): Likewise.
6be7d3da 4990
75f8807f 4991 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4992
50938595
PE
4993 * tparam.h: New file.
4994 * term.c, tparam.h: Include it.
4995 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4996 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4997 Move these decls to tparam.h, and make them agree with what
4998 is actually in tparam.c. The previous trick of using incompatible
4999 decls in different modules does not conform to the C standard.
5000 All callers of tparam changed to use tparam's actual API.
5001 * tparam.c (tparam1, tparam, tgoto):
5002 Use const pointers where appropriate.
5003
fbceeba2
PE
5004 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5005 * cm.h (struct cm): Likewise.
5006 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5007 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5008 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5009 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5010 (turn_on_face, init_tty): Likewise.
5011 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5012
7f3f1250
PE
5013 * term.c (term_mouse_position): Rename local to avoid shadowing.
5014
e6ca6543
PE
5015 * alloc.c (mark_ttys): Move decl from here ...
5016 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5017
c40f8d15
AS
50182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5019
5020 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5021
cfe0661d
JB
50222011-03-09 Juanma Barranquero <lekktu@gmail.com>
5023
5024 * search.c (compile_pattern_1): Remove argument regp, unused since
5025 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5026 (compile_pattern): Don't pass it.
5027
0afb4571
J
50282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5029
5030 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5031 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5032 for ! HAVE_GTK3.
5033 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5034
5035 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5036
5037 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5038 gdk_window_get_screen, gdk_window_get_geometry,
5039 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5040 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5041 (xg_get_pixbuf_from_pixmap): New function.
5042 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5043 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5044 Call xg_get_pixbuf_from_pixmap instead of
5045 gdk_pixbuf_get_from_drawable.
5046 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5047 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5048 (xg_check_special_colors): Use GtkStyleContext and its functions
5049 for HAVE_GTK3.
5050 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5051 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5052 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5053 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5054 Call gtk_widget_get_preferred_size.
0afb4571
J
5055 (xg_frame_resized): gdk_window_get_geometry only takes 5
5056 parameters.
44f230aa
SM
5057 (xg_win_to_widget, xg_event_is_for_menubar):
5058 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5059 (xg_set_widget_bg): New function.
5060 (delete_cb): New function.
895009e1 5061 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5062 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5063 (xg_set_background_color): Call xg_set_widget_bg.
5064 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5065 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5066 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5067 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5068 if ! HAVE_GTK3.
5069 (update_frame_tool_bar): Call gtk_widget_hide.
5070 (xg_initialize): Use GDK_KEY_g.
5071
5072 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5073 if ! HAVE_GTK3
5074 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5075
5076 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5077 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5078 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5079
1c2cc4ef
JB
50802011-03-08 Juanma Barranquero <lekktu@gmail.com>
5081
5082 * w32xfns.c (select_palette): Check success of RealizePalette against
5083 GDI_ERROR, not zero.
5084
33383987 5085See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5086
5087;; Local Variables:
5088;; coding: utf-8
aac0c6e3
MR
5089;; End:
5090
33383987 5091 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5092
5093 This file is part of GNU Emacs.
5094
5095 GNU Emacs is free software: you can redistribute it and/or modify
5096 it under the terms of the GNU General Public License as published by
5097 the Free Software Foundation, either version 3 of the License, or
5098 (at your option) any later version.
5099
5100 GNU Emacs is distributed in the hope that it will be useful,
5101 but WITHOUT ANY WARRANTY; without even the implied warranty of
5102 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5103 GNU General Public License for more details.
5104
5105 You should have received a copy of the GNU General Public License
5106 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.