Give better error messages when trying to load non-existent symlinks
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bc985c87
AS
12011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2
3 * character.c (Fcharacterp): Don't advertise optional ignored
4 argument. (Bug#4026)
5
0cf34688
LMI
62011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7
b3dadd76
LMI
8 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9 key" (bug#4257).
10
0cf34688
LMI
11 * window.c (Fset_window_start): Doc fix (bug#4199).
12 (Fset_window_hscroll): Ditto.
13
270768cd
PE
142011-07-12 Paul Eggert <eggert@cs.ucla.edu>
15
077e3dda 16 Fix minor new problems caught by GCC 4.6.1.
270768cd 17 * term.c (init_tty): Remove unused local.
490011a6 18 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 19 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 20 not used otherwise.
270768cd 21
b1f58454
CY
222011-07-12 Chong Yidong <cyd@stupidchicken.com>
23
24 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
25
22b9578d
LMI
262011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
27
6e70ab07
LMI
28 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
29 are the mini-buffer and the echo area (bug#3320).
30
22b9578d
LMI
31 * term.c (init_tty): Remove support for supdup, c10 and perq
32 terminals, which are no longer supported (bug#1482).
33
8974cc9f
JB
342011-07-10 Johan Bockgård <bojohan@gnu.org>
35
36 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
37
a560d974
JD
382011-07-10 Jan Djärv <jan.h.d@swipnet.se>
39
40 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
41 for non-popups (Bug#3642).
42
1dae0f0a
AS
432011-07-10 Andreas Schwab <schwab@linux-m68k.org>
44
268c2c36 45 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 46 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
47 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
48 * cm.c (losecursor): Likewise.
1dae0f0a
AS
49 * data.c (fmod): Likewise.
50 * dispnew.c (swap_glyphs_in_rows): Likewise.
51 * emacs.c (memory_warning_signal): Likewise.
52 * floatfns.c (float_error): Likewise.
53 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
54 (otf_open, font_otf_capability, generate_otf_features)
55 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
56 Likewise.
57 * image.c (pbm_read_file): Likewise.
58 * indent.c (string_display_width): Likewise.
59 * intervals.c (check_for_interval, search_for_interval)
60 (inc_interval_count, count_intervals, root_interval)
61 (adjust_intervals_for_insertion, make_new_interval): Likewise.
62 * lread.c (defalias): Likewise.
268c2c36 63 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
64 * regex.c (set_image_of_range_1, set_image_of_range)
65 (regex_grow_registers): Likewise.
66 * sysdep.c (strerror): Likewise.
67 * termcap.c (valid_filename_p, tprint, main): Likewise.
68 * tparam.c (main): Likewise.
69 * unexhp9k800.c (run_time_remap, save_data_space)
70 (update_file_ptrs, read_header, write_header, calculate_checksum)
71 (copy_file, copy_rest, display_header): Likewise.
72 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
73 Likewise.
74 * xdisp.c (check_it): Likewise.
75 * xfaces.c (register_color, unregister_color, unregister_colors):
76 Likewise.
77 * xfns.c (print_fontset_result): Likewise.
78 * xrdb.c (member, fatal, main): Likewise.
79
99033785
PE
802011-07-10 Paul Eggert <eggert@cs.ucla.edu>
81
82 Fix minor problems found by static checking (Bug#9031).
83 * chartab.c (char_table_set_range, map_sub_char_table):
84 Remove unused locals.
85 (uniprop_table): Now static.
86 * composite.c (_work_char): Remove unused static var.
87
9cb2ac56
JB
882011-07-09 Juanma Barranquero <lekktu@gmail.com>
89
90 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
91
f25661f0
JD
922011-07-09 Jan Djärv <jan.h.d@swipnet.se>
93
94 * gtkutil.c (qttip_cb): Remove code without function.
95
8278c4fe
EZ
962011-07-09 Eli Zaretskii <eliz@gnu.org>
97
98 * w32.c (pthread_sigmask): New stub.
99
1692ae2d 1002011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 101
8a6ebd58 102 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
103 sigprocmask is portable only for single-threaded applications, and
104 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
105 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
106 (LIBES): Use it.
107 * callproc.c (Fcall_process):
108 * process.c (create_process):
109 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
110 Use pthread_sigmask, not sigprocmask.
123403e4 111
1b854618
JD
1122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
113
114 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
115 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
116 wrong (Bug#8591).
117
3fe4b549
JD
1182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
119
0ce7e563
JD
120 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
121 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
122 (xg_hide_tooltip): Fix comment.
123
3fe4b549
JD
124 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
125 in registerServicesMenuSendTypes.
126 (validRequestorForSendType): Don't check ns_return_types.
127
128 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
129 ns_return_type.
130
5df75e47
JR
1312011-07-08 Jason Rumney <jasonr@gnu.org>
132
133 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
134 frame struct members of non-existent frames (Bug#6284).
135
699c10bd
JD
1362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
137
4393663b
JD
138 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
139 variable firstTime not needed on OSX >= 10.6.
140 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
141 >= 10.5. Use setKnobProportion, setDoubleValue.
142
143 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
144 (MAC_OS_X_VERSION_10_5): Define if not defined.
145 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
146 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
147 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
148
149 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
150 cString and lossyCString on OSX >= 10.4
151
152 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
153 sizeToFit on OSX >= 10.2.
154
155 * nsimage.m (allocInitFromFile): Don't use deprecated method
156 bestRepresentationForDevice on OSX >= 10.6.
157
158 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
159 to avoid warning.
160
161 * emacs.c: Declare unexec_init_emacs_zone.
162
a63e0781
JD
163 * nsgui.h: Fix compiler warning about gnulib redefining verify.
164
699c10bd
JD
165 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
166
167 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
168 on svcsMenu (Bug#8842).
169
170 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
171 ns_return_types.
172 (Fns_list_services): Just return Qnil on 10.6, code not working there.
173
174 * nsterm.m (QUTF8_STRING): Declare.
175 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
176 (validRequestorForSendType): Return type is (id).
177 Change indexOfObjectIdenticalTo to indexOfObject.
178 Check if we have local selection before returning self (Bug#8842).
179 (writeSelectionToPasteboard): Put local selection into paste board
180 if we have a local selection (Bug#8842).
181 (syms_of_nsterm): DEFSYM QUTF8_STRING.
182
183 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
184 (ns_get_local_selection): Declare.
185
54e10184
LMI
1862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
187
9888ff71
LMI
188 * keymap.c (describe_map_tree): Don't insert a double newline at
189 the end of the buffer (bug#1169) and return whether we inserted
190 something.
191
54e10184
LMI
192 * callint.c (Fcall_interactively): Change "reading args" to
193 "providing args" to try to clarify what it does (bug#1010).
194
15fa4783
KH
1952011-07-07 Kenichi Handa <handa@m17n.org>
196
197 * composite.c (composition_compute_stop_pos): Ignore a static
198 composition starting before CHARPOS (Bug#8915).
199
200 * xdisp.c (handle_composition_prop): Likewise.
201
a8815b00
EZ
2022011-07-07 Eli Zaretskii <eliz@gnu.org>
203
204 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
205 (Bug#9015)
206
ef7b981d 2072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
208
209 * character.h (unicode_category_t): New enum type.
210
211 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
212 (Qchar_code_property_table): New variable.
213 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
214 (UNIPROP_COMPRESSED_FORM_P): New macros.
215 (char_table_ascii): Uncompress the compressed values.
216 (sub_char_table_ref): New arg is_uniprop. Callers changed.
217 Uncompress the compressed values.
218 (sub_char_table_ref_and_range): Likewise.
219 (char_table_ref_and_range): Uncompress the compressed values.
220 (sub_char_table_set): New arg is_uniprop. Callers changed.
221 Uncompress the compressed values.
222 (sub_char_table_set_range): Args changed. Callers changed.
223 (char_table_set_range): Adjuted for the above change.
224 (map_sub_char_table): Delete args default_val and parent. Add arg
225 top. Give decoded values to a Lisp function.
226 (map_char_table): Adjusted for the above change. Give decoded
227 values to a Lisp function. Gcpro more variables.
228 (uniprop_table_uncompress)
229 (uniprop_decode_value_run_length): New functions.
230 (uniprop_decoder, uniprop_decoder_count): New variables.
231 (uniprop_get_decoder, uniprop_encode_value_character)
232 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
233 New functions.
234 (uniprop_encoder, uniprop_encoder_count): New variables.
235 (uniprop_get_encoder, uniprop_table)
236 (Funicode_property_table_internal, Fget_unicode_property_internal)
237 (Fput_unicode_property_internal): New functions.
238 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
239 Sunicode_property_table_internal, Sget_unicode_property_internal,
240 and Sput_unicode_property_internal. Defvar_lisp
241 char-code-property-alist.
242
243 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
244 Vunicode_category_table.
245
246 * font.c (font_range): Adjusted for the change of
247 Vunicode_category_table.
248
76b397fb
DN
2492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
250
251 * m/iris4d.h: Remove file, move contents ...
252 * s/irix6-5.h: ... here.
253
22b4128e
PE
2542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
255
256 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
257 * alloc.c (mark_buffer):
258 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
259 (clone_per_buffer_values): Don't assume that
22b4128e
PE
260 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
261 This isn't true in general, and it's particularly not true
262 if Emacs is configured with --with-wide-int.
263 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
264 New macros, used in the buffer.c change.
265
869795d6
JD
2662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
267
268 * xsettings.c: Use both GConf and GSettings if both are available.
269 (store_config_changed_event): Add comment.
270 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
271 (store_tool_bar_style_changed): New functions.
272 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
273 (struct xsettings): Move font inside HAVE_XFT.
274 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
275 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
276 Move inside HAVE_XFT.
277 (something_changed_gsettingsCB): Renamed from something_changedCB.
278 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
279 also.
280 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
281 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
282 (something_changed_gconfCB): Renamed from something_changedCB.
283 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
284 (parse_settings): Move check for font inside HAVE_XFT.
285 (read_settings, apply_xft_settings): Add comment.
286 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
287 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
288 call store_font_name_changed.
289 (xft_settings_event): Add comment.
290 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
291 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
292 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
293 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
294 (xsettings_initialize): Call init_gsettings last.
295 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
296 comment.
297
d8ed26bd
PE
2982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
299
300 Random fixes. E.g., (random) never returned negative values.
301 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
302 subseconds part to the entropy, as that's a bit more random.
303 Prefer signed to unsigned, since the signedness doesn't matter and
304 in general we prefer signed. When given a limit, use a
305 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
306 latter isn't right if USE_2_TAGS_FOR_INTS.
307 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
308 not 0..VALMASK. Don't discard "excess" bits that random () returns.
309
cabf1cac
SM
3102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
311
312 * textprop.c (text_property_stickiness):
313 Obey Vtext_property_default_nonsticky.
314 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
315 * w32fns.c (syms_of_w32fns):
316 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
317
6e9b2be9
PE
3182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
319
320 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
321 This is more efficient than Ffile_directory_p and avoids a minor race.
322
90186c68
LMI
3232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
324
7c301272
LMI
325 * buffer.c (Foverlay_put): Say what the return value is
326 (bug#7835).
327
c4f2d8d4
LMI
328 * fileio.c (barf_or_query_if_file_exists): Check first if the file
329 is a directory before asking whether to use the file name
330 (bug#7564).
ad637907
LMI
331 (barf_or_query_if_file_exists): Make the "File is a directory"
332 error be more correct.
c4f2d8d4 333
90186c68
LMI
334 * fns.c (Frequire): Remove the mention of the .gz files, since
335 that's installation-specific, but keep the mention of
336 `get-load-suffixes'.
337
da64016e
PE
3382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
339
340 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
341 Report string overflow if the output is too long.
342
7d47b580
JB
3432011-07-04 Juanma Barranquero <lekktu@gmail.com>
344
a555cb87
JB
345 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
346 (syms_of_gnutls): Remove duplicate DEFSYM for
347 Qgnutls_bootprop_verify_hostname_error, an error for
348 Qgnutls_bootprop_verify_error (which is no longer used).
349
7d47b580
JB
350 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
351 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
352 Also (re)move comments that are misplaced or no longer relevant.
353
1e49bfab
LMI
3542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
355
356 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
357
1485f4c0
CY
3582011-07-03 Chong Yidong <cyd@stupidchicken.com>
359
360 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
361 and background color parameters if they have been changed.
362
a9ab721e
LMI
3632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
364
365 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
366
cf7cff57
PE
3672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
368
2e13213d
PE
369 * xsettings.c (SYSTEM_FONT): Define only when used.
370 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
371
cf7cff57
PE
372 * keymap.c (access_keymap_1): Now static.
373
7a8e04f7
CY
3742011-07-02 Chong Yidong <cyd@stupidchicken.com>
375
376 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
377 leave any prefix arg for the up event (Bug#1586).
378
61352f62
LMI
3792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
380
69bb1ef7
LMI
381 * lread.c (syms_of_lread): Mention single symbols defined by
382 `defvar' or `defconst' (bug#7154).
383
61352f62 384 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 385 (Frequire): Mention get-load-suffixes.
61352f62 386
28545e04
MR
3872011-07-02 Martin Rudalics <rudalics@gmx.at>
388
389 * window.h (window): Remove clone_number slot.
390 * window.c (Fwindow_clone_number, Fset_window_clone_number):
391 Remove.
392 (make_parent_window, make_window, saved_window)
393 (Fset_window_configuration, save_window_save): Don't deal with
394 clone numbers.
395 * buffer.c (Qclone_number): Remove declaration.
396 (sort_overlays, overlay_strings): Don't deal with clone numbers.
397
3349e122
SM
3982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
399
400 Add multiple inheritance to keymaps.
401 * keymap.c (Fmake_composed_keymap): New function.
402 (Fset_keymap_parent): Simplify.
403 (fix_submap_inheritance): Remove.
404 (access_keymap_1): New function extracted from access_keymap to handle
405 embedded parents and handle lists of maps.
406 (access_keymap): Use it.
407 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
408 (Fcopy_keymap): Handle embedded parents.
409 (Fcommand_remapping, define_as_prefix): Simplify.
410 (Fkey_binding): Simplify.
411 (syms_of_keymap): Move minibuffer-local-completion-map,
412 minibuffer-local-filename-completion-map,
413 minibuffer-local-must-match-map, and
414 minibuffer-local-filename-must-match-map to Elisp.
415 (syms_of_keymap): Defsubr make-composed-keymap.
416 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
417 (parse_menu_item): Trivial simplification.
418
3279eb87
GM
4192011-07-01 Glenn Morris <rgm@gnu.org>
420
421 * Makefile.in (SETTINGS_LIBS): Fix typo.
422
4550efdf
KI
4232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
424
425 * coding.c (Fencode_coding_string): Record the last coding system
426 used, as the function doc string says (bug#8738).
427
0949d2b6
JD
4282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
429
430 * xsettings.c (store_monospaced_changed): Take new font as arg and
431 check for change against current_mono_font.
432 (EMACS_TYPE_SETTINGS): Remove this and related defines.
433 (emacs_settings_constructor, emacs_settings_get_property)
434 (emacs_settings_set_property, emacs_settings_class_init)
435 (emacs_settings_init, gsettings_obj): Remove.
436 (something_changedCB): New function for HAVE_GSETTINGS.
437 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
438 with value as argument.
439 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
440 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 441 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
442 "changed".
443
444 * xgselect.c: Add defined (HAVE_GSETTINGS).
445 (xgselect_initialize): Ditto.
446
447 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
448 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
449 xg_select.
450
bbc6b304
PE
4512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
452
453 * eval.c (struct backtrace): Simplify and port the data structure.
454 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
455 signed bit field, as this assumption is not portable and it makes
456 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
457 "char debug_on_exit : 1" as this is not portable either; instead,
458 use the portable "unsigned int debug_on_exit : 1". Remove unused
459 member evalargs. Remove obsolete comments about cc bombing out.
460
9851bfc5
JD
4612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
462
51bb811f 463 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
464 Let HAVE_GSETTINGS override HAVE_GCONF.
465 (store_monospaced_changed): New function.
466 (EMACS_SETTINGS): A new type derived from GObject to handle
467 GSettings notifications.
468 (emacs_settings_constructor, emacs_settings_get_property)
469 (emacs_settings_set_property, emacs_settings_class_init):
470 New functions.
471 (gsettings_client, gsettings_obj): New variables.
472 (GSETTINGS_SCHEMA): New define.
473 (something_changedCB): Call store_monospaced_changed.
474 (init_gsettings): New function.
475 (xsettings_initialize): Call init_gsettings.
476 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
477 to NULL.
478
479 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
480 GCONF_CFLAGS/LIBS.
481
5386012d
MR
4822011-06-29 Martin Rudalics <rudalics@gmx.at>
483
484 * window.c (resize_root_window, grow_mini_window)
485 (shrink_mini_window): Rename Qresize_root_window to
486 Qwindow_resize_root_window and Qresize_root_window_vertically to
487 Qwindow_resize_root_window_vertically.
488
f13e0b08
PE
4892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
490
491 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
492
94515237
JB
4932011-06-27 Juanma Barranquero <lekktu@gmail.com>
494
495 * makefile.w32-in: Redesign dependencies so they reflect more
496 clearly which files are directly included by each source file,
497 and not through other includes.
498
e43b6e43
MR
4992011-06-27 Martin Rudalics <rudalics@gmx.at>
500
501 * buffer.c (Qclone_number): Declare static and DEFSYM it.
502 (sort_overlays, overlay_strings): When an overlay's clone number
503 matches the window's clone number process the overlay even if
504 the overlay's window property doesn't match the current window.
505
d68443dc
MR
506 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
507 (Fwindow_hchild): Rename to Fwindow_left_child.
508 (Fwindow_next): Rename to Fwindow_next_sibling.
509 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
510 (resize_window_check): Rename to window_resize_check.
511 (resize_window_apply): Rename to window_resize_apply.
512 (Fresize_window_apply): Rename to Fwindow_resize_apply.
513 (Fdelete_other_windows_internal, resize_frame_windows)
514 (Fsplit_window_internal, Fdelete_window_internal)
515 (grow_mini_window, shrink_mini_window)
516 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 517
c7e73be5
JD
5182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
519
520 * emacsgtkfixed.h: State that this is only used with Gtk+3.
521 (emacs_fixed_set_min_size): Remove.
522 (emacs_fixed_new): Take frame as argument.
523
524 * emacsgtkfixed.c: State that this is only used with Gtk+3.
525 (_EmacsFixedPrivate): Remove minwidth/height.
526 Add struct frame *f.
527 (emacs_fixed_init): Initialize priv->f.
528 (get_parent_class, emacs_fixed_set_min_size): Remove.
529 (emacs_fixed_new): Set priv->f to argument.
530 (emacs_fixed_get_preferred_width)
531 (emacs_fixed_get_preferred_height): Use min_width/height from
532 frames size_hint to set minimum and natural (Bug#8919).
533 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
534 and use min_width/height from frames size_hint to set
535 min_width/height (Bug#8919).
536
537 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
538 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
539 Fix indentation.
c7e73be5 540
cf99dcf8
EZ
5412011-06-26 Eli Zaretskii <eliz@gnu.org>
542
543 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
544 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
545 called at ZV.
546
029529ac
CY
5472011-06-26 Chong Yidong <cyd@stupidchicken.com>
548
549 * process.c (wait_reading_process_output): Bypass select if
550 waiting for a cell while ignoring keyboard input, and input is
551 pending. Suggested by Jan Djärv (Bug#8869).
552
7a7ef429
PE
5532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
554
555 Use gnulib's dup2 module instead of rolling our own.
556 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
557
11fdef7d 5582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
559
560 * dispnew.c (scrolling_window): Before scrolling, turn off a
561 mouse-highlight in the window being scrolled.
562
cd3520a4
JB
5632011-06-24 Juanma Barranquero <lekktu@gmail.com>
564
565 Move DEFSYM to lisp.h and use everywhere.
566
567 * character.h (DEFSYM): Move declaration...
568 * lisp.h (DEFSYM): ...here.
569
570 * gnutls.c:
571 * minibuf.c:
572 * w32menu.c:
573 * w32proc.c:
574 * w32select.c: Don't include character.h.
575
576 * alloc.c (syms_of_alloc):
577 * buffer.c (syms_of_buffer):
578 * bytecode.c (syms_of_bytecode):
579 * callint.c (syms_of_callint):
580 * casefiddle.c (syms_of_casefiddle):
581 * casetab.c (init_casetab_once):
582 * category.c (init_category_once, syms_of_category):
583 * ccl.c (syms_of_ccl):
584 * cmds.c (syms_of_cmds):
585 * composite.c (syms_of_composite):
586 * dbusbind.c (syms_of_dbusbind):
587 * dired.c (syms_of_dired):
588 * dispnew.c (syms_of_display):
589 * doc.c (syms_of_doc):
590 * editfns.c (syms_of_editfns):
591 * emacs.c (syms_of_emacs):
592 * eval.c (syms_of_eval):
593 * fileio.c (syms_of_fileio):
594 * fns.c (syms_of_fns):
595 * frame.c (syms_of_frame):
596 * fringe.c (syms_of_fringe):
597 * insdel.c (syms_of_insdel):
598 * keymap.c (syms_of_keymap):
599 * lread.c (init_obarray, syms_of_lread):
600 * macros.c (syms_of_macros):
601 * msdos.c (syms_of_msdos):
602 * print.c (syms_of_print):
603 * process.c (syms_of_process):
604 * search.c (syms_of_search):
605 * sound.c (syms_of_sound):
606 * syntax.c (init_syntax_once, syms_of_syntax):
607 * terminal.c (syms_of_terminal):
608 * textprop.c (syms_of_textprop):
609 * undo.c (syms_of_undo):
610 * w32.c (globals_of_w32):
611 * window.c (syms_of_window):
612 * xdisp.c (syms_of_xdisp):
613 * xfaces.c (syms_of_xfaces):
614 * xfns.c (syms_of_xfns):
615 * xmenu.c (syms_of_xmenu):
616 * xsettings.c (syms_of_xsettings):
617 * xterm.c (syms_of_xterm): Use DEFSYM.
618
4228cf16
TZ
6192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
620
cd3520a4 621 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 622
7fcccf1e
PE
6232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
624
7efb4e0e
PE
625 Integer and buffer overflow fixes (Bug#8873).
626
ff5844ad
PE
627 * print.c (printchar, strout): Check for string overflow.
628 (PRINTPREPARE, printchar, strout):
629 Don't set size unless allocation succeeds.
630
90532f02
PE
631 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
632 for sizes. Check for string overflow more accurately.
633 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
634
6d84508d
PE
635 * macros.c: Integer and buffer overflow fixes.
636 * keyboard.h (struct keyboard.kbd_macro_bufsize):
637 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
638 Use ptrdiff_t, not int, for sizes.
639 Don't increment bufsize until after realloc succeeds.
640 Check for size-calculation overflow.
641 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
642
437b2cb4
PE
643 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
644
8b9ac8b4
PE
645 * lread.c: Integer overflow fixes.
646 (read_integer): Radix is now EMACS_INT, not int,
647 to improve quality of diagnostics for out-of-range radices.
648 Calculate buffer size correctly for out-of-range radices.
649 (read1): Check for integer overflow in radices, and in
650 read-circle numbers.
82cb60d3
PE
651 (read_escape): Avoid int overflow.
652 (Fload, openp, read_buffer_size, read1)
653 (substitute_object_recurse, read_vector, read_list, map_obarray):
654 Use ptrdiff_t, not int, for sizes.
655 (read1): Use EMACS_INT, not int, for sizes.
20270765 656 Check for size overflow.
8b9ac8b4 657
7fcccf1e
PE
658 * image.c (cache_image): Check for size arithmetic overflow.
659
bfbbd7e7
PE
660 * lread.c: Integer overflow issues.
661 (saved_doc_string_size, saved_doc_string_length)
662 (prev_saved_doc_string_size, prev_saved_doc_string_length):
663 Now ptrdiff_t, not int.
664 (read1): Don't assume doc string length fits in int. Check for
665 out-of-range doc string lengths.
666 (read_list): Don't assume file position fits in int.
39019e54 667 (read_escape): Check for hex character overflow.
bfbbd7e7 668
4e323265
LL
6692011-06-22 Leo Liu <sdl.web@gmail.com>
670
671 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
672 Move to minibuffer.el.
673
85fece3e
PE
6742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
675
20b84ce9 676 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
677 The following patches are for when GLYPH_DEBUG && !XASSERT.
678 * dispextern.h (trace_redisplay_p, dump_glyph_string):
679 * dispnew.c (flush_stdout):
680 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
681 Mark as externally visible.
682 * dispnew.c (check_window_matrix_pointers): Now static.
683 * dispnew.c (window_to_frame_vpos):
684 * xfns.c (unwind_create_frame):
685 * xterm.c (x_check_font): Remove unused local.
686 * scroll.c (CHECK_BOUNDS):
687 * xfaces.c (cache_fache): Rename local to avoid shadowing.
688 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
689 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
690 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
691 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
692 Now static.
693 (debug_method_add): Use va_list and vsprintf rather than relying
694 on undefined behavior with wrong number of arguments.
695 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
696 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
697 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
698 since we're not interested in debugging glyphs with old libraries.
699 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
700 GCC 4.6.0's static checking.
701
0766b489
PE
7022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
703
31fd4b32
PE
704 Integer overflow and signedness fixes (Bug#8873).
705 A few related buffer overrun fixes, too.
706
b79e8648
PE
707 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
708
0766b489
PE
709 * dispextern.h (struct face.stipple):
710 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
711 (x_bitmap_mask, x_allocate_bitmap_record)
712 (x_create_bitmap_from_data, x_create_bitmap_from_file)
713 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
714 (x_create_bitmap_from_xpm_data):
715 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
716 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
717 (.bitmaps_last):
718 * xfaces.c (load_pixmap):
719 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
720 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
721 (.bitmaps_last, struct x_output.icon_bitmap):
722 Use ptrdiff_t, not int, for bitmap indexes.
723 (x_allocate_bitmap_record): Check for size overflow.
724 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
725
b081724f
PE
726 Use ptrdiff_t, not int, for overlay counts.
727 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
728 * editfns.c (overlays_around, get_pos_property):
729 * textprop.c (get_char_property_and_overlay):
730 * xdisp.c (next_overlay_change, note_mouse_highlight):
731 * xfaces.c (face_at_buffer_position):
21514da7
PE
732 * buffer.c (OVERLAY_COUNT_MAX): New macro.
733 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
734 (Fnext_overlay_change, Fprevious_overlay_change)
735 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 736 Use ptrdiff_t, not int, for sizes.
21514da7 737 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 738
3de73e5e
PE
739 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
740
2606c57b
PE
741 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
742 (x_session_initialize): Do not assume string length fits in int.
743
aaafe47a
PE
744 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
745 This is unlikely, but can occur if DPI is outlandish.
746
2674ddc8 747 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
748 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
749
28154962
PE
750 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
751 * xrdb.c (magic_file_p, search_magic_path):
752 Omit last arg SUFFIX; it was always 0. All callers changed.
753 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
754
7de51af5
PE
755 * xfont.c (xfont_match): Avoid need for strlen.
756
25ed6cc3
PE
757 * xfns.c: Don't assume strlen fits in int.
758 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
759
4eab31dd
PE
760 * xdisp.c (message_log_check_duplicate): Return intmax_t,
761 not unsigned long, as we prefer signed integers. All callers changed.
762 Detect integer overflow in repeat count.
763 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 764 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 765
171e2a58
PE
766 * termcap.c: Don't assume sizes fit in int and never overflow.
767 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
768 (gobble_line): Check for size-calculation overflow.
769
ad39faca 770 * minibuf.c (Fread_buffer):
6e5bb2dc 771 * lread.c (intern, intern_c_string):
74ca2eb3
PE
772 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
773 Don't assume string length fits in int.
774
52c61c22 775 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
776 * gtkutil.c (style_changed_cb): Avoid need for strlen.
777
b5b8c9e5
PE
778 * font.c: Don't assume string length fits in int.
779 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
780 Use ptrdiff_t, not int.
ccd6111c
PE
781 (font_intern_prop): Don't assume string length fits in int.
782 Don't assume integer property fits in fixnum.
783 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 784
882f0d81 785 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 786 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
787 Reformulate so as not to need the command string.
788 Invoke gzip -cd rather than gunzip, as it's more portable.
789 (lock_info_type, lock_file_1, lock_file):
790 Don't assume pid_t and time_t fit in unsigned long.
791 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
792 (current_lock_owner): Prefer signed type for sizes.
793 Use memcpy, not strncpy, where memcpy is what is really wanted.
794 Don't assume (via atoi) that time_t and pid_t fit in int.
795 Check for time_t and/or pid_t out of range, e.g., via a network share.
796 Don't alloca where an auto var works fine.
797
93f4cf88
PE
798 * fileio.c: Fix some integer overflow issues.
799 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
800 Don't assume string length fits in int.
801 (directory_file_name): Don't assume string length fits in long.
802 (make_temp_name): Don't assume pid fits in int, or that its print
803 length is less than 20.
804
f3e92b69
PE
805 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
806
1bfdaf10
PE
807 * coding.c (make_subsidiaries): Don't assume string length fits in int.
808
35016e9a
PE
809 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
810
3d1e65a1
PE
811 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
812 We prefer signed integers, even for size calculations.
813
0b963a93
PE
814 * emacs.c: Don't assume string length fits in 'int'.
815 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
816 (main): Don't invoke strlen when not needed.
817
573f4b54
PE
818 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
819 (XD_DEBUG_MESSAGE): Don't waste a byte.
820
989f33ba
PE
821 * callproc.c (getenv_internal_1, getenv_internal)
822 (Fgetenv_internal):
965d34eb
PE
823 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
824
e4d29b33
PE
825 * lread.c (invalid_syntax): Omit length argument.
826 All uses changed. This doesn't fix a bug, but it simplifies the
827 code away from its former Hollerith-constant appearance, and it's
828 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 829 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 830
eb49b136
PE
831 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
832 This didn't break anything, but it didn't help either.
833 It's confusing to put a bogus integer in a place where the actual
834 value does not matter.
9f62aeb1 835 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 836 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 837
15375a22
PE
838 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
839 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
840 implementation.
b61cc01c
PE
841 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
842 We prefer signed types, and the value cannot exceed the EMACS_INT
843 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
844 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
845 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
846 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 847
53b2623d
PE
848 * indent.c (sane_tab_width): New function.
849 (current_column, scan_for_column, Findent_to, position_indentation)
850 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 851 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 852
51cab52b 853 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 854
f2ed8a70
PE
855 * lisp.h (lint_assume): New macro.
856 * composite.c (composition_gstring_put_cache):
857 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
858
abe80cc6
PE
859 * editfns.c, insdel.c:
860 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 861
b02c740e
PE
862 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
863
ebc96716
PE
864 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
865
b4e50fa0 866 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 867 Use much-faster test for byte-length change.
311d5d7c 868 Don't assume string byte-length fits in 'int'.
a4cf38e4 869 Check that character arg fits in 'int'.
85461888 870 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 871
c0c1ee9f
PE
872 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
873
a498d7f4
PE
874 * fns.c (concat): Catch string overflow earlier.
875 Do not rely on integer wraparound.
876
51cab52b
PE
877 * dispextern.h (struct it.overlay_strings_charpos)
878 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
879 * xdisp.c (forward_to_next_line_start)
880 (back_to_previous_visible_line_start)
881 (reseat_at_next_visible_line_start, next_element_from_buffer):
882 Don't arbitrarily truncate the value of 'selective' to int.
883
76031fad
PE
884 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
885
5eb55db9
PE
886 * composite.c: Don't truncate sizes to 'int'.
887 (composition_gstring_p, composition_reseat_it)
888 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
889 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
890 not EMACS_UINT, for indexes.
5eb55db9 891
0703a717
PE
892 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
893
d6202519
PE
894 * buffer.c: Include <verify.h>.
895 (struct sortvec.priority, struct sortstr.priority):
8961a454 896 Now EMACS_INT, not int.
c20998a7 897 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
898 (struct sortstr.size, record_overlay_string)
899 (struct sortstrlist.size, struct sortlist.used):
900 Don't truncate size to int.
901 (record_overlay_string): Check for size-calculation overflow.
d6202519 902 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 903
d5a19415
JM
9042011-06-22 Jim Meyering <meyering@redhat.com>
905
029529ac 906 Don't leak an XBM-image-sized buffer
d5a19415
JM
907 * image.c (xbm_load): Free the image buffer after using it.
908
a9041e6c
PE
9092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
910
911 Port to Sun C.
912 * composite.c (find_automatic_composition): Omit needless 'return 0;'
913 that Sun C diagnosed.
914 * fns.c (secure_hash): Fix pointer signedness issue.
915 * intervals.c (static_offset_intervals): New function.
916 (offset_intervals): Use it.
917
7f3f739f
LL
9182011-06-21 Leo Liu <sdl.web@gmail.com>
919
920 * deps.mk (fns.o):
921 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
922 sha512.h.
923
924 * fns.c (secure_hash): Rename from crypto_hash_function and change
925 the first arg to accept symbols.
5b66d427 926 (Fsecure_hash): New primitive.
7f3f739f
LL
927 (syms_of_fns): New symbols.
928
76147d94
DD
9292011-06-20 Deniz Dogan <deniz@dogan.se>
930
931 * process.c (Fset_process_buffer): Clarify return value in
932 docstring.
933
7d7d0045
CY
9342011-06-18 Chong Yidong <cyd@stupidchicken.com>
935
936 * dispnew.c (add_window_display_history): Use BVAR.
937
938 * xdisp.c (debug_method_add): Use BVAR.
939 (check_window_end, dump_glyph_matrix, dump_glyph)
940 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
941
942 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
943 Likewise.
944
945 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
946 check till after the cache is created in init_frame_faces.
947
ff2bc410
SM
9482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
949
950 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
951
28177add
PE
9522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
953
dd3482fe
PE
954 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
955 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
956 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
957
393d71f3 958 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
959 * fileio.c (Finsert_file_contents):
960 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
961 Remove the old (too-loose) buffer overflow checks.
962 They weren't needed, since make_gap checks for buffer overflow.
963 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
964 The old code merely checked for Emacs fixnum overflow, and relied
965 on undefined (wraparound) behavior. The new code avoids undefined
966 behavior, and also checks for ptrdiff_t and/or size_t overflow.
967
2e6813b0 968 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
969 Tune. Don't use wider integers than needed. Don't use alloca.
970 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 971
599a9e4f
PE
972 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
973
99561444
PE
974 * insdel.c, lisp.h (buffer_overflow): New function.
975 (insert_from_buffer_1, replace_range, replace_range_2):
976 * insdel.c (make_gap_larger):
977 * editfns.c (Finsert_char):
978 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
979
28177add
PE
980 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
981
e69dafad
PE
9822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
983
a7af7fde 984 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 985
b1c46f02
PE
986 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
987 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
988
e69dafad
PE
989 * fileio.c: Don't assume EMACS_INT fits in off_t.
990 (emacs_lseek): New static function.
991 (Finsert_file_contents, Fwrite_region): Use it.
992 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
993
566684ea
PE
994 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
995
e6966cd6
PE
996 * fns.c: Don't overflow int when computing a list length.
997 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
998 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
999 truncation on 64-bit hosts. Check for QUIT every
1000 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1001 faster and is responsive enough.
1002 (Flength): Report an error instead of overflowing an integer.
1003 (Fsafe_length): Return a float if the value is not representable
1004 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1005 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1006 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1007
dd0b0efb
PE
1008 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1009 (header_size, word_size): New constants.
1010 (allocate_vectorlike): Don't check size overflow here.
1011 (allocate_vector): Check it here instead, since this is the only
1012 caller of allocate_vectorlike that could cause overflow.
1013 Check that the new vector's length is representable as a fixnum.
1014
86fe5cfe
PE
1015 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1016 The previous code was bogus. For example, next_almost_prime (32)
1017 returned 39, which is undesirable as it is a multiple of 3; and
1018 next_almost_prime (24) returned 25, which is a multiple of 5 so
1019 why was the code bothering to check for multiples of 7?
1020
80e88859
PE
1021 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1022
4a2f0ad6
PE
1023 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1024
f66c7cf8
PE
1025 Variadic C functions now count arguments with ptrdiff_t.
1026 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1027 Back then I didn't know that the Emacs coding style prefers signed int.
1028 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1029 were being counted with int, which may truncate counts on 64-bit
1030 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1031 * lisp.h (struct Lisp_Subr.function.aMANY)
1032 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1033 Arg counts are now ptrdiff_t, not size_t.
1034 All variadic functions and their callers changed accordingly.
1035 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1036 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1037 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1038 * callint.c (Fcall_interactively): Check arg count for overflow,
1039 to avoid potential buffer overrun. Use signed char, not 'int',
1040 for 'varies' array, so that we needn't bother to check its size
1041 calculation for overflow.
1042 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1043 * eval.c (apply_lambda):
1044 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1045 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1046 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1047
a1759b76
PE
1048 * callint.c (Fcall_interactively): Don't use index var as event count.
1049
d96be9fc
PE
1050 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1051 * mem-limits.h (SIZE): Remove; no longer used.
1052
a690a978 1053 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1054
578c21e6
PE
1055 Remove unnecessary casts.
1056 * xterm.c (x_term_init):
1057 * xfns.c (x_set_border_pixel):
1058 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1059 These aren't needed now that we assume ANSI C.
1060
96f53c6c
PE
1061 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1062 It's more likely to cause problems (due to unsigned overflow)
1063 than to cure them.
1064
83c77d31
PE
1065 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1066
ee2079f1
PE
1067 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1068
6da65536
PE
1069 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1070
7147c4a4
PE
1071 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1072
193e32d9
PE
1073 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1074
e5533da6
PE
1075 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1076
9910e595
PE
1077 GLYPH_CODE_FACE returns EMACS_INT, not int.
1078 * dispextern.h (merge_faces):
1079 * xfaces.c (merge_faces):
01103c44
PE
1080 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1081 Don't assume EMACS_INT fits in int.
9910e595 1082
2638320e
PE
1083 * character.h (CHAR_VALID_P): Remove unused parameter.
1084 * fontset.c, lisp.h, xdisp.c: All uses changed.
1085
045eb8d9
PE
1086 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1087
c1f134b5
PE
1088 * fns.c (concat): Minor tuning based on overflow analysis.
1089 This doesn't fix any bugs. Use int to hold character, instead
1090 of constantly refetching from Emacs object. Use XFASTINT, not
1091 XINT, for value known to be a character. Don't bother comparing
1092 a single byte to 0400, as it's always less.
1093
395fcb93 1094 * floatfns.c (Fexpt):
327eeec8
PE
1095 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1096
abbd3d23
PE
1097 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1098 for characters.
1099
684a03ef
PE
1100 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1101
0fed43f3
PE
1102 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1103 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1104 incorrectly succeed when S was a string, because 4294967386 was
1105 truncated before it was used.
1106
8fd02eb7
PE
1107 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1108 Otherwise, an out-of-range integer could cause undefined behavior
1109 on a 64-bit host.
1110
f8c86b69
PE
1111 * composite.c: Use int, not EMACS_INT, for characters.
1112 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1113 EMACS_INT, for values that are known to be in character range.
1114 This doesn't fix any bugs but is the usual style inside Emacs and
1115 may generate better code on 32-bit machines.
1116
34206dd2
PE
1117 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1118 This is for reasons similar to the recent CHAR_STRING fix.
1119 * charset.c (Fencode_char): Check that character arg is actually
1120 a character. Pass an int to ENCODE_CHAR.
1121 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1122 wider than 'int', as a compile-time check to prevent future regressions
1123 in this area.
1124
c5958d4c 1125 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1126
1127 Make sure a 64-bit char is never passed to CHAR_STRING.
1128 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1129 by silently ignoring the top 32 bits, allowing some values
1130 that were far too large to be valid characters.
1131 * character.h: Include <verify.h>.
1132 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1133 arguments are no wider than unsigned, as a compile-time check
1134 to prevent future regressions in this area.
1135 * data.c (Faset):
01103c44 1136 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1137 (Fsubst_char_in_region):
1138 * fns.c (concat):
1139 * xdisp.c (decode_mode_spec_coding):
1140 Adjust to CHAR_STRING's new requirement.
1141 * editfns.c (Finsert_char, Fsubst_char_in_region):
1142 * fns.c (concat): Check that character args are actually
1143 characters. Without this test, these functions did the wrong
1144 thing with wildly out-of-range values on 64-bit hosts.
1145
d37ca623
PE
1146 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1147 These casts should not be needed on 32-bit hosts, either.
1148 * keyboard.c (read_char):
1149 * lread.c (Fload): Remove casts to unsigned.
1150
ea204efb
PE
1151 * lisp.h (UNSIGNED_CMP): New macro.
1152 This fixes comparison bugs on 64-bit hosts.
1153 (ASCII_CHAR_P): Use it.
1154 * casefiddle.c (casify_object):
01103c44 1155 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1156 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1157 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1158 * dispextern.h (FACE_FROM_ID):
1159 * keyboard.c (read_char): Use UNSIGNED_CMP.
1160
41cb286c
PE
1161 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1162 not to EMACS_INT, to avoid GCC warning.
1163
4a1b9832
PE
1164 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1165
55daad71
PE
1166 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1167 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1168 isn't needed on 32-bit machines.
8f95c75c 1169
01103c44
PE
1170 * buffer.c (Fgenerate_new_buffer_name):
1171 Use EMACS_INT for count, not int.
0ceccced 1172 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1173
1174 * data.c (Qcompiled_function): Now static.
1175
c6f072e7
PE
1176 * window.c (window_body_lines): Now static.
1177
20ce5912
PE
1178 * image.c (gif_load): Rename local to avoid shadowing.
1179
9c4c5f81
PE
1180 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1181 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1182 * alloc.c (make_save_value): Integer argument is now of type
1183 ptrdiff_t, not int.
1184 (mark_object): Use ptrdiff_t, not int.
1185 * lisp.h (pD): New macro.
1186 * print.c (print_object): Use it.
1187
c0c5c8ae
PE
1188 * alloc.c: Use EMACS_INT, not int, to count objects.
1189 (total_conses, total_markers, total_symbols, total_vector_size)
1190 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1191 (total_free_floats, total_floats, total_free_intervals)
1192 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1193 Now EMACS_INT, not int. All uses changed.
1194 (Fgarbage_collect): Compute overall total using a double, so that
1195 integer overflow is less likely to be a problem. Check for overflow
1196 when converting back to an integer.
5a25e253
PE
1197 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1198 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1199 These were 'int' variables that could overflow on 64-bit hosts;
1200 they were never used, so remove them instead of repairing them.
211a0b2a 1201 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1202 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1203 Previously, this ceilinged at INT_MAX, but that doesn't work on
1204 64-bit machines.
e46bb31a 1205 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1206
c78baabf 1207 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1208 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1209 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1210 when a (possibly-narrower) signed value would do just as well.
1211 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1212
c9d624c6
PE
1213 * alloc.c: Catch some string size overflows that we were missing.
1214 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1215 for convenience in STRING_BYTES_MAX.
1216 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1217 The definition here is exact; the one in lisp.h was approximate.
1218 (allocate_string_data): Check for string overflow. This catches
1219 some instances we weren't catching before. Also, it catches
1220 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1221 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1222 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1223
c9d624c6
PE
1224 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1225 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1226 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1227
353032ce
PE
1228 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1229
2bccce07
PE
1230 * alloc.c (Fmake_string): Check for out-of-range init.
1231
0ac30604
SM
12322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1233
1234 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1235
c195f2de
JD
12362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1239 xg_get_default_scrollbar_width.
1240
1241 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1242 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1243 (style_changed_cb): Call update_theme_scrollbar_width and call
1244 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1245 all frames (Bug#8505).
1246 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1247 Call gtk_window_set_resizable if HAVE_GTK3.
1248 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1249 and height if HAVE_GTK3 (Bug#8505).
1250 (scroll_bar_width_for_theme): New variable.
1251 (update_theme_scrollbar_width): New function.
1252 (xg_get_default_scrollbar_width): Move code to
1253 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1254 (xg_initialize): Call update_theme_scrollbar_width.
1255
1256 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1257
1258 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1259
e10ac9f1
MR
12602011-06-12 Martin Rudalics <rudalics@gmx.at>
1261
1262 * frame.c (make_frame): Call other_buffer_safely instead of
1263 other_buffer.
1264
1265 * window.c (temp_output_buffer_show): Call display_buffer with
1266 second argument Vtemp_buffer_show_specifiers and reset latter
1267 immediately after the call.
1268 (Vtemp_buffer_show_specifiers): New variable.
1269 (auto_window_vscroll_p, next_screen_context_lines)
1270 (Vscroll_preserve_screen_position): Remove leading asterisks from
1271 doc-strings.
1272
2d3c217e 12732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1274
7b7f97e8 1275 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1276 * buffer.c (Qclone_number): Remove for now, as it's unused.
1277 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1278 (record_buffer): Remove unused local.
1279 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1280 (set_frame_buffer_list): Remove; unused.
1281 * frame.h (other_visible_frames): Remove decl.
1282 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1283 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1284 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1285 if HAVE_GPM.
1286 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1287 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1288 Define only if HAVE_GPM.
1289 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1290 (update_hints_inhibit): Remove; never set. All uses removed.
1291 * widgetprv.h (emacsFrameClassRec): Remove decl.
1292 * window.c (delete_deletable_window): Now returns void, since it
1293 wasn't returning anything.
1294 (compare_window_configurations): Remove unused locals.
1295 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1296 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1297 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1298 the same widths as pointers. This follows up on the 2011-05-06 patch.
1299 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1300 * xterm.h: Likewise.
1301 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1302
1384b89e
JB
13032011-06-12 Juanma Barranquero <lekktu@gmail.com>
1304
1305 * makefile.w32-in: Update dependencies.
1306 (LISP_H): Add lib/intprops.h.
1307
1100a63c
CY
13082011-06-11 Chong Yidong <cyd@stupidchicken.com>
1309
1310 * image.c (gif_load): Add animation frame delay to the metadata.
1311 (syms_of_image): Use DEFSYM. New symbol `delay'.
1312
6198ccd0
MR
13132011-06-11 Martin Rudalics <rudalics@gmx.at>
1314
1315 * window.c (delete_deletable_window): Re-add.
1316 (Fset_window_configuration): Rewrite to handle dead buffers and
1317 consequently deletable windows.
1318 (window_tree, Fwindow_tree): Remove. Supply functionality in
1319 window.el.
1320 (compare_window_configurations): Simplify code.
1321
b6e3633c
AS
13222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1323
1ab0dee5
AS
1324 * image.c (imagemagick_load_image): Fix type mismatch.
1325 (Fimagemagick_types): Likewise.
1326
b6e3633c
AS
1327 * window.h (replace_buffer_in_windows): Declare.
1328
9397e56f
MR
13292011-06-11 Martin Rudalics <rudalics@gmx.at>
1330
1331 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1332 Qclone_number. Remove external declaration of Qdelete_window.
1333 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1334 code.
1335 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1336 Qbuffer_list_update_hook if allowed.
1337 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1338 buffer list implementation.
1339 (other_buffer_safely): New function.
1340 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1341 calls to replace_buffer_in_windows and
1342 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1343 if allowed.
1344 (record_buffer): Inhibit quitting and rewrite using quittable
1345 functions. Run Qbuffer_list_update_hook if allowed.
1346 (Frecord_buffer, Funrecord_buffer): New functions.
1347 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1348 switch-to-buffer to window.el.
1349 (bury-buffer): Move to window.el.
1350 (Vbuffer_list_update_hook): New variable.
1351
1352 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1353 section.
1354
1355 * window.h (resize_frame_windows): Move up in code.
1356 (Fwindow_frame): Remove EXFUN.
1357 (replace_buffer_in_all_windows): Remove prototype.
1358 (replace_buffer_in_windows_safely): Add prototype.
1359
1360 * window.c: Declare Qdelete_window static again. Move down
1361 declaration of select_count.
1362 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1363 (Fother_window): Move to window.el.
1364 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1365 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1366 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1367 window.el.
1368 (replace_buffer_in_windows): Implement by calling
1369 Qreplace_buffer_in_windows.
1370 (replace_buffer_in_all_windows): Remove with some functionality
1371 moved into replace_buffer_in_windows_safely.
1372 (replace_buffer_in_windows_safely): New function.
1373 (select_window_norecord, select_frame_norecord): Move in front
1374 of run_window_configuration_change_hook. Remove now obsolete
1375 declarations.
1376 (Fset_window_buffer): Rewrite doc-string. Call
1377 Qrecord_window_buffer.
1378 (keys_of_window): Move binding for other-window to window.el.
1379
b50691aa
CY
13802011-06-11 Chong Yidong <cyd@stupidchicken.com>
1381
1382 * dispextern.h (struct image): Replace data member, whose int_val
1383 and ptr_val fields were not used by anything, with a single
1384 lisp_val object.
1385
1386 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1387 (gif_clear_image, gif_load, imagemagick_load_image)
1388 (gs_clear_image, gs_load): Callers changed.
1389
3f754b86
PE
13902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1391
cca69397
PE
1392 * buffer.h: Include <time.h>, for time_t.
1393 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1394
109e28d0
PE
1395 Fix minor problems found by static checking.
1396
60737f02
PE
1397 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1398
4b66faf3
PE
1399 Make identifiers static if they are not used in other modules.
1400 * data.c (Qcompiled_function, Qframe, Qvector):
1401 * image.c (QimageMagick, Qsvg):
1402 * minibuf.c (Qmetadata):
1403 * window.c (resize_window_check, resize_root_window): Now static.
1404 * window.h (resize_window_check, resize_root_window): Remove decls.
1405
109e28d0
PE
1406 * window.c (window_deletion_count, delete_deletable_window):
1407 Remove; unused.
46a4ce9e
PE
1408 (window_body_lines): Now static.
1409 (Fdelete_other_windows_internal): Mark vars as initialized.
1410 Make sure 'resize_failed' is initialized.
1411 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1412 (resize_window_apply): Remove unused local.
1413 * window.h (delete_deletable_window): Remove decl.
1414
109e28d0 1415 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1416 (imagemagick_load_image): Fix pointer signedness problem by changing
1417 last arg from unsigned char * to char *. All uses changed.
1418 Also, fix a local for similar reasons.
1419 Remove unused locals. Remove locals to avoid shadowing.
1420 (fn_rsvg_handle_free): Remove; unused.
1421 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1422 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1423
3f754b86
PE
1424 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1425
2547adb1
CY
14262011-06-10 Chong Yidong <cyd@stupidchicken.com>
1427
1428 * image.c (gif_load): Fix omitted cast error introduced by
1429 2011-06-06 change.
1430
2c8e37d4
MR
14312011-06-10 Martin Rudalics <rudalics@gmx.at>
1432
1433 * window.h (resize_proportionally, orig_total_lines)
1434 (orig_top_line): Remove from window structure.
1435 (set_window_height, set_window_width, change_window_heights)
1436 (Fdelete_window): Remove prototypes.
1437 (resize_frame_windows): Remove duplicate declaration.
1438
440a42e3
EZ
14392011-06-10 Eli Zaretskii <eliz@gnu.org>
1440
1441 * window.h (resize_frame_windows, resize_window_check)
1442 (delete_deletable_window, resize_root_window)
1443 (resize_frame_windows): Declare prototypes.
1444
1445 * window.c (resize_window_apply): Make definition be "static" to
1446 match the prototype.
1447
562dd5e9
MR
14482011-06-10 Martin Rudalics <rudalics@gmx.at>
1449
1450 * window.c: Remove declarations of Qwindow_size_fixed,
1451 window_min_size_1, window_min_size_2, window_min_size,
1452 size_window, window_fixed_size_p, enlarge_window, delete_window.
1453 Remove static from declaration of Qdelete_window, it's
1454 temporarily needed by Fbury_buffer.
1455 (replace_window): Don't assign orig_top_line and
1456 orig_total_lines.
1457 (Fdelete_window, delete_window): Remove. Window deletion is
1458 handled by window.el.
1459 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1460 Fdelete_window calls with calls to Qdelete_window.
1461 (Fdelete_other_windows): Remove. Deleting other windows is
1462 handled by window.el.
1463 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1464 handled in window.el.
1465 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1466 Window minimum sizes are handled in window.el.
1467 (shrink_windows, size_window, set_window_height)
1468 (set_window_width, change_window_heights, window_height)
1469 (window_width, CURBEG, CURSIZE, enlarge_window)
1470 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1471 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1472 handled in window.el.
1473 (make_dummy_parent): Rename to make_parent_window and give it a
1474 second argument horflag.
1475 (make_window): Don't set resize_proportionally any more.
1476 (Fsplit_window): Remove. Windows are split in window.el.
1477 (save_restore_action, save_restore_orig_size)
1478 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1479 Resize mini windows in window.el.
1480 (grow_mini_window, shrink_mini_window): Implement by calling
1481 Qresize_root_window_vertically, resize_window_check and
1482 resize_window_apply.
1483 (saved_window, Fset_window_configuration, save_window_save): Do
1484 not handle orig_top_line, orig_total_lines, and
1485 resize_proportionally.
1486 (window_min_height, window_min_width): Move to window.el.
1487 (keys_of_window): Move bindings for delete-other-windows,
1488 split-window, delete-window and enlarge-window to window.el.
1489
1490 * buffer.c: Temporarily extern Qdelete_window.
1491 (Fbury_buffer): Temporarily call Qdelete_window instead of
1492 Fdelete_window (Fbury_buffer will move to window.el soon).
1493
1494 * frame.c (set_menu_bar_lines_1): Remove code handling
1495 orig_top_line and orig_total_lines.
1496
1497 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1498 set_window_height but set heights directly.
1499 (change_frame_size_1): Use resize_frame_windows.
1500
1501 * xdisp.c (init_xdisp): Don't use set_window_height but set
1502 heights directly.
1503
1504 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1505 resize_frame_windows instead of change_window_heights and run
1506 run_window_configuration_change_hook.
1507
1508 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1509 instead of change_window_heights and run
1510 run_window_configuration_change_hook.
1511
1a13852e
MR
15122011-06-09 Martin Rudalics <rudalics@gmx.at>
1513
1514 * window.c (replace_window): Rename second argument REPLACEMENT to
1515 NEW. New third argument SETFLAG. Rewrite.
1516 (delete_window, make_dummy_parent): Call replace_window with
1517 third argument 1.
1518 (window_list_1): Move down in code.
1519 (run_window_configuration_change_hook): Move set_buffer part
1520 before select_frame_norecord part in order to unwind correctly.
1521 Rename count1 to count.
1522 (recombine_windows, delete_deletable_window, resize_root_window)
1523 (Fdelete_other_windows_internal)
1524 (Frun_window_configuration_change_hook, make_parent_window)
1525 (resize_window_check, resize_window_apply, Fresize_window_apply)
1526 (resize_frame_windows, Fsplit_window_internal)
1527 (Fdelete_window_internal, Fresize_mini_window_internal): New
1528 functions.
1529 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1530
f3d1777e
MR
15312011-06-08 Martin Rudalics <rudalics@gmx.at>
1532
496e208e
MR
1533 * window.h (window): Add some new members to window structure -
1534 normal_lines, normal_cols, new_total, new_normal, clone_number,
1535 splits, nest, prev_buffers, next_buffers.
1536 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1537 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1538
f3d1777e
MR
1539 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1540 Remove.
496e208e
MR
1541 (make_dummy_parent): Set new members of windows structure.
1542 (make_window): Move down in code. Handle new members of window
1543 structure.
1544 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1545 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1546 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1547 (Fset_window_prev_buffers, Fwindow_next_buffers)
1548 (Fset_window_next_buffers, Fset_window_clone_number): New
1549 functions.
1550 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1551 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1552 Doc-string fixes.
1553 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1554 Argument WINDOW can be now internal window too.
1555 (Fwindow_use_time): Move up in code.
1556 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1557 Rewrite doc-string.
1558 (Fset_window_configuration, saved_window)
1559 (Fcurrent_window_configuration, save_window_save): Handle new
1560 members of window structure.
b9e809c2
MR
1561 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1562 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1563 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1564 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1565 Qget_mru_window, Qresize_root_window,
1566 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1567 Qauto_buffer_name; staticpro them.
f3d1777e 1568
abde8f8c
MR
15692011-06-07 Martin Rudalics <rudalics@gmx.at>
1570
1571 * window.c (Fwindow_total_size, Fwindow_left_column)
1572 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1573 (Fwindow_list_1): New functions.
1574 (window_box_text_cols): Replace with window_body_cols.
1575 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1576 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1577 (delete_window, Fset_window_configuration): Call
1578 delete_all_subwindows with window as argument.
1579 (delete_all_subwindows): Take a window as argument and not a
1580 structure. Rewrite.
190b47e6
MR
1581 (window_loop): Remove handling of GET_LRU_WINDOW and
1582 GET_LARGEST_WINDOW.
1583 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1584
1585 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1586 window_box_text_cols. delete_all_subwindows now takes a
1587 Lisp_Object as argument.
abde8f8c
MR
1588
1589 * indent.c (compute_motion, Fcompute_motion): Use
1590 window_body_cols instead of window_box_text_cols.
1591
fa8a67e6
MR
1592 * frame.c (delete_frame): Call delete_all_subwindows with root
1593 window as argument.
1594
a54e3482
DC
15952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1596
1597 * fns.c (Fputhash): Document return value.
1598
60002bf5
CY
15992011-06-06 Chong Yidong <cyd@stupidchicken.com>
1600
1601 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1602
0c671da6 16032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1604
b862a52a 1605 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1606
be44ca6c
PE
1607 Check for overflow when converting integer to cons and back.
1608 * charset.c (Fdefine_charset_internal, Fdecode_char):
1609 Use cons_to_unsigned to catch overflow.
1610 (Fencode_char): Use INTEGER_TO_CONS.
1611 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1612 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1613 * data.c (long_to_cons, cons_to_long): Remove.
1614 (cons_to_unsigned, cons_to_signed): New functions.
1615 These signal an error for invalid or out-of-range values.
1616 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1617 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1618 * font.c (Ffont_variation_glyphs):
1619 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1620 * lisp.h: Include <intprops.h>.
1621 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1622 (cons_to_signed, cons_to_unsigned): New decls.
1623 (long_to_cons, cons_to_long): Remove decls.
1624 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1625 (Fprimitive_undo): Use CONS_TO_INTEGER.
1626 * xfns.c (Fx_window_property): Likewise.
1627 * xselect.c: Include <limits.h>.
1628 (x_own_selection, selection_data_to_lisp_data):
1629 Use INTEGER_TO_CONS.
1630 (x_handle_selection_request, x_handle_selection_clear)
1631 (x_get_foreign_selection, Fx_disown_selection_internal)
1632 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1633 (lisp_data_to_selection_data): Use cons_to_unsigned.
1634 (x_fill_property_data): Use cons_to_signed.
1635 Report values out of range.
1636
d1f3d2af
PE
1637 Check for buffer and string overflow more precisely.
1638 * buffer.h (BUF_BYTES_MAX): New macro.
1639 * lisp.h (STRING_BYTES_MAX): New macro.
1640 * alloc.c (Fmake_string):
1641 * character.c (string_escape_byte8):
1642 * coding.c (coding_alloc_by_realloc):
1643 * doprnt.c (doprnt):
1644 * editfns.c (Fformat):
1645 * eval.c (verror):
1646 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1647 since they may not be the same number.
1648 * editfns.c (Finsert_char):
1649 * fileio.c (Finsert_file_contents):
1650 Likewise for BUF_BYTES_MAX.
1651
dd52fcea
PE
1652 * image.c: Use ptrdiff_t, not int, for sizes.
1653 (slurp_file): Switch from int to ptrdiff_t.
1654 All uses changed.
1655 (slurp_file): Check that file size fits in both size_t (for
1656 malloc) and ptrdiff_t (for sanity and safety).
1657
7f9bbdbb
PE
1658 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1659 if b->modtime has its maximal value.
1660
dfe18f82
PE
1661 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1662
84acfcf0
PE
1663 Don't assume time_t can fit into int.
1664 * buffer.h (struct buffer.modtime): Now time_t, not int.
1665 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1666 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1667
ccd9a01a
PE
1668 Minor fixes for signed vs unsigned integers.
1669 * character.h (MAYBE_UNIFY_CHAR):
1670 * charset.c (maybe_unify_char):
1671 * keyboard.c (read_char, reorder_modifiers):
1672 XINT -> XFASTINT, since the integer must be nonnegative.
1673 * ftfont.c (ftfont_spec_pattern):
1674 * keymap.c (access_keymap, silly_event_symbol_error):
1675 XUINT -> XFASTINT, since the integer must be nonnegative.
1676 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1677 since it makes no difference and we prefer signed.
1678 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1679 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1680 nonnegative.
1681
d6d100dd
SM
16822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1683
1684 * window.h (Fwindow_frame): Declare.
1685
2b6148e4
PE
16862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1689 (SPARE_MEMORY): Always define.
1690 (LARGE_REQUEST): Remove.
1691 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1692
f230ecc9
MR
16932011-06-06 Martin Rudalics <rudalics@gmx.at>
1694
727e958e
MR
1695 * lisp.h: Move EXFUNS for Fframe_root_window,
1696 Fframe_first_window and Fset_frame_selected_window to window.h.
1697
1698 * window.h: Move EXFUNS for Fframe_root_window,
1699 Fframe_first_window and Fset_frame_selected_window here from
1700 lisp.h.
1701
1702 * frame.c (Fwindow_frame, Fframe_first_window)
1703 (Fframe_root_window, Fframe_selected_window)
1704 (Fset_frame_selected_window): Move to window.c.
1705 (Factive_minibuffer_window): Move to minibuf.c.
1706 (Fother_visible_frames_p): New function.
1707
1708 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1709
f230ecc9
MR
1710 * window.c (decode_window, decode_any_window): Move up in code.
1711 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1712 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1713 (Fwindow_buffer): Move up and rewrite doc-string.
1714 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1715 (Fwindow_prev): New functions.
727e958e
MR
1716 (Fwindow_frame): Move here from frame.c. Accept any window as
1717 argument.
1718 (Fframe_root_window, Fframe_first_window)
1719 (Fframe_selected_window): Move here from frame.c. Accept frame
1720 or arbitrary window as argument. Update doc-strings.
1721 (Fminibuffer_window): Move up in code.
1722 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1723 (Fset_frame_selected_window): Move here from frame.c.
1724 Marginal rewrite.
727e958e
MR
1725 (Fselected_window, select_window, Fselect_window): Move up in
1726 code. Minor doc-string fixes.
f230ecc9 1727
4d09bcf6
PE
17282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1731 Do not assume that spare memory exists; that assumption is valid
1732 only if SYSTEM_MALLOC.
1733 (LARGE_REQUEST): New macro, so that the issue of large requests
1734 is separated from the issue of spare memory.
1735
810928a2
AS
17362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1737
172418ad
AS
1738 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1739 format. (Bug#8806)
1740
43f862f7
AS
1741 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1742
810928a2
AS
1743 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1744 before statements.
1745
a059fe24
JD
17462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1747
1748 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1749
1750 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1751
1752 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1753 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1754
989bf368
JB
17552011-06-05 Juanma Barranquero <lekktu@gmail.com>
1756
1757 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1758
4b80f674
CY
17592011-06-04 Chong Yidong <cyd@stupidchicken.com>
1760
1761 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1762 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1763 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1764 New error handlers.
4b80f674
CY
1765 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1766 Obey Vx_select_enable_clipboard_manager. Catch errors in
1767 x_clipboard_manager_save (Bug#8779).
1768 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1769 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1770
99a33b77 17712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1772
1773 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1774
99a33b77 17752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1776
1777 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1778 in the current matrix if keep_current_p is non-zero.
1779
8264569d
EZ
17802011-06-04 Eli Zaretskii <eliz@gnu.org>
1781
1782 * bidi.c (bidi_level_of_next_char): Fix last change.
1783
57f97249
EZ
17842011-06-03 Eli Zaretskii <eliz@gnu.org>
1785
fec2107c 1786 Support bidi reordering of text covered by display properties.
57f97249 1787
fec2107c
EZ
1788 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1789 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1790 (bidi_cache_search, bidi_cache_iterator_state)
1791 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1792 (bidi_level_of_next_char, bidi_move_to_visually_next):
1793 Support character positions inside a run of characters covered by a
fec2107c
EZ
1794 display string.
1795 (bidi_paragraph_init, bidi_resolve_explicit_1)
1796 (bidi_level_of_next_char): Call bidi_fetch_char and
1797 bidi_fetch_char_advance instead of FETCH_CHAR and
1798 FETCH_CHAR_ADVANCE.
1799 (bidi_init_it): Initialize new members.
1800 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1801 definitions.
1802 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1803 instead of using explicit *_CHAR codes.
d6d100dd
SM
1804 (bidi_resolve_explicit, bidi_resolve_weak):
1805 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1806 bidirectional text is supported only in multibyte buffers.
1807 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1808 it to initialize the frame_window_p member of struct bidi_it.
1809 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1810 (bidi_resolve_explicit, bidi_resolve_weak)
1811 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1812 bidi_it->nchars is non-positive.
1813 (bidi_level_of_next_char): Don't try to lookup the cache for the
1814 next/previous character if nothing is cached there yet, or if we
1815 were just reseat()'ed to a new position.
c40e2fb2 1816
0e14fe90
EZ
1817 * xdisp.c (set_cursor_from_row): Set start and stop points
1818 according to the row's direction when priming the loop that looks
1819 for the glyph on which to display cursor.
1820 (single_display_spec_intangible_p): Function deleted.
1821 (display_prop_intangible_p): Reimplement to call
1822 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1823 Accept 3 additional arguments needed by handle_display_spec.
1824 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1825 values: lists, `(when COND...)' forms, etc.
1826 (single_display_spec_string_p): Support property values that are
1827 lists with the argument STRING its top-level element.
1828 (display_prop_string_p): Fix the condition for processing a
1829 property that is a list to be consistent with handle_display_spec.
fec2107c 1830 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1831 last portion of handle_display_prop.
1832 (compute_display_string_pos): Accept additional argument
1833 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1834 value of a `display' property is a "replacing spec".
1835 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1836 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1837 the display property, but just return a value indicating whether
1838 the display property will replace the characters it covers.
1839 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1840 frame_window_p members of struct bidi_it.
d6d100dd
SM
1841 (compute_display_string_pos, compute_display_string_end):
1842 New functions.
fec2107c
EZ
1843 (push_it): Accept second argument POSITION, where pop_it should
1844 jump to continue iteration.
1845 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1846
fec2107c
EZ
1847 * keyboard.c (adjust_point_for_property): Adjust the call to
1848 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1849
1850 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1851 (bidi_init_it): Update prototypes.
1852 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1853 (compute_display_string_pos, compute_display_string_end):
1854 Declare prototypes.
fec2107c
EZ
1855 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1856 EMACS_INT.
fc6f18ce 1857
40087514 18582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1859
57f53182
PE
1860 Malloc failure behavior now depends on size of allocation.
1861 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1862 * lisp.h: Change signatures accordingly.
1863 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1864 All callers changed. (Bug#8762)
1865
1866 * gnutls.c: Use Emacs's memory allocators.
1867 Without this change, the gnutls library would invoke malloc etc.
1868 directly, which causes problems on non-SYNC_INPUT hosts, and which
1869 runs afoul of improving memory_full behavior. (Bug#8761)
1870 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1871 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1872 xfree instead of the default malloc, realloc, free.
1873 (Fgnutls_boot): No need to check for memory allocation failure,
1874 since xmalloc does that for us.
1875
ac32cd99 1876 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1877 * category.c (hash_get_category_set):
1878 * ccl.c (ccl_driver):
1879 * charset.c (Fdefine_charset_internal):
1880 * charset.h (struct charset.hash_index):
1881 * composite.c (get_composition_id, gstring_lookup_cache)
1882 (composition_gstring_put_cache):
1883 * composite.h (struct composition.hash_index):
1884 * dispextern.h (struct image.hash):
1885 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1886 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1887 (hashfn_equal, hashfn_user_defined, make_hash_table)
1888 (maybe_resize_hash_table, hash_lookup, hash_put)
1889 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1890 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1891 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1892 * image.c (make_image, search_image_cache, lookup_image)
1893 (xpm_put_color_table_h):
1894 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1895 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1896 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1897 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1898 * alloc.c (allocate_vectorlike):
1899 Check for overflow in vector size calculations.
1900 * ccl.c (ccl_driver):
1901 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1902 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1903 need to be updated by these changes.
40087514
PE
1904 * fns.c (make_hash_table, maybe_resize_hash_table):
1905 Check for integer overflow with large hash tables.
0de4bb68
PE
1906 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1907 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1908 (SXHASH_REDUCE): New macro.
1909 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1910 Use it instead of discarding useful hash info with large hash values.
1911 (sxhash_float): New function.
1912 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1913 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1914 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1915 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1916 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1917 Adjust signatures to match updated version of code.
1918 (consing_since_gc): Now EMACS_INT, since a single hash table can
1919 use more than INT_MAX bytes.
1920
698d32e2
DN
19212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1922
1923 Make it possible to build with GCC-4.6+ -O2 -flto.
1924
1925 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1926
fd6fa53f
SM
19272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1928
1929 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1930 Call minibuffer-inactive-mode.
1931
864db017
JB
19322011-05-31 Juanma Barranquero <lekktu@gmail.com>
1933
1934 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1935 Update dependencies.
1936
2ad0baf4
DN
19372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1938
1939 * data.c (init_data): Remove code for UTS, this system is not
1940 supported anymore.
1941
4fcc2638
DN
19422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1943
1944 Don't force ./temacs to start in terminal mode.
1945
1946 * frame.c (make_initial_frame): Initialize faces in all cases, not
1947 only when CANNOT_DUMP is defined.
1948 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1949
c56e0fd5
DN
19502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1951
1952 * dispnew.c (add_window_display_history): Use const for the string
1953 pointer. Remove declaration, not needed.
1954
333d54da 19552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1956
55d4c1b2 1957 Use 'inline', not 'INLINE'.
333d54da 1958 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1959 * alloc.c, fontset.c (INLINE): Remove.
1960 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1961 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1962 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1963 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1964 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1965
738db178
DN
19662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1967
1968 Make it possible to run ./temacs.
1969
1970 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1971 syms_of_callproc does the same thing. Remove test for
1972 "initialized", do it in the caller.
1973 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1974
620c53a6
SM
19752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1976
1977 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1978 (read_minibuf): Use get_minibuffer.
1979 (syms_of_minibuf): Use DEFSYM.
1980 (Qmetadata): New var.
1981 * data.c (Qbuffer): Don't make it static.
1982 (syms_of_data): Use DEFSYM.
1983
e003a292
PE
19842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1987 (CCL_CODE_MIN): New macro.
1988
ed008a6d
PE
19892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1990
3687c2ef
PE
1991 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1992
ed008a6d
PE
1993 * eval.c (Qdebug): Now static.
1994 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1995 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1996 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1997
d66c4c7c
CY
19982011-05-29 Chong Yidong <cyd@stupidchicken.com>
1999
2000 * image.c: Various fixes to ImageMagick code comments.
2001 (Fimagemagick_types): Doc fix.
2002
5fbc2025
PE
20032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2004
0196f88a
PE
2005 Minor fixes prompted by GCC 4.6.0 warnings.
2006
2007 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2008
5fbc2025
PE
2009 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2010 (x_clipboard_manager_save_all): Move extern decl to ...
2011 * xterm.h: ... here, so that it can be checked for consistency.
2012
1dd3c2d9
CY
20132011-05-29 Chong Yidong <cyd@stupidchicken.com>
2014
2015 * xselect.c (x_clipboard_manager_save_frame)
2016 (x_clipboard_manager_save_all): New functions.
2017 (Fx_clipboard_manager_save): Lisp function deleted.
2018
2019 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2020 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2021
2022 * xterm.h: Update prototype.
2023
5ba6571d
WX
20242011-05-28 William Xu <william.xwl@gmail.com>
2025
2026 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2027 exiting (Bug#8239).
2028
3eaff834
JM
20292011-05-28 Jim Meyering <meyering@redhat.com>
2030
e1900994 2031 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2032 * fns.c (to_uchar): Define.
2033 (crypto_hash_function): Use it to convert some newly-signed
2034 variables to unsigned, to avoid sign-extension bugs. For example,
2035 without this change, (md5 "truc") would evaluate to
2036 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2037 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2038 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2039
0f6990a7
PE
20402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2041
2042 Integer overflow fixes.
c8a9ca5a 2043
08686060
PE
2044 * dbusbind.c: Serial number integer overflow fixes.
2045 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2046 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2047 to hold a serial number that is too large for a fixnum.
2048 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2049 Check for serial numbers out of range. Decode any serial number
59568bf0 2050 that was so large that it became a float. (Bug#8722)
08686060 2051
2d1fc3c7
PE
2052 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2053 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2054 Use XFASTINT rather than XUINT when numbers are nonnegative.
2055 (xd_append_arg, Fdbus_method_return_internal):
2056 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2057 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2058 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2059 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2060 (Bug#8722)
2d1fc3c7 2061
c8a9ca5a
PE
2062 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2063
519e1d69
PE
2064 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2065
30569699
PE
2066 ccl: add integer overflow checks
2067 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2068 (IN_INT_RANGE): New macros.
2069 (ccl_driver): Use them to check for integer overflow when
2070 decoding a CCL program. Many of the new checks are whether XINT (x)
2071 fits in int; it doesn't always, on 64-bit hosts. The new version
2072 doesn't catch all possible integer overflows, but it's an
847044ea 2073 improvement. (Bug#8719)
30569699 2074
c11285dc
PE
2075 * alloc.c (make_event_array): Use XINT, not XUINT.
2076 There's no need for unsigned here.
2077
fdccd48e
PE
2078 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2079 This follows up to the 2011-05-06 change that substituted uintptr_t
2080 for EMACS_INT. This case wasn't caught back then.
2081
37910ab2
PE
2082 Rework Fformat to avoid integer overflow issues.
2083 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2084 now (part of C89). Include <verify.h>.
2085 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2086 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2087 (Fformat): Avoid the prepass trying to compute sizes; it was only
2088 approximate and thus did not catch overflow reliably. Instead, walk
2089 through the format just once, formatting and computing sizes as we go,
2090 checking for integer overflow at every step, and allocating a larger
2091 buffer as needed. Keep track separately whether the format is
2092 multibyte. Keep only the most-recently calculated precision, rather
2093 than them all. Record whether each argument has been converted to
2094 string. Use EMACS_INT, not int, for byte and char and arg counts.
2095 Support field widths and precisions larger than INT_MAX. Avoid
2096 sprintf's undefined behavior with conversion specifications such as %#d
2097 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2098 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2099 formatting out-of-range floating point numbers with int
9173deec 2100 formats. (Bug#8668)
37910ab2 2101
2e6578fb
PE
2102 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2103
0ae6bdee
PE
2104 * data.c: Avoid integer truncation in expressions involving floats.
2105 * data.c: Include <intprops.h>.
2106 (arith_driver): When there's an integer overflow in an expression
2107 involving floating point, convert the integers to floating point
2108 so that the resulting value does not suffer from catastrophic
2109 integer truncation. For example, on a 64-bit host (* 4
2110 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2111 Do not rely on undefined behavior after integer overflow.
2112
de883a70
PE
2113 merge count_size_as_multibyte, parse_str_to_multibyte
2114 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2115 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2116 Check for integer overflow.
2117 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2118 since it's now a duplicate of the other. This is more of
2119 a character than a buffer op, so better that it's in character.c.
2120 * fns.c, print.c: Adjust to above changes.
2121
2ff916cb
PE
21222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2123
2124 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2125
f1b54466
PE
21262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2127
fb1ac845
PE
2128 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2129 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2130 (x_clipboard_manager_save): Now static.
2131 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2132
f1b54466
PE
2133 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2134 (crypto_hash_function): Now static.
2135 Fix pointer signedness problems. Avoid unnecessary initializations.
2136
a9f737ee
CY
21372011-05-27 Chong Yidong <cyd@stupidchicken.com>
2138
2139 * termhooks.h (Vselection_alist): Make it terminal-local.
2140
2141 * terminal.c (create_terminal): Initialize it.
2142
2143 * xselect.c: Support for clipboard managers.
2144 (Vselection_alist): Move to termhooks.h as terminal-local var.
2145 (LOCAL_SELECTION): New macro.
2146 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2147 (symbol_to_x_atom): Remove gratuitous arg.
2148 (x_handle_selection_request, lisp_data_to_selection_data)
2149 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2150 (x_own_selection, x_get_local_selection, x_convert_selection):
2151 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2152 (some_frame_on_display): Delete unused function.
2153 (Fx_own_selection_internal, Fx_get_selection_internal)
2154 (Fx_disown_selection_internal, Fx_selection_owner_p)
2155 (Fx_selection_exists_p): New optional frame arg.
2156 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2157 (x_handle_selection_clear): Don't treat other terminals with the
2158 same keyboard specially. Use the terminal-local Vselection_alist.
2159 (x_clear_frame_selections): Use Frun_hook_with_args.
2160
2161 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2162
2163 * xterm.h: Add support for those atoms.
2164
e067f0c1
CY
21652011-05-26 Chong Yidong <cyd@stupidchicken.com>
2166
2167 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2168 (converted_selections, conversion_fail_tag): New global variables.
2169 (x_selection_request_lisp_error): Free the above.
2170 (x_get_local_selection): Remove unnecessary code.
2171 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2172 of converted selections stored in converted_selections.
2173 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2174 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2175 (x_convert_selection): New function.
2176 (x_handle_selection_event): Simplify.
2177 (x_get_foreign_selection): Don't ignore incoming requests while
2178 waiting for an answer; this will fail when we implement
2179 SAVE_TARGETS, and seems unnecessary anyway.
2180 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2181 (Vx_sent_selection_functions): Doc fix.
2182
0f4aebc0
LL
21832011-05-26 Leo Liu <sdl.web@gmail.com>
2184
2185 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2186
e61124cd
YM
21872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2188
2189 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2190
2191 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2192 for fringe update if it has periodic bitmap.
2193 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2194 and fringe_bitmap_periodic_p.
2195
2196 * fringe.c (get_fringe_bitmap_data): New function.
2197 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2198 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2199 row. Mark glyph row for fringe update if periodicity changed.
2200
2201 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2202 for fringe update unless it has periodic bitmap.
2203
f16d9837
KH
22042011-05-25 Kenichi Handa <handa@m17n.org>
2205
2206 * xdisp.c (get_next_display_element): Set correct it->face_id for
2207 a static composition.
2208
e1b90ef6
LL
22092011-05-24 Leo Liu <sdl.web@gmail.com>
2210
2211 * deps.mk (fns.o):
2212 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2213
2214 * fns.c (crypto_hash_function, Fsha1): New function.
2215 (Fmd5): Use crypto_hash_function.
2216 (syms_of_fns): Add Ssha1.
2217
7400048f
PE
22182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 * gnutls.c: Remove unused macros.
2221 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2222 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2223 Remove macros that are defined and never used.
2224 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2225
abb71cf4
CY
22262011-05-22 Chong Yidong <cyd@stupidchicken.com>
2227
2228 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2229 (Fx_get_selection_internal): Minor cleanup.
2230 (Fx_own_selection_internal): Rename arguments for consistency with
2231 select.el.
2232
6307db39
PE
22332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2236
f3d4e0a4
CY
22372011-05-22 Chong Yidong <cyd@stupidchicken.com>
2238
2239 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2240
4d8ade89
YM
22412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2242
2243 * dispnew.c (scrolling_window): Don't exclude the case that the
2244 last enabled row in the desired matrix touches the bottom boundary.
2245
32078c8d
GM
22462011-05-21 Glenn Morris <rgm@gnu.org>
2247
2248 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2249 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2250 and add some more files.
32078c8d 2251
7285dc67
EZ
22522011-05-20 Eli Zaretskii <eliz@gnu.org>
2253
2254 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2255 report_file_error introduced by the change from 2011-05-07.
2256
89d1bd22
PE
22572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2258
2259 * systime.h (Time): Define only if emacs is defined.
2260 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2261 where the include path doesn't have X11/X.h by default. See
2262 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2263
e23640bb 22642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2265
2266 * composite.c (find_automatic_composition): Fix previous change.
2267
b9704ad9
GM
22682011-05-20 Glenn Morris <rgm@gnu.org>
2269
2270 * lisp.mk: New file, split from Makefile.in.
2271 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2272 (shortlisp): Remove.
2273 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2274
4a720484
GM
22752011-05-19 Glenn Morris <rgm@gnu.org>
2276
2277 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2278 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2279 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2280 (lisp): Set the order to that of loadup.el.
2281 (shortlisp): Make it a copy of $lisp.
2282 (SOME_MACHINE_LISP): Remove.
2283 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2284 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2285
a28d4396
KH
22862011-05-18 Kenichi Handa <handa@m17n.org>
2287
2288 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2289 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2290 (find_automatic_composition): Mostly rewrite for efficiency.
2291
a2b1fa8e
JB
22922011-05-18 Juanma Barranquero <lekktu@gmail.com>
2293
2294 * makefile.w32-in: Update dependencies.
2295
8e1f5610
CS
22962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2297
2298 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2299 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2300
7025ee00 23012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2302
cdfa6eab
PE
2303 Fix some integer overflow issues, such as string length overflow.
2304
06d6db33
PE
2305 * insdel.c (count_size_as_multibyte): Check for string overflow.
2306
2b4560a8
PE
2307 * character.c (lisp_string_width): Check for string overflow.
2308 Use EMACS_INT, not int, for string indexes and lengths; in
2309 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2310 the resulting string length overflows an EMACS_INT; instead,
2311 report a string overflow if no precision given. When checking for
2312 precision exhaustion, use a check that cannot possibly have
2313 integer overflow. (Bug#8675)
2314 * character.h (lisp_string_width): Adjust to new signature.
2315
cb93f9be
PE
2316 * alloc.c (string_overflow): New function.
2317 (Fmake_string): Use it. This doesn't change behavior, but saves
2318 a few bytes and will simplify future changes.
2319 * character.c (string_escape_byte8): Likewise.
2320 * lisp.h (string_overflow): New decl.
2321
1a1f3366
PE
2322 Fixups, following up to the user-interface timestamp change.
2323 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2324 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2325 * msdos.c (mouse_get_pos): Likewise.
2326 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2327 * w32gui.h (Time): Define by including "systime.h" rather than by
2328 declaring it ourselves. (Bug#8664)
2329
d4e3e4d3
PE
2330 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2331 * image.c (clear_image_cache): Likewise.
2332
f6a24d19
PE
2333 * term.c (term_mouse_position): Don't assume time_t wraparound.
2334
08dc5ae6
PE
2335 Be more systematic about user-interface timestamps.
2336 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2337 and sometimes 'EMACS_UINT', to represent these timestamps.
2338 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2339 This makes the code easier to follow, and makes it easier to catch
2340 integer overflow bugs such as Bug#8664.
2341 * frame.c (Fmouse_position, Fmouse_pixel_position):
2342 Use Time, not unsigned long, for user-interface timestamps.
2343 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2344 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2345 * keyboard.h (last_event_timestamp): Likewise.
2346 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2347 * menu.h (xmenu_show): Likewise.
2348 * term.c (term_mouse_position): Likewise.
2349 * termhooks.h (struct input_event.timestamp): Likewise.
2350 (struct terminal.mouse_position_hook): Likewise.
2351 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2352 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2353 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2354 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2355 what it was before.
2356 * menu.h, termhooks.h: Include "systime.h", for Time.
2357
8e55734a
PE
2358 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2359 Don't assume that the difference between two unsigned long values
2360 can fit into an integer. At this point, we know button_down_time
2361 <= event->timestamp, so the difference must be nonnegative, so
2362 there's no need to cast the result if double-click-time is
2363 nonnegative, as it should be; check that it's nonnegative, just in
2364 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2365 apart (about 25 days). (Bug#8664)
8e55734a 2366
841f1b75 2367 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2368 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2369
3e26f69c
PE
2370 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2371 that always fit in int. Use a sentinel instead of a counter, to
2372 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2373 * frame.h (struct frame): Use int for menu_bar_items_used
2374 instead of EMACS_INT, since it always fits in int.
3e26f69c 2375
5cc152c0
PE
2376 * menu.c (grow_menu_items): Check for int overflow.
2377
d89eb65e
PE
2378 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2379
5235bd3e
PE
2380 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2381 Before, the code was not consistent. These values cannot exceed
2382 2**31 - 1 so there's no need to make them unsigned.
2383 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2384 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2385 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2386 as modifiers.
2387 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2388
bc827e23
PE
2389 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2390 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2391 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2392 presumably because the widths might not match.
2393
78eb494e
PE
2394 * window.c (size_window): Avoid needless test at loop start.
2395
04f2d78b
CB
23962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2397
2398 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2399
d2fc7e3d 24002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2401
2402 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2403
d2fc7e3d 24042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2405
2406 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2407 `width' to `bar_area_x' and `bar_area_width', respectively.
2408 (x_scroll_run): Take account of fringe background extension.
2409
04f2d78b
CB
2410 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2411 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2412 `bar_area_width', respectively.
2413 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2414 background extension.
2415
79b70037
GM
24162011-05-10 Jim Meyering <meyering@redhat.com>
2417
2418 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2419
2f142cc5
JB
24202011-05-10 Juanma Barranquero <lekktu@gmail.com>
2421
2422 * image.c (Finit_image_library): Return t for built-in image types,
2423 like pbm and xbm. (Bug#8640)
2424
57679c86
AS
24252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2426
2427 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2428
888c9e86
EZ
24292011-05-07 Eli Zaretskii <eliz@gnu.org>
2430
b0512a1d
EZ
2431 * w32console.c (Fset_screen_color): Doc fix.
2432 (Fget_screen_color): New function.
2433 (syms_of_ntterm): Defsubr it.
2434
7285dc67
EZ
2435 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2436 unlink the temporary file if Fcall_process didn't create it in the
2437 first place.
2438 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2439 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2440 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2441 cue to call_process_cleanup not to close that handle.
2442
4d3fcc8e
BK
24432011-05-07 Ben Key <bkey76@gmail.com>
2444
2445 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2446 one of two shell specific rules, either bootstrap-temacs-CMD or
2447 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2448 to the previous implementation of the bootstrap-temacs rule.
2449 The bootstrap-temacs-CMD rule is similar to the previous
2450 implementation of the bootstrap-temacs rule except that it
2451 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2452 variable.
2453
2454 These changes, along with some changes to nt/configure.bat,
2455 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2456 earlier fix to add support for --cflags and --ldflags options
2457 that include quotes so that it works whether make uses cmd or
2458 sh as the shell.
2459
b4289b64
MA
24602011-05-06 Michael Albinus <michael.albinus@gmx.de>
2461
2462 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2463 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2464 is a constant.
2465 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2466 a string. Handle both cases.
2467 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2468 (Fdbus_register_method): Use Qinvalid_function.
2469
af4c0e28
JB
24702011-05-06 Juanma Barranquero <lekktu@gmail.com>
2471
2472 * makefile.w32-in: Update dependencies.
2473 (LISP_H): Add inttypes.h and stdin.h.
2474 (PROCESS_H): Add unistd.h.
2475
c51453d9
EZ
24762011-05-06 Eli Zaretskii <eliz@gnu.org>
2477
2478 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2479 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2480
8ff0ac3c 24812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2482
4c4b566b
PE
2483 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2484
aab2b9b5
PE
2485 * term.c (vfatal): Remove stray call to va_end.
2486 It's not needed and the C Standard doesn't allow it here anyway.
2487
c378da0b
PE
2488 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2489 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2490
288b08c7
PE
2491 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2492 bytes.
2493
e3601888
PE
2494 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2495
db6c0e74
PE
2496 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2497
dd5963ea
PE
2498 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2499
88c9450f
PE
2500 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2501
2f9442b8
PE
2502 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2503
c032b5f8
PE
2504 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2505 * charset.c (Fdefine_charset_internal): Don't initialize
2506 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2507 32-bit int (Bug#8600).
a108c10b
PE
2508
2509 * lread.c (read_integer): Be more consistent with string-to-number.
2510 Use string_to_number to do the actual conversion; this avoids
2511 rounding errors and fixes some other screwups. Without this fix,
2512 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2513 (digit_to_number): Move earlier, for benefit of read_integer.
2514 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2515 not a digit in any supported base. (Bug#8602)
a108c10b 2516
ad5f9eea
PE
2517 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2518
aec1708a
PE
2519 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2520 to match comment at start of function. This also removes a
2521 GCC warning about overflow in a 32+64-bit port.
2522
47be4ab5
PE
2523 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2524
371cac43
PE
2525 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2526 Reported by Stefan Monnier in
2527 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2528 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2529 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2530
d01a7826
PE
2531 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2532 (EMACS_UINTPTR): Likewise, with uintptr_t.
2533
7fd47d5c
PE
2534 * lisp.h: Prefer 64-bit EMACS_INT if available.
2535 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2536 on 32-bit hosts that have 64-bit int, so that they can access
2537 large files.
122b0c86
PE
2538 However, temporarily disable this change unless the temporary
2539 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2540
8727937b
PE
2541 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2542
8ac068ac
PE
2543 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2544 This removes an assumption that EMACS_INT and long are the same
2545 width as pointers. The assumption is true for Emacs porting targets
2546 now, but we want to make other targets possible.
2547 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2548 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2549 In the rest of the code, change types of integers that hold casted
2550 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2551 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2552 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2553 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2554 No need to cast type when ORing.
2555 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2556 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2557 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2558 assume EMACS_INT is the same width as char *.
2559 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2560 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2561 Remove no-longer-needed casts.
2562 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2563 (xg_tool_bar_help_callback, xg_make_tool_item):
2564 Use EMACS_INTPTR to hold an integer
2565 that will be cast to void *; this can avoid a GCC warning
2566 if EMACS_INT is not the same width as void *.
2567 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2568 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2569 (current_message_1, set_message_1):
2570 Use a local to convert to proper width without a cast.
2571 * xmenu.c (dialog_selection_callback): Likewise.
2572
ede49d71
PE
2573 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2574 Also, don't assume VALBITS / RAND_BITS is less than 5,
2575 and don't rely on undefined behavior when shifting a 1 left into
2576 the sign bit.
2577 * lisp.h (get_random): Change signature to match.
2578
2f30ecd0
PE
2579 * lread.c (hash_string): Use size_t, not int, for hash computation.
2580 Normally we prefer signed values; but hashing is special, because
2581 it's better to use unsigned division on hash table sizes so that
2582 the remainder is nonnegative. Also, size_t is the natural width
2583 for hashing into memory. The previous code used 'int', which doesn't
2584 retain enough info to hash well into very large tables.
2585 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2586
2a866e7b
PE
2587 * dbusbind.c: Don't possibly lose pointer info when converting.
2588 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2589 Use XPNTR rather than XHASH, so that the high-order bits of
2590 the pointer aren't lost when converting through void *.
2591
51639eac
PE
2592 * eval.c (Fautoload): Don't double-shift a pointer.
2593
92394119
PE
2594 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2595
dbdb9a7c
JB
25962011-05-06 Juanma Barranquero <lekktu@gmail.com>
2597
2598 * gnutls.c (DEF_GNUTLS_FN):
2599 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2600
db7a0b4f
AS
26012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2602
2603 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2604 marker. (Bug#8610)
2605
f7ff1b0f 26062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2607
2608 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2609 New version that can reserve upto 2GB of heap space.
2610
f7ff1b0f 26112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2612
2613 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2614
639c109b
TZ
26152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2616
2617 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2618 `gnutls_certificate_set_x509_key_file'.
2619
d2127135
JB
26202011-05-05 Juanma Barranquero <lekktu@gmail.com>
2621
2622 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2623 Update dependencies.
2624
e968f4f3
JB
26252011-05-04 Juanma Barranquero <lekktu@gmail.com>
2626
2627 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2628 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2629 Remove unused parameter `fildes'.
2630 * process.c (read_process_output, send_process): Don't pass it.
2631
84d358f0
JB
26322011-05-04 Juanma Barranquero <lekktu@gmail.com>
2633
2634 Fix previous change: the library cache is defined in w32.c.
2635 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2636 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2637
0898ca10
JB
26382011-05-04 Juanma Barranquero <lekktu@gmail.com>
2639
2640 Implement dynamic loading of GnuTLS on Windows.
2641
2642 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2643 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2644 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2645 Declare.
2646
2647 * gnutls.c (Qgnutls_dll): Define.
2648 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2649 (gnutls_*): Declare function pointers.
2650 (init_gnutls_functions): New function to initialize function pointers.
2651 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2652 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2653 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2654 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2655 (emacs_gnutls_write, emacs_gnutls_read)
2656 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2657 (Fgnutls_available_p): New function.
2658 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2659 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2660 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2661
2662 * image.c: Include w32.h.
2663 (Vimage_type_cache): Delete.
2664 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2665 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2666 (w32_delayed_load): Move to w32.c.
2667
2668 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2669
2670 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2671 (w32_delayed_load): Move from image.c. When loading a library, record
2672 its filename in the :loaded-from property of the library id.
2673 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2674 Initialize and staticpro them.
2675 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2676
2677 * process.c: Include lisp.h before w32.h, not after.
2678 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2679 instead of gnutls_record_check_pending.
2680
2681 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2682
ff4de4aa
TZ
26832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2684
2685 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2686 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2687 as passed in.
2688
abe95abb
JD
26892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2690
2691 * xterm.c (x_set_frame_alpha): Do not set property on anything
2692 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2693
e16e55d4
JB
26942011-05-02 Juanma Barranquero <lekktu@gmail.com>
2695
2696 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2697
bafcf6a5
JB
26982011-05-02 Juanma Barranquero <lekktu@gmail.com>
2699
2700 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2701 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2702 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2703 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2704 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2705 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2706 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2707 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2708 (Qgnutls_bootprop_callbacks_verify): Make static.
2709
e7a6747f
AS
27102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2711
19ed11ba
AS
2712 * callproc.c: Indentation fixup.
2713
e7a6747f 2714 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2715 (wait_for_termination, interruptible_wait_for_termination):
2716 Move after wait_for_termination_1.
e7a6747f 2717
1ef14cb4
LMI
27182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2719
2720 * sysdep.c (interruptible_wait_for_termination): New function
2721 which is like wait_for_termination, but allows keyboard
2722 interruptions.
2723
2724 * callproc.c (Fcall_process): Add (:file "file") as an option for
2725 the STDOUT buffer.
2726 (Fcall_process_region): Ditto.
2727
330d880c
EZ
27282011-04-30 Eli Zaretskii <eliz@gnu.org>
2729
8db90b73
EZ
2730 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2731 rather than `XVECTOR (FOO)->size'.
2732
330d880c
EZ
2733 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2734 inttypes.h, as a gnulib replacement is used if it not available in
2735 system headers.
2736
15cbd324
EZ
27372011-04-21 Eli Zaretskii <eliz@gnu.org>
2738
2739 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2740 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2741 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2742
2743 * coding.c (coding_alloc_by_realloc): Error out if destination
2744 will grow beyond MOST_POSITIVE_FIXNUM.
2745 (decode_coding_emacs_mule): Abort if there isn't enough place in
2746 charbuf for the composition carryover bytes. Reserve an extra
2747 space for up to 2 characters produced in a loop.
2748 (decode_coding_iso_2022): Abort if there isn't enough place in
2749 charbuf for the composition carryover bytes.
2750
27512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2752
ae940cca
EZ
2753 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2754 aborting when %lld or %lll format is passed.
2755 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2756 %llo or %llx format is passed. (Bug#8545)
2757
03ab8921
EZ
2758 * window.c (window_scroll_line_based): Use a marker instead of
2759 simple variables to record original value of point. (Bug#7952)
2760
afda1437
EZ
2761 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2762 produced by %s or %c overflows available buffer space. (Bug#8545)
2763
f76dee0c
PE
27642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2765
2766 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2767 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2768
fdc5744d
JB
27692011-04-28 Juanma Barranquero <lekktu@gmail.com>
2770
2771 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2772
638f053a
JB
27732011-04-28 Juanma Barranquero <lekktu@gmail.com>
2774
2775 * keyboard.c (Qdelayed_warnings_hook): Define.
2776 (command_loop_1): Run `delayed-warnings-hook'
2777 if Vdelayed_warnings_list is non-nil.
2778 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2779 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2780
d178f871
EZ
27812011-04-28 Eli Zaretskii <eliz@gnu.org>
2782
2783 * doprnt.c (doprnt): Don't return value smaller than the buffer
2784 size if the message was truncated. (Bug#8545).
2785
b124fd93
JB
27862011-04-28 Juanma Barranquero <lekktu@gmail.com>
2787
2788 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2789 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2790
e810457d
PE
27912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2794
ea51cceb
JB
27952011-04-27 Juanma Barranquero <lekktu@gmail.com>
2796
2797 * makefile.w32-in: Update dependencies.
2798
94dcfacf
EZ
27992011-04-27 Eli Zaretskii <eliz@gnu.org>
2800
2801 Improve `doprnt' and its usage. (Bug#8545)
2802 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2803 `format_end'. Remove support for %l as a conversion specifier.
2804 Don't use xrealloc. Improve diagnostics when the %l size modifier
2805 is used. Update the commentary.
2806
2807 * eval.c (verror): Simplify calculation of size_t.
2808
2809 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2810 messages.
2811
f61f41d7
PE
28122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2813
2814 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2815 change.
2816
96fb4434
PE
28172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2820 This makes this file independent of the recent pseudovector change.
2821
671875da 28222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2823
69e9b5a3
PE
2824 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2825
b5f869a7 2826 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2827 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2828 Remove unused local.
c8926152 2829 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2830
841a1577 2831 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2832 GCC 4.6.0 optimizes based on type-based alias analysis.
2833 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2834 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2835 != &v->size, and therefore "v->size = 1; b->size = 2; return
2836 v->size;" must therefore return 1. This assumption is incorrect
2837 for Emacs, since it type-puns struct Lisp_Vector * with many other
2838 types. To fix this problem, this patch adds a new type struct
f904488f 2839 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2840 and pseudovectors, and helps optimizing compilers not get fooled
2841 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2842 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2843 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2844 the size member.
eab3844f
PE
2845 (XSETPVECTYPE): Rewrite in terms of new macro.
2846 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2847 This is a bit clearer, and further avoids the possibility of
2848 undesirable aliasing.
2849 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2850 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2851 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2852 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2853 (ASIZE): Now uses header.size rather than size.
2854 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2855 to avoid the hassle of writing XVECTOR (foo)->header.size.
2856 (struct vectorlike_header): New type.
eab3844f
PE
2857 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2858 object, to help avoid aliasing.
2859 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2860 (SUBRP): Likewise, since Lisp_Subr is a special case.
2861 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2862 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2863 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2864 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2865 changed to be "header.size" and "header.next".
2866 * buffer.h (struct buffer): Likewise.
2867 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2868 * frame.h (struct frame): Likewise.
2869 * process.h (struct Lisp_Process): Likewise.
2870 * termhooks.h (struct terminal): Likewise.
2871 * window.c (struct save_window_data, struct saved_window): Likewise.
2872 * window.h (struct window): Likewise.
2873 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2874 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2875 * buffer.c (init_buffer_once): Likewise.
2876 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2877 special case.
2878 * process.c (Fformat_network_address): Use local var for size,
2879 for brevity.
2880
0df1eac5
PE
2881 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2882
847ab9d1 2883 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2884 * data.c (atof): Remove decl; no longer used or needed.
2885 (digit_to_number): Move to lread.c.
2886 (Fstring_to_number): Use new string_to_number function, to be
2887 consistent with how the Lisp reader treats infinities and NaNs.
2888 Do not assume that floating-point numbers represent EMACS_INT
2889 without losing information; this is not true on most 64-bit hosts.
2890 Avoid double-rounding errors, by insisting on integers when
2891 parsing non-base-10 numbers, as the documentation specifies.
2892 * lisp.h (string_to_number): New decl, replacing ...
2893 (isfloat_string): Remove.
bc0a5c13 2894 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2895 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2896 appears to have been a coding error. Similarly, do not accept
2897 strings like +-1e0 as floating point numbers. Do not report
2898 overflow for integer overflows unless the base is not 10 which
2899 means we have no simple and reliable way to continue.
2900 Break out the floating-point parsing into a new
2901 function string_to_number, so that Fstring_to_number parses
2902 floating point numbers consistently with the Lisp reader.
04f2d78b 2903 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2904 (E_CHAR, EXP_INT): Remove, replacing with ...
2905 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2906 (string_to_number): New function, replacing isfloat_string.
2907 This function checks for valid syntax and produces the resulting
2908 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2909 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2910 so that overflow for non-base-10 numbers is reported only when
2911 there's no portable and simple way to convert to floating point.
452f4150 2912
67769ffc
PE
2913 * textprop.c (set_text_properties_1): Rewrite for clarity,
2914 and to avoid GCC warning about integer overflow.
2915
c20db43f
PE
2916 * intervals.h (struct interval): Use EMACS_INT for members
2917 where EMACS_UINT might cause problems. See
2918 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2919 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2920 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2921 All uses changed.
37aa2f85
PE
2922 (offset_intervals): Tell GCC not to worry about length overflow
2923 when negating a negative length.
c20db43f 2924
2538aa2f
PE
2925 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2926 (overrun_check_free): Likewise.
2927
f2d3008d
PE
2928 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2929 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2930 word size.
2931
ec8df744
PE
2932 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2933 (gnutls_make_error): Rename local to avoid shadowing.
2934 (gnutls_emacs_global_deinit): ifdef out; not used.
2935 (Fgnutls_boot): Use const for pointer to readonly storage.
2936 Comment out unused local. Fix pointer signedness problems.
2937
640ee02d
PE
2938 * lread.c (openp): Don't stuff size_t into an 'int'.
2939 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2940 about possible signed overflow.
2941
6048fb2a
PE
2942 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2943 (GDK_KEY_g): Don't define if already defined.
2944 (xg_prepare_tooltip): Avoid pointer signedness problem.
2945 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2946
fa3c87e1
PE
2947 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2948 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2949
2172544b
PE
2950 * xfns.c (Fx_window_property): Simplify a bit,
2951 to make a bit faster and to avoid GCC 4.6.0 warning.
2952 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2953
9b821a21
PE
2954 * fns.c (internal_equal): Don't assume size_t fits in int.
2955
3c616cfa
PE
2956 * alloc.c (compact_small_strings): Tighten assertion a little.
2957
c2982e87
PE
2958 Replace pEd with more-general pI, and fix some printf arg casts.
2959 * lisp.h (pI): New macro, generalizing old pEd macro to other
2960 conversion specifiers. For example, use "...%"pI"d..." rather
2961 than "...%"pEd"...".
2962 (pEd): Remove. All uses replaced with similar uses of pI.
2963 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2964 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2965 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2966 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2967 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2968 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2969 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2970 64-bit hosts.
2971 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2972 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2973 * print.c (safe_debug_print, print_object): Likewise.
2974 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2975 to int.
6f04d126
PE
2976 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2977 avoiding the 0 flag, which is not portable.
c2982e87
PE
2978 * process.c (Fmake_network_process): Use pI to avoid cast.
2979 * region-cache.c (pp_cache): Likewise.
2980 * xdisp.c (decode_mode_spec): Likewise.
2981 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2982 behavior on 64-bit hosts with printf arg.
6f04d126 2983 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2984 (x_stop_queuing_selection_requests): Likewise.
2985 (x_get_window_property): Don't truncate byte count to an 'int'
2986 when tracing.
0b432f21 2987
5e073ec7
PE
2988 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2989 here, since it parses constructs like leading '-' and spaces,
2990 which are not wanted; and it overflows with large numbers.
2991 Instead, simply match F[0-9]+, which is what is wanted anyway.
2992
36372bf9
PE
2993 * alloc.c: Remove unportable assumptions about struct layout.
2994 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2995 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2996 (allocate_vectorlike, make_pure_vector): Use the new macros,
2997 plus offsetof, to remove unportable assumptions about struct layout.
2998 These assumptions hold on all porting targets that I know of, but
2999 they are not guaranteed, they're easy to remove, and removing them
3000 makes further changes easier.
3001
0b432f21
PE
3002 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3003 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3004 (string_overrun_cookie): Now const. Use initializers that
3005 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3006 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3007 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3008 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3009 multiple of sizeof (EMACS_INT); it need not be, if
3010 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3011 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3012
895009e1
JB
30132011-04-26 Juanma Barranquero <lekktu@gmail.com>
3014
3015 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3016
6a7a1b0b
TZ
30172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3018
3019 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3020 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3021 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3022
841a1577 30232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3024
3025 * lisp.h (Qdebug): List symbol.
895009e1 3026 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3027 * keyboard.c (debug-on-event): New variable.
3028 (handle_user_signal): Break into debugger when debug-on-event
3029 matches the current signal symbol.
3030
f2d3ba6f
DN
30312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3032
3033 * alloc.c (check_sblock, check_string_bytes)
3034 (check_string_free_list): Convert to standard C.
3035
42ce4c63
TZ
30362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3037
3038 * w32.c (emacs_gnutls_push): Fix typo.
3039
825cd63c
EZ
30402011-04-25 Eli Zaretskii <eliz@gnu.org>
3041
fb11d64d
EZ
3042 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3043 "cast to pointer from integer of different size".
3044
825cd63c
EZ
3045 Improve doprnt and its use in verror. (Bug#8545)
3046 * doprnt.c (doprnt): Document the set of format control sequences
3047 supported by the function. Use SAFE_ALLOCA instead of always
3048 using `alloca'.
3049
3050 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3051 is one byte too soon. Don't use xrealloc; instead xfree and
3052 xmalloc anew.
3053
e061a11b
TZ
30542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3055
3056 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3057 callbacks stage.
3058
3059 * gnutls.c: Renamed global_initialized to
3060 gnutls_global_initialized. Added internals for the
3061 :verify-hostname-error, :verify-error, and :verify-flags
3062 parameters of `gnutls-boot' and documented those parameters in the
3063 docstring. Start callback support.
9173deec
JB
3064 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3065 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3066 on error. Return error code.
e061a11b
TZ
3067 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3068 (emacs_gnutls_read): Likewise.
3069 (Fgnutls_boot): Return handshake error code.
3070 (emacs_gnutls_handle_error): New function.
3071 (wsaerror_to_errno): Likewise.
3072
3073 * w32.h (emacs_gnutls_pull): Add prototype.
3074 (emacs_gnutls_push): Likewise.
3075
3076 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3077 (emacs_gnutls_push): Likewise.
3078
30792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3080
3081 * process.c (wait_reading_process_output): Check if GnuTLS
3082 buffered some data internally if no FDs are set for TLS
3083 connections.
3084
3085 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3086 (LIBS): Link to USER_LIBS.
3087 ($(BLD)/gnutls.$(0)): New target.
3088
fa6996bc
EZ
30892011-04-24 Eli Zaretskii <eliz@gnu.org>
3090
eb35682e
EZ
3091 * xdisp.c (handle_single_display_spec): Rename the
3092 display_replaced_before_p argument into display_replaced_p, to
3093 make it consistent with the commentary. Fix typos in the
3094 commentary.
3095
e2ad650c
EZ
3096 * textprop.c (syms_of_textprop): Remove dead code.
3097 (copy_text_properties): Delete obsolete commentary about an
3098 interface that was deleted long ago. Fix typos in the description
3099 of arguments.
3100
1b2de274
EZ
3101 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3102 to changes in oldXMenu/XMenu.h from 2011-04-16.
3103 <menu_help_message, prev_menu_help_message>: Constify.
3104 (IT_menu_make_room): menu->help_text is now `const char **';
3105 adjust.
3106
3107 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3108 to changes in oldXMenu/XMenu.h from 2011-04-16.
3109 (struct XMenu): Declare `help_text' `const char **'.
3110
3111 * xfaces.c <Qunspecified>: Make extern again.
3112
3113 * syntax.c: Include sys/types.h before including regex.h, as
3114 required by Posix.
3115
762b15be
EZ
3116 * doc.c (get_doc_string): Improve the format passed to `error'.
3117
3118 * doprnt.c (doprnt): Improve commentary.
3119
3120 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3121
3122 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3123 them with etags.
3124
f1052e5d
EZ
3125 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3126 changes in globals.h immediately force recompilation.
762b15be
EZ
3127 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3128 $(CURDIR)/s/ms-w32.h.
3129 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3130
fa6996bc
EZ
3131 * character.c (Fchar_direction): Function deleted.
3132 (syms_of_character): Don't defsubr it.
3133 <char-direction-table>: Deleted.
3134
e6c3da20
EZ
31352011-04-23 Eli Zaretskii <eliz@gnu.org>
3136
3137 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3138 * doprnt.c: Include limits.h.
3139 (SIZE_MAX): New macro.
04f2d78b
CB
3140 (doprnt): Return a size_t value. 2nd arg is now size_t.
3141 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3142 Improve overflow protection. Support `l' modifier for integer
3143 conversions. Support %l conversion. Don't assume an EMACS_INT
3144 argument for integer conversions and for %c.
3145
3146 * lisp.h (doprnt): Restore prototype.
3147
3148 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3149 $(SRC)/character.h.
3150
3151 * Makefile.in (base_obj): Add back doprnt.o.
3152
3153 * deps.mk (doprnt.o): Add back prerequisites.
3154 (callint.o): Depend on character.h.
3155
3156 * eval.c (internal_lisp_condition_case): Include the handler
3157 representation in the error message.
3158 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3159 when breaking from the loop.
3160
3161 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3162
3163 * callint.c (Fcall_interactively): When displaying error message
3164 about invalid control letter, pass the character's codepoint, not
3165 a pointer to its multibyte form. Improve display of the character
3166 in octal and display also its hex code.
3167
3168 * character.c (char_string): Use %x to display the (unsigned)
3169 codepoint of an invalid character, to avoid displaying a bogus
3170 negative value.
3171
3172 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3173 `error', not SYMBOL_NAME itself.
3174
3175 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3176 character arguments to `error'.
3177
3178 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3179 to `error' in error message about FINAL_CHAR argument. Make sure
3180 FINAL_CHAR is a character, and use %c when it is passed as
3181 argument to `error'.
3182
4ffd0d6b 31832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3184
3185 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3186
3187 * w32.c: Include <time.h>.
3188 (sys_localtime): New function.
3189
4ffd0d6b 31902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3191
3192 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3193
4ffd0d6b 3194 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3195
4ffd0d6b 31962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3197
4ffd0d6b
GM
3198 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3199 zombies (Bug#8467).
aac0c6e3 3200
04c56954
EZ
32012011-04-19 Eli Zaretskii <eliz@gnu.org>
3202
3203 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3204 gl_state.e_property when gl_state.object is Qt.
3205
3206 * insdel.c (make_gap_larger): Remove limitation of buffer size
3207 to <= INT_MAX.
3208
16a43933
CY
32092011-04-18 Chong Yidong <cyd@stupidchicken.com>
3210
3211 * xdisp.c (lookup_glyphless_char_display)
3212 (produce_glyphless_glyph): Handle cons cell entry in
3213 glyphless-char-display.
3214 (Vglyphless_char_display): Document it.
3215
3216 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3217 glyphless-char-display.
3218
4581706e
CY
32192011-04-17 Chong Yidong <cyd@stupidchicken.com>
3220
3221 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3222
3223 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3224
3225 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3226 definition for no-X builds.
3227
4887c6e2 32282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3229
fd35b6f9
PE
3230 Static checks with GCC 4.6.0 and non-default toolkits.
3231
5c1ccb01
PE
3232 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3233
006c5daa
PE
3234 * process.c (keyboard_bit_set): Define only if SIGIO.
3235 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3236 (send_process): Repair possible setjmp clobbering.
3237
efc736d3
PE
3238 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3239
4e2fe2e6
PE
3240 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3241
f97334a2
PE
3242 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3243
4e75f29d
PE
3244 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3245 Define only if needed.
3246
90efadd1
PE
3247 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3248 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3249 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3250
3c647824
PE
3251 * dispextern.h (struct redisplay_interface): Rename param
3252 to avoid shadowing.
e264f262 3253 * termhooks.h (struct terminal): Likewise.
761383f4 3254 * xterm.c (xembed_send_message): Likewise.
3c647824 3255
b58c5c4a
PE
3256 * insdel.c (make_gap_smaller): Define only if
3257 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3258
cad59032
PE
3259 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3260 it.
3261
c339dc2e
PE
3262 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3263 so that we aren't warned about unused symbols.
3264
91a3e27b
PE
3265 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3266
399c71d3 3267 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3268
8ffc96f5
PE
3269 * xfns.c (x_real_positions): Mark locals as initialized.
3270
eef9bc79
PE
3271 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3272
098db9dd
PE
3273 * xterm.c: Fix problems found by static analysis with other toolkits.
3274 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3275 (x_dispatch_event): Declare static if USE_GTK, and
3276 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3277 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3278 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3279 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3280 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3281
eb18f6cc
PE
3282 * xmenu.c (menu_help_callback): Pointer type fixes.
3283 Use const pointers when pointing at readonly data. Avoid pointer
3284 signedness clashes.
3285 (FALSE): Remove unused macro.
3286 (update_frame_menubar): Remove unused decl.
3287
1fe72bf8
PE
3288 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3289
60d9e1db
PE
3290 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3291 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3292 (single_menu_item): Rename local to avoid shadowing.
3293
39261c26
PE
3294 * keyboard.c (make_lispy_event): Remove unused local var.
3295
018c5e19
PE
3296 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3297 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3298
63d2b86e
PE
3299 * bitmaps: Change bitmaps from unsigned char back to the X11
3300 compatible char. Avoid the old compiler warnings about
3301 out-of-range initializers by using, for example, '\xab' rather
3302 than 0xab.
3303
aefd87e1
PE
3304 * xgselect.c (xgselect_initialize): Check vs interface
3305 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3306
bf501fb9
PE
3307 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3308
e9829fdf
PE
3309 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3310 to read-only memory.
3311
1086c095
PE
3312 * fns.c (vector): Remove; this old hack is no longer needed.
3313
2baccd04 3314 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3315 Remove unused var.
dde42981 3316 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3317
72391843 3318 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3319
436c16df 3320 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3321 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3322 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3323
92bb796d 3324 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3325 (x_term_init): Remove local to avoid shadowing.
92bb796d 3326
764430a3 3327 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3328
3329 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3330 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3331
d1dfb56c
EZ
33322011-04-16 Eli Zaretskii <eliz@gnu.org>
3333
c4354cb4
EZ
3334 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3335
d1dfb56c
EZ
3336 Fix regex.c, syntax.c and friends for buffers > 2GB.
3337 * syntax.h (struct gl_state_s): Declare character position members
3338 EMACS_INT.
3339
3340 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3341
04f2d78b
CB
3342 * textprop.c (verify_interval_modification, interval_of):
3343 Declare arguments EMACS_INT.
d1dfb56c
EZ
3344
3345 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3346 EMACS_INT.
3347
3348 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3349
3350 * indent.c (Fvertical_motion): Local variable it_start is now
3351 EMACS_INT.
3352
3353 * regex.c (re_match, re_match_2, re_match_2_internal)
3354 (bcmp_translate, regcomp, regexec, print_double_string)
3355 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3356 (re_compile_pattern, re_exec): Declare arguments and local
3357 variables `size_t' and `ssize_t' and return values `regoff_t', as
3358 appropriate.
3359 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3360 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3361 <compile_stack_type>: `size' and `avail' are now `size_t'.
3362
3363 * regex.h <regoff_t>: Use ssize_t, not int.
3364 (re_search, re_search_2, re_match, re_match_2): Arguments that
3365 specify buffer/string position and length are now ssize_t and
3366 size_t. Return type is regoff_t.
3367
613052cd
BK
33682011-04-16 Ben Key <bkey76@gmail.com>
3369
3370 * nsfont.m: Fixed bugs in ns_get_family and
3371 ns_descriptor_to_entity that were caused by using free to
3372 deallocate memory blocks that were allocated by xmalloc (via
3373 xstrdup). This caused Emacs to crash when compiled with
3374 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3375 --enable-checking=xmallocoverrun). xfree is now used to
3376 deallocate these memory blocks.
3377
4170f62f 33782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3379
71b41406
PE
3380 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3381
9587a89d
PE
3382 emacs_write: Accept and return EMACS_INT for sizes.
3383 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3384 et seq.
3385 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3386 Accept and return EMACS_INT.
3387 (emacs_gnutls_write): Return the number of bytes written on
3388 partial writes.
3389 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3390 (emacs_read, emacs_write): Remove check for negative size, as the
3391 Emacs source code has been audited now.
9587a89d
PE
3392 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3393 (emacs_read, emacs_write): Use it.
273a5f82
PE
3394 * process.c (send_process): Adjust to the new signatures of
3395 emacs_write and emacs_gnutls_write. Do not attempt to store
3396 a byte offset into an 'int'; it might overflow.
9587a89d 3397 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3398
3e047f51
PE
3399 * sound.c: Don't assume sizes fit in 'int'.
3400 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3401 Return EMACS_INT, not int.
3e047f51 3402 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3403 Accept EMACS_INT, not int.
3404 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3405 record read return values.
3406
cc39a9db
BK
34072011-04-15 Ben Key <bkey76@gmail.com>
3408
c9d0ec6d
JB
3409 * keyboard.c (Qundefined): Don't declare static since it is used
3410 in nsfns.m.
3411 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3412 static since they are used in nsfont.m.
cc39a9db 3413
6c60eb9f
SM
34142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3415
3416 * process.c (Qprocessp): Don't declare static.
3417 * lisp.h (Qprocessp): Declare again.
3418
7990b61a
JB
34192011-04-15 Juanma Barranquero <lekktu@gmail.com>
3420
3421 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3422
5d4cb038
PE
34232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3424
8bd7b830 3425 Improve C-level modularity by making more things 'static'.
cd64ea1d 3426
e3b27b31
PE
3427 Don't publish debugger-only interfaces to other modules.
3428 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3429 (verify_bytepos, count_markers): Move decls to the only modules
3430 that need them.
3431 * region-cache.h (pp_cache): Likewise.
3432 * window.h (check_all_windows): Likewise.
3433 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3434
5d4cb038
PE
3435 * sysdep.c (croak): Now static, if
3436 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3437 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3438
3439 * alloc.c (refill_memory_reserve): Now static if
3440 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3441 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3442
e87b6180
PE
3443 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3444 Define only if USE_LUCID.
3445
ac64929e
PE
3446 * xrdb.c (x_customization_string, x_rm_string): Now static.
3447
6f37259d
PE
3448 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3449 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3450
1683e3ab
PE
3451 * xdisp.c (draw_row_with_mouse_face): Now static.
3452 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3453
de9c2632
PE
3454 * window.h (check_all_windows): Mark externally visible.
3455
2b96acb7
PE
3456 * window.c (window_deletion_count): Now static.
3457
3458 * undo.c: Make symbols static if they're not exported.
3459 (last_undo_buffer, last_boundary_position, pending_boundary):
3460 Now static.
3461
50436f33
PE
3462 * textprop.c (interval_insert_behind_hooks): Now static.
3463 (interval_insert_in_front_hooks): Likewise.
3464
64520e5c
PE
3465 * term.c: Make symbols static if they're not exported.
3466 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3467 (max_frame_lines, tty_set_terminal_modes):
3468 (tty_reset_terminal_modes, tty_turn_off_highlight):
3469 (get_tty_terminal): Now static.
3470 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3471 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3472 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3473 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3474 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3475
1fa53021
PE
3476 * sysdep.c: Make symbols static if they're not exported.
3477 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3478 Now static.
3479 (sigprocmask_set, full_mask): Remove; unused.
3480 (wait_debugging): Mark as visible.
3481 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3482 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3483
d4b43b22
PE
3484 * syntax.c (syntax_temp): Define only if !__GNUC__.
3485
b7c513d0
PE
3486 * sound.c (current_sound_device, current_sound): Now static.
3487
989b29ad
PE
3488 * search.c (searchbufs, searchbuf_head): Now static.
3489
13a55a78
PE
3490 * scroll.c (scroll_cost): Remove; unused.
3491 * dispextern.h (scroll_cost): Remove decl.
3492
de68a1fc
PE
3493 * region-cache.h (pp_cache): Mark as externally visible.
3494
40ccffa6
PE
3495 * process.c: Make symbols static if they're not exported.
3496 (process_tick, update_tick, create_process, chan_process):
3497 (Vprocess_alist, proc_buffered_char, datagram_access):
3498 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3499 (deactivate_process): Mark defn as static, as well as decl.
3500 * lisp.h (create_process): Remove decl.
3501 * process.h (chan_process, Vprocess_alist): Remove decls.
3502
ad64fc97
PE
3503 * print.c: Make symbols static if they're not exported.
3504 (print_depth, new_backquote_output, being_printed, print_buffer):
3505 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3506 (print_interval, print_number_index, initial_stderr_stream):
3507 Now static.
3508 * lisp.h (Fprinc): Remove decl.
3509 (debug_output_compilation_hack): Mark as externally visible.
3510
adddb265
PE
3511 * sysdep.c (croak): Move decl from here to syssignal.h.
3512 * syssignal.h (croak): Put it here, so the API can be checked when
3513 'croak' is called from dissociate_if_controlling_tty.
3514
1717ede2
PE
3515 * minibuf.c: Make symbols static if they're not exported.
3516 (minibuf_save_list, choose_minibuf_frame): Now static.
3517 * lisp.h (choose_minibuf_frame): Remove decl.
3518
fa5fb2bc
PE
3519 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3520
1e3890d1
PE
3521 * lread.c: Make symbols static if they're not exported.
3522 (read_objects, initial_obarray, oblookup_last_bucket_number):
3523 Now static.
3524 (make_symbol): Remove; unused.
3525 * lisp.h (initial_obarray, make_symbol): Remove decls.
3526
8a1414fa
PE
3527 * keyboard.c: Make symbols static if they're not exported.
3528 (single_kboard, recent_keys_index, total_keys, recent_keys):
3529 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3530 (this_single_command_key_start, echoing, last_auto_save):
3531 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3532 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3533 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3534 (Vlispy_mouse_stem, double_click_count):
3535 Now static.
3536 (force_auto_save_soon): Define only if SIGDANGER.
3537 (ignore_mouse_drag_p): Now static if
3538 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3539 (print_help): Remove; unused.
3540 (stop_character, last_timer_event): Mark as externally visible.
3541 * keyboard.h (ignore_mouse_drag_p): Declare only if
3542 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3543 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3544 * lisp.h (echoing): Remove decl.
3545 (force_auto_save_soon): Declare only if SIGDANGER.
3546 * xdisp.c (redisplay_window): Simplify code, to make it more
3547 obvious that ignore_mouse_drag_p is not accessed if !defined
3548 USE_GTK && !defined HAVE_NS.
3549
93ea6e8f
PE
3550 * intervals.c: Make symbols static if they're not exported.
3551 (merge_properties_sticky, merge_interval_right, delete_interval):
3552 Now static.
3553 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3554
77382fcc
PE
3555 * insdel.c: Make symbols static if they're not exported.
3556 However, leave prepare_to_modify_buffer alone. It's never
3557 called from outside this function, but that appears to be a bug.
3558 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3559 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3560 (adjust_after_replace_noundo): Remove; unused.
3561 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3562 (signal_before_change): Remove decls.
77382fcc 3563
9306c32e
PE
3564 * indent.c (val_compute_motion, val_vmotion): Now static.
3565
cd44d2eb
PE
3566 * image.c: Make symbols static if they're not exported.
3567 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3568 if USE_GTK.
3569 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3570 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3571
ad9a7a06
PE
3572 * fringe.c (standard_bitmaps): Now static.
3573 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3574
81626931
PE
3575 * frame.c: Make symbols static if they're not exported.
3576 (x_report_frame_params, make_terminal_frame): Now static.
3577 (get_frame_param): Now static, unless HAVE_NS.
3578 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3579 (x_get_resource_string): Remove; not used.
3580 * frame.h (make_terminal_frame, x_report_frame_params):
3581 (x_get_resource_string); Remove decls.
3582 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3583 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3584
239f9db9
PE
3585 * font.c, fontset.c: Make symbols static if they're not exported.
3586 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3587 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3588 * font.c (font_close_object): Now static.
3589 * font.h (font_close_object): Remove.
3590 * fontset.c (FONTSET_OBJLIST): Remove.
3591 (free_realized_fontset) #if-0 the body, which does nothing.
3592 (face_suitable_for_char_p): #if-0, as it's never called.
3593 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3594 * xfaces.c (face_at_string_position):
3595 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3596 since 0 is always ASCII.
3597
dfcf3579
PE
3598 * fns.c (weak_hash_tables): Now static.
3599
5045092b
PE
3600 * fileio.c: Make symbols static if they're not exported.
3601 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3602 (Vwrite_region_annotation_buffers): Now static.
3603
57a96f5c
PE
3604 * eval.c: Make symbols static if they're not exported.
3605 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3606 * lisp.h (backtrace_list): Remove decl.
3607
35f08c38
PE
3608 * emacs.c: Make symbols static if they're not exported.
3609 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3610 (fatal_error_code, fatal_error_signal_hook, standard_args):
3611 Now static.
3612 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3613 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3614 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3615 * lisp.h (fatal_error_signal_hook): Remove decl.
3616 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3617
f44bd759
PE
3618 * editfns.c: Move a (normally-unused) function to its only use.
3619 * editfns.c, lisp.h (get_operating_system_release): Remove.
3620 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3621 worth the hassle of breaking this out.
3622
b532497d
PE
3623 * xterm.c: Make symbols static if they're not exported.
3624 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3625 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3626 (x_destroy_window, x_delete_display):
3627 Now static.
3628 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3629 (x_mouse_leave): Remove; unused.
3630 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3631 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3632 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3633 Remove decls.
3634 (x_mouse_leave): Declare only if WINDOWSNT.
3635 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3636 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3637 USE_X_TOOLKIT.
3638
1675728f
PE
3639 * ftxfont.c: Make symbols static if they're not exported.
3640 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3641 HAVE_FREETYPE.
3642 * font.h (ftxfont_driver): Likewise.
3643
e4cebfca
PE
3644 * xfns.c: Make symbols static if they're not exported.
3645 (x_last_font_name, x_display_info_for_name):
3646 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3647 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3648 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3649 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3650 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3651 (last_show_tip_args): Now static.
3652 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3653 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3654 (x_screen_planes): Remove; unused.
3655 * dispextern.h (x_screen_planes): Remove decl.
3656
5bf46f05
PE
3657 * dispnew.c: Make symbols static if they're not exported.
3658 * dispextern.h (redraw_garbaged_frames, scrolling):
3659 (increment_row_positions): Remove.
3660 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3661 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3662 Now static.
3663 (redraw_garbaged_frames): Remove; unused.
3664
435f4c28
PE
3665 * xfaces.c: Make symbols static if they're not exported.
3666 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3667 Remove decls.
3668 * xterm.h (defined_color): Remove decls.
3669 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3670 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3671 (menu_face_changed_default, defined_color, free_realized_face):
3672 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3673 (ascii_face_of_lisp_face): Remove; unused.
3674
8524aef3
PE
3675 * xdisp.c: Make symbols static if they're not exported.
3676 * dispextern.h (scratch_glyph_row, window_box_edges):
3677 (glyph_to_pixel_coords, set_cursor_from_row):
3678 (get_next_display_element, set_iterator_to_next):
3679 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3680 (show_mouse_face): Remove decls
3681 * frame.h (message_buf_print): Likewise.
3682 * lisp.h (pop_message, set_message, check_point_in_composition):
3683 Likewise.
3684 * xterm.h (set_vertical_scroll_bar): Likewise.
3685 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3686 (message_buf_print, scratch_glyph_row, displayed_buffer):
3687 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3688 (get_next_display_element, show_mouse_face, window_box_edges):
3689 (frame_to_window_pixel_xy, check_point_in_composition):
3690 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3691 (glyph_to_pixel_coords): Remove; unused.
3692
16390cd2
PE
3693 * dired.c (file_name_completion): Now static.
3694
3695 * dbusbind.c (xd_in_read_queued_messages): Now static.
3696
a25f4dfa
PE
3697 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3698 * data.c (circular_list_error): Remove.
3699
14a9c8df
PE
3700 * commands.h (last_point_position, last_point_position_buffer):
3701 (last_point_position_window): Remove decls.
3702 * keyboard.c: Make these variables static.
3703
04f2d78b
CB
3704 * coding.h (coding, code_convert_region, encode_coding_gap):
3705 Remove decls.
74ab6df5
PE
3706 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3707 (iso_code_class, detect_coding, code_convert_region): Now static.
3708 (encode_coding_gap): Remove; unused.
3709
38dfbee1
PE
3710 * chartab.c (chartab_chars, chartab_bits): Now static.
3711
a2cb4e63
PE
3712 * charset.h (charset_iso_8859_1): Remove decl.
3713 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3714 Now static.
3715
127198fd
PE
3716 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3717 * ccl.c (Vccl_program_table): Now static.
3718 (check_ccl_update): Remove; unused.
3719
d85b608f
PE
3720 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3721 * category.h: ... from here.
3722 * category.c (check_category_table, set_category_set): Now static.
3723
31cd66f3
PE
3724 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3725 * lisp.h: Remove these decls.
3726
c358e587
PE
3727 * buffer.c (buffer_count): Remove unused var.
3728
e78aecca
PE
3729 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3730 so that it's not optimized away.
3731 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3732 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3733 exported only to the debugger.
3734
e192d7d3 3735 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3736 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3737
92470028
PE
3738 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3739 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3740 was inaccessible from Lisp.
3741 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3742 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3743
244ed907
PE
3744 alloc.c: Import and export fewer symbols, and remove unused items.
3745 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3746 is defined.
3747 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3748 it's not optimized away by whole-program optimization.
3749 (message_enable_multibyte, free_misc): Remove.
3750 (catchlist, handlerlist, mark_backtrace):
3751 Declare only if BYTE_MARK_STACK.
3752 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3753 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3754 (message_enable_multibyte): Remove decl.
3755 (free_misc, interval_free_list, float_block, float_block_index):
3756 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3757 (cons_free_list, last_marked_index):
3758 Now static.
3759 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3760 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3761 (mark_backtrace): Define only if BYTE_MARK_STACK.
3762 * xdisp.c (message_enable_multibyte): Now static.
3763
61c2b50e 3764 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3765 This makes it easier for human readers (and static analyzers)
3766 to see whether these variables are used from other modules.
3767 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3768 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3769 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3770 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3771 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3772 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3773 * xmenu.c, xselect.c:
3774 Declare Q* vars static if they are not used in other modules.
3775 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3776 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3777 Remove decls of unexported vars.
3778 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3779
95c82688
PE
3780 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3781
16a97296
PE
3782 Make Emacs functions such as Fatom 'static' by default.
3783 This makes it easier for human readers (and static analyzers)
3784 to see whether these functions can be called from other modules.
3785 DEFUN now defines a static function. To make the function external
3786 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3787 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3788 (Finit_image_library):
16a97296
PE
3789 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3790 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3791 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3792 Remove decls, since these functions are now static.
3793 (Funintern, Fget_internal_run_time): New decls, since these functions
3794 were already external.
95c82688 3795
16a97296
PE
3796 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3797 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3798 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3799 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3800 * keyboard.c, keymap.c, lread.c:
3801 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3802 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3803 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3804 Mark functions with DEFUE instead of DEFUN,
3805 if they are used in other modules.
3806 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3807 decls for now-static functions.
3808 * buffer.h (Fdelete_overlay): Remove decl.
3809 * callproc.c (Fgetenv_internal): Mark as internal.
3810 * composite.c (Fremove_list_of_text_properties): Remove decl.
3811 (Fcomposition_get_gstring): New forward static decl.
3812 * composite.h (Fcomposite_get_gstring): Remove decl.
3813 * dired.c (Ffile_attributes): New forward static decl.
3814 * doc.c (Fdocumntation_property): New forward static decl.
3815 * eval.c (Ffetch_bytecode): New forward static decl.
3816 (Funintern): Remove extern decl; now in .h file where it belongs.
3817 * fileio.c (Fmake_symbolic_link): New forward static decl.
3818 * image.c (Finit_image_library): New forward static decl.
3819 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3820 * intervals.h (Fprevious_property_change):
3821 (Fremove_list_of_text_properties): Remove decls.
3822 * keyboard.c (Fthis_command_keys): Remove decl.
3823 (Fcommand_execute): New forward static decl.
3824 * keymap.c (Flookup_key): New forward static decl.
3825 (Fcopy_keymap): Now static.
3826 * keymap.h (Flookup_key): Remove decl.
3827 * process.c (Fget_process): New forward static decl.
3828 (Fprocess_datagram_address): Mark as internal.
3829 * syntax.c (Fsyntax_table_p): New forward static decl.
3830 (skip_chars): Remove duplicate decl.
3831 * textprop.c (Fprevious_property_change): New forward static decl.
3832 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3833 Now internal.
3834 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3835 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3836
785bbd42
PE
3837 * editfns.c (Fformat): Remove unreachable code.
3838
8b913b57
AS
38392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3840
3841 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3842 change. (Bug#8496)
3843
a6744a35
EZ
38442011-04-13 Eli Zaretskii <eliz@gnu.org>
3845
3846 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3847 when at ZV. (Bug#8487)
3848
e7974947
AS
38492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3850
baad03f0
AS
3851 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3852 (Bug#8437)
3853 * keyboard.c (parse_tool_bar_item): Likewise.
3854 * sound.c (sound_cleanup, alsa_close): Likewise.
3855 * termcap.c (tgetent): Likewise.
3856 * xfns.c (x_default_font_parameter): Likewise.
3857 * xsettings.c (read_and_apply_settings): Likewise.
3858
e7974947
AS
3859 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3860 (overrun_check_free): Protoize.
3861
28272684
PE
38622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3865 since callers should never pass a negative size.
3866 Change the signature to match that of plain 'read' and 'write'; see
3867 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3868 * lisp.h: Update prototypes of emacs_write and emacs_read.
3869
11997c76
EZ
38702011-04-11 Eli Zaretskii <eliz@gnu.org>
3871
3872 * xdisp.c (redisplay_window): Don't try to determine the character
3873 position of the scroll margin if the window start point w->startp
e896f03c 3874 is outside the buffer's accessible region. (Bug#8468)
11997c76 3875
8a2cbd72
EZ
38762011-04-10 Eli Zaretskii <eliz@gnu.org>
3877
3878 Fix write-region and its subroutines for buffers > 2GB.
3879 * fileio.c (a_write, e_write): Modify declaration of arguments and
3880 local variables to support buffers larger than 2GB.
3881 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3882
3883 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3884 argument, local variables, and return value.
3885
3886 * lisp.h: Update prototypes of emacs_write and emacs_read.
3887
3888 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3889
4073e537 38902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3891
1ebfdcb6
PE
3892 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3893
b2ded58d
PE
3894 Fix more problems found by GCC 4.6.0's static checks.
3895
7d66342c
PE
3896 * xdisp.c (vmessage): Use a better test for character truncation.
3897
bbf47d44
PE
3898 * charset.c (load_charset_map): <, not <=, for optimization,
3899 and to avoid potential problems with integer overflow.
9248994d 3900 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3901 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3902 * editfns.c (Fformat): Likewise.
1e69125e 3903 * syntax.c (skip_chars): Likewise.
3befa583 3904
e3019616
PE
3905 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3906 This also lets GCC 4.6.0 generate slightly better loop code.
3907
becfa255
PE
3908 * callint.c (Fcall_interactively): <, not <=, for optimization.
3909 (Fcall_interactively): Count the number of arguments produced,
3910 not the number of arguments given. This is simpler and lets GCC
3911 4.6.0 generate slightly better code.
3912
dae0cd48
PE
3913 * ftfont.c: Distingish more carefully between FcChar8 and char.
3914 The previous code passed unsigned char * to a functions like
3915 strlen and xstrcasecmp that expect char *, which does not
3916 conform to the C standard.
3917 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3918 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3919 char * when the C standard requires it.
3920
76032d70
PE
3921 * keyboard.c (read_char): Remove unused var.
3922
eb3f1cc8
PE
3923 * eval.c: Port to Windows vsnprintf (Bug#8435).
3924 Include <limits.h>.
3925 (SIZE_MAX): Define if the headers do not.
3926 (verror): Do not give up if vsnprintf returns a negative count.
3927 Instead, grow the buffer. This ports to Windows vsnprintf, which
3928 does not conform to C99. Problem reported by Eli Zaretskii.
3929 Also, simplify the allocation scheme, by avoiding the need for
3930 calling realloc, and removing the ALLOCATED variable.
3931
70476b54
PE
3932 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3933
12020a9e
PE
3934 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3935 But keep the doprint source code for now, as we might revamp it
3936 and use it again (Bug#8435).
ea6c7ae6
PE
3937 * lisp.h (doprnt): Remove.
3938 * Makefile.in (base_obj): Remove doprnt.o.
3939 * deps.mk (doprnt.o): Remove.
3940
5fdb398c
PE
3941 error: Print 32- and 64-bit integers portably (Bug#8435).
3942 Without this change, on typical 64-bit hosts error ("...%d...", N)
3943 was used to print both 32- and 64-bit integers N, which relied on
3944 undefined behavior.
3945 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3946 New macro.
3947 * lisp.h (error, verror): Mark as printf-like functions.
3948 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3949 Report overflow in size calculations when allocating printf buffer.
3950 Do not truncate output string at its first null byte.
3951 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3952 Truncate the output at a character boundary, since vsnprintf does not
3953 do that.
3954 * charset.c (check_iso_charset_parameter): Convert internal
3955 character to string before calling 'error', since %c now has the
3956 printf meaning.
3957 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3958 overflow when computing char to be passed to 'error'. Do not
3959 pass Lisp_Object to 'error'; pass the integer instead.
3960 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3961 formatted with plain %d.
3962
b189fa66
PE
3963 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3964
bff87ef0
PE
3965 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3966
7e2cac20
PE
3967 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3968
ce4d90b5
PE
3969 * xterm.c (x_catch_errors): Remove duplicate declaration.
3970
266c9547
PE
3971 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3972
79c49ad2
PE
3973 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3974
368f4090
JM
39752011-04-10 Jim Meyering <meyering@redhat.com>
3976
3977 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3978 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3979 return ssize_t not "int", and use size_t as the buffer length.
3980 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3981 * gnutls.h: Update declarations.
3982 * process.c (read_process_output): Use ssize_t, to match.
3983 (send_process): Likewise.
3984
a32d4040
CY
39852011-04-09 Chong Yidong <cyd@stupidchicken.com>
3986
3987 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3988
8546720e 39892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3990
04f2d78b
CB
3991 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3992 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3993
8546720e
GM
3994 * xterm.c (handle_one_xevent):
3995 * xmenu.c (create_and_show_popup_menu):
3996 * xselect.c (x_decline_selection_request)
3997 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3998
0a2f5c1a 39992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4000
4001 Fix some uses of `int' instead of EMACS_INT.
4002 * search.c (string_match_1, fast_string_match)
4003 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4004 (scan_buffer, find_next_newline_no_quit)
4005 (find_before_next_newline, search_command, Freplace_match)
4006 (Fmatch_data): Make some `int' variables be EMACS_INT.
4007
4008 * xdisp.c (display_count_lines): 3rd argument and return value now
4009 EMACS_INT. All callers changed.
4010 (pint2hrstr): Last argument is now EMACS_INT.
4011
4012 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4013 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4014 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4015 (decode_coding_utf_16, decode_coding_emacs_mule)
4016 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4017 (decode_coding_ccl, decode_coding_charset)
4018 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4019 (decode_coding_iso_2022, decode_coding_emacs_mule)
4020 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4021 <char_offset, last_offset>: Declare EMACS_INT.
4022 (encode_coding_utf_8, encode_coding_utf_16)
4023 (encode_coding_emacs_mule, encode_invocation_designation)
4024 (encode_designation_at_bol, encode_coding_iso_2022)
4025 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4026 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4027 Declare EMACS_INT.
4028 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4029 (encode_invocation_designation): Last argument P_NCHARS is now
4030 EMACS_INT.
4031 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4032 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4033
4034 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4035 All users changed.
4036
4037 * ccl.c (Fccl_execute_on_string): Declare some variables
4038 EMACS_INT.
4039
8546720e 40402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4041
4042 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4043
4e19a977
CS
40442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4045
4046 * process.c (Fformat_network_address): Doc fix.
4047
87302331
R
40482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4049
4050 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4051
cbb59342
CY
40522011-04-08 Chong Yidong <cyd@stupidchicken.com>
4053
4054 * keyboard.c (read_char): Call Lisp function help-form-show,
4055 instead of using internal_with_output_to_temp_buffer.
4056 (Qhelp_form_show): New var.
e0d38eeb 4057 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4058
4059 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4060
4061 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4062
e67a13ab
CY
40632011-04-06 Chong Yidong <cyd@stupidchicken.com>
4064
04f2d78b
CB
4065 * process.c (Flist_processes): Remove to Lisp.
4066 (list_processes_1): Delete.
e67a13ab 4067
973f782d
EZ
40682011-04-06 Eli Zaretskii <eliz@gnu.org>
4069
7c106b1e
EZ
4070 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4071
973f782d
EZ
4072 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4073
41cf7d1a 40742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4075
ca23cc88
PE
4076 Fix more problems found by GCC 4.6.0's static checks.
4077
f390e2d5
PE
4078 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4079
42eea0d0
PE
4080 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4081
b69769da 4082 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4083
f9541e84
PE
4084 * xdisp.c (vmessage): Mark as a printf-like function.
4085
13841b55
PE
4086 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4087
c136c10f
PE
4088 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4089
5e2d4a30
PE
4090 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4091 printf-like functions.
4092 (tiff_load): Add casts to remove these marks before passing them
4093 to system-supplied API.
4094
583f48b9
PE
4095 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4096
b25d760e
PE
4097 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4098 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4099 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4100 directly, rather than having caller test rule sign. This avoids
4101 some unnecessary tests.
4102 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4103 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4104 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4105
bc7b6697 4106 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4107 (xfont_open): Avoid unnecessary tests.
bc7b6697 4108
27ccc379
PE
4109 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4110
dcd5c89a
PE
4111 * composite.h, composite.c (composition_gstring_put_cache):
4112 Use EMACS_INT, not int, for length.
4113
b13a45c6
PE
4114 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4115 breaking out part of COMPOSITION_DECODE_RULE.
4116 (COMPOSITION_DECODE_RULE): Use it.
4117 * composite.c (get_composition_id): Remove unused local vars,
4118 by using the new macro.
4119
1e792e4d
PE
4120 * textprop.c (set_text_properties_1): Change while to do-while,
4121 since the condition is always true at first.
4122
dc6c6455 4123 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4124 (interval_deletion_adjustment): Return unsigned value.
4125 All uses changed.
dc6c6455 4126
aba7731a
PE
4127 * process.c (list_processes_1, create_pty, read_process_output):
4128 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4129 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4130 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4131 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4132 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4133
fdfc4bf3
PE
4134 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4135
fca8fe46 4136 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4137 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4138
06a0259a 4139 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4140 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4141 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4142
e7b9e80f
PE
4143 * print.c (print_error_message): Avoid int overflow.
4144
56201685
PE
4145 * font.c (font_list_entities): Redo for clarity,
4146 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4147
78834453 4148 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4149 (font_score): Avoid potential overflow in diff calculation.
78834453 4150
0bc0b309 4151 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4152 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4153
e610eaca
PE
4154 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4155
b895abce
PE
4156 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4157 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4158 can always succeed if overflow has undefined behavior.
4159
1f1d9321 4160 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4161 (wordify): Omit three unnecessary tests.
1f1d9321 4162
c59478bc
PE
4163 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4164 All callers changed. This avoids the need for an unused var.
4165
79b73827
PE
4166 * casefiddle.c (casify_region): Remove var that is set but not used.
4167
a4db5dfe
PE
4168 * dired.c (file_name_completion): Remove var that is set but not used.
4169
43aae36e
PE
4170 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4171
2a47c44d 4172 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4173 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4174
a37c69bf
PE
4175 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4176 Check for integer overflow on size calculations.
4177
328ab8e7
PE
4178 * buffer.c (Fprevious_overlay_change): Remove var that is set
4179 but not used.
4180
e5a2a5cb
PE
4181 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4182 Remove vars that are set but not used.
8d84a6eb 4183 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4184 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4185
a60e5f68
PE
4186 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4187
f661cb61 4188 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4189 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4190
f0397f5a
PE
4191 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4192 that are set but not used.
4193
8664db06 4194 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4195 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4196
6abdaa4a
PE
4197 * xselect.c (x_get_local_selection, x_handle_property_notify):
4198 Remove vars that are set but not used.
4199
0ce7538d 4200 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4201 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4202
9ae848fc
PE
4203 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4204 Remove var that is set but not used.
0b918413
PE
4205 (scroll_bar_windows_size): Now size_t, not int.
4206 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4207 Check for overflow.
9ae848fc 4208
a5a62657
PE
4209 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4210 (map_tty_color) [!defined MSDOS]: Likewise.
4211
5c5cdd39
PE
4212 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4213
66ebf983
PE
4214 * coding.c: Remove vars that are set but not used.
4215 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4216 All callers changed.
4217 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4218 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4219 (decode_coding_charset): Remove vars that are set but not used.
4220
1be4d761
PE
4221 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4222 that is set but not used.
4223
47553fa8
PE
4224 * print.c (print_object): Remove var that is set but not used.
4225
1f7196bf 4226 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4227 The gnulib version avoids calling malloc in the usual case,
4228 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4229 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4230 * filelock.c (current_lock_owner): Likewise.
4231 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4232 * sysdep.c: Include allocator.h, careadlinkat.h.
4233 (emacs_no_realloc_allocator): New static constant.
4234 (emacs_readlink): New function.
fdb61804
PE
4235 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4236 ../lib/careadlinkat.h.
d1fdcab7 4237
f84c17c7
SM
42382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4239
4240 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4241 first non-nil return value).
4242
ef3862ad
JD
42432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4244
4245 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4246 if not defined (Bug#8403).
4247
376a7006
JB
42482011-04-02 Juanma Barranquero <lekktu@gmail.com>
4249
4250 * xdisp.c (display_count_lines): Remove parameter `start',
4251 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4252 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4253 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4254 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4255 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4256 and thereabouts. All callers changed.
4257 (get_per_char_metric): Remove parameter `f', unused since
4258 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4259
6ca3801d
JM
42602011-04-02 Jim Meyering <meyering@redhat.com>
4261
4262 do not dereference NULL upon failed strdup
4263 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4264 (ns_get_family): Likewise.
4265
d8e2b5ba
JB
42662011-04-02 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4269
8c74fcbd
JD
42702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4271
4272 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4273 later (Bug#8403).
4274
7200d79c
SM
42752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4276
03408648 4277 Add lexical binding.
7200d79c 4278
03408648
SM
4279 * window.c (Ftemp_output_buffer_show): New fun.
4280 (Fsave_window_excursion):
4281 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4282
4283 * lread.c (lisp_file_lexically_bound_p): New function.
4284 (Fload): Bind Qlexical_binding.
4285 (readevalloop): Remove `evalfun' arg.
4286 Bind Qinternal_interpreter_environment.
4287 (Feval_buffer): Bind Qlexical_binding.
4288 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4289 Mark as dynamic.
4290 (syms_of_lread): Declare `lexical-binding'.
4291
4292 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4293
4294 * keyboard.c (eval_dyn): New fun.
4295 (menu_item_eval_property): Use it.
ca105506
SM
4296
4297 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4298
03408648
SM
4299 * fns.c (concat, mapcar1): Accept byte-code-functions.
4300
4301 * eval.c (Fsetq): Handle lexical vars.
4302 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4303 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4304 (FletX, Flet): Obey lexical binding.
4305 (Fcommandp): Handle closures.
4306 (Feval): New `lexical' arg.
4307 (eval_sub): New function extracted from Feval. Use it almost
4308 everywhere where Feval was used. Look up vars in lexical env.
4309 Handle closures.
4310 (Ffunctionp): Move from subr.el.
4311 (Ffuncall): Handle closures.
4312 (apply_lambda): Remove `eval_flags'.
4313 (funcall_lambda): Handle closures and new byte-code-functions.
4314 (Fspecial_variable_p): New function.
4315 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4316 but without exporting it to Lisp.
23aba0ea 4317
23aba0ea 4318 * doc.c (Fdocumentation, store_function_docstring):
03408648 4319 * data.c (Finteractive_form): Handle closures.
23aba0ea 4320
03408648
SM
4321 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4322 interactive spec.
ba83908c 4323
04f2d78b
CB
4324 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4325 New byte-codes.
03408648
SM
4326 (exec_byte_code): New function extracted from Fbyte_code to handle new
4327 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4328
03408648 4329 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4330
03408648 4331 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4332
e2abce01
JB
43332011-03-31 Juanma Barranquero <lekktu@gmail.com>
4334
4335 * xdisp.c (redisplay_internal): Fix prototype.
4336
63696a73 43372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4338
63696a73 4339 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4340 (try_scrolling): Use it when setting scroll_limit.
4341 Limit scrolling to 100 screen lines.
63696a73
EZ
4342 (redisplay_window): Even when falling back on "recentering",
4343 position point in the window according to scroll-conservatively,
4344 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4345
4346 (try_scrolling): When point is above the window, allow searching
4347 as far as scroll_max, or one screenful, to compute vertical
4348 distance from PT to the scroll margin position. This prevents
4349 try_scrolling from unnecessarily failing when
4350 scroll-conservatively is set to a value slightly larger than the
4351 window height. Clean up the case of PT below the margin at bottom
4352 of window: scroll_max can no longer be INT_MAX. When aggressive
4353 scrolling is in use, don't let point enter the opposite scroll
4354 margin as result of the scroll.
4355 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4356 threshold of 100 lines for never-recentering scrolling.
4357
e4cc2dfc
JB
43582011-03-31 Juanma Barranquero <lekktu@gmail.com>
4359
4360 * dispextern.h (move_it_by_lines):
4361 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4362 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4363 (message_log_check_duplicate): Remove parameters `prev_bol' and
4364 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4365 (redisplay_internal): Remove parameter `preserve_echo_area',
4366 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4367
4368 * indent.c (Fvertical_motion):
4369 * window.c (window_scroll_pixel_based, Frecenter):
4370 Don't pass `need_y_p' to `move_it_by_lines'.
4371
1c470562
SM
43722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4373
44f230aa
SM
4374 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4375 steal a few bits to be more compact.
4376 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4377 Remove unneeded casts.
4378
1c470562
SM
4379 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4380
888adce9
ZK
43812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4382
4383 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4384 binding" message (bug#7967).
4385
f838ed7b
PE
43862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4387
77861b95
PE
4388 Fix more problems found by GCC 4.6.0's static checks.
4389
de6dbc14
PE
4390 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4391 Remove unused local var.
4392
f838ed7b
PE
4393 * editfns.c (Fmessage_box): Remove unused local var.
4394
792c7b2b
PE
4395 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4396 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4397 Omit unused local vars.
c499e557 4398 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4399 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4400 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4401 Omit unused local var.
4402
ba0165e1
PE
4403 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4404 Don't assume string length fits in int.
32ad8845 4405 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4406 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4407
3c59b4c9
PE
4408 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4409 instead of alloca (Bug#8344).
4410
a3eed478 4411 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4412 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4413
eb4d412d
PE
4414 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4415
1658b401
PE
4416 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4417 concerns.
4418
4419 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4420
4421 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4422
9a2c6e05
PE
4423 * keyboard.c (syms_of_keyboard): Use the same style as later
4424 in this function when indexing through an array. This also
4425 works around GCC bug 48267.
4426
03d0a109
PE
4427 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4428
44f730c8
PE
4429 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4430
fe75f926
PE
4431 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4432 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4433
ffa8c828
PE
4434 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4435 This avoids undefined behavior on integer overflow, and is a bit
4436 more convenient anyway since it is compared to a size_t variable.
4437
c5101a77
PE
4438 Variadic C functions now count arguments with size_t, not int.
4439 This avoids an unnecessary limitation on 64-bit machines, which
4440 caused (substring ...) to crash on large vectors (Bug#8344).
4441 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4442 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4443 All variadic functions and their callers changed accordingly.
c5101a77
PE
4444 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4445 * data.c (arith_driver, float_arith_driver): Likewise.
4446 * editfns.c (general_insert_function): Likewise.
4447 * eval.c (struct backtrace.nargs, interactive_p)
4448 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4449 (funcall_lambda, mark_backtrace): Likewise.
4450 * fns.c (concat): Likewise.
4451 * frame.c (x_set_frame_parameters): Likewise.
4452 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4453 0 if not found, not -1. All callers changed.
4454
dd3f25f7
PE
4455 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4456 (stack_copy_size): Now size_t, not int.
4457 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4458
461c2ab9
JB
44592011-03-28 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4462 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4463 All callers changed.
4464
4465 * lisp.h (multibyte_char_to_unibyte):
4466 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4467 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4468 * character.h (CHAR_TO_BYTE8):
4469 * cmds.c (internal_self_insert):
4470 * editfns.c (general_insert_function):
4471 * keymap.c (push_key_description):
4472 * search.c (Freplace_match):
4473 * xdisp.c (message_dolog, set_message_1): All callers changed.
4474
f6d62986
SM
44752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4476
4477 * keyboard.c (safe_run_hook_funcall): New function.
4478 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4479 don't set the hook to nil, but remove the offending function instead.
4480 (Qcommand_hook_internal): Remove, unused.
4481 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4482 Vcommand_hook_internal.
4483
4484 * eval.c (enum run_hooks_condition): Remove.
4485 (funcall_nil, funcall_not): New functions.
4486 (run_hook_with_args): Call each function through a `funcall' argument.
4487 Remove `cond' argument, now redundant.
4488 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4489 (Frun_hook_with_args_until_failure): Adjust accordingly.
4490 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4491
1db5b1ad
JB
44922011-03-28 Juanma Barranquero <lekktu@gmail.com>
4493
4494 * dispextern.h (string_buffer_position): Remove declaration.
4495
4496 * print.c (strout): Remove parameter `multibyte', unused since
4497 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4498
4499 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4500 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4501 All callers changed.
4502
4503 * w32.c (_wsa_errlist): Use braces for struct initializers.
4504
4505 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4506 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4507 All callers changed.
4508 (string_buffer_position): Likewise. Also, make static (it's never
4509 used outside xdisp.c).
4510 (cursor_row_p): Remove parameter `w', unused since
4511 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4512 (decode_mode_spec): Remove parameter `precision', introduced during
4513 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4514 All callers changed.
4515
5ffb62aa
JD
45162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4517
4518 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4519
461c2ab9 45202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4521
4522 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4523 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4524 (ns_update_auto_hide_menu_bar): New functions.
4525 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4526 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4527 ns_constrain_all_frames.
4528 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4529 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4530
5c380ffb
JD
45312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4532
4533 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4534
9af30bdf
GM
45352011-03-27 Glenn Morris <rgm@gnu.org>
4536
4537 * syssignal.h: Replace RETSIGTYPE with void.
4538 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4539 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4540 Replace SIGTYPE with void everywhere.
4541 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4542 * s/template.h (SIGTYPE): Remove commented out definition.
4543
e2abce01
JB
45442011-03-26 Eli Zaretskii <eliz@gnu.org>
4545
4546 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4547 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4548
f868cd8a
JB
45492011-03-26 Juanma Barranquero <lekktu@gmail.com>
4550
59eb0929
JB
4551 * w32.c (read_unc_volume): Use parameter `henum', instead of
4552 global variable `wget_enum_handle'.
4553
4554 * keymap.c (describe_vector): Remove parameters `indices' and
4555 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4556 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4557
f868cd8a
JB
4558 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4559
4560 * keyboard.c (timer_check): Remove parameter `do_it_now',
4561 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4562 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4563 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4564
4565 * keyboard.c (read_char):
4566 * w32menu.c (w32_menu_display_help):
4567 * xmenu.c (show_help_event, menu_help_callback):
4568 Adjust calls to `show_help_echo'.
4569
4570 * gtkutil.c (xg_maybe_add_timer):
4571 * keyboard.c (readable_events):
4572 * process.c (wait_reading_process_output):
4573 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4574
4575 * insdel.c (adjust_markers_gap_motion):
4576 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4577 (gap_left, gap_right): Don't call it.
4578
2ecf6fdb
CY
45792011-03-25 Chong Yidong <cyd@stupidchicken.com>
4580
4581 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4582 incurred during fontification.
4583
6b1f9ba4
JB
45842011-03-25 Juanma Barranquero <lekktu@gmail.com>
4585
4586 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4587 (DEFVAR_PER_BUFFER): Don't pass it.
4588
4589 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4590 (scrolling_window): Don't pass it.
4591
0f4a96b5
JB
45922011-03-25 Juanma Barranquero <lekktu@gmail.com>
4593
4594 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4595
4596 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4597 and `suffix'.
4598 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4599 of variables specific to SELinux and computation of `encoded_absname'.
4600
4601 * image.c (XPutPixel): Remove unused variable `height'.
4602
4603 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4604
4605 * unexw32.c (get_section_info): Remove unused variable `section'.
4606
4607 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4608 (system_process_attributes): Remove unused variable `sess'.
4609 (sys_read): Remove unused variable `err'.
4610
4611 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4612 (w32_wnd_proc): Remove unused variable `isdead'.
4613 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4614 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4615 (x_create_tip_frame): Remove unused variable `tem'.
4616
4617 * w32inevt.c (w32_console_read_socket):
4618 Remove unused variable `no_events'.
4619
4620 * w32term.c (x_draw_composite_glyph_string_foreground):
4621 Remove unused variable `width'.
4622
1149507c
JB
46232011-03-24 Juanma Barranquero <lekktu@gmail.com>
4624
4625 * w32term.c (x_set_glyph_string_clipping):
4626 Don't pass uninitialized region to CombineRgn.
4627
9c88f339
JB
46282011-03-23 Juanma Barranquero <lekktu@gmail.com>
4629
4630 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4631 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4632 (Fx_close_connection): Remove unused variable `i'.
4633
4634 * w32font.c (w32font_draw): Return number of glyphs.
4635 (w32font_open_internal): Remove unused variable `i'.
4636 (w32font_driver): Add missing initializer.
4637
4638 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4639 (fill_in_menu): Remove unused variable `items_added'.
4640
4641 * w32term.c (last_mouse_press_frame): Remove static global variable.
4642 (w32_clip_to_row): Remove unused variable `f'.
4643 (x_delete_terminal): Remove unused variable `i'.
4644
4645 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4646 (NOTHING): Remove unused static global variable.
4647 (uniscribe_check_otf): Remove unused variable `table'.
4648 (uniscribe_font_driver): Add missing initializers.
4649
dee091a3
JD
46502011-03-23 Julien Danjou <julien@danjou.info>
4651
4652 * term.c (Fsuspend_tty, Fresume_tty):
4653 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4654 * window.c (temp_output_buffer_show):
4655 * insdel.c (signal_before_change):
4656 * frame.c (Fhandle_switch_frame):
4657 * fileio.c (Fdo_auto_save):
4658 * emacs.c (Fkill_emacs):
4659 * editfns.c (save_excursion_restore):
4660 * cmds.c (internal_self_insert):
4661 * callint.c (Fcall_interactively):
4662 * buffer.c (Fkill_all_local_variables):
4663 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4664 Use Frun_hooks.
0f4a96b5 4665 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4666 unconditionnaly since it does the check itself.
4667
2c520ab5 46682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4669
c9c49752
PE
4670 Fix more problems found by GCC 4.5.2's static checks.
4671
8abc3f12
PE
4672 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4673 the first time through the loop, since we know p0 < p1 then.
4674 This also avoids a gcc -Wstrict-overflow warning.
4675
a2d26660
PE
4676 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4677 leading to a memory leak, possible in functions like
4678 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4679 of objects (Bug#8318).
a2d26660 4680
916c72e9
PE
4681 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4682 that could (at least in theory) be that large.
4683
19ab8a18
PE
4684 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4685 This is less likely to overflow, and avoids undefined behavior if
4686 overflow does occur. All callers changed. Use strtoul to scan
4687 for the unsigned long integer.
b7cbbd6f
PE
4688 (pint2hrstr): Simplify and tune code slightly.
4689 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4690
f0641eff
PE
4691 * scroll.c (do_scrolling): Work around GCC bug 48228.
4692 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4693
7f650bb9
PE
4694 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4695 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4696 (validate_x_resource_name): Simplify count usage.
4697 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4698
37dd57d1
PE
4699 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4700 fail (Bug#8306).
81e56e61 4701
699979fc 4702 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4703
401bf9b4
PE
4704 * process.c (Fmake_network_process): Use socklen_t, not int,
4705 where POSIX says socklen_t is required in portable programs.
4706 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4707 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4708 (Fmake_network_process, server_accept_connection):
4709 (wait_reading_process_output, read_process_output):
4710 Likewise.
4711
b93aacde
PE
4712 * process.c: Rename or move locals to avoid shadowing.
4713 (list_processes_1, Fmake_network_process):
4714 (read_process_output_error_handler, exec_sentinel_error_handler):
4715 Rename or move locals.
4dc343ee 4716 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4717 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4718 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4719 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4720 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4721
af8a867c 4722 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4723 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4724 Include tparam.h instead, since it declares them.
af8a867c
PE
4725 * cm.h (PC): Remove extern decl; tparam.h now does this.
4726 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4727 * terminfo.c: Include tparam.h, to check interfaces.
4728 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4729 (tparam): Adjust signature to match interface in tparam.h;
4730 this removes some undefined behavior. Check that outstring and len
4731 are zero, which they always are with Emacs.
4732 * tparam.h (PC, BC, UP): New extern decls.
4733
0248044d 4734 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4735 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4736
8ff096c1 4737 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4738 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4739 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4740 (ftfont_list): Remove unused local.
49eaafba
PE
4741 (get_adstyle_property, ftfont_pattern_entity):
4742 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4743 Rename locals to avoid shadowing.
8ff096c1 4744
e2be39f6
PE
4745 * xfont.c (xfont_list_family): Mark var as initialized.
4746
c9735e30
PE
4747 * xml.c (make_dom): Now static.
4748
8f5201ae
PE
4749 * composite.c (composition_compute_stop_pos): Rename local to
4750 avoid shadowing.
b246f932
PE
4751 (composition_reseat_it): Remove unused locals.
4752 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4753 (composition_update_it): Mark var as initialized.
11b61122
PE
4754 (find_automatic_composition): Mark vars as initialized,
4755 with a FIXME (Bug#8290).
8f5201ae 4756
760fbc2c
PE
4757 character.h: Rename locals to avoid shadowing.
4758 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4759 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4760 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4761 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4762 to avoid shadowing.
4763
ff08eb85
PE
4764 * textprop.c (property_change_between_p): Remove; unused.
4765
fc7bf025
PE
4766 * intervals.c (interval_start_pos): Now static.
4767
235d7abc
PE
4768 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4769
44f230aa
SM
4770 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4771 Rename locals to avoid shadowing.
3e7d6594 4772
50060332
PE
4773 * sound.c (wav_play, au_play, Fplay_sound_internal):
4774 Fix pointer signedness.
d01f234b 4775 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4776 (wav_play): Initialize a variable to 0, to prevent undefined
4777 behavior (Bug#8278).
50060332 4778
c4fc4e30
PE
4779 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4780
918436ed
PE
4781 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4782
c939f91b
PE
4783 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4784 clobbering (Bug#8298).
b9c7f648
PE
4785 * sysdep.c (sys_subshell): Likewise.
4786 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4787
6bd8c144
PE
4788 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4789 This should get cleaned up, so that child_setup has the
4790 same signature on all platforms.
4791
7710357c 4792 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4793 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4794
c59da222
CY
47952011-03-22 Chong Yidong <cyd@stupidchicken.com>
4796
4797 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4798 not to be necessary, and produces flickering.
4799
66b87493
GM
48002011-03-20 Glenn Morris <rgm@gnu.org>
4801
4802 * config.in: Remove file.
4803
45b6f6d5
JB
48042011-03-20 Juanma Barranquero <lekktu@gmail.com>
4805
4806 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4807 are now in src/globals.h.
4808 (syms_of_minibuf): Remove spurious & from previous change.
4809
3ec03f7e
LL
48102011-03-20 Leo <sdl.web@gmail.com>
4811
4812 * minibuf.c (completing-read-function): New variable.
4813 (completing-read-default): Rename from completing-read.
4814 (completing-read): Call completing-read-function.
4815
b14e3e21
CY
48162011-03-19 Juanma Barranquero <lekktu@gmail.com>
4817
4818 * xfaces.c (Fx_load_color_file):
4819 Read color file from absolute filename (bug#8250).
4820
f2b726e6
JB
48212011-03-19 Juanma Barranquero <lekktu@gmail.com>
4822
4823 * makefile.w32-in: Update dependencies.
4824
09f6ff02
EZ
48252011-03-17 Eli Zaretskii <eliz@gnu.org>
4826
4827 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4828
29a6015a
PE
48292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4830
a3a6c54e
PE
4831 Fix more problems found by GCC 4.5.2's static checks.
4832
b766f867
PE
4833 * process.c (make_serial_process_unwind, send_process_trap):
4834 (sigchld_handler): Now static.
4835
be02381c
PE
4836 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4837 That way, the code declares only the vars that it needs.
4838 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4839 * s/cygwin.h (PTY_ITERATION): Likewise.
4840 * s/darwin.h (PTY_ITERATION): Likewise.
4841 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4842
57048744
PE
4843 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4844 * process.c (allocate_pty): Don't declare stb unless it's needed.
4845
7914961c 4846 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4847 (CONSTANTLIM): Remove; unused.
4848 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4849 Define only if needed.
7914961c 4850
b3967b18
PE
4851 * unexelf.c (unexec): Name an expression,
4852 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4853 Use a different way to cause a compilation error if anyone uses
4854 n rather than nn, a way that does not involve shadowing.
73366a00 4855 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4856
29a6015a
PE
4857 * deps.mk (unexalpha.o): Remove; unused.
4858
43cfc33e 4859 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4860 * unexec.h: New file.
ce701a33
PE
4861 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4862 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4863 Depend on unexec.h.
4864 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4865 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4866 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4867 Change as necessary to match prototype in unexec.h.
ce701a33 4868
01f44d5a
PE
4869 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4870 shadowing.
4f63c6bb 4871 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4872
a6670b0b
PE
4873 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4874 Rename locals to avoid shadowing.
4875
cef2010d 4876 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4877 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4878
d4d7173a
PE
4879 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4880
f08b802a
PE
4881 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4882 warning when compiling print.c.
4883
3ddb0639
PE
4884 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4885 instead of using an uninitialized var.
5ad03b97 4886 (font_sort_entities): Mark var as initialized.
3ddb0639 4887
170a2692
PE
4888 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4889
e663c700
PE
4890 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4891 pointers to constants.
89bc529a 4892 (font_parse_fcname): Remove unused vars.
7b81e2d0 4893 (font_delete_unmatched): Now static.
ea838e10 4894 (font_get_spec): Remove; unused.
13a547c6
PE
4895 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4896 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4897 Rename or move locals to avoid shadowing.
e663c700 4898
2a80c887 4899 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4900 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4901
1384fa33 4902 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4903 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4904
8b2c52e9
PE
4905 * alloc.c (mark_backtrace): Move decl from here ...
4906 * lisp.h: ... to here, so that it can be checked.
4907
475545b5 4908 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4909 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4910 (lisp_indirect_variable): Name an expression,
4911 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4912 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4913
b1349114 4914 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4915 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4916 Use const pointer when appropriate.
b1349114 4917
a2928364
PE
4918 * lisp.h (get_system_name, get_operating_system_release):
4919 Move decls here, to check interfaces.
4920 * process.c (get_operating_system_release): Move decl to lisp.h.
4921 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4922 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4923 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4924 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4925 (Fformat_time_string, Fencode_time, Finsert_char):
4926 (Ftranslate_region_internal, Fformat):
4927 Rename or remove local vars to avoid shadowing.
9710023e 4928 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4929
a415e694
PE
4930 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4931 avoid shadowing.
4932
8ef4622d
PE
4933 * lisp.h (eassert): Check that the argument compiles, even if
4934 ENABLE_CHECKING is not defined.
4935
946f9a5b
PE
4936 * data.c (Findirect_variable): Name an expression, to avoid
4937 gcc -Wbad-function-cast warning.
112396d6 4938 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4939 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4940 (Fmake_variable_buffer_local, Fmake_local_variable):
4941 Mark variables as initialized.
52746918 4942 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4943
e5aab7e7 4944 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4945 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4946 Rename locals to avoid shadowing.
dff45157
PE
4947 (mark_stack): Move local variables into the #ifdef region where
4948 they're used.
7bc26fdb
PE
4949 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4950 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4951 needed otherwise.
4952 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4953 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4954 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4955
e5aab7e7
PE
4956 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4957 avoids undefined behavior in theory.
4958
4da60324
PE
4959 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4960
88043301
PE
4961 Use functions, not macros, for up- and down-casing (Bug#8254).
4962 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4963 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4964 to use the following functions instead of these macros.
4965 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4966 EMACS_INT, since callers assume the returned value fits in int.
4967 (upcase1): Likewise, for UPCASE_TABLE.
4968 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4969 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4970 the race-condition problem in the old DOWNCASE.
88043301 4971
19ed5445
PE
4972 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4973 Rename locals to avoid shadowing.
4974 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4975 (regex_compile, re_search_2, re_match_2_internal):
4976 Remove unused local vars.
952db0d7
PE
4977 (FREE_VAR): Rewrite so as not to use empty "else",
4978 which gcc can warn about.
da053e48 4979 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4980 (RETALLOC_IF): Define only if needed.
4981 (WORDCHAR_P): Likewise. This one is never needed, but is used
4982 only in a comment talking about a compiler bug, so put inside
4983 the #if 0 of that comment.
4984 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4985 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4986 Remove; unused.
19ed5445 4987
1f3561e4 4988 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4989 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4990 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4991
ded6f8f7
PE
4992 * search.c (simple_search): Remove unused var.
4993
dbd37a95
PE
4994 * dired.c (compile_pattern): Move decl from here ...
4995 * lisp.h: ... to here, so that it can be checked.
4996 (struct re_registers): New forward decl.
4997
7e47afad
PE
4998 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4999
85f24f61
PE
5000 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5001 All uses changed.
5002 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5003 Rename locals to avoid shadowing.
5671df8f 5004 (Fvertical_motion): Mark locals as initialized.
85f24f61 5005
181aa2be 5006 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5007 (casify_region): Mark local as initialized.
181aa2be 5008
930d429c
PE
5009 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5010
7082eac6
PE
5011 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5012 New macros, so that the caller can use some names other than
5013 gcpro1, gcpro2, etc.
5014 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5015 of the new macros.
5016 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5017 argument, for consistency with GCPRO2_VAR, etc: it is now the
5018 prefix of the variable, not the variable itself. All uses
5019 changed.
38b2c076
PE
5020 * dired.c (directory_files_internal, file_name_completion):
5021 Rename locals to avoid shadowing.
5022
15206ed9
PE
5023 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5024 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5025 dired.c's scmp function, had undefined behavior.
5026 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5027 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5028 * buffer.h: ... to here, because these macros use current_buffer,
5029 and the new implementation with inline functions needs to have
5030 current_buffer in scope now, rather than later when the macros
5031 are used.
5032 (downcase, upcase1): New static inline functions.
5033 (DOWNCASE, UPCASE1): Reimplement using these functions.
5034 This avoids undefined behavior in expressions like
5035 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5036 from race conditions in accessing the global variables
5037 case_temp1 and case_temp2.
5038 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5039 * lisp.h (case_temp1, case_temp2): Remove their decls.
5040 * character.h (ASCII_CHAR_P): Move from here ...
5041 * lisp.h: ... to here, so that the inline functions mentioned
5042 above can use them.
5043
4a6bea26
PE
5044 * dired.c (directory_files_internal_unwind): Now static.
5045
f14b7e14
PE
5046 * fileio.c (file_name_as_directory, directory_file_name):
5047 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5048 Now static.
2893f146
PE
5049 (file_name_as_directory): Use const pointers when appropriate.
5050 (Fexpand_file_name): Likewise. In particular, newdir might
5051 point at constant storage, so make it a const pointer.
fd4ead52 5052 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5053 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5054 signedness issues.
f839df0c
PE
5055 (Fset_file_times, Finsert_file_contents, auto_save_error):
5056 Rename locals to avoid shadowing.
f14b7e14 5057
5716756e 5058 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5059 (Ftry_completion, Fall_completions): Rename or remove locals
5060 to avoid shadowing.
5716756e 5061
b4c3046a
PE
5062 * marker.c (bytepos_to_charpos): Remove; unused.
5063
b45db522
PE
5064 * lisp.h (verify_bytepos, count_markers): New decls,
5065 so that gcc does not warn that these functions aren't declared.
5066
85876d07
PE
5067 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5068 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5069 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5070 (copy_text): Remove unused local var.
85876d07 5071
03d78a21 5072 * filelock.c (within_one_second): Now static.
b3dd38ab 5073 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5074
5df8f01b
PE
5075 * buffer.c (fix_overlays_before): Mark locals as initialized.
5076 (fix_start_end_in_overlays): Likewise. This function should be
5077 simplified by using pointers-to-pointers, but that's a different
5078 matter.
b1d876f1 5079 (switch_to_buffer_1): Now static.
8f54f30a
PE
5080 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5081 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5082
a70072c9 5083 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5084 Fix pointer signedness issue.
edced198
PE
5085 (sys_subshell): Mark local as volatile if checking for lint,
5086 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5087 (MAXPATHLEN): Define only if needed.
a70072c9 5088
a0977c44
PE
5089 * process.c (serial_open, serial_configure): Move decls from here ...
5090 * systty.h: ... to here, so that they can be checked.
5091
a884fdcc
PE
5092 * fns.c (get_random, seed_random): Move extern decls from here ...
5093 * lisp.h: ... to here, so that they can be checked.
5094
604efe86 5095 * sysdep.c (reset_io): Now static.
b8950c94 5096 (wait_for_termination_signal): Remove; unused.
604efe86 5097
38fc62d9
PE
5098 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5099 (copy_keymap_item, append_key, push_text_char_description):
5100 Now static.
1004a21a 5101 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5102 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5103 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5104 (describe_map_tree):
5105 Rename locals to avoid shadowing.
38fc62d9 5106
2f2650da
PE
5107 * keyboard.c: Declare functions static if they are not used elsewhere.
5108 (echo_char, echo_dash, cmd_error, top_level_2):
5109 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5110 (read_char, kbd_buffer_get_event, make_lispy_position):
5111 (make_lispy_event, make_lispy_movement, apply_modifiers):
5112 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5113 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5114 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5115 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5116 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5117
a053e86c 5118 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5119 (mark_kboards): Move decl here ...
5120 * alloc.c (mark_kboards): ... from here.
a053e86c 5121
4752793e
PE
5122 * lisp.h (force_auto_save_soon): New decl.
5123
74f10ca7 5124 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5125 (DEFINE_DUMMY_FUNCTION): New macro.
5126 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5127 Use it.
c03cd23f
PE
5128 (main): Add casts to avoid warnings
5129 if GCC considers string literals to be constants.
74f10ca7 5130
022e70d4
PE
5131 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5132
59d6fe83
PE
5133 * dbusbind.c: Pointer signedness fixes.
5134 (xd_signature, xd_append_arg, xd_initialize):
5135 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5136 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5137 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5138 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5139
78320123
PE
5140 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5141 if GCC considers string literals to be constants.
49cebcca 5142 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5143
35ac2a97
SM
51442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5145
fb103ca9
SM
5146 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5147 (print_preprocess, print_object): New macro to fix last change.
5148
35ac2a97
SM
5149 * print.c (print_preprocess): Don't forget font objects.
5150
62973b41
JB
51512011-03-16 Juanma Barranquero <lekktu@gmail.com>
5152
5153 * emacs.c (USAGE3): Doc fixes.
5154
0e48bb22
AS
51552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5156
5157 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5158 structure.
5159
7684e57b
JB
51602011-03-14 Juanma Barranquero <lekktu@gmail.com>
5161
5162 * lisp.h (VWindow_system, Qfile_name_history):
5163 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5164 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5165 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5166
5167 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5168 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5169
5170 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5171 * w32console.c (detect_input_pending, read_input_pending)
5172 (encode_terminal_code):
5173 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5174 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5175 (w32_system_caret_y, Qfile_name_history):
5176 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5177 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5178 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5179 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5180 * w32proc.c (Qlocal, report_file_error):
5181 * w32term.c (Vwindow_system, updating_frame):
5182 * w32uniscribe.c (initialized, uniscribe_font_driver):
5183 Remove unneeded extern declarations.
5184
2aa46d6c
CY
51852011-03-14 Chong Yidong <cyd@stupidchicken.com>
5186
c96bbc66 5187 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5188
cffc6f3b
CY
51892011-03-13 Chong Yidong <cyd@stupidchicken.com>
5190
5191 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5192 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5193 These macros can no longer be used for assignment.
5194
44f230aa
SM
5195 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5196 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5197 (record_buffer_markers, fetch_buffer_markers): New functions for
5198 recording and fetching special buffer markers.
5199 (set_buffer_internal_1, set_buffer_temp): Use them.
5200
5201 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5202
5203 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5204
5205 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5206 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5207
5208 * xdisp.c (hscroll_window_tree):
5209 (reconsider_clip_changes): Use PT instead of BUF_PT.
5210
d251f04b
EZ
52112011-03-13 Eli Zaretskii <eliz@gnu.org>
5212
5213 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5214 $(EMACS_ROOT)/lib/intprops.h.
5215
f0c77cd1
PE
52162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5217
3eca4629
PE
5218 Fix more problems found by GCC 4.5.2's static checks.
5219
7c86ee98
PE
5220 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5221 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5222 (xg_free_frame_widgets): Make it clear that a local variable is
5223 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5224 (gdk_window_get_screen): Make it clear that this macro is needed
5225 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5226 (int_gtk_range_get_value): New function, which avoids a diagnostic
5227 from gcc -Wbad-function-cast.
5228 (xg_set_toolkit_scroll_bar_thumb): Use it.
5229 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5230 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5231 (get_utf8_string, xg_get_file_with_chooser):
5232 Rename locals to avoid shadowing.
5233 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5234
41729b81
PE
5235 * xgselect.c (xg_select): Remove unused var.
5236
f0c77cd1
PE
5237 * image.c (four_corners_best): Mark locals as initialized.
5238 (gif_load): Initialize transparent_p to zero (Bug#8238).
5239 Mark another local as initialized.
ec6cf4c6 5240 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5241
ce0ad53d 5242 * image.c (clear_image_cache): Now static.
d5d5a617 5243 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5244 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5245 (x_edge_detection): Remove unnecessary cast that
5246 gcc -Wbad-function-cast diagnoses.
2037898d 5247 (gif_load): Fix pointer signedness.
6ae141d6
PE
5248 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5249 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5250
33383987 52512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5252
d32df629
PE
5253 Improve quality of tests for time stamp overflow.
5254 For example, without this patch (encode-time 0 0 0 1 1
5255 1152921504606846976) returns the obviously-bogus value (-948597
5256 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5257 reports time overflow. See
5258 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5259 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5260 * editfns.c: Include limits.h and intprops.h.
5261 (TIME_T_MIN, TIME_T_MAX): New macros.
5262 (time_overflow): Move earlier, to before first use.
5263 (hi_time, lo_time): New functions, for an accurate test for
5264 out-of-range times.
5265 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5266 (Fget_internal_run_time): Don't assume time_t fits in int.
5267 (make_time): Use list2 instead of Fcons twice.
5268 (Fdecode_time): More accurate test for out-of-range times.
5269 (check_tm_member): New function.
5270 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5271 (lisp_time_argument): Don't rely on undefined left-shift and
5272 right-shift behavior when checking for time stamp overflow.
8be6f318 5273
fe31d94c
PE
5274 * editfns.c (time_overflow): New function, refactoring common code.
5275 (Fformat_time_string, Fdecode_time, Fencode_time):
5276 (Fcurrent_time_string): Use it.
5277
8be6f318
PE
5278 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5279 * dired.c (make_time): Move to ...
5280 * editfns.c (make_time): ... here.
5281 * systime.h: Note the move.
5282
09d9db2c 52832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5284
126bc0dc
YM
5285 * fringe.c (update_window_fringes): Remove unused variables.
5286
c47cbdfd
YM
5287 * unexmacosx.c (copy_data_segment): Also copy __got section.
5288 (Bug#8223)
5289
7ac80be9
EZ
52902011-03-12 Eli Zaretskii <eliz@gnu.org>
5291
c96bbc66 5292 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5293 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5294 Constify `char *' arguments and their references according to
5295 prototypes in tparam.h.
5296
ecb0f94d 5297 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5298
7ac80be9
EZ
5299 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5300 Adapt all references accordingly.
5301
5302 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5303
ef1fd07e
TT
53042011-03-11 Tom Tromey <tromey@redhat.com>
5305
5306 * buffer.c (syms_of_buffer): Remove obsolete comment.
5307
7ef4b50c
EZ
53082011-03-11 Eli Zaretskii <eliz@gnu.org>
5309
5310 * termhooks.h (encode_terminal_code): Declare prototype.
5311
5312 * msdos.c (encode_terminal_code): Don't declare prototype.
5313
5314 * term.c (encode_terminal_code): Now external again, used by
5315 w32console.c and msdos.c.
5316
44f230aa
SM
5317 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5318 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5319
4b1ec863 53202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5321
1714f52b 5322 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5323
4b1ec863
PE
5324 * fringe.c (update_window_fringes): Mark locals as initialized
5325 (Bug#8227).
5326 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5327
524c7aa6
PE
5328 * alloc.c (mark_fringe_data): Move decl from here ...
5329 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5330 to check its interface.
5331 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5332
a5c0af81 5333 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5334 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5335 (fontset_font): Mark local as initialized.
a9a06e0b 5336 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5337
b4716021
PE
5338 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5339
811e9bac 5340 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5341 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5342 (x_own_selection, Fx_disown_selection_internal): Rename locals
5343 to avoid shadowing.
5344 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5345
7e3ab302
PE
5346 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5347 so that the caller can use some name other than gcpro1.
5348 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5349 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5350 (Fx_backspace_delete_keys_p):
5351 Use them to avoid shadowing, and rename vars to avoid shadowing.
5352 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5353 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5354 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5355 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5356 Remove unused locals.
7e3ab302
PE
5357 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5358 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5359 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5360 macros.
f78faa98 5361
e2b13473
PE
5362 * xterm.h (x_mouse_leave): New decl.
5363
77f23912
PE
5364 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5365 Remove unused functions.
cdf4ba58
PE
5366 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5367 (x_calc_absolute_position): Now static.
7411c686 5368 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5369 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5370 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5371 unless they are used.
38d0b34a
PE
5372 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5373 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5374 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5375 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5376 (x_error_catcher, x_connection_closed, x_error_handler):
5377 (x_error_quitter, xembed_send_message, x_iconify_frame):
5378 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5379 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5380 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5381
44f230aa
SM
5382 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5383 Rename or move locals to avoid shadowing.
6b463e58 5384 (tty_defined_color, merge_face_heights): Now static.
5967d051 5385 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5386 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5387 does not deduce is never used uninitialized.
73719eba
PE
5388 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5389 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5390
426994c3 5391 * terminal.c (store_terminal_param): Now static.
5489860b 5392
032f1620 5393 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5394 (set_frame_menubar): Remove unused local.
d4323972 5395 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5396 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5397 since they might point to immutable storage.
281585b0
PE
5398 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5399 since it's unused otherwise.
032f1620 5400
367c19e5 5401 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5402 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5403 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5404 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5405 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5406 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5407 does not deduce are never used uninitialized.
70739cbe 5408
07b48fa9
PE
5409 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5410
8868a238 5411 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5412 * window.c (window_loop, size_window):
5413 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5414
7e5cf297 5415 * window.c (display_buffer): Now static.
d6550a9f
PE
5416 (size_window): Mark variables that gcc -Wuninitialized
5417 does not deduce are never used uninitialized.
a586633d
PE
5418 * window.h (check_all_windows): New decl, to forestall
5419 gcc -Wmissing-prototypes diagnostic.
5b555da1 5420 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5421
f6095868
PE
5422 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5423 shadowing.
5424 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5425 Include <limits.h>.
5426 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5427 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5428 (load_charset_map): Mark variables that gcc -Wuninitialized
5429 does not deduce are never used uninitialized.
53df7c11 5430 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5431
f38b440c
PE
5432 * coding.c (coding_set_source, coding_set_destination):
5433 Use "else { /* comment */ }" rather than "else /* comment */;"
5434 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5435 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5436 a block, when the outer 'i' will do.
5437 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5438 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5439 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5440 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5441 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5442 Rename locals to avoid shadowing.
5443 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5444 * coding.c (emacs_mule_char, encode_invocation_designation):
5445 Now static, since they're not used elsewhere.
413bb2db 5446 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5447 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5448 (decode_coding_emacs_mule): Mark variables that gcc
5449 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5450 (detect_coding_iso_2022): Initialize a local variable that might
5451 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5452 this initialization is needed. (Bug#8211)
5f58e762
PE
5453 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5454 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5455 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5456 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5457 Remove unused macros.
f38b440c 5458
232b38b9 5459 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5460 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5461 * character.c (string_count_byte8): Likewise.
232b38b9 5462
fb90da1b
PE
5463 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5464 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5465
fb93dbc2
PE
5466 * chartab.c (copy_sub_char_table): Now static, since it's not used
5467 elsewhere.
5c156ace
PE
5468 (sub_char_table_ref_and_range, char_table_ref_and_range):
5469 Rename locals to avoid shadowing.
bbcd0949 5470 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5471
7d3b3862 5472 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5473 (BIDI_BOB): Remove unused macro.
7d3b3862 5474
6be7d3da
PE
5475 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5476 deduce are never used uninitialized.
c2ed9c8b 5477 * term.c (encode_terminal_code): Likewise.
6be7d3da 5478
75f8807f 5479 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5480
50938595
PE
5481 * tparam.h: New file.
5482 * term.c, tparam.h: Include it.
5483 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5484 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5485 Move these decls to tparam.h, and make them agree with what
5486 is actually in tparam.c. The previous trick of using incompatible
5487 decls in different modules does not conform to the C standard.
5488 All callers of tparam changed to use tparam's actual API.
5489 * tparam.c (tparam1, tparam, tgoto):
5490 Use const pointers where appropriate.
5491
fbceeba2
PE
5492 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5493 * cm.h (struct cm): Likewise.
5494 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5495 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5496 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5497 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5498 (turn_on_face, init_tty): Likewise.
5499 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5500
7f3f1250
PE
5501 * term.c (term_mouse_position): Rename local to avoid shadowing.
5502
e6ca6543
PE
5503 * alloc.c (mark_ttys): Move decl from here ...
5504 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5505
c40f8d15
AS
55062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5507
5508 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5509
cfe0661d
JB
55102011-03-09 Juanma Barranquero <lekktu@gmail.com>
5511
5512 * search.c (compile_pattern_1): Remove argument regp, unused since
5513 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5514 (compile_pattern): Don't pass it.
5515
0afb4571
J
55162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5517
5518 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5519 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5520 for ! HAVE_GTK3.
5521 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5522
5523 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5524
5525 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5526 gdk_window_get_screen, gdk_window_get_geometry,
5527 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5528 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5529 (xg_get_pixbuf_from_pixmap): New function.
5530 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5531 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5532 Call xg_get_pixbuf_from_pixmap instead of
5533 gdk_pixbuf_get_from_drawable.
5534 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5535 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5536 (xg_check_special_colors): Use GtkStyleContext and its functions
5537 for HAVE_GTK3.
5538 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5539 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5540 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5541 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5542 Call gtk_widget_get_preferred_size.
0afb4571
J
5543 (xg_frame_resized): gdk_window_get_geometry only takes 5
5544 parameters.
44f230aa
SM
5545 (xg_win_to_widget, xg_event_is_for_menubar):
5546 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5547 (xg_set_widget_bg): New function.
5548 (delete_cb): New function.
895009e1 5549 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5550 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5551 (xg_set_background_color): Call xg_set_widget_bg.
5552 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5553 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5554 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5555 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5556 if ! HAVE_GTK3.
5557 (update_frame_tool_bar): Call gtk_widget_hide.
5558 (xg_initialize): Use GDK_KEY_g.
5559
5560 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5561 if ! HAVE_GTK3
5562 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5563
5564 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5565 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5566 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5567
1c2cc4ef
JB
55682011-03-08 Juanma Barranquero <lekktu@gmail.com>
5569
5570 * w32xfns.c (select_palette): Check success of RealizePalette against
5571 GDI_ERROR, not zero.
5572
33383987 5573See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5574
5575;; Local Variables:
5576;; coding: utf-8
aac0c6e3
MR
5577;; End:
5578
33383987 5579 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5580
5581 This file is part of GNU Emacs.
5582
5583 GNU Emacs is free software: you can redistribute it and/or modify
5584 it under the terms of the GNU General Public License as published by
5585 the Free Software Foundation, either version 3 of the License, or
5586 (at your option) any later version.
5587
5588 GNU Emacs is distributed in the hope that it will be useful,
5589 but WITHOUT ANY WARRANTY; without even the implied warranty of
5590 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5591 GNU General Public License for more details.
5592
5593 You should have received a copy of the GNU General Public License
5594 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.