* faces.el (set-face-attribute): Clarify the meaning of the nil frame.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1c6e5a32
GM
12012-01-05 Glenn Morris <rgm@gnu.org>
2
3 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4
651e947e
EZ
52012-01-01 Eli Zaretskii <eliz@gnu.org>
6
7 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8 Load gnutls_transport_set_lowat only if GnuTLS version is below
9 2.11.1.
10 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
11 GnuTLS versions below 2.11.1.
12
3778cdd8
AL
132011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
14
15 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
16 to the doc string advising against its use for altering the way
17 windows are scrolled.
18
0e5317f7
KH
192011-12-28 Kenichi Handa <handa@m17n.org>
20
21 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
22 coding-system ASCII compatible only when it does not produce BOM
23 on encoding (Bug#10383).
24
93d5ca1f
JD
252011-12-26 Jan Djärv <jan.h.d@swipnet.se>
26
27 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
28 can scroll.
29 (create_and_show_popup_menu): Always use menu_position_func for
30 Gtk3 (Bug#10361).
31
ca22b785
AS
322011-12-24 Andreas Schwab <schwab@linux-m68k.org>
33
34 * callint.c (Fcall_interactively): Don't truncate prompt string.
35
d048e1e6
EZ
362011-12-23 Eli Zaretskii <eliz@gnu.org>
37
38 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
39 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 40 resumed from there (after widening). (Bug#10360)
d048e1e6 41
5ccaba1f
JD
422011-12-22 Jan Djärv <jan.h.d@swipnet.se>
43
44 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
45
204ee57f
JD
462011-12-21 Jan Djärv <jan.h.d@swipnet.se>
47
b81d40f0
JB
48 * nsterm.m (x_free_frame_resources):
49 Release f->output_data.ns->miniimage.
204ee57f
JD
50 (ns_index_color): Fix indentation. Do not retain
51 color_table->colors[i].
52
53 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
54 before returning.
55
56 * nsfns.m (x_set_background_color): Assign return value from
57 ns_index_color to face-background instead of NSColor*.
58 (ns_implicitly_set_icon_type): Fix indentation.
59 Change assignment in for loop to comparison.
60
61 * emacs.c (ns_pool): New variable.
62 (main): Assign ns_pool.
63 (Fkill_emacs): Call ns_release_autorelease_pool.
64
65 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
66 autorelease fdesc, release fdAttrs and tdict.
67 (ns_get_covering_families): Release charset.
68 (ns_findfonts): Release NSFontDescriptor created with new.
69 (ns_uni_to_glyphs): Fix indentation.
70 (setString): Release attrStr before assigning new value.
71
c803b2b7
JD
722011-12-18 Jan Djärv <jan.h.d@swipnet.se>
73
678f4426
JD
74 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
75 and NS_IMPL_COCOA.
76 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
77 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
78
792011-12-18 David Reitter <reitter@cmu.edu>
80
5fecd5fc
JD
81 * nsterm.m (ns_term_init): Subscribe for notifications
82 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
83 to method trackingNotification in EmacsMenu.
84
85 * nsmenu.m (trackingMenu): New variable.
3771cb17 86 (trackingNotification): New method (from Aquamacs).
5fecd5fc 87 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 88 from Aquamacs (Bug#7030).
678f4426
JD
89
902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 91
c803b2b7
JD
92 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
93 (symbol_to_nsstring): Fix indentation.
94 (ns_symbol_to_pb): New function.
95 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
96 (Fns_rotate_cut_buffers_internal): Removed.
97 (Fns_store_selection_internal): Renamed from
98 Fns_store_cut_buffer_internal.
99 (ns_get_foreign_selection, Fx_own_selection_internal)
100 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
101 (Fns_get_selection_internal, Fns_store_selection_internal):
102 Use ns_symbol_to_pb and check if return value is nil.
103 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
104 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
105 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
106 renamed to Sns_store_selection_internal.
107 (ns_handle_selection_request): Move code to Fx_own_selection_internal
108 and remove this function.
109 (ns_handle_selection_clear): Remove, never used.
110 (Fx_own_selection_internal): Move code from ns_handle_selection_request
111 here.
112
e1b01a3a
KB
1132011-12-17 Ken Brown <kbrown@cornell.edu>
114
115 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
116 GID is unknown (Bug#10257).
117
2adb6e85
PE
1182011-12-17 Paul Eggert <eggert@cs.ucla.edu>
119
120 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
121 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
122 which caused a build failure on GNU/Linux IA-64. This problem was
123 introduced by my 2011-10-07 patch.
124
d1d7b339
JL
1252011-12-15 Juri Linkov <juri@jurta.org>
126
127 * image.c (imagemagick_error): New function. (Bug#10112)
128 (imagemagick_load_image): Comment out `MagickSetResolution' call.
129 Use `imagemagick_error' where ImageMagick functions return
130 `MagickFalse'.
131 (Fimagemagick_types): Add `Fnreverse' to return the list in the
132 proper order.
133
100d5755
KH
1342011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
135
136 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
137 fill background (Bug#8992).
138
454592a6
MR
1392011-12-13 Martin Rudalics <rudalics@gmx.at>
140
141 * window.c (Vwindow_combination_resize)
142 (Vwindow_combination_limit): Use t instead of non-nil in
143 doc-strings.
61d4b438
MR
144 (Vrecenter_redisplay): Add first sentence of doc-string on
145 separate line.
53524d93 146 (Frecenter): Fix doc-string typo.
454592a6 147
3633e3aa
KH
1482011-12-11 Kenichi Handa <handa@m17n.org>
149
150 * coding.c (Funencodable_char_position): Pay attention to the
151 buffer text relocation (Bug#9389).
152
7b9d523a
JD
1532011-12-10 Jan Djärv <jan.h.d@swipnet.se>
154
155 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
156 gtk_init (Bug#10100).
157
b73189c6
EZ
1582011-12-10 Eli Zaretskii <eliz@gnu.org>
159
160 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
161 IT->string is nil. (Bug#10263)
162
f7dfe5d6
JD
1632011-12-10 Jan Djärv <jan.h.d@swipnet.se>
164
83faebb4
JD
165 * nsterm.h (x_free_frame_resources): Declare.
166
f7dfe5d6
JD
167 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
168 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
169
170 * nsterm.h (ns_get_defaults_value): Declare.
171
172 * nsterm.m (ns_default): Call ns_get_defaults_value.
173
7cd4e72c
EZ
1742011-12-09 Eli Zaretskii <eliz@gnu.org>
175
176 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
177 (Bug#10170)
178
b34d7317
YM
1792011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
180
181 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
182 that where the value of an _OBJC_* symbol points to is in the .bss
183 section (Bug#10240).
184
76470ad1
KH
1852011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
186
187 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 188 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 189
745fff94
KH
1902011-12-08 Kenichi Handa <handa@m17n.org>
191
192 * ftfont.c (get_adstyle_property): Fix previous change
193 (Bug#10233).
194
6e44397c
JB
1952011-12-07 Juanma Barranquero <lekktu@gmail.com>
196
197 * w32.c (init_environment): If no_site_lisp, remove site-lisp
198 dirs from the default value of EMACSLOADPATH (bug#10208).
199
7efa6272
GM
2002011-12-07 Glenn Morris <rgm@gnu.org>
201
202 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
203 installation and source directories as well. (Bug#10208)
204
f6fc4d87
CY
2052011-12-06 Chong Yidong <cyd@gnu.org>
206
207 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
208
2bf26180
GM
2092011-12-06 Glenn Morris <rgm@gnu.org>
210
211 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
212 as an error, not just -1. (Bug#10217)
213
3a6ad4f0
CY
2142011-12-05 Chong Yidong <cyd@gnu.org>
215
216 * keyboard.c (process_special_events): New function.
217 (swallow_events, Finput_pending_p): Use it (Bug#10195).
218
75a3b399
PE
2192011-12-05 Paul Eggert <eggert@cs.ucla.edu>
220
221 * coding.c (encode_designation_at_bol): Don't use uninitialized
222 local variable (Bug#9318).
223
c3c9e25e
KH
2242011-12-05 Kenichi Handa <handa@m17n.org>
225
226 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
227 return Qnil (Bug#8046, Bug#10193).
228
5eb05ea3
KH
2292011-12-05 Kenichi Handa <handa@m17n.org>
230
231 * coding.c (encode_designation_at_bol): New args charbuf_end and
232 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
233 (coding_set_source): Return how many bytes coding->source was
234 relocated.
235 (coding_set_destination): Return how many bytes
236 coding->destination was relocated.
237 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
238 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
239
2402011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
241
242 * coding.c (CODING_CHAR_CHARSET_P): New macro.
243 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
244 macro (Bug#9318).
245
2462011-12-05 Andreas Schwab <schwab@linux-m68k.org>
247
248 The following changes are to fix Bug#9318.
249
a79703f5 250 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
251 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
252 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 253 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 254
7dbda6df
JB
2552011-12-05 Juanma Barranquero <lekktu@gmail.com>
256
257 * lisp.h (process_quit_flag): Fix external declaration.
258
6d5eb5b0
SM
2592011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
260
261 Don't macro-inline non-performance-critical code.
262 * eval.c (process_quit_flag): New function.
263 * lisp.h (QUIT): Use it.
264
a0c3fad0
JD
2652011-12-04 Jan Djärv <jan.h.d@swipnet.se>
266
267 * nsfns.m (get_geometry_from_preferences): New function.
268 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
269
6c07aac2
AS
2702011-12-04 Andreas Schwab <schwab@linux-m68k.org>
271
272 * emacs.c (Qkill_emacs): Define.
273 (syms_of_emacs): Initialize it.
274 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
275 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
276 (quit_throw_to_read_char): Add parameter `from_signal'.
277 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
278 * lisp.h (QUIT): Call Fkill_emacs if requested.
279
c052ead4
JD
2802011-12-03 Jan Djärv <jan.h.d@swipnet.se>
281
282 * widget.c (update_wm_hints): Return if wmshell is null.
283 (widget_update_wm_size_hints): New function.
284
285 * widget.h (widget_update_wm_size_hints): Declare.
286
287 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
288 widget_update_wm_size_hints (Bug#10104).
289
9e49252b
EZ
2902011-12-03 Eli Zaretskii <eliz@gnu.org>
291
292 * xdisp.c (handle_invisible_prop): If the invisible text ends just
293 before a newline, prepare the bidi iterator for consuming the
294 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 295 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 296
02b16839
JL
2972011-12-02 Juri Linkov <juri@jurta.org>
298
299 * search.c (Fword_search_regexp): New Lisp function created from
300 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
301 (Fword_search_backward, Fword_search_forward)
302 (Fword_search_backward_lax, Fword_search_forward_lax):
303 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
304 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
305
0068070e
SM
3062011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
307
308 * fileio.c (Finsert_file_contents): Move after-change-function call
309 to before the "handled:" label, since all "goto handled" appear in
310 cases where the *-change-functions have already been properly called
311 (bug#10117).
312
3360a3fc
AS
3132011-12-01 Andreas Schwab <schwab@linux-m68k.org>
314
315 * keyboard.c (interrupt_signal): Don't call kill-emacs when
316 waiting for input. (Bug#10169)
317
73d6c093
EZ
3182011-11-30 Eli Zaretskii <eliz@gnu.org>
319
320 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
321 verifies glyph row's hash code--we have just reallocated the
322 glyphs, so their contents can be complete garbage. (Bug#10164)
323
febe6bea
JB
3242011-11-30 Juanma Barranquero <lekktu@gmail.com>
325
326 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
327
801a4313
EZ
3282011-11-30 Eli Zaretskii <eliz@gnu.org>
329
330 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
331 attributes are tested _before_ calling verify_row_hash, to protect
332 against GCC re-ordering of the tests. (Bug#10164)
333
2b56b87e
JD
3342011-11-29 Jan Djärv <jan.h.d@swipnet.se>
335
336 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
337
338 * xterm.c (handle_one_xevent): Only set async_visible and friends
339 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 340 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
341 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
342
dbf31225
PE
3432011-11-28 Paul Eggert <eggert@cs.ucla.edu>
344
345 Remove GCPRO-related macros that exist only to avoid shadowing locals.
346 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
347 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
348 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
349 All uses changed to use GCPRO1 etc.
350 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
351 Revert to old implementation (i.e., before 2011-03-11).
352
1305621b
YM
3532011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
354
355 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
356 of scroll runs so as to avoid assigning disabled bogus rows and
357 unnecessary graphics copy operations.
358
8c9afb46
EZ
3592011-11-27 Eli Zaretskii <eliz@gnu.org>
360
361 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
362 (snprintf) [_MSC_VER]: Redirect to _snprintf.
363 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
364 (malloc, free, realloc, calloc): Redirect to e_* only when
365 compiling Emacs.
366
367 * lisp.h (GCTYPEBITS): Move before first use.
368 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
369 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
370 this macro definition.
371
372 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
373 _MSC_VER.
374
54e9e3bf
JD
3752011-11-27 Jan Djärv <jan.h.d@swipnet.se>
376
6d5eb5b0
SM
377 * gtkutil.c (xg_create_frame_widgets):
378 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
379 present with Gtk+ 2.0.
380
83aca1cb
PE
3812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
382
383 * fileio.c (Finsert_file_contents): Undo previous change; see
384 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
385
5b76caa4
PE
3862011-11-26 Paul Eggert <eggert@cs.ucla.edu>
387
388 Rename locals to avoid shadowing.
389 * fileio.c (Finsert_file_contents):
390 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
391 * process.c (wait_reading_process_output):
392 Rename inner 'proc' to 'p' to avoid shadowing.
393 Indent for consistency with usual Emacs style.
394
8c535114
EZ
3952011-11-25 Eli Zaretskii <eliz@gnu.org>
396
397 * xdisp.c (redisplay_window): If cursor row is not fully visible
398 after recentering, and scroll-conservatively is set to a large
399 number, scroll window by a few more lines to make the cursor fully
400 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
401 (start_display): Don't move to the next line if the display should
402 start at a newline that is part of a display vector or an overlay
403 string. (Bug#10119)
8c535114 404
fa4fdb5c
JL
4052011-11-24 Juri Linkov <juri@jurta.org>
406
407 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
408 after the `MagickPingImage' call. (Bug#10112)
409
90ec88df
CY
4102011-11-23 Chong Yidong <cyd@gnu.org>
411
412 * window.c (Fcoordinates_in_window_p): Accept only live windows.
413
56e2e794
MR
4142011-11-23 Martin Rudalics <rudalics@gmx.at>
415
416 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
417 making another buffer current. (Bug#10114)
418
b6e64c41
GM
4192011-11-23 Glenn Morris <rgm@gnu.org>
420
421 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
422
6b21de18
CY
4232011-11-23 Chong Yidong <cyd@gnu.org>
424
425 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
426 using it (Bug#5984).
427
b12cd789
EZ
4282011-11-22 Eli Zaretskii <eliz@gnu.org>
429
430 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
431 and header-lines, as they don't have one computed for them.
432 (Bug#10098)
433
434 * .gdbinit (prow): Make displayed values more self-explaining.
435 Add row's hash code.
436
261b6fd4
LMI
4372011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
438
439 * process.c (wait_reading_process_output): Fix asynchrounous
440 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 441 (wait_reading_process_output): Add comment and URL.
261b6fd4 442
e7cfd277
JD
4432011-11-21 Jan Djärv <jan.h.d@swipnet.se>
444
445 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
446
a9b9b7f5
CY
4472011-11-21 Chong Yidong <cyd@gnu.org>
448
449 * window.c (Fnext_window, Fprevious_window): Doc fix.
450
b0d15b4f
SM
4512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
452
453 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
454
fe7a3057
JB
4552011-11-20 Juanma Barranquero <lekktu@gmail.com>
456
457 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
458
d2999b1a
MR
4592011-11-20 Martin Rudalics <rudalics@gmx.at>
460
461 * window.c (Fset_window_combination_limit): Rename argument
462 STATUS to LIMIT.
463 (Vwindow_combination_limit): Remove "status" from doc-string.
464
d5ff9cd0
AS
4652011-11-20 Andreas Schwab <schwab@linux-m68k.org>
466
467 * m/ibms390.h: Remove.
468 * m/ibms390x.h: Don't include "ibms390.h".
469
a5bb9bd3
SM
4702011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
471
472 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
473 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
474
cd1181db
JB
4752011-11-20 Juanma Barranquero <lekktu@gmail.com>
476
477 * casetab.c (Fset_case_table):
478 * charset.c (Fcharset_after): Fix typos.
479
615a3b8d 4802011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 481
17e845af
PE
482 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
483 Otherwise, valgrind does not work on some platforms.
484 Problem reported by Andreas Schwab in
6a0bf43d
PE
485 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
486 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
487 is set, removing the need for VIRT_ADDRESS_VARIES.
488 (PURE_P): Use a more-efficient implementation that needs just one
489 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
490 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
491 to 4 (xorl, subq, cmpq, setbe).
492 * alloc.c (pure): Always extern now, since that's the
493 VIRT_ADDR_VARIES behavior.
494 (PURE_POINTER_P): Use a single comparison, not two, for
495 consistency with the new puresize.h.
496 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
497 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
498 Remove VIRT_ADDR_VARIES no longer needed.
499
f8fe6f96
EZ
5002011-11-19 Eli Zaretskii <eliz@gnu.org>
501
502 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
503 (erase_phys_cursor, update_window_cursor, show_mouse_face)
504 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
505 behave as if the cursor position were at the window margin.
506
507 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
508 and the cursor position is out of bounds, behave as if the cursor
509 position were at the window margin. (Bug#10075)
510
df05a53c
CY
5112011-11-18 Chong Yidong <cyd@gnu.org>
512
513 * window.c (Fwindow_combination_limit): Make first argument
514 non-optional, since it is meaningless for live windows like the
515 selected window.
516
2071918e
DA
5172011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
518
519 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
520
b50a28de
SM
5212011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
522
523 * intervals.c: Fix grafting over the whole buffer (bug#10071).
524 (graft_intervals_into_buffer): Simplify.
525
015137db
EZ
5262011-11-18 Eli Zaretskii <eliz@gnu.org>
527
528 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
529 hash values of the two rows.
530 (copy_row_except_pointers): Preserve the used[] arrays and the
531 hash values of the two rows. (Bug#10035)
68c95424 532 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
533
534 * xdisp.c (row_hash): New function, body extracted from
535 compute_line_metrics.
536 (compute_line_metrics): Call row_hash, instead of computing the
537 hash code inline.
538
539 * dispnew.c (verify_row_hash): Call row_hash for computing the
540 hash code of a row, instead of duplicating code from xdisp.c.
541
542 * dispextern.h (row_hash): Add prototype.
543
a2addb04
TH
5442011-11-18 Tassilo Horn <tassilo@member.fsf.org>
545
546 * frame.c (delete_frame): Don't delete the terminal when the last
547 X frame is closed if emacs is built with GTK toolkit.
548
df85d315
JB
5492011-11-17 Juanma Barranquero <lekktu@gmail.com>
550
551 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
552
a0c2d0ae
MR
5532011-11-17 Martin Rudalics <rudalics@gmx.at>
554
555 * window.c (Vwindow_splits): Rename to
556 Vwindow_combination_resize. Suggested by Juri Linkov.
557 (Fsplit_window_internal): Use Vwindow_combination_resize instead
558 of Vwindow_splits.
559
58179cce
JB
5602011-11-16 Juanma Barranquero <lekktu@gmail.com>
561
7877f373
JB
562 * nsfns.m (Fns_font_name):
563 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 564
b6f67890
MR
5652011-11-16 Martin Rudalics <rudalics@gmx.at>
566
567 * window.h (window): Rename slot "nest" to "combination_limit".
568 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
569 (Fset_window_nest): Rename to Fset_window_combination_limit.
570 (Vwindow_nest): Rename to Vwindow_combination_limit.
571 (recombine_windows, make_parent_window, make_window)
572 (Fsplit_window_internal, saved_window)
573 (Fset_window_configuration, save_window_save): Rename all
574 occurrences of window_nest to window_combination_limit.
575
c7015153
JB
5762011-11-15 Juanma Barranquero <lekktu@gmail.com>
577
578 * image.c (imagemagick_load_image): Fix typo.
579
322ad6ec
EZ
5802011-11-14 Eli Zaretskii <eliz@gnu.org>
581
582 * xdisp.c (display_line): Move the call to
583 highlight_trailing_whitespace before the call to
584 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
585 faces of all the glyphs to compute ROW's hash value.
586 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 587
f067b8ec
JB
5882011-11-14 Juanma Barranquero <lekktu@gmail.com>
589
590 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
591 just return (bug#10044).
592
1e5b2111
EZ
5932011-11-12 Eli Zaretskii <eliz@gnu.org>
594
7ef3cbd5
EZ
595 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
596 with user-defined heap size. Bump the default size of the temacs
597 heap to 27MB, to avoid memory warning when running temacs.
598 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
599
1e5b2111
EZ
600 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
601 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
602 (verify_row_hash) [XASSERTS]: New function.
603 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
604 that the hash value of glyph rows is correct.
1e5b2111 605
89d61221
MR
6062011-11-12 Martin Rudalics <rudalics@gmx.at>
607
608 * window.h (window): Remove splits slot.
609 * window.c (Fwindow_splits, Fset_window_splits): Remove.
610 (Fdelete_other_windows_internal, make_parent_window)
611 (make_window, Fsplit_window_internal, Fdelete_window_internal)
612 (Fset_window_configuration, save_window_save): Don't deal with
613 split status of windows.
614 (saved_window): Remove splits slot.
615 (Vwindow_splits): Rewrite doc-string.
616
97f18cc8
JD
6172011-11-11 Jan Djärv <jan.h.d@swipnet.se>
618
619 * xfns.c (unwind_create_frame):
620 * nsfns.m (unwind_create_frame):
621 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
622 Vframe_list (Bug#9999).
623
22a648b4
DA
6242011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
625
0b381c7e 626 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 627
659afede
KH
6282011-11-11 Kenichi Handa <handa@m17n.org>
629
630 * callproc.c (Fcall_process): Set the member dst_multibyte of
631 process_coding.
632
9ac0394b
KH
6332011-11-11 Johan Bockgård <bojohan@gnu.org>
634
635 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
636 avoid a crash (bug#9496).
637
2fbdc249
CY
6382011-11-09 Chong Yidong <cyd@gnu.org>
639
640 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
641 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
642
ac6b1f81
PE
6432011-11-08 Paul Eggert <eggert@cs.ucla.edu>
644
645 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
646
09db192c
PE
6472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
648
649 Avoid some portability problems by eschewing 'extern inline' functions.
650 The trivial performance wins aren't worth the portability hassles; see
651 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
652 et seq.
653 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
654 (window_box_width, window_box_left, window_box_left_offset)
655 (window_box_right, window_box_right_offset): Undo previous change,
656 by removing the "extern"s.
657 * intervals.c (adjust_intervals_for_insertion)
658 (adjust_intervals_for_deletion): Undo previous change,
659 making these static again.
660 (offset_intervals, temp_set_point_both, temp_set_point)
661 (copy_intervals_to_string): No longer inline.
662 * xdisp.c (window_text_bottom_y, window_box_width)
663 (window_box_height, window_box_left_offset)
664 (window_box_right_offset, window_box_left, window_box_right)
665 (window_box): No longer inline.
666
105216ed
CY
6672011-11-08 Chong Yidong <cyd@gnu.org>
668
669 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
670 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
671 Signal an error if not a live window.
105216ed
CY
672 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
673 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
674
ae9e237f
JB
6752011-11-07 Juanma Barranquero <lekktu@gmail.com>
676
677 * lisp.h (syms_of_abbrev): Remove declaration.
678 Reported by CHENG Gao <chenggao@royau.me>.
679
c7aa8333
EZ
6802011-11-07 Eli Zaretskii <eliz@gnu.org>
681
682 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
683 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
684 of temacs in GUI mode.
685
be7f5545
MR
6862011-11-07 Martin Rudalics <rudalics@gmx.at>
687
688 * window.h: Declare delete_all_child_windows instead of
689 delete_all_subwindows.
690 * window.c (Fwindow_nest, Fset_window_nest)
691 (Fset_window_new_total, Fset_window_new_normal)
692 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
693 (delete_all_subwindows): Rename to delete_all_child_windows.
694 (Fdelete_other_windows_internal, Fset_window_configuration):
695 Call delete_all_child_windows instead of delete_all_subwindows.
696 * frame.c (delete_frame): Call delete_all_child_windows instead
697 of delete_all_subwindows.
698
ca78dc43
PE
6992011-11-07 Paul Eggert <eggert@cs.ucla.edu>
700
701 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
702 This is also needed for porting to any host where GC_MARK_STACK is
703 not GC_MAKE_GCPROS_NOOPS.
704 (which_symbols): Use it.
705
a0241d01
KH
7062011-11-07 Kenichi Handa <handa@m17n.org>
707
708 * coding.c (coding_set_destination): Check coding->src_pos only
709 when coding->src_object is a buffer (bug#9910).
710
711 * process.c (send_process): Set the member src_multibyte of coding
712 to 0 (bug#9911) when sending a unibyte text.
713
714 * callproc.c (Fcall_process): Set the member src_multibyte of
715 process_coding to 0 (bug#9912).
716
a64bfdfa 7172011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
718
719 * xmenu.c (cleanup_widget_value_tree): New function.
720 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
721 calling free_menubar_widget_value_tree directly (Bug#9830).
722
cb41b32a
PE
7232011-11-06 Paul Eggert <eggert@cs.ucla.edu>
724
725 Fix some portability problems with 'inline'.
726 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
727 (window_box_width, window_box_left, window_box_left_offset)
728 (window_box_right, window_box_right_offset): Declare extern.
729 Otherwise, these inline functions do not conform to C99 and
730 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
731 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
732 * intervals.c (adjust_intervals_for_insertion)
733 (adjust_intervals_for_deletion): Now extern, because otherwise the
734 extern inline functions 'offset_intervals' couldn't refer to it.
735 (static_offset_intervals): Remove.
736 (offset_intervals): Rewrite using the old contents of
737 static_offset_intervals. The old version didn't conform to C99
738 because an extern inline function contained a reference to an
739 identifier with static linkage.
740
b7041366
AS
7412011-11-06 Andreas Schwab <schwab@linux-m68k.org>
742
743 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
744 GC.
745
88a37c4d
EZ
7462011-11-06 Eli Zaretskii <eliz@gnu.org>
747
748 * xdisp.c (init_iterator, reseat_to_string): Don't set the
749 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
750 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
751 return Qleft_to_right.
752
49745b39
CY
7532011-11-06 Chong Yidong <cyd@gnu.org>
754
755 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
756 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
757 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
758 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
759 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
760 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
761 (Fwindow_vscroll): Doc fix.
762 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
763 argument, since it makes no sense to pass a live window and for
764 consistency with window-child.
765
1f05cd82
CS
7662011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
767
768 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
769 support MSVC.
770
22610910
JR
7712011-11-05 Jason Rumney <jasonr@gnu.org>
772
773 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
774 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
775 fonts (Bug#6029).
776 (add_font_entity_to_list): Fix logic errors in mixed boolean and
777 bitwise arithmetic preventing use of unicode-sip and non-truetype
778 opentype fonts.
779
a06776b2
EZ
7802011-11-05 Eli Zaretskii <eliz@gnu.org>
781
3ad924ba
EZ
782 * s/ms-w32.h (fstat, stat, utime): Move redirections to
783 "emacs"-only part.
784
a06776b2
EZ
785 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
786 initialization code to keep similarity to xfns.c after changes
787 from 2011-11-05.
788
c9e7db78
JD
7892011-11-05 Jan Djärv <jan.h.d@swipnet.se>
790
a97f8f3f
JD
791 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
792 (unwind_create_frame): New function (Bug#9943).
793 (Fx_create_frame): Restructure code to be more similar to the one in
794 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
795 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
796 Move terminal->reference_count++ just before making the frame official
797 (Bug#9943).
798
799 * nsterm.m (x_free_frame_resources): New function.
800 (x_destroy_window): Move code to x_free_frame_resources.
801
c9e7db78 802 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
803 (Fx_create_frame, x_create_tip_frame):
804 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
805 official. Move initialization of image_cache_refcount and
806 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
807
a6fc3b5c
EZ
8082011-11-05 Eli Zaretskii <eliz@gnu.org>
809
810 Support MSVC build with newer versions of Visual Studio.
811 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
812 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
813 nt/gmake.defs.
814
815 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
816 which are not supported by MSVC.
817 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
818 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
819 bitfields.
820 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
821 types in bitfields.
822 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
823
824 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
825
58179cce 8262011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
827
828 Support MSVC build with newer versions of Visual Studio.
829 * w32.c: Don't include w32api.h for MSVC.
830 (init_environment) [_MSC_VER]: Call sys_access, not _access.
831
832 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
833 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
834 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
835 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
836 e_* cousins.
837 (alloca) [_MSC_VER]: Define to _alloca.
838
839 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
840
841 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
842
a58c13ed
EZ
8432011-11-04 Eli Zaretskii <eliz@gnu.org>
844
845 * xdisp.c (note_mouse_highlight): If either of
846 previous/next-single-property-change returns nil, treat that as
847 the beginning or the end of the buffer. (Bug#9955)
848
fe0b6370
JD
8492011-11-04 Jan Djärv <jan.h.d@swipnet.se>
850
a58c13ed 851 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
852 label is not null (Bug#9951).
853 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
854 may be NULL.
855
89bd5ee1
EZ
8562011-11-04 Eli Zaretskii <eliz@gnu.org>
857
858 * window.c (Fwindow_body_size): Mention in the doc string that the
859 return value is in frame's canonical units. (Bug#9949)
860
84c3edb9
EZ
8612011-11-03 Eli Zaretskii <eliz@gnu.org>
862
4e2fb5c7
EZ
863 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
864
84c3edb9 865 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 866 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 867 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 868
bc17a887
EZ
8692011-11-01 Eli Zaretskii <eliz@gnu.org>
870
871 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
872 Don't stop backward scan on the continuation glyph, even though
873 its CHARPOS is positive.
6d5eb5b0
SM
874 (mouse_face_from_buffer_pos, note_mouse_highlight):
875 Rename cover_string to disp_string.
bc17a887 876
4ee88440
MR
8772011-11-01 Martin Rudalics <rudalics@gmx.at>
878
879 * window.c (temp_output_buffer_show): Don't use
880 Vtemp_buffer_show_specifiers.
881 (Vtemp_buffer_show_specifiers): Remove unused variable.
882
c2ff3c02
EZ
8832011-10-30 Eli Zaretskii <eliz@gnu.org>
884
885 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
886 past the beginning of the current glyph matrix.
887
58179cce 8882011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
889
890 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
891 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
892 HAVE_GTK3 (Bug#9869).
b77a6a7f 893
3b574623
JD
894 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
895 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
896
b77a6a7f
JD
897 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
898
899 * xterm.c: Declare x_handle_net_wm_state to return int.
900 (handle_one_xevent): Check if we are iconified but don't have
901 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
902 (get_current_wm_state): Return non-zero if not hidden,
903 check for _NET_WM_STATE_HIDDEN (Bug#9893).
904 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
905 (x_handle_net_wm_state): Return what get_current_wm_state returns.
906 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
907
196e41e4
PE
9082011-10-29 Paul Eggert <eggert@cs.ucla.edu>
909
910 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
911 so that this new function doesn't get optimized away by a
912 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
913
021f2e1a
AS
9142011-10-29 Andreas Schwab <schwab@linux-m68k.org>
915
916 * frame.h (MOUSE_HL_INFO): Remove excess parens.
917
8b058d44
EZ
9182011-10-29 Eli Zaretskii <eliz@gnu.org>
919
920 Fix the `xbytecode' command.
921 * .gdbinit (xprintbytestr): New command.
b50a28de 922 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
923 (xbytecode): Print the byte-code string as well.
924
4452fb80
EZ
9252011-10-29 Kim Storm <storm@cua.dk>
926
8b058d44
EZ
927 * alloc.c (which_symbols): New function.
928
21b72067
AS
9292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
930
931 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
932 line. (Bug#9903)
933
83ed7b5c
GM
9342011-10-29 Glenn Morris <rgm@gnu.org>
935
936 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
937 Not clear what it was for, and it causes various bugs. (Bug#9839)
938
5a7a728b
EZ
9392011-10-28 Eli Zaretskii <eliz@gnu.org>
940
941 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
942 possible random value that matches one of those tested as
943 condition to clear the mouse face.
944
d3d0842f
CY
9452011-10-28 Chong Yidong <cyd@gnu.org>
946
947 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
948
31b39d13
DN
9492011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
950
951 * window.c (make_window): Initialize phys_cursor_on_p.
952
9aba6043
SM
9532011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
954
955 * lisp.h (struct Lisp_Symbol): Update comments.
956
c20992f4
JB
9572011-10-28 Juanma Barranquero <lekktu@gmail.com>
958
959 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
960
db4f02f2
EZ
9612011-10-28 Eli Zaretskii <eliz@gnu.org>
962
963 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
964 <oslsachem@gmail.com> for helping to debug this.
965
966 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
967 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
968 (g_b_init_get_glyph_outline_w): New static variables.
969 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
970 (GetGlyphOutlineW_Proc): New typedefs.
971 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
972 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
973 New functions.
974 (w32font_open_internal, compute_metrics):
975 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
976 instead of calling the "wide" APIs directly.
977
978 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
979
980 * w32.h (syms_of_w32font): Add prototype.
981
87e68db4
JB
9822011-10-27 Juanma Barranquero <lekktu@gmail.com>
983
984 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
985 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
986 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
987 (Fmove_to_window_line): Doc fix.
988
435c1d67
CY
9892011-10-27 Chong Yidong <cyd@gnu.org>
990
991 * process.c (make_process): Set gnutls_state to NULL.
992
993 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
994 non-NULL, regardless of GNUTLS_INITSTAGE.
995 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
996 an error. Set process slots as soon as we allocate them.
997
998 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
999
9c6c6f49
CY
10002011-10-27 Chong Yidong <cyd@gnu.org>
1001
9aba6043
SM
1002 * gnutls.c (emacs_gnutls_deinit): New function.
1003 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1004 (Fgnutls_deinit, Fgnutls_boot): Use it.
1005
1006 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1007 (deactivate_process): Call emacs_gnutls_deinit.
1008
657d08d3
JB
10092011-10-27 Juanma Barranquero <lekktu@gmail.com>
1010
1011 * image.c (x_create_x_image_and_pixmap):
1012 * w32.c (sys_rename, w32_delayed_load):
1013 * w32font.c (fill_in_logfont):
1014 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1015
5430d399
JB
10162011-10-26 Juanma Barranquero <lekktu@gmail.com>
1017
1018 * w32fns.c (w32_default_color_map): New function,
1019 extracted from Fw32_default_color_map.
a7ef684b 1020 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1021
fe0055fa
PE
10222011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1025
e6346438
SM
10262011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1027
1028 * keyboard.c (test_undefined): New function (bug#9751).
1029 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1030
e112cc37
ET
10312011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1032
1033 * sysdep.c (init_sys_modes): Fix the check for the controlling
1034 terminal (Bug#6649).
1035
7b5d6677
EZ
10362011-10-20 Eli Zaretskii <eliz@gnu.org>
1037
1038 * dispextern.h (struct bidi_it): New member next_en_type.
1039
1040 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1041 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1042 current character, check also for next_en_type being WEAK_EN.
1043 (bidi_resolve_weak): Don't enter the expensive loop if the current
1044 position is before next_en_pos. Record the bidi type of the first
1045 non-ET, non-BN character we find, in addition to its position.
1046 (bidi_level_of_next_char): Invalidate next_en_type when
1047 next_en_pos is over-stepped.
1048
7da0b018
PE
10492011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1052 * editfns.c: Rewrite current-time-zone so that it invokes
1053 the equivalent of (format-time-string "%Z") to get the time zone name.
1054 This fixes a bug when the time zone name contains characters that
1055 need converting from the system time locale to Emacs internal format.
1056 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1057 that patch fixed format-time-string to do the conversion, but
1058 I forgot to fix current-time-zone.
1059 (format_time_string): New function, containing most of
1060 what Fformat_time_string used to contain.
1061 (Fformat_time_string): Rewrite in terms of format_time_string.
1062 This doesn't change this function's behavior.
1063 (current-time-zone): Rewrite to use format_time_string.
1064 This fixes the bug reported by Michael Schierl in
1065 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1066 Jason Rumney's 2007-06-07 change worked around this bug, but
1067 didn't fix it.
1068 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1069
8547b010
EZ
10702011-10-19 Eli Zaretskii <eliz@gnu.org>
1071
1072 * xdisp.c (start_display): If the character at POS is displayed
1073 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1074 (try_window_reusing_current_matrix): If a line ends in a display
1075 vector or the next line starts in a display vector, continue
1076 redrawing the window even though the character position of
1077 start_row was reached.
8547b010
EZ
1078 (Bug#9771, part 2)
1079
4e948d15
CY
10802011-10-18 Chong Yidong <cyd@gnu.org>
1081
1082 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1083 with nobreak-char-display too.
1084
4787455f
EZ
10852011-10-18 Eli Zaretskii <eliz@gnu.org>
1086
1087 Fix part 3 of bug#9771.
1088 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1089 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1090 non-neutral characters if the current character is a paragraph
1091 separator (a.k.a. Newline). This avoids running the same
1092 expensive loop twice, once when we consume the preceding newline
1093 and the other time when the line actually needs to be displayed.
1094 Avoid the loop when we see neutrals on the base embedding level
1095 following a character whose directionality is the same as the
1096 paragraph's. This avoids running the expensive loop when a line
1097 ends in a long sequence of neutrals, like control characters.
1098 Add assertion against STRONG_AL type. Slightly rearrange code
1099 that determines the type of a neutral given the first non-neutral
1100 that follows it.
1101 (bidi_level_of_next_char): Set next_en_pos to zero when
1102 invalidating its info.
1103
2c91f553
EZ
11042011-10-17 Eli Zaretskii <eliz@gnu.org>
1105
1106 * xdisp.c (push_display_prop): Determine whether to record string
1107 or buffer position by IT->string, not by IT->method. Allow
1108 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1109 (move_it_vertically_backward): Don't look for character position
1110 immediately after the newline when in a continuation line.
1111 (Bug#9771, part 1)
2c91f553 1112
c7b08b0d
MR
11132011-10-15 Martin Rudalics <rudalics@gmx.at>
1114
1115 * window.c (coordinates_in_window): Rewrite and delabelize
1116 vertical border check. (Bug#5357) (Bug#9618)
1117
6b02f655
SM
11182011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1119
1120 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1121 errors in XSetWindowBorder (bug#9310).
1122
81d40c92
DA
11232011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1124
1125 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1126 avoid crash when xmalloc overrun checking is enabled.
1127
d4172c3b
EZ
11282011-10-13 Eli Zaretskii <eliz@gnu.org>
1129
1130 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1131 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1132 cursor motion with <left> and <right> arrow keys.
1133
1134 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1135 some callers set that themselves.
1136
b00eea75
EZ
11372011-10-12 Eli Zaretskii <eliz@gnu.org>
1138
1139 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1140 display string and the previous row comes from the same string and
1141 is empty. (Bug#9739) (Bug#9738)
1142
8fe012c4
SM
11432011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1144
1145 * doc.c (get_doc_string): Encode file name (bug#9735).
1146
0074aef2
EZ
11472011-10-12 Eli Zaretskii <eliz@gnu.org>
1148
79beb178
EZ
1149 * bidi.c (bidi_level_of_next_char):
1150 * xdisp.c (get_visually_first_element): Remove old incorrect
1151 comments regarding the Unicode Line Separator character.
1152
0074aef2
EZ
1153 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1154
6e4b3fbe
DA
11552011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1156
1157 * alloc.c (Fgc_status): Do not access beyond zombies array
1158 boundary if nzombies > MAX_ZOMBIES.
1159 * alloc.c (dump_zombies): Add missing format specifier.
1160
0324f3af
PE
11612011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1162
b5525cac
PE
1163 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1164 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1165
0324f3af
PE
1166 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1167 Some packages use them to denote characters with modifiers.
1168
e9b5f888
AS
11692011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1170
1171 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1172 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1173 matching a pp-number. Rename parameter var to var1.
1174
127827c0
SM
11752011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1176
1177 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1178
c8fd3bd0
GM
11792011-10-08 Glenn Morris <rgm@gnu.org>
1180
1181 * callint.c (Fcall_interactively): Give a more explicit error for the
1182 'c' case with a non-character input. (Bug#8479)
1183
352ec8ff
EZ
11842011-10-08 Eli Zaretskii <eliz@gnu.org>
1185
03669ccb
EZ
1186 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1187 lines.
7061c986
EZ
1188 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1189 lines that are hscrolled on the left.
03669ccb 1190
352ec8ff
EZ
1191 * dispnew.c (buffer_posn_from_coords): Account for a possible
1192 presence of header-line. (Bug#4426)
1193
a66cfb1c
SM
11942011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1195
6b02f655
SM
1196 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1197 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1198
7c5ee88e
PE
11992011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1202 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1203 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1204 this makes Emacs dump core during garbage collection on rare
1205 occasions. sizeof is obviously inferior to offsetof here, so
1206 stick with offsetof.
1207 (GC_POINTER_ALIGNMENT): New macro.
1208 (mark_memory): Omit 3rd (offset) arg; caller changed.
1209 Don't assume EMACS_INT alignment is the same as pointer alignment.
1210
df1bbe5b
SM
12112011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1212
1213 * keyboard.c (read_key_sequence_remapped): New var.
1214 (read_key_sequence): Compute remapping in the right buffer.
1215 (command_loop_1): Use read_key_sequence's remapping directly.
1216
51553db6
SM
12172011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1218
32c1fffd
SM
1219 * dired.c (file_name_completion): Don't expand file name.
1220 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1221 before checking file name handler.
1222
51553db6
SM
1223 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1224 they've been requested explicitly (bug#9591).
1225
b6bd1599 12262011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1227
1228 * keymap.c (Fsingle_key_description): Use make_specified_string
1229 instead of build_string to build string from push_key_description.
1230 (Bug#5193)
1231
f701dc2a
PE
12322011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1233
4222c55d
PE
1234 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1235 This fixes a Y2038 bug on 64-bit hosts.
1236 * buffer.c (reset_buffer):
1237 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1238 (Fclear_buffer_auto_save_failure):
1239 Use 0, not -1, to represent an unset failure time, since time_t
1240 might not be signed.
1241
f701dc2a
PE
1242 Remove dependency on glibc malloc internals.
1243 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1244 Move back here from lisp.h, but with their new implementations.
1245 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1246 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1247 * charset.c (charset_table_init): New static var.
1248 (syms_of_charset): Use it instead of xmalloc. This removes a
1249 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1250 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1251 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1252 Move back to alloc.c.
1253 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1254 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1255
9ceebf39
JD
12562011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1257
1258 * nsterm.m (windowDidResize): Call x_set_window_size only when
1259 ns_in_resize is true. Otherwise set pixelwidth/height and
1260 call change_frame_size (Bug#9628).
1261
cb993c58
PE
12622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1263
3930c88b
PE
1264 Port --enable-checking=all to Fedora 14 x86-64.
1265 * charset.c (syms_of_charset): Also account for glibc malloc's
1266 internal overhead when calculating the initial malloc maximum.
1267
cb993c58
PE
1268 Port --enable-checking=all to Fedora 14 x86.
1269 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1270 Move to lisp.h.
1271 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1272 (overrun_check_realloc, overrun_check_free):
1273 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1274 That way, xmalloc returns a properly-aligned pointer even if
1275 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1276 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1277 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1278 into account when calculating the initial malloc maximum.
1279 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1280 Move here from alloc.c, so that charset.c can use it too.
1281 Properly align; the old code wasn't right for common 32-bit hosts
1282 when configured with --enable-checking=all.
1283 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1284 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1285
31bed486
EZ
12862011-09-29 Eli Zaretskii <eliz@gnu.org>
1287
04c70788 1288 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1289 use EDOM.
1290
fbcaa2f3
EZ
12912011-09-28 Eli Zaretskii <eliz@gnu.org>
1292
1293 * xdisp.c (compute_display_string_end): If there's no display
1294 string at CHARPOS, return -1.
1295
1296 * bidi.c (bidi_fetch_char): When compute_display_string_end
1297 returns a negative value, treat the character as a normal
1298 character not covered by a display string. (Bug#9624)
1299
a239d4e9
JB
13002011-09-28 Juanma Barranquero <lekktu@gmail.com>
1301
1302 * lread.c (Fread_from_string): Fix typo in docstring.
1303
88652fd5
EZ
13042011-09-27 Eli Zaretskii <eliz@gnu.org>
1305
1306 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1307 newline, reseat the iterator instead of bidi-iterating there one
1308 character at a time. (Bug#9610)
32c1fffd
SM
1309 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1310 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1311
ed497dd4
AS
13122011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1313
1314 * lread.c (readevalloop): Use correct code for NBSP.
1315 (read1): Likewise. (Bug#9608)
1316
b2bf61aa
MA
13172011-09-25 Michael Albinus <michael.albinus@gmx.de>
1318
1319 * dbusbind.c (Fdbus_register_signal): When service is not
1320 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1321
32bbb17c
GM
13222011-09-25 Glenn Morris <rgm@gnu.org>
1323
1324 * buffer.c (truncate-lines): Doc fix.
1325
94e0933e
CY
13262011-09-24 Chong Yidong <cyd@stupidchicken.com>
1327
1328 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1329 (Fset_window_next_buffers): Doc fix.
1330
cddde921
GM
13312011-09-24 Glenn Morris <rgm@gnu.org>
1332
1333 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1334
1260aef1
PE
13352011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1336
25b4bfa0
PE
1337 Fix minor problems found by static checking.
1338 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1339 * indent.c (Fvertical_motion): Fix == vs = typo.
1340
e3cbd34b
EZ
13412011-09-24 Eli Zaretskii <eliz@gnu.org>
1342
a66cfb1c
SM
1343 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1344 Default value is now t. Doc fix.
6bf7006f 1345
e3cbd34b 1346 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1347 logic when moving up, not only when moving down. Fix the
e3cbd34b 1348 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1349 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1350
1351 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1352 CHARPOS is covered by a display string which includes newlines.
1353 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1354 is covered by a display string with embedded newlines.
1355
a3de0cbd
MA
13562011-09-24 Michael Albinus <michael.albinus@gmx.de>
1357
1358 * dbusbind.c (Fdbus_register_signal): Add match rule to
1359 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1360 (Fdbus_register_method, Vdbus_registered_objects_table):
1361 Fix docstring.
a3de0cbd 1362
b260039d
JM
13632011-09-24 Jim Meyering <meyering@redhat.com>
1364
32c1fffd 1365 do not ignore write error for any output size
b260039d
JM
1366 The previous change was incomplete.
1367 While it makes emacs --batch detect the vast majority of stdout
1368 write failures, errors were still ignored whenever the output size is
1369 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1370 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1371 && echo FAIL: ignored write error
1372 FAIL: ignored write error
1373 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1374 && echo FAIL: ignored write error
1375 FAIL: ignored write error
1376 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1377
8eca8a7c
AS
13782011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1379
1380 * emacs.c (Fkill_emacs): In noninteractive mode exit
1381 non-successfully if a write error occurred on stdout. (Bug#9574)
1382
3341db62
EZ
13832011-09-21 Eli Zaretskii <eliz@gnu.org>
1384
1385 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1386 the xassert test.
1387
1388 * dispextern.h (struct it): Update the comment documenting what
1389 can it->OBJECT be.
1390
8c203dbf
EZ
13912011-09-20 Eli Zaretskii <eliz@gnu.org>
1392
1393 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1394 a display string, extend search for cursor position to end of row.
1395 (find_row_edges): If the row ends in a newline from a display
1396 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1397 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1398 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1399 non-empty line. Fixes confusing cursor motion with arrow keys at
1400 the beginning of a line that starts with whitespace.
8c203dbf 1401
a4824228
LMI
14022011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1403
1404 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1405 (bug#9493).
1406
33ed493b
CY
14072011-09-18 Chong Yidong <cyd@stupidchicken.com>
1408
1409 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1410 boolean (Bug#9154).
1411
56cd55c8
EZ
14122011-09-18 Eli Zaretskii <eliz@gnu.org>
1413
1414 * xdisp.c (display_line): Record maximum and minimum buffer
1415 positions even if no glyphs were produced (e.g., by a zero-width
1416 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1417 buffer positions that will be removed from the glyph row because
1418 they don't fit.
c02dcedf
EZ
1419 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1420 column is beyond frame width: don't subtract 1 "pixel" when
1421 computing width of the stretch.
3e62b7e0
EZ
1422 (reseat_at_next_visible_line_start): Undo the change made on
1423 2011-09-17 that saved paragraph information and restored it after
1424 the call to `reseat'. (Bug#9545)
56cd55c8 1425
5ed99d36 14262011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1427
1428 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1429 and turn window cursor on if cleared (Bug#9415).
1430
5ed99d36 14312011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1432
1433 * search.c (boyer_moore): Take unibyte characters from pattern
1434 literally. (Bug#9458)
1435
9bade7b2
EZ
14362011-09-18 Eli Zaretskii <eliz@gnu.org>
1437
1438 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1439
e5e9d610
PE
14402011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1441
87e4427a
PE
1442 Fix minor problem found by static checking.
1443 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1444 initialized, to pacify gcc -Wuninitialized.
1445
e5e9d610
PE
1446 * fileio.c: Report proper errno when syscall falls.
1447 (Finsert_file_contents): Save and restore errno,
1448 so that report_file_error outputs the correct diagnostic.
1449 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1450
a1674f0b
EZ
14512011-09-18 Eli Zaretskii <eliz@gnu.org>
1452
1453 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1454
fbfb6dd4
EZ
14552011-09-17 Eli Zaretskii <eliz@gnu.org>
1456
1457 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1458 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1459
bb187662
EZ
14602011-09-17 Eli Zaretskii <eliz@gnu.org>
1461
1137e8b8 1462 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1463 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1464
1465 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1466 (bidi_find_paragraph_start): Search back for paragraph beginning
1467 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1468 (bidi_move_to_visually_next): Only trigger paragraph-related
1469 computations when the last character is a newline or at EOB, not
1470 just any NEUTRAL_B. (Bug#9470)
1471
bb187662
EZ
1472 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1473 truncated lines if point is covered by a display string. (Bug#9524)
1474
2e621251
PE
14752011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1478 (cons_to_x_long): New function.
1479 (lisp_data_to_selection_data): Use it. Correct the test for
1480 short-versus-long data; it was negated. Break out of vector
1481 loop, for efficiency, when a long datum is discovered.
1482
91a15bc6
SM
14832011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1484
1485 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1486
b41c3a35
EZ
14872011-09-16 Eli Zaretskii <eliz@gnu.org>
1488
1489 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1490 GCC PR/17406) by declaring this function with external scope.
1491
7812ba2d
PE
14922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1495 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1496
cf7edc2a
AS
14972011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1498
1499 * editfns.c (Fformat): Correctly handle text properties on "%%".
1500
bd01620e
EZ
15012011-09-15 Eli Zaretskii <eliz@gnu.org>
1502
1503 * xterm.c (x_draw_composite_glyph_string_foreground):
1504 * w32term.c (x_draw_composite_glyph_string_foreground):
1505 * term.c (encode_terminal_code):
1506 * composite.c (composition_update_it, get_composition_id):
1507 * xdisp.c (get_next_display_element)
1508 (fill_composite_glyph_string): Add comments about special meaning
1509 of TAB characters in a composition.
1510
a02719a3
PE
15112011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1514 This occurs when processing a multibyte format.
1515 Problem reported by Wolfgang Jenker.
a02719a3 1516
72589a3c
JB
15172011-09-15 Johan Bockgård <bojohan@gnu.org>
1518
1519 * xdisp.c (try_cursor_movement): Only check for exact match if
1520 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1521
1c14176c
PE
15222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 Remove unused external symbols.
1525 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1526 * xdisp.c (calc_pixel_width_or_height): Now static.
1527 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1528 * indent.c (check_display_width):
1529 * w32term.c: Fix comment to match code.
1530 * xterm.c, xterm.h (x_catching_errors): Remove.
1531
d2eea5b5
PE
15322011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1533
1534 * xselect.c: Use signed conversions more consistently (Bug#9498).
1535 (selection_data_to_lisp_data): Assume incoming selection data are
1536 signed integers, not unsigned. This is to be consistent with
1537 outgoing selection data, which was modified to use signed integers
1538 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1539 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1540 expects long, not unsigned long.
1541
46888499
EZ
15422011-09-14 Eli Zaretskii <eliz@gnu.org>
1543
1544 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1545 computation of loop end. Reported by Johan Bockgård
1546 <bojohan@gnu.org>.
1547
ef8ef9fb
CY
15482011-09-13 Chong Yidong <cyd@stupidchicken.com>
1549
1550 * frame.c (Fother_visible_frames_p): Function deleted.
1551
fa819fed
EZ
15522011-09-12 Eli Zaretskii <eliz@gnu.org>
1553
1554 * indent.c (compute_motion): Process display vector front to back
1555 rather than the other way around. (Bug#2496)
1556
2ba8e008
SM
15572011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1558
1559 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1560
20f53c69
CY
15612011-09-11 Chong Yidong <cyd@stupidchicken.com>
1562
1563 * minibuf.c (Fread_from_minibuffer): Doc fix.
1564
d562d7a4
EZ
15652011-09-11 Eli Zaretskii <eliz@gnu.org>
1566
1567 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1568 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1569
1c4d7f3d
LMI
15702011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1571
1572 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1573 value for non-existent files.
1574
b885bf36
EZ
15752011-09-11 Eli Zaretskii <eliz@gnu.org>
1576
1577 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1578 set its "size" to -1. This will set the modtime_size field of
1579 the corresponding buffer to -1, which is what
1580 verify-visited-file-modtime expects for files that do not exist.
1581 (Bug#9139)
1582
6612f0bf
PE
15832011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1586 here ...
1587 * lisp.h: ... from here. push_key_description is no longer
1588 defined in keyboard.c, so its declaration should not be in
1589 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1590 logically belongs with push_key_description.
1591
dfb3f755
PE
15922011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 * buffer.h: Include <sys/types.h> instead of <time.h>.
1595 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1596 Problem reported by Herbert J. Skuhra.
1597
3134906c
LMI
15982011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1599
1600 * xml.c (parse_region): Make the parsing work for
1601 non-comment-starting XML files again (bug#9144).
1602
8d903f4e
AS
16032011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1604
1605 * image.c (gif_load): Fix calculation of bottom and right corner.
1606 (Bug#9468)
1607
80ad64f4
EZ
16082011-09-10 Eli Zaretskii <eliz@gnu.org>
1609
1610 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1611 redisplay in small windows.
1612
208a048d
EZ
16132011-09-09 Eli Zaretskii <eliz@gnu.org>
1614
1615 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1616
9b1c252e
MR
16172011-09-08 Martin Rudalics <rudalics@gmx.at>
1618
1619 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1620 Operate on live windows only.
1621
2949f33b
JB
16222011-09-08 Juanma Barranquero <lekktu@gmail.com>
1623
1624 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1625
e08dcafd
EZ
16262011-09-07 Eli Zaretskii <eliz@gnu.org>
1627
1628 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1629 only under bidi iteration.
1630
115b96bd
JD
16312011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1632
1633 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1634
c8199d0f
PE
16352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1638 Without this fix, the command to link temacs failed due to an
1639 undefined symbol __builtin_isnan. This is because
1640 /usr/include/iso/math_c99.h #defines isnan(x) to
1641 __builtin_isnan(x), but the bundled gcc, which identifies itself
1642 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1643 a __builtin_isnan.
1644 * floatfns.c (isnan): #undef, and then #define to a clone of
1645 what's in data.c.
1646 (Fisnan): Always define, since it's always available now.
1647 (syms_of_floatfns): Always define isnan at the Lisp level.
1648
e39b275c 16492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1650
1651 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1652
b2db44d9 16532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1654
f4af5137 1655 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1656 The previous code assumed that file offsets (off_t values) fit in
1657 EMACS_INT variables, which is not true on typical 32-bit hosts.
1658 The code messed up by falsely reporting buffer overflow in cases
1659 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1660 when "big" contains more than 2**29 bytes, even though this
1661 inserts just one byte and does not overflow the buffer.
1662 (Finsert_file_contents): Store file offsets as off_t
1663 values, not as EMACS_INT values. Check for overflow when
1664 converting between EMACS_INT and off_t. When checking for
1665 buffer overflow or for overlap, take the offsets into account.
1666 Don't use EMACS_INT for small values where int suffices.
1667 When checking for overlap, fix a typo: ZV was used where
1668 ZV_BYTE was intended.
1669 (Fwrite_region): Don't assume off_t fits into 'long'.
1670 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1671
ecfc0a49
MA
16722011-09-05 Michael Albinus <michael.albinus@gmx.de>
1673
1674 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1675
6511acf2 16762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1677
0999621a 1678 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1679
1680 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1681 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1682 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1683 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1684 (modify_event_symbol): Do not assume that the length of
1685 name_alist_or_stem is safe to alloca and fits in int.
1686 (Fexecute_extended_command): Likewise for function name and binding.
1687 (Frecursion_depth): Wrap around reliably on integer overflow.
1688 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1689 since some callers pass EMACS_INT values.
1690 (Fsingle_key_description): Don't crash if symbol name contains more
1691 than MAX_ALLOCA bytes.
1692 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1693 (get_minibuffer): Arg is now EMACS_INT, not int.
1694 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1695 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1696 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1697
2be7d702
PE
1698 * dbusbind.c (signature_cat): New function.
1699 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1700 Do not overrun buffer; instead, report string overflow.
1701
9d1df220
PE
1702 * dispnew.c (add_window_display_history): Don't overrun buffer.
1703 Truncate instead; this is OK since it's just a log.
1704
33ef5c64
PE
1705 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1706 even if the time zone offset is outlandishly large.
1707 Don't mishandle offset == INT_MIN.
1708
66c6fdd5
PE
1709 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1710 when creating daemon; the previous buffer-overflow check was incorrect.
1711
d749b01b
PE
1712 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1713 which has the guts of the old verror function.
1714
b5cd1905
PE
1715 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1716 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1717
6e1a67fb
PE
1718 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1719 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1720 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1721 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1722 length of string rather than counting it via multiple sprintfs;
1723 that's simpler and more reliable.
c21721cc
PE
1724 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1725 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1726 sprintf, in case result does not fit in int.
1727
c57b67fc
PE
1728 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1729 (fontset_from_font): Print it.
1730
8a401434
PE
1731 * frame.c (tty_frame_count): Now printmax_t, not int.
1732 (make_terminal_frame, set_term_frame_name): Print it.
1733 (x_report_frame_params): In X, window IDs are unsigned long,
1734 not signed long, so print them as unsigned.
1735 (validate_x_resource_name): Check for implausibly long names,
1736 and don't assume name length fits in 'int'.
1737 (x_get_resource_string): Don't blindly alloca invocation name;
1738 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1739 not fit in int.
1740
6e1a67fb
PE
1741 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1742 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1743 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1744
0df02bf3
PE
1745 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1746 Use esprintf, not sprintf, in case result does not fit in int.
1747
48e30793
PE
1748 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1749 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1750 it as a large positive number.
1751 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1752 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1753
a66ff6d8
PE
1754 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1755 in case result does not fit in int.
1756
aca216ff
PE
1757 * print.c (float_to_string): Detect width overflow more reliably.
1758 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1759 buffer overrun. Don't assume list length fits in 'int'. Treat
1760 print length of 0 as 0, not as infinity; to be consistent with other
1761 uses of print length in this function. Don't overflow print length
1762 index. Don't assume hash table size fits in 'long', or that
1763 vectorlike size fits in 'unsigned long'.
1764
31c286f7
PE
1765 * process.c (make_process): Use printmax_t, not int, to format
1766 process-name gensyms.
1767
55e5faa1
PE
1768 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1769
80f2e268
PE
1770 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1771 to avoid potential buffer overrun.
1772
670741ab
PE
1773 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1774 if X resource line is longer than 512 bytes.
1775
b7163a50
PE
1776 * xfns.c (x_window): Make sprintf buffer a bit bigger
1777 to avoid potential buffer overrun.
1778
ae58ff1f
PE
1779 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1780
c43c8a6a
PE
1781 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1782
3f8236f4
PE
17832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1784
53e9fe90 1785 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1786 Without these, Emacs silently mishandles large integers sometimes.
1787 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1788 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1789
6511acf2
PE
1790 * xdisp.c (try_window_id): Check Emacs fixnum range before
1791 converting to 'int'.
806add1d 1792
6511acf2 1793 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1794 Check that an Emacs fixnum is in range before assigning it to 'int'.
1795 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1796 values converted from Emacs fixnums.
1797 (Frecenter): Don't wrap around a line count if it is out of 'int'
1798 range; instead, treat it as an extreme value.
1799 (Fset_window_configuration, compare_window_configurations):
1800 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1801
6511acf2
PE
1802 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1803 that can exceed INT_MAX. Check that EMACS_INT value is in range
1804 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1805 (match_limit): Don't assume that a fixnum can fit in 'int'.
1806
6511acf2 1807 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1808 exceed INT_MAX.
1809
6511acf2 1810 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1811 (Fvertical_motion): Don't wrap around LINES values that don't fit
1812 in 'int'. Instead, treat them as extreme values. This is good
1813 enough for windows, which can't have more than INT_MAX lines anyway.
1814
fcb901a7
LMI
18152011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1816
0f2f6b6d
LMI
1817 * Require libxml/parser.h to avoid compilation warning.
1818
fcb901a7
LMI
1819 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1820
1821 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1822 since this reportedly can destroy thread storage.
1823
6e20a0d4
CY
18242011-08-30 Chong Yidong <cyd@stupidchicken.com>
1825
1826 * syntax.c (find_defun_start): Update all cache variables if
1827 exiting early (Bug#9401).
1828
148ae00e
EZ
18292011-08-30 Eli Zaretskii <eliz@gnu.org>
1830
f6cfbd8f
EZ
1831 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1832
148ae00e
EZ
1833 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1834 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1835 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1836
1837 * term.c (tty_append_glyph): New function.
1838 (produce_stretch_glyph): Static function and its prototype deleted.
1839
a66cfb1c
SM
1840 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1841 Add prototypes.
148ae00e 1842
c4a07a4c
PE
18432011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1846 when checking :margin (Bug#9390).
1847 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1848 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1849 so that the name doesn't mislead. All uses changed.
1850
6bc8cd65
JB
18512011-08-28 Johan Bockgård <bojohan@gnu.org>
1852
1853 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1854 set_tty_hooks.
1855
dca4927e
EZ
18562011-08-27 Eli Zaretskii <eliz@gnu.org>
1857
1858 * xdisp.c (move_it_to): Don't bail out early when reaching
1859 position beyond to_charpos, if we are scanning backwards.
1860 (move_it_vertically_backward): When DY == 0, make sure we get to
1861 the first character in the line after the newline.
1862
f2cad773
PE
18632011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1864
1865 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1866 (ccl_driver): Do not generate an out-of-range pointer.
1867 (Fccl_execute_on_string): Remove unnecessary check for
1868 integer overflow, noted by Stefan Monnier in
1869 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1870 Remove a FIXME that didn't need fixing.
1871 Simplify the newly-introduced buffer reallocation code.
1872
0cae2cdb
JB
18732011-08-27 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1876
5fc295a4 18772011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1878
70c60eb2 1879 Integer and memory overflow issues (Bug#9196).
726e0ab1 1880
d31850da
PE
1881 * doc.c (get_doc_string): Rework so that
1882 get_doc_string_buffer_size is the actual buffer size, rather than
1883 being 1 less than the actual buffer size; this makes xpalloc more
1884 convenient.
1885
a69fbedb
PE
1886 * image.c (x_allocate_bitmap_record, cache_image):
1887 * xselect.c (Fx_register_dnd_atom):
1888 Simplify previous changes by using xpalloc.
1889
fe5c5d37
PE
1890 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1891 since either will do and ptrdiff_t is convenient with xpalloc.
1892
0065d054
PE
1893 * charset.c (charset_table_size)
1894 (struct charset_sort_data.priority): Now ptrdiff_t.
1895 (charset_compare): Don't overflow if priorities differ greatly.
1896 (Fsort_charsets): Don't assume list length fits in int.
1897 Check for size-calculation overflow when allocating sort data.
1898 (syms_of_charset): Allocate an initial charset table that is
1899 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1900
1901 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1902
1903 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1904 The actual value is always <= INT_MAX, and leaving it unsigned made
1905 overflow checking harder.
1906
1907 * dispextern.h (struct glyph_matrix.rows_allocated)
1908 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1909 with xpalloc. The values are still always <= INT_MAX.
1910
1911 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1912
1913 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1914 (SAFE_NALLOCA): New macro.
1915
1916 * region-cache.c (struct boundary.pos, find_cache_boundary)
1917 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1918 (set_cache_region, invalidate_region_cache)
1919 (revalidate_region_cache, know_region_cache, region_cache_forward)
1920 (region_cache_backward, pp_cache):
1921 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1922 so that ptrdiff_t * can be passed to xpalloc.
1923 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1924 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1925 (pp_cache): Don't assume cache_len fits in int.
1926 * region-cache.h: Adjust extern decls to match.
1927
1928 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1929 EMACS_INT, since either will do, for xpalloc.
1930
1931 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1932 (xnmalloc, xnrealloc, xpalloc): New functions.
1933
726e0ab1
PE
1934 * bidi.c (bidi_shelve_header_size): New constant.
1935 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1936 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1937
51f30bc5 1938 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1939 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1940 (overlay_strings):
1941 Don't update size of array until after memory allocation succeeds,
1942 because xmalloc/xrealloc may not return.
0065d054
PE
1943 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1944 now that we have proper integer overflow checking.
1945 (record_overlay_string, overlay_strings): Catch overflows when
1946 calculating size of overlay_str_buf.
726e0ab1 1947
0065d054
PE
1948 * callproc.c (Fcall_process): Check for size overflow when
1949 calculating size of args2.
1950 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1951 Normally we prefer signed values, but sticking with ptrdiff_t would
1952 require adding more-complicated checks.
726e0ab1
PE
1953
1954 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1955 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1956 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1957 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1958
1959 * character.c (Fstring): Check for size-calculation overflow.
1960
1961 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1962 unnecessary integer overflow. Check for size overflow.
1963 (encode_coding_object): Don't update size until xmalloc succeeds.
1964
1965 * composite.c (get_composition_id): Check for overflow in glyph
1966 length calculations.
1967
1968 Integer and memory overflow fixes for display code.
1969 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1970 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1971 (scrolling_window): Check for overflow in size calculations.
1972 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1973 Don't assume glyph table len fits in int.
1974 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1975 (row_table_size): Now ptrdiff_t, not int.
1976 (scrolling_window): Avoid overflow in size calculations.
1977 Don't update size until allocation succeeds.
1978 * fns.c (concat): Check for overflow in size calculations.
1979 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1980 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1981 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1982
1983 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1984 (get_doc_string): Check for size calculation overflow.
1985 Don't update size until allocation succeeds.
1986 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1987 EMACS_INT, where ptrdiff_t will do.
1988 (Fsubstitute_command_keys): Check for string overflow.
1989
1990 * editfns.c (set_time_zone_rule): Don't assume environment length
1991 fits in int.
1992 (message_length): Now ptrdiff_t, not int.
1993 (Fmessage_box): Don't update size until allocation succeeds.
1994 Don't assume message length fits in int.
1995 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1996
0065d054
PE
1997 * emacs.c (main): Do not reallocate argv, since there is a null at
1998 the end that can be overwritten, and this way there's no need to
1999 worry about size-calculation overflow.
2000 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2001
2002 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2003 alloc succeeds.
2004 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2005
2006 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2007 (x_set_scroll_bar_width, x_figure_window_size):
2008 Check for integer overflow.
2009 (x_set_alpha): Do not assume XINT fits in int.
2010
2011 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2012 This is for the members text_lines, text_cols, total_lines, total_cols,
2013 where the system imposes an 'int' limit.
2014
2015 * fringe.c (Fdefine_fringe_bitmap):
2016 Don't update size until alloc works.
2017
2018 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2019 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2020
2021 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2022 Check for size-calculation overflow.
2023 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2024 do, as we prefer signed integers.
2025 (id_to_widget.max_size, id_to_widget.used)
2026 (xg_store_widget_in_map, xg_remove_widget_from_map)
2027 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2028 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2029 Use and return ptrdiff_t, not int.
2030 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2031 * gtkutil.h: Change prototypes to match the above.
2032
2033 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2034 are duplicate now that they've been promoted to lisp.h.
2035 (x_allocate_bitmap_record, x_alloc_image_color)
2036 (make_image_cache, cache_image, xpm_load):
2037 Don't update size until alloc is done.
2038 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2039 (x_detect_edges):
3256efce 2040 Check for size calculation overflow.
726e0ab1
PE
2041 (ct_colors_allocated_max): New constant.
2042 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2043 overflow.
3256efce 2044
726e0ab1
PE
2045 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2046 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2047 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2048 Use ptrdiff_t, not int, to count maps.
2049 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2050 calculations. Don't update size until allocation succeeds.
2051 Redo calculations to avoid overflow.
726e0ab1
PE
2052 * keyboard.h: Change prototypes to match the above.
2053
2054 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2055 to count maps.
2056 (current_minor_maps): Check for size calculation overflow.
2057 * keymap.h: Change prototypes to match the above.
2058
2059 * lread.c (read1, init_obarray): Don't update size until alloc done.
2060
2061 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2062 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2063
726e0ab1
PE
2064 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2065 Now ptrdiff_t, not int.
2066 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2067 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2068
2069 * process.c (Fnetwork_interface_list): Check for overflow
2070 in size calculation.
2071
2072 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2073
2074 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2075 overflow. Don't bother calling xmalloc when xrealloc will do.
2076
2077 * search.c (Freplace_match): Check for size calculation overflow.
2078 (Fset_match_data): Don't assume list lengths fit in 'int'.
2079
2080 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2081 for command line length. Do not attempt to address one before the
2082 beginning of an array, as that's not portable.
2083
2084 * term.c (max_frame_lines): Remove; unused.
2085 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2086 not int.
2087 (encode_terminal_code, calculate_costs): Check for size
2088 calculation overflow.
2089 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2090 table lengths and related sizes. Don't update size until alloc
2091 done. Redo calculations to avoid overflow.
2092 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2093
2094 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2095 subtracting pointers.
2096 (gobble_line): Check for overflow more carefully. Don't update size
2097 until alloc done.
2098
2099 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2100 Don't update size until alloc done.
2101 Redo size calculations to avoid overflow.
2102 Check for size calculation overflow.
0065d054 2103 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2104
2105 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2106 Use ptrdiff_t, not int, for sizes.
2107 (store_mode_line_noprop_char): Don't update size until alloc done.
2108
0065d054
PE
2109 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2110 Use ptrdiff_t, not int, for sizes.
2111 (Finternal_make_lisp_face, cache_face):
2112 Check for size calculation overflow.
2113 (cache_face): Treat size calculation overflows as if they were
2114 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2115
2116 * xfns.c (x_encode_text, x_set_name_internal)
2117 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2118 sizes, since they can exceed INT_MAX in size. Check for size
2119 calculation overflow.
2120
0065d054
PE
2121 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2122 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2123 Don't update size until alloc done.
2124
0065d054 2125 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2126 as sprintf is limited to int lengths.
1d526e2f 2127
252c5ee1
PE
2128 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2129 (X_LONG_MIN): New macros.
864d7ce7
PE
2130 Use them to make the following changes clearer.
2131 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2132 This change doesn't affect the value now, but it may help remind
2133 future maintainers not to raise the value too much later.
2134 (SELECTION_QUANTUM): Remove, replacing with ...
2135 (selection_quantum): ... new function, which avoids overflow.
2136 All uses changed.
2137 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2138 assumption that selection length fits in 'int'.
2139 (x_reply_selection_request, x_handle_selection_request)
2140 (x_get_window_property, receive_incremental_selection)
2141 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2142 (lisp_data_to_selection_data, clean_local_selection_data):
2143 Use ptrdiff_t, not int, to record length of selection.
2144 (x_reply_selection_request, x_get_window_property)
2145 (receive_incremental_selection, x_property_data_to_lisp):
2146 Redo calculations to avoid overflow.
2147 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2148 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2149 something.
2150 (x_get_window_property, receive_incremental_selection)
2151 (lisp_data_to_selection_data, x_property_data_to_lisp):
2152 Check for size-calculation overflow.
2153 (x_get_window_property, receive_incremental_selection)
2154 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2155 Don't store size until memory allocation succeeds.
2156 (x_get_window_property): Plug memory leak on memory exhaustion.
2157 Don't double-block input; malloc is safe here. Don't assume 2**34
2158 - 4 fits in unsigned long. Add an xassert to check
2159 XGetWindowProperty overflow. Be more careful about overflow
2160 calculations, and distinguish size from memory overflow better.
2161 (receive_incremental_selection): When tracing, don't assume
2162 unsigned int is less than INT_MAX.
2163 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2164 harmful) conversions of unsigned short to int.
2165 (lisp_data_to_selection_data): Don't assume that integers
2166 in the range -65535 through -1 fit in an X unsigned short.
2167 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2168 result parameters unless successful. Rely on cons_to_unsigned
2169 to report problems with elements; the old code wasn't right anyway.
2170 (x_check_property_data): Check for int overflow; we cannot use
2171 a wider type due to X limits.
2172 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2173
726e0ab1 2174 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2175
0065d054
PE
2176 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2177 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2178 (x_color_cells): Don't store size until memory allocation succeeds.
2179 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2180 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2181 (x_term_init): Don't assume length fits in int (sprintf is limited
2182 to int size).
bc18e09d 2183
ebfa62c0
PE
2184 Use ptrdiff_t for composition IDs.
2185 * character.c (lisp_string_width):
2186 * composite.c (composition_table_size, n_compositions)
2187 (get_composition_id, composition_gstring_from_id):
2188 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2189 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2190 * window.c (Frecenter):
2191 Use ptrdiff_t, not int, for composition IDs.
2192 * composite.c (get_composition_id): Check for integer overflow.
2193 * composite.h: Adjust prototypes to match the above changes.
2194
d3411f89
PE
2195 Use ptrdiff_t for hash table indexes.
2196 * category.c (hash_get_category_set):
2197 * ccl.c (ccl_driver):
2198 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2199 * coding.c (coding_system_charset_list, detect_coding_system):
2200 * coding.h (struct coding_system.id):
2201 * composite.c (get_composition_id, gstring_lookup_cache):
2202 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2203 * image.c (xpm_get_color_table_h):
2204 * lisp.h (hash_lookup, hash_put):
2205 * minibuf.c (Ftest_completion):
2206 Use ptrdiff_t for hash table indexes, not int (which is too
2207 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2208 32-bit --with-wide-int hosts).
2209
e097a6fa
PE
2210 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2211 Add a FIXME comment about memory leaks.
2212 (syms_of_charset): Don't assume xmalloc returns.
2213
5637687f
PE
2214 Don't assume that stated character widths fit in int.
2215 * character.c (Fchar_width, c_string_width, lisp_string_width):
2216 * character.h (CHAR_WIDTH):
2217 * indent.c (MULTIBYTE_BYTES_WIDTH):
2218 Use sanitize_char_width to avoid undefined and/or bad behavior
2219 with outlandish widths.
a66cfb1c 2220 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2221 now that we have two such functions. All uses changed.
2222 (sanitize_char_width): New inline function.
2223
a2271ba2
PE
2224 Don't assume that tab-width fits in int.
2225 * character.h (sanitize_width): New inline function.
2226 (SANE_TAB_WIDTH): New macro.
2227 (ASCII_CHAR_WIDTH): Use it.
2228 * indent.c (sane_tab_width): Remove. All uses replaced by
2229 SANE_TAB_WIDTH (current_buffer).
2230 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2231
18c52557
PE
2232 * fileio.c: Integer overflow issues with file modes.
2233 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2234
caeeedc1
PE
2235 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2236 Remove unreachable code.
2237 (read_hex, load_charset_map_from_file): Check for integer overflow.
2238
50849c52
PE
2239 * xterm.c: don't go over XClientMessageEvent limit
2240 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2241 (x_send_scroll_bar_event): Likewise. Check that the size does not
2242 exceed limits imposed by XClientMessageEvent, as well as the usual
2243 ptrdiff_t and size_t limits.
2244
b13995db
PE
2245 * keyboard.c: Overflow, signedness and related fixes.
2246 (make_lispy_movement): Use same integer type in forward decl
2247 that is used in the definition.
2248 (read_key_sequence, keyremap_step):
2249 Change bufsize argument back to int, undoing my 2011-03-30 change.
2250 We prefer signed types, and int is wide enough here.
2251 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2252 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2253 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2254 length, not size_t. Use ptrdiff_t for index, not int.
2255 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2256 possibility of integer overflow.
2257
13464394
PE
2258 Overflow, signedness and related fixes for images.
2259
2260 * dispextern.h (struct it.stack[0].u.image.image_id)
2261 (struct_it.image_id, struct image.id, struct image_cache.size)
2262 (struct image_cache.used, struct image_cache.ref_count):
2263 * gtkutil.c (update_frame_tool_bar):
2264 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2265 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2266 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2267 * nsmenu.m (update_frame_tool_bar):
2268 * xdisp.c (calc_pixel_width_or_height):
2269 * xfns.c (image_cache_refcount):
2270 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2271 on typical 64-bit hosts.
2272
2273 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2274 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2275 Omit unnecessary casts to int.
2276 (parse_image_spec): Check that integers fall into 'int' range
2277 when the callers expect that.
2278 (image_ascent): Redo ascent calculation to avoid int overflow.
2279 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2280 (lookup_image): Remove unnecessary tests.
2281 (xbm_image_p): Locals are now of int, not EMACS_INT,
2282 since parse_image_check makes sure they fit into int.
2283 (png_load, gif_load, svg_load_image):
2284 Prefer int to unsigned where either will do.
2285 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2286 old tiff_error_handler and tiff_warning_handler.
2287 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2288 stack buffer overflows. It uses only the features of vsnprintf
2289 that are common to both POSIX and native Microsoft.
2290 (tiff_error_handler, tiff_warning_handler): Use it.
2291 (tiff_load, gif_load, imagemagick_load_image):
2292 Don't assume :index value fits in 'int'.
2293 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2294 (imagemagick_load_image): Check that crop parameters fit into
2295 the integer types that MagickCropImage accepts. Don't assume
2296 Vimagemagick_render_type has a nonnegative value. Don't assume
2297 size_t fits in 'long'.
2298 (gs_load): Use printmax_t to print the widest integers possible.
2299 Check for integer overflow when computing image height and width.
2300
c11821d4
EZ
23012011-08-26 Eli Zaretskii <eliz@gnu.org>
2302
2303 * xdisp.c (redisplay_window): Don't force window start if point
2304 will be invisible in the resulting window. (Bug#9324)
2305
0c95fcf7
EZ
23062011-08-25 Eli Zaretskii <eliz@gnu.org>
2307
2308 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2309 the display spec is of the form `(space ...)'.
2310 (handle_display_spec): Return the value returned by
2311 handle_single_display_spec, not just 1 or zero.
2312 (handle_single_display_spec): If the display spec is of the form
2313 `(space ...)', and specifies display in the text area, return 2
2314 rather than 1.
fee65a97 2315 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2316 accurately, and prefer exact match for point under bidi.
2317 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2318
2319 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2320 into disp_prop; all users changed.
2321
2322 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2323 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2324 for the text covered by the display property.
2325
e4ed06f1
CY
23262011-08-25 Chong Yidong <cyd@stupidchicken.com>
2327
2328 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2329 Change return value to nil.
2330 (Frecord_buffer): Delete unused function.
2331
f67cdd7f
EZ
23322011-08-24 Eli Zaretskii <eliz@gnu.org>
2333
5980d4c6
EZ
2334 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2335 buffers, return left-to-right.
8610fe8b
EZ
2336 (set_cursor_from_row): Consider candidate row a win if its glyph
2337 represents a newline and point is on that newline. Fixes cursor
2338 positioning on the newline at EOL of R2L text within L2R
2339 paragraph, and vice versa.
2340 (try_cursor_movement): Check continued rows, in addition to
2341 continuation rows. Fixes unwarranted scroll when point enters a
2342 continued line of R2L text within an L2R paragraph, or vice versa.
2343 (cursor_row_p): Consider the case of point being equal to
2344 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2345 from the end of a short line to the beginning of a continued line
2346 of R2L text within L2R paragraph.
2347 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2348 composed characters.
5980d4c6 2349
f67cdd7f
EZ
2350 * bidi.c (bidi_check_type): Use xassert.
2351 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2352 members.
2353
bca633fb
EZ
23542011-08-23 Eli Zaretskii <eliz@gnu.org>
2355
2356 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2357 a character.
2358
4a5885a7
CY
23592011-08-23 Chong Yidong <cyd@stupidchicken.com>
2360
2361 * nsfont.m (ns_otf_to_script): Fix typo.
2362
0902a04e
KH
23632011-08-22 Kenichi Handa <handa@m17n.org>
2364
2365 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2366 extra slot even if the purpose is char-code-property-table.
2367
1a2e6670
EZ
23682011-08-23 Eli Zaretskii <eliz@gnu.org>
2369
8ddde651
EZ
2370 * xdisp.c (redisplay_window): When computing centering_position,
2371 account for the height of the header line. (Bug#8874)
2372
425cc014
EZ
2373 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2374 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2375 candidate is selected by the mouse, and that candidate has a
2376 composed character under the mouse.
2377
1a2e6670
EZ
2378 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2379 coordinates reported by pos-visible-in-window-p for a composed
2380 character in column zero.
2381
8b76d6f8
SM
23822011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2383
2384 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2385
dac347dd
EZ
23862011-08-22 Eli Zaretskii <eliz@gnu.org>
2387
2388 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2389 consider it a hit if to_charpos is anywhere in the range of the
2390 composed buffer positions.
2391
e013fb34
CY
23922011-08-22 Chong Yidong <cyd@stupidchicken.com>
2393
2394 * image.c (gif_load): Don't assume that each subimage has the same
2395 dimensions as the base image. Handle disposal method that is
2396 "undefined" by the gif spec (Bug#9335).
2397
bd1ba3e8
CY
23982011-08-20 Chong Yidong <cyd@stupidchicken.com>
2399
2400 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2401 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2402
54a1215b
EZ
24032011-08-19 Eli Zaretskii <eliz@gnu.org>
2404
823564e5
EZ
2405 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2406 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2407 from an Org mode buffer to a Speedbar frame.
2408
54a1215b
EZ
2409 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2410 a composition, take its buffer position from IT->cmp_it.charpos.
2411 Fixes cursor positioning at the beginning of a line that begins
2412 with a composed character.
2413
9778ebcc
EZ
24142011-08-18 Eli Zaretskii <eliz@gnu.org>
2415
0be6ee06
EZ
2416 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2417 character bidirectional type, use STRONG_L instead. Fixes crashes
2418 in a buffer produced by `describe-categories'.
2419
9778ebcc
EZ
2420 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2421 members before the level stack, so they would be saved and
2422 restored when copying iterator state. Fixes incorrect reordering
2423 around TABs covered by display properties.
2424
156bffbe
AS
24252011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2426
6b02f655 2427 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2428
72ad093b
CY
24292011-08-17 Chong Yidong <cyd@stupidchicken.com>
2430
2431 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2432 (internal_condition_case_2, internal_condition_case_n):
2433 Remove unnecessary aborts (Bug#9081).
72ad093b 2434
35774242
EZ
24352011-08-17 Eli Zaretskii <eliz@gnu.org>
2436
2437 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2438 has no `load' handler, try opening the file locally. (Bug#9311)
2439
db76dd85
KB
24402011-08-16 Ken Brown <kbrown@cornell.edu>
2441
2442 * gmalloc.c: Expand comment.
2443
b215eee5
EZ
24442011-08-16 Eli Zaretskii <eliz@gnu.org>
2445
2446 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2447 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2448
a4579d33
KB
24492011-08-16 Ken Brown <kbrown@cornell.edu>
2450
2451 Fix memory allocation problems in Cygwin build (Bug#9273).
2452
2453 * unexcw.c ( __malloc_initialized): Declare external variable.
2454 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2455
8b76d6f8
SM
2456 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2457 New variables.
a4579d33
KB
2458 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2459 dumped emacs.
2460 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2461 in the static heap.
2462 [CYGWIN] (special_realloc): New function.
2463 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2464 requests to realloc storage in the static heap.
2465
3ebec551
PE
24662011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2467
2468 * bidi.c (bidi_initialize): Remove unused local.
2469
9fd8be00
EZ
24702011-08-15 Eli Zaretskii <eliz@gnu.org>
2471
6b02f655
SM
2472 * bidimirror.h:
2473 * biditype.h: Remove file.
2474 * makefile.w32-in ($(BLD)/bidi.$(O)):
2475 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2476
2477 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2478
2479 * chartab.c: Improve commentary for the uniprop_table API.
2480
32413314
EZ
2481 * bidi.c (bidi_paragraph_init): Support zero value of
2482 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2483 (bidi_initialize): Use uniprop_table instead of including
2484 biditype.h and bidimirror.h.
32413314 2485
9fd8be00
EZ
2486 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2487 coordinates of the iterator when restoring from ppos_it.
2488 (Bug#9296)
2489
5cf2b69b
KH
24902011-08-14 Kenichi Handa <handa@m17n.org>
2491
2492 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2493 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2494
daf17d00
EZ
24952011-08-14 Eli Zaretskii <eliz@gnu.org>
2496
2497 * xdisp.c (move_it_in_display_line_to): Don't invoke
2498 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2499 ppos_it. Fixes vertical cursor motion when line beginning is
2500 covered by an image. (Bug#9296)
2501
08e3161a
JD
25022011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2503
2504 * nsterm.h (ns_run_ascript): Declare.
2505 (NSAPP_DATA2_RUNASSCRIPT): Define.
2506
2507 * nsfns.m (as_script, as_result, as_status): New static variables.
2508 (ns_run_ascript): New function.
5e617bc2 2509 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2510 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2511 the event loop. Get status from as_status (Bug#7276).
2512
2513 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2514 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2515 the event loop (Bug#7276).
2516
a3720aa2
AS
25172011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2518
2519 * gnutls.c (QCgnutls_bootprop_priority)
2520 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2521 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2522 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2523 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2524 (QCgnutls_bootprop_verify_hostname_error)
2525 (QCgnutls_bootprop_callbacks_verify): Rename from
2526 Qgnutls_bootprop_..., all uses changed.
2527
2528 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2529 uses changed.
2530
0a0d27fb
PE
25312011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2532
19d5c50c
PE
2533 * xfaces.c (Qframe_set_background_mode): Now static.
2534 * dispextern.h (Qframe_set_background_mode): Remove decl.
2535
0a0d27fb
PE
2536 * process.c (Fnetwork_interface_info): Declare local only if needed.
2537
377538cb
JD
25382011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2539
2540 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2541 (Fnetwork_interface_list): Allocate in increments of bytes instead
2542 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2543 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2544 sockaddr.
2545 (struct ifflag_def): notrailers is smart on OSX.
2546 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2547 Get hardware address with getifaddrs if available.
2548
08fff70c
EZ
25492011-08-12 Eli Zaretskii <eliz@gnu.org>
2550
2551 * xdisp.c (iterate_out_of_display_property): xassert that
2552 IT->position is set to within IT->object's boundaries. Break from
2553 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2554 when IT->position is set up wrongly due to some bug.
2555 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2556 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2557 entry. Force push_it to save on the stack the current
2558 buffer/string position, to be restored by pop_it. Fix flags in
2559 the iterator structure wrt the object coming from a display
2560 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2561 properties. (Bug#9284)
2562
7be1c708 25632011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2564
7be1c708
CY
2565 * fontset.c (fontset_get_font_group): Add proper type checks.
2566 (Bug#9172)
aac0c6e3 2567
7be1c708 25682011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2569
7be1c708
CY
2570 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2571 and LC_VERSION_MIN_MACOSX.
2572 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2573 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2574
97bb72a6
EZ
25752011-08-08 Eli Zaretskii <eliz@gnu.org>
2576
2577 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2578 no-display-properties-and-no-overlays under bidi display.
2579 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2580 properties and overlays.
97bb72a6 2581
d5617611
CY
25822011-08-08 Chong Yidong <cyd@stupidchicken.com>
2583
37e11a63
CY
2584 * editfns.c (Fset_time_zone_rule): Document relationship with the
2585 setenv function.
2586
d5617611
CY
2587 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2588 the font entity extracted from the cache (Bug#8109).
2589
58872834
CY
25902011-08-07 Chong Yidong <cyd@stupidchicken.com>
2591
2592 * composite.c (autocmp_chars): Don't reset point. That is done by
2593 restore_point_unwind (Bug#5984).
2594
75bfc667
JL
25952011-08-07 Juri Linkov <juri@jurta.org>
2596
2597 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2598 to show the arg `TIME' instead of `TIMEVAL'.
2599
d1410150
EZ
26002011-08-06 Eli Zaretskii <eliz@gnu.org>
2601
2602 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2603 display property strides EOL and includes a newline, as in
2604 longlines-mode. (Bug#9254)
75b771e4
EZ
2605 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2606 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2607
2608 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2609 is non-zero, even if the data buffer is NULL. Fixes a crash in
2610 vertical-motion with longlines-mode. (Bug#9254)
2611
35928349
EZ
26122011-08-05 Eli Zaretskii <eliz@gnu.org>
2613
ec7cc85b
EZ
2614 * bidi.c <bidi_cache_total_alloc>: Now static.
2615 (bidi_initialize): Initialize bidi_cache_total_alloc.
2616
8b76d6f8 2617 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2618 cache. (Bug#9221)
2619
2620 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2621 amount allocated this far in `bidi_cache_total_alloc'.
2622 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2623 non-zero, only free the data buffer without restoring the cache
2624 contents. All callers changed.
2625
2626 * dispextern.h (bidi_unshelve_cache): Update prototype.
2627
2628 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2629 (move_it_in_display_line, move_it_to)
2630 (move_it_vertically_backward, move_it_by_lines): Replace the call
2631 to xfree to an equivalent call to bidi_unshelve_cache.
2632 (move_it_in_display_line_to): Fix logic of returning
412b6358 2633 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2634
e2e2423b
EZ
26352011-08-05 Eli Zaretskii <eliz@gnu.org>
2636
2637 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2638 came from a string character with a `cursor' property. (Bug#9229)
2639
ae9e757a
JD
26402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2641
2642 * Makefile.in (LIB_PTHREAD): New variable.
2643 (LIBES): Add LIB_PTHREAD (Bug#9216).
2644
2645 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2646 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2647
213bd7f2
AS
26482011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2649
6b02f655 2650 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2651
99aaf75f
JD
26522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2653
2654 * xterm.c (x_find_topmost_parent): New function.
2655 (x_set_frame_alpha): Find topmost parent window with
2656 x_find_topmost_parent and set the property there also (bug#9181).
2657 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2658
c74e9d86
PE
26592011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 * callproc.c (Fcall_process): Avoid vfork clobbering
2662 the local vars buffer, coding_systems, current_dir.
2663
640c8776
SM
26642011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2665
2666 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2667
f26d0e4c
PE
26682011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2669
8a10d76c
PE
2670 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2671 so that it is not optimized away.
2672
f26d0e4c
PE
2673 * xdisp.c (compute_display_string_pos): Remove unused local.
2674
55439c61
EZ
26752011-08-02 Eli Zaretskii <eliz@gnu.org>
2676
2677 Fix slow cursor motion and scrolling in large buffers with
2678 selective display, like Org Mode buffers. (Bug#9218)
2679
2680 * dispextern.h (struct bidi_it): New member disp_prop_p.
2681
2682 * xdisp.c: Remove one-slot cache of display string positions.
2683 (compute_display_string_pos): Accept an additional argument
5e617bc2 2684 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2685 for a display string or property. If found, set DISP_PROP_P
2686 non-zero.
2687
2688 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2689 DISP_PROP_P, and pass it to compute_display_string_pos.
2690 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2691 non-zero. All callers of bidi_fetch_char changed.
2692
fb33fa43
SM
26932011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2694
2695 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2696
b099e063
DM
26972010-12-03 Don March <don@ohspite.net>
2698
2699 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2700 last character M-[char] is translated to ESC [char] (bug#7541).
2701
5cc7f7af
KH
27022011-08-02 Kenichi Handa <handa@m17n.org>
2703
d0fffa3f 2704 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2705
2706 * chartab.c (uniprop_table): Make it non-static.
2707
525d5e6e
EZ
27082011-08-01 Eli Zaretskii <eliz@gnu.org>
2709
2710 * xdisp.c (forward_to_next_line_start): Accept additional argument
2711 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2712 on the newline.
2713 (reseat_at_next_visible_line_start): Use the bidi iterator state
2714 returned by forward_to_next_line_start to restore the state of
2715 it->bidi_it after backing up to previous newline. (Bug#9212)
2716
31011111
AS
27172011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2718
2719 * regex.c (re_comp): Protoize.
2720 (re_exec): Fix return type.
2721 (regexec): Fix type of `ret'. (Bug#9203)
2722
476371c4
PE
27232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2724
e5d76069
PE
2725 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2726 This is needed if max-image-size is a floating-point number.
2727
9a79b20c
AS
27282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2729
2730 * print.c (print_object): Print empty symbol as ##.
2731
2732 * lread.c (read1): Read ## as empty symbol.
2733
d8c2fa78
AA
27342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2735
2736 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2737 setting frame foreground color (Bug#9175).
2738 (x_set_background_color): Likewise.
2739
ffe57a7a
AA
2740 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2741 contents (Bug#9176).
2742 (EmacsTooltip -init): Remove bezels and add shadows to
2743 tooltip windows.
2744
bf3492a5
AA
2745 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2746 or scroll bar (Bug#8470).
2747
d55e9c53
AA
2748 * nsfont.m (nsfont_open): Remove assignment to voffset and
2749 unnecessary vars hshink, expand, hd, full_height, min_height.
2750 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2751
2752 * nsterm.h (nsfont_info): Remove voffset field.
2753
d8c2fa78 27542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2755
2756 Implement strike-through and overline on NextStep (Bug#8863).
2757
2758 * nsfont.m (nsfont_open): Use underline position provided by font,
2759 instead of hard-coded value of 2.
2760 (nsfont_draw): Call ns_draw_text_decoration instead.
2761
2762 * nsterm.h: Add declaration for ns_draw_text_decoration.
2763
2764 * nsterm.m (ns_draw_text_decoration): New function for drawing
2765 underline, overline, and strike-through.
2766 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2767 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2768 accommodate underlining, etc.
4843aac3 2769
4cc60b9b
EZ
27702011-07-28 Eli Zaretskii <eliz@gnu.org>
2771
bc7ece87
EZ
2772 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2773 default.
4cc60b9b 2774
476371c4
PE
27752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2776
66606eea
PE
2777 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2778 Without this fix, if a signal arrives just after memory fills up,
2779 'malloc' might be invoked reentrantly.
2780
476371c4
PE
2781 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2782 In other words, assume that every image size is allowed, on non-X
2783 hosts. This assumption is probably wrong, but it lets Emacs compile.
2784
f3fcc40d
AS
27852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2786
2787 * regex.c (re_iswctype): Convert return values to boolean.
2788
350c992f
EZ
27892011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2790
2791 * xdisp.c (compute_display_string_pos): Don't use cached display
2792 string position if the buffer had its restriction changed.
2793 (Bug#9184)
2794
5266b4bb
PE
27952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2796
2797 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2798
2573a837 27992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2800
41f55ccd 2801 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2802
39e378da
PE
2803 * bidi.c: Integer size and overflow fixes.
2804 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2805 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2806 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2807 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2808 (bidi_find_other_level_edge):
2809 Use ptrdiff_t instead of EMACS_INT where either will do.
2810 This works better on 32-bit hosts configured --with-wide-int.
2811 (bidi_cache_ensure_space): Check for size-calculation overflow.
2812 Use % rather than repeated addition, for better worst-case speed.
2813 Don't set bidi_cache_size until after xrealloc returns, because it
2814 might not return.
2815 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2816 (bidi_cache_ensure_space): Also check that the bidi cache size
2817 does not exceed that of the largest Lisp string or buffer. See Eli
2818 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2819
5e927815
PE
2820 * alloc.c (__malloc_size_t): Remove.
2821 All uses replaced by size_t. See Andreas Schwab's note
2822 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2823
ca4aa935
PE
2824 * image.c: Improve checking for integer overflow.
2825 (check_image_size): Assume that f is nonnull, since
2826 it is always nonnull in practice. This is one less thing to
2827 worry about when checking for integer overflow later.
2828 (x_check_image_size): New function, which checks for integer
2829 overflow issues inside X.
2830 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2831 This removes the need for a memory_full check.
2832 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2833 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2834 (xbm_read_bitmap_data): Change locals back to 'int', since
2835 their values must fit in 'int'.
2836 (xpm_load_image, png_load, tiff_load):
2837 Invoke x_create_x_image_and_pixmap earlier,
2838 to avoid much needless work if the image is too large.
2839 (tiff_load): Treat overly large images as if
2840 x_create_x_image_and_pixmap failed, not as malloc failures.
2841 (gs_load): Use x_check_image_size.
2842
5f8f9cc2
PE
2843 * gtkutil.c: Omit integer casts.
2844 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2845 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2846
5adf60bc
PE
2847 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2848
c8907a93
PE
2849 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2850 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2851 would wrongly return t on a 64-bit host.
2852
e3c25c68
PE
2853 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2854 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2855 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2856 and therefore cause GCC to emit a bogus diagnostic in some cases.
2857
3f791afe
PE
2858 * image.c: Integer signedness and overflow and related fixes.
2859 This is not an exhaustive set of fixes, but it's time to
2860 record what I've got.
2861 (lookup_pixel_color, check_image_size): Remove redundant decls.
2862 (check_image_size): Don't assume that arbitrary EMACS_INT values
2863 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2864 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2865 (tiff_load, imagemagick_load_image):
2866 Check for overflow in size calculations.
2867 (x_create_x_image_and_pixmap): Remove unnecessary test for
2868 xmalloc returning NULL; that can't happen.
2869 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2870 (xpm_color_bucket): Use better integer hashing function.
2871 (xpm_cache_color): Don't possibly over-allocate memory.
2872 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2873 (gif_memory_source):
2874 Use ptrdiff_t, not int or size_t, to record sizes.
2875 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2876 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2877 either works, as we prefer signed integers.
2878 (tiff_read_from_memory, tiff_write_from_memory):
2879 Return tsize_t, not size_t, since that's what the TIFF API wants.
2880 (tiff_read_from_memory): Don't fail simply because the read would
2881 go past EOF; instead, return a short read.
2882 (tiff_load): Omit no-longer-needed casts.
2883 (Fimagemagick_types): Don't assume size fits into 'int'.
2884
3cc5a532
PE
2885 Improve hashing quality when configured --with-wide-int.
2886 * fns.c (hash_string): New function, taken from sxhash_string.
2887 Do not discard information about ASCII character case; this
2888 discarding is no longer needed.
2889 (sxhash-string): Use it. Change sig to match it. Caller changed.
2890 * lisp.h: Declare it.
2891 * lread.c (hash_string): Remove, since we now use fns.c's version.
2892 The fns.c version returns a wider integer if --with-wide-int is
2893 specified, so this should help the quality of the hashing a bit.
2894
b312a492
PE
2895 * emacs.c: Integer overflow minor fix.
2896 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2897 Define only if GNU_LINUX.
2898 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2899
dfd153ae
PE
2900 * dispnew.c: Integer signedness and overflow fixes.
2901 Remove unnecessary forward decls, that were a maintenance hassle.
2902 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2903 All uses changed.
2904 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2905 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2906 (prepare_desired_row, line_draw_cost):
2907 Use int, not unsigned, where either works.
2908 (save_current_matrix, restore_current_matrix):
2909 Use ptrdiff_t, not size_t, where either works.
2910 (init_display): Check for overflow more accurately, and without
2911 relying on undefined behavior.
2912
a81d11a3
PE
2913 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2914 Remove, replacing with the new symbols in lisp.h. All uses changed.
2915 * fileio.c (make_temp_name):
2916 * filelock.c (lock_file_1, lock_file):
2917 * xdisp.c (message_dolog):
2918 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2919 Use pMd etc. instead.
2920 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2921 replacing the pWIDE etc. symbols removed from editfns.c.
2922
3300e6fd
PE
2923 * keyboard.h (num_input_events): Now uintmax_t.
2924 This is (very slightly) less likely to mess up due to wraparound.
2925 All uses changed.
2926
fd05c7e9
PE
2927 * buffer.c: Integer signedness fixes.
2928 (alloc_buffer_text, enlarge_buffer_text):
2929 Use ptrdiff_t rather than size_t when either will do, as we prefer
2930 signed integers.
2931
903fe15d
PE
2932 * alloc.c: Integer signedness and overflow fixes.
2933 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2934 (__malloc_size_t): Default to size_t, not to int.
2935 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2936 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2937 Prefer ptrdiff_t to size_t when either would do, as we prefer
2938 signed integers.
2939 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2940 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2941 Now const. Initialize with values that are in range even if char
2942 is signed.
2943 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2944 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2945 These functions do the right thing with sizes > 2**32.
2946 (check_depth): Now ptrdiff_t, not int.
2947 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2948 Adjust to new way of storing sizes. Check for size overflow bugs
2949 in rest of code.
2950 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2951 slightly wrong anyway, as it missed one instance of
2952 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2953 (refill_memory_reserve): Omit needless cast to size_t.
2954 (mark_object_loop_halt): Mark as externally visible.
2955
ac82cc6a
PE
2956 * xselect.c: Integer signedness and overflow fixes.
2957 (Fx_register_dnd_atom, x_handle_dnd_message):
2958 Use ptrdiff_t, not size_t, since we prefer signed.
2959 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2960 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2961 x_dnd_atoms_size and x_dnd_atoms_length.
2962
c2d1e36d
PE
2963 * doprnt.c: Prefer signed to unsigned when either works.
2964 * eval.c (verror):
2965 * doprnt.c (doprnt):
2966 * lisp.h (doprnt):
2967 * xdisp.c (vmessage):
2968 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2969 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2970 prefer signed arithmetic to avoid comparison confusion.
2971 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2972 but is a bit tricky.
2973
0e926e56
PE
2974 Assume freestanding C89 headers, string.h, stdlib.h.
2975 * data.c, doprnt.c, floatfns.c, print.c:
2976 Include float.h unconditionally.
2977 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2978 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2979 * regex.c: Likewise for stddef.h, string.h.
2980 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2981 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2982 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2983 (STDC_HEADERS): Remove obsolete defines.
2984 * sysdep.c: Include limits.h unconditionally.
2985
9cfdb3ec
PE
2986 Assume support for memcmp, memcpy, memmove, memset.
2987 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2988 * regex.c (memcmp, memcpy):
2989 Remove; we assume C89 now.
2990
2991 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2992 (__malloc_safe_bcopy): Remove; no longer needed.
2993
cf950e6b 2994 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2995 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2996 well either way, and we prefer signed to unsigned.
2997
dbf38e02
LMI
29982011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2999
3000 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3001 closes the connection while we're reading (bug#9182).
3002
d6f0886c 30032011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3004
d6f0886c
JD
3005 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3006 are specified (Bug#9168).
24e0f6b1 3007
2eb1f9e6
PE
30082011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3009
3010 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3011 Found by GCC static checking and --with-wide-int on a 32-bit host.
3012
22381272 30132011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3014
3015 * xdisp.c (compute_display_string_pos): Fix logic of caching
3016 previous display string position. Initialize cached_prev_pos to
3017 -1. Fixes slow-down at the beginning of a buffer.
3018
f25e39b4
EZ
30192011-07-24 Eli Zaretskii <eliz@gnu.org>
3020
3021 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3022 for attrs[LFACE_FONTSET_INDEX].
3023
04c4b52e
PE
30242011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3025
3026 * xml.c (parse_region): Remove unused local
3027 that was recently introduced.
3028
c1734fbd
EZ
30292011-07-23 Eli Zaretskii <eliz@gnu.org>
3030
be18c5a5
EZ
3031 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3032 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3033
c1734fbd
EZ
3034 * xdisp.c (move_it_in_display_line_to): Record the best matching
3035 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3036 exit if none of the characters scanned was an exact match.
3037 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3038 when exact match is impossible due to invisible text, and the
3039 lines are truncated.
3040
a258d627
JD
30412011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3042
3043 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3044 for OSX >= 10.7.
3045
b6d5a689
EZ
30462011-07-22 Eli Zaretskii <eliz@gnu.org>
3047
0f74f785
EZ
3048 Fix a significant slow-down of cursor motion with C-n, C-p,
3049 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3050 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3051 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3052 (next_element_from_buffer): Call compute_stop_pos_backwards to
3053 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3054 base_level_stop.
3055 (reseat): Don't look for prev_stop, as that could mean a very long
3056 run.
3057 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3058 <cached_disp_overlay_modiff>: Cache for last found display string
3059 position.
551918c1 3060 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3061 about the same buffer in the same area of character positions, and
3062 the buffer wasn't changed since the time the display string
3063 position was cached.
551918c1 3064
b2d0c91a
EZ
30652011-07-22 Eli Zaretskii <eliz@gnu.org>
3066
3067 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3068 is an integer, which is important for empty lines. (Bug#9149)
3069
043604ee
CY
30702011-07-22 Chong Yidong <cyd@stupidchicken.com>
3071
3072 * frame.c (Fmodify_frame_parameters): In tty case, update the
3073 default face if necessary (Bug#4238).
3074
da4adb04
CY
30752011-07-21 Chong Yidong <cyd@stupidchicken.com>
3076
3077 * editfns.c (Fstring_to_char): No need to explain what a character
3078 is in the docstring (Bug#6576).
3079
9abd0532
LMI
30802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3081
3082 * xml.c (parse_region): Make sure we always return a tree.
3083
36881d16
HK
30842011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3085
3086 * xml.c (parse_region): If a document contains only comments,
3087 return that, too.
3088
1e98674d
LMI
30892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3090
3091 * xml.c (make_dom): Return comments, too.
3092
590bd467
PE
30932011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3094
3095 Port to OpenBSD.
3096 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3097 and the surrounding thread.
3098 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3099 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3100 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3101 timer goes off.
3102 * s/openbsd.h (BROKEN_SIGIO): Define.
3103 * unexelf.c (unexec) [__OpenBSD__]:
3104 Don't update the .mdebug section of the Alpha COFF symbol table.
3105
f41628b2
LMI
31062011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3107
3108 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3109 (bug#8460).
3110
b59b67c5
PE
31112011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3112
15e3a074
PE
3113 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3114 This fixes some race conditions on the permissions of any newly
3115 created file.
3116
41bed37d
PE
3117 * alloc.c (valid_pointer_p): Use pipe, not open.
3118 This fixes some permissions issues when debugging.
3119
b59b67c5
PE
3120 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3121 If fchown fails to set both uid and gid, try to set just gid,
3122 as that is sometimes allowed. Adjust the file's mode to eliminate
3123 setuid or setgid bits that are inappropriate if fchown fails.
3124
925a6be7
SM
31252011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3126
3127 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3128 to compare Lisp_Objects.
3129 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3130 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3131 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3132
52968808
AS
31332011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3134
0a6a104b
AS
3135 * lread.c (read_integer): Unread even EOF character.
3136 (read1): Likewise. Properly record start position of symbol.
3137
52968808
AS
3138 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3139 symbol character follows.
3140
9e381cdd
PE
31412011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3144 This works around a problem with the previous change to Fcopy_file.
3145 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3146 and without this change, GCC might complain about discarding
3147 fchown's return value.
3148
b5641435
JB
31492011-07-16 Juanma Barranquero <lekktu@gmail.com>
3150
3151 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3152
a8031457
PE
31532011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3154
3155 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3156
dd889327
LMI
31572011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3158
750c33f7
LMI
3159 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3160 it's used from the C level.
3161
dd889327
LMI
3162 * process.c: Use the same condition for POLL_FOR_INPUT in both
3163 keyboard.c and process.c (bug#1858).
3164
87e86684
LM
31652011-07-09 Lawrence Mitchell <wence@gmx.li>
3166
3167 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3168 (Fgnutls_boot): Use it.
3169
64348f40
AS
31702011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3171
3172 * doc.c (Fsubstitute_command_keys): Revert last change.
3173
1d698799
LMI
31742011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3175
f863868c
LMI
3176 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3177 quotes the next character, and doesn't affect other longer
3178 sequences (bug#8935).
3179
1d698799
LMI
3180 * lread.c (syms_of_lread): Clarify that is isn't only
3181 `eval-buffer' and `eval-defun' that's affected by
3182 `lexical-binding' (bug#8460).
3183
aa4b6df6
EZ
31842011-07-15 Eli Zaretskii <eliz@gnu.org>
3185
3186 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3187 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3188
5d856da6
PE
31892011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3190
ad6042bb
PE
3191 Fix minor problems found by static checking.
3192 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3193 (elsz): Now a signed constant, not a size_t var. We prefer signed
3194 types to unsigned, to avoid integer comparison confusion. Without
3195 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3196 "cannot optimize loop, the loop counter may overflow", a symptom
3197 of the confusion.
f00bbb22 3198 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3199 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3200
6468f31c
LMI
32012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3202
49080b10
LMI
3203 * search.c (Fre_search_backward): Mention `case-fold-search' in
3204 all the re_search_* functions (bug#8138).
3205
6468f31c
LMI
3206 * keyboard.c (Fopen_dribble_file): Document when the file is
3207 closed (bug#8056).
3208
c965adc5
EZ
32092011-07-14 Eli Zaretskii <eliz@gnu.org>
3210
df9733bf
EZ
3211 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3212 bidi_cache_idx.
3213
0bb23927
EZ
3214 Support bidi reordering of display and overlay strings.
3215 * xdisp.c (compute_display_string_pos)
3216 (compute_display_string_end): Accept additional argument STRING.
3217 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3218 (reseat_to_string): Initialize bidi_it->string.s and
3219 bidi_it->string.schars.
3220 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3221 NULL (avoids a crash in bidi_paragraph_init).
3222 Initialize itb.string.lstring.
0bb23927
EZ
3223 (init_iterator): Call bidi_init_it only of a valid
3224 buffer position was specified. Initialize paragraph_embedding to
3225 L2R.
3226 (reseat_to_string): Initialize the bidi iterator.
3227 (display_string): If we need to ignore text properties of
3228 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3229 original value of -1 will not work with bidi.)
3230 (compute_display_string_pos): First arg is now struct
3231 `text_pos *'; all callers changed. Support display properties on
3232 Lisp strings.
3233 (compute_display_string_end): Support display properties on Lisp
3234 strings.
3235 (init_iterator, reseat_1, reseat_to_string): Initialize the
3236 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3237 when iterating on a string not from display properties).
640c8776
SM
3238 (compute_display_string_pos, compute_display_string_end):
3239 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3240 arrow keys.
3241 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3242 base_level_stop; instead, set base_level_stop to BEGV.
3243 Fixes crashes in vertical-motion.
0bb23927
EZ
3244 (next_element_from_buffer): Improve commentary for when
3245 the iterator is before prev_stop.
3246 (init_iterator): Initialize bidi_p from the default value of
3247 bidi-display-reordering, not from buffer-local value. Use the
3248 buffer-local value only if initializing for buffer iteration.
3249 (handle_invisible_prop): Support invisible properties on strings
3250 that are being bidi-reordered.
3251 (set_iterator_to_next): Support bidi reordering of C strings and
3252 Lisp strings.
3253 (next_element_from_string): Support bidi reordering of Lisp
3254 strings.
3255 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3256 (display_string): Support display of R2L glyph rows.
3257 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3258 (init_iterator): Don't initialize it->bidi_p for strings
3259 here.
3260 (reseat_to_string): Initialize it->bidi_p for strings here.
3261 (next_element_from_string, next_element_from_c_string)
3262 (next_element_from_buffer): Add xassert's for correspondence
3263 between IT's object being iterated and it->bidi_it.string
3264 structure.
3265 (face_before_or_after_it_pos): Support bidi iteration.
3266 (next_element_from_c_string): Handle the case of the first string
3267 character that is not the first one in the visual order.
3268 (get_visually_first_element): New function, refactored from common
3269 parts of next_element_from_buffer, next_element_from_string, and
3270 next_element_from_c_string.
3271 (tool_bar_lines_needed, redisplay_tool_bar)
3272 (display_menu_bar): Force left-to-right direction. Add a FIXME
3273 comment for making that be controlled by a user option.
3274 (push_it, pop_it): Save and restore the state of the
3275 bidi iterator. Save and restore the bidi_p flag.
3276 (pop_it): Iterate out of display property for string iteration as
3277 well.
3278 (iterate_out_of_display_property): Support iteration over strings.
3279 (handle_single_display_spec): Set up it->bidi_it for iteration
3280 over a display string, and call bidi_init_it.
3281 (handle_single_display_spec, next_overlay_string)
3282 (get_overlay_strings_1, push_display_prop): Set up the bidi
3283 iterator for displaying display or overlay strings.
3284 (forward_to_next_line_start): Don't use the shortcut if
3285 bidi-iterating.
3286 (back_to_previous_visible_line_start): If handle_display_prop
3287 pushed the iterator stack, restore the internal state of the bidi
3288 iterator by calling bidi_pop_it same number of times.
3289 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3290 and we are bidi-iterating, don't decrement the iterator position;
3291 instead, set the first_elt flag in the bidi iterator, to produce
3292 the same effect.
3293 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3294 (push_display_prop): xassert that we are iterating a buffer.
3295 (push_it, pop_it): Save and restore paragraph_embedding member.
3296 (handle_single_display_spec, next_overlay_string)
3297 (get_overlay_strings_1, reseat_1, reseat_to_string)
3298 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3299 correctly. Don't assume unibyte strings are not bidi-reordered.
3300 (compute_display_string_pos)
3301 (compute_display_string_end): Fix handling the case of C string.
3302 (push_it, pop_it): Save and restore from_disp_prop_p.
3303 (handle_single_display_spec, push_display_prop): Set the
3304 from_disp_prop_p flag.
3305 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3306 (pop_it): Call iterate_out_of_display_property only if we are
3307 popping after iteration over a string that came from a display
3308 property. Fix a typo in popping stretch info. Add an assertion
3309 for verifying that the iterator position is in sync with the bidi
3310 iterator.
3311 (handle_single_display_spec, get_overlay_strings_1)
3312 (push_display_prop): Fix initialization of paragraph direction for
3313 string when that of the parent object is not yet determined.
3314 (reseat_1): Call bidi_init_it to resync the bidi
3315 iterator with IT's position. (Bug#7616)
3316 (find_row_edges): If ROW->start.pos gives position
3317 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3318 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3319 Reset the from_disp_prop_p flag.
3320 (SAVE_IT, RESTORE_IT): New macros.
3321 (pos_visible_p, face_before_or_after_it_pos)
3322 (back_to_previous_visible_line_start)
3323 (move_it_in_display_line_to, move_it_in_display_line)
3324 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3325 (try_scrolling, redisplay_window, display_line): Use them when
3326 saving a temporary copy of the iterator and restoring it back.
3327 (back_to_previous_visible_line_start, reseat_1)
3328 (init_iterator): Empty the bidi cache "stack".
3329 (move_it_in_display_line_to): If iterator ended up at
3330 EOL, but we never saw any buffer positions smaller than
3331 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3332 motion in bidi-reordered lines.
3333 (move_it_in_display_line_to): Record prev_method and prev_pos
3334 immediately before the call to set_iterator_to_next. Fixes cursor
3335 motion in bidi-reordered lines with stretch glyphs and strings
3336 displayed in margins. (Bug#8133) (Bug#8867)
3337 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3338 TO_CHARPOS.
640c8776
SM
3339 (pos_visible_p): Support positions in bidi-reordered lines.
3340 Save and restore bidi cache.
0bb23927
EZ
3341
3342 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3343 (bidi_paragraph_info): Delete unused struct.
3344 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3345 (bidi_cache_start): New variable.
3346 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3347 to zero.
3348 (bidi_cache_fetch_state, bidi_cache_search)
3349 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3350 (bidi_cache_find, bidi_peek_at_next_level)
3351 (bidi_level_of_next_char, bidi_find_other_level_edge)
3352 (bidi_move_to_visually_next): Compare cache index with
3353 bidi_cache_start rather than with zero.
3354 (bidi_fetch_char): Accept new argument STRING; all callers
3355 changed. Support iteration over a string. Support strings with
3356 display properties. Support unibyte strings. Fix the type of
3357 `len' according to what STRING_CHAR_AND_LENGTH expects.
3358 (bidi_paragraph_init, bidi_resolve_explicit_1)
3359 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3360 (bidi_level_of_next_char, bidi_move_to_visually_next):
3361 Support iteration over a string.
0bb23927
EZ
3362 (bidi_set_sor_type, bidi_resolve_explicit_1)
3363 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3364 can now be zero (for strings); special values 0 and -1 were
3365 changed to -1 and -2, respectively.
3366 (bidi_char_at_pos): New function.
3367 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3368 Call it instead of FETCH_MULTIBYTE_CHAR.
3369 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3370 initialized to valid values.
3371 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3372 values.
3373 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3374 the test for valid cached positions. Fix the logic for looking up
3375 the sentinel state in the cache. GCPRO the Lisp string we are
3376 iterating.
3377 (bidi_push_it, bidi_pop_it): New functions.
3378 (bidi_initialize): Initialize the bidi cache start stack pointer.
3379 (bidi_cache_ensure_space): New function, refactored from part of
3380 bidi_cache_iterator_state. Don't assume the required size is just
3381 one BIDI_CACHE_CHUNK away.
3382 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3383 (bidi_count_bytes, bidi_char_at_pos): New functions.
3384 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3385 always valid if bidi_cache_idx is valid.
3386 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3387 is valid if it's going to be used.
3388 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3389 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3390 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3391 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3392 (bidi_find_other_level_edge, bidi_cache_start_stack):
3393 All variables related to cache indices are now EMACS_INT.
c965adc5 3394
0bb23927
EZ
3395 * dispextern.h (struct bidi_string_data): New structure.
3396 (struct bidi_it): New member `string'. Make flag members be 1-bit
3397 fields, and put them last in the struct.
640c8776
SM
3398 (compute_display_string_pos, compute_display_string_end):
3399 Update prototypes.
0bb23927
EZ
3400 (bidi_push_it, bidi_pop_it): Add prototypes.
3401 (struct iterator_stack_entry): New members bidi_p,
3402 paragraph_embedding, and from_disp_prop_p.
3403 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3404 (bidi_shelve_cache, bidi_unshelve_cache):
3405 Declare prototypes.
0bb23927
EZ
3406
3407 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3408 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3409 and vector-like objects.
3410
3411 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3412 cache around display iteration.
3413
3414 * window.c (Fwindow_end, window_scroll_pixel_based)
3415 (displayed_window_lines, Frecenter): Save and restore the bidi
3416 cache around display iteration.
3417
3bbd2265
LMI
34182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3419
3420 * editfns.c (Fdelete_region): Clarify the use of the named
3421 parameters (bug#6788).
3422
adc47434
MR
34232011-07-14 Martin Rudalics <rudalics@gmx.at>
3424
3425 * indent.c (Fvertical_motion): Set and restore w->pointm when
3426 saving and restoring the window's buffer (Bug#9006).
3427
837c31f8
LMI
34282011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3429
3430 * editfns.c (Fstring_to_char): Clarify just what is returned
3431 (bug#6576). Text by Eli Zaretskii.
3432
ac389d0c
JB
34332011-07-13 Juanma Barranquero <lekktu@gmail.com>
3434
3435 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3436
0be0ce47
EZ
34372011-07-13 Eli Zaretskii <eliz@gnu.org>
3438
3439 * buffer.c (mmap_find): Fix a typo.
3440
cd18e7e3
JB
34412011-07-13 Johan Bockgård <bojohan@gnu.org>
3442
3443 Fix execution of x selection hooks.
3444 * xselect.c (Qx_lost_selection_functions)
3445 (Qx_sent_selection_functions): New vars.
3446 (syms_of_xselect): DEFSYM them.
3447 (x_handle_selection_request): Pass Qx_sent_selection_functions
3448 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3449 (x_handle_selection_clear,x_clear_frame_selections):
3450 Pass Qx_lost_selection_functions rather than
3451 Vx_lost_selection_functions to Frun_hook_with_args.
3452
47ea7f44
PE
34532011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3454
ac389d0c 3455 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3456 The old code sometimes used this field without initializing it.
3457
47ea7f44
PE
3458 * alloc.c (gc_sweep): Don't read past end of array.
3459 In theory, the old code could also have corrupted Emacs internals,
3460 though it'd be very unlikely.
3461
bc985c87
AS
34622011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3463
3464 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3465 argument. (Bug#4026)
bc985c87 3466
0cf34688
LMI
34672011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3468
b3dadd76
LMI
3469 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3470 key" (bug#4257).
3471
0cf34688
LMI
3472 * window.c (Fset_window_start): Doc fix (bug#4199).
3473 (Fset_window_hscroll): Ditto.
3474
270768cd
PE
34752011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3476
077e3dda 3477 Fix minor new problems caught by GCC 4.6.1.
270768cd 3478 * term.c (init_tty): Remove unused local.
490011a6 3479 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3480 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3481 not used otherwise.
270768cd 3482
b1f58454
CY
34832011-07-12 Chong Yidong <cyd@stupidchicken.com>
3484
3485 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3486
22b9578d
LMI
34872011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3488
6e70ab07
LMI
3489 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3490 are the mini-buffer and the echo area (bug#3320).
3491
22b9578d
LMI
3492 * term.c (init_tty): Remove support for supdup, c10 and perq
3493 terminals, which are no longer supported (bug#1482).
3494
8974cc9f
JB
34952011-07-10 Johan Bockgård <bojohan@gnu.org>
3496
3497 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3498
a560d974
JD
34992011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3500
3501 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3502 for non-popups (Bug#3642).
3503
1dae0f0a
AS
35042011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3505
268c2c36 3506 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3507 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3508 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3509 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3510 * data.c (fmod): Likewise.
3511 * dispnew.c (swap_glyphs_in_rows): Likewise.
3512 * emacs.c (memory_warning_signal): Likewise.
3513 * floatfns.c (float_error): Likewise.
3514 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3515 (otf_open, font_otf_capability, generate_otf_features)
3516 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3517 Likewise.
3518 * image.c (pbm_read_file): Likewise.
3519 * indent.c (string_display_width): Likewise.
3520 * intervals.c (check_for_interval, search_for_interval)
3521 (inc_interval_count, count_intervals, root_interval)
3522 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3523 * lread.c (defalias): Likewise.
268c2c36 3524 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3525 * regex.c (set_image_of_range_1, set_image_of_range)
3526 (regex_grow_registers): Likewise.
3527 * sysdep.c (strerror): Likewise.
3528 * termcap.c (valid_filename_p, tprint, main): Likewise.
3529 * tparam.c (main): Likewise.
3530 * unexhp9k800.c (run_time_remap, save_data_space)
3531 (update_file_ptrs, read_header, write_header, calculate_checksum)
3532 (copy_file, copy_rest, display_header): Likewise.
3533 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3534 Likewise.
3535 * xdisp.c (check_it): Likewise.
3536 * xfaces.c (register_color, unregister_color, unregister_colors):
3537 Likewise.
3538 * xfns.c (print_fontset_result): Likewise.
3539 * xrdb.c (member, fatal, main): Likewise.
3540
99033785
PE
35412011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 Fix minor problems found by static checking (Bug#9031).
3544 * chartab.c (char_table_set_range, map_sub_char_table):
3545 Remove unused locals.
3546 (uniprop_table): Now static.
3547 * composite.c (_work_char): Remove unused static var.
3548
9cb2ac56
JB
35492011-07-09 Juanma Barranquero <lekktu@gmail.com>
3550
3551 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3552
f25661f0
JD
35532011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3554
3555 * gtkutil.c (qttip_cb): Remove code without function.
3556
8278c4fe
EZ
35572011-07-09 Eli Zaretskii <eliz@gnu.org>
3558
3559 * w32.c (pthread_sigmask): New stub.
3560
1692ae2d 35612011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3562
8a6ebd58 3563 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3564 sigprocmask is portable only for single-threaded applications, and
3565 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3566 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3567 (LIBES): Use it.
3568 * callproc.c (Fcall_process):
3569 * process.c (create_process):
3570 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3571 Use pthread_sigmask, not sigprocmask.
123403e4 3572
1b854618
JD
35732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3574
3575 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3576 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3577 wrong (Bug#8591).
3578
3fe4b549
JD
35792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3580
0ce7e563
JD
3581 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3582 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3583 (xg_hide_tooltip): Fix comment.
3584
3fe4b549
JD
3585 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3586 in registerServicesMenuSendTypes.
3587 (validRequestorForSendType): Don't check ns_return_types.
3588
3589 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3590 ns_return_type.
3591
5df75e47
JR
35922011-07-08 Jason Rumney <jasonr@gnu.org>
3593
22610910
JR
3594 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3595 SH_SHOW for hidden windows (Bug#5482).
3596
5df75e47
JR
3597 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3598 frame struct members of non-existent frames (Bug#6284).
3599
699c10bd
JD
36002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3601
4393663b
JD
3602 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3603 variable firstTime not needed on OSX >= 10.6.
3604 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3605 >= 10.5. Use setKnobProportion, setDoubleValue.
3606
3607 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3608 (MAC_OS_X_VERSION_10_5): Define if not defined.
3609 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3610 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3611 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3612
3613 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3614 cString and lossyCString on OSX >= 10.4
3615
58179cce 3616 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3617 sizeToFit on OSX >= 10.2.
3618
3619 * nsimage.m (allocInitFromFile): Don't use deprecated method
3620 bestRepresentationForDevice on OSX >= 10.6.
3621
3622 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3623 to avoid warning.
3624
3625 * emacs.c: Declare unexec_init_emacs_zone.
3626
a63e0781
JD
3627 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3628
699c10bd
JD
3629 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3630
3631 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3632 on svcsMenu (Bug#8842).
3633
3634 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3635 ns_return_types.
3636 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3637
3638 * nsterm.m (QUTF8_STRING): Declare.
3639 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3640 (validRequestorForSendType): Return type is (id).
3641 Change indexOfObjectIdenticalTo to indexOfObject.
3642 Check if we have local selection before returning self (Bug#8842).
3643 (writeSelectionToPasteboard): Put local selection into paste board
3644 if we have a local selection (Bug#8842).
3645 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3646
3647 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3648 (ns_get_local_selection): Declare.
3649
54e10184
LMI
36502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3651
9888ff71
LMI
3652 * keymap.c (describe_map_tree): Don't insert a double newline at
3653 the end of the buffer (bug#1169) and return whether we inserted
3654 something.
3655
54e10184
LMI
3656 * callint.c (Fcall_interactively): Change "reading args" to
3657 "providing args" to try to clarify what it does (bug#1010).
3658
15fa4783
KH
36592011-07-07 Kenichi Handa <handa@m17n.org>
3660
3661 * composite.c (composition_compute_stop_pos): Ignore a static
3662 composition starting before CHARPOS (Bug#8915).
3663
3664 * xdisp.c (handle_composition_prop): Likewise.
3665
a8815b00
EZ
36662011-07-07 Eli Zaretskii <eliz@gnu.org>
3667
3668 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3669 (Bug#9015)
3670
ef7b981d 36712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3672
3673 * character.h (unicode_category_t): New enum type.
3674
3675 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3676 (Qchar_code_property_table): New variable.
3677 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3678 (UNIPROP_COMPRESSED_FORM_P): New macros.
3679 (char_table_ascii): Uncompress the compressed values.
3680 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3681 Uncompress the compressed values.
ac389d0c 3682 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3683 (char_table_ref_and_range): Uncompress the compressed values.
3684 (sub_char_table_set): New arg is_uniprop. Callers changed.
3685 Uncompress the compressed values.
3686 (sub_char_table_set_range): Args changed. Callers changed.
3687 (char_table_set_range): Adjuted for the above change.
3688 (map_sub_char_table): Delete args default_val and parent. Add arg
3689 top. Give decoded values to a Lisp function.
640c8776 3690 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3691 values to a Lisp function. Gcpro more variables.
3692 (uniprop_table_uncompress)
3693 (uniprop_decode_value_run_length): New functions.
3694 (uniprop_decoder, uniprop_decoder_count): New variables.
3695 (uniprop_get_decoder, uniprop_encode_value_character)
3696 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3697 New functions.
3698 (uniprop_encoder, uniprop_encoder_count): New variables.
3699 (uniprop_get_encoder, uniprop_table)
3700 (Funicode_property_table_internal, Fget_unicode_property_internal)
3701 (Fput_unicode_property_internal): New functions.
3702 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3703 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3704 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3705 char-code-property-alist.
3706
640c8776 3707 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3708 Vunicode_category_table.
3709
640c8776 3710 * font.c (font_range): Adjust for the change of
c805dec0
KH
3711 Vunicode_category_table.
3712
76b397fb
DN
37132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3714
3715 * m/iris4d.h: Remove file, move contents ...
3716 * s/irix6-5.h: ... here.
3717
22b4128e
PE
37182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3719
3720 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3721 * alloc.c (mark_buffer):
3722 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3723 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3724 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3725 This isn't true in general, and it's particularly not true
3726 if Emacs is configured with --with-wide-int.
3727 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3728 New macros, used in the buffer.c change.
3729
869795d6
JD
37302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3731
3732 * xsettings.c: Use both GConf and GSettings if both are available.
3733 (store_config_changed_event): Add comment.
3734 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3735 (store_tool_bar_style_changed): New functions.
5e617bc2 3736 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3737 (struct xsettings): Move font inside HAVE_XFT.
3738 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3739 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3740 Move inside HAVE_XFT.
640c8776 3741 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3742 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3743 also.
3744 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3745 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3746 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3747 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3748 (parse_settings): Move check for font inside HAVE_XFT.
3749 (read_settings, apply_xft_settings): Add comment.
3750 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3751 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3752 call store_font_name_changed.
3753 (xft_settings_event): Add comment.
3754 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3755 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3756 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3757 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3758 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3759 (xsettings_get_system_font, xsettings_get_system_normal_font):
3760 Add comment.
869795d6 3761
d8ed26bd
PE
37622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3763
3764 Random fixes. E.g., (random) never returned negative values.
3765 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3766 subseconds part to the entropy, as that's a bit more random.
3767 Prefer signed to unsigned, since the signedness doesn't matter and
3768 in general we prefer signed. When given a limit, use a
3769 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3770 latter isn't right if USE_2_TAGS_FOR_INTS.
3771 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3772 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3773
cabf1cac
SM
37742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3775
3776 * textprop.c (text_property_stickiness):
3777 Obey Vtext_property_default_nonsticky.
3778 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3779 * w32fns.c (syms_of_w32fns):
3780 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3781
6e9b2be9
PE
37822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3785 This is more efficient than Ffile_directory_p and avoids a minor race.
3786
90186c68
LMI
37872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3788
7c301272
LMI
3789 * buffer.c (Foverlay_put): Say what the return value is
3790 (bug#7835).
3791
c4f2d8d4
LMI
3792 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3793 is a directory before asking whether to use the file name
3794 (bug#7564).
ad637907
LMI
3795 (barf_or_query_if_file_exists): Make the "File is a directory"
3796 error be more correct.
c4f2d8d4 3797
90186c68
LMI
3798 * fns.c (Frequire): Remove the mention of the .gz files, since
3799 that's installation-specific, but keep the mention of
3800 `get-load-suffixes'.
3801
da64016e
PE
38022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3803
3804 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3805 Report string overflow if the output is too long.
3806
7d47b580
JB
38072011-07-04 Juanma Barranquero <lekktu@gmail.com>
3808
a555cb87
JB
3809 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3810 (syms_of_gnutls): Remove duplicate DEFSYM for
3811 Qgnutls_bootprop_verify_hostname_error, an error for
3812 Qgnutls_bootprop_verify_error (which is no longer used).
3813
7d47b580
JB
3814 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3815 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3816 Also (re)move comments that are misplaced or no longer relevant.
3817
1e49bfab
LMI
38182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3819
3820 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3821
1485f4c0
CY
38222011-07-03 Chong Yidong <cyd@stupidchicken.com>
3823
3824 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3825 and background color parameters if they have been changed.
3826
a9ab721e
LMI
38272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3828
3829 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3830
cf7cff57
PE
38312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3832
2e13213d
PE
3833 * xsettings.c (SYSTEM_FONT): Define only when used.
3834 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3835
cf7cff57
PE
3836 * keymap.c (access_keymap_1): Now static.
3837
7a8e04f7
CY
38382011-07-02 Chong Yidong <cyd@stupidchicken.com>
3839
3840 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3841 leave any prefix arg for the up event (Bug#1586).
3842
61352f62
LMI
38432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3844
69bb1ef7
LMI
3845 * lread.c (syms_of_lread): Mention single symbols defined by
3846 `defvar' or `defconst' (bug#7154).
3847
61352f62 3848 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3849 (Frequire): Mention get-load-suffixes.
61352f62 3850
28545e04
MR
38512011-07-02 Martin Rudalics <rudalics@gmx.at>
3852
3853 * window.h (window): Remove clone_number slot.
3854 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3855 Remove.
3856 (make_parent_window, make_window, saved_window)
3857 (Fset_window_configuration, save_window_save): Don't deal with
3858 clone numbers.
3859 * buffer.c (Qclone_number): Remove declaration.
3860 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3861
3349e122
SM
38622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3863
3864 Add multiple inheritance to keymaps.
3865 * keymap.c (Fmake_composed_keymap): New function.
3866 (Fset_keymap_parent): Simplify.
3867 (fix_submap_inheritance): Remove.
3868 (access_keymap_1): New function extracted from access_keymap to handle
3869 embedded parents and handle lists of maps.
3870 (access_keymap): Use it.
3871 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3872 (Fcopy_keymap): Handle embedded parents.
3873 (Fcommand_remapping, define_as_prefix): Simplify.
3874 (Fkey_binding): Simplify.
3875 (syms_of_keymap): Move minibuffer-local-completion-map,
3876 minibuffer-local-filename-completion-map,
3877 minibuffer-local-must-match-map, and
3878 minibuffer-local-filename-must-match-map to Elisp.
3879 (syms_of_keymap): Defsubr make-composed-keymap.
3880 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3881 (parse_menu_item): Trivial simplification.
3882
3279eb87
GM
38832011-07-01 Glenn Morris <rgm@gnu.org>
3884
3885 * Makefile.in (SETTINGS_LIBS): Fix typo.
3886
4550efdf
KI
38872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3888
3889 * coding.c (Fencode_coding_string): Record the last coding system
3890 used, as the function doc string says (bug#8738).
3891
0949d2b6
JD
38922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3893
3894 * xsettings.c (store_monospaced_changed): Take new font as arg and
3895 check for change against current_mono_font.
3896 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3897 (emacs_settings_constructor, emacs_settings_get_property)
3898 (emacs_settings_set_property, emacs_settings_class_init)
3899 (emacs_settings_init, gsettings_obj): Remove.
3900 (something_changedCB): New function for HAVE_GSETTINGS.
3901 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3902 with value as argument.
3903 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3904 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3905 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3906 "changed".
3907
3908 * xgselect.c: Add defined (HAVE_GSETTINGS).
3909 (xgselect_initialize): Ditto.
3910
3911 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3912 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3913 xg_select.
3914
bbc6b304
PE
39152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3916
3917 * eval.c (struct backtrace): Simplify and port the data structure.
3918 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3919 signed bit field, as this assumption is not portable and it makes
3920 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3921 "char debug_on_exit : 1" as this is not portable either; instead,
3922 use the portable "unsigned int debug_on_exit : 1". Remove unused
3923 member evalargs. Remove obsolete comments about cc bombing out.
3924
9851bfc5
JD
39252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3926
51bb811f 3927 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3928 Let HAVE_GSETTINGS override HAVE_GCONF.
3929 (store_monospaced_changed): New function.
3930 (EMACS_SETTINGS): A new type derived from GObject to handle
3931 GSettings notifications.
3932 (emacs_settings_constructor, emacs_settings_get_property)
3933 (emacs_settings_set_property, emacs_settings_class_init):
3934 New functions.
3935 (gsettings_client, gsettings_obj): New variables.
3936 (GSETTINGS_SCHEMA): New define.
3937 (something_changedCB): Call store_monospaced_changed.
3938 (init_gsettings): New function.
3939 (xsettings_initialize): Call init_gsettings.
3940 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3941 to NULL.
3942
640c8776 3943 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3944 GCONF_CFLAGS/LIBS.
3945
5386012d
MR
39462011-06-29 Martin Rudalics <rudalics@gmx.at>
3947
3948 * window.c (resize_root_window, grow_mini_window)
3949 (shrink_mini_window): Rename Qresize_root_window to
3950 Qwindow_resize_root_window and Qresize_root_window_vertically to
3951 Qwindow_resize_root_window_vertically.
3952
f13e0b08
PE
39532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3956
94515237
JB
39572011-06-27 Juanma Barranquero <lekktu@gmail.com>
3958
3959 * makefile.w32-in: Redesign dependencies so they reflect more
3960 clearly which files are directly included by each source file,
3961 and not through other includes.
3962
e43b6e43
MR
39632011-06-27 Martin Rudalics <rudalics@gmx.at>
3964
3965 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3966 (sort_overlays, overlay_strings): When an overlay's clone number
3967 matches the window's clone number process the overlay even if
3968 the overlay's window property doesn't match the current window.
3969
d68443dc
MR
3970 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3971 (Fwindow_hchild): Rename to Fwindow_left_child.
3972 (Fwindow_next): Rename to Fwindow_next_sibling.
3973 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3974 (resize_window_check): Rename to window_resize_check.
3975 (resize_window_apply): Rename to window_resize_apply.
3976 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3977 (Fdelete_other_windows_internal, resize_frame_windows)
3978 (Fsplit_window_internal, Fdelete_window_internal)
3979 (grow_mini_window, shrink_mini_window)
3980 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3981
c7e73be5
JD
39822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3983
3984 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3985 (emacs_fixed_set_min_size): Remove.
3986 (emacs_fixed_new): Take frame as argument.
3987
3988 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3989 (_EmacsFixedPrivate): Remove minwidth/height.
3990 Add struct frame *f.
3991 (emacs_fixed_init): Initialize priv->f.
3992 (get_parent_class, emacs_fixed_set_min_size): Remove.
3993 (emacs_fixed_new): Set priv->f to argument.
3994 (emacs_fixed_get_preferred_width)
3995 (emacs_fixed_get_preferred_height): Use min_width/height from
3996 frames size_hint to set minimum and natural (Bug#8919).
3997 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3998 and use min_width/height from frames size_hint to set
3999 min_width/height (Bug#8919).
4000
4001 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4002 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4003 Fix indentation.
c7e73be5 4004
cf99dcf8
EZ
40052011-06-26 Eli Zaretskii <eliz@gnu.org>
4006
4007 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4008 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4009 called at ZV.
4010
029529ac
CY
40112011-06-26 Chong Yidong <cyd@stupidchicken.com>
4012
4013 * process.c (wait_reading_process_output): Bypass select if
4014 waiting for a cell while ignoring keyboard input, and input is
4015 pending. Suggested by Jan Djärv (Bug#8869).
4016
7a7ef429
PE
40172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4018
4019 Use gnulib's dup2 module instead of rolling our own.
4020 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4021
11fdef7d 40222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4023
4024 * dispnew.c (scrolling_window): Before scrolling, turn off a
4025 mouse-highlight in the window being scrolled.
4026
cd3520a4
JB
40272011-06-24 Juanma Barranquero <lekktu@gmail.com>
4028
4029 Move DEFSYM to lisp.h and use everywhere.
4030
4031 * character.h (DEFSYM): Move declaration...
4032 * lisp.h (DEFSYM): ...here.
4033
4034 * gnutls.c:
4035 * minibuf.c:
4036 * w32menu.c:
4037 * w32proc.c:
4038 * w32select.c: Don't include character.h.
4039
4040 * alloc.c (syms_of_alloc):
4041 * buffer.c (syms_of_buffer):
4042 * bytecode.c (syms_of_bytecode):
4043 * callint.c (syms_of_callint):
4044 * casefiddle.c (syms_of_casefiddle):
4045 * casetab.c (init_casetab_once):
4046 * category.c (init_category_once, syms_of_category):
4047 * ccl.c (syms_of_ccl):
4048 * cmds.c (syms_of_cmds):
4049 * composite.c (syms_of_composite):
4050 * dbusbind.c (syms_of_dbusbind):
4051 * dired.c (syms_of_dired):
4052 * dispnew.c (syms_of_display):
4053 * doc.c (syms_of_doc):
4054 * editfns.c (syms_of_editfns):
4055 * emacs.c (syms_of_emacs):
4056 * eval.c (syms_of_eval):
4057 * fileio.c (syms_of_fileio):
4058 * fns.c (syms_of_fns):
4059 * frame.c (syms_of_frame):
4060 * fringe.c (syms_of_fringe):
4061 * insdel.c (syms_of_insdel):
4062 * keymap.c (syms_of_keymap):
4063 * lread.c (init_obarray, syms_of_lread):
4064 * macros.c (syms_of_macros):
4065 * msdos.c (syms_of_msdos):
4066 * print.c (syms_of_print):
4067 * process.c (syms_of_process):
4068 * search.c (syms_of_search):
4069 * sound.c (syms_of_sound):
4070 * syntax.c (init_syntax_once, syms_of_syntax):
4071 * terminal.c (syms_of_terminal):
4072 * textprop.c (syms_of_textprop):
4073 * undo.c (syms_of_undo):
4074 * w32.c (globals_of_w32):
4075 * window.c (syms_of_window):
4076 * xdisp.c (syms_of_xdisp):
4077 * xfaces.c (syms_of_xfaces):
4078 * xfns.c (syms_of_xfns):
4079 * xmenu.c (syms_of_xmenu):
4080 * xsettings.c (syms_of_xsettings):
4081 * xterm.c (syms_of_xterm): Use DEFSYM.
4082
4228cf16
TZ
40832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4084
cd3520a4 4085 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4086
7fcccf1e
PE
40872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4088
7efb4e0e
PE
4089 Integer and buffer overflow fixes (Bug#8873).
4090
ff5844ad
PE
4091 * print.c (printchar, strout): Check for string overflow.
4092 (PRINTPREPARE, printchar, strout):
4093 Don't set size unless allocation succeeds.
4094
90532f02
PE
4095 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4096 for sizes. Check for string overflow more accurately.
4097 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4098
6d84508d
PE
4099 * macros.c: Integer and buffer overflow fixes.
4100 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4101 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4102 Use ptrdiff_t, not int, for sizes.
4103 Don't increment bufsize until after realloc succeeds.
4104 Check for size-calculation overflow.
4105 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4106
437b2cb4
PE
4107 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4108
8b9ac8b4
PE
4109 * lread.c: Integer overflow fixes.
4110 (read_integer): Radix is now EMACS_INT, not int,
4111 to improve quality of diagnostics for out-of-range radices.
4112 Calculate buffer size correctly for out-of-range radices.
4113 (read1): Check for integer overflow in radices, and in
4114 read-circle numbers.
82cb60d3
PE
4115 (read_escape): Avoid int overflow.
4116 (Fload, openp, read_buffer_size, read1)
4117 (substitute_object_recurse, read_vector, read_list, map_obarray):
4118 Use ptrdiff_t, not int, for sizes.
4119 (read1): Use EMACS_INT, not int, for sizes.
20270765 4120 Check for size overflow.
8b9ac8b4 4121
7fcccf1e
PE
4122 * image.c (cache_image): Check for size arithmetic overflow.
4123
bfbbd7e7
PE
4124 * lread.c: Integer overflow issues.
4125 (saved_doc_string_size, saved_doc_string_length)
4126 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4127 Now ptrdiff_t, not int.
4128 (read1): Don't assume doc string length fits in int. Check for
4129 out-of-range doc string lengths.
4130 (read_list): Don't assume file position fits in int.
39019e54 4131 (read_escape): Check for hex character overflow.
bfbbd7e7 4132
4e323265
LL
41332011-06-22 Leo Liu <sdl.web@gmail.com>
4134
4135 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4136 Move to minibuffer.el.
4137
85fece3e
PE
41382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4139
20b84ce9 4140 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4141 The following patches are for when GLYPH_DEBUG && !XASSERT.
4142 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4143 * dispnew.c (flush_stdout):
4144 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4145 Mark as externally visible.
4146 * dispnew.c (check_window_matrix_pointers): Now static.
4147 * dispnew.c (window_to_frame_vpos):
4148 * xfns.c (unwind_create_frame):
4149 * xterm.c (x_check_font): Remove unused local.
4150 * scroll.c (CHECK_BOUNDS):
4151 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4152 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4153 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4154 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4155 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4156 Now static.
4157 (debug_method_add): Use va_list and vsprintf rather than relying
4158 on undefined behavior with wrong number of arguments.
4159 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4160 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4161 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4162 since we're not interested in debugging glyphs with old libraries.
4163 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4164 GCC 4.6.0's static checking.
4165
0766b489
PE
41662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4167
31fd4b32
PE
4168 Integer overflow and signedness fixes (Bug#8873).
4169 A few related buffer overrun fixes, too.
4170
b79e8648
PE
4171 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4172
0766b489
PE
4173 * dispextern.h (struct face.stipple):
4174 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4175 (x_bitmap_mask, x_allocate_bitmap_record)
4176 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4177 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4178 (x_create_bitmap_from_xpm_data):
4179 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4180 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4181 (.bitmaps_last):
4182 * xfaces.c (load_pixmap):
4183 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4184 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4185 (.bitmaps_last, struct x_output.icon_bitmap):
4186 Use ptrdiff_t, not int, for bitmap indexes.
4187 (x_allocate_bitmap_record): Check for size overflow.
4188 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4189
b081724f
PE
4190 Use ptrdiff_t, not int, for overlay counts.
4191 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4192 * editfns.c (overlays_around, get_pos_property):
4193 * textprop.c (get_char_property_and_overlay):
4194 * xdisp.c (next_overlay_change, note_mouse_highlight):
4195 * xfaces.c (face_at_buffer_position):
21514da7
PE
4196 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4197 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4198 (Fnext_overlay_change, Fprevious_overlay_change)
4199 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4200 Use ptrdiff_t, not int, for sizes.
21514da7 4201 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4202
3de73e5e
PE
4203 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4204
2606c57b
PE
4205 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4206 (x_session_initialize): Do not assume string length fits in int.
4207
aaafe47a
PE
4208 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4209 This is unlikely, but can occur if DPI is outlandish.
4210
2674ddc8 4211 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4212 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4213
28154962
PE
4214 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4215 * xrdb.c (magic_file_p, search_magic_path):
4216 Omit last arg SUFFIX; it was always 0. All callers changed.
4217 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4218
7de51af5
PE
4219 * xfont.c (xfont_match): Avoid need for strlen.
4220
25ed6cc3
PE
4221 * xfns.c: Don't assume strlen fits in int.
4222 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4223
4eab31dd
PE
4224 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4225 not unsigned long, as we prefer signed integers. All callers changed.
4226 Detect integer overflow in repeat count.
4227 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4228 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4229
171e2a58
PE
4230 * termcap.c: Don't assume sizes fit in int and never overflow.
4231 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4232 (gobble_line): Check for size-calculation overflow.
4233
ad39faca 4234 * minibuf.c (Fread_buffer):
6e5bb2dc 4235 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4236 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4237 Don't assume string length fits in int.
4238
52c61c22 4239 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4240 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4241
b5b8c9e5
PE
4242 * font.c: Don't assume string length fits in int.
4243 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4244 Use ptrdiff_t, not int.
ccd6111c
PE
4245 (font_intern_prop): Don't assume string length fits in int.
4246 Don't assume integer property fits in fixnum.
4247 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4248
882f0d81 4249 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4250 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4251 Reformulate so as not to need the command string.
4252 Invoke gzip -cd rather than gunzip, as it's more portable.
4253 (lock_info_type, lock_file_1, lock_file):
4254 Don't assume pid_t and time_t fit in unsigned long.
4255 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4256 (current_lock_owner): Prefer signed type for sizes.
4257 Use memcpy, not strncpy, where memcpy is what is really wanted.
4258 Don't assume (via atoi) that time_t and pid_t fit in int.
4259 Check for time_t and/or pid_t out of range, e.g., via a network share.
4260 Don't alloca where an auto var works fine.
4261
93f4cf88
PE
4262 * fileio.c: Fix some integer overflow issues.
4263 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4264 Don't assume string length fits in int.
4265 (directory_file_name): Don't assume string length fits in long.
4266 (make_temp_name): Don't assume pid fits in int, or that its print
4267 length is less than 20.
4268
f3e92b69
PE
4269 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4270
1bfdaf10
PE
4271 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4272
35016e9a
PE
4273 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4274
3d1e65a1
PE
4275 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4276 We prefer signed integers, even for size calculations.
4277
0b963a93
PE
4278 * emacs.c: Don't assume string length fits in 'int'.
4279 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4280 (main): Don't invoke strlen when not needed.
4281
573f4b54
PE
4282 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4283 (XD_DEBUG_MESSAGE): Don't waste a byte.
4284
989f33ba
PE
4285 * callproc.c (getenv_internal_1, getenv_internal)
4286 (Fgetenv_internal):
965d34eb
PE
4287 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4288
e4d29b33
PE
4289 * lread.c (invalid_syntax): Omit length argument.
4290 All uses changed. This doesn't fix a bug, but it simplifies the
4291 code away from its former Hollerith-constant appearance, and it's
4292 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4293 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4294
eb49b136
PE
4295 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4296 This didn't break anything, but it didn't help either.
4297 It's confusing to put a bogus integer in a place where the actual
4298 value does not matter.
9f62aeb1 4299 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4300 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4301
15375a22
PE
4302 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4303 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4304 implementation.
b61cc01c
PE
4305 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4306 We prefer signed types, and the value cannot exceed the EMACS_INT
4307 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4308 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4309 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4310 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4311
53b2623d
PE
4312 * indent.c (sane_tab_width): New function.
4313 (current_column, scan_for_column, Findent_to, position_indentation)
4314 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4315 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4316
51cab52b 4317 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4318
f2ed8a70
PE
4319 * lisp.h (lint_assume): New macro.
4320 * composite.c (composition_gstring_put_cache):
4321 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4322
abe80cc6
PE
4323 * editfns.c, insdel.c:
4324 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4325
b02c740e
PE
4326 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4327
ebc96716
PE
4328 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4329
b4e50fa0 4330 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4331 Use much-faster test for byte-length change.
311d5d7c 4332 Don't assume string byte-length fits in 'int'.
a4cf38e4 4333 Check that character arg fits in 'int'.
85461888 4334 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4335
c0c1ee9f
PE
4336 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4337
a498d7f4
PE
4338 * fns.c (concat): Catch string overflow earlier.
4339 Do not rely on integer wraparound.
4340
51cab52b
PE
4341 * dispextern.h (struct it.overlay_strings_charpos)
4342 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4343 * xdisp.c (forward_to_next_line_start)
4344 (back_to_previous_visible_line_start)
4345 (reseat_at_next_visible_line_start, next_element_from_buffer):
4346 Don't arbitrarily truncate the value of 'selective' to int.
4347
76031fad
PE
4348 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4349
5eb55db9
PE
4350 * composite.c: Don't truncate sizes to 'int'.
4351 (composition_gstring_p, composition_reseat_it)
4352 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4353 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4354 not EMACS_UINT, for indexes.
5eb55db9 4355
0703a717
PE
4356 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4357
d6202519
PE
4358 * buffer.c: Include <verify.h>.
4359 (struct sortvec.priority, struct sortstr.priority):
8961a454 4360 Now EMACS_INT, not int.
c20998a7 4361 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4362 (struct sortstr.size, record_overlay_string)
4363 (struct sortstrlist.size, struct sortlist.used):
4364 Don't truncate size to int.
4365 (record_overlay_string): Check for size-calculation overflow.
d6202519 4366 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4367
d5a19415
JM
43682011-06-22 Jim Meyering <meyering@redhat.com>
4369
029529ac 4370 Don't leak an XBM-image-sized buffer
d5a19415
JM
4371 * image.c (xbm_load): Free the image buffer after using it.
4372
a9041e6c
PE
43732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4374
4375 Port to Sun C.
4376 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4377 that Sun C diagnosed.
4378 * fns.c (secure_hash): Fix pointer signedness issue.
4379 * intervals.c (static_offset_intervals): New function.
4380 (offset_intervals): Use it.
4381
7f3f739f
LL
43822011-06-21 Leo Liu <sdl.web@gmail.com>
4383
4384 * deps.mk (fns.o):
4385 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4386 sha512.h.
4387
4388 * fns.c (secure_hash): Rename from crypto_hash_function and change
4389 the first arg to accept symbols.
5b66d427 4390 (Fsecure_hash): New primitive.
7f3f739f
LL
4391 (syms_of_fns): New symbols.
4392
76147d94
DD
43932011-06-20 Deniz Dogan <deniz@dogan.se>
4394
4395 * process.c (Fset_process_buffer): Clarify return value in
4396 docstring.
4397
7d7d0045
CY
43982011-06-18 Chong Yidong <cyd@stupidchicken.com>
4399
4400 * dispnew.c (add_window_display_history): Use BVAR.
4401
4402 * xdisp.c (debug_method_add): Use BVAR.
4403 (check_window_end, dump_glyph_matrix, dump_glyph)
4404 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4405
4406 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4407 Likewise.
4408
4409 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4410 check till after the cache is created in init_frame_faces.
4411
ff2bc410
SM
44122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4413
4414 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4415
28177add
PE
44162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4417
dd3482fe
PE
4418 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4419 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4420 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4421
393d71f3 4422 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4423 * fileio.c (Finsert_file_contents):
4424 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4425 Remove the old (too-loose) buffer overflow checks.
4426 They weren't needed, since make_gap checks for buffer overflow.
4427 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4428 The old code merely checked for Emacs fixnum overflow, and relied
4429 on undefined (wraparound) behavior. The new code avoids undefined
4430 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4431
2e6813b0 4432 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4433 Tune. Don't use wider integers than needed. Don't use alloca.
4434 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4435
599a9e4f
PE
4436 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4437
99561444
PE
4438 * insdel.c, lisp.h (buffer_overflow): New function.
4439 (insert_from_buffer_1, replace_range, replace_range_2):
4440 * insdel.c (make_gap_larger):
4441 * editfns.c (Finsert_char):
4442 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4443
28177add
PE
4444 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4445
e69dafad
PE
44462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4447
4baa020d 4448 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4449
b1c46f02
PE
4450 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4451 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4452
e69dafad
PE
4453 * fileio.c: Don't assume EMACS_INT fits in off_t.
4454 (emacs_lseek): New static function.
4455 (Finsert_file_contents, Fwrite_region): Use it.
4456 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4457
566684ea
PE
4458 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4459
e6966cd6
PE
4460 * fns.c: Don't overflow int when computing a list length.
4461 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4462 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4463 truncation on 64-bit hosts. Check for QUIT every
4464 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4465 faster and is responsive enough.
4466 (Flength): Report an error instead of overflowing an integer.
4467 (Fsafe_length): Return a float if the value is not representable
4468 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4469 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4470 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4471
dd0b0efb
PE
4472 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4473 (header_size, word_size): New constants.
4474 (allocate_vectorlike): Don't check size overflow here.
4475 (allocate_vector): Check it here instead, since this is the only
4476 caller of allocate_vectorlike that could cause overflow.
4477 Check that the new vector's length is representable as a fixnum.
4478
86fe5cfe
PE
4479 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4480 The previous code was bogus. For example, next_almost_prime (32)
4481 returned 39, which is undesirable as it is a multiple of 3; and
4482 next_almost_prime (24) returned 25, which is a multiple of 5 so
4483 why was the code bothering to check for multiples of 7?
4484
80e88859
PE
4485 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4486
4a2f0ad6
PE
4487 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4488
f66c7cf8
PE
4489 Variadic C functions now count arguments with ptrdiff_t.
4490 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4491 Back then I didn't know that the Emacs coding style prefers signed int.
4492 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4493 were being counted with int, which may truncate counts on 64-bit
4494 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4495 * lisp.h (struct Lisp_Subr.function.aMANY)
4496 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4497 Arg counts are now ptrdiff_t, not size_t.
4498 All variadic functions and their callers changed accordingly.
4499 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4500 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4501 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4502 * callint.c (Fcall_interactively): Check arg count for overflow,
4503 to avoid potential buffer overrun. Use signed char, not 'int',
4504 for 'varies' array, so that we needn't bother to check its size
4505 calculation for overflow.
4506 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4507 * eval.c (apply_lambda):
4508 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4509 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4510 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4511
a1759b76
PE
4512 * callint.c (Fcall_interactively): Don't use index var as event count.
4513
d96be9fc
PE
4514 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4515 * mem-limits.h (SIZE): Remove; no longer used.
4516
a690a978 4517 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4518
578c21e6
PE
4519 Remove unnecessary casts.
4520 * xterm.c (x_term_init):
4521 * xfns.c (x_set_border_pixel):
4522 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4523 These aren't needed now that we assume ANSI C.
4524
96f53c6c
PE
4525 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4526 It's more likely to cause problems (due to unsigned overflow)
4527 than to cure them.
4528
83c77d31
PE
4529 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4530
ee2079f1
PE
4531 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4532
6da65536
PE
4533 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4534
7147c4a4
PE
4535 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4536
193e32d9
PE
4537 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4538
e5533da6
PE
4539 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4540
9910e595
PE
4541 GLYPH_CODE_FACE returns EMACS_INT, not int.
4542 * dispextern.h (merge_faces):
4543 * xfaces.c (merge_faces):
01103c44
PE
4544 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4545 Don't assume EMACS_INT fits in int.
9910e595 4546
2638320e
PE
4547 * character.h (CHAR_VALID_P): Remove unused parameter.
4548 * fontset.c, lisp.h, xdisp.c: All uses changed.
4549
045eb8d9
PE
4550 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4551
c1f134b5
PE
4552 * fns.c (concat): Minor tuning based on overflow analysis.
4553 This doesn't fix any bugs. Use int to hold character, instead
4554 of constantly refetching from Emacs object. Use XFASTINT, not
4555 XINT, for value known to be a character. Don't bother comparing
4556 a single byte to 0400, as it's always less.
4557
395fcb93 4558 * floatfns.c (Fexpt):
327eeec8
PE
4559 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4560
abbd3d23
PE
4561 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4562 for characters.
4563
684a03ef
PE
4564 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4565
0fed43f3
PE
4566 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4567 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4568 incorrectly succeed when S was a string, because 4294967386 was
4569 truncated before it was used.
4570
8fd02eb7
PE
4571 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4572 Otherwise, an out-of-range integer could cause undefined behavior
4573 on a 64-bit host.
4574
f8c86b69
PE
4575 * composite.c: Use int, not EMACS_INT, for characters.
4576 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4577 EMACS_INT, for values that are known to be in character range.
4578 This doesn't fix any bugs but is the usual style inside Emacs and
4579 may generate better code on 32-bit machines.
4580
34206dd2
PE
4581 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4582 This is for reasons similar to the recent CHAR_STRING fix.
4583 * charset.c (Fencode_char): Check that character arg is actually
4584 a character. Pass an int to ENCODE_CHAR.
4585 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4586 wider than 'int', as a compile-time check to prevent future regressions
4587 in this area.
4588
c5958d4c 4589 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4590
4591 Make sure a 64-bit char is never passed to CHAR_STRING.
4592 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4593 by silently ignoring the top 32 bits, allowing some values
4594 that were far too large to be valid characters.
4595 * character.h: Include <verify.h>.
4596 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4597 arguments are no wider than unsigned, as a compile-time check
4598 to prevent future regressions in this area.
4599 * data.c (Faset):
01103c44 4600 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4601 (Fsubst_char_in_region):
4602 * fns.c (concat):
4603 * xdisp.c (decode_mode_spec_coding):
4604 Adjust to CHAR_STRING's new requirement.
4605 * editfns.c (Finsert_char, Fsubst_char_in_region):
4606 * fns.c (concat): Check that character args are actually
4607 characters. Without this test, these functions did the wrong
4608 thing with wildly out-of-range values on 64-bit hosts.
4609
d37ca623
PE
4610 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4611 These casts should not be needed on 32-bit hosts, either.
4612 * keyboard.c (read_char):
4613 * lread.c (Fload): Remove casts to unsigned.
4614
ea204efb
PE
4615 * lisp.h (UNSIGNED_CMP): New macro.
4616 This fixes comparison bugs on 64-bit hosts.
4617 (ASCII_CHAR_P): Use it.
4618 * casefiddle.c (casify_object):
01103c44 4619 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4620 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4621 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4622 * dispextern.h (FACE_FROM_ID):
4623 * keyboard.c (read_char): Use UNSIGNED_CMP.
4624
41cb286c
PE
4625 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4626 not to EMACS_INT, to avoid GCC warning.
4627
4a1b9832
PE
4628 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4629
55daad71
PE
4630 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4631 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4632 isn't needed on 32-bit machines.
8f95c75c 4633
01103c44
PE
4634 * buffer.c (Fgenerate_new_buffer_name):
4635 Use EMACS_INT for count, not int.
0ceccced 4636 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4637
4638 * data.c (Qcompiled_function): Now static.
4639
c6f072e7
PE
4640 * window.c (window_body_lines): Now static.
4641
20ce5912
PE
4642 * image.c (gif_load): Rename local to avoid shadowing.
4643
9c4c5f81
PE
4644 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4645 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4646 * alloc.c (make_save_value): Integer argument is now of type
4647 ptrdiff_t, not int.
4648 (mark_object): Use ptrdiff_t, not int.
4649 * lisp.h (pD): New macro.
4650 * print.c (print_object): Use it.
4651
c0c5c8ae
PE
4652 * alloc.c: Use EMACS_INT, not int, to count objects.
4653 (total_conses, total_markers, total_symbols, total_vector_size)
4654 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4655 (total_free_floats, total_floats, total_free_intervals)
4656 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4657 Now EMACS_INT, not int. All uses changed.
4658 (Fgarbage_collect): Compute overall total using a double, so that
4659 integer overflow is less likely to be a problem. Check for overflow
4660 when converting back to an integer.
5a25e253
PE
4661 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4662 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4663 These were 'int' variables that could overflow on 64-bit hosts;
4664 they were never used, so remove them instead of repairing them.
211a0b2a 4665 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4666 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4667 Previously, this ceilinged at INT_MAX, but that doesn't work on
4668 64-bit machines.
e46bb31a 4669 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4670
c78baabf 4671 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4672 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4673 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4674 when a (possibly-narrower) signed value would do just as well.
4675 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4676
c9d624c6
PE
4677 * alloc.c: Catch some string size overflows that we were missing.
4678 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4679 for convenience in STRING_BYTES_MAX.
4680 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4681 The definition here is exact; the one in lisp.h was approximate.
4682 (allocate_string_data): Check for string overflow. This catches
4683 some instances we weren't catching before. Also, it catches
4684 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4685 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4686 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4687
c9d624c6
PE
4688 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4689 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4690 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4691
353032ce
PE
4692 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4693
2bccce07
PE
4694 * alloc.c (Fmake_string): Check for out-of-range init.
4695
0ac30604
SM
46962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4697
4698 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4699
c195f2de
JD
47002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4701
4702 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4703 xg_get_default_scrollbar_width.
4704
4705 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4706 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4707 (style_changed_cb): Call update_theme_scrollbar_width and call
4708 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4709 all frames (Bug#8505).
4710 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4711 Call gtk_window_set_resizable if HAVE_GTK3.
4712 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4713 and height if HAVE_GTK3 (Bug#8505).
4714 (scroll_bar_width_for_theme): New variable.
4715 (update_theme_scrollbar_width): New function.
4716 (xg_get_default_scrollbar_width): Move code to
4717 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4718 (xg_initialize): Call update_theme_scrollbar_width.
4719
4720 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4721
4722 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4723
e10ac9f1
MR
47242011-06-12 Martin Rudalics <rudalics@gmx.at>
4725
4726 * frame.c (make_frame): Call other_buffer_safely instead of
4727 other_buffer.
4728
4729 * window.c (temp_output_buffer_show): Call display_buffer with
4730 second argument Vtemp_buffer_show_specifiers and reset latter
4731 immediately after the call.
4732 (Vtemp_buffer_show_specifiers): New variable.
4733 (auto_window_vscroll_p, next_screen_context_lines)
4734 (Vscroll_preserve_screen_position): Remove leading asterisks from
4735 doc-strings.
4736
2d3c217e 47372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4738
7b7f97e8 4739 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4740 * buffer.c (Qclone_number): Remove for now, as it's unused.
4741 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4742 (record_buffer): Remove unused local.
4743 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4744 (set_frame_buffer_list): Remove; unused.
4745 * frame.h (other_visible_frames): Remove decl.
4746 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4747 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4748 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4749 if HAVE_GPM.
4750 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4751 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4752 Define only if HAVE_GPM.
4753 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4754 (update_hints_inhibit): Remove; never set. All uses removed.
4755 * widgetprv.h (emacsFrameClassRec): Remove decl.
4756 * window.c (delete_deletable_window): Now returns void, since it
4757 wasn't returning anything.
4758 (compare_window_configurations): Remove unused locals.
4759 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4760 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4761 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4762 the same widths as pointers. This follows up on the 2011-05-06 patch.
4763 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4764 * xterm.h: Likewise.
4765 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4766
1384b89e
JB
47672011-06-12 Juanma Barranquero <lekktu@gmail.com>
4768
4769 * makefile.w32-in: Update dependencies.
4770 (LISP_H): Add lib/intprops.h.
4771
1100a63c
CY
47722011-06-11 Chong Yidong <cyd@stupidchicken.com>
4773
4774 * image.c (gif_load): Add animation frame delay to the metadata.
4775 (syms_of_image): Use DEFSYM. New symbol `delay'.
4776
6198ccd0
MR
47772011-06-11 Martin Rudalics <rudalics@gmx.at>
4778
4779 * window.c (delete_deletable_window): Re-add.
4780 (Fset_window_configuration): Rewrite to handle dead buffers and
4781 consequently deletable windows.
4782 (window_tree, Fwindow_tree): Remove. Supply functionality in
4783 window.el.
4784 (compare_window_configurations): Simplify code.
4785
b6e3633c
AS
47862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4787
1ab0dee5
AS
4788 * image.c (imagemagick_load_image): Fix type mismatch.
4789 (Fimagemagick_types): Likewise.
4790
b6e3633c
AS
4791 * window.h (replace_buffer_in_windows): Declare.
4792
9397e56f
MR
47932011-06-11 Martin Rudalics <rudalics@gmx.at>
4794
4795 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4796 Qclone_number. Remove external declaration of Qdelete_window.
4797 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4798 code.
640c8776
SM
4799 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4800 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4801 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4802 buffer list implementation.
4803 (other_buffer_safely): New function.
4804 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4805 calls to replace_buffer_in_windows and
4806 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4807 if allowed.
4808 (record_buffer): Inhibit quitting and rewrite using quittable
4809 functions. Run Qbuffer_list_update_hook if allowed.
4810 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4811 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4812 Move switch-to-buffer to window.el.
9397e56f
MR
4813 (bury-buffer): Move to window.el.
4814 (Vbuffer_list_update_hook): New variable.
4815
4816 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4817 section.
4818
4819 * window.h (resize_frame_windows): Move up in code.
4820 (Fwindow_frame): Remove EXFUN.
4821 (replace_buffer_in_all_windows): Remove prototype.
4822 (replace_buffer_in_windows_safely): Add prototype.
4823
4824 * window.c: Declare Qdelete_window static again. Move down
4825 declaration of select_count.
4826 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4827 (Fother_window): Move to window.el.
4828 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4829 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4830 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4831 window.el.
4832 (replace_buffer_in_windows): Implement by calling
4833 Qreplace_buffer_in_windows.
4834 (replace_buffer_in_all_windows): Remove with some functionality
4835 moved into replace_buffer_in_windows_safely.
4836 (replace_buffer_in_windows_safely): New function.
4837 (select_window_norecord, select_frame_norecord): Move in front
4838 of run_window_configuration_change_hook. Remove now obsolete
4839 declarations.
640c8776
SM
4840 (Fset_window_buffer): Rewrite doc-string.
4841 Call Qrecord_window_buffer.
9397e56f
MR
4842 (keys_of_window): Move binding for other-window to window.el.
4843
b50691aa
CY
48442011-06-11 Chong Yidong <cyd@stupidchicken.com>
4845
4846 * dispextern.h (struct image): Replace data member, whose int_val
4847 and ptr_val fields were not used by anything, with a single
4848 lisp_val object.
4849
4850 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4851 (gif_clear_image, gif_load, imagemagick_load_image)
4852 (gs_clear_image, gs_load): Callers changed.
4853
3f754b86
PE
48542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4855
cca69397
PE
4856 * buffer.h: Include <time.h>, for time_t.
4857 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4858
109e28d0
PE
4859 Fix minor problems found by static checking.
4860
60737f02
PE
4861 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4862
4b66faf3
PE
4863 Make identifiers static if they are not used in other modules.
4864 * data.c (Qcompiled_function, Qframe, Qvector):
4865 * image.c (QimageMagick, Qsvg):
4866 * minibuf.c (Qmetadata):
4867 * window.c (resize_window_check, resize_root_window): Now static.
4868 * window.h (resize_window_check, resize_root_window): Remove decls.
4869
109e28d0
PE
4870 * window.c (window_deletion_count, delete_deletable_window):
4871 Remove; unused.
46a4ce9e
PE
4872 (window_body_lines): Now static.
4873 (Fdelete_other_windows_internal): Mark vars as initialized.
4874 Make sure 'resize_failed' is initialized.
4875 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4876 (resize_window_apply): Remove unused local.
4877 * window.h (delete_deletable_window): Remove decl.
4878
109e28d0 4879 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4880 (imagemagick_load_image): Fix pointer signedness problem by changing
4881 last arg from unsigned char * to char *. All uses changed.
4882 Also, fix a local for similar reasons.
4883 Remove unused locals. Remove locals to avoid shadowing.
4884 (fn_rsvg_handle_free): Remove; unused.
4885 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4886 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4887
3f754b86
PE
4888 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4889
2547adb1
CY
48902011-06-10 Chong Yidong <cyd@stupidchicken.com>
4891
4892 * image.c (gif_load): Fix omitted cast error introduced by
4893 2011-06-06 change.
4894
2c8e37d4
MR
48952011-06-10 Martin Rudalics <rudalics@gmx.at>
4896
4897 * window.h (resize_proportionally, orig_total_lines)
4898 (orig_top_line): Remove from window structure.
4899 (set_window_height, set_window_width, change_window_heights)
4900 (Fdelete_window): Remove prototypes.
4901 (resize_frame_windows): Remove duplicate declaration.
4902
440a42e3
EZ
49032011-06-10 Eli Zaretskii <eliz@gnu.org>
4904
4905 * window.h (resize_frame_windows, resize_window_check)
4906 (delete_deletable_window, resize_root_window)
4907 (resize_frame_windows): Declare prototypes.
4908
4909 * window.c (resize_window_apply): Make definition be "static" to
4910 match the prototype.
4911
562dd5e9
MR
49122011-06-10 Martin Rudalics <rudalics@gmx.at>
4913
4914 * window.c: Remove declarations of Qwindow_size_fixed,
4915 window_min_size_1, window_min_size_2, window_min_size,
4916 size_window, window_fixed_size_p, enlarge_window, delete_window.
4917 Remove static from declaration of Qdelete_window, it's
4918 temporarily needed by Fbury_buffer.
4919 (replace_window): Don't assign orig_top_line and
4920 orig_total_lines.
4921 (Fdelete_window, delete_window): Remove. Window deletion is
4922 handled by window.el.
640c8776
SM
4923 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4924 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4925 (Fdelete_other_windows): Remove. Deleting other windows is
4926 handled by window.el.
4927 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4928 handled in window.el.
4929 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4930 Window minimum sizes are handled in window.el.
4931 (shrink_windows, size_window, set_window_height)
4932 (set_window_width, change_window_heights, window_height)
4933 (window_width, CURBEG, CURSIZE, enlarge_window)
4934 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4935 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4936 handled in window.el.
4937 (make_dummy_parent): Rename to make_parent_window and give it a
4938 second argument horflag.
4939 (make_window): Don't set resize_proportionally any more.
4940 (Fsplit_window): Remove. Windows are split in window.el.
4941 (save_restore_action, save_restore_orig_size)
4942 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4943 Resize mini windows in window.el.
4944 (grow_mini_window, shrink_mini_window): Implement by calling
4945 Qresize_root_window_vertically, resize_window_check and
4946 resize_window_apply.
640c8776
SM
4947 (saved_window, Fset_window_configuration, save_window_save):
4948 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4949 resize_proportionally.
4950 (window_min_height, window_min_width): Move to window.el.
4951 (keys_of_window): Move bindings for delete-other-windows,
4952 split-window, delete-window and enlarge-window to window.el.
4953
4954 * buffer.c: Temporarily extern Qdelete_window.
4955 (Fbury_buffer): Temporarily call Qdelete_window instead of
4956 Fdelete_window (Fbury_buffer will move to window.el soon).
4957
4958 * frame.c (set_menu_bar_lines_1): Remove code handling
4959 orig_top_line and orig_total_lines.
4960
4961 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4962 set_window_height but set heights directly.
4963 (change_frame_size_1): Use resize_frame_windows.
4964
4965 * xdisp.c (init_xdisp): Don't use set_window_height but set
4966 heights directly.
4967
640c8776
SM
4968 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4969 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4970 run_window_configuration_change_hook.
4971
4972 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4973 instead of change_window_heights and run
4974 run_window_configuration_change_hook.
4975
1a13852e
MR
49762011-06-09 Martin Rudalics <rudalics@gmx.at>
4977
4978 * window.c (replace_window): Rename second argument REPLACEMENT to
4979 NEW. New third argument SETFLAG. Rewrite.
4980 (delete_window, make_dummy_parent): Call replace_window with
4981 third argument 1.
4982 (window_list_1): Move down in code.
4983 (run_window_configuration_change_hook): Move set_buffer part
4984 before select_frame_norecord part in order to unwind correctly.
4985 Rename count1 to count.
4986 (recombine_windows, delete_deletable_window, resize_root_window)
4987 (Fdelete_other_windows_internal)
4988 (Frun_window_configuration_change_hook, make_parent_window)
4989 (resize_window_check, resize_window_apply, Fresize_window_apply)
4990 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4991 (Fdelete_window_internal, Fresize_mini_window_internal):
4992 New functions.
1a13852e
MR
4993 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4994
f3d1777e
MR
49952011-06-08 Martin Rudalics <rudalics@gmx.at>
4996
496e208e
MR
4997 * window.h (window): Add some new members to window structure -
4998 normal_lines, normal_cols, new_total, new_normal, clone_number,
4999 splits, nest, prev_buffers, next_buffers.
5000 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5001 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5002
f3d1777e
MR
5003 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5004 Remove.
496e208e
MR
5005 (make_dummy_parent): Set new members of windows structure.
5006 (make_window): Move down in code. Handle new members of window
5007 structure.
5008 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5009 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5010 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5011 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5012 (Fset_window_next_buffers, Fset_window_clone_number):
5013 New functions.
496e208e
MR
5014 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5015 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5016 Doc-string fixes.
5017 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5018 Argument WINDOW can be now internal window too.
5019 (Fwindow_use_time): Move up in code.
5020 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5021 Rewrite doc-string.
5022 (Fset_window_configuration, saved_window)
5023 (Fcurrent_window_configuration, save_window_save): Handle new
5024 members of window structure.
b9e809c2
MR
5025 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5026 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5027 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5028 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5029 Qget_mru_window, Qresize_root_window,
5030 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5031 Qauto_buffer_name; staticpro them.
f3d1777e 5032
abde8f8c
MR
50332011-06-07 Martin Rudalics <rudalics@gmx.at>
5034
5035 * window.c (Fwindow_total_size, Fwindow_left_column)
5036 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5037 (Fwindow_list_1): New functions.
5038 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5039 (Fwindow_width, Fscroll_left, Fscroll_right):
5040 Use window_body_cols instead of window_box_text_cols.
5041 (delete_window, Fset_window_configuration):
5042 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5043 (delete_all_subwindows): Take a window as argument and not a
5044 structure. Rewrite.
190b47e6
MR
5045 (window_loop): Remove handling of GET_LRU_WINDOW and
5046 GET_LARGEST_WINDOW.
5047 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5048
5049 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5050 window_box_text_cols. delete_all_subwindows now takes a
5051 Lisp_Object as argument.
abde8f8c 5052
640c8776
SM
5053 * indent.c (compute_motion, Fcompute_motion):
5054 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5055
fa8a67e6
MR
5056 * frame.c (delete_frame): Call delete_all_subwindows with root
5057 window as argument.
5058
a54e3482
DC
50592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5060
5061 * fns.c (Fputhash): Document return value.
5062
60002bf5
CY
50632011-06-06 Chong Yidong <cyd@stupidchicken.com>
5064
5065 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5066
0c671da6 50672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5068
b862a52a 5069 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5070
be44ca6c
PE
5071 Check for overflow when converting integer to cons and back.
5072 * charset.c (Fdefine_charset_internal, Fdecode_char):
5073 Use cons_to_unsigned to catch overflow.
5074 (Fencode_char): Use INTEGER_TO_CONS.
5075 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5076 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5077 * data.c (long_to_cons, cons_to_long): Remove.
5078 (cons_to_unsigned, cons_to_signed): New functions.
5079 These signal an error for invalid or out-of-range values.
5080 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5081 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5082 * font.c (Ffont_variation_glyphs):
5083 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5084 * lisp.h: Include <intprops.h>.
5085 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5086 (cons_to_signed, cons_to_unsigned): New decls.
5087 (long_to_cons, cons_to_long): Remove decls.
5088 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5089 (Fprimitive_undo): Use CONS_TO_INTEGER.
5090 * xfns.c (Fx_window_property): Likewise.
5091 * xselect.c: Include <limits.h>.
5092 (x_own_selection, selection_data_to_lisp_data):
5093 Use INTEGER_TO_CONS.
5094 (x_handle_selection_request, x_handle_selection_clear)
5095 (x_get_foreign_selection, Fx_disown_selection_internal)
5096 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5097 (lisp_data_to_selection_data): Use cons_to_unsigned.
5098 (x_fill_property_data): Use cons_to_signed.
5099 Report values out of range.
5100
d1f3d2af
PE
5101 Check for buffer and string overflow more precisely.
5102 * buffer.h (BUF_BYTES_MAX): New macro.
5103 * lisp.h (STRING_BYTES_MAX): New macro.
5104 * alloc.c (Fmake_string):
5105 * character.c (string_escape_byte8):
5106 * coding.c (coding_alloc_by_realloc):
5107 * doprnt.c (doprnt):
5108 * editfns.c (Fformat):
5109 * eval.c (verror):
5110 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5111 since they may not be the same number.
5112 * editfns.c (Finsert_char):
5113 * fileio.c (Finsert_file_contents):
5114 Likewise for BUF_BYTES_MAX.
5115
dd52fcea
PE
5116 * image.c: Use ptrdiff_t, not int, for sizes.
5117 (slurp_file): Switch from int to ptrdiff_t.
5118 All uses changed.
5119 (slurp_file): Check that file size fits in both size_t (for
5120 malloc) and ptrdiff_t (for sanity and safety).
5121
7f9bbdbb
PE
5122 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5123 if b->modtime has its maximal value.
5124
dfe18f82
PE
5125 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5126
84acfcf0
PE
5127 Don't assume time_t can fit into int.
5128 * buffer.h (struct buffer.modtime): Now time_t, not int.
5129 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5130 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5131
ccd9a01a
PE
5132 Minor fixes for signed vs unsigned integers.
5133 * character.h (MAYBE_UNIFY_CHAR):
5134 * charset.c (maybe_unify_char):
5135 * keyboard.c (read_char, reorder_modifiers):
5136 XINT -> XFASTINT, since the integer must be nonnegative.
5137 * ftfont.c (ftfont_spec_pattern):
5138 * keymap.c (access_keymap, silly_event_symbol_error):
5139 XUINT -> XFASTINT, since the integer must be nonnegative.
5140 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5141 since it makes no difference and we prefer signed.
5142 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5143 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5144 nonnegative.
5145
d6d100dd
SM
51462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5147
5148 * window.h (Fwindow_frame): Declare.
5149
2b6148e4
PE
51502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5151
5152 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5153 (SPARE_MEMORY): Always define.
5154 (LARGE_REQUEST): Remove.
5155 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5156
f230ecc9
MR
51572011-06-06 Martin Rudalics <rudalics@gmx.at>
5158
727e958e
MR
5159 * lisp.h: Move EXFUNS for Fframe_root_window,
5160 Fframe_first_window and Fset_frame_selected_window to window.h.
5161
5162 * window.h: Move EXFUNS for Fframe_root_window,
5163 Fframe_first_window and Fset_frame_selected_window here from
5164 lisp.h.
5165
5166 * frame.c (Fwindow_frame, Fframe_first_window)
5167 (Fframe_root_window, Fframe_selected_window)
5168 (Fset_frame_selected_window): Move to window.c.
5169 (Factive_minibuffer_window): Move to minibuf.c.
5170 (Fother_visible_frames_p): New function.
5171
5172 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5173
f230ecc9
MR
5174 * window.c (decode_window, decode_any_window): Move up in code.
5175 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5176 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5177 (Fwindow_buffer): Move up and rewrite doc-string.
5178 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5179 (Fwindow_prev): New functions.
727e958e
MR
5180 (Fwindow_frame): Move here from frame.c. Accept any window as
5181 argument.
5182 (Fframe_root_window, Fframe_first_window)
5183 (Fframe_selected_window): Move here from frame.c. Accept frame
5184 or arbitrary window as argument. Update doc-strings.
5185 (Fminibuffer_window): Move up in code.
5186 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5187 (Fset_frame_selected_window): Move here from frame.c.
5188 Marginal rewrite.
727e958e
MR
5189 (Fselected_window, select_window, Fselect_window): Move up in
5190 code. Minor doc-string fixes.
f230ecc9 5191
4d09bcf6
PE
51922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5193
5194 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5195 Do not assume that spare memory exists; that assumption is valid
5196 only if SYSTEM_MALLOC.
5197 (LARGE_REQUEST): New macro, so that the issue of large requests
5198 is separated from the issue of spare memory.
5199
810928a2
AS
52002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5201
172418ad
AS
5202 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5203 format. (Bug#8806)
5204
43f862f7
AS
5205 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5206
810928a2
AS
5207 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5208 before statements.
5209
a059fe24
JD
52102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5211
5212 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5213
5214 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5215
5216 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5217 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5218
989bf368
JB
52192011-06-05 Juanma Barranquero <lekktu@gmail.com>
5220
5221 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5222
4b80f674
CY
52232011-06-04 Chong Yidong <cyd@stupidchicken.com>
5224
5225 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5226 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5227 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5228 New error handlers.
4b80f674
CY
5229 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5230 Obey Vx_select_enable_clipboard_manager. Catch errors in
5231 x_clipboard_manager_save (Bug#8779).
5232 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5233 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5234
99a33b77 52352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5236
5237 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5238
99a33b77 52392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5240
5241 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5242 in the current matrix if keep_current_p is non-zero.
5243
8264569d
EZ
52442011-06-04 Eli Zaretskii <eliz@gnu.org>
5245
5246 * bidi.c (bidi_level_of_next_char): Fix last change.
5247
57f97249
EZ
52482011-06-03 Eli Zaretskii <eliz@gnu.org>
5249
fec2107c 5250 Support bidi reordering of text covered by display properties.
57f97249 5251
fec2107c
EZ
5252 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5253 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5254 (bidi_cache_search, bidi_cache_iterator_state)
5255 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5256 (bidi_level_of_next_char, bidi_move_to_visually_next):
5257 Support character positions inside a run of characters covered by a
fec2107c
EZ
5258 display string.
5259 (bidi_paragraph_init, bidi_resolve_explicit_1)
5260 (bidi_level_of_next_char): Call bidi_fetch_char and
5261 bidi_fetch_char_advance instead of FETCH_CHAR and
5262 FETCH_CHAR_ADVANCE.
5263 (bidi_init_it): Initialize new members.
5264 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5265 definitions.
5266 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5267 instead of using explicit *_CHAR codes.
d6d100dd
SM
5268 (bidi_resolve_explicit, bidi_resolve_weak):
5269 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5270 bidirectional text is supported only in multibyte buffers.
5271 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5272 it to initialize the frame_window_p member of struct bidi_it.
5273 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5274 (bidi_resolve_explicit, bidi_resolve_weak)
5275 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5276 bidi_it->nchars is non-positive.
5277 (bidi_level_of_next_char): Don't try to lookup the cache for the
5278 next/previous character if nothing is cached there yet, or if we
5279 were just reseat()'ed to a new position.
c40e2fb2 5280
0e14fe90
EZ
5281 * xdisp.c (set_cursor_from_row): Set start and stop points
5282 according to the row's direction when priming the loop that looks
5283 for the glyph on which to display cursor.
5284 (single_display_spec_intangible_p): Function deleted.
5285 (display_prop_intangible_p): Reimplement to call
5286 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5287 Accept 3 additional arguments needed by handle_display_spec.
5288 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5289 values: lists, `(when COND...)' forms, etc.
5290 (single_display_spec_string_p): Support property values that are
5291 lists with the argument STRING its top-level element.
5292 (display_prop_string_p): Fix the condition for processing a
5293 property that is a list to be consistent with handle_display_spec.
fec2107c 5294 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5295 last portion of handle_display_prop.
5296 (compute_display_string_pos): Accept additional argument
5297 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5298 value of a `display' property is a "replacing spec".
5299 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5300 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5301 the display property, but just return a value indicating whether
5302 the display property will replace the characters it covers.
5303 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5304 frame_window_p members of struct bidi_it.
d6d100dd
SM
5305 (compute_display_string_pos, compute_display_string_end):
5306 New functions.
fec2107c
EZ
5307 (push_it): Accept second argument POSITION, where pop_it should
5308 jump to continue iteration.
5309 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5310
fec2107c
EZ
5311 * keyboard.c (adjust_point_for_property): Adjust the call to
5312 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5313
5314 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5315 (bidi_init_it): Update prototypes.
5316 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5317 (compute_display_string_pos, compute_display_string_end):
5318 Declare prototypes.
fec2107c
EZ
5319 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5320 EMACS_INT.
fc6f18ce 5321
40087514 53222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5323
57f53182
PE
5324 Malloc failure behavior now depends on size of allocation.
5325 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5326 * lisp.h: Change signatures accordingly.
5327 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5328 All callers changed. (Bug#8762)
5329
5330 * gnutls.c: Use Emacs's memory allocators.
5331 Without this change, the gnutls library would invoke malloc etc.
5332 directly, which causes problems on non-SYNC_INPUT hosts, and which
5333 runs afoul of improving memory_full behavior. (Bug#8761)
5334 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5335 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5336 xfree instead of the default malloc, realloc, free.
5337 (Fgnutls_boot): No need to check for memory allocation failure,
5338 since xmalloc does that for us.
5339
ac32cd99 5340 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5341 * category.c (hash_get_category_set):
5342 * ccl.c (ccl_driver):
5343 * charset.c (Fdefine_charset_internal):
5344 * charset.h (struct charset.hash_index):
5345 * composite.c (get_composition_id, gstring_lookup_cache)
5346 (composition_gstring_put_cache):
5347 * composite.h (struct composition.hash_index):
5348 * dispextern.h (struct image.hash):
5349 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5350 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5351 (hashfn_equal, hashfn_user_defined, make_hash_table)
5352 (maybe_resize_hash_table, hash_lookup, hash_put)
5353 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5354 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5355 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5356 * image.c (make_image, search_image_cache, lookup_image)
5357 (xpm_put_color_table_h):
5358 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5359 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5360 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5361 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5362 * alloc.c (allocate_vectorlike):
5363 Check for overflow in vector size calculations.
5364 * ccl.c (ccl_driver):
5365 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5366 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5367 need to be updated by these changes.
40087514
PE
5368 * fns.c (make_hash_table, maybe_resize_hash_table):
5369 Check for integer overflow with large hash tables.
0de4bb68
PE
5370 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5371 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5372 (SXHASH_REDUCE): New macro.
5373 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5374 Use it instead of discarding useful hash info with large hash values.
5375 (sxhash_float): New function.
5376 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5377 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5378 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5379 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5380 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5381 Adjust signatures to match updated version of code.
5382 (consing_since_gc): Now EMACS_INT, since a single hash table can
5383 use more than INT_MAX bytes.
5384
698d32e2
DN
53852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5386
5387 Make it possible to build with GCC-4.6+ -O2 -flto.
5388
5389 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5390
fd6fa53f
SM
53912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5392
5393 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5394 Call minibuffer-inactive-mode.
5395
864db017
JB
53962011-05-31 Juanma Barranquero <lekktu@gmail.com>
5397
5398 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5399 Update dependencies.
5400
2ad0baf4
DN
54012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5402
5403 * data.c (init_data): Remove code for UTS, this system is not
5404 supported anymore.
5405
4fcc2638
DN
54062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5407
5408 Don't force ./temacs to start in terminal mode.
5409
5410 * frame.c (make_initial_frame): Initialize faces in all cases, not
5411 only when CANNOT_DUMP is defined.
5412 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5413
c56e0fd5
DN
54142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5415
5416 * dispnew.c (add_window_display_history): Use const for the string
5417 pointer. Remove declaration, not needed.
5418
333d54da 54192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5420
55d4c1b2 5421 Use 'inline', not 'INLINE'.
333d54da 5422 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5423 * alloc.c, fontset.c (INLINE): Remove.
5424 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5425 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5426 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5427 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5428 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5429
738db178
DN
54302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5431
5432 Make it possible to run ./temacs.
5433
5434 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5435 syms_of_callproc does the same thing. Remove test for
5436 "initialized", do it in the caller.
5437 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5438
620c53a6
SM
54392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5440
5441 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5442 (read_minibuf): Use get_minibuffer.
5443 (syms_of_minibuf): Use DEFSYM.
5444 (Qmetadata): New var.
5445 * data.c (Qbuffer): Don't make it static.
5446 (syms_of_data): Use DEFSYM.
5447
e003a292
PE
54482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5449
5450 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5451 (CCL_CODE_MIN): New macro.
5452
ed008a6d
PE
54532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5454
3687c2ef
PE
5455 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5456
ed008a6d
PE
5457 * eval.c (Qdebug): Now static.
5458 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5459 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5460 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5461
d66c4c7c
CY
54622011-05-29 Chong Yidong <cyd@stupidchicken.com>
5463
5464 * image.c: Various fixes to ImageMagick code comments.
5465 (Fimagemagick_types): Doc fix.
5466
5fbc2025
PE
54672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5468
0196f88a
PE
5469 Minor fixes prompted by GCC 4.6.0 warnings.
5470
5471 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5472
5fbc2025
PE
5473 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5474 (x_clipboard_manager_save_all): Move extern decl to ...
5475 * xterm.h: ... here, so that it can be checked for consistency.
5476
1dd3c2d9
CY
54772011-05-29 Chong Yidong <cyd@stupidchicken.com>
5478
5479 * xselect.c (x_clipboard_manager_save_frame)
5480 (x_clipboard_manager_save_all): New functions.
5481 (Fx_clipboard_manager_save): Lisp function deleted.
5482
5483 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5484 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5485
5486 * xterm.h: Update prototype.
5487
5ba6571d
WX
54882011-05-28 William Xu <william.xwl@gmail.com>
5489
5490 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5491 exiting (Bug#8239).
5492
3eaff834
JM
54932011-05-28 Jim Meyering <meyering@redhat.com>
5494
e1900994 5495 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5496 * fns.c (to_uchar): Define.
5497 (crypto_hash_function): Use it to convert some newly-signed
5498 variables to unsigned, to avoid sign-extension bugs. For example,
5499 without this change, (md5 "truc") would evaluate to
5500 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5501 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5502 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5503
0f6990a7
PE
55042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5505
5506 Integer overflow fixes.
c8a9ca5a 5507
08686060
PE
5508 * dbusbind.c: Serial number integer overflow fixes.
5509 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5510 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5511 to hold a serial number that is too large for a fixnum.
5512 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5513 Check for serial numbers out of range. Decode any serial number
59568bf0 5514 that was so large that it became a float. (Bug#8722)
08686060 5515
2d1fc3c7
PE
5516 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5517 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5518 Use XFASTINT rather than XUINT when numbers are nonnegative.
5519 (xd_append_arg, Fdbus_method_return_internal):
5520 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5521 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5522 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5523 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5524 (Bug#8722)
2d1fc3c7 5525
c8a9ca5a
PE
5526 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5527
519e1d69
PE
5528 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5529
30569699
PE
5530 ccl: add integer overflow checks
5531 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5532 (IN_INT_RANGE): New macros.
5533 (ccl_driver): Use them to check for integer overflow when
5534 decoding a CCL program. Many of the new checks are whether XINT (x)
5535 fits in int; it doesn't always, on 64-bit hosts. The new version
5536 doesn't catch all possible integer overflows, but it's an
847044ea 5537 improvement. (Bug#8719)
30569699 5538
c11285dc
PE
5539 * alloc.c (make_event_array): Use XINT, not XUINT.
5540 There's no need for unsigned here.
5541
fdccd48e
PE
5542 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5543 This follows up to the 2011-05-06 change that substituted uintptr_t
5544 for EMACS_INT. This case wasn't caught back then.
5545
37910ab2
PE
5546 Rework Fformat to avoid integer overflow issues.
5547 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5548 now (part of C89). Include <verify.h>.
5549 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5550 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5551 (Fformat): Avoid the prepass trying to compute sizes; it was only
5552 approximate and thus did not catch overflow reliably. Instead, walk
5553 through the format just once, formatting and computing sizes as we go,
5554 checking for integer overflow at every step, and allocating a larger
5555 buffer as needed. Keep track separately whether the format is
5556 multibyte. Keep only the most-recently calculated precision, rather
5557 than them all. Record whether each argument has been converted to
5558 string. Use EMACS_INT, not int, for byte and char and arg counts.
5559 Support field widths and precisions larger than INT_MAX. Avoid
5560 sprintf's undefined behavior with conversion specifications such as %#d
5561 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5562 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5563 formatting out-of-range floating point numbers with int
9173deec 5564 formats. (Bug#8668)
37910ab2 5565
2e6578fb
PE
5566 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5567
0ae6bdee
PE
5568 * data.c: Avoid integer truncation in expressions involving floats.
5569 * data.c: Include <intprops.h>.
5570 (arith_driver): When there's an integer overflow in an expression
5571 involving floating point, convert the integers to floating point
5572 so that the resulting value does not suffer from catastrophic
5573 integer truncation. For example, on a 64-bit host (* 4
5574 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5575 Do not rely on undefined behavior after integer overflow.
5576
de883a70
PE
5577 merge count_size_as_multibyte, parse_str_to_multibyte
5578 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5579 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5580 Check for integer overflow.
5581 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5582 since it's now a duplicate of the other. This is more of
5583 a character than a buffer op, so better that it's in character.c.
5584 * fns.c, print.c: Adjust to above changes.
5585
2ff916cb
PE
55862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5587
5588 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5589
f1b54466
PE
55902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5591
fb1ac845
PE
5592 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5593 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5594 (x_clipboard_manager_save): Now static.
5595 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5596
f1b54466
PE
5597 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5598 (crypto_hash_function): Now static.
5599 Fix pointer signedness problems. Avoid unnecessary initializations.
5600
a9f737ee
CY
56012011-05-27 Chong Yidong <cyd@stupidchicken.com>
5602
5603 * termhooks.h (Vselection_alist): Make it terminal-local.
5604
5605 * terminal.c (create_terminal): Initialize it.
5606
5607 * xselect.c: Support for clipboard managers.
5608 (Vselection_alist): Move to termhooks.h as terminal-local var.
5609 (LOCAL_SELECTION): New macro.
5610 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5611 (symbol_to_x_atom): Remove gratuitous arg.
5612 (x_handle_selection_request, lisp_data_to_selection_data)
5613 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5614 (x_own_selection, x_get_local_selection, x_convert_selection):
5615 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5616 (some_frame_on_display): Delete unused function.
5617 (Fx_own_selection_internal, Fx_get_selection_internal)
5618 (Fx_disown_selection_internal, Fx_selection_owner_p)
5619 (Fx_selection_exists_p): New optional frame arg.
5620 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5621 (x_handle_selection_clear): Don't treat other terminals with the
5622 same keyboard specially. Use the terminal-local Vselection_alist.
5623 (x_clear_frame_selections): Use Frun_hook_with_args.
5624
5625 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5626
5627 * xterm.h: Add support for those atoms.
5628
e067f0c1
CY
56292011-05-26 Chong Yidong <cyd@stupidchicken.com>
5630
5631 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5632 (converted_selections, conversion_fail_tag): New global variables.
5633 (x_selection_request_lisp_error): Free the above.
5634 (x_get_local_selection): Remove unnecessary code.
5635 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5636 of converted selections stored in converted_selections.
5637 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5638 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5639 (x_convert_selection): New function.
5640 (x_handle_selection_event): Simplify.
5641 (x_get_foreign_selection): Don't ignore incoming requests while
5642 waiting for an answer; this will fail when we implement
5643 SAVE_TARGETS, and seems unnecessary anyway.
5644 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5645 (Vx_sent_selection_functions): Doc fix.
5646
0f4aebc0
LL
56472011-05-26 Leo Liu <sdl.web@gmail.com>
5648
5649 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5650
e61124cd
YM
56512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5652
5653 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5654
5655 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5656 for fringe update if it has periodic bitmap.
ac389d0c 5657 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5658 and fringe_bitmap_periodic_p.
5659
5660 * fringe.c (get_fringe_bitmap_data): New function.
5661 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5662 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5663 row. Mark glyph row for fringe update if periodicity changed.
5664
5665 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5666 for fringe update unless it has periodic bitmap.
5667
f16d9837
KH
56682011-05-25 Kenichi Handa <handa@m17n.org>
5669
5670 * xdisp.c (get_next_display_element): Set correct it->face_id for
5671 a static composition.
5672
e1b90ef6
LL
56732011-05-24 Leo Liu <sdl.web@gmail.com>
5674
5675 * deps.mk (fns.o):
5676 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5677
5678 * fns.c (crypto_hash_function, Fsha1): New function.
5679 (Fmd5): Use crypto_hash_function.
5680 (syms_of_fns): Add Ssha1.
5681
7400048f
PE
56822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5683
5684 * gnutls.c: Remove unused macros.
5685 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5686 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5687 Remove macros that are defined and never used.
5688 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5689
abb71cf4
CY
56902011-05-22 Chong Yidong <cyd@stupidchicken.com>
5691
5692 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5693 (Fx_get_selection_internal): Minor cleanup.
5694 (Fx_own_selection_internal): Rename arguments for consistency with
5695 select.el.
5696
6307db39
PE
56972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5698
5699 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5700
f3d4e0a4
CY
57012011-05-22 Chong Yidong <cyd@stupidchicken.com>
5702
5703 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5704
4d8ade89
YM
57052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5706
5707 * dispnew.c (scrolling_window): Don't exclude the case that the
5708 last enabled row in the desired matrix touches the bottom boundary.
5709
32078c8d
GM
57102011-05-21 Glenn Morris <rgm@gnu.org>
5711
5712 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5713 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5714 and add some more files.
32078c8d 5715
7285dc67
EZ
57162011-05-20 Eli Zaretskii <eliz@gnu.org>
5717
5718 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5719 report_file_error introduced by the change from 2011-05-07.
5720
89d1bd22
PE
57212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5722
5723 * systime.h (Time): Define only if emacs is defined.
5724 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5725 where the include path doesn't have X11/X.h by default. See
5726 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5727
e23640bb 57282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5729
5730 * composite.c (find_automatic_composition): Fix previous change.
5731
b9704ad9
GM
57322011-05-20 Glenn Morris <rgm@gnu.org>
5733
5734 * lisp.mk: New file, split from Makefile.in.
5735 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5736 (shortlisp): Remove.
5737 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5738
4a720484
GM
57392011-05-19 Glenn Morris <rgm@gnu.org>
5740
5741 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5742 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5743 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5744 (lisp): Set the order to that of loadup.el.
5745 (shortlisp): Make it a copy of $lisp.
5746 (SOME_MACHINE_LISP): Remove.
5747 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5748 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5749
a28d4396
KH
57502011-05-18 Kenichi Handa <handa@m17n.org>
5751
5752 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5753 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5754 (find_automatic_composition): Mostly rewrite for efficiency.
5755
a2b1fa8e
JB
57562011-05-18 Juanma Barranquero <lekktu@gmail.com>
5757
5758 * makefile.w32-in: Update dependencies.
5759
8e1f5610
CS
57602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5761
5762 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5763 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5764
7025ee00 57652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5766
cdfa6eab
PE
5767 Fix some integer overflow issues, such as string length overflow.
5768
06d6db33
PE
5769 * insdel.c (count_size_as_multibyte): Check for string overflow.
5770
2b4560a8
PE
5771 * character.c (lisp_string_width): Check for string overflow.
5772 Use EMACS_INT, not int, for string indexes and lengths; in
5773 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5774 the resulting string length overflows an EMACS_INT; instead,
5775 report a string overflow if no precision given. When checking for
5776 precision exhaustion, use a check that cannot possibly have
5777 integer overflow. (Bug#8675)
5778 * character.h (lisp_string_width): Adjust to new signature.
5779
cb93f9be
PE
5780 * alloc.c (string_overflow): New function.
5781 (Fmake_string): Use it. This doesn't change behavior, but saves
5782 a few bytes and will simplify future changes.
5783 * character.c (string_escape_byte8): Likewise.
5784 * lisp.h (string_overflow): New decl.
5785
1a1f3366
PE
5786 Fixups, following up to the user-interface timestamp change.
5787 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5788 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5789 * msdos.c (mouse_get_pos): Likewise.
5790 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5791 * w32gui.h (Time): Define by including "systime.h" rather than by
5792 declaring it ourselves. (Bug#8664)
5793
d4e3e4d3
PE
5794 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5795 * image.c (clear_image_cache): Likewise.
5796
f6a24d19
PE
5797 * term.c (term_mouse_position): Don't assume time_t wraparound.
5798
08dc5ae6
PE
5799 Be more systematic about user-interface timestamps.
5800 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5801 and sometimes 'EMACS_UINT', to represent these timestamps.
5802 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5803 This makes the code easier to follow, and makes it easier to catch
5804 integer overflow bugs such as Bug#8664.
5805 * frame.c (Fmouse_position, Fmouse_pixel_position):
5806 Use Time, not unsigned long, for user-interface timestamps.
5807 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5808 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5809 * keyboard.h (last_event_timestamp): Likewise.
5810 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5811 * menu.h (xmenu_show): Likewise.
5812 * term.c (term_mouse_position): Likewise.
5813 * termhooks.h (struct input_event.timestamp): Likewise.
5814 (struct terminal.mouse_position_hook): Likewise.
5815 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5816 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5817 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5818 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5819 what it was before.
5820 * menu.h, termhooks.h: Include "systime.h", for Time.
5821
8e55734a
PE
5822 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5823 Don't assume that the difference between two unsigned long values
5824 can fit into an integer. At this point, we know button_down_time
5825 <= event->timestamp, so the difference must be nonnegative, so
5826 there's no need to cast the result if double-click-time is
5827 nonnegative, as it should be; check that it's nonnegative, just in
5828 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5829 apart (about 25 days). (Bug#8664)
8e55734a 5830
841f1b75 5831 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5832 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5833
3e26f69c
PE
5834 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5835 that always fit in int. Use a sentinel instead of a counter, to
5836 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5837 * frame.h (struct frame): Use int for menu_bar_items_used
5838 instead of EMACS_INT, since it always fits in int.
3e26f69c 5839
5cc152c0
PE
5840 * menu.c (grow_menu_items): Check for int overflow.
5841
d89eb65e
PE
5842 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5843
5235bd3e
PE
5844 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5845 Before, the code was not consistent. These values cannot exceed
5846 2**31 - 1 so there's no need to make them unsigned.
5847 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5848 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5849 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5850 as modifiers.
5851 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5852
bc827e23
PE
5853 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5854 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5855 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5856 presumably because the widths might not match.
5857
78eb494e
PE
5858 * window.c (size_window): Avoid needless test at loop start.
5859
04f2d78b
CB
58602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5861
5862 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5863
d2fc7e3d 58642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5865
5866 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5867
d2fc7e3d 58682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5869
5870 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5871 `width' to `bar_area_x' and `bar_area_width', respectively.
5872 (x_scroll_run): Take account of fringe background extension.
5873
04f2d78b
CB
5874 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5875 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5876 `bar_area_width', respectively.
5877 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5878 background extension.
5879
79b70037
GM
58802011-05-10 Jim Meyering <meyering@redhat.com>
5881
5882 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5883
2f142cc5
JB
58842011-05-10 Juanma Barranquero <lekktu@gmail.com>
5885
5886 * image.c (Finit_image_library): Return t for built-in image types,
5887 like pbm and xbm. (Bug#8640)
5888
57679c86
AS
58892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5890
5891 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5892
888c9e86
EZ
58932011-05-07 Eli Zaretskii <eliz@gnu.org>
5894
b0512a1d
EZ
5895 * w32console.c (Fset_screen_color): Doc fix.
5896 (Fget_screen_color): New function.
5897 (syms_of_ntterm): Defsubr it.
5898
7285dc67
EZ
5899 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5900 unlink the temporary file if Fcall_process didn't create it in the
5901 first place.
5902 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5903 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5904 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5905 cue to call_process_cleanup not to close that handle.
5906
4d3fcc8e
BK
59072011-05-07 Ben Key <bkey76@gmail.com>
5908
5909 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5910 one of two shell specific rules, either bootstrap-temacs-CMD or
5911 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5912 to the previous implementation of the bootstrap-temacs rule.
5913 The bootstrap-temacs-CMD rule is similar to the previous
5914 implementation of the bootstrap-temacs rule except that it
5915 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5916 variable.
5917
5918 These changes, along with some changes to nt/configure.bat,
5919 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5920 earlier fix to add support for --cflags and --ldflags options
5921 that include quotes so that it works whether make uses cmd or
5922 sh as the shell.
5923
b4289b64
MA
59242011-05-06 Michael Albinus <michael.albinus@gmx.de>
5925
5926 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5927 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5928 is a constant.
5929 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5930 a string. Handle both cases.
5931 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5932 (Fdbus_register_method): Use Qinvalid_function.
5933
af4c0e28
JB
59342011-05-06 Juanma Barranquero <lekktu@gmail.com>
5935
5936 * makefile.w32-in: Update dependencies.
5937 (LISP_H): Add inttypes.h and stdin.h.
5938 (PROCESS_H): Add unistd.h.
5939
c51453d9
EZ
59402011-05-06 Eli Zaretskii <eliz@gnu.org>
5941
5942 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5943 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5944
8ff0ac3c 59452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5946
4c4b566b
PE
5947 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5948
aab2b9b5
PE
5949 * term.c (vfatal): Remove stray call to va_end.
5950 It's not needed and the C Standard doesn't allow it here anyway.
5951
c378da0b
PE
5952 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5953 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5954
288b08c7
PE
5955 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5956 bytes.
5957
e3601888
PE
5958 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5959
db6c0e74
PE
5960 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5961
dd5963ea
PE
5962 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5963
88c9450f
PE
5964 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5965
2f9442b8
PE
5966 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5967
c032b5f8
PE
5968 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5969 * charset.c (Fdefine_charset_internal): Don't initialize
5970 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5971 32-bit int (Bug#8600).
a108c10b
PE
5972
5973 * lread.c (read_integer): Be more consistent with string-to-number.
5974 Use string_to_number to do the actual conversion; this avoids
5975 rounding errors and fixes some other screwups. Without this fix,
5976 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5977 (digit_to_number): Move earlier, for benefit of read_integer.
5978 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5979 not a digit in any supported base. (Bug#8602)
a108c10b 5980
ad5f9eea
PE
5981 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5982
aec1708a
PE
5983 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5984 to match comment at start of function. This also removes a
5985 GCC warning about overflow in a 32+64-bit port.
5986
47be4ab5
PE
5987 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5988
371cac43
PE
5989 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5990 Reported by Stefan Monnier in
5991 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5992 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5993 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5994
d01a7826
PE
5995 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5996 (EMACS_UINTPTR): Likewise, with uintptr_t.
5997
7fd47d5c
PE
5998 * lisp.h: Prefer 64-bit EMACS_INT if available.
5999 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6000 on 32-bit hosts that have 64-bit int, so that they can access
6001 large files.
122b0c86
PE
6002 However, temporarily disable this change unless the temporary
6003 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6004
8727937b
PE
6005 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6006
8ac068ac
PE
6007 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6008 This removes an assumption that EMACS_INT and long are the same
6009 width as pointers. The assumption is true for Emacs porting targets
6010 now, but we want to make other targets possible.
6011 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6012 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6013 In the rest of the code, change types of integers that hold casted
6014 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6015 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6016 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6017 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6018 No need to cast type when ORing.
6019 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6020 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6021 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6022 assume EMACS_INT is the same width as char *.
6023 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6024 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6025 Remove no-longer-needed casts.
6026 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6027 (xg_tool_bar_help_callback, xg_make_tool_item):
6028 Use EMACS_INTPTR to hold an integer
6029 that will be cast to void *; this can avoid a GCC warning
6030 if EMACS_INT is not the same width as void *.
6031 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6032 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6033 (current_message_1, set_message_1):
6034 Use a local to convert to proper width without a cast.
6035 * xmenu.c (dialog_selection_callback): Likewise.
6036
ede49d71
PE
6037 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6038 Also, don't assume VALBITS / RAND_BITS is less than 5,
6039 and don't rely on undefined behavior when shifting a 1 left into
6040 the sign bit.
6041 * lisp.h (get_random): Change signature to match.
6042
2f30ecd0
PE
6043 * lread.c (hash_string): Use size_t, not int, for hash computation.
6044 Normally we prefer signed values; but hashing is special, because
6045 it's better to use unsigned division on hash table sizes so that
6046 the remainder is nonnegative. Also, size_t is the natural width
6047 for hashing into memory. The previous code used 'int', which doesn't
6048 retain enough info to hash well into very large tables.
6049 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6050
2a866e7b
PE
6051 * dbusbind.c: Don't possibly lose pointer info when converting.
6052 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6053 Use XPNTR rather than XHASH, so that the high-order bits of
6054 the pointer aren't lost when converting through void *.
6055
51639eac
PE
6056 * eval.c (Fautoload): Don't double-shift a pointer.
6057
92394119
PE
6058 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6059
dbdb9a7c
JB
60602011-05-06 Juanma Barranquero <lekktu@gmail.com>
6061
6062 * gnutls.c (DEF_GNUTLS_FN):
6063 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6064
db7a0b4f
AS
60652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6066
6067 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6068 marker. (Bug#8610)
6069
f7ff1b0f 60702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6071
6072 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6073 New version that can reserve upto 2GB of heap space.
6074
f7ff1b0f 60752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6076
6077 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6078
639c109b
TZ
60792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6080
6081 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6082 `gnutls_certificate_set_x509_key_file'.
6083
d2127135
JB
60842011-05-05 Juanma Barranquero <lekktu@gmail.com>
6085
6086 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6087 Update dependencies.
6088
e968f4f3
JB
60892011-05-04 Juanma Barranquero <lekktu@gmail.com>
6090
6091 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6092 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6093 Remove unused parameter `fildes'.
6094 * process.c (read_process_output, send_process): Don't pass it.
6095
84d358f0
JB
60962011-05-04 Juanma Barranquero <lekktu@gmail.com>
6097
6098 Fix previous change: the library cache is defined in w32.c.
6099 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6100 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6101
0898ca10
JB
61022011-05-04 Juanma Barranquero <lekktu@gmail.com>
6103
6104 Implement dynamic loading of GnuTLS on Windows.
6105
6106 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6107 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6108 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6109 Declare.
6110
6111 * gnutls.c (Qgnutls_dll): Define.
6112 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6113 (gnutls_*): Declare function pointers.
6114 (init_gnutls_functions): New function to initialize function pointers.
6115 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6116 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6117 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6118 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6119 (emacs_gnutls_write, emacs_gnutls_read)
6120 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6121 (Fgnutls_available_p): New function.
6122 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6123 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6124 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6125
6126 * image.c: Include w32.h.
6127 (Vimage_type_cache): Delete.
6128 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6129 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6130 (w32_delayed_load): Move to w32.c.
6131
6132 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6133
6134 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6135 (w32_delayed_load): Move from image.c. When loading a library, record
6136 its filename in the :loaded-from property of the library id.
6137 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6138 Initialize and staticpro them.
6139 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6140
6141 * process.c: Include lisp.h before w32.h, not after.
6142 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6143 instead of gnutls_record_check_pending.
6144
6145 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6146
ff4de4aa
TZ
61472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6148
6149 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6150 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6151 as passed in.
6152
abe95abb
JD
61532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6154
6155 * xterm.c (x_set_frame_alpha): Do not set property on anything
6156 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6157
e16e55d4
JB
61582011-05-02 Juanma Barranquero <lekktu@gmail.com>
6159
6160 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6161
bafcf6a5
JB
61622011-05-02 Juanma Barranquero <lekktu@gmail.com>
6163
6164 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6165 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6166 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6167 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6168 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6169 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6170 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6171 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6172 (Qgnutls_bootprop_callbacks_verify): Make static.
6173
e7a6747f
AS
61742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6175
19ed11ba
AS
6176 * callproc.c: Indentation fixup.
6177
e7a6747f 6178 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6179 (wait_for_termination, interruptible_wait_for_termination):
6180 Move after wait_for_termination_1.
e7a6747f 6181
1ef14cb4
LMI
61822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6183
6184 * sysdep.c (interruptible_wait_for_termination): New function
6185 which is like wait_for_termination, but allows keyboard
6186 interruptions.
6187
6188 * callproc.c (Fcall_process): Add (:file "file") as an option for
6189 the STDOUT buffer.
6190 (Fcall_process_region): Ditto.
6191
330d880c
EZ
61922011-04-30 Eli Zaretskii <eliz@gnu.org>
6193
8db90b73
EZ
6194 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6195 rather than `XVECTOR (FOO)->size'.
6196
330d880c
EZ
6197 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6198 inttypes.h, as a gnulib replacement is used if it not available in
6199 system headers.
6200
15cbd324
EZ
62012011-04-21 Eli Zaretskii <eliz@gnu.org>
6202
6203 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6204 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6205 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6206
6207 * coding.c (coding_alloc_by_realloc): Error out if destination
6208 will grow beyond MOST_POSITIVE_FIXNUM.
6209 (decode_coding_emacs_mule): Abort if there isn't enough place in
6210 charbuf for the composition carryover bytes. Reserve an extra
6211 space for up to 2 characters produced in a loop.
6212 (decode_coding_iso_2022): Abort if there isn't enough place in
6213 charbuf for the composition carryover bytes.
6214
62152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6216
ae940cca
EZ
6217 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6218 aborting when %lld or %lll format is passed.
6219 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6220 %llo or %llx format is passed. (Bug#8545)
6221
03ab8921
EZ
6222 * window.c (window_scroll_line_based): Use a marker instead of
6223 simple variables to record original value of point. (Bug#7952)
6224
afda1437
EZ
6225 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6226 produced by %s or %c overflows available buffer space. (Bug#8545)
6227
f76dee0c
PE
62282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6229
6230 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6231 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6232
fdc5744d
JB
62332011-04-28 Juanma Barranquero <lekktu@gmail.com>
6234
6235 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6236
638f053a
JB
62372011-04-28 Juanma Barranquero <lekktu@gmail.com>
6238
6239 * keyboard.c (Qdelayed_warnings_hook): Define.
6240 (command_loop_1): Run `delayed-warnings-hook'
6241 if Vdelayed_warnings_list is non-nil.
6242 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6243 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6244
d178f871
EZ
62452011-04-28 Eli Zaretskii <eliz@gnu.org>
6246
6247 * doprnt.c (doprnt): Don't return value smaller than the buffer
6248 size if the message was truncated. (Bug#8545).
6249
b124fd93
JB
62502011-04-28 Juanma Barranquero <lekktu@gmail.com>
6251
6252 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6253 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6254
e810457d
PE
62552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6256
6257 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6258
ea51cceb
JB
62592011-04-27 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * makefile.w32-in: Update dependencies.
6262
94dcfacf
EZ
62632011-04-27 Eli Zaretskii <eliz@gnu.org>
6264
6265 Improve `doprnt' and its usage. (Bug#8545)
6266 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6267 `format_end'. Remove support for %l as a conversion specifier.
6268 Don't use xrealloc. Improve diagnostics when the %l size modifier
6269 is used. Update the commentary.
6270
6271 * eval.c (verror): Simplify calculation of size_t.
6272
6273 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6274 messages.
6275
f61f41d7
PE
62762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6277
6278 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6279 change.
6280
96fb4434
PE
62812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6282
6283 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6284 This makes this file independent of the recent pseudovector change.
6285
671875da 62862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6287
69e9b5a3
PE
6288 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6289
b5f869a7 6290 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6291 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6292 Remove unused local.
c8926152 6293 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6294
841a1577 6295 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6296 GCC 4.6.0 optimizes based on type-based alias analysis.
6297 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6298 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6299 != &v->size, and therefore "v->size = 1; b->size = 2; return
6300 v->size;" must therefore return 1. This assumption is incorrect
6301 for Emacs, since it type-puns struct Lisp_Vector * with many other
6302 types. To fix this problem, this patch adds a new type struct
f904488f 6303 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6304 and pseudovectors, and helps optimizing compilers not get fooled
6305 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6306 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6307 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6308 the size member.
eab3844f
PE
6309 (XSETPVECTYPE): Rewrite in terms of new macro.
6310 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6311 This is a bit clearer, and further avoids the possibility of
6312 undesirable aliasing.
6313 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6314 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6315 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6316 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6317 (ASIZE): Now uses header.size rather than size.
6318 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6319 to avoid the hassle of writing XVECTOR (foo)->header.size.
6320 (struct vectorlike_header): New type.
eab3844f
PE
6321 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6322 object, to help avoid aliasing.
6323 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6324 (SUBRP): Likewise, since Lisp_Subr is a special case.
6325 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6326 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6327 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6328 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6329 changed to be "header.size" and "header.next".
6330 * buffer.h (struct buffer): Likewise.
6331 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6332 * frame.h (struct frame): Likewise.
6333 * process.h (struct Lisp_Process): Likewise.
6334 * termhooks.h (struct terminal): Likewise.
6335 * window.c (struct save_window_data, struct saved_window): Likewise.
6336 * window.h (struct window): Likewise.
6337 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6338 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6339 * buffer.c (init_buffer_once): Likewise.
6340 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6341 special case.
6342 * process.c (Fformat_network_address): Use local var for size,
6343 for brevity.
6344
0df1eac5
PE
6345 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6346
847ab9d1 6347 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6348 * data.c (atof): Remove decl; no longer used or needed.
6349 (digit_to_number): Move to lread.c.
6350 (Fstring_to_number): Use new string_to_number function, to be
6351 consistent with how the Lisp reader treats infinities and NaNs.
6352 Do not assume that floating-point numbers represent EMACS_INT
6353 without losing information; this is not true on most 64-bit hosts.
6354 Avoid double-rounding errors, by insisting on integers when
6355 parsing non-base-10 numbers, as the documentation specifies.
6356 * lisp.h (string_to_number): New decl, replacing ...
6357 (isfloat_string): Remove.
bc0a5c13 6358 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6359 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6360 appears to have been a coding error. Similarly, do not accept
6361 strings like +-1e0 as floating point numbers. Do not report
6362 overflow for integer overflows unless the base is not 10 which
6363 means we have no simple and reliable way to continue.
6364 Break out the floating-point parsing into a new
6365 function string_to_number, so that Fstring_to_number parses
6366 floating point numbers consistently with the Lisp reader.
04f2d78b 6367 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6368 (E_CHAR, EXP_INT): Remove, replacing with ...
6369 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6370 (string_to_number): New function, replacing isfloat_string.
6371 This function checks for valid syntax and produces the resulting
6372 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6373 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6374 so that overflow for non-base-10 numbers is reported only when
6375 there's no portable and simple way to convert to floating point.
452f4150 6376
67769ffc
PE
6377 * textprop.c (set_text_properties_1): Rewrite for clarity,
6378 and to avoid GCC warning about integer overflow.
6379
c20db43f
PE
6380 * intervals.h (struct interval): Use EMACS_INT for members
6381 where EMACS_UINT might cause problems. See
6382 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6383 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6384 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6385 All uses changed.
37aa2f85
PE
6386 (offset_intervals): Tell GCC not to worry about length overflow
6387 when negating a negative length.
c20db43f 6388
2538aa2f
PE
6389 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6390 (overrun_check_free): Likewise.
6391
f2d3008d
PE
6392 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6393 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6394 word size.
6395
ec8df744
PE
6396 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6397 (gnutls_make_error): Rename local to avoid shadowing.
6398 (gnutls_emacs_global_deinit): ifdef out; not used.
6399 (Fgnutls_boot): Use const for pointer to readonly storage.
6400 Comment out unused local. Fix pointer signedness problems.
6401
640ee02d
PE
6402 * lread.c (openp): Don't stuff size_t into an 'int'.
6403 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6404 about possible signed overflow.
6405
6048fb2a
PE
6406 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6407 (GDK_KEY_g): Don't define if already defined.
6408 (xg_prepare_tooltip): Avoid pointer signedness problem.
6409 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6410
fa3c87e1
PE
6411 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6412 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6413
2172544b
PE
6414 * xfns.c (Fx_window_property): Simplify a bit,
6415 to make a bit faster and to avoid GCC 4.6.0 warning.
6416 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6417
9b821a21
PE
6418 * fns.c (internal_equal): Don't assume size_t fits in int.
6419
3c616cfa
PE
6420 * alloc.c (compact_small_strings): Tighten assertion a little.
6421
c2982e87
PE
6422 Replace pEd with more-general pI, and fix some printf arg casts.
6423 * lisp.h (pI): New macro, generalizing old pEd macro to other
6424 conversion specifiers. For example, use "...%"pI"d..." rather
6425 than "...%"pEd"...".
6426 (pEd): Remove. All uses replaced with similar uses of pI.
6427 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6428 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6429 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6430 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6431 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6432 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6433 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6434 64-bit hosts.
6435 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6436 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6437 * print.c (safe_debug_print, print_object): Likewise.
6438 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6439 to int.
6f04d126
PE
6440 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6441 avoiding the 0 flag, which is not portable.
c2982e87
PE
6442 * process.c (Fmake_network_process): Use pI to avoid cast.
6443 * region-cache.c (pp_cache): Likewise.
6444 * xdisp.c (decode_mode_spec): Likewise.
6445 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6446 behavior on 64-bit hosts with printf arg.
6f04d126 6447 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6448 (x_stop_queuing_selection_requests): Likewise.
6449 (x_get_window_property): Don't truncate byte count to an 'int'
6450 when tracing.
0b432f21 6451
5e073ec7
PE
6452 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6453 here, since it parses constructs like leading '-' and spaces,
6454 which are not wanted; and it overflows with large numbers.
6455 Instead, simply match F[0-9]+, which is what is wanted anyway.
6456
36372bf9
PE
6457 * alloc.c: Remove unportable assumptions about struct layout.
6458 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6459 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6460 (allocate_vectorlike, make_pure_vector): Use the new macros,
6461 plus offsetof, to remove unportable assumptions about struct layout.
6462 These assumptions hold on all porting targets that I know of, but
6463 they are not guaranteed, they're easy to remove, and removing them
6464 makes further changes easier.
6465
0b432f21
PE
6466 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6467 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6468 (string_overrun_cookie): Now const. Use initializers that
6469 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6470 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6471 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6472 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6473 multiple of sizeof (EMACS_INT); it need not be, if
6474 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6475 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6476
895009e1
JB
64772011-04-26 Juanma Barranquero <lekktu@gmail.com>
6478
6479 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6480
6a7a1b0b
TZ
64812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6482
6483 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6484 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6485 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6486
841a1577 64872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6488
6489 * lisp.h (Qdebug): List symbol.
895009e1 6490 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6491 * keyboard.c (debug-on-event): New variable.
6492 (handle_user_signal): Break into debugger when debug-on-event
6493 matches the current signal symbol.
6494
f2d3ba6f
DN
64952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6496
6497 * alloc.c (check_sblock, check_string_bytes)
6498 (check_string_free_list): Convert to standard C.
6499
42ce4c63
TZ
65002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6501
6502 * w32.c (emacs_gnutls_push): Fix typo.
6503
825cd63c
EZ
65042011-04-25 Eli Zaretskii <eliz@gnu.org>
6505
fb11d64d
EZ
6506 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6507 "cast to pointer from integer of different size".
6508
825cd63c
EZ
6509 Improve doprnt and its use in verror. (Bug#8545)
6510 * doprnt.c (doprnt): Document the set of format control sequences
6511 supported by the function. Use SAFE_ALLOCA instead of always
6512 using `alloca'.
6513
6514 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6515 is one byte too soon. Don't use xrealloc; instead xfree and
6516 xmalloc anew.
6517
e061a11b
TZ
65182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6519
6520 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6521 callbacks stage.
6522
6523 * gnutls.c: Renamed global_initialized to
6524 gnutls_global_initialized. Added internals for the
6525 :verify-hostname-error, :verify-error, and :verify-flags
6526 parameters of `gnutls-boot' and documented those parameters in the
6527 docstring. Start callback support.
9173deec
JB
6528 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6529 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6530 on error. Return error code.
e061a11b
TZ
6531 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6532 (emacs_gnutls_read): Likewise.
6533 (Fgnutls_boot): Return handshake error code.
6534 (emacs_gnutls_handle_error): New function.
6535 (wsaerror_to_errno): Likewise.
6536
6537 * w32.h (emacs_gnutls_pull): Add prototype.
6538 (emacs_gnutls_push): Likewise.
6539
6540 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6541 (emacs_gnutls_push): Likewise.
6542
65432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6544
6545 * process.c (wait_reading_process_output): Check if GnuTLS
6546 buffered some data internally if no FDs are set for TLS
6547 connections.
6548
6549 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6550 (LIBS): Link to USER_LIBS.
6551 ($(BLD)/gnutls.$(0)): New target.
6552
fa6996bc
EZ
65532011-04-24 Eli Zaretskii <eliz@gnu.org>
6554
eb35682e
EZ
6555 * xdisp.c (handle_single_display_spec): Rename the
6556 display_replaced_before_p argument into display_replaced_p, to
6557 make it consistent with the commentary. Fix typos in the
6558 commentary.
6559
e2ad650c
EZ
6560 * textprop.c (syms_of_textprop): Remove dead code.
6561 (copy_text_properties): Delete obsolete commentary about an
6562 interface that was deleted long ago. Fix typos in the description
6563 of arguments.
6564
1b2de274
EZ
6565 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6566 to changes in oldXMenu/XMenu.h from 2011-04-16.
6567 <menu_help_message, prev_menu_help_message>: Constify.
6568 (IT_menu_make_room): menu->help_text is now `const char **';
6569 adjust.
6570
6571 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6572 to changes in oldXMenu/XMenu.h from 2011-04-16.
6573 (struct XMenu): Declare `help_text' `const char **'.
6574
6575 * xfaces.c <Qunspecified>: Make extern again.
6576
6577 * syntax.c: Include sys/types.h before including regex.h, as
6578 required by Posix.
6579
762b15be
EZ
6580 * doc.c (get_doc_string): Improve the format passed to `error'.
6581
6582 * doprnt.c (doprnt): Improve commentary.
6583
6584 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6585
6586 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6587 them with etags.
6588
f1052e5d
EZ
6589 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6590 changes in globals.h immediately force recompilation.
762b15be
EZ
6591 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6592 $(CURDIR)/s/ms-w32.h.
6593 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6594
fa6996bc
EZ
6595 * character.c (Fchar_direction): Function deleted.
6596 (syms_of_character): Don't defsubr it.
6597 <char-direction-table>: Deleted.
6598
e6c3da20
EZ
65992011-04-23 Eli Zaretskii <eliz@gnu.org>
6600
6601 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6602 * doprnt.c: Include limits.h.
6603 (SIZE_MAX): New macro.
04f2d78b
CB
6604 (doprnt): Return a size_t value. 2nd arg is now size_t.
6605 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6606 Improve overflow protection. Support `l' modifier for integer
6607 conversions. Support %l conversion. Don't assume an EMACS_INT
6608 argument for integer conversions and for %c.
6609
6610 * lisp.h (doprnt): Restore prototype.
6611
6612 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6613 $(SRC)/character.h.
6614
6615 * Makefile.in (base_obj): Add back doprnt.o.
6616
6617 * deps.mk (doprnt.o): Add back prerequisites.
6618 (callint.o): Depend on character.h.
6619
6620 * eval.c (internal_lisp_condition_case): Include the handler
6621 representation in the error message.
6622 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6623 when breaking from the loop.
6624
6625 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6626
6627 * callint.c (Fcall_interactively): When displaying error message
6628 about invalid control letter, pass the character's codepoint, not
6629 a pointer to its multibyte form. Improve display of the character
6630 in octal and display also its hex code.
6631
6632 * character.c (char_string): Use %x to display the (unsigned)
6633 codepoint of an invalid character, to avoid displaying a bogus
6634 negative value.
6635
6636 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6637 `error', not SYMBOL_NAME itself.
6638
6639 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6640 character arguments to `error'.
6641
6642 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6643 to `error' in error message about FINAL_CHAR argument. Make sure
6644 FINAL_CHAR is a character, and use %c when it is passed as
6645 argument to `error'.
6646
4ffd0d6b 66472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6648
6649 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6650
6651 * w32.c: Include <time.h>.
6652 (sys_localtime): New function.
6653
4ffd0d6b 66542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6655
6656 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6657
4ffd0d6b 6658 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6659
4ffd0d6b 66602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6661
4ffd0d6b
GM
6662 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6663 zombies (Bug#8467).
aac0c6e3 6664
04c56954
EZ
66652011-04-19 Eli Zaretskii <eliz@gnu.org>
6666
6667 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6668 gl_state.e_property when gl_state.object is Qt.
6669
6670 * insdel.c (make_gap_larger): Remove limitation of buffer size
6671 to <= INT_MAX.
6672
16a43933
CY
66732011-04-18 Chong Yidong <cyd@stupidchicken.com>
6674
6675 * xdisp.c (lookup_glyphless_char_display)
6676 (produce_glyphless_glyph): Handle cons cell entry in
6677 glyphless-char-display.
6678 (Vglyphless_char_display): Document it.
6679
6680 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6681 glyphless-char-display.
6682
4581706e
CY
66832011-04-17 Chong Yidong <cyd@stupidchicken.com>
6684
6685 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6686
6687 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6688
6689 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6690 definition for no-X builds.
6691
4887c6e2 66922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6693
fd35b6f9
PE
6694 Static checks with GCC 4.6.0 and non-default toolkits.
6695
5c1ccb01
PE
6696 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6697
006c5daa
PE
6698 * process.c (keyboard_bit_set): Define only if SIGIO.
6699 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6700 (send_process): Repair possible setjmp clobbering.
6701
efc736d3
PE
6702 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6703
4e2fe2e6
PE
6704 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6705
f97334a2
PE
6706 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6707
4e75f29d
PE
6708 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6709 Define only if needed.
6710
90efadd1
PE
6711 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6712 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6713 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6714
3c647824
PE
6715 * dispextern.h (struct redisplay_interface): Rename param
6716 to avoid shadowing.
e264f262 6717 * termhooks.h (struct terminal): Likewise.
761383f4 6718 * xterm.c (xembed_send_message): Likewise.
3c647824 6719
b58c5c4a
PE
6720 * insdel.c (make_gap_smaller): Define only if
6721 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6722
cad59032
PE
6723 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6724 it.
6725
c339dc2e
PE
6726 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6727 so that we aren't warned about unused symbols.
6728
91a3e27b
PE
6729 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6730
399c71d3 6731 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6732
8ffc96f5
PE
6733 * xfns.c (x_real_positions): Mark locals as initialized.
6734
eef9bc79
PE
6735 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6736
098db9dd
PE
6737 * xterm.c: Fix problems found by static analysis with other toolkits.
6738 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6739 (x_dispatch_event): Declare static if USE_GTK, and
6740 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6741 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6742 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6743 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6744 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6745
eb18f6cc
PE
6746 * xmenu.c (menu_help_callback): Pointer type fixes.
6747 Use const pointers when pointing at readonly data. Avoid pointer
6748 signedness clashes.
6749 (FALSE): Remove unused macro.
6750 (update_frame_menubar): Remove unused decl.
6751
1fe72bf8
PE
6752 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6753
60d9e1db
PE
6754 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6755 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6756 (single_menu_item): Rename local to avoid shadowing.
6757
39261c26
PE
6758 * keyboard.c (make_lispy_event): Remove unused local var.
6759
018c5e19
PE
6760 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6761 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6762
63d2b86e
PE
6763 * bitmaps: Change bitmaps from unsigned char back to the X11
6764 compatible char. Avoid the old compiler warnings about
6765 out-of-range initializers by using, for example, '\xab' rather
6766 than 0xab.
6767
aefd87e1
PE
6768 * xgselect.c (xgselect_initialize): Check vs interface
6769 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6770
bf501fb9
PE
6771 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6772
e9829fdf
PE
6773 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6774 to read-only memory.
6775
1086c095
PE
6776 * fns.c (vector): Remove; this old hack is no longer needed.
6777
2baccd04 6778 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6779 Remove unused var.
dde42981 6780 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6781
72391843 6782 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6783
436c16df 6784 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6785 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6786 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6787
92bb796d 6788 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6789 (x_term_init): Remove local to avoid shadowing.
92bb796d 6790
764430a3 6791 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6792
6793 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6794 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6795
d1dfb56c
EZ
67962011-04-16 Eli Zaretskii <eliz@gnu.org>
6797
c4354cb4
EZ
6798 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6799
d1dfb56c
EZ
6800 Fix regex.c, syntax.c and friends for buffers > 2GB.
6801 * syntax.h (struct gl_state_s): Declare character position members
6802 EMACS_INT.
6803
6804 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6805
04f2d78b
CB
6806 * textprop.c (verify_interval_modification, interval_of):
6807 Declare arguments EMACS_INT.
d1dfb56c
EZ
6808
6809 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6810 EMACS_INT.
6811
6812 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6813
6814 * indent.c (Fvertical_motion): Local variable it_start is now
6815 EMACS_INT.
6816
6817 * regex.c (re_match, re_match_2, re_match_2_internal)
6818 (bcmp_translate, regcomp, regexec, print_double_string)
6819 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6820 (re_compile_pattern, re_exec): Declare arguments and local
6821 variables `size_t' and `ssize_t' and return values `regoff_t', as
6822 appropriate.
6823 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6824 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6825 <compile_stack_type>: `size' and `avail' are now `size_t'.
6826
6827 * regex.h <regoff_t>: Use ssize_t, not int.
6828 (re_search, re_search_2, re_match, re_match_2): Arguments that
6829 specify buffer/string position and length are now ssize_t and
6830 size_t. Return type is regoff_t.
6831
613052cd
BK
68322011-04-16 Ben Key <bkey76@gmail.com>
6833
6834 * nsfont.m: Fixed bugs in ns_get_family and
6835 ns_descriptor_to_entity that were caused by using free to
6836 deallocate memory blocks that were allocated by xmalloc (via
6837 xstrdup). This caused Emacs to crash when compiled with
6838 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6839 --enable-checking=xmallocoverrun). xfree is now used to
6840 deallocate these memory blocks.
6841
4170f62f 68422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6843
71b41406
PE
6844 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6845
9587a89d
PE
6846 emacs_write: Accept and return EMACS_INT for sizes.
6847 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6848 et seq.
6849 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6850 Accept and return EMACS_INT.
6851 (emacs_gnutls_write): Return the number of bytes written on
6852 partial writes.
6853 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6854 (emacs_read, emacs_write): Remove check for negative size, as the
6855 Emacs source code has been audited now.
9587a89d
PE
6856 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6857 (emacs_read, emacs_write): Use it.
273a5f82
PE
6858 * process.c (send_process): Adjust to the new signatures of
6859 emacs_write and emacs_gnutls_write. Do not attempt to store
6860 a byte offset into an 'int'; it might overflow.
9587a89d 6861 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6862
3e047f51
PE
6863 * sound.c: Don't assume sizes fit in 'int'.
6864 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6865 Return EMACS_INT, not int.
3e047f51 6866 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6867 Accept EMACS_INT, not int.
6868 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6869 record read return values.
6870
cc39a9db
BK
68712011-04-15 Ben Key <bkey76@gmail.com>
6872
c9d0ec6d
JB
6873 * keyboard.c (Qundefined): Don't declare static since it is used
6874 in nsfns.m.
6875 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6876 static since they are used in nsfont.m.
cc39a9db 6877
6c60eb9f
SM
68782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6879
6880 * process.c (Qprocessp): Don't declare static.
6881 * lisp.h (Qprocessp): Declare again.
6882
7990b61a
JB
68832011-04-15 Juanma Barranquero <lekktu@gmail.com>
6884
6885 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6886
5d4cb038
PE
68872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6888
8bd7b830 6889 Improve C-level modularity by making more things 'static'.
cd64ea1d 6890
e3b27b31
PE
6891 Don't publish debugger-only interfaces to other modules.
6892 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6893 (verify_bytepos, count_markers): Move decls to the only modules
6894 that need them.
6895 * region-cache.h (pp_cache): Likewise.
6896 * window.h (check_all_windows): Likewise.
6897 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6898
5d4cb038
PE
6899 * sysdep.c (croak): Now static, if
6900 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6901 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6902
6903 * alloc.c (refill_memory_reserve): Now static if
6904 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6905 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6906
e87b6180
PE
6907 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6908 Define only if USE_LUCID.
6909
ac64929e
PE
6910 * xrdb.c (x_customization_string, x_rm_string): Now static.
6911
6f37259d
PE
6912 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6913 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6914
1683e3ab
PE
6915 * xdisp.c (draw_row_with_mouse_face): Now static.
6916 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6917
de9c2632
PE
6918 * window.h (check_all_windows): Mark externally visible.
6919
2b96acb7
PE
6920 * window.c (window_deletion_count): Now static.
6921
6922 * undo.c: Make symbols static if they're not exported.
6923 (last_undo_buffer, last_boundary_position, pending_boundary):
6924 Now static.
6925
50436f33
PE
6926 * textprop.c (interval_insert_behind_hooks): Now static.
6927 (interval_insert_in_front_hooks): Likewise.
6928
64520e5c
PE
6929 * term.c: Make symbols static if they're not exported.
6930 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6931 (max_frame_lines, tty_set_terminal_modes):
6932 (tty_reset_terminal_modes, tty_turn_off_highlight):
6933 (get_tty_terminal): Now static.
6934 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6935 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6936 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6937 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6938 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6939
1fa53021
PE
6940 * sysdep.c: Make symbols static if they're not exported.
6941 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6942 Now static.
6943 (sigprocmask_set, full_mask): Remove; unused.
6944 (wait_debugging): Mark as visible.
6945 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6946 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6947
d4b43b22
PE
6948 * syntax.c (syntax_temp): Define only if !__GNUC__.
6949
b7c513d0
PE
6950 * sound.c (current_sound_device, current_sound): Now static.
6951
989b29ad
PE
6952 * search.c (searchbufs, searchbuf_head): Now static.
6953
13a55a78
PE
6954 * scroll.c (scroll_cost): Remove; unused.
6955 * dispextern.h (scroll_cost): Remove decl.
6956
de68a1fc
PE
6957 * region-cache.h (pp_cache): Mark as externally visible.
6958
40ccffa6
PE
6959 * process.c: Make symbols static if they're not exported.
6960 (process_tick, update_tick, create_process, chan_process):
6961 (Vprocess_alist, proc_buffered_char, datagram_access):
6962 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6963 (deactivate_process): Mark defn as static, as well as decl.
6964 * lisp.h (create_process): Remove decl.
6965 * process.h (chan_process, Vprocess_alist): Remove decls.
6966
ad64fc97
PE
6967 * print.c: Make symbols static if they're not exported.
6968 (print_depth, new_backquote_output, being_printed, print_buffer):
6969 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6970 (print_interval, print_number_index, initial_stderr_stream):
6971 Now static.
6972 * lisp.h (Fprinc): Remove decl.
6973 (debug_output_compilation_hack): Mark as externally visible.
6974
adddb265
PE
6975 * sysdep.c (croak): Move decl from here to syssignal.h.
6976 * syssignal.h (croak): Put it here, so the API can be checked when
6977 'croak' is called from dissociate_if_controlling_tty.
6978
1717ede2
PE
6979 * minibuf.c: Make symbols static if they're not exported.
6980 (minibuf_save_list, choose_minibuf_frame): Now static.
6981 * lisp.h (choose_minibuf_frame): Remove decl.
6982
fa5fb2bc
PE
6983 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6984
1e3890d1
PE
6985 * lread.c: Make symbols static if they're not exported.
6986 (read_objects, initial_obarray, oblookup_last_bucket_number):
6987 Now static.
6988 (make_symbol): Remove; unused.
6989 * lisp.h (initial_obarray, make_symbol): Remove decls.
6990
8a1414fa
PE
6991 * keyboard.c: Make symbols static if they're not exported.
6992 (single_kboard, recent_keys_index, total_keys, recent_keys):
6993 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6994 (this_single_command_key_start, echoing, last_auto_save):
6995 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6996 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6997 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6998 (Vlispy_mouse_stem, double_click_count):
6999 Now static.
7000 (force_auto_save_soon): Define only if SIGDANGER.
7001 (ignore_mouse_drag_p): Now static if
7002 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7003 (print_help): Remove; unused.
7004 (stop_character, last_timer_event): Mark as externally visible.
7005 * keyboard.h (ignore_mouse_drag_p): Declare only if
7006 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7007 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7008 * lisp.h (echoing): Remove decl.
7009 (force_auto_save_soon): Declare only if SIGDANGER.
7010 * xdisp.c (redisplay_window): Simplify code, to make it more
7011 obvious that ignore_mouse_drag_p is not accessed if !defined
7012 USE_GTK && !defined HAVE_NS.
7013
93ea6e8f
PE
7014 * intervals.c: Make symbols static if they're not exported.
7015 (merge_properties_sticky, merge_interval_right, delete_interval):
7016 Now static.
7017 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7018
77382fcc
PE
7019 * insdel.c: Make symbols static if they're not exported.
7020 However, leave prepare_to_modify_buffer alone. It's never
7021 called from outside this function, but that appears to be a bug.
7022 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7023 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7024 (adjust_after_replace_noundo): Remove; unused.
7025 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7026 (signal_before_change): Remove decls.
77382fcc 7027
9306c32e
PE
7028 * indent.c (val_compute_motion, val_vmotion): Now static.
7029
cd44d2eb
PE
7030 * image.c: Make symbols static if they're not exported.
7031 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7032 if USE_GTK.
7033 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7034 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7035
ad9a7a06
PE
7036 * fringe.c (standard_bitmaps): Now static.
7037 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7038
81626931
PE
7039 * frame.c: Make symbols static if they're not exported.
7040 (x_report_frame_params, make_terminal_frame): Now static.
7041 (get_frame_param): Now static, unless HAVE_NS.
7042 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7043 (x_get_resource_string): Remove; not used.
7044 * frame.h (make_terminal_frame, x_report_frame_params):
7045 (x_get_resource_string); Remove decls.
7046 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7047 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7048
239f9db9
PE
7049 * font.c, fontset.c: Make symbols static if they're not exported.
7050 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7051 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7052 * font.c (font_close_object): Now static.
7053 * font.h (font_close_object): Remove.
7054 * fontset.c (FONTSET_OBJLIST): Remove.
7055 (free_realized_fontset) #if-0 the body, which does nothing.
7056 (face_suitable_for_char_p): #if-0, as it's never called.
7057 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7058 * xfaces.c (face_at_string_position):
7059 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7060 since 0 is always ASCII.
7061
dfcf3579
PE
7062 * fns.c (weak_hash_tables): Now static.
7063
5045092b
PE
7064 * fileio.c: Make symbols static if they're not exported.
7065 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7066 (Vwrite_region_annotation_buffers): Now static.
7067
57a96f5c
PE
7068 * eval.c: Make symbols static if they're not exported.
7069 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7070 * lisp.h (backtrace_list): Remove decl.
7071
35f08c38
PE
7072 * emacs.c: Make symbols static if they're not exported.
7073 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7074 (fatal_error_code, fatal_error_signal_hook, standard_args):
7075 Now static.
7076 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7077 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7078 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7079 * lisp.h (fatal_error_signal_hook): Remove decl.
7080 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7081
f44bd759
PE
7082 * editfns.c: Move a (normally-unused) function to its only use.
7083 * editfns.c, lisp.h (get_operating_system_release): Remove.
7084 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7085 worth the hassle of breaking this out.
7086
b532497d
PE
7087 * xterm.c: Make symbols static if they're not exported.
7088 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7089 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7090 (x_destroy_window, x_delete_display):
7091 Now static.
7092 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7093 (x_mouse_leave): Remove; unused.
7094 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7095 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7096 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7097 Remove decls.
7098 (x_mouse_leave): Declare only if WINDOWSNT.
7099 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7100 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7101 USE_X_TOOLKIT.
7102
1675728f
PE
7103 * ftxfont.c: Make symbols static if they're not exported.
7104 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7105 HAVE_FREETYPE.
7106 * font.h (ftxfont_driver): Likewise.
7107
e4cebfca
PE
7108 * xfns.c: Make symbols static if they're not exported.
7109 (x_last_font_name, x_display_info_for_name):
7110 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7111 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7112 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7113 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7114 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7115 (last_show_tip_args): Now static.
7116 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7117 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7118 (x_screen_planes): Remove; unused.
7119 * dispextern.h (x_screen_planes): Remove decl.
7120
5bf46f05
PE
7121 * dispnew.c: Make symbols static if they're not exported.
7122 * dispextern.h (redraw_garbaged_frames, scrolling):
7123 (increment_row_positions): Remove.
7124 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7125 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7126 Now static.
7127 (redraw_garbaged_frames): Remove; unused.
7128
435f4c28
PE
7129 * xfaces.c: Make symbols static if they're not exported.
7130 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7131 Remove decls.
7132 * xterm.h (defined_color): Remove decls.
7133 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7134 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7135 (menu_face_changed_default, defined_color, free_realized_face):
7136 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7137 (ascii_face_of_lisp_face): Remove; unused.
7138
8524aef3
PE
7139 * xdisp.c: Make symbols static if they're not exported.
7140 * dispextern.h (scratch_glyph_row, window_box_edges):
7141 (glyph_to_pixel_coords, set_cursor_from_row):
7142 (get_next_display_element, set_iterator_to_next):
7143 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7144 (show_mouse_face): Remove decls
7145 * frame.h (message_buf_print): Likewise.
7146 * lisp.h (pop_message, set_message, check_point_in_composition):
7147 Likewise.
7148 * xterm.h (set_vertical_scroll_bar): Likewise.
7149 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7150 (message_buf_print, scratch_glyph_row, displayed_buffer):
7151 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7152 (get_next_display_element, show_mouse_face, window_box_edges):
7153 (frame_to_window_pixel_xy, check_point_in_composition):
7154 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7155 (glyph_to_pixel_coords): Remove; unused.
7156
16390cd2
PE
7157 * dired.c (file_name_completion): Now static.
7158
7159 * dbusbind.c (xd_in_read_queued_messages): Now static.
7160
a25f4dfa
PE
7161 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7162 * data.c (circular_list_error): Remove.
7163
14a9c8df
PE
7164 * commands.h (last_point_position, last_point_position_buffer):
7165 (last_point_position_window): Remove decls.
7166 * keyboard.c: Make these variables static.
7167
04f2d78b
CB
7168 * coding.h (coding, code_convert_region, encode_coding_gap):
7169 Remove decls.
74ab6df5
PE
7170 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7171 (iso_code_class, detect_coding, code_convert_region): Now static.
7172 (encode_coding_gap): Remove; unused.
7173
38dfbee1
PE
7174 * chartab.c (chartab_chars, chartab_bits): Now static.
7175
a2cb4e63
PE
7176 * charset.h (charset_iso_8859_1): Remove decl.
7177 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7178 Now static.
7179
127198fd
PE
7180 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7181 * ccl.c (Vccl_program_table): Now static.
7182 (check_ccl_update): Remove; unused.
7183
d85b608f
PE
7184 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7185 * category.h: ... from here.
7186 * category.c (check_category_table, set_category_set): Now static.
7187
31cd66f3
PE
7188 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7189 * lisp.h: Remove these decls.
7190
c358e587
PE
7191 * buffer.c (buffer_count): Remove unused var.
7192
e78aecca
PE
7193 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7194 so that it's not optimized away.
7195 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7196 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7197 exported only to the debugger.
7198
e192d7d3 7199 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7200 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7201
92470028
PE
7202 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7203 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7204 was inaccessible from Lisp.
7205 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7206 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7207
244ed907
PE
7208 alloc.c: Import and export fewer symbols, and remove unused items.
7209 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7210 is defined.
7211 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7212 it's not optimized away by whole-program optimization.
7213 (message_enable_multibyte, free_misc): Remove.
7214 (catchlist, handlerlist, mark_backtrace):
7215 Declare only if BYTE_MARK_STACK.
7216 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7217 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7218 (message_enable_multibyte): Remove decl.
7219 (free_misc, interval_free_list, float_block, float_block_index):
7220 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7221 (cons_free_list, last_marked_index):
7222 Now static.
7223 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7224 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7225 (mark_backtrace): Define only if BYTE_MARK_STACK.
7226 * xdisp.c (message_enable_multibyte): Now static.
7227
61c2b50e 7228 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7229 This makes it easier for human readers (and static analyzers)
7230 to see whether these variables are used from other modules.
7231 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7232 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7233 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7234 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7235 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7236 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7237 * xmenu.c, xselect.c:
7238 Declare Q* vars static if they are not used in other modules.
7239 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7240 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7241 Remove decls of unexported vars.
7242 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7243
95c82688
PE
7244 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7245
16a97296
PE
7246 Make Emacs functions such as Fatom 'static' by default.
7247 This makes it easier for human readers (and static analyzers)
7248 to see whether these functions can be called from other modules.
7249 DEFUN now defines a static function. To make the function external
7250 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7251 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7252 (Finit_image_library):
16a97296
PE
7253 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7254 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7255 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7256 Remove decls, since these functions are now static.
7257 (Funintern, Fget_internal_run_time): New decls, since these functions
7258 were already external.
95c82688 7259
16a97296
PE
7260 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7261 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7262 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7263 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7264 * keyboard.c, keymap.c, lread.c:
7265 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7266 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7267 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7268 Mark functions with DEFUE instead of DEFUN,
7269 if they are used in other modules.
7270 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7271 decls for now-static functions.
7272 * buffer.h (Fdelete_overlay): Remove decl.
7273 * callproc.c (Fgetenv_internal): Mark as internal.
7274 * composite.c (Fremove_list_of_text_properties): Remove decl.
7275 (Fcomposition_get_gstring): New forward static decl.
7276 * composite.h (Fcomposite_get_gstring): Remove decl.
7277 * dired.c (Ffile_attributes): New forward static decl.
7278 * doc.c (Fdocumntation_property): New forward static decl.
7279 * eval.c (Ffetch_bytecode): New forward static decl.
7280 (Funintern): Remove extern decl; now in .h file where it belongs.
7281 * fileio.c (Fmake_symbolic_link): New forward static decl.
7282 * image.c (Finit_image_library): New forward static decl.
7283 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7284 * intervals.h (Fprevious_property_change):
7285 (Fremove_list_of_text_properties): Remove decls.
7286 * keyboard.c (Fthis_command_keys): Remove decl.
7287 (Fcommand_execute): New forward static decl.
7288 * keymap.c (Flookup_key): New forward static decl.
7289 (Fcopy_keymap): Now static.
7290 * keymap.h (Flookup_key): Remove decl.
7291 * process.c (Fget_process): New forward static decl.
7292 (Fprocess_datagram_address): Mark as internal.
7293 * syntax.c (Fsyntax_table_p): New forward static decl.
7294 (skip_chars): Remove duplicate decl.
7295 * textprop.c (Fprevious_property_change): New forward static decl.
7296 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7297 Now internal.
7298 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7299 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7300
785bbd42
PE
7301 * editfns.c (Fformat): Remove unreachable code.
7302
8b913b57
AS
73032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7304
7305 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7306 change. (Bug#8496)
7307
a6744a35
EZ
73082011-04-13 Eli Zaretskii <eliz@gnu.org>
7309
7310 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7311 when at ZV. (Bug#8487)
7312
e7974947
AS
73132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7314
baad03f0
AS
7315 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7316 (Bug#8437)
7317 * keyboard.c (parse_tool_bar_item): Likewise.
7318 * sound.c (sound_cleanup, alsa_close): Likewise.
7319 * termcap.c (tgetent): Likewise.
7320 * xfns.c (x_default_font_parameter): Likewise.
7321 * xsettings.c (read_and_apply_settings): Likewise.
7322
e7974947
AS
7323 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7324 (overrun_check_free): Protoize.
7325
28272684
PE
73262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7327
7328 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7329 since callers should never pass a negative size.
7330 Change the signature to match that of plain 'read' and 'write'; see
7331 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7332 * lisp.h: Update prototypes of emacs_write and emacs_read.
7333
11997c76
EZ
73342011-04-11 Eli Zaretskii <eliz@gnu.org>
7335
7336 * xdisp.c (redisplay_window): Don't try to determine the character
7337 position of the scroll margin if the window start point w->startp
e896f03c 7338 is outside the buffer's accessible region. (Bug#8468)
11997c76 7339
8a2cbd72
EZ
73402011-04-10 Eli Zaretskii <eliz@gnu.org>
7341
7342 Fix write-region and its subroutines for buffers > 2GB.
7343 * fileio.c (a_write, e_write): Modify declaration of arguments and
7344 local variables to support buffers larger than 2GB.
7345 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7346
7347 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7348 argument, local variables, and return value.
7349
7350 * lisp.h: Update prototypes of emacs_write and emacs_read.
7351
7352 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7353
4073e537 73542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7355
1ebfdcb6
PE
7356 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7357
b2ded58d
PE
7358 Fix more problems found by GCC 4.6.0's static checks.
7359
7d66342c
PE
7360 * xdisp.c (vmessage): Use a better test for character truncation.
7361
bbf47d44
PE
7362 * charset.c (load_charset_map): <, not <=, for optimization,
7363 and to avoid potential problems with integer overflow.
9248994d 7364 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7365 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7366 * editfns.c (Fformat): Likewise.
1e69125e 7367 * syntax.c (skip_chars): Likewise.
3befa583 7368
e3019616
PE
7369 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7370 This also lets GCC 4.6.0 generate slightly better loop code.
7371
becfa255
PE
7372 * callint.c (Fcall_interactively): <, not <=, for optimization.
7373 (Fcall_interactively): Count the number of arguments produced,
7374 not the number of arguments given. This is simpler and lets GCC
7375 4.6.0 generate slightly better code.
7376
dae0cd48
PE
7377 * ftfont.c: Distingish more carefully between FcChar8 and char.
7378 The previous code passed unsigned char * to a functions like
7379 strlen and xstrcasecmp that expect char *, which does not
7380 conform to the C standard.
7381 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7382 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7383 char * when the C standard requires it.
7384
76032d70
PE
7385 * keyboard.c (read_char): Remove unused var.
7386
eb3f1cc8
PE
7387 * eval.c: Port to Windows vsnprintf (Bug#8435).
7388 Include <limits.h>.
7389 (SIZE_MAX): Define if the headers do not.
7390 (verror): Do not give up if vsnprintf returns a negative count.
7391 Instead, grow the buffer. This ports to Windows vsnprintf, which
7392 does not conform to C99. Problem reported by Eli Zaretskii.
7393 Also, simplify the allocation scheme, by avoiding the need for
7394 calling realloc, and removing the ALLOCATED variable.
7395
70476b54
PE
7396 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7397
12020a9e
PE
7398 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7399 But keep the doprint source code for now, as we might revamp it
7400 and use it again (Bug#8435).
ea6c7ae6
PE
7401 * lisp.h (doprnt): Remove.
7402 * Makefile.in (base_obj): Remove doprnt.o.
7403 * deps.mk (doprnt.o): Remove.
7404
5fdb398c
PE
7405 error: Print 32- and 64-bit integers portably (Bug#8435).
7406 Without this change, on typical 64-bit hosts error ("...%d...", N)
7407 was used to print both 32- and 64-bit integers N, which relied on
7408 undefined behavior.
7409 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7410 New macro.
7411 * lisp.h (error, verror): Mark as printf-like functions.
7412 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7413 Report overflow in size calculations when allocating printf buffer.
7414 Do not truncate output string at its first null byte.
7415 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7416 Truncate the output at a character boundary, since vsnprintf does not
7417 do that.
7418 * charset.c (check_iso_charset_parameter): Convert internal
7419 character to string before calling 'error', since %c now has the
7420 printf meaning.
7421 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7422 overflow when computing char to be passed to 'error'. Do not
7423 pass Lisp_Object to 'error'; pass the integer instead.
7424 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7425 formatted with plain %d.
7426
b189fa66
PE
7427 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7428
bff87ef0
PE
7429 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7430
7e2cac20
PE
7431 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7432
ce4d90b5
PE
7433 * xterm.c (x_catch_errors): Remove duplicate declaration.
7434
266c9547
PE
7435 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7436
79c49ad2
PE
7437 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7438
368f4090
JM
74392011-04-10 Jim Meyering <meyering@redhat.com>
7440
7441 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7442 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7443 return ssize_t not "int", and use size_t as the buffer length.
7444 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7445 * gnutls.h: Update declarations.
7446 * process.c (read_process_output): Use ssize_t, to match.
7447 (send_process): Likewise.
7448
a32d4040
CY
74492011-04-09 Chong Yidong <cyd@stupidchicken.com>
7450
7451 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7452
8546720e 74532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7454
04f2d78b
CB
7455 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7456 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7457
8546720e
GM
7458 * xterm.c (handle_one_xevent):
7459 * xmenu.c (create_and_show_popup_menu):
7460 * xselect.c (x_decline_selection_request)
7461 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7462
0a2f5c1a 74632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7464
7465 Fix some uses of `int' instead of EMACS_INT.
7466 * search.c (string_match_1, fast_string_match)
7467 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7468 (scan_buffer, find_next_newline_no_quit)
7469 (find_before_next_newline, search_command, Freplace_match)
7470 (Fmatch_data): Make some `int' variables be EMACS_INT.
7471
7472 * xdisp.c (display_count_lines): 3rd argument and return value now
7473 EMACS_INT. All callers changed.
7474 (pint2hrstr): Last argument is now EMACS_INT.
7475
7476 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7477 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7478 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7479 (decode_coding_utf_16, decode_coding_emacs_mule)
7480 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7481 (decode_coding_ccl, decode_coding_charset)
7482 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7483 (decode_coding_iso_2022, decode_coding_emacs_mule)
7484 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7485 <char_offset, last_offset>: Declare EMACS_INT.
7486 (encode_coding_utf_8, encode_coding_utf_16)
7487 (encode_coding_emacs_mule, encode_invocation_designation)
7488 (encode_designation_at_bol, encode_coding_iso_2022)
7489 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7490 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7491 Declare EMACS_INT.
7492 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7493 (encode_invocation_designation): Last argument P_NCHARS is now
7494 EMACS_INT.
7495 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7496 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7497
7498 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7499 All users changed.
7500
7501 * ccl.c (Fccl_execute_on_string): Declare some variables
7502 EMACS_INT.
7503
8546720e 75042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7505
7506 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7507
4e19a977
CS
75082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7509
7510 * process.c (Fformat_network_address): Doc fix.
7511
87302331
R
75122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7513
ee7683eb 7514 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7515
cbb59342
CY
75162011-04-08 Chong Yidong <cyd@stupidchicken.com>
7517
7518 * keyboard.c (read_char): Call Lisp function help-form-show,
7519 instead of using internal_with_output_to_temp_buffer.
7520 (Qhelp_form_show): New var.
e0d38eeb 7521 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7522
7523 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7524
7525 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7526
e67a13ab
CY
75272011-04-06 Chong Yidong <cyd@stupidchicken.com>
7528
04f2d78b
CB
7529 * process.c (Flist_processes): Remove to Lisp.
7530 (list_processes_1): Delete.
e67a13ab 7531
973f782d
EZ
75322011-04-06 Eli Zaretskii <eliz@gnu.org>
7533
7c106b1e
EZ
7534 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7535
973f782d
EZ
7536 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7537
41cf7d1a 75382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7539
ca23cc88
PE
7540 Fix more problems found by GCC 4.6.0's static checks.
7541
f390e2d5
PE
7542 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7543
42eea0d0
PE
7544 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7545
b69769da 7546 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7547
f9541e84
PE
7548 * xdisp.c (vmessage): Mark as a printf-like function.
7549
13841b55
PE
7550 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7551
c136c10f
PE
7552 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7553
5e2d4a30
PE
7554 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7555 printf-like functions.
7556 (tiff_load): Add casts to remove these marks before passing them
7557 to system-supplied API.
7558
583f48b9
PE
7559 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7560
b25d760e
PE
7561 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7562 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7563 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7564 directly, rather than having caller test rule sign. This avoids
7565 some unnecessary tests.
7566 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7567 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7568 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7569
bc7b6697 7570 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7571 (xfont_open): Avoid unnecessary tests.
bc7b6697 7572
27ccc379
PE
7573 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7574
dcd5c89a
PE
7575 * composite.h, composite.c (composition_gstring_put_cache):
7576 Use EMACS_INT, not int, for length.
7577
b13a45c6
PE
7578 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7579 breaking out part of COMPOSITION_DECODE_RULE.
7580 (COMPOSITION_DECODE_RULE): Use it.
7581 * composite.c (get_composition_id): Remove unused local vars,
7582 by using the new macro.
7583
1e792e4d
PE
7584 * textprop.c (set_text_properties_1): Change while to do-while,
7585 since the condition is always true at first.
7586
dc6c6455 7587 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7588 (interval_deletion_adjustment): Return unsigned value.
7589 All uses changed.
dc6c6455 7590
aba7731a
PE
7591 * process.c (list_processes_1, create_pty, read_process_output):
7592 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7593 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7594 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7595 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7596 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7597
fdfc4bf3
PE
7598 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7599
fca8fe46 7600 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7601 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7602
06a0259a 7603 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7604 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7605 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7606
e7b9e80f
PE
7607 * print.c (print_error_message): Avoid int overflow.
7608
56201685
PE
7609 * font.c (font_list_entities): Redo for clarity,
7610 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7611
78834453 7612 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7613 (font_score): Avoid potential overflow in diff calculation.
78834453 7614
0bc0b309 7615 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7616 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7617
e610eaca
PE
7618 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7619
b895abce
PE
7620 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7621 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7622 can always succeed if overflow has undefined behavior.
7623
1f1d9321 7624 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7625 (wordify): Omit three unnecessary tests.
1f1d9321 7626
c59478bc
PE
7627 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7628 All callers changed. This avoids the need for an unused var.
7629
79b73827
PE
7630 * casefiddle.c (casify_region): Remove var that is set but not used.
7631
a4db5dfe
PE
7632 * dired.c (file_name_completion): Remove var that is set but not used.
7633
43aae36e
PE
7634 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7635
2a47c44d 7636 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7637 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7638
a37c69bf
PE
7639 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7640 Check for integer overflow on size calculations.
7641
328ab8e7
PE
7642 * buffer.c (Fprevious_overlay_change): Remove var that is set
7643 but not used.
7644
e5a2a5cb
PE
7645 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7646 Remove vars that are set but not used.
8d84a6eb 7647 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7648 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7649
a60e5f68
PE
7650 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7651
f661cb61 7652 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7653 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7654
f0397f5a
PE
7655 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7656 that are set but not used.
7657
8664db06 7658 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7659 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7660
6abdaa4a
PE
7661 * xselect.c (x_get_local_selection, x_handle_property_notify):
7662 Remove vars that are set but not used.
7663
0ce7538d 7664 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7665 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7666
9ae848fc
PE
7667 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7668 Remove var that is set but not used.
0b918413
PE
7669 (scroll_bar_windows_size): Now size_t, not int.
7670 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7671 Check for overflow.
9ae848fc 7672
a5a62657
PE
7673 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7674 (map_tty_color) [!defined MSDOS]: Likewise.
7675
5c5cdd39
PE
7676 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7677
66ebf983
PE
7678 * coding.c: Remove vars that are set but not used.
7679 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7680 All callers changed.
7681 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7682 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7683 (decode_coding_charset): Remove vars that are set but not used.
7684
1be4d761
PE
7685 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7686 that is set but not used.
7687
47553fa8
PE
7688 * print.c (print_object): Remove var that is set but not used.
7689
1f7196bf 7690 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7691 The gnulib version avoids calling malloc in the usual case,
7692 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7693 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7694 * filelock.c (current_lock_owner): Likewise.
7695 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7696 * sysdep.c: Include allocator.h, careadlinkat.h.
7697 (emacs_no_realloc_allocator): New static constant.
7698 (emacs_readlink): New function.
fdb61804
PE
7699 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7700 ../lib/careadlinkat.h.
d1fdcab7 7701
f84c17c7
SM
77022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7703
7704 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7705 first non-nil return value).
7706
ef3862ad
JD
77072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7708
7709 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7710 if not defined (Bug#8403).
7711
376a7006
JB
77122011-04-02 Juanma Barranquero <lekktu@gmail.com>
7713
7714 * xdisp.c (display_count_lines): Remove parameter `start',
7715 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7716 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7717 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7718 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7719 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7720 and thereabouts. All callers changed.
7721 (get_per_char_metric): Remove parameter `f', unused since
7722 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7723
6ca3801d
JM
77242011-04-02 Jim Meyering <meyering@redhat.com>
7725
7726 do not dereference NULL upon failed strdup
7727 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7728 (ns_get_family): Likewise.
7729
d8e2b5ba
JB
77302011-04-02 Juanma Barranquero <lekktu@gmail.com>
7731
7732 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7733
8c74fcbd
JD
77342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7735
7736 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7737 later (Bug#8403).
7738
7200d79c
SM
77392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7740
03408648 7741 Add lexical binding.
7200d79c 7742
03408648
SM
7743 * window.c (Ftemp_output_buffer_show): New fun.
7744 (Fsave_window_excursion):
7745 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7746
7747 * lread.c (lisp_file_lexically_bound_p): New function.
7748 (Fload): Bind Qlexical_binding.
7749 (readevalloop): Remove `evalfun' arg.
7750 Bind Qinternal_interpreter_environment.
7751 (Feval_buffer): Bind Qlexical_binding.
7752 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7753 Mark as dynamic.
7754 (syms_of_lread): Declare `lexical-binding'.
7755
7756 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7757
7758 * keyboard.c (eval_dyn): New fun.
7759 (menu_item_eval_property): Use it.
ca105506
SM
7760
7761 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7762
03408648
SM
7763 * fns.c (concat, mapcar1): Accept byte-code-functions.
7764
7765 * eval.c (Fsetq): Handle lexical vars.
7766 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7767 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7768 (FletX, Flet): Obey lexical binding.
7769 (Fcommandp): Handle closures.
7770 (Feval): New `lexical' arg.
7771 (eval_sub): New function extracted from Feval. Use it almost
7772 everywhere where Feval was used. Look up vars in lexical env.
7773 Handle closures.
7774 (Ffunctionp): Move from subr.el.
7775 (Ffuncall): Handle closures.
7776 (apply_lambda): Remove `eval_flags'.
7777 (funcall_lambda): Handle closures and new byte-code-functions.
7778 (Fspecial_variable_p): New function.
7779 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7780 but without exporting it to Lisp.
23aba0ea 7781
23aba0ea 7782 * doc.c (Fdocumentation, store_function_docstring):
03408648 7783 * data.c (Finteractive_form): Handle closures.
23aba0ea 7784
03408648
SM
7785 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7786 interactive spec.
ba83908c 7787
04f2d78b
CB
7788 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7789 New byte-codes.
03408648
SM
7790 (exec_byte_code): New function extracted from Fbyte_code to handle new
7791 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7792
03408648 7793 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7794
03408648 7795 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7796
e2abce01
JB
77972011-03-31 Juanma Barranquero <lekktu@gmail.com>
7798
7799 * xdisp.c (redisplay_internal): Fix prototype.
7800
63696a73 78012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7802
63696a73 7803 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7804 (try_scrolling): Use it when setting scroll_limit.
7805 Limit scrolling to 100 screen lines.
63696a73
EZ
7806 (redisplay_window): Even when falling back on "recentering",
7807 position point in the window according to scroll-conservatively,
7808 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7809
7810 (try_scrolling): When point is above the window, allow searching
7811 as far as scroll_max, or one screenful, to compute vertical
7812 distance from PT to the scroll margin position. This prevents
7813 try_scrolling from unnecessarily failing when
7814 scroll-conservatively is set to a value slightly larger than the
7815 window height. Clean up the case of PT below the margin at bottom
7816 of window: scroll_max can no longer be INT_MAX. When aggressive
7817 scrolling is in use, don't let point enter the opposite scroll
7818 margin as result of the scroll.
7819 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7820 threshold of 100 lines for never-recentering scrolling.
7821
e4cc2dfc
JB
78222011-03-31 Juanma Barranquero <lekktu@gmail.com>
7823
7824 * dispextern.h (move_it_by_lines):
7825 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7826 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7827 (message_log_check_duplicate): Remove parameters `prev_bol' and
7828 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7829 (redisplay_internal): Remove parameter `preserve_echo_area',
7830 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7831
7832 * indent.c (Fvertical_motion):
7833 * window.c (window_scroll_pixel_based, Frecenter):
7834 Don't pass `need_y_p' to `move_it_by_lines'.
7835
1c470562
SM
78362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7837
44f230aa
SM
7838 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7839 steal a few bits to be more compact.
7840 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7841 Remove unneeded casts.
7842
1c470562
SM
7843 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7844
888adce9
ZK
78452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7846
7847 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7848 binding" message (bug#7967).
7849
f838ed7b
PE
78502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7851
77861b95
PE
7852 Fix more problems found by GCC 4.6.0's static checks.
7853
de6dbc14
PE
7854 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7855 Remove unused local var.
7856
f838ed7b
PE
7857 * editfns.c (Fmessage_box): Remove unused local var.
7858
792c7b2b
PE
7859 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7860 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7861 Omit unused local vars.
c499e557 7862 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7863 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7864 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7865 Omit unused local var.
7866
ba0165e1
PE
7867 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7868 Don't assume string length fits in int.
32ad8845 7869 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7870 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7871
3c59b4c9
PE
7872 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7873 instead of alloca (Bug#8344).
7874
a3eed478 7875 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7876 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7877
eb4d412d
PE
7878 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7879
1658b401
PE
7880 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7881 concerns.
7882
7883 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7884
7885 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7886
9a2c6e05
PE
7887 * keyboard.c (syms_of_keyboard): Use the same style as later
7888 in this function when indexing through an array. This also
7889 works around GCC bug 48267.
7890
03d0a109
PE
7891 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7892
44f730c8
PE
7893 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7894
fe75f926
PE
7895 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7896 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7897
ffa8c828
PE
7898 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7899 This avoids undefined behavior on integer overflow, and is a bit
7900 more convenient anyway since it is compared to a size_t variable.
7901
c5101a77
PE
7902 Variadic C functions now count arguments with size_t, not int.
7903 This avoids an unnecessary limitation on 64-bit machines, which
7904 caused (substring ...) to crash on large vectors (Bug#8344).
7905 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7906 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7907 All variadic functions and their callers changed accordingly.
c5101a77
PE
7908 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7909 * data.c (arith_driver, float_arith_driver): Likewise.
7910 * editfns.c (general_insert_function): Likewise.
7911 * eval.c (struct backtrace.nargs, interactive_p)
7912 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7913 (funcall_lambda, mark_backtrace): Likewise.
7914 * fns.c (concat): Likewise.
7915 * frame.c (x_set_frame_parameters): Likewise.
7916 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7917 0 if not found, not -1. All callers changed.
7918
dd3f25f7
PE
7919 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7920 (stack_copy_size): Now size_t, not int.
7921 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7922
461c2ab9
JB
79232011-03-28 Juanma Barranquero <lekktu@gmail.com>
7924
7925 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7926 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7927 All callers changed.
7928
7929 * lisp.h (multibyte_char_to_unibyte):
7930 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7931 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7932 * character.h (CHAR_TO_BYTE8):
7933 * cmds.c (internal_self_insert):
7934 * editfns.c (general_insert_function):
7935 * keymap.c (push_key_description):
7936 * search.c (Freplace_match):
7937 * xdisp.c (message_dolog, set_message_1): All callers changed.
7938
f6d62986
SM
79392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7940
7941 * keyboard.c (safe_run_hook_funcall): New function.
7942 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7943 don't set the hook to nil, but remove the offending function instead.
7944 (Qcommand_hook_internal): Remove, unused.
7945 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7946 Vcommand_hook_internal.
7947
7948 * eval.c (enum run_hooks_condition): Remove.
7949 (funcall_nil, funcall_not): New functions.
7950 (run_hook_with_args): Call each function through a `funcall' argument.
7951 Remove `cond' argument, now redundant.
7952 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7953 (Frun_hook_with_args_until_failure): Adjust accordingly.
7954 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7955
1db5b1ad
JB
79562011-03-28 Juanma Barranquero <lekktu@gmail.com>
7957
7958 * dispextern.h (string_buffer_position): Remove declaration.
7959
7960 * print.c (strout): Remove parameter `multibyte', unused since
7961 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7962
7963 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7964 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7965 All callers changed.
7966
7967 * w32.c (_wsa_errlist): Use braces for struct initializers.
7968
7969 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7970 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7971 All callers changed.
7972 (string_buffer_position): Likewise. Also, make static (it's never
7973 used outside xdisp.c).
7974 (cursor_row_p): Remove parameter `w', unused since
7975 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7976 (decode_mode_spec): Remove parameter `precision', introduced during
7977 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7978 All callers changed.
7979
5ffb62aa
JD
79802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7981
7982 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7983
461c2ab9 79842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7985
7986 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7987 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7988 (ns_update_auto_hide_menu_bar): New functions.
7989 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7990 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7991 ns_constrain_all_frames.
7992 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7993 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7994
5c380ffb
JD
79952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7996
7997 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7998
9af30bdf
GM
79992011-03-27 Glenn Morris <rgm@gnu.org>
8000
8001 * syssignal.h: Replace RETSIGTYPE with void.
8002 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8003 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8004 Replace SIGTYPE with void everywhere.
8005 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8006 * s/template.h (SIGTYPE): Remove commented out definition.
8007
e2abce01
JB
80082011-03-26 Eli Zaretskii <eliz@gnu.org>
8009
8010 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8011 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8012
f868cd8a
JB
80132011-03-26 Juanma Barranquero <lekktu@gmail.com>
8014
59eb0929
JB
8015 * w32.c (read_unc_volume): Use parameter `henum', instead of
8016 global variable `wget_enum_handle'.
8017
8018 * keymap.c (describe_vector): Remove parameters `indices' and
8019 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8020 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8021
f868cd8a
JB
8022 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8023
8024 * keyboard.c (timer_check): Remove parameter `do_it_now',
8025 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8026 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8027 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8028
8029 * keyboard.c (read_char):
8030 * w32menu.c (w32_menu_display_help):
8031 * xmenu.c (show_help_event, menu_help_callback):
8032 Adjust calls to `show_help_echo'.
8033
8034 * gtkutil.c (xg_maybe_add_timer):
8035 * keyboard.c (readable_events):
8036 * process.c (wait_reading_process_output):
8037 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8038
8039 * insdel.c (adjust_markers_gap_motion):
8040 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8041 (gap_left, gap_right): Don't call it.
8042
2ecf6fdb
CY
80432011-03-25 Chong Yidong <cyd@stupidchicken.com>
8044
8045 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8046 incurred during fontification.
8047
6b1f9ba4
JB
80482011-03-25 Juanma Barranquero <lekktu@gmail.com>
8049
8050 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8051 (DEFVAR_PER_BUFFER): Don't pass it.
8052
8053 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8054 (scrolling_window): Don't pass it.
8055
0f4a96b5
JB
80562011-03-25 Juanma Barranquero <lekktu@gmail.com>
8057
8058 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8059
8060 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8061 and `suffix'.
8062 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8063 of variables specific to SELinux and computation of `encoded_absname'.
8064
8065 * image.c (XPutPixel): Remove unused variable `height'.
8066
8067 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8068
8069 * unexw32.c (get_section_info): Remove unused variable `section'.
8070
8071 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8072 (system_process_attributes): Remove unused variable `sess'.
8073 (sys_read): Remove unused variable `err'.
8074
8075 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8076 (w32_wnd_proc): Remove unused variable `isdead'.
8077 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8078 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8079 (x_create_tip_frame): Remove unused variable `tem'.
8080
8081 * w32inevt.c (w32_console_read_socket):
8082 Remove unused variable `no_events'.
8083
8084 * w32term.c (x_draw_composite_glyph_string_foreground):
8085 Remove unused variable `width'.
8086
1149507c
JB
80872011-03-24 Juanma Barranquero <lekktu@gmail.com>
8088
8089 * w32term.c (x_set_glyph_string_clipping):
8090 Don't pass uninitialized region to CombineRgn.
8091
9c88f339
JB
80922011-03-23 Juanma Barranquero <lekktu@gmail.com>
8093
8094 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8095 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8096 (Fx_close_connection): Remove unused variable `i'.
8097
8098 * w32font.c (w32font_draw): Return number of glyphs.
8099 (w32font_open_internal): Remove unused variable `i'.
8100 (w32font_driver): Add missing initializer.
8101
8102 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8103 (fill_in_menu): Remove unused variable `items_added'.
8104
8105 * w32term.c (last_mouse_press_frame): Remove static global variable.
8106 (w32_clip_to_row): Remove unused variable `f'.
8107 (x_delete_terminal): Remove unused variable `i'.
8108
8109 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8110 (NOTHING): Remove unused static global variable.
8111 (uniscribe_check_otf): Remove unused variable `table'.
8112 (uniscribe_font_driver): Add missing initializers.
8113
dee091a3
JD
81142011-03-23 Julien Danjou <julien@danjou.info>
8115
8116 * term.c (Fsuspend_tty, Fresume_tty):
8117 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8118 * window.c (temp_output_buffer_show):
8119 * insdel.c (signal_before_change):
8120 * frame.c (Fhandle_switch_frame):
8121 * fileio.c (Fdo_auto_save):
8122 * emacs.c (Fkill_emacs):
8123 * editfns.c (save_excursion_restore):
8124 * cmds.c (internal_self_insert):
8125 * callint.c (Fcall_interactively):
8126 * buffer.c (Fkill_all_local_variables):
8127 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8128 Use Frun_hooks.
0f4a96b5 8129 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8130 unconditionally since it does the check itself.
dee091a3 8131
2c520ab5 81322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8133
c9c49752
PE
8134 Fix more problems found by GCC 4.5.2's static checks.
8135
8abc3f12
PE
8136 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8137 the first time through the loop, since we know p0 < p1 then.
8138 This also avoids a gcc -Wstrict-overflow warning.
8139
a2d26660
PE
8140 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8141 leading to a memory leak, possible in functions like
8142 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8143 of objects (Bug#8318).
a2d26660 8144
916c72e9
PE
8145 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8146 that could (at least in theory) be that large.
8147
19ab8a18
PE
8148 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8149 This is less likely to overflow, and avoids undefined behavior if
8150 overflow does occur. All callers changed. Use strtoul to scan
8151 for the unsigned long integer.
b7cbbd6f
PE
8152 (pint2hrstr): Simplify and tune code slightly.
8153 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8154
f0641eff
PE
8155 * scroll.c (do_scrolling): Work around GCC bug 48228.
8156 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8157
7f650bb9
PE
8158 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8159 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8160 (validate_x_resource_name): Simplify count usage.
8161 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8162
37dd57d1
PE
8163 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8164 fail (Bug#8306).
81e56e61 8165
699979fc 8166 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8167
401bf9b4
PE
8168 * process.c (Fmake_network_process): Use socklen_t, not int,
8169 where POSIX says socklen_t is required in portable programs.
8170 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8171 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8172 (Fmake_network_process, server_accept_connection):
8173 (wait_reading_process_output, read_process_output):
8174 Likewise.
8175
b93aacde
PE
8176 * process.c: Rename or move locals to avoid shadowing.
8177 (list_processes_1, Fmake_network_process):
8178 (read_process_output_error_handler, exec_sentinel_error_handler):
8179 Rename or move locals.
4dc343ee 8180 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8181 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8182 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8183 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8184 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8185
af8a867c 8186 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8187 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8188 Include tparam.h instead, since it declares them.
af8a867c
PE
8189 * cm.h (PC): Remove extern decl; tparam.h now does this.
8190 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8191 * terminfo.c: Include tparam.h, to check interfaces.
8192 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8193 (tparam): Adjust signature to match interface in tparam.h;
8194 this removes some undefined behavior. Check that outstring and len
8195 are zero, which they always are with Emacs.
8196 * tparam.h (PC, BC, UP): New extern decls.
8197
0248044d 8198 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8199 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8200
8ff096c1 8201 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8202 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8203 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8204 (ftfont_list): Remove unused local.
49eaafba
PE
8205 (get_adstyle_property, ftfont_pattern_entity):
8206 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8207 Rename locals to avoid shadowing.
8ff096c1 8208
e2be39f6
PE
8209 * xfont.c (xfont_list_family): Mark var as initialized.
8210
c9735e30
PE
8211 * xml.c (make_dom): Now static.
8212
8f5201ae
PE
8213 * composite.c (composition_compute_stop_pos): Rename local to
8214 avoid shadowing.
b246f932
PE
8215 (composition_reseat_it): Remove unused locals.
8216 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8217 (composition_update_it): Mark var as initialized.
11b61122
PE
8218 (find_automatic_composition): Mark vars as initialized,
8219 with a FIXME (Bug#8290).
8f5201ae 8220
760fbc2c
PE
8221 character.h: Rename locals to avoid shadowing.
8222 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8223 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8224 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8225 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8226 to avoid shadowing.
8227
ff08eb85
PE
8228 * textprop.c (property_change_between_p): Remove; unused.
8229
fc7bf025
PE
8230 * intervals.c (interval_start_pos): Now static.
8231
235d7abc
PE
8232 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8233
44f230aa
SM
8234 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8235 Rename locals to avoid shadowing.
3e7d6594 8236
50060332
PE
8237 * sound.c (wav_play, au_play, Fplay_sound_internal):
8238 Fix pointer signedness.
d01f234b 8239 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8240 (wav_play): Initialize a variable to 0, to prevent undefined
8241 behavior (Bug#8278).
50060332 8242
c4fc4e30
PE
8243 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8244
918436ed
PE
8245 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8246
c939f91b
PE
8247 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8248 clobbering (Bug#8298).
b9c7f648
PE
8249 * sysdep.c (sys_subshell): Likewise.
8250 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8251
6bd8c144
PE
8252 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8253 This should get cleaned up, so that child_setup has the
8254 same signature on all platforms.
8255
7710357c 8256 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8257 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8258
c59da222
CY
82592011-03-22 Chong Yidong <cyd@stupidchicken.com>
8260
8261 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8262 not to be necessary, and produces flickering.
8263
66b87493
GM
82642011-03-20 Glenn Morris <rgm@gnu.org>
8265
8266 * config.in: Remove file.
8267
45b6f6d5
JB
82682011-03-20 Juanma Barranquero <lekktu@gmail.com>
8269
8270 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8271 are now in src/globals.h.
8272 (syms_of_minibuf): Remove spurious & from previous change.
8273
3ec03f7e
LL
82742011-03-20 Leo <sdl.web@gmail.com>
8275
8276 * minibuf.c (completing-read-function): New variable.
8277 (completing-read-default): Rename from completing-read.
8278 (completing-read): Call completing-read-function.
8279
b14e3e21
CY
82802011-03-19 Juanma Barranquero <lekktu@gmail.com>
8281
8282 * xfaces.c (Fx_load_color_file):
8283 Read color file from absolute filename (bug#8250).
8284
f2b726e6
JB
82852011-03-19 Juanma Barranquero <lekktu@gmail.com>
8286
8287 * makefile.w32-in: Update dependencies.
8288
09f6ff02
EZ
82892011-03-17 Eli Zaretskii <eliz@gnu.org>
8290
8291 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8292
29a6015a
PE
82932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8294
a3a6c54e
PE
8295 Fix more problems found by GCC 4.5.2's static checks.
8296
b766f867
PE
8297 * process.c (make_serial_process_unwind, send_process_trap):
8298 (sigchld_handler): Now static.
8299
be02381c
PE
8300 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8301 That way, the code declares only the vars that it needs.
8302 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8303 * s/cygwin.h (PTY_ITERATION): Likewise.
8304 * s/darwin.h (PTY_ITERATION): Likewise.
8305 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8306
57048744
PE
8307 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8308 * process.c (allocate_pty): Don't declare stb unless it's needed.
8309
7914961c 8310 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8311 (CONSTANTLIM): Remove; unused.
8312 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8313 Define only if needed.
7914961c 8314
b3967b18
PE
8315 * unexelf.c (unexec): Name an expression,
8316 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8317 Use a different way to cause a compilation error if anyone uses
8318 n rather than nn, a way that does not involve shadowing.
73366a00 8319 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8320
29a6015a
PE
8321 * deps.mk (unexalpha.o): Remove; unused.
8322
43cfc33e 8323 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8324 * unexec.h: New file.
ce701a33
PE
8325 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8326 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8327 Depend on unexec.h.
8328 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8329 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8330 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8331 Change as necessary to match prototype in unexec.h.
ce701a33 8332
01f44d5a
PE
8333 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8334 shadowing.
4f63c6bb 8335 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8336
a6670b0b
PE
8337 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8338 Rename locals to avoid shadowing.
8339
cef2010d 8340 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8341 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8342
d4d7173a
PE
8343 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8344
f08b802a
PE
8345 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8346 warning when compiling print.c.
8347
3ddb0639
PE
8348 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8349 instead of using an uninitialized var.
5ad03b97 8350 (font_sort_entities): Mark var as initialized.
3ddb0639 8351
170a2692
PE
8352 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8353
e663c700
PE
8354 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8355 pointers to constants.
89bc529a 8356 (font_parse_fcname): Remove unused vars.
7b81e2d0 8357 (font_delete_unmatched): Now static.
ea838e10 8358 (font_get_spec): Remove; unused.
13a547c6
PE
8359 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8360 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8361 Rename or move locals to avoid shadowing.
e663c700 8362
2a80c887 8363 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8364 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8365
1384fa33 8366 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8367 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8368
8b2c52e9
PE
8369 * alloc.c (mark_backtrace): Move decl from here ...
8370 * lisp.h: ... to here, so that it can be checked.
8371
475545b5 8372 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8373 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8374 (lisp_indirect_variable): Name an expression,
8375 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8376 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8377
b1349114 8378 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8379 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8380 Use const pointer when appropriate.
b1349114 8381
a2928364
PE
8382 * lisp.h (get_system_name, get_operating_system_release):
8383 Move decls here, to check interfaces.
8384 * process.c (get_operating_system_release): Move decl to lisp.h.
8385 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8386 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8387 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8388 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8389 (Fformat_time_string, Fencode_time, Finsert_char):
8390 (Ftranslate_region_internal, Fformat):
8391 Rename or remove local vars to avoid shadowing.
9710023e 8392 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8393
a415e694
PE
8394 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8395 avoid shadowing.
8396
8ef4622d
PE
8397 * lisp.h (eassert): Check that the argument compiles, even if
8398 ENABLE_CHECKING is not defined.
8399
946f9a5b
PE
8400 * data.c (Findirect_variable): Name an expression, to avoid
8401 gcc -Wbad-function-cast warning.
112396d6 8402 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8403 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8404 (Fmake_variable_buffer_local, Fmake_local_variable):
8405 Mark variables as initialized.
52746918 8406 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8407
e5aab7e7 8408 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8409 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8410 Rename locals to avoid shadowing.
dff45157
PE
8411 (mark_stack): Move local variables into the #ifdef region where
8412 they're used.
7bc26fdb
PE
8413 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8414 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8415 needed otherwise.
8416 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8417 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8418 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8419
e5aab7e7
PE
8420 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8421 avoids undefined behavior in theory.
8422
4da60324
PE
8423 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8424
88043301
PE
8425 Use functions, not macros, for up- and down-casing (Bug#8254).
8426 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8427 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8428 to use the following functions instead of these macros.
8429 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8430 EMACS_INT, since callers assume the returned value fits in int.
8431 (upcase1): Likewise, for UPCASE_TABLE.
8432 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8433 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8434 the race-condition problem in the old DOWNCASE.
88043301 8435
19ed5445
PE
8436 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8437 Rename locals to avoid shadowing.
8438 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8439 (regex_compile, re_search_2, re_match_2_internal):
8440 Remove unused local vars.
952db0d7
PE
8441 (FREE_VAR): Rewrite so as not to use empty "else",
8442 which gcc can warn about.
da053e48 8443 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8444 (RETALLOC_IF): Define only if needed.
8445 (WORDCHAR_P): Likewise. This one is never needed, but is used
8446 only in a comment talking about a compiler bug, so put inside
8447 the #if 0 of that comment.
8448 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8449 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8450 Remove; unused.
19ed5445 8451
1f3561e4 8452 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8453 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8454 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8455
ded6f8f7
PE
8456 * search.c (simple_search): Remove unused var.
8457
dbd37a95
PE
8458 * dired.c (compile_pattern): Move decl from here ...
8459 * lisp.h: ... to here, so that it can be checked.
8460 (struct re_registers): New forward decl.
8461
7e47afad
PE
8462 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8463
85f24f61
PE
8464 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8465 All uses changed.
8466 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8467 Rename locals to avoid shadowing.
5671df8f 8468 (Fvertical_motion): Mark locals as initialized.
85f24f61 8469
181aa2be 8470 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8471 (casify_region): Mark local as initialized.
181aa2be 8472
930d429c
PE
8473 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8474
7082eac6
PE
8475 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8476 New macros, so that the caller can use some names other than
8477 gcpro1, gcpro2, etc.
8478 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8479 of the new macros.
8480 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8481 argument, for consistency with GCPRO2_VAR, etc: it is now the
8482 prefix of the variable, not the variable itself. All uses
8483 changed.
38b2c076
PE
8484 * dired.c (directory_files_internal, file_name_completion):
8485 Rename locals to avoid shadowing.
8486
15206ed9
PE
8487 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8488 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8489 dired.c's scmp function, had undefined behavior.
8490 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8491 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8492 * buffer.h: ... to here, because these macros use current_buffer,
8493 and the new implementation with inline functions needs to have
8494 current_buffer in scope now, rather than later when the macros
8495 are used.
8496 (downcase, upcase1): New static inline functions.
8497 (DOWNCASE, UPCASE1): Reimplement using these functions.
8498 This avoids undefined behavior in expressions like
8499 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8500 from race conditions in accessing the global variables
8501 case_temp1 and case_temp2.
8502 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8503 * lisp.h (case_temp1, case_temp2): Remove their decls.
8504 * character.h (ASCII_CHAR_P): Move from here ...
8505 * lisp.h: ... to here, so that the inline functions mentioned
8506 above can use them.
8507
4a6bea26
PE
8508 * dired.c (directory_files_internal_unwind): Now static.
8509
f14b7e14
PE
8510 * fileio.c (file_name_as_directory, directory_file_name):
8511 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8512 Now static.
2893f146
PE
8513 (file_name_as_directory): Use const pointers when appropriate.
8514 (Fexpand_file_name): Likewise. In particular, newdir might
8515 point at constant storage, so make it a const pointer.
fd4ead52 8516 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8517 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8518 signedness issues.
f839df0c
PE
8519 (Fset_file_times, Finsert_file_contents, auto_save_error):
8520 Rename locals to avoid shadowing.
f14b7e14 8521
5716756e 8522 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8523 (Ftry_completion, Fall_completions): Rename or remove locals
8524 to avoid shadowing.
5716756e 8525
b4c3046a
PE
8526 * marker.c (bytepos_to_charpos): Remove; unused.
8527
b45db522
PE
8528 * lisp.h (verify_bytepos, count_markers): New decls,
8529 so that gcc does not warn that these functions aren't declared.
8530
85876d07
PE
8531 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8532 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8533 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8534 (copy_text): Remove unused local var.
85876d07 8535
03d78a21 8536 * filelock.c (within_one_second): Now static.
b3dd38ab 8537 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8538
5df8f01b
PE
8539 * buffer.c (fix_overlays_before): Mark locals as initialized.
8540 (fix_start_end_in_overlays): Likewise. This function should be
8541 simplified by using pointers-to-pointers, but that's a different
8542 matter.
b1d876f1 8543 (switch_to_buffer_1): Now static.
8f54f30a
PE
8544 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8545 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8546
a70072c9 8547 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8548 Fix pointer signedness issue.
edced198
PE
8549 (sys_subshell): Mark local as volatile if checking for lint,
8550 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8551 (MAXPATHLEN): Define only if needed.
a70072c9 8552
a0977c44
PE
8553 * process.c (serial_open, serial_configure): Move decls from here ...
8554 * systty.h: ... to here, so that they can be checked.
8555
a884fdcc
PE
8556 * fns.c (get_random, seed_random): Move extern decls from here ...
8557 * lisp.h: ... to here, so that they can be checked.
8558
604efe86 8559 * sysdep.c (reset_io): Now static.
b8950c94 8560 (wait_for_termination_signal): Remove; unused.
604efe86 8561
38fc62d9
PE
8562 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8563 (copy_keymap_item, append_key, push_text_char_description):
8564 Now static.
1004a21a 8565 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8566 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8567 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8568 (describe_map_tree):
8569 Rename locals to avoid shadowing.
38fc62d9 8570
2f2650da
PE
8571 * keyboard.c: Declare functions static if they are not used elsewhere.
8572 (echo_char, echo_dash, cmd_error, top_level_2):
8573 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8574 (read_char, kbd_buffer_get_event, make_lispy_position):
8575 (make_lispy_event, make_lispy_movement, apply_modifiers):
8576 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8577 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8578 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8579 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8580 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8581
a053e86c 8582 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8583 (mark_kboards): Move decl here ...
8584 * alloc.c (mark_kboards): ... from here.
a053e86c 8585
4752793e
PE
8586 * lisp.h (force_auto_save_soon): New decl.
8587
74f10ca7 8588 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8589 (DEFINE_DUMMY_FUNCTION): New macro.
8590 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8591 Use it.
c03cd23f
PE
8592 (main): Add casts to avoid warnings
8593 if GCC considers string literals to be constants.
74f10ca7 8594
022e70d4
PE
8595 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8596
59d6fe83
PE
8597 * dbusbind.c: Pointer signedness fixes.
8598 (xd_signature, xd_append_arg, xd_initialize):
8599 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8600 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8601 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8602 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8603
78320123
PE
8604 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8605 if GCC considers string literals to be constants.
49cebcca 8606 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8607
35ac2a97
SM
86082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8609
fb103ca9
SM
8610 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8611 (print_preprocess, print_object): New macro to fix last change.
8612
35ac2a97
SM
8613 * print.c (print_preprocess): Don't forget font objects.
8614
62973b41
JB
86152011-03-16 Juanma Barranquero <lekktu@gmail.com>
8616
8617 * emacs.c (USAGE3): Doc fixes.
8618
0e48bb22
AS
86192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8620
8621 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8622 structure.
8623
7684e57b
JB
86242011-03-14 Juanma Barranquero <lekktu@gmail.com>
8625
8626 * lisp.h (VWindow_system, Qfile_name_history):
8627 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8628 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8629 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8630
8631 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8632 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8633
8634 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8635 * w32console.c (detect_input_pending, read_input_pending)
8636 (encode_terminal_code):
8637 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8638 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8639 (w32_system_caret_y, Qfile_name_history):
8640 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8641 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8642 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8643 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8644 * w32proc.c (Qlocal, report_file_error):
8645 * w32term.c (Vwindow_system, updating_frame):
8646 * w32uniscribe.c (initialized, uniscribe_font_driver):
8647 Remove unneeded extern declarations.
8648
2aa46d6c
CY
86492011-03-14 Chong Yidong <cyd@stupidchicken.com>
8650
c96bbc66 8651 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8652
cffc6f3b
CY
86532011-03-13 Chong Yidong <cyd@stupidchicken.com>
8654
8655 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8656 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8657 These macros can no longer be used for assignment.
8658
44f230aa
SM
8659 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8660 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8661 (record_buffer_markers, fetch_buffer_markers): New functions for
8662 recording and fetching special buffer markers.
8663 (set_buffer_internal_1, set_buffer_temp): Use them.
8664
8665 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8666
8667 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8668
8669 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8670 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8671
8672 * xdisp.c (hscroll_window_tree):
8673 (reconsider_clip_changes): Use PT instead of BUF_PT.
8674
d251f04b
EZ
86752011-03-13 Eli Zaretskii <eliz@gnu.org>
8676
8677 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8678 $(EMACS_ROOT)/lib/intprops.h.
8679
f0c77cd1
PE
86802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8681
3eca4629
PE
8682 Fix more problems found by GCC 4.5.2's static checks.
8683
7c86ee98
PE
8684 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8685 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8686 (xg_free_frame_widgets): Make it clear that a local variable is
8687 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8688 (gdk_window_get_screen): Make it clear that this macro is needed
8689 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8690 (int_gtk_range_get_value): New function, which avoids a diagnostic
8691 from gcc -Wbad-function-cast.
8692 (xg_set_toolkit_scroll_bar_thumb): Use it.
8693 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8694 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8695 (get_utf8_string, xg_get_file_with_chooser):
8696 Rename locals to avoid shadowing.
8697 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8698
41729b81
PE
8699 * xgselect.c (xg_select): Remove unused var.
8700
f0c77cd1
PE
8701 * image.c (four_corners_best): Mark locals as initialized.
8702 (gif_load): Initialize transparent_p to zero (Bug#8238).
8703 Mark another local as initialized.
ec6cf4c6 8704 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8705
ce0ad53d 8706 * image.c (clear_image_cache): Now static.
d5d5a617 8707 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8708 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8709 (x_edge_detection): Remove unnecessary cast that
8710 gcc -Wbad-function-cast diagnoses.
2037898d 8711 (gif_load): Fix pointer signedness.
6ae141d6
PE
8712 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8713 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8714
33383987 87152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8716
d32df629
PE
8717 Improve quality of tests for time stamp overflow.
8718 For example, without this patch (encode-time 0 0 0 1 1
8719 1152921504606846976) returns the obviously-bogus value (-948597
8720 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8721 reports time overflow. See
8722 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8723 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8724 * editfns.c: Include limits.h and intprops.h.
8725 (TIME_T_MIN, TIME_T_MAX): New macros.
8726 (time_overflow): Move earlier, to before first use.
8727 (hi_time, lo_time): New functions, for an accurate test for
8728 out-of-range times.
8729 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8730 (Fget_internal_run_time): Don't assume time_t fits in int.
8731 (make_time): Use list2 instead of Fcons twice.
8732 (Fdecode_time): More accurate test for out-of-range times.
8733 (check_tm_member): New function.
8734 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8735 (lisp_time_argument): Don't rely on undefined left-shift and
8736 right-shift behavior when checking for time stamp overflow.
8be6f318 8737
fe31d94c
PE
8738 * editfns.c (time_overflow): New function, refactoring common code.
8739 (Fformat_time_string, Fdecode_time, Fencode_time):
8740 (Fcurrent_time_string): Use it.
8741
8be6f318
PE
8742 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8743 * dired.c (make_time): Move to ...
8744 * editfns.c (make_time): ... here.
8745 * systime.h: Note the move.
8746
09d9db2c 87472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8748
126bc0dc
YM
8749 * fringe.c (update_window_fringes): Remove unused variables.
8750
c47cbdfd
YM
8751 * unexmacosx.c (copy_data_segment): Also copy __got section.
8752 (Bug#8223)
8753
7ac80be9
EZ
87542011-03-12 Eli Zaretskii <eliz@gnu.org>
8755
c96bbc66 8756 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8757 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8758 Constify `char *' arguments and their references according to
8759 prototypes in tparam.h.
8760
ecb0f94d 8761 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8762
7ac80be9
EZ
8763 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8764 Adapt all references accordingly.
8765
8766 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8767
ef1fd07e
TT
87682011-03-11 Tom Tromey <tromey@redhat.com>
8769
8770 * buffer.c (syms_of_buffer): Remove obsolete comment.
8771
7ef4b50c
EZ
87722011-03-11 Eli Zaretskii <eliz@gnu.org>
8773
8774 * termhooks.h (encode_terminal_code): Declare prototype.
8775
8776 * msdos.c (encode_terminal_code): Don't declare prototype.
8777
8778 * term.c (encode_terminal_code): Now external again, used by
8779 w32console.c and msdos.c.
8780
44f230aa
SM
8781 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8782 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8783
4b1ec863 87842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8785
1714f52b 8786 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8787
4b1ec863
PE
8788 * fringe.c (update_window_fringes): Mark locals as initialized
8789 (Bug#8227).
8790 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8791
524c7aa6
PE
8792 * alloc.c (mark_fringe_data): Move decl from here ...
8793 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8794 to check its interface.
8795 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8796
a5c0af81 8797 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8798 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8799 (fontset_font): Mark local as initialized.
a9a06e0b 8800 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8801
b4716021
PE
8802 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8803
811e9bac 8804 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8805 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8806 (x_own_selection, Fx_disown_selection_internal): Rename locals
8807 to avoid shadowing.
8808 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8809
7e3ab302
PE
8810 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8811 so that the caller can use some name other than gcpro1.
8812 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8813 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8814 (Fx_backspace_delete_keys_p):
8815 Use them to avoid shadowing, and rename vars to avoid shadowing.
8816 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8817 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8818 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8819 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8820 Remove unused locals.
7e3ab302
PE
8821 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8822 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8823 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8824 macros.
f78faa98 8825
e2b13473
PE
8826 * xterm.h (x_mouse_leave): New decl.
8827
77f23912
PE
8828 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8829 Remove unused functions.
cdf4ba58
PE
8830 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8831 (x_calc_absolute_position): Now static.
7411c686 8832 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8833 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8834 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8835 unless they are used.
38d0b34a
PE
8836 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8837 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8838 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8839 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8840 (x_error_catcher, x_connection_closed, x_error_handler):
8841 (x_error_quitter, xembed_send_message, x_iconify_frame):
8842 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8843 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8844 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8845
44f230aa
SM
8846 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8847 Rename or move locals to avoid shadowing.
6b463e58 8848 (tty_defined_color, merge_face_heights): Now static.
5967d051 8849 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8850 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8851 does not deduce is never used uninitialized.
73719eba
PE
8852 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8853 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8854
426994c3 8855 * terminal.c (store_terminal_param): Now static.
5489860b 8856
032f1620 8857 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8858 (set_frame_menubar): Remove unused local.
d4323972 8859 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8860 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8861 since they might point to immutable storage.
281585b0
PE
8862 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8863 since it's unused otherwise.
032f1620 8864
367c19e5 8865 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8866 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8867 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8868 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8869 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8870 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8871 does not deduce are never used uninitialized.
70739cbe 8872
07b48fa9
PE
8873 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8874
8868a238 8875 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8876 * window.c (window_loop, size_window):
8877 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8878
7e5cf297 8879 * window.c (display_buffer): Now static.
d6550a9f
PE
8880 (size_window): Mark variables that gcc -Wuninitialized
8881 does not deduce are never used uninitialized.
a586633d
PE
8882 * window.h (check_all_windows): New decl, to forestall
8883 gcc -Wmissing-prototypes diagnostic.
5b555da1 8884 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8885
f6095868
PE
8886 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8887 shadowing.
8888 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8889 Include <limits.h>.
8890 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8891 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8892 (load_charset_map): Mark variables that gcc -Wuninitialized
8893 does not deduce are never used uninitialized.
53df7c11 8894 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8895
f38b440c
PE
8896 * coding.c (coding_set_source, coding_set_destination):
8897 Use "else { /* comment */ }" rather than "else /* comment */;"
8898 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8899 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8900 a block, when the outer 'i' will do.
8901 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8902 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8903 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8904 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8905 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8906 Rename locals to avoid shadowing.
8907 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8908 * coding.c (emacs_mule_char, encode_invocation_designation):
8909 Now static, since they're not used elsewhere.
413bb2db 8910 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8911 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8912 (decode_coding_emacs_mule): Mark variables that gcc
8913 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8914 (detect_coding_iso_2022): Initialize a local variable that might
8915 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8916 this initialization is needed. (Bug#8211)
5f58e762
PE
8917 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8918 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8919 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8920 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8921 Remove unused macros.
f38b440c 8922
232b38b9 8923 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8924 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8925 * character.c (string_count_byte8): Likewise.
232b38b9 8926
fb90da1b
PE
8927 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8928 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8929
fb93dbc2
PE
8930 * chartab.c (copy_sub_char_table): Now static, since it's not used
8931 elsewhere.
5c156ace
PE
8932 (sub_char_table_ref_and_range, char_table_ref_and_range):
8933 Rename locals to avoid shadowing.
bbcd0949 8934 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8935
7d3b3862 8936 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8937 (BIDI_BOB): Remove unused macro.
7d3b3862 8938
6be7d3da
PE
8939 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8940 deduce are never used uninitialized.
c2ed9c8b 8941 * term.c (encode_terminal_code): Likewise.
6be7d3da 8942
75f8807f 8943 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8944
50938595
PE
8945 * tparam.h: New file.
8946 * term.c, tparam.h: Include it.
8947 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8948 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8949 Move these decls to tparam.h, and make them agree with what
8950 is actually in tparam.c. The previous trick of using incompatible
8951 decls in different modules does not conform to the C standard.
8952 All callers of tparam changed to use tparam's actual API.
8953 * tparam.c (tparam1, tparam, tgoto):
8954 Use const pointers where appropriate.
8955
fbceeba2
PE
8956 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8957 * cm.h (struct cm): Likewise.
8958 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8959 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8960 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8961 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8962 (turn_on_face, init_tty): Likewise.
8963 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8964
7f3f1250
PE
8965 * term.c (term_mouse_position): Rename local to avoid shadowing.
8966
e6ca6543
PE
8967 * alloc.c (mark_ttys): Move decl from here ...
8968 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8969
c40f8d15
AS
89702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8971
8972 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8973
cfe0661d
JB
89742011-03-09 Juanma Barranquero <lekktu@gmail.com>
8975
8976 * search.c (compile_pattern_1): Remove argument regp, unused since
8977 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8978 (compile_pattern): Don't pass it.
8979
0afb4571
J
89802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8981
8982 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8983 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8984 for ! HAVE_GTK3.
8985 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8986
8987 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8988
8989 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8990 gdk_window_get_screen, gdk_window_get_geometry,
8991 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8992 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8993 (xg_get_pixbuf_from_pixmap): New function.
8994 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8995 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8996 Call xg_get_pixbuf_from_pixmap instead of
8997 gdk_pixbuf_get_from_drawable.
8998 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8999 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9000 (xg_check_special_colors): Use GtkStyleContext and its functions
9001 for HAVE_GTK3.
9002 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9003 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9004 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9005 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9006 Call gtk_widget_get_preferred_size.
0afb4571
J
9007 (xg_frame_resized): gdk_window_get_geometry only takes 5
9008 parameters.
44f230aa
SM
9009 (xg_win_to_widget, xg_event_is_for_menubar):
9010 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9011 (xg_set_widget_bg): New function.
9012 (delete_cb): New function.
895009e1 9013 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9014 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9015 (xg_set_background_color): Call xg_set_widget_bg.
9016 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9017 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9018 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9019 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9020 if ! HAVE_GTK3.
9021 (update_frame_tool_bar): Call gtk_widget_hide.
9022 (xg_initialize): Use GDK_KEY_g.
9023
9024 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9025 if ! HAVE_GTK3
9026 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9027
9028 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9029 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9030 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9031
1c2cc4ef
JB
90322011-03-08 Juanma Barranquero <lekktu@gmail.com>
9033
9034 * w32xfns.c (select_palette): Check success of RealizePalette against
9035 GDI_ERROR, not zero.
9036
33383987 9037See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9038
9039;; Local Variables:
9040;; coding: utf-8
aac0c6e3
MR
9041;; End:
9042
acaf905b 9043 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9044
9045 This file is part of GNU Emacs.
9046
9047 GNU Emacs is free software: you can redistribute it and/or modify
9048 it under the terms of the GNU General Public License as published by
9049 the Free Software Foundation, either version 3 of the License, or
9050 (at your option) any later version.
9051
9052 GNU Emacs is distributed in the hope that it will be useful,
9053 but WITHOUT ANY WARRANTY; without even the implied warranty of
9054 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9055 GNU General Public License for more details.
9056
9057 You should have received a copy of the GNU General Public License
9058 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.