* xdisp.c (draw_row_with_mouse_face): Now static.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
93ea6e8f
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
1683e3ab
PE
3 * xdisp.c (draw_row_with_mouse_face): Now static.
4 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5
de9c2632
PE
6 * window.h (check_all_windows): Mark externally visible.
7
2b96acb7
PE
8 * window.c (window_deletion_count): Now static.
9
10 * undo.c: Make symbols static if they're not exported.
11 (last_undo_buffer, last_boundary_position, pending_boundary):
12 Now static.
13
50436f33
PE
14 * textprop.c (interval_insert_behind_hooks): Now static.
15 (interval_insert_in_front_hooks): Likewise.
16
64520e5c
PE
17 * term.c: Make symbols static if they're not exported.
18 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
19 (max_frame_lines, tty_set_terminal_modes):
20 (tty_reset_terminal_modes, tty_turn_off_highlight):
21 (get_tty_terminal): Now static.
22 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
23 * termhooks.h (term_mouse_moveto): Do not declare if
24 HAVE_WINDOW_SYSTEMM.
25 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
26 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
27
1fa53021
PE
28 * sysdep.c: Make symbols static if they're not exported.
29 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
30 Now static.
31 (sigprocmask_set, full_mask): Remove; unused.
32 (wait_debugging): Mark as visible.
33 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
34 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
35
d4b43b22
PE
36 * syntax.c (syntax_temp): Define only if !__GNUC__.
37
b7c513d0
PE
38 * sound.c (current_sound_device, current_sound): Now static.
39
989b29ad
PE
40 * search.c (searchbufs, searchbuf_head): Now static.
41
13a55a78
PE
42 * scroll.c (scroll_cost): Remove; unused.
43 * dispextern.h (scroll_cost): Remove decl.
44
de68a1fc
PE
45 * region-cache.h (pp_cache): Mark as externally visible.
46
40ccffa6
PE
47 * process.c: Make symbols static if they're not exported.
48 (process_tick, update_tick, create_process, chan_process):
49 (Vprocess_alist, proc_buffered_char, datagram_access):
50 (fd_callback_data, send_process_frame, process_sent_to): Now static.
51 (deactivate_process): Mark defn as static, as well as decl.
52 * lisp.h (create_process): Remove decl.
53 * process.h (chan_process, Vprocess_alist): Remove decls.
54
ad64fc97
PE
55 * print.c: Make symbols static if they're not exported.
56 (print_depth, new_backquote_output, being_printed, print_buffer):
57 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
58 (print_interval, print_number_index, initial_stderr_stream):
59 Now static.
60 * lisp.h (Fprinc): Remove decl.
61 (debug_output_compilation_hack): Mark as externally visible.
62
adddb265
PE
63 * sysdep.c (croak): Move decl from here to syssignal.h.
64 * syssignal.h (croak): Put it here, so the API can be checked when
65 'croak' is called from dissociate_if_controlling_tty.
66
1717ede2
PE
67 * minibuf.c: Make symbols static if they're not exported.
68 (minibuf_save_list, choose_minibuf_frame): Now static.
69 * lisp.h (choose_minibuf_frame): Remove decl.
70
fa5fb2bc
PE
71 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
72
1e3890d1
PE
73 * lread.c: Make symbols static if they're not exported.
74 (read_objects, initial_obarray, oblookup_last_bucket_number):
75 Now static.
76 (make_symbol): Remove; unused.
77 * lisp.h (initial_obarray, make_symbol): Remove decls.
78
8a1414fa
PE
79 * keyboard.c: Make symbols static if they're not exported.
80 (single_kboard, recent_keys_index, total_keys, recent_keys):
81 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
82 (this_single_command_key_start, echoing, last_auto_save):
83 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
84 (command_loop, echo_now, keyboard_init_hook, help_char_p):
85 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
86 (Vlispy_mouse_stem, double_click_count):
87 Now static.
88 (force_auto_save_soon): Define only if SIGDANGER.
89 (ignore_mouse_drag_p): Now static if
90 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
91 (print_help): Remove; unused.
92 (stop_character, last_timer_event): Mark as externally visible.
93 * keyboard.h (ignore_mouse_drag_p): Declare only if
94 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
95 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
96 * lisp.h (echoing): Remove decl.
97 (force_auto_save_soon): Declare only if SIGDANGER.
98 * xdisp.c (redisplay_window): Simplify code, to make it more
99 obvious that ignore_mouse_drag_p is not accessed if !defined
100 USE_GTK && !defined HAVE_NS.
101
93ea6e8f
PE
102 * intervals.c: Make symbols static if they're not exported.
103 (merge_properties_sticky, merge_interval_right, delete_interval):
104 Now static.
105 * intervals.h (merge_interval_right, delete_interval): Remove decls.
106
b532497d
PE
1072011-04-13 Paul Eggert <eggert@cs.ucla.edu>
108
77382fcc
PE
109 * insdel.c: Make symbols static if they're not exported.
110 However, leave prepare_to_modify_buffer alone. It's never
111 called from outside this function, but that appears to be a bug.
112 (combine_after_change_list, combine_after_change_buffer):
4889fc82 113 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
114 (adjust_after_replace_noundo): Remove; unused.
115 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 116 (signal_before_change): Remove decls.
77382fcc 117
9306c32e
PE
118 * indent.c (val_compute_motion, val_vmotion): Now static.
119
cd44d2eb
PE
120 * image.c: Make symbols static if they're not exported.
121 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
122 if USE_GTK.
123 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
124 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
125
ad9a7a06
PE
126 * fringe.c (standard_bitmaps): Now static.
127 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
128
81626931
PE
129 * frame.c: Make symbols static if they're not exported.
130 (x_report_frame_params, make_terminal_frame): Now static.
131 (get_frame_param): Now static, unless HAVE_NS.
132 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
133 (x_get_resource_string): Remove; not used.
134 * frame.h (make_terminal_frame, x_report_frame_params):
135 (x_get_resource_string); Remove decls.
136 (x_fullscreen_adjust): Declare only if WINDOWSNT.
137 * lisp.h (get_frame_param): Declare only if HAVE_NS.
138
239f9db9
PE
139 * font.c, fontset.c: Make symbols static if they're not exported.
140 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
141 (FACE_SUITABLE_FOR_CHAR_P): Use it.
142 * font.c (font_close_object): Now static.
143 * font.h (font_close_object): Remove.
144 * fontset.c (FONTSET_OBJLIST): Remove.
145 (free_realized_fontset) #if-0 the body, which does nothing.
146 (face_suitable_for_char_p): #if-0, as it's never called.
147 * fontset.h (face_suitable_for_char_p): Remove decl.
148 * xfaces.c (face_at_string_position): Use
149 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
150 since 0 is always ASCII.
151
dfcf3579
PE
152 * fns.c (weak_hash_tables): Now static.
153
5045092b
PE
154 * fileio.c: Make symbols static if they're not exported.
155 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
156 (Vwrite_region_annotation_buffers): Now static.
157
57a96f5c
PE
158 * eval.c: Make symbols static if they're not exported.
159 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
160 * lisp.h (backtrace_list): Remove decl.
161
35f08c38
PE
162 * emacs.c: Make symbols static if they're not exported.
163 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
164 (fatal_error_code, fatal_error_signal_hook, standard_args):
165 Now static.
166 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
167 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
168 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
169 * lisp.h (fatal_error_signal_hook): Remove decl.
170 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
171
f44bd759
PE
172 * editfns.c: Move a (normally-unused) function to its only use.
173 * editfns.c, lisp.h (get_operating_system_release): Remove.
174 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
175 worth the hassle of breaking this out.
176
b532497d
PE
177 * xterm.c: Make symbols static if they're not exported.
178 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
179 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
180 (x_destroy_window, x_delete_display):
181 Now static.
182 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
183 (x_mouse_leave): Remove; unused.
184 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
185 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
186 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
187 Remove decls.
188 (x_mouse_leave): Declare only if WINDOWSNT.
189 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
190 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
191 USE_X_TOOLKIT.
192
a25f4dfa
PE
1932011-04-12 Paul Eggert <eggert@cs.ucla.edu>
194
1675728f
PE
195 * ftxfont.c: Make symbols static if they're not exported.
196 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
197 HAVE_FREETYPE.
198 * font.h (ftxfont_driver): Likewise.
199
e4cebfca
PE
200 * xfns.c: Make symbols static if they're not exported.
201 (x_last_font_name, x_display_info_for_name):
202 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
203 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
204 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
205 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
206 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
207 (last_show_tip_args): Now static.
208 (xic_defaut_fontset, xic_create_fontsetname): Define only if
209 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
210 (x_screen_planes): Remove; unused.
211 * dispextern.h (x_screen_planes): Remove decl.
212
5bf46f05
PE
213 * dispnew.c: Make symbols static if they're not exported.
214 * dispextern.h (redraw_garbaged_frames, scrolling):
215 (increment_row_positions): Remove.
216 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
217 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
218 Now static.
219 (redraw_garbaged_frames): Remove; unused.
220
435f4c28
PE
221 * xfaces.c: Make symbols static if they're not exported.
222 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
223 Remove decls.
224 * xterm.h (defined_color): Remove decls.
225 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
226 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
227 (menu_face_changed_default, defined_color, free_realized_face):
228 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
229 (ascii_face_of_lisp_face): Remove; unused.
230
8524aef3
PE
231 * xdisp.c: Make symbols static if they're not exported.
232 * dispextern.h (scratch_glyph_row, window_box_edges):
233 (glyph_to_pixel_coords, set_cursor_from_row):
234 (get_next_display_element, set_iterator_to_next):
235 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
236 (show_mouse_face): Remove decls
237 * frame.h (message_buf_print): Likewise.
238 * lisp.h (pop_message, set_message, check_point_in_composition):
239 Likewise.
240 * xterm.h (set_vertical_scroll_bar): Likewise.
241 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
242 (message_buf_print, scratch_glyph_row, displayed_buffer):
243 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
244 (get_next_display_element, show_mouse_face, window_box_edges):
245 (frame_to_window_pixel_xy, check_point_in_composition):
246 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
247 (glyph_to_pixel_coords): Remove; unused.
248
16390cd2
PE
249 * dired.c (file_name_completion): Now static.
250
251 * dbusbind.c (xd_in_read_queued_messages): Now static.
252
a25f4dfa
PE
253 * lisp.h (circular_list_error, FOREACH): Remove; unused.
254 * data.c (circular_list_error): Remove.
255
16a97296
PE
2562011-04-11 Paul Eggert <eggert@cs.ucla.edu>
257
14a9c8df
PE
258 * commands.h (last_point_position, last_point_position_buffer):
259 (last_point_position_window): Remove decls.
260 * keyboard.c: Make these variables static.
261
74ab6df5
PE
262 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
263 decls.
264 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
265 (iso_code_class, detect_coding, code_convert_region): Now static.
266 (encode_coding_gap): Remove; unused.
267
38dfbee1
PE
268 * chartab.c (chartab_chars, chartab_bits): Now static.
269
a2cb4e63
PE
270 * charset.h (charset_iso_8859_1): Remove decl.
271 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
272 Now static.
273
127198fd
PE
274 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
275 * ccl.c (Vccl_program_table): Now static.
276 (check_ccl_update): Remove; unused.
277
d85b608f
PE
278 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
279 * category.h: ... from here.
280 * category.c (check_category_table, set_category_set): Now static.
281
31cd66f3
PE
282 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
283 * lisp.h: Remove these decls.
284
c358e587
PE
285 * buffer.c (buffer_count): Remove unused var.
286
e78aecca
PE
287 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
288 so that it's not optimized away.
289 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
290 * dispextern.h (bidi_dump_cached_states): Remove, since it's
291 exported only to the debugger.
292
e192d7d3
PE
293 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
294 * atimer.h (run_all_atimers): Removed; not exported.
295
92470028
PE
296 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
297 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
298 was inaccessible from Lisp.
299 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
300 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
301
244ed907
PE
302 alloc.c: Import and export fewer symbols, and remove unused items.
303 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
304 is defined.
305 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
306 it's not optimized away by whole-program optimization.
307 (message_enable_multibyte, free_misc): Remove.
308 (catchlist, handlerlist, mark_backtrace):
309 Declare only if BYTE_MARK_STACK.
310 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
311 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
312 (message_enable_multibyte): Remove decl.
313 (free_misc, interval_free_list, float_block, float_block_index):
314 (n_float_blocks, float_free_list, cons_block, cons_block_index):
315 (cons_free_list, last_marked_index):
316 Now static.
317 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
318 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
319 (mark_backtrace): Define only if BYTE_MARK_STACK.
320 * xdisp.c (message_enable_multibyte): Now static.
321
955cbe7b
PE
322 Declare Lisp_Object Q* variables to be 'static' if not exproted.
323 This makes it easier for human readers (and static analyzers)
324 to see whether these variables are used from other modules.
325 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
326 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
327 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
328 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
329 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
330 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
331 * xmenu.c, xselect.c:
332 Declare Q* vars static if they are not used in other modules.
333 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
334 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
335 Remove decls of unexported vars.
336 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
337
95c82688
PE
338 * lisp.h (DEFINE_FUNC): Make sname 'static'.
339
16a97296
PE
340 Make Emacs functions such as Fatom 'static' by default.
341 This makes it easier for human readers (and static analyzers)
342 to see whether these functions can be called from other modules.
343 DEFUN now defines a static function. To make the function external
344 so that it can be used in other C modules, use the new macro DEFUE.
345 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
346 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
347 static function definition. Use DEFUE if you want an extern one.
348 (DEFUE, INFUN): New macros.
349 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
350 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
351 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
352 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
353 Remove decls, since these functions are now static.
354 (Funintern, Fget_internal_run_time): New decls, since these functions
355 were already external.
95c82688 356
16a97296
PE
357 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
358 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
359 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
360 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
361 * keyboard.c, keymap.c, lread.c:
362 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
363 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
364 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
365 Mark functions with DEFUE instead of DEFUN,
366 if they are used in other modules.
367 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
368 decls for now-static functions.
369 * buffer.h (Fdelete_overlay): Remove decl.
370 * callproc.c (Fgetenv_internal): Mark as internal.
371 * composite.c (Fremove_list_of_text_properties): Remove decl.
372 (Fcomposition_get_gstring): New forward static decl.
373 * composite.h (Fcomposite_get_gstring): Remove decl.
374 * dired.c (Ffile_attributes): New forward static decl.
375 * doc.c (Fdocumntation_property): New forward static decl.
376 * eval.c (Ffetch_bytecode): New forward static decl.
377 (Funintern): Remove extern decl; now in .h file where it belongs.
378 * fileio.c (Fmake_symbolic_link): New forward static decl.
379 * image.c (Finit_image_library): New forward static decl.
380 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
381 * intervals.h (Fprevious_property_change):
382 (Fremove_list_of_text_properties): Remove decls.
383 * keyboard.c (Fthis_command_keys): Remove decl.
384 (Fcommand_execute): New forward static decl.
385 * keymap.c (Flookup_key): New forward static decl.
386 (Fcopy_keymap): Now static.
387 * keymap.h (Flookup_key): Remove decl.
388 * process.c (Fget_process): New forward static decl.
389 (Fprocess_datagram_address): Mark as internal.
390 * syntax.c (Fsyntax_table_p): New forward static decl.
391 (skip_chars): Remove duplicate decl.
392 * textprop.c (Fprevious_property_change): New forward static decl.
393 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
394 Now internal.
395 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
396 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
397
785bbd42
PE
3982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
399
400 * editfns.c (Fformat): Remove unreachable code.
401
4073e537 4022011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 403
b2ded58d
PE
404 Fix more problems found by GCC 4.6.0's static checks.
405
7d66342c
PE
406 * xdisp.c (vmessage): Use a better test for character truncation.
407
bbf47d44
PE
408 * charset.c (load_charset_map): <, not <=, for optimization,
409 and to avoid potential problems with integer overflow.
9248994d 410 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 411 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 412 * editfns.c (Fformat): Likewise.
1e69125e 413 * syntax.c (skip_chars): Likewise.
3befa583 414
e3019616
PE
415 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
416 This also lets GCC 4.6.0 generate slightly better loop code.
417
becfa255
PE
418 * callint.c (Fcall_interactively): <, not <=, for optimization.
419 (Fcall_interactively): Count the number of arguments produced,
420 not the number of arguments given. This is simpler and lets GCC
421 4.6.0 generate slightly better code.
422
dae0cd48
PE
423 * ftfont.c: Distingish more carefully between FcChar8 and char.
424 The previous code passed unsigned char * to a functions like
425 strlen and xstrcasecmp that expect char *, which does not
426 conform to the C standard.
427 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
428 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
429 char * when the C standard requires it.
430
76032d70
PE
431 * keyboard.c (read_char): Remove unused var.
432
eb3f1cc8
PE
433 * eval.c: Port to Windows vsnprintf (Bug#8435).
434 Include <limits.h>.
435 (SIZE_MAX): Define if the headers do not.
436 (verror): Do not give up if vsnprintf returns a negative count.
437 Instead, grow the buffer. This ports to Windows vsnprintf, which
438 does not conform to C99. Problem reported by Eli Zaretskii.
439 Also, simplify the allocation scheme, by avoiding the need for
440 calling realloc, and removing the ALLOCATED variable.
441
70476b54
PE
442 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
443
12020a9e
PE
444 Remove invocations of doprnt, as Emacs now uses vsnprintf.
445 But keep the doprint source code for now, as we might revamp it
446 and use it again (Bug#8435).
ea6c7ae6
PE
447 * lisp.h (doprnt): Remove.
448 * Makefile.in (base_obj): Remove doprnt.o.
449 * deps.mk (doprnt.o): Remove.
450
5fdb398c
PE
451 error: Print 32- and 64-bit integers portably (Bug#8435).
452 Without this change, on typical 64-bit hosts error ("...%d...", N)
453 was used to print both 32- and 64-bit integers N, which relied on
454 undefined behavior.
455 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
456 New macro.
457 * lisp.h (error, verror): Mark as printf-like functions.
458 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
459 Report overflow in size calculations when allocating printf buffer.
460 Do not truncate output string at its first null byte.
461 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
462 Truncate the output at a character boundary, since vsnprintf does not
463 do that.
464 * charset.c (check_iso_charset_parameter): Convert internal
465 character to string before calling 'error', since %c now has the
466 printf meaning.
467 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
468 overflow when computing char to be passed to 'error'. Do not
469 pass Lisp_Object to 'error'; pass the integer instead.
470 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
471 formatted with plain %d.
472
b189fa66
PE
473 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
474
bff87ef0
PE
475 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
476
7e2cac20
PE
477 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
478
ce4d90b5
PE
479 * xterm.c (x_catch_errors): Remove duplicate declaration.
480
266c9547
PE
481 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
482
79c49ad2
PE
483 * xdisp.c, lisp.h (message_nolog): Remove; unused.
484
368f4090
JM
4852011-04-10 Jim Meyering <meyering@redhat.com>
486
487 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
488 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
489 return ssize_t not "int", and use size_t as the buffer length.
490 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
491 * gnutls.h: Update declarations.
492 * process.c (read_process_output): Use ssize_t, to match.
493 (send_process): Likewise.
494
a32d4040
CY
4952011-04-09 Chong Yidong <cyd@stupidchicken.com>
496
497 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
498
8546720e 4992011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 500
8546720e
GM
501 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
502 unsigned char, to match FcChar8 type definition.
aac0c6e3 503
8546720e
GM
504 * xterm.c (handle_one_xevent):
505 * xmenu.c (create_and_show_popup_menu):
506 * xselect.c (x_decline_selection_request)
507 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 508
a53e2e89
EZ
5092011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
510
511 Fix some uses of `int' instead of EMACS_INT.
512 * search.c (string_match_1, fast_string_match)
513 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
514 (scan_buffer, find_next_newline_no_quit)
515 (find_before_next_newline, search_command, Freplace_match)
516 (Fmatch_data): Make some `int' variables be EMACS_INT.
517
518 * xdisp.c (display_count_lines): 3rd argument and return value now
519 EMACS_INT. All callers changed.
520 (pint2hrstr): Last argument is now EMACS_INT.
521
522 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
523 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
524 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
525 (decode_coding_utf_16, decode_coding_emacs_mule)
526 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
527 (decode_coding_ccl, decode_coding_charset)
528 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
529 (decode_coding_iso_2022, decode_coding_emacs_mule)
530 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
531 <char_offset, last_offset>: Declare EMACS_INT.
532 (encode_coding_utf_8, encode_coding_utf_16)
533 (encode_coding_emacs_mule, encode_invocation_designation)
534 (encode_designation_at_bol, encode_coding_iso_2022)
535 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
536 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
537 Declare EMACS_INT.
538 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
539 (encode_invocation_designation): Last argument P_NCHARS is now
540 EMACS_INT.
541 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
542 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
543
544 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
545 All users changed.
546
547 * ccl.c (Fccl_execute_on_string): Declare some variables
548 EMACS_INT.
549
8546720e 5502011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
551
552 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
553
4e19a977
CS
5542011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
555
556 * process.c (Fformat_network_address): Doc fix.
557
87302331
R
5582011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
559
560 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
561
cbb59342
CY
5622011-04-08 Chong Yidong <cyd@stupidchicken.com>
563
564 * keyboard.c (read_char): Call Lisp function help-form-show,
565 instead of using internal_with_output_to_temp_buffer.
566 (Qhelp_form_show): New var.
e0d38eeb 567 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
568
569 * print.c (internal_with_output_to_temp_buffer): Function deleted.
570
571 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
572
e67a13ab
CY
5732011-04-06 Chong Yidong <cyd@stupidchicken.com>
574
575 * process.c (Flist_processes): Removed to Lisp.
576 (list_processes_1): Deleted.
577
973f782d
EZ
5782011-04-06 Eli Zaretskii <eliz@gnu.org>
579
7c106b1e
EZ
580 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
581
973f782d
EZ
582 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
583
41cf7d1a 5842011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 585
ca23cc88
PE
586 Fix more problems found by GCC 4.6.0's static checks.
587
f390e2d5
PE
588 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
589
42eea0d0
PE
590 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
591
b69769da 592 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 593
f9541e84
PE
594 * xdisp.c (vmessage): Mark as a printf-like function.
595
13841b55
PE
596 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
597
c136c10f
PE
598 * sound.c (sound_warning): Don't crash if arg contains a printf format.
599
5e2d4a30
PE
600 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
601 printf-like functions.
602 (tiff_load): Add casts to remove these marks before passing them
603 to system-supplied API.
604
583f48b9
PE
605 * eval.c (Fsignal): Remove excess argument to 'fatal'.
606
b25d760e
PE
607 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
608 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
609 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
610 directly, rather than having caller test rule sign. This avoids
611 some unnecessary tests.
612 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
613 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
614 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 615
bc7b6697 616 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 617 (xfont_open): Avoid unnecessary tests.
bc7b6697 618
27ccc379
PE
619 * composite.c (composition_gstring_put_cache): Use unsigned integer.
620
dcd5c89a
PE
621 * composite.h, composite.c (composition_gstring_put_cache):
622 Use EMACS_INT, not int, for length.
623
b13a45c6
PE
624 * composite.h (COMPOSITION_DECODE_REFS): New macro,
625 breaking out part of COMPOSITION_DECODE_RULE.
626 (COMPOSITION_DECODE_RULE): Use it.
627 * composite.c (get_composition_id): Remove unused local vars,
628 by using the new macro.
629
1e792e4d
PE
630 * textprop.c (set_text_properties_1): Change while to do-while,
631 since the condition is always true at first.
632
dc6c6455 633 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
634 (interval_deletion_adjustment): Return unsigned value.
635 All uses changed.
dc6c6455 636
aba7731a
PE
637 * process.c (list_processes_1, create_pty, read_process_output):
638 (exec_sentinel): Remove vars that were set but not used.
afd4052b 639 (create_pty): Remove unnecessary "volatile"s.
bc57d757 640 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 641 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 642 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 643
fdfc4bf3
PE
644 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
645
fca8fe46 646 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 647 (update_syntax_table): Use unsigned instead of int.
fca8fe46 648
06a0259a 649 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 650 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 651 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 652
e7b9e80f
PE
653 * print.c (print_error_message): Avoid int overflow.
654
56201685
PE
655 * font.c (font_list_entities): Redo for clarity,
656 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
657
78834453 658 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 659 (font_score): Avoid potential overflow in diff calculation.
78834453 660
0bc0b309 661 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 662 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 663
e610eaca
PE
664 * eval.c (funcall_lambda): Rename local to avoid shadowing.
665
b895abce
PE
666 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
667 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
668 can always succeed if overflow has undefined behavior.
669
1f1d9321 670 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 671 (wordify): Omit three unnecessary tests.
1f1d9321 672
c59478bc
PE
673 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
674 All callers changed. This avoids the need for an unused var.
675
79b73827
PE
676 * casefiddle.c (casify_region): Remove var that is set but not used.
677
a4db5dfe
PE
678 * dired.c (file_name_completion): Remove var that is set but not used.
679
43aae36e
PE
680 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
681
2a47c44d 682 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 683 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 684
a37c69bf
PE
685 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
686 Check for integer overflow on size calculations.
687
328ab8e7
PE
688 * buffer.c (Fprevious_overlay_change): Remove var that is set
689 but not used.
690
e5a2a5cb
PE
691 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
692 Remove vars that are set but not used.
8d84a6eb 693 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 694 (timer_check_2): Mark vars as initialized.
e5a2a5cb 695
a60e5f68
PE
696 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
697
f661cb61 698 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 699 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 700
f0397f5a
PE
701 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
702 that are set but not used.
703
8664db06 704 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 705 if XCreateBitmapFromData fails (Bug#8410).
8664db06 706
6abdaa4a
PE
707 * xselect.c (x_get_local_selection, x_handle_property_notify):
708 Remove vars that are set but not used.
709
0ce7538d 710 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 711 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 712
9ae848fc
PE
713 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
714 Remove var that is set but not used.
0b918413
PE
715 (scroll_bar_windows_size): Now size_t, not int.
716 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
717 Check for overflow.
9ae848fc 718
a5a62657
PE
719 * xfaces.c (realize_named_face): Remove vars that are set but not used.
720 (map_tty_color) [!defined MSDOS]: Likewise.
721
5c5cdd39
PE
722 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
723
66ebf983
PE
724 * coding.c: Remove vars that are set but not used.
725 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
726 All callers changed.
727 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
728 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
729 (decode_coding_charset): Remove vars that are set but not used.
730
1be4d761
PE
731 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
732 that is set but not used.
733
47553fa8
PE
734 * print.c (print_object): Remove var that is set but not used.
735
1f7196bf 736 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
737 The gnulib version avoids calling malloc in the usual case,
738 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
739 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
740 * filelock.c (current_lock_owner): Likewise.
741 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
742 * sysdep.c: Include allocator.h, careadlinkat.h.
743 (emacs_no_realloc_allocator): New static constant.
744 (emacs_readlink): New function.
fdb61804
PE
745 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
746 ../lib/careadlinkat.h.
d1fdcab7 747
f84c17c7
SM
7482011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
749
750 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
751 first non-nil return value).
752
ef3862ad
JD
7532011-04-03 Jan Djärv <jan.h.d@swipnet.se>
754
755 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
756 if not defined (Bug#8403).
757
376a7006
JB
7582011-04-02 Juanma Barranquero <lekktu@gmail.com>
759
760 * xdisp.c (display_count_lines): Remove parameter `start',
761 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
762 (get_char_face_and_encoding): Remove parameter `multibyte_p',
763 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
764 (fill_stretch_glyph_string): Remove parameters `row' and `area',
765 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
766 and thereabouts. All callers changed.
767 (get_per_char_metric): Remove parameter `f', unused since
768 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
769
6ca3801d
JM
7702011-04-02 Jim Meyering <meyering@redhat.com>
771
772 do not dereference NULL upon failed strdup
773 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
774 (ns_get_family): Likewise.
775
d8e2b5ba
JB
7762011-04-02 Juanma Barranquero <lekktu@gmail.com>
777
778 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
779
8c74fcbd
JD
7802011-04-02 Jan Djärv <jan.h.d@swipnet.se>
781
782 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
783 later (Bug#8403).
784
7200d79c
SM
7852011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
786
03408648 787 Add lexical binding.
7200d79c 788
03408648
SM
789 * window.c (Ftemp_output_buffer_show): New fun.
790 (Fsave_window_excursion):
791 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
792
793 * lread.c (lisp_file_lexically_bound_p): New function.
794 (Fload): Bind Qlexical_binding.
795 (readevalloop): Remove `evalfun' arg.
796 Bind Qinternal_interpreter_environment.
797 (Feval_buffer): Bind Qlexical_binding.
798 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
799 Mark as dynamic.
800 (syms_of_lread): Declare `lexical-binding'.
801
802 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
803
804 * keyboard.c (eval_dyn): New fun.
805 (menu_item_eval_property): Use it.
ca105506
SM
806
807 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 808
03408648
SM
809 * fns.c (concat, mapcar1): Accept byte-code-functions.
810
811 * eval.c (Fsetq): Handle lexical vars.
812 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
813 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
814 (FletX, Flet): Obey lexical binding.
815 (Fcommandp): Handle closures.
816 (Feval): New `lexical' arg.
817 (eval_sub): New function extracted from Feval. Use it almost
818 everywhere where Feval was used. Look up vars in lexical env.
819 Handle closures.
820 (Ffunctionp): Move from subr.el.
821 (Ffuncall): Handle closures.
822 (apply_lambda): Remove `eval_flags'.
823 (funcall_lambda): Handle closures and new byte-code-functions.
824 (Fspecial_variable_p): New function.
825 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
826 but without exporting it to Lisp.
23aba0ea 827
23aba0ea 828 * doc.c (Fdocumentation, store_function_docstring):
03408648 829 * data.c (Finteractive_form): Handle closures.
23aba0ea 830
03408648
SM
831 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
832 interactive spec.
ba83908c 833
03408648
SM
834 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
835 byte-codes.
836 (exec_byte_code): New function extracted from Fbyte_code to handle new
837 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 838
03408648 839 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 840
03408648 841 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 842
e2abce01
JB
8432011-03-31 Juanma Barranquero <lekktu@gmail.com>
844
845 * xdisp.c (redisplay_internal): Fix prototype.
846
63696a73 8472011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 848
63696a73
EZ
849 * xdisp.c (SCROLL_LIMIT): New macro.
850 (try_scrolling): Use it when setting scroll_limit. Limit
851 scrolling to 100 screen lines.
852 (redisplay_window): Even when falling back on "recentering",
853 position point in the window according to scroll-conservatively,
854 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
855
856 (try_scrolling): When point is above the window, allow searching
857 as far as scroll_max, or one screenful, to compute vertical
858 distance from PT to the scroll margin position. This prevents
859 try_scrolling from unnecessarily failing when
860 scroll-conservatively is set to a value slightly larger than the
861 window height. Clean up the case of PT below the margin at bottom
862 of window: scroll_max can no longer be INT_MAX. When aggressive
863 scrolling is in use, don't let point enter the opposite scroll
864 margin as result of the scroll.
865 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
866 threshold of 100 lines for never-recentering scrolling.
867
e4cc2dfc
JB
8682011-03-31 Juanma Barranquero <lekktu@gmail.com>
869
870 * dispextern.h (move_it_by_lines):
871 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
872 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
873 (message_log_check_duplicate): Remove parameters `prev_bol' and
874 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
875 (redisplay_internal): Remove parameter `preserve_echo_area',
876 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
877
878 * indent.c (Fvertical_motion):
879 * window.c (window_scroll_pixel_based, Frecenter):
880 Don't pass `need_y_p' to `move_it_by_lines'.
881
1c470562
SM
8822011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
883
44f230aa
SM
884 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
885 steal a few bits to be more compact.
886 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
887 Remove unneeded casts.
888
1c470562
SM
889 * bytecode.c (Fbyte_code): CAR and CDR can GC.
890
888adce9
ZK
8912011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
892
893 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
894 binding" message (bug#7967).
895
f838ed7b
PE
8962011-03-30 Paul Eggert <eggert@cs.ucla.edu>
897
77861b95
PE
898 Fix more problems found by GCC 4.6.0's static checks.
899
de6dbc14
PE
900 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
901 Remove unused local var.
902
f838ed7b
PE
903 * editfns.c (Fmessage_box): Remove unused local var.
904
792c7b2b
PE
905 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
906 (note_mode_line_or_margin_highlight, note_mouse_highlight):
907 Omit unused local vars.
c499e557 908 * window.c (shrink_windows): Omit unused local var.
b01a1c29 909 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
910 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
911 Omit unused local var.
912
ba0165e1
PE
913 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
914 Don't assume string length fits in int.
32ad8845 915 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 916 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 917
3c59b4c9
PE
918 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
919 instead of alloca (Bug#8344).
920
a3eed478 921 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 922 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 923
eb4d412d
PE
924 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
925
1658b401
PE
926 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
927 concerns.
928
929 * term.c (produce_glyphless_glyph): Remove unnecessary test.
930
931 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 932
9a2c6e05
PE
933 * keyboard.c (syms_of_keyboard): Use the same style as later
934 in this function when indexing through an array. This also
935 works around GCC bug 48267.
936
03d0a109
PE
937 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
938
44f730c8
PE
939 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
940
fe75f926
PE
941 * chartab.c (sub_char_table_ref_and_range): Redo for slight
942 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
943
ffa8c828
PE
944 * keyboard.c, keyboard.h (num_input_events): Now size_t.
945 This avoids undefined behavior on integer overflow, and is a bit
946 more convenient anyway since it is compared to a size_t variable.
947
c5101a77
PE
948 Variadic C functions now count arguments with size_t, not int.
949 This avoids an unnecessary limitation on 64-bit machines, which
950 caused (substring ...) to crash on large vectors (Bug#8344).
951 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
952 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 953 All variadic functions and their callers changed accordingly.
c5101a77
PE
954 (struct gcpro.nvars): Now size_t, not int. All uses changed.
955 * data.c (arith_driver, float_arith_driver): Likewise.
956 * editfns.c (general_insert_function): Likewise.
957 * eval.c (struct backtrace.nargs, interactive_p)
958 (internal_condition_case_n, run_hook_with_args, apply_lambda)
959 (funcall_lambda, mark_backtrace): Likewise.
960 * fns.c (concat): Likewise.
961 * frame.c (x_set_frame_parameters): Likewise.
962 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
963 0 if not found, not -1. All callers changed.
964
dd3f25f7
PE
965 * alloc.c (garbage_collect): Don't assume stack size fits in int.
966 (stack_copy_size): Now size_t, not int.
967 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
968
461c2ab9
JB
9692011-03-28 Juanma Barranquero <lekktu@gmail.com>
970
971 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
972 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
973 All callers changed.
974
975 * lisp.h (multibyte_char_to_unibyte):
976 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
977 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
978 * character.h (CHAR_TO_BYTE8):
979 * cmds.c (internal_self_insert):
980 * editfns.c (general_insert_function):
981 * keymap.c (push_key_description):
982 * search.c (Freplace_match):
983 * xdisp.c (message_dolog, set_message_1): All callers changed.
984
f6d62986
SM
9852011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
986
987 * keyboard.c (safe_run_hook_funcall): New function.
988 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
989 don't set the hook to nil, but remove the offending function instead.
990 (Qcommand_hook_internal): Remove, unused.
991 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
992 Vcommand_hook_internal.
993
994 * eval.c (enum run_hooks_condition): Remove.
995 (funcall_nil, funcall_not): New functions.
996 (run_hook_with_args): Call each function through a `funcall' argument.
997 Remove `cond' argument, now redundant.
998 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
999 (Frun_hook_with_args_until_failure): Adjust accordingly.
1000 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1001
1db5b1ad
JB
10022011-03-28 Juanma Barranquero <lekktu@gmail.com>
1003
1004 * dispextern.h (string_buffer_position): Remove declaration.
1005
1006 * print.c (strout): Remove parameter `multibyte', unused since
1007 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1008
1009 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1010 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1011 All callers changed.
1012
1013 * w32.c (_wsa_errlist): Use braces for struct initializers.
1014
1015 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1016 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1017 All callers changed.
1018 (string_buffer_position): Likewise. Also, make static (it's never
1019 used outside xdisp.c).
1020 (cursor_row_p): Remove parameter `w', unused since
1021 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1022 (decode_mode_spec): Remove parameter `precision', introduced during
1023 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1024 All callers changed.
1025
5ffb62aa
JD
10262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1027
1028 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1029
461c2ab9 10302011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1031
1032 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1033 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1034 (ns_update_auto_hide_menu_bar): New functions.
1035 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1036 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1037 ns_constrain_all_frames.
1038 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1039 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1040
5c380ffb
JD
10412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1042
1043 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1044
9af30bdf
GM
10452011-03-27 Glenn Morris <rgm@gnu.org>
1046
1047 * syssignal.h: Replace RETSIGTYPE with void.
1048 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1049 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1050 Replace SIGTYPE with void everywhere.
1051 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1052 * s/template.h (SIGTYPE): Remove commented out definition.
1053
e2abce01
JB
10542011-03-26 Eli Zaretskii <eliz@gnu.org>
1055
1056 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1057 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1058
f868cd8a
JB
10592011-03-26 Juanma Barranquero <lekktu@gmail.com>
1060
59eb0929
JB
1061 * w32.c (read_unc_volume): Use parameter `henum', instead of
1062 global variable `wget_enum_handle'.
1063
1064 * keymap.c (describe_vector): Remove parameters `indices' and
1065 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1066 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1067
f868cd8a
JB
1068 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1069
1070 * keyboard.c (timer_check): Remove parameter `do_it_now',
1071 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1072 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1073 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1074
1075 * keyboard.c (read_char):
1076 * w32menu.c (w32_menu_display_help):
1077 * xmenu.c (show_help_event, menu_help_callback):
1078 Adjust calls to `show_help_echo'.
1079
1080 * gtkutil.c (xg_maybe_add_timer):
1081 * keyboard.c (readable_events):
1082 * process.c (wait_reading_process_output):
1083 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1084
1085 * insdel.c (adjust_markers_gap_motion):
1086 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1087 (gap_left, gap_right): Don't call it.
1088
2ecf6fdb
CY
10892011-03-25 Chong Yidong <cyd@stupidchicken.com>
1090
1091 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1092 incurred during fontification.
1093
6b1f9ba4
JB
10942011-03-25 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1097 (DEFVAR_PER_BUFFER): Don't pass it.
1098
1099 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1100 (scrolling_window): Don't pass it.
1101
0f4a96b5
JB
11022011-03-25 Juanma Barranquero <lekktu@gmail.com>
1103
1104 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1105
1106 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1107 and `suffix'.
1108 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1109 of variables specific to SELinux and computation of `encoded_absname'.
1110
1111 * image.c (XPutPixel): Remove unused variable `height'.
1112
1113 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1114
1115 * unexw32.c (get_section_info): Remove unused variable `section'.
1116
1117 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1118 (system_process_attributes): Remove unused variable `sess'.
1119 (sys_read): Remove unused variable `err'.
1120
1121 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1122 (w32_wnd_proc): Remove unused variable `isdead'.
1123 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1124 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1125 (x_create_tip_frame): Remove unused variable `tem'.
1126
1127 * w32inevt.c (w32_console_read_socket):
1128 Remove unused variable `no_events'.
1129
1130 * w32term.c (x_draw_composite_glyph_string_foreground):
1131 Remove unused variable `width'.
1132
1149507c
JB
11332011-03-24 Juanma Barranquero <lekktu@gmail.com>
1134
1135 * w32term.c (x_set_glyph_string_clipping):
1136 Don't pass uninitialized region to CombineRgn.
1137
9c88f339
JB
11382011-03-23 Juanma Barranquero <lekktu@gmail.com>
1139
1140 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1141 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1142 (Fx_close_connection): Remove unused variable `i'.
1143
1144 * w32font.c (w32font_draw): Return number of glyphs.
1145 (w32font_open_internal): Remove unused variable `i'.
1146 (w32font_driver): Add missing initializer.
1147
1148 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1149 (fill_in_menu): Remove unused variable `items_added'.
1150
1151 * w32term.c (last_mouse_press_frame): Remove static global variable.
1152 (w32_clip_to_row): Remove unused variable `f'.
1153 (x_delete_terminal): Remove unused variable `i'.
1154
1155 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1156 (NOTHING): Remove unused static global variable.
1157 (uniscribe_check_otf): Remove unused variable `table'.
1158 (uniscribe_font_driver): Add missing initializers.
1159
dee091a3
JD
11602011-03-23 Julien Danjou <julien@danjou.info>
1161
1162 * term.c (Fsuspend_tty, Fresume_tty):
1163 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1164 * window.c (temp_output_buffer_show):
1165 * insdel.c (signal_before_change):
1166 * frame.c (Fhandle_switch_frame):
1167 * fileio.c (Fdo_auto_save):
1168 * emacs.c (Fkill_emacs):
1169 * editfns.c (save_excursion_restore):
1170 * cmds.c (internal_self_insert):
1171 * callint.c (Fcall_interactively):
1172 * buffer.c (Fkill_all_local_variables):
1173 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1174 Use Frun_hooks.
0f4a96b5 1175 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1176 unconditionnaly since it does the check itself.
1177
2c520ab5 11782011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1179
c9c49752
PE
1180 Fix more problems found by GCC 4.5.2's static checks.
1181
8abc3f12
PE
1182 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1183 the first time through the loop, since we know p0 < p1 then.
1184 This also avoids a gcc -Wstrict-overflow warning.
1185
a2d26660
PE
1186 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1187 leading to a memory leak, possible in functions like
1188 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1189 of objects (Bug#8318).
a2d26660 1190
916c72e9
PE
1191 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1192 that could (at least in theory) be that large.
1193
19ab8a18
PE
1194 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1195 This is less likely to overflow, and avoids undefined behavior if
1196 overflow does occur. All callers changed. Use strtoul to scan
1197 for the unsigned long integer.
b7cbbd6f
PE
1198 (pint2hrstr): Simplify and tune code slightly.
1199 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1200
f0641eff
PE
1201 * scroll.c (do_scrolling): Work around GCC bug 48228.
1202 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1203
7f650bb9
PE
1204 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1205 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1206 (validate_x_resource_name): Simplify count usage.
1207 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1208
37dd57d1
PE
1209 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1210 fail (Bug#8306).
81e56e61 1211
699979fc 1212 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1213
401bf9b4
PE
1214 * process.c (Fmake_network_process): Use socklen_t, not int,
1215 where POSIX says socklen_t is required in portable programs.
1216 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1217 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1218 (Fmake_network_process, server_accept_connection):
1219 (wait_reading_process_output, read_process_output):
1220 Likewise.
1221
b93aacde
PE
1222 * process.c: Rename or move locals to avoid shadowing.
1223 (list_processes_1, Fmake_network_process):
1224 (read_process_output_error_handler, exec_sentinel_error_handler):
1225 Rename or move locals.
4dc343ee 1226 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1227 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1228 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1229 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1230 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1231
af8a867c 1232 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1233 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1234 Include tparam.h instead, since it declares them.
af8a867c
PE
1235 * cm.h (PC): Remove extern decl; tparam.h now does this.
1236 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1237 * terminfo.c: Include tparam.h, to check interfaces.
1238 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1239 (tparam): Adjust signature to match interface in tparam.h;
1240 this removes some undefined behavior. Check that outstring and len
1241 are zero, which they always are with Emacs.
1242 * tparam.h (PC, BC, UP): New extern decls.
1243
0248044d 1244 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1245 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1246
8ff096c1 1247 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1248 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1249 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1250 (ftfont_list): Remove unused local.
49eaafba
PE
1251 (get_adstyle_property, ftfont_pattern_entity):
1252 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1253 Rename locals to avoid shadowing.
8ff096c1 1254
e2be39f6
PE
1255 * xfont.c (xfont_list_family): Mark var as initialized.
1256
c9735e30
PE
1257 * xml.c (make_dom): Now static.
1258
8f5201ae
PE
1259 * composite.c (composition_compute_stop_pos): Rename local to
1260 avoid shadowing.
b246f932
PE
1261 (composition_reseat_it): Remove unused locals.
1262 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1263 (composition_update_it): Mark var as initialized.
11b61122
PE
1264 (find_automatic_composition): Mark vars as initialized,
1265 with a FIXME (Bug#8290).
8f5201ae 1266
760fbc2c
PE
1267 character.h: Rename locals to avoid shadowing.
1268 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1269 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1270 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1271 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1272 to avoid shadowing.
1273
ff08eb85
PE
1274 * textprop.c (property_change_between_p): Remove; unused.
1275
fc7bf025
PE
1276 * intervals.c (interval_start_pos): Now static.
1277
235d7abc
PE
1278 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1279
44f230aa
SM
1280 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1281 Rename locals to avoid shadowing.
3e7d6594 1282
50060332
PE
1283 * sound.c (wav_play, au_play, Fplay_sound_internal):
1284 Fix pointer signedness.
d01f234b 1285 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1286 (wav_play): Initialize a variable to 0, to prevent undefined
1287 behavior (Bug#8278).
50060332 1288
c4fc4e30
PE
1289 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1290
918436ed
PE
1291 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1292
c939f91b
PE
1293 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1294 clobbering (Bug#8298).
b9c7f648
PE
1295 * sysdep.c (sys_subshell): Likewise.
1296 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1297
6bd8c144
PE
1298 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1299 This should get cleaned up, so that child_setup has the
1300 same signature on all platforms.
1301
7710357c 1302 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1303 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1304
c59da222
CY
13052011-03-22 Chong Yidong <cyd@stupidchicken.com>
1306
1307 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1308 not to be necessary, and produces flickering.
1309
66b87493
GM
13102011-03-20 Glenn Morris <rgm@gnu.org>
1311
1312 * config.in: Remove file.
1313
45b6f6d5
JB
13142011-03-20 Juanma Barranquero <lekktu@gmail.com>
1315
1316 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1317 are now in src/globals.h.
1318 (syms_of_minibuf): Remove spurious & from previous change.
1319
3ec03f7e
LL
13202011-03-20 Leo <sdl.web@gmail.com>
1321
1322 * minibuf.c (completing-read-function): New variable.
1323 (completing-read-default): Rename from completing-read.
1324 (completing-read): Call completing-read-function.
1325
b14e3e21
CY
13262011-03-19 Juanma Barranquero <lekktu@gmail.com>
1327
1328 * xfaces.c (Fx_load_color_file):
1329 Read color file from absolute filename (bug#8250).
1330
f2b726e6
JB
13312011-03-19 Juanma Barranquero <lekktu@gmail.com>
1332
1333 * makefile.w32-in: Update dependencies.
1334
09f6ff02
EZ
13352011-03-17 Eli Zaretskii <eliz@gnu.org>
1336
1337 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1338
29a6015a
PE
13392011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1340
a3a6c54e
PE
1341 Fix more problems found by GCC 4.5.2's static checks.
1342
b766f867
PE
1343 * process.c (make_serial_process_unwind, send_process_trap):
1344 (sigchld_handler): Now static.
1345
be02381c
PE
1346 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1347 That way, the code declares only the vars that it needs.
1348 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1349 * s/cygwin.h (PTY_ITERATION): Likewise.
1350 * s/darwin.h (PTY_ITERATION): Likewise.
1351 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1352
57048744
PE
1353 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1354 * process.c (allocate_pty): Don't declare stb unless it's needed.
1355
7914961c 1356 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1357 (CONSTANTLIM): Remove; unused.
1358 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1359 Define only if needed.
7914961c 1360
b3967b18
PE
1361 * unexelf.c (unexec): Name an expression,
1362 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1363 Use a different way to cause a compilation error if anyone uses
1364 n rather than nn, a way that does not involve shadowing.
73366a00 1365 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1366
29a6015a
PE
1367 * deps.mk (unexalpha.o): Remove; unused.
1368
43cfc33e 1369 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1370 * unexec.h: New file.
ce701a33
PE
1371 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1372 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1373 Depend on unexec.h.
1374 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1375 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1376 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1377 Change as necessary to match prototype in unexec.h.
ce701a33 1378
01f44d5a
PE
1379 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1380 shadowing.
4f63c6bb 1381 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1382
a6670b0b
PE
1383 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1384 Rename locals to avoid shadowing.
1385
cef2010d 1386 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1387 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1388
d4d7173a
PE
1389 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1390
f08b802a
PE
1391 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1392 warning when compiling print.c.
1393
3ddb0639
PE
1394 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1395 instead of using an uninitialized var.
5ad03b97 1396 (font_sort_entities): Mark var as initialized.
3ddb0639 1397
170a2692
PE
1398 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1399
e663c700
PE
1400 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1401 pointers to constants.
89bc529a 1402 (font_parse_fcname): Remove unused vars.
7b81e2d0 1403 (font_delete_unmatched): Now static.
ea838e10 1404 (font_get_spec): Remove; unused.
13a547c6
PE
1405 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1406 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1407 Rename or move locals to avoid shadowing.
e663c700 1408
2a80c887 1409 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1410 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1411
1384fa33 1412 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1413 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1414
8b2c52e9
PE
1415 * alloc.c (mark_backtrace): Move decl from here ...
1416 * lisp.h: ... to here, so that it can be checked.
1417
475545b5 1418 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1419 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1420 (lisp_indirect_variable): Name an expression,
1421 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1422 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1423
b1349114 1424 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1425 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1426 Use const pointer when appropriate.
b1349114 1427
a2928364
PE
1428 * lisp.h (get_system_name, get_operating_system_release):
1429 Move decls here, to check interfaces.
1430 * process.c (get_operating_system_release): Move decl to lisp.h.
1431 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1432 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1433 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1434 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1435 (Fformat_time_string, Fencode_time, Finsert_char):
1436 (Ftranslate_region_internal, Fformat):
1437 Rename or remove local vars to avoid shadowing.
9710023e 1438 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1439
a415e694
PE
1440 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1441 avoid shadowing.
1442
8ef4622d
PE
1443 * lisp.h (eassert): Check that the argument compiles, even if
1444 ENABLE_CHECKING is not defined.
1445
946f9a5b
PE
1446 * data.c (Findirect_variable): Name an expression, to avoid
1447 gcc -Wbad-function-cast warning.
112396d6 1448 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1449 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1450 (Fmake_variable_buffer_local, Fmake_local_variable):
1451 Mark variables as initialized.
52746918 1452 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1453
e5aab7e7 1454 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1455 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1456 Rename locals to avoid shadowing.
dff45157
PE
1457 (mark_stack): Move local variables into the #ifdef region where
1458 they're used.
7bc26fdb
PE
1459 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1460 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1461 needed otherwise.
1462 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1463 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1464 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1465
e5aab7e7
PE
1466 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1467 avoids undefined behavior in theory.
1468
4da60324
PE
1469 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1470
88043301
PE
1471 Use functions, not macros, for up- and down-casing (Bug#8254).
1472 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1473 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1474 to use the following functions instead of these macros.
1475 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1476 EMACS_INT, since callers assume the returned value fits in int.
1477 (upcase1): Likewise, for UPCASE_TABLE.
1478 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1479 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1480 the race-condition problem in the old DOWNCASE.
88043301 1481
19ed5445
PE
1482 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1483 Rename locals to avoid shadowing.
1484 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1485 (regex_compile, re_search_2, re_match_2_internal):
1486 Remove unused local vars.
952db0d7
PE
1487 (FREE_VAR): Rewrite so as not to use empty "else",
1488 which gcc can warn about.
da053e48 1489 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1490 (RETALLOC_IF): Define only if needed.
1491 (WORDCHAR_P): Likewise. This one is never needed, but is used
1492 only in a comment talking about a compiler bug, so put inside
1493 the #if 0 of that comment.
1494 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1495 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1496 Remove; unused.
19ed5445 1497
1f3561e4 1498 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1499 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1500 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1501
ded6f8f7
PE
1502 * search.c (simple_search): Remove unused var.
1503
dbd37a95
PE
1504 * dired.c (compile_pattern): Move decl from here ...
1505 * lisp.h: ... to here, so that it can be checked.
1506 (struct re_registers): New forward decl.
1507
7e47afad
PE
1508 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1509
85f24f61
PE
1510 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1511 All uses changed.
1512 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1513 Rename locals to avoid shadowing.
5671df8f 1514 (Fvertical_motion): Mark locals as initialized.
85f24f61 1515
181aa2be 1516 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1517 (casify_region): Mark local as initialized.
181aa2be 1518
930d429c
PE
1519 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1520
7082eac6
PE
1521 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1522 New macros, so that the caller can use some names other than
1523 gcpro1, gcpro2, etc.
1524 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1525 of the new macros.
1526 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1527 argument, for consistency with GCPRO2_VAR, etc: it is now the
1528 prefix of the variable, not the variable itself. All uses
1529 changed.
38b2c076
PE
1530 * dired.c (directory_files_internal, file_name_completion):
1531 Rename locals to avoid shadowing.
1532
15206ed9
PE
1533 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1534 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1535 dired.c's scmp function, had undefined behavior.
1536 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1537 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1538 * buffer.h: ... to here, because these macros use current_buffer,
1539 and the new implementation with inline functions needs to have
1540 current_buffer in scope now, rather than later when the macros
1541 are used.
1542 (downcase, upcase1): New static inline functions.
1543 (DOWNCASE, UPCASE1): Reimplement using these functions.
1544 This avoids undefined behavior in expressions like
1545 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1546 from race conditions in accessing the global variables
1547 case_temp1 and case_temp2.
1548 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1549 * lisp.h (case_temp1, case_temp2): Remove their decls.
1550 * character.h (ASCII_CHAR_P): Move from here ...
1551 * lisp.h: ... to here, so that the inline functions mentioned
1552 above can use them.
1553
4a6bea26
PE
1554 * dired.c (directory_files_internal_unwind): Now static.
1555
f14b7e14
PE
1556 * fileio.c (file_name_as_directory, directory_file_name):
1557 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1558 Now static.
2893f146
PE
1559 (file_name_as_directory): Use const pointers when appropriate.
1560 (Fexpand_file_name): Likewise. In particular, newdir might
1561 point at constant storage, so make it a const pointer.
fd4ead52 1562 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1563 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1564 signedness issues.
f839df0c
PE
1565 (Fset_file_times, Finsert_file_contents, auto_save_error):
1566 Rename locals to avoid shadowing.
f14b7e14 1567
5716756e 1568 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1569 (Ftry_completion, Fall_completions): Rename or remove locals
1570 to avoid shadowing.
5716756e 1571
b4c3046a
PE
1572 * marker.c (bytepos_to_charpos): Remove; unused.
1573
b45db522
PE
1574 * lisp.h (verify_bytepos, count_markers): New decls,
1575 so that gcc does not warn that these functions aren't declared.
1576
85876d07
PE
1577 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1578 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1579 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1580 (copy_text): Remove unused local var.
85876d07 1581
03d78a21 1582 * filelock.c (within_one_second): Now static.
b3dd38ab 1583 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1584
5df8f01b
PE
1585 * buffer.c (fix_overlays_before): Mark locals as initialized.
1586 (fix_start_end_in_overlays): Likewise. This function should be
1587 simplified by using pointers-to-pointers, but that's a different
1588 matter.
b1d876f1 1589 (switch_to_buffer_1): Now static.
8f54f30a
PE
1590 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1591 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1592
a70072c9 1593 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1594 Fix pointer signedness issue.
edced198
PE
1595 (sys_subshell): Mark local as volatile if checking for lint,
1596 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1597 (MAXPATHLEN): Define only if needed.
a70072c9 1598
a0977c44
PE
1599 * process.c (serial_open, serial_configure): Move decls from here ...
1600 * systty.h: ... to here, so that they can be checked.
1601
a884fdcc
PE
1602 * fns.c (get_random, seed_random): Move extern decls from here ...
1603 * lisp.h: ... to here, so that they can be checked.
1604
604efe86 1605 * sysdep.c (reset_io): Now static.
b8950c94 1606 (wait_for_termination_signal): Remove; unused.
604efe86 1607
38fc62d9
PE
1608 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1609 (copy_keymap_item, append_key, push_text_char_description):
1610 Now static.
1004a21a 1611 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1612 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1613 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1614 (describe_map_tree):
1615 Rename locals to avoid shadowing.
38fc62d9 1616
2f2650da
PE
1617 * keyboard.c: Declare functions static if they are not used elsewhere.
1618 (echo_char, echo_dash, cmd_error, top_level_2):
1619 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1620 (read_char, kbd_buffer_get_event, make_lispy_position):
1621 (make_lispy_event, make_lispy_movement, apply_modifiers):
1622 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1623 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1624 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1625 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1626 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1627
a053e86c 1628 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1629 (mark_kboards): Move decl here ...
1630 * alloc.c (mark_kboards): ... from here.
a053e86c 1631
4752793e
PE
1632 * lisp.h (force_auto_save_soon): New decl.
1633
74f10ca7 1634 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1635 (DEFINE_DUMMY_FUNCTION): New macro.
1636 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1637 Use it.
c03cd23f
PE
1638 (main): Add casts to avoid warnings
1639 if GCC considers string literals to be constants.
74f10ca7 1640
022e70d4
PE
1641 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1642
59d6fe83
PE
1643 * dbusbind.c: Pointer signedness fixes.
1644 (xd_signature, xd_append_arg, xd_initialize):
1645 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1646 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1647 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1648 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1649
78320123
PE
1650 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1651 if GCC considers string literals to be constants.
49cebcca 1652 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1653
35ac2a97
SM
16542011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1655
fb103ca9
SM
1656 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1657 (print_preprocess, print_object): New macro to fix last change.
1658
35ac2a97
SM
1659 * print.c (print_preprocess): Don't forget font objects.
1660
62973b41
JB
16612011-03-16 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * emacs.c (USAGE3): Doc fixes.
1664
0e48bb22
AS
16652011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1666
1667 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1668 structure.
1669
7684e57b
JB
16702011-03-14 Juanma Barranquero <lekktu@gmail.com>
1671
1672 * lisp.h (VWindow_system, Qfile_name_history):
1673 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1674 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1675 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1676
1677 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1678 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1679
1680 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1681 * w32console.c (detect_input_pending, read_input_pending)
1682 (encode_terminal_code):
1683 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1684 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1685 (w32_system_caret_y, Qfile_name_history):
1686 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1687 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1688 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1689 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1690 * w32proc.c (Qlocal, report_file_error):
1691 * w32term.c (Vwindow_system, updating_frame):
1692 * w32uniscribe.c (initialized, uniscribe_font_driver):
1693 Remove unneeded extern declarations.
1694
2aa46d6c
CY
16952011-03-14 Chong Yidong <cyd@stupidchicken.com>
1696
c96bbc66 1697 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1698
cffc6f3b
CY
16992011-03-13 Chong Yidong <cyd@stupidchicken.com>
1700
1701 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1702 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1703 These macros can no longer be used for assignment.
1704
44f230aa
SM
1705 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1706 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1707 (record_buffer_markers, fetch_buffer_markers): New functions for
1708 recording and fetching special buffer markers.
1709 (set_buffer_internal_1, set_buffer_temp): Use them.
1710
1711 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1712
1713 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1714
1715 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1716 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1717
1718 * xdisp.c (hscroll_window_tree):
1719 (reconsider_clip_changes): Use PT instead of BUF_PT.
1720
d251f04b
EZ
17212011-03-13 Eli Zaretskii <eliz@gnu.org>
1722
1723 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1724 $(EMACS_ROOT)/lib/intprops.h.
1725
f0c77cd1
PE
17262011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1727
3eca4629
PE
1728 Fix more problems found by GCC 4.5.2's static checks.
1729
7c86ee98
PE
1730 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1731 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1732 (xg_free_frame_widgets): Make it clear that a local variable is
1733 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1734 (gdk_window_get_screen): Make it clear that this macro is needed
1735 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1736 (int_gtk_range_get_value): New function, which avoids a diagnostic
1737 from gcc -Wbad-function-cast.
1738 (xg_set_toolkit_scroll_bar_thumb): Use it.
1739 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1740 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1741 (get_utf8_string, xg_get_file_with_chooser):
1742 Rename locals to avoid shadowing.
1743 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1744
41729b81
PE
1745 * xgselect.c (xg_select): Remove unused var.
1746
f0c77cd1
PE
1747 * image.c (four_corners_best): Mark locals as initialized.
1748 (gif_load): Initialize transparent_p to zero (Bug#8238).
1749 Mark another local as initialized.
ec6cf4c6 1750 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1751
ce0ad53d 1752 * image.c (clear_image_cache): Now static.
d5d5a617 1753 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1754 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1755 (x_edge_detection): Remove unnecessary cast that
1756 gcc -Wbad-function-cast diagnoses.
2037898d 1757 (gif_load): Fix pointer signedness.
6ae141d6
PE
1758 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1759 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1760
33383987 17612011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1762
d32df629
PE
1763 Improve quality of tests for time stamp overflow.
1764 For example, without this patch (encode-time 0 0 0 1 1
1765 1152921504606846976) returns the obviously-bogus value (-948597
1766 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1767 reports time overflow. See
1768 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1769 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1770 * editfns.c: Include limits.h and intprops.h.
1771 (TIME_T_MIN, TIME_T_MAX): New macros.
1772 (time_overflow): Move earlier, to before first use.
1773 (hi_time, lo_time): New functions, for an accurate test for
1774 out-of-range times.
1775 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1776 (Fget_internal_run_time): Don't assume time_t fits in int.
1777 (make_time): Use list2 instead of Fcons twice.
1778 (Fdecode_time): More accurate test for out-of-range times.
1779 (check_tm_member): New function.
1780 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1781 (lisp_time_argument): Don't rely on undefined left-shift and
1782 right-shift behavior when checking for time stamp overflow.
8be6f318 1783
fe31d94c
PE
1784 * editfns.c (time_overflow): New function, refactoring common code.
1785 (Fformat_time_string, Fdecode_time, Fencode_time):
1786 (Fcurrent_time_string): Use it.
1787
8be6f318
PE
1788 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1789 * dired.c (make_time): Move to ...
1790 * editfns.c (make_time): ... here.
1791 * systime.h: Note the move.
1792
09d9db2c 17932011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1794
126bc0dc
YM
1795 * fringe.c (update_window_fringes): Remove unused variables.
1796
c47cbdfd
YM
1797 * unexmacosx.c (copy_data_segment): Also copy __got section.
1798 (Bug#8223)
1799
7ac80be9
EZ
18002011-03-12 Eli Zaretskii <eliz@gnu.org>
1801
c96bbc66 1802 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1803 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1804 Constify `char *' arguments and their references according to
1805 prototypes in tparam.h.
1806
ecb0f94d 1807 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1808
7ac80be9
EZ
1809 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1810 Adapt all references accordingly.
1811
1812 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1813
ef1fd07e
TT
18142011-03-11 Tom Tromey <tromey@redhat.com>
1815
1816 * buffer.c (syms_of_buffer): Remove obsolete comment.
1817
7ef4b50c
EZ
18182011-03-11 Eli Zaretskii <eliz@gnu.org>
1819
1820 * termhooks.h (encode_terminal_code): Declare prototype.
1821
1822 * msdos.c (encode_terminal_code): Don't declare prototype.
1823
1824 * term.c (encode_terminal_code): Now external again, used by
1825 w32console.c and msdos.c.
1826
44f230aa
SM
1827 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1828 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1829
4b1ec863 18302011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1831
1714f52b 1832 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1833
4b1ec863
PE
1834 * fringe.c (update_window_fringes): Mark locals as initialized
1835 (Bug#8227).
1836 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1837
524c7aa6
PE
1838 * alloc.c (mark_fringe_data): Move decl from here ...
1839 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1840 to check its interface.
1841 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1842
a5c0af81 1843 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1844 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1845 (fontset_font): Mark local as initialized.
a9a06e0b 1846 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1847
b4716021
PE
1848 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1849
811e9bac 1850 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1851 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1852 (x_own_selection, Fx_disown_selection_internal): Rename locals
1853 to avoid shadowing.
1854 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1855
7e3ab302
PE
1856 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1857 so that the caller can use some name other than gcpro1.
1858 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1859 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1860 (Fx_backspace_delete_keys_p):
1861 Use them to avoid shadowing, and rename vars to avoid shadowing.
1862 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1863 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1864 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1865 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1866 Remove unused locals.
7e3ab302
PE
1867 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1868 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1869 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1870 macros.
f78faa98 1871
e2b13473
PE
1872 * xterm.h (x_mouse_leave): New decl.
1873
77f23912
PE
1874 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1875 Remove unused functions.
cdf4ba58
PE
1876 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1877 (x_calc_absolute_position): Now static.
7411c686 1878 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1879 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1880 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1881 unless they are used.
38d0b34a
PE
1882 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1883 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1884 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1885 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1886 (x_error_catcher, x_connection_closed, x_error_handler):
1887 (x_error_quitter, xembed_send_message, x_iconify_frame):
1888 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1889 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1890 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1891
44f230aa
SM
1892 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1893 Rename or move locals to avoid shadowing.
6b463e58 1894 (tty_defined_color, merge_face_heights): Now static.
5967d051 1895 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1896 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1897 does not deduce is never used uninitialized.
73719eba
PE
1898 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1899 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1900
426994c3 1901 * terminal.c (store_terminal_param): Now static.
5489860b 1902
032f1620 1903 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1904 (set_frame_menubar): Remove unused local.
d4323972 1905 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1906 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1907 since they might point to immutable storage.
281585b0
PE
1908 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1909 since it's unused otherwise.
032f1620 1910
367c19e5 1911 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1912 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1913 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1914 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1915 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1916 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1917 does not deduce are never used uninitialized.
70739cbe 1918
07b48fa9
PE
1919 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1920
8868a238 1921 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1922 * window.c (window_loop, size_window):
1923 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1924
7e5cf297 1925 * window.c (display_buffer): Now static.
d6550a9f
PE
1926 (size_window): Mark variables that gcc -Wuninitialized
1927 does not deduce are never used uninitialized.
a586633d
PE
1928 * window.h (check_all_windows): New decl, to forestall
1929 gcc -Wmissing-prototypes diagnostic.
5b555da1 1930 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1931
f6095868
PE
1932 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1933 shadowing.
1934 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1935 Include <limits.h>.
1936 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1937 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1938 (load_charset_map): Mark variables that gcc -Wuninitialized
1939 does not deduce are never used uninitialized.
53df7c11 1940 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1941
f38b440c
PE
1942 * coding.c (coding_set_source, coding_set_destination):
1943 Use "else { /* comment */ }" rather than "else /* comment */;"
1944 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1945 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1946 a block, when the outer 'i' will do.
1947 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1948 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1949 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1950 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1951 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1952 Rename locals to avoid shadowing.
1953 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1954 * coding.c (emacs_mule_char, encode_invocation_designation):
1955 Now static, since they're not used elsewhere.
413bb2db 1956 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1957 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1958 (decode_coding_emacs_mule): Mark variables that gcc
1959 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1960 (detect_coding_iso_2022): Initialize a local variable that might
1961 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1962 this initialization is needed. (Bug#8211)
5f58e762
PE
1963 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1964 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1965 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1966 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1967 Remove unused macros.
f38b440c 1968
232b38b9 1969 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1970 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1971 * character.c (string_count_byte8): Likewise.
232b38b9 1972
fb90da1b
PE
1973 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1974 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1975
fb93dbc2
PE
1976 * chartab.c (copy_sub_char_table): Now static, since it's not used
1977 elsewhere.
5c156ace
PE
1978 (sub_char_table_ref_and_range, char_table_ref_and_range):
1979 Rename locals to avoid shadowing.
bbcd0949 1980 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1981
7d3b3862 1982 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1983 (BIDI_BOB): Remove unused macro.
7d3b3862 1984
6be7d3da
PE
1985 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1986 deduce are never used uninitialized.
c2ed9c8b 1987 * term.c (encode_terminal_code): Likewise.
6be7d3da 1988
75f8807f 1989 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1990
50938595
PE
1991 * tparam.h: New file.
1992 * term.c, tparam.h: Include it.
1993 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1994 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1995 Move these decls to tparam.h, and make them agree with what
1996 is actually in tparam.c. The previous trick of using incompatible
1997 decls in different modules does not conform to the C standard.
1998 All callers of tparam changed to use tparam's actual API.
1999 * tparam.c (tparam1, tparam, tgoto):
2000 Use const pointers where appropriate.
2001
fbceeba2
PE
2002 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2003 * cm.h (struct cm): Likewise.
2004 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2005 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2006 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2007 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2008 (turn_on_face, init_tty): Likewise.
2009 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2010
7f3f1250
PE
2011 * term.c (term_mouse_position): Rename local to avoid shadowing.
2012
e6ca6543
PE
2013 * alloc.c (mark_ttys): Move decl from here ...
2014 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2015
c40f8d15
AS
20162011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2017
2018 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2019
cfe0661d
JB
20202011-03-09 Juanma Barranquero <lekktu@gmail.com>
2021
2022 * search.c (compile_pattern_1): Remove argument regp, unused since
2023 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2024 (compile_pattern): Don't pass it.
2025
0afb4571
J
20262011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2027
2028 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2029 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2030 for ! HAVE_GTK3.
2031 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2032
2033 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2034
2035 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2036 gdk_window_get_screen, gdk_window_get_geometry,
2037 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2038 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2039 (xg_get_pixbuf_from_pixmap): New function.
2040 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2041 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2042 Call xg_get_pixbuf_from_pixmap instead of
2043 gdk_pixbuf_get_from_drawable.
2044 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2045 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2046 (xg_check_special_colors): Use GtkStyleContext and its functions
2047 for HAVE_GTK3.
2048 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2049 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2050 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2051 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2052 Call gtk_widget_get_preferred_size.
0afb4571
J
2053 (xg_frame_resized): gdk_window_get_geometry only takes 5
2054 parameters.
44f230aa
SM
2055 (xg_win_to_widget, xg_event_is_for_menubar):
2056 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2057 (xg_set_widget_bg): New function.
2058 (delete_cb): New function.
2059 (xg_create_frame_widgets): connect delete-event to delete_cb.
2060 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2061 (xg_set_background_color): Call xg_set_widget_bg.
2062 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2063 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2064 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2065 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2066 if ! HAVE_GTK3.
2067 (update_frame_tool_bar): Call gtk_widget_hide.
2068 (xg_initialize): Use GDK_KEY_g.
2069
2070 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2071 if ! HAVE_GTK3
2072 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2073
2074 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2075 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2076 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2077
1c2cc4ef
JB
20782011-03-08 Juanma Barranquero <lekktu@gmail.com>
2079
2080 * w32xfns.c (select_palette): Check success of RealizePalette against
2081 GDI_ERROR, not zero.
2082
33383987 2083See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2084
2085;; Local Variables:
2086;; coding: utf-8
aac0c6e3
MR
2087;; End:
2088
33383987 2089 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2090
2091 This file is part of GNU Emacs.
2092
2093 GNU Emacs is free software: you can redistribute it and/or modify
2094 it under the terms of the GNU General Public License as published by
2095 the Free Software Foundation, either version 3 of the License, or
2096 (at your option) any later version.
2097
2098 GNU Emacs is distributed in the hope that it will be useful,
2099 but WITHOUT ANY WARRANTY; without even the implied warranty of
2100 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2101 GNU General Public License for more details.
2102
2103 You should have received a copy of the GNU General Public License
2104 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.