Cleanup calls to Fgarbage_collect.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
765e61e3
DA
12012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Cleanup calls to Fgarbage_collect.
4 * lisp.h (maybe_gc): New prototype.
5 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
6 Remove declarations.
7 * alloc.c (maybe_gc): New function.
8 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
9 Make them static.
10 * bytecode.c (MAYBE_GC): Use maybe_gc.
11 * eval.c (eval_sub, Ffuncall): Likewise.
12 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
13 to avoid dependency from auto-save feature.
14
52b852c7
PE
152012-07-19 Paul Eggert <eggert@cs.ucla.edu>
16
17 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
18 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
19 'for_each_per_buffer_object_at'.
20 All uses changed. It's better to use upper-case for macros that
21 cannot be implemented as functions, to give the reader a clue
22 that they're special.
23
5db81e33
SM
242012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
25
26 * alloc.c (Fgarbage_collect): Tweak docstring.
27
5b835e1d
DA
282012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Tweak the value returned from Fgarbage_collect again.
31 * alloc.c (Fgarbage_collect): New return value, as confirmed in
32 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
33 Adjust documentation.
34 (total_vector_bytes): Rename to total_vector_slots, adjust
35 accounting.
36 (total_free_vector_bytes): Rename to total_free_vector_slots,
37 adjust accounting.
38 (Qstring_bytes, Qvector_slots): New symbols.
39 (syms_of_alloc): DEFSYM them.
40
9cd47b72
DA
412012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
42
43 Buffer compaction primitive which may be used from Lisp.
44 * buffer.c (compact_buffer, Fcompact_buffer): New function.
45 (syms_of_buffer): Register Fcompact_buffer.
46 * alloc.c (Fgarbage_collect): Use compact_buffer.
47 * buffer.h (compact_buffer): New prototype.
48 (struct buffer_text): New member.
49
d17337e5
DA
502012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
51
52 New macro to iterate over all buffers, miscellaneous cleanups.
53 * lisp.h (all_buffers): Remove declaration.
54 * buffer.h (all_buffers): Add declaration, with comment.
55 (for_each_buffer): New macro.
56 * alloc.c (Fgarbage_collect, mark_object): Use it.
57 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
58 (init_buffer): Likewise.
59 * data.c (Fset_default): Likewise.
60 * coding.c (code_conversion_restore): Remove redundant check
61 for dead buffer.
62 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
63
60cfd278
AS
642012-07-18 Andreas Schwab <schwab@linux-m68k.org>
65
66 Fix bug that created negative-length intervals.
67 * intervals.c (merge_interval_right, merge_interval_left):
68 Do not zero out this interval if it is absorbed by its children,
69 as this interval's total length doesn't change in that case. See
70 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
71
d06714cb
PE
722012-07-18 Paul Eggert <eggert@cs.ucla.edu>
73
83713154
PE
74 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
75 when invoking (make-bool-vector N t) and N is a positive
76 multiple of 8 -- the last 8 bits were mistakenly cleared.
77
d06714cb
PE
78 Remove some struct layout assumptions in bool vectors.
79 * alloc.c (bool_header_size): New constant.
80 (header_size, word_size): Move earlier, as they're now used earlier.
81 Use 'word_size' in a few more places, where it's appropriate.
82 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
83 padding before the data member of a bool vector.
84 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
85 than doing the check by hand with an abort ().
86
464d5a5e
SM
872012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
88
5fbc0409
SM
89 * eval.c (Fdefvar): Don't check constants since we only set the var if
90 it's not yet defined anyway (bug#11904).
91
464d5a5e
SM
92 * lisp.h (last_undo_boundary): Declare new var.
93 * keyboard.c (command_loop_1): Set it.
94 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
95 were auto-added by the command loop (bug#11774).
96
8dc2e44a
AS
972012-07-18 Andreas Schwab <schwab@linux-m68k.org>
98
99 * w32font.c (Qsymbol): Remove local definition.
100 (syms_of_w32font): Don't DEFSYM it.
101
169925ec
DA
1022012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
103
104 Fix sweep_vectors to handle large bool vectors correctly.
105 * alloc.c (sweep_vectors): Account total_vector_bytes for
106 bool vectors larger than VBLOCK_BYTES_MAX.
107
5fbfb018
CY
1082012-07-18 Chong Yidong <cyd@gnu.org>
109
110 * frame.c (x_set_frame_parameters): Revert bogus change introduced
111 in 2012-05-25 commit by Paul Eggert (Bug#11738).
112
3ab6e069
DA
1132012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
114
115 Return more descriptive data from Fgarbage_collect.
116 Suggested by Stefan Monnier in
117 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
118 * alloc.c (bounded_number): New function.
119 (total_buffers, total_vectors): New variable.
120 (total_string_size): Rename to total_string_bytes, adjust users.
121 (total_vector_size): Rename to total_vector_bytes, adjust users.
122 (sweep_vectors): Account total_vectors and total_vector_bytes.
123 (Fgarbage_collect): New return value. Adjust documentation.
124 (gc_sweep): Account total_buffers.
125 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
126 (VECTOR_SIZE): Remove.
127 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
128 (Qinterval, Qmisc): New symbols.
129 (syms_of_data): Initialize them.
130 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
131 (Qcons, Qbuffer): New declarations.
132
6d02fe5b
PE
1332012-07-17 Paul Eggert <eggert@cs.ucla.edu>
134
135 * alloc.c (Fmemory_free): Account for memory-free's own storage.
136 Round up, not down. Improve doc.
137
b7ffe040
DA
1382012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
139
140 Restore old code in allocate_string_data to avoid Faset breakage.
141 Reported by Julien Danjou <julien@danjou.info> in
142 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
143 * alloc.c (allocate_string_data): Restore old code with minor
144 adjustments, fix comment to explain this subtle issue.
145
4dc7c8d5
SM
1462012-07-17 Eli Zaretskii <eliz@gnu.org>
147
148 Remove FILE_SYSTEM_CASE.
149 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
150
151 * fileio.c (FILE_SYSTEM_CASE): Don't define.
152 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
153 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
154 call-process-region passes it through expand-file-name.
155
156 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
157
1582012-07-17 Andreas Schwab <schwab@linux-m68k.org>
159
160 Fix crash when creating indirect buffer (Bug#11917)
161 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
162 Don't handle unbound variables specially if non-zero.
163 (Fbuffer_local_variables): Pass zero.
164 (clone_per_buffer_values): Pass non-zero.
165
1662012-07-17 Andreas Schwab <schwab@linux-m68k.org>
167
168 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
169 to make the loop interruptible.
170
1712012-07-17 Andreas Schwab <schwab@linux-m68k.org>
172
173 * gnutls.c (emacs_gnutls_handshake): Only retry if
174 GNUTLS_E_INTERRUPTED.
175
cce7fefc
DA
1762012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
177
178 Cleanup and convert miscellaneous checks to eassert.
179 * alloc.c (mark_interval): Fix comment, partially rephrase
180 old comment from intervals.h (see below).
181 * intervals.c (find_interval, adjust_intervals_for_insertion)
182 (delete_interval, adjust_intervals_for_deletion)
183 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
184 Convert to eassert.
185 (adjust_intervals_for_insertion, make_new_interval):
186 Remove obsolete and unused code.
187 * intervals.h (struct interval): Remove obsolete comment.
188 * textprotp.c (erase_properties): Remove unused code.
189 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
190 (Fremove_list_of_text_properties): Convert to eassert.
191
9ea10cc3
CY
1922012-07-17 Chong Yidong <cyd@gnu.org>
193
194 * editfns.c (Finsert_char): Doc fix.
195
3900d5de
DA
1962012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
197
198 Fix previous change to make Fmemory_free always accurate.
199 * alloc.c (make_interval): Update total_free_intervals.
200 (make_float): Likewise for total_free_floats.
201 (free_cons, Fcons): Likewise for total_free_conses.
202 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
203 Likewise for total_free_vector_bytes.
204 (Fmake_symbol): Likewise for total_free_symbols.
205 (bytes_free): Remove.
206
7098646f
DA
2072012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
208
209 Simple free memory accounting feature.
210 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
211 (sweep_vectors): Accumulate size of free vectors.
212 (Fgarbage_collect): Setup bytes_free.
213 (Fmemory_free): New function.
214 (syms_of_alloc): Register it.
215
22657b40
DA
2162012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
217
218 Cleanup overlays checking.
219 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
220 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
221 eassert and OVERLAYP.
222 (sort_overlays): Change to use OVERLAYP.
223
ddfc8813
RK
2242012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
225
226 * editfns.c (Finsert_char): Make it interactive, and make the
227 second arg optional. Copy interactive spec and docstring from
228 ucs-insert.
229
7c26cf3c
PE
2302012-07-17 Paul Eggert <eggert@cs.ucla.edu>
231
232 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
233 Unlike the other wrapped functions, fabs has an unspecified
234 effect on errno.
235
5d127af9
JD
2362012-07-16 Jan Djärv <jan.h.d@swipnet.se>
237
238 * nsterm.m (keyDown): Interpret flags without left/right bits
239 as the left key (Bug#11670).
240
6a0dd1d7
DA
2412012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
242
243 Remove empty and useless init functions.
244 * lisp.h (init_character_once, init_fns, init_image)
245 (init_filelock, init_sound): Remove prototype.
246 * character.c (init_character_once): Remove.
247 * filelock.c (init_filelock): Likewise.
248 * fns.c (init_fns): Likewise.
249 * image.c (init_image): Likewise.
250 * sound.c (init_sound): Likewise.
251 * emacs.c (main): Adjust accordingly.
252
7a6136fd
DA
2532012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
254
255 * gtkutil.h: Tiny cleanups.
256 (use_old_gtk_file_dialog): Remove useless declaration.
257 (xg_uses_old_file_dialog): Add suggested const attribute.
258
ce811ad9
EZ
2592012-07-15 Eli Zaretskii <eliz@gnu.org>
260
261 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
262 (bidi_paragraph_init): Use it to limit search forward for a strong
263 directional character in abnormally large paragraphs full of
264 neutral or weak characters. (Bug#11943)
265
c9adfeaa
SF
2662012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
267
268 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
269 the toolbar (Bug#9451).
270 (xg_make_tool_item): Give the widget event box a transparent
271 background.
272
fff62aa9
DA
2732012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
274
275 Cleanup basic allocation variables and functions.
276 * alloc.c (ignore_warnings, init_intervals, init_float)
277 (init_cons, init_symbol, init_marker): Remove.
278 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
279 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
280 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
281 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
282 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
283 (staticidx, init_alloc_once, init_strings, free_ablock):
284 Remove redundant initialization.
285 * fns.c (init_weak_hash_tables): Remove.
286 * lisp.h (init_weak_hash_tables): Remove prototype.
287
9730daca
DA
2882012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
289
290 Use zero_vector where appropriate.
291 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
292 accordingly.
293 * lisp.h (zero_vector): New declaration.
294 * font.c (null_vector): Remove.
295 (syms_of_font): Remove initialization and staticpro.
296 (font_list_entities, font_find_for_lface): Change to use zero_vector.
297 * keymap.c (Faccessible_keymaps): Likewise.
298
2e2d2a13
LL
2992012-07-15 Leo Liu <sdl.web@gmail.com>
300
301 * fringe.c: Fix typo in comments.
302
cd276f6e
LL
3032012-07-14 Leo Liu <sdl.web@gmail.com>
304
305 * fringe.c: Add a new bitmap exclamation-mark.
306
5a1131d9
EZ
3072012-07-14 Eli Zaretskii <eliz@gnu.org>
308
309 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
310
311 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
312 (HAVE_MENUS): Don't define, defined by editing config.in with
313 msdos/sed2v2.inp.
314 (GMALLOC_INHIBIT_VALLOC): Don't define.
315 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
316
22e983b7
JB
3172012-07-14 Juanma Barranquero <lekktu@gmail.com>
318
319 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
320
5b3f250f
GM
3212012-07-14 Glenn Morris <rgm@gnu.org>
322
323 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
324 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
325 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
326
33d63ff4
GM
3272012-07-13 Glenn Morris <rgm@gnu.org>
328
5b633342
GM
329 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
330
33d63ff4
GM
331 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
332 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
333
b55b9f85
JD
3342012-07-13 Jan Djärv <jan.h.d@swipnet.se>
335
0dc8cf50
JD
336 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
337 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
338 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
339 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
340 where appropriate.
341 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
342 as boolean expression.
343 (x_set_window_size): Remove unused variable toolbar.
344 (ns_get_color_default, ns_mod_to_lisp): Remove.
345 (ns_mouse_position): Remove unused variables xchar and ychar.
346 (ns_compute_glyph_string_overhangs): Remove unused variable face.
347 (ns_set_vertical_scroll_bar): Remove unused variable count.
348 (ns_delete_terminal): Remove unused variable i.
349 (ns_term_init): Remove unused variables r, g and b.
350 (mouseDown): Remove unused variable window.
351 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
352 (initFrameFromEmacs): Remove unused variable vbextra.
353 (mouseEntered): Remove unused variables p and dpyinfo.
354 (mouseExited): Remove unused variables p and r.
355 (ns_define_frame_cursor, ns_clear_frame_area)
356 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
357 (menuDown): Assign [sender tag] to variable and cast the variable.
358
359 * nsterm.h (menuDown): Add id as type to argument sender.
360 (ns_display_info_for_name): Add Lisp_Object argument.
361 (ns_term_init): Add Lisp_Object argument.
362 (ns_map_event_to_object): Add void argument.
363 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
364 prototype with arguments and only declare if __OBJC__.
365 (nxatoms_of_nsselect): Add void argument.
366 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
367 (ns_alloc_autorelease_pool): Add void argument.
368 (ns_release_autorelease_pool): Add void* argument.
369 (ns_get_defaults_value): Add const char* argument.
370
371 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
372 (initFromContents): Use SSDATA where appropriate.
373 (ns_update_menubar): Add braces to ambigous if-else.
374 (initWithTitle): Put () around assignment in if statement.
375 (ns_menu_show): Remove unused variables window and keymap.
376 (update_frame_tool_bar): Remove unused variable selected_p.
377 (initWithContentRect): Remove unused variable this_cmd_name.
378
379 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
380 appropriate.
381 (setXBMColor): Remove unused variable len.
382 (setPixmapData): Put () around assignment in loop statement.
383
384 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
385 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
386 where appropriate.
387 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
388 around assignment in loop statement.
389 (nsfont_open): Remove unused variable i.
390 (nsfont_open): Remove unused variable len.
391 (nsfont_draw): Remove unused variable cs.
392
393 * nsfns.m (x_set_icon_name, ns_set_name_internal)
394 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
395 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
396 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
397 (Fns_font_name, Fns_perform_service)
398 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
399 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
400 (ns_set_name): Remove unused variable view.
401 (x_set_menu_bar_lines): Remove unused variable olines.
402 (x_set_tool_bar_lines): Remove unused variable root_window.
403 (Fns_list_colors): Put () around assignment in while statement.
404 (Fns_perform_service): Remove unused variable len.
405 (Fns_display_usable_bounds): Remove unused variable top.
406 (syms_of_nsfns): Remove unused variable i.
407
b55b9f85
JD
408 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
409 memcpy (Bug#11907).
410
ed9265fc 4112012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
412
413 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
414 and free it with DestroyExceptionInfo (Bug#11558).
415
ef099b57
JB
4162012-07-13 Juanma Barranquero <lekktu@gmail.com>
417
418 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
419 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
420 Set here, not in nt/config.nt.
421
ea814a5d
EZ
4222012-07-13 Eli Zaretskii <eliz@gnu.org>
423
424 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
425 cursor overflow into the last glyph on display line when the right
426 fringe is off. (Bug#11832)
427
1a952767
PE
4282012-07-13 Paul Eggert <eggert@cs.ucla.edu>
429
430 * xdisp.c (produce_special_glyphs): Now static.
431 * dispextern.h (produce_special_glyphs): Remove decl.
432
983188fd
GM
4332012-07-13 Glenn Morris <rgm@gnu.org>
434
32fb4bb6
GM
435 * s/bsd-common, s/cygwin.h: Remove empty files.
436 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
437
983188fd
GM
438 * s/usg5-4-common.h (USG, USG5):
439 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
440 * s/sol2-6.h (SOLARIS2):
441 * s/irix6-5.h (IRIX6_5):
442 * s/hpux10-20.h (USG, USG5, HPUX):
443 * s/gnu-linux.h (USG, GNU_LINUX):
444 * s/freebsd.h (BSD_SYSTEM):
445 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
446 * s/cygwin.h (CYGWIN):
447 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
448 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
449
d1e68667 4502012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
451
452 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 453
6de0e799
GM
4542012-07-13 Glenn Morris <rgm@gnu.org>
455
739ae010
GM
456 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
457
dbee5793
GM
458 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
459
6de0e799
GM
460 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
461 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
462
b82da769
GM
4632012-07-12 Glenn Morris <rgm@gnu.org>
464
4fae5a7a 465 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
466
467 * process.c (init_process_emacs): Rename from init_process.
468 The old name is also the name of a Mach system call.
469 * lisp.h, emacs.c: Update for this name change.
470 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
471 longer needed.
472
5a979817
EZ
4732012-07-12 Eli Zaretskii <eliz@gnu.org>
474
475 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
476 memmove call that removes glyphs covered by the left truncation
477 glyph. Improve commentary.
478 (display_line): Fix display of continuation glyphs on GUI frames
479 when the right fringe is turned off and variable-size fonts are
480 used in the window. Move the code that appends a stretch glyph to
481 produce_special_glyphs, so that it could be used for truncation
482 and continuation glyphs alike.
483 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
484 glyph of a suitably computed width, to align the special glyphs at
485 the window margin. Code moved from display_line. (Bug#11832)
486
3e91a053
GM
4872012-07-12 Glenn Morris <rgm@gnu.org>
488
ba9e4b84
GM
489 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
490
491 * s/gnu-linux.h, s/hpux10-20.h:
492 Do not unconditionally define HAVE_XRMSETDATABASE.
493
3e91a053
GM
494 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
495
b300b1f4
PE
4962012-07-12 Paul Eggert <eggert@cs.ucla.edu>
497
498 Fix typos that broke OS X build.
499 Reported by Randal L. Schwartz in
500 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
501 * nsterm.m (ns_timeout): Add missing local decl.
502 (ns_get_color): snprintf -> sprintf, to fix typo.
503
6e777848
GM
5042012-07-12 Glenn Morris <rgm@gnu.org>
505
3f922c37
GM
506 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
507 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
508 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
509 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
510
0ab7b23a
GM
511 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
512 Move PTY_OPEN to configure.
513
6e777848
GM
514 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
515 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
516 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
517
4a7edc24
DA
5182012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Use empty_unibyte_string where applicable.
521 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
522 * lread.c (read1): Likewise.
523 * xsettings.c (syms_of_xsettings): Likewise.
524
308aab79
GM
5252012-07-12 Glenn Morris <rgm@gnu.org>
526
42bd1719
GM
527 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
528 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
529 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
530 * s/hpux10-20.h (RUN_TIME_REMAP):
531 * s/bsd-common.h (TABDLY): Move to configure.
532
533 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
534
535 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
536
ea0bbd17 537 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 538 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
539
540 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 541
308aab79
GM
542 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
543 * s/template.h: Move NARROWPROTO to configure.
544
ee1cf5cf
GM
5452012-07-11 Glenn Morris <rgm@gnu.org>
546
30fe9bf4
GM
547 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
548 unused since 2011-01-17 change to systty.h.
549
ee1cf5cf
GM
550 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
551 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
552 Move HAVE_PTYS and HAVE_SOCKETS to configure.
553
63e47e07
PE
5542012-07-11 Paul Eggert <eggert@cs.ucla.edu>
555
556 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
557
c43fb4c3
GM
5582012-07-11 Glenn Morris <rgm@gnu.org>
559
560 * s/darwin.h, s/gnu-linux.h, s/template.h:
561 Move INTERRUPT_INPUT to configure.
562
e8df9267
DA
5632012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
564
565 Minor adjustments to interning code.
566 * lisp.h (intern, intern_c_string): Redefine as static inline
567 wrappers for intern_1 and intern_c_string_1, respectively.
568 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
569 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
570 Vobarray checking.
e8df9267
DA
571 * font.c (font_intern_prop): Likewise. Adjust comment.
572 * w32font.c (intern_font_name): Likewise.
573
34348bd4
AS
5742012-07-11 Andreas Schwab <schwab@linux-m68k.org>
575
d96a1e0c
AS
576 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
577
34348bd4
AS
578 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
579 of Fcar/Fcdr if possible.
580 * font.c (check_otf_features): Likewise.
581 * fontset.c (Fnew_fontset): Likewise.
582 * gnutls.c (Fgnutls_boot): Likewise.
583 * minibuf.c (read_minibuf): Likewise.
584 * msdos.c (IT_set_frame_parameters): Likewise.
585 * xmenu.c (Fx_popup_dialog): Likewise.
586 * w32menu.c (Fx_popup_dialog): Likewise.
587
c8add24e
GM
5882012-07-11 Glenn Morris <rgm@gnu.org>
589
4b575b3c
GM
590 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
591 since nothing has defined it on these platforms.
592
09f4e3b0
GM
593 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
594 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
595
172bedef
GM
596 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
597 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
598 Move CLASH_DETECTION to configure.
599
249685df
GM
600 * s/gnu.h: Remove file, which is now empty.
601
c8add24e
GM
602 * s/gnu.h, s/gnu-linux.h:
603 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
604
b41253a3
JW
6052012-07-11 John Wiegley <johnw@newartisans.com>
606
607 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
608 function attribute, so we only use it if it exists in the
609 compiler.
610
d923b542
DA
6112012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
612
613 Avoid call to strlen in fast_c_string_match_ignore_case.
614 * search.c (fast_c_string_match_ignore_case): Change to use
615 length argument. Adjust users accordingly.
616 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
617
5ebbef1d
PE
6182012-07-11 Paul Eggert <eggert@cs.ucla.edu>
619
bb352260
PE
620 Assume mkdir, rmdir.
621 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
622 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
623
57054ddd
PE
624 Assume rename.
625 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
626
b747d3f7
PE
627 Assume perror.
628 * s/hpux10-20.h (HAVE_PERROR): Remove.
629 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
630 Remove dummy definition, as this problem was obsolete long ago.
631
5ebbef1d
PE
632 Assume strerror.
633 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
634
984e7f30
DA
6352012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
636
637 Avoid calls to strlen in font processing functions.
638 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 639 (font_open_by_name): Change to use length argument. Adjust
984e7f30 640 users accordingly.
d923b542
DA
641 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
642 Adjust prototypes.
643 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
644 Change to return ptrdiff_t.
984e7f30
DA
645 (xfont_list_pattern, xfont_match): Use length returned by
646 xfont_decode_coding_xlfd.
647 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
648
20e94fdd
GM
6492012-07-11 Glenn Morris <rgm@gnu.org>
650
9d596af3
GM
651 * s/darwin.h, s/freebsd.h, s/netbsd.h:
652 Move DONT_REOPEN_PTY to configure.
653
20e94fdd
GM
654 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
655 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
656
e99a530f
PE
6572012-07-10 Paul Eggert <eggert@cs.ucla.edu>
658
22ffb973
PE
659 Remove "#define unix" that is no longer needed (Bug#11905).
660 * s/aix4-2.h (unix): Remove; no longer needed.
661
e9a9ae03
PE
662 EMACS_TIME simplification (Bug#11875).
663 This replaces macros (which typically do not work in GDB)
664 with functions, typedefs and enums, making the code easier to debug.
665 The functional style also makes code easier to read and maintain.
666 * systime.h: Include <sys/time.h> on all hosts, not just if
667 WINDOWSNT, since 'struct timeval' is needed in general.
668 (EMACS_TIME): Now a typedef, not a macro.
669 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
670 not macros.
671 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
672 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
673 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
674 (EMACS_TIME_LE): Now functions, not macros.
675 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
676 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
677 which are not functions. All uses rewritten to use:
678 (make_emacs_time): New function.
679 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
680 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
681 not functions. All uses rewritten to use the following, respectively:
682 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
683 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 684 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
685 * fileio.c (Fcopy_file):
686 * xterm.c (XTflash): Get the current time closer to when it's used.
687 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
688
ffacb126
PE
689 * bytecode.c (targets): Suppress -Woverride-init warnings.
690
e99a530f
PE
691 Simplify by avoiding confusing use of strncpy etc.
692 * doc.c (Fsnarf_documentation):
693 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
694 * frame.c (Fmake_terminal_frame):
695 * gtkutil.c (get_utf8_string):
696 * lread.c (openp):
697 * nsmenu.m (ns_update_menubar):
698 * regex.c (regerror):
699 Prefer memcpy to strncpy and strncat when either will do.
700 * fileio.c (Fsubstitute_in_file_name):
701 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
702 (menu_separator_name_p):
703 * nsmenu.m (ns_update_menubar):
704 Prefer memcmp to strncmp when either will do.
705 * nsterm.m: Include <ftoastr.h>.
706 (ns_get_color):
707 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
708 Prefer snprintf to strncpy.
709 * nsterm.m (ns_term_init):
710 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
711 * nsterm.m (ns_term_init):
712 Avoid the need for strncpy, by using build_string or
713 make_unibyte_string directly. Use dtoastr, not snprintf.
714 * process.c (Fmake_network_process): Diagnose service names that
715 are too long, rather than silently truncating them or creating
716 non-null-terminated names.
717 (Fnetwork_interface_info): Likewise, for interface names.
718 * sysdep.c (system_process_attributes) [GNU_LINUX]:
719 Prefer sprintf to strncat.
720 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
721 Prefer vsnprintf to vsprintf + strncpy.
722
c59592b3
GM
7232012-07-10 Glenn Morris <rgm@gnu.org>
724
725 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
726 Clarify fallback case.
727
7d7bbefd
DA
7282012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
731 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
732 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 733 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
734 where argument type is known to be a Lisp_Cons.
735
3a4c8000
TT
7362012-07-10 Tom Tromey <tromey@redhat.com>
737
738 * bytecode.c (BYTE_CODE_THREADED): New macro.
739 (BYTE_CODES): New macro. Replaces all old byte-code defines.
740 (enum byte_code_op): New type.
741 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
742 (exec_byte_code): Use them. Use token threading when applicable.
743
2a0213a6
DA
7442012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
745
746 Optimize pure C strings initialization.
747 * lisp.h (make_pure_string): Fix prototype.
748 (build_pure_c_string): New function, defined as static inline. This
749 provides a better opportunity to optimize away calls to strlen when
750 the function is called with compile-time constant argument.
751 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
752 argument, adjust users accordingly. Use build_pure_c_string where
753 appropriate.
754 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
755 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
756 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
757
cb1caeaf
DA
7582012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Avoid calls to strlen in miscellaneous functions.
761 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
762 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
763 * lread.c (openp): Likewise.
764
c293e30c
DA
7652012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
766
767 Avoid calls to strlen in path processing functions.
768 * fileio.c (file_name_as_directory): Add comment. Change to add
769 srclen argument and return the length of result. Adjust users
770 accordingly.
771 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 772 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
773 users accordingly.
774 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
775
9e059e3f
GM
7762012-07-10 Glenn Morris <rgm@gnu.org>
777
d02eb359
GM
778 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
779 Move PENDING_OUTPUT_COUNT definition to configure.
780
882cf227
GM
781 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
782 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
783 * s/gnu.h (DATA_START): Move definitions to configure.
784
af6e839f
GM
785 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
786 We include usg5-4-common.h, which defines them both.
787
40289a12
GM
788 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
789 O_RDONLY already includes it).
790
9e059e3f
GM
791 Stop ns builds setting the EMACSLOADPATH environment variable.
792 * nsterm.m (ns_load_path): Rename from ns_init_paths.
793 Now it does not set EMACSLOADPATH, just returns the load-path string.
794 * nsterm.h: Update accordingly.
795 * lread.c [HAVE_NS]: Include nsterm.h.
796 (init_lread) [HAVE_NS]: Use ns_load_path.
797 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
798
7c4e8ec0
GM
7992012-07-09 Glenn Morris <rgm@gnu.org>
800
d4f600ff
GM
801 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
802 since the included bsd-common.h does so.
803
cbb31951
GM
804 Stop ns builds setting the EMACSPATH environment variable.
805 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
806 (ns_init_paths): Do not set EMACSPATH.
807 * nsterm.h (ns_exec_path): Add it.
808 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
809 Use ns_exec_path.
810
7c4e8ec0
GM
811 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
812
26bccfae
PE
8132012-07-09 Paul Eggert <eggert@cs.ucla.edu>
814
a0bee46f
PE
815 * process.c (wait_reading_process_output): 'waitchannels' was unset
816 when read_kbd || !NILP (wait_for_cell); fix this.
817
5994c183
PE
818 Add GCC-style 'const' attribute to functions that can use it.
819 * character.h (char_resolve_modifier_mask):
820 * keyboard.h (make_ctrl_char):
821 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
822 (init_character_once, next_almost_prime, init_fns, init_image)
823 (flush_pending_output, init_sound):
824 * mem-limits.h (start_of_data):
825 * menu.h (finish_menu_items):
826 Add ATTRIBUTE_CONST.
827 * emacs.c (DEFINE_DUMMY_FUNCTION):
828 Declare the dummy function with ATTRIBUTE_CONST.
829 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
830 Add decls with ATTRIBUTE_CONST.
831
26bccfae
PE
832 Minor improvements to make_formatted_string.
833 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
834 where int is good enough, as vsprintf returns an int.
835 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
836
a8290ec3
DA
8372012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
838
839 Use make_formatted_string to avoid double length calculation.
840 * lisp.h (make_formatted_string): New prototype.
841 * alloc.c (make_formatted_string): New function.
842 * buffer.c (Fgenerate_new_buffer_name): Use it.
843 * dbus.c (syms_of_dbusbind): Likewise.
844 * editfns.c (Fcurrent_time_zone): Likewise.
845 * filelock.c (get_boot_time): Likewise.
846 * frame.c (make_terminal_frame, set_term_frame_name)
847 (x_report_frame_params): Likewise.
848 * image.c (gs_load): Likewise.
849 * minibuf.c (get_minibuffer): Likewise.
850 * msdos.c (dos_set_window_size): Likewise.
851 * process.c (make_process): Likewise.
852 * xdisp.c (ensure_echo_area_buffers): Likewise.
853 * xsettings.c (apply_xft_settings): Likewise.
854
d01ba2f1
GM
8552012-07-09 Glenn Morris <rgm@gnu.org>
856
857 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
858 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
859 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
860 * nsterm.h (ns_etc_directory): Add it.
861 * callproc.c [HAVE_NS]: Include nsterm.h.
862 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
863
f1f924b6
DA
8642012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
865
866 Move marker debugging code under MARKER_DEBUG.
867 * marker.c (MARKER_DEBUG): Move marker debugging code under
868 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
869 for bootstrap with --enable-checking (~3x slowdown reported
870 by Juanma Barranquero <lekktu@gmail.com>).
871 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
872
ab531b66
PE
8732012-07-08 Paul Eggert <eggert@cs.ucla.edu>
874
875 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
876 See <http://bugs.gnu.org/11825#29>.
877
c4b3bc8a
EZ
8782012-07-08 Eli Zaretskii <eliz@gnu.org>
879
880 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
881 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
882 (display_line): Add commentary about displaying truncation glyphs
883 on GUI frames.
884 (produce_special_glyphs): Move here from term.c.
885
886 * term.c (produce_special_glyphs): Move to xdisp.c.
887
888 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
889 section.
c4b3bc8a 890
b676b881
AS
8912012-07-07 Andreas Schwab <schwab@linux-m68k.org>
892
f17c5273
AS
893 * xdisp.c (display_line): Avoid warning about implicit declaration
894 of FRAME_FONT.
895
298819b9
AS
896 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
897
b676b881
AS
898 * lisp.h: Remove empty conditional.
899
6045c4fd
PE
9002012-07-07 Paul Eggert <eggert@cs.ucla.edu>
901
b3350bf9
PE
902 * lread.c (load_path_check): Now static.
903
6045c4fd
PE
904 Fix some minor --with-ns problems found by static checking.
905 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
906 (x_set_font) [!HAVE_X_WINDOWS]:
907 * image.c (xpm_load_image) [HAVE_NS]:
908 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
909 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
910 Remove unused local.
911 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
912 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
913 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
914 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
915 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
916 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
917 Fix pointer signedness problem.
918 * xfaces.c (FRAME_X_FONT_TABLE):
919 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
920
929e7845
GM
9212012-07-07 Glenn Morris <rgm@gnu.org>
922
923 * lread.c (load_path_check): New function, split from init_lread.
924 (init_lread): Reorganize. Motivation:
925 If EMACSLOADPATH is set, check/warn about that rather than the
926 defaults, which we are not going to use. Hence we can remove
927 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
928 Don't warn if site-lisp directories are missing.
929 If not installed, start from a blank load-path, since
930 PATH_LOADSEARCH refers to the eventual installation directories.
931
58dd0aa4
EZ
9322012-07-07 Eli Zaretskii <eliz@gnu.org>
933
934 Support truncation and continuation glyphs on GUI frames, when
935 fringes are disabled. (Bug#11832)
936 * xdisp.c (init_iterator): Get dimensions of truncation and
937 continuation glyphs even if on GUI frames. Adjust
938 it->last_visible_x on GUI frames when the left or right fringes,
939 or both, are absent.
940 (start_display, move_it_in_display_line_to): Handle the case of a
941 GUI frame without a fringe to display continuation or truncation
942 glyphs.
943 (insert_left_trunc_glyphs): Support GUI frames: make sure
944 truncation glyphs overwrite enough glyphs from the current line to
945 have sufficient space in pixels.
946 (display_line): Support truncation and continuation glyphs on GUI
947 frames. If some spare pixels are left on the line after inserting
948 the truncation glyphs, fill that space with a stretch glyph of a
949 suitably computed width.
950
951 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
952 produce_glyphs, to support GUI sessions.
953
31571fd7
PE
9542012-07-07 Paul Eggert <eggert@cs.ucla.edu>
955
5a16b9bc
PE
956 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
957
f3047c75
PE
958 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
959
31571fd7
PE
960 Do not require float-time's arg to fit in time_t (Bug#11825).
961 This works better on hosts where time_t is unsigned, and where
962 float-time is applied to the (negative) difference between two times.
963 * editfns.c (decode_time_components): Last arg is now double *,
964 not int *, and means to store all the result as a double, without
965 worrying about whether the seconds part fits in time_t.
966 All callers changed.
967 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
968 All callers changed.
969 (Ffloat_time): Do not fail merely because the specified time falls
970 outside of time_t range.
971
4516fbef
GM
9722012-07-07 Glenn Morris <rgm@gnu.org>
973
974 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
975 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
976 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
977
07adc2c6
JB
9782012-07-07 Juanma Barranquero <lekktu@gmail.com>
979
980 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
981 Update dependencies.
982
983 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
984
fd573f31
PE
9852012-07-06 Paul Eggert <eggert@cs.ucla.edu>
986
fee5959d
PE
987 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
988 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
989 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
990 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
991 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
992 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
993
fd573f31
PE
994 * xfont.c (compare_font_names): Redo to omit the need for casts.
995
ddadbc0e
AS
9962012-07-06 Andreas Schwab <schwab@linux-m68k.org>
997
fca8d6b6
AS
998 * xfns.c (Fx_change_window_property): Doc fix.
999 * w32fns.c (Fx_change_window_property): Doc fix.
1000
ddadbc0e
AS
1001 * w32fns.c (Fx_window_property): Accept the same arguments as the
1002 X Windows version. Doc fix.
1003 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1004
ed9265fc 10052012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1006 Eli Zaretskii <eliz@gnu.org>
1007
1008 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1009 Windows-specific code from nt/config.nt moved here.
1010 Obsolete settings removed.
1011
216ee680
PE
10122012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1013
1014 * process.c: Avoid unnecessary calls to gettime.
1015 (wait_reading_process_output): Don't get the time of day
1016 when gobbling data immediately and not waiting, as there's no need
1017 for it in that case. This removes a FIXME.
1018
bdd091e4
JD
10192012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1020
1021 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1022 is defined (Bug#11768).
1023
9d44f8ce
DA
10242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1025
1026 Fix marker debugging code.
1027 * marker.c (byte_char_debug_check): Do not perform the check
1028 if buffer is not multibyte.
090bd7cb
JB
1029 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1030 Call byte_char_debug_check with correct arguments.
9d44f8ce 1031
90fc4786
DA
10322012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1033
1034 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1035 * marker.c (byte_char_debug_check, count_markers):
1036 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1037 (byte_debug_flag): Remove.
1038 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1039 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1040
7b7ae965
DA
10412012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1042
4e57b342
DA
1043 Avoid code repetition in marker-related functions.
1044 * marker.c (attach_marker): New function.
1045 (Fset_marker, set_marker_restricted, set_marker_both)
1046 (set_marker_restricted_both): Use it.
1047 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1048 Consistently rename charno to charpos.
1049 (marker_position): Add eassert.
1050 (marker_byte_position): Convert to eassert.
1051
10522012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1055 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1056 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1057
657924ff
DA
10582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 Introduce fast path for the widely used marker operation.
1061 * alloc.c (build_marker): New function.
1062 * lisp.h (build_marker): New prototype.
1063 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1064 * composite.c (autocmp_chars): Likewise.
1065 * editfns.c (buildmark): Remove.
1066 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1067 (save_restriction_save): Use build_marker.
1068 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1069 * window.c (save_window_save): Likewise.
1070
041a49a6
DA
10712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1072
1073 Do not use Fdelete_overlay in delete_all_overlays
1074 to avoid redundant calls to unchain_overlay.
1075 * buffer.c (drop_overlay): New function.
1076 (delete_all_overlays, Fdelete_overlay): Use it.
1077 * minibuf.c (get_minibuffer): Fix comment.
1078
7dca65a4
PE
10792012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Port to OpenBSD 5.1 amd64.
1082 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1083 This is needed for OpenBSD, and should be harmless on all BSD systems.
1084 Also, include <sys/sysctl.h>, as it should be available on all
1085 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1086 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1087 use p_pid member, not kp_proc.pid.
1088
8eb876e2
GM
10892012-07-06 Glenn Morris <rgm@gnu.org>
1090
1091 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1092
38182d90
PE
10932012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 More xmalloc and related cleanup.
1096 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1097 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1098 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1099 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1100 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1101 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1102 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1103 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1104 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1105 * xterm.c:
1106 Omit needless casts involving void * pointers and allocation.
1107 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1108 as the former is more robust if P's type is changed.
1109 Prefer xzalloc to xmalloc + memset 0.
1110 Simplify malloc-or-realloc to realloc.
1111 Don't worry about xmalloc returning a null pointer.
1112 Prefer xstrdup to xmalloc + strcpy.
1113 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1114 growing it.
1115 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1116 alloca of a constant.
1117
6dd5a677
EZ
11182012-07-05 Eli Zaretskii <eliz@gnu.org>
1119
1120 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1121 hscroll is larger than the line width. Fixes long and futile
1122 looping inside extend_face_to_end_of_line (on a TTY) producing
1123 glyphs that are not needed and thrown away.
1124
6b312f0f
DA
11252012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1126
1127 * marker.c (set_marker_restricted_both): Simplify by using
1128 clip_to_bounds.
1129
f520ef9b
PE
11302012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1131
1132 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1133
383b7c95
JD
11342012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1135
1136 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1137 not defined (Bug#11768).
1138 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1139 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1140 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1141 followed by gtk_box_set_homogeneous (Bug#11768).
1142 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1143 (update_theme_scrollbar_width, xg_create_scroll_bar):
1144 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1145 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1146 (is_box_type): New function (Bug#11768).
1147 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1148 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1149 with default display (Bug#11768).
1150
d6e7bf45
EZ
11512012-07-05 Eli Zaretskii <eliz@gnu.org>
1152
1153 * xdisp.c (window_hscroll_limited): New function.
1154 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1155 coordinates when window's hscroll is set to insanely large
1156 values. (Bug#11857)
1157
431391ec
JB
11582012-07-05 Juanma Barranquero <lekktu@gmail.com>
1159
1160 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1161 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1162
23f86fce
DA
11632012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1164
1165 Cleanup xmalloc.
1166 * lisp.h (xzalloc): New prototype. Omit needless casts.
1167 * alloc.c (xzalloc): New function. Omit needless casts.
1168 * charset.c: Omit needless casts. Convert all calls to
1169 xmalloc with following memset to xzalloc.
1170 * dispnew.c: Likewise.
1171 * fringe.c: Likewise.
1172 * image.c: Likewise.
1173 * sound.c: Likewise.
1174 * term.c: Likewise.
1175 * w32fns.c: Likewise.
1176 * w32font.c: Likewise.
1177 * w32term.c: Likewise.
1178 * xfaces.c: Likewise.
1179 * xfns.c: Likewise.
1180 * xterm.c: Likewise.
1181 * atimer.c: Omit needless casts.
1182 * buffer.c: Likewise.
1183 * callproc.c: Likewise.
1184 * ccl.c: Likewise.
1185 * coding.c: Likewise.
1186 * composite.c: Likewise.
1187 * doc.c: Likewise.
1188 * doprnt.c: Likewise.
1189 * editfns.c: Likewise.
1190 * emacs.c: Likewise.
1191 * eval.c: Likewise.
1192 * filelock.c: Likewise.
1193 * fns.c: Likewise.
1194 * gtkutil.c: Likewise.
1195 * keyboard.c: Likewise.
1196 * lisp.h: Likewise.
1197 * lread.c: Likewise.
1198 * minibuf.c: Likewise.
1199 * msdos.c: Likewise.
1200 * print.c: Likewise.
1201 * process.c: Likewise.
1202 * region-cache.c: Likewise.
1203 * search.c: Likewise.
1204 * sysdep.c: Likewise.
1205 * termcap.c: Likewise.
1206 * terminal.c: Likewise.
1207 * tparam.c: Likewise.
1208 * w16select.c: Likewise.
1209 * w32.c: Likewise.
1210 * w32reg.c: Likewise.
1211 * w32select.c: Likewise.
1212 * w32uniscribe.c: Likewise.
1213 * widget.c: Likewise.
1214 * xdisp.c: Likewise.
1215 * xmenu.c: Likewise.
1216 * xrdb.c: Likewise.
1217 * xselect.c: Likewise.
1218
0497dc44
PE
12192012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 * fileio.c (time_error_value): Check the right error number.
1222 Problem reported by Troels Nielsen in
1223 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1224
356e7178
PE
12252012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1226
4e71fd89
PE
1227 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1228 This should be fixed in a better way; see Eli Zaretskii in
1229 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1230 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1231
f0941253
PE
1232 * fileio.c (time_error_value): Rename from special_mtime.
1233 The old name's problems were noted by Eli Zaretskii in
1234 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1235
065c9eb4
PE
1236 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1237 This variable's comment says Emacs needs at least one GDB-visible
1238 symbol of type enum pvec_type, to work around GDB problems.
1239 The symbol's value doesn't matter.
1240
356e7178
PE
1241 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1242 that causes compilation to fail on pre-C99 compilers.
1243
ed9265fc 12442012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1245
1246 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1247 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1248
3884d954
DA
12492012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1250
d209e2fb 1251 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1252 headers for buffer_defaults and buffer_local_symbols.
1253 Reported by Juanma Barranquero <lekktu@gmail.com>.
1254
ee28be33
SM
12552012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1256
1257 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1258 * lisp.h (enum pvec_type): Use fewer bits.
1259 (PSEUDOVECTOR_SIZE_BITS): New constant.
1260 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1261 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1262 change in pvec_type.
1263 (PSEUDOVECTOR_TYPEP): New macro.
1264 (TYPED_PSEUDOVECTORP): Use it.
1265 * fns.c (internal_equal): Adapt code to extract pvectype.
1266 * emacs.c (gdb_pvec_type): Update type.
1267 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1268 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1269 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1270 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1271 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1272 abusing vector->header.next.nbytes.
1273 (live_vector_p): Use PVEC_TYPE.
1274 (mark_object): Adapt code to extract pvectype. Use switch.
1275
c7f2cd7f
PE
12762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1279 Tighten new eassert a bit.
1280
8ce70ed2
DA
12812012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1282
1283 Fix compilation with --enable-gcc-warnings and -O1
1284 optimization level.
1285 * doprnt.c (doprnt): Change type of tem to int, initialize
1286 to avoid compiler warning. Add eassert.
1287 * search.c (simple_search): Initialize match_byte to avoid
1288 compiler warning. Add eassert.
1289
dea7f1e5
PE
12902012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1291
24a212eb
PE
1292 Avoid weird behavior with large horizontal scrolls.
1293 Without this change, for example, large hscroll values would
1294 mess up Emacs's display on Fedora 15 x86, presumably due to
1295 overflows in int calculations in the display code.
1296 Also, if buffers had long lines, Emacs would freeze.
1297 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1298 (set_window_hscroll): New function, containing the old guts of
1299 Fset_window_hscroll. Return the clipped value.
1300 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1301 This avoids the need to check against PTRDIFF_MAX.
1302
dea7f1e5
PE
1303 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1304
76046526
DA
13052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1308
39adff0d
PE
13092012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1310
63807d47
PE
1311 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1312 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1313 since GCC 4.4.6 issues a bogus warning for them.
1314
39adff0d
PE
1315 Fix bugs in file timestamp newness comparisons.
1316 * fileio.c (Ffile_newer_than_file_p):
1317 * lread.c (Fload): Use full timestamp resolution of files,
1318 not just the 1-second resolution, so that files that are only
1319 slightly newer still count as newer.
1320 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1321 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1322
dbeed9a6
PE
13232012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 * fileio.c: Improve handling of file time marker. (Bug#11852)
1326 (special_mtime): New function.
1327 (Finsert_file_contents, Fverify_visited_file_modtime):
1328 Use it to set special mtime values consistently.
1329
636334d6
AS
13302012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1331
1332 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1333 marker for non-existing file. (Bug#11852)
1334
e2017fe2
GM
13352012-07-03 Glenn Morris <rgm@gnu.org>
1336
1337 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1338 and did not make it into globals.h).
1339
404dbd37
TT
13402012-07-03 Tom Tromey <tromey@redhat.com>
1341
1342 * window.c (Fset_window_margins, Fset_window_fringes)
1343 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1344 * textprop.c (Fprevious_property_change): No longer static.
1345 * syntax.c (Fsyntax_table_p): No longer static.
1346 * process.c (Fget_process, Fprocess_datagram_address): No longer
1347 static.
1348 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1349 * keyboard.c (Fcommand_execute): No longer static.
1350 Remove EXFUN.
1351 * insdel.c (Fcombine_after_change_execute): No longer static.
1352 * image.c (Finit_image_library): No longer static.
1353 * fileio.c (Fmake_symbolic_link): No longer static.
1354 * eval.c (Ffetch_bytecode): No longer static.
1355 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1356 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1357 No longer static.
404dbd37
TT
1358 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1359 static.
1360 * dired.c (Ffile_attributes): No longer static.
1361 * composite.c (Fcomposition_get_gstring): No longer static.
1362 * callproc.c (Fgetenv_internal): No longer static.
1363
1364 * ccl.h: Remove EXFUNs.
1365 * buffer.h: Remove EXFUNs.
1366 * dispextern.h: Remove EXFUNs.
1367 * intervals.h: Remove EXFUNs.
1368 * fontset.h: Remove EXFUN.
1369 * font.h: Remove EXFUNs.
1370 * dosfns.c (system_process_attributes): Remove EXFUN.
1371 * keymap.h: Remove EXFUNs.
1372 * lisp.h: Remove EXFUNs.
1373 * w32term.h: Remove EXFUNs.
1374 * window.h: Remove EXFUNs.
1375 * xsettings.h: Remove EXFUN.
1376 * xterm.h: Remove EXFUN.
1377
8e4fd1e1
GM
13782012-07-03 Glenn Morris <rgm@gnu.org>
1379
1380 * lisp.h (Frandom): Make it visible to C.
1381 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1382 buffer for invisible buffers. (Bug#1229)
1383
ca95b3eb
DA
13842012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1385
1386 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1387 values which aren't power of 2.
1388 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1389 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1390 accordingly.
1391
7555c33f
SM
13922012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1393
1394 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1395
1396 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1397
d12e8f5a
DA
13982012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1399
1400 * alloc.c (allocate_vector_block): Remove redundant
1401 calls to mallopt if DOUG_LEA_MALLOC is defined.
1402 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1403 avoid calls to mallopt if zero_vector is returned.
1404
296094c3
DA
14052012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1406
1407 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1408 is enabled, avoid dereferencing NULL current_sblock if
1409 running undumped.
1410
36429c89
DA
14112012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1412
1413 Cleanup basic buffer management.
1414 * buffer.h (struct buffer): Change layout to use generic vector
1415 marking code. Fix some comments. Change type of 'clip_changed'
1416 to bitfield. Remove unused #ifndef old.
1417 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1418 (GET_OVERLAYS_AT): Fix indentation.
1419 (for_each_per_buffer_object_at): New macro.
1420 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1421 (Fbuffer_local_variables): Use it.
1422 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1423 * alloc.c (allocate_buffer): Adjust to match new layout of
1424 struct buffer. Fix comment.
1425 (mark_overlay): New function.
1426 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1427 Lisp area of struct buffer.
1428 (mark_object): Use it. Adjust marking of misc objects
1429 and related comments.
1430
3b3e4cac
PE
14312012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1434 wrapper that is not needed because the wrapped code is a no-op (zero
1435 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1436 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1437
cf5c0175
DA
14382012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1439
1440 * alloc.c (mark_buffer): Simplify. Remove prototype.
1441 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1442 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1443 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1444 redundant calls to mark_vectorlike for bool vectors.
1445
ca26824c
GM
14462012-06-30 Glenn Morris <rgm@gnu.org>
1447
2e4c5312
GM
1448 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1449
ca26824c
GM
1450 * epaths.in (PATH_SITELOADSEARCH): New.
1451 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1452 This is rather than relying on --enable-locallisppath elements
1453 having "site-lisp" in their names. (Bug#10208#25, 11658)
1454
0d23c240
EZ
14552012-06-30 Eli Zaretskii <eliz@gnu.org>
1456
c9240d7a
EZ
1457 * w32proc.c (sys_select): Accept and ignore one more argument.
1458
1459 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1460
0d23c240 1461 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1462 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1463
1464 * sysdep.c: Don't include dos.h and dosfns.h.
1465
1466 * process.c (sys_select):
1467 * msdos.c (sys_select): Accept one more argument and ignore it.
1468
1469 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1470 adapt data types and code to that.
1471
1472 * dosfns.c:
1473 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1474 which clashes with the gnulib function of the same name.
1475
af5a5a98
AS
14762012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1477
c5e4379c
AS
1478 * font.c (font_style_to_value, font_style_symbolic)
1479 (font_prop_validate_style): Add type checks for values in
1480 font_style_table.
1481
af5a5a98
AS
1482 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1483 argument.
1484 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1485 uses.
1486
8d38f461
EZ
14872012-06-29 Eli Zaretskii <eliz@gnu.org>
1488
2e5a6631
EZ
1489 * xdisp.c (try_window_id): Undo last change.
1490
8d38f461
EZ
1491 * w32.c (getwd): Adjust commentary about startup_dir.
1492 (init_environment): Always call sys_access, even in non-MSVC
1493 builds. Don't chdir to the directory of the Emacs executable.
1494 This undoes code from 1997 which was justified by the need to
1495 "avoid conflicts when removing and renaming directories". But its
1496 downside was that every relative file name was being interpreted
1497 relative to the directory of the Emacs executable, which can never
1498 be TRT. In particular, it broke sys_access when called with
1499 relative file names.
1500 (sys_access): Map GetLastError to errno.
1501
2af3565e
DA
15022012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1503
1504 * window.h (struct window): Change type of 'fringes_outside_margins'
1505 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1506 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1507 Adjust comment.
1508 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1509 to ptrdiff_t.
1510
c8d3a25c 15112012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1512
c8d3a25c
GM
1513 * gnutls.c (emacs_gnutls_handshake):
1514 Add QUIT to make the loop interruptible.
57570cd3 1515
c8d3a25c 15162012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1517
c8d3a25c
GM
1518 * charset.c (init_charset): Make lack of etc/charsets fatal.
1519
3e984ee8
DA
15202012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1521
1522 * editfns.c (region_limit): Fix type mismatch.
1523
ef884f23
DA
15242012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1525
1526 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1527 undefined. Convert from xassert to eassert.
1528 * nsmenu.m: Convert from xassert to eassert.
1529 * nsterm.m: Likewise.
1530
7d7e0027
SM
15312012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1532
1533 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1534
aa754e6a
PE
15352012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1536
1537 Avoid integer overflow on scroll-left and scroll-right.
1538 * window.c (HSCROLL_MAX): New macro.
1539 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1540 overflow when requested scroll falls outside ptrdiff_t range.
1541
80b00b08
DA
15422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1543
1544 * window.h (struct window): Change type of 'hscroll',
1545 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1546 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1547 Adjust users accordingly.
1548 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1549 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1550 from EMACS_INT to ptrdiff_t.
1551 (make_window): Omit redundant initialization.
1552
62b2bcf6
JB
15532012-06-28 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1556
45942c7d
DA
15572012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1558
1559 * window.h (struct window): Change type of 'use_time' and
1560 'sequence_number' from Lisp_Object to int.
1561 * frame.c (make_frame): Adjust users accordingly.
1562 * print.c (print_object): Likewise.
1563 * window.c (select_window, Fwindow_use_time, make_parent_window)
1564 (make_window): Likewise.
1565
e509cfa6
DA
15662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1567
1568 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1569 enabled with --enable-checking=[all,glyphs] configure option.
1570 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1571 adjust comments accordingly.
1572 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1573 undefined, adjust comments accordingly.
1574 * image.c: Likewise.
1575 * scroll.c: Likewise.
1576 * w32fns.c: Likewise.
1577 * w32term.c: Likewise.
1578 * xdisp.c: Likewise.
1579 * xfaces.c: Likewise.
1580 * xfns.c: Likewise.
1581 * xterm.c: Likewise.
1582
a54e2c05
DA
15832012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1584
1585 Generalize run-time debugging checks.
1586 * dispextern.h (XASSERTS): Remove.
1587 * fontset.c (xassert): Remove.
1588 Convert from xassert to eassert.
1589 * alloc.c: Convert from xassert to eassert.
1590 * bidi.c: Likewise.
1591 * dispnew.c: Likewise.
1592 * fns.c: Likewise.
1593 * fringe.c: Likewise.
1594 * ftfont.c: Likewise.
1595 * gtkutil.c: Likewise.
1596 * image.c: Likewise.
1597 * keyboard.c: Likewise.
1598 * menu.c: Likewise.
1599 * process.c: Likewise.
1600 * scroll.c: Likewise.
1601 * sound.c: Likewise.
1602 * term.c: Likewise.
1603 * w32console.c: Likewise.
1604 * w32fns.c: Likewise.
1605 * w32term.c: Likewise.
1606 * window.c: Likewise.
1607 * xdisp.c: Likewise.
1608 * xfaces.c: Likewise.
1609 * xfns.c: Likewise.
1610 * xselect.c: Likewise.
1611 * xterm.c: Likewise.
1612
1ec4b7b2
SM
16132012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1614
1615 * fns.c (maybe_resize_hash_table): Output message when growing the
1616 purify-hashtable.
1617
2014308a
DA
16182012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1619
1620 * alloc.c (allocate_string_data): Remove dead code.
1621 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1622 avoid GCC warning about unused macro.
1623
246155eb
DA
16242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 * alloc.c (allocate_string): Omit intervals initialization.
1627 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1628 as in make_pure_string and make_pure_c_string.
1629
43184b7b
DA
16302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1631
d209e2fb 1632 * alloc.c (allocate_string): Fix last change.
43184b7b 1633
3fe6dd74
DA
16342012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1635
d209e2fb 1636 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1637 to memset, add explicit initialization where appropriate.
1638
1ba6038a
GM
16392012-06-27 Glenn Morris <rgm@gnu.org>
1640
1641 * lisp.mk (lisp): Remove paths.elc.
1642
c89926a5
CY
16432012-06-27 Chong Yidong <cyd@gnu.org>
1644
1645 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1646
ed6b3510
JW
16472012-06-26 John Wiegley <johnw@newartisans.com>
1648
1ec4b7b2 1649 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1650 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1651
ed6b3510
JW
1652 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1653 when building with Clang.
1654
8edd4a2b
SM
16552012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1656
1657 * eval.c (Fapply): Allow calling it with a single argument.
1658
f6f62d1b
EZ
16592012-06-26 Eli Zaretskii <eliz@gnu.org>
1660
1661 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1662 _stricmp and _strnicmp.
1663 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1664
62efea5e
DA
16652012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1668 allocated window.
1669 (allocate_process): Likewise for new process.
8edd4a2b 1670 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1671 (allocate_frame): Likewise.
1672 * frame.c (make_frame): Omit redundant initialization.
1673 * window.c (make_parent_window): Use memset.
1674 (make_window): Omit redundant initialization.
1675 * process.c (make_process): Omit redundant initialization.
1676 * terminal.c (create_terminal): Likewise.
1677
42997f4d
DA
16782012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1679
1680 * term.c (delete_tty): Remove redundant call to memset.
1681
1130ecfc
DA
16822012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1683
1684 * alloc.c: Remove build_string.
1685 * lisp.h: Define build_string as static inline. This provides
1686 a better opportunity to optimize away calls to strlen when the
1687 function is called with compile-time constant argument.
1688 * image.c (imagemagick_error): Convert to build_string.
1689 * w32proc.c (sys_spawnve): Likewise.
1690 * xterm.c (x_term_init): Likewise.
1691
cf38a720
PE
16922012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1693
99027bdd
PE
1694 Use sprintf return value instead of invoking strlen on result.
1695 In the old days this wasn't portable, since some sprintf
1696 implementations returned char *. But they died out years ago and
1697 Emacs already assumes sprintf returns int.
1698 Similarly for float_to_string.
1699 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1700 * ccl.c (ccl_driver):
1701 * character.c (string_escape_byte8):
1702 * data.c (Fnumber_to_string):
1703 * doprnt.c (doprnt):
1704 * print.c (print_object):
1705 * xdisp.c (message_dolog):
1706 * xfns.c (syms_of_xfns):
1707 Use sprintf or float_to_string result to avoid need to call strlen.
1708 * data.c (Fnumber_to_string):
1709 Use make_unibyte_string, since the string must be ASCII.
1710 * lisp.h, print.c (float_to_string): Now returns int length.
1711 * term.c (produce_glyphless_glyph):
1712 Use sprintf result rather than recomputing it.
1713
cf38a720
PE
1714 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1715 * Makefile.in (ALL_CFLAGS):
1716 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1717 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1718
3511c784
DA
17192012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1720
0a08eb21 1721 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1722 strcasecmp if available.
1723 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1724
fb7da12e
AS
17252012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1726
1727 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1728 Avoid comma operator.
1729 * menu.c (push_submenu_start, push_submenu_end)
1730 (push_left_right_boundary, push_menu_pane): Likewise.
1731 * msdos.c (dos_rawgetc): Likewise.
1732
afa2ffd8
DA
17332012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1734
1735 * xfns.c (xic_create_fontsetname): Remove redundant calls
1736 to memset.
1737
b3b4476b
PE
17382012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1739
4495ff38
PE
1740 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1741 sprintf already null-terminates its output.
1742
b3b4476b
PE
1743 * xfns.c (x_window): Remove redundant cast.
1744
b00876c9
DA
17452012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1746
1747 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1748 `const char *' to `char *' to avoid compiler warning.
1749
d188e26b
PE
17502012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1751
885d1d74
PE
1752 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1753 instead of truncating it to 63 (admittedly a generous limit).
1754
d188e26b
PE
1755 * process.c: Fix spelling and caps in comments.
1756
e2f560b1
DN
17572012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1758
e86db54b 1759 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1760 * sysdep.c (setpgrp): Remove definition, not used in this file.
1761
7583a3a1
JB
17622012-06-24 Juanma Barranquero <lekktu@gmail.com>
1763
1764 * makefile.w32-in: Update dependencies.
1765
696056c2
EZ
17662012-06-24 Eli Zaretskii <eliz@gnu.org>
1767
1768 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1769 (SYSTIME_H): Add nt/inc/sys/time.h.
1770
1771 * systime.h [WINDOWSNT]: Include sys/time.h.
1772
1773 * s/ms-w32.h (struct timespec): Definition moved from
1774 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1775
845ca893
PE
17762012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1779 * buffer.h (buffer_slot_type_mismatch):
1780 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1781 * eval.c (unwind_to_catch):
1782 * image.c (my_png_error, my_error_exit):
1783 * keyboard.c (quit_throw_to_read_char, user_error)
1784 (Fexit_recursive_edit, Fabort_recursive_edit):
1785 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1786 (wrong_type_argument, buffer_overflow, __executable_start)
1787 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1788 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1789 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1790 (fatal):
1791 (child_setup) [!DOS_NT]:
1792 * lread.c (end_of_file_error, invalid_syntax):
1793 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1794 * puresize.h (pure_write_error):
1795 * search.c (matcher_overflow):
1796 * sound.c (sound_perror, alsa_sound_perror):
1797 * sysdep.c, syssignal.h (croak):
1798 * term.c (maybe_fatal, vfatal):
1799 * textprop.c (text_read_only):
1800 * undo.c (user_error):
1801 * unexmacosx.c (unexec_error):
1802 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1803 Use _Noreturn rather than NO_RETURN.
1804 No need for separate decl merely because of _Noreturn.
1805 * sound.c (sound_warning, parse_sound):
1806 Remove unnecessary forward decls.
1807
f1dd8073
PE
18082012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1811 * lisp.h (WAIT_READING_MAX): New macro.
1812 * dispnew.c (Fsleep_for, sit_for):
1813 * keyboard.c (kbd_buffer_get_event):
1814 * process.c (Faccept_process_output):
1815 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1816 This improves on the previous patch, which introduced a bug
1817 when time_t is unsigned and as wide as intmax_t.
1818 See <http://bugs.gnu.org/9000#51>.
1819
b82c1755
EZ
18202012-06-23 Eli Zaretskii <eliz@gnu.org>
1821
1822 * dispnew.c (sit_for, Fsleep_for):
1823 * keyboard.c (kbd_buffer_get_event):
1824 * process.c (Faccept_process_output): Avoid compiler warnings when
1825 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1826
ca300656
JB
18272012-06-23 Juanma Barranquero <lekktu@gmail.com>
1828
049ec95b
JB
1829 * makefile.w32-in: Update dependencies.
1830
ca300656
JB
1831 * w32.c (ltime): Add return type and declare static.
1832 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1833
db7b8d06
PE
18342012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1835
1836 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1837 Privately reported by Herbert J. Skuhra.
1838 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1839 All uses changed.
1840 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1841 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1842
0bd8297f
EZ
18432012-06-23 Eli Zaretskii <eliz@gnu.org>
1844
96512555
EZ
1845 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1846 last argument of make_unibyte_string.
1847
0bd8297f
EZ
1848 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1849 language ID in the event parameters.
1850
1851 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1852 event.code, not the obscure "character set ID".
1853
63def6b6
CY
18542012-06-23 Chong Yidong <cyd@gnu.org>
1855
1856 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1857
e8a02204
EZ
18582012-06-23 Eli Zaretskii <eliz@gnu.org>
1859
388cdec0
EZ
1860 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1861 * w32.c (fdutimens): New function.
1862
1863 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1864
1865 * s/ms-w32.h (pselect): Redirect to sys_select.
1866
1867 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1868
e8a02204
EZ
1869 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1870 in the logic of incrementing and decrementing the value of
1871 use_relocatable_buffers.
1872
d054f3fb
PE
18732012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1876 Privately reported by Herbert J. Skuhra.
1877 [__FreeBSD__]: Remove "*/" typo after "#include".
1878 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1879 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1880 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1881 Don't assume EMACS_TIME and struct timeval are the same type.
1882
d35af63c
PE
18832012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 Support higher-resolution time stamps (Bug#9000).
1886 The time stamps are only nanosecond-resolution at the C level,
1887 since that's the best that any real-world system supports now.
1888 But they are picosecond-resolution at the Lisp level, as that's
1889 easy, and leaves room for future OS improvements.
1890
1891 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1892 (LIBES): Use it.
1893
1894 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1895 Don't get current time unless it's needed.
1896
1897 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1898 now provides it if it's absent.
1899 (start_atimer): Port to higher-res time stamps.
1900 Check for time stamp overflow. Don't get current time more
1901 often than is needed.
1902
1903 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1904 Include systime.h, not time.h.
1905 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1906
1907 * dired.c: Include stat-time.h.
1908 (Ffile-attributes): File times now have higher resolution.
1909
1910 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1911 (struct image): Timestamp now has higher resolution.
1912
1913 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1914 has at least microseconds now. All uses removed.
1915 (update_frame, update_single_window, update_window, update_frame_1)
1916 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1917
1918 * editfns.c (time_overflow): Now extern.
1919 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1920 (float-time, Fformat_time_string, Fcurrent_time_string)
1921 (Fcurrent_time_zone): Accept and generate higher-resolution
1922 time stamps.
1923 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1924 (decode_time_components, lisp_seconds_argument): New functions.
1925 (make_time): Now static.
1926 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1927 Report an error if the time is invalid, rather than having the caller
1928 do that.
1929
1930 * fileio.c: Include <stat-time.h>
1931 (Fcopy_file): Copy higher-resolution time stamps.
1932 Prefer to set the time stamp via a file descriptor if that works.
1933 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1934 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1935 (Fvisited_file_modtime, Fset_visited_file_modtime):
1936 Support higher-resolution time stamps.
1937
1938 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1939
1940 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1941
1942 * image.c (prepare_image_for_display, clear_image_cache)
1943 (lookup_image): Port to higer-resolution time stamps.
1944
1945 * keyboard.c (start_polling, bind_polling_period):
1946 Check for time stamp overflow.
1947 (read_char, kbd_buffer_get_event, timer_start_idle)
1948 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1949 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1950 Port to higher-resolution time stamps. Do not assume time_t is signed.
1951 (decode_timer): New function. Timers are now vectors of length 9,
1952 not 8, to accommodate the picosecond component.
1953 (timer_check_2): Use it.
1954
1955 * nsterm.m (select_timeout, timeval_subtract): Remove.
1956 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1957 as they're a bit more accurate and handle overflow better.
1958 (ns_select): Change prototype to be compatible with pselect.
1959 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1960 * nsterm.h (ns_select): Adjust prototype.
1961
1962 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1963 us-resolution time stamps.
1964 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1965
1966 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1967
1968 * lisp.h (time_overflow): New decl.
1969 (wait_reading_process_output): First arg is now intmax_t, not int,
1970 to accommodate larger waits.
1971
1972 * process.h (struct Lisp_Process.read_output_delay):
1973 Now counts nanoseconds, not microseconds.
1974 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1975 EMACS_HAS_USECS.
1976 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1977 (wait_reading_process_output):
1978 Port to ns-resolution time stamps.
1979 (Faccept_process_output, wait_reading_process_output):
1980 Check for time stamp overflow. Do not assume time_t is signed.
1981 (select_wrapper): Remove; we now use pselect.
1982 (Fprocess_attributes): Now generates ns-resolution time stamps.
1983
1984 * sysdep.c: Include utimens.h. Don't include utime.h
1985 or worry about struct utimbuf; gnulib does that for us now.
1986 (gettimeofday): Remove; gnulib provides a substitute.
1987 (make_timeval): New function.
1988 (set_file_times): Now sets ns-resolution time stamps.
1989 New arg FD; all uses changed.
1990 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1991 (system_process_attributes):
1992 Now returns ns-resolution time stamp. All uses changed.
1993 Check for time stamp overflow.
1994
1995 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1996 provides a substitute now.
1997
1998 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1999 since it guarantees struct timespec.
2000 (EMACS_TIME): Now struct timespec, so that we can support
2001 ns-resolution time stamps.
2002 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2003 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2004 (EMACS_USECS): Remove.
2005 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2006 so multiply the arg by 1000 before storing it.
2007 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2008 New macros.
2009 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2010 Port to ns-resolution time stamps.
2011 (EMACS_TIME_NEG_P): Remove; replaced by....
2012 (EMACS_TIME_SIGN): New macro.
2013 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2014 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2015 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2016 (make_timeval, make_lisp_time, decode_time_components): New decls.
2017 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2018 that it mishandled time_t overflow. You can't compare by subtracting!
2019 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2020 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2021
2022 * term.c: Include <sys/time.h>.
2023 (timeval_to_Time): New function, for proper overflow wraparound.
2024 (term_mouse_position, term_mouse_click): Use it.
2025
2026 * undo.c (record_first_change): Support higher-resolution time stamps
2027 in the undo buffer.
2028 (Fprimitive_undo): Use them when restoring time stamps.
2029
2030 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2031 (w32_get_internal_run_time):
2032 Port to higher-resolution Emacs time stamps.
2033 (ltime): Now accepts single 64-bit integer, as that's more convenient
2034 for callers.
2035
2036 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2037
2038 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2039 for compatibility with pselect. Support ns-resolution time stamps.
2040
2041 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2042
2043 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2044 Check for time stamp overflow, and support ns-resolution time stamps.
2045
2046 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2047 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2048 (timeval_subtract): Remove; no longer needed.
2049 (XTflash, XTring_bell, x_wait_for_event):
2050 Port to ns-resolution time stamps. Don't assume time_t is signed.
2051
b6a92dfe
CY
20522012-06-22 Chong Yidong <cyd@gnu.org>
2053
2054 * xdisp.c (x_consider_frame_title): Revert last change.
2055
d251c37c
EZ
20562012-06-22 Eli Zaretskii <eliz@gnu.org>
2057
2058 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2059 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2060 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2061 staticidx goes up to 1597 out of 1600 = 0x640.)
2062
f10deafb
PE
20632012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2066 Otherwise, the umask might be mistakenly 0 while handling input signals.
2067
ec6de1e2
SM
20682012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2069
2070 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2071
28be1ada
DA
20722012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2073
2074 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2075 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2076 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2077 access to `contents' member of Lisp_Vector objects with AREF and ASET
2078 where appropriate.
2079
c6bf3022
CY
20802012-06-19 Chong Yidong <cyd@gnu.org>
2081
2082 * frame.c (delete_frame): When selecting a frame on a different
2083 text terminal, do not alter the terminal's top-frame.
2084
2085 * xdisp.c (format_mode_line_unwind_data): Record the target
2086 frame's selected window and its terminal's top-frame.
2087 (unwind_format_mode_line): Restore them.
2088 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2089 Callers changed.
2090 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2091 since tty frames can be explicitly named.
2092 (prepare_menu_bars): Likewise.
2093
2094 * term.c (Ftty_top_frame): New function.
2095
defd4196
PE
20962012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 Port byte-code-meter to modern targets.
2099 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2100 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2101 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2102 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2103 (METER_1, METER_2): Simplify.
2104
1053a871
SM
21052012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2106
2107 * data.c (Fdefalias): Return `symbol' (bug#11686).
2108
b7e8d081
MR
21092012-06-18 Martin Rudalics <rudalics@gmx.at>
2110
2111 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2112 gets killed during executing of this function (Bug#11665).
2113 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2114 (Vkill_buffer_query_functions): In doc-string say that functions
2115 run by this hook should not change the current buffer.
2116
7ea2b339
PE
21172012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 Fix recently-introduced process.c problems found by static checking.
2120 * process.c (write_queue_push, write_queue_pop, send_process):
2121 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2122 (write_queue_pop): Fix pointer signedness problem.
2123 (send_process): Remove unused local.
2124
96a313a1
CY
21252012-06-17 Chong Yidong <cyd@gnu.org>
2126
2127 * xdisp.c (redisplay_internal): No need to redisplay terminal
2128 frames that are not on top.
2129
20ca2e94
TN
21302012-06-17 Troels Nielsen <bn.troels@gmail.com>
2131
2132 * process.c (make_process): Initialize write_queue.
2133 (write_queue_push, write_queue_pop): New functions.
2134 (send_process): Use them to maintain correct ordering of process
2135 writes (Bug#10815).
2136
9a900ca9
PE
21372012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2138
310fbfa8
PE
2139 * lisp.h (eassert): Assume C89 or later.
2140 This removes the need for CHECK.
2141 (CHECK): Remove. Its comments about always evaluating its
2142 argument were confusing, as 'eassert' typically does not evaluate
2143 its argument.
2144
27bb1ca4
PE
2145 * coding.c (produce_chars): Use ptrdiff_t, not int.
2146
9a900ca9
PE
2147 * xterm.c (x_draw_underwave): Check for integer overflow.
2148 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2149
41b7f8bc 21502012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2151
2152 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2153 referenced (Bug#11583).
2154
9b0e3eba
AA
21552012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2156
2157 Implement wave-style variant of underlining.
2158 * dispextern.h (face_underline_type): New enum.
2159 (face): Add field for underline type.
2160 * nsterm.m (ns_draw_underwave): New function.
2161 (ns_draw_text_decoration): Use it.
2162 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2163 New functions.
2164 (x_draw_glyph_string): Use them.
2165 * xfaces.c (Qline, Qwave): New Lisp objects.
2166 (check_lface_attrs, merge_face_ref)
1053a871
SM
2167 (Finternal_set_lisp_face_attribute, realize_x_face):
2168 Handle wave-style underline face attributes.
9b0e3eba
AA
2169 * xterm.c (x_draw_underwave): New function.
2170 (x_draw_glyph_string): Use it.
2171
0fb52f11
JB
21722012-06-16 Juanma Barranquero <lekktu@gmail.com>
2173
2174 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2175 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2176 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2177 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2178 ($(BLD)/w32select.$(O)): Update dependencies.
2179
e5560ff7
AS
21802012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2181
2182 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2183 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2184 * character.c (_fetch_multibyte_char_p): Remove.
2185 * alloc.c: Include "character.h" before "buffer.h".
2186 * bidi.c: Likewise.
2187 * buffer.c: Likewise.
2188 * bytecode.c: Likewise.
2189 * callint.c: Likewise.
2190 * callproc.c: Likewise.
2191 * casefiddle.c: Likewise.
2192 * casetab.c: Likewise.
2193 * category.c: Likewise.
2194 * cmds.c: Likewise.
2195 * coding.c: Likewise.
2196 * composite.c: Likewise.
2197 * dired.c: Likewise.
2198 * dispnew.c: Likewise.
2199 * doc.c: Likewise.
2200 * dosfns.c: Likewise.
2201 * editfns.c: Likewise.
2202 * emacs.c: Likewise.
2203 * fileio.c: Likewise.
2204 * filelock.c: Likewise.
2205 * font.c: Likewise.
2206 * fontset.c: Likewise.
2207 * fringe.c: Likewise.
2208 * indent.c: Likewise.
2209 * insdel.c: Likewise.
2210 * intervals.c: Likewise.
2211 * keyboard.c: Likewise.
2212 * keymap.c: Likewise.
2213 * lread.c: Likewise.
2214 * macros.c: Likewise.
2215 * marker.c: Likewise.
2216 * minibuf.c: Likewise.
2217 * nsfns.m: Likewise.
2218 * nsmenu.m: Likewise.
2219 * print.c: Likewise.
2220 * process.c: Likewise.
2221 * regex.c: Likewise.
2222 * region-cache.c: Likewise.
2223 * search.c: Likewise.
2224 * syntax.c: Likewise.
2225 * term.c: Likewise.
2226 * textprop.c: Likewise.
2227 * undo.c: Likewise.
2228 * unexsol.c: Likewise.
2229 * w16select.c: Likewise.
2230 * w32fns.c: Likewise.
2231 * w32menu.c: Likewise.
2232 * window.c: Likewise.
2233 * xdisp.c: Likewise.
2234 * xfns.c: Likewise.
2235 * xmenu.c: Likewise.
2236 * xml.c: Likewise.
2237 * xselect.c: Likewise.
2238
2f07e6af
EZ
22392012-06-16 Eli Zaretskii <eliz@gnu.org>
2240
1053a871
SM
2241 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2242 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2243 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2244 row.
2245 (handle_face_prop): Use chunk-relative overlay string index when
2246 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2247 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2248 the rightmost. (Bug#11720)
2f07e6af 2249
29b83cec
AS
22502012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2251
2252 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2253 (CATEGORY_MEMBER): Enforce 1/0 value.
2254 * category.c (_temp_category_set): Remove.
2255
4c5501e9
EZ
22562012-06-16 Eli Zaretskii <eliz@gnu.org>
2257
2258 * window.c (Fdelete_other_windows_internal)
2259 (Fdelete_window_internal): Don't access frame's mouse highlight
2260 info of the initial frame. (Bug#11677)
2261
2b570124
PE
22622012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2263
e93864f9
PE
2264 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2265 Assume USE_2_TAGS_FOR_INTS.
2266 (xreload): Adjust $tagmask width to match recent lisp.h change.
2267
2b570124
PE
2268 Simplify lisp.h in minor ways that should not affect code.
2269 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2270 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2271 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2272 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2273 (INTTYPEBITS): New macro, for clarity.
2274 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2275 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2276 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2277 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2278 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2279
81755f69
JB
22802012-06-13 Juanma Barranquero <lekktu@gmail.com>
2281
2282 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2283
16192a57
GM
22842012-06-13 Glenn Morris <rgm@gnu.org>
2285
2286 * s/bsd-common.h (BSD4_3):
2287 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2288
646b5f55
AS
22892012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2290
2291 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2292 instead of union.
2293 (XLI, XIL): Define.
1053a871
SM
2294 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2295 Use them.
2296 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2297 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2298 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2299 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2300 * frame.c (delete_frame): Remove outdated comment.
2301 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2302 USE_LISP_UNION_TYPE.
2303 (Fw32_unregister_hot_key): Likewise.
2304 (Fw32_toggle_lock_key): Likewise.
2305 * w32menu.c (add_menu_item): Likewise.
2306 (w32_menu_display_help): Use XIL instead of checking
2307 USE_LISP_UNION_TYPE.
2308 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2309 (init_heap): Likewise.
2310 * w32term.c (w32_read_socket): Update comment.
2311
1d3823c9
GM
23122012-06-13 Glenn Morris <rgm@gnu.org>
2313
c62ff706
GM
2314 * s/usg5-4-common.h, src/s/unixware.h:
2315 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2316
1d3823c9
GM
2317 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2318
bfe3e0a2
PE
23192012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2322 * alloc.c (make_number) [!defined make_number]:
2323 Remove, as lisp.h always defines this now.
2324 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2325 (roundup_size): Verify that it is a power of 2.
2326 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2327 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2328 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2329 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2330 USE_LSB_TAG now is always defined to be either 0 or 1.
2331 All uses changed.
2332 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2333 code works fine either way, and efficiency is not a concern here,
2334 as the union type is for debugging, not for production.
2335 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2336 Use an inline function on all platforms when using the union type,
2337 since this is simpler and 'static inline' can be used portably
2338 within Emacs now.
2339 (LISP_INITIALLY_ZERO): New macro.
2340 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2341 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2342
45fa9c0f
GM
23432012-06-12 Glenn Morris <rgm@gnu.org>
2344
b4492cba
GM
2345 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2346
2347 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2348
45fa9c0f
GM
2349 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2350 Move BROKEN_SIGIO to configure.
2351
2352 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2353 Move NO_TERMIO to configure.
2354
0e25d334
CY
23552012-06-12 Chong Yidong <cyd@gnu.org>
2356
2357 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2358 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2359 MagickExportImagePixels is undefined.
2360
43682bb6
PE
23612012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2362
2363 * image.c (imagemagick_load_image): Remove unused label.
2364
a9be7d2b
GM
23652012-06-11 Glenn Morris <rgm@gnu.org>
2366
2367 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2368 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2369 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2370 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2371
3017f87f
SM
23722012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2373
2374 * alloc.c (make_byte_code): New function.
2375 (Fmake_byte_code): Use it. Don't purify here.
2376 * lread.c (read1): Use it as well to avoid extra allocation.
2377
1b9b4cf4
CY
23782012-06-11 Chong Yidong <cyd@gnu.org>
2379
2380 * image.c (imagemagick_load_image): Implement transparency.
2381
95988fcf
AS
23822012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2383
2384 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2385 account for preceding backslashes. (Bug#11663)
2386
cd4eb164
CY
23872012-06-09 Chong Yidong <cyd@gnu.org>
2388
2389 * term.c: Support italics in capable terminals (Bug#9652).
2390 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2391 (turn_on_face): Output using TS_enter_italic_mode if available.
2392 Don't handle unused blinking and alt-charset cases.
2393 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2394 and tty_alt_charset_p cases.
2395 (tty_capable_p, init_tty): Support italics.
2396
2397 * termchar.h (struct tty_display_info): Add field for italics.
2398 Remove unused blink field.
2399
2400 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2401 Handle slant.
2402
2403 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2404 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2405 tty_alt_charset_p. Add tty_italic_p.
2406
ff88beb8
MA
24072012-06-09 Michael Albinus <michael.albinus@gmx.de>
2408
2409 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2410 dbus_type_is_basic if available.
2411 (xd_extract_signed, xd_extract_unsigned): Rename from
2412 extract_signed and extract_unsigned, respectively. Adapt callers.
2413
44286096
CY
24142012-06-09 Chong Yidong <cyd@gnu.org>
2415
1682701f
CY
2416 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2417
44286096
CY
2418 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2419 case (Bug#9752).
2420
d86feb17
PE
24212012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * xdisp.c (vmessage): Treat frame message as multibyte.
2424 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2425 would generate the diagnostic "Making \302\247 buffer-local while
2426 let-bound!".
2427
d5c20fe8
EZ
24282012-06-08 Eli Zaretskii <eliz@gnu.org>
2429
2430 * dispnew.c (showing_window_margins_p): Undo last change, which
2431 was done due to an inadvertent commit.
2432 (adjust_frame_glyphs_for_frame_redisplay): Do call
2433 showing_window_margins_p.
2434
513749ee
SM
24352012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2436
2437 * eval.c (Fmake_var_non_special): New primitive.
2438 (syms_of_eval): Defsubr it.
2439 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2440
d4a8f5c1
JB
24412012-06-08 Juanma Barranquero <lekktu@gmail.com>
2442
2443 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2444 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2445
8bbbc977
EZ
24462012-06-08 Eli Zaretskii <eliz@gnu.org>
2447
2448 * alloc.c (allocate_vectorlike): Fix last change.
2449
f3372c87
DA
24502012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2451
2452 Block-based vector allocation of small vectors.
2453 * lisp.h (struct vectorlike_header): New field `nbytes',
2454 adjust comment accordingly.
2455 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2456 to denote vector blocks. Adjust users (live_vector_p,
2457 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2458 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2459 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2460 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2461 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2462 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2463 (roundup_size): New constant.
2464 (struct vector_block): New data type.
2465 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2466 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2467 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2468 (sweep_vectors): New functions.
2469 (allocate_vectorlike): Return `zero_vector' as the only vector of
2470 0 items. Allocate new vector from block if vector size is less than
2471 or equal to VBLOCK_BYTES_MAX.
2472 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2473 (init_alloc_once): Add call to init_vectors.
2474
4f18a4ed
SM
24752012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2476
2477 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2478
86f158bc
PE
24792012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2480
2481 * doprnt.c (doprnt): Truncate multibyte char correctly.
2482 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2483 would mishandle a string argument "Xc" if X was a multibyte
2484 character of length 2: it would truncate after X's first byte
2485 rather than including all of X.
2486
c5cfcbe0
CY
24872012-06-06 Chong Yidong <cyd@gnu.org>
2488
2489 * buffer.c (word_wrap): Doc fix.
2490
c05cf390
PE
24912012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2492
2493 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2494
0c3461de
GM
24952012-06-03 Glenn Morris <rgm@gnu.org>
2496
2497 * xdisp.c (tool-bar-style): Doc fix.
2498
c71232db
UM
24992012-06-03 Ulrich Müller <ulm@gentoo.org>
2500
2501 * Makefile.in (PAXCTL): Define.
2502 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2503 binary via PaX flags if the paxctl utility is available.
2504 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2505 Restore PaX flags to their default. (Bug#11398)
2506
383f7350
CY
25072012-06-03 Chong Yidong <cyd@gnu.org>
2508
2509 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2510 buffer (Bug#11226).
2511
5f2c76c6
CY
25122012-06-03 Chong Yidong <cyd@gnu.org>
2513
2514 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2515 (note_mode_line_or_margin_highlight): If there is no help echo,
2516 use mode-line-default-help-echo. Handle the case where the mouse
2517 position is past the end of the mode line string.
2518
2519 * buffer.c (buffer_local_value_1): New function, split from
2520 Fbuffer_local_value; can return Qunbound.
2521 (Fbuffer_local_value): Use it.
2522 (Vmode_line_format): Docstring tweaks.
2523
773d47f6
PE
25242012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 * sysdep.c (system_process_attributes): Improve comment.
2527
f2d6a3df
SM
25282012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2529
2530 * keyboard.c: Export real-this-command to Elisp.
2531 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2532 and DEFVAR it. Update all users.
2533
63810350
PE
25342012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2535
7bd5c1f4
PE
2536 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2537
63810350
PE
2538 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2539 Convert pctcpu and pctmem to Lisp float properly.
2540 Let the compiler fold better, as 100.0/0x8000 is exact.
2541
a2821611
AS
25422012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2543
2544 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2545 cons_block.
2546
5fceba1d
PE
25472012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2548
2549 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2550
c98ff5dd
DA
25512012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2552
2553 For a 'struct window', replace some Lisp_Object fields to
2554 bitfields where appropriate, remove unused fields.
2555 * window.h (struct window): Remove unused 'last_mark_x' and
2556 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2557 change it's type from Lisp_Object to bitfield.
2558 Change type of 'force_start', 'optional_new_start',
2559 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2560 fields from Lisp_Object to bitfield. Adjust users accordingly.
2561
ca34e0be
PE
25622012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 Pacify gcc -Wdouble-precision when using Xaw.
2565 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2566 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2567 Use 'float' consistently, rather than 'float' in most places
2568 and 'double' in a couple of places.
2569
efc00ab1 25702012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2571
2572 * xdisp.c (handle_stop): Detect whether we have overlay strings
2573 loaded by testing it->current.overlay_string_index to be
2574 non-negative, instead of checking whether n_overlay_strings is
2575 positive. (Bug#11587)
2576
efc00ab1 25772012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2578
2579 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2580
2581 * doc.c (Fsubstitute_command_keys): Doc fix.
2582
efc00ab1 25832012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2584
2585 * search.c (search_buffer): Remove calls to
2586 r_alloc_inhibit_buffer_relocation, as it is now called by
2587 maybe_unify_char, which was the cause of relocation of buffer text
2588 in bug#11519.
2589
efc00ab1 25902012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2591
2592 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2593 for the duration of call to load_charset, to avoid problems with
2594 callers of maybe_unify_char that access buffer text through C
2595 pointers.
2596
2597 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2598 decrement the inhibition flag, instead of just setting or
2599 resetting it.
2600
ba93a187
PE
26012012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 Remove obsolete '#define static' cruft.
2604 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2605 This #undef was "temporary" in 2000; it is no longer needed
2606 now that '#define static' has gone away.
2607 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2608 (gray_bitmap_bits): Remove; no longer needed.
2609 All uses replaced with definiens.
2610 * xterm.c: Include "bitmaps/gray.xbm".
2611
9e4bf381
PE
26122012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 Clean up __executable_start, monstartup when --enable-profiling.
2615 The following changes affect the code only when profiling.
2616 * dispnew.c (__executable_start): Rename from safe_bcopy.
2617 Define only on platforms that need it.
2618 * emacs.c: Include <sys/gmon.h> when profiling.
2619 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2620 (__executable_start): Remove decl, since lisp.h does it now.
2621 (safe_bcopy): Remove decl; no longer has that name.
2622 (main): Coalesce #if into single bit of code, for simplicity.
2623 Cast pointers to uintptr_t, since standard libraries want integers
2624 and not pointers.
2625 * lisp.h (__executable_start): New decl.
2626
32d72c2f
GM
26272012-05-31 Glenn Morris <rgm@gnu.org>
2628
2629 * image.c (Fimagemagick_types): Doc fix.
2630
baac5bc7
JM
26312012-05-30 Jim Meyering <meyering@redhat.com>
2632
2633 * callproc.c (Fcall_process_region): Include directory component
2634 in mkstemp error message (Bug#11586).
2635
72cb32cf
PE
26362012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 * alloc.c, lisp.h (make_pure_vector): Now static.
2639
61b108cc
SM
26402012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2641
2642 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2643 Move to byte-run.el.
2644 (Fautoload): Do the hash-doc more carefully.
2645 * data.c (Fdefalias): Purify definition, except for keymaps.
2646 (Qdefun): Move from eval.c.
2647 * lisp.h (Qdefun): Remove.
2648 * lread.c (read1): Tiny simplification.
2649
471fe23d
TN
26502012-05-29 Troels Nielsen <bn.troels@gmail.com>
2651
934f3f58 2652 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2653 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2654 Bug#9642, but explicitly check that the buffer the overlay would
2655 be moved to is live and rearrange lines to make sure that errors
2656 will not put the overlay in an inconsistent state.
2657 (Fdelete_overlay): Cosmetics.
2658
85d0efd1
EZ
26592012-05-28 Eli Zaretskii <eliz@gnu.org>
2660
2661 * w32term.c (my_bring_window_to_top): New function.
2662 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2663 could be different from the original one.
2664 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2665 (Bug#11513)
2666
2667 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2668 by calling BringWindowToTop.
2669
2670 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2671 (WM_EMACS_END): Increase by one.
2672
da92a98c
PE
26732012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2674
2675 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2676 This avoids undefined behavior that might cause the eassert
2677 to not catch an out-of-range value.
2678
74d1f848
JB
26792012-05-28 Juanma Barranquero <lekktu@gmail.com>
2680
2681 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2682 Update dependencies.
2683
9e1a06fc
EZ
26842012-05-27 Eli Zaretskii <eliz@gnu.org>
2685
2686 * bidi.c (bidi_mirror_char): Fix last change.
2687
f3dd7312
AS
26882012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2689
2690 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2691 when referring to sectname field in printf format.
2692
81899c91
PE
26932012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2694
57b81a9f
PE
2695 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2696 Only r_alloc_inhibit_buffer_relocation needed to be added;
2697 the others were already declared.
2698
81899c91
PE
2699 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2700 before checking whether it's out of range. Put the check inside
2701 eassert. See
2702 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2703
33017faf 27042012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2705
2706 * callproc.c (Fcall_process): Restore a line that was accidentally
2707 commented out in the 2011-02-13 change (bug#11547).
2708
33017faf 27092012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2710
2711 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2712 defined on ralloc.c.
2713
2714 * buffer.c [REL_ALLOC]: Remove prototypes of
2715 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2716 they are now on lisp.h.
2717
2718 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2719
2720 * search.c (search_buffer): Use it to inhibit relocation of buffer
2721 text while re_search_2 is doing its job, because re_search_2 is
2722 passed C pointers to buffer text. (Bug#11519)
2723
23415acf
EZ
2724 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2725 Update value to 24.
2726
44e27368
EZ
2727 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2728 state after an additional call to move_it_in_display_line_to, keep
2729 the values of it->max_ascent and it->max_descent found for the
2730 entire line.
2731 (pos_visible_p): Revert the comparison against bottom_y to what it
2732 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2733 (Bug#11464)
2734
c1892f11
PE
27352012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 Fix coding-related core dumps with gcc -ftrapv.
2738 The code was computing A - B, where A and B are pointers, and B is
2739 random garbage. This can lead to core dumps on platforms that
2740 have special pointer registers, and it also leads to core dumps on
2741 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2742 A - B only when B is initialized properly.
2743 * coding.c (coding_set_source, coding_set_destination): Return void.
2744 (coding_change_source, coding_change_destinations): New functions,
2745 with the old behaviors of coding_set_source and coding_set_destination.
2746 All callers that need an offset changed to use these new functions.
2747
eb7afdad
GM
27482012-05-26 Glenn Morris <rgm@gnu.org>
2749
2750 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2751
f12fdf02
EZ
27522012-05-26 Eli Zaretskii <eliz@gnu.org>
2753
53a63be6 2754 Extend mouse support on W32 text-mode console.
61b108cc
SM
2755 * xdisp.c (draw_row_with_mouse_face):
2756 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2757
eb3f6f01 2758 * w32console.c: Include window.h.
61b108cc
SM
2759 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2760 New functions.
eb3f6f01
EZ
2761 (initialize_w32_display): Initialize mouse-highlight data.
2762
53a63be6
EZ
2763 * w32inevt.c: Include termchar.h and window.h.
2764 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2765 moves, call note_mouse_highlight. If help_echo changed, call
2766 gen_help_event to produce help-echo message in the echo area.
2767 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2768 highlight info.
2769
4cfd81f6
PE
27702012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 * lread.c (read1): Simplify slightly to avoid an overflow warning
2773 with GCC 4.7.0 on x86-64.
2774
4446092a
EZ
27752012-05-26 Eli Zaretskii <eliz@gnu.org>
2776
2777 * bidi.c (bidi_mirror_char): Revert last change: an int is
2778 definitely wide enough here.
2779
42b2a986 27802012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2781
42b2a986 2782 Fix integer width and related bugs (Bug#9874).
eb106a49 2783 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2784 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2785 (string_bytes, check_sblock, allocate_string_data):
2786 (compact_small_strings, Fmake_bool_vector, make_string)
2787 (make_unibyte_string, make_multibyte_string)
2788 (make_string_from_bytes, make_specified_string)
2789 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2790 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2791 (mark_vectorlike):
2792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2793 (allocate_pseudovector):
2794 Use int, not EMACS_INT, where int is wide enough.
2795 (inhibit_garbage_collection, Fgarbage_collect):
2796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2797 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2798 int might not be wide enough.
2799 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2800 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2801 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2802 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2803 (bidi_level_of_next_char, bidi_move_to_visually_next):
2804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2805 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2806 (Fkill_buffer, Fset_buffer_major_mode)
2807 (advance_to_char_boundary, Fbuffer_swap_text)
2808 (Fset_buffer_multibyte, overlays_at, overlays_in)
2809 (overlay_touches_p, struct sortvec, record_overlay_string)
2810 (overlay_strings, recenter_overlay_lists)
2811 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2812 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2813 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2814 (Foverlay_recenter, last_overlay_modification_hooks_used)
2815 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2817 (validate_region): Omit unnecessary test for b <= e,
2818 since that's guaranteed by the previous test.
d311d28c
PE
2819 (adjust_overlays_for_delete): Avoid pos + length overflow.
2820 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2821 (report_overlay_modification):
2822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2823 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2824 Omit pointer cast, which isn't needed anyway, and doesn't work
2825 after the EMACS_INT -> ptrdiff_t change.
02481186 2826 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2827 * buffer.h: Adjust decls to match defn changes elsewhere.
2828 (struct buffer_text, struct buffer):
2829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2830 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2831 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2832 not int, to avoid needless 32-bit limit on 64-bit hosts.
2833 (exec_byte_code): Use tighter memory-full test, one that checks
2834 for alloca overflow. Don't compute the address of the object just
2835 before an array, as that's not portable. Use EMACS_INT, not
2836 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2837 * callint.c (Fcall_interactively):
2838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2839 * callproc.c (call_process_kill, Fcall_process):
2840 Don't assume pid_t fits into an Emacs fixnum.
2841 (call_process_cleanup, Fcall_process, child_setup):
2842 Don't assume pid_t fits into int.
2843 (call_process_cleanup, Fcall_process, delete_temp_file)
2844 (Fcall_process_region):
2845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2846 (Fcall_process): Simplify handling of volatile integers.
2847 Use int, not EMACS_INT, where int will do.
2848 * casefiddle.c (casify_object, casify_region, operate_on_word)
2849 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2851 (casify_object): Avoid integer overflow when overallocating buffer.
2852 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2853 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2854 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2855 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2856 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2857 integers are now checked earlier. All uses replaced with XINT.
2858 (ccl_driver):
2859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2860 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2861 (ccl_driver, Fregister_code_conversion_map):
2862 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2863 (resolve_symbol_ccl_program): Check that vector header is in range.
2864 Always copy the vector, so that we can check its contents reliably
2865 now rather than having to recheck each instruction as it's being
2866 executed. Check that vector words fit in 'int'.
2867 (ccl_get_compiled_code, Fregister_ccl_program)
2868 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2869 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2870 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2871 contents are in range.
2872 (Fccl_execute_on_string): Check that status is in range.
2873 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2874 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2875 Accept and return EMACS_INT, not int, because callers can pass values
2876 out of 'int' range.
2877 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2878 (multibyte_chars_in_text, parse_str_as_multibyte)
2879 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2880 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2881 (string_escape_byte8, Fget_byte):
2882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2883 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2884 avoid mishandling large integers.
2885 * character.h: Adjust decls to match defn changes elsewhere.
2886 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2887 (Ffind_charset_region):
2888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2889 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2890 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2891 Don't assume fixnum fits in int.
d311d28c
PE
2892 (load_charset_map_from_vector, Fmap_charset_chars):
2893 Remove now-unnecessary CHECK_NATNUMs.
2894 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2895 Don't rely on undefined behavior with signed left shift overflow.
2896 Don't assume unsigned int fits into fixnum, or that fixnum fits
2897 into unsigned int. Don't require max_code to be a valid fixnum;
2898 that's not true for gb10830 4-byte on a 32-bit host. Allow
2899 invalid_code to be a cons, for the same reason. Require code_offset
2900 to be a character. Avoid int overflow if max_char is close
2901 to INT_MAX.
2902 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2903 this is intended anyway and avoids some undefined behavior.
2904 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2905 INDEX_TO_CODE_POINT, as that's what it expects.
2906 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2907 * charset.h (DECODE_CHAR): Return int, not unsigned;
2908 this is what was intended anyway, and it avoids undefined behavior.
2909 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2910 integer-overflow issues.
2911 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2912 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2913 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2914 * chartab.c (Fmake_char_table, Fset_char_table_range)
2915 (uniprop_get_decoder, uniprop_get_encoder):
2916 Don't assume fixnum fits in int.
2917 * cmds.c (move_point): New function, that does the gist of
2918 Fforward_char and Fbackward_char, but does so while checking
2919 for integer overflow more accurately.
c96e5d6a 2920 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2921 (Fforward_line, Fend_of_line, internal_self_insert)
2922 (internal_self_insert):
2923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2924 Fix a FIXME, by checking for integer overflow when calculating
2925 target_clm and actual_clm.
2926 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2927 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2928 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2929 (coding_alloc_by_making_gap, alloc_destination)
2930 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2931 (encode_coding_utf_16, detect_coding_emacs_mule)
2932 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2933 (detect_coding_iso_2022, decode_coding_iso_2022)
2934 (encode_invocation_designation, encode_designation_at_bol)
2935 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2936 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2937 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2938 (encode_coding_ccl, encode_coding_raw_text)
2939 (detect_coding_charset, decode_coding_charset)
2940 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2941 (produce_composition, produce_charset, produce_annotation)
2942 (decode_coding, handle_composition_annotation)
2943 (handle_charset_annotation, consume_chars, decode_coding_gap)
2944 (decode_coding_object, encode_coding_object, detect_coding_system)
2945 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2946 (code_convert_region, code_convert_string)
8f50130c
PE
2947 (Fdefine_coding_system_internal)
2948 (coding_set_source, coding_set_destination):
d311d28c
PE
2949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2950 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2951 (Fdefine_coding_system_internal):
2952 Don't assume fixnums fit in int.
2953 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2954 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2955 (Funencodable_char_position, Fcheck_coding_systems_region)
2956 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2958 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2959 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2960 Don't access memory outside of the args array.
d311d28c 2961 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2962 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2963 result of ENCODE_CHAR.
d311d28c
PE
2964 * coding.h: Adjust decls to match defn changes elsewhere.
2965 (struct coding_system):
2966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2967 * composite.c (get_composition_id, find_composition)
2968 (run_composition_function, update_compositions)
2969 (compose_text, composition_gstring_put_cache)
2970 (composition_gstring_p, composition_gstring_width)
2971 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2972 (composition_compute_stop_pos, composition_reseat_it)
2973 (composition_update_it, struct position_record)
2974 (find_automatic_composition, composition_adjust_point)
2975 (Fcomposition_get_gstring, Ffind_composition_internal):
2976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2977 (update_compositions):
2978 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2979 * composite.h: Adjust decls to match defn changes elsewhere.
2980 (struct composition):
2981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2982 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2983 Do not attempt to compute the address of the object just before a
2984 buffer; this is not portable.
2985 (Faref, Faset):
2986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2987 (Faset): Use int, not EMACS_INT, where int is wide enough.
2988 (Fstring_to_number): Don't assume fixnums fit in int.
2989 (Frem): Don't assume arg is nonnegative.
2990 * dbusbind.c (xd_append_arg): Check for integers out of range.
2991 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2992 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2993 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2994 (xd_get_connection_references): Return ptrdiff_t, not int.
2995 All uses changed.
2996 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2997 (xd_read_message_1):
2998 Use int, not unsigned, where the dbus API uses int.
2999 (Fdbus_message_internal): Don't overflow mtype.
3000 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3001 * dired.c (directory_files_internal, file_name_completion, scmp)
3002 (file_name_completion_stat):
3003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3004 (file_name_completion): Don't overflow matchcount.
3005 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3006 * dispextern.h: Adjust decls to match defn changes elsewhere.
3007 (struct text_pos, struct glyph, struct bidi_saved_info)
3008 (struct bidi_string_data, struct bidi_it, struct composition_it)
3009 (struct it):
3010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3011 (struct display_pos, struct composition_it, struct it):
3012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3013 * dispnew.c (increment_matrix_positions)
3014 (increment_row_positions, mode_line_string)
3015 (marginal_area_string):
3016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3017 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3019 (duration_to_sec_usec): New function, to check for overflow better.
3020 (Fsleep_for, sit_for): Use it.
3021 * doc.c (get_doc_string, store_function_docstring):
3022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3023 (get_doc_string, Fsnarf_documentation):
3024 Use int, not EMACS_INT, where int is wide enough.
3025 (get_doc_string):
3026 Use SAFE_ALLOCA, not alloca.
3027 Check for overflow when converting EMACS_INT to off_t.
3028 * doprnt.c (doprnt):
3029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3030 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3031 Don't assume uid_t fits into fixnum.
3032 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3033 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3034 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3035 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3036 (general_insert_function)
3037 (Finsert_char, make_buffer_string, make_buffer_string_both)
3038 (update_buffer_properties, Fbuffer_substring)
3039 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3040 (Fsubst_char_in_region, check_translation)
3041 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3042 (transpose_markers, Ftranspose_regions):
3043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3044 (clip_to_bounds): Move to lisp.h as an inline function).
3045 (Fconstrain_to_field): Don't assume integers are nonnegative.
3046 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3047 (Fsubst_char_in_region, Fsave_restriction):
3048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3049 (Femacs_pid): Don't assume pid_t fits into fixnum.
3050 (lo_time): Use int, not EMACS_INT, when int suffices.
3051 (lisp_time_argument): Check for usec out of range.
3052 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3053 (Fuser_login_name, Fuser_full_name): Signal an error
3054 if a uid argument is out of range, rather than relying on
3055 undefined behavior.
c8d5c857
PE
3056 (Fformat_time_string): Remove now-unnecessary check.
3057 lisp_time_argument checks for out-of-range usec now.
243e0530 3058 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3059 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3060 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3061 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3062 (init_cmdargs, Fdump_emacs):
3063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3064 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3065 the bottom (typically) 32 bits of the fixnum.
3066 * eval.c (specpdl_size, call_debugger):
3067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3068 (when_entered_debugger, Fbacktrace_debug):
3069 Don't assume fixnum can fit in int.
3070 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3071 the object just before a buffer; this is not portable.
3072 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3073 (grow_specpdl, unbind_to):
3074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3075 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3076 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3077 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3078 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3079 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3081 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3082 (a_write, e_write):
3083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3084 (Fcopy_file, non_regular_nbytes, read_non_regular)
3085 (Finsert_file_contents):
3086 Use int, not EMACS_INT, where int is wide enough.
3087 (READ_BUF_SIZE): Verify that it fits in int.
3088 (Finsert_file_contents): Check that counts are in proper range,
3089 rather than assuming fixnums fit into ptrdiff_t etc.
3090 Don't assume fixnums fit into int.
125b3835 3091 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3092 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3093 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3094 (string_char_to_byte, string_byte_to_char)
3095 (string_make_multibyte, string_to_multibyte)
3096 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3097 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3098 (substring_both, Fdelete, internal_equal, Ffillarray)
3099 (Fclear_string, mapcar1)
3100 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3101 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3102 (larger_vector, make_hash_table, maybe_resize_hash_table)
3103 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3104 (Fmaphash, secure_hash):
3105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3106 (concat): Check for string index and length overflow.
3107 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3108 (Frequire):
3109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3110 (larger_vector): New API (vec, incr_min, size_max) replaces old
3111 one (vec, new_size, init). This catches size overflow.
3112 INIT was removed because it was always Qnil.
3113 All callers changed.
3114 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3115 the upper bound on a hash table index size.
3116 (make_hash_table, maybe_resize_hash_table): Use it.
3117 (secure_hash): Computer start_byte and end_byte only after
3118 they're known to be in ptrdiff_t range.
3119 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3120 (Ffont_get_glyphs, Ffont_at):
3121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3122 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3123 (Flist_fonts, Fopen_font):
3124 Don't assume fixnum can fit in int.
3125 (check_gstring): Don't assume index can fit in int.
3126 (font_match_p): Check that fixnum is a character, not a nonnegative
3127 fixnum, since the later code needs to stuff it into an int.
3128 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3129 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3130 conversion overflow issues.
3131 (Fopen_font): Check for integer out of range.
3132 (Ffont_get_glyphs): Don't assume index can fit in int.
3133 * font.h: Adjust decls to match defn changes elsewhere.
3134 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3135 integer overflow.
3136 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3137 printmax_t, where ptrdiff_t is wide enough.
3138 (Finternal_char_font):
3139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3140 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3141 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3142 (Fset_frame_position, x_set_frame_parameters)
3143 (x_set_line_spacing, x_set_border_width)
3144 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3145 Check that fixnums are in proper range for system types.
3146 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3148 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3149 Use SAFE_ALLOCA_LISP, not alloca.
3150 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3151 intptr_t is wide enough.
3152 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3153 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3154 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3155 Check for fixnum out of range.
3156 * ftfont.c (ftfont_list): Don't assume index fits in int.
3157 Check that fixnums are in proper range for system types.
3158 (ftfont_shape_by_flt):
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3160 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3162 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3163 Check that fixnums are in proper range for system types.
3164 * gnutls.h: Adjust decls to match defn changes elsewhere.
3165 * gtkutil.c (xg_dialog_run):
3166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3167 (update_frame_tool_bar):
3168 Check that fixnums are in proper range for system types.
3169 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3170 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3171 * indent.c (last_known_column, last_known_column_point):
3172 (current_column_bol_cache):
3173 (skip_invisible, current_column, check_display_width):
3174 (check_display_width, scan_for_column, current_column_1)
3175 (Findent_to, Fcurrent_indentation, position_indentation)
3176 (indented_beyond_p, Fmove_to_column, compute_motion):
3177 (Fcompute_motion, Fvertical_motion):
3178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3179 (last_known_column_modified): Use EMACS_INT, not int.
3180 (check_display_width):
3181 (Fcompute_motion):
3182 Check that fixnums and floats are in proper range for system types.
3183 (compute_motion): Don't assume index or fixnum fits in int.
3184 (compute_motion, Fcompute_motion):
3185 Use int, not EMACS_INT, when it is wide enough.
3186 (vmotion): Omit local var start_hpos that is always 0; that way
3187 we don't need to worry about overflow in expressions involving it.
3188 * indent.h: Adjust decls to match defn changes elsewhere.
3189 (struct position):
3190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3191 Use int, not EMACS_INT, where int is wide enough.
3192 Remove unused members ovstring_chars_done and tab_offset;
3193 all uses removed.
3194 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3195 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3196 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3197 (make_gap, copy_text, insert, insert_and_inherit)
3198 (insert_before_markers, insert_before_markers_and_inherit)
3199 (insert_1, count_combining_before, count_combining_after)
3200 (insert_1_both, insert_from_string)
3201 (insert_from_string_before_markers, insert_from_string_1)
3202 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3203 (adjust_after_replace, adjust_after_insert, replace_range)
3204 (replace_range_2, del_range, del_range_1, del_range_byte)
3205 (del_range_both, del_range_2, modify_region)
3206 (prepare_to_modify_buffer, signal_before_change)
3207 (signal_after_change, Fcombine_after_change_execute):
3208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3209 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3210 (balance_an_interval, split_interval_right, split_interval_left)
3211 (find_interval, next_interval, update_interval)
3212 (adjust_intervals_for_insertion, delete_node, delete_interval)
3213 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3214 (static_offset_intervals, offset_intervals)
3215 (merge_interval_right, merge_interval_left, make_new_interval)
3216 (graft_intervals_into_buffer, temp_set_point_both)
3217 (temp_set_point, set_point, adjust_for_invis_intang)
3218 (set_point_both, move_if_not_intangible, get_property_and_range)
3219 (get_local_map, copy_intervals, copy_intervals_to_string)
3220 (compare_string_intervals, set_intervals_multibyte_1):
3221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3222 * intervals.h: Adjust decls to match defn changes elsewhere.
3223 (struct interval):
3224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3225 * keyboard.c (this_command_key_count, this_single_command_key_start)
3226 (before_command_key_count, before_command_echo_length, echo_now)
3227 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3228 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3229 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3230 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3232 (last_non_minibuf_size, last_point_position, echo_truncate)
3233 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3234 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3235 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3236 (stuff_buffered_input):
3237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3238 (last_auto_save, command_loop_1, read_char):
3239 Use EMACS_INT, not int, to avoid integer overflow.
3240 (record_char): Avoid overflow in total_keys computation.
3241 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3242 * keyboard.h: Adjust decls to match defn changes elsewhere.
3243 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3244 (Fkey_description, Fdescribe_vector, Flookup_key):
3245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3246 (click_position): New function, to check that positions are in range.
3247 (Fcurrent_active_maps):
3248 (describe_command):
3249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3250 (Faccessible_keymaps, Fkey_description):
3251 (preferred_sequence_p):
3252 Don't assume fixnum can fit into int.
3253 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3254 Check for integer overflow in size calculations.
3255 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3256 avoid mishandling large integers.
3257 * lisp.h: Adjust decls to match defn changes elsewhere.
3258 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3259 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3260 (struct Lisp_Marker):
3261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3262 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3263 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3264 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3265 All callers changed.
3266 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3267 Assume the arg has valid form, since it always does.
3268 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3269 unsigned integer system type.
3270 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3271 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3273 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3274 (duration_to_sec_usec): New decl.
3275 * lread.c (read_from_string_index, read_from_string_index_byte)
3276 (read_from_string_limit, readchar, unreadchar, openp)
3277 (read_internal_start, read1, oblookup):
3278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3279 (Fload, readevalloop, Feval_buffer, Feval_region):
3280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3281 (openp): Check for out-of-range argument to 'access'.
3282 (read1): Use int, not EMACS_INT, where int is wide enough.
3283 Don't assume fixnum fits into int.
6efdadfd 3284 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3285 (read_filtered_event): Use duration_to_sec_usec
3286 to do proper overflow checking on durations.
d311d28c
PE
3287 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3288 in size calculation.
3289 (Fexecute_kbd_macro):
3290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3291 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3292 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3293 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3294 (set_marker_both, set_marker_restricted_both, marker_position)
3295 (marker_byte_position, Fbuffer_has_markers_at):
3296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3297 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3298 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3299 It now merely ensures that the menu is large enough, without
3300 necessarily growing it, as this avoids some integer overflow issues.
3301 All callers changed.
3302 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3304 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3305 Use SAFE_ALLOCA_LISP, not alloca.
3306 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3307 to EMACS_INT. Check that fixnums are in proper range for system types.
3308 * minibuf.c (minibuf_prompt_width, string_to_object)
3309 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3310 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3312 (get_minibuffer, read_minibuf_unwind):
3313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3314 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3315 this simplifies overflow checking. All callers changed.
3316 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3317 (Ftest_completion):
3318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3319 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3320 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3321 Check that fixnums are in proper range for system types.
3322 (Fx_create_frame, Fx_show_tip):
3323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3324 * nsfont.m (ns_findfonts, nsfont_list_family):
3325 Don't assume fixnum fits in long.
3326 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3328 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3329 wide enough.
17fdb222 3330 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3332 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3333 (PRINTDECLARE, PRINTPREPARE):
3334 (strout, print_string):
3335 (print, print_preprocess, print_check_string_charset_prop)
3336 (print_object):
3337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3338 (PRINTDECLARE):
3339 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3341 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3342 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3343 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3344 (print_error_message): Use SAFE_ALLOCA, not alloca.
3345 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3346 (print_depth, new_backquote_output, print_number_index):
3347 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3348 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3349 (Fset_process_window_size, Fformat_network_address)
3350 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3351 (sigchld_handler):
d311d28c 3352 Check that fixnums are in proper range for system types.
d44287d4 3353 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3354 Check for process-ids out of pid_t range rather than relying on
3355 undefined behavior.
e4d81efc 3356 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3357 (Fformat_network_address, read_process_output, send_process)
3358 (Fprocess_send_region, status_notify):
3359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3360 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3361 (wait_reading_process_output, read_process_output, exec_sentinel):
3362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3363 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3364 (Faccept_process_output): Use duration_to_sec_usec to do proper
3365 overflow checking on durations.
dde14581
PE
3366 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3367 Don't assume pid_t fits in int.
02481186
PE
3368 * process.h (struct Lisp_Process): Members tick and update_tick
3369 are now of type EMACS_INT, not int.
b62b53e8
PE
3370 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3371 configured --with-wide-int.
d311d28c
PE
3372 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3373 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3374 * search.c (looking_at_1, string_match_1):
3375 (fast_string_match, fast_c_string_match_ignore_case)
3376 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3377 (scan_newline, find_before_next_newline, search_command)
3378 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3379 (set_search_regs, wordify):
3380 (Freplace_match):
3381 (Fmatch_data):
3382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3383 (string_match_1, search_buffer, set_search_regs):
3384 (Fmatch_data):
3385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 (wordify): Check for overflow in size calculation.
3387 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3388 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3389 Check that fixnums are in proper range for system types.
3390 * sound.c (struct sound_device)
3391 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3393 (Fplay_sound_internal):
3394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3395 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3396 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3397 (Fparse_partial_sexp):
3398 Don't assume fixnums can fit in int.
3399 (struct lisp_parse_state, find_start_pos, find_start_value)
3400 (find_start_value_byte, find_start_begv)
3401 (update_syntax_table, char_quoted, dec_bytepos)
3402 (find_defun_start, prev_char_comend_first, back_comment):
3403 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3404 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3406 (Finternal_describe_syntax_value): Check that match_lisp is a
3407 character, not an integer, since the code stuffs it into int.
3408 (scan_words, scan_sexps_forward):
3409 Check that fixnums are in proper range for system types.
3410 (Fforward_word):
3411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3412 (scan_sexps_forward):
3413 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3414 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3415 * syntax.h: Adjust decls to match defn changes elsewhere.
3416 (struct gl_state_s):
3417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3418 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3419 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3420 * sysdep.c (wait_for_termination_1, wait_for_termination)
3421 (interruptible_wait_for_termination, mkdir):
3422 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3423 (emacs_read, emacs_write):
3424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3425 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3426 and double all fit in int.
d311d28c
PE
3427 * term.c (set_tty_color_mode):
3428 Check that fixnums are in proper range for system types.
3429 * termhooks.h (struct input_event):
3430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3431 * textprop.c (validate_interval_range, interval_of)
3432 (Fadd_text_properties, set_text_properties_1)
3433 (Fremove_text_properties, Fremove_list_of_text_properties)
3434 (Ftext_property_any, Ftext_property_not_all)
3435 (copy_text_properties, text_property_list, extend_property_ranges)
3436 (verify_interval_modification):
3437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3438 (Fnext_single_char_property_change)
3439 (Fprevious_single_char_property_change):
3440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3441 (copy_text_properties):
3442 Check for integer overflow in index calculation.
d311d28c
PE
3443 * undo.c (last_boundary_position, record_point, record_insert)
3444 (record_delete, record_marker_adjustment, record_change)
3445 (record_property_change):
3446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3447 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3449 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3450 (Fx_hide_tip, Fx_file_dialog):
3451 * w32menu.c (set_frame_menubar):
3452 Use ptrdiff_t, not int, for consistency with rest of code.
3453 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3454 (select_window, Fdelete_other_windows_internal)
3455 (window_scroll_pixel_based, window_scroll_line_based)
3456 (Frecenter, Fset_window_configuration):
3457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3458 (Fset_window_hscroll, run_window_configuration_change_hook)
3459 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3460 (Fscroll_other_window, Frecenter):
d311d28c
PE
3461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3462 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3463 Don't assume fixnum fits in int.
3464 (Fset_window_scroll_bars):
3465 Check that fixnums are in proper range for system types.
3466 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3467 (string_pos, c_string_pos, number_of_chars, init_iterator)
3468 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3469 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3470 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3471 (face_before_or_after_it_pos, handle_invisible_prop)
3472 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3473 (display_prop_intangible_p, string_buffer_position_lim)
3474 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3475 (get_overlay_strings_1, get_overlay_strings)
3476 (iterate_out_of_display_property, forward_to_next_line_start)
3477 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3478 (get_next_display_element, set_iterator_to_next)
3479 (get_visually_first_element, compute_stop_pos_backwards)
3480 (handle_stop_backwards, next_element_from_buffer)
3481 (move_it_in_display_line_to, move_it_in_display_line)
3482 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3483 (add_to_log, message_dolog, message_log_check_duplicate)
3484 (message2, message2_nolog, message3, message3_nolog
3485 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3486 (current_message_1, truncate_echo_area, truncate_message_1)
3487 (set_message, set_message_1, store_mode_line_noprop)
3488 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3489 (text_outside_line_unchanged_p, check_point_in_composition)
3490 (reconsider_clip_changes)
3491 (redisplay_internal, set_cursor_from_row, try_scrolling)
3492 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3493 (redisplay_window, find_last_unchanged_at_beg_row)
3494 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3495 (trailing_whitespace_p, find_row_edges, display_line)
3496 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3497 (display_mode_element, store_mode_line_string)
3498 (pint2str, pint2hrstr, decode_mode_spec)
3499 (display_count_lines, display_string, draw_glyphs)
3500 (x_produce_glyphs, x_insert_glyphs)
3501 (rows_from_pos_range, mouse_face_from_buffer_pos)
3502 (fast_find_string_pos, mouse_face_from_string_pos)
3503 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3505 (safe_call, init_from_display_pos, handle_fontified_prop)
3506 (handle_single_display_spec, load_overlay_strings)
3507 (with_echo_area_buffer, setup_echo_area_for_printing)
3508 (display_echo_area, echo_area_display)
3509 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3510 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3511 (redisplay_window, dump_glyph_row, display_mode_line)
3512 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3513 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3515 (handle_single_display_spec, build_desired_tool_bar_string)
3516 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3517 (get_specified_cursor_type):
3518 Check that fixnums are in proper range for system types.
3519 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3520 (Flookup_image_map):
3521 Don't assume fixnums fit in int.
3522 (compare_overlay_entries):
3523 Avoid mishandling comparisons due to subtraction overflow.
3524 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3525 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3526 (handle_tool_bar_click):
3527 Use int, not unsigned, since we prefer signed and the signedness
3528 doesn't matter here.
3529 (get_next_display_element, next_element_from_display_vector):
3530 Use int, not EMACS_INT, when int is wide enough.
3531 (start_hourglass): Use duration_to_sec_usec to do proper
3532 overflow checking on durations.
3533 * xfaces.c (Fbitmap_spec_p):
3534 Check that fixnums are in proper range for system types.
3535 (compare_fonts_by_sort_order):
3536 Avoid mishandling comparisons due to subtraction overflow.
3537 (Fx_family_fonts, realize_basic_faces):
3538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3539 (Fx_family_fonts):
3540 Don't assume fixnum fits in int.
3541 Use SAFE_ALLOCA_LISP, not alloca.
3542 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3543 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3544 (face_at_buffer_position, face_for_overlay_string)
3545 (face_at_string_position):
3546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3547 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3548 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3549 (Fx_show_tip):
3550 Check that fixnums are in proper range for system types.
3551 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3552 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3554 (Fx_change_window_property): Don't assume fixnums fit in int.
3555 * xfont.c (xfont_chars_supported):
3556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3557 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3558 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3560 * xml.c (parse_region):
3561 * xrdb.c (magic_file_p):
3562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3563 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3564 (x_get_local_selection, x_reply_selection_request)
3565 (x_handle_selection_request, wait_for_property_change):
3566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3567 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3568 short is wide enough.
3569 (x_send_client_event): Don't assume fixnum fits in int.
3570 * xterm.c (x_x_to_emacs_modifiers):
3571 Don't assume EMACS_INT overflows nicely into int.
3572 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3573 may come from Lisp.
3574 (handle_one_xevent): NATNUMP can eval its arg twice.
3575 (x_connection_closed):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 * xterm.h: Adjust decls to match defn changes elsewhere.
3578 (struct scroll_bar): Use struct vectorlike_header
3579 rather than rolling our own approximation.
3580 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3581
c6574eb5
GM
35822012-05-25 Glenn Morris <rgm@gnu.org>
3583
3584 * lisp.mk (lisp): Update for more files being compiled now.
3585
e8d32c7e
SM
35862012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3587
48def666
SM
3588 * lread.c: Remove `read_pure' which makes no difference.
3589 (read_pure): Remove var.
3590 (unreadpure): Remove function.
3591 (readevalloop): Don't call read_list with -1 flag.
3592 (read1, read_vector): Don't test read_pure any more.
3593 (read_list): Simplify.
3594
e8d32c7e
SM
3595 * fileio.c, character.h: Minor style tweaks.
3596
4b2addb7
DA
35972012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3598
3599 * window.h (clip_changed): Remove useless declaration.
3600
584461b2
JB
36012012-05-22 Juanma Barranquero <lekktu@gmail.com>
3602
3603 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3604 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3605
34374650
PE
36062012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 Remove src/m/*.
3609 This directory predates autoconf and is no longer needed nowadays.
3610 Move its few remaining bits of functionality to where they're needed.
3611 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3612 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3613 * m/template.h: Remove.
3614 * Makefile.in (M_FILE): Remove. All uses removed.
3615 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3616 * lisp.h (USE_LSB_TAG):
3617 * mem-limits.h (EXCEEDS_LISP_PTR):
3618 Use VAL_MAX, not VALBITS, in #if.
3619 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3620 (EMACS_UINT): Define unconditionally now.
3621 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3622 (BITS_PER_EMACS_INT): New constants, replacing
3623 what used to be in config.h, but not useful in #if.
3624 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3625 define them any more.
3626 (VAL_MAX): New macro.
3627 (VALMASK): Use it.
3628 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3629 BITS_PER_EMACS_INT, in #if.
3630 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3631 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3632 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3633 * s/ms-w32.h (DATA_START):
3634 Move here from removed file m/intel386.h.
3635 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3636 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3637
261cb4bb
PE
36382012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3639
3640 Assume C89 or later.
3641 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3642 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3643 (xrealloc):
3644 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3645 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3646 * textprop.c, tparam.c (NULL): Remove.
3647 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3648 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3649 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3650 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3651 * xterm.c (input_signal_count): Assume volatile works.
3652
ff23cd9f
KB
36532012-05-21 Ken Brown <kbrown@cornell.edu>
3654
3655 * xgselect.c (xg_select): Fix first argument in call to 'select'
3656 (bug#11508).
3657
1b170bc6
KB
36582012-05-20 Ken Brown <kbrown@cornell.edu>
3659
3660 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3661 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3662
b2f4d39f
KB
36632012-05-19 Ken Brown <kbrown@cornell.edu>
3664
3665 * xfns.c (x_in_use): Remove `static' qualifier.
3666 * xterm.h (x_in_use): Declare.
3667 * xgselect.c: Include xterm.h.
3668 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3669 and `display_arg' (bug#9754).
3670
003fdae2
PE
36712012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3672
9232a6d9
PE
3673 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3674
003fdae2
PE
3675 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3676 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3677
784b56e2
EZ
36782012-05-18 Eli Zaretskii <eliz@gnu.org>
3679
3680 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3681
3682 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3683 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3684
3685 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3686 reference to image_cache->refcount.
3687 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3688
a0a79cde
JL
36892012-05-17 Juri Linkov <juri@jurta.org>
3690
3691 * search.c (Fword_search_regexp, Fword_search_backward)
3692 (Fword_search_forward, Fword_search_backward_lax)
3693 (Fword_search_forward_lax): Move functions to isearch.el
3694 (bug#10145, bug#11381).
3695
b0572523
PE
36962012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3697
3698 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3699
9660f5fc
SM
37002012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3701
3702 * lread.c (init_obarray): Declare Qt and Qnil as special.
3703
4374de83
GM
37042012-05-14 Glenn Morris <rgm@gnu.org>
3705
3706 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3707 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3708
dc44c39a
PE
37092012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3710
078c97cb
PE
3711 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3712
dc44c39a
PE
3713 * unexaix.c: Port to more-recent AIX compilers.
3714 (report_error, report_error_1, make_hdr, copy_sym)
3715 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3716 Make arguments const char *, not char *, to avoid violations of C
3717 standard and to fix some AIX warnings reported by Gilles Pion.
3718
e18afed7 37192012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3720
3721 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3722 already have overlays loaded.
3723 (handle_single_display_spec): Before returning without displaying
3724 fringe bitmap, synchronize the bidi iterator with the main display
3725 iterator, by calling iterate_out_of_display_property.
3726 (iterate_out_of_display_property): Detect buffer iteration by
3727 testing that it->string is a Lisp string.
3728 (get_next_display_element): When the current object is exhausted,
3729 and there's something on it->stack, call set_iterator_to_next to
3730 proceed with what's on the stack, instead of returning zero.
3731 (set_iterator_to_next): If called at the end of a Lisp string,
3732 proceed to consider_string_end without incrementing string
3733 position. Don't increment display vector index past the end of
3734 the display vector. (Bug#11417)
c8fb9dc6
EZ
3735 (pos_visible_p): Don't report a position visible when move_it_to
3736 stopped at the last line of window, which happens to be scanned
3737 backwards by the bidi iteration. (Bug#11464)
ac268e67 3738
e18afed7 37392012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3740
3741 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3742 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3743 are on a TTY, and thus unable to display on the fringes.
3744 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3745 so we need to signal to the caller that this is a "replacing"
3746 display spec. This fixes display when the spec is invalid or we
3747 are on a TTY.
3748
e18afed7 37492012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3750
3751 * unexaix.c (make_hdr): Fix typo in prototype.
3752 This bug broke the build on AIX. Problem reported by Gilles Pion.
3753
9d0a235a
MA
37542012-05-14 Michael Albinus <michael.albinus@gmx.de>
3755
3756 * keyboard.c (kbd_buffer_get_event): Read special events also in
3757 batch mode. (Bug#11415)
3758
9e6b06ed
GM
37592012-05-12 Glenn Morris <rgm@gnu.org>
3760
3761 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3762
c1a1d7a3
EZ
37632012-05-12 Eli Zaretskii <eliz@gnu.org>
3764
3765 * lisp.mk (lisp): Add newcomment.elc.
3766
3fe7cdc8
GM
37672012-05-12 Glenn Morris <rgm@gnu.org>
3768
3769 * Makefile.in (MKDIR_P): New, set by configure.
3770 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3771
53f7d2c0
PE
37722012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3773
3774 Remove unused function hourglass_started.
3775 * dispextern.h (hourglass_started):
3776 * w32fns.c (hourglass_started):
3777 * xdisp.c (hourglass_started): Remove.
3778
75aafb17
JB
37792012-05-10 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3782 Update dependencies.
3783
12959e8e
PE
37842012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3785
97107e2e
PE
3786 * xgselect.c (xg_select): Put maxfds+1 into a var.
3787 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3788
12959e8e
PE
3789 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3790
836d29b3
DA
37912012-05-10 Dave Abrahams <dave@boostpro.com>
3792
3793 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3794 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3795
5cb67954
MA
37962012-05-09 Michael Albinus <michael.albinus@gmx.de>
3797
3798 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3799 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3800 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3801 Initialize xd_registered_buses.
3802
3478ec45
PE
38032012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3804
b263a6b0
PE
3805 Untag more efficiently if USE_LSB_TAG.
3806 This is based on a proposal by YAMAMOTO Mitsuharu in
3807 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3808 For an admittedly artificial (nth 8000 longlist) benchmark on
3809 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3810 Emacs's overall text size by 1%.
3811 * lisp.h (XUNTAG): New macro.
3812 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3813 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3814 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3815 * eval.c (Fautoload):
3816 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3817 * frame.h (XFRAME): Use XUNTAG.
3818
3478ec45
PE
3819 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3820 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3821 Remove unportable assumptions about print widths of types like
3822 dbus_uint32_t.
3823 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3824 intptr_t when converting between pointer and integer, to avoid GCC
3825 warnings about wrong width.
3826
666b903b 38272012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3828
3829 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3830 stack for each reader_thread, instead of defaulting to 8MB
3831 determined by the linker. This avoids failures in creating
3832 subprocesses on Windows 7, see the discussion in this thread:
3833 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3834
b120cc17
JC
38352012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3836
3837 Fix up display of the *Minibuf-0* buffer in the mini window.
3838 * keyboard.c (read_char): Don't clear the echo area if there's no
3839 message to clear.
3840 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3841 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3842
9a4b36f8
MA
38432012-05-07 Michael Albinus <michael.albinus@gmx.de>
3844
3845 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3846 batch mode.
3847
e5f9458f
CY
38482012-05-06 Chong Yidong <cyd@gnu.org>
3849
3850 * lisp.mk (lisp): Update.
3851
eceeb5fc 38522012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3853
3854 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3855
71873e2b
SM
38562012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3857
3858 * data.c (PUT_ERROR): New macro.
3859 (syms_of_data): Use it. Add new error type `user-error'.
3860 * undo.c (user_error): New function.
3861 (Fprimitive_undo): Use it.
3862 * print.c (print_error_message): Adjust print style for `user-error'.
3863 * keyboard.c (user_error): New function.
3864 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3865
ab0fa4e4
PE
38662012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3867
3868 Do not limit current-time-string to years 1000..9999.
3869 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3870 (Fcurrent_time_string): Support any year that is supported by the
3871 underlying localtime representation. Don't use asctime, as it
3872 has undefined behavior for years outside the range -999..9999.
3873
7ed806a7
PE
38742012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 Fix race conditions involving setenv, gmtime, localtime, asctime.
3877 Without this fix, interrupts could mess up code that uses these
3878 nonreentrant functions, since setting TZ invalidates existing
3879 tm_zone or tzname values, and since most of these functions return
3880 pointers to static storage.
3881 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3882 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3883 Grow the critical sections to include not just invoking
3884 localtime/gmtime, but also accessing these functions' results
3885 including their tm_zone values if any, and any related TZ setting.
3886 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3887 so that the struct tm is saved in the critical section.
3888 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3889 motivated by the fact that memory allocation needs to be outside
3890 the critical section.
3891
0c16dfed
DA
38922012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3893
3894 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3895 with RESET_INTERVAL.
3896
3897 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3898 Remove duplicated buffer name initialization.
3899
3f83ace8
JM
39002012-05-02 Jim Meyering <jim@meyering.net>
3901
3902 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3903
c7b8541e
JM
3904 * xfns.c (x_window): Use xstrdup (Bug#11375).
3905
90207a15 39062012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3907
3908 * xdisp.c (pos_visible_p): If already at a newline from the
3909 display string before the 'while' loop, don't walk back the glyphs
3910 from it3.glyph_row. Solves assertion violation when the display
3911 string begins with a newline (egg.el). (Bug#11367)
3912
b593d6a9
AH
39132012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3914
3915 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3916 Move to simple.el.
3917
4737362e
GM
39182012-05-01 Glenn Morris <rgm@gnu.org>
3919
99cf43f9
GM
3920 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3921 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3922 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3923 All were removed before 23.1.
3924
9311dcff
GM
3925 * dispnew.c: Remove HAVE_LIBNCURSES test;
3926 it is always true on relevant platforms.
3927
4d5c6349
GM
3928 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3929 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3930
4737362e
GM
3931 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3932
74dd3a6b
AS
39332012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3934
3935 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3936 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3937 Remove.
3938
13c379ee
PE
39392012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3940
3941 Do not avoid creating empty evaporating overlays (Bug#9642).
3942 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3943 That is, do not delete an evaporating overlay if it becomes
3944 empty after its bounds are adjusted to fit within its buffer.
3945 This fix caused other problems, and I'm reverting it until we get
3946 to the bottom of them.
3947
a8e7d6d7 39482012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3949
3950 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3951
a8e7d6d7 39522012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3953
3954 * xdisp.c (pos_visible_p): If the window start position is beyond
3955 ZV, start the display from buffer beginning. Prevents assertion
3956 violation in init_iterator when the minibuffer window is scrolled
3957 via the scroll bar.
3958
3959 * window.c (window_scroll_pixel_based): Likewise.
3960
a8e7d6d7 39612012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3962
3963 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3964
a8e7d6d7 39652012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3966
3967 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3968 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3969
a8e7d6d7 39702012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3971
b593d6a9
AH
3972 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3973 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3974
1c6900d9
EZ
39752012-04-26 Eli Zaretskii <eliz@gnu.org>
3976
4c3fa1d9
EZ
3977 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3978 display element, check also the underlying string or buffer
3979 character. (Bug#11341)
3980
1c6900d9
EZ
3981 * w32menu.c: Include w32heap.h.
3982 (add_menu_item): If the call to AppendMenuW (via
3983 unicode_append_menu) fails, disable Unicode menus only if we are
3984 running on Windows 9X/Me.
3985
42bf8205
AS
39862012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3987
3988 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3989 (xgetint): Add missing shift for LSB tags.
3990
b1bac16e
MR
39912012-04-24 Martin Rudalics <rudalics@gmx.at>
3992
3993 * keyboard.c (read_char): Don't wipe echo area for select window
3994 events: These might get delayed via `mouse-autoselect-window'
3995 (Bug#11304).
3996
d69621cc
JB
39972012-04-24 Juanma Barranquero <lekktu@gmail.com>
3998
3999 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4000 manipulation of :loaded-from data.
4001
02fd101b
JB
40022012-04-23 Juanma Barranquero <lekktu@gmail.com>
4003
4004 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4005 now a cons (bug#11311).
4006
888bec30
PE
40072012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4008
89a438bd
PE
4009 Do not create empty overlays with the evaporate property (Bug#9642).
4010 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4011 if it becomes empty after its bounds are adjusted to fit within
4012 its buffer. Without this fix, in a nonempty buffer (let ((o
4013 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4014 yields an empty overlay that has the evaporate property, which is
4015 not supposed to happen.
4016
1068fe4d
PE
4017 Fix minor GTK3 problems found by static checking.
4018 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4019 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4020 (struct _EmacsFixedClass, emacs_fixed_get_type):
4021 Move decls here from emacsgtkfixed.h, since they needn't be public.
4022 (emacs_fixed_get_type): Now static.
4023 (emacs_fixed_class_init): Omit unused local.
4024 (emacs_fixed_child_type): Remove; unused.
4025 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4026 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4027 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4028 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4029 (EMACS_FIXED_GET_CLASS): Remove; unused.
4030 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4031
888bec30
PE
4032 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4033 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4034
de85e130
PE
40352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4036
d0baac98 4037 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4038 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4039 (__malloc_size_t, __malloc_ptrdiff_t):
4040 Remove. All uses removed, replaced by the definiens if needed,
4041 since we can assume C89 or better now.
4042 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4043 (protect_malloc_state, align, get_contiguous_space)
4044 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4045 (malloc_atfork_handler_child, malloc_enable_thread)
4046 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4047 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4048 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4049 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4050 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4051 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4052 Define using prototypes, not old style.
4053 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4054 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4055 (align): Don't assume that signed integer overflow wraps around.
4056 Omit unused local var.
4057 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4058 (_free_internal_nolock, memalign, mallochook, reallochook):
4059 Omit no-longer-needed casts.
4060 (valloc): Use getpagesize, not __getpagesize.
4061 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4062 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4063
de85e130
PE
4064 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4065
dcbf5805
MA
40662012-04-22 Michael Albinus <michael.albinus@gmx.de>
4067
4068 Move functions from C to Lisp. Make non-blocking method calls
4069 the default. Implement further D-Bus standard interfaces.
4070
4071 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4072 (QCdbus_request_name_allow_replacement)
4073 (QCdbus_request_name_replace_existing)
4074 (QCdbus_request_name_do_not_queue)
4075 (QCdbus_request_name_reply_primary_owner)
4076 (QCdbus_request_name_reply_in_queue)
4077 (QCdbus_request_name_reply_exists)
4078 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4079 (QCdbus_registered_serial, QCdbus_registered_method)
4080 (QCdbus_registered_signal): New Lisp objects.
4081 (XD_DEBUG_MESSAGE): Use sizeof.
4082 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4083 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4084 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4085 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4086 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4087 (xd_signature, xd_append_arg): Allow float for integer types.
4088 (xd_get_connection_references): New function.
b593d6a9
AH
4089 (xd_get_connection_address): Rename from xd_initialize.
4090 Return cached address.
dcbf5805
MA
4091 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4092 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4093 level.
4094 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4095 Return number of refcounts.
dcbf5805
MA
4096 (Fdbus_get_unique_name): Make stronger parameter check.
4097 (Fdbus_message_internal): New defun.
4098 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4099 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4100 (Fdbus_send_signal, Fdbus_register_service)
4101 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4102 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4103 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4104 (Vdbus_compiled_version, Vdbus_runtime_version)
4105 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4106 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4107 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4108 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4109 Adapt docstring.
dcbf5805 4110
52828e02
PE
41112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4112
da05bc4c
PE
4113 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4114 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4115 Do not assume ptrdiff_t is the same width as 'int'.
4116
52828e02
PE
4117 * alloc.c: Handle unusual debugging option combinations.
4118 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4119 since the two debugging options are incompatible.
4120 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4121 is defined.
4122 (mem_init, mem_insert, mem_insert_fixup):
4123 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4124 (NEED_MEM_INSERT): Remove; no longer needed.
4125
f01769f9
LL
41262012-04-22 Leo Liu <sdl.web@gmail.com>
4127
4128 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4129
5790543d
PE
41302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4131
4132 * sysdep.c [__FreeBSD__]: Minor cleanups.
4133 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4134 Use Emacs indenting style more consistently. Avoid some casts.
4135 Use 'double' consistently rather than mixing 'float' and 'double'.
4136
b91b7e4d
EW
41372012-04-21 Eduard Wiebe <usenet@pusto.de>
4138
b593d6a9
AH
4139 * sysdep.c (list_system_processes, system_process_attributes):
4140 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4141
6114eb15
AS
41422012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4143
4144 * lisp.mk (lisp): Update.
4145
2f38dff7
PE
41462012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4149 It is never used otherwise.
4150
4ae29f89
SM
41512012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4152
4153 * print.c (print_preprocess): Only check print_depth if print-circle
4154 is nil.
4155 (print_object): Check for cycles even when print-circle is nil and
4156 print-gensym is t, but only check print_depth if print-circle is nil.
4157
f30d612a
CY
41582012-04-20 Chong Yidong <cyd@gnu.org>
4159
4160 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4161 set the status to "failed" and ensure that sentinel is run.
4162
c07a4c0b 41632012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4164
4165 * process.c (Fset_process_inherit_coding_system_flag)
4166 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4167 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4168
c07a4c0b 41692012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4170
4171 * xdisp.c (string_buffer_position_lim): Limit starting position to
4172 BEGV.
4173 (set_cursor_from_row): If called for a mode-line or header-line
4174 row, return zero immediately.
4175 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4176 farther than the first row after the header line, if any.
4177 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4178 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4179
c07a4c0b 41802012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4181
4ae29f89
SM
4182 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4183 (bug#11238).
ad3a2b41 4184
c07a4c0b 41852012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 41862012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4187
4188 configure: new option --enable-gcc-warnings (Bug#11207)
4189 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4190 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4191 (ALL_CFLAGS): Use new macros rather than old.
4192 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4193 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4194 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4195 -Wunused-result, -Wunused-variable. This should go away once
4196 the Emacs and Gnulib regex code is merged.
4197 (xmalloc, xrealloc): Now static.
4198
aba027e8
PE
41992012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4200
4201 * dired.c (Fsystem_groups): Remove unused local.
4202
e5a36063
GM
42032012-04-17 Glenn Morris <rgm@gnu.org>
4204
4205 * dired.c (Fsystem_users): Doc fix.
4206
316411f0
DA
42072012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4208
4209 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4210 (syms_of_dired): Add them.
4211
9426aba4
PE
42122012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4213
b62a57be
PE
4214 Fix minor alloc.c problems found by static checking.
4215 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4216 New extern decls, to avoid calling undeclared functions.
4217 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4218 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4219 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4220 (NEED_MEM_INSERT): New macro.
4221 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4222 Remove one incorrect comment and fix another.
b62a57be 4223
3539f31f
PE
4224 Fix minor ralloc.c problems found by static checking.
4225 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4226 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4227 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4228 (r_alloc_sbrk): Now static.
4229
a041960a
PE
4230 Improve ralloc.c interface checking.
4231 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4232 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4233 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4234 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4235 [REL_ALLOC]: ... to here, to check interface.
4236 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4237 Remove decls. This fixes an "It stinks!".
4238
9426aba4
PE
4239 * alloc.c (which_symbols): Fix alignment issue / type clash.
4240
d55c12ed
AS
42412012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4242
4243 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4244 (struct Lisp_Misc_Any): Likewise.
4245 (struct Lisp_Free): Likewise.
4246 * alloc.c (union aligned_Lisp_Symbol): Define.
4247 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4248 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4249 (union aligned_Lisp_Misc): Define.
4250 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4251 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4252 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4253
b948ce8b
PE
42542012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4255
4256 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4257 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4258 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4259 * s/netbsd.h, s/sol2-6.h:
4260 Remove definition of GC_MARK_STACK, since the default now works.
4261 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4262 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4263 no longer the default.
4264 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4265
35dc09a1 42662012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4267
35dc09a1
GM
4268 * lread.c (lisp_file_lexically_bound_p):
4269 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4270
35dc09a1
GM
42712012-04-14 Eli Zaretskii <eliz@gnu.org>
4272
4273 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4274 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4275
42762012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4277
4278 * nsterm.m (constrainFrameRect): Always constrain when there is only
4279 one screen (Bug#10962).
4280
bcd86815
KB
42812012-04-13 Ken Brown <kbrown@cornell.edu>
4282
4283 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4284
c25df26e
RT
42852012-04-13 Reuben Thomas <rrt@sc3d.org>
4286
4287 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4288
0fc59f1e
DC
42892012-04-11 Daniel Colascione <dancol@dancol.org>
4290
4291 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4292 against is gone. It's better to use vfork now so that when Cygwin
4293 gains a new, working vfork, we use it automatically (bug#10398).
4294
de8c03dc
SM
42952012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4296
4297 * window.c (save_window_save): Obey window-point-insertion-type.
4298
2f097256
GM
42992012-04-11 Glenn Morris <rgm@gnu.org>
4300
4301 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4302
453b951e
SM
43032012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4304
4305 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4306
75f1671a 43072012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4308
4309 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4310 (force_quit_count): New var.
4311 (handle_interrupt): Use it.
4312
2a8ce227
JB
43132012-04-10 Juanma Barranquero <lekktu@gmail.com>
4314
4315 * w32.c (w32_delayed_load): Record the full path of the library
4316 being loaded (bug#10424).
4317
935396c0
GM
43182012-04-09 Glenn Morris <rgm@gnu.org>
4319
05920a43
GM
4320 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4321 not just in the obarray, before snarfing them. (Bug#11036)
4322
935396c0
GM
4323 * Makefile.in ($(leimdir)/leim-list.el):
4324 Pass EMACS rather than BUILT_EMACS.
4325
a18ecafa
TZ
43262012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4327
4328 * process.c (make_process):
4329 * process.h: Add integer `gnutls_handshakes_tried' member to
4330 process struct.
4331
6bbef4e5
JC
4332 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4333 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4334
4335 * gnutls.c (gnutls_log_function2i): Convenience log function.
4336 (emacs_gnutls_read): Use new log functions,
4337 `gnutls_handshakes_tried' process member, and
4338 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4339 attempts per process (connection).
4340
b4d3bc10
CY
43412012-04-09 Chong Yidong <cyd@gnu.org>
4342
4343 * eval.c (Fuser_variable_p, user_variable_p_eh)
4344 (lisp_indirect_variable): Functions deleted.
4345 (Fdefvar): Caller changed.
4346
4347 * callint.c (Finteractive, Fcall_interactively):
4348 * minibuf.c (Fread_variable): Callers changed.
4349
70f4d973
EZ
43502012-04-09 Eli Zaretskii <eliz@gnu.org>
4351
4352 * xdisp.c (set_cursor_from_row): If the display string appears in
4353 the buffer at position that is closer to point than the position
4354 after the display string, display the cursor on the first glyph of
4355 the display string. Fixes cursor display when a 'display' text
4356 property immediately follows invisible text. (Bug#11094)
4357
cb3c2e3e
PE
43582012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4359
4360 composite.c: use 'double' consistently
4361 * composite.c (get_composition_id): Use 'double' consistently
4362 instead of converting 'float' to 'double' and vice versa; this is
4363 easier to understand and avoids a GCC warning.
4364
fd06db5d
GM
43652012-04-09 Glenn Morris <rgm@gnu.org>
4366
50fe702a
GM
4367 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4368 preparation for dumping it with emacs. (Bug#4789)
4369 (leimdir): New variable.
4370 ($(leimdir)/leim-list.el): New rule.
4371 (emacs$(EXEEXT)): Depend on leim-list.el.
4372
fd06db5d
GM
4373 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4374 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4375 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4376
55c131ee
AS
43772012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4378
4379 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4380 proper alignment.
4381
9209588f
JB
43822012-04-07 Juanma Barranquero <lekktu@gmail.com>
4383
4384 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4385 Remove unused local variable.
4386
e3fb2efb
PE
43872012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4388
4389 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4390 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4391 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4392 objects, as mark_maybe_pointer will catch them otherwise.
4393 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4394 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4395
b5385551
PE
43962012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4397
4398 Fix typo that broke non-Windows builds.
4399 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4400
9078ead6
EZ
44012012-04-07 Eli Zaretskii <eliz@gnu.org>
4402
4403 Support building on MS-Windows with libxml2.
4404
4405 * makefile.w32-in (OBJ2): Add xml.$(O).
4406 (GLOBAL_SOURCES): Add xml.c.
4407 ($(BLD)/xml.$(O)): New dependency list.
4408
4409 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4410 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4411 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4412 [!WINDOWSNT]: New macros.
4413 (init_libxml2_functions, libxml2_loaded_p): New functions.
4414 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4415 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4416 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4417 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4418 linked in).
6bbef4e5
JC
4419 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4420 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4421 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4422
4423 * emacs.c: Don't include libxml/parser.h.
4424 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4425 xmlCleanupParser directly.
4426
4427 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4428
3811fdf3
EZ
44292012-04-07 Eli Zaretskii <eliz@gnu.org>
4430
4431 * indent.c (Fvertical_motion): If there is a display string at
4432 point, use it.vpos to compute how many lines to backtrack after
4433 move_it_to point. (Bug#11133)
4434
2f8e16b2
EZ
44352012-04-06 Eli Zaretskii <eliz@gnu.org>
4436
4437 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4438 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4439 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4440 macros related to unification of CJK characters. For the details,
4441 see the discussion following the message here:
4442 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4443
3d439cd1
CY
44442012-04-04 Chong Yidong <cyd@gnu.org>
4445
4446 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4447
8bc53d00
EZ
44482012-04-01 Eli Zaretskii <eliz@gnu.org>
4449
4450 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4451 instead of alloca. (Bug#11138)
4452
3b0512a3
AS
44532012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4454
4455 * w32menu.c (is_simple_dialog): Properly check lisp types.
4456 (Bug#11141)
4457
8427ddd2
EZ
44582012-03-31 Eli Zaretskii <eliz@gnu.org>
4459
979022ef
EZ
4460 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4461 position we get to after a call to move_it_to fails the
4462 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4463 only if we wind up in a string from display property. (Bug#11063)
4464
a6b1c7cc
EZ
4465 * window.c (Fdelete_other_windows_internal): Invalidate the row
4466 and column information about mouse highlight, so that redisplay
4467 restores it after reallocating the glyph matrices. (Bug#7464)
4468
8427ddd2
EZ
4469 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4470 string comes from a `display' text property, use the buffer
4471 position of that property as if we actually saw that position in
4472 the row's glyphs.
697ba24b
EZ
4473 (move_it_by_lines): Remove the assertion that
4474 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4475 violated when there's a before-string at the beginning of a line.
4476 (Bug#11063)
8427ddd2 4477
65a0a738
EZ
44782012-03-30 Eli Zaretskii <eliz@gnu.org>
4479
4480 * xdisp.c (append_space_for_newline): If the default face was
4481 remapped, use the remapped face for the appended newline.
4482 (extend_face_to_end_of_line): Use the remapped default face for
4483 extending the face to the end of the line.
4484 (display_line): Call extend_face_to_end_of_line when the default
4485 face was remapped. (Bug#11068)
4486
581355cc
EZ
44872012-03-29 Eli Zaretskii <eliz@gnu.org>
4488
4489 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4490
e8fc049f
SM
44912012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4492
4493 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4494
4fb9a543
GM
44952012-03-27 Glenn Morris <rgm@gnu.org>
4496
4497 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4498 Doc fixes.
4499
679910f1
KH
45002012-03-26 Kenichi Handa <handa@m17n.org>
4501
4502 * dispextern.h (struct glyph): Fix previous change. Change the
4503 bit length of glyphless.ch to 25 (Bug#11082).
4504
90d49b7f
CY
45052012-03-26 Chong Yidong <cyd@gnu.org>
4506
4507 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4508 (command_loop_1): Use it; inhibit selection update for
4509 handle-select-window too (Bug#8996).
4510
f514f6f0
FP
45112012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4512
e8fc049f 4513 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4514
bf43fa51
KH
45152012-03-25 Kenichi Handa <handa@m17n.org>
4516
4517 * dispextern.h (struct glyph): Change the bit length of
4518 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4519
8a0c01dd
EZ
45202012-03-24 Eli Zaretskii <eliz@gnu.org>
4521
4522 * s/ms-w32.h (tzname): Include time.h before redirecting to
4523 _tzname. Fixes the MSVC build. (Bug#9960)
4524
7d1c3a76
AS
45252012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4526
8ed79523
AS
4527 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4528 characters.
4529
7d1c3a76
AS
4530 * xterm.c (XTread_socket): Only modify handling_signal if
4531 !SYNC_INPUT. (Bug#11080)
4532
e99a9b8b
EZ
45332012-03-23 Eli Zaretskii <eliz@gnu.org>
4534
4535 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4536 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4537 when fetching a multibyte character consumes more bytes than
4538 CHAR_BYTES returns, due to unification of CJK characters in
4539 string_char. (Bug#11073)
4540
5063c0e1
TN
45412012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4542
4543 * process.c (wait_reading_process_output): Handle pty disconnect
4544 by refraining from sending oneself a SIGCHLD (bug#10933).
4545
9f851fbd
CY
45462012-03-22 Chong Yidong <cyd@gnu.org>
4547
4548 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4549
5063c0e1 4550 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4551 Mark string as coming from a prefix property.
4552 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4553 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4554
fb5b8aca
CY
45552012-03-21 Chong Yidong <cyd@gnu.org>
4556
4557 * xfaces.c (Vface_remapping_alist): Doc fix.
4558
62356a1b
EZ
45592012-03-20 Eli Zaretskii <eliz@gnu.org>
4560
4561 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4562 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4563 Doc fixes.
62356a1b 4564
025de85b
CY
45652012-03-20 Chong Yidong <cyd@gnu.org>
4566
4567 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4568 to reflect default non-nil value of redisplay-dont-pause.
4569
4827f94e
KH
45702012-03-19 Kenichi Handa <handa@m17n.org>
4571
4572 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4573 it fit in a valid range (Bug#11003).
4574
e50a24a2
EZ
45752012-03-18 Eli Zaretskii <eliz@gnu.org>
4576
4577 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4578 that is not from display property, accept the row as a "cursor
4579 row" if one of the string's character has a non-nil `cursor'
4580 property. Fixes cursor positioning when there are newlines in
4581 overlay strings, e.g. in icomplete.el. (Bug#11035)
4582
9af5ed87
PE
45832012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4584
4585 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4586
d1f55f16
CY
45872012-03-12 Chong Yidong <cyd@gnu.org>
4588
4589 * eval.c (inhibit_lisp_code): Rename from
4590 inhibit_window_configuration_change_hook; move from window.c.
4591
4592 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4593 * window.c (run_window_configuration_change_hook)
4594 (syms_of_window): Callers changed.
4595
66c5eebd
CY
45962012-03-11 Chong Yidong <cyd@gnu.org>
4597
413df973
CY
4598 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4599
66c5eebd
CY
4600 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4601
1de11f56
CY
46022012-03-10 Chong Yidong <cyd@gnu.org>
4603
4604 * frame.c (other_visible_frames): Don't assume the selected frame
4605 is visible (Bug#10955).
4606
cae07000
SM
46072012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4608
4609 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4610
89c94350
JD
46112012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4612
4613 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4614 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4615 zero (Bug#10954).
4616
999dd333
GM
46172012-03-03 Glenn Morris <rgm@gnu.org>
4618
01a6dcc8 4619 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4620
de0100f2
EZ
46212012-03-02 Eli Zaretskii <eliz@gnu.org>
4622
4623 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4624 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4625 (redisplay_window, next_element_from_string): Fix typos in
4626 comments.
3e441275
EZ
4627 (redisplay_window): Pass to move_it_vertically the margin in
4628 pixels, not in screen lines.
de0100f2 4629
96a72ee9
GM
46302012-03-02 Glenn Morris <rgm@gnu.org>
4631
4632 * buffer.c (buffer-list-update-hook): Doc fix.
4633
312508d7
EZ
46342012-02-29 Eli Zaretskii <eliz@gnu.org>
4635
4636 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4637 push_it before setting up the iterator for the first overlay
4638 string, even if we have an empty string loaded.
4639 (next_overlay_string): If there's an empty string on the iterator
4640 stack, pop the stack. (Bug#10903)
4641
27f3c637
PE
46422012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4643
4644 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4645 Suggested by Stefan Monnier in
4646 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4647 * alloc.c (widen_to_Lisp_Object): New static function.
4648 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4649 and widening them to Lisp_Objects. This would work even if
4650 USE_LSB_TAG is defined and wide integers are used, which might
4651 happen in a future version of Emacs.
4652
3c9dfce6
CY
46532012-02-25 Chong Yidong <cyd@gnu.org>
4654
fa74b241
CY
4655 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4656 Doc fix.
4657
3c9dfce6
CY
4658 * xselect.c (Fx_selection_exists_p): Doc fix.
4659 (x_clipboard_manager_save_all): Print an informative message
4660 before saving to clipboard manager.
4661
9486df08
CY
46622012-02-24 Chong Yidong <cyd@gnu.org>
4663
4664 * keyboard.c (process_special_events): Handle all X selection
4665 requests in kbd_buffer, not just the next one (Bug#8869).
4666
f01d3321
CY
46672012-02-23 Chong Yidong <cyd@gnu.org>
4668
4669 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4670 call when setting menu-bar-lines and tool-bar-lines parameters.
4671 (unwind_create_frame_1): New helper function.
4672
4673 * window.c (inhibit_window_configuration_change_hook): New var.
4674 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4675 (syms_of_window): Initialize it.
f01d3321 4676
86b847b6
CY
46772012-02-22 Chong Yidong <cyd@gnu.org>
4678
4679 * xterm.c (x_draw_image_relief): Add missing type check for
4680 Vtool_bar_button_margin (Bug#10743).
4681
a59225b1
CY
46822012-02-21 Chong Yidong <cyd@gnu.org>
4683
4684 * fileio.c (Vfile_name_handler_alist): Doc fix.
4685
4686 * buffer.c (Fget_file_buffer): Protect against invalid file
4687 handler return value.
4688
310f5bd4
PE
46892012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4690
cb3a28cc
PE
4691 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4692 when computing $valmask.
4693
310f5bd4
PE
4694 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4695 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4696 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4697 It's useless in that case, and it can cause problems on hosts
4698 that allocate halves of EMACS_INT values separately.
4699 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4700 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4701 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4702 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4703 it avoids undefined behavior on hosts where shifting right by more
4704 than the word width has undefined behavior.
4705
2375c96a
CY
47062012-02-19 Chong Yidong <cyd@gnu.org>
4707
4708 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4709 (Funhandled_file_name_directory, Ffile_name_as_directory)
4710 (Fdirectory_file_name, Fexpand_file_name)
4711 (Fsubstitute_in_file_name): Protect against invalid file handler
4712 return values (Bug#10845).
4713
3eb49e71
EZ
47142012-02-18 Eli Zaretskii <eliz@gnu.org>
4715
4716 * .gdbinit (pitx): Fix incorrect references to fields of the
4717 iterator stack.
4718
7b926f3f
CY
47192012-02-17 Chong Yidong <cyd@gnu.org>
4720
4721 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4722
11273115
PE
47232012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4726 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4727
c3a70e2b
CY
47282012-02-15 Chong Yidong <cyd@gnu.org>
4729
4730 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4731 marked as special. Also, starting docstrings with * is obsolete.
4732
0ca43699
AS
47332012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4734
4735 * gnutls.c (emacs_gnutls_write): Fix last change.
4736
2e8f3c56
LI
47372012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4738
4739 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4740 send_process.
4741
af70074f
SM
47422012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4743
4744 * keymap.c (Fsingle_key_description): Handle char ranges.
4745
95986d52
CY
47462012-02-12 Chong Yidong <cyd@gnu.org>
4747
afd83bd1
CY
4748 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4749 as that creates a dangerous corner case.
4750
95986d52
CY
4751 * window.c (Fdelete_window_internal): Invalidate the mouse
4752 highlight (Bug#9904).
4753
bd7da63e
GM
47542012-02-12 Glenn Morris <rgm@gnu.org>
4755
4756 * xselect.c (Fx_own_selection_internal)
4757 (Fx_get_selection_internal, Fx_disown_selection_internal)
4758 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4759 * nsselect.m (Fx_own_selection_internal)
4760 (Fx_disown_selection_internal, Fx_selection_exists_p)
4761 (Fx_selection_owner_p, Fx_get_selection_internal):
4762 Sync docs and argument specs with the xselect.c versions.
4763
77abcbc2
LI
47642012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4765
4766 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4767
90b671e2
EZ
47682012-02-11 Eli Zaretskii <eliz@gnu.org>
4769
1c0ca0b7
EZ
4770 * w32select.c (Fx_selection_exists_p): Sync doc string and
4771 argument list with xselect.c. (Bug#10783)
4772
4773 * w16select.c (Fx_selection_exists_p): Sync doc string and
4774 argument list with xselect.c. (Bug#10783)
90b671e2 4775
49241268
GM
47762012-02-10 Glenn Morris <rgm@gnu.org>
4777
4778 * fns.c (Fsecure_hash): Doc fix.
4779
f998bbe7 47802012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4781
4782 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4783
0992bd9c
CY
47842012-02-07 Chong Yidong <cyd@gnu.org>
4785
4786 * buffer.c (Fbuffer_local_variables)
4787 (buffer_lisp_local_variables): Handle unbound vars correctly;
4788 don't let Qunbound leak into Lisp.
4789
af008560
GM
47902012-02-07 Glenn Morris <rgm@gnu.org>
4791
dd605cc4
GM
4792 * image.c (Fimagemagick_types): Doc fix.
4793
af008560
GM
4794 * image.c (imagemagick-render-type): Change it from a lisp object
4795 to an integer. Move the doc here from the lisp manual.
4796 Treat all values not equal to 0 the same.
4797
1449fa1d
CY
47982012-02-06 Chong Yidong <cyd@gnu.org>
4799
4800 * doc.c (store_function_docstring): Avoid applying docstring of
4801 alias to base function (Bug#2603).
4802
3723ec07
AS
48032012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4804
4805 * .gdbinit (pp1, pv1): Remove redundant defines.
4806 (pr): Use pp.
4807
79c1cc1e
CY
48082012-02-04 Chong Yidong <cyd@gnu.org>
4809
4810 * nsterm.m: Declare a global (Bug#10694).
4811
d7f29f8e
EZ
48122012-02-04 Eli Zaretskii <eliz@gnu.org>
4813
cae07000
SM
4814 * w32.c (get_emacs_configuration_options):
4815 Include --enable-checking, if specified, in the return value.
d7f29f8e 4816
3b95a6f9
MR
48172012-02-04 Martin Rudalics <rudalics@gmx.at>
4818
4819 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4820 after rounding frame sizes. (Bug#9723)
4821
d6fa96a6
EZ
48222012-02-04 Eli Zaretskii <eliz@gnu.org>
4823
4824 * keyboard.c (adjust_point_for_property): Don't position point
4825 before BEGV. (Bug#10696)
4826
df0b2940
PE
48272012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4828
4829 Handle overflow when computing char display width (Bug#9496).
4830 * character.c (char_width): Return EMACS_INT, not int.
4831 (char_width, c_string_width): Check for overflow when
4832 computing the width; this is possible now that individual
4833 characters can have unbounded width. Problem introduced
4834 by merge from Emacs 23 on 2012-01-19.
4835
6bee44d6
MA
48362012-02-02 Michael Albinus <michael.albinus@gmx.de>
4837
4838 * dbusbind.c (Fdbus_register_method): Mention the return value
4839 :ignore in the docstring.
4840
44f92739
GM
48412012-02-02 Glenn Morris <rgm@gnu.org>
4842
1b9f60cc
GM
4843 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4844
44f92739
GM
4845 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4846 Unconditionally set to t. (Bug#10673)
4847 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4848 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4849 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4850
c5d3843c
KH
48512012-02-02 Kenichi Handa <handa@m17n.org>
4852
4853 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4854 0, do not call append_composite_glyph.
4855
159462d4 48562012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4857
4858 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4859 NULL (Bug#6988).
4860 (x_produce_glyphs): If the component of a composition is a null
4861 string, set it->pixel_width to 1 to avoid zero-width glyph.
4862
78cef877
EZ
48632012-02-01 Eli Zaretskii <eliz@gnu.org>
4864
4865 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4866 first 2 arguments are identical. This makes inserting large
4867 output from a subprocess an order of magnitude faster on
4868 MS-Windows, where all sbrk'ed memory is always contiguous.
4869
97897668
GM
48702012-01-31 Glenn Morris <rgm@gnu.org>
4871
4872 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4873 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4874 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4875
31fd3586
GM
48762012-01-29 Glenn Morris <rgm@gnu.org>
4877
4878 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4879
0e24a8b2
CY
48802012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4881
4882 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4883
cc0adcb0
CY
48842012-01-28 Chong Yidong <cyd@gnu.org>
4885
4886 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4887
acc28cb9
CY
48882012-01-26 Chong Yidong <cyd@gnu.org>
4889
9c69cfb7
CY
4890 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4891
acc28cb9
CY
4892 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4893 repeat counts (Bug#10507).
4894
48da7392
GM
48952012-01-26 Glenn Morris <rgm@gnu.org>
4896
4897 * lread.c (syms_of_lread): Doc fix.
4898
14af5f7f
CY
48992012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4900
4901 * coding.c (encode_designation_at_bol): Change return value to
4902 EMACS_INT.
4903
0b21c100
CY
49042012-01-25 Chong Yidong <cyd@gnu.org>
4905
4906 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4907
3c2907f7
CY
49082012-01-21 Chong Yidong <cyd@gnu.org>
4909
4910 * floatfns.c (Fcopysign): Make the second argument non-optional,
4911 since nil is not allowed anyway.
4912
959ad23f
AS
49132012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4914
4915 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4916 (send_process): Likewise.
4917
34a02f46
MR
49182012-01-19 Martin Rudalics <rudalics@gmx.at>
4919
4920 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4921 (Vwindow_persistent_parameters): Do not use Qstate.
4922 Rewrite doc-strings.
34a02f46 4923
1259009a 49242012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4925
4926 * character.c (char_width): New function.
70d4fdf6
GM
4927 (Fchar_width, c_string_width, lisp_string_width):
4928 Use char_width (Bug#9496).
25ed9e61 4929
6a6ee00d
MR
49302012-01-16 Martin Rudalics <rudalics@gmx.at>
4931
4932 * window.c (Vwindow_persistent_parameters): New variable.
4933 (Fset_window_configuration, save_window_save): Handle persistent
4934 window parameters.
4935
c85efaf7
EZ
49362012-01-14 Eli Zaretskii <eliz@gnu.org>
4937
4938 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4939 thrashing the stack of the thread. (Bug#9087)
4940
5944709e
PE
49412012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4942
4943 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4944
e71f5d99
EZ
49452012-01-11 Eli Zaretskii <eliz@gnu.org>
4946
4947 * xdisp.c (rows_from_pos_range): Handle the case where the
4948 highlight ends on a newline. (Bug#10464)
4949 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4950 he end column for display of highlight that ends on a newline
4951 before a R2L line.
4952
ce316182
GM
49532012-01-11 Glenn Morris <rgm@gnu.org>
4954
4955 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4956 from load-path also when installation-directory is nil. (Bug#10208)
4957
5b43da69
GM
49582012-01-10 Glenn Morris <rgm@gnu.org>
4959
74cc8ff9
GM
4960 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4961
7d8d6e4e
GM
4962 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4963 Update template values to be closer to their typical values these days.
5b43da69 4964
a0db8d43
EZ
49652012-01-09 Eli Zaretskii <eliz@gnu.org>
4966
4967 * xdisp.c (rows_from_pos_range): Accept additional argument
4968 DISP_STRING, and accept any glyph in a row whose object is that
4969 string as eligible for mouse highlight. Fixes mouse highlight of
4970 display strings from overlays. (Bug#10464)
4971
9a0115ab 49722012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4973
b9110d6a 4974 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4975 * fileio.c (auto_saving_dir_umask): New static var.
4976 (Fmake_directory_internal): Use it.
4977 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4978 creating the directory. The old code temporarily assigns
4979 too-generous permissions to the directory.
4980 (do_auto_save_eh): Clear it.
b9110d6a 4981 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4982 that the var is always cleared.
4983
6c1bd3f3
EZ
49842012-01-07 Eli Zaretskii <eliz@gnu.org>
4985
4986 * search.c (scan_buffer): Pass character positions to
4987 know_region_cache, not byte positions. (Bug#6540)
4988
069d2b50
L
49892012-01-07 LynX <_LynX@bk.ru> (tiny change)
4990
4991 * w32.c (sys_rename): Report EXDEV when rename of a directory
4992 fails because the target is on another logical disk. (Bug#10284)
4993
75bf0d33
DB
49942012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4995
4996 * xterm.c (x_embed_request_focus): New function.
4997
4998 * xterm.h: Add prototype.
4999
5000 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5001
1c6e5a32
GM
50022012-01-05 Glenn Morris <rgm@gnu.org>
5003
5004 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5005
651e947e
EZ
50062012-01-01 Eli Zaretskii <eliz@gnu.org>
5007
5008 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5009 Load gnutls_transport_set_lowat only if GnuTLS version is below
5010 2.11.1.
5011 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5012 GnuTLS versions below 2.11.1.
5013
3778cdd8
AL
50142011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5015
5016 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5017 to the doc string advising against its use for altering the way
5018 windows are scrolled.
5019
0e5317f7
KH
50202011-12-28 Kenichi Handa <handa@m17n.org>
5021
5022 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5023 coding-system ASCII compatible only when it does not produce BOM
5024 on encoding (Bug#10383).
5025
93d5ca1f
JD
50262011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5027
5028 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5029 can scroll.
5030 (create_and_show_popup_menu): Always use menu_position_func for
5031 Gtk3 (Bug#10361).
5032
ca22b785
AS
50332011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5034
5035 * callint.c (Fcall_interactively): Don't truncate prompt string.
5036
d048e1e6
EZ
50372011-12-23 Eli Zaretskii <eliz@gnu.org>
5038
5039 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5040 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5041 resumed from there (after widening). (Bug#10360)
d048e1e6 5042
5ccaba1f
JD
50432011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5044
5045 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5046
204ee57f
JD
50472011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5048
b81d40f0
JB
5049 * nsterm.m (x_free_frame_resources):
5050 Release f->output_data.ns->miniimage.
204ee57f
JD
5051 (ns_index_color): Fix indentation. Do not retain
5052 color_table->colors[i].
5053
5054 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5055 before returning.
5056
5057 * nsfns.m (x_set_background_color): Assign return value from
5058 ns_index_color to face-background instead of NSColor*.
5059 (ns_implicitly_set_icon_type): Fix indentation.
5060 Change assignment in for loop to comparison.
5061
5062 * emacs.c (ns_pool): New variable.
5063 (main): Assign ns_pool.
5064 (Fkill_emacs): Call ns_release_autorelease_pool.
5065
5066 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5067 autorelease fdesc, release fdAttrs and tdict.
5068 (ns_get_covering_families): Release charset.
5069 (ns_findfonts): Release NSFontDescriptor created with new.
5070 (ns_uni_to_glyphs): Fix indentation.
5071 (setString): Release attrStr before assigning new value.
5072
c803b2b7
JD
50732011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5074
678f4426
JD
5075 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5076 and NS_IMPL_COCOA.
5077 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5078 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5079
cd394be1 50802011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5081
5fecd5fc
JD
5082 * nsterm.m (ns_term_init): Subscribe for notifications
5083 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5084 to method trackingNotification in EmacsMenu.
5085
5086 * nsmenu.m (trackingMenu): New variable.
3771cb17 5087 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5088 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5089 from Aquamacs (Bug#7030).
678f4426
JD
5090
50912011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5092
c803b2b7
JD
5093 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5094 (symbol_to_nsstring): Fix indentation.
5095 (ns_symbol_to_pb): New function.
cae07000
SM
5096 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5097 (Fns_rotate_cut_buffers_internal): Remove.
5098 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5099 Fns_store_cut_buffer_internal.
5100 (ns_get_foreign_selection, Fx_own_selection_internal)
5101 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5102 (Fns_get_selection_internal, Fns_store_selection_internal):
5103 Use ns_symbol_to_pb and check if return value is nil.
5104 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5105 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5106 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5107 renamed to Sns_store_selection_internal.
5108 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5109 and remove this function.
5110 (ns_handle_selection_clear): Remove, never used.
5111 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5112 here.
5113
e1b01a3a
KB
51142011-12-17 Ken Brown <kbrown@cornell.edu>
5115
5116 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5117 GID is unknown (Bug#10257).
5118
2adb6e85
PE
51192011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5120
5121 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5122 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5123 which caused a build failure on GNU/Linux IA-64. This problem was
5124 introduced by my 2011-10-07 patch.
5125
d1d7b339
JL
51262011-12-15 Juri Linkov <juri@jurta.org>
5127
5128 * image.c (imagemagick_error): New function. (Bug#10112)
5129 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5130 Use `imagemagick_error' where ImageMagick functions return
5131 `MagickFalse'.
5132 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5133 proper order.
5134
100d5755
KH
51352011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5136
5137 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5138 fill background (Bug#8992).
5139
454592a6
MR
51402011-12-13 Martin Rudalics <rudalics@gmx.at>
5141
5142 * window.c (Vwindow_combination_resize)
5143 (Vwindow_combination_limit): Use t instead of non-nil in
5144 doc-strings.
61d4b438
MR
5145 (Vrecenter_redisplay): Add first sentence of doc-string on
5146 separate line.
53524d93 5147 (Frecenter): Fix doc-string typo.
454592a6 5148
3633e3aa
KH
51492011-12-11 Kenichi Handa <handa@m17n.org>
5150
5151 * coding.c (Funencodable_char_position): Pay attention to the
5152 buffer text relocation (Bug#9389).
5153
7b9d523a 51542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5155
7b9d523a
JD
5156 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5157 gtk_init (Bug#10100).
5158
b73189c6
EZ
51592011-12-10 Eli Zaretskii <eliz@gnu.org>
5160
5161 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5162 IT->string is nil. (Bug#10263)
5163
f7dfe5d6
JD
51642011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5165
83faebb4
JD
5166 * nsterm.h (x_free_frame_resources): Declare.
5167
f7dfe5d6
JD
5168 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5169 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5170
5171 * nsterm.h (ns_get_defaults_value): Declare.
5172
5173 * nsterm.m (ns_default): Call ns_get_defaults_value.
5174
7cd4e72c
EZ
51752011-12-09 Eli Zaretskii <eliz@gnu.org>
5176
5177 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5178 (Bug#10170)
5179
b34d7317
YM
51802011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5181
5182 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5183 that where the value of an _OBJC_* symbol points to is in the .bss
5184 section (Bug#10240).
5185
76470ad1
KH
51862011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5187
5188 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5189 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5190
745fff94
KH
51912011-12-08 Kenichi Handa <handa@m17n.org>
5192
5193 * ftfont.c (get_adstyle_property): Fix previous change
5194 (Bug#10233).
5195
6e44397c
JB
51962011-12-07 Juanma Barranquero <lekktu@gmail.com>
5197
5198 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5199 dirs from the default value of EMACSLOADPATH (bug#10208).
5200
7efa6272
GM
52012011-12-07 Glenn Morris <rgm@gnu.org>
5202
5203 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5204 installation and source directories as well. (Bug#10208)
5205
f6fc4d87
CY
52062011-12-06 Chong Yidong <cyd@gnu.org>
5207
5208 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5209
2bf26180
GM
52102011-12-06 Glenn Morris <rgm@gnu.org>
5211
5212 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5213 as an error, not just -1. (Bug#10217)
5214
3a6ad4f0
CY
52152011-12-05 Chong Yidong <cyd@gnu.org>
5216
5217 * keyboard.c (process_special_events): New function.
5218 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5219
75a3b399
PE
52202011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5221
5222 * coding.c (encode_designation_at_bol): Don't use uninitialized
5223 local variable (Bug#9318).
5224
c3c9e25e
KH
52252011-12-05 Kenichi Handa <handa@m17n.org>
5226
5227 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5228 return Qnil (Bug#8046, Bug#10193).
5229
5eb05ea3
KH
52302011-12-05 Kenichi Handa <handa@m17n.org>
5231
5232 * coding.c (encode_designation_at_bol): New args charbuf_end and
5233 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5234 (coding_set_source): Return how many bytes coding->source was
5235 relocated.
5236 (coding_set_destination): Return how many bytes
5237 coding->destination was relocated.
5238 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5239 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5240
52412011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5242
5243 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5244 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5245 macro (Bug#9318).
5246
52472011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5248
5249 The following changes are to fix Bug#9318.
5250
a79703f5 5251 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5252 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5253 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5254 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5255
7dbda6df
JB
52562011-12-05 Juanma Barranquero <lekktu@gmail.com>
5257
5258 * lisp.h (process_quit_flag): Fix external declaration.
5259
6d5eb5b0
SM
52602011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5261
5262 Don't macro-inline non-performance-critical code.
5263 * eval.c (process_quit_flag): New function.
5264 * lisp.h (QUIT): Use it.
5265
a0c3fad0
JD
52662011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5267
5268 * nsfns.m (get_geometry_from_preferences): New function.
5269 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5270
6c07aac2
AS
52712011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5272
5273 * emacs.c (Qkill_emacs): Define.
5274 (syms_of_emacs): Initialize it.
5275 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5276 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5277 (quit_throw_to_read_char): Add parameter `from_signal'.
5278 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5279 * lisp.h (QUIT): Call Fkill_emacs if requested.
5280
c052ead4
JD
52812011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5282
5283 * widget.c (update_wm_hints): Return if wmshell is null.
5284 (widget_update_wm_size_hints): New function.
5285
5286 * widget.h (widget_update_wm_size_hints): Declare.
5287
5288 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5289 widget_update_wm_size_hints (Bug#10104).
5290
9e49252b
EZ
52912011-12-03 Eli Zaretskii <eliz@gnu.org>
5292
5293 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5294 before a newline, prepare the bidi iterator for consuming the
5295 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5296 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5297
02b16839
JL
52982011-12-02 Juri Linkov <juri@jurta.org>
5299
5300 * search.c (Fword_search_regexp): New Lisp function created from
5301 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5302 (Fword_search_backward, Fword_search_forward)
5303 (Fword_search_backward_lax, Fword_search_forward_lax):
5304 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5305 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5306
0068070e
SM
53072011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5308
5309 * fileio.c (Finsert_file_contents): Move after-change-function call
5310 to before the "handled:" label, since all "goto handled" appear in
5311 cases where the *-change-functions have already been properly called
5312 (bug#10117).
5313
3360a3fc
AS
53142011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5315
5316 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5317 waiting for input. (Bug#10169)
5318
73d6c093
EZ
53192011-11-30 Eli Zaretskii <eliz@gnu.org>
5320
5321 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5322 verifies glyph row's hash code--we have just reallocated the
5323 glyphs, so their contents can be complete garbage. (Bug#10164)
5324
febe6bea
JB
53252011-11-30 Juanma Barranquero <lekktu@gmail.com>
5326
5327 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5328
801a4313
EZ
53292011-11-30 Eli Zaretskii <eliz@gnu.org>
5330
5331 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5332 attributes are tested _before_ calling verify_row_hash, to protect
5333 against GCC re-ordering of the tests. (Bug#10164)
5334
2b56b87e
JD
53352011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5336
5337 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5338
5339 * xterm.c (handle_one_xevent): Only set async_visible and friends
5340 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5341 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5342 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5343
dbf31225
PE
53442011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5345
5346 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5347 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5348 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5349 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5350 All uses changed to use GCPRO1 etc.
5351 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5352 Revert to old implementation (i.e., before 2011-03-11).
5353
1305621b
YM
53542011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5355
5356 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5357 of scroll runs so as to avoid assigning disabled bogus rows and
5358 unnecessary graphics copy operations.
5359
8c9afb46
EZ
53602011-11-27 Eli Zaretskii <eliz@gnu.org>
5361
5362 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5363 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5364 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5365 (malloc, free, realloc, calloc): Redirect to e_* only when
5366 compiling Emacs.
5367
5368 * lisp.h (GCTYPEBITS): Move before first use.
5369 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5370 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5371 this macro definition.
5372
5373 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5374 _MSC_VER.
5375
54e9e3bf
JD
53762011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5377
6d5eb5b0
SM
5378 * gtkutil.c (xg_create_frame_widgets):
5379 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5380 present with Gtk+ 2.0.
5381
83aca1cb
PE
53822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5383
5384 * fileio.c (Finsert_file_contents): Undo previous change; see
5385 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5386
5b76caa4
PE
53872011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5388
5389 Rename locals to avoid shadowing.
5390 * fileio.c (Finsert_file_contents):
5391 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5392 * process.c (wait_reading_process_output):
5393 Rename inner 'proc' to 'p' to avoid shadowing.
5394 Indent for consistency with usual Emacs style.
5395
8c535114
EZ
53962011-11-25 Eli Zaretskii <eliz@gnu.org>
5397
5398 * xdisp.c (redisplay_window): If cursor row is not fully visible
5399 after recentering, and scroll-conservatively is set to a large
5400 number, scroll window by a few more lines to make the cursor fully
5401 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5402 (start_display): Don't move to the next line if the display should
5403 start at a newline that is part of a display vector or an overlay
5404 string. (Bug#10119)
8c535114 5405
fa4fdb5c
JL
54062011-11-24 Juri Linkov <juri@jurta.org>
5407
5408 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5409 after the `MagickPingImage' call. (Bug#10112)
5410
90ec88df
CY
54112011-11-23 Chong Yidong <cyd@gnu.org>
5412
5413 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5414
56e2e794
MR
54152011-11-23 Martin Rudalics <rudalics@gmx.at>
5416
5417 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5418 making another buffer current. (Bug#10114)
5419
b6e64c41
GM
54202011-11-23 Glenn Morris <rgm@gnu.org>
5421
5422 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5423
6b21de18
CY
54242011-11-23 Chong Yidong <cyd@gnu.org>
5425
5426 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5427 using it (Bug#5984).
5428
b12cd789
EZ
54292011-11-22 Eli Zaretskii <eliz@gnu.org>
5430
5431 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5432 and header-lines, as they don't have one computed for them.
5433 (Bug#10098)
5434
5435 * .gdbinit (prow): Make displayed values more self-explaining.
5436 Add row's hash code.
5437
261b6fd4
LMI
54382011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5439
5440 * process.c (wait_reading_process_output): Fix asynchrounous
5441 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5442 (wait_reading_process_output): Add comment and URL.
261b6fd4 5443
e7cfd277
JD
54442011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5445
5446 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5447
a9b9b7f5
CY
54482011-11-21 Chong Yidong <cyd@gnu.org>
5449
5450 * window.c (Fnext_window, Fprevious_window): Doc fix.
5451
b0d15b4f
SM
54522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5453
5454 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5455
fe7a3057
JB
54562011-11-20 Juanma Barranquero <lekktu@gmail.com>
5457
5458 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5459
d2999b1a
MR
54602011-11-20 Martin Rudalics <rudalics@gmx.at>
5461
5462 * window.c (Fset_window_combination_limit): Rename argument
5463 STATUS to LIMIT.
5464 (Vwindow_combination_limit): Remove "status" from doc-string.
5465
d5ff9cd0
AS
54662011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5467
5468 * m/ibms390.h: Remove.
5469 * m/ibms390x.h: Don't include "ibms390.h".
5470
a5bb9bd3
SM
54712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5472
5473 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5474 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5475
cd1181db
JB
54762011-11-20 Juanma Barranquero <lekktu@gmail.com>
5477
5478 * casetab.c (Fset_case_table):
5479 * charset.c (Fcharset_after): Fix typos.
5480
615a3b8d 54812011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5482
17e845af
PE
5483 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5484 Otherwise, valgrind does not work on some platforms.
5485 Problem reported by Andreas Schwab in
6a0bf43d
PE
5486 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5487 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5488 is set, removing the need for VIRT_ADDRESS_VARIES.
5489 (PURE_P): Use a more-efficient implementation that needs just one
5490 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5491 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5492 to 4 (xorl, subq, cmpq, setbe).
5493 * alloc.c (pure): Always extern now, since that's the
5494 VIRT_ADDR_VARIES behavior.
5495 (PURE_POINTER_P): Use a single comparison, not two, for
5496 consistency with the new puresize.h.
5497 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5498 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5499 Remove VIRT_ADDR_VARIES no longer needed.
5500
f8fe6f96
EZ
55012011-11-19 Eli Zaretskii <eliz@gnu.org>
5502
5503 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5504 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5505 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5506 behave as if the cursor position were at the window margin.
5507
5508 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5509 and the cursor position is out of bounds, behave as if the cursor
5510 position were at the window margin. (Bug#10075)
5511
df05a53c
CY
55122011-11-18 Chong Yidong <cyd@gnu.org>
5513
5514 * window.c (Fwindow_combination_limit): Make first argument
5515 non-optional, since it is meaningless for live windows like the
5516 selected window.
61ccba97 5517
2071918e
DA
55182011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5519
5520 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5521
b50a28de
SM
55222011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5523
5524 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5525 (graft_intervals_into_buffer): Simplify.
5526
015137db
EZ
55272011-11-18 Eli Zaretskii <eliz@gnu.org>
5528
5529 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5530 hash values of the two rows.
5531 (copy_row_except_pointers): Preserve the used[] arrays and the
5532 hash values of the two rows. (Bug#10035)
68c95424 5533 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5534
5535 * xdisp.c (row_hash): New function, body extracted from
5536 compute_line_metrics.
5537 (compute_line_metrics): Call row_hash, instead of computing the
5538 hash code inline.
5539
5540 * dispnew.c (verify_row_hash): Call row_hash for computing the
5541 hash code of a row, instead of duplicating code from xdisp.c.
5542
5543 * dispextern.h (row_hash): Add prototype.
5544
a2addb04
TH
55452011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5546
5547 * frame.c (delete_frame): Don't delete the terminal when the last
5548 X frame is closed if emacs is built with GTK toolkit.
5549
df85d315
JB
55502011-11-17 Juanma Barranquero <lekktu@gmail.com>
5551
5552 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5553
a0c2d0ae
MR
55542011-11-17 Martin Rudalics <rudalics@gmx.at>
5555
5556 * window.c (Vwindow_splits): Rename to
5557 Vwindow_combination_resize. Suggested by Juri Linkov.
5558 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5559 of Vwindow_splits.
5560
58179cce
JB
55612011-11-16 Juanma Barranquero <lekktu@gmail.com>
5562
7877f373
JB
5563 * nsfns.m (Fns_font_name):
5564 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5565
b6f67890
MR
55662011-11-16 Martin Rudalics <rudalics@gmx.at>
5567
5568 * window.h (window): Rename slot "nest" to "combination_limit".
5569 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5570 (Fset_window_nest): Rename to Fset_window_combination_limit.
5571 (Vwindow_nest): Rename to Vwindow_combination_limit.
5572 (recombine_windows, make_parent_window, make_window)
5573 (Fsplit_window_internal, saved_window)
5574 (Fset_window_configuration, save_window_save): Rename all
5575 occurrences of window_nest to window_combination_limit.
5576
c7015153
JB
55772011-11-15 Juanma Barranquero <lekktu@gmail.com>
5578
5579 * image.c (imagemagick_load_image): Fix typo.
5580
322ad6ec
EZ
55812011-11-14 Eli Zaretskii <eliz@gnu.org>
5582
5583 * xdisp.c (display_line): Move the call to
5584 highlight_trailing_whitespace before the call to
5585 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5586 faces of all the glyphs to compute ROW's hash value.
5587 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5588
f067b8ec
JB
55892011-11-14 Juanma Barranquero <lekktu@gmail.com>
5590
5591 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5592 just return (bug#10044).
5593
1e5b2111
EZ
55942011-11-12 Eli Zaretskii <eliz@gnu.org>
5595
7ef3cbd5
EZ
5596 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5597 with user-defined heap size. Bump the default size of the temacs
5598 heap to 27MB, to avoid memory warning when running temacs.
5599 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5600
1e5b2111
EZ
5601 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5602 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5603 (verify_row_hash) [XASSERTS]: New function.
5604 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5605 that the hash value of glyph rows is correct.
1e5b2111 5606
89d61221
MR
56072011-11-12 Martin Rudalics <rudalics@gmx.at>
5608
5609 * window.h (window): Remove splits slot.
5610 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5611 (Fdelete_other_windows_internal, make_parent_window)
5612 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5613 (Fset_window_configuration, save_window_save): Don't deal with
5614 split status of windows.
5615 (saved_window): Remove splits slot.
5616 (Vwindow_splits): Rewrite doc-string.
5617
97f18cc8
JD
56182011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5619
5620 * xfns.c (unwind_create_frame):
5621 * nsfns.m (unwind_create_frame):
5622 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5623 Vframe_list (Bug#9999).
5624
22a648b4
DA
56252011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5626
0b381c7e 5627 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5628
659afede
KH
56292011-11-11 Kenichi Handa <handa@m17n.org>
5630
5631 * callproc.c (Fcall_process): Set the member dst_multibyte of
5632 process_coding.
5633
9ac0394b
KH
56342011-11-11 Johan Bockgård <bojohan@gnu.org>
5635
5636 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5637 avoid a crash (bug#9496).
5638
2fbdc249
CY
56392011-11-09 Chong Yidong <cyd@gnu.org>
5640
5641 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5642 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5643
ac6b1f81
PE
56442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5647
09db192c
PE
56482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5649
5650 Avoid some portability problems by eschewing 'extern inline' functions.
5651 The trivial performance wins aren't worth the portability hassles; see
5652 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5653 et seq.
5654 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5655 (window_box_width, window_box_left, window_box_left_offset)
5656 (window_box_right, window_box_right_offset): Undo previous change,
5657 by removing the "extern"s.
5658 * intervals.c (adjust_intervals_for_insertion)
5659 (adjust_intervals_for_deletion): Undo previous change,
5660 making these static again.
5661 (offset_intervals, temp_set_point_both, temp_set_point)
5662 (copy_intervals_to_string): No longer inline.
5663 * xdisp.c (window_text_bottom_y, window_box_width)
5664 (window_box_height, window_box_left_offset)
5665 (window_box_right_offset, window_box_left, window_box_right)
5666 (window_box): No longer inline.
5667
105216ed
CY
56682011-11-08 Chong Yidong <cyd@gnu.org>
5669
5670 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5671 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5672 Signal an error if not a live window.
105216ed
CY
5673 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5674 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5675
ae9e237f
JB
56762011-11-07 Juanma Barranquero <lekktu@gmail.com>
5677
5678 * lisp.h (syms_of_abbrev): Remove declaration.
5679 Reported by CHENG Gao <chenggao@royau.me>.
5680
c7aa8333
EZ
56812011-11-07 Eli Zaretskii <eliz@gnu.org>
5682
5683 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5684 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5685 of temacs in GUI mode.
5686
be7f5545
MR
56872011-11-07 Martin Rudalics <rudalics@gmx.at>
5688
5689 * window.h: Declare delete_all_child_windows instead of
5690 delete_all_subwindows.
5691 * window.c (Fwindow_nest, Fset_window_nest)
5692 (Fset_window_new_total, Fset_window_new_normal)
5693 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5694 (delete_all_subwindows): Rename to delete_all_child_windows.
5695 (Fdelete_other_windows_internal, Fset_window_configuration):
5696 Call delete_all_child_windows instead of delete_all_subwindows.
5697 * frame.c (delete_frame): Call delete_all_child_windows instead
5698 of delete_all_subwindows.
5699
ca78dc43
PE
57002011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5701
5702 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5703 This is also needed for porting to any host where GC_MARK_STACK is
5704 not GC_MAKE_GCPROS_NOOPS.
5705 (which_symbols): Use it.
5706
a0241d01
KH
57072011-11-07 Kenichi Handa <handa@m17n.org>
5708
5709 * coding.c (coding_set_destination): Check coding->src_pos only
5710 when coding->src_object is a buffer (bug#9910).
5711
5712 * process.c (send_process): Set the member src_multibyte of coding
5713 to 0 (bug#9911) when sending a unibyte text.
5714
5715 * callproc.c (Fcall_process): Set the member src_multibyte of
5716 process_coding to 0 (bug#9912).
5717
a64bfdfa 57182011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5719
5720 * xmenu.c (cleanup_widget_value_tree): New function.
5721 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5722 calling free_menubar_widget_value_tree directly (Bug#9830).
5723
cb41b32a
PE
57242011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5725
5726 Fix some portability problems with 'inline'.
5727 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5728 (window_box_width, window_box_left, window_box_left_offset)
5729 (window_box_right, window_box_right_offset): Declare extern.
5730 Otherwise, these inline functions do not conform to C99 and
5731 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5732 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5733 * intervals.c (adjust_intervals_for_insertion)
5734 (adjust_intervals_for_deletion): Now extern, because otherwise the
5735 extern inline functions 'offset_intervals' couldn't refer to it.
5736 (static_offset_intervals): Remove.
5737 (offset_intervals): Rewrite using the old contents of
5738 static_offset_intervals. The old version didn't conform to C99
5739 because an extern inline function contained a reference to an
5740 identifier with static linkage.
5741
b7041366
AS
57422011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5743
5744 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5745 GC.
5746
88a37c4d
EZ
57472011-11-06 Eli Zaretskii <eliz@gnu.org>
5748
5749 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5750 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5751 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5752 return Qleft_to_right.
5753
49745b39
CY
57542011-11-06 Chong Yidong <cyd@gnu.org>
5755
5756 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5757 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5758 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5759 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5760 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5761 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5762 (Fwindow_vscroll): Doc fix.
5763 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5764 argument, since it makes no sense to pass a live window and for
5765 consistency with window-child.
5766
1f05cd82
CS
57672011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5768
5769 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5770 support MSVC.
5771
22610910
JR
57722011-11-05 Jason Rumney <jasonr@gnu.org>
5773
5774 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5775 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5776 fonts (Bug#6029).
5777 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5778 bitwise arithmetic preventing use of unicode-sip and non-truetype
5779 opentype fonts.
5780
a06776b2
EZ
57812011-11-05 Eli Zaretskii <eliz@gnu.org>
5782
3ad924ba
EZ
5783 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5784 "emacs"-only part.
5785
a06776b2
EZ
5786 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5787 initialization code to keep similarity to xfns.c after changes
5788 from 2011-11-05.
5789
c9e7db78
JD
57902011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5791
a97f8f3f
JD
5792 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5793 (unwind_create_frame): New function (Bug#9943).
5794 (Fx_create_frame): Restructure code to be more similar to the one in
5795 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5796 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5797 Move terminal->reference_count++ just before making the frame official
5798 (Bug#9943).
5799
5800 * nsterm.m (x_free_frame_resources): New function.
5801 (x_destroy_window): Move code to x_free_frame_resources.
5802
c9e7db78 5803 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5804 (Fx_create_frame, x_create_tip_frame):
5805 Move terminal->reference_count++ just before making the frame
75f1671a 5806 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5807 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5808
a6fc3b5c
EZ
58092011-11-05 Eli Zaretskii <eliz@gnu.org>
5810
5811 Support MSVC build with newer versions of Visual Studio.
5812 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5813 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5814 nt/gmake.defs.
5815
5816 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5817 which are not supported by MSVC.
5818 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5819 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5820 bitfields.
5821 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5822 types in bitfields.
5823 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5824
5825 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5826
58179cce 58272011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5828
5829 Support MSVC build with newer versions of Visual Studio.
5830 * w32.c: Don't include w32api.h for MSVC.
5831 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5832
5833 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5834 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5835 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5836 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5837 e_* cousins.
5838 (alloca) [_MSC_VER]: Define to _alloca.
5839
5840 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5841
5842 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5843
a58c13ed
EZ
58442011-11-04 Eli Zaretskii <eliz@gnu.org>
5845
5846 * xdisp.c (note_mouse_highlight): If either of
5847 previous/next-single-property-change returns nil, treat that as
5848 the beginning or the end of the buffer. (Bug#9955)
5849
fe0b6370
JD
58502011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5851
a58c13ed 5852 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5853 label is not null (Bug#9951).
5854 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5855 may be NULL.
5856
89bd5ee1
EZ
58572011-11-04 Eli Zaretskii <eliz@gnu.org>
5858
5859 * window.c (Fwindow_body_size): Mention in the doc string that the
5860 return value is in frame's canonical units. (Bug#9949)
5861
84c3edb9
EZ
58622011-11-03 Eli Zaretskii <eliz@gnu.org>
5863
4e2fb5c7
EZ
5864 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5865
84c3edb9 5866 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5867 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5868 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5869
bc17a887
EZ
58702011-11-01 Eli Zaretskii <eliz@gnu.org>
5871
5872 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5873 Don't stop backward scan on the continuation glyph, even though
5874 its CHARPOS is positive.
6d5eb5b0
SM
5875 (mouse_face_from_buffer_pos, note_mouse_highlight):
5876 Rename cover_string to disp_string.
bc17a887 5877
4ee88440
MR
58782011-11-01 Martin Rudalics <rudalics@gmx.at>
5879
5880 * window.c (temp_output_buffer_show): Don't use
5881 Vtemp_buffer_show_specifiers.
5882 (Vtemp_buffer_show_specifiers): Remove unused variable.
5883
c2ff3c02
EZ
58842011-10-30 Eli Zaretskii <eliz@gnu.org>
5885
5886 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5887 past the beginning of the current glyph matrix.
5888
58179cce 58892011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5890
5891 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5892 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5893 HAVE_GTK3 (Bug#9869).
b77a6a7f 5894
3b574623
JD
5895 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5896 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5897
b77a6a7f
JD
5898 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5899
5900 * xterm.c: Declare x_handle_net_wm_state to return int.
5901 (handle_one_xevent): Check if we are iconified but don't have
5902 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5903 (get_current_wm_state): Return non-zero if not hidden,
5904 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5905 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5906 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5907 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5908
196e41e4
PE
59092011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5910
5911 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5912 so that this new function doesn't get optimized away by a
5913 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5914
021f2e1a
AS
59152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5916
5917 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5918
8b058d44
EZ
59192011-10-29 Eli Zaretskii <eliz@gnu.org>
5920
5921 Fix the `xbytecode' command.
5922 * .gdbinit (xprintbytestr): New command.
b50a28de 5923 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5924 (xbytecode): Print the byte-code string as well.
5925
4452fb80
EZ
59262011-10-29 Kim Storm <storm@cua.dk>
5927
8b058d44
EZ
5928 * alloc.c (which_symbols): New function.
5929
21b72067
AS
59302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5931
5932 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5933 line. (Bug#9903)
5934
83ed7b5c
GM
59352011-10-29 Glenn Morris <rgm@gnu.org>
5936
5937 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5938 Not clear what it was for, and it causes various bugs. (Bug#9839)
5939
5a7a728b
EZ
59402011-10-28 Eli Zaretskii <eliz@gnu.org>
5941
5942 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5943 possible random value that matches one of those tested as
5944 condition to clear the mouse face.
5945
d3d0842f
CY
59462011-10-28 Chong Yidong <cyd@gnu.org>
5947
5948 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5949
31b39d13
DN
59502011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5951
5952 * window.c (make_window): Initialize phys_cursor_on_p.
5953
9aba6043
SM
59542011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5955
5956 * lisp.h (struct Lisp_Symbol): Update comments.
5957
c20992f4
JB
59582011-10-28 Juanma Barranquero <lekktu@gmail.com>
5959
5960 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5961
db4f02f2
EZ
59622011-10-28 Eli Zaretskii <eliz@gnu.org>
5963
5964 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5965 <oslsachem@gmail.com> for helping to debug this.
5966
5967 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5968 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5969 (g_b_init_get_glyph_outline_w): New static variables.
5970 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5971 (GetGlyphOutlineW_Proc): New typedefs.
5972 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5973 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5974 New functions.
5975 (w32font_open_internal, compute_metrics):
5976 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5977 instead of calling the "wide" APIs directly.
5978
5979 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5980
5981 * w32.h (syms_of_w32font): Add prototype.
5982
87e68db4
JB
59832011-10-27 Juanma Barranquero <lekktu@gmail.com>
5984
5985 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5986 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5987 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5988 (Fmove_to_window_line): Doc fix.
5989
435c1d67
CY
59902011-10-27 Chong Yidong <cyd@gnu.org>
5991
5992 * process.c (make_process): Set gnutls_state to NULL.
5993
5994 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5995 non-NULL, regardless of GNUTLS_INITSTAGE.
5996 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5997 an error. Set process slots as soon as we allocate them.
5998
5999 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6000
9c6c6f49
CY
60012011-10-27 Chong Yidong <cyd@gnu.org>
6002
9aba6043
SM
6003 * gnutls.c (emacs_gnutls_deinit): New function.
6004 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6005 (Fgnutls_deinit, Fgnutls_boot): Use it.
6006
6007 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6008 (deactivate_process): Call emacs_gnutls_deinit.
6009
657d08d3
JB
60102011-10-27 Juanma Barranquero <lekktu@gmail.com>
6011
6012 * image.c (x_create_x_image_and_pixmap):
6013 * w32.c (sys_rename, w32_delayed_load):
6014 * w32font.c (fill_in_logfont):
6015 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6016
5430d399
JB
60172011-10-26 Juanma Barranquero <lekktu@gmail.com>
6018
6019 * w32fns.c (w32_default_color_map): New function,
6020 extracted from Fw32_default_color_map.
a7ef684b 6021 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6022
fe0055fa
PE
60232011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6024
6025 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6026
e6346438
SM
60272011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6028
6029 * keyboard.c (test_undefined): New function (bug#9751).
6030 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6031
e112cc37
ET
60322011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6033
6034 * sysdep.c (init_sys_modes): Fix the check for the controlling
6035 terminal (Bug#6649).
6036
7b5d6677
EZ
60372011-10-20 Eli Zaretskii <eliz@gnu.org>
6038
6039 * dispextern.h (struct bidi_it): New member next_en_type.
6040
6041 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6042 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6043 current character, check also for next_en_type being WEAK_EN.
6044 (bidi_resolve_weak): Don't enter the expensive loop if the current
6045 position is before next_en_pos. Record the bidi type of the first
6046 non-ET, non-BN character we find, in addition to its position.
6047 (bidi_level_of_next_char): Invalidate next_en_type when
6048 next_en_pos is over-stepped.
6049
7da0b018
PE
60502011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6051
6052 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6053 * editfns.c: Rewrite current-time-zone so that it invokes
6054 the equivalent of (format-time-string "%Z") to get the time zone name.
6055 This fixes a bug when the time zone name contains characters that
6056 need converting from the system time locale to Emacs internal format.
6057 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6058 that patch fixed format-time-string to do the conversion, but
6059 I forgot to fix current-time-zone.
6060 (format_time_string): New function, containing most of
6061 what Fformat_time_string used to contain.
6062 (Fformat_time_string): Rewrite in terms of format_time_string.
6063 This doesn't change this function's behavior.
6064 (current-time-zone): Rewrite to use format_time_string.
6065 This fixes the bug reported by Michael Schierl in
6066 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6067 Jason Rumney's 2007-06-07 change worked around this bug, but
6068 didn't fix it.
6069 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6070
8547b010
EZ
60712011-10-19 Eli Zaretskii <eliz@gnu.org>
6072
6073 * xdisp.c (start_display): If the character at POS is displayed
6074 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6075 (try_window_reusing_current_matrix): If a line ends in a display
6076 vector or the next line starts in a display vector, continue
6077 redrawing the window even though the character position of
6078 start_row was reached.
8547b010
EZ
6079 (Bug#9771, part 2)
6080
4e948d15
CY
60812011-10-18 Chong Yidong <cyd@gnu.org>
6082
6083 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6084 with nobreak-char-display too.
6085
4787455f
EZ
60862011-10-18 Eli Zaretskii <eliz@gnu.org>
6087
6088 Fix part 3 of bug#9771.
6089 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6090 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6091 non-neutral characters if the current character is a paragraph
6092 separator (a.k.a. Newline). This avoids running the same
6093 expensive loop twice, once when we consume the preceding newline
6094 and the other time when the line actually needs to be displayed.
6095 Avoid the loop when we see neutrals on the base embedding level
6096 following a character whose directionality is the same as the
6097 paragraph's. This avoids running the expensive loop when a line
6098 ends in a long sequence of neutrals, like control characters.
6099 Add assertion against STRONG_AL type. Slightly rearrange code
6100 that determines the type of a neutral given the first non-neutral
6101 that follows it.
6102 (bidi_level_of_next_char): Set next_en_pos to zero when
6103 invalidating its info.
6104
2c91f553
EZ
61052011-10-17 Eli Zaretskii <eliz@gnu.org>
6106
6107 * xdisp.c (push_display_prop): Determine whether to record string
6108 or buffer position by IT->string, not by IT->method. Allow
6109 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6110 (move_it_vertically_backward): Don't look for character position
6111 immediately after the newline when in a continuation line.
6112 (Bug#9771, part 1)
2c91f553 6113
c7b08b0d
MR
61142011-10-15 Martin Rudalics <rudalics@gmx.at>
6115
6116 * window.c (coordinates_in_window): Rewrite and delabelize
6117 vertical border check. (Bug#5357) (Bug#9618)
6118
6b02f655
SM
61192011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6120
6121 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6122 errors in XSetWindowBorder (bug#9310).
6123
81d40c92
DA
61242011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6125
6126 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6127 avoid crash when xmalloc overrun checking is enabled.
6128
d4172c3b
EZ
61292011-10-13 Eli Zaretskii <eliz@gnu.org>
6130
6131 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6132 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6133 cursor motion with <left> and <right> arrow keys.
6134
6135 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6136 some callers set that themselves.
6137
b00eea75
EZ
61382011-10-12 Eli Zaretskii <eliz@gnu.org>
6139
6140 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6141 display string and the previous row comes from the same string and
6142 is empty. (Bug#9739) (Bug#9738)
6143
8fe012c4
SM
61442011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6145
6146 * doc.c (get_doc_string): Encode file name (bug#9735).
6147
0074aef2
EZ
61482011-10-12 Eli Zaretskii <eliz@gnu.org>
6149
79beb178
EZ
6150 * bidi.c (bidi_level_of_next_char):
6151 * xdisp.c (get_visually_first_element): Remove old incorrect
6152 comments regarding the Unicode Line Separator character.
6153
0074aef2
EZ
6154 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6155
6e4b3fbe
DA
61562011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6157
6158 * alloc.c (Fgc_status): Do not access beyond zombies array
6159 boundary if nzombies > MAX_ZOMBIES.
6160 * alloc.c (dump_zombies): Add missing format specifier.
6161
0324f3af
PE
61622011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6163
b5525cac
PE
6164 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6165 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6166
0324f3af
PE
6167 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6168 Some packages use them to denote characters with modifiers.
6169
e9b5f888
AS
61702011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6171
6172 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6173 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6174 matching a pp-number. Rename parameter var to var1.
6175
127827c0
SM
61762011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6177
6178 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6179
c8fd3bd0
GM
61802011-10-08 Glenn Morris <rgm@gnu.org>
6181
6182 * callint.c (Fcall_interactively): Give a more explicit error for the
6183 'c' case with a non-character input. (Bug#8479)
6184
352ec8ff
EZ
61852011-10-08 Eli Zaretskii <eliz@gnu.org>
6186
03669ccb
EZ
6187 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6188 lines.
7061c986
EZ
6189 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6190 lines that are hscrolled on the left.
03669ccb 6191
352ec8ff
EZ
6192 * dispnew.c (buffer_posn_from_coords): Account for a possible
6193 presence of header-line. (Bug#4426)
6194
a66cfb1c
SM
61952011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6196
6b02f655
SM
6197 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6198 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6199
7c5ee88e
PE
62002011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6201
6202 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6203 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6204 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6205 this makes Emacs dump core during garbage collection on rare
6206 occasions. sizeof is obviously inferior to offsetof here, so
6207 stick with offsetof.
6208 (GC_POINTER_ALIGNMENT): New macro.
6209 (mark_memory): Omit 3rd (offset) arg; caller changed.
6210 Don't assume EMACS_INT alignment is the same as pointer alignment.
6211
df1bbe5b
SM
62122011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6213
6214 * keyboard.c (read_key_sequence_remapped): New var.
6215 (read_key_sequence): Compute remapping in the right buffer.
6216 (command_loop_1): Use read_key_sequence's remapping directly.
6217
51553db6
SM
62182011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6219
32c1fffd
SM
6220 * dired.c (file_name_completion): Don't expand file name.
6221 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6222 before checking file name handler.
6223
51553db6
SM
6224 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6225 they've been requested explicitly (bug#9591).
6226
b6bd1599 62272011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6228
6229 * keymap.c (Fsingle_key_description): Use make_specified_string
6230 instead of build_string to build string from push_key_description.
6231 (Bug#5193)
6232
f701dc2a
PE
62332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6234
4222c55d
PE
6235 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6236 This fixes a Y2038 bug on 64-bit hosts.
6237 * buffer.c (reset_buffer):
6238 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6239 (Fclear_buffer_auto_save_failure):
6240 Use 0, not -1, to represent an unset failure time, since time_t
6241 might not be signed.
6242
f701dc2a
PE
6243 Remove dependency on glibc malloc internals.
6244 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6245 Move back here from lisp.h, but with their new implementations.
6246 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6247 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6248 * charset.c (charset_table_init): New static var.
6249 (syms_of_charset): Use it instead of xmalloc. This removes a
6250 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6251 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6252 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6253 Move back to alloc.c.
6254 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6255 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6256
9ceebf39
JD
62572011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6258
6259 * nsterm.m (windowDidResize): Call x_set_window_size only when
6260 ns_in_resize is true. Otherwise set pixelwidth/height and
6261 call change_frame_size (Bug#9628).
6262
cb993c58
PE
62632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6264
3930c88b
PE
6265 Port --enable-checking=all to Fedora 14 x86-64.
6266 * charset.c (syms_of_charset): Also account for glibc malloc's
6267 internal overhead when calculating the initial malloc maximum.
6268
cb993c58
PE
6269 Port --enable-checking=all to Fedora 14 x86.
6270 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6271 Move to lisp.h.
6272 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6273 (overrun_check_realloc, overrun_check_free):
6274 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6275 That way, xmalloc returns a properly-aligned pointer even if
6276 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6277 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6278 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6279 into account when calculating the initial malloc maximum.
6280 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6281 Move here from alloc.c, so that charset.c can use it too.
6282 Properly align; the old code wasn't right for common 32-bit hosts
6283 when configured with --enable-checking=all.
6284 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6285 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6286
31bed486
EZ
62872011-09-29 Eli Zaretskii <eliz@gnu.org>
6288
04c70788 6289 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6290 use EDOM.
6291
fbcaa2f3
EZ
62922011-09-28 Eli Zaretskii <eliz@gnu.org>
6293
6294 * xdisp.c (compute_display_string_end): If there's no display
6295 string at CHARPOS, return -1.
6296
6297 * bidi.c (bidi_fetch_char): When compute_display_string_end
6298 returns a negative value, treat the character as a normal
6299 character not covered by a display string. (Bug#9624)
6300
a239d4e9
JB
63012011-09-28 Juanma Barranquero <lekktu@gmail.com>
6302
6303 * lread.c (Fread_from_string): Fix typo in docstring.
6304
88652fd5
EZ
63052011-09-27 Eli Zaretskii <eliz@gnu.org>
6306
6307 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6308 newline, reseat the iterator instead of bidi-iterating there one
6309 character at a time. (Bug#9610)
32c1fffd
SM
6310 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6311 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6312
ed497dd4
AS
63132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6314
6315 * lread.c (readevalloop): Use correct code for NBSP.
6316 (read1): Likewise. (Bug#9608)
6317
b2bf61aa
MA
63182011-09-25 Michael Albinus <michael.albinus@gmx.de>
6319
6320 * dbusbind.c (Fdbus_register_signal): When service is not
6321 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6322
32bbb17c
GM
63232011-09-25 Glenn Morris <rgm@gnu.org>
6324
6325 * buffer.c (truncate-lines): Doc fix.
6326
94e0933e
CY
63272011-09-24 Chong Yidong <cyd@stupidchicken.com>
6328
6329 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6330 (Fset_window_next_buffers): Doc fix.
6331
cddde921
GM
63322011-09-24 Glenn Morris <rgm@gnu.org>
6333
6334 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6335
1260aef1
PE
63362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6337
25b4bfa0
PE
6338 Fix minor problems found by static checking.
6339 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6340 * indent.c (Fvertical_motion): Fix == vs = typo.
6341
e3cbd34b
EZ
63422011-09-24 Eli Zaretskii <eliz@gnu.org>
6343
a66cfb1c
SM
6344 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6345 Default value is now t. Doc fix.
6bf7006f 6346
e3cbd34b 6347 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6348 logic when moving up, not only when moving down. Fix the
e3cbd34b 6349 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6350 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6351
6352 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6353 CHARPOS is covered by a display string which includes newlines.
6354 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6355 is covered by a display string with embedded newlines.
6356
a3de0cbd
MA
63572011-09-24 Michael Albinus <michael.albinus@gmx.de>
6358
6359 * dbusbind.c (Fdbus_register_signal): Add match rule to
6360 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6361 (Fdbus_register_method, Vdbus_registered_objects_table):
6362 Fix docstring.
a3de0cbd 6363
b260039d
JM
63642011-09-24 Jim Meyering <meyering@redhat.com>
6365
32c1fffd 6366 do not ignore write error for any output size
b260039d
JM
6367 The previous change was incomplete.
6368 While it makes emacs --batch detect the vast majority of stdout
6369 write failures, errors were still ignored whenever the output size is
6370 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6371 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6372 && echo FAIL: ignored write error
6373 FAIL: ignored write error
6374 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6375 && echo FAIL: ignored write error
6376 FAIL: ignored write error
6377 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6378
8eca8a7c
AS
63792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6380
6381 * emacs.c (Fkill_emacs): In noninteractive mode exit
6382 non-successfully if a write error occurred on stdout. (Bug#9574)
6383
3341db62
EZ
63842011-09-21 Eli Zaretskii <eliz@gnu.org>
6385
6386 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6387 the xassert test.
6388
6389 * dispextern.h (struct it): Update the comment documenting what
6390 can it->OBJECT be.
6391
8c203dbf
EZ
63922011-09-20 Eli Zaretskii <eliz@gnu.org>
6393
6394 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6395 a display string, extend search for cursor position to end of row.
6396 (find_row_edges): If the row ends in a newline from a display
6397 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6398 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6399 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6400 non-empty line. Fixes confusing cursor motion with arrow keys at
6401 the beginning of a line that starts with whitespace.
8c203dbf 6402
a4824228
LMI
64032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6404
6405 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6406 (bug#9493).
6407
33ed493b
CY
64082011-09-18 Chong Yidong <cyd@stupidchicken.com>
6409
6410 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6411 boolean (Bug#9154).
6412
56cd55c8
EZ
64132011-09-18 Eli Zaretskii <eliz@gnu.org>
6414
6415 * xdisp.c (display_line): Record maximum and minimum buffer
6416 positions even if no glyphs were produced (e.g., by a zero-width
6417 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6418 buffer positions that will be removed from the glyph row because
6419 they don't fit.
c02dcedf
EZ
6420 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6421 column is beyond frame width: don't subtract 1 "pixel" when
6422 computing width of the stretch.
3e62b7e0
EZ
6423 (reseat_at_next_visible_line_start): Undo the change made on
6424 2011-09-17 that saved paragraph information and restored it after
6425 the call to `reseat'. (Bug#9545)
56cd55c8 6426
5ed99d36 64272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6428
6429 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6430 and turn window cursor on if cleared (Bug#9415).
6431
5ed99d36 64322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6433
6434 * search.c (boyer_moore): Take unibyte characters from pattern
6435 literally. (Bug#9458)
6436
9bade7b2
EZ
64372011-09-18 Eli Zaretskii <eliz@gnu.org>
6438
6439 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6440
e5e9d610
PE
64412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6442
87e4427a
PE
6443 Fix minor problem found by static checking.
6444 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6445 initialized, to pacify gcc -Wuninitialized.
6446
e5e9d610
PE
6447 * fileio.c: Report proper errno when syscall falls.
6448 (Finsert_file_contents): Save and restore errno,
6449 so that report_file_error outputs the correct diagnostic.
6450 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6451
a1674f0b
EZ
64522011-09-18 Eli Zaretskii <eliz@gnu.org>
6453
6454 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6455
fbfb6dd4
EZ
64562011-09-17 Eli Zaretskii <eliz@gnu.org>
6457
6458 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6459 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6460
bb187662
EZ
64612011-09-17 Eli Zaretskii <eliz@gnu.org>
6462
1137e8b8 6463 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6464 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6465
6466 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6467 (bidi_find_paragraph_start): Search back for paragraph beginning
6468 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6469 (bidi_move_to_visually_next): Only trigger paragraph-related
6470 computations when the last character is a newline or at EOB, not
6471 just any NEUTRAL_B. (Bug#9470)
6472
bb187662
EZ
6473 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6474 truncated lines if point is covered by a display string. (Bug#9524)
6475
2e621251
PE
64762011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6477
6478 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6479 (cons_to_x_long): New function.
6480 (lisp_data_to_selection_data): Use it. Correct the test for
6481 short-versus-long data; it was negated. Break out of vector
6482 loop, for efficiency, when a long datum is discovered.
6483
91a15bc6
SM
64842011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6485
6486 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6487
b41c3a35
EZ
64882011-09-16 Eli Zaretskii <eliz@gnu.org>
6489
6490 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6491 GCC PR/17406) by declaring this function with external scope.
6492
7812ba2d
PE
64932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6494
6495 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6496 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6497
cf7edc2a
AS
64982011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6499
6500 * editfns.c (Fformat): Correctly handle text properties on "%%".
6501
bd01620e
EZ
65022011-09-15 Eli Zaretskii <eliz@gnu.org>
6503
6504 * xterm.c (x_draw_composite_glyph_string_foreground):
6505 * w32term.c (x_draw_composite_glyph_string_foreground):
6506 * term.c (encode_terminal_code):
6507 * composite.c (composition_update_it, get_composition_id):
6508 * xdisp.c (get_next_display_element)
6509 (fill_composite_glyph_string): Add comments about special meaning
6510 of TAB characters in a composition.
6511
a02719a3
PE
65122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6513
6514 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6515 This occurs when processing a multibyte format.
6516 Problem reported by Wolfgang Jenker.
a02719a3 6517
72589a3c
JB
65182011-09-15 Johan Bockgård <bojohan@gnu.org>
6519
6520 * xdisp.c (try_cursor_movement): Only check for exact match if
6521 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6522
1c14176c
PE
65232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6524
6525 Remove unused external symbols.
6526 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6527 * xdisp.c (calc_pixel_width_or_height): Now static.
6528 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6529 * indent.c (check_display_width):
6530 * w32term.c: Fix comment to match code.
6531 * xterm.c, xterm.h (x_catching_errors): Remove.
6532
d2eea5b5
PE
65332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6534
6535 * xselect.c: Use signed conversions more consistently (Bug#9498).
6536 (selection_data_to_lisp_data): Assume incoming selection data are
6537 signed integers, not unsigned. This is to be consistent with
6538 outgoing selection data, which was modified to use signed integers
6539 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6540 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6541 expects long, not unsigned long.
6542
46888499
EZ
65432011-09-14 Eli Zaretskii <eliz@gnu.org>
6544
6545 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6546 computation of loop end. Reported by Johan Bockgård
6547 <bojohan@gnu.org>.
6548
ef8ef9fb
CY
65492011-09-13 Chong Yidong <cyd@stupidchicken.com>
6550
6551 * frame.c (Fother_visible_frames_p): Function deleted.
6552
fa819fed
EZ
65532011-09-12 Eli Zaretskii <eliz@gnu.org>
6554
6555 * indent.c (compute_motion): Process display vector front to back
6556 rather than the other way around. (Bug#2496)
6557
2ba8e008
SM
65582011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6559
6560 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6561
20f53c69
CY
65622011-09-11 Chong Yidong <cyd@stupidchicken.com>
6563
6564 * minibuf.c (Fread_from_minibuffer): Doc fix.
6565
d562d7a4
EZ
65662011-09-11 Eli Zaretskii <eliz@gnu.org>
6567
6568 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6569 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6570
1c4d7f3d
LMI
65712011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6572
6573 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6574 value for non-existent files.
6575
b885bf36
EZ
65762011-09-11 Eli Zaretskii <eliz@gnu.org>
6577
6578 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6579 set its "size" to -1. This will set the modtime_size field of
6580 the corresponding buffer to -1, which is what
6581 verify-visited-file-modtime expects for files that do not exist.
6582 (Bug#9139)
6583
6612f0bf
PE
65842011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6585
6586 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6587 here ...
6588 * lisp.h: ... from here. push_key_description is no longer
6589 defined in keyboard.c, so its declaration should not be in
6590 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6591 logically belongs with push_key_description.
6592
dfb3f755
PE
65932011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6594
6595 * buffer.h: Include <sys/types.h> instead of <time.h>.
6596 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6597 Problem reported by Herbert J. Skuhra.
6598
3134906c
LMI
65992011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6600
6601 * xml.c (parse_region): Make the parsing work for
6602 non-comment-starting XML files again (bug#9144).
6603
8d903f4e
AS
66042011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6605
6606 * image.c (gif_load): Fix calculation of bottom and right corner.
6607 (Bug#9468)
6608
80ad64f4
EZ
66092011-09-10 Eli Zaretskii <eliz@gnu.org>
6610
6611 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6612 redisplay in small windows.
6613
208a048d
EZ
66142011-09-09 Eli Zaretskii <eliz@gnu.org>
6615
6616 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6617
9b1c252e
MR
66182011-09-08 Martin Rudalics <rudalics@gmx.at>
6619
6620 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6621 Operate on live windows only.
6622
2949f33b
JB
66232011-09-08 Juanma Barranquero <lekktu@gmail.com>
6624
6625 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6626
e08dcafd
EZ
66272011-09-07 Eli Zaretskii <eliz@gnu.org>
6628
6629 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6630 only under bidi iteration.
6631
115b96bd
JD
66322011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6633
6634 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6635
c8199d0f
PE
66362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6637
6638 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6639 Without this fix, the command to link temacs failed due to an
6640 undefined symbol __builtin_isnan. This is because
6641 /usr/include/iso/math_c99.h #defines isnan(x) to
6642 __builtin_isnan(x), but the bundled gcc, which identifies itself
6643 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6644 a __builtin_isnan.
6645 * floatfns.c (isnan): #undef, and then #define to a clone of
6646 what's in data.c.
6647 (Fisnan): Always define, since it's always available now.
6648 (syms_of_floatfns): Always define isnan at the Lisp level.
6649
e39b275c 66502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6651
6652 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6653
b2db44d9 66542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6655
f4af5137 6656 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6657 The previous code assumed that file offsets (off_t values) fit in
6658 EMACS_INT variables, which is not true on typical 32-bit hosts.
6659 The code messed up by falsely reporting buffer overflow in cases
6660 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6661 when "big" contains more than 2**29 bytes, even though this
6662 inserts just one byte and does not overflow the buffer.
6663 (Finsert_file_contents): Store file offsets as off_t
6664 values, not as EMACS_INT values. Check for overflow when
6665 converting between EMACS_INT and off_t. When checking for
6666 buffer overflow or for overlap, take the offsets into account.
6667 Don't use EMACS_INT for small values where int suffices.
6668 When checking for overlap, fix a typo: ZV was used where
6669 ZV_BYTE was intended.
6670 (Fwrite_region): Don't assume off_t fits into 'long'.
6671 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6672
ecfc0a49
MA
66732011-09-05 Michael Albinus <michael.albinus@gmx.de>
6674
6675 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6676
6511acf2 66772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6678
0999621a 6679 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6680
6681 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6682 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6683 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6684 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6685 (modify_event_symbol): Do not assume that the length of
6686 name_alist_or_stem is safe to alloca and fits in int.
6687 (Fexecute_extended_command): Likewise for function name and binding.
6688 (Frecursion_depth): Wrap around reliably on integer overflow.
6689 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6690 since some callers pass EMACS_INT values.
6691 (Fsingle_key_description): Don't crash if symbol name contains more
6692 than MAX_ALLOCA bytes.
6693 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6694 (get_minibuffer): Arg is now EMACS_INT, not int.
6695 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6696 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6697 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6698
2be7d702
PE
6699 * dbusbind.c (signature_cat): New function.
6700 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6701 Do not overrun buffer; instead, report string overflow.
6702
9d1df220
PE
6703 * dispnew.c (add_window_display_history): Don't overrun buffer.
6704 Truncate instead; this is OK since it's just a log.
6705
33ef5c64
PE
6706 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6707 even if the time zone offset is outlandishly large.
6708 Don't mishandle offset == INT_MIN.
6709
66c6fdd5
PE
6710 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6711 when creating daemon; the previous buffer-overflow check was incorrect.
6712
d749b01b
PE
6713 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6714 which has the guts of the old verror function.
6715
b5cd1905
PE
6716 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6717 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6718
6e1a67fb
PE
6719 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6720 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6721 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6722 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6723 length of string rather than counting it via multiple sprintfs;
6724 that's simpler and more reliable.
c21721cc
PE
6725 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6726 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6727 sprintf, in case result does not fit in int.
6728
c57b67fc
PE
6729 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6730 (fontset_from_font): Print it.
6731
8a401434
PE
6732 * frame.c (tty_frame_count): Now printmax_t, not int.
6733 (make_terminal_frame, set_term_frame_name): Print it.
6734 (x_report_frame_params): In X, window IDs are unsigned long,
6735 not signed long, so print them as unsigned.
6736 (validate_x_resource_name): Check for implausibly long names,
6737 and don't assume name length fits in 'int'.
6738 (x_get_resource_string): Don't blindly alloca invocation name;
6739 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6740 not fit in int.
6741
6e1a67fb
PE
6742 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6743 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6744 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6745
0df02bf3
PE
6746 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6747 Use esprintf, not sprintf, in case result does not fit in int.
6748
48e30793
PE
6749 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6750 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6751 it as a large positive number.
6752 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6753 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6754
a66ff6d8
PE
6755 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6756 in case result does not fit in int.
6757
aca216ff
PE
6758 * print.c (float_to_string): Detect width overflow more reliably.
6759 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6760 buffer overrun. Don't assume list length fits in 'int'. Treat
6761 print length of 0 as 0, not as infinity; to be consistent with other
6762 uses of print length in this function. Don't overflow print length
6763 index. Don't assume hash table size fits in 'long', or that
6764 vectorlike size fits in 'unsigned long'.
6765
31c286f7
PE
6766 * process.c (make_process): Use printmax_t, not int, to format
6767 process-name gensyms.
6768
55e5faa1
PE
6769 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6770
80f2e268
PE
6771 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6772 to avoid potential buffer overrun.
6773
670741ab
PE
6774 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6775 if X resource line is longer than 512 bytes.
6776
b7163a50
PE
6777 * xfns.c (x_window): Make sprintf buffer a bit bigger
6778 to avoid potential buffer overrun.
6779
ae58ff1f
PE
6780 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6781
c43c8a6a
PE
6782 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6783
3f8236f4
PE
67842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6785
53e9fe90 6786 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6787 Without these, Emacs silently mishandles large integers sometimes.
6788 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6789 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6790
6511acf2
PE
6791 * xdisp.c (try_window_id): Check Emacs fixnum range before
6792 converting to 'int'.
806add1d 6793
6511acf2 6794 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6795 Check that an Emacs fixnum is in range before assigning it to 'int'.
6796 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6797 values converted from Emacs fixnums.
6798 (Frecenter): Don't wrap around a line count if it is out of 'int'
6799 range; instead, treat it as an extreme value.
6800 (Fset_window_configuration, compare_window_configurations):
6801 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6802
6511acf2
PE
6803 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6804 that can exceed INT_MAX. Check that EMACS_INT value is in range
6805 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6806 (match_limit): Don't assume that a fixnum can fit in 'int'.
6807
6511acf2 6808 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6809 exceed INT_MAX.
6810
6511acf2 6811 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6812 (Fvertical_motion): Don't wrap around LINES values that don't fit
6813 in 'int'. Instead, treat them as extreme values. This is good
6814 enough for windows, which can't have more than INT_MAX lines anyway.
6815
fcb901a7
LMI
68162011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6817
0f2f6b6d
LMI
6818 * Require libxml/parser.h to avoid compilation warning.
6819
fcb901a7
LMI
6820 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6821
6822 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6823 since this reportedly can destroy thread storage.
6824
6e20a0d4
CY
68252011-08-30 Chong Yidong <cyd@stupidchicken.com>
6826
6827 * syntax.c (find_defun_start): Update all cache variables if
6828 exiting early (Bug#9401).
6829
148ae00e
EZ
68302011-08-30 Eli Zaretskii <eliz@gnu.org>
6831
f6cfbd8f
EZ
6832 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6833
148ae00e
EZ
6834 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6835 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6836 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6837
6838 * term.c (tty_append_glyph): New function.
6839 (produce_stretch_glyph): Static function and its prototype deleted.
6840
a66cfb1c
SM
6841 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6842 Add prototypes.
148ae00e 6843
c4a07a4c
PE
68442011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6845
6846 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6847 when checking :margin (Bug#9390).
6848 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6849 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6850 so that the name doesn't mislead. All uses changed.
6851
6bc8cd65
JB
68522011-08-28 Johan Bockgård <bojohan@gnu.org>
6853
6854 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6855 set_tty_hooks.
6856
dca4927e
EZ
68572011-08-27 Eli Zaretskii <eliz@gnu.org>
6858
6859 * xdisp.c (move_it_to): Don't bail out early when reaching
6860 position beyond to_charpos, if we are scanning backwards.
6861 (move_it_vertically_backward): When DY == 0, make sure we get to
6862 the first character in the line after the newline.
6863
f2cad773
PE
68642011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6865
6866 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6867 (ccl_driver): Do not generate an out-of-range pointer.
6868 (Fccl_execute_on_string): Remove unnecessary check for
6869 integer overflow, noted by Stefan Monnier in
6870 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6871 Remove a FIXME that didn't need fixing.
6872 Simplify the newly-introduced buffer reallocation code.
6873
0cae2cdb
JB
68742011-08-27 Juanma Barranquero <lekktu@gmail.com>
6875
6876 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6877
5fc295a4 68782011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6879
70c60eb2 6880 Integer and memory overflow issues (Bug#9196).
726e0ab1 6881
d31850da
PE
6882 * doc.c (get_doc_string): Rework so that
6883 get_doc_string_buffer_size is the actual buffer size, rather than
6884 being 1 less than the actual buffer size; this makes xpalloc more
6885 convenient.
6886
a69fbedb
PE
6887 * image.c (x_allocate_bitmap_record, cache_image):
6888 * xselect.c (Fx_register_dnd_atom):
6889 Simplify previous changes by using xpalloc.
6890
fe5c5d37
PE
6891 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6892 since either will do and ptrdiff_t is convenient with xpalloc.
6893
0065d054
PE
6894 * charset.c (charset_table_size)
6895 (struct charset_sort_data.priority): Now ptrdiff_t.
6896 (charset_compare): Don't overflow if priorities differ greatly.
6897 (Fsort_charsets): Don't assume list length fits in int.
6898 Check for size-calculation overflow when allocating sort data.
6899 (syms_of_charset): Allocate an initial charset table that is
6900 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6901
6902 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6903
6904 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6905 The actual value is always <= INT_MAX, and leaving it unsigned made
6906 overflow checking harder.
6907
6908 * dispextern.h (struct glyph_matrix.rows_allocated)
6909 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6910 with xpalloc. The values are still always <= INT_MAX.
6911
6912 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6913
6914 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6915 (SAFE_NALLOCA): New macro.
6916
6917 * region-cache.c (struct boundary.pos, find_cache_boundary)
6918 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6919 (set_cache_region, invalidate_region_cache)
6920 (revalidate_region_cache, know_region_cache, region_cache_forward)
6921 (region_cache_backward, pp_cache):
6922 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6923 so that ptrdiff_t * can be passed to xpalloc.
6924 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6925 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6926 (pp_cache): Don't assume cache_len fits in int.
6927 * region-cache.h: Adjust extern decls to match.
6928
6929 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6930 EMACS_INT, since either will do, for xpalloc.
6931
6932 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6933 (xnmalloc, xnrealloc, xpalloc): New functions.
6934
726e0ab1
PE
6935 * bidi.c (bidi_shelve_header_size): New constant.
6936 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6937 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6938
51f30bc5 6939 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6940 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6941 (overlay_strings):
6942 Don't update size of array until after memory allocation succeeds,
6943 because xmalloc/xrealloc may not return.
0065d054
PE
6944 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6945 now that we have proper integer overflow checking.
6946 (record_overlay_string, overlay_strings): Catch overflows when
6947 calculating size of overlay_str_buf.
726e0ab1 6948
0065d054
PE
6949 * callproc.c (Fcall_process): Check for size overflow when
6950 calculating size of args2.
6951 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6952 Normally we prefer signed values, but sticking with ptrdiff_t would
6953 require adding more-complicated checks.
726e0ab1
PE
6954
6955 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6956 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6957 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6958 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6959
6960 * character.c (Fstring): Check for size-calculation overflow.
6961
6962 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6963 unnecessary integer overflow. Check for size overflow.
6964 (encode_coding_object): Don't update size until xmalloc succeeds.
6965
6966 * composite.c (get_composition_id): Check for overflow in glyph
6967 length calculations.
6968
6969 Integer and memory overflow fixes for display code.
6970 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6971 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6972 (scrolling_window): Check for overflow in size calculations.
6973 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6974 Don't assume glyph table len fits in int.
6975 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6976 (row_table_size): Now ptrdiff_t, not int.
6977 (scrolling_window): Avoid overflow in size calculations.
6978 Don't update size until allocation succeeds.
6979 * fns.c (concat): Check for overflow in size calculations.
6980 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6981 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6982 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6983
6984 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6985 (get_doc_string): Check for size calculation overflow.
6986 Don't update size until allocation succeeds.
6987 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6988 EMACS_INT, where ptrdiff_t will do.
6989 (Fsubstitute_command_keys): Check for string overflow.
6990
6991 * editfns.c (set_time_zone_rule): Don't assume environment length
6992 fits in int.
6993 (message_length): Now ptrdiff_t, not int.
6994 (Fmessage_box): Don't update size until allocation succeeds.
6995 Don't assume message length fits in int.
6996 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6997
0065d054
PE
6998 * emacs.c (main): Do not reallocate argv, since there is a null at
6999 the end that can be overwritten, and this way there's no need to
7000 worry about size-calculation overflow.
7001 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7002
7003 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7004 alloc succeeds.
7005 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7006
7007 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7008 (x_set_scroll_bar_width, x_figure_window_size):
7009 Check for integer overflow.
7010 (x_set_alpha): Do not assume XINT fits in int.
7011
7012 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7013 This is for the members text_lines, text_cols, total_lines, total_cols,
7014 where the system imposes an 'int' limit.
7015
7016 * fringe.c (Fdefine_fringe_bitmap):
7017 Don't update size until alloc works.
7018
7019 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7020 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7021
7022 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7023 Check for size-calculation overflow.
7024 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7025 do, as we prefer signed integers.
7026 (id_to_widget.max_size, id_to_widget.used)
7027 (xg_store_widget_in_map, xg_remove_widget_from_map)
7028 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7029 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7030 Use and return ptrdiff_t, not int.
7031 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7032 * gtkutil.h: Change prototypes to match the above.
7033
7034 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7035 are duplicate now that they've been promoted to lisp.h.
7036 (x_allocate_bitmap_record, x_alloc_image_color)
7037 (make_image_cache, cache_image, xpm_load):
7038 Don't update size until alloc is done.
7039 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7040 (x_detect_edges):
3256efce 7041 Check for size calculation overflow.
726e0ab1
PE
7042 (ct_colors_allocated_max): New constant.
7043 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7044 overflow.
3256efce 7045
726e0ab1
PE
7046 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7047 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7048 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7049 Use ptrdiff_t, not int, to count maps.
7050 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7051 calculations. Don't update size until allocation succeeds.
7052 Redo calculations to avoid overflow.
726e0ab1
PE
7053 * keyboard.h: Change prototypes to match the above.
7054
7055 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7056 to count maps.
7057 (current_minor_maps): Check for size calculation overflow.
7058 * keymap.h: Change prototypes to match the above.
7059
7060 * lread.c (read1, init_obarray): Don't update size until alloc done.
7061
7062 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7063 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7064
726e0ab1
PE
7065 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7066 Now ptrdiff_t, not int.
7067 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7068 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7069
7070 * process.c (Fnetwork_interface_list): Check for overflow
7071 in size calculation.
7072
7073 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7074
7075 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7076 overflow. Don't bother calling xmalloc when xrealloc will do.
7077
7078 * search.c (Freplace_match): Check for size calculation overflow.
7079 (Fset_match_data): Don't assume list lengths fit in 'int'.
7080
7081 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7082 for command line length. Do not attempt to address one before the
7083 beginning of an array, as that's not portable.
7084
7085 * term.c (max_frame_lines): Remove; unused.
7086 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7087 not int.
7088 (encode_terminal_code, calculate_costs): Check for size
7089 calculation overflow.
7090 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7091 table lengths and related sizes. Don't update size until alloc
7092 done. Redo calculations to avoid overflow.
7093 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7094
7095 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7096 subtracting pointers.
7097 (gobble_line): Check for overflow more carefully. Don't update size
7098 until alloc done.
7099
7100 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7101 Don't update size until alloc done.
7102 Redo size calculations to avoid overflow.
7103 Check for size calculation overflow.
0065d054 7104 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7105
7106 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7107 Use ptrdiff_t, not int, for sizes.
7108 (store_mode_line_noprop_char): Don't update size until alloc done.
7109
0065d054
PE
7110 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7111 Use ptrdiff_t, not int, for sizes.
7112 (Finternal_make_lisp_face, cache_face):
7113 Check for size calculation overflow.
7114 (cache_face): Treat size calculation overflows as if they were
7115 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7116
7117 * xfns.c (x_encode_text, x_set_name_internal)
7118 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7119 sizes, since they can exceed INT_MAX in size. Check for size
7120 calculation overflow.
7121
0065d054
PE
7122 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7123 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7124 Don't update size until alloc done.
7125
0065d054 7126 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7127 as sprintf is limited to int lengths.
1d526e2f 7128
252c5ee1
PE
7129 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7130 (X_LONG_MIN): New macros.
864d7ce7
PE
7131 Use them to make the following changes clearer.
7132 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7133 This change doesn't affect the value now, but it may help remind
7134 future maintainers not to raise the value too much later.
7135 (SELECTION_QUANTUM): Remove, replacing with ...
7136 (selection_quantum): ... new function, which avoids overflow.
7137 All uses changed.
7138 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7139 assumption that selection length fits in 'int'.
7140 (x_reply_selection_request, x_handle_selection_request)
7141 (x_get_window_property, receive_incremental_selection)
7142 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7143 (lisp_data_to_selection_data, clean_local_selection_data):
7144 Use ptrdiff_t, not int, to record length of selection.
7145 (x_reply_selection_request, x_get_window_property)
7146 (receive_incremental_selection, x_property_data_to_lisp):
7147 Redo calculations to avoid overflow.
7148 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7149 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7150 something.
7151 (x_get_window_property, receive_incremental_selection)
7152 (lisp_data_to_selection_data, x_property_data_to_lisp):
7153 Check for size-calculation overflow.
7154 (x_get_window_property, receive_incremental_selection)
7155 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7156 Don't store size until memory allocation succeeds.
7157 (x_get_window_property): Plug memory leak on memory exhaustion.
7158 Don't double-block input; malloc is safe here. Don't assume 2**34
7159 - 4 fits in unsigned long. Add an xassert to check
7160 XGetWindowProperty overflow. Be more careful about overflow
7161 calculations, and distinguish size from memory overflow better.
7162 (receive_incremental_selection): When tracing, don't assume
7163 unsigned int is less than INT_MAX.
7164 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7165 harmful) conversions of unsigned short to int.
7166 (lisp_data_to_selection_data): Don't assume that integers
7167 in the range -65535 through -1 fit in an X unsigned short.
7168 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7169 result parameters unless successful. Rely on cons_to_unsigned
7170 to report problems with elements; the old code wasn't right anyway.
7171 (x_check_property_data): Check for int overflow; we cannot use
7172 a wider type due to X limits.
7173 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7174
726e0ab1 7175 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7176
0065d054
PE
7177 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7178 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7179 (x_color_cells): Don't store size until memory allocation succeeds.
7180 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7181 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7182 (x_term_init): Don't assume length fits in int (sprintf is limited
7183 to int size).
bc18e09d 7184
ebfa62c0
PE
7185 Use ptrdiff_t for composition IDs.
7186 * character.c (lisp_string_width):
7187 * composite.c (composition_table_size, n_compositions)
7188 (get_composition_id, composition_gstring_from_id):
7189 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7190 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7191 * window.c (Frecenter):
7192 Use ptrdiff_t, not int, for composition IDs.
7193 * composite.c (get_composition_id): Check for integer overflow.
7194 * composite.h: Adjust prototypes to match the above changes.
7195
d3411f89
PE
7196 Use ptrdiff_t for hash table indexes.
7197 * category.c (hash_get_category_set):
7198 * ccl.c (ccl_driver):
7199 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7200 * coding.c (coding_system_charset_list, detect_coding_system):
7201 * coding.h (struct coding_system.id):
7202 * composite.c (get_composition_id, gstring_lookup_cache):
7203 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7204 * image.c (xpm_get_color_table_h):
7205 * lisp.h (hash_lookup, hash_put):
7206 * minibuf.c (Ftest_completion):
7207 Use ptrdiff_t for hash table indexes, not int (which is too
7208 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7209 32-bit --with-wide-int hosts).
7210
e097a6fa
PE
7211 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7212 Add a FIXME comment about memory leaks.
7213 (syms_of_charset): Don't assume xmalloc returns.
7214
5637687f
PE
7215 Don't assume that stated character widths fit in int.
7216 * character.c (Fchar_width, c_string_width, lisp_string_width):
7217 * character.h (CHAR_WIDTH):
7218 * indent.c (MULTIBYTE_BYTES_WIDTH):
7219 Use sanitize_char_width to avoid undefined and/or bad behavior
7220 with outlandish widths.
a66cfb1c 7221 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7222 now that we have two such functions. All uses changed.
7223 (sanitize_char_width): New inline function.
7224
a2271ba2
PE
7225 Don't assume that tab-width fits in int.
7226 * character.h (sanitize_width): New inline function.
7227 (SANE_TAB_WIDTH): New macro.
7228 (ASCII_CHAR_WIDTH): Use it.
7229 * indent.c (sane_tab_width): Remove. All uses replaced by
7230 SANE_TAB_WIDTH (current_buffer).
7231 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7232
18c52557
PE
7233 * fileio.c: Integer overflow issues with file modes.
7234 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7235
caeeedc1
PE
7236 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7237 Remove unreachable code.
7238 (read_hex, load_charset_map_from_file): Check for integer overflow.
7239
6df6ae42 7240 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7241 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7242 (x_send_scroll_bar_event): Likewise. Check that the size does not
7243 exceed limits imposed by XClientMessageEvent, as well as the usual
7244 ptrdiff_t and size_t limits.
7245
b13995db
PE
7246 * keyboard.c: Overflow, signedness and related fixes.
7247 (make_lispy_movement): Use same integer type in forward decl
7248 that is used in the definition.
7249 (read_key_sequence, keyremap_step):
7250 Change bufsize argument back to int, undoing my 2011-03-30 change.
7251 We prefer signed types, and int is wide enough here.
7252 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7253 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7254 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7255 length, not size_t. Use ptrdiff_t for index, not int.
7256 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7257 possibility of integer overflow.
7258
13464394
PE
7259 Overflow, signedness and related fixes for images.
7260
7261 * dispextern.h (struct it.stack[0].u.image.image_id)
7262 (struct_it.image_id, struct image.id, struct image_cache.size)
7263 (struct image_cache.used, struct image_cache.ref_count):
7264 * gtkutil.c (update_frame_tool_bar):
7265 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7266 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7267 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7268 * nsmenu.m (update_frame_tool_bar):
7269 * xdisp.c (calc_pixel_width_or_height):
7270 * xfns.c (image_cache_refcount):
7271 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7272 on typical 64-bit hosts.
7273
7274 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7275 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7276 Omit unnecessary casts to int.
7277 (parse_image_spec): Check that integers fall into 'int' range
7278 when the callers expect that.
7279 (image_ascent): Redo ascent calculation to avoid int overflow.
7280 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7281 (lookup_image): Remove unnecessary tests.
7282 (xbm_image_p): Locals are now of int, not EMACS_INT,
7283 since parse_image_check makes sure they fit into int.
7284 (png_load, gif_load, svg_load_image):
7285 Prefer int to unsigned where either will do.
7286 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7287 old tiff_error_handler and tiff_warning_handler.
7288 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7289 stack buffer overflows. It uses only the features of vsnprintf
7290 that are common to both POSIX and native Microsoft.
7291 (tiff_error_handler, tiff_warning_handler): Use it.
7292 (tiff_load, gif_load, imagemagick_load_image):
7293 Don't assume :index value fits in 'int'.
7294 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7295 (imagemagick_load_image): Check that crop parameters fit into
7296 the integer types that MagickCropImage accepts. Don't assume
7297 Vimagemagick_render_type has a nonnegative value. Don't assume
7298 size_t fits in 'long'.
7299 (gs_load): Use printmax_t to print the widest integers possible.
7300 Check for integer overflow when computing image height and width.
7301
c11821d4
EZ
73022011-08-26 Eli Zaretskii <eliz@gnu.org>
7303
7304 * xdisp.c (redisplay_window): Don't force window start if point
7305 will be invisible in the resulting window. (Bug#9324)
7306
0c95fcf7
EZ
73072011-08-25 Eli Zaretskii <eliz@gnu.org>
7308
7309 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7310 the display spec is of the form `(space ...)'.
7311 (handle_display_spec): Return the value returned by
7312 handle_single_display_spec, not just 1 or zero.
7313 (handle_single_display_spec): If the display spec is of the form
7314 `(space ...)', and specifies display in the text area, return 2
7315 rather than 1.
fee65a97 7316 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7317 accurately, and prefer exact match for point under bidi.
7318 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7319
7320 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7321 into disp_prop; all users changed.
7322
7323 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7324 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7325 for the text covered by the display property.
7326
e4ed06f1
CY
73272011-08-25 Chong Yidong <cyd@stupidchicken.com>
7328
7329 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7330 Change return value to nil.
7331 (Frecord_buffer): Delete unused function.
7332
f67cdd7f
EZ
73332011-08-24 Eli Zaretskii <eliz@gnu.org>
7334
5980d4c6
EZ
7335 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7336 buffers, return left-to-right.
8610fe8b
EZ
7337 (set_cursor_from_row): Consider candidate row a win if its glyph
7338 represents a newline and point is on that newline. Fixes cursor
7339 positioning on the newline at EOL of R2L text within L2R
7340 paragraph, and vice versa.
7341 (try_cursor_movement): Check continued rows, in addition to
7342 continuation rows. Fixes unwarranted scroll when point enters a
7343 continued line of R2L text within an L2R paragraph, or vice versa.
7344 (cursor_row_p): Consider the case of point being equal to
7345 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7346 from the end of a short line to the beginning of a continued line
7347 of R2L text within L2R paragraph.
7348 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7349 composed characters.
5980d4c6 7350
f67cdd7f
EZ
7351 * bidi.c (bidi_check_type): Use xassert.
7352 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7353 members.
7354
bca633fb
EZ
73552011-08-23 Eli Zaretskii <eliz@gnu.org>
7356
7357 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7358 a character.
7359
4a5885a7
CY
73602011-08-23 Chong Yidong <cyd@stupidchicken.com>
7361
7362 * nsfont.m (ns_otf_to_script): Fix typo.
7363
0902a04e
KH
73642011-08-22 Kenichi Handa <handa@m17n.org>
7365
7366 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7367 extra slot even if the purpose is char-code-property-table.
7368
1a2e6670
EZ
73692011-08-23 Eli Zaretskii <eliz@gnu.org>
7370
8ddde651
EZ
7371 * xdisp.c (redisplay_window): When computing centering_position,
7372 account for the height of the header line. (Bug#8874)
7373
425cc014
EZ
7374 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7375 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7376 candidate is selected by the mouse, and that candidate has a
7377 composed character under the mouse.
7378
1a2e6670
EZ
7379 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7380 coordinates reported by pos-visible-in-window-p for a composed
7381 character in column zero.
7382
8b76d6f8
SM
73832011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7384
7385 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7386
dac347dd
EZ
73872011-08-22 Eli Zaretskii <eliz@gnu.org>
7388
7389 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7390 consider it a hit if to_charpos is anywhere in the range of the
7391 composed buffer positions.
7392
e013fb34
CY
73932011-08-22 Chong Yidong <cyd@stupidchicken.com>
7394
7395 * image.c (gif_load): Don't assume that each subimage has the same
7396 dimensions as the base image. Handle disposal method that is
7397 "undefined" by the gif spec (Bug#9335).
7398
bd1ba3e8
CY
73992011-08-20 Chong Yidong <cyd@stupidchicken.com>
7400
7401 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7402 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7403
54a1215b
EZ
74042011-08-19 Eli Zaretskii <eliz@gnu.org>
7405
823564e5
EZ
7406 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7407 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7408 from an Org mode buffer to a Speedbar frame.
7409
54a1215b
EZ
7410 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7411 a composition, take its buffer position from IT->cmp_it.charpos.
7412 Fixes cursor positioning at the beginning of a line that begins
7413 with a composed character.
7414
9778ebcc
EZ
74152011-08-18 Eli Zaretskii <eliz@gnu.org>
7416
0be6ee06
EZ
7417 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7418 character bidirectional type, use STRONG_L instead. Fixes crashes
7419 in a buffer produced by `describe-categories'.
7420
9778ebcc
EZ
7421 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7422 members before the level stack, so they would be saved and
7423 restored when copying iterator state. Fixes incorrect reordering
7424 around TABs covered by display properties.
7425
156bffbe
AS
74262011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7427
6b02f655 7428 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7429
72ad093b
CY
74302011-08-17 Chong Yidong <cyd@stupidchicken.com>
7431
7432 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7433 (internal_condition_case_2, internal_condition_case_n):
7434 Remove unnecessary aborts (Bug#9081).
72ad093b 7435
35774242
EZ
74362011-08-17 Eli Zaretskii <eliz@gnu.org>
7437
7438 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7439 has no `load' handler, try opening the file locally. (Bug#9311)
7440
db76dd85
KB
74412011-08-16 Ken Brown <kbrown@cornell.edu>
7442
7443 * gmalloc.c: Expand comment.
7444
b215eee5
EZ
74452011-08-16 Eli Zaretskii <eliz@gnu.org>
7446
7447 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7448 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7449
a4579d33
KB
74502011-08-16 Ken Brown <kbrown@cornell.edu>
7451
7452 Fix memory allocation problems in Cygwin build (Bug#9273).
7453
7454 * unexcw.c ( __malloc_initialized): Declare external variable.
7455 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7456
8b76d6f8
SM
7457 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7458 New variables.
a4579d33
KB
7459 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7460 dumped emacs.
7461 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7462 in the static heap.
7463 [CYGWIN] (special_realloc): New function.
7464 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7465 requests to realloc storage in the static heap.
7466
3ebec551
PE
74672011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7468
7469 * bidi.c (bidi_initialize): Remove unused local.
7470
9fd8be00
EZ
74712011-08-15 Eli Zaretskii <eliz@gnu.org>
7472
6b02f655
SM
7473 * bidimirror.h:
7474 * biditype.h: Remove file.
7475 * makefile.w32-in ($(BLD)/bidi.$(O)):
7476 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7477
7478 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7479
7480 * chartab.c: Improve commentary for the uniprop_table API.
7481
32413314
EZ
7482 * bidi.c (bidi_paragraph_init): Support zero value of
7483 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7484 (bidi_initialize): Use uniprop_table instead of including
7485 biditype.h and bidimirror.h.
32413314 7486
9fd8be00
EZ
7487 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7488 coordinates of the iterator when restoring from ppos_it.
7489 (Bug#9296)
7490
5cf2b69b
KH
74912011-08-14 Kenichi Handa <handa@m17n.org>
7492
7493 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7494 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7495
daf17d00
EZ
74962011-08-14 Eli Zaretskii <eliz@gnu.org>
7497
7498 * xdisp.c (move_it_in_display_line_to): Don't invoke
7499 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7500 ppos_it. Fixes vertical cursor motion when line beginning is
7501 covered by an image. (Bug#9296)
7502
08e3161a
JD
75032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7504
7505 * nsterm.h (ns_run_ascript): Declare.
7506 (NSAPP_DATA2_RUNASSCRIPT): Define.
7507
7508 * nsfns.m (as_script, as_result, as_status): New static variables.
7509 (ns_run_ascript): New function.
5e617bc2 7510 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7511 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7512 the event loop. Get status from as_status (Bug#7276).
7513
7514 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7515 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7516 the event loop (Bug#7276).
7517
a3720aa2
AS
75182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7519
7520 * gnutls.c (QCgnutls_bootprop_priority)
7521 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7522 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7523 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7524 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7525 (QCgnutls_bootprop_verify_hostname_error)
7526 (QCgnutls_bootprop_callbacks_verify): Rename from
7527 Qgnutls_bootprop_..., all uses changed.
7528
7529 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7530 uses changed.
7531
0a0d27fb
PE
75322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7533
19d5c50c
PE
7534 * xfaces.c (Qframe_set_background_mode): Now static.
7535 * dispextern.h (Qframe_set_background_mode): Remove decl.
7536
0a0d27fb
PE
7537 * process.c (Fnetwork_interface_info): Declare local only if needed.
7538
377538cb
JD
75392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7540
7541 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7542 (Fnetwork_interface_list): Allocate in increments of bytes instead
7543 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7544 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7545 sockaddr.
7546 (struct ifflag_def): notrailers is smart on OSX.
7547 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7548 Get hardware address with getifaddrs if available.
7549
08fff70c
EZ
75502011-08-12 Eli Zaretskii <eliz@gnu.org>
7551
7552 * xdisp.c (iterate_out_of_display_property): xassert that
7553 IT->position is set to within IT->object's boundaries. Break from
7554 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7555 when IT->position is set up wrongly due to some bug.
7556 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7557 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7558 entry. Force push_it to save on the stack the current
7559 buffer/string position, to be restored by pop_it. Fix flags in
7560 the iterator structure wrt the object coming from a display
7561 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7562 properties. (Bug#9284)
7563
7be1c708 75642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7565
7be1c708
CY
7566 * fontset.c (fontset_get_font_group): Add proper type checks.
7567 (Bug#9172)
aac0c6e3 7568
7be1c708 75692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7570
7be1c708
CY
7571 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7572 and LC_VERSION_MIN_MACOSX.
7573 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7574 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7575
97bb72a6
EZ
75762011-08-08 Eli Zaretskii <eliz@gnu.org>
7577
7578 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7579 no-display-properties-and-no-overlays under bidi display.
7580 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7581 properties and overlays.
97bb72a6 7582
d5617611
CY
75832011-08-08 Chong Yidong <cyd@stupidchicken.com>
7584
37e11a63
CY
7585 * editfns.c (Fset_time_zone_rule): Document relationship with the
7586 setenv function.
7587
d5617611
CY
7588 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7589 the font entity extracted from the cache (Bug#8109).
7590
58872834
CY
75912011-08-07 Chong Yidong <cyd@stupidchicken.com>
7592
7593 * composite.c (autocmp_chars): Don't reset point. That is done by
7594 restore_point_unwind (Bug#5984).
7595
75bfc667
JL
75962011-08-07 Juri Linkov <juri@jurta.org>
7597
7598 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7599 to show the arg `TIME' instead of `TIMEVAL'.
7600
d1410150
EZ
76012011-08-06 Eli Zaretskii <eliz@gnu.org>
7602
7603 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7604 display property strides EOL and includes a newline, as in
7605 longlines-mode. (Bug#9254)
75b771e4
EZ
7606 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7607 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7608
7609 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7610 is non-zero, even if the data buffer is NULL. Fixes a crash in
7611 vertical-motion with longlines-mode. (Bug#9254)
7612
35928349
EZ
76132011-08-05 Eli Zaretskii <eliz@gnu.org>
7614
ec7cc85b
EZ
7615 * bidi.c <bidi_cache_total_alloc>: Now static.
7616 (bidi_initialize): Initialize bidi_cache_total_alloc.
7617
8b76d6f8 7618 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7619 cache. (Bug#9221)
7620
7621 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7622 amount allocated this far in `bidi_cache_total_alloc'.
7623 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7624 non-zero, only free the data buffer without restoring the cache
7625 contents. All callers changed.
7626
7627 * dispextern.h (bidi_unshelve_cache): Update prototype.
7628
7629 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7630 (move_it_in_display_line, move_it_to)
7631 (move_it_vertically_backward, move_it_by_lines): Replace the call
7632 to xfree to an equivalent call to bidi_unshelve_cache.
7633 (move_it_in_display_line_to): Fix logic of returning
412b6358 7634 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7635
e2e2423b
EZ
76362011-08-05 Eli Zaretskii <eliz@gnu.org>
7637
7638 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7639 came from a string character with a `cursor' property. (Bug#9229)
7640
ae9e757a
JD
76412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7642
7643 * Makefile.in (LIB_PTHREAD): New variable.
7644 (LIBES): Add LIB_PTHREAD (Bug#9216).
7645
7646 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7647 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7648
213bd7f2
AS
76492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7650
6b02f655 7651 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7652
99aaf75f
JD
76532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7654
7655 * xterm.c (x_find_topmost_parent): New function.
7656 (x_set_frame_alpha): Find topmost parent window with
7657 x_find_topmost_parent and set the property there also (bug#9181).
7658 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7659
c74e9d86
PE
76602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7661
7662 * callproc.c (Fcall_process): Avoid vfork clobbering
7663 the local vars buffer, coding_systems, current_dir.
7664
640c8776
SM
76652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7666
7667 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7668
f26d0e4c
PE
76692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7670
8a10d76c
PE
7671 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7672 so that it is not optimized away.
7673
f26d0e4c
PE
7674 * xdisp.c (compute_display_string_pos): Remove unused local.
7675
55439c61
EZ
76762011-08-02 Eli Zaretskii <eliz@gnu.org>
7677
7678 Fix slow cursor motion and scrolling in large buffers with
7679 selective display, like Org Mode buffers. (Bug#9218)
7680
7681 * dispextern.h (struct bidi_it): New member disp_prop_p.
7682
7683 * xdisp.c: Remove one-slot cache of display string positions.
7684 (compute_display_string_pos): Accept an additional argument
5e617bc2 7685 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7686 for a display string or property. If found, set DISP_PROP_P
7687 non-zero.
7688
7689 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7690 DISP_PROP_P, and pass it to compute_display_string_pos.
7691 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7692 non-zero. All callers of bidi_fetch_char changed.
7693
fb33fa43
SM
76942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7695
7696 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7697
b099e063
DM
76982010-12-03 Don March <don@ohspite.net>
7699
7700 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7701 last character M-[char] is translated to ESC [char] (bug#7541).
7702
5cc7f7af
KH
77032011-08-02 Kenichi Handa <handa@m17n.org>
7704
d0fffa3f 7705 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7706
7707 * chartab.c (uniprop_table): Make it non-static.
7708
525d5e6e
EZ
77092011-08-01 Eli Zaretskii <eliz@gnu.org>
7710
7711 * xdisp.c (forward_to_next_line_start): Accept additional argument
7712 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7713 on the newline.
7714 (reseat_at_next_visible_line_start): Use the bidi iterator state
7715 returned by forward_to_next_line_start to restore the state of
7716 it->bidi_it after backing up to previous newline. (Bug#9212)
7717
31011111
AS
77182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7719
7720 * regex.c (re_comp): Protoize.
7721 (re_exec): Fix return type.
7722 (regexec): Fix type of `ret'. (Bug#9203)
7723
476371c4
PE
77242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7725
e5d76069
PE
7726 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7727 This is needed if max-image-size is a floating-point number.
7728
9a79b20c
AS
77292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7730
7731 * print.c (print_object): Print empty symbol as ##.
7732
7733 * lread.c (read1): Read ## as empty symbol.
7734
d8c2fa78
AA
77352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7736
7737 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7738 setting frame foreground color (Bug#9175).
7739 (x_set_background_color): Likewise.
7740
ffe57a7a
AA
7741 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7742 contents (Bug#9176).
7743 (EmacsTooltip -init): Remove bezels and add shadows to
7744 tooltip windows.
7745
bf3492a5
AA
7746 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7747 or scroll bar (Bug#8470).
7748
d55e9c53
AA
7749 * nsfont.m (nsfont_open): Remove assignment to voffset and
7750 unnecessary vars hshink, expand, hd, full_height, min_height.
7751 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7752
7753 * nsterm.h (nsfont_info): Remove voffset field.
7754
d8c2fa78 77552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7756
7757 Implement strike-through and overline on NextStep (Bug#8863).
7758
7759 * nsfont.m (nsfont_open): Use underline position provided by font,
7760 instead of hard-coded value of 2.
7761 (nsfont_draw): Call ns_draw_text_decoration instead.
7762
7763 * nsterm.h: Add declaration for ns_draw_text_decoration.
7764
7765 * nsterm.m (ns_draw_text_decoration): New function for drawing
7766 underline, overline, and strike-through.
7767 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7768 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7769 accommodate underlining, etc.
4843aac3 7770
4cc60b9b
EZ
77712011-07-28 Eli Zaretskii <eliz@gnu.org>
7772
bc7ece87
EZ
7773 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7774 default.
4cc60b9b 7775
476371c4
PE
77762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7777
66606eea
PE
7778 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7779 Without this fix, if a signal arrives just after memory fills up,
7780 'malloc' might be invoked reentrantly.
7781
476371c4
PE
7782 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7783 In other words, assume that every image size is allowed, on non-X
7784 hosts. This assumption is probably wrong, but it lets Emacs compile.
7785
f3fcc40d
AS
77862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7787
7788 * regex.c (re_iswctype): Convert return values to boolean.
7789
350c992f
EZ
77902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7791
7792 * xdisp.c (compute_display_string_pos): Don't use cached display
7793 string position if the buffer had its restriction changed.
7794 (Bug#9184)
7795
5266b4bb
PE
77962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7797
7798 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7799
2573a837 78002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7801
41f55ccd 7802 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7803
39e378da
PE
7804 * bidi.c: Integer size and overflow fixes.
7805 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7806 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7807 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7808 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7809 (bidi_find_other_level_edge):
7810 Use ptrdiff_t instead of EMACS_INT where either will do.
7811 This works better on 32-bit hosts configured --with-wide-int.
7812 (bidi_cache_ensure_space): Check for size-calculation overflow.
7813 Use % rather than repeated addition, for better worst-case speed.
7814 Don't set bidi_cache_size until after xrealloc returns, because it
7815 might not return.
7816 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7817 (bidi_cache_ensure_space): Also check that the bidi cache size
7818 does not exceed that of the largest Lisp string or buffer. See Eli
7819 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7820
5e927815
PE
7821 * alloc.c (__malloc_size_t): Remove.
7822 All uses replaced by size_t. See Andreas Schwab's note
7823 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7824
ca4aa935
PE
7825 * image.c: Improve checking for integer overflow.
7826 (check_image_size): Assume that f is nonnull, since
7827 it is always nonnull in practice. This is one less thing to
7828 worry about when checking for integer overflow later.
7829 (x_check_image_size): New function, which checks for integer
7830 overflow issues inside X.
7831 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7832 This removes the need for a memory_full check.
7833 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7834 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7835 (xbm_read_bitmap_data): Change locals back to 'int', since
7836 their values must fit in 'int'.
7837 (xpm_load_image, png_load, tiff_load):
7838 Invoke x_create_x_image_and_pixmap earlier,
7839 to avoid much needless work if the image is too large.
7840 (tiff_load): Treat overly large images as if
7841 x_create_x_image_and_pixmap failed, not as malloc failures.
7842 (gs_load): Use x_check_image_size.
7843
5f8f9cc2
PE
7844 * gtkutil.c: Omit integer casts.
7845 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7846 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7847
5adf60bc
PE
7848 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7849
c8907a93
PE
7850 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7851 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7852 would wrongly return t on a 64-bit host.
7853
e3c25c68
PE
7854 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7855 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7856 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7857 and therefore cause GCC to emit a bogus diagnostic in some cases.
7858
3f791afe
PE
7859 * image.c: Integer signedness and overflow and related fixes.
7860 This is not an exhaustive set of fixes, but it's time to
7861 record what I've got.
7862 (lookup_pixel_color, check_image_size): Remove redundant decls.
7863 (check_image_size): Don't assume that arbitrary EMACS_INT values
7864 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7865 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7866 (tiff_load, imagemagick_load_image):
7867 Check for overflow in size calculations.
7868 (x_create_x_image_and_pixmap): Remove unnecessary test for
7869 xmalloc returning NULL; that can't happen.
7870 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7871 (xpm_color_bucket): Use better integer hashing function.
7872 (xpm_cache_color): Don't possibly over-allocate memory.
7873 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7874 (gif_memory_source):
7875 Use ptrdiff_t, not int or size_t, to record sizes.
7876 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7877 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7878 either works, as we prefer signed integers.
7879 (tiff_read_from_memory, tiff_write_from_memory):
7880 Return tsize_t, not size_t, since that's what the TIFF API wants.
7881 (tiff_read_from_memory): Don't fail simply because the read would
7882 go past EOF; instead, return a short read.
7883 (tiff_load): Omit no-longer-needed casts.
7884 (Fimagemagick_types): Don't assume size fits into 'int'.
7885
3cc5a532
PE
7886 Improve hashing quality when configured --with-wide-int.
7887 * fns.c (hash_string): New function, taken from sxhash_string.
7888 Do not discard information about ASCII character case; this
7889 discarding is no longer needed.
7890 (sxhash-string): Use it. Change sig to match it. Caller changed.
7891 * lisp.h: Declare it.
7892 * lread.c (hash_string): Remove, since we now use fns.c's version.
7893 The fns.c version returns a wider integer if --with-wide-int is
7894 specified, so this should help the quality of the hashing a bit.
7895
b312a492
PE
7896 * emacs.c: Integer overflow minor fix.
7897 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7898 Define only if GNU_LINUX.
7899 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7900
dfd153ae
PE
7901 * dispnew.c: Integer signedness and overflow fixes.
7902 Remove unnecessary forward decls, that were a maintenance hassle.
7903 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7904 All uses changed.
7905 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7906 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7907 (prepare_desired_row, line_draw_cost):
7908 Use int, not unsigned, where either works.
7909 (save_current_matrix, restore_current_matrix):
7910 Use ptrdiff_t, not size_t, where either works.
7911 (init_display): Check for overflow more accurately, and without
7912 relying on undefined behavior.
7913
a81d11a3
PE
7914 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7915 Remove, replacing with the new symbols in lisp.h. All uses changed.
7916 * fileio.c (make_temp_name):
7917 * filelock.c (lock_file_1, lock_file):
7918 * xdisp.c (message_dolog):
7919 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7920 Use pMd etc. instead.
7921 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7922 replacing the pWIDE etc. symbols removed from editfns.c.
7923
3300e6fd
PE
7924 * keyboard.h (num_input_events): Now uintmax_t.
7925 This is (very slightly) less likely to mess up due to wraparound.
7926 All uses changed.
7927
fd05c7e9
PE
7928 * buffer.c: Integer signedness fixes.
7929 (alloc_buffer_text, enlarge_buffer_text):
7930 Use ptrdiff_t rather than size_t when either will do, as we prefer
7931 signed integers.
7932
903fe15d
PE
7933 * alloc.c: Integer signedness and overflow fixes.
7934 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7935 (__malloc_size_t): Default to size_t, not to int.
7936 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7937 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7938 Prefer ptrdiff_t to size_t when either would do, as we prefer
7939 signed integers.
7940 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7941 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7942 Now const. Initialize with values that are in range even if char
7943 is signed.
7944 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7945 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7946 These functions do the right thing with sizes > 2**32.
7947 (check_depth): Now ptrdiff_t, not int.
7948 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7949 Adjust to new way of storing sizes. Check for size overflow bugs
7950 in rest of code.
7951 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7952 slightly wrong anyway, as it missed one instance of
7953 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7954 (refill_memory_reserve): Omit needless cast to size_t.
7955 (mark_object_loop_halt): Mark as externally visible.
7956
ac82cc6a
PE
7957 * xselect.c: Integer signedness and overflow fixes.
7958 (Fx_register_dnd_atom, x_handle_dnd_message):
7959 Use ptrdiff_t, not size_t, since we prefer signed.
7960 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7961 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7962 x_dnd_atoms_size and x_dnd_atoms_length.
7963
c2d1e36d
PE
7964 * doprnt.c: Prefer signed to unsigned when either works.
7965 * eval.c (verror):
7966 * doprnt.c (doprnt):
7967 * lisp.h (doprnt):
7968 * xdisp.c (vmessage):
7969 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7970 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7971 prefer signed arithmetic to avoid comparison confusion.
7972 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7973 but is a bit tricky.
7974
0e926e56
PE
7975 Assume freestanding C89 headers, string.h, stdlib.h.
7976 * data.c, doprnt.c, floatfns.c, print.c:
7977 Include float.h unconditionally.
7978 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7979 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7980 * regex.c: Likewise for stddef.h, string.h.
7981 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7982 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7983 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7984 (STDC_HEADERS): Remove obsolete defines.
7985 * sysdep.c: Include limits.h unconditionally.
7986
9cfdb3ec
PE
7987 Assume support for memcmp, memcpy, memmove, memset.
7988 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7989 * regex.c (memcmp, memcpy):
7990 Remove; we assume C89 now.
7991
7992 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7993 (__malloc_safe_bcopy): Remove; no longer needed.
7994
cf950e6b 7995 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7996 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7997 well either way, and we prefer signed to unsigned.
7998
dbf38e02
LMI
79992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8000
8001 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8002 closes the connection while we're reading (bug#9182).
8003
d6f0886c 80042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8005
d6f0886c
JD
8006 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8007 are specified (Bug#9168).
24e0f6b1 8008
2eb1f9e6
PE
80092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8010
8011 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8012 Found by GCC static checking and --with-wide-int on a 32-bit host.
8013
22381272 80142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8015
8016 * xdisp.c (compute_display_string_pos): Fix logic of caching
8017 previous display string position. Initialize cached_prev_pos to
8018 -1. Fixes slow-down at the beginning of a buffer.
8019
f25e39b4
EZ
80202011-07-24 Eli Zaretskii <eliz@gnu.org>
8021
8022 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8023 for attrs[LFACE_FONTSET_INDEX].
8024
04c4b52e
PE
80252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8026
8027 * xml.c (parse_region): Remove unused local
8028 that was recently introduced.
8029
c1734fbd
EZ
80302011-07-23 Eli Zaretskii <eliz@gnu.org>
8031
be18c5a5
EZ
8032 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8033 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8034
c1734fbd
EZ
8035 * xdisp.c (move_it_in_display_line_to): Record the best matching
8036 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8037 exit if none of the characters scanned was an exact match.
8038 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8039 when exact match is impossible due to invisible text, and the
8040 lines are truncated.
8041
a258d627
JD
80422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8043
8044 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8045 for OSX >= 10.7.
8046
b6d5a689
EZ
80472011-07-22 Eli Zaretskii <eliz@gnu.org>
8048
0f74f785
EZ
8049 Fix a significant slow-down of cursor motion with C-n, C-p,
8050 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8051 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8052 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8053 (next_element_from_buffer): Call compute_stop_pos_backwards to
8054 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8055 base_level_stop.
8056 (reseat): Don't look for prev_stop, as that could mean a very long
8057 run.
8058 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8059 <cached_disp_overlay_modiff>: Cache for last found display string
8060 position.
551918c1 8061 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8062 about the same buffer in the same area of character positions, and
8063 the buffer wasn't changed since the time the display string
8064 position was cached.
551918c1 8065
b2d0c91a
EZ
80662011-07-22 Eli Zaretskii <eliz@gnu.org>
8067
8068 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8069 is an integer, which is important for empty lines. (Bug#9149)
8070
043604ee
CY
80712011-07-22 Chong Yidong <cyd@stupidchicken.com>
8072
8073 * frame.c (Fmodify_frame_parameters): In tty case, update the
8074 default face if necessary (Bug#4238).
8075
da4adb04
CY
80762011-07-21 Chong Yidong <cyd@stupidchicken.com>
8077
8078 * editfns.c (Fstring_to_char): No need to explain what a character
8079 is in the docstring (Bug#6576).
8080
9abd0532
LMI
80812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8082
8083 * xml.c (parse_region): Make sure we always return a tree.
8084
36881d16
HK
80852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8086
8087 * xml.c (parse_region): If a document contains only comments,
8088 return that, too.
8089
1e98674d
LMI
80902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8091
8092 * xml.c (make_dom): Return comments, too.
8093
590bd467
PE
80942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8095
8096 Port to OpenBSD.
8097 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8098 and the surrounding thread.
8099 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8100 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8101 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8102 timer goes off.
8103 * s/openbsd.h (BROKEN_SIGIO): Define.
8104 * unexelf.c (unexec) [__OpenBSD__]:
8105 Don't update the .mdebug section of the Alpha COFF symbol table.
8106
f41628b2
LMI
81072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8108
8109 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8110 (bug#8460).
8111
b59b67c5
PE
81122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8113
15e3a074
PE
8114 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8115 This fixes some race conditions on the permissions of any newly
8116 created file.
8117
41bed37d
PE
8118 * alloc.c (valid_pointer_p): Use pipe, not open.
8119 This fixes some permissions issues when debugging.
8120
b59b67c5
PE
8121 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8122 If fchown fails to set both uid and gid, try to set just gid,
8123 as that is sometimes allowed. Adjust the file's mode to eliminate
8124 setuid or setgid bits that are inappropriate if fchown fails.
8125
925a6be7
SM
81262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8127
8128 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8129 to compare Lisp_Objects.
8130 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8131 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8132 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8133
52968808
AS
81342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8135
0a6a104b
AS
8136 * lread.c (read_integer): Unread even EOF character.
8137 (read1): Likewise. Properly record start position of symbol.
8138
52968808
AS
8139 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8140 symbol character follows.
8141
9e381cdd
PE
81422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8143
8144 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8145 This works around a problem with the previous change to Fcopy_file.
8146 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8147 and without this change, GCC might complain about discarding
8148 fchown's return value.
8149
b5641435
JB
81502011-07-16 Juanma Barranquero <lekktu@gmail.com>
8151
8152 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8153
a8031457
PE
81542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8155
8156 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8157
dd889327
LMI
81582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8159
750c33f7
LMI
8160 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8161 it's used from the C level.
8162
dd889327
LMI
8163 * process.c: Use the same condition for POLL_FOR_INPUT in both
8164 keyboard.c and process.c (bug#1858).
8165
87e86684
LM
81662011-07-09 Lawrence Mitchell <wence@gmx.li>
8167
8168 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8169 (Fgnutls_boot): Use it.
8170
64348f40
AS
81712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8172
8173 * doc.c (Fsubstitute_command_keys): Revert last change.
8174
1d698799
LMI
81752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8176
f863868c
LMI
8177 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8178 quotes the next character, and doesn't affect other longer
8179 sequences (bug#8935).
8180
1d698799
LMI
8181 * lread.c (syms_of_lread): Clarify that is isn't only
8182 `eval-buffer' and `eval-defun' that's affected by
8183 `lexical-binding' (bug#8460).
8184
aa4b6df6
EZ
81852011-07-15 Eli Zaretskii <eliz@gnu.org>
8186
8187 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8188 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8189
5d856da6
PE
81902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8191
ad6042bb
PE
8192 Fix minor problems found by static checking.
8193 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8194 (elsz): Now a signed constant, not a size_t var. We prefer signed
8195 types to unsigned, to avoid integer comparison confusion. Without
8196 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8197 "cannot optimize loop, the loop counter may overflow", a symptom
8198 of the confusion.
f00bbb22 8199 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8200 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8201
6468f31c
LMI
82022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8203
49080b10
LMI
8204 * search.c (Fre_search_backward): Mention `case-fold-search' in
8205 all the re_search_* functions (bug#8138).
8206
6468f31c
LMI
8207 * keyboard.c (Fopen_dribble_file): Document when the file is
8208 closed (bug#8056).
8209
c965adc5
EZ
82102011-07-14 Eli Zaretskii <eliz@gnu.org>
8211
df9733bf
EZ
8212 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8213 bidi_cache_idx.
8214
0bb23927
EZ
8215 Support bidi reordering of display and overlay strings.
8216 * xdisp.c (compute_display_string_pos)
8217 (compute_display_string_end): Accept additional argument STRING.
8218 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8219 (reseat_to_string): Initialize bidi_it->string.s and
8220 bidi_it->string.schars.
8221 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8222 NULL (avoids a crash in bidi_paragraph_init).
8223 Initialize itb.string.lstring.
0bb23927
EZ
8224 (init_iterator): Call bidi_init_it only of a valid
8225 buffer position was specified. Initialize paragraph_embedding to
8226 L2R.
8227 (reseat_to_string): Initialize the bidi iterator.
8228 (display_string): If we need to ignore text properties of
8229 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8230 original value of -1 will not work with bidi.)
8231 (compute_display_string_pos): First arg is now struct
8232 `text_pos *'; all callers changed. Support display properties on
8233 Lisp strings.
8234 (compute_display_string_end): Support display properties on Lisp
8235 strings.
8236 (init_iterator, reseat_1, reseat_to_string): Initialize the
8237 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8238 when iterating on a string not from display properties).
640c8776
SM
8239 (compute_display_string_pos, compute_display_string_end):
8240 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8241 arrow keys.
8242 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8243 base_level_stop; instead, set base_level_stop to BEGV.
8244 Fixes crashes in vertical-motion.
0bb23927
EZ
8245 (next_element_from_buffer): Improve commentary for when
8246 the iterator is before prev_stop.
8247 (init_iterator): Initialize bidi_p from the default value of
8248 bidi-display-reordering, not from buffer-local value. Use the
8249 buffer-local value only if initializing for buffer iteration.
8250 (handle_invisible_prop): Support invisible properties on strings
8251 that are being bidi-reordered.
8252 (set_iterator_to_next): Support bidi reordering of C strings and
8253 Lisp strings.
8254 (next_element_from_string): Support bidi reordering of Lisp
8255 strings.
8256 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8257 (display_string): Support display of R2L glyph rows.
8258 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8259 (init_iterator): Don't initialize it->bidi_p for strings
8260 here.
8261 (reseat_to_string): Initialize it->bidi_p for strings here.
8262 (next_element_from_string, next_element_from_c_string)
8263 (next_element_from_buffer): Add xassert's for correspondence
8264 between IT's object being iterated and it->bidi_it.string
8265 structure.
8266 (face_before_or_after_it_pos): Support bidi iteration.
8267 (next_element_from_c_string): Handle the case of the first string
8268 character that is not the first one in the visual order.
8269 (get_visually_first_element): New function, refactored from common
8270 parts of next_element_from_buffer, next_element_from_string, and
8271 next_element_from_c_string.
8272 (tool_bar_lines_needed, redisplay_tool_bar)
8273 (display_menu_bar): Force left-to-right direction. Add a FIXME
8274 comment for making that be controlled by a user option.
8275 (push_it, pop_it): Save and restore the state of the
8276 bidi iterator. Save and restore the bidi_p flag.
8277 (pop_it): Iterate out of display property for string iteration as
8278 well.
8279 (iterate_out_of_display_property): Support iteration over strings.
8280 (handle_single_display_spec): Set up it->bidi_it for iteration
8281 over a display string, and call bidi_init_it.
8282 (handle_single_display_spec, next_overlay_string)
8283 (get_overlay_strings_1, push_display_prop): Set up the bidi
8284 iterator for displaying display or overlay strings.
8285 (forward_to_next_line_start): Don't use the shortcut if
8286 bidi-iterating.
8287 (back_to_previous_visible_line_start): If handle_display_prop
8288 pushed the iterator stack, restore the internal state of the bidi
8289 iterator by calling bidi_pop_it same number of times.
8290 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8291 and we are bidi-iterating, don't decrement the iterator position;
8292 instead, set the first_elt flag in the bidi iterator, to produce
8293 the same effect.
8294 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8295 (push_display_prop): xassert that we are iterating a buffer.
8296 (push_it, pop_it): Save and restore paragraph_embedding member.
8297 (handle_single_display_spec, next_overlay_string)
8298 (get_overlay_strings_1, reseat_1, reseat_to_string)
8299 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8300 correctly. Don't assume unibyte strings are not bidi-reordered.
8301 (compute_display_string_pos)
8302 (compute_display_string_end): Fix handling the case of C string.
8303 (push_it, pop_it): Save and restore from_disp_prop_p.
8304 (handle_single_display_spec, push_display_prop): Set the
8305 from_disp_prop_p flag.
8306 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8307 (pop_it): Call iterate_out_of_display_property only if we are
8308 popping after iteration over a string that came from a display
8309 property. Fix a typo in popping stretch info. Add an assertion
8310 for verifying that the iterator position is in sync with the bidi
8311 iterator.
8312 (handle_single_display_spec, get_overlay_strings_1)
8313 (push_display_prop): Fix initialization of paragraph direction for
8314 string when that of the parent object is not yet determined.
8315 (reseat_1): Call bidi_init_it to resync the bidi
8316 iterator with IT's position. (Bug#7616)
8317 (find_row_edges): If ROW->start.pos gives position
8318 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8319 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8320 Reset the from_disp_prop_p flag.
8321 (SAVE_IT, RESTORE_IT): New macros.
8322 (pos_visible_p, face_before_or_after_it_pos)
8323 (back_to_previous_visible_line_start)
8324 (move_it_in_display_line_to, move_it_in_display_line)
8325 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8326 (try_scrolling, redisplay_window, display_line): Use them when
8327 saving a temporary copy of the iterator and restoring it back.
8328 (back_to_previous_visible_line_start, reseat_1)
8329 (init_iterator): Empty the bidi cache "stack".
8330 (move_it_in_display_line_to): If iterator ended up at
8331 EOL, but we never saw any buffer positions smaller than
8332 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8333 motion in bidi-reordered lines.
8334 (move_it_in_display_line_to): Record prev_method and prev_pos
8335 immediately before the call to set_iterator_to_next. Fixes cursor
8336 motion in bidi-reordered lines with stretch glyphs and strings
8337 displayed in margins. (Bug#8133) (Bug#8867)
8338 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8339 TO_CHARPOS.
640c8776
SM
8340 (pos_visible_p): Support positions in bidi-reordered lines.
8341 Save and restore bidi cache.
0bb23927
EZ
8342
8343 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8344 (bidi_paragraph_info): Delete unused struct.
8345 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8346 (bidi_cache_start): New variable.
8347 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8348 to zero.
8349 (bidi_cache_fetch_state, bidi_cache_search)
8350 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8351 (bidi_cache_find, bidi_peek_at_next_level)
8352 (bidi_level_of_next_char, bidi_find_other_level_edge)
8353 (bidi_move_to_visually_next): Compare cache index with
8354 bidi_cache_start rather than with zero.
8355 (bidi_fetch_char): Accept new argument STRING; all callers
8356 changed. Support iteration over a string. Support strings with
8357 display properties. Support unibyte strings. Fix the type of
8358 `len' according to what STRING_CHAR_AND_LENGTH expects.
8359 (bidi_paragraph_init, bidi_resolve_explicit_1)
8360 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8361 (bidi_level_of_next_char, bidi_move_to_visually_next):
8362 Support iteration over a string.
0bb23927
EZ
8363 (bidi_set_sor_type, bidi_resolve_explicit_1)
8364 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8365 can now be zero (for strings); special values 0 and -1 were
8366 changed to -1 and -2, respectively.
8367 (bidi_char_at_pos): New function.
8368 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8369 Call it instead of FETCH_MULTIBYTE_CHAR.
8370 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8371 initialized to valid values.
8372 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8373 values.
8374 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8375 the test for valid cached positions. Fix the logic for looking up
8376 the sentinel state in the cache. GCPRO the Lisp string we are
8377 iterating.
8378 (bidi_push_it, bidi_pop_it): New functions.
8379 (bidi_initialize): Initialize the bidi cache start stack pointer.
8380 (bidi_cache_ensure_space): New function, refactored from part of
8381 bidi_cache_iterator_state. Don't assume the required size is just
8382 one BIDI_CACHE_CHUNK away.
8383 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8384 (bidi_count_bytes, bidi_char_at_pos): New functions.
8385 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8386 always valid if bidi_cache_idx is valid.
8387 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8388 is valid if it's going to be used.
8389 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8390 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8391 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8392 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8393 (bidi_find_other_level_edge, bidi_cache_start_stack):
8394 All variables related to cache indices are now EMACS_INT.
c965adc5 8395
0bb23927
EZ
8396 * dispextern.h (struct bidi_string_data): New structure.
8397 (struct bidi_it): New member `string'. Make flag members be 1-bit
8398 fields, and put them last in the struct.
640c8776
SM
8399 (compute_display_string_pos, compute_display_string_end):
8400 Update prototypes.
0bb23927
EZ
8401 (bidi_push_it, bidi_pop_it): Add prototypes.
8402 (struct iterator_stack_entry): New members bidi_p,
8403 paragraph_embedding, and from_disp_prop_p.
8404 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8405 (bidi_shelve_cache, bidi_unshelve_cache):
8406 Declare prototypes.
0bb23927
EZ
8407
8408 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8409 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8410 and vector-like objects.
8411
8412 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8413 cache around display iteration.
8414
8415 * window.c (Fwindow_end, window_scroll_pixel_based)
8416 (displayed_window_lines, Frecenter): Save and restore the bidi
8417 cache around display iteration.
8418
3bbd2265
LMI
84192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8420
8421 * editfns.c (Fdelete_region): Clarify the use of the named
8422 parameters (bug#6788).
8423
adc47434
MR
84242011-07-14 Martin Rudalics <rudalics@gmx.at>
8425
8426 * indent.c (Fvertical_motion): Set and restore w->pointm when
8427 saving and restoring the window's buffer (Bug#9006).
8428
837c31f8
LMI
84292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8430
8431 * editfns.c (Fstring_to_char): Clarify just what is returned
8432 (bug#6576). Text by Eli Zaretskii.
8433
ac389d0c
JB
84342011-07-13 Juanma Barranquero <lekktu@gmail.com>
8435
8436 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8437
0be0ce47
EZ
84382011-07-13 Eli Zaretskii <eliz@gnu.org>
8439
8440 * buffer.c (mmap_find): Fix a typo.
8441
cd18e7e3
JB
84422011-07-13 Johan Bockgård <bojohan@gnu.org>
8443
8444 Fix execution of x selection hooks.
8445 * xselect.c (Qx_lost_selection_functions)
8446 (Qx_sent_selection_functions): New vars.
8447 (syms_of_xselect): DEFSYM them.
8448 (x_handle_selection_request): Pass Qx_sent_selection_functions
8449 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8450 (x_handle_selection_clear,x_clear_frame_selections):
8451 Pass Qx_lost_selection_functions rather than
8452 Vx_lost_selection_functions to Frun_hook_with_args.
8453
47ea7f44
PE
84542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8455
ac389d0c 8456 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8457 The old code sometimes used this field without initializing it.
8458
47ea7f44
PE
8459 * alloc.c (gc_sweep): Don't read past end of array.
8460 In theory, the old code could also have corrupted Emacs internals,
8461 though it'd be very unlikely.
8462
bc985c87
AS
84632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8464
8465 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8466 argument. (Bug#4026)
bc985c87 8467
0cf34688
LMI
84682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8469
b3dadd76
LMI
8470 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8471 key" (bug#4257).
8472
0cf34688
LMI
8473 * window.c (Fset_window_start): Doc fix (bug#4199).
8474 (Fset_window_hscroll): Ditto.
8475
270768cd
PE
84762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8477
077e3dda 8478 Fix minor new problems caught by GCC 4.6.1.
270768cd 8479 * term.c (init_tty): Remove unused local.
490011a6 8480 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8481 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8482 not used otherwise.
270768cd 8483
b1f58454
CY
84842011-07-12 Chong Yidong <cyd@stupidchicken.com>
8485
8486 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8487
22b9578d
LMI
84882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8489
6e70ab07
LMI
8490 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8491 are the mini-buffer and the echo area (bug#3320).
8492
22b9578d
LMI
8493 * term.c (init_tty): Remove support for supdup, c10 and perq
8494 terminals, which are no longer supported (bug#1482).
8495
8974cc9f
JB
84962011-07-10 Johan Bockgård <bojohan@gnu.org>
8497
8498 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8499
a560d974
JD
85002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8501
8502 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8503 for non-popups (Bug#3642).
8504
1dae0f0a
AS
85052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8506
268c2c36 8507 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8508 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8509 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8510 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8511 * data.c (fmod): Likewise.
8512 * dispnew.c (swap_glyphs_in_rows): Likewise.
8513 * emacs.c (memory_warning_signal): Likewise.
8514 * floatfns.c (float_error): Likewise.
8515 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8516 (otf_open, font_otf_capability, generate_otf_features)
8517 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8518 Likewise.
8519 * image.c (pbm_read_file): Likewise.
8520 * indent.c (string_display_width): Likewise.
8521 * intervals.c (check_for_interval, search_for_interval)
8522 (inc_interval_count, count_intervals, root_interval)
8523 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8524 * lread.c (defalias): Likewise.
268c2c36 8525 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8526 * regex.c (set_image_of_range_1, set_image_of_range)
8527 (regex_grow_registers): Likewise.
8528 * sysdep.c (strerror): Likewise.
8529 * termcap.c (valid_filename_p, tprint, main): Likewise.
8530 * tparam.c (main): Likewise.
8531 * unexhp9k800.c (run_time_remap, save_data_space)
8532 (update_file_ptrs, read_header, write_header, calculate_checksum)
8533 (copy_file, copy_rest, display_header): Likewise.
8534 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8535 Likewise.
8536 * xdisp.c (check_it): Likewise.
8537 * xfaces.c (register_color, unregister_color, unregister_colors):
8538 Likewise.
8539 * xfns.c (print_fontset_result): Likewise.
8540 * xrdb.c (member, fatal, main): Likewise.
8541
99033785
PE
85422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8543
8544 Fix minor problems found by static checking (Bug#9031).
8545 * chartab.c (char_table_set_range, map_sub_char_table):
8546 Remove unused locals.
8547 (uniprop_table): Now static.
8548 * composite.c (_work_char): Remove unused static var.
8549
9cb2ac56
JB
85502011-07-09 Juanma Barranquero <lekktu@gmail.com>
8551
8552 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8553
f25661f0
JD
85542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8555
8556 * gtkutil.c (qttip_cb): Remove code without function.
8557
8278c4fe
EZ
85582011-07-09 Eli Zaretskii <eliz@gnu.org>
8559
8560 * w32.c (pthread_sigmask): New stub.
8561
1692ae2d 85622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8563
8a6ebd58 8564 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8565 sigprocmask is portable only for single-threaded applications, and
8566 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8567 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8568 (LIBES): Use it.
8569 * callproc.c (Fcall_process):
8570 * process.c (create_process):
8571 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8572 Use pthread_sigmask, not sigprocmask.
123403e4 8573
1b854618
JD
85742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8575
8576 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8577 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8578 wrong (Bug#8591).
8579
3fe4b549
JD
85802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8581
0ce7e563
JD
8582 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8583 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8584 (xg_hide_tooltip): Fix comment.
8585
3fe4b549
JD
8586 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8587 in registerServicesMenuSendTypes.
8588 (validRequestorForSendType): Don't check ns_return_types.
8589
8590 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8591 ns_return_type.
8592
5df75e47
JR
85932011-07-08 Jason Rumney <jasonr@gnu.org>
8594
22610910
JR
8595 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8596 SH_SHOW for hidden windows (Bug#5482).
8597
5df75e47
JR
8598 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8599 frame struct members of non-existent frames (Bug#6284).
8600
699c10bd
JD
86012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8602
4393663b
JD
8603 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8604 variable firstTime not needed on OSX >= 10.6.
8605 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8606 >= 10.5. Use setKnobProportion, setDoubleValue.
8607
8608 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8609 (MAC_OS_X_VERSION_10_5): Define if not defined.
8610 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8611 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8612 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8613
8614 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8615 cString and lossyCString on OSX >= 10.4.
4393663b 8616
58179cce 8617 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8618 sizeToFit on OSX >= 10.2.
8619
8620 * nsimage.m (allocInitFromFile): Don't use deprecated method
8621 bestRepresentationForDevice on OSX >= 10.6.
8622
8623 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8624 to avoid warning.
8625
8626 * emacs.c: Declare unexec_init_emacs_zone.
8627
a63e0781
JD
8628 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8629
699c10bd
JD
8630 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8631
8632 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8633 on svcsMenu (Bug#8842).
8634
8635 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8636 ns_return_types.
8637 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8638
8639 * nsterm.m (QUTF8_STRING): Declare.
8640 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8641 (validRequestorForSendType): Return type is (id).
8642 Change indexOfObjectIdenticalTo to indexOfObject.
8643 Check if we have local selection before returning self (Bug#8842).
8644 (writeSelectionToPasteboard): Put local selection into paste board
8645 if we have a local selection (Bug#8842).
8646 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8647
8648 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8649 (ns_get_local_selection): Declare.
8650
54e10184
LMI
86512011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8652
9888ff71
LMI
8653 * keymap.c (describe_map_tree): Don't insert a double newline at
8654 the end of the buffer (bug#1169) and return whether we inserted
8655 something.
8656
54e10184
LMI
8657 * callint.c (Fcall_interactively): Change "reading args" to
8658 "providing args" to try to clarify what it does (bug#1010).
8659
15fa4783
KH
86602011-07-07 Kenichi Handa <handa@m17n.org>
8661
8662 * composite.c (composition_compute_stop_pos): Ignore a static
8663 composition starting before CHARPOS (Bug#8915).
8664
8665 * xdisp.c (handle_composition_prop): Likewise.
8666
a8815b00
EZ
86672011-07-07 Eli Zaretskii <eliz@gnu.org>
8668
8669 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8670 (Bug#9015)
8671
ef7b981d 86722011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8673
8674 * character.h (unicode_category_t): New enum type.
8675
8676 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8677 (Qchar_code_property_table): New variable.
8678 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8679 (UNIPROP_COMPRESSED_FORM_P): New macros.
8680 (char_table_ascii): Uncompress the compressed values.
8681 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8682 Uncompress the compressed values.
ac389d0c 8683 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8684 (char_table_ref_and_range): Uncompress the compressed values.
8685 (sub_char_table_set): New arg is_uniprop. Callers changed.
8686 Uncompress the compressed values.
8687 (sub_char_table_set_range): Args changed. Callers changed.
8688 (char_table_set_range): Adjuted for the above change.
8689 (map_sub_char_table): Delete args default_val and parent. Add arg
8690 top. Give decoded values to a Lisp function.
640c8776 8691 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8692 values to a Lisp function. Gcpro more variables.
8693 (uniprop_table_uncompress)
8694 (uniprop_decode_value_run_length): New functions.
8695 (uniprop_decoder, uniprop_decoder_count): New variables.
8696 (uniprop_get_decoder, uniprop_encode_value_character)
8697 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8698 New functions.
8699 (uniprop_encoder, uniprop_encoder_count): New variables.
8700 (uniprop_get_encoder, uniprop_table)
8701 (Funicode_property_table_internal, Fget_unicode_property_internal)
8702 (Fput_unicode_property_internal): New functions.
8703 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8704 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8705 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8706 char-code-property-alist.
8707
640c8776 8708 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8709 Vunicode_category_table.
8710
640c8776 8711 * font.c (font_range): Adjust for the change of
c805dec0
KH
8712 Vunicode_category_table.
8713
76b397fb
DN
87142011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8715
8716 * m/iris4d.h: Remove file, move contents ...
8717 * s/irix6-5.h: ... here.
8718
22b4128e
PE
87192011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8720
8721 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8722 * alloc.c (mark_buffer):
8723 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8724 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8725 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8726 This isn't true in general, and it's particularly not true
8727 if Emacs is configured with --with-wide-int.
8728 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8729 New macros, used in the buffer.c change.
8730
869795d6
JD
87312011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8732
8733 * xsettings.c: Use both GConf and GSettings if both are available.
8734 (store_config_changed_event): Add comment.
8735 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8736 (store_tool_bar_style_changed): New functions.
5e617bc2 8737 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8738 (struct xsettings): Move font inside HAVE_XFT.
8739 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8740 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8741 Move inside HAVE_XFT.
640c8776 8742 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8743 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8744 also.
8745 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8746 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8747 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8748 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8749 (parse_settings): Move check for font inside HAVE_XFT.
8750 (read_settings, apply_xft_settings): Add comment.
8751 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8752 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8753 call store_font_name_changed.
8754 (xft_settings_event): Add comment.
8755 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8756 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8757 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8758 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8759 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8760 (xsettings_get_system_font, xsettings_get_system_normal_font):
8761 Add comment.
869795d6 8762
d8ed26bd
PE
87632011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8764
8765 Random fixes. E.g., (random) never returned negative values.
8766 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8767 subseconds part to the entropy, as that's a bit more random.
8768 Prefer signed to unsigned, since the signedness doesn't matter and
8769 in general we prefer signed. When given a limit, use a
8770 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8771 latter isn't right if USE_2_TAGS_FOR_INTS.
8772 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8773 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8774
cabf1cac
SM
87752011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8776
8777 * textprop.c (text_property_stickiness):
8778 Obey Vtext_property_default_nonsticky.
8779 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8780 * w32fns.c (syms_of_w32fns):
8781 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8782
6e9b2be9
PE
87832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8784
8785 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8786 This is more efficient than Ffile_directory_p and avoids a minor race.
8787
90186c68
LMI
87882011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8789
7c301272
LMI
8790 * buffer.c (Foverlay_put): Say what the return value is
8791 (bug#7835).
8792
c4f2d8d4
LMI
8793 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8794 is a directory before asking whether to use the file name
8795 (bug#7564).
ad637907
LMI
8796 (barf_or_query_if_file_exists): Make the "File is a directory"
8797 error be more correct.
c4f2d8d4 8798
90186c68
LMI
8799 * fns.c (Frequire): Remove the mention of the .gz files, since
8800 that's installation-specific, but keep the mention of
8801 `get-load-suffixes'.
8802
da64016e
PE
88032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8804
8805 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8806 Report string overflow if the output is too long.
8807
7d47b580
JB
88082011-07-04 Juanma Barranquero <lekktu@gmail.com>
8809
a555cb87
JB
8810 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8811 (syms_of_gnutls): Remove duplicate DEFSYM for
8812 Qgnutls_bootprop_verify_hostname_error, an error for
8813 Qgnutls_bootprop_verify_error (which is no longer used).
8814
7d47b580
JB
8815 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8816 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8817 Also (re)move comments that are misplaced or no longer relevant.
8818
1e49bfab
LMI
88192011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8820
8821 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8822
1485f4c0
CY
88232011-07-03 Chong Yidong <cyd@stupidchicken.com>
8824
8825 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8826 and background color parameters if they have been changed.
8827
a9ab721e
LMI
88282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8829
8830 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8831
cf7cff57
PE
88322011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8833
2e13213d
PE
8834 * xsettings.c (SYSTEM_FONT): Define only when used.
8835 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8836
cf7cff57
PE
8837 * keymap.c (access_keymap_1): Now static.
8838
7a8e04f7
CY
88392011-07-02 Chong Yidong <cyd@stupidchicken.com>
8840
8841 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8842 leave any prefix arg for the up event (Bug#1586).
8843
61352f62
LMI
88442011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8845
69bb1ef7
LMI
8846 * lread.c (syms_of_lread): Mention single symbols defined by
8847 `defvar' or `defconst' (bug#7154).
8848
61352f62 8849 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8850 (Frequire): Mention get-load-suffixes.
61352f62 8851
28545e04
MR
88522011-07-02 Martin Rudalics <rudalics@gmx.at>
8853
8854 * window.h (window): Remove clone_number slot.
8855 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8856 Remove.
8857 (make_parent_window, make_window, saved_window)
8858 (Fset_window_configuration, save_window_save): Don't deal with
8859 clone numbers.
8860 * buffer.c (Qclone_number): Remove declaration.
8861 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8862
3349e122
SM
88632011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8864
8865 Add multiple inheritance to keymaps.
8866 * keymap.c (Fmake_composed_keymap): New function.
8867 (Fset_keymap_parent): Simplify.
8868 (fix_submap_inheritance): Remove.
8869 (access_keymap_1): New function extracted from access_keymap to handle
8870 embedded parents and handle lists of maps.
8871 (access_keymap): Use it.
8872 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8873 (Fcopy_keymap): Handle embedded parents.
8874 (Fcommand_remapping, define_as_prefix): Simplify.
8875 (Fkey_binding): Simplify.
8876 (syms_of_keymap): Move minibuffer-local-completion-map,
8877 minibuffer-local-filename-completion-map,
8878 minibuffer-local-must-match-map, and
8879 minibuffer-local-filename-must-match-map to Elisp.
8880 (syms_of_keymap): Defsubr make-composed-keymap.
8881 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8882 (parse_menu_item): Trivial simplification.
8883
3279eb87
GM
88842011-07-01 Glenn Morris <rgm@gnu.org>
8885
8886 * Makefile.in (SETTINGS_LIBS): Fix typo.
8887
4550efdf
KI
88882011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8889
8890 * coding.c (Fencode_coding_string): Record the last coding system
8891 used, as the function doc string says (bug#8738).
8892
0949d2b6
JD
88932011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8894
8895 * xsettings.c (store_monospaced_changed): Take new font as arg and
8896 check for change against current_mono_font.
8897 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8898 (emacs_settings_constructor, emacs_settings_get_property)
8899 (emacs_settings_set_property, emacs_settings_class_init)
8900 (emacs_settings_init, gsettings_obj): Remove.
8901 (something_changedCB): New function for HAVE_GSETTINGS.
8902 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8903 with value as argument.
8904 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8905 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8906 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8907 "changed".
8908
8909 * xgselect.c: Add defined (HAVE_GSETTINGS).
8910 (xgselect_initialize): Ditto.
8911
8912 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8913 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8914 xg_select.
8915
bbc6b304
PE
89162011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8917
8918 * eval.c (struct backtrace): Simplify and port the data structure.
8919 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8920 signed bit field, as this assumption is not portable and it makes
8921 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8922 "char debug_on_exit : 1" as this is not portable either; instead,
8923 use the portable "unsigned int debug_on_exit : 1". Remove unused
8924 member evalargs. Remove obsolete comments about cc bombing out.
8925
9851bfc5
JD
89262011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8927
51bb811f 8928 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8929 Let HAVE_GSETTINGS override HAVE_GCONF.
8930 (store_monospaced_changed): New function.
8931 (EMACS_SETTINGS): A new type derived from GObject to handle
8932 GSettings notifications.
8933 (emacs_settings_constructor, emacs_settings_get_property)
8934 (emacs_settings_set_property, emacs_settings_class_init):
8935 New functions.
8936 (gsettings_client, gsettings_obj): New variables.
8937 (GSETTINGS_SCHEMA): New define.
8938 (something_changedCB): Call store_monospaced_changed.
8939 (init_gsettings): New function.
8940 (xsettings_initialize): Call init_gsettings.
8941 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8942 to NULL.
8943
640c8776 8944 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8945 GCONF_CFLAGS/LIBS.
8946
5386012d
MR
89472011-06-29 Martin Rudalics <rudalics@gmx.at>
8948
8949 * window.c (resize_root_window, grow_mini_window)
8950 (shrink_mini_window): Rename Qresize_root_window to
8951 Qwindow_resize_root_window and Qresize_root_window_vertically to
8952 Qwindow_resize_root_window_vertically.
8953
f13e0b08
PE
89542011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8955
8956 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8957
94515237
JB
89582011-06-27 Juanma Barranquero <lekktu@gmail.com>
8959
8960 * makefile.w32-in: Redesign dependencies so they reflect more
8961 clearly which files are directly included by each source file,
8962 and not through other includes.
8963
e43b6e43
MR
89642011-06-27 Martin Rudalics <rudalics@gmx.at>
8965
8966 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8967 (sort_overlays, overlay_strings): When an overlay's clone number
8968 matches the window's clone number process the overlay even if
8969 the overlay's window property doesn't match the current window.
8970
d68443dc
MR
8971 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8972 (Fwindow_hchild): Rename to Fwindow_left_child.
8973 (Fwindow_next): Rename to Fwindow_next_sibling.
8974 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8975 (resize_window_check): Rename to window_resize_check.
8976 (resize_window_apply): Rename to window_resize_apply.
8977 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8978 (Fdelete_other_windows_internal, resize_frame_windows)
8979 (Fsplit_window_internal, Fdelete_window_internal)
8980 (grow_mini_window, shrink_mini_window)
8981 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8982
c7e73be5
JD
89832011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8984
8985 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8986 (emacs_fixed_set_min_size): Remove.
8987 (emacs_fixed_new): Take frame as argument.
8988
8989 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8990 (_EmacsFixedPrivate): Remove minwidth/height.
8991 Add struct frame *f.
8992 (emacs_fixed_init): Initialize priv->f.
8993 (get_parent_class, emacs_fixed_set_min_size): Remove.
8994 (emacs_fixed_new): Set priv->f to argument.
8995 (emacs_fixed_get_preferred_width)
8996 (emacs_fixed_get_preferred_height): Use min_width/height from
8997 frames size_hint to set minimum and natural (Bug#8919).
8998 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8999 and use min_width/height from frames size_hint to set
9000 min_width/height (Bug#8919).
9001
9002 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9003 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9004 Fix indentation.
c7e73be5 9005
cf99dcf8
EZ
90062011-06-26 Eli Zaretskii <eliz@gnu.org>
9007
9008 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9009 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9010 called at ZV.
9011
029529ac
CY
90122011-06-26 Chong Yidong <cyd@stupidchicken.com>
9013
9014 * process.c (wait_reading_process_output): Bypass select if
9015 waiting for a cell while ignoring keyboard input, and input is
9016 pending. Suggested by Jan Djärv (Bug#8869).
9017
7a7ef429
PE
90182011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9019
9020 Use gnulib's dup2 module instead of rolling our own.
9021 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9022
11fdef7d 90232011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9024
9025 * dispnew.c (scrolling_window): Before scrolling, turn off a
9026 mouse-highlight in the window being scrolled.
9027
cd3520a4
JB
90282011-06-24 Juanma Barranquero <lekktu@gmail.com>
9029
9030 Move DEFSYM to lisp.h and use everywhere.
9031
9032 * character.h (DEFSYM): Move declaration...
9033 * lisp.h (DEFSYM): ...here.
9034
9035 * gnutls.c:
9036 * minibuf.c:
9037 * w32menu.c:
9038 * w32proc.c:
9039 * w32select.c: Don't include character.h.
9040
9041 * alloc.c (syms_of_alloc):
9042 * buffer.c (syms_of_buffer):
9043 * bytecode.c (syms_of_bytecode):
9044 * callint.c (syms_of_callint):
9045 * casefiddle.c (syms_of_casefiddle):
9046 * casetab.c (init_casetab_once):
9047 * category.c (init_category_once, syms_of_category):
9048 * ccl.c (syms_of_ccl):
9049 * cmds.c (syms_of_cmds):
9050 * composite.c (syms_of_composite):
9051 * dbusbind.c (syms_of_dbusbind):
9052 * dired.c (syms_of_dired):
9053 * dispnew.c (syms_of_display):
9054 * doc.c (syms_of_doc):
9055 * editfns.c (syms_of_editfns):
9056 * emacs.c (syms_of_emacs):
9057 * eval.c (syms_of_eval):
9058 * fileio.c (syms_of_fileio):
9059 * fns.c (syms_of_fns):
9060 * frame.c (syms_of_frame):
9061 * fringe.c (syms_of_fringe):
9062 * insdel.c (syms_of_insdel):
9063 * keymap.c (syms_of_keymap):
9064 * lread.c (init_obarray, syms_of_lread):
9065 * macros.c (syms_of_macros):
9066 * msdos.c (syms_of_msdos):
9067 * print.c (syms_of_print):
9068 * process.c (syms_of_process):
9069 * search.c (syms_of_search):
9070 * sound.c (syms_of_sound):
9071 * syntax.c (init_syntax_once, syms_of_syntax):
9072 * terminal.c (syms_of_terminal):
9073 * textprop.c (syms_of_textprop):
9074 * undo.c (syms_of_undo):
9075 * w32.c (globals_of_w32):
9076 * window.c (syms_of_window):
9077 * xdisp.c (syms_of_xdisp):
9078 * xfaces.c (syms_of_xfaces):
9079 * xfns.c (syms_of_xfns):
9080 * xmenu.c (syms_of_xmenu):
9081 * xsettings.c (syms_of_xsettings):
9082 * xterm.c (syms_of_xterm): Use DEFSYM.
9083
4228cf16
TZ
90842011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9085
cd3520a4 9086 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9087
7fcccf1e
PE
90882011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9089
7efb4e0e
PE
9090 Integer and buffer overflow fixes (Bug#8873).
9091
ff5844ad
PE
9092 * print.c (printchar, strout): Check for string overflow.
9093 (PRINTPREPARE, printchar, strout):
9094 Don't set size unless allocation succeeds.
9095
90532f02
PE
9096 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9097 for sizes. Check for string overflow more accurately.
9098 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9099
6d84508d
PE
9100 * macros.c: Integer and buffer overflow fixes.
9101 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9102 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9103 Use ptrdiff_t, not int, for sizes.
9104 Don't increment bufsize until after realloc succeeds.
9105 Check for size-calculation overflow.
9106 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9107
437b2cb4
PE
9108 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9109
8b9ac8b4
PE
9110 * lread.c: Integer overflow fixes.
9111 (read_integer): Radix is now EMACS_INT, not int,
9112 to improve quality of diagnostics for out-of-range radices.
9113 Calculate buffer size correctly for out-of-range radices.
9114 (read1): Check for integer overflow in radices, and in
9115 read-circle numbers.
82cb60d3
PE
9116 (read_escape): Avoid int overflow.
9117 (Fload, openp, read_buffer_size, read1)
9118 (substitute_object_recurse, read_vector, read_list, map_obarray):
9119 Use ptrdiff_t, not int, for sizes.
9120 (read1): Use EMACS_INT, not int, for sizes.
20270765 9121 Check for size overflow.
8b9ac8b4 9122
7fcccf1e
PE
9123 * image.c (cache_image): Check for size arithmetic overflow.
9124
bfbbd7e7
PE
9125 * lread.c: Integer overflow issues.
9126 (saved_doc_string_size, saved_doc_string_length)
9127 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9128 Now ptrdiff_t, not int.
9129 (read1): Don't assume doc string length fits in int. Check for
9130 out-of-range doc string lengths.
9131 (read_list): Don't assume file position fits in int.
39019e54 9132 (read_escape): Check for hex character overflow.
bfbbd7e7 9133
4e323265
LL
91342011-06-22 Leo Liu <sdl.web@gmail.com>
9135
9136 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9137 Move to minibuffer.el.
9138
85fece3e
PE
91392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9140
20b84ce9 9141 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9142 The following patches are for when GLYPH_DEBUG && !XASSERT.
9143 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9144 * dispnew.c (flush_stdout):
9145 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9146 Mark as externally visible.
9147 * dispnew.c (check_window_matrix_pointers): Now static.
9148 * dispnew.c (window_to_frame_vpos):
9149 * xfns.c (unwind_create_frame):
9150 * xterm.c (x_check_font): Remove unused local.
9151 * scroll.c (CHECK_BOUNDS):
9152 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9153 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9154 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9155 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9156 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9157 Now static.
9158 (debug_method_add): Use va_list and vsprintf rather than relying
9159 on undefined behavior with wrong number of arguments.
9160 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9161 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9162 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9163 since we're not interested in debugging glyphs with old libraries.
9164 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9165 GCC 4.6.0's static checking.
9166
0766b489
PE
91672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9168
31fd4b32
PE
9169 Integer overflow and signedness fixes (Bug#8873).
9170 A few related buffer overrun fixes, too.
9171
b79e8648
PE
9172 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9173
0766b489
PE
9174 * dispextern.h (struct face.stipple):
9175 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9176 (x_bitmap_mask, x_allocate_bitmap_record)
9177 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9178 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9179 (x_create_bitmap_from_xpm_data):
9180 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9181 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9182 (.bitmaps_last):
9183 * xfaces.c (load_pixmap):
9184 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9185 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9186 (.bitmaps_last, struct x_output.icon_bitmap):
9187 Use ptrdiff_t, not int, for bitmap indexes.
9188 (x_allocate_bitmap_record): Check for size overflow.
9189 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9190
b081724f
PE
9191 Use ptrdiff_t, not int, for overlay counts.
9192 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9193 * editfns.c (overlays_around, get_pos_property):
9194 * textprop.c (get_char_property_and_overlay):
9195 * xdisp.c (next_overlay_change, note_mouse_highlight):
9196 * xfaces.c (face_at_buffer_position):
21514da7
PE
9197 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9198 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9199 (Fnext_overlay_change, Fprevious_overlay_change)
9200 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9201 Use ptrdiff_t, not int, for sizes.
21514da7 9202 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9203
3de73e5e
PE
9204 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9205
2606c57b
PE
9206 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9207 (x_session_initialize): Do not assume string length fits in int.
9208
aaafe47a
PE
9209 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9210 This is unlikely, but can occur if DPI is outlandish.
9211
2674ddc8 9212 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9213 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9214
28154962
PE
9215 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9216 * xrdb.c (magic_file_p, search_magic_path):
9217 Omit last arg SUFFIX; it was always 0. All callers changed.
9218 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9219
7de51af5
PE
9220 * xfont.c (xfont_match): Avoid need for strlen.
9221
25ed6cc3
PE
9222 * xfns.c: Don't assume strlen fits in int.
9223 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9224
4eab31dd
PE
9225 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9226 not unsigned long, as we prefer signed integers. All callers changed.
9227 Detect integer overflow in repeat count.
9228 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9229 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9230
171e2a58
PE
9231 * termcap.c: Don't assume sizes fit in int and never overflow.
9232 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9233 (gobble_line): Check for size-calculation overflow.
9234
ad39faca 9235 * minibuf.c (Fread_buffer):
6e5bb2dc 9236 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9237 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9238 Don't assume string length fits in int.
9239
52c61c22 9240 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9241 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9242
b5b8c9e5
PE
9243 * font.c: Don't assume string length fits in int.
9244 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9245 Use ptrdiff_t, not int.
ccd6111c
PE
9246 (font_intern_prop): Don't assume string length fits in int.
9247 Don't assume integer property fits in fixnum.
9248 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9249
882f0d81 9250 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9251 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9252 Reformulate so as not to need the command string.
9253 Invoke gzip -cd rather than gunzip, as it's more portable.
9254 (lock_info_type, lock_file_1, lock_file):
9255 Don't assume pid_t and time_t fit in unsigned long.
9256 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9257 (current_lock_owner): Prefer signed type for sizes.
9258 Use memcpy, not strncpy, where memcpy is what is really wanted.
9259 Don't assume (via atoi) that time_t and pid_t fit in int.
9260 Check for time_t and/or pid_t out of range, e.g., via a network share.
9261 Don't alloca where an auto var works fine.
9262
93f4cf88
PE
9263 * fileio.c: Fix some integer overflow issues.
9264 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9265 Don't assume string length fits in int.
9266 (directory_file_name): Don't assume string length fits in long.
9267 (make_temp_name): Don't assume pid fits in int, or that its print
9268 length is less than 20.
9269
f3e92b69
PE
9270 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9271
1bfdaf10
PE
9272 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9273
35016e9a
PE
9274 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9275
3d1e65a1
PE
9276 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9277 We prefer signed integers, even for size calculations.
9278
0b963a93
PE
9279 * emacs.c: Don't assume string length fits in 'int'.
9280 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9281 (main): Don't invoke strlen when not needed.
9282
573f4b54
PE
9283 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9284 (XD_DEBUG_MESSAGE): Don't waste a byte.
9285
989f33ba
PE
9286 * callproc.c (getenv_internal_1, getenv_internal)
9287 (Fgetenv_internal):
965d34eb
PE
9288 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9289
e4d29b33
PE
9290 * lread.c (invalid_syntax): Omit length argument.
9291 All uses changed. This doesn't fix a bug, but it simplifies the
9292 code away from its former Hollerith-constant appearance, and it's
9293 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9294 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9295
eb49b136
PE
9296 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9297 This didn't break anything, but it didn't help either.
9298 It's confusing to put a bogus integer in a place where the actual
9299 value does not matter.
9f62aeb1 9300 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9301 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9302
15375a22
PE
9303 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9304 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9305 implementation.
b61cc01c
PE
9306 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9307 We prefer signed types, and the value cannot exceed the EMACS_INT
9308 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9309 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9310 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9311 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9312
53b2623d
PE
9313 * indent.c (sane_tab_width): New function.
9314 (current_column, scan_for_column, Findent_to, position_indentation)
9315 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9316 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9317
51cab52b 9318 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9319
f2ed8a70
PE
9320 * lisp.h (lint_assume): New macro.
9321 * composite.c (composition_gstring_put_cache):
9322 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9323
abe80cc6
PE
9324 * editfns.c, insdel.c:
9325 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9326
b02c740e
PE
9327 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9328
ebc96716
PE
9329 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9330
b4e50fa0 9331 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9332 Use much-faster test for byte-length change.
311d5d7c 9333 Don't assume string byte-length fits in 'int'.
a4cf38e4 9334 Check that character arg fits in 'int'.
85461888 9335 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9336
c0c1ee9f
PE
9337 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9338
a498d7f4
PE
9339 * fns.c (concat): Catch string overflow earlier.
9340 Do not rely on integer wraparound.
9341
51cab52b
PE
9342 * dispextern.h (struct it.overlay_strings_charpos)
9343 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9344 * xdisp.c (forward_to_next_line_start)
9345 (back_to_previous_visible_line_start)
9346 (reseat_at_next_visible_line_start, next_element_from_buffer):
9347 Don't arbitrarily truncate the value of 'selective' to int.
9348
76031fad
PE
9349 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9350
5eb55db9
PE
9351 * composite.c: Don't truncate sizes to 'int'.
9352 (composition_gstring_p, composition_reseat_it)
9353 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9354 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9355 not EMACS_UINT, for indexes.
5eb55db9 9356
0703a717
PE
9357 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9358
d6202519
PE
9359 * buffer.c: Include <verify.h>.
9360 (struct sortvec.priority, struct sortstr.priority):
8961a454 9361 Now EMACS_INT, not int.
c20998a7 9362 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9363 (struct sortstr.size, record_overlay_string)
9364 (struct sortstrlist.size, struct sortlist.used):
9365 Don't truncate size to int.
9366 (record_overlay_string): Check for size-calculation overflow.
d6202519 9367 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9368
d5a19415
JM
93692011-06-22 Jim Meyering <meyering@redhat.com>
9370
029529ac 9371 Don't leak an XBM-image-sized buffer
d5a19415
JM
9372 * image.c (xbm_load): Free the image buffer after using it.
9373
a9041e6c
PE
93742011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9375
9376 Port to Sun C.
9377 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9378 that Sun C diagnosed.
9379 * fns.c (secure_hash): Fix pointer signedness issue.
9380 * intervals.c (static_offset_intervals): New function.
9381 (offset_intervals): Use it.
9382
7f3f739f
LL
93832011-06-21 Leo Liu <sdl.web@gmail.com>
9384
9385 * deps.mk (fns.o):
9386 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9387 sha512.h.
9388
9389 * fns.c (secure_hash): Rename from crypto_hash_function and change
9390 the first arg to accept symbols.
5b66d427 9391 (Fsecure_hash): New primitive.
7f3f739f
LL
9392 (syms_of_fns): New symbols.
9393
76147d94
DD
93942011-06-20 Deniz Dogan <deniz@dogan.se>
9395
9396 * process.c (Fset_process_buffer): Clarify return value in
9397 docstring.
9398
7d7d0045
CY
93992011-06-18 Chong Yidong <cyd@stupidchicken.com>
9400
9401 * dispnew.c (add_window_display_history): Use BVAR.
9402
9403 * xdisp.c (debug_method_add): Use BVAR.
9404 (check_window_end, dump_glyph_matrix, dump_glyph)
9405 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9406
9407 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9408 Likewise.
9409
9410 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9411 check till after the cache is created in init_frame_faces.
9412
ff2bc410
SM
94132011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9414
9415 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9416
28177add
PE
94172011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9418
dd3482fe
PE
9419 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9420 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9421 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9422
393d71f3 9423 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9424 * fileio.c (Finsert_file_contents):
9425 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9426 Remove the old (too-loose) buffer overflow checks.
9427 They weren't needed, since make_gap checks for buffer overflow.
9428 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9429 The old code merely checked for Emacs fixnum overflow, and relied
9430 on undefined (wraparound) behavior. The new code avoids undefined
9431 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9432
2e6813b0 9433 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9434 Tune. Don't use wider integers than needed. Don't use alloca.
9435 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9436
599a9e4f
PE
9437 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9438
99561444
PE
9439 * insdel.c, lisp.h (buffer_overflow): New function.
9440 (insert_from_buffer_1, replace_range, replace_range_2):
9441 * insdel.c (make_gap_larger):
9442 * editfns.c (Finsert_char):
9443 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9444
28177add
PE
9445 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9446
e69dafad
PE
94472011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9448
4baa020d 9449 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9450
b1c46f02
PE
9451 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9452 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9453
e69dafad
PE
9454 * fileio.c: Don't assume EMACS_INT fits in off_t.
9455 (emacs_lseek): New static function.
9456 (Finsert_file_contents, Fwrite_region): Use it.
9457 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9458
566684ea
PE
9459 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9460
e6966cd6
PE
9461 * fns.c: Don't overflow int when computing a list length.
9462 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9463 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9464 truncation on 64-bit hosts. Check for QUIT every
9465 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9466 faster and is responsive enough.
9467 (Flength): Report an error instead of overflowing an integer.
9468 (Fsafe_length): Return a float if the value is not representable
9469 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9470 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9471 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9472
dd0b0efb
PE
9473 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9474 (header_size, word_size): New constants.
9475 (allocate_vectorlike): Don't check size overflow here.
9476 (allocate_vector): Check it here instead, since this is the only
9477 caller of allocate_vectorlike that could cause overflow.
9478 Check that the new vector's length is representable as a fixnum.
9479
86fe5cfe
PE
9480 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9481 The previous code was bogus. For example, next_almost_prime (32)
9482 returned 39, which is undesirable as it is a multiple of 3; and
9483 next_almost_prime (24) returned 25, which is a multiple of 5 so
9484 why was the code bothering to check for multiples of 7?
9485
80e88859
PE
9486 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9487
4a2f0ad6
PE
9488 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9489
f66c7cf8
PE
9490 Variadic C functions now count arguments with ptrdiff_t.
9491 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9492 Back then I didn't know that the Emacs coding style prefers signed int.
9493 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9494 were being counted with int, which may truncate counts on 64-bit
9495 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9496 * lisp.h (struct Lisp_Subr.function.aMANY)
9497 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9498 Arg counts are now ptrdiff_t, not size_t.
9499 All variadic functions and their callers changed accordingly.
9500 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9501 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9502 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9503 * callint.c (Fcall_interactively): Check arg count for overflow,
9504 to avoid potential buffer overrun. Use signed char, not 'int',
9505 for 'varies' array, so that we needn't bother to check its size
9506 calculation for overflow.
9507 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9508 * eval.c (apply_lambda):
9509 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9510 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9511 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9512
a1759b76
PE
9513 * callint.c (Fcall_interactively): Don't use index var as event count.
9514
d96be9fc
PE
9515 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9516 * mem-limits.h (SIZE): Remove; no longer used.
9517
a690a978 9518 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9519
578c21e6
PE
9520 Remove unnecessary casts.
9521 * xterm.c (x_term_init):
9522 * xfns.c (x_set_border_pixel):
9523 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9524 These aren't needed now that we assume ANSI C.
9525
96f53c6c
PE
9526 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9527 It's more likely to cause problems (due to unsigned overflow)
9528 than to cure them.
9529
83c77d31
PE
9530 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9531
ee2079f1
PE
9532 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9533
6da65536
PE
9534 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9535
7147c4a4
PE
9536 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9537
193e32d9
PE
9538 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9539
e5533da6
PE
9540 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9541
9910e595
PE
9542 GLYPH_CODE_FACE returns EMACS_INT, not int.
9543 * dispextern.h (merge_faces):
9544 * xfaces.c (merge_faces):
01103c44
PE
9545 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9546 Don't assume EMACS_INT fits in int.
9910e595 9547
2638320e
PE
9548 * character.h (CHAR_VALID_P): Remove unused parameter.
9549 * fontset.c, lisp.h, xdisp.c: All uses changed.
9550
045eb8d9
PE
9551 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9552
c1f134b5
PE
9553 * fns.c (concat): Minor tuning based on overflow analysis.
9554 This doesn't fix any bugs. Use int to hold character, instead
9555 of constantly refetching from Emacs object. Use XFASTINT, not
9556 XINT, for value known to be a character. Don't bother comparing
9557 a single byte to 0400, as it's always less.
9558
395fcb93 9559 * floatfns.c (Fexpt):
327eeec8
PE
9560 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9561
abbd3d23
PE
9562 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9563 for characters.
9564
684a03ef
PE
9565 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9566
0fed43f3
PE
9567 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9568 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9569 incorrectly succeed when S was a string, because 4294967386 was
9570 truncated before it was used.
9571
8fd02eb7
PE
9572 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9573 Otherwise, an out-of-range integer could cause undefined behavior
9574 on a 64-bit host.
9575
f8c86b69
PE
9576 * composite.c: Use int, not EMACS_INT, for characters.
9577 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9578 EMACS_INT, for values that are known to be in character range.
9579 This doesn't fix any bugs but is the usual style inside Emacs and
9580 may generate better code on 32-bit machines.
9581
34206dd2
PE
9582 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9583 This is for reasons similar to the recent CHAR_STRING fix.
9584 * charset.c (Fencode_char): Check that character arg is actually
9585 a character. Pass an int to ENCODE_CHAR.
9586 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9587 wider than 'int', as a compile-time check to prevent future regressions
9588 in this area.
9589
c5958d4c 9590 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9591
9592 Make sure a 64-bit char is never passed to CHAR_STRING.
9593 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9594 by silently ignoring the top 32 bits, allowing some values
9595 that were far too large to be valid characters.
9596 * character.h: Include <verify.h>.
9597 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9598 arguments are no wider than unsigned, as a compile-time check
9599 to prevent future regressions in this area.
9600 * data.c (Faset):
01103c44 9601 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9602 (Fsubst_char_in_region):
9603 * fns.c (concat):
9604 * xdisp.c (decode_mode_spec_coding):
9605 Adjust to CHAR_STRING's new requirement.
9606 * editfns.c (Finsert_char, Fsubst_char_in_region):
9607 * fns.c (concat): Check that character args are actually
9608 characters. Without this test, these functions did the wrong
9609 thing with wildly out-of-range values on 64-bit hosts.
9610
d37ca623
PE
9611 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9612 These casts should not be needed on 32-bit hosts, either.
9613 * keyboard.c (read_char):
9614 * lread.c (Fload): Remove casts to unsigned.
9615
ea204efb
PE
9616 * lisp.h (UNSIGNED_CMP): New macro.
9617 This fixes comparison bugs on 64-bit hosts.
9618 (ASCII_CHAR_P): Use it.
9619 * casefiddle.c (casify_object):
01103c44 9620 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9621 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9622 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9623 * dispextern.h (FACE_FROM_ID):
9624 * keyboard.c (read_char): Use UNSIGNED_CMP.
9625
41cb286c
PE
9626 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9627 not to EMACS_INT, to avoid GCC warning.
9628
4a1b9832
PE
9629 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9630
55daad71
PE
9631 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9632 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9633 isn't needed on 32-bit machines.
8f95c75c 9634
01103c44
PE
9635 * buffer.c (Fgenerate_new_buffer_name):
9636 Use EMACS_INT for count, not int.
0ceccced 9637 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9638
9639 * data.c (Qcompiled_function): Now static.
9640
c6f072e7
PE
9641 * window.c (window_body_lines): Now static.
9642
20ce5912
PE
9643 * image.c (gif_load): Rename local to avoid shadowing.
9644
9c4c5f81
PE
9645 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9646 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9647 * alloc.c (make_save_value): Integer argument is now of type
9648 ptrdiff_t, not int.
9649 (mark_object): Use ptrdiff_t, not int.
9650 * lisp.h (pD): New macro.
9651 * print.c (print_object): Use it.
9652
c0c5c8ae
PE
9653 * alloc.c: Use EMACS_INT, not int, to count objects.
9654 (total_conses, total_markers, total_symbols, total_vector_size)
9655 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9656 (total_free_floats, total_floats, total_free_intervals)
9657 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9658 Now EMACS_INT, not int. All uses changed.
9659 (Fgarbage_collect): Compute overall total using a double, so that
9660 integer overflow is less likely to be a problem. Check for overflow
9661 when converting back to an integer.
5a25e253
PE
9662 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9663 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9664 These were 'int' variables that could overflow on 64-bit hosts;
9665 they were never used, so remove them instead of repairing them.
211a0b2a 9666 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9667 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9668 Previously, this ceilinged at INT_MAX, but that doesn't work on
9669 64-bit machines.
e46bb31a 9670 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9671
c78baabf 9672 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9673 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9674 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9675 when a (possibly-narrower) signed value would do just as well.
9676 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9677
c9d624c6
PE
9678 * alloc.c: Catch some string size overflows that we were missing.
9679 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9680 for convenience in STRING_BYTES_MAX.
9681 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9682 The definition here is exact; the one in lisp.h was approximate.
9683 (allocate_string_data): Check for string overflow. This catches
9684 some instances we weren't catching before. Also, it catches
9685 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9686 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9687 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9688
c9d624c6
PE
9689 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9690 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9691 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9692
353032ce
PE
9693 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9694
2bccce07
PE
9695 * alloc.c (Fmake_string): Check for out-of-range init.
9696
0ac30604
SM
96972011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9698
9699 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9700
c195f2de
JD
97012011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9702
9703 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9704 xg_get_default_scrollbar_width.
9705
9706 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9707 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9708 (style_changed_cb): Call update_theme_scrollbar_width and call
9709 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9710 all frames (Bug#8505).
9711 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9712 Call gtk_window_set_resizable if HAVE_GTK3.
9713 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9714 and height if HAVE_GTK3 (Bug#8505).
9715 (scroll_bar_width_for_theme): New variable.
9716 (update_theme_scrollbar_width): New function.
9717 (xg_get_default_scrollbar_width): Move code to
9718 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9719 (xg_initialize): Call update_theme_scrollbar_width.
9720
9721 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9722
9723 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9724
e10ac9f1
MR
97252011-06-12 Martin Rudalics <rudalics@gmx.at>
9726
9727 * frame.c (make_frame): Call other_buffer_safely instead of
9728 other_buffer.
9729
9730 * window.c (temp_output_buffer_show): Call display_buffer with
9731 second argument Vtemp_buffer_show_specifiers and reset latter
9732 immediately after the call.
9733 (Vtemp_buffer_show_specifiers): New variable.
9734 (auto_window_vscroll_p, next_screen_context_lines)
9735 (Vscroll_preserve_screen_position): Remove leading asterisks from
9736 doc-strings.
9737
2d3c217e 97382011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9739
7b7f97e8 9740 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9741 * buffer.c (Qclone_number): Remove for now, as it's unused.
9742 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9743 (record_buffer): Remove unused local.
9744 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9745 (set_frame_buffer_list): Remove; unused.
9746 * frame.h (other_visible_frames): Remove decl.
9747 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9748 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9749 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9750 if HAVE_GPM.
9751 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9752 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9753 Define only if HAVE_GPM.
9754 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9755 (update_hints_inhibit): Remove; never set. All uses removed.
9756 * widgetprv.h (emacsFrameClassRec): Remove decl.
9757 * window.c (delete_deletable_window): Now returns void, since it
9758 wasn't returning anything.
9759 (compare_window_configurations): Remove unused locals.
9760 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9761 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9762 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9763 the same widths as pointers. This follows up on the 2011-05-06 patch.
9764 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9765 * xterm.h: Likewise.
9766 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9767
1384b89e
JB
97682011-06-12 Juanma Barranquero <lekktu@gmail.com>
9769
9770 * makefile.w32-in: Update dependencies.
9771 (LISP_H): Add lib/intprops.h.
9772
1100a63c
CY
97732011-06-11 Chong Yidong <cyd@stupidchicken.com>
9774
9775 * image.c (gif_load): Add animation frame delay to the metadata.
9776 (syms_of_image): Use DEFSYM. New symbol `delay'.
9777
6198ccd0
MR
97782011-06-11 Martin Rudalics <rudalics@gmx.at>
9779
9780 * window.c (delete_deletable_window): Re-add.
9781 (Fset_window_configuration): Rewrite to handle dead buffers and
9782 consequently deletable windows.
9783 (window_tree, Fwindow_tree): Remove. Supply functionality in
9784 window.el.
9785 (compare_window_configurations): Simplify code.
9786
b6e3633c
AS
97872011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9788
1ab0dee5
AS
9789 * image.c (imagemagick_load_image): Fix type mismatch.
9790 (Fimagemagick_types): Likewise.
9791
b6e3633c
AS
9792 * window.h (replace_buffer_in_windows): Declare.
9793
9397e56f
MR
97942011-06-11 Martin Rudalics <rudalics@gmx.at>
9795
9796 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9797 Qclone_number. Remove external declaration of Qdelete_window.
9798 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9799 code.
640c8776
SM
9800 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9801 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9802 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9803 buffer list implementation.
9804 (other_buffer_safely): New function.
9805 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9806 calls to replace_buffer_in_windows and
9807 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9808 if allowed.
9809 (record_buffer): Inhibit quitting and rewrite using quittable
9810 functions. Run Qbuffer_list_update_hook if allowed.
9811 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9812 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9813 Move switch-to-buffer to window.el.
9397e56f
MR
9814 (bury-buffer): Move to window.el.
9815 (Vbuffer_list_update_hook): New variable.
9816
9817 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9818 section.
9819
9820 * window.h (resize_frame_windows): Move up in code.
9821 (Fwindow_frame): Remove EXFUN.
9822 (replace_buffer_in_all_windows): Remove prototype.
9823 (replace_buffer_in_windows_safely): Add prototype.
9824
9825 * window.c: Declare Qdelete_window static again. Move down
9826 declaration of select_count.
9827 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9828 (Fother_window): Move to window.el.
9829 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9830 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9831 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9832 window.el.
9833 (replace_buffer_in_windows): Implement by calling
9834 Qreplace_buffer_in_windows.
9835 (replace_buffer_in_all_windows): Remove with some functionality
9836 moved into replace_buffer_in_windows_safely.
9837 (replace_buffer_in_windows_safely): New function.
9838 (select_window_norecord, select_frame_norecord): Move in front
9839 of run_window_configuration_change_hook. Remove now obsolete
9840 declarations.
640c8776
SM
9841 (Fset_window_buffer): Rewrite doc-string.
9842 Call Qrecord_window_buffer.
9397e56f
MR
9843 (keys_of_window): Move binding for other-window to window.el.
9844
b50691aa
CY
98452011-06-11 Chong Yidong <cyd@stupidchicken.com>
9846
9847 * dispextern.h (struct image): Replace data member, whose int_val
9848 and ptr_val fields were not used by anything, with a single
9849 lisp_val object.
9850
9851 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9852 (gif_clear_image, gif_load, imagemagick_load_image)
9853 (gs_clear_image, gs_load): Callers changed.
9854
3f754b86
PE
98552011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9856
cca69397
PE
9857 * buffer.h: Include <time.h>, for time_t.
9858 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9859
109e28d0
PE
9860 Fix minor problems found by static checking.
9861
60737f02
PE
9862 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9863
4b66faf3
PE
9864 Make identifiers static if they are not used in other modules.
9865 * data.c (Qcompiled_function, Qframe, Qvector):
9866 * image.c (QimageMagick, Qsvg):
9867 * minibuf.c (Qmetadata):
9868 * window.c (resize_window_check, resize_root_window): Now static.
9869 * window.h (resize_window_check, resize_root_window): Remove decls.
9870
109e28d0
PE
9871 * window.c (window_deletion_count, delete_deletable_window):
9872 Remove; unused.
46a4ce9e
PE
9873 (window_body_lines): Now static.
9874 (Fdelete_other_windows_internal): Mark vars as initialized.
9875 Make sure 'resize_failed' is initialized.
9876 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9877 (resize_window_apply): Remove unused local.
9878 * window.h (delete_deletable_window): Remove decl.
9879
109e28d0 9880 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9881 (imagemagick_load_image): Fix pointer signedness problem by changing
9882 last arg from unsigned char * to char *. All uses changed.
9883 Also, fix a local for similar reasons.
9884 Remove unused locals. Remove locals to avoid shadowing.
9885 (fn_rsvg_handle_free): Remove; unused.
9886 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9887 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9888
3f754b86
PE
9889 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9890
2547adb1
CY
98912011-06-10 Chong Yidong <cyd@stupidchicken.com>
9892
9893 * image.c (gif_load): Fix omitted cast error introduced by
9894 2011-06-06 change.
9895
2c8e37d4
MR
98962011-06-10 Martin Rudalics <rudalics@gmx.at>
9897
9898 * window.h (resize_proportionally, orig_total_lines)
9899 (orig_top_line): Remove from window structure.
9900 (set_window_height, set_window_width, change_window_heights)
9901 (Fdelete_window): Remove prototypes.
9902 (resize_frame_windows): Remove duplicate declaration.
9903
440a42e3
EZ
99042011-06-10 Eli Zaretskii <eliz@gnu.org>
9905
9906 * window.h (resize_frame_windows, resize_window_check)
9907 (delete_deletable_window, resize_root_window)
9908 (resize_frame_windows): Declare prototypes.
9909
9910 * window.c (resize_window_apply): Make definition be "static" to
9911 match the prototype.
9912
562dd5e9
MR
99132011-06-10 Martin Rudalics <rudalics@gmx.at>
9914
9915 * window.c: Remove declarations of Qwindow_size_fixed,
9916 window_min_size_1, window_min_size_2, window_min_size,
9917 size_window, window_fixed_size_p, enlarge_window, delete_window.
9918 Remove static from declaration of Qdelete_window, it's
9919 temporarily needed by Fbury_buffer.
9920 (replace_window): Don't assign orig_top_line and
9921 orig_total_lines.
9922 (Fdelete_window, delete_window): Remove. Window deletion is
9923 handled by window.el.
640c8776
SM
9924 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9925 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9926 (Fdelete_other_windows): Remove. Deleting other windows is
9927 handled by window.el.
9928 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9929 handled in window.el.
9930 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9931 Window minimum sizes are handled in window.el.
9932 (shrink_windows, size_window, set_window_height)
9933 (set_window_width, change_window_heights, window_height)
9934 (window_width, CURBEG, CURSIZE, enlarge_window)
9935 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9936 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9937 handled in window.el.
9938 (make_dummy_parent): Rename to make_parent_window and give it a
9939 second argument horflag.
9940 (make_window): Don't set resize_proportionally any more.
9941 (Fsplit_window): Remove. Windows are split in window.el.
9942 (save_restore_action, save_restore_orig_size)
9943 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9944 Resize mini windows in window.el.
9945 (grow_mini_window, shrink_mini_window): Implement by calling
9946 Qresize_root_window_vertically, resize_window_check and
9947 resize_window_apply.
640c8776
SM
9948 (saved_window, Fset_window_configuration, save_window_save):
9949 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9950 resize_proportionally.
9951 (window_min_height, window_min_width): Move to window.el.
9952 (keys_of_window): Move bindings for delete-other-windows,
9953 split-window, delete-window and enlarge-window to window.el.
9954
9955 * buffer.c: Temporarily extern Qdelete_window.
9956 (Fbury_buffer): Temporarily call Qdelete_window instead of
9957 Fdelete_window (Fbury_buffer will move to window.el soon).
9958
9959 * frame.c (set_menu_bar_lines_1): Remove code handling
9960 orig_top_line and orig_total_lines.
9961
9962 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9963 set_window_height but set heights directly.
9964 (change_frame_size_1): Use resize_frame_windows.
9965
9966 * xdisp.c (init_xdisp): Don't use set_window_height but set
9967 heights directly.
9968
640c8776
SM
9969 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9970 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9971 run_window_configuration_change_hook.
9972
9973 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9974 instead of change_window_heights and run
9975 run_window_configuration_change_hook.
9976
1a13852e
MR
99772011-06-09 Martin Rudalics <rudalics@gmx.at>
9978
9979 * window.c (replace_window): Rename second argument REPLACEMENT to
9980 NEW. New third argument SETFLAG. Rewrite.
9981 (delete_window, make_dummy_parent): Call replace_window with
9982 third argument 1.
9983 (window_list_1): Move down in code.
9984 (run_window_configuration_change_hook): Move set_buffer part
9985 before select_frame_norecord part in order to unwind correctly.
9986 Rename count1 to count.
9987 (recombine_windows, delete_deletable_window, resize_root_window)
9988 (Fdelete_other_windows_internal)
9989 (Frun_window_configuration_change_hook, make_parent_window)
9990 (resize_window_check, resize_window_apply, Fresize_window_apply)
9991 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9992 (Fdelete_window_internal, Fresize_mini_window_internal):
9993 New functions.
1a13852e
MR
9994 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9995
f3d1777e
MR
99962011-06-08 Martin Rudalics <rudalics@gmx.at>
9997
496e208e
MR
9998 * window.h (window): Add some new members to window structure -
9999 normal_lines, normal_cols, new_total, new_normal, clone_number,
10000 splits, nest, prev_buffers, next_buffers.
10001 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10002 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10003
f3d1777e
MR
10004 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10005 Remove.
496e208e
MR
10006 (make_dummy_parent): Set new members of windows structure.
10007 (make_window): Move down in code. Handle new members of window
10008 structure.
10009 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10010 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10011 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10012 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10013 (Fset_window_next_buffers, Fset_window_clone_number):
10014 New functions.
496e208e
MR
10015 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10016 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10017 Doc-string fixes.
10018 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10019 Argument WINDOW can be now internal window too.
10020 (Fwindow_use_time): Move up in code.
10021 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10022 Rewrite doc-string.
10023 (Fset_window_configuration, saved_window)
10024 (Fcurrent_window_configuration, save_window_save): Handle new
10025 members of window structure.
b9e809c2
MR
10026 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10027 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10028 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10029 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10030 Qget_mru_window, Qresize_root_window,
10031 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10032 Qauto_buffer_name; staticpro them.
f3d1777e 10033
abde8f8c
MR
100342011-06-07 Martin Rudalics <rudalics@gmx.at>
10035
10036 * window.c (Fwindow_total_size, Fwindow_left_column)
10037 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10038 (Fwindow_list_1): New functions.
10039 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10040 (Fwindow_width, Fscroll_left, Fscroll_right):
10041 Use window_body_cols instead of window_box_text_cols.
10042 (delete_window, Fset_window_configuration):
10043 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10044 (delete_all_subwindows): Take a window as argument and not a
10045 structure. Rewrite.
190b47e6
MR
10046 (window_loop): Remove handling of GET_LRU_WINDOW and
10047 GET_LARGEST_WINDOW.
10048 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10049
10050 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10051 window_box_text_cols. delete_all_subwindows now takes a
10052 Lisp_Object as argument.
abde8f8c 10053
640c8776
SM
10054 * indent.c (compute_motion, Fcompute_motion):
10055 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10056
fa8a67e6
MR
10057 * frame.c (delete_frame): Call delete_all_subwindows with root
10058 window as argument.
10059
a54e3482
DC
100602011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10061
10062 * fns.c (Fputhash): Document return value.
10063
60002bf5
CY
100642011-06-06 Chong Yidong <cyd@stupidchicken.com>
10065
10066 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10067
0c671da6 100682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10069
b862a52a 10070 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10071
be44ca6c
PE
10072 Check for overflow when converting integer to cons and back.
10073 * charset.c (Fdefine_charset_internal, Fdecode_char):
10074 Use cons_to_unsigned to catch overflow.
10075 (Fencode_char): Use INTEGER_TO_CONS.
10076 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10077 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10078 * data.c (long_to_cons, cons_to_long): Remove.
10079 (cons_to_unsigned, cons_to_signed): New functions.
10080 These signal an error for invalid or out-of-range values.
10081 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10082 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10083 * font.c (Ffont_variation_glyphs):
10084 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10085 * lisp.h: Include <intprops.h>.
10086 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10087 (cons_to_signed, cons_to_unsigned): New decls.
10088 (long_to_cons, cons_to_long): Remove decls.
10089 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10090 (Fprimitive_undo): Use CONS_TO_INTEGER.
10091 * xfns.c (Fx_window_property): Likewise.
10092 * xselect.c: Include <limits.h>.
10093 (x_own_selection, selection_data_to_lisp_data):
10094 Use INTEGER_TO_CONS.
10095 (x_handle_selection_request, x_handle_selection_clear)
10096 (x_get_foreign_selection, Fx_disown_selection_internal)
10097 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10098 (lisp_data_to_selection_data): Use cons_to_unsigned.
10099 (x_fill_property_data): Use cons_to_signed.
10100 Report values out of range.
10101
d1f3d2af
PE
10102 Check for buffer and string overflow more precisely.
10103 * buffer.h (BUF_BYTES_MAX): New macro.
10104 * lisp.h (STRING_BYTES_MAX): New macro.
10105 * alloc.c (Fmake_string):
10106 * character.c (string_escape_byte8):
10107 * coding.c (coding_alloc_by_realloc):
10108 * doprnt.c (doprnt):
10109 * editfns.c (Fformat):
10110 * eval.c (verror):
10111 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10112 since they may not be the same number.
10113 * editfns.c (Finsert_char):
10114 * fileio.c (Finsert_file_contents):
10115 Likewise for BUF_BYTES_MAX.
10116
dd52fcea
PE
10117 * image.c: Use ptrdiff_t, not int, for sizes.
10118 (slurp_file): Switch from int to ptrdiff_t.
10119 All uses changed.
10120 (slurp_file): Check that file size fits in both size_t (for
10121 malloc) and ptrdiff_t (for sanity and safety).
10122
7f9bbdbb
PE
10123 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10124 if b->modtime has its maximal value.
10125
dfe18f82
PE
10126 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10127
84acfcf0
PE
10128 Don't assume time_t can fit into int.
10129 * buffer.h (struct buffer.modtime): Now time_t, not int.
10130 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10131 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10132
ccd9a01a
PE
10133 Minor fixes for signed vs unsigned integers.
10134 * character.h (MAYBE_UNIFY_CHAR):
10135 * charset.c (maybe_unify_char):
10136 * keyboard.c (read_char, reorder_modifiers):
10137 XINT -> XFASTINT, since the integer must be nonnegative.
10138 * ftfont.c (ftfont_spec_pattern):
10139 * keymap.c (access_keymap, silly_event_symbol_error):
10140 XUINT -> XFASTINT, since the integer must be nonnegative.
10141 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10142 since it makes no difference and we prefer signed.
10143 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10144 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10145 nonnegative.
10146
d6d100dd
SM
101472011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10148
10149 * window.h (Fwindow_frame): Declare.
10150
2b6148e4
PE
101512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10152
10153 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10154 (SPARE_MEMORY): Always define.
10155 (LARGE_REQUEST): Remove.
10156 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10157
f230ecc9
MR
101582011-06-06 Martin Rudalics <rudalics@gmx.at>
10159
727e958e
MR
10160 * lisp.h: Move EXFUNS for Fframe_root_window,
10161 Fframe_first_window and Fset_frame_selected_window to window.h.
10162
10163 * window.h: Move EXFUNS for Fframe_root_window,
10164 Fframe_first_window and Fset_frame_selected_window here from
10165 lisp.h.
10166
10167 * frame.c (Fwindow_frame, Fframe_first_window)
10168 (Fframe_root_window, Fframe_selected_window)
10169 (Fset_frame_selected_window): Move to window.c.
10170 (Factive_minibuffer_window): Move to minibuf.c.
10171 (Fother_visible_frames_p): New function.
10172
10173 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10174
f230ecc9
MR
10175 * window.c (decode_window, decode_any_window): Move up in code.
10176 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10177 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10178 (Fwindow_buffer): Move up and rewrite doc-string.
10179 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10180 (Fwindow_prev): New functions.
727e958e
MR
10181 (Fwindow_frame): Move here from frame.c. Accept any window as
10182 argument.
10183 (Fframe_root_window, Fframe_first_window)
10184 (Fframe_selected_window): Move here from frame.c. Accept frame
10185 or arbitrary window as argument. Update doc-strings.
10186 (Fminibuffer_window): Move up in code.
10187 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10188 (Fset_frame_selected_window): Move here from frame.c.
10189 Marginal rewrite.
727e958e
MR
10190 (Fselected_window, select_window, Fselect_window): Move up in
10191 code. Minor doc-string fixes.
f230ecc9 10192
4d09bcf6
PE
101932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10194
10195 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10196 Do not assume that spare memory exists; that assumption is valid
10197 only if SYSTEM_MALLOC.
10198 (LARGE_REQUEST): New macro, so that the issue of large requests
10199 is separated from the issue of spare memory.
10200
810928a2
AS
102012011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10202
172418ad
AS
10203 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10204 format. (Bug#8806)
10205
43f862f7
AS
10206 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10207
810928a2
AS
10208 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10209 before statements.
10210
a059fe24
JD
102112011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10212
10213 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10214
10215 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10216
10217 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10218 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10219
989bf368
JB
102202011-06-05 Juanma Barranquero <lekktu@gmail.com>
10221
10222 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10223
4b80f674
CY
102242011-06-04 Chong Yidong <cyd@stupidchicken.com>
10225
10226 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10227 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10228 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10229 New error handlers.
4b80f674
CY
10230 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10231 Obey Vx_select_enable_clipboard_manager. Catch errors in
10232 x_clipboard_manager_save (Bug#8779).
10233 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10234 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10235
99a33b77 102362011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10237
10238 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10239
99a33b77 102402011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10241
10242 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10243 in the current matrix if keep_current_p is non-zero.
10244
8264569d
EZ
102452011-06-04 Eli Zaretskii <eliz@gnu.org>
10246
10247 * bidi.c (bidi_level_of_next_char): Fix last change.
10248
57f97249
EZ
102492011-06-03 Eli Zaretskii <eliz@gnu.org>
10250
fec2107c 10251 Support bidi reordering of text covered by display properties.
57f97249 10252
fec2107c
EZ
10253 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10254 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10255 (bidi_cache_search, bidi_cache_iterator_state)
10256 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10257 (bidi_level_of_next_char, bidi_move_to_visually_next):
10258 Support character positions inside a run of characters covered by a
fec2107c
EZ
10259 display string.
10260 (bidi_paragraph_init, bidi_resolve_explicit_1)
10261 (bidi_level_of_next_char): Call bidi_fetch_char and
10262 bidi_fetch_char_advance instead of FETCH_CHAR and
10263 FETCH_CHAR_ADVANCE.
10264 (bidi_init_it): Initialize new members.
10265 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10266 definitions.
10267 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10268 instead of using explicit *_CHAR codes.
d6d100dd
SM
10269 (bidi_resolve_explicit, bidi_resolve_weak):
10270 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10271 bidirectional text is supported only in multibyte buffers.
10272 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10273 it to initialize the frame_window_p member of struct bidi_it.
10274 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10275 (bidi_resolve_explicit, bidi_resolve_weak)
10276 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10277 bidi_it->nchars is non-positive.
10278 (bidi_level_of_next_char): Don't try to lookup the cache for the
10279 next/previous character if nothing is cached there yet, or if we
10280 were just reseat()'ed to a new position.
c40e2fb2 10281
0e14fe90
EZ
10282 * xdisp.c (set_cursor_from_row): Set start and stop points
10283 according to the row's direction when priming the loop that looks
10284 for the glyph on which to display cursor.
10285 (single_display_spec_intangible_p): Function deleted.
10286 (display_prop_intangible_p): Reimplement to call
10287 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10288 Accept 3 additional arguments needed by handle_display_spec.
10289 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10290 values: lists, `(when COND...)' forms, etc.
10291 (single_display_spec_string_p): Support property values that are
10292 lists with the argument STRING its top-level element.
10293 (display_prop_string_p): Fix the condition for processing a
10294 property that is a list to be consistent with handle_display_spec.
fec2107c 10295 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10296 last portion of handle_display_prop.
10297 (compute_display_string_pos): Accept additional argument
10298 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10299 value of a `display' property is a "replacing spec".
10300 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10301 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10302 the display property, but just return a value indicating whether
10303 the display property will replace the characters it covers.
10304 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10305 frame_window_p members of struct bidi_it.
d6d100dd
SM
10306 (compute_display_string_pos, compute_display_string_end):
10307 New functions.
fec2107c
EZ
10308 (push_it): Accept second argument POSITION, where pop_it should
10309 jump to continue iteration.
10310 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10311
fec2107c
EZ
10312 * keyboard.c (adjust_point_for_property): Adjust the call to
10313 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10314
10315 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10316 (bidi_init_it): Update prototypes.
10317 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10318 (compute_display_string_pos, compute_display_string_end):
10319 Declare prototypes.
fec2107c
EZ
10320 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10321 EMACS_INT.
fc6f18ce 10322
40087514 103232011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10324
57f53182
PE
10325 Malloc failure behavior now depends on size of allocation.
10326 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10327 * lisp.h: Change signatures accordingly.
10328 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10329 All callers changed. (Bug#8762)
10330
10331 * gnutls.c: Use Emacs's memory allocators.
10332 Without this change, the gnutls library would invoke malloc etc.
10333 directly, which causes problems on non-SYNC_INPUT hosts, and which
10334 runs afoul of improving memory_full behavior. (Bug#8761)
10335 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10336 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10337 xfree instead of the default malloc, realloc, free.
10338 (Fgnutls_boot): No need to check for memory allocation failure,
10339 since xmalloc does that for us.
10340
ac32cd99 10341 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10342 * category.c (hash_get_category_set):
10343 * ccl.c (ccl_driver):
10344 * charset.c (Fdefine_charset_internal):
10345 * charset.h (struct charset.hash_index):
10346 * composite.c (get_composition_id, gstring_lookup_cache)
10347 (composition_gstring_put_cache):
10348 * composite.h (struct composition.hash_index):
10349 * dispextern.h (struct image.hash):
10350 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10351 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10352 (hashfn_equal, hashfn_user_defined, make_hash_table)
10353 (maybe_resize_hash_table, hash_lookup, hash_put)
10354 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10355 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10356 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10357 * image.c (make_image, search_image_cache, lookup_image)
10358 (xpm_put_color_table_h):
10359 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10360 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10361 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10362 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10363 * alloc.c (allocate_vectorlike):
10364 Check for overflow in vector size calculations.
10365 * ccl.c (ccl_driver):
10366 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10367 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10368 need to be updated by these changes.
40087514
PE
10369 * fns.c (make_hash_table, maybe_resize_hash_table):
10370 Check for integer overflow with large hash tables.
0de4bb68
PE
10371 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10372 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10373 (SXHASH_REDUCE): New macro.
10374 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10375 Use it instead of discarding useful hash info with large hash values.
10376 (sxhash_float): New function.
10377 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10378 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10379 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10380 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10381 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10382 Adjust signatures to match updated version of code.
10383 (consing_since_gc): Now EMACS_INT, since a single hash table can
10384 use more than INT_MAX bytes.
10385
698d32e2
DN
103862011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10387
10388 Make it possible to build with GCC-4.6+ -O2 -flto.
10389
10390 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10391
fd6fa53f
SM
103922011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10393
10394 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10395 Call minibuffer-inactive-mode.
10396
864db017
JB
103972011-05-31 Juanma Barranquero <lekktu@gmail.com>
10398
10399 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10400 Update dependencies.
10401
2ad0baf4
DN
104022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10403
10404 * data.c (init_data): Remove code for UTS, this system is not
10405 supported anymore.
10406
4fcc2638
DN
104072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10408
10409 Don't force ./temacs to start in terminal mode.
10410
10411 * frame.c (make_initial_frame): Initialize faces in all cases, not
10412 only when CANNOT_DUMP is defined.
10413 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10414
c56e0fd5
DN
104152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10416
10417 * dispnew.c (add_window_display_history): Use const for the string
10418 pointer. Remove declaration, not needed.
10419
333d54da 104202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10421
55d4c1b2 10422 Use 'inline', not 'INLINE'.
333d54da 10423 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10424 * alloc.c, fontset.c (INLINE): Remove.
10425 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10426 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10427 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10428 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10429 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10430
738db178
DN
104312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10432
10433 Make it possible to run ./temacs.
10434
10435 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10436 syms_of_callproc does the same thing. Remove test for
10437 "initialized", do it in the caller.
10438 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10439
620c53a6
SM
104402011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10441
10442 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10443 (read_minibuf): Use get_minibuffer.
10444 (syms_of_minibuf): Use DEFSYM.
10445 (Qmetadata): New var.
10446 * data.c (Qbuffer): Don't make it static.
10447 (syms_of_data): Use DEFSYM.
10448
e003a292
PE
104492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10450
10451 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10452 (CCL_CODE_MIN): New macro.
10453
ed008a6d
PE
104542011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10455
3687c2ef
PE
10456 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10457
ed008a6d
PE
10458 * eval.c (Qdebug): Now static.
10459 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10460 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10461 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10462
d66c4c7c
CY
104632011-05-29 Chong Yidong <cyd@stupidchicken.com>
10464
10465 * image.c: Various fixes to ImageMagick code comments.
10466 (Fimagemagick_types): Doc fix.
10467
5fbc2025
PE
104682011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10469
0196f88a
PE
10470 Minor fixes prompted by GCC 4.6.0 warnings.
10471
10472 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10473
5fbc2025
PE
10474 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10475 (x_clipboard_manager_save_all): Move extern decl to ...
10476 * xterm.h: ... here, so that it can be checked for consistency.
10477
1dd3c2d9
CY
104782011-05-29 Chong Yidong <cyd@stupidchicken.com>
10479
10480 * xselect.c (x_clipboard_manager_save_frame)
10481 (x_clipboard_manager_save_all): New functions.
10482 (Fx_clipboard_manager_save): Lisp function deleted.
10483
10484 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10485 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10486
10487 * xterm.h: Update prototype.
10488
5ba6571d
WX
104892011-05-28 William Xu <william.xwl@gmail.com>
10490
10491 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10492 exiting (Bug#8239).
10493
3eaff834
JM
104942011-05-28 Jim Meyering <meyering@redhat.com>
10495
e1900994 10496 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10497 * fns.c (to_uchar): Define.
10498 (crypto_hash_function): Use it to convert some newly-signed
10499 variables to unsigned, to avoid sign-extension bugs. For example,
10500 without this change, (md5 "truc") would evaluate to
10501 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10502 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10503 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10504
0f6990a7
PE
105052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10506
10507 Integer overflow fixes.
c8a9ca5a 10508
08686060
PE
10509 * dbusbind.c: Serial number integer overflow fixes.
10510 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10511 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10512 to hold a serial number that is too large for a fixnum.
10513 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10514 Check for serial numbers out of range. Decode any serial number
59568bf0 10515 that was so large that it became a float. (Bug#8722)
08686060 10516
2d1fc3c7
PE
10517 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10518 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10519 Use XFASTINT rather than XUINT when numbers are nonnegative.
10520 (xd_append_arg, Fdbus_method_return_internal):
10521 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10522 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10523 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10524 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10525 (Bug#8722)
2d1fc3c7 10526
c8a9ca5a
PE
10527 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10528
519e1d69
PE
10529 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10530
6df6ae42 10531 ccl: Add integer overflow checks.
30569699
PE
10532 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10533 (IN_INT_RANGE): New macros.
10534 (ccl_driver): Use them to check for integer overflow when
10535 decoding a CCL program. Many of the new checks are whether XINT (x)
10536 fits in int; it doesn't always, on 64-bit hosts. The new version
10537 doesn't catch all possible integer overflows, but it's an
847044ea 10538 improvement. (Bug#8719)
30569699 10539
c11285dc
PE
10540 * alloc.c (make_event_array): Use XINT, not XUINT.
10541 There's no need for unsigned here.
10542
fdccd48e
PE
10543 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10544 This follows up to the 2011-05-06 change that substituted uintptr_t
10545 for EMACS_INT. This case wasn't caught back then.
10546
37910ab2
PE
10547 Rework Fformat to avoid integer overflow issues.
10548 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10549 now (part of C89). Include <verify.h>.
10550 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10551 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10552 (Fformat): Avoid the prepass trying to compute sizes; it was only
10553 approximate and thus did not catch overflow reliably. Instead, walk
10554 through the format just once, formatting and computing sizes as we go,
10555 checking for integer overflow at every step, and allocating a larger
10556 buffer as needed. Keep track separately whether the format is
10557 multibyte. Keep only the most-recently calculated precision, rather
10558 than them all. Record whether each argument has been converted to
10559 string. Use EMACS_INT, not int, for byte and char and arg counts.
10560 Support field widths and precisions larger than INT_MAX. Avoid
10561 sprintf's undefined behavior with conversion specifications such as %#d
10562 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10563 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10564 formatting out-of-range floating point numbers with int
9173deec 10565 formats. (Bug#8668)
37910ab2 10566
2e6578fb
PE
10567 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10568
0ae6bdee
PE
10569 * data.c: Avoid integer truncation in expressions involving floats.
10570 * data.c: Include <intprops.h>.
10571 (arith_driver): When there's an integer overflow in an expression
10572 involving floating point, convert the integers to floating point
10573 so that the resulting value does not suffer from catastrophic
10574 integer truncation. For example, on a 64-bit host (* 4
10575 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10576 Do not rely on undefined behavior after integer overflow.
10577
de883a70
PE
10578 merge count_size_as_multibyte, parse_str_to_multibyte
10579 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10580 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10581 Check for integer overflow.
10582 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10583 since it's now a duplicate of the other. This is more of
10584 a character than a buffer op, so better that it's in character.c.
10585 * fns.c, print.c: Adjust to above changes.
10586
2ff916cb
PE
105872011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10588
10589 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10590
f1b54466
PE
105912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10592
fb1ac845
PE
10593 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10594 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10595 (x_clipboard_manager_save): Now static.
10596 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10597
f1b54466
PE
10598 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10599 (crypto_hash_function): Now static.
10600 Fix pointer signedness problems. Avoid unnecessary initializations.
10601
a9f737ee
CY
106022011-05-27 Chong Yidong <cyd@stupidchicken.com>
10603
10604 * termhooks.h (Vselection_alist): Make it terminal-local.
10605
10606 * terminal.c (create_terminal): Initialize it.
10607
10608 * xselect.c: Support for clipboard managers.
10609 (Vselection_alist): Move to termhooks.h as terminal-local var.
10610 (LOCAL_SELECTION): New macro.
10611 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10612 (symbol_to_x_atom): Remove gratuitous arg.
10613 (x_handle_selection_request, lisp_data_to_selection_data)
10614 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10615 (x_own_selection, x_get_local_selection, x_convert_selection):
10616 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10617 (some_frame_on_display): Delete unused function.
10618 (Fx_own_selection_internal, Fx_get_selection_internal)
10619 (Fx_disown_selection_internal, Fx_selection_owner_p)
10620 (Fx_selection_exists_p): New optional frame arg.
10621 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10622 (x_handle_selection_clear): Don't treat other terminals with the
10623 same keyboard specially. Use the terminal-local Vselection_alist.
10624 (x_clear_frame_selections): Use Frun_hook_with_args.
10625
10626 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10627
10628 * xterm.h: Add support for those atoms.
10629
e067f0c1
CY
106302011-05-26 Chong Yidong <cyd@stupidchicken.com>
10631
10632 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10633 (converted_selections, conversion_fail_tag): New global variables.
10634 (x_selection_request_lisp_error): Free the above.
10635 (x_get_local_selection): Remove unnecessary code.
10636 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10637 of converted selections stored in converted_selections.
10638 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10639 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10640 (x_convert_selection): New function.
10641 (x_handle_selection_event): Simplify.
10642 (x_get_foreign_selection): Don't ignore incoming requests while
10643 waiting for an answer; this will fail when we implement
10644 SAVE_TARGETS, and seems unnecessary anyway.
10645 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10646 (Vx_sent_selection_functions): Doc fix.
10647
0f4aebc0
LL
106482011-05-26 Leo Liu <sdl.web@gmail.com>
10649
10650 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10651
e61124cd
YM
106522011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10653
10654 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10655
10656 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10657 for fringe update if it has periodic bitmap.
ac389d0c 10658 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10659 and fringe_bitmap_periodic_p.
10660
10661 * fringe.c (get_fringe_bitmap_data): New function.
10662 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10663 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10664 row. Mark glyph row for fringe update if periodicity changed.
10665
10666 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10667 for fringe update unless it has periodic bitmap.
10668
f16d9837
KH
106692011-05-25 Kenichi Handa <handa@m17n.org>
10670
10671 * xdisp.c (get_next_display_element): Set correct it->face_id for
10672 a static composition.
10673
e1b90ef6
LL
106742011-05-24 Leo Liu <sdl.web@gmail.com>
10675
10676 * deps.mk (fns.o):
10677 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10678
10679 * fns.c (crypto_hash_function, Fsha1): New function.
10680 (Fmd5): Use crypto_hash_function.
10681 (syms_of_fns): Add Ssha1.
10682
7400048f
PE
106832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10684
10685 * gnutls.c: Remove unused macros.
10686 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10687 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10688 Remove macros that are defined and never used.
10689 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10690
abb71cf4
CY
106912011-05-22 Chong Yidong <cyd@stupidchicken.com>
10692
10693 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10694 (Fx_get_selection_internal): Minor cleanup.
10695 (Fx_own_selection_internal): Rename arguments for consistency with
10696 select.el.
10697
6307db39
PE
106982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10699
10700 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10701
f3d4e0a4
CY
107022011-05-22 Chong Yidong <cyd@stupidchicken.com>
10703
10704 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10705
4d8ade89
YM
107062011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10707
10708 * dispnew.c (scrolling_window): Don't exclude the case that the
10709 last enabled row in the desired matrix touches the bottom boundary.
10710
32078c8d
GM
107112011-05-21 Glenn Morris <rgm@gnu.org>
10712
10713 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10714 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10715 and add some more files.
32078c8d 10716
7285dc67
EZ
107172011-05-20 Eli Zaretskii <eliz@gnu.org>
10718
10719 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10720 report_file_error introduced by the change from 2011-05-07.
10721
89d1bd22
PE
107222011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10723
10724 * systime.h (Time): Define only if emacs is defined.
10725 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10726 where the include path doesn't have X11/X.h by default. See
10727 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10728
cd394be1 107292011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10730
10731 * composite.c (find_automatic_composition): Fix previous change.
10732
b9704ad9
GM
107332011-05-20 Glenn Morris <rgm@gnu.org>
10734
10735 * lisp.mk: New file, split from Makefile.in.
10736 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10737 (shortlisp): Remove.
10738 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10739
4a720484
GM
107402011-05-19 Glenn Morris <rgm@gnu.org>
10741
10742 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10743 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10744 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10745 (lisp): Set the order to that of loadup.el.
10746 (shortlisp): Make it a copy of $lisp.
10747 (SOME_MACHINE_LISP): Remove.
10748 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10749 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10750
a28d4396
KH
107512011-05-18 Kenichi Handa <handa@m17n.org>
10752
10753 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10754 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10755 (find_automatic_composition): Mostly rewrite for efficiency.
10756
a2b1fa8e
JB
107572011-05-18 Juanma Barranquero <lekktu@gmail.com>
10758
10759 * makefile.w32-in: Update dependencies.
10760
8e1f5610
CS
107612011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10762
10763 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10764 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10765
7025ee00 107662011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10767
cdfa6eab
PE
10768 Fix some integer overflow issues, such as string length overflow.
10769
06d6db33
PE
10770 * insdel.c (count_size_as_multibyte): Check for string overflow.
10771
2b4560a8
PE
10772 * character.c (lisp_string_width): Check for string overflow.
10773 Use EMACS_INT, not int, for string indexes and lengths; in
10774 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10775 the resulting string length overflows an EMACS_INT; instead,
10776 report a string overflow if no precision given. When checking for
10777 precision exhaustion, use a check that cannot possibly have
10778 integer overflow. (Bug#8675)
10779 * character.h (lisp_string_width): Adjust to new signature.
10780
cb93f9be
PE
10781 * alloc.c (string_overflow): New function.
10782 (Fmake_string): Use it. This doesn't change behavior, but saves
10783 a few bytes and will simplify future changes.
10784 * character.c (string_escape_byte8): Likewise.
10785 * lisp.h (string_overflow): New decl.
10786
1a1f3366
PE
10787 Fixups, following up to the user-interface timestamp change.
10788 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10789 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10790 * msdos.c (mouse_get_pos): Likewise.
10791 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10792 * w32gui.h (Time): Define by including "systime.h" rather than by
10793 declaring it ourselves. (Bug#8664)
10794
d4e3e4d3
PE
10795 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10796 * image.c (clear_image_cache): Likewise.
10797
f6a24d19
PE
10798 * term.c (term_mouse_position): Don't assume time_t wraparound.
10799
08dc5ae6
PE
10800 Be more systematic about user-interface timestamps.
10801 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10802 and sometimes 'EMACS_UINT', to represent these timestamps.
10803 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10804 This makes the code easier to follow, and makes it easier to catch
10805 integer overflow bugs such as Bug#8664.
10806 * frame.c (Fmouse_position, Fmouse_pixel_position):
10807 Use Time, not unsigned long, for user-interface timestamps.
10808 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10809 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10810 * keyboard.h (last_event_timestamp): Likewise.
10811 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10812 * menu.h (xmenu_show): Likewise.
10813 * term.c (term_mouse_position): Likewise.
10814 * termhooks.h (struct input_event.timestamp): Likewise.
10815 (struct terminal.mouse_position_hook): Likewise.
10816 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10817 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10818 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10819 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10820 what it was before.
10821 * menu.h, termhooks.h: Include "systime.h", for Time.
10822
8e55734a
PE
10823 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10824 Don't assume that the difference between two unsigned long values
10825 can fit into an integer. At this point, we know button_down_time
10826 <= event->timestamp, so the difference must be nonnegative, so
10827 there's no need to cast the result if double-click-time is
10828 nonnegative, as it should be; check that it's nonnegative, just in
10829 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10830 apart (about 25 days). (Bug#8664)
8e55734a 10831
841f1b75 10832 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10833 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10834
3e26f69c
PE
10835 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10836 that always fit in int. Use a sentinel instead of a counter, to
10837 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10838 * frame.h (struct frame): Use int for menu_bar_items_used
10839 instead of EMACS_INT, since it always fits in int.
3e26f69c 10840
5cc152c0
PE
10841 * menu.c (grow_menu_items): Check for int overflow.
10842
d89eb65e
PE
10843 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10844
5235bd3e
PE
10845 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10846 Before, the code was not consistent. These values cannot exceed
10847 2**31 - 1 so there's no need to make them unsigned.
10848 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10849 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10850 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10851 as modifiers.
10852 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10853
bc827e23
PE
10854 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10855 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10856 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10857 presumably because the widths might not match.
10858
78eb494e
PE
10859 * window.c (size_window): Avoid needless test at loop start.
10860
04f2d78b
CB
108612011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10862
10863 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10864
d2fc7e3d 108652011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10866
10867 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10868
d2fc7e3d 108692011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10870
10871 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10872 `width' to `bar_area_x' and `bar_area_width', respectively.
10873 (x_scroll_run): Take account of fringe background extension.
10874
04f2d78b
CB
10875 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10876 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10877 `bar_area_width', respectively.
10878 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10879 background extension.
10880
79b70037
GM
108812011-05-10 Jim Meyering <meyering@redhat.com>
10882
10883 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10884
2f142cc5
JB
108852011-05-10 Juanma Barranquero <lekktu@gmail.com>
10886
10887 * image.c (Finit_image_library): Return t for built-in image types,
10888 like pbm and xbm. (Bug#8640)
10889
57679c86
AS
108902011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10891
10892 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10893
888c9e86
EZ
108942011-05-07 Eli Zaretskii <eliz@gnu.org>
10895
b0512a1d
EZ
10896 * w32console.c (Fset_screen_color): Doc fix.
10897 (Fget_screen_color): New function.
10898 (syms_of_ntterm): Defsubr it.
10899
7285dc67
EZ
10900 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10901 unlink the temporary file if Fcall_process didn't create it in the
10902 first place.
10903 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10904 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10905 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10906 cue to call_process_cleanup not to close that handle.
10907
4d3fcc8e
BK
109082011-05-07 Ben Key <bkey76@gmail.com>
10909
10910 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10911 one of two shell specific rules, either bootstrap-temacs-CMD or
10912 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10913 to the previous implementation of the bootstrap-temacs rule.
10914 The bootstrap-temacs-CMD rule is similar to the previous
10915 implementation of the bootstrap-temacs rule except that it
10916 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10917 variable.
10918
10919 These changes, along with some changes to nt/configure.bat,
10920 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10921 earlier fix to add support for --cflags and --ldflags options
10922 that include quotes so that it works whether make uses cmd or
10923 sh as the shell.
10924
b4289b64
MA
109252011-05-06 Michael Albinus <michael.albinus@gmx.de>
10926
10927 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10928 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10929 is a constant.
10930 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10931 a string. Handle both cases.
10932 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10933 (Fdbus_register_method): Use Qinvalid_function.
10934
af4c0e28
JB
109352011-05-06 Juanma Barranquero <lekktu@gmail.com>
10936
10937 * makefile.w32-in: Update dependencies.
10938 (LISP_H): Add inttypes.h and stdin.h.
10939 (PROCESS_H): Add unistd.h.
10940
c51453d9
EZ
109412011-05-06 Eli Zaretskii <eliz@gnu.org>
10942
10943 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10944 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10945
8ff0ac3c 109462011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10947
4c4b566b
PE
10948 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10949
aab2b9b5
PE
10950 * term.c (vfatal): Remove stray call to va_end.
10951 It's not needed and the C Standard doesn't allow it here anyway.
10952
c378da0b
PE
10953 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10954 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10955
288b08c7
PE
10956 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10957 bytes.
10958
e3601888
PE
10959 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10960
db6c0e74
PE
10961 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10962
dd5963ea
PE
10963 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10964
88c9450f
PE
10965 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10966
2f9442b8
PE
10967 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10968
c032b5f8
PE
10969 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10970 * charset.c (Fdefine_charset_internal): Don't initialize
10971 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10972 32-bit int (Bug#8600).
a108c10b
PE
10973
10974 * lread.c (read_integer): Be more consistent with string-to-number.
10975 Use string_to_number to do the actual conversion; this avoids
10976 rounding errors and fixes some other screwups. Without this fix,
10977 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10978 (digit_to_number): Move earlier, for benefit of read_integer.
10979 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10980 not a digit in any supported base. (Bug#8602)
a108c10b 10981
ad5f9eea
PE
10982 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10983
aec1708a
PE
10984 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10985 to match comment at start of function. This also removes a
10986 GCC warning about overflow in a 32+64-bit port.
10987
47be4ab5
PE
10988 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10989
371cac43
PE
10990 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10991 Reported by Stefan Monnier in
10992 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10993 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10994 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10995
d01a7826
PE
10996 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10997 (EMACS_UINTPTR): Likewise, with uintptr_t.
10998
7fd47d5c
PE
10999 * lisp.h: Prefer 64-bit EMACS_INT if available.
11000 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11001 on 32-bit hosts that have 64-bit int, so that they can access
11002 large files.
122b0c86
PE
11003 However, temporarily disable this change unless the temporary
11004 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11005
8727937b
PE
11006 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11007
8ac068ac
PE
11008 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11009 This removes an assumption that EMACS_INT and long are the same
11010 width as pointers. The assumption is true for Emacs porting targets
11011 now, but we want to make other targets possible.
11012 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11013 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11014 In the rest of the code, change types of integers that hold casted
11015 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11016 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11017 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11018 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11019 No need to cast type when ORing.
11020 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11021 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11022 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11023 assume EMACS_INT is the same width as char *.
11024 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11025 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11026 Remove no-longer-needed casts.
11027 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11028 (xg_tool_bar_help_callback, xg_make_tool_item):
11029 Use EMACS_INTPTR to hold an integer
11030 that will be cast to void *; this can avoid a GCC warning
11031 if EMACS_INT is not the same width as void *.
11032 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11033 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11034 (current_message_1, set_message_1):
11035 Use a local to convert to proper width without a cast.
11036 * xmenu.c (dialog_selection_callback): Likewise.
11037
ede49d71
PE
11038 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11039 Also, don't assume VALBITS / RAND_BITS is less than 5,
11040 and don't rely on undefined behavior when shifting a 1 left into
11041 the sign bit.
11042 * lisp.h (get_random): Change signature to match.
11043
2f30ecd0
PE
11044 * lread.c (hash_string): Use size_t, not int, for hash computation.
11045 Normally we prefer signed values; but hashing is special, because
11046 it's better to use unsigned division on hash table sizes so that
11047 the remainder is nonnegative. Also, size_t is the natural width
11048 for hashing into memory. The previous code used 'int', which doesn't
11049 retain enough info to hash well into very large tables.
11050 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11051
2a866e7b
PE
11052 * dbusbind.c: Don't possibly lose pointer info when converting.
11053 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11054 Use XPNTR rather than XHASH, so that the high-order bits of
11055 the pointer aren't lost when converting through void *.
11056
51639eac
PE
11057 * eval.c (Fautoload): Don't double-shift a pointer.
11058
92394119
PE
11059 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11060
dbdb9a7c
JB
110612011-05-06 Juanma Barranquero <lekktu@gmail.com>
11062
11063 * gnutls.c (DEF_GNUTLS_FN):
11064 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11065
db7a0b4f
AS
110662011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11067
11068 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11069 marker. (Bug#8610)
11070
cd394be1 110712011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11072
11073 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11074 New version that can reserve upto 2GB of heap space.
11075
f7ff1b0f 110762011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11077
11078 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11079
639c109b
TZ
110802011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11081
11082 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11083 `gnutls_certificate_set_x509_key_file'.
11084
d2127135
JB
110852011-05-05 Juanma Barranquero <lekktu@gmail.com>
11086
11087 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11088 Update dependencies.
11089
e968f4f3
JB
110902011-05-04 Juanma Barranquero <lekktu@gmail.com>
11091
11092 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11093 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11094 Remove unused parameter `fildes'.
11095 * process.c (read_process_output, send_process): Don't pass it.
11096
84d358f0
JB
110972011-05-04 Juanma Barranquero <lekktu@gmail.com>
11098
11099 Fix previous change: the library cache is defined in w32.c.
11100 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11101 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11102
0898ca10
JB
111032011-05-04 Juanma Barranquero <lekktu@gmail.com>
11104
11105 Implement dynamic loading of GnuTLS on Windows.
11106
11107 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11108 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11109 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11110 Declare.
11111
11112 * gnutls.c (Qgnutls_dll): Define.
11113 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11114 (gnutls_*): Declare function pointers.
11115 (init_gnutls_functions): New function to initialize function pointers.
11116 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11117 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11118 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11119 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11120 (emacs_gnutls_write, emacs_gnutls_read)
11121 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11122 (Fgnutls_available_p): New function.
11123 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11124 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11125 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11126
11127 * image.c: Include w32.h.
11128 (Vimage_type_cache): Delete.
11129 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11130 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11131 (w32_delayed_load): Move to w32.c.
11132
11133 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11134
11135 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11136 (w32_delayed_load): Move from image.c. When loading a library, record
11137 its filename in the :loaded-from property of the library id.
11138 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11139 Initialize and staticpro them.
11140 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11141
11142 * process.c: Include lisp.h before w32.h, not after.
11143 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11144 instead of gnutls_record_check_pending.
11145
11146 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11147
ff4de4aa
TZ
111482011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11149
11150 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11151 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11152 as passed in.
11153
abe95abb
JD
111542011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11155
11156 * xterm.c (x_set_frame_alpha): Do not set property on anything
11157 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11158
e16e55d4
JB
111592011-05-02 Juanma Barranquero <lekktu@gmail.com>
11160
11161 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11162
bafcf6a5
JB
111632011-05-02 Juanma Barranquero <lekktu@gmail.com>
11164
11165 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11166 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11167 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11168 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11169 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11170 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11171 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11172 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11173 (Qgnutls_bootprop_callbacks_verify): Make static.
11174
e7a6747f
AS
111752011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11176
19ed11ba
AS
11177 * callproc.c: Indentation fixup.
11178
e7a6747f 11179 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11180 (wait_for_termination, interruptible_wait_for_termination):
11181 Move after wait_for_termination_1.
e7a6747f 11182
1ef14cb4
LMI
111832011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11184
11185 * sysdep.c (interruptible_wait_for_termination): New function
11186 which is like wait_for_termination, but allows keyboard
11187 interruptions.
11188
11189 * callproc.c (Fcall_process): Add (:file "file") as an option for
11190 the STDOUT buffer.
11191 (Fcall_process_region): Ditto.
11192
330d880c
EZ
111932011-04-30 Eli Zaretskii <eliz@gnu.org>
11194
8db90b73
EZ
11195 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11196 rather than `XVECTOR (FOO)->size'.
11197
330d880c
EZ
11198 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11199 inttypes.h, as a gnulib replacement is used if it not available in
11200 system headers.
11201
15cbd324
EZ
112022011-04-21 Eli Zaretskii <eliz@gnu.org>
11203
11204 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11205 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11206 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11207
11208 * coding.c (coding_alloc_by_realloc): Error out if destination
11209 will grow beyond MOST_POSITIVE_FIXNUM.
11210 (decode_coding_emacs_mule): Abort if there isn't enough place in
11211 charbuf for the composition carryover bytes. Reserve an extra
11212 space for up to 2 characters produced in a loop.
11213 (decode_coding_iso_2022): Abort if there isn't enough place in
11214 charbuf for the composition carryover bytes.
11215
112162011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11217
ae940cca
EZ
11218 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11219 aborting when %lld or %lll format is passed.
11220 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11221 %llo or %llx format is passed. (Bug#8545)
11222
03ab8921
EZ
11223 * window.c (window_scroll_line_based): Use a marker instead of
11224 simple variables to record original value of point. (Bug#7952)
11225
afda1437
EZ
11226 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11227 produced by %s or %c overflows available buffer space. (Bug#8545)
11228
f76dee0c
PE
112292011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11230
11231 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11232 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11233
fdc5744d
JB
112342011-04-28 Juanma Barranquero <lekktu@gmail.com>
11235
11236 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11237
638f053a
JB
112382011-04-28 Juanma Barranquero <lekktu@gmail.com>
11239
11240 * keyboard.c (Qdelayed_warnings_hook): Define.
11241 (command_loop_1): Run `delayed-warnings-hook'
11242 if Vdelayed_warnings_list is non-nil.
11243 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11244 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11245
d178f871
EZ
112462011-04-28 Eli Zaretskii <eliz@gnu.org>
11247
11248 * doprnt.c (doprnt): Don't return value smaller than the buffer
11249 size if the message was truncated. (Bug#8545).
11250
b124fd93
JB
112512011-04-28 Juanma Barranquero <lekktu@gmail.com>
11252
11253 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11254 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11255
e810457d
PE
112562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11257
11258 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11259
ea51cceb
JB
112602011-04-27 Juanma Barranquero <lekktu@gmail.com>
11261
11262 * makefile.w32-in: Update dependencies.
11263
94dcfacf
EZ
112642011-04-27 Eli Zaretskii <eliz@gnu.org>
11265
11266 Improve `doprnt' and its usage. (Bug#8545)
11267 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11268 `format_end'. Remove support for %l as a conversion specifier.
11269 Don't use xrealloc. Improve diagnostics when the %l size modifier
11270 is used. Update the commentary.
11271
11272 * eval.c (verror): Simplify calculation of size_t.
11273
11274 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11275 messages.
11276
f61f41d7
PE
112772011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11278
11279 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11280 change.
11281
96fb4434
PE
112822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11283
11284 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11285 This makes this file independent of the recent pseudovector change.
11286
671875da 112872011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11288
69e9b5a3
PE
11289 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11290
b5f869a7 11291 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11292 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11293 Remove unused local.
c8926152 11294 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11295
841a1577 11296 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11297 GCC 4.6.0 optimizes based on type-based alias analysis.
11298 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11299 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11300 != &v->size, and therefore "v->size = 1; b->size = 2; return
11301 v->size;" must therefore return 1. This assumption is incorrect
11302 for Emacs, since it type-puns struct Lisp_Vector * with many other
11303 types. To fix this problem, this patch adds a new type struct
f904488f 11304 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11305 and pseudovectors, and helps optimizing compilers not get fooled
11306 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11307 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11308 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11309 the size member.
eab3844f
PE
11310 (XSETPVECTYPE): Rewrite in terms of new macro.
11311 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11312 This is a bit clearer, and further avoids the possibility of
11313 undesirable aliasing.
11314 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11315 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11316 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11317 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11318 (ASIZE): Now uses header.size rather than size.
11319 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11320 to avoid the hassle of writing XVECTOR (foo)->header.size.
11321 (struct vectorlike_header): New type.
eab3844f
PE
11322 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11323 object, to help avoid aliasing.
11324 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11325 (SUBRP): Likewise, since Lisp_Subr is a special case.
11326 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11327 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11328 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11329 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11330 changed to be "header.size" and "header.next".
11331 * buffer.h (struct buffer): Likewise.
11332 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11333 * frame.h (struct frame): Likewise.
11334 * process.h (struct Lisp_Process): Likewise.
11335 * termhooks.h (struct terminal): Likewise.
11336 * window.c (struct save_window_data, struct saved_window): Likewise.
11337 * window.h (struct window): Likewise.
11338 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11339 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11340 * buffer.c (init_buffer_once): Likewise.
11341 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11342 special case.
11343 * process.c (Fformat_network_address): Use local var for size,
11344 for brevity.
11345
0df1eac5
PE
11346 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11347
847ab9d1 11348 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11349 * data.c (atof): Remove decl; no longer used or needed.
11350 (digit_to_number): Move to lread.c.
11351 (Fstring_to_number): Use new string_to_number function, to be
11352 consistent with how the Lisp reader treats infinities and NaNs.
11353 Do not assume that floating-point numbers represent EMACS_INT
11354 without losing information; this is not true on most 64-bit hosts.
11355 Avoid double-rounding errors, by insisting on integers when
11356 parsing non-base-10 numbers, as the documentation specifies.
11357 * lisp.h (string_to_number): New decl, replacing ...
11358 (isfloat_string): Remove.
bc0a5c13 11359 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11360 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11361 appears to have been a coding error. Similarly, do not accept
11362 strings like +-1e0 as floating point numbers. Do not report
11363 overflow for integer overflows unless the base is not 10 which
11364 means we have no simple and reliable way to continue.
11365 Break out the floating-point parsing into a new
11366 function string_to_number, so that Fstring_to_number parses
11367 floating point numbers consistently with the Lisp reader.
04f2d78b 11368 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11369 (E_CHAR, EXP_INT): Remove, replacing with ...
11370 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11371 (string_to_number): New function, replacing isfloat_string.
11372 This function checks for valid syntax and produces the resulting
11373 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11374 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11375 so that overflow for non-base-10 numbers is reported only when
11376 there's no portable and simple way to convert to floating point.
452f4150 11377
67769ffc
PE
11378 * textprop.c (set_text_properties_1): Rewrite for clarity,
11379 and to avoid GCC warning about integer overflow.
11380
c20db43f
PE
11381 * intervals.h (struct interval): Use EMACS_INT for members
11382 where EMACS_UINT might cause problems. See
11383 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11384 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11385 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11386 All uses changed.
37aa2f85
PE
11387 (offset_intervals): Tell GCC not to worry about length overflow
11388 when negating a negative length.
c20db43f 11389
2538aa2f
PE
11390 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11391 (overrun_check_free): Likewise.
11392
f2d3008d
PE
11393 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11394 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11395 word size.
11396
ec8df744
PE
11397 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11398 (gnutls_make_error): Rename local to avoid shadowing.
11399 (gnutls_emacs_global_deinit): ifdef out; not used.
11400 (Fgnutls_boot): Use const for pointer to readonly storage.
11401 Comment out unused local. Fix pointer signedness problems.
11402
640ee02d
PE
11403 * lread.c (openp): Don't stuff size_t into an 'int'.
11404 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11405 about possible signed overflow.
11406
6048fb2a
PE
11407 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11408 (GDK_KEY_g): Don't define if already defined.
11409 (xg_prepare_tooltip): Avoid pointer signedness problem.
11410 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11411
fa3c87e1
PE
11412 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11413 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11414
2172544b
PE
11415 * xfns.c (Fx_window_property): Simplify a bit,
11416 to make a bit faster and to avoid GCC 4.6.0 warning.
11417 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11418
9b821a21
PE
11419 * fns.c (internal_equal): Don't assume size_t fits in int.
11420
3c616cfa
PE
11421 * alloc.c (compact_small_strings): Tighten assertion a little.
11422
c2982e87
PE
11423 Replace pEd with more-general pI, and fix some printf arg casts.
11424 * lisp.h (pI): New macro, generalizing old pEd macro to other
11425 conversion specifiers. For example, use "...%"pI"d..." rather
11426 than "...%"pEd"...".
11427 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11428 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11429 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11430 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11431 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11432 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11433 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11434 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11435 64-bit hosts.
11436 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11437 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11438 * print.c (safe_debug_print, print_object): Likewise.
11439 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11440 to int.
6f04d126
PE
11441 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11442 avoiding the 0 flag, which is not portable.
c2982e87
PE
11443 * process.c (Fmake_network_process): Use pI to avoid cast.
11444 * region-cache.c (pp_cache): Likewise.
11445 * xdisp.c (decode_mode_spec): Likewise.
11446 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11447 behavior on 64-bit hosts with printf arg.
6f04d126 11448 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11449 (x_stop_queuing_selection_requests): Likewise.
11450 (x_get_window_property): Don't truncate byte count to an 'int'
11451 when tracing.
0b432f21 11452
5e073ec7
PE
11453 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11454 here, since it parses constructs like leading '-' and spaces,
11455 which are not wanted; and it overflows with large numbers.
11456 Instead, simply match F[0-9]+, which is what is wanted anyway.
11457
36372bf9
PE
11458 * alloc.c: Remove unportable assumptions about struct layout.
11459 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11460 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11461 (allocate_vectorlike, make_pure_vector): Use the new macros,
11462 plus offsetof, to remove unportable assumptions about struct layout.
11463 These assumptions hold on all porting targets that I know of, but
11464 they are not guaranteed, they're easy to remove, and removing them
11465 makes further changes easier.
11466
0b432f21
PE
11467 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11468 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11469 (string_overrun_cookie): Now const. Use initializers that
11470 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11471 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11472 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11473 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11474 multiple of sizeof (EMACS_INT); it need not be, if
11475 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11476 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11477
895009e1
JB
114782011-04-26 Juanma Barranquero <lekktu@gmail.com>
11479
11480 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11481
6a7a1b0b
TZ
114822011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11483
11484 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11485 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11486 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11487
841a1577 114882011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11489
11490 * lisp.h (Qdebug): List symbol.
895009e1 11491 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11492 * keyboard.c (debug-on-event): New variable.
11493 (handle_user_signal): Break into debugger when debug-on-event
11494 matches the current signal symbol.
11495
f2d3ba6f
DN
114962011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11497
11498 * alloc.c (check_sblock, check_string_bytes)
11499 (check_string_free_list): Convert to standard C.
11500
42ce4c63
TZ
115012011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11502
11503 * w32.c (emacs_gnutls_push): Fix typo.
11504
825cd63c
EZ
115052011-04-25 Eli Zaretskii <eliz@gnu.org>
11506
fb11d64d
EZ
11507 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11508 "cast to pointer from integer of different size".
11509
825cd63c
EZ
11510 Improve doprnt and its use in verror. (Bug#8545)
11511 * doprnt.c (doprnt): Document the set of format control sequences
11512 supported by the function. Use SAFE_ALLOCA instead of always
11513 using `alloca'.
11514
11515 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11516 is one byte too soon. Don't use xrealloc; instead xfree and
11517 xmalloc anew.
11518
e061a11b
TZ
115192011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11520
11521 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11522 callbacks stage.
11523
11524 * gnutls.c: Renamed global_initialized to
11525 gnutls_global_initialized. Added internals for the
11526 :verify-hostname-error, :verify-error, and :verify-flags
11527 parameters of `gnutls-boot' and documented those parameters in the
11528 docstring. Start callback support.
9173deec
JB
11529 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11530 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11531 on error. Return error code.
e061a11b
TZ
11532 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11533 (emacs_gnutls_read): Likewise.
11534 (Fgnutls_boot): Return handshake error code.
11535 (emacs_gnutls_handle_error): New function.
11536 (wsaerror_to_errno): Likewise.
11537
11538 * w32.h (emacs_gnutls_pull): Add prototype.
11539 (emacs_gnutls_push): Likewise.
11540
11541 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11542 (emacs_gnutls_push): Likewise.
11543
115442011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11545
11546 * process.c (wait_reading_process_output): Check if GnuTLS
11547 buffered some data internally if no FDs are set for TLS
11548 connections.
11549
11550 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11551 (LIBS): Link to USER_LIBS.
11552 ($(BLD)/gnutls.$(0)): New target.
11553
fa6996bc
EZ
115542011-04-24 Eli Zaretskii <eliz@gnu.org>
11555
eb35682e
EZ
11556 * xdisp.c (handle_single_display_spec): Rename the
11557 display_replaced_before_p argument into display_replaced_p, to
11558 make it consistent with the commentary. Fix typos in the
11559 commentary.
11560
e2ad650c
EZ
11561 * textprop.c (syms_of_textprop): Remove dead code.
11562 (copy_text_properties): Delete obsolete commentary about an
11563 interface that was deleted long ago. Fix typos in the description
11564 of arguments.
11565
1b2de274
EZ
11566 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11567 to changes in oldXMenu/XMenu.h from 2011-04-16.
11568 <menu_help_message, prev_menu_help_message>: Constify.
11569 (IT_menu_make_room): menu->help_text is now `const char **';
11570 adjust.
11571
11572 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11573 to changes in oldXMenu/XMenu.h from 2011-04-16.
11574 (struct XMenu): Declare `help_text' `const char **'.
11575
11576 * xfaces.c <Qunspecified>: Make extern again.
11577
11578 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11579 required by POSIX.
1b2de274 11580
762b15be
EZ
11581 * doc.c (get_doc_string): Improve the format passed to `error'.
11582
11583 * doprnt.c (doprnt): Improve commentary.
11584
11585 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11586
11587 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11588 them with etags.
11589
f1052e5d
EZ
11590 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11591 changes in globals.h immediately force recompilation.
762b15be
EZ
11592 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11593 $(CURDIR)/s/ms-w32.h.
11594 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11595
fa6996bc
EZ
11596 * character.c (Fchar_direction): Function deleted.
11597 (syms_of_character): Don't defsubr it.
11598 <char-direction-table>: Deleted.
11599
e6c3da20
EZ
116002011-04-23 Eli Zaretskii <eliz@gnu.org>
11601
11602 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11603 * doprnt.c: Include limits.h.
11604 (SIZE_MAX): New macro.
04f2d78b
CB
11605 (doprnt): Return a size_t value. 2nd arg is now size_t.
11606 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11607 Improve overflow protection. Support `l' modifier for integer
11608 conversions. Support %l conversion. Don't assume an EMACS_INT
11609 argument for integer conversions and for %c.
11610
11611 * lisp.h (doprnt): Restore prototype.
11612
11613 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11614 $(SRC)/character.h.
11615
11616 * Makefile.in (base_obj): Add back doprnt.o.
11617
11618 * deps.mk (doprnt.o): Add back prerequisites.
11619 (callint.o): Depend on character.h.
11620
11621 * eval.c (internal_lisp_condition_case): Include the handler
11622 representation in the error message.
11623 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11624 when breaking from the loop.
11625
11626 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11627
11628 * callint.c (Fcall_interactively): When displaying error message
11629 about invalid control letter, pass the character's codepoint, not
11630 a pointer to its multibyte form. Improve display of the character
11631 in octal and display also its hex code.
11632
11633 * character.c (char_string): Use %x to display the (unsigned)
11634 codepoint of an invalid character, to avoid displaying a bogus
11635 negative value.
11636
11637 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11638 `error', not SYMBOL_NAME itself.
11639
11640 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11641 character arguments to `error'.
11642
11643 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11644 to `error' in error message about FINAL_CHAR argument. Make sure
11645 FINAL_CHAR is a character, and use %c when it is passed as
11646 argument to `error'.
11647
4ffd0d6b 116482011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11649
11650 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11651
11652 * w32.c: Include <time.h>.
11653 (sys_localtime): New function.
11654
4ffd0d6b 116552011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11656
11657 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11658
4ffd0d6b 11659 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11660
4ffd0d6b 116612011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11662
4ffd0d6b
GM
11663 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11664 zombies (Bug#8467).
aac0c6e3 11665
04c56954
EZ
116662011-04-19 Eli Zaretskii <eliz@gnu.org>
11667
11668 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11669 gl_state.e_property when gl_state.object is Qt.
11670
11671 * insdel.c (make_gap_larger): Remove limitation of buffer size
11672 to <= INT_MAX.
11673
16a43933
CY
116742011-04-18 Chong Yidong <cyd@stupidchicken.com>
11675
11676 * xdisp.c (lookup_glyphless_char_display)
11677 (produce_glyphless_glyph): Handle cons cell entry in
11678 glyphless-char-display.
11679 (Vglyphless_char_display): Document it.
11680
11681 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11682 glyphless-char-display.
11683
4581706e
CY
116842011-04-17 Chong Yidong <cyd@stupidchicken.com>
11685
11686 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11687
11688 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11689
11690 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11691 definition for no-X builds.
11692
4887c6e2 116932011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11694
fd35b6f9
PE
11695 Static checks with GCC 4.6.0 and non-default toolkits.
11696
5c1ccb01
PE
11697 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11698
006c5daa
PE
11699 * process.c (keyboard_bit_set): Define only if SIGIO.
11700 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11701 (send_process): Repair possible setjmp clobbering.
11702
efc736d3
PE
11703 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11704
4e2fe2e6
PE
11705 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11706
f97334a2
PE
11707 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11708
4e75f29d
PE
11709 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11710 Define only if needed.
11711
90efadd1
PE
11712 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11713 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11714 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11715
3c647824
PE
11716 * dispextern.h (struct redisplay_interface): Rename param
11717 to avoid shadowing.
e264f262 11718 * termhooks.h (struct terminal): Likewise.
761383f4 11719 * xterm.c (xembed_send_message): Likewise.
3c647824 11720
b58c5c4a
PE
11721 * insdel.c (make_gap_smaller): Define only if
11722 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11723
cad59032
PE
11724 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11725 it.
11726
c339dc2e
PE
11727 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11728 so that we aren't warned about unused symbols.
11729
91a3e27b
PE
11730 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11731
399c71d3 11732 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11733
8ffc96f5
PE
11734 * xfns.c (x_real_positions): Mark locals as initialized.
11735
eef9bc79
PE
11736 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11737
098db9dd
PE
11738 * xterm.c: Fix problems found by static analysis with other toolkits.
11739 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11740 (x_dispatch_event): Declare static if USE_GTK, and
11741 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11742 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11743 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11744 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11745 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11746
eb18f6cc
PE
11747 * xmenu.c (menu_help_callback): Pointer type fixes.
11748 Use const pointers when pointing at readonly data. Avoid pointer
11749 signedness clashes.
11750 (FALSE): Remove unused macro.
11751 (update_frame_menubar): Remove unused decl.
11752
1fe72bf8
PE
11753 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11754
60d9e1db
PE
11755 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11756 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11757 (single_menu_item): Rename local to avoid shadowing.
11758
39261c26
PE
11759 * keyboard.c (make_lispy_event): Remove unused local var.
11760
018c5e19
PE
11761 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11762 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11763
63d2b86e
PE
11764 * bitmaps: Change bitmaps from unsigned char back to the X11
11765 compatible char. Avoid the old compiler warnings about
11766 out-of-range initializers by using, for example, '\xab' rather
11767 than 0xab.
11768
aefd87e1
PE
11769 * xgselect.c (xgselect_initialize): Check vs interface
11770 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11771
bf501fb9
PE
11772 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11773
e9829fdf
PE
11774 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11775 to read-only memory.
11776
1086c095
PE
11777 * fns.c (vector): Remove; this old hack is no longer needed.
11778
2baccd04 11779 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11780 Remove unused var.
dde42981 11781 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11782
72391843 11783 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11784
436c16df 11785 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11786 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11787 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11788
92bb796d 11789 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11790 (x_term_init): Remove local to avoid shadowing.
92bb796d 11791
764430a3 11792 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11793
11794 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11795 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11796
d1dfb56c
EZ
117972011-04-16 Eli Zaretskii <eliz@gnu.org>
11798
c4354cb4
EZ
11799 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11800
d1dfb56c
EZ
11801 Fix regex.c, syntax.c and friends for buffers > 2GB.
11802 * syntax.h (struct gl_state_s): Declare character position members
11803 EMACS_INT.
11804
11805 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11806
04f2d78b
CB
11807 * textprop.c (verify_interval_modification, interval_of):
11808 Declare arguments EMACS_INT.
d1dfb56c
EZ
11809
11810 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11811 EMACS_INT.
11812
11813 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11814
11815 * indent.c (Fvertical_motion): Local variable it_start is now
11816 EMACS_INT.
11817
11818 * regex.c (re_match, re_match_2, re_match_2_internal)
11819 (bcmp_translate, regcomp, regexec, print_double_string)
11820 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11821 (re_compile_pattern, re_exec): Declare arguments and local
11822 variables `size_t' and `ssize_t' and return values `regoff_t', as
11823 appropriate.
11824 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11825 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11826 <compile_stack_type>: `size' and `avail' are now `size_t'.
11827
11828 * regex.h <regoff_t>: Use ssize_t, not int.
11829 (re_search, re_search_2, re_match, re_match_2): Arguments that
11830 specify buffer/string position and length are now ssize_t and
11831 size_t. Return type is regoff_t.
11832
613052cd
BK
118332011-04-16 Ben Key <bkey76@gmail.com>
11834
11835 * nsfont.m: Fixed bugs in ns_get_family and
11836 ns_descriptor_to_entity that were caused by using free to
11837 deallocate memory blocks that were allocated by xmalloc (via
11838 xstrdup). This caused Emacs to crash when compiled with
11839 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11840 --enable-checking=xmallocoverrun). xfree is now used to
11841 deallocate these memory blocks.
11842
4170f62f 118432011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11844
71b41406
PE
11845 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11846
9587a89d
PE
11847 emacs_write: Accept and return EMACS_INT for sizes.
11848 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11849 et seq.
11850 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11851 Accept and return EMACS_INT.
11852 (emacs_gnutls_write): Return the number of bytes written on
11853 partial writes.
11854 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11855 (emacs_read, emacs_write): Remove check for negative size, as the
11856 Emacs source code has been audited now.
9587a89d
PE
11857 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11858 (emacs_read, emacs_write): Use it.
273a5f82
PE
11859 * process.c (send_process): Adjust to the new signatures of
11860 emacs_write and emacs_gnutls_write. Do not attempt to store
11861 a byte offset into an 'int'; it might overflow.
9587a89d 11862 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11863
3e047f51
PE
11864 * sound.c: Don't assume sizes fit in 'int'.
11865 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11866 Return EMACS_INT, not int.
3e047f51 11867 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11868 Accept EMACS_INT, not int.
11869 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11870 record read return values.
11871
cc39a9db
BK
118722011-04-15 Ben Key <bkey76@gmail.com>
11873
c9d0ec6d
JB
11874 * keyboard.c (Qundefined): Don't declare static since it is used
11875 in nsfns.m.
11876 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11877 static since they are used in nsfont.m.
cc39a9db 11878
6c60eb9f
SM
118792011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11880
11881 * process.c (Qprocessp): Don't declare static.
11882 * lisp.h (Qprocessp): Declare again.
11883
7990b61a
JB
118842011-04-15 Juanma Barranquero <lekktu@gmail.com>
11885
11886 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11887
5d4cb038
PE
118882011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11889
8bd7b830 11890 Improve C-level modularity by making more things 'static'.
cd64ea1d 11891
e3b27b31
PE
11892 Don't publish debugger-only interfaces to other modules.
11893 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11894 (verify_bytepos, count_markers): Move decls to the only modules
11895 that need them.
11896 * region-cache.h (pp_cache): Likewise.
11897 * window.h (check_all_windows): Likewise.
11898 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11899
5d4cb038
PE
11900 * sysdep.c (croak): Now static, if
11901 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11902 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11903
11904 * alloc.c (refill_memory_reserve): Now static if
11905 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11906 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11907
e87b6180
PE
11908 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11909 Define only if USE_LUCID.
11910
ac64929e
PE
11911 * xrdb.c (x_customization_string, x_rm_string): Now static.
11912
6f37259d
PE
11913 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11914 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11915
1683e3ab
PE
11916 * xdisp.c (draw_row_with_mouse_face): Now static.
11917 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11918
de9c2632
PE
11919 * window.h (check_all_windows): Mark externally visible.
11920
2b96acb7
PE
11921 * window.c (window_deletion_count): Now static.
11922
11923 * undo.c: Make symbols static if they're not exported.
11924 (last_undo_buffer, last_boundary_position, pending_boundary):
11925 Now static.
11926
50436f33
PE
11927 * textprop.c (interval_insert_behind_hooks): Now static.
11928 (interval_insert_in_front_hooks): Likewise.
11929
64520e5c
PE
11930 * term.c: Make symbols static if they're not exported.
11931 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11932 (max_frame_lines, tty_set_terminal_modes):
11933 (tty_reset_terminal_modes, tty_turn_off_highlight):
11934 (get_tty_terminal): Now static.
11935 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11936 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11937 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11938 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11939 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11940
1fa53021
PE
11941 * sysdep.c: Make symbols static if they're not exported.
11942 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11943 Now static.
11944 (sigprocmask_set, full_mask): Remove; unused.
11945 (wait_debugging): Mark as visible.
11946 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11947 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11948
d4b43b22
PE
11949 * syntax.c (syntax_temp): Define only if !__GNUC__.
11950
b7c513d0
PE
11951 * sound.c (current_sound_device, current_sound): Now static.
11952
989b29ad
PE
11953 * search.c (searchbufs, searchbuf_head): Now static.
11954
13a55a78
PE
11955 * scroll.c (scroll_cost): Remove; unused.
11956 * dispextern.h (scroll_cost): Remove decl.
11957
de68a1fc
PE
11958 * region-cache.h (pp_cache): Mark as externally visible.
11959
40ccffa6
PE
11960 * process.c: Make symbols static if they're not exported.
11961 (process_tick, update_tick, create_process, chan_process):
11962 (Vprocess_alist, proc_buffered_char, datagram_access):
11963 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11964 (deactivate_process): Mark defn as static, as well as decl.
11965 * lisp.h (create_process): Remove decl.
11966 * process.h (chan_process, Vprocess_alist): Remove decls.
11967
ad64fc97
PE
11968 * print.c: Make symbols static if they're not exported.
11969 (print_depth, new_backquote_output, being_printed, print_buffer):
11970 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11971 (print_interval, print_number_index, initial_stderr_stream):
11972 Now static.
11973 * lisp.h (Fprinc): Remove decl.
11974 (debug_output_compilation_hack): Mark as externally visible.
11975
adddb265
PE
11976 * sysdep.c (croak): Move decl from here to syssignal.h.
11977 * syssignal.h (croak): Put it here, so the API can be checked when
11978 'croak' is called from dissociate_if_controlling_tty.
11979
1717ede2
PE
11980 * minibuf.c: Make symbols static if they're not exported.
11981 (minibuf_save_list, choose_minibuf_frame): Now static.
11982 * lisp.h (choose_minibuf_frame): Remove decl.
11983
fa5fb2bc
PE
11984 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11985
1e3890d1
PE
11986 * lread.c: Make symbols static if they're not exported.
11987 (read_objects, initial_obarray, oblookup_last_bucket_number):
11988 Now static.
11989 (make_symbol): Remove; unused.
11990 * lisp.h (initial_obarray, make_symbol): Remove decls.
11991
8a1414fa
PE
11992 * keyboard.c: Make symbols static if they're not exported.
11993 (single_kboard, recent_keys_index, total_keys, recent_keys):
11994 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11995 (this_single_command_key_start, echoing, last_auto_save):
11996 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11997 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11998 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11999 (Vlispy_mouse_stem, double_click_count):
12000 Now static.
12001 (force_auto_save_soon): Define only if SIGDANGER.
12002 (ignore_mouse_drag_p): Now static if
12003 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12004 (print_help): Remove; unused.
12005 (stop_character, last_timer_event): Mark as externally visible.
12006 * keyboard.h (ignore_mouse_drag_p): Declare only if
12007 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12008 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12009 * lisp.h (echoing): Remove decl.
12010 (force_auto_save_soon): Declare only if SIGDANGER.
12011 * xdisp.c (redisplay_window): Simplify code, to make it more
12012 obvious that ignore_mouse_drag_p is not accessed if !defined
12013 USE_GTK && !defined HAVE_NS.
12014
93ea6e8f
PE
12015 * intervals.c: Make symbols static if they're not exported.
12016 (merge_properties_sticky, merge_interval_right, delete_interval):
12017 Now static.
12018 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12019
77382fcc
PE
12020 * insdel.c: Make symbols static if they're not exported.
12021 However, leave prepare_to_modify_buffer alone. It's never
12022 called from outside this function, but that appears to be a bug.
12023 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12024 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12025 (adjust_after_replace_noundo): Remove; unused.
12026 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12027 (signal_before_change): Remove decls.
77382fcc 12028
9306c32e
PE
12029 * indent.c (val_compute_motion, val_vmotion): Now static.
12030
cd44d2eb
PE
12031 * image.c: Make symbols static if they're not exported.
12032 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12033 if USE_GTK.
12034 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12035 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12036
ad9a7a06
PE
12037 * fringe.c (standard_bitmaps): Now static.
12038 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12039
81626931
PE
12040 * frame.c: Make symbols static if they're not exported.
12041 (x_report_frame_params, make_terminal_frame): Now static.
12042 (get_frame_param): Now static, unless HAVE_NS.
12043 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12044 (x_get_resource_string): Remove; not used.
12045 * frame.h (make_terminal_frame, x_report_frame_params):
12046 (x_get_resource_string); Remove decls.
12047 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12048 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12049
239f9db9
PE
12050 * font.c, fontset.c: Make symbols static if they're not exported.
12051 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12052 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12053 * font.c (font_close_object): Now static.
12054 * font.h (font_close_object): Remove.
12055 * fontset.c (FONTSET_OBJLIST): Remove.
12056 (free_realized_fontset) #if-0 the body, which does nothing.
12057 (face_suitable_for_char_p): #if-0, as it's never called.
12058 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12059 * xfaces.c (face_at_string_position):
12060 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12061 since 0 is always ASCII.
12062
dfcf3579
PE
12063 * fns.c (weak_hash_tables): Now static.
12064
5045092b
PE
12065 * fileio.c: Make symbols static if they're not exported.
12066 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12067 (Vwrite_region_annotation_buffers): Now static.
12068
57a96f5c
PE
12069 * eval.c: Make symbols static if they're not exported.
12070 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12071 * lisp.h (backtrace_list): Remove decl.
12072
35f08c38
PE
12073 * emacs.c: Make symbols static if they're not exported.
12074 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12075 (fatal_error_code, fatal_error_signal_hook, standard_args):
12076 Now static.
12077 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12078 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12079 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12080 * lisp.h (fatal_error_signal_hook): Remove decl.
12081 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12082
f44bd759
PE
12083 * editfns.c: Move a (normally-unused) function to its only use.
12084 * editfns.c, lisp.h (get_operating_system_release): Remove.
12085 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12086 worth the hassle of breaking this out.
12087
b532497d
PE
12088 * xterm.c: Make symbols static if they're not exported.
12089 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12090 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12091 (x_destroy_window, x_delete_display):
12092 Now static.
12093 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12094 (x_mouse_leave): Remove; unused.
12095 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12096 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12097 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12098 Remove decls.
12099 (x_mouse_leave): Declare only if WINDOWSNT.
12100 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12101 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12102 USE_X_TOOLKIT.
12103
1675728f
PE
12104 * ftxfont.c: Make symbols static if they're not exported.
12105 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12106 HAVE_FREETYPE.
12107 * font.h (ftxfont_driver): Likewise.
12108
e4cebfca
PE
12109 * xfns.c: Make symbols static if they're not exported.
12110 (x_last_font_name, x_display_info_for_name):
12111 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12112 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12113 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12114 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12115 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12116 (last_show_tip_args): Now static.
12117 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12118 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12119 (x_screen_planes): Remove; unused.
12120 * dispextern.h (x_screen_planes): Remove decl.
12121
5bf46f05
PE
12122 * dispnew.c: Make symbols static if they're not exported.
12123 * dispextern.h (redraw_garbaged_frames, scrolling):
12124 (increment_row_positions): Remove.
12125 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12126 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12127 Now static.
12128 (redraw_garbaged_frames): Remove; unused.
12129
435f4c28
PE
12130 * xfaces.c: Make symbols static if they're not exported.
12131 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12132 Remove decls.
12133 * xterm.h (defined_color): Remove decls.
12134 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12135 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12136 (menu_face_changed_default, defined_color, free_realized_face):
12137 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12138 (ascii_face_of_lisp_face): Remove; unused.
12139
8524aef3
PE
12140 * xdisp.c: Make symbols static if they're not exported.
12141 * dispextern.h (scratch_glyph_row, window_box_edges):
12142 (glyph_to_pixel_coords, set_cursor_from_row):
12143 (get_next_display_element, set_iterator_to_next):
12144 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12145 (show_mouse_face): Remove decls
12146 * frame.h (message_buf_print): Likewise.
12147 * lisp.h (pop_message, set_message, check_point_in_composition):
12148 Likewise.
12149 * xterm.h (set_vertical_scroll_bar): Likewise.
12150 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12151 (message_buf_print, scratch_glyph_row, displayed_buffer):
12152 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12153 (get_next_display_element, show_mouse_face, window_box_edges):
12154 (frame_to_window_pixel_xy, check_point_in_composition):
12155 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12156 (glyph_to_pixel_coords): Remove; unused.
12157
16390cd2
PE
12158 * dired.c (file_name_completion): Now static.
12159
12160 * dbusbind.c (xd_in_read_queued_messages): Now static.
12161
a25f4dfa
PE
12162 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12163 * data.c (circular_list_error): Remove.
12164
14a9c8df
PE
12165 * commands.h (last_point_position, last_point_position_buffer):
12166 (last_point_position_window): Remove decls.
12167 * keyboard.c: Make these variables static.
12168
04f2d78b
CB
12169 * coding.h (coding, code_convert_region, encode_coding_gap):
12170 Remove decls.
74ab6df5
PE
12171 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12172 (iso_code_class, detect_coding, code_convert_region): Now static.
12173 (encode_coding_gap): Remove; unused.
12174
38dfbee1
PE
12175 * chartab.c (chartab_chars, chartab_bits): Now static.
12176
a2cb4e63
PE
12177 * charset.h (charset_iso_8859_1): Remove decl.
12178 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12179 Now static.
12180
127198fd
PE
12181 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12182 * ccl.c (Vccl_program_table): Now static.
12183 (check_ccl_update): Remove; unused.
12184
d85b608f
PE
12185 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12186 * category.h: ... from here.
12187 * category.c (check_category_table, set_category_set): Now static.
12188
31cd66f3
PE
12189 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12190 * lisp.h: Remove these decls.
12191
c358e587
PE
12192 * buffer.c (buffer_count): Remove unused var.
12193
e78aecca
PE
12194 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12195 so that it's not optimized away.
12196 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12197 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12198 exported only to the debugger.
12199
e192d7d3 12200 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12201 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12202
92470028
PE
12203 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12204 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12205 was inaccessible from Lisp.
12206 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12207 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12208
244ed907
PE
12209 alloc.c: Import and export fewer symbols, and remove unused items.
12210 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12211 is defined.
12212 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12213 it's not optimized away by whole-program optimization.
12214 (message_enable_multibyte, free_misc): Remove.
12215 (catchlist, handlerlist, mark_backtrace):
12216 Declare only if BYTE_MARK_STACK.
12217 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12218 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12219 (message_enable_multibyte): Remove decl.
12220 (free_misc, interval_free_list, float_block, float_block_index):
12221 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12222 (cons_free_list, last_marked_index):
12223 Now static.
12224 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12225 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12226 (mark_backtrace): Define only if BYTE_MARK_STACK.
12227 * xdisp.c (message_enable_multibyte): Now static.
12228
61c2b50e 12229 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12230 This makes it easier for human readers (and static analyzers)
12231 to see whether these variables are used from other modules.
12232 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12233 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12234 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12235 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12236 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12237 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12238 * xmenu.c, xselect.c:
12239 Declare Q* vars static if they are not used in other modules.
12240 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12241 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12242 Remove decls of unexported vars.
12243 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12244
95c82688
PE
12245 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12246
16a97296
PE
12247 Make Emacs functions such as Fatom 'static' by default.
12248 This makes it easier for human readers (and static analyzers)
12249 to see whether these functions can be called from other modules.
12250 DEFUN now defines a static function. To make the function external
12251 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12252 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12253 (Finit_image_library):
16a97296
PE
12254 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12255 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12256 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12257 Remove decls, since these functions are now static.
12258 (Funintern, Fget_internal_run_time): New decls, since these functions
12259 were already external.
95c82688 12260
16a97296
PE
12261 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12262 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12263 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12264 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12265 * keyboard.c, keymap.c, lread.c:
12266 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12267 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12268 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12269 Mark functions with DEFUE instead of DEFUN,
12270 if they are used in other modules.
12271 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12272 decls for now-static functions.
12273 * buffer.h (Fdelete_overlay): Remove decl.
12274 * callproc.c (Fgetenv_internal): Mark as internal.
12275 * composite.c (Fremove_list_of_text_properties): Remove decl.
12276 (Fcomposition_get_gstring): New forward static decl.
12277 * composite.h (Fcomposite_get_gstring): Remove decl.
12278 * dired.c (Ffile_attributes): New forward static decl.
12279 * doc.c (Fdocumntation_property): New forward static decl.
12280 * eval.c (Ffetch_bytecode): New forward static decl.
12281 (Funintern): Remove extern decl; now in .h file where it belongs.
12282 * fileio.c (Fmake_symbolic_link): New forward static decl.
12283 * image.c (Finit_image_library): New forward static decl.
12284 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12285 * intervals.h (Fprevious_property_change):
12286 (Fremove_list_of_text_properties): Remove decls.
12287 * keyboard.c (Fthis_command_keys): Remove decl.
12288 (Fcommand_execute): New forward static decl.
12289 * keymap.c (Flookup_key): New forward static decl.
12290 (Fcopy_keymap): Now static.
12291 * keymap.h (Flookup_key): Remove decl.
12292 * process.c (Fget_process): New forward static decl.
12293 (Fprocess_datagram_address): Mark as internal.
12294 * syntax.c (Fsyntax_table_p): New forward static decl.
12295 (skip_chars): Remove duplicate decl.
12296 * textprop.c (Fprevious_property_change): New forward static decl.
12297 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12298 Now internal.
12299 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12300 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12301
785bbd42
PE
12302 * editfns.c (Fformat): Remove unreachable code.
12303
8b913b57
AS
123042011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12305
12306 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12307 change. (Bug#8496)
12308
a6744a35
EZ
123092011-04-13 Eli Zaretskii <eliz@gnu.org>
12310
12311 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12312 when at ZV. (Bug#8487)
12313
e7974947
AS
123142011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12315
baad03f0
AS
12316 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12317 (Bug#8437)
12318 * keyboard.c (parse_tool_bar_item): Likewise.
12319 * sound.c (sound_cleanup, alsa_close): Likewise.
12320 * termcap.c (tgetent): Likewise.
12321 * xfns.c (x_default_font_parameter): Likewise.
12322 * xsettings.c (read_and_apply_settings): Likewise.
12323
e7974947
AS
12324 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12325 (overrun_check_free): Protoize.
12326
28272684
PE
123272011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12328
12329 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12330 since callers should never pass a negative size.
12331 Change the signature to match that of plain 'read' and 'write'; see
12332 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12333 * lisp.h: Update prototypes of emacs_write and emacs_read.
12334
11997c76
EZ
123352011-04-11 Eli Zaretskii <eliz@gnu.org>
12336
12337 * xdisp.c (redisplay_window): Don't try to determine the character
12338 position of the scroll margin if the window start point w->startp
e896f03c 12339 is outside the buffer's accessible region. (Bug#8468)
11997c76 12340
8a2cbd72
EZ
123412011-04-10 Eli Zaretskii <eliz@gnu.org>
12342
12343 Fix write-region and its subroutines for buffers > 2GB.
12344 * fileio.c (a_write, e_write): Modify declaration of arguments and
12345 local variables to support buffers larger than 2GB.
12346 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12347
12348 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12349 argument, local variables, and return value.
12350
12351 * lisp.h: Update prototypes of emacs_write and emacs_read.
12352
12353 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12354
4073e537 123552011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12356
1ebfdcb6
PE
12357 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12358
b2ded58d
PE
12359 Fix more problems found by GCC 4.6.0's static checks.
12360
7d66342c
PE
12361 * xdisp.c (vmessage): Use a better test for character truncation.
12362
bbf47d44
PE
12363 * charset.c (load_charset_map): <, not <=, for optimization,
12364 and to avoid potential problems with integer overflow.
9248994d 12365 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12366 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12367 * editfns.c (Fformat): Likewise.
1e69125e 12368 * syntax.c (skip_chars): Likewise.
3befa583 12369
e3019616
PE
12370 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12371 This also lets GCC 4.6.0 generate slightly better loop code.
12372
becfa255
PE
12373 * callint.c (Fcall_interactively): <, not <=, for optimization.
12374 (Fcall_interactively): Count the number of arguments produced,
12375 not the number of arguments given. This is simpler and lets GCC
12376 4.6.0 generate slightly better code.
12377
dae0cd48
PE
12378 * ftfont.c: Distingish more carefully between FcChar8 and char.
12379 The previous code passed unsigned char * to a functions like
12380 strlen and xstrcasecmp that expect char *, which does not
12381 conform to the C standard.
12382 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12383 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12384 char * when the C standard requires it.
12385
76032d70
PE
12386 * keyboard.c (read_char): Remove unused var.
12387
eb3f1cc8
PE
12388 * eval.c: Port to Windows vsnprintf (Bug#8435).
12389 Include <limits.h>.
12390 (SIZE_MAX): Define if the headers do not.
12391 (verror): Do not give up if vsnprintf returns a negative count.
12392 Instead, grow the buffer. This ports to Windows vsnprintf, which
12393 does not conform to C99. Problem reported by Eli Zaretskii.
12394 Also, simplify the allocation scheme, by avoiding the need for
12395 calling realloc, and removing the ALLOCATED variable.
12396
70476b54
PE
12397 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12398
12020a9e
PE
12399 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12400 But keep the doprint source code for now, as we might revamp it
12401 and use it again (Bug#8435).
ea6c7ae6
PE
12402 * lisp.h (doprnt): Remove.
12403 * Makefile.in (base_obj): Remove doprnt.o.
12404 * deps.mk (doprnt.o): Remove.
12405
5fdb398c
PE
12406 error: Print 32- and 64-bit integers portably (Bug#8435).
12407 Without this change, on typical 64-bit hosts error ("...%d...", N)
12408 was used to print both 32- and 64-bit integers N, which relied on
12409 undefined behavior.
61bdb816 12410 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12411 * lisp.h (error, verror): Mark as printf-like functions.
12412 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12413 Report overflow in size calculations when allocating printf buffer.
12414 Do not truncate output string at its first null byte.
12415 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12416 Truncate the output at a character boundary, since vsnprintf does not
12417 do that.
12418 * charset.c (check_iso_charset_parameter): Convert internal
12419 character to string before calling 'error', since %c now has the
12420 printf meaning.
12421 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12422 overflow when computing char to be passed to 'error'. Do not
12423 pass Lisp_Object to 'error'; pass the integer instead.
12424 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12425 formatted with plain %d.
12426
b189fa66
PE
12427 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12428
bff87ef0
PE
12429 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12430
7e2cac20
PE
12431 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12432
ce4d90b5
PE
12433 * xterm.c (x_catch_errors): Remove duplicate declaration.
12434
266c9547
PE
12435 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12436
79c49ad2
PE
12437 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12438
368f4090
JM
124392011-04-10 Jim Meyering <meyering@redhat.com>
12440
12441 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12442 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12443 return ssize_t not "int", and use size_t as the buffer length.
12444 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12445 * gnutls.h: Update declarations.
12446 * process.c (read_process_output): Use ssize_t, to match.
12447 (send_process): Likewise.
12448
a32d4040
CY
124492011-04-09 Chong Yidong <cyd@stupidchicken.com>
12450
12451 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12452
8546720e 124532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12454
04f2d78b
CB
12455 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12456 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12457
8546720e
GM
12458 * xterm.c (handle_one_xevent):
12459 * xmenu.c (create_and_show_popup_menu):
12460 * xselect.c (x_decline_selection_request)
12461 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12462
0a2f5c1a 124632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12464
12465 Fix some uses of `int' instead of EMACS_INT.
12466 * search.c (string_match_1, fast_string_match)
12467 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12468 (scan_buffer, find_next_newline_no_quit)
12469 (find_before_next_newline, search_command, Freplace_match)
12470 (Fmatch_data): Make some `int' variables be EMACS_INT.
12471
12472 * xdisp.c (display_count_lines): 3rd argument and return value now
12473 EMACS_INT. All callers changed.
12474 (pint2hrstr): Last argument is now EMACS_INT.
12475
12476 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12477 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12478 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12479 (decode_coding_utf_16, decode_coding_emacs_mule)
12480 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12481 (decode_coding_ccl, decode_coding_charset)
12482 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12483 (decode_coding_iso_2022, decode_coding_emacs_mule)
12484 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12485 <char_offset, last_offset>: Declare EMACS_INT.
12486 (encode_coding_utf_8, encode_coding_utf_16)
12487 (encode_coding_emacs_mule, encode_invocation_designation)
12488 (encode_designation_at_bol, encode_coding_iso_2022)
12489 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12490 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12491 Declare EMACS_INT.
12492 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12493 (encode_invocation_designation): Last argument P_NCHARS is now
12494 EMACS_INT.
12495 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12496 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12497
12498 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12499 All users changed.
12500
12501 * ccl.c (Fccl_execute_on_string): Declare some variables
12502 EMACS_INT.
12503
8546720e 125042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12505
12506 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12507
4e19a977
CS
125082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12509
12510 * process.c (Fformat_network_address): Doc fix.
12511
87302331
R
125122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12513
ee7683eb 12514 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12515
cbb59342
CY
125162011-04-08 Chong Yidong <cyd@stupidchicken.com>
12517
12518 * keyboard.c (read_char): Call Lisp function help-form-show,
12519 instead of using internal_with_output_to_temp_buffer.
12520 (Qhelp_form_show): New var.
e0d38eeb 12521 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12522
12523 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12524
12525 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12526
e67a13ab
CY
125272011-04-06 Chong Yidong <cyd@stupidchicken.com>
12528
04f2d78b
CB
12529 * process.c (Flist_processes): Remove to Lisp.
12530 (list_processes_1): Delete.
e67a13ab 12531
973f782d
EZ
125322011-04-06 Eli Zaretskii <eliz@gnu.org>
12533
7c106b1e
EZ
12534 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12535
973f782d
EZ
12536 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12537
41cf7d1a 125382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12539
ca23cc88
PE
12540 Fix more problems found by GCC 4.6.0's static checks.
12541
f390e2d5
PE
12542 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12543
42eea0d0
PE
12544 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12545
b69769da 12546 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12547
f9541e84
PE
12548 * xdisp.c (vmessage): Mark as a printf-like function.
12549
13841b55
PE
12550 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12551
c136c10f
PE
12552 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12553
5e2d4a30
PE
12554 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12555 printf-like functions.
12556 (tiff_load): Add casts to remove these marks before passing them
12557 to system-supplied API.
12558
583f48b9
PE
12559 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12560
b25d760e
PE
12561 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12562 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12563 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12564 directly, rather than having caller test rule sign. This avoids
12565 some unnecessary tests.
12566 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12567 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12568 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12569
bc7b6697 12570 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12571 (xfont_open): Avoid unnecessary tests.
bc7b6697 12572
27ccc379
PE
12573 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12574
dcd5c89a
PE
12575 * composite.h, composite.c (composition_gstring_put_cache):
12576 Use EMACS_INT, not int, for length.
12577
b13a45c6
PE
12578 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12579 breaking out part of COMPOSITION_DECODE_RULE.
12580 (COMPOSITION_DECODE_RULE): Use it.
12581 * composite.c (get_composition_id): Remove unused local vars,
12582 by using the new macro.
12583
1e792e4d
PE
12584 * textprop.c (set_text_properties_1): Change while to do-while,
12585 since the condition is always true at first.
12586
dc6c6455 12587 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12588 (interval_deletion_adjustment): Return unsigned value.
12589 All uses changed.
dc6c6455 12590
aba7731a
PE
12591 * process.c (list_processes_1, create_pty, read_process_output):
12592 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12593 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12594 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12595 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12596 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12597
fdfc4bf3
PE
12598 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12599
fca8fe46 12600 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12601 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12602
06a0259a 12603 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12604 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12605 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12606
e7b9e80f
PE
12607 * print.c (print_error_message): Avoid int overflow.
12608
56201685
PE
12609 * font.c (font_list_entities): Redo for clarity,
12610 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12611
78834453 12612 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12613 (font_score): Avoid potential overflow in diff calculation.
78834453 12614
0bc0b309 12615 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12616 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12617
e610eaca
PE
12618 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12619
b895abce
PE
12620 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12621 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12622 can always succeed if overflow has undefined behavior.
12623
1f1d9321 12624 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12625 (wordify): Omit three unnecessary tests.
1f1d9321 12626
c59478bc
PE
12627 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12628 All callers changed. This avoids the need for an unused var.
12629
79b73827
PE
12630 * casefiddle.c (casify_region): Remove var that is set but not used.
12631
a4db5dfe
PE
12632 * dired.c (file_name_completion): Remove var that is set but not used.
12633
43aae36e
PE
12634 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12635
2a47c44d 12636 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12637 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12638
a37c69bf
PE
12639 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12640 Check for integer overflow on size calculations.
12641
328ab8e7
PE
12642 * buffer.c (Fprevious_overlay_change): Remove var that is set
12643 but not used.
12644
e5a2a5cb
PE
12645 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12646 Remove vars that are set but not used.
8d84a6eb 12647 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12648 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12649
a60e5f68
PE
12650 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12651
f661cb61 12652 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12653 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12654
f0397f5a
PE
12655 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12656 that are set but not used.
12657
8664db06 12658 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12659 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12660
6abdaa4a
PE
12661 * xselect.c (x_get_local_selection, x_handle_property_notify):
12662 Remove vars that are set but not used.
12663
0ce7538d 12664 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12665 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12666
9ae848fc
PE
12667 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12668 Remove var that is set but not used.
0b918413
PE
12669 (scroll_bar_windows_size): Now size_t, not int.
12670 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12671 Check for overflow.
9ae848fc 12672
a5a62657
PE
12673 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12674 (map_tty_color) [!defined MSDOS]: Likewise.
12675
5c5cdd39
PE
12676 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12677
66ebf983
PE
12678 * coding.c: Remove vars that are set but not used.
12679 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12680 All callers changed.
12681 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12682 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12683 (decode_coding_charset): Remove vars that are set but not used.
12684
1be4d761
PE
12685 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12686 that is set but not used.
12687
47553fa8
PE
12688 * print.c (print_object): Remove var that is set but not used.
12689
1f7196bf 12690 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12691 The gnulib version avoids calling malloc in the usual case,
12692 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12693 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12694 * filelock.c (current_lock_owner): Likewise.
12695 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12696 * sysdep.c: Include allocator.h, careadlinkat.h.
12697 (emacs_no_realloc_allocator): New static constant.
12698 (emacs_readlink): New function.
fdb61804
PE
12699 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12700 ../lib/careadlinkat.h.
d1fdcab7 12701
f84c17c7
SM
127022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12703
12704 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12705 first non-nil return value).
12706
ef3862ad
JD
127072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12708
12709 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12710 if not defined (Bug#8403).
12711
376a7006
JB
127122011-04-02 Juanma Barranquero <lekktu@gmail.com>
12713
12714 * xdisp.c (display_count_lines): Remove parameter `start',
12715 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12716 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12717 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12718 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12719 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12720 and thereabouts. All callers changed.
12721 (get_per_char_metric): Remove parameter `f', unused since
12722 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12723
6ca3801d
JM
127242011-04-02 Jim Meyering <meyering@redhat.com>
12725
12726 do not dereference NULL upon failed strdup
12727 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12728 (ns_get_family): Likewise.
12729
d8e2b5ba
JB
127302011-04-02 Juanma Barranquero <lekktu@gmail.com>
12731
12732 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12733
8c74fcbd
JD
127342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12735
12736 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12737 later (Bug#8403).
12738
7200d79c
SM
127392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12740
03408648 12741 Add lexical binding.
7200d79c 12742
03408648
SM
12743 * window.c (Ftemp_output_buffer_show): New fun.
12744 (Fsave_window_excursion):
12745 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12746
12747 * lread.c (lisp_file_lexically_bound_p): New function.
12748 (Fload): Bind Qlexical_binding.
12749 (readevalloop): Remove `evalfun' arg.
12750 Bind Qinternal_interpreter_environment.
12751 (Feval_buffer): Bind Qlexical_binding.
12752 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12753 Mark as dynamic.
12754 (syms_of_lread): Declare `lexical-binding'.
12755
12756 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12757
12758 * keyboard.c (eval_dyn): New fun.
12759 (menu_item_eval_property): Use it.
ca105506
SM
12760
12761 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12762
03408648
SM
12763 * fns.c (concat, mapcar1): Accept byte-code-functions.
12764
12765 * eval.c (Fsetq): Handle lexical vars.
12766 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12767 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12768 (FletX, Flet): Obey lexical binding.
12769 (Fcommandp): Handle closures.
12770 (Feval): New `lexical' arg.
12771 (eval_sub): New function extracted from Feval. Use it almost
12772 everywhere where Feval was used. Look up vars in lexical env.
12773 Handle closures.
12774 (Ffunctionp): Move from subr.el.
12775 (Ffuncall): Handle closures.
12776 (apply_lambda): Remove `eval_flags'.
12777 (funcall_lambda): Handle closures and new byte-code-functions.
12778 (Fspecial_variable_p): New function.
12779 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12780 but without exporting it to Lisp.
23aba0ea 12781
23aba0ea 12782 * doc.c (Fdocumentation, store_function_docstring):
03408648 12783 * data.c (Finteractive_form): Handle closures.
23aba0ea 12784
03408648
SM
12785 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12786 interactive spec.
ba83908c 12787
04f2d78b
CB
12788 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12789 New byte-codes.
03408648
SM
12790 (exec_byte_code): New function extracted from Fbyte_code to handle new
12791 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12792
03408648 12793 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12794
03408648 12795 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12796
e2abce01
JB
127972011-03-31 Juanma Barranquero <lekktu@gmail.com>
12798
12799 * xdisp.c (redisplay_internal): Fix prototype.
12800
63696a73 128012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12802
63696a73 12803 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12804 (try_scrolling): Use it when setting scroll_limit.
12805 Limit scrolling to 100 screen lines.
63696a73
EZ
12806 (redisplay_window): Even when falling back on "recentering",
12807 position point in the window according to scroll-conservatively,
12808 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12809
12810 (try_scrolling): When point is above the window, allow searching
12811 as far as scroll_max, or one screenful, to compute vertical
12812 distance from PT to the scroll margin position. This prevents
12813 try_scrolling from unnecessarily failing when
12814 scroll-conservatively is set to a value slightly larger than the
12815 window height. Clean up the case of PT below the margin at bottom
12816 of window: scroll_max can no longer be INT_MAX. When aggressive
12817 scrolling is in use, don't let point enter the opposite scroll
12818 margin as result of the scroll.
12819 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12820 threshold of 100 lines for never-recentering scrolling.
12821
e4cc2dfc
JB
128222011-03-31 Juanma Barranquero <lekktu@gmail.com>
12823
12824 * dispextern.h (move_it_by_lines):
12825 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12826 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12827 (message_log_check_duplicate): Remove parameters `prev_bol' and
12828 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12829 (redisplay_internal): Remove parameter `preserve_echo_area',
12830 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12831
12832 * indent.c (Fvertical_motion):
12833 * window.c (window_scroll_pixel_based, Frecenter):
12834 Don't pass `need_y_p' to `move_it_by_lines'.
12835
1c470562
SM
128362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12837
44f230aa
SM
12838 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12839 steal a few bits to be more compact.
12840 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12841 Remove unneeded casts.
12842
1c470562
SM
12843 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12844
888adce9
ZK
128452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12846
12847 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12848 binding" message (bug#7967).
12849
f838ed7b
PE
128502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12851
77861b95
PE
12852 Fix more problems found by GCC 4.6.0's static checks.
12853
de6dbc14
PE
12854 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12855 Remove unused local var.
12856
f838ed7b
PE
12857 * editfns.c (Fmessage_box): Remove unused local var.
12858
792c7b2b
PE
12859 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12860 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12861 Omit unused local vars.
c499e557 12862 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12863 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12864 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12865 Omit unused local var.
12866
ba0165e1
PE
12867 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12868 Don't assume string length fits in int.
32ad8845 12869 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12870 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12871
3c59b4c9
PE
12872 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12873 instead of alloca (Bug#8344).
12874
a3eed478 12875 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12876 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12877
eb4d412d
PE
12878 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12879
1658b401
PE
12880 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12881 concerns.
12882
12883 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12884
12885 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12886
9a2c6e05
PE
12887 * keyboard.c (syms_of_keyboard): Use the same style as later
12888 in this function when indexing through an array. This also
12889 works around GCC bug 48267.
12890
03d0a109
PE
12891 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12892
44f730c8
PE
12893 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12894
fe75f926
PE
12895 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12896 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12897
ffa8c828
PE
12898 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12899 This avoids undefined behavior on integer overflow, and is a bit
12900 more convenient anyway since it is compared to a size_t variable.
12901
c5101a77
PE
12902 Variadic C functions now count arguments with size_t, not int.
12903 This avoids an unnecessary limitation on 64-bit machines, which
12904 caused (substring ...) to crash on large vectors (Bug#8344).
12905 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12906 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12907 All variadic functions and their callers changed accordingly.
c5101a77
PE
12908 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12909 * data.c (arith_driver, float_arith_driver): Likewise.
12910 * editfns.c (general_insert_function): Likewise.
12911 * eval.c (struct backtrace.nargs, interactive_p)
12912 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12913 (funcall_lambda, mark_backtrace): Likewise.
12914 * fns.c (concat): Likewise.
12915 * frame.c (x_set_frame_parameters): Likewise.
12916 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12917 0 if not found, not -1. All callers changed.
12918
dd3f25f7
PE
12919 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12920 (stack_copy_size): Now size_t, not int.
12921 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12922
461c2ab9
JB
129232011-03-28 Juanma Barranquero <lekktu@gmail.com>
12924
12925 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12926 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12927 All callers changed.
12928
12929 * lisp.h (multibyte_char_to_unibyte):
12930 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12931 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12932 * character.h (CHAR_TO_BYTE8):
12933 * cmds.c (internal_self_insert):
12934 * editfns.c (general_insert_function):
12935 * keymap.c (push_key_description):
12936 * search.c (Freplace_match):
12937 * xdisp.c (message_dolog, set_message_1): All callers changed.
12938
f6d62986
SM
129392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12940
12941 * keyboard.c (safe_run_hook_funcall): New function.
12942 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12943 don't set the hook to nil, but remove the offending function instead.
12944 (Qcommand_hook_internal): Remove, unused.
12945 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12946 Vcommand_hook_internal.
12947
12948 * eval.c (enum run_hooks_condition): Remove.
12949 (funcall_nil, funcall_not): New functions.
12950 (run_hook_with_args): Call each function through a `funcall' argument.
12951 Remove `cond' argument, now redundant.
12952 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12953 (Frun_hook_with_args_until_failure): Adjust accordingly.
12954 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12955
1db5b1ad
JB
129562011-03-28 Juanma Barranquero <lekktu@gmail.com>
12957
12958 * dispextern.h (string_buffer_position): Remove declaration.
12959
12960 * print.c (strout): Remove parameter `multibyte', unused since
12961 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12962
12963 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12964 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12965 All callers changed.
12966
12967 * w32.c (_wsa_errlist): Use braces for struct initializers.
12968
12969 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12970 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12971 All callers changed.
12972 (string_buffer_position): Likewise. Also, make static (it's never
12973 used outside xdisp.c).
12974 (cursor_row_p): Remove parameter `w', unused since
12975 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12976 (decode_mode_spec): Remove parameter `precision', introduced during
12977 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12978 All callers changed.
12979
5ffb62aa
JD
129802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12981
12982 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12983
461c2ab9 129842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12985
12986 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12987 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12988 (ns_update_auto_hide_menu_bar): New functions.
12989 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12990 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12991 ns_constrain_all_frames.
12992 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12993 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12994
5c380ffb
JD
129952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12996
12997 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12998
9af30bdf
GM
129992011-03-27 Glenn Morris <rgm@gnu.org>
13000
13001 * syssignal.h: Replace RETSIGTYPE with void.
13002 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13003 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13004 Replace SIGTYPE with void everywhere.
13005 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13006 * s/template.h (SIGTYPE): Remove commented out definition.
13007
e2abce01
JB
130082011-03-26 Eli Zaretskii <eliz@gnu.org>
13009
13010 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13011 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13012
f868cd8a
JB
130132011-03-26 Juanma Barranquero <lekktu@gmail.com>
13014
59eb0929
JB
13015 * w32.c (read_unc_volume): Use parameter `henum', instead of
13016 global variable `wget_enum_handle'.
13017
13018 * keymap.c (describe_vector): Remove parameters `indices' and
13019 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13020 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13021
f868cd8a
JB
13022 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13023
13024 * keyboard.c (timer_check): Remove parameter `do_it_now',
13025 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13026 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13027 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13028
13029 * keyboard.c (read_char):
13030 * w32menu.c (w32_menu_display_help):
13031 * xmenu.c (show_help_event, menu_help_callback):
13032 Adjust calls to `show_help_echo'.
13033
13034 * gtkutil.c (xg_maybe_add_timer):
13035 * keyboard.c (readable_events):
13036 * process.c (wait_reading_process_output):
13037 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13038
13039 * insdel.c (adjust_markers_gap_motion):
13040 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13041 (gap_left, gap_right): Don't call it.
13042
2ecf6fdb
CY
130432011-03-25 Chong Yidong <cyd@stupidchicken.com>
13044
13045 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13046 incurred during fontification.
13047
6b1f9ba4
JB
130482011-03-25 Juanma Barranquero <lekktu@gmail.com>
13049
13050 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13051 (DEFVAR_PER_BUFFER): Don't pass it.
13052
13053 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13054 (scrolling_window): Don't pass it.
13055
0f4a96b5
JB
130562011-03-25 Juanma Barranquero <lekktu@gmail.com>
13057
13058 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13059
13060 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13061 and `suffix'.
13062 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13063 of variables specific to SELinux and computation of `encoded_absname'.
13064
13065 * image.c (XPutPixel): Remove unused variable `height'.
13066
13067 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13068
13069 * unexw32.c (get_section_info): Remove unused variable `section'.
13070
13071 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13072 (system_process_attributes): Remove unused variable `sess'.
13073 (sys_read): Remove unused variable `err'.
13074
13075 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13076 (w32_wnd_proc): Remove unused variable `isdead'.
13077 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13078 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13079 (x_create_tip_frame): Remove unused variable `tem'.
13080
13081 * w32inevt.c (w32_console_read_socket):
13082 Remove unused variable `no_events'.
13083
13084 * w32term.c (x_draw_composite_glyph_string_foreground):
13085 Remove unused variable `width'.
13086
1149507c
JB
130872011-03-24 Juanma Barranquero <lekktu@gmail.com>
13088
13089 * w32term.c (x_set_glyph_string_clipping):
13090 Don't pass uninitialized region to CombineRgn.
13091
9c88f339
JB
130922011-03-23 Juanma Barranquero <lekktu@gmail.com>
13093
13094 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13095 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13096 (Fx_close_connection): Remove unused variable `i'.
13097
13098 * w32font.c (w32font_draw): Return number of glyphs.
13099 (w32font_open_internal): Remove unused variable `i'.
13100 (w32font_driver): Add missing initializer.
13101
13102 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13103 (fill_in_menu): Remove unused variable `items_added'.
13104
13105 * w32term.c (last_mouse_press_frame): Remove static global variable.
13106 (w32_clip_to_row): Remove unused variable `f'.
13107 (x_delete_terminal): Remove unused variable `i'.
13108
13109 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13110 (NOTHING): Remove unused static global variable.
13111 (uniscribe_check_otf): Remove unused variable `table'.
13112 (uniscribe_font_driver): Add missing initializers.
13113
dee091a3
JD
131142011-03-23 Julien Danjou <julien@danjou.info>
13115
13116 * term.c (Fsuspend_tty, Fresume_tty):
13117 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13118 * window.c (temp_output_buffer_show):
13119 * insdel.c (signal_before_change):
13120 * frame.c (Fhandle_switch_frame):
13121 * fileio.c (Fdo_auto_save):
13122 * emacs.c (Fkill_emacs):
13123 * editfns.c (save_excursion_restore):
13124 * cmds.c (internal_self_insert):
13125 * callint.c (Fcall_interactively):
13126 * buffer.c (Fkill_all_local_variables):
13127 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13128 Use Frun_hooks.
0f4a96b5 13129 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13130 unconditionally since it does the check itself.
dee091a3 13131
2c520ab5 131322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13133
c9c49752
PE
13134 Fix more problems found by GCC 4.5.2's static checks.
13135
8abc3f12
PE
13136 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13137 the first time through the loop, since we know p0 < p1 then.
13138 This also avoids a gcc -Wstrict-overflow warning.
13139
a2d26660
PE
13140 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13141 leading to a memory leak, possible in functions like
13142 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13143 of objects (Bug#8318).
a2d26660 13144
916c72e9
PE
13145 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13146 that could (at least in theory) be that large.
13147
19ab8a18
PE
13148 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13149 This is less likely to overflow, and avoids undefined behavior if
13150 overflow does occur. All callers changed. Use strtoul to scan
13151 for the unsigned long integer.
b7cbbd6f
PE
13152 (pint2hrstr): Simplify and tune code slightly.
13153 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13154
f0641eff
PE
13155 * scroll.c (do_scrolling): Work around GCC bug 48228.
13156 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13157
7f650bb9
PE
13158 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13159 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13160 (validate_x_resource_name): Simplify count usage.
13161 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13162
37dd57d1
PE
13163 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13164 fail (Bug#8306).
81e56e61 13165
699979fc 13166 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13167
401bf9b4
PE
13168 * process.c (Fmake_network_process): Use socklen_t, not int,
13169 where POSIX says socklen_t is required in portable programs.
13170 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13171 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13172 (Fmake_network_process, server_accept_connection):
13173 (wait_reading_process_output, read_process_output):
13174 Likewise.
13175
b93aacde
PE
13176 * process.c: Rename or move locals to avoid shadowing.
13177 (list_processes_1, Fmake_network_process):
13178 (read_process_output_error_handler, exec_sentinel_error_handler):
13179 Rename or move locals.
4dc343ee 13180 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13181 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13182 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13183 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13184 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13185
af8a867c 13186 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13187 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13188 Include tparam.h instead, since it declares them.
af8a867c
PE
13189 * cm.h (PC): Remove extern decl; tparam.h now does this.
13190 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13191 * terminfo.c: Include tparam.h, to check interfaces.
13192 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13193 (tparam): Adjust signature to match interface in tparam.h;
13194 this removes some undefined behavior. Check that outstring and len
13195 are zero, which they always are with Emacs.
13196 * tparam.h (PC, BC, UP): New extern decls.
13197
0248044d 13198 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13199 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13200
8ff096c1 13201 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13202 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13203 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13204 (ftfont_list): Remove unused local.
49eaafba
PE
13205 (get_adstyle_property, ftfont_pattern_entity):
13206 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13207 Rename locals to avoid shadowing.
8ff096c1 13208
e2be39f6
PE
13209 * xfont.c (xfont_list_family): Mark var as initialized.
13210
c9735e30
PE
13211 * xml.c (make_dom): Now static.
13212
8f5201ae
PE
13213 * composite.c (composition_compute_stop_pos): Rename local to
13214 avoid shadowing.
b246f932
PE
13215 (composition_reseat_it): Remove unused locals.
13216 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13217 (composition_update_it): Mark var as initialized.
11b61122
PE
13218 (find_automatic_composition): Mark vars as initialized,
13219 with a FIXME (Bug#8290).
8f5201ae 13220
760fbc2c
PE
13221 character.h: Rename locals to avoid shadowing.
13222 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13223 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13224 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13225 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13226 to avoid shadowing.
13227
ff08eb85
PE
13228 * textprop.c (property_change_between_p): Remove; unused.
13229
fc7bf025
PE
13230 * intervals.c (interval_start_pos): Now static.
13231
235d7abc
PE
13232 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13233
44f230aa
SM
13234 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13235 Rename locals to avoid shadowing.
3e7d6594 13236
50060332
PE
13237 * sound.c (wav_play, au_play, Fplay_sound_internal):
13238 Fix pointer signedness.
d01f234b 13239 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13240 (wav_play): Initialize a variable to 0, to prevent undefined
13241 behavior (Bug#8278).
50060332 13242
c4fc4e30
PE
13243 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13244
918436ed
PE
13245 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13246
c939f91b
PE
13247 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13248 clobbering (Bug#8298).
b9c7f648
PE
13249 * sysdep.c (sys_subshell): Likewise.
13250 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13251
6bd8c144
PE
13252 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13253 This should get cleaned up, so that child_setup has the
13254 same signature on all platforms.
13255
7710357c 13256 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13257 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13258
c59da222
CY
132592011-03-22 Chong Yidong <cyd@stupidchicken.com>
13260
13261 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13262 not to be necessary, and produces flickering.
13263
66b87493
GM
132642011-03-20 Glenn Morris <rgm@gnu.org>
13265
13266 * config.in: Remove file.
13267
45b6f6d5
JB
132682011-03-20 Juanma Barranquero <lekktu@gmail.com>
13269
13270 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13271 are now in src/globals.h.
13272 (syms_of_minibuf): Remove spurious & from previous change.
13273
cd394be1 132742011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13275
13276 * minibuf.c (completing-read-function): New variable.
13277 (completing-read-default): Rename from completing-read.
13278 (completing-read): Call completing-read-function.
13279
b14e3e21
CY
132802011-03-19 Juanma Barranquero <lekktu@gmail.com>
13281
13282 * xfaces.c (Fx_load_color_file):
13283 Read color file from absolute filename (bug#8250).
13284
f2b726e6
JB
132852011-03-19 Juanma Barranquero <lekktu@gmail.com>
13286
13287 * makefile.w32-in: Update dependencies.
13288
09f6ff02
EZ
132892011-03-17 Eli Zaretskii <eliz@gnu.org>
13290
13291 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13292
29a6015a
PE
132932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13294
a3a6c54e
PE
13295 Fix more problems found by GCC 4.5.2's static checks.
13296
b766f867
PE
13297 * process.c (make_serial_process_unwind, send_process_trap):
13298 (sigchld_handler): Now static.
13299
be02381c
PE
13300 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13301 That way, the code declares only the vars that it needs.
13302 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13303 * s/cygwin.h (PTY_ITERATION): Likewise.
13304 * s/darwin.h (PTY_ITERATION): Likewise.
13305 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13306
57048744
PE
13307 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13308 * process.c (allocate_pty): Don't declare stb unless it's needed.
13309
7914961c 13310 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13311 (CONSTANTLIM): Remove; unused.
13312 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13313 Define only if needed.
7914961c 13314
b3967b18
PE
13315 * unexelf.c (unexec): Name an expression,
13316 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13317 Use a different way to cause a compilation error if anyone uses
13318 n rather than nn, a way that does not involve shadowing.
73366a00 13319 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13320
29a6015a
PE
13321 * deps.mk (unexalpha.o): Remove; unused.
13322
43cfc33e 13323 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13324 * unexec.h: New file.
ce701a33
PE
13325 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13326 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13327 Depend on unexec.h.
13328 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13329 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13330 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13331 Change as necessary to match prototype in unexec.h.
ce701a33 13332
01f44d5a
PE
13333 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13334 shadowing.
4f63c6bb 13335 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13336
a6670b0b
PE
13337 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13338 Rename locals to avoid shadowing.
13339
cef2010d 13340 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13341 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13342
d4d7173a
PE
13343 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13344
f08b802a
PE
13345 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13346 warning when compiling print.c.
13347
3ddb0639
PE
13348 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13349 instead of using an uninitialized var.
5ad03b97 13350 (font_sort_entities): Mark var as initialized.
3ddb0639 13351
170a2692
PE
13352 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13353
e663c700
PE
13354 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13355 pointers to constants.
89bc529a 13356 (font_parse_fcname): Remove unused vars.
7b81e2d0 13357 (font_delete_unmatched): Now static.
ea838e10 13358 (font_get_spec): Remove; unused.
13a547c6
PE
13359 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13360 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13361 Rename or move locals to avoid shadowing.
e663c700 13362
2a80c887 13363 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13364 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13365
1384fa33 13366 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13367 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13368
8b2c52e9
PE
13369 * alloc.c (mark_backtrace): Move decl from here ...
13370 * lisp.h: ... to here, so that it can be checked.
13371
475545b5 13372 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13373 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13374 (lisp_indirect_variable): Name an expression,
13375 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13376 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13377
b1349114 13378 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13379 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13380 Use const pointer when appropriate.
b1349114 13381
a2928364
PE
13382 * lisp.h (get_system_name, get_operating_system_release):
13383 Move decls here, to check interfaces.
13384 * process.c (get_operating_system_release): Move decl to lisp.h.
13385 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13386 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13387 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13388 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13389 (Fformat_time_string, Fencode_time, Finsert_char):
13390 (Ftranslate_region_internal, Fformat):
13391 Rename or remove local vars to avoid shadowing.
9710023e 13392 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13393
a415e694
PE
13394 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13395 avoid shadowing.
13396
8ef4622d
PE
13397 * lisp.h (eassert): Check that the argument compiles, even if
13398 ENABLE_CHECKING is not defined.
13399
946f9a5b
PE
13400 * data.c (Findirect_variable): Name an expression, to avoid
13401 gcc -Wbad-function-cast warning.
112396d6 13402 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13403 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13404 (Fmake_variable_buffer_local, Fmake_local_variable):
13405 Mark variables as initialized.
52746918 13406 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13407
e5aab7e7 13408 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13409 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13410 Rename locals to avoid shadowing.
dff45157
PE
13411 (mark_stack): Move local variables into the #ifdef region where
13412 they're used.
7bc26fdb
PE
13413 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13414 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13415 needed otherwise.
13416 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13417 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13418 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13419
e5aab7e7
PE
13420 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13421 avoids undefined behavior in theory.
13422
4da60324
PE
13423 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13424
88043301
PE
13425 Use functions, not macros, for up- and down-casing (Bug#8254).
13426 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13427 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13428 to use the following functions instead of these macros.
13429 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13430 EMACS_INT, since callers assume the returned value fits in int.
13431 (upcase1): Likewise, for UPCASE_TABLE.
13432 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13433 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13434 the race-condition problem in the old DOWNCASE.
88043301 13435
19ed5445
PE
13436 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13437 Rename locals to avoid shadowing.
13438 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13439 (regex_compile, re_search_2, re_match_2_internal):
13440 Remove unused local vars.
952db0d7
PE
13441 (FREE_VAR): Rewrite so as not to use empty "else",
13442 which gcc can warn about.
da053e48 13443 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13444 (RETALLOC_IF): Define only if needed.
13445 (WORDCHAR_P): Likewise. This one is never needed, but is used
13446 only in a comment talking about a compiler bug, so put inside
13447 the #if 0 of that comment.
13448 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13449 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13450 Remove; unused.
19ed5445 13451
1f3561e4 13452 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13453 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13454 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13455
ded6f8f7
PE
13456 * search.c (simple_search): Remove unused var.
13457
dbd37a95
PE
13458 * dired.c (compile_pattern): Move decl from here ...
13459 * lisp.h: ... to here, so that it can be checked.
13460 (struct re_registers): New forward decl.
13461
7e47afad
PE
13462 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13463
85f24f61
PE
13464 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13465 All uses changed.
13466 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13467 Rename locals to avoid shadowing.
5671df8f 13468 (Fvertical_motion): Mark locals as initialized.
85f24f61 13469
181aa2be 13470 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13471 (casify_region): Mark local as initialized.
181aa2be 13472
930d429c
PE
13473 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13474
7082eac6
PE
13475 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13476 New macros, so that the caller can use some names other than
13477 gcpro1, gcpro2, etc.
13478 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13479 of the new macros.
13480 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13481 argument, for consistency with GCPRO2_VAR, etc: it is now the
13482 prefix of the variable, not the variable itself. All uses
13483 changed.
38b2c076
PE
13484 * dired.c (directory_files_internal, file_name_completion):
13485 Rename locals to avoid shadowing.
13486
15206ed9
PE
13487 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13488 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13489 dired.c's scmp function, had undefined behavior.
13490 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13491 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13492 * buffer.h: ... to here, because these macros use current_buffer,
13493 and the new implementation with inline functions needs to have
13494 current_buffer in scope now, rather than later when the macros
13495 are used.
13496 (downcase, upcase1): New static inline functions.
13497 (DOWNCASE, UPCASE1): Reimplement using these functions.
13498 This avoids undefined behavior in expressions like
13499 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13500 from race conditions in accessing the global variables
13501 case_temp1 and case_temp2.
13502 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13503 * lisp.h (case_temp1, case_temp2): Remove their decls.
13504 * character.h (ASCII_CHAR_P): Move from here ...
13505 * lisp.h: ... to here, so that the inline functions mentioned
13506 above can use them.
13507
4a6bea26
PE
13508 * dired.c (directory_files_internal_unwind): Now static.
13509
f14b7e14
PE
13510 * fileio.c (file_name_as_directory, directory_file_name):
13511 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13512 Now static.
2893f146
PE
13513 (file_name_as_directory): Use const pointers when appropriate.
13514 (Fexpand_file_name): Likewise. In particular, newdir might
13515 point at constant storage, so make it a const pointer.
fd4ead52 13516 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13517 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13518 signedness issues.
f839df0c
PE
13519 (Fset_file_times, Finsert_file_contents, auto_save_error):
13520 Rename locals to avoid shadowing.
f14b7e14 13521
5716756e 13522 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13523 (Ftry_completion, Fall_completions): Rename or remove locals
13524 to avoid shadowing.
5716756e 13525
b4c3046a
PE
13526 * marker.c (bytepos_to_charpos): Remove; unused.
13527
b45db522
PE
13528 * lisp.h (verify_bytepos, count_markers): New decls,
13529 so that gcc does not warn that these functions aren't declared.
13530
85876d07
PE
13531 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13532 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13533 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13534 (copy_text): Remove unused local var.
85876d07 13535
03d78a21 13536 * filelock.c (within_one_second): Now static.
b3dd38ab 13537 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13538
5df8f01b
PE
13539 * buffer.c (fix_overlays_before): Mark locals as initialized.
13540 (fix_start_end_in_overlays): Likewise. This function should be
13541 simplified by using pointers-to-pointers, but that's a different
13542 matter.
b1d876f1 13543 (switch_to_buffer_1): Now static.
8f54f30a
PE
13544 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13545 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13546
a70072c9 13547 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13548 Fix pointer signedness issue.
edced198
PE
13549 (sys_subshell): Mark local as volatile if checking for lint,
13550 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13551 (MAXPATHLEN): Define only if needed.
a70072c9 13552
a0977c44
PE
13553 * process.c (serial_open, serial_configure): Move decls from here ...
13554 * systty.h: ... to here, so that they can be checked.
13555
a884fdcc
PE
13556 * fns.c (get_random, seed_random): Move extern decls from here ...
13557 * lisp.h: ... to here, so that they can be checked.
13558
604efe86 13559 * sysdep.c (reset_io): Now static.
b8950c94 13560 (wait_for_termination_signal): Remove; unused.
604efe86 13561
38fc62d9
PE
13562 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13563 (copy_keymap_item, append_key, push_text_char_description):
13564 Now static.
1004a21a 13565 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13566 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13567 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13568 (describe_map_tree):
13569 Rename locals to avoid shadowing.
38fc62d9 13570
2f2650da
PE
13571 * keyboard.c: Declare functions static if they are not used elsewhere.
13572 (echo_char, echo_dash, cmd_error, top_level_2):
13573 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13574 (read_char, kbd_buffer_get_event, make_lispy_position):
13575 (make_lispy_event, make_lispy_movement, apply_modifiers):
13576 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13577 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13578 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13579 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13580 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13581
a053e86c 13582 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13583 (mark_kboards): Move decl here ...
13584 * alloc.c (mark_kboards): ... from here.
a053e86c 13585
4752793e
PE
13586 * lisp.h (force_auto_save_soon): New decl.
13587
74f10ca7 13588 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13589 (DEFINE_DUMMY_FUNCTION): New macro.
13590 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13591 Use it.
c03cd23f
PE
13592 (main): Add casts to avoid warnings
13593 if GCC considers string literals to be constants.
74f10ca7 13594
022e70d4
PE
13595 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13596
59d6fe83
PE
13597 * dbusbind.c: Pointer signedness fixes.
13598 (xd_signature, xd_append_arg, xd_initialize):
13599 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13600 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13601 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13602 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13603
78320123
PE
13604 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13605 if GCC considers string literals to be constants.
49cebcca 13606 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13607
35ac2a97
SM
136082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13609
fb103ca9
SM
13610 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13611 (print_preprocess, print_object): New macro to fix last change.
13612
35ac2a97
SM
13613 * print.c (print_preprocess): Don't forget font objects.
13614
62973b41
JB
136152011-03-16 Juanma Barranquero <lekktu@gmail.com>
13616
13617 * emacs.c (USAGE3): Doc fixes.
13618
0e48bb22
AS
136192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13620
13621 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13622 structure.
13623
7684e57b
JB
136242011-03-14 Juanma Barranquero <lekktu@gmail.com>
13625
13626 * lisp.h (VWindow_system, Qfile_name_history):
13627 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13628 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13629 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13630
13631 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13632 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13633
13634 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13635 * w32console.c (detect_input_pending, read_input_pending)
13636 (encode_terminal_code):
13637 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13638 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13639 (w32_system_caret_y, Qfile_name_history):
13640 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13641 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13642 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13643 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13644 * w32proc.c (Qlocal, report_file_error):
13645 * w32term.c (Vwindow_system, updating_frame):
13646 * w32uniscribe.c (initialized, uniscribe_font_driver):
13647 Remove unneeded extern declarations.
13648
2aa46d6c
CY
136492011-03-14 Chong Yidong <cyd@stupidchicken.com>
13650
c96bbc66 13651 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13652
cffc6f3b
CY
136532011-03-13 Chong Yidong <cyd@stupidchicken.com>
13654
13655 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13656 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13657 These macros can no longer be used for assignment.
13658
44f230aa
SM
13659 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13660 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13661 (record_buffer_markers, fetch_buffer_markers): New functions for
13662 recording and fetching special buffer markers.
13663 (set_buffer_internal_1, set_buffer_temp): Use them.
13664
13665 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13666
13667 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13668
13669 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13670 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13671
13672 * xdisp.c (hscroll_window_tree):
13673 (reconsider_clip_changes): Use PT instead of BUF_PT.
13674
d251f04b
EZ
136752011-03-13 Eli Zaretskii <eliz@gnu.org>
13676
13677 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13678 $(EMACS_ROOT)/lib/intprops.h.
13679
f0c77cd1
PE
136802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13681
3eca4629
PE
13682 Fix more problems found by GCC 4.5.2's static checks.
13683
7c86ee98
PE
13684 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13685 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13686 (xg_free_frame_widgets): Make it clear that a local variable is
13687 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13688 (gdk_window_get_screen): Make it clear that this macro is needed
13689 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13690 (int_gtk_range_get_value): New function, which avoids a diagnostic
13691 from gcc -Wbad-function-cast.
13692 (xg_set_toolkit_scroll_bar_thumb): Use it.
13693 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13694 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13695 (get_utf8_string, xg_get_file_with_chooser):
13696 Rename locals to avoid shadowing.
13697 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13698
41729b81
PE
13699 * xgselect.c (xg_select): Remove unused var.
13700
f0c77cd1
PE
13701 * image.c (four_corners_best): Mark locals as initialized.
13702 (gif_load): Initialize transparent_p to zero (Bug#8238).
13703 Mark another local as initialized.
ec6cf4c6 13704 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13705
ce0ad53d 13706 * image.c (clear_image_cache): Now static.
d5d5a617 13707 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13708 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13709 (x_edge_detection): Remove unnecessary cast that
13710 gcc -Wbad-function-cast diagnoses.
2037898d 13711 (gif_load): Fix pointer signedness.
6ae141d6
PE
13712 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13713 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13714
33383987 137152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13716
d32df629
PE
13717 Improve quality of tests for time stamp overflow.
13718 For example, without this patch (encode-time 0 0 0 1 1
13719 1152921504606846976) returns the obviously-bogus value (-948597
13720 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13721 reports time overflow. See
13722 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13723 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13724 * editfns.c: Include limits.h and intprops.h.
13725 (TIME_T_MIN, TIME_T_MAX): New macros.
13726 (time_overflow): Move earlier, to before first use.
13727 (hi_time, lo_time): New functions, for an accurate test for
13728 out-of-range times.
13729 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13730 (Fget_internal_run_time): Don't assume time_t fits in int.
13731 (make_time): Use list2 instead of Fcons twice.
13732 (Fdecode_time): More accurate test for out-of-range times.
13733 (check_tm_member): New function.
13734 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13735 (lisp_time_argument): Don't rely on undefined left-shift and
13736 right-shift behavior when checking for time stamp overflow.
8be6f318 13737
fe31d94c
PE
13738 * editfns.c (time_overflow): New function, refactoring common code.
13739 (Fformat_time_string, Fdecode_time, Fencode_time):
13740 (Fcurrent_time_string): Use it.
13741
8be6f318
PE
13742 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13743 * dired.c (make_time): Move to ...
13744 * editfns.c (make_time): ... here.
13745 * systime.h: Note the move.
13746
09d9db2c 137472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13748
126bc0dc
YM
13749 * fringe.c (update_window_fringes): Remove unused variables.
13750
c47cbdfd
YM
13751 * unexmacosx.c (copy_data_segment): Also copy __got section.
13752 (Bug#8223)
13753
7ac80be9
EZ
137542011-03-12 Eli Zaretskii <eliz@gnu.org>
13755
c96bbc66 13756 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13757 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13758 Constify `char *' arguments and their references according to
13759 prototypes in tparam.h.
13760
ecb0f94d 13761 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13762
7ac80be9
EZ
13763 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13764 Adapt all references accordingly.
13765
13766 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13767
ef1fd07e
TT
137682011-03-11 Tom Tromey <tromey@redhat.com>
13769
13770 * buffer.c (syms_of_buffer): Remove obsolete comment.
13771
7ef4b50c
EZ
137722011-03-11 Eli Zaretskii <eliz@gnu.org>
13773
13774 * termhooks.h (encode_terminal_code): Declare prototype.
13775
13776 * msdos.c (encode_terminal_code): Don't declare prototype.
13777
13778 * term.c (encode_terminal_code): Now external again, used by
13779 w32console.c and msdos.c.
13780
44f230aa
SM
13781 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13782 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13783
4b1ec863 137842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13785
1714f52b 13786 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13787
4b1ec863
PE
13788 * fringe.c (update_window_fringes): Mark locals as initialized
13789 (Bug#8227).
13790 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13791
524c7aa6
PE
13792 * alloc.c (mark_fringe_data): Move decl from here ...
13793 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13794 to check its interface.
13795 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13796
a5c0af81 13797 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13798 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13799 (fontset_font): Mark local as initialized.
a9a06e0b 13800 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13801
b4716021
PE
13802 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13803
811e9bac 13804 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13805 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13806 (x_own_selection, Fx_disown_selection_internal): Rename locals
13807 to avoid shadowing.
13808 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13809
7e3ab302
PE
13810 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13811 so that the caller can use some name other than gcpro1.
13812 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13813 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13814 (Fx_backspace_delete_keys_p):
13815 Use them to avoid shadowing, and rename vars to avoid shadowing.
13816 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13817 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13818 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13819 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13820 Remove unused locals.
7e3ab302
PE
13821 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13822 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13823 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13824 macros.
f78faa98 13825
e2b13473
PE
13826 * xterm.h (x_mouse_leave): New decl.
13827
77f23912
PE
13828 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13829 Remove unused functions.
cdf4ba58
PE
13830 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13831 (x_calc_absolute_position): Now static.
7411c686 13832 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13833 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13834 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13835 unless they are used.
38d0b34a
PE
13836 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13837 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13838 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13839 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13840 (x_error_catcher, x_connection_closed, x_error_handler):
13841 (x_error_quitter, xembed_send_message, x_iconify_frame):
13842 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13843 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13844 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13845
44f230aa
SM
13846 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13847 Rename or move locals to avoid shadowing.
6b463e58 13848 (tty_defined_color, merge_face_heights): Now static.
5967d051 13849 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13850 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13851 does not deduce is never used uninitialized.
73719eba
PE
13852 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13853 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13854
426994c3 13855 * terminal.c (store_terminal_param): Now static.
5489860b 13856
032f1620 13857 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13858 (set_frame_menubar): Remove unused local.
d4323972 13859 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13860 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13861 since they might point to immutable storage.
281585b0
PE
13862 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13863 since it's unused otherwise.
032f1620 13864
367c19e5 13865 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13866 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13867 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13868 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13869 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13870 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13871 does not deduce are never used uninitialized.
70739cbe 13872
07b48fa9
PE
13873 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13874
8868a238 13875 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13876 * window.c (window_loop, size_window):
13877 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13878
7e5cf297 13879 * window.c (display_buffer): Now static.
d6550a9f
PE
13880 (size_window): Mark variables that gcc -Wuninitialized
13881 does not deduce are never used uninitialized.
a586633d
PE
13882 * window.h (check_all_windows): New decl, to forestall
13883 gcc -Wmissing-prototypes diagnostic.
5b555da1 13884 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13885
f6095868
PE
13886 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13887 shadowing.
13888 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13889 Include <limits.h>.
13890 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13891 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13892 (load_charset_map): Mark variables that gcc -Wuninitialized
13893 does not deduce are never used uninitialized.
53df7c11 13894 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13895
f38b440c
PE
13896 * coding.c (coding_set_source, coding_set_destination):
13897 Use "else { /* comment */ }" rather than "else /* comment */;"
13898 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13899 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13900 a block, when the outer 'i' will do.
13901 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13902 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13903 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13904 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13905 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13906 Rename locals to avoid shadowing.
13907 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13908 * coding.c (emacs_mule_char, encode_invocation_designation):
13909 Now static, since they're not used elsewhere.
413bb2db 13910 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13911 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13912 (decode_coding_emacs_mule): Mark variables that gcc
13913 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13914 (detect_coding_iso_2022): Initialize a local variable that might
13915 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13916 this initialization is needed. (Bug#8211)
5f58e762
PE
13917 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13918 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13919 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13920 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13921 Remove unused macros.
f38b440c 13922
232b38b9 13923 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13924 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13925 * character.c (string_count_byte8): Likewise.
232b38b9 13926
fb90da1b
PE
13927 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13928 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13929
fb93dbc2
PE
13930 * chartab.c (copy_sub_char_table): Now static, since it's not used
13931 elsewhere.
5c156ace
PE
13932 (sub_char_table_ref_and_range, char_table_ref_and_range):
13933 Rename locals to avoid shadowing.
bbcd0949 13934 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13935
7d3b3862 13936 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13937 (BIDI_BOB): Remove unused macro.
7d3b3862 13938
6be7d3da
PE
13939 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13940 deduce are never used uninitialized.
c2ed9c8b 13941 * term.c (encode_terminal_code): Likewise.
6be7d3da 13942
75f8807f 13943 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13944
50938595
PE
13945 * tparam.h: New file.
13946 * term.c, tparam.h: Include it.
13947 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13948 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13949 Move these decls to tparam.h, and make them agree with what
13950 is actually in tparam.c. The previous trick of using incompatible
13951 decls in different modules does not conform to the C standard.
13952 All callers of tparam changed to use tparam's actual API.
13953 * tparam.c (tparam1, tparam, tgoto):
13954 Use const pointers where appropriate.
13955
fbceeba2
PE
13956 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13957 * cm.h (struct cm): Likewise.
13958 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13959 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13960 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13961 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13962 (turn_on_face, init_tty): Likewise.
13963 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13964
7f3f1250
PE
13965 * term.c (term_mouse_position): Rename local to avoid shadowing.
13966
e6ca6543
PE
13967 * alloc.c (mark_ttys): Move decl from here ...
13968 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13969
c40f8d15
AS
139702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13971
13972 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13973
cfe0661d
JB
139742011-03-09 Juanma Barranquero <lekktu@gmail.com>
13975
13976 * search.c (compile_pattern_1): Remove argument regp, unused since
13977 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13978 (compile_pattern): Don't pass it.
13979
0afb4571
J
139802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13981
13982 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13983 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13984 for ! HAVE_GTK3.
13985 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13986
13987 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13988
13989 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13990 gdk_window_get_screen, gdk_window_get_geometry,
13991 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13992 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13993 (xg_get_pixbuf_from_pixmap): New function.
13994 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13995 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13996 Call xg_get_pixbuf_from_pixmap instead of
13997 gdk_pixbuf_get_from_drawable.
13998 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13999 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14000 (xg_check_special_colors): Use GtkStyleContext and its functions
14001 for HAVE_GTK3.
14002 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14003 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14004 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14005 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14006 Call gtk_widget_get_preferred_size.
0afb4571
J
14007 (xg_frame_resized): gdk_window_get_geometry only takes 5
14008 parameters.
44f230aa
SM
14009 (xg_win_to_widget, xg_event_is_for_menubar):
14010 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14011 (xg_set_widget_bg): New function.
14012 (delete_cb): New function.
895009e1 14013 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14014 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14015 (xg_set_background_color): Call xg_set_widget_bg.
14016 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14017 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14018 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14019 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14020 if ! HAVE_GTK3.
14021 (update_frame_tool_bar): Call gtk_widget_hide.
14022 (xg_initialize): Use GDK_KEY_g.
14023
14024 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14025 if ! HAVE_GTK3
14026 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14027
14028 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14029 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14030 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14031
1c2cc4ef
JB
140322011-03-08 Juanma Barranquero <lekktu@gmail.com>
14033
14034 * w32xfns.c (select_palette): Check success of RealizePalette against
14035 GDI_ERROR, not zero.
14036
33383987 14037See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14038
14039;; Local Variables:
14040;; coding: utf-8
aac0c6e3
MR
14041;; End:
14042
2f097256 14043 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14044
14045 This file is part of GNU Emacs.
14046
14047 GNU Emacs is free software: you can redistribute it and/or modify
14048 it under the terms of the GNU General Public License as published by
14049 the Free Software Foundation, either version 3 of the License, or
14050 (at your option) any later version.
14051
14052 GNU Emacs is distributed in the hope that it will be useful,
14053 but WITHOUT ANY WARRANTY; without even the implied warranty of
14054 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14055 GNU General Public License for more details.
14056
14057 You should have received a copy of the GNU General Public License
14058 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.