Assume perror.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5ebbef1d
PE
12012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2
b747d3f7
PE
3 Assume perror.
4 * s/hpux10-20.h (HAVE_PERROR): Remove.
5 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
6 Remove dummy definition, as this problem was obsolete long ago.
7
5ebbef1d
PE
8 Assume strerror.
9 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
10
984e7f30
DA
112012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
12
13 Avoid calls to strlen in font processing functions.
14 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
15 (font_open_by_name): Changed to use length argument. Adjust
16 users accordingly.
17 * font.h (font_open_by_name, font_parse_xlfd): Adjust prototypes.
18 * xfont.c (xfont_decode_coding_xlfd): Changed to return ptrdiff_t.
19 (xfont_list_pattern, xfont_match): Use length returned by
20 xfont_decode_coding_xlfd.
21 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
22
20e94fdd
GM
232012-07-11 Glenn Morris <rgm@gnu.org>
24
9d596af3
GM
25 * s/darwin.h, s/freebsd.h, s/netbsd.h:
26 Move DONT_REOPEN_PTY to configure.
27
20e94fdd
GM
28 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
29 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
30
e99a530f
PE
312012-07-10 Paul Eggert <eggert@cs.ucla.edu>
32
22ffb973
PE
33 Remove "#define unix" that is no longer needed (Bug#11905).
34 * s/aix4-2.h (unix): Remove; no longer needed.
35
e9a9ae03
PE
36 EMACS_TIME simplification (Bug#11875).
37 This replaces macros (which typically do not work in GDB)
38 with functions, typedefs and enums, making the code easier to debug.
39 The functional style also makes code easier to read and maintain.
40 * systime.h: Include <sys/time.h> on all hosts, not just if
41 WINDOWSNT, since 'struct timeval' is needed in general.
42 (EMACS_TIME): Now a typedef, not a macro.
43 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
44 not macros.
45 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
46 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
47 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
48 (EMACS_TIME_LE): Now functions, not macros.
49 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
50 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
51 which are not functions. All uses rewritten to use:
52 (make_emacs_time): New function.
53 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
54 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
55 not functions. All uses rewritten to use the following, respectively:
56 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
57 (add_emacs_time, sub_emacs_time): New functions.
58 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
59 * fileio.c (Fcopy_file):
60 * xterm.c (XTflash): Get the current time closer to when it's used.
61 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
62
ffacb126
PE
63 * bytecode.c (targets): Suppress -Woverride-init warnings.
64
e99a530f
PE
65 Simplify by avoiding confusing use of strncpy etc.
66 * doc.c (Fsnarf_documentation):
67 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
68 * frame.c (Fmake_terminal_frame):
69 * gtkutil.c (get_utf8_string):
70 * lread.c (openp):
71 * nsmenu.m (ns_update_menubar):
72 * regex.c (regerror):
73 Prefer memcpy to strncpy and strncat when either will do.
74 * fileio.c (Fsubstitute_in_file_name):
75 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
76 (menu_separator_name_p):
77 * nsmenu.m (ns_update_menubar):
78 Prefer memcmp to strncmp when either will do.
79 * nsterm.m: Include <ftoastr.h>.
80 (ns_get_color):
81 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
82 Prefer snprintf to strncpy.
83 * nsterm.m (ns_term_init):
84 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
85 * nsterm.m (ns_term_init):
86 Avoid the need for strncpy, by using build_string or
87 make_unibyte_string directly. Use dtoastr, not snprintf.
88 * process.c (Fmake_network_process): Diagnose service names that
89 are too long, rather than silently truncating them or creating
90 non-null-terminated names.
91 (Fnetwork_interface_info): Likewise, for interface names.
92 * sysdep.c (system_process_attributes) [GNU_LINUX]:
93 Prefer sprintf to strncat.
94 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
95 Prefer vsnprintf to vsprintf + strncpy.
96
c59592b3
GM
972012-07-10 Glenn Morris <rgm@gnu.org>
98
99 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
100 Clarify fallback case.
101
7d7bbefd
DA
1022012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
103
104 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
105 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
106 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
107 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
108 where argument type is known to be a Lisp_Cons.
109
3a4c8000
TT
1102012-07-10 Tom Tromey <tromey@redhat.com>
111
112 * bytecode.c (BYTE_CODE_THREADED): New macro.
113 (BYTE_CODES): New macro. Replaces all old byte-code defines.
114 (enum byte_code_op): New type.
115 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
116 (exec_byte_code): Use them. Use token threading when applicable.
117
2a0213a6
DA
1182012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
119
120 Optimize pure C strings initialization.
121 * lisp.h (make_pure_string): Fix prototype.
122 (build_pure_c_string): New function, defined as static inline. This
123 provides a better opportunity to optimize away calls to strlen when
124 the function is called with compile-time constant argument.
125 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
126 argument, adjust users accordingly. Use build_pure_c_string where
127 appropriate.
128 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
129 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
130 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
131
cb1caeaf
DA
1322012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
133
134 Avoid calls to strlen in miscellaneous functions.
135 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
136 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
137 * lread.c (openp): Likewise.
138
c293e30c
DA
1392012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
140
141 Avoid calls to strlen in path processing functions.
142 * fileio.c (file_name_as_directory): Add comment. Change to add
143 srclen argument and return the length of result. Adjust users
144 accordingly.
145 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 146 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
147 users accordingly.
148 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
149
9e059e3f
GM
1502012-07-10 Glenn Morris <rgm@gnu.org>
151
d02eb359
GM
152 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
153 Move PENDING_OUTPUT_COUNT definition to configure.
154
882cf227
GM
155 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
156 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
157 * s/gnu.h (DATA_START): Move definitions to configure.
158
af6e839f
GM
159 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
160 We include usg5-4-common.h, which defines them both.
161
40289a12
GM
162 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
163 O_RDONLY already includes it).
164
9e059e3f
GM
165 Stop ns builds setting the EMACSLOADPATH environment variable.
166 * nsterm.m (ns_load_path): Rename from ns_init_paths.
167 Now it does not set EMACSLOADPATH, just returns the load-path string.
168 * nsterm.h: Update accordingly.
169 * lread.c [HAVE_NS]: Include nsterm.h.
170 (init_lread) [HAVE_NS]: Use ns_load_path.
171 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
172
7c4e8ec0
GM
1732012-07-09 Glenn Morris <rgm@gnu.org>
174
d4f600ff
GM
175 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
176 since the included bsd-common.h does so.
177
cbb31951
GM
178 Stop ns builds setting the EMACSPATH environment variable.
179 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
180 (ns_init_paths): Do not set EMACSPATH.
181 * nsterm.h (ns_exec_path): Add it.
182 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
183 Use ns_exec_path.
184
7c4e8ec0
GM
185 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
186
26bccfae
PE
1872012-07-09 Paul Eggert <eggert@cs.ucla.edu>
188
a0bee46f
PE
189 * process.c (wait_reading_process_output): 'waitchannels' was unset
190 when read_kbd || !NILP (wait_for_cell); fix this.
191
5994c183
PE
192 Add GCC-style 'const' attribute to functions that can use it.
193 * character.h (char_resolve_modifier_mask):
194 * keyboard.h (make_ctrl_char):
195 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
196 (init_character_once, next_almost_prime, init_fns, init_image)
197 (flush_pending_output, init_sound):
198 * mem-limits.h (start_of_data):
199 * menu.h (finish_menu_items):
200 Add ATTRIBUTE_CONST.
201 * emacs.c (DEFINE_DUMMY_FUNCTION):
202 Declare the dummy function with ATTRIBUTE_CONST.
203 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
204 Add decls with ATTRIBUTE_CONST.
205
26bccfae
PE
206 Minor improvements to make_formatted_string.
207 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
208 where int is good enough, as vsprintf returns an int.
209 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
210
a8290ec3
DA
2112012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
212
213 Use make_formatted_string to avoid double length calculation.
214 * lisp.h (make_formatted_string): New prototype.
215 * alloc.c (make_formatted_string): New function.
216 * buffer.c (Fgenerate_new_buffer_name): Use it.
217 * dbus.c (syms_of_dbusbind): Likewise.
218 * editfns.c (Fcurrent_time_zone): Likewise.
219 * filelock.c (get_boot_time): Likewise.
220 * frame.c (make_terminal_frame, set_term_frame_name)
221 (x_report_frame_params): Likewise.
222 * image.c (gs_load): Likewise.
223 * minibuf.c (get_minibuffer): Likewise.
224 * msdos.c (dos_set_window_size): Likewise.
225 * process.c (make_process): Likewise.
226 * xdisp.c (ensure_echo_area_buffers): Likewise.
227 * xsettings.c (apply_xft_settings): Likewise.
228
d01ba2f1
GM
2292012-07-09 Glenn Morris <rgm@gnu.org>
230
231 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
232 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
233 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
234 * nsterm.h (ns_etc_directory): Add it.
235 * callproc.c [HAVE_NS]: Include nsterm.h.
236 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
237
f1f924b6
DA
2382012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
239
240 Move marker debugging code under MARKER_DEBUG.
241 * marker.c (MARKER_DEBUG): Move marker debugging code under
242 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
243 for bootstrap with --enable-checking (~3x slowdown reported
244 by Juanma Barranquero <lekktu@gmail.com>).
245 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
246
ab531b66
PE
2472012-07-08 Paul Eggert <eggert@cs.ucla.edu>
248
249 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
250 See <http://bugs.gnu.org/11825#29>.
251
c4b3bc8a
EZ
2522012-07-08 Eli Zaretskii <eliz@gnu.org>
253
254 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
255 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
256 (display_line): Add commentary about displaying truncation glyphs
257 on GUI frames.
258 (produce_special_glyphs): Move here from term.c.
259
260 * term.c (produce_special_glyphs): Move to xdisp.c.
261
262 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
263 section.
c4b3bc8a 264
b676b881
AS
2652012-07-07 Andreas Schwab <schwab@linux-m68k.org>
266
f17c5273
AS
267 * xdisp.c (display_line): Avoid warning about implicit declaration
268 of FRAME_FONT.
269
298819b9
AS
270 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
271
b676b881
AS
272 * lisp.h: Remove empty conditional.
273
6045c4fd
PE
2742012-07-07 Paul Eggert <eggert@cs.ucla.edu>
275
b3350bf9
PE
276 * lread.c (load_path_check): Now static.
277
6045c4fd
PE
278 Fix some minor --with-ns problems found by static checking.
279 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
280 (x_set_font) [!HAVE_X_WINDOWS]:
281 * image.c (xpm_load_image) [HAVE_NS]:
282 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
283 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
284 Remove unused local.
285 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
286 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
287 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
288 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
289 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
290 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
291 Fix pointer signedness problem.
292 * xfaces.c (FRAME_X_FONT_TABLE):
293 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
294
929e7845
GM
2952012-07-07 Glenn Morris <rgm@gnu.org>
296
297 * lread.c (load_path_check): New function, split from init_lread.
298 (init_lread): Reorganize. Motivation:
299 If EMACSLOADPATH is set, check/warn about that rather than the
300 defaults, which we are not going to use. Hence we can remove
301 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
302 Don't warn if site-lisp directories are missing.
303 If not installed, start from a blank load-path, since
304 PATH_LOADSEARCH refers to the eventual installation directories.
305
58dd0aa4
EZ
3062012-07-07 Eli Zaretskii <eliz@gnu.org>
307
308 Support truncation and continuation glyphs on GUI frames, when
309 fringes are disabled. (Bug#11832)
310 * xdisp.c (init_iterator): Get dimensions of truncation and
311 continuation glyphs even if on GUI frames. Adjust
312 it->last_visible_x on GUI frames when the left or right fringes,
313 or both, are absent.
314 (start_display, move_it_in_display_line_to): Handle the case of a
315 GUI frame without a fringe to display continuation or truncation
316 glyphs.
317 (insert_left_trunc_glyphs): Support GUI frames: make sure
318 truncation glyphs overwrite enough glyphs from the current line to
319 have sufficient space in pixels.
320 (display_line): Support truncation and continuation glyphs on GUI
321 frames. If some spare pixels are left on the line after inserting
322 the truncation glyphs, fill that space with a stretch glyph of a
323 suitably computed width.
324
325 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
326 produce_glyphs, to support GUI sessions.
327
31571fd7
PE
3282012-07-07 Paul Eggert <eggert@cs.ucla.edu>
329
5a16b9bc
PE
330 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
331
f3047c75
PE
332 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
333
31571fd7
PE
334 Do not require float-time's arg to fit in time_t (Bug#11825).
335 This works better on hosts where time_t is unsigned, and where
336 float-time is applied to the (negative) difference between two times.
337 * editfns.c (decode_time_components): Last arg is now double *,
338 not int *, and means to store all the result as a double, without
339 worrying about whether the seconds part fits in time_t.
340 All callers changed.
341 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
342 All callers changed.
343 (Ffloat_time): Do not fail merely because the specified time falls
344 outside of time_t range.
345
4516fbef
GM
3462012-07-07 Glenn Morris <rgm@gnu.org>
347
348 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
349 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
350 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
351
07adc2c6
JB
3522012-07-07 Juanma Barranquero <lekktu@gmail.com>
353
354 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
355 Update dependencies.
356
357 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
358
fd573f31
PE
3592012-07-06 Paul Eggert <eggert@cs.ucla.edu>
360
fee5959d
PE
361 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
362 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
363 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
364 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
365 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
366 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
367
fd573f31
PE
368 * xfont.c (compare_font_names): Redo to omit the need for casts.
369
ddadbc0e
AS
3702012-07-06 Andreas Schwab <schwab@linux-m68k.org>
371
fca8d6b6
AS
372 * xfns.c (Fx_change_window_property): Doc fix.
373 * w32fns.c (Fx_change_window_property): Doc fix.
374
ddadbc0e
AS
375 * w32fns.c (Fx_window_property): Accept the same arguments as the
376 X Windows version. Doc fix.
377 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
378
f247498e
JB
3792012-07-06 Juanma Barranquero <lekktu@gmail.com>
380 Eli Zaretskii <eliz@gnu.org>
381
382 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
383 Windows-specific code from nt/config.nt moved here.
384 Obsolete settings removed.
385
216ee680
PE
3862012-07-06 Paul Eggert <eggert@cs.ucla.edu>
387
388 * process.c: Avoid unnecessary calls to gettime.
389 (wait_reading_process_output): Don't get the time of day
390 when gobbling data immediately and not waiting, as there's no need
391 for it in that case. This removes a FIXME.
392
bdd091e4
JD
3932012-07-06 Jan Djärv <jan.h.d@swipnet.se>
394
395 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
396 is defined (Bug#11768).
397
9d44f8ce
DA
3982012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
399
400 Fix marker debugging code.
401 * marker.c (byte_char_debug_check): Do not perform the check
402 if buffer is not multibyte.
090bd7cb
JB
403 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
404 Call byte_char_debug_check with correct arguments.
9d44f8ce 405
90fc4786
DA
4062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
407
408 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
409 * marker.c (byte_char_debug_check, count_markers):
410 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
411 (byte_debug_flag): Remove.
412 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
413 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
414
7b7ae965
DA
4152012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
416
4e57b342
DA
417 Avoid code repetition in marker-related functions.
418 * marker.c (attach_marker): New function.
419 (Fset_marker, set_marker_restricted, set_marker_both)
420 (set_marker_restricted_both): Use it.
421 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
422 Consistently rename charno to charpos.
423 (marker_position): Add eassert.
424 (marker_byte_position): Convert to eassert.
425
4262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
427
428 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 429 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 430 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 431
657924ff
DA
4322012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Introduce fast path for the widely used marker operation.
435 * alloc.c (build_marker): New function.
436 * lisp.h (build_marker): New prototype.
437 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
438 * composite.c (autocmp_chars): Likewise.
439 * editfns.c (buildmark): Remove.
440 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
441 (save_restriction_save): Use build_marker.
442 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
443 * window.c (save_window_save): Likewise.
444
041a49a6
DA
4452012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
446
447 Do not use Fdelete_overlay in delete_all_overlays
448 to avoid redundant calls to unchain_overlay.
449 * buffer.c (drop_overlay): New function.
450 (delete_all_overlays, Fdelete_overlay): Use it.
451 * minibuf.c (get_minibuffer): Fix comment.
452
7dca65a4
PE
4532012-07-06 Paul Eggert <eggert@cs.ucla.edu>
454
455 Port to OpenBSD 5.1 amd64.
456 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
457 This is needed for OpenBSD, and should be harmless on all BSD systems.
458 Also, include <sys/sysctl.h>, as it should be available on all
459 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
460 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
461 use p_pid member, not kp_proc.pid.
462
8eb876e2
GM
4632012-07-06 Glenn Morris <rgm@gnu.org>
464
465 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
466
38182d90
PE
4672012-07-05 Paul Eggert <eggert@cs.ucla.edu>
468
469 More xmalloc and related cleanup.
470 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
471 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
472 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
473 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
474 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
475 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
476 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
477 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
478 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
479 * xterm.c:
480 Omit needless casts involving void * pointers and allocation.
481 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
482 as the former is more robust if P's type is changed.
483 Prefer xzalloc to xmalloc + memset 0.
484 Simplify malloc-or-realloc to realloc.
485 Don't worry about xmalloc returning a null pointer.
486 Prefer xstrdup to xmalloc + strcpy.
487 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
488 growing it.
489 * keyboard.c (apply_modifiers_uncached): Prefer local array to
490 alloca of a constant.
491
6dd5a677
EZ
4922012-07-05 Eli Zaretskii <eliz@gnu.org>
493
494 * xdisp.c (display_line): Fix horizontal pixel coordinates when
495 hscroll is larger than the line width. Fixes long and futile
496 looping inside extend_face_to_end_of_line (on a TTY) producing
497 glyphs that are not needed and thrown away.
498
6b312f0f
DA
4992012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
500
501 * marker.c (set_marker_restricted_both): Simplify by using
502 clip_to_bounds.
503
f520ef9b
PE
5042012-07-05 Paul Eggert <eggert@cs.ucla.edu>
505
506 * editfns.c (region_limit): Simplify by using clip_to_bounds.
507
383b7c95
JD
5082012-07-05 Jan Djärv <jan.h.d@swipnet.se>
509
510 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
511 not defined (Bug#11768).
512 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
513 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
514 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
515 followed by gtk_box_set_homogeneous (Bug#11768).
516 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
517 (update_theme_scrollbar_width, xg_create_scroll_bar):
518 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
519 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
520 (is_box_type): New function (Bug#11768).
521 (xg_tool_item_stale_p): Call is_box_type.
5293d758 522 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
523 with default display (Bug#11768).
524
d6e7bf45
EZ
5252012-07-05 Eli Zaretskii <eliz@gnu.org>
526
527 * xdisp.c (window_hscroll_limited): New function.
528 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
529 coordinates when window's hscroll is set to insanely large
530 values. (Bug#11857)
531
431391ec
JB
5322012-07-05 Juanma Barranquero <lekktu@gmail.com>
533
534 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
535 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
536
23f86fce
DA
5372012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
538
539 Cleanup xmalloc.
540 * lisp.h (xzalloc): New prototype. Omit needless casts.
541 * alloc.c (xzalloc): New function. Omit needless casts.
542 * charset.c: Omit needless casts. Convert all calls to
543 xmalloc with following memset to xzalloc.
544 * dispnew.c: Likewise.
545 * fringe.c: Likewise.
546 * image.c: Likewise.
547 * sound.c: Likewise.
548 * term.c: Likewise.
549 * w32fns.c: Likewise.
550 * w32font.c: Likewise.
551 * w32term.c: Likewise.
552 * xfaces.c: Likewise.
553 * xfns.c: Likewise.
554 * xterm.c: Likewise.
555 * atimer.c: Omit needless casts.
556 * buffer.c: Likewise.
557 * callproc.c: Likewise.
558 * ccl.c: Likewise.
559 * coding.c: Likewise.
560 * composite.c: Likewise.
561 * doc.c: Likewise.
562 * doprnt.c: Likewise.
563 * editfns.c: Likewise.
564 * emacs.c: Likewise.
565 * eval.c: Likewise.
566 * filelock.c: Likewise.
567 * fns.c: Likewise.
568 * gtkutil.c: Likewise.
569 * keyboard.c: Likewise.
570 * lisp.h: Likewise.
571 * lread.c: Likewise.
572 * minibuf.c: Likewise.
573 * msdos.c: Likewise.
574 * print.c: Likewise.
575 * process.c: Likewise.
576 * region-cache.c: Likewise.
577 * search.c: Likewise.
578 * sysdep.c: Likewise.
579 * termcap.c: Likewise.
580 * terminal.c: Likewise.
581 * tparam.c: Likewise.
582 * w16select.c: Likewise.
583 * w32.c: Likewise.
584 * w32reg.c: Likewise.
585 * w32select.c: Likewise.
586 * w32uniscribe.c: Likewise.
587 * widget.c: Likewise.
588 * xdisp.c: Likewise.
589 * xmenu.c: Likewise.
590 * xrdb.c: Likewise.
591 * xselect.c: Likewise.
592
0497dc44
PE
5932012-07-05 Paul Eggert <eggert@cs.ucla.edu>
594
595 * fileio.c (time_error_value): Check the right error number.
596 Problem reported by Troels Nielsen in
597 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
598
356e7178
PE
5992012-07-04 Paul Eggert <eggert@cs.ucla.edu>
600
4e71fd89
PE
601 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
602 This should be fixed in a better way; see Eli Zaretskii in
603 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
604 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
605
f0941253
PE
606 * fileio.c (time_error_value): Rename from special_mtime.
607 The old name's problems were noted by Eli Zaretskii in
608 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
609
065c9eb4
PE
610 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
611 This variable's comment says Emacs needs at least one GDB-visible
612 symbol of type enum pvec_type, to work around GDB problems.
613 The symbol's value doesn't matter.
614
356e7178
PE
615 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
616 that causes compilation to fail on pre-C99 compilers.
617
95f61aa2
JB
6182012-07-04 Juanma Barranquero <lekktu@gmail.com>
619
620 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
621 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
622
3884d954
DA
6232012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
624
d209e2fb 625 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
626 headers for buffer_defaults and buffer_local_symbols.
627 Reported by Juanma Barranquero <lekktu@gmail.com>.
628
ee28be33
SM
6292012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
630
631 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
632 * lisp.h (enum pvec_type): Use fewer bits.
633 (PSEUDOVECTOR_SIZE_BITS): New constant.
634 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
635 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
636 change in pvec_type.
637 (PSEUDOVECTOR_TYPEP): New macro.
638 (TYPED_PSEUDOVECTORP): Use it.
639 * fns.c (internal_equal): Adapt code to extract pvectype.
640 * emacs.c (gdb_pvec_type): Update type.
641 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
642 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
643 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
644 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
645 (sweep_vectors): Use it. Use local var `total_bytes' instead of
646 abusing vector->header.next.nbytes.
647 (live_vector_p): Use PVEC_TYPE.
648 (mark_object): Adapt code to extract pvectype. Use switch.
649
c7f2cd7f
PE
6502012-07-04 Paul Eggert <eggert@cs.ucla.edu>
651
652 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
653 Tighten new eassert a bit.
654
8ce70ed2
DA
6552012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
656
657 Fix compilation with --enable-gcc-warnings and -O1
658 optimization level.
659 * doprnt.c (doprnt): Change type of tem to int, initialize
660 to avoid compiler warning. Add eassert.
661 * search.c (simple_search): Initialize match_byte to avoid
662 compiler warning. Add eassert.
663
dea7f1e5
PE
6642012-07-04 Paul Eggert <eggert@cs.ucla.edu>
665
24a212eb
PE
666 Avoid weird behavior with large horizontal scrolls.
667 Without this change, for example, large hscroll values would
668 mess up Emacs's display on Fedora 15 x86, presumably due to
669 overflows in int calculations in the display code.
670 Also, if buffers had long lines, Emacs would freeze.
671 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
672 (set_window_hscroll): New function, containing the old guts of
673 Fset_window_hscroll. Return the clipped value.
674 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
675 This avoids the need to check against PTRDIFF_MAX.
676
dea7f1e5
PE
677 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
678
76046526
DA
6792012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
680
681 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
682
39adff0d
PE
6832012-07-04 Paul Eggert <eggert@cs.ucla.edu>
684
63807d47
PE
685 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
686 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
687 since GCC 4.4.6 issues a bogus warning for them.
688
39adff0d
PE
689 Fix bugs in file timestamp newness comparisons.
690 * fileio.c (Ffile_newer_than_file_p):
691 * lread.c (Fload): Use full timestamp resolution of files,
692 not just the 1-second resolution, so that files that are only
693 slightly newer still count as newer.
694 * fileio.c (Ffile_newer_than_file_p): Don't assume file
695 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
696
dbeed9a6
PE
6972012-07-03 Paul Eggert <eggert@cs.ucla.edu>
698
699 * fileio.c: Improve handling of file time marker. (Bug#11852)
700 (special_mtime): New function.
701 (Finsert_file_contents, Fverify_visited_file_modtime):
702 Use it to set special mtime values consistently.
703
636334d6
AS
7042012-07-03 Andreas Schwab <schwab@linux-m68k.org>
705
706 * fileio.c (Finsert_file_contents): Properly handle st_mtime
707 marker for non-existing file. (Bug#11852)
708
e2017fe2
GM
7092012-07-03 Glenn Morris <rgm@gnu.org>
710
711 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
712 and did not make it into globals.h).
713
404dbd37
TT
7142012-07-03 Tom Tromey <tromey@redhat.com>
715
716 * window.c (Fset_window_margins, Fset_window_fringes)
717 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
718 * textprop.c (Fprevious_property_change): No longer static.
719 * syntax.c (Fsyntax_table_p): No longer static.
720 * process.c (Fget_process, Fprocess_datagram_address): No longer
721 static.
722 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
723 * keyboard.c (Fcommand_execute): No longer static.
724 Remove EXFUN.
725 * insdel.c (Fcombine_after_change_execute): No longer static.
726 * image.c (Finit_image_library): No longer static.
727 * fileio.c (Fmake_symbolic_link): No longer static.
728 * eval.c (Ffetch_bytecode): No longer static.
729 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
730 * doc.c (Fdocumentation_property, Fsnarf_documentation):
731 No longer static.
404dbd37
TT
732 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
733 static.
734 * dired.c (Ffile_attributes): No longer static.
735 * composite.c (Fcomposition_get_gstring): No longer static.
736 * callproc.c (Fgetenv_internal): No longer static.
737
738 * ccl.h: Remove EXFUNs.
739 * buffer.h: Remove EXFUNs.
740 * dispextern.h: Remove EXFUNs.
741 * intervals.h: Remove EXFUNs.
742 * fontset.h: Remove EXFUN.
743 * font.h: Remove EXFUNs.
744 * dosfns.c (system_process_attributes): Remove EXFUN.
745 * keymap.h: Remove EXFUNs.
746 * lisp.h: Remove EXFUNs.
747 * w32term.h: Remove EXFUNs.
748 * window.h: Remove EXFUNs.
749 * xsettings.h: Remove EXFUN.
750 * xterm.h: Remove EXFUN.
751
8e4fd1e1
GM
7522012-07-03 Glenn Morris <rgm@gnu.org>
753
754 * lisp.h (Frandom): Make it visible to C.
755 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
756 buffer for invisible buffers. (Bug#1229)
757
ca95b3eb
DA
7582012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
761 values which aren't power of 2.
762 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
763 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
764 accordingly.
765
7555c33f
SM
7662012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
767
768 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
769
770 * alloc.c (mark_object): Revert part of last patch to use `switch'.
771
d12e8f5a
DA
7722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
773
774 * alloc.c (allocate_vector_block): Remove redundant
775 calls to mallopt if DOUG_LEA_MALLOC is defined.
776 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
777 avoid calls to mallopt if zero_vector is returned.
778
296094c3
DA
7792012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
780
781 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
782 is enabled, avoid dereferencing NULL current_sblock if
783 running undumped.
784
36429c89
DA
7852012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
786
787 Cleanup basic buffer management.
788 * buffer.h (struct buffer): Change layout to use generic vector
789 marking code. Fix some comments. Change type of 'clip_changed'
790 to bitfield. Remove unused #ifndef old.
791 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
792 (GET_OVERLAYS_AT): Fix indentation.
793 (for_each_per_buffer_object_at): New macro.
794 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
795 (Fbuffer_local_variables): Use it.
796 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
797 * alloc.c (allocate_buffer): Adjust to match new layout of
798 struct buffer. Fix comment.
799 (mark_overlay): New function.
800 (mark_buffer): Use it. Use mark_vectorlike to mark normal
801 Lisp area of struct buffer.
802 (mark_object): Use it. Adjust marking of misc objects
803 and related comments.
804
3b3e4cac
PE
8052012-07-02 Paul Eggert <eggert@cs.ucla.edu>
806
807 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
808 wrapper that is not needed because the wrapped code is a no-op (zero
809 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
810 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
811
cf5c0175
DA
8122012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
813
814 * alloc.c (mark_buffer): Simplify. Remove prototype.
815 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 816 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
817 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
818 redundant calls to mark_vectorlike for bool vectors.
819
ca26824c
GM
8202012-06-30 Glenn Morris <rgm@gnu.org>
821
2e4c5312
GM
822 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
823
ca26824c
GM
824 * epaths.in (PATH_SITELOADSEARCH): New.
825 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
826 This is rather than relying on --enable-locallisppath elements
827 having "site-lisp" in their names. (Bug#10208#25, 11658)
828
0d23c240
EZ
8292012-06-30 Eli Zaretskii <eliz@gnu.org>
830
c9240d7a
EZ
831 * w32proc.c (sys_select): Accept and ignore one more argument.
832
833 * w32.c (emacs_gnutls_pull): Call select with one more argument.
834
0d23c240 835 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 836 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
837
838 * sysdep.c: Don't include dos.h and dosfns.h.
839
840 * process.c (sys_select):
841 * msdos.c (sys_select): Accept one more argument and ignore it.
842
843 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
844 adapt data types and code to that.
845
846 * dosfns.c:
847 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
848 which clashes with the gnulib function of the same name.
849
af5a5a98
AS
8502012-06-30 Andreas Schwab <schwab@linux-m68k.org>
851
c5e4379c
AS
852 * font.c (font_style_to_value, font_style_symbolic)
853 (font_prop_validate_style): Add type checks for values in
854 font_style_table.
855
af5a5a98
AS
856 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
857 argument.
858 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
859 uses.
860
8d38f461
EZ
8612012-06-29 Eli Zaretskii <eliz@gnu.org>
862
2e5a6631
EZ
863 * xdisp.c (try_window_id): Undo last change.
864
8d38f461
EZ
865 * w32.c (getwd): Adjust commentary about startup_dir.
866 (init_environment): Always call sys_access, even in non-MSVC
867 builds. Don't chdir to the directory of the Emacs executable.
868 This undoes code from 1997 which was justified by the need to
869 "avoid conflicts when removing and renaming directories". But its
870 downside was that every relative file name was being interpreted
871 relative to the directory of the Emacs executable, which can never
872 be TRT. In particular, it broke sys_access when called with
873 relative file names.
874 (sys_access): Map GetLastError to errno.
875
2af3565e
DA
8762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
877
878 * window.h (struct window): Change type of 'fringes_outside_margins'
879 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 880 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
881 Adjust comment.
882 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
883 to ptrdiff_t.
884
c8d3a25c 8852012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 886
c8d3a25c
GM
887 * gnutls.c (emacs_gnutls_handshake):
888 Add QUIT to make the loop interruptible.
57570cd3 889
c8d3a25c 8902012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 891
c8d3a25c
GM
892 * charset.c (init_charset): Make lack of etc/charsets fatal.
893
3e984ee8
DA
8942012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
895
896 * editfns.c (region_limit): Fix type mismatch.
897
ef884f23
DA
8982012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
899
900 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
901 undefined. Convert from xassert to eassert.
902 * nsmenu.m: Convert from xassert to eassert.
903 * nsterm.m: Likewise.
904
7d7e0027
SM
9052012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
906
907 * editfns.c (region_limit): Clip to narrowing (bug#11770).
908
aa754e6a
PE
9092012-06-28 Paul Eggert <eggert@cs.ucla.edu>
910
911 Avoid integer overflow on scroll-left and scroll-right.
912 * window.c (HSCROLL_MAX): New macro.
913 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
914 overflow when requested scroll falls outside ptrdiff_t range.
915
80b00b08
DA
9162012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
917
918 * window.h (struct window): Change type of 'hscroll',
919 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
920 'last_modified' and 'last_overlay_modified' to EMACS_INT.
921 Adjust users accordingly.
922 * xdisp.c (try_cursor_movement): Replace type check with eassert.
923 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
924 from EMACS_INT to ptrdiff_t.
925 (make_window): Omit redundant initialization.
926
62b2bcf6
JB
9272012-06-28 Juanma Barranquero <lekktu@gmail.com>
928
929 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
930
45942c7d
DA
9312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
932
933 * window.h (struct window): Change type of 'use_time' and
934 'sequence_number' from Lisp_Object to int.
935 * frame.c (make_frame): Adjust users accordingly.
936 * print.c (print_object): Likewise.
937 * window.c (select_window, Fwindow_use_time, make_parent_window)
938 (make_window): Likewise.
939
e509cfa6
DA
9402012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
941
942 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
943 enabled with --enable-checking=[all,glyphs] configure option.
944 Fix GLYPH_DEBUG usage assuming that it may be undefined,
945 adjust comments accordingly.
946 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
947 undefined, adjust comments accordingly.
948 * image.c: Likewise.
949 * scroll.c: Likewise.
950 * w32fns.c: Likewise.
951 * w32term.c: Likewise.
952 * xdisp.c: Likewise.
953 * xfaces.c: Likewise.
954 * xfns.c: Likewise.
955 * xterm.c: Likewise.
956
a54e2c05
DA
9572012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
958
959 Generalize run-time debugging checks.
960 * dispextern.h (XASSERTS): Remove.
961 * fontset.c (xassert): Remove.
962 Convert from xassert to eassert.
963 * alloc.c: Convert from xassert to eassert.
964 * bidi.c: Likewise.
965 * dispnew.c: Likewise.
966 * fns.c: Likewise.
967 * fringe.c: Likewise.
968 * ftfont.c: Likewise.
969 * gtkutil.c: Likewise.
970 * image.c: Likewise.
971 * keyboard.c: Likewise.
972 * menu.c: Likewise.
973 * process.c: Likewise.
974 * scroll.c: Likewise.
975 * sound.c: Likewise.
976 * term.c: Likewise.
977 * w32console.c: Likewise.
978 * w32fns.c: Likewise.
979 * w32term.c: Likewise.
980 * window.c: Likewise.
981 * xdisp.c: Likewise.
982 * xfaces.c: Likewise.
983 * xfns.c: Likewise.
984 * xselect.c: Likewise.
985 * xterm.c: Likewise.
986
1ec4b7b2
SM
9872012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
988
989 * fns.c (maybe_resize_hash_table): Output message when growing the
990 purify-hashtable.
991
2014308a
DA
9922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
993
994 * alloc.c (allocate_string_data): Remove dead code.
995 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
996 avoid GCC warning about unused macro.
997
246155eb
DA
9982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 * alloc.c (allocate_string): Omit intervals initialization.
1001 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1002 as in make_pure_string and make_pure_c_string.
1003
43184b7b
DA
10042012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1005
d209e2fb 1006 * alloc.c (allocate_string): Fix last change.
43184b7b 1007
3fe6dd74
DA
10082012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1009
d209e2fb 1010 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1011 to memset, add explicit initialization where appropriate.
1012
1ba6038a
GM
10132012-06-27 Glenn Morris <rgm@gnu.org>
1014
1015 * lisp.mk (lisp): Remove paths.elc.
1016
c89926a5
CY
10172012-06-27 Chong Yidong <cyd@gnu.org>
1018
1019 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1020
ed6b3510
JW
10212012-06-26 John Wiegley <johnw@newartisans.com>
1022
1ec4b7b2 1023 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1024 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1025
ed6b3510
JW
1026 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1027 when building with Clang.
1028
8edd4a2b
SM
10292012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1030
1031 * eval.c (Fapply): Allow calling it with a single argument.
1032
f6f62d1b
EZ
10332012-06-26 Eli Zaretskii <eliz@gnu.org>
1034
1035 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1036 _stricmp and _strnicmp.
1037 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1038
62efea5e
DA
10392012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1040
1041 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1042 allocated window.
1043 (allocate_process): Likewise for new process.
8edd4a2b 1044 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1045 (allocate_frame): Likewise.
1046 * frame.c (make_frame): Omit redundant initialization.
1047 * window.c (make_parent_window): Use memset.
1048 (make_window): Omit redundant initialization.
1049 * process.c (make_process): Omit redundant initialization.
1050 * terminal.c (create_terminal): Likewise.
1051
42997f4d
DA
10522012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 * term.c (delete_tty): Remove redundant call to memset.
1055
1130ecfc
DA
10562012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1057
1058 * alloc.c: Remove build_string.
1059 * lisp.h: Define build_string as static inline. This provides
1060 a better opportunity to optimize away calls to strlen when the
1061 function is called with compile-time constant argument.
1062 * image.c (imagemagick_error): Convert to build_string.
1063 * w32proc.c (sys_spawnve): Likewise.
1064 * xterm.c (x_term_init): Likewise.
1065
cf38a720
PE
10662012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1067
99027bdd
PE
1068 Use sprintf return value instead of invoking strlen on result.
1069 In the old days this wasn't portable, since some sprintf
1070 implementations returned char *. But they died out years ago and
1071 Emacs already assumes sprintf returns int.
1072 Similarly for float_to_string.
1073 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1074 * ccl.c (ccl_driver):
1075 * character.c (string_escape_byte8):
1076 * data.c (Fnumber_to_string):
1077 * doprnt.c (doprnt):
1078 * print.c (print_object):
1079 * xdisp.c (message_dolog):
1080 * xfns.c (syms_of_xfns):
1081 Use sprintf or float_to_string result to avoid need to call strlen.
1082 * data.c (Fnumber_to_string):
1083 Use make_unibyte_string, since the string must be ASCII.
1084 * lisp.h, print.c (float_to_string): Now returns int length.
1085 * term.c (produce_glyphless_glyph):
1086 Use sprintf result rather than recomputing it.
1087
cf38a720
PE
1088 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1089 * Makefile.in (ALL_CFLAGS):
1090 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1091 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1092
3511c784
DA
10932012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1094
0a08eb21 1095 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1096 strcasecmp if available.
1097 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1098
fb7da12e
AS
10992012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1100
1101 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1102 Avoid comma operator.
1103 * menu.c (push_submenu_start, push_submenu_end)
1104 (push_left_right_boundary, push_menu_pane): Likewise.
1105 * msdos.c (dos_rawgetc): Likewise.
1106
afa2ffd8
DA
11072012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1108
1109 * xfns.c (xic_create_fontsetname): Remove redundant calls
1110 to memset.
1111
b3b4476b
PE
11122012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1113
4495ff38
PE
1114 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1115 sprintf already null-terminates its output.
1116
b3b4476b
PE
1117 * xfns.c (x_window): Remove redundant cast.
1118
b00876c9
DA
11192012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1120
1121 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1122 `const char *' to `char *' to avoid compiler warning.
1123
d188e26b
PE
11242012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1125
885d1d74
PE
1126 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1127 instead of truncating it to 63 (admittedly a generous limit).
1128
d188e26b
PE
1129 * process.c: Fix spelling and caps in comments.
1130
e2f560b1
DN
11312012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1132
e86db54b 1133 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1134 * sysdep.c (setpgrp): Remove definition, not used in this file.
1135
7583a3a1
JB
11362012-06-24 Juanma Barranquero <lekktu@gmail.com>
1137
1138 * makefile.w32-in: Update dependencies.
1139
696056c2
EZ
11402012-06-24 Eli Zaretskii <eliz@gnu.org>
1141
1142 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1143 (SYSTIME_H): Add nt/inc/sys/time.h.
1144
1145 * systime.h [WINDOWSNT]: Include sys/time.h.
1146
1147 * s/ms-w32.h (struct timespec): Definition moved from
1148 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1149
845ca893
PE
11502012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1153 * buffer.h (buffer_slot_type_mismatch):
1154 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1155 * eval.c (unwind_to_catch):
1156 * image.c (my_png_error, my_error_exit):
1157 * keyboard.c (quit_throw_to_read_char, user_error)
1158 (Fexit_recursive_edit, Fabort_recursive_edit):
1159 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1160 (wrong_type_argument, buffer_overflow, __executable_start)
1161 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1162 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1163 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1164 (fatal):
1165 (child_setup) [!DOS_NT]:
1166 * lread.c (end_of_file_error, invalid_syntax):
1167 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1168 * puresize.h (pure_write_error):
1169 * search.c (matcher_overflow):
1170 * sound.c (sound_perror, alsa_sound_perror):
1171 * sysdep.c, syssignal.h (croak):
1172 * term.c (maybe_fatal, vfatal):
1173 * textprop.c (text_read_only):
1174 * undo.c (user_error):
1175 * unexmacosx.c (unexec_error):
1176 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1177 Use _Noreturn rather than NO_RETURN.
1178 No need for separate decl merely because of _Noreturn.
1179 * sound.c (sound_warning, parse_sound):
1180 Remove unnecessary forward decls.
1181
f1dd8073
PE
11822012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1185 * lisp.h (WAIT_READING_MAX): New macro.
1186 * dispnew.c (Fsleep_for, sit_for):
1187 * keyboard.c (kbd_buffer_get_event):
1188 * process.c (Faccept_process_output):
1189 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1190 This improves on the previous patch, which introduced a bug
1191 when time_t is unsigned and as wide as intmax_t.
1192 See <http://bugs.gnu.org/9000#51>.
1193
b82c1755
EZ
11942012-06-23 Eli Zaretskii <eliz@gnu.org>
1195
1196 * dispnew.c (sit_for, Fsleep_for):
1197 * keyboard.c (kbd_buffer_get_event):
1198 * process.c (Faccept_process_output): Avoid compiler warnings when
1199 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1200
ca300656
JB
12012012-06-23 Juanma Barranquero <lekktu@gmail.com>
1202
049ec95b
JB
1203 * makefile.w32-in: Update dependencies.
1204
ca300656
JB
1205 * w32.c (ltime): Add return type and declare static.
1206 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1207
db7b8d06
PE
12082012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1211 Privately reported by Herbert J. Skuhra.
1212 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1213 All uses changed.
1214 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1215 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1216
0bd8297f
EZ
12172012-06-23 Eli Zaretskii <eliz@gnu.org>
1218
96512555
EZ
1219 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1220 last argument of make_unibyte_string.
1221
0bd8297f
EZ
1222 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1223 language ID in the event parameters.
1224
1225 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1226 event.code, not the obscure "character set ID".
1227
63def6b6
CY
12282012-06-23 Chong Yidong <cyd@gnu.org>
1229
1230 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1231
e8a02204
EZ
12322012-06-23 Eli Zaretskii <eliz@gnu.org>
1233
388cdec0
EZ
1234 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1235 * w32.c (fdutimens): New function.
1236
1237 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1238
1239 * s/ms-w32.h (pselect): Redirect to sys_select.
1240
1241 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1242
e8a02204
EZ
1243 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1244 in the logic of incrementing and decrementing the value of
1245 use_relocatable_buffers.
1246
d054f3fb
PE
12472012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1250 Privately reported by Herbert J. Skuhra.
1251 [__FreeBSD__]: Remove "*/" typo after "#include".
1252 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1253 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1254 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1255 Don't assume EMACS_TIME and struct timeval are the same type.
1256
d35af63c
PE
12572012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 Support higher-resolution time stamps (Bug#9000).
1260 The time stamps are only nanosecond-resolution at the C level,
1261 since that's the best that any real-world system supports now.
1262 But they are picosecond-resolution at the Lisp level, as that's
1263 easy, and leaves room for future OS improvements.
1264
1265 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1266 (LIBES): Use it.
1267
1268 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1269 Don't get current time unless it's needed.
1270
1271 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1272 now provides it if it's absent.
1273 (start_atimer): Port to higher-res time stamps.
1274 Check for time stamp overflow. Don't get current time more
1275 often than is needed.
1276
1277 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1278 Include systime.h, not time.h.
1279 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1280
1281 * dired.c: Include stat-time.h.
1282 (Ffile-attributes): File times now have higher resolution.
1283
1284 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1285 (struct image): Timestamp now has higher resolution.
1286
1287 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1288 has at least microseconds now. All uses removed.
1289 (update_frame, update_single_window, update_window, update_frame_1)
1290 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1291
1292 * editfns.c (time_overflow): Now extern.
1293 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1294 (float-time, Fformat_time_string, Fcurrent_time_string)
1295 (Fcurrent_time_zone): Accept and generate higher-resolution
1296 time stamps.
1297 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1298 (decode_time_components, lisp_seconds_argument): New functions.
1299 (make_time): Now static.
1300 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1301 Report an error if the time is invalid, rather than having the caller
1302 do that.
1303
1304 * fileio.c: Include <stat-time.h>
1305 (Fcopy_file): Copy higher-resolution time stamps.
1306 Prefer to set the time stamp via a file descriptor if that works.
1307 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1308 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1309 (Fvisited_file_modtime, Fset_visited_file_modtime):
1310 Support higher-resolution time stamps.
1311
1312 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1313
1314 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1315
1316 * image.c (prepare_image_for_display, clear_image_cache)
1317 (lookup_image): Port to higer-resolution time stamps.
1318
1319 * keyboard.c (start_polling, bind_polling_period):
1320 Check for time stamp overflow.
1321 (read_char, kbd_buffer_get_event, timer_start_idle)
1322 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1323 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1324 Port to higher-resolution time stamps. Do not assume time_t is signed.
1325 (decode_timer): New function. Timers are now vectors of length 9,
1326 not 8, to accommodate the picosecond component.
1327 (timer_check_2): Use it.
1328
1329 * nsterm.m (select_timeout, timeval_subtract): Remove.
1330 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1331 as they're a bit more accurate and handle overflow better.
1332 (ns_select): Change prototype to be compatible with pselect.
1333 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1334 * nsterm.h (ns_select): Adjust prototype.
1335
1336 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1337 us-resolution time stamps.
1338 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1339
1340 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1341
1342 * lisp.h (time_overflow): New decl.
1343 (wait_reading_process_output): First arg is now intmax_t, not int,
1344 to accommodate larger waits.
1345
1346 * process.h (struct Lisp_Process.read_output_delay):
1347 Now counts nanoseconds, not microseconds.
1348 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1349 EMACS_HAS_USECS.
1350 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1351 (wait_reading_process_output):
1352 Port to ns-resolution time stamps.
1353 (Faccept_process_output, wait_reading_process_output):
1354 Check for time stamp overflow. Do not assume time_t is signed.
1355 (select_wrapper): Remove; we now use pselect.
1356 (Fprocess_attributes): Now generates ns-resolution time stamps.
1357
1358 * sysdep.c: Include utimens.h. Don't include utime.h
1359 or worry about struct utimbuf; gnulib does that for us now.
1360 (gettimeofday): Remove; gnulib provides a substitute.
1361 (make_timeval): New function.
1362 (set_file_times): Now sets ns-resolution time stamps.
1363 New arg FD; all uses changed.
1364 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1365 (system_process_attributes):
1366 Now returns ns-resolution time stamp. All uses changed.
1367 Check for time stamp overflow.
1368
1369 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1370 provides a substitute now.
1371
1372 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1373 since it guarantees struct timespec.
1374 (EMACS_TIME): Now struct timespec, so that we can support
1375 ns-resolution time stamps.
1376 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1377 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1378 (EMACS_USECS): Remove.
1379 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1380 so multiply the arg by 1000 before storing it.
1381 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1382 New macros.
1383 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1384 Port to ns-resolution time stamps.
1385 (EMACS_TIME_NEG_P): Remove; replaced by....
1386 (EMACS_TIME_SIGN): New macro.
1387 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1388 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1389 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1390 (make_timeval, make_lisp_time, decode_time_components): New decls.
1391 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1392 that it mishandled time_t overflow. You can't compare by subtracting!
1393 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1394 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1395
1396 * term.c: Include <sys/time.h>.
1397 (timeval_to_Time): New function, for proper overflow wraparound.
1398 (term_mouse_position, term_mouse_click): Use it.
1399
1400 * undo.c (record_first_change): Support higher-resolution time stamps
1401 in the undo buffer.
1402 (Fprimitive_undo): Use them when restoring time stamps.
1403
1404 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1405 (w32_get_internal_run_time):
1406 Port to higher-resolution Emacs time stamps.
1407 (ltime): Now accepts single 64-bit integer, as that's more convenient
1408 for callers.
1409
1410 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1411
1412 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1413 for compatibility with pselect. Support ns-resolution time stamps.
1414
1415 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1416
1417 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1418 Check for time stamp overflow, and support ns-resolution time stamps.
1419
1420 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1421 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1422 (timeval_subtract): Remove; no longer needed.
1423 (XTflash, XTring_bell, x_wait_for_event):
1424 Port to ns-resolution time stamps. Don't assume time_t is signed.
1425
b6a92dfe
CY
14262012-06-22 Chong Yidong <cyd@gnu.org>
1427
1428 * xdisp.c (x_consider_frame_title): Revert last change.
1429
d251c37c
EZ
14302012-06-22 Eli Zaretskii <eliz@gnu.org>
1431
1432 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1433 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1434 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1435 staticidx goes up to 1597 out of 1600 = 0x640.)
1436
f10deafb
PE
14372012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1440 Otherwise, the umask might be mistakenly 0 while handling input signals.
1441
ec6de1e2
SM
14422012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1443
1444 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1445
28be1ada
DA
14462012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1447
1448 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1449 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1450 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1451 access to `contents' member of Lisp_Vector objects with AREF and ASET
1452 where appropriate.
1453
c6bf3022
CY
14542012-06-19 Chong Yidong <cyd@gnu.org>
1455
1456 * frame.c (delete_frame): When selecting a frame on a different
1457 text terminal, do not alter the terminal's top-frame.
1458
1459 * xdisp.c (format_mode_line_unwind_data): Record the target
1460 frame's selected window and its terminal's top-frame.
1461 (unwind_format_mode_line): Restore them.
1462 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1463 Callers changed.
1464 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1465 since tty frames can be explicitly named.
1466 (prepare_menu_bars): Likewise.
1467
1468 * term.c (Ftty_top_frame): New function.
1469
defd4196
PE
14702012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 Port byte-code-meter to modern targets.
1473 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1474 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1475 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1476 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1477 (METER_1, METER_2): Simplify.
1478
1053a871
SM
14792012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1480
1481 * data.c (Fdefalias): Return `symbol' (bug#11686).
1482
b7e8d081
MR
14832012-06-18 Martin Rudalics <rudalics@gmx.at>
1484
1485 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1486 gets killed during executing of this function (Bug#11665).
1487 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1488 (Vkill_buffer_query_functions): In doc-string say that functions
1489 run by this hook should not change the current buffer.
1490
7ea2b339
PE
14912012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 Fix recently-introduced process.c problems found by static checking.
1494 * process.c (write_queue_push, write_queue_pop, send_process):
1495 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1496 (write_queue_pop): Fix pointer signedness problem.
1497 (send_process): Remove unused local.
1498
96a313a1
CY
14992012-06-17 Chong Yidong <cyd@gnu.org>
1500
1501 * xdisp.c (redisplay_internal): No need to redisplay terminal
1502 frames that are not on top.
1503
20ca2e94
TN
15042012-06-17 Troels Nielsen <bn.troels@gmail.com>
1505
1506 * process.c (make_process): Initialize write_queue.
1507 (write_queue_push, write_queue_pop): New functions.
1508 (send_process): Use them to maintain correct ordering of process
1509 writes (Bug#10815).
1510
9a900ca9
PE
15112012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1512
310fbfa8
PE
1513 * lisp.h (eassert): Assume C89 or later.
1514 This removes the need for CHECK.
1515 (CHECK): Remove. Its comments about always evaluating its
1516 argument were confusing, as 'eassert' typically does not evaluate
1517 its argument.
1518
27bb1ca4
PE
1519 * coding.c (produce_chars): Use ptrdiff_t, not int.
1520
9a900ca9
PE
1521 * xterm.c (x_draw_underwave): Check for integer overflow.
1522 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1523
41b7f8bc 15242012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1525
1526 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1527 referenced (Bug#11583).
1528
9b0e3eba
AA
15292012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1530
1531 Implement wave-style variant of underlining.
1532 * dispextern.h (face_underline_type): New enum.
1533 (face): Add field for underline type.
1534 * nsterm.m (ns_draw_underwave): New function.
1535 (ns_draw_text_decoration): Use it.
1536 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1537 New functions.
1538 (x_draw_glyph_string): Use them.
1539 * xfaces.c (Qline, Qwave): New Lisp objects.
1540 (check_lface_attrs, merge_face_ref)
1053a871
SM
1541 (Finternal_set_lisp_face_attribute, realize_x_face):
1542 Handle wave-style underline face attributes.
9b0e3eba
AA
1543 * xterm.c (x_draw_underwave): New function.
1544 (x_draw_glyph_string): Use it.
1545
0fb52f11
JB
15462012-06-16 Juanma Barranquero <lekktu@gmail.com>
1547
1548 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1549 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1550 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1551 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1552 ($(BLD)/w32select.$(O)): Update dependencies.
1553
e5560ff7
AS
15542012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1555
1556 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1557 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1558 * character.c (_fetch_multibyte_char_p): Remove.
1559 * alloc.c: Include "character.h" before "buffer.h".
1560 * bidi.c: Likewise.
1561 * buffer.c: Likewise.
1562 * bytecode.c: Likewise.
1563 * callint.c: Likewise.
1564 * callproc.c: Likewise.
1565 * casefiddle.c: Likewise.
1566 * casetab.c: Likewise.
1567 * category.c: Likewise.
1568 * cmds.c: Likewise.
1569 * coding.c: Likewise.
1570 * composite.c: Likewise.
1571 * dired.c: Likewise.
1572 * dispnew.c: Likewise.
1573 * doc.c: Likewise.
1574 * dosfns.c: Likewise.
1575 * editfns.c: Likewise.
1576 * emacs.c: Likewise.
1577 * fileio.c: Likewise.
1578 * filelock.c: Likewise.
1579 * font.c: Likewise.
1580 * fontset.c: Likewise.
1581 * fringe.c: Likewise.
1582 * indent.c: Likewise.
1583 * insdel.c: Likewise.
1584 * intervals.c: Likewise.
1585 * keyboard.c: Likewise.
1586 * keymap.c: Likewise.
1587 * lread.c: Likewise.
1588 * macros.c: Likewise.
1589 * marker.c: Likewise.
1590 * minibuf.c: Likewise.
1591 * nsfns.m: Likewise.
1592 * nsmenu.m: Likewise.
1593 * print.c: Likewise.
1594 * process.c: Likewise.
1595 * regex.c: Likewise.
1596 * region-cache.c: Likewise.
1597 * search.c: Likewise.
1598 * syntax.c: Likewise.
1599 * term.c: Likewise.
1600 * textprop.c: Likewise.
1601 * undo.c: Likewise.
1602 * unexsol.c: Likewise.
1603 * w16select.c: Likewise.
1604 * w32fns.c: Likewise.
1605 * w32menu.c: Likewise.
1606 * window.c: Likewise.
1607 * xdisp.c: Likewise.
1608 * xfns.c: Likewise.
1609 * xmenu.c: Likewise.
1610 * xml.c: Likewise.
1611 * xselect.c: Likewise.
1612
2f07e6af
EZ
16132012-06-16 Eli Zaretskii <eliz@gnu.org>
1614
1053a871
SM
1615 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1616 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1617 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1618 row.
1619 (handle_face_prop): Use chunk-relative overlay string index when
1620 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1621 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1622 the rightmost. (Bug#11720)
2f07e6af 1623
29b83cec
AS
16242012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1625
1626 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1627 (CATEGORY_MEMBER): Enforce 1/0 value.
1628 * category.c (_temp_category_set): Remove.
1629
4c5501e9
EZ
16302012-06-16 Eli Zaretskii <eliz@gnu.org>
1631
1632 * window.c (Fdelete_other_windows_internal)
1633 (Fdelete_window_internal): Don't access frame's mouse highlight
1634 info of the initial frame. (Bug#11677)
1635
2b570124
PE
16362012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1637
e93864f9
PE
1638 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1639 Assume USE_2_TAGS_FOR_INTS.
1640 (xreload): Adjust $tagmask width to match recent lisp.h change.
1641
2b570124
PE
1642 Simplify lisp.h in minor ways that should not affect code.
1643 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1644 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1645 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1646 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1647 (INTTYPEBITS): New macro, for clarity.
1648 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1649 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1650 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1651 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1652 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1653
81755f69
JB
16542012-06-13 Juanma Barranquero <lekktu@gmail.com>
1655
1656 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1657
16192a57
GM
16582012-06-13 Glenn Morris <rgm@gnu.org>
1659
1660 * s/bsd-common.h (BSD4_3):
1661 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1662
646b5f55
AS
16632012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1664
1665 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1666 instead of union.
1667 (XLI, XIL): Define.
1053a871
SM
1668 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1669 Use them.
1670 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1671 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1672 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1673 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1674 * frame.c (delete_frame): Remove outdated comment.
1675 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1676 USE_LISP_UNION_TYPE.
1677 (Fw32_unregister_hot_key): Likewise.
1678 (Fw32_toggle_lock_key): Likewise.
1679 * w32menu.c (add_menu_item): Likewise.
1680 (w32_menu_display_help): Use XIL instead of checking
1681 USE_LISP_UNION_TYPE.
1682 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1683 (init_heap): Likewise.
1684 * w32term.c (w32_read_socket): Update comment.
1685
1d3823c9
GM
16862012-06-13 Glenn Morris <rgm@gnu.org>
1687
c62ff706
GM
1688 * s/usg5-4-common.h, src/s/unixware.h:
1689 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1690
1d3823c9
GM
1691 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1692
bfe3e0a2
PE
16932012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1696 * alloc.c (make_number) [!defined make_number]:
1697 Remove, as lisp.h always defines this now.
1698 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1699 (roundup_size): Verify that it is a power of 2.
1700 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1701 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1702 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1703 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1704 USE_LSB_TAG now is always defined to be either 0 or 1.
1705 All uses changed.
1706 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1707 code works fine either way, and efficiency is not a concern here,
1708 as the union type is for debugging, not for production.
1709 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1710 Use an inline function on all platforms when using the union type,
1711 since this is simpler and 'static inline' can be used portably
1712 within Emacs now.
1713 (LISP_INITIALLY_ZERO): New macro.
1714 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1715 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1716
45fa9c0f
GM
17172012-06-12 Glenn Morris <rgm@gnu.org>
1718
b4492cba
GM
1719 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1720
1721 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1722
45fa9c0f
GM
1723 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1724 Move BROKEN_SIGIO to configure.
1725
1726 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1727 Move NO_TERMIO to configure.
1728
0e25d334
CY
17292012-06-12 Chong Yidong <cyd@gnu.org>
1730
1731 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1732 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1733 MagickExportImagePixels is undefined.
1734
43682bb6
PE
17352012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 * image.c (imagemagick_load_image): Remove unused label.
1738
a9be7d2b
GM
17392012-06-11 Glenn Morris <rgm@gnu.org>
1740
1741 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1742 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1743 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1744 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1745
3017f87f
SM
17462012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1747
1748 * alloc.c (make_byte_code): New function.
1749 (Fmake_byte_code): Use it. Don't purify here.
1750 * lread.c (read1): Use it as well to avoid extra allocation.
1751
1b9b4cf4
CY
17522012-06-11 Chong Yidong <cyd@gnu.org>
1753
1754 * image.c (imagemagick_load_image): Implement transparency.
1755
95988fcf
AS
17562012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1757
1758 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1759 account for preceding backslashes. (Bug#11663)
1760
cd4eb164
CY
17612012-06-09 Chong Yidong <cyd@gnu.org>
1762
1763 * term.c: Support italics in capable terminals (Bug#9652).
1764 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1765 (turn_on_face): Output using TS_enter_italic_mode if available.
1766 Don't handle unused blinking and alt-charset cases.
1767 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1768 and tty_alt_charset_p cases.
1769 (tty_capable_p, init_tty): Support italics.
1770
1771 * termchar.h (struct tty_display_info): Add field for italics.
1772 Remove unused blink field.
1773
1774 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1775 Handle slant.
1776
1777 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1778 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1779 tty_alt_charset_p. Add tty_italic_p.
1780
ff88beb8
MA
17812012-06-09 Michael Albinus <michael.albinus@gmx.de>
1782
1783 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1784 dbus_type_is_basic if available.
1785 (xd_extract_signed, xd_extract_unsigned): Rename from
1786 extract_signed and extract_unsigned, respectively. Adapt callers.
1787
44286096
CY
17882012-06-09 Chong Yidong <cyd@gnu.org>
1789
1682701f
CY
1790 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1791
44286096
CY
1792 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1793 case (Bug#9752).
1794
d86feb17
PE
17952012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 * xdisp.c (vmessage): Treat frame message as multibyte.
1798 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1799 would generate the diagnostic "Making \302\247 buffer-local while
1800 let-bound!".
1801
d5c20fe8
EZ
18022012-06-08 Eli Zaretskii <eliz@gnu.org>
1803
1804 * dispnew.c (showing_window_margins_p): Undo last change, which
1805 was done due to an inadvertent commit.
1806 (adjust_frame_glyphs_for_frame_redisplay): Do call
1807 showing_window_margins_p.
1808
513749ee
SM
18092012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1810
1811 * eval.c (Fmake_var_non_special): New primitive.
1812 (syms_of_eval): Defsubr it.
1813 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1814
d4a8f5c1
JB
18152012-06-08 Juanma Barranquero <lekktu@gmail.com>
1816
1817 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1818 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1819
8bbbc977
EZ
18202012-06-08 Eli Zaretskii <eliz@gnu.org>
1821
1822 * alloc.c (allocate_vectorlike): Fix last change.
1823
f3372c87
DA
18242012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1825
1826 Block-based vector allocation of small vectors.
1827 * lisp.h (struct vectorlike_header): New field `nbytes',
1828 adjust comment accordingly.
1829 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1830 to denote vector blocks. Adjust users (live_vector_p,
1831 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1832 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1833 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1834 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1835 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1836 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1837 (roundup_size): New constant.
1838 (struct vector_block): New data type.
1839 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1840 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1841 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1842 (sweep_vectors): New functions.
1843 (allocate_vectorlike): Return `zero_vector' as the only vector of
1844 0 items. Allocate new vector from block if vector size is less than
1845 or equal to VBLOCK_BYTES_MAX.
1846 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1847 (init_alloc_once): Add call to init_vectors.
1848
4f18a4ed
SM
18492012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1850
1851 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1852
86f158bc
PE
18532012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1854
1855 * doprnt.c (doprnt): Truncate multibyte char correctly.
1856 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1857 would mishandle a string argument "Xc" if X was a multibyte
1858 character of length 2: it would truncate after X's first byte
1859 rather than including all of X.
1860
c5cfcbe0
CY
18612012-06-06 Chong Yidong <cyd@gnu.org>
1862
1863 * buffer.c (word_wrap): Doc fix.
1864
c05cf390
PE
18652012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1868
0c3461de
GM
18692012-06-03 Glenn Morris <rgm@gnu.org>
1870
1871 * xdisp.c (tool-bar-style): Doc fix.
1872
c71232db
UM
18732012-06-03 Ulrich Müller <ulm@gentoo.org>
1874
1875 * Makefile.in (PAXCTL): Define.
1876 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1877 binary via PaX flags if the paxctl utility is available.
1878 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1879 Restore PaX flags to their default. (Bug#11398)
1880
383f7350
CY
18812012-06-03 Chong Yidong <cyd@gnu.org>
1882
1883 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1884 buffer (Bug#11226).
1885
5f2c76c6
CY
18862012-06-03 Chong Yidong <cyd@gnu.org>
1887
1888 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1889 (note_mode_line_or_margin_highlight): If there is no help echo,
1890 use mode-line-default-help-echo. Handle the case where the mouse
1891 position is past the end of the mode line string.
1892
1893 * buffer.c (buffer_local_value_1): New function, split from
1894 Fbuffer_local_value; can return Qunbound.
1895 (Fbuffer_local_value): Use it.
1896 (Vmode_line_format): Docstring tweaks.
1897
773d47f6
PE
18982012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1899
1900 * sysdep.c (system_process_attributes): Improve comment.
1901
f2d6a3df
SM
19022012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1903
1904 * keyboard.c: Export real-this-command to Elisp.
1905 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1906 and DEFVAR it. Update all users.
1907
63810350
PE
19082012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1909
7bd5c1f4
PE
1910 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1911
63810350
PE
1912 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1913 Convert pctcpu and pctmem to Lisp float properly.
1914 Let the compiler fold better, as 100.0/0x8000 is exact.
1915
a2821611
AS
19162012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1917
1918 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1919 cons_block.
1920
5fceba1d
PE
19212012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1924
c98ff5dd
DA
19252012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1926
1927 For a 'struct window', replace some Lisp_Object fields to
1928 bitfields where appropriate, remove unused fields.
1929 * window.h (struct window): Remove unused 'last_mark_x' and
1930 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1931 change it's type from Lisp_Object to bitfield.
1932 Change type of 'force_start', 'optional_new_start',
1933 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1934 fields from Lisp_Object to bitfield. Adjust users accordingly.
1935
ca34e0be
PE
19362012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 Pacify gcc -Wdouble-precision when using Xaw.
1939 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1940 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1941 Use 'float' consistently, rather than 'float' in most places
1942 and 'double' in a couple of places.
1943
efc00ab1 19442012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1945
1946 * xdisp.c (handle_stop): Detect whether we have overlay strings
1947 loaded by testing it->current.overlay_string_index to be
1948 non-negative, instead of checking whether n_overlay_strings is
1949 positive. (Bug#11587)
1950
efc00ab1 19512012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1952
1953 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1954
1955 * doc.c (Fsubstitute_command_keys): Doc fix.
1956
efc00ab1 19572012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1958
1959 * search.c (search_buffer): Remove calls to
1960 r_alloc_inhibit_buffer_relocation, as it is now called by
1961 maybe_unify_char, which was the cause of relocation of buffer text
1962 in bug#11519.
1963
efc00ab1 19642012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1965
1966 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1967 for the duration of call to load_charset, to avoid problems with
1968 callers of maybe_unify_char that access buffer text through C
1969 pointers.
1970
1971 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1972 decrement the inhibition flag, instead of just setting or
1973 resetting it.
1974
ba93a187
PE
19752012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 Remove obsolete '#define static' cruft.
1978 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1979 This #undef was "temporary" in 2000; it is no longer needed
1980 now that '#define static' has gone away.
1981 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1982 (gray_bitmap_bits): Remove; no longer needed.
1983 All uses replaced with definiens.
1984 * xterm.c: Include "bitmaps/gray.xbm".
1985
9e4bf381
PE
19862012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1987
1988 Clean up __executable_start, monstartup when --enable-profiling.
1989 The following changes affect the code only when profiling.
1990 * dispnew.c (__executable_start): Rename from safe_bcopy.
1991 Define only on platforms that need it.
1992 * emacs.c: Include <sys/gmon.h> when profiling.
1993 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1994 (__executable_start): Remove decl, since lisp.h does it now.
1995 (safe_bcopy): Remove decl; no longer has that name.
1996 (main): Coalesce #if into single bit of code, for simplicity.
1997 Cast pointers to uintptr_t, since standard libraries want integers
1998 and not pointers.
1999 * lisp.h (__executable_start): New decl.
2000
32d72c2f
GM
20012012-05-31 Glenn Morris <rgm@gnu.org>
2002
2003 * image.c (Fimagemagick_types): Doc fix.
2004
baac5bc7
JM
20052012-05-30 Jim Meyering <meyering@redhat.com>
2006
2007 * callproc.c (Fcall_process_region): Include directory component
2008 in mkstemp error message (Bug#11586).
2009
72cb32cf
PE
20102012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * alloc.c, lisp.h (make_pure_vector): Now static.
2013
61b108cc
SM
20142012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2015
2016 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2017 Move to byte-run.el.
2018 (Fautoload): Do the hash-doc more carefully.
2019 * data.c (Fdefalias): Purify definition, except for keymaps.
2020 (Qdefun): Move from eval.c.
2021 * lisp.h (Qdefun): Remove.
2022 * lread.c (read1): Tiny simplification.
2023
471fe23d
TN
20242012-05-29 Troels Nielsen <bn.troels@gmail.com>
2025
934f3f58 2026 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2027 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2028 Bug#9642, but explicitly check that the buffer the overlay would
2029 be moved to is live and rearrange lines to make sure that errors
2030 will not put the overlay in an inconsistent state.
2031 (Fdelete_overlay): Cosmetics.
2032
85d0efd1
EZ
20332012-05-28 Eli Zaretskii <eliz@gnu.org>
2034
2035 * w32term.c (my_bring_window_to_top): New function.
2036 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2037 could be different from the original one.
2038 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2039 (Bug#11513)
2040
2041 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2042 by calling BringWindowToTop.
2043
2044 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2045 (WM_EMACS_END): Increase by one.
2046
da92a98c
PE
20472012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2048
2049 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2050 This avoids undefined behavior that might cause the eassert
2051 to not catch an out-of-range value.
2052
74d1f848
JB
20532012-05-28 Juanma Barranquero <lekktu@gmail.com>
2054
2055 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2056 Update dependencies.
2057
9e1a06fc
EZ
20582012-05-27 Eli Zaretskii <eliz@gnu.org>
2059
2060 * bidi.c (bidi_mirror_char): Fix last change.
2061
f3dd7312
AS
20622012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2063
2064 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2065 when referring to sectname field in printf format.
2066
81899c91
PE
20672012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2068
57b81a9f
PE
2069 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2070 Only r_alloc_inhibit_buffer_relocation needed to be added;
2071 the others were already declared.
2072
81899c91
PE
2073 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2074 before checking whether it's out of range. Put the check inside
2075 eassert. See
2076 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2077
33017faf 20782012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2079
2080 * callproc.c (Fcall_process): Restore a line that was accidentally
2081 commented out in the 2011-02-13 change (bug#11547).
2082
33017faf 20832012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2084
2085 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2086 defined on ralloc.c.
2087
2088 * buffer.c [REL_ALLOC]: Remove prototypes of
2089 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2090 they are now on lisp.h.
2091
2092 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2093
2094 * search.c (search_buffer): Use it to inhibit relocation of buffer
2095 text while re_search_2 is doing its job, because re_search_2 is
2096 passed C pointers to buffer text. (Bug#11519)
2097
23415acf
EZ
2098 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2099 Update value to 24.
2100
44e27368
EZ
2101 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2102 state after an additional call to move_it_in_display_line_to, keep
2103 the values of it->max_ascent and it->max_descent found for the
2104 entire line.
2105 (pos_visible_p): Revert the comparison against bottom_y to what it
2106 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2107 (Bug#11464)
2108
c1892f11
PE
21092012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 Fix coding-related core dumps with gcc -ftrapv.
2112 The code was computing A - B, where A and B are pointers, and B is
2113 random garbage. This can lead to core dumps on platforms that
2114 have special pointer registers, and it also leads to core dumps on
2115 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2116 A - B only when B is initialized properly.
2117 * coding.c (coding_set_source, coding_set_destination): Return void.
2118 (coding_change_source, coding_change_destinations): New functions,
2119 with the old behaviors of coding_set_source and coding_set_destination.
2120 All callers that need an offset changed to use these new functions.
2121
eb7afdad
GM
21222012-05-26 Glenn Morris <rgm@gnu.org>
2123
2124 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2125
f12fdf02
EZ
21262012-05-26 Eli Zaretskii <eliz@gnu.org>
2127
53a63be6 2128 Extend mouse support on W32 text-mode console.
61b108cc
SM
2129 * xdisp.c (draw_row_with_mouse_face):
2130 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2131
eb3f6f01 2132 * w32console.c: Include window.h.
61b108cc
SM
2133 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2134 New functions.
eb3f6f01
EZ
2135 (initialize_w32_display): Initialize mouse-highlight data.
2136
53a63be6
EZ
2137 * w32inevt.c: Include termchar.h and window.h.
2138 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2139 moves, call note_mouse_highlight. If help_echo changed, call
2140 gen_help_event to produce help-echo message in the echo area.
2141 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2142 highlight info.
2143
4cfd81f6
PE
21442012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 * lread.c (read1): Simplify slightly to avoid an overflow warning
2147 with GCC 4.7.0 on x86-64.
2148
4446092a
EZ
21492012-05-26 Eli Zaretskii <eliz@gnu.org>
2150
2151 * bidi.c (bidi_mirror_char): Revert last change: an int is
2152 definitely wide enough here.
2153
42b2a986 21542012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2155
42b2a986 2156 Fix integer width and related bugs (Bug#9874).
eb106a49 2157 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2158 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2159 (string_bytes, check_sblock, allocate_string_data):
2160 (compact_small_strings, Fmake_bool_vector, make_string)
2161 (make_unibyte_string, make_multibyte_string)
2162 (make_string_from_bytes, make_specified_string)
2163 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2164 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2165 (mark_vectorlike):
2166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2167 (allocate_pseudovector):
2168 Use int, not EMACS_INT, where int is wide enough.
2169 (inhibit_garbage_collection, Fgarbage_collect):
2170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2171 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2172 int might not be wide enough.
2173 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2174 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2175 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2176 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2177 (bidi_level_of_next_char, bidi_move_to_visually_next):
2178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2179 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2180 (Fkill_buffer, Fset_buffer_major_mode)
2181 (advance_to_char_boundary, Fbuffer_swap_text)
2182 (Fset_buffer_multibyte, overlays_at, overlays_in)
2183 (overlay_touches_p, struct sortvec, record_overlay_string)
2184 (overlay_strings, recenter_overlay_lists)
2185 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2186 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2187 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2188 (Foverlay_recenter, last_overlay_modification_hooks_used)
2189 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2191 (validate_region): Omit unnecessary test for b <= e,
2192 since that's guaranteed by the previous test.
d311d28c
PE
2193 (adjust_overlays_for_delete): Avoid pos + length overflow.
2194 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2195 (report_overlay_modification):
2196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2197 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2198 Omit pointer cast, which isn't needed anyway, and doesn't work
2199 after the EMACS_INT -> ptrdiff_t change.
02481186 2200 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2201 * buffer.h: Adjust decls to match defn changes elsewhere.
2202 (struct buffer_text, struct buffer):
2203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2204 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2205 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2206 not int, to avoid needless 32-bit limit on 64-bit hosts.
2207 (exec_byte_code): Use tighter memory-full test, one that checks
2208 for alloca overflow. Don't compute the address of the object just
2209 before an array, as that's not portable. Use EMACS_INT, not
2210 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2211 * callint.c (Fcall_interactively):
2212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2213 * callproc.c (call_process_kill, Fcall_process):
2214 Don't assume pid_t fits into an Emacs fixnum.
2215 (call_process_cleanup, Fcall_process, child_setup):
2216 Don't assume pid_t fits into int.
2217 (call_process_cleanup, Fcall_process, delete_temp_file)
2218 (Fcall_process_region):
2219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2220 (Fcall_process): Simplify handling of volatile integers.
2221 Use int, not EMACS_INT, where int will do.
2222 * casefiddle.c (casify_object, casify_region, operate_on_word)
2223 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2225 (casify_object): Avoid integer overflow when overallocating buffer.
2226 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2227 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2228 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2229 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2230 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2231 integers are now checked earlier. All uses replaced with XINT.
2232 (ccl_driver):
2233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2234 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2235 (ccl_driver, Fregister_code_conversion_map):
2236 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2237 (resolve_symbol_ccl_program): Check that vector header is in range.
2238 Always copy the vector, so that we can check its contents reliably
2239 now rather than having to recheck each instruction as it's being
2240 executed. Check that vector words fit in 'int'.
2241 (ccl_get_compiled_code, Fregister_ccl_program)
2242 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2243 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2244 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2245 contents are in range.
2246 (Fccl_execute_on_string): Check that status is in range.
2247 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2248 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2249 Accept and return EMACS_INT, not int, because callers can pass values
2250 out of 'int' range.
2251 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2252 (multibyte_chars_in_text, parse_str_as_multibyte)
2253 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2254 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2255 (string_escape_byte8, Fget_byte):
2256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2257 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2258 avoid mishandling large integers.
2259 * character.h: Adjust decls to match defn changes elsewhere.
2260 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2261 (Ffind_charset_region):
2262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2263 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2264 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2265 Don't assume fixnum fits in int.
d311d28c
PE
2266 (load_charset_map_from_vector, Fmap_charset_chars):
2267 Remove now-unnecessary CHECK_NATNUMs.
2268 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2269 Don't rely on undefined behavior with signed left shift overflow.
2270 Don't assume unsigned int fits into fixnum, or that fixnum fits
2271 into unsigned int. Don't require max_code to be a valid fixnum;
2272 that's not true for gb10830 4-byte on a 32-bit host. Allow
2273 invalid_code to be a cons, for the same reason. Require code_offset
2274 to be a character. Avoid int overflow if max_char is close
2275 to INT_MAX.
2276 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2277 this is intended anyway and avoids some undefined behavior.
2278 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2279 INDEX_TO_CODE_POINT, as that's what it expects.
2280 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2281 * charset.h (DECODE_CHAR): Return int, not unsigned;
2282 this is what was intended anyway, and it avoids undefined behavior.
2283 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2284 integer-overflow issues.
2285 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2286 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2287 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2288 * chartab.c (Fmake_char_table, Fset_char_table_range)
2289 (uniprop_get_decoder, uniprop_get_encoder):
2290 Don't assume fixnum fits in int.
2291 * cmds.c (move_point): New function, that does the gist of
2292 Fforward_char and Fbackward_char, but does so while checking
2293 for integer overflow more accurately.
c96e5d6a 2294 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2295 (Fforward_line, Fend_of_line, internal_self_insert)
2296 (internal_self_insert):
2297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2298 Fix a FIXME, by checking for integer overflow when calculating
2299 target_clm and actual_clm.
2300 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2301 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2302 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2303 (coding_alloc_by_making_gap, alloc_destination)
2304 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2305 (encode_coding_utf_16, detect_coding_emacs_mule)
2306 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2307 (detect_coding_iso_2022, decode_coding_iso_2022)
2308 (encode_invocation_designation, encode_designation_at_bol)
2309 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2310 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2311 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2312 (encode_coding_ccl, encode_coding_raw_text)
2313 (detect_coding_charset, decode_coding_charset)
2314 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2315 (produce_composition, produce_charset, produce_annotation)
2316 (decode_coding, handle_composition_annotation)
2317 (handle_charset_annotation, consume_chars, decode_coding_gap)
2318 (decode_coding_object, encode_coding_object, detect_coding_system)
2319 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2320 (code_convert_region, code_convert_string)
8f50130c
PE
2321 (Fdefine_coding_system_internal)
2322 (coding_set_source, coding_set_destination):
d311d28c
PE
2323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2324 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2325 (Fdefine_coding_system_internal):
2326 Don't assume fixnums fit in int.
2327 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2328 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2329 (Funencodable_char_position, Fcheck_coding_systems_region)
2330 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2332 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2333 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2334 Don't access memory outside of the args array.
d311d28c 2335 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2336 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2337 result of ENCODE_CHAR.
d311d28c
PE
2338 * coding.h: Adjust decls to match defn changes elsewhere.
2339 (struct coding_system):
2340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2341 * composite.c (get_composition_id, find_composition)
2342 (run_composition_function, update_compositions)
2343 (compose_text, composition_gstring_put_cache)
2344 (composition_gstring_p, composition_gstring_width)
2345 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2346 (composition_compute_stop_pos, composition_reseat_it)
2347 (composition_update_it, struct position_record)
2348 (find_automatic_composition, composition_adjust_point)
2349 (Fcomposition_get_gstring, Ffind_composition_internal):
2350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2351 (update_compositions):
2352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2353 * composite.h: Adjust decls to match defn changes elsewhere.
2354 (struct composition):
2355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2356 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2357 Do not attempt to compute the address of the object just before a
2358 buffer; this is not portable.
2359 (Faref, Faset):
2360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2361 (Faset): Use int, not EMACS_INT, where int is wide enough.
2362 (Fstring_to_number): Don't assume fixnums fit in int.
2363 (Frem): Don't assume arg is nonnegative.
2364 * dbusbind.c (xd_append_arg): Check for integers out of range.
2365 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2366 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2367 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2368 (xd_get_connection_references): Return ptrdiff_t, not int.
2369 All uses changed.
2370 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2371 (xd_read_message_1):
2372 Use int, not unsigned, where the dbus API uses int.
2373 (Fdbus_message_internal): Don't overflow mtype.
2374 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2375 * dired.c (directory_files_internal, file_name_completion, scmp)
2376 (file_name_completion_stat):
2377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2378 (file_name_completion): Don't overflow matchcount.
2379 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2380 * dispextern.h: Adjust decls to match defn changes elsewhere.
2381 (struct text_pos, struct glyph, struct bidi_saved_info)
2382 (struct bidi_string_data, struct bidi_it, struct composition_it)
2383 (struct it):
2384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2385 (struct display_pos, struct composition_it, struct it):
2386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2387 * dispnew.c (increment_matrix_positions)
2388 (increment_row_positions, mode_line_string)
2389 (marginal_area_string):
2390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2391 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2393 (duration_to_sec_usec): New function, to check for overflow better.
2394 (Fsleep_for, sit_for): Use it.
2395 * doc.c (get_doc_string, store_function_docstring):
2396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2397 (get_doc_string, Fsnarf_documentation):
2398 Use int, not EMACS_INT, where int is wide enough.
2399 (get_doc_string):
2400 Use SAFE_ALLOCA, not alloca.
2401 Check for overflow when converting EMACS_INT to off_t.
2402 * doprnt.c (doprnt):
2403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2404 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2405 Don't assume uid_t fits into fixnum.
2406 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2407 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2408 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2409 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2410 (general_insert_function)
2411 (Finsert_char, make_buffer_string, make_buffer_string_both)
2412 (update_buffer_properties, Fbuffer_substring)
2413 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2414 (Fsubst_char_in_region, check_translation)
2415 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2416 (transpose_markers, Ftranspose_regions):
2417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2418 (clip_to_bounds): Move to lisp.h as an inline function).
2419 (Fconstrain_to_field): Don't assume integers are nonnegative.
2420 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2421 (Fsubst_char_in_region, Fsave_restriction):
2422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2423 (Femacs_pid): Don't assume pid_t fits into fixnum.
2424 (lo_time): Use int, not EMACS_INT, when int suffices.
2425 (lisp_time_argument): Check for usec out of range.
2426 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2427 (Fuser_login_name, Fuser_full_name): Signal an error
2428 if a uid argument is out of range, rather than relying on
2429 undefined behavior.
c8d5c857
PE
2430 (Fformat_time_string): Remove now-unnecessary check.
2431 lisp_time_argument checks for out-of-range usec now.
243e0530 2432 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2433 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2434 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2435 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2436 (init_cmdargs, Fdump_emacs):
2437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2438 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2439 the bottom (typically) 32 bits of the fixnum.
2440 * eval.c (specpdl_size, call_debugger):
2441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2442 (when_entered_debugger, Fbacktrace_debug):
2443 Don't assume fixnum can fit in int.
2444 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2445 the object just before a buffer; this is not portable.
2446 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2447 (grow_specpdl, unbind_to):
2448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2449 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2450 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2451 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2452 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2453 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2455 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2456 (a_write, e_write):
2457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2458 (Fcopy_file, non_regular_nbytes, read_non_regular)
2459 (Finsert_file_contents):
2460 Use int, not EMACS_INT, where int is wide enough.
2461 (READ_BUF_SIZE): Verify that it fits in int.
2462 (Finsert_file_contents): Check that counts are in proper range,
2463 rather than assuming fixnums fit into ptrdiff_t etc.
2464 Don't assume fixnums fit into int.
125b3835 2465 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2466 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2467 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2468 (string_char_to_byte, string_byte_to_char)
2469 (string_make_multibyte, string_to_multibyte)
2470 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2471 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2472 (substring_both, Fdelete, internal_equal, Ffillarray)
2473 (Fclear_string, mapcar1)
2474 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2475 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2476 (larger_vector, make_hash_table, maybe_resize_hash_table)
2477 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2478 (Fmaphash, secure_hash):
2479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2480 (concat): Check for string index and length overflow.
2481 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2482 (Frequire):
2483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2484 (larger_vector): New API (vec, incr_min, size_max) replaces old
2485 one (vec, new_size, init). This catches size overflow.
2486 INIT was removed because it was always Qnil.
2487 All callers changed.
2488 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2489 the upper bound on a hash table index size.
2490 (make_hash_table, maybe_resize_hash_table): Use it.
2491 (secure_hash): Computer start_byte and end_byte only after
2492 they're known to be in ptrdiff_t range.
2493 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2494 (Ffont_get_glyphs, Ffont_at):
2495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2496 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2497 (Flist_fonts, Fopen_font):
2498 Don't assume fixnum can fit in int.
2499 (check_gstring): Don't assume index can fit in int.
2500 (font_match_p): Check that fixnum is a character, not a nonnegative
2501 fixnum, since the later code needs to stuff it into an int.
2502 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2503 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2504 conversion overflow issues.
2505 (Fopen_font): Check for integer out of range.
2506 (Ffont_get_glyphs): Don't assume index can fit in int.
2507 * font.h: Adjust decls to match defn changes elsewhere.
2508 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2509 integer overflow.
2510 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2511 printmax_t, where ptrdiff_t is wide enough.
2512 (Finternal_char_font):
2513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2514 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2515 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2516 (Fset_frame_position, x_set_frame_parameters)
2517 (x_set_line_spacing, x_set_border_width)
2518 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2519 Check that fixnums are in proper range for system types.
2520 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2522 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2523 Use SAFE_ALLOCA_LISP, not alloca.
2524 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2525 intptr_t is wide enough.
2526 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2527 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2528 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2529 Check for fixnum out of range.
2530 * ftfont.c (ftfont_list): Don't assume index fits in int.
2531 Check that fixnums are in proper range for system types.
2532 (ftfont_shape_by_flt):
2533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2534 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2536 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2537 Check that fixnums are in proper range for system types.
2538 * gnutls.h: Adjust decls to match defn changes elsewhere.
2539 * gtkutil.c (xg_dialog_run):
2540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2541 (update_frame_tool_bar):
2542 Check that fixnums are in proper range for system types.
2543 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2544 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2545 * indent.c (last_known_column, last_known_column_point):
2546 (current_column_bol_cache):
2547 (skip_invisible, current_column, check_display_width):
2548 (check_display_width, scan_for_column, current_column_1)
2549 (Findent_to, Fcurrent_indentation, position_indentation)
2550 (indented_beyond_p, Fmove_to_column, compute_motion):
2551 (Fcompute_motion, Fvertical_motion):
2552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2553 (last_known_column_modified): Use EMACS_INT, not int.
2554 (check_display_width):
2555 (Fcompute_motion):
2556 Check that fixnums and floats are in proper range for system types.
2557 (compute_motion): Don't assume index or fixnum fits in int.
2558 (compute_motion, Fcompute_motion):
2559 Use int, not EMACS_INT, when it is wide enough.
2560 (vmotion): Omit local var start_hpos that is always 0; that way
2561 we don't need to worry about overflow in expressions involving it.
2562 * indent.h: Adjust decls to match defn changes elsewhere.
2563 (struct position):
2564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2565 Use int, not EMACS_INT, where int is wide enough.
2566 Remove unused members ovstring_chars_done and tab_offset;
2567 all uses removed.
2568 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2569 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2570 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2571 (make_gap, copy_text, insert, insert_and_inherit)
2572 (insert_before_markers, insert_before_markers_and_inherit)
2573 (insert_1, count_combining_before, count_combining_after)
2574 (insert_1_both, insert_from_string)
2575 (insert_from_string_before_markers, insert_from_string_1)
2576 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2577 (adjust_after_replace, adjust_after_insert, replace_range)
2578 (replace_range_2, del_range, del_range_1, del_range_byte)
2579 (del_range_both, del_range_2, modify_region)
2580 (prepare_to_modify_buffer, signal_before_change)
2581 (signal_after_change, Fcombine_after_change_execute):
2582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2583 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2584 (balance_an_interval, split_interval_right, split_interval_left)
2585 (find_interval, next_interval, update_interval)
2586 (adjust_intervals_for_insertion, delete_node, delete_interval)
2587 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2588 (static_offset_intervals, offset_intervals)
2589 (merge_interval_right, merge_interval_left, make_new_interval)
2590 (graft_intervals_into_buffer, temp_set_point_both)
2591 (temp_set_point, set_point, adjust_for_invis_intang)
2592 (set_point_both, move_if_not_intangible, get_property_and_range)
2593 (get_local_map, copy_intervals, copy_intervals_to_string)
2594 (compare_string_intervals, set_intervals_multibyte_1):
2595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2596 * intervals.h: Adjust decls to match defn changes elsewhere.
2597 (struct interval):
2598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2599 * keyboard.c (this_command_key_count, this_single_command_key_start)
2600 (before_command_key_count, before_command_echo_length, echo_now)
2601 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2602 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2603 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2604 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2606 (last_non_minibuf_size, last_point_position, echo_truncate)
2607 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2608 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2609 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2610 (stuff_buffered_input):
2611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2612 (last_auto_save, command_loop_1, read_char):
2613 Use EMACS_INT, not int, to avoid integer overflow.
2614 (record_char): Avoid overflow in total_keys computation.
2615 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2616 * keyboard.h: Adjust decls to match defn changes elsewhere.
2617 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2618 (Fkey_description, Fdescribe_vector, Flookup_key):
2619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2620 (click_position): New function, to check that positions are in range.
2621 (Fcurrent_active_maps):
2622 (describe_command):
2623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2624 (Faccessible_keymaps, Fkey_description):
2625 (preferred_sequence_p):
2626 Don't assume fixnum can fit into int.
2627 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2628 Check for integer overflow in size calculations.
2629 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2630 avoid mishandling large integers.
2631 * lisp.h: Adjust decls to match defn changes elsewhere.
2632 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2633 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2634 (struct Lisp_Marker):
2635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2636 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2637 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2638 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2639 All callers changed.
2640 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2641 Assume the arg has valid form, since it always does.
2642 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2643 unsigned integer system type.
2644 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2645 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2647 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2648 (duration_to_sec_usec): New decl.
2649 * lread.c (read_from_string_index, read_from_string_index_byte)
2650 (read_from_string_limit, readchar, unreadchar, openp)
2651 (read_internal_start, read1, oblookup):
2652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2653 (Fload, readevalloop, Feval_buffer, Feval_region):
2654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2655 (openp): Check for out-of-range argument to 'access'.
2656 (read1): Use int, not EMACS_INT, where int is wide enough.
2657 Don't assume fixnum fits into int.
6efdadfd 2658 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2659 (read_filtered_event): Use duration_to_sec_usec
2660 to do proper overflow checking on durations.
d311d28c
PE
2661 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2662 in size calculation.
2663 (Fexecute_kbd_macro):
2664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2665 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2666 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2667 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2668 (set_marker_both, set_marker_restricted_both, marker_position)
2669 (marker_byte_position, Fbuffer_has_markers_at):
2670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2671 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2672 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2673 It now merely ensures that the menu is large enough, without
2674 necessarily growing it, as this avoids some integer overflow issues.
2675 All callers changed.
2676 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2678 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2679 Use SAFE_ALLOCA_LISP, not alloca.
2680 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2681 to EMACS_INT. Check that fixnums are in proper range for system types.
2682 * minibuf.c (minibuf_prompt_width, string_to_object)
2683 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2684 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2686 (get_minibuffer, read_minibuf_unwind):
2687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2688 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2689 this simplifies overflow checking. All callers changed.
2690 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2691 (Ftest_completion):
2692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2693 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2694 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2695 Check that fixnums are in proper range for system types.
2696 (Fx_create_frame, Fx_show_tip):
2697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2698 * nsfont.m (ns_findfonts, nsfont_list_family):
2699 Don't assume fixnum fits in long.
2700 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2702 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2703 wide enough.
17fdb222 2704 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2706 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2707 (PRINTDECLARE, PRINTPREPARE):
2708 (strout, print_string):
2709 (print, print_preprocess, print_check_string_charset_prop)
2710 (print_object):
2711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2712 (PRINTDECLARE):
2713 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2715 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2716 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2717 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2718 (print_error_message): Use SAFE_ALLOCA, not alloca.
2719 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2720 (print_depth, new_backquote_output, print_number_index):
2721 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2722 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2723 (Fset_process_window_size, Fformat_network_address)
2724 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2725 (sigchld_handler):
d311d28c 2726 Check that fixnums are in proper range for system types.
d44287d4 2727 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2728 Check for process-ids out of pid_t range rather than relying on
2729 undefined behavior.
e4d81efc 2730 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2731 (Fformat_network_address, read_process_output, send_process)
2732 (Fprocess_send_region, status_notify):
2733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2734 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2735 (wait_reading_process_output, read_process_output, exec_sentinel):
2736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2737 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2738 (Faccept_process_output): Use duration_to_sec_usec to do proper
2739 overflow checking on durations.
dde14581
PE
2740 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2741 Don't assume pid_t fits in int.
02481186
PE
2742 * process.h (struct Lisp_Process): Members tick and update_tick
2743 are now of type EMACS_INT, not int.
b62b53e8
PE
2744 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2745 configured --with-wide-int.
d311d28c
PE
2746 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2747 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2748 * search.c (looking_at_1, string_match_1):
2749 (fast_string_match, fast_c_string_match_ignore_case)
2750 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2751 (scan_newline, find_before_next_newline, search_command)
2752 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2753 (set_search_regs, wordify):
2754 (Freplace_match):
2755 (Fmatch_data):
2756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2757 (string_match_1, search_buffer, set_search_regs):
2758 (Fmatch_data):
2759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2760 (wordify): Check for overflow in size calculation.
2761 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2762 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2763 Check that fixnums are in proper range for system types.
2764 * sound.c (struct sound_device)
2765 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2767 (Fplay_sound_internal):
2768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2769 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2770 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2771 (Fparse_partial_sexp):
2772 Don't assume fixnums can fit in int.
2773 (struct lisp_parse_state, find_start_pos, find_start_value)
2774 (find_start_value_byte, find_start_begv)
2775 (update_syntax_table, char_quoted, dec_bytepos)
2776 (find_defun_start, prev_char_comend_first, back_comment):
2777 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2778 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2780 (Finternal_describe_syntax_value): Check that match_lisp is a
2781 character, not an integer, since the code stuffs it into int.
2782 (scan_words, scan_sexps_forward):
2783 Check that fixnums are in proper range for system types.
2784 (Fforward_word):
2785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2786 (scan_sexps_forward):
2787 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2788 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2789 * syntax.h: Adjust decls to match defn changes elsewhere.
2790 (struct gl_state_s):
2791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2792 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2793 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2794 * sysdep.c (wait_for_termination_1, wait_for_termination)
2795 (interruptible_wait_for_termination, mkdir):
2796 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2797 (emacs_read, emacs_write):
2798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2799 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2800 and double all fit in int.
d311d28c
PE
2801 * term.c (set_tty_color_mode):
2802 Check that fixnums are in proper range for system types.
2803 * termhooks.h (struct input_event):
2804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2805 * textprop.c (validate_interval_range, interval_of)
2806 (Fadd_text_properties, set_text_properties_1)
2807 (Fremove_text_properties, Fremove_list_of_text_properties)
2808 (Ftext_property_any, Ftext_property_not_all)
2809 (copy_text_properties, text_property_list, extend_property_ranges)
2810 (verify_interval_modification):
2811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2812 (Fnext_single_char_property_change)
2813 (Fprevious_single_char_property_change):
2814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2815 (copy_text_properties):
2816 Check for integer overflow in index calculation.
d311d28c
PE
2817 * undo.c (last_boundary_position, record_point, record_insert)
2818 (record_delete, record_marker_adjustment, record_change)
2819 (record_property_change):
2820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2821 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2823 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2824 (Fx_hide_tip, Fx_file_dialog):
2825 * w32menu.c (set_frame_menubar):
2826 Use ptrdiff_t, not int, for consistency with rest of code.
2827 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2828 (select_window, Fdelete_other_windows_internal)
2829 (window_scroll_pixel_based, window_scroll_line_based)
2830 (Frecenter, Fset_window_configuration):
2831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2832 (Fset_window_hscroll, run_window_configuration_change_hook)
2833 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2834 (Fscroll_other_window, Frecenter):
d311d28c
PE
2835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2836 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2837 Don't assume fixnum fits in int.
2838 (Fset_window_scroll_bars):
2839 Check that fixnums are in proper range for system types.
2840 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2841 (string_pos, c_string_pos, number_of_chars, init_iterator)
2842 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2843 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2844 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2845 (face_before_or_after_it_pos, handle_invisible_prop)
2846 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2847 (display_prop_intangible_p, string_buffer_position_lim)
2848 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2849 (get_overlay_strings_1, get_overlay_strings)
2850 (iterate_out_of_display_property, forward_to_next_line_start)
2851 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2852 (get_next_display_element, set_iterator_to_next)
2853 (get_visually_first_element, compute_stop_pos_backwards)
2854 (handle_stop_backwards, next_element_from_buffer)
2855 (move_it_in_display_line_to, move_it_in_display_line)
2856 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2857 (add_to_log, message_dolog, message_log_check_duplicate)
2858 (message2, message2_nolog, message3, message3_nolog
2859 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2860 (current_message_1, truncate_echo_area, truncate_message_1)
2861 (set_message, set_message_1, store_mode_line_noprop)
2862 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2863 (text_outside_line_unchanged_p, check_point_in_composition)
2864 (reconsider_clip_changes)
2865 (redisplay_internal, set_cursor_from_row, try_scrolling)
2866 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2867 (redisplay_window, find_last_unchanged_at_beg_row)
2868 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2869 (trailing_whitespace_p, find_row_edges, display_line)
2870 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2871 (display_mode_element, store_mode_line_string)
2872 (pint2str, pint2hrstr, decode_mode_spec)
2873 (display_count_lines, display_string, draw_glyphs)
2874 (x_produce_glyphs, x_insert_glyphs)
2875 (rows_from_pos_range, mouse_face_from_buffer_pos)
2876 (fast_find_string_pos, mouse_face_from_string_pos)
2877 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2879 (safe_call, init_from_display_pos, handle_fontified_prop)
2880 (handle_single_display_spec, load_overlay_strings)
2881 (with_echo_area_buffer, setup_echo_area_for_printing)
2882 (display_echo_area, echo_area_display)
2883 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2884 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2885 (redisplay_window, dump_glyph_row, display_mode_line)
2886 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2887 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2889 (handle_single_display_spec, build_desired_tool_bar_string)
2890 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2891 (get_specified_cursor_type):
2892 Check that fixnums are in proper range for system types.
2893 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2894 (Flookup_image_map):
2895 Don't assume fixnums fit in int.
2896 (compare_overlay_entries):
2897 Avoid mishandling comparisons due to subtraction overflow.
2898 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2899 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2900 (handle_tool_bar_click):
2901 Use int, not unsigned, since we prefer signed and the signedness
2902 doesn't matter here.
2903 (get_next_display_element, next_element_from_display_vector):
2904 Use int, not EMACS_INT, when int is wide enough.
2905 (start_hourglass): Use duration_to_sec_usec to do proper
2906 overflow checking on durations.
2907 * xfaces.c (Fbitmap_spec_p):
2908 Check that fixnums are in proper range for system types.
2909 (compare_fonts_by_sort_order):
2910 Avoid mishandling comparisons due to subtraction overflow.
2911 (Fx_family_fonts, realize_basic_faces):
2912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2913 (Fx_family_fonts):
2914 Don't assume fixnum fits in int.
2915 Use SAFE_ALLOCA_LISP, not alloca.
2916 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2917 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2918 (face_at_buffer_position, face_for_overlay_string)
2919 (face_at_string_position):
2920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2921 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2922 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2923 (Fx_show_tip):
2924 Check that fixnums are in proper range for system types.
2925 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2926 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2928 (Fx_change_window_property): Don't assume fixnums fit in int.
2929 * xfont.c (xfont_chars_supported):
2930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2931 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2932 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2934 * xml.c (parse_region):
2935 * xrdb.c (magic_file_p):
2936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2937 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2938 (x_get_local_selection, x_reply_selection_request)
2939 (x_handle_selection_request, wait_for_property_change):
2940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2941 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2942 short is wide enough.
2943 (x_send_client_event): Don't assume fixnum fits in int.
2944 * xterm.c (x_x_to_emacs_modifiers):
2945 Don't assume EMACS_INT overflows nicely into int.
2946 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2947 may come from Lisp.
2948 (handle_one_xevent): NATNUMP can eval its arg twice.
2949 (x_connection_closed):
2950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2951 * xterm.h: Adjust decls to match defn changes elsewhere.
2952 (struct scroll_bar): Use struct vectorlike_header
2953 rather than rolling our own approximation.
2954 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2955
c6574eb5
GM
29562012-05-25 Glenn Morris <rgm@gnu.org>
2957
2958 * lisp.mk (lisp): Update for more files being compiled now.
2959
e8d32c7e
SM
29602012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2961
48def666
SM
2962 * lread.c: Remove `read_pure' which makes no difference.
2963 (read_pure): Remove var.
2964 (unreadpure): Remove function.
2965 (readevalloop): Don't call read_list with -1 flag.
2966 (read1, read_vector): Don't test read_pure any more.
2967 (read_list): Simplify.
2968
e8d32c7e
SM
2969 * fileio.c, character.h: Minor style tweaks.
2970
4b2addb7
DA
29712012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2972
2973 * window.h (clip_changed): Remove useless declaration.
2974
584461b2
JB
29752012-05-22 Juanma Barranquero <lekktu@gmail.com>
2976
2977 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2978 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2979
34374650
PE
29802012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2981
2982 Remove src/m/*.
2983 This directory predates autoconf and is no longer needed nowadays.
2984 Move its few remaining bits of functionality to where they're needed.
2985 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2986 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2987 * m/template.h: Remove.
2988 * Makefile.in (M_FILE): Remove. All uses removed.
2989 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2990 * lisp.h (USE_LSB_TAG):
2991 * mem-limits.h (EXCEEDS_LISP_PTR):
2992 Use VAL_MAX, not VALBITS, in #if.
2993 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2994 (EMACS_UINT): Define unconditionally now.
2995 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2996 (BITS_PER_EMACS_INT): New constants, replacing
2997 what used to be in config.h, but not useful in #if.
2998 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2999 define them any more.
3000 (VAL_MAX): New macro.
3001 (VALMASK): Use it.
3002 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3003 BITS_PER_EMACS_INT, in #if.
3004 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3005 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3006 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3007 * s/ms-w32.h (DATA_START):
3008 Move here from removed file m/intel386.h.
3009 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3010 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3011
261cb4bb
PE
30122012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3013
3014 Assume C89 or later.
3015 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3016 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3017 (xrealloc):
3018 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3019 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3020 * textprop.c, tparam.c (NULL): Remove.
3021 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3022 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3023 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3024 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3025 * xterm.c (input_signal_count): Assume volatile works.
3026
ff23cd9f
KB
30272012-05-21 Ken Brown <kbrown@cornell.edu>
3028
3029 * xgselect.c (xg_select): Fix first argument in call to 'select'
3030 (bug#11508).
3031
1b170bc6
KB
30322012-05-20 Ken Brown <kbrown@cornell.edu>
3033
3034 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3035 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3036
b2f4d39f
KB
30372012-05-19 Ken Brown <kbrown@cornell.edu>
3038
3039 * xfns.c (x_in_use): Remove `static' qualifier.
3040 * xterm.h (x_in_use): Declare.
3041 * xgselect.c: Include xterm.h.
3042 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3043 and `display_arg' (bug#9754).
3044
003fdae2
PE
30452012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3046
9232a6d9
PE
3047 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3048
003fdae2
PE
3049 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3050 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3051
784b56e2
EZ
30522012-05-18 Eli Zaretskii <eliz@gnu.org>
3053
3054 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3055
3056 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3057 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3058
3059 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3060 reference to image_cache->refcount.
3061 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3062
a0a79cde
JL
30632012-05-17 Juri Linkov <juri@jurta.org>
3064
3065 * search.c (Fword_search_regexp, Fword_search_backward)
3066 (Fword_search_forward, Fword_search_backward_lax)
3067 (Fword_search_forward_lax): Move functions to isearch.el
3068 (bug#10145, bug#11381).
3069
b0572523
PE
30702012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3071
3072 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3073
9660f5fc
SM
30742012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3075
3076 * lread.c (init_obarray): Declare Qt and Qnil as special.
3077
4374de83
GM
30782012-05-14 Glenn Morris <rgm@gnu.org>
3079
3080 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3081 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3082
dc44c39a
PE
30832012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3084
078c97cb
PE
3085 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3086
dc44c39a
PE
3087 * unexaix.c: Port to more-recent AIX compilers.
3088 (report_error, report_error_1, make_hdr, copy_sym)
3089 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3090 Make arguments const char *, not char *, to avoid violations of C
3091 standard and to fix some AIX warnings reported by Gilles Pion.
3092
e18afed7 30932012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3094
3095 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3096 already have overlays loaded.
3097 (handle_single_display_spec): Before returning without displaying
3098 fringe bitmap, synchronize the bidi iterator with the main display
3099 iterator, by calling iterate_out_of_display_property.
3100 (iterate_out_of_display_property): Detect buffer iteration by
3101 testing that it->string is a Lisp string.
3102 (get_next_display_element): When the current object is exhausted,
3103 and there's something on it->stack, call set_iterator_to_next to
3104 proceed with what's on the stack, instead of returning zero.
3105 (set_iterator_to_next): If called at the end of a Lisp string,
3106 proceed to consider_string_end without incrementing string
3107 position. Don't increment display vector index past the end of
3108 the display vector. (Bug#11417)
c8fb9dc6
EZ
3109 (pos_visible_p): Don't report a position visible when move_it_to
3110 stopped at the last line of window, which happens to be scanned
3111 backwards by the bidi iteration. (Bug#11464)
ac268e67 3112
e18afed7 31132012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3114
3115 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3116 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3117 are on a TTY, and thus unable to display on the fringes.
3118 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3119 so we need to signal to the caller that this is a "replacing"
3120 display spec. This fixes display when the spec is invalid or we
3121 are on a TTY.
3122
e18afed7 31232012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3124
3125 * unexaix.c (make_hdr): Fix typo in prototype.
3126 This bug broke the build on AIX. Problem reported by Gilles Pion.
3127
9d0a235a
MA
31282012-05-14 Michael Albinus <michael.albinus@gmx.de>
3129
3130 * keyboard.c (kbd_buffer_get_event): Read special events also in
3131 batch mode. (Bug#11415)
3132
9e6b06ed
GM
31332012-05-12 Glenn Morris <rgm@gnu.org>
3134
3135 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3136
c1a1d7a3
EZ
31372012-05-12 Eli Zaretskii <eliz@gnu.org>
3138
3139 * lisp.mk (lisp): Add newcomment.elc.
3140
3fe7cdc8
GM
31412012-05-12 Glenn Morris <rgm@gnu.org>
3142
3143 * Makefile.in (MKDIR_P): New, set by configure.
3144 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3145
53f7d2c0
PE
31462012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3147
3148 Remove unused function hourglass_started.
3149 * dispextern.h (hourglass_started):
3150 * w32fns.c (hourglass_started):
3151 * xdisp.c (hourglass_started): Remove.
3152
75aafb17
JB
31532012-05-10 Juanma Barranquero <lekktu@gmail.com>
3154
3155 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3156 Update dependencies.
3157
12959e8e
PE
31582012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3159
97107e2e
PE
3160 * xgselect.c (xg_select): Put maxfds+1 into a var.
3161 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3162
12959e8e
PE
3163 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3164
836d29b3
DA
31652012-05-10 Dave Abrahams <dave@boostpro.com>
3166
3167 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3168 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3169
5cb67954
MA
31702012-05-09 Michael Albinus <michael.albinus@gmx.de>
3171
3172 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3173 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3174 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3175 Initialize xd_registered_buses.
3176
3478ec45
PE
31772012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3178
b263a6b0
PE
3179 Untag more efficiently if USE_LSB_TAG.
3180 This is based on a proposal by YAMAMOTO Mitsuharu in
3181 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3182 For an admittedly artificial (nth 8000 longlist) benchmark on
3183 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3184 Emacs's overall text size by 1%.
3185 * lisp.h (XUNTAG): New macro.
3186 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3187 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3188 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3189 * eval.c (Fautoload):
3190 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3191 * frame.h (XFRAME): Use XUNTAG.
3192
3478ec45
PE
3193 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3194 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3195 Remove unportable assumptions about print widths of types like
3196 dbus_uint32_t.
3197 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3198 intptr_t when converting between pointer and integer, to avoid GCC
3199 warnings about wrong width.
3200
666b903b 32012012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3202
3203 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3204 stack for each reader_thread, instead of defaulting to 8MB
3205 determined by the linker. This avoids failures in creating
3206 subprocesses on Windows 7, see the discussion in this thread:
3207 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3208
b120cc17
JC
32092012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3210
3211 Fix up display of the *Minibuf-0* buffer in the mini window.
3212 * keyboard.c (read_char): Don't clear the echo area if there's no
3213 message to clear.
3214 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3215 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3216
9a4b36f8
MA
32172012-05-07 Michael Albinus <michael.albinus@gmx.de>
3218
3219 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3220 batch mode.
3221
e5f9458f
CY
32222012-05-06 Chong Yidong <cyd@gnu.org>
3223
3224 * lisp.mk (lisp): Update.
3225
eceeb5fc 32262012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3227
3228 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3229
71873e2b
SM
32302012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3231
3232 * data.c (PUT_ERROR): New macro.
3233 (syms_of_data): Use it. Add new error type `user-error'.
3234 * undo.c (user_error): New function.
3235 (Fprimitive_undo): Use it.
3236 * print.c (print_error_message): Adjust print style for `user-error'.
3237 * keyboard.c (user_error): New function.
3238 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3239
ab0fa4e4
PE
32402012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3241
3242 Do not limit current-time-string to years 1000..9999.
3243 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3244 (Fcurrent_time_string): Support any year that is supported by the
3245 underlying localtime representation. Don't use asctime, as it
3246 has undefined behavior for years outside the range -999..9999.
3247
7ed806a7
PE
32482012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3249
3250 Fix race conditions involving setenv, gmtime, localtime, asctime.
3251 Without this fix, interrupts could mess up code that uses these
3252 nonreentrant functions, since setting TZ invalidates existing
3253 tm_zone or tzname values, and since most of these functions return
3254 pointers to static storage.
3255 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3256 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3257 Grow the critical sections to include not just invoking
3258 localtime/gmtime, but also accessing these functions' results
3259 including their tm_zone values if any, and any related TZ setting.
3260 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3261 so that the struct tm is saved in the critical section.
3262 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3263 motivated by the fact that memory allocation needs to be outside
3264 the critical section.
3265
0c16dfed
DA
32662012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3267
3268 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3269 with RESET_INTERVAL.
3270
3271 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3272 Remove duplicated buffer name initialization.
3273
3f83ace8
JM
32742012-05-02 Jim Meyering <jim@meyering.net>
3275
3276 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3277
c7b8541e
JM
3278 * xfns.c (x_window): Use xstrdup (Bug#11375).
3279
90207a15 32802012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3281
3282 * xdisp.c (pos_visible_p): If already at a newline from the
3283 display string before the 'while' loop, don't walk back the glyphs
3284 from it3.glyph_row. Solves assertion violation when the display
3285 string begins with a newline (egg.el). (Bug#11367)
3286
b593d6a9
AH
32872012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3288
3289 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3290 Move to simple.el.
3291
4737362e
GM
32922012-05-01 Glenn Morris <rgm@gnu.org>
3293
99cf43f9
GM
3294 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3295 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3296 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3297 All were removed before 23.1.
3298
9311dcff
GM
3299 * dispnew.c: Remove HAVE_LIBNCURSES test;
3300 it is always true on relevant platforms.
3301
4d5c6349
GM
3302 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3303 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3304
4737362e
GM
3305 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3306
74dd3a6b
AS
33072012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3308
3309 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3310 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3311 Remove.
3312
13c379ee
PE
33132012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3314
3315 Do not avoid creating empty evaporating overlays (Bug#9642).
3316 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3317 That is, do not delete an evaporating overlay if it becomes
3318 empty after its bounds are adjusted to fit within its buffer.
3319 This fix caused other problems, and I'm reverting it until we get
3320 to the bottom of them.
3321
a8e7d6d7 33222012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3323
3324 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3325
a8e7d6d7 33262012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3327
3328 * xdisp.c (pos_visible_p): If the window start position is beyond
3329 ZV, start the display from buffer beginning. Prevents assertion
3330 violation in init_iterator when the minibuffer window is scrolled
3331 via the scroll bar.
3332
3333 * window.c (window_scroll_pixel_based): Likewise.
3334
a8e7d6d7 33352012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3336
3337 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3338
a8e7d6d7 33392012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3340
3341 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3342 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3343
a8e7d6d7 33442012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3345
b593d6a9
AH
3346 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3347 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3348
1c6900d9
EZ
33492012-04-26 Eli Zaretskii <eliz@gnu.org>
3350
4c3fa1d9
EZ
3351 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3352 display element, check also the underlying string or buffer
3353 character. (Bug#11341)
3354
1c6900d9
EZ
3355 * w32menu.c: Include w32heap.h.
3356 (add_menu_item): If the call to AppendMenuW (via
3357 unicode_append_menu) fails, disable Unicode menus only if we are
3358 running on Windows 9X/Me.
3359
42bf8205
AS
33602012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3361
3362 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3363 (xgetint): Add missing shift for LSB tags.
3364
b1bac16e
MR
33652012-04-24 Martin Rudalics <rudalics@gmx.at>
3366
3367 * keyboard.c (read_char): Don't wipe echo area for select window
3368 events: These might get delayed via `mouse-autoselect-window'
3369 (Bug#11304).
3370
d69621cc
JB
33712012-04-24 Juanma Barranquero <lekktu@gmail.com>
3372
3373 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3374 manipulation of :loaded-from data.
3375
02fd101b
JB
33762012-04-23 Juanma Barranquero <lekktu@gmail.com>
3377
3378 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3379 now a cons (bug#11311).
3380
888bec30
PE
33812012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3382
89a438bd
PE
3383 Do not create empty overlays with the evaporate property (Bug#9642).
3384 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3385 if it becomes empty after its bounds are adjusted to fit within
3386 its buffer. Without this fix, in a nonempty buffer (let ((o
3387 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3388 yields an empty overlay that has the evaporate property, which is
3389 not supposed to happen.
3390
1068fe4d
PE
3391 Fix minor GTK3 problems found by static checking.
3392 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3393 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3394 (struct _EmacsFixedClass, emacs_fixed_get_type):
3395 Move decls here from emacsgtkfixed.h, since they needn't be public.
3396 (emacs_fixed_get_type): Now static.
3397 (emacs_fixed_class_init): Omit unused local.
3398 (emacs_fixed_child_type): Remove; unused.
3399 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3400 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3401 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3402 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3403 (EMACS_FIXED_GET_CLASS): Remove; unused.
3404 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3405
888bec30
PE
3406 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3407 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3408
de85e130
PE
34092012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3410
d0baac98 3411 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3412 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3413 (__malloc_size_t, __malloc_ptrdiff_t):
3414 Remove. All uses removed, replaced by the definiens if needed,
3415 since we can assume C89 or better now.
3416 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3417 (protect_malloc_state, align, get_contiguous_space)
3418 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3419 (malloc_atfork_handler_child, malloc_enable_thread)
3420 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3421 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3422 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3423 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3424 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3425 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3426 Define using prototypes, not old style.
3427 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3428 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3429 (align): Don't assume that signed integer overflow wraps around.
3430 Omit unused local var.
3431 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3432 (_free_internal_nolock, memalign, mallochook, reallochook):
3433 Omit no-longer-needed casts.
3434 (valloc): Use getpagesize, not __getpagesize.
3435 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3436 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3437
de85e130
PE
3438 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3439
dcbf5805
MA
34402012-04-22 Michael Albinus <michael.albinus@gmx.de>
3441
3442 Move functions from C to Lisp. Make non-blocking method calls
3443 the default. Implement further D-Bus standard interfaces.
3444
3445 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3446 (QCdbus_request_name_allow_replacement)
3447 (QCdbus_request_name_replace_existing)
3448 (QCdbus_request_name_do_not_queue)
3449 (QCdbus_request_name_reply_primary_owner)
3450 (QCdbus_request_name_reply_in_queue)
3451 (QCdbus_request_name_reply_exists)
3452 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3453 (QCdbus_registered_serial, QCdbus_registered_method)
3454 (QCdbus_registered_signal): New Lisp objects.
3455 (XD_DEBUG_MESSAGE): Use sizeof.
3456 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3457 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3458 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3459 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3460 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3461 (xd_signature, xd_append_arg): Allow float for integer types.
3462 (xd_get_connection_references): New function.
b593d6a9
AH
3463 (xd_get_connection_address): Rename from xd_initialize.
3464 Return cached address.
dcbf5805
MA
3465 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3466 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3467 level.
3468 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3469 Return number of refcounts.
dcbf5805
MA
3470 (Fdbus_get_unique_name): Make stronger parameter check.
3471 (Fdbus_message_internal): New defun.
3472 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3473 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3474 (Fdbus_send_signal, Fdbus_register_service)
3475 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3476 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3477 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3478 (Vdbus_compiled_version, Vdbus_runtime_version)
3479 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3480 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3481 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3482 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3483 Adapt docstring.
dcbf5805 3484
52828e02
PE
34852012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3486
da05bc4c
PE
3487 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3488 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3489 Do not assume ptrdiff_t is the same width as 'int'.
3490
52828e02
PE
3491 * alloc.c: Handle unusual debugging option combinations.
3492 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3493 since the two debugging options are incompatible.
3494 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3495 is defined.
3496 (mem_init, mem_insert, mem_insert_fixup):
3497 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3498 (NEED_MEM_INSERT): Remove; no longer needed.
3499
f01769f9
LL
35002012-04-22 Leo Liu <sdl.web@gmail.com>
3501
3502 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3503
5790543d
PE
35042012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3505
3506 * sysdep.c [__FreeBSD__]: Minor cleanups.
3507 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3508 Use Emacs indenting style more consistently. Avoid some casts.
3509 Use 'double' consistently rather than mixing 'float' and 'double'.
3510
b91b7e4d
EW
35112012-04-21 Eduard Wiebe <usenet@pusto.de>
3512
b593d6a9
AH
3513 * sysdep.c (list_system_processes, system_process_attributes):
3514 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3515
6114eb15
AS
35162012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3517
3518 * lisp.mk (lisp): Update.
3519
2f38dff7
PE
35202012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3523 It is never used otherwise.
3524
4ae29f89
SM
35252012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3526
3527 * print.c (print_preprocess): Only check print_depth if print-circle
3528 is nil.
3529 (print_object): Check for cycles even when print-circle is nil and
3530 print-gensym is t, but only check print_depth if print-circle is nil.
3531
f30d612a
CY
35322012-04-20 Chong Yidong <cyd@gnu.org>
3533
3534 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3535 set the status to "failed" and ensure that sentinel is run.
3536
c07a4c0b 35372012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3538
3539 * process.c (Fset_process_inherit_coding_system_flag)
3540 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3541 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3542
c07a4c0b 35432012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3544
3545 * xdisp.c (string_buffer_position_lim): Limit starting position to
3546 BEGV.
3547 (set_cursor_from_row): If called for a mode-line or header-line
3548 row, return zero immediately.
3549 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3550 farther than the first row after the header line, if any.
3551 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3552 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3553
c07a4c0b 35542012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3555
4ae29f89
SM
3556 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3557 (bug#11238).
ad3a2b41 3558
c07a4c0b 35592012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 35602012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3561
3562 configure: new option --enable-gcc-warnings (Bug#11207)
3563 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3564 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3565 (ALL_CFLAGS): Use new macros rather than old.
3566 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3567 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3568 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3569 -Wunused-result, -Wunused-variable. This should go away once
3570 the Emacs and Gnulib regex code is merged.
3571 (xmalloc, xrealloc): Now static.
3572
aba027e8
PE
35732012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * dired.c (Fsystem_groups): Remove unused local.
3576
e5a36063
GM
35772012-04-17 Glenn Morris <rgm@gnu.org>
3578
3579 * dired.c (Fsystem_users): Doc fix.
3580
316411f0
DA
35812012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3582
3583 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3584 (syms_of_dired): Add them.
3585
9426aba4
PE
35862012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3587
b62a57be
PE
3588 Fix minor alloc.c problems found by static checking.
3589 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3590 New extern decls, to avoid calling undeclared functions.
3591 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3592 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3593 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3594 (NEED_MEM_INSERT): New macro.
3595 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3596 Remove one incorrect comment and fix another.
b62a57be 3597
3539f31f
PE
3598 Fix minor ralloc.c problems found by static checking.
3599 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3600 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3601 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3602 (r_alloc_sbrk): Now static.
3603
a041960a
PE
3604 Improve ralloc.c interface checking.
3605 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3606 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3607 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3608 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3609 [REL_ALLOC]: ... to here, to check interface.
3610 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3611 Remove decls. This fixes an "It stinks!".
3612
9426aba4
PE
3613 * alloc.c (which_symbols): Fix alignment issue / type clash.
3614
d55c12ed
AS
36152012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3616
3617 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3618 (struct Lisp_Misc_Any): Likewise.
3619 (struct Lisp_Free): Likewise.
3620 * alloc.c (union aligned_Lisp_Symbol): Define.
3621 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3622 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3623 (union aligned_Lisp_Misc): Define.
3624 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3625 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3626 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3627
b948ce8b
PE
36282012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3631 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3632 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3633 * s/netbsd.h, s/sol2-6.h:
3634 Remove definition of GC_MARK_STACK, since the default now works.
3635 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3636 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3637 no longer the default.
3638 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3639
35dc09a1 36402012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3641
35dc09a1
GM
3642 * lread.c (lisp_file_lexically_bound_p):
3643 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3644
35dc09a1
GM
36452012-04-14 Eli Zaretskii <eliz@gnu.org>
3646
3647 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3648 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3649
36502012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3651
3652 * nsterm.m (constrainFrameRect): Always constrain when there is only
3653 one screen (Bug#10962).
3654
bcd86815
KB
36552012-04-13 Ken Brown <kbrown@cornell.edu>
3656
3657 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3658
c25df26e
RT
36592012-04-13 Reuben Thomas <rrt@sc3d.org>
3660
3661 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3662
0fc59f1e
DC
36632012-04-11 Daniel Colascione <dancol@dancol.org>
3664
3665 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3666 against is gone. It's better to use vfork now so that when Cygwin
3667 gains a new, working vfork, we use it automatically (bug#10398).
3668
de8c03dc
SM
36692012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3670
3671 * window.c (save_window_save): Obey window-point-insertion-type.
3672
2f097256
GM
36732012-04-11 Glenn Morris <rgm@gnu.org>
3674
3675 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3676
453b951e
SM
36772012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3678
3679 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3680
75f1671a 36812012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3682
3683 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3684 (force_quit_count): New var.
3685 (handle_interrupt): Use it.
3686
2a8ce227
JB
36872012-04-10 Juanma Barranquero <lekktu@gmail.com>
3688
3689 * w32.c (w32_delayed_load): Record the full path of the library
3690 being loaded (bug#10424).
3691
935396c0
GM
36922012-04-09 Glenn Morris <rgm@gnu.org>
3693
05920a43
GM
3694 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3695 not just in the obarray, before snarfing them. (Bug#11036)
3696
935396c0
GM
3697 * Makefile.in ($(leimdir)/leim-list.el):
3698 Pass EMACS rather than BUILT_EMACS.
3699
a18ecafa
TZ
37002012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3701
3702 * process.c (make_process):
3703 * process.h: Add integer `gnutls_handshakes_tried' member to
3704 process struct.
3705
6bbef4e5
JC
3706 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3707 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3708
3709 * gnutls.c (gnutls_log_function2i): Convenience log function.
3710 (emacs_gnutls_read): Use new log functions,
3711 `gnutls_handshakes_tried' process member, and
3712 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3713 attempts per process (connection).
3714
b4d3bc10
CY
37152012-04-09 Chong Yidong <cyd@gnu.org>
3716
3717 * eval.c (Fuser_variable_p, user_variable_p_eh)
3718 (lisp_indirect_variable): Functions deleted.
3719 (Fdefvar): Caller changed.
3720
3721 * callint.c (Finteractive, Fcall_interactively):
3722 * minibuf.c (Fread_variable): Callers changed.
3723
70f4d973
EZ
37242012-04-09 Eli Zaretskii <eliz@gnu.org>
3725
3726 * xdisp.c (set_cursor_from_row): If the display string appears in
3727 the buffer at position that is closer to point than the position
3728 after the display string, display the cursor on the first glyph of
3729 the display string. Fixes cursor display when a 'display' text
3730 property immediately follows invisible text. (Bug#11094)
3731
cb3c2e3e
PE
37322012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 composite.c: use 'double' consistently
3735 * composite.c (get_composition_id): Use 'double' consistently
3736 instead of converting 'float' to 'double' and vice versa; this is
3737 easier to understand and avoids a GCC warning.
3738
fd06db5d
GM
37392012-04-09 Glenn Morris <rgm@gnu.org>
3740
50fe702a
GM
3741 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3742 preparation for dumping it with emacs. (Bug#4789)
3743 (leimdir): New variable.
3744 ($(leimdir)/leim-list.el): New rule.
3745 (emacs$(EXEEXT)): Depend on leim-list.el.
3746
fd06db5d
GM
3747 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3748 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3749 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3750
55c131ee
AS
37512012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3752
3753 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3754 proper alignment.
3755
9209588f
JB
37562012-04-07 Juanma Barranquero <lekktu@gmail.com>
3757
3758 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3759 Remove unused local variable.
3760
e3fb2efb
PE
37612012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3762
3763 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3764 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3765 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3766 objects, as mark_maybe_pointer will catch them otherwise.
3767 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3768 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3769
b5385551
PE
37702012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3771
3772 Fix typo that broke non-Windows builds.
3773 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3774
9078ead6
EZ
37752012-04-07 Eli Zaretskii <eliz@gnu.org>
3776
3777 Support building on MS-Windows with libxml2.
3778
3779 * makefile.w32-in (OBJ2): Add xml.$(O).
3780 (GLOBAL_SOURCES): Add xml.c.
3781 ($(BLD)/xml.$(O)): New dependency list.
3782
3783 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3784 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3785 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3786 [!WINDOWSNT]: New macros.
3787 (init_libxml2_functions, libxml2_loaded_p): New functions.
3788 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3789 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3790 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3791 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3792 linked in).
6bbef4e5
JC
3793 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3794 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3795 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3796
3797 * emacs.c: Don't include libxml/parser.h.
3798 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3799 xmlCleanupParser directly.
3800
3801 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3802
3811fdf3
EZ
38032012-04-07 Eli Zaretskii <eliz@gnu.org>
3804
3805 * indent.c (Fvertical_motion): If there is a display string at
3806 point, use it.vpos to compute how many lines to backtrack after
3807 move_it_to point. (Bug#11133)
3808
2f8e16b2
EZ
38092012-04-06 Eli Zaretskii <eliz@gnu.org>
3810
3811 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3812 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3813 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3814 macros related to unification of CJK characters. For the details,
3815 see the discussion following the message here:
3816 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3817
3d439cd1
CY
38182012-04-04 Chong Yidong <cyd@gnu.org>
3819
3820 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3821
8bc53d00
EZ
38222012-04-01 Eli Zaretskii <eliz@gnu.org>
3823
3824 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3825 instead of alloca. (Bug#11138)
3826
3b0512a3
AS
38272012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3828
3829 * w32menu.c (is_simple_dialog): Properly check lisp types.
3830 (Bug#11141)
3831
8427ddd2
EZ
38322012-03-31 Eli Zaretskii <eliz@gnu.org>
3833
979022ef
EZ
3834 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3835 position we get to after a call to move_it_to fails the
3836 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3837 only if we wind up in a string from display property. (Bug#11063)
3838
a6b1c7cc
EZ
3839 * window.c (Fdelete_other_windows_internal): Invalidate the row
3840 and column information about mouse highlight, so that redisplay
3841 restores it after reallocating the glyph matrices. (Bug#7464)
3842
8427ddd2
EZ
3843 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3844 string comes from a `display' text property, use the buffer
3845 position of that property as if we actually saw that position in
3846 the row's glyphs.
697ba24b
EZ
3847 (move_it_by_lines): Remove the assertion that
3848 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3849 violated when there's a before-string at the beginning of a line.
3850 (Bug#11063)
8427ddd2 3851
65a0a738
EZ
38522012-03-30 Eli Zaretskii <eliz@gnu.org>
3853
3854 * xdisp.c (append_space_for_newline): If the default face was
3855 remapped, use the remapped face for the appended newline.
3856 (extend_face_to_end_of_line): Use the remapped default face for
3857 extending the face to the end of the line.
3858 (display_line): Call extend_face_to_end_of_line when the default
3859 face was remapped. (Bug#11068)
3860
581355cc
EZ
38612012-03-29 Eli Zaretskii <eliz@gnu.org>
3862
3863 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3864
e8fc049f
SM
38652012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3866
3867 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3868
4fb9a543
GM
38692012-03-27 Glenn Morris <rgm@gnu.org>
3870
3871 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3872 Doc fixes.
3873
679910f1
KH
38742012-03-26 Kenichi Handa <handa@m17n.org>
3875
3876 * dispextern.h (struct glyph): Fix previous change. Change the
3877 bit length of glyphless.ch to 25 (Bug#11082).
3878
90d49b7f
CY
38792012-03-26 Chong Yidong <cyd@gnu.org>
3880
3881 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3882 (command_loop_1): Use it; inhibit selection update for
3883 handle-select-window too (Bug#8996).
3884
f514f6f0
FP
38852012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3886
e8fc049f 3887 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3888
bf43fa51
KH
38892012-03-25 Kenichi Handa <handa@m17n.org>
3890
3891 * dispextern.h (struct glyph): Change the bit length of
3892 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3893
8a0c01dd
EZ
38942012-03-24 Eli Zaretskii <eliz@gnu.org>
3895
3896 * s/ms-w32.h (tzname): Include time.h before redirecting to
3897 _tzname. Fixes the MSVC build. (Bug#9960)
3898
7d1c3a76
AS
38992012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3900
8ed79523
AS
3901 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3902 characters.
3903
7d1c3a76
AS
3904 * xterm.c (XTread_socket): Only modify handling_signal if
3905 !SYNC_INPUT. (Bug#11080)
3906
e99a9b8b
EZ
39072012-03-23 Eli Zaretskii <eliz@gnu.org>
3908
3909 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3910 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3911 when fetching a multibyte character consumes more bytes than
3912 CHAR_BYTES returns, due to unification of CJK characters in
3913 string_char. (Bug#11073)
3914
5063c0e1
TN
39152012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3916
3917 * process.c (wait_reading_process_output): Handle pty disconnect
3918 by refraining from sending oneself a SIGCHLD (bug#10933).
3919
9f851fbd
CY
39202012-03-22 Chong Yidong <cyd@gnu.org>
3921
3922 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3923
5063c0e1 3924 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3925 Mark string as coming from a prefix property.
3926 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3927 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3928
fb5b8aca
CY
39292012-03-21 Chong Yidong <cyd@gnu.org>
3930
3931 * xfaces.c (Vface_remapping_alist): Doc fix.
3932
62356a1b
EZ
39332012-03-20 Eli Zaretskii <eliz@gnu.org>
3934
3935 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3936 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3937 Doc fixes.
62356a1b 3938
025de85b
CY
39392012-03-20 Chong Yidong <cyd@gnu.org>
3940
3941 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3942 to reflect default non-nil value of redisplay-dont-pause.
3943
4827f94e
KH
39442012-03-19 Kenichi Handa <handa@m17n.org>
3945
3946 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3947 it fit in a valid range (Bug#11003).
3948
e50a24a2
EZ
39492012-03-18 Eli Zaretskii <eliz@gnu.org>
3950
3951 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3952 that is not from display property, accept the row as a "cursor
3953 row" if one of the string's character has a non-nil `cursor'
3954 property. Fixes cursor positioning when there are newlines in
3955 overlay strings, e.g. in icomplete.el. (Bug#11035)
3956
9af5ed87
PE
39572012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3960
d1f55f16
CY
39612012-03-12 Chong Yidong <cyd@gnu.org>
3962
3963 * eval.c (inhibit_lisp_code): Rename from
3964 inhibit_window_configuration_change_hook; move from window.c.
3965
3966 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3967 * window.c (run_window_configuration_change_hook)
3968 (syms_of_window): Callers changed.
3969
66c5eebd
CY
39702012-03-11 Chong Yidong <cyd@gnu.org>
3971
413df973
CY
3972 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3973
66c5eebd
CY
3974 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3975
1de11f56
CY
39762012-03-10 Chong Yidong <cyd@gnu.org>
3977
3978 * frame.c (other_visible_frames): Don't assume the selected frame
3979 is visible (Bug#10955).
3980
cae07000
SM
39812012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3982
3983 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3984
89c94350
JD
39852012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3986
3987 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3988 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3989 zero (Bug#10954).
3990
999dd333
GM
39912012-03-03 Glenn Morris <rgm@gnu.org>
3992
01a6dcc8 3993 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3994
de0100f2
EZ
39952012-03-02 Eli Zaretskii <eliz@gnu.org>
3996
3997 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3998 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3999 (redisplay_window, next_element_from_string): Fix typos in
4000 comments.
3e441275
EZ
4001 (redisplay_window): Pass to move_it_vertically the margin in
4002 pixels, not in screen lines.
de0100f2 4003
96a72ee9
GM
40042012-03-02 Glenn Morris <rgm@gnu.org>
4005
4006 * buffer.c (buffer-list-update-hook): Doc fix.
4007
312508d7
EZ
40082012-02-29 Eli Zaretskii <eliz@gnu.org>
4009
4010 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4011 push_it before setting up the iterator for the first overlay
4012 string, even if we have an empty string loaded.
4013 (next_overlay_string): If there's an empty string on the iterator
4014 stack, pop the stack. (Bug#10903)
4015
27f3c637
PE
40162012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4017
4018 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4019 Suggested by Stefan Monnier in
4020 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4021 * alloc.c (widen_to_Lisp_Object): New static function.
4022 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4023 and widening them to Lisp_Objects. This would work even if
4024 USE_LSB_TAG is defined and wide integers are used, which might
4025 happen in a future version of Emacs.
4026
3c9dfce6
CY
40272012-02-25 Chong Yidong <cyd@gnu.org>
4028
fa74b241
CY
4029 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4030 Doc fix.
4031
3c9dfce6
CY
4032 * xselect.c (Fx_selection_exists_p): Doc fix.
4033 (x_clipboard_manager_save_all): Print an informative message
4034 before saving to clipboard manager.
4035
9486df08
CY
40362012-02-24 Chong Yidong <cyd@gnu.org>
4037
4038 * keyboard.c (process_special_events): Handle all X selection
4039 requests in kbd_buffer, not just the next one (Bug#8869).
4040
f01d3321
CY
40412012-02-23 Chong Yidong <cyd@gnu.org>
4042
4043 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4044 call when setting menu-bar-lines and tool-bar-lines parameters.
4045 (unwind_create_frame_1): New helper function.
4046
4047 * window.c (inhibit_window_configuration_change_hook): New var.
4048 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4049 (syms_of_window): Initialize it.
f01d3321 4050
86b847b6
CY
40512012-02-22 Chong Yidong <cyd@gnu.org>
4052
4053 * xterm.c (x_draw_image_relief): Add missing type check for
4054 Vtool_bar_button_margin (Bug#10743).
4055
a59225b1
CY
40562012-02-21 Chong Yidong <cyd@gnu.org>
4057
4058 * fileio.c (Vfile_name_handler_alist): Doc fix.
4059
4060 * buffer.c (Fget_file_buffer): Protect against invalid file
4061 handler return value.
4062
310f5bd4
PE
40632012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4064
cb3a28cc
PE
4065 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4066 when computing $valmask.
4067
310f5bd4
PE
4068 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4069 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4070 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4071 It's useless in that case, and it can cause problems on hosts
4072 that allocate halves of EMACS_INT values separately.
4073 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4074 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4075 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4076 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4077 it avoids undefined behavior on hosts where shifting right by more
4078 than the word width has undefined behavior.
4079
2375c96a
CY
40802012-02-19 Chong Yidong <cyd@gnu.org>
4081
4082 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4083 (Funhandled_file_name_directory, Ffile_name_as_directory)
4084 (Fdirectory_file_name, Fexpand_file_name)
4085 (Fsubstitute_in_file_name): Protect against invalid file handler
4086 return values (Bug#10845).
4087
3eb49e71
EZ
40882012-02-18 Eli Zaretskii <eliz@gnu.org>
4089
4090 * .gdbinit (pitx): Fix incorrect references to fields of the
4091 iterator stack.
4092
7b926f3f
CY
40932012-02-17 Chong Yidong <cyd@gnu.org>
4094
4095 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4096
11273115
PE
40972012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4100 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4101
c3a70e2b
CY
41022012-02-15 Chong Yidong <cyd@gnu.org>
4103
4104 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4105 marked as special. Also, starting docstrings with * is obsolete.
4106
0ca43699
AS
41072012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4108
4109 * gnutls.c (emacs_gnutls_write): Fix last change.
4110
2e8f3c56
LI
41112012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4112
4113 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4114 send_process.
4115
af70074f
SM
41162012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4117
4118 * keymap.c (Fsingle_key_description): Handle char ranges.
4119
95986d52
CY
41202012-02-12 Chong Yidong <cyd@gnu.org>
4121
afd83bd1
CY
4122 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4123 as that creates a dangerous corner case.
4124
95986d52
CY
4125 * window.c (Fdelete_window_internal): Invalidate the mouse
4126 highlight (Bug#9904).
4127
bd7da63e
GM
41282012-02-12 Glenn Morris <rgm@gnu.org>
4129
4130 * xselect.c (Fx_own_selection_internal)
4131 (Fx_get_selection_internal, Fx_disown_selection_internal)
4132 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4133 * nsselect.m (Fx_own_selection_internal)
4134 (Fx_disown_selection_internal, Fx_selection_exists_p)
4135 (Fx_selection_owner_p, Fx_get_selection_internal):
4136 Sync docs and argument specs with the xselect.c versions.
4137
77abcbc2
LI
41382012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4139
4140 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4141
90b671e2
EZ
41422012-02-11 Eli Zaretskii <eliz@gnu.org>
4143
1c0ca0b7
EZ
4144 * w32select.c (Fx_selection_exists_p): Sync doc string and
4145 argument list with xselect.c. (Bug#10783)
4146
4147 * w16select.c (Fx_selection_exists_p): Sync doc string and
4148 argument list with xselect.c. (Bug#10783)
90b671e2 4149
49241268
GM
41502012-02-10 Glenn Morris <rgm@gnu.org>
4151
4152 * fns.c (Fsecure_hash): Doc fix.
4153
f998bbe7 41542012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4155
4156 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4157
0992bd9c
CY
41582012-02-07 Chong Yidong <cyd@gnu.org>
4159
4160 * buffer.c (Fbuffer_local_variables)
4161 (buffer_lisp_local_variables): Handle unbound vars correctly;
4162 don't let Qunbound leak into Lisp.
4163
af008560
GM
41642012-02-07 Glenn Morris <rgm@gnu.org>
4165
dd605cc4
GM
4166 * image.c (Fimagemagick_types): Doc fix.
4167
af008560
GM
4168 * image.c (imagemagick-render-type): Change it from a lisp object
4169 to an integer. Move the doc here from the lisp manual.
4170 Treat all values not equal to 0 the same.
4171
1449fa1d
CY
41722012-02-06 Chong Yidong <cyd@gnu.org>
4173
4174 * doc.c (store_function_docstring): Avoid applying docstring of
4175 alias to base function (Bug#2603).
4176
3723ec07
AS
41772012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4178
4179 * .gdbinit (pp1, pv1): Remove redundant defines.
4180 (pr): Use pp.
4181
79c1cc1e
CY
41822012-02-04 Chong Yidong <cyd@gnu.org>
4183
4184 * nsterm.m: Declare a global (Bug#10694).
4185
d7f29f8e
EZ
41862012-02-04 Eli Zaretskii <eliz@gnu.org>
4187
cae07000
SM
4188 * w32.c (get_emacs_configuration_options):
4189 Include --enable-checking, if specified, in the return value.
d7f29f8e 4190
3b95a6f9
MR
41912012-02-04 Martin Rudalics <rudalics@gmx.at>
4192
4193 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4194 after rounding frame sizes. (Bug#9723)
4195
d6fa96a6
EZ
41962012-02-04 Eli Zaretskii <eliz@gnu.org>
4197
4198 * keyboard.c (adjust_point_for_property): Don't position point
4199 before BEGV. (Bug#10696)
4200
df0b2940
PE
42012012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 Handle overflow when computing char display width (Bug#9496).
4204 * character.c (char_width): Return EMACS_INT, not int.
4205 (char_width, c_string_width): Check for overflow when
4206 computing the width; this is possible now that individual
4207 characters can have unbounded width. Problem introduced
4208 by merge from Emacs 23 on 2012-01-19.
4209
6bee44d6
MA
42102012-02-02 Michael Albinus <michael.albinus@gmx.de>
4211
4212 * dbusbind.c (Fdbus_register_method): Mention the return value
4213 :ignore in the docstring.
4214
44f92739
GM
42152012-02-02 Glenn Morris <rgm@gnu.org>
4216
1b9f60cc
GM
4217 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4218
44f92739
GM
4219 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4220 Unconditionally set to t. (Bug#10673)
4221 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4222 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4223 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4224
c5d3843c
KH
42252012-02-02 Kenichi Handa <handa@m17n.org>
4226
4227 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4228 0, do not call append_composite_glyph.
4229
159462d4 42302012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4231
4232 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4233 NULL (Bug#6988).
4234 (x_produce_glyphs): If the component of a composition is a null
4235 string, set it->pixel_width to 1 to avoid zero-width glyph.
4236
78cef877
EZ
42372012-02-01 Eli Zaretskii <eliz@gnu.org>
4238
4239 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4240 first 2 arguments are identical. This makes inserting large
4241 output from a subprocess an order of magnitude faster on
4242 MS-Windows, where all sbrk'ed memory is always contiguous.
4243
97897668
GM
42442012-01-31 Glenn Morris <rgm@gnu.org>
4245
4246 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4247 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4248 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4249
31fd3586
GM
42502012-01-29 Glenn Morris <rgm@gnu.org>
4251
4252 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4253
0e24a8b2
CY
42542012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4255
4256 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4257
cc0adcb0
CY
42582012-01-28 Chong Yidong <cyd@gnu.org>
4259
4260 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4261
acc28cb9
CY
42622012-01-26 Chong Yidong <cyd@gnu.org>
4263
9c69cfb7
CY
4264 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4265
acc28cb9
CY
4266 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4267 repeat counts (Bug#10507).
4268
48da7392
GM
42692012-01-26 Glenn Morris <rgm@gnu.org>
4270
4271 * lread.c (syms_of_lread): Doc fix.
4272
14af5f7f
CY
42732012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4274
4275 * coding.c (encode_designation_at_bol): Change return value to
4276 EMACS_INT.
4277
0b21c100
CY
42782012-01-25 Chong Yidong <cyd@gnu.org>
4279
4280 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4281
3c2907f7
CY
42822012-01-21 Chong Yidong <cyd@gnu.org>
4283
4284 * floatfns.c (Fcopysign): Make the second argument non-optional,
4285 since nil is not allowed anyway.
4286
959ad23f
AS
42872012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4288
4289 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4290 (send_process): Likewise.
4291
34a02f46
MR
42922012-01-19 Martin Rudalics <rudalics@gmx.at>
4293
4294 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4295 (Vwindow_persistent_parameters): Do not use Qstate.
4296 Rewrite doc-strings.
34a02f46 4297
1259009a 42982012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4299
4300 * character.c (char_width): New function.
70d4fdf6
GM
4301 (Fchar_width, c_string_width, lisp_string_width):
4302 Use char_width (Bug#9496).
25ed9e61 4303
6a6ee00d
MR
43042012-01-16 Martin Rudalics <rudalics@gmx.at>
4305
4306 * window.c (Vwindow_persistent_parameters): New variable.
4307 (Fset_window_configuration, save_window_save): Handle persistent
4308 window parameters.
4309
c85efaf7
EZ
43102012-01-14 Eli Zaretskii <eliz@gnu.org>
4311
4312 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4313 thrashing the stack of the thread. (Bug#9087)
4314
5944709e
PE
43152012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4316
4317 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4318
e71f5d99
EZ
43192012-01-11 Eli Zaretskii <eliz@gnu.org>
4320
4321 * xdisp.c (rows_from_pos_range): Handle the case where the
4322 highlight ends on a newline. (Bug#10464)
4323 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4324 he end column for display of highlight that ends on a newline
4325 before a R2L line.
4326
ce316182
GM
43272012-01-11 Glenn Morris <rgm@gnu.org>
4328
4329 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4330 from load-path also when installation-directory is nil. (Bug#10208)
4331
5b43da69
GM
43322012-01-10 Glenn Morris <rgm@gnu.org>
4333
74cc8ff9
GM
4334 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4335
7d8d6e4e
GM
4336 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4337 Update template values to be closer to their typical values these days.
5b43da69 4338
a0db8d43
EZ
43392012-01-09 Eli Zaretskii <eliz@gnu.org>
4340
4341 * xdisp.c (rows_from_pos_range): Accept additional argument
4342 DISP_STRING, and accept any glyph in a row whose object is that
4343 string as eligible for mouse highlight. Fixes mouse highlight of
4344 display strings from overlays. (Bug#10464)
4345
9a0115ab 43462012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4347
b9110d6a 4348 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4349 * fileio.c (auto_saving_dir_umask): New static var.
4350 (Fmake_directory_internal): Use it.
4351 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4352 creating the directory. The old code temporarily assigns
4353 too-generous permissions to the directory.
4354 (do_auto_save_eh): Clear it.
b9110d6a 4355 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4356 that the var is always cleared.
4357
6c1bd3f3
EZ
43582012-01-07 Eli Zaretskii <eliz@gnu.org>
4359
4360 * search.c (scan_buffer): Pass character positions to
4361 know_region_cache, not byte positions. (Bug#6540)
4362
069d2b50
L
43632012-01-07 LynX <_LynX@bk.ru> (tiny change)
4364
4365 * w32.c (sys_rename): Report EXDEV when rename of a directory
4366 fails because the target is on another logical disk. (Bug#10284)
4367
75bf0d33
DB
43682012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4369
4370 * xterm.c (x_embed_request_focus): New function.
4371
4372 * xterm.h: Add prototype.
4373
4374 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4375
1c6e5a32
GM
43762012-01-05 Glenn Morris <rgm@gnu.org>
4377
4378 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4379
651e947e
EZ
43802012-01-01 Eli Zaretskii <eliz@gnu.org>
4381
4382 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4383 Load gnutls_transport_set_lowat only if GnuTLS version is below
4384 2.11.1.
4385 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4386 GnuTLS versions below 2.11.1.
4387
3778cdd8
AL
43882011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4389
4390 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4391 to the doc string advising against its use for altering the way
4392 windows are scrolled.
4393
0e5317f7
KH
43942011-12-28 Kenichi Handa <handa@m17n.org>
4395
4396 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4397 coding-system ASCII compatible only when it does not produce BOM
4398 on encoding (Bug#10383).
4399
93d5ca1f
JD
44002011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4401
4402 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4403 can scroll.
4404 (create_and_show_popup_menu): Always use menu_position_func for
4405 Gtk3 (Bug#10361).
4406
ca22b785
AS
44072011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4408
4409 * callint.c (Fcall_interactively): Don't truncate prompt string.
4410
d048e1e6
EZ
44112011-12-23 Eli Zaretskii <eliz@gnu.org>
4412
4413 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4414 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4415 resumed from there (after widening). (Bug#10360)
d048e1e6 4416
5ccaba1f
JD
44172011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4418
4419 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4420
204ee57f
JD
44212011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4422
b81d40f0
JB
4423 * nsterm.m (x_free_frame_resources):
4424 Release f->output_data.ns->miniimage.
204ee57f
JD
4425 (ns_index_color): Fix indentation. Do not retain
4426 color_table->colors[i].
4427
4428 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4429 before returning.
4430
4431 * nsfns.m (x_set_background_color): Assign return value from
4432 ns_index_color to face-background instead of NSColor*.
4433 (ns_implicitly_set_icon_type): Fix indentation.
4434 Change assignment in for loop to comparison.
4435
4436 * emacs.c (ns_pool): New variable.
4437 (main): Assign ns_pool.
4438 (Fkill_emacs): Call ns_release_autorelease_pool.
4439
4440 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4441 autorelease fdesc, release fdAttrs and tdict.
4442 (ns_get_covering_families): Release charset.
4443 (ns_findfonts): Release NSFontDescriptor created with new.
4444 (ns_uni_to_glyphs): Fix indentation.
4445 (setString): Release attrStr before assigning new value.
4446
c803b2b7
JD
44472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4448
678f4426
JD
4449 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4450 and NS_IMPL_COCOA.
4451 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4452 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4453
cd394be1 44542011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4455
5fecd5fc
JD
4456 * nsterm.m (ns_term_init): Subscribe for notifications
4457 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4458 to method trackingNotification in EmacsMenu.
4459
4460 * nsmenu.m (trackingMenu): New variable.
3771cb17 4461 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4462 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4463 from Aquamacs (Bug#7030).
678f4426
JD
4464
44652011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4466
c803b2b7
JD
4467 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4468 (symbol_to_nsstring): Fix indentation.
4469 (ns_symbol_to_pb): New function.
cae07000
SM
4470 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4471 (Fns_rotate_cut_buffers_internal): Remove.
4472 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4473 Fns_store_cut_buffer_internal.
4474 (ns_get_foreign_selection, Fx_own_selection_internal)
4475 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4476 (Fns_get_selection_internal, Fns_store_selection_internal):
4477 Use ns_symbol_to_pb and check if return value is nil.
4478 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4479 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4480 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4481 renamed to Sns_store_selection_internal.
4482 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4483 and remove this function.
4484 (ns_handle_selection_clear): Remove, never used.
4485 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4486 here.
4487
e1b01a3a
KB
44882011-12-17 Ken Brown <kbrown@cornell.edu>
4489
4490 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4491 GID is unknown (Bug#10257).
4492
2adb6e85
PE
44932011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4494
4495 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4496 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4497 which caused a build failure on GNU/Linux IA-64. This problem was
4498 introduced by my 2011-10-07 patch.
4499
d1d7b339
JL
45002011-12-15 Juri Linkov <juri@jurta.org>
4501
4502 * image.c (imagemagick_error): New function. (Bug#10112)
4503 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4504 Use `imagemagick_error' where ImageMagick functions return
4505 `MagickFalse'.
4506 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4507 proper order.
4508
100d5755
KH
45092011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4510
4511 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4512 fill background (Bug#8992).
4513
454592a6
MR
45142011-12-13 Martin Rudalics <rudalics@gmx.at>
4515
4516 * window.c (Vwindow_combination_resize)
4517 (Vwindow_combination_limit): Use t instead of non-nil in
4518 doc-strings.
61d4b438
MR
4519 (Vrecenter_redisplay): Add first sentence of doc-string on
4520 separate line.
53524d93 4521 (Frecenter): Fix doc-string typo.
454592a6 4522
3633e3aa
KH
45232011-12-11 Kenichi Handa <handa@m17n.org>
4524
4525 * coding.c (Funencodable_char_position): Pay attention to the
4526 buffer text relocation (Bug#9389).
4527
7b9d523a 45282011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4529
7b9d523a
JD
4530 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4531 gtk_init (Bug#10100).
4532
b73189c6
EZ
45332011-12-10 Eli Zaretskii <eliz@gnu.org>
4534
4535 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4536 IT->string is nil. (Bug#10263)
4537
f7dfe5d6
JD
45382011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4539
83faebb4
JD
4540 * nsterm.h (x_free_frame_resources): Declare.
4541
f7dfe5d6
JD
4542 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4543 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4544
4545 * nsterm.h (ns_get_defaults_value): Declare.
4546
4547 * nsterm.m (ns_default): Call ns_get_defaults_value.
4548
7cd4e72c
EZ
45492011-12-09 Eli Zaretskii <eliz@gnu.org>
4550
4551 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4552 (Bug#10170)
4553
b34d7317
YM
45542011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4555
4556 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4557 that where the value of an _OBJC_* symbol points to is in the .bss
4558 section (Bug#10240).
4559
76470ad1
KH
45602011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4561
4562 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4563 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4564
745fff94
KH
45652011-12-08 Kenichi Handa <handa@m17n.org>
4566
4567 * ftfont.c (get_adstyle_property): Fix previous change
4568 (Bug#10233).
4569
6e44397c
JB
45702011-12-07 Juanma Barranquero <lekktu@gmail.com>
4571
4572 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4573 dirs from the default value of EMACSLOADPATH (bug#10208).
4574
7efa6272
GM
45752011-12-07 Glenn Morris <rgm@gnu.org>
4576
4577 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4578 installation and source directories as well. (Bug#10208)
4579
f6fc4d87
CY
45802011-12-06 Chong Yidong <cyd@gnu.org>
4581
4582 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4583
2bf26180
GM
45842011-12-06 Glenn Morris <rgm@gnu.org>
4585
4586 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4587 as an error, not just -1. (Bug#10217)
4588
3a6ad4f0
CY
45892011-12-05 Chong Yidong <cyd@gnu.org>
4590
4591 * keyboard.c (process_special_events): New function.
4592 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4593
75a3b399
PE
45942011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4595
4596 * coding.c (encode_designation_at_bol): Don't use uninitialized
4597 local variable (Bug#9318).
4598
c3c9e25e
KH
45992011-12-05 Kenichi Handa <handa@m17n.org>
4600
4601 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4602 return Qnil (Bug#8046, Bug#10193).
4603
5eb05ea3
KH
46042011-12-05 Kenichi Handa <handa@m17n.org>
4605
4606 * coding.c (encode_designation_at_bol): New args charbuf_end and
4607 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4608 (coding_set_source): Return how many bytes coding->source was
4609 relocated.
4610 (coding_set_destination): Return how many bytes
4611 coding->destination was relocated.
4612 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4613 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4614
46152011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4616
4617 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4618 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4619 macro (Bug#9318).
4620
46212011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4622
4623 The following changes are to fix Bug#9318.
4624
a79703f5 4625 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4626 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4627 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4628 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4629
7dbda6df
JB
46302011-12-05 Juanma Barranquero <lekktu@gmail.com>
4631
4632 * lisp.h (process_quit_flag): Fix external declaration.
4633
6d5eb5b0
SM
46342011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4635
4636 Don't macro-inline non-performance-critical code.
4637 * eval.c (process_quit_flag): New function.
4638 * lisp.h (QUIT): Use it.
4639
a0c3fad0
JD
46402011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4641
4642 * nsfns.m (get_geometry_from_preferences): New function.
4643 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4644
6c07aac2
AS
46452011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4646
4647 * emacs.c (Qkill_emacs): Define.
4648 (syms_of_emacs): Initialize it.
4649 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4650 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4651 (quit_throw_to_read_char): Add parameter `from_signal'.
4652 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4653 * lisp.h (QUIT): Call Fkill_emacs if requested.
4654
c052ead4
JD
46552011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4656
4657 * widget.c (update_wm_hints): Return if wmshell is null.
4658 (widget_update_wm_size_hints): New function.
4659
4660 * widget.h (widget_update_wm_size_hints): Declare.
4661
4662 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4663 widget_update_wm_size_hints (Bug#10104).
4664
9e49252b
EZ
46652011-12-03 Eli Zaretskii <eliz@gnu.org>
4666
4667 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4668 before a newline, prepare the bidi iterator for consuming the
4669 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4670 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4671
02b16839
JL
46722011-12-02 Juri Linkov <juri@jurta.org>
4673
4674 * search.c (Fword_search_regexp): New Lisp function created from
4675 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4676 (Fword_search_backward, Fword_search_forward)
4677 (Fword_search_backward_lax, Fword_search_forward_lax):
4678 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4679 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4680
0068070e
SM
46812011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4682
4683 * fileio.c (Finsert_file_contents): Move after-change-function call
4684 to before the "handled:" label, since all "goto handled" appear in
4685 cases where the *-change-functions have already been properly called
4686 (bug#10117).
4687
3360a3fc
AS
46882011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4689
4690 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4691 waiting for input. (Bug#10169)
4692
73d6c093
EZ
46932011-11-30 Eli Zaretskii <eliz@gnu.org>
4694
4695 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4696 verifies glyph row's hash code--we have just reallocated the
4697 glyphs, so their contents can be complete garbage. (Bug#10164)
4698
febe6bea
JB
46992011-11-30 Juanma Barranquero <lekktu@gmail.com>
4700
4701 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4702
801a4313
EZ
47032011-11-30 Eli Zaretskii <eliz@gnu.org>
4704
4705 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4706 attributes are tested _before_ calling verify_row_hash, to protect
4707 against GCC re-ordering of the tests. (Bug#10164)
4708
2b56b87e
JD
47092011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4710
4711 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4712
4713 * xterm.c (handle_one_xevent): Only set async_visible and friends
4714 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4715 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4716 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4717
dbf31225
PE
47182011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4719
4720 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4721 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4722 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4723 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4724 All uses changed to use GCPRO1 etc.
4725 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4726 Revert to old implementation (i.e., before 2011-03-11).
4727
1305621b
YM
47282011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4729
4730 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4731 of scroll runs so as to avoid assigning disabled bogus rows and
4732 unnecessary graphics copy operations.
4733
8c9afb46
EZ
47342011-11-27 Eli Zaretskii <eliz@gnu.org>
4735
4736 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4737 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4738 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4739 (malloc, free, realloc, calloc): Redirect to e_* only when
4740 compiling Emacs.
4741
4742 * lisp.h (GCTYPEBITS): Move before first use.
4743 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4744 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4745 this macro definition.
4746
4747 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4748 _MSC_VER.
4749
54e9e3bf
JD
47502011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4751
6d5eb5b0
SM
4752 * gtkutil.c (xg_create_frame_widgets):
4753 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4754 present with Gtk+ 2.0.
4755
83aca1cb
PE
47562011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4757
4758 * fileio.c (Finsert_file_contents): Undo previous change; see
4759 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4760
5b76caa4
PE
47612011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4762
4763 Rename locals to avoid shadowing.
4764 * fileio.c (Finsert_file_contents):
4765 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4766 * process.c (wait_reading_process_output):
4767 Rename inner 'proc' to 'p' to avoid shadowing.
4768 Indent for consistency with usual Emacs style.
4769
8c535114
EZ
47702011-11-25 Eli Zaretskii <eliz@gnu.org>
4771
4772 * xdisp.c (redisplay_window): If cursor row is not fully visible
4773 after recentering, and scroll-conservatively is set to a large
4774 number, scroll window by a few more lines to make the cursor fully
4775 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4776 (start_display): Don't move to the next line if the display should
4777 start at a newline that is part of a display vector or an overlay
4778 string. (Bug#10119)
8c535114 4779
fa4fdb5c
JL
47802011-11-24 Juri Linkov <juri@jurta.org>
4781
4782 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4783 after the `MagickPingImage' call. (Bug#10112)
4784
90ec88df
CY
47852011-11-23 Chong Yidong <cyd@gnu.org>
4786
4787 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4788
56e2e794
MR
47892011-11-23 Martin Rudalics <rudalics@gmx.at>
4790
4791 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4792 making another buffer current. (Bug#10114)
4793
b6e64c41
GM
47942011-11-23 Glenn Morris <rgm@gnu.org>
4795
4796 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4797
6b21de18
CY
47982011-11-23 Chong Yidong <cyd@gnu.org>
4799
4800 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4801 using it (Bug#5984).
4802
b12cd789
EZ
48032011-11-22 Eli Zaretskii <eliz@gnu.org>
4804
4805 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4806 and header-lines, as they don't have one computed for them.
4807 (Bug#10098)
4808
4809 * .gdbinit (prow): Make displayed values more self-explaining.
4810 Add row's hash code.
4811
261b6fd4
LMI
48122011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4813
4814 * process.c (wait_reading_process_output): Fix asynchrounous
4815 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4816 (wait_reading_process_output): Add comment and URL.
261b6fd4 4817
e7cfd277
JD
48182011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4819
4820 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4821
a9b9b7f5
CY
48222011-11-21 Chong Yidong <cyd@gnu.org>
4823
4824 * window.c (Fnext_window, Fprevious_window): Doc fix.
4825
b0d15b4f
SM
48262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4827
4828 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4829
fe7a3057
JB
48302011-11-20 Juanma Barranquero <lekktu@gmail.com>
4831
4832 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4833
d2999b1a
MR
48342011-11-20 Martin Rudalics <rudalics@gmx.at>
4835
4836 * window.c (Fset_window_combination_limit): Rename argument
4837 STATUS to LIMIT.
4838 (Vwindow_combination_limit): Remove "status" from doc-string.
4839
d5ff9cd0
AS
48402011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4841
4842 * m/ibms390.h: Remove.
4843 * m/ibms390x.h: Don't include "ibms390.h".
4844
a5bb9bd3
SM
48452011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4846
4847 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4848 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4849
cd1181db
JB
48502011-11-20 Juanma Barranquero <lekktu@gmail.com>
4851
4852 * casetab.c (Fset_case_table):
4853 * charset.c (Fcharset_after): Fix typos.
4854
615a3b8d 48552011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4856
17e845af
PE
4857 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4858 Otherwise, valgrind does not work on some platforms.
4859 Problem reported by Andreas Schwab in
6a0bf43d
PE
4860 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4861 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4862 is set, removing the need for VIRT_ADDRESS_VARIES.
4863 (PURE_P): Use a more-efficient implementation that needs just one
4864 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4865 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4866 to 4 (xorl, subq, cmpq, setbe).
4867 * alloc.c (pure): Always extern now, since that's the
4868 VIRT_ADDR_VARIES behavior.
4869 (PURE_POINTER_P): Use a single comparison, not two, for
4870 consistency with the new puresize.h.
4871 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4872 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4873 Remove VIRT_ADDR_VARIES no longer needed.
4874
f8fe6f96
EZ
48752011-11-19 Eli Zaretskii <eliz@gnu.org>
4876
4877 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4878 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4879 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4880 behave as if the cursor position were at the window margin.
4881
4882 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4883 and the cursor position is out of bounds, behave as if the cursor
4884 position were at the window margin. (Bug#10075)
4885
df05a53c
CY
48862011-11-18 Chong Yidong <cyd@gnu.org>
4887
4888 * window.c (Fwindow_combination_limit): Make first argument
4889 non-optional, since it is meaningless for live windows like the
4890 selected window.
61ccba97 4891
2071918e
DA
48922011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4893
4894 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4895
b50a28de
SM
48962011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4897
4898 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4899 (graft_intervals_into_buffer): Simplify.
4900
015137db
EZ
49012011-11-18 Eli Zaretskii <eliz@gnu.org>
4902
4903 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4904 hash values of the two rows.
4905 (copy_row_except_pointers): Preserve the used[] arrays and the
4906 hash values of the two rows. (Bug#10035)
68c95424 4907 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4908
4909 * xdisp.c (row_hash): New function, body extracted from
4910 compute_line_metrics.
4911 (compute_line_metrics): Call row_hash, instead of computing the
4912 hash code inline.
4913
4914 * dispnew.c (verify_row_hash): Call row_hash for computing the
4915 hash code of a row, instead of duplicating code from xdisp.c.
4916
4917 * dispextern.h (row_hash): Add prototype.
4918
a2addb04
TH
49192011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4920
4921 * frame.c (delete_frame): Don't delete the terminal when the last
4922 X frame is closed if emacs is built with GTK toolkit.
4923
df85d315
JB
49242011-11-17 Juanma Barranquero <lekktu@gmail.com>
4925
4926 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4927
a0c2d0ae
MR
49282011-11-17 Martin Rudalics <rudalics@gmx.at>
4929
4930 * window.c (Vwindow_splits): Rename to
4931 Vwindow_combination_resize. Suggested by Juri Linkov.
4932 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4933 of Vwindow_splits.
4934
58179cce
JB
49352011-11-16 Juanma Barranquero <lekktu@gmail.com>
4936
7877f373
JB
4937 * nsfns.m (Fns_font_name):
4938 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4939
b6f67890
MR
49402011-11-16 Martin Rudalics <rudalics@gmx.at>
4941
4942 * window.h (window): Rename slot "nest" to "combination_limit".
4943 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4944 (Fset_window_nest): Rename to Fset_window_combination_limit.
4945 (Vwindow_nest): Rename to Vwindow_combination_limit.
4946 (recombine_windows, make_parent_window, make_window)
4947 (Fsplit_window_internal, saved_window)
4948 (Fset_window_configuration, save_window_save): Rename all
4949 occurrences of window_nest to window_combination_limit.
4950
c7015153
JB
49512011-11-15 Juanma Barranquero <lekktu@gmail.com>
4952
4953 * image.c (imagemagick_load_image): Fix typo.
4954
322ad6ec
EZ
49552011-11-14 Eli Zaretskii <eliz@gnu.org>
4956
4957 * xdisp.c (display_line): Move the call to
4958 highlight_trailing_whitespace before the call to
4959 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4960 faces of all the glyphs to compute ROW's hash value.
4961 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4962
f067b8ec
JB
49632011-11-14 Juanma Barranquero <lekktu@gmail.com>
4964
4965 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4966 just return (bug#10044).
4967
1e5b2111
EZ
49682011-11-12 Eli Zaretskii <eliz@gnu.org>
4969
7ef3cbd5
EZ
4970 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4971 with user-defined heap size. Bump the default size of the temacs
4972 heap to 27MB, to avoid memory warning when running temacs.
4973 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4974
1e5b2111
EZ
4975 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4976 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4977 (verify_row_hash) [XASSERTS]: New function.
4978 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4979 that the hash value of glyph rows is correct.
1e5b2111 4980
89d61221
MR
49812011-11-12 Martin Rudalics <rudalics@gmx.at>
4982
4983 * window.h (window): Remove splits slot.
4984 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4985 (Fdelete_other_windows_internal, make_parent_window)
4986 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4987 (Fset_window_configuration, save_window_save): Don't deal with
4988 split status of windows.
4989 (saved_window): Remove splits slot.
4990 (Vwindow_splits): Rewrite doc-string.
4991
97f18cc8
JD
49922011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4993
4994 * xfns.c (unwind_create_frame):
4995 * nsfns.m (unwind_create_frame):
4996 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4997 Vframe_list (Bug#9999).
4998
22a648b4
DA
49992011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5000
0b381c7e 5001 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5002
659afede
KH
50032011-11-11 Kenichi Handa <handa@m17n.org>
5004
5005 * callproc.c (Fcall_process): Set the member dst_multibyte of
5006 process_coding.
5007
9ac0394b
KH
50082011-11-11 Johan Bockgård <bojohan@gnu.org>
5009
5010 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5011 avoid a crash (bug#9496).
5012
2fbdc249
CY
50132011-11-09 Chong Yidong <cyd@gnu.org>
5014
5015 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5016 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5017
ac6b1f81
PE
50182011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5019
5020 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5021
09db192c
PE
50222011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 Avoid some portability problems by eschewing 'extern inline' functions.
5025 The trivial performance wins aren't worth the portability hassles; see
5026 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5027 et seq.
5028 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5029 (window_box_width, window_box_left, window_box_left_offset)
5030 (window_box_right, window_box_right_offset): Undo previous change,
5031 by removing the "extern"s.
5032 * intervals.c (adjust_intervals_for_insertion)
5033 (adjust_intervals_for_deletion): Undo previous change,
5034 making these static again.
5035 (offset_intervals, temp_set_point_both, temp_set_point)
5036 (copy_intervals_to_string): No longer inline.
5037 * xdisp.c (window_text_bottom_y, window_box_width)
5038 (window_box_height, window_box_left_offset)
5039 (window_box_right_offset, window_box_left, window_box_right)
5040 (window_box): No longer inline.
5041
105216ed
CY
50422011-11-08 Chong Yidong <cyd@gnu.org>
5043
5044 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5045 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5046 Signal an error if not a live window.
105216ed
CY
5047 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5048 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5049
ae9e237f
JB
50502011-11-07 Juanma Barranquero <lekktu@gmail.com>
5051
5052 * lisp.h (syms_of_abbrev): Remove declaration.
5053 Reported by CHENG Gao <chenggao@royau.me>.
5054
c7aa8333
EZ
50552011-11-07 Eli Zaretskii <eliz@gnu.org>
5056
5057 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5058 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5059 of temacs in GUI mode.
5060
be7f5545
MR
50612011-11-07 Martin Rudalics <rudalics@gmx.at>
5062
5063 * window.h: Declare delete_all_child_windows instead of
5064 delete_all_subwindows.
5065 * window.c (Fwindow_nest, Fset_window_nest)
5066 (Fset_window_new_total, Fset_window_new_normal)
5067 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5068 (delete_all_subwindows): Rename to delete_all_child_windows.
5069 (Fdelete_other_windows_internal, Fset_window_configuration):
5070 Call delete_all_child_windows instead of delete_all_subwindows.
5071 * frame.c (delete_frame): Call delete_all_child_windows instead
5072 of delete_all_subwindows.
5073
ca78dc43
PE
50742011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5075
5076 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5077 This is also needed for porting to any host where GC_MARK_STACK is
5078 not GC_MAKE_GCPROS_NOOPS.
5079 (which_symbols): Use it.
5080
a0241d01
KH
50812011-11-07 Kenichi Handa <handa@m17n.org>
5082
5083 * coding.c (coding_set_destination): Check coding->src_pos only
5084 when coding->src_object is a buffer (bug#9910).
5085
5086 * process.c (send_process): Set the member src_multibyte of coding
5087 to 0 (bug#9911) when sending a unibyte text.
5088
5089 * callproc.c (Fcall_process): Set the member src_multibyte of
5090 process_coding to 0 (bug#9912).
5091
a64bfdfa 50922011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5093
5094 * xmenu.c (cleanup_widget_value_tree): New function.
5095 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5096 calling free_menubar_widget_value_tree directly (Bug#9830).
5097
cb41b32a
PE
50982011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5099
5100 Fix some portability problems with 'inline'.
5101 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5102 (window_box_width, window_box_left, window_box_left_offset)
5103 (window_box_right, window_box_right_offset): Declare extern.
5104 Otherwise, these inline functions do not conform to C99 and
5105 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5106 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5107 * intervals.c (adjust_intervals_for_insertion)
5108 (adjust_intervals_for_deletion): Now extern, because otherwise the
5109 extern inline functions 'offset_intervals' couldn't refer to it.
5110 (static_offset_intervals): Remove.
5111 (offset_intervals): Rewrite using the old contents of
5112 static_offset_intervals. The old version didn't conform to C99
5113 because an extern inline function contained a reference to an
5114 identifier with static linkage.
5115
b7041366
AS
51162011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5117
5118 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5119 GC.
5120
88a37c4d
EZ
51212011-11-06 Eli Zaretskii <eliz@gnu.org>
5122
5123 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5124 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5125 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5126 return Qleft_to_right.
5127
49745b39
CY
51282011-11-06 Chong Yidong <cyd@gnu.org>
5129
5130 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5131 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5132 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5133 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5134 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5135 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5136 (Fwindow_vscroll): Doc fix.
5137 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5138 argument, since it makes no sense to pass a live window and for
5139 consistency with window-child.
5140
1f05cd82
CS
51412011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5142
5143 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5144 support MSVC.
5145
22610910
JR
51462011-11-05 Jason Rumney <jasonr@gnu.org>
5147
5148 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5149 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5150 fonts (Bug#6029).
5151 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5152 bitwise arithmetic preventing use of unicode-sip and non-truetype
5153 opentype fonts.
5154
a06776b2
EZ
51552011-11-05 Eli Zaretskii <eliz@gnu.org>
5156
3ad924ba
EZ
5157 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5158 "emacs"-only part.
5159
a06776b2
EZ
5160 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5161 initialization code to keep similarity to xfns.c after changes
5162 from 2011-11-05.
5163
c9e7db78
JD
51642011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5165
a97f8f3f
JD
5166 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5167 (unwind_create_frame): New function (Bug#9943).
5168 (Fx_create_frame): Restructure code to be more similar to the one in
5169 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5170 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5171 Move terminal->reference_count++ just before making the frame official
5172 (Bug#9943).
5173
5174 * nsterm.m (x_free_frame_resources): New function.
5175 (x_destroy_window): Move code to x_free_frame_resources.
5176
c9e7db78 5177 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5178 (Fx_create_frame, x_create_tip_frame):
5179 Move terminal->reference_count++ just before making the frame
75f1671a 5180 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5181 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5182
a6fc3b5c
EZ
51832011-11-05 Eli Zaretskii <eliz@gnu.org>
5184
5185 Support MSVC build with newer versions of Visual Studio.
5186 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5187 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5188 nt/gmake.defs.
5189
5190 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5191 which are not supported by MSVC.
5192 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5193 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5194 bitfields.
5195 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5196 types in bitfields.
5197 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5198
5199 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5200
58179cce 52012011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5202
5203 Support MSVC build with newer versions of Visual Studio.
5204 * w32.c: Don't include w32api.h for MSVC.
5205 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5206
5207 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5208 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5209 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5210 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5211 e_* cousins.
5212 (alloca) [_MSC_VER]: Define to _alloca.
5213
5214 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5215
5216 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5217
a58c13ed
EZ
52182011-11-04 Eli Zaretskii <eliz@gnu.org>
5219
5220 * xdisp.c (note_mouse_highlight): If either of
5221 previous/next-single-property-change returns nil, treat that as
5222 the beginning or the end of the buffer. (Bug#9955)
5223
fe0b6370
JD
52242011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5225
a58c13ed 5226 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5227 label is not null (Bug#9951).
5228 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5229 may be NULL.
5230
89bd5ee1
EZ
52312011-11-04 Eli Zaretskii <eliz@gnu.org>
5232
5233 * window.c (Fwindow_body_size): Mention in the doc string that the
5234 return value is in frame's canonical units. (Bug#9949)
5235
84c3edb9
EZ
52362011-11-03 Eli Zaretskii <eliz@gnu.org>
5237
4e2fb5c7
EZ
5238 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5239
84c3edb9 5240 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5241 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5242 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5243
bc17a887
EZ
52442011-11-01 Eli Zaretskii <eliz@gnu.org>
5245
5246 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5247 Don't stop backward scan on the continuation glyph, even though
5248 its CHARPOS is positive.
6d5eb5b0
SM
5249 (mouse_face_from_buffer_pos, note_mouse_highlight):
5250 Rename cover_string to disp_string.
bc17a887 5251
4ee88440
MR
52522011-11-01 Martin Rudalics <rudalics@gmx.at>
5253
5254 * window.c (temp_output_buffer_show): Don't use
5255 Vtemp_buffer_show_specifiers.
5256 (Vtemp_buffer_show_specifiers): Remove unused variable.
5257
c2ff3c02
EZ
52582011-10-30 Eli Zaretskii <eliz@gnu.org>
5259
5260 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5261 past the beginning of the current glyph matrix.
5262
58179cce 52632011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5264
5265 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5266 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5267 HAVE_GTK3 (Bug#9869).
b77a6a7f 5268
3b574623
JD
5269 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5270 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5271
b77a6a7f
JD
5272 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5273
5274 * xterm.c: Declare x_handle_net_wm_state to return int.
5275 (handle_one_xevent): Check if we are iconified but don't have
5276 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5277 (get_current_wm_state): Return non-zero if not hidden,
5278 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5279 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5280 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5281 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5282
196e41e4
PE
52832011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5284
5285 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5286 so that this new function doesn't get optimized away by a
5287 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5288
021f2e1a
AS
52892011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5290
5291 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5292
8b058d44
EZ
52932011-10-29 Eli Zaretskii <eliz@gnu.org>
5294
5295 Fix the `xbytecode' command.
5296 * .gdbinit (xprintbytestr): New command.
b50a28de 5297 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5298 (xbytecode): Print the byte-code string as well.
5299
4452fb80
EZ
53002011-10-29 Kim Storm <storm@cua.dk>
5301
8b058d44
EZ
5302 * alloc.c (which_symbols): New function.
5303
21b72067
AS
53042011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5305
5306 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5307 line. (Bug#9903)
5308
83ed7b5c
GM
53092011-10-29 Glenn Morris <rgm@gnu.org>
5310
5311 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5312 Not clear what it was for, and it causes various bugs. (Bug#9839)
5313
5a7a728b
EZ
53142011-10-28 Eli Zaretskii <eliz@gnu.org>
5315
5316 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5317 possible random value that matches one of those tested as
5318 condition to clear the mouse face.
5319
d3d0842f
CY
53202011-10-28 Chong Yidong <cyd@gnu.org>
5321
5322 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5323
31b39d13
DN
53242011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5325
5326 * window.c (make_window): Initialize phys_cursor_on_p.
5327
9aba6043
SM
53282011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5329
5330 * lisp.h (struct Lisp_Symbol): Update comments.
5331
c20992f4
JB
53322011-10-28 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5335
db4f02f2
EZ
53362011-10-28 Eli Zaretskii <eliz@gnu.org>
5337
5338 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5339 <oslsachem@gmail.com> for helping to debug this.
5340
5341 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5342 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5343 (g_b_init_get_glyph_outline_w): New static variables.
5344 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5345 (GetGlyphOutlineW_Proc): New typedefs.
5346 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5347 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5348 New functions.
5349 (w32font_open_internal, compute_metrics):
5350 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5351 instead of calling the "wide" APIs directly.
5352
5353 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5354
5355 * w32.h (syms_of_w32font): Add prototype.
5356
87e68db4
JB
53572011-10-27 Juanma Barranquero <lekktu@gmail.com>
5358
5359 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5360 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5361 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5362 (Fmove_to_window_line): Doc fix.
5363
435c1d67
CY
53642011-10-27 Chong Yidong <cyd@gnu.org>
5365
5366 * process.c (make_process): Set gnutls_state to NULL.
5367
5368 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5369 non-NULL, regardless of GNUTLS_INITSTAGE.
5370 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5371 an error. Set process slots as soon as we allocate them.
5372
5373 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5374
9c6c6f49
CY
53752011-10-27 Chong Yidong <cyd@gnu.org>
5376
9aba6043
SM
5377 * gnutls.c (emacs_gnutls_deinit): New function.
5378 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5379 (Fgnutls_deinit, Fgnutls_boot): Use it.
5380
5381 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5382 (deactivate_process): Call emacs_gnutls_deinit.
5383
657d08d3
JB
53842011-10-27 Juanma Barranquero <lekktu@gmail.com>
5385
5386 * image.c (x_create_x_image_and_pixmap):
5387 * w32.c (sys_rename, w32_delayed_load):
5388 * w32font.c (fill_in_logfont):
5389 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5390
5430d399
JB
53912011-10-26 Juanma Barranquero <lekktu@gmail.com>
5392
5393 * w32fns.c (w32_default_color_map): New function,
5394 extracted from Fw32_default_color_map.
a7ef684b 5395 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5396
fe0055fa
PE
53972011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5398
5399 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5400
e6346438
SM
54012011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5402
5403 * keyboard.c (test_undefined): New function (bug#9751).
5404 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5405
e112cc37
ET
54062011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5407
5408 * sysdep.c (init_sys_modes): Fix the check for the controlling
5409 terminal (Bug#6649).
5410
7b5d6677
EZ
54112011-10-20 Eli Zaretskii <eliz@gnu.org>
5412
5413 * dispextern.h (struct bidi_it): New member next_en_type.
5414
5415 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5416 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5417 current character, check also for next_en_type being WEAK_EN.
5418 (bidi_resolve_weak): Don't enter the expensive loop if the current
5419 position is before next_en_pos. Record the bidi type of the first
5420 non-ET, non-BN character we find, in addition to its position.
5421 (bidi_level_of_next_char): Invalidate next_en_type when
5422 next_en_pos is over-stepped.
5423
7da0b018
PE
54242011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5425
5426 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5427 * editfns.c: Rewrite current-time-zone so that it invokes
5428 the equivalent of (format-time-string "%Z") to get the time zone name.
5429 This fixes a bug when the time zone name contains characters that
5430 need converting from the system time locale to Emacs internal format.
5431 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5432 that patch fixed format-time-string to do the conversion, but
5433 I forgot to fix current-time-zone.
5434 (format_time_string): New function, containing most of
5435 what Fformat_time_string used to contain.
5436 (Fformat_time_string): Rewrite in terms of format_time_string.
5437 This doesn't change this function's behavior.
5438 (current-time-zone): Rewrite to use format_time_string.
5439 This fixes the bug reported by Michael Schierl in
5440 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5441 Jason Rumney's 2007-06-07 change worked around this bug, but
5442 didn't fix it.
5443 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5444
8547b010
EZ
54452011-10-19 Eli Zaretskii <eliz@gnu.org>
5446
5447 * xdisp.c (start_display): If the character at POS is displayed
5448 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5449 (try_window_reusing_current_matrix): If a line ends in a display
5450 vector or the next line starts in a display vector, continue
5451 redrawing the window even though the character position of
5452 start_row was reached.
8547b010
EZ
5453 (Bug#9771, part 2)
5454
4e948d15
CY
54552011-10-18 Chong Yidong <cyd@gnu.org>
5456
5457 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5458 with nobreak-char-display too.
5459
4787455f
EZ
54602011-10-18 Eli Zaretskii <eliz@gnu.org>
5461
5462 Fix part 3 of bug#9771.
5463 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5464 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5465 non-neutral characters if the current character is a paragraph
5466 separator (a.k.a. Newline). This avoids running the same
5467 expensive loop twice, once when we consume the preceding newline
5468 and the other time when the line actually needs to be displayed.
5469 Avoid the loop when we see neutrals on the base embedding level
5470 following a character whose directionality is the same as the
5471 paragraph's. This avoids running the expensive loop when a line
5472 ends in a long sequence of neutrals, like control characters.
5473 Add assertion against STRONG_AL type. Slightly rearrange code
5474 that determines the type of a neutral given the first non-neutral
5475 that follows it.
5476 (bidi_level_of_next_char): Set next_en_pos to zero when
5477 invalidating its info.
5478
2c91f553
EZ
54792011-10-17 Eli Zaretskii <eliz@gnu.org>
5480
5481 * xdisp.c (push_display_prop): Determine whether to record string
5482 or buffer position by IT->string, not by IT->method. Allow
5483 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5484 (move_it_vertically_backward): Don't look for character position
5485 immediately after the newline when in a continuation line.
5486 (Bug#9771, part 1)
2c91f553 5487
c7b08b0d
MR
54882011-10-15 Martin Rudalics <rudalics@gmx.at>
5489
5490 * window.c (coordinates_in_window): Rewrite and delabelize
5491 vertical border check. (Bug#5357) (Bug#9618)
5492
6b02f655
SM
54932011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5494
5495 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5496 errors in XSetWindowBorder (bug#9310).
5497
81d40c92
DA
54982011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5499
5500 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5501 avoid crash when xmalloc overrun checking is enabled.
5502
d4172c3b
EZ
55032011-10-13 Eli Zaretskii <eliz@gnu.org>
5504
5505 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5506 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5507 cursor motion with <left> and <right> arrow keys.
5508
5509 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5510 some callers set that themselves.
5511
b00eea75
EZ
55122011-10-12 Eli Zaretskii <eliz@gnu.org>
5513
5514 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5515 display string and the previous row comes from the same string and
5516 is empty. (Bug#9739) (Bug#9738)
5517
8fe012c4
SM
55182011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5519
5520 * doc.c (get_doc_string): Encode file name (bug#9735).
5521
0074aef2
EZ
55222011-10-12 Eli Zaretskii <eliz@gnu.org>
5523
79beb178
EZ
5524 * bidi.c (bidi_level_of_next_char):
5525 * xdisp.c (get_visually_first_element): Remove old incorrect
5526 comments regarding the Unicode Line Separator character.
5527
0074aef2
EZ
5528 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5529
6e4b3fbe
DA
55302011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5531
5532 * alloc.c (Fgc_status): Do not access beyond zombies array
5533 boundary if nzombies > MAX_ZOMBIES.
5534 * alloc.c (dump_zombies): Add missing format specifier.
5535
0324f3af
PE
55362011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5537
b5525cac
PE
5538 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5539 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5540
0324f3af
PE
5541 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5542 Some packages use them to denote characters with modifiers.
5543
e9b5f888
AS
55442011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5545
5546 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5547 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5548 matching a pp-number. Rename parameter var to var1.
5549
127827c0
SM
55502011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5551
5552 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5553
c8fd3bd0
GM
55542011-10-08 Glenn Morris <rgm@gnu.org>
5555
5556 * callint.c (Fcall_interactively): Give a more explicit error for the
5557 'c' case with a non-character input. (Bug#8479)
5558
352ec8ff
EZ
55592011-10-08 Eli Zaretskii <eliz@gnu.org>
5560
03669ccb
EZ
5561 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5562 lines.
7061c986
EZ
5563 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5564 lines that are hscrolled on the left.
03669ccb 5565
352ec8ff
EZ
5566 * dispnew.c (buffer_posn_from_coords): Account for a possible
5567 presence of header-line. (Bug#4426)
5568
a66cfb1c
SM
55692011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5570
6b02f655
SM
5571 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5572 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5573
7c5ee88e
PE
55742011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5575
5576 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5577 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5578 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5579 this makes Emacs dump core during garbage collection on rare
5580 occasions. sizeof is obviously inferior to offsetof here, so
5581 stick with offsetof.
5582 (GC_POINTER_ALIGNMENT): New macro.
5583 (mark_memory): Omit 3rd (offset) arg; caller changed.
5584 Don't assume EMACS_INT alignment is the same as pointer alignment.
5585
df1bbe5b
SM
55862011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5587
5588 * keyboard.c (read_key_sequence_remapped): New var.
5589 (read_key_sequence): Compute remapping in the right buffer.
5590 (command_loop_1): Use read_key_sequence's remapping directly.
5591
51553db6
SM
55922011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5593
32c1fffd
SM
5594 * dired.c (file_name_completion): Don't expand file name.
5595 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5596 before checking file name handler.
5597
51553db6
SM
5598 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5599 they've been requested explicitly (bug#9591).
5600
b6bd1599 56012011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5602
5603 * keymap.c (Fsingle_key_description): Use make_specified_string
5604 instead of build_string to build string from push_key_description.
5605 (Bug#5193)
5606
f701dc2a
PE
56072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5608
4222c55d
PE
5609 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5610 This fixes a Y2038 bug on 64-bit hosts.
5611 * buffer.c (reset_buffer):
5612 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5613 (Fclear_buffer_auto_save_failure):
5614 Use 0, not -1, to represent an unset failure time, since time_t
5615 might not be signed.
5616
f701dc2a
PE
5617 Remove dependency on glibc malloc internals.
5618 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5619 Move back here from lisp.h, but with their new implementations.
5620 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5621 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5622 * charset.c (charset_table_init): New static var.
5623 (syms_of_charset): Use it instead of xmalloc. This removes a
5624 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5625 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5626 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5627 Move back to alloc.c.
5628 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5629 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5630
9ceebf39
JD
56312011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5632
5633 * nsterm.m (windowDidResize): Call x_set_window_size only when
5634 ns_in_resize is true. Otherwise set pixelwidth/height and
5635 call change_frame_size (Bug#9628).
5636
cb993c58
PE
56372011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5638
3930c88b
PE
5639 Port --enable-checking=all to Fedora 14 x86-64.
5640 * charset.c (syms_of_charset): Also account for glibc malloc's
5641 internal overhead when calculating the initial malloc maximum.
5642
cb993c58
PE
5643 Port --enable-checking=all to Fedora 14 x86.
5644 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5645 Move to lisp.h.
5646 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5647 (overrun_check_realloc, overrun_check_free):
5648 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5649 That way, xmalloc returns a properly-aligned pointer even if
5650 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5651 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5652 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5653 into account when calculating the initial malloc maximum.
5654 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5655 Move here from alloc.c, so that charset.c can use it too.
5656 Properly align; the old code wasn't right for common 32-bit hosts
5657 when configured with --enable-checking=all.
5658 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5659 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5660
31bed486
EZ
56612011-09-29 Eli Zaretskii <eliz@gnu.org>
5662
04c70788 5663 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5664 use EDOM.
5665
fbcaa2f3
EZ
56662011-09-28 Eli Zaretskii <eliz@gnu.org>
5667
5668 * xdisp.c (compute_display_string_end): If there's no display
5669 string at CHARPOS, return -1.
5670
5671 * bidi.c (bidi_fetch_char): When compute_display_string_end
5672 returns a negative value, treat the character as a normal
5673 character not covered by a display string. (Bug#9624)
5674
a239d4e9
JB
56752011-09-28 Juanma Barranquero <lekktu@gmail.com>
5676
5677 * lread.c (Fread_from_string): Fix typo in docstring.
5678
88652fd5
EZ
56792011-09-27 Eli Zaretskii <eliz@gnu.org>
5680
5681 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5682 newline, reseat the iterator instead of bidi-iterating there one
5683 character at a time. (Bug#9610)
32c1fffd
SM
5684 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5685 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5686
ed497dd4
AS
56872011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5688
5689 * lread.c (readevalloop): Use correct code for NBSP.
5690 (read1): Likewise. (Bug#9608)
5691
b2bf61aa
MA
56922011-09-25 Michael Albinus <michael.albinus@gmx.de>
5693
5694 * dbusbind.c (Fdbus_register_signal): When service is not
5695 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5696
32bbb17c
GM
56972011-09-25 Glenn Morris <rgm@gnu.org>
5698
5699 * buffer.c (truncate-lines): Doc fix.
5700
94e0933e
CY
57012011-09-24 Chong Yidong <cyd@stupidchicken.com>
5702
5703 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5704 (Fset_window_next_buffers): Doc fix.
5705
cddde921
GM
57062011-09-24 Glenn Morris <rgm@gnu.org>
5707
5708 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5709
1260aef1
PE
57102011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5711
25b4bfa0
PE
5712 Fix minor problems found by static checking.
5713 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5714 * indent.c (Fvertical_motion): Fix == vs = typo.
5715
e3cbd34b
EZ
57162011-09-24 Eli Zaretskii <eliz@gnu.org>
5717
a66cfb1c
SM
5718 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5719 Default value is now t. Doc fix.
6bf7006f 5720
e3cbd34b 5721 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5722 logic when moving up, not only when moving down. Fix the
e3cbd34b 5723 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5724 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5725
5726 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5727 CHARPOS is covered by a display string which includes newlines.
5728 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5729 is covered by a display string with embedded newlines.
5730
a3de0cbd
MA
57312011-09-24 Michael Albinus <michael.albinus@gmx.de>
5732
5733 * dbusbind.c (Fdbus_register_signal): Add match rule to
5734 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5735 (Fdbus_register_method, Vdbus_registered_objects_table):
5736 Fix docstring.
a3de0cbd 5737
b260039d
JM
57382011-09-24 Jim Meyering <meyering@redhat.com>
5739
32c1fffd 5740 do not ignore write error for any output size
b260039d
JM
5741 The previous change was incomplete.
5742 While it makes emacs --batch detect the vast majority of stdout
5743 write failures, errors were still ignored whenever the output size is
5744 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5745 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5746 && echo FAIL: ignored write error
5747 FAIL: ignored write error
5748 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5749 && echo FAIL: ignored write error
5750 FAIL: ignored write error
5751 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5752
8eca8a7c
AS
57532011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5754
5755 * emacs.c (Fkill_emacs): In noninteractive mode exit
5756 non-successfully if a write error occurred on stdout. (Bug#9574)
5757
3341db62
EZ
57582011-09-21 Eli Zaretskii <eliz@gnu.org>
5759
5760 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5761 the xassert test.
5762
5763 * dispextern.h (struct it): Update the comment documenting what
5764 can it->OBJECT be.
5765
8c203dbf
EZ
57662011-09-20 Eli Zaretskii <eliz@gnu.org>
5767
5768 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5769 a display string, extend search for cursor position to end of row.
5770 (find_row_edges): If the row ends in a newline from a display
5771 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5772 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5773 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5774 non-empty line. Fixes confusing cursor motion with arrow keys at
5775 the beginning of a line that starts with whitespace.
8c203dbf 5776
a4824228
LMI
57772011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5778
5779 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5780 (bug#9493).
5781
33ed493b
CY
57822011-09-18 Chong Yidong <cyd@stupidchicken.com>
5783
5784 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5785 boolean (Bug#9154).
5786
56cd55c8
EZ
57872011-09-18 Eli Zaretskii <eliz@gnu.org>
5788
5789 * xdisp.c (display_line): Record maximum and minimum buffer
5790 positions even if no glyphs were produced (e.g., by a zero-width
5791 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5792 buffer positions that will be removed from the glyph row because
5793 they don't fit.
c02dcedf
EZ
5794 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5795 column is beyond frame width: don't subtract 1 "pixel" when
5796 computing width of the stretch.
3e62b7e0
EZ
5797 (reseat_at_next_visible_line_start): Undo the change made on
5798 2011-09-17 that saved paragraph information and restored it after
5799 the call to `reseat'. (Bug#9545)
56cd55c8 5800
5ed99d36 58012011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5802
5803 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5804 and turn window cursor on if cleared (Bug#9415).
5805
5ed99d36 58062011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5807
5808 * search.c (boyer_moore): Take unibyte characters from pattern
5809 literally. (Bug#9458)
5810
9bade7b2
EZ
58112011-09-18 Eli Zaretskii <eliz@gnu.org>
5812
5813 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5814
e5e9d610
PE
58152011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5816
87e4427a
PE
5817 Fix minor problem found by static checking.
5818 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5819 initialized, to pacify gcc -Wuninitialized.
5820
e5e9d610
PE
5821 * fileio.c: Report proper errno when syscall falls.
5822 (Finsert_file_contents): Save and restore errno,
5823 so that report_file_error outputs the correct diagnostic.
5824 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5825
a1674f0b
EZ
58262011-09-18 Eli Zaretskii <eliz@gnu.org>
5827
5828 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5829
fbfb6dd4
EZ
58302011-09-17 Eli Zaretskii <eliz@gnu.org>
5831
5832 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5833 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5834
bb187662
EZ
58352011-09-17 Eli Zaretskii <eliz@gnu.org>
5836
1137e8b8 5837 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5838 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5839
5840 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5841 (bidi_find_paragraph_start): Search back for paragraph beginning
5842 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5843 (bidi_move_to_visually_next): Only trigger paragraph-related
5844 computations when the last character is a newline or at EOB, not
5845 just any NEUTRAL_B. (Bug#9470)
5846
bb187662
EZ
5847 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5848 truncated lines if point is covered by a display string. (Bug#9524)
5849
2e621251
PE
58502011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5851
5852 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5853 (cons_to_x_long): New function.
5854 (lisp_data_to_selection_data): Use it. Correct the test for
5855 short-versus-long data; it was negated. Break out of vector
5856 loop, for efficiency, when a long datum is discovered.
5857
91a15bc6
SM
58582011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5859
5860 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5861
b41c3a35
EZ
58622011-09-16 Eli Zaretskii <eliz@gnu.org>
5863
5864 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5865 GCC PR/17406) by declaring this function with external scope.
5866
7812ba2d
PE
58672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5868
5869 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5870 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5871
cf7edc2a
AS
58722011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5873
5874 * editfns.c (Fformat): Correctly handle text properties on "%%".
5875
bd01620e
EZ
58762011-09-15 Eli Zaretskii <eliz@gnu.org>
5877
5878 * xterm.c (x_draw_composite_glyph_string_foreground):
5879 * w32term.c (x_draw_composite_glyph_string_foreground):
5880 * term.c (encode_terminal_code):
5881 * composite.c (composition_update_it, get_composition_id):
5882 * xdisp.c (get_next_display_element)
5883 (fill_composite_glyph_string): Add comments about special meaning
5884 of TAB characters in a composition.
5885
a02719a3
PE
58862011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5887
5888 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5889 This occurs when processing a multibyte format.
5890 Problem reported by Wolfgang Jenker.
a02719a3 5891
72589a3c
JB
58922011-09-15 Johan Bockgård <bojohan@gnu.org>
5893
5894 * xdisp.c (try_cursor_movement): Only check for exact match if
5895 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5896
1c14176c
PE
58972011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5898
5899 Remove unused external symbols.
5900 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5901 * xdisp.c (calc_pixel_width_or_height): Now static.
5902 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5903 * indent.c (check_display_width):
5904 * w32term.c: Fix comment to match code.
5905 * xterm.c, xterm.h (x_catching_errors): Remove.
5906
d2eea5b5
PE
59072011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5908
5909 * xselect.c: Use signed conversions more consistently (Bug#9498).
5910 (selection_data_to_lisp_data): Assume incoming selection data are
5911 signed integers, not unsigned. This is to be consistent with
5912 outgoing selection data, which was modified to use signed integers
5913 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5914 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5915 expects long, not unsigned long.
5916
46888499
EZ
59172011-09-14 Eli Zaretskii <eliz@gnu.org>
5918
5919 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5920 computation of loop end. Reported by Johan Bockgård
5921 <bojohan@gnu.org>.
5922
ef8ef9fb
CY
59232011-09-13 Chong Yidong <cyd@stupidchicken.com>
5924
5925 * frame.c (Fother_visible_frames_p): Function deleted.
5926
fa819fed
EZ
59272011-09-12 Eli Zaretskii <eliz@gnu.org>
5928
5929 * indent.c (compute_motion): Process display vector front to back
5930 rather than the other way around. (Bug#2496)
5931
2ba8e008
SM
59322011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5933
5934 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5935
20f53c69
CY
59362011-09-11 Chong Yidong <cyd@stupidchicken.com>
5937
5938 * minibuf.c (Fread_from_minibuffer): Doc fix.
5939
d562d7a4
EZ
59402011-09-11 Eli Zaretskii <eliz@gnu.org>
5941
5942 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5943 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5944
1c4d7f3d
LMI
59452011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5946
5947 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5948 value for non-existent files.
5949
b885bf36
EZ
59502011-09-11 Eli Zaretskii <eliz@gnu.org>
5951
5952 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5953 set its "size" to -1. This will set the modtime_size field of
5954 the corresponding buffer to -1, which is what
5955 verify-visited-file-modtime expects for files that do not exist.
5956 (Bug#9139)
5957
6612f0bf
PE
59582011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5959
5960 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5961 here ...
5962 * lisp.h: ... from here. push_key_description is no longer
5963 defined in keyboard.c, so its declaration should not be in
5964 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5965 logically belongs with push_key_description.
5966
dfb3f755
PE
59672011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5968
5969 * buffer.h: Include <sys/types.h> instead of <time.h>.
5970 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5971 Problem reported by Herbert J. Skuhra.
5972
3134906c
LMI
59732011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5974
5975 * xml.c (parse_region): Make the parsing work for
5976 non-comment-starting XML files again (bug#9144).
5977
8d903f4e
AS
59782011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5979
5980 * image.c (gif_load): Fix calculation of bottom and right corner.
5981 (Bug#9468)
5982
80ad64f4
EZ
59832011-09-10 Eli Zaretskii <eliz@gnu.org>
5984
5985 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5986 redisplay in small windows.
5987
208a048d
EZ
59882011-09-09 Eli Zaretskii <eliz@gnu.org>
5989
5990 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5991
9b1c252e
MR
59922011-09-08 Martin Rudalics <rudalics@gmx.at>
5993
5994 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5995 Operate on live windows only.
5996
2949f33b
JB
59972011-09-08 Juanma Barranquero <lekktu@gmail.com>
5998
5999 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6000
e08dcafd
EZ
60012011-09-07 Eli Zaretskii <eliz@gnu.org>
6002
6003 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6004 only under bidi iteration.
6005
115b96bd
JD
60062011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6007
6008 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6009
c8199d0f
PE
60102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6011
6012 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6013 Without this fix, the command to link temacs failed due to an
6014 undefined symbol __builtin_isnan. This is because
6015 /usr/include/iso/math_c99.h #defines isnan(x) to
6016 __builtin_isnan(x), but the bundled gcc, which identifies itself
6017 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6018 a __builtin_isnan.
6019 * floatfns.c (isnan): #undef, and then #define to a clone of
6020 what's in data.c.
6021 (Fisnan): Always define, since it's always available now.
6022 (syms_of_floatfns): Always define isnan at the Lisp level.
6023
e39b275c 60242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6025
6026 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6027
b2db44d9 60282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6029
f4af5137 6030 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6031 The previous code assumed that file offsets (off_t values) fit in
6032 EMACS_INT variables, which is not true on typical 32-bit hosts.
6033 The code messed up by falsely reporting buffer overflow in cases
6034 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6035 when "big" contains more than 2**29 bytes, even though this
6036 inserts just one byte and does not overflow the buffer.
6037 (Finsert_file_contents): Store file offsets as off_t
6038 values, not as EMACS_INT values. Check for overflow when
6039 converting between EMACS_INT and off_t. When checking for
6040 buffer overflow or for overlap, take the offsets into account.
6041 Don't use EMACS_INT for small values where int suffices.
6042 When checking for overlap, fix a typo: ZV was used where
6043 ZV_BYTE was intended.
6044 (Fwrite_region): Don't assume off_t fits into 'long'.
6045 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6046
ecfc0a49
MA
60472011-09-05 Michael Albinus <michael.albinus@gmx.de>
6048
6049 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6050
6511acf2 60512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6052
0999621a 6053 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6054
6055 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6056 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6057 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6058 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6059 (modify_event_symbol): Do not assume that the length of
6060 name_alist_or_stem is safe to alloca and fits in int.
6061 (Fexecute_extended_command): Likewise for function name and binding.
6062 (Frecursion_depth): Wrap around reliably on integer overflow.
6063 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6064 since some callers pass EMACS_INT values.
6065 (Fsingle_key_description): Don't crash if symbol name contains more
6066 than MAX_ALLOCA bytes.
6067 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6068 (get_minibuffer): Arg is now EMACS_INT, not int.
6069 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6070 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6071 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6072
2be7d702
PE
6073 * dbusbind.c (signature_cat): New function.
6074 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6075 Do not overrun buffer; instead, report string overflow.
6076
9d1df220
PE
6077 * dispnew.c (add_window_display_history): Don't overrun buffer.
6078 Truncate instead; this is OK since it's just a log.
6079
33ef5c64
PE
6080 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6081 even if the time zone offset is outlandishly large.
6082 Don't mishandle offset == INT_MIN.
6083
66c6fdd5
PE
6084 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6085 when creating daemon; the previous buffer-overflow check was incorrect.
6086
d749b01b
PE
6087 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6088 which has the guts of the old verror function.
6089
b5cd1905
PE
6090 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6091 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6092
6e1a67fb
PE
6093 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6094 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6095 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6096 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6097 length of string rather than counting it via multiple sprintfs;
6098 that's simpler and more reliable.
c21721cc
PE
6099 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6100 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6101 sprintf, in case result does not fit in int.
6102
c57b67fc
PE
6103 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6104 (fontset_from_font): Print it.
6105
8a401434
PE
6106 * frame.c (tty_frame_count): Now printmax_t, not int.
6107 (make_terminal_frame, set_term_frame_name): Print it.
6108 (x_report_frame_params): In X, window IDs are unsigned long,
6109 not signed long, so print them as unsigned.
6110 (validate_x_resource_name): Check for implausibly long names,
6111 and don't assume name length fits in 'int'.
6112 (x_get_resource_string): Don't blindly alloca invocation name;
6113 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6114 not fit in int.
6115
6e1a67fb
PE
6116 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6117 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6118 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6119
0df02bf3
PE
6120 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6121 Use esprintf, not sprintf, in case result does not fit in int.
6122
48e30793
PE
6123 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6124 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6125 it as a large positive number.
6126 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6127 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6128
a66ff6d8
PE
6129 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6130 in case result does not fit in int.
6131
aca216ff
PE
6132 * print.c (float_to_string): Detect width overflow more reliably.
6133 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6134 buffer overrun. Don't assume list length fits in 'int'. Treat
6135 print length of 0 as 0, not as infinity; to be consistent with other
6136 uses of print length in this function. Don't overflow print length
6137 index. Don't assume hash table size fits in 'long', or that
6138 vectorlike size fits in 'unsigned long'.
6139
31c286f7
PE
6140 * process.c (make_process): Use printmax_t, not int, to format
6141 process-name gensyms.
6142
55e5faa1
PE
6143 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6144
80f2e268
PE
6145 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6146 to avoid potential buffer overrun.
6147
670741ab
PE
6148 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6149 if X resource line is longer than 512 bytes.
6150
b7163a50
PE
6151 * xfns.c (x_window): Make sprintf buffer a bit bigger
6152 to avoid potential buffer overrun.
6153
ae58ff1f
PE
6154 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6155
c43c8a6a
PE
6156 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6157
3f8236f4
PE
61582011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6159
53e9fe90 6160 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6161 Without these, Emacs silently mishandles large integers sometimes.
6162 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6163 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6164
6511acf2
PE
6165 * xdisp.c (try_window_id): Check Emacs fixnum range before
6166 converting to 'int'.
806add1d 6167
6511acf2 6168 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6169 Check that an Emacs fixnum is in range before assigning it to 'int'.
6170 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6171 values converted from Emacs fixnums.
6172 (Frecenter): Don't wrap around a line count if it is out of 'int'
6173 range; instead, treat it as an extreme value.
6174 (Fset_window_configuration, compare_window_configurations):
6175 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6176
6511acf2
PE
6177 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6178 that can exceed INT_MAX. Check that EMACS_INT value is in range
6179 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6180 (match_limit): Don't assume that a fixnum can fit in 'int'.
6181
6511acf2 6182 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6183 exceed INT_MAX.
6184
6511acf2 6185 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6186 (Fvertical_motion): Don't wrap around LINES values that don't fit
6187 in 'int'. Instead, treat them as extreme values. This is good
6188 enough for windows, which can't have more than INT_MAX lines anyway.
6189
fcb901a7
LMI
61902011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6191
0f2f6b6d
LMI
6192 * Require libxml/parser.h to avoid compilation warning.
6193
fcb901a7
LMI
6194 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6195
6196 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6197 since this reportedly can destroy thread storage.
6198
6e20a0d4
CY
61992011-08-30 Chong Yidong <cyd@stupidchicken.com>
6200
6201 * syntax.c (find_defun_start): Update all cache variables if
6202 exiting early (Bug#9401).
6203
148ae00e
EZ
62042011-08-30 Eli Zaretskii <eliz@gnu.org>
6205
f6cfbd8f
EZ
6206 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6207
148ae00e
EZ
6208 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6209 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6210 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6211
6212 * term.c (tty_append_glyph): New function.
6213 (produce_stretch_glyph): Static function and its prototype deleted.
6214
a66cfb1c
SM
6215 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6216 Add prototypes.
148ae00e 6217
c4a07a4c
PE
62182011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6219
6220 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6221 when checking :margin (Bug#9390).
6222 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6223 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6224 so that the name doesn't mislead. All uses changed.
6225
6bc8cd65
JB
62262011-08-28 Johan Bockgård <bojohan@gnu.org>
6227
6228 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6229 set_tty_hooks.
6230
dca4927e
EZ
62312011-08-27 Eli Zaretskii <eliz@gnu.org>
6232
6233 * xdisp.c (move_it_to): Don't bail out early when reaching
6234 position beyond to_charpos, if we are scanning backwards.
6235 (move_it_vertically_backward): When DY == 0, make sure we get to
6236 the first character in the line after the newline.
6237
f2cad773
PE
62382011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6239
6240 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6241 (ccl_driver): Do not generate an out-of-range pointer.
6242 (Fccl_execute_on_string): Remove unnecessary check for
6243 integer overflow, noted by Stefan Monnier in
6244 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6245 Remove a FIXME that didn't need fixing.
6246 Simplify the newly-introduced buffer reallocation code.
6247
0cae2cdb
JB
62482011-08-27 Juanma Barranquero <lekktu@gmail.com>
6249
6250 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6251
5fc295a4 62522011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6253
70c60eb2 6254 Integer and memory overflow issues (Bug#9196).
726e0ab1 6255
d31850da
PE
6256 * doc.c (get_doc_string): Rework so that
6257 get_doc_string_buffer_size is the actual buffer size, rather than
6258 being 1 less than the actual buffer size; this makes xpalloc more
6259 convenient.
6260
a69fbedb
PE
6261 * image.c (x_allocate_bitmap_record, cache_image):
6262 * xselect.c (Fx_register_dnd_atom):
6263 Simplify previous changes by using xpalloc.
6264
fe5c5d37
PE
6265 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6266 since either will do and ptrdiff_t is convenient with xpalloc.
6267
0065d054
PE
6268 * charset.c (charset_table_size)
6269 (struct charset_sort_data.priority): Now ptrdiff_t.
6270 (charset_compare): Don't overflow if priorities differ greatly.
6271 (Fsort_charsets): Don't assume list length fits in int.
6272 Check for size-calculation overflow when allocating sort data.
6273 (syms_of_charset): Allocate an initial charset table that is
6274 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6275
6276 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6277
6278 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6279 The actual value is always <= INT_MAX, and leaving it unsigned made
6280 overflow checking harder.
6281
6282 * dispextern.h (struct glyph_matrix.rows_allocated)
6283 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6284 with xpalloc. The values are still always <= INT_MAX.
6285
6286 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6287
6288 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6289 (SAFE_NALLOCA): New macro.
6290
6291 * region-cache.c (struct boundary.pos, find_cache_boundary)
6292 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6293 (set_cache_region, invalidate_region_cache)
6294 (revalidate_region_cache, know_region_cache, region_cache_forward)
6295 (region_cache_backward, pp_cache):
6296 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6297 so that ptrdiff_t * can be passed to xpalloc.
6298 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6299 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6300 (pp_cache): Don't assume cache_len fits in int.
6301 * region-cache.h: Adjust extern decls to match.
6302
6303 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6304 EMACS_INT, since either will do, for xpalloc.
6305
6306 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6307 (xnmalloc, xnrealloc, xpalloc): New functions.
6308
726e0ab1
PE
6309 * bidi.c (bidi_shelve_header_size): New constant.
6310 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6311 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6312
51f30bc5 6313 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6314 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6315 (overlay_strings):
6316 Don't update size of array until after memory allocation succeeds,
6317 because xmalloc/xrealloc may not return.
0065d054
PE
6318 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6319 now that we have proper integer overflow checking.
6320 (record_overlay_string, overlay_strings): Catch overflows when
6321 calculating size of overlay_str_buf.
726e0ab1 6322
0065d054
PE
6323 * callproc.c (Fcall_process): Check for size overflow when
6324 calculating size of args2.
6325 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6326 Normally we prefer signed values, but sticking with ptrdiff_t would
6327 require adding more-complicated checks.
726e0ab1
PE
6328
6329 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6330 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6331 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6332 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6333
6334 * character.c (Fstring): Check for size-calculation overflow.
6335
6336 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6337 unnecessary integer overflow. Check for size overflow.
6338 (encode_coding_object): Don't update size until xmalloc succeeds.
6339
6340 * composite.c (get_composition_id): Check for overflow in glyph
6341 length calculations.
6342
6343 Integer and memory overflow fixes for display code.
6344 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6345 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6346 (scrolling_window): Check for overflow in size calculations.
6347 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6348 Don't assume glyph table len fits in int.
6349 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6350 (row_table_size): Now ptrdiff_t, not int.
6351 (scrolling_window): Avoid overflow in size calculations.
6352 Don't update size until allocation succeeds.
6353 * fns.c (concat): Check for overflow in size calculations.
6354 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6355 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6356 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6357
6358 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6359 (get_doc_string): Check for size calculation overflow.
6360 Don't update size until allocation succeeds.
6361 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6362 EMACS_INT, where ptrdiff_t will do.
6363 (Fsubstitute_command_keys): Check for string overflow.
6364
6365 * editfns.c (set_time_zone_rule): Don't assume environment length
6366 fits in int.
6367 (message_length): Now ptrdiff_t, not int.
6368 (Fmessage_box): Don't update size until allocation succeeds.
6369 Don't assume message length fits in int.
6370 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6371
0065d054
PE
6372 * emacs.c (main): Do not reallocate argv, since there is a null at
6373 the end that can be overwritten, and this way there's no need to
6374 worry about size-calculation overflow.
6375 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6376
6377 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6378 alloc succeeds.
6379 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6380
6381 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6382 (x_set_scroll_bar_width, x_figure_window_size):
6383 Check for integer overflow.
6384 (x_set_alpha): Do not assume XINT fits in int.
6385
6386 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6387 This is for the members text_lines, text_cols, total_lines, total_cols,
6388 where the system imposes an 'int' limit.
6389
6390 * fringe.c (Fdefine_fringe_bitmap):
6391 Don't update size until alloc works.
6392
6393 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6394 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6395
6396 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6397 Check for size-calculation overflow.
6398 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6399 do, as we prefer signed integers.
6400 (id_to_widget.max_size, id_to_widget.used)
6401 (xg_store_widget_in_map, xg_remove_widget_from_map)
6402 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6403 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6404 Use and return ptrdiff_t, not int.
6405 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6406 * gtkutil.h: Change prototypes to match the above.
6407
6408 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6409 are duplicate now that they've been promoted to lisp.h.
6410 (x_allocate_bitmap_record, x_alloc_image_color)
6411 (make_image_cache, cache_image, xpm_load):
6412 Don't update size until alloc is done.
6413 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6414 (x_detect_edges):
3256efce 6415 Check for size calculation overflow.
726e0ab1
PE
6416 (ct_colors_allocated_max): New constant.
6417 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6418 overflow.
3256efce 6419
726e0ab1
PE
6420 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6421 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6422 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6423 Use ptrdiff_t, not int, to count maps.
6424 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6425 calculations. Don't update size until allocation succeeds.
6426 Redo calculations to avoid overflow.
726e0ab1
PE
6427 * keyboard.h: Change prototypes to match the above.
6428
6429 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6430 to count maps.
6431 (current_minor_maps): Check for size calculation overflow.
6432 * keymap.h: Change prototypes to match the above.
6433
6434 * lread.c (read1, init_obarray): Don't update size until alloc done.
6435
6436 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6437 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6438
726e0ab1
PE
6439 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6440 Now ptrdiff_t, not int.
6441 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6442 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6443
6444 * process.c (Fnetwork_interface_list): Check for overflow
6445 in size calculation.
6446
6447 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6448
6449 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6450 overflow. Don't bother calling xmalloc when xrealloc will do.
6451
6452 * search.c (Freplace_match): Check for size calculation overflow.
6453 (Fset_match_data): Don't assume list lengths fit in 'int'.
6454
6455 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6456 for command line length. Do not attempt to address one before the
6457 beginning of an array, as that's not portable.
6458
6459 * term.c (max_frame_lines): Remove; unused.
6460 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6461 not int.
6462 (encode_terminal_code, calculate_costs): Check for size
6463 calculation overflow.
6464 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6465 table lengths and related sizes. Don't update size until alloc
6466 done. Redo calculations to avoid overflow.
6467 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6468
6469 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6470 subtracting pointers.
6471 (gobble_line): Check for overflow more carefully. Don't update size
6472 until alloc done.
6473
6474 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6475 Don't update size until alloc done.
6476 Redo size calculations to avoid overflow.
6477 Check for size calculation overflow.
0065d054 6478 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6479
6480 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6481 Use ptrdiff_t, not int, for sizes.
6482 (store_mode_line_noprop_char): Don't update size until alloc done.
6483
0065d054
PE
6484 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6485 Use ptrdiff_t, not int, for sizes.
6486 (Finternal_make_lisp_face, cache_face):
6487 Check for size calculation overflow.
6488 (cache_face): Treat size calculation overflows as if they were
6489 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6490
6491 * xfns.c (x_encode_text, x_set_name_internal)
6492 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6493 sizes, since they can exceed INT_MAX in size. Check for size
6494 calculation overflow.
6495
0065d054
PE
6496 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6497 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6498 Don't update size until alloc done.
6499
0065d054 6500 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6501 as sprintf is limited to int lengths.
1d526e2f 6502
252c5ee1
PE
6503 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6504 (X_LONG_MIN): New macros.
864d7ce7
PE
6505 Use them to make the following changes clearer.
6506 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6507 This change doesn't affect the value now, but it may help remind
6508 future maintainers not to raise the value too much later.
6509 (SELECTION_QUANTUM): Remove, replacing with ...
6510 (selection_quantum): ... new function, which avoids overflow.
6511 All uses changed.
6512 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6513 assumption that selection length fits in 'int'.
6514 (x_reply_selection_request, x_handle_selection_request)
6515 (x_get_window_property, receive_incremental_selection)
6516 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6517 (lisp_data_to_selection_data, clean_local_selection_data):
6518 Use ptrdiff_t, not int, to record length of selection.
6519 (x_reply_selection_request, x_get_window_property)
6520 (receive_incremental_selection, x_property_data_to_lisp):
6521 Redo calculations to avoid overflow.
6522 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6523 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6524 something.
6525 (x_get_window_property, receive_incremental_selection)
6526 (lisp_data_to_selection_data, x_property_data_to_lisp):
6527 Check for size-calculation overflow.
6528 (x_get_window_property, receive_incremental_selection)
6529 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6530 Don't store size until memory allocation succeeds.
6531 (x_get_window_property): Plug memory leak on memory exhaustion.
6532 Don't double-block input; malloc is safe here. Don't assume 2**34
6533 - 4 fits in unsigned long. Add an xassert to check
6534 XGetWindowProperty overflow. Be more careful about overflow
6535 calculations, and distinguish size from memory overflow better.
6536 (receive_incremental_selection): When tracing, don't assume
6537 unsigned int is less than INT_MAX.
6538 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6539 harmful) conversions of unsigned short to int.
6540 (lisp_data_to_selection_data): Don't assume that integers
6541 in the range -65535 through -1 fit in an X unsigned short.
6542 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6543 result parameters unless successful. Rely on cons_to_unsigned
6544 to report problems with elements; the old code wasn't right anyway.
6545 (x_check_property_data): Check for int overflow; we cannot use
6546 a wider type due to X limits.
6547 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6548
726e0ab1 6549 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6550
0065d054
PE
6551 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6552 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6553 (x_color_cells): Don't store size until memory allocation succeeds.
6554 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6555 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6556 (x_term_init): Don't assume length fits in int (sprintf is limited
6557 to int size).
bc18e09d 6558
ebfa62c0
PE
6559 Use ptrdiff_t for composition IDs.
6560 * character.c (lisp_string_width):
6561 * composite.c (composition_table_size, n_compositions)
6562 (get_composition_id, composition_gstring_from_id):
6563 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6564 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6565 * window.c (Frecenter):
6566 Use ptrdiff_t, not int, for composition IDs.
6567 * composite.c (get_composition_id): Check for integer overflow.
6568 * composite.h: Adjust prototypes to match the above changes.
6569
d3411f89
PE
6570 Use ptrdiff_t for hash table indexes.
6571 * category.c (hash_get_category_set):
6572 * ccl.c (ccl_driver):
6573 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6574 * coding.c (coding_system_charset_list, detect_coding_system):
6575 * coding.h (struct coding_system.id):
6576 * composite.c (get_composition_id, gstring_lookup_cache):
6577 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6578 * image.c (xpm_get_color_table_h):
6579 * lisp.h (hash_lookup, hash_put):
6580 * minibuf.c (Ftest_completion):
6581 Use ptrdiff_t for hash table indexes, not int (which is too
6582 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6583 32-bit --with-wide-int hosts).
6584
e097a6fa
PE
6585 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6586 Add a FIXME comment about memory leaks.
6587 (syms_of_charset): Don't assume xmalloc returns.
6588
5637687f
PE
6589 Don't assume that stated character widths fit in int.
6590 * character.c (Fchar_width, c_string_width, lisp_string_width):
6591 * character.h (CHAR_WIDTH):
6592 * indent.c (MULTIBYTE_BYTES_WIDTH):
6593 Use sanitize_char_width to avoid undefined and/or bad behavior
6594 with outlandish widths.
a66cfb1c 6595 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6596 now that we have two such functions. All uses changed.
6597 (sanitize_char_width): New inline function.
6598
a2271ba2
PE
6599 Don't assume that tab-width fits in int.
6600 * character.h (sanitize_width): New inline function.
6601 (SANE_TAB_WIDTH): New macro.
6602 (ASCII_CHAR_WIDTH): Use it.
6603 * indent.c (sane_tab_width): Remove. All uses replaced by
6604 SANE_TAB_WIDTH (current_buffer).
6605 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6606
18c52557
PE
6607 * fileio.c: Integer overflow issues with file modes.
6608 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6609
caeeedc1
PE
6610 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6611 Remove unreachable code.
6612 (read_hex, load_charset_map_from_file): Check for integer overflow.
6613
6df6ae42 6614 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6615 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6616 (x_send_scroll_bar_event): Likewise. Check that the size does not
6617 exceed limits imposed by XClientMessageEvent, as well as the usual
6618 ptrdiff_t and size_t limits.
6619
b13995db
PE
6620 * keyboard.c: Overflow, signedness and related fixes.
6621 (make_lispy_movement): Use same integer type in forward decl
6622 that is used in the definition.
6623 (read_key_sequence, keyremap_step):
6624 Change bufsize argument back to int, undoing my 2011-03-30 change.
6625 We prefer signed types, and int is wide enough here.
6626 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6627 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6628 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6629 length, not size_t. Use ptrdiff_t for index, not int.
6630 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6631 possibility of integer overflow.
6632
13464394
PE
6633 Overflow, signedness and related fixes for images.
6634
6635 * dispextern.h (struct it.stack[0].u.image.image_id)
6636 (struct_it.image_id, struct image.id, struct image_cache.size)
6637 (struct image_cache.used, struct image_cache.ref_count):
6638 * gtkutil.c (update_frame_tool_bar):
6639 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6640 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6641 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6642 * nsmenu.m (update_frame_tool_bar):
6643 * xdisp.c (calc_pixel_width_or_height):
6644 * xfns.c (image_cache_refcount):
6645 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6646 on typical 64-bit hosts.
6647
6648 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6649 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6650 Omit unnecessary casts to int.
6651 (parse_image_spec): Check that integers fall into 'int' range
6652 when the callers expect that.
6653 (image_ascent): Redo ascent calculation to avoid int overflow.
6654 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6655 (lookup_image): Remove unnecessary tests.
6656 (xbm_image_p): Locals are now of int, not EMACS_INT,
6657 since parse_image_check makes sure they fit into int.
6658 (png_load, gif_load, svg_load_image):
6659 Prefer int to unsigned where either will do.
6660 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6661 old tiff_error_handler and tiff_warning_handler.
6662 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6663 stack buffer overflows. It uses only the features of vsnprintf
6664 that are common to both POSIX and native Microsoft.
6665 (tiff_error_handler, tiff_warning_handler): Use it.
6666 (tiff_load, gif_load, imagemagick_load_image):
6667 Don't assume :index value fits in 'int'.
6668 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6669 (imagemagick_load_image): Check that crop parameters fit into
6670 the integer types that MagickCropImage accepts. Don't assume
6671 Vimagemagick_render_type has a nonnegative value. Don't assume
6672 size_t fits in 'long'.
6673 (gs_load): Use printmax_t to print the widest integers possible.
6674 Check for integer overflow when computing image height and width.
6675
c11821d4
EZ
66762011-08-26 Eli Zaretskii <eliz@gnu.org>
6677
6678 * xdisp.c (redisplay_window): Don't force window start if point
6679 will be invisible in the resulting window. (Bug#9324)
6680
0c95fcf7
EZ
66812011-08-25 Eli Zaretskii <eliz@gnu.org>
6682
6683 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6684 the display spec is of the form `(space ...)'.
6685 (handle_display_spec): Return the value returned by
6686 handle_single_display_spec, not just 1 or zero.
6687 (handle_single_display_spec): If the display spec is of the form
6688 `(space ...)', and specifies display in the text area, return 2
6689 rather than 1.
fee65a97 6690 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6691 accurately, and prefer exact match for point under bidi.
6692 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6693
6694 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6695 into disp_prop; all users changed.
6696
6697 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6698 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6699 for the text covered by the display property.
6700
e4ed06f1
CY
67012011-08-25 Chong Yidong <cyd@stupidchicken.com>
6702
6703 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6704 Change return value to nil.
6705 (Frecord_buffer): Delete unused function.
6706
f67cdd7f
EZ
67072011-08-24 Eli Zaretskii <eliz@gnu.org>
6708
5980d4c6
EZ
6709 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6710 buffers, return left-to-right.
8610fe8b
EZ
6711 (set_cursor_from_row): Consider candidate row a win if its glyph
6712 represents a newline and point is on that newline. Fixes cursor
6713 positioning on the newline at EOL of R2L text within L2R
6714 paragraph, and vice versa.
6715 (try_cursor_movement): Check continued rows, in addition to
6716 continuation rows. Fixes unwarranted scroll when point enters a
6717 continued line of R2L text within an L2R paragraph, or vice versa.
6718 (cursor_row_p): Consider the case of point being equal to
6719 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6720 from the end of a short line to the beginning of a continued line
6721 of R2L text within L2R paragraph.
6722 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6723 composed characters.
5980d4c6 6724
f67cdd7f
EZ
6725 * bidi.c (bidi_check_type): Use xassert.
6726 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6727 members.
6728
bca633fb
EZ
67292011-08-23 Eli Zaretskii <eliz@gnu.org>
6730
6731 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6732 a character.
6733
4a5885a7
CY
67342011-08-23 Chong Yidong <cyd@stupidchicken.com>
6735
6736 * nsfont.m (ns_otf_to_script): Fix typo.
6737
0902a04e
KH
67382011-08-22 Kenichi Handa <handa@m17n.org>
6739
6740 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6741 extra slot even if the purpose is char-code-property-table.
6742
1a2e6670
EZ
67432011-08-23 Eli Zaretskii <eliz@gnu.org>
6744
8ddde651
EZ
6745 * xdisp.c (redisplay_window): When computing centering_position,
6746 account for the height of the header line. (Bug#8874)
6747
425cc014
EZ
6748 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6749 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6750 candidate is selected by the mouse, and that candidate has a
6751 composed character under the mouse.
6752
1a2e6670
EZ
6753 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6754 coordinates reported by pos-visible-in-window-p for a composed
6755 character in column zero.
6756
8b76d6f8
SM
67572011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6758
6759 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6760
dac347dd
EZ
67612011-08-22 Eli Zaretskii <eliz@gnu.org>
6762
6763 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6764 consider it a hit if to_charpos is anywhere in the range of the
6765 composed buffer positions.
6766
e013fb34
CY
67672011-08-22 Chong Yidong <cyd@stupidchicken.com>
6768
6769 * image.c (gif_load): Don't assume that each subimage has the same
6770 dimensions as the base image. Handle disposal method that is
6771 "undefined" by the gif spec (Bug#9335).
6772
bd1ba3e8
CY
67732011-08-20 Chong Yidong <cyd@stupidchicken.com>
6774
6775 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6776 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6777
54a1215b
EZ
67782011-08-19 Eli Zaretskii <eliz@gnu.org>
6779
823564e5
EZ
6780 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6781 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6782 from an Org mode buffer to a Speedbar frame.
6783
54a1215b
EZ
6784 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6785 a composition, take its buffer position from IT->cmp_it.charpos.
6786 Fixes cursor positioning at the beginning of a line that begins
6787 with a composed character.
6788
9778ebcc
EZ
67892011-08-18 Eli Zaretskii <eliz@gnu.org>
6790
0be6ee06
EZ
6791 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6792 character bidirectional type, use STRONG_L instead. Fixes crashes
6793 in a buffer produced by `describe-categories'.
6794
9778ebcc
EZ
6795 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6796 members before the level stack, so they would be saved and
6797 restored when copying iterator state. Fixes incorrect reordering
6798 around TABs covered by display properties.
6799
156bffbe
AS
68002011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6801
6b02f655 6802 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6803
72ad093b
CY
68042011-08-17 Chong Yidong <cyd@stupidchicken.com>
6805
6806 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6807 (internal_condition_case_2, internal_condition_case_n):
6808 Remove unnecessary aborts (Bug#9081).
72ad093b 6809
35774242
EZ
68102011-08-17 Eli Zaretskii <eliz@gnu.org>
6811
6812 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6813 has no `load' handler, try opening the file locally. (Bug#9311)
6814
db76dd85
KB
68152011-08-16 Ken Brown <kbrown@cornell.edu>
6816
6817 * gmalloc.c: Expand comment.
6818
b215eee5
EZ
68192011-08-16 Eli Zaretskii <eliz@gnu.org>
6820
6821 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6822 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6823
a4579d33
KB
68242011-08-16 Ken Brown <kbrown@cornell.edu>
6825
6826 Fix memory allocation problems in Cygwin build (Bug#9273).
6827
6828 * unexcw.c ( __malloc_initialized): Declare external variable.
6829 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6830
8b76d6f8
SM
6831 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6832 New variables.
a4579d33
KB
6833 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6834 dumped emacs.
6835 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6836 in the static heap.
6837 [CYGWIN] (special_realloc): New function.
6838 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6839 requests to realloc storage in the static heap.
6840
3ebec551
PE
68412011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6842
6843 * bidi.c (bidi_initialize): Remove unused local.
6844
9fd8be00
EZ
68452011-08-15 Eli Zaretskii <eliz@gnu.org>
6846
6b02f655
SM
6847 * bidimirror.h:
6848 * biditype.h: Remove file.
6849 * makefile.w32-in ($(BLD)/bidi.$(O)):
6850 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6851
6852 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6853
6854 * chartab.c: Improve commentary for the uniprop_table API.
6855
32413314
EZ
6856 * bidi.c (bidi_paragraph_init): Support zero value of
6857 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6858 (bidi_initialize): Use uniprop_table instead of including
6859 biditype.h and bidimirror.h.
32413314 6860
9fd8be00
EZ
6861 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6862 coordinates of the iterator when restoring from ppos_it.
6863 (Bug#9296)
6864
5cf2b69b
KH
68652011-08-14 Kenichi Handa <handa@m17n.org>
6866
6867 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6868 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6869
daf17d00
EZ
68702011-08-14 Eli Zaretskii <eliz@gnu.org>
6871
6872 * xdisp.c (move_it_in_display_line_to): Don't invoke
6873 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6874 ppos_it. Fixes vertical cursor motion when line beginning is
6875 covered by an image. (Bug#9296)
6876
08e3161a
JD
68772011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6878
6879 * nsterm.h (ns_run_ascript): Declare.
6880 (NSAPP_DATA2_RUNASSCRIPT): Define.
6881
6882 * nsfns.m (as_script, as_result, as_status): New static variables.
6883 (ns_run_ascript): New function.
5e617bc2 6884 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6885 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6886 the event loop. Get status from as_status (Bug#7276).
6887
6888 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6889 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6890 the event loop (Bug#7276).
6891
a3720aa2
AS
68922011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6893
6894 * gnutls.c (QCgnutls_bootprop_priority)
6895 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6896 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6897 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6898 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6899 (QCgnutls_bootprop_verify_hostname_error)
6900 (QCgnutls_bootprop_callbacks_verify): Rename from
6901 Qgnutls_bootprop_..., all uses changed.
6902
6903 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6904 uses changed.
6905
0a0d27fb
PE
69062011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6907
19d5c50c
PE
6908 * xfaces.c (Qframe_set_background_mode): Now static.
6909 * dispextern.h (Qframe_set_background_mode): Remove decl.
6910
0a0d27fb
PE
6911 * process.c (Fnetwork_interface_info): Declare local only if needed.
6912
377538cb
JD
69132011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6914
6915 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6916 (Fnetwork_interface_list): Allocate in increments of bytes instead
6917 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6918 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6919 sockaddr.
6920 (struct ifflag_def): notrailers is smart on OSX.
6921 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6922 Get hardware address with getifaddrs if available.
6923
08fff70c
EZ
69242011-08-12 Eli Zaretskii <eliz@gnu.org>
6925
6926 * xdisp.c (iterate_out_of_display_property): xassert that
6927 IT->position is set to within IT->object's boundaries. Break from
6928 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6929 when IT->position is set up wrongly due to some bug.
6930 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6931 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6932 entry. Force push_it to save on the stack the current
6933 buffer/string position, to be restored by pop_it. Fix flags in
6934 the iterator structure wrt the object coming from a display
6935 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6936 properties. (Bug#9284)
6937
7be1c708 69382011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6939
7be1c708
CY
6940 * fontset.c (fontset_get_font_group): Add proper type checks.
6941 (Bug#9172)
aac0c6e3 6942
7be1c708 69432011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6944
7be1c708
CY
6945 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6946 and LC_VERSION_MIN_MACOSX.
6947 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6948 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6949
97bb72a6
EZ
69502011-08-08 Eli Zaretskii <eliz@gnu.org>
6951
6952 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6953 no-display-properties-and-no-overlays under bidi display.
6954 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6955 properties and overlays.
97bb72a6 6956
d5617611
CY
69572011-08-08 Chong Yidong <cyd@stupidchicken.com>
6958
37e11a63
CY
6959 * editfns.c (Fset_time_zone_rule): Document relationship with the
6960 setenv function.
6961
d5617611
CY
6962 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6963 the font entity extracted from the cache (Bug#8109).
6964
58872834
CY
69652011-08-07 Chong Yidong <cyd@stupidchicken.com>
6966
6967 * composite.c (autocmp_chars): Don't reset point. That is done by
6968 restore_point_unwind (Bug#5984).
6969
75bfc667
JL
69702011-08-07 Juri Linkov <juri@jurta.org>
6971
6972 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6973 to show the arg `TIME' instead of `TIMEVAL'.
6974
d1410150
EZ
69752011-08-06 Eli Zaretskii <eliz@gnu.org>
6976
6977 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6978 display property strides EOL and includes a newline, as in
6979 longlines-mode. (Bug#9254)
75b771e4
EZ
6980 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6981 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6982
6983 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6984 is non-zero, even if the data buffer is NULL. Fixes a crash in
6985 vertical-motion with longlines-mode. (Bug#9254)
6986
35928349
EZ
69872011-08-05 Eli Zaretskii <eliz@gnu.org>
6988
ec7cc85b
EZ
6989 * bidi.c <bidi_cache_total_alloc>: Now static.
6990 (bidi_initialize): Initialize bidi_cache_total_alloc.
6991
8b76d6f8 6992 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6993 cache. (Bug#9221)
6994
6995 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6996 amount allocated this far in `bidi_cache_total_alloc'.
6997 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6998 non-zero, only free the data buffer without restoring the cache
6999 contents. All callers changed.
7000
7001 * dispextern.h (bidi_unshelve_cache): Update prototype.
7002
7003 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7004 (move_it_in_display_line, move_it_to)
7005 (move_it_vertically_backward, move_it_by_lines): Replace the call
7006 to xfree to an equivalent call to bidi_unshelve_cache.
7007 (move_it_in_display_line_to): Fix logic of returning
412b6358 7008 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7009
e2e2423b
EZ
70102011-08-05 Eli Zaretskii <eliz@gnu.org>
7011
7012 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7013 came from a string character with a `cursor' property. (Bug#9229)
7014
ae9e757a
JD
70152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7016
7017 * Makefile.in (LIB_PTHREAD): New variable.
7018 (LIBES): Add LIB_PTHREAD (Bug#9216).
7019
7020 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7021 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7022
213bd7f2
AS
70232011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7024
6b02f655 7025 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7026
99aaf75f
JD
70272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7028
7029 * xterm.c (x_find_topmost_parent): New function.
7030 (x_set_frame_alpha): Find topmost parent window with
7031 x_find_topmost_parent and set the property there also (bug#9181).
7032 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7033
c74e9d86
PE
70342011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7035
7036 * callproc.c (Fcall_process): Avoid vfork clobbering
7037 the local vars buffer, coding_systems, current_dir.
7038
640c8776
SM
70392011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7040
7041 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7042
f26d0e4c
PE
70432011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7044
8a10d76c
PE
7045 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7046 so that it is not optimized away.
7047
f26d0e4c
PE
7048 * xdisp.c (compute_display_string_pos): Remove unused local.
7049
55439c61
EZ
70502011-08-02 Eli Zaretskii <eliz@gnu.org>
7051
7052 Fix slow cursor motion and scrolling in large buffers with
7053 selective display, like Org Mode buffers. (Bug#9218)
7054
7055 * dispextern.h (struct bidi_it): New member disp_prop_p.
7056
7057 * xdisp.c: Remove one-slot cache of display string positions.
7058 (compute_display_string_pos): Accept an additional argument
5e617bc2 7059 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7060 for a display string or property. If found, set DISP_PROP_P
7061 non-zero.
7062
7063 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7064 DISP_PROP_P, and pass it to compute_display_string_pos.
7065 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7066 non-zero. All callers of bidi_fetch_char changed.
7067
fb33fa43
SM
70682011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7069
7070 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7071
b099e063
DM
70722010-12-03 Don March <don@ohspite.net>
7073
7074 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7075 last character M-[char] is translated to ESC [char] (bug#7541).
7076
5cc7f7af
KH
70772011-08-02 Kenichi Handa <handa@m17n.org>
7078
d0fffa3f 7079 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7080
7081 * chartab.c (uniprop_table): Make it non-static.
7082
525d5e6e
EZ
70832011-08-01 Eli Zaretskii <eliz@gnu.org>
7084
7085 * xdisp.c (forward_to_next_line_start): Accept additional argument
7086 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7087 on the newline.
7088 (reseat_at_next_visible_line_start): Use the bidi iterator state
7089 returned by forward_to_next_line_start to restore the state of
7090 it->bidi_it after backing up to previous newline. (Bug#9212)
7091
31011111
AS
70922011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7093
7094 * regex.c (re_comp): Protoize.
7095 (re_exec): Fix return type.
7096 (regexec): Fix type of `ret'. (Bug#9203)
7097
476371c4
PE
70982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7099
e5d76069
PE
7100 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7101 This is needed if max-image-size is a floating-point number.
7102
9a79b20c
AS
71032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7104
7105 * print.c (print_object): Print empty symbol as ##.
7106
7107 * lread.c (read1): Read ## as empty symbol.
7108
d8c2fa78
AA
71092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7110
7111 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7112 setting frame foreground color (Bug#9175).
7113 (x_set_background_color): Likewise.
7114
ffe57a7a
AA
7115 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7116 contents (Bug#9176).
7117 (EmacsTooltip -init): Remove bezels and add shadows to
7118 tooltip windows.
7119
bf3492a5
AA
7120 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7121 or scroll bar (Bug#8470).
7122
d55e9c53
AA
7123 * nsfont.m (nsfont_open): Remove assignment to voffset and
7124 unnecessary vars hshink, expand, hd, full_height, min_height.
7125 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7126
7127 * nsterm.h (nsfont_info): Remove voffset field.
7128
d8c2fa78 71292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7130
7131 Implement strike-through and overline on NextStep (Bug#8863).
7132
7133 * nsfont.m (nsfont_open): Use underline position provided by font,
7134 instead of hard-coded value of 2.
7135 (nsfont_draw): Call ns_draw_text_decoration instead.
7136
7137 * nsterm.h: Add declaration for ns_draw_text_decoration.
7138
7139 * nsterm.m (ns_draw_text_decoration): New function for drawing
7140 underline, overline, and strike-through.
7141 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7142 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7143 accommodate underlining, etc.
4843aac3 7144
4cc60b9b
EZ
71452011-07-28 Eli Zaretskii <eliz@gnu.org>
7146
bc7ece87
EZ
7147 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7148 default.
4cc60b9b 7149
476371c4
PE
71502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7151
66606eea
PE
7152 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7153 Without this fix, if a signal arrives just after memory fills up,
7154 'malloc' might be invoked reentrantly.
7155
476371c4
PE
7156 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7157 In other words, assume that every image size is allowed, on non-X
7158 hosts. This assumption is probably wrong, but it lets Emacs compile.
7159
f3fcc40d
AS
71602011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7161
7162 * regex.c (re_iswctype): Convert return values to boolean.
7163
350c992f
EZ
71642011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7165
7166 * xdisp.c (compute_display_string_pos): Don't use cached display
7167 string position if the buffer had its restriction changed.
7168 (Bug#9184)
7169
5266b4bb
PE
71702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7171
7172 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7173
2573a837 71742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7175
41f55ccd 7176 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7177
39e378da
PE
7178 * bidi.c: Integer size and overflow fixes.
7179 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7180 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7181 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7182 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7183 (bidi_find_other_level_edge):
7184 Use ptrdiff_t instead of EMACS_INT where either will do.
7185 This works better on 32-bit hosts configured --with-wide-int.
7186 (bidi_cache_ensure_space): Check for size-calculation overflow.
7187 Use % rather than repeated addition, for better worst-case speed.
7188 Don't set bidi_cache_size until after xrealloc returns, because it
7189 might not return.
7190 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7191 (bidi_cache_ensure_space): Also check that the bidi cache size
7192 does not exceed that of the largest Lisp string or buffer. See Eli
7193 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7194
5e927815
PE
7195 * alloc.c (__malloc_size_t): Remove.
7196 All uses replaced by size_t. See Andreas Schwab's note
7197 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7198
ca4aa935
PE
7199 * image.c: Improve checking for integer overflow.
7200 (check_image_size): Assume that f is nonnull, since
7201 it is always nonnull in practice. This is one less thing to
7202 worry about when checking for integer overflow later.
7203 (x_check_image_size): New function, which checks for integer
7204 overflow issues inside X.
7205 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7206 This removes the need for a memory_full check.
7207 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7208 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7209 (xbm_read_bitmap_data): Change locals back to 'int', since
7210 their values must fit in 'int'.
7211 (xpm_load_image, png_load, tiff_load):
7212 Invoke x_create_x_image_and_pixmap earlier,
7213 to avoid much needless work if the image is too large.
7214 (tiff_load): Treat overly large images as if
7215 x_create_x_image_and_pixmap failed, not as malloc failures.
7216 (gs_load): Use x_check_image_size.
7217
5f8f9cc2
PE
7218 * gtkutil.c: Omit integer casts.
7219 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7220 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7221
5adf60bc
PE
7222 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7223
c8907a93
PE
7224 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7225 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7226 would wrongly return t on a 64-bit host.
7227
e3c25c68
PE
7228 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7229 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7230 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7231 and therefore cause GCC to emit a bogus diagnostic in some cases.
7232
3f791afe
PE
7233 * image.c: Integer signedness and overflow and related fixes.
7234 This is not an exhaustive set of fixes, but it's time to
7235 record what I've got.
7236 (lookup_pixel_color, check_image_size): Remove redundant decls.
7237 (check_image_size): Don't assume that arbitrary EMACS_INT values
7238 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7239 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7240 (tiff_load, imagemagick_load_image):
7241 Check for overflow in size calculations.
7242 (x_create_x_image_and_pixmap): Remove unnecessary test for
7243 xmalloc returning NULL; that can't happen.
7244 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7245 (xpm_color_bucket): Use better integer hashing function.
7246 (xpm_cache_color): Don't possibly over-allocate memory.
7247 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7248 (gif_memory_source):
7249 Use ptrdiff_t, not int or size_t, to record sizes.
7250 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7251 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7252 either works, as we prefer signed integers.
7253 (tiff_read_from_memory, tiff_write_from_memory):
7254 Return tsize_t, not size_t, since that's what the TIFF API wants.
7255 (tiff_read_from_memory): Don't fail simply because the read would
7256 go past EOF; instead, return a short read.
7257 (tiff_load): Omit no-longer-needed casts.
7258 (Fimagemagick_types): Don't assume size fits into 'int'.
7259
3cc5a532
PE
7260 Improve hashing quality when configured --with-wide-int.
7261 * fns.c (hash_string): New function, taken from sxhash_string.
7262 Do not discard information about ASCII character case; this
7263 discarding is no longer needed.
7264 (sxhash-string): Use it. Change sig to match it. Caller changed.
7265 * lisp.h: Declare it.
7266 * lread.c (hash_string): Remove, since we now use fns.c's version.
7267 The fns.c version returns a wider integer if --with-wide-int is
7268 specified, so this should help the quality of the hashing a bit.
7269
b312a492
PE
7270 * emacs.c: Integer overflow minor fix.
7271 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7272 Define only if GNU_LINUX.
7273 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7274
dfd153ae
PE
7275 * dispnew.c: Integer signedness and overflow fixes.
7276 Remove unnecessary forward decls, that were a maintenance hassle.
7277 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7278 All uses changed.
7279 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7280 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7281 (prepare_desired_row, line_draw_cost):
7282 Use int, not unsigned, where either works.
7283 (save_current_matrix, restore_current_matrix):
7284 Use ptrdiff_t, not size_t, where either works.
7285 (init_display): Check for overflow more accurately, and without
7286 relying on undefined behavior.
7287
a81d11a3
PE
7288 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7289 Remove, replacing with the new symbols in lisp.h. All uses changed.
7290 * fileio.c (make_temp_name):
7291 * filelock.c (lock_file_1, lock_file):
7292 * xdisp.c (message_dolog):
7293 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7294 Use pMd etc. instead.
7295 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7296 replacing the pWIDE etc. symbols removed from editfns.c.
7297
3300e6fd
PE
7298 * keyboard.h (num_input_events): Now uintmax_t.
7299 This is (very slightly) less likely to mess up due to wraparound.
7300 All uses changed.
7301
fd05c7e9
PE
7302 * buffer.c: Integer signedness fixes.
7303 (alloc_buffer_text, enlarge_buffer_text):
7304 Use ptrdiff_t rather than size_t when either will do, as we prefer
7305 signed integers.
7306
903fe15d
PE
7307 * alloc.c: Integer signedness and overflow fixes.
7308 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7309 (__malloc_size_t): Default to size_t, not to int.
7310 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7311 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7312 Prefer ptrdiff_t to size_t when either would do, as we prefer
7313 signed integers.
7314 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7315 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7316 Now const. Initialize with values that are in range even if char
7317 is signed.
7318 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7319 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7320 These functions do the right thing with sizes > 2**32.
7321 (check_depth): Now ptrdiff_t, not int.
7322 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7323 Adjust to new way of storing sizes. Check for size overflow bugs
7324 in rest of code.
7325 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7326 slightly wrong anyway, as it missed one instance of
7327 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7328 (refill_memory_reserve): Omit needless cast to size_t.
7329 (mark_object_loop_halt): Mark as externally visible.
7330
ac82cc6a
PE
7331 * xselect.c: Integer signedness and overflow fixes.
7332 (Fx_register_dnd_atom, x_handle_dnd_message):
7333 Use ptrdiff_t, not size_t, since we prefer signed.
7334 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7335 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7336 x_dnd_atoms_size and x_dnd_atoms_length.
7337
c2d1e36d
PE
7338 * doprnt.c: Prefer signed to unsigned when either works.
7339 * eval.c (verror):
7340 * doprnt.c (doprnt):
7341 * lisp.h (doprnt):
7342 * xdisp.c (vmessage):
7343 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7344 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7345 prefer signed arithmetic to avoid comparison confusion.
7346 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7347 but is a bit tricky.
7348
0e926e56
PE
7349 Assume freestanding C89 headers, string.h, stdlib.h.
7350 * data.c, doprnt.c, floatfns.c, print.c:
7351 Include float.h unconditionally.
7352 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7353 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7354 * regex.c: Likewise for stddef.h, string.h.
7355 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7356 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7357 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7358 (STDC_HEADERS): Remove obsolete defines.
7359 * sysdep.c: Include limits.h unconditionally.
7360
9cfdb3ec
PE
7361 Assume support for memcmp, memcpy, memmove, memset.
7362 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7363 * regex.c (memcmp, memcpy):
7364 Remove; we assume C89 now.
7365
7366 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7367 (__malloc_safe_bcopy): Remove; no longer needed.
7368
cf950e6b 7369 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7370 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7371 well either way, and we prefer signed to unsigned.
7372
dbf38e02
LMI
73732011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7374
7375 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7376 closes the connection while we're reading (bug#9182).
7377
d6f0886c 73782011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7379
d6f0886c
JD
7380 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7381 are specified (Bug#9168).
24e0f6b1 7382
2eb1f9e6
PE
73832011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7384
7385 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7386 Found by GCC static checking and --with-wide-int on a 32-bit host.
7387
22381272 73882011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7389
7390 * xdisp.c (compute_display_string_pos): Fix logic of caching
7391 previous display string position. Initialize cached_prev_pos to
7392 -1. Fixes slow-down at the beginning of a buffer.
7393
f25e39b4
EZ
73942011-07-24 Eli Zaretskii <eliz@gnu.org>
7395
7396 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7397 for attrs[LFACE_FONTSET_INDEX].
7398
04c4b52e
PE
73992011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7400
7401 * xml.c (parse_region): Remove unused local
7402 that was recently introduced.
7403
c1734fbd
EZ
74042011-07-23 Eli Zaretskii <eliz@gnu.org>
7405
be18c5a5
EZ
7406 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7407 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7408
c1734fbd
EZ
7409 * xdisp.c (move_it_in_display_line_to): Record the best matching
7410 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7411 exit if none of the characters scanned was an exact match.
7412 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7413 when exact match is impossible due to invisible text, and the
7414 lines are truncated.
7415
a258d627
JD
74162011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7417
7418 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7419 for OSX >= 10.7.
7420
b6d5a689
EZ
74212011-07-22 Eli Zaretskii <eliz@gnu.org>
7422
0f74f785
EZ
7423 Fix a significant slow-down of cursor motion with C-n, C-p,
7424 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7425 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7426 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7427 (next_element_from_buffer): Call compute_stop_pos_backwards to
7428 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7429 base_level_stop.
7430 (reseat): Don't look for prev_stop, as that could mean a very long
7431 run.
7432 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7433 <cached_disp_overlay_modiff>: Cache for last found display string
7434 position.
551918c1 7435 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7436 about the same buffer in the same area of character positions, and
7437 the buffer wasn't changed since the time the display string
7438 position was cached.
551918c1 7439
b2d0c91a
EZ
74402011-07-22 Eli Zaretskii <eliz@gnu.org>
7441
7442 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7443 is an integer, which is important for empty lines. (Bug#9149)
7444
043604ee
CY
74452011-07-22 Chong Yidong <cyd@stupidchicken.com>
7446
7447 * frame.c (Fmodify_frame_parameters): In tty case, update the
7448 default face if necessary (Bug#4238).
7449
da4adb04
CY
74502011-07-21 Chong Yidong <cyd@stupidchicken.com>
7451
7452 * editfns.c (Fstring_to_char): No need to explain what a character
7453 is in the docstring (Bug#6576).
7454
9abd0532
LMI
74552011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7456
7457 * xml.c (parse_region): Make sure we always return a tree.
7458
36881d16
HK
74592011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7460
7461 * xml.c (parse_region): If a document contains only comments,
7462 return that, too.
7463
1e98674d
LMI
74642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7465
7466 * xml.c (make_dom): Return comments, too.
7467
590bd467
PE
74682011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7469
7470 Port to OpenBSD.
7471 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7472 and the surrounding thread.
7473 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7474 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7475 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7476 timer goes off.
7477 * s/openbsd.h (BROKEN_SIGIO): Define.
7478 * unexelf.c (unexec) [__OpenBSD__]:
7479 Don't update the .mdebug section of the Alpha COFF symbol table.
7480
f41628b2
LMI
74812011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7482
7483 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7484 (bug#8460).
7485
b59b67c5
PE
74862011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7487
15e3a074
PE
7488 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7489 This fixes some race conditions on the permissions of any newly
7490 created file.
7491
41bed37d
PE
7492 * alloc.c (valid_pointer_p): Use pipe, not open.
7493 This fixes some permissions issues when debugging.
7494
b59b67c5
PE
7495 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7496 If fchown fails to set both uid and gid, try to set just gid,
7497 as that is sometimes allowed. Adjust the file's mode to eliminate
7498 setuid or setgid bits that are inappropriate if fchown fails.
7499
925a6be7
SM
75002011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7501
7502 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7503 to compare Lisp_Objects.
7504 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7505 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7506 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7507
52968808
AS
75082011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7509
0a6a104b
AS
7510 * lread.c (read_integer): Unread even EOF character.
7511 (read1): Likewise. Properly record start position of symbol.
7512
52968808
AS
7513 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7514 symbol character follows.
7515
9e381cdd
PE
75162011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7517
7518 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7519 This works around a problem with the previous change to Fcopy_file.
7520 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7521 and without this change, GCC might complain about discarding
7522 fchown's return value.
7523
b5641435
JB
75242011-07-16 Juanma Barranquero <lekktu@gmail.com>
7525
7526 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7527
a8031457
PE
75282011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7529
7530 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7531
dd889327
LMI
75322011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7533
750c33f7
LMI
7534 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7535 it's used from the C level.
7536
dd889327
LMI
7537 * process.c: Use the same condition for POLL_FOR_INPUT in both
7538 keyboard.c and process.c (bug#1858).
7539
87e86684
LM
75402011-07-09 Lawrence Mitchell <wence@gmx.li>
7541
7542 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7543 (Fgnutls_boot): Use it.
7544
64348f40
AS
75452011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7546
7547 * doc.c (Fsubstitute_command_keys): Revert last change.
7548
1d698799
LMI
75492011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7550
f863868c
LMI
7551 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7552 quotes the next character, and doesn't affect other longer
7553 sequences (bug#8935).
7554
1d698799
LMI
7555 * lread.c (syms_of_lread): Clarify that is isn't only
7556 `eval-buffer' and `eval-defun' that's affected by
7557 `lexical-binding' (bug#8460).
7558
aa4b6df6
EZ
75592011-07-15 Eli Zaretskii <eliz@gnu.org>
7560
7561 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7562 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7563
5d856da6
PE
75642011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7565
ad6042bb
PE
7566 Fix minor problems found by static checking.
7567 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7568 (elsz): Now a signed constant, not a size_t var. We prefer signed
7569 types to unsigned, to avoid integer comparison confusion. Without
7570 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7571 "cannot optimize loop, the loop counter may overflow", a symptom
7572 of the confusion.
f00bbb22 7573 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7574 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7575
6468f31c
LMI
75762011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7577
49080b10
LMI
7578 * search.c (Fre_search_backward): Mention `case-fold-search' in
7579 all the re_search_* functions (bug#8138).
7580
6468f31c
LMI
7581 * keyboard.c (Fopen_dribble_file): Document when the file is
7582 closed (bug#8056).
7583
c965adc5
EZ
75842011-07-14 Eli Zaretskii <eliz@gnu.org>
7585
df9733bf
EZ
7586 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7587 bidi_cache_idx.
7588
0bb23927
EZ
7589 Support bidi reordering of display and overlay strings.
7590 * xdisp.c (compute_display_string_pos)
7591 (compute_display_string_end): Accept additional argument STRING.
7592 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7593 (reseat_to_string): Initialize bidi_it->string.s and
7594 bidi_it->string.schars.
7595 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7596 NULL (avoids a crash in bidi_paragraph_init).
7597 Initialize itb.string.lstring.
0bb23927
EZ
7598 (init_iterator): Call bidi_init_it only of a valid
7599 buffer position was specified. Initialize paragraph_embedding to
7600 L2R.
7601 (reseat_to_string): Initialize the bidi iterator.
7602 (display_string): If we need to ignore text properties of
7603 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7604 original value of -1 will not work with bidi.)
7605 (compute_display_string_pos): First arg is now struct
7606 `text_pos *'; all callers changed. Support display properties on
7607 Lisp strings.
7608 (compute_display_string_end): Support display properties on Lisp
7609 strings.
7610 (init_iterator, reseat_1, reseat_to_string): Initialize the
7611 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7612 when iterating on a string not from display properties).
640c8776
SM
7613 (compute_display_string_pos, compute_display_string_end):
7614 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7615 arrow keys.
7616 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7617 base_level_stop; instead, set base_level_stop to BEGV.
7618 Fixes crashes in vertical-motion.
0bb23927
EZ
7619 (next_element_from_buffer): Improve commentary for when
7620 the iterator is before prev_stop.
7621 (init_iterator): Initialize bidi_p from the default value of
7622 bidi-display-reordering, not from buffer-local value. Use the
7623 buffer-local value only if initializing for buffer iteration.
7624 (handle_invisible_prop): Support invisible properties on strings
7625 that are being bidi-reordered.
7626 (set_iterator_to_next): Support bidi reordering of C strings and
7627 Lisp strings.
7628 (next_element_from_string): Support bidi reordering of Lisp
7629 strings.
7630 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7631 (display_string): Support display of R2L glyph rows.
7632 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7633 (init_iterator): Don't initialize it->bidi_p for strings
7634 here.
7635 (reseat_to_string): Initialize it->bidi_p for strings here.
7636 (next_element_from_string, next_element_from_c_string)
7637 (next_element_from_buffer): Add xassert's for correspondence
7638 between IT's object being iterated and it->bidi_it.string
7639 structure.
7640 (face_before_or_after_it_pos): Support bidi iteration.
7641 (next_element_from_c_string): Handle the case of the first string
7642 character that is not the first one in the visual order.
7643 (get_visually_first_element): New function, refactored from common
7644 parts of next_element_from_buffer, next_element_from_string, and
7645 next_element_from_c_string.
7646 (tool_bar_lines_needed, redisplay_tool_bar)
7647 (display_menu_bar): Force left-to-right direction. Add a FIXME
7648 comment for making that be controlled by a user option.
7649 (push_it, pop_it): Save and restore the state of the
7650 bidi iterator. Save and restore the bidi_p flag.
7651 (pop_it): Iterate out of display property for string iteration as
7652 well.
7653 (iterate_out_of_display_property): Support iteration over strings.
7654 (handle_single_display_spec): Set up it->bidi_it for iteration
7655 over a display string, and call bidi_init_it.
7656 (handle_single_display_spec, next_overlay_string)
7657 (get_overlay_strings_1, push_display_prop): Set up the bidi
7658 iterator for displaying display or overlay strings.
7659 (forward_to_next_line_start): Don't use the shortcut if
7660 bidi-iterating.
7661 (back_to_previous_visible_line_start): If handle_display_prop
7662 pushed the iterator stack, restore the internal state of the bidi
7663 iterator by calling bidi_pop_it same number of times.
7664 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7665 and we are bidi-iterating, don't decrement the iterator position;
7666 instead, set the first_elt flag in the bidi iterator, to produce
7667 the same effect.
7668 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7669 (push_display_prop): xassert that we are iterating a buffer.
7670 (push_it, pop_it): Save and restore paragraph_embedding member.
7671 (handle_single_display_spec, next_overlay_string)
7672 (get_overlay_strings_1, reseat_1, reseat_to_string)
7673 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7674 correctly. Don't assume unibyte strings are not bidi-reordered.
7675 (compute_display_string_pos)
7676 (compute_display_string_end): Fix handling the case of C string.
7677 (push_it, pop_it): Save and restore from_disp_prop_p.
7678 (handle_single_display_spec, push_display_prop): Set the
7679 from_disp_prop_p flag.
7680 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7681 (pop_it): Call iterate_out_of_display_property only if we are
7682 popping after iteration over a string that came from a display
7683 property. Fix a typo in popping stretch info. Add an assertion
7684 for verifying that the iterator position is in sync with the bidi
7685 iterator.
7686 (handle_single_display_spec, get_overlay_strings_1)
7687 (push_display_prop): Fix initialization of paragraph direction for
7688 string when that of the parent object is not yet determined.
7689 (reseat_1): Call bidi_init_it to resync the bidi
7690 iterator with IT's position. (Bug#7616)
7691 (find_row_edges): If ROW->start.pos gives position
7692 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7693 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7694 Reset the from_disp_prop_p flag.
7695 (SAVE_IT, RESTORE_IT): New macros.
7696 (pos_visible_p, face_before_or_after_it_pos)
7697 (back_to_previous_visible_line_start)
7698 (move_it_in_display_line_to, move_it_in_display_line)
7699 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7700 (try_scrolling, redisplay_window, display_line): Use them when
7701 saving a temporary copy of the iterator and restoring it back.
7702 (back_to_previous_visible_line_start, reseat_1)
7703 (init_iterator): Empty the bidi cache "stack".
7704 (move_it_in_display_line_to): If iterator ended up at
7705 EOL, but we never saw any buffer positions smaller than
7706 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7707 motion in bidi-reordered lines.
7708 (move_it_in_display_line_to): Record prev_method and prev_pos
7709 immediately before the call to set_iterator_to_next. Fixes cursor
7710 motion in bidi-reordered lines with stretch glyphs and strings
7711 displayed in margins. (Bug#8133) (Bug#8867)
7712 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7713 TO_CHARPOS.
640c8776
SM
7714 (pos_visible_p): Support positions in bidi-reordered lines.
7715 Save and restore bidi cache.
0bb23927
EZ
7716
7717 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7718 (bidi_paragraph_info): Delete unused struct.
7719 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7720 (bidi_cache_start): New variable.
7721 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7722 to zero.
7723 (bidi_cache_fetch_state, bidi_cache_search)
7724 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7725 (bidi_cache_find, bidi_peek_at_next_level)
7726 (bidi_level_of_next_char, bidi_find_other_level_edge)
7727 (bidi_move_to_visually_next): Compare cache index with
7728 bidi_cache_start rather than with zero.
7729 (bidi_fetch_char): Accept new argument STRING; all callers
7730 changed. Support iteration over a string. Support strings with
7731 display properties. Support unibyte strings. Fix the type of
7732 `len' according to what STRING_CHAR_AND_LENGTH expects.
7733 (bidi_paragraph_init, bidi_resolve_explicit_1)
7734 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7735 (bidi_level_of_next_char, bidi_move_to_visually_next):
7736 Support iteration over a string.
0bb23927
EZ
7737 (bidi_set_sor_type, bidi_resolve_explicit_1)
7738 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7739 can now be zero (for strings); special values 0 and -1 were
7740 changed to -1 and -2, respectively.
7741 (bidi_char_at_pos): New function.
7742 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7743 Call it instead of FETCH_MULTIBYTE_CHAR.
7744 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7745 initialized to valid values.
7746 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7747 values.
7748 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7749 the test for valid cached positions. Fix the logic for looking up
7750 the sentinel state in the cache. GCPRO the Lisp string we are
7751 iterating.
7752 (bidi_push_it, bidi_pop_it): New functions.
7753 (bidi_initialize): Initialize the bidi cache start stack pointer.
7754 (bidi_cache_ensure_space): New function, refactored from part of
7755 bidi_cache_iterator_state. Don't assume the required size is just
7756 one BIDI_CACHE_CHUNK away.
7757 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7758 (bidi_count_bytes, bidi_char_at_pos): New functions.
7759 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7760 always valid if bidi_cache_idx is valid.
7761 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7762 is valid if it's going to be used.
7763 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7764 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7765 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7766 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7767 (bidi_find_other_level_edge, bidi_cache_start_stack):
7768 All variables related to cache indices are now EMACS_INT.
c965adc5 7769
0bb23927
EZ
7770 * dispextern.h (struct bidi_string_data): New structure.
7771 (struct bidi_it): New member `string'. Make flag members be 1-bit
7772 fields, and put them last in the struct.
640c8776
SM
7773 (compute_display_string_pos, compute_display_string_end):
7774 Update prototypes.
0bb23927
EZ
7775 (bidi_push_it, bidi_pop_it): Add prototypes.
7776 (struct iterator_stack_entry): New members bidi_p,
7777 paragraph_embedding, and from_disp_prop_p.
7778 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7779 (bidi_shelve_cache, bidi_unshelve_cache):
7780 Declare prototypes.
0bb23927
EZ
7781
7782 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7783 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7784 and vector-like objects.
7785
7786 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7787 cache around display iteration.
7788
7789 * window.c (Fwindow_end, window_scroll_pixel_based)
7790 (displayed_window_lines, Frecenter): Save and restore the bidi
7791 cache around display iteration.
7792
3bbd2265
LMI
77932011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7794
7795 * editfns.c (Fdelete_region): Clarify the use of the named
7796 parameters (bug#6788).
7797
adc47434
MR
77982011-07-14 Martin Rudalics <rudalics@gmx.at>
7799
7800 * indent.c (Fvertical_motion): Set and restore w->pointm when
7801 saving and restoring the window's buffer (Bug#9006).
7802
837c31f8
LMI
78032011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7804
7805 * editfns.c (Fstring_to_char): Clarify just what is returned
7806 (bug#6576). Text by Eli Zaretskii.
7807
ac389d0c
JB
78082011-07-13 Juanma Barranquero <lekktu@gmail.com>
7809
7810 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7811
0be0ce47
EZ
78122011-07-13 Eli Zaretskii <eliz@gnu.org>
7813
7814 * buffer.c (mmap_find): Fix a typo.
7815
cd18e7e3
JB
78162011-07-13 Johan Bockgård <bojohan@gnu.org>
7817
7818 Fix execution of x selection hooks.
7819 * xselect.c (Qx_lost_selection_functions)
7820 (Qx_sent_selection_functions): New vars.
7821 (syms_of_xselect): DEFSYM them.
7822 (x_handle_selection_request): Pass Qx_sent_selection_functions
7823 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7824 (x_handle_selection_clear,x_clear_frame_selections):
7825 Pass Qx_lost_selection_functions rather than
7826 Vx_lost_selection_functions to Frun_hook_with_args.
7827
47ea7f44
PE
78282011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7829
ac389d0c 7830 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7831 The old code sometimes used this field without initializing it.
7832
47ea7f44
PE
7833 * alloc.c (gc_sweep): Don't read past end of array.
7834 In theory, the old code could also have corrupted Emacs internals,
7835 though it'd be very unlikely.
7836
bc985c87
AS
78372011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7838
7839 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7840 argument. (Bug#4026)
bc985c87 7841
0cf34688
LMI
78422011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7843
b3dadd76
LMI
7844 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7845 key" (bug#4257).
7846
0cf34688
LMI
7847 * window.c (Fset_window_start): Doc fix (bug#4199).
7848 (Fset_window_hscroll): Ditto.
7849
270768cd
PE
78502011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7851
077e3dda 7852 Fix minor new problems caught by GCC 4.6.1.
270768cd 7853 * term.c (init_tty): Remove unused local.
490011a6 7854 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7855 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7856 not used otherwise.
270768cd 7857
b1f58454
CY
78582011-07-12 Chong Yidong <cyd@stupidchicken.com>
7859
7860 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7861
22b9578d
LMI
78622011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7863
6e70ab07
LMI
7864 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7865 are the mini-buffer and the echo area (bug#3320).
7866
22b9578d
LMI
7867 * term.c (init_tty): Remove support for supdup, c10 and perq
7868 terminals, which are no longer supported (bug#1482).
7869
8974cc9f
JB
78702011-07-10 Johan Bockgård <bojohan@gnu.org>
7871
7872 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7873
a560d974
JD
78742011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7875
7876 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7877 for non-popups (Bug#3642).
7878
1dae0f0a
AS
78792011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7880
268c2c36 7881 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7882 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7883 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7884 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7885 * data.c (fmod): Likewise.
7886 * dispnew.c (swap_glyphs_in_rows): Likewise.
7887 * emacs.c (memory_warning_signal): Likewise.
7888 * floatfns.c (float_error): Likewise.
7889 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7890 (otf_open, font_otf_capability, generate_otf_features)
7891 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7892 Likewise.
7893 * image.c (pbm_read_file): Likewise.
7894 * indent.c (string_display_width): Likewise.
7895 * intervals.c (check_for_interval, search_for_interval)
7896 (inc_interval_count, count_intervals, root_interval)
7897 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7898 * lread.c (defalias): Likewise.
268c2c36 7899 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7900 * regex.c (set_image_of_range_1, set_image_of_range)
7901 (regex_grow_registers): Likewise.
7902 * sysdep.c (strerror): Likewise.
7903 * termcap.c (valid_filename_p, tprint, main): Likewise.
7904 * tparam.c (main): Likewise.
7905 * unexhp9k800.c (run_time_remap, save_data_space)
7906 (update_file_ptrs, read_header, write_header, calculate_checksum)
7907 (copy_file, copy_rest, display_header): Likewise.
7908 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7909 Likewise.
7910 * xdisp.c (check_it): Likewise.
7911 * xfaces.c (register_color, unregister_color, unregister_colors):
7912 Likewise.
7913 * xfns.c (print_fontset_result): Likewise.
7914 * xrdb.c (member, fatal, main): Likewise.
7915
99033785
PE
79162011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7917
7918 Fix minor problems found by static checking (Bug#9031).
7919 * chartab.c (char_table_set_range, map_sub_char_table):
7920 Remove unused locals.
7921 (uniprop_table): Now static.
7922 * composite.c (_work_char): Remove unused static var.
7923
9cb2ac56
JB
79242011-07-09 Juanma Barranquero <lekktu@gmail.com>
7925
7926 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7927
f25661f0
JD
79282011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7929
7930 * gtkutil.c (qttip_cb): Remove code without function.
7931
8278c4fe
EZ
79322011-07-09 Eli Zaretskii <eliz@gnu.org>
7933
7934 * w32.c (pthread_sigmask): New stub.
7935
1692ae2d 79362011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7937
8a6ebd58 7938 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7939 sigprocmask is portable only for single-threaded applications, and
7940 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7941 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7942 (LIBES): Use it.
7943 * callproc.c (Fcall_process):
7944 * process.c (create_process):
7945 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7946 Use pthread_sigmask, not sigprocmask.
123403e4 7947
1b854618
JD
79482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7949
7950 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7951 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7952 wrong (Bug#8591).
7953
3fe4b549
JD
79542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7955
0ce7e563
JD
7956 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7957 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7958 (xg_hide_tooltip): Fix comment.
7959
3fe4b549
JD
7960 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7961 in registerServicesMenuSendTypes.
7962 (validRequestorForSendType): Don't check ns_return_types.
7963
7964 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7965 ns_return_type.
7966
5df75e47
JR
79672011-07-08 Jason Rumney <jasonr@gnu.org>
7968
22610910
JR
7969 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7970 SH_SHOW for hidden windows (Bug#5482).
7971
5df75e47
JR
7972 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7973 frame struct members of non-existent frames (Bug#6284).
7974
699c10bd
JD
79752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7976
4393663b
JD
7977 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7978 variable firstTime not needed on OSX >= 10.6.
7979 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7980 >= 10.5. Use setKnobProportion, setDoubleValue.
7981
7982 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7983 (MAC_OS_X_VERSION_10_5): Define if not defined.
7984 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7985 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7986 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7987
7988 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7989 cString and lossyCString on OSX >= 10.4.
4393663b 7990
58179cce 7991 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7992 sizeToFit on OSX >= 10.2.
7993
7994 * nsimage.m (allocInitFromFile): Don't use deprecated method
7995 bestRepresentationForDevice on OSX >= 10.6.
7996
7997 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7998 to avoid warning.
7999
8000 * emacs.c: Declare unexec_init_emacs_zone.
8001
a63e0781
JD
8002 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8003
699c10bd
JD
8004 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8005
8006 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8007 on svcsMenu (Bug#8842).
8008
8009 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8010 ns_return_types.
8011 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8012
8013 * nsterm.m (QUTF8_STRING): Declare.
8014 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8015 (validRequestorForSendType): Return type is (id).
8016 Change indexOfObjectIdenticalTo to indexOfObject.
8017 Check if we have local selection before returning self (Bug#8842).
8018 (writeSelectionToPasteboard): Put local selection into paste board
8019 if we have a local selection (Bug#8842).
8020 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8021
8022 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8023 (ns_get_local_selection): Declare.
8024
54e10184
LMI
80252011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8026
9888ff71
LMI
8027 * keymap.c (describe_map_tree): Don't insert a double newline at
8028 the end of the buffer (bug#1169) and return whether we inserted
8029 something.
8030
54e10184
LMI
8031 * callint.c (Fcall_interactively): Change "reading args" to
8032 "providing args" to try to clarify what it does (bug#1010).
8033
15fa4783
KH
80342011-07-07 Kenichi Handa <handa@m17n.org>
8035
8036 * composite.c (composition_compute_stop_pos): Ignore a static
8037 composition starting before CHARPOS (Bug#8915).
8038
8039 * xdisp.c (handle_composition_prop): Likewise.
8040
a8815b00
EZ
80412011-07-07 Eli Zaretskii <eliz@gnu.org>
8042
8043 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8044 (Bug#9015)
8045
ef7b981d 80462011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8047
8048 * character.h (unicode_category_t): New enum type.
8049
8050 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8051 (Qchar_code_property_table): New variable.
8052 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8053 (UNIPROP_COMPRESSED_FORM_P): New macros.
8054 (char_table_ascii): Uncompress the compressed values.
8055 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8056 Uncompress the compressed values.
ac389d0c 8057 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8058 (char_table_ref_and_range): Uncompress the compressed values.
8059 (sub_char_table_set): New arg is_uniprop. Callers changed.
8060 Uncompress the compressed values.
8061 (sub_char_table_set_range): Args changed. Callers changed.
8062 (char_table_set_range): Adjuted for the above change.
8063 (map_sub_char_table): Delete args default_val and parent. Add arg
8064 top. Give decoded values to a Lisp function.
640c8776 8065 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8066 values to a Lisp function. Gcpro more variables.
8067 (uniprop_table_uncompress)
8068 (uniprop_decode_value_run_length): New functions.
8069 (uniprop_decoder, uniprop_decoder_count): New variables.
8070 (uniprop_get_decoder, uniprop_encode_value_character)
8071 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8072 New functions.
8073 (uniprop_encoder, uniprop_encoder_count): New variables.
8074 (uniprop_get_encoder, uniprop_table)
8075 (Funicode_property_table_internal, Fget_unicode_property_internal)
8076 (Fput_unicode_property_internal): New functions.
8077 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8078 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8079 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8080 char-code-property-alist.
8081
640c8776 8082 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8083 Vunicode_category_table.
8084
640c8776 8085 * font.c (font_range): Adjust for the change of
c805dec0
KH
8086 Vunicode_category_table.
8087
76b397fb
DN
80882011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8089
8090 * m/iris4d.h: Remove file, move contents ...
8091 * s/irix6-5.h: ... here.
8092
22b4128e
PE
80932011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8094
8095 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8096 * alloc.c (mark_buffer):
8097 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8098 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8099 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8100 This isn't true in general, and it's particularly not true
8101 if Emacs is configured with --with-wide-int.
8102 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8103 New macros, used in the buffer.c change.
8104
869795d6
JD
81052011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8106
8107 * xsettings.c: Use both GConf and GSettings if both are available.
8108 (store_config_changed_event): Add comment.
8109 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8110 (store_tool_bar_style_changed): New functions.
5e617bc2 8111 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8112 (struct xsettings): Move font inside HAVE_XFT.
8113 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8114 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8115 Move inside HAVE_XFT.
640c8776 8116 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8117 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8118 also.
8119 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8120 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8121 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8122 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8123 (parse_settings): Move check for font inside HAVE_XFT.
8124 (read_settings, apply_xft_settings): Add comment.
8125 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8126 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8127 call store_font_name_changed.
8128 (xft_settings_event): Add comment.
8129 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8130 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8131 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8132 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8133 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8134 (xsettings_get_system_font, xsettings_get_system_normal_font):
8135 Add comment.
869795d6 8136
d8ed26bd
PE
81372011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8138
8139 Random fixes. E.g., (random) never returned negative values.
8140 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8141 subseconds part to the entropy, as that's a bit more random.
8142 Prefer signed to unsigned, since the signedness doesn't matter and
8143 in general we prefer signed. When given a limit, use a
8144 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8145 latter isn't right if USE_2_TAGS_FOR_INTS.
8146 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8147 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8148
cabf1cac
SM
81492011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8150
8151 * textprop.c (text_property_stickiness):
8152 Obey Vtext_property_default_nonsticky.
8153 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8154 * w32fns.c (syms_of_w32fns):
8155 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8156
6e9b2be9
PE
81572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8158
8159 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8160 This is more efficient than Ffile_directory_p and avoids a minor race.
8161
90186c68
LMI
81622011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8163
7c301272
LMI
8164 * buffer.c (Foverlay_put): Say what the return value is
8165 (bug#7835).
8166
c4f2d8d4
LMI
8167 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8168 is a directory before asking whether to use the file name
8169 (bug#7564).
ad637907
LMI
8170 (barf_or_query_if_file_exists): Make the "File is a directory"
8171 error be more correct.
c4f2d8d4 8172
90186c68
LMI
8173 * fns.c (Frequire): Remove the mention of the .gz files, since
8174 that's installation-specific, but keep the mention of
8175 `get-load-suffixes'.
8176
da64016e
PE
81772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8178
8179 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8180 Report string overflow if the output is too long.
8181
7d47b580
JB
81822011-07-04 Juanma Barranquero <lekktu@gmail.com>
8183
a555cb87
JB
8184 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8185 (syms_of_gnutls): Remove duplicate DEFSYM for
8186 Qgnutls_bootprop_verify_hostname_error, an error for
8187 Qgnutls_bootprop_verify_error (which is no longer used).
8188
7d47b580
JB
8189 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8190 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8191 Also (re)move comments that are misplaced or no longer relevant.
8192
1e49bfab
LMI
81932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8194
8195 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8196
1485f4c0
CY
81972011-07-03 Chong Yidong <cyd@stupidchicken.com>
8198
8199 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8200 and background color parameters if they have been changed.
8201
a9ab721e
LMI
82022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8203
8204 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8205
cf7cff57
PE
82062011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8207
2e13213d
PE
8208 * xsettings.c (SYSTEM_FONT): Define only when used.
8209 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8210
cf7cff57
PE
8211 * keymap.c (access_keymap_1): Now static.
8212
7a8e04f7
CY
82132011-07-02 Chong Yidong <cyd@stupidchicken.com>
8214
8215 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8216 leave any prefix arg for the up event (Bug#1586).
8217
61352f62
LMI
82182011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8219
69bb1ef7
LMI
8220 * lread.c (syms_of_lread): Mention single symbols defined by
8221 `defvar' or `defconst' (bug#7154).
8222
61352f62 8223 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8224 (Frequire): Mention get-load-suffixes.
61352f62 8225
28545e04
MR
82262011-07-02 Martin Rudalics <rudalics@gmx.at>
8227
8228 * window.h (window): Remove clone_number slot.
8229 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8230 Remove.
8231 (make_parent_window, make_window, saved_window)
8232 (Fset_window_configuration, save_window_save): Don't deal with
8233 clone numbers.
8234 * buffer.c (Qclone_number): Remove declaration.
8235 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8236
3349e122
SM
82372011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8238
8239 Add multiple inheritance to keymaps.
8240 * keymap.c (Fmake_composed_keymap): New function.
8241 (Fset_keymap_parent): Simplify.
8242 (fix_submap_inheritance): Remove.
8243 (access_keymap_1): New function extracted from access_keymap to handle
8244 embedded parents and handle lists of maps.
8245 (access_keymap): Use it.
8246 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8247 (Fcopy_keymap): Handle embedded parents.
8248 (Fcommand_remapping, define_as_prefix): Simplify.
8249 (Fkey_binding): Simplify.
8250 (syms_of_keymap): Move minibuffer-local-completion-map,
8251 minibuffer-local-filename-completion-map,
8252 minibuffer-local-must-match-map, and
8253 minibuffer-local-filename-must-match-map to Elisp.
8254 (syms_of_keymap): Defsubr make-composed-keymap.
8255 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8256 (parse_menu_item): Trivial simplification.
8257
3279eb87
GM
82582011-07-01 Glenn Morris <rgm@gnu.org>
8259
8260 * Makefile.in (SETTINGS_LIBS): Fix typo.
8261
4550efdf
KI
82622011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8263
8264 * coding.c (Fencode_coding_string): Record the last coding system
8265 used, as the function doc string says (bug#8738).
8266
0949d2b6
JD
82672011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8268
8269 * xsettings.c (store_monospaced_changed): Take new font as arg and
8270 check for change against current_mono_font.
8271 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8272 (emacs_settings_constructor, emacs_settings_get_property)
8273 (emacs_settings_set_property, emacs_settings_class_init)
8274 (emacs_settings_init, gsettings_obj): Remove.
8275 (something_changedCB): New function for HAVE_GSETTINGS.
8276 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8277 with value as argument.
8278 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8279 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8280 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8281 "changed".
8282
8283 * xgselect.c: Add defined (HAVE_GSETTINGS).
8284 (xgselect_initialize): Ditto.
8285
8286 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8287 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8288 xg_select.
8289
bbc6b304
PE
82902011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8291
8292 * eval.c (struct backtrace): Simplify and port the data structure.
8293 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8294 signed bit field, as this assumption is not portable and it makes
8295 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8296 "char debug_on_exit : 1" as this is not portable either; instead,
8297 use the portable "unsigned int debug_on_exit : 1". Remove unused
8298 member evalargs. Remove obsolete comments about cc bombing out.
8299
9851bfc5
JD
83002011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8301
51bb811f 8302 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8303 Let HAVE_GSETTINGS override HAVE_GCONF.
8304 (store_monospaced_changed): New function.
8305 (EMACS_SETTINGS): A new type derived from GObject to handle
8306 GSettings notifications.
8307 (emacs_settings_constructor, emacs_settings_get_property)
8308 (emacs_settings_set_property, emacs_settings_class_init):
8309 New functions.
8310 (gsettings_client, gsettings_obj): New variables.
8311 (GSETTINGS_SCHEMA): New define.
8312 (something_changedCB): Call store_monospaced_changed.
8313 (init_gsettings): New function.
8314 (xsettings_initialize): Call init_gsettings.
8315 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8316 to NULL.
8317
640c8776 8318 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8319 GCONF_CFLAGS/LIBS.
8320
5386012d
MR
83212011-06-29 Martin Rudalics <rudalics@gmx.at>
8322
8323 * window.c (resize_root_window, grow_mini_window)
8324 (shrink_mini_window): Rename Qresize_root_window to
8325 Qwindow_resize_root_window and Qresize_root_window_vertically to
8326 Qwindow_resize_root_window_vertically.
8327
f13e0b08
PE
83282011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8329
8330 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8331
94515237
JB
83322011-06-27 Juanma Barranquero <lekktu@gmail.com>
8333
8334 * makefile.w32-in: Redesign dependencies so they reflect more
8335 clearly which files are directly included by each source file,
8336 and not through other includes.
8337
e43b6e43
MR
83382011-06-27 Martin Rudalics <rudalics@gmx.at>
8339
8340 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8341 (sort_overlays, overlay_strings): When an overlay's clone number
8342 matches the window's clone number process the overlay even if
8343 the overlay's window property doesn't match the current window.
8344
d68443dc
MR
8345 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8346 (Fwindow_hchild): Rename to Fwindow_left_child.
8347 (Fwindow_next): Rename to Fwindow_next_sibling.
8348 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8349 (resize_window_check): Rename to window_resize_check.
8350 (resize_window_apply): Rename to window_resize_apply.
8351 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8352 (Fdelete_other_windows_internal, resize_frame_windows)
8353 (Fsplit_window_internal, Fdelete_window_internal)
8354 (grow_mini_window, shrink_mini_window)
8355 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8356
c7e73be5
JD
83572011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8358
8359 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8360 (emacs_fixed_set_min_size): Remove.
8361 (emacs_fixed_new): Take frame as argument.
8362
8363 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8364 (_EmacsFixedPrivate): Remove minwidth/height.
8365 Add struct frame *f.
8366 (emacs_fixed_init): Initialize priv->f.
8367 (get_parent_class, emacs_fixed_set_min_size): Remove.
8368 (emacs_fixed_new): Set priv->f to argument.
8369 (emacs_fixed_get_preferred_width)
8370 (emacs_fixed_get_preferred_height): Use min_width/height from
8371 frames size_hint to set minimum and natural (Bug#8919).
8372 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8373 and use min_width/height from frames size_hint to set
8374 min_width/height (Bug#8919).
8375
8376 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8377 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8378 Fix indentation.
c7e73be5 8379
cf99dcf8
EZ
83802011-06-26 Eli Zaretskii <eliz@gnu.org>
8381
8382 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8383 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8384 called at ZV.
8385
029529ac
CY
83862011-06-26 Chong Yidong <cyd@stupidchicken.com>
8387
8388 * process.c (wait_reading_process_output): Bypass select if
8389 waiting for a cell while ignoring keyboard input, and input is
8390 pending. Suggested by Jan Djärv (Bug#8869).
8391
7a7ef429
PE
83922011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8393
8394 Use gnulib's dup2 module instead of rolling our own.
8395 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8396
11fdef7d 83972011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8398
8399 * dispnew.c (scrolling_window): Before scrolling, turn off a
8400 mouse-highlight in the window being scrolled.
8401
cd3520a4
JB
84022011-06-24 Juanma Barranquero <lekktu@gmail.com>
8403
8404 Move DEFSYM to lisp.h and use everywhere.
8405
8406 * character.h (DEFSYM): Move declaration...
8407 * lisp.h (DEFSYM): ...here.
8408
8409 * gnutls.c:
8410 * minibuf.c:
8411 * w32menu.c:
8412 * w32proc.c:
8413 * w32select.c: Don't include character.h.
8414
8415 * alloc.c (syms_of_alloc):
8416 * buffer.c (syms_of_buffer):
8417 * bytecode.c (syms_of_bytecode):
8418 * callint.c (syms_of_callint):
8419 * casefiddle.c (syms_of_casefiddle):
8420 * casetab.c (init_casetab_once):
8421 * category.c (init_category_once, syms_of_category):
8422 * ccl.c (syms_of_ccl):
8423 * cmds.c (syms_of_cmds):
8424 * composite.c (syms_of_composite):
8425 * dbusbind.c (syms_of_dbusbind):
8426 * dired.c (syms_of_dired):
8427 * dispnew.c (syms_of_display):
8428 * doc.c (syms_of_doc):
8429 * editfns.c (syms_of_editfns):
8430 * emacs.c (syms_of_emacs):
8431 * eval.c (syms_of_eval):
8432 * fileio.c (syms_of_fileio):
8433 * fns.c (syms_of_fns):
8434 * frame.c (syms_of_frame):
8435 * fringe.c (syms_of_fringe):
8436 * insdel.c (syms_of_insdel):
8437 * keymap.c (syms_of_keymap):
8438 * lread.c (init_obarray, syms_of_lread):
8439 * macros.c (syms_of_macros):
8440 * msdos.c (syms_of_msdos):
8441 * print.c (syms_of_print):
8442 * process.c (syms_of_process):
8443 * search.c (syms_of_search):
8444 * sound.c (syms_of_sound):
8445 * syntax.c (init_syntax_once, syms_of_syntax):
8446 * terminal.c (syms_of_terminal):
8447 * textprop.c (syms_of_textprop):
8448 * undo.c (syms_of_undo):
8449 * w32.c (globals_of_w32):
8450 * window.c (syms_of_window):
8451 * xdisp.c (syms_of_xdisp):
8452 * xfaces.c (syms_of_xfaces):
8453 * xfns.c (syms_of_xfns):
8454 * xmenu.c (syms_of_xmenu):
8455 * xsettings.c (syms_of_xsettings):
8456 * xterm.c (syms_of_xterm): Use DEFSYM.
8457
4228cf16
TZ
84582011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8459
cd3520a4 8460 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8461
7fcccf1e
PE
84622011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8463
7efb4e0e
PE
8464 Integer and buffer overflow fixes (Bug#8873).
8465
ff5844ad
PE
8466 * print.c (printchar, strout): Check for string overflow.
8467 (PRINTPREPARE, printchar, strout):
8468 Don't set size unless allocation succeeds.
8469
90532f02
PE
8470 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8471 for sizes. Check for string overflow more accurately.
8472 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8473
6d84508d
PE
8474 * macros.c: Integer and buffer overflow fixes.
8475 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8476 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8477 Use ptrdiff_t, not int, for sizes.
8478 Don't increment bufsize until after realloc succeeds.
8479 Check for size-calculation overflow.
8480 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8481
437b2cb4
PE
8482 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8483
8b9ac8b4
PE
8484 * lread.c: Integer overflow fixes.
8485 (read_integer): Radix is now EMACS_INT, not int,
8486 to improve quality of diagnostics for out-of-range radices.
8487 Calculate buffer size correctly for out-of-range radices.
8488 (read1): Check for integer overflow in radices, and in
8489 read-circle numbers.
82cb60d3
PE
8490 (read_escape): Avoid int overflow.
8491 (Fload, openp, read_buffer_size, read1)
8492 (substitute_object_recurse, read_vector, read_list, map_obarray):
8493 Use ptrdiff_t, not int, for sizes.
8494 (read1): Use EMACS_INT, not int, for sizes.
20270765 8495 Check for size overflow.
8b9ac8b4 8496
7fcccf1e
PE
8497 * image.c (cache_image): Check for size arithmetic overflow.
8498
bfbbd7e7
PE
8499 * lread.c: Integer overflow issues.
8500 (saved_doc_string_size, saved_doc_string_length)
8501 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8502 Now ptrdiff_t, not int.
8503 (read1): Don't assume doc string length fits in int. Check for
8504 out-of-range doc string lengths.
8505 (read_list): Don't assume file position fits in int.
39019e54 8506 (read_escape): Check for hex character overflow.
bfbbd7e7 8507
4e323265
LL
85082011-06-22 Leo Liu <sdl.web@gmail.com>
8509
8510 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8511 Move to minibuffer.el.
8512
85fece3e
PE
85132011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8514
20b84ce9 8515 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8516 The following patches are for when GLYPH_DEBUG && !XASSERT.
8517 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8518 * dispnew.c (flush_stdout):
8519 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8520 Mark as externally visible.
8521 * dispnew.c (check_window_matrix_pointers): Now static.
8522 * dispnew.c (window_to_frame_vpos):
8523 * xfns.c (unwind_create_frame):
8524 * xterm.c (x_check_font): Remove unused local.
8525 * scroll.c (CHECK_BOUNDS):
8526 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8527 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8528 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8529 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8530 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8531 Now static.
8532 (debug_method_add): Use va_list and vsprintf rather than relying
8533 on undefined behavior with wrong number of arguments.
8534 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8535 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8536 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8537 since we're not interested in debugging glyphs with old libraries.
8538 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8539 GCC 4.6.0's static checking.
8540
0766b489
PE
85412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8542
31fd4b32
PE
8543 Integer overflow and signedness fixes (Bug#8873).
8544 A few related buffer overrun fixes, too.
8545
b79e8648
PE
8546 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8547
0766b489
PE
8548 * dispextern.h (struct face.stipple):
8549 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8550 (x_bitmap_mask, x_allocate_bitmap_record)
8551 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8552 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8553 (x_create_bitmap_from_xpm_data):
8554 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8555 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8556 (.bitmaps_last):
8557 * xfaces.c (load_pixmap):
8558 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8559 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8560 (.bitmaps_last, struct x_output.icon_bitmap):
8561 Use ptrdiff_t, not int, for bitmap indexes.
8562 (x_allocate_bitmap_record): Check for size overflow.
8563 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8564
b081724f
PE
8565 Use ptrdiff_t, not int, for overlay counts.
8566 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8567 * editfns.c (overlays_around, get_pos_property):
8568 * textprop.c (get_char_property_and_overlay):
8569 * xdisp.c (next_overlay_change, note_mouse_highlight):
8570 * xfaces.c (face_at_buffer_position):
21514da7
PE
8571 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8572 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8573 (Fnext_overlay_change, Fprevious_overlay_change)
8574 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8575 Use ptrdiff_t, not int, for sizes.
21514da7 8576 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8577
3de73e5e
PE
8578 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8579
2606c57b
PE
8580 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8581 (x_session_initialize): Do not assume string length fits in int.
8582
aaafe47a
PE
8583 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8584 This is unlikely, but can occur if DPI is outlandish.
8585
2674ddc8 8586 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8587 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8588
28154962
PE
8589 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8590 * xrdb.c (magic_file_p, search_magic_path):
8591 Omit last arg SUFFIX; it was always 0. All callers changed.
8592 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8593
7de51af5
PE
8594 * xfont.c (xfont_match): Avoid need for strlen.
8595
25ed6cc3
PE
8596 * xfns.c: Don't assume strlen fits in int.
8597 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8598
4eab31dd
PE
8599 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8600 not unsigned long, as we prefer signed integers. All callers changed.
8601 Detect integer overflow in repeat count.
8602 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8603 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8604
171e2a58
PE
8605 * termcap.c: Don't assume sizes fit in int and never overflow.
8606 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8607 (gobble_line): Check for size-calculation overflow.
8608
ad39faca 8609 * minibuf.c (Fread_buffer):
6e5bb2dc 8610 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8611 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8612 Don't assume string length fits in int.
8613
52c61c22 8614 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8615 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8616
b5b8c9e5
PE
8617 * font.c: Don't assume string length fits in int.
8618 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8619 Use ptrdiff_t, not int.
ccd6111c
PE
8620 (font_intern_prop): Don't assume string length fits in int.
8621 Don't assume integer property fits in fixnum.
8622 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8623
882f0d81 8624 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8625 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8626 Reformulate so as not to need the command string.
8627 Invoke gzip -cd rather than gunzip, as it's more portable.
8628 (lock_info_type, lock_file_1, lock_file):
8629 Don't assume pid_t and time_t fit in unsigned long.
8630 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8631 (current_lock_owner): Prefer signed type for sizes.
8632 Use memcpy, not strncpy, where memcpy is what is really wanted.
8633 Don't assume (via atoi) that time_t and pid_t fit in int.
8634 Check for time_t and/or pid_t out of range, e.g., via a network share.
8635 Don't alloca where an auto var works fine.
8636
93f4cf88
PE
8637 * fileio.c: Fix some integer overflow issues.
8638 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8639 Don't assume string length fits in int.
8640 (directory_file_name): Don't assume string length fits in long.
8641 (make_temp_name): Don't assume pid fits in int, or that its print
8642 length is less than 20.
8643
f3e92b69
PE
8644 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8645
1bfdaf10
PE
8646 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8647
35016e9a
PE
8648 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8649
3d1e65a1
PE
8650 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8651 We prefer signed integers, even for size calculations.
8652
0b963a93
PE
8653 * emacs.c: Don't assume string length fits in 'int'.
8654 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8655 (main): Don't invoke strlen when not needed.
8656
573f4b54
PE
8657 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8658 (XD_DEBUG_MESSAGE): Don't waste a byte.
8659
989f33ba
PE
8660 * callproc.c (getenv_internal_1, getenv_internal)
8661 (Fgetenv_internal):
965d34eb
PE
8662 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8663
e4d29b33
PE
8664 * lread.c (invalid_syntax): Omit length argument.
8665 All uses changed. This doesn't fix a bug, but it simplifies the
8666 code away from its former Hollerith-constant appearance, and it's
8667 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8668 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8669
eb49b136
PE
8670 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8671 This didn't break anything, but it didn't help either.
8672 It's confusing to put a bogus integer in a place where the actual
8673 value does not matter.
9f62aeb1 8674 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8675 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8676
15375a22
PE
8677 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8678 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8679 implementation.
b61cc01c
PE
8680 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8681 We prefer signed types, and the value cannot exceed the EMACS_INT
8682 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8683 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8684 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8685 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8686
53b2623d
PE
8687 * indent.c (sane_tab_width): New function.
8688 (current_column, scan_for_column, Findent_to, position_indentation)
8689 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8690 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8691
51cab52b 8692 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8693
f2ed8a70
PE
8694 * lisp.h (lint_assume): New macro.
8695 * composite.c (composition_gstring_put_cache):
8696 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8697
abe80cc6
PE
8698 * editfns.c, insdel.c:
8699 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8700
b02c740e
PE
8701 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8702
ebc96716
PE
8703 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8704
b4e50fa0 8705 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8706 Use much-faster test for byte-length change.
311d5d7c 8707 Don't assume string byte-length fits in 'int'.
a4cf38e4 8708 Check that character arg fits in 'int'.
85461888 8709 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8710
c0c1ee9f
PE
8711 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8712
a498d7f4
PE
8713 * fns.c (concat): Catch string overflow earlier.
8714 Do not rely on integer wraparound.
8715
51cab52b
PE
8716 * dispextern.h (struct it.overlay_strings_charpos)
8717 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8718 * xdisp.c (forward_to_next_line_start)
8719 (back_to_previous_visible_line_start)
8720 (reseat_at_next_visible_line_start, next_element_from_buffer):
8721 Don't arbitrarily truncate the value of 'selective' to int.
8722
76031fad
PE
8723 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8724
5eb55db9
PE
8725 * composite.c: Don't truncate sizes to 'int'.
8726 (composition_gstring_p, composition_reseat_it)
8727 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8728 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8729 not EMACS_UINT, for indexes.
5eb55db9 8730
0703a717
PE
8731 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8732
d6202519
PE
8733 * buffer.c: Include <verify.h>.
8734 (struct sortvec.priority, struct sortstr.priority):
8961a454 8735 Now EMACS_INT, not int.
c20998a7 8736 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8737 (struct sortstr.size, record_overlay_string)
8738 (struct sortstrlist.size, struct sortlist.used):
8739 Don't truncate size to int.
8740 (record_overlay_string): Check for size-calculation overflow.
d6202519 8741 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8742
d5a19415
JM
87432011-06-22 Jim Meyering <meyering@redhat.com>
8744
029529ac 8745 Don't leak an XBM-image-sized buffer
d5a19415
JM
8746 * image.c (xbm_load): Free the image buffer after using it.
8747
a9041e6c
PE
87482011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8749
8750 Port to Sun C.
8751 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8752 that Sun C diagnosed.
8753 * fns.c (secure_hash): Fix pointer signedness issue.
8754 * intervals.c (static_offset_intervals): New function.
8755 (offset_intervals): Use it.
8756
7f3f739f
LL
87572011-06-21 Leo Liu <sdl.web@gmail.com>
8758
8759 * deps.mk (fns.o):
8760 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8761 sha512.h.
8762
8763 * fns.c (secure_hash): Rename from crypto_hash_function and change
8764 the first arg to accept symbols.
5b66d427 8765 (Fsecure_hash): New primitive.
7f3f739f
LL
8766 (syms_of_fns): New symbols.
8767
76147d94
DD
87682011-06-20 Deniz Dogan <deniz@dogan.se>
8769
8770 * process.c (Fset_process_buffer): Clarify return value in
8771 docstring.
8772
7d7d0045
CY
87732011-06-18 Chong Yidong <cyd@stupidchicken.com>
8774
8775 * dispnew.c (add_window_display_history): Use BVAR.
8776
8777 * xdisp.c (debug_method_add): Use BVAR.
8778 (check_window_end, dump_glyph_matrix, dump_glyph)
8779 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8780
8781 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8782 Likewise.
8783
8784 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8785 check till after the cache is created in init_frame_faces.
8786
ff2bc410
SM
87872011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8788
8789 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8790
28177add
PE
87912011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8792
dd3482fe
PE
8793 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8794 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8795 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8796
393d71f3 8797 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8798 * fileio.c (Finsert_file_contents):
8799 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8800 Remove the old (too-loose) buffer overflow checks.
8801 They weren't needed, since make_gap checks for buffer overflow.
8802 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8803 The old code merely checked for Emacs fixnum overflow, and relied
8804 on undefined (wraparound) behavior. The new code avoids undefined
8805 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8806
2e6813b0 8807 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8808 Tune. Don't use wider integers than needed. Don't use alloca.
8809 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8810
599a9e4f
PE
8811 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8812
99561444
PE
8813 * insdel.c, lisp.h (buffer_overflow): New function.
8814 (insert_from_buffer_1, replace_range, replace_range_2):
8815 * insdel.c (make_gap_larger):
8816 * editfns.c (Finsert_char):
8817 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8818
28177add
PE
8819 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8820
e69dafad
PE
88212011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8822
4baa020d 8823 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8824
b1c46f02
PE
8825 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8826 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8827
e69dafad
PE
8828 * fileio.c: Don't assume EMACS_INT fits in off_t.
8829 (emacs_lseek): New static function.
8830 (Finsert_file_contents, Fwrite_region): Use it.
8831 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8832
566684ea
PE
8833 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8834
e6966cd6
PE
8835 * fns.c: Don't overflow int when computing a list length.
8836 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8837 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8838 truncation on 64-bit hosts. Check for QUIT every
8839 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8840 faster and is responsive enough.
8841 (Flength): Report an error instead of overflowing an integer.
8842 (Fsafe_length): Return a float if the value is not representable
8843 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8844 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8845 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8846
dd0b0efb
PE
8847 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8848 (header_size, word_size): New constants.
8849 (allocate_vectorlike): Don't check size overflow here.
8850 (allocate_vector): Check it here instead, since this is the only
8851 caller of allocate_vectorlike that could cause overflow.
8852 Check that the new vector's length is representable as a fixnum.
8853
86fe5cfe
PE
8854 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8855 The previous code was bogus. For example, next_almost_prime (32)
8856 returned 39, which is undesirable as it is a multiple of 3; and
8857 next_almost_prime (24) returned 25, which is a multiple of 5 so
8858 why was the code bothering to check for multiples of 7?
8859
80e88859
PE
8860 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8861
4a2f0ad6
PE
8862 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8863
f66c7cf8
PE
8864 Variadic C functions now count arguments with ptrdiff_t.
8865 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8866 Back then I didn't know that the Emacs coding style prefers signed int.
8867 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8868 were being counted with int, which may truncate counts on 64-bit
8869 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8870 * lisp.h (struct Lisp_Subr.function.aMANY)
8871 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8872 Arg counts are now ptrdiff_t, not size_t.
8873 All variadic functions and their callers changed accordingly.
8874 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8875 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8876 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8877 * callint.c (Fcall_interactively): Check arg count for overflow,
8878 to avoid potential buffer overrun. Use signed char, not 'int',
8879 for 'varies' array, so that we needn't bother to check its size
8880 calculation for overflow.
8881 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8882 * eval.c (apply_lambda):
8883 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8884 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8885 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8886
a1759b76
PE
8887 * callint.c (Fcall_interactively): Don't use index var as event count.
8888
d96be9fc
PE
8889 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8890 * mem-limits.h (SIZE): Remove; no longer used.
8891
a690a978 8892 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8893
578c21e6
PE
8894 Remove unnecessary casts.
8895 * xterm.c (x_term_init):
8896 * xfns.c (x_set_border_pixel):
8897 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8898 These aren't needed now that we assume ANSI C.
8899
96f53c6c
PE
8900 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8901 It's more likely to cause problems (due to unsigned overflow)
8902 than to cure them.
8903
83c77d31
PE
8904 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8905
ee2079f1
PE
8906 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8907
6da65536
PE
8908 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8909
7147c4a4
PE
8910 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8911
193e32d9
PE
8912 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8913
e5533da6
PE
8914 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8915
9910e595
PE
8916 GLYPH_CODE_FACE returns EMACS_INT, not int.
8917 * dispextern.h (merge_faces):
8918 * xfaces.c (merge_faces):
01103c44
PE
8919 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8920 Don't assume EMACS_INT fits in int.
9910e595 8921
2638320e
PE
8922 * character.h (CHAR_VALID_P): Remove unused parameter.
8923 * fontset.c, lisp.h, xdisp.c: All uses changed.
8924
045eb8d9
PE
8925 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8926
c1f134b5
PE
8927 * fns.c (concat): Minor tuning based on overflow analysis.
8928 This doesn't fix any bugs. Use int to hold character, instead
8929 of constantly refetching from Emacs object. Use XFASTINT, not
8930 XINT, for value known to be a character. Don't bother comparing
8931 a single byte to 0400, as it's always less.
8932
395fcb93 8933 * floatfns.c (Fexpt):
327eeec8
PE
8934 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8935
abbd3d23
PE
8936 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8937 for characters.
8938
684a03ef
PE
8939 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8940
0fed43f3
PE
8941 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8942 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8943 incorrectly succeed when S was a string, because 4294967386 was
8944 truncated before it was used.
8945
8fd02eb7
PE
8946 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8947 Otherwise, an out-of-range integer could cause undefined behavior
8948 on a 64-bit host.
8949
f8c86b69
PE
8950 * composite.c: Use int, not EMACS_INT, for characters.
8951 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8952 EMACS_INT, for values that are known to be in character range.
8953 This doesn't fix any bugs but is the usual style inside Emacs and
8954 may generate better code on 32-bit machines.
8955
34206dd2
PE
8956 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8957 This is for reasons similar to the recent CHAR_STRING fix.
8958 * charset.c (Fencode_char): Check that character arg is actually
8959 a character. Pass an int to ENCODE_CHAR.
8960 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8961 wider than 'int', as a compile-time check to prevent future regressions
8962 in this area.
8963
c5958d4c 8964 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8965
8966 Make sure a 64-bit char is never passed to CHAR_STRING.
8967 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8968 by silently ignoring the top 32 bits, allowing some values
8969 that were far too large to be valid characters.
8970 * character.h: Include <verify.h>.
8971 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8972 arguments are no wider than unsigned, as a compile-time check
8973 to prevent future regressions in this area.
8974 * data.c (Faset):
01103c44 8975 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8976 (Fsubst_char_in_region):
8977 * fns.c (concat):
8978 * xdisp.c (decode_mode_spec_coding):
8979 Adjust to CHAR_STRING's new requirement.
8980 * editfns.c (Finsert_char, Fsubst_char_in_region):
8981 * fns.c (concat): Check that character args are actually
8982 characters. Without this test, these functions did the wrong
8983 thing with wildly out-of-range values on 64-bit hosts.
8984
d37ca623
PE
8985 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8986 These casts should not be needed on 32-bit hosts, either.
8987 * keyboard.c (read_char):
8988 * lread.c (Fload): Remove casts to unsigned.
8989
ea204efb
PE
8990 * lisp.h (UNSIGNED_CMP): New macro.
8991 This fixes comparison bugs on 64-bit hosts.
8992 (ASCII_CHAR_P): Use it.
8993 * casefiddle.c (casify_object):
01103c44 8994 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8995 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8996 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8997 * dispextern.h (FACE_FROM_ID):
8998 * keyboard.c (read_char): Use UNSIGNED_CMP.
8999
41cb286c
PE
9000 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9001 not to EMACS_INT, to avoid GCC warning.
9002
4a1b9832
PE
9003 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9004
55daad71
PE
9005 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9006 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9007 isn't needed on 32-bit machines.
8f95c75c 9008
01103c44
PE
9009 * buffer.c (Fgenerate_new_buffer_name):
9010 Use EMACS_INT for count, not int.
0ceccced 9011 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9012
9013 * data.c (Qcompiled_function): Now static.
9014
c6f072e7
PE
9015 * window.c (window_body_lines): Now static.
9016
20ce5912
PE
9017 * image.c (gif_load): Rename local to avoid shadowing.
9018
9c4c5f81
PE
9019 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9020 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9021 * alloc.c (make_save_value): Integer argument is now of type
9022 ptrdiff_t, not int.
9023 (mark_object): Use ptrdiff_t, not int.
9024 * lisp.h (pD): New macro.
9025 * print.c (print_object): Use it.
9026
c0c5c8ae
PE
9027 * alloc.c: Use EMACS_INT, not int, to count objects.
9028 (total_conses, total_markers, total_symbols, total_vector_size)
9029 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9030 (total_free_floats, total_floats, total_free_intervals)
9031 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9032 Now EMACS_INT, not int. All uses changed.
9033 (Fgarbage_collect): Compute overall total using a double, so that
9034 integer overflow is less likely to be a problem. Check for overflow
9035 when converting back to an integer.
5a25e253
PE
9036 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9037 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9038 These were 'int' variables that could overflow on 64-bit hosts;
9039 they were never used, so remove them instead of repairing them.
211a0b2a 9040 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9041 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9042 Previously, this ceilinged at INT_MAX, but that doesn't work on
9043 64-bit machines.
e46bb31a 9044 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9045
c78baabf 9046 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9047 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9048 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9049 when a (possibly-narrower) signed value would do just as well.
9050 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9051
c9d624c6
PE
9052 * alloc.c: Catch some string size overflows that we were missing.
9053 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9054 for convenience in STRING_BYTES_MAX.
9055 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9056 The definition here is exact; the one in lisp.h was approximate.
9057 (allocate_string_data): Check for string overflow. This catches
9058 some instances we weren't catching before. Also, it catches
9059 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9060 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9061 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9062
c9d624c6
PE
9063 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9064 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9065 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9066
353032ce
PE
9067 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9068
2bccce07
PE
9069 * alloc.c (Fmake_string): Check for out-of-range init.
9070
0ac30604
SM
90712011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9072
9073 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9074
c195f2de
JD
90752011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9076
9077 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9078 xg_get_default_scrollbar_width.
9079
9080 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9081 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9082 (style_changed_cb): Call update_theme_scrollbar_width and call
9083 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9084 all frames (Bug#8505).
9085 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9086 Call gtk_window_set_resizable if HAVE_GTK3.
9087 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9088 and height if HAVE_GTK3 (Bug#8505).
9089 (scroll_bar_width_for_theme): New variable.
9090 (update_theme_scrollbar_width): New function.
9091 (xg_get_default_scrollbar_width): Move code to
9092 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9093 (xg_initialize): Call update_theme_scrollbar_width.
9094
9095 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9096
9097 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9098
e10ac9f1
MR
90992011-06-12 Martin Rudalics <rudalics@gmx.at>
9100
9101 * frame.c (make_frame): Call other_buffer_safely instead of
9102 other_buffer.
9103
9104 * window.c (temp_output_buffer_show): Call display_buffer with
9105 second argument Vtemp_buffer_show_specifiers and reset latter
9106 immediately after the call.
9107 (Vtemp_buffer_show_specifiers): New variable.
9108 (auto_window_vscroll_p, next_screen_context_lines)
9109 (Vscroll_preserve_screen_position): Remove leading asterisks from
9110 doc-strings.
9111
2d3c217e 91122011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9113
7b7f97e8 9114 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9115 * buffer.c (Qclone_number): Remove for now, as it's unused.
9116 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9117 (record_buffer): Remove unused local.
9118 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9119 (set_frame_buffer_list): Remove; unused.
9120 * frame.h (other_visible_frames): Remove decl.
9121 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9122 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9123 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9124 if HAVE_GPM.
9125 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9126 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9127 Define only if HAVE_GPM.
9128 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9129 (update_hints_inhibit): Remove; never set. All uses removed.
9130 * widgetprv.h (emacsFrameClassRec): Remove decl.
9131 * window.c (delete_deletable_window): Now returns void, since it
9132 wasn't returning anything.
9133 (compare_window_configurations): Remove unused locals.
9134 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9135 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9136 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9137 the same widths as pointers. This follows up on the 2011-05-06 patch.
9138 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9139 * xterm.h: Likewise.
9140 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9141
1384b89e
JB
91422011-06-12 Juanma Barranquero <lekktu@gmail.com>
9143
9144 * makefile.w32-in: Update dependencies.
9145 (LISP_H): Add lib/intprops.h.
9146
1100a63c
CY
91472011-06-11 Chong Yidong <cyd@stupidchicken.com>
9148
9149 * image.c (gif_load): Add animation frame delay to the metadata.
9150 (syms_of_image): Use DEFSYM. New symbol `delay'.
9151
6198ccd0
MR
91522011-06-11 Martin Rudalics <rudalics@gmx.at>
9153
9154 * window.c (delete_deletable_window): Re-add.
9155 (Fset_window_configuration): Rewrite to handle dead buffers and
9156 consequently deletable windows.
9157 (window_tree, Fwindow_tree): Remove. Supply functionality in
9158 window.el.
9159 (compare_window_configurations): Simplify code.
9160
b6e3633c
AS
91612011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9162
1ab0dee5
AS
9163 * image.c (imagemagick_load_image): Fix type mismatch.
9164 (Fimagemagick_types): Likewise.
9165
b6e3633c
AS
9166 * window.h (replace_buffer_in_windows): Declare.
9167
9397e56f
MR
91682011-06-11 Martin Rudalics <rudalics@gmx.at>
9169
9170 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9171 Qclone_number. Remove external declaration of Qdelete_window.
9172 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9173 code.
640c8776
SM
9174 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9175 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9176 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9177 buffer list implementation.
9178 (other_buffer_safely): New function.
9179 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9180 calls to replace_buffer_in_windows and
9181 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9182 if allowed.
9183 (record_buffer): Inhibit quitting and rewrite using quittable
9184 functions. Run Qbuffer_list_update_hook if allowed.
9185 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9186 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9187 Move switch-to-buffer to window.el.
9397e56f
MR
9188 (bury-buffer): Move to window.el.
9189 (Vbuffer_list_update_hook): New variable.
9190
9191 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9192 section.
9193
9194 * window.h (resize_frame_windows): Move up in code.
9195 (Fwindow_frame): Remove EXFUN.
9196 (replace_buffer_in_all_windows): Remove prototype.
9197 (replace_buffer_in_windows_safely): Add prototype.
9198
9199 * window.c: Declare Qdelete_window static again. Move down
9200 declaration of select_count.
9201 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9202 (Fother_window): Move to window.el.
9203 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9204 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9205 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9206 window.el.
9207 (replace_buffer_in_windows): Implement by calling
9208 Qreplace_buffer_in_windows.
9209 (replace_buffer_in_all_windows): Remove with some functionality
9210 moved into replace_buffer_in_windows_safely.
9211 (replace_buffer_in_windows_safely): New function.
9212 (select_window_norecord, select_frame_norecord): Move in front
9213 of run_window_configuration_change_hook. Remove now obsolete
9214 declarations.
640c8776
SM
9215 (Fset_window_buffer): Rewrite doc-string.
9216 Call Qrecord_window_buffer.
9397e56f
MR
9217 (keys_of_window): Move binding for other-window to window.el.
9218
b50691aa
CY
92192011-06-11 Chong Yidong <cyd@stupidchicken.com>
9220
9221 * dispextern.h (struct image): Replace data member, whose int_val
9222 and ptr_val fields were not used by anything, with a single
9223 lisp_val object.
9224
9225 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9226 (gif_clear_image, gif_load, imagemagick_load_image)
9227 (gs_clear_image, gs_load): Callers changed.
9228
3f754b86
PE
92292011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9230
cca69397
PE
9231 * buffer.h: Include <time.h>, for time_t.
9232 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9233
109e28d0
PE
9234 Fix minor problems found by static checking.
9235
60737f02
PE
9236 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9237
4b66faf3
PE
9238 Make identifiers static if they are not used in other modules.
9239 * data.c (Qcompiled_function, Qframe, Qvector):
9240 * image.c (QimageMagick, Qsvg):
9241 * minibuf.c (Qmetadata):
9242 * window.c (resize_window_check, resize_root_window): Now static.
9243 * window.h (resize_window_check, resize_root_window): Remove decls.
9244
109e28d0
PE
9245 * window.c (window_deletion_count, delete_deletable_window):
9246 Remove; unused.
46a4ce9e
PE
9247 (window_body_lines): Now static.
9248 (Fdelete_other_windows_internal): Mark vars as initialized.
9249 Make sure 'resize_failed' is initialized.
9250 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9251 (resize_window_apply): Remove unused local.
9252 * window.h (delete_deletable_window): Remove decl.
9253
109e28d0 9254 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9255 (imagemagick_load_image): Fix pointer signedness problem by changing
9256 last arg from unsigned char * to char *. All uses changed.
9257 Also, fix a local for similar reasons.
9258 Remove unused locals. Remove locals to avoid shadowing.
9259 (fn_rsvg_handle_free): Remove; unused.
9260 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9261 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9262
3f754b86
PE
9263 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9264
2547adb1
CY
92652011-06-10 Chong Yidong <cyd@stupidchicken.com>
9266
9267 * image.c (gif_load): Fix omitted cast error introduced by
9268 2011-06-06 change.
9269
2c8e37d4
MR
92702011-06-10 Martin Rudalics <rudalics@gmx.at>
9271
9272 * window.h (resize_proportionally, orig_total_lines)
9273 (orig_top_line): Remove from window structure.
9274 (set_window_height, set_window_width, change_window_heights)
9275 (Fdelete_window): Remove prototypes.
9276 (resize_frame_windows): Remove duplicate declaration.
9277
440a42e3
EZ
92782011-06-10 Eli Zaretskii <eliz@gnu.org>
9279
9280 * window.h (resize_frame_windows, resize_window_check)
9281 (delete_deletable_window, resize_root_window)
9282 (resize_frame_windows): Declare prototypes.
9283
9284 * window.c (resize_window_apply): Make definition be "static" to
9285 match the prototype.
9286
562dd5e9
MR
92872011-06-10 Martin Rudalics <rudalics@gmx.at>
9288
9289 * window.c: Remove declarations of Qwindow_size_fixed,
9290 window_min_size_1, window_min_size_2, window_min_size,
9291 size_window, window_fixed_size_p, enlarge_window, delete_window.
9292 Remove static from declaration of Qdelete_window, it's
9293 temporarily needed by Fbury_buffer.
9294 (replace_window): Don't assign orig_top_line and
9295 orig_total_lines.
9296 (Fdelete_window, delete_window): Remove. Window deletion is
9297 handled by window.el.
640c8776
SM
9298 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9299 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9300 (Fdelete_other_windows): Remove. Deleting other windows is
9301 handled by window.el.
9302 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9303 handled in window.el.
9304 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9305 Window minimum sizes are handled in window.el.
9306 (shrink_windows, size_window, set_window_height)
9307 (set_window_width, change_window_heights, window_height)
9308 (window_width, CURBEG, CURSIZE, enlarge_window)
9309 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9310 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9311 handled in window.el.
9312 (make_dummy_parent): Rename to make_parent_window and give it a
9313 second argument horflag.
9314 (make_window): Don't set resize_proportionally any more.
9315 (Fsplit_window): Remove. Windows are split in window.el.
9316 (save_restore_action, save_restore_orig_size)
9317 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9318 Resize mini windows in window.el.
9319 (grow_mini_window, shrink_mini_window): Implement by calling
9320 Qresize_root_window_vertically, resize_window_check and
9321 resize_window_apply.
640c8776
SM
9322 (saved_window, Fset_window_configuration, save_window_save):
9323 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9324 resize_proportionally.
9325 (window_min_height, window_min_width): Move to window.el.
9326 (keys_of_window): Move bindings for delete-other-windows,
9327 split-window, delete-window and enlarge-window to window.el.
9328
9329 * buffer.c: Temporarily extern Qdelete_window.
9330 (Fbury_buffer): Temporarily call Qdelete_window instead of
9331 Fdelete_window (Fbury_buffer will move to window.el soon).
9332
9333 * frame.c (set_menu_bar_lines_1): Remove code handling
9334 orig_top_line and orig_total_lines.
9335
9336 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9337 set_window_height but set heights directly.
9338 (change_frame_size_1): Use resize_frame_windows.
9339
9340 * xdisp.c (init_xdisp): Don't use set_window_height but set
9341 heights directly.
9342
640c8776
SM
9343 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9344 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9345 run_window_configuration_change_hook.
9346
9347 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9348 instead of change_window_heights and run
9349 run_window_configuration_change_hook.
9350
1a13852e
MR
93512011-06-09 Martin Rudalics <rudalics@gmx.at>
9352
9353 * window.c (replace_window): Rename second argument REPLACEMENT to
9354 NEW. New third argument SETFLAG. Rewrite.
9355 (delete_window, make_dummy_parent): Call replace_window with
9356 third argument 1.
9357 (window_list_1): Move down in code.
9358 (run_window_configuration_change_hook): Move set_buffer part
9359 before select_frame_norecord part in order to unwind correctly.
9360 Rename count1 to count.
9361 (recombine_windows, delete_deletable_window, resize_root_window)
9362 (Fdelete_other_windows_internal)
9363 (Frun_window_configuration_change_hook, make_parent_window)
9364 (resize_window_check, resize_window_apply, Fresize_window_apply)
9365 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9366 (Fdelete_window_internal, Fresize_mini_window_internal):
9367 New functions.
1a13852e
MR
9368 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9369
f3d1777e
MR
93702011-06-08 Martin Rudalics <rudalics@gmx.at>
9371
496e208e
MR
9372 * window.h (window): Add some new members to window structure -
9373 normal_lines, normal_cols, new_total, new_normal, clone_number,
9374 splits, nest, prev_buffers, next_buffers.
9375 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9376 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9377
f3d1777e
MR
9378 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9379 Remove.
496e208e
MR
9380 (make_dummy_parent): Set new members of windows structure.
9381 (make_window): Move down in code. Handle new members of window
9382 structure.
9383 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9384 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9385 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9386 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9387 (Fset_window_next_buffers, Fset_window_clone_number):
9388 New functions.
496e208e
MR
9389 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9390 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9391 Doc-string fixes.
9392 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9393 Argument WINDOW can be now internal window too.
9394 (Fwindow_use_time): Move up in code.
9395 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9396 Rewrite doc-string.
9397 (Fset_window_configuration, saved_window)
9398 (Fcurrent_window_configuration, save_window_save): Handle new
9399 members of window structure.
b9e809c2
MR
9400 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9401 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9402 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9403 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9404 Qget_mru_window, Qresize_root_window,
9405 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9406 Qauto_buffer_name; staticpro them.
f3d1777e 9407
abde8f8c
MR
94082011-06-07 Martin Rudalics <rudalics@gmx.at>
9409
9410 * window.c (Fwindow_total_size, Fwindow_left_column)
9411 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9412 (Fwindow_list_1): New functions.
9413 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9414 (Fwindow_width, Fscroll_left, Fscroll_right):
9415 Use window_body_cols instead of window_box_text_cols.
9416 (delete_window, Fset_window_configuration):
9417 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9418 (delete_all_subwindows): Take a window as argument and not a
9419 structure. Rewrite.
190b47e6
MR
9420 (window_loop): Remove handling of GET_LRU_WINDOW and
9421 GET_LARGEST_WINDOW.
9422 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9423
9424 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9425 window_box_text_cols. delete_all_subwindows now takes a
9426 Lisp_Object as argument.
abde8f8c 9427
640c8776
SM
9428 * indent.c (compute_motion, Fcompute_motion):
9429 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9430
fa8a67e6
MR
9431 * frame.c (delete_frame): Call delete_all_subwindows with root
9432 window as argument.
9433
a54e3482
DC
94342011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9435
9436 * fns.c (Fputhash): Document return value.
9437
60002bf5
CY
94382011-06-06 Chong Yidong <cyd@stupidchicken.com>
9439
9440 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9441
0c671da6 94422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9443
b862a52a 9444 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9445
be44ca6c
PE
9446 Check for overflow when converting integer to cons and back.
9447 * charset.c (Fdefine_charset_internal, Fdecode_char):
9448 Use cons_to_unsigned to catch overflow.
9449 (Fencode_char): Use INTEGER_TO_CONS.
9450 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9451 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9452 * data.c (long_to_cons, cons_to_long): Remove.
9453 (cons_to_unsigned, cons_to_signed): New functions.
9454 These signal an error for invalid or out-of-range values.
9455 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9456 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9457 * font.c (Ffont_variation_glyphs):
9458 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9459 * lisp.h: Include <intprops.h>.
9460 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9461 (cons_to_signed, cons_to_unsigned): New decls.
9462 (long_to_cons, cons_to_long): Remove decls.
9463 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9464 (Fprimitive_undo): Use CONS_TO_INTEGER.
9465 * xfns.c (Fx_window_property): Likewise.
9466 * xselect.c: Include <limits.h>.
9467 (x_own_selection, selection_data_to_lisp_data):
9468 Use INTEGER_TO_CONS.
9469 (x_handle_selection_request, x_handle_selection_clear)
9470 (x_get_foreign_selection, Fx_disown_selection_internal)
9471 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9472 (lisp_data_to_selection_data): Use cons_to_unsigned.
9473 (x_fill_property_data): Use cons_to_signed.
9474 Report values out of range.
9475
d1f3d2af
PE
9476 Check for buffer and string overflow more precisely.
9477 * buffer.h (BUF_BYTES_MAX): New macro.
9478 * lisp.h (STRING_BYTES_MAX): New macro.
9479 * alloc.c (Fmake_string):
9480 * character.c (string_escape_byte8):
9481 * coding.c (coding_alloc_by_realloc):
9482 * doprnt.c (doprnt):
9483 * editfns.c (Fformat):
9484 * eval.c (verror):
9485 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9486 since they may not be the same number.
9487 * editfns.c (Finsert_char):
9488 * fileio.c (Finsert_file_contents):
9489 Likewise for BUF_BYTES_MAX.
9490
dd52fcea
PE
9491 * image.c: Use ptrdiff_t, not int, for sizes.
9492 (slurp_file): Switch from int to ptrdiff_t.
9493 All uses changed.
9494 (slurp_file): Check that file size fits in both size_t (for
9495 malloc) and ptrdiff_t (for sanity and safety).
9496
7f9bbdbb
PE
9497 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9498 if b->modtime has its maximal value.
9499
dfe18f82
PE
9500 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9501
84acfcf0
PE
9502 Don't assume time_t can fit into int.
9503 * buffer.h (struct buffer.modtime): Now time_t, not int.
9504 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9505 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9506
ccd9a01a
PE
9507 Minor fixes for signed vs unsigned integers.
9508 * character.h (MAYBE_UNIFY_CHAR):
9509 * charset.c (maybe_unify_char):
9510 * keyboard.c (read_char, reorder_modifiers):
9511 XINT -> XFASTINT, since the integer must be nonnegative.
9512 * ftfont.c (ftfont_spec_pattern):
9513 * keymap.c (access_keymap, silly_event_symbol_error):
9514 XUINT -> XFASTINT, since the integer must be nonnegative.
9515 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9516 since it makes no difference and we prefer signed.
9517 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9518 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9519 nonnegative.
9520
d6d100dd
SM
95212011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9522
9523 * window.h (Fwindow_frame): Declare.
9524
2b6148e4
PE
95252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9526
9527 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9528 (SPARE_MEMORY): Always define.
9529 (LARGE_REQUEST): Remove.
9530 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9531
f230ecc9
MR
95322011-06-06 Martin Rudalics <rudalics@gmx.at>
9533
727e958e
MR
9534 * lisp.h: Move EXFUNS for Fframe_root_window,
9535 Fframe_first_window and Fset_frame_selected_window to window.h.
9536
9537 * window.h: Move EXFUNS for Fframe_root_window,
9538 Fframe_first_window and Fset_frame_selected_window here from
9539 lisp.h.
9540
9541 * frame.c (Fwindow_frame, Fframe_first_window)
9542 (Fframe_root_window, Fframe_selected_window)
9543 (Fset_frame_selected_window): Move to window.c.
9544 (Factive_minibuffer_window): Move to minibuf.c.
9545 (Fother_visible_frames_p): New function.
9546
9547 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9548
f230ecc9
MR
9549 * window.c (decode_window, decode_any_window): Move up in code.
9550 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9551 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9552 (Fwindow_buffer): Move up and rewrite doc-string.
9553 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9554 (Fwindow_prev): New functions.
727e958e
MR
9555 (Fwindow_frame): Move here from frame.c. Accept any window as
9556 argument.
9557 (Fframe_root_window, Fframe_first_window)
9558 (Fframe_selected_window): Move here from frame.c. Accept frame
9559 or arbitrary window as argument. Update doc-strings.
9560 (Fminibuffer_window): Move up in code.
9561 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9562 (Fset_frame_selected_window): Move here from frame.c.
9563 Marginal rewrite.
727e958e
MR
9564 (Fselected_window, select_window, Fselect_window): Move up in
9565 code. Minor doc-string fixes.
f230ecc9 9566
4d09bcf6
PE
95672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9568
9569 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9570 Do not assume that spare memory exists; that assumption is valid
9571 only if SYSTEM_MALLOC.
9572 (LARGE_REQUEST): New macro, so that the issue of large requests
9573 is separated from the issue of spare memory.
9574
810928a2
AS
95752011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9576
172418ad
AS
9577 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9578 format. (Bug#8806)
9579
43f862f7
AS
9580 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9581
810928a2
AS
9582 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9583 before statements.
9584
a059fe24
JD
95852011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9586
9587 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9588
9589 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9590
9591 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9592 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9593
989bf368
JB
95942011-06-05 Juanma Barranquero <lekktu@gmail.com>
9595
9596 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9597
4b80f674
CY
95982011-06-04 Chong Yidong <cyd@stupidchicken.com>
9599
9600 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9601 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9602 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9603 New error handlers.
4b80f674
CY
9604 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9605 Obey Vx_select_enable_clipboard_manager. Catch errors in
9606 x_clipboard_manager_save (Bug#8779).
9607 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9608 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9609
99a33b77 96102011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9611
9612 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9613
99a33b77 96142011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9615
9616 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9617 in the current matrix if keep_current_p is non-zero.
9618
8264569d
EZ
96192011-06-04 Eli Zaretskii <eliz@gnu.org>
9620
9621 * bidi.c (bidi_level_of_next_char): Fix last change.
9622
57f97249
EZ
96232011-06-03 Eli Zaretskii <eliz@gnu.org>
9624
fec2107c 9625 Support bidi reordering of text covered by display properties.
57f97249 9626
fec2107c
EZ
9627 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9628 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9629 (bidi_cache_search, bidi_cache_iterator_state)
9630 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9631 (bidi_level_of_next_char, bidi_move_to_visually_next):
9632 Support character positions inside a run of characters covered by a
fec2107c
EZ
9633 display string.
9634 (bidi_paragraph_init, bidi_resolve_explicit_1)
9635 (bidi_level_of_next_char): Call bidi_fetch_char and
9636 bidi_fetch_char_advance instead of FETCH_CHAR and
9637 FETCH_CHAR_ADVANCE.
9638 (bidi_init_it): Initialize new members.
9639 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9640 definitions.
9641 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9642 instead of using explicit *_CHAR codes.
d6d100dd
SM
9643 (bidi_resolve_explicit, bidi_resolve_weak):
9644 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9645 bidirectional text is supported only in multibyte buffers.
9646 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9647 it to initialize the frame_window_p member of struct bidi_it.
9648 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9649 (bidi_resolve_explicit, bidi_resolve_weak)
9650 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9651 bidi_it->nchars is non-positive.
9652 (bidi_level_of_next_char): Don't try to lookup the cache for the
9653 next/previous character if nothing is cached there yet, or if we
9654 were just reseat()'ed to a new position.
c40e2fb2 9655
0e14fe90
EZ
9656 * xdisp.c (set_cursor_from_row): Set start and stop points
9657 according to the row's direction when priming the loop that looks
9658 for the glyph on which to display cursor.
9659 (single_display_spec_intangible_p): Function deleted.
9660 (display_prop_intangible_p): Reimplement to call
9661 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9662 Accept 3 additional arguments needed by handle_display_spec.
9663 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9664 values: lists, `(when COND...)' forms, etc.
9665 (single_display_spec_string_p): Support property values that are
9666 lists with the argument STRING its top-level element.
9667 (display_prop_string_p): Fix the condition for processing a
9668 property that is a list to be consistent with handle_display_spec.
fec2107c 9669 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9670 last portion of handle_display_prop.
9671 (compute_display_string_pos): Accept additional argument
9672 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9673 value of a `display' property is a "replacing spec".
9674 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9675 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9676 the display property, but just return a value indicating whether
9677 the display property will replace the characters it covers.
9678 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9679 frame_window_p members of struct bidi_it.
d6d100dd
SM
9680 (compute_display_string_pos, compute_display_string_end):
9681 New functions.
fec2107c
EZ
9682 (push_it): Accept second argument POSITION, where pop_it should
9683 jump to continue iteration.
9684 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9685
fec2107c
EZ
9686 * keyboard.c (adjust_point_for_property): Adjust the call to
9687 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9688
9689 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9690 (bidi_init_it): Update prototypes.
9691 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9692 (compute_display_string_pos, compute_display_string_end):
9693 Declare prototypes.
fec2107c
EZ
9694 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9695 EMACS_INT.
fc6f18ce 9696
40087514 96972011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9698
57f53182
PE
9699 Malloc failure behavior now depends on size of allocation.
9700 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9701 * lisp.h: Change signatures accordingly.
9702 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9703 All callers changed. (Bug#8762)
9704
9705 * gnutls.c: Use Emacs's memory allocators.
9706 Without this change, the gnutls library would invoke malloc etc.
9707 directly, which causes problems on non-SYNC_INPUT hosts, and which
9708 runs afoul of improving memory_full behavior. (Bug#8761)
9709 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9710 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9711 xfree instead of the default malloc, realloc, free.
9712 (Fgnutls_boot): No need to check for memory allocation failure,
9713 since xmalloc does that for us.
9714
ac32cd99 9715 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9716 * category.c (hash_get_category_set):
9717 * ccl.c (ccl_driver):
9718 * charset.c (Fdefine_charset_internal):
9719 * charset.h (struct charset.hash_index):
9720 * composite.c (get_composition_id, gstring_lookup_cache)
9721 (composition_gstring_put_cache):
9722 * composite.h (struct composition.hash_index):
9723 * dispextern.h (struct image.hash):
9724 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9725 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9726 (hashfn_equal, hashfn_user_defined, make_hash_table)
9727 (maybe_resize_hash_table, hash_lookup, hash_put)
9728 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9729 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9730 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9731 * image.c (make_image, search_image_cache, lookup_image)
9732 (xpm_put_color_table_h):
9733 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9734 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9735 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9736 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9737 * alloc.c (allocate_vectorlike):
9738 Check for overflow in vector size calculations.
9739 * ccl.c (ccl_driver):
9740 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9741 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9742 need to be updated by these changes.
40087514
PE
9743 * fns.c (make_hash_table, maybe_resize_hash_table):
9744 Check for integer overflow with large hash tables.
0de4bb68
PE
9745 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9746 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9747 (SXHASH_REDUCE): New macro.
9748 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9749 Use it instead of discarding useful hash info with large hash values.
9750 (sxhash_float): New function.
9751 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9752 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9753 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9754 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9755 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9756 Adjust signatures to match updated version of code.
9757 (consing_since_gc): Now EMACS_INT, since a single hash table can
9758 use more than INT_MAX bytes.
9759
698d32e2
DN
97602011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9761
9762 Make it possible to build with GCC-4.6+ -O2 -flto.
9763
9764 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9765
fd6fa53f
SM
97662011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9767
9768 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9769 Call minibuffer-inactive-mode.
9770
864db017
JB
97712011-05-31 Juanma Barranquero <lekktu@gmail.com>
9772
9773 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9774 Update dependencies.
9775
2ad0baf4
DN
97762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9777
9778 * data.c (init_data): Remove code for UTS, this system is not
9779 supported anymore.
9780
4fcc2638
DN
97812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9782
9783 Don't force ./temacs to start in terminal mode.
9784
9785 * frame.c (make_initial_frame): Initialize faces in all cases, not
9786 only when CANNOT_DUMP is defined.
9787 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9788
c56e0fd5
DN
97892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9790
9791 * dispnew.c (add_window_display_history): Use const for the string
9792 pointer. Remove declaration, not needed.
9793
333d54da 97942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9795
55d4c1b2 9796 Use 'inline', not 'INLINE'.
333d54da 9797 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9798 * alloc.c, fontset.c (INLINE): Remove.
9799 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9800 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9801 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9802 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9803 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9804
738db178
DN
98052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9806
9807 Make it possible to run ./temacs.
9808
9809 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9810 syms_of_callproc does the same thing. Remove test for
9811 "initialized", do it in the caller.
9812 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9813
620c53a6
SM
98142011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9815
9816 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9817 (read_minibuf): Use get_minibuffer.
9818 (syms_of_minibuf): Use DEFSYM.
9819 (Qmetadata): New var.
9820 * data.c (Qbuffer): Don't make it static.
9821 (syms_of_data): Use DEFSYM.
9822
e003a292
PE
98232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9824
9825 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9826 (CCL_CODE_MIN): New macro.
9827
ed008a6d
PE
98282011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9829
3687c2ef
PE
9830 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9831
ed008a6d
PE
9832 * eval.c (Qdebug): Now static.
9833 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9834 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9835 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9836
d66c4c7c
CY
98372011-05-29 Chong Yidong <cyd@stupidchicken.com>
9838
9839 * image.c: Various fixes to ImageMagick code comments.
9840 (Fimagemagick_types): Doc fix.
9841
5fbc2025
PE
98422011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9843
0196f88a
PE
9844 Minor fixes prompted by GCC 4.6.0 warnings.
9845
9846 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9847
5fbc2025
PE
9848 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9849 (x_clipboard_manager_save_all): Move extern decl to ...
9850 * xterm.h: ... here, so that it can be checked for consistency.
9851
1dd3c2d9
CY
98522011-05-29 Chong Yidong <cyd@stupidchicken.com>
9853
9854 * xselect.c (x_clipboard_manager_save_frame)
9855 (x_clipboard_manager_save_all): New functions.
9856 (Fx_clipboard_manager_save): Lisp function deleted.
9857
9858 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9859 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9860
9861 * xterm.h: Update prototype.
9862
5ba6571d
WX
98632011-05-28 William Xu <william.xwl@gmail.com>
9864
9865 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9866 exiting (Bug#8239).
9867
3eaff834
JM
98682011-05-28 Jim Meyering <meyering@redhat.com>
9869
e1900994 9870 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9871 * fns.c (to_uchar): Define.
9872 (crypto_hash_function): Use it to convert some newly-signed
9873 variables to unsigned, to avoid sign-extension bugs. For example,
9874 without this change, (md5 "truc") would evaluate to
9875 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9876 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9877 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9878
0f6990a7
PE
98792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9880
9881 Integer overflow fixes.
c8a9ca5a 9882
08686060
PE
9883 * dbusbind.c: Serial number integer overflow fixes.
9884 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9885 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9886 to hold a serial number that is too large for a fixnum.
9887 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9888 Check for serial numbers out of range. Decode any serial number
59568bf0 9889 that was so large that it became a float. (Bug#8722)
08686060 9890
2d1fc3c7
PE
9891 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9892 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9893 Use XFASTINT rather than XUINT when numbers are nonnegative.
9894 (xd_append_arg, Fdbus_method_return_internal):
9895 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9896 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9897 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9898 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9899 (Bug#8722)
2d1fc3c7 9900
c8a9ca5a
PE
9901 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9902
519e1d69
PE
9903 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9904
6df6ae42 9905 ccl: Add integer overflow checks.
30569699
PE
9906 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9907 (IN_INT_RANGE): New macros.
9908 (ccl_driver): Use them to check for integer overflow when
9909 decoding a CCL program. Many of the new checks are whether XINT (x)
9910 fits in int; it doesn't always, on 64-bit hosts. The new version
9911 doesn't catch all possible integer overflows, but it's an
847044ea 9912 improvement. (Bug#8719)
30569699 9913
c11285dc
PE
9914 * alloc.c (make_event_array): Use XINT, not XUINT.
9915 There's no need for unsigned here.
9916
fdccd48e
PE
9917 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9918 This follows up to the 2011-05-06 change that substituted uintptr_t
9919 for EMACS_INT. This case wasn't caught back then.
9920
37910ab2
PE
9921 Rework Fformat to avoid integer overflow issues.
9922 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9923 now (part of C89). Include <verify.h>.
9924 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9925 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9926 (Fformat): Avoid the prepass trying to compute sizes; it was only
9927 approximate and thus did not catch overflow reliably. Instead, walk
9928 through the format just once, formatting and computing sizes as we go,
9929 checking for integer overflow at every step, and allocating a larger
9930 buffer as needed. Keep track separately whether the format is
9931 multibyte. Keep only the most-recently calculated precision, rather
9932 than them all. Record whether each argument has been converted to
9933 string. Use EMACS_INT, not int, for byte and char and arg counts.
9934 Support field widths and precisions larger than INT_MAX. Avoid
9935 sprintf's undefined behavior with conversion specifications such as %#d
9936 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9937 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9938 formatting out-of-range floating point numbers with int
9173deec 9939 formats. (Bug#8668)
37910ab2 9940
2e6578fb
PE
9941 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9942
0ae6bdee
PE
9943 * data.c: Avoid integer truncation in expressions involving floats.
9944 * data.c: Include <intprops.h>.
9945 (arith_driver): When there's an integer overflow in an expression
9946 involving floating point, convert the integers to floating point
9947 so that the resulting value does not suffer from catastrophic
9948 integer truncation. For example, on a 64-bit host (* 4
9949 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9950 Do not rely on undefined behavior after integer overflow.
9951
de883a70
PE
9952 merge count_size_as_multibyte, parse_str_to_multibyte
9953 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9954 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9955 Check for integer overflow.
9956 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9957 since it's now a duplicate of the other. This is more of
9958 a character than a buffer op, so better that it's in character.c.
9959 * fns.c, print.c: Adjust to above changes.
9960
2ff916cb
PE
99612011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9962
9963 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9964
f1b54466
PE
99652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9966
fb1ac845
PE
9967 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9968 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9969 (x_clipboard_manager_save): Now static.
9970 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9971
f1b54466
PE
9972 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9973 (crypto_hash_function): Now static.
9974 Fix pointer signedness problems. Avoid unnecessary initializations.
9975
a9f737ee
CY
99762011-05-27 Chong Yidong <cyd@stupidchicken.com>
9977
9978 * termhooks.h (Vselection_alist): Make it terminal-local.
9979
9980 * terminal.c (create_terminal): Initialize it.
9981
9982 * xselect.c: Support for clipboard managers.
9983 (Vselection_alist): Move to termhooks.h as terminal-local var.
9984 (LOCAL_SELECTION): New macro.
9985 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9986 (symbol_to_x_atom): Remove gratuitous arg.
9987 (x_handle_selection_request, lisp_data_to_selection_data)
9988 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9989 (x_own_selection, x_get_local_selection, x_convert_selection):
9990 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9991 (some_frame_on_display): Delete unused function.
9992 (Fx_own_selection_internal, Fx_get_selection_internal)
9993 (Fx_disown_selection_internal, Fx_selection_owner_p)
9994 (Fx_selection_exists_p): New optional frame arg.
9995 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9996 (x_handle_selection_clear): Don't treat other terminals with the
9997 same keyboard specially. Use the terminal-local Vselection_alist.
9998 (x_clear_frame_selections): Use Frun_hook_with_args.
9999
10000 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10001
10002 * xterm.h: Add support for those atoms.
10003
e067f0c1
CY
100042011-05-26 Chong Yidong <cyd@stupidchicken.com>
10005
10006 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10007 (converted_selections, conversion_fail_tag): New global variables.
10008 (x_selection_request_lisp_error): Free the above.
10009 (x_get_local_selection): Remove unnecessary code.
10010 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10011 of converted selections stored in converted_selections.
10012 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10013 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10014 (x_convert_selection): New function.
10015 (x_handle_selection_event): Simplify.
10016 (x_get_foreign_selection): Don't ignore incoming requests while
10017 waiting for an answer; this will fail when we implement
10018 SAVE_TARGETS, and seems unnecessary anyway.
10019 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10020 (Vx_sent_selection_functions): Doc fix.
10021
0f4aebc0
LL
100222011-05-26 Leo Liu <sdl.web@gmail.com>
10023
10024 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10025
e61124cd
YM
100262011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10027
10028 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10029
10030 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10031 for fringe update if it has periodic bitmap.
ac389d0c 10032 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10033 and fringe_bitmap_periodic_p.
10034
10035 * fringe.c (get_fringe_bitmap_data): New function.
10036 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10037 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10038 row. Mark glyph row for fringe update if periodicity changed.
10039
10040 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10041 for fringe update unless it has periodic bitmap.
10042
f16d9837
KH
100432011-05-25 Kenichi Handa <handa@m17n.org>
10044
10045 * xdisp.c (get_next_display_element): Set correct it->face_id for
10046 a static composition.
10047
e1b90ef6
LL
100482011-05-24 Leo Liu <sdl.web@gmail.com>
10049
10050 * deps.mk (fns.o):
10051 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10052
10053 * fns.c (crypto_hash_function, Fsha1): New function.
10054 (Fmd5): Use crypto_hash_function.
10055 (syms_of_fns): Add Ssha1.
10056
7400048f
PE
100572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10058
10059 * gnutls.c: Remove unused macros.
10060 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10061 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10062 Remove macros that are defined and never used.
10063 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10064
abb71cf4
CY
100652011-05-22 Chong Yidong <cyd@stupidchicken.com>
10066
10067 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10068 (Fx_get_selection_internal): Minor cleanup.
10069 (Fx_own_selection_internal): Rename arguments for consistency with
10070 select.el.
10071
6307db39
PE
100722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10073
10074 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10075
f3d4e0a4
CY
100762011-05-22 Chong Yidong <cyd@stupidchicken.com>
10077
10078 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10079
4d8ade89
YM
100802011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10081
10082 * dispnew.c (scrolling_window): Don't exclude the case that the
10083 last enabled row in the desired matrix touches the bottom boundary.
10084
32078c8d
GM
100852011-05-21 Glenn Morris <rgm@gnu.org>
10086
10087 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10088 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10089 and add some more files.
32078c8d 10090
7285dc67
EZ
100912011-05-20 Eli Zaretskii <eliz@gnu.org>
10092
10093 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10094 report_file_error introduced by the change from 2011-05-07.
10095
89d1bd22
PE
100962011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10097
10098 * systime.h (Time): Define only if emacs is defined.
10099 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10100 where the include path doesn't have X11/X.h by default. See
10101 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10102
cd394be1 101032011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10104
10105 * composite.c (find_automatic_composition): Fix previous change.
10106
b9704ad9
GM
101072011-05-20 Glenn Morris <rgm@gnu.org>
10108
10109 * lisp.mk: New file, split from Makefile.in.
10110 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10111 (shortlisp): Remove.
10112 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10113
4a720484
GM
101142011-05-19 Glenn Morris <rgm@gnu.org>
10115
10116 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10117 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10118 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10119 (lisp): Set the order to that of loadup.el.
10120 (shortlisp): Make it a copy of $lisp.
10121 (SOME_MACHINE_LISP): Remove.
10122 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10123 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10124
a28d4396
KH
101252011-05-18 Kenichi Handa <handa@m17n.org>
10126
10127 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10128 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10129 (find_automatic_composition): Mostly rewrite for efficiency.
10130
a2b1fa8e
JB
101312011-05-18 Juanma Barranquero <lekktu@gmail.com>
10132
10133 * makefile.w32-in: Update dependencies.
10134
8e1f5610
CS
101352011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10136
10137 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10138 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10139
7025ee00 101402011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10141
cdfa6eab
PE
10142 Fix some integer overflow issues, such as string length overflow.
10143
06d6db33
PE
10144 * insdel.c (count_size_as_multibyte): Check for string overflow.
10145
2b4560a8
PE
10146 * character.c (lisp_string_width): Check for string overflow.
10147 Use EMACS_INT, not int, for string indexes and lengths; in
10148 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10149 the resulting string length overflows an EMACS_INT; instead,
10150 report a string overflow if no precision given. When checking for
10151 precision exhaustion, use a check that cannot possibly have
10152 integer overflow. (Bug#8675)
10153 * character.h (lisp_string_width): Adjust to new signature.
10154
cb93f9be
PE
10155 * alloc.c (string_overflow): New function.
10156 (Fmake_string): Use it. This doesn't change behavior, but saves
10157 a few bytes and will simplify future changes.
10158 * character.c (string_escape_byte8): Likewise.
10159 * lisp.h (string_overflow): New decl.
10160
1a1f3366
PE
10161 Fixups, following up to the user-interface timestamp change.
10162 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10163 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10164 * msdos.c (mouse_get_pos): Likewise.
10165 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10166 * w32gui.h (Time): Define by including "systime.h" rather than by
10167 declaring it ourselves. (Bug#8664)
10168
d4e3e4d3
PE
10169 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10170 * image.c (clear_image_cache): Likewise.
10171
f6a24d19
PE
10172 * term.c (term_mouse_position): Don't assume time_t wraparound.
10173
08dc5ae6
PE
10174 Be more systematic about user-interface timestamps.
10175 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10176 and sometimes 'EMACS_UINT', to represent these timestamps.
10177 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10178 This makes the code easier to follow, and makes it easier to catch
10179 integer overflow bugs such as Bug#8664.
10180 * frame.c (Fmouse_position, Fmouse_pixel_position):
10181 Use Time, not unsigned long, for user-interface timestamps.
10182 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10183 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10184 * keyboard.h (last_event_timestamp): Likewise.
10185 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10186 * menu.h (xmenu_show): Likewise.
10187 * term.c (term_mouse_position): Likewise.
10188 * termhooks.h (struct input_event.timestamp): Likewise.
10189 (struct terminal.mouse_position_hook): Likewise.
10190 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10191 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10192 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10193 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10194 what it was before.
10195 * menu.h, termhooks.h: Include "systime.h", for Time.
10196
8e55734a
PE
10197 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10198 Don't assume that the difference between two unsigned long values
10199 can fit into an integer. At this point, we know button_down_time
10200 <= event->timestamp, so the difference must be nonnegative, so
10201 there's no need to cast the result if double-click-time is
10202 nonnegative, as it should be; check that it's nonnegative, just in
10203 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10204 apart (about 25 days). (Bug#8664)
8e55734a 10205
841f1b75 10206 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10207 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10208
3e26f69c
PE
10209 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10210 that always fit in int. Use a sentinel instead of a counter, to
10211 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10212 * frame.h (struct frame): Use int for menu_bar_items_used
10213 instead of EMACS_INT, since it always fits in int.
3e26f69c 10214
5cc152c0
PE
10215 * menu.c (grow_menu_items): Check for int overflow.
10216
d89eb65e
PE
10217 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10218
5235bd3e
PE
10219 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10220 Before, the code was not consistent. These values cannot exceed
10221 2**31 - 1 so there's no need to make them unsigned.
10222 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10223 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10224 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10225 as modifiers.
10226 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10227
bc827e23
PE
10228 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10229 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10230 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10231 presumably because the widths might not match.
10232
78eb494e
PE
10233 * window.c (size_window): Avoid needless test at loop start.
10234
04f2d78b
CB
102352011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10236
10237 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10238
d2fc7e3d 102392011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10240
10241 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10242
d2fc7e3d 102432011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10244
10245 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10246 `width' to `bar_area_x' and `bar_area_width', respectively.
10247 (x_scroll_run): Take account of fringe background extension.
10248
04f2d78b
CB
10249 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10250 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10251 `bar_area_width', respectively.
10252 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10253 background extension.
10254
79b70037
GM
102552011-05-10 Jim Meyering <meyering@redhat.com>
10256
10257 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10258
2f142cc5
JB
102592011-05-10 Juanma Barranquero <lekktu@gmail.com>
10260
10261 * image.c (Finit_image_library): Return t for built-in image types,
10262 like pbm and xbm. (Bug#8640)
10263
57679c86
AS
102642011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10265
10266 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10267
888c9e86
EZ
102682011-05-07 Eli Zaretskii <eliz@gnu.org>
10269
b0512a1d
EZ
10270 * w32console.c (Fset_screen_color): Doc fix.
10271 (Fget_screen_color): New function.
10272 (syms_of_ntterm): Defsubr it.
10273
7285dc67
EZ
10274 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10275 unlink the temporary file if Fcall_process didn't create it in the
10276 first place.
10277 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10278 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10279 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10280 cue to call_process_cleanup not to close that handle.
10281
4d3fcc8e
BK
102822011-05-07 Ben Key <bkey76@gmail.com>
10283
10284 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10285 one of two shell specific rules, either bootstrap-temacs-CMD or
10286 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10287 to the previous implementation of the bootstrap-temacs rule.
10288 The bootstrap-temacs-CMD rule is similar to the previous
10289 implementation of the bootstrap-temacs rule except that it
10290 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10291 variable.
10292
10293 These changes, along with some changes to nt/configure.bat,
10294 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10295 earlier fix to add support for --cflags and --ldflags options
10296 that include quotes so that it works whether make uses cmd or
10297 sh as the shell.
10298
b4289b64
MA
102992011-05-06 Michael Albinus <michael.albinus@gmx.de>
10300
10301 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10302 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10303 is a constant.
10304 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10305 a string. Handle both cases.
10306 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10307 (Fdbus_register_method): Use Qinvalid_function.
10308
af4c0e28
JB
103092011-05-06 Juanma Barranquero <lekktu@gmail.com>
10310
10311 * makefile.w32-in: Update dependencies.
10312 (LISP_H): Add inttypes.h and stdin.h.
10313 (PROCESS_H): Add unistd.h.
10314
c51453d9
EZ
103152011-05-06 Eli Zaretskii <eliz@gnu.org>
10316
10317 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10318 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10319
8ff0ac3c 103202011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10321
4c4b566b
PE
10322 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10323
aab2b9b5
PE
10324 * term.c (vfatal): Remove stray call to va_end.
10325 It's not needed and the C Standard doesn't allow it here anyway.
10326
c378da0b
PE
10327 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10328 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10329
288b08c7
PE
10330 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10331 bytes.
10332
e3601888
PE
10333 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10334
db6c0e74
PE
10335 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10336
dd5963ea
PE
10337 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10338
88c9450f
PE
10339 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10340
2f9442b8
PE
10341 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10342
c032b5f8
PE
10343 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10344 * charset.c (Fdefine_charset_internal): Don't initialize
10345 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10346 32-bit int (Bug#8600).
a108c10b
PE
10347
10348 * lread.c (read_integer): Be more consistent with string-to-number.
10349 Use string_to_number to do the actual conversion; this avoids
10350 rounding errors and fixes some other screwups. Without this fix,
10351 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10352 (digit_to_number): Move earlier, for benefit of read_integer.
10353 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10354 not a digit in any supported base. (Bug#8602)
a108c10b 10355
ad5f9eea
PE
10356 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10357
aec1708a
PE
10358 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10359 to match comment at start of function. This also removes a
10360 GCC warning about overflow in a 32+64-bit port.
10361
47be4ab5
PE
10362 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10363
371cac43
PE
10364 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10365 Reported by Stefan Monnier in
10366 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10367 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10368 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10369
d01a7826
PE
10370 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10371 (EMACS_UINTPTR): Likewise, with uintptr_t.
10372
7fd47d5c
PE
10373 * lisp.h: Prefer 64-bit EMACS_INT if available.
10374 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10375 on 32-bit hosts that have 64-bit int, so that they can access
10376 large files.
122b0c86
PE
10377 However, temporarily disable this change unless the temporary
10378 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10379
8727937b
PE
10380 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10381
8ac068ac
PE
10382 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10383 This removes an assumption that EMACS_INT and long are the same
10384 width as pointers. The assumption is true for Emacs porting targets
10385 now, but we want to make other targets possible.
10386 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10387 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10388 In the rest of the code, change types of integers that hold casted
10389 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10390 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10391 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10392 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10393 No need to cast type when ORing.
10394 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10395 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10396 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10397 assume EMACS_INT is the same width as char *.
10398 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10399 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10400 Remove no-longer-needed casts.
10401 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10402 (xg_tool_bar_help_callback, xg_make_tool_item):
10403 Use EMACS_INTPTR to hold an integer
10404 that will be cast to void *; this can avoid a GCC warning
10405 if EMACS_INT is not the same width as void *.
10406 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10407 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10408 (current_message_1, set_message_1):
10409 Use a local to convert to proper width without a cast.
10410 * xmenu.c (dialog_selection_callback): Likewise.
10411
ede49d71
PE
10412 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10413 Also, don't assume VALBITS / RAND_BITS is less than 5,
10414 and don't rely on undefined behavior when shifting a 1 left into
10415 the sign bit.
10416 * lisp.h (get_random): Change signature to match.
10417
2f30ecd0
PE
10418 * lread.c (hash_string): Use size_t, not int, for hash computation.
10419 Normally we prefer signed values; but hashing is special, because
10420 it's better to use unsigned division on hash table sizes so that
10421 the remainder is nonnegative. Also, size_t is the natural width
10422 for hashing into memory. The previous code used 'int', which doesn't
10423 retain enough info to hash well into very large tables.
10424 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10425
2a866e7b
PE
10426 * dbusbind.c: Don't possibly lose pointer info when converting.
10427 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10428 Use XPNTR rather than XHASH, so that the high-order bits of
10429 the pointer aren't lost when converting through void *.
10430
51639eac
PE
10431 * eval.c (Fautoload): Don't double-shift a pointer.
10432
92394119
PE
10433 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10434
dbdb9a7c
JB
104352011-05-06 Juanma Barranquero <lekktu@gmail.com>
10436
10437 * gnutls.c (DEF_GNUTLS_FN):
10438 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10439
db7a0b4f
AS
104402011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10441
10442 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10443 marker. (Bug#8610)
10444
cd394be1 104452011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10446
10447 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10448 New version that can reserve upto 2GB of heap space.
10449
f7ff1b0f 104502011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10451
10452 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10453
639c109b
TZ
104542011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10455
10456 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10457 `gnutls_certificate_set_x509_key_file'.
10458
d2127135
JB
104592011-05-05 Juanma Barranquero <lekktu@gmail.com>
10460
10461 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10462 Update dependencies.
10463
e968f4f3
JB
104642011-05-04 Juanma Barranquero <lekktu@gmail.com>
10465
10466 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10467 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10468 Remove unused parameter `fildes'.
10469 * process.c (read_process_output, send_process): Don't pass it.
10470
84d358f0
JB
104712011-05-04 Juanma Barranquero <lekktu@gmail.com>
10472
10473 Fix previous change: the library cache is defined in w32.c.
10474 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10475 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10476
0898ca10
JB
104772011-05-04 Juanma Barranquero <lekktu@gmail.com>
10478
10479 Implement dynamic loading of GnuTLS on Windows.
10480
10481 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10482 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10483 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10484 Declare.
10485
10486 * gnutls.c (Qgnutls_dll): Define.
10487 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10488 (gnutls_*): Declare function pointers.
10489 (init_gnutls_functions): New function to initialize function pointers.
10490 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10491 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10492 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10493 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10494 (emacs_gnutls_write, emacs_gnutls_read)
10495 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10496 (Fgnutls_available_p): New function.
10497 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10498 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10499 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10500
10501 * image.c: Include w32.h.
10502 (Vimage_type_cache): Delete.
10503 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10504 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10505 (w32_delayed_load): Move to w32.c.
10506
10507 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10508
10509 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10510 (w32_delayed_load): Move from image.c. When loading a library, record
10511 its filename in the :loaded-from property of the library id.
10512 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10513 Initialize and staticpro them.
10514 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10515
10516 * process.c: Include lisp.h before w32.h, not after.
10517 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10518 instead of gnutls_record_check_pending.
10519
10520 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10521
ff4de4aa
TZ
105222011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10523
10524 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10525 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10526 as passed in.
10527
abe95abb
JD
105282011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10529
10530 * xterm.c (x_set_frame_alpha): Do not set property on anything
10531 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10532
e16e55d4
JB
105332011-05-02 Juanma Barranquero <lekktu@gmail.com>
10534
10535 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10536
bafcf6a5
JB
105372011-05-02 Juanma Barranquero <lekktu@gmail.com>
10538
10539 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10540 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10541 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10542 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10543 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10544 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10545 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10546 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10547 (Qgnutls_bootprop_callbacks_verify): Make static.
10548
e7a6747f
AS
105492011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10550
19ed11ba
AS
10551 * callproc.c: Indentation fixup.
10552
e7a6747f 10553 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10554 (wait_for_termination, interruptible_wait_for_termination):
10555 Move after wait_for_termination_1.
e7a6747f 10556
1ef14cb4
LMI
105572011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10558
10559 * sysdep.c (interruptible_wait_for_termination): New function
10560 which is like wait_for_termination, but allows keyboard
10561 interruptions.
10562
10563 * callproc.c (Fcall_process): Add (:file "file") as an option for
10564 the STDOUT buffer.
10565 (Fcall_process_region): Ditto.
10566
330d880c
EZ
105672011-04-30 Eli Zaretskii <eliz@gnu.org>
10568
8db90b73
EZ
10569 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10570 rather than `XVECTOR (FOO)->size'.
10571
330d880c
EZ
10572 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10573 inttypes.h, as a gnulib replacement is used if it not available in
10574 system headers.
10575
15cbd324
EZ
105762011-04-21 Eli Zaretskii <eliz@gnu.org>
10577
10578 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10579 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10580 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10581
10582 * coding.c (coding_alloc_by_realloc): Error out if destination
10583 will grow beyond MOST_POSITIVE_FIXNUM.
10584 (decode_coding_emacs_mule): Abort if there isn't enough place in
10585 charbuf for the composition carryover bytes. Reserve an extra
10586 space for up to 2 characters produced in a loop.
10587 (decode_coding_iso_2022): Abort if there isn't enough place in
10588 charbuf for the composition carryover bytes.
10589
105902011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10591
ae940cca
EZ
10592 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10593 aborting when %lld or %lll format is passed.
10594 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10595 %llo or %llx format is passed. (Bug#8545)
10596
03ab8921
EZ
10597 * window.c (window_scroll_line_based): Use a marker instead of
10598 simple variables to record original value of point. (Bug#7952)
10599
afda1437
EZ
10600 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10601 produced by %s or %c overflows available buffer space. (Bug#8545)
10602
f76dee0c
PE
106032011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10604
10605 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10606 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10607
fdc5744d
JB
106082011-04-28 Juanma Barranquero <lekktu@gmail.com>
10609
10610 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10611
638f053a
JB
106122011-04-28 Juanma Barranquero <lekktu@gmail.com>
10613
10614 * keyboard.c (Qdelayed_warnings_hook): Define.
10615 (command_loop_1): Run `delayed-warnings-hook'
10616 if Vdelayed_warnings_list is non-nil.
10617 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10618 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10619
d178f871
EZ
106202011-04-28 Eli Zaretskii <eliz@gnu.org>
10621
10622 * doprnt.c (doprnt): Don't return value smaller than the buffer
10623 size if the message was truncated. (Bug#8545).
10624
b124fd93
JB
106252011-04-28 Juanma Barranquero <lekktu@gmail.com>
10626
10627 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10628 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10629
e810457d
PE
106302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10631
10632 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10633
ea51cceb
JB
106342011-04-27 Juanma Barranquero <lekktu@gmail.com>
10635
10636 * makefile.w32-in: Update dependencies.
10637
94dcfacf
EZ
106382011-04-27 Eli Zaretskii <eliz@gnu.org>
10639
10640 Improve `doprnt' and its usage. (Bug#8545)
10641 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10642 `format_end'. Remove support for %l as a conversion specifier.
10643 Don't use xrealloc. Improve diagnostics when the %l size modifier
10644 is used. Update the commentary.
10645
10646 * eval.c (verror): Simplify calculation of size_t.
10647
10648 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10649 messages.
10650
f61f41d7
PE
106512011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10652
10653 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10654 change.
10655
96fb4434
PE
106562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10657
10658 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10659 This makes this file independent of the recent pseudovector change.
10660
671875da 106612011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10662
69e9b5a3
PE
10663 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10664
b5f869a7 10665 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10666 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10667 Remove unused local.
c8926152 10668 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10669
841a1577 10670 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10671 GCC 4.6.0 optimizes based on type-based alias analysis.
10672 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10673 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10674 != &v->size, and therefore "v->size = 1; b->size = 2; return
10675 v->size;" must therefore return 1. This assumption is incorrect
10676 for Emacs, since it type-puns struct Lisp_Vector * with many other
10677 types. To fix this problem, this patch adds a new type struct
f904488f 10678 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10679 and pseudovectors, and helps optimizing compilers not get fooled
10680 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10681 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10682 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10683 the size member.
eab3844f
PE
10684 (XSETPVECTYPE): Rewrite in terms of new macro.
10685 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10686 This is a bit clearer, and further avoids the possibility of
10687 undesirable aliasing.
10688 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10689 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10690 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10691 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10692 (ASIZE): Now uses header.size rather than size.
10693 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10694 to avoid the hassle of writing XVECTOR (foo)->header.size.
10695 (struct vectorlike_header): New type.
eab3844f
PE
10696 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10697 object, to help avoid aliasing.
10698 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10699 (SUBRP): Likewise, since Lisp_Subr is a special case.
10700 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10701 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10702 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10703 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10704 changed to be "header.size" and "header.next".
10705 * buffer.h (struct buffer): Likewise.
10706 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10707 * frame.h (struct frame): Likewise.
10708 * process.h (struct Lisp_Process): Likewise.
10709 * termhooks.h (struct terminal): Likewise.
10710 * window.c (struct save_window_data, struct saved_window): Likewise.
10711 * window.h (struct window): Likewise.
10712 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10713 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10714 * buffer.c (init_buffer_once): Likewise.
10715 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10716 special case.
10717 * process.c (Fformat_network_address): Use local var for size,
10718 for brevity.
10719
0df1eac5
PE
10720 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10721
847ab9d1 10722 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10723 * data.c (atof): Remove decl; no longer used or needed.
10724 (digit_to_number): Move to lread.c.
10725 (Fstring_to_number): Use new string_to_number function, to be
10726 consistent with how the Lisp reader treats infinities and NaNs.
10727 Do not assume that floating-point numbers represent EMACS_INT
10728 without losing information; this is not true on most 64-bit hosts.
10729 Avoid double-rounding errors, by insisting on integers when
10730 parsing non-base-10 numbers, as the documentation specifies.
10731 * lisp.h (string_to_number): New decl, replacing ...
10732 (isfloat_string): Remove.
bc0a5c13 10733 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10734 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10735 appears to have been a coding error. Similarly, do not accept
10736 strings like +-1e0 as floating point numbers. Do not report
10737 overflow for integer overflows unless the base is not 10 which
10738 means we have no simple and reliable way to continue.
10739 Break out the floating-point parsing into a new
10740 function string_to_number, so that Fstring_to_number parses
10741 floating point numbers consistently with the Lisp reader.
04f2d78b 10742 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10743 (E_CHAR, EXP_INT): Remove, replacing with ...
10744 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10745 (string_to_number): New function, replacing isfloat_string.
10746 This function checks for valid syntax and produces the resulting
10747 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10748 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10749 so that overflow for non-base-10 numbers is reported only when
10750 there's no portable and simple way to convert to floating point.
452f4150 10751
67769ffc
PE
10752 * textprop.c (set_text_properties_1): Rewrite for clarity,
10753 and to avoid GCC warning about integer overflow.
10754
c20db43f
PE
10755 * intervals.h (struct interval): Use EMACS_INT for members
10756 where EMACS_UINT might cause problems. See
10757 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10758 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10759 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10760 All uses changed.
37aa2f85
PE
10761 (offset_intervals): Tell GCC not to worry about length overflow
10762 when negating a negative length.
c20db43f 10763
2538aa2f
PE
10764 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10765 (overrun_check_free): Likewise.
10766
f2d3008d
PE
10767 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10768 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10769 word size.
10770
ec8df744
PE
10771 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10772 (gnutls_make_error): Rename local to avoid shadowing.
10773 (gnutls_emacs_global_deinit): ifdef out; not used.
10774 (Fgnutls_boot): Use const for pointer to readonly storage.
10775 Comment out unused local. Fix pointer signedness problems.
10776
640ee02d
PE
10777 * lread.c (openp): Don't stuff size_t into an 'int'.
10778 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10779 about possible signed overflow.
10780
6048fb2a
PE
10781 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10782 (GDK_KEY_g): Don't define if already defined.
10783 (xg_prepare_tooltip): Avoid pointer signedness problem.
10784 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10785
fa3c87e1
PE
10786 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10787 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10788
2172544b
PE
10789 * xfns.c (Fx_window_property): Simplify a bit,
10790 to make a bit faster and to avoid GCC 4.6.0 warning.
10791 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10792
9b821a21
PE
10793 * fns.c (internal_equal): Don't assume size_t fits in int.
10794
3c616cfa
PE
10795 * alloc.c (compact_small_strings): Tighten assertion a little.
10796
c2982e87
PE
10797 Replace pEd with more-general pI, and fix some printf arg casts.
10798 * lisp.h (pI): New macro, generalizing old pEd macro to other
10799 conversion specifiers. For example, use "...%"pI"d..." rather
10800 than "...%"pEd"...".
10801 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10802 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10803 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10804 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10805 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10806 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10807 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10808 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10809 64-bit hosts.
10810 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10811 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10812 * print.c (safe_debug_print, print_object): Likewise.
10813 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10814 to int.
6f04d126
PE
10815 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10816 avoiding the 0 flag, which is not portable.
c2982e87
PE
10817 * process.c (Fmake_network_process): Use pI to avoid cast.
10818 * region-cache.c (pp_cache): Likewise.
10819 * xdisp.c (decode_mode_spec): Likewise.
10820 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10821 behavior on 64-bit hosts with printf arg.
6f04d126 10822 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10823 (x_stop_queuing_selection_requests): Likewise.
10824 (x_get_window_property): Don't truncate byte count to an 'int'
10825 when tracing.
0b432f21 10826
5e073ec7
PE
10827 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10828 here, since it parses constructs like leading '-' and spaces,
10829 which are not wanted; and it overflows with large numbers.
10830 Instead, simply match F[0-9]+, which is what is wanted anyway.
10831
36372bf9
PE
10832 * alloc.c: Remove unportable assumptions about struct layout.
10833 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10834 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10835 (allocate_vectorlike, make_pure_vector): Use the new macros,
10836 plus offsetof, to remove unportable assumptions about struct layout.
10837 These assumptions hold on all porting targets that I know of, but
10838 they are not guaranteed, they're easy to remove, and removing them
10839 makes further changes easier.
10840
0b432f21
PE
10841 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10842 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10843 (string_overrun_cookie): Now const. Use initializers that
10844 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10845 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10846 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10847 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10848 multiple of sizeof (EMACS_INT); it need not be, if
10849 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10850 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10851
895009e1
JB
108522011-04-26 Juanma Barranquero <lekktu@gmail.com>
10853
10854 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10855
6a7a1b0b
TZ
108562011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10857
10858 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10859 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10860 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10861
841a1577 108622011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10863
10864 * lisp.h (Qdebug): List symbol.
895009e1 10865 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10866 * keyboard.c (debug-on-event): New variable.
10867 (handle_user_signal): Break into debugger when debug-on-event
10868 matches the current signal symbol.
10869
f2d3ba6f
DN
108702011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10871
10872 * alloc.c (check_sblock, check_string_bytes)
10873 (check_string_free_list): Convert to standard C.
10874
42ce4c63
TZ
108752011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10876
10877 * w32.c (emacs_gnutls_push): Fix typo.
10878
825cd63c
EZ
108792011-04-25 Eli Zaretskii <eliz@gnu.org>
10880
fb11d64d
EZ
10881 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10882 "cast to pointer from integer of different size".
10883
825cd63c
EZ
10884 Improve doprnt and its use in verror. (Bug#8545)
10885 * doprnt.c (doprnt): Document the set of format control sequences
10886 supported by the function. Use SAFE_ALLOCA instead of always
10887 using `alloca'.
10888
10889 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10890 is one byte too soon. Don't use xrealloc; instead xfree and
10891 xmalloc anew.
10892
e061a11b
TZ
108932011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10894
10895 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10896 callbacks stage.
10897
10898 * gnutls.c: Renamed global_initialized to
10899 gnutls_global_initialized. Added internals for the
10900 :verify-hostname-error, :verify-error, and :verify-flags
10901 parameters of `gnutls-boot' and documented those parameters in the
10902 docstring. Start callback support.
9173deec
JB
10903 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10904 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10905 on error. Return error code.
e061a11b
TZ
10906 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10907 (emacs_gnutls_read): Likewise.
10908 (Fgnutls_boot): Return handshake error code.
10909 (emacs_gnutls_handle_error): New function.
10910 (wsaerror_to_errno): Likewise.
10911
10912 * w32.h (emacs_gnutls_pull): Add prototype.
10913 (emacs_gnutls_push): Likewise.
10914
10915 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10916 (emacs_gnutls_push): Likewise.
10917
109182011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10919
10920 * process.c (wait_reading_process_output): Check if GnuTLS
10921 buffered some data internally if no FDs are set for TLS
10922 connections.
10923
10924 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10925 (LIBS): Link to USER_LIBS.
10926 ($(BLD)/gnutls.$(0)): New target.
10927
fa6996bc
EZ
109282011-04-24 Eli Zaretskii <eliz@gnu.org>
10929
eb35682e
EZ
10930 * xdisp.c (handle_single_display_spec): Rename the
10931 display_replaced_before_p argument into display_replaced_p, to
10932 make it consistent with the commentary. Fix typos in the
10933 commentary.
10934
e2ad650c
EZ
10935 * textprop.c (syms_of_textprop): Remove dead code.
10936 (copy_text_properties): Delete obsolete commentary about an
10937 interface that was deleted long ago. Fix typos in the description
10938 of arguments.
10939
1b2de274
EZ
10940 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10941 to changes in oldXMenu/XMenu.h from 2011-04-16.
10942 <menu_help_message, prev_menu_help_message>: Constify.
10943 (IT_menu_make_room): menu->help_text is now `const char **';
10944 adjust.
10945
10946 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10947 to changes in oldXMenu/XMenu.h from 2011-04-16.
10948 (struct XMenu): Declare `help_text' `const char **'.
10949
10950 * xfaces.c <Qunspecified>: Make extern again.
10951
10952 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10953 required by POSIX.
1b2de274 10954
762b15be
EZ
10955 * doc.c (get_doc_string): Improve the format passed to `error'.
10956
10957 * doprnt.c (doprnt): Improve commentary.
10958
10959 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10960
10961 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10962 them with etags.
10963
f1052e5d
EZ
10964 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10965 changes in globals.h immediately force recompilation.
762b15be
EZ
10966 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10967 $(CURDIR)/s/ms-w32.h.
10968 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10969
fa6996bc
EZ
10970 * character.c (Fchar_direction): Function deleted.
10971 (syms_of_character): Don't defsubr it.
10972 <char-direction-table>: Deleted.
10973
e6c3da20
EZ
109742011-04-23 Eli Zaretskii <eliz@gnu.org>
10975
10976 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10977 * doprnt.c: Include limits.h.
10978 (SIZE_MAX): New macro.
04f2d78b
CB
10979 (doprnt): Return a size_t value. 2nd arg is now size_t.
10980 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10981 Improve overflow protection. Support `l' modifier for integer
10982 conversions. Support %l conversion. Don't assume an EMACS_INT
10983 argument for integer conversions and for %c.
10984
10985 * lisp.h (doprnt): Restore prototype.
10986
10987 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10988 $(SRC)/character.h.
10989
10990 * Makefile.in (base_obj): Add back doprnt.o.
10991
10992 * deps.mk (doprnt.o): Add back prerequisites.
10993 (callint.o): Depend on character.h.
10994
10995 * eval.c (internal_lisp_condition_case): Include the handler
10996 representation in the error message.
10997 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10998 when breaking from the loop.
10999
11000 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11001
11002 * callint.c (Fcall_interactively): When displaying error message
11003 about invalid control letter, pass the character's codepoint, not
11004 a pointer to its multibyte form. Improve display of the character
11005 in octal and display also its hex code.
11006
11007 * character.c (char_string): Use %x to display the (unsigned)
11008 codepoint of an invalid character, to avoid displaying a bogus
11009 negative value.
11010
11011 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11012 `error', not SYMBOL_NAME itself.
11013
11014 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11015 character arguments to `error'.
11016
11017 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11018 to `error' in error message about FINAL_CHAR argument. Make sure
11019 FINAL_CHAR is a character, and use %c when it is passed as
11020 argument to `error'.
11021
4ffd0d6b 110222011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11023
11024 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11025
11026 * w32.c: Include <time.h>.
11027 (sys_localtime): New function.
11028
4ffd0d6b 110292011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11030
11031 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11032
4ffd0d6b 11033 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11034
4ffd0d6b 110352011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11036
4ffd0d6b
GM
11037 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11038 zombies (Bug#8467).
aac0c6e3 11039
04c56954
EZ
110402011-04-19 Eli Zaretskii <eliz@gnu.org>
11041
11042 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11043 gl_state.e_property when gl_state.object is Qt.
11044
11045 * insdel.c (make_gap_larger): Remove limitation of buffer size
11046 to <= INT_MAX.
11047
16a43933
CY
110482011-04-18 Chong Yidong <cyd@stupidchicken.com>
11049
11050 * xdisp.c (lookup_glyphless_char_display)
11051 (produce_glyphless_glyph): Handle cons cell entry in
11052 glyphless-char-display.
11053 (Vglyphless_char_display): Document it.
11054
11055 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11056 glyphless-char-display.
11057
4581706e
CY
110582011-04-17 Chong Yidong <cyd@stupidchicken.com>
11059
11060 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11061
11062 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11063
11064 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11065 definition for no-X builds.
11066
4887c6e2 110672011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11068
fd35b6f9
PE
11069 Static checks with GCC 4.6.0 and non-default toolkits.
11070
5c1ccb01
PE
11071 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11072
006c5daa
PE
11073 * process.c (keyboard_bit_set): Define only if SIGIO.
11074 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11075 (send_process): Repair possible setjmp clobbering.
11076
efc736d3
PE
11077 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11078
4e2fe2e6
PE
11079 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11080
f97334a2
PE
11081 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11082
4e75f29d
PE
11083 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11084 Define only if needed.
11085
90efadd1
PE
11086 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11087 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11088 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11089
3c647824
PE
11090 * dispextern.h (struct redisplay_interface): Rename param
11091 to avoid shadowing.
e264f262 11092 * termhooks.h (struct terminal): Likewise.
761383f4 11093 * xterm.c (xembed_send_message): Likewise.
3c647824 11094
b58c5c4a
PE
11095 * insdel.c (make_gap_smaller): Define only if
11096 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11097
cad59032
PE
11098 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11099 it.
11100
c339dc2e
PE
11101 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11102 so that we aren't warned about unused symbols.
11103
91a3e27b
PE
11104 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11105
399c71d3 11106 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11107
8ffc96f5
PE
11108 * xfns.c (x_real_positions): Mark locals as initialized.
11109
eef9bc79
PE
11110 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11111
098db9dd
PE
11112 * xterm.c: Fix problems found by static analysis with other toolkits.
11113 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11114 (x_dispatch_event): Declare static if USE_GTK, and
11115 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11116 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11117 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11118 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11119 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11120
eb18f6cc
PE
11121 * xmenu.c (menu_help_callback): Pointer type fixes.
11122 Use const pointers when pointing at readonly data. Avoid pointer
11123 signedness clashes.
11124 (FALSE): Remove unused macro.
11125 (update_frame_menubar): Remove unused decl.
11126
1fe72bf8
PE
11127 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11128
60d9e1db
PE
11129 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11130 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11131 (single_menu_item): Rename local to avoid shadowing.
11132
39261c26
PE
11133 * keyboard.c (make_lispy_event): Remove unused local var.
11134
018c5e19
PE
11135 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11136 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11137
63d2b86e
PE
11138 * bitmaps: Change bitmaps from unsigned char back to the X11
11139 compatible char. Avoid the old compiler warnings about
11140 out-of-range initializers by using, for example, '\xab' rather
11141 than 0xab.
11142
aefd87e1
PE
11143 * xgselect.c (xgselect_initialize): Check vs interface
11144 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11145
bf501fb9
PE
11146 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11147
e9829fdf
PE
11148 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11149 to read-only memory.
11150
1086c095
PE
11151 * fns.c (vector): Remove; this old hack is no longer needed.
11152
2baccd04 11153 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11154 Remove unused var.
dde42981 11155 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11156
72391843 11157 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11158
436c16df 11159 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11160 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11161 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11162
92bb796d 11163 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11164 (x_term_init): Remove local to avoid shadowing.
92bb796d 11165
764430a3 11166 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11167
11168 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11169 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11170
d1dfb56c
EZ
111712011-04-16 Eli Zaretskii <eliz@gnu.org>
11172
c4354cb4
EZ
11173 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11174
d1dfb56c
EZ
11175 Fix regex.c, syntax.c and friends for buffers > 2GB.
11176 * syntax.h (struct gl_state_s): Declare character position members
11177 EMACS_INT.
11178
11179 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11180
04f2d78b
CB
11181 * textprop.c (verify_interval_modification, interval_of):
11182 Declare arguments EMACS_INT.
d1dfb56c
EZ
11183
11184 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11185 EMACS_INT.
11186
11187 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11188
11189 * indent.c (Fvertical_motion): Local variable it_start is now
11190 EMACS_INT.
11191
11192 * regex.c (re_match, re_match_2, re_match_2_internal)
11193 (bcmp_translate, regcomp, regexec, print_double_string)
11194 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11195 (re_compile_pattern, re_exec): Declare arguments and local
11196 variables `size_t' and `ssize_t' and return values `regoff_t', as
11197 appropriate.
11198 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11199 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11200 <compile_stack_type>: `size' and `avail' are now `size_t'.
11201
11202 * regex.h <regoff_t>: Use ssize_t, not int.
11203 (re_search, re_search_2, re_match, re_match_2): Arguments that
11204 specify buffer/string position and length are now ssize_t and
11205 size_t. Return type is regoff_t.
11206
613052cd
BK
112072011-04-16 Ben Key <bkey76@gmail.com>
11208
11209 * nsfont.m: Fixed bugs in ns_get_family and
11210 ns_descriptor_to_entity that were caused by using free to
11211 deallocate memory blocks that were allocated by xmalloc (via
11212 xstrdup). This caused Emacs to crash when compiled with
11213 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11214 --enable-checking=xmallocoverrun). xfree is now used to
11215 deallocate these memory blocks.
11216
4170f62f 112172011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11218
71b41406
PE
11219 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11220
9587a89d
PE
11221 emacs_write: Accept and return EMACS_INT for sizes.
11222 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11223 et seq.
11224 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11225 Accept and return EMACS_INT.
11226 (emacs_gnutls_write): Return the number of bytes written on
11227 partial writes.
11228 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11229 (emacs_read, emacs_write): Remove check for negative size, as the
11230 Emacs source code has been audited now.
9587a89d
PE
11231 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11232 (emacs_read, emacs_write): Use it.
273a5f82
PE
11233 * process.c (send_process): Adjust to the new signatures of
11234 emacs_write and emacs_gnutls_write. Do not attempt to store
11235 a byte offset into an 'int'; it might overflow.
9587a89d 11236 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11237
3e047f51
PE
11238 * sound.c: Don't assume sizes fit in 'int'.
11239 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11240 Return EMACS_INT, not int.
3e047f51 11241 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11242 Accept EMACS_INT, not int.
11243 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11244 record read return values.
11245
cc39a9db
BK
112462011-04-15 Ben Key <bkey76@gmail.com>
11247
c9d0ec6d
JB
11248 * keyboard.c (Qundefined): Don't declare static since it is used
11249 in nsfns.m.
11250 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11251 static since they are used in nsfont.m.
cc39a9db 11252
6c60eb9f
SM
112532011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11254
11255 * process.c (Qprocessp): Don't declare static.
11256 * lisp.h (Qprocessp): Declare again.
11257
7990b61a
JB
112582011-04-15 Juanma Barranquero <lekktu@gmail.com>
11259
11260 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11261
5d4cb038
PE
112622011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11263
8bd7b830 11264 Improve C-level modularity by making more things 'static'.
cd64ea1d 11265
e3b27b31
PE
11266 Don't publish debugger-only interfaces to other modules.
11267 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11268 (verify_bytepos, count_markers): Move decls to the only modules
11269 that need them.
11270 * region-cache.h (pp_cache): Likewise.
11271 * window.h (check_all_windows): Likewise.
11272 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11273
5d4cb038
PE
11274 * sysdep.c (croak): Now static, if
11275 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11276 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11277
11278 * alloc.c (refill_memory_reserve): Now static if
11279 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11280 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11281
e87b6180
PE
11282 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11283 Define only if USE_LUCID.
11284
ac64929e
PE
11285 * xrdb.c (x_customization_string, x_rm_string): Now static.
11286
6f37259d
PE
11287 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11288 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11289
1683e3ab
PE
11290 * xdisp.c (draw_row_with_mouse_face): Now static.
11291 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11292
de9c2632
PE
11293 * window.h (check_all_windows): Mark externally visible.
11294
2b96acb7
PE
11295 * window.c (window_deletion_count): Now static.
11296
11297 * undo.c: Make symbols static if they're not exported.
11298 (last_undo_buffer, last_boundary_position, pending_boundary):
11299 Now static.
11300
50436f33
PE
11301 * textprop.c (interval_insert_behind_hooks): Now static.
11302 (interval_insert_in_front_hooks): Likewise.
11303
64520e5c
PE
11304 * term.c: Make symbols static if they're not exported.
11305 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11306 (max_frame_lines, tty_set_terminal_modes):
11307 (tty_reset_terminal_modes, tty_turn_off_highlight):
11308 (get_tty_terminal): Now static.
11309 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11310 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11311 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11312 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11313 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11314
1fa53021
PE
11315 * sysdep.c: Make symbols static if they're not exported.
11316 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11317 Now static.
11318 (sigprocmask_set, full_mask): Remove; unused.
11319 (wait_debugging): Mark as visible.
11320 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11321 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11322
d4b43b22
PE
11323 * syntax.c (syntax_temp): Define only if !__GNUC__.
11324
b7c513d0
PE
11325 * sound.c (current_sound_device, current_sound): Now static.
11326
989b29ad
PE
11327 * search.c (searchbufs, searchbuf_head): Now static.
11328
13a55a78
PE
11329 * scroll.c (scroll_cost): Remove; unused.
11330 * dispextern.h (scroll_cost): Remove decl.
11331
de68a1fc
PE
11332 * region-cache.h (pp_cache): Mark as externally visible.
11333
40ccffa6
PE
11334 * process.c: Make symbols static if they're not exported.
11335 (process_tick, update_tick, create_process, chan_process):
11336 (Vprocess_alist, proc_buffered_char, datagram_access):
11337 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11338 (deactivate_process): Mark defn as static, as well as decl.
11339 * lisp.h (create_process): Remove decl.
11340 * process.h (chan_process, Vprocess_alist): Remove decls.
11341
ad64fc97
PE
11342 * print.c: Make symbols static if they're not exported.
11343 (print_depth, new_backquote_output, being_printed, print_buffer):
11344 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11345 (print_interval, print_number_index, initial_stderr_stream):
11346 Now static.
11347 * lisp.h (Fprinc): Remove decl.
11348 (debug_output_compilation_hack): Mark as externally visible.
11349
adddb265
PE
11350 * sysdep.c (croak): Move decl from here to syssignal.h.
11351 * syssignal.h (croak): Put it here, so the API can be checked when
11352 'croak' is called from dissociate_if_controlling_tty.
11353
1717ede2
PE
11354 * minibuf.c: Make symbols static if they're not exported.
11355 (minibuf_save_list, choose_minibuf_frame): Now static.
11356 * lisp.h (choose_minibuf_frame): Remove decl.
11357
fa5fb2bc
PE
11358 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11359
1e3890d1
PE
11360 * lread.c: Make symbols static if they're not exported.
11361 (read_objects, initial_obarray, oblookup_last_bucket_number):
11362 Now static.
11363 (make_symbol): Remove; unused.
11364 * lisp.h (initial_obarray, make_symbol): Remove decls.
11365
8a1414fa
PE
11366 * keyboard.c: Make symbols static if they're not exported.
11367 (single_kboard, recent_keys_index, total_keys, recent_keys):
11368 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11369 (this_single_command_key_start, echoing, last_auto_save):
11370 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11371 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11372 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11373 (Vlispy_mouse_stem, double_click_count):
11374 Now static.
11375 (force_auto_save_soon): Define only if SIGDANGER.
11376 (ignore_mouse_drag_p): Now static if
11377 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11378 (print_help): Remove; unused.
11379 (stop_character, last_timer_event): Mark as externally visible.
11380 * keyboard.h (ignore_mouse_drag_p): Declare only if
11381 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11382 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11383 * lisp.h (echoing): Remove decl.
11384 (force_auto_save_soon): Declare only if SIGDANGER.
11385 * xdisp.c (redisplay_window): Simplify code, to make it more
11386 obvious that ignore_mouse_drag_p is not accessed if !defined
11387 USE_GTK && !defined HAVE_NS.
11388
93ea6e8f
PE
11389 * intervals.c: Make symbols static if they're not exported.
11390 (merge_properties_sticky, merge_interval_right, delete_interval):
11391 Now static.
11392 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11393
77382fcc
PE
11394 * insdel.c: Make symbols static if they're not exported.
11395 However, leave prepare_to_modify_buffer alone. It's never
11396 called from outside this function, but that appears to be a bug.
11397 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11398 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11399 (adjust_after_replace_noundo): Remove; unused.
11400 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11401 (signal_before_change): Remove decls.
77382fcc 11402
9306c32e
PE
11403 * indent.c (val_compute_motion, val_vmotion): Now static.
11404
cd44d2eb
PE
11405 * image.c: Make symbols static if they're not exported.
11406 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11407 if USE_GTK.
11408 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11409 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11410
ad9a7a06
PE
11411 * fringe.c (standard_bitmaps): Now static.
11412 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11413
81626931
PE
11414 * frame.c: Make symbols static if they're not exported.
11415 (x_report_frame_params, make_terminal_frame): Now static.
11416 (get_frame_param): Now static, unless HAVE_NS.
11417 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11418 (x_get_resource_string): Remove; not used.
11419 * frame.h (make_terminal_frame, x_report_frame_params):
11420 (x_get_resource_string); Remove decls.
11421 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11422 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11423
239f9db9
PE
11424 * font.c, fontset.c: Make symbols static if they're not exported.
11425 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11426 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11427 * font.c (font_close_object): Now static.
11428 * font.h (font_close_object): Remove.
11429 * fontset.c (FONTSET_OBJLIST): Remove.
11430 (free_realized_fontset) #if-0 the body, which does nothing.
11431 (face_suitable_for_char_p): #if-0, as it's never called.
11432 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11433 * xfaces.c (face_at_string_position):
11434 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11435 since 0 is always ASCII.
11436
dfcf3579
PE
11437 * fns.c (weak_hash_tables): Now static.
11438
5045092b
PE
11439 * fileio.c: Make symbols static if they're not exported.
11440 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11441 (Vwrite_region_annotation_buffers): Now static.
11442
57a96f5c
PE
11443 * eval.c: Make symbols static if they're not exported.
11444 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11445 * lisp.h (backtrace_list): Remove decl.
11446
35f08c38
PE
11447 * emacs.c: Make symbols static if they're not exported.
11448 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11449 (fatal_error_code, fatal_error_signal_hook, standard_args):
11450 Now static.
11451 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11452 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11453 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11454 * lisp.h (fatal_error_signal_hook): Remove decl.
11455 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11456
f44bd759
PE
11457 * editfns.c: Move a (normally-unused) function to its only use.
11458 * editfns.c, lisp.h (get_operating_system_release): Remove.
11459 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11460 worth the hassle of breaking this out.
11461
b532497d
PE
11462 * xterm.c: Make symbols static if they're not exported.
11463 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11464 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11465 (x_destroy_window, x_delete_display):
11466 Now static.
11467 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11468 (x_mouse_leave): Remove; unused.
11469 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11470 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11471 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11472 Remove decls.
11473 (x_mouse_leave): Declare only if WINDOWSNT.
11474 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11475 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11476 USE_X_TOOLKIT.
11477
1675728f
PE
11478 * ftxfont.c: Make symbols static if they're not exported.
11479 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11480 HAVE_FREETYPE.
11481 * font.h (ftxfont_driver): Likewise.
11482
e4cebfca
PE
11483 * xfns.c: Make symbols static if they're not exported.
11484 (x_last_font_name, x_display_info_for_name):
11485 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11486 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11487 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11488 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11489 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11490 (last_show_tip_args): Now static.
11491 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11492 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11493 (x_screen_planes): Remove; unused.
11494 * dispextern.h (x_screen_planes): Remove decl.
11495
5bf46f05
PE
11496 * dispnew.c: Make symbols static if they're not exported.
11497 * dispextern.h (redraw_garbaged_frames, scrolling):
11498 (increment_row_positions): Remove.
11499 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11500 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11501 Now static.
11502 (redraw_garbaged_frames): Remove; unused.
11503
435f4c28
PE
11504 * xfaces.c: Make symbols static if they're not exported.
11505 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11506 Remove decls.
11507 * xterm.h (defined_color): Remove decls.
11508 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11509 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11510 (menu_face_changed_default, defined_color, free_realized_face):
11511 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11512 (ascii_face_of_lisp_face): Remove; unused.
11513
8524aef3
PE
11514 * xdisp.c: Make symbols static if they're not exported.
11515 * dispextern.h (scratch_glyph_row, window_box_edges):
11516 (glyph_to_pixel_coords, set_cursor_from_row):
11517 (get_next_display_element, set_iterator_to_next):
11518 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11519 (show_mouse_face): Remove decls
11520 * frame.h (message_buf_print): Likewise.
11521 * lisp.h (pop_message, set_message, check_point_in_composition):
11522 Likewise.
11523 * xterm.h (set_vertical_scroll_bar): Likewise.
11524 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11525 (message_buf_print, scratch_glyph_row, displayed_buffer):
11526 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11527 (get_next_display_element, show_mouse_face, window_box_edges):
11528 (frame_to_window_pixel_xy, check_point_in_composition):
11529 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11530 (glyph_to_pixel_coords): Remove; unused.
11531
16390cd2
PE
11532 * dired.c (file_name_completion): Now static.
11533
11534 * dbusbind.c (xd_in_read_queued_messages): Now static.
11535
a25f4dfa
PE
11536 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11537 * data.c (circular_list_error): Remove.
11538
14a9c8df
PE
11539 * commands.h (last_point_position, last_point_position_buffer):
11540 (last_point_position_window): Remove decls.
11541 * keyboard.c: Make these variables static.
11542
04f2d78b
CB
11543 * coding.h (coding, code_convert_region, encode_coding_gap):
11544 Remove decls.
74ab6df5
PE
11545 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11546 (iso_code_class, detect_coding, code_convert_region): Now static.
11547 (encode_coding_gap): Remove; unused.
11548
38dfbee1
PE
11549 * chartab.c (chartab_chars, chartab_bits): Now static.
11550
a2cb4e63
PE
11551 * charset.h (charset_iso_8859_1): Remove decl.
11552 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11553 Now static.
11554
127198fd
PE
11555 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11556 * ccl.c (Vccl_program_table): Now static.
11557 (check_ccl_update): Remove; unused.
11558
d85b608f
PE
11559 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11560 * category.h: ... from here.
11561 * category.c (check_category_table, set_category_set): Now static.
11562
31cd66f3
PE
11563 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11564 * lisp.h: Remove these decls.
11565
c358e587
PE
11566 * buffer.c (buffer_count): Remove unused var.
11567
e78aecca
PE
11568 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11569 so that it's not optimized away.
11570 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11571 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11572 exported only to the debugger.
11573
e192d7d3 11574 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11575 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11576
92470028
PE
11577 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11578 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11579 was inaccessible from Lisp.
11580 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11581 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11582
244ed907
PE
11583 alloc.c: Import and export fewer symbols, and remove unused items.
11584 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11585 is defined.
11586 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11587 it's not optimized away by whole-program optimization.
11588 (message_enable_multibyte, free_misc): Remove.
11589 (catchlist, handlerlist, mark_backtrace):
11590 Declare only if BYTE_MARK_STACK.
11591 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11592 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11593 (message_enable_multibyte): Remove decl.
11594 (free_misc, interval_free_list, float_block, float_block_index):
11595 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11596 (cons_free_list, last_marked_index):
11597 Now static.
11598 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11599 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11600 (mark_backtrace): Define only if BYTE_MARK_STACK.
11601 * xdisp.c (message_enable_multibyte): Now static.
11602
61c2b50e 11603 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11604 This makes it easier for human readers (and static analyzers)
11605 to see whether these variables are used from other modules.
11606 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11607 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11608 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11609 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11610 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11611 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11612 * xmenu.c, xselect.c:
11613 Declare Q* vars static if they are not used in other modules.
11614 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11615 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11616 Remove decls of unexported vars.
11617 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11618
95c82688
PE
11619 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11620
16a97296
PE
11621 Make Emacs functions such as Fatom 'static' by default.
11622 This makes it easier for human readers (and static analyzers)
11623 to see whether these functions can be called from other modules.
11624 DEFUN now defines a static function. To make the function external
11625 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11626 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11627 (Finit_image_library):
16a97296
PE
11628 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11629 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11630 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11631 Remove decls, since these functions are now static.
11632 (Funintern, Fget_internal_run_time): New decls, since these functions
11633 were already external.
95c82688 11634
16a97296
PE
11635 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11636 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11637 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11638 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11639 * keyboard.c, keymap.c, lread.c:
11640 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11641 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11642 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11643 Mark functions with DEFUE instead of DEFUN,
11644 if they are used in other modules.
11645 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11646 decls for now-static functions.
11647 * buffer.h (Fdelete_overlay): Remove decl.
11648 * callproc.c (Fgetenv_internal): Mark as internal.
11649 * composite.c (Fremove_list_of_text_properties): Remove decl.
11650 (Fcomposition_get_gstring): New forward static decl.
11651 * composite.h (Fcomposite_get_gstring): Remove decl.
11652 * dired.c (Ffile_attributes): New forward static decl.
11653 * doc.c (Fdocumntation_property): New forward static decl.
11654 * eval.c (Ffetch_bytecode): New forward static decl.
11655 (Funintern): Remove extern decl; now in .h file where it belongs.
11656 * fileio.c (Fmake_symbolic_link): New forward static decl.
11657 * image.c (Finit_image_library): New forward static decl.
11658 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11659 * intervals.h (Fprevious_property_change):
11660 (Fremove_list_of_text_properties): Remove decls.
11661 * keyboard.c (Fthis_command_keys): Remove decl.
11662 (Fcommand_execute): New forward static decl.
11663 * keymap.c (Flookup_key): New forward static decl.
11664 (Fcopy_keymap): Now static.
11665 * keymap.h (Flookup_key): Remove decl.
11666 * process.c (Fget_process): New forward static decl.
11667 (Fprocess_datagram_address): Mark as internal.
11668 * syntax.c (Fsyntax_table_p): New forward static decl.
11669 (skip_chars): Remove duplicate decl.
11670 * textprop.c (Fprevious_property_change): New forward static decl.
11671 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11672 Now internal.
11673 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11674 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11675
785bbd42
PE
11676 * editfns.c (Fformat): Remove unreachable code.
11677
8b913b57
AS
116782011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11679
11680 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11681 change. (Bug#8496)
11682
a6744a35
EZ
116832011-04-13 Eli Zaretskii <eliz@gnu.org>
11684
11685 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11686 when at ZV. (Bug#8487)
11687
e7974947
AS
116882011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11689
baad03f0
AS
11690 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11691 (Bug#8437)
11692 * keyboard.c (parse_tool_bar_item): Likewise.
11693 * sound.c (sound_cleanup, alsa_close): Likewise.
11694 * termcap.c (tgetent): Likewise.
11695 * xfns.c (x_default_font_parameter): Likewise.
11696 * xsettings.c (read_and_apply_settings): Likewise.
11697
e7974947
AS
11698 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11699 (overrun_check_free): Protoize.
11700
28272684
PE
117012011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11702
11703 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11704 since callers should never pass a negative size.
11705 Change the signature to match that of plain 'read' and 'write'; see
11706 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11707 * lisp.h: Update prototypes of emacs_write and emacs_read.
11708
11997c76
EZ
117092011-04-11 Eli Zaretskii <eliz@gnu.org>
11710
11711 * xdisp.c (redisplay_window): Don't try to determine the character
11712 position of the scroll margin if the window start point w->startp
e896f03c 11713 is outside the buffer's accessible region. (Bug#8468)
11997c76 11714
8a2cbd72
EZ
117152011-04-10 Eli Zaretskii <eliz@gnu.org>
11716
11717 Fix write-region and its subroutines for buffers > 2GB.
11718 * fileio.c (a_write, e_write): Modify declaration of arguments and
11719 local variables to support buffers larger than 2GB.
11720 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11721
11722 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11723 argument, local variables, and return value.
11724
11725 * lisp.h: Update prototypes of emacs_write and emacs_read.
11726
11727 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11728
4073e537 117292011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11730
1ebfdcb6
PE
11731 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11732
b2ded58d
PE
11733 Fix more problems found by GCC 4.6.0's static checks.
11734
7d66342c
PE
11735 * xdisp.c (vmessage): Use a better test for character truncation.
11736
bbf47d44
PE
11737 * charset.c (load_charset_map): <, not <=, for optimization,
11738 and to avoid potential problems with integer overflow.
9248994d 11739 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11740 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11741 * editfns.c (Fformat): Likewise.
1e69125e 11742 * syntax.c (skip_chars): Likewise.
3befa583 11743
e3019616
PE
11744 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11745 This also lets GCC 4.6.0 generate slightly better loop code.
11746
becfa255
PE
11747 * callint.c (Fcall_interactively): <, not <=, for optimization.
11748 (Fcall_interactively): Count the number of arguments produced,
11749 not the number of arguments given. This is simpler and lets GCC
11750 4.6.0 generate slightly better code.
11751
dae0cd48
PE
11752 * ftfont.c: Distingish more carefully between FcChar8 and char.
11753 The previous code passed unsigned char * to a functions like
11754 strlen and xstrcasecmp that expect char *, which does not
11755 conform to the C standard.
11756 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11757 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11758 char * when the C standard requires it.
11759
76032d70
PE
11760 * keyboard.c (read_char): Remove unused var.
11761
eb3f1cc8
PE
11762 * eval.c: Port to Windows vsnprintf (Bug#8435).
11763 Include <limits.h>.
11764 (SIZE_MAX): Define if the headers do not.
11765 (verror): Do not give up if vsnprintf returns a negative count.
11766 Instead, grow the buffer. This ports to Windows vsnprintf, which
11767 does not conform to C99. Problem reported by Eli Zaretskii.
11768 Also, simplify the allocation scheme, by avoiding the need for
11769 calling realloc, and removing the ALLOCATED variable.
11770
70476b54
PE
11771 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11772
12020a9e
PE
11773 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11774 But keep the doprint source code for now, as we might revamp it
11775 and use it again (Bug#8435).
ea6c7ae6
PE
11776 * lisp.h (doprnt): Remove.
11777 * Makefile.in (base_obj): Remove doprnt.o.
11778 * deps.mk (doprnt.o): Remove.
11779
5fdb398c
PE
11780 error: Print 32- and 64-bit integers portably (Bug#8435).
11781 Without this change, on typical 64-bit hosts error ("...%d...", N)
11782 was used to print both 32- and 64-bit integers N, which relied on
11783 undefined behavior.
61bdb816 11784 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11785 * lisp.h (error, verror): Mark as printf-like functions.
11786 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11787 Report overflow in size calculations when allocating printf buffer.
11788 Do not truncate output string at its first null byte.
11789 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11790 Truncate the output at a character boundary, since vsnprintf does not
11791 do that.
11792 * charset.c (check_iso_charset_parameter): Convert internal
11793 character to string before calling 'error', since %c now has the
11794 printf meaning.
11795 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11796 overflow when computing char to be passed to 'error'. Do not
11797 pass Lisp_Object to 'error'; pass the integer instead.
11798 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11799 formatted with plain %d.
11800
b189fa66
PE
11801 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11802
bff87ef0
PE
11803 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11804
7e2cac20
PE
11805 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11806
ce4d90b5
PE
11807 * xterm.c (x_catch_errors): Remove duplicate declaration.
11808
266c9547
PE
11809 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11810
79c49ad2
PE
11811 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11812
368f4090
JM
118132011-04-10 Jim Meyering <meyering@redhat.com>
11814
11815 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11816 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11817 return ssize_t not "int", and use size_t as the buffer length.
11818 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11819 * gnutls.h: Update declarations.
11820 * process.c (read_process_output): Use ssize_t, to match.
11821 (send_process): Likewise.
11822
a32d4040
CY
118232011-04-09 Chong Yidong <cyd@stupidchicken.com>
11824
11825 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11826
8546720e 118272011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11828
04f2d78b
CB
11829 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11830 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11831
8546720e
GM
11832 * xterm.c (handle_one_xevent):
11833 * xmenu.c (create_and_show_popup_menu):
11834 * xselect.c (x_decline_selection_request)
11835 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11836
0a2f5c1a 118372011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11838
11839 Fix some uses of `int' instead of EMACS_INT.
11840 * search.c (string_match_1, fast_string_match)
11841 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11842 (scan_buffer, find_next_newline_no_quit)
11843 (find_before_next_newline, search_command, Freplace_match)
11844 (Fmatch_data): Make some `int' variables be EMACS_INT.
11845
11846 * xdisp.c (display_count_lines): 3rd argument and return value now
11847 EMACS_INT. All callers changed.
11848 (pint2hrstr): Last argument is now EMACS_INT.
11849
11850 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11851 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11852 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11853 (decode_coding_utf_16, decode_coding_emacs_mule)
11854 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11855 (decode_coding_ccl, decode_coding_charset)
11856 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11857 (decode_coding_iso_2022, decode_coding_emacs_mule)
11858 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11859 <char_offset, last_offset>: Declare EMACS_INT.
11860 (encode_coding_utf_8, encode_coding_utf_16)
11861 (encode_coding_emacs_mule, encode_invocation_designation)
11862 (encode_designation_at_bol, encode_coding_iso_2022)
11863 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11864 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11865 Declare EMACS_INT.
11866 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11867 (encode_invocation_designation): Last argument P_NCHARS is now
11868 EMACS_INT.
11869 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11870 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11871
11872 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11873 All users changed.
11874
11875 * ccl.c (Fccl_execute_on_string): Declare some variables
11876 EMACS_INT.
11877
8546720e 118782011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11879
11880 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11881
4e19a977
CS
118822011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11883
11884 * process.c (Fformat_network_address): Doc fix.
11885
87302331
R
118862011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11887
ee7683eb 11888 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11889
cbb59342
CY
118902011-04-08 Chong Yidong <cyd@stupidchicken.com>
11891
11892 * keyboard.c (read_char): Call Lisp function help-form-show,
11893 instead of using internal_with_output_to_temp_buffer.
11894 (Qhelp_form_show): New var.
e0d38eeb 11895 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11896
11897 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11898
11899 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11900
e67a13ab
CY
119012011-04-06 Chong Yidong <cyd@stupidchicken.com>
11902
04f2d78b
CB
11903 * process.c (Flist_processes): Remove to Lisp.
11904 (list_processes_1): Delete.
e67a13ab 11905
973f782d
EZ
119062011-04-06 Eli Zaretskii <eliz@gnu.org>
11907
7c106b1e
EZ
11908 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11909
973f782d
EZ
11910 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11911
41cf7d1a 119122011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11913
ca23cc88
PE
11914 Fix more problems found by GCC 4.6.0's static checks.
11915
f390e2d5
PE
11916 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11917
42eea0d0
PE
11918 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11919
b69769da 11920 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11921
f9541e84
PE
11922 * xdisp.c (vmessage): Mark as a printf-like function.
11923
13841b55
PE
11924 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11925
c136c10f
PE
11926 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11927
5e2d4a30
PE
11928 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11929 printf-like functions.
11930 (tiff_load): Add casts to remove these marks before passing them
11931 to system-supplied API.
11932
583f48b9
PE
11933 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11934
b25d760e
PE
11935 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11936 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11937 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11938 directly, rather than having caller test rule sign. This avoids
11939 some unnecessary tests.
11940 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11941 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11942 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11943
bc7b6697 11944 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11945 (xfont_open): Avoid unnecessary tests.
bc7b6697 11946
27ccc379
PE
11947 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11948
dcd5c89a
PE
11949 * composite.h, composite.c (composition_gstring_put_cache):
11950 Use EMACS_INT, not int, for length.
11951
b13a45c6
PE
11952 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11953 breaking out part of COMPOSITION_DECODE_RULE.
11954 (COMPOSITION_DECODE_RULE): Use it.
11955 * composite.c (get_composition_id): Remove unused local vars,
11956 by using the new macro.
11957
1e792e4d
PE
11958 * textprop.c (set_text_properties_1): Change while to do-while,
11959 since the condition is always true at first.
11960
dc6c6455 11961 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11962 (interval_deletion_adjustment): Return unsigned value.
11963 All uses changed.
dc6c6455 11964
aba7731a
PE
11965 * process.c (list_processes_1, create_pty, read_process_output):
11966 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11967 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11968 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11969 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11970 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11971
fdfc4bf3
PE
11972 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11973
fca8fe46 11974 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11975 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11976
06a0259a 11977 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11978 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11979 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11980
e7b9e80f
PE
11981 * print.c (print_error_message): Avoid int overflow.
11982
56201685
PE
11983 * font.c (font_list_entities): Redo for clarity,
11984 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11985
78834453 11986 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11987 (font_score): Avoid potential overflow in diff calculation.
78834453 11988
0bc0b309 11989 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11990 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11991
e610eaca
PE
11992 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11993
b895abce
PE
11994 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11995 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11996 can always succeed if overflow has undefined behavior.
11997
1f1d9321 11998 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11999 (wordify): Omit three unnecessary tests.
1f1d9321 12000
c59478bc
PE
12001 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12002 All callers changed. This avoids the need for an unused var.
12003
79b73827
PE
12004 * casefiddle.c (casify_region): Remove var that is set but not used.
12005
a4db5dfe
PE
12006 * dired.c (file_name_completion): Remove var that is set but not used.
12007
43aae36e
PE
12008 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12009
2a47c44d 12010 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12011 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12012
a37c69bf
PE
12013 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12014 Check for integer overflow on size calculations.
12015
328ab8e7
PE
12016 * buffer.c (Fprevious_overlay_change): Remove var that is set
12017 but not used.
12018
e5a2a5cb
PE
12019 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12020 Remove vars that are set but not used.
8d84a6eb 12021 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12022 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12023
a60e5f68
PE
12024 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12025
f661cb61 12026 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12027 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12028
f0397f5a
PE
12029 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12030 that are set but not used.
12031
8664db06 12032 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12033 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12034
6abdaa4a
PE
12035 * xselect.c (x_get_local_selection, x_handle_property_notify):
12036 Remove vars that are set but not used.
12037
0ce7538d 12038 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12039 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12040
9ae848fc
PE
12041 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12042 Remove var that is set but not used.
0b918413
PE
12043 (scroll_bar_windows_size): Now size_t, not int.
12044 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12045 Check for overflow.
9ae848fc 12046
a5a62657
PE
12047 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12048 (map_tty_color) [!defined MSDOS]: Likewise.
12049
5c5cdd39
PE
12050 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12051
66ebf983
PE
12052 * coding.c: Remove vars that are set but not used.
12053 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12054 All callers changed.
12055 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12056 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12057 (decode_coding_charset): Remove vars that are set but not used.
12058
1be4d761
PE
12059 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12060 that is set but not used.
12061
47553fa8
PE
12062 * print.c (print_object): Remove var that is set but not used.
12063
1f7196bf 12064 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12065 The gnulib version avoids calling malloc in the usual case,
12066 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12067 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12068 * filelock.c (current_lock_owner): Likewise.
12069 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12070 * sysdep.c: Include allocator.h, careadlinkat.h.
12071 (emacs_no_realloc_allocator): New static constant.
12072 (emacs_readlink): New function.
fdb61804
PE
12073 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12074 ../lib/careadlinkat.h.
d1fdcab7 12075
f84c17c7
SM
120762011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12077
12078 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12079 first non-nil return value).
12080
ef3862ad
JD
120812011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12082
12083 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12084 if not defined (Bug#8403).
12085
376a7006
JB
120862011-04-02 Juanma Barranquero <lekktu@gmail.com>
12087
12088 * xdisp.c (display_count_lines): Remove parameter `start',
12089 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12090 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12091 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12092 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12093 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12094 and thereabouts. All callers changed.
12095 (get_per_char_metric): Remove parameter `f', unused since
12096 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12097
6ca3801d
JM
120982011-04-02 Jim Meyering <meyering@redhat.com>
12099
12100 do not dereference NULL upon failed strdup
12101 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12102 (ns_get_family): Likewise.
12103
d8e2b5ba
JB
121042011-04-02 Juanma Barranquero <lekktu@gmail.com>
12105
12106 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12107
8c74fcbd
JD
121082011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12109
12110 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12111 later (Bug#8403).
12112
7200d79c
SM
121132011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12114
03408648 12115 Add lexical binding.
7200d79c 12116
03408648
SM
12117 * window.c (Ftemp_output_buffer_show): New fun.
12118 (Fsave_window_excursion):
12119 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12120
12121 * lread.c (lisp_file_lexically_bound_p): New function.
12122 (Fload): Bind Qlexical_binding.
12123 (readevalloop): Remove `evalfun' arg.
12124 Bind Qinternal_interpreter_environment.
12125 (Feval_buffer): Bind Qlexical_binding.
12126 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12127 Mark as dynamic.
12128 (syms_of_lread): Declare `lexical-binding'.
12129
12130 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12131
12132 * keyboard.c (eval_dyn): New fun.
12133 (menu_item_eval_property): Use it.
ca105506
SM
12134
12135 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12136
03408648
SM
12137 * fns.c (concat, mapcar1): Accept byte-code-functions.
12138
12139 * eval.c (Fsetq): Handle lexical vars.
12140 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12141 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12142 (FletX, Flet): Obey lexical binding.
12143 (Fcommandp): Handle closures.
12144 (Feval): New `lexical' arg.
12145 (eval_sub): New function extracted from Feval. Use it almost
12146 everywhere where Feval was used. Look up vars in lexical env.
12147 Handle closures.
12148 (Ffunctionp): Move from subr.el.
12149 (Ffuncall): Handle closures.
12150 (apply_lambda): Remove `eval_flags'.
12151 (funcall_lambda): Handle closures and new byte-code-functions.
12152 (Fspecial_variable_p): New function.
12153 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12154 but without exporting it to Lisp.
23aba0ea 12155
23aba0ea 12156 * doc.c (Fdocumentation, store_function_docstring):
03408648 12157 * data.c (Finteractive_form): Handle closures.
23aba0ea 12158
03408648
SM
12159 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12160 interactive spec.
ba83908c 12161
04f2d78b
CB
12162 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12163 New byte-codes.
03408648
SM
12164 (exec_byte_code): New function extracted from Fbyte_code to handle new
12165 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12166
03408648 12167 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12168
03408648 12169 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12170
e2abce01
JB
121712011-03-31 Juanma Barranquero <lekktu@gmail.com>
12172
12173 * xdisp.c (redisplay_internal): Fix prototype.
12174
63696a73 121752011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12176
63696a73 12177 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12178 (try_scrolling): Use it when setting scroll_limit.
12179 Limit scrolling to 100 screen lines.
63696a73
EZ
12180 (redisplay_window): Even when falling back on "recentering",
12181 position point in the window according to scroll-conservatively,
12182 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12183
12184 (try_scrolling): When point is above the window, allow searching
12185 as far as scroll_max, or one screenful, to compute vertical
12186 distance from PT to the scroll margin position. This prevents
12187 try_scrolling from unnecessarily failing when
12188 scroll-conservatively is set to a value slightly larger than the
12189 window height. Clean up the case of PT below the margin at bottom
12190 of window: scroll_max can no longer be INT_MAX. When aggressive
12191 scrolling is in use, don't let point enter the opposite scroll
12192 margin as result of the scroll.
12193 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12194 threshold of 100 lines for never-recentering scrolling.
12195
e4cc2dfc
JB
121962011-03-31 Juanma Barranquero <lekktu@gmail.com>
12197
12198 * dispextern.h (move_it_by_lines):
12199 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12200 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12201 (message_log_check_duplicate): Remove parameters `prev_bol' and
12202 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12203 (redisplay_internal): Remove parameter `preserve_echo_area',
12204 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12205
12206 * indent.c (Fvertical_motion):
12207 * window.c (window_scroll_pixel_based, Frecenter):
12208 Don't pass `need_y_p' to `move_it_by_lines'.
12209
1c470562
SM
122102011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12211
44f230aa
SM
12212 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12213 steal a few bits to be more compact.
12214 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12215 Remove unneeded casts.
12216
1c470562
SM
12217 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12218
888adce9
ZK
122192011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12220
12221 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12222 binding" message (bug#7967).
12223
f838ed7b
PE
122242011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12225
77861b95
PE
12226 Fix more problems found by GCC 4.6.0's static checks.
12227
de6dbc14
PE
12228 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12229 Remove unused local var.
12230
f838ed7b
PE
12231 * editfns.c (Fmessage_box): Remove unused local var.
12232
792c7b2b
PE
12233 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12234 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12235 Omit unused local vars.
c499e557 12236 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12237 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12238 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12239 Omit unused local var.
12240
ba0165e1
PE
12241 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12242 Don't assume string length fits in int.
32ad8845 12243 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12244 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12245
3c59b4c9
PE
12246 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12247 instead of alloca (Bug#8344).
12248
a3eed478 12249 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12250 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12251
eb4d412d
PE
12252 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12253
1658b401
PE
12254 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12255 concerns.
12256
12257 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12258
12259 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12260
9a2c6e05
PE
12261 * keyboard.c (syms_of_keyboard): Use the same style as later
12262 in this function when indexing through an array. This also
12263 works around GCC bug 48267.
12264
03d0a109
PE
12265 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12266
44f730c8
PE
12267 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12268
fe75f926
PE
12269 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12270 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12271
ffa8c828
PE
12272 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12273 This avoids undefined behavior on integer overflow, and is a bit
12274 more convenient anyway since it is compared to a size_t variable.
12275
c5101a77
PE
12276 Variadic C functions now count arguments with size_t, not int.
12277 This avoids an unnecessary limitation on 64-bit machines, which
12278 caused (substring ...) to crash on large vectors (Bug#8344).
12279 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12280 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12281 All variadic functions and their callers changed accordingly.
c5101a77
PE
12282 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12283 * data.c (arith_driver, float_arith_driver): Likewise.
12284 * editfns.c (general_insert_function): Likewise.
12285 * eval.c (struct backtrace.nargs, interactive_p)
12286 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12287 (funcall_lambda, mark_backtrace): Likewise.
12288 * fns.c (concat): Likewise.
12289 * frame.c (x_set_frame_parameters): Likewise.
12290 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12291 0 if not found, not -1. All callers changed.
12292
dd3f25f7
PE
12293 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12294 (stack_copy_size): Now size_t, not int.
12295 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12296
461c2ab9
JB
122972011-03-28 Juanma Barranquero <lekktu@gmail.com>
12298
12299 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12300 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12301 All callers changed.
12302
12303 * lisp.h (multibyte_char_to_unibyte):
12304 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12305 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12306 * character.h (CHAR_TO_BYTE8):
12307 * cmds.c (internal_self_insert):
12308 * editfns.c (general_insert_function):
12309 * keymap.c (push_key_description):
12310 * search.c (Freplace_match):
12311 * xdisp.c (message_dolog, set_message_1): All callers changed.
12312
f6d62986
SM
123132011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12314
12315 * keyboard.c (safe_run_hook_funcall): New function.
12316 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12317 don't set the hook to nil, but remove the offending function instead.
12318 (Qcommand_hook_internal): Remove, unused.
12319 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12320 Vcommand_hook_internal.
12321
12322 * eval.c (enum run_hooks_condition): Remove.
12323 (funcall_nil, funcall_not): New functions.
12324 (run_hook_with_args): Call each function through a `funcall' argument.
12325 Remove `cond' argument, now redundant.
12326 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12327 (Frun_hook_with_args_until_failure): Adjust accordingly.
12328 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12329
1db5b1ad
JB
123302011-03-28 Juanma Barranquero <lekktu@gmail.com>
12331
12332 * dispextern.h (string_buffer_position): Remove declaration.
12333
12334 * print.c (strout): Remove parameter `multibyte', unused since
12335 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12336
12337 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12338 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12339 All callers changed.
12340
12341 * w32.c (_wsa_errlist): Use braces for struct initializers.
12342
12343 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12344 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12345 All callers changed.
12346 (string_buffer_position): Likewise. Also, make static (it's never
12347 used outside xdisp.c).
12348 (cursor_row_p): Remove parameter `w', unused since
12349 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12350 (decode_mode_spec): Remove parameter `precision', introduced during
12351 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12352 All callers changed.
12353
5ffb62aa
JD
123542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12355
12356 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12357
461c2ab9 123582011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12359
12360 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12361 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12362 (ns_update_auto_hide_menu_bar): New functions.
12363 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12364 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12365 ns_constrain_all_frames.
12366 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12367 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12368
5c380ffb
JD
123692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12370
12371 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12372
9af30bdf
GM
123732011-03-27 Glenn Morris <rgm@gnu.org>
12374
12375 * syssignal.h: Replace RETSIGTYPE with void.
12376 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12377 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12378 Replace SIGTYPE with void everywhere.
12379 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12380 * s/template.h (SIGTYPE): Remove commented out definition.
12381
e2abce01
JB
123822011-03-26 Eli Zaretskii <eliz@gnu.org>
12383
12384 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12385 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12386
f868cd8a
JB
123872011-03-26 Juanma Barranquero <lekktu@gmail.com>
12388
59eb0929
JB
12389 * w32.c (read_unc_volume): Use parameter `henum', instead of
12390 global variable `wget_enum_handle'.
12391
12392 * keymap.c (describe_vector): Remove parameters `indices' and
12393 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12394 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12395
f868cd8a
JB
12396 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12397
12398 * keyboard.c (timer_check): Remove parameter `do_it_now',
12399 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12400 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12401 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12402
12403 * keyboard.c (read_char):
12404 * w32menu.c (w32_menu_display_help):
12405 * xmenu.c (show_help_event, menu_help_callback):
12406 Adjust calls to `show_help_echo'.
12407
12408 * gtkutil.c (xg_maybe_add_timer):
12409 * keyboard.c (readable_events):
12410 * process.c (wait_reading_process_output):
12411 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12412
12413 * insdel.c (adjust_markers_gap_motion):
12414 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12415 (gap_left, gap_right): Don't call it.
12416
2ecf6fdb
CY
124172011-03-25 Chong Yidong <cyd@stupidchicken.com>
12418
12419 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12420 incurred during fontification.
12421
6b1f9ba4
JB
124222011-03-25 Juanma Barranquero <lekktu@gmail.com>
12423
12424 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12425 (DEFVAR_PER_BUFFER): Don't pass it.
12426
12427 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12428 (scrolling_window): Don't pass it.
12429
0f4a96b5
JB
124302011-03-25 Juanma Barranquero <lekktu@gmail.com>
12431
12432 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12433
12434 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12435 and `suffix'.
12436 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12437 of variables specific to SELinux and computation of `encoded_absname'.
12438
12439 * image.c (XPutPixel): Remove unused variable `height'.
12440
12441 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12442
12443 * unexw32.c (get_section_info): Remove unused variable `section'.
12444
12445 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12446 (system_process_attributes): Remove unused variable `sess'.
12447 (sys_read): Remove unused variable `err'.
12448
12449 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12450 (w32_wnd_proc): Remove unused variable `isdead'.
12451 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12452 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12453 (x_create_tip_frame): Remove unused variable `tem'.
12454
12455 * w32inevt.c (w32_console_read_socket):
12456 Remove unused variable `no_events'.
12457
12458 * w32term.c (x_draw_composite_glyph_string_foreground):
12459 Remove unused variable `width'.
12460
1149507c
JB
124612011-03-24 Juanma Barranquero <lekktu@gmail.com>
12462
12463 * w32term.c (x_set_glyph_string_clipping):
12464 Don't pass uninitialized region to CombineRgn.
12465
9c88f339
JB
124662011-03-23 Juanma Barranquero <lekktu@gmail.com>
12467
12468 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12469 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12470 (Fx_close_connection): Remove unused variable `i'.
12471
12472 * w32font.c (w32font_draw): Return number of glyphs.
12473 (w32font_open_internal): Remove unused variable `i'.
12474 (w32font_driver): Add missing initializer.
12475
12476 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12477 (fill_in_menu): Remove unused variable `items_added'.
12478
12479 * w32term.c (last_mouse_press_frame): Remove static global variable.
12480 (w32_clip_to_row): Remove unused variable `f'.
12481 (x_delete_terminal): Remove unused variable `i'.
12482
12483 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12484 (NOTHING): Remove unused static global variable.
12485 (uniscribe_check_otf): Remove unused variable `table'.
12486 (uniscribe_font_driver): Add missing initializers.
12487
dee091a3
JD
124882011-03-23 Julien Danjou <julien@danjou.info>
12489
12490 * term.c (Fsuspend_tty, Fresume_tty):
12491 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12492 * window.c (temp_output_buffer_show):
12493 * insdel.c (signal_before_change):
12494 * frame.c (Fhandle_switch_frame):
12495 * fileio.c (Fdo_auto_save):
12496 * emacs.c (Fkill_emacs):
12497 * editfns.c (save_excursion_restore):
12498 * cmds.c (internal_self_insert):
12499 * callint.c (Fcall_interactively):
12500 * buffer.c (Fkill_all_local_variables):
12501 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12502 Use Frun_hooks.
0f4a96b5 12503 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12504 unconditionally since it does the check itself.
dee091a3 12505
2c520ab5 125062011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12507
c9c49752
PE
12508 Fix more problems found by GCC 4.5.2's static checks.
12509
8abc3f12
PE
12510 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12511 the first time through the loop, since we know p0 < p1 then.
12512 This also avoids a gcc -Wstrict-overflow warning.
12513
a2d26660
PE
12514 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12515 leading to a memory leak, possible in functions like
12516 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12517 of objects (Bug#8318).
a2d26660 12518
916c72e9
PE
12519 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12520 that could (at least in theory) be that large.
12521
19ab8a18
PE
12522 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12523 This is less likely to overflow, and avoids undefined behavior if
12524 overflow does occur. All callers changed. Use strtoul to scan
12525 for the unsigned long integer.
b7cbbd6f
PE
12526 (pint2hrstr): Simplify and tune code slightly.
12527 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12528
f0641eff
PE
12529 * scroll.c (do_scrolling): Work around GCC bug 48228.
12530 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12531
7f650bb9
PE
12532 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12533 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12534 (validate_x_resource_name): Simplify count usage.
12535 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12536
37dd57d1
PE
12537 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12538 fail (Bug#8306).
81e56e61 12539
699979fc 12540 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12541
401bf9b4
PE
12542 * process.c (Fmake_network_process): Use socklen_t, not int,
12543 where POSIX says socklen_t is required in portable programs.
12544 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12545 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12546 (Fmake_network_process, server_accept_connection):
12547 (wait_reading_process_output, read_process_output):
12548 Likewise.
12549
b93aacde
PE
12550 * process.c: Rename or move locals to avoid shadowing.
12551 (list_processes_1, Fmake_network_process):
12552 (read_process_output_error_handler, exec_sentinel_error_handler):
12553 Rename or move locals.
4dc343ee 12554 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12555 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12556 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12557 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12558 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12559
af8a867c 12560 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12561 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12562 Include tparam.h instead, since it declares them.
af8a867c
PE
12563 * cm.h (PC): Remove extern decl; tparam.h now does this.
12564 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12565 * terminfo.c: Include tparam.h, to check interfaces.
12566 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12567 (tparam): Adjust signature to match interface in tparam.h;
12568 this removes some undefined behavior. Check that outstring and len
12569 are zero, which they always are with Emacs.
12570 * tparam.h (PC, BC, UP): New extern decls.
12571
0248044d 12572 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12573 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12574
8ff096c1 12575 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12576 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12577 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12578 (ftfont_list): Remove unused local.
49eaafba
PE
12579 (get_adstyle_property, ftfont_pattern_entity):
12580 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12581 Rename locals to avoid shadowing.
8ff096c1 12582
e2be39f6
PE
12583 * xfont.c (xfont_list_family): Mark var as initialized.
12584
c9735e30
PE
12585 * xml.c (make_dom): Now static.
12586
8f5201ae
PE
12587 * composite.c (composition_compute_stop_pos): Rename local to
12588 avoid shadowing.
b246f932
PE
12589 (composition_reseat_it): Remove unused locals.
12590 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12591 (composition_update_it): Mark var as initialized.
11b61122
PE
12592 (find_automatic_composition): Mark vars as initialized,
12593 with a FIXME (Bug#8290).
8f5201ae 12594
760fbc2c
PE
12595 character.h: Rename locals to avoid shadowing.
12596 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12597 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12598 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12599 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12600 to avoid shadowing.
12601
ff08eb85
PE
12602 * textprop.c (property_change_between_p): Remove; unused.
12603
fc7bf025
PE
12604 * intervals.c (interval_start_pos): Now static.
12605
235d7abc
PE
12606 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12607
44f230aa
SM
12608 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12609 Rename locals to avoid shadowing.
3e7d6594 12610
50060332
PE
12611 * sound.c (wav_play, au_play, Fplay_sound_internal):
12612 Fix pointer signedness.
d01f234b 12613 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12614 (wav_play): Initialize a variable to 0, to prevent undefined
12615 behavior (Bug#8278).
50060332 12616
c4fc4e30
PE
12617 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12618
918436ed
PE
12619 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12620
c939f91b
PE
12621 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12622 clobbering (Bug#8298).
b9c7f648
PE
12623 * sysdep.c (sys_subshell): Likewise.
12624 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12625
6bd8c144
PE
12626 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12627 This should get cleaned up, so that child_setup has the
12628 same signature on all platforms.
12629
7710357c 12630 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12631 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12632
c59da222
CY
126332011-03-22 Chong Yidong <cyd@stupidchicken.com>
12634
12635 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12636 not to be necessary, and produces flickering.
12637
66b87493
GM
126382011-03-20 Glenn Morris <rgm@gnu.org>
12639
12640 * config.in: Remove file.
12641
45b6f6d5
JB
126422011-03-20 Juanma Barranquero <lekktu@gmail.com>
12643
12644 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12645 are now in src/globals.h.
12646 (syms_of_minibuf): Remove spurious & from previous change.
12647
cd394be1 126482011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12649
12650 * minibuf.c (completing-read-function): New variable.
12651 (completing-read-default): Rename from completing-read.
12652 (completing-read): Call completing-read-function.
12653
b14e3e21
CY
126542011-03-19 Juanma Barranquero <lekktu@gmail.com>
12655
12656 * xfaces.c (Fx_load_color_file):
12657 Read color file from absolute filename (bug#8250).
12658
f2b726e6
JB
126592011-03-19 Juanma Barranquero <lekktu@gmail.com>
12660
12661 * makefile.w32-in: Update dependencies.
12662
09f6ff02
EZ
126632011-03-17 Eli Zaretskii <eliz@gnu.org>
12664
12665 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12666
29a6015a
PE
126672011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12668
a3a6c54e
PE
12669 Fix more problems found by GCC 4.5.2's static checks.
12670
b766f867
PE
12671 * process.c (make_serial_process_unwind, send_process_trap):
12672 (sigchld_handler): Now static.
12673
be02381c
PE
12674 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12675 That way, the code declares only the vars that it needs.
12676 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12677 * s/cygwin.h (PTY_ITERATION): Likewise.
12678 * s/darwin.h (PTY_ITERATION): Likewise.
12679 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12680
57048744
PE
12681 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12682 * process.c (allocate_pty): Don't declare stb unless it's needed.
12683
7914961c 12684 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12685 (CONSTANTLIM): Remove; unused.
12686 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12687 Define only if needed.
7914961c 12688
b3967b18
PE
12689 * unexelf.c (unexec): Name an expression,
12690 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12691 Use a different way to cause a compilation error if anyone uses
12692 n rather than nn, a way that does not involve shadowing.
73366a00 12693 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12694
29a6015a
PE
12695 * deps.mk (unexalpha.o): Remove; unused.
12696
43cfc33e 12697 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12698 * unexec.h: New file.
ce701a33
PE
12699 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12700 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12701 Depend on unexec.h.
12702 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12703 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12704 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12705 Change as necessary to match prototype in unexec.h.
ce701a33 12706
01f44d5a
PE
12707 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12708 shadowing.
4f63c6bb 12709 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12710
a6670b0b
PE
12711 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12712 Rename locals to avoid shadowing.
12713
cef2010d 12714 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12715 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12716
d4d7173a
PE
12717 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12718
f08b802a
PE
12719 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12720 warning when compiling print.c.
12721
3ddb0639
PE
12722 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12723 instead of using an uninitialized var.
5ad03b97 12724 (font_sort_entities): Mark var as initialized.
3ddb0639 12725
170a2692
PE
12726 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12727
e663c700
PE
12728 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12729 pointers to constants.
89bc529a 12730 (font_parse_fcname): Remove unused vars.
7b81e2d0 12731 (font_delete_unmatched): Now static.
ea838e10 12732 (font_get_spec): Remove; unused.
13a547c6
PE
12733 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12734 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12735 Rename or move locals to avoid shadowing.
e663c700 12736
2a80c887 12737 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12738 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12739
1384fa33 12740 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12741 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12742
8b2c52e9
PE
12743 * alloc.c (mark_backtrace): Move decl from here ...
12744 * lisp.h: ... to here, so that it can be checked.
12745
475545b5 12746 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12747 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12748 (lisp_indirect_variable): Name an expression,
12749 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12750 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12751
b1349114 12752 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12753 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12754 Use const pointer when appropriate.
b1349114 12755
a2928364
PE
12756 * lisp.h (get_system_name, get_operating_system_release):
12757 Move decls here, to check interfaces.
12758 * process.c (get_operating_system_release): Move decl to lisp.h.
12759 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12760 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12761 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12762 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12763 (Fformat_time_string, Fencode_time, Finsert_char):
12764 (Ftranslate_region_internal, Fformat):
12765 Rename or remove local vars to avoid shadowing.
9710023e 12766 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12767
a415e694
PE
12768 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12769 avoid shadowing.
12770
8ef4622d
PE
12771 * lisp.h (eassert): Check that the argument compiles, even if
12772 ENABLE_CHECKING is not defined.
12773
946f9a5b
PE
12774 * data.c (Findirect_variable): Name an expression, to avoid
12775 gcc -Wbad-function-cast warning.
112396d6 12776 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12777 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12778 (Fmake_variable_buffer_local, Fmake_local_variable):
12779 Mark variables as initialized.
52746918 12780 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12781
e5aab7e7 12782 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12783 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12784 Rename locals to avoid shadowing.
dff45157
PE
12785 (mark_stack): Move local variables into the #ifdef region where
12786 they're used.
7bc26fdb
PE
12787 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12788 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12789 needed otherwise.
12790 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12791 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12792 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12793
e5aab7e7
PE
12794 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12795 avoids undefined behavior in theory.
12796
4da60324
PE
12797 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12798
88043301
PE
12799 Use functions, not macros, for up- and down-casing (Bug#8254).
12800 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12801 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12802 to use the following functions instead of these macros.
12803 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12804 EMACS_INT, since callers assume the returned value fits in int.
12805 (upcase1): Likewise, for UPCASE_TABLE.
12806 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12807 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12808 the race-condition problem in the old DOWNCASE.
88043301 12809
19ed5445
PE
12810 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12811 Rename locals to avoid shadowing.
12812 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12813 (regex_compile, re_search_2, re_match_2_internal):
12814 Remove unused local vars.
952db0d7
PE
12815 (FREE_VAR): Rewrite so as not to use empty "else",
12816 which gcc can warn about.
da053e48 12817 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12818 (RETALLOC_IF): Define only if needed.
12819 (WORDCHAR_P): Likewise. This one is never needed, but is used
12820 only in a comment talking about a compiler bug, so put inside
12821 the #if 0 of that comment.
12822 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12823 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12824 Remove; unused.
19ed5445 12825
1f3561e4 12826 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12827 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12828 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12829
ded6f8f7
PE
12830 * search.c (simple_search): Remove unused var.
12831
dbd37a95
PE
12832 * dired.c (compile_pattern): Move decl from here ...
12833 * lisp.h: ... to here, so that it can be checked.
12834 (struct re_registers): New forward decl.
12835
7e47afad
PE
12836 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12837
85f24f61
PE
12838 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12839 All uses changed.
12840 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12841 Rename locals to avoid shadowing.
5671df8f 12842 (Fvertical_motion): Mark locals as initialized.
85f24f61 12843
181aa2be 12844 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12845 (casify_region): Mark local as initialized.
181aa2be 12846
930d429c
PE
12847 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12848
7082eac6
PE
12849 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12850 New macros, so that the caller can use some names other than
12851 gcpro1, gcpro2, etc.
12852 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12853 of the new macros.
12854 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12855 argument, for consistency with GCPRO2_VAR, etc: it is now the
12856 prefix of the variable, not the variable itself. All uses
12857 changed.
38b2c076
PE
12858 * dired.c (directory_files_internal, file_name_completion):
12859 Rename locals to avoid shadowing.
12860
15206ed9
PE
12861 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12862 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12863 dired.c's scmp function, had undefined behavior.
12864 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12865 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12866 * buffer.h: ... to here, because these macros use current_buffer,
12867 and the new implementation with inline functions needs to have
12868 current_buffer in scope now, rather than later when the macros
12869 are used.
12870 (downcase, upcase1): New static inline functions.
12871 (DOWNCASE, UPCASE1): Reimplement using these functions.
12872 This avoids undefined behavior in expressions like
12873 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12874 from race conditions in accessing the global variables
12875 case_temp1 and case_temp2.
12876 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12877 * lisp.h (case_temp1, case_temp2): Remove their decls.
12878 * character.h (ASCII_CHAR_P): Move from here ...
12879 * lisp.h: ... to here, so that the inline functions mentioned
12880 above can use them.
12881
4a6bea26
PE
12882 * dired.c (directory_files_internal_unwind): Now static.
12883
f14b7e14
PE
12884 * fileio.c (file_name_as_directory, directory_file_name):
12885 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12886 Now static.
2893f146
PE
12887 (file_name_as_directory): Use const pointers when appropriate.
12888 (Fexpand_file_name): Likewise. In particular, newdir might
12889 point at constant storage, so make it a const pointer.
fd4ead52 12890 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12891 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12892 signedness issues.
f839df0c
PE
12893 (Fset_file_times, Finsert_file_contents, auto_save_error):
12894 Rename locals to avoid shadowing.
f14b7e14 12895
5716756e 12896 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12897 (Ftry_completion, Fall_completions): Rename or remove locals
12898 to avoid shadowing.
5716756e 12899
b4c3046a
PE
12900 * marker.c (bytepos_to_charpos): Remove; unused.
12901
b45db522
PE
12902 * lisp.h (verify_bytepos, count_markers): New decls,
12903 so that gcc does not warn that these functions aren't declared.
12904
85876d07
PE
12905 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12906 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12907 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12908 (copy_text): Remove unused local var.
85876d07 12909
03d78a21 12910 * filelock.c (within_one_second): Now static.
b3dd38ab 12911 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12912
5df8f01b
PE
12913 * buffer.c (fix_overlays_before): Mark locals as initialized.
12914 (fix_start_end_in_overlays): Likewise. This function should be
12915 simplified by using pointers-to-pointers, but that's a different
12916 matter.
b1d876f1 12917 (switch_to_buffer_1): Now static.
8f54f30a
PE
12918 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12919 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12920
a70072c9 12921 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12922 Fix pointer signedness issue.
edced198
PE
12923 (sys_subshell): Mark local as volatile if checking for lint,
12924 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12925 (MAXPATHLEN): Define only if needed.
a70072c9 12926
a0977c44
PE
12927 * process.c (serial_open, serial_configure): Move decls from here ...
12928 * systty.h: ... to here, so that they can be checked.
12929
a884fdcc
PE
12930 * fns.c (get_random, seed_random): Move extern decls from here ...
12931 * lisp.h: ... to here, so that they can be checked.
12932
604efe86 12933 * sysdep.c (reset_io): Now static.
b8950c94 12934 (wait_for_termination_signal): Remove; unused.
604efe86 12935
38fc62d9
PE
12936 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12937 (copy_keymap_item, append_key, push_text_char_description):
12938 Now static.
1004a21a 12939 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12940 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12941 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12942 (describe_map_tree):
12943 Rename locals to avoid shadowing.
38fc62d9 12944
2f2650da
PE
12945 * keyboard.c: Declare functions static if they are not used elsewhere.
12946 (echo_char, echo_dash, cmd_error, top_level_2):
12947 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12948 (read_char, kbd_buffer_get_event, make_lispy_position):
12949 (make_lispy_event, make_lispy_movement, apply_modifiers):
12950 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12951 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12952 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12953 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12954 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12955
a053e86c 12956 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12957 (mark_kboards): Move decl here ...
12958 * alloc.c (mark_kboards): ... from here.
a053e86c 12959
4752793e
PE
12960 * lisp.h (force_auto_save_soon): New decl.
12961
74f10ca7 12962 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12963 (DEFINE_DUMMY_FUNCTION): New macro.
12964 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12965 Use it.
c03cd23f
PE
12966 (main): Add casts to avoid warnings
12967 if GCC considers string literals to be constants.
74f10ca7 12968
022e70d4
PE
12969 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12970
59d6fe83
PE
12971 * dbusbind.c: Pointer signedness fixes.
12972 (xd_signature, xd_append_arg, xd_initialize):
12973 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12974 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12975 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12976 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12977
78320123
PE
12978 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12979 if GCC considers string literals to be constants.
49cebcca 12980 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12981
35ac2a97
SM
129822011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12983
fb103ca9
SM
12984 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12985 (print_preprocess, print_object): New macro to fix last change.
12986
35ac2a97
SM
12987 * print.c (print_preprocess): Don't forget font objects.
12988
62973b41
JB
129892011-03-16 Juanma Barranquero <lekktu@gmail.com>
12990
12991 * emacs.c (USAGE3): Doc fixes.
12992
0e48bb22
AS
129932011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12994
12995 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12996 structure.
12997
7684e57b
JB
129982011-03-14 Juanma Barranquero <lekktu@gmail.com>
12999
13000 * lisp.h (VWindow_system, Qfile_name_history):
13001 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13002 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13003 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13004
13005 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13006 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13007
13008 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13009 * w32console.c (detect_input_pending, read_input_pending)
13010 (encode_terminal_code):
13011 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13012 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13013 (w32_system_caret_y, Qfile_name_history):
13014 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13015 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13016 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13017 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13018 * w32proc.c (Qlocal, report_file_error):
13019 * w32term.c (Vwindow_system, updating_frame):
13020 * w32uniscribe.c (initialized, uniscribe_font_driver):
13021 Remove unneeded extern declarations.
13022
2aa46d6c
CY
130232011-03-14 Chong Yidong <cyd@stupidchicken.com>
13024
c96bbc66 13025 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13026
cffc6f3b
CY
130272011-03-13 Chong Yidong <cyd@stupidchicken.com>
13028
13029 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13030 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13031 These macros can no longer be used for assignment.
13032
44f230aa
SM
13033 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13034 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13035 (record_buffer_markers, fetch_buffer_markers): New functions for
13036 recording and fetching special buffer markers.
13037 (set_buffer_internal_1, set_buffer_temp): Use them.
13038
13039 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13040
13041 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13042
13043 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13044 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13045
13046 * xdisp.c (hscroll_window_tree):
13047 (reconsider_clip_changes): Use PT instead of BUF_PT.
13048
d251f04b
EZ
130492011-03-13 Eli Zaretskii <eliz@gnu.org>
13050
13051 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13052 $(EMACS_ROOT)/lib/intprops.h.
13053
f0c77cd1
PE
130542011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13055
3eca4629
PE
13056 Fix more problems found by GCC 4.5.2's static checks.
13057
7c86ee98
PE
13058 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13059 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13060 (xg_free_frame_widgets): Make it clear that a local variable is
13061 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13062 (gdk_window_get_screen): Make it clear that this macro is needed
13063 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13064 (int_gtk_range_get_value): New function, which avoids a diagnostic
13065 from gcc -Wbad-function-cast.
13066 (xg_set_toolkit_scroll_bar_thumb): Use it.
13067 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13068 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13069 (get_utf8_string, xg_get_file_with_chooser):
13070 Rename locals to avoid shadowing.
13071 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13072
41729b81
PE
13073 * xgselect.c (xg_select): Remove unused var.
13074
f0c77cd1
PE
13075 * image.c (four_corners_best): Mark locals as initialized.
13076 (gif_load): Initialize transparent_p to zero (Bug#8238).
13077 Mark another local as initialized.
ec6cf4c6 13078 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13079
ce0ad53d 13080 * image.c (clear_image_cache): Now static.
d5d5a617 13081 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13082 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13083 (x_edge_detection): Remove unnecessary cast that
13084 gcc -Wbad-function-cast diagnoses.
2037898d 13085 (gif_load): Fix pointer signedness.
6ae141d6
PE
13086 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13087 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13088
33383987 130892011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13090
d32df629
PE
13091 Improve quality of tests for time stamp overflow.
13092 For example, without this patch (encode-time 0 0 0 1 1
13093 1152921504606846976) returns the obviously-bogus value (-948597
13094 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13095 reports time overflow. See
13096 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13097 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13098 * editfns.c: Include limits.h and intprops.h.
13099 (TIME_T_MIN, TIME_T_MAX): New macros.
13100 (time_overflow): Move earlier, to before first use.
13101 (hi_time, lo_time): New functions, for an accurate test for
13102 out-of-range times.
13103 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13104 (Fget_internal_run_time): Don't assume time_t fits in int.
13105 (make_time): Use list2 instead of Fcons twice.
13106 (Fdecode_time): More accurate test for out-of-range times.
13107 (check_tm_member): New function.
13108 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13109 (lisp_time_argument): Don't rely on undefined left-shift and
13110 right-shift behavior when checking for time stamp overflow.
8be6f318 13111
fe31d94c
PE
13112 * editfns.c (time_overflow): New function, refactoring common code.
13113 (Fformat_time_string, Fdecode_time, Fencode_time):
13114 (Fcurrent_time_string): Use it.
13115
8be6f318
PE
13116 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13117 * dired.c (make_time): Move to ...
13118 * editfns.c (make_time): ... here.
13119 * systime.h: Note the move.
13120
09d9db2c 131212011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13122
126bc0dc
YM
13123 * fringe.c (update_window_fringes): Remove unused variables.
13124
c47cbdfd
YM
13125 * unexmacosx.c (copy_data_segment): Also copy __got section.
13126 (Bug#8223)
13127
7ac80be9
EZ
131282011-03-12 Eli Zaretskii <eliz@gnu.org>
13129
c96bbc66 13130 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13131 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13132 Constify `char *' arguments and their references according to
13133 prototypes in tparam.h.
13134
ecb0f94d 13135 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13136
7ac80be9
EZ
13137 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13138 Adapt all references accordingly.
13139
13140 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13141
ef1fd07e
TT
131422011-03-11 Tom Tromey <tromey@redhat.com>
13143
13144 * buffer.c (syms_of_buffer): Remove obsolete comment.
13145
7ef4b50c
EZ
131462011-03-11 Eli Zaretskii <eliz@gnu.org>
13147
13148 * termhooks.h (encode_terminal_code): Declare prototype.
13149
13150 * msdos.c (encode_terminal_code): Don't declare prototype.
13151
13152 * term.c (encode_terminal_code): Now external again, used by
13153 w32console.c and msdos.c.
13154
44f230aa
SM
13155 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13156 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13157
4b1ec863 131582011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13159
1714f52b 13160 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13161
4b1ec863
PE
13162 * fringe.c (update_window_fringes): Mark locals as initialized
13163 (Bug#8227).
13164 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13165
524c7aa6
PE
13166 * alloc.c (mark_fringe_data): Move decl from here ...
13167 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13168 to check its interface.
13169 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13170
a5c0af81 13171 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13172 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13173 (fontset_font): Mark local as initialized.
a9a06e0b 13174 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13175
b4716021
PE
13176 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13177
811e9bac 13178 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13179 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13180 (x_own_selection, Fx_disown_selection_internal): Rename locals
13181 to avoid shadowing.
13182 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13183
7e3ab302
PE
13184 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13185 so that the caller can use some name other than gcpro1.
13186 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13187 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13188 (Fx_backspace_delete_keys_p):
13189 Use them to avoid shadowing, and rename vars to avoid shadowing.
13190 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13191 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13192 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13193 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13194 Remove unused locals.
7e3ab302
PE
13195 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13196 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13197 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13198 macros.
f78faa98 13199
e2b13473
PE
13200 * xterm.h (x_mouse_leave): New decl.
13201
77f23912
PE
13202 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13203 Remove unused functions.
cdf4ba58
PE
13204 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13205 (x_calc_absolute_position): Now static.
7411c686 13206 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13207 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13208 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13209 unless they are used.
38d0b34a
PE
13210 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13211 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13212 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13213 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13214 (x_error_catcher, x_connection_closed, x_error_handler):
13215 (x_error_quitter, xembed_send_message, x_iconify_frame):
13216 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13217 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13218 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13219
44f230aa
SM
13220 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13221 Rename or move locals to avoid shadowing.
6b463e58 13222 (tty_defined_color, merge_face_heights): Now static.
5967d051 13223 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13224 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13225 does not deduce is never used uninitialized.
73719eba
PE
13226 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13227 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13228
426994c3 13229 * terminal.c (store_terminal_param): Now static.
5489860b 13230
032f1620 13231 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13232 (set_frame_menubar): Remove unused local.
d4323972 13233 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13234 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13235 since they might point to immutable storage.
281585b0
PE
13236 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13237 since it's unused otherwise.
032f1620 13238
367c19e5 13239 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13240 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13241 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13242 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13243 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13244 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13245 does not deduce are never used uninitialized.
70739cbe 13246
07b48fa9
PE
13247 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13248
8868a238 13249 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13250 * window.c (window_loop, size_window):
13251 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13252
7e5cf297 13253 * window.c (display_buffer): Now static.
d6550a9f
PE
13254 (size_window): Mark variables that gcc -Wuninitialized
13255 does not deduce are never used uninitialized.
a586633d
PE
13256 * window.h (check_all_windows): New decl, to forestall
13257 gcc -Wmissing-prototypes diagnostic.
5b555da1 13258 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13259
f6095868
PE
13260 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13261 shadowing.
13262 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13263 Include <limits.h>.
13264 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13265 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13266 (load_charset_map): Mark variables that gcc -Wuninitialized
13267 does not deduce are never used uninitialized.
53df7c11 13268 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13269
f38b440c
PE
13270 * coding.c (coding_set_source, coding_set_destination):
13271 Use "else { /* comment */ }" rather than "else /* comment */;"
13272 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13273 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13274 a block, when the outer 'i' will do.
13275 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13276 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13277 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13278 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13279 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13280 Rename locals to avoid shadowing.
13281 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13282 * coding.c (emacs_mule_char, encode_invocation_designation):
13283 Now static, since they're not used elsewhere.
413bb2db 13284 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13285 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13286 (decode_coding_emacs_mule): Mark variables that gcc
13287 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13288 (detect_coding_iso_2022): Initialize a local variable that might
13289 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13290 this initialization is needed. (Bug#8211)
5f58e762
PE
13291 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13292 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13293 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13294 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13295 Remove unused macros.
f38b440c 13296
232b38b9 13297 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13298 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13299 * character.c (string_count_byte8): Likewise.
232b38b9 13300
fb90da1b
PE
13301 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13302 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13303
fb93dbc2
PE
13304 * chartab.c (copy_sub_char_table): Now static, since it's not used
13305 elsewhere.
5c156ace
PE
13306 (sub_char_table_ref_and_range, char_table_ref_and_range):
13307 Rename locals to avoid shadowing.
bbcd0949 13308 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13309
7d3b3862 13310 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13311 (BIDI_BOB): Remove unused macro.
7d3b3862 13312
6be7d3da
PE
13313 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13314 deduce are never used uninitialized.
c2ed9c8b 13315 * term.c (encode_terminal_code): Likewise.
6be7d3da 13316
75f8807f 13317 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13318
50938595
PE
13319 * tparam.h: New file.
13320 * term.c, tparam.h: Include it.
13321 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13322 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13323 Move these decls to tparam.h, and make them agree with what
13324 is actually in tparam.c. The previous trick of using incompatible
13325 decls in different modules does not conform to the C standard.
13326 All callers of tparam changed to use tparam's actual API.
13327 * tparam.c (tparam1, tparam, tgoto):
13328 Use const pointers where appropriate.
13329
fbceeba2
PE
13330 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13331 * cm.h (struct cm): Likewise.
13332 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13333 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13334 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13335 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13336 (turn_on_face, init_tty): Likewise.
13337 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13338
7f3f1250
PE
13339 * term.c (term_mouse_position): Rename local to avoid shadowing.
13340
e6ca6543
PE
13341 * alloc.c (mark_ttys): Move decl from here ...
13342 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13343
c40f8d15
AS
133442011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13345
13346 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13347
cfe0661d
JB
133482011-03-09 Juanma Barranquero <lekktu@gmail.com>
13349
13350 * search.c (compile_pattern_1): Remove argument regp, unused since
13351 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13352 (compile_pattern): Don't pass it.
13353
0afb4571
J
133542011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13355
13356 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13357 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13358 for ! HAVE_GTK3.
13359 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13360
13361 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13362
13363 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13364 gdk_window_get_screen, gdk_window_get_geometry,
13365 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13366 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13367 (xg_get_pixbuf_from_pixmap): New function.
13368 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13369 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13370 Call xg_get_pixbuf_from_pixmap instead of
13371 gdk_pixbuf_get_from_drawable.
13372 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13373 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13374 (xg_check_special_colors): Use GtkStyleContext and its functions
13375 for HAVE_GTK3.
13376 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13377 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13378 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13379 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13380 Call gtk_widget_get_preferred_size.
0afb4571
J
13381 (xg_frame_resized): gdk_window_get_geometry only takes 5
13382 parameters.
44f230aa
SM
13383 (xg_win_to_widget, xg_event_is_for_menubar):
13384 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13385 (xg_set_widget_bg): New function.
13386 (delete_cb): New function.
895009e1 13387 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13388 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13389 (xg_set_background_color): Call xg_set_widget_bg.
13390 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13391 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13392 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13393 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13394 if ! HAVE_GTK3.
13395 (update_frame_tool_bar): Call gtk_widget_hide.
13396 (xg_initialize): Use GDK_KEY_g.
13397
13398 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13399 if ! HAVE_GTK3
13400 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13401
13402 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13403 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13404 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13405
1c2cc4ef
JB
134062011-03-08 Juanma Barranquero <lekktu@gmail.com>
13407
13408 * w32xfns.c (select_palette): Check success of RealizePalette against
13409 GDI_ERROR, not zero.
13410
33383987 13411See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13412
13413;; Local Variables:
13414;; coding: utf-8
aac0c6e3
MR
13415;; End:
13416
2f097256 13417 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13418
13419 This file is part of GNU Emacs.
13420
13421 GNU Emacs is free software: you can redistribute it and/or modify
13422 it under the terms of the GNU General Public License as published by
13423 the Free Software Foundation, either version 3 of the License, or
13424 (at your option) any later version.
13425
13426 GNU Emacs is distributed in the hope that it will be useful,
13427 but WITHOUT ANY WARRANTY; without even the implied warranty of
13428 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13429 GNU General Public License for more details.
13430
13431 You should have received a copy of the GNU General Public License
13432 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.