Commit | Line | Data |
---|---|---|
6c60eb9f SM |
1 | 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca> |
2 | ||
3 | * process.c (Qprocessp): Don't declare static. | |
4 | * lisp.h (Qprocessp): Declare again. | |
5 | ||
7990b61a JB |
6 | 2011-04-15 Juanma Barranquero <lekktu@gmail.com> |
7 | ||
8 | * font.c (Qopentype): Don't make static (used from w32uniscribe.c). | |
9 | ||
5d4cb038 PE |
10 | 2011-04-14 Paul Eggert <eggert@cs.ucla.edu> |
11 | ||
8bd7b830 | 12 | Improve C-level modularity by making more things 'static'. |
cd64ea1d | 13 | |
e3b27b31 PE |
14 | Don't publish debugger-only interfaces to other modules. |
15 | * lisp.h (safe_debug_print, debug_output_compilation_hack): | |
16 | (verify_bytepos, count_markers): Move decls to the only modules | |
17 | that need them. | |
18 | * region-cache.h (pp_cache): Likewise. | |
19 | * window.h (check_all_windows): Likewise. | |
20 | * marker.c, print.c, region-cache.c, window.c: Decls moved here. | |
21 | ||
5d4cb038 PE |
22 | * sysdep.c (croak): Now static, if |
23 | defined TIOCNOTTY || defined USG5 || defined CYGWIN. | |
24 | * syssignal.h (croak): Declare only if not static. | |
69003fd8 PE |
25 | |
26 | * alloc.c (refill_memory_reserve): Now static if | |
27 | !defined REL_ALLOC || defined SYSTEM_MALLOC. | |
28 | * lisp.h (refill_memory_reserve): Declare only if not static. | |
93ea6e8f | 29 | |
e87b6180 PE |
30 | * xsettings.c, xsettings.h (xsettings_get_system_normal_font): |
31 | Define only if USE_LUCID. | |
32 | ||
ac64929e PE |
33 | * xrdb.c (x_customization_string, x_rm_string): Now static. |
34 | ||
6f37259d PE |
35 | * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF. |
36 | * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF. | |
37 | ||
1683e3ab PE |
38 | * xdisp.c (draw_row_with_mouse_face): Now static. |
39 | * dispextern.h (draw_row_with_mouse_fave): Remove decl. | |
40 | ||
de9c2632 PE |
41 | * window.h (check_all_windows): Mark externally visible. |
42 | ||
2b96acb7 PE |
43 | * window.c (window_deletion_count): Now static. |
44 | ||
45 | * undo.c: Make symbols static if they're not exported. | |
46 | (last_undo_buffer, last_boundary_position, pending_boundary): | |
47 | Now static. | |
48 | ||
50436f33 PE |
49 | * textprop.c (interval_insert_behind_hooks): Now static. |
50 | (interval_insert_in_front_hooks): Likewise. | |
51 | ||
64520e5c PE |
52 | * term.c: Make symbols static if they're not exported. |
53 | (tty_turn_off_highlight, get_tty_terminal, max_frame_cols): | |
54 | (max_frame_lines, tty_set_terminal_modes): | |
55 | (tty_reset_terminal_modes, tty_turn_off_highlight): | |
56 | (get_tty_terminal): Now static. | |
57 | (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM. | |
58 | * termhooks.h (term_mouse_moveto): Do not declare if | |
8bd7b830 | 59 | HAVE_WINDOW_SYSTEM. |
64520e5c PE |
60 | * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes): |
61 | (tty_turn_off_highlight, get_tty_terminal): Remove decls. | |
62 | ||
1fa53021 PE |
63 | * sysdep.c: Make symbols static if they're not exported. |
64 | (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner): | |
65 | Now static. | |
66 | (sigprocmask_set, full_mask): Remove; unused. | |
67 | (wait_debugging): Mark as visible. | |
68 | * syssignal.h (SIGFULLMASK, full_mask): Remove decls. | |
69 | * systty.h (emacs_get_tty, emacs_set_tty): Remove decls. | |
70 | ||
d4b43b22 PE |
71 | * syntax.c (syntax_temp): Define only if !__GNUC__. |
72 | ||
b7c513d0 PE |
73 | * sound.c (current_sound_device, current_sound): Now static. |
74 | ||
989b29ad PE |
75 | * search.c (searchbufs, searchbuf_head): Now static. |
76 | ||
13a55a78 PE |
77 | * scroll.c (scroll_cost): Remove; unused. |
78 | * dispextern.h (scroll_cost): Remove decl. | |
79 | ||
de68a1fc PE |
80 | * region-cache.h (pp_cache): Mark as externally visible. |
81 | ||
40ccffa6 PE |
82 | * process.c: Make symbols static if they're not exported. |
83 | (process_tick, update_tick, create_process, chan_process): | |
84 | (Vprocess_alist, proc_buffered_char, datagram_access): | |
85 | (fd_callback_data, send_process_frame, process_sent_to): Now static. | |
86 | (deactivate_process): Mark defn as static, as well as decl. | |
87 | * lisp.h (create_process): Remove decl. | |
88 | * process.h (chan_process, Vprocess_alist): Remove decls. | |
89 | ||
ad64fc97 PE |
90 | * print.c: Make symbols static if they're not exported. |
91 | (print_depth, new_backquote_output, being_printed, print_buffer): | |
92 | (print_buffer_size, print_buffer_pos, print_buffer_pos_byte): | |
93 | (print_interval, print_number_index, initial_stderr_stream): | |
94 | Now static. | |
95 | * lisp.h (Fprinc): Remove decl. | |
96 | (debug_output_compilation_hack): Mark as externally visible. | |
97 | ||
adddb265 PE |
98 | * sysdep.c (croak): Move decl from here to syssignal.h. |
99 | * syssignal.h (croak): Put it here, so the API can be checked when | |
100 | 'croak' is called from dissociate_if_controlling_tty. | |
101 | ||
1717ede2 PE |
102 | * minibuf.c: Make symbols static if they're not exported. |
103 | (minibuf_save_list, choose_minibuf_frame): Now static. | |
104 | * lisp.h (choose_minibuf_frame): Remove decl. | |
105 | ||
fa5fb2bc PE |
106 | * lisp.h (verify_bytepos, count_markers): Mark as externally visible. |
107 | ||
1e3890d1 PE |
108 | * lread.c: Make symbols static if they're not exported. |
109 | (read_objects, initial_obarray, oblookup_last_bucket_number): | |
110 | Now static. | |
111 | (make_symbol): Remove; unused. | |
112 | * lisp.h (initial_obarray, make_symbol): Remove decls. | |
113 | ||
8a1414fa PE |
114 | * keyboard.c: Make symbols static if they're not exported. |
115 | (single_kboard, recent_keys_index, total_keys, recent_keys): | |
116 | (this_command_key_count_reset, raw_keybuf, raw_keybuf_count): | |
117 | (this_single_command_key_start, echoing, last_auto_save): | |
118 | (read_key_sequence_cmd, dribble, recursive_edit_unwind): | |
119 | (command_loop, echo_now, keyboard_init_hook, help_char_p): | |
120 | (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer): | |
121 | (Vlispy_mouse_stem, double_click_count): | |
122 | Now static. | |
123 | (force_auto_save_soon): Define only if SIGDANGER. | |
124 | (ignore_mouse_drag_p): Now static if | |
125 | !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS. | |
126 | (print_help): Remove; unused. | |
127 | (stop_character, last_timer_event): Mark as externally visible. | |
128 | * keyboard.h (ignore_mouse_drag_p): Declare only if | |
129 | defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS. | |
130 | (echo_now, help_char_p, quit_throw_to_read_char): Remove decls. | |
131 | * lisp.h (echoing): Remove decl. | |
132 | (force_auto_save_soon): Declare only if SIGDANGER. | |
133 | * xdisp.c (redisplay_window): Simplify code, to make it more | |
134 | obvious that ignore_mouse_drag_p is not accessed if !defined | |
135 | USE_GTK && !defined HAVE_NS. | |
136 | ||
93ea6e8f PE |
137 | * intervals.c: Make symbols static if they're not exported. |
138 | (merge_properties_sticky, merge_interval_right, delete_interval): | |
139 | Now static. | |
140 | * intervals.h (merge_interval_right, delete_interval): Remove decls. | |
141 | ||
77382fcc PE |
142 | * insdel.c: Make symbols static if they're not exported. |
143 | However, leave prepare_to_modify_buffer alone. It's never | |
144 | called from outside this function, but that appears to be a bug. | |
145 | (combine_after_change_list, combine_after_change_buffer): | |
4889fc82 | 146 | (adjust_after_replace, signal_before_change): Now static. |
77382fcc PE |
147 | (adjust_after_replace_noundo): Remove; unused. |
148 | * lisp.h (adjust_after_replace, adjust_after_replace_noundo): | |
4889fc82 | 149 | (signal_before_change): Remove decls. |
77382fcc | 150 | |
9306c32e PE |
151 | * indent.c (val_compute_motion, val_vmotion): Now static. |
152 | ||
cd44d2eb PE |
153 | * image.c: Make symbols static if they're not exported. |
154 | * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare | |
155 | if USE_GTK. | |
156 | * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK. | |
157 | (xpm_color_cache, ct_table, ct_colors_allocated): Now static. | |
158 | ||
ad9a7a06 PE |
159 | * fringe.c (standard_bitmaps): Now static. |
160 | (max_used_fringe_bitmap): Now static, unless HAVE_NS. | |
161 | ||
81626931 PE |
162 | * frame.c: Make symbols static if they're not exported. |
163 | (x_report_frame_params, make_terminal_frame): Now static. | |
164 | (get_frame_param): Now static, unless HAVE_NS. | |
165 | (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM. | |
166 | (x_get_resource_string): Remove; not used. | |
167 | * frame.h (make_terminal_frame, x_report_frame_params): | |
168 | (x_get_resource_string); Remove decls. | |
169 | (x_fullscreen_adjust): Declare only if WINDOWSNT. | |
170 | * lisp.h (get_frame_param): Declare only if HAVE_NS. | |
171 | ||
239f9db9 PE |
172 | * font.c, fontset.c: Make symbols static if they're not exported. |
173 | * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro. | |
174 | (FACE_SUITABLE_FOR_CHAR_P): Use it. | |
175 | * font.c (font_close_object): Now static. | |
176 | * font.h (font_close_object): Remove. | |
177 | * fontset.c (FONTSET_OBJLIST): Remove. | |
178 | (free_realized_fontset) #if-0 the body, which does nothing. | |
179 | (face_suitable_for_char_p): #if-0, as it's never called. | |
180 | * fontset.h (face_suitable_for_char_p): Remove decl. | |
181 | * xfaces.c (face_at_string_position): Use | |
182 | FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P, | |
183 | since 0 is always ASCII. | |
184 | ||
dfcf3579 PE |
185 | * fns.c (weak_hash_tables): Now static. |
186 | ||
5045092b PE |
187 | * fileio.c: Make symbols static if they're not exported. |
188 | (auto_saving, auto_save_mode_bits, auto_save_error_occurred): | |
189 | (Vwrite_region_annotation_buffers): Now static. | |
190 | ||
57a96f5c PE |
191 | * eval.c: Make symbols static if they're not exported. |
192 | (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static. | |
193 | * lisp.h (backtrace_list): Remove decl. | |
194 | ||
35f08c38 PE |
195 | * emacs.c: Make symbols static if they're not exported. |
196 | (malloc_state_ptr, malloc_using_checking, syms_of_emacs): | |
197 | (fatal_error_code, fatal_error_signal_hook, standard_args): | |
198 | Now static. | |
199 | (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL. | |
200 | (DEFINE_DUMMY_FUNCTION): Mark function as externally visible. | |
201 | (__CTOR_LIST__, __DTOR_LIST__): Now externally visible. | |
202 | * lisp.h (fatal_error_signal_hook): Remove decl. | |
203 | (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL. | |
204 | ||
f44bd759 PE |
205 | * editfns.c: Move a (normally-unused) function to its only use. |
206 | * editfns.c, lisp.h (get_operating_system_release): Remove. | |
207 | * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not | |
208 | worth the hassle of breaking this out. | |
209 | ||
b532497d PE |
210 | * xterm.c: Make symbols static if they're not exported. |
211 | (x_raise_frame, x_lower_frame, x_wm_set_window_state): | |
212 | (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error): | |
213 | (x_destroy_window, x_delete_display): | |
214 | Now static. | |
215 | (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT). | |
216 | (x_mouse_leave): Remove; unused. | |
217 | * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame): | |
218 | (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap): | |
219 | (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes): | |
220 | Remove decls. | |
221 | (x_mouse_leave): Declare only if WINDOWSNT. | |
222 | (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT. | |
223 | (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS && | |
224 | USE_X_TOOLKIT. | |
225 | ||
1675728f PE |
226 | * ftxfont.c: Make symbols static if they're not exported. |
227 | (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined | |
228 | HAVE_FREETYPE. | |
229 | * font.h (ftxfont_driver): Likewise. | |
230 | ||
e4cebfca PE |
231 | * xfns.c: Make symbols static if they're not exported. |
232 | (x_last_font_name, x_display_info_for_name): | |
233 | (x_set_foreground_color, x_set_background_color, x_set_mouse_color): | |
234 | (x_set_cursor_color, x_set_border_pixel, x_set_border_color): | |
235 | (x_set_cursor_type, x_set_icon_type, x_set_icon_name): | |
236 | (x_set_scroll_bar_foreground, x_set_scroll_bar_background): | |
237 | (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer): | |
238 | (last_show_tip_args): Now static. | |
239 | (xic_defaut_fontset, xic_create_fontsetname): Define only if | |
240 | defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT | |
241 | (x_screen_planes): Remove; unused. | |
242 | * dispextern.h (x_screen_planes): Remove decl. | |
243 | ||
5bf46f05 PE |
244 | * dispnew.c: Make symbols static if they're not exported. |
245 | * dispextern.h (redraw_garbaged_frames, scrolling): | |
246 | (increment_row_positions): Remove. | |
247 | * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling): | |
248 | (delayed_size_change, glyph_matrix_count, glyph_pool_count): | |
249 | Now static. | |
250 | (redraw_garbaged_frames): Remove; unused. | |
251 | ||
435f4c28 PE |
252 | * xfaces.c: Make symbols static if they're not exported. |
253 | * dispextern.h (ascii_face_of_lisp_face, free_realized_face): | |
254 | Remove decls. | |
255 | * xterm.h (defined_color): Remove decls. | |
256 | (x_free_dpy_colors): Declare only if USE_X_TOOLKIT. | |
257 | * xfaces.c (tty_suppress_bold_inverse_default_colors_p): | |
258 | (menu_face_changed_default, defined_color, free_realized_face): | |
259 | (x_free_dpy_colors): Define only if USE_X_TOOLKIT. | |
260 | (ascii_face_of_lisp_face): Remove; unused. | |
261 | ||
8524aef3 PE |
262 | * xdisp.c: Make symbols static if they're not exported. |
263 | * dispextern.h (scratch_glyph_row, window_box_edges): | |
264 | (glyph_to_pixel_coords, set_cursor_from_row): | |
265 | (get_next_display_element, set_iterator_to_next): | |
266 | (highlight_trailing_whitespace, frame_to_window_pixel_xy): | |
267 | (show_mouse_face): Remove decls | |
268 | * frame.h (message_buf_print): Likewise. | |
269 | * lisp.h (pop_message, set_message, check_point_in_composition): | |
270 | Likewise. | |
271 | * xterm.h (set_vertical_scroll_bar): Likewise. | |
272 | * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed): | |
273 | (message_buf_print, scratch_glyph_row, displayed_buffer): | |
274 | (set_iterator_to_next, pop_message, set_message, set_cursor_from_row): | |
275 | (get_next_display_element, show_mouse_face, window_box_edges): | |
276 | (frame_to_window_pixel_xy, check_point_in_composition): | |
277 | (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static. | |
278 | (glyph_to_pixel_coords): Remove; unused. | |
279 | ||
16390cd2 PE |
280 | * dired.c (file_name_completion): Now static. |
281 | ||
282 | * dbusbind.c (xd_in_read_queued_messages): Now static. | |
283 | ||
a25f4dfa PE |
284 | * lisp.h (circular_list_error, FOREACH): Remove; unused. |
285 | * data.c (circular_list_error): Remove. | |
286 | ||
14a9c8df PE |
287 | * commands.h (last_point_position, last_point_position_buffer): |
288 | (last_point_position_window): Remove decls. | |
289 | * keyboard.c: Make these variables static. | |
290 | ||
74ab6df5 PE |
291 | * coding.h (coding, code_convert_region, encode_coding_gap): Remove |
292 | decls. | |
293 | * coding.c (Vsjis_coding_system, Vbig5_coding_system): | |
294 | (iso_code_class, detect_coding, code_convert_region): Now static. | |
295 | (encode_coding_gap): Remove; unused. | |
296 | ||
38dfbee1 PE |
297 | * chartab.c (chartab_chars, chartab_bits): Now static. |
298 | ||
a2cb4e63 PE |
299 | * charset.h (charset_iso_8859_1): Remove decl. |
300 | * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump): | |
301 | Now static. | |
302 | ||
127198fd PE |
303 | * ccl.h (check_ccl_update, Vccl_program_table): Remove decls. |
304 | * ccl.c (Vccl_program_table): Now static. | |
305 | (check_ccl_update): Remove; unused. | |
306 | ||
d85b608f PE |
307 | * category.c (SET_CATEGORY_SET, set_category_set): Move here. |
308 | * category.h: ... from here. | |
309 | * category.c (check_category_table, set_category_set): Now static. | |
310 | ||
31cd66f3 PE |
311 | * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static. |
312 | * lisp.h: Remove these decls. | |
313 | ||
c358e587 PE |
314 | * buffer.c (buffer_count): Remove unused var. |
315 | ||
e78aecca PE |
316 | * bidi.c (bidi_dump_cached_states): Mark as externally visible, |
317 | so that it's not optimized away. | |
318 | (bidi_ignore_explicit_marks_for_paragraph_level): Likewise. | |
319 | * dispextern.h (bidi_dump_cached_states): Remove, since it's | |
320 | exported only to the debugger. | |
321 | ||
e192d7d3 PE |
322 | * atimer.c (alarm_signal_handler, run_all_atimers): Now static. |
323 | * atimer.h (run_all_atimers): Removed; not exported. | |
324 | ||
92470028 PE |
325 | font.c: Make copy_font_spec and merge_font_spec ordinary C functions. |
326 | * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it | |
327 | was inaccessible from Lisp. | |
328 | (merge_font_spec): Likewise, renaming from Fmerge_font_spec. | |
329 | * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses. | |
330 | ||
244ed907 PE |
331 | alloc.c: Import and export fewer symbols, and remove unused items. |
332 | * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING | |
333 | is defined. | |
334 | (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that | |
335 | it's not optimized away by whole-program optimization. | |
336 | (message_enable_multibyte, free_misc): Remove. | |
337 | (catchlist, handlerlist, mark_backtrace): | |
338 | Declare only if BYTE_MARK_STACK. | |
339 | (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo. | |
340 | * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined. | |
341 | (message_enable_multibyte): Remove decl. | |
342 | (free_misc, interval_free_list, float_block, float_block_index): | |
343 | (n_float_blocks, float_free_list, cons_block, cons_block_index): | |
344 | (cons_free_list, last_marked_index): | |
345 | Now static. | |
346 | (suppress_checking, die): Define only if ENABLE_CHECKING is defined. | |
347 | * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK. | |
348 | (mark_backtrace): Define only if BYTE_MARK_STACK. | |
349 | * xdisp.c (message_enable_multibyte): Now static. | |
350 | ||
955cbe7b PE |
351 | Declare Lisp_Object Q* variables to be 'static' if not exproted. |
352 | This makes it easier for human readers (and static analyzers) | |
353 | to see whether these variables are used from other modules. | |
354 | * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c: | |
355 | * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c: | |
356 | * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c: | |
357 | * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c: | |
358 | * lread.c, macros.c, minibuf.c, print.c, process.c, search.c: | |
359 | * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c: | |
360 | * xmenu.c, xselect.c: | |
361 | Declare Q* vars static if they are not used in other modules. | |
362 | * ccl.h, character.h, charset.h, coding.h, composite.h, font.h: | |
363 | * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h: | |
364 | Remove decls of unexported vars. | |
365 | * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro. | |
366 | ||
95c82688 PE |
367 | * lisp.h (DEFINE_FUNC): Make sname 'static'. |
368 | ||
16a97296 PE |
369 | Make Emacs functions such as Fatom 'static' by default. |
370 | This makes it easier for human readers (and static analyzers) | |
371 | to see whether these functions can be called from other modules. | |
372 | DEFUN now defines a static function. To make the function external | |
373 | so that it can be used in other C modules, use the new macro DEFUE. | |
8bd7b830 PE |
374 | * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p): |
375 | (Finit_image_library): | |
16a97296 PE |
376 | (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer): |
377 | (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute): | |
378 | (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes): | |
379 | Remove decls, since these functions are now static. | |
380 | (Funintern, Fget_internal_run_time): New decls, since these functions | |
381 | were already external. | |
95c82688 | 382 | |
16a97296 PE |
383 | * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c: |
384 | * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c: | |
385 | * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c: | |
386 | * fns.c, font.c, fontset.c, frame.c, image.c, indent.c: | |
387 | * keyboard.c, keymap.c, lread.c: | |
388 | * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c: | |
389 | * syntax.c, term.c, terminal.c, textprop.c, undo.c: | |
390 | * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c: | |
391 | Mark functions with DEFUE instead of DEFUN, | |
392 | if they are used in other modules. | |
393 | * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward | |
394 | decls for now-static functions. | |
395 | * buffer.h (Fdelete_overlay): Remove decl. | |
396 | * callproc.c (Fgetenv_internal): Mark as internal. | |
397 | * composite.c (Fremove_list_of_text_properties): Remove decl. | |
398 | (Fcomposition_get_gstring): New forward static decl. | |
399 | * composite.h (Fcomposite_get_gstring): Remove decl. | |
400 | * dired.c (Ffile_attributes): New forward static decl. | |
401 | * doc.c (Fdocumntation_property): New forward static decl. | |
402 | * eval.c (Ffetch_bytecode): New forward static decl. | |
403 | (Funintern): Remove extern decl; now in .h file where it belongs. | |
404 | * fileio.c (Fmake_symbolic_link): New forward static decl. | |
405 | * image.c (Finit_image_library): New forward static decl. | |
406 | * insdel.c (Fcombine_after_change_execute): Make forward decl static. | |
407 | * intervals.h (Fprevious_property_change): | |
408 | (Fremove_list_of_text_properties): Remove decls. | |
409 | * keyboard.c (Fthis_command_keys): Remove decl. | |
410 | (Fcommand_execute): New forward static decl. | |
411 | * keymap.c (Flookup_key): New forward static decl. | |
412 | (Fcopy_keymap): Now static. | |
413 | * keymap.h (Flookup_key): Remove decl. | |
414 | * process.c (Fget_process): New forward static decl. | |
415 | (Fprocess_datagram_address): Mark as internal. | |
416 | * syntax.c (Fsyntax_table_p): New forward static decl. | |
417 | (skip_chars): Remove duplicate decl. | |
418 | * textprop.c (Fprevious_property_change): New forward static decl. | |
419 | * window.c (Fset_window_fringes, Fset_window_scroll_bars): | |
420 | Now internal. | |
421 | (Fset_window_margins, Fset_window_vscroll): New forward static decls. | |
422 | * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls. | |
423 | ||
785bbd42 PE |
424 | * editfns.c (Fformat): Remove unreachable code. |
425 | ||
8b913b57 AS |
426 | 2011-04-14 Andreas Schwab <schwab@linux-m68k.org> |
427 | ||
428 | * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13 | |
429 | change. (Bug#8496) | |
430 | ||
a6744a35 EZ |
431 | 2011-04-13 Eli Zaretskii <eliz@gnu.org> |
432 | ||
433 | * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init | |
434 | when at ZV. (Bug#8487) | |
435 | ||
e7974947 AS |
436 | 2011-04-12 Andreas Schwab <schwab@linux-m68k.org> |
437 | ||
baad03f0 AS |
438 | * charset.c (Fclear_charset_maps): Use xfree instead of free. |
439 | (Bug#8437) | |
440 | * keyboard.c (parse_tool_bar_item): Likewise. | |
441 | * sound.c (sound_cleanup, alsa_close): Likewise. | |
442 | * termcap.c (tgetent): Likewise. | |
443 | * xfns.c (x_default_font_parameter): Likewise. | |
444 | * xsettings.c (read_and_apply_settings): Likewise. | |
445 | ||
e7974947 AS |
446 | * alloc.c (overrun_check_malloc, overrun_check_realloc) |
447 | (overrun_check_free): Protoize. | |
448 | ||
28272684 PE |
449 | 2011-04-12 Paul Eggert <eggert@cs.ucla.edu> |
450 | ||
451 | * sysdep.c (emacs_read, emacs_write): Check for negative sizes | |
452 | since callers should never pass a negative size. | |
453 | Change the signature to match that of plain 'read' and 'write'; see | |
454 | <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>. | |
455 | * lisp.h: Update prototypes of emacs_write and emacs_read. | |
456 | ||
11997c76 EZ |
457 | 2011-04-11 Eli Zaretskii <eliz@gnu.org> |
458 | ||
459 | * xdisp.c (redisplay_window): Don't try to determine the character | |
460 | position of the scroll margin if the window start point w->startp | |
e896f03c | 461 | is outside the buffer's accessible region. (Bug#8468) |
11997c76 | 462 | |
8a2cbd72 EZ |
463 | 2011-04-10 Eli Zaretskii <eliz@gnu.org> |
464 | ||
465 | Fix write-region and its subroutines for buffers > 2GB. | |
466 | * fileio.c (a_write, e_write): Modify declaration of arguments and | |
467 | local variables to support buffers larger than 2GB. | |
468 | (Fcopy_file): Use EMACS_INT for return value of emacs_read. | |
469 | ||
470 | * sysdep.c (emacs_write, emacs_read): Use ssize_t for last | |
471 | argument, local variables, and return value. | |
472 | ||
473 | * lisp.h: Update prototypes of emacs_write and emacs_read. | |
474 | ||
475 | * sound.c (vox_write): Use ssize_t for return value of emacs_write. | |
476 | ||
4073e537 | 477 | 2011-04-10 Paul Eggert <eggert@cs.ucla.edu> |
eb3f1cc8 | 478 | |
1ebfdcb6 PE |
479 | * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack. |
480 | ||
b2ded58d PE |
481 | Fix more problems found by GCC 4.6.0's static checks. |
482 | ||
7d66342c PE |
483 | * xdisp.c (vmessage): Use a better test for character truncation. |
484 | ||
bbf47d44 PE |
485 | * charset.c (load_charset_map): <, not <=, for optimization, |
486 | and to avoid potential problems with integer overflow. | |
9248994d | 487 | * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise. |
f9a68bc5 | 488 | * casetab.c (set_identity, shuffle): Likewise. |
3ab1c7ce | 489 | * editfns.c (Fformat): Likewise. |
1e69125e | 490 | * syntax.c (skip_chars): Likewise. |
3befa583 | 491 | |
e3019616 PE |
492 | * xmenu.c (set_frame_menubar): Allocate smaller local vectors. |
493 | This also lets GCC 4.6.0 generate slightly better loop code. | |
494 | ||
becfa255 PE |
495 | * callint.c (Fcall_interactively): <, not <=, for optimization. |
496 | (Fcall_interactively): Count the number of arguments produced, | |
497 | not the number of arguments given. This is simpler and lets GCC | |
498 | 4.6.0 generate slightly better code. | |
499 | ||
dae0cd48 PE |
500 | * ftfont.c: Distingish more carefully between FcChar8 and char. |
501 | The previous code passed unsigned char * to a functions like | |
502 | strlen and xstrcasecmp that expect char *, which does not | |
503 | conform to the C standard. | |
504 | (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for | |
505 | arguments to FcPatternGetString, and explicitly cast FcChar8 * to | |
506 | char * when the C standard requires it. | |
507 | ||
76032d70 PE |
508 | * keyboard.c (read_char): Remove unused var. |
509 | ||
eb3f1cc8 PE |
510 | * eval.c: Port to Windows vsnprintf (Bug#8435). |
511 | Include <limits.h>. | |
512 | (SIZE_MAX): Define if the headers do not. | |
513 | (verror): Do not give up if vsnprintf returns a negative count. | |
514 | Instead, grow the buffer. This ports to Windows vsnprintf, which | |
515 | does not conform to C99. Problem reported by Eli Zaretskii. | |
516 | Also, simplify the allocation scheme, by avoiding the need for | |
517 | calling realloc, and removing the ALLOCATED variable. | |
518 | ||
70476b54 PE |
519 | * eval.c (verror): Initial buffer size is 4000 (not 200) bytes. |
520 | ||
12020a9e PE |
521 | Remove invocations of doprnt, as Emacs now uses vsnprintf. |
522 | But keep the doprint source code for now, as we might revamp it | |
523 | and use it again (Bug#8435). | |
ea6c7ae6 PE |
524 | * lisp.h (doprnt): Remove. |
525 | * Makefile.in (base_obj): Remove doprnt.o. | |
526 | * deps.mk (doprnt.o): Remove. | |
527 | ||
5fdb398c PE |
528 | error: Print 32- and 64-bit integers portably (Bug#8435). |
529 | Without this change, on typical 64-bit hosts error ("...%d...", N) | |
530 | was used to print both 32- and 64-bit integers N, which relied on | |
531 | undefined behavior. | |
532 | * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd): | |
533 | New macro. | |
534 | * lisp.h (error, verror): Mark as printf-like functions. | |
535 | * eval.c (verror): Use vsnprintf, not doprnt, to do the real work. | |
536 | Report overflow in size calculations when allocating printf buffer. | |
537 | Do not truncate output string at its first null byte. | |
538 | * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work. | |
539 | Truncate the output at a character boundary, since vsnprintf does not | |
540 | do that. | |
541 | * charset.c (check_iso_charset_parameter): Convert internal | |
542 | character to string before calling 'error', since %c now has the | |
543 | printf meaning. | |
544 | * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int | |
545 | overflow when computing char to be passed to 'error'. Do not | |
546 | pass Lisp_Object to 'error'; pass the integer instead. | |
547 | * nsfns.m (Fns_do_applescript): Use int, not long, since it's | |
548 | formatted with plain %d. | |
549 | ||
b189fa66 PE |
550 | * eval.c (internal_lisp_condition_case): Don't pass spurious arg. |
551 | ||
bff87ef0 PE |
552 | * keyboard.c (access_keymap_keyremap): Print func name, not garbage. |
553 | ||
7e2cac20 PE |
554 | * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int. |
555 | ||
ce4d90b5 PE |
556 | * xterm.c (x_catch_errors): Remove duplicate declaration. |
557 | ||
266c9547 PE |
558 | * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too. |
559 | ||
79c49ad2 PE |
560 | * xdisp.c, lisp.h (message_nolog): Remove; unused. |
561 | ||
368f4090 JM |
562 | 2011-04-10 Jim Meyering <meyering@redhat.com> |
563 | ||
564 | use ssize_t and size_t for read- and write-like emacs_gnutls_* functions | |
565 | * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like: | |
566 | return ssize_t not "int", and use size_t as the buffer length. | |
567 | (emacs_gnutls_write): Likewise, and make the buffer pointer "const". | |
568 | * gnutls.h: Update declarations. | |
569 | * process.c (read_process_output): Use ssize_t, to match. | |
570 | (send_process): Likewise. | |
571 | ||
a32d4040 CY |
572 | 2011-04-09 Chong Yidong <cyd@stupidchicken.com> |
573 | ||
574 | * image.c (Fimagemagick_types): Doc fix, and comment cleanup. | |
575 | ||
8546720e | 576 | 2011-04-09 Chong Yidong <cyd@stupidchicken.com> |
aac0c6e3 | 577 | |
8546720e GM |
578 | * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use |
579 | unsigned char, to match FcChar8 type definition. | |
aac0c6e3 | 580 | |
8546720e GM |
581 | * xterm.c (handle_one_xevent): |
582 | * xmenu.c (create_and_show_popup_menu): | |
583 | * xselect.c (x_decline_selection_request) | |
584 | (x_reply_selection_request): Avoid type-punned deref of X events. | |
aac0c6e3 | 585 | |
0a2f5c1a | 586 | 2011-04-09 Eli Zaretskii <eliz@gnu.org> |
a53e2e89 EZ |
587 | |
588 | Fix some uses of `int' instead of EMACS_INT. | |
589 | * search.c (string_match_1, fast_string_match) | |
590 | (fast_c_string_match_ignore_case, fast_string_match_ignore_case) | |
591 | (scan_buffer, find_next_newline_no_quit) | |
592 | (find_before_next_newline, search_command, Freplace_match) | |
593 | (Fmatch_data): Make some `int' variables be EMACS_INT. | |
594 | ||
595 | * xdisp.c (display_count_lines): 3rd argument and return value now | |
596 | EMACS_INT. All callers changed. | |
597 | (pint2hrstr): Last argument is now EMACS_INT. | |
598 | ||
599 | * coding.c (detect_coding_utf_8, detect_coding_emacs_mule) | |
600 | (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5) | |
601 | (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8) | |
602 | (decode_coding_utf_16, decode_coding_emacs_mule) | |
603 | (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5) | |
604 | (decode_coding_ccl, decode_coding_charset) | |
605 | <consumed_chars, consumed_chars_base>: Declare EMACS_INT. | |
606 | (decode_coding_iso_2022, decode_coding_emacs_mule) | |
607 | (decode_coding_sjis, decode_coding_big5, decode_coding_charset) | |
608 | <char_offset, last_offset>: Declare EMACS_INT. | |
609 | (encode_coding_utf_8, encode_coding_utf_16) | |
610 | (encode_coding_emacs_mule, encode_invocation_designation) | |
611 | (encode_designation_at_bol, encode_coding_iso_2022) | |
612 | (encode_coding_sjis, encode_coding_big5, encode_coding_ccl) | |
613 | (encode_coding_raw_text, encode_coding_charset) <produced_chars>: | |
614 | Declare EMACS_INT. | |
615 | (ASSURE_DESTINATION): Declare more_bytes EMACS_INT. | |
616 | (encode_invocation_designation): Last argument P_NCHARS is now | |
617 | EMACS_INT. | |
618 | (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT. | |
619 | (produce_chars): from_nchars and to_nchars are now EMACS_INT. | |
620 | ||
621 | * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT. | |
622 | All users changed. | |
623 | ||
624 | * ccl.c (Fccl_execute_on_string): Declare some variables | |
625 | EMACS_INT. | |
626 | ||
8546720e | 627 | 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change) |
0080dc6b SS |
628 | |
629 | * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450). | |
630 | ||
4e19a977 CS |
631 | 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com> |
632 | ||
633 | * process.c (Fformat_network_address): Doc fix. | |
634 | ||
87302331 R |
635 | 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change) |
636 | ||
637 | * xml.c (parse_region): Avoid creating spurious whiespace nodes. | |
638 | ||
cbb59342 CY |
639 | 2011-04-08 Chong Yidong <cyd@stupidchicken.com> |
640 | ||
641 | * keyboard.c (read_char): Call Lisp function help-form-show, | |
642 | instead of using internal_with_output_to_temp_buffer. | |
643 | (Qhelp_form_show): New var. | |
e0d38eeb | 644 | (syms_of_keyboard): Use DEFSYM macro. |
cbb59342 CY |
645 | |
646 | * print.c (internal_with_output_to_temp_buffer): Function deleted. | |
647 | ||
648 | * lisp.h (internal_with_output_to_temp_buffer): Remove prototype. | |
649 | ||
e67a13ab CY |
650 | 2011-04-06 Chong Yidong <cyd@stupidchicken.com> |
651 | ||
652 | * process.c (Flist_processes): Removed to Lisp. | |
653 | (list_processes_1): Deleted. | |
654 | ||
973f782d EZ |
655 | 2011-04-06 Eli Zaretskii <eliz@gnu.org> |
656 | ||
7c106b1e EZ |
657 | * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements. |
658 | ||
973f782d EZ |
659 | * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs. |
660 | ||
41cf7d1a | 661 | 2011-04-06 Paul Eggert <eggert@cs.ucla.edu> |
27ccc379 | 662 | |
ca23cc88 PE |
663 | Fix more problems found by GCC 4.6.0's static checks. |
664 | ||
f390e2d5 PE |
665 | * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats. |
666 | ||
42eea0d0 PE |
667 | * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats. |
668 | ||
b69769da | 669 | * lisp.h (message, message_nolog, fatal): Mark as printf-like. |
1e973bc7 | 670 | |
f9541e84 PE |
671 | * xdisp.c (vmessage): Mark as a printf-like function. |
672 | ||
13841b55 PE |
673 | * term.c (vfatal, maybe_fatal): Mark as printf-like functions. |
674 | ||
c136c10f PE |
675 | * sound.c (sound_warning): Don't crash if arg contains a printf format. |
676 | ||
5e2d4a30 PE |
677 | * image.c (tiff_error_handler, tiff_warning_handler): Mark as |
678 | printf-like functions. | |
679 | (tiff_load): Add casts to remove these marks before passing them | |
680 | to system-supplied API. | |
681 | ||
583f48b9 PE |
682 | * eval.c (Fsignal): Remove excess argument to 'fatal'. |
683 | ||
b25d760e PE |
684 | * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int. |
685 | This avoids several warnings with gcc -Wstrict-overflow. | |
d5efd1d1 PE |
686 | (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code |
687 | directly, rather than having caller test rule sign. This avoids | |
688 | some unnecessary tests. | |
689 | * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro. | |
690 | (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This | |
691 | affects only one use, in DECODE_COMPOSITION_RULE, which is changed. | |
b25d760e | 692 | |
bc7b6697 | 693 | * xfont.c (xfont_text_extents): Remove var that was set but not used. |
625a3eb1 | 694 | (xfont_open): Avoid unnecessary tests. |
bc7b6697 | 695 | |
27ccc379 PE |
696 | * composite.c (composition_gstring_put_cache): Use unsigned integer. |
697 | ||
dcd5c89a PE |
698 | * composite.h, composite.c (composition_gstring_put_cache): |
699 | Use EMACS_INT, not int, for length. | |
700 | ||
b13a45c6 PE |
701 | * composite.h (COMPOSITION_DECODE_REFS): New macro, |
702 | breaking out part of COMPOSITION_DECODE_RULE. | |
703 | (COMPOSITION_DECODE_RULE): Use it. | |
704 | * composite.c (get_composition_id): Remove unused local vars, | |
705 | by using the new macro. | |
706 | ||
1e792e4d PE |
707 | * textprop.c (set_text_properties_1): Change while to do-while, |
708 | since the condition is always true at first. | |
709 | ||
dc6c6455 | 710 | * intervals.c (graft_intervals_into_buffer): Mark var as used. |
aa86731f PE |
711 | (interval_deletion_adjustment): Return unsigned value. |
712 | All uses changed. | |
dc6c6455 | 713 | |
aba7731a PE |
714 | * process.c (list_processes_1, create_pty, read_process_output): |
715 | (exec_sentinel): Remove vars that were set but not used. | |
afd4052b | 716 | (create_pty): Remove unnecessary "volatile"s. |
bc57d757 | 717 | (Fnetwork_interface_info): Avoid possibility of int overflow. |
82eaa333 | 718 | (read_process_output): Do adaptive read buffering even if carryover. |
fe07cdfa | 719 | (read_process_output): Simplify nbytes computation if buffered. |
aba7731a | 720 | |
fdfc4bf3 PE |
721 | * bytecode.c (exec_byte_code): Rename local to avoid shadowing. |
722 | ||
fca8fe46 | 723 | * syntax.c (scan_words): Remove var that was set but not used. |
12cbf13f | 724 | (update_syntax_table): Use unsigned instead of int. |
fca8fe46 | 725 | |
06a0259a | 726 | * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs. |
3c346cc3 | 727 | (lisp_file_lexically_bound_p, read1): Use unsigned instead of int. |
e6eb4e9e | 728 | (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop. |
06a0259a | 729 | |
e7b9e80f PE |
730 | * print.c (print_error_message): Avoid int overflow. |
731 | ||
56201685 PE |
732 | * font.c (font_list_entities): Redo for clarity, |
733 | so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX. | |
734 | ||
78834453 | 735 | * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars. |
790771b1 | 736 | (font_score): Avoid potential overflow in diff calculation. |
78834453 | 737 | |
0bc0b309 | 738 | * fns.c (substring_both): Remove var that is set but not used. |
8cd55cb4 | 739 | (sxhash): Redo loop for clarity and to avoid wraparound warning. |
0bc0b309 | 740 | |
e610eaca PE |
741 | * eval.c (funcall_lambda): Rename local to avoid shadowing. |
742 | ||
b895abce PE |
743 | * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int. |
744 | Otherwise, GCC 4.6.0 optimizes the loop check away since the check | |
745 | can always succeed if overflow has undefined behavior. | |
746 | ||
1f1d9321 | 747 | * search.c (boyer_moore, wordify): Remove vars set but not used. |
6f076cc7 | 748 | (wordify): Omit three unnecessary tests. |
1f1d9321 | 749 | |
c59478bc PE |
750 | * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column. |
751 | All callers changed. This avoids the need for an unused var. | |
752 | ||
79b73827 PE |
753 | * casefiddle.c (casify_region): Remove var that is set but not used. |
754 | ||
a4db5dfe PE |
755 | * dired.c (file_name_completion): Remove var that is set but not used. |
756 | ||
43aae36e PE |
757 | * fileio.c (Finsert_file_contents): Make EOF condition clearer. |
758 | ||
2a47c44d | 759 | * fileio.c (Finsert_file_contents): Avoid signed integer overflow. |
163c5f32 | 760 | (Finsert_file_contents): Remove unnecessary code checking fd. |
2a47c44d | 761 | |
a37c69bf PE |
762 | * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes. |
763 | Check for integer overflow on size calculations. | |
764 | ||
328ab8e7 PE |
765 | * buffer.c (Fprevious_overlay_change): Remove var that is set |
766 | but not used. | |
767 | ||
e5a2a5cb PE |
768 | * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt): |
769 | Remove vars that are set but not used. | |
8d84a6eb | 770 | (timer_check_2): Don't assume timer-list and idle-timer-list are lists. |
6b043475 | 771 | (timer_check_2): Mark vars as initialized. |
e5a2a5cb | 772 | |
a60e5f68 PE |
773 | * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized. |
774 | ||
f661cb61 | 775 | * image.c (lookup_image): Remove var that is set but not used. |
35fa624f | 776 | (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable. |
f661cb61 | 777 | |
f0397f5a PE |
778 | * fontset.c (Finternal_char_font, Ffontset_info): Remove vars |
779 | that are set but not used. | |
780 | ||
8664db06 | 781 | * xfns.c (make_invisible_cursor): Don't return garbage |
03733ee7 | 782 | if XCreateBitmapFromData fails (Bug#8410). |
8664db06 | 783 | |
6abdaa4a PE |
784 | * xselect.c (x_get_local_selection, x_handle_property_notify): |
785 | Remove vars that are set but not used. | |
786 | ||
0ce7538d | 787 | * xfns.c (x_create_tip_frame): Remove var that is set but not used. |
6abdaa4a | 788 | (make_invisible_cursor): Initialize a possibly-uninitialized variable. |
0ce7538d | 789 | |
9ae848fc PE |
790 | * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]: |
791 | Remove var that is set but not used. | |
0b918413 PE |
792 | (scroll_bar_windows_size): Now size_t, not int. |
793 | (x_send_scroll_bar_event): Use size_t, not int, for sizes. | |
794 | Check for overflow. | |
9ae848fc | 795 | |
a5a62657 PE |
796 | * xfaces.c (realize_named_face): Remove vars that are set but not used. |
797 | (map_tty_color) [!defined MSDOS]: Likewise. | |
798 | ||
5c5cdd39 PE |
799 | * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning. |
800 | ||
66ebf983 PE |
801 | * coding.c: Remove vars that are set but not used. |
802 | (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused. | |
803 | All callers changed. | |
804 | (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule): | |
805 | (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5): | |
806 | (decode_coding_charset): Remove vars that are set but not used. | |
807 | ||
1be4d761 PE |
808 | * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var |
809 | that is set but not used. | |
810 | ||
47553fa8 PE |
811 | * print.c (print_object): Remove var that is set but not used. |
812 | ||
1f7196bf | 813 | Replace 2 copies of readlink code with 1 gnulib version (Bug#8401). |
d1fdcab7 PE |
814 | The gnulib version avoids calling malloc in the usual case, |
815 | and on 64-bit hosts doesn't have some arbitrary 32-bit limits. | |
816 | * fileio.c (Ffile_symlink_p): Use emacs_readlink. | |
817 | * filelock.c (current_lock_owner): Likewise. | |
818 | * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function. | |
819 | * sysdep.c: Include allocator.h, careadlinkat.h. | |
820 | (emacs_no_realloc_allocator): New static constant. | |
821 | (emacs_readlink): New function. | |
fdb61804 PE |
822 | * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on |
823 | ../lib/careadlinkat.h. | |
d1fdcab7 | 824 | |
f84c17c7 SM |
825 | 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca> |
826 | ||
827 | * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the | |
828 | first non-nil return value). | |
829 | ||
ef3862ad JD |
830 | 2011-04-03 Jan Djärv <jan.h.d@swipnet.se> |
831 | ||
832 | * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6 | |
833 | if not defined (Bug#8403). | |
834 | ||
376a7006 JB |
835 | 2011-04-02 Juanma Barranquero <lekktu@gmail.com> |
836 | ||
837 | * xdisp.c (display_count_lines): Remove parameter `start', | |
838 | unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed. | |
839 | (get_char_face_and_encoding): Remove parameter `multibyte_p', | |
840 | unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed. | |
841 | (fill_stretch_glyph_string): Remove parameters `row' and `area', | |
842 | unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk | |
843 | and thereabouts. All callers changed. | |
844 | (get_per_char_metric): Remove parameter `f', unused since | |
845 | 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed. | |
846 | ||
6ca3801d JM |
847 | 2011-04-02 Jim Meyering <meyering@redhat.com> |
848 | ||
849 | do not dereference NULL upon failed strdup | |
850 | * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup. | |
851 | (ns_get_family): Likewise. | |
852 | ||
d8e2b5ba JB |
853 | 2011-04-02 Juanma Barranquero <lekktu@gmail.com> |
854 | ||
855 | * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment. | |
856 | ||
8c74fcbd JD |
857 | 2011-04-02 Jan Djärv <jan.h.d@swipnet.se> |
858 | ||
859 | * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or | |
860 | later (Bug#8403). | |
861 | ||
7200d79c SM |
862 | 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca> |
863 | ||
03408648 | 864 | Add lexical binding. |
7200d79c | 865 | |
03408648 SM |
866 | * window.c (Ftemp_output_buffer_show): New fun. |
867 | (Fsave_window_excursion): | |
868 | * print.c (Fwith_output_to_temp_buffer): Move to subr.el. | |
869 | ||
870 | * lread.c (lisp_file_lexically_bound_p): New function. | |
871 | (Fload): Bind Qlexical_binding. | |
872 | (readevalloop): Remove `evalfun' arg. | |
873 | Bind Qinternal_interpreter_environment. | |
874 | (Feval_buffer): Bind Qlexical_binding. | |
875 | (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard): | |
876 | Mark as dynamic. | |
877 | (syms_of_lread): Declare `lexical-binding'. | |
878 | ||
879 | * lisp.h (struct Lisp_Symbol): New field `declared_special'. | |
880 | ||
881 | * keyboard.c (eval_dyn): New fun. | |
882 | (menu_item_eval_property): Use it. | |
ca105506 SM |
883 | |
884 | * image.c (parse_image_spec): Use Ffunctionp. | |
ca105506 | 885 | |
03408648 SM |
886 | * fns.c (concat, mapcar1): Accept byte-code-functions. |
887 | ||
888 | * eval.c (Fsetq): Handle lexical vars. | |
889 | (Fdefun, Fdefmacro, Ffunction): Make closures when needed. | |
890 | (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic. | |
891 | (FletX, Flet): Obey lexical binding. | |
892 | (Fcommandp): Handle closures. | |
893 | (Feval): New `lexical' arg. | |
894 | (eval_sub): New function extracted from Feval. Use it almost | |
895 | everywhere where Feval was used. Look up vars in lexical env. | |
896 | Handle closures. | |
897 | (Ffunctionp): Move from subr.el. | |
898 | (Ffuncall): Handle closures. | |
899 | (apply_lambda): Remove `eval_flags'. | |
900 | (funcall_lambda): Handle closures and new byte-code-functions. | |
901 | (Fspecial_variable_p): New function. | |
902 | (syms_of_eval): Initialize the Vinternal_interpreter_environment var, | |
903 | but without exporting it to Lisp. | |
23aba0ea | 904 | |
23aba0ea | 905 | * doc.c (Fdocumentation, store_function_docstring): |
03408648 | 906 | * data.c (Finteractive_form): Handle closures. |
23aba0ea | 907 | |
03408648 SM |
908 | * callint.c (Fcall_interactively): Preserve lexical-binding mode for |
909 | interactive spec. | |
ba83908c | 910 | |
03408648 SM |
911 | * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New |
912 | byte-codes. | |
913 | (exec_byte_code): New function extracted from Fbyte_code to handle new | |
914 | calling convention for byte-code-functions. Add new byte-codes. | |
ba83908c | 915 | |
03408648 | 916 | * buffer.c (defvar_per_buffer): Set new `declared_special' field. |
e2abe5a1 | 917 | |
03408648 | 918 | * alloc.c (Fmake_symbol): Init new `declared_special' field. |
e2abe5a1 | 919 | |
e2abce01 JB |
920 | 2011-03-31 Juanma Barranquero <lekktu@gmail.com> |
921 | ||
922 | * xdisp.c (redisplay_internal): Fix prototype. | |
923 | ||
63696a73 | 924 | 2011-03-31 Eli Zaretskii <eliz@gnu.org> |
09725d26 | 925 | |
63696a73 EZ |
926 | * xdisp.c (SCROLL_LIMIT): New macro. |
927 | (try_scrolling): Use it when setting scroll_limit. Limit | |
928 | scrolling to 100 screen lines. | |
929 | (redisplay_window): Even when falling back on "recentering", | |
930 | position point in the window according to scroll-conservatively, | |
931 | scroll-margin, and scroll-*-aggressively variables. (Bug#6671) | |
932 | ||
933 | (try_scrolling): When point is above the window, allow searching | |
934 | as far as scroll_max, or one screenful, to compute vertical | |
935 | distance from PT to the scroll margin position. This prevents | |
936 | try_scrolling from unnecessarily failing when | |
937 | scroll-conservatively is set to a value slightly larger than the | |
938 | window height. Clean up the case of PT below the margin at bottom | |
939 | of window: scroll_max can no longer be INT_MAX. When aggressive | |
940 | scrolling is in use, don't let point enter the opposite scroll | |
941 | margin as result of the scroll. | |
942 | (syms_of_xdisp) <scroll-conservatively>: Document the | |
09725d26 EZ |
943 | threshold of 100 lines for never-recentering scrolling. |
944 | ||
e4cc2dfc JB |
945 | 2011-03-31 Juanma Barranquero <lekktu@gmail.com> |
946 | ||
947 | * dispextern.h (move_it_by_lines): | |
948 | * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused | |
949 | since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed. | |
950 | (message_log_check_duplicate): Remove parameters `prev_bol' and | |
951 | `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed. | |
952 | (redisplay_internal): Remove parameter `preserve_echo_area', | |
953 | unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed. | |
954 | ||
955 | * indent.c (Fvertical_motion): | |
956 | * window.c (window_scroll_pixel_based, Frecenter): | |
957 | Don't pass `need_y_p' to `move_it_by_lines'. | |
958 | ||
1c470562 SM |
959 | 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca> |
960 | ||
44f230aa SM |
961 | * eval.c (struct backtrace): Don't cheat with negative numbers, but do |
962 | steal a few bits to be more compact. | |
963 | (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace): | |
964 | Remove unneeded casts. | |
965 | ||
1c470562 SM |
966 | * bytecode.c (Fbyte_code): CAR and CDR can GC. |
967 | ||
888adce9 ZK |
968 | 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change) |
969 | ||
970 | * keyboard.c (Fexecute_extended_command): Do log the "suggest key | |
971 | binding" message (bug#7967). | |
972 | ||
f838ed7b PE |
973 | 2011-03-30 Paul Eggert <eggert@cs.ucla.edu> |
974 | ||
77861b95 PE |
975 | Fix more problems found by GCC 4.6.0's static checks. |
976 | ||
de6dbc14 PE |
977 | * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]: |
978 | Remove unused local var. | |
979 | ||
f838ed7b PE |
980 | * editfns.c (Fmessage_box): Remove unused local var. |
981 | ||
792c7b2b PE |
982 | * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs): |
983 | (note_mode_line_or_margin_highlight, note_mouse_highlight): | |
984 | Omit unused local vars. | |
c499e557 | 985 | * window.c (shrink_windows): Omit unused local var. |
b01a1c29 | 986 | * menu.c (digest_single_submenu): Omit unused local var. |
0bc32927 PE |
987 | * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]: |
988 | Omit unused local var. | |
989 | ||
ba0165e1 PE |
990 | * keyboard.c (parse_modifiers_uncached, parse_modifiers): |
991 | Don't assume string length fits in int. | |
32ad8845 | 992 | (keyremap_step, read_key_sequence): Use size_t for sizes. |
48011560 | 993 | (read_key_sequence): Don't check last_real_key_start redundantly. |
ba0165e1 | 994 | |
3c59b4c9 PE |
995 | * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA |
996 | instead of alloca (Bug#8344). | |
997 | ||
a3eed478 | 998 | * eval.c (Fbacktrace): Don't assume nargs fits in int. |
5d5d959d | 999 | (Fbacktrace_frame): Don't assume nframes fits in int. |
a3eed478 | 1000 | |
eb4d412d PE |
1001 | * syntax.c (scan_sexps_forward): Avoid pointer wraparound. |
1002 | ||
1658b401 PE |
1003 | * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow |
1004 | concerns. | |
1005 | ||
1006 | * term.c (produce_glyphless_glyph): Remove unnecessary test. | |
1007 | ||
1008 | * cm.c (calccost): Turn while-do into do-while, for clarity. | |
44f730c8 | 1009 | |
9a2c6e05 PE |
1010 | * keyboard.c (syms_of_keyboard): Use the same style as later |
1011 | in this function when indexing through an array. This also | |
1012 | works around GCC bug 48267. | |
1013 | ||
03d0a109 PE |
1014 | * image.c (tiff_load): Fix off-by-one image count (Bug#8336). |
1015 | ||
44f730c8 PE |
1016 | * xselect.c (x_check_property_data): Return correct size (Bug#8335). |
1017 | ||
fe75f926 PE |
1018 | * chartab.c (sub_char_table_ref_and_range): Redo for slight |
1019 | efficiency gain, and to bypass a gcc -Wstrict-overflow warning. | |
1020 | ||
ffa8c828 PE |
1021 | * keyboard.c, keyboard.h (num_input_events): Now size_t. |
1022 | This avoids undefined behavior on integer overflow, and is a bit | |
1023 | more convenient anyway since it is compared to a size_t variable. | |
1024 | ||
c5101a77 PE |
1025 | Variadic C functions now count arguments with size_t, not int. |
1026 | This avoids an unnecessary limitation on 64-bit machines, which | |
1027 | caused (substring ...) to crash on large vectors (Bug#8344). | |
1028 | * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int. | |
1029 | (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise. | |
77861b95 | 1030 | All variadic functions and their callers changed accordingly. |
c5101a77 PE |
1031 | (struct gcpro.nvars): Now size_t, not int. All uses changed. |
1032 | * data.c (arith_driver, float_arith_driver): Likewise. | |
1033 | * editfns.c (general_insert_function): Likewise. | |
1034 | * eval.c (struct backtrace.nargs, interactive_p) | |
1035 | (internal_condition_case_n, run_hook_with_args, apply_lambda) | |
1036 | (funcall_lambda, mark_backtrace): Likewise. | |
1037 | * fns.c (concat): Likewise. | |
1038 | * frame.c (x_set_frame_parameters): Likewise. | |
1039 | * fns.c (get_key_arg): Now accepts and returns size_t, and returns | |
1040 | 0 if not found, not -1. All callers changed. | |
1041 | ||
dd3f25f7 PE |
1042 | * alloc.c (garbage_collect): Don't assume stack size fits in int. |
1043 | (stack_copy_size): Now size_t, not int. | |
1044 | (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0. | |
1045 | ||
461c2ab9 JB |
1046 | 2011-03-28 Juanma Barranquero <lekktu@gmail.com> |
1047 | ||
1048 | * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end', | |
1049 | unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org. | |
1050 | All callers changed. | |
1051 | ||
1052 | * lisp.h (multibyte_char_to_unibyte): | |
1053 | * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl', | |
1054 | unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org. | |
1055 | * character.h (CHAR_TO_BYTE8): | |
1056 | * cmds.c (internal_self_insert): | |
1057 | * editfns.c (general_insert_function): | |
1058 | * keymap.c (push_key_description): | |
1059 | * search.c (Freplace_match): | |
1060 | * xdisp.c (message_dolog, set_message_1): All callers changed. | |
1061 | ||
f6d62986 SM |
1062 | 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca> |
1063 | ||
1064 | * keyboard.c (safe_run_hook_funcall): New function. | |
1065 | (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error, | |
1066 | don't set the hook to nil, but remove the offending function instead. | |
1067 | (Qcommand_hook_internal): Remove, unused. | |
1068 | (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define | |
1069 | Vcommand_hook_internal. | |
1070 | ||
1071 | * eval.c (enum run_hooks_condition): Remove. | |
1072 | (funcall_nil, funcall_not): New functions. | |
1073 | (run_hook_with_args): Call each function through a `funcall' argument. | |
1074 | Remove `cond' argument, now redundant. | |
1075 | (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success) | |
1076 | (Frun_hook_with_args_until_failure): Adjust accordingly. | |
1077 | (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions. | |
1078 | ||
1db5b1ad JB |
1079 | 2011-03-28 Juanma Barranquero <lekktu@gmail.com> |
1080 | ||
1081 | * dispextern.h (string_buffer_position): Remove declaration. | |
1082 | ||
1083 | * print.c (strout): Remove parameter `multibyte', unused since | |
1084 | 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed. | |
1085 | ||
1086 | * search.c (boyer_moore): Remove parameters `len', `pos' and `lim', | |
1087 | never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org. | |
1088 | All callers changed. | |
1089 | ||
1090 | * w32.c (_wsa_errlist): Use braces for struct initializers. | |
1091 | ||
1092 | * xdisp.c (string_buffer_position_lim): Remove parameter `w', | |
1093 | never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org. | |
1094 | All callers changed. | |
1095 | (string_buffer_position): Likewise. Also, make static (it's never | |
1096 | used outside xdisp.c). | |
1097 | (cursor_row_p): Remove parameter `w', unused since | |
1098 | 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed. | |
1099 | (decode_mode_spec): Remove parameter `precision', introduced during | |
1100 | Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used. | |
1101 | All callers changed. | |
1102 | ||
5ffb62aa JD |
1103 | 2011-03-27 Jan Djärv <jan.h.d@swipnet.se> |
1104 | ||
1105 | * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar. | |
1106 | ||
461c2ab9 | 1107 | 2011-03-27 Anders Lindgren <andlind@gmail.com> |
f0a1382a JD |
1108 | |
1109 | * nsterm.m (ns_menu_bar_is_hidden): New variable. | |
1110 | (ns_constrain_all_frames, ns_menu_bar_should_be_hidden) | |
1111 | (ns_update_auto_hide_menu_bar): New functions. | |
1112 | (ns_update_begin): Call ns_update_auto_hide_menu_bar. | |
1113 | (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and | |
1114 | ns_constrain_all_frames. | |
1115 | (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden. | |
1116 | (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil. | |
1117 | ||
5c380ffb JD |
1118 | 2011-03-27 Jan Djärv <jan.h.d@swipnet.se> |
1119 | ||
1120 | * nsmenu.m (runDialogAt): Remove argument to timer_check. | |
1121 | ||
9af30bdf GM |
1122 | 2011-03-27 Glenn Morris <rgm@gnu.org> |
1123 | ||
1124 | * syssignal.h: Replace RETSIGTYPE with void. | |
1125 | * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c: | |
1126 | * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c: | |
1127 | Replace SIGTYPE with void everywhere. | |
1128 | * s/usg5-4-common.h (SIGTYPE): Remove definition. | |
1129 | * s/template.h (SIGTYPE): Remove commented out definition. | |
1130 | ||
e2abce01 JB |
1131 | 2011-03-26 Eli Zaretskii <eliz@gnu.org> |
1132 | ||
1133 | * xdisp.c (redisplay_window): Don't check buffer's clip_changed | |
1134 | flag as a prerequisite for invoking try_scrolling. (Bug#6671) | |
1135 | ||
f868cd8a JB |
1136 | 2011-03-26 Juanma Barranquero <lekktu@gmail.com> |
1137 | ||
59eb0929 JB |
1138 | * w32.c (read_unc_volume): Use parameter `henum', instead of |
1139 | global variable `wget_enum_handle'. | |
1140 | ||
1141 | * keymap.c (describe_vector): Remove parameters `indices' and | |
1142 | `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org. | |
1143 | (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'. | |
1144 | ||
f868cd8a JB |
1145 | * keyboard.h (timer_check, show_help_echo): Remove unused parameters. |
1146 | ||
1147 | * keyboard.c (timer_check): Remove parameter `do_it_now', | |
1148 | unused since 1996-04-12T06:01:29Z!rms@gnu.org. | |
1149 | (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo', | |
1150 | unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca. | |
1151 | ||
1152 | * keyboard.c (read_char): | |
1153 | * w32menu.c (w32_menu_display_help): | |
1154 | * xmenu.c (show_help_event, menu_help_callback): | |
1155 | Adjust calls to `show_help_echo'. | |
1156 | ||
1157 | * gtkutil.c (xg_maybe_add_timer): | |
1158 | * keyboard.c (readable_events): | |
1159 | * process.c (wait_reading_process_output): | |
1160 | * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'. | |
1161 | ||
1162 | * insdel.c (adjust_markers_gap_motion): | |
1163 | Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org. | |
1164 | (gap_left, gap_right): Don't call it. | |
1165 | ||
2ecf6fdb CY |
1166 | 2011-03-25 Chong Yidong <cyd@stupidchicken.com> |
1167 | ||
1168 | * xdisp.c (handle_fontified_prop): Discard changes to clip_changed | |
1169 | incurred during fontification. | |
1170 | ||
6b1f9ba4 JB |
1171 | 2011-03-25 Juanma Barranquero <lekktu@gmail.com> |
1172 | ||
1173 | * buffer.c (defvar_per_buffer): Remove unused parameter `doc'. | |
1174 | (DEFVAR_PER_BUFFER): Don't pass it. | |
1175 | ||
1176 | * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'. | |
1177 | (scrolling_window): Don't pass it. | |
1178 | ||
0f4a96b5 JB |
1179 | 2011-03-25 Juanma Barranquero <lekktu@gmail.com> |
1180 | ||
1181 | * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef. | |
1182 | ||
1183 | * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len' | |
1184 | and `suffix'. | |
1185 | (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration | |
1186 | of variables specific to SELinux and computation of `encoded_absname'. | |
1187 | ||
1188 | * image.c (XPutPixel): Remove unused variable `height'. | |
1189 | ||
1190 | * keyboard.c (make_lispy_event): Remove unused variable `hpos'. | |
1191 | ||
1192 | * unexw32.c (get_section_info): Remove unused variable `section'. | |
1193 | ||
1194 | * w32.c (stat): Remove unused variables `drive_root' and `devtype'. | |
1195 | (system_process_attributes): Remove unused variable `sess'. | |
1196 | (sys_read): Remove unused variable `err'. | |
1197 | ||
1198 | * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef. | |
1199 | (w32_wnd_proc): Remove unused variable `isdead'. | |
1200 | (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef. | |
1201 | (Fx_server_max_request_size): Remove unused variable `dpyinfo'. | |
1202 | (x_create_tip_frame): Remove unused variable `tem'. | |
1203 | ||
1204 | * w32inevt.c (w32_console_read_socket): | |
1205 | Remove unused variable `no_events'. | |
1206 | ||
1207 | * w32term.c (x_draw_composite_glyph_string_foreground): | |
1208 | Remove unused variable `width'. | |
1209 | ||
1149507c JB |
1210 | 2011-03-24 Juanma Barranquero <lekktu@gmail.com> |
1211 | ||
1212 | * w32term.c (x_set_glyph_string_clipping): | |
1213 | Don't pass uninitialized region to CombineRgn. | |
1214 | ||
9c88f339 JB |
1215 | 2011-03-23 Juanma Barranquero <lekktu@gmail.com> |
1216 | ||
1217 | * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'. | |
1218 | (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer. | |
1219 | (Fx_close_connection): Remove unused variable `i'. | |
1220 | ||
1221 | * w32font.c (w32font_draw): Return number of glyphs. | |
1222 | (w32font_open_internal): Remove unused variable `i'. | |
1223 | (w32font_driver): Add missing initializer. | |
1224 | ||
1225 | * w32menu.c (utf8to16): Remove unused variable `utf16'. | |
1226 | (fill_in_menu): Remove unused variable `items_added'. | |
1227 | ||
1228 | * w32term.c (last_mouse_press_frame): Remove static global variable. | |
1229 | (w32_clip_to_row): Remove unused variable `f'. | |
1230 | (x_delete_terminal): Remove unused variable `i'. | |
1231 | ||
1232 | * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'. | |
1233 | (NOTHING): Remove unused static global variable. | |
1234 | (uniscribe_check_otf): Remove unused variable `table'. | |
1235 | (uniscribe_font_driver): Add missing initializers. | |
1236 | ||
dee091a3 JD |
1237 | 2011-03-23 Julien Danjou <julien@danjou.info> |
1238 | ||
1239 | * term.c (Fsuspend_tty, Fresume_tty): | |
1240 | * minibuf.c (read_minibuf, run_exit_minibuf_hook): | |
1241 | * window.c (temp_output_buffer_show): | |
1242 | * insdel.c (signal_before_change): | |
1243 | * frame.c (Fhandle_switch_frame): | |
1244 | * fileio.c (Fdo_auto_save): | |
1245 | * emacs.c (Fkill_emacs): | |
1246 | * editfns.c (save_excursion_restore): | |
1247 | * cmds.c (internal_self_insert): | |
1248 | * callint.c (Fcall_interactively): | |
1249 | * buffer.c (Fkill_all_local_variables): | |
1250 | * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1): | |
1251 | Use Frun_hooks. | |
0f4a96b5 | 1252 | (command_loop_1): Use Frun_hooks. Call safe_run_hooks |
dee091a3 JD |
1253 | unconditionnaly since it does the check itself. |
1254 | ||
2c520ab5 | 1255 | 2011-03-23 Paul Eggert <eggert@cs.ucla.edu> |
f0641eff | 1256 | |
c9c49752 PE |
1257 | Fix more problems found by GCC 4.5.2's static checks. |
1258 | ||
8abc3f12 PE |
1259 | * coding.c (encode_coding_raw_text): Avoid unnecessary test |
1260 | the first time through the loop, since we know p0 < p1 then. | |
1261 | This also avoids a gcc -Wstrict-overflow warning. | |
1262 | ||
a2d26660 PE |
1263 | * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow |
1264 | leading to a memory leak, possible in functions like | |
1265 | load_charset_map_from_file that can allocate an unbounded number | |
b12ef411 | 1266 | of objects (Bug#8318). |
a2d26660 | 1267 | |
916c72e9 PE |
1268 | * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes |
1269 | that could (at least in theory) be that large. | |
1270 | ||
19ab8a18 PE |
1271 | * xdisp.c (message_log_check_duplicate): Return unsigned long, not int. |
1272 | This is less likely to overflow, and avoids undefined behavior if | |
1273 | overflow does occur. All callers changed. Use strtoul to scan | |
1274 | for the unsigned long integer. | |
b7cbbd6f PE |
1275 | (pint2hrstr): Simplify and tune code slightly. |
1276 | This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow. | |
19ab8a18 | 1277 | |
f0641eff PE |
1278 | * scroll.c (do_scrolling): Work around GCC bug 48228. |
1279 | See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>. | |
1280 | ||
7f650bb9 PE |
1281 | * frame.c (Fmodify_frame_parameters): Simplify loop counter. |
1282 | This also avoids a warning with gcc -Wstrict-overflow. | |
39f5e519 PE |
1283 | (validate_x_resource_name): Simplify count usage. |
1284 | This also avoids a warning with gcc -Wstrict-overflow. | |
7f650bb9 | 1285 | |
37dd57d1 PE |
1286 | * fileio.c (Fcopy_file): Report error if fchown or fchmod |
1287 | fail (Bug#8306). | |
81e56e61 | 1288 | |
699979fc | 1289 | * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303). |
dc1ca6a8 | 1290 | |
401bf9b4 PE |
1291 | * process.c (Fmake_network_process): Use socklen_t, not int, |
1292 | where POSIX says socklen_t is required in portable programs. | |
1293 | This fixes a porting bug on hosts like 64-bit HP-UX, where | |
591b2973 | 1294 | socklen_t is wider than int (Bug#8277). |
401bf9b4 PE |
1295 | (Fmake_network_process, server_accept_connection): |
1296 | (wait_reading_process_output, read_process_output): | |
1297 | Likewise. | |
1298 | ||
b93aacde PE |
1299 | * process.c: Rename or move locals to avoid shadowing. |
1300 | (list_processes_1, Fmake_network_process): | |
1301 | (read_process_output_error_handler, exec_sentinel_error_handler): | |
1302 | Rename or move locals. | |
4dc343ee | 1303 | (Fmake_network_process): Define label "retry_connect" only if needed. |
0da49335 | 1304 | (Fnetwork_interface_info): Fix pointer signedness. |
f990b4e5 | 1305 | (process_send_signal): Add cast to avoid pointer signedness problem. |
7b808126 | 1306 | (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros. |
c939f91b | 1307 | (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298). |
b93aacde | 1308 | |
af8a867c | 1309 | Make tparam.h and terminfo.c consistent. |
44f230aa SM |
1310 | * cm.c (tputs, tgoto, BC, UP): Remove extern decls. |
1311 | Include tparam.h instead, since it declares them. | |
af8a867c PE |
1312 | * cm.h (PC): Remove extern decl; tparam.h now does this. |
1313 | * deps.mk (cm.o, terminfo.o): Depend on tparam.h. | |
1314 | * terminfo.c: Include tparam.h, to check interfaces. | |
1315 | (tparm): Make 1st arg a const pointer in decl. Put it at top level. | |
1316 | (tparam): Adjust signature to match interface in tparam.h; | |
1317 | this removes some undefined behavior. Check that outstring and len | |
1318 | are zero, which they always are with Emacs. | |
1319 | * tparam.h (PC, BC, UP): New extern decls. | |
1320 | ||
0248044d | 1321 | * xftfont.c (xftfont_shape): Now static, and defined only if needed. |
001a7ab4 | 1322 | (xftfont_open): Rename locals to avoid shadowing. |
0248044d | 1323 | |
8ff096c1 | 1324 | * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness. |
a00924bb PE |
1325 | (ftfont_otf_capability, ftfont_shape): Omit decls if not needed. |
1326 | (OTF_TAG_SYM): Omit macro if not needed. | |
e932860f | 1327 | (ftfont_list): Remove unused local. |
49eaafba PE |
1328 | (get_adstyle_property, ftfont_pattern_entity): |
1329 | (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point): | |
1330 | Rename locals to avoid shadowing. | |
8ff096c1 | 1331 | |
e2be39f6 PE |
1332 | * xfont.c (xfont_list_family): Mark var as initialized. |
1333 | ||
c9735e30 PE |
1334 | * xml.c (make_dom): Now static. |
1335 | ||
8f5201ae PE |
1336 | * composite.c (composition_compute_stop_pos): Rename local to |
1337 | avoid shadowing. | |
b246f932 PE |
1338 | (composition_reseat_it): Remove unused locals. |
1339 | (find_automatic_composition, composition_adjust_point): Likewise. | |
80e079b2 | 1340 | (composition_update_it): Mark var as initialized. |
11b61122 PE |
1341 | (find_automatic_composition): Mark vars as initialized, |
1342 | with a FIXME (Bug#8290). | |
8f5201ae | 1343 | |
760fbc2c PE |
1344 | character.h: Rename locals to avoid shadowing. |
1345 | * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE): | |
1346 | (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE): | |
1347 | (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS): | |
1348 | (BUF_DEC_POS): Be more systematic about renaming local temporaries | |
1349 | to avoid shadowing. | |
1350 | ||
ff08eb85 PE |
1351 | * textprop.c (property_change_between_p): Remove; unused. |
1352 | ||
fc7bf025 PE |
1353 | * intervals.c (interval_start_pos): Now static. |
1354 | ||
235d7abc PE |
1355 | * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else". |
1356 | ||
44f230aa SM |
1357 | * atimer.c (start_atimer, append_atimer_lists, set_alarm): |
1358 | Rename locals to avoid shadowing. | |
3e7d6594 | 1359 | |
50060332 PE |
1360 | * sound.c (wav_play, au_play, Fplay_sound_internal): |
1361 | Fix pointer signedness. | |
d01f234b | 1362 | (alsa_choose_format): Remove unused local var. |
c83b8872 PE |
1363 | (wav_play): Initialize a variable to 0, to prevent undefined |
1364 | behavior (Bug#8278). | |
50060332 | 1365 | |
c4fc4e30 PE |
1366 | * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing. |
1367 | ||
918436ed PE |
1368 | * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes. |
1369 | ||
c939f91b PE |
1370 | * callproc.c (Fcall_process): Use 'volatile' to avoid vfork |
1371 | clobbering (Bug#8298). | |
b9c7f648 PE |
1372 | * sysdep.c (sys_subshell): Likewise. |
1373 | Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out. | |
7e9123a2 | 1374 | |
6bd8c144 PE |
1375 | * lisp.h (child_setup): Now NO_RETURN unless DOS_NT. |
1376 | This should get cleaned up, so that child_setup has the | |
1377 | same signature on all platforms. | |
1378 | ||
7710357c | 1379 | * callproc.c (call_process_cleanup): Now static. |
cb1d0ef7 | 1380 | (relocate_fd): Rename locals to avoid shadowing. |
7710357c | 1381 | |
c59da222 CY |
1382 | 2011-03-22 Chong Yidong <cyd@stupidchicken.com> |
1383 | ||
1384 | * xterm.c (x_clear_frame): Remove XClearWindow call. This appears | |
1385 | not to be necessary, and produces flickering. | |
1386 | ||
66b87493 GM |
1387 | 2011-03-20 Glenn Morris <rgm@gnu.org> |
1388 | ||
1389 | * config.in: Remove file. | |
1390 | ||
45b6f6d5 JB |
1391 | 2011-03-20 Juanma Barranquero <lekktu@gmail.com> |
1392 | ||
1393 | * minibuf.c (Vcompleting_read_function): Don't declare, global variables | |
1394 | are now in src/globals.h. | |
1395 | (syms_of_minibuf): Remove spurious & from previous change. | |
1396 | ||
3ec03f7e LL |
1397 | 2011-03-20 Leo <sdl.web@gmail.com> |
1398 | ||
1399 | * minibuf.c (completing-read-function): New variable. | |
1400 | (completing-read-default): Rename from completing-read. | |
1401 | (completing-read): Call completing-read-function. | |
1402 | ||
b14e3e21 CY |
1403 | 2011-03-19 Juanma Barranquero <lekktu@gmail.com> |
1404 | ||
1405 | * xfaces.c (Fx_load_color_file): | |
1406 | Read color file from absolute filename (bug#8250). | |
1407 | ||
f2b726e6 JB |
1408 | 2011-03-19 Juanma Barranquero <lekktu@gmail.com> |
1409 | ||
1410 | * makefile.w32-in: Update dependencies. | |
1411 | ||
09f6ff02 EZ |
1412 | 2011-03-17 Eli Zaretskii <eliz@gnu.org> |
1413 | ||
1414 | * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h. | |
1415 | ||
29a6015a PE |
1416 | 2011-03-17 Paul Eggert <eggert@cs.ucla.edu> |
1417 | ||
a3a6c54e PE |
1418 | Fix more problems found by GCC 4.5.2's static checks. |
1419 | ||
b766f867 PE |
1420 | * process.c (make_serial_process_unwind, send_process_trap): |
1421 | (sigchld_handler): Now static. | |
1422 | ||
be02381c PE |
1423 | * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars. |
1424 | That way, the code declares only the vars that it needs. | |
1425 | * s/aix4-2.h (PTY_ITERATION): Declare iteration vars. | |
1426 | * s/cygwin.h (PTY_ITERATION): Likewise. | |
1427 | * s/darwin.h (PTY_ITERATION): Likewise. | |
1428 | * s/gnu-linux.h (PTY_ITERATION): Likewise. | |
1429 | ||
57048744 PE |
1430 | * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling. |
1431 | * process.c (allocate_pty): Don't declare stb unless it's needed. | |
1432 | ||
7914961c | 1433 | * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else". |
615f2d59 PE |
1434 | (CONSTANTLIM): Remove; unused. |
1435 | (METER_CODE, Bscan_buffer, Bread_char, Bset_mark): | |
1436 | Define only if needed. | |
7914961c | 1437 | |
b3967b18 PE |
1438 | * unexelf.c (unexec): Name an expression, |
1439 | to avoid gcc -Wbad-function-cast warning. | |
9ae71512 PE |
1440 | Use a different way to cause a compilation error if anyone uses |
1441 | n rather than nn, a way that does not involve shadowing. | |
73366a00 | 1442 | (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused. |
b3967b18 | 1443 | |
29a6015a PE |
1444 | * deps.mk (unexalpha.o): Remove; unused. |
1445 | ||
43cfc33e | 1446 | New file unexec.h, the (simple) interface for unexec (Bug#8267). |
7feda0d2 | 1447 | * unexec.h: New file. |
ce701a33 PE |
1448 | * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o): |
1449 | (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o): | |
1450 | Depend on unexec.h. | |
1451 | * emacs.c [!defined CANNOT_DUMP]: Include unexec.h. | |
1452 | * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c: | |
1453 | * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h. | |
381259ef | 1454 | Change as necessary to match prototype in unexec.h. |
ce701a33 | 1455 | |
01f44d5a PE |
1456 | * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid |
1457 | shadowing. | |
4f63c6bb | 1458 | (back_comment, skip_chars): Mark vars as initialized. |
01f44d5a | 1459 | |
a6670b0b PE |
1460 | * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS): |
1461 | Rename locals to avoid shadowing. | |
1462 | ||
cef2010d | 1463 | * lread.c (read1): Rewrite so as not to use empty "else". |
0902fe45 | 1464 | (Fload, readevalloop, read1): Rename locals to avoid shadowing. |
cef2010d | 1465 | |
d4d7173a PE |
1466 | * print.c (Fredirect_debugging_output): Fix pointer signedess. |
1467 | ||
f08b802a PE |
1468 | * lisp.h (debug_output_compilation_hack): Add decl here, to avoid |
1469 | warning when compiling print.c. | |
1470 | ||
3ddb0639 PE |
1471 | * font.c (font_unparse_fcname): Abort in an "impossible" situation |
1472 | instead of using an uninitialized var. | |
5ad03b97 | 1473 | (font_sort_entities): Mark var as initialized. |
3ddb0639 | 1474 | |
170a2692 PE |
1475 | * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing. |
1476 | ||
e663c700 PE |
1477 | * font.c (font_unparse_xlfd): Don't mix pointers to variables with |
1478 | pointers to constants. | |
89bc529a | 1479 | (font_parse_fcname): Remove unused vars. |
7b81e2d0 | 1480 | (font_delete_unmatched): Now static. |
ea838e10 | 1481 | (font_get_spec): Remove; unused. |
13a547c6 PE |
1482 | (font_style_to_value, font_prop_validate_style, font_unparse_fcname): |
1483 | (font_update_drivers, Ffont_get_glyphs, font_add_log): | |
1484 | Rename or move locals to avoid shadowing. | |
e663c700 | 1485 | |
2a80c887 | 1486 | * fns.c (require_nesting_list, require_unwind): Now static. |
612f56df | 1487 | (Ffillarray): Rename locals to avoid shadowing. |
2a80c887 | 1488 | |
1384fa33 | 1489 | * floatfns.c (domain_error2): Define only if needed. |
a885e2ed | 1490 | (Ffrexp, Fldexp): Rename locals to avoid shadowing. |
1384fa33 | 1491 | |
8b2c52e9 PE |
1492 | * alloc.c (mark_backtrace): Move decl from here ... |
1493 | * lisp.h: ... to here, so that it can be checked. | |
1494 | ||
475545b5 | 1495 | * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static. |
d28a2170 | 1496 | (Fdefvar): Rewrite so as not to use empty "else". |
cfcbfb1a PE |
1497 | (lisp_indirect_variable): Name an expression, |
1498 | to avoid gcc -Wbad-function-cast warning. | |
1faed8ae | 1499 | (Fdefvar): Rename locals to avoid shadowing. |
475545b5 | 1500 | |
b1349114 | 1501 | * callint.c (quotify_arg, quotify_args): Now static. |
a3e8cbda | 1502 | (Fcall_interactively): Rename locals to avoid shadowing. |
b0e80955 | 1503 | Use const pointer when appropriate. |
b1349114 | 1504 | |
a2928364 PE |
1505 | * lisp.h (get_system_name, get_operating_system_release): |
1506 | Move decls here, to check interfaces. | |
1507 | * process.c (get_operating_system_release): Move decl to lisp.h. | |
1508 | * xrdb.c (get_system_name): Likewise. | |
63c5d10b PE |
1509 | * editfns.c (init_editfns, Fuser_login_name, Fuser_uid): |
1510 | (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts, | |
1511 | some of which prompt warnings from gcc -Wbad-function-cast. | |
545b49b4 PE |
1512 | (Fformat_time_string, Fencode_time, Finsert_char): |
1513 | (Ftranslate_region_internal, Fformat): | |
1514 | Rename or remove local vars to avoid shadowing. | |
9710023e | 1515 | (Ftranslate_region_internal): Mark var as initialized. |
63c5d10b | 1516 | |
a415e694 PE |
1517 | * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to |
1518 | avoid shadowing. | |
1519 | ||
8ef4622d PE |
1520 | * lisp.h (eassert): Check that the argument compiles, even if |
1521 | ENABLE_CHECKING is not defined. | |
1522 | ||
946f9a5b PE |
1523 | * data.c (Findirect_variable): Name an expression, to avoid |
1524 | gcc -Wbad-function-cast warning. | |
112396d6 | 1525 | (default_value, arithcompare, arith_driver, arith_error): Now static. |
b9b84fa9 | 1526 | (store_symval_forwarding): Rename local to avoid shadowing. |
44f230aa SM |
1527 | (Fmake_variable_buffer_local, Fmake_local_variable): |
1528 | Mark variables as initialized. | |
52746918 | 1529 | (do_blv_forwarding, do_symval_forwarding): Remove; unused. |
946f9a5b | 1530 | |
e5aab7e7 | 1531 | * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST. |
ae35e756 PE |
1532 | (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect): |
1533 | Rename locals to avoid shadowing. | |
dff45157 PE |
1534 | (mark_stack): Move local variables into the #ifdef region where |
1535 | they're used. | |
7bc26fdb PE |
1536 | (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if |
1537 | ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not | |
1538 | needed otherwise. | |
1539 | (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS. | |
1540 | (GC_STRING_CHARS): Remove; not used. | |
d40d4be1 | 1541 | (Fmemory_limit): Cast sbrk's returned value to char *. |
ae35e756 | 1542 | |
e5aab7e7 PE |
1543 | * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this |
1544 | avoids undefined behavior in theory. | |
1545 | ||
4da60324 PE |
1546 | * regex.c (IF_LINT): Add defn, for benefit of ../lib-src. |
1547 | ||
88043301 PE |
1548 | Use functions, not macros, for up- and down-casing (Bug#8254). |
1549 | * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP): | |
1550 | (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed | |
1551 | to use the following functions instead of these macros. | |
1552 | (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not | |
1553 | EMACS_INT, since callers assume the returned value fits in int. | |
1554 | (upcase1): Likewise, for UPCASE_TABLE. | |
1555 | (uppercasep, lowercasep, upcase): New static inline functions. | |
0da09c43 | 1556 | * editfns.c (Fchar_equal): Remove no-longer-needed workaround for |
db69b0cd | 1557 | the race-condition problem in the old DOWNCASE. |
88043301 | 1558 | |
19ed5445 PE |
1559 | * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT): |
1560 | Rename locals to avoid shadowing. | |
1561 | (regex_compile, re_match_2_internal): Move locals to avoid shadowing. | |
abbd1bcf PE |
1562 | (regex_compile, re_search_2, re_match_2_internal): |
1563 | Remove unused local vars. | |
952db0d7 PE |
1564 | (FREE_VAR): Rewrite so as not to use empty "else", |
1565 | which gcc can warn about. | |
da053e48 | 1566 | (regex_compile, re_match_2_internal): Mark locals as initialized. |
b313f9d8 PE |
1567 | (RETALLOC_IF): Define only if needed. |
1568 | (WORDCHAR_P): Likewise. This one is never needed, but is used | |
1569 | only in a comment talking about a compiler bug, so put inside | |
1570 | the #if 0 of that comment. | |
1571 | (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK): | |
1572 | (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING): | |
1573 | Remove; unused. | |
19ed5445 | 1574 | |
1f3561e4 | 1575 | * search.c (boyer_moore): Rename locals to avoid shadowing. |
76ef09b7 PE |
1576 | * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE): |
1577 | (PREV_CHAR_BOUNDARY): Likewise. | |
1f3561e4 | 1578 | |
ded6f8f7 PE |
1579 | * search.c (simple_search): Remove unused var. |
1580 | ||
dbd37a95 PE |
1581 | * dired.c (compile_pattern): Move decl from here ... |
1582 | * lisp.h: ... to here, so that it can be checked. | |
1583 | (struct re_registers): New forward decl. | |
1584 | ||
7e47afad PE |
1585 | * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing. |
1586 | ||
85f24f61 PE |
1587 | * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width. |
1588 | All uses changed. | |
1589 | (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion): | |
1590 | Rename locals to avoid shadowing. | |
5671df8f | 1591 | (Fvertical_motion): Mark locals as initialized. |
85f24f61 | 1592 | |
181aa2be | 1593 | * casefiddle.c (casify_object, casify_region): Now static. |
e45a141a | 1594 | (casify_region): Mark local as initialized. |
181aa2be | 1595 | |
930d429c PE |
1596 | * cmds.c (internal_self_insert): Rename local to avoid shadowing. |
1597 | ||
7082eac6 PE |
1598 | * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR): |
1599 | New macros, so that the caller can use some names other than | |
1600 | gcpro1, gcpro2, etc. | |
1601 | (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms | |
1602 | of the new macros. | |
1603 | (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second | |
1604 | argument, for consistency with GCPRO2_VAR, etc: it is now the | |
1605 | prefix of the variable, not the variable itself. All uses | |
1606 | changed. | |
38b2c076 PE |
1607 | * dired.c (directory_files_internal, file_name_completion): |
1608 | Rename locals to avoid shadowing. | |
1609 | ||
15206ed9 PE |
1610 | Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254). |
1611 | An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in | |
1612 | dired.c's scmp function, had undefined behavior. | |
1613 | * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP): | |
1614 | (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ... | |
1615 | * buffer.h: ... to here, because these macros use current_buffer, | |
1616 | and the new implementation with inline functions needs to have | |
1617 | current_buffer in scope now, rather than later when the macros | |
1618 | are used. | |
1619 | (downcase, upcase1): New static inline functions. | |
1620 | (DOWNCASE, UPCASE1): Reimplement using these functions. | |
1621 | This avoids undefined behavior in expressions like | |
1622 | DOWNCASE (x) == DOWNCASE (y), which previously suffered | |
1623 | from race conditions in accessing the global variables | |
1624 | case_temp1 and case_temp2. | |
1625 | * casetab.c (case_temp1, case_temp2): Remove; no longer needed. | |
1626 | * lisp.h (case_temp1, case_temp2): Remove their decls. | |
1627 | * character.h (ASCII_CHAR_P): Move from here ... | |
1628 | * lisp.h: ... to here, so that the inline functions mentioned | |
1629 | above can use them. | |
1630 | ||
4a6bea26 PE |
1631 | * dired.c (directory_files_internal_unwind): Now static. |
1632 | ||
f14b7e14 PE |
1633 | * fileio.c (file_name_as_directory, directory_file_name): |
1634 | (barf_or_query_if_file_exists, auto_save_error, auto_save_1): | |
1635 | Now static. | |
2893f146 PE |
1636 | (file_name_as_directory): Use const pointers when appropriate. |
1637 | (Fexpand_file_name): Likewise. In particular, newdir might | |
1638 | point at constant storage, so make it a const pointer. | |
fd4ead52 | 1639 | (Fmake_directory_internal, Fread_file_name): Remove unused vars. |
b14aac08 PE |
1640 | (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer |
1641 | signedness issues. | |
f839df0c PE |
1642 | (Fset_file_times, Finsert_file_contents, auto_save_error): |
1643 | Rename locals to avoid shadowing. | |
f14b7e14 | 1644 | |
5716756e | 1645 | * minibuf.c (choose_minibuf_frame_1): Now static. |
62137a95 PE |
1646 | (Ftry_completion, Fall_completions): Rename or remove locals |
1647 | to avoid shadowing. | |
5716756e | 1648 | |
b4c3046a PE |
1649 | * marker.c (bytepos_to_charpos): Remove; unused. |
1650 | ||
b45db522 PE |
1651 | * lisp.h (verify_bytepos, count_markers): New decls, |
1652 | so that gcc does not warn that these functions aren't declared. | |
1653 | ||
85876d07 PE |
1654 | * insdel.c (check_markers, make_gap_larger, make_gap_smaller): |
1655 | (reset_var_on_error, Fcombine_after_change_execute_1): Now static. | |
f0cb4a60 | 1656 | (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic. |
40ef059e | 1657 | (copy_text): Remove unused local var. |
85876d07 | 1658 | |
03d78a21 | 1659 | * filelock.c (within_one_second): Now static. |
b3dd38ab | 1660 | (lock_file_1): Rename local to avoid shadowing. |
03d78a21 | 1661 | |
5df8f01b PE |
1662 | * buffer.c (fix_overlays_before): Mark locals as initialized. |
1663 | (fix_start_end_in_overlays): Likewise. This function should be | |
1664 | simplified by using pointers-to-pointers, but that's a different | |
1665 | matter. | |
b1d876f1 | 1666 | (switch_to_buffer_1): Now static. |
8f54f30a PE |
1667 | (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte): |
1668 | (report_overlay_modification): Rename locals to avoid shadowing. | |
c3bd59b5 | 1669 | |
a70072c9 | 1670 | * sysdep.c (system_process_attributes): Rename vars to avoid shadowing. |
fbd02d7b | 1671 | Fix pointer signedness issue. |
edced198 PE |
1672 | (sys_subshell): Mark local as volatile if checking for lint, |
1673 | to suppress a gcc -Wclobbered warning that does not seem to be right. | |
15dfd3d9 | 1674 | (MAXPATHLEN): Define only if needed. |
a70072c9 | 1675 | |
a0977c44 PE |
1676 | * process.c (serial_open, serial_configure): Move decls from here ... |
1677 | * systty.h: ... to here, so that they can be checked. | |
1678 | ||
a884fdcc PE |
1679 | * fns.c (get_random, seed_random): Move extern decls from here ... |
1680 | * lisp.h: ... to here, so that they can be checked. | |
1681 | ||
604efe86 | 1682 | * sysdep.c (reset_io): Now static. |
b8950c94 | 1683 | (wait_for_termination_signal): Remove; unused. |
604efe86 | 1684 | |
38fc62d9 PE |
1685 | * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal): |
1686 | (copy_keymap_item, append_key, push_text_char_description): | |
1687 | Now static. | |
1004a21a | 1688 | (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily. |
dbbb8427 | 1689 | (DENSE_TABLE_SIZE): Remove; unused. |
c1141155 PE |
1690 | (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal): |
1691 | (describe_map_tree): | |
1692 | Rename locals to avoid shadowing. | |
38fc62d9 | 1693 | |
2f2650da PE |
1694 | * keyboard.c: Declare functions static if they are not used elsewhere. |
1695 | (echo_char, echo_dash, cmd_error, top_level_2): | |
1696 | (poll_for_input, handle_async_input): Now static. | |
69a058fa PE |
1697 | (read_char, kbd_buffer_get_event, make_lispy_position): |
1698 | (make_lispy_event, make_lispy_movement, apply_modifiers): | |
1699 | (decode_keyboard_code, tty_read_avail_input, menu_bar_items): | |
1700 | (parse_tool_bar_item, read_key_sequence, Fread_key_sequence): | |
1701 | (Fread_key_sequence_vector): Rename locals to avoid shadowing. | |
c8a06054 | 1702 | (read_key_sequence, read_char): Mark locals as initialized. |
3ac94672 | 1703 | (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN. |
2f2650da | 1704 | |
a053e86c | 1705 | * keyboard.h (make_ctrl_char): New decl. |
da2f2dd9 PE |
1706 | (mark_kboards): Move decl here ... |
1707 | * alloc.c (mark_kboards): ... from here. | |
a053e86c | 1708 | |
4752793e PE |
1709 | * lisp.h (force_auto_save_soon): New decl. |
1710 | ||
74f10ca7 | 1711 | * emacs.c (init_cmdargs): Rename local to avoid shadowing. |
244fc23d PE |
1712 | (DEFINE_DUMMY_FUNCTION): New macro. |
1713 | (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main): | |
1714 | Use it. | |
c03cd23f PE |
1715 | (main): Add casts to avoid warnings |
1716 | if GCC considers string literals to be constants. | |
74f10ca7 | 1717 | |
022e70d4 PE |
1718 | * lisp.h (fatal_error_signal): Add decl, since it's exported. |
1719 | ||
59d6fe83 PE |
1720 | * dbusbind.c: Pointer signedness fixes. |
1721 | (xd_signature, xd_append_arg, xd_initialize): | |
1722 | (Fdbus_call_method, Fdbus_call_method_asynchronously): | |
1723 | (Fdbus_method_return_internal, Fdbus_method_error_internal): | |
1724 | (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service): | |
1725 | (Fdbus_register_signal): Use SSDATA when the context wants char *. | |
1726 | ||
78320123 PE |
1727 | * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning |
1728 | if GCC considers string literals to be constants. | |
49cebcca | 1729 | (Fdbus_register_service, Fdbus_register_method): Remove unused vars. |
78320123 | 1730 | |
35ac2a97 SM |
1731 | 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca> |
1732 | ||
fb103ca9 SM |
1733 | * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro. |
1734 | (print_preprocess, print_object): New macro to fix last change. | |
1735 | ||
35ac2a97 SM |
1736 | * print.c (print_preprocess): Don't forget font objects. |
1737 | ||
62973b41 JB |
1738 | 2011-03-16 Juanma Barranquero <lekktu@gmail.com> |
1739 | ||
1740 | * emacs.c (USAGE3): Doc fixes. | |
1741 | ||
0e48bb22 AS |
1742 | 2011-03-15 Andreas Schwab <schwab@linux-m68k.org> |
1743 | ||
1744 | * coding.c (detect_coding_iso_2022): Reorganize code to clarify | |
1745 | structure. | |
1746 | ||
7684e57b JB |
1747 | 2011-03-14 Juanma Barranquero <lekktu@gmail.com> |
1748 | ||
1749 | * lisp.h (VWindow_system, Qfile_name_history): | |
1750 | * keyboard.h (lispy_function_keys) [WINDOWSNT]: | |
1751 | * w32term.h (w32_system_caret_hwnd, w32_system_caret_height) | |
1752 | (w32_system_caret_x, w32_system_caret_y): Declare extern. | |
1753 | ||
1754 | * w32select.c: Don't #include "keyboard.h". | |
c96bbc66 | 1755 | (run_protected): Add extern declaration for waiting_for_input. |
7684e57b JB |
1756 | |
1757 | * w32.c (Qlocal, noninteractive1, inhibit_window_system): | |
1758 | * w32console.c (detect_input_pending, read_input_pending) | |
1759 | (encode_terminal_code): | |
1760 | * w32fns.c (quit_char, lispy_function_keys, Qtooltip) | |
1761 | (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x) | |
1762 | (w32_system_caret_y, Qfile_name_history): | |
1763 | * w32font.c (w32font_driver, QCantialias, QCotf, QClang): | |
1764 | * w32inevt.c (reinvoke_input_signal, lispy_function_keys): | |
1765 | * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map) | |
1766 | (Qoverriding_terminal_local_map, Qmenu_bar_update_hook): | |
1767 | * w32proc.c (Qlocal, report_file_error): | |
1768 | * w32term.c (Vwindow_system, updating_frame): | |
1769 | * w32uniscribe.c (initialized, uniscribe_font_driver): | |
1770 | Remove unneeded extern declarations. | |
1771 | ||
2aa46d6c CY |
1772 | 2011-03-14 Chong Yidong <cyd@stupidchicken.com> |
1773 | ||
c96bbc66 | 1774 | * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions. |
2aa46d6c | 1775 | |
cffc6f3b CY |
1776 | 2011-03-13 Chong Yidong <cyd@stupidchicken.com> |
1777 | ||
1778 | * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT) | |
1779 | (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219). | |
1780 | These macros can no longer be used for assignment. | |
1781 | ||
44f230aa SM |
1782 | * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): |
1783 | Assign struct members directly, instead of using BUF_BEGV etc. | |
cffc6f3b CY |
1784 | (record_buffer_markers, fetch_buffer_markers): New functions for |
1785 | recording and fetching special buffer markers. | |
1786 | (set_buffer_internal_1, set_buffer_temp): Use them. | |
1787 | ||
1788 | * lread.c (unreadchar): Use SET_BUF_PT_BOTH. | |
1789 | ||
1790 | * insdel.c (adjust_point): Use SET_BUF_PT_BOTH. | |
1791 | ||
1792 | * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH. | |
1793 | (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH. | |
1794 | ||
1795 | * xdisp.c (hscroll_window_tree): | |
1796 | (reconsider_clip_changes): Use PT instead of BUF_PT. | |
1797 | ||
d251f04b EZ |
1798 | 2011-03-13 Eli Zaretskii <eliz@gnu.org> |
1799 | ||
1800 | * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on | |
1801 | $(EMACS_ROOT)/lib/intprops.h. | |
1802 | ||
f0c77cd1 PE |
1803 | 2011-03-13 Paul Eggert <eggert@cs.ucla.edu> |
1804 | ||
3eca4629 PE |
1805 | Fix more problems found by GCC 4.5.2's static checks. |
1806 | ||
7c86ee98 PE |
1807 | * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char * |
1808 | to unsigned char * to avoid compiler diagnostic. | |
b0afc268 PE |
1809 | (xg_free_frame_widgets): Make it clear that a local variable is |
1810 | needed only if USE_GTK_TOOLTIP. | |
01e0b5ad PE |
1811 | (gdk_window_get_screen): Make it clear that this macro is needed |
1812 | only if USE_GTK_TOOLTIP. | |
1e5524e7 PE |
1813 | (int_gtk_range_get_value): New function, which avoids a diagnostic |
1814 | from gcc -Wbad-function-cast. | |
1815 | (xg_set_toolkit_scroll_bar_thumb): Use it. | |
1816 | (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid | |
1817 | diagnostic from gcc -Wbad-function-cast. | |
65dc836c PE |
1818 | (get_utf8_string, xg_get_file_with_chooser): |
1819 | Rename locals to avoid shadowing. | |
1820 | (create_dialog): Move locals to avoid shadowing. | |
7c86ee98 | 1821 | |
41729b81 PE |
1822 | * xgselect.c (xg_select): Remove unused var. |
1823 | ||
f0c77cd1 PE |
1824 | * image.c (four_corners_best): Mark locals as initialized. |
1825 | (gif_load): Initialize transparent_p to zero (Bug#8238). | |
1826 | Mark another local as initialized. | |
ec6cf4c6 | 1827 | (my_png_error, my_error_exit): Mark with NO_RETURN. |
f0c77cd1 | 1828 | |
ce0ad53d | 1829 | * image.c (clear_image_cache): Now static. |
d5d5a617 | 1830 | (DIM, HAVE_STDLIB_H_1): Remove unused macros. |
e22cffbc | 1831 | (xpm_load): Redo to avoid "discards qualifiers" gcc warning. |
77a765fd PE |
1832 | (x_edge_detection): Remove unnecessary cast that |
1833 | gcc -Wbad-function-cast diagnoses. | |
2037898d | 1834 | (gif_load): Fix pointer signedness. |
6ae141d6 PE |
1835 | (clear_image_cache, xbm_read_bitmap_data, x_detect_edges): |
1836 | (jpeg_load, gif_load): Rename locals to avoid shadowing. | |
ce0ad53d | 1837 | |
33383987 | 1838 | 2011-03-12 Paul Eggert <eggert@cs.ucla.edu> |
3eca4629 | 1839 | |
d32df629 PE |
1840 | Improve quality of tests for time stamp overflow. |
1841 | For example, without this patch (encode-time 0 0 0 1 1 | |
1842 | 1152921504606846976) returns the obviously-bogus value (-948597 | |
1843 | 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly | |
1844 | reports time overflow. See | |
1845 | <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>. | |
b8d9bd41 PE |
1846 | * deps.mk (editfns.o): Depend on ../lib/intprops.h. |
1847 | * editfns.c: Include limits.h and intprops.h. | |
1848 | (TIME_T_MIN, TIME_T_MAX): New macros. | |
1849 | (time_overflow): Move earlier, to before first use. | |
1850 | (hi_time, lo_time): New functions, for an accurate test for | |
1851 | out-of-range times. | |
1852 | (Fcurrent_time, Fget_internal_run_time, make_time): Use them. | |
1853 | (Fget_internal_run_time): Don't assume time_t fits in int. | |
1854 | (make_time): Use list2 instead of Fcons twice. | |
1855 | (Fdecode_time): More accurate test for out-of-range times. | |
1856 | (check_tm_member): New function. | |
1857 | (Fencode_time): Use it, to test for out-of-range times. | |
d32df629 PE |
1858 | (lisp_time_argument): Don't rely on undefined left-shift and |
1859 | right-shift behavior when checking for time stamp overflow. | |
8be6f318 | 1860 | |
fe31d94c PE |
1861 | * editfns.c (time_overflow): New function, refactoring common code. |
1862 | (Fformat_time_string, Fdecode_time, Fencode_time): | |
1863 | (Fcurrent_time_string): Use it. | |
1864 | ||
8be6f318 PE |
1865 | Move 'make_time' to be next to its inverse 'lisp_time_argument'. |
1866 | * dired.c (make_time): Move to ... | |
1867 | * editfns.c (make_time): ... here. | |
1868 | * systime.h: Note the move. | |
1869 | ||
09d9db2c | 1870 | 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
c47cbdfd | 1871 | |
126bc0dc YM |
1872 | * fringe.c (update_window_fringes): Remove unused variables. |
1873 | ||
c47cbdfd YM |
1874 | * unexmacosx.c (copy_data_segment): Also copy __got section. |
1875 | (Bug#8223) | |
1876 | ||
7ac80be9 EZ |
1877 | 2011-03-12 Eli Zaretskii <eliz@gnu.org> |
1878 | ||
c96bbc66 | 1879 | * termcap.c [MSDOS]: Include "msdos.h". |
058e5dad EZ |
1880 | (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent): |
1881 | Constify `char *' arguments and their references according to | |
1882 | prototypes in tparam.h. | |
1883 | ||
ecb0f94d | 1884 | * deps.mk (termcap.o): Depend on tparam.h and msdos.h. |
058e5dad | 1885 | |
7ac80be9 EZ |
1886 | * msdos.c (XMenuAddPane): 3rd argument is `const char *' now. |
1887 | Adapt all references accordingly. | |
1888 | ||
1889 | * msdos.h (XMenuAddPane): 3rd argument is `const char *' now. | |
1890 | ||
ef1fd07e TT |
1891 | 2011-03-11 Tom Tromey <tromey@redhat.com> |
1892 | ||
1893 | * buffer.c (syms_of_buffer): Remove obsolete comment. | |
1894 | ||
7ef4b50c EZ |
1895 | 2011-03-11 Eli Zaretskii <eliz@gnu.org> |
1896 | ||
1897 | * termhooks.h (encode_terminal_code): Declare prototype. | |
1898 | ||
1899 | * msdos.c (encode_terminal_code): Don't declare prototype. | |
1900 | ||
1901 | * term.c (encode_terminal_code): Now external again, used by | |
1902 | w32console.c and msdos.c. | |
1903 | ||
44f230aa SM |
1904 | * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): |
1905 | Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu. | |
7ef4b50c | 1906 | |
4b1ec863 | 1907 | 2011-03-11 Paul Eggert <eggert@cs.ucla.edu> |
f78faa98 | 1908 | |
1714f52b | 1909 | Fix some minor problems found by GCC 4.5.2's static checks. |
83316bf4 | 1910 | |
4b1ec863 PE |
1911 | * fringe.c (update_window_fringes): Mark locals as initialized |
1912 | (Bug#8227). | |
1913 | (destroy_fringe_bitmap, init_fringe_bitmap): Now static. | |
bf60f616 | 1914 | |
524c7aa6 PE |
1915 | * alloc.c (mark_fringe_data): Move decl from here ... |
1916 | * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here, | |
1917 | to check its interface. | |
1918 | (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM. | |
1919 | ||
a5c0af81 | 1920 | * fontset.c (free_realized_fontset): Now static. |
7519b8cd | 1921 | (Fset_fontset_font): Rename local to avoid shadowing. |
cc6e5db1 | 1922 | (fontset_font): Mark local as initialized. |
a9a06e0b | 1923 | (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused. |
a5c0af81 | 1924 | |
b4716021 PE |
1925 | * xrdb.c: Include "xterm.h", to check x_load_resources's interface. |
1926 | ||
811e9bac | 1927 | * xselect.c (x_disown_buffer_selections): Remove; not used. |
7b83e2f1 | 1928 | (TRACE3) [!defined TRACE_SELECTION]: Remove; not used. |
aa0daa9f PE |
1929 | (x_own_selection, Fx_disown_selection_internal): Rename locals |
1930 | to avoid shadowing. | |
1931 | (x_handle_dnd_message): Remove local to avoid shadowing. | |
811e9bac | 1932 | |
7e3ab302 PE |
1933 | * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros, |
1934 | so that the caller can use some name other than gcpro1. | |
1935 | (GCPRO1, UNGCPRO): Reimplement in terms of the new macros. | |
58d2d479 PE |
1936 | * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip): |
1937 | (Fx_backspace_delete_keys_p): | |
1938 | Use them to avoid shadowing, and rename vars to avoid shadowing. | |
1939 | (x_decode_color, x_set_name, x_window): Now static. | |
6b437900 | 1940 | (Fx_create_frame): Add braces to silence GCC warning. |
c0951e53 | 1941 | (Fx_file_dialog, Fx_select_font): Fix pointer signedness. |
06b0c8a0 PE |
1942 | (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame): |
1943 | Remove unused locals. | |
7e3ab302 PE |
1944 | (Fx_create_frame, x_create_tip_frame, Fx_show_tip): |
1945 | (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing. | |
1946 | Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR | |
1947 | macros. | |
f78faa98 | 1948 | |
e2b13473 PE |
1949 | * xterm.h (x_mouse_leave): New decl. |
1950 | ||
77f23912 PE |
1951 | * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame): |
1952 | Remove unused functions. | |
cdf4ba58 PE |
1953 | (x_shift_glyphs_for_insert, XTflash, XTring_bell): |
1954 | (x_calc_absolute_position): Now static. | |
7411c686 | 1955 | (XTread_socket): Don't define label "out" unless it's used. |
2b07bcff | 1956 | Don't declare local "event" unless it's used. |
ed7bf3a5 PE |
1957 | (x_iconify_frame, x_free_frame_resources): Don't declare locals |
1958 | unless they are used. | |
38d0b34a PE |
1959 | (XEMBED_VERSION, xembed_set_info): Don't define unless needed. |
1960 | (x_fatal_error_signal): Remove; not used. | |
a6067996 PE |
1961 | (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position): |
1962 | (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor): | |
1963 | (x_error_catcher, x_connection_closed, x_error_handler): | |
1964 | (x_error_quitter, xembed_send_message, x_iconify_frame): | |
1965 | (my_log_handler): Rename locals to avoid shadowing. | |
28f1c698 | 1966 | (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN. |
2a8fade0 | 1967 | (x_connection_closed): Tell GCC not to suggest NO_RETURN. |
77f23912 | 1968 | |
44f230aa SM |
1969 | * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): |
1970 | Rename or move locals to avoid shadowing. | |
6b463e58 | 1971 | (tty_defined_color, merge_face_heights): Now static. |
5967d051 | 1972 | (free_realized_faces_for_fontset): Remove; not used. |
1e9966ea PE |
1973 | (Fx_list_fonts): Mark variable that gcc -Wuninitialized |
1974 | does not deduce is never used uninitialized. | |
73719eba PE |
1975 | (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used. |
1976 | (LFACEP): Define only if XASSERTS, as it's not needed otherwise. | |
071048a3 | 1977 | |
426994c3 | 1978 | * terminal.c (store_terminal_param): Now static. |
5489860b | 1979 | |
032f1620 | 1980 | * xmenu.c (menu_highlight_callback): Now static. |
9d66f88e | 1981 | (set_frame_menubar): Remove unused local. |
d4323972 | 1982 | (xmenu_show): Rename parameter to avoid shadowing. |
6d1f7fee PE |
1983 | (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const" |
1984 | since they might point to immutable storage. | |
281585b0 PE |
1985 | (next_menubar_widget_id): Declare only if USE_X_TOOLKIT, |
1986 | since it's unused otherwise. | |
032f1620 | 1987 | |
367c19e5 | 1988 | * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff. |
53df7c11 | 1989 | Add a FIXME, since the code still doesn't look right. (Bug#8215) |
9f36b9fd PE |
1990 | (Fcurrent_bidi_paragraph_direction): Simplify slightly; this |
1991 | avoids a gcc -Wuninitialized diagnostic. | |
0e086e8f | 1992 | (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs): |
44a3a108 PE |
1993 | (note_mouse_highlight): Mark variables that gcc -Wuninitialized |
1994 | does not deduce are never used uninitialized. | |
70739cbe | 1995 | |
07b48fa9 PE |
1996 | * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c. |
1997 | ||
8868a238 | 1998 | * xdisp.c (redisplay_window): Rename local to avoid shadowing. |
4554d213 PE |
1999 | * window.c (window_loop, size_window): |
2000 | (run_window_configuration_change_hook, enlarge_window): Likewise. | |
8868a238 | 2001 | |
7e5cf297 | 2002 | * window.c (display_buffer): Now static. |
d6550a9f PE |
2003 | (size_window): Mark variables that gcc -Wuninitialized |
2004 | does not deduce are never used uninitialized. | |
a586633d PE |
2005 | * window.h (check_all_windows): New decl, to forestall |
2006 | gcc -Wmissing-prototypes diagnostic. | |
5b555da1 | 2007 | * dispextern.h (bidi_dump_cached_states): Likewise. |
7e5cf297 | 2008 | |
f6095868 PE |
2009 | * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid |
2010 | shadowing. | |
2011 | * charset.c (map_charset_for_dump, Fchar_charset): Likewise. | |
726929c4 PE |
2012 | Include <limits.h>. |
2013 | (Fsort_charsets): Redo min/max calculation to shorten the code a bit | |
2014 | and to avoid gcc -Wuninitialized warning. | |
89ef49df PE |
2015 | (load_charset_map): Mark variables that gcc -Wuninitialized |
2016 | does not deduce are never used uninitialized. | |
53df7c11 | 2017 | (load_charset): Abort instead of using uninitialized var (Bug#8229). |
f6095868 | 2018 | |
f38b440c PE |
2019 | * coding.c (coding_set_source, coding_set_destination): |
2020 | Use "else { /* comment */ }" rather than "else /* comment */;" | |
2021 | for clarity, and to avoid gcc -Wempty-body warning. | |
2735d060 PE |
2022 | (Fdefine_coding_system_internal): Don't redeclare 'i' inside |
2023 | a block, when the outer 'i' will do. | |
2024 | (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule): | |
2025 | (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022): | |
2026 | (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5): | |
2027 | (decode_coding_raw_text, decode_coding_charset, get_translation_table): | |
2028 | (Fdecode_sjis_char, Fdefine_coding_system_internal): | |
2029 | Rename locals to avoid shadowing. | |
2030 | * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise. | |
e2f1bab9 PE |
2031 | * coding.c (emacs_mule_char, encode_invocation_designation): |
2032 | Now static, since they're not used elsewhere. | |
413bb2db | 2033 | (decode_coding_iso_2022): Add "default: abort ();" as a safety check. |
c4a63b12 | 2034 | (decode_coding_object, encode_coding_object, detect_coding_system): |
ee05f961 PE |
2035 | (decode_coding_emacs_mule): Mark variables that gcc |
2036 | -Wuninitialized does not deduce are never used uninitialized. | |
160b01f6 PE |
2037 | (detect_coding_iso_2022): Initialize a local variable that might |
2038 | be used uninitialized. Leave a FIXME because it's not clear that | |
53df7c11 | 2039 | this initialization is needed. (Bug#8211) |
5f58e762 PE |
2040 | (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT): |
2041 | (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P): | |
2042 | (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER): | |
2043 | (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R): | |
2044 | Remove unused macros. | |
f38b440c | 2045 | |
232b38b9 | 2046 | * category.c (hash_get_category_set): Remove unused local var. |
9f3b5e69 | 2047 | (copy_category_table): Now static, since it's not used elsewhere. |
d0891610 | 2048 | * character.c (string_count_byte8): Likewise. |
232b38b9 | 2049 | |
fb90da1b PE |
2050 | * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string): |
2051 | (Fregister_code_conversion_map): Rename locals to avoid shadowing. | |
2052 | ||
fb93dbc2 PE |
2053 | * chartab.c (copy_sub_char_table): Now static, since it's not used |
2054 | elsewhere. | |
5c156ace PE |
2055 | (sub_char_table_ref_and_range, char_table_ref_and_range): |
2056 | Rename locals to avoid shadowing. | |
bbcd0949 | 2057 | (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros. |
fb93dbc2 | 2058 | |
7d3b3862 | 2059 | * bidi.c (bidi_check_type): Now static, since it's not used elsewhere. |
630d6892 | 2060 | (BIDI_BOB): Remove unused macro. |
7d3b3862 | 2061 | |
6be7d3da PE |
2062 | * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not |
2063 | deduce are never used uninitialized. | |
c2ed9c8b | 2064 | * term.c (encode_terminal_code): Likewise. |
6be7d3da | 2065 | |
75f8807f | 2066 | * term.c (encode_terminal_code): Now static. Remove unused local. |
72abad34 | 2067 | |
50938595 PE |
2068 | * tparam.h: New file. |
2069 | * term.c, tparam.h: Include it. | |
2070 | * deps.mk (term.o, tparam.o): Depend on tparam.h. | |
2071 | * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr): | |
2072 | Move these decls to tparam.h, and make them agree with what | |
2073 | is actually in tparam.c. The previous trick of using incompatible | |
2074 | decls in different modules does not conform to the C standard. | |
2075 | All callers of tparam changed to use tparam's actual API. | |
2076 | * tparam.c (tparam1, tparam, tgoto): | |
2077 | Use const pointers where appropriate. | |
2078 | ||
fbceeba2 PE |
2079 | * cm.c (calccost, cmgoto): Use const pointers where appropriate. |
2080 | * cm.h (struct cm): Likewise. | |
2081 | * dispextern.h (do_line_insertion_deletion_costs): Likewise. | |
2082 | * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise. | |
2083 | * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table): | |
2084 | (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph): | |
2085 | (turn_on_face, init_tty): Likewise. | |
2086 | * termchar.h (struct tty_display_info): Likewise. | |
fbceeba2 | 2087 | |
7f3f1250 PE |
2088 | * term.c (term_mouse_position): Rename local to avoid shadowing. |
2089 | ||
e6ca6543 PE |
2090 | * alloc.c (mark_ttys): Move decl from here ... |
2091 | * lisp.h (mark_ttys): ... to here, so that it's checked against defn. | |
2092 | ||
c40f8d15 AS |
2093 | 2011-03-11 Andreas Schwab <schwab@linux-m68k.org> |
2094 | ||
2095 | * .gdbinit (pwinx, xbuffer): Fix access to buffer name. | |
2096 | ||
cfe0661d JB |
2097 | 2011-03-09 Juanma Barranquero <lekktu@gmail.com> |
2098 | ||
2099 | * search.c (compile_pattern_1): Remove argument regp, unused since | |
2100 | revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig. | |
2101 | (compile_pattern): Don't pass it. | |
2102 | ||
0afb4571 J |
2103 | 2011-03-08 Jan Djärv <jan.h.d@swipnet.se> |
2104 | ||
2105 | * xterm.h (DEFAULT_GDK_DISPLAY): New define. | |
2106 | (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines | |
2107 | for ! HAVE_GTK3. | |
2108 | (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID. | |
2109 | ||
2110 | * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size. | |
2111 | ||
2112 | * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define | |
2113 | gdk_window_get_screen, gdk_window_get_geometry, | |
2114 | gdk_x11_window_lookup_for_display and GDK_KEY_g. | |
2115 | (xg_set_screen): Use DEFAULT_GDK_DISPLAY. | |
2116 | (xg_get_pixbuf_from_pixmap): New function. | |
2117 | (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap | |
2118 | to Pixmap, take frame as parameter, remove GdkColormap parameter. | |
2119 | Call xg_get_pixbuf_from_pixmap instead of | |
2120 | gdk_pixbuf_get_from_drawable. | |
2121 | (xg_get_image_for_pixmap): Do not make GdkPixmaps, call | |
2122 | xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead. | |
2123 | (xg_check_special_colors): Use GtkStyleContext and its functions | |
2124 | for HAVE_GTK3. | |
2125 | (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen. | |
2126 | (xg_prepare_tooltip, create_dialog, menubar_map_cb) | |
2127 | (xg_update_frame_menubar, xg_tool_bar_detach_callback) | |
44f230aa SM |
2128 | (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): |
2129 | Call gtk_widget_get_preferred_size. | |
0afb4571 J |
2130 | (xg_frame_resized): gdk_window_get_geometry only takes 5 |
2131 | parameters. | |
44f230aa SM |
2132 | (xg_win_to_widget, xg_event_is_for_menubar): |
2133 | Call gdk_x11_window_lookup_for_display. | |
0afb4571 J |
2134 | (xg_set_widget_bg): New function. |
2135 | (delete_cb): New function. | |
2136 | (xg_create_frame_widgets): connect delete-event to delete_cb. | |
2137 | Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3 | |
2138 | (xg_set_background_color): Call xg_set_widget_bg. | |
2139 | (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask. | |
2140 | (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3. | |
2141 | Only call gtk_range_set_update_policy if ! HAVE_GTK3. | |
2142 | (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback | |
2143 | if ! HAVE_GTK3. | |
2144 | (update_frame_tool_bar): Call gtk_widget_hide. | |
2145 | (xg_initialize): Use GDK_KEY_g. | |
2146 | ||
2147 | * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id | |
2148 | if ! HAVE_GTK3 | |
2149 | (x_session_initialize): Call gdk_x11_set_sm_client_id. | |
2150 | ||
2151 | * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3. | |
2152 | (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS. | |
2153 | Load ~/emacs.d/gtkrc only for ! HAVE_GTK3. | |
2154 | ||
1c2cc4ef JB |
2155 | 2011-03-08 Juanma Barranquero <lekktu@gmail.com> |
2156 | ||
2157 | * w32xfns.c (select_palette): Check success of RealizePalette against | |
2158 | GDI_ERROR, not zero. | |
2159 | ||
33383987 | 2160 | See ChangeLog.11 for earlier changes. |
aac0c6e3 MR |
2161 | |
2162 | ;; Local Variables: | |
2163 | ;; coding: utf-8 | |
aac0c6e3 MR |
2164 | ;; End: |
2165 | ||
33383987 | 2166 | Copyright (C) 2011 Free Software Foundation, Inc. |
aac0c6e3 MR |
2167 | |
2168 | This file is part of GNU Emacs. | |
2169 | ||
2170 | GNU Emacs is free software: you can redistribute it and/or modify | |
2171 | it under the terms of the GNU General Public License as published by | |
2172 | the Free Software Foundation, either version 3 of the License, or | |
2173 | (at your option) any later version. | |
2174 | ||
2175 | GNU Emacs is distributed in the hope that it will be useful, | |
2176 | but WITHOUT ANY WARRANTY; without even the implied warranty of | |
2177 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
2178 | GNU General Public License for more details. | |
2179 | ||
2180 | You should have received a copy of the GNU General Public License | |
2181 | along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. |