Fix documentation per bug #9949.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
89bd5ee1
EZ
12011-11-04 Eli Zaretskii <eliz@gnu.org>
2
3 * window.c (Fwindow_body_size): Mention in the doc string that the
4 return value is in frame's canonical units. (Bug#9949)
5
84c3edb9
EZ
62011-11-03 Eli Zaretskii <eliz@gnu.org>
7
4e2fb5c7
EZ
8 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9
84c3edb9 10 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 11 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 12 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 13
bc17a887
EZ
142011-11-01 Eli Zaretskii <eliz@gnu.org>
15
16 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
17 Don't stop backward scan on the continuation glyph, even though
18 its CHARPOS is positive.
26b46e51
EZ
19 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
20 cover_string to disp_string.
bc17a887 21
4ee88440
MR
222011-11-01 Martin Rudalics <rudalics@gmx.at>
23
24 * window.c (temp_output_buffer_show): Don't use
25 Vtemp_buffer_show_specifiers.
26 (Vtemp_buffer_show_specifiers): Remove unused variable.
27
c2ff3c02
EZ
282011-10-30 Eli Zaretskii <eliz@gnu.org>
29
30 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
31 past the beginning of the current glyph matrix.
32
6e56383b
JD
332011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
34
35 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
36 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
37 HAVE_GTK3 (Bug#9869).
b77a6a7f 38
3b574623
JD
39 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
40 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
41
b77a6a7f
JD
42 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
43
44 * xterm.c: Declare x_handle_net_wm_state to return int.
45 (handle_one_xevent): Check if we are iconified but don't have
46 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
47 (get_current_wm_state): Return non-zero if not hidden,
48 check for _NET_WM_STATE_HIDDEN (Bug#9893).
49 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
50 (x_handle_net_wm_state): Return what get_current_wm_state returns.
51 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
52
196e41e4
PE
532011-10-29 Paul Eggert <eggert@cs.ucla.edu>
54
55 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
56 so that this new function doesn't get optimized away by a
57 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
58
021f2e1a
AS
592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
60
61 * frame.h (MOUSE_HL_INFO): Remove excess parens.
62
8b058d44
EZ
632011-10-29 Eli Zaretskii <eliz@gnu.org>
64
65 Fix the `xbytecode' command.
66 * .gdbinit (xprintbytestr): New command.
67 (xwhichsymbols): Renamed from `which'; all callers changed.
68 (xbytecode): Print the byte-code string as well.
69
4452fb80
EZ
702011-10-29 Kim Storm <storm@cua.dk>
71
8b058d44
EZ
72 * alloc.c (which_symbols): New function.
73
21b72067
AS
742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
75
76 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
77 line. (Bug#9903)
78
83ed7b5c
GM
792011-10-29 Glenn Morris <rgm@gnu.org>
80
81 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
82 Not clear what it was for, and it causes various bugs. (Bug#9839)
83
5a7a728b
EZ
842011-10-28 Eli Zaretskii <eliz@gnu.org>
85
86 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
87 possible random value that matches one of those tested as
88 condition to clear the mouse face.
89
d3d0842f
CY
902011-10-28 Chong Yidong <cyd@gnu.org>
91
92 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
93
31b39d13
DN
942011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
95
96 * window.c (make_window): Initialize phys_cursor_on_p.
97
9aba6043
SM
982011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
99
100 * lisp.h (struct Lisp_Symbol): Update comments.
101
c20992f4
JB
1022011-10-28 Juanma Barranquero <lekktu@gmail.com>
103
104 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
105
db4f02f2
EZ
1062011-10-28 Eli Zaretskii <eliz@gnu.org>
107
108 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
109 <oslsachem@gmail.com> for helping to debug this.
110
111 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
112 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
113 (g_b_init_get_glyph_outline_w): New static variables.
114 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
115 (GetGlyphOutlineW_Proc): New typedefs.
116 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
117 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
118 New functions.
119 (w32font_open_internal, compute_metrics):
120 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
121 instead of calling the "wide" APIs directly.
122
123 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
124
125 * w32.h (syms_of_w32font): Add prototype.
126
87e68db4
JB
1272011-10-27 Juanma Barranquero <lekktu@gmail.com>
128
129 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
130 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
131 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
132 (Fmove_to_window_line): Doc fix.
133
435c1d67
CY
1342011-10-27 Chong Yidong <cyd@gnu.org>
135
136 * process.c (make_process): Set gnutls_state to NULL.
137
138 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
139 non-NULL, regardless of GNUTLS_INITSTAGE.
140 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
141 an error. Set process slots as soon as we allocate them.
142
143 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
144
9c6c6f49
CY
1452011-10-27 Chong Yidong <cyd@gnu.org>
146
9aba6043
SM
147 * gnutls.c (emacs_gnutls_deinit): New function.
148 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
149 (Fgnutls_deinit, Fgnutls_boot): Use it.
150
151 * process.c (make_process): Initialize GnuTLS credentials to NULL.
152 (deactivate_process): Call emacs_gnutls_deinit.
153
657d08d3
JB
1542011-10-27 Juanma Barranquero <lekktu@gmail.com>
155
156 * image.c (x_create_x_image_and_pixmap):
157 * w32.c (sys_rename, w32_delayed_load):
158 * w32font.c (fill_in_logfont):
159 * w32reg.c (x_get_string_resource): Silence compiler warnings.
160
5430d399
JB
1612011-10-26 Juanma Barranquero <lekktu@gmail.com>
162
163 * w32fns.c (w32_default_color_map): New function,
164 extracted from Fw32_default_color_map.
a7ef684b 165 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 166
fe0055fa
PE
1672011-10-25 Paul Eggert <eggert@cs.ucla.edu>
168
169 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
170
e6346438
SM
1712011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
172
173 * keyboard.c (test_undefined): New function (bug#9751).
174 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
175
e112cc37
ET
1762011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
177
178 * sysdep.c (init_sys_modes): Fix the check for the controlling
179 terminal (Bug#6649).
180
7b5d6677
EZ
1812011-10-20 Eli Zaretskii <eliz@gnu.org>
182
183 * dispextern.h (struct bidi_it): New member next_en_type.
184
185 * bidi.c (bidi_line_init): Initialize the next_en_type member.
186 (bidi_resolve_explicit_1): When next_en_pos is valid for the
187 current character, check also for next_en_type being WEAK_EN.
188 (bidi_resolve_weak): Don't enter the expensive loop if the current
189 position is before next_en_pos. Record the bidi type of the first
190 non-ET, non-BN character we find, in addition to its position.
191 (bidi_level_of_next_char): Invalidate next_en_type when
192 next_en_pos is over-stepped.
193
7da0b018
PE
1942011-10-20 Paul Eggert <eggert@cs.ucla.edu>
195
196 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
197 * editfns.c: Rewrite current-time-zone so that it invokes
198 the equivalent of (format-time-string "%Z") to get the time zone name.
199 This fixes a bug when the time zone name contains characters that
200 need converting from the system time locale to Emacs internal format.
201 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
202 that patch fixed format-time-string to do the conversion, but
203 I forgot to fix current-time-zone.
204 (format_time_string): New function, containing most of
205 what Fformat_time_string used to contain.
206 (Fformat_time_string): Rewrite in terms of format_time_string.
207 This doesn't change this function's behavior.
208 (current-time-zone): Rewrite to use format_time_string.
209 This fixes the bug reported by Michael Schierl in
210 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
211 Jason Rumney's 2007-06-07 change worked around this bug, but
212 didn't fix it.
213 * systime.h (tzname, timezone): Remove no-longer-used declarations.
214
8547b010
EZ
2152011-10-19 Eli Zaretskii <eliz@gnu.org>
216
217 * xdisp.c (start_display): If the character at POS is displayed
218 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
219 (try_window_reusing_current_matrix): If a line ends in a display
220 vector or the next line starts in a display vector, continue
221 redrawing the window even though the character position of
222 start_row was reached.
8547b010
EZ
223 (Bug#9771, part 2)
224
4e948d15
CY
2252011-10-18 Chong Yidong <cyd@gnu.org>
226
227 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
228 with nobreak-char-display too.
229
4787455f
EZ
2302011-10-18 Eli Zaretskii <eliz@gnu.org>
231
232 Fix part 3 of bug#9771.
233 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
234 (bidi_resolve_neutral): Don't enter the expensive loop looking for
235 non-neutral characters if the current character is a paragraph
236 separator (a.k.a. Newline). This avoids running the same
237 expensive loop twice, once when we consume the preceding newline
238 and the other time when the line actually needs to be displayed.
239 Avoid the loop when we see neutrals on the base embedding level
240 following a character whose directionality is the same as the
241 paragraph's. This avoids running the expensive loop when a line
242 ends in a long sequence of neutrals, like control characters.
243 Add assertion against STRONG_AL type. Slightly rearrange code
244 that determines the type of a neutral given the first non-neutral
245 that follows it.
246 (bidi_level_of_next_char): Set next_en_pos to zero when
247 invalidating its info.
248
2c91f553
EZ
2492011-10-17 Eli Zaretskii <eliz@gnu.org>
250
251 * xdisp.c (push_display_prop): Determine whether to record string
252 or buffer position by IT->string, not by IT->method. Allow
253 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
254 (move_it_vertically_backward): Don't look for character position
255 immediately after the newline when in a continuation line.
256 (Bug#9771, part 1)
2c91f553 257
c7b08b0d
MR
2582011-10-15 Martin Rudalics <rudalics@gmx.at>
259
260 * window.c (coordinates_in_window): Rewrite and delabelize
261 vertical border check. (Bug#5357) (Bug#9618)
262
6b02f655
SM
2632011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
264
265 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
266 errors in XSetWindowBorder (bug#9310).
267
81d40c92
DA
2682011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
269
270 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
271 avoid crash when xmalloc overrun checking is enabled.
272
d4172c3b
EZ
2732011-10-13 Eli Zaretskii <eliz@gnu.org>
274
275 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
276 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
277 cursor motion with <left> and <right> arrow keys.
278
279 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
280 some callers set that themselves.
281
b00eea75
EZ
2822011-10-12 Eli Zaretskii <eliz@gnu.org>
283
284 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
285 display string and the previous row comes from the same string and
286 is empty. (Bug#9739) (Bug#9738)
287
8fe012c4
SM
2882011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
289
290 * doc.c (get_doc_string): Encode file name (bug#9735).
291
0074aef2
EZ
2922011-10-12 Eli Zaretskii <eliz@gnu.org>
293
79beb178
EZ
294 * bidi.c (bidi_level_of_next_char):
295 * xdisp.c (get_visually_first_element): Remove old incorrect
296 comments regarding the Unicode Line Separator character.
297
0074aef2
EZ
298 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
299
6e4b3fbe
DA
3002011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
301
302 * alloc.c (Fgc_status): Do not access beyond zombies array
303 boundary if nzombies > MAX_ZOMBIES.
304 * alloc.c (dump_zombies): Add missing format specifier.
305
0324f3af
PE
3062011-10-12 Paul Eggert <eggert@cs.ucla.edu>
307
b5525cac
PE
308 * xdisp.c (set_cursor_from_row): Simplify conditionals,
309 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
310
0324f3af
PE
311 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
312 Some packages use them to denote characters with modifiers.
313
e9b5f888
AS
3142011-10-11 Andreas Schwab <schwab@linux-m68k.org>
315
316 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
317 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
318 matching a pp-number. Rename parameter var to var1.
319
127827c0
SM
3202011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
321
322 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
323
c8fd3bd0
GM
3242011-10-08 Glenn Morris <rgm@gnu.org>
325
326 * callint.c (Fcall_interactively): Give a more explicit error for the
327 'c' case with a non-character input. (Bug#8479)
328
352ec8ff
EZ
3292011-10-08 Eli Zaretskii <eliz@gnu.org>
330
03669ccb
EZ
331 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
332 lines.
7061c986
EZ
333 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
334 lines that are hscrolled on the left.
03669ccb 335
352ec8ff
EZ
336 * dispnew.c (buffer_posn_from_coords): Account for a possible
337 presence of header-line. (Bug#4426)
338
a66cfb1c
SM
3392011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
340
6b02f655
SM
341 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
342 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 343
7c5ee88e
PE
3442011-10-07 Paul Eggert <eggert@cs.ucla.edu>
345
346 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
347 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
348 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
349 this makes Emacs dump core during garbage collection on rare
350 occasions. sizeof is obviously inferior to offsetof here, so
351 stick with offsetof.
352 (GC_POINTER_ALIGNMENT): New macro.
353 (mark_memory): Omit 3rd (offset) arg; caller changed.
354 Don't assume EMACS_INT alignment is the same as pointer alignment.
355
df1bbe5b
SM
3562011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
357
358 * keyboard.c (read_key_sequence_remapped): New var.
359 (read_key_sequence): Compute remapping in the right buffer.
360 (command_loop_1): Use read_key_sequence's remapping directly.
361
51553db6
SM
3622011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
363
32c1fffd
SM
364 * dired.c (file_name_completion): Don't expand file name.
365 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
366 before checking file name handler.
367
51553db6
SM
368 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
369 they've been requested explicitly (bug#9591).
370
b6bd1599 3712011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
372
373 * keymap.c (Fsingle_key_description): Use make_specified_string
374 instead of build_string to build string from push_key_description.
375 (Bug#5193)
376
f701dc2a
PE
3772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
378
4222c55d
PE
379 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
380 This fixes a Y2038 bug on 64-bit hosts.
381 * buffer.c (reset_buffer):
382 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
383 (Fclear_buffer_auto_save_failure):
384 Use 0, not -1, to represent an unset failure time, since time_t
385 might not be signed.
386
f701dc2a
PE
387 Remove dependency on glibc malloc internals.
388 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
389 Move back here from lisp.h, but with their new implementations.
390 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
391 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
392 * charset.c (charset_table_init): New static var.
393 (syms_of_charset): Use it instead of xmalloc. This removes a
394 dependency on glibc malloc internals. See Eli Zaretskii's comment in
395 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
396 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
397 Move back to alloc.c.
398 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
399 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
400
9ceebf39
JD
4012011-09-30 Jan Djärv <jan.h.d@swipnet.se>
402
403 * nsterm.m (windowDidResize): Call x_set_window_size only when
404 ns_in_resize is true. Otherwise set pixelwidth/height and
405 call change_frame_size (Bug#9628).
406
cb993c58
PE
4072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
408
3930c88b
PE
409 Port --enable-checking=all to Fedora 14 x86-64.
410 * charset.c (syms_of_charset): Also account for glibc malloc's
411 internal overhead when calculating the initial malloc maximum.
412
cb993c58
PE
413 Port --enable-checking=all to Fedora 14 x86.
414 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
415 Move to lisp.h.
416 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
417 (overrun_check_realloc, overrun_check_free):
418 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
419 That way, xmalloc returns a properly-aligned pointer even if
420 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
421 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
422 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
423 into account when calculating the initial malloc maximum.
424 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
425 Move here from alloc.c, so that charset.c can use it too.
426 Properly align; the old code wasn't right for common 32-bit hosts
427 when configured with --enable-checking=all.
428 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
429 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
430
31bed486
EZ
4312011-09-29 Eli Zaretskii <eliz@gnu.org>
432
04c70788 433 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
434 use EDOM.
435
fbcaa2f3
EZ
4362011-09-28 Eli Zaretskii <eliz@gnu.org>
437
438 * xdisp.c (compute_display_string_end): If there's no display
439 string at CHARPOS, return -1.
440
441 * bidi.c (bidi_fetch_char): When compute_display_string_end
442 returns a negative value, treat the character as a normal
443 character not covered by a display string. (Bug#9624)
444
a239d4e9
JB
4452011-09-28 Juanma Barranquero <lekktu@gmail.com>
446
447 * lread.c (Fread_from_string): Fix typo in docstring.
448
88652fd5
EZ
4492011-09-27 Eli Zaretskii <eliz@gnu.org>
450
451 * xdisp.c (handle_invisible_prop): If invisible text ends on a
452 newline, reseat the iterator instead of bidi-iterating there one
453 character at a time. (Bug#9610)
32c1fffd
SM
454 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
455 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 456
ed497dd4
AS
4572011-09-27 Andreas Schwab <schwab@linux-m68k.org>
458
459 * lread.c (readevalloop): Use correct code for NBSP.
460 (read1): Likewise. (Bug#9608)
461
b2bf61aa
MA
4622011-09-25 Michael Albinus <michael.albinus@gmx.de>
463
464 * dbusbind.c (Fdbus_register_signal): When service is not
465 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
466
32bbb17c
GM
4672011-09-25 Glenn Morris <rgm@gnu.org>
468
469 * buffer.c (truncate-lines): Doc fix.
470
94e0933e
CY
4712011-09-24 Chong Yidong <cyd@stupidchicken.com>
472
473 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
474 (Fset_window_next_buffers): Doc fix.
475
cddde921
GM
4762011-09-24 Glenn Morris <rgm@gnu.org>
477
478 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
479
1260aef1
PE
4802011-09-24 Paul Eggert <eggert@cs.ucla.edu>
481
25b4bfa0
PE
482 Fix minor problems found by static checking.
483 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
484 * indent.c (Fvertical_motion): Fix == vs = typo.
485
e3cbd34b
EZ
4862011-09-24 Eli Zaretskii <eliz@gnu.org>
487
a66cfb1c
SM
488 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
489 Default value is now t. Doc fix.
6bf7006f 490
e3cbd34b 491 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 492 logic when moving up, not only when moving down. Fix the
e3cbd34b 493 confusing name and values of the it_overshoot_expected variable;
32c1fffd 494 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
495
496 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
497 CHARPOS is covered by a display string which includes newlines.
498 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
499 is covered by a display string with embedded newlines.
500
a3de0cbd
MA
5012011-09-24 Michael Albinus <michael.albinus@gmx.de>
502
503 * dbusbind.c (Fdbus_register_signal): Add match rule to
504 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
505 (Fdbus_register_method, Vdbus_registered_objects_table):
506 Fix docstring.
a3de0cbd 507
b260039d
JM
5082011-09-24 Jim Meyering <meyering@redhat.com>
509
32c1fffd 510 do not ignore write error for any output size
b260039d
JM
511 The previous change was incomplete.
512 While it makes emacs --batch detect the vast majority of stdout
513 write failures, errors were still ignored whenever the output size is
514 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
515 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
516 && echo FAIL: ignored write error
517 FAIL: ignored write error
518 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
519 && echo FAIL: ignored write error
520 FAIL: ignored write error
521 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
522
8eca8a7c
AS
5232011-09-23 Andreas Schwab <schwab@linux-m68k.org>
524
525 * emacs.c (Fkill_emacs): In noninteractive mode exit
526 non-successfully if a write error occurred on stdout. (Bug#9574)
527
3341db62
EZ
5282011-09-21 Eli Zaretskii <eliz@gnu.org>
529
530 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
531 the xassert test.
532
533 * dispextern.h (struct it): Update the comment documenting what
534 can it->OBJECT be.
535
8c203dbf
EZ
5362011-09-20 Eli Zaretskii <eliz@gnu.org>
537
538 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
539 a display string, extend search for cursor position to end of row.
540 (find_row_edges): If the row ends in a newline from a display
541 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
542 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
543 (Fcurrent_bidi_paragraph_direction): Fix search for previous
544 non-empty line. Fixes confusing cursor motion with arrow keys at
545 the beginning of a line that starts with whitespace.
8c203dbf 546
a4824228
LMI
5472011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
548
549 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
550 (bug#9493).
551
33ed493b
CY
5522011-09-18 Chong Yidong <cyd@stupidchicken.com>
553
554 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
555 boolean (Bug#9154).
556
56cd55c8
EZ
5572011-09-18 Eli Zaretskii <eliz@gnu.org>
558
559 * xdisp.c (display_line): Record maximum and minimum buffer
560 positions even if no glyphs were produced (e.g., by a zero-width
561 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
562 buffer positions that will be removed from the glyph row because
563 they don't fit.
c02dcedf
EZ
564 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
565 column is beyond frame width: don't subtract 1 "pixel" when
566 computing width of the stretch.
3e62b7e0
EZ
567 (reseat_at_next_visible_line_start): Undo the change made on
568 2011-09-17 that saved paragraph information and restored it after
569 the call to `reseat'. (Bug#9545)
56cd55c8 570
5ed99d36 5712011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
572
573 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
574 and turn window cursor on if cleared (Bug#9415).
575
5ed99d36 5762011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
577
578 * search.c (boyer_moore): Take unibyte characters from pattern
579 literally. (Bug#9458)
580
9bade7b2
EZ
5812011-09-18 Eli Zaretskii <eliz@gnu.org>
582
583 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
584
e5e9d610
PE
5852011-09-18 Paul Eggert <eggert@cs.ucla.edu>
586
87e4427a
PE
587 Fix minor problem found by static checking.
588 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
589 initialized, to pacify gcc -Wuninitialized.
590
e5e9d610
PE
591 * fileio.c: Report proper errno when syscall falls.
592 (Finsert_file_contents): Save and restore errno,
593 so that report_file_error outputs the correct diagnostic.
594 (Fwrite_region) [CLASH_DETECTION]: Likewise.
595
a1674f0b
EZ
5962011-09-18 Eli Zaretskii <eliz@gnu.org>
597
598 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
599
fbfb6dd4
EZ
6002011-09-17 Eli Zaretskii <eliz@gnu.org>
601
602 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
603 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
604
bb187662
EZ
6052011-09-17 Eli Zaretskii <eliz@gnu.org>
606
1137e8b8 607 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 608 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
609
610 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
611 (bidi_find_paragraph_start): Search back for paragraph beginning
612 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
613 (bidi_move_to_visually_next): Only trigger paragraph-related
614 computations when the last character is a newline or at EOB, not
615 just any NEUTRAL_B. (Bug#9470)
616
bb187662
EZ
617 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
618 truncated lines if point is covered by a display string. (Bug#9524)
619
2e621251
PE
6202011-09-16 Paul Eggert <eggert@cs.ucla.edu>
621
622 * xselect.c: Relax test for outgoing X longs (Bug#9498).
623 (cons_to_x_long): New function.
624 (lisp_data_to_selection_data): Use it. Correct the test for
625 short-versus-long data; it was negated. Break out of vector
626 loop, for efficiency, when a long datum is discovered.
627
91a15bc6
SM
6282011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
629
630 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
631
b41c3a35
EZ
6322011-09-16 Eli Zaretskii <eliz@gnu.org>
633
634 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
635 GCC PR/17406) by declaring this function with external scope.
636
7812ba2d
PE
6372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
638
639 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
640 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
641
cf7edc2a
AS
6422011-09-15 Andreas Schwab <schwab@linux-m68k.org>
643
644 * editfns.c (Fformat): Correctly handle text properties on "%%".
645
bd01620e
EZ
6462011-09-15 Eli Zaretskii <eliz@gnu.org>
647
648 * xterm.c (x_draw_composite_glyph_string_foreground):
649 * w32term.c (x_draw_composite_glyph_string_foreground):
650 * term.c (encode_terminal_code):
651 * composite.c (composition_update_it, get_composition_id):
652 * xdisp.c (get_next_display_element)
653 (fill_composite_glyph_string): Add comments about special meaning
654 of TAB characters in a composition.
655
a02719a3
PE
6562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
657
658 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
659 This occurs when processing a multibyte format.
660 Problem reported by Wolfgang Jenker.
a02719a3 661
72589a3c
JB
6622011-09-15 Johan Bockgård <bojohan@gnu.org>
663
664 * xdisp.c (try_cursor_movement): Only check for exact match if
665 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
666
1c14176c
PE
6672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
668
669 Remove unused external symbols.
670 * dispextern.h (calc_pixel_width_or_height): Remove decl.
671 * xdisp.c (calc_pixel_width_or_height): Now static.
672 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
673 * indent.c (check_display_width):
674 * w32term.c: Fix comment to match code.
675 * xterm.c, xterm.h (x_catching_errors): Remove.
676
d2eea5b5
PE
6772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
678
679 * xselect.c: Use signed conversions more consistently (Bug#9498).
680 (selection_data_to_lisp_data): Assume incoming selection data are
681 signed integers, not unsigned. This is to be consistent with
682 outgoing selection data, which was modified to use signed integers
683 in as part of the fix to Bug#9196 in response to Jan D.'s comment
684 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
685 expects long, not unsigned long.
686
46888499
EZ
6872011-09-14 Eli Zaretskii <eliz@gnu.org>
688
689 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
690 computation of loop end. Reported by Johan Bockgård
691 <bojohan@gnu.org>.
692
ef8ef9fb
CY
6932011-09-13 Chong Yidong <cyd@stupidchicken.com>
694
695 * frame.c (Fother_visible_frames_p): Function deleted.
696
fa819fed
EZ
6972011-09-12 Eli Zaretskii <eliz@gnu.org>
698
699 * indent.c (compute_motion): Process display vector front to back
700 rather than the other way around. (Bug#2496)
701
2ba8e008
SM
7022011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
703
704 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
705
20f53c69
CY
7062011-09-11 Chong Yidong <cyd@stupidchicken.com>
707
708 * minibuf.c (Fread_from_minibuffer): Doc fix.
709
d562d7a4
EZ
7102011-09-11 Eli Zaretskii <eliz@gnu.org>
711
712 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
713 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
714
1c4d7f3d
LMI
7152011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
716
717 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
718 value for non-existent files.
719
b885bf36
EZ
7202011-09-11 Eli Zaretskii <eliz@gnu.org>
721
722 * fileio.c (Finsert_file_contents): If the file cannot be opened,
723 set its "size" to -1. This will set the modtime_size field of
724 the corresponding buffer to -1, which is what
725 verify-visited-file-modtime expects for files that do not exist.
726 (Bug#9139)
727
6612f0bf
PE
7282011-09-11 Paul Eggert <eggert@cs.ucla.edu>
729
730 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
731 here ...
732 * lisp.h: ... from here. push_key_description is no longer
733 defined in keyboard.c, so its declaration should not be in
734 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
735 logically belongs with push_key_description.
736
dfb3f755
PE
7372011-09-10 Paul Eggert <eggert@cs.ucla.edu>
738
739 * buffer.h: Include <sys/types.h> instead of <time.h>.
740 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
741 Problem reported by Herbert J. Skuhra.
742
3134906c
LMI
7432011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
744
745 * xml.c (parse_region): Make the parsing work for
746 non-comment-starting XML files again (bug#9144).
747
8d903f4e
AS
7482011-09-10 Andreas Schwab <schwab@linux-m68k.org>
749
750 * image.c (gif_load): Fix calculation of bottom and right corner.
751 (Bug#9468)
752
80ad64f4
EZ
7532011-09-10 Eli Zaretskii <eliz@gnu.org>
754
755 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
756 redisplay in small windows.
757
208a048d
EZ
7582011-09-09 Eli Zaretskii <eliz@gnu.org>
759
760 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
761
9b1c252e
MR
7622011-09-08 Martin Rudalics <rudalics@gmx.at>
763
764 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
765 Operate on live windows only.
766
2949f33b
JB
7672011-09-08 Juanma Barranquero <lekktu@gmail.com>
768
769 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
770
e08dcafd
EZ
7712011-09-07 Eli Zaretskii <eliz@gnu.org>
772
773 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
774 only under bidi iteration.
775
115b96bd
JD
7762011-09-07 Jan Djärv <jan.h.d@swipnet.se>
777
778 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
779
c8199d0f
PE
7802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
781
782 isnan: Fix porting problem to Solaris 10 with bundled gcc.
783 Without this fix, the command to link temacs failed due to an
784 undefined symbol __builtin_isnan. This is because
785 /usr/include/iso/math_c99.h #defines isnan(x) to
786 __builtin_isnan(x), but the bundled gcc, which identifies itself
787 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
788 a __builtin_isnan.
789 * floatfns.c (isnan): #undef, and then #define to a clone of
790 what's in data.c.
791 (Fisnan): Always define, since it's always available now.
792 (syms_of_floatfns): Always define isnan at the Lisp level.
793
e39b275c 7942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
795
796 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
797
b2db44d9 7982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 799
f4af5137 800 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
801 The previous code assumed that file offsets (off_t values) fit in
802 EMACS_INT variables, which is not true on typical 32-bit hosts.
803 The code messed up by falsely reporting buffer overflow in cases
804 such as (insert-file-contents "big" nil 1 2) into an empty buffer
805 when "big" contains more than 2**29 bytes, even though this
806 inserts just one byte and does not overflow the buffer.
807 (Finsert_file_contents): Store file offsets as off_t
808 values, not as EMACS_INT values. Check for overflow when
809 converting between EMACS_INT and off_t. When checking for
810 buffer overflow or for overlap, take the offsets into account.
811 Don't use EMACS_INT for small values where int suffices.
812 When checking for overlap, fix a typo: ZV was used where
813 ZV_BYTE was intended.
814 (Fwrite_region): Don't assume off_t fits into 'long'.
815 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
816
ecfc0a49
MA
8172011-09-05 Michael Albinus <michael.albinus@gmx.de>
818
819 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
820
6511acf2 8212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 822
0999621a 823 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
824
825 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 826 (esprintf, exprintf, evxprintf): New functions.
62f19c19 827 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 828 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
829 (modify_event_symbol): Do not assume that the length of
830 name_alist_or_stem is safe to alloca and fits in int.
831 (Fexecute_extended_command): Likewise for function name and binding.
832 (Frecursion_depth): Wrap around reliably on integer overflow.
833 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
834 since some callers pass EMACS_INT values.
835 (Fsingle_key_description): Don't crash if symbol name contains more
836 than MAX_ALLOCA bytes.
837 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
838 (get_minibuffer): Arg is now EMACS_INT, not int.
839 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 840 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
841 * window.h (command_loop_level, minibuf_level): Reflect API changes.
842
2be7d702
PE
843 * dbusbind.c (signature_cat): New function.
844 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
845 Do not overrun buffer; instead, report string overflow.
846
9d1df220
PE
847 * dispnew.c (add_window_display_history): Don't overrun buffer.
848 Truncate instead; this is OK since it's just a log.
849
33ef5c64
PE
850 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
851 even if the time zone offset is outlandishly large.
852 Don't mishandle offset == INT_MIN.
853
66c6fdd5
PE
854 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
855 when creating daemon; the previous buffer-overflow check was incorrect.
856
d749b01b
PE
857 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
858 which has the guts of the old verror function.
859
b5cd1905
PE
860 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
861 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
862
6e1a67fb
PE
863 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
864 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 865 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 866 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
867 length of string rather than counting it via multiple sprintfs;
868 that's simpler and more reliable.
c21721cc
PE
869 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
870 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
871 sprintf, in case result does not fit in int.
872
c57b67fc
PE
873 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
874 (fontset_from_font): Print it.
875
8a401434
PE
876 * frame.c (tty_frame_count): Now printmax_t, not int.
877 (make_terminal_frame, set_term_frame_name): Print it.
878 (x_report_frame_params): In X, window IDs are unsigned long,
879 not signed long, so print them as unsigned.
880 (validate_x_resource_name): Check for implausibly long names,
881 and don't assume name length fits in 'int'.
882 (x_get_resource_string): Don't blindly alloca invocation name;
883 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
884 not fit in int.
885
6e1a67fb
PE
886 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
887 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
888 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
889
0df02bf3
PE
890 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
891 Use esprintf, not sprintf, in case result does not fit in int.
892
48e30793
PE
893 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
894 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
895 it as a large positive number.
896 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
897 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
898
a66ff6d8
PE
899 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
900 in case result does not fit in int.
901
aca216ff
PE
902 * print.c (float_to_string): Detect width overflow more reliably.
903 (print_object): Make sprintf buffer a bit bigger, to avoid potential
904 buffer overrun. Don't assume list length fits in 'int'. Treat
905 print length of 0 as 0, not as infinity; to be consistent with other
906 uses of print length in this function. Don't overflow print length
907 index. Don't assume hash table size fits in 'long', or that
908 vectorlike size fits in 'unsigned long'.
909
31c286f7
PE
910 * process.c (make_process): Use printmax_t, not int, to format
911 process-name gensyms.
912
55e5faa1
PE
913 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
914
80f2e268
PE
915 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
916 to avoid potential buffer overrun.
917
670741ab
PE
918 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
919 if X resource line is longer than 512 bytes.
920
b7163a50
PE
921 * xfns.c (x_window): Make sprintf buffer a bit bigger
922 to avoid potential buffer overrun.
923
ae58ff1f
PE
924 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
925
c43c8a6a
PE
926 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
927
3f8236f4
PE
9282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
929
53e9fe90 930 Integer overflow fixes for scrolling, etc.
6511acf2
PE
931 Without these, Emacs silently mishandles large integers sometimes.
932 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
933 it were "C-u 1 M-x recenter" on a typical 64-bit host.
934
6511acf2
PE
935 * xdisp.c (try_window_id): Check Emacs fixnum range before
936 converting to 'int'.
806add1d 937
6511acf2 938 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
939 Check that an Emacs fixnum is in range before assigning it to 'int'.
940 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
941 values converted from Emacs fixnums.
942 (Frecenter): Don't wrap around a line count if it is out of 'int'
943 range; instead, treat it as an extreme value.
944 (Fset_window_configuration, compare_window_configurations):
945 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
946
6511acf2
PE
947 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
948 that can exceed INT_MAX. Check that EMACS_INT value is in range
949 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
950 (match_limit): Don't assume that a fixnum can fit in 'int'.
951
6511acf2 952 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
953 exceed INT_MAX.
954
6511acf2 955 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
956 (Fvertical_motion): Don't wrap around LINES values that don't fit
957 in 'int'. Instead, treat them as extreme values. This is good
958 enough for windows, which can't have more than INT_MAX lines anyway.
959
fcb901a7
LMI
9602011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
961
0f2f6b6d
LMI
962 * Require libxml/parser.h to avoid compilation warning.
963
fcb901a7
LMI
964 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
965
966 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
967 since this reportedly can destroy thread storage.
968
6e20a0d4
CY
9692011-08-30 Chong Yidong <cyd@stupidchicken.com>
970
971 * syntax.c (find_defun_start): Update all cache variables if
972 exiting early (Bug#9401).
973
148ae00e
EZ
9742011-08-30 Eli Zaretskii <eliz@gnu.org>
975
f6cfbd8f
EZ
976 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
977
148ae00e
EZ
978 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
979 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
980 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
981
982 * term.c (tty_append_glyph): New function.
983 (produce_stretch_glyph): Static function and its prototype deleted.
984
a66cfb1c
SM
985 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
986 Add prototypes.
148ae00e 987
c4a07a4c
PE
9882011-08-29 Paul Eggert <eggert@cs.ucla.edu>
989
990 * image.c (parse_image_spec): Check for nonnegative, not for positive,
991 when checking :margin (Bug#9390).
992 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 993 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
994 so that the name doesn't mislead. All uses changed.
995
6bc8cd65
JB
9962011-08-28 Johan Bockgård <bojohan@gnu.org>
997
998 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
999 set_tty_hooks.
1000
dca4927e
EZ
10012011-08-27 Eli Zaretskii <eliz@gnu.org>
1002
1003 * xdisp.c (move_it_to): Don't bail out early when reaching
1004 position beyond to_charpos, if we are scanning backwards.
1005 (move_it_vertically_backward): When DY == 0, make sure we get to
1006 the first character in the line after the newline.
1007
f2cad773
PE
10082011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1011 (ccl_driver): Do not generate an out-of-range pointer.
1012 (Fccl_execute_on_string): Remove unnecessary check for
1013 integer overflow, noted by Stefan Monnier in
1014 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1015 Remove a FIXME that didn't need fixing.
1016 Simplify the newly-introduced buffer reallocation code.
1017
0cae2cdb
JB
10182011-08-27 Juanma Barranquero <lekktu@gmail.com>
1019
1020 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1021
5fc295a4 10222011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1023
70c60eb2 1024 Integer and memory overflow issues (Bug#9196).
726e0ab1 1025
d31850da
PE
1026 * doc.c (get_doc_string): Rework so that
1027 get_doc_string_buffer_size is the actual buffer size, rather than
1028 being 1 less than the actual buffer size; this makes xpalloc more
1029 convenient.
1030
a69fbedb
PE
1031 * image.c (x_allocate_bitmap_record, cache_image):
1032 * xselect.c (Fx_register_dnd_atom):
1033 Simplify previous changes by using xpalloc.
1034
fe5c5d37
PE
1035 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1036 since either will do and ptrdiff_t is convenient with xpalloc.
1037
0065d054
PE
1038 * charset.c (charset_table_size)
1039 (struct charset_sort_data.priority): Now ptrdiff_t.
1040 (charset_compare): Don't overflow if priorities differ greatly.
1041 (Fsort_charsets): Don't assume list length fits in int.
1042 Check for size-calculation overflow when allocating sort data.
1043 (syms_of_charset): Allocate an initial charset table that is
1044 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1045
1046 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1047
1048 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1049 The actual value is always <= INT_MAX, and leaving it unsigned made
1050 overflow checking harder.
1051
1052 * dispextern.h (struct glyph_matrix.rows_allocated)
1053 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1054 with xpalloc. The values are still always <= INT_MAX.
1055
1056 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1057
1058 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1059 (SAFE_NALLOCA): New macro.
1060
1061 * region-cache.c (struct boundary.pos, find_cache_boundary)
1062 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1063 (set_cache_region, invalidate_region_cache)
1064 (revalidate_region_cache, know_region_cache, region_cache_forward)
1065 (region_cache_backward, pp_cache):
1066 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1067 so that ptrdiff_t * can be passed to xpalloc.
1068 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1069 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1070 (pp_cache): Don't assume cache_len fits in int.
1071 * region-cache.h: Adjust extern decls to match.
1072
1073 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1074 EMACS_INT, since either will do, for xpalloc.
1075
1076 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1077 (xnmalloc, xnrealloc, xpalloc): New functions.
1078
726e0ab1
PE
1079 * bidi.c (bidi_shelve_header_size): New constant.
1080 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1081 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1082
51f30bc5 1083 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1084 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1085 (overlay_strings):
1086 Don't update size of array until after memory allocation succeeds,
1087 because xmalloc/xrealloc may not return.
0065d054
PE
1088 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1089 now that we have proper integer overflow checking.
1090 (record_overlay_string, overlay_strings): Catch overflows when
1091 calculating size of overlay_str_buf.
726e0ab1 1092
0065d054
PE
1093 * callproc.c (Fcall_process): Check for size overflow when
1094 calculating size of args2.
1095 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1096 Normally we prefer signed values, but sticking with ptrdiff_t would
1097 require adding more-complicated checks.
726e0ab1
PE
1098
1099 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1100 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1101 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1102 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1103
1104 * character.c (Fstring): Check for size-calculation overflow.
1105
1106 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1107 unnecessary integer overflow. Check for size overflow.
1108 (encode_coding_object): Don't update size until xmalloc succeeds.
1109
1110 * composite.c (get_composition_id): Check for overflow in glyph
1111 length calculations.
1112
1113 Integer and memory overflow fixes for display code.
1114 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1115 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1116 (scrolling_window): Check for overflow in size calculations.
1117 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1118 Don't assume glyph table len fits in int.
1119 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1120 (row_table_size): Now ptrdiff_t, not int.
1121 (scrolling_window): Avoid overflow in size calculations.
1122 Don't update size until allocation succeeds.
1123 * fns.c (concat): Check for overflow in size calculations.
1124 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1125 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1126 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1127
1128 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1129 (get_doc_string): Check for size calculation overflow.
1130 Don't update size until allocation succeeds.
1131 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1132 EMACS_INT, where ptrdiff_t will do.
1133 (Fsubstitute_command_keys): Check for string overflow.
1134
1135 * editfns.c (set_time_zone_rule): Don't assume environment length
1136 fits in int.
1137 (message_length): Now ptrdiff_t, not int.
1138 (Fmessage_box): Don't update size until allocation succeeds.
1139 Don't assume message length fits in int.
1140 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1141
0065d054
PE
1142 * emacs.c (main): Do not reallocate argv, since there is a null at
1143 the end that can be overwritten, and this way there's no need to
1144 worry about size-calculation overflow.
1145 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1146
1147 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1148 alloc succeeds.
1149 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1150
1151 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1152 (x_set_scroll_bar_width, x_figure_window_size):
1153 Check for integer overflow.
1154 (x_set_alpha): Do not assume XINT fits in int.
1155
1156 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1157 This is for the members text_lines, text_cols, total_lines, total_cols,
1158 where the system imposes an 'int' limit.
1159
1160 * fringe.c (Fdefine_fringe_bitmap):
1161 Don't update size until alloc works.
1162
1163 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1164 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1165
1166 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1167 Check for size-calculation overflow.
1168 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1169 do, as we prefer signed integers.
1170 (id_to_widget.max_size, id_to_widget.used)
1171 (xg_store_widget_in_map, xg_remove_widget_from_map)
1172 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1173 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1174 Use and return ptrdiff_t, not int.
1175 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1176 * gtkutil.h: Change prototypes to match the above.
1177
1178 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1179 are duplicate now that they've been promoted to lisp.h.
1180 (x_allocate_bitmap_record, x_alloc_image_color)
1181 (make_image_cache, cache_image, xpm_load):
1182 Don't update size until alloc is done.
1183 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1184 (x_detect_edges):
3256efce 1185 Check for size calculation overflow.
726e0ab1
PE
1186 (ct_colors_allocated_max): New constant.
1187 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1188 overflow.
3256efce 1189
726e0ab1
PE
1190 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1191 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1192 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1193 Use ptrdiff_t, not int, to count maps.
1194 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1195 calculations. Don't update size until allocation succeeds.
1196 Redo calculations to avoid overflow.
726e0ab1
PE
1197 * keyboard.h: Change prototypes to match the above.
1198
1199 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1200 to count maps.
1201 (current_minor_maps): Check for size calculation overflow.
1202 * keymap.h: Change prototypes to match the above.
1203
1204 * lread.c (read1, init_obarray): Don't update size until alloc done.
1205
1206 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1207 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1208
726e0ab1
PE
1209 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1210 Now ptrdiff_t, not int.
1211 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1212 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1213
1214 * process.c (Fnetwork_interface_list): Check for overflow
1215 in size calculation.
1216
1217 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1218
1219 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1220 overflow. Don't bother calling xmalloc when xrealloc will do.
1221
1222 * search.c (Freplace_match): Check for size calculation overflow.
1223 (Fset_match_data): Don't assume list lengths fit in 'int'.
1224
1225 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1226 for command line length. Do not attempt to address one before the
1227 beginning of an array, as that's not portable.
1228
1229 * term.c (max_frame_lines): Remove; unused.
1230 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1231 not int.
1232 (encode_terminal_code, calculate_costs): Check for size
1233 calculation overflow.
1234 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1235 table lengths and related sizes. Don't update size until alloc
1236 done. Redo calculations to avoid overflow.
1237 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1238
1239 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1240 subtracting pointers.
1241 (gobble_line): Check for overflow more carefully. Don't update size
1242 until alloc done.
1243
1244 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1245 Don't update size until alloc done.
1246 Redo size calculations to avoid overflow.
1247 Check for size calculation overflow.
0065d054 1248 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1249
1250 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1251 Use ptrdiff_t, not int, for sizes.
1252 (store_mode_line_noprop_char): Don't update size until alloc done.
1253
0065d054
PE
1254 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1255 Use ptrdiff_t, not int, for sizes.
1256 (Finternal_make_lisp_face, cache_face):
1257 Check for size calculation overflow.
1258 (cache_face): Treat size calculation overflows as if they were
1259 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1260
1261 * xfns.c (x_encode_text, x_set_name_internal)
1262 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1263 sizes, since they can exceed INT_MAX in size. Check for size
1264 calculation overflow.
1265
0065d054
PE
1266 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1267 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1268 Don't update size until alloc done.
1269
0065d054 1270 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1271 as sprintf is limited to int lengths.
1d526e2f 1272
252c5ee1
PE
1273 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1274 (X_LONG_MIN): New macros.
864d7ce7
PE
1275 Use them to make the following changes clearer.
1276 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1277 This change doesn't affect the value now, but it may help remind
1278 future maintainers not to raise the value too much later.
1279 (SELECTION_QUANTUM): Remove, replacing with ...
1280 (selection_quantum): ... new function, which avoids overflow.
1281 All uses changed.
1282 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1283 assumption that selection length fits in 'int'.
1284 (x_reply_selection_request, x_handle_selection_request)
1285 (x_get_window_property, receive_incremental_selection)
1286 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1287 (lisp_data_to_selection_data, clean_local_selection_data):
1288 Use ptrdiff_t, not int, to record length of selection.
1289 (x_reply_selection_request, x_get_window_property)
1290 (receive_incremental_selection, x_property_data_to_lisp):
1291 Redo calculations to avoid overflow.
1292 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1293 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1294 something.
1295 (x_get_window_property, receive_incremental_selection)
1296 (lisp_data_to_selection_data, x_property_data_to_lisp):
1297 Check for size-calculation overflow.
1298 (x_get_window_property, receive_incremental_selection)
1299 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1300 Don't store size until memory allocation succeeds.
1301 (x_get_window_property): Plug memory leak on memory exhaustion.
1302 Don't double-block input; malloc is safe here. Don't assume 2**34
1303 - 4 fits in unsigned long. Add an xassert to check
1304 XGetWindowProperty overflow. Be more careful about overflow
1305 calculations, and distinguish size from memory overflow better.
1306 (receive_incremental_selection): When tracing, don't assume
1307 unsigned int is less than INT_MAX.
1308 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1309 harmful) conversions of unsigned short to int.
1310 (lisp_data_to_selection_data): Don't assume that integers
1311 in the range -65535 through -1 fit in an X unsigned short.
1312 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1313 result parameters unless successful. Rely on cons_to_unsigned
1314 to report problems with elements; the old code wasn't right anyway.
1315 (x_check_property_data): Check for int overflow; we cannot use
1316 a wider type due to X limits.
1317 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1318
726e0ab1 1319 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1320
0065d054
PE
1321 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1322 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1323 (x_color_cells): Don't store size until memory allocation succeeds.
1324 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1325 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1326 (x_term_init): Don't assume length fits in int (sprintf is limited
1327 to int size).
bc18e09d 1328
ebfa62c0
PE
1329 Use ptrdiff_t for composition IDs.
1330 * character.c (lisp_string_width):
1331 * composite.c (composition_table_size, n_compositions)
1332 (get_composition_id, composition_gstring_from_id):
1333 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1334 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1335 * window.c (Frecenter):
1336 Use ptrdiff_t, not int, for composition IDs.
1337 * composite.c (get_composition_id): Check for integer overflow.
1338 * composite.h: Adjust prototypes to match the above changes.
1339
d3411f89
PE
1340 Use ptrdiff_t for hash table indexes.
1341 * category.c (hash_get_category_set):
1342 * ccl.c (ccl_driver):
1343 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1344 * coding.c (coding_system_charset_list, detect_coding_system):
1345 * coding.h (struct coding_system.id):
1346 * composite.c (get_composition_id, gstring_lookup_cache):
1347 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1348 * image.c (xpm_get_color_table_h):
1349 * lisp.h (hash_lookup, hash_put):
1350 * minibuf.c (Ftest_completion):
1351 Use ptrdiff_t for hash table indexes, not int (which is too
1352 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1353 32-bit --with-wide-int hosts).
1354
e097a6fa
PE
1355 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1356 Add a FIXME comment about memory leaks.
1357 (syms_of_charset): Don't assume xmalloc returns.
1358
5637687f
PE
1359 Don't assume that stated character widths fit in int.
1360 * character.c (Fchar_width, c_string_width, lisp_string_width):
1361 * character.h (CHAR_WIDTH):
1362 * indent.c (MULTIBYTE_BYTES_WIDTH):
1363 Use sanitize_char_width to avoid undefined and/or bad behavior
1364 with outlandish widths.
a66cfb1c 1365 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1366 now that we have two such functions. All uses changed.
1367 (sanitize_char_width): New inline function.
1368
a2271ba2
PE
1369 Don't assume that tab-width fits in int.
1370 * character.h (sanitize_width): New inline function.
1371 (SANE_TAB_WIDTH): New macro.
1372 (ASCII_CHAR_WIDTH): Use it.
1373 * indent.c (sane_tab_width): Remove. All uses replaced by
1374 SANE_TAB_WIDTH (current_buffer).
1375 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1376
18c52557
PE
1377 * fileio.c: Integer overflow issues with file modes.
1378 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1379
caeeedc1
PE
1380 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1381 Remove unreachable code.
1382 (read_hex, load_charset_map_from_file): Check for integer overflow.
1383
50849c52
PE
1384 * xterm.c: don't go over XClientMessageEvent limit
1385 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1386 (x_send_scroll_bar_event): Likewise. Check that the size does not
1387 exceed limits imposed by XClientMessageEvent, as well as the usual
1388 ptrdiff_t and size_t limits.
1389
b13995db
PE
1390 * keyboard.c: Overflow, signedness and related fixes.
1391 (make_lispy_movement): Use same integer type in forward decl
1392 that is used in the definition.
1393 (read_key_sequence, keyremap_step):
1394 Change bufsize argument back to int, undoing my 2011-03-30 change.
1395 We prefer signed types, and int is wide enough here.
1396 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1397 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1398 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1399 length, not size_t. Use ptrdiff_t for index, not int.
1400 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1401 possibility of integer overflow.
1402
13464394
PE
1403 Overflow, signedness and related fixes for images.
1404
1405 * dispextern.h (struct it.stack[0].u.image.image_id)
1406 (struct_it.image_id, struct image.id, struct image_cache.size)
1407 (struct image_cache.used, struct image_cache.ref_count):
1408 * gtkutil.c (update_frame_tool_bar):
1409 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1410 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1411 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1412 * nsmenu.m (update_frame_tool_bar):
1413 * xdisp.c (calc_pixel_width_or_height):
1414 * xfns.c (image_cache_refcount):
1415 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1416 on typical 64-bit hosts.
1417
1418 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1419 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1420 Omit unnecessary casts to int.
1421 (parse_image_spec): Check that integers fall into 'int' range
1422 when the callers expect that.
1423 (image_ascent): Redo ascent calculation to avoid int overflow.
1424 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1425 (lookup_image): Remove unnecessary tests.
1426 (xbm_image_p): Locals are now of int, not EMACS_INT,
1427 since parse_image_check makes sure they fit into int.
1428 (png_load, gif_load, svg_load_image):
1429 Prefer int to unsigned where either will do.
1430 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1431 old tiff_error_handler and tiff_warning_handler.
1432 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1433 stack buffer overflows. It uses only the features of vsnprintf
1434 that are common to both POSIX and native Microsoft.
1435 (tiff_error_handler, tiff_warning_handler): Use it.
1436 (tiff_load, gif_load, imagemagick_load_image):
1437 Don't assume :index value fits in 'int'.
1438 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1439 (imagemagick_load_image): Check that crop parameters fit into
1440 the integer types that MagickCropImage accepts. Don't assume
1441 Vimagemagick_render_type has a nonnegative value. Don't assume
1442 size_t fits in 'long'.
1443 (gs_load): Use printmax_t to print the widest integers possible.
1444 Check for integer overflow when computing image height and width.
1445
c11821d4
EZ
14462011-08-26 Eli Zaretskii <eliz@gnu.org>
1447
1448 * xdisp.c (redisplay_window): Don't force window start if point
1449 will be invisible in the resulting window. (Bug#9324)
1450
0c95fcf7
EZ
14512011-08-25 Eli Zaretskii <eliz@gnu.org>
1452
1453 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1454 the display spec is of the form `(space ...)'.
1455 (handle_display_spec): Return the value returned by
1456 handle_single_display_spec, not just 1 or zero.
1457 (handle_single_display_spec): If the display spec is of the form
1458 `(space ...)', and specifies display in the text area, return 2
1459 rather than 1.
fee65a97 1460 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1461 accurately, and prefer exact match for point under bidi.
1462 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1463
1464 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1465 into disp_prop; all users changed.
1466
1467 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1468 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1469 for the text covered by the display property.
1470
e4ed06f1
CY
14712011-08-25 Chong Yidong <cyd@stupidchicken.com>
1472
1473 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1474 Change return value to nil.
1475 (Frecord_buffer): Delete unused function.
1476
f67cdd7f
EZ
14772011-08-24 Eli Zaretskii <eliz@gnu.org>
1478
5980d4c6
EZ
1479 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1480 buffers, return left-to-right.
8610fe8b
EZ
1481 (set_cursor_from_row): Consider candidate row a win if its glyph
1482 represents a newline and point is on that newline. Fixes cursor
1483 positioning on the newline at EOL of R2L text within L2R
1484 paragraph, and vice versa.
1485 (try_cursor_movement): Check continued rows, in addition to
1486 continuation rows. Fixes unwarranted scroll when point enters a
1487 continued line of R2L text within an L2R paragraph, or vice versa.
1488 (cursor_row_p): Consider the case of point being equal to
1489 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1490 from the end of a short line to the beginning of a continued line
1491 of R2L text within L2R paragraph.
1492 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1493 composed characters.
5980d4c6 1494
f67cdd7f
EZ
1495 * bidi.c (bidi_check_type): Use xassert.
1496 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1497 members.
1498
bca633fb
EZ
14992011-08-23 Eli Zaretskii <eliz@gnu.org>
1500
1501 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1502 a character.
1503
4a5885a7
CY
15042011-08-23 Chong Yidong <cyd@stupidchicken.com>
1505
1506 * nsfont.m (ns_otf_to_script): Fix typo.
1507
0902a04e
KH
15082011-08-22 Kenichi Handa <handa@m17n.org>
1509
1510 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1511 extra slot even if the purpose is char-code-property-table.
1512
1a2e6670
EZ
15132011-08-23 Eli Zaretskii <eliz@gnu.org>
1514
8ddde651
EZ
1515 * xdisp.c (redisplay_window): When computing centering_position,
1516 account for the height of the header line. (Bug#8874)
1517
425cc014
EZ
1518 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1519 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1520 candidate is selected by the mouse, and that candidate has a
1521 composed character under the mouse.
1522
1a2e6670
EZ
1523 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1524 coordinates reported by pos-visible-in-window-p for a composed
1525 character in column zero.
1526
8b76d6f8
SM
15272011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1528
1529 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1530
dac347dd
EZ
15312011-08-22 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1534 consider it a hit if to_charpos is anywhere in the range of the
1535 composed buffer positions.
1536
e013fb34
CY
15372011-08-22 Chong Yidong <cyd@stupidchicken.com>
1538
1539 * image.c (gif_load): Don't assume that each subimage has the same
1540 dimensions as the base image. Handle disposal method that is
1541 "undefined" by the gif spec (Bug#9335).
1542
bd1ba3e8
CY
15432011-08-20 Chong Yidong <cyd@stupidchicken.com>
1544
1545 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1546 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1547
54a1215b
EZ
15482011-08-19 Eli Zaretskii <eliz@gnu.org>
1549
823564e5
EZ
1550 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1551 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1552 from an Org mode buffer to a Speedbar frame.
1553
54a1215b
EZ
1554 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1555 a composition, take its buffer position from IT->cmp_it.charpos.
1556 Fixes cursor positioning at the beginning of a line that begins
1557 with a composed character.
1558
9778ebcc
EZ
15592011-08-18 Eli Zaretskii <eliz@gnu.org>
1560
0be6ee06
EZ
1561 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1562 character bidirectional type, use STRONG_L instead. Fixes crashes
1563 in a buffer produced by `describe-categories'.
1564
9778ebcc
EZ
1565 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1566 members before the level stack, so they would be saved and
1567 restored when copying iterator state. Fixes incorrect reordering
1568 around TABs covered by display properties.
1569
156bffbe
AS
15702011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1571
6b02f655 1572 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1573
72ad093b
CY
15742011-08-17 Chong Yidong <cyd@stupidchicken.com>
1575
1576 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1577 (internal_condition_case_2, internal_condition_case_n):
1578 Remove unnecessary aborts (Bug#9081).
72ad093b 1579
35774242
EZ
15802011-08-17 Eli Zaretskii <eliz@gnu.org>
1581
1582 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1583 has no `load' handler, try opening the file locally. (Bug#9311)
1584
db76dd85
KB
15852011-08-16 Ken Brown <kbrown@cornell.edu>
1586
1587 * gmalloc.c: Expand comment.
1588
b215eee5
EZ
15892011-08-16 Eli Zaretskii <eliz@gnu.org>
1590
1591 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1592 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1593
a4579d33
KB
15942011-08-16 Ken Brown <kbrown@cornell.edu>
1595
1596 Fix memory allocation problems in Cygwin build (Bug#9273).
1597
1598 * unexcw.c ( __malloc_initialized): Declare external variable.
1599 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1600
8b76d6f8
SM
1601 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1602 New variables.
a4579d33
KB
1603 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1604 dumped emacs.
1605 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1606 in the static heap.
1607 [CYGWIN] (special_realloc): New function.
1608 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1609 requests to realloc storage in the static heap.
1610
3ebec551
PE
16112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1612
1613 * bidi.c (bidi_initialize): Remove unused local.
1614
9fd8be00
EZ
16152011-08-15 Eli Zaretskii <eliz@gnu.org>
1616
6b02f655
SM
1617 * bidimirror.h:
1618 * biditype.h: Remove file.
1619 * makefile.w32-in ($(BLD)/bidi.$(O)):
1620 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1621
1622 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1623
1624 * chartab.c: Improve commentary for the uniprop_table API.
1625
32413314
EZ
1626 * bidi.c (bidi_paragraph_init): Support zero value of
1627 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1628 (bidi_initialize): Use uniprop_table instead of including
1629 biditype.h and bidimirror.h.
32413314 1630
9fd8be00
EZ
1631 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1632 coordinates of the iterator when restoring from ppos_it.
1633 (Bug#9296)
1634
5cf2b69b
KH
16352011-08-14 Kenichi Handa <handa@m17n.org>
1636
1637 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1638 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1639
daf17d00
EZ
16402011-08-14 Eli Zaretskii <eliz@gnu.org>
1641
1642 * xdisp.c (move_it_in_display_line_to): Don't invoke
1643 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1644 ppos_it. Fixes vertical cursor motion when line beginning is
1645 covered by an image. (Bug#9296)
1646
08e3161a
JD
16472011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1648
1649 * nsterm.h (ns_run_ascript): Declare.
1650 (NSAPP_DATA2_RUNASSCRIPT): Define.
1651
1652 * nsfns.m (as_script, as_result, as_status): New static variables.
1653 (ns_run_ascript): New function.
5e617bc2 1654 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1655 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1656 the event loop. Get status from as_status (Bug#7276).
1657
1658 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1659 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1660 the event loop (Bug#7276).
1661
a3720aa2
AS
16622011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1663
1664 * gnutls.c (QCgnutls_bootprop_priority)
1665 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1666 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1667 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1668 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1669 (QCgnutls_bootprop_verify_hostname_error)
1670 (QCgnutls_bootprop_callbacks_verify): Rename from
1671 Qgnutls_bootprop_..., all uses changed.
1672
1673 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1674 uses changed.
1675
0a0d27fb
PE
16762011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1677
19d5c50c
PE
1678 * xfaces.c (Qframe_set_background_mode): Now static.
1679 * dispextern.h (Qframe_set_background_mode): Remove decl.
1680
0a0d27fb
PE
1681 * process.c (Fnetwork_interface_info): Declare local only if needed.
1682
377538cb
JD
16832011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1684
1685 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1686 (Fnetwork_interface_list): Allocate in increments of bytes instead
1687 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1688 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1689 sockaddr.
1690 (struct ifflag_def): notrailers is smart on OSX.
1691 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1692 Get hardware address with getifaddrs if available.
1693
08fff70c
EZ
16942011-08-12 Eli Zaretskii <eliz@gnu.org>
1695
1696 * xdisp.c (iterate_out_of_display_property): xassert that
1697 IT->position is set to within IT->object's boundaries. Break from
1698 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1699 when IT->position is set up wrongly due to some bug.
1700 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1701 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1702 entry. Force push_it to save on the stack the current
1703 buffer/string position, to be restored by pop_it. Fix flags in
1704 the iterator structure wrt the object coming from a display
1705 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1706 properties. (Bug#9284)
1707
7be1c708 17082011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1709
7be1c708
CY
1710 * fontset.c (fontset_get_font_group): Add proper type checks.
1711 (Bug#9172)
aac0c6e3 1712
7be1c708 17132011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1714
7be1c708
CY
1715 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1716 and LC_VERSION_MIN_MACOSX.
1717 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1718 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1719
97bb72a6
EZ
17202011-08-08 Eli Zaretskii <eliz@gnu.org>
1721
1722 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1723 no-display-properties-and-no-overlays under bidi display.
1724 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1725 properties and overlays.
97bb72a6 1726
d5617611
CY
17272011-08-08 Chong Yidong <cyd@stupidchicken.com>
1728
37e11a63
CY
1729 * editfns.c (Fset_time_zone_rule): Document relationship with the
1730 setenv function.
1731
d5617611
CY
1732 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1733 the font entity extracted from the cache (Bug#8109).
1734
58872834
CY
17352011-08-07 Chong Yidong <cyd@stupidchicken.com>
1736
1737 * composite.c (autocmp_chars): Don't reset point. That is done by
1738 restore_point_unwind (Bug#5984).
1739
75bfc667
JL
17402011-08-07 Juri Linkov <juri@jurta.org>
1741
1742 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1743 to show the arg `TIME' instead of `TIMEVAL'.
1744
d1410150
EZ
17452011-08-06 Eli Zaretskii <eliz@gnu.org>
1746
1747 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1748 display property strides EOL and includes a newline, as in
1749 longlines-mode. (Bug#9254)
75b771e4
EZ
1750 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1751 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1752
1753 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1754 is non-zero, even if the data buffer is NULL. Fixes a crash in
1755 vertical-motion with longlines-mode. (Bug#9254)
1756
35928349
EZ
17572011-08-05 Eli Zaretskii <eliz@gnu.org>
1758
ec7cc85b
EZ
1759 * bidi.c <bidi_cache_total_alloc>: Now static.
1760 (bidi_initialize): Initialize bidi_cache_total_alloc.
1761
8b76d6f8 1762 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1763 cache. (Bug#9221)
1764
1765 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1766 amount allocated this far in `bidi_cache_total_alloc'.
1767 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1768 non-zero, only free the data buffer without restoring the cache
1769 contents. All callers changed.
1770
1771 * dispextern.h (bidi_unshelve_cache): Update prototype.
1772
1773 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1774 (move_it_in_display_line, move_it_to)
1775 (move_it_vertically_backward, move_it_by_lines): Replace the call
1776 to xfree to an equivalent call to bidi_unshelve_cache.
1777 (move_it_in_display_line_to): Fix logic of returning
412b6358 1778 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1779
e2e2423b
EZ
17802011-08-05 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1783 came from a string character with a `cursor' property. (Bug#9229)
1784
ae9e757a
JD
17852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1786
1787 * Makefile.in (LIB_PTHREAD): New variable.
1788 (LIBES): Add LIB_PTHREAD (Bug#9216).
1789
1790 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1791 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1792
213bd7f2
AS
17932011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1794
6b02f655 1795 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1796
99aaf75f
JD
17972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1798
1799 * xterm.c (x_find_topmost_parent): New function.
1800 (x_set_frame_alpha): Find topmost parent window with
1801 x_find_topmost_parent and set the property there also (bug#9181).
1802 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1803
c74e9d86
PE
18042011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 * callproc.c (Fcall_process): Avoid vfork clobbering
1807 the local vars buffer, coding_systems, current_dir.
1808
640c8776
SM
18092011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1810
1811 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1812
f26d0e4c
PE
18132011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1814
8a10d76c
PE
1815 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1816 so that it is not optimized away.
1817
f26d0e4c
PE
1818 * xdisp.c (compute_display_string_pos): Remove unused local.
1819
55439c61
EZ
18202011-08-02 Eli Zaretskii <eliz@gnu.org>
1821
1822 Fix slow cursor motion and scrolling in large buffers with
1823 selective display, like Org Mode buffers. (Bug#9218)
1824
1825 * dispextern.h (struct bidi_it): New member disp_prop_p.
1826
1827 * xdisp.c: Remove one-slot cache of display string positions.
1828 (compute_display_string_pos): Accept an additional argument
5e617bc2 1829 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1830 for a display string or property. If found, set DISP_PROP_P
1831 non-zero.
1832
1833 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1834 DISP_PROP_P, and pass it to compute_display_string_pos.
1835 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1836 non-zero. All callers of bidi_fetch_char changed.
1837
fb33fa43
SM
18382011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1839
1840 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1841
b099e063
DM
18422010-12-03 Don March <don@ohspite.net>
1843
1844 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1845 last character M-[char] is translated to ESC [char] (bug#7541).
1846
5cc7f7af
KH
18472011-08-02 Kenichi Handa <handa@m17n.org>
1848
d0fffa3f 1849 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1850
1851 * chartab.c (uniprop_table): Make it non-static.
1852
525d5e6e
EZ
18532011-08-01 Eli Zaretskii <eliz@gnu.org>
1854
1855 * xdisp.c (forward_to_next_line_start): Accept additional argument
1856 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1857 on the newline.
1858 (reseat_at_next_visible_line_start): Use the bidi iterator state
1859 returned by forward_to_next_line_start to restore the state of
1860 it->bidi_it after backing up to previous newline. (Bug#9212)
1861
31011111
AS
18622011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1863
1864 * regex.c (re_comp): Protoize.
1865 (re_exec): Fix return type.
1866 (regexec): Fix type of `ret'. (Bug#9203)
1867
476371c4
PE
18682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1869
e5d76069
PE
1870 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1871 This is needed if max-image-size is a floating-point number.
1872
9a79b20c
AS
18732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1874
1875 * print.c (print_object): Print empty symbol as ##.
1876
1877 * lread.c (read1): Read ## as empty symbol.
1878
d8c2fa78
AA
18792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1880
1881 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1882 setting frame foreground color (Bug#9175).
1883 (x_set_background_color): Likewise.
1884
ffe57a7a
AA
1885 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1886 contents (Bug#9176).
1887 (EmacsTooltip -init): Remove bezels and add shadows to
1888 tooltip windows.
1889
bf3492a5
AA
1890 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1891 or scroll bar (Bug#8470).
1892
d55e9c53
AA
1893 * nsfont.m (nsfont_open): Remove assignment to voffset and
1894 unnecessary vars hshink, expand, hd, full_height, min_height.
1895 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1896
1897 * nsterm.h (nsfont_info): Remove voffset field.
1898
d8c2fa78 18992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1900
1901 Implement strike-through and overline on NextStep (Bug#8863).
1902
1903 * nsfont.m (nsfont_open): Use underline position provided by font,
1904 instead of hard-coded value of 2.
1905 (nsfont_draw): Call ns_draw_text_decoration instead.
1906
1907 * nsterm.h: Add declaration for ns_draw_text_decoration.
1908
1909 * nsterm.m (ns_draw_text_decoration): New function for drawing
1910 underline, overline, and strike-through.
1911 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1912 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1913 accommodate underlining, etc.
4843aac3 1914
4cc60b9b
EZ
19152011-07-28 Eli Zaretskii <eliz@gnu.org>
1916
bc7ece87
EZ
1917 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1918 default.
4cc60b9b 1919
476371c4
PE
19202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1921
66606eea
PE
1922 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1923 Without this fix, if a signal arrives just after memory fills up,
1924 'malloc' might be invoked reentrantly.
1925
476371c4
PE
1926 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1927 In other words, assume that every image size is allowed, on non-X
1928 hosts. This assumption is probably wrong, but it lets Emacs compile.
1929
f3fcc40d
AS
19302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1931
1932 * regex.c (re_iswctype): Convert return values to boolean.
1933
350c992f
EZ
19342011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1935
1936 * xdisp.c (compute_display_string_pos): Don't use cached display
1937 string position if the buffer had its restriction changed.
1938 (Bug#9184)
1939
5266b4bb
PE
19402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1943
2573a837 19442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1945
41f55ccd 1946 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1947
39e378da
PE
1948 * bidi.c: Integer size and overflow fixes.
1949 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1950 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1951 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1952 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1953 (bidi_find_other_level_edge):
1954 Use ptrdiff_t instead of EMACS_INT where either will do.
1955 This works better on 32-bit hosts configured --with-wide-int.
1956 (bidi_cache_ensure_space): Check for size-calculation overflow.
1957 Use % rather than repeated addition, for better worst-case speed.
1958 Don't set bidi_cache_size until after xrealloc returns, because it
1959 might not return.
1960 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1961 (bidi_cache_ensure_space): Also check that the bidi cache size
1962 does not exceed that of the largest Lisp string or buffer. See Eli
1963 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1964
5e927815
PE
1965 * alloc.c (__malloc_size_t): Remove.
1966 All uses replaced by size_t. See Andreas Schwab's note
1967 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1968
ca4aa935
PE
1969 * image.c: Improve checking for integer overflow.
1970 (check_image_size): Assume that f is nonnull, since
1971 it is always nonnull in practice. This is one less thing to
1972 worry about when checking for integer overflow later.
1973 (x_check_image_size): New function, which checks for integer
1974 overflow issues inside X.
1975 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1976 This removes the need for a memory_full check.
1977 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1978 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1979 (xbm_read_bitmap_data): Change locals back to 'int', since
1980 their values must fit in 'int'.
1981 (xpm_load_image, png_load, tiff_load):
1982 Invoke x_create_x_image_and_pixmap earlier,
1983 to avoid much needless work if the image is too large.
1984 (tiff_load): Treat overly large images as if
1985 x_create_x_image_and_pixmap failed, not as malloc failures.
1986 (gs_load): Use x_check_image_size.
1987
5f8f9cc2
PE
1988 * gtkutil.c: Omit integer casts.
1989 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1990 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1991
5adf60bc
PE
1992 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1993
c8907a93
PE
1994 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1995 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1996 would wrongly return t on a 64-bit host.
1997
e3c25c68
PE
1998 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1999 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2000 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2001 and therefore cause GCC to emit a bogus diagnostic in some cases.
2002
3f791afe
PE
2003 * image.c: Integer signedness and overflow and related fixes.
2004 This is not an exhaustive set of fixes, but it's time to
2005 record what I've got.
2006 (lookup_pixel_color, check_image_size): Remove redundant decls.
2007 (check_image_size): Don't assume that arbitrary EMACS_INT values
2008 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2009 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2010 (tiff_load, imagemagick_load_image):
2011 Check for overflow in size calculations.
2012 (x_create_x_image_and_pixmap): Remove unnecessary test for
2013 xmalloc returning NULL; that can't happen.
2014 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2015 (xpm_color_bucket): Use better integer hashing function.
2016 (xpm_cache_color): Don't possibly over-allocate memory.
2017 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2018 (gif_memory_source):
2019 Use ptrdiff_t, not int or size_t, to record sizes.
2020 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2021 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2022 either works, as we prefer signed integers.
2023 (tiff_read_from_memory, tiff_write_from_memory):
2024 Return tsize_t, not size_t, since that's what the TIFF API wants.
2025 (tiff_read_from_memory): Don't fail simply because the read would
2026 go past EOF; instead, return a short read.
2027 (tiff_load): Omit no-longer-needed casts.
2028 (Fimagemagick_types): Don't assume size fits into 'int'.
2029
3cc5a532
PE
2030 Improve hashing quality when configured --with-wide-int.
2031 * fns.c (hash_string): New function, taken from sxhash_string.
2032 Do not discard information about ASCII character case; this
2033 discarding is no longer needed.
2034 (sxhash-string): Use it. Change sig to match it. Caller changed.
2035 * lisp.h: Declare it.
2036 * lread.c (hash_string): Remove, since we now use fns.c's version.
2037 The fns.c version returns a wider integer if --with-wide-int is
2038 specified, so this should help the quality of the hashing a bit.
2039
b312a492
PE
2040 * emacs.c: Integer overflow minor fix.
2041 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2042 Define only if GNU_LINUX.
2043 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2044
dfd153ae
PE
2045 * dispnew.c: Integer signedness and overflow fixes.
2046 Remove unnecessary forward decls, that were a maintenance hassle.
2047 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2048 All uses changed.
2049 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2050 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2051 (prepare_desired_row, line_draw_cost):
2052 Use int, not unsigned, where either works.
2053 (save_current_matrix, restore_current_matrix):
2054 Use ptrdiff_t, not size_t, where either works.
2055 (init_display): Check for overflow more accurately, and without
2056 relying on undefined behavior.
2057
a81d11a3
PE
2058 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2059 Remove, replacing with the new symbols in lisp.h. All uses changed.
2060 * fileio.c (make_temp_name):
2061 * filelock.c (lock_file_1, lock_file):
2062 * xdisp.c (message_dolog):
2063 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2064 Use pMd etc. instead.
2065 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2066 replacing the pWIDE etc. symbols removed from editfns.c.
2067
3300e6fd
PE
2068 * keyboard.h (num_input_events): Now uintmax_t.
2069 This is (very slightly) less likely to mess up due to wraparound.
2070 All uses changed.
2071
fd05c7e9
PE
2072 * buffer.c: Integer signedness fixes.
2073 (alloc_buffer_text, enlarge_buffer_text):
2074 Use ptrdiff_t rather than size_t when either will do, as we prefer
2075 signed integers.
2076
903fe15d
PE
2077 * alloc.c: Integer signedness and overflow fixes.
2078 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2079 (__malloc_size_t): Default to size_t, not to int.
2080 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2081 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2082 Prefer ptrdiff_t to size_t when either would do, as we prefer
2083 signed integers.
2084 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2085 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2086 Now const. Initialize with values that are in range even if char
2087 is signed.
2088 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2089 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2090 These functions do the right thing with sizes > 2**32.
2091 (check_depth): Now ptrdiff_t, not int.
2092 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2093 Adjust to new way of storing sizes. Check for size overflow bugs
2094 in rest of code.
2095 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2096 slightly wrong anyway, as it missed one instance of
2097 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2098 (refill_memory_reserve): Omit needless cast to size_t.
2099 (mark_object_loop_halt): Mark as externally visible.
2100
ac82cc6a
PE
2101 * xselect.c: Integer signedness and overflow fixes.
2102 (Fx_register_dnd_atom, x_handle_dnd_message):
2103 Use ptrdiff_t, not size_t, since we prefer signed.
2104 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2105 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2106 x_dnd_atoms_size and x_dnd_atoms_length.
2107
c2d1e36d
PE
2108 * doprnt.c: Prefer signed to unsigned when either works.
2109 * eval.c (verror):
2110 * doprnt.c (doprnt):
2111 * lisp.h (doprnt):
2112 * xdisp.c (vmessage):
2113 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2114 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2115 prefer signed arithmetic to avoid comparison confusion.
2116 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2117 but is a bit tricky.
2118
0e926e56
PE
2119 Assume freestanding C89 headers, string.h, stdlib.h.
2120 * data.c, doprnt.c, floatfns.c, print.c:
2121 Include float.h unconditionally.
2122 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2123 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2124 * regex.c: Likewise for stddef.h, string.h.
2125 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2126 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2127 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2128 (STDC_HEADERS): Remove obsolete defines.
2129 * sysdep.c: Include limits.h unconditionally.
2130
9cfdb3ec
PE
2131 Assume support for memcmp, memcpy, memmove, memset.
2132 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2133 * regex.c (memcmp, memcpy):
2134 Remove; we assume C89 now.
2135
2136 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2137 (__malloc_safe_bcopy): Remove; no longer needed.
2138
cf950e6b 2139 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2140 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2141 well either way, and we prefer signed to unsigned.
2142
dbf38e02
LMI
21432011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2144
2145 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2146 closes the connection while we're reading (bug#9182).
2147
d6f0886c 21482011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2149
d6f0886c
JD
2150 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2151 are specified (Bug#9168).
24e0f6b1 2152
2eb1f9e6
PE
21532011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2156 Found by GCC static checking and --with-wide-int on a 32-bit host.
2157
22381272 21582011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2159
2160 * xdisp.c (compute_display_string_pos): Fix logic of caching
2161 previous display string position. Initialize cached_prev_pos to
2162 -1. Fixes slow-down at the beginning of a buffer.
2163
f25e39b4
EZ
21642011-07-24 Eli Zaretskii <eliz@gnu.org>
2165
2166 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2167 for attrs[LFACE_FONTSET_INDEX].
2168
04c4b52e
PE
21692011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 * xml.c (parse_region): Remove unused local
2172 that was recently introduced.
2173
c1734fbd
EZ
21742011-07-23 Eli Zaretskii <eliz@gnu.org>
2175
be18c5a5
EZ
2176 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2177 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2178
c1734fbd
EZ
2179 * xdisp.c (move_it_in_display_line_to): Record the best matching
2180 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2181 exit if none of the characters scanned was an exact match.
2182 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2183 when exact match is impossible due to invisible text, and the
2184 lines are truncated.
2185
a258d627
JD
21862011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2187
2188 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2189 for OSX >= 10.7.
2190
b6d5a689
EZ
21912011-07-22 Eli Zaretskii <eliz@gnu.org>
2192
0f74f785
EZ
2193 Fix a significant slow-down of cursor motion with C-n, C-p,
2194 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2195 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2196 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2197 (next_element_from_buffer): Call compute_stop_pos_backwards to
2198 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2199 base_level_stop.
2200 (reseat): Don't look for prev_stop, as that could mean a very long
2201 run.
2202 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2203 <cached_disp_overlay_modiff>: Cache for last found display string
2204 position.
551918c1 2205 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2206 about the same buffer in the same area of character positions, and
2207 the buffer wasn't changed since the time the display string
2208 position was cached.
551918c1 2209
b2d0c91a
EZ
22102011-07-22 Eli Zaretskii <eliz@gnu.org>
2211
2212 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2213 is an integer, which is important for empty lines. (Bug#9149)
2214
043604ee
CY
22152011-07-22 Chong Yidong <cyd@stupidchicken.com>
2216
2217 * frame.c (Fmodify_frame_parameters): In tty case, update the
2218 default face if necessary (Bug#4238).
2219
da4adb04
CY
22202011-07-21 Chong Yidong <cyd@stupidchicken.com>
2221
2222 * editfns.c (Fstring_to_char): No need to explain what a character
2223 is in the docstring (Bug#6576).
2224
9abd0532
LMI
22252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2226
2227 * xml.c (parse_region): Make sure we always return a tree.
2228
36881d16
HK
22292011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2230
2231 * xml.c (parse_region): If a document contains only comments,
2232 return that, too.
2233
1e98674d
LMI
22342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2235
2236 * xml.c (make_dom): Return comments, too.
2237
590bd467
PE
22382011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 Port to OpenBSD.
2241 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2242 and the surrounding thread.
2243 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2244 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2245 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2246 timer goes off.
2247 * s/openbsd.h (BROKEN_SIGIO): Define.
2248 * unexelf.c (unexec) [__OpenBSD__]:
2249 Don't update the .mdebug section of the Alpha COFF symbol table.
2250
f41628b2
LMI
22512011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2252
2253 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2254 (bug#8460).
2255
b59b67c5
PE
22562011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2257
15e3a074
PE
2258 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2259 This fixes some race conditions on the permissions of any newly
2260 created file.
2261
41bed37d
PE
2262 * alloc.c (valid_pointer_p): Use pipe, not open.
2263 This fixes some permissions issues when debugging.
2264
b59b67c5
PE
2265 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2266 If fchown fails to set both uid and gid, try to set just gid,
2267 as that is sometimes allowed. Adjust the file's mode to eliminate
2268 setuid or setgid bits that are inappropriate if fchown fails.
2269
925a6be7
SM
22702011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2271
2272 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2273 to compare Lisp_Objects.
2274 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2275 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2276 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2277
52968808
AS
22782011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2279
0a6a104b
AS
2280 * lread.c (read_integer): Unread even EOF character.
2281 (read1): Likewise. Properly record start position of symbol.
2282
52968808
AS
2283 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2284 symbol character follows.
2285
9e381cdd
PE
22862011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2289 This works around a problem with the previous change to Fcopy_file.
2290 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2291 and without this change, GCC might complain about discarding
2292 fchown's return value.
2293
b5641435
JB
22942011-07-16 Juanma Barranquero <lekktu@gmail.com>
2295
2296 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2297
a8031457
PE
22982011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2299
2300 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2301
dd889327
LMI
23022011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2303
750c33f7
LMI
2304 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2305 it's used from the C level.
2306
dd889327
LMI
2307 * process.c: Use the same condition for POLL_FOR_INPUT in both
2308 keyboard.c and process.c (bug#1858).
2309
87e86684
LM
23102011-07-09 Lawrence Mitchell <wence@gmx.li>
2311
2312 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2313 (Fgnutls_boot): Use it.
2314
64348f40
AS
23152011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2316
2317 * doc.c (Fsubstitute_command_keys): Revert last change.
2318
1d698799
LMI
23192011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2320
f863868c
LMI
2321 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2322 quotes the next character, and doesn't affect other longer
2323 sequences (bug#8935).
2324
1d698799
LMI
2325 * lread.c (syms_of_lread): Clarify that is isn't only
2326 `eval-buffer' and `eval-defun' that's affected by
2327 `lexical-binding' (bug#8460).
2328
aa4b6df6
EZ
23292011-07-15 Eli Zaretskii <eliz@gnu.org>
2330
2331 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2332 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2333
5d856da6
PE
23342011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2335
ad6042bb
PE
2336 Fix minor problems found by static checking.
2337 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2338 (elsz): Now a signed constant, not a size_t var. We prefer signed
2339 types to unsigned, to avoid integer comparison confusion. Without
2340 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2341 "cannot optimize loop, the loop counter may overflow", a symptom
2342 of the confusion.
f00bbb22 2343 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2344 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2345
6468f31c
LMI
23462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2347
49080b10
LMI
2348 * search.c (Fre_search_backward): Mention `case-fold-search' in
2349 all the re_search_* functions (bug#8138).
2350
6468f31c
LMI
2351 * keyboard.c (Fopen_dribble_file): Document when the file is
2352 closed (bug#8056).
2353
c965adc5
EZ
23542011-07-14 Eli Zaretskii <eliz@gnu.org>
2355
df9733bf
EZ
2356 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2357 bidi_cache_idx.
2358
0bb23927
EZ
2359 Support bidi reordering of display and overlay strings.
2360 * xdisp.c (compute_display_string_pos)
2361 (compute_display_string_end): Accept additional argument STRING.
2362 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2363 (reseat_to_string): Initialize bidi_it->string.s and
2364 bidi_it->string.schars.
2365 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2366 NULL (avoids a crash in bidi_paragraph_init).
2367 Initialize itb.string.lstring.
0bb23927
EZ
2368 (init_iterator): Call bidi_init_it only of a valid
2369 buffer position was specified. Initialize paragraph_embedding to
2370 L2R.
2371 (reseat_to_string): Initialize the bidi iterator.
2372 (display_string): If we need to ignore text properties of
2373 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2374 original value of -1 will not work with bidi.)
2375 (compute_display_string_pos): First arg is now struct
2376 `text_pos *'; all callers changed. Support display properties on
2377 Lisp strings.
2378 (compute_display_string_end): Support display properties on Lisp
2379 strings.
2380 (init_iterator, reseat_1, reseat_to_string): Initialize the
2381 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2382 when iterating on a string not from display properties).
640c8776
SM
2383 (compute_display_string_pos, compute_display_string_end):
2384 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2385 arrow keys.
2386 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2387 base_level_stop; instead, set base_level_stop to BEGV.
2388 Fixes crashes in vertical-motion.
0bb23927
EZ
2389 (next_element_from_buffer): Improve commentary for when
2390 the iterator is before prev_stop.
2391 (init_iterator): Initialize bidi_p from the default value of
2392 bidi-display-reordering, not from buffer-local value. Use the
2393 buffer-local value only if initializing for buffer iteration.
2394 (handle_invisible_prop): Support invisible properties on strings
2395 that are being bidi-reordered.
2396 (set_iterator_to_next): Support bidi reordering of C strings and
2397 Lisp strings.
2398 (next_element_from_string): Support bidi reordering of Lisp
2399 strings.
2400 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2401 (display_string): Support display of R2L glyph rows.
2402 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2403 (init_iterator): Don't initialize it->bidi_p for strings
2404 here.
2405 (reseat_to_string): Initialize it->bidi_p for strings here.
2406 (next_element_from_string, next_element_from_c_string)
2407 (next_element_from_buffer): Add xassert's for correspondence
2408 between IT's object being iterated and it->bidi_it.string
2409 structure.
2410 (face_before_or_after_it_pos): Support bidi iteration.
2411 (next_element_from_c_string): Handle the case of the first string
2412 character that is not the first one in the visual order.
2413 (get_visually_first_element): New function, refactored from common
2414 parts of next_element_from_buffer, next_element_from_string, and
2415 next_element_from_c_string.
2416 (tool_bar_lines_needed, redisplay_tool_bar)
2417 (display_menu_bar): Force left-to-right direction. Add a FIXME
2418 comment for making that be controlled by a user option.
2419 (push_it, pop_it): Save and restore the state of the
2420 bidi iterator. Save and restore the bidi_p flag.
2421 (pop_it): Iterate out of display property for string iteration as
2422 well.
2423 (iterate_out_of_display_property): Support iteration over strings.
2424 (handle_single_display_spec): Set up it->bidi_it for iteration
2425 over a display string, and call bidi_init_it.
2426 (handle_single_display_spec, next_overlay_string)
2427 (get_overlay_strings_1, push_display_prop): Set up the bidi
2428 iterator for displaying display or overlay strings.
2429 (forward_to_next_line_start): Don't use the shortcut if
2430 bidi-iterating.
2431 (back_to_previous_visible_line_start): If handle_display_prop
2432 pushed the iterator stack, restore the internal state of the bidi
2433 iterator by calling bidi_pop_it same number of times.
2434 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2435 and we are bidi-iterating, don't decrement the iterator position;
2436 instead, set the first_elt flag in the bidi iterator, to produce
2437 the same effect.
2438 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2439 (push_display_prop): xassert that we are iterating a buffer.
2440 (push_it, pop_it): Save and restore paragraph_embedding member.
2441 (handle_single_display_spec, next_overlay_string)
2442 (get_overlay_strings_1, reseat_1, reseat_to_string)
2443 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2444 correctly. Don't assume unibyte strings are not bidi-reordered.
2445 (compute_display_string_pos)
2446 (compute_display_string_end): Fix handling the case of C string.
2447 (push_it, pop_it): Save and restore from_disp_prop_p.
2448 (handle_single_display_spec, push_display_prop): Set the
2449 from_disp_prop_p flag.
2450 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2451 (pop_it): Call iterate_out_of_display_property only if we are
2452 popping after iteration over a string that came from a display
2453 property. Fix a typo in popping stretch info. Add an assertion
2454 for verifying that the iterator position is in sync with the bidi
2455 iterator.
2456 (handle_single_display_spec, get_overlay_strings_1)
2457 (push_display_prop): Fix initialization of paragraph direction for
2458 string when that of the parent object is not yet determined.
2459 (reseat_1): Call bidi_init_it to resync the bidi
2460 iterator with IT's position. (Bug#7616)
2461 (find_row_edges): If ROW->start.pos gives position
2462 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2463 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2464 Reset the from_disp_prop_p flag.
2465 (SAVE_IT, RESTORE_IT): New macros.
2466 (pos_visible_p, face_before_or_after_it_pos)
2467 (back_to_previous_visible_line_start)
2468 (move_it_in_display_line_to, move_it_in_display_line)
2469 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2470 (try_scrolling, redisplay_window, display_line): Use them when
2471 saving a temporary copy of the iterator and restoring it back.
2472 (back_to_previous_visible_line_start, reseat_1)
2473 (init_iterator): Empty the bidi cache "stack".
2474 (move_it_in_display_line_to): If iterator ended up at
2475 EOL, but we never saw any buffer positions smaller than
2476 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2477 motion in bidi-reordered lines.
2478 (move_it_in_display_line_to): Record prev_method and prev_pos
2479 immediately before the call to set_iterator_to_next. Fixes cursor
2480 motion in bidi-reordered lines with stretch glyphs and strings
2481 displayed in margins. (Bug#8133) (Bug#8867)
2482 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2483 TO_CHARPOS.
640c8776
SM
2484 (pos_visible_p): Support positions in bidi-reordered lines.
2485 Save and restore bidi cache.
0bb23927
EZ
2486
2487 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2488 (bidi_paragraph_info): Delete unused struct.
2489 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2490 (bidi_cache_start): New variable.
2491 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2492 to zero.
2493 (bidi_cache_fetch_state, bidi_cache_search)
2494 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2495 (bidi_cache_find, bidi_peek_at_next_level)
2496 (bidi_level_of_next_char, bidi_find_other_level_edge)
2497 (bidi_move_to_visually_next): Compare cache index with
2498 bidi_cache_start rather than with zero.
2499 (bidi_fetch_char): Accept new argument STRING; all callers
2500 changed. Support iteration over a string. Support strings with
2501 display properties. Support unibyte strings. Fix the type of
2502 `len' according to what STRING_CHAR_AND_LENGTH expects.
2503 (bidi_paragraph_init, bidi_resolve_explicit_1)
2504 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2505 (bidi_level_of_next_char, bidi_move_to_visually_next):
2506 Support iteration over a string.
0bb23927
EZ
2507 (bidi_set_sor_type, bidi_resolve_explicit_1)
2508 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2509 can now be zero (for strings); special values 0 and -1 were
2510 changed to -1 and -2, respectively.
2511 (bidi_char_at_pos): New function.
2512 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2513 Call it instead of FETCH_MULTIBYTE_CHAR.
2514 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2515 initialized to valid values.
2516 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2517 values.
2518 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2519 the test for valid cached positions. Fix the logic for looking up
2520 the sentinel state in the cache. GCPRO the Lisp string we are
2521 iterating.
2522 (bidi_push_it, bidi_pop_it): New functions.
2523 (bidi_initialize): Initialize the bidi cache start stack pointer.
2524 (bidi_cache_ensure_space): New function, refactored from part of
2525 bidi_cache_iterator_state. Don't assume the required size is just
2526 one BIDI_CACHE_CHUNK away.
2527 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2528 (bidi_count_bytes, bidi_char_at_pos): New functions.
2529 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2530 always valid if bidi_cache_idx is valid.
2531 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2532 is valid if it's going to be used.
2533 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2534 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2535 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2536 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2537 (bidi_find_other_level_edge, bidi_cache_start_stack):
2538 All variables related to cache indices are now EMACS_INT.
c965adc5 2539
0bb23927
EZ
2540 * dispextern.h (struct bidi_string_data): New structure.
2541 (struct bidi_it): New member `string'. Make flag members be 1-bit
2542 fields, and put them last in the struct.
640c8776
SM
2543 (compute_display_string_pos, compute_display_string_end):
2544 Update prototypes.
0bb23927
EZ
2545 (bidi_push_it, bidi_pop_it): Add prototypes.
2546 (struct iterator_stack_entry): New members bidi_p,
2547 paragraph_embedding, and from_disp_prop_p.
2548 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2549 (bidi_shelve_cache, bidi_unshelve_cache):
2550 Declare prototypes.
0bb23927
EZ
2551
2552 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2553 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2554 and vector-like objects.
2555
2556 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2557 cache around display iteration.
2558
2559 * window.c (Fwindow_end, window_scroll_pixel_based)
2560 (displayed_window_lines, Frecenter): Save and restore the bidi
2561 cache around display iteration.
2562
3bbd2265
LMI
25632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2564
2565 * editfns.c (Fdelete_region): Clarify the use of the named
2566 parameters (bug#6788).
2567
adc47434
MR
25682011-07-14 Martin Rudalics <rudalics@gmx.at>
2569
2570 * indent.c (Fvertical_motion): Set and restore w->pointm when
2571 saving and restoring the window's buffer (Bug#9006).
2572
837c31f8
LMI
25732011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2574
2575 * editfns.c (Fstring_to_char): Clarify just what is returned
2576 (bug#6576). Text by Eli Zaretskii.
2577
ac389d0c
JB
25782011-07-13 Juanma Barranquero <lekktu@gmail.com>
2579
2580 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2581
0be0ce47
EZ
25822011-07-13 Eli Zaretskii <eliz@gnu.org>
2583
2584 * buffer.c (mmap_find): Fix a typo.
2585
cd18e7e3
JB
25862011-07-13 Johan Bockgård <bojohan@gnu.org>
2587
2588 Fix execution of x selection hooks.
2589 * xselect.c (Qx_lost_selection_functions)
2590 (Qx_sent_selection_functions): New vars.
2591 (syms_of_xselect): DEFSYM them.
2592 (x_handle_selection_request): Pass Qx_sent_selection_functions
2593 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2594 (x_handle_selection_clear,x_clear_frame_selections):
2595 Pass Qx_lost_selection_functions rather than
2596 Vx_lost_selection_functions to Frun_hook_with_args.
2597
47ea7f44
PE
25982011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2599
ac389d0c 2600 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2601 The old code sometimes used this field without initializing it.
2602
47ea7f44
PE
2603 * alloc.c (gc_sweep): Don't read past end of array.
2604 In theory, the old code could also have corrupted Emacs internals,
2605 though it'd be very unlikely.
2606
bc985c87
AS
26072011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2608
2609 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2610 argument. (Bug#4026)
bc985c87 2611
0cf34688
LMI
26122011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2613
b3dadd76
LMI
2614 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2615 key" (bug#4257).
2616
0cf34688
LMI
2617 * window.c (Fset_window_start): Doc fix (bug#4199).
2618 (Fset_window_hscroll): Ditto.
2619
270768cd
PE
26202011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2621
077e3dda 2622 Fix minor new problems caught by GCC 4.6.1.
270768cd 2623 * term.c (init_tty): Remove unused local.
490011a6 2624 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2625 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2626 not used otherwise.
270768cd 2627
b1f58454
CY
26282011-07-12 Chong Yidong <cyd@stupidchicken.com>
2629
2630 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2631
22b9578d
LMI
26322011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2633
6e70ab07
LMI
2634 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2635 are the mini-buffer and the echo area (bug#3320).
2636
22b9578d
LMI
2637 * term.c (init_tty): Remove support for supdup, c10 and perq
2638 terminals, which are no longer supported (bug#1482).
2639
8974cc9f
JB
26402011-07-10 Johan Bockgård <bojohan@gnu.org>
2641
2642 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2643
a560d974
JD
26442011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2645
2646 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2647 for non-popups (Bug#3642).
2648
1dae0f0a
AS
26492011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2650
268c2c36 2651 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2652 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2653 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2654 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2655 * data.c (fmod): Likewise.
2656 * dispnew.c (swap_glyphs_in_rows): Likewise.
2657 * emacs.c (memory_warning_signal): Likewise.
2658 * floatfns.c (float_error): Likewise.
2659 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2660 (otf_open, font_otf_capability, generate_otf_features)
2661 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2662 Likewise.
2663 * image.c (pbm_read_file): Likewise.
2664 * indent.c (string_display_width): Likewise.
2665 * intervals.c (check_for_interval, search_for_interval)
2666 (inc_interval_count, count_intervals, root_interval)
2667 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2668 * lread.c (defalias): Likewise.
268c2c36 2669 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2670 * regex.c (set_image_of_range_1, set_image_of_range)
2671 (regex_grow_registers): Likewise.
2672 * sysdep.c (strerror): Likewise.
2673 * termcap.c (valid_filename_p, tprint, main): Likewise.
2674 * tparam.c (main): Likewise.
2675 * unexhp9k800.c (run_time_remap, save_data_space)
2676 (update_file_ptrs, read_header, write_header, calculate_checksum)
2677 (copy_file, copy_rest, display_header): Likewise.
2678 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2679 Likewise.
2680 * xdisp.c (check_it): Likewise.
2681 * xfaces.c (register_color, unregister_color, unregister_colors):
2682 Likewise.
2683 * xfns.c (print_fontset_result): Likewise.
2684 * xrdb.c (member, fatal, main): Likewise.
2685
99033785
PE
26862011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2687
2688 Fix minor problems found by static checking (Bug#9031).
2689 * chartab.c (char_table_set_range, map_sub_char_table):
2690 Remove unused locals.
2691 (uniprop_table): Now static.
2692 * composite.c (_work_char): Remove unused static var.
2693
9cb2ac56
JB
26942011-07-09 Juanma Barranquero <lekktu@gmail.com>
2695
2696 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2697
f25661f0
JD
26982011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2699
2700 * gtkutil.c (qttip_cb): Remove code without function.
2701
8278c4fe
EZ
27022011-07-09 Eli Zaretskii <eliz@gnu.org>
2703
2704 * w32.c (pthread_sigmask): New stub.
2705
1692ae2d 27062011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2707
8a6ebd58 2708 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2709 sigprocmask is portable only for single-threaded applications, and
2710 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2711 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2712 (LIBES): Use it.
2713 * callproc.c (Fcall_process):
2714 * process.c (create_process):
2715 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2716 Use pthread_sigmask, not sigprocmask.
123403e4 2717
1b854618
JD
27182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2719
2720 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2721 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2722 wrong (Bug#8591).
2723
3fe4b549
JD
27242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2725
0ce7e563
JD
2726 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2727 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2728 (xg_hide_tooltip): Fix comment.
2729
3fe4b549
JD
2730 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2731 in registerServicesMenuSendTypes.
2732 (validRequestorForSendType): Don't check ns_return_types.
2733
2734 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2735 ns_return_type.
2736
5df75e47
JR
27372011-07-08 Jason Rumney <jasonr@gnu.org>
2738
2739 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2740 frame struct members of non-existent frames (Bug#6284).
2741
699c10bd
JD
27422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2743
4393663b
JD
2744 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2745 variable firstTime not needed on OSX >= 10.6.
2746 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2747 >= 10.5. Use setKnobProportion, setDoubleValue.
2748
2749 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2750 (MAC_OS_X_VERSION_10_5): Define if not defined.
2751 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2752 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2753 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2754
2755 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2756 cString and lossyCString on OSX >= 10.4
2757
2758 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2759 sizeToFit on OSX >= 10.2.
2760
2761 * nsimage.m (allocInitFromFile): Don't use deprecated method
2762 bestRepresentationForDevice on OSX >= 10.6.
2763
2764 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2765 to avoid warning.
2766
2767 * emacs.c: Declare unexec_init_emacs_zone.
2768
a63e0781
JD
2769 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2770
699c10bd
JD
2771 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2772
2773 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2774 on svcsMenu (Bug#8842).
2775
2776 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2777 ns_return_types.
2778 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2779
2780 * nsterm.m (QUTF8_STRING): Declare.
2781 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2782 (validRequestorForSendType): Return type is (id).
2783 Change indexOfObjectIdenticalTo to indexOfObject.
2784 Check if we have local selection before returning self (Bug#8842).
2785 (writeSelectionToPasteboard): Put local selection into paste board
2786 if we have a local selection (Bug#8842).
2787 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2788
2789 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2790 (ns_get_local_selection): Declare.
2791
54e10184
LMI
27922011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2793
9888ff71
LMI
2794 * keymap.c (describe_map_tree): Don't insert a double newline at
2795 the end of the buffer (bug#1169) and return whether we inserted
2796 something.
2797
54e10184
LMI
2798 * callint.c (Fcall_interactively): Change "reading args" to
2799 "providing args" to try to clarify what it does (bug#1010).
2800
15fa4783
KH
28012011-07-07 Kenichi Handa <handa@m17n.org>
2802
2803 * composite.c (composition_compute_stop_pos): Ignore a static
2804 composition starting before CHARPOS (Bug#8915).
2805
2806 * xdisp.c (handle_composition_prop): Likewise.
2807
a8815b00
EZ
28082011-07-07 Eli Zaretskii <eliz@gnu.org>
2809
2810 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2811 (Bug#9015)
2812
ef7b981d 28132011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2814
2815 * character.h (unicode_category_t): New enum type.
2816
2817 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2818 (Qchar_code_property_table): New variable.
2819 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2820 (UNIPROP_COMPRESSED_FORM_P): New macros.
2821 (char_table_ascii): Uncompress the compressed values.
2822 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2823 Uncompress the compressed values.
ac389d0c 2824 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2825 (char_table_ref_and_range): Uncompress the compressed values.
2826 (sub_char_table_set): New arg is_uniprop. Callers changed.
2827 Uncompress the compressed values.
2828 (sub_char_table_set_range): Args changed. Callers changed.
2829 (char_table_set_range): Adjuted for the above change.
2830 (map_sub_char_table): Delete args default_val and parent. Add arg
2831 top. Give decoded values to a Lisp function.
640c8776 2832 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2833 values to a Lisp function. Gcpro more variables.
2834 (uniprop_table_uncompress)
2835 (uniprop_decode_value_run_length): New functions.
2836 (uniprop_decoder, uniprop_decoder_count): New variables.
2837 (uniprop_get_decoder, uniprop_encode_value_character)
2838 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2839 New functions.
2840 (uniprop_encoder, uniprop_encoder_count): New variables.
2841 (uniprop_get_encoder, uniprop_table)
2842 (Funicode_property_table_internal, Fget_unicode_property_internal)
2843 (Fput_unicode_property_internal): New functions.
2844 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2845 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2846 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2847 char-code-property-alist.
2848
640c8776 2849 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2850 Vunicode_category_table.
2851
640c8776 2852 * font.c (font_range): Adjust for the change of
c805dec0
KH
2853 Vunicode_category_table.
2854
76b397fb
DN
28552011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2856
2857 * m/iris4d.h: Remove file, move contents ...
2858 * s/irix6-5.h: ... here.
2859
22b4128e
PE
28602011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2861
2862 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2863 * alloc.c (mark_buffer):
2864 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2865 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2866 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2867 This isn't true in general, and it's particularly not true
2868 if Emacs is configured with --with-wide-int.
2869 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2870 New macros, used in the buffer.c change.
2871
869795d6
JD
28722011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2873
2874 * xsettings.c: Use both GConf and GSettings if both are available.
2875 (store_config_changed_event): Add comment.
2876 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2877 (store_tool_bar_style_changed): New functions.
5e617bc2 2878 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2879 (struct xsettings): Move font inside HAVE_XFT.
2880 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2881 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2882 Move inside HAVE_XFT.
640c8776 2883 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2884 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2885 also.
2886 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2887 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2888 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2889 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2890 (parse_settings): Move check for font inside HAVE_XFT.
2891 (read_settings, apply_xft_settings): Add comment.
2892 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2893 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2894 call store_font_name_changed.
2895 (xft_settings_event): Add comment.
2896 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2897 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2898 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2899 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2900 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2901 (xsettings_get_system_font, xsettings_get_system_normal_font):
2902 Add comment.
869795d6 2903
d8ed26bd
PE
29042011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2905
2906 Random fixes. E.g., (random) never returned negative values.
2907 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2908 subseconds part to the entropy, as that's a bit more random.
2909 Prefer signed to unsigned, since the signedness doesn't matter and
2910 in general we prefer signed. When given a limit, use a
2911 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2912 latter isn't right if USE_2_TAGS_FOR_INTS.
2913 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2914 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2915
cabf1cac
SM
29162011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2917
2918 * textprop.c (text_property_stickiness):
2919 Obey Vtext_property_default_nonsticky.
2920 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2921 * w32fns.c (syms_of_w32fns):
2922 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2923
6e9b2be9
PE
29242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2927 This is more efficient than Ffile_directory_p and avoids a minor race.
2928
90186c68
LMI
29292011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2930
7c301272
LMI
2931 * buffer.c (Foverlay_put): Say what the return value is
2932 (bug#7835).
2933
c4f2d8d4
LMI
2934 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2935 is a directory before asking whether to use the file name
2936 (bug#7564).
ad637907
LMI
2937 (barf_or_query_if_file_exists): Make the "File is a directory"
2938 error be more correct.
c4f2d8d4 2939
90186c68
LMI
2940 * fns.c (Frequire): Remove the mention of the .gz files, since
2941 that's installation-specific, but keep the mention of
2942 `get-load-suffixes'.
2943
da64016e
PE
29442011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2945
2946 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2947 Report string overflow if the output is too long.
2948
7d47b580
JB
29492011-07-04 Juanma Barranquero <lekktu@gmail.com>
2950
a555cb87
JB
2951 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2952 (syms_of_gnutls): Remove duplicate DEFSYM for
2953 Qgnutls_bootprop_verify_hostname_error, an error for
2954 Qgnutls_bootprop_verify_error (which is no longer used).
2955
7d47b580
JB
2956 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2957 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2958 Also (re)move comments that are misplaced or no longer relevant.
2959
1e49bfab
LMI
29602011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2961
2962 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2963
1485f4c0
CY
29642011-07-03 Chong Yidong <cyd@stupidchicken.com>
2965
2966 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2967 and background color parameters if they have been changed.
2968
a9ab721e
LMI
29692011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2970
2971 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2972
cf7cff57
PE
29732011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2974
2e13213d
PE
2975 * xsettings.c (SYSTEM_FONT): Define only when used.
2976 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2977
cf7cff57
PE
2978 * keymap.c (access_keymap_1): Now static.
2979
7a8e04f7
CY
29802011-07-02 Chong Yidong <cyd@stupidchicken.com>
2981
2982 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2983 leave any prefix arg for the up event (Bug#1586).
2984
61352f62
LMI
29852011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2986
69bb1ef7
LMI
2987 * lread.c (syms_of_lread): Mention single symbols defined by
2988 `defvar' or `defconst' (bug#7154).
2989
61352f62 2990 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2991 (Frequire): Mention get-load-suffixes.
61352f62 2992
28545e04
MR
29932011-07-02 Martin Rudalics <rudalics@gmx.at>
2994
2995 * window.h (window): Remove clone_number slot.
2996 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2997 Remove.
2998 (make_parent_window, make_window, saved_window)
2999 (Fset_window_configuration, save_window_save): Don't deal with
3000 clone numbers.
3001 * buffer.c (Qclone_number): Remove declaration.
3002 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3003
3349e122
SM
30042011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3005
3006 Add multiple inheritance to keymaps.
3007 * keymap.c (Fmake_composed_keymap): New function.
3008 (Fset_keymap_parent): Simplify.
3009 (fix_submap_inheritance): Remove.
3010 (access_keymap_1): New function extracted from access_keymap to handle
3011 embedded parents and handle lists of maps.
3012 (access_keymap): Use it.
3013 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3014 (Fcopy_keymap): Handle embedded parents.
3015 (Fcommand_remapping, define_as_prefix): Simplify.
3016 (Fkey_binding): Simplify.
3017 (syms_of_keymap): Move minibuffer-local-completion-map,
3018 minibuffer-local-filename-completion-map,
3019 minibuffer-local-must-match-map, and
3020 minibuffer-local-filename-must-match-map to Elisp.
3021 (syms_of_keymap): Defsubr make-composed-keymap.
3022 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3023 (parse_menu_item): Trivial simplification.
3024
3279eb87
GM
30252011-07-01 Glenn Morris <rgm@gnu.org>
3026
3027 * Makefile.in (SETTINGS_LIBS): Fix typo.
3028
4550efdf
KI
30292011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3030
3031 * coding.c (Fencode_coding_string): Record the last coding system
3032 used, as the function doc string says (bug#8738).
3033
0949d2b6
JD
30342011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3035
3036 * xsettings.c (store_monospaced_changed): Take new font as arg and
3037 check for change against current_mono_font.
3038 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3039 (emacs_settings_constructor, emacs_settings_get_property)
3040 (emacs_settings_set_property, emacs_settings_class_init)
3041 (emacs_settings_init, gsettings_obj): Remove.
3042 (something_changedCB): New function for HAVE_GSETTINGS.
3043 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3044 with value as argument.
3045 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3046 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3047 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3048 "changed".
3049
3050 * xgselect.c: Add defined (HAVE_GSETTINGS).
3051 (xgselect_initialize): Ditto.
3052
3053 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3054 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3055 xg_select.
3056
bbc6b304
PE
30572011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 * eval.c (struct backtrace): Simplify and port the data structure.
3060 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3061 signed bit field, as this assumption is not portable and it makes
3062 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3063 "char debug_on_exit : 1" as this is not portable either; instead,
3064 use the portable "unsigned int debug_on_exit : 1". Remove unused
3065 member evalargs. Remove obsolete comments about cc bombing out.
3066
9851bfc5
JD
30672011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3068
51bb811f 3069 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3070 Let HAVE_GSETTINGS override HAVE_GCONF.
3071 (store_monospaced_changed): New function.
3072 (EMACS_SETTINGS): A new type derived from GObject to handle
3073 GSettings notifications.
3074 (emacs_settings_constructor, emacs_settings_get_property)
3075 (emacs_settings_set_property, emacs_settings_class_init):
3076 New functions.
3077 (gsettings_client, gsettings_obj): New variables.
3078 (GSETTINGS_SCHEMA): New define.
3079 (something_changedCB): Call store_monospaced_changed.
3080 (init_gsettings): New function.
3081 (xsettings_initialize): Call init_gsettings.
3082 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3083 to NULL.
3084
640c8776 3085 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3086 GCONF_CFLAGS/LIBS.
3087
5386012d
MR
30882011-06-29 Martin Rudalics <rudalics@gmx.at>
3089
3090 * window.c (resize_root_window, grow_mini_window)
3091 (shrink_mini_window): Rename Qresize_root_window to
3092 Qwindow_resize_root_window and Qresize_root_window_vertically to
3093 Qwindow_resize_root_window_vertically.
3094
f13e0b08
PE
30952011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3096
3097 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3098
94515237
JB
30992011-06-27 Juanma Barranquero <lekktu@gmail.com>
3100
3101 * makefile.w32-in: Redesign dependencies so they reflect more
3102 clearly which files are directly included by each source file,
3103 and not through other includes.
3104
e43b6e43
MR
31052011-06-27 Martin Rudalics <rudalics@gmx.at>
3106
3107 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3108 (sort_overlays, overlay_strings): When an overlay's clone number
3109 matches the window's clone number process the overlay even if
3110 the overlay's window property doesn't match the current window.
3111
d68443dc
MR
3112 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3113 (Fwindow_hchild): Rename to Fwindow_left_child.
3114 (Fwindow_next): Rename to Fwindow_next_sibling.
3115 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3116 (resize_window_check): Rename to window_resize_check.
3117 (resize_window_apply): Rename to window_resize_apply.
3118 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3119 (Fdelete_other_windows_internal, resize_frame_windows)
3120 (Fsplit_window_internal, Fdelete_window_internal)
3121 (grow_mini_window, shrink_mini_window)
3122 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3123
c7e73be5
JD
31242011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3125
3126 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3127 (emacs_fixed_set_min_size): Remove.
3128 (emacs_fixed_new): Take frame as argument.
3129
3130 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3131 (_EmacsFixedPrivate): Remove minwidth/height.
3132 Add struct frame *f.
3133 (emacs_fixed_init): Initialize priv->f.
3134 (get_parent_class, emacs_fixed_set_min_size): Remove.
3135 (emacs_fixed_new): Set priv->f to argument.
3136 (emacs_fixed_get_preferred_width)
3137 (emacs_fixed_get_preferred_height): Use min_width/height from
3138 frames size_hint to set minimum and natural (Bug#8919).
3139 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3140 and use min_width/height from frames size_hint to set
3141 min_width/height (Bug#8919).
3142
3143 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3144 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3145 Fix indentation.
c7e73be5 3146
cf99dcf8
EZ
31472011-06-26 Eli Zaretskii <eliz@gnu.org>
3148
3149 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3150 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3151 called at ZV.
3152
029529ac
CY
31532011-06-26 Chong Yidong <cyd@stupidchicken.com>
3154
3155 * process.c (wait_reading_process_output): Bypass select if
3156 waiting for a cell while ignoring keyboard input, and input is
3157 pending. Suggested by Jan Djärv (Bug#8869).
3158
7a7ef429
PE
31592011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 Use gnulib's dup2 module instead of rolling our own.
3162 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3163
11fdef7d 31642011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3165
3166 * dispnew.c (scrolling_window): Before scrolling, turn off a
3167 mouse-highlight in the window being scrolled.
3168
cd3520a4
JB
31692011-06-24 Juanma Barranquero <lekktu@gmail.com>
3170
3171 Move DEFSYM to lisp.h and use everywhere.
3172
3173 * character.h (DEFSYM): Move declaration...
3174 * lisp.h (DEFSYM): ...here.
3175
3176 * gnutls.c:
3177 * minibuf.c:
3178 * w32menu.c:
3179 * w32proc.c:
3180 * w32select.c: Don't include character.h.
3181
3182 * alloc.c (syms_of_alloc):
3183 * buffer.c (syms_of_buffer):
3184 * bytecode.c (syms_of_bytecode):
3185 * callint.c (syms_of_callint):
3186 * casefiddle.c (syms_of_casefiddle):
3187 * casetab.c (init_casetab_once):
3188 * category.c (init_category_once, syms_of_category):
3189 * ccl.c (syms_of_ccl):
3190 * cmds.c (syms_of_cmds):
3191 * composite.c (syms_of_composite):
3192 * dbusbind.c (syms_of_dbusbind):
3193 * dired.c (syms_of_dired):
3194 * dispnew.c (syms_of_display):
3195 * doc.c (syms_of_doc):
3196 * editfns.c (syms_of_editfns):
3197 * emacs.c (syms_of_emacs):
3198 * eval.c (syms_of_eval):
3199 * fileio.c (syms_of_fileio):
3200 * fns.c (syms_of_fns):
3201 * frame.c (syms_of_frame):
3202 * fringe.c (syms_of_fringe):
3203 * insdel.c (syms_of_insdel):
3204 * keymap.c (syms_of_keymap):
3205 * lread.c (init_obarray, syms_of_lread):
3206 * macros.c (syms_of_macros):
3207 * msdos.c (syms_of_msdos):
3208 * print.c (syms_of_print):
3209 * process.c (syms_of_process):
3210 * search.c (syms_of_search):
3211 * sound.c (syms_of_sound):
3212 * syntax.c (init_syntax_once, syms_of_syntax):
3213 * terminal.c (syms_of_terminal):
3214 * textprop.c (syms_of_textprop):
3215 * undo.c (syms_of_undo):
3216 * w32.c (globals_of_w32):
3217 * window.c (syms_of_window):
3218 * xdisp.c (syms_of_xdisp):
3219 * xfaces.c (syms_of_xfaces):
3220 * xfns.c (syms_of_xfns):
3221 * xmenu.c (syms_of_xmenu):
3222 * xsettings.c (syms_of_xsettings):
3223 * xterm.c (syms_of_xterm): Use DEFSYM.
3224
4228cf16
TZ
32252011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3226
cd3520a4 3227 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3228
7fcccf1e
PE
32292011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3230
7efb4e0e
PE
3231 Integer and buffer overflow fixes (Bug#8873).
3232
ff5844ad
PE
3233 * print.c (printchar, strout): Check for string overflow.
3234 (PRINTPREPARE, printchar, strout):
3235 Don't set size unless allocation succeeds.
3236
90532f02
PE
3237 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3238 for sizes. Check for string overflow more accurately.
3239 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3240
6d84508d
PE
3241 * macros.c: Integer and buffer overflow fixes.
3242 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3243 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3244 Use ptrdiff_t, not int, for sizes.
3245 Don't increment bufsize until after realloc succeeds.
3246 Check for size-calculation overflow.
3247 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3248
437b2cb4
PE
3249 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3250
8b9ac8b4
PE
3251 * lread.c: Integer overflow fixes.
3252 (read_integer): Radix is now EMACS_INT, not int,
3253 to improve quality of diagnostics for out-of-range radices.
3254 Calculate buffer size correctly for out-of-range radices.
3255 (read1): Check for integer overflow in radices, and in
3256 read-circle numbers.
82cb60d3
PE
3257 (read_escape): Avoid int overflow.
3258 (Fload, openp, read_buffer_size, read1)
3259 (substitute_object_recurse, read_vector, read_list, map_obarray):
3260 Use ptrdiff_t, not int, for sizes.
3261 (read1): Use EMACS_INT, not int, for sizes.
20270765 3262 Check for size overflow.
8b9ac8b4 3263
7fcccf1e
PE
3264 * image.c (cache_image): Check for size arithmetic overflow.
3265
bfbbd7e7
PE
3266 * lread.c: Integer overflow issues.
3267 (saved_doc_string_size, saved_doc_string_length)
3268 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3269 Now ptrdiff_t, not int.
3270 (read1): Don't assume doc string length fits in int. Check for
3271 out-of-range doc string lengths.
3272 (read_list): Don't assume file position fits in int.
39019e54 3273 (read_escape): Check for hex character overflow.
bfbbd7e7 3274
4e323265
LL
32752011-06-22 Leo Liu <sdl.web@gmail.com>
3276
3277 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3278 Move to minibuffer.el.
3279
85fece3e
PE
32802011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3281
20b84ce9 3282 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3283 The following patches are for when GLYPH_DEBUG && !XASSERT.
3284 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3285 * dispnew.c (flush_stdout):
3286 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3287 Mark as externally visible.
3288 * dispnew.c (check_window_matrix_pointers): Now static.
3289 * dispnew.c (window_to_frame_vpos):
3290 * xfns.c (unwind_create_frame):
3291 * xterm.c (x_check_font): Remove unused local.
3292 * scroll.c (CHECK_BOUNDS):
3293 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3294 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3295 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3296 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3297 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3298 Now static.
3299 (debug_method_add): Use va_list and vsprintf rather than relying
3300 on undefined behavior with wrong number of arguments.
3301 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3302 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3303 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3304 since we're not interested in debugging glyphs with old libraries.
3305 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3306 GCC 4.6.0's static checking.
3307
0766b489
PE
33082011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3309
31fd4b32
PE
3310 Integer overflow and signedness fixes (Bug#8873).
3311 A few related buffer overrun fixes, too.
3312
b79e8648
PE
3313 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3314
0766b489
PE
3315 * dispextern.h (struct face.stipple):
3316 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3317 (x_bitmap_mask, x_allocate_bitmap_record)
3318 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3319 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3320 (x_create_bitmap_from_xpm_data):
3321 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3322 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3323 (.bitmaps_last):
3324 * xfaces.c (load_pixmap):
3325 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3326 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3327 (.bitmaps_last, struct x_output.icon_bitmap):
3328 Use ptrdiff_t, not int, for bitmap indexes.
3329 (x_allocate_bitmap_record): Check for size overflow.
3330 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3331
b081724f
PE
3332 Use ptrdiff_t, not int, for overlay counts.
3333 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3334 * editfns.c (overlays_around, get_pos_property):
3335 * textprop.c (get_char_property_and_overlay):
3336 * xdisp.c (next_overlay_change, note_mouse_highlight):
3337 * xfaces.c (face_at_buffer_position):
21514da7
PE
3338 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3339 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3340 (Fnext_overlay_change, Fprevious_overlay_change)
3341 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3342 Use ptrdiff_t, not int, for sizes.
21514da7 3343 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3344
3de73e5e
PE
3345 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3346
2606c57b
PE
3347 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3348 (x_session_initialize): Do not assume string length fits in int.
3349
aaafe47a
PE
3350 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3351 This is unlikely, but can occur if DPI is outlandish.
3352
2674ddc8 3353 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3354 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3355
28154962
PE
3356 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3357 * xrdb.c (magic_file_p, search_magic_path):
3358 Omit last arg SUFFIX; it was always 0. All callers changed.
3359 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3360
7de51af5
PE
3361 * xfont.c (xfont_match): Avoid need for strlen.
3362
25ed6cc3
PE
3363 * xfns.c: Don't assume strlen fits in int.
3364 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3365
4eab31dd
PE
3366 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3367 not unsigned long, as we prefer signed integers. All callers changed.
3368 Detect integer overflow in repeat count.
3369 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3370 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3371
171e2a58
PE
3372 * termcap.c: Don't assume sizes fit in int and never overflow.
3373 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3374 (gobble_line): Check for size-calculation overflow.
3375
ad39faca 3376 * minibuf.c (Fread_buffer):
6e5bb2dc 3377 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3378 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3379 Don't assume string length fits in int.
3380
52c61c22 3381 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3382 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3383
b5b8c9e5
PE
3384 * font.c: Don't assume string length fits in int.
3385 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3386 Use ptrdiff_t, not int.
ccd6111c
PE
3387 (font_intern_prop): Don't assume string length fits in int.
3388 Don't assume integer property fits in fixnum.
3389 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3390
882f0d81 3391 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3392 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3393 Reformulate so as not to need the command string.
3394 Invoke gzip -cd rather than gunzip, as it's more portable.
3395 (lock_info_type, lock_file_1, lock_file):
3396 Don't assume pid_t and time_t fit in unsigned long.
3397 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3398 (current_lock_owner): Prefer signed type for sizes.
3399 Use memcpy, not strncpy, where memcpy is what is really wanted.
3400 Don't assume (via atoi) that time_t and pid_t fit in int.
3401 Check for time_t and/or pid_t out of range, e.g., via a network share.
3402 Don't alloca where an auto var works fine.
3403
93f4cf88
PE
3404 * fileio.c: Fix some integer overflow issues.
3405 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3406 Don't assume string length fits in int.
3407 (directory_file_name): Don't assume string length fits in long.
3408 (make_temp_name): Don't assume pid fits in int, or that its print
3409 length is less than 20.
3410
f3e92b69
PE
3411 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3412
1bfdaf10
PE
3413 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3414
35016e9a
PE
3415 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3416
3d1e65a1
PE
3417 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3418 We prefer signed integers, even for size calculations.
3419
0b963a93
PE
3420 * emacs.c: Don't assume string length fits in 'int'.
3421 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3422 (main): Don't invoke strlen when not needed.
3423
573f4b54
PE
3424 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3425 (XD_DEBUG_MESSAGE): Don't waste a byte.
3426
989f33ba
PE
3427 * callproc.c (getenv_internal_1, getenv_internal)
3428 (Fgetenv_internal):
965d34eb
PE
3429 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3430
e4d29b33
PE
3431 * lread.c (invalid_syntax): Omit length argument.
3432 All uses changed. This doesn't fix a bug, but it simplifies the
3433 code away from its former Hollerith-constant appearance, and it's
3434 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3435 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3436
eb49b136
PE
3437 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3438 This didn't break anything, but it didn't help either.
3439 It's confusing to put a bogus integer in a place where the actual
3440 value does not matter.
9f62aeb1 3441 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3442 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3443
15375a22
PE
3444 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3445 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3446 implementation.
b61cc01c
PE
3447 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3448 We prefer signed types, and the value cannot exceed the EMACS_INT
3449 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3450 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3451 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3452 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3453
53b2623d
PE
3454 * indent.c (sane_tab_width): New function.
3455 (current_column, scan_for_column, Findent_to, position_indentation)
3456 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3457 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3458
51cab52b 3459 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3460
f2ed8a70
PE
3461 * lisp.h (lint_assume): New macro.
3462 * composite.c (composition_gstring_put_cache):
3463 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3464
abe80cc6
PE
3465 * editfns.c, insdel.c:
3466 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3467
b02c740e
PE
3468 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3469
ebc96716
PE
3470 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3471
b4e50fa0 3472 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3473 Use much-faster test for byte-length change.
311d5d7c 3474 Don't assume string byte-length fits in 'int'.
a4cf38e4 3475 Check that character arg fits in 'int'.
85461888 3476 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3477
c0c1ee9f
PE
3478 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3479
a498d7f4
PE
3480 * fns.c (concat): Catch string overflow earlier.
3481 Do not rely on integer wraparound.
3482
51cab52b
PE
3483 * dispextern.h (struct it.overlay_strings_charpos)
3484 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3485 * xdisp.c (forward_to_next_line_start)
3486 (back_to_previous_visible_line_start)
3487 (reseat_at_next_visible_line_start, next_element_from_buffer):
3488 Don't arbitrarily truncate the value of 'selective' to int.
3489
76031fad
PE
3490 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3491
5eb55db9
PE
3492 * composite.c: Don't truncate sizes to 'int'.
3493 (composition_gstring_p, composition_reseat_it)
3494 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3495 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3496 not EMACS_UINT, for indexes.
5eb55db9 3497
0703a717
PE
3498 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3499
d6202519
PE
3500 * buffer.c: Include <verify.h>.
3501 (struct sortvec.priority, struct sortstr.priority):
8961a454 3502 Now EMACS_INT, not int.
c20998a7 3503 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3504 (struct sortstr.size, record_overlay_string)
3505 (struct sortstrlist.size, struct sortlist.used):
3506 Don't truncate size to int.
3507 (record_overlay_string): Check for size-calculation overflow.
d6202519 3508 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3509
d5a19415
JM
35102011-06-22 Jim Meyering <meyering@redhat.com>
3511
029529ac 3512 Don't leak an XBM-image-sized buffer
d5a19415
JM
3513 * image.c (xbm_load): Free the image buffer after using it.
3514
a9041e6c
PE
35152011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 Port to Sun C.
3518 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3519 that Sun C diagnosed.
3520 * fns.c (secure_hash): Fix pointer signedness issue.
3521 * intervals.c (static_offset_intervals): New function.
3522 (offset_intervals): Use it.
3523
7f3f739f
LL
35242011-06-21 Leo Liu <sdl.web@gmail.com>
3525
3526 * deps.mk (fns.o):
3527 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3528 sha512.h.
3529
3530 * fns.c (secure_hash): Rename from crypto_hash_function and change
3531 the first arg to accept symbols.
5b66d427 3532 (Fsecure_hash): New primitive.
7f3f739f
LL
3533 (syms_of_fns): New symbols.
3534
76147d94
DD
35352011-06-20 Deniz Dogan <deniz@dogan.se>
3536
3537 * process.c (Fset_process_buffer): Clarify return value in
3538 docstring.
3539
7d7d0045
CY
35402011-06-18 Chong Yidong <cyd@stupidchicken.com>
3541
3542 * dispnew.c (add_window_display_history): Use BVAR.
3543
3544 * xdisp.c (debug_method_add): Use BVAR.
3545 (check_window_end, dump_glyph_matrix, dump_glyph)
3546 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3547
3548 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3549 Likewise.
3550
3551 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3552 check till after the cache is created in init_frame_faces.
3553
ff2bc410
SM
35542011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3555
3556 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3557
28177add
PE
35582011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3559
dd3482fe
PE
3560 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3561 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3562 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3563
393d71f3 3564 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3565 * fileio.c (Finsert_file_contents):
3566 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3567 Remove the old (too-loose) buffer overflow checks.
3568 They weren't needed, since make_gap checks for buffer overflow.
3569 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3570 The old code merely checked for Emacs fixnum overflow, and relied
3571 on undefined (wraparound) behavior. The new code avoids undefined
3572 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3573
2e6813b0 3574 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3575 Tune. Don't use wider integers than needed. Don't use alloca.
3576 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3577
599a9e4f
PE
3578 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3579
99561444
PE
3580 * insdel.c, lisp.h (buffer_overflow): New function.
3581 (insert_from_buffer_1, replace_range, replace_range_2):
3582 * insdel.c (make_gap_larger):
3583 * editfns.c (Finsert_char):
3584 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3585
28177add
PE
3586 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3587
e69dafad
PE
35882011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3589
a7af7fde 3590 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3591
b1c46f02
PE
3592 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3593 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3594
e69dafad
PE
3595 * fileio.c: Don't assume EMACS_INT fits in off_t.
3596 (emacs_lseek): New static function.
3597 (Finsert_file_contents, Fwrite_region): Use it.
3598 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3599
566684ea
PE
3600 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3601
e6966cd6
PE
3602 * fns.c: Don't overflow int when computing a list length.
3603 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3604 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3605 truncation on 64-bit hosts. Check for QUIT every
3606 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3607 faster and is responsive enough.
3608 (Flength): Report an error instead of overflowing an integer.
3609 (Fsafe_length): Return a float if the value is not representable
3610 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3611 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3612 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3613
dd0b0efb
PE
3614 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3615 (header_size, word_size): New constants.
3616 (allocate_vectorlike): Don't check size overflow here.
3617 (allocate_vector): Check it here instead, since this is the only
3618 caller of allocate_vectorlike that could cause overflow.
3619 Check that the new vector's length is representable as a fixnum.
3620
86fe5cfe
PE
3621 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3622 The previous code was bogus. For example, next_almost_prime (32)
3623 returned 39, which is undesirable as it is a multiple of 3; and
3624 next_almost_prime (24) returned 25, which is a multiple of 5 so
3625 why was the code bothering to check for multiples of 7?
3626
80e88859
PE
3627 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3628
4a2f0ad6
PE
3629 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3630
f66c7cf8
PE
3631 Variadic C functions now count arguments with ptrdiff_t.
3632 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3633 Back then I didn't know that the Emacs coding style prefers signed int.
3634 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3635 were being counted with int, which may truncate counts on 64-bit
3636 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3637 * lisp.h (struct Lisp_Subr.function.aMANY)
3638 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3639 Arg counts are now ptrdiff_t, not size_t.
3640 All variadic functions and their callers changed accordingly.
3641 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3642 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3643 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3644 * callint.c (Fcall_interactively): Check arg count for overflow,
3645 to avoid potential buffer overrun. Use signed char, not 'int',
3646 for 'varies' array, so that we needn't bother to check its size
3647 calculation for overflow.
3648 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3649 * eval.c (apply_lambda):
3650 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3651 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3652 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3653
a1759b76
PE
3654 * callint.c (Fcall_interactively): Don't use index var as event count.
3655
d96be9fc
PE
3656 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3657 * mem-limits.h (SIZE): Remove; no longer used.
3658
a690a978 3659 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3660
578c21e6
PE
3661 Remove unnecessary casts.
3662 * xterm.c (x_term_init):
3663 * xfns.c (x_set_border_pixel):
3664 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3665 These aren't needed now that we assume ANSI C.
3666
96f53c6c
PE
3667 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3668 It's more likely to cause problems (due to unsigned overflow)
3669 than to cure them.
3670
83c77d31
PE
3671 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3672
ee2079f1
PE
3673 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3674
6da65536
PE
3675 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3676
7147c4a4
PE
3677 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3678
193e32d9
PE
3679 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3680
e5533da6
PE
3681 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3682
9910e595
PE
3683 GLYPH_CODE_FACE returns EMACS_INT, not int.
3684 * dispextern.h (merge_faces):
3685 * xfaces.c (merge_faces):
01103c44
PE
3686 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3687 Don't assume EMACS_INT fits in int.
9910e595 3688
2638320e
PE
3689 * character.h (CHAR_VALID_P): Remove unused parameter.
3690 * fontset.c, lisp.h, xdisp.c: All uses changed.
3691
045eb8d9
PE
3692 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3693
c1f134b5
PE
3694 * fns.c (concat): Minor tuning based on overflow analysis.
3695 This doesn't fix any bugs. Use int to hold character, instead
3696 of constantly refetching from Emacs object. Use XFASTINT, not
3697 XINT, for value known to be a character. Don't bother comparing
3698 a single byte to 0400, as it's always less.
3699
395fcb93 3700 * floatfns.c (Fexpt):
327eeec8
PE
3701 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3702
abbd3d23
PE
3703 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3704 for characters.
3705
684a03ef
PE
3706 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3707
0fed43f3
PE
3708 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3709 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3710 incorrectly succeed when S was a string, because 4294967386 was
3711 truncated before it was used.
3712
8fd02eb7
PE
3713 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3714 Otherwise, an out-of-range integer could cause undefined behavior
3715 on a 64-bit host.
3716
f8c86b69
PE
3717 * composite.c: Use int, not EMACS_INT, for characters.
3718 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3719 EMACS_INT, for values that are known to be in character range.
3720 This doesn't fix any bugs but is the usual style inside Emacs and
3721 may generate better code on 32-bit machines.
3722
34206dd2
PE
3723 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3724 This is for reasons similar to the recent CHAR_STRING fix.
3725 * charset.c (Fencode_char): Check that character arg is actually
3726 a character. Pass an int to ENCODE_CHAR.
3727 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3728 wider than 'int', as a compile-time check to prevent future regressions
3729 in this area.
3730
c5958d4c 3731 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3732
3733 Make sure a 64-bit char is never passed to CHAR_STRING.
3734 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3735 by silently ignoring the top 32 bits, allowing some values
3736 that were far too large to be valid characters.
3737 * character.h: Include <verify.h>.
3738 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3739 arguments are no wider than unsigned, as a compile-time check
3740 to prevent future regressions in this area.
3741 * data.c (Faset):
01103c44 3742 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3743 (Fsubst_char_in_region):
3744 * fns.c (concat):
3745 * xdisp.c (decode_mode_spec_coding):
3746 Adjust to CHAR_STRING's new requirement.
3747 * editfns.c (Finsert_char, Fsubst_char_in_region):
3748 * fns.c (concat): Check that character args are actually
3749 characters. Without this test, these functions did the wrong
3750 thing with wildly out-of-range values on 64-bit hosts.
3751
d37ca623
PE
3752 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3753 These casts should not be needed on 32-bit hosts, either.
3754 * keyboard.c (read_char):
3755 * lread.c (Fload): Remove casts to unsigned.
3756
ea204efb
PE
3757 * lisp.h (UNSIGNED_CMP): New macro.
3758 This fixes comparison bugs on 64-bit hosts.
3759 (ASCII_CHAR_P): Use it.
3760 * casefiddle.c (casify_object):
01103c44 3761 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3762 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3763 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3764 * dispextern.h (FACE_FROM_ID):
3765 * keyboard.c (read_char): Use UNSIGNED_CMP.
3766
41cb286c
PE
3767 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3768 not to EMACS_INT, to avoid GCC warning.
3769
4a1b9832
PE
3770 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3771
55daad71
PE
3772 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3773 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3774 isn't needed on 32-bit machines.
8f95c75c 3775
01103c44
PE
3776 * buffer.c (Fgenerate_new_buffer_name):
3777 Use EMACS_INT for count, not int.
0ceccced 3778 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3779
3780 * data.c (Qcompiled_function): Now static.
3781
c6f072e7
PE
3782 * window.c (window_body_lines): Now static.
3783
20ce5912
PE
3784 * image.c (gif_load): Rename local to avoid shadowing.
3785
9c4c5f81
PE
3786 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3787 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3788 * alloc.c (make_save_value): Integer argument is now of type
3789 ptrdiff_t, not int.
3790 (mark_object): Use ptrdiff_t, not int.
3791 * lisp.h (pD): New macro.
3792 * print.c (print_object): Use it.
3793
c0c5c8ae
PE
3794 * alloc.c: Use EMACS_INT, not int, to count objects.
3795 (total_conses, total_markers, total_symbols, total_vector_size)
3796 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3797 (total_free_floats, total_floats, total_free_intervals)
3798 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3799 Now EMACS_INT, not int. All uses changed.
3800 (Fgarbage_collect): Compute overall total using a double, so that
3801 integer overflow is less likely to be a problem. Check for overflow
3802 when converting back to an integer.
5a25e253
PE
3803 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3804 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3805 These were 'int' variables that could overflow on 64-bit hosts;
3806 they were never used, so remove them instead of repairing them.
211a0b2a 3807 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3808 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3809 Previously, this ceilinged at INT_MAX, but that doesn't work on
3810 64-bit machines.
e46bb31a 3811 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3812
c78baabf 3813 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3814 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3815 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3816 when a (possibly-narrower) signed value would do just as well.
3817 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3818
c9d624c6
PE
3819 * alloc.c: Catch some string size overflows that we were missing.
3820 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3821 for convenience in STRING_BYTES_MAX.
3822 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3823 The definition here is exact; the one in lisp.h was approximate.
3824 (allocate_string_data): Check for string overflow. This catches
3825 some instances we weren't catching before. Also, it catches
3826 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3827 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3828 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3829
c9d624c6
PE
3830 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3831 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3832 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3833
353032ce
PE
3834 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3835
2bccce07
PE
3836 * alloc.c (Fmake_string): Check for out-of-range init.
3837
0ac30604
SM
38382011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3839
3840 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3841
c195f2de
JD
38422011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3843
3844 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3845 xg_get_default_scrollbar_width.
3846
3847 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3848 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3849 (style_changed_cb): Call update_theme_scrollbar_width and call
3850 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3851 all frames (Bug#8505).
3852 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3853 Call gtk_window_set_resizable if HAVE_GTK3.
3854 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3855 and height if HAVE_GTK3 (Bug#8505).
3856 (scroll_bar_width_for_theme): New variable.
3857 (update_theme_scrollbar_width): New function.
3858 (xg_get_default_scrollbar_width): Move code to
3859 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3860 (xg_initialize): Call update_theme_scrollbar_width.
3861
3862 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3863
3864 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3865
e10ac9f1
MR
38662011-06-12 Martin Rudalics <rudalics@gmx.at>
3867
3868 * frame.c (make_frame): Call other_buffer_safely instead of
3869 other_buffer.
3870
3871 * window.c (temp_output_buffer_show): Call display_buffer with
3872 second argument Vtemp_buffer_show_specifiers and reset latter
3873 immediately after the call.
3874 (Vtemp_buffer_show_specifiers): New variable.
3875 (auto_window_vscroll_p, next_screen_context_lines)
3876 (Vscroll_preserve_screen_position): Remove leading asterisks from
3877 doc-strings.
3878
2d3c217e 38792011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3880
7b7f97e8 3881 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3882 * buffer.c (Qclone_number): Remove for now, as it's unused.
3883 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3884 (record_buffer): Remove unused local.
3885 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3886 (set_frame_buffer_list): Remove; unused.
3887 * frame.h (other_visible_frames): Remove decl.
3888 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3889 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3890 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3891 if HAVE_GPM.
3892 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3893 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3894 Define only if HAVE_GPM.
3895 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3896 (update_hints_inhibit): Remove; never set. All uses removed.
3897 * widgetprv.h (emacsFrameClassRec): Remove decl.
3898 * window.c (delete_deletable_window): Now returns void, since it
3899 wasn't returning anything.
3900 (compare_window_configurations): Remove unused locals.
3901 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3902 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3903 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3904 the same widths as pointers. This follows up on the 2011-05-06 patch.
3905 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3906 * xterm.h: Likewise.
3907 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3908
1384b89e
JB
39092011-06-12 Juanma Barranquero <lekktu@gmail.com>
3910
3911 * makefile.w32-in: Update dependencies.
3912 (LISP_H): Add lib/intprops.h.
3913
1100a63c
CY
39142011-06-11 Chong Yidong <cyd@stupidchicken.com>
3915
3916 * image.c (gif_load): Add animation frame delay to the metadata.
3917 (syms_of_image): Use DEFSYM. New symbol `delay'.
3918
6198ccd0
MR
39192011-06-11 Martin Rudalics <rudalics@gmx.at>
3920
3921 * window.c (delete_deletable_window): Re-add.
3922 (Fset_window_configuration): Rewrite to handle dead buffers and
3923 consequently deletable windows.
3924 (window_tree, Fwindow_tree): Remove. Supply functionality in
3925 window.el.
3926 (compare_window_configurations): Simplify code.
3927
b6e3633c
AS
39282011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3929
1ab0dee5
AS
3930 * image.c (imagemagick_load_image): Fix type mismatch.
3931 (Fimagemagick_types): Likewise.
3932
b6e3633c
AS
3933 * window.h (replace_buffer_in_windows): Declare.
3934
9397e56f
MR
39352011-06-11 Martin Rudalics <rudalics@gmx.at>
3936
3937 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3938 Qclone_number. Remove external declaration of Qdelete_window.
3939 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3940 code.
640c8776
SM
3941 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3942 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3943 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3944 buffer list implementation.
3945 (other_buffer_safely): New function.
3946 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3947 calls to replace_buffer_in_windows and
3948 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3949 if allowed.
3950 (record_buffer): Inhibit quitting and rewrite using quittable
3951 functions. Run Qbuffer_list_update_hook if allowed.
3952 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3953 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3954 Move switch-to-buffer to window.el.
9397e56f
MR
3955 (bury-buffer): Move to window.el.
3956 (Vbuffer_list_update_hook): New variable.
3957
3958 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3959 section.
3960
3961 * window.h (resize_frame_windows): Move up in code.
3962 (Fwindow_frame): Remove EXFUN.
3963 (replace_buffer_in_all_windows): Remove prototype.
3964 (replace_buffer_in_windows_safely): Add prototype.
3965
3966 * window.c: Declare Qdelete_window static again. Move down
3967 declaration of select_count.
3968 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3969 (Fother_window): Move to window.el.
3970 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3971 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3972 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3973 window.el.
3974 (replace_buffer_in_windows): Implement by calling
3975 Qreplace_buffer_in_windows.
3976 (replace_buffer_in_all_windows): Remove with some functionality
3977 moved into replace_buffer_in_windows_safely.
3978 (replace_buffer_in_windows_safely): New function.
3979 (select_window_norecord, select_frame_norecord): Move in front
3980 of run_window_configuration_change_hook. Remove now obsolete
3981 declarations.
640c8776
SM
3982 (Fset_window_buffer): Rewrite doc-string.
3983 Call Qrecord_window_buffer.
9397e56f
MR
3984 (keys_of_window): Move binding for other-window to window.el.
3985
b50691aa
CY
39862011-06-11 Chong Yidong <cyd@stupidchicken.com>
3987
3988 * dispextern.h (struct image): Replace data member, whose int_val
3989 and ptr_val fields were not used by anything, with a single
3990 lisp_val object.
3991
3992 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3993 (gif_clear_image, gif_load, imagemagick_load_image)
3994 (gs_clear_image, gs_load): Callers changed.
3995
3f754b86
PE
39962011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3997
cca69397
PE
3998 * buffer.h: Include <time.h>, for time_t.
3999 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4000
109e28d0
PE
4001 Fix minor problems found by static checking.
4002
60737f02
PE
4003 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4004
4b66faf3
PE
4005 Make identifiers static if they are not used in other modules.
4006 * data.c (Qcompiled_function, Qframe, Qvector):
4007 * image.c (QimageMagick, Qsvg):
4008 * minibuf.c (Qmetadata):
4009 * window.c (resize_window_check, resize_root_window): Now static.
4010 * window.h (resize_window_check, resize_root_window): Remove decls.
4011
109e28d0
PE
4012 * window.c (window_deletion_count, delete_deletable_window):
4013 Remove; unused.
46a4ce9e
PE
4014 (window_body_lines): Now static.
4015 (Fdelete_other_windows_internal): Mark vars as initialized.
4016 Make sure 'resize_failed' is initialized.
4017 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4018 (resize_window_apply): Remove unused local.
4019 * window.h (delete_deletable_window): Remove decl.
4020
109e28d0 4021 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4022 (imagemagick_load_image): Fix pointer signedness problem by changing
4023 last arg from unsigned char * to char *. All uses changed.
4024 Also, fix a local for similar reasons.
4025 Remove unused locals. Remove locals to avoid shadowing.
4026 (fn_rsvg_handle_free): Remove; unused.
4027 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4028 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4029
3f754b86
PE
4030 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4031
2547adb1
CY
40322011-06-10 Chong Yidong <cyd@stupidchicken.com>
4033
4034 * image.c (gif_load): Fix omitted cast error introduced by
4035 2011-06-06 change.
4036
2c8e37d4
MR
40372011-06-10 Martin Rudalics <rudalics@gmx.at>
4038
4039 * window.h (resize_proportionally, orig_total_lines)
4040 (orig_top_line): Remove from window structure.
4041 (set_window_height, set_window_width, change_window_heights)
4042 (Fdelete_window): Remove prototypes.
4043 (resize_frame_windows): Remove duplicate declaration.
4044
440a42e3
EZ
40452011-06-10 Eli Zaretskii <eliz@gnu.org>
4046
4047 * window.h (resize_frame_windows, resize_window_check)
4048 (delete_deletable_window, resize_root_window)
4049 (resize_frame_windows): Declare prototypes.
4050
4051 * window.c (resize_window_apply): Make definition be "static" to
4052 match the prototype.
4053
562dd5e9
MR
40542011-06-10 Martin Rudalics <rudalics@gmx.at>
4055
4056 * window.c: Remove declarations of Qwindow_size_fixed,
4057 window_min_size_1, window_min_size_2, window_min_size,
4058 size_window, window_fixed_size_p, enlarge_window, delete_window.
4059 Remove static from declaration of Qdelete_window, it's
4060 temporarily needed by Fbury_buffer.
4061 (replace_window): Don't assign orig_top_line and
4062 orig_total_lines.
4063 (Fdelete_window, delete_window): Remove. Window deletion is
4064 handled by window.el.
640c8776
SM
4065 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4066 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4067 (Fdelete_other_windows): Remove. Deleting other windows is
4068 handled by window.el.
4069 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4070 handled in window.el.
4071 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4072 Window minimum sizes are handled in window.el.
4073 (shrink_windows, size_window, set_window_height)
4074 (set_window_width, change_window_heights, window_height)
4075 (window_width, CURBEG, CURSIZE, enlarge_window)
4076 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4077 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4078 handled in window.el.
4079 (make_dummy_parent): Rename to make_parent_window and give it a
4080 second argument horflag.
4081 (make_window): Don't set resize_proportionally any more.
4082 (Fsplit_window): Remove. Windows are split in window.el.
4083 (save_restore_action, save_restore_orig_size)
4084 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4085 Resize mini windows in window.el.
4086 (grow_mini_window, shrink_mini_window): Implement by calling
4087 Qresize_root_window_vertically, resize_window_check and
4088 resize_window_apply.
640c8776
SM
4089 (saved_window, Fset_window_configuration, save_window_save):
4090 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4091 resize_proportionally.
4092 (window_min_height, window_min_width): Move to window.el.
4093 (keys_of_window): Move bindings for delete-other-windows,
4094 split-window, delete-window and enlarge-window to window.el.
4095
4096 * buffer.c: Temporarily extern Qdelete_window.
4097 (Fbury_buffer): Temporarily call Qdelete_window instead of
4098 Fdelete_window (Fbury_buffer will move to window.el soon).
4099
4100 * frame.c (set_menu_bar_lines_1): Remove code handling
4101 orig_top_line and orig_total_lines.
4102
4103 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4104 set_window_height but set heights directly.
4105 (change_frame_size_1): Use resize_frame_windows.
4106
4107 * xdisp.c (init_xdisp): Don't use set_window_height but set
4108 heights directly.
4109
640c8776
SM
4110 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4111 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4112 run_window_configuration_change_hook.
4113
4114 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4115 instead of change_window_heights and run
4116 run_window_configuration_change_hook.
4117
1a13852e
MR
41182011-06-09 Martin Rudalics <rudalics@gmx.at>
4119
4120 * window.c (replace_window): Rename second argument REPLACEMENT to
4121 NEW. New third argument SETFLAG. Rewrite.
4122 (delete_window, make_dummy_parent): Call replace_window with
4123 third argument 1.
4124 (window_list_1): Move down in code.
4125 (run_window_configuration_change_hook): Move set_buffer part
4126 before select_frame_norecord part in order to unwind correctly.
4127 Rename count1 to count.
4128 (recombine_windows, delete_deletable_window, resize_root_window)
4129 (Fdelete_other_windows_internal)
4130 (Frun_window_configuration_change_hook, make_parent_window)
4131 (resize_window_check, resize_window_apply, Fresize_window_apply)
4132 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4133 (Fdelete_window_internal, Fresize_mini_window_internal):
4134 New functions.
1a13852e
MR
4135 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4136
f3d1777e
MR
41372011-06-08 Martin Rudalics <rudalics@gmx.at>
4138
496e208e
MR
4139 * window.h (window): Add some new members to window structure -
4140 normal_lines, normal_cols, new_total, new_normal, clone_number,
4141 splits, nest, prev_buffers, next_buffers.
4142 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4143 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4144
f3d1777e
MR
4145 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4146 Remove.
496e208e
MR
4147 (make_dummy_parent): Set new members of windows structure.
4148 (make_window): Move down in code. Handle new members of window
4149 structure.
4150 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4151 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4152 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4153 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4154 (Fset_window_next_buffers, Fset_window_clone_number):
4155 New functions.
496e208e
MR
4156 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4157 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4158 Doc-string fixes.
4159 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4160 Argument WINDOW can be now internal window too.
4161 (Fwindow_use_time): Move up in code.
4162 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4163 Rewrite doc-string.
4164 (Fset_window_configuration, saved_window)
4165 (Fcurrent_window_configuration, save_window_save): Handle new
4166 members of window structure.
b9e809c2
MR
4167 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4168 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4169 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4170 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4171 Qget_mru_window, Qresize_root_window,
4172 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4173 Qauto_buffer_name; staticpro them.
f3d1777e 4174
abde8f8c
MR
41752011-06-07 Martin Rudalics <rudalics@gmx.at>
4176
4177 * window.c (Fwindow_total_size, Fwindow_left_column)
4178 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4179 (Fwindow_list_1): New functions.
4180 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4181 (Fwindow_width, Fscroll_left, Fscroll_right):
4182 Use window_body_cols instead of window_box_text_cols.
4183 (delete_window, Fset_window_configuration):
4184 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4185 (delete_all_subwindows): Take a window as argument and not a
4186 structure. Rewrite.
190b47e6
MR
4187 (window_loop): Remove handling of GET_LRU_WINDOW and
4188 GET_LARGEST_WINDOW.
4189 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4190
4191 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4192 window_box_text_cols. delete_all_subwindows now takes a
4193 Lisp_Object as argument.
abde8f8c 4194
640c8776
SM
4195 * indent.c (compute_motion, Fcompute_motion):
4196 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4197
fa8a67e6
MR
4198 * frame.c (delete_frame): Call delete_all_subwindows with root
4199 window as argument.
4200
a54e3482
DC
42012011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4202
4203 * fns.c (Fputhash): Document return value.
4204
60002bf5
CY
42052011-06-06 Chong Yidong <cyd@stupidchicken.com>
4206
4207 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4208
0c671da6 42092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4210
b862a52a 4211 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4212
be44ca6c
PE
4213 Check for overflow when converting integer to cons and back.
4214 * charset.c (Fdefine_charset_internal, Fdecode_char):
4215 Use cons_to_unsigned to catch overflow.
4216 (Fencode_char): Use INTEGER_TO_CONS.
4217 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4218 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4219 * data.c (long_to_cons, cons_to_long): Remove.
4220 (cons_to_unsigned, cons_to_signed): New functions.
4221 These signal an error for invalid or out-of-range values.
4222 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4223 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4224 * font.c (Ffont_variation_glyphs):
4225 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4226 * lisp.h: Include <intprops.h>.
4227 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4228 (cons_to_signed, cons_to_unsigned): New decls.
4229 (long_to_cons, cons_to_long): Remove decls.
4230 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4231 (Fprimitive_undo): Use CONS_TO_INTEGER.
4232 * xfns.c (Fx_window_property): Likewise.
4233 * xselect.c: Include <limits.h>.
4234 (x_own_selection, selection_data_to_lisp_data):
4235 Use INTEGER_TO_CONS.
4236 (x_handle_selection_request, x_handle_selection_clear)
4237 (x_get_foreign_selection, Fx_disown_selection_internal)
4238 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4239 (lisp_data_to_selection_data): Use cons_to_unsigned.
4240 (x_fill_property_data): Use cons_to_signed.
4241 Report values out of range.
4242
d1f3d2af
PE
4243 Check for buffer and string overflow more precisely.
4244 * buffer.h (BUF_BYTES_MAX): New macro.
4245 * lisp.h (STRING_BYTES_MAX): New macro.
4246 * alloc.c (Fmake_string):
4247 * character.c (string_escape_byte8):
4248 * coding.c (coding_alloc_by_realloc):
4249 * doprnt.c (doprnt):
4250 * editfns.c (Fformat):
4251 * eval.c (verror):
4252 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4253 since they may not be the same number.
4254 * editfns.c (Finsert_char):
4255 * fileio.c (Finsert_file_contents):
4256 Likewise for BUF_BYTES_MAX.
4257
dd52fcea
PE
4258 * image.c: Use ptrdiff_t, not int, for sizes.
4259 (slurp_file): Switch from int to ptrdiff_t.
4260 All uses changed.
4261 (slurp_file): Check that file size fits in both size_t (for
4262 malloc) and ptrdiff_t (for sanity and safety).
4263
7f9bbdbb
PE
4264 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4265 if b->modtime has its maximal value.
4266
dfe18f82
PE
4267 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4268
84acfcf0
PE
4269 Don't assume time_t can fit into int.
4270 * buffer.h (struct buffer.modtime): Now time_t, not int.
4271 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4272 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4273
ccd9a01a
PE
4274 Minor fixes for signed vs unsigned integers.
4275 * character.h (MAYBE_UNIFY_CHAR):
4276 * charset.c (maybe_unify_char):
4277 * keyboard.c (read_char, reorder_modifiers):
4278 XINT -> XFASTINT, since the integer must be nonnegative.
4279 * ftfont.c (ftfont_spec_pattern):
4280 * keymap.c (access_keymap, silly_event_symbol_error):
4281 XUINT -> XFASTINT, since the integer must be nonnegative.
4282 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4283 since it makes no difference and we prefer signed.
4284 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4285 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4286 nonnegative.
4287
d6d100dd
SM
42882011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4289
4290 * window.h (Fwindow_frame): Declare.
4291
2b6148e4
PE
42922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4293
4294 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4295 (SPARE_MEMORY): Always define.
4296 (LARGE_REQUEST): Remove.
4297 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4298
f230ecc9
MR
42992011-06-06 Martin Rudalics <rudalics@gmx.at>
4300
727e958e
MR
4301 * lisp.h: Move EXFUNS for Fframe_root_window,
4302 Fframe_first_window and Fset_frame_selected_window to window.h.
4303
4304 * window.h: Move EXFUNS for Fframe_root_window,
4305 Fframe_first_window and Fset_frame_selected_window here from
4306 lisp.h.
4307
4308 * frame.c (Fwindow_frame, Fframe_first_window)
4309 (Fframe_root_window, Fframe_selected_window)
4310 (Fset_frame_selected_window): Move to window.c.
4311 (Factive_minibuffer_window): Move to minibuf.c.
4312 (Fother_visible_frames_p): New function.
4313
4314 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4315
f230ecc9
MR
4316 * window.c (decode_window, decode_any_window): Move up in code.
4317 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4318 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4319 (Fwindow_buffer): Move up and rewrite doc-string.
4320 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4321 (Fwindow_prev): New functions.
727e958e
MR
4322 (Fwindow_frame): Move here from frame.c. Accept any window as
4323 argument.
4324 (Fframe_root_window, Fframe_first_window)
4325 (Fframe_selected_window): Move here from frame.c. Accept frame
4326 or arbitrary window as argument. Update doc-strings.
4327 (Fminibuffer_window): Move up in code.
4328 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4329 (Fset_frame_selected_window): Move here from frame.c.
4330 Marginal rewrite.
727e958e
MR
4331 (Fselected_window, select_window, Fselect_window): Move up in
4332 code. Minor doc-string fixes.
f230ecc9 4333
4d09bcf6
PE
43342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4335
4336 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4337 Do not assume that spare memory exists; that assumption is valid
4338 only if SYSTEM_MALLOC.
4339 (LARGE_REQUEST): New macro, so that the issue of large requests
4340 is separated from the issue of spare memory.
4341
810928a2
AS
43422011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4343
172418ad
AS
4344 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4345 format. (Bug#8806)
4346
43f862f7
AS
4347 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4348
810928a2
AS
4349 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4350 before statements.
4351
a059fe24
JD
43522011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4353
4354 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4355
4356 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4357
4358 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4359 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4360
989bf368
JB
43612011-06-05 Juanma Barranquero <lekktu@gmail.com>
4362
4363 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4364
4b80f674
CY
43652011-06-04 Chong Yidong <cyd@stupidchicken.com>
4366
4367 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4368 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4369 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4370 New error handlers.
4b80f674
CY
4371 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4372 Obey Vx_select_enable_clipboard_manager. Catch errors in
4373 x_clipboard_manager_save (Bug#8779).
4374 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4375 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4376
99a33b77 43772011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4378
4379 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4380
99a33b77 43812011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4382
4383 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4384 in the current matrix if keep_current_p is non-zero.
4385
8264569d
EZ
43862011-06-04 Eli Zaretskii <eliz@gnu.org>
4387
4388 * bidi.c (bidi_level_of_next_char): Fix last change.
4389
57f97249
EZ
43902011-06-03 Eli Zaretskii <eliz@gnu.org>
4391
fec2107c 4392 Support bidi reordering of text covered by display properties.
57f97249 4393
fec2107c
EZ
4394 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4395 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4396 (bidi_cache_search, bidi_cache_iterator_state)
4397 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4398 (bidi_level_of_next_char, bidi_move_to_visually_next):
4399 Support character positions inside a run of characters covered by a
fec2107c
EZ
4400 display string.
4401 (bidi_paragraph_init, bidi_resolve_explicit_1)
4402 (bidi_level_of_next_char): Call bidi_fetch_char and
4403 bidi_fetch_char_advance instead of FETCH_CHAR and
4404 FETCH_CHAR_ADVANCE.
4405 (bidi_init_it): Initialize new members.
4406 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4407 definitions.
4408 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4409 instead of using explicit *_CHAR codes.
d6d100dd
SM
4410 (bidi_resolve_explicit, bidi_resolve_weak):
4411 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4412 bidirectional text is supported only in multibyte buffers.
4413 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4414 it to initialize the frame_window_p member of struct bidi_it.
4415 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4416 (bidi_resolve_explicit, bidi_resolve_weak)
4417 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4418 bidi_it->nchars is non-positive.
4419 (bidi_level_of_next_char): Don't try to lookup the cache for the
4420 next/previous character if nothing is cached there yet, or if we
4421 were just reseat()'ed to a new position.
c40e2fb2 4422
0e14fe90
EZ
4423 * xdisp.c (set_cursor_from_row): Set start and stop points
4424 according to the row's direction when priming the loop that looks
4425 for the glyph on which to display cursor.
4426 (single_display_spec_intangible_p): Function deleted.
4427 (display_prop_intangible_p): Reimplement to call
4428 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4429 Accept 3 additional arguments needed by handle_display_spec.
4430 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4431 values: lists, `(when COND...)' forms, etc.
4432 (single_display_spec_string_p): Support property values that are
4433 lists with the argument STRING its top-level element.
4434 (display_prop_string_p): Fix the condition for processing a
4435 property that is a list to be consistent with handle_display_spec.
fec2107c 4436 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4437 last portion of handle_display_prop.
4438 (compute_display_string_pos): Accept additional argument
4439 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4440 value of a `display' property is a "replacing spec".
4441 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4442 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4443 the display property, but just return a value indicating whether
4444 the display property will replace the characters it covers.
4445 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4446 frame_window_p members of struct bidi_it.
d6d100dd
SM
4447 (compute_display_string_pos, compute_display_string_end):
4448 New functions.
fec2107c
EZ
4449 (push_it): Accept second argument POSITION, where pop_it should
4450 jump to continue iteration.
4451 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4452
fec2107c
EZ
4453 * keyboard.c (adjust_point_for_property): Adjust the call to
4454 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4455
4456 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4457 (bidi_init_it): Update prototypes.
4458 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4459 (compute_display_string_pos, compute_display_string_end):
4460 Declare prototypes.
fec2107c
EZ
4461 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4462 EMACS_INT.
fc6f18ce 4463
40087514 44642011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4465
57f53182
PE
4466 Malloc failure behavior now depends on size of allocation.
4467 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4468 * lisp.h: Change signatures accordingly.
4469 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4470 All callers changed. (Bug#8762)
4471
4472 * gnutls.c: Use Emacs's memory allocators.
4473 Without this change, the gnutls library would invoke malloc etc.
4474 directly, which causes problems on non-SYNC_INPUT hosts, and which
4475 runs afoul of improving memory_full behavior. (Bug#8761)
4476 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4477 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4478 xfree instead of the default malloc, realloc, free.
4479 (Fgnutls_boot): No need to check for memory allocation failure,
4480 since xmalloc does that for us.
4481
ac32cd99 4482 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4483 * category.c (hash_get_category_set):
4484 * ccl.c (ccl_driver):
4485 * charset.c (Fdefine_charset_internal):
4486 * charset.h (struct charset.hash_index):
4487 * composite.c (get_composition_id, gstring_lookup_cache)
4488 (composition_gstring_put_cache):
4489 * composite.h (struct composition.hash_index):
4490 * dispextern.h (struct image.hash):
4491 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4492 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4493 (hashfn_equal, hashfn_user_defined, make_hash_table)
4494 (maybe_resize_hash_table, hash_lookup, hash_put)
4495 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4496 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4497 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4498 * image.c (make_image, search_image_cache, lookup_image)
4499 (xpm_put_color_table_h):
4500 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4501 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4502 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4503 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4504 * alloc.c (allocate_vectorlike):
4505 Check for overflow in vector size calculations.
4506 * ccl.c (ccl_driver):
4507 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4508 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4509 need to be updated by these changes.
40087514
PE
4510 * fns.c (make_hash_table, maybe_resize_hash_table):
4511 Check for integer overflow with large hash tables.
0de4bb68
PE
4512 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4513 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4514 (SXHASH_REDUCE): New macro.
4515 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4516 Use it instead of discarding useful hash info with large hash values.
4517 (sxhash_float): New function.
4518 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4519 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4520 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4521 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4522 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4523 Adjust signatures to match updated version of code.
4524 (consing_since_gc): Now EMACS_INT, since a single hash table can
4525 use more than INT_MAX bytes.
4526
698d32e2
DN
45272011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4528
4529 Make it possible to build with GCC-4.6+ -O2 -flto.
4530
4531 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4532
fd6fa53f
SM
45332011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4534
4535 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4536 Call minibuffer-inactive-mode.
4537
864db017
JB
45382011-05-31 Juanma Barranquero <lekktu@gmail.com>
4539
4540 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4541 Update dependencies.
4542
2ad0baf4
DN
45432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4544
4545 * data.c (init_data): Remove code for UTS, this system is not
4546 supported anymore.
4547
4fcc2638
DN
45482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4549
4550 Don't force ./temacs to start in terminal mode.
4551
4552 * frame.c (make_initial_frame): Initialize faces in all cases, not
4553 only when CANNOT_DUMP is defined.
4554 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4555
c56e0fd5
DN
45562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4557
4558 * dispnew.c (add_window_display_history): Use const for the string
4559 pointer. Remove declaration, not needed.
4560
333d54da 45612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4562
55d4c1b2 4563 Use 'inline', not 'INLINE'.
333d54da 4564 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4565 * alloc.c, fontset.c (INLINE): Remove.
4566 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4567 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4568 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4569 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4570 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4571
738db178
DN
45722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4573
4574 Make it possible to run ./temacs.
4575
4576 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4577 syms_of_callproc does the same thing. Remove test for
4578 "initialized", do it in the caller.
4579 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4580
620c53a6
SM
45812011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4582
4583 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4584 (read_minibuf): Use get_minibuffer.
4585 (syms_of_minibuf): Use DEFSYM.
4586 (Qmetadata): New var.
4587 * data.c (Qbuffer): Don't make it static.
4588 (syms_of_data): Use DEFSYM.
4589
e003a292
PE
45902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4591
4592 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4593 (CCL_CODE_MIN): New macro.
4594
ed008a6d
PE
45952011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4596
3687c2ef
PE
4597 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4598
ed008a6d
PE
4599 * eval.c (Qdebug): Now static.
4600 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4601 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4602 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4603
d66c4c7c
CY
46042011-05-29 Chong Yidong <cyd@stupidchicken.com>
4605
4606 * image.c: Various fixes to ImageMagick code comments.
4607 (Fimagemagick_types): Doc fix.
4608
5fbc2025
PE
46092011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4610
0196f88a
PE
4611 Minor fixes prompted by GCC 4.6.0 warnings.
4612
4613 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4614
5fbc2025
PE
4615 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4616 (x_clipboard_manager_save_all): Move extern decl to ...
4617 * xterm.h: ... here, so that it can be checked for consistency.
4618
1dd3c2d9
CY
46192011-05-29 Chong Yidong <cyd@stupidchicken.com>
4620
4621 * xselect.c (x_clipboard_manager_save_frame)
4622 (x_clipboard_manager_save_all): New functions.
4623 (Fx_clipboard_manager_save): Lisp function deleted.
4624
4625 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4626 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4627
4628 * xterm.h: Update prototype.
4629
5ba6571d
WX
46302011-05-28 William Xu <william.xwl@gmail.com>
4631
4632 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4633 exiting (Bug#8239).
4634
3eaff834
JM
46352011-05-28 Jim Meyering <meyering@redhat.com>
4636
e1900994 4637 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4638 * fns.c (to_uchar): Define.
4639 (crypto_hash_function): Use it to convert some newly-signed
4640 variables to unsigned, to avoid sign-extension bugs. For example,
4641 without this change, (md5 "truc") would evaluate to
4642 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4643 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4644 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4645
0f6990a7
PE
46462011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4647
4648 Integer overflow fixes.
c8a9ca5a 4649
08686060
PE
4650 * dbusbind.c: Serial number integer overflow fixes.
4651 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4652 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4653 to hold a serial number that is too large for a fixnum.
4654 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4655 Check for serial numbers out of range. Decode any serial number
59568bf0 4656 that was so large that it became a float. (Bug#8722)
08686060 4657
2d1fc3c7
PE
4658 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4659 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4660 Use XFASTINT rather than XUINT when numbers are nonnegative.
4661 (xd_append_arg, Fdbus_method_return_internal):
4662 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4663 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4664 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4665 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4666 (Bug#8722)
2d1fc3c7 4667
c8a9ca5a
PE
4668 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4669
519e1d69
PE
4670 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4671
30569699
PE
4672 ccl: add integer overflow checks
4673 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4674 (IN_INT_RANGE): New macros.
4675 (ccl_driver): Use them to check for integer overflow when
4676 decoding a CCL program. Many of the new checks are whether XINT (x)
4677 fits in int; it doesn't always, on 64-bit hosts. The new version
4678 doesn't catch all possible integer overflows, but it's an
847044ea 4679 improvement. (Bug#8719)
30569699 4680
c11285dc
PE
4681 * alloc.c (make_event_array): Use XINT, not XUINT.
4682 There's no need for unsigned here.
4683
fdccd48e
PE
4684 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4685 This follows up to the 2011-05-06 change that substituted uintptr_t
4686 for EMACS_INT. This case wasn't caught back then.
4687
37910ab2
PE
4688 Rework Fformat to avoid integer overflow issues.
4689 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4690 now (part of C89). Include <verify.h>.
4691 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4692 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4693 (Fformat): Avoid the prepass trying to compute sizes; it was only
4694 approximate and thus did not catch overflow reliably. Instead, walk
4695 through the format just once, formatting and computing sizes as we go,
4696 checking for integer overflow at every step, and allocating a larger
4697 buffer as needed. Keep track separately whether the format is
4698 multibyte. Keep only the most-recently calculated precision, rather
4699 than them all. Record whether each argument has been converted to
4700 string. Use EMACS_INT, not int, for byte and char and arg counts.
4701 Support field widths and precisions larger than INT_MAX. Avoid
4702 sprintf's undefined behavior with conversion specifications such as %#d
4703 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4704 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4705 formatting out-of-range floating point numbers with int
9173deec 4706 formats. (Bug#8668)
37910ab2 4707
2e6578fb
PE
4708 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4709
0ae6bdee
PE
4710 * data.c: Avoid integer truncation in expressions involving floats.
4711 * data.c: Include <intprops.h>.
4712 (arith_driver): When there's an integer overflow in an expression
4713 involving floating point, convert the integers to floating point
4714 so that the resulting value does not suffer from catastrophic
4715 integer truncation. For example, on a 64-bit host (* 4
4716 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4717 Do not rely on undefined behavior after integer overflow.
4718
de883a70
PE
4719 merge count_size_as_multibyte, parse_str_to_multibyte
4720 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4721 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4722 Check for integer overflow.
4723 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4724 since it's now a duplicate of the other. This is more of
4725 a character than a buffer op, so better that it's in character.c.
4726 * fns.c, print.c: Adjust to above changes.
4727
2ff916cb
PE
47282011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4729
4730 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4731
f1b54466
PE
47322011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4733
fb1ac845
PE
4734 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4735 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4736 (x_clipboard_manager_save): Now static.
4737 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4738
f1b54466
PE
4739 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4740 (crypto_hash_function): Now static.
4741 Fix pointer signedness problems. Avoid unnecessary initializations.
4742
a9f737ee
CY
47432011-05-27 Chong Yidong <cyd@stupidchicken.com>
4744
4745 * termhooks.h (Vselection_alist): Make it terminal-local.
4746
4747 * terminal.c (create_terminal): Initialize it.
4748
4749 * xselect.c: Support for clipboard managers.
4750 (Vselection_alist): Move to termhooks.h as terminal-local var.
4751 (LOCAL_SELECTION): New macro.
4752 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4753 (symbol_to_x_atom): Remove gratuitous arg.
4754 (x_handle_selection_request, lisp_data_to_selection_data)
4755 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4756 (x_own_selection, x_get_local_selection, x_convert_selection):
4757 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4758 (some_frame_on_display): Delete unused function.
4759 (Fx_own_selection_internal, Fx_get_selection_internal)
4760 (Fx_disown_selection_internal, Fx_selection_owner_p)
4761 (Fx_selection_exists_p): New optional frame arg.
4762 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4763 (x_handle_selection_clear): Don't treat other terminals with the
4764 same keyboard specially. Use the terminal-local Vselection_alist.
4765 (x_clear_frame_selections): Use Frun_hook_with_args.
4766
4767 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4768
4769 * xterm.h: Add support for those atoms.
4770
e067f0c1
CY
47712011-05-26 Chong Yidong <cyd@stupidchicken.com>
4772
4773 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4774 (converted_selections, conversion_fail_tag): New global variables.
4775 (x_selection_request_lisp_error): Free the above.
4776 (x_get_local_selection): Remove unnecessary code.
4777 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4778 of converted selections stored in converted_selections.
4779 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4780 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4781 (x_convert_selection): New function.
4782 (x_handle_selection_event): Simplify.
4783 (x_get_foreign_selection): Don't ignore incoming requests while
4784 waiting for an answer; this will fail when we implement
4785 SAVE_TARGETS, and seems unnecessary anyway.
4786 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4787 (Vx_sent_selection_functions): Doc fix.
4788
0f4aebc0
LL
47892011-05-26 Leo Liu <sdl.web@gmail.com>
4790
4791 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4792
e61124cd
YM
47932011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4794
4795 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4796
4797 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4798 for fringe update if it has periodic bitmap.
ac389d0c 4799 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4800 and fringe_bitmap_periodic_p.
4801
4802 * fringe.c (get_fringe_bitmap_data): New function.
4803 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4804 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4805 row. Mark glyph row for fringe update if periodicity changed.
4806
4807 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4808 for fringe update unless it has periodic bitmap.
4809
f16d9837
KH
48102011-05-25 Kenichi Handa <handa@m17n.org>
4811
4812 * xdisp.c (get_next_display_element): Set correct it->face_id for
4813 a static composition.
4814
e1b90ef6
LL
48152011-05-24 Leo Liu <sdl.web@gmail.com>
4816
4817 * deps.mk (fns.o):
4818 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4819
4820 * fns.c (crypto_hash_function, Fsha1): New function.
4821 (Fmd5): Use crypto_hash_function.
4822 (syms_of_fns): Add Ssha1.
4823
7400048f
PE
48242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4825
4826 * gnutls.c: Remove unused macros.
4827 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4828 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4829 Remove macros that are defined and never used.
4830 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4831
abb71cf4
CY
48322011-05-22 Chong Yidong <cyd@stupidchicken.com>
4833
4834 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4835 (Fx_get_selection_internal): Minor cleanup.
4836 (Fx_own_selection_internal): Rename arguments for consistency with
4837 select.el.
4838
6307db39
PE
48392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4840
4841 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4842
f3d4e0a4
CY
48432011-05-22 Chong Yidong <cyd@stupidchicken.com>
4844
4845 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4846
4d8ade89
YM
48472011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4848
4849 * dispnew.c (scrolling_window): Don't exclude the case that the
4850 last enabled row in the desired matrix touches the bottom boundary.
4851
32078c8d
GM
48522011-05-21 Glenn Morris <rgm@gnu.org>
4853
4854 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4855 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4856 and add some more files.
32078c8d 4857
7285dc67
EZ
48582011-05-20 Eli Zaretskii <eliz@gnu.org>
4859
4860 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4861 report_file_error introduced by the change from 2011-05-07.
4862
89d1bd22
PE
48632011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4864
4865 * systime.h (Time): Define only if emacs is defined.
4866 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4867 where the include path doesn't have X11/X.h by default. See
4868 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4869
e23640bb 48702011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4871
4872 * composite.c (find_automatic_composition): Fix previous change.
4873
b9704ad9
GM
48742011-05-20 Glenn Morris <rgm@gnu.org>
4875
4876 * lisp.mk: New file, split from Makefile.in.
4877 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4878 (shortlisp): Remove.
4879 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4880
4a720484
GM
48812011-05-19 Glenn Morris <rgm@gnu.org>
4882
4883 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4884 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4885 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4886 (lisp): Set the order to that of loadup.el.
4887 (shortlisp): Make it a copy of $lisp.
4888 (SOME_MACHINE_LISP): Remove.
4889 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4890 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4891
a28d4396
KH
48922011-05-18 Kenichi Handa <handa@m17n.org>
4893
4894 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4895 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4896 (find_automatic_composition): Mostly rewrite for efficiency.
4897
a2b1fa8e
JB
48982011-05-18 Juanma Barranquero <lekktu@gmail.com>
4899
4900 * makefile.w32-in: Update dependencies.
4901
8e1f5610
CS
49022011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4903
4904 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4905 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4906
7025ee00 49072011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4908
cdfa6eab
PE
4909 Fix some integer overflow issues, such as string length overflow.
4910
06d6db33
PE
4911 * insdel.c (count_size_as_multibyte): Check for string overflow.
4912
2b4560a8
PE
4913 * character.c (lisp_string_width): Check for string overflow.
4914 Use EMACS_INT, not int, for string indexes and lengths; in
4915 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4916 the resulting string length overflows an EMACS_INT; instead,
4917 report a string overflow if no precision given. When checking for
4918 precision exhaustion, use a check that cannot possibly have
4919 integer overflow. (Bug#8675)
4920 * character.h (lisp_string_width): Adjust to new signature.
4921
cb93f9be
PE
4922 * alloc.c (string_overflow): New function.
4923 (Fmake_string): Use it. This doesn't change behavior, but saves
4924 a few bytes and will simplify future changes.
4925 * character.c (string_escape_byte8): Likewise.
4926 * lisp.h (string_overflow): New decl.
4927
1a1f3366
PE
4928 Fixups, following up to the user-interface timestamp change.
4929 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4930 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4931 * msdos.c (mouse_get_pos): Likewise.
4932 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4933 * w32gui.h (Time): Define by including "systime.h" rather than by
4934 declaring it ourselves. (Bug#8664)
4935
d4e3e4d3
PE
4936 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4937 * image.c (clear_image_cache): Likewise.
4938
f6a24d19
PE
4939 * term.c (term_mouse_position): Don't assume time_t wraparound.
4940
08dc5ae6
PE
4941 Be more systematic about user-interface timestamps.
4942 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4943 and sometimes 'EMACS_UINT', to represent these timestamps.
4944 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4945 This makes the code easier to follow, and makes it easier to catch
4946 integer overflow bugs such as Bug#8664.
4947 * frame.c (Fmouse_position, Fmouse_pixel_position):
4948 Use Time, not unsigned long, for user-interface timestamps.
4949 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4950 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4951 * keyboard.h (last_event_timestamp): Likewise.
4952 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4953 * menu.h (xmenu_show): Likewise.
4954 * term.c (term_mouse_position): Likewise.
4955 * termhooks.h (struct input_event.timestamp): Likewise.
4956 (struct terminal.mouse_position_hook): Likewise.
4957 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4958 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4959 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4960 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4961 what it was before.
4962 * menu.h, termhooks.h: Include "systime.h", for Time.
4963
8e55734a
PE
4964 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4965 Don't assume that the difference between two unsigned long values
4966 can fit into an integer. At this point, we know button_down_time
4967 <= event->timestamp, so the difference must be nonnegative, so
4968 there's no need to cast the result if double-click-time is
4969 nonnegative, as it should be; check that it's nonnegative, just in
4970 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4971 apart (about 25 days). (Bug#8664)
8e55734a 4972
841f1b75 4973 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4974 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4975
3e26f69c
PE
4976 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4977 that always fit in int. Use a sentinel instead of a counter, to
4978 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4979 * frame.h (struct frame): Use int for menu_bar_items_used
4980 instead of EMACS_INT, since it always fits in int.
3e26f69c 4981
5cc152c0
PE
4982 * menu.c (grow_menu_items): Check for int overflow.
4983
d89eb65e
PE
4984 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4985
5235bd3e
PE
4986 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4987 Before, the code was not consistent. These values cannot exceed
4988 2**31 - 1 so there's no need to make them unsigned.
4989 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4990 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4991 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4992 as modifiers.
4993 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4994
bc827e23
PE
4995 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4996 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4997 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4998 presumably because the widths might not match.
4999
78eb494e
PE
5000 * window.c (size_window): Avoid needless test at loop start.
5001
04f2d78b
CB
50022011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5003
5004 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5005
d2fc7e3d 50062011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5007
5008 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5009
d2fc7e3d 50102011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5011
5012 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5013 `width' to `bar_area_x' and `bar_area_width', respectively.
5014 (x_scroll_run): Take account of fringe background extension.
5015
04f2d78b
CB
5016 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5017 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5018 `bar_area_width', respectively.
5019 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5020 background extension.
5021
79b70037
GM
50222011-05-10 Jim Meyering <meyering@redhat.com>
5023
5024 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5025
2f142cc5
JB
50262011-05-10 Juanma Barranquero <lekktu@gmail.com>
5027
5028 * image.c (Finit_image_library): Return t for built-in image types,
5029 like pbm and xbm. (Bug#8640)
5030
57679c86
AS
50312011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5032
5033 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5034
888c9e86
EZ
50352011-05-07 Eli Zaretskii <eliz@gnu.org>
5036
b0512a1d
EZ
5037 * w32console.c (Fset_screen_color): Doc fix.
5038 (Fget_screen_color): New function.
5039 (syms_of_ntterm): Defsubr it.
5040
7285dc67
EZ
5041 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5042 unlink the temporary file if Fcall_process didn't create it in the
5043 first place.
5044 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5045 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5046 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5047 cue to call_process_cleanup not to close that handle.
5048
4d3fcc8e
BK
50492011-05-07 Ben Key <bkey76@gmail.com>
5050
5051 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5052 one of two shell specific rules, either bootstrap-temacs-CMD or
5053 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5054 to the previous implementation of the bootstrap-temacs rule.
5055 The bootstrap-temacs-CMD rule is similar to the previous
5056 implementation of the bootstrap-temacs rule except that it
5057 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5058 variable.
5059
5060 These changes, along with some changes to nt/configure.bat,
5061 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5062 earlier fix to add support for --cflags and --ldflags options
5063 that include quotes so that it works whether make uses cmd or
5064 sh as the shell.
5065
b4289b64
MA
50662011-05-06 Michael Albinus <michael.albinus@gmx.de>
5067
5068 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5069 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5070 is a constant.
5071 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5072 a string. Handle both cases.
5073 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5074 (Fdbus_register_method): Use Qinvalid_function.
5075
af4c0e28
JB
50762011-05-06 Juanma Barranquero <lekktu@gmail.com>
5077
5078 * makefile.w32-in: Update dependencies.
5079 (LISP_H): Add inttypes.h and stdin.h.
5080 (PROCESS_H): Add unistd.h.
5081
c51453d9
EZ
50822011-05-06 Eli Zaretskii <eliz@gnu.org>
5083
5084 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5085 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5086
8ff0ac3c 50872011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5088
4c4b566b
PE
5089 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5090
aab2b9b5
PE
5091 * term.c (vfatal): Remove stray call to va_end.
5092 It's not needed and the C Standard doesn't allow it here anyway.
5093
c378da0b
PE
5094 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5095 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5096
288b08c7
PE
5097 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5098 bytes.
5099
e3601888
PE
5100 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5101
db6c0e74
PE
5102 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5103
dd5963ea
PE
5104 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5105
88c9450f
PE
5106 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5107
2f9442b8
PE
5108 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5109
c032b5f8
PE
5110 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5111 * charset.c (Fdefine_charset_internal): Don't initialize
5112 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5113 32-bit int (Bug#8600).
a108c10b
PE
5114
5115 * lread.c (read_integer): Be more consistent with string-to-number.
5116 Use string_to_number to do the actual conversion; this avoids
5117 rounding errors and fixes some other screwups. Without this fix,
5118 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5119 (digit_to_number): Move earlier, for benefit of read_integer.
5120 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5121 not a digit in any supported base. (Bug#8602)
a108c10b 5122
ad5f9eea
PE
5123 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5124
aec1708a
PE
5125 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5126 to match comment at start of function. This also removes a
5127 GCC warning about overflow in a 32+64-bit port.
5128
47be4ab5
PE
5129 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5130
371cac43
PE
5131 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5132 Reported by Stefan Monnier in
5133 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5134 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5135 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5136
d01a7826
PE
5137 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5138 (EMACS_UINTPTR): Likewise, with uintptr_t.
5139
7fd47d5c
PE
5140 * lisp.h: Prefer 64-bit EMACS_INT if available.
5141 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5142 on 32-bit hosts that have 64-bit int, so that they can access
5143 large files.
122b0c86
PE
5144 However, temporarily disable this change unless the temporary
5145 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5146
8727937b
PE
5147 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5148
8ac068ac
PE
5149 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5150 This removes an assumption that EMACS_INT and long are the same
5151 width as pointers. The assumption is true for Emacs porting targets
5152 now, but we want to make other targets possible.
5153 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5154 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5155 In the rest of the code, change types of integers that hold casted
5156 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5157 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5158 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5159 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5160 No need to cast type when ORing.
5161 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5162 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5163 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5164 assume EMACS_INT is the same width as char *.
5165 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5166 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5167 Remove no-longer-needed casts.
5168 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5169 (xg_tool_bar_help_callback, xg_make_tool_item):
5170 Use EMACS_INTPTR to hold an integer
5171 that will be cast to void *; this can avoid a GCC warning
5172 if EMACS_INT is not the same width as void *.
5173 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5174 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5175 (current_message_1, set_message_1):
5176 Use a local to convert to proper width without a cast.
5177 * xmenu.c (dialog_selection_callback): Likewise.
5178
ede49d71
PE
5179 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5180 Also, don't assume VALBITS / RAND_BITS is less than 5,
5181 and don't rely on undefined behavior when shifting a 1 left into
5182 the sign bit.
5183 * lisp.h (get_random): Change signature to match.
5184
2f30ecd0
PE
5185 * lread.c (hash_string): Use size_t, not int, for hash computation.
5186 Normally we prefer signed values; but hashing is special, because
5187 it's better to use unsigned division on hash table sizes so that
5188 the remainder is nonnegative. Also, size_t is the natural width
5189 for hashing into memory. The previous code used 'int', which doesn't
5190 retain enough info to hash well into very large tables.
5191 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5192
2a866e7b
PE
5193 * dbusbind.c: Don't possibly lose pointer info when converting.
5194 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5195 Use XPNTR rather than XHASH, so that the high-order bits of
5196 the pointer aren't lost when converting through void *.
5197
51639eac
PE
5198 * eval.c (Fautoload): Don't double-shift a pointer.
5199
92394119
PE
5200 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5201
dbdb9a7c
JB
52022011-05-06 Juanma Barranquero <lekktu@gmail.com>
5203
5204 * gnutls.c (DEF_GNUTLS_FN):
5205 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5206
db7a0b4f
AS
52072011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5208
5209 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5210 marker. (Bug#8610)
5211
f7ff1b0f 52122011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5213
5214 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5215 New version that can reserve upto 2GB of heap space.
5216
f7ff1b0f 52172011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5218
5219 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5220
639c109b
TZ
52212011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5222
5223 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5224 `gnutls_certificate_set_x509_key_file'.
5225
d2127135
JB
52262011-05-05 Juanma Barranquero <lekktu@gmail.com>
5227
5228 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5229 Update dependencies.
5230
e968f4f3
JB
52312011-05-04 Juanma Barranquero <lekktu@gmail.com>
5232
5233 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5234 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5235 Remove unused parameter `fildes'.
5236 * process.c (read_process_output, send_process): Don't pass it.
5237
84d358f0
JB
52382011-05-04 Juanma Barranquero <lekktu@gmail.com>
5239
5240 Fix previous change: the library cache is defined in w32.c.
5241 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5242 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5243
0898ca10
JB
52442011-05-04 Juanma Barranquero <lekktu@gmail.com>
5245
5246 Implement dynamic loading of GnuTLS on Windows.
5247
5248 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5249 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5250 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5251 Declare.
5252
5253 * gnutls.c (Qgnutls_dll): Define.
5254 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5255 (gnutls_*): Declare function pointers.
5256 (init_gnutls_functions): New function to initialize function pointers.
5257 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5258 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5259 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5260 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5261 (emacs_gnutls_write, emacs_gnutls_read)
5262 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5263 (Fgnutls_available_p): New function.
5264 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5265 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5266 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5267
5268 * image.c: Include w32.h.
5269 (Vimage_type_cache): Delete.
5270 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5271 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5272 (w32_delayed_load): Move to w32.c.
5273
5274 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5275
5276 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5277 (w32_delayed_load): Move from image.c. When loading a library, record
5278 its filename in the :loaded-from property of the library id.
5279 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5280 Initialize and staticpro them.
5281 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5282
5283 * process.c: Include lisp.h before w32.h, not after.
5284 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5285 instead of gnutls_record_check_pending.
5286
5287 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5288
ff4de4aa
TZ
52892011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5290
5291 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5292 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5293 as passed in.
5294
abe95abb
JD
52952011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5296
5297 * xterm.c (x_set_frame_alpha): Do not set property on anything
5298 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5299
e16e55d4
JB
53002011-05-02 Juanma Barranquero <lekktu@gmail.com>
5301
5302 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5303
bafcf6a5
JB
53042011-05-02 Juanma Barranquero <lekktu@gmail.com>
5305
5306 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5307 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5308 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5309 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5310 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5311 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5312 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5313 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5314 (Qgnutls_bootprop_callbacks_verify): Make static.
5315
e7a6747f
AS
53162011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5317
19ed11ba
AS
5318 * callproc.c: Indentation fixup.
5319
e7a6747f 5320 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5321 (wait_for_termination, interruptible_wait_for_termination):
5322 Move after wait_for_termination_1.
e7a6747f 5323
1ef14cb4
LMI
53242011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5325
5326 * sysdep.c (interruptible_wait_for_termination): New function
5327 which is like wait_for_termination, but allows keyboard
5328 interruptions.
5329
5330 * callproc.c (Fcall_process): Add (:file "file") as an option for
5331 the STDOUT buffer.
5332 (Fcall_process_region): Ditto.
5333
330d880c
EZ
53342011-04-30 Eli Zaretskii <eliz@gnu.org>
5335
8db90b73
EZ
5336 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5337 rather than `XVECTOR (FOO)->size'.
5338
330d880c
EZ
5339 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5340 inttypes.h, as a gnulib replacement is used if it not available in
5341 system headers.
5342
15cbd324
EZ
53432011-04-21 Eli Zaretskii <eliz@gnu.org>
5344
5345 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5346 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5347 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5348
5349 * coding.c (coding_alloc_by_realloc): Error out if destination
5350 will grow beyond MOST_POSITIVE_FIXNUM.
5351 (decode_coding_emacs_mule): Abort if there isn't enough place in
5352 charbuf for the composition carryover bytes. Reserve an extra
5353 space for up to 2 characters produced in a loop.
5354 (decode_coding_iso_2022): Abort if there isn't enough place in
5355 charbuf for the composition carryover bytes.
5356
53572011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5358
ae940cca
EZ
5359 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5360 aborting when %lld or %lll format is passed.
5361 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5362 %llo or %llx format is passed. (Bug#8545)
5363
03ab8921
EZ
5364 * window.c (window_scroll_line_based): Use a marker instead of
5365 simple variables to record original value of point. (Bug#7952)
5366
afda1437
EZ
5367 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5368 produced by %s or %c overflows available buffer space. (Bug#8545)
5369
f76dee0c
PE
53702011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5371
5372 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5373 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5374
fdc5744d
JB
53752011-04-28 Juanma Barranquero <lekktu@gmail.com>
5376
5377 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5378
638f053a
JB
53792011-04-28 Juanma Barranquero <lekktu@gmail.com>
5380
5381 * keyboard.c (Qdelayed_warnings_hook): Define.
5382 (command_loop_1): Run `delayed-warnings-hook'
5383 if Vdelayed_warnings_list is non-nil.
5384 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5385 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5386
d178f871
EZ
53872011-04-28 Eli Zaretskii <eliz@gnu.org>
5388
5389 * doprnt.c (doprnt): Don't return value smaller than the buffer
5390 size if the message was truncated. (Bug#8545).
5391
b124fd93
JB
53922011-04-28 Juanma Barranquero <lekktu@gmail.com>
5393
5394 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5395 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5396
e810457d
PE
53972011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5398
5399 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5400
ea51cceb
JB
54012011-04-27 Juanma Barranquero <lekktu@gmail.com>
5402
5403 * makefile.w32-in: Update dependencies.
5404
94dcfacf
EZ
54052011-04-27 Eli Zaretskii <eliz@gnu.org>
5406
5407 Improve `doprnt' and its usage. (Bug#8545)
5408 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5409 `format_end'. Remove support for %l as a conversion specifier.
5410 Don't use xrealloc. Improve diagnostics when the %l size modifier
5411 is used. Update the commentary.
5412
5413 * eval.c (verror): Simplify calculation of size_t.
5414
5415 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5416 messages.
5417
f61f41d7
PE
54182011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5419
5420 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5421 change.
5422
96fb4434
PE
54232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5424
5425 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5426 This makes this file independent of the recent pseudovector change.
5427
671875da 54282011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5429
69e9b5a3
PE
5430 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5431
b5f869a7 5432 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5433 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5434 Remove unused local.
c8926152 5435 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5436
841a1577 5437 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5438 GCC 4.6.0 optimizes based on type-based alias analysis.
5439 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5440 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5441 != &v->size, and therefore "v->size = 1; b->size = 2; return
5442 v->size;" must therefore return 1. This assumption is incorrect
5443 for Emacs, since it type-puns struct Lisp_Vector * with many other
5444 types. To fix this problem, this patch adds a new type struct
f904488f 5445 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5446 and pseudovectors, and helps optimizing compilers not get fooled
5447 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5448 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5449 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5450 the size member.
eab3844f
PE
5451 (XSETPVECTYPE): Rewrite in terms of new macro.
5452 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5453 This is a bit clearer, and further avoids the possibility of
5454 undesirable aliasing.
5455 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5456 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5457 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5458 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5459 (ASIZE): Now uses header.size rather than size.
5460 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5461 to avoid the hassle of writing XVECTOR (foo)->header.size.
5462 (struct vectorlike_header): New type.
eab3844f
PE
5463 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5464 object, to help avoid aliasing.
5465 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5466 (SUBRP): Likewise, since Lisp_Subr is a special case.
5467 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5468 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5469 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5470 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5471 changed to be "header.size" and "header.next".
5472 * buffer.h (struct buffer): Likewise.
5473 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5474 * frame.h (struct frame): Likewise.
5475 * process.h (struct Lisp_Process): Likewise.
5476 * termhooks.h (struct terminal): Likewise.
5477 * window.c (struct save_window_data, struct saved_window): Likewise.
5478 * window.h (struct window): Likewise.
5479 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5480 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5481 * buffer.c (init_buffer_once): Likewise.
5482 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5483 special case.
5484 * process.c (Fformat_network_address): Use local var for size,
5485 for brevity.
5486
0df1eac5
PE
5487 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5488
847ab9d1 5489 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5490 * data.c (atof): Remove decl; no longer used or needed.
5491 (digit_to_number): Move to lread.c.
5492 (Fstring_to_number): Use new string_to_number function, to be
5493 consistent with how the Lisp reader treats infinities and NaNs.
5494 Do not assume that floating-point numbers represent EMACS_INT
5495 without losing information; this is not true on most 64-bit hosts.
5496 Avoid double-rounding errors, by insisting on integers when
5497 parsing non-base-10 numbers, as the documentation specifies.
5498 * lisp.h (string_to_number): New decl, replacing ...
5499 (isfloat_string): Remove.
bc0a5c13 5500 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5501 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5502 appears to have been a coding error. Similarly, do not accept
5503 strings like +-1e0 as floating point numbers. Do not report
5504 overflow for integer overflows unless the base is not 10 which
5505 means we have no simple and reliable way to continue.
5506 Break out the floating-point parsing into a new
5507 function string_to_number, so that Fstring_to_number parses
5508 floating point numbers consistently with the Lisp reader.
04f2d78b 5509 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5510 (E_CHAR, EXP_INT): Remove, replacing with ...
5511 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5512 (string_to_number): New function, replacing isfloat_string.
5513 This function checks for valid syntax and produces the resulting
5514 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5515 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5516 so that overflow for non-base-10 numbers is reported only when
5517 there's no portable and simple way to convert to floating point.
452f4150 5518
67769ffc
PE
5519 * textprop.c (set_text_properties_1): Rewrite for clarity,
5520 and to avoid GCC warning about integer overflow.
5521
c20db43f
PE
5522 * intervals.h (struct interval): Use EMACS_INT for members
5523 where EMACS_UINT might cause problems. See
5524 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5525 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5526 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5527 All uses changed.
37aa2f85
PE
5528 (offset_intervals): Tell GCC not to worry about length overflow
5529 when negating a negative length.
c20db43f 5530
2538aa2f
PE
5531 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5532 (overrun_check_free): Likewise.
5533
f2d3008d
PE
5534 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5535 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5536 word size.
5537
ec8df744
PE
5538 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5539 (gnutls_make_error): Rename local to avoid shadowing.
5540 (gnutls_emacs_global_deinit): ifdef out; not used.
5541 (Fgnutls_boot): Use const for pointer to readonly storage.
5542 Comment out unused local. Fix pointer signedness problems.
5543
640ee02d
PE
5544 * lread.c (openp): Don't stuff size_t into an 'int'.
5545 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5546 about possible signed overflow.
5547
6048fb2a
PE
5548 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5549 (GDK_KEY_g): Don't define if already defined.
5550 (xg_prepare_tooltip): Avoid pointer signedness problem.
5551 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5552
fa3c87e1
PE
5553 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5554 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5555
2172544b
PE
5556 * xfns.c (Fx_window_property): Simplify a bit,
5557 to make a bit faster and to avoid GCC 4.6.0 warning.
5558 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5559
9b821a21
PE
5560 * fns.c (internal_equal): Don't assume size_t fits in int.
5561
3c616cfa
PE
5562 * alloc.c (compact_small_strings): Tighten assertion a little.
5563
c2982e87
PE
5564 Replace pEd with more-general pI, and fix some printf arg casts.
5565 * lisp.h (pI): New macro, generalizing old pEd macro to other
5566 conversion specifiers. For example, use "...%"pI"d..." rather
5567 than "...%"pEd"...".
5568 (pEd): Remove. All uses replaced with similar uses of pI.
5569 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5570 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5571 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5572 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5573 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5574 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5575 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5576 64-bit hosts.
5577 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5578 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5579 * print.c (safe_debug_print, print_object): Likewise.
5580 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5581 to int.
6f04d126
PE
5582 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5583 avoiding the 0 flag, which is not portable.
c2982e87
PE
5584 * process.c (Fmake_network_process): Use pI to avoid cast.
5585 * region-cache.c (pp_cache): Likewise.
5586 * xdisp.c (decode_mode_spec): Likewise.
5587 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5588 behavior on 64-bit hosts with printf arg.
6f04d126 5589 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5590 (x_stop_queuing_selection_requests): Likewise.
5591 (x_get_window_property): Don't truncate byte count to an 'int'
5592 when tracing.
0b432f21 5593
5e073ec7
PE
5594 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5595 here, since it parses constructs like leading '-' and spaces,
5596 which are not wanted; and it overflows with large numbers.
5597 Instead, simply match F[0-9]+, which is what is wanted anyway.
5598
36372bf9
PE
5599 * alloc.c: Remove unportable assumptions about struct layout.
5600 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5601 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5602 (allocate_vectorlike, make_pure_vector): Use the new macros,
5603 plus offsetof, to remove unportable assumptions about struct layout.
5604 These assumptions hold on all porting targets that I know of, but
5605 they are not guaranteed, they're easy to remove, and removing them
5606 makes further changes easier.
5607
0b432f21
PE
5608 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5609 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5610 (string_overrun_cookie): Now const. Use initializers that
5611 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5612 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5613 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5614 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5615 multiple of sizeof (EMACS_INT); it need not be, if
5616 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5617 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5618
895009e1
JB
56192011-04-26 Juanma Barranquero <lekktu@gmail.com>
5620
5621 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5622
6a7a1b0b
TZ
56232011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5624
5625 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5626 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5627 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5628
841a1577 56292011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5630
5631 * lisp.h (Qdebug): List symbol.
895009e1 5632 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5633 * keyboard.c (debug-on-event): New variable.
5634 (handle_user_signal): Break into debugger when debug-on-event
5635 matches the current signal symbol.
5636
f2d3ba6f
DN
56372011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5638
5639 * alloc.c (check_sblock, check_string_bytes)
5640 (check_string_free_list): Convert to standard C.
5641
42ce4c63
TZ
56422011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5643
5644 * w32.c (emacs_gnutls_push): Fix typo.
5645
825cd63c
EZ
56462011-04-25 Eli Zaretskii <eliz@gnu.org>
5647
fb11d64d
EZ
5648 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5649 "cast to pointer from integer of different size".
5650
825cd63c
EZ
5651 Improve doprnt and its use in verror. (Bug#8545)
5652 * doprnt.c (doprnt): Document the set of format control sequences
5653 supported by the function. Use SAFE_ALLOCA instead of always
5654 using `alloca'.
5655
5656 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5657 is one byte too soon. Don't use xrealloc; instead xfree and
5658 xmalloc anew.
5659
e061a11b
TZ
56602011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5661
5662 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5663 callbacks stage.
5664
5665 * gnutls.c: Renamed global_initialized to
5666 gnutls_global_initialized. Added internals for the
5667 :verify-hostname-error, :verify-error, and :verify-flags
5668 parameters of `gnutls-boot' and documented those parameters in the
5669 docstring. Start callback support.
9173deec
JB
5670 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5671 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5672 on error. Return error code.
e061a11b
TZ
5673 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5674 (emacs_gnutls_read): Likewise.
5675 (Fgnutls_boot): Return handshake error code.
5676 (emacs_gnutls_handle_error): New function.
5677 (wsaerror_to_errno): Likewise.
5678
5679 * w32.h (emacs_gnutls_pull): Add prototype.
5680 (emacs_gnutls_push): Likewise.
5681
5682 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5683 (emacs_gnutls_push): Likewise.
5684
56852011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5686
5687 * process.c (wait_reading_process_output): Check if GnuTLS
5688 buffered some data internally if no FDs are set for TLS
5689 connections.
5690
5691 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5692 (LIBS): Link to USER_LIBS.
5693 ($(BLD)/gnutls.$(0)): New target.
5694
fa6996bc
EZ
56952011-04-24 Eli Zaretskii <eliz@gnu.org>
5696
eb35682e
EZ
5697 * xdisp.c (handle_single_display_spec): Rename the
5698 display_replaced_before_p argument into display_replaced_p, to
5699 make it consistent with the commentary. Fix typos in the
5700 commentary.
5701
e2ad650c
EZ
5702 * textprop.c (syms_of_textprop): Remove dead code.
5703 (copy_text_properties): Delete obsolete commentary about an
5704 interface that was deleted long ago. Fix typos in the description
5705 of arguments.
5706
1b2de274
EZ
5707 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5708 to changes in oldXMenu/XMenu.h from 2011-04-16.
5709 <menu_help_message, prev_menu_help_message>: Constify.
5710 (IT_menu_make_room): menu->help_text is now `const char **';
5711 adjust.
5712
5713 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5714 to changes in oldXMenu/XMenu.h from 2011-04-16.
5715 (struct XMenu): Declare `help_text' `const char **'.
5716
5717 * xfaces.c <Qunspecified>: Make extern again.
5718
5719 * syntax.c: Include sys/types.h before including regex.h, as
5720 required by Posix.
5721
762b15be
EZ
5722 * doc.c (get_doc_string): Improve the format passed to `error'.
5723
5724 * doprnt.c (doprnt): Improve commentary.
5725
5726 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5727
5728 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5729 them with etags.
5730
f1052e5d
EZ
5731 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5732 changes in globals.h immediately force recompilation.
762b15be
EZ
5733 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5734 $(CURDIR)/s/ms-w32.h.
5735 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5736
fa6996bc
EZ
5737 * character.c (Fchar_direction): Function deleted.
5738 (syms_of_character): Don't defsubr it.
5739 <char-direction-table>: Deleted.
5740
e6c3da20
EZ
57412011-04-23 Eli Zaretskii <eliz@gnu.org>
5742
5743 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5744 * doprnt.c: Include limits.h.
5745 (SIZE_MAX): New macro.
04f2d78b
CB
5746 (doprnt): Return a size_t value. 2nd arg is now size_t.
5747 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5748 Improve overflow protection. Support `l' modifier for integer
5749 conversions. Support %l conversion. Don't assume an EMACS_INT
5750 argument for integer conversions and for %c.
5751
5752 * lisp.h (doprnt): Restore prototype.
5753
5754 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5755 $(SRC)/character.h.
5756
5757 * Makefile.in (base_obj): Add back doprnt.o.
5758
5759 * deps.mk (doprnt.o): Add back prerequisites.
5760 (callint.o): Depend on character.h.
5761
5762 * eval.c (internal_lisp_condition_case): Include the handler
5763 representation in the error message.
5764 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5765 when breaking from the loop.
5766
5767 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5768
5769 * callint.c (Fcall_interactively): When displaying error message
5770 about invalid control letter, pass the character's codepoint, not
5771 a pointer to its multibyte form. Improve display of the character
5772 in octal and display also its hex code.
5773
5774 * character.c (char_string): Use %x to display the (unsigned)
5775 codepoint of an invalid character, to avoid displaying a bogus
5776 negative value.
5777
5778 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5779 `error', not SYMBOL_NAME itself.
5780
5781 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5782 character arguments to `error'.
5783
5784 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5785 to `error' in error message about FINAL_CHAR argument. Make sure
5786 FINAL_CHAR is a character, and use %c when it is passed as
5787 argument to `error'.
5788
4ffd0d6b 57892011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5790
5791 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5792
5793 * w32.c: Include <time.h>.
5794 (sys_localtime): New function.
5795
4ffd0d6b 57962011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5797
5798 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5799
4ffd0d6b 5800 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5801
4ffd0d6b 58022011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5803
4ffd0d6b
GM
5804 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5805 zombies (Bug#8467).
aac0c6e3 5806
04c56954
EZ
58072011-04-19 Eli Zaretskii <eliz@gnu.org>
5808
5809 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5810 gl_state.e_property when gl_state.object is Qt.
5811
5812 * insdel.c (make_gap_larger): Remove limitation of buffer size
5813 to <= INT_MAX.
5814
16a43933
CY
58152011-04-18 Chong Yidong <cyd@stupidchicken.com>
5816
5817 * xdisp.c (lookup_glyphless_char_display)
5818 (produce_glyphless_glyph): Handle cons cell entry in
5819 glyphless-char-display.
5820 (Vglyphless_char_display): Document it.
5821
5822 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5823 glyphless-char-display.
5824
4581706e
CY
58252011-04-17 Chong Yidong <cyd@stupidchicken.com>
5826
5827 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5828
5829 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5830
5831 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5832 definition for no-X builds.
5833
4887c6e2 58342011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5835
fd35b6f9
PE
5836 Static checks with GCC 4.6.0 and non-default toolkits.
5837
5c1ccb01
PE
5838 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5839
006c5daa
PE
5840 * process.c (keyboard_bit_set): Define only if SIGIO.
5841 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5842 (send_process): Repair possible setjmp clobbering.
5843
efc736d3
PE
5844 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5845
4e2fe2e6
PE
5846 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5847
f97334a2
PE
5848 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5849
4e75f29d
PE
5850 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5851 Define only if needed.
5852
90efadd1
PE
5853 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5854 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5855 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5856
3c647824
PE
5857 * dispextern.h (struct redisplay_interface): Rename param
5858 to avoid shadowing.
e264f262 5859 * termhooks.h (struct terminal): Likewise.
761383f4 5860 * xterm.c (xembed_send_message): Likewise.
3c647824 5861
b58c5c4a
PE
5862 * insdel.c (make_gap_smaller): Define only if
5863 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5864
cad59032
PE
5865 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5866 it.
5867
c339dc2e
PE
5868 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5869 so that we aren't warned about unused symbols.
5870
91a3e27b
PE
5871 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5872
399c71d3 5873 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5874
8ffc96f5
PE
5875 * xfns.c (x_real_positions): Mark locals as initialized.
5876
eef9bc79
PE
5877 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5878
098db9dd
PE
5879 * xterm.c: Fix problems found by static analysis with other toolkits.
5880 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5881 (x_dispatch_event): Declare static if USE_GTK, and
5882 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5883 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5884 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5885 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5886 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5887
eb18f6cc
PE
5888 * xmenu.c (menu_help_callback): Pointer type fixes.
5889 Use const pointers when pointing at readonly data. Avoid pointer
5890 signedness clashes.
5891 (FALSE): Remove unused macro.
5892 (update_frame_menubar): Remove unused decl.
5893
1fe72bf8
PE
5894 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5895
60d9e1db
PE
5896 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5897 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5898 (single_menu_item): Rename local to avoid shadowing.
5899
39261c26
PE
5900 * keyboard.c (make_lispy_event): Remove unused local var.
5901
018c5e19
PE
5902 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5903 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5904
63d2b86e
PE
5905 * bitmaps: Change bitmaps from unsigned char back to the X11
5906 compatible char. Avoid the old compiler warnings about
5907 out-of-range initializers by using, for example, '\xab' rather
5908 than 0xab.
5909
aefd87e1
PE
5910 * xgselect.c (xgselect_initialize): Check vs interface
5911 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5912
bf501fb9
PE
5913 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5914
e9829fdf
PE
5915 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5916 to read-only memory.
5917
1086c095
PE
5918 * fns.c (vector): Remove; this old hack is no longer needed.
5919
2baccd04 5920 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5921 Remove unused var.
dde42981 5922 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5923
72391843 5924 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5925
436c16df 5926 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5927 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5928 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5929
92bb796d 5930 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5931 (x_term_init): Remove local to avoid shadowing.
92bb796d 5932
764430a3 5933 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5934
5935 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5936 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5937
d1dfb56c
EZ
59382011-04-16 Eli Zaretskii <eliz@gnu.org>
5939
c4354cb4
EZ
5940 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5941
d1dfb56c
EZ
5942 Fix regex.c, syntax.c and friends for buffers > 2GB.
5943 * syntax.h (struct gl_state_s): Declare character position members
5944 EMACS_INT.
5945
5946 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5947
04f2d78b
CB
5948 * textprop.c (verify_interval_modification, interval_of):
5949 Declare arguments EMACS_INT.
d1dfb56c
EZ
5950
5951 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5952 EMACS_INT.
5953
5954 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5955
5956 * indent.c (Fvertical_motion): Local variable it_start is now
5957 EMACS_INT.
5958
5959 * regex.c (re_match, re_match_2, re_match_2_internal)
5960 (bcmp_translate, regcomp, regexec, print_double_string)
5961 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5962 (re_compile_pattern, re_exec): Declare arguments and local
5963 variables `size_t' and `ssize_t' and return values `regoff_t', as
5964 appropriate.
5965 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5966 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5967 <compile_stack_type>: `size' and `avail' are now `size_t'.
5968
5969 * regex.h <regoff_t>: Use ssize_t, not int.
5970 (re_search, re_search_2, re_match, re_match_2): Arguments that
5971 specify buffer/string position and length are now ssize_t and
5972 size_t. Return type is regoff_t.
5973
613052cd
BK
59742011-04-16 Ben Key <bkey76@gmail.com>
5975
5976 * nsfont.m: Fixed bugs in ns_get_family and
5977 ns_descriptor_to_entity that were caused by using free to
5978 deallocate memory blocks that were allocated by xmalloc (via
5979 xstrdup). This caused Emacs to crash when compiled with
5980 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5981 --enable-checking=xmallocoverrun). xfree is now used to
5982 deallocate these memory blocks.
5983
4170f62f 59842011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5985
71b41406
PE
5986 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5987
9587a89d
PE
5988 emacs_write: Accept and return EMACS_INT for sizes.
5989 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5990 et seq.
5991 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5992 Accept and return EMACS_INT.
5993 (emacs_gnutls_write): Return the number of bytes written on
5994 partial writes.
5995 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5996 (emacs_read, emacs_write): Remove check for negative size, as the
5997 Emacs source code has been audited now.
9587a89d
PE
5998 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5999 (emacs_read, emacs_write): Use it.
273a5f82
PE
6000 * process.c (send_process): Adjust to the new signatures of
6001 emacs_write and emacs_gnutls_write. Do not attempt to store
6002 a byte offset into an 'int'; it might overflow.
9587a89d 6003 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6004
3e047f51
PE
6005 * sound.c: Don't assume sizes fit in 'int'.
6006 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6007 Return EMACS_INT, not int.
3e047f51 6008 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6009 Accept EMACS_INT, not int.
6010 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6011 record read return values.
6012
cc39a9db
BK
60132011-04-15 Ben Key <bkey76@gmail.com>
6014
c9d0ec6d
JB
6015 * keyboard.c (Qundefined): Don't declare static since it is used
6016 in nsfns.m.
6017 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6018 static since they are used in nsfont.m.
cc39a9db 6019
6c60eb9f
SM
60202011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6021
6022 * process.c (Qprocessp): Don't declare static.
6023 * lisp.h (Qprocessp): Declare again.
6024
7990b61a
JB
60252011-04-15 Juanma Barranquero <lekktu@gmail.com>
6026
6027 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6028
5d4cb038
PE
60292011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6030
8bd7b830 6031 Improve C-level modularity by making more things 'static'.
cd64ea1d 6032
e3b27b31
PE
6033 Don't publish debugger-only interfaces to other modules.
6034 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6035 (verify_bytepos, count_markers): Move decls to the only modules
6036 that need them.
6037 * region-cache.h (pp_cache): Likewise.
6038 * window.h (check_all_windows): Likewise.
6039 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6040
5d4cb038
PE
6041 * sysdep.c (croak): Now static, if
6042 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6043 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6044
6045 * alloc.c (refill_memory_reserve): Now static if
6046 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6047 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6048
e87b6180
PE
6049 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6050 Define only if USE_LUCID.
6051
ac64929e
PE
6052 * xrdb.c (x_customization_string, x_rm_string): Now static.
6053
6f37259d
PE
6054 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6055 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6056
1683e3ab
PE
6057 * xdisp.c (draw_row_with_mouse_face): Now static.
6058 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6059
de9c2632
PE
6060 * window.h (check_all_windows): Mark externally visible.
6061
2b96acb7
PE
6062 * window.c (window_deletion_count): Now static.
6063
6064 * undo.c: Make symbols static if they're not exported.
6065 (last_undo_buffer, last_boundary_position, pending_boundary):
6066 Now static.
6067
50436f33
PE
6068 * textprop.c (interval_insert_behind_hooks): Now static.
6069 (interval_insert_in_front_hooks): Likewise.
6070
64520e5c
PE
6071 * term.c: Make symbols static if they're not exported.
6072 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6073 (max_frame_lines, tty_set_terminal_modes):
6074 (tty_reset_terminal_modes, tty_turn_off_highlight):
6075 (get_tty_terminal): Now static.
6076 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6077 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6078 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6079 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6080 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6081
1fa53021
PE
6082 * sysdep.c: Make symbols static if they're not exported.
6083 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6084 Now static.
6085 (sigprocmask_set, full_mask): Remove; unused.
6086 (wait_debugging): Mark as visible.
6087 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6088 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6089
d4b43b22
PE
6090 * syntax.c (syntax_temp): Define only if !__GNUC__.
6091
b7c513d0
PE
6092 * sound.c (current_sound_device, current_sound): Now static.
6093
989b29ad
PE
6094 * search.c (searchbufs, searchbuf_head): Now static.
6095
13a55a78
PE
6096 * scroll.c (scroll_cost): Remove; unused.
6097 * dispextern.h (scroll_cost): Remove decl.
6098
de68a1fc
PE
6099 * region-cache.h (pp_cache): Mark as externally visible.
6100
40ccffa6
PE
6101 * process.c: Make symbols static if they're not exported.
6102 (process_tick, update_tick, create_process, chan_process):
6103 (Vprocess_alist, proc_buffered_char, datagram_access):
6104 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6105 (deactivate_process): Mark defn as static, as well as decl.
6106 * lisp.h (create_process): Remove decl.
6107 * process.h (chan_process, Vprocess_alist): Remove decls.
6108
ad64fc97
PE
6109 * print.c: Make symbols static if they're not exported.
6110 (print_depth, new_backquote_output, being_printed, print_buffer):
6111 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6112 (print_interval, print_number_index, initial_stderr_stream):
6113 Now static.
6114 * lisp.h (Fprinc): Remove decl.
6115 (debug_output_compilation_hack): Mark as externally visible.
6116
adddb265
PE
6117 * sysdep.c (croak): Move decl from here to syssignal.h.
6118 * syssignal.h (croak): Put it here, so the API can be checked when
6119 'croak' is called from dissociate_if_controlling_tty.
6120
1717ede2
PE
6121 * minibuf.c: Make symbols static if they're not exported.
6122 (minibuf_save_list, choose_minibuf_frame): Now static.
6123 * lisp.h (choose_minibuf_frame): Remove decl.
6124
fa5fb2bc
PE
6125 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6126
1e3890d1
PE
6127 * lread.c: Make symbols static if they're not exported.
6128 (read_objects, initial_obarray, oblookup_last_bucket_number):
6129 Now static.
6130 (make_symbol): Remove; unused.
6131 * lisp.h (initial_obarray, make_symbol): Remove decls.
6132
8a1414fa
PE
6133 * keyboard.c: Make symbols static if they're not exported.
6134 (single_kboard, recent_keys_index, total_keys, recent_keys):
6135 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6136 (this_single_command_key_start, echoing, last_auto_save):
6137 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6138 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6139 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6140 (Vlispy_mouse_stem, double_click_count):
6141 Now static.
6142 (force_auto_save_soon): Define only if SIGDANGER.
6143 (ignore_mouse_drag_p): Now static if
6144 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6145 (print_help): Remove; unused.
6146 (stop_character, last_timer_event): Mark as externally visible.
6147 * keyboard.h (ignore_mouse_drag_p): Declare only if
6148 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6149 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6150 * lisp.h (echoing): Remove decl.
6151 (force_auto_save_soon): Declare only if SIGDANGER.
6152 * xdisp.c (redisplay_window): Simplify code, to make it more
6153 obvious that ignore_mouse_drag_p is not accessed if !defined
6154 USE_GTK && !defined HAVE_NS.
6155
93ea6e8f
PE
6156 * intervals.c: Make symbols static if they're not exported.
6157 (merge_properties_sticky, merge_interval_right, delete_interval):
6158 Now static.
6159 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6160
77382fcc
PE
6161 * insdel.c: Make symbols static if they're not exported.
6162 However, leave prepare_to_modify_buffer alone. It's never
6163 called from outside this function, but that appears to be a bug.
6164 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6165 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6166 (adjust_after_replace_noundo): Remove; unused.
6167 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6168 (signal_before_change): Remove decls.
77382fcc 6169
9306c32e
PE
6170 * indent.c (val_compute_motion, val_vmotion): Now static.
6171
cd44d2eb
PE
6172 * image.c: Make symbols static if they're not exported.
6173 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6174 if USE_GTK.
6175 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6176 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6177
ad9a7a06
PE
6178 * fringe.c (standard_bitmaps): Now static.
6179 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6180
81626931
PE
6181 * frame.c: Make symbols static if they're not exported.
6182 (x_report_frame_params, make_terminal_frame): Now static.
6183 (get_frame_param): Now static, unless HAVE_NS.
6184 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6185 (x_get_resource_string): Remove; not used.
6186 * frame.h (make_terminal_frame, x_report_frame_params):
6187 (x_get_resource_string); Remove decls.
6188 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6189 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6190
239f9db9
PE
6191 * font.c, fontset.c: Make symbols static if they're not exported.
6192 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6193 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6194 * font.c (font_close_object): Now static.
6195 * font.h (font_close_object): Remove.
6196 * fontset.c (FONTSET_OBJLIST): Remove.
6197 (free_realized_fontset) #if-0 the body, which does nothing.
6198 (face_suitable_for_char_p): #if-0, as it's never called.
6199 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6200 * xfaces.c (face_at_string_position):
6201 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6202 since 0 is always ASCII.
6203
dfcf3579
PE
6204 * fns.c (weak_hash_tables): Now static.
6205
5045092b
PE
6206 * fileio.c: Make symbols static if they're not exported.
6207 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6208 (Vwrite_region_annotation_buffers): Now static.
6209
57a96f5c
PE
6210 * eval.c: Make symbols static if they're not exported.
6211 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6212 * lisp.h (backtrace_list): Remove decl.
6213
35f08c38
PE
6214 * emacs.c: Make symbols static if they're not exported.
6215 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6216 (fatal_error_code, fatal_error_signal_hook, standard_args):
6217 Now static.
6218 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6219 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6220 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6221 * lisp.h (fatal_error_signal_hook): Remove decl.
6222 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6223
f44bd759
PE
6224 * editfns.c: Move a (normally-unused) function to its only use.
6225 * editfns.c, lisp.h (get_operating_system_release): Remove.
6226 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6227 worth the hassle of breaking this out.
6228
b532497d
PE
6229 * xterm.c: Make symbols static if they're not exported.
6230 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6231 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6232 (x_destroy_window, x_delete_display):
6233 Now static.
6234 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6235 (x_mouse_leave): Remove; unused.
6236 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6237 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6238 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6239 Remove decls.
6240 (x_mouse_leave): Declare only if WINDOWSNT.
6241 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6242 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6243 USE_X_TOOLKIT.
6244
1675728f
PE
6245 * ftxfont.c: Make symbols static if they're not exported.
6246 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6247 HAVE_FREETYPE.
6248 * font.h (ftxfont_driver): Likewise.
6249
e4cebfca
PE
6250 * xfns.c: Make symbols static if they're not exported.
6251 (x_last_font_name, x_display_info_for_name):
6252 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6253 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6254 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6255 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6256 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6257 (last_show_tip_args): Now static.
6258 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6259 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6260 (x_screen_planes): Remove; unused.
6261 * dispextern.h (x_screen_planes): Remove decl.
6262
5bf46f05
PE
6263 * dispnew.c: Make symbols static if they're not exported.
6264 * dispextern.h (redraw_garbaged_frames, scrolling):
6265 (increment_row_positions): Remove.
6266 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6267 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6268 Now static.
6269 (redraw_garbaged_frames): Remove; unused.
6270
435f4c28
PE
6271 * xfaces.c: Make symbols static if they're not exported.
6272 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6273 Remove decls.
6274 * xterm.h (defined_color): Remove decls.
6275 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6276 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6277 (menu_face_changed_default, defined_color, free_realized_face):
6278 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6279 (ascii_face_of_lisp_face): Remove; unused.
6280
8524aef3
PE
6281 * xdisp.c: Make symbols static if they're not exported.
6282 * dispextern.h (scratch_glyph_row, window_box_edges):
6283 (glyph_to_pixel_coords, set_cursor_from_row):
6284 (get_next_display_element, set_iterator_to_next):
6285 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6286 (show_mouse_face): Remove decls
6287 * frame.h (message_buf_print): Likewise.
6288 * lisp.h (pop_message, set_message, check_point_in_composition):
6289 Likewise.
6290 * xterm.h (set_vertical_scroll_bar): Likewise.
6291 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6292 (message_buf_print, scratch_glyph_row, displayed_buffer):
6293 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6294 (get_next_display_element, show_mouse_face, window_box_edges):
6295 (frame_to_window_pixel_xy, check_point_in_composition):
6296 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6297 (glyph_to_pixel_coords): Remove; unused.
6298
16390cd2
PE
6299 * dired.c (file_name_completion): Now static.
6300
6301 * dbusbind.c (xd_in_read_queued_messages): Now static.
6302
a25f4dfa
PE
6303 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6304 * data.c (circular_list_error): Remove.
6305
14a9c8df
PE
6306 * commands.h (last_point_position, last_point_position_buffer):
6307 (last_point_position_window): Remove decls.
6308 * keyboard.c: Make these variables static.
6309
04f2d78b
CB
6310 * coding.h (coding, code_convert_region, encode_coding_gap):
6311 Remove decls.
74ab6df5
PE
6312 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6313 (iso_code_class, detect_coding, code_convert_region): Now static.
6314 (encode_coding_gap): Remove; unused.
6315
38dfbee1
PE
6316 * chartab.c (chartab_chars, chartab_bits): Now static.
6317
a2cb4e63
PE
6318 * charset.h (charset_iso_8859_1): Remove decl.
6319 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6320 Now static.
6321
127198fd
PE
6322 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6323 * ccl.c (Vccl_program_table): Now static.
6324 (check_ccl_update): Remove; unused.
6325
d85b608f
PE
6326 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6327 * category.h: ... from here.
6328 * category.c (check_category_table, set_category_set): Now static.
6329
31cd66f3
PE
6330 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6331 * lisp.h: Remove these decls.
6332
c358e587
PE
6333 * buffer.c (buffer_count): Remove unused var.
6334
e78aecca
PE
6335 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6336 so that it's not optimized away.
6337 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6338 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6339 exported only to the debugger.
6340
e192d7d3 6341 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6342 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6343
92470028
PE
6344 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6345 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6346 was inaccessible from Lisp.
6347 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6348 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6349
244ed907
PE
6350 alloc.c: Import and export fewer symbols, and remove unused items.
6351 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6352 is defined.
6353 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6354 it's not optimized away by whole-program optimization.
6355 (message_enable_multibyte, free_misc): Remove.
6356 (catchlist, handlerlist, mark_backtrace):
6357 Declare only if BYTE_MARK_STACK.
6358 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6359 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6360 (message_enable_multibyte): Remove decl.
6361 (free_misc, interval_free_list, float_block, float_block_index):
6362 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6363 (cons_free_list, last_marked_index):
6364 Now static.
6365 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6366 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6367 (mark_backtrace): Define only if BYTE_MARK_STACK.
6368 * xdisp.c (message_enable_multibyte): Now static.
6369
61c2b50e 6370 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6371 This makes it easier for human readers (and static analyzers)
6372 to see whether these variables are used from other modules.
6373 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6374 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6375 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6376 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6377 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6378 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6379 * xmenu.c, xselect.c:
6380 Declare Q* vars static if they are not used in other modules.
6381 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6382 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6383 Remove decls of unexported vars.
6384 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6385
95c82688
PE
6386 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6387
16a97296
PE
6388 Make Emacs functions such as Fatom 'static' by default.
6389 This makes it easier for human readers (and static analyzers)
6390 to see whether these functions can be called from other modules.
6391 DEFUN now defines a static function. To make the function external
6392 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6393 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6394 (Finit_image_library):
16a97296
PE
6395 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6396 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6397 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6398 Remove decls, since these functions are now static.
6399 (Funintern, Fget_internal_run_time): New decls, since these functions
6400 were already external.
95c82688 6401
16a97296
PE
6402 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6403 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6404 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6405 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6406 * keyboard.c, keymap.c, lread.c:
6407 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6408 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6409 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6410 Mark functions with DEFUE instead of DEFUN,
6411 if they are used in other modules.
6412 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6413 decls for now-static functions.
6414 * buffer.h (Fdelete_overlay): Remove decl.
6415 * callproc.c (Fgetenv_internal): Mark as internal.
6416 * composite.c (Fremove_list_of_text_properties): Remove decl.
6417 (Fcomposition_get_gstring): New forward static decl.
6418 * composite.h (Fcomposite_get_gstring): Remove decl.
6419 * dired.c (Ffile_attributes): New forward static decl.
6420 * doc.c (Fdocumntation_property): New forward static decl.
6421 * eval.c (Ffetch_bytecode): New forward static decl.
6422 (Funintern): Remove extern decl; now in .h file where it belongs.
6423 * fileio.c (Fmake_symbolic_link): New forward static decl.
6424 * image.c (Finit_image_library): New forward static decl.
6425 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6426 * intervals.h (Fprevious_property_change):
6427 (Fremove_list_of_text_properties): Remove decls.
6428 * keyboard.c (Fthis_command_keys): Remove decl.
6429 (Fcommand_execute): New forward static decl.
6430 * keymap.c (Flookup_key): New forward static decl.
6431 (Fcopy_keymap): Now static.
6432 * keymap.h (Flookup_key): Remove decl.
6433 * process.c (Fget_process): New forward static decl.
6434 (Fprocess_datagram_address): Mark as internal.
6435 * syntax.c (Fsyntax_table_p): New forward static decl.
6436 (skip_chars): Remove duplicate decl.
6437 * textprop.c (Fprevious_property_change): New forward static decl.
6438 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6439 Now internal.
6440 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6441 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6442
785bbd42
PE
6443 * editfns.c (Fformat): Remove unreachable code.
6444
8b913b57
AS
64452011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6446
6447 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6448 change. (Bug#8496)
6449
a6744a35
EZ
64502011-04-13 Eli Zaretskii <eliz@gnu.org>
6451
6452 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6453 when at ZV. (Bug#8487)
6454
e7974947
AS
64552011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6456
baad03f0
AS
6457 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6458 (Bug#8437)
6459 * keyboard.c (parse_tool_bar_item): Likewise.
6460 * sound.c (sound_cleanup, alsa_close): Likewise.
6461 * termcap.c (tgetent): Likewise.
6462 * xfns.c (x_default_font_parameter): Likewise.
6463 * xsettings.c (read_and_apply_settings): Likewise.
6464
e7974947
AS
6465 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6466 (overrun_check_free): Protoize.
6467
28272684
PE
64682011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6469
6470 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6471 since callers should never pass a negative size.
6472 Change the signature to match that of plain 'read' and 'write'; see
6473 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6474 * lisp.h: Update prototypes of emacs_write and emacs_read.
6475
11997c76
EZ
64762011-04-11 Eli Zaretskii <eliz@gnu.org>
6477
6478 * xdisp.c (redisplay_window): Don't try to determine the character
6479 position of the scroll margin if the window start point w->startp
e896f03c 6480 is outside the buffer's accessible region. (Bug#8468)
11997c76 6481
8a2cbd72
EZ
64822011-04-10 Eli Zaretskii <eliz@gnu.org>
6483
6484 Fix write-region and its subroutines for buffers > 2GB.
6485 * fileio.c (a_write, e_write): Modify declaration of arguments and
6486 local variables to support buffers larger than 2GB.
6487 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6488
6489 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6490 argument, local variables, and return value.
6491
6492 * lisp.h: Update prototypes of emacs_write and emacs_read.
6493
6494 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6495
4073e537 64962011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6497
1ebfdcb6
PE
6498 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6499
b2ded58d
PE
6500 Fix more problems found by GCC 4.6.0's static checks.
6501
7d66342c
PE
6502 * xdisp.c (vmessage): Use a better test for character truncation.
6503
bbf47d44
PE
6504 * charset.c (load_charset_map): <, not <=, for optimization,
6505 and to avoid potential problems with integer overflow.
9248994d 6506 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6507 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6508 * editfns.c (Fformat): Likewise.
1e69125e 6509 * syntax.c (skip_chars): Likewise.
3befa583 6510
e3019616
PE
6511 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6512 This also lets GCC 4.6.0 generate slightly better loop code.
6513
becfa255
PE
6514 * callint.c (Fcall_interactively): <, not <=, for optimization.
6515 (Fcall_interactively): Count the number of arguments produced,
6516 not the number of arguments given. This is simpler and lets GCC
6517 4.6.0 generate slightly better code.
6518
dae0cd48
PE
6519 * ftfont.c: Distingish more carefully between FcChar8 and char.
6520 The previous code passed unsigned char * to a functions like
6521 strlen and xstrcasecmp that expect char *, which does not
6522 conform to the C standard.
6523 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6524 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6525 char * when the C standard requires it.
6526
76032d70
PE
6527 * keyboard.c (read_char): Remove unused var.
6528
eb3f1cc8
PE
6529 * eval.c: Port to Windows vsnprintf (Bug#8435).
6530 Include <limits.h>.
6531 (SIZE_MAX): Define if the headers do not.
6532 (verror): Do not give up if vsnprintf returns a negative count.
6533 Instead, grow the buffer. This ports to Windows vsnprintf, which
6534 does not conform to C99. Problem reported by Eli Zaretskii.
6535 Also, simplify the allocation scheme, by avoiding the need for
6536 calling realloc, and removing the ALLOCATED variable.
6537
70476b54
PE
6538 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6539
12020a9e
PE
6540 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6541 But keep the doprint source code for now, as we might revamp it
6542 and use it again (Bug#8435).
ea6c7ae6
PE
6543 * lisp.h (doprnt): Remove.
6544 * Makefile.in (base_obj): Remove doprnt.o.
6545 * deps.mk (doprnt.o): Remove.
6546
5fdb398c
PE
6547 error: Print 32- and 64-bit integers portably (Bug#8435).
6548 Without this change, on typical 64-bit hosts error ("...%d...", N)
6549 was used to print both 32- and 64-bit integers N, which relied on
6550 undefined behavior.
6551 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6552 New macro.
6553 * lisp.h (error, verror): Mark as printf-like functions.
6554 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6555 Report overflow in size calculations when allocating printf buffer.
6556 Do not truncate output string at its first null byte.
6557 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6558 Truncate the output at a character boundary, since vsnprintf does not
6559 do that.
6560 * charset.c (check_iso_charset_parameter): Convert internal
6561 character to string before calling 'error', since %c now has the
6562 printf meaning.
6563 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6564 overflow when computing char to be passed to 'error'. Do not
6565 pass Lisp_Object to 'error'; pass the integer instead.
6566 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6567 formatted with plain %d.
6568
b189fa66
PE
6569 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6570
bff87ef0
PE
6571 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6572
7e2cac20
PE
6573 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6574
ce4d90b5
PE
6575 * xterm.c (x_catch_errors): Remove duplicate declaration.
6576
266c9547
PE
6577 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6578
79c49ad2
PE
6579 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6580
368f4090
JM
65812011-04-10 Jim Meyering <meyering@redhat.com>
6582
6583 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6584 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6585 return ssize_t not "int", and use size_t as the buffer length.
6586 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6587 * gnutls.h: Update declarations.
6588 * process.c (read_process_output): Use ssize_t, to match.
6589 (send_process): Likewise.
6590
a32d4040
CY
65912011-04-09 Chong Yidong <cyd@stupidchicken.com>
6592
6593 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6594
8546720e 65952011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6596
04f2d78b
CB
6597 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6598 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6599
8546720e
GM
6600 * xterm.c (handle_one_xevent):
6601 * xmenu.c (create_and_show_popup_menu):
6602 * xselect.c (x_decline_selection_request)
6603 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6604
0a2f5c1a 66052011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6606
6607 Fix some uses of `int' instead of EMACS_INT.
6608 * search.c (string_match_1, fast_string_match)
6609 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6610 (scan_buffer, find_next_newline_no_quit)
6611 (find_before_next_newline, search_command, Freplace_match)
6612 (Fmatch_data): Make some `int' variables be EMACS_INT.
6613
6614 * xdisp.c (display_count_lines): 3rd argument and return value now
6615 EMACS_INT. All callers changed.
6616 (pint2hrstr): Last argument is now EMACS_INT.
6617
6618 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6619 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6620 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6621 (decode_coding_utf_16, decode_coding_emacs_mule)
6622 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6623 (decode_coding_ccl, decode_coding_charset)
6624 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6625 (decode_coding_iso_2022, decode_coding_emacs_mule)
6626 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6627 <char_offset, last_offset>: Declare EMACS_INT.
6628 (encode_coding_utf_8, encode_coding_utf_16)
6629 (encode_coding_emacs_mule, encode_invocation_designation)
6630 (encode_designation_at_bol, encode_coding_iso_2022)
6631 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6632 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6633 Declare EMACS_INT.
6634 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6635 (encode_invocation_designation): Last argument P_NCHARS is now
6636 EMACS_INT.
6637 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6638 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6639
6640 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6641 All users changed.
6642
6643 * ccl.c (Fccl_execute_on_string): Declare some variables
6644 EMACS_INT.
6645
8546720e 66462011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6647
6648 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6649
4e19a977
CS
66502011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6651
6652 * process.c (Fformat_network_address): Doc fix.
6653
87302331
R
66542011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6655
6656 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6657
cbb59342
CY
66582011-04-08 Chong Yidong <cyd@stupidchicken.com>
6659
6660 * keyboard.c (read_char): Call Lisp function help-form-show,
6661 instead of using internal_with_output_to_temp_buffer.
6662 (Qhelp_form_show): New var.
e0d38eeb 6663 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6664
6665 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6666
6667 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6668
e67a13ab
CY
66692011-04-06 Chong Yidong <cyd@stupidchicken.com>
6670
04f2d78b
CB
6671 * process.c (Flist_processes): Remove to Lisp.
6672 (list_processes_1): Delete.
e67a13ab 6673
973f782d
EZ
66742011-04-06 Eli Zaretskii <eliz@gnu.org>
6675
7c106b1e
EZ
6676 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6677
973f782d
EZ
6678 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6679
41cf7d1a 66802011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6681
ca23cc88
PE
6682 Fix more problems found by GCC 4.6.0's static checks.
6683
f390e2d5
PE
6684 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6685
42eea0d0
PE
6686 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6687
b69769da 6688 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6689
f9541e84
PE
6690 * xdisp.c (vmessage): Mark as a printf-like function.
6691
13841b55
PE
6692 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6693
c136c10f
PE
6694 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6695
5e2d4a30
PE
6696 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6697 printf-like functions.
6698 (tiff_load): Add casts to remove these marks before passing them
6699 to system-supplied API.
6700
583f48b9
PE
6701 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6702
b25d760e
PE
6703 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6704 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6705 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6706 directly, rather than having caller test rule sign. This avoids
6707 some unnecessary tests.
6708 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6709 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6710 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6711
bc7b6697 6712 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6713 (xfont_open): Avoid unnecessary tests.
bc7b6697 6714
27ccc379
PE
6715 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6716
dcd5c89a
PE
6717 * composite.h, composite.c (composition_gstring_put_cache):
6718 Use EMACS_INT, not int, for length.
6719
b13a45c6
PE
6720 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6721 breaking out part of COMPOSITION_DECODE_RULE.
6722 (COMPOSITION_DECODE_RULE): Use it.
6723 * composite.c (get_composition_id): Remove unused local vars,
6724 by using the new macro.
6725
1e792e4d
PE
6726 * textprop.c (set_text_properties_1): Change while to do-while,
6727 since the condition is always true at first.
6728
dc6c6455 6729 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6730 (interval_deletion_adjustment): Return unsigned value.
6731 All uses changed.
dc6c6455 6732
aba7731a
PE
6733 * process.c (list_processes_1, create_pty, read_process_output):
6734 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6735 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6736 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6737 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6738 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6739
fdfc4bf3
PE
6740 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6741
fca8fe46 6742 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6743 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6744
06a0259a 6745 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6746 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6747 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6748
e7b9e80f
PE
6749 * print.c (print_error_message): Avoid int overflow.
6750
56201685
PE
6751 * font.c (font_list_entities): Redo for clarity,
6752 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6753
78834453 6754 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6755 (font_score): Avoid potential overflow in diff calculation.
78834453 6756
0bc0b309 6757 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6758 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6759
e610eaca
PE
6760 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6761
b895abce
PE
6762 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6763 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6764 can always succeed if overflow has undefined behavior.
6765
1f1d9321 6766 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6767 (wordify): Omit three unnecessary tests.
1f1d9321 6768
c59478bc
PE
6769 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6770 All callers changed. This avoids the need for an unused var.
6771
79b73827
PE
6772 * casefiddle.c (casify_region): Remove var that is set but not used.
6773
a4db5dfe
PE
6774 * dired.c (file_name_completion): Remove var that is set but not used.
6775
43aae36e
PE
6776 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6777
2a47c44d 6778 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6779 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6780
a37c69bf
PE
6781 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6782 Check for integer overflow on size calculations.
6783
328ab8e7
PE
6784 * buffer.c (Fprevious_overlay_change): Remove var that is set
6785 but not used.
6786
e5a2a5cb
PE
6787 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6788 Remove vars that are set but not used.
8d84a6eb 6789 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6790 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6791
a60e5f68
PE
6792 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6793
f661cb61 6794 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6795 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6796
f0397f5a
PE
6797 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6798 that are set but not used.
6799
8664db06 6800 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6801 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6802
6abdaa4a
PE
6803 * xselect.c (x_get_local_selection, x_handle_property_notify):
6804 Remove vars that are set but not used.
6805
0ce7538d 6806 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6807 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6808
9ae848fc
PE
6809 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6810 Remove var that is set but not used.
0b918413
PE
6811 (scroll_bar_windows_size): Now size_t, not int.
6812 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6813 Check for overflow.
9ae848fc 6814
a5a62657
PE
6815 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6816 (map_tty_color) [!defined MSDOS]: Likewise.
6817
5c5cdd39
PE
6818 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6819
66ebf983
PE
6820 * coding.c: Remove vars that are set but not used.
6821 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6822 All callers changed.
6823 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6824 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6825 (decode_coding_charset): Remove vars that are set but not used.
6826
1be4d761
PE
6827 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6828 that is set but not used.
6829
47553fa8
PE
6830 * print.c (print_object): Remove var that is set but not used.
6831
1f7196bf 6832 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6833 The gnulib version avoids calling malloc in the usual case,
6834 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6835 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6836 * filelock.c (current_lock_owner): Likewise.
6837 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6838 * sysdep.c: Include allocator.h, careadlinkat.h.
6839 (emacs_no_realloc_allocator): New static constant.
6840 (emacs_readlink): New function.
fdb61804
PE
6841 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6842 ../lib/careadlinkat.h.
d1fdcab7 6843
f84c17c7
SM
68442011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6845
6846 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6847 first non-nil return value).
6848
ef3862ad
JD
68492011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6850
6851 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6852 if not defined (Bug#8403).
6853
376a7006
JB
68542011-04-02 Juanma Barranquero <lekktu@gmail.com>
6855
6856 * xdisp.c (display_count_lines): Remove parameter `start',
6857 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6858 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6859 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6860 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6861 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6862 and thereabouts. All callers changed.
6863 (get_per_char_metric): Remove parameter `f', unused since
6864 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6865
6ca3801d
JM
68662011-04-02 Jim Meyering <meyering@redhat.com>
6867
6868 do not dereference NULL upon failed strdup
6869 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6870 (ns_get_family): Likewise.
6871
d8e2b5ba
JB
68722011-04-02 Juanma Barranquero <lekktu@gmail.com>
6873
6874 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6875
8c74fcbd
JD
68762011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6877
6878 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6879 later (Bug#8403).
6880
7200d79c
SM
68812011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6882
03408648 6883 Add lexical binding.
7200d79c 6884
03408648
SM
6885 * window.c (Ftemp_output_buffer_show): New fun.
6886 (Fsave_window_excursion):
6887 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6888
6889 * lread.c (lisp_file_lexically_bound_p): New function.
6890 (Fload): Bind Qlexical_binding.
6891 (readevalloop): Remove `evalfun' arg.
6892 Bind Qinternal_interpreter_environment.
6893 (Feval_buffer): Bind Qlexical_binding.
6894 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6895 Mark as dynamic.
6896 (syms_of_lread): Declare `lexical-binding'.
6897
6898 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6899
6900 * keyboard.c (eval_dyn): New fun.
6901 (menu_item_eval_property): Use it.
ca105506
SM
6902
6903 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6904
03408648
SM
6905 * fns.c (concat, mapcar1): Accept byte-code-functions.
6906
6907 * eval.c (Fsetq): Handle lexical vars.
6908 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6909 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6910 (FletX, Flet): Obey lexical binding.
6911 (Fcommandp): Handle closures.
6912 (Feval): New `lexical' arg.
6913 (eval_sub): New function extracted from Feval. Use it almost
6914 everywhere where Feval was used. Look up vars in lexical env.
6915 Handle closures.
6916 (Ffunctionp): Move from subr.el.
6917 (Ffuncall): Handle closures.
6918 (apply_lambda): Remove `eval_flags'.
6919 (funcall_lambda): Handle closures and new byte-code-functions.
6920 (Fspecial_variable_p): New function.
6921 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6922 but without exporting it to Lisp.
23aba0ea 6923
23aba0ea 6924 * doc.c (Fdocumentation, store_function_docstring):
03408648 6925 * data.c (Finteractive_form): Handle closures.
23aba0ea 6926
03408648
SM
6927 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6928 interactive spec.
ba83908c 6929
04f2d78b
CB
6930 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6931 New byte-codes.
03408648
SM
6932 (exec_byte_code): New function extracted from Fbyte_code to handle new
6933 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6934
03408648 6935 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6936
03408648 6937 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6938
e2abce01
JB
69392011-03-31 Juanma Barranquero <lekktu@gmail.com>
6940
6941 * xdisp.c (redisplay_internal): Fix prototype.
6942
63696a73 69432011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6944
63696a73 6945 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6946 (try_scrolling): Use it when setting scroll_limit.
6947 Limit scrolling to 100 screen lines.
63696a73
EZ
6948 (redisplay_window): Even when falling back on "recentering",
6949 position point in the window according to scroll-conservatively,
6950 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6951
6952 (try_scrolling): When point is above the window, allow searching
6953 as far as scroll_max, or one screenful, to compute vertical
6954 distance from PT to the scroll margin position. This prevents
6955 try_scrolling from unnecessarily failing when
6956 scroll-conservatively is set to a value slightly larger than the
6957 window height. Clean up the case of PT below the margin at bottom
6958 of window: scroll_max can no longer be INT_MAX. When aggressive
6959 scrolling is in use, don't let point enter the opposite scroll
6960 margin as result of the scroll.
6961 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6962 threshold of 100 lines for never-recentering scrolling.
6963
e4cc2dfc
JB
69642011-03-31 Juanma Barranquero <lekktu@gmail.com>
6965
6966 * dispextern.h (move_it_by_lines):
6967 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6968 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6969 (message_log_check_duplicate): Remove parameters `prev_bol' and
6970 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6971 (redisplay_internal): Remove parameter `preserve_echo_area',
6972 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6973
6974 * indent.c (Fvertical_motion):
6975 * window.c (window_scroll_pixel_based, Frecenter):
6976 Don't pass `need_y_p' to `move_it_by_lines'.
6977
1c470562
SM
69782011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6979
44f230aa
SM
6980 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6981 steal a few bits to be more compact.
6982 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6983 Remove unneeded casts.
6984
1c470562
SM
6985 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6986
888adce9
ZK
69872011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6988
6989 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6990 binding" message (bug#7967).
6991
f838ed7b
PE
69922011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6993
77861b95
PE
6994 Fix more problems found by GCC 4.6.0's static checks.
6995
de6dbc14
PE
6996 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6997 Remove unused local var.
6998
f838ed7b
PE
6999 * editfns.c (Fmessage_box): Remove unused local var.
7000
792c7b2b
PE
7001 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7002 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7003 Omit unused local vars.
c499e557 7004 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7005 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7006 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7007 Omit unused local var.
7008
ba0165e1
PE
7009 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7010 Don't assume string length fits in int.
32ad8845 7011 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7012 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7013
3c59b4c9
PE
7014 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7015 instead of alloca (Bug#8344).
7016
a3eed478 7017 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7018 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7019
eb4d412d
PE
7020 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7021
1658b401
PE
7022 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7023 concerns.
7024
7025 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7026
7027 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7028
9a2c6e05
PE
7029 * keyboard.c (syms_of_keyboard): Use the same style as later
7030 in this function when indexing through an array. This also
7031 works around GCC bug 48267.
7032
03d0a109
PE
7033 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7034
44f730c8
PE
7035 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7036
fe75f926
PE
7037 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7038 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7039
ffa8c828
PE
7040 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7041 This avoids undefined behavior on integer overflow, and is a bit
7042 more convenient anyway since it is compared to a size_t variable.
7043
c5101a77
PE
7044 Variadic C functions now count arguments with size_t, not int.
7045 This avoids an unnecessary limitation on 64-bit machines, which
7046 caused (substring ...) to crash on large vectors (Bug#8344).
7047 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7048 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7049 All variadic functions and their callers changed accordingly.
c5101a77
PE
7050 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7051 * data.c (arith_driver, float_arith_driver): Likewise.
7052 * editfns.c (general_insert_function): Likewise.
7053 * eval.c (struct backtrace.nargs, interactive_p)
7054 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7055 (funcall_lambda, mark_backtrace): Likewise.
7056 * fns.c (concat): Likewise.
7057 * frame.c (x_set_frame_parameters): Likewise.
7058 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7059 0 if not found, not -1. All callers changed.
7060
dd3f25f7
PE
7061 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7062 (stack_copy_size): Now size_t, not int.
7063 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7064
461c2ab9
JB
70652011-03-28 Juanma Barranquero <lekktu@gmail.com>
7066
7067 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7068 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7069 All callers changed.
7070
7071 * lisp.h (multibyte_char_to_unibyte):
7072 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7073 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7074 * character.h (CHAR_TO_BYTE8):
7075 * cmds.c (internal_self_insert):
7076 * editfns.c (general_insert_function):
7077 * keymap.c (push_key_description):
7078 * search.c (Freplace_match):
7079 * xdisp.c (message_dolog, set_message_1): All callers changed.
7080
f6d62986
SM
70812011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7082
7083 * keyboard.c (safe_run_hook_funcall): New function.
7084 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7085 don't set the hook to nil, but remove the offending function instead.
7086 (Qcommand_hook_internal): Remove, unused.
7087 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7088 Vcommand_hook_internal.
7089
7090 * eval.c (enum run_hooks_condition): Remove.
7091 (funcall_nil, funcall_not): New functions.
7092 (run_hook_with_args): Call each function through a `funcall' argument.
7093 Remove `cond' argument, now redundant.
7094 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7095 (Frun_hook_with_args_until_failure): Adjust accordingly.
7096 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7097
1db5b1ad
JB
70982011-03-28 Juanma Barranquero <lekktu@gmail.com>
7099
7100 * dispextern.h (string_buffer_position): Remove declaration.
7101
7102 * print.c (strout): Remove parameter `multibyte', unused since
7103 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7104
7105 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7106 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7107 All callers changed.
7108
7109 * w32.c (_wsa_errlist): Use braces for struct initializers.
7110
7111 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7112 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7113 All callers changed.
7114 (string_buffer_position): Likewise. Also, make static (it's never
7115 used outside xdisp.c).
7116 (cursor_row_p): Remove parameter `w', unused since
7117 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7118 (decode_mode_spec): Remove parameter `precision', introduced during
7119 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7120 All callers changed.
7121
5ffb62aa
JD
71222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7123
7124 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7125
461c2ab9 71262011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7127
7128 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7129 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7130 (ns_update_auto_hide_menu_bar): New functions.
7131 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7132 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7133 ns_constrain_all_frames.
7134 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7135 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7136
5c380ffb
JD
71372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7138
7139 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7140
9af30bdf
GM
71412011-03-27 Glenn Morris <rgm@gnu.org>
7142
7143 * syssignal.h: Replace RETSIGTYPE with void.
7144 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7145 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7146 Replace SIGTYPE with void everywhere.
7147 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7148 * s/template.h (SIGTYPE): Remove commented out definition.
7149
e2abce01
JB
71502011-03-26 Eli Zaretskii <eliz@gnu.org>
7151
7152 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7153 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7154
f868cd8a
JB
71552011-03-26 Juanma Barranquero <lekktu@gmail.com>
7156
59eb0929
JB
7157 * w32.c (read_unc_volume): Use parameter `henum', instead of
7158 global variable `wget_enum_handle'.
7159
7160 * keymap.c (describe_vector): Remove parameters `indices' and
7161 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7162 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7163
f868cd8a
JB
7164 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7165
7166 * keyboard.c (timer_check): Remove parameter `do_it_now',
7167 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7168 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7169 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7170
7171 * keyboard.c (read_char):
7172 * w32menu.c (w32_menu_display_help):
7173 * xmenu.c (show_help_event, menu_help_callback):
7174 Adjust calls to `show_help_echo'.
7175
7176 * gtkutil.c (xg_maybe_add_timer):
7177 * keyboard.c (readable_events):
7178 * process.c (wait_reading_process_output):
7179 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7180
7181 * insdel.c (adjust_markers_gap_motion):
7182 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7183 (gap_left, gap_right): Don't call it.
7184
2ecf6fdb
CY
71852011-03-25 Chong Yidong <cyd@stupidchicken.com>
7186
7187 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7188 incurred during fontification.
7189
6b1f9ba4
JB
71902011-03-25 Juanma Barranquero <lekktu@gmail.com>
7191
7192 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7193 (DEFVAR_PER_BUFFER): Don't pass it.
7194
7195 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7196 (scrolling_window): Don't pass it.
7197
0f4a96b5
JB
71982011-03-25 Juanma Barranquero <lekktu@gmail.com>
7199
7200 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7201
7202 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7203 and `suffix'.
7204 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7205 of variables specific to SELinux and computation of `encoded_absname'.
7206
7207 * image.c (XPutPixel): Remove unused variable `height'.
7208
7209 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7210
7211 * unexw32.c (get_section_info): Remove unused variable `section'.
7212
7213 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7214 (system_process_attributes): Remove unused variable `sess'.
7215 (sys_read): Remove unused variable `err'.
7216
7217 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7218 (w32_wnd_proc): Remove unused variable `isdead'.
7219 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7220 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7221 (x_create_tip_frame): Remove unused variable `tem'.
7222
7223 * w32inevt.c (w32_console_read_socket):
7224 Remove unused variable `no_events'.
7225
7226 * w32term.c (x_draw_composite_glyph_string_foreground):
7227 Remove unused variable `width'.
7228
1149507c
JB
72292011-03-24 Juanma Barranquero <lekktu@gmail.com>
7230
7231 * w32term.c (x_set_glyph_string_clipping):
7232 Don't pass uninitialized region to CombineRgn.
7233
9c88f339
JB
72342011-03-23 Juanma Barranquero <lekktu@gmail.com>
7235
7236 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7237 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7238 (Fx_close_connection): Remove unused variable `i'.
7239
7240 * w32font.c (w32font_draw): Return number of glyphs.
7241 (w32font_open_internal): Remove unused variable `i'.
7242 (w32font_driver): Add missing initializer.
7243
7244 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7245 (fill_in_menu): Remove unused variable `items_added'.
7246
7247 * w32term.c (last_mouse_press_frame): Remove static global variable.
7248 (w32_clip_to_row): Remove unused variable `f'.
7249 (x_delete_terminal): Remove unused variable `i'.
7250
7251 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7252 (NOTHING): Remove unused static global variable.
7253 (uniscribe_check_otf): Remove unused variable `table'.
7254 (uniscribe_font_driver): Add missing initializers.
7255
dee091a3
JD
72562011-03-23 Julien Danjou <julien@danjou.info>
7257
7258 * term.c (Fsuspend_tty, Fresume_tty):
7259 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7260 * window.c (temp_output_buffer_show):
7261 * insdel.c (signal_before_change):
7262 * frame.c (Fhandle_switch_frame):
7263 * fileio.c (Fdo_auto_save):
7264 * emacs.c (Fkill_emacs):
7265 * editfns.c (save_excursion_restore):
7266 * cmds.c (internal_self_insert):
7267 * callint.c (Fcall_interactively):
7268 * buffer.c (Fkill_all_local_variables):
7269 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7270 Use Frun_hooks.
0f4a96b5 7271 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7272 unconditionnaly since it does the check itself.
7273
2c520ab5 72742011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7275
c9c49752
PE
7276 Fix more problems found by GCC 4.5.2's static checks.
7277
8abc3f12
PE
7278 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7279 the first time through the loop, since we know p0 < p1 then.
7280 This also avoids a gcc -Wstrict-overflow warning.
7281
a2d26660
PE
7282 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7283 leading to a memory leak, possible in functions like
7284 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7285 of objects (Bug#8318).
a2d26660 7286
916c72e9
PE
7287 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7288 that could (at least in theory) be that large.
7289
19ab8a18
PE
7290 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7291 This is less likely to overflow, and avoids undefined behavior if
7292 overflow does occur. All callers changed. Use strtoul to scan
7293 for the unsigned long integer.
b7cbbd6f
PE
7294 (pint2hrstr): Simplify and tune code slightly.
7295 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7296
f0641eff
PE
7297 * scroll.c (do_scrolling): Work around GCC bug 48228.
7298 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7299
7f650bb9
PE
7300 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7301 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7302 (validate_x_resource_name): Simplify count usage.
7303 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7304
37dd57d1
PE
7305 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7306 fail (Bug#8306).
81e56e61 7307
699979fc 7308 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7309
401bf9b4
PE
7310 * process.c (Fmake_network_process): Use socklen_t, not int,
7311 where POSIX says socklen_t is required in portable programs.
7312 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7313 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7314 (Fmake_network_process, server_accept_connection):
7315 (wait_reading_process_output, read_process_output):
7316 Likewise.
7317
b93aacde
PE
7318 * process.c: Rename or move locals to avoid shadowing.
7319 (list_processes_1, Fmake_network_process):
7320 (read_process_output_error_handler, exec_sentinel_error_handler):
7321 Rename or move locals.
4dc343ee 7322 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7323 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7324 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7325 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7326 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7327
af8a867c 7328 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7329 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7330 Include tparam.h instead, since it declares them.
af8a867c
PE
7331 * cm.h (PC): Remove extern decl; tparam.h now does this.
7332 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7333 * terminfo.c: Include tparam.h, to check interfaces.
7334 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7335 (tparam): Adjust signature to match interface in tparam.h;
7336 this removes some undefined behavior. Check that outstring and len
7337 are zero, which they always are with Emacs.
7338 * tparam.h (PC, BC, UP): New extern decls.
7339
0248044d 7340 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7341 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7342
8ff096c1 7343 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7344 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7345 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7346 (ftfont_list): Remove unused local.
49eaafba
PE
7347 (get_adstyle_property, ftfont_pattern_entity):
7348 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7349 Rename locals to avoid shadowing.
8ff096c1 7350
e2be39f6
PE
7351 * xfont.c (xfont_list_family): Mark var as initialized.
7352
c9735e30
PE
7353 * xml.c (make_dom): Now static.
7354
8f5201ae
PE
7355 * composite.c (composition_compute_stop_pos): Rename local to
7356 avoid shadowing.
b246f932
PE
7357 (composition_reseat_it): Remove unused locals.
7358 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7359 (composition_update_it): Mark var as initialized.
11b61122
PE
7360 (find_automatic_composition): Mark vars as initialized,
7361 with a FIXME (Bug#8290).
8f5201ae 7362
760fbc2c
PE
7363 character.h: Rename locals to avoid shadowing.
7364 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7365 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7366 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7367 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7368 to avoid shadowing.
7369
ff08eb85
PE
7370 * textprop.c (property_change_between_p): Remove; unused.
7371
fc7bf025
PE
7372 * intervals.c (interval_start_pos): Now static.
7373
235d7abc
PE
7374 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7375
44f230aa
SM
7376 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7377 Rename locals to avoid shadowing.
3e7d6594 7378
50060332
PE
7379 * sound.c (wav_play, au_play, Fplay_sound_internal):
7380 Fix pointer signedness.
d01f234b 7381 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7382 (wav_play): Initialize a variable to 0, to prevent undefined
7383 behavior (Bug#8278).
50060332 7384
c4fc4e30
PE
7385 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7386
918436ed
PE
7387 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7388
c939f91b
PE
7389 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7390 clobbering (Bug#8298).
b9c7f648
PE
7391 * sysdep.c (sys_subshell): Likewise.
7392 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7393
6bd8c144
PE
7394 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7395 This should get cleaned up, so that child_setup has the
7396 same signature on all platforms.
7397
7710357c 7398 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7399 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7400
c59da222
CY
74012011-03-22 Chong Yidong <cyd@stupidchicken.com>
7402
7403 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7404 not to be necessary, and produces flickering.
7405
66b87493
GM
74062011-03-20 Glenn Morris <rgm@gnu.org>
7407
7408 * config.in: Remove file.
7409
45b6f6d5
JB
74102011-03-20 Juanma Barranquero <lekktu@gmail.com>
7411
7412 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7413 are now in src/globals.h.
7414 (syms_of_minibuf): Remove spurious & from previous change.
7415
3ec03f7e
LL
74162011-03-20 Leo <sdl.web@gmail.com>
7417
7418 * minibuf.c (completing-read-function): New variable.
7419 (completing-read-default): Rename from completing-read.
7420 (completing-read): Call completing-read-function.
7421
b14e3e21
CY
74222011-03-19 Juanma Barranquero <lekktu@gmail.com>
7423
7424 * xfaces.c (Fx_load_color_file):
7425 Read color file from absolute filename (bug#8250).
7426
f2b726e6
JB
74272011-03-19 Juanma Barranquero <lekktu@gmail.com>
7428
7429 * makefile.w32-in: Update dependencies.
7430
09f6ff02
EZ
74312011-03-17 Eli Zaretskii <eliz@gnu.org>
7432
7433 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7434
29a6015a
PE
74352011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7436
a3a6c54e
PE
7437 Fix more problems found by GCC 4.5.2's static checks.
7438
b766f867
PE
7439 * process.c (make_serial_process_unwind, send_process_trap):
7440 (sigchld_handler): Now static.
7441
be02381c
PE
7442 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7443 That way, the code declares only the vars that it needs.
7444 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7445 * s/cygwin.h (PTY_ITERATION): Likewise.
7446 * s/darwin.h (PTY_ITERATION): Likewise.
7447 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7448
57048744
PE
7449 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7450 * process.c (allocate_pty): Don't declare stb unless it's needed.
7451
7914961c 7452 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7453 (CONSTANTLIM): Remove; unused.
7454 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7455 Define only if needed.
7914961c 7456
b3967b18
PE
7457 * unexelf.c (unexec): Name an expression,
7458 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7459 Use a different way to cause a compilation error if anyone uses
7460 n rather than nn, a way that does not involve shadowing.
73366a00 7461 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7462
29a6015a
PE
7463 * deps.mk (unexalpha.o): Remove; unused.
7464
43cfc33e 7465 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7466 * unexec.h: New file.
ce701a33
PE
7467 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7468 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7469 Depend on unexec.h.
7470 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7471 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7472 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7473 Change as necessary to match prototype in unexec.h.
ce701a33 7474
01f44d5a
PE
7475 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7476 shadowing.
4f63c6bb 7477 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7478
a6670b0b
PE
7479 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7480 Rename locals to avoid shadowing.
7481
cef2010d 7482 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7483 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7484
d4d7173a
PE
7485 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7486
f08b802a
PE
7487 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7488 warning when compiling print.c.
7489
3ddb0639
PE
7490 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7491 instead of using an uninitialized var.
5ad03b97 7492 (font_sort_entities): Mark var as initialized.
3ddb0639 7493
170a2692
PE
7494 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7495
e663c700
PE
7496 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7497 pointers to constants.
89bc529a 7498 (font_parse_fcname): Remove unused vars.
7b81e2d0 7499 (font_delete_unmatched): Now static.
ea838e10 7500 (font_get_spec): Remove; unused.
13a547c6
PE
7501 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7502 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7503 Rename or move locals to avoid shadowing.
e663c700 7504
2a80c887 7505 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7506 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7507
1384fa33 7508 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7509 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7510
8b2c52e9
PE
7511 * alloc.c (mark_backtrace): Move decl from here ...
7512 * lisp.h: ... to here, so that it can be checked.
7513
475545b5 7514 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7515 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7516 (lisp_indirect_variable): Name an expression,
7517 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7518 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7519
b1349114 7520 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7521 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7522 Use const pointer when appropriate.
b1349114 7523
a2928364
PE
7524 * lisp.h (get_system_name, get_operating_system_release):
7525 Move decls here, to check interfaces.
7526 * process.c (get_operating_system_release): Move decl to lisp.h.
7527 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7528 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7529 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7530 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7531 (Fformat_time_string, Fencode_time, Finsert_char):
7532 (Ftranslate_region_internal, Fformat):
7533 Rename or remove local vars to avoid shadowing.
9710023e 7534 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7535
a415e694
PE
7536 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7537 avoid shadowing.
7538
8ef4622d
PE
7539 * lisp.h (eassert): Check that the argument compiles, even if
7540 ENABLE_CHECKING is not defined.
7541
946f9a5b
PE
7542 * data.c (Findirect_variable): Name an expression, to avoid
7543 gcc -Wbad-function-cast warning.
112396d6 7544 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7545 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7546 (Fmake_variable_buffer_local, Fmake_local_variable):
7547 Mark variables as initialized.
52746918 7548 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7549
e5aab7e7 7550 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7551 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7552 Rename locals to avoid shadowing.
dff45157
PE
7553 (mark_stack): Move local variables into the #ifdef region where
7554 they're used.
7bc26fdb
PE
7555 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7556 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7557 needed otherwise.
7558 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7559 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7560 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7561
e5aab7e7
PE
7562 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7563 avoids undefined behavior in theory.
7564
4da60324
PE
7565 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7566
88043301
PE
7567 Use functions, not macros, for up- and down-casing (Bug#8254).
7568 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7569 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7570 to use the following functions instead of these macros.
7571 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7572 EMACS_INT, since callers assume the returned value fits in int.
7573 (upcase1): Likewise, for UPCASE_TABLE.
7574 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7575 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7576 the race-condition problem in the old DOWNCASE.
88043301 7577
19ed5445
PE
7578 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7579 Rename locals to avoid shadowing.
7580 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7581 (regex_compile, re_search_2, re_match_2_internal):
7582 Remove unused local vars.
952db0d7
PE
7583 (FREE_VAR): Rewrite so as not to use empty "else",
7584 which gcc can warn about.
da053e48 7585 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7586 (RETALLOC_IF): Define only if needed.
7587 (WORDCHAR_P): Likewise. This one is never needed, but is used
7588 only in a comment talking about a compiler bug, so put inside
7589 the #if 0 of that comment.
7590 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7591 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7592 Remove; unused.
19ed5445 7593
1f3561e4 7594 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7595 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7596 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7597
ded6f8f7
PE
7598 * search.c (simple_search): Remove unused var.
7599
dbd37a95
PE
7600 * dired.c (compile_pattern): Move decl from here ...
7601 * lisp.h: ... to here, so that it can be checked.
7602 (struct re_registers): New forward decl.
7603
7e47afad
PE
7604 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7605
85f24f61
PE
7606 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7607 All uses changed.
7608 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7609 Rename locals to avoid shadowing.
5671df8f 7610 (Fvertical_motion): Mark locals as initialized.
85f24f61 7611
181aa2be 7612 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7613 (casify_region): Mark local as initialized.
181aa2be 7614
930d429c
PE
7615 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7616
7082eac6
PE
7617 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7618 New macros, so that the caller can use some names other than
7619 gcpro1, gcpro2, etc.
7620 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7621 of the new macros.
7622 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7623 argument, for consistency with GCPRO2_VAR, etc: it is now the
7624 prefix of the variable, not the variable itself. All uses
7625 changed.
38b2c076
PE
7626 * dired.c (directory_files_internal, file_name_completion):
7627 Rename locals to avoid shadowing.
7628
15206ed9
PE
7629 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7630 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7631 dired.c's scmp function, had undefined behavior.
7632 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7633 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7634 * buffer.h: ... to here, because these macros use current_buffer,
7635 and the new implementation with inline functions needs to have
7636 current_buffer in scope now, rather than later when the macros
7637 are used.
7638 (downcase, upcase1): New static inline functions.
7639 (DOWNCASE, UPCASE1): Reimplement using these functions.
7640 This avoids undefined behavior in expressions like
7641 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7642 from race conditions in accessing the global variables
7643 case_temp1 and case_temp2.
7644 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7645 * lisp.h (case_temp1, case_temp2): Remove their decls.
7646 * character.h (ASCII_CHAR_P): Move from here ...
7647 * lisp.h: ... to here, so that the inline functions mentioned
7648 above can use them.
7649
4a6bea26
PE
7650 * dired.c (directory_files_internal_unwind): Now static.
7651
f14b7e14
PE
7652 * fileio.c (file_name_as_directory, directory_file_name):
7653 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7654 Now static.
2893f146
PE
7655 (file_name_as_directory): Use const pointers when appropriate.
7656 (Fexpand_file_name): Likewise. In particular, newdir might
7657 point at constant storage, so make it a const pointer.
fd4ead52 7658 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7659 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7660 signedness issues.
f839df0c
PE
7661 (Fset_file_times, Finsert_file_contents, auto_save_error):
7662 Rename locals to avoid shadowing.
f14b7e14 7663
5716756e 7664 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7665 (Ftry_completion, Fall_completions): Rename or remove locals
7666 to avoid shadowing.
5716756e 7667
b4c3046a
PE
7668 * marker.c (bytepos_to_charpos): Remove; unused.
7669
b45db522
PE
7670 * lisp.h (verify_bytepos, count_markers): New decls,
7671 so that gcc does not warn that these functions aren't declared.
7672
85876d07
PE
7673 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7674 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7675 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7676 (copy_text): Remove unused local var.
85876d07 7677
03d78a21 7678 * filelock.c (within_one_second): Now static.
b3dd38ab 7679 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7680
5df8f01b
PE
7681 * buffer.c (fix_overlays_before): Mark locals as initialized.
7682 (fix_start_end_in_overlays): Likewise. This function should be
7683 simplified by using pointers-to-pointers, but that's a different
7684 matter.
b1d876f1 7685 (switch_to_buffer_1): Now static.
8f54f30a
PE
7686 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7687 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7688
a70072c9 7689 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7690 Fix pointer signedness issue.
edced198
PE
7691 (sys_subshell): Mark local as volatile if checking for lint,
7692 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7693 (MAXPATHLEN): Define only if needed.
a70072c9 7694
a0977c44
PE
7695 * process.c (serial_open, serial_configure): Move decls from here ...
7696 * systty.h: ... to here, so that they can be checked.
7697
a884fdcc
PE
7698 * fns.c (get_random, seed_random): Move extern decls from here ...
7699 * lisp.h: ... to here, so that they can be checked.
7700
604efe86 7701 * sysdep.c (reset_io): Now static.
b8950c94 7702 (wait_for_termination_signal): Remove; unused.
604efe86 7703
38fc62d9
PE
7704 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7705 (copy_keymap_item, append_key, push_text_char_description):
7706 Now static.
1004a21a 7707 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7708 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7709 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7710 (describe_map_tree):
7711 Rename locals to avoid shadowing.
38fc62d9 7712
2f2650da
PE
7713 * keyboard.c: Declare functions static if they are not used elsewhere.
7714 (echo_char, echo_dash, cmd_error, top_level_2):
7715 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7716 (read_char, kbd_buffer_get_event, make_lispy_position):
7717 (make_lispy_event, make_lispy_movement, apply_modifiers):
7718 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7719 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7720 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7721 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7722 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7723
a053e86c 7724 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7725 (mark_kboards): Move decl here ...
7726 * alloc.c (mark_kboards): ... from here.
a053e86c 7727
4752793e
PE
7728 * lisp.h (force_auto_save_soon): New decl.
7729
74f10ca7 7730 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7731 (DEFINE_DUMMY_FUNCTION): New macro.
7732 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7733 Use it.
c03cd23f
PE
7734 (main): Add casts to avoid warnings
7735 if GCC considers string literals to be constants.
74f10ca7 7736
022e70d4
PE
7737 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7738
59d6fe83
PE
7739 * dbusbind.c: Pointer signedness fixes.
7740 (xd_signature, xd_append_arg, xd_initialize):
7741 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7742 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7743 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7744 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7745
78320123
PE
7746 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7747 if GCC considers string literals to be constants.
49cebcca 7748 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7749
35ac2a97
SM
77502011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7751
fb103ca9
SM
7752 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7753 (print_preprocess, print_object): New macro to fix last change.
7754
35ac2a97
SM
7755 * print.c (print_preprocess): Don't forget font objects.
7756
62973b41
JB
77572011-03-16 Juanma Barranquero <lekktu@gmail.com>
7758
7759 * emacs.c (USAGE3): Doc fixes.
7760
0e48bb22
AS
77612011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7762
7763 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7764 structure.
7765
7684e57b
JB
77662011-03-14 Juanma Barranquero <lekktu@gmail.com>
7767
7768 * lisp.h (VWindow_system, Qfile_name_history):
7769 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7770 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7771 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7772
7773 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7774 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7775
7776 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7777 * w32console.c (detect_input_pending, read_input_pending)
7778 (encode_terminal_code):
7779 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7780 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7781 (w32_system_caret_y, Qfile_name_history):
7782 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7783 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7784 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7785 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7786 * w32proc.c (Qlocal, report_file_error):
7787 * w32term.c (Vwindow_system, updating_frame):
7788 * w32uniscribe.c (initialized, uniscribe_font_driver):
7789 Remove unneeded extern declarations.
7790
2aa46d6c
CY
77912011-03-14 Chong Yidong <cyd@stupidchicken.com>
7792
c96bbc66 7793 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7794
cffc6f3b
CY
77952011-03-13 Chong Yidong <cyd@stupidchicken.com>
7796
7797 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7798 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7799 These macros can no longer be used for assignment.
7800
44f230aa
SM
7801 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7802 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7803 (record_buffer_markers, fetch_buffer_markers): New functions for
7804 recording and fetching special buffer markers.
7805 (set_buffer_internal_1, set_buffer_temp): Use them.
7806
7807 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7808
7809 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7810
7811 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7812 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7813
7814 * xdisp.c (hscroll_window_tree):
7815 (reconsider_clip_changes): Use PT instead of BUF_PT.
7816
d251f04b
EZ
78172011-03-13 Eli Zaretskii <eliz@gnu.org>
7818
7819 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7820 $(EMACS_ROOT)/lib/intprops.h.
7821
f0c77cd1
PE
78222011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7823
3eca4629
PE
7824 Fix more problems found by GCC 4.5.2's static checks.
7825
7c86ee98
PE
7826 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7827 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7828 (xg_free_frame_widgets): Make it clear that a local variable is
7829 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7830 (gdk_window_get_screen): Make it clear that this macro is needed
7831 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7832 (int_gtk_range_get_value): New function, which avoids a diagnostic
7833 from gcc -Wbad-function-cast.
7834 (xg_set_toolkit_scroll_bar_thumb): Use it.
7835 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7836 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7837 (get_utf8_string, xg_get_file_with_chooser):
7838 Rename locals to avoid shadowing.
7839 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7840
41729b81
PE
7841 * xgselect.c (xg_select): Remove unused var.
7842
f0c77cd1
PE
7843 * image.c (four_corners_best): Mark locals as initialized.
7844 (gif_load): Initialize transparent_p to zero (Bug#8238).
7845 Mark another local as initialized.
ec6cf4c6 7846 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7847
ce0ad53d 7848 * image.c (clear_image_cache): Now static.
d5d5a617 7849 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7850 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7851 (x_edge_detection): Remove unnecessary cast that
7852 gcc -Wbad-function-cast diagnoses.
2037898d 7853 (gif_load): Fix pointer signedness.
6ae141d6
PE
7854 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7855 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7856
33383987 78572011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7858
d32df629
PE
7859 Improve quality of tests for time stamp overflow.
7860 For example, without this patch (encode-time 0 0 0 1 1
7861 1152921504606846976) returns the obviously-bogus value (-948597
7862 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7863 reports time overflow. See
7864 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7865 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7866 * editfns.c: Include limits.h and intprops.h.
7867 (TIME_T_MIN, TIME_T_MAX): New macros.
7868 (time_overflow): Move earlier, to before first use.
7869 (hi_time, lo_time): New functions, for an accurate test for
7870 out-of-range times.
7871 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7872 (Fget_internal_run_time): Don't assume time_t fits in int.
7873 (make_time): Use list2 instead of Fcons twice.
7874 (Fdecode_time): More accurate test for out-of-range times.
7875 (check_tm_member): New function.
7876 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7877 (lisp_time_argument): Don't rely on undefined left-shift and
7878 right-shift behavior when checking for time stamp overflow.
8be6f318 7879
fe31d94c
PE
7880 * editfns.c (time_overflow): New function, refactoring common code.
7881 (Fformat_time_string, Fdecode_time, Fencode_time):
7882 (Fcurrent_time_string): Use it.
7883
8be6f318
PE
7884 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7885 * dired.c (make_time): Move to ...
7886 * editfns.c (make_time): ... here.
7887 * systime.h: Note the move.
7888
09d9db2c 78892011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7890
126bc0dc
YM
7891 * fringe.c (update_window_fringes): Remove unused variables.
7892
c47cbdfd
YM
7893 * unexmacosx.c (copy_data_segment): Also copy __got section.
7894 (Bug#8223)
7895
7ac80be9
EZ
78962011-03-12 Eli Zaretskii <eliz@gnu.org>
7897
c96bbc66 7898 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7899 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7900 Constify `char *' arguments and their references according to
7901 prototypes in tparam.h.
7902
ecb0f94d 7903 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7904
7ac80be9
EZ
7905 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7906 Adapt all references accordingly.
7907
7908 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7909
ef1fd07e
TT
79102011-03-11 Tom Tromey <tromey@redhat.com>
7911
7912 * buffer.c (syms_of_buffer): Remove obsolete comment.
7913
7ef4b50c
EZ
79142011-03-11 Eli Zaretskii <eliz@gnu.org>
7915
7916 * termhooks.h (encode_terminal_code): Declare prototype.
7917
7918 * msdos.c (encode_terminal_code): Don't declare prototype.
7919
7920 * term.c (encode_terminal_code): Now external again, used by
7921 w32console.c and msdos.c.
7922
44f230aa
SM
7923 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7924 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7925
4b1ec863 79262011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7927
1714f52b 7928 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7929
4b1ec863
PE
7930 * fringe.c (update_window_fringes): Mark locals as initialized
7931 (Bug#8227).
7932 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7933
524c7aa6
PE
7934 * alloc.c (mark_fringe_data): Move decl from here ...
7935 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7936 to check its interface.
7937 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7938
a5c0af81 7939 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7940 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7941 (fontset_font): Mark local as initialized.
a9a06e0b 7942 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7943
b4716021
PE
7944 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7945
811e9bac 7946 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7947 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7948 (x_own_selection, Fx_disown_selection_internal): Rename locals
7949 to avoid shadowing.
7950 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7951
7e3ab302
PE
7952 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7953 so that the caller can use some name other than gcpro1.
7954 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7955 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7956 (Fx_backspace_delete_keys_p):
7957 Use them to avoid shadowing, and rename vars to avoid shadowing.
7958 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7959 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7960 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7961 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7962 Remove unused locals.
7e3ab302
PE
7963 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7964 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7965 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7966 macros.
f78faa98 7967
e2b13473
PE
7968 * xterm.h (x_mouse_leave): New decl.
7969
77f23912
PE
7970 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7971 Remove unused functions.
cdf4ba58
PE
7972 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7973 (x_calc_absolute_position): Now static.
7411c686 7974 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7975 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7976 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7977 unless they are used.
38d0b34a
PE
7978 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7979 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7980 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7981 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7982 (x_error_catcher, x_connection_closed, x_error_handler):
7983 (x_error_quitter, xembed_send_message, x_iconify_frame):
7984 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7985 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7986 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7987
44f230aa
SM
7988 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7989 Rename or move locals to avoid shadowing.
6b463e58 7990 (tty_defined_color, merge_face_heights): Now static.
5967d051 7991 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7992 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7993 does not deduce is never used uninitialized.
73719eba
PE
7994 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7995 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7996
426994c3 7997 * terminal.c (store_terminal_param): Now static.
5489860b 7998
032f1620 7999 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8000 (set_frame_menubar): Remove unused local.
d4323972 8001 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8002 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8003 since they might point to immutable storage.
281585b0
PE
8004 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8005 since it's unused otherwise.
032f1620 8006
367c19e5 8007 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8008 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8009 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8010 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8011 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8012 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8013 does not deduce are never used uninitialized.
70739cbe 8014
07b48fa9
PE
8015 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8016
8868a238 8017 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8018 * window.c (window_loop, size_window):
8019 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8020
7e5cf297 8021 * window.c (display_buffer): Now static.
d6550a9f
PE
8022 (size_window): Mark variables that gcc -Wuninitialized
8023 does not deduce are never used uninitialized.
a586633d
PE
8024 * window.h (check_all_windows): New decl, to forestall
8025 gcc -Wmissing-prototypes diagnostic.
5b555da1 8026 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8027
f6095868
PE
8028 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8029 shadowing.
8030 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8031 Include <limits.h>.
8032 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8033 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8034 (load_charset_map): Mark variables that gcc -Wuninitialized
8035 does not deduce are never used uninitialized.
53df7c11 8036 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8037
f38b440c
PE
8038 * coding.c (coding_set_source, coding_set_destination):
8039 Use "else { /* comment */ }" rather than "else /* comment */;"
8040 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8041 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8042 a block, when the outer 'i' will do.
8043 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8044 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8045 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8046 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8047 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8048 Rename locals to avoid shadowing.
8049 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8050 * coding.c (emacs_mule_char, encode_invocation_designation):
8051 Now static, since they're not used elsewhere.
413bb2db 8052 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8053 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8054 (decode_coding_emacs_mule): Mark variables that gcc
8055 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8056 (detect_coding_iso_2022): Initialize a local variable that might
8057 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8058 this initialization is needed. (Bug#8211)
5f58e762
PE
8059 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8060 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8061 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8062 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8063 Remove unused macros.
f38b440c 8064
232b38b9 8065 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8066 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8067 * character.c (string_count_byte8): Likewise.
232b38b9 8068
fb90da1b
PE
8069 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8070 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8071
fb93dbc2
PE
8072 * chartab.c (copy_sub_char_table): Now static, since it's not used
8073 elsewhere.
5c156ace
PE
8074 (sub_char_table_ref_and_range, char_table_ref_and_range):
8075 Rename locals to avoid shadowing.
bbcd0949 8076 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8077
7d3b3862 8078 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8079 (BIDI_BOB): Remove unused macro.
7d3b3862 8080
6be7d3da
PE
8081 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8082 deduce are never used uninitialized.
c2ed9c8b 8083 * term.c (encode_terminal_code): Likewise.
6be7d3da 8084
75f8807f 8085 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8086
50938595
PE
8087 * tparam.h: New file.
8088 * term.c, tparam.h: Include it.
8089 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8090 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8091 Move these decls to tparam.h, and make them agree with what
8092 is actually in tparam.c. The previous trick of using incompatible
8093 decls in different modules does not conform to the C standard.
8094 All callers of tparam changed to use tparam's actual API.
8095 * tparam.c (tparam1, tparam, tgoto):
8096 Use const pointers where appropriate.
8097
fbceeba2
PE
8098 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8099 * cm.h (struct cm): Likewise.
8100 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8101 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8102 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8103 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8104 (turn_on_face, init_tty): Likewise.
8105 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8106
7f3f1250
PE
8107 * term.c (term_mouse_position): Rename local to avoid shadowing.
8108
e6ca6543
PE
8109 * alloc.c (mark_ttys): Move decl from here ...
8110 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8111
c40f8d15
AS
81122011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8113
8114 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8115
cfe0661d
JB
81162011-03-09 Juanma Barranquero <lekktu@gmail.com>
8117
8118 * search.c (compile_pattern_1): Remove argument regp, unused since
8119 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8120 (compile_pattern): Don't pass it.
8121
0afb4571
J
81222011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8123
8124 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8125 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8126 for ! HAVE_GTK3.
8127 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8128
8129 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8130
8131 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8132 gdk_window_get_screen, gdk_window_get_geometry,
8133 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8134 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8135 (xg_get_pixbuf_from_pixmap): New function.
8136 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8137 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8138 Call xg_get_pixbuf_from_pixmap instead of
8139 gdk_pixbuf_get_from_drawable.
8140 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8141 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8142 (xg_check_special_colors): Use GtkStyleContext and its functions
8143 for HAVE_GTK3.
8144 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8145 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8146 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8147 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8148 Call gtk_widget_get_preferred_size.
0afb4571
J
8149 (xg_frame_resized): gdk_window_get_geometry only takes 5
8150 parameters.
44f230aa
SM
8151 (xg_win_to_widget, xg_event_is_for_menubar):
8152 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8153 (xg_set_widget_bg): New function.
8154 (delete_cb): New function.
895009e1 8155 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8156 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8157 (xg_set_background_color): Call xg_set_widget_bg.
8158 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8159 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8160 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8161 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8162 if ! HAVE_GTK3.
8163 (update_frame_tool_bar): Call gtk_widget_hide.
8164 (xg_initialize): Use GDK_KEY_g.
8165
8166 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8167 if ! HAVE_GTK3
8168 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8169
8170 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8171 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8172 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8173
1c2cc4ef
JB
81742011-03-08 Juanma Barranquero <lekktu@gmail.com>
8175
8176 * w32xfns.c (select_palette): Check success of RealizePalette against
8177 GDI_ERROR, not zero.
8178
33383987 8179See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8180
8181;; Local Variables:
8182;; coding: utf-8
aac0c6e3
MR
8183;; End:
8184
33383987 8185 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8186
8187 This file is part of GNU Emacs.
8188
8189 GNU Emacs is free software: you can redistribute it and/or modify
8190 it under the terms of the GNU General Public License as published by
8191 the Free Software Foundation, either version 3 of the License, or
8192 (at your option) any later version.
8193
8194 GNU Emacs is distributed in the hope that it will be useful,
8195 but WITHOUT ANY WARRANTY; without even the implied warranty of
8196 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8197 GNU General Public License for more details.
8198
8199 You should have received a copy of the GNU General Public License
8200 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.