Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
97897668
GM
12012-01-31 Glenn Morris <rgm@gnu.org>
2
3 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6
31fd3586
GM
72012-01-29 Glenn Morris <rgm@gnu.org>
8
9 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
10
0e24a8b2
CY
112012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
12
13 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
14
cc0adcb0
CY
152012-01-28 Chong Yidong <cyd@gnu.org>
16
0e24a8b2 17
cc0adcb0
CY
18 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
19
acc28cb9
CY
202012-01-26 Chong Yidong <cyd@gnu.org>
21
9c69cfb7
CY
22 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
23
acc28cb9
CY
24 * search.c (Fsearch_forward, Fsearch_backward): Document negative
25 repeat counts (Bug#10507).
26
48da7392
GM
272012-01-26 Glenn Morris <rgm@gnu.org>
28
29 * lread.c (syms_of_lread): Doc fix.
30
14af5f7f
CY
312012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
32
33 * coding.c (encode_designation_at_bol): Change return value to
34 EMACS_INT.
35
0b21c100
CY
362012-01-25 Chong Yidong <cyd@gnu.org>
37
38 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
39
3c2907f7
CY
402012-01-21 Chong Yidong <cyd@gnu.org>
41
42 * floatfns.c (Fcopysign): Make the second argument non-optional,
43 since nil is not allowed anyway.
44
959ad23f
AS
452012-01-21 Andreas Schwab <schwab@linux-m68k.org>
46
47 * process.c (read_process_output): Use p instead of XPROCESS (proc).
48 (send_process): Likewise.
49
34a02f46
MR
502012-01-19 Martin Rudalics <rudalics@gmx.at>
51
52 * window.c (save_window_save, Fcurrent_window_configuration)
53 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
54 doc-strings.
55
1259009a 562012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
57
58 * character.c (char_width): New function.
70d4fdf6
GM
59 (Fchar_width, c_string_width, lisp_string_width):
60 Use char_width (Bug#9496).
25ed9e61 61
6a6ee00d
MR
622012-01-16 Martin Rudalics <rudalics@gmx.at>
63
64 * window.c (Vwindow_persistent_parameters): New variable.
65 (Fset_window_configuration, save_window_save): Handle persistent
66 window parameters.
67
c85efaf7
EZ
682012-01-14 Eli Zaretskii <eliz@gnu.org>
69
70 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
71 thrashing the stack of the thread. (Bug#9087)
72
5944709e
PE
732012-01-12 Paul Eggert <eggert@cs.ucla.edu>
74
75 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
76
e71f5d99
EZ
772012-01-11 Eli Zaretskii <eliz@gnu.org>
78
79 * xdisp.c (rows_from_pos_range): Handle the case where the
80 highlight ends on a newline. (Bug#10464)
81 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
82 he end column for display of highlight that ends on a newline
83 before a R2L line.
84
ce316182
GM
852012-01-11 Glenn Morris <rgm@gnu.org>
86
87 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
88 from load-path also when installation-directory is nil. (Bug#10208)
89
5b43da69
GM
902012-01-10 Glenn Morris <rgm@gnu.org>
91
74cc8ff9
GM
92 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
93
7d8d6e4e
GM
94 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
95 Update template values to be closer to their typical values these days.
5b43da69 96
a0db8d43
EZ
972012-01-09 Eli Zaretskii <eliz@gnu.org>
98
99 * xdisp.c (rows_from_pos_range): Accept additional argument
100 DISP_STRING, and accept any glyph in a row whose object is that
101 string as eligible for mouse highlight. Fixes mouse highlight of
102 display strings from overlays. (Bug#10464)
103
9a0115ab 1042012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 105
b9110d6a 106 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
107 * fileio.c (auto_saving_dir_umask): New static var.
108 (Fmake_directory_internal): Use it.
109 (do_auto_save_make_dir): Set it, instead of invoking chmod after
110 creating the directory. The old code temporarily assigns
111 too-generous permissions to the directory.
112 (do_auto_save_eh): Clear it.
b9110d6a 113 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
114 that the var is always cleared.
115
6c1bd3f3
EZ
1162012-01-07 Eli Zaretskii <eliz@gnu.org>
117
118 * search.c (scan_buffer): Pass character positions to
119 know_region_cache, not byte positions. (Bug#6540)
120
069d2b50
L
1212012-01-07 LynX <_LynX@bk.ru> (tiny change)
122
123 * w32.c (sys_rename): Report EXDEV when rename of a directory
124 fails because the target is on another logical disk. (Bug#10284)
125
75bf0d33
DB
1262012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
127
128 * xterm.c (x_embed_request_focus): New function.
129
130 * xterm.h: Add prototype.
131
132 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
133
1c6e5a32
GM
1342012-01-05 Glenn Morris <rgm@gnu.org>
135
136 * emacs.c (emacs_copyright): Update short copyright year to 2012.
137
651e947e
EZ
1382012-01-01 Eli Zaretskii <eliz@gnu.org>
139
140 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
141 Load gnutls_transport_set_lowat only if GnuTLS version is below
142 2.11.1.
143 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
144 GnuTLS versions below 2.11.1.
145
3778cdd8
AL
1462011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
147
148 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
149 to the doc string advising against its use for altering the way
150 windows are scrolled.
151
0e5317f7
KH
1522011-12-28 Kenichi Handa <handa@m17n.org>
153
154 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
155 coding-system ASCII compatible only when it does not produce BOM
156 on encoding (Bug#10383).
157
93d5ca1f
JD
1582011-12-26 Jan Djärv <jan.h.d@swipnet.se>
159
160 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
161 can scroll.
162 (create_and_show_popup_menu): Always use menu_position_func for
163 Gtk3 (Bug#10361).
164
ca22b785
AS
1652011-12-24 Andreas Schwab <schwab@linux-m68k.org>
166
167 * callint.c (Fcall_interactively): Don't truncate prompt string.
168
d048e1e6
EZ
1692011-12-23 Eli Zaretskii <eliz@gnu.org>
170
171 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
172 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 173 resumed from there (after widening). (Bug#10360)
d048e1e6 174
5ccaba1f
JD
1752011-12-22 Jan Djärv <jan.h.d@swipnet.se>
176
177 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
178
204ee57f
JD
1792011-12-21 Jan Djärv <jan.h.d@swipnet.se>
180
b81d40f0
JB
181 * nsterm.m (x_free_frame_resources):
182 Release f->output_data.ns->miniimage.
204ee57f
JD
183 (ns_index_color): Fix indentation. Do not retain
184 color_table->colors[i].
185
186 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
187 before returning.
188
189 * nsfns.m (x_set_background_color): Assign return value from
190 ns_index_color to face-background instead of NSColor*.
191 (ns_implicitly_set_icon_type): Fix indentation.
192 Change assignment in for loop to comparison.
193
194 * emacs.c (ns_pool): New variable.
195 (main): Assign ns_pool.
196 (Fkill_emacs): Call ns_release_autorelease_pool.
197
198 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
199 autorelease fdesc, release fdAttrs and tdict.
200 (ns_get_covering_families): Release charset.
201 (ns_findfonts): Release NSFontDescriptor created with new.
202 (ns_uni_to_glyphs): Fix indentation.
203 (setString): Release attrStr before assigning new value.
204
c803b2b7
JD
2052011-12-18 Jan Djärv <jan.h.d@swipnet.se>
206
678f4426
JD
207 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
208 and NS_IMPL_COCOA.
209 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
210 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
211
cd394be1 2122011-12-18 David Reitter <reitter@cmu.edu>
678f4426 213
5fecd5fc
JD
214 * nsterm.m (ns_term_init): Subscribe for notifications
215 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
216 to method trackingNotification in EmacsMenu.
217
218 * nsmenu.m (trackingMenu): New variable.
3771cb17 219 (trackingNotification): New method (from Aquamacs).
5fecd5fc 220 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 221 from Aquamacs (Bug#7030).
678f4426
JD
222
2232011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 224
c803b2b7
JD
225 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
226 (symbol_to_nsstring): Fix indentation.
227 (ns_symbol_to_pb): New function.
228 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
229 (Fns_rotate_cut_buffers_internal): Removed.
230 (Fns_store_selection_internal): Renamed from
231 Fns_store_cut_buffer_internal.
232 (ns_get_foreign_selection, Fx_own_selection_internal)
233 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
234 (Fns_get_selection_internal, Fns_store_selection_internal):
235 Use ns_symbol_to_pb and check if return value is nil.
236 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
237 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
238 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
239 renamed to Sns_store_selection_internal.
240 (ns_handle_selection_request): Move code to Fx_own_selection_internal
241 and remove this function.
242 (ns_handle_selection_clear): Remove, never used.
243 (Fx_own_selection_internal): Move code from ns_handle_selection_request
244 here.
245
e1b01a3a
KB
2462011-12-17 Ken Brown <kbrown@cornell.edu>
247
248 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
249 GID is unknown (Bug#10257).
250
2adb6e85
PE
2512011-12-17 Paul Eggert <eggert@cs.ucla.edu>
252
253 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
254 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
255 which caused a build failure on GNU/Linux IA-64. This problem was
256 introduced by my 2011-10-07 patch.
257
d1d7b339
JL
2582011-12-15 Juri Linkov <juri@jurta.org>
259
260 * image.c (imagemagick_error): New function. (Bug#10112)
261 (imagemagick_load_image): Comment out `MagickSetResolution' call.
262 Use `imagemagick_error' where ImageMagick functions return
263 `MagickFalse'.
264 (Fimagemagick_types): Add `Fnreverse' to return the list in the
265 proper order.
266
100d5755
KH
2672011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
268
269 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
270 fill background (Bug#8992).
271
454592a6
MR
2722011-12-13 Martin Rudalics <rudalics@gmx.at>
273
274 * window.c (Vwindow_combination_resize)
275 (Vwindow_combination_limit): Use t instead of non-nil in
276 doc-strings.
61d4b438
MR
277 (Vrecenter_redisplay): Add first sentence of doc-string on
278 separate line.
53524d93 279 (Frecenter): Fix doc-string typo.
454592a6 280
3633e3aa
KH
2812011-12-11 Kenichi Handa <handa@m17n.org>
282
283 * coding.c (Funencodable_char_position): Pay attention to the
284 buffer text relocation (Bug#9389).
285
7b9d523a
JD
2862011-12-10 Jan Djärv <jan.h.d@swipnet.se>
287
288 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
289 gtk_init (Bug#10100).
290
b73189c6
EZ
2912011-12-10 Eli Zaretskii <eliz@gnu.org>
292
293 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
294 IT->string is nil. (Bug#10263)
295
f7dfe5d6
JD
2962011-12-10 Jan Djärv <jan.h.d@swipnet.se>
297
83faebb4
JD
298 * nsterm.h (x_free_frame_resources): Declare.
299
f7dfe5d6
JD
300 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
301 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
302
303 * nsterm.h (ns_get_defaults_value): Declare.
304
305 * nsterm.m (ns_default): Call ns_get_defaults_value.
306
7cd4e72c
EZ
3072011-12-09 Eli Zaretskii <eliz@gnu.org>
308
309 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
310 (Bug#10170)
311
b34d7317
YM
3122011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
313
314 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
315 that where the value of an _OBJC_* symbol points to is in the .bss
316 section (Bug#10240).
317
76470ad1
KH
3182011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
319
320 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 321 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 322
745fff94
KH
3232011-12-08 Kenichi Handa <handa@m17n.org>
324
325 * ftfont.c (get_adstyle_property): Fix previous change
326 (Bug#10233).
327
6e44397c
JB
3282011-12-07 Juanma Barranquero <lekktu@gmail.com>
329
330 * w32.c (init_environment): If no_site_lisp, remove site-lisp
331 dirs from the default value of EMACSLOADPATH (bug#10208).
332
7efa6272
GM
3332011-12-07 Glenn Morris <rgm@gnu.org>
334
335 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
336 installation and source directories as well. (Bug#10208)
337
f6fc4d87
CY
3382011-12-06 Chong Yidong <cyd@gnu.org>
339
340 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
341
2bf26180
GM
3422011-12-06 Glenn Morris <rgm@gnu.org>
343
344 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
345 as an error, not just -1. (Bug#10217)
346
3a6ad4f0
CY
3472011-12-05 Chong Yidong <cyd@gnu.org>
348
349 * keyboard.c (process_special_events): New function.
350 (swallow_events, Finput_pending_p): Use it (Bug#10195).
351
75a3b399
PE
3522011-12-05 Paul Eggert <eggert@cs.ucla.edu>
353
354 * coding.c (encode_designation_at_bol): Don't use uninitialized
355 local variable (Bug#9318).
356
c3c9e25e
KH
3572011-12-05 Kenichi Handa <handa@m17n.org>
358
359 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
360 return Qnil (Bug#8046, Bug#10193).
361
5eb05ea3
KH
3622011-12-05 Kenichi Handa <handa@m17n.org>
363
364 * coding.c (encode_designation_at_bol): New args charbuf_end and
365 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
366 (coding_set_source): Return how many bytes coding->source was
367 relocated.
368 (coding_set_destination): Return how many bytes
369 coding->destination was relocated.
370 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
371 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
372
3732011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
374
375 * coding.c (CODING_CHAR_CHARSET_P): New macro.
376 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
377 macro (Bug#9318).
378
3792011-12-05 Andreas Schwab <schwab@linux-m68k.org>
380
381 The following changes are to fix Bug#9318.
382
a79703f5 383 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
384 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
385 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 386 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 387
7dbda6df
JB
3882011-12-05 Juanma Barranquero <lekktu@gmail.com>
389
390 * lisp.h (process_quit_flag): Fix external declaration.
391
6d5eb5b0
SM
3922011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
393
394 Don't macro-inline non-performance-critical code.
395 * eval.c (process_quit_flag): New function.
396 * lisp.h (QUIT): Use it.
397
a0c3fad0
JD
3982011-12-04 Jan Djärv <jan.h.d@swipnet.se>
399
400 * nsfns.m (get_geometry_from_preferences): New function.
401 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
402
6c07aac2
AS
4032011-12-04 Andreas Schwab <schwab@linux-m68k.org>
404
405 * emacs.c (Qkill_emacs): Define.
406 (syms_of_emacs): Initialize it.
407 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
408 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
409 (quit_throw_to_read_char): Add parameter `from_signal'.
410 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
411 * lisp.h (QUIT): Call Fkill_emacs if requested.
412
c052ead4
JD
4132011-12-03 Jan Djärv <jan.h.d@swipnet.se>
414
415 * widget.c (update_wm_hints): Return if wmshell is null.
416 (widget_update_wm_size_hints): New function.
417
418 * widget.h (widget_update_wm_size_hints): Declare.
419
420 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
421 widget_update_wm_size_hints (Bug#10104).
422
9e49252b
EZ
4232011-12-03 Eli Zaretskii <eliz@gnu.org>
424
425 * xdisp.c (handle_invisible_prop): If the invisible text ends just
426 before a newline, prepare the bidi iterator for consuming the
427 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 428 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 429
02b16839
JL
4302011-12-02 Juri Linkov <juri@jurta.org>
431
432 * search.c (Fword_search_regexp): New Lisp function created from
433 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
434 (Fword_search_backward, Fword_search_forward)
435 (Fword_search_backward_lax, Fword_search_forward_lax):
436 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
437 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
438
0068070e
SM
4392011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
440
441 * fileio.c (Finsert_file_contents): Move after-change-function call
442 to before the "handled:" label, since all "goto handled" appear in
443 cases where the *-change-functions have already been properly called
444 (bug#10117).
445
3360a3fc
AS
4462011-12-01 Andreas Schwab <schwab@linux-m68k.org>
447
448 * keyboard.c (interrupt_signal): Don't call kill-emacs when
449 waiting for input. (Bug#10169)
450
73d6c093
EZ
4512011-11-30 Eli Zaretskii <eliz@gnu.org>
452
453 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
454 verifies glyph row's hash code--we have just reallocated the
455 glyphs, so their contents can be complete garbage. (Bug#10164)
456
febe6bea
JB
4572011-11-30 Juanma Barranquero <lekktu@gmail.com>
458
459 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
460
801a4313
EZ
4612011-11-30 Eli Zaretskii <eliz@gnu.org>
462
463 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
464 attributes are tested _before_ calling verify_row_hash, to protect
465 against GCC re-ordering of the tests. (Bug#10164)
466
2b56b87e
JD
4672011-11-29 Jan Djärv <jan.h.d@swipnet.se>
468
469 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
470
471 * xterm.c (handle_one_xevent): Only set async_visible and friends
472 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 473 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
474 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
475
dbf31225
PE
4762011-11-28 Paul Eggert <eggert@cs.ucla.edu>
477
478 Remove GCPRO-related macros that exist only to avoid shadowing locals.
479 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
480 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
481 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
482 All uses changed to use GCPRO1 etc.
483 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
484 Revert to old implementation (i.e., before 2011-03-11).
485
1305621b
YM
4862011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
487
488 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
489 of scroll runs so as to avoid assigning disabled bogus rows and
490 unnecessary graphics copy operations.
491
8c9afb46
EZ
4922011-11-27 Eli Zaretskii <eliz@gnu.org>
493
494 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
495 (snprintf) [_MSC_VER]: Redirect to _snprintf.
496 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
497 (malloc, free, realloc, calloc): Redirect to e_* only when
498 compiling Emacs.
499
500 * lisp.h (GCTYPEBITS): Move before first use.
501 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
502 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
503 this macro definition.
504
505 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
506 _MSC_VER.
507
54e9e3bf
JD
5082011-11-27 Jan Djärv <jan.h.d@swipnet.se>
509
6d5eb5b0
SM
510 * gtkutil.c (xg_create_frame_widgets):
511 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
512 present with Gtk+ 2.0.
513
83aca1cb
PE
5142011-11-26 Paul Eggert <eggert@cs.ucla.edu>
515
516 * fileio.c (Finsert_file_contents): Undo previous change; see
517 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
518
5b76caa4
PE
5192011-11-26 Paul Eggert <eggert@cs.ucla.edu>
520
521 Rename locals to avoid shadowing.
522 * fileio.c (Finsert_file_contents):
523 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
524 * process.c (wait_reading_process_output):
525 Rename inner 'proc' to 'p' to avoid shadowing.
526 Indent for consistency with usual Emacs style.
527
8c535114
EZ
5282011-11-25 Eli Zaretskii <eliz@gnu.org>
529
530 * xdisp.c (redisplay_window): If cursor row is not fully visible
531 after recentering, and scroll-conservatively is set to a large
532 number, scroll window by a few more lines to make the cursor fully
533 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
534 (start_display): Don't move to the next line if the display should
535 start at a newline that is part of a display vector or an overlay
536 string. (Bug#10119)
8c535114 537
fa4fdb5c
JL
5382011-11-24 Juri Linkov <juri@jurta.org>
539
540 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
541 after the `MagickPingImage' call. (Bug#10112)
542
90ec88df
CY
5432011-11-23 Chong Yidong <cyd@gnu.org>
544
545 * window.c (Fcoordinates_in_window_p): Accept only live windows.
546
56e2e794
MR
5472011-11-23 Martin Rudalics <rudalics@gmx.at>
548
549 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
550 making another buffer current. (Bug#10114)
551
b6e64c41
GM
5522011-11-23 Glenn Morris <rgm@gnu.org>
553
554 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
555
6b21de18
CY
5562011-11-23 Chong Yidong <cyd@gnu.org>
557
558 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
559 using it (Bug#5984).
560
b12cd789
EZ
5612011-11-22 Eli Zaretskii <eliz@gnu.org>
562
563 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
564 and header-lines, as they don't have one computed for them.
565 (Bug#10098)
566
567 * .gdbinit (prow): Make displayed values more self-explaining.
568 Add row's hash code.
569
261b6fd4
LMI
5702011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
571
572 * process.c (wait_reading_process_output): Fix asynchrounous
573 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 574 (wait_reading_process_output): Add comment and URL.
261b6fd4 575
e7cfd277
JD
5762011-11-21 Jan Djärv <jan.h.d@swipnet.se>
577
578 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
579
a9b9b7f5
CY
5802011-11-21 Chong Yidong <cyd@gnu.org>
581
582 * window.c (Fnext_window, Fprevious_window): Doc fix.
583
b0d15b4f
SM
5842011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
585
586 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
587
fe7a3057
JB
5882011-11-20 Juanma Barranquero <lekktu@gmail.com>
589
590 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
591
d2999b1a
MR
5922011-11-20 Martin Rudalics <rudalics@gmx.at>
593
594 * window.c (Fset_window_combination_limit): Rename argument
595 STATUS to LIMIT.
596 (Vwindow_combination_limit): Remove "status" from doc-string.
597
d5ff9cd0
AS
5982011-11-20 Andreas Schwab <schwab@linux-m68k.org>
599
600 * m/ibms390.h: Remove.
601 * m/ibms390x.h: Don't include "ibms390.h".
602
a5bb9bd3
SM
6032011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
604
605 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
606 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
607
cd1181db
JB
6082011-11-20 Juanma Barranquero <lekktu@gmail.com>
609
610 * casetab.c (Fset_case_table):
611 * charset.c (Fcharset_after): Fix typos.
612
615a3b8d 6132011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 614
17e845af
PE
615 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
616 Otherwise, valgrind does not work on some platforms.
617 Problem reported by Andreas Schwab in
6a0bf43d
PE
618 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
619 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
620 is set, removing the need for VIRT_ADDRESS_VARIES.
621 (PURE_P): Use a more-efficient implementation that needs just one
622 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
623 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
624 to 4 (xorl, subq, cmpq, setbe).
625 * alloc.c (pure): Always extern now, since that's the
626 VIRT_ADDR_VARIES behavior.
627 (PURE_POINTER_P): Use a single comparison, not two, for
628 consistency with the new puresize.h.
629 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
630 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
631 Remove VIRT_ADDR_VARIES no longer needed.
632
f8fe6f96
EZ
6332011-11-19 Eli Zaretskii <eliz@gnu.org>
634
635 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
636 (erase_phys_cursor, update_window_cursor, show_mouse_face)
637 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
638 behave as if the cursor position were at the window margin.
639
640 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
641 and the cursor position is out of bounds, behave as if the cursor
642 position were at the window margin. (Bug#10075)
643
df05a53c
CY
6442011-11-18 Chong Yidong <cyd@gnu.org>
645
646 * window.c (Fwindow_combination_limit): Make first argument
647 non-optional, since it is meaningless for live windows like the
648 selected window.
649
2071918e
DA
6502011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
651
652 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
653
b50a28de
SM
6542011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
655
656 * intervals.c: Fix grafting over the whole buffer (bug#10071).
657 (graft_intervals_into_buffer): Simplify.
658
015137db
EZ
6592011-11-18 Eli Zaretskii <eliz@gnu.org>
660
661 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
662 hash values of the two rows.
663 (copy_row_except_pointers): Preserve the used[] arrays and the
664 hash values of the two rows. (Bug#10035)
68c95424 665 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
666
667 * xdisp.c (row_hash): New function, body extracted from
668 compute_line_metrics.
669 (compute_line_metrics): Call row_hash, instead of computing the
670 hash code inline.
671
672 * dispnew.c (verify_row_hash): Call row_hash for computing the
673 hash code of a row, instead of duplicating code from xdisp.c.
674
675 * dispextern.h (row_hash): Add prototype.
676
a2addb04
TH
6772011-11-18 Tassilo Horn <tassilo@member.fsf.org>
678
679 * frame.c (delete_frame): Don't delete the terminal when the last
680 X frame is closed if emacs is built with GTK toolkit.
681
df85d315
JB
6822011-11-17 Juanma Barranquero <lekktu@gmail.com>
683
684 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
685
a0c2d0ae
MR
6862011-11-17 Martin Rudalics <rudalics@gmx.at>
687
688 * window.c (Vwindow_splits): Rename to
689 Vwindow_combination_resize. Suggested by Juri Linkov.
690 (Fsplit_window_internal): Use Vwindow_combination_resize instead
691 of Vwindow_splits.
692
58179cce
JB
6932011-11-16 Juanma Barranquero <lekktu@gmail.com>
694
7877f373
JB
695 * nsfns.m (Fns_font_name):
696 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 697
b6f67890
MR
6982011-11-16 Martin Rudalics <rudalics@gmx.at>
699
700 * window.h (window): Rename slot "nest" to "combination_limit".
701 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
702 (Fset_window_nest): Rename to Fset_window_combination_limit.
703 (Vwindow_nest): Rename to Vwindow_combination_limit.
704 (recombine_windows, make_parent_window, make_window)
705 (Fsplit_window_internal, saved_window)
706 (Fset_window_configuration, save_window_save): Rename all
707 occurrences of window_nest to window_combination_limit.
708
c7015153
JB
7092011-11-15 Juanma Barranquero <lekktu@gmail.com>
710
711 * image.c (imagemagick_load_image): Fix typo.
712
322ad6ec
EZ
7132011-11-14 Eli Zaretskii <eliz@gnu.org>
714
715 * xdisp.c (display_line): Move the call to
716 highlight_trailing_whitespace before the call to
717 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
718 faces of all the glyphs to compute ROW's hash value.
719 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 720
f067b8ec
JB
7212011-11-14 Juanma Barranquero <lekktu@gmail.com>
722
723 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
724 just return (bug#10044).
725
1e5b2111
EZ
7262011-11-12 Eli Zaretskii <eliz@gnu.org>
727
7ef3cbd5
EZ
728 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
729 with user-defined heap size. Bump the default size of the temacs
730 heap to 27MB, to avoid memory warning when running temacs.
731 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
732
1e5b2111
EZ
733 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
734 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
735 (verify_row_hash) [XASSERTS]: New function.
736 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
737 that the hash value of glyph rows is correct.
1e5b2111 738
89d61221
MR
7392011-11-12 Martin Rudalics <rudalics@gmx.at>
740
741 * window.h (window): Remove splits slot.
742 * window.c (Fwindow_splits, Fset_window_splits): Remove.
743 (Fdelete_other_windows_internal, make_parent_window)
744 (make_window, Fsplit_window_internal, Fdelete_window_internal)
745 (Fset_window_configuration, save_window_save): Don't deal with
746 split status of windows.
747 (saved_window): Remove splits slot.
748 (Vwindow_splits): Rewrite doc-string.
749
97f18cc8
JD
7502011-11-11 Jan Djärv <jan.h.d@swipnet.se>
751
752 * xfns.c (unwind_create_frame):
753 * nsfns.m (unwind_create_frame):
754 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
755 Vframe_list (Bug#9999).
756
22a648b4
DA
7572011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
758
0b381c7e 759 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 760
659afede
KH
7612011-11-11 Kenichi Handa <handa@m17n.org>
762
763 * callproc.c (Fcall_process): Set the member dst_multibyte of
764 process_coding.
765
9ac0394b
KH
7662011-11-11 Johan Bockgård <bojohan@gnu.org>
767
768 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
769 avoid a crash (bug#9496).
770
2fbdc249
CY
7712011-11-09 Chong Yidong <cyd@gnu.org>
772
773 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
774 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
775
ac6b1f81
PE
7762011-11-08 Paul Eggert <eggert@cs.ucla.edu>
777
778 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
779
09db192c
PE
7802011-11-08 Paul Eggert <eggert@cs.ucla.edu>
781
782 Avoid some portability problems by eschewing 'extern inline' functions.
783 The trivial performance wins aren't worth the portability hassles; see
784 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
785 et seq.
786 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
787 (window_box_width, window_box_left, window_box_left_offset)
788 (window_box_right, window_box_right_offset): Undo previous change,
789 by removing the "extern"s.
790 * intervals.c (adjust_intervals_for_insertion)
791 (adjust_intervals_for_deletion): Undo previous change,
792 making these static again.
793 (offset_intervals, temp_set_point_both, temp_set_point)
794 (copy_intervals_to_string): No longer inline.
795 * xdisp.c (window_text_bottom_y, window_box_width)
796 (window_box_height, window_box_left_offset)
797 (window_box_right_offset, window_box_left, window_box_right)
798 (window_box): No longer inline.
799
105216ed
CY
8002011-11-08 Chong Yidong <cyd@gnu.org>
801
802 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
803 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
804 Signal an error if not a live window.
105216ed
CY
805 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
806 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
807
ae9e237f
JB
8082011-11-07 Juanma Barranquero <lekktu@gmail.com>
809
810 * lisp.h (syms_of_abbrev): Remove declaration.
811 Reported by CHENG Gao <chenggao@royau.me>.
812
c7aa8333
EZ
8132011-11-07 Eli Zaretskii <eliz@gnu.org>
814
815 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
816 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
817 of temacs in GUI mode.
818
be7f5545
MR
8192011-11-07 Martin Rudalics <rudalics@gmx.at>
820
821 * window.h: Declare delete_all_child_windows instead of
822 delete_all_subwindows.
823 * window.c (Fwindow_nest, Fset_window_nest)
824 (Fset_window_new_total, Fset_window_new_normal)
825 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
826 (delete_all_subwindows): Rename to delete_all_child_windows.
827 (Fdelete_other_windows_internal, Fset_window_configuration):
828 Call delete_all_child_windows instead of delete_all_subwindows.
829 * frame.c (delete_frame): Call delete_all_child_windows instead
830 of delete_all_subwindows.
831
ca78dc43
PE
8322011-11-07 Paul Eggert <eggert@cs.ucla.edu>
833
834 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
835 This is also needed for porting to any host where GC_MARK_STACK is
836 not GC_MAKE_GCPROS_NOOPS.
837 (which_symbols): Use it.
838
a0241d01
KH
8392011-11-07 Kenichi Handa <handa@m17n.org>
840
841 * coding.c (coding_set_destination): Check coding->src_pos only
842 when coding->src_object is a buffer (bug#9910).
843
844 * process.c (send_process): Set the member src_multibyte of coding
845 to 0 (bug#9911) when sending a unibyte text.
846
847 * callproc.c (Fcall_process): Set the member src_multibyte of
848 process_coding to 0 (bug#9912).
849
a64bfdfa 8502011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
851
852 * xmenu.c (cleanup_widget_value_tree): New function.
853 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
854 calling free_menubar_widget_value_tree directly (Bug#9830).
855
cb41b32a
PE
8562011-11-06 Paul Eggert <eggert@cs.ucla.edu>
857
858 Fix some portability problems with 'inline'.
859 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
860 (window_box_width, window_box_left, window_box_left_offset)
861 (window_box_right, window_box_right_offset): Declare extern.
862 Otherwise, these inline functions do not conform to C99 and
863 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
864 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
865 * intervals.c (adjust_intervals_for_insertion)
866 (adjust_intervals_for_deletion): Now extern, because otherwise the
867 extern inline functions 'offset_intervals' couldn't refer to it.
868 (static_offset_intervals): Remove.
869 (offset_intervals): Rewrite using the old contents of
870 static_offset_intervals. The old version didn't conform to C99
871 because an extern inline function contained a reference to an
872 identifier with static linkage.
873
b7041366
AS
8742011-11-06 Andreas Schwab <schwab@linux-m68k.org>
875
876 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
877 GC.
878
88a37c4d
EZ
8792011-11-06 Eli Zaretskii <eliz@gnu.org>
880
881 * xdisp.c (init_iterator, reseat_to_string): Don't set the
882 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
883 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
884 return Qleft_to_right.
885
49745b39
CY
8862011-11-06 Chong Yidong <cyd@gnu.org>
887
888 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
889 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
890 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
891 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
892 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
893 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
894 (Fwindow_vscroll): Doc fix.
895 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
896 argument, since it makes no sense to pass a live window and for
897 consistency with window-child.
898
1f05cd82
CS
8992011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
900
901 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
902 support MSVC.
903
22610910
JR
9042011-11-05 Jason Rumney <jasonr@gnu.org>
905
906 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
907 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
908 fonts (Bug#6029).
909 (add_font_entity_to_list): Fix logic errors in mixed boolean and
910 bitwise arithmetic preventing use of unicode-sip and non-truetype
911 opentype fonts.
912
a06776b2
EZ
9132011-11-05 Eli Zaretskii <eliz@gnu.org>
914
3ad924ba
EZ
915 * s/ms-w32.h (fstat, stat, utime): Move redirections to
916 "emacs"-only part.
917
a06776b2
EZ
918 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
919 initialization code to keep similarity to xfns.c after changes
920 from 2011-11-05.
921
c9e7db78
JD
9222011-11-05 Jan Djärv <jan.h.d@swipnet.se>
923
a97f8f3f
JD
924 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
925 (unwind_create_frame): New function (Bug#9943).
926 (Fx_create_frame): Restructure code to be more similar to the one in
927 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
928 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
929 Move terminal->reference_count++ just before making the frame official
930 (Bug#9943).
931
932 * nsterm.m (x_free_frame_resources): New function.
933 (x_destroy_window): Move code to x_free_frame_resources.
934
c9e7db78 935 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
936 (Fx_create_frame, x_create_tip_frame):
937 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
938 official. Move initialization of image_cache_refcount and
939 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
940
a6fc3b5c
EZ
9412011-11-05 Eli Zaretskii <eliz@gnu.org>
942
943 Support MSVC build with newer versions of Visual Studio.
944 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
945 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
946 nt/gmake.defs.
947
948 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
949 which are not supported by MSVC.
950 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
951 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
952 bitfields.
953 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
954 types in bitfields.
955 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
956
957 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
958
58179cce 9592011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
960
961 Support MSVC build with newer versions of Visual Studio.
962 * w32.c: Don't include w32api.h for MSVC.
963 (init_environment) [_MSC_VER]: Call sys_access, not _access.
964
965 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
966 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
967 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
968 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
969 e_* cousins.
970 (alloca) [_MSC_VER]: Define to _alloca.
971
972 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
973
974 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
975
a58c13ed
EZ
9762011-11-04 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (note_mouse_highlight): If either of
979 previous/next-single-property-change returns nil, treat that as
980 the beginning or the end of the buffer. (Bug#9955)
981
fe0b6370
JD
9822011-11-04 Jan Djärv <jan.h.d@swipnet.se>
983
a58c13ed 984 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
985 label is not null (Bug#9951).
986 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
987 may be NULL.
988
89bd5ee1
EZ
9892011-11-04 Eli Zaretskii <eliz@gnu.org>
990
991 * window.c (Fwindow_body_size): Mention in the doc string that the
992 return value is in frame's canonical units. (Bug#9949)
993
84c3edb9
EZ
9942011-11-03 Eli Zaretskii <eliz@gnu.org>
995
4e2fb5c7
EZ
996 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
997
84c3edb9 998 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 999 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1000 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1001
bc17a887
EZ
10022011-11-01 Eli Zaretskii <eliz@gnu.org>
1003
1004 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1005 Don't stop backward scan on the continuation glyph, even though
1006 its CHARPOS is positive.
6d5eb5b0
SM
1007 (mouse_face_from_buffer_pos, note_mouse_highlight):
1008 Rename cover_string to disp_string.
bc17a887 1009
4ee88440
MR
10102011-11-01 Martin Rudalics <rudalics@gmx.at>
1011
1012 * window.c (temp_output_buffer_show): Don't use
1013 Vtemp_buffer_show_specifiers.
1014 (Vtemp_buffer_show_specifiers): Remove unused variable.
1015
c2ff3c02
EZ
10162011-10-30 Eli Zaretskii <eliz@gnu.org>
1017
1018 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1019 past the beginning of the current glyph matrix.
1020
58179cce 10212011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1022
1023 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1024 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1025 HAVE_GTK3 (Bug#9869).
b77a6a7f 1026
3b574623
JD
1027 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1028 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1029
b77a6a7f
JD
1030 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1031
1032 * xterm.c: Declare x_handle_net_wm_state to return int.
1033 (handle_one_xevent): Check if we are iconified but don't have
1034 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1035 (get_current_wm_state): Return non-zero if not hidden,
1036 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1037 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1038 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1039 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1040
196e41e4
PE
10412011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1042
1043 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1044 so that this new function doesn't get optimized away by a
1045 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1046
021f2e1a
AS
10472011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1048
1049 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1050
8b058d44
EZ
10512011-10-29 Eli Zaretskii <eliz@gnu.org>
1052
1053 Fix the `xbytecode' command.
1054 * .gdbinit (xprintbytestr): New command.
b50a28de 1055 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1056 (xbytecode): Print the byte-code string as well.
1057
4452fb80
EZ
10582011-10-29 Kim Storm <storm@cua.dk>
1059
8b058d44
EZ
1060 * alloc.c (which_symbols): New function.
1061
21b72067
AS
10622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1063
1064 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1065 line. (Bug#9903)
1066
83ed7b5c
GM
10672011-10-29 Glenn Morris <rgm@gnu.org>
1068
1069 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1070 Not clear what it was for, and it causes various bugs. (Bug#9839)
1071
5a7a728b
EZ
10722011-10-28 Eli Zaretskii <eliz@gnu.org>
1073
1074 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1075 possible random value that matches one of those tested as
1076 condition to clear the mouse face.
1077
d3d0842f
CY
10782011-10-28 Chong Yidong <cyd@gnu.org>
1079
1080 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1081
31b39d13
DN
10822011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1083
1084 * window.c (make_window): Initialize phys_cursor_on_p.
1085
9aba6043
SM
10862011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1087
1088 * lisp.h (struct Lisp_Symbol): Update comments.
1089
c20992f4
JB
10902011-10-28 Juanma Barranquero <lekktu@gmail.com>
1091
1092 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1093
db4f02f2
EZ
10942011-10-28 Eli Zaretskii <eliz@gnu.org>
1095
1096 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1097 <oslsachem@gmail.com> for helping to debug this.
1098
1099 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1100 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1101 (g_b_init_get_glyph_outline_w): New static variables.
1102 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1103 (GetGlyphOutlineW_Proc): New typedefs.
1104 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1105 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1106 New functions.
1107 (w32font_open_internal, compute_metrics):
1108 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1109 instead of calling the "wide" APIs directly.
1110
1111 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1112
1113 * w32.h (syms_of_w32font): Add prototype.
1114
87e68db4
JB
11152011-10-27 Juanma Barranquero <lekktu@gmail.com>
1116
1117 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1118 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1119 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1120 (Fmove_to_window_line): Doc fix.
1121
435c1d67
CY
11222011-10-27 Chong Yidong <cyd@gnu.org>
1123
1124 * process.c (make_process): Set gnutls_state to NULL.
1125
1126 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1127 non-NULL, regardless of GNUTLS_INITSTAGE.
1128 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1129 an error. Set process slots as soon as we allocate them.
1130
1131 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1132
9c6c6f49
CY
11332011-10-27 Chong Yidong <cyd@gnu.org>
1134
9aba6043
SM
1135 * gnutls.c (emacs_gnutls_deinit): New function.
1136 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1137 (Fgnutls_deinit, Fgnutls_boot): Use it.
1138
1139 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1140 (deactivate_process): Call emacs_gnutls_deinit.
1141
657d08d3
JB
11422011-10-27 Juanma Barranquero <lekktu@gmail.com>
1143
1144 * image.c (x_create_x_image_and_pixmap):
1145 * w32.c (sys_rename, w32_delayed_load):
1146 * w32font.c (fill_in_logfont):
1147 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1148
5430d399
JB
11492011-10-26 Juanma Barranquero <lekktu@gmail.com>
1150
1151 * w32fns.c (w32_default_color_map): New function,
1152 extracted from Fw32_default_color_map.
a7ef684b 1153 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1154
fe0055fa
PE
11552011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1158
e6346438
SM
11592011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1160
1161 * keyboard.c (test_undefined): New function (bug#9751).
1162 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1163
e112cc37
ET
11642011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1165
1166 * sysdep.c (init_sys_modes): Fix the check for the controlling
1167 terminal (Bug#6649).
1168
7b5d6677
EZ
11692011-10-20 Eli Zaretskii <eliz@gnu.org>
1170
1171 * dispextern.h (struct bidi_it): New member next_en_type.
1172
1173 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1174 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1175 current character, check also for next_en_type being WEAK_EN.
1176 (bidi_resolve_weak): Don't enter the expensive loop if the current
1177 position is before next_en_pos. Record the bidi type of the first
1178 non-ET, non-BN character we find, in addition to its position.
1179 (bidi_level_of_next_char): Invalidate next_en_type when
1180 next_en_pos is over-stepped.
1181
7da0b018
PE
11822011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1185 * editfns.c: Rewrite current-time-zone so that it invokes
1186 the equivalent of (format-time-string "%Z") to get the time zone name.
1187 This fixes a bug when the time zone name contains characters that
1188 need converting from the system time locale to Emacs internal format.
1189 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1190 that patch fixed format-time-string to do the conversion, but
1191 I forgot to fix current-time-zone.
1192 (format_time_string): New function, containing most of
1193 what Fformat_time_string used to contain.
1194 (Fformat_time_string): Rewrite in terms of format_time_string.
1195 This doesn't change this function's behavior.
1196 (current-time-zone): Rewrite to use format_time_string.
1197 This fixes the bug reported by Michael Schierl in
1198 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1199 Jason Rumney's 2007-06-07 change worked around this bug, but
1200 didn't fix it.
1201 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1202
8547b010
EZ
12032011-10-19 Eli Zaretskii <eliz@gnu.org>
1204
1205 * xdisp.c (start_display): If the character at POS is displayed
1206 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1207 (try_window_reusing_current_matrix): If a line ends in a display
1208 vector or the next line starts in a display vector, continue
1209 redrawing the window even though the character position of
1210 start_row was reached.
8547b010
EZ
1211 (Bug#9771, part 2)
1212
4e948d15
CY
12132011-10-18 Chong Yidong <cyd@gnu.org>
1214
1215 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1216 with nobreak-char-display too.
1217
4787455f
EZ
12182011-10-18 Eli Zaretskii <eliz@gnu.org>
1219
1220 Fix part 3 of bug#9771.
1221 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1222 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1223 non-neutral characters if the current character is a paragraph
1224 separator (a.k.a. Newline). This avoids running the same
1225 expensive loop twice, once when we consume the preceding newline
1226 and the other time when the line actually needs to be displayed.
1227 Avoid the loop when we see neutrals on the base embedding level
1228 following a character whose directionality is the same as the
1229 paragraph's. This avoids running the expensive loop when a line
1230 ends in a long sequence of neutrals, like control characters.
1231 Add assertion against STRONG_AL type. Slightly rearrange code
1232 that determines the type of a neutral given the first non-neutral
1233 that follows it.
1234 (bidi_level_of_next_char): Set next_en_pos to zero when
1235 invalidating its info.
1236
2c91f553
EZ
12372011-10-17 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (push_display_prop): Determine whether to record string
1240 or buffer position by IT->string, not by IT->method. Allow
1241 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1242 (move_it_vertically_backward): Don't look for character position
1243 immediately after the newline when in a continuation line.
1244 (Bug#9771, part 1)
2c91f553 1245
c7b08b0d
MR
12462011-10-15 Martin Rudalics <rudalics@gmx.at>
1247
1248 * window.c (coordinates_in_window): Rewrite and delabelize
1249 vertical border check. (Bug#5357) (Bug#9618)
1250
6b02f655
SM
12512011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1252
1253 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1254 errors in XSetWindowBorder (bug#9310).
1255
81d40c92
DA
12562011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1257
1258 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1259 avoid crash when xmalloc overrun checking is enabled.
1260
d4172c3b
EZ
12612011-10-13 Eli Zaretskii <eliz@gnu.org>
1262
1263 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1264 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1265 cursor motion with <left> and <right> arrow keys.
1266
1267 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1268 some callers set that themselves.
1269
b00eea75
EZ
12702011-10-12 Eli Zaretskii <eliz@gnu.org>
1271
1272 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1273 display string and the previous row comes from the same string and
1274 is empty. (Bug#9739) (Bug#9738)
1275
8fe012c4
SM
12762011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1277
1278 * doc.c (get_doc_string): Encode file name (bug#9735).
1279
0074aef2
EZ
12802011-10-12 Eli Zaretskii <eliz@gnu.org>
1281
79beb178
EZ
1282 * bidi.c (bidi_level_of_next_char):
1283 * xdisp.c (get_visually_first_element): Remove old incorrect
1284 comments regarding the Unicode Line Separator character.
1285
0074aef2
EZ
1286 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1287
6e4b3fbe
DA
12882011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 * alloc.c (Fgc_status): Do not access beyond zombies array
1291 boundary if nzombies > MAX_ZOMBIES.
1292 * alloc.c (dump_zombies): Add missing format specifier.
1293
0324f3af
PE
12942011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1295
b5525cac
PE
1296 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1297 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1298
0324f3af
PE
1299 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1300 Some packages use them to denote characters with modifiers.
1301
e9b5f888
AS
13022011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1303
1304 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1305 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1306 matching a pp-number. Rename parameter var to var1.
1307
127827c0
SM
13082011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1309
1310 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1311
c8fd3bd0
GM
13122011-10-08 Glenn Morris <rgm@gnu.org>
1313
1314 * callint.c (Fcall_interactively): Give a more explicit error for the
1315 'c' case with a non-character input. (Bug#8479)
1316
352ec8ff
EZ
13172011-10-08 Eli Zaretskii <eliz@gnu.org>
1318
03669ccb
EZ
1319 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1320 lines.
7061c986
EZ
1321 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1322 lines that are hscrolled on the left.
03669ccb 1323
352ec8ff
EZ
1324 * dispnew.c (buffer_posn_from_coords): Account for a possible
1325 presence of header-line. (Bug#4426)
1326
a66cfb1c
SM
13272011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1328
6b02f655
SM
1329 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1330 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1331
7c5ee88e
PE
13322011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1335 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1336 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1337 this makes Emacs dump core during garbage collection on rare
1338 occasions. sizeof is obviously inferior to offsetof here, so
1339 stick with offsetof.
1340 (GC_POINTER_ALIGNMENT): New macro.
1341 (mark_memory): Omit 3rd (offset) arg; caller changed.
1342 Don't assume EMACS_INT alignment is the same as pointer alignment.
1343
df1bbe5b
SM
13442011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1345
1346 * keyboard.c (read_key_sequence_remapped): New var.
1347 (read_key_sequence): Compute remapping in the right buffer.
1348 (command_loop_1): Use read_key_sequence's remapping directly.
1349
51553db6
SM
13502011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1351
32c1fffd
SM
1352 * dired.c (file_name_completion): Don't expand file name.
1353 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1354 before checking file name handler.
1355
51553db6
SM
1356 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1357 they've been requested explicitly (bug#9591).
1358
b6bd1599 13592011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1360
1361 * keymap.c (Fsingle_key_description): Use make_specified_string
1362 instead of build_string to build string from push_key_description.
1363 (Bug#5193)
1364
f701dc2a
PE
13652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1366
4222c55d
PE
1367 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1368 This fixes a Y2038 bug on 64-bit hosts.
1369 * buffer.c (reset_buffer):
1370 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1371 (Fclear_buffer_auto_save_failure):
1372 Use 0, not -1, to represent an unset failure time, since time_t
1373 might not be signed.
1374
f701dc2a
PE
1375 Remove dependency on glibc malloc internals.
1376 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1377 Move back here from lisp.h, but with their new implementations.
1378 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1379 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1380 * charset.c (charset_table_init): New static var.
1381 (syms_of_charset): Use it instead of xmalloc. This removes a
1382 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1383 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1384 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1385 Move back to alloc.c.
1386 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1387 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1388
9ceebf39
JD
13892011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1390
1391 * nsterm.m (windowDidResize): Call x_set_window_size only when
1392 ns_in_resize is true. Otherwise set pixelwidth/height and
1393 call change_frame_size (Bug#9628).
1394
cb993c58
PE
13952011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1396
3930c88b
PE
1397 Port --enable-checking=all to Fedora 14 x86-64.
1398 * charset.c (syms_of_charset): Also account for glibc malloc's
1399 internal overhead when calculating the initial malloc maximum.
1400
cb993c58
PE
1401 Port --enable-checking=all to Fedora 14 x86.
1402 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1403 Move to lisp.h.
1404 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1405 (overrun_check_realloc, overrun_check_free):
1406 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1407 That way, xmalloc returns a properly-aligned pointer even if
1408 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1409 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1410 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1411 into account when calculating the initial malloc maximum.
1412 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1413 Move here from alloc.c, so that charset.c can use it too.
1414 Properly align; the old code wasn't right for common 32-bit hosts
1415 when configured with --enable-checking=all.
1416 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1417 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1418
31bed486
EZ
14192011-09-29 Eli Zaretskii <eliz@gnu.org>
1420
04c70788 1421 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1422 use EDOM.
1423
fbcaa2f3
EZ
14242011-09-28 Eli Zaretskii <eliz@gnu.org>
1425
1426 * xdisp.c (compute_display_string_end): If there's no display
1427 string at CHARPOS, return -1.
1428
1429 * bidi.c (bidi_fetch_char): When compute_display_string_end
1430 returns a negative value, treat the character as a normal
1431 character not covered by a display string. (Bug#9624)
1432
a239d4e9
JB
14332011-09-28 Juanma Barranquero <lekktu@gmail.com>
1434
1435 * lread.c (Fread_from_string): Fix typo in docstring.
1436
88652fd5
EZ
14372011-09-27 Eli Zaretskii <eliz@gnu.org>
1438
1439 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1440 newline, reseat the iterator instead of bidi-iterating there one
1441 character at a time. (Bug#9610)
32c1fffd
SM
1442 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1443 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1444
ed497dd4
AS
14452011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1446
1447 * lread.c (readevalloop): Use correct code for NBSP.
1448 (read1): Likewise. (Bug#9608)
1449
b2bf61aa
MA
14502011-09-25 Michael Albinus <michael.albinus@gmx.de>
1451
1452 * dbusbind.c (Fdbus_register_signal): When service is not
1453 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1454
32bbb17c
GM
14552011-09-25 Glenn Morris <rgm@gnu.org>
1456
1457 * buffer.c (truncate-lines): Doc fix.
1458
94e0933e
CY
14592011-09-24 Chong Yidong <cyd@stupidchicken.com>
1460
1461 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1462 (Fset_window_next_buffers): Doc fix.
1463
cddde921
GM
14642011-09-24 Glenn Morris <rgm@gnu.org>
1465
1466 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1467
1260aef1
PE
14682011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1469
25b4bfa0
PE
1470 Fix minor problems found by static checking.
1471 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1472 * indent.c (Fvertical_motion): Fix == vs = typo.
1473
e3cbd34b
EZ
14742011-09-24 Eli Zaretskii <eliz@gnu.org>
1475
a66cfb1c
SM
1476 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1477 Default value is now t. Doc fix.
6bf7006f 1478
e3cbd34b 1479 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1480 logic when moving up, not only when moving down. Fix the
e3cbd34b 1481 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1482 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1483
1484 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1485 CHARPOS is covered by a display string which includes newlines.
1486 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1487 is covered by a display string with embedded newlines.
1488
a3de0cbd
MA
14892011-09-24 Michael Albinus <michael.albinus@gmx.de>
1490
1491 * dbusbind.c (Fdbus_register_signal): Add match rule to
1492 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1493 (Fdbus_register_method, Vdbus_registered_objects_table):
1494 Fix docstring.
a3de0cbd 1495
b260039d
JM
14962011-09-24 Jim Meyering <meyering@redhat.com>
1497
32c1fffd 1498 do not ignore write error for any output size
b260039d
JM
1499 The previous change was incomplete.
1500 While it makes emacs --batch detect the vast majority of stdout
1501 write failures, errors were still ignored whenever the output size is
1502 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1503 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1504 && echo FAIL: ignored write error
1505 FAIL: ignored write error
1506 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1507 && echo FAIL: ignored write error
1508 FAIL: ignored write error
1509 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1510
8eca8a7c
AS
15112011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1512
1513 * emacs.c (Fkill_emacs): In noninteractive mode exit
1514 non-successfully if a write error occurred on stdout. (Bug#9574)
1515
3341db62
EZ
15162011-09-21 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1519 the xassert test.
1520
1521 * dispextern.h (struct it): Update the comment documenting what
1522 can it->OBJECT be.
1523
8c203dbf
EZ
15242011-09-20 Eli Zaretskii <eliz@gnu.org>
1525
1526 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1527 a display string, extend search for cursor position to end of row.
1528 (find_row_edges): If the row ends in a newline from a display
1529 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1530 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1531 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1532 non-empty line. Fixes confusing cursor motion with arrow keys at
1533 the beginning of a line that starts with whitespace.
8c203dbf 1534
a4824228
LMI
15352011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1536
1537 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1538 (bug#9493).
1539
33ed493b
CY
15402011-09-18 Chong Yidong <cyd@stupidchicken.com>
1541
1542 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1543 boolean (Bug#9154).
1544
56cd55c8
EZ
15452011-09-18 Eli Zaretskii <eliz@gnu.org>
1546
1547 * xdisp.c (display_line): Record maximum and minimum buffer
1548 positions even if no glyphs were produced (e.g., by a zero-width
1549 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1550 buffer positions that will be removed from the glyph row because
1551 they don't fit.
c02dcedf
EZ
1552 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1553 column is beyond frame width: don't subtract 1 "pixel" when
1554 computing width of the stretch.
3e62b7e0
EZ
1555 (reseat_at_next_visible_line_start): Undo the change made on
1556 2011-09-17 that saved paragraph information and restored it after
1557 the call to `reseat'. (Bug#9545)
56cd55c8 1558
5ed99d36 15592011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1560
1561 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1562 and turn window cursor on if cleared (Bug#9415).
1563
5ed99d36 15642011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1565
1566 * search.c (boyer_moore): Take unibyte characters from pattern
1567 literally. (Bug#9458)
1568
9bade7b2
EZ
15692011-09-18 Eli Zaretskii <eliz@gnu.org>
1570
1571 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1572
e5e9d610
PE
15732011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1574
87e4427a
PE
1575 Fix minor problem found by static checking.
1576 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1577 initialized, to pacify gcc -Wuninitialized.
1578
e5e9d610
PE
1579 * fileio.c: Report proper errno when syscall falls.
1580 (Finsert_file_contents): Save and restore errno,
1581 so that report_file_error outputs the correct diagnostic.
1582 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1583
a1674f0b
EZ
15842011-09-18 Eli Zaretskii <eliz@gnu.org>
1585
1586 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1587
fbfb6dd4
EZ
15882011-09-17 Eli Zaretskii <eliz@gnu.org>
1589
1590 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1591 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1592
bb187662
EZ
15932011-09-17 Eli Zaretskii <eliz@gnu.org>
1594
1137e8b8 1595 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1596 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1597
1598 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1599 (bidi_find_paragraph_start): Search back for paragraph beginning
1600 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1601 (bidi_move_to_visually_next): Only trigger paragraph-related
1602 computations when the last character is a newline or at EOB, not
1603 just any NEUTRAL_B. (Bug#9470)
1604
bb187662
EZ
1605 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1606 truncated lines if point is covered by a display string. (Bug#9524)
1607
2e621251
PE
16082011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1609
1610 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1611 (cons_to_x_long): New function.
1612 (lisp_data_to_selection_data): Use it. Correct the test for
1613 short-versus-long data; it was negated. Break out of vector
1614 loop, for efficiency, when a long datum is discovered.
1615
91a15bc6
SM
16162011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1617
1618 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1619
b41c3a35
EZ
16202011-09-16 Eli Zaretskii <eliz@gnu.org>
1621
1622 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1623 GCC PR/17406) by declaring this function with external scope.
1624
7812ba2d
PE
16252011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1628 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1629
cf7edc2a
AS
16302011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1631
1632 * editfns.c (Fformat): Correctly handle text properties on "%%".
1633
bd01620e
EZ
16342011-09-15 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xterm.c (x_draw_composite_glyph_string_foreground):
1637 * w32term.c (x_draw_composite_glyph_string_foreground):
1638 * term.c (encode_terminal_code):
1639 * composite.c (composition_update_it, get_composition_id):
1640 * xdisp.c (get_next_display_element)
1641 (fill_composite_glyph_string): Add comments about special meaning
1642 of TAB characters in a composition.
1643
a02719a3
PE
16442011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1647 This occurs when processing a multibyte format.
1648 Problem reported by Wolfgang Jenker.
a02719a3 1649
72589a3c
JB
16502011-09-15 Johan Bockgård <bojohan@gnu.org>
1651
1652 * xdisp.c (try_cursor_movement): Only check for exact match if
1653 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1654
1c14176c
PE
16552011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 Remove unused external symbols.
1658 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1659 * xdisp.c (calc_pixel_width_or_height): Now static.
1660 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1661 * indent.c (check_display_width):
1662 * w32term.c: Fix comment to match code.
1663 * xterm.c, xterm.h (x_catching_errors): Remove.
1664
d2eea5b5
PE
16652011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 * xselect.c: Use signed conversions more consistently (Bug#9498).
1668 (selection_data_to_lisp_data): Assume incoming selection data are
1669 signed integers, not unsigned. This is to be consistent with
1670 outgoing selection data, which was modified to use signed integers
1671 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1672 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1673 expects long, not unsigned long.
1674
46888499
EZ
16752011-09-14 Eli Zaretskii <eliz@gnu.org>
1676
1677 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1678 computation of loop end. Reported by Johan Bockgård
1679 <bojohan@gnu.org>.
1680
ef8ef9fb
CY
16812011-09-13 Chong Yidong <cyd@stupidchicken.com>
1682
1683 * frame.c (Fother_visible_frames_p): Function deleted.
1684
fa819fed
EZ
16852011-09-12 Eli Zaretskii <eliz@gnu.org>
1686
1687 * indent.c (compute_motion): Process display vector front to back
1688 rather than the other way around. (Bug#2496)
1689
2ba8e008
SM
16902011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1691
1692 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1693
20f53c69
CY
16942011-09-11 Chong Yidong <cyd@stupidchicken.com>
1695
1696 * minibuf.c (Fread_from_minibuffer): Doc fix.
1697
d562d7a4
EZ
16982011-09-11 Eli Zaretskii <eliz@gnu.org>
1699
1700 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1701 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1702
1c4d7f3d
LMI
17032011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1704
1705 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1706 value for non-existent files.
1707
b885bf36
EZ
17082011-09-11 Eli Zaretskii <eliz@gnu.org>
1709
1710 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1711 set its "size" to -1. This will set the modtime_size field of
1712 the corresponding buffer to -1, which is what
1713 verify-visited-file-modtime expects for files that do not exist.
1714 (Bug#9139)
1715
6612f0bf
PE
17162011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1719 here ...
1720 * lisp.h: ... from here. push_key_description is no longer
1721 defined in keyboard.c, so its declaration should not be in
1722 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1723 logically belongs with push_key_description.
1724
dfb3f755
PE
17252011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1726
1727 * buffer.h: Include <sys/types.h> instead of <time.h>.
1728 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1729 Problem reported by Herbert J. Skuhra.
1730
3134906c
LMI
17312011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1732
1733 * xml.c (parse_region): Make the parsing work for
1734 non-comment-starting XML files again (bug#9144).
1735
8d903f4e
AS
17362011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1737
1738 * image.c (gif_load): Fix calculation of bottom and right corner.
1739 (Bug#9468)
1740
80ad64f4
EZ
17412011-09-10 Eli Zaretskii <eliz@gnu.org>
1742
1743 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1744 redisplay in small windows.
1745
208a048d
EZ
17462011-09-09 Eli Zaretskii <eliz@gnu.org>
1747
1748 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1749
9b1c252e
MR
17502011-09-08 Martin Rudalics <rudalics@gmx.at>
1751
1752 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1753 Operate on live windows only.
1754
2949f33b
JB
17552011-09-08 Juanma Barranquero <lekktu@gmail.com>
1756
1757 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1758
e08dcafd
EZ
17592011-09-07 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1762 only under bidi iteration.
1763
115b96bd
JD
17642011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1765
1766 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1767
c8199d0f
PE
17682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1771 Without this fix, the command to link temacs failed due to an
1772 undefined symbol __builtin_isnan. This is because
1773 /usr/include/iso/math_c99.h #defines isnan(x) to
1774 __builtin_isnan(x), but the bundled gcc, which identifies itself
1775 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1776 a __builtin_isnan.
1777 * floatfns.c (isnan): #undef, and then #define to a clone of
1778 what's in data.c.
1779 (Fisnan): Always define, since it's always available now.
1780 (syms_of_floatfns): Always define isnan at the Lisp level.
1781
e39b275c 17822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1783
1784 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1785
b2db44d9 17862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1787
f4af5137 1788 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1789 The previous code assumed that file offsets (off_t values) fit in
1790 EMACS_INT variables, which is not true on typical 32-bit hosts.
1791 The code messed up by falsely reporting buffer overflow in cases
1792 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1793 when "big" contains more than 2**29 bytes, even though this
1794 inserts just one byte and does not overflow the buffer.
1795 (Finsert_file_contents): Store file offsets as off_t
1796 values, not as EMACS_INT values. Check for overflow when
1797 converting between EMACS_INT and off_t. When checking for
1798 buffer overflow or for overlap, take the offsets into account.
1799 Don't use EMACS_INT for small values where int suffices.
1800 When checking for overlap, fix a typo: ZV was used where
1801 ZV_BYTE was intended.
1802 (Fwrite_region): Don't assume off_t fits into 'long'.
1803 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1804
ecfc0a49
MA
18052011-09-05 Michael Albinus <michael.albinus@gmx.de>
1806
1807 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1808
6511acf2 18092011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1810
0999621a 1811 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1812
1813 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1814 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1815 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1816 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1817 (modify_event_symbol): Do not assume that the length of
1818 name_alist_or_stem is safe to alloca and fits in int.
1819 (Fexecute_extended_command): Likewise for function name and binding.
1820 (Frecursion_depth): Wrap around reliably on integer overflow.
1821 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1822 since some callers pass EMACS_INT values.
1823 (Fsingle_key_description): Don't crash if symbol name contains more
1824 than MAX_ALLOCA bytes.
1825 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1826 (get_minibuffer): Arg is now EMACS_INT, not int.
1827 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1828 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1829 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1830
2be7d702
PE
1831 * dbusbind.c (signature_cat): New function.
1832 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1833 Do not overrun buffer; instead, report string overflow.
1834
9d1df220
PE
1835 * dispnew.c (add_window_display_history): Don't overrun buffer.
1836 Truncate instead; this is OK since it's just a log.
1837
33ef5c64
PE
1838 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1839 even if the time zone offset is outlandishly large.
1840 Don't mishandle offset == INT_MIN.
1841
66c6fdd5
PE
1842 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1843 when creating daemon; the previous buffer-overflow check was incorrect.
1844
d749b01b
PE
1845 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1846 which has the guts of the old verror function.
1847
b5cd1905
PE
1848 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1849 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1850
6e1a67fb
PE
1851 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1852 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1853 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1854 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1855 length of string rather than counting it via multiple sprintfs;
1856 that's simpler and more reliable.
c21721cc
PE
1857 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1858 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1859 sprintf, in case result does not fit in int.
1860
c57b67fc
PE
1861 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1862 (fontset_from_font): Print it.
1863
8a401434
PE
1864 * frame.c (tty_frame_count): Now printmax_t, not int.
1865 (make_terminal_frame, set_term_frame_name): Print it.
1866 (x_report_frame_params): In X, window IDs are unsigned long,
1867 not signed long, so print them as unsigned.
1868 (validate_x_resource_name): Check for implausibly long names,
1869 and don't assume name length fits in 'int'.
1870 (x_get_resource_string): Don't blindly alloca invocation name;
1871 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1872 not fit in int.
1873
6e1a67fb
PE
1874 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1875 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1876 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1877
0df02bf3
PE
1878 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1879 Use esprintf, not sprintf, in case result does not fit in int.
1880
48e30793
PE
1881 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1882 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1883 it as a large positive number.
1884 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1885 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1886
a66ff6d8
PE
1887 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1888 in case result does not fit in int.
1889
aca216ff
PE
1890 * print.c (float_to_string): Detect width overflow more reliably.
1891 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1892 buffer overrun. Don't assume list length fits in 'int'. Treat
1893 print length of 0 as 0, not as infinity; to be consistent with other
1894 uses of print length in this function. Don't overflow print length
1895 index. Don't assume hash table size fits in 'long', or that
1896 vectorlike size fits in 'unsigned long'.
1897
31c286f7
PE
1898 * process.c (make_process): Use printmax_t, not int, to format
1899 process-name gensyms.
1900
55e5faa1
PE
1901 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1902
80f2e268
PE
1903 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1904 to avoid potential buffer overrun.
1905
670741ab
PE
1906 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1907 if X resource line is longer than 512 bytes.
1908
b7163a50
PE
1909 * xfns.c (x_window): Make sprintf buffer a bit bigger
1910 to avoid potential buffer overrun.
1911
ae58ff1f
PE
1912 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1913
c43c8a6a
PE
1914 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1915
3f8236f4
PE
19162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1917
53e9fe90 1918 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1919 Without these, Emacs silently mishandles large integers sometimes.
1920 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1921 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1922
6511acf2
PE
1923 * xdisp.c (try_window_id): Check Emacs fixnum range before
1924 converting to 'int'.
806add1d 1925
6511acf2 1926 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1927 Check that an Emacs fixnum is in range before assigning it to 'int'.
1928 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1929 values converted from Emacs fixnums.
1930 (Frecenter): Don't wrap around a line count if it is out of 'int'
1931 range; instead, treat it as an extreme value.
1932 (Fset_window_configuration, compare_window_configurations):
1933 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1934
6511acf2
PE
1935 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1936 that can exceed INT_MAX. Check that EMACS_INT value is in range
1937 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1938 (match_limit): Don't assume that a fixnum can fit in 'int'.
1939
6511acf2 1940 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1941 exceed INT_MAX.
1942
6511acf2 1943 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1944 (Fvertical_motion): Don't wrap around LINES values that don't fit
1945 in 'int'. Instead, treat them as extreme values. This is good
1946 enough for windows, which can't have more than INT_MAX lines anyway.
1947
fcb901a7
LMI
19482011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1949
0f2f6b6d
LMI
1950 * Require libxml/parser.h to avoid compilation warning.
1951
fcb901a7
LMI
1952 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1953
1954 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1955 since this reportedly can destroy thread storage.
1956
6e20a0d4
CY
19572011-08-30 Chong Yidong <cyd@stupidchicken.com>
1958
1959 * syntax.c (find_defun_start): Update all cache variables if
1960 exiting early (Bug#9401).
1961
148ae00e
EZ
19622011-08-30 Eli Zaretskii <eliz@gnu.org>
1963
f6cfbd8f
EZ
1964 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1965
148ae00e
EZ
1966 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1967 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1968 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1969
1970 * term.c (tty_append_glyph): New function.
1971 (produce_stretch_glyph): Static function and its prototype deleted.
1972
a66cfb1c
SM
1973 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1974 Add prototypes.
148ae00e 1975
c4a07a4c
PE
19762011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1979 when checking :margin (Bug#9390).
1980 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1981 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1982 so that the name doesn't mislead. All uses changed.
1983
6bc8cd65
JB
19842011-08-28 Johan Bockgård <bojohan@gnu.org>
1985
1986 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1987 set_tty_hooks.
1988
dca4927e
EZ
19892011-08-27 Eli Zaretskii <eliz@gnu.org>
1990
1991 * xdisp.c (move_it_to): Don't bail out early when reaching
1992 position beyond to_charpos, if we are scanning backwards.
1993 (move_it_vertically_backward): When DY == 0, make sure we get to
1994 the first character in the line after the newline.
1995
f2cad773
PE
19962011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1997
1998 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1999 (ccl_driver): Do not generate an out-of-range pointer.
2000 (Fccl_execute_on_string): Remove unnecessary check for
2001 integer overflow, noted by Stefan Monnier in
2002 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2003 Remove a FIXME that didn't need fixing.
2004 Simplify the newly-introduced buffer reallocation code.
2005
0cae2cdb
JB
20062011-08-27 Juanma Barranquero <lekktu@gmail.com>
2007
2008 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2009
5fc295a4 20102011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2011
70c60eb2 2012 Integer and memory overflow issues (Bug#9196).
726e0ab1 2013
d31850da
PE
2014 * doc.c (get_doc_string): Rework so that
2015 get_doc_string_buffer_size is the actual buffer size, rather than
2016 being 1 less than the actual buffer size; this makes xpalloc more
2017 convenient.
2018
a69fbedb
PE
2019 * image.c (x_allocate_bitmap_record, cache_image):
2020 * xselect.c (Fx_register_dnd_atom):
2021 Simplify previous changes by using xpalloc.
2022
fe5c5d37
PE
2023 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2024 since either will do and ptrdiff_t is convenient with xpalloc.
2025
0065d054
PE
2026 * charset.c (charset_table_size)
2027 (struct charset_sort_data.priority): Now ptrdiff_t.
2028 (charset_compare): Don't overflow if priorities differ greatly.
2029 (Fsort_charsets): Don't assume list length fits in int.
2030 Check for size-calculation overflow when allocating sort data.
2031 (syms_of_charset): Allocate an initial charset table that is
2032 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2033
2034 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2035
2036 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2037 The actual value is always <= INT_MAX, and leaving it unsigned made
2038 overflow checking harder.
2039
2040 * dispextern.h (struct glyph_matrix.rows_allocated)
2041 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2042 with xpalloc. The values are still always <= INT_MAX.
2043
2044 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2045
2046 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2047 (SAFE_NALLOCA): New macro.
2048
2049 * region-cache.c (struct boundary.pos, find_cache_boundary)
2050 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2051 (set_cache_region, invalidate_region_cache)
2052 (revalidate_region_cache, know_region_cache, region_cache_forward)
2053 (region_cache_backward, pp_cache):
2054 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2055 so that ptrdiff_t * can be passed to xpalloc.
2056 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2057 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2058 (pp_cache): Don't assume cache_len fits in int.
2059 * region-cache.h: Adjust extern decls to match.
2060
2061 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2062 EMACS_INT, since either will do, for xpalloc.
2063
2064 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2065 (xnmalloc, xnrealloc, xpalloc): New functions.
2066
726e0ab1
PE
2067 * bidi.c (bidi_shelve_header_size): New constant.
2068 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2069 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2070
51f30bc5 2071 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2072 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2073 (overlay_strings):
2074 Don't update size of array until after memory allocation succeeds,
2075 because xmalloc/xrealloc may not return.
0065d054
PE
2076 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2077 now that we have proper integer overflow checking.
2078 (record_overlay_string, overlay_strings): Catch overflows when
2079 calculating size of overlay_str_buf.
726e0ab1 2080
0065d054
PE
2081 * callproc.c (Fcall_process): Check for size overflow when
2082 calculating size of args2.
2083 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2084 Normally we prefer signed values, but sticking with ptrdiff_t would
2085 require adding more-complicated checks.
726e0ab1
PE
2086
2087 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2088 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2089 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2090 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2091
2092 * character.c (Fstring): Check for size-calculation overflow.
2093
2094 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2095 unnecessary integer overflow. Check for size overflow.
2096 (encode_coding_object): Don't update size until xmalloc succeeds.
2097
2098 * composite.c (get_composition_id): Check for overflow in glyph
2099 length calculations.
2100
2101 Integer and memory overflow fixes for display code.
2102 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2103 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2104 (scrolling_window): Check for overflow in size calculations.
2105 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2106 Don't assume glyph table len fits in int.
2107 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2108 (row_table_size): Now ptrdiff_t, not int.
2109 (scrolling_window): Avoid overflow in size calculations.
2110 Don't update size until allocation succeeds.
2111 * fns.c (concat): Check for overflow in size calculations.
2112 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2113 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2114 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2115
2116 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2117 (get_doc_string): Check for size calculation overflow.
2118 Don't update size until allocation succeeds.
2119 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2120 EMACS_INT, where ptrdiff_t will do.
2121 (Fsubstitute_command_keys): Check for string overflow.
2122
2123 * editfns.c (set_time_zone_rule): Don't assume environment length
2124 fits in int.
2125 (message_length): Now ptrdiff_t, not int.
2126 (Fmessage_box): Don't update size until allocation succeeds.
2127 Don't assume message length fits in int.
2128 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2129
0065d054
PE
2130 * emacs.c (main): Do not reallocate argv, since there is a null at
2131 the end that can be overwritten, and this way there's no need to
2132 worry about size-calculation overflow.
2133 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2134
2135 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2136 alloc succeeds.
2137 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2138
2139 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2140 (x_set_scroll_bar_width, x_figure_window_size):
2141 Check for integer overflow.
2142 (x_set_alpha): Do not assume XINT fits in int.
2143
2144 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2145 This is for the members text_lines, text_cols, total_lines, total_cols,
2146 where the system imposes an 'int' limit.
2147
2148 * fringe.c (Fdefine_fringe_bitmap):
2149 Don't update size until alloc works.
2150
2151 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2152 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2153
2154 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2155 Check for size-calculation overflow.
2156 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2157 do, as we prefer signed integers.
2158 (id_to_widget.max_size, id_to_widget.used)
2159 (xg_store_widget_in_map, xg_remove_widget_from_map)
2160 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2161 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2162 Use and return ptrdiff_t, not int.
2163 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2164 * gtkutil.h: Change prototypes to match the above.
2165
2166 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2167 are duplicate now that they've been promoted to lisp.h.
2168 (x_allocate_bitmap_record, x_alloc_image_color)
2169 (make_image_cache, cache_image, xpm_load):
2170 Don't update size until alloc is done.
2171 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2172 (x_detect_edges):
3256efce 2173 Check for size calculation overflow.
726e0ab1
PE
2174 (ct_colors_allocated_max): New constant.
2175 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2176 overflow.
3256efce 2177
726e0ab1
PE
2178 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2179 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2180 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2181 Use ptrdiff_t, not int, to count maps.
2182 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2183 calculations. Don't update size until allocation succeeds.
2184 Redo calculations to avoid overflow.
726e0ab1
PE
2185 * keyboard.h: Change prototypes to match the above.
2186
2187 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2188 to count maps.
2189 (current_minor_maps): Check for size calculation overflow.
2190 * keymap.h: Change prototypes to match the above.
2191
2192 * lread.c (read1, init_obarray): Don't update size until alloc done.
2193
2194 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2195 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2196
726e0ab1
PE
2197 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2198 Now ptrdiff_t, not int.
2199 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2200 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2201
2202 * process.c (Fnetwork_interface_list): Check for overflow
2203 in size calculation.
2204
2205 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2206
2207 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2208 overflow. Don't bother calling xmalloc when xrealloc will do.
2209
2210 * search.c (Freplace_match): Check for size calculation overflow.
2211 (Fset_match_data): Don't assume list lengths fit in 'int'.
2212
2213 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2214 for command line length. Do not attempt to address one before the
2215 beginning of an array, as that's not portable.
2216
2217 * term.c (max_frame_lines): Remove; unused.
2218 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2219 not int.
2220 (encode_terminal_code, calculate_costs): Check for size
2221 calculation overflow.
2222 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2223 table lengths and related sizes. Don't update size until alloc
2224 done. Redo calculations to avoid overflow.
2225 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2226
2227 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2228 subtracting pointers.
2229 (gobble_line): Check for overflow more carefully. Don't update size
2230 until alloc done.
2231
2232 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2233 Don't update size until alloc done.
2234 Redo size calculations to avoid overflow.
2235 Check for size calculation overflow.
0065d054 2236 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2237
2238 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2239 Use ptrdiff_t, not int, for sizes.
2240 (store_mode_line_noprop_char): Don't update size until alloc done.
2241
0065d054
PE
2242 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2243 Use ptrdiff_t, not int, for sizes.
2244 (Finternal_make_lisp_face, cache_face):
2245 Check for size calculation overflow.
2246 (cache_face): Treat size calculation overflows as if they were
2247 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2248
2249 * xfns.c (x_encode_text, x_set_name_internal)
2250 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2251 sizes, since they can exceed INT_MAX in size. Check for size
2252 calculation overflow.
2253
0065d054
PE
2254 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2255 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2256 Don't update size until alloc done.
2257
0065d054 2258 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2259 as sprintf is limited to int lengths.
1d526e2f 2260
252c5ee1
PE
2261 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2262 (X_LONG_MIN): New macros.
864d7ce7
PE
2263 Use them to make the following changes clearer.
2264 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2265 This change doesn't affect the value now, but it may help remind
2266 future maintainers not to raise the value too much later.
2267 (SELECTION_QUANTUM): Remove, replacing with ...
2268 (selection_quantum): ... new function, which avoids overflow.
2269 All uses changed.
2270 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2271 assumption that selection length fits in 'int'.
2272 (x_reply_selection_request, x_handle_selection_request)
2273 (x_get_window_property, receive_incremental_selection)
2274 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2275 (lisp_data_to_selection_data, clean_local_selection_data):
2276 Use ptrdiff_t, not int, to record length of selection.
2277 (x_reply_selection_request, x_get_window_property)
2278 (receive_incremental_selection, x_property_data_to_lisp):
2279 Redo calculations to avoid overflow.
2280 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2281 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2282 something.
2283 (x_get_window_property, receive_incremental_selection)
2284 (lisp_data_to_selection_data, x_property_data_to_lisp):
2285 Check for size-calculation overflow.
2286 (x_get_window_property, receive_incremental_selection)
2287 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2288 Don't store size until memory allocation succeeds.
2289 (x_get_window_property): Plug memory leak on memory exhaustion.
2290 Don't double-block input; malloc is safe here. Don't assume 2**34
2291 - 4 fits in unsigned long. Add an xassert to check
2292 XGetWindowProperty overflow. Be more careful about overflow
2293 calculations, and distinguish size from memory overflow better.
2294 (receive_incremental_selection): When tracing, don't assume
2295 unsigned int is less than INT_MAX.
2296 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2297 harmful) conversions of unsigned short to int.
2298 (lisp_data_to_selection_data): Don't assume that integers
2299 in the range -65535 through -1 fit in an X unsigned short.
2300 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2301 result parameters unless successful. Rely on cons_to_unsigned
2302 to report problems with elements; the old code wasn't right anyway.
2303 (x_check_property_data): Check for int overflow; we cannot use
2304 a wider type due to X limits.
2305 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2306
726e0ab1 2307 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2308
0065d054
PE
2309 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2310 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2311 (x_color_cells): Don't store size until memory allocation succeeds.
2312 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2313 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2314 (x_term_init): Don't assume length fits in int (sprintf is limited
2315 to int size).
bc18e09d 2316
ebfa62c0
PE
2317 Use ptrdiff_t for composition IDs.
2318 * character.c (lisp_string_width):
2319 * composite.c (composition_table_size, n_compositions)
2320 (get_composition_id, composition_gstring_from_id):
2321 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2322 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2323 * window.c (Frecenter):
2324 Use ptrdiff_t, not int, for composition IDs.
2325 * composite.c (get_composition_id): Check for integer overflow.
2326 * composite.h: Adjust prototypes to match the above changes.
2327
d3411f89
PE
2328 Use ptrdiff_t for hash table indexes.
2329 * category.c (hash_get_category_set):
2330 * ccl.c (ccl_driver):
2331 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2332 * coding.c (coding_system_charset_list, detect_coding_system):
2333 * coding.h (struct coding_system.id):
2334 * composite.c (get_composition_id, gstring_lookup_cache):
2335 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2336 * image.c (xpm_get_color_table_h):
2337 * lisp.h (hash_lookup, hash_put):
2338 * minibuf.c (Ftest_completion):
2339 Use ptrdiff_t for hash table indexes, not int (which is too
2340 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2341 32-bit --with-wide-int hosts).
2342
e097a6fa
PE
2343 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2344 Add a FIXME comment about memory leaks.
2345 (syms_of_charset): Don't assume xmalloc returns.
2346
5637687f
PE
2347 Don't assume that stated character widths fit in int.
2348 * character.c (Fchar_width, c_string_width, lisp_string_width):
2349 * character.h (CHAR_WIDTH):
2350 * indent.c (MULTIBYTE_BYTES_WIDTH):
2351 Use sanitize_char_width to avoid undefined and/or bad behavior
2352 with outlandish widths.
a66cfb1c 2353 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2354 now that we have two such functions. All uses changed.
2355 (sanitize_char_width): New inline function.
2356
a2271ba2
PE
2357 Don't assume that tab-width fits in int.
2358 * character.h (sanitize_width): New inline function.
2359 (SANE_TAB_WIDTH): New macro.
2360 (ASCII_CHAR_WIDTH): Use it.
2361 * indent.c (sane_tab_width): Remove. All uses replaced by
2362 SANE_TAB_WIDTH (current_buffer).
2363 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2364
18c52557
PE
2365 * fileio.c: Integer overflow issues with file modes.
2366 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2367
caeeedc1
PE
2368 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2369 Remove unreachable code.
2370 (read_hex, load_charset_map_from_file): Check for integer overflow.
2371
50849c52
PE
2372 * xterm.c: don't go over XClientMessageEvent limit
2373 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2374 (x_send_scroll_bar_event): Likewise. Check that the size does not
2375 exceed limits imposed by XClientMessageEvent, as well as the usual
2376 ptrdiff_t and size_t limits.
2377
b13995db
PE
2378 * keyboard.c: Overflow, signedness and related fixes.
2379 (make_lispy_movement): Use same integer type in forward decl
2380 that is used in the definition.
2381 (read_key_sequence, keyremap_step):
2382 Change bufsize argument back to int, undoing my 2011-03-30 change.
2383 We prefer signed types, and int is wide enough here.
2384 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2385 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2386 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2387 length, not size_t. Use ptrdiff_t for index, not int.
2388 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2389 possibility of integer overflow.
2390
13464394
PE
2391 Overflow, signedness and related fixes for images.
2392
2393 * dispextern.h (struct it.stack[0].u.image.image_id)
2394 (struct_it.image_id, struct image.id, struct image_cache.size)
2395 (struct image_cache.used, struct image_cache.ref_count):
2396 * gtkutil.c (update_frame_tool_bar):
2397 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2398 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2399 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2400 * nsmenu.m (update_frame_tool_bar):
2401 * xdisp.c (calc_pixel_width_or_height):
2402 * xfns.c (image_cache_refcount):
2403 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2404 on typical 64-bit hosts.
2405
2406 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2407 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2408 Omit unnecessary casts to int.
2409 (parse_image_spec): Check that integers fall into 'int' range
2410 when the callers expect that.
2411 (image_ascent): Redo ascent calculation to avoid int overflow.
2412 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2413 (lookup_image): Remove unnecessary tests.
2414 (xbm_image_p): Locals are now of int, not EMACS_INT,
2415 since parse_image_check makes sure they fit into int.
2416 (png_load, gif_load, svg_load_image):
2417 Prefer int to unsigned where either will do.
2418 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2419 old tiff_error_handler and tiff_warning_handler.
2420 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2421 stack buffer overflows. It uses only the features of vsnprintf
2422 that are common to both POSIX and native Microsoft.
2423 (tiff_error_handler, tiff_warning_handler): Use it.
2424 (tiff_load, gif_load, imagemagick_load_image):
2425 Don't assume :index value fits in 'int'.
2426 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2427 (imagemagick_load_image): Check that crop parameters fit into
2428 the integer types that MagickCropImage accepts. Don't assume
2429 Vimagemagick_render_type has a nonnegative value. Don't assume
2430 size_t fits in 'long'.
2431 (gs_load): Use printmax_t to print the widest integers possible.
2432 Check for integer overflow when computing image height and width.
2433
c11821d4
EZ
24342011-08-26 Eli Zaretskii <eliz@gnu.org>
2435
2436 * xdisp.c (redisplay_window): Don't force window start if point
2437 will be invisible in the resulting window. (Bug#9324)
2438
0c95fcf7
EZ
24392011-08-25 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2442 the display spec is of the form `(space ...)'.
2443 (handle_display_spec): Return the value returned by
2444 handle_single_display_spec, not just 1 or zero.
2445 (handle_single_display_spec): If the display spec is of the form
2446 `(space ...)', and specifies display in the text area, return 2
2447 rather than 1.
fee65a97 2448 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2449 accurately, and prefer exact match for point under bidi.
2450 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2451
2452 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2453 into disp_prop; all users changed.
2454
2455 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2456 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2457 for the text covered by the display property.
2458
e4ed06f1
CY
24592011-08-25 Chong Yidong <cyd@stupidchicken.com>
2460
2461 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2462 Change return value to nil.
2463 (Frecord_buffer): Delete unused function.
2464
f67cdd7f
EZ
24652011-08-24 Eli Zaretskii <eliz@gnu.org>
2466
5980d4c6
EZ
2467 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2468 buffers, return left-to-right.
8610fe8b
EZ
2469 (set_cursor_from_row): Consider candidate row a win if its glyph
2470 represents a newline and point is on that newline. Fixes cursor
2471 positioning on the newline at EOL of R2L text within L2R
2472 paragraph, and vice versa.
2473 (try_cursor_movement): Check continued rows, in addition to
2474 continuation rows. Fixes unwarranted scroll when point enters a
2475 continued line of R2L text within an L2R paragraph, or vice versa.
2476 (cursor_row_p): Consider the case of point being equal to
2477 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2478 from the end of a short line to the beginning of a continued line
2479 of R2L text within L2R paragraph.
2480 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2481 composed characters.
5980d4c6 2482
f67cdd7f
EZ
2483 * bidi.c (bidi_check_type): Use xassert.
2484 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2485 members.
2486
bca633fb
EZ
24872011-08-23 Eli Zaretskii <eliz@gnu.org>
2488
2489 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2490 a character.
2491
4a5885a7
CY
24922011-08-23 Chong Yidong <cyd@stupidchicken.com>
2493
2494 * nsfont.m (ns_otf_to_script): Fix typo.
2495
0902a04e
KH
24962011-08-22 Kenichi Handa <handa@m17n.org>
2497
2498 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2499 extra slot even if the purpose is char-code-property-table.
2500
1a2e6670
EZ
25012011-08-23 Eli Zaretskii <eliz@gnu.org>
2502
8ddde651
EZ
2503 * xdisp.c (redisplay_window): When computing centering_position,
2504 account for the height of the header line. (Bug#8874)
2505
425cc014
EZ
2506 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2507 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2508 candidate is selected by the mouse, and that candidate has a
2509 composed character under the mouse.
2510
1a2e6670
EZ
2511 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2512 coordinates reported by pos-visible-in-window-p for a composed
2513 character in column zero.
2514
8b76d6f8
SM
25152011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2516
2517 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2518
dac347dd
EZ
25192011-08-22 Eli Zaretskii <eliz@gnu.org>
2520
2521 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2522 consider it a hit if to_charpos is anywhere in the range of the
2523 composed buffer positions.
2524
e013fb34
CY
25252011-08-22 Chong Yidong <cyd@stupidchicken.com>
2526
2527 * image.c (gif_load): Don't assume that each subimage has the same
2528 dimensions as the base image. Handle disposal method that is
2529 "undefined" by the gif spec (Bug#9335).
2530
bd1ba3e8
CY
25312011-08-20 Chong Yidong <cyd@stupidchicken.com>
2532
2533 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2534 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2535
54a1215b
EZ
25362011-08-19 Eli Zaretskii <eliz@gnu.org>
2537
823564e5
EZ
2538 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2539 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2540 from an Org mode buffer to a Speedbar frame.
2541
54a1215b
EZ
2542 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2543 a composition, take its buffer position from IT->cmp_it.charpos.
2544 Fixes cursor positioning at the beginning of a line that begins
2545 with a composed character.
2546
9778ebcc
EZ
25472011-08-18 Eli Zaretskii <eliz@gnu.org>
2548
0be6ee06
EZ
2549 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2550 character bidirectional type, use STRONG_L instead. Fixes crashes
2551 in a buffer produced by `describe-categories'.
2552
9778ebcc
EZ
2553 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2554 members before the level stack, so they would be saved and
2555 restored when copying iterator state. Fixes incorrect reordering
2556 around TABs covered by display properties.
2557
156bffbe
AS
25582011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2559
6b02f655 2560 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2561
72ad093b
CY
25622011-08-17 Chong Yidong <cyd@stupidchicken.com>
2563
2564 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2565 (internal_condition_case_2, internal_condition_case_n):
2566 Remove unnecessary aborts (Bug#9081).
72ad093b 2567
35774242
EZ
25682011-08-17 Eli Zaretskii <eliz@gnu.org>
2569
2570 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2571 has no `load' handler, try opening the file locally. (Bug#9311)
2572
db76dd85
KB
25732011-08-16 Ken Brown <kbrown@cornell.edu>
2574
2575 * gmalloc.c: Expand comment.
2576
b215eee5
EZ
25772011-08-16 Eli Zaretskii <eliz@gnu.org>
2578
2579 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2580 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2581
a4579d33
KB
25822011-08-16 Ken Brown <kbrown@cornell.edu>
2583
2584 Fix memory allocation problems in Cygwin build (Bug#9273).
2585
2586 * unexcw.c ( __malloc_initialized): Declare external variable.
2587 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2588
8b76d6f8
SM
2589 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2590 New variables.
a4579d33
KB
2591 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2592 dumped emacs.
2593 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2594 in the static heap.
2595 [CYGWIN] (special_realloc): New function.
2596 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2597 requests to realloc storage in the static heap.
2598
3ebec551
PE
25992011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * bidi.c (bidi_initialize): Remove unused local.
2602
9fd8be00
EZ
26032011-08-15 Eli Zaretskii <eliz@gnu.org>
2604
6b02f655
SM
2605 * bidimirror.h:
2606 * biditype.h: Remove file.
2607 * makefile.w32-in ($(BLD)/bidi.$(O)):
2608 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2609
2610 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2611
2612 * chartab.c: Improve commentary for the uniprop_table API.
2613
32413314
EZ
2614 * bidi.c (bidi_paragraph_init): Support zero value of
2615 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2616 (bidi_initialize): Use uniprop_table instead of including
2617 biditype.h and bidimirror.h.
32413314 2618
9fd8be00
EZ
2619 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2620 coordinates of the iterator when restoring from ppos_it.
2621 (Bug#9296)
2622
5cf2b69b
KH
26232011-08-14 Kenichi Handa <handa@m17n.org>
2624
2625 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2626 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2627
daf17d00
EZ
26282011-08-14 Eli Zaretskii <eliz@gnu.org>
2629
2630 * xdisp.c (move_it_in_display_line_to): Don't invoke
2631 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2632 ppos_it. Fixes vertical cursor motion when line beginning is
2633 covered by an image. (Bug#9296)
2634
08e3161a
JD
26352011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2636
2637 * nsterm.h (ns_run_ascript): Declare.
2638 (NSAPP_DATA2_RUNASSCRIPT): Define.
2639
2640 * nsfns.m (as_script, as_result, as_status): New static variables.
2641 (ns_run_ascript): New function.
5e617bc2 2642 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2643 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2644 the event loop. Get status from as_status (Bug#7276).
2645
2646 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2647 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2648 the event loop (Bug#7276).
2649
a3720aa2
AS
26502011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2651
2652 * gnutls.c (QCgnutls_bootprop_priority)
2653 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2654 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2655 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2656 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2657 (QCgnutls_bootprop_verify_hostname_error)
2658 (QCgnutls_bootprop_callbacks_verify): Rename from
2659 Qgnutls_bootprop_..., all uses changed.
2660
2661 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2662 uses changed.
2663
0a0d27fb
PE
26642011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2665
19d5c50c
PE
2666 * xfaces.c (Qframe_set_background_mode): Now static.
2667 * dispextern.h (Qframe_set_background_mode): Remove decl.
2668
0a0d27fb
PE
2669 * process.c (Fnetwork_interface_info): Declare local only if needed.
2670
377538cb
JD
26712011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2672
2673 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2674 (Fnetwork_interface_list): Allocate in increments of bytes instead
2675 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2676 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2677 sockaddr.
2678 (struct ifflag_def): notrailers is smart on OSX.
2679 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2680 Get hardware address with getifaddrs if available.
2681
08fff70c
EZ
26822011-08-12 Eli Zaretskii <eliz@gnu.org>
2683
2684 * xdisp.c (iterate_out_of_display_property): xassert that
2685 IT->position is set to within IT->object's boundaries. Break from
2686 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2687 when IT->position is set up wrongly due to some bug.
2688 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2689 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2690 entry. Force push_it to save on the stack the current
2691 buffer/string position, to be restored by pop_it. Fix flags in
2692 the iterator structure wrt the object coming from a display
2693 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2694 properties. (Bug#9284)
2695
7be1c708 26962011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2697
7be1c708
CY
2698 * fontset.c (fontset_get_font_group): Add proper type checks.
2699 (Bug#9172)
aac0c6e3 2700
7be1c708 27012011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2702
7be1c708
CY
2703 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2704 and LC_VERSION_MIN_MACOSX.
2705 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2706 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2707
97bb72a6
EZ
27082011-08-08 Eli Zaretskii <eliz@gnu.org>
2709
2710 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2711 no-display-properties-and-no-overlays under bidi display.
2712 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2713 properties and overlays.
97bb72a6 2714
d5617611
CY
27152011-08-08 Chong Yidong <cyd@stupidchicken.com>
2716
37e11a63
CY
2717 * editfns.c (Fset_time_zone_rule): Document relationship with the
2718 setenv function.
2719
d5617611
CY
2720 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2721 the font entity extracted from the cache (Bug#8109).
2722
58872834
CY
27232011-08-07 Chong Yidong <cyd@stupidchicken.com>
2724
2725 * composite.c (autocmp_chars): Don't reset point. That is done by
2726 restore_point_unwind (Bug#5984).
2727
75bfc667
JL
27282011-08-07 Juri Linkov <juri@jurta.org>
2729
2730 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2731 to show the arg `TIME' instead of `TIMEVAL'.
2732
d1410150
EZ
27332011-08-06 Eli Zaretskii <eliz@gnu.org>
2734
2735 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2736 display property strides EOL and includes a newline, as in
2737 longlines-mode. (Bug#9254)
75b771e4
EZ
2738 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2739 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2740
2741 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2742 is non-zero, even if the data buffer is NULL. Fixes a crash in
2743 vertical-motion with longlines-mode. (Bug#9254)
2744
35928349
EZ
27452011-08-05 Eli Zaretskii <eliz@gnu.org>
2746
ec7cc85b
EZ
2747 * bidi.c <bidi_cache_total_alloc>: Now static.
2748 (bidi_initialize): Initialize bidi_cache_total_alloc.
2749
8b76d6f8 2750 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2751 cache. (Bug#9221)
2752
2753 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2754 amount allocated this far in `bidi_cache_total_alloc'.
2755 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2756 non-zero, only free the data buffer without restoring the cache
2757 contents. All callers changed.
2758
2759 * dispextern.h (bidi_unshelve_cache): Update prototype.
2760
2761 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2762 (move_it_in_display_line, move_it_to)
2763 (move_it_vertically_backward, move_it_by_lines): Replace the call
2764 to xfree to an equivalent call to bidi_unshelve_cache.
2765 (move_it_in_display_line_to): Fix logic of returning
412b6358 2766 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2767
e2e2423b
EZ
27682011-08-05 Eli Zaretskii <eliz@gnu.org>
2769
2770 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2771 came from a string character with a `cursor' property. (Bug#9229)
2772
ae9e757a
JD
27732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2774
2775 * Makefile.in (LIB_PTHREAD): New variable.
2776 (LIBES): Add LIB_PTHREAD (Bug#9216).
2777
2778 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2779 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2780
213bd7f2
AS
27812011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2782
6b02f655 2783 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2784
99aaf75f
JD
27852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2786
2787 * xterm.c (x_find_topmost_parent): New function.
2788 (x_set_frame_alpha): Find topmost parent window with
2789 x_find_topmost_parent and set the property there also (bug#9181).
2790 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2791
c74e9d86
PE
27922011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2793
2794 * callproc.c (Fcall_process): Avoid vfork clobbering
2795 the local vars buffer, coding_systems, current_dir.
2796
640c8776
SM
27972011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2798
2799 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2800
f26d0e4c
PE
28012011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2802
8a10d76c
PE
2803 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2804 so that it is not optimized away.
2805
f26d0e4c
PE
2806 * xdisp.c (compute_display_string_pos): Remove unused local.
2807
55439c61
EZ
28082011-08-02 Eli Zaretskii <eliz@gnu.org>
2809
2810 Fix slow cursor motion and scrolling in large buffers with
2811 selective display, like Org Mode buffers. (Bug#9218)
2812
2813 * dispextern.h (struct bidi_it): New member disp_prop_p.
2814
2815 * xdisp.c: Remove one-slot cache of display string positions.
2816 (compute_display_string_pos): Accept an additional argument
5e617bc2 2817 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2818 for a display string or property. If found, set DISP_PROP_P
2819 non-zero.
2820
2821 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2822 DISP_PROP_P, and pass it to compute_display_string_pos.
2823 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2824 non-zero. All callers of bidi_fetch_char changed.
2825
fb33fa43
SM
28262011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2827
2828 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2829
b099e063
DM
28302010-12-03 Don March <don@ohspite.net>
2831
2832 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2833 last character M-[char] is translated to ESC [char] (bug#7541).
2834
5cc7f7af
KH
28352011-08-02 Kenichi Handa <handa@m17n.org>
2836
d0fffa3f 2837 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2838
2839 * chartab.c (uniprop_table): Make it non-static.
2840
525d5e6e
EZ
28412011-08-01 Eli Zaretskii <eliz@gnu.org>
2842
2843 * xdisp.c (forward_to_next_line_start): Accept additional argument
2844 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2845 on the newline.
2846 (reseat_at_next_visible_line_start): Use the bidi iterator state
2847 returned by forward_to_next_line_start to restore the state of
2848 it->bidi_it after backing up to previous newline. (Bug#9212)
2849
31011111
AS
28502011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2851
2852 * regex.c (re_comp): Protoize.
2853 (re_exec): Fix return type.
2854 (regexec): Fix type of `ret'. (Bug#9203)
2855
476371c4
PE
28562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2857
e5d76069
PE
2858 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2859 This is needed if max-image-size is a floating-point number.
2860
9a79b20c
AS
28612011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2862
2863 * print.c (print_object): Print empty symbol as ##.
2864
2865 * lread.c (read1): Read ## as empty symbol.
2866
d8c2fa78
AA
28672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2868
2869 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2870 setting frame foreground color (Bug#9175).
2871 (x_set_background_color): Likewise.
2872
ffe57a7a
AA
2873 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2874 contents (Bug#9176).
2875 (EmacsTooltip -init): Remove bezels and add shadows to
2876 tooltip windows.
2877
bf3492a5
AA
2878 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2879 or scroll bar (Bug#8470).
2880
d55e9c53
AA
2881 * nsfont.m (nsfont_open): Remove assignment to voffset and
2882 unnecessary vars hshink, expand, hd, full_height, min_height.
2883 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2884
2885 * nsterm.h (nsfont_info): Remove voffset field.
2886
d8c2fa78 28872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2888
2889 Implement strike-through and overline on NextStep (Bug#8863).
2890
2891 * nsfont.m (nsfont_open): Use underline position provided by font,
2892 instead of hard-coded value of 2.
2893 (nsfont_draw): Call ns_draw_text_decoration instead.
2894
2895 * nsterm.h: Add declaration for ns_draw_text_decoration.
2896
2897 * nsterm.m (ns_draw_text_decoration): New function for drawing
2898 underline, overline, and strike-through.
2899 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2900 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2901 accommodate underlining, etc.
4843aac3 2902
4cc60b9b
EZ
29032011-07-28 Eli Zaretskii <eliz@gnu.org>
2904
bc7ece87
EZ
2905 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2906 default.
4cc60b9b 2907
476371c4
PE
29082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2909
66606eea
PE
2910 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2911 Without this fix, if a signal arrives just after memory fills up,
2912 'malloc' might be invoked reentrantly.
2913
476371c4
PE
2914 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2915 In other words, assume that every image size is allowed, on non-X
2916 hosts. This assumption is probably wrong, but it lets Emacs compile.
2917
f3fcc40d
AS
29182011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2919
2920 * regex.c (re_iswctype): Convert return values to boolean.
2921
350c992f
EZ
29222011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2923
2924 * xdisp.c (compute_display_string_pos): Don't use cached display
2925 string position if the buffer had its restriction changed.
2926 (Bug#9184)
2927
5266b4bb
PE
29282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2931
2573a837 29322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2933
41f55ccd 2934 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2935
39e378da
PE
2936 * bidi.c: Integer size and overflow fixes.
2937 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2938 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2939 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2940 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2941 (bidi_find_other_level_edge):
2942 Use ptrdiff_t instead of EMACS_INT where either will do.
2943 This works better on 32-bit hosts configured --with-wide-int.
2944 (bidi_cache_ensure_space): Check for size-calculation overflow.
2945 Use % rather than repeated addition, for better worst-case speed.
2946 Don't set bidi_cache_size until after xrealloc returns, because it
2947 might not return.
2948 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2949 (bidi_cache_ensure_space): Also check that the bidi cache size
2950 does not exceed that of the largest Lisp string or buffer. See Eli
2951 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2952
5e927815
PE
2953 * alloc.c (__malloc_size_t): Remove.
2954 All uses replaced by size_t. See Andreas Schwab's note
2955 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2956
ca4aa935
PE
2957 * image.c: Improve checking for integer overflow.
2958 (check_image_size): Assume that f is nonnull, since
2959 it is always nonnull in practice. This is one less thing to
2960 worry about when checking for integer overflow later.
2961 (x_check_image_size): New function, which checks for integer
2962 overflow issues inside X.
2963 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2964 This removes the need for a memory_full check.
2965 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2966 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2967 (xbm_read_bitmap_data): Change locals back to 'int', since
2968 their values must fit in 'int'.
2969 (xpm_load_image, png_load, tiff_load):
2970 Invoke x_create_x_image_and_pixmap earlier,
2971 to avoid much needless work if the image is too large.
2972 (tiff_load): Treat overly large images as if
2973 x_create_x_image_and_pixmap failed, not as malloc failures.
2974 (gs_load): Use x_check_image_size.
2975
5f8f9cc2
PE
2976 * gtkutil.c: Omit integer casts.
2977 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2978 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2979
5adf60bc
PE
2980 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2981
c8907a93
PE
2982 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2983 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2984 would wrongly return t on a 64-bit host.
2985
e3c25c68
PE
2986 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2987 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2988 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2989 and therefore cause GCC to emit a bogus diagnostic in some cases.
2990
3f791afe
PE
2991 * image.c: Integer signedness and overflow and related fixes.
2992 This is not an exhaustive set of fixes, but it's time to
2993 record what I've got.
2994 (lookup_pixel_color, check_image_size): Remove redundant decls.
2995 (check_image_size): Don't assume that arbitrary EMACS_INT values
2996 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2997 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2998 (tiff_load, imagemagick_load_image):
2999 Check for overflow in size calculations.
3000 (x_create_x_image_and_pixmap): Remove unnecessary test for
3001 xmalloc returning NULL; that can't happen.
3002 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3003 (xpm_color_bucket): Use better integer hashing function.
3004 (xpm_cache_color): Don't possibly over-allocate memory.
3005 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3006 (gif_memory_source):
3007 Use ptrdiff_t, not int or size_t, to record sizes.
3008 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3009 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3010 either works, as we prefer signed integers.
3011 (tiff_read_from_memory, tiff_write_from_memory):
3012 Return tsize_t, not size_t, since that's what the TIFF API wants.
3013 (tiff_read_from_memory): Don't fail simply because the read would
3014 go past EOF; instead, return a short read.
3015 (tiff_load): Omit no-longer-needed casts.
3016 (Fimagemagick_types): Don't assume size fits into 'int'.
3017
3cc5a532
PE
3018 Improve hashing quality when configured --with-wide-int.
3019 * fns.c (hash_string): New function, taken from sxhash_string.
3020 Do not discard information about ASCII character case; this
3021 discarding is no longer needed.
3022 (sxhash-string): Use it. Change sig to match it. Caller changed.
3023 * lisp.h: Declare it.
3024 * lread.c (hash_string): Remove, since we now use fns.c's version.
3025 The fns.c version returns a wider integer if --with-wide-int is
3026 specified, so this should help the quality of the hashing a bit.
3027
b312a492
PE
3028 * emacs.c: Integer overflow minor fix.
3029 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3030 Define only if GNU_LINUX.
3031 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3032
dfd153ae
PE
3033 * dispnew.c: Integer signedness and overflow fixes.
3034 Remove unnecessary forward decls, that were a maintenance hassle.
3035 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3036 All uses changed.
3037 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3038 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3039 (prepare_desired_row, line_draw_cost):
3040 Use int, not unsigned, where either works.
3041 (save_current_matrix, restore_current_matrix):
3042 Use ptrdiff_t, not size_t, where either works.
3043 (init_display): Check for overflow more accurately, and without
3044 relying on undefined behavior.
3045
a81d11a3
PE
3046 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3047 Remove, replacing with the new symbols in lisp.h. All uses changed.
3048 * fileio.c (make_temp_name):
3049 * filelock.c (lock_file_1, lock_file):
3050 * xdisp.c (message_dolog):
3051 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3052 Use pMd etc. instead.
3053 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3054 replacing the pWIDE etc. symbols removed from editfns.c.
3055
3300e6fd
PE
3056 * keyboard.h (num_input_events): Now uintmax_t.
3057 This is (very slightly) less likely to mess up due to wraparound.
3058 All uses changed.
3059
fd05c7e9
PE
3060 * buffer.c: Integer signedness fixes.
3061 (alloc_buffer_text, enlarge_buffer_text):
3062 Use ptrdiff_t rather than size_t when either will do, as we prefer
3063 signed integers.
3064
903fe15d
PE
3065 * alloc.c: Integer signedness and overflow fixes.
3066 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3067 (__malloc_size_t): Default to size_t, not to int.
3068 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3069 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3070 Prefer ptrdiff_t to size_t when either would do, as we prefer
3071 signed integers.
3072 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3073 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3074 Now const. Initialize with values that are in range even if char
3075 is signed.
3076 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3077 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3078 These functions do the right thing with sizes > 2**32.
3079 (check_depth): Now ptrdiff_t, not int.
3080 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3081 Adjust to new way of storing sizes. Check for size overflow bugs
3082 in rest of code.
3083 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3084 slightly wrong anyway, as it missed one instance of
3085 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3086 (refill_memory_reserve): Omit needless cast to size_t.
3087 (mark_object_loop_halt): Mark as externally visible.
3088
ac82cc6a
PE
3089 * xselect.c: Integer signedness and overflow fixes.
3090 (Fx_register_dnd_atom, x_handle_dnd_message):
3091 Use ptrdiff_t, not size_t, since we prefer signed.
3092 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3093 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3094 x_dnd_atoms_size and x_dnd_atoms_length.
3095
c2d1e36d
PE
3096 * doprnt.c: Prefer signed to unsigned when either works.
3097 * eval.c (verror):
3098 * doprnt.c (doprnt):
3099 * lisp.h (doprnt):
3100 * xdisp.c (vmessage):
3101 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3102 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3103 prefer signed arithmetic to avoid comparison confusion.
3104 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3105 but is a bit tricky.
3106
0e926e56
PE
3107 Assume freestanding C89 headers, string.h, stdlib.h.
3108 * data.c, doprnt.c, floatfns.c, print.c:
3109 Include float.h unconditionally.
3110 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3111 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3112 * regex.c: Likewise for stddef.h, string.h.
3113 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3114 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3115 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3116 (STDC_HEADERS): Remove obsolete defines.
3117 * sysdep.c: Include limits.h unconditionally.
3118
9cfdb3ec
PE
3119 Assume support for memcmp, memcpy, memmove, memset.
3120 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3121 * regex.c (memcmp, memcpy):
3122 Remove; we assume C89 now.
3123
3124 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3125 (__malloc_safe_bcopy): Remove; no longer needed.
3126
cf950e6b 3127 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3128 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3129 well either way, and we prefer signed to unsigned.
3130
dbf38e02
LMI
31312011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3132
3133 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3134 closes the connection while we're reading (bug#9182).
3135
d6f0886c 31362011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3137
d6f0886c
JD
3138 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3139 are specified (Bug#9168).
24e0f6b1 3140
2eb1f9e6
PE
31412011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3144 Found by GCC static checking and --with-wide-int on a 32-bit host.
3145
22381272 31462011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3147
3148 * xdisp.c (compute_display_string_pos): Fix logic of caching
3149 previous display string position. Initialize cached_prev_pos to
3150 -1. Fixes slow-down at the beginning of a buffer.
3151
f25e39b4
EZ
31522011-07-24 Eli Zaretskii <eliz@gnu.org>
3153
3154 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3155 for attrs[LFACE_FONTSET_INDEX].
3156
04c4b52e
PE
31572011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3158
3159 * xml.c (parse_region): Remove unused local
3160 that was recently introduced.
3161
c1734fbd
EZ
31622011-07-23 Eli Zaretskii <eliz@gnu.org>
3163
be18c5a5
EZ
3164 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3165 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3166
c1734fbd
EZ
3167 * xdisp.c (move_it_in_display_line_to): Record the best matching
3168 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3169 exit if none of the characters scanned was an exact match.
3170 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3171 when exact match is impossible due to invisible text, and the
3172 lines are truncated.
3173
a258d627
JD
31742011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3175
3176 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3177 for OSX >= 10.7.
3178
b6d5a689
EZ
31792011-07-22 Eli Zaretskii <eliz@gnu.org>
3180
0f74f785
EZ
3181 Fix a significant slow-down of cursor motion with C-n, C-p,
3182 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3183 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3184 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3185 (next_element_from_buffer): Call compute_stop_pos_backwards to
3186 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3187 base_level_stop.
3188 (reseat): Don't look for prev_stop, as that could mean a very long
3189 run.
3190 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3191 <cached_disp_overlay_modiff>: Cache for last found display string
3192 position.
551918c1 3193 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3194 about the same buffer in the same area of character positions, and
3195 the buffer wasn't changed since the time the display string
3196 position was cached.
551918c1 3197
b2d0c91a
EZ
31982011-07-22 Eli Zaretskii <eliz@gnu.org>
3199
3200 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3201 is an integer, which is important for empty lines. (Bug#9149)
3202
043604ee
CY
32032011-07-22 Chong Yidong <cyd@stupidchicken.com>
3204
3205 * frame.c (Fmodify_frame_parameters): In tty case, update the
3206 default face if necessary (Bug#4238).
3207
da4adb04
CY
32082011-07-21 Chong Yidong <cyd@stupidchicken.com>
3209
3210 * editfns.c (Fstring_to_char): No need to explain what a character
3211 is in the docstring (Bug#6576).
3212
9abd0532
LMI
32132011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3214
3215 * xml.c (parse_region): Make sure we always return a tree.
3216
36881d16
HK
32172011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3218
3219 * xml.c (parse_region): If a document contains only comments,
3220 return that, too.
3221
1e98674d
LMI
32222011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3223
3224 * xml.c (make_dom): Return comments, too.
3225
590bd467
PE
32262011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 Port to OpenBSD.
3229 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3230 and the surrounding thread.
3231 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3232 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3233 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3234 timer goes off.
3235 * s/openbsd.h (BROKEN_SIGIO): Define.
3236 * unexelf.c (unexec) [__OpenBSD__]:
3237 Don't update the .mdebug section of the Alpha COFF symbol table.
3238
f41628b2
LMI
32392011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3240
3241 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3242 (bug#8460).
3243
b59b67c5
PE
32442011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3245
15e3a074
PE
3246 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3247 This fixes some race conditions on the permissions of any newly
3248 created file.
3249
41bed37d
PE
3250 * alloc.c (valid_pointer_p): Use pipe, not open.
3251 This fixes some permissions issues when debugging.
3252
b59b67c5
PE
3253 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3254 If fchown fails to set both uid and gid, try to set just gid,
3255 as that is sometimes allowed. Adjust the file's mode to eliminate
3256 setuid or setgid bits that are inappropriate if fchown fails.
3257
925a6be7
SM
32582011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3259
3260 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3261 to compare Lisp_Objects.
3262 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3263 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3264 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3265
52968808
AS
32662011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3267
0a6a104b
AS
3268 * lread.c (read_integer): Unread even EOF character.
3269 (read1): Likewise. Properly record start position of symbol.
3270
52968808
AS
3271 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3272 symbol character follows.
3273
9e381cdd
PE
32742011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3277 This works around a problem with the previous change to Fcopy_file.
3278 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3279 and without this change, GCC might complain about discarding
3280 fchown's return value.
3281
b5641435
JB
32822011-07-16 Juanma Barranquero <lekktu@gmail.com>
3283
3284 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3285
a8031457
PE
32862011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3289
dd889327
LMI
32902011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3291
750c33f7
LMI
3292 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3293 it's used from the C level.
3294
dd889327
LMI
3295 * process.c: Use the same condition for POLL_FOR_INPUT in both
3296 keyboard.c and process.c (bug#1858).
3297
87e86684
LM
32982011-07-09 Lawrence Mitchell <wence@gmx.li>
3299
3300 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3301 (Fgnutls_boot): Use it.
3302
64348f40
AS
33032011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3304
3305 * doc.c (Fsubstitute_command_keys): Revert last change.
3306
1d698799
LMI
33072011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3308
f863868c
LMI
3309 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3310 quotes the next character, and doesn't affect other longer
3311 sequences (bug#8935).
3312
1d698799
LMI
3313 * lread.c (syms_of_lread): Clarify that is isn't only
3314 `eval-buffer' and `eval-defun' that's affected by
3315 `lexical-binding' (bug#8460).
3316
aa4b6df6
EZ
33172011-07-15 Eli Zaretskii <eliz@gnu.org>
3318
3319 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3320 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3321
5d856da6
PE
33222011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3323
ad6042bb
PE
3324 Fix minor problems found by static checking.
3325 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3326 (elsz): Now a signed constant, not a size_t var. We prefer signed
3327 types to unsigned, to avoid integer comparison confusion. Without
3328 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3329 "cannot optimize loop, the loop counter may overflow", a symptom
3330 of the confusion.
f00bbb22 3331 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3332 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3333
6468f31c
LMI
33342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3335
49080b10
LMI
3336 * search.c (Fre_search_backward): Mention `case-fold-search' in
3337 all the re_search_* functions (bug#8138).
3338
6468f31c
LMI
3339 * keyboard.c (Fopen_dribble_file): Document when the file is
3340 closed (bug#8056).
3341
c965adc5
EZ
33422011-07-14 Eli Zaretskii <eliz@gnu.org>
3343
df9733bf
EZ
3344 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3345 bidi_cache_idx.
3346
0bb23927
EZ
3347 Support bidi reordering of display and overlay strings.
3348 * xdisp.c (compute_display_string_pos)
3349 (compute_display_string_end): Accept additional argument STRING.
3350 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3351 (reseat_to_string): Initialize bidi_it->string.s and
3352 bidi_it->string.schars.
3353 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3354 NULL (avoids a crash in bidi_paragraph_init).
3355 Initialize itb.string.lstring.
0bb23927
EZ
3356 (init_iterator): Call bidi_init_it only of a valid
3357 buffer position was specified. Initialize paragraph_embedding to
3358 L2R.
3359 (reseat_to_string): Initialize the bidi iterator.
3360 (display_string): If we need to ignore text properties of
3361 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3362 original value of -1 will not work with bidi.)
3363 (compute_display_string_pos): First arg is now struct
3364 `text_pos *'; all callers changed. Support display properties on
3365 Lisp strings.
3366 (compute_display_string_end): Support display properties on Lisp
3367 strings.
3368 (init_iterator, reseat_1, reseat_to_string): Initialize the
3369 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3370 when iterating on a string not from display properties).
640c8776
SM
3371 (compute_display_string_pos, compute_display_string_end):
3372 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3373 arrow keys.
3374 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3375 base_level_stop; instead, set base_level_stop to BEGV.
3376 Fixes crashes in vertical-motion.
0bb23927
EZ
3377 (next_element_from_buffer): Improve commentary for when
3378 the iterator is before prev_stop.
3379 (init_iterator): Initialize bidi_p from the default value of
3380 bidi-display-reordering, not from buffer-local value. Use the
3381 buffer-local value only if initializing for buffer iteration.
3382 (handle_invisible_prop): Support invisible properties on strings
3383 that are being bidi-reordered.
3384 (set_iterator_to_next): Support bidi reordering of C strings and
3385 Lisp strings.
3386 (next_element_from_string): Support bidi reordering of Lisp
3387 strings.
3388 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3389 (display_string): Support display of R2L glyph rows.
3390 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3391 (init_iterator): Don't initialize it->bidi_p for strings
3392 here.
3393 (reseat_to_string): Initialize it->bidi_p for strings here.
3394 (next_element_from_string, next_element_from_c_string)
3395 (next_element_from_buffer): Add xassert's for correspondence
3396 between IT's object being iterated and it->bidi_it.string
3397 structure.
3398 (face_before_or_after_it_pos): Support bidi iteration.
3399 (next_element_from_c_string): Handle the case of the first string
3400 character that is not the first one in the visual order.
3401 (get_visually_first_element): New function, refactored from common
3402 parts of next_element_from_buffer, next_element_from_string, and
3403 next_element_from_c_string.
3404 (tool_bar_lines_needed, redisplay_tool_bar)
3405 (display_menu_bar): Force left-to-right direction. Add a FIXME
3406 comment for making that be controlled by a user option.
3407 (push_it, pop_it): Save and restore the state of the
3408 bidi iterator. Save and restore the bidi_p flag.
3409 (pop_it): Iterate out of display property for string iteration as
3410 well.
3411 (iterate_out_of_display_property): Support iteration over strings.
3412 (handle_single_display_spec): Set up it->bidi_it for iteration
3413 over a display string, and call bidi_init_it.
3414 (handle_single_display_spec, next_overlay_string)
3415 (get_overlay_strings_1, push_display_prop): Set up the bidi
3416 iterator for displaying display or overlay strings.
3417 (forward_to_next_line_start): Don't use the shortcut if
3418 bidi-iterating.
3419 (back_to_previous_visible_line_start): If handle_display_prop
3420 pushed the iterator stack, restore the internal state of the bidi
3421 iterator by calling bidi_pop_it same number of times.
3422 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3423 and we are bidi-iterating, don't decrement the iterator position;
3424 instead, set the first_elt flag in the bidi iterator, to produce
3425 the same effect.
3426 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3427 (push_display_prop): xassert that we are iterating a buffer.
3428 (push_it, pop_it): Save and restore paragraph_embedding member.
3429 (handle_single_display_spec, next_overlay_string)
3430 (get_overlay_strings_1, reseat_1, reseat_to_string)
3431 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3432 correctly. Don't assume unibyte strings are not bidi-reordered.
3433 (compute_display_string_pos)
3434 (compute_display_string_end): Fix handling the case of C string.
3435 (push_it, pop_it): Save and restore from_disp_prop_p.
3436 (handle_single_display_spec, push_display_prop): Set the
3437 from_disp_prop_p flag.
3438 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3439 (pop_it): Call iterate_out_of_display_property only if we are
3440 popping after iteration over a string that came from a display
3441 property. Fix a typo in popping stretch info. Add an assertion
3442 for verifying that the iterator position is in sync with the bidi
3443 iterator.
3444 (handle_single_display_spec, get_overlay_strings_1)
3445 (push_display_prop): Fix initialization of paragraph direction for
3446 string when that of the parent object is not yet determined.
3447 (reseat_1): Call bidi_init_it to resync the bidi
3448 iterator with IT's position. (Bug#7616)
3449 (find_row_edges): If ROW->start.pos gives position
3450 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3451 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3452 Reset the from_disp_prop_p flag.
3453 (SAVE_IT, RESTORE_IT): New macros.
3454 (pos_visible_p, face_before_or_after_it_pos)
3455 (back_to_previous_visible_line_start)
3456 (move_it_in_display_line_to, move_it_in_display_line)
3457 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3458 (try_scrolling, redisplay_window, display_line): Use them when
3459 saving a temporary copy of the iterator and restoring it back.
3460 (back_to_previous_visible_line_start, reseat_1)
3461 (init_iterator): Empty the bidi cache "stack".
3462 (move_it_in_display_line_to): If iterator ended up at
3463 EOL, but we never saw any buffer positions smaller than
3464 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3465 motion in bidi-reordered lines.
3466 (move_it_in_display_line_to): Record prev_method and prev_pos
3467 immediately before the call to set_iterator_to_next. Fixes cursor
3468 motion in bidi-reordered lines with stretch glyphs and strings
3469 displayed in margins. (Bug#8133) (Bug#8867)
3470 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3471 TO_CHARPOS.
640c8776
SM
3472 (pos_visible_p): Support positions in bidi-reordered lines.
3473 Save and restore bidi cache.
0bb23927
EZ
3474
3475 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3476 (bidi_paragraph_info): Delete unused struct.
3477 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3478 (bidi_cache_start): New variable.
3479 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3480 to zero.
3481 (bidi_cache_fetch_state, bidi_cache_search)
3482 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3483 (bidi_cache_find, bidi_peek_at_next_level)
3484 (bidi_level_of_next_char, bidi_find_other_level_edge)
3485 (bidi_move_to_visually_next): Compare cache index with
3486 bidi_cache_start rather than with zero.
3487 (bidi_fetch_char): Accept new argument STRING; all callers
3488 changed. Support iteration over a string. Support strings with
3489 display properties. Support unibyte strings. Fix the type of
3490 `len' according to what STRING_CHAR_AND_LENGTH expects.
3491 (bidi_paragraph_init, bidi_resolve_explicit_1)
3492 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3493 (bidi_level_of_next_char, bidi_move_to_visually_next):
3494 Support iteration over a string.
0bb23927
EZ
3495 (bidi_set_sor_type, bidi_resolve_explicit_1)
3496 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3497 can now be zero (for strings); special values 0 and -1 were
3498 changed to -1 and -2, respectively.
3499 (bidi_char_at_pos): New function.
3500 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3501 Call it instead of FETCH_MULTIBYTE_CHAR.
3502 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3503 initialized to valid values.
3504 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3505 values.
3506 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3507 the test for valid cached positions. Fix the logic for looking up
3508 the sentinel state in the cache. GCPRO the Lisp string we are
3509 iterating.
3510 (bidi_push_it, bidi_pop_it): New functions.
3511 (bidi_initialize): Initialize the bidi cache start stack pointer.
3512 (bidi_cache_ensure_space): New function, refactored from part of
3513 bidi_cache_iterator_state. Don't assume the required size is just
3514 one BIDI_CACHE_CHUNK away.
3515 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3516 (bidi_count_bytes, bidi_char_at_pos): New functions.
3517 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3518 always valid if bidi_cache_idx is valid.
3519 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3520 is valid if it's going to be used.
3521 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3522 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3523 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3524 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3525 (bidi_find_other_level_edge, bidi_cache_start_stack):
3526 All variables related to cache indices are now EMACS_INT.
c965adc5 3527
0bb23927
EZ
3528 * dispextern.h (struct bidi_string_data): New structure.
3529 (struct bidi_it): New member `string'. Make flag members be 1-bit
3530 fields, and put them last in the struct.
640c8776
SM
3531 (compute_display_string_pos, compute_display_string_end):
3532 Update prototypes.
0bb23927
EZ
3533 (bidi_push_it, bidi_pop_it): Add prototypes.
3534 (struct iterator_stack_entry): New members bidi_p,
3535 paragraph_embedding, and from_disp_prop_p.
3536 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3537 (bidi_shelve_cache, bidi_unshelve_cache):
3538 Declare prototypes.
0bb23927
EZ
3539
3540 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3541 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3542 and vector-like objects.
3543
3544 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3545 cache around display iteration.
3546
3547 * window.c (Fwindow_end, window_scroll_pixel_based)
3548 (displayed_window_lines, Frecenter): Save and restore the bidi
3549 cache around display iteration.
3550
3bbd2265
LMI
35512011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3552
3553 * editfns.c (Fdelete_region): Clarify the use of the named
3554 parameters (bug#6788).
3555
adc47434
MR
35562011-07-14 Martin Rudalics <rudalics@gmx.at>
3557
3558 * indent.c (Fvertical_motion): Set and restore w->pointm when
3559 saving and restoring the window's buffer (Bug#9006).
3560
837c31f8
LMI
35612011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3562
3563 * editfns.c (Fstring_to_char): Clarify just what is returned
3564 (bug#6576). Text by Eli Zaretskii.
3565
ac389d0c
JB
35662011-07-13 Juanma Barranquero <lekktu@gmail.com>
3567
3568 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3569
0be0ce47
EZ
35702011-07-13 Eli Zaretskii <eliz@gnu.org>
3571
3572 * buffer.c (mmap_find): Fix a typo.
3573
cd18e7e3
JB
35742011-07-13 Johan Bockgård <bojohan@gnu.org>
3575
3576 Fix execution of x selection hooks.
3577 * xselect.c (Qx_lost_selection_functions)
3578 (Qx_sent_selection_functions): New vars.
3579 (syms_of_xselect): DEFSYM them.
3580 (x_handle_selection_request): Pass Qx_sent_selection_functions
3581 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3582 (x_handle_selection_clear,x_clear_frame_selections):
3583 Pass Qx_lost_selection_functions rather than
3584 Vx_lost_selection_functions to Frun_hook_with_args.
3585
47ea7f44
PE
35862011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3587
ac389d0c 3588 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3589 The old code sometimes used this field without initializing it.
3590
47ea7f44
PE
3591 * alloc.c (gc_sweep): Don't read past end of array.
3592 In theory, the old code could also have corrupted Emacs internals,
3593 though it'd be very unlikely.
3594
bc985c87
AS
35952011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3596
3597 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3598 argument. (Bug#4026)
bc985c87 3599
0cf34688
LMI
36002011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3601
b3dadd76
LMI
3602 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3603 key" (bug#4257).
3604
0cf34688
LMI
3605 * window.c (Fset_window_start): Doc fix (bug#4199).
3606 (Fset_window_hscroll): Ditto.
3607
270768cd
PE
36082011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3609
077e3dda 3610 Fix minor new problems caught by GCC 4.6.1.
270768cd 3611 * term.c (init_tty): Remove unused local.
490011a6 3612 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3613 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3614 not used otherwise.
270768cd 3615
b1f58454
CY
36162011-07-12 Chong Yidong <cyd@stupidchicken.com>
3617
3618 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3619
22b9578d
LMI
36202011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3621
6e70ab07
LMI
3622 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3623 are the mini-buffer and the echo area (bug#3320).
3624
22b9578d
LMI
3625 * term.c (init_tty): Remove support for supdup, c10 and perq
3626 terminals, which are no longer supported (bug#1482).
3627
8974cc9f
JB
36282011-07-10 Johan Bockgård <bojohan@gnu.org>
3629
3630 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3631
a560d974
JD
36322011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3633
3634 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3635 for non-popups (Bug#3642).
3636
1dae0f0a
AS
36372011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3638
268c2c36 3639 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3640 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3641 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3642 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3643 * data.c (fmod): Likewise.
3644 * dispnew.c (swap_glyphs_in_rows): Likewise.
3645 * emacs.c (memory_warning_signal): Likewise.
3646 * floatfns.c (float_error): Likewise.
3647 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3648 (otf_open, font_otf_capability, generate_otf_features)
3649 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3650 Likewise.
3651 * image.c (pbm_read_file): Likewise.
3652 * indent.c (string_display_width): Likewise.
3653 * intervals.c (check_for_interval, search_for_interval)
3654 (inc_interval_count, count_intervals, root_interval)
3655 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3656 * lread.c (defalias): Likewise.
268c2c36 3657 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3658 * regex.c (set_image_of_range_1, set_image_of_range)
3659 (regex_grow_registers): Likewise.
3660 * sysdep.c (strerror): Likewise.
3661 * termcap.c (valid_filename_p, tprint, main): Likewise.
3662 * tparam.c (main): Likewise.
3663 * unexhp9k800.c (run_time_remap, save_data_space)
3664 (update_file_ptrs, read_header, write_header, calculate_checksum)
3665 (copy_file, copy_rest, display_header): Likewise.
3666 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3667 Likewise.
3668 * xdisp.c (check_it): Likewise.
3669 * xfaces.c (register_color, unregister_color, unregister_colors):
3670 Likewise.
3671 * xfns.c (print_fontset_result): Likewise.
3672 * xrdb.c (member, fatal, main): Likewise.
3673
99033785
PE
36742011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 Fix minor problems found by static checking (Bug#9031).
3677 * chartab.c (char_table_set_range, map_sub_char_table):
3678 Remove unused locals.
3679 (uniprop_table): Now static.
3680 * composite.c (_work_char): Remove unused static var.
3681
9cb2ac56
JB
36822011-07-09 Juanma Barranquero <lekktu@gmail.com>
3683
3684 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3685
f25661f0
JD
36862011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3687
3688 * gtkutil.c (qttip_cb): Remove code without function.
3689
8278c4fe
EZ
36902011-07-09 Eli Zaretskii <eliz@gnu.org>
3691
3692 * w32.c (pthread_sigmask): New stub.
3693
1692ae2d 36942011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3695
8a6ebd58 3696 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3697 sigprocmask is portable only for single-threaded applications, and
3698 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3699 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3700 (LIBES): Use it.
3701 * callproc.c (Fcall_process):
3702 * process.c (create_process):
3703 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3704 Use pthread_sigmask, not sigprocmask.
123403e4 3705
1b854618
JD
37062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3707
3708 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3709 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3710 wrong (Bug#8591).
3711
3fe4b549
JD
37122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3713
0ce7e563
JD
3714 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3715 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3716 (xg_hide_tooltip): Fix comment.
3717
3fe4b549
JD
3718 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3719 in registerServicesMenuSendTypes.
3720 (validRequestorForSendType): Don't check ns_return_types.
3721
3722 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3723 ns_return_type.
3724
5df75e47
JR
37252011-07-08 Jason Rumney <jasonr@gnu.org>
3726
22610910
JR
3727 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3728 SH_SHOW for hidden windows (Bug#5482).
3729
5df75e47
JR
3730 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3731 frame struct members of non-existent frames (Bug#6284).
3732
699c10bd
JD
37332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3734
4393663b
JD
3735 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3736 variable firstTime not needed on OSX >= 10.6.
3737 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3738 >= 10.5. Use setKnobProportion, setDoubleValue.
3739
3740 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3741 (MAC_OS_X_VERSION_10_5): Define if not defined.
3742 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3743 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3744 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3745
3746 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3747 cString and lossyCString on OSX >= 10.4
3748
58179cce 3749 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3750 sizeToFit on OSX >= 10.2.
3751
3752 * nsimage.m (allocInitFromFile): Don't use deprecated method
3753 bestRepresentationForDevice on OSX >= 10.6.
3754
3755 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3756 to avoid warning.
3757
3758 * emacs.c: Declare unexec_init_emacs_zone.
3759
a63e0781
JD
3760 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3761
699c10bd
JD
3762 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3763
3764 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3765 on svcsMenu (Bug#8842).
3766
3767 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3768 ns_return_types.
3769 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3770
3771 * nsterm.m (QUTF8_STRING): Declare.
3772 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3773 (validRequestorForSendType): Return type is (id).
3774 Change indexOfObjectIdenticalTo to indexOfObject.
3775 Check if we have local selection before returning self (Bug#8842).
3776 (writeSelectionToPasteboard): Put local selection into paste board
3777 if we have a local selection (Bug#8842).
3778 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3779
3780 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3781 (ns_get_local_selection): Declare.
3782
54e10184
LMI
37832011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3784
9888ff71
LMI
3785 * keymap.c (describe_map_tree): Don't insert a double newline at
3786 the end of the buffer (bug#1169) and return whether we inserted
3787 something.
3788
54e10184
LMI
3789 * callint.c (Fcall_interactively): Change "reading args" to
3790 "providing args" to try to clarify what it does (bug#1010).
3791
15fa4783
KH
37922011-07-07 Kenichi Handa <handa@m17n.org>
3793
3794 * composite.c (composition_compute_stop_pos): Ignore a static
3795 composition starting before CHARPOS (Bug#8915).
3796
3797 * xdisp.c (handle_composition_prop): Likewise.
3798
a8815b00
EZ
37992011-07-07 Eli Zaretskii <eliz@gnu.org>
3800
3801 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3802 (Bug#9015)
3803
ef7b981d 38042011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3805
3806 * character.h (unicode_category_t): New enum type.
3807
3808 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3809 (Qchar_code_property_table): New variable.
3810 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3811 (UNIPROP_COMPRESSED_FORM_P): New macros.
3812 (char_table_ascii): Uncompress the compressed values.
3813 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3814 Uncompress the compressed values.
ac389d0c 3815 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3816 (char_table_ref_and_range): Uncompress the compressed values.
3817 (sub_char_table_set): New arg is_uniprop. Callers changed.
3818 Uncompress the compressed values.
3819 (sub_char_table_set_range): Args changed. Callers changed.
3820 (char_table_set_range): Adjuted for the above change.
3821 (map_sub_char_table): Delete args default_val and parent. Add arg
3822 top. Give decoded values to a Lisp function.
640c8776 3823 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3824 values to a Lisp function. Gcpro more variables.
3825 (uniprop_table_uncompress)
3826 (uniprop_decode_value_run_length): New functions.
3827 (uniprop_decoder, uniprop_decoder_count): New variables.
3828 (uniprop_get_decoder, uniprop_encode_value_character)
3829 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3830 New functions.
3831 (uniprop_encoder, uniprop_encoder_count): New variables.
3832 (uniprop_get_encoder, uniprop_table)
3833 (Funicode_property_table_internal, Fget_unicode_property_internal)
3834 (Fput_unicode_property_internal): New functions.
3835 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3836 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3837 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3838 char-code-property-alist.
3839
640c8776 3840 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3841 Vunicode_category_table.
3842
640c8776 3843 * font.c (font_range): Adjust for the change of
c805dec0
KH
3844 Vunicode_category_table.
3845
76b397fb
DN
38462011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3847
3848 * m/iris4d.h: Remove file, move contents ...
3849 * s/irix6-5.h: ... here.
3850
22b4128e
PE
38512011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3854 * alloc.c (mark_buffer):
3855 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3856 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3857 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3858 This isn't true in general, and it's particularly not true
3859 if Emacs is configured with --with-wide-int.
3860 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3861 New macros, used in the buffer.c change.
3862
869795d6
JD
38632011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3864
3865 * xsettings.c: Use both GConf and GSettings if both are available.
3866 (store_config_changed_event): Add comment.
3867 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3868 (store_tool_bar_style_changed): New functions.
5e617bc2 3869 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3870 (struct xsettings): Move font inside HAVE_XFT.
3871 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3872 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3873 Move inside HAVE_XFT.
640c8776 3874 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3875 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3876 also.
3877 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3878 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3879 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3880 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3881 (parse_settings): Move check for font inside HAVE_XFT.
3882 (read_settings, apply_xft_settings): Add comment.
3883 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3884 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3885 call store_font_name_changed.
3886 (xft_settings_event): Add comment.
3887 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3888 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3889 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3890 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3891 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3892 (xsettings_get_system_font, xsettings_get_system_normal_font):
3893 Add comment.
869795d6 3894
d8ed26bd
PE
38952011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 Random fixes. E.g., (random) never returned negative values.
3898 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3899 subseconds part to the entropy, as that's a bit more random.
3900 Prefer signed to unsigned, since the signedness doesn't matter and
3901 in general we prefer signed. When given a limit, use a
3902 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3903 latter isn't right if USE_2_TAGS_FOR_INTS.
3904 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3905 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3906
cabf1cac
SM
39072011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3908
3909 * textprop.c (text_property_stickiness):
3910 Obey Vtext_property_default_nonsticky.
3911 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3912 * w32fns.c (syms_of_w32fns):
3913 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3914
6e9b2be9
PE
39152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3916
3917 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3918 This is more efficient than Ffile_directory_p and avoids a minor race.
3919
90186c68
LMI
39202011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3921
7c301272
LMI
3922 * buffer.c (Foverlay_put): Say what the return value is
3923 (bug#7835).
3924
c4f2d8d4
LMI
3925 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3926 is a directory before asking whether to use the file name
3927 (bug#7564).
ad637907
LMI
3928 (barf_or_query_if_file_exists): Make the "File is a directory"
3929 error be more correct.
c4f2d8d4 3930
90186c68
LMI
3931 * fns.c (Frequire): Remove the mention of the .gz files, since
3932 that's installation-specific, but keep the mention of
3933 `get-load-suffixes'.
3934
da64016e
PE
39352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3938 Report string overflow if the output is too long.
3939
7d47b580
JB
39402011-07-04 Juanma Barranquero <lekktu@gmail.com>
3941
a555cb87
JB
3942 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3943 (syms_of_gnutls): Remove duplicate DEFSYM for
3944 Qgnutls_bootprop_verify_hostname_error, an error for
3945 Qgnutls_bootprop_verify_error (which is no longer used).
3946
7d47b580
JB
3947 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3948 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3949 Also (re)move comments that are misplaced or no longer relevant.
3950
1e49bfab
LMI
39512011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3952
3953 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3954
1485f4c0
CY
39552011-07-03 Chong Yidong <cyd@stupidchicken.com>
3956
3957 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3958 and background color parameters if they have been changed.
3959
a9ab721e
LMI
39602011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3961
3962 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3963
cf7cff57
PE
39642011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3965
2e13213d
PE
3966 * xsettings.c (SYSTEM_FONT): Define only when used.
3967 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3968
cf7cff57
PE
3969 * keymap.c (access_keymap_1): Now static.
3970
7a8e04f7
CY
39712011-07-02 Chong Yidong <cyd@stupidchicken.com>
3972
3973 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3974 leave any prefix arg for the up event (Bug#1586).
3975
61352f62
LMI
39762011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3977
69bb1ef7
LMI
3978 * lread.c (syms_of_lread): Mention single symbols defined by
3979 `defvar' or `defconst' (bug#7154).
3980
61352f62 3981 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3982 (Frequire): Mention get-load-suffixes.
61352f62 3983
28545e04
MR
39842011-07-02 Martin Rudalics <rudalics@gmx.at>
3985
3986 * window.h (window): Remove clone_number slot.
3987 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3988 Remove.
3989 (make_parent_window, make_window, saved_window)
3990 (Fset_window_configuration, save_window_save): Don't deal with
3991 clone numbers.
3992 * buffer.c (Qclone_number): Remove declaration.
3993 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3994
3349e122
SM
39952011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3996
3997 Add multiple inheritance to keymaps.
3998 * keymap.c (Fmake_composed_keymap): New function.
3999 (Fset_keymap_parent): Simplify.
4000 (fix_submap_inheritance): Remove.
4001 (access_keymap_1): New function extracted from access_keymap to handle
4002 embedded parents and handle lists of maps.
4003 (access_keymap): Use it.
4004 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4005 (Fcopy_keymap): Handle embedded parents.
4006 (Fcommand_remapping, define_as_prefix): Simplify.
4007 (Fkey_binding): Simplify.
4008 (syms_of_keymap): Move minibuffer-local-completion-map,
4009 minibuffer-local-filename-completion-map,
4010 minibuffer-local-must-match-map, and
4011 minibuffer-local-filename-must-match-map to Elisp.
4012 (syms_of_keymap): Defsubr make-composed-keymap.
4013 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4014 (parse_menu_item): Trivial simplification.
4015
3279eb87
GM
40162011-07-01 Glenn Morris <rgm@gnu.org>
4017
4018 * Makefile.in (SETTINGS_LIBS): Fix typo.
4019
4550efdf
KI
40202011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4021
4022 * coding.c (Fencode_coding_string): Record the last coding system
4023 used, as the function doc string says (bug#8738).
4024
0949d2b6
JD
40252011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4026
4027 * xsettings.c (store_monospaced_changed): Take new font as arg and
4028 check for change against current_mono_font.
4029 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4030 (emacs_settings_constructor, emacs_settings_get_property)
4031 (emacs_settings_set_property, emacs_settings_class_init)
4032 (emacs_settings_init, gsettings_obj): Remove.
4033 (something_changedCB): New function for HAVE_GSETTINGS.
4034 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4035 with value as argument.
4036 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4037 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4038 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4039 "changed".
4040
4041 * xgselect.c: Add defined (HAVE_GSETTINGS).
4042 (xgselect_initialize): Ditto.
4043
4044 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4045 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4046 xg_select.
4047
bbc6b304
PE
40482011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4049
4050 * eval.c (struct backtrace): Simplify and port the data structure.
4051 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4052 signed bit field, as this assumption is not portable and it makes
4053 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4054 "char debug_on_exit : 1" as this is not portable either; instead,
4055 use the portable "unsigned int debug_on_exit : 1". Remove unused
4056 member evalargs. Remove obsolete comments about cc bombing out.
4057
9851bfc5
JD
40582011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4059
51bb811f 4060 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4061 Let HAVE_GSETTINGS override HAVE_GCONF.
4062 (store_monospaced_changed): New function.
4063 (EMACS_SETTINGS): A new type derived from GObject to handle
4064 GSettings notifications.
4065 (emacs_settings_constructor, emacs_settings_get_property)
4066 (emacs_settings_set_property, emacs_settings_class_init):
4067 New functions.
4068 (gsettings_client, gsettings_obj): New variables.
4069 (GSETTINGS_SCHEMA): New define.
4070 (something_changedCB): Call store_monospaced_changed.
4071 (init_gsettings): New function.
4072 (xsettings_initialize): Call init_gsettings.
4073 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4074 to NULL.
4075
640c8776 4076 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4077 GCONF_CFLAGS/LIBS.
4078
5386012d
MR
40792011-06-29 Martin Rudalics <rudalics@gmx.at>
4080
4081 * window.c (resize_root_window, grow_mini_window)
4082 (shrink_mini_window): Rename Qresize_root_window to
4083 Qwindow_resize_root_window and Qresize_root_window_vertically to
4084 Qwindow_resize_root_window_vertically.
4085
f13e0b08
PE
40862011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4087
4088 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4089
94515237
JB
40902011-06-27 Juanma Barranquero <lekktu@gmail.com>
4091
4092 * makefile.w32-in: Redesign dependencies so they reflect more
4093 clearly which files are directly included by each source file,
4094 and not through other includes.
4095
e43b6e43
MR
40962011-06-27 Martin Rudalics <rudalics@gmx.at>
4097
4098 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4099 (sort_overlays, overlay_strings): When an overlay's clone number
4100 matches the window's clone number process the overlay even if
4101 the overlay's window property doesn't match the current window.
4102
d68443dc
MR
4103 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4104 (Fwindow_hchild): Rename to Fwindow_left_child.
4105 (Fwindow_next): Rename to Fwindow_next_sibling.
4106 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4107 (resize_window_check): Rename to window_resize_check.
4108 (resize_window_apply): Rename to window_resize_apply.
4109 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4110 (Fdelete_other_windows_internal, resize_frame_windows)
4111 (Fsplit_window_internal, Fdelete_window_internal)
4112 (grow_mini_window, shrink_mini_window)
4113 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4114
c7e73be5
JD
41152011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4116
4117 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4118 (emacs_fixed_set_min_size): Remove.
4119 (emacs_fixed_new): Take frame as argument.
4120
4121 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4122 (_EmacsFixedPrivate): Remove minwidth/height.
4123 Add struct frame *f.
4124 (emacs_fixed_init): Initialize priv->f.
4125 (get_parent_class, emacs_fixed_set_min_size): Remove.
4126 (emacs_fixed_new): Set priv->f to argument.
4127 (emacs_fixed_get_preferred_width)
4128 (emacs_fixed_get_preferred_height): Use min_width/height from
4129 frames size_hint to set minimum and natural (Bug#8919).
4130 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4131 and use min_width/height from frames size_hint to set
4132 min_width/height (Bug#8919).
4133
4134 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4135 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4136 Fix indentation.
c7e73be5 4137
cf99dcf8
EZ
41382011-06-26 Eli Zaretskii <eliz@gnu.org>
4139
4140 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4141 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4142 called at ZV.
4143
029529ac
CY
41442011-06-26 Chong Yidong <cyd@stupidchicken.com>
4145
4146 * process.c (wait_reading_process_output): Bypass select if
4147 waiting for a cell while ignoring keyboard input, and input is
4148 pending. Suggested by Jan Djärv (Bug#8869).
4149
7a7ef429
PE
41502011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4151
4152 Use gnulib's dup2 module instead of rolling our own.
4153 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4154
11fdef7d 41552011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4156
4157 * dispnew.c (scrolling_window): Before scrolling, turn off a
4158 mouse-highlight in the window being scrolled.
4159
cd3520a4
JB
41602011-06-24 Juanma Barranquero <lekktu@gmail.com>
4161
4162 Move DEFSYM to lisp.h and use everywhere.
4163
4164 * character.h (DEFSYM): Move declaration...
4165 * lisp.h (DEFSYM): ...here.
4166
4167 * gnutls.c:
4168 * minibuf.c:
4169 * w32menu.c:
4170 * w32proc.c:
4171 * w32select.c: Don't include character.h.
4172
4173 * alloc.c (syms_of_alloc):
4174 * buffer.c (syms_of_buffer):
4175 * bytecode.c (syms_of_bytecode):
4176 * callint.c (syms_of_callint):
4177 * casefiddle.c (syms_of_casefiddle):
4178 * casetab.c (init_casetab_once):
4179 * category.c (init_category_once, syms_of_category):
4180 * ccl.c (syms_of_ccl):
4181 * cmds.c (syms_of_cmds):
4182 * composite.c (syms_of_composite):
4183 * dbusbind.c (syms_of_dbusbind):
4184 * dired.c (syms_of_dired):
4185 * dispnew.c (syms_of_display):
4186 * doc.c (syms_of_doc):
4187 * editfns.c (syms_of_editfns):
4188 * emacs.c (syms_of_emacs):
4189 * eval.c (syms_of_eval):
4190 * fileio.c (syms_of_fileio):
4191 * fns.c (syms_of_fns):
4192 * frame.c (syms_of_frame):
4193 * fringe.c (syms_of_fringe):
4194 * insdel.c (syms_of_insdel):
4195 * keymap.c (syms_of_keymap):
4196 * lread.c (init_obarray, syms_of_lread):
4197 * macros.c (syms_of_macros):
4198 * msdos.c (syms_of_msdos):
4199 * print.c (syms_of_print):
4200 * process.c (syms_of_process):
4201 * search.c (syms_of_search):
4202 * sound.c (syms_of_sound):
4203 * syntax.c (init_syntax_once, syms_of_syntax):
4204 * terminal.c (syms_of_terminal):
4205 * textprop.c (syms_of_textprop):
4206 * undo.c (syms_of_undo):
4207 * w32.c (globals_of_w32):
4208 * window.c (syms_of_window):
4209 * xdisp.c (syms_of_xdisp):
4210 * xfaces.c (syms_of_xfaces):
4211 * xfns.c (syms_of_xfns):
4212 * xmenu.c (syms_of_xmenu):
4213 * xsettings.c (syms_of_xsettings):
4214 * xterm.c (syms_of_xterm): Use DEFSYM.
4215
4228cf16
TZ
42162011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4217
cd3520a4 4218 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4219
7fcccf1e
PE
42202011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4221
7efb4e0e
PE
4222 Integer and buffer overflow fixes (Bug#8873).
4223
ff5844ad
PE
4224 * print.c (printchar, strout): Check for string overflow.
4225 (PRINTPREPARE, printchar, strout):
4226 Don't set size unless allocation succeeds.
4227
90532f02
PE
4228 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4229 for sizes. Check for string overflow more accurately.
4230 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4231
6d84508d
PE
4232 * macros.c: Integer and buffer overflow fixes.
4233 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4234 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4235 Use ptrdiff_t, not int, for sizes.
4236 Don't increment bufsize until after realloc succeeds.
4237 Check for size-calculation overflow.
4238 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4239
437b2cb4
PE
4240 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4241
8b9ac8b4
PE
4242 * lread.c: Integer overflow fixes.
4243 (read_integer): Radix is now EMACS_INT, not int,
4244 to improve quality of diagnostics for out-of-range radices.
4245 Calculate buffer size correctly for out-of-range radices.
4246 (read1): Check for integer overflow in radices, and in
4247 read-circle numbers.
82cb60d3
PE
4248 (read_escape): Avoid int overflow.
4249 (Fload, openp, read_buffer_size, read1)
4250 (substitute_object_recurse, read_vector, read_list, map_obarray):
4251 Use ptrdiff_t, not int, for sizes.
4252 (read1): Use EMACS_INT, not int, for sizes.
20270765 4253 Check for size overflow.
8b9ac8b4 4254
7fcccf1e
PE
4255 * image.c (cache_image): Check for size arithmetic overflow.
4256
bfbbd7e7
PE
4257 * lread.c: Integer overflow issues.
4258 (saved_doc_string_size, saved_doc_string_length)
4259 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4260 Now ptrdiff_t, not int.
4261 (read1): Don't assume doc string length fits in int. Check for
4262 out-of-range doc string lengths.
4263 (read_list): Don't assume file position fits in int.
39019e54 4264 (read_escape): Check for hex character overflow.
bfbbd7e7 4265
4e323265
LL
42662011-06-22 Leo Liu <sdl.web@gmail.com>
4267
4268 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4269 Move to minibuffer.el.
4270
85fece3e
PE
42712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4272
20b84ce9 4273 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4274 The following patches are for when GLYPH_DEBUG && !XASSERT.
4275 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4276 * dispnew.c (flush_stdout):
4277 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4278 Mark as externally visible.
4279 * dispnew.c (check_window_matrix_pointers): Now static.
4280 * dispnew.c (window_to_frame_vpos):
4281 * xfns.c (unwind_create_frame):
4282 * xterm.c (x_check_font): Remove unused local.
4283 * scroll.c (CHECK_BOUNDS):
4284 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4285 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4286 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4287 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4288 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4289 Now static.
4290 (debug_method_add): Use va_list and vsprintf rather than relying
4291 on undefined behavior with wrong number of arguments.
4292 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4293 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4294 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4295 since we're not interested in debugging glyphs with old libraries.
4296 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4297 GCC 4.6.0's static checking.
4298
0766b489
PE
42992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4300
31fd4b32
PE
4301 Integer overflow and signedness fixes (Bug#8873).
4302 A few related buffer overrun fixes, too.
4303
b79e8648
PE
4304 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4305
0766b489
PE
4306 * dispextern.h (struct face.stipple):
4307 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4308 (x_bitmap_mask, x_allocate_bitmap_record)
4309 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4310 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4311 (x_create_bitmap_from_xpm_data):
4312 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4313 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4314 (.bitmaps_last):
4315 * xfaces.c (load_pixmap):
4316 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4317 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4318 (.bitmaps_last, struct x_output.icon_bitmap):
4319 Use ptrdiff_t, not int, for bitmap indexes.
4320 (x_allocate_bitmap_record): Check for size overflow.
4321 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4322
b081724f
PE
4323 Use ptrdiff_t, not int, for overlay counts.
4324 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4325 * editfns.c (overlays_around, get_pos_property):
4326 * textprop.c (get_char_property_and_overlay):
4327 * xdisp.c (next_overlay_change, note_mouse_highlight):
4328 * xfaces.c (face_at_buffer_position):
21514da7
PE
4329 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4330 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4331 (Fnext_overlay_change, Fprevious_overlay_change)
4332 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4333 Use ptrdiff_t, not int, for sizes.
21514da7 4334 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4335
3de73e5e
PE
4336 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4337
2606c57b
PE
4338 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4339 (x_session_initialize): Do not assume string length fits in int.
4340
aaafe47a
PE
4341 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4342 This is unlikely, but can occur if DPI is outlandish.
4343
2674ddc8 4344 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4345 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4346
28154962
PE
4347 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4348 * xrdb.c (magic_file_p, search_magic_path):
4349 Omit last arg SUFFIX; it was always 0. All callers changed.
4350 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4351
7de51af5
PE
4352 * xfont.c (xfont_match): Avoid need for strlen.
4353
25ed6cc3
PE
4354 * xfns.c: Don't assume strlen fits in int.
4355 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4356
4eab31dd
PE
4357 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4358 not unsigned long, as we prefer signed integers. All callers changed.
4359 Detect integer overflow in repeat count.
4360 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4361 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4362
171e2a58
PE
4363 * termcap.c: Don't assume sizes fit in int and never overflow.
4364 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4365 (gobble_line): Check for size-calculation overflow.
4366
ad39faca 4367 * minibuf.c (Fread_buffer):
6e5bb2dc 4368 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4369 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4370 Don't assume string length fits in int.
4371
52c61c22 4372 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4373 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4374
b5b8c9e5
PE
4375 * font.c: Don't assume string length fits in int.
4376 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4377 Use ptrdiff_t, not int.
ccd6111c
PE
4378 (font_intern_prop): Don't assume string length fits in int.
4379 Don't assume integer property fits in fixnum.
4380 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4381
882f0d81 4382 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4383 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4384 Reformulate so as not to need the command string.
4385 Invoke gzip -cd rather than gunzip, as it's more portable.
4386 (lock_info_type, lock_file_1, lock_file):
4387 Don't assume pid_t and time_t fit in unsigned long.
4388 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4389 (current_lock_owner): Prefer signed type for sizes.
4390 Use memcpy, not strncpy, where memcpy is what is really wanted.
4391 Don't assume (via atoi) that time_t and pid_t fit in int.
4392 Check for time_t and/or pid_t out of range, e.g., via a network share.
4393 Don't alloca where an auto var works fine.
4394
93f4cf88
PE
4395 * fileio.c: Fix some integer overflow issues.
4396 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4397 Don't assume string length fits in int.
4398 (directory_file_name): Don't assume string length fits in long.
4399 (make_temp_name): Don't assume pid fits in int, or that its print
4400 length is less than 20.
4401
f3e92b69
PE
4402 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4403
1bfdaf10
PE
4404 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4405
35016e9a
PE
4406 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4407
3d1e65a1
PE
4408 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4409 We prefer signed integers, even for size calculations.
4410
0b963a93
PE
4411 * emacs.c: Don't assume string length fits in 'int'.
4412 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4413 (main): Don't invoke strlen when not needed.
4414
573f4b54
PE
4415 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4416 (XD_DEBUG_MESSAGE): Don't waste a byte.
4417
989f33ba
PE
4418 * callproc.c (getenv_internal_1, getenv_internal)
4419 (Fgetenv_internal):
965d34eb
PE
4420 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4421
e4d29b33
PE
4422 * lread.c (invalid_syntax): Omit length argument.
4423 All uses changed. This doesn't fix a bug, but it simplifies the
4424 code away from its former Hollerith-constant appearance, and it's
4425 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4426 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4427
eb49b136
PE
4428 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4429 This didn't break anything, but it didn't help either.
4430 It's confusing to put a bogus integer in a place where the actual
4431 value does not matter.
9f62aeb1 4432 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4433 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4434
15375a22
PE
4435 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4436 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4437 implementation.
b61cc01c
PE
4438 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4439 We prefer signed types, and the value cannot exceed the EMACS_INT
4440 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4441 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4442 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4443 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4444
53b2623d
PE
4445 * indent.c (sane_tab_width): New function.
4446 (current_column, scan_for_column, Findent_to, position_indentation)
4447 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4448 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4449
51cab52b 4450 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4451
f2ed8a70
PE
4452 * lisp.h (lint_assume): New macro.
4453 * composite.c (composition_gstring_put_cache):
4454 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4455
abe80cc6
PE
4456 * editfns.c, insdel.c:
4457 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4458
b02c740e
PE
4459 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4460
ebc96716
PE
4461 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4462
b4e50fa0 4463 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4464 Use much-faster test for byte-length change.
311d5d7c 4465 Don't assume string byte-length fits in 'int'.
a4cf38e4 4466 Check that character arg fits in 'int'.
85461888 4467 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4468
c0c1ee9f
PE
4469 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4470
a498d7f4
PE
4471 * fns.c (concat): Catch string overflow earlier.
4472 Do not rely on integer wraparound.
4473
51cab52b
PE
4474 * dispextern.h (struct it.overlay_strings_charpos)
4475 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4476 * xdisp.c (forward_to_next_line_start)
4477 (back_to_previous_visible_line_start)
4478 (reseat_at_next_visible_line_start, next_element_from_buffer):
4479 Don't arbitrarily truncate the value of 'selective' to int.
4480
76031fad
PE
4481 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4482
5eb55db9
PE
4483 * composite.c: Don't truncate sizes to 'int'.
4484 (composition_gstring_p, composition_reseat_it)
4485 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4486 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4487 not EMACS_UINT, for indexes.
5eb55db9 4488
0703a717
PE
4489 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4490
d6202519
PE
4491 * buffer.c: Include <verify.h>.
4492 (struct sortvec.priority, struct sortstr.priority):
8961a454 4493 Now EMACS_INT, not int.
c20998a7 4494 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4495 (struct sortstr.size, record_overlay_string)
4496 (struct sortstrlist.size, struct sortlist.used):
4497 Don't truncate size to int.
4498 (record_overlay_string): Check for size-calculation overflow.
d6202519 4499 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4500
d5a19415
JM
45012011-06-22 Jim Meyering <meyering@redhat.com>
4502
029529ac 4503 Don't leak an XBM-image-sized buffer
d5a19415
JM
4504 * image.c (xbm_load): Free the image buffer after using it.
4505
a9041e6c
PE
45062011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4507
4508 Port to Sun C.
4509 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4510 that Sun C diagnosed.
4511 * fns.c (secure_hash): Fix pointer signedness issue.
4512 * intervals.c (static_offset_intervals): New function.
4513 (offset_intervals): Use it.
4514
7f3f739f
LL
45152011-06-21 Leo Liu <sdl.web@gmail.com>
4516
4517 * deps.mk (fns.o):
4518 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4519 sha512.h.
4520
4521 * fns.c (secure_hash): Rename from crypto_hash_function and change
4522 the first arg to accept symbols.
5b66d427 4523 (Fsecure_hash): New primitive.
7f3f739f
LL
4524 (syms_of_fns): New symbols.
4525
76147d94
DD
45262011-06-20 Deniz Dogan <deniz@dogan.se>
4527
4528 * process.c (Fset_process_buffer): Clarify return value in
4529 docstring.
4530
7d7d0045
CY
45312011-06-18 Chong Yidong <cyd@stupidchicken.com>
4532
4533 * dispnew.c (add_window_display_history): Use BVAR.
4534
4535 * xdisp.c (debug_method_add): Use BVAR.
4536 (check_window_end, dump_glyph_matrix, dump_glyph)
4537 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4538
4539 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4540 Likewise.
4541
4542 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4543 check till after the cache is created in init_frame_faces.
4544
ff2bc410
SM
45452011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4546
4547 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4548
28177add
PE
45492011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4550
dd3482fe
PE
4551 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4552 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4553 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4554
393d71f3 4555 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4556 * fileio.c (Finsert_file_contents):
4557 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4558 Remove the old (too-loose) buffer overflow checks.
4559 They weren't needed, since make_gap checks for buffer overflow.
4560 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4561 The old code merely checked for Emacs fixnum overflow, and relied
4562 on undefined (wraparound) behavior. The new code avoids undefined
4563 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4564
2e6813b0 4565 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4566 Tune. Don't use wider integers than needed. Don't use alloca.
4567 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4568
599a9e4f
PE
4569 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4570
99561444
PE
4571 * insdel.c, lisp.h (buffer_overflow): New function.
4572 (insert_from_buffer_1, replace_range, replace_range_2):
4573 * insdel.c (make_gap_larger):
4574 * editfns.c (Finsert_char):
4575 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4576
28177add
PE
4577 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4578
e69dafad
PE
45792011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4580
4baa020d 4581 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4582
b1c46f02
PE
4583 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4584 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4585
e69dafad
PE
4586 * fileio.c: Don't assume EMACS_INT fits in off_t.
4587 (emacs_lseek): New static function.
4588 (Finsert_file_contents, Fwrite_region): Use it.
4589 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4590
566684ea
PE
4591 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4592
e6966cd6
PE
4593 * fns.c: Don't overflow int when computing a list length.
4594 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4595 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4596 truncation on 64-bit hosts. Check for QUIT every
4597 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4598 faster and is responsive enough.
4599 (Flength): Report an error instead of overflowing an integer.
4600 (Fsafe_length): Return a float if the value is not representable
4601 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4602 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4603 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4604
dd0b0efb
PE
4605 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4606 (header_size, word_size): New constants.
4607 (allocate_vectorlike): Don't check size overflow here.
4608 (allocate_vector): Check it here instead, since this is the only
4609 caller of allocate_vectorlike that could cause overflow.
4610 Check that the new vector's length is representable as a fixnum.
4611
86fe5cfe
PE
4612 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4613 The previous code was bogus. For example, next_almost_prime (32)
4614 returned 39, which is undesirable as it is a multiple of 3; and
4615 next_almost_prime (24) returned 25, which is a multiple of 5 so
4616 why was the code bothering to check for multiples of 7?
4617
80e88859
PE
4618 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4619
4a2f0ad6
PE
4620 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4621
f66c7cf8
PE
4622 Variadic C functions now count arguments with ptrdiff_t.
4623 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4624 Back then I didn't know that the Emacs coding style prefers signed int.
4625 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4626 were being counted with int, which may truncate counts on 64-bit
4627 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4628 * lisp.h (struct Lisp_Subr.function.aMANY)
4629 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4630 Arg counts are now ptrdiff_t, not size_t.
4631 All variadic functions and their callers changed accordingly.
4632 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4633 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4634 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4635 * callint.c (Fcall_interactively): Check arg count for overflow,
4636 to avoid potential buffer overrun. Use signed char, not 'int',
4637 for 'varies' array, so that we needn't bother to check its size
4638 calculation for overflow.
4639 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4640 * eval.c (apply_lambda):
4641 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4642 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4643 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4644
a1759b76
PE
4645 * callint.c (Fcall_interactively): Don't use index var as event count.
4646
d96be9fc
PE
4647 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4648 * mem-limits.h (SIZE): Remove; no longer used.
4649
a690a978 4650 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4651
578c21e6
PE
4652 Remove unnecessary casts.
4653 * xterm.c (x_term_init):
4654 * xfns.c (x_set_border_pixel):
4655 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4656 These aren't needed now that we assume ANSI C.
4657
96f53c6c
PE
4658 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4659 It's more likely to cause problems (due to unsigned overflow)
4660 than to cure them.
4661
83c77d31
PE
4662 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4663
ee2079f1
PE
4664 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4665
6da65536
PE
4666 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4667
7147c4a4
PE
4668 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4669
193e32d9
PE
4670 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4671
e5533da6
PE
4672 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4673
9910e595
PE
4674 GLYPH_CODE_FACE returns EMACS_INT, not int.
4675 * dispextern.h (merge_faces):
4676 * xfaces.c (merge_faces):
01103c44
PE
4677 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4678 Don't assume EMACS_INT fits in int.
9910e595 4679
2638320e
PE
4680 * character.h (CHAR_VALID_P): Remove unused parameter.
4681 * fontset.c, lisp.h, xdisp.c: All uses changed.
4682
045eb8d9
PE
4683 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4684
c1f134b5
PE
4685 * fns.c (concat): Minor tuning based on overflow analysis.
4686 This doesn't fix any bugs. Use int to hold character, instead
4687 of constantly refetching from Emacs object. Use XFASTINT, not
4688 XINT, for value known to be a character. Don't bother comparing
4689 a single byte to 0400, as it's always less.
4690
395fcb93 4691 * floatfns.c (Fexpt):
327eeec8
PE
4692 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4693
abbd3d23
PE
4694 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4695 for characters.
4696
684a03ef
PE
4697 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4698
0fed43f3
PE
4699 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4700 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4701 incorrectly succeed when S was a string, because 4294967386 was
4702 truncated before it was used.
4703
8fd02eb7
PE
4704 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4705 Otherwise, an out-of-range integer could cause undefined behavior
4706 on a 64-bit host.
4707
f8c86b69
PE
4708 * composite.c: Use int, not EMACS_INT, for characters.
4709 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4710 EMACS_INT, for values that are known to be in character range.
4711 This doesn't fix any bugs but is the usual style inside Emacs and
4712 may generate better code on 32-bit machines.
4713
34206dd2
PE
4714 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4715 This is for reasons similar to the recent CHAR_STRING fix.
4716 * charset.c (Fencode_char): Check that character arg is actually
4717 a character. Pass an int to ENCODE_CHAR.
4718 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4719 wider than 'int', as a compile-time check to prevent future regressions
4720 in this area.
4721
c5958d4c 4722 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4723
4724 Make sure a 64-bit char is never passed to CHAR_STRING.
4725 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4726 by silently ignoring the top 32 bits, allowing some values
4727 that were far too large to be valid characters.
4728 * character.h: Include <verify.h>.
4729 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4730 arguments are no wider than unsigned, as a compile-time check
4731 to prevent future regressions in this area.
4732 * data.c (Faset):
01103c44 4733 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4734 (Fsubst_char_in_region):
4735 * fns.c (concat):
4736 * xdisp.c (decode_mode_spec_coding):
4737 Adjust to CHAR_STRING's new requirement.
4738 * editfns.c (Finsert_char, Fsubst_char_in_region):
4739 * fns.c (concat): Check that character args are actually
4740 characters. Without this test, these functions did the wrong
4741 thing with wildly out-of-range values on 64-bit hosts.
4742
d37ca623
PE
4743 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4744 These casts should not be needed on 32-bit hosts, either.
4745 * keyboard.c (read_char):
4746 * lread.c (Fload): Remove casts to unsigned.
4747
ea204efb
PE
4748 * lisp.h (UNSIGNED_CMP): New macro.
4749 This fixes comparison bugs on 64-bit hosts.
4750 (ASCII_CHAR_P): Use it.
4751 * casefiddle.c (casify_object):
01103c44 4752 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4753 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4754 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4755 * dispextern.h (FACE_FROM_ID):
4756 * keyboard.c (read_char): Use UNSIGNED_CMP.
4757
41cb286c
PE
4758 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4759 not to EMACS_INT, to avoid GCC warning.
4760
4a1b9832
PE
4761 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4762
55daad71
PE
4763 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4764 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4765 isn't needed on 32-bit machines.
8f95c75c 4766
01103c44
PE
4767 * buffer.c (Fgenerate_new_buffer_name):
4768 Use EMACS_INT for count, not int.
0ceccced 4769 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4770
4771 * data.c (Qcompiled_function): Now static.
4772
c6f072e7
PE
4773 * window.c (window_body_lines): Now static.
4774
20ce5912
PE
4775 * image.c (gif_load): Rename local to avoid shadowing.
4776
9c4c5f81
PE
4777 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4778 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4779 * alloc.c (make_save_value): Integer argument is now of type
4780 ptrdiff_t, not int.
4781 (mark_object): Use ptrdiff_t, not int.
4782 * lisp.h (pD): New macro.
4783 * print.c (print_object): Use it.
4784
c0c5c8ae
PE
4785 * alloc.c: Use EMACS_INT, not int, to count objects.
4786 (total_conses, total_markers, total_symbols, total_vector_size)
4787 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4788 (total_free_floats, total_floats, total_free_intervals)
4789 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4790 Now EMACS_INT, not int. All uses changed.
4791 (Fgarbage_collect): Compute overall total using a double, so that
4792 integer overflow is less likely to be a problem. Check for overflow
4793 when converting back to an integer.
5a25e253
PE
4794 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4795 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4796 These were 'int' variables that could overflow on 64-bit hosts;
4797 they were never used, so remove them instead of repairing them.
211a0b2a 4798 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4799 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4800 Previously, this ceilinged at INT_MAX, but that doesn't work on
4801 64-bit machines.
e46bb31a 4802 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4803
c78baabf 4804 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4805 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4806 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4807 when a (possibly-narrower) signed value would do just as well.
4808 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4809
c9d624c6
PE
4810 * alloc.c: Catch some string size overflows that we were missing.
4811 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4812 for convenience in STRING_BYTES_MAX.
4813 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4814 The definition here is exact; the one in lisp.h was approximate.
4815 (allocate_string_data): Check for string overflow. This catches
4816 some instances we weren't catching before. Also, it catches
4817 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4818 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4819 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4820
c9d624c6
PE
4821 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4822 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4823 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4824
353032ce
PE
4825 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4826
2bccce07
PE
4827 * alloc.c (Fmake_string): Check for out-of-range init.
4828
0ac30604
SM
48292011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4830
4831 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4832
c195f2de
JD
48332011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4834
4835 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4836 xg_get_default_scrollbar_width.
4837
4838 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4839 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4840 (style_changed_cb): Call update_theme_scrollbar_width and call
4841 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4842 all frames (Bug#8505).
4843 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4844 Call gtk_window_set_resizable if HAVE_GTK3.
4845 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4846 and height if HAVE_GTK3 (Bug#8505).
4847 (scroll_bar_width_for_theme): New variable.
4848 (update_theme_scrollbar_width): New function.
4849 (xg_get_default_scrollbar_width): Move code to
4850 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4851 (xg_initialize): Call update_theme_scrollbar_width.
4852
4853 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4854
4855 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4856
e10ac9f1
MR
48572011-06-12 Martin Rudalics <rudalics@gmx.at>
4858
4859 * frame.c (make_frame): Call other_buffer_safely instead of
4860 other_buffer.
4861
4862 * window.c (temp_output_buffer_show): Call display_buffer with
4863 second argument Vtemp_buffer_show_specifiers and reset latter
4864 immediately after the call.
4865 (Vtemp_buffer_show_specifiers): New variable.
4866 (auto_window_vscroll_p, next_screen_context_lines)
4867 (Vscroll_preserve_screen_position): Remove leading asterisks from
4868 doc-strings.
4869
2d3c217e 48702011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4871
7b7f97e8 4872 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4873 * buffer.c (Qclone_number): Remove for now, as it's unused.
4874 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4875 (record_buffer): Remove unused local.
4876 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4877 (set_frame_buffer_list): Remove; unused.
4878 * frame.h (other_visible_frames): Remove decl.
4879 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4880 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4881 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4882 if HAVE_GPM.
4883 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4884 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4885 Define only if HAVE_GPM.
4886 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4887 (update_hints_inhibit): Remove; never set. All uses removed.
4888 * widgetprv.h (emacsFrameClassRec): Remove decl.
4889 * window.c (delete_deletable_window): Now returns void, since it
4890 wasn't returning anything.
4891 (compare_window_configurations): Remove unused locals.
4892 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4893 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4894 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4895 the same widths as pointers. This follows up on the 2011-05-06 patch.
4896 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4897 * xterm.h: Likewise.
4898 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4899
1384b89e
JB
49002011-06-12 Juanma Barranquero <lekktu@gmail.com>
4901
4902 * makefile.w32-in: Update dependencies.
4903 (LISP_H): Add lib/intprops.h.
4904
1100a63c
CY
49052011-06-11 Chong Yidong <cyd@stupidchicken.com>
4906
4907 * image.c (gif_load): Add animation frame delay to the metadata.
4908 (syms_of_image): Use DEFSYM. New symbol `delay'.
4909
6198ccd0
MR
49102011-06-11 Martin Rudalics <rudalics@gmx.at>
4911
4912 * window.c (delete_deletable_window): Re-add.
4913 (Fset_window_configuration): Rewrite to handle dead buffers and
4914 consequently deletable windows.
4915 (window_tree, Fwindow_tree): Remove. Supply functionality in
4916 window.el.
4917 (compare_window_configurations): Simplify code.
4918
b6e3633c
AS
49192011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4920
1ab0dee5
AS
4921 * image.c (imagemagick_load_image): Fix type mismatch.
4922 (Fimagemagick_types): Likewise.
4923
b6e3633c
AS
4924 * window.h (replace_buffer_in_windows): Declare.
4925
9397e56f
MR
49262011-06-11 Martin Rudalics <rudalics@gmx.at>
4927
4928 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4929 Qclone_number. Remove external declaration of Qdelete_window.
4930 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4931 code.
640c8776
SM
4932 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4933 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4934 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4935 buffer list implementation.
4936 (other_buffer_safely): New function.
4937 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4938 calls to replace_buffer_in_windows and
4939 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4940 if allowed.
4941 (record_buffer): Inhibit quitting and rewrite using quittable
4942 functions. Run Qbuffer_list_update_hook if allowed.
4943 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4944 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4945 Move switch-to-buffer to window.el.
9397e56f
MR
4946 (bury-buffer): Move to window.el.
4947 (Vbuffer_list_update_hook): New variable.
4948
4949 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4950 section.
4951
4952 * window.h (resize_frame_windows): Move up in code.
4953 (Fwindow_frame): Remove EXFUN.
4954 (replace_buffer_in_all_windows): Remove prototype.
4955 (replace_buffer_in_windows_safely): Add prototype.
4956
4957 * window.c: Declare Qdelete_window static again. Move down
4958 declaration of select_count.
4959 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4960 (Fother_window): Move to window.el.
4961 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4962 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4963 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4964 window.el.
4965 (replace_buffer_in_windows): Implement by calling
4966 Qreplace_buffer_in_windows.
4967 (replace_buffer_in_all_windows): Remove with some functionality
4968 moved into replace_buffer_in_windows_safely.
4969 (replace_buffer_in_windows_safely): New function.
4970 (select_window_norecord, select_frame_norecord): Move in front
4971 of run_window_configuration_change_hook. Remove now obsolete
4972 declarations.
640c8776
SM
4973 (Fset_window_buffer): Rewrite doc-string.
4974 Call Qrecord_window_buffer.
9397e56f
MR
4975 (keys_of_window): Move binding for other-window to window.el.
4976
b50691aa
CY
49772011-06-11 Chong Yidong <cyd@stupidchicken.com>
4978
4979 * dispextern.h (struct image): Replace data member, whose int_val
4980 and ptr_val fields were not used by anything, with a single
4981 lisp_val object.
4982
4983 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4984 (gif_clear_image, gif_load, imagemagick_load_image)
4985 (gs_clear_image, gs_load): Callers changed.
4986
3f754b86
PE
49872011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4988
cca69397
PE
4989 * buffer.h: Include <time.h>, for time_t.
4990 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4991
109e28d0
PE
4992 Fix minor problems found by static checking.
4993
60737f02
PE
4994 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4995
4b66faf3
PE
4996 Make identifiers static if they are not used in other modules.
4997 * data.c (Qcompiled_function, Qframe, Qvector):
4998 * image.c (QimageMagick, Qsvg):
4999 * minibuf.c (Qmetadata):
5000 * window.c (resize_window_check, resize_root_window): Now static.
5001 * window.h (resize_window_check, resize_root_window): Remove decls.
5002
109e28d0
PE
5003 * window.c (window_deletion_count, delete_deletable_window):
5004 Remove; unused.
46a4ce9e
PE
5005 (window_body_lines): Now static.
5006 (Fdelete_other_windows_internal): Mark vars as initialized.
5007 Make sure 'resize_failed' is initialized.
5008 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5009 (resize_window_apply): Remove unused local.
5010 * window.h (delete_deletable_window): Remove decl.
5011
109e28d0 5012 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5013 (imagemagick_load_image): Fix pointer signedness problem by changing
5014 last arg from unsigned char * to char *. All uses changed.
5015 Also, fix a local for similar reasons.
5016 Remove unused locals. Remove locals to avoid shadowing.
5017 (fn_rsvg_handle_free): Remove; unused.
5018 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5019 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5020
3f754b86
PE
5021 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5022
2547adb1
CY
50232011-06-10 Chong Yidong <cyd@stupidchicken.com>
5024
5025 * image.c (gif_load): Fix omitted cast error introduced by
5026 2011-06-06 change.
5027
2c8e37d4
MR
50282011-06-10 Martin Rudalics <rudalics@gmx.at>
5029
5030 * window.h (resize_proportionally, orig_total_lines)
5031 (orig_top_line): Remove from window structure.
5032 (set_window_height, set_window_width, change_window_heights)
5033 (Fdelete_window): Remove prototypes.
5034 (resize_frame_windows): Remove duplicate declaration.
5035
440a42e3
EZ
50362011-06-10 Eli Zaretskii <eliz@gnu.org>
5037
5038 * window.h (resize_frame_windows, resize_window_check)
5039 (delete_deletable_window, resize_root_window)
5040 (resize_frame_windows): Declare prototypes.
5041
5042 * window.c (resize_window_apply): Make definition be "static" to
5043 match the prototype.
5044
562dd5e9
MR
50452011-06-10 Martin Rudalics <rudalics@gmx.at>
5046
5047 * window.c: Remove declarations of Qwindow_size_fixed,
5048 window_min_size_1, window_min_size_2, window_min_size,
5049 size_window, window_fixed_size_p, enlarge_window, delete_window.
5050 Remove static from declaration of Qdelete_window, it's
5051 temporarily needed by Fbury_buffer.
5052 (replace_window): Don't assign orig_top_line and
5053 orig_total_lines.
5054 (Fdelete_window, delete_window): Remove. Window deletion is
5055 handled by window.el.
640c8776
SM
5056 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5057 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5058 (Fdelete_other_windows): Remove. Deleting other windows is
5059 handled by window.el.
5060 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5061 handled in window.el.
5062 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5063 Window minimum sizes are handled in window.el.
5064 (shrink_windows, size_window, set_window_height)
5065 (set_window_width, change_window_heights, window_height)
5066 (window_width, CURBEG, CURSIZE, enlarge_window)
5067 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5068 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5069 handled in window.el.
5070 (make_dummy_parent): Rename to make_parent_window and give it a
5071 second argument horflag.
5072 (make_window): Don't set resize_proportionally any more.
5073 (Fsplit_window): Remove. Windows are split in window.el.
5074 (save_restore_action, save_restore_orig_size)
5075 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5076 Resize mini windows in window.el.
5077 (grow_mini_window, shrink_mini_window): Implement by calling
5078 Qresize_root_window_vertically, resize_window_check and
5079 resize_window_apply.
640c8776
SM
5080 (saved_window, Fset_window_configuration, save_window_save):
5081 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5082 resize_proportionally.
5083 (window_min_height, window_min_width): Move to window.el.
5084 (keys_of_window): Move bindings for delete-other-windows,
5085 split-window, delete-window and enlarge-window to window.el.
5086
5087 * buffer.c: Temporarily extern Qdelete_window.
5088 (Fbury_buffer): Temporarily call Qdelete_window instead of
5089 Fdelete_window (Fbury_buffer will move to window.el soon).
5090
5091 * frame.c (set_menu_bar_lines_1): Remove code handling
5092 orig_top_line and orig_total_lines.
5093
5094 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5095 set_window_height but set heights directly.
5096 (change_frame_size_1): Use resize_frame_windows.
5097
5098 * xdisp.c (init_xdisp): Don't use set_window_height but set
5099 heights directly.
5100
640c8776
SM
5101 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5102 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5103 run_window_configuration_change_hook.
5104
5105 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5106 instead of change_window_heights and run
5107 run_window_configuration_change_hook.
5108
1a13852e
MR
51092011-06-09 Martin Rudalics <rudalics@gmx.at>
5110
5111 * window.c (replace_window): Rename second argument REPLACEMENT to
5112 NEW. New third argument SETFLAG. Rewrite.
5113 (delete_window, make_dummy_parent): Call replace_window with
5114 third argument 1.
5115 (window_list_1): Move down in code.
5116 (run_window_configuration_change_hook): Move set_buffer part
5117 before select_frame_norecord part in order to unwind correctly.
5118 Rename count1 to count.
5119 (recombine_windows, delete_deletable_window, resize_root_window)
5120 (Fdelete_other_windows_internal)
5121 (Frun_window_configuration_change_hook, make_parent_window)
5122 (resize_window_check, resize_window_apply, Fresize_window_apply)
5123 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5124 (Fdelete_window_internal, Fresize_mini_window_internal):
5125 New functions.
1a13852e
MR
5126 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5127
f3d1777e
MR
51282011-06-08 Martin Rudalics <rudalics@gmx.at>
5129
496e208e
MR
5130 * window.h (window): Add some new members to window structure -
5131 normal_lines, normal_cols, new_total, new_normal, clone_number,
5132 splits, nest, prev_buffers, next_buffers.
5133 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5134 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5135
f3d1777e
MR
5136 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5137 Remove.
496e208e
MR
5138 (make_dummy_parent): Set new members of windows structure.
5139 (make_window): Move down in code. Handle new members of window
5140 structure.
5141 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5142 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5143 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5144 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5145 (Fset_window_next_buffers, Fset_window_clone_number):
5146 New functions.
496e208e
MR
5147 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5148 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5149 Doc-string fixes.
5150 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5151 Argument WINDOW can be now internal window too.
5152 (Fwindow_use_time): Move up in code.
5153 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5154 Rewrite doc-string.
5155 (Fset_window_configuration, saved_window)
5156 (Fcurrent_window_configuration, save_window_save): Handle new
5157 members of window structure.
b9e809c2
MR
5158 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5159 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5160 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5161 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5162 Qget_mru_window, Qresize_root_window,
5163 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5164 Qauto_buffer_name; staticpro them.
f3d1777e 5165
abde8f8c
MR
51662011-06-07 Martin Rudalics <rudalics@gmx.at>
5167
5168 * window.c (Fwindow_total_size, Fwindow_left_column)
5169 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5170 (Fwindow_list_1): New functions.
5171 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5172 (Fwindow_width, Fscroll_left, Fscroll_right):
5173 Use window_body_cols instead of window_box_text_cols.
5174 (delete_window, Fset_window_configuration):
5175 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5176 (delete_all_subwindows): Take a window as argument and not a
5177 structure. Rewrite.
190b47e6
MR
5178 (window_loop): Remove handling of GET_LRU_WINDOW and
5179 GET_LARGEST_WINDOW.
5180 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5181
5182 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5183 window_box_text_cols. delete_all_subwindows now takes a
5184 Lisp_Object as argument.
abde8f8c 5185
640c8776
SM
5186 * indent.c (compute_motion, Fcompute_motion):
5187 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5188
fa8a67e6
MR
5189 * frame.c (delete_frame): Call delete_all_subwindows with root
5190 window as argument.
5191
a54e3482
DC
51922011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5193
5194 * fns.c (Fputhash): Document return value.
5195
60002bf5
CY
51962011-06-06 Chong Yidong <cyd@stupidchicken.com>
5197
5198 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5199
0c671da6 52002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5201
b862a52a 5202 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5203
be44ca6c
PE
5204 Check for overflow when converting integer to cons and back.
5205 * charset.c (Fdefine_charset_internal, Fdecode_char):
5206 Use cons_to_unsigned to catch overflow.
5207 (Fencode_char): Use INTEGER_TO_CONS.
5208 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5209 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5210 * data.c (long_to_cons, cons_to_long): Remove.
5211 (cons_to_unsigned, cons_to_signed): New functions.
5212 These signal an error for invalid or out-of-range values.
5213 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5214 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5215 * font.c (Ffont_variation_glyphs):
5216 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5217 * lisp.h: Include <intprops.h>.
5218 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5219 (cons_to_signed, cons_to_unsigned): New decls.
5220 (long_to_cons, cons_to_long): Remove decls.
5221 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5222 (Fprimitive_undo): Use CONS_TO_INTEGER.
5223 * xfns.c (Fx_window_property): Likewise.
5224 * xselect.c: Include <limits.h>.
5225 (x_own_selection, selection_data_to_lisp_data):
5226 Use INTEGER_TO_CONS.
5227 (x_handle_selection_request, x_handle_selection_clear)
5228 (x_get_foreign_selection, Fx_disown_selection_internal)
5229 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5230 (lisp_data_to_selection_data): Use cons_to_unsigned.
5231 (x_fill_property_data): Use cons_to_signed.
5232 Report values out of range.
5233
d1f3d2af
PE
5234 Check for buffer and string overflow more precisely.
5235 * buffer.h (BUF_BYTES_MAX): New macro.
5236 * lisp.h (STRING_BYTES_MAX): New macro.
5237 * alloc.c (Fmake_string):
5238 * character.c (string_escape_byte8):
5239 * coding.c (coding_alloc_by_realloc):
5240 * doprnt.c (doprnt):
5241 * editfns.c (Fformat):
5242 * eval.c (verror):
5243 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5244 since they may not be the same number.
5245 * editfns.c (Finsert_char):
5246 * fileio.c (Finsert_file_contents):
5247 Likewise for BUF_BYTES_MAX.
5248
dd52fcea
PE
5249 * image.c: Use ptrdiff_t, not int, for sizes.
5250 (slurp_file): Switch from int to ptrdiff_t.
5251 All uses changed.
5252 (slurp_file): Check that file size fits in both size_t (for
5253 malloc) and ptrdiff_t (for sanity and safety).
5254
7f9bbdbb
PE
5255 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5256 if b->modtime has its maximal value.
5257
dfe18f82
PE
5258 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5259
84acfcf0
PE
5260 Don't assume time_t can fit into int.
5261 * buffer.h (struct buffer.modtime): Now time_t, not int.
5262 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5263 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5264
ccd9a01a
PE
5265 Minor fixes for signed vs unsigned integers.
5266 * character.h (MAYBE_UNIFY_CHAR):
5267 * charset.c (maybe_unify_char):
5268 * keyboard.c (read_char, reorder_modifiers):
5269 XINT -> XFASTINT, since the integer must be nonnegative.
5270 * ftfont.c (ftfont_spec_pattern):
5271 * keymap.c (access_keymap, silly_event_symbol_error):
5272 XUINT -> XFASTINT, since the integer must be nonnegative.
5273 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5274 since it makes no difference and we prefer signed.
5275 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5276 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5277 nonnegative.
5278
d6d100dd
SM
52792011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5280
5281 * window.h (Fwindow_frame): Declare.
5282
2b6148e4
PE
52832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5284
5285 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5286 (SPARE_MEMORY): Always define.
5287 (LARGE_REQUEST): Remove.
5288 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5289
f230ecc9
MR
52902011-06-06 Martin Rudalics <rudalics@gmx.at>
5291
727e958e
MR
5292 * lisp.h: Move EXFUNS for Fframe_root_window,
5293 Fframe_first_window and Fset_frame_selected_window to window.h.
5294
5295 * window.h: Move EXFUNS for Fframe_root_window,
5296 Fframe_first_window and Fset_frame_selected_window here from
5297 lisp.h.
5298
5299 * frame.c (Fwindow_frame, Fframe_first_window)
5300 (Fframe_root_window, Fframe_selected_window)
5301 (Fset_frame_selected_window): Move to window.c.
5302 (Factive_minibuffer_window): Move to minibuf.c.
5303 (Fother_visible_frames_p): New function.
5304
5305 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5306
f230ecc9
MR
5307 * window.c (decode_window, decode_any_window): Move up in code.
5308 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5309 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5310 (Fwindow_buffer): Move up and rewrite doc-string.
5311 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5312 (Fwindow_prev): New functions.
727e958e
MR
5313 (Fwindow_frame): Move here from frame.c. Accept any window as
5314 argument.
5315 (Fframe_root_window, Fframe_first_window)
5316 (Fframe_selected_window): Move here from frame.c. Accept frame
5317 or arbitrary window as argument. Update doc-strings.
5318 (Fminibuffer_window): Move up in code.
5319 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5320 (Fset_frame_selected_window): Move here from frame.c.
5321 Marginal rewrite.
727e958e
MR
5322 (Fselected_window, select_window, Fselect_window): Move up in
5323 code. Minor doc-string fixes.
f230ecc9 5324
4d09bcf6
PE
53252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5326
5327 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5328 Do not assume that spare memory exists; that assumption is valid
5329 only if SYSTEM_MALLOC.
5330 (LARGE_REQUEST): New macro, so that the issue of large requests
5331 is separated from the issue of spare memory.
5332
810928a2
AS
53332011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5334
172418ad
AS
5335 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5336 format. (Bug#8806)
5337
43f862f7
AS
5338 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5339
810928a2
AS
5340 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5341 before statements.
5342
a059fe24
JD
53432011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5344
5345 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5346
5347 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5348
5349 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5350 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5351
989bf368
JB
53522011-06-05 Juanma Barranquero <lekktu@gmail.com>
5353
5354 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5355
4b80f674
CY
53562011-06-04 Chong Yidong <cyd@stupidchicken.com>
5357
5358 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5359 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5360 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5361 New error handlers.
4b80f674
CY
5362 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5363 Obey Vx_select_enable_clipboard_manager. Catch errors in
5364 x_clipboard_manager_save (Bug#8779).
5365 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5366 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5367
99a33b77 53682011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5369
5370 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5371
99a33b77 53722011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5373
5374 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5375 in the current matrix if keep_current_p is non-zero.
5376
8264569d
EZ
53772011-06-04 Eli Zaretskii <eliz@gnu.org>
5378
5379 * bidi.c (bidi_level_of_next_char): Fix last change.
5380
57f97249
EZ
53812011-06-03 Eli Zaretskii <eliz@gnu.org>
5382
fec2107c 5383 Support bidi reordering of text covered by display properties.
57f97249 5384
fec2107c
EZ
5385 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5386 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5387 (bidi_cache_search, bidi_cache_iterator_state)
5388 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5389 (bidi_level_of_next_char, bidi_move_to_visually_next):
5390 Support character positions inside a run of characters covered by a
fec2107c
EZ
5391 display string.
5392 (bidi_paragraph_init, bidi_resolve_explicit_1)
5393 (bidi_level_of_next_char): Call bidi_fetch_char and
5394 bidi_fetch_char_advance instead of FETCH_CHAR and
5395 FETCH_CHAR_ADVANCE.
5396 (bidi_init_it): Initialize new members.
5397 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5398 definitions.
5399 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5400 instead of using explicit *_CHAR codes.
d6d100dd
SM
5401 (bidi_resolve_explicit, bidi_resolve_weak):
5402 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5403 bidirectional text is supported only in multibyte buffers.
5404 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5405 it to initialize the frame_window_p member of struct bidi_it.
5406 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5407 (bidi_resolve_explicit, bidi_resolve_weak)
5408 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5409 bidi_it->nchars is non-positive.
5410 (bidi_level_of_next_char): Don't try to lookup the cache for the
5411 next/previous character if nothing is cached there yet, or if we
5412 were just reseat()'ed to a new position.
c40e2fb2 5413
0e14fe90
EZ
5414 * xdisp.c (set_cursor_from_row): Set start and stop points
5415 according to the row's direction when priming the loop that looks
5416 for the glyph on which to display cursor.
5417 (single_display_spec_intangible_p): Function deleted.
5418 (display_prop_intangible_p): Reimplement to call
5419 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5420 Accept 3 additional arguments needed by handle_display_spec.
5421 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5422 values: lists, `(when COND...)' forms, etc.
5423 (single_display_spec_string_p): Support property values that are
5424 lists with the argument STRING its top-level element.
5425 (display_prop_string_p): Fix the condition for processing a
5426 property that is a list to be consistent with handle_display_spec.
fec2107c 5427 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5428 last portion of handle_display_prop.
5429 (compute_display_string_pos): Accept additional argument
5430 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5431 value of a `display' property is a "replacing spec".
5432 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5433 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5434 the display property, but just return a value indicating whether
5435 the display property will replace the characters it covers.
5436 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5437 frame_window_p members of struct bidi_it.
d6d100dd
SM
5438 (compute_display_string_pos, compute_display_string_end):
5439 New functions.
fec2107c
EZ
5440 (push_it): Accept second argument POSITION, where pop_it should
5441 jump to continue iteration.
5442 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5443
fec2107c
EZ
5444 * keyboard.c (adjust_point_for_property): Adjust the call to
5445 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5446
5447 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5448 (bidi_init_it): Update prototypes.
5449 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5450 (compute_display_string_pos, compute_display_string_end):
5451 Declare prototypes.
fec2107c
EZ
5452 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5453 EMACS_INT.
fc6f18ce 5454
40087514 54552011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5456
57f53182
PE
5457 Malloc failure behavior now depends on size of allocation.
5458 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5459 * lisp.h: Change signatures accordingly.
5460 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5461 All callers changed. (Bug#8762)
5462
5463 * gnutls.c: Use Emacs's memory allocators.
5464 Without this change, the gnutls library would invoke malloc etc.
5465 directly, which causes problems on non-SYNC_INPUT hosts, and which
5466 runs afoul of improving memory_full behavior. (Bug#8761)
5467 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5468 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5469 xfree instead of the default malloc, realloc, free.
5470 (Fgnutls_boot): No need to check for memory allocation failure,
5471 since xmalloc does that for us.
5472
ac32cd99 5473 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5474 * category.c (hash_get_category_set):
5475 * ccl.c (ccl_driver):
5476 * charset.c (Fdefine_charset_internal):
5477 * charset.h (struct charset.hash_index):
5478 * composite.c (get_composition_id, gstring_lookup_cache)
5479 (composition_gstring_put_cache):
5480 * composite.h (struct composition.hash_index):
5481 * dispextern.h (struct image.hash):
5482 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5483 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5484 (hashfn_equal, hashfn_user_defined, make_hash_table)
5485 (maybe_resize_hash_table, hash_lookup, hash_put)
5486 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5487 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5488 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5489 * image.c (make_image, search_image_cache, lookup_image)
5490 (xpm_put_color_table_h):
5491 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5492 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5493 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5494 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5495 * alloc.c (allocate_vectorlike):
5496 Check for overflow in vector size calculations.
5497 * ccl.c (ccl_driver):
5498 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5499 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5500 need to be updated by these changes.
40087514
PE
5501 * fns.c (make_hash_table, maybe_resize_hash_table):
5502 Check for integer overflow with large hash tables.
0de4bb68
PE
5503 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5504 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5505 (SXHASH_REDUCE): New macro.
5506 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5507 Use it instead of discarding useful hash info with large hash values.
5508 (sxhash_float): New function.
5509 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5510 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5511 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5512 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5513 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5514 Adjust signatures to match updated version of code.
5515 (consing_since_gc): Now EMACS_INT, since a single hash table can
5516 use more than INT_MAX bytes.
5517
698d32e2
DN
55182011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5519
5520 Make it possible to build with GCC-4.6+ -O2 -flto.
5521
5522 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5523
fd6fa53f
SM
55242011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5525
5526 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5527 Call minibuffer-inactive-mode.
5528
864db017
JB
55292011-05-31 Juanma Barranquero <lekktu@gmail.com>
5530
5531 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5532 Update dependencies.
5533
2ad0baf4
DN
55342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5535
5536 * data.c (init_data): Remove code for UTS, this system is not
5537 supported anymore.
5538
4fcc2638
DN
55392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5540
5541 Don't force ./temacs to start in terminal mode.
5542
5543 * frame.c (make_initial_frame): Initialize faces in all cases, not
5544 only when CANNOT_DUMP is defined.
5545 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5546
c56e0fd5
DN
55472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5548
5549 * dispnew.c (add_window_display_history): Use const for the string
5550 pointer. Remove declaration, not needed.
5551
333d54da 55522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5553
55d4c1b2 5554 Use 'inline', not 'INLINE'.
333d54da 5555 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5556 * alloc.c, fontset.c (INLINE): Remove.
5557 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5558 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5559 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5560 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5561 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5562
738db178
DN
55632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5564
5565 Make it possible to run ./temacs.
5566
5567 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5568 syms_of_callproc does the same thing. Remove test for
5569 "initialized", do it in the caller.
5570 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5571
620c53a6
SM
55722011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5573
5574 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5575 (read_minibuf): Use get_minibuffer.
5576 (syms_of_minibuf): Use DEFSYM.
5577 (Qmetadata): New var.
5578 * data.c (Qbuffer): Don't make it static.
5579 (syms_of_data): Use DEFSYM.
5580
e003a292
PE
55812011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5582
5583 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5584 (CCL_CODE_MIN): New macro.
5585
ed008a6d
PE
55862011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5587
3687c2ef
PE
5588 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5589
ed008a6d
PE
5590 * eval.c (Qdebug): Now static.
5591 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5592 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5593 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5594
d66c4c7c
CY
55952011-05-29 Chong Yidong <cyd@stupidchicken.com>
5596
5597 * image.c: Various fixes to ImageMagick code comments.
5598 (Fimagemagick_types): Doc fix.
5599
5fbc2025
PE
56002011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5601
0196f88a
PE
5602 Minor fixes prompted by GCC 4.6.0 warnings.
5603
5604 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5605
5fbc2025
PE
5606 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5607 (x_clipboard_manager_save_all): Move extern decl to ...
5608 * xterm.h: ... here, so that it can be checked for consistency.
5609
1dd3c2d9
CY
56102011-05-29 Chong Yidong <cyd@stupidchicken.com>
5611
5612 * xselect.c (x_clipboard_manager_save_frame)
5613 (x_clipboard_manager_save_all): New functions.
5614 (Fx_clipboard_manager_save): Lisp function deleted.
5615
5616 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5617 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5618
5619 * xterm.h: Update prototype.
5620
5ba6571d
WX
56212011-05-28 William Xu <william.xwl@gmail.com>
5622
5623 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5624 exiting (Bug#8239).
5625
3eaff834
JM
56262011-05-28 Jim Meyering <meyering@redhat.com>
5627
e1900994 5628 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5629 * fns.c (to_uchar): Define.
5630 (crypto_hash_function): Use it to convert some newly-signed
5631 variables to unsigned, to avoid sign-extension bugs. For example,
5632 without this change, (md5 "truc") would evaluate to
5633 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5634 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5635 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5636
0f6990a7
PE
56372011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5638
5639 Integer overflow fixes.
c8a9ca5a 5640
08686060
PE
5641 * dbusbind.c: Serial number integer overflow fixes.
5642 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5643 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5644 to hold a serial number that is too large for a fixnum.
5645 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5646 Check for serial numbers out of range. Decode any serial number
59568bf0 5647 that was so large that it became a float. (Bug#8722)
08686060 5648
2d1fc3c7
PE
5649 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5650 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5651 Use XFASTINT rather than XUINT when numbers are nonnegative.
5652 (xd_append_arg, Fdbus_method_return_internal):
5653 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5654 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5655 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5656 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5657 (Bug#8722)
2d1fc3c7 5658
c8a9ca5a
PE
5659 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5660
519e1d69
PE
5661 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5662
30569699
PE
5663 ccl: add integer overflow checks
5664 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5665 (IN_INT_RANGE): New macros.
5666 (ccl_driver): Use them to check for integer overflow when
5667 decoding a CCL program. Many of the new checks are whether XINT (x)
5668 fits in int; it doesn't always, on 64-bit hosts. The new version
5669 doesn't catch all possible integer overflows, but it's an
847044ea 5670 improvement. (Bug#8719)
30569699 5671
c11285dc
PE
5672 * alloc.c (make_event_array): Use XINT, not XUINT.
5673 There's no need for unsigned here.
5674
fdccd48e
PE
5675 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5676 This follows up to the 2011-05-06 change that substituted uintptr_t
5677 for EMACS_INT. This case wasn't caught back then.
5678
37910ab2
PE
5679 Rework Fformat to avoid integer overflow issues.
5680 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5681 now (part of C89). Include <verify.h>.
5682 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5683 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5684 (Fformat): Avoid the prepass trying to compute sizes; it was only
5685 approximate and thus did not catch overflow reliably. Instead, walk
5686 through the format just once, formatting and computing sizes as we go,
5687 checking for integer overflow at every step, and allocating a larger
5688 buffer as needed. Keep track separately whether the format is
5689 multibyte. Keep only the most-recently calculated precision, rather
5690 than them all. Record whether each argument has been converted to
5691 string. Use EMACS_INT, not int, for byte and char and arg counts.
5692 Support field widths and precisions larger than INT_MAX. Avoid
5693 sprintf's undefined behavior with conversion specifications such as %#d
5694 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5695 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5696 formatting out-of-range floating point numbers with int
9173deec 5697 formats. (Bug#8668)
37910ab2 5698
2e6578fb
PE
5699 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5700
0ae6bdee
PE
5701 * data.c: Avoid integer truncation in expressions involving floats.
5702 * data.c: Include <intprops.h>.
5703 (arith_driver): When there's an integer overflow in an expression
5704 involving floating point, convert the integers to floating point
5705 so that the resulting value does not suffer from catastrophic
5706 integer truncation. For example, on a 64-bit host (* 4
5707 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5708 Do not rely on undefined behavior after integer overflow.
5709
de883a70
PE
5710 merge count_size_as_multibyte, parse_str_to_multibyte
5711 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5712 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5713 Check for integer overflow.
5714 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5715 since it's now a duplicate of the other. This is more of
5716 a character than a buffer op, so better that it's in character.c.
5717 * fns.c, print.c: Adjust to above changes.
5718
2ff916cb
PE
57192011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5720
5721 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5722
f1b54466
PE
57232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5724
fb1ac845
PE
5725 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5726 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5727 (x_clipboard_manager_save): Now static.
5728 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5729
f1b54466
PE
5730 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5731 (crypto_hash_function): Now static.
5732 Fix pointer signedness problems. Avoid unnecessary initializations.
5733
a9f737ee
CY
57342011-05-27 Chong Yidong <cyd@stupidchicken.com>
5735
5736 * termhooks.h (Vselection_alist): Make it terminal-local.
5737
5738 * terminal.c (create_terminal): Initialize it.
5739
5740 * xselect.c: Support for clipboard managers.
5741 (Vselection_alist): Move to termhooks.h as terminal-local var.
5742 (LOCAL_SELECTION): New macro.
5743 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5744 (symbol_to_x_atom): Remove gratuitous arg.
5745 (x_handle_selection_request, lisp_data_to_selection_data)
5746 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5747 (x_own_selection, x_get_local_selection, x_convert_selection):
5748 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5749 (some_frame_on_display): Delete unused function.
5750 (Fx_own_selection_internal, Fx_get_selection_internal)
5751 (Fx_disown_selection_internal, Fx_selection_owner_p)
5752 (Fx_selection_exists_p): New optional frame arg.
5753 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5754 (x_handle_selection_clear): Don't treat other terminals with the
5755 same keyboard specially. Use the terminal-local Vselection_alist.
5756 (x_clear_frame_selections): Use Frun_hook_with_args.
5757
5758 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5759
5760 * xterm.h: Add support for those atoms.
5761
e067f0c1
CY
57622011-05-26 Chong Yidong <cyd@stupidchicken.com>
5763
5764 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5765 (converted_selections, conversion_fail_tag): New global variables.
5766 (x_selection_request_lisp_error): Free the above.
5767 (x_get_local_selection): Remove unnecessary code.
5768 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5769 of converted selections stored in converted_selections.
5770 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5771 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5772 (x_convert_selection): New function.
5773 (x_handle_selection_event): Simplify.
5774 (x_get_foreign_selection): Don't ignore incoming requests while
5775 waiting for an answer; this will fail when we implement
5776 SAVE_TARGETS, and seems unnecessary anyway.
5777 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5778 (Vx_sent_selection_functions): Doc fix.
5779
0f4aebc0
LL
57802011-05-26 Leo Liu <sdl.web@gmail.com>
5781
5782 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5783
e61124cd
YM
57842011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5785
5786 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5787
5788 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5789 for fringe update if it has periodic bitmap.
ac389d0c 5790 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5791 and fringe_bitmap_periodic_p.
5792
5793 * fringe.c (get_fringe_bitmap_data): New function.
5794 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5795 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5796 row. Mark glyph row for fringe update if periodicity changed.
5797
5798 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5799 for fringe update unless it has periodic bitmap.
5800
f16d9837
KH
58012011-05-25 Kenichi Handa <handa@m17n.org>
5802
5803 * xdisp.c (get_next_display_element): Set correct it->face_id for
5804 a static composition.
5805
e1b90ef6
LL
58062011-05-24 Leo Liu <sdl.web@gmail.com>
5807
5808 * deps.mk (fns.o):
5809 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5810
5811 * fns.c (crypto_hash_function, Fsha1): New function.
5812 (Fmd5): Use crypto_hash_function.
5813 (syms_of_fns): Add Ssha1.
5814
7400048f
PE
58152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 * gnutls.c: Remove unused macros.
5818 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5819 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5820 Remove macros that are defined and never used.
5821 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5822
abb71cf4
CY
58232011-05-22 Chong Yidong <cyd@stupidchicken.com>
5824
5825 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5826 (Fx_get_selection_internal): Minor cleanup.
5827 (Fx_own_selection_internal): Rename arguments for consistency with
5828 select.el.
5829
6307db39
PE
58302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5831
5832 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5833
f3d4e0a4
CY
58342011-05-22 Chong Yidong <cyd@stupidchicken.com>
5835
5836 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5837
4d8ade89
YM
58382011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5839
5840 * dispnew.c (scrolling_window): Don't exclude the case that the
5841 last enabled row in the desired matrix touches the bottom boundary.
5842
32078c8d
GM
58432011-05-21 Glenn Morris <rgm@gnu.org>
5844
5845 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5846 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5847 and add some more files.
32078c8d 5848
7285dc67
EZ
58492011-05-20 Eli Zaretskii <eliz@gnu.org>
5850
5851 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5852 report_file_error introduced by the change from 2011-05-07.
5853
89d1bd22
PE
58542011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 * systime.h (Time): Define only if emacs is defined.
5857 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5858 where the include path doesn't have X11/X.h by default. See
5859 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5860
cd394be1 58612011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5862
5863 * composite.c (find_automatic_composition): Fix previous change.
5864
b9704ad9
GM
58652011-05-20 Glenn Morris <rgm@gnu.org>
5866
5867 * lisp.mk: New file, split from Makefile.in.
5868 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5869 (shortlisp): Remove.
5870 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5871
4a720484
GM
58722011-05-19 Glenn Morris <rgm@gnu.org>
5873
5874 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5875 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5876 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5877 (lisp): Set the order to that of loadup.el.
5878 (shortlisp): Make it a copy of $lisp.
5879 (SOME_MACHINE_LISP): Remove.
5880 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5881 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5882
a28d4396
KH
58832011-05-18 Kenichi Handa <handa@m17n.org>
5884
5885 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5886 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5887 (find_automatic_composition): Mostly rewrite for efficiency.
5888
a2b1fa8e
JB
58892011-05-18 Juanma Barranquero <lekktu@gmail.com>
5890
5891 * makefile.w32-in: Update dependencies.
5892
8e1f5610
CS
58932011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5894
5895 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5896 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5897
7025ee00 58982011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5899
cdfa6eab
PE
5900 Fix some integer overflow issues, such as string length overflow.
5901
06d6db33
PE
5902 * insdel.c (count_size_as_multibyte): Check for string overflow.
5903
2b4560a8
PE
5904 * character.c (lisp_string_width): Check for string overflow.
5905 Use EMACS_INT, not int, for string indexes and lengths; in
5906 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5907 the resulting string length overflows an EMACS_INT; instead,
5908 report a string overflow if no precision given. When checking for
5909 precision exhaustion, use a check that cannot possibly have
5910 integer overflow. (Bug#8675)
5911 * character.h (lisp_string_width): Adjust to new signature.
5912
cb93f9be
PE
5913 * alloc.c (string_overflow): New function.
5914 (Fmake_string): Use it. This doesn't change behavior, but saves
5915 a few bytes and will simplify future changes.
5916 * character.c (string_escape_byte8): Likewise.
5917 * lisp.h (string_overflow): New decl.
5918
1a1f3366
PE
5919 Fixups, following up to the user-interface timestamp change.
5920 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5921 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5922 * msdos.c (mouse_get_pos): Likewise.
5923 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5924 * w32gui.h (Time): Define by including "systime.h" rather than by
5925 declaring it ourselves. (Bug#8664)
5926
d4e3e4d3
PE
5927 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5928 * image.c (clear_image_cache): Likewise.
5929
f6a24d19
PE
5930 * term.c (term_mouse_position): Don't assume time_t wraparound.
5931
08dc5ae6
PE
5932 Be more systematic about user-interface timestamps.
5933 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5934 and sometimes 'EMACS_UINT', to represent these timestamps.
5935 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5936 This makes the code easier to follow, and makes it easier to catch
5937 integer overflow bugs such as Bug#8664.
5938 * frame.c (Fmouse_position, Fmouse_pixel_position):
5939 Use Time, not unsigned long, for user-interface timestamps.
5940 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5941 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5942 * keyboard.h (last_event_timestamp): Likewise.
5943 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5944 * menu.h (xmenu_show): Likewise.
5945 * term.c (term_mouse_position): Likewise.
5946 * termhooks.h (struct input_event.timestamp): Likewise.
5947 (struct terminal.mouse_position_hook): Likewise.
5948 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5949 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5950 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5951 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5952 what it was before.
5953 * menu.h, termhooks.h: Include "systime.h", for Time.
5954
8e55734a
PE
5955 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5956 Don't assume that the difference between two unsigned long values
5957 can fit into an integer. At this point, we know button_down_time
5958 <= event->timestamp, so the difference must be nonnegative, so
5959 there's no need to cast the result if double-click-time is
5960 nonnegative, as it should be; check that it's nonnegative, just in
5961 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5962 apart (about 25 days). (Bug#8664)
8e55734a 5963
841f1b75 5964 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5965 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5966
3e26f69c
PE
5967 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5968 that always fit in int. Use a sentinel instead of a counter, to
5969 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5970 * frame.h (struct frame): Use int for menu_bar_items_used
5971 instead of EMACS_INT, since it always fits in int.
3e26f69c 5972
5cc152c0
PE
5973 * menu.c (grow_menu_items): Check for int overflow.
5974
d89eb65e
PE
5975 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5976
5235bd3e
PE
5977 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5978 Before, the code was not consistent. These values cannot exceed
5979 2**31 - 1 so there's no need to make them unsigned.
5980 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5981 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5982 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5983 as modifiers.
5984 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5985
bc827e23
PE
5986 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5987 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5988 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5989 presumably because the widths might not match.
5990
78eb494e
PE
5991 * window.c (size_window): Avoid needless test at loop start.
5992
04f2d78b
CB
59932011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5994
5995 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5996
d2fc7e3d 59972011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5998
5999 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6000
d2fc7e3d 60012011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6002
6003 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6004 `width' to `bar_area_x' and `bar_area_width', respectively.
6005 (x_scroll_run): Take account of fringe background extension.
6006
04f2d78b
CB
6007 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6008 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6009 `bar_area_width', respectively.
6010 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6011 background extension.
6012
79b70037
GM
60132011-05-10 Jim Meyering <meyering@redhat.com>
6014
6015 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6016
2f142cc5
JB
60172011-05-10 Juanma Barranquero <lekktu@gmail.com>
6018
6019 * image.c (Finit_image_library): Return t for built-in image types,
6020 like pbm and xbm. (Bug#8640)
6021
57679c86
AS
60222011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6023
6024 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6025
888c9e86
EZ
60262011-05-07 Eli Zaretskii <eliz@gnu.org>
6027
b0512a1d
EZ
6028 * w32console.c (Fset_screen_color): Doc fix.
6029 (Fget_screen_color): New function.
6030 (syms_of_ntterm): Defsubr it.
6031
7285dc67
EZ
6032 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6033 unlink the temporary file if Fcall_process didn't create it in the
6034 first place.
6035 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6036 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6037 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6038 cue to call_process_cleanup not to close that handle.
6039
4d3fcc8e
BK
60402011-05-07 Ben Key <bkey76@gmail.com>
6041
6042 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6043 one of two shell specific rules, either bootstrap-temacs-CMD or
6044 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6045 to the previous implementation of the bootstrap-temacs rule.
6046 The bootstrap-temacs-CMD rule is similar to the previous
6047 implementation of the bootstrap-temacs rule except that it
6048 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6049 variable.
6050
6051 These changes, along with some changes to nt/configure.bat,
6052 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6053 earlier fix to add support for --cflags and --ldflags options
6054 that include quotes so that it works whether make uses cmd or
6055 sh as the shell.
6056
b4289b64
MA
60572011-05-06 Michael Albinus <michael.albinus@gmx.de>
6058
6059 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6060 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6061 is a constant.
6062 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6063 a string. Handle both cases.
6064 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6065 (Fdbus_register_method): Use Qinvalid_function.
6066
af4c0e28
JB
60672011-05-06 Juanma Barranquero <lekktu@gmail.com>
6068
6069 * makefile.w32-in: Update dependencies.
6070 (LISP_H): Add inttypes.h and stdin.h.
6071 (PROCESS_H): Add unistd.h.
6072
c51453d9
EZ
60732011-05-06 Eli Zaretskii <eliz@gnu.org>
6074
6075 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6076 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6077
8ff0ac3c 60782011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6079
4c4b566b
PE
6080 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6081
aab2b9b5
PE
6082 * term.c (vfatal): Remove stray call to va_end.
6083 It's not needed and the C Standard doesn't allow it here anyway.
6084
c378da0b
PE
6085 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6086 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6087
288b08c7
PE
6088 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6089 bytes.
6090
e3601888
PE
6091 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6092
db6c0e74
PE
6093 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6094
dd5963ea
PE
6095 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6096
88c9450f
PE
6097 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6098
2f9442b8
PE
6099 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6100
c032b5f8
PE
6101 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6102 * charset.c (Fdefine_charset_internal): Don't initialize
6103 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6104 32-bit int (Bug#8600).
a108c10b
PE
6105
6106 * lread.c (read_integer): Be more consistent with string-to-number.
6107 Use string_to_number to do the actual conversion; this avoids
6108 rounding errors and fixes some other screwups. Without this fix,
6109 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6110 (digit_to_number): Move earlier, for benefit of read_integer.
6111 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6112 not a digit in any supported base. (Bug#8602)
a108c10b 6113
ad5f9eea
PE
6114 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6115
aec1708a
PE
6116 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6117 to match comment at start of function. This also removes a
6118 GCC warning about overflow in a 32+64-bit port.
6119
47be4ab5
PE
6120 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6121
371cac43
PE
6122 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6123 Reported by Stefan Monnier in
6124 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6125 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6126 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6127
d01a7826
PE
6128 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6129 (EMACS_UINTPTR): Likewise, with uintptr_t.
6130
7fd47d5c
PE
6131 * lisp.h: Prefer 64-bit EMACS_INT if available.
6132 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6133 on 32-bit hosts that have 64-bit int, so that they can access
6134 large files.
122b0c86
PE
6135 However, temporarily disable this change unless the temporary
6136 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6137
8727937b
PE
6138 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6139
8ac068ac
PE
6140 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6141 This removes an assumption that EMACS_INT and long are the same
6142 width as pointers. The assumption is true for Emacs porting targets
6143 now, but we want to make other targets possible.
6144 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6145 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6146 In the rest of the code, change types of integers that hold casted
6147 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6148 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6149 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6150 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6151 No need to cast type when ORing.
6152 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6153 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6154 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6155 assume EMACS_INT is the same width as char *.
6156 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6157 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6158 Remove no-longer-needed casts.
6159 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6160 (xg_tool_bar_help_callback, xg_make_tool_item):
6161 Use EMACS_INTPTR to hold an integer
6162 that will be cast to void *; this can avoid a GCC warning
6163 if EMACS_INT is not the same width as void *.
6164 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6165 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6166 (current_message_1, set_message_1):
6167 Use a local to convert to proper width without a cast.
6168 * xmenu.c (dialog_selection_callback): Likewise.
6169
ede49d71
PE
6170 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6171 Also, don't assume VALBITS / RAND_BITS is less than 5,
6172 and don't rely on undefined behavior when shifting a 1 left into
6173 the sign bit.
6174 * lisp.h (get_random): Change signature to match.
6175
2f30ecd0
PE
6176 * lread.c (hash_string): Use size_t, not int, for hash computation.
6177 Normally we prefer signed values; but hashing is special, because
6178 it's better to use unsigned division on hash table sizes so that
6179 the remainder is nonnegative. Also, size_t is the natural width
6180 for hashing into memory. The previous code used 'int', which doesn't
6181 retain enough info to hash well into very large tables.
6182 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6183
2a866e7b
PE
6184 * dbusbind.c: Don't possibly lose pointer info when converting.
6185 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6186 Use XPNTR rather than XHASH, so that the high-order bits of
6187 the pointer aren't lost when converting through void *.
6188
51639eac
PE
6189 * eval.c (Fautoload): Don't double-shift a pointer.
6190
92394119
PE
6191 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6192
dbdb9a7c
JB
61932011-05-06 Juanma Barranquero <lekktu@gmail.com>
6194
6195 * gnutls.c (DEF_GNUTLS_FN):
6196 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6197
db7a0b4f
AS
61982011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6199
6200 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6201 marker. (Bug#8610)
6202
cd394be1 62032011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6204
6205 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6206 New version that can reserve upto 2GB of heap space.
6207
f7ff1b0f 62082011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6209
6210 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6211
639c109b
TZ
62122011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6213
6214 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6215 `gnutls_certificate_set_x509_key_file'.
6216
d2127135
JB
62172011-05-05 Juanma Barranquero <lekktu@gmail.com>
6218
6219 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6220 Update dependencies.
6221
e968f4f3
JB
62222011-05-04 Juanma Barranquero <lekktu@gmail.com>
6223
6224 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6225 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6226 Remove unused parameter `fildes'.
6227 * process.c (read_process_output, send_process): Don't pass it.
6228
84d358f0
JB
62292011-05-04 Juanma Barranquero <lekktu@gmail.com>
6230
6231 Fix previous change: the library cache is defined in w32.c.
6232 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6233 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6234
0898ca10
JB
62352011-05-04 Juanma Barranquero <lekktu@gmail.com>
6236
6237 Implement dynamic loading of GnuTLS on Windows.
6238
6239 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6240 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6241 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6242 Declare.
6243
6244 * gnutls.c (Qgnutls_dll): Define.
6245 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6246 (gnutls_*): Declare function pointers.
6247 (init_gnutls_functions): New function to initialize function pointers.
6248 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6249 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6250 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6251 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6252 (emacs_gnutls_write, emacs_gnutls_read)
6253 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6254 (Fgnutls_available_p): New function.
6255 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6256 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6257 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6258
6259 * image.c: Include w32.h.
6260 (Vimage_type_cache): Delete.
6261 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6262 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6263 (w32_delayed_load): Move to w32.c.
6264
6265 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6266
6267 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6268 (w32_delayed_load): Move from image.c. When loading a library, record
6269 its filename in the :loaded-from property of the library id.
6270 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6271 Initialize and staticpro them.
6272 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6273
6274 * process.c: Include lisp.h before w32.h, not after.
6275 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6276 instead of gnutls_record_check_pending.
6277
6278 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6279
ff4de4aa
TZ
62802011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6281
6282 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6283 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6284 as passed in.
6285
abe95abb
JD
62862011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6287
6288 * xterm.c (x_set_frame_alpha): Do not set property on anything
6289 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6290
e16e55d4
JB
62912011-05-02 Juanma Barranquero <lekktu@gmail.com>
6292
6293 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6294
bafcf6a5
JB
62952011-05-02 Juanma Barranquero <lekktu@gmail.com>
6296
6297 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6298 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6299 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6300 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6301 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6302 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6303 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6304 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6305 (Qgnutls_bootprop_callbacks_verify): Make static.
6306
e7a6747f
AS
63072011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6308
19ed11ba
AS
6309 * callproc.c: Indentation fixup.
6310
e7a6747f 6311 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6312 (wait_for_termination, interruptible_wait_for_termination):
6313 Move after wait_for_termination_1.
e7a6747f 6314
1ef14cb4
LMI
63152011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6316
6317 * sysdep.c (interruptible_wait_for_termination): New function
6318 which is like wait_for_termination, but allows keyboard
6319 interruptions.
6320
6321 * callproc.c (Fcall_process): Add (:file "file") as an option for
6322 the STDOUT buffer.
6323 (Fcall_process_region): Ditto.
6324
330d880c
EZ
63252011-04-30 Eli Zaretskii <eliz@gnu.org>
6326
8db90b73
EZ
6327 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6328 rather than `XVECTOR (FOO)->size'.
6329
330d880c
EZ
6330 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6331 inttypes.h, as a gnulib replacement is used if it not available in
6332 system headers.
6333
15cbd324
EZ
63342011-04-21 Eli Zaretskii <eliz@gnu.org>
6335
6336 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6337 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6338 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6339
6340 * coding.c (coding_alloc_by_realloc): Error out if destination
6341 will grow beyond MOST_POSITIVE_FIXNUM.
6342 (decode_coding_emacs_mule): Abort if there isn't enough place in
6343 charbuf for the composition carryover bytes. Reserve an extra
6344 space for up to 2 characters produced in a loop.
6345 (decode_coding_iso_2022): Abort if there isn't enough place in
6346 charbuf for the composition carryover bytes.
6347
63482011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6349
ae940cca
EZ
6350 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6351 aborting when %lld or %lll format is passed.
6352 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6353 %llo or %llx format is passed. (Bug#8545)
6354
03ab8921
EZ
6355 * window.c (window_scroll_line_based): Use a marker instead of
6356 simple variables to record original value of point. (Bug#7952)
6357
afda1437
EZ
6358 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6359 produced by %s or %c overflows available buffer space. (Bug#8545)
6360
f76dee0c
PE
63612011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6362
6363 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6364 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6365
fdc5744d
JB
63662011-04-28 Juanma Barranquero <lekktu@gmail.com>
6367
6368 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6369
638f053a
JB
63702011-04-28 Juanma Barranquero <lekktu@gmail.com>
6371
6372 * keyboard.c (Qdelayed_warnings_hook): Define.
6373 (command_loop_1): Run `delayed-warnings-hook'
6374 if Vdelayed_warnings_list is non-nil.
6375 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6376 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6377
d178f871
EZ
63782011-04-28 Eli Zaretskii <eliz@gnu.org>
6379
6380 * doprnt.c (doprnt): Don't return value smaller than the buffer
6381 size if the message was truncated. (Bug#8545).
6382
b124fd93
JB
63832011-04-28 Juanma Barranquero <lekktu@gmail.com>
6384
6385 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6386 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6387
e810457d
PE
63882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6389
6390 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6391
ea51cceb
JB
63922011-04-27 Juanma Barranquero <lekktu@gmail.com>
6393
6394 * makefile.w32-in: Update dependencies.
6395
94dcfacf
EZ
63962011-04-27 Eli Zaretskii <eliz@gnu.org>
6397
6398 Improve `doprnt' and its usage. (Bug#8545)
6399 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6400 `format_end'. Remove support for %l as a conversion specifier.
6401 Don't use xrealloc. Improve diagnostics when the %l size modifier
6402 is used. Update the commentary.
6403
6404 * eval.c (verror): Simplify calculation of size_t.
6405
6406 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6407 messages.
6408
f61f41d7
PE
64092011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6410
6411 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6412 change.
6413
96fb4434
PE
64142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6415
6416 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6417 This makes this file independent of the recent pseudovector change.
6418
671875da 64192011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6420
69e9b5a3
PE
6421 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6422
b5f869a7 6423 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6424 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6425 Remove unused local.
c8926152 6426 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6427
841a1577 6428 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6429 GCC 4.6.0 optimizes based on type-based alias analysis.
6430 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6431 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6432 != &v->size, and therefore "v->size = 1; b->size = 2; return
6433 v->size;" must therefore return 1. This assumption is incorrect
6434 for Emacs, since it type-puns struct Lisp_Vector * with many other
6435 types. To fix this problem, this patch adds a new type struct
f904488f 6436 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6437 and pseudovectors, and helps optimizing compilers not get fooled
6438 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6439 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6440 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6441 the size member.
eab3844f
PE
6442 (XSETPVECTYPE): Rewrite in terms of new macro.
6443 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6444 This is a bit clearer, and further avoids the possibility of
6445 undesirable aliasing.
6446 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6447 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6448 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6449 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6450 (ASIZE): Now uses header.size rather than size.
6451 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6452 to avoid the hassle of writing XVECTOR (foo)->header.size.
6453 (struct vectorlike_header): New type.
eab3844f
PE
6454 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6455 object, to help avoid aliasing.
6456 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6457 (SUBRP): Likewise, since Lisp_Subr is a special case.
6458 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6459 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6460 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6461 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6462 changed to be "header.size" and "header.next".
6463 * buffer.h (struct buffer): Likewise.
6464 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6465 * frame.h (struct frame): Likewise.
6466 * process.h (struct Lisp_Process): Likewise.
6467 * termhooks.h (struct terminal): Likewise.
6468 * window.c (struct save_window_data, struct saved_window): Likewise.
6469 * window.h (struct window): Likewise.
6470 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6471 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6472 * buffer.c (init_buffer_once): Likewise.
6473 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6474 special case.
6475 * process.c (Fformat_network_address): Use local var for size,
6476 for brevity.
6477
0df1eac5
PE
6478 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6479
847ab9d1 6480 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6481 * data.c (atof): Remove decl; no longer used or needed.
6482 (digit_to_number): Move to lread.c.
6483 (Fstring_to_number): Use new string_to_number function, to be
6484 consistent with how the Lisp reader treats infinities and NaNs.
6485 Do not assume that floating-point numbers represent EMACS_INT
6486 without losing information; this is not true on most 64-bit hosts.
6487 Avoid double-rounding errors, by insisting on integers when
6488 parsing non-base-10 numbers, as the documentation specifies.
6489 * lisp.h (string_to_number): New decl, replacing ...
6490 (isfloat_string): Remove.
bc0a5c13 6491 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6492 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6493 appears to have been a coding error. Similarly, do not accept
6494 strings like +-1e0 as floating point numbers. Do not report
6495 overflow for integer overflows unless the base is not 10 which
6496 means we have no simple and reliable way to continue.
6497 Break out the floating-point parsing into a new
6498 function string_to_number, so that Fstring_to_number parses
6499 floating point numbers consistently with the Lisp reader.
04f2d78b 6500 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6501 (E_CHAR, EXP_INT): Remove, replacing with ...
6502 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6503 (string_to_number): New function, replacing isfloat_string.
6504 This function checks for valid syntax and produces the resulting
6505 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6506 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6507 so that overflow for non-base-10 numbers is reported only when
6508 there's no portable and simple way to convert to floating point.
452f4150 6509
67769ffc
PE
6510 * textprop.c (set_text_properties_1): Rewrite for clarity,
6511 and to avoid GCC warning about integer overflow.
6512
c20db43f
PE
6513 * intervals.h (struct interval): Use EMACS_INT for members
6514 where EMACS_UINT might cause problems. See
6515 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6516 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6517 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6518 All uses changed.
37aa2f85
PE
6519 (offset_intervals): Tell GCC not to worry about length overflow
6520 when negating a negative length.
c20db43f 6521
2538aa2f
PE
6522 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6523 (overrun_check_free): Likewise.
6524
f2d3008d
PE
6525 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6526 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6527 word size.
6528
ec8df744
PE
6529 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6530 (gnutls_make_error): Rename local to avoid shadowing.
6531 (gnutls_emacs_global_deinit): ifdef out; not used.
6532 (Fgnutls_boot): Use const for pointer to readonly storage.
6533 Comment out unused local. Fix pointer signedness problems.
6534
640ee02d
PE
6535 * lread.c (openp): Don't stuff size_t into an 'int'.
6536 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6537 about possible signed overflow.
6538
6048fb2a
PE
6539 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6540 (GDK_KEY_g): Don't define if already defined.
6541 (xg_prepare_tooltip): Avoid pointer signedness problem.
6542 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6543
fa3c87e1
PE
6544 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6545 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6546
2172544b
PE
6547 * xfns.c (Fx_window_property): Simplify a bit,
6548 to make a bit faster and to avoid GCC 4.6.0 warning.
6549 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6550
9b821a21
PE
6551 * fns.c (internal_equal): Don't assume size_t fits in int.
6552
3c616cfa
PE
6553 * alloc.c (compact_small_strings): Tighten assertion a little.
6554
c2982e87
PE
6555 Replace pEd with more-general pI, and fix some printf arg casts.
6556 * lisp.h (pI): New macro, generalizing old pEd macro to other
6557 conversion specifiers. For example, use "...%"pI"d..." rather
6558 than "...%"pEd"...".
6559 (pEd): Remove. All uses replaced with similar uses of pI.
6560 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6561 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6562 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6563 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6564 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6565 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6566 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6567 64-bit hosts.
6568 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6569 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6570 * print.c (safe_debug_print, print_object): Likewise.
6571 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6572 to int.
6f04d126
PE
6573 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6574 avoiding the 0 flag, which is not portable.
c2982e87
PE
6575 * process.c (Fmake_network_process): Use pI to avoid cast.
6576 * region-cache.c (pp_cache): Likewise.
6577 * xdisp.c (decode_mode_spec): Likewise.
6578 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6579 behavior on 64-bit hosts with printf arg.
6f04d126 6580 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6581 (x_stop_queuing_selection_requests): Likewise.
6582 (x_get_window_property): Don't truncate byte count to an 'int'
6583 when tracing.
0b432f21 6584
5e073ec7
PE
6585 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6586 here, since it parses constructs like leading '-' and spaces,
6587 which are not wanted; and it overflows with large numbers.
6588 Instead, simply match F[0-9]+, which is what is wanted anyway.
6589
36372bf9
PE
6590 * alloc.c: Remove unportable assumptions about struct layout.
6591 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6592 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6593 (allocate_vectorlike, make_pure_vector): Use the new macros,
6594 plus offsetof, to remove unportable assumptions about struct layout.
6595 These assumptions hold on all porting targets that I know of, but
6596 they are not guaranteed, they're easy to remove, and removing them
6597 makes further changes easier.
6598
0b432f21
PE
6599 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6600 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6601 (string_overrun_cookie): Now const. Use initializers that
6602 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6603 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6604 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6605 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6606 multiple of sizeof (EMACS_INT); it need not be, if
6607 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6608 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6609
895009e1
JB
66102011-04-26 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6613
6a7a1b0b
TZ
66142011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6615
6616 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6617 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6618 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6619
841a1577 66202011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6621
6622 * lisp.h (Qdebug): List symbol.
895009e1 6623 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6624 * keyboard.c (debug-on-event): New variable.
6625 (handle_user_signal): Break into debugger when debug-on-event
6626 matches the current signal symbol.
6627
f2d3ba6f
DN
66282011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6629
6630 * alloc.c (check_sblock, check_string_bytes)
6631 (check_string_free_list): Convert to standard C.
6632
42ce4c63
TZ
66332011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6634
6635 * w32.c (emacs_gnutls_push): Fix typo.
6636
825cd63c
EZ
66372011-04-25 Eli Zaretskii <eliz@gnu.org>
6638
fb11d64d
EZ
6639 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6640 "cast to pointer from integer of different size".
6641
825cd63c
EZ
6642 Improve doprnt and its use in verror. (Bug#8545)
6643 * doprnt.c (doprnt): Document the set of format control sequences
6644 supported by the function. Use SAFE_ALLOCA instead of always
6645 using `alloca'.
6646
6647 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6648 is one byte too soon. Don't use xrealloc; instead xfree and
6649 xmalloc anew.
6650
e061a11b
TZ
66512011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6652
6653 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6654 callbacks stage.
6655
6656 * gnutls.c: Renamed global_initialized to
6657 gnutls_global_initialized. Added internals for the
6658 :verify-hostname-error, :verify-error, and :verify-flags
6659 parameters of `gnutls-boot' and documented those parameters in the
6660 docstring. Start callback support.
9173deec
JB
6661 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6662 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6663 on error. Return error code.
e061a11b
TZ
6664 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6665 (emacs_gnutls_read): Likewise.
6666 (Fgnutls_boot): Return handshake error code.
6667 (emacs_gnutls_handle_error): New function.
6668 (wsaerror_to_errno): Likewise.
6669
6670 * w32.h (emacs_gnutls_pull): Add prototype.
6671 (emacs_gnutls_push): Likewise.
6672
6673 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6674 (emacs_gnutls_push): Likewise.
6675
66762011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6677
6678 * process.c (wait_reading_process_output): Check if GnuTLS
6679 buffered some data internally if no FDs are set for TLS
6680 connections.
6681
6682 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6683 (LIBS): Link to USER_LIBS.
6684 ($(BLD)/gnutls.$(0)): New target.
6685
fa6996bc
EZ
66862011-04-24 Eli Zaretskii <eliz@gnu.org>
6687
eb35682e
EZ
6688 * xdisp.c (handle_single_display_spec): Rename the
6689 display_replaced_before_p argument into display_replaced_p, to
6690 make it consistent with the commentary. Fix typos in the
6691 commentary.
6692
e2ad650c
EZ
6693 * textprop.c (syms_of_textprop): Remove dead code.
6694 (copy_text_properties): Delete obsolete commentary about an
6695 interface that was deleted long ago. Fix typos in the description
6696 of arguments.
6697
1b2de274
EZ
6698 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6699 to changes in oldXMenu/XMenu.h from 2011-04-16.
6700 <menu_help_message, prev_menu_help_message>: Constify.
6701 (IT_menu_make_room): menu->help_text is now `const char **';
6702 adjust.
6703
6704 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6705 to changes in oldXMenu/XMenu.h from 2011-04-16.
6706 (struct XMenu): Declare `help_text' `const char **'.
6707
6708 * xfaces.c <Qunspecified>: Make extern again.
6709
6710 * syntax.c: Include sys/types.h before including regex.h, as
6711 required by Posix.
6712
762b15be
EZ
6713 * doc.c (get_doc_string): Improve the format passed to `error'.
6714
6715 * doprnt.c (doprnt): Improve commentary.
6716
6717 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6718
6719 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6720 them with etags.
6721
f1052e5d
EZ
6722 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6723 changes in globals.h immediately force recompilation.
762b15be
EZ
6724 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6725 $(CURDIR)/s/ms-w32.h.
6726 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6727
fa6996bc
EZ
6728 * character.c (Fchar_direction): Function deleted.
6729 (syms_of_character): Don't defsubr it.
6730 <char-direction-table>: Deleted.
6731
e6c3da20
EZ
67322011-04-23 Eli Zaretskii <eliz@gnu.org>
6733
6734 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6735 * doprnt.c: Include limits.h.
6736 (SIZE_MAX): New macro.
04f2d78b
CB
6737 (doprnt): Return a size_t value. 2nd arg is now size_t.
6738 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6739 Improve overflow protection. Support `l' modifier for integer
6740 conversions. Support %l conversion. Don't assume an EMACS_INT
6741 argument for integer conversions and for %c.
6742
6743 * lisp.h (doprnt): Restore prototype.
6744
6745 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6746 $(SRC)/character.h.
6747
6748 * Makefile.in (base_obj): Add back doprnt.o.
6749
6750 * deps.mk (doprnt.o): Add back prerequisites.
6751 (callint.o): Depend on character.h.
6752
6753 * eval.c (internal_lisp_condition_case): Include the handler
6754 representation in the error message.
6755 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6756 when breaking from the loop.
6757
6758 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6759
6760 * callint.c (Fcall_interactively): When displaying error message
6761 about invalid control letter, pass the character's codepoint, not
6762 a pointer to its multibyte form. Improve display of the character
6763 in octal and display also its hex code.
6764
6765 * character.c (char_string): Use %x to display the (unsigned)
6766 codepoint of an invalid character, to avoid displaying a bogus
6767 negative value.
6768
6769 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6770 `error', not SYMBOL_NAME itself.
6771
6772 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6773 character arguments to `error'.
6774
6775 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6776 to `error' in error message about FINAL_CHAR argument. Make sure
6777 FINAL_CHAR is a character, and use %c when it is passed as
6778 argument to `error'.
6779
4ffd0d6b 67802011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6781
6782 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6783
6784 * w32.c: Include <time.h>.
6785 (sys_localtime): New function.
6786
4ffd0d6b 67872011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6788
6789 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6790
4ffd0d6b 6791 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6792
4ffd0d6b 67932011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6794
4ffd0d6b
GM
6795 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6796 zombies (Bug#8467).
aac0c6e3 6797
04c56954
EZ
67982011-04-19 Eli Zaretskii <eliz@gnu.org>
6799
6800 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6801 gl_state.e_property when gl_state.object is Qt.
6802
6803 * insdel.c (make_gap_larger): Remove limitation of buffer size
6804 to <= INT_MAX.
6805
16a43933
CY
68062011-04-18 Chong Yidong <cyd@stupidchicken.com>
6807
6808 * xdisp.c (lookup_glyphless_char_display)
6809 (produce_glyphless_glyph): Handle cons cell entry in
6810 glyphless-char-display.
6811 (Vglyphless_char_display): Document it.
6812
6813 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6814 glyphless-char-display.
6815
4581706e
CY
68162011-04-17 Chong Yidong <cyd@stupidchicken.com>
6817
6818 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6819
6820 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6821
6822 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6823 definition for no-X builds.
6824
4887c6e2 68252011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6826
fd35b6f9
PE
6827 Static checks with GCC 4.6.0 and non-default toolkits.
6828
5c1ccb01
PE
6829 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6830
006c5daa
PE
6831 * process.c (keyboard_bit_set): Define only if SIGIO.
6832 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6833 (send_process): Repair possible setjmp clobbering.
6834
efc736d3
PE
6835 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6836
4e2fe2e6
PE
6837 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6838
f97334a2
PE
6839 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6840
4e75f29d
PE
6841 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6842 Define only if needed.
6843
90efadd1
PE
6844 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6845 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6846 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6847
3c647824
PE
6848 * dispextern.h (struct redisplay_interface): Rename param
6849 to avoid shadowing.
e264f262 6850 * termhooks.h (struct terminal): Likewise.
761383f4 6851 * xterm.c (xembed_send_message): Likewise.
3c647824 6852
b58c5c4a
PE
6853 * insdel.c (make_gap_smaller): Define only if
6854 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6855
cad59032
PE
6856 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6857 it.
6858
c339dc2e
PE
6859 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6860 so that we aren't warned about unused symbols.
6861
91a3e27b
PE
6862 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6863
399c71d3 6864 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6865
8ffc96f5
PE
6866 * xfns.c (x_real_positions): Mark locals as initialized.
6867
eef9bc79
PE
6868 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6869
098db9dd
PE
6870 * xterm.c: Fix problems found by static analysis with other toolkits.
6871 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6872 (x_dispatch_event): Declare static if USE_GTK, and
6873 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6874 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6875 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6876 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6877 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6878
eb18f6cc
PE
6879 * xmenu.c (menu_help_callback): Pointer type fixes.
6880 Use const pointers when pointing at readonly data. Avoid pointer
6881 signedness clashes.
6882 (FALSE): Remove unused macro.
6883 (update_frame_menubar): Remove unused decl.
6884
1fe72bf8
PE
6885 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6886
60d9e1db
PE
6887 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6888 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6889 (single_menu_item): Rename local to avoid shadowing.
6890
39261c26
PE
6891 * keyboard.c (make_lispy_event): Remove unused local var.
6892
018c5e19
PE
6893 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6894 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6895
63d2b86e
PE
6896 * bitmaps: Change bitmaps from unsigned char back to the X11
6897 compatible char. Avoid the old compiler warnings about
6898 out-of-range initializers by using, for example, '\xab' rather
6899 than 0xab.
6900
aefd87e1
PE
6901 * xgselect.c (xgselect_initialize): Check vs interface
6902 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6903
bf501fb9
PE
6904 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6905
e9829fdf
PE
6906 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6907 to read-only memory.
6908
1086c095
PE
6909 * fns.c (vector): Remove; this old hack is no longer needed.
6910
2baccd04 6911 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6912 Remove unused var.
dde42981 6913 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6914
72391843 6915 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6916
436c16df 6917 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6918 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6919 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6920
92bb796d 6921 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6922 (x_term_init): Remove local to avoid shadowing.
92bb796d 6923
764430a3 6924 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6925
6926 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6927 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6928
d1dfb56c
EZ
69292011-04-16 Eli Zaretskii <eliz@gnu.org>
6930
c4354cb4
EZ
6931 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6932
d1dfb56c
EZ
6933 Fix regex.c, syntax.c and friends for buffers > 2GB.
6934 * syntax.h (struct gl_state_s): Declare character position members
6935 EMACS_INT.
6936
6937 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6938
04f2d78b
CB
6939 * textprop.c (verify_interval_modification, interval_of):
6940 Declare arguments EMACS_INT.
d1dfb56c
EZ
6941
6942 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6943 EMACS_INT.
6944
6945 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6946
6947 * indent.c (Fvertical_motion): Local variable it_start is now
6948 EMACS_INT.
6949
6950 * regex.c (re_match, re_match_2, re_match_2_internal)
6951 (bcmp_translate, regcomp, regexec, print_double_string)
6952 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6953 (re_compile_pattern, re_exec): Declare arguments and local
6954 variables `size_t' and `ssize_t' and return values `regoff_t', as
6955 appropriate.
6956 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6957 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6958 <compile_stack_type>: `size' and `avail' are now `size_t'.
6959
6960 * regex.h <regoff_t>: Use ssize_t, not int.
6961 (re_search, re_search_2, re_match, re_match_2): Arguments that
6962 specify buffer/string position and length are now ssize_t and
6963 size_t. Return type is regoff_t.
6964
613052cd
BK
69652011-04-16 Ben Key <bkey76@gmail.com>
6966
6967 * nsfont.m: Fixed bugs in ns_get_family and
6968 ns_descriptor_to_entity that were caused by using free to
6969 deallocate memory blocks that were allocated by xmalloc (via
6970 xstrdup). This caused Emacs to crash when compiled with
6971 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6972 --enable-checking=xmallocoverrun). xfree is now used to
6973 deallocate these memory blocks.
6974
4170f62f 69752011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6976
71b41406
PE
6977 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6978
9587a89d
PE
6979 emacs_write: Accept and return EMACS_INT for sizes.
6980 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6981 et seq.
6982 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6983 Accept and return EMACS_INT.
6984 (emacs_gnutls_write): Return the number of bytes written on
6985 partial writes.
6986 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6987 (emacs_read, emacs_write): Remove check for negative size, as the
6988 Emacs source code has been audited now.
9587a89d
PE
6989 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6990 (emacs_read, emacs_write): Use it.
273a5f82
PE
6991 * process.c (send_process): Adjust to the new signatures of
6992 emacs_write and emacs_gnutls_write. Do not attempt to store
6993 a byte offset into an 'int'; it might overflow.
9587a89d 6994 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6995
3e047f51
PE
6996 * sound.c: Don't assume sizes fit in 'int'.
6997 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6998 Return EMACS_INT, not int.
3e047f51 6999 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7000 Accept EMACS_INT, not int.
7001 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7002 record read return values.
7003
cc39a9db
BK
70042011-04-15 Ben Key <bkey76@gmail.com>
7005
c9d0ec6d
JB
7006 * keyboard.c (Qundefined): Don't declare static since it is used
7007 in nsfns.m.
7008 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7009 static since they are used in nsfont.m.
cc39a9db 7010
6c60eb9f
SM
70112011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7012
7013 * process.c (Qprocessp): Don't declare static.
7014 * lisp.h (Qprocessp): Declare again.
7015
7990b61a
JB
70162011-04-15 Juanma Barranquero <lekktu@gmail.com>
7017
7018 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7019
5d4cb038
PE
70202011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7021
8bd7b830 7022 Improve C-level modularity by making more things 'static'.
cd64ea1d 7023
e3b27b31
PE
7024 Don't publish debugger-only interfaces to other modules.
7025 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7026 (verify_bytepos, count_markers): Move decls to the only modules
7027 that need them.
7028 * region-cache.h (pp_cache): Likewise.
7029 * window.h (check_all_windows): Likewise.
7030 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7031
5d4cb038
PE
7032 * sysdep.c (croak): Now static, if
7033 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7034 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7035
7036 * alloc.c (refill_memory_reserve): Now static if
7037 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7038 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7039
e87b6180
PE
7040 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7041 Define only if USE_LUCID.
7042
ac64929e
PE
7043 * xrdb.c (x_customization_string, x_rm_string): Now static.
7044
6f37259d
PE
7045 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7046 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7047
1683e3ab
PE
7048 * xdisp.c (draw_row_with_mouse_face): Now static.
7049 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7050
de9c2632
PE
7051 * window.h (check_all_windows): Mark externally visible.
7052
2b96acb7
PE
7053 * window.c (window_deletion_count): Now static.
7054
7055 * undo.c: Make symbols static if they're not exported.
7056 (last_undo_buffer, last_boundary_position, pending_boundary):
7057 Now static.
7058
50436f33
PE
7059 * textprop.c (interval_insert_behind_hooks): Now static.
7060 (interval_insert_in_front_hooks): Likewise.
7061
64520e5c
PE
7062 * term.c: Make symbols static if they're not exported.
7063 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7064 (max_frame_lines, tty_set_terminal_modes):
7065 (tty_reset_terminal_modes, tty_turn_off_highlight):
7066 (get_tty_terminal): Now static.
7067 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7068 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7069 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7070 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7071 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7072
1fa53021
PE
7073 * sysdep.c: Make symbols static if they're not exported.
7074 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7075 Now static.
7076 (sigprocmask_set, full_mask): Remove; unused.
7077 (wait_debugging): Mark as visible.
7078 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7079 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7080
d4b43b22
PE
7081 * syntax.c (syntax_temp): Define only if !__GNUC__.
7082
b7c513d0
PE
7083 * sound.c (current_sound_device, current_sound): Now static.
7084
989b29ad
PE
7085 * search.c (searchbufs, searchbuf_head): Now static.
7086
13a55a78
PE
7087 * scroll.c (scroll_cost): Remove; unused.
7088 * dispextern.h (scroll_cost): Remove decl.
7089
de68a1fc
PE
7090 * region-cache.h (pp_cache): Mark as externally visible.
7091
40ccffa6
PE
7092 * process.c: Make symbols static if they're not exported.
7093 (process_tick, update_tick, create_process, chan_process):
7094 (Vprocess_alist, proc_buffered_char, datagram_access):
7095 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7096 (deactivate_process): Mark defn as static, as well as decl.
7097 * lisp.h (create_process): Remove decl.
7098 * process.h (chan_process, Vprocess_alist): Remove decls.
7099
ad64fc97
PE
7100 * print.c: Make symbols static if they're not exported.
7101 (print_depth, new_backquote_output, being_printed, print_buffer):
7102 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7103 (print_interval, print_number_index, initial_stderr_stream):
7104 Now static.
7105 * lisp.h (Fprinc): Remove decl.
7106 (debug_output_compilation_hack): Mark as externally visible.
7107
adddb265
PE
7108 * sysdep.c (croak): Move decl from here to syssignal.h.
7109 * syssignal.h (croak): Put it here, so the API can be checked when
7110 'croak' is called from dissociate_if_controlling_tty.
7111
1717ede2
PE
7112 * minibuf.c: Make symbols static if they're not exported.
7113 (minibuf_save_list, choose_minibuf_frame): Now static.
7114 * lisp.h (choose_minibuf_frame): Remove decl.
7115
fa5fb2bc
PE
7116 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7117
1e3890d1
PE
7118 * lread.c: Make symbols static if they're not exported.
7119 (read_objects, initial_obarray, oblookup_last_bucket_number):
7120 Now static.
7121 (make_symbol): Remove; unused.
7122 * lisp.h (initial_obarray, make_symbol): Remove decls.
7123
8a1414fa
PE
7124 * keyboard.c: Make symbols static if they're not exported.
7125 (single_kboard, recent_keys_index, total_keys, recent_keys):
7126 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7127 (this_single_command_key_start, echoing, last_auto_save):
7128 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7129 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7130 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7131 (Vlispy_mouse_stem, double_click_count):
7132 Now static.
7133 (force_auto_save_soon): Define only if SIGDANGER.
7134 (ignore_mouse_drag_p): Now static if
7135 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7136 (print_help): Remove; unused.
7137 (stop_character, last_timer_event): Mark as externally visible.
7138 * keyboard.h (ignore_mouse_drag_p): Declare only if
7139 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7140 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7141 * lisp.h (echoing): Remove decl.
7142 (force_auto_save_soon): Declare only if SIGDANGER.
7143 * xdisp.c (redisplay_window): Simplify code, to make it more
7144 obvious that ignore_mouse_drag_p is not accessed if !defined
7145 USE_GTK && !defined HAVE_NS.
7146
93ea6e8f
PE
7147 * intervals.c: Make symbols static if they're not exported.
7148 (merge_properties_sticky, merge_interval_right, delete_interval):
7149 Now static.
7150 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7151
77382fcc
PE
7152 * insdel.c: Make symbols static if they're not exported.
7153 However, leave prepare_to_modify_buffer alone. It's never
7154 called from outside this function, but that appears to be a bug.
7155 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7156 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7157 (adjust_after_replace_noundo): Remove; unused.
7158 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7159 (signal_before_change): Remove decls.
77382fcc 7160
9306c32e
PE
7161 * indent.c (val_compute_motion, val_vmotion): Now static.
7162
cd44d2eb
PE
7163 * image.c: Make symbols static if they're not exported.
7164 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7165 if USE_GTK.
7166 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7167 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7168
ad9a7a06
PE
7169 * fringe.c (standard_bitmaps): Now static.
7170 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7171
81626931
PE
7172 * frame.c: Make symbols static if they're not exported.
7173 (x_report_frame_params, make_terminal_frame): Now static.
7174 (get_frame_param): Now static, unless HAVE_NS.
7175 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7176 (x_get_resource_string): Remove; not used.
7177 * frame.h (make_terminal_frame, x_report_frame_params):
7178 (x_get_resource_string); Remove decls.
7179 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7180 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7181
239f9db9
PE
7182 * font.c, fontset.c: Make symbols static if they're not exported.
7183 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7184 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7185 * font.c (font_close_object): Now static.
7186 * font.h (font_close_object): Remove.
7187 * fontset.c (FONTSET_OBJLIST): Remove.
7188 (free_realized_fontset) #if-0 the body, which does nothing.
7189 (face_suitable_for_char_p): #if-0, as it's never called.
7190 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7191 * xfaces.c (face_at_string_position):
7192 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7193 since 0 is always ASCII.
7194
dfcf3579
PE
7195 * fns.c (weak_hash_tables): Now static.
7196
5045092b
PE
7197 * fileio.c: Make symbols static if they're not exported.
7198 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7199 (Vwrite_region_annotation_buffers): Now static.
7200
57a96f5c
PE
7201 * eval.c: Make symbols static if they're not exported.
7202 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7203 * lisp.h (backtrace_list): Remove decl.
7204
35f08c38
PE
7205 * emacs.c: Make symbols static if they're not exported.
7206 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7207 (fatal_error_code, fatal_error_signal_hook, standard_args):
7208 Now static.
7209 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7210 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7211 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7212 * lisp.h (fatal_error_signal_hook): Remove decl.
7213 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7214
f44bd759
PE
7215 * editfns.c: Move a (normally-unused) function to its only use.
7216 * editfns.c, lisp.h (get_operating_system_release): Remove.
7217 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7218 worth the hassle of breaking this out.
7219
b532497d
PE
7220 * xterm.c: Make symbols static if they're not exported.
7221 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7222 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7223 (x_destroy_window, x_delete_display):
7224 Now static.
7225 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7226 (x_mouse_leave): Remove; unused.
7227 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7228 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7229 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7230 Remove decls.
7231 (x_mouse_leave): Declare only if WINDOWSNT.
7232 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7233 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7234 USE_X_TOOLKIT.
7235
1675728f
PE
7236 * ftxfont.c: Make symbols static if they're not exported.
7237 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7238 HAVE_FREETYPE.
7239 * font.h (ftxfont_driver): Likewise.
7240
e4cebfca
PE
7241 * xfns.c: Make symbols static if they're not exported.
7242 (x_last_font_name, x_display_info_for_name):
7243 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7244 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7245 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7246 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7247 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7248 (last_show_tip_args): Now static.
7249 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7250 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7251 (x_screen_planes): Remove; unused.
7252 * dispextern.h (x_screen_planes): Remove decl.
7253
5bf46f05
PE
7254 * dispnew.c: Make symbols static if they're not exported.
7255 * dispextern.h (redraw_garbaged_frames, scrolling):
7256 (increment_row_positions): Remove.
7257 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7258 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7259 Now static.
7260 (redraw_garbaged_frames): Remove; unused.
7261
435f4c28
PE
7262 * xfaces.c: Make symbols static if they're not exported.
7263 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7264 Remove decls.
7265 * xterm.h (defined_color): Remove decls.
7266 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7267 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7268 (menu_face_changed_default, defined_color, free_realized_face):
7269 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7270 (ascii_face_of_lisp_face): Remove; unused.
7271
8524aef3
PE
7272 * xdisp.c: Make symbols static if they're not exported.
7273 * dispextern.h (scratch_glyph_row, window_box_edges):
7274 (glyph_to_pixel_coords, set_cursor_from_row):
7275 (get_next_display_element, set_iterator_to_next):
7276 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7277 (show_mouse_face): Remove decls
7278 * frame.h (message_buf_print): Likewise.
7279 * lisp.h (pop_message, set_message, check_point_in_composition):
7280 Likewise.
7281 * xterm.h (set_vertical_scroll_bar): Likewise.
7282 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7283 (message_buf_print, scratch_glyph_row, displayed_buffer):
7284 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7285 (get_next_display_element, show_mouse_face, window_box_edges):
7286 (frame_to_window_pixel_xy, check_point_in_composition):
7287 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7288 (glyph_to_pixel_coords): Remove; unused.
7289
16390cd2
PE
7290 * dired.c (file_name_completion): Now static.
7291
7292 * dbusbind.c (xd_in_read_queued_messages): Now static.
7293
a25f4dfa
PE
7294 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7295 * data.c (circular_list_error): Remove.
7296
14a9c8df
PE
7297 * commands.h (last_point_position, last_point_position_buffer):
7298 (last_point_position_window): Remove decls.
7299 * keyboard.c: Make these variables static.
7300
04f2d78b
CB
7301 * coding.h (coding, code_convert_region, encode_coding_gap):
7302 Remove decls.
74ab6df5
PE
7303 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7304 (iso_code_class, detect_coding, code_convert_region): Now static.
7305 (encode_coding_gap): Remove; unused.
7306
38dfbee1
PE
7307 * chartab.c (chartab_chars, chartab_bits): Now static.
7308
a2cb4e63
PE
7309 * charset.h (charset_iso_8859_1): Remove decl.
7310 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7311 Now static.
7312
127198fd
PE
7313 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7314 * ccl.c (Vccl_program_table): Now static.
7315 (check_ccl_update): Remove; unused.
7316
d85b608f
PE
7317 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7318 * category.h: ... from here.
7319 * category.c (check_category_table, set_category_set): Now static.
7320
31cd66f3
PE
7321 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7322 * lisp.h: Remove these decls.
7323
c358e587
PE
7324 * buffer.c (buffer_count): Remove unused var.
7325
e78aecca
PE
7326 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7327 so that it's not optimized away.
7328 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7329 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7330 exported only to the debugger.
7331
e192d7d3 7332 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7333 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7334
92470028
PE
7335 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7336 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7337 was inaccessible from Lisp.
7338 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7339 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7340
244ed907
PE
7341 alloc.c: Import and export fewer symbols, and remove unused items.
7342 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7343 is defined.
7344 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7345 it's not optimized away by whole-program optimization.
7346 (message_enable_multibyte, free_misc): Remove.
7347 (catchlist, handlerlist, mark_backtrace):
7348 Declare only if BYTE_MARK_STACK.
7349 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7350 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7351 (message_enable_multibyte): Remove decl.
7352 (free_misc, interval_free_list, float_block, float_block_index):
7353 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7354 (cons_free_list, last_marked_index):
7355 Now static.
7356 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7357 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7358 (mark_backtrace): Define only if BYTE_MARK_STACK.
7359 * xdisp.c (message_enable_multibyte): Now static.
7360
61c2b50e 7361 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7362 This makes it easier for human readers (and static analyzers)
7363 to see whether these variables are used from other modules.
7364 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7365 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7366 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7367 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7368 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7369 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7370 * xmenu.c, xselect.c:
7371 Declare Q* vars static if they are not used in other modules.
7372 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7373 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7374 Remove decls of unexported vars.
7375 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7376
95c82688
PE
7377 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7378
16a97296
PE
7379 Make Emacs functions such as Fatom 'static' by default.
7380 This makes it easier for human readers (and static analyzers)
7381 to see whether these functions can be called from other modules.
7382 DEFUN now defines a static function. To make the function external
7383 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7384 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7385 (Finit_image_library):
16a97296
PE
7386 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7387 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7388 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7389 Remove decls, since these functions are now static.
7390 (Funintern, Fget_internal_run_time): New decls, since these functions
7391 were already external.
95c82688 7392
16a97296
PE
7393 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7394 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7395 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7396 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7397 * keyboard.c, keymap.c, lread.c:
7398 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7399 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7400 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7401 Mark functions with DEFUE instead of DEFUN,
7402 if they are used in other modules.
7403 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7404 decls for now-static functions.
7405 * buffer.h (Fdelete_overlay): Remove decl.
7406 * callproc.c (Fgetenv_internal): Mark as internal.
7407 * composite.c (Fremove_list_of_text_properties): Remove decl.
7408 (Fcomposition_get_gstring): New forward static decl.
7409 * composite.h (Fcomposite_get_gstring): Remove decl.
7410 * dired.c (Ffile_attributes): New forward static decl.
7411 * doc.c (Fdocumntation_property): New forward static decl.
7412 * eval.c (Ffetch_bytecode): New forward static decl.
7413 (Funintern): Remove extern decl; now in .h file where it belongs.
7414 * fileio.c (Fmake_symbolic_link): New forward static decl.
7415 * image.c (Finit_image_library): New forward static decl.
7416 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7417 * intervals.h (Fprevious_property_change):
7418 (Fremove_list_of_text_properties): Remove decls.
7419 * keyboard.c (Fthis_command_keys): Remove decl.
7420 (Fcommand_execute): New forward static decl.
7421 * keymap.c (Flookup_key): New forward static decl.
7422 (Fcopy_keymap): Now static.
7423 * keymap.h (Flookup_key): Remove decl.
7424 * process.c (Fget_process): New forward static decl.
7425 (Fprocess_datagram_address): Mark as internal.
7426 * syntax.c (Fsyntax_table_p): New forward static decl.
7427 (skip_chars): Remove duplicate decl.
7428 * textprop.c (Fprevious_property_change): New forward static decl.
7429 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7430 Now internal.
7431 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7432 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7433
785bbd42
PE
7434 * editfns.c (Fformat): Remove unreachable code.
7435
8b913b57
AS
74362011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7437
7438 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7439 change. (Bug#8496)
7440
a6744a35
EZ
74412011-04-13 Eli Zaretskii <eliz@gnu.org>
7442
7443 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7444 when at ZV. (Bug#8487)
7445
e7974947
AS
74462011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7447
baad03f0
AS
7448 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7449 (Bug#8437)
7450 * keyboard.c (parse_tool_bar_item): Likewise.
7451 * sound.c (sound_cleanup, alsa_close): Likewise.
7452 * termcap.c (tgetent): Likewise.
7453 * xfns.c (x_default_font_parameter): Likewise.
7454 * xsettings.c (read_and_apply_settings): Likewise.
7455
e7974947
AS
7456 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7457 (overrun_check_free): Protoize.
7458
28272684
PE
74592011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7460
7461 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7462 since callers should never pass a negative size.
7463 Change the signature to match that of plain 'read' and 'write'; see
7464 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7465 * lisp.h: Update prototypes of emacs_write and emacs_read.
7466
11997c76
EZ
74672011-04-11 Eli Zaretskii <eliz@gnu.org>
7468
7469 * xdisp.c (redisplay_window): Don't try to determine the character
7470 position of the scroll margin if the window start point w->startp
e896f03c 7471 is outside the buffer's accessible region. (Bug#8468)
11997c76 7472
8a2cbd72
EZ
74732011-04-10 Eli Zaretskii <eliz@gnu.org>
7474
7475 Fix write-region and its subroutines for buffers > 2GB.
7476 * fileio.c (a_write, e_write): Modify declaration of arguments and
7477 local variables to support buffers larger than 2GB.
7478 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7479
7480 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7481 argument, local variables, and return value.
7482
7483 * lisp.h: Update prototypes of emacs_write and emacs_read.
7484
7485 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7486
4073e537 74872011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7488
1ebfdcb6
PE
7489 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7490
b2ded58d
PE
7491 Fix more problems found by GCC 4.6.0's static checks.
7492
7d66342c
PE
7493 * xdisp.c (vmessage): Use a better test for character truncation.
7494
bbf47d44
PE
7495 * charset.c (load_charset_map): <, not <=, for optimization,
7496 and to avoid potential problems with integer overflow.
9248994d 7497 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7498 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7499 * editfns.c (Fformat): Likewise.
1e69125e 7500 * syntax.c (skip_chars): Likewise.
3befa583 7501
e3019616
PE
7502 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7503 This also lets GCC 4.6.0 generate slightly better loop code.
7504
becfa255
PE
7505 * callint.c (Fcall_interactively): <, not <=, for optimization.
7506 (Fcall_interactively): Count the number of arguments produced,
7507 not the number of arguments given. This is simpler and lets GCC
7508 4.6.0 generate slightly better code.
7509
dae0cd48
PE
7510 * ftfont.c: Distingish more carefully between FcChar8 and char.
7511 The previous code passed unsigned char * to a functions like
7512 strlen and xstrcasecmp that expect char *, which does not
7513 conform to the C standard.
7514 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7515 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7516 char * when the C standard requires it.
7517
76032d70
PE
7518 * keyboard.c (read_char): Remove unused var.
7519
eb3f1cc8
PE
7520 * eval.c: Port to Windows vsnprintf (Bug#8435).
7521 Include <limits.h>.
7522 (SIZE_MAX): Define if the headers do not.
7523 (verror): Do not give up if vsnprintf returns a negative count.
7524 Instead, grow the buffer. This ports to Windows vsnprintf, which
7525 does not conform to C99. Problem reported by Eli Zaretskii.
7526 Also, simplify the allocation scheme, by avoiding the need for
7527 calling realloc, and removing the ALLOCATED variable.
7528
70476b54
PE
7529 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7530
12020a9e
PE
7531 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7532 But keep the doprint source code for now, as we might revamp it
7533 and use it again (Bug#8435).
ea6c7ae6
PE
7534 * lisp.h (doprnt): Remove.
7535 * Makefile.in (base_obj): Remove doprnt.o.
7536 * deps.mk (doprnt.o): Remove.
7537
5fdb398c
PE
7538 error: Print 32- and 64-bit integers portably (Bug#8435).
7539 Without this change, on typical 64-bit hosts error ("...%d...", N)
7540 was used to print both 32- and 64-bit integers N, which relied on
7541 undefined behavior.
7542 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7543 New macro.
7544 * lisp.h (error, verror): Mark as printf-like functions.
7545 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7546 Report overflow in size calculations when allocating printf buffer.
7547 Do not truncate output string at its first null byte.
7548 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7549 Truncate the output at a character boundary, since vsnprintf does not
7550 do that.
7551 * charset.c (check_iso_charset_parameter): Convert internal
7552 character to string before calling 'error', since %c now has the
7553 printf meaning.
7554 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7555 overflow when computing char to be passed to 'error'. Do not
7556 pass Lisp_Object to 'error'; pass the integer instead.
7557 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7558 formatted with plain %d.
7559
b189fa66
PE
7560 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7561
bff87ef0
PE
7562 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7563
7e2cac20
PE
7564 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7565
ce4d90b5
PE
7566 * xterm.c (x_catch_errors): Remove duplicate declaration.
7567
266c9547
PE
7568 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7569
79c49ad2
PE
7570 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7571
368f4090
JM
75722011-04-10 Jim Meyering <meyering@redhat.com>
7573
7574 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7575 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7576 return ssize_t not "int", and use size_t as the buffer length.
7577 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7578 * gnutls.h: Update declarations.
7579 * process.c (read_process_output): Use ssize_t, to match.
7580 (send_process): Likewise.
7581
a32d4040
CY
75822011-04-09 Chong Yidong <cyd@stupidchicken.com>
7583
7584 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7585
8546720e 75862011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7587
04f2d78b
CB
7588 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7589 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7590
8546720e
GM
7591 * xterm.c (handle_one_xevent):
7592 * xmenu.c (create_and_show_popup_menu):
7593 * xselect.c (x_decline_selection_request)
7594 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7595
0a2f5c1a 75962011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7597
7598 Fix some uses of `int' instead of EMACS_INT.
7599 * search.c (string_match_1, fast_string_match)
7600 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7601 (scan_buffer, find_next_newline_no_quit)
7602 (find_before_next_newline, search_command, Freplace_match)
7603 (Fmatch_data): Make some `int' variables be EMACS_INT.
7604
7605 * xdisp.c (display_count_lines): 3rd argument and return value now
7606 EMACS_INT. All callers changed.
7607 (pint2hrstr): Last argument is now EMACS_INT.
7608
7609 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7610 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7611 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7612 (decode_coding_utf_16, decode_coding_emacs_mule)
7613 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7614 (decode_coding_ccl, decode_coding_charset)
7615 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7616 (decode_coding_iso_2022, decode_coding_emacs_mule)
7617 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7618 <char_offset, last_offset>: Declare EMACS_INT.
7619 (encode_coding_utf_8, encode_coding_utf_16)
7620 (encode_coding_emacs_mule, encode_invocation_designation)
7621 (encode_designation_at_bol, encode_coding_iso_2022)
7622 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7623 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7624 Declare EMACS_INT.
7625 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7626 (encode_invocation_designation): Last argument P_NCHARS is now
7627 EMACS_INT.
7628 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7629 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7630
7631 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7632 All users changed.
7633
7634 * ccl.c (Fccl_execute_on_string): Declare some variables
7635 EMACS_INT.
7636
8546720e 76372011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7638
7639 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7640
4e19a977
CS
76412011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7642
7643 * process.c (Fformat_network_address): Doc fix.
7644
87302331
R
76452011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7646
ee7683eb 7647 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7648
cbb59342
CY
76492011-04-08 Chong Yidong <cyd@stupidchicken.com>
7650
7651 * keyboard.c (read_char): Call Lisp function help-form-show,
7652 instead of using internal_with_output_to_temp_buffer.
7653 (Qhelp_form_show): New var.
e0d38eeb 7654 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7655
7656 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7657
7658 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7659
e67a13ab
CY
76602011-04-06 Chong Yidong <cyd@stupidchicken.com>
7661
04f2d78b
CB
7662 * process.c (Flist_processes): Remove to Lisp.
7663 (list_processes_1): Delete.
e67a13ab 7664
973f782d
EZ
76652011-04-06 Eli Zaretskii <eliz@gnu.org>
7666
7c106b1e
EZ
7667 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7668
973f782d
EZ
7669 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7670
41cf7d1a 76712011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7672
ca23cc88
PE
7673 Fix more problems found by GCC 4.6.0's static checks.
7674
f390e2d5
PE
7675 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7676
42eea0d0
PE
7677 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7678
b69769da 7679 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7680
f9541e84
PE
7681 * xdisp.c (vmessage): Mark as a printf-like function.
7682
13841b55
PE
7683 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7684
c136c10f
PE
7685 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7686
5e2d4a30
PE
7687 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7688 printf-like functions.
7689 (tiff_load): Add casts to remove these marks before passing them
7690 to system-supplied API.
7691
583f48b9
PE
7692 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7693
b25d760e
PE
7694 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7695 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7696 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7697 directly, rather than having caller test rule sign. This avoids
7698 some unnecessary tests.
7699 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7700 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7701 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7702
bc7b6697 7703 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7704 (xfont_open): Avoid unnecessary tests.
bc7b6697 7705
27ccc379
PE
7706 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7707
dcd5c89a
PE
7708 * composite.h, composite.c (composition_gstring_put_cache):
7709 Use EMACS_INT, not int, for length.
7710
b13a45c6
PE
7711 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7712 breaking out part of COMPOSITION_DECODE_RULE.
7713 (COMPOSITION_DECODE_RULE): Use it.
7714 * composite.c (get_composition_id): Remove unused local vars,
7715 by using the new macro.
7716
1e792e4d
PE
7717 * textprop.c (set_text_properties_1): Change while to do-while,
7718 since the condition is always true at first.
7719
dc6c6455 7720 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7721 (interval_deletion_adjustment): Return unsigned value.
7722 All uses changed.
dc6c6455 7723
aba7731a
PE
7724 * process.c (list_processes_1, create_pty, read_process_output):
7725 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7726 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7727 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7728 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7729 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7730
fdfc4bf3
PE
7731 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7732
fca8fe46 7733 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7734 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7735
06a0259a 7736 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7737 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7738 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7739
e7b9e80f
PE
7740 * print.c (print_error_message): Avoid int overflow.
7741
56201685
PE
7742 * font.c (font_list_entities): Redo for clarity,
7743 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7744
78834453 7745 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7746 (font_score): Avoid potential overflow in diff calculation.
78834453 7747
0bc0b309 7748 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7749 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7750
e610eaca
PE
7751 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7752
b895abce
PE
7753 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7754 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7755 can always succeed if overflow has undefined behavior.
7756
1f1d9321 7757 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7758 (wordify): Omit three unnecessary tests.
1f1d9321 7759
c59478bc
PE
7760 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7761 All callers changed. This avoids the need for an unused var.
7762
79b73827
PE
7763 * casefiddle.c (casify_region): Remove var that is set but not used.
7764
a4db5dfe
PE
7765 * dired.c (file_name_completion): Remove var that is set but not used.
7766
43aae36e
PE
7767 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7768
2a47c44d 7769 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7770 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7771
a37c69bf
PE
7772 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7773 Check for integer overflow on size calculations.
7774
328ab8e7
PE
7775 * buffer.c (Fprevious_overlay_change): Remove var that is set
7776 but not used.
7777
e5a2a5cb
PE
7778 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7779 Remove vars that are set but not used.
8d84a6eb 7780 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7781 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7782
a60e5f68
PE
7783 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7784
f661cb61 7785 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7786 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7787
f0397f5a
PE
7788 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7789 that are set but not used.
7790
8664db06 7791 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7792 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7793
6abdaa4a
PE
7794 * xselect.c (x_get_local_selection, x_handle_property_notify):
7795 Remove vars that are set but not used.
7796
0ce7538d 7797 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7798 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7799
9ae848fc
PE
7800 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7801 Remove var that is set but not used.
0b918413
PE
7802 (scroll_bar_windows_size): Now size_t, not int.
7803 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7804 Check for overflow.
9ae848fc 7805
a5a62657
PE
7806 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7807 (map_tty_color) [!defined MSDOS]: Likewise.
7808
5c5cdd39
PE
7809 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7810
66ebf983
PE
7811 * coding.c: Remove vars that are set but not used.
7812 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7813 All callers changed.
7814 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7815 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7816 (decode_coding_charset): Remove vars that are set but not used.
7817
1be4d761
PE
7818 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7819 that is set but not used.
7820
47553fa8
PE
7821 * print.c (print_object): Remove var that is set but not used.
7822
1f7196bf 7823 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7824 The gnulib version avoids calling malloc in the usual case,
7825 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7826 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7827 * filelock.c (current_lock_owner): Likewise.
7828 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7829 * sysdep.c: Include allocator.h, careadlinkat.h.
7830 (emacs_no_realloc_allocator): New static constant.
7831 (emacs_readlink): New function.
fdb61804
PE
7832 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7833 ../lib/careadlinkat.h.
d1fdcab7 7834
f84c17c7
SM
78352011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7836
7837 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7838 first non-nil return value).
7839
ef3862ad
JD
78402011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7841
7842 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7843 if not defined (Bug#8403).
7844
376a7006
JB
78452011-04-02 Juanma Barranquero <lekktu@gmail.com>
7846
7847 * xdisp.c (display_count_lines): Remove parameter `start',
7848 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7849 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7850 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7851 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7852 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7853 and thereabouts. All callers changed.
7854 (get_per_char_metric): Remove parameter `f', unused since
7855 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7856
6ca3801d
JM
78572011-04-02 Jim Meyering <meyering@redhat.com>
7858
7859 do not dereference NULL upon failed strdup
7860 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7861 (ns_get_family): Likewise.
7862
d8e2b5ba
JB
78632011-04-02 Juanma Barranquero <lekktu@gmail.com>
7864
7865 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7866
8c74fcbd
JD
78672011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7868
7869 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7870 later (Bug#8403).
7871
7200d79c
SM
78722011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7873
03408648 7874 Add lexical binding.
7200d79c 7875
03408648
SM
7876 * window.c (Ftemp_output_buffer_show): New fun.
7877 (Fsave_window_excursion):
7878 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7879
7880 * lread.c (lisp_file_lexically_bound_p): New function.
7881 (Fload): Bind Qlexical_binding.
7882 (readevalloop): Remove `evalfun' arg.
7883 Bind Qinternal_interpreter_environment.
7884 (Feval_buffer): Bind Qlexical_binding.
7885 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7886 Mark as dynamic.
7887 (syms_of_lread): Declare `lexical-binding'.
7888
7889 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7890
7891 * keyboard.c (eval_dyn): New fun.
7892 (menu_item_eval_property): Use it.
ca105506
SM
7893
7894 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7895
03408648
SM
7896 * fns.c (concat, mapcar1): Accept byte-code-functions.
7897
7898 * eval.c (Fsetq): Handle lexical vars.
7899 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7900 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7901 (FletX, Flet): Obey lexical binding.
7902 (Fcommandp): Handle closures.
7903 (Feval): New `lexical' arg.
7904 (eval_sub): New function extracted from Feval. Use it almost
7905 everywhere where Feval was used. Look up vars in lexical env.
7906 Handle closures.
7907 (Ffunctionp): Move from subr.el.
7908 (Ffuncall): Handle closures.
7909 (apply_lambda): Remove `eval_flags'.
7910 (funcall_lambda): Handle closures and new byte-code-functions.
7911 (Fspecial_variable_p): New function.
7912 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7913 but without exporting it to Lisp.
23aba0ea 7914
23aba0ea 7915 * doc.c (Fdocumentation, store_function_docstring):
03408648 7916 * data.c (Finteractive_form): Handle closures.
23aba0ea 7917
03408648
SM
7918 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7919 interactive spec.
ba83908c 7920
04f2d78b
CB
7921 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7922 New byte-codes.
03408648
SM
7923 (exec_byte_code): New function extracted from Fbyte_code to handle new
7924 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7925
03408648 7926 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7927
03408648 7928 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7929
e2abce01
JB
79302011-03-31 Juanma Barranquero <lekktu@gmail.com>
7931
7932 * xdisp.c (redisplay_internal): Fix prototype.
7933
63696a73 79342011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7935
63696a73 7936 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7937 (try_scrolling): Use it when setting scroll_limit.
7938 Limit scrolling to 100 screen lines.
63696a73
EZ
7939 (redisplay_window): Even when falling back on "recentering",
7940 position point in the window according to scroll-conservatively,
7941 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7942
7943 (try_scrolling): When point is above the window, allow searching
7944 as far as scroll_max, or one screenful, to compute vertical
7945 distance from PT to the scroll margin position. This prevents
7946 try_scrolling from unnecessarily failing when
7947 scroll-conservatively is set to a value slightly larger than the
7948 window height. Clean up the case of PT below the margin at bottom
7949 of window: scroll_max can no longer be INT_MAX. When aggressive
7950 scrolling is in use, don't let point enter the opposite scroll
7951 margin as result of the scroll.
7952 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7953 threshold of 100 lines for never-recentering scrolling.
7954
e4cc2dfc
JB
79552011-03-31 Juanma Barranquero <lekktu@gmail.com>
7956
7957 * dispextern.h (move_it_by_lines):
7958 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7959 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7960 (message_log_check_duplicate): Remove parameters `prev_bol' and
7961 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7962 (redisplay_internal): Remove parameter `preserve_echo_area',
7963 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7964
7965 * indent.c (Fvertical_motion):
7966 * window.c (window_scroll_pixel_based, Frecenter):
7967 Don't pass `need_y_p' to `move_it_by_lines'.
7968
1c470562
SM
79692011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7970
44f230aa
SM
7971 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7972 steal a few bits to be more compact.
7973 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7974 Remove unneeded casts.
7975
1c470562
SM
7976 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7977
888adce9
ZK
79782011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7979
7980 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7981 binding" message (bug#7967).
7982
f838ed7b
PE
79832011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7984
77861b95
PE
7985 Fix more problems found by GCC 4.6.0's static checks.
7986
de6dbc14
PE
7987 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7988 Remove unused local var.
7989
f838ed7b
PE
7990 * editfns.c (Fmessage_box): Remove unused local var.
7991
792c7b2b
PE
7992 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7993 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7994 Omit unused local vars.
c499e557 7995 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7996 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7997 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7998 Omit unused local var.
7999
ba0165e1
PE
8000 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8001 Don't assume string length fits in int.
32ad8845 8002 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8003 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8004
3c59b4c9
PE
8005 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8006 instead of alloca (Bug#8344).
8007
a3eed478 8008 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8009 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8010
eb4d412d
PE
8011 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8012
1658b401
PE
8013 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8014 concerns.
8015
8016 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8017
8018 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8019
9a2c6e05
PE
8020 * keyboard.c (syms_of_keyboard): Use the same style as later
8021 in this function when indexing through an array. This also
8022 works around GCC bug 48267.
8023
03d0a109
PE
8024 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8025
44f730c8
PE
8026 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8027
fe75f926
PE
8028 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8029 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8030
ffa8c828
PE
8031 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8032 This avoids undefined behavior on integer overflow, and is a bit
8033 more convenient anyway since it is compared to a size_t variable.
8034
c5101a77
PE
8035 Variadic C functions now count arguments with size_t, not int.
8036 This avoids an unnecessary limitation on 64-bit machines, which
8037 caused (substring ...) to crash on large vectors (Bug#8344).
8038 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8039 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8040 All variadic functions and their callers changed accordingly.
c5101a77
PE
8041 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8042 * data.c (arith_driver, float_arith_driver): Likewise.
8043 * editfns.c (general_insert_function): Likewise.
8044 * eval.c (struct backtrace.nargs, interactive_p)
8045 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8046 (funcall_lambda, mark_backtrace): Likewise.
8047 * fns.c (concat): Likewise.
8048 * frame.c (x_set_frame_parameters): Likewise.
8049 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8050 0 if not found, not -1. All callers changed.
8051
dd3f25f7
PE
8052 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8053 (stack_copy_size): Now size_t, not int.
8054 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8055
461c2ab9
JB
80562011-03-28 Juanma Barranquero <lekktu@gmail.com>
8057
8058 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8059 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8060 All callers changed.
8061
8062 * lisp.h (multibyte_char_to_unibyte):
8063 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8064 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8065 * character.h (CHAR_TO_BYTE8):
8066 * cmds.c (internal_self_insert):
8067 * editfns.c (general_insert_function):
8068 * keymap.c (push_key_description):
8069 * search.c (Freplace_match):
8070 * xdisp.c (message_dolog, set_message_1): All callers changed.
8071
f6d62986
SM
80722011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8073
8074 * keyboard.c (safe_run_hook_funcall): New function.
8075 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8076 don't set the hook to nil, but remove the offending function instead.
8077 (Qcommand_hook_internal): Remove, unused.
8078 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8079 Vcommand_hook_internal.
8080
8081 * eval.c (enum run_hooks_condition): Remove.
8082 (funcall_nil, funcall_not): New functions.
8083 (run_hook_with_args): Call each function through a `funcall' argument.
8084 Remove `cond' argument, now redundant.
8085 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8086 (Frun_hook_with_args_until_failure): Adjust accordingly.
8087 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8088
1db5b1ad
JB
80892011-03-28 Juanma Barranquero <lekktu@gmail.com>
8090
8091 * dispextern.h (string_buffer_position): Remove declaration.
8092
8093 * print.c (strout): Remove parameter `multibyte', unused since
8094 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8095
8096 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8097 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8098 All callers changed.
8099
8100 * w32.c (_wsa_errlist): Use braces for struct initializers.
8101
8102 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8103 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8104 All callers changed.
8105 (string_buffer_position): Likewise. Also, make static (it's never
8106 used outside xdisp.c).
8107 (cursor_row_p): Remove parameter `w', unused since
8108 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8109 (decode_mode_spec): Remove parameter `precision', introduced during
8110 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8111 All callers changed.
8112
5ffb62aa
JD
81132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8114
8115 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8116
461c2ab9 81172011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8118
8119 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8120 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8121 (ns_update_auto_hide_menu_bar): New functions.
8122 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8123 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8124 ns_constrain_all_frames.
8125 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8126 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8127
5c380ffb
JD
81282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8129
8130 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8131
9af30bdf
GM
81322011-03-27 Glenn Morris <rgm@gnu.org>
8133
8134 * syssignal.h: Replace RETSIGTYPE with void.
8135 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8136 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8137 Replace SIGTYPE with void everywhere.
8138 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8139 * s/template.h (SIGTYPE): Remove commented out definition.
8140
e2abce01
JB
81412011-03-26 Eli Zaretskii <eliz@gnu.org>
8142
8143 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8144 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8145
f868cd8a
JB
81462011-03-26 Juanma Barranquero <lekktu@gmail.com>
8147
59eb0929
JB
8148 * w32.c (read_unc_volume): Use parameter `henum', instead of
8149 global variable `wget_enum_handle'.
8150
8151 * keymap.c (describe_vector): Remove parameters `indices' and
8152 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8153 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8154
f868cd8a
JB
8155 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8156
8157 * keyboard.c (timer_check): Remove parameter `do_it_now',
8158 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8159 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8160 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8161
8162 * keyboard.c (read_char):
8163 * w32menu.c (w32_menu_display_help):
8164 * xmenu.c (show_help_event, menu_help_callback):
8165 Adjust calls to `show_help_echo'.
8166
8167 * gtkutil.c (xg_maybe_add_timer):
8168 * keyboard.c (readable_events):
8169 * process.c (wait_reading_process_output):
8170 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8171
8172 * insdel.c (adjust_markers_gap_motion):
8173 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8174 (gap_left, gap_right): Don't call it.
8175
2ecf6fdb
CY
81762011-03-25 Chong Yidong <cyd@stupidchicken.com>
8177
8178 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8179 incurred during fontification.
8180
6b1f9ba4
JB
81812011-03-25 Juanma Barranquero <lekktu@gmail.com>
8182
8183 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8184 (DEFVAR_PER_BUFFER): Don't pass it.
8185
8186 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8187 (scrolling_window): Don't pass it.
8188
0f4a96b5
JB
81892011-03-25 Juanma Barranquero <lekktu@gmail.com>
8190
8191 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8192
8193 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8194 and `suffix'.
8195 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8196 of variables specific to SELinux and computation of `encoded_absname'.
8197
8198 * image.c (XPutPixel): Remove unused variable `height'.
8199
8200 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8201
8202 * unexw32.c (get_section_info): Remove unused variable `section'.
8203
8204 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8205 (system_process_attributes): Remove unused variable `sess'.
8206 (sys_read): Remove unused variable `err'.
8207
8208 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8209 (w32_wnd_proc): Remove unused variable `isdead'.
8210 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8211 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8212 (x_create_tip_frame): Remove unused variable `tem'.
8213
8214 * w32inevt.c (w32_console_read_socket):
8215 Remove unused variable `no_events'.
8216
8217 * w32term.c (x_draw_composite_glyph_string_foreground):
8218 Remove unused variable `width'.
8219
1149507c
JB
82202011-03-24 Juanma Barranquero <lekktu@gmail.com>
8221
8222 * w32term.c (x_set_glyph_string_clipping):
8223 Don't pass uninitialized region to CombineRgn.
8224
9c88f339
JB
82252011-03-23 Juanma Barranquero <lekktu@gmail.com>
8226
8227 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8228 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8229 (Fx_close_connection): Remove unused variable `i'.
8230
8231 * w32font.c (w32font_draw): Return number of glyphs.
8232 (w32font_open_internal): Remove unused variable `i'.
8233 (w32font_driver): Add missing initializer.
8234
8235 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8236 (fill_in_menu): Remove unused variable `items_added'.
8237
8238 * w32term.c (last_mouse_press_frame): Remove static global variable.
8239 (w32_clip_to_row): Remove unused variable `f'.
8240 (x_delete_terminal): Remove unused variable `i'.
8241
8242 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8243 (NOTHING): Remove unused static global variable.
8244 (uniscribe_check_otf): Remove unused variable `table'.
8245 (uniscribe_font_driver): Add missing initializers.
8246
dee091a3
JD
82472011-03-23 Julien Danjou <julien@danjou.info>
8248
8249 * term.c (Fsuspend_tty, Fresume_tty):
8250 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8251 * window.c (temp_output_buffer_show):
8252 * insdel.c (signal_before_change):
8253 * frame.c (Fhandle_switch_frame):
8254 * fileio.c (Fdo_auto_save):
8255 * emacs.c (Fkill_emacs):
8256 * editfns.c (save_excursion_restore):
8257 * cmds.c (internal_self_insert):
8258 * callint.c (Fcall_interactively):
8259 * buffer.c (Fkill_all_local_variables):
8260 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8261 Use Frun_hooks.
0f4a96b5 8262 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8263 unconditionally since it does the check itself.
dee091a3 8264
2c520ab5 82652011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8266
c9c49752
PE
8267 Fix more problems found by GCC 4.5.2's static checks.
8268
8abc3f12
PE
8269 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8270 the first time through the loop, since we know p0 < p1 then.
8271 This also avoids a gcc -Wstrict-overflow warning.
8272
a2d26660
PE
8273 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8274 leading to a memory leak, possible in functions like
8275 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8276 of objects (Bug#8318).
a2d26660 8277
916c72e9
PE
8278 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8279 that could (at least in theory) be that large.
8280
19ab8a18
PE
8281 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8282 This is less likely to overflow, and avoids undefined behavior if
8283 overflow does occur. All callers changed. Use strtoul to scan
8284 for the unsigned long integer.
b7cbbd6f
PE
8285 (pint2hrstr): Simplify and tune code slightly.
8286 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8287
f0641eff
PE
8288 * scroll.c (do_scrolling): Work around GCC bug 48228.
8289 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8290
7f650bb9
PE
8291 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8292 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8293 (validate_x_resource_name): Simplify count usage.
8294 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8295
37dd57d1
PE
8296 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8297 fail (Bug#8306).
81e56e61 8298
699979fc 8299 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8300
401bf9b4
PE
8301 * process.c (Fmake_network_process): Use socklen_t, not int,
8302 where POSIX says socklen_t is required in portable programs.
8303 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8304 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8305 (Fmake_network_process, server_accept_connection):
8306 (wait_reading_process_output, read_process_output):
8307 Likewise.
8308
b93aacde
PE
8309 * process.c: Rename or move locals to avoid shadowing.
8310 (list_processes_1, Fmake_network_process):
8311 (read_process_output_error_handler, exec_sentinel_error_handler):
8312 Rename or move locals.
4dc343ee 8313 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8314 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8315 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8316 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8317 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8318
af8a867c 8319 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8320 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8321 Include tparam.h instead, since it declares them.
af8a867c
PE
8322 * cm.h (PC): Remove extern decl; tparam.h now does this.
8323 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8324 * terminfo.c: Include tparam.h, to check interfaces.
8325 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8326 (tparam): Adjust signature to match interface in tparam.h;
8327 this removes some undefined behavior. Check that outstring and len
8328 are zero, which they always are with Emacs.
8329 * tparam.h (PC, BC, UP): New extern decls.
8330
0248044d 8331 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8332 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8333
8ff096c1 8334 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8335 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8336 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8337 (ftfont_list): Remove unused local.
49eaafba
PE
8338 (get_adstyle_property, ftfont_pattern_entity):
8339 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8340 Rename locals to avoid shadowing.
8ff096c1 8341
e2be39f6
PE
8342 * xfont.c (xfont_list_family): Mark var as initialized.
8343
c9735e30
PE
8344 * xml.c (make_dom): Now static.
8345
8f5201ae
PE
8346 * composite.c (composition_compute_stop_pos): Rename local to
8347 avoid shadowing.
b246f932
PE
8348 (composition_reseat_it): Remove unused locals.
8349 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8350 (composition_update_it): Mark var as initialized.
11b61122
PE
8351 (find_automatic_composition): Mark vars as initialized,
8352 with a FIXME (Bug#8290).
8f5201ae 8353
760fbc2c
PE
8354 character.h: Rename locals to avoid shadowing.
8355 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8356 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8357 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8358 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8359 to avoid shadowing.
8360
ff08eb85
PE
8361 * textprop.c (property_change_between_p): Remove; unused.
8362
fc7bf025
PE
8363 * intervals.c (interval_start_pos): Now static.
8364
235d7abc
PE
8365 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8366
44f230aa
SM
8367 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8368 Rename locals to avoid shadowing.
3e7d6594 8369
50060332
PE
8370 * sound.c (wav_play, au_play, Fplay_sound_internal):
8371 Fix pointer signedness.
d01f234b 8372 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8373 (wav_play): Initialize a variable to 0, to prevent undefined
8374 behavior (Bug#8278).
50060332 8375
c4fc4e30
PE
8376 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8377
918436ed
PE
8378 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8379
c939f91b
PE
8380 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8381 clobbering (Bug#8298).
b9c7f648
PE
8382 * sysdep.c (sys_subshell): Likewise.
8383 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8384
6bd8c144
PE
8385 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8386 This should get cleaned up, so that child_setup has the
8387 same signature on all platforms.
8388
7710357c 8389 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8390 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8391
c59da222
CY
83922011-03-22 Chong Yidong <cyd@stupidchicken.com>
8393
8394 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8395 not to be necessary, and produces flickering.
8396
66b87493
GM
83972011-03-20 Glenn Morris <rgm@gnu.org>
8398
8399 * config.in: Remove file.
8400
45b6f6d5
JB
84012011-03-20 Juanma Barranquero <lekktu@gmail.com>
8402
8403 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8404 are now in src/globals.h.
8405 (syms_of_minibuf): Remove spurious & from previous change.
8406
cd394be1 84072011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8408
8409 * minibuf.c (completing-read-function): New variable.
8410 (completing-read-default): Rename from completing-read.
8411 (completing-read): Call completing-read-function.
8412
b14e3e21
CY
84132011-03-19 Juanma Barranquero <lekktu@gmail.com>
8414
8415 * xfaces.c (Fx_load_color_file):
8416 Read color file from absolute filename (bug#8250).
8417
f2b726e6
JB
84182011-03-19 Juanma Barranquero <lekktu@gmail.com>
8419
8420 * makefile.w32-in: Update dependencies.
8421
09f6ff02
EZ
84222011-03-17 Eli Zaretskii <eliz@gnu.org>
8423
8424 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8425
29a6015a
PE
84262011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8427
a3a6c54e
PE
8428 Fix more problems found by GCC 4.5.2's static checks.
8429
b766f867
PE
8430 * process.c (make_serial_process_unwind, send_process_trap):
8431 (sigchld_handler): Now static.
8432
be02381c
PE
8433 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8434 That way, the code declares only the vars that it needs.
8435 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8436 * s/cygwin.h (PTY_ITERATION): Likewise.
8437 * s/darwin.h (PTY_ITERATION): Likewise.
8438 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8439
57048744
PE
8440 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8441 * process.c (allocate_pty): Don't declare stb unless it's needed.
8442
7914961c 8443 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8444 (CONSTANTLIM): Remove; unused.
8445 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8446 Define only if needed.
7914961c 8447
b3967b18
PE
8448 * unexelf.c (unexec): Name an expression,
8449 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8450 Use a different way to cause a compilation error if anyone uses
8451 n rather than nn, a way that does not involve shadowing.
73366a00 8452 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8453
29a6015a
PE
8454 * deps.mk (unexalpha.o): Remove; unused.
8455
43cfc33e 8456 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8457 * unexec.h: New file.
ce701a33
PE
8458 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8459 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8460 Depend on unexec.h.
8461 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8462 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8463 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8464 Change as necessary to match prototype in unexec.h.
ce701a33 8465
01f44d5a
PE
8466 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8467 shadowing.
4f63c6bb 8468 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8469
a6670b0b
PE
8470 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8471 Rename locals to avoid shadowing.
8472
cef2010d 8473 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8474 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8475
d4d7173a
PE
8476 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8477
f08b802a
PE
8478 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8479 warning when compiling print.c.
8480
3ddb0639
PE
8481 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8482 instead of using an uninitialized var.
5ad03b97 8483 (font_sort_entities): Mark var as initialized.
3ddb0639 8484
170a2692
PE
8485 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8486
e663c700
PE
8487 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8488 pointers to constants.
89bc529a 8489 (font_parse_fcname): Remove unused vars.
7b81e2d0 8490 (font_delete_unmatched): Now static.
ea838e10 8491 (font_get_spec): Remove; unused.
13a547c6
PE
8492 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8493 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8494 Rename or move locals to avoid shadowing.
e663c700 8495
2a80c887 8496 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8497 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8498
1384fa33 8499 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8500 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8501
8b2c52e9
PE
8502 * alloc.c (mark_backtrace): Move decl from here ...
8503 * lisp.h: ... to here, so that it can be checked.
8504
475545b5 8505 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8506 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8507 (lisp_indirect_variable): Name an expression,
8508 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8509 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8510
b1349114 8511 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8512 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8513 Use const pointer when appropriate.
b1349114 8514
a2928364
PE
8515 * lisp.h (get_system_name, get_operating_system_release):
8516 Move decls here, to check interfaces.
8517 * process.c (get_operating_system_release): Move decl to lisp.h.
8518 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8519 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8520 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8521 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8522 (Fformat_time_string, Fencode_time, Finsert_char):
8523 (Ftranslate_region_internal, Fformat):
8524 Rename or remove local vars to avoid shadowing.
9710023e 8525 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8526
a415e694
PE
8527 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8528 avoid shadowing.
8529
8ef4622d
PE
8530 * lisp.h (eassert): Check that the argument compiles, even if
8531 ENABLE_CHECKING is not defined.
8532
946f9a5b
PE
8533 * data.c (Findirect_variable): Name an expression, to avoid
8534 gcc -Wbad-function-cast warning.
112396d6 8535 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8536 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8537 (Fmake_variable_buffer_local, Fmake_local_variable):
8538 Mark variables as initialized.
52746918 8539 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8540
e5aab7e7 8541 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8542 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8543 Rename locals to avoid shadowing.
dff45157
PE
8544 (mark_stack): Move local variables into the #ifdef region where
8545 they're used.
7bc26fdb
PE
8546 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8547 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8548 needed otherwise.
8549 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8550 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8551 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8552
e5aab7e7
PE
8553 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8554 avoids undefined behavior in theory.
8555
4da60324
PE
8556 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8557
88043301
PE
8558 Use functions, not macros, for up- and down-casing (Bug#8254).
8559 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8560 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8561 to use the following functions instead of these macros.
8562 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8563 EMACS_INT, since callers assume the returned value fits in int.
8564 (upcase1): Likewise, for UPCASE_TABLE.
8565 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8566 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8567 the race-condition problem in the old DOWNCASE.
88043301 8568
19ed5445
PE
8569 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8570 Rename locals to avoid shadowing.
8571 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8572 (regex_compile, re_search_2, re_match_2_internal):
8573 Remove unused local vars.
952db0d7
PE
8574 (FREE_VAR): Rewrite so as not to use empty "else",
8575 which gcc can warn about.
da053e48 8576 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8577 (RETALLOC_IF): Define only if needed.
8578 (WORDCHAR_P): Likewise. This one is never needed, but is used
8579 only in a comment talking about a compiler bug, so put inside
8580 the #if 0 of that comment.
8581 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8582 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8583 Remove; unused.
19ed5445 8584
1f3561e4 8585 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8586 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8587 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8588
ded6f8f7
PE
8589 * search.c (simple_search): Remove unused var.
8590
dbd37a95
PE
8591 * dired.c (compile_pattern): Move decl from here ...
8592 * lisp.h: ... to here, so that it can be checked.
8593 (struct re_registers): New forward decl.
8594
7e47afad
PE
8595 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8596
85f24f61
PE
8597 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8598 All uses changed.
8599 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8600 Rename locals to avoid shadowing.
5671df8f 8601 (Fvertical_motion): Mark locals as initialized.
85f24f61 8602
181aa2be 8603 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8604 (casify_region): Mark local as initialized.
181aa2be 8605
930d429c
PE
8606 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8607
7082eac6
PE
8608 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8609 New macros, so that the caller can use some names other than
8610 gcpro1, gcpro2, etc.
8611 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8612 of the new macros.
8613 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8614 argument, for consistency with GCPRO2_VAR, etc: it is now the
8615 prefix of the variable, not the variable itself. All uses
8616 changed.
38b2c076
PE
8617 * dired.c (directory_files_internal, file_name_completion):
8618 Rename locals to avoid shadowing.
8619
15206ed9
PE
8620 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8621 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8622 dired.c's scmp function, had undefined behavior.
8623 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8624 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8625 * buffer.h: ... to here, because these macros use current_buffer,
8626 and the new implementation with inline functions needs to have
8627 current_buffer in scope now, rather than later when the macros
8628 are used.
8629 (downcase, upcase1): New static inline functions.
8630 (DOWNCASE, UPCASE1): Reimplement using these functions.
8631 This avoids undefined behavior in expressions like
8632 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8633 from race conditions in accessing the global variables
8634 case_temp1 and case_temp2.
8635 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8636 * lisp.h (case_temp1, case_temp2): Remove their decls.
8637 * character.h (ASCII_CHAR_P): Move from here ...
8638 * lisp.h: ... to here, so that the inline functions mentioned
8639 above can use them.
8640
4a6bea26
PE
8641 * dired.c (directory_files_internal_unwind): Now static.
8642
f14b7e14
PE
8643 * fileio.c (file_name_as_directory, directory_file_name):
8644 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8645 Now static.
2893f146
PE
8646 (file_name_as_directory): Use const pointers when appropriate.
8647 (Fexpand_file_name): Likewise. In particular, newdir might
8648 point at constant storage, so make it a const pointer.
fd4ead52 8649 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8650 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8651 signedness issues.
f839df0c
PE
8652 (Fset_file_times, Finsert_file_contents, auto_save_error):
8653 Rename locals to avoid shadowing.
f14b7e14 8654
5716756e 8655 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8656 (Ftry_completion, Fall_completions): Rename or remove locals
8657 to avoid shadowing.
5716756e 8658
b4c3046a
PE
8659 * marker.c (bytepos_to_charpos): Remove; unused.
8660
b45db522
PE
8661 * lisp.h (verify_bytepos, count_markers): New decls,
8662 so that gcc does not warn that these functions aren't declared.
8663
85876d07
PE
8664 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8665 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8666 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8667 (copy_text): Remove unused local var.
85876d07 8668
03d78a21 8669 * filelock.c (within_one_second): Now static.
b3dd38ab 8670 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8671
5df8f01b
PE
8672 * buffer.c (fix_overlays_before): Mark locals as initialized.
8673 (fix_start_end_in_overlays): Likewise. This function should be
8674 simplified by using pointers-to-pointers, but that's a different
8675 matter.
b1d876f1 8676 (switch_to_buffer_1): Now static.
8f54f30a
PE
8677 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8678 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8679
a70072c9 8680 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8681 Fix pointer signedness issue.
edced198
PE
8682 (sys_subshell): Mark local as volatile if checking for lint,
8683 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8684 (MAXPATHLEN): Define only if needed.
a70072c9 8685
a0977c44
PE
8686 * process.c (serial_open, serial_configure): Move decls from here ...
8687 * systty.h: ... to here, so that they can be checked.
8688
a884fdcc
PE
8689 * fns.c (get_random, seed_random): Move extern decls from here ...
8690 * lisp.h: ... to here, so that they can be checked.
8691
604efe86 8692 * sysdep.c (reset_io): Now static.
b8950c94 8693 (wait_for_termination_signal): Remove; unused.
604efe86 8694
38fc62d9
PE
8695 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8696 (copy_keymap_item, append_key, push_text_char_description):
8697 Now static.
1004a21a 8698 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8699 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8700 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8701 (describe_map_tree):
8702 Rename locals to avoid shadowing.
38fc62d9 8703
2f2650da
PE
8704 * keyboard.c: Declare functions static if they are not used elsewhere.
8705 (echo_char, echo_dash, cmd_error, top_level_2):
8706 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8707 (read_char, kbd_buffer_get_event, make_lispy_position):
8708 (make_lispy_event, make_lispy_movement, apply_modifiers):
8709 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8710 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8711 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8712 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8713 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8714
a053e86c 8715 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8716 (mark_kboards): Move decl here ...
8717 * alloc.c (mark_kboards): ... from here.
a053e86c 8718
4752793e
PE
8719 * lisp.h (force_auto_save_soon): New decl.
8720
74f10ca7 8721 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8722 (DEFINE_DUMMY_FUNCTION): New macro.
8723 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8724 Use it.
c03cd23f
PE
8725 (main): Add casts to avoid warnings
8726 if GCC considers string literals to be constants.
74f10ca7 8727
022e70d4
PE
8728 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8729
59d6fe83
PE
8730 * dbusbind.c: Pointer signedness fixes.
8731 (xd_signature, xd_append_arg, xd_initialize):
8732 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8733 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8734 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8735 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8736
78320123
PE
8737 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8738 if GCC considers string literals to be constants.
49cebcca 8739 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8740
35ac2a97
SM
87412011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8742
fb103ca9
SM
8743 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8744 (print_preprocess, print_object): New macro to fix last change.
8745
35ac2a97
SM
8746 * print.c (print_preprocess): Don't forget font objects.
8747
62973b41
JB
87482011-03-16 Juanma Barranquero <lekktu@gmail.com>
8749
8750 * emacs.c (USAGE3): Doc fixes.
8751
0e48bb22
AS
87522011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8753
8754 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8755 structure.
8756
7684e57b
JB
87572011-03-14 Juanma Barranquero <lekktu@gmail.com>
8758
8759 * lisp.h (VWindow_system, Qfile_name_history):
8760 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8761 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8762 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8763
8764 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8765 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8766
8767 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8768 * w32console.c (detect_input_pending, read_input_pending)
8769 (encode_terminal_code):
8770 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8771 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8772 (w32_system_caret_y, Qfile_name_history):
8773 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8774 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8775 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8776 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8777 * w32proc.c (Qlocal, report_file_error):
8778 * w32term.c (Vwindow_system, updating_frame):
8779 * w32uniscribe.c (initialized, uniscribe_font_driver):
8780 Remove unneeded extern declarations.
8781
2aa46d6c
CY
87822011-03-14 Chong Yidong <cyd@stupidchicken.com>
8783
c96bbc66 8784 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8785
cffc6f3b
CY
87862011-03-13 Chong Yidong <cyd@stupidchicken.com>
8787
8788 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8789 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8790 These macros can no longer be used for assignment.
8791
44f230aa
SM
8792 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8793 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8794 (record_buffer_markers, fetch_buffer_markers): New functions for
8795 recording and fetching special buffer markers.
8796 (set_buffer_internal_1, set_buffer_temp): Use them.
8797
8798 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8799
8800 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8801
8802 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8803 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8804
8805 * xdisp.c (hscroll_window_tree):
8806 (reconsider_clip_changes): Use PT instead of BUF_PT.
8807
d251f04b
EZ
88082011-03-13 Eli Zaretskii <eliz@gnu.org>
8809
8810 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8811 $(EMACS_ROOT)/lib/intprops.h.
8812
f0c77cd1
PE
88132011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8814
3eca4629
PE
8815 Fix more problems found by GCC 4.5.2's static checks.
8816
7c86ee98
PE
8817 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8818 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8819 (xg_free_frame_widgets): Make it clear that a local variable is
8820 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8821 (gdk_window_get_screen): Make it clear that this macro is needed
8822 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8823 (int_gtk_range_get_value): New function, which avoids a diagnostic
8824 from gcc -Wbad-function-cast.
8825 (xg_set_toolkit_scroll_bar_thumb): Use it.
8826 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8827 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8828 (get_utf8_string, xg_get_file_with_chooser):
8829 Rename locals to avoid shadowing.
8830 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8831
41729b81
PE
8832 * xgselect.c (xg_select): Remove unused var.
8833
f0c77cd1
PE
8834 * image.c (four_corners_best): Mark locals as initialized.
8835 (gif_load): Initialize transparent_p to zero (Bug#8238).
8836 Mark another local as initialized.
ec6cf4c6 8837 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8838
ce0ad53d 8839 * image.c (clear_image_cache): Now static.
d5d5a617 8840 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8841 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8842 (x_edge_detection): Remove unnecessary cast that
8843 gcc -Wbad-function-cast diagnoses.
2037898d 8844 (gif_load): Fix pointer signedness.
6ae141d6
PE
8845 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8846 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8847
33383987 88482011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8849
d32df629
PE
8850 Improve quality of tests for time stamp overflow.
8851 For example, without this patch (encode-time 0 0 0 1 1
8852 1152921504606846976) returns the obviously-bogus value (-948597
8853 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8854 reports time overflow. See
8855 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8856 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8857 * editfns.c: Include limits.h and intprops.h.
8858 (TIME_T_MIN, TIME_T_MAX): New macros.
8859 (time_overflow): Move earlier, to before first use.
8860 (hi_time, lo_time): New functions, for an accurate test for
8861 out-of-range times.
8862 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8863 (Fget_internal_run_time): Don't assume time_t fits in int.
8864 (make_time): Use list2 instead of Fcons twice.
8865 (Fdecode_time): More accurate test for out-of-range times.
8866 (check_tm_member): New function.
8867 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8868 (lisp_time_argument): Don't rely on undefined left-shift and
8869 right-shift behavior when checking for time stamp overflow.
8be6f318 8870
fe31d94c
PE
8871 * editfns.c (time_overflow): New function, refactoring common code.
8872 (Fformat_time_string, Fdecode_time, Fencode_time):
8873 (Fcurrent_time_string): Use it.
8874
8be6f318
PE
8875 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8876 * dired.c (make_time): Move to ...
8877 * editfns.c (make_time): ... here.
8878 * systime.h: Note the move.
8879
09d9db2c 88802011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8881
126bc0dc
YM
8882 * fringe.c (update_window_fringes): Remove unused variables.
8883
c47cbdfd
YM
8884 * unexmacosx.c (copy_data_segment): Also copy __got section.
8885 (Bug#8223)
8886
7ac80be9
EZ
88872011-03-12 Eli Zaretskii <eliz@gnu.org>
8888
c96bbc66 8889 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8890 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8891 Constify `char *' arguments and their references according to
8892 prototypes in tparam.h.
8893
ecb0f94d 8894 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8895
7ac80be9
EZ
8896 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8897 Adapt all references accordingly.
8898
8899 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8900
ef1fd07e
TT
89012011-03-11 Tom Tromey <tromey@redhat.com>
8902
8903 * buffer.c (syms_of_buffer): Remove obsolete comment.
8904
7ef4b50c
EZ
89052011-03-11 Eli Zaretskii <eliz@gnu.org>
8906
8907 * termhooks.h (encode_terminal_code): Declare prototype.
8908
8909 * msdos.c (encode_terminal_code): Don't declare prototype.
8910
8911 * term.c (encode_terminal_code): Now external again, used by
8912 w32console.c and msdos.c.
8913
44f230aa
SM
8914 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8915 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8916
4b1ec863 89172011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8918
1714f52b 8919 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8920
4b1ec863
PE
8921 * fringe.c (update_window_fringes): Mark locals as initialized
8922 (Bug#8227).
8923 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8924
524c7aa6
PE
8925 * alloc.c (mark_fringe_data): Move decl from here ...
8926 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8927 to check its interface.
8928 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8929
a5c0af81 8930 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8931 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8932 (fontset_font): Mark local as initialized.
a9a06e0b 8933 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8934
b4716021
PE
8935 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8936
811e9bac 8937 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8938 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8939 (x_own_selection, Fx_disown_selection_internal): Rename locals
8940 to avoid shadowing.
8941 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8942
7e3ab302
PE
8943 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8944 so that the caller can use some name other than gcpro1.
8945 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8946 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8947 (Fx_backspace_delete_keys_p):
8948 Use them to avoid shadowing, and rename vars to avoid shadowing.
8949 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8950 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8951 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8952 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8953 Remove unused locals.
7e3ab302
PE
8954 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8955 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8956 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8957 macros.
f78faa98 8958
e2b13473
PE
8959 * xterm.h (x_mouse_leave): New decl.
8960
77f23912
PE
8961 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8962 Remove unused functions.
cdf4ba58
PE
8963 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8964 (x_calc_absolute_position): Now static.
7411c686 8965 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8966 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8967 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8968 unless they are used.
38d0b34a
PE
8969 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8970 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8971 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8972 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8973 (x_error_catcher, x_connection_closed, x_error_handler):
8974 (x_error_quitter, xembed_send_message, x_iconify_frame):
8975 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8976 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8977 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8978
44f230aa
SM
8979 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8980 Rename or move locals to avoid shadowing.
6b463e58 8981 (tty_defined_color, merge_face_heights): Now static.
5967d051 8982 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8983 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8984 does not deduce is never used uninitialized.
73719eba
PE
8985 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8986 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8987
426994c3 8988 * terminal.c (store_terminal_param): Now static.
5489860b 8989
032f1620 8990 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8991 (set_frame_menubar): Remove unused local.
d4323972 8992 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8993 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8994 since they might point to immutable storage.
281585b0
PE
8995 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8996 since it's unused otherwise.
032f1620 8997
367c19e5 8998 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8999 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9000 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9001 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9002 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9003 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9004 does not deduce are never used uninitialized.
70739cbe 9005
07b48fa9
PE
9006 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9007
8868a238 9008 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9009 * window.c (window_loop, size_window):
9010 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9011
7e5cf297 9012 * window.c (display_buffer): Now static.
d6550a9f
PE
9013 (size_window): Mark variables that gcc -Wuninitialized
9014 does not deduce are never used uninitialized.
a586633d
PE
9015 * window.h (check_all_windows): New decl, to forestall
9016 gcc -Wmissing-prototypes diagnostic.
5b555da1 9017 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9018
f6095868
PE
9019 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9020 shadowing.
9021 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9022 Include <limits.h>.
9023 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9024 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9025 (load_charset_map): Mark variables that gcc -Wuninitialized
9026 does not deduce are never used uninitialized.
53df7c11 9027 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9028
f38b440c
PE
9029 * coding.c (coding_set_source, coding_set_destination):
9030 Use "else { /* comment */ }" rather than "else /* comment */;"
9031 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9032 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9033 a block, when the outer 'i' will do.
9034 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9035 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9036 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9037 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9038 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9039 Rename locals to avoid shadowing.
9040 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9041 * coding.c (emacs_mule_char, encode_invocation_designation):
9042 Now static, since they're not used elsewhere.
413bb2db 9043 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9044 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9045 (decode_coding_emacs_mule): Mark variables that gcc
9046 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9047 (detect_coding_iso_2022): Initialize a local variable that might
9048 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9049 this initialization is needed. (Bug#8211)
5f58e762
PE
9050 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9051 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9052 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9053 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9054 Remove unused macros.
f38b440c 9055
232b38b9 9056 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9057 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9058 * character.c (string_count_byte8): Likewise.
232b38b9 9059
fb90da1b
PE
9060 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9061 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9062
fb93dbc2
PE
9063 * chartab.c (copy_sub_char_table): Now static, since it's not used
9064 elsewhere.
5c156ace
PE
9065 (sub_char_table_ref_and_range, char_table_ref_and_range):
9066 Rename locals to avoid shadowing.
bbcd0949 9067 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9068
7d3b3862 9069 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9070 (BIDI_BOB): Remove unused macro.
7d3b3862 9071
6be7d3da
PE
9072 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9073 deduce are never used uninitialized.
c2ed9c8b 9074 * term.c (encode_terminal_code): Likewise.
6be7d3da 9075
75f8807f 9076 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9077
50938595
PE
9078 * tparam.h: New file.
9079 * term.c, tparam.h: Include it.
9080 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9081 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9082 Move these decls to tparam.h, and make them agree with what
9083 is actually in tparam.c. The previous trick of using incompatible
9084 decls in different modules does not conform to the C standard.
9085 All callers of tparam changed to use tparam's actual API.
9086 * tparam.c (tparam1, tparam, tgoto):
9087 Use const pointers where appropriate.
9088
fbceeba2
PE
9089 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9090 * cm.h (struct cm): Likewise.
9091 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9092 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9093 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9094 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9095 (turn_on_face, init_tty): Likewise.
9096 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9097
7f3f1250
PE
9098 * term.c (term_mouse_position): Rename local to avoid shadowing.
9099
e6ca6543
PE
9100 * alloc.c (mark_ttys): Move decl from here ...
9101 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9102
c40f8d15
AS
91032011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9104
9105 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9106
cfe0661d
JB
91072011-03-09 Juanma Barranquero <lekktu@gmail.com>
9108
9109 * search.c (compile_pattern_1): Remove argument regp, unused since
9110 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9111 (compile_pattern): Don't pass it.
9112
0afb4571
J
91132011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9114
9115 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9116 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9117 for ! HAVE_GTK3.
9118 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9119
9120 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9121
9122 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9123 gdk_window_get_screen, gdk_window_get_geometry,
9124 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9125 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9126 (xg_get_pixbuf_from_pixmap): New function.
9127 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9128 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9129 Call xg_get_pixbuf_from_pixmap instead of
9130 gdk_pixbuf_get_from_drawable.
9131 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9132 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9133 (xg_check_special_colors): Use GtkStyleContext and its functions
9134 for HAVE_GTK3.
9135 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9136 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9137 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9138 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9139 Call gtk_widget_get_preferred_size.
0afb4571
J
9140 (xg_frame_resized): gdk_window_get_geometry only takes 5
9141 parameters.
44f230aa
SM
9142 (xg_win_to_widget, xg_event_is_for_menubar):
9143 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9144 (xg_set_widget_bg): New function.
9145 (delete_cb): New function.
895009e1 9146 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9147 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9148 (xg_set_background_color): Call xg_set_widget_bg.
9149 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9150 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9151 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9152 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9153 if ! HAVE_GTK3.
9154 (update_frame_tool_bar): Call gtk_widget_hide.
9155 (xg_initialize): Use GDK_KEY_g.
9156
9157 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9158 if ! HAVE_GTK3
9159 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9160
9161 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9162 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9163 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9164
1c2cc4ef
JB
91652011-03-08 Juanma Barranquero <lekktu@gmail.com>
9166
9167 * w32xfns.c (select_palette): Check success of RealizePalette against
9168 GDI_ERROR, not zero.
9169
33383987 9170See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9171
9172;; Local Variables:
9173;; coding: utf-8
aac0c6e3
MR
9174;; End:
9175
acaf905b 9176 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9177
9178 This file is part of GNU Emacs.
9179
9180 GNU Emacs is free software: you can redistribute it and/or modify
9181 it under the terms of the GNU General Public License as published by
9182 the Free Software Foundation, either version 3 of the License, or
9183 (at your option) any later version.
9184
9185 GNU Emacs is distributed in the hope that it will be useful,
9186 but WITHOUT ANY WARRANTY; without even the implied warranty of
9187 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9188 GNU General Public License for more details.
9189
9190 You should have received a copy of the GNU General Public License
9191 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.