* buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
28177add
PE
12011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4
e69dafad
PE
52011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6
a7af7fde 7 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 8
b1c46f02
PE
9 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11
e69dafad
PE
12 * fileio.c: Don't assume EMACS_INT fits in off_t.
13 (emacs_lseek): New static function.
14 (Finsert_file_contents, Fwrite_region): Use it.
15 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
16
566684ea
PE
17 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
18
e6966cd6
PE
19 * fns.c: Don't overflow int when computing a list length.
20 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
21 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
22 truncation on 64-bit hosts. Check for QUIT every
23 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
24 faster and is responsive enough.
25 (Flength): Report an error instead of overflowing an integer.
26 (Fsafe_length): Return a float if the value is not representable
27 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 28 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 29 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 30
dd0b0efb
PE
31 * alloc.c: Check that resized vectors' lengths fit in fixnums.
32 (header_size, word_size): New constants.
33 (allocate_vectorlike): Don't check size overflow here.
34 (allocate_vector): Check it here instead, since this is the only
35 caller of allocate_vectorlike that could cause overflow.
36 Check that the new vector's length is representable as a fixnum.
37
86fe5cfe
PE
38 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
39 The previous code was bogus. For example, next_almost_prime (32)
40 returned 39, which is undesirable as it is a multiple of 3; and
41 next_almost_prime (24) returned 25, which is a multiple of 5 so
42 why was the code bothering to check for multiples of 7?
43
80e88859
PE
44 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
45
4a2f0ad6
PE
46 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
47
f66c7cf8
PE
48 Variadic C functions now count arguments with ptrdiff_t.
49 This partly undoes my 2011-03-30 change, which replaced int with size_t.
50 Back then I didn't know that the Emacs coding style prefers signed int.
51 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
52 were being counted with int, which may truncate counts on 64-bit
53 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
54 * lisp.h (struct Lisp_Subr.function.aMANY)
55 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
56 Arg counts are now ptrdiff_t, not size_t.
57 All variadic functions and their callers changed accordingly.
58 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
59 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
60 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
61 * callint.c (Fcall_interactively): Check arg count for overflow,
62 to avoid potential buffer overrun. Use signed char, not 'int',
63 for 'varies' array, so that we needn't bother to check its size
64 calculation for overflow.
65 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
66 * eval.c (apply_lambda):
67 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
68 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
69 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
70
a1759b76
PE
71 * callint.c (Fcall_interactively): Don't use index var as event count.
72
d96be9fc
PE
73 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
74 * mem-limits.h (SIZE): Remove; no longer used.
75
a690a978 76 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 77
578c21e6
PE
78 Remove unnecessary casts.
79 * xterm.c (x_term_init):
80 * xfns.c (x_set_border_pixel):
81 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
82 These aren't needed now that we assume ANSI C.
83
96f53c6c
PE
84 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
85 It's more likely to cause problems (due to unsigned overflow)
86 than to cure them.
87
83c77d31
PE
88 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
89
ee2079f1
PE
90 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
91
6da65536
PE
92 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
93
7147c4a4
PE
94 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
95
193e32d9
PE
96 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
97
e5533da6
PE
98 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
99
9910e595
PE
100 GLYPH_CODE_FACE returns EMACS_INT, not int.
101 * dispextern.h (merge_faces):
102 * xfaces.c (merge_faces):
01103c44
PE
103 * xdisp.c (get_next_display_element, next_element_from_display_vector):
104 Don't assume EMACS_INT fits in int.
9910e595 105
2638320e
PE
106 * character.h (CHAR_VALID_P): Remove unused parameter.
107 * fontset.c, lisp.h, xdisp.c: All uses changed.
108
045eb8d9
PE
109 * editfns.c (Ftranslate_region_internal): Omit redundant test.
110
c1f134b5
PE
111 * fns.c (concat): Minor tuning based on overflow analysis.
112 This doesn't fix any bugs. Use int to hold character, instead
113 of constantly refetching from Emacs object. Use XFASTINT, not
114 XINT, for value known to be a character. Don't bother comparing
115 a single byte to 0400, as it's always less.
116
395fcb93 117 * floatfns.c (Fexpt):
327eeec8
PE
118 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
119
abbd3d23
PE
120 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
121 for characters.
122
684a03ef
PE
123 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
124
0fed43f3
PE
125 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
126 Without this fix, on a 64-bit host (aset S 0 4294967386) would
127 incorrectly succeed when S was a string, because 4294967386 was
128 truncated before it was used.
129
8fd02eb7
PE
130 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
131 Otherwise, an out-of-range integer could cause undefined behavior
132 on a 64-bit host.
133
f8c86b69
PE
134 * composite.c: Use int, not EMACS_INT, for characters.
135 (fill_gstring_body, composition_compute_stop_pos): Use int, not
136 EMACS_INT, for values that are known to be in character range.
137 This doesn't fix any bugs but is the usual style inside Emacs and
138 may generate better code on 32-bit machines.
139
34206dd2
PE
140 Make sure a 64-bit char is never passed to ENCODE_CHAR.
141 This is for reasons similar to the recent CHAR_STRING fix.
142 * charset.c (Fencode_char): Check that character arg is actually
143 a character. Pass an int to ENCODE_CHAR.
144 * charset.h (ENCODE_CHAR): Verify that the character argument is no
145 wider than 'int', as a compile-time check to prevent future regressions
146 in this area.
147
c5958d4c 148 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
149
150 Make sure a 64-bit char is never passed to CHAR_STRING.
151 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
152 by silently ignoring the top 32 bits, allowing some values
153 that were far too large to be valid characters.
154 * character.h: Include <verify.h>.
155 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
156 arguments are no wider than unsigned, as a compile-time check
157 to prevent future regressions in this area.
158 * data.c (Faset):
01103c44 159 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
160 (Fsubst_char_in_region):
161 * fns.c (concat):
162 * xdisp.c (decode_mode_spec_coding):
163 Adjust to CHAR_STRING's new requirement.
164 * editfns.c (Finsert_char, Fsubst_char_in_region):
165 * fns.c (concat): Check that character args are actually
166 characters. Without this test, these functions did the wrong
167 thing with wildly out-of-range values on 64-bit hosts.
168
d37ca623
PE
169 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
170 These casts should not be needed on 32-bit hosts, either.
171 * keyboard.c (read_char):
172 * lread.c (Fload): Remove casts to unsigned.
173
ea204efb
PE
174 * lisp.h (UNSIGNED_CMP): New macro.
175 This fixes comparison bugs on 64-bit hosts.
176 (ASCII_CHAR_P): Use it.
177 * casefiddle.c (casify_object):
01103c44 178 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
179 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
180 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
181 * dispextern.h (FACE_FROM_ID):
182 * keyboard.c (read_char): Use UNSIGNED_CMP.
183
41cb286c
PE
184 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
185 not to EMACS_INT, to avoid GCC warning.
186
4a1b9832
PE
187 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
188
55daad71
PE
189 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
190 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
191 isn't needed on 32-bit machines.
8f95c75c 192
01103c44
PE
193 * buffer.c (Fgenerate_new_buffer_name):
194 Use EMACS_INT for count, not int.
0ceccced 195 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
196
197 * data.c (Qcompiled_function): Now static.
198
c6f072e7
PE
199 * window.c (window_body_lines): Now static.
200
20ce5912
PE
201 * image.c (gif_load): Rename local to avoid shadowing.
202
9c4c5f81
PE
203 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
204 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
205 * alloc.c (make_save_value): Integer argument is now of type
206 ptrdiff_t, not int.
207 (mark_object): Use ptrdiff_t, not int.
208 * lisp.h (pD): New macro.
209 * print.c (print_object): Use it.
210
c0c5c8ae
PE
211 * alloc.c: Use EMACS_INT, not int, to count objects.
212 (total_conses, total_markers, total_symbols, total_vector_size)
213 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
214 (total_free_floats, total_floats, total_free_intervals)
215 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
216 Now EMACS_INT, not int. All uses changed.
217 (Fgarbage_collect): Compute overall total using a double, so that
218 integer overflow is less likely to be a problem. Check for overflow
219 when converting back to an integer.
5a25e253
PE
220 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
221 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
222 These were 'int' variables that could overflow on 64-bit hosts;
223 they were never used, so remove them instead of repairing them.
211a0b2a 224 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
225 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
226 Previously, this ceilinged at INT_MAX, but that doesn't work on
227 64-bit machines.
e46bb31a 228 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 229
c78baabf 230 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 231 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
232 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
233 when a (possibly-narrower) signed value would do just as well.
234 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 235
c9d624c6
PE
236 * alloc.c: Catch some string size overflows that we were missing.
237 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
238 for convenience in STRING_BYTES_MAX.
239 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
240 The definition here is exact; the one in lisp.h was approximate.
241 (allocate_string_data): Check for string overflow. This catches
242 some instances we weren't catching before. Also, it catches
243 size_t overflow on (unusual) hosts where SIZE_MAX <= min
244 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
245 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 246
c9d624c6
PE
247 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
248 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
249 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
250
353032ce
PE
251 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
252
2bccce07
PE
253 * alloc.c (Fmake_string): Check for out-of-range init.
254
0ac30604
SM
2552011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
256
257 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
258
c195f2de
JD
2592011-06-14 Jan Djärv <jan.h.d@swipnet.se>
260
261 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
262 xg_get_default_scrollbar_width.
263
264 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
265 (int_gtk_range_get_value): Move to the scroll bar part of the file.
266 (style_changed_cb): Call update_theme_scrollbar_width and call
267 x_set_scroll_bar_default_width and xg_frame_set_char_size for
268 all frames (Bug#8505).
269 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
270 Call gtk_window_set_resizable if HAVE_GTK3.
271 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
272 and height if HAVE_GTK3 (Bug#8505).
273 (scroll_bar_width_for_theme): New variable.
274 (update_theme_scrollbar_width): New function.
275 (xg_get_default_scrollbar_width): Move code to
276 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
277 (xg_initialize): Call update_theme_scrollbar_width.
278
279 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
280
281 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
282
e10ac9f1
MR
2832011-06-12 Martin Rudalics <rudalics@gmx.at>
284
285 * frame.c (make_frame): Call other_buffer_safely instead of
286 other_buffer.
287
288 * window.c (temp_output_buffer_show): Call display_buffer with
289 second argument Vtemp_buffer_show_specifiers and reset latter
290 immediately after the call.
291 (Vtemp_buffer_show_specifiers): New variable.
292 (auto_window_vscroll_p, next_screen_context_lines)
293 (Vscroll_preserve_screen_position): Remove leading asterisks from
294 doc-strings.
295
2d3c217e 2962011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 297
7b7f97e8 298 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
299 * buffer.c (Qclone_number): Remove for now, as it's unused.
300 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
301 (record_buffer): Remove unused local.
302 * frame.c (other_visible_frames, frame_buffer_list): Now static.
303 (set_frame_buffer_list): Remove; unused.
304 * frame.h (other_visible_frames): Remove decl.
305 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
306 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
307 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
308 if HAVE_GPM.
309 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
310 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
311 Define only if HAVE_GPM.
312 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
313 (update_hints_inhibit): Remove; never set. All uses removed.
314 * widgetprv.h (emacsFrameClassRec): Remove decl.
315 * window.c (delete_deletable_window): Now returns void, since it
316 wasn't returning anything.
317 (compare_window_configurations): Remove unused locals.
318 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
319 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
320 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
321 the same widths as pointers. This follows up on the 2011-05-06 patch.
322 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
323 * xterm.h: Likewise.
324 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
325
1384b89e
JB
3262011-06-12 Juanma Barranquero <lekktu@gmail.com>
327
328 * makefile.w32-in: Update dependencies.
329 (LISP_H): Add lib/intprops.h.
330
1100a63c
CY
3312011-06-11 Chong Yidong <cyd@stupidchicken.com>
332
333 * image.c (gif_load): Add animation frame delay to the metadata.
334 (syms_of_image): Use DEFSYM. New symbol `delay'.
335
6198ccd0
MR
3362011-06-11 Martin Rudalics <rudalics@gmx.at>
337
338 * window.c (delete_deletable_window): Re-add.
339 (Fset_window_configuration): Rewrite to handle dead buffers and
340 consequently deletable windows.
341 (window_tree, Fwindow_tree): Remove. Supply functionality in
342 window.el.
343 (compare_window_configurations): Simplify code.
344
b6e3633c
AS
3452011-06-11 Andreas Schwab <schwab@linux-m68k.org>
346
1ab0dee5
AS
347 * image.c (imagemagick_load_image): Fix type mismatch.
348 (Fimagemagick_types): Likewise.
349
b6e3633c
AS
350 * window.h (replace_buffer_in_windows): Declare.
351
9397e56f
MR
3522011-06-11 Martin Rudalics <rudalics@gmx.at>
353
354 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
355 Qclone_number. Remove external declaration of Qdelete_window.
356 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
357 code.
358 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
359 Qbuffer_list_update_hook if allowed.
360 (Fother_buffer): Rewrite doc-string. Major rewrite for new
361 buffer list implementation.
362 (other_buffer_safely): New function.
363 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
364 calls to replace_buffer_in_windows and
365 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
366 if allowed.
367 (record_buffer): Inhibit quitting and rewrite using quittable
368 functions. Run Qbuffer_list_update_hook if allowed.
369 (Frecord_buffer, Funrecord_buffer): New functions.
370 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
371 switch-to-buffer to window.el.
372 (bury-buffer): Move to window.el.
373 (Vbuffer_list_update_hook): New variable.
374
375 * lisp.h (other_buffer_safely): Add prototype in buffer.c
376 section.
377
378 * window.h (resize_frame_windows): Move up in code.
379 (Fwindow_frame): Remove EXFUN.
380 (replace_buffer_in_all_windows): Remove prototype.
381 (replace_buffer_in_windows_safely): Add prototype.
382
383 * window.c: Declare Qdelete_window static again. Move down
384 declaration of select_count.
385 (Fnext_window, Fprevious_window): Rewrite doc-strings.
386 (Fother_window): Move to window.el.
387 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
388 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
389 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
390 window.el.
391 (replace_buffer_in_windows): Implement by calling
392 Qreplace_buffer_in_windows.
393 (replace_buffer_in_all_windows): Remove with some functionality
394 moved into replace_buffer_in_windows_safely.
395 (replace_buffer_in_windows_safely): New function.
396 (select_window_norecord, select_frame_norecord): Move in front
397 of run_window_configuration_change_hook. Remove now obsolete
398 declarations.
399 (Fset_window_buffer): Rewrite doc-string. Call
400 Qrecord_window_buffer.
401 (keys_of_window): Move binding for other-window to window.el.
402
b50691aa
CY
4032011-06-11 Chong Yidong <cyd@stupidchicken.com>
404
405 * dispextern.h (struct image): Replace data member, whose int_val
406 and ptr_val fields were not used by anything, with a single
407 lisp_val object.
408
409 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
410 (gif_clear_image, gif_load, imagemagick_load_image)
411 (gs_clear_image, gs_load): Callers changed.
412
3f754b86
PE
4132011-06-10 Paul Eggert <eggert@cs.ucla.edu>
414
cca69397
PE
415 * buffer.h: Include <time.h>, for time_t.
416 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
417
109e28d0
PE
418 Fix minor problems found by static checking.
419
60737f02
PE
420 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
421
4b66faf3
PE
422 Make identifiers static if they are not used in other modules.
423 * data.c (Qcompiled_function, Qframe, Qvector):
424 * image.c (QimageMagick, Qsvg):
425 * minibuf.c (Qmetadata):
426 * window.c (resize_window_check, resize_root_window): Now static.
427 * window.h (resize_window_check, resize_root_window): Remove decls.
428
109e28d0
PE
429 * window.c (window_deletion_count, delete_deletable_window):
430 Remove; unused.
46a4ce9e
PE
431 (window_body_lines): Now static.
432 (Fdelete_other_windows_internal): Mark vars as initialized.
433 Make sure 'resize_failed' is initialized.
434 (run_window_configuration_change_hook): Rename local to avoid shadowing.
435 (resize_window_apply): Remove unused local.
436 * window.h (delete_deletable_window): Remove decl.
437
109e28d0 438 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
439 (imagemagick_load_image): Fix pointer signedness problem by changing
440 last arg from unsigned char * to char *. All uses changed.
441 Also, fix a local for similar reasons.
442 Remove unused locals. Remove locals to avoid shadowing.
443 (fn_rsvg_handle_free): Remove; unused.
444 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 445 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 446
3f754b86
PE
447 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
448
2547adb1
CY
4492011-06-10 Chong Yidong <cyd@stupidchicken.com>
450
451 * image.c (gif_load): Fix omitted cast error introduced by
452 2011-06-06 change.
453
2c8e37d4
MR
4542011-06-10 Martin Rudalics <rudalics@gmx.at>
455
456 * window.h (resize_proportionally, orig_total_lines)
457 (orig_top_line): Remove from window structure.
458 (set_window_height, set_window_width, change_window_heights)
459 (Fdelete_window): Remove prototypes.
460 (resize_frame_windows): Remove duplicate declaration.
461
440a42e3
EZ
4622011-06-10 Eli Zaretskii <eliz@gnu.org>
463
464 * window.h (resize_frame_windows, resize_window_check)
465 (delete_deletable_window, resize_root_window)
466 (resize_frame_windows): Declare prototypes.
467
468 * window.c (resize_window_apply): Make definition be "static" to
469 match the prototype.
470
562dd5e9
MR
4712011-06-10 Martin Rudalics <rudalics@gmx.at>
472
473 * window.c: Remove declarations of Qwindow_size_fixed,
474 window_min_size_1, window_min_size_2, window_min_size,
475 size_window, window_fixed_size_p, enlarge_window, delete_window.
476 Remove static from declaration of Qdelete_window, it's
477 temporarily needed by Fbury_buffer.
478 (replace_window): Don't assign orig_top_line and
479 orig_total_lines.
480 (Fdelete_window, delete_window): Remove. Window deletion is
481 handled by window.el.
482 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
483 Fdelete_window calls with calls to Qdelete_window.
484 (Fdelete_other_windows): Remove. Deleting other windows is
485 handled by window.el.
486 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
487 handled in window.el.
488 (window_min_size_2, window_min_size_1, window_min_size): Remove.
489 Window minimum sizes are handled in window.el.
490 (shrink_windows, size_window, set_window_height)
491 (set_window_width, change_window_heights, window_height)
492 (window_width, CURBEG, CURSIZE, enlarge_window)
493 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
494 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
495 handled in window.el.
496 (make_dummy_parent): Rename to make_parent_window and give it a
497 second argument horflag.
498 (make_window): Don't set resize_proportionally any more.
499 (Fsplit_window): Remove. Windows are split in window.el.
500 (save_restore_action, save_restore_orig_size)
501 (shrink_window_lowest_first, save_restore_orig_size): Remove.
502 Resize mini windows in window.el.
503 (grow_mini_window, shrink_mini_window): Implement by calling
504 Qresize_root_window_vertically, resize_window_check and
505 resize_window_apply.
506 (saved_window, Fset_window_configuration, save_window_save): Do
507 not handle orig_top_line, orig_total_lines, and
508 resize_proportionally.
509 (window_min_height, window_min_width): Move to window.el.
510 (keys_of_window): Move bindings for delete-other-windows,
511 split-window, delete-window and enlarge-window to window.el.
512
513 * buffer.c: Temporarily extern Qdelete_window.
514 (Fbury_buffer): Temporarily call Qdelete_window instead of
515 Fdelete_window (Fbury_buffer will move to window.el soon).
516
517 * frame.c (set_menu_bar_lines_1): Remove code handling
518 orig_top_line and orig_total_lines.
519
520 * dispnew.c (adjust_frame_glyphs_initially): Don't use
521 set_window_height but set heights directly.
522 (change_frame_size_1): Use resize_frame_windows.
523
524 * xdisp.c (init_xdisp): Don't use set_window_height but set
525 heights directly.
526
527 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
528 resize_frame_windows instead of change_window_heights and run
529 run_window_configuration_change_hook.
530
531 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
532 instead of change_window_heights and run
533 run_window_configuration_change_hook.
534
1a13852e
MR
5352011-06-09 Martin Rudalics <rudalics@gmx.at>
536
537 * window.c (replace_window): Rename second argument REPLACEMENT to
538 NEW. New third argument SETFLAG. Rewrite.
539 (delete_window, make_dummy_parent): Call replace_window with
540 third argument 1.
541 (window_list_1): Move down in code.
542 (run_window_configuration_change_hook): Move set_buffer part
543 before select_frame_norecord part in order to unwind correctly.
544 Rename count1 to count.
545 (recombine_windows, delete_deletable_window, resize_root_window)
546 (Fdelete_other_windows_internal)
547 (Frun_window_configuration_change_hook, make_parent_window)
548 (resize_window_check, resize_window_apply, Fresize_window_apply)
549 (resize_frame_windows, Fsplit_window_internal)
550 (Fdelete_window_internal, Fresize_mini_window_internal): New
551 functions.
552 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
553
f3d1777e
MR
5542011-06-08 Martin Rudalics <rudalics@gmx.at>
555
496e208e
MR
556 * window.h (window): Add some new members to window structure -
557 normal_lines, normal_cols, new_total, new_normal, clone_number,
558 splits, nest, prev_buffers, next_buffers.
559 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 560 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 561
f3d1777e
MR
562 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
563 Remove.
496e208e
MR
564 (make_dummy_parent): Set new members of windows structure.
565 (make_window): Move down in code. Handle new members of window
566 structure.
567 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
568 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
569 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
570 (Fset_window_prev_buffers, Fwindow_next_buffers)
571 (Fset_window_next_buffers, Fset_window_clone_number): New
572 functions.
573 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
574 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
575 Doc-string fixes.
576 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
577 Argument WINDOW can be now internal window too.
578 (Fwindow_use_time): Move up in code.
579 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
580 Rewrite doc-string.
581 (Fset_window_configuration, saved_window)
582 (Fcurrent_window_configuration, save_window_save): Handle new
583 members of window structure.
b9e809c2
MR
584 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
585 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
586 (syms_of_window): New Lisp objects Qrecord_window_buffer,
587 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
588 Qget_mru_window, Qresize_root_window,
589 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
590 Qauto_buffer_name; staticpro them.
f3d1777e 591
abde8f8c
MR
5922011-06-07 Martin Rudalics <rudalics@gmx.at>
593
594 * window.c (Fwindow_total_size, Fwindow_left_column)
595 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
596 (Fwindow_list_1): New functions.
597 (window_box_text_cols): Replace with window_body_cols.
598 (Fwindow_width, Fscroll_left, Fscroll_right): Use
599 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
600 (delete_window, Fset_window_configuration): Call
601 delete_all_subwindows with window as argument.
602 (delete_all_subwindows): Take a window as argument and not a
603 structure. Rewrite.
190b47e6
MR
604 (window_loop): Remove handling of GET_LRU_WINDOW and
605 GET_LARGEST_WINDOW.
606 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
607
608 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
609 window_box_text_cols. delete_all_subwindows now takes a
610 Lisp_Object as argument.
abde8f8c
MR
611
612 * indent.c (compute_motion, Fcompute_motion): Use
613 window_body_cols instead of window_box_text_cols.
614
fa8a67e6
MR
615 * frame.c (delete_frame): Call delete_all_subwindows with root
616 window as argument.
617
a54e3482
DC
6182011-06-07 Daniel Colascione <dan.colascione@gmail.com>
619
620 * fns.c (Fputhash): Document return value.
621
60002bf5
CY
6222011-06-06 Chong Yidong <cyd@stupidchicken.com>
623
624 * image.c (gif_load): Implement gif89a spec "no disposal" method.
625
0c671da6 6262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 627
b862a52a 628 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 629
be44ca6c
PE
630 Check for overflow when converting integer to cons and back.
631 * charset.c (Fdefine_charset_internal, Fdecode_char):
632 Use cons_to_unsigned to catch overflow.
633 (Fencode_char): Use INTEGER_TO_CONS.
634 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
635 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
636 * data.c (long_to_cons, cons_to_long): Remove.
637 (cons_to_unsigned, cons_to_signed): New functions.
638 These signal an error for invalid or out-of-range values.
639 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
640 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
641 * font.c (Ffont_variation_glyphs):
642 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
643 * lisp.h: Include <intprops.h>.
644 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
645 (cons_to_signed, cons_to_unsigned): New decls.
646 (long_to_cons, cons_to_long): Remove decls.
647 * undo.c (record_first_change): Use INTEGER_TO_CONS.
648 (Fprimitive_undo): Use CONS_TO_INTEGER.
649 * xfns.c (Fx_window_property): Likewise.
650 * xselect.c: Include <limits.h>.
651 (x_own_selection, selection_data_to_lisp_data):
652 Use INTEGER_TO_CONS.
653 (x_handle_selection_request, x_handle_selection_clear)
654 (x_get_foreign_selection, Fx_disown_selection_internal)
655 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
656 (lisp_data_to_selection_data): Use cons_to_unsigned.
657 (x_fill_property_data): Use cons_to_signed.
658 Report values out of range.
659
d1f3d2af
PE
660 Check for buffer and string overflow more precisely.
661 * buffer.h (BUF_BYTES_MAX): New macro.
662 * lisp.h (STRING_BYTES_MAX): New macro.
663 * alloc.c (Fmake_string):
664 * character.c (string_escape_byte8):
665 * coding.c (coding_alloc_by_realloc):
666 * doprnt.c (doprnt):
667 * editfns.c (Fformat):
668 * eval.c (verror):
669 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
670 since they may not be the same number.
671 * editfns.c (Finsert_char):
672 * fileio.c (Finsert_file_contents):
673 Likewise for BUF_BYTES_MAX.
674
dd52fcea
PE
675 * image.c: Use ptrdiff_t, not int, for sizes.
676 (slurp_file): Switch from int to ptrdiff_t.
677 All uses changed.
678 (slurp_file): Check that file size fits in both size_t (for
679 malloc) and ptrdiff_t (for sanity and safety).
680
7f9bbdbb
PE
681 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
682 if b->modtime has its maximal value.
683
dfe18f82
PE
684 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
685
84acfcf0
PE
686 Don't assume time_t can fit into int.
687 * buffer.h (struct buffer.modtime): Now time_t, not int.
688 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
689 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
690
ccd9a01a
PE
691 Minor fixes for signed vs unsigned integers.
692 * character.h (MAYBE_UNIFY_CHAR):
693 * charset.c (maybe_unify_char):
694 * keyboard.c (read_char, reorder_modifiers):
695 XINT -> XFASTINT, since the integer must be nonnegative.
696 * ftfont.c (ftfont_spec_pattern):
697 * keymap.c (access_keymap, silly_event_symbol_error):
698 XUINT -> XFASTINT, since the integer must be nonnegative.
699 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
700 since it makes no difference and we prefer signed.
701 * keyboard.c (record_char): Use XUINT when all the neighbors do.
702 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
703 nonnegative.
704
d6d100dd
SM
7052011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
706
707 * window.h (Fwindow_frame): Declare.
708
2b6148e4
PE
7092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
710
711 * alloc.c: Simplify handling of large-request failures (Bug#8800).
712 (SPARE_MEMORY): Always define.
713 (LARGE_REQUEST): Remove.
714 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
715
f230ecc9
MR
7162011-06-06 Martin Rudalics <rudalics@gmx.at>
717
727e958e
MR
718 * lisp.h: Move EXFUNS for Fframe_root_window,
719 Fframe_first_window and Fset_frame_selected_window to window.h.
720
721 * window.h: Move EXFUNS for Fframe_root_window,
722 Fframe_first_window and Fset_frame_selected_window here from
723 lisp.h.
724
725 * frame.c (Fwindow_frame, Fframe_first_window)
726 (Fframe_root_window, Fframe_selected_window)
727 (Fset_frame_selected_window): Move to window.c.
728 (Factive_minibuffer_window): Move to minibuf.c.
729 (Fother_visible_frames_p): New function.
730
731 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
732
f230ecc9
MR
733 * window.c (decode_window, decode_any_window): Move up in code.
734 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
735 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
736 (Fwindow_buffer): Move up and rewrite doc-string.
737 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
738 (Fwindow_prev): New functions.
727e958e
MR
739 (Fwindow_frame): Move here from frame.c. Accept any window as
740 argument.
741 (Fframe_root_window, Fframe_first_window)
742 (Fframe_selected_window): Move here from frame.c. Accept frame
743 or arbitrary window as argument. Update doc-strings.
744 (Fminibuffer_window): Move up in code.
745 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
746 (Fset_frame_selected_window): Move here from frame.c.
747 Marginal rewrite.
727e958e
MR
748 (Fselected_window, select_window, Fselect_window): Move up in
749 code. Minor doc-string fixes.
f230ecc9 750
4d09bcf6
PE
7512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
752
753 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
754 Do not assume that spare memory exists; that assumption is valid
755 only if SYSTEM_MALLOC.
756 (LARGE_REQUEST): New macro, so that the issue of large requests
757 is separated from the issue of spare memory.
758
810928a2
AS
7592011-06-05 Andreas Schwab <schwab@linux-m68k.org>
760
172418ad
AS
761 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
762 format. (Bug#8806)
763
43f862f7
AS
764 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
765
810928a2
AS
766 * xfns.c (x_set_scroll_bar_default_width): Move declarations
767 before statements.
768
a059fe24
JD
7692011-06-05 Jan Djärv <jan.h.d@swipnet.se>
770
771 * gtkutil.c (xg_get_default_scrollbar_width): New function.
772
773 * gtkutil.h: Declare xg_get_default_scrollbar_width.
774
775 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
776 min width by calling x_set_scroll_bar_default_width (Bug#8505).
777
989bf368
JB
7782011-06-05 Juanma Barranquero <lekktu@gmail.com>
779
780 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
781
4b80f674
CY
7822011-06-04 Chong Yidong <cyd@stupidchicken.com>
783
784 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
785 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
786 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
787 New error handlers.
4b80f674
CY
788 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
789 Obey Vx_select_enable_clipboard_manager. Catch errors in
790 x_clipboard_manager_save (Bug#8779).
791 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 792 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 793
99a33b77 7942011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
795
796 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
797
99a33b77 7982011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
799
800 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
801 in the current matrix if keep_current_p is non-zero.
802
8264569d
EZ
8032011-06-04 Eli Zaretskii <eliz@gnu.org>
804
805 * bidi.c (bidi_level_of_next_char): Fix last change.
806
57f97249
EZ
8072011-06-03 Eli Zaretskii <eliz@gnu.org>
808
fec2107c 809 Support bidi reordering of text covered by display properties.
57f97249 810
fec2107c
EZ
811 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
812 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
813 (bidi_cache_search, bidi_cache_iterator_state)
814 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
815 (bidi_level_of_next_char, bidi_move_to_visually_next):
816 Support character positions inside a run of characters covered by a
fec2107c
EZ
817 display string.
818 (bidi_paragraph_init, bidi_resolve_explicit_1)
819 (bidi_level_of_next_char): Call bidi_fetch_char and
820 bidi_fetch_char_advance instead of FETCH_CHAR and
821 FETCH_CHAR_ADVANCE.
822 (bidi_init_it): Initialize new members.
823 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
824 definitions.
825 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
826 instead of using explicit *_CHAR codes.
d6d100dd
SM
827 (bidi_resolve_explicit, bidi_resolve_weak):
828 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
829 bidirectional text is supported only in multibyte buffers.
830 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
831 it to initialize the frame_window_p member of struct bidi_it.
832 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
833 (bidi_resolve_explicit, bidi_resolve_weak)
834 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
835 bidi_it->nchars is non-positive.
836 (bidi_level_of_next_char): Don't try to lookup the cache for the
837 next/previous character if nothing is cached there yet, or if we
838 were just reseat()'ed to a new position.
c40e2fb2 839
0e14fe90
EZ
840 * xdisp.c (set_cursor_from_row): Set start and stop points
841 according to the row's direction when priming the loop that looks
842 for the glyph on which to display cursor.
843 (single_display_spec_intangible_p): Function deleted.
844 (display_prop_intangible_p): Reimplement to call
845 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
846 Accept 3 additional arguments needed by handle_display_spec.
847 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
848 values: lists, `(when COND...)' forms, etc.
849 (single_display_spec_string_p): Support property values that are
850 lists with the argument STRING its top-level element.
851 (display_prop_string_p): Fix the condition for processing a
852 property that is a list to be consistent with handle_display_spec.
fec2107c 853 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
854 last portion of handle_display_prop.
855 (compute_display_string_pos): Accept additional argument
856 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
857 value of a `display' property is a "replacing spec".
858 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
859 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
860 the display property, but just return a value indicating whether
861 the display property will replace the characters it covers.
862 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
863 frame_window_p members of struct bidi_it.
d6d100dd
SM
864 (compute_display_string_pos, compute_display_string_end):
865 New functions.
fec2107c
EZ
866 (push_it): Accept second argument POSITION, where pop_it should
867 jump to continue iteration.
868 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 869
fec2107c
EZ
870 * keyboard.c (adjust_point_for_property): Adjust the call to
871 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
872
873 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
874 (bidi_init_it): Update prototypes.
875 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
876 (compute_display_string_pos, compute_display_string_end):
877 Declare prototypes.
fec2107c
EZ
878 (struct bidi_it): New members nchars and disp_pos. ch_len is now
879 EMACS_INT.
fc6f18ce 880
40087514 8812011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 882
57f53182
PE
883 Malloc failure behavior now depends on size of allocation.
884 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
885 * lisp.h: Change signatures accordingly.
886 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
887 All callers changed. (Bug#8762)
888
889 * gnutls.c: Use Emacs's memory allocators.
890 Without this change, the gnutls library would invoke malloc etc.
891 directly, which causes problems on non-SYNC_INPUT hosts, and which
892 runs afoul of improving memory_full behavior. (Bug#8761)
893 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
894 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
895 xfree instead of the default malloc, realloc, free.
896 (Fgnutls_boot): No need to check for memory allocation failure,
897 since xmalloc does that for us.
898
ac32cd99 899 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
900 * category.c (hash_get_category_set):
901 * ccl.c (ccl_driver):
902 * charset.c (Fdefine_charset_internal):
903 * charset.h (struct charset.hash_index):
904 * composite.c (get_composition_id, gstring_lookup_cache)
905 (composition_gstring_put_cache):
906 * composite.h (struct composition.hash_index):
907 * dispextern.h (struct image.hash):
908 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
909 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
910 (hashfn_equal, hashfn_user_defined, make_hash_table)
911 (maybe_resize_hash_table, hash_lookup, hash_put)
912 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
913 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
914 (Fsxhash, Fgethash, Fputhash, Fmaphash):
915 * image.c (make_image, search_image_cache, lookup_image)
916 (xpm_put_color_table_h):
917 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 918 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
919 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
920 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
921 * alloc.c (allocate_vectorlike):
922 Check for overflow in vector size calculations.
923 * ccl.c (ccl_driver):
924 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
925 * fns.c, image.c: Remove unnecessary static decls that would otherwise
926 need to be updated by these changes.
40087514
PE
927 * fns.c (make_hash_table, maybe_resize_hash_table):
928 Check for integer overflow with large hash tables.
0de4bb68
PE
929 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
930 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
931 (SXHASH_REDUCE): New macro.
932 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
933 Use it instead of discarding useful hash info with large hash values.
934 (sxhash_float): New function.
935 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
936 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
937 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
938 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
939 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
940 Adjust signatures to match updated version of code.
941 (consing_since_gc): Now EMACS_INT, since a single hash table can
942 use more than INT_MAX bytes.
943
698d32e2
DN
9442011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
945
946 Make it possible to build with GCC-4.6+ -O2 -flto.
947
948 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
949
fd6fa53f
SM
9502011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
951
952 * minibuf.c (get_minibuffer, read_minibuf_unwind):
953 Call minibuffer-inactive-mode.
954
864db017
JB
9552011-05-31 Juanma Barranquero <lekktu@gmail.com>
956
957 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
958 Update dependencies.
959
2ad0baf4
DN
9602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
961
962 * data.c (init_data): Remove code for UTS, this system is not
963 supported anymore.
964
4fcc2638
DN
9652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
966
967 Don't force ./temacs to start in terminal mode.
968
969 * frame.c (make_initial_frame): Initialize faces in all cases, not
970 only when CANNOT_DUMP is defined.
971 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
972
c56e0fd5
DN
9732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
974
975 * dispnew.c (add_window_display_history): Use const for the string
976 pointer. Remove declaration, not needed.
977
333d54da 9782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 979
55d4c1b2 980 Use 'inline', not 'INLINE'.
333d54da 981 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
982 * alloc.c, fontset.c (INLINE): Remove.
983 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
984 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
985 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
986 * gmalloc.c (register_heapinfo): Use inline unconditionally.
987 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
988
738db178
DN
9892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
990
991 Make it possible to run ./temacs.
992
993 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
994 syms_of_callproc does the same thing. Remove test for
995 "initialized", do it in the caller.
996 * emacs.c (main): Avoid calling set_initial_environment when dumping.
997
620c53a6
SM
9982011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
999
1000 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1001 (read_minibuf): Use get_minibuffer.
1002 (syms_of_minibuf): Use DEFSYM.
1003 (Qmetadata): New var.
1004 * data.c (Qbuffer): Don't make it static.
1005 (syms_of_data): Use DEFSYM.
1006
e003a292
PE
10072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1010 (CCL_CODE_MIN): New macro.
1011
ed008a6d
PE
10122011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1013
3687c2ef
PE
1014 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1015
ed008a6d
PE
1016 * eval.c (Qdebug): Now static.
1017 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1018 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1019 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1020
d66c4c7c
CY
10212011-05-29 Chong Yidong <cyd@stupidchicken.com>
1022
1023 * image.c: Various fixes to ImageMagick code comments.
1024 (Fimagemagick_types): Doc fix.
1025
5fbc2025
PE
10262011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1027
0196f88a
PE
1028 Minor fixes prompted by GCC 4.6.0 warnings.
1029
1030 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1031
5fbc2025
PE
1032 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1033 (x_clipboard_manager_save_all): Move extern decl to ...
1034 * xterm.h: ... here, so that it can be checked for consistency.
1035
1dd3c2d9
CY
10362011-05-29 Chong Yidong <cyd@stupidchicken.com>
1037
1038 * xselect.c (x_clipboard_manager_save_frame)
1039 (x_clipboard_manager_save_all): New functions.
1040 (Fx_clipboard_manager_save): Lisp function deleted.
1041
1042 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1043 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1044
1045 * xterm.h: Update prototype.
1046
5ba6571d
WX
10472011-05-28 William Xu <william.xwl@gmail.com>
1048
1049 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1050 exiting (Bug#8239).
1051
3eaff834
JM
10522011-05-28 Jim Meyering <meyering@redhat.com>
1053
e1900994 1054 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1055 * fns.c (to_uchar): Define.
1056 (crypto_hash_function): Use it to convert some newly-signed
1057 variables to unsigned, to avoid sign-extension bugs. For example,
1058 without this change, (md5 "truc") would evaluate to
1059 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1060 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1061 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1062
0f6990a7
PE
10632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 Integer overflow fixes.
c8a9ca5a 1066
08686060
PE
1067 * dbusbind.c: Serial number integer overflow fixes.
1068 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1069 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1070 to hold a serial number that is too large for a fixnum.
1071 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1072 Check for serial numbers out of range. Decode any serial number
59568bf0 1073 that was so large that it became a float. (Bug#8722)
08686060 1074
2d1fc3c7
PE
1075 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1076 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1077 Use XFASTINT rather than XUINT when numbers are nonnegative.
1078 (xd_append_arg, Fdbus_method_return_internal):
1079 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1080 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1081 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1082 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1083 (Bug#8722)
2d1fc3c7 1084
c8a9ca5a
PE
1085 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1086
519e1d69
PE
1087 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1088
30569699
PE
1089 ccl: add integer overflow checks
1090 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1091 (IN_INT_RANGE): New macros.
1092 (ccl_driver): Use them to check for integer overflow when
1093 decoding a CCL program. Many of the new checks are whether XINT (x)
1094 fits in int; it doesn't always, on 64-bit hosts. The new version
1095 doesn't catch all possible integer overflows, but it's an
847044ea 1096 improvement. (Bug#8719)
30569699 1097
c11285dc
PE
1098 * alloc.c (make_event_array): Use XINT, not XUINT.
1099 There's no need for unsigned here.
1100
fdccd48e
PE
1101 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1102 This follows up to the 2011-05-06 change that substituted uintptr_t
1103 for EMACS_INT. This case wasn't caught back then.
1104
37910ab2
PE
1105 Rework Fformat to avoid integer overflow issues.
1106 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1107 now (part of C89). Include <verify.h>.
1108 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1109 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1110 (Fformat): Avoid the prepass trying to compute sizes; it was only
1111 approximate and thus did not catch overflow reliably. Instead, walk
1112 through the format just once, formatting and computing sizes as we go,
1113 checking for integer overflow at every step, and allocating a larger
1114 buffer as needed. Keep track separately whether the format is
1115 multibyte. Keep only the most-recently calculated precision, rather
1116 than them all. Record whether each argument has been converted to
1117 string. Use EMACS_INT, not int, for byte and char and arg counts.
1118 Support field widths and precisions larger than INT_MAX. Avoid
1119 sprintf's undefined behavior with conversion specifications such as %#d
1120 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1121 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1122 formatting out-of-range floating point numbers with int
1123 formats. (Bug#8668)
1124
2e6578fb
PE
1125 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1126
0ae6bdee
PE
1127 * data.c: Avoid integer truncation in expressions involving floats.
1128 * data.c: Include <intprops.h>.
1129 (arith_driver): When there's an integer overflow in an expression
1130 involving floating point, convert the integers to floating point
1131 so that the resulting value does not suffer from catastrophic
1132 integer truncation. For example, on a 64-bit host (* 4
1133 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1134 Do not rely on undefined behavior after integer overflow.
1135
de883a70
PE
1136 merge count_size_as_multibyte, parse_str_to_multibyte
1137 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1138 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1139 Check for integer overflow.
1140 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1141 since it's now a duplicate of the other. This is more of
1142 a character than a buffer op, so better that it's in character.c.
1143 * fns.c, print.c: Adjust to above changes.
1144
2ff916cb
PE
11452011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1146
1147 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1148
f1b54466
PE
11492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1150
fb1ac845
PE
1151 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1152 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1153 (x_clipboard_manager_save): Now static.
1154 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1155
f1b54466
PE
1156 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1157 (crypto_hash_function): Now static.
1158 Fix pointer signedness problems. Avoid unnecessary initializations.
1159
a9f737ee
CY
11602011-05-27 Chong Yidong <cyd@stupidchicken.com>
1161
1162 * termhooks.h (Vselection_alist): Make it terminal-local.
1163
1164 * terminal.c (create_terminal): Initialize it.
1165
1166 * xselect.c: Support for clipboard managers.
1167 (Vselection_alist): Move to termhooks.h as terminal-local var.
1168 (LOCAL_SELECTION): New macro.
1169 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1170 (symbol_to_x_atom): Remove gratuitous arg.
1171 (x_handle_selection_request, lisp_data_to_selection_data)
1172 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1173 (x_own_selection, x_get_local_selection, x_convert_selection):
1174 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1175 (some_frame_on_display): Delete unused function.
1176 (Fx_own_selection_internal, Fx_get_selection_internal)
1177 (Fx_disown_selection_internal, Fx_selection_owner_p)
1178 (Fx_selection_exists_p): New optional frame arg.
1179 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1180 (x_handle_selection_clear): Don't treat other terminals with the
1181 same keyboard specially. Use the terminal-local Vselection_alist.
1182 (x_clear_frame_selections): Use Frun_hook_with_args.
1183
1184 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1185
1186 * xterm.h: Add support for those atoms.
1187
e067f0c1
CY
11882011-05-26 Chong Yidong <cyd@stupidchicken.com>
1189
1190 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1191 (converted_selections, conversion_fail_tag): New global variables.
1192 (x_selection_request_lisp_error): Free the above.
1193 (x_get_local_selection): Remove unnecessary code.
1194 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1195 of converted selections stored in converted_selections.
1196 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1197 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1198 (x_convert_selection): New function.
1199 (x_handle_selection_event): Simplify.
1200 (x_get_foreign_selection): Don't ignore incoming requests while
1201 waiting for an answer; this will fail when we implement
1202 SAVE_TARGETS, and seems unnecessary anyway.
1203 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1204 (Vx_sent_selection_functions): Doc fix.
1205
0f4aebc0
LL
12062011-05-26 Leo Liu <sdl.web@gmail.com>
1207
1208 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1209
e61124cd
YM
12102011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1211
1212 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1213
1214 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1215 for fringe update if it has periodic bitmap.
1216 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1217 and fringe_bitmap_periodic_p.
1218
1219 * fringe.c (get_fringe_bitmap_data): New function.
1220 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1221 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1222 row. Mark glyph row for fringe update if periodicity changed.
1223
1224 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1225 for fringe update unless it has periodic bitmap.
1226
f16d9837
KH
12272011-05-25 Kenichi Handa <handa@m17n.org>
1228
1229 * xdisp.c (get_next_display_element): Set correct it->face_id for
1230 a static composition.
1231
e1b90ef6
LL
12322011-05-24 Leo Liu <sdl.web@gmail.com>
1233
1234 * deps.mk (fns.o):
1235 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1236
1237 * fns.c (crypto_hash_function, Fsha1): New function.
1238 (Fmd5): Use crypto_hash_function.
1239 (syms_of_fns): Add Ssha1.
1240
7400048f
PE
12412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 * gnutls.c: Remove unused macros.
1244 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1245 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1246 Remove macros that are defined and never used.
1247 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1248
abb71cf4
CY
12492011-05-22 Chong Yidong <cyd@stupidchicken.com>
1250
1251 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1252 (Fx_get_selection_internal): Minor cleanup.
1253 (Fx_own_selection_internal): Rename arguments for consistency with
1254 select.el.
1255
6307db39
PE
12562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1259
f3d4e0a4
CY
12602011-05-22 Chong Yidong <cyd@stupidchicken.com>
1261
1262 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1263
4d8ade89
YM
12642011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1265
1266 * dispnew.c (scrolling_window): Don't exclude the case that the
1267 last enabled row in the desired matrix touches the bottom boundary.
1268
32078c8d
GM
12692011-05-21 Glenn Morris <rgm@gnu.org>
1270
1271 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1272 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1273 and add some more files.
32078c8d 1274
7285dc67
EZ
12752011-05-20 Eli Zaretskii <eliz@gnu.org>
1276
1277 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1278 report_file_error introduced by the change from 2011-05-07.
1279
89d1bd22
PE
12802011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * systime.h (Time): Define only if emacs is defined.
1283 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1284 where the include path doesn't have X11/X.h by default. See
1285 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1286
e23640bb 12872011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1288
1289 * composite.c (find_automatic_composition): Fix previous change.
1290
b9704ad9
GM
12912011-05-20 Glenn Morris <rgm@gnu.org>
1292
1293 * lisp.mk: New file, split from Makefile.in.
1294 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1295 (shortlisp): Remove.
1296 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1297
4a720484
GM
12982011-05-19 Glenn Morris <rgm@gnu.org>
1299
1300 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1301 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1302 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1303 (lisp): Set the order to that of loadup.el.
1304 (shortlisp): Make it a copy of $lisp.
1305 (SOME_MACHINE_LISP): Remove.
1306 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1307 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1308
a28d4396
KH
13092011-05-18 Kenichi Handa <handa@m17n.org>
1310
1311 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1312 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1313 (find_automatic_composition): Mostly rewrite for efficiency.
1314
a2b1fa8e
JB
13152011-05-18 Juanma Barranquero <lekktu@gmail.com>
1316
1317 * makefile.w32-in: Update dependencies.
1318
8e1f5610
CS
13192011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1320
1321 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1322 revision 104625).
1323
7025ee00 13242011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1325
cdfa6eab
PE
1326 Fix some integer overflow issues, such as string length overflow.
1327
06d6db33
PE
1328 * insdel.c (count_size_as_multibyte): Check for string overflow.
1329
2b4560a8
PE
1330 * character.c (lisp_string_width): Check for string overflow.
1331 Use EMACS_INT, not int, for string indexes and lengths; in
1332 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1333 the resulting string length overflows an EMACS_INT; instead,
1334 report a string overflow if no precision given. When checking for
1335 precision exhaustion, use a check that cannot possibly have
1336 integer overflow. (Bug#8675)
1337 * character.h (lisp_string_width): Adjust to new signature.
1338
cb93f9be
PE
1339 * alloc.c (string_overflow): New function.
1340 (Fmake_string): Use it. This doesn't change behavior, but saves
1341 a few bytes and will simplify future changes.
1342 * character.c (string_escape_byte8): Likewise.
1343 * lisp.h (string_overflow): New decl.
1344
1a1f3366
PE
1345 Fixups, following up to the user-interface timestamp change.
1346 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1347 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1348 * msdos.c (mouse_get_pos): Likewise.
1349 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1350 * w32gui.h (Time): Define by including "systime.h" rather than by
1351 declaring it ourselves. (Bug#8664)
1352
d4e3e4d3
PE
1353 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1354 * image.c (clear_image_cache): Likewise.
1355
f6a24d19
PE
1356 * term.c (term_mouse_position): Don't assume time_t wraparound.
1357
08dc5ae6
PE
1358 Be more systematic about user-interface timestamps.
1359 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1360 and sometimes 'EMACS_UINT', to represent these timestamps.
1361 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1362 This makes the code easier to follow, and makes it easier to catch
1363 integer overflow bugs such as Bug#8664.
1364 * frame.c (Fmouse_position, Fmouse_pixel_position):
1365 Use Time, not unsigned long, for user-interface timestamps.
1366 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1367 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1368 * keyboard.h (last_event_timestamp): Likewise.
1369 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1370 * menu.h (xmenu_show): Likewise.
1371 * term.c (term_mouse_position): Likewise.
1372 * termhooks.h (struct input_event.timestamp): Likewise.
1373 (struct terminal.mouse_position_hook): Likewise.
1374 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1375 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1376 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1377 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1378 what it was before.
1379 * menu.h, termhooks.h: Include "systime.h", for Time.
1380
8e55734a
PE
1381 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1382 Don't assume that the difference between two unsigned long values
1383 can fit into an integer. At this point, we know button_down_time
1384 <= event->timestamp, so the difference must be nonnegative, so
1385 there's no need to cast the result if double-click-time is
1386 nonnegative, as it should be; check that it's nonnegative, just in
1387 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1388 apart (about 25 days). (Bug#8664)
8e55734a 1389
841f1b75 1390 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1391 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1392
3e26f69c
PE
1393 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1394 that always fit in int. Use a sentinel instead of a counter, to
1395 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1396 * frame.h (struct frame): Use int for menu_bar_items_used
1397 instead of EMACS_INT, since it always fits in int.
3e26f69c 1398
5cc152c0
PE
1399 * menu.c (grow_menu_items): Check for int overflow.
1400
d89eb65e
PE
1401 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1402
5235bd3e
PE
1403 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1404 Before, the code was not consistent. These values cannot exceed
1405 2**31 - 1 so there's no need to make them unsigned.
1406 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1407 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1408 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1409 as modifiers.
1410 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1411
bc827e23
PE
1412 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1413 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1414 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1415 presumably because the widths might not match.
1416
78eb494e
PE
1417 * window.c (size_window): Avoid needless test at loop start.
1418
04f2d78b
CB
14192011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1420
1421 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1422
d2fc7e3d 14232011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1424
1425 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1426
d2fc7e3d 14272011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1428
1429 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1430 `width' to `bar_area_x' and `bar_area_width', respectively.
1431 (x_scroll_run): Take account of fringe background extension.
1432
04f2d78b
CB
1433 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1434 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1435 `bar_area_width', respectively.
1436 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1437 background extension.
1438
79b70037
GM
14392011-05-10 Jim Meyering <meyering@redhat.com>
1440
1441 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1442
2f142cc5
JB
14432011-05-10 Juanma Barranquero <lekktu@gmail.com>
1444
1445 * image.c (Finit_image_library): Return t for built-in image types,
1446 like pbm and xbm. (Bug#8640)
1447
57679c86
AS
14482011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1449
1450 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1451
888c9e86
EZ
14522011-05-07 Eli Zaretskii <eliz@gnu.org>
1453
b0512a1d
EZ
1454 * w32console.c (Fset_screen_color): Doc fix.
1455 (Fget_screen_color): New function.
1456 (syms_of_ntterm): Defsubr it.
1457
7285dc67
EZ
1458 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1459 unlink the temporary file if Fcall_process didn't create it in the
1460 first place.
1461 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1462 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1463 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1464 cue to call_process_cleanup not to close that handle.
1465
4d3fcc8e
BK
14662011-05-07 Ben Key <bkey76@gmail.com>
1467
1468 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1469 one of two shell specific rules, either bootstrap-temacs-CMD or
1470 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1471 to the previous implementation of the bootstrap-temacs rule.
1472 The bootstrap-temacs-CMD rule is similar to the previous
1473 implementation of the bootstrap-temacs rule except that it
1474 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1475 variable.
1476
1477 These changes, along with some changes to nt/configure.bat,
1478 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1479 earlier fix to add support for --cflags and --ldflags options
1480 that include quotes so that it works whether make uses cmd or
1481 sh as the shell.
1482
b4289b64
MA
14832011-05-06 Michael Albinus <michael.albinus@gmx.de>
1484
1485 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1486 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1487 is a constant.
1488 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1489 a string. Handle both cases.
1490 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1491 (Fdbus_register_method): Use Qinvalid_function.
1492
af4c0e28
JB
14932011-05-06 Juanma Barranquero <lekktu@gmail.com>
1494
1495 * makefile.w32-in: Update dependencies.
1496 (LISP_H): Add inttypes.h and stdin.h.
1497 (PROCESS_H): Add unistd.h.
1498
c51453d9
EZ
14992011-05-06 Eli Zaretskii <eliz@gnu.org>
1500
1501 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1502 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1503
8ff0ac3c 15042011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1505
4c4b566b
PE
1506 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1507
aab2b9b5
PE
1508 * term.c (vfatal): Remove stray call to va_end.
1509 It's not needed and the C Standard doesn't allow it here anyway.
1510
c378da0b
PE
1511 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1512 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1513
288b08c7
PE
1514 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1515 bytes.
1516
e3601888
PE
1517 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1518
db6c0e74
PE
1519 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1520
dd5963ea
PE
1521 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1522
88c9450f
PE
1523 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1524
2f9442b8
PE
1525 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1526
c032b5f8
PE
1527 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1528 * charset.c (Fdefine_charset_internal): Don't initialize
1529 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1530 32-bit int (Bug#8600).
a108c10b
PE
1531
1532 * lread.c (read_integer): Be more consistent with string-to-number.
1533 Use string_to_number to do the actual conversion; this avoids
1534 rounding errors and fixes some other screwups. Without this fix,
1535 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1536 (digit_to_number): Move earlier, for benefit of read_integer.
1537 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1538 not a digit in any supported base. (Bug#8602)
a108c10b 1539
ad5f9eea
PE
1540 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1541
aec1708a
PE
1542 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1543 to match comment at start of function. This also removes a
1544 GCC warning about overflow in a 32+64-bit port.
1545
47be4ab5
PE
1546 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1547
371cac43
PE
1548 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1549 Reported by Stefan Monnier in
1550 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1551 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1552 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1553
d01a7826
PE
1554 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1555 (EMACS_UINTPTR): Likewise, with uintptr_t.
1556
7fd47d5c
PE
1557 * lisp.h: Prefer 64-bit EMACS_INT if available.
1558 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1559 on 32-bit hosts that have 64-bit int, so that they can access
1560 large files.
122b0c86
PE
1561 However, temporarily disable this change unless the temporary
1562 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1563
8727937b
PE
1564 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1565
8ac068ac
PE
1566 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1567 This removes an assumption that EMACS_INT and long are the same
1568 width as pointers. The assumption is true for Emacs porting targets
1569 now, but we want to make other targets possible.
1570 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1571 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1572 In the rest of the code, change types of integers that hold casted
1573 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1574 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1575 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1576 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1577 No need to cast type when ORing.
1578 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1579 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1580 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1581 assume EMACS_INT is the same width as char *.
1582 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1583 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1584 Remove no-longer-needed casts.
1585 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1586 (xg_tool_bar_help_callback, xg_make_tool_item):
1587 Use EMACS_INTPTR to hold an integer
1588 that will be cast to void *; this can avoid a GCC warning
1589 if EMACS_INT is not the same width as void *.
1590 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1591 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1592 (current_message_1, set_message_1):
1593 Use a local to convert to proper width without a cast.
1594 * xmenu.c (dialog_selection_callback): Likewise.
1595
ede49d71
PE
1596 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1597 Also, don't assume VALBITS / RAND_BITS is less than 5,
1598 and don't rely on undefined behavior when shifting a 1 left into
1599 the sign bit.
1600 * lisp.h (get_random): Change signature to match.
1601
2f30ecd0
PE
1602 * lread.c (hash_string): Use size_t, not int, for hash computation.
1603 Normally we prefer signed values; but hashing is special, because
1604 it's better to use unsigned division on hash table sizes so that
1605 the remainder is nonnegative. Also, size_t is the natural width
1606 for hashing into memory. The previous code used 'int', which doesn't
1607 retain enough info to hash well into very large tables.
1608 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1609
2a866e7b
PE
1610 * dbusbind.c: Don't possibly lose pointer info when converting.
1611 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1612 Use XPNTR rather than XHASH, so that the high-order bits of
1613 the pointer aren't lost when converting through void *.
1614
51639eac
PE
1615 * eval.c (Fautoload): Don't double-shift a pointer.
1616
92394119
PE
1617 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1618
dbdb9a7c
JB
16192011-05-06 Juanma Barranquero <lekktu@gmail.com>
1620
1621 * gnutls.c (DEF_GNUTLS_FN):
1622 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1623
db7a0b4f
AS
16242011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1625
1626 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1627 marker. (Bug#8610)
1628
f7ff1b0f 16292011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1630
1631 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1632 New version that can reserve upto 2GB of heap space.
1633
f7ff1b0f 16342011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1635
1636 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1637
639c109b
TZ
16382011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1639
1640 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1641 `gnutls_certificate_set_x509_key_file'.
1642
d2127135
JB
16432011-05-05 Juanma Barranquero <lekktu@gmail.com>
1644
1645 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1646 Update dependencies.
1647
e968f4f3
JB
16482011-05-04 Juanma Barranquero <lekktu@gmail.com>
1649
1650 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1651 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1652 Remove unused parameter `fildes'.
1653 * process.c (read_process_output, send_process): Don't pass it.
1654
84d358f0
JB
16552011-05-04 Juanma Barranquero <lekktu@gmail.com>
1656
1657 Fix previous change: the library cache is defined in w32.c.
1658 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1659 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1660
0898ca10
JB
16612011-05-04 Juanma Barranquero <lekktu@gmail.com>
1662
1663 Implement dynamic loading of GnuTLS on Windows.
1664
1665 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1666 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1667 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1668 Declare.
1669
1670 * gnutls.c (Qgnutls_dll): Define.
1671 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1672 (gnutls_*): Declare function pointers.
1673 (init_gnutls_functions): New function to initialize function pointers.
1674 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1675 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1676 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1677 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1678 (emacs_gnutls_write, emacs_gnutls_read)
1679 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1680 (Fgnutls_available_p): New function.
1681 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1682 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1683 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1684
1685 * image.c: Include w32.h.
1686 (Vimage_type_cache): Delete.
1687 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1688 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1689 (w32_delayed_load): Move to w32.c.
1690
1691 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1692
1693 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1694 (w32_delayed_load): Move from image.c. When loading a library, record
1695 its filename in the :loaded-from property of the library id.
1696 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1697 Initialize and staticpro them.
1698 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1699
1700 * process.c: Include lisp.h before w32.h, not after.
1701 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1702 instead of gnutls_record_check_pending.
1703
1704 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1705
ff4de4aa
TZ
17062011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1707
1708 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1709 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1710 as passed in.
1711
abe95abb
JD
17122011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1713
1714 * xterm.c (x_set_frame_alpha): Do not set property on anything
1715 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1716
e16e55d4
JB
17172011-05-02 Juanma Barranquero <lekktu@gmail.com>
1718
1719 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1720
bafcf6a5
JB
17212011-05-02 Juanma Barranquero <lekktu@gmail.com>
1722
1723 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1724 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1725 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1726 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1727 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1728 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1729 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1730 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1731 (Qgnutls_bootprop_callbacks_verify): Make static.
1732
e7a6747f
AS
17332011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1734
19ed11ba
AS
1735 * callproc.c: Indentation fixup.
1736
e7a6747f 1737 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1738 (wait_for_termination, interruptible_wait_for_termination):
1739 Move after wait_for_termination_1.
e7a6747f 1740
1ef14cb4
LMI
17412011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1742
1743 * sysdep.c (interruptible_wait_for_termination): New function
1744 which is like wait_for_termination, but allows keyboard
1745 interruptions.
1746
1747 * callproc.c (Fcall_process): Add (:file "file") as an option for
1748 the STDOUT buffer.
1749 (Fcall_process_region): Ditto.
1750
330d880c
EZ
17512011-04-30 Eli Zaretskii <eliz@gnu.org>
1752
8db90b73
EZ
1753 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1754 rather than `XVECTOR (FOO)->size'.
1755
330d880c
EZ
1756 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1757 inttypes.h, as a gnulib replacement is used if it not available in
1758 system headers.
1759
15cbd324
EZ
17602011-04-21 Eli Zaretskii <eliz@gnu.org>
1761
1762 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1763 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1764 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1765
1766 * coding.c (coding_alloc_by_realloc): Error out if destination
1767 will grow beyond MOST_POSITIVE_FIXNUM.
1768 (decode_coding_emacs_mule): Abort if there isn't enough place in
1769 charbuf for the composition carryover bytes. Reserve an extra
1770 space for up to 2 characters produced in a loop.
1771 (decode_coding_iso_2022): Abort if there isn't enough place in
1772 charbuf for the composition carryover bytes.
1773
17742011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1775
ae940cca
EZ
1776 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1777 aborting when %lld or %lll format is passed.
1778 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1779 %llo or %llx format is passed. (Bug#8545)
1780
03ab8921
EZ
1781 * window.c (window_scroll_line_based): Use a marker instead of
1782 simple variables to record original value of point. (Bug#7952)
1783
afda1437
EZ
1784 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1785 produced by %s or %c overflows available buffer space. (Bug#8545)
1786
f76dee0c
PE
17872011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1790 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1791
fdc5744d
JB
17922011-04-28 Juanma Barranquero <lekktu@gmail.com>
1793
1794 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1795
638f053a
JB
17962011-04-28 Juanma Barranquero <lekktu@gmail.com>
1797
1798 * keyboard.c (Qdelayed_warnings_hook): Define.
1799 (command_loop_1): Run `delayed-warnings-hook'
1800 if Vdelayed_warnings_list is non-nil.
1801 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1802 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1803
d178f871
EZ
18042011-04-28 Eli Zaretskii <eliz@gnu.org>
1805
1806 * doprnt.c (doprnt): Don't return value smaller than the buffer
1807 size if the message was truncated. (Bug#8545).
1808
b124fd93
JB
18092011-04-28 Juanma Barranquero <lekktu@gmail.com>
1810
1811 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1812 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1813
e810457d
PE
18142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1815
1816 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1817
ea51cceb
JB
18182011-04-27 Juanma Barranquero <lekktu@gmail.com>
1819
1820 * makefile.w32-in: Update dependencies.
1821
94dcfacf
EZ
18222011-04-27 Eli Zaretskii <eliz@gnu.org>
1823
1824 Improve `doprnt' and its usage. (Bug#8545)
1825 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1826 `format_end'. Remove support for %l as a conversion specifier.
1827 Don't use xrealloc. Improve diagnostics when the %l size modifier
1828 is used. Update the commentary.
1829
1830 * eval.c (verror): Simplify calculation of size_t.
1831
1832 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1833 messages.
1834
f61f41d7
PE
18352011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1836
1837 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1838 change.
1839
96fb4434
PE
18402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1843 This makes this file independent of the recent pseudovector change.
1844
671875da 18452011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1846
69e9b5a3
PE
1847 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1848
b5f869a7 1849 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1850 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1851 Remove unused local.
c8926152 1852 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1853
841a1577 1854 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1855 GCC 4.6.0 optimizes based on type-based alias analysis.
1856 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1857 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1858 != &v->size, and therefore "v->size = 1; b->size = 2; return
1859 v->size;" must therefore return 1. This assumption is incorrect
1860 for Emacs, since it type-puns struct Lisp_Vector * with many other
1861 types. To fix this problem, this patch adds a new type struct
f904488f 1862 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1863 and pseudovectors, and helps optimizing compilers not get fooled
1864 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1865 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1866 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1867 the size member.
eab3844f
PE
1868 (XSETPVECTYPE): Rewrite in terms of new macro.
1869 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1870 This is a bit clearer, and further avoids the possibility of
1871 undesirable aliasing.
1872 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1873 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1874 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1875 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1876 (ASIZE): Now uses header.size rather than size.
1877 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1878 to avoid the hassle of writing XVECTOR (foo)->header.size.
1879 (struct vectorlike_header): New type.
eab3844f
PE
1880 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1881 object, to help avoid aliasing.
1882 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1883 (SUBRP): Likewise, since Lisp_Subr is a special case.
1884 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1885 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1886 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1887 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1888 changed to be "header.size" and "header.next".
1889 * buffer.h (struct buffer): Likewise.
1890 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1891 * frame.h (struct frame): Likewise.
1892 * process.h (struct Lisp_Process): Likewise.
1893 * termhooks.h (struct terminal): Likewise.
1894 * window.c (struct save_window_data, struct saved_window): Likewise.
1895 * window.h (struct window): Likewise.
1896 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1897 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1898 * buffer.c (init_buffer_once): Likewise.
1899 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1900 special case.
1901 * process.c (Fformat_network_address): Use local var for size,
1902 for brevity.
1903
0df1eac5
PE
1904 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1905
847ab9d1 1906 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1907 * data.c (atof): Remove decl; no longer used or needed.
1908 (digit_to_number): Move to lread.c.
1909 (Fstring_to_number): Use new string_to_number function, to be
1910 consistent with how the Lisp reader treats infinities and NaNs.
1911 Do not assume that floating-point numbers represent EMACS_INT
1912 without losing information; this is not true on most 64-bit hosts.
1913 Avoid double-rounding errors, by insisting on integers when
1914 parsing non-base-10 numbers, as the documentation specifies.
1915 * lisp.h (string_to_number): New decl, replacing ...
1916 (isfloat_string): Remove.
bc0a5c13 1917 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1918 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1919 appears to have been a coding error. Similarly, do not accept
1920 strings like +-1e0 as floating point numbers. Do not report
1921 overflow for integer overflows unless the base is not 10 which
1922 means we have no simple and reliable way to continue.
1923 Break out the floating-point parsing into a new
1924 function string_to_number, so that Fstring_to_number parses
1925 floating point numbers consistently with the Lisp reader.
04f2d78b 1926 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1927 (E_CHAR, EXP_INT): Remove, replacing with ...
1928 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1929 (string_to_number): New function, replacing isfloat_string.
1930 This function checks for valid syntax and produces the resulting
1931 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1932 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1933 so that overflow for non-base-10 numbers is reported only when
1934 there's no portable and simple way to convert to floating point.
452f4150 1935
67769ffc
PE
1936 * textprop.c (set_text_properties_1): Rewrite for clarity,
1937 and to avoid GCC warning about integer overflow.
1938
c20db43f
PE
1939 * intervals.h (struct interval): Use EMACS_INT for members
1940 where EMACS_UINT might cause problems. See
1941 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1942 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1943 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1944 All uses changed.
37aa2f85
PE
1945 (offset_intervals): Tell GCC not to worry about length overflow
1946 when negating a negative length.
c20db43f 1947
2538aa2f
PE
1948 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1949 (overrun_check_free): Likewise.
1950
f2d3008d
PE
1951 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1952 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1953 word size.
1954
ec8df744
PE
1955 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1956 (gnutls_make_error): Rename local to avoid shadowing.
1957 (gnutls_emacs_global_deinit): ifdef out; not used.
1958 (Fgnutls_boot): Use const for pointer to readonly storage.
1959 Comment out unused local. Fix pointer signedness problems.
1960
640ee02d
PE
1961 * lread.c (openp): Don't stuff size_t into an 'int'.
1962 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1963 about possible signed overflow.
1964
6048fb2a
PE
1965 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1966 (GDK_KEY_g): Don't define if already defined.
1967 (xg_prepare_tooltip): Avoid pointer signedness problem.
1968 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1969
fa3c87e1
PE
1970 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1971 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1972
2172544b
PE
1973 * xfns.c (Fx_window_property): Simplify a bit,
1974 to make a bit faster and to avoid GCC 4.6.0 warning.
1975 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1976
9b821a21
PE
1977 * fns.c (internal_equal): Don't assume size_t fits in int.
1978
3c616cfa
PE
1979 * alloc.c (compact_small_strings): Tighten assertion a little.
1980
c2982e87
PE
1981 Replace pEd with more-general pI, and fix some printf arg casts.
1982 * lisp.h (pI): New macro, generalizing old pEd macro to other
1983 conversion specifiers. For example, use "...%"pI"d..." rather
1984 than "...%"pEd"...".
1985 (pEd): Remove. All uses replaced with similar uses of pI.
1986 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1987 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1988 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1989 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1990 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1991 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1992 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1993 64-bit hosts.
1994 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1995 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1996 * print.c (safe_debug_print, print_object): Likewise.
1997 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1998 to int.
6f04d126
PE
1999 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2000 avoiding the 0 flag, which is not portable.
c2982e87
PE
2001 * process.c (Fmake_network_process): Use pI to avoid cast.
2002 * region-cache.c (pp_cache): Likewise.
2003 * xdisp.c (decode_mode_spec): Likewise.
2004 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2005 behavior on 64-bit hosts with printf arg.
6f04d126 2006 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2007 (x_stop_queuing_selection_requests): Likewise.
2008 (x_get_window_property): Don't truncate byte count to an 'int'
2009 when tracing.
0b432f21 2010
5e073ec7
PE
2011 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2012 here, since it parses constructs like leading '-' and spaces,
2013 which are not wanted; and it overflows with large numbers.
2014 Instead, simply match F[0-9]+, which is what is wanted anyway.
2015
36372bf9
PE
2016 * alloc.c: Remove unportable assumptions about struct layout.
2017 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2018 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2019 (allocate_vectorlike, make_pure_vector): Use the new macros,
2020 plus offsetof, to remove unportable assumptions about struct layout.
2021 These assumptions hold on all porting targets that I know of, but
2022 they are not guaranteed, they're easy to remove, and removing them
2023 makes further changes easier.
2024
0b432f21
PE
2025 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2026 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2027 (string_overrun_cookie): Now const. Use initializers that
2028 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2029 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2030 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2031 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2032 multiple of sizeof (EMACS_INT); it need not be, if
2033 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2034 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2035
895009e1
JB
20362011-04-26 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2039
6a7a1b0b
TZ
20402011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2041
2042 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2043 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2044 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2045
841a1577 20462011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2047
2048 * lisp.h (Qdebug): List symbol.
895009e1 2049 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2050 * keyboard.c (debug-on-event): New variable.
2051 (handle_user_signal): Break into debugger when debug-on-event
2052 matches the current signal symbol.
2053
f2d3ba6f
DN
20542011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2055
2056 * alloc.c (check_sblock, check_string_bytes)
2057 (check_string_free_list): Convert to standard C.
2058
42ce4c63
TZ
20592011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2060
2061 * w32.c (emacs_gnutls_push): Fix typo.
2062
825cd63c
EZ
20632011-04-25 Eli Zaretskii <eliz@gnu.org>
2064
fb11d64d
EZ
2065 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2066 "cast to pointer from integer of different size".
2067
825cd63c
EZ
2068 Improve doprnt and its use in verror. (Bug#8545)
2069 * doprnt.c (doprnt): Document the set of format control sequences
2070 supported by the function. Use SAFE_ALLOCA instead of always
2071 using `alloca'.
2072
2073 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2074 is one byte too soon. Don't use xrealloc; instead xfree and
2075 xmalloc anew.
2076
e061a11b
TZ
20772011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2078
2079 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2080 callbacks stage.
2081
2082 * gnutls.c: Renamed global_initialized to
2083 gnutls_global_initialized. Added internals for the
2084 :verify-hostname-error, :verify-error, and :verify-flags
2085 parameters of `gnutls-boot' and documented those parameters in the
2086 docstring. Start callback support.
2087 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2088 unless a fatal error occured. Call gnutls_alert_send_appropriate
2089 on error. Return error code.
2090 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2091 (emacs_gnutls_read): Likewise.
2092 (Fgnutls_boot): Return handshake error code.
2093 (emacs_gnutls_handle_error): New function.
2094 (wsaerror_to_errno): Likewise.
2095
2096 * w32.h (emacs_gnutls_pull): Add prototype.
2097 (emacs_gnutls_push): Likewise.
2098
2099 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2100 (emacs_gnutls_push): Likewise.
2101
21022011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2103
2104 * process.c (wait_reading_process_output): Check if GnuTLS
2105 buffered some data internally if no FDs are set for TLS
2106 connections.
2107
2108 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2109 (LIBS): Link to USER_LIBS.
2110 ($(BLD)/gnutls.$(0)): New target.
2111
fa6996bc
EZ
21122011-04-24 Eli Zaretskii <eliz@gnu.org>
2113
eb35682e
EZ
2114 * xdisp.c (handle_single_display_spec): Rename the
2115 display_replaced_before_p argument into display_replaced_p, to
2116 make it consistent with the commentary. Fix typos in the
2117 commentary.
2118
e2ad650c
EZ
2119 * textprop.c (syms_of_textprop): Remove dead code.
2120 (copy_text_properties): Delete obsolete commentary about an
2121 interface that was deleted long ago. Fix typos in the description
2122 of arguments.
2123
1b2de274
EZ
2124 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2125 to changes in oldXMenu/XMenu.h from 2011-04-16.
2126 <menu_help_message, prev_menu_help_message>: Constify.
2127 (IT_menu_make_room): menu->help_text is now `const char **';
2128 adjust.
2129
2130 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2131 to changes in oldXMenu/XMenu.h from 2011-04-16.
2132 (struct XMenu): Declare `help_text' `const char **'.
2133
2134 * xfaces.c <Qunspecified>: Make extern again.
2135
2136 * syntax.c: Include sys/types.h before including regex.h, as
2137 required by Posix.
2138
762b15be
EZ
2139 * doc.c (get_doc_string): Improve the format passed to `error'.
2140
2141 * doprnt.c (doprnt): Improve commentary.
2142
2143 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2144
2145 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2146 them with etags.
2147
f1052e5d
EZ
2148 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2149 changes in globals.h immediately force recompilation.
762b15be
EZ
2150 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2151 $(CURDIR)/s/ms-w32.h.
2152 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2153
fa6996bc
EZ
2154 * character.c (Fchar_direction): Function deleted.
2155 (syms_of_character): Don't defsubr it.
2156 <char-direction-table>: Deleted.
2157
e6c3da20
EZ
21582011-04-23 Eli Zaretskii <eliz@gnu.org>
2159
2160 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2161 * doprnt.c: Include limits.h.
2162 (SIZE_MAX): New macro.
04f2d78b
CB
2163 (doprnt): Return a size_t value. 2nd arg is now size_t.
2164 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2165 Improve overflow protection. Support `l' modifier for integer
2166 conversions. Support %l conversion. Don't assume an EMACS_INT
2167 argument for integer conversions and for %c.
2168
2169 * lisp.h (doprnt): Restore prototype.
2170
2171 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2172 $(SRC)/character.h.
2173
2174 * Makefile.in (base_obj): Add back doprnt.o.
2175
2176 * deps.mk (doprnt.o): Add back prerequisites.
2177 (callint.o): Depend on character.h.
2178
2179 * eval.c (internal_lisp_condition_case): Include the handler
2180 representation in the error message.
2181 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2182 when breaking from the loop.
2183
2184 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2185
2186 * callint.c (Fcall_interactively): When displaying error message
2187 about invalid control letter, pass the character's codepoint, not
2188 a pointer to its multibyte form. Improve display of the character
2189 in octal and display also its hex code.
2190
2191 * character.c (char_string): Use %x to display the (unsigned)
2192 codepoint of an invalid character, to avoid displaying a bogus
2193 negative value.
2194
2195 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2196 `error', not SYMBOL_NAME itself.
2197
2198 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2199 character arguments to `error'.
2200
2201 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2202 to `error' in error message about FINAL_CHAR argument. Make sure
2203 FINAL_CHAR is a character, and use %c when it is passed as
2204 argument to `error'.
2205
4ffd0d6b 22062011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2207
2208 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2209
2210 * w32.c: Include <time.h>.
2211 (sys_localtime): New function.
2212
4ffd0d6b 22132011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2214
2215 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2216
4ffd0d6b 2217 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2218
4ffd0d6b 22192011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2220
4ffd0d6b
GM
2221 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2222 zombies (Bug#8467).
aac0c6e3 2223
04c56954
EZ
22242011-04-19 Eli Zaretskii <eliz@gnu.org>
2225
2226 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2227 gl_state.e_property when gl_state.object is Qt.
2228
2229 * insdel.c (make_gap_larger): Remove limitation of buffer size
2230 to <= INT_MAX.
2231
16a43933
CY
22322011-04-18 Chong Yidong <cyd@stupidchicken.com>
2233
2234 * xdisp.c (lookup_glyphless_char_display)
2235 (produce_glyphless_glyph): Handle cons cell entry in
2236 glyphless-char-display.
2237 (Vglyphless_char_display): Document it.
2238
2239 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2240 glyphless-char-display.
2241
4581706e
CY
22422011-04-17 Chong Yidong <cyd@stupidchicken.com>
2243
2244 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2245
2246 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2247
2248 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2249 definition for no-X builds.
2250
4887c6e2 22512011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2252
fd35b6f9
PE
2253 Static checks with GCC 4.6.0 and non-default toolkits.
2254
5c1ccb01
PE
2255 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2256
006c5daa
PE
2257 * process.c (keyboard_bit_set): Define only if SIGIO.
2258 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2259 (send_process): Repair possible setjmp clobbering.
2260
efc736d3
PE
2261 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2262
4e2fe2e6
PE
2263 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2264
f97334a2
PE
2265 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2266
4e75f29d
PE
2267 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2268 Define only if needed.
2269
90efadd1
PE
2270 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2271 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2272 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2273
3c647824
PE
2274 * dispextern.h (struct redisplay_interface): Rename param
2275 to avoid shadowing.
e264f262 2276 * termhooks.h (struct terminal): Likewise.
761383f4 2277 * xterm.c (xembed_send_message): Likewise.
3c647824 2278
b58c5c4a
PE
2279 * insdel.c (make_gap_smaller): Define only if
2280 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2281
cad59032
PE
2282 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2283 it.
2284
c339dc2e
PE
2285 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2286 so that we aren't warned about unused symbols.
2287
91a3e27b
PE
2288 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2289
399c71d3 2290 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2291
8ffc96f5
PE
2292 * xfns.c (x_real_positions): Mark locals as initialized.
2293
eef9bc79
PE
2294 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2295
098db9dd
PE
2296 * xterm.c: Fix problems found by static analysis with other toolkits.
2297 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2298 (x_dispatch_event): Declare static if USE_GTK, and
2299 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2300 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2301 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2302 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2303 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2304
eb18f6cc
PE
2305 * xmenu.c (menu_help_callback): Pointer type fixes.
2306 Use const pointers when pointing at readonly data. Avoid pointer
2307 signedness clashes.
2308 (FALSE): Remove unused macro.
2309 (update_frame_menubar): Remove unused decl.
2310
1fe72bf8
PE
2311 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2312
60d9e1db
PE
2313 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2314 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2315 (single_menu_item): Rename local to avoid shadowing.
2316
39261c26
PE
2317 * keyboard.c (make_lispy_event): Remove unused local var.
2318
018c5e19
PE
2319 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2320 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2321
63d2b86e
PE
2322 * bitmaps: Change bitmaps from unsigned char back to the X11
2323 compatible char. Avoid the old compiler warnings about
2324 out-of-range initializers by using, for example, '\xab' rather
2325 than 0xab.
2326
aefd87e1
PE
2327 * xgselect.c (xgselect_initialize): Check vs interface
2328 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2329
bf501fb9
PE
2330 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2331
e9829fdf
PE
2332 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2333 to read-only memory.
2334
1086c095
PE
2335 * fns.c (vector): Remove; this old hack is no longer needed.
2336
2baccd04 2337 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2338 Remove unused var.
dde42981 2339 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2340
72391843 2341 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2342
436c16df 2343 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2344 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2345 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2346
92bb796d 2347 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2348 (x_term_init): Remove local to avoid shadowing.
92bb796d 2349
764430a3 2350 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2351
2352 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2353 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2354
d1dfb56c
EZ
23552011-04-16 Eli Zaretskii <eliz@gnu.org>
2356
c4354cb4
EZ
2357 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2358
d1dfb56c
EZ
2359 Fix regex.c, syntax.c and friends for buffers > 2GB.
2360 * syntax.h (struct gl_state_s): Declare character position members
2361 EMACS_INT.
2362
2363 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2364
04f2d78b
CB
2365 * textprop.c (verify_interval_modification, interval_of):
2366 Declare arguments EMACS_INT.
d1dfb56c
EZ
2367
2368 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2369 EMACS_INT.
2370
2371 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2372
2373 * indent.c (Fvertical_motion): Local variable it_start is now
2374 EMACS_INT.
2375
2376 * regex.c (re_match, re_match_2, re_match_2_internal)
2377 (bcmp_translate, regcomp, regexec, print_double_string)
2378 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2379 (re_compile_pattern, re_exec): Declare arguments and local
2380 variables `size_t' and `ssize_t' and return values `regoff_t', as
2381 appropriate.
2382 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2383 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2384 <compile_stack_type>: `size' and `avail' are now `size_t'.
2385
2386 * regex.h <regoff_t>: Use ssize_t, not int.
2387 (re_search, re_search_2, re_match, re_match_2): Arguments that
2388 specify buffer/string position and length are now ssize_t and
2389 size_t. Return type is regoff_t.
2390
613052cd
BK
23912011-04-16 Ben Key <bkey76@gmail.com>
2392
2393 * nsfont.m: Fixed bugs in ns_get_family and
2394 ns_descriptor_to_entity that were caused by using free to
2395 deallocate memory blocks that were allocated by xmalloc (via
2396 xstrdup). This caused Emacs to crash when compiled with
2397 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2398 --enable-checking=xmallocoverrun). xfree is now used to
2399 deallocate these memory blocks.
2400
4170f62f 24012011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2402
71b41406
PE
2403 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2404
9587a89d
PE
2405 emacs_write: Accept and return EMACS_INT for sizes.
2406 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2407 et seq.
2408 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2409 Accept and return EMACS_INT.
2410 (emacs_gnutls_write): Return the number of bytes written on
2411 partial writes.
2412 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2413 (emacs_read, emacs_write): Remove check for negative size, as the
2414 Emacs source code has been audited now.
9587a89d
PE
2415 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2416 (emacs_read, emacs_write): Use it.
273a5f82
PE
2417 * process.c (send_process): Adjust to the new signatures of
2418 emacs_write and emacs_gnutls_write. Do not attempt to store
2419 a byte offset into an 'int'; it might overflow.
9587a89d 2420 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2421
3e047f51
PE
2422 * sound.c: Don't assume sizes fit in 'int'.
2423 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2424 Return EMACS_INT, not int.
3e047f51 2425 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2426 Accept EMACS_INT, not int.
2427 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2428 record read return values.
2429
cc39a9db
BK
24302011-04-15 Ben Key <bkey76@gmail.com>
2431
c9d0ec6d
JB
2432 * keyboard.c (Qundefined): Don't declare static since it is used
2433 in nsfns.m.
2434 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2435 static since they are used in nsfont.m.
cc39a9db 2436
6c60eb9f
SM
24372011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2438
2439 * process.c (Qprocessp): Don't declare static.
2440 * lisp.h (Qprocessp): Declare again.
2441
7990b61a
JB
24422011-04-15 Juanma Barranquero <lekktu@gmail.com>
2443
2444 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2445
5d4cb038
PE
24462011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2447
8bd7b830 2448 Improve C-level modularity by making more things 'static'.
cd64ea1d 2449
e3b27b31
PE
2450 Don't publish debugger-only interfaces to other modules.
2451 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2452 (verify_bytepos, count_markers): Move decls to the only modules
2453 that need them.
2454 * region-cache.h (pp_cache): Likewise.
2455 * window.h (check_all_windows): Likewise.
2456 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2457
5d4cb038
PE
2458 * sysdep.c (croak): Now static, if
2459 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2460 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2461
2462 * alloc.c (refill_memory_reserve): Now static if
2463 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2464 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2465
e87b6180
PE
2466 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2467 Define only if USE_LUCID.
2468
ac64929e
PE
2469 * xrdb.c (x_customization_string, x_rm_string): Now static.
2470
6f37259d
PE
2471 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2472 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2473
1683e3ab
PE
2474 * xdisp.c (draw_row_with_mouse_face): Now static.
2475 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2476
de9c2632
PE
2477 * window.h (check_all_windows): Mark externally visible.
2478
2b96acb7
PE
2479 * window.c (window_deletion_count): Now static.
2480
2481 * undo.c: Make symbols static if they're not exported.
2482 (last_undo_buffer, last_boundary_position, pending_boundary):
2483 Now static.
2484
50436f33
PE
2485 * textprop.c (interval_insert_behind_hooks): Now static.
2486 (interval_insert_in_front_hooks): Likewise.
2487
64520e5c
PE
2488 * term.c: Make symbols static if they're not exported.
2489 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2490 (max_frame_lines, tty_set_terminal_modes):
2491 (tty_reset_terminal_modes, tty_turn_off_highlight):
2492 (get_tty_terminal): Now static.
2493 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2494 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2495 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2496 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2497 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2498
1fa53021
PE
2499 * sysdep.c: Make symbols static if they're not exported.
2500 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2501 Now static.
2502 (sigprocmask_set, full_mask): Remove; unused.
2503 (wait_debugging): Mark as visible.
2504 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2505 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2506
d4b43b22
PE
2507 * syntax.c (syntax_temp): Define only if !__GNUC__.
2508
b7c513d0
PE
2509 * sound.c (current_sound_device, current_sound): Now static.
2510
989b29ad
PE
2511 * search.c (searchbufs, searchbuf_head): Now static.
2512
13a55a78
PE
2513 * scroll.c (scroll_cost): Remove; unused.
2514 * dispextern.h (scroll_cost): Remove decl.
2515
de68a1fc
PE
2516 * region-cache.h (pp_cache): Mark as externally visible.
2517
40ccffa6
PE
2518 * process.c: Make symbols static if they're not exported.
2519 (process_tick, update_tick, create_process, chan_process):
2520 (Vprocess_alist, proc_buffered_char, datagram_access):
2521 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2522 (deactivate_process): Mark defn as static, as well as decl.
2523 * lisp.h (create_process): Remove decl.
2524 * process.h (chan_process, Vprocess_alist): Remove decls.
2525
ad64fc97
PE
2526 * print.c: Make symbols static if they're not exported.
2527 (print_depth, new_backquote_output, being_printed, print_buffer):
2528 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2529 (print_interval, print_number_index, initial_stderr_stream):
2530 Now static.
2531 * lisp.h (Fprinc): Remove decl.
2532 (debug_output_compilation_hack): Mark as externally visible.
2533
adddb265
PE
2534 * sysdep.c (croak): Move decl from here to syssignal.h.
2535 * syssignal.h (croak): Put it here, so the API can be checked when
2536 'croak' is called from dissociate_if_controlling_tty.
2537
1717ede2
PE
2538 * minibuf.c: Make symbols static if they're not exported.
2539 (minibuf_save_list, choose_minibuf_frame): Now static.
2540 * lisp.h (choose_minibuf_frame): Remove decl.
2541
fa5fb2bc
PE
2542 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2543
1e3890d1
PE
2544 * lread.c: Make symbols static if they're not exported.
2545 (read_objects, initial_obarray, oblookup_last_bucket_number):
2546 Now static.
2547 (make_symbol): Remove; unused.
2548 * lisp.h (initial_obarray, make_symbol): Remove decls.
2549
8a1414fa
PE
2550 * keyboard.c: Make symbols static if they're not exported.
2551 (single_kboard, recent_keys_index, total_keys, recent_keys):
2552 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2553 (this_single_command_key_start, echoing, last_auto_save):
2554 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2555 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2556 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2557 (Vlispy_mouse_stem, double_click_count):
2558 Now static.
2559 (force_auto_save_soon): Define only if SIGDANGER.
2560 (ignore_mouse_drag_p): Now static if
2561 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2562 (print_help): Remove; unused.
2563 (stop_character, last_timer_event): Mark as externally visible.
2564 * keyboard.h (ignore_mouse_drag_p): Declare only if
2565 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2566 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2567 * lisp.h (echoing): Remove decl.
2568 (force_auto_save_soon): Declare only if SIGDANGER.
2569 * xdisp.c (redisplay_window): Simplify code, to make it more
2570 obvious that ignore_mouse_drag_p is not accessed if !defined
2571 USE_GTK && !defined HAVE_NS.
2572
93ea6e8f
PE
2573 * intervals.c: Make symbols static if they're not exported.
2574 (merge_properties_sticky, merge_interval_right, delete_interval):
2575 Now static.
2576 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2577
77382fcc
PE
2578 * insdel.c: Make symbols static if they're not exported.
2579 However, leave prepare_to_modify_buffer alone. It's never
2580 called from outside this function, but that appears to be a bug.
2581 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2582 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2583 (adjust_after_replace_noundo): Remove; unused.
2584 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2585 (signal_before_change): Remove decls.
77382fcc 2586
9306c32e
PE
2587 * indent.c (val_compute_motion, val_vmotion): Now static.
2588
cd44d2eb
PE
2589 * image.c: Make symbols static if they're not exported.
2590 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2591 if USE_GTK.
2592 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2593 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2594
ad9a7a06
PE
2595 * fringe.c (standard_bitmaps): Now static.
2596 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2597
81626931
PE
2598 * frame.c: Make symbols static if they're not exported.
2599 (x_report_frame_params, make_terminal_frame): Now static.
2600 (get_frame_param): Now static, unless HAVE_NS.
2601 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2602 (x_get_resource_string): Remove; not used.
2603 * frame.h (make_terminal_frame, x_report_frame_params):
2604 (x_get_resource_string); Remove decls.
2605 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2606 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2607
239f9db9
PE
2608 * font.c, fontset.c: Make symbols static if they're not exported.
2609 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2610 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2611 * font.c (font_close_object): Now static.
2612 * font.h (font_close_object): Remove.
2613 * fontset.c (FONTSET_OBJLIST): Remove.
2614 (free_realized_fontset) #if-0 the body, which does nothing.
2615 (face_suitable_for_char_p): #if-0, as it's never called.
2616 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2617 * xfaces.c (face_at_string_position):
2618 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2619 since 0 is always ASCII.
2620
dfcf3579
PE
2621 * fns.c (weak_hash_tables): Now static.
2622
5045092b
PE
2623 * fileio.c: Make symbols static if they're not exported.
2624 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2625 (Vwrite_region_annotation_buffers): Now static.
2626
57a96f5c
PE
2627 * eval.c: Make symbols static if they're not exported.
2628 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2629 * lisp.h (backtrace_list): Remove decl.
2630
35f08c38
PE
2631 * emacs.c: Make symbols static if they're not exported.
2632 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2633 (fatal_error_code, fatal_error_signal_hook, standard_args):
2634 Now static.
2635 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2636 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2637 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2638 * lisp.h (fatal_error_signal_hook): Remove decl.
2639 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2640
f44bd759
PE
2641 * editfns.c: Move a (normally-unused) function to its only use.
2642 * editfns.c, lisp.h (get_operating_system_release): Remove.
2643 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2644 worth the hassle of breaking this out.
2645
b532497d
PE
2646 * xterm.c: Make symbols static if they're not exported.
2647 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2648 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2649 (x_destroy_window, x_delete_display):
2650 Now static.
2651 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2652 (x_mouse_leave): Remove; unused.
2653 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2654 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2655 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2656 Remove decls.
2657 (x_mouse_leave): Declare only if WINDOWSNT.
2658 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2659 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2660 USE_X_TOOLKIT.
2661
1675728f
PE
2662 * ftxfont.c: Make symbols static if they're not exported.
2663 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2664 HAVE_FREETYPE.
2665 * font.h (ftxfont_driver): Likewise.
2666
e4cebfca
PE
2667 * xfns.c: Make symbols static if they're not exported.
2668 (x_last_font_name, x_display_info_for_name):
2669 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2670 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2671 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2672 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2673 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2674 (last_show_tip_args): Now static.
2675 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2676 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2677 (x_screen_planes): Remove; unused.
2678 * dispextern.h (x_screen_planes): Remove decl.
2679
5bf46f05
PE
2680 * dispnew.c: Make symbols static if they're not exported.
2681 * dispextern.h (redraw_garbaged_frames, scrolling):
2682 (increment_row_positions): Remove.
2683 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2684 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2685 Now static.
2686 (redraw_garbaged_frames): Remove; unused.
2687
435f4c28
PE
2688 * xfaces.c: Make symbols static if they're not exported.
2689 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2690 Remove decls.
2691 * xterm.h (defined_color): Remove decls.
2692 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2693 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2694 (menu_face_changed_default, defined_color, free_realized_face):
2695 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2696 (ascii_face_of_lisp_face): Remove; unused.
2697
8524aef3
PE
2698 * xdisp.c: Make symbols static if they're not exported.
2699 * dispextern.h (scratch_glyph_row, window_box_edges):
2700 (glyph_to_pixel_coords, set_cursor_from_row):
2701 (get_next_display_element, set_iterator_to_next):
2702 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2703 (show_mouse_face): Remove decls
2704 * frame.h (message_buf_print): Likewise.
2705 * lisp.h (pop_message, set_message, check_point_in_composition):
2706 Likewise.
2707 * xterm.h (set_vertical_scroll_bar): Likewise.
2708 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2709 (message_buf_print, scratch_glyph_row, displayed_buffer):
2710 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2711 (get_next_display_element, show_mouse_face, window_box_edges):
2712 (frame_to_window_pixel_xy, check_point_in_composition):
2713 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2714 (glyph_to_pixel_coords): Remove; unused.
2715
16390cd2
PE
2716 * dired.c (file_name_completion): Now static.
2717
2718 * dbusbind.c (xd_in_read_queued_messages): Now static.
2719
a25f4dfa
PE
2720 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2721 * data.c (circular_list_error): Remove.
2722
14a9c8df
PE
2723 * commands.h (last_point_position, last_point_position_buffer):
2724 (last_point_position_window): Remove decls.
2725 * keyboard.c: Make these variables static.
2726
04f2d78b
CB
2727 * coding.h (coding, code_convert_region, encode_coding_gap):
2728 Remove decls.
74ab6df5
PE
2729 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2730 (iso_code_class, detect_coding, code_convert_region): Now static.
2731 (encode_coding_gap): Remove; unused.
2732
38dfbee1
PE
2733 * chartab.c (chartab_chars, chartab_bits): Now static.
2734
a2cb4e63
PE
2735 * charset.h (charset_iso_8859_1): Remove decl.
2736 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2737 Now static.
2738
127198fd
PE
2739 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2740 * ccl.c (Vccl_program_table): Now static.
2741 (check_ccl_update): Remove; unused.
2742
d85b608f
PE
2743 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2744 * category.h: ... from here.
2745 * category.c (check_category_table, set_category_set): Now static.
2746
31cd66f3
PE
2747 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2748 * lisp.h: Remove these decls.
2749
c358e587
PE
2750 * buffer.c (buffer_count): Remove unused var.
2751
e78aecca
PE
2752 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2753 so that it's not optimized away.
2754 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2755 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2756 exported only to the debugger.
2757
e192d7d3 2758 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2759 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2760
92470028
PE
2761 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2762 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2763 was inaccessible from Lisp.
2764 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2765 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2766
244ed907
PE
2767 alloc.c: Import and export fewer symbols, and remove unused items.
2768 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2769 is defined.
2770 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2771 it's not optimized away by whole-program optimization.
2772 (message_enable_multibyte, free_misc): Remove.
2773 (catchlist, handlerlist, mark_backtrace):
2774 Declare only if BYTE_MARK_STACK.
2775 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2776 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2777 (message_enable_multibyte): Remove decl.
2778 (free_misc, interval_free_list, float_block, float_block_index):
2779 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2780 (cons_free_list, last_marked_index):
2781 Now static.
2782 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2783 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2784 (mark_backtrace): Define only if BYTE_MARK_STACK.
2785 * xdisp.c (message_enable_multibyte): Now static.
2786
61c2b50e 2787 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2788 This makes it easier for human readers (and static analyzers)
2789 to see whether these variables are used from other modules.
2790 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2791 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2792 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2793 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2794 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2795 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2796 * xmenu.c, xselect.c:
2797 Declare Q* vars static if they are not used in other modules.
2798 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2799 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2800 Remove decls of unexported vars.
2801 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2802
95c82688
PE
2803 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2804
16a97296
PE
2805 Make Emacs functions such as Fatom 'static' by default.
2806 This makes it easier for human readers (and static analyzers)
2807 to see whether these functions can be called from other modules.
2808 DEFUN now defines a static function. To make the function external
2809 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2810 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2811 (Finit_image_library):
16a97296
PE
2812 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2813 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2814 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2815 Remove decls, since these functions are now static.
2816 (Funintern, Fget_internal_run_time): New decls, since these functions
2817 were already external.
95c82688 2818
16a97296
PE
2819 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2820 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2821 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2822 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2823 * keyboard.c, keymap.c, lread.c:
2824 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2825 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2826 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2827 Mark functions with DEFUE instead of DEFUN,
2828 if they are used in other modules.
2829 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2830 decls for now-static functions.
2831 * buffer.h (Fdelete_overlay): Remove decl.
2832 * callproc.c (Fgetenv_internal): Mark as internal.
2833 * composite.c (Fremove_list_of_text_properties): Remove decl.
2834 (Fcomposition_get_gstring): New forward static decl.
2835 * composite.h (Fcomposite_get_gstring): Remove decl.
2836 * dired.c (Ffile_attributes): New forward static decl.
2837 * doc.c (Fdocumntation_property): New forward static decl.
2838 * eval.c (Ffetch_bytecode): New forward static decl.
2839 (Funintern): Remove extern decl; now in .h file where it belongs.
2840 * fileio.c (Fmake_symbolic_link): New forward static decl.
2841 * image.c (Finit_image_library): New forward static decl.
2842 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2843 * intervals.h (Fprevious_property_change):
2844 (Fremove_list_of_text_properties): Remove decls.
2845 * keyboard.c (Fthis_command_keys): Remove decl.
2846 (Fcommand_execute): New forward static decl.
2847 * keymap.c (Flookup_key): New forward static decl.
2848 (Fcopy_keymap): Now static.
2849 * keymap.h (Flookup_key): Remove decl.
2850 * process.c (Fget_process): New forward static decl.
2851 (Fprocess_datagram_address): Mark as internal.
2852 * syntax.c (Fsyntax_table_p): New forward static decl.
2853 (skip_chars): Remove duplicate decl.
2854 * textprop.c (Fprevious_property_change): New forward static decl.
2855 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2856 Now internal.
2857 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2858 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2859
785bbd42
PE
2860 * editfns.c (Fformat): Remove unreachable code.
2861
8b913b57
AS
28622011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2863
2864 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2865 change. (Bug#8496)
2866
a6744a35
EZ
28672011-04-13 Eli Zaretskii <eliz@gnu.org>
2868
2869 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2870 when at ZV. (Bug#8487)
2871
e7974947
AS
28722011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2873
baad03f0
AS
2874 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2875 (Bug#8437)
2876 * keyboard.c (parse_tool_bar_item): Likewise.
2877 * sound.c (sound_cleanup, alsa_close): Likewise.
2878 * termcap.c (tgetent): Likewise.
2879 * xfns.c (x_default_font_parameter): Likewise.
2880 * xsettings.c (read_and_apply_settings): Likewise.
2881
e7974947
AS
2882 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2883 (overrun_check_free): Protoize.
2884
28272684
PE
28852011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2888 since callers should never pass a negative size.
2889 Change the signature to match that of plain 'read' and 'write'; see
2890 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2891 * lisp.h: Update prototypes of emacs_write and emacs_read.
2892
11997c76
EZ
28932011-04-11 Eli Zaretskii <eliz@gnu.org>
2894
2895 * xdisp.c (redisplay_window): Don't try to determine the character
2896 position of the scroll margin if the window start point w->startp
e896f03c 2897 is outside the buffer's accessible region. (Bug#8468)
11997c76 2898
8a2cbd72
EZ
28992011-04-10 Eli Zaretskii <eliz@gnu.org>
2900
2901 Fix write-region and its subroutines for buffers > 2GB.
2902 * fileio.c (a_write, e_write): Modify declaration of arguments and
2903 local variables to support buffers larger than 2GB.
2904 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2905
2906 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2907 argument, local variables, and return value.
2908
2909 * lisp.h: Update prototypes of emacs_write and emacs_read.
2910
2911 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2912
4073e537 29132011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2914
1ebfdcb6
PE
2915 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2916
b2ded58d
PE
2917 Fix more problems found by GCC 4.6.0's static checks.
2918
7d66342c
PE
2919 * xdisp.c (vmessage): Use a better test for character truncation.
2920
bbf47d44
PE
2921 * charset.c (load_charset_map): <, not <=, for optimization,
2922 and to avoid potential problems with integer overflow.
9248994d 2923 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2924 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2925 * editfns.c (Fformat): Likewise.
1e69125e 2926 * syntax.c (skip_chars): Likewise.
3befa583 2927
e3019616
PE
2928 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2929 This also lets GCC 4.6.0 generate slightly better loop code.
2930
becfa255
PE
2931 * callint.c (Fcall_interactively): <, not <=, for optimization.
2932 (Fcall_interactively): Count the number of arguments produced,
2933 not the number of arguments given. This is simpler and lets GCC
2934 4.6.0 generate slightly better code.
2935
dae0cd48
PE
2936 * ftfont.c: Distingish more carefully between FcChar8 and char.
2937 The previous code passed unsigned char * to a functions like
2938 strlen and xstrcasecmp that expect char *, which does not
2939 conform to the C standard.
2940 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2941 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2942 char * when the C standard requires it.
2943
76032d70
PE
2944 * keyboard.c (read_char): Remove unused var.
2945
eb3f1cc8
PE
2946 * eval.c: Port to Windows vsnprintf (Bug#8435).
2947 Include <limits.h>.
2948 (SIZE_MAX): Define if the headers do not.
2949 (verror): Do not give up if vsnprintf returns a negative count.
2950 Instead, grow the buffer. This ports to Windows vsnprintf, which
2951 does not conform to C99. Problem reported by Eli Zaretskii.
2952 Also, simplify the allocation scheme, by avoiding the need for
2953 calling realloc, and removing the ALLOCATED variable.
2954
70476b54
PE
2955 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2956
12020a9e
PE
2957 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2958 But keep the doprint source code for now, as we might revamp it
2959 and use it again (Bug#8435).
ea6c7ae6
PE
2960 * lisp.h (doprnt): Remove.
2961 * Makefile.in (base_obj): Remove doprnt.o.
2962 * deps.mk (doprnt.o): Remove.
2963
5fdb398c
PE
2964 error: Print 32- and 64-bit integers portably (Bug#8435).
2965 Without this change, on typical 64-bit hosts error ("...%d...", N)
2966 was used to print both 32- and 64-bit integers N, which relied on
2967 undefined behavior.
2968 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2969 New macro.
2970 * lisp.h (error, verror): Mark as printf-like functions.
2971 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2972 Report overflow in size calculations when allocating printf buffer.
2973 Do not truncate output string at its first null byte.
2974 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2975 Truncate the output at a character boundary, since vsnprintf does not
2976 do that.
2977 * charset.c (check_iso_charset_parameter): Convert internal
2978 character to string before calling 'error', since %c now has the
2979 printf meaning.
2980 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2981 overflow when computing char to be passed to 'error'. Do not
2982 pass Lisp_Object to 'error'; pass the integer instead.
2983 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2984 formatted with plain %d.
2985
b189fa66
PE
2986 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2987
bff87ef0
PE
2988 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2989
7e2cac20
PE
2990 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2991
ce4d90b5
PE
2992 * xterm.c (x_catch_errors): Remove duplicate declaration.
2993
266c9547
PE
2994 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2995
79c49ad2
PE
2996 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2997
368f4090
JM
29982011-04-10 Jim Meyering <meyering@redhat.com>
2999
3000 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3001 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3002 return ssize_t not "int", and use size_t as the buffer length.
3003 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3004 * gnutls.h: Update declarations.
3005 * process.c (read_process_output): Use ssize_t, to match.
3006 (send_process): Likewise.
3007
a32d4040
CY
30082011-04-09 Chong Yidong <cyd@stupidchicken.com>
3009
3010 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3011
8546720e 30122011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3013
04f2d78b
CB
3014 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3015 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3016
8546720e
GM
3017 * xterm.c (handle_one_xevent):
3018 * xmenu.c (create_and_show_popup_menu):
3019 * xselect.c (x_decline_selection_request)
3020 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3021
0a2f5c1a 30222011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3023
3024 Fix some uses of `int' instead of EMACS_INT.
3025 * search.c (string_match_1, fast_string_match)
3026 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3027 (scan_buffer, find_next_newline_no_quit)
3028 (find_before_next_newline, search_command, Freplace_match)
3029 (Fmatch_data): Make some `int' variables be EMACS_INT.
3030
3031 * xdisp.c (display_count_lines): 3rd argument and return value now
3032 EMACS_INT. All callers changed.
3033 (pint2hrstr): Last argument is now EMACS_INT.
3034
3035 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3036 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3037 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3038 (decode_coding_utf_16, decode_coding_emacs_mule)
3039 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3040 (decode_coding_ccl, decode_coding_charset)
3041 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3042 (decode_coding_iso_2022, decode_coding_emacs_mule)
3043 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3044 <char_offset, last_offset>: Declare EMACS_INT.
3045 (encode_coding_utf_8, encode_coding_utf_16)
3046 (encode_coding_emacs_mule, encode_invocation_designation)
3047 (encode_designation_at_bol, encode_coding_iso_2022)
3048 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3049 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3050 Declare EMACS_INT.
3051 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3052 (encode_invocation_designation): Last argument P_NCHARS is now
3053 EMACS_INT.
3054 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3055 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3056
3057 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3058 All users changed.
3059
3060 * ccl.c (Fccl_execute_on_string): Declare some variables
3061 EMACS_INT.
3062
8546720e 30632011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3064
3065 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3066
4e19a977
CS
30672011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3068
3069 * process.c (Fformat_network_address): Doc fix.
3070
87302331
R
30712011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3072
3073 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3074
cbb59342
CY
30752011-04-08 Chong Yidong <cyd@stupidchicken.com>
3076
3077 * keyboard.c (read_char): Call Lisp function help-form-show,
3078 instead of using internal_with_output_to_temp_buffer.
3079 (Qhelp_form_show): New var.
e0d38eeb 3080 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3081
3082 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3083
3084 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3085
e67a13ab
CY
30862011-04-06 Chong Yidong <cyd@stupidchicken.com>
3087
04f2d78b
CB
3088 * process.c (Flist_processes): Remove to Lisp.
3089 (list_processes_1): Delete.
e67a13ab 3090
973f782d
EZ
30912011-04-06 Eli Zaretskii <eliz@gnu.org>
3092
7c106b1e
EZ
3093 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3094
973f782d
EZ
3095 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3096
41cf7d1a 30972011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3098
ca23cc88
PE
3099 Fix more problems found by GCC 4.6.0's static checks.
3100
f390e2d5
PE
3101 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3102
42eea0d0
PE
3103 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3104
b69769da 3105 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3106
f9541e84
PE
3107 * xdisp.c (vmessage): Mark as a printf-like function.
3108
13841b55
PE
3109 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3110
c136c10f
PE
3111 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3112
5e2d4a30
PE
3113 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3114 printf-like functions.
3115 (tiff_load): Add casts to remove these marks before passing them
3116 to system-supplied API.
3117
583f48b9
PE
3118 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3119
b25d760e
PE
3120 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3121 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3122 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3123 directly, rather than having caller test rule sign. This avoids
3124 some unnecessary tests.
3125 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3126 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3127 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3128
bc7b6697 3129 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3130 (xfont_open): Avoid unnecessary tests.
bc7b6697 3131
27ccc379
PE
3132 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3133
dcd5c89a
PE
3134 * composite.h, composite.c (composition_gstring_put_cache):
3135 Use EMACS_INT, not int, for length.
3136
b13a45c6
PE
3137 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3138 breaking out part of COMPOSITION_DECODE_RULE.
3139 (COMPOSITION_DECODE_RULE): Use it.
3140 * composite.c (get_composition_id): Remove unused local vars,
3141 by using the new macro.
3142
1e792e4d
PE
3143 * textprop.c (set_text_properties_1): Change while to do-while,
3144 since the condition is always true at first.
3145
dc6c6455 3146 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3147 (interval_deletion_adjustment): Return unsigned value.
3148 All uses changed.
dc6c6455 3149
aba7731a
PE
3150 * process.c (list_processes_1, create_pty, read_process_output):
3151 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3152 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3153 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3154 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3155 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3156
fdfc4bf3
PE
3157 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3158
fca8fe46 3159 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3160 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3161
06a0259a 3162 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3163 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3164 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3165
e7b9e80f
PE
3166 * print.c (print_error_message): Avoid int overflow.
3167
56201685
PE
3168 * font.c (font_list_entities): Redo for clarity,
3169 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3170
78834453 3171 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3172 (font_score): Avoid potential overflow in diff calculation.
78834453 3173
0bc0b309 3174 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3175 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3176
e610eaca
PE
3177 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3178
b895abce
PE
3179 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3180 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3181 can always succeed if overflow has undefined behavior.
3182
1f1d9321 3183 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3184 (wordify): Omit three unnecessary tests.
1f1d9321 3185
c59478bc
PE
3186 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3187 All callers changed. This avoids the need for an unused var.
3188
79b73827
PE
3189 * casefiddle.c (casify_region): Remove var that is set but not used.
3190
a4db5dfe
PE
3191 * dired.c (file_name_completion): Remove var that is set but not used.
3192
43aae36e
PE
3193 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3194
2a47c44d 3195 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3196 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3197
a37c69bf
PE
3198 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3199 Check for integer overflow on size calculations.
3200
328ab8e7
PE
3201 * buffer.c (Fprevious_overlay_change): Remove var that is set
3202 but not used.
3203
e5a2a5cb
PE
3204 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3205 Remove vars that are set but not used.
8d84a6eb 3206 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3207 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3208
a60e5f68
PE
3209 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3210
f661cb61 3211 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3212 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3213
f0397f5a
PE
3214 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3215 that are set but not used.
3216
8664db06 3217 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3218 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3219
6abdaa4a
PE
3220 * xselect.c (x_get_local_selection, x_handle_property_notify):
3221 Remove vars that are set but not used.
3222
0ce7538d 3223 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3224 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3225
9ae848fc
PE
3226 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3227 Remove var that is set but not used.
0b918413
PE
3228 (scroll_bar_windows_size): Now size_t, not int.
3229 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3230 Check for overflow.
9ae848fc 3231
a5a62657
PE
3232 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3233 (map_tty_color) [!defined MSDOS]: Likewise.
3234
5c5cdd39
PE
3235 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3236
66ebf983
PE
3237 * coding.c: Remove vars that are set but not used.
3238 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3239 All callers changed.
3240 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3241 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3242 (decode_coding_charset): Remove vars that are set but not used.
3243
1be4d761
PE
3244 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3245 that is set but not used.
3246
47553fa8
PE
3247 * print.c (print_object): Remove var that is set but not used.
3248
1f7196bf 3249 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3250 The gnulib version avoids calling malloc in the usual case,
3251 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3252 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3253 * filelock.c (current_lock_owner): Likewise.
3254 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3255 * sysdep.c: Include allocator.h, careadlinkat.h.
3256 (emacs_no_realloc_allocator): New static constant.
3257 (emacs_readlink): New function.
fdb61804
PE
3258 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3259 ../lib/careadlinkat.h.
d1fdcab7 3260
f84c17c7
SM
32612011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3262
3263 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3264 first non-nil return value).
3265
ef3862ad
JD
32662011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3267
3268 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3269 if not defined (Bug#8403).
3270
376a7006
JB
32712011-04-02 Juanma Barranquero <lekktu@gmail.com>
3272
3273 * xdisp.c (display_count_lines): Remove parameter `start',
3274 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3275 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3276 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3277 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3278 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3279 and thereabouts. All callers changed.
3280 (get_per_char_metric): Remove parameter `f', unused since
3281 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3282
6ca3801d
JM
32832011-04-02 Jim Meyering <meyering@redhat.com>
3284
3285 do not dereference NULL upon failed strdup
3286 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3287 (ns_get_family): Likewise.
3288
d8e2b5ba
JB
32892011-04-02 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3292
8c74fcbd
JD
32932011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3294
3295 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3296 later (Bug#8403).
3297
7200d79c
SM
32982011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3299
03408648 3300 Add lexical binding.
7200d79c 3301
03408648
SM
3302 * window.c (Ftemp_output_buffer_show): New fun.
3303 (Fsave_window_excursion):
3304 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3305
3306 * lread.c (lisp_file_lexically_bound_p): New function.
3307 (Fload): Bind Qlexical_binding.
3308 (readevalloop): Remove `evalfun' arg.
3309 Bind Qinternal_interpreter_environment.
3310 (Feval_buffer): Bind Qlexical_binding.
3311 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3312 Mark as dynamic.
3313 (syms_of_lread): Declare `lexical-binding'.
3314
3315 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3316
3317 * keyboard.c (eval_dyn): New fun.
3318 (menu_item_eval_property): Use it.
ca105506
SM
3319
3320 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3321
03408648
SM
3322 * fns.c (concat, mapcar1): Accept byte-code-functions.
3323
3324 * eval.c (Fsetq): Handle lexical vars.
3325 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3326 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3327 (FletX, Flet): Obey lexical binding.
3328 (Fcommandp): Handle closures.
3329 (Feval): New `lexical' arg.
3330 (eval_sub): New function extracted from Feval. Use it almost
3331 everywhere where Feval was used. Look up vars in lexical env.
3332 Handle closures.
3333 (Ffunctionp): Move from subr.el.
3334 (Ffuncall): Handle closures.
3335 (apply_lambda): Remove `eval_flags'.
3336 (funcall_lambda): Handle closures and new byte-code-functions.
3337 (Fspecial_variable_p): New function.
3338 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3339 but without exporting it to Lisp.
23aba0ea 3340
23aba0ea 3341 * doc.c (Fdocumentation, store_function_docstring):
03408648 3342 * data.c (Finteractive_form): Handle closures.
23aba0ea 3343
03408648
SM
3344 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3345 interactive spec.
ba83908c 3346
04f2d78b
CB
3347 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3348 New byte-codes.
03408648
SM
3349 (exec_byte_code): New function extracted from Fbyte_code to handle new
3350 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3351
03408648 3352 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3353
03408648 3354 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3355
e2abce01
JB
33562011-03-31 Juanma Barranquero <lekktu@gmail.com>
3357
3358 * xdisp.c (redisplay_internal): Fix prototype.
3359
63696a73 33602011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3361
63696a73 3362 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3363 (try_scrolling): Use it when setting scroll_limit.
3364 Limit scrolling to 100 screen lines.
63696a73
EZ
3365 (redisplay_window): Even when falling back on "recentering",
3366 position point in the window according to scroll-conservatively,
3367 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3368
3369 (try_scrolling): When point is above the window, allow searching
3370 as far as scroll_max, or one screenful, to compute vertical
3371 distance from PT to the scroll margin position. This prevents
3372 try_scrolling from unnecessarily failing when
3373 scroll-conservatively is set to a value slightly larger than the
3374 window height. Clean up the case of PT below the margin at bottom
3375 of window: scroll_max can no longer be INT_MAX. When aggressive
3376 scrolling is in use, don't let point enter the opposite scroll
3377 margin as result of the scroll.
3378 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3379 threshold of 100 lines for never-recentering scrolling.
3380
e4cc2dfc
JB
33812011-03-31 Juanma Barranquero <lekktu@gmail.com>
3382
3383 * dispextern.h (move_it_by_lines):
3384 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3385 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3386 (message_log_check_duplicate): Remove parameters `prev_bol' and
3387 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3388 (redisplay_internal): Remove parameter `preserve_echo_area',
3389 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3390
3391 * indent.c (Fvertical_motion):
3392 * window.c (window_scroll_pixel_based, Frecenter):
3393 Don't pass `need_y_p' to `move_it_by_lines'.
3394
1c470562
SM
33952011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3396
44f230aa
SM
3397 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3398 steal a few bits to be more compact.
3399 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3400 Remove unneeded casts.
3401
1c470562
SM
3402 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3403
888adce9
ZK
34042011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3405
3406 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3407 binding" message (bug#7967).
3408
f838ed7b
PE
34092011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3410
77861b95
PE
3411 Fix more problems found by GCC 4.6.0's static checks.
3412
de6dbc14
PE
3413 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3414 Remove unused local var.
3415
f838ed7b
PE
3416 * editfns.c (Fmessage_box): Remove unused local var.
3417
792c7b2b
PE
3418 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3419 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3420 Omit unused local vars.
c499e557 3421 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3422 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3423 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3424 Omit unused local var.
3425
ba0165e1
PE
3426 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3427 Don't assume string length fits in int.
32ad8845 3428 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3429 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3430
3c59b4c9
PE
3431 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3432 instead of alloca (Bug#8344).
3433
a3eed478 3434 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3435 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3436
eb4d412d
PE
3437 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3438
1658b401
PE
3439 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3440 concerns.
3441
3442 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3443
3444 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3445
9a2c6e05
PE
3446 * keyboard.c (syms_of_keyboard): Use the same style as later
3447 in this function when indexing through an array. This also
3448 works around GCC bug 48267.
3449
03d0a109
PE
3450 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3451
44f730c8
PE
3452 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3453
fe75f926
PE
3454 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3455 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3456
ffa8c828
PE
3457 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3458 This avoids undefined behavior on integer overflow, and is a bit
3459 more convenient anyway since it is compared to a size_t variable.
3460
c5101a77
PE
3461 Variadic C functions now count arguments with size_t, not int.
3462 This avoids an unnecessary limitation on 64-bit machines, which
3463 caused (substring ...) to crash on large vectors (Bug#8344).
3464 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3465 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3466 All variadic functions and their callers changed accordingly.
c5101a77
PE
3467 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3468 * data.c (arith_driver, float_arith_driver): Likewise.
3469 * editfns.c (general_insert_function): Likewise.
3470 * eval.c (struct backtrace.nargs, interactive_p)
3471 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3472 (funcall_lambda, mark_backtrace): Likewise.
3473 * fns.c (concat): Likewise.
3474 * frame.c (x_set_frame_parameters): Likewise.
3475 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3476 0 if not found, not -1. All callers changed.
3477
dd3f25f7
PE
3478 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3479 (stack_copy_size): Now size_t, not int.
3480 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3481
461c2ab9
JB
34822011-03-28 Juanma Barranquero <lekktu@gmail.com>
3483
3484 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3485 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3486 All callers changed.
3487
3488 * lisp.h (multibyte_char_to_unibyte):
3489 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3490 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3491 * character.h (CHAR_TO_BYTE8):
3492 * cmds.c (internal_self_insert):
3493 * editfns.c (general_insert_function):
3494 * keymap.c (push_key_description):
3495 * search.c (Freplace_match):
3496 * xdisp.c (message_dolog, set_message_1): All callers changed.
3497
f6d62986
SM
34982011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3499
3500 * keyboard.c (safe_run_hook_funcall): New function.
3501 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3502 don't set the hook to nil, but remove the offending function instead.
3503 (Qcommand_hook_internal): Remove, unused.
3504 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3505 Vcommand_hook_internal.
3506
3507 * eval.c (enum run_hooks_condition): Remove.
3508 (funcall_nil, funcall_not): New functions.
3509 (run_hook_with_args): Call each function through a `funcall' argument.
3510 Remove `cond' argument, now redundant.
3511 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3512 (Frun_hook_with_args_until_failure): Adjust accordingly.
3513 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3514
1db5b1ad
JB
35152011-03-28 Juanma Barranquero <lekktu@gmail.com>
3516
3517 * dispextern.h (string_buffer_position): Remove declaration.
3518
3519 * print.c (strout): Remove parameter `multibyte', unused since
3520 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3521
3522 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3523 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3524 All callers changed.
3525
3526 * w32.c (_wsa_errlist): Use braces for struct initializers.
3527
3528 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3529 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3530 All callers changed.
3531 (string_buffer_position): Likewise. Also, make static (it's never
3532 used outside xdisp.c).
3533 (cursor_row_p): Remove parameter `w', unused since
3534 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3535 (decode_mode_spec): Remove parameter `precision', introduced during
3536 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3537 All callers changed.
3538
5ffb62aa
JD
35392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3540
3541 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3542
461c2ab9 35432011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3544
3545 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3546 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3547 (ns_update_auto_hide_menu_bar): New functions.
3548 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3549 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3550 ns_constrain_all_frames.
3551 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3552 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3553
5c380ffb
JD
35542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3555
3556 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3557
9af30bdf
GM
35582011-03-27 Glenn Morris <rgm@gnu.org>
3559
3560 * syssignal.h: Replace RETSIGTYPE with void.
3561 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3562 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3563 Replace SIGTYPE with void everywhere.
3564 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3565 * s/template.h (SIGTYPE): Remove commented out definition.
3566
e2abce01
JB
35672011-03-26 Eli Zaretskii <eliz@gnu.org>
3568
3569 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3570 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3571
f868cd8a
JB
35722011-03-26 Juanma Barranquero <lekktu@gmail.com>
3573
59eb0929
JB
3574 * w32.c (read_unc_volume): Use parameter `henum', instead of
3575 global variable `wget_enum_handle'.
3576
3577 * keymap.c (describe_vector): Remove parameters `indices' and
3578 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3579 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3580
f868cd8a
JB
3581 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3582
3583 * keyboard.c (timer_check): Remove parameter `do_it_now',
3584 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3585 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3586 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3587
3588 * keyboard.c (read_char):
3589 * w32menu.c (w32_menu_display_help):
3590 * xmenu.c (show_help_event, menu_help_callback):
3591 Adjust calls to `show_help_echo'.
3592
3593 * gtkutil.c (xg_maybe_add_timer):
3594 * keyboard.c (readable_events):
3595 * process.c (wait_reading_process_output):
3596 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3597
3598 * insdel.c (adjust_markers_gap_motion):
3599 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3600 (gap_left, gap_right): Don't call it.
3601
2ecf6fdb
CY
36022011-03-25 Chong Yidong <cyd@stupidchicken.com>
3603
3604 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3605 incurred during fontification.
3606
6b1f9ba4
JB
36072011-03-25 Juanma Barranquero <lekktu@gmail.com>
3608
3609 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3610 (DEFVAR_PER_BUFFER): Don't pass it.
3611
3612 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3613 (scrolling_window): Don't pass it.
3614
0f4a96b5
JB
36152011-03-25 Juanma Barranquero <lekktu@gmail.com>
3616
3617 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3618
3619 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3620 and `suffix'.
3621 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3622 of variables specific to SELinux and computation of `encoded_absname'.
3623
3624 * image.c (XPutPixel): Remove unused variable `height'.
3625
3626 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3627
3628 * unexw32.c (get_section_info): Remove unused variable `section'.
3629
3630 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3631 (system_process_attributes): Remove unused variable `sess'.
3632 (sys_read): Remove unused variable `err'.
3633
3634 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3635 (w32_wnd_proc): Remove unused variable `isdead'.
3636 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3637 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3638 (x_create_tip_frame): Remove unused variable `tem'.
3639
3640 * w32inevt.c (w32_console_read_socket):
3641 Remove unused variable `no_events'.
3642
3643 * w32term.c (x_draw_composite_glyph_string_foreground):
3644 Remove unused variable `width'.
3645
1149507c
JB
36462011-03-24 Juanma Barranquero <lekktu@gmail.com>
3647
3648 * w32term.c (x_set_glyph_string_clipping):
3649 Don't pass uninitialized region to CombineRgn.
3650
9c88f339
JB
36512011-03-23 Juanma Barranquero <lekktu@gmail.com>
3652
3653 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3654 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3655 (Fx_close_connection): Remove unused variable `i'.
3656
3657 * w32font.c (w32font_draw): Return number of glyphs.
3658 (w32font_open_internal): Remove unused variable `i'.
3659 (w32font_driver): Add missing initializer.
3660
3661 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3662 (fill_in_menu): Remove unused variable `items_added'.
3663
3664 * w32term.c (last_mouse_press_frame): Remove static global variable.
3665 (w32_clip_to_row): Remove unused variable `f'.
3666 (x_delete_terminal): Remove unused variable `i'.
3667
3668 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3669 (NOTHING): Remove unused static global variable.
3670 (uniscribe_check_otf): Remove unused variable `table'.
3671 (uniscribe_font_driver): Add missing initializers.
3672
dee091a3
JD
36732011-03-23 Julien Danjou <julien@danjou.info>
3674
3675 * term.c (Fsuspend_tty, Fresume_tty):
3676 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3677 * window.c (temp_output_buffer_show):
3678 * insdel.c (signal_before_change):
3679 * frame.c (Fhandle_switch_frame):
3680 * fileio.c (Fdo_auto_save):
3681 * emacs.c (Fkill_emacs):
3682 * editfns.c (save_excursion_restore):
3683 * cmds.c (internal_self_insert):
3684 * callint.c (Fcall_interactively):
3685 * buffer.c (Fkill_all_local_variables):
3686 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3687 Use Frun_hooks.
0f4a96b5 3688 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3689 unconditionnaly since it does the check itself.
3690
2c520ab5 36912011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3692
c9c49752
PE
3693 Fix more problems found by GCC 4.5.2's static checks.
3694
8abc3f12
PE
3695 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3696 the first time through the loop, since we know p0 < p1 then.
3697 This also avoids a gcc -Wstrict-overflow warning.
3698
a2d26660
PE
3699 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3700 leading to a memory leak, possible in functions like
3701 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3702 of objects (Bug#8318).
a2d26660 3703
916c72e9
PE
3704 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3705 that could (at least in theory) be that large.
3706
19ab8a18
PE
3707 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3708 This is less likely to overflow, and avoids undefined behavior if
3709 overflow does occur. All callers changed. Use strtoul to scan
3710 for the unsigned long integer.
b7cbbd6f
PE
3711 (pint2hrstr): Simplify and tune code slightly.
3712 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3713
f0641eff
PE
3714 * scroll.c (do_scrolling): Work around GCC bug 48228.
3715 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3716
7f650bb9
PE
3717 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3718 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3719 (validate_x_resource_name): Simplify count usage.
3720 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3721
37dd57d1
PE
3722 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3723 fail (Bug#8306).
81e56e61 3724
699979fc 3725 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3726
401bf9b4
PE
3727 * process.c (Fmake_network_process): Use socklen_t, not int,
3728 where POSIX says socklen_t is required in portable programs.
3729 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3730 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3731 (Fmake_network_process, server_accept_connection):
3732 (wait_reading_process_output, read_process_output):
3733 Likewise.
3734
b93aacde
PE
3735 * process.c: Rename or move locals to avoid shadowing.
3736 (list_processes_1, Fmake_network_process):
3737 (read_process_output_error_handler, exec_sentinel_error_handler):
3738 Rename or move locals.
4dc343ee 3739 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3740 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3741 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3742 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3743 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3744
af8a867c 3745 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3746 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3747 Include tparam.h instead, since it declares them.
af8a867c
PE
3748 * cm.h (PC): Remove extern decl; tparam.h now does this.
3749 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3750 * terminfo.c: Include tparam.h, to check interfaces.
3751 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3752 (tparam): Adjust signature to match interface in tparam.h;
3753 this removes some undefined behavior. Check that outstring and len
3754 are zero, which they always are with Emacs.
3755 * tparam.h (PC, BC, UP): New extern decls.
3756
0248044d 3757 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3758 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3759
8ff096c1 3760 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3761 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3762 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3763 (ftfont_list): Remove unused local.
49eaafba
PE
3764 (get_adstyle_property, ftfont_pattern_entity):
3765 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3766 Rename locals to avoid shadowing.
8ff096c1 3767
e2be39f6
PE
3768 * xfont.c (xfont_list_family): Mark var as initialized.
3769
c9735e30
PE
3770 * xml.c (make_dom): Now static.
3771
8f5201ae
PE
3772 * composite.c (composition_compute_stop_pos): Rename local to
3773 avoid shadowing.
b246f932
PE
3774 (composition_reseat_it): Remove unused locals.
3775 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3776 (composition_update_it): Mark var as initialized.
11b61122
PE
3777 (find_automatic_composition): Mark vars as initialized,
3778 with a FIXME (Bug#8290).
8f5201ae 3779
760fbc2c
PE
3780 character.h: Rename locals to avoid shadowing.
3781 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3782 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3783 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3784 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3785 to avoid shadowing.
3786
ff08eb85
PE
3787 * textprop.c (property_change_between_p): Remove; unused.
3788
fc7bf025
PE
3789 * intervals.c (interval_start_pos): Now static.
3790
235d7abc
PE
3791 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3792
44f230aa
SM
3793 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3794 Rename locals to avoid shadowing.
3e7d6594 3795
50060332
PE
3796 * sound.c (wav_play, au_play, Fplay_sound_internal):
3797 Fix pointer signedness.
d01f234b 3798 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3799 (wav_play): Initialize a variable to 0, to prevent undefined
3800 behavior (Bug#8278).
50060332 3801
c4fc4e30
PE
3802 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3803
918436ed
PE
3804 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3805
c939f91b
PE
3806 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3807 clobbering (Bug#8298).
b9c7f648
PE
3808 * sysdep.c (sys_subshell): Likewise.
3809 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3810
6bd8c144
PE
3811 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3812 This should get cleaned up, so that child_setup has the
3813 same signature on all platforms.
3814
7710357c 3815 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3816 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3817
c59da222
CY
38182011-03-22 Chong Yidong <cyd@stupidchicken.com>
3819
3820 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3821 not to be necessary, and produces flickering.
3822
66b87493
GM
38232011-03-20 Glenn Morris <rgm@gnu.org>
3824
3825 * config.in: Remove file.
3826
45b6f6d5
JB
38272011-03-20 Juanma Barranquero <lekktu@gmail.com>
3828
3829 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3830 are now in src/globals.h.
3831 (syms_of_minibuf): Remove spurious & from previous change.
3832
3ec03f7e
LL
38332011-03-20 Leo <sdl.web@gmail.com>
3834
3835 * minibuf.c (completing-read-function): New variable.
3836 (completing-read-default): Rename from completing-read.
3837 (completing-read): Call completing-read-function.
3838
b14e3e21
CY
38392011-03-19 Juanma Barranquero <lekktu@gmail.com>
3840
3841 * xfaces.c (Fx_load_color_file):
3842 Read color file from absolute filename (bug#8250).
3843
f2b726e6
JB
38442011-03-19 Juanma Barranquero <lekktu@gmail.com>
3845
3846 * makefile.w32-in: Update dependencies.
3847
09f6ff02
EZ
38482011-03-17 Eli Zaretskii <eliz@gnu.org>
3849
3850 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3851
29a6015a
PE
38522011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3853
a3a6c54e
PE
3854 Fix more problems found by GCC 4.5.2's static checks.
3855
b766f867
PE
3856 * process.c (make_serial_process_unwind, send_process_trap):
3857 (sigchld_handler): Now static.
3858
be02381c
PE
3859 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3860 That way, the code declares only the vars that it needs.
3861 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3862 * s/cygwin.h (PTY_ITERATION): Likewise.
3863 * s/darwin.h (PTY_ITERATION): Likewise.
3864 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3865
57048744
PE
3866 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3867 * process.c (allocate_pty): Don't declare stb unless it's needed.
3868
7914961c 3869 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3870 (CONSTANTLIM): Remove; unused.
3871 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3872 Define only if needed.
7914961c 3873
b3967b18
PE
3874 * unexelf.c (unexec): Name an expression,
3875 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3876 Use a different way to cause a compilation error if anyone uses
3877 n rather than nn, a way that does not involve shadowing.
73366a00 3878 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3879
29a6015a
PE
3880 * deps.mk (unexalpha.o): Remove; unused.
3881
43cfc33e 3882 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3883 * unexec.h: New file.
ce701a33
PE
3884 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3885 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3886 Depend on unexec.h.
3887 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3888 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3889 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3890 Change as necessary to match prototype in unexec.h.
ce701a33 3891
01f44d5a
PE
3892 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3893 shadowing.
4f63c6bb 3894 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3895
a6670b0b
PE
3896 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3897 Rename locals to avoid shadowing.
3898
cef2010d 3899 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3900 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3901
d4d7173a
PE
3902 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3903
f08b802a
PE
3904 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3905 warning when compiling print.c.
3906
3ddb0639
PE
3907 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3908 instead of using an uninitialized var.
5ad03b97 3909 (font_sort_entities): Mark var as initialized.
3ddb0639 3910
170a2692
PE
3911 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3912
e663c700
PE
3913 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3914 pointers to constants.
89bc529a 3915 (font_parse_fcname): Remove unused vars.
7b81e2d0 3916 (font_delete_unmatched): Now static.
ea838e10 3917 (font_get_spec): Remove; unused.
13a547c6
PE
3918 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3919 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3920 Rename or move locals to avoid shadowing.
e663c700 3921
2a80c887 3922 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3923 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3924
1384fa33 3925 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3926 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3927
8b2c52e9
PE
3928 * alloc.c (mark_backtrace): Move decl from here ...
3929 * lisp.h: ... to here, so that it can be checked.
3930
475545b5 3931 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3932 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3933 (lisp_indirect_variable): Name an expression,
3934 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3935 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3936
b1349114 3937 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3938 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3939 Use const pointer when appropriate.
b1349114 3940
a2928364
PE
3941 * lisp.h (get_system_name, get_operating_system_release):
3942 Move decls here, to check interfaces.
3943 * process.c (get_operating_system_release): Move decl to lisp.h.
3944 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3945 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3946 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3947 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3948 (Fformat_time_string, Fencode_time, Finsert_char):
3949 (Ftranslate_region_internal, Fformat):
3950 Rename or remove local vars to avoid shadowing.
9710023e 3951 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3952
a415e694
PE
3953 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3954 avoid shadowing.
3955
8ef4622d
PE
3956 * lisp.h (eassert): Check that the argument compiles, even if
3957 ENABLE_CHECKING is not defined.
3958
946f9a5b
PE
3959 * data.c (Findirect_variable): Name an expression, to avoid
3960 gcc -Wbad-function-cast warning.
112396d6 3961 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3962 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3963 (Fmake_variable_buffer_local, Fmake_local_variable):
3964 Mark variables as initialized.
52746918 3965 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3966
e5aab7e7 3967 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3968 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3969 Rename locals to avoid shadowing.
dff45157
PE
3970 (mark_stack): Move local variables into the #ifdef region where
3971 they're used.
7bc26fdb
PE
3972 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3973 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3974 needed otherwise.
3975 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3976 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3977 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3978
e5aab7e7
PE
3979 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3980 avoids undefined behavior in theory.
3981
4da60324
PE
3982 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3983
88043301
PE
3984 Use functions, not macros, for up- and down-casing (Bug#8254).
3985 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3986 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3987 to use the following functions instead of these macros.
3988 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3989 EMACS_INT, since callers assume the returned value fits in int.
3990 (upcase1): Likewise, for UPCASE_TABLE.
3991 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3992 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3993 the race-condition problem in the old DOWNCASE.
88043301 3994
19ed5445
PE
3995 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3996 Rename locals to avoid shadowing.
3997 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3998 (regex_compile, re_search_2, re_match_2_internal):
3999 Remove unused local vars.
952db0d7
PE
4000 (FREE_VAR): Rewrite so as not to use empty "else",
4001 which gcc can warn about.
da053e48 4002 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4003 (RETALLOC_IF): Define only if needed.
4004 (WORDCHAR_P): Likewise. This one is never needed, but is used
4005 only in a comment talking about a compiler bug, so put inside
4006 the #if 0 of that comment.
4007 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4008 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4009 Remove; unused.
19ed5445 4010
1f3561e4 4011 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4012 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4013 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4014
ded6f8f7
PE
4015 * search.c (simple_search): Remove unused var.
4016
dbd37a95
PE
4017 * dired.c (compile_pattern): Move decl from here ...
4018 * lisp.h: ... to here, so that it can be checked.
4019 (struct re_registers): New forward decl.
4020
7e47afad
PE
4021 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4022
85f24f61
PE
4023 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4024 All uses changed.
4025 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4026 Rename locals to avoid shadowing.
5671df8f 4027 (Fvertical_motion): Mark locals as initialized.
85f24f61 4028
181aa2be 4029 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4030 (casify_region): Mark local as initialized.
181aa2be 4031
930d429c
PE
4032 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4033
7082eac6
PE
4034 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4035 New macros, so that the caller can use some names other than
4036 gcpro1, gcpro2, etc.
4037 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4038 of the new macros.
4039 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4040 argument, for consistency with GCPRO2_VAR, etc: it is now the
4041 prefix of the variable, not the variable itself. All uses
4042 changed.
38b2c076
PE
4043 * dired.c (directory_files_internal, file_name_completion):
4044 Rename locals to avoid shadowing.
4045
15206ed9
PE
4046 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4047 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4048 dired.c's scmp function, had undefined behavior.
4049 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4050 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4051 * buffer.h: ... to here, because these macros use current_buffer,
4052 and the new implementation with inline functions needs to have
4053 current_buffer in scope now, rather than later when the macros
4054 are used.
4055 (downcase, upcase1): New static inline functions.
4056 (DOWNCASE, UPCASE1): Reimplement using these functions.
4057 This avoids undefined behavior in expressions like
4058 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4059 from race conditions in accessing the global variables
4060 case_temp1 and case_temp2.
4061 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4062 * lisp.h (case_temp1, case_temp2): Remove their decls.
4063 * character.h (ASCII_CHAR_P): Move from here ...
4064 * lisp.h: ... to here, so that the inline functions mentioned
4065 above can use them.
4066
4a6bea26
PE
4067 * dired.c (directory_files_internal_unwind): Now static.
4068
f14b7e14
PE
4069 * fileio.c (file_name_as_directory, directory_file_name):
4070 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4071 Now static.
2893f146
PE
4072 (file_name_as_directory): Use const pointers when appropriate.
4073 (Fexpand_file_name): Likewise. In particular, newdir might
4074 point at constant storage, so make it a const pointer.
fd4ead52 4075 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4076 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4077 signedness issues.
f839df0c
PE
4078 (Fset_file_times, Finsert_file_contents, auto_save_error):
4079 Rename locals to avoid shadowing.
f14b7e14 4080
5716756e 4081 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4082 (Ftry_completion, Fall_completions): Rename or remove locals
4083 to avoid shadowing.
5716756e 4084
b4c3046a
PE
4085 * marker.c (bytepos_to_charpos): Remove; unused.
4086
b45db522
PE
4087 * lisp.h (verify_bytepos, count_markers): New decls,
4088 so that gcc does not warn that these functions aren't declared.
4089
85876d07
PE
4090 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4091 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4092 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4093 (copy_text): Remove unused local var.
85876d07 4094
03d78a21 4095 * filelock.c (within_one_second): Now static.
b3dd38ab 4096 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4097
5df8f01b
PE
4098 * buffer.c (fix_overlays_before): Mark locals as initialized.
4099 (fix_start_end_in_overlays): Likewise. This function should be
4100 simplified by using pointers-to-pointers, but that's a different
4101 matter.
b1d876f1 4102 (switch_to_buffer_1): Now static.
8f54f30a
PE
4103 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4104 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4105
a70072c9 4106 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4107 Fix pointer signedness issue.
edced198
PE
4108 (sys_subshell): Mark local as volatile if checking for lint,
4109 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4110 (MAXPATHLEN): Define only if needed.
a70072c9 4111
a0977c44
PE
4112 * process.c (serial_open, serial_configure): Move decls from here ...
4113 * systty.h: ... to here, so that they can be checked.
4114
a884fdcc
PE
4115 * fns.c (get_random, seed_random): Move extern decls from here ...
4116 * lisp.h: ... to here, so that they can be checked.
4117
604efe86 4118 * sysdep.c (reset_io): Now static.
b8950c94 4119 (wait_for_termination_signal): Remove; unused.
604efe86 4120
38fc62d9
PE
4121 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4122 (copy_keymap_item, append_key, push_text_char_description):
4123 Now static.
1004a21a 4124 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4125 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4126 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4127 (describe_map_tree):
4128 Rename locals to avoid shadowing.
38fc62d9 4129
2f2650da
PE
4130 * keyboard.c: Declare functions static if they are not used elsewhere.
4131 (echo_char, echo_dash, cmd_error, top_level_2):
4132 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4133 (read_char, kbd_buffer_get_event, make_lispy_position):
4134 (make_lispy_event, make_lispy_movement, apply_modifiers):
4135 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4136 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4137 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4138 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4139 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4140
a053e86c 4141 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4142 (mark_kboards): Move decl here ...
4143 * alloc.c (mark_kboards): ... from here.
a053e86c 4144
4752793e
PE
4145 * lisp.h (force_auto_save_soon): New decl.
4146
74f10ca7 4147 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4148 (DEFINE_DUMMY_FUNCTION): New macro.
4149 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4150 Use it.
c03cd23f
PE
4151 (main): Add casts to avoid warnings
4152 if GCC considers string literals to be constants.
74f10ca7 4153
022e70d4
PE
4154 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4155
59d6fe83
PE
4156 * dbusbind.c: Pointer signedness fixes.
4157 (xd_signature, xd_append_arg, xd_initialize):
4158 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4159 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4160 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4161 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4162
78320123
PE
4163 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4164 if GCC considers string literals to be constants.
49cebcca 4165 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4166
35ac2a97
SM
41672011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4168
fb103ca9
SM
4169 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4170 (print_preprocess, print_object): New macro to fix last change.
4171
35ac2a97
SM
4172 * print.c (print_preprocess): Don't forget font objects.
4173
62973b41
JB
41742011-03-16 Juanma Barranquero <lekktu@gmail.com>
4175
4176 * emacs.c (USAGE3): Doc fixes.
4177
0e48bb22
AS
41782011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4179
4180 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4181 structure.
4182
7684e57b
JB
41832011-03-14 Juanma Barranquero <lekktu@gmail.com>
4184
4185 * lisp.h (VWindow_system, Qfile_name_history):
4186 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4187 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4188 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4189
4190 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4191 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4192
4193 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4194 * w32console.c (detect_input_pending, read_input_pending)
4195 (encode_terminal_code):
4196 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4197 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4198 (w32_system_caret_y, Qfile_name_history):
4199 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4200 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4201 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4202 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4203 * w32proc.c (Qlocal, report_file_error):
4204 * w32term.c (Vwindow_system, updating_frame):
4205 * w32uniscribe.c (initialized, uniscribe_font_driver):
4206 Remove unneeded extern declarations.
4207
2aa46d6c
CY
42082011-03-14 Chong Yidong <cyd@stupidchicken.com>
4209
c96bbc66 4210 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4211
cffc6f3b
CY
42122011-03-13 Chong Yidong <cyd@stupidchicken.com>
4213
4214 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4215 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4216 These macros can no longer be used for assignment.
4217
44f230aa
SM
4218 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4219 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4220 (record_buffer_markers, fetch_buffer_markers): New functions for
4221 recording and fetching special buffer markers.
4222 (set_buffer_internal_1, set_buffer_temp): Use them.
4223
4224 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4225
4226 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4227
4228 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4229 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4230
4231 * xdisp.c (hscroll_window_tree):
4232 (reconsider_clip_changes): Use PT instead of BUF_PT.
4233
d251f04b
EZ
42342011-03-13 Eli Zaretskii <eliz@gnu.org>
4235
4236 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4237 $(EMACS_ROOT)/lib/intprops.h.
4238
f0c77cd1
PE
42392011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4240
3eca4629
PE
4241 Fix more problems found by GCC 4.5.2's static checks.
4242
7c86ee98
PE
4243 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4244 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4245 (xg_free_frame_widgets): Make it clear that a local variable is
4246 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4247 (gdk_window_get_screen): Make it clear that this macro is needed
4248 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4249 (int_gtk_range_get_value): New function, which avoids a diagnostic
4250 from gcc -Wbad-function-cast.
4251 (xg_set_toolkit_scroll_bar_thumb): Use it.
4252 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4253 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4254 (get_utf8_string, xg_get_file_with_chooser):
4255 Rename locals to avoid shadowing.
4256 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4257
41729b81
PE
4258 * xgselect.c (xg_select): Remove unused var.
4259
f0c77cd1
PE
4260 * image.c (four_corners_best): Mark locals as initialized.
4261 (gif_load): Initialize transparent_p to zero (Bug#8238).
4262 Mark another local as initialized.
ec6cf4c6 4263 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4264
ce0ad53d 4265 * image.c (clear_image_cache): Now static.
d5d5a617 4266 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4267 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4268 (x_edge_detection): Remove unnecessary cast that
4269 gcc -Wbad-function-cast diagnoses.
2037898d 4270 (gif_load): Fix pointer signedness.
6ae141d6
PE
4271 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4272 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4273
33383987 42742011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4275
d32df629
PE
4276 Improve quality of tests for time stamp overflow.
4277 For example, without this patch (encode-time 0 0 0 1 1
4278 1152921504606846976) returns the obviously-bogus value (-948597
4279 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4280 reports time overflow. See
4281 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4282 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4283 * editfns.c: Include limits.h and intprops.h.
4284 (TIME_T_MIN, TIME_T_MAX): New macros.
4285 (time_overflow): Move earlier, to before first use.
4286 (hi_time, lo_time): New functions, for an accurate test for
4287 out-of-range times.
4288 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4289 (Fget_internal_run_time): Don't assume time_t fits in int.
4290 (make_time): Use list2 instead of Fcons twice.
4291 (Fdecode_time): More accurate test for out-of-range times.
4292 (check_tm_member): New function.
4293 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4294 (lisp_time_argument): Don't rely on undefined left-shift and
4295 right-shift behavior when checking for time stamp overflow.
8be6f318 4296
fe31d94c
PE
4297 * editfns.c (time_overflow): New function, refactoring common code.
4298 (Fformat_time_string, Fdecode_time, Fencode_time):
4299 (Fcurrent_time_string): Use it.
4300
8be6f318
PE
4301 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4302 * dired.c (make_time): Move to ...
4303 * editfns.c (make_time): ... here.
4304 * systime.h: Note the move.
4305
09d9db2c 43062011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4307
126bc0dc
YM
4308 * fringe.c (update_window_fringes): Remove unused variables.
4309
c47cbdfd
YM
4310 * unexmacosx.c (copy_data_segment): Also copy __got section.
4311 (Bug#8223)
4312
7ac80be9
EZ
43132011-03-12 Eli Zaretskii <eliz@gnu.org>
4314
c96bbc66 4315 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4316 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4317 Constify `char *' arguments and their references according to
4318 prototypes in tparam.h.
4319
ecb0f94d 4320 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4321
7ac80be9
EZ
4322 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4323 Adapt all references accordingly.
4324
4325 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4326
ef1fd07e
TT
43272011-03-11 Tom Tromey <tromey@redhat.com>
4328
4329 * buffer.c (syms_of_buffer): Remove obsolete comment.
4330
7ef4b50c
EZ
43312011-03-11 Eli Zaretskii <eliz@gnu.org>
4332
4333 * termhooks.h (encode_terminal_code): Declare prototype.
4334
4335 * msdos.c (encode_terminal_code): Don't declare prototype.
4336
4337 * term.c (encode_terminal_code): Now external again, used by
4338 w32console.c and msdos.c.
4339
44f230aa
SM
4340 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4341 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4342
4b1ec863 43432011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4344
1714f52b 4345 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4346
4b1ec863
PE
4347 * fringe.c (update_window_fringes): Mark locals as initialized
4348 (Bug#8227).
4349 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4350
524c7aa6
PE
4351 * alloc.c (mark_fringe_data): Move decl from here ...
4352 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4353 to check its interface.
4354 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4355
a5c0af81 4356 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4357 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4358 (fontset_font): Mark local as initialized.
a9a06e0b 4359 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4360
b4716021
PE
4361 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4362
811e9bac 4363 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4364 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4365 (x_own_selection, Fx_disown_selection_internal): Rename locals
4366 to avoid shadowing.
4367 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4368
7e3ab302
PE
4369 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4370 so that the caller can use some name other than gcpro1.
4371 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4372 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4373 (Fx_backspace_delete_keys_p):
4374 Use them to avoid shadowing, and rename vars to avoid shadowing.
4375 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4376 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4377 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4378 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4379 Remove unused locals.
7e3ab302
PE
4380 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4381 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4382 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4383 macros.
f78faa98 4384
e2b13473
PE
4385 * xterm.h (x_mouse_leave): New decl.
4386
77f23912
PE
4387 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4388 Remove unused functions.
cdf4ba58
PE
4389 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4390 (x_calc_absolute_position): Now static.
7411c686 4391 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4392 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4393 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4394 unless they are used.
38d0b34a
PE
4395 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4396 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4397 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4398 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4399 (x_error_catcher, x_connection_closed, x_error_handler):
4400 (x_error_quitter, xembed_send_message, x_iconify_frame):
4401 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4402 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4403 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4404
44f230aa
SM
4405 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4406 Rename or move locals to avoid shadowing.
6b463e58 4407 (tty_defined_color, merge_face_heights): Now static.
5967d051 4408 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4409 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4410 does not deduce is never used uninitialized.
73719eba
PE
4411 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4412 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4413
426994c3 4414 * terminal.c (store_terminal_param): Now static.
5489860b 4415
032f1620 4416 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4417 (set_frame_menubar): Remove unused local.
d4323972 4418 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4419 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4420 since they might point to immutable storage.
281585b0
PE
4421 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4422 since it's unused otherwise.
032f1620 4423
367c19e5 4424 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4425 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4426 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4427 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4428 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4429 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4430 does not deduce are never used uninitialized.
70739cbe 4431
07b48fa9
PE
4432 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4433
8868a238 4434 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4435 * window.c (window_loop, size_window):
4436 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4437
7e5cf297 4438 * window.c (display_buffer): Now static.
d6550a9f
PE
4439 (size_window): Mark variables that gcc -Wuninitialized
4440 does not deduce are never used uninitialized.
a586633d
PE
4441 * window.h (check_all_windows): New decl, to forestall
4442 gcc -Wmissing-prototypes diagnostic.
5b555da1 4443 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4444
f6095868
PE
4445 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4446 shadowing.
4447 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4448 Include <limits.h>.
4449 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4450 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4451 (load_charset_map): Mark variables that gcc -Wuninitialized
4452 does not deduce are never used uninitialized.
53df7c11 4453 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4454
f38b440c
PE
4455 * coding.c (coding_set_source, coding_set_destination):
4456 Use "else { /* comment */ }" rather than "else /* comment */;"
4457 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4458 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4459 a block, when the outer 'i' will do.
4460 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4461 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4462 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4463 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4464 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4465 Rename locals to avoid shadowing.
4466 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4467 * coding.c (emacs_mule_char, encode_invocation_designation):
4468 Now static, since they're not used elsewhere.
413bb2db 4469 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4470 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4471 (decode_coding_emacs_mule): Mark variables that gcc
4472 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4473 (detect_coding_iso_2022): Initialize a local variable that might
4474 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4475 this initialization is needed. (Bug#8211)
5f58e762
PE
4476 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4477 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4478 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4479 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4480 Remove unused macros.
f38b440c 4481
232b38b9 4482 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4483 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4484 * character.c (string_count_byte8): Likewise.
232b38b9 4485
fb90da1b
PE
4486 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4487 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4488
fb93dbc2
PE
4489 * chartab.c (copy_sub_char_table): Now static, since it's not used
4490 elsewhere.
5c156ace
PE
4491 (sub_char_table_ref_and_range, char_table_ref_and_range):
4492 Rename locals to avoid shadowing.
bbcd0949 4493 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4494
7d3b3862 4495 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4496 (BIDI_BOB): Remove unused macro.
7d3b3862 4497
6be7d3da
PE
4498 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4499 deduce are never used uninitialized.
c2ed9c8b 4500 * term.c (encode_terminal_code): Likewise.
6be7d3da 4501
75f8807f 4502 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4503
50938595
PE
4504 * tparam.h: New file.
4505 * term.c, tparam.h: Include it.
4506 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4507 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4508 Move these decls to tparam.h, and make them agree with what
4509 is actually in tparam.c. The previous trick of using incompatible
4510 decls in different modules does not conform to the C standard.
4511 All callers of tparam changed to use tparam's actual API.
4512 * tparam.c (tparam1, tparam, tgoto):
4513 Use const pointers where appropriate.
4514
fbceeba2
PE
4515 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4516 * cm.h (struct cm): Likewise.
4517 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4518 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4519 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4520 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4521 (turn_on_face, init_tty): Likewise.
4522 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4523
7f3f1250
PE
4524 * term.c (term_mouse_position): Rename local to avoid shadowing.
4525
e6ca6543
PE
4526 * alloc.c (mark_ttys): Move decl from here ...
4527 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4528
c40f8d15
AS
45292011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4530
4531 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4532
cfe0661d
JB
45332011-03-09 Juanma Barranquero <lekktu@gmail.com>
4534
4535 * search.c (compile_pattern_1): Remove argument regp, unused since
4536 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4537 (compile_pattern): Don't pass it.
4538
0afb4571
J
45392011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4540
4541 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4542 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4543 for ! HAVE_GTK3.
4544 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4545
4546 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4547
4548 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4549 gdk_window_get_screen, gdk_window_get_geometry,
4550 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4551 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4552 (xg_get_pixbuf_from_pixmap): New function.
4553 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4554 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4555 Call xg_get_pixbuf_from_pixmap instead of
4556 gdk_pixbuf_get_from_drawable.
4557 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4558 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4559 (xg_check_special_colors): Use GtkStyleContext and its functions
4560 for HAVE_GTK3.
4561 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4562 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4563 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4564 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4565 Call gtk_widget_get_preferred_size.
0afb4571
J
4566 (xg_frame_resized): gdk_window_get_geometry only takes 5
4567 parameters.
44f230aa
SM
4568 (xg_win_to_widget, xg_event_is_for_menubar):
4569 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4570 (xg_set_widget_bg): New function.
4571 (delete_cb): New function.
895009e1 4572 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4573 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4574 (xg_set_background_color): Call xg_set_widget_bg.
4575 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4576 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4577 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4578 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4579 if ! HAVE_GTK3.
4580 (update_frame_tool_bar): Call gtk_widget_hide.
4581 (xg_initialize): Use GDK_KEY_g.
4582
4583 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4584 if ! HAVE_GTK3
4585 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4586
4587 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4588 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4589 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4590
1c2cc4ef
JB
45912011-03-08 Juanma Barranquero <lekktu@gmail.com>
4592
4593 * w32xfns.c (select_palette): Check success of RealizePalette against
4594 GDI_ERROR, not zero.
4595
33383987 4596See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4597
4598;; Local Variables:
4599;; coding: utf-8
aac0c6e3
MR
4600;; End:
4601
33383987 4602 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4603
4604 This file is part of GNU Emacs.
4605
4606 GNU Emacs is free software: you can redistribute it and/or modify
4607 it under the terms of the GNU General Public License as published by
4608 the Free Software Foundation, either version 3 of the License, or
4609 (at your option) any later version.
4610
4611 GNU Emacs is distributed in the hope that it will be useful,
4612 but WITHOUT ANY WARRANTY; without even the implied warranty of
4613 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4614 GNU General Public License for more details.
4615
4616 You should have received a copy of the GNU General Public License
4617 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.