international/quail.el (quail-insert-kbd-layout): Surround each row by LRO and PDF...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d1f55f16
CY
12012-03-12 Chong Yidong <cyd@gnu.org>
2
3 * eval.c (inhibit_lisp_code): Rename from
4 inhibit_window_configuration_change_hook; move from window.c.
5
6 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7 * window.c (run_window_configuration_change_hook)
8 (syms_of_window): Callers changed.
9
66c5eebd
CY
102012-03-11 Chong Yidong <cyd@gnu.org>
11
413df973
CY
12 * keymap.c (Fkey_description): Doc fix (Bug#9700).
13
66c5eebd
CY
14 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
15
1de11f56
CY
162012-03-10 Chong Yidong <cyd@gnu.org>
17
18 * frame.c (other_visible_frames): Don't assume the selected frame
19 is visible (Bug#10955).
20
cae07000
SM
212012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
22
23 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
24
89c94350
JD
252012-03-08 Jan Djärv <jan.h.d@swipnet.se>
26
27 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
28 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
29 zero (Bug#10954).
30
999dd333
GM
312012-03-03 Glenn Morris <rgm@gnu.org>
32
01a6dcc8 33 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 34
de0100f2
EZ
352012-03-02 Eli Zaretskii <eliz@gnu.org>
36
37 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
38 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
39 (redisplay_window, next_element_from_string): Fix typos in
40 comments.
3e441275
EZ
41 (redisplay_window): Pass to move_it_vertically the margin in
42 pixels, not in screen lines.
de0100f2 43
96a72ee9
GM
442012-03-02 Glenn Morris <rgm@gnu.org>
45
46 * buffer.c (buffer-list-update-hook): Doc fix.
47
312508d7
EZ
482012-02-29 Eli Zaretskii <eliz@gnu.org>
49
50 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
51 push_it before setting up the iterator for the first overlay
52 string, even if we have an empty string loaded.
53 (next_overlay_string): If there's an empty string on the iterator
54 stack, pop the stack. (Bug#10903)
55
27f3c637
PE
562012-02-25 Paul Eggert <eggert@cs.ucla.edu>
57
58 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
59 Suggested by Stefan Monnier in
60 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
61 * alloc.c (widen_to_Lisp_Object): New static function.
62 (mark_memory): Also mark Lisp_Objects by fetching pointer words
63 and widening them to Lisp_Objects. This would work even if
64 USE_LSB_TAG is defined and wide integers are used, which might
65 happen in a future version of Emacs.
66
3c9dfce6
CY
672012-02-25 Chong Yidong <cyd@gnu.org>
68
fa74b241
CY
69 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
70 Doc fix.
71
3c9dfce6
CY
72 * xselect.c (Fx_selection_exists_p): Doc fix.
73 (x_clipboard_manager_save_all): Print an informative message
74 before saving to clipboard manager.
75
9486df08
CY
762012-02-24 Chong Yidong <cyd@gnu.org>
77
78 * keyboard.c (process_special_events): Handle all X selection
79 requests in kbd_buffer, not just the next one (Bug#8869).
80
f01d3321
CY
812012-02-23 Chong Yidong <cyd@gnu.org>
82
83 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
84 call when setting menu-bar-lines and tool-bar-lines parameters.
85 (unwind_create_frame_1): New helper function.
86
87 * window.c (inhibit_window_configuration_change_hook): New var.
88 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 89 (syms_of_window): Initialize it.
f01d3321 90
86b847b6
CY
912012-02-22 Chong Yidong <cyd@gnu.org>
92
93 * xterm.c (x_draw_image_relief): Add missing type check for
94 Vtool_bar_button_margin (Bug#10743).
95
a59225b1
CY
962012-02-21 Chong Yidong <cyd@gnu.org>
97
98 * fileio.c (Vfile_name_handler_alist): Doc fix.
99
100 * buffer.c (Fget_file_buffer): Protect against invalid file
101 handler return value.
102
310f5bd4
PE
1032012-02-20 Paul Eggert <eggert@cs.ucla.edu>
104
cb3a28cc
PE
105 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
106 when computing $valmask.
107
310f5bd4
PE
108 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
109 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
110 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
111 It's useless in that case, and it can cause problems on hosts
112 that allocate halves of EMACS_INT values separately.
113 Reported by Dan Horák. Diagnosed by Andreas Schwab in
114 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
115 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
116 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
117 it avoids undefined behavior on hosts where shifting right by more
118 than the word width has undefined behavior.
119
2375c96a
CY
1202012-02-19 Chong Yidong <cyd@gnu.org>
121
122 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
123 (Funhandled_file_name_directory, Ffile_name_as_directory)
124 (Fdirectory_file_name, Fexpand_file_name)
125 (Fsubstitute_in_file_name): Protect against invalid file handler
126 return values (Bug#10845).
127
3eb49e71
EZ
1282012-02-18 Eli Zaretskii <eliz@gnu.org>
129
130 * .gdbinit (pitx): Fix incorrect references to fields of the
131 iterator stack.
132
7b926f3f
CY
1332012-02-17 Chong Yidong <cyd@gnu.org>
134
135 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
136
11273115
PE
1372012-02-15 Paul Eggert <eggert@cs.ucla.edu>
138
139 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
140 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
141
c3a70e2b
CY
1422012-02-15 Chong Yidong <cyd@gnu.org>
143
144 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
145 marked as special. Also, starting docstrings with * is obsolete.
146
0ca43699
AS
1472012-02-13 Andreas Schwab <schwab@linux-m68k.org>
148
149 * gnutls.c (emacs_gnutls_write): Fix last change.
150
2e8f3c56
LI
1512012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
152
153 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
154 send_process.
155
af70074f
SM
1562012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
157
158 * keymap.c (Fsingle_key_description): Handle char ranges.
159
95986d52
CY
1602012-02-12 Chong Yidong <cyd@gnu.org>
161
afd83bd1
CY
162 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
163 as that creates a dangerous corner case.
164
95986d52
CY
165 * window.c (Fdelete_window_internal): Invalidate the mouse
166 highlight (Bug#9904).
167
bd7da63e
GM
1682012-02-12 Glenn Morris <rgm@gnu.org>
169
170 * xselect.c (Fx_own_selection_internal)
171 (Fx_get_selection_internal, Fx_disown_selection_internal)
172 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
173 * nsselect.m (Fx_own_selection_internal)
174 (Fx_disown_selection_internal, Fx_selection_exists_p)
175 (Fx_selection_owner_p, Fx_get_selection_internal):
176 Sync docs and argument specs with the xselect.c versions.
177
77abcbc2
LI
1782012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
179
180 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
181
90b671e2
EZ
1822012-02-11 Eli Zaretskii <eliz@gnu.org>
183
1c0ca0b7
EZ
184 * w32select.c (Fx_selection_exists_p): Sync doc string and
185 argument list with xselect.c. (Bug#10783)
186
187 * w16select.c (Fx_selection_exists_p): Sync doc string and
188 argument list with xselect.c. (Bug#10783)
90b671e2 189
49241268
GM
1902012-02-10 Glenn Morris <rgm@gnu.org>
191
192 * fns.c (Fsecure_hash): Doc fix.
193
f998bbe7 1942012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
195
196 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
197
0992bd9c
CY
1982012-02-07 Chong Yidong <cyd@gnu.org>
199
200 * buffer.c (Fbuffer_local_variables)
201 (buffer_lisp_local_variables): Handle unbound vars correctly;
202 don't let Qunbound leak into Lisp.
203
af008560
GM
2042012-02-07 Glenn Morris <rgm@gnu.org>
205
dd605cc4
GM
206 * image.c (Fimagemagick_types): Doc fix.
207
af008560
GM
208 * image.c (imagemagick-render-type): Change it from a lisp object
209 to an integer. Move the doc here from the lisp manual.
210 Treat all values not equal to 0 the same.
211
1449fa1d
CY
2122012-02-06 Chong Yidong <cyd@gnu.org>
213
214 * doc.c (store_function_docstring): Avoid applying docstring of
215 alias to base function (Bug#2603).
216
3723ec07
AS
2172012-02-04 Andreas Schwab <schwab@linux-m68k.org>
218
219 * .gdbinit (pp1, pv1): Remove redundant defines.
220 (pr): Use pp.
221
79c1cc1e
CY
2222012-02-04 Chong Yidong <cyd@gnu.org>
223
224 * nsterm.m: Declare a global (Bug#10694).
225
d7f29f8e
EZ
2262012-02-04 Eli Zaretskii <eliz@gnu.org>
227
cae07000
SM
228 * w32.c (get_emacs_configuration_options):
229 Include --enable-checking, if specified, in the return value.
d7f29f8e 230
3b95a6f9
MR
2312012-02-04 Martin Rudalics <rudalics@gmx.at>
232
233 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
234 after rounding frame sizes. (Bug#9723)
235
d6fa96a6
EZ
2362012-02-04 Eli Zaretskii <eliz@gnu.org>
237
238 * keyboard.c (adjust_point_for_property): Don't position point
239 before BEGV. (Bug#10696)
240
df0b2940
PE
2412012-02-03 Paul Eggert <eggert@cs.ucla.edu>
242
243 Handle overflow when computing char display width (Bug#9496).
244 * character.c (char_width): Return EMACS_INT, not int.
245 (char_width, c_string_width): Check for overflow when
246 computing the width; this is possible now that individual
247 characters can have unbounded width. Problem introduced
248 by merge from Emacs 23 on 2012-01-19.
249
6bee44d6
MA
2502012-02-02 Michael Albinus <michael.albinus@gmx.de>
251
252 * dbusbind.c (Fdbus_register_method): Mention the return value
253 :ignore in the docstring.
254
44f92739
GM
2552012-02-02 Glenn Morris <rgm@gnu.org>
256
1b9f60cc
GM
257 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
258
44f92739
GM
259 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
260 Unconditionally set to t. (Bug#10673)
261 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
262 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
263 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
264
c5d3843c
KH
2652012-02-02 Kenichi Handa <handa@m17n.org>
266
267 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
268 0, do not call append_composite_glyph.
269
159462d4 2702012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
271
272 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
273 NULL (Bug#6988).
274 (x_produce_glyphs): If the component of a composition is a null
275 string, set it->pixel_width to 1 to avoid zero-width glyph.
276
78cef877
EZ
2772012-02-01 Eli Zaretskii <eliz@gnu.org>
278
279 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
280 first 2 arguments are identical. This makes inserting large
281 output from a subprocess an order of magnitude faster on
282 MS-Windows, where all sbrk'ed memory is always contiguous.
283
97897668
GM
2842012-01-31 Glenn Morris <rgm@gnu.org>
285
286 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 287 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
288 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
289
31fd3586
GM
2902012-01-29 Glenn Morris <rgm@gnu.org>
291
292 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
293
0e24a8b2
CY
2942012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
295
296 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
297
cc0adcb0
CY
2982012-01-28 Chong Yidong <cyd@gnu.org>
299
300 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
301
acc28cb9
CY
3022012-01-26 Chong Yidong <cyd@gnu.org>
303
9c69cfb7
CY
304 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
305
acc28cb9
CY
306 * search.c (Fsearch_forward, Fsearch_backward): Document negative
307 repeat counts (Bug#10507).
308
48da7392
GM
3092012-01-26 Glenn Morris <rgm@gnu.org>
310
311 * lread.c (syms_of_lread): Doc fix.
312
14af5f7f
CY
3132012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
314
315 * coding.c (encode_designation_at_bol): Change return value to
316 EMACS_INT.
317
0b21c100
CY
3182012-01-25 Chong Yidong <cyd@gnu.org>
319
320 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
321
3c2907f7
CY
3222012-01-21 Chong Yidong <cyd@gnu.org>
323
324 * floatfns.c (Fcopysign): Make the second argument non-optional,
325 since nil is not allowed anyway.
326
959ad23f
AS
3272012-01-21 Andreas Schwab <schwab@linux-m68k.org>
328
329 * process.c (read_process_output): Use p instead of XPROCESS (proc).
330 (send_process): Likewise.
331
34a02f46
MR
3322012-01-19 Martin Rudalics <rudalics@gmx.at>
333
334 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
335 (Vwindow_persistent_parameters): Do not use Qstate.
336 Rewrite doc-strings.
34a02f46 337
1259009a 3382012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
339
340 * character.c (char_width): New function.
70d4fdf6
GM
341 (Fchar_width, c_string_width, lisp_string_width):
342 Use char_width (Bug#9496).
25ed9e61 343
6a6ee00d
MR
3442012-01-16 Martin Rudalics <rudalics@gmx.at>
345
346 * window.c (Vwindow_persistent_parameters): New variable.
347 (Fset_window_configuration, save_window_save): Handle persistent
348 window parameters.
349
c85efaf7
EZ
3502012-01-14 Eli Zaretskii <eliz@gnu.org>
351
352 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
353 thrashing the stack of the thread. (Bug#9087)
354
5944709e
PE
3552012-01-12 Paul Eggert <eggert@cs.ucla.edu>
356
357 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
358
e71f5d99
EZ
3592012-01-11 Eli Zaretskii <eliz@gnu.org>
360
361 * xdisp.c (rows_from_pos_range): Handle the case where the
362 highlight ends on a newline. (Bug#10464)
363 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
364 he end column for display of highlight that ends on a newline
365 before a R2L line.
366
ce316182
GM
3672012-01-11 Glenn Morris <rgm@gnu.org>
368
369 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
370 from load-path also when installation-directory is nil. (Bug#10208)
371
5b43da69
GM
3722012-01-10 Glenn Morris <rgm@gnu.org>
373
74cc8ff9
GM
374 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
375
7d8d6e4e
GM
376 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
377 Update template values to be closer to their typical values these days.
5b43da69 378
a0db8d43
EZ
3792012-01-09 Eli Zaretskii <eliz@gnu.org>
380
381 * xdisp.c (rows_from_pos_range): Accept additional argument
382 DISP_STRING, and accept any glyph in a row whose object is that
383 string as eligible for mouse highlight. Fixes mouse highlight of
384 display strings from overlays. (Bug#10464)
385
9a0115ab 3862012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 387
b9110d6a 388 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
389 * fileio.c (auto_saving_dir_umask): New static var.
390 (Fmake_directory_internal): Use it.
391 (do_auto_save_make_dir): Set it, instead of invoking chmod after
392 creating the directory. The old code temporarily assigns
393 too-generous permissions to the directory.
394 (do_auto_save_eh): Clear it.
b9110d6a 395 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
396 that the var is always cleared.
397
6c1bd3f3
EZ
3982012-01-07 Eli Zaretskii <eliz@gnu.org>
399
400 * search.c (scan_buffer): Pass character positions to
401 know_region_cache, not byte positions. (Bug#6540)
402
069d2b50
L
4032012-01-07 LynX <_LynX@bk.ru> (tiny change)
404
405 * w32.c (sys_rename): Report EXDEV when rename of a directory
406 fails because the target is on another logical disk. (Bug#10284)
407
75bf0d33
DB
4082012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
409
410 * xterm.c (x_embed_request_focus): New function.
411
412 * xterm.h: Add prototype.
413
414 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
415
1c6e5a32
GM
4162012-01-05 Glenn Morris <rgm@gnu.org>
417
418 * emacs.c (emacs_copyright): Update short copyright year to 2012.
419
651e947e
EZ
4202012-01-01 Eli Zaretskii <eliz@gnu.org>
421
422 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
423 Load gnutls_transport_set_lowat only if GnuTLS version is below
424 2.11.1.
425 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
426 GnuTLS versions below 2.11.1.
427
3778cdd8
AL
4282011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
429
430 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
431 to the doc string advising against its use for altering the way
432 windows are scrolled.
433
0e5317f7
KH
4342011-12-28 Kenichi Handa <handa@m17n.org>
435
436 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
437 coding-system ASCII compatible only when it does not produce BOM
438 on encoding (Bug#10383).
439
93d5ca1f
JD
4402011-12-26 Jan Djärv <jan.h.d@swipnet.se>
441
442 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
443 can scroll.
444 (create_and_show_popup_menu): Always use menu_position_func for
445 Gtk3 (Bug#10361).
446
ca22b785
AS
4472011-12-24 Andreas Schwab <schwab@linux-m68k.org>
448
449 * callint.c (Fcall_interactively): Don't truncate prompt string.
450
d048e1e6
EZ
4512011-12-23 Eli Zaretskii <eliz@gnu.org>
452
453 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
454 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 455 resumed from there (after widening). (Bug#10360)
d048e1e6 456
5ccaba1f
JD
4572011-12-22 Jan Djärv <jan.h.d@swipnet.se>
458
459 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
460
204ee57f
JD
4612011-12-21 Jan Djärv <jan.h.d@swipnet.se>
462
b81d40f0
JB
463 * nsterm.m (x_free_frame_resources):
464 Release f->output_data.ns->miniimage.
204ee57f
JD
465 (ns_index_color): Fix indentation. Do not retain
466 color_table->colors[i].
467
468 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
469 before returning.
470
471 * nsfns.m (x_set_background_color): Assign return value from
472 ns_index_color to face-background instead of NSColor*.
473 (ns_implicitly_set_icon_type): Fix indentation.
474 Change assignment in for loop to comparison.
475
476 * emacs.c (ns_pool): New variable.
477 (main): Assign ns_pool.
478 (Fkill_emacs): Call ns_release_autorelease_pool.
479
480 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
481 autorelease fdesc, release fdAttrs and tdict.
482 (ns_get_covering_families): Release charset.
483 (ns_findfonts): Release NSFontDescriptor created with new.
484 (ns_uni_to_glyphs): Fix indentation.
485 (setString): Release attrStr before assigning new value.
486
c803b2b7
JD
4872011-12-18 Jan Djärv <jan.h.d@swipnet.se>
488
678f4426
JD
489 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
490 and NS_IMPL_COCOA.
491 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
492 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
493
cd394be1 4942011-12-18 David Reitter <reitter@cmu.edu>
678f4426 495
5fecd5fc
JD
496 * nsterm.m (ns_term_init): Subscribe for notifications
497 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
498 to method trackingNotification in EmacsMenu.
499
500 * nsmenu.m (trackingMenu): New variable.
3771cb17 501 (trackingNotification): New method (from Aquamacs).
5fecd5fc 502 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 503 from Aquamacs (Bug#7030).
678f4426
JD
504
5052011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 506
c803b2b7
JD
507 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
508 (symbol_to_nsstring): Fix indentation.
509 (ns_symbol_to_pb): New function.
cae07000
SM
510 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
511 (Fns_rotate_cut_buffers_internal): Remove.
512 (Fns_store_selection_internal): Rename from
c803b2b7
JD
513 Fns_store_cut_buffer_internal.
514 (ns_get_foreign_selection, Fx_own_selection_internal)
515 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
516 (Fns_get_selection_internal, Fns_store_selection_internal):
517 Use ns_symbol_to_pb and check if return value is nil.
518 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
519 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
520 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
521 renamed to Sns_store_selection_internal.
522 (ns_handle_selection_request): Move code to Fx_own_selection_internal
523 and remove this function.
524 (ns_handle_selection_clear): Remove, never used.
525 (Fx_own_selection_internal): Move code from ns_handle_selection_request
526 here.
527
e1b01a3a
KB
5282011-12-17 Ken Brown <kbrown@cornell.edu>
529
530 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
531 GID is unknown (Bug#10257).
532
2adb6e85
PE
5332011-12-17 Paul Eggert <eggert@cs.ucla.edu>
534
535 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
536 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
537 which caused a build failure on GNU/Linux IA-64. This problem was
538 introduced by my 2011-10-07 patch.
539
d1d7b339
JL
5402011-12-15 Juri Linkov <juri@jurta.org>
541
542 * image.c (imagemagick_error): New function. (Bug#10112)
543 (imagemagick_load_image): Comment out `MagickSetResolution' call.
544 Use `imagemagick_error' where ImageMagick functions return
545 `MagickFalse'.
546 (Fimagemagick_types): Add `Fnreverse' to return the list in the
547 proper order.
548
100d5755
KH
5492011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
550
551 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
552 fill background (Bug#8992).
553
454592a6
MR
5542011-12-13 Martin Rudalics <rudalics@gmx.at>
555
556 * window.c (Vwindow_combination_resize)
557 (Vwindow_combination_limit): Use t instead of non-nil in
558 doc-strings.
61d4b438
MR
559 (Vrecenter_redisplay): Add first sentence of doc-string on
560 separate line.
53524d93 561 (Frecenter): Fix doc-string typo.
454592a6 562
3633e3aa
KH
5632011-12-11 Kenichi Handa <handa@m17n.org>
564
565 * coding.c (Funencodable_char_position): Pay attention to the
566 buffer text relocation (Bug#9389).
567
7b9d523a
JD
5682011-12-10 Jan Djärv <jan.h.d@swipnet.se>
569
570 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
571 gtk_init (Bug#10100).
572
b73189c6
EZ
5732011-12-10 Eli Zaretskii <eliz@gnu.org>
574
575 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
576 IT->string is nil. (Bug#10263)
577
f7dfe5d6
JD
5782011-12-10 Jan Djärv <jan.h.d@swipnet.se>
579
83faebb4
JD
580 * nsterm.h (x_free_frame_resources): Declare.
581
f7dfe5d6
JD
582 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
583 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
584
585 * nsterm.h (ns_get_defaults_value): Declare.
586
587 * nsterm.m (ns_default): Call ns_get_defaults_value.
588
7cd4e72c
EZ
5892011-12-09 Eli Zaretskii <eliz@gnu.org>
590
591 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
592 (Bug#10170)
593
b34d7317
YM
5942011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
595
596 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
597 that where the value of an _OBJC_* symbol points to is in the .bss
598 section (Bug#10240).
599
76470ad1
KH
6002011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
601
602 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 603 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 604
745fff94
KH
6052011-12-08 Kenichi Handa <handa@m17n.org>
606
607 * ftfont.c (get_adstyle_property): Fix previous change
608 (Bug#10233).
609
6e44397c
JB
6102011-12-07 Juanma Barranquero <lekktu@gmail.com>
611
612 * w32.c (init_environment): If no_site_lisp, remove site-lisp
613 dirs from the default value of EMACSLOADPATH (bug#10208).
614
7efa6272
GM
6152011-12-07 Glenn Morris <rgm@gnu.org>
616
617 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
618 installation and source directories as well. (Bug#10208)
619
f6fc4d87
CY
6202011-12-06 Chong Yidong <cyd@gnu.org>
621
622 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
623
2bf26180
GM
6242011-12-06 Glenn Morris <rgm@gnu.org>
625
626 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
627 as an error, not just -1. (Bug#10217)
628
3a6ad4f0
CY
6292011-12-05 Chong Yidong <cyd@gnu.org>
630
631 * keyboard.c (process_special_events): New function.
632 (swallow_events, Finput_pending_p): Use it (Bug#10195).
633
75a3b399
PE
6342011-12-05 Paul Eggert <eggert@cs.ucla.edu>
635
636 * coding.c (encode_designation_at_bol): Don't use uninitialized
637 local variable (Bug#9318).
638
c3c9e25e
KH
6392011-12-05 Kenichi Handa <handa@m17n.org>
640
641 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
642 return Qnil (Bug#8046, Bug#10193).
643
5eb05ea3
KH
6442011-12-05 Kenichi Handa <handa@m17n.org>
645
646 * coding.c (encode_designation_at_bol): New args charbuf_end and
647 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
648 (coding_set_source): Return how many bytes coding->source was
649 relocated.
650 (coding_set_destination): Return how many bytes
651 coding->destination was relocated.
652 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 653 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
654
6552011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
656
657 * coding.c (CODING_CHAR_CHARSET_P): New macro.
658 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
659 macro (Bug#9318).
660
6612011-12-05 Andreas Schwab <schwab@linux-m68k.org>
662
663 The following changes are to fix Bug#9318.
664
a79703f5 665 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
666 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
667 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 668 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 669
7dbda6df
JB
6702011-12-05 Juanma Barranquero <lekktu@gmail.com>
671
672 * lisp.h (process_quit_flag): Fix external declaration.
673
6d5eb5b0
SM
6742011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
675
676 Don't macro-inline non-performance-critical code.
677 * eval.c (process_quit_flag): New function.
678 * lisp.h (QUIT): Use it.
679
a0c3fad0
JD
6802011-12-04 Jan Djärv <jan.h.d@swipnet.se>
681
682 * nsfns.m (get_geometry_from_preferences): New function.
683 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
684
6c07aac2
AS
6852011-12-04 Andreas Schwab <schwab@linux-m68k.org>
686
687 * emacs.c (Qkill_emacs): Define.
688 (syms_of_emacs): Initialize it.
689 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
690 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
691 (quit_throw_to_read_char): Add parameter `from_signal'.
692 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
693 * lisp.h (QUIT): Call Fkill_emacs if requested.
694
c052ead4
JD
6952011-12-03 Jan Djärv <jan.h.d@swipnet.se>
696
697 * widget.c (update_wm_hints): Return if wmshell is null.
698 (widget_update_wm_size_hints): New function.
699
700 * widget.h (widget_update_wm_size_hints): Declare.
701
702 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
703 widget_update_wm_size_hints (Bug#10104).
704
9e49252b
EZ
7052011-12-03 Eli Zaretskii <eliz@gnu.org>
706
707 * xdisp.c (handle_invisible_prop): If the invisible text ends just
708 before a newline, prepare the bidi iterator for consuming the
709 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 710 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 711
02b16839
JL
7122011-12-02 Juri Linkov <juri@jurta.org>
713
714 * search.c (Fword_search_regexp): New Lisp function created from
715 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
716 (Fword_search_backward, Fword_search_forward)
717 (Fword_search_backward_lax, Fword_search_forward_lax):
718 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
719 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
720
0068070e
SM
7212011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
722
723 * fileio.c (Finsert_file_contents): Move after-change-function call
724 to before the "handled:" label, since all "goto handled" appear in
725 cases where the *-change-functions have already been properly called
726 (bug#10117).
727
3360a3fc
AS
7282011-12-01 Andreas Schwab <schwab@linux-m68k.org>
729
730 * keyboard.c (interrupt_signal): Don't call kill-emacs when
731 waiting for input. (Bug#10169)
732
73d6c093
EZ
7332011-11-30 Eli Zaretskii <eliz@gnu.org>
734
735 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
736 verifies glyph row's hash code--we have just reallocated the
737 glyphs, so their contents can be complete garbage. (Bug#10164)
738
febe6bea
JB
7392011-11-30 Juanma Barranquero <lekktu@gmail.com>
740
741 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
742
801a4313
EZ
7432011-11-30 Eli Zaretskii <eliz@gnu.org>
744
745 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
746 attributes are tested _before_ calling verify_row_hash, to protect
747 against GCC re-ordering of the tests. (Bug#10164)
748
2b56b87e
JD
7492011-11-29 Jan Djärv <jan.h.d@swipnet.se>
750
751 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
752
753 * xterm.c (handle_one_xevent): Only set async_visible and friends
754 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 755 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
756 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
757
dbf31225
PE
7582011-11-28 Paul Eggert <eggert@cs.ucla.edu>
759
760 Remove GCPRO-related macros that exist only to avoid shadowing locals.
761 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
762 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
763 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
764 All uses changed to use GCPRO1 etc.
765 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
766 Revert to old implementation (i.e., before 2011-03-11).
767
1305621b
YM
7682011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
769
770 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
771 of scroll runs so as to avoid assigning disabled bogus rows and
772 unnecessary graphics copy operations.
773
8c9afb46
EZ
7742011-11-27 Eli Zaretskii <eliz@gnu.org>
775
776 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
777 (snprintf) [_MSC_VER]: Redirect to _snprintf.
778 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
779 (malloc, free, realloc, calloc): Redirect to e_* only when
780 compiling Emacs.
781
782 * lisp.h (GCTYPEBITS): Move before first use.
783 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
784 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
785 this macro definition.
786
787 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
788 _MSC_VER.
789
54e9e3bf
JD
7902011-11-27 Jan Djärv <jan.h.d@swipnet.se>
791
6d5eb5b0
SM
792 * gtkutil.c (xg_create_frame_widgets):
793 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
794 present with Gtk+ 2.0.
795
83aca1cb
PE
7962011-11-26 Paul Eggert <eggert@cs.ucla.edu>
797
798 * fileio.c (Finsert_file_contents): Undo previous change; see
799 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
800
5b76caa4
PE
8012011-11-26 Paul Eggert <eggert@cs.ucla.edu>
802
803 Rename locals to avoid shadowing.
804 * fileio.c (Finsert_file_contents):
805 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
806 * process.c (wait_reading_process_output):
807 Rename inner 'proc' to 'p' to avoid shadowing.
808 Indent for consistency with usual Emacs style.
809
8c535114
EZ
8102011-11-25 Eli Zaretskii <eliz@gnu.org>
811
812 * xdisp.c (redisplay_window): If cursor row is not fully visible
813 after recentering, and scroll-conservatively is set to a large
814 number, scroll window by a few more lines to make the cursor fully
815 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
816 (start_display): Don't move to the next line if the display should
817 start at a newline that is part of a display vector or an overlay
818 string. (Bug#10119)
8c535114 819
fa4fdb5c
JL
8202011-11-24 Juri Linkov <juri@jurta.org>
821
822 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
823 after the `MagickPingImage' call. (Bug#10112)
824
90ec88df
CY
8252011-11-23 Chong Yidong <cyd@gnu.org>
826
827 * window.c (Fcoordinates_in_window_p): Accept only live windows.
828
56e2e794
MR
8292011-11-23 Martin Rudalics <rudalics@gmx.at>
830
831 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
832 making another buffer current. (Bug#10114)
833
b6e64c41
GM
8342011-11-23 Glenn Morris <rgm@gnu.org>
835
836 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
837
6b21de18
CY
8382011-11-23 Chong Yidong <cyd@gnu.org>
839
840 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
841 using it (Bug#5984).
842
b12cd789
EZ
8432011-11-22 Eli Zaretskii <eliz@gnu.org>
844
845 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
846 and header-lines, as they don't have one computed for them.
847 (Bug#10098)
848
849 * .gdbinit (prow): Make displayed values more self-explaining.
850 Add row's hash code.
851
261b6fd4
LMI
8522011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
853
854 * process.c (wait_reading_process_output): Fix asynchrounous
855 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 856 (wait_reading_process_output): Add comment and URL.
261b6fd4 857
e7cfd277
JD
8582011-11-21 Jan Djärv <jan.h.d@swipnet.se>
859
860 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
861
a9b9b7f5
CY
8622011-11-21 Chong Yidong <cyd@gnu.org>
863
864 * window.c (Fnext_window, Fprevious_window): Doc fix.
865
b0d15b4f
SM
8662011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
867
868 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
869
fe7a3057
JB
8702011-11-20 Juanma Barranquero <lekktu@gmail.com>
871
872 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
873
d2999b1a
MR
8742011-11-20 Martin Rudalics <rudalics@gmx.at>
875
876 * window.c (Fset_window_combination_limit): Rename argument
877 STATUS to LIMIT.
878 (Vwindow_combination_limit): Remove "status" from doc-string.
879
d5ff9cd0
AS
8802011-11-20 Andreas Schwab <schwab@linux-m68k.org>
881
882 * m/ibms390.h: Remove.
883 * m/ibms390x.h: Don't include "ibms390.h".
884
a5bb9bd3
SM
8852011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
886
887 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
888 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
889
cd1181db
JB
8902011-11-20 Juanma Barranquero <lekktu@gmail.com>
891
892 * casetab.c (Fset_case_table):
893 * charset.c (Fcharset_after): Fix typos.
894
615a3b8d 8952011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 896
17e845af
PE
897 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
898 Otherwise, valgrind does not work on some platforms.
899 Problem reported by Andreas Schwab in
6a0bf43d
PE
900 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
901 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
902 is set, removing the need for VIRT_ADDRESS_VARIES.
903 (PURE_P): Use a more-efficient implementation that needs just one
904 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
905 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
906 to 4 (xorl, subq, cmpq, setbe).
907 * alloc.c (pure): Always extern now, since that's the
908 VIRT_ADDR_VARIES behavior.
909 (PURE_POINTER_P): Use a single comparison, not two, for
910 consistency with the new puresize.h.
911 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
912 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
913 Remove VIRT_ADDR_VARIES no longer needed.
914
f8fe6f96
EZ
9152011-11-19 Eli Zaretskii <eliz@gnu.org>
916
917 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
918 (erase_phys_cursor, update_window_cursor, show_mouse_face)
919 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
920 behave as if the cursor position were at the window margin.
921
922 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
923 and the cursor position is out of bounds, behave as if the cursor
924 position were at the window margin. (Bug#10075)
925
df05a53c
CY
9262011-11-18 Chong Yidong <cyd@gnu.org>
927
928 * window.c (Fwindow_combination_limit): Make first argument
929 non-optional, since it is meaningless for live windows like the
930 selected window.
931
2071918e
DA
9322011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
933
934 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
935
b50a28de
SM
9362011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
937
938 * intervals.c: Fix grafting over the whole buffer (bug#10071).
939 (graft_intervals_into_buffer): Simplify.
940
015137db
EZ
9412011-11-18 Eli Zaretskii <eliz@gnu.org>
942
943 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
944 hash values of the two rows.
945 (copy_row_except_pointers): Preserve the used[] arrays and the
946 hash values of the two rows. (Bug#10035)
68c95424 947 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
948
949 * xdisp.c (row_hash): New function, body extracted from
950 compute_line_metrics.
951 (compute_line_metrics): Call row_hash, instead of computing the
952 hash code inline.
953
954 * dispnew.c (verify_row_hash): Call row_hash for computing the
955 hash code of a row, instead of duplicating code from xdisp.c.
956
957 * dispextern.h (row_hash): Add prototype.
958
a2addb04
TH
9592011-11-18 Tassilo Horn <tassilo@member.fsf.org>
960
961 * frame.c (delete_frame): Don't delete the terminal when the last
962 X frame is closed if emacs is built with GTK toolkit.
963
df85d315
JB
9642011-11-17 Juanma Barranquero <lekktu@gmail.com>
965
966 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
967
a0c2d0ae
MR
9682011-11-17 Martin Rudalics <rudalics@gmx.at>
969
970 * window.c (Vwindow_splits): Rename to
971 Vwindow_combination_resize. Suggested by Juri Linkov.
972 (Fsplit_window_internal): Use Vwindow_combination_resize instead
973 of Vwindow_splits.
974
58179cce
JB
9752011-11-16 Juanma Barranquero <lekktu@gmail.com>
976
7877f373
JB
977 * nsfns.m (Fns_font_name):
978 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 979
b6f67890
MR
9802011-11-16 Martin Rudalics <rudalics@gmx.at>
981
982 * window.h (window): Rename slot "nest" to "combination_limit".
983 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
984 (Fset_window_nest): Rename to Fset_window_combination_limit.
985 (Vwindow_nest): Rename to Vwindow_combination_limit.
986 (recombine_windows, make_parent_window, make_window)
987 (Fsplit_window_internal, saved_window)
988 (Fset_window_configuration, save_window_save): Rename all
989 occurrences of window_nest to window_combination_limit.
990
c7015153
JB
9912011-11-15 Juanma Barranquero <lekktu@gmail.com>
992
993 * image.c (imagemagick_load_image): Fix typo.
994
322ad6ec
EZ
9952011-11-14 Eli Zaretskii <eliz@gnu.org>
996
997 * xdisp.c (display_line): Move the call to
998 highlight_trailing_whitespace before the call to
999 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1000 faces of all the glyphs to compute ROW's hash value.
1001 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1002
f067b8ec
JB
10032011-11-14 Juanma Barranquero <lekktu@gmail.com>
1004
1005 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1006 just return (bug#10044).
1007
1e5b2111
EZ
10082011-11-12 Eli Zaretskii <eliz@gnu.org>
1009
7ef3cbd5
EZ
1010 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1011 with user-defined heap size. Bump the default size of the temacs
1012 heap to 27MB, to avoid memory warning when running temacs.
1013 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1014
1e5b2111
EZ
1015 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1016 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1017 (verify_row_hash) [XASSERTS]: New function.
1018 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1019 that the hash value of glyph rows is correct.
1e5b2111 1020
89d61221
MR
10212011-11-12 Martin Rudalics <rudalics@gmx.at>
1022
1023 * window.h (window): Remove splits slot.
1024 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1025 (Fdelete_other_windows_internal, make_parent_window)
1026 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1027 (Fset_window_configuration, save_window_save): Don't deal with
1028 split status of windows.
1029 (saved_window): Remove splits slot.
1030 (Vwindow_splits): Rewrite doc-string.
1031
97f18cc8
JD
10322011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1033
1034 * xfns.c (unwind_create_frame):
1035 * nsfns.m (unwind_create_frame):
1036 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1037 Vframe_list (Bug#9999).
1038
22a648b4
DA
10392011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1040
0b381c7e 1041 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1042
659afede
KH
10432011-11-11 Kenichi Handa <handa@m17n.org>
1044
1045 * callproc.c (Fcall_process): Set the member dst_multibyte of
1046 process_coding.
1047
9ac0394b
KH
10482011-11-11 Johan Bockgård <bojohan@gnu.org>
1049
1050 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1051 avoid a crash (bug#9496).
1052
2fbdc249
CY
10532011-11-09 Chong Yidong <cyd@gnu.org>
1054
1055 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1056 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1057
ac6b1f81
PE
10582011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1059
1060 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1061
09db192c
PE
10622011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 Avoid some portability problems by eschewing 'extern inline' functions.
1065 The trivial performance wins aren't worth the portability hassles; see
1066 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1067 et seq.
1068 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1069 (window_box_width, window_box_left, window_box_left_offset)
1070 (window_box_right, window_box_right_offset): Undo previous change,
1071 by removing the "extern"s.
1072 * intervals.c (adjust_intervals_for_insertion)
1073 (adjust_intervals_for_deletion): Undo previous change,
1074 making these static again.
1075 (offset_intervals, temp_set_point_both, temp_set_point)
1076 (copy_intervals_to_string): No longer inline.
1077 * xdisp.c (window_text_bottom_y, window_box_width)
1078 (window_box_height, window_box_left_offset)
1079 (window_box_right_offset, window_box_left, window_box_right)
1080 (window_box): No longer inline.
1081
105216ed
CY
10822011-11-08 Chong Yidong <cyd@gnu.org>
1083
1084 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1085 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1086 Signal an error if not a live window.
105216ed
CY
1087 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1088 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1089
ae9e237f
JB
10902011-11-07 Juanma Barranquero <lekktu@gmail.com>
1091
1092 * lisp.h (syms_of_abbrev): Remove declaration.
1093 Reported by CHENG Gao <chenggao@royau.me>.
1094
c7aa8333
EZ
10952011-11-07 Eli Zaretskii <eliz@gnu.org>
1096
1097 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1098 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1099 of temacs in GUI mode.
1100
be7f5545
MR
11012011-11-07 Martin Rudalics <rudalics@gmx.at>
1102
1103 * window.h: Declare delete_all_child_windows instead of
1104 delete_all_subwindows.
1105 * window.c (Fwindow_nest, Fset_window_nest)
1106 (Fset_window_new_total, Fset_window_new_normal)
1107 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1108 (delete_all_subwindows): Rename to delete_all_child_windows.
1109 (Fdelete_other_windows_internal, Fset_window_configuration):
1110 Call delete_all_child_windows instead of delete_all_subwindows.
1111 * frame.c (delete_frame): Call delete_all_child_windows instead
1112 of delete_all_subwindows.
1113
ca78dc43
PE
11142011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1117 This is also needed for porting to any host where GC_MARK_STACK is
1118 not GC_MAKE_GCPROS_NOOPS.
1119 (which_symbols): Use it.
1120
a0241d01
KH
11212011-11-07 Kenichi Handa <handa@m17n.org>
1122
1123 * coding.c (coding_set_destination): Check coding->src_pos only
1124 when coding->src_object is a buffer (bug#9910).
1125
1126 * process.c (send_process): Set the member src_multibyte of coding
1127 to 0 (bug#9911) when sending a unibyte text.
1128
1129 * callproc.c (Fcall_process): Set the member src_multibyte of
1130 process_coding to 0 (bug#9912).
1131
a64bfdfa 11322011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1133
1134 * xmenu.c (cleanup_widget_value_tree): New function.
1135 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1136 calling free_menubar_widget_value_tree directly (Bug#9830).
1137
cb41b32a
PE
11382011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 Fix some portability problems with 'inline'.
1141 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1142 (window_box_width, window_box_left, window_box_left_offset)
1143 (window_box_right, window_box_right_offset): Declare extern.
1144 Otherwise, these inline functions do not conform to C99 and
1145 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1146 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1147 * intervals.c (adjust_intervals_for_insertion)
1148 (adjust_intervals_for_deletion): Now extern, because otherwise the
1149 extern inline functions 'offset_intervals' couldn't refer to it.
1150 (static_offset_intervals): Remove.
1151 (offset_intervals): Rewrite using the old contents of
1152 static_offset_intervals. The old version didn't conform to C99
1153 because an extern inline function contained a reference to an
1154 identifier with static linkage.
1155
b7041366
AS
11562011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1157
1158 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1159 GC.
1160
88a37c4d
EZ
11612011-11-06 Eli Zaretskii <eliz@gnu.org>
1162
1163 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1164 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1165 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1166 return Qleft_to_right.
1167
49745b39
CY
11682011-11-06 Chong Yidong <cyd@gnu.org>
1169
1170 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1171 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1172 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1173 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1174 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1175 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1176 (Fwindow_vscroll): Doc fix.
1177 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1178 argument, since it makes no sense to pass a live window and for
1179 consistency with window-child.
1180
1f05cd82
CS
11812011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1182
1183 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1184 support MSVC.
1185
22610910
JR
11862011-11-05 Jason Rumney <jasonr@gnu.org>
1187
1188 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1189 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1190 fonts (Bug#6029).
1191 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1192 bitwise arithmetic preventing use of unicode-sip and non-truetype
1193 opentype fonts.
1194
a06776b2
EZ
11952011-11-05 Eli Zaretskii <eliz@gnu.org>
1196
3ad924ba
EZ
1197 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1198 "emacs"-only part.
1199
a06776b2
EZ
1200 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1201 initialization code to keep similarity to xfns.c after changes
1202 from 2011-11-05.
1203
c9e7db78
JD
12042011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1205
a97f8f3f
JD
1206 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1207 (unwind_create_frame): New function (Bug#9943).
1208 (Fx_create_frame): Restructure code to be more similar to the one in
1209 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1210 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1211 Move terminal->reference_count++ just before making the frame official
1212 (Bug#9943).
1213
1214 * nsterm.m (x_free_frame_resources): New function.
1215 (x_destroy_window): Move code to x_free_frame_resources.
1216
c9e7db78 1217 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1218 (Fx_create_frame, x_create_tip_frame):
1219 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1220 official. Move initialization of image_cache_refcount and
1221 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1222
a6fc3b5c
EZ
12232011-11-05 Eli Zaretskii <eliz@gnu.org>
1224
1225 Support MSVC build with newer versions of Visual Studio.
1226 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1227 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1228 nt/gmake.defs.
1229
1230 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1231 which are not supported by MSVC.
1232 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1233 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1234 bitfields.
1235 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1236 types in bitfields.
1237 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1238
1239 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1240
58179cce 12412011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1242
1243 Support MSVC build with newer versions of Visual Studio.
1244 * w32.c: Don't include w32api.h for MSVC.
1245 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1246
1247 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1248 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1249 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1250 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1251 e_* cousins.
1252 (alloca) [_MSC_VER]: Define to _alloca.
1253
1254 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1255
1256 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1257
a58c13ed
EZ
12582011-11-04 Eli Zaretskii <eliz@gnu.org>
1259
1260 * xdisp.c (note_mouse_highlight): If either of
1261 previous/next-single-property-change returns nil, treat that as
1262 the beginning or the end of the buffer. (Bug#9955)
1263
fe0b6370
JD
12642011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1265
a58c13ed 1266 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1267 label is not null (Bug#9951).
1268 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1269 may be NULL.
1270
89bd5ee1
EZ
12712011-11-04 Eli Zaretskii <eliz@gnu.org>
1272
1273 * window.c (Fwindow_body_size): Mention in the doc string that the
1274 return value is in frame's canonical units. (Bug#9949)
1275
84c3edb9
EZ
12762011-11-03 Eli Zaretskii <eliz@gnu.org>
1277
4e2fb5c7
EZ
1278 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1279
84c3edb9 1280 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1281 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1282 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1283
bc17a887
EZ
12842011-11-01 Eli Zaretskii <eliz@gnu.org>
1285
1286 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1287 Don't stop backward scan on the continuation glyph, even though
1288 its CHARPOS is positive.
6d5eb5b0
SM
1289 (mouse_face_from_buffer_pos, note_mouse_highlight):
1290 Rename cover_string to disp_string.
bc17a887 1291
4ee88440
MR
12922011-11-01 Martin Rudalics <rudalics@gmx.at>
1293
1294 * window.c (temp_output_buffer_show): Don't use
1295 Vtemp_buffer_show_specifiers.
1296 (Vtemp_buffer_show_specifiers): Remove unused variable.
1297
c2ff3c02
EZ
12982011-10-30 Eli Zaretskii <eliz@gnu.org>
1299
1300 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1301 past the beginning of the current glyph matrix.
1302
58179cce 13032011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1304
1305 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1306 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1307 HAVE_GTK3 (Bug#9869).
b77a6a7f 1308
3b574623
JD
1309 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1310 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1311
b77a6a7f
JD
1312 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1313
1314 * xterm.c: Declare x_handle_net_wm_state to return int.
1315 (handle_one_xevent): Check if we are iconified but don't have
1316 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1317 (get_current_wm_state): Return non-zero if not hidden,
1318 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1319 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1320 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1321 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1322
196e41e4
PE
13232011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1326 so that this new function doesn't get optimized away by a
1327 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1328
021f2e1a
AS
13292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1330
1331 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1332
8b058d44
EZ
13332011-10-29 Eli Zaretskii <eliz@gnu.org>
1334
1335 Fix the `xbytecode' command.
1336 * .gdbinit (xprintbytestr): New command.
b50a28de 1337 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1338 (xbytecode): Print the byte-code string as well.
1339
4452fb80
EZ
13402011-10-29 Kim Storm <storm@cua.dk>
1341
8b058d44
EZ
1342 * alloc.c (which_symbols): New function.
1343
21b72067
AS
13442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1345
1346 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1347 line. (Bug#9903)
1348
83ed7b5c
GM
13492011-10-29 Glenn Morris <rgm@gnu.org>
1350
1351 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1352 Not clear what it was for, and it causes various bugs. (Bug#9839)
1353
5a7a728b
EZ
13542011-10-28 Eli Zaretskii <eliz@gnu.org>
1355
1356 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1357 possible random value that matches one of those tested as
1358 condition to clear the mouse face.
1359
d3d0842f
CY
13602011-10-28 Chong Yidong <cyd@gnu.org>
1361
1362 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1363
31b39d13
DN
13642011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1365
1366 * window.c (make_window): Initialize phys_cursor_on_p.
1367
9aba6043
SM
13682011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1369
1370 * lisp.h (struct Lisp_Symbol): Update comments.
1371
c20992f4
JB
13722011-10-28 Juanma Barranquero <lekktu@gmail.com>
1373
1374 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1375
db4f02f2
EZ
13762011-10-28 Eli Zaretskii <eliz@gnu.org>
1377
1378 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1379 <oslsachem@gmail.com> for helping to debug this.
1380
1381 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1382 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1383 (g_b_init_get_glyph_outline_w): New static variables.
1384 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1385 (GetGlyphOutlineW_Proc): New typedefs.
1386 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1387 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1388 New functions.
1389 (w32font_open_internal, compute_metrics):
1390 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1391 instead of calling the "wide" APIs directly.
1392
1393 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1394
1395 * w32.h (syms_of_w32font): Add prototype.
1396
87e68db4
JB
13972011-10-27 Juanma Barranquero <lekktu@gmail.com>
1398
1399 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1400 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1401 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1402 (Fmove_to_window_line): Doc fix.
1403
435c1d67
CY
14042011-10-27 Chong Yidong <cyd@gnu.org>
1405
1406 * process.c (make_process): Set gnutls_state to NULL.
1407
1408 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1409 non-NULL, regardless of GNUTLS_INITSTAGE.
1410 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1411 an error. Set process slots as soon as we allocate them.
1412
1413 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1414
9c6c6f49
CY
14152011-10-27 Chong Yidong <cyd@gnu.org>
1416
9aba6043
SM
1417 * gnutls.c (emacs_gnutls_deinit): New function.
1418 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1419 (Fgnutls_deinit, Fgnutls_boot): Use it.
1420
1421 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1422 (deactivate_process): Call emacs_gnutls_deinit.
1423
657d08d3
JB
14242011-10-27 Juanma Barranquero <lekktu@gmail.com>
1425
1426 * image.c (x_create_x_image_and_pixmap):
1427 * w32.c (sys_rename, w32_delayed_load):
1428 * w32font.c (fill_in_logfont):
1429 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1430
5430d399
JB
14312011-10-26 Juanma Barranquero <lekktu@gmail.com>
1432
1433 * w32fns.c (w32_default_color_map): New function,
1434 extracted from Fw32_default_color_map.
a7ef684b 1435 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1436
fe0055fa
PE
14372011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1440
e6346438
SM
14412011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1442
1443 * keyboard.c (test_undefined): New function (bug#9751).
1444 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1445
e112cc37
ET
14462011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1447
1448 * sysdep.c (init_sys_modes): Fix the check for the controlling
1449 terminal (Bug#6649).
1450
7b5d6677
EZ
14512011-10-20 Eli Zaretskii <eliz@gnu.org>
1452
1453 * dispextern.h (struct bidi_it): New member next_en_type.
1454
1455 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1456 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1457 current character, check also for next_en_type being WEAK_EN.
1458 (bidi_resolve_weak): Don't enter the expensive loop if the current
1459 position is before next_en_pos. Record the bidi type of the first
1460 non-ET, non-BN character we find, in addition to its position.
1461 (bidi_level_of_next_char): Invalidate next_en_type when
1462 next_en_pos is over-stepped.
1463
7da0b018
PE
14642011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1465
1466 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1467 * editfns.c: Rewrite current-time-zone so that it invokes
1468 the equivalent of (format-time-string "%Z") to get the time zone name.
1469 This fixes a bug when the time zone name contains characters that
1470 need converting from the system time locale to Emacs internal format.
1471 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1472 that patch fixed format-time-string to do the conversion, but
1473 I forgot to fix current-time-zone.
1474 (format_time_string): New function, containing most of
1475 what Fformat_time_string used to contain.
1476 (Fformat_time_string): Rewrite in terms of format_time_string.
1477 This doesn't change this function's behavior.
1478 (current-time-zone): Rewrite to use format_time_string.
1479 This fixes the bug reported by Michael Schierl in
1480 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1481 Jason Rumney's 2007-06-07 change worked around this bug, but
1482 didn't fix it.
1483 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1484
8547b010
EZ
14852011-10-19 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xdisp.c (start_display): If the character at POS is displayed
1488 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1489 (try_window_reusing_current_matrix): If a line ends in a display
1490 vector or the next line starts in a display vector, continue
1491 redrawing the window even though the character position of
1492 start_row was reached.
8547b010
EZ
1493 (Bug#9771, part 2)
1494
4e948d15
CY
14952011-10-18 Chong Yidong <cyd@gnu.org>
1496
1497 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1498 with nobreak-char-display too.
1499
4787455f
EZ
15002011-10-18 Eli Zaretskii <eliz@gnu.org>
1501
1502 Fix part 3 of bug#9771.
1503 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1504 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1505 non-neutral characters if the current character is a paragraph
1506 separator (a.k.a. Newline). This avoids running the same
1507 expensive loop twice, once when we consume the preceding newline
1508 and the other time when the line actually needs to be displayed.
1509 Avoid the loop when we see neutrals on the base embedding level
1510 following a character whose directionality is the same as the
1511 paragraph's. This avoids running the expensive loop when a line
1512 ends in a long sequence of neutrals, like control characters.
1513 Add assertion against STRONG_AL type. Slightly rearrange code
1514 that determines the type of a neutral given the first non-neutral
1515 that follows it.
1516 (bidi_level_of_next_char): Set next_en_pos to zero when
1517 invalidating its info.
1518
2c91f553
EZ
15192011-10-17 Eli Zaretskii <eliz@gnu.org>
1520
1521 * xdisp.c (push_display_prop): Determine whether to record string
1522 or buffer position by IT->string, not by IT->method. Allow
1523 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1524 (move_it_vertically_backward): Don't look for character position
1525 immediately after the newline when in a continuation line.
1526 (Bug#9771, part 1)
2c91f553 1527
c7b08b0d
MR
15282011-10-15 Martin Rudalics <rudalics@gmx.at>
1529
1530 * window.c (coordinates_in_window): Rewrite and delabelize
1531 vertical border check. (Bug#5357) (Bug#9618)
1532
6b02f655
SM
15332011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1534
1535 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1536 errors in XSetWindowBorder (bug#9310).
1537
81d40c92
DA
15382011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1541 avoid crash when xmalloc overrun checking is enabled.
1542
d4172c3b
EZ
15432011-10-13 Eli Zaretskii <eliz@gnu.org>
1544
1545 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1546 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1547 cursor motion with <left> and <right> arrow keys.
1548
1549 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1550 some callers set that themselves.
1551
b00eea75
EZ
15522011-10-12 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1555 display string and the previous row comes from the same string and
1556 is empty. (Bug#9739) (Bug#9738)
1557
8fe012c4
SM
15582011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1559
1560 * doc.c (get_doc_string): Encode file name (bug#9735).
1561
0074aef2
EZ
15622011-10-12 Eli Zaretskii <eliz@gnu.org>
1563
79beb178
EZ
1564 * bidi.c (bidi_level_of_next_char):
1565 * xdisp.c (get_visually_first_element): Remove old incorrect
1566 comments regarding the Unicode Line Separator character.
1567
0074aef2
EZ
1568 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1569
6e4b3fbe
DA
15702011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1571
1572 * alloc.c (Fgc_status): Do not access beyond zombies array
1573 boundary if nzombies > MAX_ZOMBIES.
1574 * alloc.c (dump_zombies): Add missing format specifier.
1575
0324f3af
PE
15762011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1577
b5525cac
PE
1578 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1579 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1580
0324f3af
PE
1581 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1582 Some packages use them to denote characters with modifiers.
1583
e9b5f888
AS
15842011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1585
1586 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1587 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1588 matching a pp-number. Rename parameter var to var1.
1589
127827c0
SM
15902011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1593
c8fd3bd0
GM
15942011-10-08 Glenn Morris <rgm@gnu.org>
1595
1596 * callint.c (Fcall_interactively): Give a more explicit error for the
1597 'c' case with a non-character input. (Bug#8479)
1598
352ec8ff
EZ
15992011-10-08 Eli Zaretskii <eliz@gnu.org>
1600
03669ccb
EZ
1601 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1602 lines.
7061c986
EZ
1603 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1604 lines that are hscrolled on the left.
03669ccb 1605
352ec8ff
EZ
1606 * dispnew.c (buffer_posn_from_coords): Account for a possible
1607 presence of header-line. (Bug#4426)
1608
a66cfb1c
SM
16092011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1610
6b02f655
SM
1611 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1612 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1613
7c5ee88e
PE
16142011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1617 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1618 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1619 this makes Emacs dump core during garbage collection on rare
1620 occasions. sizeof is obviously inferior to offsetof here, so
1621 stick with offsetof.
1622 (GC_POINTER_ALIGNMENT): New macro.
1623 (mark_memory): Omit 3rd (offset) arg; caller changed.
1624 Don't assume EMACS_INT alignment is the same as pointer alignment.
1625
df1bbe5b
SM
16262011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1627
1628 * keyboard.c (read_key_sequence_remapped): New var.
1629 (read_key_sequence): Compute remapping in the right buffer.
1630 (command_loop_1): Use read_key_sequence's remapping directly.
1631
51553db6
SM
16322011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1633
32c1fffd
SM
1634 * dired.c (file_name_completion): Don't expand file name.
1635 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1636 before checking file name handler.
1637
51553db6
SM
1638 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1639 they've been requested explicitly (bug#9591).
1640
b6bd1599 16412011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1642
1643 * keymap.c (Fsingle_key_description): Use make_specified_string
1644 instead of build_string to build string from push_key_description.
1645 (Bug#5193)
1646
f701dc2a
PE
16472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1648
4222c55d
PE
1649 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1650 This fixes a Y2038 bug on 64-bit hosts.
1651 * buffer.c (reset_buffer):
1652 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1653 (Fclear_buffer_auto_save_failure):
1654 Use 0, not -1, to represent an unset failure time, since time_t
1655 might not be signed.
1656
f701dc2a
PE
1657 Remove dependency on glibc malloc internals.
1658 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1659 Move back here from lisp.h, but with their new implementations.
1660 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1661 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1662 * charset.c (charset_table_init): New static var.
1663 (syms_of_charset): Use it instead of xmalloc. This removes a
1664 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1665 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1666 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1667 Move back to alloc.c.
1668 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1669 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1670
9ceebf39
JD
16712011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1672
1673 * nsterm.m (windowDidResize): Call x_set_window_size only when
1674 ns_in_resize is true. Otherwise set pixelwidth/height and
1675 call change_frame_size (Bug#9628).
1676
cb993c58
PE
16772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1678
3930c88b
PE
1679 Port --enable-checking=all to Fedora 14 x86-64.
1680 * charset.c (syms_of_charset): Also account for glibc malloc's
1681 internal overhead when calculating the initial malloc maximum.
1682
cb993c58
PE
1683 Port --enable-checking=all to Fedora 14 x86.
1684 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1685 Move to lisp.h.
1686 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1687 (overrun_check_realloc, overrun_check_free):
1688 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1689 That way, xmalloc returns a properly-aligned pointer even if
1690 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1691 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1692 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1693 into account when calculating the initial malloc maximum.
1694 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1695 Move here from alloc.c, so that charset.c can use it too.
1696 Properly align; the old code wasn't right for common 32-bit hosts
1697 when configured with --enable-checking=all.
1698 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1699 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1700
31bed486
EZ
17012011-09-29 Eli Zaretskii <eliz@gnu.org>
1702
04c70788 1703 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1704 use EDOM.
1705
fbcaa2f3
EZ
17062011-09-28 Eli Zaretskii <eliz@gnu.org>
1707
1708 * xdisp.c (compute_display_string_end): If there's no display
1709 string at CHARPOS, return -1.
1710
1711 * bidi.c (bidi_fetch_char): When compute_display_string_end
1712 returns a negative value, treat the character as a normal
1713 character not covered by a display string. (Bug#9624)
1714
a239d4e9
JB
17152011-09-28 Juanma Barranquero <lekktu@gmail.com>
1716
1717 * lread.c (Fread_from_string): Fix typo in docstring.
1718
88652fd5
EZ
17192011-09-27 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1722 newline, reseat the iterator instead of bidi-iterating there one
1723 character at a time. (Bug#9610)
32c1fffd
SM
1724 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1725 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1726
ed497dd4
AS
17272011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1728
1729 * lread.c (readevalloop): Use correct code for NBSP.
1730 (read1): Likewise. (Bug#9608)
1731
b2bf61aa
MA
17322011-09-25 Michael Albinus <michael.albinus@gmx.de>
1733
1734 * dbusbind.c (Fdbus_register_signal): When service is not
1735 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1736
32bbb17c
GM
17372011-09-25 Glenn Morris <rgm@gnu.org>
1738
1739 * buffer.c (truncate-lines): Doc fix.
1740
94e0933e
CY
17412011-09-24 Chong Yidong <cyd@stupidchicken.com>
1742
1743 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1744 (Fset_window_next_buffers): Doc fix.
1745
cddde921
GM
17462011-09-24 Glenn Morris <rgm@gnu.org>
1747
1748 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1749
1260aef1
PE
17502011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1751
25b4bfa0
PE
1752 Fix minor problems found by static checking.
1753 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1754 * indent.c (Fvertical_motion): Fix == vs = typo.
1755
e3cbd34b
EZ
17562011-09-24 Eli Zaretskii <eliz@gnu.org>
1757
a66cfb1c
SM
1758 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1759 Default value is now t. Doc fix.
6bf7006f 1760
e3cbd34b 1761 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1762 logic when moving up, not only when moving down. Fix the
e3cbd34b 1763 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1764 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1765
1766 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1767 CHARPOS is covered by a display string which includes newlines.
1768 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1769 is covered by a display string with embedded newlines.
1770
a3de0cbd
MA
17712011-09-24 Michael Albinus <michael.albinus@gmx.de>
1772
1773 * dbusbind.c (Fdbus_register_signal): Add match rule to
1774 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1775 (Fdbus_register_method, Vdbus_registered_objects_table):
1776 Fix docstring.
a3de0cbd 1777
b260039d
JM
17782011-09-24 Jim Meyering <meyering@redhat.com>
1779
32c1fffd 1780 do not ignore write error for any output size
b260039d
JM
1781 The previous change was incomplete.
1782 While it makes emacs --batch detect the vast majority of stdout
1783 write failures, errors were still ignored whenever the output size is
1784 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1785 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1786 && echo FAIL: ignored write error
1787 FAIL: ignored write error
1788 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1789 && echo FAIL: ignored write error
1790 FAIL: ignored write error
1791 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1792
8eca8a7c
AS
17932011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1794
1795 * emacs.c (Fkill_emacs): In noninteractive mode exit
1796 non-successfully if a write error occurred on stdout. (Bug#9574)
1797
3341db62
EZ
17982011-09-21 Eli Zaretskii <eliz@gnu.org>
1799
1800 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1801 the xassert test.
1802
1803 * dispextern.h (struct it): Update the comment documenting what
1804 can it->OBJECT be.
1805
8c203dbf
EZ
18062011-09-20 Eli Zaretskii <eliz@gnu.org>
1807
1808 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1809 a display string, extend search for cursor position to end of row.
1810 (find_row_edges): If the row ends in a newline from a display
1811 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1812 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1813 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1814 non-empty line. Fixes confusing cursor motion with arrow keys at
1815 the beginning of a line that starts with whitespace.
8c203dbf 1816
a4824228
LMI
18172011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1818
1819 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1820 (bug#9493).
1821
33ed493b
CY
18222011-09-18 Chong Yidong <cyd@stupidchicken.com>
1823
1824 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1825 boolean (Bug#9154).
1826
56cd55c8
EZ
18272011-09-18 Eli Zaretskii <eliz@gnu.org>
1828
1829 * xdisp.c (display_line): Record maximum and minimum buffer
1830 positions even if no glyphs were produced (e.g., by a zero-width
1831 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1832 buffer positions that will be removed from the glyph row because
1833 they don't fit.
c02dcedf
EZ
1834 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1835 column is beyond frame width: don't subtract 1 "pixel" when
1836 computing width of the stretch.
3e62b7e0
EZ
1837 (reseat_at_next_visible_line_start): Undo the change made on
1838 2011-09-17 that saved paragraph information and restored it after
1839 the call to `reseat'. (Bug#9545)
56cd55c8 1840
5ed99d36 18412011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1842
1843 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1844 and turn window cursor on if cleared (Bug#9415).
1845
5ed99d36 18462011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1847
1848 * search.c (boyer_moore): Take unibyte characters from pattern
1849 literally. (Bug#9458)
1850
9bade7b2
EZ
18512011-09-18 Eli Zaretskii <eliz@gnu.org>
1852
1853 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1854
e5e9d610
PE
18552011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1856
87e4427a
PE
1857 Fix minor problem found by static checking.
1858 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1859 initialized, to pacify gcc -Wuninitialized.
1860
e5e9d610
PE
1861 * fileio.c: Report proper errno when syscall falls.
1862 (Finsert_file_contents): Save and restore errno,
1863 so that report_file_error outputs the correct diagnostic.
1864 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1865
a1674f0b
EZ
18662011-09-18 Eli Zaretskii <eliz@gnu.org>
1867
1868 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1869
fbfb6dd4
EZ
18702011-09-17 Eli Zaretskii <eliz@gnu.org>
1871
1872 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1873 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1874
bb187662
EZ
18752011-09-17 Eli Zaretskii <eliz@gnu.org>
1876
1137e8b8 1877 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1878 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1879
1880 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1881 (bidi_find_paragraph_start): Search back for paragraph beginning
1882 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1883 (bidi_move_to_visually_next): Only trigger paragraph-related
1884 computations when the last character is a newline or at EOB, not
1885 just any NEUTRAL_B. (Bug#9470)
1886
bb187662
EZ
1887 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1888 truncated lines if point is covered by a display string. (Bug#9524)
1889
2e621251
PE
18902011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1893 (cons_to_x_long): New function.
1894 (lisp_data_to_selection_data): Use it. Correct the test for
1895 short-versus-long data; it was negated. Break out of vector
1896 loop, for efficiency, when a long datum is discovered.
1897
91a15bc6
SM
18982011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1899
1900 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1901
b41c3a35
EZ
19022011-09-16 Eli Zaretskii <eliz@gnu.org>
1903
1904 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1905 GCC PR/17406) by declaring this function with external scope.
1906
7812ba2d
PE
19072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1910 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1911
cf7edc2a
AS
19122011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1913
1914 * editfns.c (Fformat): Correctly handle text properties on "%%".
1915
bd01620e
EZ
19162011-09-15 Eli Zaretskii <eliz@gnu.org>
1917
1918 * xterm.c (x_draw_composite_glyph_string_foreground):
1919 * w32term.c (x_draw_composite_glyph_string_foreground):
1920 * term.c (encode_terminal_code):
1921 * composite.c (composition_update_it, get_composition_id):
1922 * xdisp.c (get_next_display_element)
1923 (fill_composite_glyph_string): Add comments about special meaning
1924 of TAB characters in a composition.
1925
a02719a3
PE
19262011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1929 This occurs when processing a multibyte format.
1930 Problem reported by Wolfgang Jenker.
a02719a3 1931
72589a3c
JB
19322011-09-15 Johan Bockgård <bojohan@gnu.org>
1933
1934 * xdisp.c (try_cursor_movement): Only check for exact match if
1935 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1936
1c14176c
PE
19372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1938
1939 Remove unused external symbols.
1940 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1941 * xdisp.c (calc_pixel_width_or_height): Now static.
1942 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1943 * indent.c (check_display_width):
1944 * w32term.c: Fix comment to match code.
1945 * xterm.c, xterm.h (x_catching_errors): Remove.
1946
d2eea5b5
PE
19472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 * xselect.c: Use signed conversions more consistently (Bug#9498).
1950 (selection_data_to_lisp_data): Assume incoming selection data are
1951 signed integers, not unsigned. This is to be consistent with
1952 outgoing selection data, which was modified to use signed integers
1953 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1954 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1955 expects long, not unsigned long.
1956
46888499
EZ
19572011-09-14 Eli Zaretskii <eliz@gnu.org>
1958
1959 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1960 computation of loop end. Reported by Johan Bockgård
1961 <bojohan@gnu.org>.
1962
ef8ef9fb
CY
19632011-09-13 Chong Yidong <cyd@stupidchicken.com>
1964
1965 * frame.c (Fother_visible_frames_p): Function deleted.
1966
fa819fed
EZ
19672011-09-12 Eli Zaretskii <eliz@gnu.org>
1968
1969 * indent.c (compute_motion): Process display vector front to back
1970 rather than the other way around. (Bug#2496)
1971
2ba8e008
SM
19722011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1973
1974 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1975
20f53c69
CY
19762011-09-11 Chong Yidong <cyd@stupidchicken.com>
1977
1978 * minibuf.c (Fread_from_minibuffer): Doc fix.
1979
d562d7a4
EZ
19802011-09-11 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1983 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1984
1c4d7f3d
LMI
19852011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1986
1987 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1988 value for non-existent files.
1989
b885bf36
EZ
19902011-09-11 Eli Zaretskii <eliz@gnu.org>
1991
1992 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1993 set its "size" to -1. This will set the modtime_size field of
1994 the corresponding buffer to -1, which is what
1995 verify-visited-file-modtime expects for files that do not exist.
1996 (Bug#9139)
1997
6612f0bf
PE
19982011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2001 here ...
2002 * lisp.h: ... from here. push_key_description is no longer
2003 defined in keyboard.c, so its declaration should not be in
2004 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2005 logically belongs with push_key_description.
2006
dfb3f755
PE
20072011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * buffer.h: Include <sys/types.h> instead of <time.h>.
2010 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2011 Problem reported by Herbert J. Skuhra.
2012
3134906c
LMI
20132011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2014
2015 * xml.c (parse_region): Make the parsing work for
2016 non-comment-starting XML files again (bug#9144).
2017
8d903f4e
AS
20182011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2019
2020 * image.c (gif_load): Fix calculation of bottom and right corner.
2021 (Bug#9468)
2022
80ad64f4
EZ
20232011-09-10 Eli Zaretskii <eliz@gnu.org>
2024
2025 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2026 redisplay in small windows.
2027
208a048d
EZ
20282011-09-09 Eli Zaretskii <eliz@gnu.org>
2029
2030 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2031
9b1c252e
MR
20322011-09-08 Martin Rudalics <rudalics@gmx.at>
2033
2034 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2035 Operate on live windows only.
2036
2949f33b
JB
20372011-09-08 Juanma Barranquero <lekktu@gmail.com>
2038
2039 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2040
e08dcafd
EZ
20412011-09-07 Eli Zaretskii <eliz@gnu.org>
2042
2043 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2044 only under bidi iteration.
2045
115b96bd
JD
20462011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2047
2048 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2049
c8199d0f
PE
20502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2053 Without this fix, the command to link temacs failed due to an
2054 undefined symbol __builtin_isnan. This is because
2055 /usr/include/iso/math_c99.h #defines isnan(x) to
2056 __builtin_isnan(x), but the bundled gcc, which identifies itself
2057 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2058 a __builtin_isnan.
2059 * floatfns.c (isnan): #undef, and then #define to a clone of
2060 what's in data.c.
2061 (Fisnan): Always define, since it's always available now.
2062 (syms_of_floatfns): Always define isnan at the Lisp level.
2063
e39b275c 20642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2065
2066 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2067
b2db44d9 20682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2069
f4af5137 2070 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2071 The previous code assumed that file offsets (off_t values) fit in
2072 EMACS_INT variables, which is not true on typical 32-bit hosts.
2073 The code messed up by falsely reporting buffer overflow in cases
2074 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2075 when "big" contains more than 2**29 bytes, even though this
2076 inserts just one byte and does not overflow the buffer.
2077 (Finsert_file_contents): Store file offsets as off_t
2078 values, not as EMACS_INT values. Check for overflow when
2079 converting between EMACS_INT and off_t. When checking for
2080 buffer overflow or for overlap, take the offsets into account.
2081 Don't use EMACS_INT for small values where int suffices.
2082 When checking for overlap, fix a typo: ZV was used where
2083 ZV_BYTE was intended.
2084 (Fwrite_region): Don't assume off_t fits into 'long'.
2085 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2086
ecfc0a49
MA
20872011-09-05 Michael Albinus <michael.albinus@gmx.de>
2088
2089 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2090
6511acf2 20912011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2092
0999621a 2093 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2094
2095 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2096 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2097 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2098 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2099 (modify_event_symbol): Do not assume that the length of
2100 name_alist_or_stem is safe to alloca and fits in int.
2101 (Fexecute_extended_command): Likewise for function name and binding.
2102 (Frecursion_depth): Wrap around reliably on integer overflow.
2103 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2104 since some callers pass EMACS_INT values.
2105 (Fsingle_key_description): Don't crash if symbol name contains more
2106 than MAX_ALLOCA bytes.
2107 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2108 (get_minibuffer): Arg is now EMACS_INT, not int.
2109 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2110 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2111 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2112
2be7d702
PE
2113 * dbusbind.c (signature_cat): New function.
2114 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2115 Do not overrun buffer; instead, report string overflow.
2116
9d1df220
PE
2117 * dispnew.c (add_window_display_history): Don't overrun buffer.
2118 Truncate instead; this is OK since it's just a log.
2119
33ef5c64
PE
2120 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2121 even if the time zone offset is outlandishly large.
2122 Don't mishandle offset == INT_MIN.
2123
66c6fdd5
PE
2124 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2125 when creating daemon; the previous buffer-overflow check was incorrect.
2126
d749b01b
PE
2127 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2128 which has the guts of the old verror function.
2129
b5cd1905
PE
2130 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2131 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2132
6e1a67fb
PE
2133 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2134 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2135 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2136 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2137 length of string rather than counting it via multiple sprintfs;
2138 that's simpler and more reliable.
c21721cc
PE
2139 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2140 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2141 sprintf, in case result does not fit in int.
2142
c57b67fc
PE
2143 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2144 (fontset_from_font): Print it.
2145
8a401434
PE
2146 * frame.c (tty_frame_count): Now printmax_t, not int.
2147 (make_terminal_frame, set_term_frame_name): Print it.
2148 (x_report_frame_params): In X, window IDs are unsigned long,
2149 not signed long, so print them as unsigned.
2150 (validate_x_resource_name): Check for implausibly long names,
2151 and don't assume name length fits in 'int'.
2152 (x_get_resource_string): Don't blindly alloca invocation name;
2153 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2154 not fit in int.
2155
6e1a67fb
PE
2156 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2157 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2158 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2159
0df02bf3
PE
2160 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2161 Use esprintf, not sprintf, in case result does not fit in int.
2162
48e30793
PE
2163 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2164 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2165 it as a large positive number.
2166 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2167 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2168
a66ff6d8
PE
2169 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2170 in case result does not fit in int.
2171
aca216ff
PE
2172 * print.c (float_to_string): Detect width overflow more reliably.
2173 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2174 buffer overrun. Don't assume list length fits in 'int'. Treat
2175 print length of 0 as 0, not as infinity; to be consistent with other
2176 uses of print length in this function. Don't overflow print length
2177 index. Don't assume hash table size fits in 'long', or that
2178 vectorlike size fits in 'unsigned long'.
2179
31c286f7
PE
2180 * process.c (make_process): Use printmax_t, not int, to format
2181 process-name gensyms.
2182
55e5faa1
PE
2183 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2184
80f2e268
PE
2185 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2186 to avoid potential buffer overrun.
2187
670741ab
PE
2188 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2189 if X resource line is longer than 512 bytes.
2190
b7163a50
PE
2191 * xfns.c (x_window): Make sprintf buffer a bit bigger
2192 to avoid potential buffer overrun.
2193
ae58ff1f
PE
2194 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2195
c43c8a6a
PE
2196 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2197
3f8236f4
PE
21982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2199
53e9fe90 2200 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2201 Without these, Emacs silently mishandles large integers sometimes.
2202 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2203 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2204
6511acf2
PE
2205 * xdisp.c (try_window_id): Check Emacs fixnum range before
2206 converting to 'int'.
806add1d 2207
6511acf2 2208 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2209 Check that an Emacs fixnum is in range before assigning it to 'int'.
2210 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2211 values converted from Emacs fixnums.
2212 (Frecenter): Don't wrap around a line count if it is out of 'int'
2213 range; instead, treat it as an extreme value.
2214 (Fset_window_configuration, compare_window_configurations):
2215 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2216
6511acf2
PE
2217 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2218 that can exceed INT_MAX. Check that EMACS_INT value is in range
2219 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2220 (match_limit): Don't assume that a fixnum can fit in 'int'.
2221
6511acf2 2222 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2223 exceed INT_MAX.
2224
6511acf2 2225 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2226 (Fvertical_motion): Don't wrap around LINES values that don't fit
2227 in 'int'. Instead, treat them as extreme values. This is good
2228 enough for windows, which can't have more than INT_MAX lines anyway.
2229
fcb901a7
LMI
22302011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2231
0f2f6b6d
LMI
2232 * Require libxml/parser.h to avoid compilation warning.
2233
fcb901a7
LMI
2234 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2235
2236 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2237 since this reportedly can destroy thread storage.
2238
6e20a0d4
CY
22392011-08-30 Chong Yidong <cyd@stupidchicken.com>
2240
2241 * syntax.c (find_defun_start): Update all cache variables if
2242 exiting early (Bug#9401).
2243
148ae00e
EZ
22442011-08-30 Eli Zaretskii <eliz@gnu.org>
2245
f6cfbd8f
EZ
2246 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2247
148ae00e
EZ
2248 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2249 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2250 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2251
2252 * term.c (tty_append_glyph): New function.
2253 (produce_stretch_glyph): Static function and its prototype deleted.
2254
a66cfb1c
SM
2255 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2256 Add prototypes.
148ae00e 2257
c4a07a4c
PE
22582011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2261 when checking :margin (Bug#9390).
2262 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2263 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2264 so that the name doesn't mislead. All uses changed.
2265
6bc8cd65
JB
22662011-08-28 Johan Bockgård <bojohan@gnu.org>
2267
2268 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2269 set_tty_hooks.
2270
dca4927e
EZ
22712011-08-27 Eli Zaretskii <eliz@gnu.org>
2272
2273 * xdisp.c (move_it_to): Don't bail out early when reaching
2274 position beyond to_charpos, if we are scanning backwards.
2275 (move_it_vertically_backward): When DY == 0, make sure we get to
2276 the first character in the line after the newline.
2277
f2cad773
PE
22782011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2281 (ccl_driver): Do not generate an out-of-range pointer.
2282 (Fccl_execute_on_string): Remove unnecessary check for
2283 integer overflow, noted by Stefan Monnier in
2284 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2285 Remove a FIXME that didn't need fixing.
2286 Simplify the newly-introduced buffer reallocation code.
2287
0cae2cdb
JB
22882011-08-27 Juanma Barranquero <lekktu@gmail.com>
2289
2290 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2291
5fc295a4 22922011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2293
70c60eb2 2294 Integer and memory overflow issues (Bug#9196).
726e0ab1 2295
d31850da
PE
2296 * doc.c (get_doc_string): Rework so that
2297 get_doc_string_buffer_size is the actual buffer size, rather than
2298 being 1 less than the actual buffer size; this makes xpalloc more
2299 convenient.
2300
a69fbedb
PE
2301 * image.c (x_allocate_bitmap_record, cache_image):
2302 * xselect.c (Fx_register_dnd_atom):
2303 Simplify previous changes by using xpalloc.
2304
fe5c5d37
PE
2305 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2306 since either will do and ptrdiff_t is convenient with xpalloc.
2307
0065d054
PE
2308 * charset.c (charset_table_size)
2309 (struct charset_sort_data.priority): Now ptrdiff_t.
2310 (charset_compare): Don't overflow if priorities differ greatly.
2311 (Fsort_charsets): Don't assume list length fits in int.
2312 Check for size-calculation overflow when allocating sort data.
2313 (syms_of_charset): Allocate an initial charset table that is
2314 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2315
2316 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2317
2318 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2319 The actual value is always <= INT_MAX, and leaving it unsigned made
2320 overflow checking harder.
2321
2322 * dispextern.h (struct glyph_matrix.rows_allocated)
2323 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2324 with xpalloc. The values are still always <= INT_MAX.
2325
2326 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2327
2328 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2329 (SAFE_NALLOCA): New macro.
2330
2331 * region-cache.c (struct boundary.pos, find_cache_boundary)
2332 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2333 (set_cache_region, invalidate_region_cache)
2334 (revalidate_region_cache, know_region_cache, region_cache_forward)
2335 (region_cache_backward, pp_cache):
2336 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2337 so that ptrdiff_t * can be passed to xpalloc.
2338 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2339 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2340 (pp_cache): Don't assume cache_len fits in int.
2341 * region-cache.h: Adjust extern decls to match.
2342
2343 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2344 EMACS_INT, since either will do, for xpalloc.
2345
2346 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2347 (xnmalloc, xnrealloc, xpalloc): New functions.
2348
726e0ab1
PE
2349 * bidi.c (bidi_shelve_header_size): New constant.
2350 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2351 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2352
51f30bc5 2353 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2354 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2355 (overlay_strings):
2356 Don't update size of array until after memory allocation succeeds,
2357 because xmalloc/xrealloc may not return.
0065d054
PE
2358 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2359 now that we have proper integer overflow checking.
2360 (record_overlay_string, overlay_strings): Catch overflows when
2361 calculating size of overlay_str_buf.
726e0ab1 2362
0065d054
PE
2363 * callproc.c (Fcall_process): Check for size overflow when
2364 calculating size of args2.
2365 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2366 Normally we prefer signed values, but sticking with ptrdiff_t would
2367 require adding more-complicated checks.
726e0ab1
PE
2368
2369 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2370 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2371 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2372 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2373
2374 * character.c (Fstring): Check for size-calculation overflow.
2375
2376 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2377 unnecessary integer overflow. Check for size overflow.
2378 (encode_coding_object): Don't update size until xmalloc succeeds.
2379
2380 * composite.c (get_composition_id): Check for overflow in glyph
2381 length calculations.
2382
2383 Integer and memory overflow fixes for display code.
2384 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2385 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2386 (scrolling_window): Check for overflow in size calculations.
2387 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2388 Don't assume glyph table len fits in int.
2389 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2390 (row_table_size): Now ptrdiff_t, not int.
2391 (scrolling_window): Avoid overflow in size calculations.
2392 Don't update size until allocation succeeds.
2393 * fns.c (concat): Check for overflow in size calculations.
2394 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2395 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2396 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2397
2398 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2399 (get_doc_string): Check for size calculation overflow.
2400 Don't update size until allocation succeeds.
2401 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2402 EMACS_INT, where ptrdiff_t will do.
2403 (Fsubstitute_command_keys): Check for string overflow.
2404
2405 * editfns.c (set_time_zone_rule): Don't assume environment length
2406 fits in int.
2407 (message_length): Now ptrdiff_t, not int.
2408 (Fmessage_box): Don't update size until allocation succeeds.
2409 Don't assume message length fits in int.
2410 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2411
0065d054
PE
2412 * emacs.c (main): Do not reallocate argv, since there is a null at
2413 the end that can be overwritten, and this way there's no need to
2414 worry about size-calculation overflow.
2415 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2416
2417 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2418 alloc succeeds.
2419 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2420
2421 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2422 (x_set_scroll_bar_width, x_figure_window_size):
2423 Check for integer overflow.
2424 (x_set_alpha): Do not assume XINT fits in int.
2425
2426 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2427 This is for the members text_lines, text_cols, total_lines, total_cols,
2428 where the system imposes an 'int' limit.
2429
2430 * fringe.c (Fdefine_fringe_bitmap):
2431 Don't update size until alloc works.
2432
2433 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2434 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2435
2436 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2437 Check for size-calculation overflow.
2438 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2439 do, as we prefer signed integers.
2440 (id_to_widget.max_size, id_to_widget.used)
2441 (xg_store_widget_in_map, xg_remove_widget_from_map)
2442 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2443 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2444 Use and return ptrdiff_t, not int.
2445 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2446 * gtkutil.h: Change prototypes to match the above.
2447
2448 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2449 are duplicate now that they've been promoted to lisp.h.
2450 (x_allocate_bitmap_record, x_alloc_image_color)
2451 (make_image_cache, cache_image, xpm_load):
2452 Don't update size until alloc is done.
2453 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2454 (x_detect_edges):
3256efce 2455 Check for size calculation overflow.
726e0ab1
PE
2456 (ct_colors_allocated_max): New constant.
2457 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2458 overflow.
3256efce 2459
726e0ab1
PE
2460 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2461 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2462 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2463 Use ptrdiff_t, not int, to count maps.
2464 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2465 calculations. Don't update size until allocation succeeds.
2466 Redo calculations to avoid overflow.
726e0ab1
PE
2467 * keyboard.h: Change prototypes to match the above.
2468
2469 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2470 to count maps.
2471 (current_minor_maps): Check for size calculation overflow.
2472 * keymap.h: Change prototypes to match the above.
2473
2474 * lread.c (read1, init_obarray): Don't update size until alloc done.
2475
2476 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2477 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2478
726e0ab1
PE
2479 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2480 Now ptrdiff_t, not int.
2481 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2482 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2483
2484 * process.c (Fnetwork_interface_list): Check for overflow
2485 in size calculation.
2486
2487 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2488
2489 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2490 overflow. Don't bother calling xmalloc when xrealloc will do.
2491
2492 * search.c (Freplace_match): Check for size calculation overflow.
2493 (Fset_match_data): Don't assume list lengths fit in 'int'.
2494
2495 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2496 for command line length. Do not attempt to address one before the
2497 beginning of an array, as that's not portable.
2498
2499 * term.c (max_frame_lines): Remove; unused.
2500 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2501 not int.
2502 (encode_terminal_code, calculate_costs): Check for size
2503 calculation overflow.
2504 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2505 table lengths and related sizes. Don't update size until alloc
2506 done. Redo calculations to avoid overflow.
2507 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2508
2509 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2510 subtracting pointers.
2511 (gobble_line): Check for overflow more carefully. Don't update size
2512 until alloc done.
2513
2514 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2515 Don't update size until alloc done.
2516 Redo size calculations to avoid overflow.
2517 Check for size calculation overflow.
0065d054 2518 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2519
2520 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2521 Use ptrdiff_t, not int, for sizes.
2522 (store_mode_line_noprop_char): Don't update size until alloc done.
2523
0065d054
PE
2524 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2525 Use ptrdiff_t, not int, for sizes.
2526 (Finternal_make_lisp_face, cache_face):
2527 Check for size calculation overflow.
2528 (cache_face): Treat size calculation overflows as if they were
2529 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2530
2531 * xfns.c (x_encode_text, x_set_name_internal)
2532 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2533 sizes, since they can exceed INT_MAX in size. Check for size
2534 calculation overflow.
2535
0065d054
PE
2536 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2537 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2538 Don't update size until alloc done.
2539
0065d054 2540 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2541 as sprintf is limited to int lengths.
1d526e2f 2542
252c5ee1
PE
2543 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2544 (X_LONG_MIN): New macros.
864d7ce7
PE
2545 Use them to make the following changes clearer.
2546 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2547 This change doesn't affect the value now, but it may help remind
2548 future maintainers not to raise the value too much later.
2549 (SELECTION_QUANTUM): Remove, replacing with ...
2550 (selection_quantum): ... new function, which avoids overflow.
2551 All uses changed.
2552 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2553 assumption that selection length fits in 'int'.
2554 (x_reply_selection_request, x_handle_selection_request)
2555 (x_get_window_property, receive_incremental_selection)
2556 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2557 (lisp_data_to_selection_data, clean_local_selection_data):
2558 Use ptrdiff_t, not int, to record length of selection.
2559 (x_reply_selection_request, x_get_window_property)
2560 (receive_incremental_selection, x_property_data_to_lisp):
2561 Redo calculations to avoid overflow.
2562 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2563 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2564 something.
2565 (x_get_window_property, receive_incremental_selection)
2566 (lisp_data_to_selection_data, x_property_data_to_lisp):
2567 Check for size-calculation overflow.
2568 (x_get_window_property, receive_incremental_selection)
2569 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2570 Don't store size until memory allocation succeeds.
2571 (x_get_window_property): Plug memory leak on memory exhaustion.
2572 Don't double-block input; malloc is safe here. Don't assume 2**34
2573 - 4 fits in unsigned long. Add an xassert to check
2574 XGetWindowProperty overflow. Be more careful about overflow
2575 calculations, and distinguish size from memory overflow better.
2576 (receive_incremental_selection): When tracing, don't assume
2577 unsigned int is less than INT_MAX.
2578 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2579 harmful) conversions of unsigned short to int.
2580 (lisp_data_to_selection_data): Don't assume that integers
2581 in the range -65535 through -1 fit in an X unsigned short.
2582 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2583 result parameters unless successful. Rely on cons_to_unsigned
2584 to report problems with elements; the old code wasn't right anyway.
2585 (x_check_property_data): Check for int overflow; we cannot use
2586 a wider type due to X limits.
2587 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2588
726e0ab1 2589 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2590
0065d054
PE
2591 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2592 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2593 (x_color_cells): Don't store size until memory allocation succeeds.
2594 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2595 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2596 (x_term_init): Don't assume length fits in int (sprintf is limited
2597 to int size).
bc18e09d 2598
ebfa62c0
PE
2599 Use ptrdiff_t for composition IDs.
2600 * character.c (lisp_string_width):
2601 * composite.c (composition_table_size, n_compositions)
2602 (get_composition_id, composition_gstring_from_id):
2603 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2604 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2605 * window.c (Frecenter):
2606 Use ptrdiff_t, not int, for composition IDs.
2607 * composite.c (get_composition_id): Check for integer overflow.
2608 * composite.h: Adjust prototypes to match the above changes.
2609
d3411f89
PE
2610 Use ptrdiff_t for hash table indexes.
2611 * category.c (hash_get_category_set):
2612 * ccl.c (ccl_driver):
2613 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2614 * coding.c (coding_system_charset_list, detect_coding_system):
2615 * coding.h (struct coding_system.id):
2616 * composite.c (get_composition_id, gstring_lookup_cache):
2617 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2618 * image.c (xpm_get_color_table_h):
2619 * lisp.h (hash_lookup, hash_put):
2620 * minibuf.c (Ftest_completion):
2621 Use ptrdiff_t for hash table indexes, not int (which is too
2622 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2623 32-bit --with-wide-int hosts).
2624
e097a6fa
PE
2625 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2626 Add a FIXME comment about memory leaks.
2627 (syms_of_charset): Don't assume xmalloc returns.
2628
5637687f
PE
2629 Don't assume that stated character widths fit in int.
2630 * character.c (Fchar_width, c_string_width, lisp_string_width):
2631 * character.h (CHAR_WIDTH):
2632 * indent.c (MULTIBYTE_BYTES_WIDTH):
2633 Use sanitize_char_width to avoid undefined and/or bad behavior
2634 with outlandish widths.
a66cfb1c 2635 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2636 now that we have two such functions. All uses changed.
2637 (sanitize_char_width): New inline function.
2638
a2271ba2
PE
2639 Don't assume that tab-width fits in int.
2640 * character.h (sanitize_width): New inline function.
2641 (SANE_TAB_WIDTH): New macro.
2642 (ASCII_CHAR_WIDTH): Use it.
2643 * indent.c (sane_tab_width): Remove. All uses replaced by
2644 SANE_TAB_WIDTH (current_buffer).
2645 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2646
18c52557
PE
2647 * fileio.c: Integer overflow issues with file modes.
2648 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2649
caeeedc1
PE
2650 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2651 Remove unreachable code.
2652 (read_hex, load_charset_map_from_file): Check for integer overflow.
2653
6df6ae42 2654 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2655 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2656 (x_send_scroll_bar_event): Likewise. Check that the size does not
2657 exceed limits imposed by XClientMessageEvent, as well as the usual
2658 ptrdiff_t and size_t limits.
2659
b13995db
PE
2660 * keyboard.c: Overflow, signedness and related fixes.
2661 (make_lispy_movement): Use same integer type in forward decl
2662 that is used in the definition.
2663 (read_key_sequence, keyremap_step):
2664 Change bufsize argument back to int, undoing my 2011-03-30 change.
2665 We prefer signed types, and int is wide enough here.
2666 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2667 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2668 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2669 length, not size_t. Use ptrdiff_t for index, not int.
2670 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2671 possibility of integer overflow.
2672
13464394
PE
2673 Overflow, signedness and related fixes for images.
2674
2675 * dispextern.h (struct it.stack[0].u.image.image_id)
2676 (struct_it.image_id, struct image.id, struct image_cache.size)
2677 (struct image_cache.used, struct image_cache.ref_count):
2678 * gtkutil.c (update_frame_tool_bar):
2679 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2680 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2681 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2682 * nsmenu.m (update_frame_tool_bar):
2683 * xdisp.c (calc_pixel_width_or_height):
2684 * xfns.c (image_cache_refcount):
2685 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2686 on typical 64-bit hosts.
2687
2688 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2689 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2690 Omit unnecessary casts to int.
2691 (parse_image_spec): Check that integers fall into 'int' range
2692 when the callers expect that.
2693 (image_ascent): Redo ascent calculation to avoid int overflow.
2694 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2695 (lookup_image): Remove unnecessary tests.
2696 (xbm_image_p): Locals are now of int, not EMACS_INT,
2697 since parse_image_check makes sure they fit into int.
2698 (png_load, gif_load, svg_load_image):
2699 Prefer int to unsigned where either will do.
2700 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2701 old tiff_error_handler and tiff_warning_handler.
2702 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2703 stack buffer overflows. It uses only the features of vsnprintf
2704 that are common to both POSIX and native Microsoft.
2705 (tiff_error_handler, tiff_warning_handler): Use it.
2706 (tiff_load, gif_load, imagemagick_load_image):
2707 Don't assume :index value fits in 'int'.
2708 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2709 (imagemagick_load_image): Check that crop parameters fit into
2710 the integer types that MagickCropImage accepts. Don't assume
2711 Vimagemagick_render_type has a nonnegative value. Don't assume
2712 size_t fits in 'long'.
2713 (gs_load): Use printmax_t to print the widest integers possible.
2714 Check for integer overflow when computing image height and width.
2715
c11821d4
EZ
27162011-08-26 Eli Zaretskii <eliz@gnu.org>
2717
2718 * xdisp.c (redisplay_window): Don't force window start if point
2719 will be invisible in the resulting window. (Bug#9324)
2720
0c95fcf7
EZ
27212011-08-25 Eli Zaretskii <eliz@gnu.org>
2722
2723 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2724 the display spec is of the form `(space ...)'.
2725 (handle_display_spec): Return the value returned by
2726 handle_single_display_spec, not just 1 or zero.
2727 (handle_single_display_spec): If the display spec is of the form
2728 `(space ...)', and specifies display in the text area, return 2
2729 rather than 1.
fee65a97 2730 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2731 accurately, and prefer exact match for point under bidi.
2732 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2733
2734 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2735 into disp_prop; all users changed.
2736
2737 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2738 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2739 for the text covered by the display property.
2740
e4ed06f1
CY
27412011-08-25 Chong Yidong <cyd@stupidchicken.com>
2742
2743 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2744 Change return value to nil.
2745 (Frecord_buffer): Delete unused function.
2746
f67cdd7f
EZ
27472011-08-24 Eli Zaretskii <eliz@gnu.org>
2748
5980d4c6
EZ
2749 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2750 buffers, return left-to-right.
8610fe8b
EZ
2751 (set_cursor_from_row): Consider candidate row a win if its glyph
2752 represents a newline and point is on that newline. Fixes cursor
2753 positioning on the newline at EOL of R2L text within L2R
2754 paragraph, and vice versa.
2755 (try_cursor_movement): Check continued rows, in addition to
2756 continuation rows. Fixes unwarranted scroll when point enters a
2757 continued line of R2L text within an L2R paragraph, or vice versa.
2758 (cursor_row_p): Consider the case of point being equal to
2759 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2760 from the end of a short line to the beginning of a continued line
2761 of R2L text within L2R paragraph.
2762 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2763 composed characters.
5980d4c6 2764
f67cdd7f
EZ
2765 * bidi.c (bidi_check_type): Use xassert.
2766 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2767 members.
2768
bca633fb
EZ
27692011-08-23 Eli Zaretskii <eliz@gnu.org>
2770
2771 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2772 a character.
2773
4a5885a7
CY
27742011-08-23 Chong Yidong <cyd@stupidchicken.com>
2775
2776 * nsfont.m (ns_otf_to_script): Fix typo.
2777
0902a04e
KH
27782011-08-22 Kenichi Handa <handa@m17n.org>
2779
2780 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2781 extra slot even if the purpose is char-code-property-table.
2782
1a2e6670
EZ
27832011-08-23 Eli Zaretskii <eliz@gnu.org>
2784
8ddde651
EZ
2785 * xdisp.c (redisplay_window): When computing centering_position,
2786 account for the height of the header line. (Bug#8874)
2787
425cc014
EZ
2788 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2789 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2790 candidate is selected by the mouse, and that candidate has a
2791 composed character under the mouse.
2792
1a2e6670
EZ
2793 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2794 coordinates reported by pos-visible-in-window-p for a composed
2795 character in column zero.
2796
8b76d6f8
SM
27972011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2798
2799 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2800
dac347dd
EZ
28012011-08-22 Eli Zaretskii <eliz@gnu.org>
2802
2803 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2804 consider it a hit if to_charpos is anywhere in the range of the
2805 composed buffer positions.
2806
e013fb34
CY
28072011-08-22 Chong Yidong <cyd@stupidchicken.com>
2808
2809 * image.c (gif_load): Don't assume that each subimage has the same
2810 dimensions as the base image. Handle disposal method that is
2811 "undefined" by the gif spec (Bug#9335).
2812
bd1ba3e8
CY
28132011-08-20 Chong Yidong <cyd@stupidchicken.com>
2814
2815 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2816 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2817
54a1215b
EZ
28182011-08-19 Eli Zaretskii <eliz@gnu.org>
2819
823564e5
EZ
2820 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2821 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2822 from an Org mode buffer to a Speedbar frame.
2823
54a1215b
EZ
2824 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2825 a composition, take its buffer position from IT->cmp_it.charpos.
2826 Fixes cursor positioning at the beginning of a line that begins
2827 with a composed character.
2828
9778ebcc
EZ
28292011-08-18 Eli Zaretskii <eliz@gnu.org>
2830
0be6ee06
EZ
2831 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2832 character bidirectional type, use STRONG_L instead. Fixes crashes
2833 in a buffer produced by `describe-categories'.
2834
9778ebcc
EZ
2835 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2836 members before the level stack, so they would be saved and
2837 restored when copying iterator state. Fixes incorrect reordering
2838 around TABs covered by display properties.
2839
156bffbe
AS
28402011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2841
6b02f655 2842 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2843
72ad093b
CY
28442011-08-17 Chong Yidong <cyd@stupidchicken.com>
2845
2846 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2847 (internal_condition_case_2, internal_condition_case_n):
2848 Remove unnecessary aborts (Bug#9081).
72ad093b 2849
35774242
EZ
28502011-08-17 Eli Zaretskii <eliz@gnu.org>
2851
2852 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2853 has no `load' handler, try opening the file locally. (Bug#9311)
2854
db76dd85
KB
28552011-08-16 Ken Brown <kbrown@cornell.edu>
2856
2857 * gmalloc.c: Expand comment.
2858
b215eee5
EZ
28592011-08-16 Eli Zaretskii <eliz@gnu.org>
2860
2861 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2862 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2863
a4579d33
KB
28642011-08-16 Ken Brown <kbrown@cornell.edu>
2865
2866 Fix memory allocation problems in Cygwin build (Bug#9273).
2867
2868 * unexcw.c ( __malloc_initialized): Declare external variable.
2869 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2870
8b76d6f8
SM
2871 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2872 New variables.
a4579d33
KB
2873 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2874 dumped emacs.
2875 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2876 in the static heap.
2877 [CYGWIN] (special_realloc): New function.
2878 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2879 requests to realloc storage in the static heap.
2880
3ebec551
PE
28812011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 * bidi.c (bidi_initialize): Remove unused local.
2884
9fd8be00
EZ
28852011-08-15 Eli Zaretskii <eliz@gnu.org>
2886
6b02f655
SM
2887 * bidimirror.h:
2888 * biditype.h: Remove file.
2889 * makefile.w32-in ($(BLD)/bidi.$(O)):
2890 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2891
2892 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2893
2894 * chartab.c: Improve commentary for the uniprop_table API.
2895
32413314
EZ
2896 * bidi.c (bidi_paragraph_init): Support zero value of
2897 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2898 (bidi_initialize): Use uniprop_table instead of including
2899 biditype.h and bidimirror.h.
32413314 2900
9fd8be00
EZ
2901 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2902 coordinates of the iterator when restoring from ppos_it.
2903 (Bug#9296)
2904
5cf2b69b
KH
29052011-08-14 Kenichi Handa <handa@m17n.org>
2906
2907 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2908 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2909
daf17d00
EZ
29102011-08-14 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (move_it_in_display_line_to): Don't invoke
2913 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2914 ppos_it. Fixes vertical cursor motion when line beginning is
2915 covered by an image. (Bug#9296)
2916
08e3161a
JD
29172011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2918
2919 * nsterm.h (ns_run_ascript): Declare.
2920 (NSAPP_DATA2_RUNASSCRIPT): Define.
2921
2922 * nsfns.m (as_script, as_result, as_status): New static variables.
2923 (ns_run_ascript): New function.
5e617bc2 2924 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2925 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2926 the event loop. Get status from as_status (Bug#7276).
2927
2928 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2929 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2930 the event loop (Bug#7276).
2931
a3720aa2
AS
29322011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2933
2934 * gnutls.c (QCgnutls_bootprop_priority)
2935 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2936 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2937 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2938 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2939 (QCgnutls_bootprop_verify_hostname_error)
2940 (QCgnutls_bootprop_callbacks_verify): Rename from
2941 Qgnutls_bootprop_..., all uses changed.
2942
2943 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2944 uses changed.
2945
0a0d27fb
PE
29462011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2947
19d5c50c
PE
2948 * xfaces.c (Qframe_set_background_mode): Now static.
2949 * dispextern.h (Qframe_set_background_mode): Remove decl.
2950
0a0d27fb
PE
2951 * process.c (Fnetwork_interface_info): Declare local only if needed.
2952
377538cb
JD
29532011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2954
2955 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2956 (Fnetwork_interface_list): Allocate in increments of bytes instead
2957 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2958 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2959 sockaddr.
2960 (struct ifflag_def): notrailers is smart on OSX.
2961 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2962 Get hardware address with getifaddrs if available.
2963
08fff70c
EZ
29642011-08-12 Eli Zaretskii <eliz@gnu.org>
2965
2966 * xdisp.c (iterate_out_of_display_property): xassert that
2967 IT->position is set to within IT->object's boundaries. Break from
2968 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2969 when IT->position is set up wrongly due to some bug.
2970 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2971 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2972 entry. Force push_it to save on the stack the current
2973 buffer/string position, to be restored by pop_it. Fix flags in
2974 the iterator structure wrt the object coming from a display
2975 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2976 properties. (Bug#9284)
2977
7be1c708 29782011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2979
7be1c708
CY
2980 * fontset.c (fontset_get_font_group): Add proper type checks.
2981 (Bug#9172)
aac0c6e3 2982
7be1c708 29832011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2984
7be1c708
CY
2985 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2986 and LC_VERSION_MIN_MACOSX.
2987 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2988 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2989
97bb72a6
EZ
29902011-08-08 Eli Zaretskii <eliz@gnu.org>
2991
2992 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2993 no-display-properties-and-no-overlays under bidi display.
2994 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2995 properties and overlays.
97bb72a6 2996
d5617611
CY
29972011-08-08 Chong Yidong <cyd@stupidchicken.com>
2998
37e11a63
CY
2999 * editfns.c (Fset_time_zone_rule): Document relationship with the
3000 setenv function.
3001
d5617611
CY
3002 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3003 the font entity extracted from the cache (Bug#8109).
3004
58872834
CY
30052011-08-07 Chong Yidong <cyd@stupidchicken.com>
3006
3007 * composite.c (autocmp_chars): Don't reset point. That is done by
3008 restore_point_unwind (Bug#5984).
3009
75bfc667
JL
30102011-08-07 Juri Linkov <juri@jurta.org>
3011
3012 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3013 to show the arg `TIME' instead of `TIMEVAL'.
3014
d1410150
EZ
30152011-08-06 Eli Zaretskii <eliz@gnu.org>
3016
3017 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3018 display property strides EOL and includes a newline, as in
3019 longlines-mode. (Bug#9254)
75b771e4
EZ
3020 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3021 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3022
3023 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3024 is non-zero, even if the data buffer is NULL. Fixes a crash in
3025 vertical-motion with longlines-mode. (Bug#9254)
3026
35928349
EZ
30272011-08-05 Eli Zaretskii <eliz@gnu.org>
3028
ec7cc85b
EZ
3029 * bidi.c <bidi_cache_total_alloc>: Now static.
3030 (bidi_initialize): Initialize bidi_cache_total_alloc.
3031
8b76d6f8 3032 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3033 cache. (Bug#9221)
3034
3035 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3036 amount allocated this far in `bidi_cache_total_alloc'.
3037 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3038 non-zero, only free the data buffer without restoring the cache
3039 contents. All callers changed.
3040
3041 * dispextern.h (bidi_unshelve_cache): Update prototype.
3042
3043 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3044 (move_it_in_display_line, move_it_to)
3045 (move_it_vertically_backward, move_it_by_lines): Replace the call
3046 to xfree to an equivalent call to bidi_unshelve_cache.
3047 (move_it_in_display_line_to): Fix logic of returning
412b6358 3048 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3049
e2e2423b
EZ
30502011-08-05 Eli Zaretskii <eliz@gnu.org>
3051
3052 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3053 came from a string character with a `cursor' property. (Bug#9229)
3054
ae9e757a
JD
30552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3056
3057 * Makefile.in (LIB_PTHREAD): New variable.
3058 (LIBES): Add LIB_PTHREAD (Bug#9216).
3059
3060 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3061 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3062
213bd7f2
AS
30632011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3064
6b02f655 3065 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3066
99aaf75f
JD
30672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3068
3069 * xterm.c (x_find_topmost_parent): New function.
3070 (x_set_frame_alpha): Find topmost parent window with
3071 x_find_topmost_parent and set the property there also (bug#9181).
3072 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3073
c74e9d86
PE
30742011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3075
3076 * callproc.c (Fcall_process): Avoid vfork clobbering
3077 the local vars buffer, coding_systems, current_dir.
3078
640c8776
SM
30792011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3080
3081 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3082
f26d0e4c
PE
30832011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3084
8a10d76c
PE
3085 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3086 so that it is not optimized away.
3087
f26d0e4c
PE
3088 * xdisp.c (compute_display_string_pos): Remove unused local.
3089
55439c61
EZ
30902011-08-02 Eli Zaretskii <eliz@gnu.org>
3091
3092 Fix slow cursor motion and scrolling in large buffers with
3093 selective display, like Org Mode buffers. (Bug#9218)
3094
3095 * dispextern.h (struct bidi_it): New member disp_prop_p.
3096
3097 * xdisp.c: Remove one-slot cache of display string positions.
3098 (compute_display_string_pos): Accept an additional argument
5e617bc2 3099 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3100 for a display string or property. If found, set DISP_PROP_P
3101 non-zero.
3102
3103 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3104 DISP_PROP_P, and pass it to compute_display_string_pos.
3105 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3106 non-zero. All callers of bidi_fetch_char changed.
3107
fb33fa43
SM
31082011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3109
3110 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3111
b099e063
DM
31122010-12-03 Don March <don@ohspite.net>
3113
3114 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3115 last character M-[char] is translated to ESC [char] (bug#7541).
3116
5cc7f7af
KH
31172011-08-02 Kenichi Handa <handa@m17n.org>
3118
d0fffa3f 3119 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3120
3121 * chartab.c (uniprop_table): Make it non-static.
3122
525d5e6e
EZ
31232011-08-01 Eli Zaretskii <eliz@gnu.org>
3124
3125 * xdisp.c (forward_to_next_line_start): Accept additional argument
3126 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3127 on the newline.
3128 (reseat_at_next_visible_line_start): Use the bidi iterator state
3129 returned by forward_to_next_line_start to restore the state of
3130 it->bidi_it after backing up to previous newline. (Bug#9212)
3131
31011111
AS
31322011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3133
3134 * regex.c (re_comp): Protoize.
3135 (re_exec): Fix return type.
3136 (regexec): Fix type of `ret'. (Bug#9203)
3137
476371c4
PE
31382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3139
e5d76069
PE
3140 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3141 This is needed if max-image-size is a floating-point number.
3142
9a79b20c
AS
31432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3144
3145 * print.c (print_object): Print empty symbol as ##.
3146
3147 * lread.c (read1): Read ## as empty symbol.
3148
d8c2fa78
AA
31492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3150
3151 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3152 setting frame foreground color (Bug#9175).
3153 (x_set_background_color): Likewise.
3154
ffe57a7a
AA
3155 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3156 contents (Bug#9176).
3157 (EmacsTooltip -init): Remove bezels and add shadows to
3158 tooltip windows.
3159
bf3492a5
AA
3160 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3161 or scroll bar (Bug#8470).
3162
d55e9c53
AA
3163 * nsfont.m (nsfont_open): Remove assignment to voffset and
3164 unnecessary vars hshink, expand, hd, full_height, min_height.
3165 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3166
3167 * nsterm.h (nsfont_info): Remove voffset field.
3168
d8c2fa78 31692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3170
3171 Implement strike-through and overline on NextStep (Bug#8863).
3172
3173 * nsfont.m (nsfont_open): Use underline position provided by font,
3174 instead of hard-coded value of 2.
3175 (nsfont_draw): Call ns_draw_text_decoration instead.
3176
3177 * nsterm.h: Add declaration for ns_draw_text_decoration.
3178
3179 * nsterm.m (ns_draw_text_decoration): New function for drawing
3180 underline, overline, and strike-through.
3181 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3182 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3183 accommodate underlining, etc.
4843aac3 3184
4cc60b9b
EZ
31852011-07-28 Eli Zaretskii <eliz@gnu.org>
3186
bc7ece87
EZ
3187 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3188 default.
4cc60b9b 3189
476371c4
PE
31902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3191
66606eea
PE
3192 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3193 Without this fix, if a signal arrives just after memory fills up,
3194 'malloc' might be invoked reentrantly.
3195
476371c4
PE
3196 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3197 In other words, assume that every image size is allowed, on non-X
3198 hosts. This assumption is probably wrong, but it lets Emacs compile.
3199
f3fcc40d
AS
32002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3201
3202 * regex.c (re_iswctype): Convert return values to boolean.
3203
350c992f
EZ
32042011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3205
3206 * xdisp.c (compute_display_string_pos): Don't use cached display
3207 string position if the buffer had its restriction changed.
3208 (Bug#9184)
3209
5266b4bb
PE
32102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3213
2573a837 32142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3215
41f55ccd 3216 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3217
39e378da
PE
3218 * bidi.c: Integer size and overflow fixes.
3219 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3220 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3221 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3222 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3223 (bidi_find_other_level_edge):
3224 Use ptrdiff_t instead of EMACS_INT where either will do.
3225 This works better on 32-bit hosts configured --with-wide-int.
3226 (bidi_cache_ensure_space): Check for size-calculation overflow.
3227 Use % rather than repeated addition, for better worst-case speed.
3228 Don't set bidi_cache_size until after xrealloc returns, because it
3229 might not return.
3230 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3231 (bidi_cache_ensure_space): Also check that the bidi cache size
3232 does not exceed that of the largest Lisp string or buffer. See Eli
3233 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3234
5e927815
PE
3235 * alloc.c (__malloc_size_t): Remove.
3236 All uses replaced by size_t. See Andreas Schwab's note
3237 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3238
ca4aa935
PE
3239 * image.c: Improve checking for integer overflow.
3240 (check_image_size): Assume that f is nonnull, since
3241 it is always nonnull in practice. This is one less thing to
3242 worry about when checking for integer overflow later.
3243 (x_check_image_size): New function, which checks for integer
3244 overflow issues inside X.
3245 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3246 This removes the need for a memory_full check.
3247 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3248 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3249 (xbm_read_bitmap_data): Change locals back to 'int', since
3250 their values must fit in 'int'.
3251 (xpm_load_image, png_load, tiff_load):
3252 Invoke x_create_x_image_and_pixmap earlier,
3253 to avoid much needless work if the image is too large.
3254 (tiff_load): Treat overly large images as if
3255 x_create_x_image_and_pixmap failed, not as malloc failures.
3256 (gs_load): Use x_check_image_size.
3257
5f8f9cc2
PE
3258 * gtkutil.c: Omit integer casts.
3259 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3260 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3261
5adf60bc
PE
3262 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3263
c8907a93
PE
3264 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3265 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3266 would wrongly return t on a 64-bit host.
3267
e3c25c68
PE
3268 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3269 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3270 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3271 and therefore cause GCC to emit a bogus diagnostic in some cases.
3272
3f791afe
PE
3273 * image.c: Integer signedness and overflow and related fixes.
3274 This is not an exhaustive set of fixes, but it's time to
3275 record what I've got.
3276 (lookup_pixel_color, check_image_size): Remove redundant decls.
3277 (check_image_size): Don't assume that arbitrary EMACS_INT values
3278 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3279 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3280 (tiff_load, imagemagick_load_image):
3281 Check for overflow in size calculations.
3282 (x_create_x_image_and_pixmap): Remove unnecessary test for
3283 xmalloc returning NULL; that can't happen.
3284 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3285 (xpm_color_bucket): Use better integer hashing function.
3286 (xpm_cache_color): Don't possibly over-allocate memory.
3287 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3288 (gif_memory_source):
3289 Use ptrdiff_t, not int or size_t, to record sizes.
3290 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3291 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3292 either works, as we prefer signed integers.
3293 (tiff_read_from_memory, tiff_write_from_memory):
3294 Return tsize_t, not size_t, since that's what the TIFF API wants.
3295 (tiff_read_from_memory): Don't fail simply because the read would
3296 go past EOF; instead, return a short read.
3297 (tiff_load): Omit no-longer-needed casts.
3298 (Fimagemagick_types): Don't assume size fits into 'int'.
3299
3cc5a532
PE
3300 Improve hashing quality when configured --with-wide-int.
3301 * fns.c (hash_string): New function, taken from sxhash_string.
3302 Do not discard information about ASCII character case; this
3303 discarding is no longer needed.
3304 (sxhash-string): Use it. Change sig to match it. Caller changed.
3305 * lisp.h: Declare it.
3306 * lread.c (hash_string): Remove, since we now use fns.c's version.
3307 The fns.c version returns a wider integer if --with-wide-int is
3308 specified, so this should help the quality of the hashing a bit.
3309
b312a492
PE
3310 * emacs.c: Integer overflow minor fix.
3311 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3312 Define only if GNU_LINUX.
3313 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3314
dfd153ae
PE
3315 * dispnew.c: Integer signedness and overflow fixes.
3316 Remove unnecessary forward decls, that were a maintenance hassle.
3317 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3318 All uses changed.
3319 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3320 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3321 (prepare_desired_row, line_draw_cost):
3322 Use int, not unsigned, where either works.
3323 (save_current_matrix, restore_current_matrix):
3324 Use ptrdiff_t, not size_t, where either works.
3325 (init_display): Check for overflow more accurately, and without
3326 relying on undefined behavior.
3327
a81d11a3
PE
3328 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3329 Remove, replacing with the new symbols in lisp.h. All uses changed.
3330 * fileio.c (make_temp_name):
3331 * filelock.c (lock_file_1, lock_file):
3332 * xdisp.c (message_dolog):
3333 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3334 Use pMd etc. instead.
3335 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3336 replacing the pWIDE etc. symbols removed from editfns.c.
3337
3300e6fd
PE
3338 * keyboard.h (num_input_events): Now uintmax_t.
3339 This is (very slightly) less likely to mess up due to wraparound.
3340 All uses changed.
3341
fd05c7e9
PE
3342 * buffer.c: Integer signedness fixes.
3343 (alloc_buffer_text, enlarge_buffer_text):
3344 Use ptrdiff_t rather than size_t when either will do, as we prefer
3345 signed integers.
3346
903fe15d
PE
3347 * alloc.c: Integer signedness and overflow fixes.
3348 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3349 (__malloc_size_t): Default to size_t, not to int.
3350 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3351 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3352 Prefer ptrdiff_t to size_t when either would do, as we prefer
3353 signed integers.
3354 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3355 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3356 Now const. Initialize with values that are in range even if char
3357 is signed.
3358 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3359 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3360 These functions do the right thing with sizes > 2**32.
3361 (check_depth): Now ptrdiff_t, not int.
3362 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3363 Adjust to new way of storing sizes. Check for size overflow bugs
3364 in rest of code.
3365 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3366 slightly wrong anyway, as it missed one instance of
3367 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3368 (refill_memory_reserve): Omit needless cast to size_t.
3369 (mark_object_loop_halt): Mark as externally visible.
3370
ac82cc6a
PE
3371 * xselect.c: Integer signedness and overflow fixes.
3372 (Fx_register_dnd_atom, x_handle_dnd_message):
3373 Use ptrdiff_t, not size_t, since we prefer signed.
3374 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3375 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3376 x_dnd_atoms_size and x_dnd_atoms_length.
3377
c2d1e36d
PE
3378 * doprnt.c: Prefer signed to unsigned when either works.
3379 * eval.c (verror):
3380 * doprnt.c (doprnt):
3381 * lisp.h (doprnt):
3382 * xdisp.c (vmessage):
3383 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3384 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3385 prefer signed arithmetic to avoid comparison confusion.
3386 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3387 but is a bit tricky.
3388
0e926e56
PE
3389 Assume freestanding C89 headers, string.h, stdlib.h.
3390 * data.c, doprnt.c, floatfns.c, print.c:
3391 Include float.h unconditionally.
3392 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3393 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3394 * regex.c: Likewise for stddef.h, string.h.
3395 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3396 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3397 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3398 (STDC_HEADERS): Remove obsolete defines.
3399 * sysdep.c: Include limits.h unconditionally.
3400
9cfdb3ec
PE
3401 Assume support for memcmp, memcpy, memmove, memset.
3402 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3403 * regex.c (memcmp, memcpy):
3404 Remove; we assume C89 now.
3405
3406 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3407 (__malloc_safe_bcopy): Remove; no longer needed.
3408
cf950e6b 3409 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3410 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3411 well either way, and we prefer signed to unsigned.
3412
dbf38e02
LMI
34132011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3414
3415 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3416 closes the connection while we're reading (bug#9182).
3417
d6f0886c 34182011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3419
d6f0886c
JD
3420 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3421 are specified (Bug#9168).
24e0f6b1 3422
2eb1f9e6
PE
34232011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3424
3425 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3426 Found by GCC static checking and --with-wide-int on a 32-bit host.
3427
22381272 34282011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3429
3430 * xdisp.c (compute_display_string_pos): Fix logic of caching
3431 previous display string position. Initialize cached_prev_pos to
3432 -1. Fixes slow-down at the beginning of a buffer.
3433
f25e39b4
EZ
34342011-07-24 Eli Zaretskii <eliz@gnu.org>
3435
3436 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3437 for attrs[LFACE_FONTSET_INDEX].
3438
04c4b52e
PE
34392011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 * xml.c (parse_region): Remove unused local
3442 that was recently introduced.
3443
c1734fbd
EZ
34442011-07-23 Eli Zaretskii <eliz@gnu.org>
3445
be18c5a5
EZ
3446 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3447 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3448
c1734fbd
EZ
3449 * xdisp.c (move_it_in_display_line_to): Record the best matching
3450 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3451 exit if none of the characters scanned was an exact match.
3452 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3453 when exact match is impossible due to invisible text, and the
3454 lines are truncated.
3455
a258d627
JD
34562011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3457
3458 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3459 for OSX >= 10.7.
3460
b6d5a689
EZ
34612011-07-22 Eli Zaretskii <eliz@gnu.org>
3462
0f74f785
EZ
3463 Fix a significant slow-down of cursor motion with C-n, C-p,
3464 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3465 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3466 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3467 (next_element_from_buffer): Call compute_stop_pos_backwards to
3468 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3469 base_level_stop.
3470 (reseat): Don't look for prev_stop, as that could mean a very long
3471 run.
3472 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3473 <cached_disp_overlay_modiff>: Cache for last found display string
3474 position.
551918c1 3475 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3476 about the same buffer in the same area of character positions, and
3477 the buffer wasn't changed since the time the display string
3478 position was cached.
551918c1 3479
b2d0c91a
EZ
34802011-07-22 Eli Zaretskii <eliz@gnu.org>
3481
3482 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3483 is an integer, which is important for empty lines. (Bug#9149)
3484
043604ee
CY
34852011-07-22 Chong Yidong <cyd@stupidchicken.com>
3486
3487 * frame.c (Fmodify_frame_parameters): In tty case, update the
3488 default face if necessary (Bug#4238).
3489
da4adb04
CY
34902011-07-21 Chong Yidong <cyd@stupidchicken.com>
3491
3492 * editfns.c (Fstring_to_char): No need to explain what a character
3493 is in the docstring (Bug#6576).
3494
9abd0532
LMI
34952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3496
3497 * xml.c (parse_region): Make sure we always return a tree.
3498
36881d16
HK
34992011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3500
3501 * xml.c (parse_region): If a document contains only comments,
3502 return that, too.
3503
1e98674d
LMI
35042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3505
3506 * xml.c (make_dom): Return comments, too.
3507
590bd467
PE
35082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3509
3510 Port to OpenBSD.
3511 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3512 and the surrounding thread.
3513 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3514 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3515 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3516 timer goes off.
3517 * s/openbsd.h (BROKEN_SIGIO): Define.
3518 * unexelf.c (unexec) [__OpenBSD__]:
3519 Don't update the .mdebug section of the Alpha COFF symbol table.
3520
f41628b2
LMI
35212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3522
3523 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3524 (bug#8460).
3525
b59b67c5
PE
35262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3527
15e3a074
PE
3528 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3529 This fixes some race conditions on the permissions of any newly
3530 created file.
3531
41bed37d
PE
3532 * alloc.c (valid_pointer_p): Use pipe, not open.
3533 This fixes some permissions issues when debugging.
3534
b59b67c5
PE
3535 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3536 If fchown fails to set both uid and gid, try to set just gid,
3537 as that is sometimes allowed. Adjust the file's mode to eliminate
3538 setuid or setgid bits that are inappropriate if fchown fails.
3539
925a6be7
SM
35402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3541
3542 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3543 to compare Lisp_Objects.
3544 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3545 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3546 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3547
52968808
AS
35482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3549
0a6a104b
AS
3550 * lread.c (read_integer): Unread even EOF character.
3551 (read1): Likewise. Properly record start position of symbol.
3552
52968808
AS
3553 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3554 symbol character follows.
3555
9e381cdd
PE
35562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3559 This works around a problem with the previous change to Fcopy_file.
3560 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3561 and without this change, GCC might complain about discarding
3562 fchown's return value.
3563
b5641435
JB
35642011-07-16 Juanma Barranquero <lekktu@gmail.com>
3565
3566 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3567
a8031457
PE
35682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3571
dd889327
LMI
35722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3573
750c33f7
LMI
3574 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3575 it's used from the C level.
3576
dd889327
LMI
3577 * process.c: Use the same condition for POLL_FOR_INPUT in both
3578 keyboard.c and process.c (bug#1858).
3579
87e86684
LM
35802011-07-09 Lawrence Mitchell <wence@gmx.li>
3581
3582 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3583 (Fgnutls_boot): Use it.
3584
64348f40
AS
35852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3586
3587 * doc.c (Fsubstitute_command_keys): Revert last change.
3588
1d698799
LMI
35892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3590
f863868c
LMI
3591 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3592 quotes the next character, and doesn't affect other longer
3593 sequences (bug#8935).
3594
1d698799
LMI
3595 * lread.c (syms_of_lread): Clarify that is isn't only
3596 `eval-buffer' and `eval-defun' that's affected by
3597 `lexical-binding' (bug#8460).
3598
aa4b6df6
EZ
35992011-07-15 Eli Zaretskii <eliz@gnu.org>
3600
3601 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3602 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3603
5d856da6
PE
36042011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3605
ad6042bb
PE
3606 Fix minor problems found by static checking.
3607 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3608 (elsz): Now a signed constant, not a size_t var. We prefer signed
3609 types to unsigned, to avoid integer comparison confusion. Without
3610 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3611 "cannot optimize loop, the loop counter may overflow", a symptom
3612 of the confusion.
f00bbb22 3613 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3614 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3615
6468f31c
LMI
36162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3617
49080b10
LMI
3618 * search.c (Fre_search_backward): Mention `case-fold-search' in
3619 all the re_search_* functions (bug#8138).
3620
6468f31c
LMI
3621 * keyboard.c (Fopen_dribble_file): Document when the file is
3622 closed (bug#8056).
3623
c965adc5
EZ
36242011-07-14 Eli Zaretskii <eliz@gnu.org>
3625
df9733bf
EZ
3626 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3627 bidi_cache_idx.
3628
0bb23927
EZ
3629 Support bidi reordering of display and overlay strings.
3630 * xdisp.c (compute_display_string_pos)
3631 (compute_display_string_end): Accept additional argument STRING.
3632 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3633 (reseat_to_string): Initialize bidi_it->string.s and
3634 bidi_it->string.schars.
3635 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3636 NULL (avoids a crash in bidi_paragraph_init).
3637 Initialize itb.string.lstring.
0bb23927
EZ
3638 (init_iterator): Call bidi_init_it only of a valid
3639 buffer position was specified. Initialize paragraph_embedding to
3640 L2R.
3641 (reseat_to_string): Initialize the bidi iterator.
3642 (display_string): If we need to ignore text properties of
3643 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3644 original value of -1 will not work with bidi.)
3645 (compute_display_string_pos): First arg is now struct
3646 `text_pos *'; all callers changed. Support display properties on
3647 Lisp strings.
3648 (compute_display_string_end): Support display properties on Lisp
3649 strings.
3650 (init_iterator, reseat_1, reseat_to_string): Initialize the
3651 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3652 when iterating on a string not from display properties).
640c8776
SM
3653 (compute_display_string_pos, compute_display_string_end):
3654 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3655 arrow keys.
3656 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3657 base_level_stop; instead, set base_level_stop to BEGV.
3658 Fixes crashes in vertical-motion.
0bb23927
EZ
3659 (next_element_from_buffer): Improve commentary for when
3660 the iterator is before prev_stop.
3661 (init_iterator): Initialize bidi_p from the default value of
3662 bidi-display-reordering, not from buffer-local value. Use the
3663 buffer-local value only if initializing for buffer iteration.
3664 (handle_invisible_prop): Support invisible properties on strings
3665 that are being bidi-reordered.
3666 (set_iterator_to_next): Support bidi reordering of C strings and
3667 Lisp strings.
3668 (next_element_from_string): Support bidi reordering of Lisp
3669 strings.
3670 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3671 (display_string): Support display of R2L glyph rows.
3672 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3673 (init_iterator): Don't initialize it->bidi_p for strings
3674 here.
3675 (reseat_to_string): Initialize it->bidi_p for strings here.
3676 (next_element_from_string, next_element_from_c_string)
3677 (next_element_from_buffer): Add xassert's for correspondence
3678 between IT's object being iterated and it->bidi_it.string
3679 structure.
3680 (face_before_or_after_it_pos): Support bidi iteration.
3681 (next_element_from_c_string): Handle the case of the first string
3682 character that is not the first one in the visual order.
3683 (get_visually_first_element): New function, refactored from common
3684 parts of next_element_from_buffer, next_element_from_string, and
3685 next_element_from_c_string.
3686 (tool_bar_lines_needed, redisplay_tool_bar)
3687 (display_menu_bar): Force left-to-right direction. Add a FIXME
3688 comment for making that be controlled by a user option.
3689 (push_it, pop_it): Save and restore the state of the
3690 bidi iterator. Save and restore the bidi_p flag.
3691 (pop_it): Iterate out of display property for string iteration as
3692 well.
3693 (iterate_out_of_display_property): Support iteration over strings.
3694 (handle_single_display_spec): Set up it->bidi_it for iteration
3695 over a display string, and call bidi_init_it.
3696 (handle_single_display_spec, next_overlay_string)
3697 (get_overlay_strings_1, push_display_prop): Set up the bidi
3698 iterator for displaying display or overlay strings.
3699 (forward_to_next_line_start): Don't use the shortcut if
3700 bidi-iterating.
3701 (back_to_previous_visible_line_start): If handle_display_prop
3702 pushed the iterator stack, restore the internal state of the bidi
3703 iterator by calling bidi_pop_it same number of times.
3704 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3705 and we are bidi-iterating, don't decrement the iterator position;
3706 instead, set the first_elt flag in the bidi iterator, to produce
3707 the same effect.
3708 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3709 (push_display_prop): xassert that we are iterating a buffer.
3710 (push_it, pop_it): Save and restore paragraph_embedding member.
3711 (handle_single_display_spec, next_overlay_string)
3712 (get_overlay_strings_1, reseat_1, reseat_to_string)
3713 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3714 correctly. Don't assume unibyte strings are not bidi-reordered.
3715 (compute_display_string_pos)
3716 (compute_display_string_end): Fix handling the case of C string.
3717 (push_it, pop_it): Save and restore from_disp_prop_p.
3718 (handle_single_display_spec, push_display_prop): Set the
3719 from_disp_prop_p flag.
3720 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3721 (pop_it): Call iterate_out_of_display_property only if we are
3722 popping after iteration over a string that came from a display
3723 property. Fix a typo in popping stretch info. Add an assertion
3724 for verifying that the iterator position is in sync with the bidi
3725 iterator.
3726 (handle_single_display_spec, get_overlay_strings_1)
3727 (push_display_prop): Fix initialization of paragraph direction for
3728 string when that of the parent object is not yet determined.
3729 (reseat_1): Call bidi_init_it to resync the bidi
3730 iterator with IT's position. (Bug#7616)
3731 (find_row_edges): If ROW->start.pos gives position
3732 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3733 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3734 Reset the from_disp_prop_p flag.
3735 (SAVE_IT, RESTORE_IT): New macros.
3736 (pos_visible_p, face_before_or_after_it_pos)
3737 (back_to_previous_visible_line_start)
3738 (move_it_in_display_line_to, move_it_in_display_line)
3739 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3740 (try_scrolling, redisplay_window, display_line): Use them when
3741 saving a temporary copy of the iterator and restoring it back.
3742 (back_to_previous_visible_line_start, reseat_1)
3743 (init_iterator): Empty the bidi cache "stack".
3744 (move_it_in_display_line_to): If iterator ended up at
3745 EOL, but we never saw any buffer positions smaller than
3746 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3747 motion in bidi-reordered lines.
3748 (move_it_in_display_line_to): Record prev_method and prev_pos
3749 immediately before the call to set_iterator_to_next. Fixes cursor
3750 motion in bidi-reordered lines with stretch glyphs and strings
3751 displayed in margins. (Bug#8133) (Bug#8867)
3752 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3753 TO_CHARPOS.
640c8776
SM
3754 (pos_visible_p): Support positions in bidi-reordered lines.
3755 Save and restore bidi cache.
0bb23927
EZ
3756
3757 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3758 (bidi_paragraph_info): Delete unused struct.
3759 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3760 (bidi_cache_start): New variable.
3761 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3762 to zero.
3763 (bidi_cache_fetch_state, bidi_cache_search)
3764 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3765 (bidi_cache_find, bidi_peek_at_next_level)
3766 (bidi_level_of_next_char, bidi_find_other_level_edge)
3767 (bidi_move_to_visually_next): Compare cache index with
3768 bidi_cache_start rather than with zero.
3769 (bidi_fetch_char): Accept new argument STRING; all callers
3770 changed. Support iteration over a string. Support strings with
3771 display properties. Support unibyte strings. Fix the type of
3772 `len' according to what STRING_CHAR_AND_LENGTH expects.
3773 (bidi_paragraph_init, bidi_resolve_explicit_1)
3774 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3775 (bidi_level_of_next_char, bidi_move_to_visually_next):
3776 Support iteration over a string.
0bb23927
EZ
3777 (bidi_set_sor_type, bidi_resolve_explicit_1)
3778 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3779 can now be zero (for strings); special values 0 and -1 were
3780 changed to -1 and -2, respectively.
3781 (bidi_char_at_pos): New function.
3782 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3783 Call it instead of FETCH_MULTIBYTE_CHAR.
3784 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3785 initialized to valid values.
3786 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3787 values.
3788 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3789 the test for valid cached positions. Fix the logic for looking up
3790 the sentinel state in the cache. GCPRO the Lisp string we are
3791 iterating.
3792 (bidi_push_it, bidi_pop_it): New functions.
3793 (bidi_initialize): Initialize the bidi cache start stack pointer.
3794 (bidi_cache_ensure_space): New function, refactored from part of
3795 bidi_cache_iterator_state. Don't assume the required size is just
3796 one BIDI_CACHE_CHUNK away.
3797 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3798 (bidi_count_bytes, bidi_char_at_pos): New functions.
3799 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3800 always valid if bidi_cache_idx is valid.
3801 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3802 is valid if it's going to be used.
3803 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3804 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3805 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3806 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3807 (bidi_find_other_level_edge, bidi_cache_start_stack):
3808 All variables related to cache indices are now EMACS_INT.
c965adc5 3809
0bb23927
EZ
3810 * dispextern.h (struct bidi_string_data): New structure.
3811 (struct bidi_it): New member `string'. Make flag members be 1-bit
3812 fields, and put them last in the struct.
640c8776
SM
3813 (compute_display_string_pos, compute_display_string_end):
3814 Update prototypes.
0bb23927
EZ
3815 (bidi_push_it, bidi_pop_it): Add prototypes.
3816 (struct iterator_stack_entry): New members bidi_p,
3817 paragraph_embedding, and from_disp_prop_p.
3818 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3819 (bidi_shelve_cache, bidi_unshelve_cache):
3820 Declare prototypes.
0bb23927
EZ
3821
3822 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3823 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3824 and vector-like objects.
3825
3826 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3827 cache around display iteration.
3828
3829 * window.c (Fwindow_end, window_scroll_pixel_based)
3830 (displayed_window_lines, Frecenter): Save and restore the bidi
3831 cache around display iteration.
3832
3bbd2265
LMI
38332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3834
3835 * editfns.c (Fdelete_region): Clarify the use of the named
3836 parameters (bug#6788).
3837
adc47434
MR
38382011-07-14 Martin Rudalics <rudalics@gmx.at>
3839
3840 * indent.c (Fvertical_motion): Set and restore w->pointm when
3841 saving and restoring the window's buffer (Bug#9006).
3842
837c31f8
LMI
38432011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3844
3845 * editfns.c (Fstring_to_char): Clarify just what is returned
3846 (bug#6576). Text by Eli Zaretskii.
3847
ac389d0c
JB
38482011-07-13 Juanma Barranquero <lekktu@gmail.com>
3849
3850 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3851
0be0ce47
EZ
38522011-07-13 Eli Zaretskii <eliz@gnu.org>
3853
3854 * buffer.c (mmap_find): Fix a typo.
3855
cd18e7e3
JB
38562011-07-13 Johan Bockgård <bojohan@gnu.org>
3857
3858 Fix execution of x selection hooks.
3859 * xselect.c (Qx_lost_selection_functions)
3860 (Qx_sent_selection_functions): New vars.
3861 (syms_of_xselect): DEFSYM them.
3862 (x_handle_selection_request): Pass Qx_sent_selection_functions
3863 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3864 (x_handle_selection_clear,x_clear_frame_selections):
3865 Pass Qx_lost_selection_functions rather than
3866 Vx_lost_selection_functions to Frun_hook_with_args.
3867
47ea7f44
PE
38682011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3869
ac389d0c 3870 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3871 The old code sometimes used this field without initializing it.
3872
47ea7f44
PE
3873 * alloc.c (gc_sweep): Don't read past end of array.
3874 In theory, the old code could also have corrupted Emacs internals,
3875 though it'd be very unlikely.
3876
bc985c87
AS
38772011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3878
3879 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3880 argument. (Bug#4026)
bc985c87 3881
0cf34688
LMI
38822011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3883
b3dadd76
LMI
3884 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3885 key" (bug#4257).
3886
0cf34688
LMI
3887 * window.c (Fset_window_start): Doc fix (bug#4199).
3888 (Fset_window_hscroll): Ditto.
3889
270768cd
PE
38902011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3891
077e3dda 3892 Fix minor new problems caught by GCC 4.6.1.
270768cd 3893 * term.c (init_tty): Remove unused local.
490011a6 3894 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3895 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3896 not used otherwise.
270768cd 3897
b1f58454
CY
38982011-07-12 Chong Yidong <cyd@stupidchicken.com>
3899
3900 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3901
22b9578d
LMI
39022011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3903
6e70ab07
LMI
3904 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3905 are the mini-buffer and the echo area (bug#3320).
3906
22b9578d
LMI
3907 * term.c (init_tty): Remove support for supdup, c10 and perq
3908 terminals, which are no longer supported (bug#1482).
3909
8974cc9f
JB
39102011-07-10 Johan Bockgård <bojohan@gnu.org>
3911
3912 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3913
a560d974
JD
39142011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3915
3916 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3917 for non-popups (Bug#3642).
3918
1dae0f0a
AS
39192011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3920
268c2c36 3921 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3922 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3923 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3924 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3925 * data.c (fmod): Likewise.
3926 * dispnew.c (swap_glyphs_in_rows): Likewise.
3927 * emacs.c (memory_warning_signal): Likewise.
3928 * floatfns.c (float_error): Likewise.
3929 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3930 (otf_open, font_otf_capability, generate_otf_features)
3931 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3932 Likewise.
3933 * image.c (pbm_read_file): Likewise.
3934 * indent.c (string_display_width): Likewise.
3935 * intervals.c (check_for_interval, search_for_interval)
3936 (inc_interval_count, count_intervals, root_interval)
3937 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3938 * lread.c (defalias): Likewise.
268c2c36 3939 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3940 * regex.c (set_image_of_range_1, set_image_of_range)
3941 (regex_grow_registers): Likewise.
3942 * sysdep.c (strerror): Likewise.
3943 * termcap.c (valid_filename_p, tprint, main): Likewise.
3944 * tparam.c (main): Likewise.
3945 * unexhp9k800.c (run_time_remap, save_data_space)
3946 (update_file_ptrs, read_header, write_header, calculate_checksum)
3947 (copy_file, copy_rest, display_header): Likewise.
3948 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3949 Likewise.
3950 * xdisp.c (check_it): Likewise.
3951 * xfaces.c (register_color, unregister_color, unregister_colors):
3952 Likewise.
3953 * xfns.c (print_fontset_result): Likewise.
3954 * xrdb.c (member, fatal, main): Likewise.
3955
99033785
PE
39562011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Fix minor problems found by static checking (Bug#9031).
3959 * chartab.c (char_table_set_range, map_sub_char_table):
3960 Remove unused locals.
3961 (uniprop_table): Now static.
3962 * composite.c (_work_char): Remove unused static var.
3963
9cb2ac56
JB
39642011-07-09 Juanma Barranquero <lekktu@gmail.com>
3965
3966 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3967
f25661f0
JD
39682011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3969
3970 * gtkutil.c (qttip_cb): Remove code without function.
3971
8278c4fe
EZ
39722011-07-09 Eli Zaretskii <eliz@gnu.org>
3973
3974 * w32.c (pthread_sigmask): New stub.
3975
1692ae2d 39762011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3977
8a6ebd58 3978 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3979 sigprocmask is portable only for single-threaded applications, and
3980 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3981 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3982 (LIBES): Use it.
3983 * callproc.c (Fcall_process):
3984 * process.c (create_process):
3985 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3986 Use pthread_sigmask, not sigprocmask.
123403e4 3987
1b854618
JD
39882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3989
3990 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3991 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3992 wrong (Bug#8591).
3993
3fe4b549
JD
39942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3995
0ce7e563
JD
3996 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3997 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3998 (xg_hide_tooltip): Fix comment.
3999
3fe4b549
JD
4000 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4001 in registerServicesMenuSendTypes.
4002 (validRequestorForSendType): Don't check ns_return_types.
4003
4004 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4005 ns_return_type.
4006
5df75e47
JR
40072011-07-08 Jason Rumney <jasonr@gnu.org>
4008
22610910
JR
4009 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4010 SH_SHOW for hidden windows (Bug#5482).
4011
5df75e47
JR
4012 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4013 frame struct members of non-existent frames (Bug#6284).
4014
699c10bd
JD
40152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4016
4393663b
JD
4017 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4018 variable firstTime not needed on OSX >= 10.6.
4019 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4020 >= 10.5. Use setKnobProportion, setDoubleValue.
4021
4022 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4023 (MAC_OS_X_VERSION_10_5): Define if not defined.
4024 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4025 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4026 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4027
4028 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4029 cString and lossyCString on OSX >= 10.4
4030
58179cce 4031 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4032 sizeToFit on OSX >= 10.2.
4033
4034 * nsimage.m (allocInitFromFile): Don't use deprecated method
4035 bestRepresentationForDevice on OSX >= 10.6.
4036
4037 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4038 to avoid warning.
4039
4040 * emacs.c: Declare unexec_init_emacs_zone.
4041
a63e0781
JD
4042 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4043
699c10bd
JD
4044 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4045
4046 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4047 on svcsMenu (Bug#8842).
4048
4049 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4050 ns_return_types.
4051 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4052
4053 * nsterm.m (QUTF8_STRING): Declare.
4054 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4055 (validRequestorForSendType): Return type is (id).
4056 Change indexOfObjectIdenticalTo to indexOfObject.
4057 Check if we have local selection before returning self (Bug#8842).
4058 (writeSelectionToPasteboard): Put local selection into paste board
4059 if we have a local selection (Bug#8842).
4060 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4061
4062 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4063 (ns_get_local_selection): Declare.
4064
54e10184
LMI
40652011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4066
9888ff71
LMI
4067 * keymap.c (describe_map_tree): Don't insert a double newline at
4068 the end of the buffer (bug#1169) and return whether we inserted
4069 something.
4070
54e10184
LMI
4071 * callint.c (Fcall_interactively): Change "reading args" to
4072 "providing args" to try to clarify what it does (bug#1010).
4073
15fa4783
KH
40742011-07-07 Kenichi Handa <handa@m17n.org>
4075
4076 * composite.c (composition_compute_stop_pos): Ignore a static
4077 composition starting before CHARPOS (Bug#8915).
4078
4079 * xdisp.c (handle_composition_prop): Likewise.
4080
a8815b00
EZ
40812011-07-07 Eli Zaretskii <eliz@gnu.org>
4082
4083 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4084 (Bug#9015)
4085
ef7b981d 40862011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4087
4088 * character.h (unicode_category_t): New enum type.
4089
4090 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4091 (Qchar_code_property_table): New variable.
4092 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4093 (UNIPROP_COMPRESSED_FORM_P): New macros.
4094 (char_table_ascii): Uncompress the compressed values.
4095 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4096 Uncompress the compressed values.
ac389d0c 4097 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4098 (char_table_ref_and_range): Uncompress the compressed values.
4099 (sub_char_table_set): New arg is_uniprop. Callers changed.
4100 Uncompress the compressed values.
4101 (sub_char_table_set_range): Args changed. Callers changed.
4102 (char_table_set_range): Adjuted for the above change.
4103 (map_sub_char_table): Delete args default_val and parent. Add arg
4104 top. Give decoded values to a Lisp function.
640c8776 4105 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4106 values to a Lisp function. Gcpro more variables.
4107 (uniprop_table_uncompress)
4108 (uniprop_decode_value_run_length): New functions.
4109 (uniprop_decoder, uniprop_decoder_count): New variables.
4110 (uniprop_get_decoder, uniprop_encode_value_character)
4111 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4112 New functions.
4113 (uniprop_encoder, uniprop_encoder_count): New variables.
4114 (uniprop_get_encoder, uniprop_table)
4115 (Funicode_property_table_internal, Fget_unicode_property_internal)
4116 (Fput_unicode_property_internal): New functions.
4117 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4118 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4119 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4120 char-code-property-alist.
4121
640c8776 4122 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4123 Vunicode_category_table.
4124
640c8776 4125 * font.c (font_range): Adjust for the change of
c805dec0
KH
4126 Vunicode_category_table.
4127
76b397fb
DN
41282011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4129
4130 * m/iris4d.h: Remove file, move contents ...
4131 * s/irix6-5.h: ... here.
4132
22b4128e
PE
41332011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4136 * alloc.c (mark_buffer):
4137 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4138 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4139 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4140 This isn't true in general, and it's particularly not true
4141 if Emacs is configured with --with-wide-int.
4142 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4143 New macros, used in the buffer.c change.
4144
869795d6
JD
41452011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4146
4147 * xsettings.c: Use both GConf and GSettings if both are available.
4148 (store_config_changed_event): Add comment.
4149 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4150 (store_tool_bar_style_changed): New functions.
5e617bc2 4151 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4152 (struct xsettings): Move font inside HAVE_XFT.
4153 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4154 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4155 Move inside HAVE_XFT.
640c8776 4156 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4157 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4158 also.
4159 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4160 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4161 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4162 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4163 (parse_settings): Move check for font inside HAVE_XFT.
4164 (read_settings, apply_xft_settings): Add comment.
4165 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4166 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4167 call store_font_name_changed.
4168 (xft_settings_event): Add comment.
4169 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4170 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4171 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4172 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4173 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4174 (xsettings_get_system_font, xsettings_get_system_normal_font):
4175 Add comment.
869795d6 4176
d8ed26bd
PE
41772011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4178
4179 Random fixes. E.g., (random) never returned negative values.
4180 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4181 subseconds part to the entropy, as that's a bit more random.
4182 Prefer signed to unsigned, since the signedness doesn't matter and
4183 in general we prefer signed. When given a limit, use a
4184 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4185 latter isn't right if USE_2_TAGS_FOR_INTS.
4186 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4187 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4188
cabf1cac
SM
41892011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4190
4191 * textprop.c (text_property_stickiness):
4192 Obey Vtext_property_default_nonsticky.
4193 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4194 * w32fns.c (syms_of_w32fns):
4195 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4196
6e9b2be9
PE
41972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4200 This is more efficient than Ffile_directory_p and avoids a minor race.
4201
90186c68
LMI
42022011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4203
7c301272
LMI
4204 * buffer.c (Foverlay_put): Say what the return value is
4205 (bug#7835).
4206
c4f2d8d4
LMI
4207 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4208 is a directory before asking whether to use the file name
4209 (bug#7564).
ad637907
LMI
4210 (barf_or_query_if_file_exists): Make the "File is a directory"
4211 error be more correct.
c4f2d8d4 4212
90186c68
LMI
4213 * fns.c (Frequire): Remove the mention of the .gz files, since
4214 that's installation-specific, but keep the mention of
4215 `get-load-suffixes'.
4216
da64016e
PE
42172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4218
4219 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4220 Report string overflow if the output is too long.
4221
7d47b580
JB
42222011-07-04 Juanma Barranquero <lekktu@gmail.com>
4223
a555cb87
JB
4224 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4225 (syms_of_gnutls): Remove duplicate DEFSYM for
4226 Qgnutls_bootprop_verify_hostname_error, an error for
4227 Qgnutls_bootprop_verify_error (which is no longer used).
4228
7d47b580
JB
4229 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4230 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4231 Also (re)move comments that are misplaced or no longer relevant.
4232
1e49bfab
LMI
42332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4234
4235 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4236
1485f4c0
CY
42372011-07-03 Chong Yidong <cyd@stupidchicken.com>
4238
4239 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4240 and background color parameters if they have been changed.
4241
a9ab721e
LMI
42422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4243
4244 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4245
cf7cff57
PE
42462011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4247
2e13213d
PE
4248 * xsettings.c (SYSTEM_FONT): Define only when used.
4249 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4250
cf7cff57
PE
4251 * keymap.c (access_keymap_1): Now static.
4252
7a8e04f7
CY
42532011-07-02 Chong Yidong <cyd@stupidchicken.com>
4254
4255 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4256 leave any prefix arg for the up event (Bug#1586).
4257
61352f62
LMI
42582011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4259
69bb1ef7
LMI
4260 * lread.c (syms_of_lread): Mention single symbols defined by
4261 `defvar' or `defconst' (bug#7154).
4262
61352f62 4263 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4264 (Frequire): Mention get-load-suffixes.
61352f62 4265
28545e04
MR
42662011-07-02 Martin Rudalics <rudalics@gmx.at>
4267
4268 * window.h (window): Remove clone_number slot.
4269 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4270 Remove.
4271 (make_parent_window, make_window, saved_window)
4272 (Fset_window_configuration, save_window_save): Don't deal with
4273 clone numbers.
4274 * buffer.c (Qclone_number): Remove declaration.
4275 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4276
3349e122
SM
42772011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4278
4279 Add multiple inheritance to keymaps.
4280 * keymap.c (Fmake_composed_keymap): New function.
4281 (Fset_keymap_parent): Simplify.
4282 (fix_submap_inheritance): Remove.
4283 (access_keymap_1): New function extracted from access_keymap to handle
4284 embedded parents and handle lists of maps.
4285 (access_keymap): Use it.
4286 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4287 (Fcopy_keymap): Handle embedded parents.
4288 (Fcommand_remapping, define_as_prefix): Simplify.
4289 (Fkey_binding): Simplify.
4290 (syms_of_keymap): Move minibuffer-local-completion-map,
4291 minibuffer-local-filename-completion-map,
4292 minibuffer-local-must-match-map, and
4293 minibuffer-local-filename-must-match-map to Elisp.
4294 (syms_of_keymap): Defsubr make-composed-keymap.
4295 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4296 (parse_menu_item): Trivial simplification.
4297
3279eb87
GM
42982011-07-01 Glenn Morris <rgm@gnu.org>
4299
4300 * Makefile.in (SETTINGS_LIBS): Fix typo.
4301
4550efdf
KI
43022011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4303
4304 * coding.c (Fencode_coding_string): Record the last coding system
4305 used, as the function doc string says (bug#8738).
4306
0949d2b6
JD
43072011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4308
4309 * xsettings.c (store_monospaced_changed): Take new font as arg and
4310 check for change against current_mono_font.
4311 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4312 (emacs_settings_constructor, emacs_settings_get_property)
4313 (emacs_settings_set_property, emacs_settings_class_init)
4314 (emacs_settings_init, gsettings_obj): Remove.
4315 (something_changedCB): New function for HAVE_GSETTINGS.
4316 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4317 with value as argument.
4318 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4319 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4320 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4321 "changed".
4322
4323 * xgselect.c: Add defined (HAVE_GSETTINGS).
4324 (xgselect_initialize): Ditto.
4325
4326 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4327 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4328 xg_select.
4329
bbc6b304
PE
43302011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4331
4332 * eval.c (struct backtrace): Simplify and port the data structure.
4333 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4334 signed bit field, as this assumption is not portable and it makes
4335 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4336 "char debug_on_exit : 1" as this is not portable either; instead,
4337 use the portable "unsigned int debug_on_exit : 1". Remove unused
4338 member evalargs. Remove obsolete comments about cc bombing out.
4339
9851bfc5
JD
43402011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4341
51bb811f 4342 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4343 Let HAVE_GSETTINGS override HAVE_GCONF.
4344 (store_monospaced_changed): New function.
4345 (EMACS_SETTINGS): A new type derived from GObject to handle
4346 GSettings notifications.
4347 (emacs_settings_constructor, emacs_settings_get_property)
4348 (emacs_settings_set_property, emacs_settings_class_init):
4349 New functions.
4350 (gsettings_client, gsettings_obj): New variables.
4351 (GSETTINGS_SCHEMA): New define.
4352 (something_changedCB): Call store_monospaced_changed.
4353 (init_gsettings): New function.
4354 (xsettings_initialize): Call init_gsettings.
4355 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4356 to NULL.
4357
640c8776 4358 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4359 GCONF_CFLAGS/LIBS.
4360
5386012d
MR
43612011-06-29 Martin Rudalics <rudalics@gmx.at>
4362
4363 * window.c (resize_root_window, grow_mini_window)
4364 (shrink_mini_window): Rename Qresize_root_window to
4365 Qwindow_resize_root_window and Qresize_root_window_vertically to
4366 Qwindow_resize_root_window_vertically.
4367
f13e0b08
PE
43682011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4369
4370 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4371
94515237
JB
43722011-06-27 Juanma Barranquero <lekktu@gmail.com>
4373
4374 * makefile.w32-in: Redesign dependencies so they reflect more
4375 clearly which files are directly included by each source file,
4376 and not through other includes.
4377
e43b6e43
MR
43782011-06-27 Martin Rudalics <rudalics@gmx.at>
4379
4380 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4381 (sort_overlays, overlay_strings): When an overlay's clone number
4382 matches the window's clone number process the overlay even if
4383 the overlay's window property doesn't match the current window.
4384
d68443dc
MR
4385 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4386 (Fwindow_hchild): Rename to Fwindow_left_child.
4387 (Fwindow_next): Rename to Fwindow_next_sibling.
4388 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4389 (resize_window_check): Rename to window_resize_check.
4390 (resize_window_apply): Rename to window_resize_apply.
4391 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4392 (Fdelete_other_windows_internal, resize_frame_windows)
4393 (Fsplit_window_internal, Fdelete_window_internal)
4394 (grow_mini_window, shrink_mini_window)
4395 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4396
c7e73be5
JD
43972011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4398
4399 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4400 (emacs_fixed_set_min_size): Remove.
4401 (emacs_fixed_new): Take frame as argument.
4402
4403 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4404 (_EmacsFixedPrivate): Remove minwidth/height.
4405 Add struct frame *f.
4406 (emacs_fixed_init): Initialize priv->f.
4407 (get_parent_class, emacs_fixed_set_min_size): Remove.
4408 (emacs_fixed_new): Set priv->f to argument.
4409 (emacs_fixed_get_preferred_width)
4410 (emacs_fixed_get_preferred_height): Use min_width/height from
4411 frames size_hint to set minimum and natural (Bug#8919).
4412 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4413 and use min_width/height from frames size_hint to set
4414 min_width/height (Bug#8919).
4415
4416 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4417 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4418 Fix indentation.
c7e73be5 4419
cf99dcf8
EZ
44202011-06-26 Eli Zaretskii <eliz@gnu.org>
4421
4422 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4423 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4424 called at ZV.
4425
029529ac
CY
44262011-06-26 Chong Yidong <cyd@stupidchicken.com>
4427
4428 * process.c (wait_reading_process_output): Bypass select if
4429 waiting for a cell while ignoring keyboard input, and input is
4430 pending. Suggested by Jan Djärv (Bug#8869).
4431
7a7ef429
PE
44322011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4433
4434 Use gnulib's dup2 module instead of rolling our own.
4435 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4436
11fdef7d 44372011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4438
4439 * dispnew.c (scrolling_window): Before scrolling, turn off a
4440 mouse-highlight in the window being scrolled.
4441
cd3520a4
JB
44422011-06-24 Juanma Barranquero <lekktu@gmail.com>
4443
4444 Move DEFSYM to lisp.h and use everywhere.
4445
4446 * character.h (DEFSYM): Move declaration...
4447 * lisp.h (DEFSYM): ...here.
4448
4449 * gnutls.c:
4450 * minibuf.c:
4451 * w32menu.c:
4452 * w32proc.c:
4453 * w32select.c: Don't include character.h.
4454
4455 * alloc.c (syms_of_alloc):
4456 * buffer.c (syms_of_buffer):
4457 * bytecode.c (syms_of_bytecode):
4458 * callint.c (syms_of_callint):
4459 * casefiddle.c (syms_of_casefiddle):
4460 * casetab.c (init_casetab_once):
4461 * category.c (init_category_once, syms_of_category):
4462 * ccl.c (syms_of_ccl):
4463 * cmds.c (syms_of_cmds):
4464 * composite.c (syms_of_composite):
4465 * dbusbind.c (syms_of_dbusbind):
4466 * dired.c (syms_of_dired):
4467 * dispnew.c (syms_of_display):
4468 * doc.c (syms_of_doc):
4469 * editfns.c (syms_of_editfns):
4470 * emacs.c (syms_of_emacs):
4471 * eval.c (syms_of_eval):
4472 * fileio.c (syms_of_fileio):
4473 * fns.c (syms_of_fns):
4474 * frame.c (syms_of_frame):
4475 * fringe.c (syms_of_fringe):
4476 * insdel.c (syms_of_insdel):
4477 * keymap.c (syms_of_keymap):
4478 * lread.c (init_obarray, syms_of_lread):
4479 * macros.c (syms_of_macros):
4480 * msdos.c (syms_of_msdos):
4481 * print.c (syms_of_print):
4482 * process.c (syms_of_process):
4483 * search.c (syms_of_search):
4484 * sound.c (syms_of_sound):
4485 * syntax.c (init_syntax_once, syms_of_syntax):
4486 * terminal.c (syms_of_terminal):
4487 * textprop.c (syms_of_textprop):
4488 * undo.c (syms_of_undo):
4489 * w32.c (globals_of_w32):
4490 * window.c (syms_of_window):
4491 * xdisp.c (syms_of_xdisp):
4492 * xfaces.c (syms_of_xfaces):
4493 * xfns.c (syms_of_xfns):
4494 * xmenu.c (syms_of_xmenu):
4495 * xsettings.c (syms_of_xsettings):
4496 * xterm.c (syms_of_xterm): Use DEFSYM.
4497
4228cf16
TZ
44982011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4499
cd3520a4 4500 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4501
7fcccf1e
PE
45022011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4503
7efb4e0e
PE
4504 Integer and buffer overflow fixes (Bug#8873).
4505
ff5844ad
PE
4506 * print.c (printchar, strout): Check for string overflow.
4507 (PRINTPREPARE, printchar, strout):
4508 Don't set size unless allocation succeeds.
4509
90532f02
PE
4510 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4511 for sizes. Check for string overflow more accurately.
4512 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4513
6d84508d
PE
4514 * macros.c: Integer and buffer overflow fixes.
4515 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4516 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4517 Use ptrdiff_t, not int, for sizes.
4518 Don't increment bufsize until after realloc succeeds.
4519 Check for size-calculation overflow.
4520 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4521
437b2cb4
PE
4522 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4523
8b9ac8b4
PE
4524 * lread.c: Integer overflow fixes.
4525 (read_integer): Radix is now EMACS_INT, not int,
4526 to improve quality of diagnostics for out-of-range radices.
4527 Calculate buffer size correctly for out-of-range radices.
4528 (read1): Check for integer overflow in radices, and in
4529 read-circle numbers.
82cb60d3
PE
4530 (read_escape): Avoid int overflow.
4531 (Fload, openp, read_buffer_size, read1)
4532 (substitute_object_recurse, read_vector, read_list, map_obarray):
4533 Use ptrdiff_t, not int, for sizes.
4534 (read1): Use EMACS_INT, not int, for sizes.
20270765 4535 Check for size overflow.
8b9ac8b4 4536
7fcccf1e
PE
4537 * image.c (cache_image): Check for size arithmetic overflow.
4538
bfbbd7e7
PE
4539 * lread.c: Integer overflow issues.
4540 (saved_doc_string_size, saved_doc_string_length)
4541 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4542 Now ptrdiff_t, not int.
4543 (read1): Don't assume doc string length fits in int. Check for
4544 out-of-range doc string lengths.
4545 (read_list): Don't assume file position fits in int.
39019e54 4546 (read_escape): Check for hex character overflow.
bfbbd7e7 4547
4e323265
LL
45482011-06-22 Leo Liu <sdl.web@gmail.com>
4549
4550 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4551 Move to minibuffer.el.
4552
85fece3e
PE
45532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4554
20b84ce9 4555 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4556 The following patches are for when GLYPH_DEBUG && !XASSERT.
4557 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4558 * dispnew.c (flush_stdout):
4559 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4560 Mark as externally visible.
4561 * dispnew.c (check_window_matrix_pointers): Now static.
4562 * dispnew.c (window_to_frame_vpos):
4563 * xfns.c (unwind_create_frame):
4564 * xterm.c (x_check_font): Remove unused local.
4565 * scroll.c (CHECK_BOUNDS):
4566 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4567 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4568 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4569 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4570 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4571 Now static.
4572 (debug_method_add): Use va_list and vsprintf rather than relying
4573 on undefined behavior with wrong number of arguments.
4574 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4575 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4576 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4577 since we're not interested in debugging glyphs with old libraries.
4578 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4579 GCC 4.6.0's static checking.
4580
0766b489
PE
45812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4582
31fd4b32
PE
4583 Integer overflow and signedness fixes (Bug#8873).
4584 A few related buffer overrun fixes, too.
4585
b79e8648
PE
4586 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4587
0766b489
PE
4588 * dispextern.h (struct face.stipple):
4589 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4590 (x_bitmap_mask, x_allocate_bitmap_record)
4591 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4592 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4593 (x_create_bitmap_from_xpm_data):
4594 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4595 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4596 (.bitmaps_last):
4597 * xfaces.c (load_pixmap):
4598 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4599 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4600 (.bitmaps_last, struct x_output.icon_bitmap):
4601 Use ptrdiff_t, not int, for bitmap indexes.
4602 (x_allocate_bitmap_record): Check for size overflow.
4603 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4604
b081724f
PE
4605 Use ptrdiff_t, not int, for overlay counts.
4606 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4607 * editfns.c (overlays_around, get_pos_property):
4608 * textprop.c (get_char_property_and_overlay):
4609 * xdisp.c (next_overlay_change, note_mouse_highlight):
4610 * xfaces.c (face_at_buffer_position):
21514da7
PE
4611 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4612 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4613 (Fnext_overlay_change, Fprevious_overlay_change)
4614 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4615 Use ptrdiff_t, not int, for sizes.
21514da7 4616 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4617
3de73e5e
PE
4618 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4619
2606c57b
PE
4620 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4621 (x_session_initialize): Do not assume string length fits in int.
4622
aaafe47a
PE
4623 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4624 This is unlikely, but can occur if DPI is outlandish.
4625
2674ddc8 4626 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4627 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4628
28154962
PE
4629 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4630 * xrdb.c (magic_file_p, search_magic_path):
4631 Omit last arg SUFFIX; it was always 0. All callers changed.
4632 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4633
7de51af5
PE
4634 * xfont.c (xfont_match): Avoid need for strlen.
4635
25ed6cc3
PE
4636 * xfns.c: Don't assume strlen fits in int.
4637 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4638
4eab31dd
PE
4639 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4640 not unsigned long, as we prefer signed integers. All callers changed.
4641 Detect integer overflow in repeat count.
4642 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4643 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4644
171e2a58
PE
4645 * termcap.c: Don't assume sizes fit in int and never overflow.
4646 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4647 (gobble_line): Check for size-calculation overflow.
4648
ad39faca 4649 * minibuf.c (Fread_buffer):
6e5bb2dc 4650 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4651 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4652 Don't assume string length fits in int.
4653
52c61c22 4654 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4655 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4656
b5b8c9e5
PE
4657 * font.c: Don't assume string length fits in int.
4658 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4659 Use ptrdiff_t, not int.
ccd6111c
PE
4660 (font_intern_prop): Don't assume string length fits in int.
4661 Don't assume integer property fits in fixnum.
4662 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4663
882f0d81 4664 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4665 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4666 Reformulate so as not to need the command string.
4667 Invoke gzip -cd rather than gunzip, as it's more portable.
4668 (lock_info_type, lock_file_1, lock_file):
4669 Don't assume pid_t and time_t fit in unsigned long.
4670 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4671 (current_lock_owner): Prefer signed type for sizes.
4672 Use memcpy, not strncpy, where memcpy is what is really wanted.
4673 Don't assume (via atoi) that time_t and pid_t fit in int.
4674 Check for time_t and/or pid_t out of range, e.g., via a network share.
4675 Don't alloca where an auto var works fine.
4676
93f4cf88
PE
4677 * fileio.c: Fix some integer overflow issues.
4678 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4679 Don't assume string length fits in int.
4680 (directory_file_name): Don't assume string length fits in long.
4681 (make_temp_name): Don't assume pid fits in int, or that its print
4682 length is less than 20.
4683
f3e92b69
PE
4684 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4685
1bfdaf10
PE
4686 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4687
35016e9a
PE
4688 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4689
3d1e65a1
PE
4690 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4691 We prefer signed integers, even for size calculations.
4692
0b963a93
PE
4693 * emacs.c: Don't assume string length fits in 'int'.
4694 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4695 (main): Don't invoke strlen when not needed.
4696
573f4b54
PE
4697 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4698 (XD_DEBUG_MESSAGE): Don't waste a byte.
4699
989f33ba
PE
4700 * callproc.c (getenv_internal_1, getenv_internal)
4701 (Fgetenv_internal):
965d34eb
PE
4702 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4703
e4d29b33
PE
4704 * lread.c (invalid_syntax): Omit length argument.
4705 All uses changed. This doesn't fix a bug, but it simplifies the
4706 code away from its former Hollerith-constant appearance, and it's
4707 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4708 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4709
eb49b136
PE
4710 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4711 This didn't break anything, but it didn't help either.
4712 It's confusing to put a bogus integer in a place where the actual
4713 value does not matter.
9f62aeb1 4714 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4715 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4716
15375a22
PE
4717 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4718 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4719 implementation.
b61cc01c
PE
4720 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4721 We prefer signed types, and the value cannot exceed the EMACS_INT
4722 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4723 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4724 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4725 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4726
53b2623d
PE
4727 * indent.c (sane_tab_width): New function.
4728 (current_column, scan_for_column, Findent_to, position_indentation)
4729 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4730 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4731
51cab52b 4732 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4733
f2ed8a70
PE
4734 * lisp.h (lint_assume): New macro.
4735 * composite.c (composition_gstring_put_cache):
4736 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4737
abe80cc6
PE
4738 * editfns.c, insdel.c:
4739 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4740
b02c740e
PE
4741 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4742
ebc96716
PE
4743 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4744
b4e50fa0 4745 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4746 Use much-faster test for byte-length change.
311d5d7c 4747 Don't assume string byte-length fits in 'int'.
a4cf38e4 4748 Check that character arg fits in 'int'.
85461888 4749 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4750
c0c1ee9f
PE
4751 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4752
a498d7f4
PE
4753 * fns.c (concat): Catch string overflow earlier.
4754 Do not rely on integer wraparound.
4755
51cab52b
PE
4756 * dispextern.h (struct it.overlay_strings_charpos)
4757 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4758 * xdisp.c (forward_to_next_line_start)
4759 (back_to_previous_visible_line_start)
4760 (reseat_at_next_visible_line_start, next_element_from_buffer):
4761 Don't arbitrarily truncate the value of 'selective' to int.
4762
76031fad
PE
4763 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4764
5eb55db9
PE
4765 * composite.c: Don't truncate sizes to 'int'.
4766 (composition_gstring_p, composition_reseat_it)
4767 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4768 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4769 not EMACS_UINT, for indexes.
5eb55db9 4770
0703a717
PE
4771 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4772
d6202519
PE
4773 * buffer.c: Include <verify.h>.
4774 (struct sortvec.priority, struct sortstr.priority):
8961a454 4775 Now EMACS_INT, not int.
c20998a7 4776 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4777 (struct sortstr.size, record_overlay_string)
4778 (struct sortstrlist.size, struct sortlist.used):
4779 Don't truncate size to int.
4780 (record_overlay_string): Check for size-calculation overflow.
d6202519 4781 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4782
d5a19415
JM
47832011-06-22 Jim Meyering <meyering@redhat.com>
4784
029529ac 4785 Don't leak an XBM-image-sized buffer
d5a19415
JM
4786 * image.c (xbm_load): Free the image buffer after using it.
4787
a9041e6c
PE
47882011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 Port to Sun C.
4791 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4792 that Sun C diagnosed.
4793 * fns.c (secure_hash): Fix pointer signedness issue.
4794 * intervals.c (static_offset_intervals): New function.
4795 (offset_intervals): Use it.
4796
7f3f739f
LL
47972011-06-21 Leo Liu <sdl.web@gmail.com>
4798
4799 * deps.mk (fns.o):
4800 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4801 sha512.h.
4802
4803 * fns.c (secure_hash): Rename from crypto_hash_function and change
4804 the first arg to accept symbols.
5b66d427 4805 (Fsecure_hash): New primitive.
7f3f739f
LL
4806 (syms_of_fns): New symbols.
4807
76147d94
DD
48082011-06-20 Deniz Dogan <deniz@dogan.se>
4809
4810 * process.c (Fset_process_buffer): Clarify return value in
4811 docstring.
4812
7d7d0045
CY
48132011-06-18 Chong Yidong <cyd@stupidchicken.com>
4814
4815 * dispnew.c (add_window_display_history): Use BVAR.
4816
4817 * xdisp.c (debug_method_add): Use BVAR.
4818 (check_window_end, dump_glyph_matrix, dump_glyph)
4819 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4820
4821 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4822 Likewise.
4823
4824 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4825 check till after the cache is created in init_frame_faces.
4826
ff2bc410
SM
48272011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4828
4829 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4830
28177add
PE
48312011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4832
dd3482fe
PE
4833 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4834 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4835 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4836
393d71f3 4837 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4838 * fileio.c (Finsert_file_contents):
4839 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4840 Remove the old (too-loose) buffer overflow checks.
4841 They weren't needed, since make_gap checks for buffer overflow.
4842 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4843 The old code merely checked for Emacs fixnum overflow, and relied
4844 on undefined (wraparound) behavior. The new code avoids undefined
4845 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4846
2e6813b0 4847 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4848 Tune. Don't use wider integers than needed. Don't use alloca.
4849 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4850
599a9e4f
PE
4851 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4852
99561444
PE
4853 * insdel.c, lisp.h (buffer_overflow): New function.
4854 (insert_from_buffer_1, replace_range, replace_range_2):
4855 * insdel.c (make_gap_larger):
4856 * editfns.c (Finsert_char):
4857 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4858
28177add
PE
4859 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4860
e69dafad
PE
48612011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4862
4baa020d 4863 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4864
b1c46f02
PE
4865 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4866 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4867
e69dafad
PE
4868 * fileio.c: Don't assume EMACS_INT fits in off_t.
4869 (emacs_lseek): New static function.
4870 (Finsert_file_contents, Fwrite_region): Use it.
4871 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4872
566684ea
PE
4873 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4874
e6966cd6
PE
4875 * fns.c: Don't overflow int when computing a list length.
4876 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4877 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4878 truncation on 64-bit hosts. Check for QUIT every
4879 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4880 faster and is responsive enough.
4881 (Flength): Report an error instead of overflowing an integer.
4882 (Fsafe_length): Return a float if the value is not representable
4883 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4884 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4885 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4886
dd0b0efb
PE
4887 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4888 (header_size, word_size): New constants.
4889 (allocate_vectorlike): Don't check size overflow here.
4890 (allocate_vector): Check it here instead, since this is the only
4891 caller of allocate_vectorlike that could cause overflow.
4892 Check that the new vector's length is representable as a fixnum.
4893
86fe5cfe
PE
4894 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4895 The previous code was bogus. For example, next_almost_prime (32)
4896 returned 39, which is undesirable as it is a multiple of 3; and
4897 next_almost_prime (24) returned 25, which is a multiple of 5 so
4898 why was the code bothering to check for multiples of 7?
4899
80e88859
PE
4900 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4901
4a2f0ad6
PE
4902 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4903
f66c7cf8
PE
4904 Variadic C functions now count arguments with ptrdiff_t.
4905 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4906 Back then I didn't know that the Emacs coding style prefers signed int.
4907 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4908 were being counted with int, which may truncate counts on 64-bit
4909 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4910 * lisp.h (struct Lisp_Subr.function.aMANY)
4911 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4912 Arg counts are now ptrdiff_t, not size_t.
4913 All variadic functions and their callers changed accordingly.
4914 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4915 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4916 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4917 * callint.c (Fcall_interactively): Check arg count for overflow,
4918 to avoid potential buffer overrun. Use signed char, not 'int',
4919 for 'varies' array, so that we needn't bother to check its size
4920 calculation for overflow.
4921 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4922 * eval.c (apply_lambda):
4923 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4924 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4925 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4926
a1759b76
PE
4927 * callint.c (Fcall_interactively): Don't use index var as event count.
4928
d96be9fc
PE
4929 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4930 * mem-limits.h (SIZE): Remove; no longer used.
4931
a690a978 4932 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4933
578c21e6
PE
4934 Remove unnecessary casts.
4935 * xterm.c (x_term_init):
4936 * xfns.c (x_set_border_pixel):
4937 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4938 These aren't needed now that we assume ANSI C.
4939
96f53c6c
PE
4940 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4941 It's more likely to cause problems (due to unsigned overflow)
4942 than to cure them.
4943
83c77d31
PE
4944 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4945
ee2079f1
PE
4946 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4947
6da65536
PE
4948 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4949
7147c4a4
PE
4950 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4951
193e32d9
PE
4952 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4953
e5533da6
PE
4954 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4955
9910e595
PE
4956 GLYPH_CODE_FACE returns EMACS_INT, not int.
4957 * dispextern.h (merge_faces):
4958 * xfaces.c (merge_faces):
01103c44
PE
4959 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4960 Don't assume EMACS_INT fits in int.
9910e595 4961
2638320e
PE
4962 * character.h (CHAR_VALID_P): Remove unused parameter.
4963 * fontset.c, lisp.h, xdisp.c: All uses changed.
4964
045eb8d9
PE
4965 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4966
c1f134b5
PE
4967 * fns.c (concat): Minor tuning based on overflow analysis.
4968 This doesn't fix any bugs. Use int to hold character, instead
4969 of constantly refetching from Emacs object. Use XFASTINT, not
4970 XINT, for value known to be a character. Don't bother comparing
4971 a single byte to 0400, as it's always less.
4972
395fcb93 4973 * floatfns.c (Fexpt):
327eeec8
PE
4974 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4975
abbd3d23
PE
4976 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4977 for characters.
4978
684a03ef
PE
4979 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4980
0fed43f3
PE
4981 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4982 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4983 incorrectly succeed when S was a string, because 4294967386 was
4984 truncated before it was used.
4985
8fd02eb7
PE
4986 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4987 Otherwise, an out-of-range integer could cause undefined behavior
4988 on a 64-bit host.
4989
f8c86b69
PE
4990 * composite.c: Use int, not EMACS_INT, for characters.
4991 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4992 EMACS_INT, for values that are known to be in character range.
4993 This doesn't fix any bugs but is the usual style inside Emacs and
4994 may generate better code on 32-bit machines.
4995
34206dd2
PE
4996 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4997 This is for reasons similar to the recent CHAR_STRING fix.
4998 * charset.c (Fencode_char): Check that character arg is actually
4999 a character. Pass an int to ENCODE_CHAR.
5000 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5001 wider than 'int', as a compile-time check to prevent future regressions
5002 in this area.
5003
c5958d4c 5004 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5005
5006 Make sure a 64-bit char is never passed to CHAR_STRING.
5007 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5008 by silently ignoring the top 32 bits, allowing some values
5009 that were far too large to be valid characters.
5010 * character.h: Include <verify.h>.
5011 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5012 arguments are no wider than unsigned, as a compile-time check
5013 to prevent future regressions in this area.
5014 * data.c (Faset):
01103c44 5015 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5016 (Fsubst_char_in_region):
5017 * fns.c (concat):
5018 * xdisp.c (decode_mode_spec_coding):
5019 Adjust to CHAR_STRING's new requirement.
5020 * editfns.c (Finsert_char, Fsubst_char_in_region):
5021 * fns.c (concat): Check that character args are actually
5022 characters. Without this test, these functions did the wrong
5023 thing with wildly out-of-range values on 64-bit hosts.
5024
d37ca623
PE
5025 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5026 These casts should not be needed on 32-bit hosts, either.
5027 * keyboard.c (read_char):
5028 * lread.c (Fload): Remove casts to unsigned.
5029
ea204efb
PE
5030 * lisp.h (UNSIGNED_CMP): New macro.
5031 This fixes comparison bugs on 64-bit hosts.
5032 (ASCII_CHAR_P): Use it.
5033 * casefiddle.c (casify_object):
01103c44 5034 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5035 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5036 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5037 * dispextern.h (FACE_FROM_ID):
5038 * keyboard.c (read_char): Use UNSIGNED_CMP.
5039
41cb286c
PE
5040 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5041 not to EMACS_INT, to avoid GCC warning.
5042
4a1b9832
PE
5043 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5044
55daad71
PE
5045 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5046 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5047 isn't needed on 32-bit machines.
8f95c75c 5048
01103c44
PE
5049 * buffer.c (Fgenerate_new_buffer_name):
5050 Use EMACS_INT for count, not int.
0ceccced 5051 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5052
5053 * data.c (Qcompiled_function): Now static.
5054
c6f072e7
PE
5055 * window.c (window_body_lines): Now static.
5056
20ce5912
PE
5057 * image.c (gif_load): Rename local to avoid shadowing.
5058
9c4c5f81
PE
5059 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5060 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5061 * alloc.c (make_save_value): Integer argument is now of type
5062 ptrdiff_t, not int.
5063 (mark_object): Use ptrdiff_t, not int.
5064 * lisp.h (pD): New macro.
5065 * print.c (print_object): Use it.
5066
c0c5c8ae
PE
5067 * alloc.c: Use EMACS_INT, not int, to count objects.
5068 (total_conses, total_markers, total_symbols, total_vector_size)
5069 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5070 (total_free_floats, total_floats, total_free_intervals)
5071 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5072 Now EMACS_INT, not int. All uses changed.
5073 (Fgarbage_collect): Compute overall total using a double, so that
5074 integer overflow is less likely to be a problem. Check for overflow
5075 when converting back to an integer.
5a25e253
PE
5076 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5077 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5078 These were 'int' variables that could overflow on 64-bit hosts;
5079 they were never used, so remove them instead of repairing them.
211a0b2a 5080 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5081 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5082 Previously, this ceilinged at INT_MAX, but that doesn't work on
5083 64-bit machines.
e46bb31a 5084 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5085
c78baabf 5086 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5087 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5088 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5089 when a (possibly-narrower) signed value would do just as well.
5090 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5091
c9d624c6
PE
5092 * alloc.c: Catch some string size overflows that we were missing.
5093 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5094 for convenience in STRING_BYTES_MAX.
5095 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5096 The definition here is exact; the one in lisp.h was approximate.
5097 (allocate_string_data): Check for string overflow. This catches
5098 some instances we weren't catching before. Also, it catches
5099 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5100 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5101 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5102
c9d624c6
PE
5103 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5104 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5105 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5106
353032ce
PE
5107 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5108
2bccce07
PE
5109 * alloc.c (Fmake_string): Check for out-of-range init.
5110
0ac30604
SM
51112011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5112
5113 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5114
c195f2de
JD
51152011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5116
5117 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5118 xg_get_default_scrollbar_width.
5119
5120 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5121 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5122 (style_changed_cb): Call update_theme_scrollbar_width and call
5123 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5124 all frames (Bug#8505).
5125 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5126 Call gtk_window_set_resizable if HAVE_GTK3.
5127 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5128 and height if HAVE_GTK3 (Bug#8505).
5129 (scroll_bar_width_for_theme): New variable.
5130 (update_theme_scrollbar_width): New function.
5131 (xg_get_default_scrollbar_width): Move code to
5132 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5133 (xg_initialize): Call update_theme_scrollbar_width.
5134
5135 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5136
5137 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5138
e10ac9f1
MR
51392011-06-12 Martin Rudalics <rudalics@gmx.at>
5140
5141 * frame.c (make_frame): Call other_buffer_safely instead of
5142 other_buffer.
5143
5144 * window.c (temp_output_buffer_show): Call display_buffer with
5145 second argument Vtemp_buffer_show_specifiers and reset latter
5146 immediately after the call.
5147 (Vtemp_buffer_show_specifiers): New variable.
5148 (auto_window_vscroll_p, next_screen_context_lines)
5149 (Vscroll_preserve_screen_position): Remove leading asterisks from
5150 doc-strings.
5151
2d3c217e 51522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5153
7b7f97e8 5154 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5155 * buffer.c (Qclone_number): Remove for now, as it's unused.
5156 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5157 (record_buffer): Remove unused local.
5158 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5159 (set_frame_buffer_list): Remove; unused.
5160 * frame.h (other_visible_frames): Remove decl.
5161 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5162 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5163 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5164 if HAVE_GPM.
5165 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5166 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5167 Define only if HAVE_GPM.
5168 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5169 (update_hints_inhibit): Remove; never set. All uses removed.
5170 * widgetprv.h (emacsFrameClassRec): Remove decl.
5171 * window.c (delete_deletable_window): Now returns void, since it
5172 wasn't returning anything.
5173 (compare_window_configurations): Remove unused locals.
5174 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5175 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5176 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5177 the same widths as pointers. This follows up on the 2011-05-06 patch.
5178 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5179 * xterm.h: Likewise.
5180 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5181
1384b89e
JB
51822011-06-12 Juanma Barranquero <lekktu@gmail.com>
5183
5184 * makefile.w32-in: Update dependencies.
5185 (LISP_H): Add lib/intprops.h.
5186
1100a63c
CY
51872011-06-11 Chong Yidong <cyd@stupidchicken.com>
5188
5189 * image.c (gif_load): Add animation frame delay to the metadata.
5190 (syms_of_image): Use DEFSYM. New symbol `delay'.
5191
6198ccd0
MR
51922011-06-11 Martin Rudalics <rudalics@gmx.at>
5193
5194 * window.c (delete_deletable_window): Re-add.
5195 (Fset_window_configuration): Rewrite to handle dead buffers and
5196 consequently deletable windows.
5197 (window_tree, Fwindow_tree): Remove. Supply functionality in
5198 window.el.
5199 (compare_window_configurations): Simplify code.
5200
b6e3633c
AS
52012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5202
1ab0dee5
AS
5203 * image.c (imagemagick_load_image): Fix type mismatch.
5204 (Fimagemagick_types): Likewise.
5205
b6e3633c
AS
5206 * window.h (replace_buffer_in_windows): Declare.
5207
9397e56f
MR
52082011-06-11 Martin Rudalics <rudalics@gmx.at>
5209
5210 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5211 Qclone_number. Remove external declaration of Qdelete_window.
5212 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5213 code.
640c8776
SM
5214 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5215 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5216 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5217 buffer list implementation.
5218 (other_buffer_safely): New function.
5219 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5220 calls to replace_buffer_in_windows and
5221 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5222 if allowed.
5223 (record_buffer): Inhibit quitting and rewrite using quittable
5224 functions. Run Qbuffer_list_update_hook if allowed.
5225 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5226 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5227 Move switch-to-buffer to window.el.
9397e56f
MR
5228 (bury-buffer): Move to window.el.
5229 (Vbuffer_list_update_hook): New variable.
5230
5231 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5232 section.
5233
5234 * window.h (resize_frame_windows): Move up in code.
5235 (Fwindow_frame): Remove EXFUN.
5236 (replace_buffer_in_all_windows): Remove prototype.
5237 (replace_buffer_in_windows_safely): Add prototype.
5238
5239 * window.c: Declare Qdelete_window static again. Move down
5240 declaration of select_count.
5241 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5242 (Fother_window): Move to window.el.
5243 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5244 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5245 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5246 window.el.
5247 (replace_buffer_in_windows): Implement by calling
5248 Qreplace_buffer_in_windows.
5249 (replace_buffer_in_all_windows): Remove with some functionality
5250 moved into replace_buffer_in_windows_safely.
5251 (replace_buffer_in_windows_safely): New function.
5252 (select_window_norecord, select_frame_norecord): Move in front
5253 of run_window_configuration_change_hook. Remove now obsolete
5254 declarations.
640c8776
SM
5255 (Fset_window_buffer): Rewrite doc-string.
5256 Call Qrecord_window_buffer.
9397e56f
MR
5257 (keys_of_window): Move binding for other-window to window.el.
5258
b50691aa
CY
52592011-06-11 Chong Yidong <cyd@stupidchicken.com>
5260
5261 * dispextern.h (struct image): Replace data member, whose int_val
5262 and ptr_val fields were not used by anything, with a single
5263 lisp_val object.
5264
5265 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5266 (gif_clear_image, gif_load, imagemagick_load_image)
5267 (gs_clear_image, gs_load): Callers changed.
5268
3f754b86
PE
52692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5270
cca69397
PE
5271 * buffer.h: Include <time.h>, for time_t.
5272 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5273
109e28d0
PE
5274 Fix minor problems found by static checking.
5275
60737f02
PE
5276 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5277
4b66faf3
PE
5278 Make identifiers static if they are not used in other modules.
5279 * data.c (Qcompiled_function, Qframe, Qvector):
5280 * image.c (QimageMagick, Qsvg):
5281 * minibuf.c (Qmetadata):
5282 * window.c (resize_window_check, resize_root_window): Now static.
5283 * window.h (resize_window_check, resize_root_window): Remove decls.
5284
109e28d0
PE
5285 * window.c (window_deletion_count, delete_deletable_window):
5286 Remove; unused.
46a4ce9e
PE
5287 (window_body_lines): Now static.
5288 (Fdelete_other_windows_internal): Mark vars as initialized.
5289 Make sure 'resize_failed' is initialized.
5290 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5291 (resize_window_apply): Remove unused local.
5292 * window.h (delete_deletable_window): Remove decl.
5293
109e28d0 5294 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5295 (imagemagick_load_image): Fix pointer signedness problem by changing
5296 last arg from unsigned char * to char *. All uses changed.
5297 Also, fix a local for similar reasons.
5298 Remove unused locals. Remove locals to avoid shadowing.
5299 (fn_rsvg_handle_free): Remove; unused.
5300 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5301 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5302
3f754b86
PE
5303 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5304
2547adb1
CY
53052011-06-10 Chong Yidong <cyd@stupidchicken.com>
5306
5307 * image.c (gif_load): Fix omitted cast error introduced by
5308 2011-06-06 change.
5309
2c8e37d4
MR
53102011-06-10 Martin Rudalics <rudalics@gmx.at>
5311
5312 * window.h (resize_proportionally, orig_total_lines)
5313 (orig_top_line): Remove from window structure.
5314 (set_window_height, set_window_width, change_window_heights)
5315 (Fdelete_window): Remove prototypes.
5316 (resize_frame_windows): Remove duplicate declaration.
5317
440a42e3
EZ
53182011-06-10 Eli Zaretskii <eliz@gnu.org>
5319
5320 * window.h (resize_frame_windows, resize_window_check)
5321 (delete_deletable_window, resize_root_window)
5322 (resize_frame_windows): Declare prototypes.
5323
5324 * window.c (resize_window_apply): Make definition be "static" to
5325 match the prototype.
5326
562dd5e9
MR
53272011-06-10 Martin Rudalics <rudalics@gmx.at>
5328
5329 * window.c: Remove declarations of Qwindow_size_fixed,
5330 window_min_size_1, window_min_size_2, window_min_size,
5331 size_window, window_fixed_size_p, enlarge_window, delete_window.
5332 Remove static from declaration of Qdelete_window, it's
5333 temporarily needed by Fbury_buffer.
5334 (replace_window): Don't assign orig_top_line and
5335 orig_total_lines.
5336 (Fdelete_window, delete_window): Remove. Window deletion is
5337 handled by window.el.
640c8776
SM
5338 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5339 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5340 (Fdelete_other_windows): Remove. Deleting other windows is
5341 handled by window.el.
5342 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5343 handled in window.el.
5344 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5345 Window minimum sizes are handled in window.el.
5346 (shrink_windows, size_window, set_window_height)
5347 (set_window_width, change_window_heights, window_height)
5348 (window_width, CURBEG, CURSIZE, enlarge_window)
5349 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5350 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5351 handled in window.el.
5352 (make_dummy_parent): Rename to make_parent_window and give it a
5353 second argument horflag.
5354 (make_window): Don't set resize_proportionally any more.
5355 (Fsplit_window): Remove. Windows are split in window.el.
5356 (save_restore_action, save_restore_orig_size)
5357 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5358 Resize mini windows in window.el.
5359 (grow_mini_window, shrink_mini_window): Implement by calling
5360 Qresize_root_window_vertically, resize_window_check and
5361 resize_window_apply.
640c8776
SM
5362 (saved_window, Fset_window_configuration, save_window_save):
5363 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5364 resize_proportionally.
5365 (window_min_height, window_min_width): Move to window.el.
5366 (keys_of_window): Move bindings for delete-other-windows,
5367 split-window, delete-window and enlarge-window to window.el.
5368
5369 * buffer.c: Temporarily extern Qdelete_window.
5370 (Fbury_buffer): Temporarily call Qdelete_window instead of
5371 Fdelete_window (Fbury_buffer will move to window.el soon).
5372
5373 * frame.c (set_menu_bar_lines_1): Remove code handling
5374 orig_top_line and orig_total_lines.
5375
5376 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5377 set_window_height but set heights directly.
5378 (change_frame_size_1): Use resize_frame_windows.
5379
5380 * xdisp.c (init_xdisp): Don't use set_window_height but set
5381 heights directly.
5382
640c8776
SM
5383 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5384 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5385 run_window_configuration_change_hook.
5386
5387 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5388 instead of change_window_heights and run
5389 run_window_configuration_change_hook.
5390
1a13852e
MR
53912011-06-09 Martin Rudalics <rudalics@gmx.at>
5392
5393 * window.c (replace_window): Rename second argument REPLACEMENT to
5394 NEW. New third argument SETFLAG. Rewrite.
5395 (delete_window, make_dummy_parent): Call replace_window with
5396 third argument 1.
5397 (window_list_1): Move down in code.
5398 (run_window_configuration_change_hook): Move set_buffer part
5399 before select_frame_norecord part in order to unwind correctly.
5400 Rename count1 to count.
5401 (recombine_windows, delete_deletable_window, resize_root_window)
5402 (Fdelete_other_windows_internal)
5403 (Frun_window_configuration_change_hook, make_parent_window)
5404 (resize_window_check, resize_window_apply, Fresize_window_apply)
5405 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5406 (Fdelete_window_internal, Fresize_mini_window_internal):
5407 New functions.
1a13852e
MR
5408 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5409
f3d1777e
MR
54102011-06-08 Martin Rudalics <rudalics@gmx.at>
5411
496e208e
MR
5412 * window.h (window): Add some new members to window structure -
5413 normal_lines, normal_cols, new_total, new_normal, clone_number,
5414 splits, nest, prev_buffers, next_buffers.
5415 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5416 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5417
f3d1777e
MR
5418 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5419 Remove.
496e208e
MR
5420 (make_dummy_parent): Set new members of windows structure.
5421 (make_window): Move down in code. Handle new members of window
5422 structure.
5423 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5424 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5425 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5426 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5427 (Fset_window_next_buffers, Fset_window_clone_number):
5428 New functions.
496e208e
MR
5429 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5430 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5431 Doc-string fixes.
5432 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5433 Argument WINDOW can be now internal window too.
5434 (Fwindow_use_time): Move up in code.
5435 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5436 Rewrite doc-string.
5437 (Fset_window_configuration, saved_window)
5438 (Fcurrent_window_configuration, save_window_save): Handle new
5439 members of window structure.
b9e809c2
MR
5440 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5441 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5442 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5443 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5444 Qget_mru_window, Qresize_root_window,
5445 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5446 Qauto_buffer_name; staticpro them.
f3d1777e 5447
abde8f8c
MR
54482011-06-07 Martin Rudalics <rudalics@gmx.at>
5449
5450 * window.c (Fwindow_total_size, Fwindow_left_column)
5451 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5452 (Fwindow_list_1): New functions.
5453 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5454 (Fwindow_width, Fscroll_left, Fscroll_right):
5455 Use window_body_cols instead of window_box_text_cols.
5456 (delete_window, Fset_window_configuration):
5457 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5458 (delete_all_subwindows): Take a window as argument and not a
5459 structure. Rewrite.
190b47e6
MR
5460 (window_loop): Remove handling of GET_LRU_WINDOW and
5461 GET_LARGEST_WINDOW.
5462 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5463
5464 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5465 window_box_text_cols. delete_all_subwindows now takes a
5466 Lisp_Object as argument.
abde8f8c 5467
640c8776
SM
5468 * indent.c (compute_motion, Fcompute_motion):
5469 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5470
fa8a67e6
MR
5471 * frame.c (delete_frame): Call delete_all_subwindows with root
5472 window as argument.
5473
a54e3482
DC
54742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5475
5476 * fns.c (Fputhash): Document return value.
5477
60002bf5
CY
54782011-06-06 Chong Yidong <cyd@stupidchicken.com>
5479
5480 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5481
0c671da6 54822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5483
b862a52a 5484 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5485
be44ca6c
PE
5486 Check for overflow when converting integer to cons and back.
5487 * charset.c (Fdefine_charset_internal, Fdecode_char):
5488 Use cons_to_unsigned to catch overflow.
5489 (Fencode_char): Use INTEGER_TO_CONS.
5490 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5491 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5492 * data.c (long_to_cons, cons_to_long): Remove.
5493 (cons_to_unsigned, cons_to_signed): New functions.
5494 These signal an error for invalid or out-of-range values.
5495 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5496 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5497 * font.c (Ffont_variation_glyphs):
5498 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5499 * lisp.h: Include <intprops.h>.
5500 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5501 (cons_to_signed, cons_to_unsigned): New decls.
5502 (long_to_cons, cons_to_long): Remove decls.
5503 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5504 (Fprimitive_undo): Use CONS_TO_INTEGER.
5505 * xfns.c (Fx_window_property): Likewise.
5506 * xselect.c: Include <limits.h>.
5507 (x_own_selection, selection_data_to_lisp_data):
5508 Use INTEGER_TO_CONS.
5509 (x_handle_selection_request, x_handle_selection_clear)
5510 (x_get_foreign_selection, Fx_disown_selection_internal)
5511 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5512 (lisp_data_to_selection_data): Use cons_to_unsigned.
5513 (x_fill_property_data): Use cons_to_signed.
5514 Report values out of range.
5515
d1f3d2af
PE
5516 Check for buffer and string overflow more precisely.
5517 * buffer.h (BUF_BYTES_MAX): New macro.
5518 * lisp.h (STRING_BYTES_MAX): New macro.
5519 * alloc.c (Fmake_string):
5520 * character.c (string_escape_byte8):
5521 * coding.c (coding_alloc_by_realloc):
5522 * doprnt.c (doprnt):
5523 * editfns.c (Fformat):
5524 * eval.c (verror):
5525 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5526 since they may not be the same number.
5527 * editfns.c (Finsert_char):
5528 * fileio.c (Finsert_file_contents):
5529 Likewise for BUF_BYTES_MAX.
5530
dd52fcea
PE
5531 * image.c: Use ptrdiff_t, not int, for sizes.
5532 (slurp_file): Switch from int to ptrdiff_t.
5533 All uses changed.
5534 (slurp_file): Check that file size fits in both size_t (for
5535 malloc) and ptrdiff_t (for sanity and safety).
5536
7f9bbdbb
PE
5537 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5538 if b->modtime has its maximal value.
5539
dfe18f82
PE
5540 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5541
84acfcf0
PE
5542 Don't assume time_t can fit into int.
5543 * buffer.h (struct buffer.modtime): Now time_t, not int.
5544 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5545 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5546
ccd9a01a
PE
5547 Minor fixes for signed vs unsigned integers.
5548 * character.h (MAYBE_UNIFY_CHAR):
5549 * charset.c (maybe_unify_char):
5550 * keyboard.c (read_char, reorder_modifiers):
5551 XINT -> XFASTINT, since the integer must be nonnegative.
5552 * ftfont.c (ftfont_spec_pattern):
5553 * keymap.c (access_keymap, silly_event_symbol_error):
5554 XUINT -> XFASTINT, since the integer must be nonnegative.
5555 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5556 since it makes no difference and we prefer signed.
5557 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5558 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5559 nonnegative.
5560
d6d100dd
SM
55612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5562
5563 * window.h (Fwindow_frame): Declare.
5564
2b6148e4
PE
55652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5566
5567 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5568 (SPARE_MEMORY): Always define.
5569 (LARGE_REQUEST): Remove.
5570 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5571
f230ecc9
MR
55722011-06-06 Martin Rudalics <rudalics@gmx.at>
5573
727e958e
MR
5574 * lisp.h: Move EXFUNS for Fframe_root_window,
5575 Fframe_first_window and Fset_frame_selected_window to window.h.
5576
5577 * window.h: Move EXFUNS for Fframe_root_window,
5578 Fframe_first_window and Fset_frame_selected_window here from
5579 lisp.h.
5580
5581 * frame.c (Fwindow_frame, Fframe_first_window)
5582 (Fframe_root_window, Fframe_selected_window)
5583 (Fset_frame_selected_window): Move to window.c.
5584 (Factive_minibuffer_window): Move to minibuf.c.
5585 (Fother_visible_frames_p): New function.
5586
5587 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5588
f230ecc9
MR
5589 * window.c (decode_window, decode_any_window): Move up in code.
5590 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5591 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5592 (Fwindow_buffer): Move up and rewrite doc-string.
5593 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5594 (Fwindow_prev): New functions.
727e958e
MR
5595 (Fwindow_frame): Move here from frame.c. Accept any window as
5596 argument.
5597 (Fframe_root_window, Fframe_first_window)
5598 (Fframe_selected_window): Move here from frame.c. Accept frame
5599 or arbitrary window as argument. Update doc-strings.
5600 (Fminibuffer_window): Move up in code.
5601 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5602 (Fset_frame_selected_window): Move here from frame.c.
5603 Marginal rewrite.
727e958e
MR
5604 (Fselected_window, select_window, Fselect_window): Move up in
5605 code. Minor doc-string fixes.
f230ecc9 5606
4d09bcf6
PE
56072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5608
5609 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5610 Do not assume that spare memory exists; that assumption is valid
5611 only if SYSTEM_MALLOC.
5612 (LARGE_REQUEST): New macro, so that the issue of large requests
5613 is separated from the issue of spare memory.
5614
810928a2
AS
56152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5616
172418ad
AS
5617 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5618 format. (Bug#8806)
5619
43f862f7
AS
5620 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5621
810928a2
AS
5622 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5623 before statements.
5624
a059fe24
JD
56252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5626
5627 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5628
5629 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5630
5631 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5632 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5633
989bf368
JB
56342011-06-05 Juanma Barranquero <lekktu@gmail.com>
5635
5636 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5637
4b80f674
CY
56382011-06-04 Chong Yidong <cyd@stupidchicken.com>
5639
5640 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5641 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5642 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5643 New error handlers.
4b80f674
CY
5644 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5645 Obey Vx_select_enable_clipboard_manager. Catch errors in
5646 x_clipboard_manager_save (Bug#8779).
5647 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5648 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5649
99a33b77 56502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5651
5652 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5653
99a33b77 56542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5655
5656 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5657 in the current matrix if keep_current_p is non-zero.
5658
8264569d
EZ
56592011-06-04 Eli Zaretskii <eliz@gnu.org>
5660
5661 * bidi.c (bidi_level_of_next_char): Fix last change.
5662
57f97249
EZ
56632011-06-03 Eli Zaretskii <eliz@gnu.org>
5664
fec2107c 5665 Support bidi reordering of text covered by display properties.
57f97249 5666
fec2107c
EZ
5667 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5668 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5669 (bidi_cache_search, bidi_cache_iterator_state)
5670 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5671 (bidi_level_of_next_char, bidi_move_to_visually_next):
5672 Support character positions inside a run of characters covered by a
fec2107c
EZ
5673 display string.
5674 (bidi_paragraph_init, bidi_resolve_explicit_1)
5675 (bidi_level_of_next_char): Call bidi_fetch_char and
5676 bidi_fetch_char_advance instead of FETCH_CHAR and
5677 FETCH_CHAR_ADVANCE.
5678 (bidi_init_it): Initialize new members.
5679 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5680 definitions.
5681 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5682 instead of using explicit *_CHAR codes.
d6d100dd
SM
5683 (bidi_resolve_explicit, bidi_resolve_weak):
5684 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5685 bidirectional text is supported only in multibyte buffers.
5686 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5687 it to initialize the frame_window_p member of struct bidi_it.
5688 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5689 (bidi_resolve_explicit, bidi_resolve_weak)
5690 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5691 bidi_it->nchars is non-positive.
5692 (bidi_level_of_next_char): Don't try to lookup the cache for the
5693 next/previous character if nothing is cached there yet, or if we
5694 were just reseat()'ed to a new position.
c40e2fb2 5695
0e14fe90
EZ
5696 * xdisp.c (set_cursor_from_row): Set start and stop points
5697 according to the row's direction when priming the loop that looks
5698 for the glyph on which to display cursor.
5699 (single_display_spec_intangible_p): Function deleted.
5700 (display_prop_intangible_p): Reimplement to call
5701 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5702 Accept 3 additional arguments needed by handle_display_spec.
5703 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5704 values: lists, `(when COND...)' forms, etc.
5705 (single_display_spec_string_p): Support property values that are
5706 lists with the argument STRING its top-level element.
5707 (display_prop_string_p): Fix the condition for processing a
5708 property that is a list to be consistent with handle_display_spec.
fec2107c 5709 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5710 last portion of handle_display_prop.
5711 (compute_display_string_pos): Accept additional argument
5712 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5713 value of a `display' property is a "replacing spec".
5714 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5715 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5716 the display property, but just return a value indicating whether
5717 the display property will replace the characters it covers.
5718 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5719 frame_window_p members of struct bidi_it.
d6d100dd
SM
5720 (compute_display_string_pos, compute_display_string_end):
5721 New functions.
fec2107c
EZ
5722 (push_it): Accept second argument POSITION, where pop_it should
5723 jump to continue iteration.
5724 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5725
fec2107c
EZ
5726 * keyboard.c (adjust_point_for_property): Adjust the call to
5727 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5728
5729 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5730 (bidi_init_it): Update prototypes.
5731 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5732 (compute_display_string_pos, compute_display_string_end):
5733 Declare prototypes.
fec2107c
EZ
5734 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5735 EMACS_INT.
fc6f18ce 5736
40087514 57372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5738
57f53182
PE
5739 Malloc failure behavior now depends on size of allocation.
5740 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5741 * lisp.h: Change signatures accordingly.
5742 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5743 All callers changed. (Bug#8762)
5744
5745 * gnutls.c: Use Emacs's memory allocators.
5746 Without this change, the gnutls library would invoke malloc etc.
5747 directly, which causes problems on non-SYNC_INPUT hosts, and which
5748 runs afoul of improving memory_full behavior. (Bug#8761)
5749 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5750 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5751 xfree instead of the default malloc, realloc, free.
5752 (Fgnutls_boot): No need to check for memory allocation failure,
5753 since xmalloc does that for us.
5754
ac32cd99 5755 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5756 * category.c (hash_get_category_set):
5757 * ccl.c (ccl_driver):
5758 * charset.c (Fdefine_charset_internal):
5759 * charset.h (struct charset.hash_index):
5760 * composite.c (get_composition_id, gstring_lookup_cache)
5761 (composition_gstring_put_cache):
5762 * composite.h (struct composition.hash_index):
5763 * dispextern.h (struct image.hash):
5764 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5765 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5766 (hashfn_equal, hashfn_user_defined, make_hash_table)
5767 (maybe_resize_hash_table, hash_lookup, hash_put)
5768 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5769 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5770 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5771 * image.c (make_image, search_image_cache, lookup_image)
5772 (xpm_put_color_table_h):
5773 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5774 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5775 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5776 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5777 * alloc.c (allocate_vectorlike):
5778 Check for overflow in vector size calculations.
5779 * ccl.c (ccl_driver):
5780 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5781 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5782 need to be updated by these changes.
40087514
PE
5783 * fns.c (make_hash_table, maybe_resize_hash_table):
5784 Check for integer overflow with large hash tables.
0de4bb68
PE
5785 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5786 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5787 (SXHASH_REDUCE): New macro.
5788 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5789 Use it instead of discarding useful hash info with large hash values.
5790 (sxhash_float): New function.
5791 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5792 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5793 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5794 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5795 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5796 Adjust signatures to match updated version of code.
5797 (consing_since_gc): Now EMACS_INT, since a single hash table can
5798 use more than INT_MAX bytes.
5799
698d32e2
DN
58002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5801
5802 Make it possible to build with GCC-4.6+ -O2 -flto.
5803
5804 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5805
fd6fa53f
SM
58062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5807
5808 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5809 Call minibuffer-inactive-mode.
5810
864db017
JB
58112011-05-31 Juanma Barranquero <lekktu@gmail.com>
5812
5813 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5814 Update dependencies.
5815
2ad0baf4
DN
58162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5817
5818 * data.c (init_data): Remove code for UTS, this system is not
5819 supported anymore.
5820
4fcc2638
DN
58212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5822
5823 Don't force ./temacs to start in terminal mode.
5824
5825 * frame.c (make_initial_frame): Initialize faces in all cases, not
5826 only when CANNOT_DUMP is defined.
5827 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5828
c56e0fd5
DN
58292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5830
5831 * dispnew.c (add_window_display_history): Use const for the string
5832 pointer. Remove declaration, not needed.
5833
333d54da 58342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5835
55d4c1b2 5836 Use 'inline', not 'INLINE'.
333d54da 5837 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5838 * alloc.c, fontset.c (INLINE): Remove.
5839 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5840 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5841 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5842 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5843 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5844
738db178
DN
58452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5846
5847 Make it possible to run ./temacs.
5848
5849 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5850 syms_of_callproc does the same thing. Remove test for
5851 "initialized", do it in the caller.
5852 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5853
620c53a6
SM
58542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5855
5856 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5857 (read_minibuf): Use get_minibuffer.
5858 (syms_of_minibuf): Use DEFSYM.
5859 (Qmetadata): New var.
5860 * data.c (Qbuffer): Don't make it static.
5861 (syms_of_data): Use DEFSYM.
5862
e003a292
PE
58632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5864
5865 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5866 (CCL_CODE_MIN): New macro.
5867
ed008a6d
PE
58682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5869
3687c2ef
PE
5870 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5871
ed008a6d
PE
5872 * eval.c (Qdebug): Now static.
5873 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5874 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5875 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5876
d66c4c7c
CY
58772011-05-29 Chong Yidong <cyd@stupidchicken.com>
5878
5879 * image.c: Various fixes to ImageMagick code comments.
5880 (Fimagemagick_types): Doc fix.
5881
5fbc2025
PE
58822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5883
0196f88a
PE
5884 Minor fixes prompted by GCC 4.6.0 warnings.
5885
5886 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5887
5fbc2025
PE
5888 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5889 (x_clipboard_manager_save_all): Move extern decl to ...
5890 * xterm.h: ... here, so that it can be checked for consistency.
5891
1dd3c2d9
CY
58922011-05-29 Chong Yidong <cyd@stupidchicken.com>
5893
5894 * xselect.c (x_clipboard_manager_save_frame)
5895 (x_clipboard_manager_save_all): New functions.
5896 (Fx_clipboard_manager_save): Lisp function deleted.
5897
5898 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5899 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5900
5901 * xterm.h: Update prototype.
5902
5ba6571d
WX
59032011-05-28 William Xu <william.xwl@gmail.com>
5904
5905 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5906 exiting (Bug#8239).
5907
3eaff834
JM
59082011-05-28 Jim Meyering <meyering@redhat.com>
5909
e1900994 5910 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5911 * fns.c (to_uchar): Define.
5912 (crypto_hash_function): Use it to convert some newly-signed
5913 variables to unsigned, to avoid sign-extension bugs. For example,
5914 without this change, (md5 "truc") would evaluate to
5915 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5916 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5917 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5918
0f6990a7
PE
59192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5920
5921 Integer overflow fixes.
c8a9ca5a 5922
08686060
PE
5923 * dbusbind.c: Serial number integer overflow fixes.
5924 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5925 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5926 to hold a serial number that is too large for a fixnum.
5927 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5928 Check for serial numbers out of range. Decode any serial number
59568bf0 5929 that was so large that it became a float. (Bug#8722)
08686060 5930
2d1fc3c7
PE
5931 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5932 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5933 Use XFASTINT rather than XUINT when numbers are nonnegative.
5934 (xd_append_arg, Fdbus_method_return_internal):
5935 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5936 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5937 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5938 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5939 (Bug#8722)
2d1fc3c7 5940
c8a9ca5a
PE
5941 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5942
519e1d69
PE
5943 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5944
6df6ae42 5945 ccl: Add integer overflow checks.
30569699
PE
5946 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5947 (IN_INT_RANGE): New macros.
5948 (ccl_driver): Use them to check for integer overflow when
5949 decoding a CCL program. Many of the new checks are whether XINT (x)
5950 fits in int; it doesn't always, on 64-bit hosts. The new version
5951 doesn't catch all possible integer overflows, but it's an
847044ea 5952 improvement. (Bug#8719)
30569699 5953
c11285dc
PE
5954 * alloc.c (make_event_array): Use XINT, not XUINT.
5955 There's no need for unsigned here.
5956
fdccd48e
PE
5957 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5958 This follows up to the 2011-05-06 change that substituted uintptr_t
5959 for EMACS_INT. This case wasn't caught back then.
5960
37910ab2
PE
5961 Rework Fformat to avoid integer overflow issues.
5962 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5963 now (part of C89). Include <verify.h>.
5964 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5965 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5966 (Fformat): Avoid the prepass trying to compute sizes; it was only
5967 approximate and thus did not catch overflow reliably. Instead, walk
5968 through the format just once, formatting and computing sizes as we go,
5969 checking for integer overflow at every step, and allocating a larger
5970 buffer as needed. Keep track separately whether the format is
5971 multibyte. Keep only the most-recently calculated precision, rather
5972 than them all. Record whether each argument has been converted to
5973 string. Use EMACS_INT, not int, for byte and char and arg counts.
5974 Support field widths and precisions larger than INT_MAX. Avoid
5975 sprintf's undefined behavior with conversion specifications such as %#d
5976 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5977 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5978 formatting out-of-range floating point numbers with int
9173deec 5979 formats. (Bug#8668)
37910ab2 5980
2e6578fb
PE
5981 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5982
0ae6bdee
PE
5983 * data.c: Avoid integer truncation in expressions involving floats.
5984 * data.c: Include <intprops.h>.
5985 (arith_driver): When there's an integer overflow in an expression
5986 involving floating point, convert the integers to floating point
5987 so that the resulting value does not suffer from catastrophic
5988 integer truncation. For example, on a 64-bit host (* 4
5989 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5990 Do not rely on undefined behavior after integer overflow.
5991
de883a70
PE
5992 merge count_size_as_multibyte, parse_str_to_multibyte
5993 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5994 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5995 Check for integer overflow.
5996 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5997 since it's now a duplicate of the other. This is more of
5998 a character than a buffer op, so better that it's in character.c.
5999 * fns.c, print.c: Adjust to above changes.
6000
2ff916cb
PE
60012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6002
6003 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6004
f1b54466
PE
60052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6006
fb1ac845
PE
6007 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6008 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6009 (x_clipboard_manager_save): Now static.
6010 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6011
f1b54466
PE
6012 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6013 (crypto_hash_function): Now static.
6014 Fix pointer signedness problems. Avoid unnecessary initializations.
6015
a9f737ee
CY
60162011-05-27 Chong Yidong <cyd@stupidchicken.com>
6017
6018 * termhooks.h (Vselection_alist): Make it terminal-local.
6019
6020 * terminal.c (create_terminal): Initialize it.
6021
6022 * xselect.c: Support for clipboard managers.
6023 (Vselection_alist): Move to termhooks.h as terminal-local var.
6024 (LOCAL_SELECTION): New macro.
6025 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6026 (symbol_to_x_atom): Remove gratuitous arg.
6027 (x_handle_selection_request, lisp_data_to_selection_data)
6028 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6029 (x_own_selection, x_get_local_selection, x_convert_selection):
6030 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6031 (some_frame_on_display): Delete unused function.
6032 (Fx_own_selection_internal, Fx_get_selection_internal)
6033 (Fx_disown_selection_internal, Fx_selection_owner_p)
6034 (Fx_selection_exists_p): New optional frame arg.
6035 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6036 (x_handle_selection_clear): Don't treat other terminals with the
6037 same keyboard specially. Use the terminal-local Vselection_alist.
6038 (x_clear_frame_selections): Use Frun_hook_with_args.
6039
6040 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6041
6042 * xterm.h: Add support for those atoms.
6043
e067f0c1
CY
60442011-05-26 Chong Yidong <cyd@stupidchicken.com>
6045
6046 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6047 (converted_selections, conversion_fail_tag): New global variables.
6048 (x_selection_request_lisp_error): Free the above.
6049 (x_get_local_selection): Remove unnecessary code.
6050 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6051 of converted selections stored in converted_selections.
6052 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6053 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6054 (x_convert_selection): New function.
6055 (x_handle_selection_event): Simplify.
6056 (x_get_foreign_selection): Don't ignore incoming requests while
6057 waiting for an answer; this will fail when we implement
6058 SAVE_TARGETS, and seems unnecessary anyway.
6059 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6060 (Vx_sent_selection_functions): Doc fix.
6061
0f4aebc0
LL
60622011-05-26 Leo Liu <sdl.web@gmail.com>
6063
6064 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6065
e61124cd
YM
60662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6067
6068 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6069
6070 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6071 for fringe update if it has periodic bitmap.
ac389d0c 6072 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6073 and fringe_bitmap_periodic_p.
6074
6075 * fringe.c (get_fringe_bitmap_data): New function.
6076 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6077 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6078 row. Mark glyph row for fringe update if periodicity changed.
6079
6080 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6081 for fringe update unless it has periodic bitmap.
6082
f16d9837
KH
60832011-05-25 Kenichi Handa <handa@m17n.org>
6084
6085 * xdisp.c (get_next_display_element): Set correct it->face_id for
6086 a static composition.
6087
e1b90ef6
LL
60882011-05-24 Leo Liu <sdl.web@gmail.com>
6089
6090 * deps.mk (fns.o):
6091 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6092
6093 * fns.c (crypto_hash_function, Fsha1): New function.
6094 (Fmd5): Use crypto_hash_function.
6095 (syms_of_fns): Add Ssha1.
6096
7400048f
PE
60972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6098
6099 * gnutls.c: Remove unused macros.
6100 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6101 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6102 Remove macros that are defined and never used.
6103 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6104
abb71cf4
CY
61052011-05-22 Chong Yidong <cyd@stupidchicken.com>
6106
6107 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6108 (Fx_get_selection_internal): Minor cleanup.
6109 (Fx_own_selection_internal): Rename arguments for consistency with
6110 select.el.
6111
6307db39
PE
61122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6115
f3d4e0a4
CY
61162011-05-22 Chong Yidong <cyd@stupidchicken.com>
6117
6118 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6119
4d8ade89
YM
61202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6121
6122 * dispnew.c (scrolling_window): Don't exclude the case that the
6123 last enabled row in the desired matrix touches the bottom boundary.
6124
32078c8d
GM
61252011-05-21 Glenn Morris <rgm@gnu.org>
6126
6127 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6128 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6129 and add some more files.
32078c8d 6130
7285dc67
EZ
61312011-05-20 Eli Zaretskii <eliz@gnu.org>
6132
6133 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6134 report_file_error introduced by the change from 2011-05-07.
6135
89d1bd22
PE
61362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6137
6138 * systime.h (Time): Define only if emacs is defined.
6139 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6140 where the include path doesn't have X11/X.h by default. See
6141 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6142
cd394be1 61432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6144
6145 * composite.c (find_automatic_composition): Fix previous change.
6146
b9704ad9
GM
61472011-05-20 Glenn Morris <rgm@gnu.org>
6148
6149 * lisp.mk: New file, split from Makefile.in.
6150 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6151 (shortlisp): Remove.
6152 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6153
4a720484
GM
61542011-05-19 Glenn Morris <rgm@gnu.org>
6155
6156 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6157 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6158 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6159 (lisp): Set the order to that of loadup.el.
6160 (shortlisp): Make it a copy of $lisp.
6161 (SOME_MACHINE_LISP): Remove.
6162 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6163 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6164
a28d4396
KH
61652011-05-18 Kenichi Handa <handa@m17n.org>
6166
6167 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6168 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6169 (find_automatic_composition): Mostly rewrite for efficiency.
6170
a2b1fa8e
JB
61712011-05-18 Juanma Barranquero <lekktu@gmail.com>
6172
6173 * makefile.w32-in: Update dependencies.
6174
8e1f5610
CS
61752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6176
6177 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6178 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6179
7025ee00 61802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6181
cdfa6eab
PE
6182 Fix some integer overflow issues, such as string length overflow.
6183
06d6db33
PE
6184 * insdel.c (count_size_as_multibyte): Check for string overflow.
6185
2b4560a8
PE
6186 * character.c (lisp_string_width): Check for string overflow.
6187 Use EMACS_INT, not int, for string indexes and lengths; in
6188 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6189 the resulting string length overflows an EMACS_INT; instead,
6190 report a string overflow if no precision given. When checking for
6191 precision exhaustion, use a check that cannot possibly have
6192 integer overflow. (Bug#8675)
6193 * character.h (lisp_string_width): Adjust to new signature.
6194
cb93f9be
PE
6195 * alloc.c (string_overflow): New function.
6196 (Fmake_string): Use it. This doesn't change behavior, but saves
6197 a few bytes and will simplify future changes.
6198 * character.c (string_escape_byte8): Likewise.
6199 * lisp.h (string_overflow): New decl.
6200
1a1f3366
PE
6201 Fixups, following up to the user-interface timestamp change.
6202 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6203 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6204 * msdos.c (mouse_get_pos): Likewise.
6205 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6206 * w32gui.h (Time): Define by including "systime.h" rather than by
6207 declaring it ourselves. (Bug#8664)
6208
d4e3e4d3
PE
6209 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6210 * image.c (clear_image_cache): Likewise.
6211
f6a24d19
PE
6212 * term.c (term_mouse_position): Don't assume time_t wraparound.
6213
08dc5ae6
PE
6214 Be more systematic about user-interface timestamps.
6215 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6216 and sometimes 'EMACS_UINT', to represent these timestamps.
6217 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6218 This makes the code easier to follow, and makes it easier to catch
6219 integer overflow bugs such as Bug#8664.
6220 * frame.c (Fmouse_position, Fmouse_pixel_position):
6221 Use Time, not unsigned long, for user-interface timestamps.
6222 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6223 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6224 * keyboard.h (last_event_timestamp): Likewise.
6225 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6226 * menu.h (xmenu_show): Likewise.
6227 * term.c (term_mouse_position): Likewise.
6228 * termhooks.h (struct input_event.timestamp): Likewise.
6229 (struct terminal.mouse_position_hook): Likewise.
6230 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6231 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6232 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6233 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6234 what it was before.
6235 * menu.h, termhooks.h: Include "systime.h", for Time.
6236
8e55734a
PE
6237 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6238 Don't assume that the difference between two unsigned long values
6239 can fit into an integer. At this point, we know button_down_time
6240 <= event->timestamp, so the difference must be nonnegative, so
6241 there's no need to cast the result if double-click-time is
6242 nonnegative, as it should be; check that it's nonnegative, just in
6243 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6244 apart (about 25 days). (Bug#8664)
8e55734a 6245
841f1b75 6246 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6247 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6248
3e26f69c
PE
6249 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6250 that always fit in int. Use a sentinel instead of a counter, to
6251 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6252 * frame.h (struct frame): Use int for menu_bar_items_used
6253 instead of EMACS_INT, since it always fits in int.
3e26f69c 6254
5cc152c0
PE
6255 * menu.c (grow_menu_items): Check for int overflow.
6256
d89eb65e
PE
6257 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6258
5235bd3e
PE
6259 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6260 Before, the code was not consistent. These values cannot exceed
6261 2**31 - 1 so there's no need to make them unsigned.
6262 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6263 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6264 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6265 as modifiers.
6266 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6267
bc827e23
PE
6268 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6269 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6270 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6271 presumably because the widths might not match.
6272
78eb494e
PE
6273 * window.c (size_window): Avoid needless test at loop start.
6274
04f2d78b
CB
62752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6276
6277 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6278
d2fc7e3d 62792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6280
6281 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6282
d2fc7e3d 62832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6284
6285 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6286 `width' to `bar_area_x' and `bar_area_width', respectively.
6287 (x_scroll_run): Take account of fringe background extension.
6288
04f2d78b
CB
6289 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6290 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6291 `bar_area_width', respectively.
6292 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6293 background extension.
6294
79b70037
GM
62952011-05-10 Jim Meyering <meyering@redhat.com>
6296
6297 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6298
2f142cc5
JB
62992011-05-10 Juanma Barranquero <lekktu@gmail.com>
6300
6301 * image.c (Finit_image_library): Return t for built-in image types,
6302 like pbm and xbm. (Bug#8640)
6303
57679c86
AS
63042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6305
6306 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6307
888c9e86
EZ
63082011-05-07 Eli Zaretskii <eliz@gnu.org>
6309
b0512a1d
EZ
6310 * w32console.c (Fset_screen_color): Doc fix.
6311 (Fget_screen_color): New function.
6312 (syms_of_ntterm): Defsubr it.
6313
7285dc67
EZ
6314 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6315 unlink the temporary file if Fcall_process didn't create it in the
6316 first place.
6317 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6318 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6319 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6320 cue to call_process_cleanup not to close that handle.
6321
4d3fcc8e
BK
63222011-05-07 Ben Key <bkey76@gmail.com>
6323
6324 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6325 one of two shell specific rules, either bootstrap-temacs-CMD or
6326 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6327 to the previous implementation of the bootstrap-temacs rule.
6328 The bootstrap-temacs-CMD rule is similar to the previous
6329 implementation of the bootstrap-temacs rule except that it
6330 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6331 variable.
6332
6333 These changes, along with some changes to nt/configure.bat,
6334 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6335 earlier fix to add support for --cflags and --ldflags options
6336 that include quotes so that it works whether make uses cmd or
6337 sh as the shell.
6338
b4289b64
MA
63392011-05-06 Michael Albinus <michael.albinus@gmx.de>
6340
6341 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6342 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6343 is a constant.
6344 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6345 a string. Handle both cases.
6346 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6347 (Fdbus_register_method): Use Qinvalid_function.
6348
af4c0e28
JB
63492011-05-06 Juanma Barranquero <lekktu@gmail.com>
6350
6351 * makefile.w32-in: Update dependencies.
6352 (LISP_H): Add inttypes.h and stdin.h.
6353 (PROCESS_H): Add unistd.h.
6354
c51453d9
EZ
63552011-05-06 Eli Zaretskii <eliz@gnu.org>
6356
6357 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6358 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6359
8ff0ac3c 63602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6361
4c4b566b
PE
6362 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6363
aab2b9b5
PE
6364 * term.c (vfatal): Remove stray call to va_end.
6365 It's not needed and the C Standard doesn't allow it here anyway.
6366
c378da0b
PE
6367 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6368 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6369
288b08c7
PE
6370 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6371 bytes.
6372
e3601888
PE
6373 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6374
db6c0e74
PE
6375 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6376
dd5963ea
PE
6377 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6378
88c9450f
PE
6379 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6380
2f9442b8
PE
6381 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6382
c032b5f8
PE
6383 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6384 * charset.c (Fdefine_charset_internal): Don't initialize
6385 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6386 32-bit int (Bug#8600).
a108c10b
PE
6387
6388 * lread.c (read_integer): Be more consistent with string-to-number.
6389 Use string_to_number to do the actual conversion; this avoids
6390 rounding errors and fixes some other screwups. Without this fix,
6391 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6392 (digit_to_number): Move earlier, for benefit of read_integer.
6393 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6394 not a digit in any supported base. (Bug#8602)
a108c10b 6395
ad5f9eea
PE
6396 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6397
aec1708a
PE
6398 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6399 to match comment at start of function. This also removes a
6400 GCC warning about overflow in a 32+64-bit port.
6401
47be4ab5
PE
6402 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6403
371cac43
PE
6404 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6405 Reported by Stefan Monnier in
6406 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6407 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6408 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6409
d01a7826
PE
6410 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6411 (EMACS_UINTPTR): Likewise, with uintptr_t.
6412
7fd47d5c
PE
6413 * lisp.h: Prefer 64-bit EMACS_INT if available.
6414 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6415 on 32-bit hosts that have 64-bit int, so that they can access
6416 large files.
122b0c86
PE
6417 However, temporarily disable this change unless the temporary
6418 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6419
8727937b
PE
6420 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6421
8ac068ac
PE
6422 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6423 This removes an assumption that EMACS_INT and long are the same
6424 width as pointers. The assumption is true for Emacs porting targets
6425 now, but we want to make other targets possible.
6426 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6427 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6428 In the rest of the code, change types of integers that hold casted
6429 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6430 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6431 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6432 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6433 No need to cast type when ORing.
6434 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6435 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6436 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6437 assume EMACS_INT is the same width as char *.
6438 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6439 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6440 Remove no-longer-needed casts.
6441 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6442 (xg_tool_bar_help_callback, xg_make_tool_item):
6443 Use EMACS_INTPTR to hold an integer
6444 that will be cast to void *; this can avoid a GCC warning
6445 if EMACS_INT is not the same width as void *.
6446 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6447 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6448 (current_message_1, set_message_1):
6449 Use a local to convert to proper width without a cast.
6450 * xmenu.c (dialog_selection_callback): Likewise.
6451
ede49d71
PE
6452 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6453 Also, don't assume VALBITS / RAND_BITS is less than 5,
6454 and don't rely on undefined behavior when shifting a 1 left into
6455 the sign bit.
6456 * lisp.h (get_random): Change signature to match.
6457
2f30ecd0
PE
6458 * lread.c (hash_string): Use size_t, not int, for hash computation.
6459 Normally we prefer signed values; but hashing is special, because
6460 it's better to use unsigned division on hash table sizes so that
6461 the remainder is nonnegative. Also, size_t is the natural width
6462 for hashing into memory. The previous code used 'int', which doesn't
6463 retain enough info to hash well into very large tables.
6464 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6465
2a866e7b
PE
6466 * dbusbind.c: Don't possibly lose pointer info when converting.
6467 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6468 Use XPNTR rather than XHASH, so that the high-order bits of
6469 the pointer aren't lost when converting through void *.
6470
51639eac
PE
6471 * eval.c (Fautoload): Don't double-shift a pointer.
6472
92394119
PE
6473 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6474
dbdb9a7c
JB
64752011-05-06 Juanma Barranquero <lekktu@gmail.com>
6476
6477 * gnutls.c (DEF_GNUTLS_FN):
6478 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6479
db7a0b4f
AS
64802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6481
6482 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6483 marker. (Bug#8610)
6484
cd394be1 64852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6486
6487 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6488 New version that can reserve upto 2GB of heap space.
6489
f7ff1b0f 64902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6491
6492 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6493
639c109b
TZ
64942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6495
6496 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6497 `gnutls_certificate_set_x509_key_file'.
6498
d2127135
JB
64992011-05-05 Juanma Barranquero <lekktu@gmail.com>
6500
6501 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6502 Update dependencies.
6503
e968f4f3
JB
65042011-05-04 Juanma Barranquero <lekktu@gmail.com>
6505
6506 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6507 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6508 Remove unused parameter `fildes'.
6509 * process.c (read_process_output, send_process): Don't pass it.
6510
84d358f0
JB
65112011-05-04 Juanma Barranquero <lekktu@gmail.com>
6512
6513 Fix previous change: the library cache is defined in w32.c.
6514 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6515 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6516
0898ca10
JB
65172011-05-04 Juanma Barranquero <lekktu@gmail.com>
6518
6519 Implement dynamic loading of GnuTLS on Windows.
6520
6521 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6522 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6523 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6524 Declare.
6525
6526 * gnutls.c (Qgnutls_dll): Define.
6527 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6528 (gnutls_*): Declare function pointers.
6529 (init_gnutls_functions): New function to initialize function pointers.
6530 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6531 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6532 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6533 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6534 (emacs_gnutls_write, emacs_gnutls_read)
6535 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6536 (Fgnutls_available_p): New function.
6537 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6538 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6539 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6540
6541 * image.c: Include w32.h.
6542 (Vimage_type_cache): Delete.
6543 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6544 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6545 (w32_delayed_load): Move to w32.c.
6546
6547 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6548
6549 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6550 (w32_delayed_load): Move from image.c. When loading a library, record
6551 its filename in the :loaded-from property of the library id.
6552 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6553 Initialize and staticpro them.
6554 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6555
6556 * process.c: Include lisp.h before w32.h, not after.
6557 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6558 instead of gnutls_record_check_pending.
6559
6560 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6561
ff4de4aa
TZ
65622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6563
6564 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6565 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6566 as passed in.
6567
abe95abb
JD
65682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6569
6570 * xterm.c (x_set_frame_alpha): Do not set property on anything
6571 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6572
e16e55d4
JB
65732011-05-02 Juanma Barranquero <lekktu@gmail.com>
6574
6575 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6576
bafcf6a5
JB
65772011-05-02 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6580 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6581 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6582 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6583 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6584 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6585 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6586 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6587 (Qgnutls_bootprop_callbacks_verify): Make static.
6588
e7a6747f
AS
65892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6590
19ed11ba
AS
6591 * callproc.c: Indentation fixup.
6592
e7a6747f 6593 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6594 (wait_for_termination, interruptible_wait_for_termination):
6595 Move after wait_for_termination_1.
e7a6747f 6596
1ef14cb4
LMI
65972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6598
6599 * sysdep.c (interruptible_wait_for_termination): New function
6600 which is like wait_for_termination, but allows keyboard
6601 interruptions.
6602
6603 * callproc.c (Fcall_process): Add (:file "file") as an option for
6604 the STDOUT buffer.
6605 (Fcall_process_region): Ditto.
6606
330d880c
EZ
66072011-04-30 Eli Zaretskii <eliz@gnu.org>
6608
8db90b73
EZ
6609 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6610 rather than `XVECTOR (FOO)->size'.
6611
330d880c
EZ
6612 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6613 inttypes.h, as a gnulib replacement is used if it not available in
6614 system headers.
6615
15cbd324
EZ
66162011-04-21 Eli Zaretskii <eliz@gnu.org>
6617
6618 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6619 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6620 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6621
6622 * coding.c (coding_alloc_by_realloc): Error out if destination
6623 will grow beyond MOST_POSITIVE_FIXNUM.
6624 (decode_coding_emacs_mule): Abort if there isn't enough place in
6625 charbuf for the composition carryover bytes. Reserve an extra
6626 space for up to 2 characters produced in a loop.
6627 (decode_coding_iso_2022): Abort if there isn't enough place in
6628 charbuf for the composition carryover bytes.
6629
66302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6631
ae940cca
EZ
6632 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6633 aborting when %lld or %lll format is passed.
6634 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6635 %llo or %llx format is passed. (Bug#8545)
6636
03ab8921
EZ
6637 * window.c (window_scroll_line_based): Use a marker instead of
6638 simple variables to record original value of point. (Bug#7952)
6639
afda1437
EZ
6640 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6641 produced by %s or %c overflows available buffer space. (Bug#8545)
6642
f76dee0c
PE
66432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6644
6645 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6646 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6647
fdc5744d
JB
66482011-04-28 Juanma Barranquero <lekktu@gmail.com>
6649
6650 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6651
638f053a
JB
66522011-04-28 Juanma Barranquero <lekktu@gmail.com>
6653
6654 * keyboard.c (Qdelayed_warnings_hook): Define.
6655 (command_loop_1): Run `delayed-warnings-hook'
6656 if Vdelayed_warnings_list is non-nil.
6657 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6658 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6659
d178f871
EZ
66602011-04-28 Eli Zaretskii <eliz@gnu.org>
6661
6662 * doprnt.c (doprnt): Don't return value smaller than the buffer
6663 size if the message was truncated. (Bug#8545).
6664
b124fd93
JB
66652011-04-28 Juanma Barranquero <lekktu@gmail.com>
6666
6667 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6668 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6669
e810457d
PE
66702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6671
6672 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6673
ea51cceb
JB
66742011-04-27 Juanma Barranquero <lekktu@gmail.com>
6675
6676 * makefile.w32-in: Update dependencies.
6677
94dcfacf
EZ
66782011-04-27 Eli Zaretskii <eliz@gnu.org>
6679
6680 Improve `doprnt' and its usage. (Bug#8545)
6681 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6682 `format_end'. Remove support for %l as a conversion specifier.
6683 Don't use xrealloc. Improve diagnostics when the %l size modifier
6684 is used. Update the commentary.
6685
6686 * eval.c (verror): Simplify calculation of size_t.
6687
6688 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6689 messages.
6690
f61f41d7
PE
66912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6692
6693 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6694 change.
6695
96fb4434
PE
66962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6697
6698 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6699 This makes this file independent of the recent pseudovector change.
6700
671875da 67012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6702
69e9b5a3
PE
6703 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6704
b5f869a7 6705 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6706 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6707 Remove unused local.
c8926152 6708 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6709
841a1577 6710 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6711 GCC 4.6.0 optimizes based on type-based alias analysis.
6712 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6713 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6714 != &v->size, and therefore "v->size = 1; b->size = 2; return
6715 v->size;" must therefore return 1. This assumption is incorrect
6716 for Emacs, since it type-puns struct Lisp_Vector * with many other
6717 types. To fix this problem, this patch adds a new type struct
f904488f 6718 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6719 and pseudovectors, and helps optimizing compilers not get fooled
6720 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6721 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6722 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6723 the size member.
eab3844f
PE
6724 (XSETPVECTYPE): Rewrite in terms of new macro.
6725 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6726 This is a bit clearer, and further avoids the possibility of
6727 undesirable aliasing.
6728 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6729 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6730 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6731 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6732 (ASIZE): Now uses header.size rather than size.
6733 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6734 to avoid the hassle of writing XVECTOR (foo)->header.size.
6735 (struct vectorlike_header): New type.
eab3844f
PE
6736 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6737 object, to help avoid aliasing.
6738 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6739 (SUBRP): Likewise, since Lisp_Subr is a special case.
6740 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6741 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6742 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6743 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6744 changed to be "header.size" and "header.next".
6745 * buffer.h (struct buffer): Likewise.
6746 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6747 * frame.h (struct frame): Likewise.
6748 * process.h (struct Lisp_Process): Likewise.
6749 * termhooks.h (struct terminal): Likewise.
6750 * window.c (struct save_window_data, struct saved_window): Likewise.
6751 * window.h (struct window): Likewise.
6752 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6753 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6754 * buffer.c (init_buffer_once): Likewise.
6755 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6756 special case.
6757 * process.c (Fformat_network_address): Use local var for size,
6758 for brevity.
6759
0df1eac5
PE
6760 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6761
847ab9d1 6762 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6763 * data.c (atof): Remove decl; no longer used or needed.
6764 (digit_to_number): Move to lread.c.
6765 (Fstring_to_number): Use new string_to_number function, to be
6766 consistent with how the Lisp reader treats infinities and NaNs.
6767 Do not assume that floating-point numbers represent EMACS_INT
6768 without losing information; this is not true on most 64-bit hosts.
6769 Avoid double-rounding errors, by insisting on integers when
6770 parsing non-base-10 numbers, as the documentation specifies.
6771 * lisp.h (string_to_number): New decl, replacing ...
6772 (isfloat_string): Remove.
bc0a5c13 6773 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6774 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6775 appears to have been a coding error. Similarly, do not accept
6776 strings like +-1e0 as floating point numbers. Do not report
6777 overflow for integer overflows unless the base is not 10 which
6778 means we have no simple and reliable way to continue.
6779 Break out the floating-point parsing into a new
6780 function string_to_number, so that Fstring_to_number parses
6781 floating point numbers consistently with the Lisp reader.
04f2d78b 6782 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6783 (E_CHAR, EXP_INT): Remove, replacing with ...
6784 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6785 (string_to_number): New function, replacing isfloat_string.
6786 This function checks for valid syntax and produces the resulting
6787 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6788 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6789 so that overflow for non-base-10 numbers is reported only when
6790 there's no portable and simple way to convert to floating point.
452f4150 6791
67769ffc
PE
6792 * textprop.c (set_text_properties_1): Rewrite for clarity,
6793 and to avoid GCC warning about integer overflow.
6794
c20db43f
PE
6795 * intervals.h (struct interval): Use EMACS_INT for members
6796 where EMACS_UINT might cause problems. See
6797 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6798 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6799 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6800 All uses changed.
37aa2f85
PE
6801 (offset_intervals): Tell GCC not to worry about length overflow
6802 when negating a negative length.
c20db43f 6803
2538aa2f
PE
6804 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6805 (overrun_check_free): Likewise.
6806
f2d3008d
PE
6807 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6808 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6809 word size.
6810
ec8df744
PE
6811 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6812 (gnutls_make_error): Rename local to avoid shadowing.
6813 (gnutls_emacs_global_deinit): ifdef out; not used.
6814 (Fgnutls_boot): Use const for pointer to readonly storage.
6815 Comment out unused local. Fix pointer signedness problems.
6816
640ee02d
PE
6817 * lread.c (openp): Don't stuff size_t into an 'int'.
6818 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6819 about possible signed overflow.
6820
6048fb2a
PE
6821 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6822 (GDK_KEY_g): Don't define if already defined.
6823 (xg_prepare_tooltip): Avoid pointer signedness problem.
6824 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6825
fa3c87e1
PE
6826 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6827 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6828
2172544b
PE
6829 * xfns.c (Fx_window_property): Simplify a bit,
6830 to make a bit faster and to avoid GCC 4.6.0 warning.
6831 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6832
9b821a21
PE
6833 * fns.c (internal_equal): Don't assume size_t fits in int.
6834
3c616cfa
PE
6835 * alloc.c (compact_small_strings): Tighten assertion a little.
6836
c2982e87
PE
6837 Replace pEd with more-general pI, and fix some printf arg casts.
6838 * lisp.h (pI): New macro, generalizing old pEd macro to other
6839 conversion specifiers. For example, use "...%"pI"d..." rather
6840 than "...%"pEd"...".
6841 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6842 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6843 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6844 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6845 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6846 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6847 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6848 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6849 64-bit hosts.
6850 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6851 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6852 * print.c (safe_debug_print, print_object): Likewise.
6853 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6854 to int.
6f04d126
PE
6855 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6856 avoiding the 0 flag, which is not portable.
c2982e87
PE
6857 * process.c (Fmake_network_process): Use pI to avoid cast.
6858 * region-cache.c (pp_cache): Likewise.
6859 * xdisp.c (decode_mode_spec): Likewise.
6860 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6861 behavior on 64-bit hosts with printf arg.
6f04d126 6862 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6863 (x_stop_queuing_selection_requests): Likewise.
6864 (x_get_window_property): Don't truncate byte count to an 'int'
6865 when tracing.
0b432f21 6866
5e073ec7
PE
6867 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6868 here, since it parses constructs like leading '-' and spaces,
6869 which are not wanted; and it overflows with large numbers.
6870 Instead, simply match F[0-9]+, which is what is wanted anyway.
6871
36372bf9
PE
6872 * alloc.c: Remove unportable assumptions about struct layout.
6873 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6874 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6875 (allocate_vectorlike, make_pure_vector): Use the new macros,
6876 plus offsetof, to remove unportable assumptions about struct layout.
6877 These assumptions hold on all porting targets that I know of, but
6878 they are not guaranteed, they're easy to remove, and removing them
6879 makes further changes easier.
6880
0b432f21
PE
6881 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6882 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6883 (string_overrun_cookie): Now const. Use initializers that
6884 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6885 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6886 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6887 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6888 multiple of sizeof (EMACS_INT); it need not be, if
6889 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6890 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6891
895009e1
JB
68922011-04-26 Juanma Barranquero <lekktu@gmail.com>
6893
6894 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6895
6a7a1b0b
TZ
68962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6897
6898 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6899 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6900 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6901
841a1577 69022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6903
6904 * lisp.h (Qdebug): List symbol.
895009e1 6905 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6906 * keyboard.c (debug-on-event): New variable.
6907 (handle_user_signal): Break into debugger when debug-on-event
6908 matches the current signal symbol.
6909
f2d3ba6f
DN
69102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6911
6912 * alloc.c (check_sblock, check_string_bytes)
6913 (check_string_free_list): Convert to standard C.
6914
42ce4c63
TZ
69152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6916
6917 * w32.c (emacs_gnutls_push): Fix typo.
6918
825cd63c
EZ
69192011-04-25 Eli Zaretskii <eliz@gnu.org>
6920
fb11d64d
EZ
6921 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6922 "cast to pointer from integer of different size".
6923
825cd63c
EZ
6924 Improve doprnt and its use in verror. (Bug#8545)
6925 * doprnt.c (doprnt): Document the set of format control sequences
6926 supported by the function. Use SAFE_ALLOCA instead of always
6927 using `alloca'.
6928
6929 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6930 is one byte too soon. Don't use xrealloc; instead xfree and
6931 xmalloc anew.
6932
e061a11b
TZ
69332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6934
6935 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6936 callbacks stage.
6937
6938 * gnutls.c: Renamed global_initialized to
6939 gnutls_global_initialized. Added internals for the
6940 :verify-hostname-error, :verify-error, and :verify-flags
6941 parameters of `gnutls-boot' and documented those parameters in the
6942 docstring. Start callback support.
9173deec
JB
6943 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6944 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6945 on error. Return error code.
e061a11b
TZ
6946 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6947 (emacs_gnutls_read): Likewise.
6948 (Fgnutls_boot): Return handshake error code.
6949 (emacs_gnutls_handle_error): New function.
6950 (wsaerror_to_errno): Likewise.
6951
6952 * w32.h (emacs_gnutls_pull): Add prototype.
6953 (emacs_gnutls_push): Likewise.
6954
6955 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6956 (emacs_gnutls_push): Likewise.
6957
69582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6959
6960 * process.c (wait_reading_process_output): Check if GnuTLS
6961 buffered some data internally if no FDs are set for TLS
6962 connections.
6963
6964 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6965 (LIBS): Link to USER_LIBS.
6966 ($(BLD)/gnutls.$(0)): New target.
6967
fa6996bc
EZ
69682011-04-24 Eli Zaretskii <eliz@gnu.org>
6969
eb35682e
EZ
6970 * xdisp.c (handle_single_display_spec): Rename the
6971 display_replaced_before_p argument into display_replaced_p, to
6972 make it consistent with the commentary. Fix typos in the
6973 commentary.
6974
e2ad650c
EZ
6975 * textprop.c (syms_of_textprop): Remove dead code.
6976 (copy_text_properties): Delete obsolete commentary about an
6977 interface that was deleted long ago. Fix typos in the description
6978 of arguments.
6979
1b2de274
EZ
6980 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6981 to changes in oldXMenu/XMenu.h from 2011-04-16.
6982 <menu_help_message, prev_menu_help_message>: Constify.
6983 (IT_menu_make_room): menu->help_text is now `const char **';
6984 adjust.
6985
6986 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6987 to changes in oldXMenu/XMenu.h from 2011-04-16.
6988 (struct XMenu): Declare `help_text' `const char **'.
6989
6990 * xfaces.c <Qunspecified>: Make extern again.
6991
6992 * syntax.c: Include sys/types.h before including regex.h, as
6993 required by Posix.
6994
762b15be
EZ
6995 * doc.c (get_doc_string): Improve the format passed to `error'.
6996
6997 * doprnt.c (doprnt): Improve commentary.
6998
6999 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7000
7001 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7002 them with etags.
7003
f1052e5d
EZ
7004 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7005 changes in globals.h immediately force recompilation.
762b15be
EZ
7006 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7007 $(CURDIR)/s/ms-w32.h.
7008 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7009
fa6996bc
EZ
7010 * character.c (Fchar_direction): Function deleted.
7011 (syms_of_character): Don't defsubr it.
7012 <char-direction-table>: Deleted.
7013
e6c3da20
EZ
70142011-04-23 Eli Zaretskii <eliz@gnu.org>
7015
7016 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7017 * doprnt.c: Include limits.h.
7018 (SIZE_MAX): New macro.
04f2d78b
CB
7019 (doprnt): Return a size_t value. 2nd arg is now size_t.
7020 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7021 Improve overflow protection. Support `l' modifier for integer
7022 conversions. Support %l conversion. Don't assume an EMACS_INT
7023 argument for integer conversions and for %c.
7024
7025 * lisp.h (doprnt): Restore prototype.
7026
7027 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7028 $(SRC)/character.h.
7029
7030 * Makefile.in (base_obj): Add back doprnt.o.
7031
7032 * deps.mk (doprnt.o): Add back prerequisites.
7033 (callint.o): Depend on character.h.
7034
7035 * eval.c (internal_lisp_condition_case): Include the handler
7036 representation in the error message.
7037 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7038 when breaking from the loop.
7039
7040 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7041
7042 * callint.c (Fcall_interactively): When displaying error message
7043 about invalid control letter, pass the character's codepoint, not
7044 a pointer to its multibyte form. Improve display of the character
7045 in octal and display also its hex code.
7046
7047 * character.c (char_string): Use %x to display the (unsigned)
7048 codepoint of an invalid character, to avoid displaying a bogus
7049 negative value.
7050
7051 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7052 `error', not SYMBOL_NAME itself.
7053
7054 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7055 character arguments to `error'.
7056
7057 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7058 to `error' in error message about FINAL_CHAR argument. Make sure
7059 FINAL_CHAR is a character, and use %c when it is passed as
7060 argument to `error'.
7061
4ffd0d6b 70622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7063
7064 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7065
7066 * w32.c: Include <time.h>.
7067 (sys_localtime): New function.
7068
4ffd0d6b 70692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7070
7071 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7072
4ffd0d6b 7073 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7074
4ffd0d6b 70752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7076
4ffd0d6b
GM
7077 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7078 zombies (Bug#8467).
aac0c6e3 7079
04c56954
EZ
70802011-04-19 Eli Zaretskii <eliz@gnu.org>
7081
7082 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7083 gl_state.e_property when gl_state.object is Qt.
7084
7085 * insdel.c (make_gap_larger): Remove limitation of buffer size
7086 to <= INT_MAX.
7087
16a43933
CY
70882011-04-18 Chong Yidong <cyd@stupidchicken.com>
7089
7090 * xdisp.c (lookup_glyphless_char_display)
7091 (produce_glyphless_glyph): Handle cons cell entry in
7092 glyphless-char-display.
7093 (Vglyphless_char_display): Document it.
7094
7095 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7096 glyphless-char-display.
7097
4581706e
CY
70982011-04-17 Chong Yidong <cyd@stupidchicken.com>
7099
7100 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7101
7102 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7103
7104 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7105 definition for no-X builds.
7106
4887c6e2 71072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7108
fd35b6f9
PE
7109 Static checks with GCC 4.6.0 and non-default toolkits.
7110
5c1ccb01
PE
7111 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7112
006c5daa
PE
7113 * process.c (keyboard_bit_set): Define only if SIGIO.
7114 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7115 (send_process): Repair possible setjmp clobbering.
7116
efc736d3
PE
7117 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7118
4e2fe2e6
PE
7119 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7120
f97334a2
PE
7121 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7122
4e75f29d
PE
7123 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7124 Define only if needed.
7125
90efadd1
PE
7126 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7127 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7128 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7129
3c647824
PE
7130 * dispextern.h (struct redisplay_interface): Rename param
7131 to avoid shadowing.
e264f262 7132 * termhooks.h (struct terminal): Likewise.
761383f4 7133 * xterm.c (xembed_send_message): Likewise.
3c647824 7134
b58c5c4a
PE
7135 * insdel.c (make_gap_smaller): Define only if
7136 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7137
cad59032
PE
7138 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7139 it.
7140
c339dc2e
PE
7141 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7142 so that we aren't warned about unused symbols.
7143
91a3e27b
PE
7144 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7145
399c71d3 7146 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7147
8ffc96f5
PE
7148 * xfns.c (x_real_positions): Mark locals as initialized.
7149
eef9bc79
PE
7150 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7151
098db9dd
PE
7152 * xterm.c: Fix problems found by static analysis with other toolkits.
7153 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7154 (x_dispatch_event): Declare static if USE_GTK, and
7155 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7156 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7157 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7158 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7159 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7160
eb18f6cc
PE
7161 * xmenu.c (menu_help_callback): Pointer type fixes.
7162 Use const pointers when pointing at readonly data. Avoid pointer
7163 signedness clashes.
7164 (FALSE): Remove unused macro.
7165 (update_frame_menubar): Remove unused decl.
7166
1fe72bf8
PE
7167 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7168
60d9e1db
PE
7169 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7170 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7171 (single_menu_item): Rename local to avoid shadowing.
7172
39261c26
PE
7173 * keyboard.c (make_lispy_event): Remove unused local var.
7174
018c5e19
PE
7175 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7176 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7177
63d2b86e
PE
7178 * bitmaps: Change bitmaps from unsigned char back to the X11
7179 compatible char. Avoid the old compiler warnings about
7180 out-of-range initializers by using, for example, '\xab' rather
7181 than 0xab.
7182
aefd87e1
PE
7183 * xgselect.c (xgselect_initialize): Check vs interface
7184 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7185
bf501fb9
PE
7186 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7187
e9829fdf
PE
7188 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7189 to read-only memory.
7190
1086c095
PE
7191 * fns.c (vector): Remove; this old hack is no longer needed.
7192
2baccd04 7193 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7194 Remove unused var.
dde42981 7195 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7196
72391843 7197 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7198
436c16df 7199 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7200 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7201 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7202
92bb796d 7203 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7204 (x_term_init): Remove local to avoid shadowing.
92bb796d 7205
764430a3 7206 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7207
7208 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7209 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7210
d1dfb56c
EZ
72112011-04-16 Eli Zaretskii <eliz@gnu.org>
7212
c4354cb4
EZ
7213 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7214
d1dfb56c
EZ
7215 Fix regex.c, syntax.c and friends for buffers > 2GB.
7216 * syntax.h (struct gl_state_s): Declare character position members
7217 EMACS_INT.
7218
7219 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7220
04f2d78b
CB
7221 * textprop.c (verify_interval_modification, interval_of):
7222 Declare arguments EMACS_INT.
d1dfb56c
EZ
7223
7224 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7225 EMACS_INT.
7226
7227 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7228
7229 * indent.c (Fvertical_motion): Local variable it_start is now
7230 EMACS_INT.
7231
7232 * regex.c (re_match, re_match_2, re_match_2_internal)
7233 (bcmp_translate, regcomp, regexec, print_double_string)
7234 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7235 (re_compile_pattern, re_exec): Declare arguments and local
7236 variables `size_t' and `ssize_t' and return values `regoff_t', as
7237 appropriate.
7238 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7239 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7240 <compile_stack_type>: `size' and `avail' are now `size_t'.
7241
7242 * regex.h <regoff_t>: Use ssize_t, not int.
7243 (re_search, re_search_2, re_match, re_match_2): Arguments that
7244 specify buffer/string position and length are now ssize_t and
7245 size_t. Return type is regoff_t.
7246
613052cd
BK
72472011-04-16 Ben Key <bkey76@gmail.com>
7248
7249 * nsfont.m: Fixed bugs in ns_get_family and
7250 ns_descriptor_to_entity that were caused by using free to
7251 deallocate memory blocks that were allocated by xmalloc (via
7252 xstrdup). This caused Emacs to crash when compiled with
7253 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7254 --enable-checking=xmallocoverrun). xfree is now used to
7255 deallocate these memory blocks.
7256
4170f62f 72572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7258
71b41406
PE
7259 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7260
9587a89d
PE
7261 emacs_write: Accept and return EMACS_INT for sizes.
7262 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7263 et seq.
7264 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7265 Accept and return EMACS_INT.
7266 (emacs_gnutls_write): Return the number of bytes written on
7267 partial writes.
7268 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7269 (emacs_read, emacs_write): Remove check for negative size, as the
7270 Emacs source code has been audited now.
9587a89d
PE
7271 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7272 (emacs_read, emacs_write): Use it.
273a5f82
PE
7273 * process.c (send_process): Adjust to the new signatures of
7274 emacs_write and emacs_gnutls_write. Do not attempt to store
7275 a byte offset into an 'int'; it might overflow.
9587a89d 7276 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7277
3e047f51
PE
7278 * sound.c: Don't assume sizes fit in 'int'.
7279 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7280 Return EMACS_INT, not int.
3e047f51 7281 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7282 Accept EMACS_INT, not int.
7283 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7284 record read return values.
7285
cc39a9db
BK
72862011-04-15 Ben Key <bkey76@gmail.com>
7287
c9d0ec6d
JB
7288 * keyboard.c (Qundefined): Don't declare static since it is used
7289 in nsfns.m.
7290 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7291 static since they are used in nsfont.m.
cc39a9db 7292
6c60eb9f
SM
72932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7294
7295 * process.c (Qprocessp): Don't declare static.
7296 * lisp.h (Qprocessp): Declare again.
7297
7990b61a
JB
72982011-04-15 Juanma Barranquero <lekktu@gmail.com>
7299
7300 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7301
5d4cb038
PE
73022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7303
8bd7b830 7304 Improve C-level modularity by making more things 'static'.
cd64ea1d 7305
e3b27b31
PE
7306 Don't publish debugger-only interfaces to other modules.
7307 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7308 (verify_bytepos, count_markers): Move decls to the only modules
7309 that need them.
7310 * region-cache.h (pp_cache): Likewise.
7311 * window.h (check_all_windows): Likewise.
7312 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7313
5d4cb038
PE
7314 * sysdep.c (croak): Now static, if
7315 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7316 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7317
7318 * alloc.c (refill_memory_reserve): Now static if
7319 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7320 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7321
e87b6180
PE
7322 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7323 Define only if USE_LUCID.
7324
ac64929e
PE
7325 * xrdb.c (x_customization_string, x_rm_string): Now static.
7326
6f37259d
PE
7327 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7328 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7329
1683e3ab
PE
7330 * xdisp.c (draw_row_with_mouse_face): Now static.
7331 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7332
de9c2632
PE
7333 * window.h (check_all_windows): Mark externally visible.
7334
2b96acb7
PE
7335 * window.c (window_deletion_count): Now static.
7336
7337 * undo.c: Make symbols static if they're not exported.
7338 (last_undo_buffer, last_boundary_position, pending_boundary):
7339 Now static.
7340
50436f33
PE
7341 * textprop.c (interval_insert_behind_hooks): Now static.
7342 (interval_insert_in_front_hooks): Likewise.
7343
64520e5c
PE
7344 * term.c: Make symbols static if they're not exported.
7345 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7346 (max_frame_lines, tty_set_terminal_modes):
7347 (tty_reset_terminal_modes, tty_turn_off_highlight):
7348 (get_tty_terminal): Now static.
7349 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7350 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7351 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7352 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7353 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7354
1fa53021
PE
7355 * sysdep.c: Make symbols static if they're not exported.
7356 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7357 Now static.
7358 (sigprocmask_set, full_mask): Remove; unused.
7359 (wait_debugging): Mark as visible.
7360 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7361 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7362
d4b43b22
PE
7363 * syntax.c (syntax_temp): Define only if !__GNUC__.
7364
b7c513d0
PE
7365 * sound.c (current_sound_device, current_sound): Now static.
7366
989b29ad
PE
7367 * search.c (searchbufs, searchbuf_head): Now static.
7368
13a55a78
PE
7369 * scroll.c (scroll_cost): Remove; unused.
7370 * dispextern.h (scroll_cost): Remove decl.
7371
de68a1fc
PE
7372 * region-cache.h (pp_cache): Mark as externally visible.
7373
40ccffa6
PE
7374 * process.c: Make symbols static if they're not exported.
7375 (process_tick, update_tick, create_process, chan_process):
7376 (Vprocess_alist, proc_buffered_char, datagram_access):
7377 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7378 (deactivate_process): Mark defn as static, as well as decl.
7379 * lisp.h (create_process): Remove decl.
7380 * process.h (chan_process, Vprocess_alist): Remove decls.
7381
ad64fc97
PE
7382 * print.c: Make symbols static if they're not exported.
7383 (print_depth, new_backquote_output, being_printed, print_buffer):
7384 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7385 (print_interval, print_number_index, initial_stderr_stream):
7386 Now static.
7387 * lisp.h (Fprinc): Remove decl.
7388 (debug_output_compilation_hack): Mark as externally visible.
7389
adddb265
PE
7390 * sysdep.c (croak): Move decl from here to syssignal.h.
7391 * syssignal.h (croak): Put it here, so the API can be checked when
7392 'croak' is called from dissociate_if_controlling_tty.
7393
1717ede2
PE
7394 * minibuf.c: Make symbols static if they're not exported.
7395 (minibuf_save_list, choose_minibuf_frame): Now static.
7396 * lisp.h (choose_minibuf_frame): Remove decl.
7397
fa5fb2bc
PE
7398 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7399
1e3890d1
PE
7400 * lread.c: Make symbols static if they're not exported.
7401 (read_objects, initial_obarray, oblookup_last_bucket_number):
7402 Now static.
7403 (make_symbol): Remove; unused.
7404 * lisp.h (initial_obarray, make_symbol): Remove decls.
7405
8a1414fa
PE
7406 * keyboard.c: Make symbols static if they're not exported.
7407 (single_kboard, recent_keys_index, total_keys, recent_keys):
7408 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7409 (this_single_command_key_start, echoing, last_auto_save):
7410 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7411 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7412 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7413 (Vlispy_mouse_stem, double_click_count):
7414 Now static.
7415 (force_auto_save_soon): Define only if SIGDANGER.
7416 (ignore_mouse_drag_p): Now static if
7417 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7418 (print_help): Remove; unused.
7419 (stop_character, last_timer_event): Mark as externally visible.
7420 * keyboard.h (ignore_mouse_drag_p): Declare only if
7421 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7422 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7423 * lisp.h (echoing): Remove decl.
7424 (force_auto_save_soon): Declare only if SIGDANGER.
7425 * xdisp.c (redisplay_window): Simplify code, to make it more
7426 obvious that ignore_mouse_drag_p is not accessed if !defined
7427 USE_GTK && !defined HAVE_NS.
7428
93ea6e8f
PE
7429 * intervals.c: Make symbols static if they're not exported.
7430 (merge_properties_sticky, merge_interval_right, delete_interval):
7431 Now static.
7432 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7433
77382fcc
PE
7434 * insdel.c: Make symbols static if they're not exported.
7435 However, leave prepare_to_modify_buffer alone. It's never
7436 called from outside this function, but that appears to be a bug.
7437 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7438 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7439 (adjust_after_replace_noundo): Remove; unused.
7440 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7441 (signal_before_change): Remove decls.
77382fcc 7442
9306c32e
PE
7443 * indent.c (val_compute_motion, val_vmotion): Now static.
7444
cd44d2eb
PE
7445 * image.c: Make symbols static if they're not exported.
7446 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7447 if USE_GTK.
7448 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7449 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7450
ad9a7a06
PE
7451 * fringe.c (standard_bitmaps): Now static.
7452 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7453
81626931
PE
7454 * frame.c: Make symbols static if they're not exported.
7455 (x_report_frame_params, make_terminal_frame): Now static.
7456 (get_frame_param): Now static, unless HAVE_NS.
7457 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7458 (x_get_resource_string): Remove; not used.
7459 * frame.h (make_terminal_frame, x_report_frame_params):
7460 (x_get_resource_string); Remove decls.
7461 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7462 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7463
239f9db9
PE
7464 * font.c, fontset.c: Make symbols static if they're not exported.
7465 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7466 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7467 * font.c (font_close_object): Now static.
7468 * font.h (font_close_object): Remove.
7469 * fontset.c (FONTSET_OBJLIST): Remove.
7470 (free_realized_fontset) #if-0 the body, which does nothing.
7471 (face_suitable_for_char_p): #if-0, as it's never called.
7472 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7473 * xfaces.c (face_at_string_position):
7474 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7475 since 0 is always ASCII.
7476
dfcf3579
PE
7477 * fns.c (weak_hash_tables): Now static.
7478
5045092b
PE
7479 * fileio.c: Make symbols static if they're not exported.
7480 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7481 (Vwrite_region_annotation_buffers): Now static.
7482
57a96f5c
PE
7483 * eval.c: Make symbols static if they're not exported.
7484 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7485 * lisp.h (backtrace_list): Remove decl.
7486
35f08c38
PE
7487 * emacs.c: Make symbols static if they're not exported.
7488 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7489 (fatal_error_code, fatal_error_signal_hook, standard_args):
7490 Now static.
7491 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7492 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7493 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7494 * lisp.h (fatal_error_signal_hook): Remove decl.
7495 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7496
f44bd759
PE
7497 * editfns.c: Move a (normally-unused) function to its only use.
7498 * editfns.c, lisp.h (get_operating_system_release): Remove.
7499 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7500 worth the hassle of breaking this out.
7501
b532497d
PE
7502 * xterm.c: Make symbols static if they're not exported.
7503 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7504 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7505 (x_destroy_window, x_delete_display):
7506 Now static.
7507 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7508 (x_mouse_leave): Remove; unused.
7509 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7510 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7511 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7512 Remove decls.
7513 (x_mouse_leave): Declare only if WINDOWSNT.
7514 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7515 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7516 USE_X_TOOLKIT.
7517
1675728f
PE
7518 * ftxfont.c: Make symbols static if they're not exported.
7519 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7520 HAVE_FREETYPE.
7521 * font.h (ftxfont_driver): Likewise.
7522
e4cebfca
PE
7523 * xfns.c: Make symbols static if they're not exported.
7524 (x_last_font_name, x_display_info_for_name):
7525 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7526 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7527 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7528 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7529 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7530 (last_show_tip_args): Now static.
7531 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7532 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7533 (x_screen_planes): Remove; unused.
7534 * dispextern.h (x_screen_planes): Remove decl.
7535
5bf46f05
PE
7536 * dispnew.c: Make symbols static if they're not exported.
7537 * dispextern.h (redraw_garbaged_frames, scrolling):
7538 (increment_row_positions): Remove.
7539 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7540 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7541 Now static.
7542 (redraw_garbaged_frames): Remove; unused.
7543
435f4c28
PE
7544 * xfaces.c: Make symbols static if they're not exported.
7545 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7546 Remove decls.
7547 * xterm.h (defined_color): Remove decls.
7548 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7549 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7550 (menu_face_changed_default, defined_color, free_realized_face):
7551 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7552 (ascii_face_of_lisp_face): Remove; unused.
7553
8524aef3
PE
7554 * xdisp.c: Make symbols static if they're not exported.
7555 * dispextern.h (scratch_glyph_row, window_box_edges):
7556 (glyph_to_pixel_coords, set_cursor_from_row):
7557 (get_next_display_element, set_iterator_to_next):
7558 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7559 (show_mouse_face): Remove decls
7560 * frame.h (message_buf_print): Likewise.
7561 * lisp.h (pop_message, set_message, check_point_in_composition):
7562 Likewise.
7563 * xterm.h (set_vertical_scroll_bar): Likewise.
7564 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7565 (message_buf_print, scratch_glyph_row, displayed_buffer):
7566 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7567 (get_next_display_element, show_mouse_face, window_box_edges):
7568 (frame_to_window_pixel_xy, check_point_in_composition):
7569 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7570 (glyph_to_pixel_coords): Remove; unused.
7571
16390cd2
PE
7572 * dired.c (file_name_completion): Now static.
7573
7574 * dbusbind.c (xd_in_read_queued_messages): Now static.
7575
a25f4dfa
PE
7576 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7577 * data.c (circular_list_error): Remove.
7578
14a9c8df
PE
7579 * commands.h (last_point_position, last_point_position_buffer):
7580 (last_point_position_window): Remove decls.
7581 * keyboard.c: Make these variables static.
7582
04f2d78b
CB
7583 * coding.h (coding, code_convert_region, encode_coding_gap):
7584 Remove decls.
74ab6df5
PE
7585 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7586 (iso_code_class, detect_coding, code_convert_region): Now static.
7587 (encode_coding_gap): Remove; unused.
7588
38dfbee1
PE
7589 * chartab.c (chartab_chars, chartab_bits): Now static.
7590
a2cb4e63
PE
7591 * charset.h (charset_iso_8859_1): Remove decl.
7592 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7593 Now static.
7594
127198fd
PE
7595 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7596 * ccl.c (Vccl_program_table): Now static.
7597 (check_ccl_update): Remove; unused.
7598
d85b608f
PE
7599 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7600 * category.h: ... from here.
7601 * category.c (check_category_table, set_category_set): Now static.
7602
31cd66f3
PE
7603 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7604 * lisp.h: Remove these decls.
7605
c358e587
PE
7606 * buffer.c (buffer_count): Remove unused var.
7607
e78aecca
PE
7608 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7609 so that it's not optimized away.
7610 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7611 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7612 exported only to the debugger.
7613
e192d7d3 7614 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7615 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7616
92470028
PE
7617 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7618 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7619 was inaccessible from Lisp.
7620 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7621 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7622
244ed907
PE
7623 alloc.c: Import and export fewer symbols, and remove unused items.
7624 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7625 is defined.
7626 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7627 it's not optimized away by whole-program optimization.
7628 (message_enable_multibyte, free_misc): Remove.
7629 (catchlist, handlerlist, mark_backtrace):
7630 Declare only if BYTE_MARK_STACK.
7631 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7632 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7633 (message_enable_multibyte): Remove decl.
7634 (free_misc, interval_free_list, float_block, float_block_index):
7635 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7636 (cons_free_list, last_marked_index):
7637 Now static.
7638 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7639 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7640 (mark_backtrace): Define only if BYTE_MARK_STACK.
7641 * xdisp.c (message_enable_multibyte): Now static.
7642
61c2b50e 7643 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7644 This makes it easier for human readers (and static analyzers)
7645 to see whether these variables are used from other modules.
7646 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7647 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7648 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7649 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7650 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7651 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7652 * xmenu.c, xselect.c:
7653 Declare Q* vars static if they are not used in other modules.
7654 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7655 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7656 Remove decls of unexported vars.
7657 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7658
95c82688
PE
7659 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7660
16a97296
PE
7661 Make Emacs functions such as Fatom 'static' by default.
7662 This makes it easier for human readers (and static analyzers)
7663 to see whether these functions can be called from other modules.
7664 DEFUN now defines a static function. To make the function external
7665 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7666 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7667 (Finit_image_library):
16a97296
PE
7668 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7669 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7670 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7671 Remove decls, since these functions are now static.
7672 (Funintern, Fget_internal_run_time): New decls, since these functions
7673 were already external.
95c82688 7674
16a97296
PE
7675 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7676 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7677 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7678 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7679 * keyboard.c, keymap.c, lread.c:
7680 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7681 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7682 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7683 Mark functions with DEFUE instead of DEFUN,
7684 if they are used in other modules.
7685 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7686 decls for now-static functions.
7687 * buffer.h (Fdelete_overlay): Remove decl.
7688 * callproc.c (Fgetenv_internal): Mark as internal.
7689 * composite.c (Fremove_list_of_text_properties): Remove decl.
7690 (Fcomposition_get_gstring): New forward static decl.
7691 * composite.h (Fcomposite_get_gstring): Remove decl.
7692 * dired.c (Ffile_attributes): New forward static decl.
7693 * doc.c (Fdocumntation_property): New forward static decl.
7694 * eval.c (Ffetch_bytecode): New forward static decl.
7695 (Funintern): Remove extern decl; now in .h file where it belongs.
7696 * fileio.c (Fmake_symbolic_link): New forward static decl.
7697 * image.c (Finit_image_library): New forward static decl.
7698 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7699 * intervals.h (Fprevious_property_change):
7700 (Fremove_list_of_text_properties): Remove decls.
7701 * keyboard.c (Fthis_command_keys): Remove decl.
7702 (Fcommand_execute): New forward static decl.
7703 * keymap.c (Flookup_key): New forward static decl.
7704 (Fcopy_keymap): Now static.
7705 * keymap.h (Flookup_key): Remove decl.
7706 * process.c (Fget_process): New forward static decl.
7707 (Fprocess_datagram_address): Mark as internal.
7708 * syntax.c (Fsyntax_table_p): New forward static decl.
7709 (skip_chars): Remove duplicate decl.
7710 * textprop.c (Fprevious_property_change): New forward static decl.
7711 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7712 Now internal.
7713 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7714 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7715
785bbd42
PE
7716 * editfns.c (Fformat): Remove unreachable code.
7717
8b913b57
AS
77182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7719
7720 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7721 change. (Bug#8496)
7722
a6744a35
EZ
77232011-04-13 Eli Zaretskii <eliz@gnu.org>
7724
7725 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7726 when at ZV. (Bug#8487)
7727
e7974947
AS
77282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7729
baad03f0
AS
7730 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7731 (Bug#8437)
7732 * keyboard.c (parse_tool_bar_item): Likewise.
7733 * sound.c (sound_cleanup, alsa_close): Likewise.
7734 * termcap.c (tgetent): Likewise.
7735 * xfns.c (x_default_font_parameter): Likewise.
7736 * xsettings.c (read_and_apply_settings): Likewise.
7737
e7974947
AS
7738 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7739 (overrun_check_free): Protoize.
7740
28272684
PE
77412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7742
7743 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7744 since callers should never pass a negative size.
7745 Change the signature to match that of plain 'read' and 'write'; see
7746 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7747 * lisp.h: Update prototypes of emacs_write and emacs_read.
7748
11997c76
EZ
77492011-04-11 Eli Zaretskii <eliz@gnu.org>
7750
7751 * xdisp.c (redisplay_window): Don't try to determine the character
7752 position of the scroll margin if the window start point w->startp
e896f03c 7753 is outside the buffer's accessible region. (Bug#8468)
11997c76 7754
8a2cbd72
EZ
77552011-04-10 Eli Zaretskii <eliz@gnu.org>
7756
7757 Fix write-region and its subroutines for buffers > 2GB.
7758 * fileio.c (a_write, e_write): Modify declaration of arguments and
7759 local variables to support buffers larger than 2GB.
7760 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7761
7762 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7763 argument, local variables, and return value.
7764
7765 * lisp.h: Update prototypes of emacs_write and emacs_read.
7766
7767 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7768
4073e537 77692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7770
1ebfdcb6
PE
7771 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7772
b2ded58d
PE
7773 Fix more problems found by GCC 4.6.0's static checks.
7774
7d66342c
PE
7775 * xdisp.c (vmessage): Use a better test for character truncation.
7776
bbf47d44
PE
7777 * charset.c (load_charset_map): <, not <=, for optimization,
7778 and to avoid potential problems with integer overflow.
9248994d 7779 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7780 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7781 * editfns.c (Fformat): Likewise.
1e69125e 7782 * syntax.c (skip_chars): Likewise.
3befa583 7783
e3019616
PE
7784 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7785 This also lets GCC 4.6.0 generate slightly better loop code.
7786
becfa255
PE
7787 * callint.c (Fcall_interactively): <, not <=, for optimization.
7788 (Fcall_interactively): Count the number of arguments produced,
7789 not the number of arguments given. This is simpler and lets GCC
7790 4.6.0 generate slightly better code.
7791
dae0cd48
PE
7792 * ftfont.c: Distingish more carefully between FcChar8 and char.
7793 The previous code passed unsigned char * to a functions like
7794 strlen and xstrcasecmp that expect char *, which does not
7795 conform to the C standard.
7796 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7797 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7798 char * when the C standard requires it.
7799
76032d70
PE
7800 * keyboard.c (read_char): Remove unused var.
7801
eb3f1cc8
PE
7802 * eval.c: Port to Windows vsnprintf (Bug#8435).
7803 Include <limits.h>.
7804 (SIZE_MAX): Define if the headers do not.
7805 (verror): Do not give up if vsnprintf returns a negative count.
7806 Instead, grow the buffer. This ports to Windows vsnprintf, which
7807 does not conform to C99. Problem reported by Eli Zaretskii.
7808 Also, simplify the allocation scheme, by avoiding the need for
7809 calling realloc, and removing the ALLOCATED variable.
7810
70476b54
PE
7811 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7812
12020a9e
PE
7813 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7814 But keep the doprint source code for now, as we might revamp it
7815 and use it again (Bug#8435).
ea6c7ae6
PE
7816 * lisp.h (doprnt): Remove.
7817 * Makefile.in (base_obj): Remove doprnt.o.
7818 * deps.mk (doprnt.o): Remove.
7819
5fdb398c
PE
7820 error: Print 32- and 64-bit integers portably (Bug#8435).
7821 Without this change, on typical 64-bit hosts error ("...%d...", N)
7822 was used to print both 32- and 64-bit integers N, which relied on
7823 undefined behavior.
61bdb816 7824 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7825 * lisp.h (error, verror): Mark as printf-like functions.
7826 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7827 Report overflow in size calculations when allocating printf buffer.
7828 Do not truncate output string at its first null byte.
7829 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7830 Truncate the output at a character boundary, since vsnprintf does not
7831 do that.
7832 * charset.c (check_iso_charset_parameter): Convert internal
7833 character to string before calling 'error', since %c now has the
7834 printf meaning.
7835 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7836 overflow when computing char to be passed to 'error'. Do not
7837 pass Lisp_Object to 'error'; pass the integer instead.
7838 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7839 formatted with plain %d.
7840
b189fa66
PE
7841 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7842
bff87ef0
PE
7843 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7844
7e2cac20
PE
7845 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7846
ce4d90b5
PE
7847 * xterm.c (x_catch_errors): Remove duplicate declaration.
7848
266c9547
PE
7849 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7850
79c49ad2
PE
7851 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7852
368f4090
JM
78532011-04-10 Jim Meyering <meyering@redhat.com>
7854
7855 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7856 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7857 return ssize_t not "int", and use size_t as the buffer length.
7858 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7859 * gnutls.h: Update declarations.
7860 * process.c (read_process_output): Use ssize_t, to match.
7861 (send_process): Likewise.
7862
a32d4040
CY
78632011-04-09 Chong Yidong <cyd@stupidchicken.com>
7864
7865 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7866
8546720e 78672011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7868
04f2d78b
CB
7869 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7870 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7871
8546720e
GM
7872 * xterm.c (handle_one_xevent):
7873 * xmenu.c (create_and_show_popup_menu):
7874 * xselect.c (x_decline_selection_request)
7875 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7876
0a2f5c1a 78772011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7878
7879 Fix some uses of `int' instead of EMACS_INT.
7880 * search.c (string_match_1, fast_string_match)
7881 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7882 (scan_buffer, find_next_newline_no_quit)
7883 (find_before_next_newline, search_command, Freplace_match)
7884 (Fmatch_data): Make some `int' variables be EMACS_INT.
7885
7886 * xdisp.c (display_count_lines): 3rd argument and return value now
7887 EMACS_INT. All callers changed.
7888 (pint2hrstr): Last argument is now EMACS_INT.
7889
7890 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7891 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7892 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7893 (decode_coding_utf_16, decode_coding_emacs_mule)
7894 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7895 (decode_coding_ccl, decode_coding_charset)
7896 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7897 (decode_coding_iso_2022, decode_coding_emacs_mule)
7898 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7899 <char_offset, last_offset>: Declare EMACS_INT.
7900 (encode_coding_utf_8, encode_coding_utf_16)
7901 (encode_coding_emacs_mule, encode_invocation_designation)
7902 (encode_designation_at_bol, encode_coding_iso_2022)
7903 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7904 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7905 Declare EMACS_INT.
7906 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7907 (encode_invocation_designation): Last argument P_NCHARS is now
7908 EMACS_INT.
7909 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7910 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7911
7912 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7913 All users changed.
7914
7915 * ccl.c (Fccl_execute_on_string): Declare some variables
7916 EMACS_INT.
7917
8546720e 79182011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7919
7920 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7921
4e19a977
CS
79222011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7923
7924 * process.c (Fformat_network_address): Doc fix.
7925
87302331
R
79262011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7927
ee7683eb 7928 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7929
cbb59342
CY
79302011-04-08 Chong Yidong <cyd@stupidchicken.com>
7931
7932 * keyboard.c (read_char): Call Lisp function help-form-show,
7933 instead of using internal_with_output_to_temp_buffer.
7934 (Qhelp_form_show): New var.
e0d38eeb 7935 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7936
7937 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7938
7939 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7940
e67a13ab
CY
79412011-04-06 Chong Yidong <cyd@stupidchicken.com>
7942
04f2d78b
CB
7943 * process.c (Flist_processes): Remove to Lisp.
7944 (list_processes_1): Delete.
e67a13ab 7945
973f782d
EZ
79462011-04-06 Eli Zaretskii <eliz@gnu.org>
7947
7c106b1e
EZ
7948 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7949
973f782d
EZ
7950 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7951
41cf7d1a 79522011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7953
ca23cc88
PE
7954 Fix more problems found by GCC 4.6.0's static checks.
7955
f390e2d5
PE
7956 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7957
42eea0d0
PE
7958 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7959
b69769da 7960 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7961
f9541e84
PE
7962 * xdisp.c (vmessage): Mark as a printf-like function.
7963
13841b55
PE
7964 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7965
c136c10f
PE
7966 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7967
5e2d4a30
PE
7968 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7969 printf-like functions.
7970 (tiff_load): Add casts to remove these marks before passing them
7971 to system-supplied API.
7972
583f48b9
PE
7973 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7974
b25d760e
PE
7975 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7976 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7977 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7978 directly, rather than having caller test rule sign. This avoids
7979 some unnecessary tests.
7980 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7981 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7982 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7983
bc7b6697 7984 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7985 (xfont_open): Avoid unnecessary tests.
bc7b6697 7986
27ccc379
PE
7987 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7988
dcd5c89a
PE
7989 * composite.h, composite.c (composition_gstring_put_cache):
7990 Use EMACS_INT, not int, for length.
7991
b13a45c6
PE
7992 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7993 breaking out part of COMPOSITION_DECODE_RULE.
7994 (COMPOSITION_DECODE_RULE): Use it.
7995 * composite.c (get_composition_id): Remove unused local vars,
7996 by using the new macro.
7997
1e792e4d
PE
7998 * textprop.c (set_text_properties_1): Change while to do-while,
7999 since the condition is always true at first.
8000
dc6c6455 8001 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8002 (interval_deletion_adjustment): Return unsigned value.
8003 All uses changed.
dc6c6455 8004
aba7731a
PE
8005 * process.c (list_processes_1, create_pty, read_process_output):
8006 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8007 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8008 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8009 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8010 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8011
fdfc4bf3
PE
8012 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8013
fca8fe46 8014 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8015 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8016
06a0259a 8017 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8018 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8019 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8020
e7b9e80f
PE
8021 * print.c (print_error_message): Avoid int overflow.
8022
56201685
PE
8023 * font.c (font_list_entities): Redo for clarity,
8024 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8025
78834453 8026 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8027 (font_score): Avoid potential overflow in diff calculation.
78834453 8028
0bc0b309 8029 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8030 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8031
e610eaca
PE
8032 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8033
b895abce
PE
8034 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8035 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8036 can always succeed if overflow has undefined behavior.
8037
1f1d9321 8038 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8039 (wordify): Omit three unnecessary tests.
1f1d9321 8040
c59478bc
PE
8041 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8042 All callers changed. This avoids the need for an unused var.
8043
79b73827
PE
8044 * casefiddle.c (casify_region): Remove var that is set but not used.
8045
a4db5dfe
PE
8046 * dired.c (file_name_completion): Remove var that is set but not used.
8047
43aae36e
PE
8048 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8049
2a47c44d 8050 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8051 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8052
a37c69bf
PE
8053 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8054 Check for integer overflow on size calculations.
8055
328ab8e7
PE
8056 * buffer.c (Fprevious_overlay_change): Remove var that is set
8057 but not used.
8058
e5a2a5cb
PE
8059 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8060 Remove vars that are set but not used.
8d84a6eb 8061 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8062 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8063
a60e5f68
PE
8064 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8065
f661cb61 8066 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8067 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8068
f0397f5a
PE
8069 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8070 that are set but not used.
8071
8664db06 8072 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8073 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8074
6abdaa4a
PE
8075 * xselect.c (x_get_local_selection, x_handle_property_notify):
8076 Remove vars that are set but not used.
8077
0ce7538d 8078 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8079 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8080
9ae848fc
PE
8081 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8082 Remove var that is set but not used.
0b918413
PE
8083 (scroll_bar_windows_size): Now size_t, not int.
8084 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8085 Check for overflow.
9ae848fc 8086
a5a62657
PE
8087 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8088 (map_tty_color) [!defined MSDOS]: Likewise.
8089
5c5cdd39
PE
8090 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8091
66ebf983
PE
8092 * coding.c: Remove vars that are set but not used.
8093 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8094 All callers changed.
8095 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8096 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8097 (decode_coding_charset): Remove vars that are set but not used.
8098
1be4d761
PE
8099 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8100 that is set but not used.
8101
47553fa8
PE
8102 * print.c (print_object): Remove var that is set but not used.
8103
1f7196bf 8104 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8105 The gnulib version avoids calling malloc in the usual case,
8106 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8107 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8108 * filelock.c (current_lock_owner): Likewise.
8109 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8110 * sysdep.c: Include allocator.h, careadlinkat.h.
8111 (emacs_no_realloc_allocator): New static constant.
8112 (emacs_readlink): New function.
fdb61804
PE
8113 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8114 ../lib/careadlinkat.h.
d1fdcab7 8115
f84c17c7
SM
81162011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8117
8118 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8119 first non-nil return value).
8120
ef3862ad
JD
81212011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8122
8123 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8124 if not defined (Bug#8403).
8125
376a7006
JB
81262011-04-02 Juanma Barranquero <lekktu@gmail.com>
8127
8128 * xdisp.c (display_count_lines): Remove parameter `start',
8129 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8130 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8131 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8132 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8133 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8134 and thereabouts. All callers changed.
8135 (get_per_char_metric): Remove parameter `f', unused since
8136 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8137
6ca3801d
JM
81382011-04-02 Jim Meyering <meyering@redhat.com>
8139
8140 do not dereference NULL upon failed strdup
8141 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8142 (ns_get_family): Likewise.
8143
d8e2b5ba
JB
81442011-04-02 Juanma Barranquero <lekktu@gmail.com>
8145
8146 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8147
8c74fcbd
JD
81482011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8149
8150 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8151 later (Bug#8403).
8152
7200d79c
SM
81532011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8154
03408648 8155 Add lexical binding.
7200d79c 8156
03408648
SM
8157 * window.c (Ftemp_output_buffer_show): New fun.
8158 (Fsave_window_excursion):
8159 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8160
8161 * lread.c (lisp_file_lexically_bound_p): New function.
8162 (Fload): Bind Qlexical_binding.
8163 (readevalloop): Remove `evalfun' arg.
8164 Bind Qinternal_interpreter_environment.
8165 (Feval_buffer): Bind Qlexical_binding.
8166 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8167 Mark as dynamic.
8168 (syms_of_lread): Declare `lexical-binding'.
8169
8170 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8171
8172 * keyboard.c (eval_dyn): New fun.
8173 (menu_item_eval_property): Use it.
ca105506
SM
8174
8175 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8176
03408648
SM
8177 * fns.c (concat, mapcar1): Accept byte-code-functions.
8178
8179 * eval.c (Fsetq): Handle lexical vars.
8180 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8181 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8182 (FletX, Flet): Obey lexical binding.
8183 (Fcommandp): Handle closures.
8184 (Feval): New `lexical' arg.
8185 (eval_sub): New function extracted from Feval. Use it almost
8186 everywhere where Feval was used. Look up vars in lexical env.
8187 Handle closures.
8188 (Ffunctionp): Move from subr.el.
8189 (Ffuncall): Handle closures.
8190 (apply_lambda): Remove `eval_flags'.
8191 (funcall_lambda): Handle closures and new byte-code-functions.
8192 (Fspecial_variable_p): New function.
8193 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8194 but without exporting it to Lisp.
23aba0ea 8195
23aba0ea 8196 * doc.c (Fdocumentation, store_function_docstring):
03408648 8197 * data.c (Finteractive_form): Handle closures.
23aba0ea 8198
03408648
SM
8199 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8200 interactive spec.
ba83908c 8201
04f2d78b
CB
8202 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8203 New byte-codes.
03408648
SM
8204 (exec_byte_code): New function extracted from Fbyte_code to handle new
8205 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8206
03408648 8207 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8208
03408648 8209 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8210
e2abce01
JB
82112011-03-31 Juanma Barranquero <lekktu@gmail.com>
8212
8213 * xdisp.c (redisplay_internal): Fix prototype.
8214
63696a73 82152011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8216
63696a73 8217 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8218 (try_scrolling): Use it when setting scroll_limit.
8219 Limit scrolling to 100 screen lines.
63696a73
EZ
8220 (redisplay_window): Even when falling back on "recentering",
8221 position point in the window according to scroll-conservatively,
8222 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8223
8224 (try_scrolling): When point is above the window, allow searching
8225 as far as scroll_max, or one screenful, to compute vertical
8226 distance from PT to the scroll margin position. This prevents
8227 try_scrolling from unnecessarily failing when
8228 scroll-conservatively is set to a value slightly larger than the
8229 window height. Clean up the case of PT below the margin at bottom
8230 of window: scroll_max can no longer be INT_MAX. When aggressive
8231 scrolling is in use, don't let point enter the opposite scroll
8232 margin as result of the scroll.
8233 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8234 threshold of 100 lines for never-recentering scrolling.
8235
e4cc2dfc
JB
82362011-03-31 Juanma Barranquero <lekktu@gmail.com>
8237
8238 * dispextern.h (move_it_by_lines):
8239 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8240 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8241 (message_log_check_duplicate): Remove parameters `prev_bol' and
8242 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8243 (redisplay_internal): Remove parameter `preserve_echo_area',
8244 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8245
8246 * indent.c (Fvertical_motion):
8247 * window.c (window_scroll_pixel_based, Frecenter):
8248 Don't pass `need_y_p' to `move_it_by_lines'.
8249
1c470562
SM
82502011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8251
44f230aa
SM
8252 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8253 steal a few bits to be more compact.
8254 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8255 Remove unneeded casts.
8256
1c470562
SM
8257 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8258
888adce9
ZK
82592011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8260
8261 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8262 binding" message (bug#7967).
8263
f838ed7b
PE
82642011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8265
77861b95
PE
8266 Fix more problems found by GCC 4.6.0's static checks.
8267
de6dbc14
PE
8268 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8269 Remove unused local var.
8270
f838ed7b
PE
8271 * editfns.c (Fmessage_box): Remove unused local var.
8272
792c7b2b
PE
8273 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8274 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8275 Omit unused local vars.
c499e557 8276 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8277 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8278 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8279 Omit unused local var.
8280
ba0165e1
PE
8281 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8282 Don't assume string length fits in int.
32ad8845 8283 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8284 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8285
3c59b4c9
PE
8286 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8287 instead of alloca (Bug#8344).
8288
a3eed478 8289 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8290 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8291
eb4d412d
PE
8292 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8293
1658b401
PE
8294 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8295 concerns.
8296
8297 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8298
8299 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8300
9a2c6e05
PE
8301 * keyboard.c (syms_of_keyboard): Use the same style as later
8302 in this function when indexing through an array. This also
8303 works around GCC bug 48267.
8304
03d0a109
PE
8305 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8306
44f730c8
PE
8307 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8308
fe75f926
PE
8309 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8310 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8311
ffa8c828
PE
8312 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8313 This avoids undefined behavior on integer overflow, and is a bit
8314 more convenient anyway since it is compared to a size_t variable.
8315
c5101a77
PE
8316 Variadic C functions now count arguments with size_t, not int.
8317 This avoids an unnecessary limitation on 64-bit machines, which
8318 caused (substring ...) to crash on large vectors (Bug#8344).
8319 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8320 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8321 All variadic functions and their callers changed accordingly.
c5101a77
PE
8322 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8323 * data.c (arith_driver, float_arith_driver): Likewise.
8324 * editfns.c (general_insert_function): Likewise.
8325 * eval.c (struct backtrace.nargs, interactive_p)
8326 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8327 (funcall_lambda, mark_backtrace): Likewise.
8328 * fns.c (concat): Likewise.
8329 * frame.c (x_set_frame_parameters): Likewise.
8330 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8331 0 if not found, not -1. All callers changed.
8332
dd3f25f7
PE
8333 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8334 (stack_copy_size): Now size_t, not int.
8335 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8336
461c2ab9
JB
83372011-03-28 Juanma Barranquero <lekktu@gmail.com>
8338
8339 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8340 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8341 All callers changed.
8342
8343 * lisp.h (multibyte_char_to_unibyte):
8344 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8345 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8346 * character.h (CHAR_TO_BYTE8):
8347 * cmds.c (internal_self_insert):
8348 * editfns.c (general_insert_function):
8349 * keymap.c (push_key_description):
8350 * search.c (Freplace_match):
8351 * xdisp.c (message_dolog, set_message_1): All callers changed.
8352
f6d62986
SM
83532011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8354
8355 * keyboard.c (safe_run_hook_funcall): New function.
8356 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8357 don't set the hook to nil, but remove the offending function instead.
8358 (Qcommand_hook_internal): Remove, unused.
8359 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8360 Vcommand_hook_internal.
8361
8362 * eval.c (enum run_hooks_condition): Remove.
8363 (funcall_nil, funcall_not): New functions.
8364 (run_hook_with_args): Call each function through a `funcall' argument.
8365 Remove `cond' argument, now redundant.
8366 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8367 (Frun_hook_with_args_until_failure): Adjust accordingly.
8368 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8369
1db5b1ad
JB
83702011-03-28 Juanma Barranquero <lekktu@gmail.com>
8371
8372 * dispextern.h (string_buffer_position): Remove declaration.
8373
8374 * print.c (strout): Remove parameter `multibyte', unused since
8375 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8376
8377 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8378 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8379 All callers changed.
8380
8381 * w32.c (_wsa_errlist): Use braces for struct initializers.
8382
8383 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8384 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8385 All callers changed.
8386 (string_buffer_position): Likewise. Also, make static (it's never
8387 used outside xdisp.c).
8388 (cursor_row_p): Remove parameter `w', unused since
8389 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8390 (decode_mode_spec): Remove parameter `precision', introduced during
8391 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8392 All callers changed.
8393
5ffb62aa
JD
83942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8395
8396 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8397
461c2ab9 83982011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8399
8400 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8401 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8402 (ns_update_auto_hide_menu_bar): New functions.
8403 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8404 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8405 ns_constrain_all_frames.
8406 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8407 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8408
5c380ffb
JD
84092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8410
8411 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8412
9af30bdf
GM
84132011-03-27 Glenn Morris <rgm@gnu.org>
8414
8415 * syssignal.h: Replace RETSIGTYPE with void.
8416 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8417 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8418 Replace SIGTYPE with void everywhere.
8419 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8420 * s/template.h (SIGTYPE): Remove commented out definition.
8421
e2abce01
JB
84222011-03-26 Eli Zaretskii <eliz@gnu.org>
8423
8424 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8425 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8426
f868cd8a
JB
84272011-03-26 Juanma Barranquero <lekktu@gmail.com>
8428
59eb0929
JB
8429 * w32.c (read_unc_volume): Use parameter `henum', instead of
8430 global variable `wget_enum_handle'.
8431
8432 * keymap.c (describe_vector): Remove parameters `indices' and
8433 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8434 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8435
f868cd8a
JB
8436 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8437
8438 * keyboard.c (timer_check): Remove parameter `do_it_now',
8439 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8440 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8441 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8442
8443 * keyboard.c (read_char):
8444 * w32menu.c (w32_menu_display_help):
8445 * xmenu.c (show_help_event, menu_help_callback):
8446 Adjust calls to `show_help_echo'.
8447
8448 * gtkutil.c (xg_maybe_add_timer):
8449 * keyboard.c (readable_events):
8450 * process.c (wait_reading_process_output):
8451 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8452
8453 * insdel.c (adjust_markers_gap_motion):
8454 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8455 (gap_left, gap_right): Don't call it.
8456
2ecf6fdb
CY
84572011-03-25 Chong Yidong <cyd@stupidchicken.com>
8458
8459 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8460 incurred during fontification.
8461
6b1f9ba4
JB
84622011-03-25 Juanma Barranquero <lekktu@gmail.com>
8463
8464 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8465 (DEFVAR_PER_BUFFER): Don't pass it.
8466
8467 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8468 (scrolling_window): Don't pass it.
8469
0f4a96b5
JB
84702011-03-25 Juanma Barranquero <lekktu@gmail.com>
8471
8472 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8473
8474 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8475 and `suffix'.
8476 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8477 of variables specific to SELinux and computation of `encoded_absname'.
8478
8479 * image.c (XPutPixel): Remove unused variable `height'.
8480
8481 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8482
8483 * unexw32.c (get_section_info): Remove unused variable `section'.
8484
8485 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8486 (system_process_attributes): Remove unused variable `sess'.
8487 (sys_read): Remove unused variable `err'.
8488
8489 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8490 (w32_wnd_proc): Remove unused variable `isdead'.
8491 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8492 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8493 (x_create_tip_frame): Remove unused variable `tem'.
8494
8495 * w32inevt.c (w32_console_read_socket):
8496 Remove unused variable `no_events'.
8497
8498 * w32term.c (x_draw_composite_glyph_string_foreground):
8499 Remove unused variable `width'.
8500
1149507c
JB
85012011-03-24 Juanma Barranquero <lekktu@gmail.com>
8502
8503 * w32term.c (x_set_glyph_string_clipping):
8504 Don't pass uninitialized region to CombineRgn.
8505
9c88f339
JB
85062011-03-23 Juanma Barranquero <lekktu@gmail.com>
8507
8508 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8509 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8510 (Fx_close_connection): Remove unused variable `i'.
8511
8512 * w32font.c (w32font_draw): Return number of glyphs.
8513 (w32font_open_internal): Remove unused variable `i'.
8514 (w32font_driver): Add missing initializer.
8515
8516 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8517 (fill_in_menu): Remove unused variable `items_added'.
8518
8519 * w32term.c (last_mouse_press_frame): Remove static global variable.
8520 (w32_clip_to_row): Remove unused variable `f'.
8521 (x_delete_terminal): Remove unused variable `i'.
8522
8523 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8524 (NOTHING): Remove unused static global variable.
8525 (uniscribe_check_otf): Remove unused variable `table'.
8526 (uniscribe_font_driver): Add missing initializers.
8527
dee091a3
JD
85282011-03-23 Julien Danjou <julien@danjou.info>
8529
8530 * term.c (Fsuspend_tty, Fresume_tty):
8531 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8532 * window.c (temp_output_buffer_show):
8533 * insdel.c (signal_before_change):
8534 * frame.c (Fhandle_switch_frame):
8535 * fileio.c (Fdo_auto_save):
8536 * emacs.c (Fkill_emacs):
8537 * editfns.c (save_excursion_restore):
8538 * cmds.c (internal_self_insert):
8539 * callint.c (Fcall_interactively):
8540 * buffer.c (Fkill_all_local_variables):
8541 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8542 Use Frun_hooks.
0f4a96b5 8543 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8544 unconditionally since it does the check itself.
dee091a3 8545
2c520ab5 85462011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8547
c9c49752
PE
8548 Fix more problems found by GCC 4.5.2's static checks.
8549
8abc3f12
PE
8550 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8551 the first time through the loop, since we know p0 < p1 then.
8552 This also avoids a gcc -Wstrict-overflow warning.
8553
a2d26660
PE
8554 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8555 leading to a memory leak, possible in functions like
8556 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8557 of objects (Bug#8318).
a2d26660 8558
916c72e9
PE
8559 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8560 that could (at least in theory) be that large.
8561
19ab8a18
PE
8562 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8563 This is less likely to overflow, and avoids undefined behavior if
8564 overflow does occur. All callers changed. Use strtoul to scan
8565 for the unsigned long integer.
b7cbbd6f
PE
8566 (pint2hrstr): Simplify and tune code slightly.
8567 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8568
f0641eff
PE
8569 * scroll.c (do_scrolling): Work around GCC bug 48228.
8570 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8571
7f650bb9
PE
8572 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8573 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8574 (validate_x_resource_name): Simplify count usage.
8575 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8576
37dd57d1
PE
8577 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8578 fail (Bug#8306).
81e56e61 8579
699979fc 8580 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8581
401bf9b4
PE
8582 * process.c (Fmake_network_process): Use socklen_t, not int,
8583 where POSIX says socklen_t is required in portable programs.
8584 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8585 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8586 (Fmake_network_process, server_accept_connection):
8587 (wait_reading_process_output, read_process_output):
8588 Likewise.
8589
b93aacde
PE
8590 * process.c: Rename or move locals to avoid shadowing.
8591 (list_processes_1, Fmake_network_process):
8592 (read_process_output_error_handler, exec_sentinel_error_handler):
8593 Rename or move locals.
4dc343ee 8594 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8595 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8596 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8597 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8598 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8599
af8a867c 8600 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8601 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8602 Include tparam.h instead, since it declares them.
af8a867c
PE
8603 * cm.h (PC): Remove extern decl; tparam.h now does this.
8604 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8605 * terminfo.c: Include tparam.h, to check interfaces.
8606 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8607 (tparam): Adjust signature to match interface in tparam.h;
8608 this removes some undefined behavior. Check that outstring and len
8609 are zero, which they always are with Emacs.
8610 * tparam.h (PC, BC, UP): New extern decls.
8611
0248044d 8612 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8613 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8614
8ff096c1 8615 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8616 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8617 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8618 (ftfont_list): Remove unused local.
49eaafba
PE
8619 (get_adstyle_property, ftfont_pattern_entity):
8620 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8621 Rename locals to avoid shadowing.
8ff096c1 8622
e2be39f6
PE
8623 * xfont.c (xfont_list_family): Mark var as initialized.
8624
c9735e30
PE
8625 * xml.c (make_dom): Now static.
8626
8f5201ae
PE
8627 * composite.c (composition_compute_stop_pos): Rename local to
8628 avoid shadowing.
b246f932
PE
8629 (composition_reseat_it): Remove unused locals.
8630 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8631 (composition_update_it): Mark var as initialized.
11b61122
PE
8632 (find_automatic_composition): Mark vars as initialized,
8633 with a FIXME (Bug#8290).
8f5201ae 8634
760fbc2c
PE
8635 character.h: Rename locals to avoid shadowing.
8636 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8637 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8638 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8639 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8640 to avoid shadowing.
8641
ff08eb85
PE
8642 * textprop.c (property_change_between_p): Remove; unused.
8643
fc7bf025
PE
8644 * intervals.c (interval_start_pos): Now static.
8645
235d7abc
PE
8646 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8647
44f230aa
SM
8648 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8649 Rename locals to avoid shadowing.
3e7d6594 8650
50060332
PE
8651 * sound.c (wav_play, au_play, Fplay_sound_internal):
8652 Fix pointer signedness.
d01f234b 8653 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8654 (wav_play): Initialize a variable to 0, to prevent undefined
8655 behavior (Bug#8278).
50060332 8656
c4fc4e30
PE
8657 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8658
918436ed
PE
8659 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8660
c939f91b
PE
8661 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8662 clobbering (Bug#8298).
b9c7f648
PE
8663 * sysdep.c (sys_subshell): Likewise.
8664 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8665
6bd8c144
PE
8666 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8667 This should get cleaned up, so that child_setup has the
8668 same signature on all platforms.
8669
7710357c 8670 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8671 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8672
c59da222
CY
86732011-03-22 Chong Yidong <cyd@stupidchicken.com>
8674
8675 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8676 not to be necessary, and produces flickering.
8677
66b87493
GM
86782011-03-20 Glenn Morris <rgm@gnu.org>
8679
8680 * config.in: Remove file.
8681
45b6f6d5
JB
86822011-03-20 Juanma Barranquero <lekktu@gmail.com>
8683
8684 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8685 are now in src/globals.h.
8686 (syms_of_minibuf): Remove spurious & from previous change.
8687
cd394be1 86882011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8689
8690 * minibuf.c (completing-read-function): New variable.
8691 (completing-read-default): Rename from completing-read.
8692 (completing-read): Call completing-read-function.
8693
b14e3e21
CY
86942011-03-19 Juanma Barranquero <lekktu@gmail.com>
8695
8696 * xfaces.c (Fx_load_color_file):
8697 Read color file from absolute filename (bug#8250).
8698
f2b726e6
JB
86992011-03-19 Juanma Barranquero <lekktu@gmail.com>
8700
8701 * makefile.w32-in: Update dependencies.
8702
09f6ff02
EZ
87032011-03-17 Eli Zaretskii <eliz@gnu.org>
8704
8705 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8706
29a6015a
PE
87072011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8708
a3a6c54e
PE
8709 Fix more problems found by GCC 4.5.2's static checks.
8710
b766f867
PE
8711 * process.c (make_serial_process_unwind, send_process_trap):
8712 (sigchld_handler): Now static.
8713
be02381c
PE
8714 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8715 That way, the code declares only the vars that it needs.
8716 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8717 * s/cygwin.h (PTY_ITERATION): Likewise.
8718 * s/darwin.h (PTY_ITERATION): Likewise.
8719 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8720
57048744
PE
8721 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8722 * process.c (allocate_pty): Don't declare stb unless it's needed.
8723
7914961c 8724 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8725 (CONSTANTLIM): Remove; unused.
8726 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8727 Define only if needed.
7914961c 8728
b3967b18
PE
8729 * unexelf.c (unexec): Name an expression,
8730 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8731 Use a different way to cause a compilation error if anyone uses
8732 n rather than nn, a way that does not involve shadowing.
73366a00 8733 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8734
29a6015a
PE
8735 * deps.mk (unexalpha.o): Remove; unused.
8736
43cfc33e 8737 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8738 * unexec.h: New file.
ce701a33
PE
8739 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8740 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8741 Depend on unexec.h.
8742 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8743 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8744 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8745 Change as necessary to match prototype in unexec.h.
ce701a33 8746
01f44d5a
PE
8747 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8748 shadowing.
4f63c6bb 8749 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8750
a6670b0b
PE
8751 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8752 Rename locals to avoid shadowing.
8753
cef2010d 8754 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8755 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8756
d4d7173a
PE
8757 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8758
f08b802a
PE
8759 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8760 warning when compiling print.c.
8761
3ddb0639
PE
8762 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8763 instead of using an uninitialized var.
5ad03b97 8764 (font_sort_entities): Mark var as initialized.
3ddb0639 8765
170a2692
PE
8766 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8767
e663c700
PE
8768 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8769 pointers to constants.
89bc529a 8770 (font_parse_fcname): Remove unused vars.
7b81e2d0 8771 (font_delete_unmatched): Now static.
ea838e10 8772 (font_get_spec): Remove; unused.
13a547c6
PE
8773 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8774 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8775 Rename or move locals to avoid shadowing.
e663c700 8776
2a80c887 8777 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8778 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8779
1384fa33 8780 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8781 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8782
8b2c52e9
PE
8783 * alloc.c (mark_backtrace): Move decl from here ...
8784 * lisp.h: ... to here, so that it can be checked.
8785
475545b5 8786 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8787 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8788 (lisp_indirect_variable): Name an expression,
8789 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8790 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8791
b1349114 8792 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8793 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8794 Use const pointer when appropriate.
b1349114 8795
a2928364
PE
8796 * lisp.h (get_system_name, get_operating_system_release):
8797 Move decls here, to check interfaces.
8798 * process.c (get_operating_system_release): Move decl to lisp.h.
8799 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8800 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8801 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8802 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8803 (Fformat_time_string, Fencode_time, Finsert_char):
8804 (Ftranslate_region_internal, Fformat):
8805 Rename or remove local vars to avoid shadowing.
9710023e 8806 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8807
a415e694
PE
8808 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8809 avoid shadowing.
8810
8ef4622d
PE
8811 * lisp.h (eassert): Check that the argument compiles, even if
8812 ENABLE_CHECKING is not defined.
8813
946f9a5b
PE
8814 * data.c (Findirect_variable): Name an expression, to avoid
8815 gcc -Wbad-function-cast warning.
112396d6 8816 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8817 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8818 (Fmake_variable_buffer_local, Fmake_local_variable):
8819 Mark variables as initialized.
52746918 8820 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8821
e5aab7e7 8822 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8823 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8824 Rename locals to avoid shadowing.
dff45157
PE
8825 (mark_stack): Move local variables into the #ifdef region where
8826 they're used.
7bc26fdb
PE
8827 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8828 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8829 needed otherwise.
8830 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8831 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8832 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8833
e5aab7e7
PE
8834 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8835 avoids undefined behavior in theory.
8836
4da60324
PE
8837 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8838
88043301
PE
8839 Use functions, not macros, for up- and down-casing (Bug#8254).
8840 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8841 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8842 to use the following functions instead of these macros.
8843 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8844 EMACS_INT, since callers assume the returned value fits in int.
8845 (upcase1): Likewise, for UPCASE_TABLE.
8846 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8847 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8848 the race-condition problem in the old DOWNCASE.
88043301 8849
19ed5445
PE
8850 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8851 Rename locals to avoid shadowing.
8852 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8853 (regex_compile, re_search_2, re_match_2_internal):
8854 Remove unused local vars.
952db0d7
PE
8855 (FREE_VAR): Rewrite so as not to use empty "else",
8856 which gcc can warn about.
da053e48 8857 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8858 (RETALLOC_IF): Define only if needed.
8859 (WORDCHAR_P): Likewise. This one is never needed, but is used
8860 only in a comment talking about a compiler bug, so put inside
8861 the #if 0 of that comment.
8862 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8863 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8864 Remove; unused.
19ed5445 8865
1f3561e4 8866 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8867 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8868 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8869
ded6f8f7
PE
8870 * search.c (simple_search): Remove unused var.
8871
dbd37a95
PE
8872 * dired.c (compile_pattern): Move decl from here ...
8873 * lisp.h: ... to here, so that it can be checked.
8874 (struct re_registers): New forward decl.
8875
7e47afad
PE
8876 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8877
85f24f61
PE
8878 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8879 All uses changed.
8880 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8881 Rename locals to avoid shadowing.
5671df8f 8882 (Fvertical_motion): Mark locals as initialized.
85f24f61 8883
181aa2be 8884 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8885 (casify_region): Mark local as initialized.
181aa2be 8886
930d429c
PE
8887 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8888
7082eac6
PE
8889 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8890 New macros, so that the caller can use some names other than
8891 gcpro1, gcpro2, etc.
8892 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8893 of the new macros.
8894 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8895 argument, for consistency with GCPRO2_VAR, etc: it is now the
8896 prefix of the variable, not the variable itself. All uses
8897 changed.
38b2c076
PE
8898 * dired.c (directory_files_internal, file_name_completion):
8899 Rename locals to avoid shadowing.
8900
15206ed9
PE
8901 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8902 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8903 dired.c's scmp function, had undefined behavior.
8904 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8905 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8906 * buffer.h: ... to here, because these macros use current_buffer,
8907 and the new implementation with inline functions needs to have
8908 current_buffer in scope now, rather than later when the macros
8909 are used.
8910 (downcase, upcase1): New static inline functions.
8911 (DOWNCASE, UPCASE1): Reimplement using these functions.
8912 This avoids undefined behavior in expressions like
8913 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8914 from race conditions in accessing the global variables
8915 case_temp1 and case_temp2.
8916 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8917 * lisp.h (case_temp1, case_temp2): Remove their decls.
8918 * character.h (ASCII_CHAR_P): Move from here ...
8919 * lisp.h: ... to here, so that the inline functions mentioned
8920 above can use them.
8921
4a6bea26
PE
8922 * dired.c (directory_files_internal_unwind): Now static.
8923
f14b7e14
PE
8924 * fileio.c (file_name_as_directory, directory_file_name):
8925 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8926 Now static.
2893f146
PE
8927 (file_name_as_directory): Use const pointers when appropriate.
8928 (Fexpand_file_name): Likewise. In particular, newdir might
8929 point at constant storage, so make it a const pointer.
fd4ead52 8930 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8931 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8932 signedness issues.
f839df0c
PE
8933 (Fset_file_times, Finsert_file_contents, auto_save_error):
8934 Rename locals to avoid shadowing.
f14b7e14 8935
5716756e 8936 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8937 (Ftry_completion, Fall_completions): Rename or remove locals
8938 to avoid shadowing.
5716756e 8939
b4c3046a
PE
8940 * marker.c (bytepos_to_charpos): Remove; unused.
8941
b45db522
PE
8942 * lisp.h (verify_bytepos, count_markers): New decls,
8943 so that gcc does not warn that these functions aren't declared.
8944
85876d07
PE
8945 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8946 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8947 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8948 (copy_text): Remove unused local var.
85876d07 8949
03d78a21 8950 * filelock.c (within_one_second): Now static.
b3dd38ab 8951 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8952
5df8f01b
PE
8953 * buffer.c (fix_overlays_before): Mark locals as initialized.
8954 (fix_start_end_in_overlays): Likewise. This function should be
8955 simplified by using pointers-to-pointers, but that's a different
8956 matter.
b1d876f1 8957 (switch_to_buffer_1): Now static.
8f54f30a
PE
8958 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8959 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8960
a70072c9 8961 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8962 Fix pointer signedness issue.
edced198
PE
8963 (sys_subshell): Mark local as volatile if checking for lint,
8964 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8965 (MAXPATHLEN): Define only if needed.
a70072c9 8966
a0977c44
PE
8967 * process.c (serial_open, serial_configure): Move decls from here ...
8968 * systty.h: ... to here, so that they can be checked.
8969
a884fdcc
PE
8970 * fns.c (get_random, seed_random): Move extern decls from here ...
8971 * lisp.h: ... to here, so that they can be checked.
8972
604efe86 8973 * sysdep.c (reset_io): Now static.
b8950c94 8974 (wait_for_termination_signal): Remove; unused.
604efe86 8975
38fc62d9
PE
8976 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8977 (copy_keymap_item, append_key, push_text_char_description):
8978 Now static.
1004a21a 8979 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8980 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8981 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8982 (describe_map_tree):
8983 Rename locals to avoid shadowing.
38fc62d9 8984
2f2650da
PE
8985 * keyboard.c: Declare functions static if they are not used elsewhere.
8986 (echo_char, echo_dash, cmd_error, top_level_2):
8987 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8988 (read_char, kbd_buffer_get_event, make_lispy_position):
8989 (make_lispy_event, make_lispy_movement, apply_modifiers):
8990 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8991 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8992 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8993 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8994 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8995
a053e86c 8996 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8997 (mark_kboards): Move decl here ...
8998 * alloc.c (mark_kboards): ... from here.
a053e86c 8999
4752793e
PE
9000 * lisp.h (force_auto_save_soon): New decl.
9001
74f10ca7 9002 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9003 (DEFINE_DUMMY_FUNCTION): New macro.
9004 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9005 Use it.
c03cd23f
PE
9006 (main): Add casts to avoid warnings
9007 if GCC considers string literals to be constants.
74f10ca7 9008
022e70d4
PE
9009 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9010
59d6fe83
PE
9011 * dbusbind.c: Pointer signedness fixes.
9012 (xd_signature, xd_append_arg, xd_initialize):
9013 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9014 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9015 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9016 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9017
78320123
PE
9018 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9019 if GCC considers string literals to be constants.
49cebcca 9020 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9021
35ac2a97
SM
90222011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9023
fb103ca9
SM
9024 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9025 (print_preprocess, print_object): New macro to fix last change.
9026
35ac2a97
SM
9027 * print.c (print_preprocess): Don't forget font objects.
9028
62973b41
JB
90292011-03-16 Juanma Barranquero <lekktu@gmail.com>
9030
9031 * emacs.c (USAGE3): Doc fixes.
9032
0e48bb22
AS
90332011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9034
9035 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9036 structure.
9037
7684e57b
JB
90382011-03-14 Juanma Barranquero <lekktu@gmail.com>
9039
9040 * lisp.h (VWindow_system, Qfile_name_history):
9041 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9042 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9043 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9044
9045 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9046 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9047
9048 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9049 * w32console.c (detect_input_pending, read_input_pending)
9050 (encode_terminal_code):
9051 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9052 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9053 (w32_system_caret_y, Qfile_name_history):
9054 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9055 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9056 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9057 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9058 * w32proc.c (Qlocal, report_file_error):
9059 * w32term.c (Vwindow_system, updating_frame):
9060 * w32uniscribe.c (initialized, uniscribe_font_driver):
9061 Remove unneeded extern declarations.
9062
2aa46d6c
CY
90632011-03-14 Chong Yidong <cyd@stupidchicken.com>
9064
c96bbc66 9065 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9066
cffc6f3b
CY
90672011-03-13 Chong Yidong <cyd@stupidchicken.com>
9068
9069 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9070 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9071 These macros can no longer be used for assignment.
9072
44f230aa
SM
9073 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9074 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9075 (record_buffer_markers, fetch_buffer_markers): New functions for
9076 recording and fetching special buffer markers.
9077 (set_buffer_internal_1, set_buffer_temp): Use them.
9078
9079 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9080
9081 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9082
9083 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9084 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9085
9086 * xdisp.c (hscroll_window_tree):
9087 (reconsider_clip_changes): Use PT instead of BUF_PT.
9088
d251f04b
EZ
90892011-03-13 Eli Zaretskii <eliz@gnu.org>
9090
9091 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9092 $(EMACS_ROOT)/lib/intprops.h.
9093
f0c77cd1
PE
90942011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9095
3eca4629
PE
9096 Fix more problems found by GCC 4.5.2's static checks.
9097
7c86ee98
PE
9098 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9099 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9100 (xg_free_frame_widgets): Make it clear that a local variable is
9101 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9102 (gdk_window_get_screen): Make it clear that this macro is needed
9103 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9104 (int_gtk_range_get_value): New function, which avoids a diagnostic
9105 from gcc -Wbad-function-cast.
9106 (xg_set_toolkit_scroll_bar_thumb): Use it.
9107 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9108 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9109 (get_utf8_string, xg_get_file_with_chooser):
9110 Rename locals to avoid shadowing.
9111 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9112
41729b81
PE
9113 * xgselect.c (xg_select): Remove unused var.
9114
f0c77cd1
PE
9115 * image.c (four_corners_best): Mark locals as initialized.
9116 (gif_load): Initialize transparent_p to zero (Bug#8238).
9117 Mark another local as initialized.
ec6cf4c6 9118 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9119
ce0ad53d 9120 * image.c (clear_image_cache): Now static.
d5d5a617 9121 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9122 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9123 (x_edge_detection): Remove unnecessary cast that
9124 gcc -Wbad-function-cast diagnoses.
2037898d 9125 (gif_load): Fix pointer signedness.
6ae141d6
PE
9126 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9127 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9128
33383987 91292011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9130
d32df629
PE
9131 Improve quality of tests for time stamp overflow.
9132 For example, without this patch (encode-time 0 0 0 1 1
9133 1152921504606846976) returns the obviously-bogus value (-948597
9134 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9135 reports time overflow. See
9136 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9137 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9138 * editfns.c: Include limits.h and intprops.h.
9139 (TIME_T_MIN, TIME_T_MAX): New macros.
9140 (time_overflow): Move earlier, to before first use.
9141 (hi_time, lo_time): New functions, for an accurate test for
9142 out-of-range times.
9143 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9144 (Fget_internal_run_time): Don't assume time_t fits in int.
9145 (make_time): Use list2 instead of Fcons twice.
9146 (Fdecode_time): More accurate test for out-of-range times.
9147 (check_tm_member): New function.
9148 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9149 (lisp_time_argument): Don't rely on undefined left-shift and
9150 right-shift behavior when checking for time stamp overflow.
8be6f318 9151
fe31d94c
PE
9152 * editfns.c (time_overflow): New function, refactoring common code.
9153 (Fformat_time_string, Fdecode_time, Fencode_time):
9154 (Fcurrent_time_string): Use it.
9155
8be6f318
PE
9156 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9157 * dired.c (make_time): Move to ...
9158 * editfns.c (make_time): ... here.
9159 * systime.h: Note the move.
9160
09d9db2c 91612011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9162
126bc0dc
YM
9163 * fringe.c (update_window_fringes): Remove unused variables.
9164
c47cbdfd
YM
9165 * unexmacosx.c (copy_data_segment): Also copy __got section.
9166 (Bug#8223)
9167
7ac80be9
EZ
91682011-03-12 Eli Zaretskii <eliz@gnu.org>
9169
c96bbc66 9170 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9171 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9172 Constify `char *' arguments and their references according to
9173 prototypes in tparam.h.
9174
ecb0f94d 9175 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9176
7ac80be9
EZ
9177 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9178 Adapt all references accordingly.
9179
9180 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9181
ef1fd07e
TT
91822011-03-11 Tom Tromey <tromey@redhat.com>
9183
9184 * buffer.c (syms_of_buffer): Remove obsolete comment.
9185
7ef4b50c
EZ
91862011-03-11 Eli Zaretskii <eliz@gnu.org>
9187
9188 * termhooks.h (encode_terminal_code): Declare prototype.
9189
9190 * msdos.c (encode_terminal_code): Don't declare prototype.
9191
9192 * term.c (encode_terminal_code): Now external again, used by
9193 w32console.c and msdos.c.
9194
44f230aa
SM
9195 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9196 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9197
4b1ec863 91982011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9199
1714f52b 9200 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9201
4b1ec863
PE
9202 * fringe.c (update_window_fringes): Mark locals as initialized
9203 (Bug#8227).
9204 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9205
524c7aa6
PE
9206 * alloc.c (mark_fringe_data): Move decl from here ...
9207 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9208 to check its interface.
9209 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9210
a5c0af81 9211 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9212 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9213 (fontset_font): Mark local as initialized.
a9a06e0b 9214 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9215
b4716021
PE
9216 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9217
811e9bac 9218 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9219 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9220 (x_own_selection, Fx_disown_selection_internal): Rename locals
9221 to avoid shadowing.
9222 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9223
7e3ab302
PE
9224 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9225 so that the caller can use some name other than gcpro1.
9226 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9227 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9228 (Fx_backspace_delete_keys_p):
9229 Use them to avoid shadowing, and rename vars to avoid shadowing.
9230 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9231 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9232 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9233 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9234 Remove unused locals.
7e3ab302
PE
9235 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9236 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9237 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9238 macros.
f78faa98 9239
e2b13473
PE
9240 * xterm.h (x_mouse_leave): New decl.
9241
77f23912
PE
9242 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9243 Remove unused functions.
cdf4ba58
PE
9244 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9245 (x_calc_absolute_position): Now static.
7411c686 9246 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9247 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9248 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9249 unless they are used.
38d0b34a
PE
9250 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9251 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9252 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9253 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9254 (x_error_catcher, x_connection_closed, x_error_handler):
9255 (x_error_quitter, xembed_send_message, x_iconify_frame):
9256 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9257 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9258 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9259
44f230aa
SM
9260 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9261 Rename or move locals to avoid shadowing.
6b463e58 9262 (tty_defined_color, merge_face_heights): Now static.
5967d051 9263 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9264 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9265 does not deduce is never used uninitialized.
73719eba
PE
9266 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9267 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9268
426994c3 9269 * terminal.c (store_terminal_param): Now static.
5489860b 9270
032f1620 9271 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9272 (set_frame_menubar): Remove unused local.
d4323972 9273 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9274 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9275 since they might point to immutable storage.
281585b0
PE
9276 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9277 since it's unused otherwise.
032f1620 9278
367c19e5 9279 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9280 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9281 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9282 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9283 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9284 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9285 does not deduce are never used uninitialized.
70739cbe 9286
07b48fa9
PE
9287 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9288
8868a238 9289 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9290 * window.c (window_loop, size_window):
9291 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9292
7e5cf297 9293 * window.c (display_buffer): Now static.
d6550a9f
PE
9294 (size_window): Mark variables that gcc -Wuninitialized
9295 does not deduce are never used uninitialized.
a586633d
PE
9296 * window.h (check_all_windows): New decl, to forestall
9297 gcc -Wmissing-prototypes diagnostic.
5b555da1 9298 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9299
f6095868
PE
9300 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9301 shadowing.
9302 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9303 Include <limits.h>.
9304 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9305 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9306 (load_charset_map): Mark variables that gcc -Wuninitialized
9307 does not deduce are never used uninitialized.
53df7c11 9308 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9309
f38b440c
PE
9310 * coding.c (coding_set_source, coding_set_destination):
9311 Use "else { /* comment */ }" rather than "else /* comment */;"
9312 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9313 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9314 a block, when the outer 'i' will do.
9315 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9316 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9317 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9318 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9319 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9320 Rename locals to avoid shadowing.
9321 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9322 * coding.c (emacs_mule_char, encode_invocation_designation):
9323 Now static, since they're not used elsewhere.
413bb2db 9324 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9325 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9326 (decode_coding_emacs_mule): Mark variables that gcc
9327 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9328 (detect_coding_iso_2022): Initialize a local variable that might
9329 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9330 this initialization is needed. (Bug#8211)
5f58e762
PE
9331 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9332 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9333 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9334 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9335 Remove unused macros.
f38b440c 9336
232b38b9 9337 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9338 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9339 * character.c (string_count_byte8): Likewise.
232b38b9 9340
fb90da1b
PE
9341 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9342 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9343
fb93dbc2
PE
9344 * chartab.c (copy_sub_char_table): Now static, since it's not used
9345 elsewhere.
5c156ace
PE
9346 (sub_char_table_ref_and_range, char_table_ref_and_range):
9347 Rename locals to avoid shadowing.
bbcd0949 9348 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9349
7d3b3862 9350 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9351 (BIDI_BOB): Remove unused macro.
7d3b3862 9352
6be7d3da
PE
9353 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9354 deduce are never used uninitialized.
c2ed9c8b 9355 * term.c (encode_terminal_code): Likewise.
6be7d3da 9356
75f8807f 9357 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9358
50938595
PE
9359 * tparam.h: New file.
9360 * term.c, tparam.h: Include it.
9361 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9362 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9363 Move these decls to tparam.h, and make them agree with what
9364 is actually in tparam.c. The previous trick of using incompatible
9365 decls in different modules does not conform to the C standard.
9366 All callers of tparam changed to use tparam's actual API.
9367 * tparam.c (tparam1, tparam, tgoto):
9368 Use const pointers where appropriate.
9369
fbceeba2
PE
9370 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9371 * cm.h (struct cm): Likewise.
9372 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9373 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9374 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9375 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9376 (turn_on_face, init_tty): Likewise.
9377 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9378
7f3f1250
PE
9379 * term.c (term_mouse_position): Rename local to avoid shadowing.
9380
e6ca6543
PE
9381 * alloc.c (mark_ttys): Move decl from here ...
9382 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9383
c40f8d15
AS
93842011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9385
9386 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9387
cfe0661d
JB
93882011-03-09 Juanma Barranquero <lekktu@gmail.com>
9389
9390 * search.c (compile_pattern_1): Remove argument regp, unused since
9391 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9392 (compile_pattern): Don't pass it.
9393
0afb4571
J
93942011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9395
9396 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9397 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9398 for ! HAVE_GTK3.
9399 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9400
9401 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9402
9403 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9404 gdk_window_get_screen, gdk_window_get_geometry,
9405 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9406 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9407 (xg_get_pixbuf_from_pixmap): New function.
9408 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9409 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9410 Call xg_get_pixbuf_from_pixmap instead of
9411 gdk_pixbuf_get_from_drawable.
9412 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9413 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9414 (xg_check_special_colors): Use GtkStyleContext and its functions
9415 for HAVE_GTK3.
9416 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9417 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9418 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9419 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9420 Call gtk_widget_get_preferred_size.
0afb4571
J
9421 (xg_frame_resized): gdk_window_get_geometry only takes 5
9422 parameters.
44f230aa
SM
9423 (xg_win_to_widget, xg_event_is_for_menubar):
9424 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9425 (xg_set_widget_bg): New function.
9426 (delete_cb): New function.
895009e1 9427 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9428 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9429 (xg_set_background_color): Call xg_set_widget_bg.
9430 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9431 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9432 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9433 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9434 if ! HAVE_GTK3.
9435 (update_frame_tool_bar): Call gtk_widget_hide.
9436 (xg_initialize): Use GDK_KEY_g.
9437
9438 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9439 if ! HAVE_GTK3
9440 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9441
9442 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9443 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9444 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9445
1c2cc4ef
JB
94462011-03-08 Juanma Barranquero <lekktu@gmail.com>
9447
9448 * w32xfns.c (select_palette): Check success of RealizePalette against
9449 GDI_ERROR, not zero.
9450
33383987 9451See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9452
9453;; Local Variables:
9454;; coding: utf-8
aac0c6e3
MR
9455;; End:
9456
acaf905b 9457 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9458
9459 This file is part of GNU Emacs.
9460
9461 GNU Emacs is free software: you can redistribute it and/or modify
9462 it under the terms of the GNU General Public License as published by
9463 the Free Software Foundation, either version 3 of the License, or
9464 (at your option) any later version.
9465
9466 GNU Emacs is distributed in the hope that it will be useful,
9467 but WITHOUT ANY WARRANTY; without even the implied warranty of
9468 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9469 GNU General Public License for more details.
9470
9471 You should have received a copy of the GNU General Public License
9472 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.