* editfns.c (save_excursion_save): Use nil if mark points to nowhere.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
549c3414
DA
12012-10-11 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * editfns.c (save_excursion_save): Use nil if mark points to nowhere.
4 (save_excursion_restore): Do not restore mark if it was not saved.
5
e85aafe7
PE
62012-10-11 Paul Eggert <eggert@cs.ucla.edu>
7
fd2f90cf
PE
8 * marker.c (cached_modiff): EMACS_INT, not int.
9
c1af190b
PE
10 * w32select.c (waiting_for_input): Declare by including "keyboard.h"
11 instead of having a wrong decl.
e85aafe7
PE
12 * nsmenu.m (waiting_for_input): Remove wrong decl.
13
e738ca56
PE
142012-10-10 Paul Eggert <eggert@cs.ucla.edu>
15
9fa1de30
PE
16 keyboard.c, keymap.c: Use bool for booleans.
17 * dispnew.c (sit_for): Distinguish between 3-way display_option
18 and boolean do_display.
19 * keyboard.c (single_kboard, this_command_key_count_reset)
20 (waiting_for_input, echoing, immediate_quit, input_pending)
21 (interrupt_input, interrupts_deferred, pop_kboard)
22 (temporarily_switch_to_single_kboard, ignore_mouse_drag_p)
23 (command_loop_1, adjust_point_for_property)
24 (safe_run_hooks_error, input_polling_used, read_char):
25 (help_char_p, readable_events, kbd_buffer_events_waiting)
26 (kbd_buffer_get_event, timer_check_2, make_lispy_event)
27 (lucid_event_type_list_p, get_input_pending):
28 (gobble_input, menu_separator_name_p, menu_bar_item)
29 (parse_menu_item, parse_tool_bar_item, read_char_x_menu_prompt)
30 (read_char_minibuf_menu_prompt, access_keymap_keyremap)
31 (keyremap_step, test_undefined, read_key_sequence)
32 (detect_input_pending, detect_input_pending_ignore_squeezables)
33 (detect_input_pending_run_timers, requeued_events_pending_p)
34 (quit_throw_to_read_char, Fset_input_interrupt_mode):
35 * keymap.c (get_keymap, keymap_parent, keymap_memberp)
36 (access_keymap_1, access_keymap, map_keymap, get_keyelt)
37 (Fdefine_key, Flookup_key, struct accessible_keymaps_data)
38 (accessible_keymaps_1, Fkey_description, push_key_description):
39 (shadow_lookup, struct where_is_internal_data)
40 (where_is_internal, Fwhere_is_internal, where_is_internal_1)
41 (Fdescribe_buffer_bindings, describe_map_tree, struct describe_map_elt)
42 (describe_map, describe_vector):
43 * menu.c (single_menu_item):
44 * nsmenu.m (ns_update_menubar):
45 * process.c (wait_reading_process_output):
46 * search.c (scan_buffer, scan_newline):
47 Use bool for boolean.
48 * keyboard.c (timers_run, swallow_events)
49 (detect_input_pending_run_timers):
50 * process.c (wait_reading_process_output):
51 Use unsigned for counter where wraparound-on-overflow is desired,
52 since unsigned is guaranteed to have that behavior and signed is not.
53 (read_char): Use ptrdiff_t for string length.
54 (get_input_pending): Remove first argument, since it was always
55 the same pointer-to-int (now pointer-to-boolean) &input_pending,
56 and behave as if it had that value. Return new value of
57 input_pending. All callers changed.
58 * keyboard.h (struct kboard): Use unsigned : 1 for boolean member
59 immediate_echo. Use ptrdiff_t for echo_after_prompt, since it's
60 a string length.
61 * keymap.c (push_key_description): Omit last arg, which was always 1.
62 All callers changed.
63
e738ca56
PE
64 * regex.c (immediate_quit) [emacs]: Remove duplicate decl.
65
29f21cdf
JB
662012-10-10 Juanma Barranquero <lekktu@gmail.com>
67
68 * makefile.w32-in ($(BLD)/dispnew.$(O), $(BLD)/indent.$(O))
69 ($(BLD)/term.$(O)): Update dependencies.
70
6aea7528
DA
712012-10-10 Dmitry Antipov <dmantipov@yandex.ru>
72
73 * alloc.c (mark_object): Use meaningful PVEC_NORMAL_VECTOR.
74 * lisp.h (enum pvec_type): Adjust comments and omit explicit
75 initializer for PVEC_NORMAL_VECTOR.
76
5f3f57be
PE
772012-10-10 Paul Eggert <eggert@cs.ucla.edu>
78
79 Clean out old termopts cruft.
80 * termopts.h (flow_control, meta_key): Remove unused decls.
81 * dispnew.c, indent.c, nsterm.m, term.c, xsettings.c, xsmfns.c:
82 Don't include termopts.h.
83
3e98c68e
DA
842012-10-10 Dmitry Antipov <dmantipov@yandex.ru>
85
86 * alloc.c (gc_sweep): Use pointer-to-a-pointer loop for buffers.
87
77e344e5
PE
882012-10-10 Paul Eggert <eggert@cs.ucla.edu>
89
90 * commands.h (immediate_quit): Remove duplicate decl.
91
5683d7cd
JD
922012-10-09 Jan Djärv <jan.h.d@swipnet.se>
93
94 * nsfont.m (Vfonts_in_cache): Remove, not needed as font.c handles
95 caching.
96 (nsfont_open): Remove setting of Vfonts_in_cache.
97 (syms_of_nsfont): Remove initialization of Vfonts_in_cache
98
cf5fc6db
EZ
992012-10-09 Eli Zaretskii <eliz@gnu.org>
100
b15736e6
EZ
101 * w32fns.c (w32_last_error): Change the return value to DWORD, to
102 match what GetLastError returns. Explain why the function is
103 needed.
104
cf5fc6db
EZ
105 * frame.c (delete_frame): Rename local variable 'tooltip_frame' to
106 'is_tooltip_frame', to avoid confusion with its global namesake.
107
f99714ce
DC
1082012-10-08 Daniel Colascione <dancol@dancol.org>
109
110 * xdisp.c (start_hourglass): Call w32_note_current_window when
2b1f11ed
EZ
111 HAVE_NTGUI, not just WINDOWSNT, resolving a problem in the cygw32
112 build that caused Emacs to display the hourglass cursor forever.
f99714ce 113
fd59cb29
GM
114 * w32fns.c (Fx_display_color_cells): Instead of using NCOLORS,
115 which is broken under remote desktop, calculate the number of
116 colors available for a display based on the display's number of
117 planes and number of bits per pixel per plane. (bug#10397).
118
62c480c9 1192012-10-08 Jan Djärv <jan.h.d@swipnet.se>
fd59cb29 120
62c480c9
JD
121 * nsfont.m (Vfonts_in_cache): New variable.
122 (nsfont_open): Use unsignedLongLongValue for cache in case wide ints
123 are used. Add cached fonts to Vfonts_in_cache.
124 (syms_of_nsfont): Initialize and staticpro Vfonts_in_cache.
125
607446ba
JB
1262012-10-08 Juanma Barranquero <lekktu@gmail.com>
127
fd5125ad
JB
128 * makefile.w32-in (LOCAL_FLAGS): Don't define HAVE_NTGUI, it's now
129 in nt/config.nt.
46979e0b
JB
130 (FONT_H): Define after FRAME_H.
131 ($(BLD)/emacs.$(O), $(BLD)/process.$(O), $(BLD)/w32heap.$(O)):
132 Update dependencies.
fd5125ad 133
607446ba
JB
134 * w32term.c: Remove leftover declaration of keyboard_codepage.
135
b6f4e300
EZ
1362012-10-08 Eli Zaretskii <eliz@gnu.org>
137
c54ebba4
EZ
138 * makefile.w32-in (FONT_H): Add $(FRAME_H).
139 (W32TERM_H): Add $(ATIMER_H) and $(FRAME_H).
140 ($(BLD)/emacs.$(O), $(BLD)/w32console.$(O)): Update dependencies.
141 (GLOBAL_SOURCES): Add cygw32.c.
fd59cb29
GM
142 ($(BLD)/unexw32.$(O)):
143 ($(BLD)/w32.$(O)):
144 ($(BLD)/w32console.$(O)):
145 ($(BLD)/w32fns.$(O)):
146 ($(BLD)/w32heap.$(O)):
147 ($(BLD)/w32menu.$(O)):
15c720a3 148 ($(BLD)/w32proc.$(O)): Add w32common.h.
c54ebba4 149
b6f4e300
EZ
150 * w32fns.c (w32_color_map_lookup, x_to_w32_color): Argument is now
151 'const char *'.
152 (x_to_w32_color): Don't modify the argument, modify a copy instead.
153
501199a3
DC
1542012-10-08 Daniel Colascione <dancol@dancol.org>
155
156 * w32term.h (WM_EMACS_BRINGTOTOP, WM_EMACS_INPUT_READY)
157 (WM_EMACS_END): Change WM_EMACS_BRINGTOTOP from 22 to 21 to close
158 accidental message numbering hole. Change other messages to
159 match.
160
161 * w32select.h (HAVE_W32SELECT): Remove.
162
163 * w32select.c, w32proc.c, w32menu.c, w32console.c, w32.c: Include
164 w32common.h instead of w32heap.h
165
166 * w32heap.h (ROUND_UP, ROUND_DOWN, get_page_size)
167 (get_allocation_unit, get_processor_type, get_w32_major_version)
168 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
169 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
170 (OS_NT, os_subtype, cache_system_info): Move declarations to
171 w32common.
172
173 * w32heap.c: Include w32common.h.
174 (sysinfo_cache, syspage_mask, osinfo_cache, w32_major_version)
175 (w32_minor_version, w32_build_number, w32_subtype): Remove
176 duplicate definitions.
177
178 * w32fns.c: Include w32common.h; include w32heap.h only in
179 WINDOWSNT.
180
181 (Fx_file_dialog): Clarify comment on GetOpenFileName structure.
182 Use `report_file_error' instead of `error' in order to better
183 inform users of what went wrong. Increase NTGUI_UNICODE file
184 dialog box file name length to 32k, the maximum allowed by the NT
185 kernel.
186
187 * w32common.h: New file.
188 (ROUND_UP, ROUND_DOWN, get_page_size)
189 (get_allocation_unit, get_processor_type, get_w32_major_version)
190 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
191 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
192 (OS_NT, os_subtype, cache_system_info): Move here.
193
194 * unexw32.c, unexcw.c: Include w32common.h.
195
196 * emacs.c (main): Use (defined (WINDOWSNT) || defined
197 HAVE_NTGUI) instead of removed HAVE_W32SELECT to decide whether
198 to call syms_of_w32select.
199
200 * cygw32.h: Remove obsolete EXFUN declarations.
201
202 * cygw32.c (Qutf_16_le): Rename to Qutf_16le.
203
204 * Makefile.in (SOME_MACHINE_OBJECTS): Reverse accidental removal
205 of w32inevt.o from SOME_MACHINE_OBJECTS.
206
93aa5c81
DC
2072012-10-08 Daniel Colascione <dancol@dancol.org>
208
209 * image.c: Permanent fix for JPEG compilation issue --- limit
210 jpeglib `boolean' redefinition to Cygwin builds.
211
d424f3d8
EZ
2122012-10-08 Eli Zaretskii <eliz@gnu.org>
213
8ee4c6ce
EZ
214 * image.c (CHECK_LIB_AVAILABLE): Remove, no longer used.
215
d424f3d8
EZ
216 * emacs.c (DAEMON_MUST_EXEC) [HAVE_NTGUI]: Define this only on
217 Cygwin.
218
e08348a0
DC
2192012-10-08 Daniel Colascione <dancol@dancol.org>
220
221 * xfaces.c, xdisp.c, window.c, w32xfns.c, w32term.h, w32term.c,
222 w32select.h w32select.c, w32proc.c, w32menu.c, w32inevt.c,
223 w32help.c, w32font.c, w32font.c, w32fns.c, w32console.c, w32.h,
224 w32.c, unexw32.c, termhooks.h, process.c, menu.c, keyboard.h,
225 keyboard.c, image.c, frame.h, frame.c, fontset.c, font.h, font.c,
226 emacs.c, dispextern.h, cygw32.h, cygw32.c, conf_post.h,
227 Makefile.in: use HAVE_NTGUI for W32 GUI and WINDOWSNT for the
228 operating system. defined(HAVE_NTGUI) && !defined(WINDOWSNT) is
229 now a supported configuration.
230
231 * Makefile.in: consolidate image variables into LIBIMAGE; add
232 W32_OBJ and W32_LIBS. Compile new files.
233
234 * conf_post.h:
235 (_DebPrint) declare tracing facility for W32 debugging. We need
236 to unify tracing later.
237
238 (NTGUI_UNICODE) Define when compiling for Cygwin to allow the
239 unconditional use of W32 Unicode functions. Cygwin runs only on
240 100% Unicode operating systems.
241
242 * cygw32.c: New file. Define Cygwin-specific facilities.
243 (Fcygwin_convert_path_to_windows)
244 (Fcygwin_convert_path_from_windows): New user functions for
245 accessing Cygwin path-munging routines.
246
247 * cygw32.h: New file.
248 (WCSDATA, to_unicode, from_unicode): Define facilities for storing
249 UTF-16LE strings temporarily inside non-Lisp-visible string
250 objects.
251
252 (w32_strerror): Just what it says on the tin.
253
254 * emacs.c: Make the NS fork-then-exec code for daemon-launching
255 also run for Cygwin; both systems have the same problem with using
256 GUI facilities in a forked child. Also call syms_of_cygw32,
257 syms_of_w32select in correct places.
258
259 (DAEMON_MUST_EXEC): new macro defined to signal that a platform
260 needs fork-then-exec for daemon launching.
261
262 * font.h: Include frame.h.
263
264 * image.c: Use the image library cache machinery only when we're
265 compiling for native WINDOWSNT; Cygwin can use shared libraries
266 like any other Unixlike system.
267
268 * keyboard.c: Clarify a comment regarding the input loop.
269
270 * menu.c: When NTGUI_UNICODE is defined, use Unicode menu
271 functions directly instead of trying to detect at runtime that our
272 host operating system supports them. We make this change for two
273 reasons: Cygwin lacks support for the multibyte character
274 conversion functions used by the legacy menu code, and Cygwin
275 never needs to rely on non-Unicode APIs.
276
277 * unexw32.c (hinst): Declare extern.
278
279 * w32.c: Change header order;
280 (w32_strerror): Move to w32fns.c because we need it for
281 non-WINDOWSNT builds.
282
283 * w32.h: Add #error macro to make sure we don't include w32.h for
284 Cygwin builds. Remove w32select declarations.
285
286 * w32console.c (w32_sys_ring_bell, Fset_message_beep): Move to
287 w32fns.c. w32console.c is WINDOWSNT-only.
288
289 * w32fns.c: Include cygw32.h or w32.h depending on CYGWIN; more
290 NTGUI_UNICODE tweaks. (See above.) Change _snprintf to the more
291 POSIXy alternative.
292 (faked_key, sysinfo_cache, osinfo_cahce, syspage_mask)
293 (w32_major_version, w32_minor_version, w32_build_number)
294 (os_subtype, sound_type): Define here
295 (w32_defined_color): Make color parameter const for consistency
296 with other _defined_color functions.
297 (w32_createwindow): Unconditionally call w32_init_class instead of
298 doing so only when hprevinst is non-NULL. Plumbing hprevinst
299 through the code is complex and unnecessary because class
300 registration is practically free.
301 (w32_name_of_message): New EMACSDEBUG-only function.
302 (Fset_message_beep): Move here
303 (Fx_open_connection): Require that the display name for Windows be
304 "w32" for consistency, emacsclient disambiguation, and maybe, one
305 day, multi-window-system support.
306 (file_dialog_callback): NTGUI_UNICODE changes; encode and decode
307 Cygwin files for W32 GUI facilities, since these clearly don't
308 expect Cygwin names.
309 (_DebPrint): Define.
310 (w32_strerror, w32_console_toggle_lock_key, w32_kbd_mods_to_emacs)
311 (w32_kbd_patch_key, w32_sys_ring_bell): Move here.
312 (Ssystem_move_file_to_trash): Define only for native WINDOWSNT.
313 (w32_last_error): Remove.
314
315 * w32font.c: Define _strlwr to strlwr for non-WINDOWSNT builds.
316
317 * w32heap.c (syspage_mask): Declare here.
318 (cache_system_info): Remove.
319
320 * w32inevt.c (faked_key): Define globally, not statically.
321 (w32_kbd_mods_to_emacs, w32_kbd_patch_key, faked_key)
322 (w32_console_toggle_lock_key): Move to w32fns.c.
323
324 * w32menu.c: Include setjmp.h. NTGUI_UNICODE changes throughout.
325
326 * w32proc.c (_DebPrint): Move to w32fns.c.
327 * w32select.c: Include string.h, stdio.h for Cygwin.
328 * w32select.h: New File.
329
330 * w32term.c: Include io.h for non-CYGWIN builds; needed for
331 get_osfhandle.
332 (w32_message_fd): New variable. Under Cygwin, holds the file
333 descriptor the system used to tell us about pending thread
334 messages.
335
336 (w32_init_term): Remove incorrect calls to fcntl and init_sigio
337 that prevented compilation under non-WINDOWSNT systems.
338
339 (w32_initialize): Open /dev/windows and assign it to
340 w32_message_fd. Provide w32 feature.
341
342 * w32term.h: Include frame.h, atimer.h. Declare various frame functions.
343 (WM_EMACS_INPUT_READY): add.
344 (prepend_msg, w32_message_fd): Declare globally.
345
346 * w32xfns.c:
347 (keyboard_handle): Use only when WINDOWSNT.
348 (notify_msg_ready): New function. Posts a message to the main
349 thread's message queue under CYGWIN, which wakes up the main
350 thread from select(2) by making the /dev/windows file descriptor
351 ready. Under WINDOWSNT, it sets an event the same way the old
352 code did.
353
354 (post, prepend_msg): Actually call notify_msg_ready instead of
355 setting the input event directly.
356
98daa893
EZ
3572012-10-07 Eli Zaretskii <eliz@gnu.org>
358
359 * ralloc.c (relinquish): If a heap is ready to be relinquished,
360 but it still has blocs in it, don't return it to the system,
361 instead of aborting. (Bug#12402)
362
3bc0a2f7
JD
3632012-10-07 Jan Djärv <jan.h.d@swipnet.se>
364
8ad5b73b 365 * nsterm.m (ns_dumpglyphs_image): Only draw slice of image (Bug#12506).
493b5b1c 366
335f5ae4
JD
367 * nsterm.m (ns_update_auto_hide_menu_bar): Remove defintion of
368 MAC_OS_X_VERSION_10_6.
8ad5b73b
JD
369 (syms_of_nsterm): Remove comment about Panther and above for
370 ns-antialias-text.
335f5ae4
JD
371 * nsterm.h (MAC_OS_X_VERSION_10_3, onTiger): Remove.
372 (EmacsApp): Remove check for >= MAC_OS_X_VERSION_10_4.
373 (struct nsfont_info): Remove check for >= MAC_OS_X_VERSION_10_3.
374
375 * nsselect.m (ns_string_from_pasteboard): Remove check for >=
376 MAC_OS_X_VERSION_10_4.
377
8ad5b73b
JD
378 * nsmenu.m (fillWithWidgetValue:): Remove code for <
379 MAC_OS_X_VERSION_10_2.
335f5ae4
JD
380
381 * nsimage.m (setPixmapData, getPixelAtX, setAlphaAtX): Remove onTiger.
382
383 * nsfns.m (Fns_list_services): Remove comment and check for OSX < 10.4.
384 (ns_do_applescript): Remove check for >= MAC_OS_X_VERSION_10_4.
385
3bc0a2f7
JD
386 * nsterm.m (ns_in_resize): Remove (Bug#12479).
387 (ns_resize_handle_rect, mouseDown, mouseUp, mouseDragged): Remove.
8ad5b73b
JD
388 (ns_clear_frame, sendEvent, windowDidResize, drawRect:): Remove
389 ns_in_resize check.
3bc0a2f7
JD
390 (ns_clear_frame_area): Remove resize handle code.
391
392 * nsfns.m (ns_in_resize): Remove.
8ad5b73b
JD
393 (x_set_icon_name, ns_set_name, ns_set_name_as_filename): Remove
394 ns_in_resize check.
3bc0a2f7 395
c622b48f
PE
3962012-10-07 Paul Eggert <eggert@cs.ucla.edu>
397
398 Improve sys_siglist detection.
399 * sysdep.c (sys_siglist, init_signals): Use _sys_siglist if it's
400 defined as a macro, as is done in Solaris.
401 (sys_siglist_entries): New macro.
402 (save_strsignal): Use it.
403 * syssignal.h (safe_strsignal): Now ATTRIBUTE_CONST, to pacify
404 GCC 4.7.2 on Fedora 17 with the fixed sys_siglist detection.
405
04fafa46
JD
4062012-10-06 Jan Djärv <jan.h.d@swipnet.se>
407
408 * nsfns.m (Fx_create_frame): Call x_default_parameter with
409 fullscreen/Fullscreen.
410
411 * nsterm.h (EmacsView): Rename tbar_height to tibar_height.
412 tobar_height is new.
413
414 * nsterm.m (x_make_frame_visible): Check for fullscreen.
415 (ns_fullscreen_hook): Activate old style fullscreen with a timer.
416 (ns_term_init): Set activateIgnoringOtherApps if old style fullscreen.
417 (windowDidResize:): Check for correct window if old style fullscreen.
418 Capitalize word in comment. Remove incorrect comment.
419 (initFrameFromEmacs:): tbar_height renamed tibar_height.
420 (windowDidEnterFullScreen:): Toggle toolbar for fullscreen to fix
421 error in drawing background.
422 (toggleFullScreen:): Remove comment. Rearrange calls.
423 Set toolbar values to zero, save old height in tobar_height.
424 Restore tool bar height when leaving fullscreen.
425 (canBecomeMainWindow): New function.
426
c6e21c03
PE
4272012-10-06 Paul Eggert <eggert@cs.ucla.edu>
428
429 * keyboard.c (read_char): Remove unnecessary 'volatile's and label.
430
0d9f584b
EZ
4312012-10-05 Eli Zaretskii <eliz@gnu.org>
432
a65fbb5f
EZ
433 * w32proc.c (stop_timer_thread): Fix declaration of 'err'.
434
0d9f584b
EZ
435 * w32.c (utime): Open the file with FILE_FLAG_BACKUP_SEMANTICS, so
436 that time stamps of directories could also be changed. Don't
437 request the too broad GENERIC_WRITE, only the more restrictive
438 FILE_WRITE_ATTRIBUTES access rights.
439
440 * fileio.c (Fset_file_times): Special-case ignoring errors for
441 directories only on MSDOS, not on MS-Windows.
442
e8757f09 4432012-10-05 Ikumi Keita <ikumi@ikumi.que.jp> (tiny change)
ca347e3d
IK
444
445 * minibuf.c (Fcompleting_read): Doc fix. (Bug#12555)
446
7604f298
EZ
4472012-10-04 Eli Zaretskii <eliz@gnu.org>
448
449 * w32.c (utime): Test for INVALID_HANDLE_VALUE, not for NULL, to
450 see whether CreateFile failed.
451
88d69b7d
PE
4522012-10-04 Paul Eggert <eggert@cs.ucla.edu>
453
454 * profiler.c (handle_profiler_signal): Inhibit pending signals too,
455 to avoid similar races.
456 * keyboard.c (pending_signals): Now bool, not int.
457
7509f454
PE
458 Port timers to OpenBSD, plus check for timer failures.
459 OpenBSD problem reported by Han Boetes.
460 * profiler.c (setup_cpu_timer): Check for failure of timer_settime
461 and/or setitimer.
462 (Fprofiler_cpu_stop): Don't assume HAVE_SETITIMER.
463 * syssignal.h (HAVE_ITIMERSPEC): New macro. This is for platforms
464 like OpenBSD, which has timer_settime but does not declare it.
465 OpenBSD does not define SIGEV_SIGNAL, so use that when deciding
466 whether to use itimerspec-related primitives. All uses of
467 HAVE_TIMER_SETTIME replaced with HAVE_ITIMERSPEC.
468
a3c5c0c5
PE
4692012-10-02 Paul Eggert <eggert@cs.ucla.edu>
470
471 * profiler.c (handle_profiler_signal): Fix a malloc race
472 that caused Emacs to hang on Fedora 17 when profiling Lisp.
473
914e743b
JD
4742012-10-02 Jan Djärv <jan.h.d@swipnet.se>
475
476 * nsterm.m (windowDidEnterFullScreen): Remove fprintf.
477
d8ab37a8
EZ
4782012-10-02 Eli Zaretskii <eliz@gnu.org>
479
480 * w32proc.c (sys_wait): Declare 'signame' 'const char *', to be
481 consistent with the change in return value of 'safe_strsignal'.
482
b3ecad33
PE
4832012-10-02 Paul Eggert <eggert@cs.ucla.edu>
484
0a99eee1
PE
485 Prefer plain 'static' to 'static inline' (Bug#12541).
486 * bidi.c (bidi_get_type, bidi_check_type, bidi_get_category)
487 (bidi_set_sor_type, bidi_push_embedding_level)
488 (bidi_pop_embedding_level, bidi_remember_char, bidi_copy_it)
489 (bidi_cache_reset, bidi_cache_shrink, bidi_cache_fetch_state)
490 (bidi_cache_search, bidi_cache_ensure_space)
491 (bidi_cache_iterator_state, bidi_cache_find)
492 (bidi_peek_at_next_level, bidi_set_paragraph_end)
493 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
494 (bidi_explicit_dir_char, bidi_resolve_neutral_1):
495 Now 'static', not 'static inline'.
496
b3ecad33
PE
497 Count overruns when profiling; change units to ns.
498 * profiler.c (handle_profiler_signal): Count sampling intervals, not ms.
499 Give extra weight to samples after overruns, to attempt to count
500 the time more accurately.
501 (setup_cpu_timer): Change sampling interval units from ms to ns, since
502 the underlying primitives nominally do ns.
503 (Fprofiler_cpu_start): Document the change. Mention that
504 the sampling intervals are only approximate.
505
090cf9db
SM
5062012-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
507
508 * frame.c (Fmake_terminal_frame): Prefer safer CONSP over !NILP.
509
510 * coding.h (ENCODE_FILE, DECODE_FILE, DECODE_SYSTEM): Remove special
511 case for the special 0 coding-system.
512
513 * buffer.c (Fset_buffer_multibyte): Signal an error instead of widening.
514 (Fmake_overlay): Remove redundant tests.
64edc777 515 (fix_start_end_in_overlays): Remove redundant recentering.
090cf9db 516
81550bf4
JB
5172012-10-02 Juanma Barranquero <lekktu@gmail.com>
518
519 * makefile.w32-in ($(BLD)/alloc.$(O), $(BLD)/gmalloc.$(O)):
520 Update dependencies.
521
aa1ba90e
PE
5222012-10-01 Paul Eggert <eggert@cs.ucla.edu>
523
524 Fix a malloc race condition involving strsignal.
525 A signal can arrive in the middle of a malloc, and Emacs's signal
526 handler can invoke strsignal, which can invoke malloc, which is
527 not portable. This race condition bug makes Emacs hang on GNU/Linux.
528 Fix it by altering the signal handler so that it does not invoke
529 strsignal.
530 * emacs.c (shut_down_emacs): Use safe_strsignal, not strsignal.
531 * process.c (status_message): Use const pointer, in case strsignal
532 is #defined to safe_strsignal.
533 * sysdep.c (sys_siglist, init_signals): Always define and
534 initialize a substitute sys_siglist if the system does not define
535 one, even if HAVE_STRSIGNAL.
536 (safe_strsignal): Rename from strsignal. Always define,
537 using sys_siglist. Return a const pointer.
538 * syssignal.h (safe_strsignal): New decl.
539 (strsignal) [!HAVE_STRSIGNAL]: Define in terms of safe_strsignal.
540
ace917bd
EZ
5412012-10-01 Eli Zaretskii <eliz@gnu.org>
542
543 * w32proc.c (timer_loop): Fix code that waits for timer
544 expiration, to avoid high CPU usage.
545
9eb71b9c
SM
5462012-10-01 Stefan Monnier <monnier@iro.umontreal.ca>
547
548 * fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
549 (sweep_weak_table): Remove redundant prototypes.
550
b3317662
FP
5512012-10-01 Fabrice Popineau <fabrice.popineau@gmail.com>
552
553 * emacs.c: Move the inclusion of TERM_HEADER after including
554 windows.h on WINDOWSNT. This avoids compilation problems with
555 MSVC.
556
f0e5f225
EZ
5572012-10-01 Eli Zaretskii <eliz@gnu.org>
558
2d7d1608
EZ
559 * unexw32.c (OFFSET_TO_RVA, RVA_TO_OFFSET)
560 (RVA_TO_SECTION_OFFSET): Encode all macro arguments in parentheses.
561 (RVA_TO_PTR): Cast the result of RVA_TO_OFFSET to 'unsigned char *',
562 as the previous version used 'void *'.
563
564 * ralloc.c (ROUNDUP): Fix last change.
565 (MEM_ROUNDUP): Don't cast MEM_ALIGN, it is already of type
566 'size_t'.
567
f0e5f225
EZ
568 * w32proc.c <disable_itimers>: New static flag.
569 (init_timers): Initialize it to zero, after creating the critical
570 sections used by the timer threads.
571 (term_timers): Set to 1 before deleting the critical sections.
572 (getitimer, setitimer): If disable_itimers is non-zero, return an
573 error indication without doing anything. Reported by Fabrice
574 Popineau <fabrice.popineau@supelec.fr> as part of bug#12544.
4cdfbb89
EZ
575 (alarm) [HAVE_SETITIMER]: Be more conformant to the expected
576 return results.
577 [!HAVE_SETITIMER]: Behave as the previous version that didn't
578 support timers.
f0e5f225
EZ
579
580 * emacs.c (shut_down_emacs) [WINDOWSNT]: Move the call to
581 term_ntproc after all the other bookkeeping, to get timers working
582 as long as possible.
583
82ef37c1
PE
5842012-10-01 Paul Eggert <eggert@cs.ucla.edu>
585
b3a4c387
PE
586 * xdisp.c (syms_of_xdisp): Default message-log-max to 1000, not 100.
587 Suggested by Juri Linkov in
588 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00821.html>.
589
b0ab8123
PE
590 Prefer plain 'static' to 'static inline' (Bug#12541).
591 With static functions, modern compilers inline pretty well by
592 themselves; advice from programmers often hurts as much as it helps.
593 On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
594 this change shrinks the text size of the Emacs executable by 1.1%
595 without affecting CPU significantly in my benchmark.
596 * alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
597 (live_float_p, live_misc_p, live_vector_p, live_buffer_p)
598 (mark_maybe_object, mark_maybe_pointer, bounded_number):
599 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
600 (bset_auto_fill_function, bset_auto_save_file_format)
601 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
602 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
603 (bset_cache_long_line_scans, bset_case_fold_search)
604 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
605 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
606 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
607 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
608 (bset_header_line_format, bset_indicate_buffer_boundaries)
609 (bset_indicate_empty_lines, bset_invisibility_spec)
610 (bset_left_fringe_width, bset_major_mode, bset_mark)
611 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
612 (bset_name, bset_overwrite_mode, bset_pt_marker)
613 (bset_right_fringe_width, bset_save_length)
614 (bset_scroll_bar_width, bset_scroll_down_aggressively)
615 (bset_scroll_up_aggressively, bset_selective_display)
616 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
617 (bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
618 (set_buffer_overlays_after):
619 * category.c (bset_category_table):
620 * charset.c (read_hex):
621 * coding.c (produce_composition, produce_charset)
622 (handle_composition_annotation, handle_charset_annotation)
623 (char_encodable_p):
624 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
625 (assign_row, set_frame_matrix_frame, make_current)
626 (add_row_entry):
627 * eval.c (set_specpdl_symbol, set_specpdl_old_value):
628 * fns.c (maybe_resize_hash_table):
629 * frame.c (fset_buffer_predicate, fset_minibuffer_window):
630 * gmalloc.c (register_heapinfo):
631 * image.c (lookup_image_type):
632 * intervals.c (set_interval_object, set_interval_left)
633 (set_interval_right, copy_interval_parent, rotate_right)
634 (rotate_left, balance_possible_root_interval):
635 * keyboard.c (kset_echo_string, kset_kbd_queue)
636 (kset_keyboard_translate_table, kset_last_prefix_arg)
637 (kset_last_repeatable_command, kset_local_function_key_map)
638 (kset_overriding_terminal_local_map, kset_real_last_command)
639 (kset_system_key_syms, clear_event, set_prop):
640 * lread.c (digit_to_number):
641 * marker.c (attach_marker, live_buffer, set_marker_internal):
642 * nsterm.m (ns_compute_glyph_string_overhangs):
643 * process.c (pset_buffer, pset_command)
644 (pset_decode_coding_system, pset_decoding_buf)
645 (pset_encode_coding_system, pset_encoding_buf, pset_filter)
646 (pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
647 (pset_status, pset_tty_name, pset_type, pset_write_queue):
648 * syntax.c (bset_syntax_table, dec_bytepos):
649 * terminal.c (tset_param_alist):
650 * textprop.c (interval_has_some_properties)
651 (interval_has_some_properties_list):
652 * window.c (wset_combination_limit, wset_dedicated)
653 (wset_display_table, wset_hchild, wset_left_fringe_width)
654 (wset_left_margin_cols, wset_new_normal, wset_new_total)
655 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
656 (wset_right_fringe_width, wset_right_margin_cols)
657 (wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
658 (wset_vertical_scroll_bar_type, wset_window_parameters):
659 * xdisp.c (wset_base_line_number, wset_base_line_pos)
660 (wset_column_number_displayed, wset_region_showing)
661 (window_box_edges, run_window_scroll_functions)
662 (append_glyph_string_lists, prepend_glyph_string_lists)
663 (append_glyph_string, set_glyph_string_background_width)
664 (append_glyph, append_composite_glyph)
665 (take_vertical_position_into_account):
666 * xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
667 (face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
668 (lface_hash, lface_same_font_attributes_p, lookup_face):
669 * xml.c (libxml2_loaded_p):
670 * xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
671 (x_set_glyph_string_clipping, x_clear_glyph_string_rect):
672 Now 'static', not 'static inline'.
673
05584c31
PE
674 * bidi.c: Tune.
675 (bidi_copy_it): Do the whole copy with a single memcpy.
676 (bidi_char_at_pos): Merge the two STRING_CHAR calls into one.
677
86ec63ba
PE
678 Revert the FOLLOW-SYMLINKS change for file-attributes.
679 Doing it right would require several changes to Tramp, and there's
680 not enough time to get that tested before the freeze today.
681 * dired.c (directory_files_internal, Ffile_attributes):
682 Undo last change.
683
82ef37c1
PE
684 * frame.c (x_report_frame_params): Port better to wider ints.
685 Do not assume that EMACS_UINT is the same width as uprintmax_t,
686 or that pointers can be printed in 15 decimal digits.
687 Avoid GCC warnings if EMACS_UINT is wider than a pointer.
688
62aba0d4
FP
6892012-09-30 Fabrice Popineau <fabrice.popineau@supelec.fr>
690
691 Support x64 build on MS-Windows.
692 * w32term.h (SCROLL_BAR_PACK, SCROLL_BAR_UNPACK): Define for x64.
693 (SET_SCROLL_BAR_W32_WINDOW): Cast ID to intptr_t, for
694 compatibility with x64.
5e4daaf3 695 (x_get_focus_frame): Add prototype.
62aba0d4
FP
696
697 * w32term.c (w32_draw_underwave): Don't use GCC extensions for
698 defining an XRectangle structure.
699
700 * w32proc.c (RVA_TO_PTR, w32_executable_type): Fix pointer
701 arithmetics for compatibility with x64.
702
703 * w32menu.c (add_menu_item): Use UINT_PTR instead of UINT, for
704 compatibility with x64.
705
706 * w32heap.h: Adjust prototypes and declarations.
707
708 * w32heap.c (RVA_TO_PTR, allocate_heap, sbrk, init_heap)
709 (round_heap): Use DWORD_PTR, ptrdiff_t and size_t instead of
710 DWORD, long, and unsigned long, for compatibility with x64.
711 (allocate_heap) [_WIN64]: Reserve 32GB of memory.
712 (sbrk): Argument is now of type ptrdiff_t.
713
714 * w32fns.c (HMONITOR): Condition declaration on _WIN32_WINNT being
715 less than 0x0500.
716 (w32_msg_pump): Use WPARAM type for 'result'.
717
718 * w32.c (init_environment, get_emacs_configuration): Support AMD64
719 architecture.
720 (init_ntproc): Cast arguments of _open_osfhandle to intptr_t, for
721 compatibility with x64.
722
723 * vm-limit.c (lim_data): Now size_t.
724 (check_memory_limits): Adjust prototypes of real_morecore and
725 __morecore to receive argument of type ptrdiff_t. Use size_t for
726 five_percent and data_size.
727
728 * unexw32.c: Use DWORD_PTR instead of DWORD for file-scope
729 variables, for compatibility with x64.
730 (rva_to_section, offset_to_section, relocate_offset)
731 (OFFSET_TO_RVA, RVA_TO_OFFSET, RVA_TO_SECTION_OFFSET)
732 (PTR_TO_RVA, RVA_TO_PTR, OFFSET_TO_PTR, get_section_info)
733 (copy_executable_and_dump_data): Use DWORD_PTR instead of DWORD
734 for compatibility with x64.
735
736 * sysdep.c (STDERR_FILENO): Define if not already defined.
737
738 * ralloc.c (real_morecore): Argument type is now ptrdiff_t.
739 (__morecore): Argument type is now ptrdiff_t.
740 (ROUNDUP, MEM_ROUNDUP): Use size_t instead of 'unsigned long'.
741 (relinquish): Use ptrdiff_t type for 'excess'.
742 (r_alloc_sbrk): Argument type is now ptrdiff_t.
743
744 * makefile.w32-in (HEAPSIZE): Get value from EMACS_HEAPSIZE.
745 (bootstrap-temacs-CMD, bootstrap-temacs-SH): Use $(EMACS_PURESIZE)
746 instead of a literal number.
747
748 * gmalloc.c [WINDOWSNT]: Include w32heap.h.
749 (min): Define only if not already defined.
750
751 * frame.c (x_report_frame_params): Use EMACS_UINT for the return
752 value of FRAME_X_WINDOW, to fit a 64-bit pointer on 64-bit Windows
753 hosts.
754
755 * image.c (x_bitmap_pixmap): Return ptrdiff_t, not int, since
756 'bitmaps' is a pointer.
757
758 * dispextern.h (x_bitmap_pixmap): Adjust prototype.
759
760 * alloc.c (gdb_make_enums_visible): Now conditional on __GNUC__.
761
e7a2937b
PE
7622012-09-30 Paul Eggert <eggert@cs.ucla.edu>
763
764 file-attributes has a new optional arg FOLLOW-SYMLINKS.
765 * dired.c (directory_files_internal, Ffile_attributes):
766 New arg follow_symlinks. All uses changed.
767
b43d62ae
SM
7682012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
769
770 * .gdbinit (xbacktrace): Adjust to recent "struct backtrace" change.
771
c06c382a
EZ
7722012-09-30 Eli Zaretskii <eliz@gnu.org>
773
774 Support atimers and CPU profiler via profile.c on MS-Windows.
775 * w32proc.c (sig_mask, crit_sig): New static variables.
776 (sys_signal): Support SIGALRM and SIGPROF.
777 (sigemptyset, sigaddset, sigfillset, sigprocmask)
b43d62ae 778 (pthread_sigmask, setpgrp): Move here from w32.c. sigaddset,
c06c382a
EZ
779 sigfillset, and sigprocmask are no longer no-ops.
780 (sigismember): New function.
781 (struct itimer_data): New definition.
782 (ticks_now, real_itimer, prof_itimer, clocks_min, crit_real)
783 (crit_prof): New static variables.
784 (MAX_SINGLE_SLEEP): New definition.
785 (timer_loop, stop_timer_thread, term_timers, init_timers)
786 (start_timer_thread, getitimer, setitimer): New functions.
787 (alarm): No longer a no-op, calls setitimer.
788
789 * w32.c (term_ntproc): Call term_timers.
790 (init_ntproc): Make sure all signals are unblocked at startup, to
791 erase any traces of dumping. Call init_timers.
792
793 * w32fns.c (hourglass_timer, HOURGLASS_ID): Remove.
794 Windows-specific code to display the hourglass mouse pointer is no
795 longer used.
796 (w32_wnd_proc): Remove code that handled the WM_TIMER message due
797 to hourglass timer expiration.
798 (start_hourglass, cancel_hourglass, DEFAULT_HOURGLASS_DELAY):
799 Remove, no longer used.
b43d62ae
SM
800 (w32_note_current_window, show_hourglass, hide_hourglass):
801 New functions, in support of hourglass cursor display similar to other
c06c382a
EZ
802 window systems.
803 (syms_of_w32fns): Don't initialize hourglass_timer.
804
805 * xdisp.c (start_hourglass, cancel_hourglass): Now used on
806 WINDOWSNT as well.
807 (start_hourglass) [WINDOWSNT]: Call w32_note_current_window.
808
809 * w32.h (init_timers, term_timers): Add prototypes.
810
95402d5f
KH
8112012-09-30 Kenichi Handa <handa@gnu.org>
812
813 * coding.c (decode_coding_ccl, encode_coding_ccl): Pay attention
814 to the buffer relocation which may be caused by ccl_driver.
815
dd946752
JD
8162012-09-30 Jan Djärv <jan.h.d@swipnet.se>
817
d7e642cc
JD
818 * xfns.c (Fx_file_dialog): Update comment.
819
820 * w32fns.c (Fx_file_dialog): Update comment.
821
822 * nsfns.m (Fns_read_file_name): Add argument DIR_ONLY_P.
823 Initialize panel name field if OSX >= 10.6.
824
825 * fileio.c (Fnext_read_file_uses_dialog_p): Add HAVE_NS.
826
dd946752
JD
827 * nsfns.m (ns_frame_parm_handlers): Add x_set_fullscreen.
828
829 * nsterm.m (NEW_STYLE_FS): New define.
830 (ns_fullscreen_hook, windowWillEnterFullScreen)
831 (windowDidEnterFullScreen, windowWillExitFullScreen)
832 (windowDidExitFullScreen, toggleFullScreen, handleFS)
833 (setFSValue): New functions.
834 (EmacsFSWindow): New implementation.
835 (canBecomeKeyWindow): New function for EmacsFSWindow.
836 (ns_create_terminal): Set fullscreen_hook to ns_fullscreen_hook.
837 (dealloc): Release nonfs_window if in fullscreen.
838 (updateFrameSize:): Call windowDidMove to update top/left.
839 (windowWillResize:toSize:): Check if frame is still maximized.
840 (initFrameFromEmacs:): Initialize fs_state, fs_before_fs,
841 next_maximized, maximized_width, maximized_height and nonfs_window.
842 Call setCollectionBehavior if NEW_STYLE_FS. Initialize bwidth and
843 tbar_height.
844 (windowWillUseStandardFrame:defaultFrame:): Update frame parameter
845 fullscreen. Set maximized_width/height. Act on next_maximized.
846
847 * nsterm.h (MAC_OS_X_VERSION_10_7, MAC_OS_X_VERSION_10_8): New.
848 (EmacsView): Add variables for fullscreen.
849 (handleFS, setFSValue, toggleFullScreen): New in EmacsView.
850 (EmacsFSWindow): New interface for fullscreen.
851
427730eb
JB
8522012-09-30 Juanma Barranquero <lekktu@gmail.com>
853
854 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
855
48de8b12
CY
8562012-09-30 Chong Yidong <cyd@gnu.org>
857
858 * fns.c (Frandom): Doc fix.
859
5938d519
MR
8602012-09-30 Martin Rudalics <rudalics@gmx.at>
861
862 * window.c (Vwindow_combination_limit): New default value.
863 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
864
cb5b0266
PE
8652012-09-30 Paul Eggert <eggert@cs.ucla.edu>
866
867 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
868 Suggested by Eli Zaretskii in
869 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
870
84f72efd
EZ
8712012-09-30 Eli Zaretskii <eliz@gnu.org>
872
873 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
874 HAVE_TIMER_SETTIME is defined.
875
9d4dcdc9
PE
8762012-09-30 Paul Eggert <eggert@cs.ucla.edu>
877
d89460ed
PE
878 Profiler improvements: more-accurate timers, overflow checks.
879 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
880 signal.h, setjmp.h. Include systime.h instead.
881 (saturated_add): New function.
882 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
883 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
884 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
885 New static vars.
84f72efd 886 (enum profiler_cpu_running): New enum.
d89460ed
PE
887 (profiler_cpu_running): Now of that enum type, not bool.
888 All uses changed to store the new value.
889 (handle_profiler_signal): Rename from sigprof_handler_1,
890 for consistency with other handlers. Do not check whether
891 cpu_log is a hash-table if garbage collecting, since it
892 doesn't matter in that case.
893 (deliver_profiler_signal): Rename from sigprof_handler,
894 for consistency with other handlers.
895 (setup_cpu_timer): New function, with much of what used to be in
896 Fprofiler_cpu_start. Check for out-of-range argument.
897 Prefer timer_settime if available, and prefer
898 thread cputime clocks, then process cputime clocks, then
899 monotonic clocks, to the old realtime clock. Use make_timeval
900 to round more-correctly when falling back to setitimer.
901 (Fprofiler_cpu_start): Use it.
902 (Fprofiler_cpu_stop): Prefer timer_settime if available.
903 Don't assume that passing NULL as the 2nd argument of setitimer
904 is the same as passing a pointer to all-zero storage.
905 Ignore SIGPROF afterwards.
906 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
907 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
908 non-fatal signal handlers. Ignore SIGPROF on startup.
909 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
910 in profiler.c, since sysdep.c now uses it.
911
9d4dcdc9
PE
912 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
913 Suggested by Eli Zaretskii in
914 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
915
8e5691a0
JB
9162012-09-29 Juanma Barranquero <lekktu@gmail.com>
917
918 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
919
e7c1b6ef
SM
9202012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
921
922 * lisp.h (struct backtrace): Remove indirection for `function' field.
923 * xdisp.c (redisplay_internal):
924 * profiler.c (record_backtrace, sigprof_handler_1):
925 * alloc.c (Fgarbage_collect):
926 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
927 (Fbacktrace_frame): Adjust accordingly.
928
e61d39cd 9292012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
930
931 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
932 (Frun_hook_with_args_until_failure): Doc fixes.
933
404043ea
EZ
9342012-09-28 Eli Zaretskii <eliz@gnu.org>
935
936 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
937 Qautomatic_redisplay and change the symbol name. All users changed.
938
704d3f45
TM
9392012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
940
941 * profiler.c (sigprof_handler): Fix race condition.
942
757140ff
GM
9432012-09-28 Glenn Morris <rgm@gnu.org>
944
945 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
946
a615a3ae
PE
9472012-09-27 Paul Eggert <eggert@cs.ucla.edu>
948
949 Check more robustly for timer_settime.
89d17fd0
PE
950 * Makefile.in (LIB_TIMER_TIME): New macro.
951 (LIBES): Add it.
a615a3ae
PE
952 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
953 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
954 call timer_settime.
955
3670daf7
TM
9562012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
957
958 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
959
6a586b7f
JB
9602012-09-26 Juanma Barranquero <lekktu@gmail.com>
961
962 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
963
41c8bfcf
PE
9642012-09-26 Paul Eggert <eggert@cs.ucla.edu>
965
966 * character.h (MAYBE_UNIFY_CHAR): Remove.
967 * charset.c, charset.h (maybe_unify_char): Now static.
968 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
969 Since this stuff is now private to charset.c, there's no need for
970 a public macro and no need to inline by hand.
971
3a880af4
SM
9722012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
973 Stefan Monnier <monnier@iro.umontreal.ca>
974 Juanma Barranquero <lekktu@gmail.com>
611b7507 975
3a880af4
SM
976 * profiler.c: New file.
977 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
978 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
979 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
980 * emacs.c (main): Call syms_of_profiler.
981 * alloc.c (Qautomatic_gc): New constant.
982 (MALLOC_PROBE): New macro.
983 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
984 (total_bytes_of_live_objects): New function.
985 (Fgarbage_collect): Use it. Record itself in backtrace_list.
986 Call malloc_probe for the memory profiler.
987 (syms_of_alloc): Define Qautomatic_gc.
988 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
989 race condition.
990 (struct backtrace): Move definition...
991 * lisp.h (struct backtrace): ..here.
992 (Qautomatic_gc, profiler_memory_running): Declare vars.
993 (malloc_probe, syms_of_profiler): Declare functions.
994 * xdisp.c (Qautomatic_redisplay): New constant.
995 (redisplay_internal): Record itself in backtrace_list.
996 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 997
5938d519 9982012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
9992012-09-25 Juanma Barranquero <lekktu@gmail.com>
1000
1001 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
1002
e26fd2e4
PE
10032012-09-25 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 Prefer POSIX timers if available.
1006 They avoid a race if the timer is too close to the current time.
1007 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
1008 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 1009 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 1010
eedec3ee
EZ
10112012-09-25 Eli Zaretskii <eliz@gnu.org>
1012
1013 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
1014 CHAR_STRING_ADVANCE.
1015 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
1016 STRING_CHAR_ADVANCE.
1017
aa15c6bb
JB
10182012-09-25 Juanma Barranquero <lekktu@gmail.com>
1019
1020 Move Vlibrary_cache to emacs.c and reset before dumping.
1021
1022 * lisp.h (reset_image_types): Declare.
1023 [WINDOWSNT] (Vlibrary_cache): Declare.
1024
1025 * image.c (reset_image_types): New function.
1026
1027 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
1028 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
1029 (Fdump_emacs): Reset Vlibrary_cache and image_types.
1030
1031 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
1032 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
1033
1034 * w32.h (Vlibrary_cache): Do not declare.
1035
54d629be
EZ
10362012-09-25 Eli Zaretskii <eliz@gnu.org>
1037
16b22fef
EZ
1038 * w32proc.c (sys_signal): Handle all signals defined by the
1039 MS-Windows runtime, not just SIGCHLD. Actually install the signal
1040 handlers for signals supported by Windows. Don't override
1041 term_ntproc as the handler for SIGABRT.
1042 (sigaction): Rewrite to call sys_signal instead of duplicating its
1043 code.
1044 (sys_kill): Improve commentary.
1045
1046 * w32.c (term_ntproc): Accept (and ignore) one argument, for
1047 consistency with a signature of a signal handler. All callers
1048 changed.
1049 (init_ntproc): Accept an argument DUMPING. If dumping, don't
1050 install term_ntproc as a signal handler for SIGABRT, as that
1051 should be done by the dumped Emacs.
1052
1053 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
1054
1055 * w32select.c (term_w32select): Protect against repeated
1056 invocation by setting clipboard_owner to NULL after calling
1057 DestroyWindow.
1058
1059 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
1060 and term_ntproc to their modified signatures.
1061
54d629be
EZ
1062 * character.c (char_string, string_char): Remove calls to
1063 MAYBE_UNIFY_CHAR. See the discussion starting at
1064 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
1065 for the details.
1066
59f7af81
CY
10672012-09-25 Chong Yidong <cyd@gnu.org>
1068
1069 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
1070
22e8cf4a
SM
10712012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
1072
1073 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
1074 when encountering an unknown bytecode.
1075
578098f3
PE
10762012-09-24 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 image.c, indent.c: Use bool for booleans.
1079 * dispextern.h (struct image_type): Members valid_p, load, init
1080 now return bool, not int. All uses changed.
1081 * image.c: Omit unnecessary static decls.
1082 (x_create_bitmap_mask, x_build_heuristic_mask):
1083 Return void, not int, since callers don't care about the return value.
1084 (x_create_bitmap_mask, define_image_type, valid_image_p)
1085 (struct image_keyword, parse_image_spec, image_spec_value)
1086 (check_image_size, image_background)
1087 (image_background_transparent, x_clear_image_1)
1088 (postprocess_image, lookup_image, x_check_image_size)
1089 (x_create_x_image_and_pixmap, xbm_image_p)
1090 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
1091 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
1092 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
1093 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
1094 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
1095 (png_image_p, init_png_functions, png_load_body, png_load)
1096 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
1097 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
1098 (init_gif_functions, gif_load, imagemagick_image_p)
1099 (imagemagick_load_image, imagemagick_load, svg_image_p)
1100 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
1101 (gs_load):
1102 * nsimage.m (ns_load_image):
1103 * nsterm.m (ns_defined_color):
1104 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
1105 * xfns.c (x_defined_color):
1106 * xterm.c (x_alloc_lighter_color_for_widget)
1107 (x_alloc_nearest_color_1, x_alloc_nearest_color)
1108 (x_alloc_lighter_color):
1109 * indent.c (disptab_matches_widthtab, current_column)
1110 (scan_for_column, string_display_width, indented_beyond_p)
1111 (compute_motion, vmotion, Fvertical_motion):
1112 Use bool for booleans.
1113
a5f2b6ec
CY
11142012-09-24 Chong Yidong <cyd@gnu.org>
1115
1116 * chartab.c (Fset_char_table_default): Obsolete function removed.
1117
18e27ea8
PE
11182012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1119
afea8a8a
PE
1120 Move pid_t related decls out of lisp.h.
1121 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
1122 (interruptible_wait_for_termination):
1123 Move these decls from lisp.h to syswait.h, since they use pid_t.
1124 Needed on FreeBSD; see Herbert J. Skuhra in
1125 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
1126 * callproc.c: Include syswait.h.
1127
18e27ea8
PE
1128 gnutls.c, gtkutil.c: Use bool for boolean.
1129 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
1130 (emacs_gnutls_handle_error):
1131 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
1132 (xg_hide_tooltip, xg_create_frame_widgets)
1133 (create_dialog, xg_uses_old_file_dialog)
1134 (xg_get_file_with_chooser, xg_get_file_with_selection)
1135 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
1136 (xg_item_label_same_p, xg_update_menubar)
1137 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
1138 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
1139 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
1140 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
1141 (update_frame_tool_bar, free_frame_tool_bar):
1142 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
1143 * nsmenu.m (ns_update_menubar):
1144 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
1145 * xfns.c (Fx_show_tip) [USE_GTK]:
1146 Use bool for boolean.
1147 * gtkutil.c (xg_update_frame_menubar):
1148 * xmenu.c (update_frame_menubar):
1149 Return void, not int, since caller ignores return value.
1150 * gtkutil.c (xg_change_toolbar_position):
1151 Return void, not 1.
1152
af0e9f75
JB
11532012-09-23 Juanma Barranquero <lekktu@gmail.com>
1154
1155 * makefile.w32-in (BLOCKINPUT_H): Remove.
1156 (SYSSIGNAL_H): New macro.
1157 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
1158 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
1159 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
1160 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
1161 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
1162 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
1163 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
1164 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
1165 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
1166 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
1167 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
1168 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
1169 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
1170 ($(BLD)/w32xfns.$(O)): Update dependencies.
1171
5101529e
EZ
11722012-09-23 Eli Zaretskii <eliz@gnu.org>
1173
1174 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
1175 fatal_error_backtrace.
1176
1177 * w32proc.c (sys_kill): Undo last change: don't do anything when
1178 invoked to deliver SIGABRT to our own process. This is now
1179 handled by emacs_raise.
1180
2c3ee0ad
JB
11812012-09-23 Juanma Barranquero <lekktu@gmail.com>
1182
1183 * w32term.c (w32_read_socket): Remove leftover reference to
1184 interrupt_input_pending.
1185
62a1d661
PE
11862012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 Do not use SA_NODEFER.
1189 Problem reported by Dani Moncayo in
1190 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
1191 * alloc.c (die):
1192 * sysdep.c (emacs_abort): Do not reset signal handler.
1193 * emacs.c (terminate_due_to_signal): Reset signal handler here.
1194 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
1195 wanted even on POSIXish hosts, and it doesn't work on Windows.
1196
a0942b9a
JD
11972012-09-23 Jan Djärv <jan.h.d@swipnet.se>
1198
1199 * xterm.c (x_term_init): Call fixup_locale before and after calling
1200 gtk_init (Bug#12392).
1201
d07ff9db
CY
12022012-09-23 Chong Yidong <cyd@gnu.org>
1203
1204 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
1205 Vdynamic_library_alist.
1206
1207 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
1208 (Fgnutls_available_p): Caller changed.
1209
1210 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
1211 (Flibxml_parse_xml_region): Likewise.
1212
1213 * dispextern.h (struct image_type): Remove arg from init function.
1214
1215 * image.c (Finit_image_library, lookup_image_type)
1216 (define_image_type): Remove now-unneeded second arg.
1217 (init_xpm_functions, init_png_functions, init_jpeg_functions)
1218 (init_tiff_functions, init_gif_functions, init_svg_functions):
1219 Arglist and w32_delayed_load calling convention changed.
1220 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 1221 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 1222
4d7e6e51
PE
12232012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 Simplify and avoid signal-handling races (Bug#12471).
1226 * alloc.c (die):
1227 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
1228 Avoid recursive loop if there's a fatal error in the function itself.
1229 * atimer.c (pending_atimers):
1230 * blockinput.h: Don't include "atimer.h"; no longer needed.
1231 (interrupt_input_pending): Remove. All uses removed.
1232 pending_signals now counts both atimers and ordinary interrupts.
1233 This is less racy than having three separate pending-signal flags.
1234 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
1235 (input_blocked_p):
1236 Rename from their upper-case counterparts BLOCK_INPUT,
1237 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
1238 INPUT_BLOCKED_P, and turn into functions. All uses changed.
1239 This makes it easier to access volatile variables more accurately.
1240 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
1241 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
1242 that's more reliable if the code is buggy and sets
1243 interrupt_input_blocked to a negative value. All uses changed.
1244 * atimer.c (deliver_alarm_signal):
1245 Remove. No need to deliver this to the parent; any thread can
1246 handle this signal now. All uses replaced by underlying handler.
1247 * atimer.c (turn_on_atimers):
1248 * dispnew.c (handle_window_change_signal):
1249 * emacs.c (handle_danger_signal):
1250 * keyboard.c (kbd_buffer_get_event):
1251 Don't reestablish signal handler; not needed with sigaction.
1252 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
1253 (UNBLOCK_INPUT_TO):
1254 Rework to avoid unnecessary accesses to volatile variables.
1255 (UNBLOCK_INPUT_TO): Now a function.
1256 (totally_unblock_input, unblock_input): New decls.
1257 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
1258 (init_data): Remove. Necessary stuff now done in init_signal.
1259 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
1260 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
1261 (fatal_error_code): Remove; no longer needed.
1262 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
1263 it doesn't always backtrace. All uses changed. No need to reset
1264 signal to default, since sigaction and/or die does that for us now.
1265 Use emacs_raise (FOO), not kill (getpid (), FOO).
1266 (main): Check more-accurately whether we're dumping.
1267 Move fatal-error setup to sysdep.c
1268 * floatfns.c: Do not include "syssignal.h"; no longer needed.
1269 * gtkutil.c (xg_get_file_name, xg_get_font):
1270 Remove no-longer-needed signal-mask manipulation.
1271 * keyboard.c, process.c (POLL_FOR_INPUT):
1272 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
1273 * keyboard.c (read_avail_input): Remove.
1274 All uses replaced by gobble_input.
1275 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
1276 (kbd_buffer_store_event_hold, gobble_input):
1277 (record_asynch_buffer_change) [USABLE_SIGIO]:
1278 (store_user_signal_events):
1279 No need to mess with signal mask.
1280 (gobble_input): If blocking input and there are terminals, simply
1281 set pending_signals to 1 and return. All hooks changed to not
1282 worry about whether input is blocked.
1283 (process_pending_signals): Clear pending_signals before processing
1284 them, in case a signal comes in while we're processing.
1285 By convention callers now test pending_signals before calling us.
1286 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
1287 New functions, to support changes to blockinput.h.
1288 (handle_input_available_signal): Now extern.
1289 (reinvoke_input_signal): Remove. All uses replaced by
1290 handle_async_input.
1291 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
1292 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
1293 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
1294 Clear sigmask reliably, even if Fsignal returns, which it can.
1295 Omit unnecessary accesses to volatile var.
1296 (quit_throw_to_read_char): No need to restore sigmask.
1297 * keyboard.c (gobble_input, handle_user_signal):
1298 * process.c (wait_reading_process_output):
1299 Call signal-handling code rather than killing ourselves.
1300 * lisp.h: Include <float.h>, for...
1301 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
1302 (pending_signals): Now volatile.
1303 (syms_of_data): Now const if IEEE floating point.
1304 (handle_input_available_signal) [USABLE_SIGIO]:
1305 (terminate_due_to_signal, record_child_status_change): New decls.
1306 * process.c (create_process): Avoid disaster if memory is exhausted
1307 while we're processing a vfork, by tightening the critical section
1308 around the vfork.
1309 (send_process_frame, process_sent_to, handle_pipe_signal)
1310 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
1311 ignores SIGPIPE.
1312 (send_process): No need for setjmp/longjmp any more, since the
1313 SIGPIPE stuff is now gone. Instead, report an error if errno
1314 is EPIPE.
1315 (record_child_status_change): Now extern. PID and W are now args.
1316 Return void, not bool. All callers changed.
1317 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
1318 Remove. All uses removed. This bug should be fixed now in a
1319 different way.
1320 (wait_for_termination_1): Use waitpid rather than sigsuspend,
1321 and record the child status change directly. This avoids the
1322 need to futz with the signal mask.
1323 (process_fatal_action): Move here from emacs.c.
1324 (emacs_sigaction_flags): New function, containing
1325 much of what used to be in emacs_sigaction_init.
1326 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
1327 caught by emacs, to make races less likely.
1328 (deliver_process_signal): Rename from handle_on_main_thread.
1329 All uses changed.
1330 (BACKTRACE_LIMIT_MAX): Now at top level.
1331 (thread_backtrace_buffer, threadback_backtrace_pointers):
1332 New static vars.
1333 (deliver_thread_signal, deliver_fatal_thread_signal):
1334 New functions, for more-accurate delivery of thread-specific signals.
1335 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
1336 (deliver_arith_signal): Handle in this thread, not
1337 in the main thread, since it's triggered by this thread.
1338 (maybe_fatal_sig): New function.
1339 (init_signals): New arg DUMPING so that we can be more accurate
1340 about whether we're dumping. Caller changed.
1341 Treat thread-specific signals differently from process-general signals.
1342 Block all signals while handling fatal error; that's safer.
1343 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
1344 on IEEE hosts.
1345 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
1346 Ignore SIGPIPE unless batch.
1347 (emacs_backtrace): Output backtrace for the appropriate thread,
1348 which is not necessarily the main thread.
1349 * syssignal.h: Include <stdbool.h>.
1350 (emacs_raise): New macro.
1351 * xterm.c (x_connection_signal): Remove; no longer needed
1352 now that we use sigaction.
1353 (x_connection_closed): No need to mess with sigmask now.
1354 (x_initialize): No need to reset SIGPIPE handler here, since
1355 init_signals does this for us now.
1356
8f4635e9
JD
13572012-09-23 Jan Djärv <jan.h.d@swipnet.se>
1358
1359 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 1360 background rect may be larger (Bug#12245).
8f4635e9 1361
3296976d
CY
13622012-09-23 Chong Yidong <cyd@gnu.org>
1363
1364 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
1365
d41e491e
PE
13662012-09-22 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 * .gdbinit: Just stop at fatal_error_backtrace.
1369 See Stefan Monnier's request in
1370 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
1371 Remove no-longer-used query of system type.
1372
c88b867f
CY
13732012-09-22 Chong Yidong <cyd@gnu.org>
1374
1375 * search.c (Freplace_match): Doc fix (Bug#12325).
1376
1377 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
1378
1379 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
1380 (Fline_end_position): Doc fix.
1381
1382 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
1383
bb4d86b4
CY
13842012-09-22 Chong Yidong <cyd@gnu.org>
1385
1386 * dispextern.h (struct image_type): Add new slot, storing a type
1387 initialization function.
1388
1389 * image.c (define_image_type): Call the image initializer function
1390 if it is defined. Arguments and return value changed.
1391 (valid_image_p, make_image): Callers changed.
1392 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
1393 (gif_type, imagemagick_type, svg_type, gs_type):
1394 Add initialization functions.
bb4d86b4
CY
1395 (Finit_image_library): Call lookup_image_type.
1396 (CHECK_LIB_AVAILABLE): Macro deleted.
1397 (lookup_image_type): Call define_image_type here, rather than via
1398 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
1399 (syms_of_image): Move define_image_type calls for xbm_type and
1400 pbm_type to lookup_image_type.
1401
df9685f3
EZ
14022012-09-22 Eli Zaretskii <eliz@gnu.org>
1403
1404 * keyboard.c (timer_check_2): Move calculation of 'timers' and
1405 'idle_timers' from here ...
1406 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
1407 lists, to avoid infloops when the timer does something stupid,
1408 like reinvoke itself with the same or smaller time-out.
1409 (Bug#12447)
1410
8e17c9ba
MR
14112012-09-22 Martin Rudalics <rudalics@gmx.at>
1412
1413 * window.c (Fsplit_window_internal): Handle only Qt value of
1414 Vwindow_combination_limit separately.
1415 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
1416 (Vwindow_combination_limit): New default value.
1417 Rewrite doc-string.
8e17c9ba 1418
589bd69b
EZ
14192012-09-22 Eli Zaretskii <eliz@gnu.org>
1420
1421 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
1422 the new overlay string. (Bug#10159)
1423
01108e3f
PE
14242012-09-22 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
1427 or that fprintf is async-signal-safe. POSIX doesn't require
1428 either assumption.
1429
82f8cd94
CY
14302012-09-22 Chong Yidong <cyd@gnu.org>
1431
1432 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
1433 (Bug#8207).
1434
3cccbd87
KH
14352012-09-22 Kenichi Handa <handa@gnu.org>
1436
1437 * composite.c (composition_reseat_it): Handle the case that a
1438 grapheme cluster is not covered by a single font (Bug#12352).
1439
09c01941
CY
14402012-09-21 Chong Yidong <cyd@gnu.org>
1441
1442 * image.c (define_image_type): Avoid adding duplicate types to
1443 image_types (Bug#12463). Suggested by Jörg Walter.
1444
acfa068f 14452012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
1446
1447 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
1448 (print_load_command_name): Add case LC_DATA_IN_CODE.
1449 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
1450
acfa068f 14512012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
1452
1453 * eval.c (Frun_hook_with_args_until_success)
1454 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
1455
acfa068f 14562012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
1457
1458 * fileio.c (Ffile_selinux_context): Only call freecon when
1459 lgetfilecon succeeded.
1460 (Fset_file_selinux_context): Likewise. (Bug#12444)
1461
acfa068f 14622012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
1463
1464 * xdisp.c (try_window_reusing_current_matrix): Under bidi
1465 reordering, locate the cursor by calling set_cursor_from_row; if
1466 that fails, clear the desired glyph matrix before returning a
1467 failure indication to the caller. Fixes leaving garbled display
1468 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
1469 (compute_stop_pos_backwards): Fix a typo that caused crashes while
1470 scrolling through multibyte text.
aa36e4d2 1471
e99f70c8
SM
14722012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
1473
1474 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
1475 calling mark_vectorlike since that's the one that marks the window.
1476 (mark_discard_killed_buffers): Mark the final cdr.
1477 * window.h (struct window): Move prev/next_buffers to the
1478 non-standard fields.
1479 * window.c (make_window): Initialize prev/next_buffers manually.
1480
f75beb47
PE
14812012-09-20 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 Omit unused arg EXPECTED from socket hooks.
1484 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
1485 * nsterm.m (ns_term_init):
1486 * termhooks.h (struct terminal.read_socket_hook):
1487 * w32inevt.c (w32_console_read_socket):
1488 * w32term.c (w32_read_socket):
1489 * xterm.c (XTread_socket):
1490 Omit unused arg EXPECTED. All callers changed.
1491 (store_user_signal_events): Return void, not int, since callers no
1492 longer care about the return value. All uses changed.
1493
b019b76a
JB
14942012-09-20 Juanma Barranquero <lekktu@gmail.com>
1495
1496 * w32gui.h (XParseGeometry): Do not declare.
1497
05642592
PE
14982012-09-19 Paul Eggert <eggert@cs.ucla.edu>
1499
e4bce92a
PE
1500 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
1501 Ignore 'expected'. See Eli Zaretskii in
1502 <http://bugs.gnu.org/12471#8> (last line).
1503
05642592
PE
1504 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
1505 (XParseGeometry): Now static. Substitute extremal values for
1506 values that are out of range.
1507
e543ae91
JD
15082012-09-19 Jan Djärv <jan.h.d@swipnet.se>
1509
1510 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
1511
1512 * nsfns.m (XParseGeometry): Remove.
1513 (Fx_create_frame): Call x_set_offset to correctly interpret
1514 top_pos in geometry.
1515
3a880af4 1516 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
1517 (Fx_parse_geometry): If there is a space in string, call
1518 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
1519
45ba16c7
EZ
15202012-09-17 Eli Zaretskii <eliz@gnu.org>
1521
c8b9f1bc
EZ
1522 * search.c (scan_buffer): Use character positions in calls to
1523 region_cache_forward and region_cache_backward, not byte
1524 positions. (Bug#12196)
1525
b4c932a2
EZ
1526 * w32term.c (w32_read_socket): Set pending_signals to 1, like
1527 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
1528
45ba16c7
EZ
1529 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
1530 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
1531 emacs_blocked_malloc, now deleted.
1532
eeceac93
PE
15332012-09-17 Paul Eggert <eggert@cs.ucla.edu>
1534
1535 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
1536 The workaround was for improving performance on Solaris 2.4, but
1537 is getting in the way now. Emacs will still work if someone is
1538 still running Solaris 2.4 in a museum somewhere; Sun dropped
1539 support for Solaris 2.4 in 2003.
1540 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
1541 * process.c (create_process) [HAVE_WORKING_VFORK]:
1542 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
1543 since Emacs no longer uses vfork on that platform.
1544
78f83752
GM
15452012-09-17 Glenn Morris <rgm@gnu.org>
1546
1547 * emacs.c: Use COPYRIGHT.
1548
634b8cac
PE
15492012-09-16 Paul Eggert <eggert@cs.ucla.edu>
1550
0caaedb1
PE
1551 Remove configure's --without-sync-input option (Bug#12450).
1552 When auditing signal-handling in preparation for cleaning it up,
1553 I found that SYNC_INPUT has race conditions and would be a real
1554 pain to fix. Since it's an undocumented and deprecated
1555 configure-time option, now seems like a good time to remove it.
1556 Also see <http://bugs.gnu.org/11080#16>.
1557 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
1558 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
1559 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1560 (malloc_hysteresis):
1561 (check_depth) [XMALLOC_OVERRUN_CHECK]:
1562 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
1563 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
1564 (dont_register_blocks, bytes_used_when_reconsidered)
1565 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
1566 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
1567 [!SYSTEM_MALLOC && !SYNC_INPUT]:
1568 Remove. All uses removed.
1569 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
1570 implementation, one that depends on whether the new macro
1571 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
1572 is defined.
1573 * atimer.c (run_timers, handle_alarm_signal):
1574 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
1575 (handle_async_input, process_pending_signals)
1576 (handle_input_available_signal, init_keyboard):
1577 * nsterm.m (ns_read_socket):
1578 * process.c (wait_reading_process_output):
1579 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
1580 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
1581 (emacs_write):
1582 * xterm.c (XTread_socket):
1583 Assume SYNC_INPUT.
1584 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
1585 * eval.c (handling_signal): Remove. All uses removed.
1586 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
1587 All uses replaced with the SYNC_INPUT version.
1588 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
1589 Remove decls.
1590 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1591 Now static.
1592
634b8cac
PE
1593 * font.c (Ffont_shape_gstring): Remove unused local.
1594
83da1b55
GM
15952012-09-16 Glenn Morris <rgm@gnu.org>
1596
518650a5
GM
1597 * Makefile.in (clean): No longer run nextstep's clean.
1598
83da1b55
GM
1599 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
1600 (ns_frag): Remove.
1601 (ns-app): Move here from ns.mk, and simplify.
1602 (clean): Simplify nextstep entry.
1603 * ns.mk: Remove file.
1604
85a43e2e
KH
16052012-09-17 Kenichi Handa <handa@gnu.org>
1606
1607 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
1608 not covert the last few charactes.
1609
ba13e616 16102012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
1611
1612 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
1613 here, but just check the validity of glyphs in the glyph-string.
1614
a8c729af
MR
16152012-09-16 Martin Rudalics <rudalics@gmx.at>
1616
3a880af4
SM
1617 * window.c (Fwindow_parameter, Fset_window_parameter):
1618 Accept any window as argument (Bug#12452).
a8c729af 1619
c077c059
JD
16202012-09-16 Jan Djärv <jan.h.d@swipnet.se>
1621
1622 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
1623 to ns_term_init to avoid memory leak.
1624
1625 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
1626 explicit retain/release.
1627 (ns_term_init): Only allow one display. Initialize outerpool and
1628 ns_*_types.
1629
39a57ad0
PE
16302012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1631
1632 Port _setjmp fix to POSIXish hosts as well as Microsoft.
1633 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
1634 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
1635 the Microsoft problem in a different way, by altering ../nt/config.nt.
1636
7105c8cb
EZ
16372012-09-15 Eli Zaretskii <eliz@gnu.org>
1638
1639 * w32xfns.c:
1640 * w32uniscribe.c:
1641 * w32term.c:
1642 * w32select.c:
1643 * w32reg.c:
1644 * w32proc.c:
1645 * w32menu.c:
1646 * w32inevt.c:
1647 * w32heap.c:
1648 * w32font.c:
1649 * w32fns.c:
1650 * w32console.c:
1651 * w32.c:
1652 * w16select.c: Remove inclusion of setjmp.h, as it is now included
1653 by lisp.h. This completes removal of setjmp.h inclusion
1654 erroneously announced in the previous commit. (Bug#12446)
1655
1656 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
1657 more accurate.
1658
1659 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
1660 not defined as a macro. The latter happens on MS-Windows.
1661 (Bug#12446)
1662
0328b6de
PE
16632012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1664
1665 Port better to POSIX hosts lacking _setjmp (Bug#12446).
1666 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 1667 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
1668 only reason for the instance was because "lisp.h" was included.
1669 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
1670 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
1671 and _longjmp with the new symbols. Emacs already uses _setjmp if
1672 available, so this change affects only POSIXish hosts that have
1673 sigsetjmp but not _setjmp, such as some versions of Solaris and
1674 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
1675 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
1676 (png_load_body) [HAVE_PNG]:
1677 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
1678 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
1679 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
1680 since PNG requires jmp_buf. This is the only exception to the
1681 general rule that we now use sys_setjmp and sys_longjmp.
1682 This exception is OK since this code does not change the signal
1683 mask or longjmp out of a signal handler.
1684
2af03429
PE
16852012-09-14 Paul Eggert <eggert@cs.ucla.edu>
1686
1687 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1688 Include "syssignal.h", for 'main_thread'.
1689
2f294edf
DA
16902012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
1691
1692 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
1693 * insdel.c (replace_range, replace_range_2):
1694 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
1695 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
1696 Remove redundant check before calling offset_intervals.
1697
6b533e9c
MR
16982012-09-14 Martin Rudalics <rudalics@gmx.at>
1699
1700 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
1701 current buffer (Bug#12387).
1702
2a7931e3
JB
17032012-09-14 Juanma Barranquero <lekktu@gmail.com>
1704
1705 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
1706
c18e885b
PE
17072012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 Use a more backwards-compatible timer format (Bug#12430).
1710 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
1711 vector element, not from the 4th, since PSECS is now at the end.
1712 (Fcurrent_idle_time): Doc fix.
1713
d59a1afb
DA
17142012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1715
1716 Function to mark objects and remove killed buffers at once.
1717 * alloc.c (discard_killed_buffers): Rename to ...
1718 (mark_discard_killed buffers) ... new name. Add marking
1719 of remaining objects. Fix comment. Adjust users.
1720 (mark_object): Do not touch frame buffer lists here.
1721 * frame.c (delete_frame): Reset frame buffer lists here.
1722
5f0cb45a
PE
17232012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1724
8ea47e3a
PE
1725 Better workaround for GNOME bug when --enable-gcc-warnings.
1726 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
1727 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
1728 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
1729
4a4bbad2
PE
1730 Simplify SIGIO usage (Bug#12408).
1731 The code that dealt with SIGIO was crufty and confusing, e.g., it
1732 played tricks like "#undef SIGIO" but these tricks were not used
1733 consistently. Simplify mostly by not #undeffing standard symbols,
1734 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
1735 or not as we please) rather than "defined SIGIO" (standard symbol
1736 that we probably shouldn't #undef).
1737 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
1738 Modules that need it can include it.
1739 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
1740 * dispextern.h (ignore_sigio): New decl.
1741 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
1742 unconditionally, since it's now a no-op if !USABLE_SIGIO.
1743 * emacs.c (shut_down_emacs):
1744 * keyboard.c (kbd_buffer_store_event_hold):
1745 Use ignore_sigio rather than invoking 'signal' directly.
1746 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
1747 for FIONREAD.
1748 (FIONREAD, SIGIO): Do not #undef.
1749 (tty_read_avail_input): Use #error rather than a syntax error.
1750 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
1751 for I_PIPE, used by SETUP_SLAVE_PTY.
1752 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
1753 * sysdep.c (croak): Remove; no longer needed. This bit of
1754 temporary code, with Fred N. Fish's comment that it's temporary,
1755 has been in Emacs since at least 1992!
1756 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
1757 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
1758 * syssignal.h (croak): Remove decl.
1759 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
1760 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
1761 now that we're termios-only.
1762 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
1763 * term.c (dissociate_if_controlling_tty): Use #error rather than
1764 a run-time error.
1765
5f0cb45a
PE
1766 Work around GCC and GNOME bugs when --enable-gcc-warnings.
1767 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
1768 to work around GNOME bug 683906.
1769 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
1770 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
1771 This works around GCC bug 54561.
1772
40bce90b
PE
17732012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 More fixes for 'volatile' and setjmp/longjmp.
1776 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
1777 * image.c (struct png_load_context) [HAVE_PNG]: New type.
1778 (png_load_body) [HAVE_PNG]:
1779 (jpeg_load_body) [HAVE_JPEG]:
1780 New function, with most of the old parent function's body.
1781 (png_load) [HAVE_PNG]:
1782 (jpeg_load) [HAVE_JPEG]:
1783 Invoke the new function, to avoid longjmp munging our locals.
1784 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
1785 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
1786 longjmp is passed 2, as the C standard doesn't guarantee this.
1787 Instead, store the failure code into mgr->failure_code.
1788
bfeae2cf
SM
17892012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1790
1791 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
1792 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
1793 (syms_of_keyboard): Remove support for unread-command-char.
1794
8099e36b
EZ
17952012-09-12 Eli Zaretskii <eliz@gnu.org>
1796
1797 * w32proc.c (sys_kill): If PID is our process ID and the signal is
1798 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
1799 violation. (Bug#12426)
1800
92547ff9
PE
18012012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
1804
45b82ad0
SM
18052012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1806
1807 * eval.c: Add `inhibit-debugger'.
1808 (Qinhibit_debugger): New symbol.
1809 (call_debugger): Bind it instead of Qdebug_on_error.
1810 (maybe_call_debugger): Test Vinhibit_debugger.
1811 (syms_of_eval): Define inhibit-debugger.
1812 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
1813 (syms_of_xdisp): Remove inhibit-debug-on-message.
1814
5779a1dc
PE
18152012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1816
50f2e553
PE
1817 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
1818 If a nonvolatile local variable is written before a _longjmp to
1819 the frame containing the variable, and is read after the _longjmp,
1820 the value read is indeterminate. Some local variables of type
1821 'struct handler' and 'struct catchtag' are used in this way, so
1822 mark each of their slots as volatile if the slot can be set before
1823 _longjmp and read afterwards.
1824 * lisp.h (struct handler): var and chosen_clause are now volatile.
1825 (struct catchtag): val, next, and pdlcount are now volatile.
1826
ae1d87e2
PE
1827 * bidi.c (bidi_push_it, bidi_pop_it):
1828 * fns.c (copy_hash_table):
1829 * image.c (define_image_type):
1830 * keyboard.c (kbd_buffer_store_event_hold):
1831 * process.c (Fprocess_send_eof):
1832 * xfaces.c (x_create_gc) [HAVE_NS]:
1833 * xgselect.c (xg_select):
1834 Prefer assignment to memcpy when either will do.
1835
5779a1dc
PE
1836 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
1837 Use pointer-to-a-pointer to simplify and avoid a NILP check each
1838 time an item is removed. No need to mark this function 'inline';
1839 the compiler knows better than we do.
1840
c4c9756b
JD
18412012-09-11 Jan Djärv <jan.h.d@swipnet.se>
1842
1843 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
1844 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
1845 to change_frame_size (Bug#12388).
1846 (windowDidResize:): Pass YES to updateFrameSize.
1847
1848 * nsterm.h: Add delay parameter to updateFrameSize.
1849
d73e321c
DA
18502012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1851
1852 Discard killed buffers from deleted window and frame objects.
1853 This reduces an amount of references to killed buffers and
1854 helps GC to reclaim them faster.
1855 * alloc.c (discard_killed_buffers): New function.
1856 (mark_object): Use it for deleted windows and frames.
1857 (mark_object): If symbol's value is set up for a killed buffer
1858 or deleted frame, restore it's global binding.
1859 * data.c (swap_in_global_binding): Add GC notice.
1860 (swap_in_symval_forwarding): Use convenient set_blv_where.
1861 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
1862 * window.h: ... to here.
1863
e578f381
DA
18642012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1865
1866 Convenient macro to check whether the buffer is live.
1867 * buffer.h (BUFFER_LIVE_P): New macro.
1868 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
1869 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
1870
3057e615
YM
18712012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1872
1873 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
1874 composition cases (Bug#12364).
1875
1876 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
1877 overhang of succeeding glyphs overlapping box cursor.
1878
1879 * w32term.c (x_draw_glyph_string): Likewise.
1880
6fda35f2
PE
18812012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1882
c990426a
PE
1883 Simplify, document, and port floating-point (Bug#12381).
1884 The porting part of this patch fixes bugs on non-IEEE platforms
1885 with frexp, ldexp, logb.
1886 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
1887 Now static.
1888 * floatfns.c: Simplify discussion of functions that Emacs doesn't
1889 support, by removing commented-out code and briefly listing the
1890 C89 functions excluded. The commented-out stuff was confusing
1891 maintenance, e.g., we thought we needed cbrt but it was commented out.
1892 (logb): Remove decl; no longer needed.
1893 (isfinite): New macro, if not already supplied.
1894 (isnan): Don't replace any existing macro.
1895 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
1896 are present on all C89 platforms.
1897 (Ffrexp): Do not special-case zero, as frexp does the right thing
1898 for that case.
1899 (Flogb): Do not use logb, as it doesn't have the desired meaning
1900 on hosts that use non-base-2 floating point. Instead, stick with
1901 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
1902 frexp, to avoid getting an unspecified result.
1903
6fda35f2
PE
1904 * xdisp.c (Qinhibit_debug_on_message): Now static.
1905
16130a58
JD
19062012-09-10 Jan Djärv <jan.h.d@swipnet.se>
1907
1908 * nsterm.m (ns_update_begin): Set clip path to whole view by using
1909 NSBezierPath (Bug#12131).
1910
d105a573
CY
19112012-09-10 Chong Yidong <cyd@gnu.org>
1912
1913 * fns.c (Fdelq, Fdelete): Doc fix.
1914
ff55dfe8
PE
19152012-09-10 Paul Eggert <eggert@cs.ucla.edu>
1916
1917 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
1918 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
1919
e7032e7c
SM
19202012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
1921
1922 * lisp.h (make_lisp_ptr): New macro to replace XSET.
1923 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
1924 Use it.
1925
e9957956
EZ
19262012-09-09 Eli Zaretskii <eliz@gnu.org>
1927
aba05ce9
EZ
1928 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
1929 left fringe if the window has a left margin. This avoids leaving
1930 traces of the cursor because its leftmost pixel is not drawn over.
1931
e9957956
EZ
1932 * dispnew.c (update_window_line): When the left margin area of a
1933 screen line is updated, set the redraw_fringe_bitmaps_p flag of
1934 that screen line. (Bug#12277)
1935
f6196b87
PE
19362012-09-09 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 Assume C89 or later for math functions (Bug#12381).
1939 This simplifies the code, and makes it a bit smaller and faster,
1940 and (most important) makes it easier to clean up signal handling
1941 since we can stop worring about floating-point exceptions in
1942 library code. That was a problem before C89, but the problem
1943 went away many years ago on all practical Emacs targets.
1944 * data.c, image.c, lread.c, print.c:
1945 Don't include <math.h>; no longer needed.
1946 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
1947 might be autoconfigured, as that never happens.
1948 * data.c (fmod):
1949 * doprnt.c (DBL_MAX_10_EXP):
1950 * print.c (DBL_DIG):
1951 Remove. C89 or later always defines these.
1952 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
1953 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
1954 (arith_error, domain_error, domain_error2):
1955 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1956 no longer needed -- we simply return what C returns. All uses removed.
1957 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1958 the wrapped code.
1959 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1960 Remove. All uses expanded, as these macros are no longer used
1961 more than once and are now more trouble than they're worth.
1962 (Ftan): Use tan, not sin / cos.
1963 (Flogb): Assume C89 frexp.
1964 (fmod_float): Assume C89 fmod.
1965 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1966 (init_floatfns): Remove. All uses removed.
1967
9d7f1863
JD
19682012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1969
1970 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1971 compositeToPoint for OSX < 10.6 (Bug#12390).
1972
eabf0404
PE
19732012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1974
1975 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1976 This produces more-accurate results.
1977
0b3b1d23
JD
19782012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1979
1980 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1981 changes (Bug#12088).
1982
6dcef6ec
CY
19832012-09-08 Chong Yidong <cyd@gnu.org>
1984
1985 * syntax.c (Fstring_to_syntax): Doc fix.
1986
aa7d57c5
JD
19872012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1988
1989 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1990 in the internal border.
1991 (x_set_window_size): Remove static variables and their usage.
1992 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1993 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1994 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1995 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1996 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1997 (ns_fix_rect_ibw): Remove.
1998 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1999 (ns_dumpglyphs_box_or_relief): Ditto.
2000 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
2001 adjustment.
2002 (ns_dumpglyphs_image): Ditto.
fc0c31f8 2003 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
2004 border adjustment.
2005 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
2006 their usage. Add fringe_extended_p and its use as in other terms.
2007 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
2008 scroll bar was removed.
2009 (updateFrameSize): New function.
2010 (windowDidResize): Move code to updateFrameSize and call it.
2011
2012 * nsterm.h (EmacsView): Add updateFrameSize.
2013
1a5432bc
CY
20142012-09-07 Chong Yidong <cyd@gnu.org>
2015
b4f5313e
CY
2016 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
2017
1a5432bc
CY
2018 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
2019
1a4f1e9b
PE
20202012-09-07 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
2023 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
2024 Problem introduced when merging patches. Noted by Eli Zaretskii in
2025 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
2026 * floatfns.c: Comment fix.
2027 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
2028 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
2029 and anyway the declaration is harmless even if SIGDANGER is not defined.
2030 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
2031 defined BROKEN_FIONREAD). systty.h formerly did this, but other
2032 source files not surprisingly expected syssignal.h to define, or
2033 not define, SIGIO, and it's cleaner to do it that way, for consistency.
2034 Include <sys/ioctl.h>, for FIONREAD.
2035 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
2036 This eliminates a problem whereby other files mysteriously had
2037 to include "syssignal.h" before including "systty.h" if they
2038 wanted to use "#ifdef SIGIO".
2039
bc8000ff
EZ
20402012-09-07 Eli Zaretskii <eliz@gnu.org>
2041
3e6d6928
EZ
2042 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
2043
2044 * w32.c (sigemptyset): Empty the set.
2045 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
2046
bc8000ff
EZ
2047 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
2048
b4fa72f2
DA
20492012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
2050
2051 * alloc.c (mark_buffer): Revert unsafe marking optimization.
2052 (mark_object): Likewise for frame objects.
2053
30730c93
PE
20542012-09-07 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 * syssignal.h (handle_on_main_thread): Always declare,
2057 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
2058 This ports to platforms without HAVE_PTHREAD.
2059
2fe28299
PE
20602012-09-06 Paul Eggert <eggert@cs.ucla.edu>
2061
2062 Signal-handler cleanup (Bug#12327).
2063 Emacs's signal handlers were written in the old 4.2BSD style with
2064 sigblock and sigmask and so forth, and this led to some
2065 inefficiencies and confusion. Rewrite these to use
2066 pthread_sigmask etc. without copying signal sets around. Also,
2067 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
2068 'signal', and instead use functions that do not attempt to take
2069 over the system name space. This patch causes Emacs's text
2070 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
2071 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
2072 Do not include <signal.h> or "syssignal.h", as these
2073 modules do not use signals.
2074 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
2075 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
2076 Do not include <signal.h>, as "syssignal.h" does that for us now.
2077 * atimer.c (sigmask_atimers): New function.
2078 (block_atimers, unblock_atimers): New functions,
2079 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
2080 All uses replaced.
2081 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
2082 no longer needed here.
2083 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 2084 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
2085 * sysdep.c (struct save_signal): New member 'action', replacing
2086 old member 'handler'.
2087 (save_signal_handlers, restore_signal_handlers):
2088 Use sigaction instead of 'signal' to save and restore.
2089 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
2090 New function. All users of 'signal' modified to use set_sighandler
2091 if they're writeonly, and to use sys_signal if they're read+write.
2092 (emacs_sigaction_init, forwarded_signal): New functions.
2093 (sys_signal): Remove. All uses replaced by calls to sigaction
2094 and emacs_sigaction_init, or by direct calls to 'signal'.
2095 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
2096 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
2097 all uses replaced by pthread_sigmask etc. calls.
2098 * syssignal.h: Include <signal.h>.
2099 (emacs_sigaction_init, forwarded_signal): New decls.
2100 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
2101 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
2102 (sigmask, sys_sigmask): Remove; no longer needed.
2103 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
2104 (sigblock, sigunblock, sigfree):
2105 (sigsetmask) [!defined sigsetmask]:
2106 Remove. All uses replaced by pthread_sigmask.
2107 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
2108 no longer need to be replaced, and its typical old uses
2109 are now done via emacs_sigaction_init and sigaction.
2110 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
2111 (sys_sigdel): Remove; unused.
2112 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
2113
0216c128
EZ
21142012-09-06 Eli Zaretskii <eliz@gnu.org>
2115
2116 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
2117 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
2118
c752cfa9
DA
21192012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
2120
2121 Explicitly mark buffer_defaults and buffer_local_symbols.
2122 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
2123 mark_local_symbols here.
2124 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
2125 since special buffers aren't marked here any more.
2126 (allocate_buffer): Chain new buffer with all_buffers here...
2127 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
2128 not here.
2129 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
2130 (syms_of_buffer): Remove staticpro of the above.
2131 (init_buffer_once): Set names for buffer_defaults and
2132 buffer_local_symbols.
2133
a864ef14
PE
21342012-09-06 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 Use bool for booleans in font-related modules.
2137 * font.c (font_intern_prop, font_style_to_value)
2138 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
2139 (generate_otf_features, font_check_otf_features, font_check_otf)
2140 (font_match_p, font_list_entities, font_at):
2141 * fontset.c (fontset_id_valid_p, reorder_font_vector
2142 (fontset_find_font, Fset_fontset_font)
2143 (face_suitable_for_char_p) [0]:
2144 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
2145 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
2146 (m17n_flt_initialized, ftfont_shape_by_flt):
2147 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
2148 * nsfont.m (nsfont_draw):
2149 * w32font.c (w32font_draw):
2150 * w32term.c (x_draw_glyphless_glyph_string_foreground):
2151 Use bool for booleans.
2152 * font.h: Adjust to above API changes.
2153 (struct font, struct font_driver, struct font_driver_list):
2154 Use bool for booleans.
2155 (struct font): Remove useless member encoding_type.
2156 All users removed.
2157 * fontset.c, xftfont.c: Omit unnecessary static decls.
2158
0699fc18
DA
21592012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
2160
2161 * alloc.c (mark_object): Revert window marking code
2162 since it's unsafe for the Fset_window_configuration.
2163
20ef56db
PE
21642012-09-05 Paul Eggert <eggert@cs.ucla.edu>
2165
2fe28299 2166 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
2167 Be more systematic about preserving errno whenever a signal
2168 handler returns, even if it's not in the main thread. Do this by
2169 renaming signal handlers to distinguish between signal delivery
2170 and signal handling. All uses changed.
2171 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
2172 * data.c (deliver_arith_signal): Rename from arith_error.
2173 * dispnew.c (deliver_window_change_signal): Rename from
2174 window_change_signal.
2175 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
2176 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
2177 * keyboard.c (deliver_input_available_signal): Rename from
2178 input_available_signal.
2179 (deliver_user_signal): Rename from handle_user_signal.
2180 (deliver_interrupt_signal): Rename from interrupt_signal.
2181 * process.c (deliver_pipe_signal): Rename from send_process_trap.
2182 (deliver_child_signal): Rename from sigchld_handler.
2183 * atimer.c (handle_alarm_signal):
2184 * data.c (handle_arith_signal):
2185 * dispnew.c (handle_window_change_signal):
2186 * emacs.c (handle_fatal_signal, handle_danger_signal):
2187 * keyboard.c (handle_input_available_signal):
2188 * keyboard.c (handle_user_signal, handle_interrupt_signal):
2189 * process.c (handle_pipe_signal, handle_child_signal):
2190 New functions, with the actual signal-handling code taken from the
2191 original respective signal handlers, sans the sporadic attempts to
2192 preserve errno, since that's now done by handle_on_main_thread.
2193 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
2194 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
2195 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2196 Move to sysdep.c.
2197 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2198 Move initialization of main_thread to sysdep.c's init_signals.
2199 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
2200 our usage, and simplifies the mainline code.
2201 (record_child_status_change): New static function, as a helper
2202 for handle_child_signal, and with most of the old child handler's
2203 contents.
2204 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
2205 (handle_child_signal): Use the above.
2206 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2207 Moved here from emacs.c.
2208 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
2209 code moved here from emacs.c's main function.
2210 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
2211 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
2212 This lets callers save and restore errno properly.
20ef56db 2213
e3ccf108
DA
22142012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2215
2216 Remove redundant or unused things here and there.
2217 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
2218 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
2219 * editfns.c (Fcompare_buffer_substrings): Likewise.
2220 * frame.h (struct terminal, struct font_driver_list):
2221 Remove redundant declarations.
2222 * window.h (Qleft, Qright): Likewise.
2223
697e1e39
DA
22242012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2225
2226 Do not mark objects from deleted buffers, windows and frames.
2227 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
2228 (mark_object): Likewise for windows and frames.
2229
c1ca42ca
DA
22302012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2231
2232 * alloc.c (valid_lisp_object_p): Treat killed buffers,
2233 buffer_defaults and buffer_local_symbols as valid objects.
2234 Return special value to denote them.
2235
014d93be
PE
22362012-09-05 Paul Eggert <eggert@cs.ucla.edu>
2237
f75d7a91
PE
2238 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
2239 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
2240 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
2241 (file_name_absolute_p, Fsubstitute_in_file_name):
2242 (check_executable, check_writable, Ffile_accessible_directory_p)
2243 (Fset_file_selinux_context, Fdefault_file_modes)
2244 (Finsert_file_contents, choose_write_coding_system)
2245 (Fwrite_region, build_annotations, a_write, e_write)
2246 (Fdo_auto_save):
2247 * filelock.c (boot_time_initialized, get_boot_time)
2248 (get_boot_time_1, lock_file_1, within_one_second):
2249 * floatfns.c (in_float):
2250 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
2251 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
2252 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
2253 * lisp.h (struct Lisp_Hash_Table.cmpfn):
2254 * window.c (compare_window_configurations):
2255 Use bool for booleans.
2256 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
2257 (Fdefault_file_modes): Now mode_t, not int, for modes.
2258 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
2259 (internal_delete_file): Now returns void, not a (boolean) int,
2260 since nobody was looking at the return value.
2261 * lisp.h, window.h: Adjust to above API changes.
2262
014d93be
PE
2263 * xdisp.c (set_message): Simplify and reindent last change.
2264
776f29e1
JB
22652012-09-05 Juanma Barranquero <lekktu@gmail.com>
2266
2267 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
2268
7f7e0167
LI
22692012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
2270
2271 * eval.c (call_debugger): Make the function non-static so that we
2272 can call it from set_message.
2273
2274 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
2275 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
2276
cf29dd84
PE
22772012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 Give more-useful info on a fatal error (Bug#12328).
2280 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
2281 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
2282 of doing the work ourselves.
2283 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
2284 do most of the work.
2285 (fatal_error_backtrace): New function, taken from the guts
2286 of the old fatal_error_signal, but with a new option to output
2287 a backtrace.
2288 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
2289 info about the signal than just its number.
2290 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
2291 * sysdep.c: Include <execinfo.h>
2292 (emacs_backtrace): New function, taken partly from the previous
2293 code of the 'die' function.
2294 (emacs_abort): Call fatal_error_backtrace rather than abort.
2295
972debf2
SM
22962012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
2297
2298 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
2299 eager (load-time) macro-expansion.
2300 * lisp.mk (lisp): Add macroexp.
2301
1088b922
PE
23022012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 Simplify redefinition of 'abort' (Bug#12316).
2305 Do not try to redefine the 'abort' function. Instead, redo
2306 the code so that it calls 'emacs_abort' rather than 'abort'.
2307 This removes the need for the NO_ABORT configure-time macro
2308 and makes it easier to change the abort code to do a backtrace.
2309 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
2310 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
2311 Remove; sysdep.c's emacs_abort now takes its place.
2312 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
2313 'abort' changed to use 'emacs_abort'.
2314 * msdos.c (dos_abort) [defined abort]: Remove; not used.
2315 (abort) [!defined abort]: Rename to ...
2316 (emacs_abort): ... new name.
2317 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
2318 the place of the old 'abort' in emacs.c.
2319 * w32.c, w32fns.c (abort): Do not #undef.
2320 * w32.c (emacs_abort): Rename from w32_abort.
2321
30934d33
EZ
23222012-09-04 Eli Zaretskii <eliz@gnu.org>
2323
2324 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
2325 offsets[j].dv, since the y axis of the screen coordinates points
2326 down, while the y axis of the font definition coordinates points
2327 up. This fixes display of Arabic diacritics such as KASRA and
2328 KASRATAN. (Bug#11860)
2329
af26b72c
PE
23302012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2331
2332 Be more systematic about _setjmp vs setjmp.
2333 * alloc.c (test_setjmp, mark_stack):
2334 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
2335 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
2336 (png_load, my_error_exit, jpeg_load):
2337 * process.c (send_process_trap, send_process):
2338 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
2339 The underscored versions are up to 30x faster on some hosts.
2340 Formerly, the code used setjmp+longjmp sometimes and
2341 _setjmp+_longjmp at other times, with no particular reason to
2342 prefer setjmp+longjmp.
2343
26d4541d
PE
23442012-09-03 Paul Eggert <eggert@cs.ucla.edu>
2345
d42f4f0f 2346 Fix minor problem found by static checking.
26d4541d 2347 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 2348
c5e28e39
MR
23492012-09-03 Martin Rudalics <rudalics@gmx.at>
2350
2351 * buffer.c (Fdelete_all_overlays): New function.
2352
3eab3ca9
CY
23532012-09-03 Chong Yidong <cyd@gnu.org>
2354
2355 * gtkutil.c: Add extern decl for Qxft.
2356
c04889f8
PE
23572012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2358
1882aa38
PE
2359 * emacs.c, eval.c: Use bool for boolean.
2360 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
2361 (malloc_using_checking) [DOUG_LEA_MALLOC]:
2362 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
2363 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
2364 (main, decode_env_path, Fdaemon_initialized):
2365 * eval.c (call_debugger, Finteractive_p, interactive_p):
2366 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
2367 (maybe_call_debugger, Fbacktrace):
2368 * process.c (read_process_output, exec_sentinel):
2369 Use bool for booleans.
2370 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
2371 All callers changed.
2372 * eval.c (interactive_p): Omit always-true boolean argument
2373 EXCLUDE_SUBRS_P. All callers changed.
2374 * dispextern.h, lisp.h: Reflect above API changes.
2375 * firstfile.c (dummy): Use the address of 'main', whose signature
2376 won't change, instead of the address of 'initialize', whose
2377 signature just changed from int to bool.
2378 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
2379 * msdos.c (fatal_error_in_progress): ... from here.
2380 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
2381 of incrementing it.
2382 (redisplay_internal, unwind_redisplay): Simply clear
2383 REDISPLAYING_P when unwinding, instead of saving its previous,
2384 always-false value and then restoring it.
2385
a411ac43
PE
2386 Clean up some extern decls.
2387 Mostly, this hoists extern decls out of .c files and into .h files.
2388 That way, we're more likely to catch errors if the interfaces change.
2389 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
2390 declare xg_mark_data.
2391 * dispextern.h (x_frame_parm_handlers):
2392 * font.h (Qxft):
2393 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
2394 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
2395 (Qultra_bold, Qoblique, Qitalic):
2396 Move extern decl here from .c file.
2397 * alloc.c (xg_mark_data) [USE_GTK]:
2398 * doc.c (Qclosure):
2399 * eval.c (Qlexical_binding):
2400 * fns.c (time) [!HAVE_UNISTD_H]:
2401 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
2402 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
2403 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
2404 * lread.c (Qinternal_interpreter_environment):
2405 * minibuf.c (Qbuffer):
2406 * process.c (QCfamily, QCfilter):
2407 * widget.c (free_frame_faces):
2408 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
2409 * xfont.c (x_clear_errors):
2410 * xterm.c (x_frame_parm_handlers):
2411 Remove now-redundant extern decls.
2412 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
2413 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
2414 Now static.
2415 * xfaces.c: Remove unnecessary static decls.
2416 * xterm.c (updating_frame): Remove decl of nonexistent object.
2417
c04889f8
PE
2418 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
2419 when building globals.h, as the objects that are not built on
2420 this host are not needed to compile C files on this host.
2421
8b339673
JD
24222012-09-02 Jan Djärv <jan.h.d@swipnet.se>
2423
2424 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
2425
2426 * frame.h: Add missing prototype for x_wm_set_size_hint.
2427
a08d4ba7
PE
24282012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2429
2430 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
2431 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
2432 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
2433 (Fsubstitute_command_keys):
2434 * editfns.c (region_limit, find_field, Fconstrain_to_field)
2435 (save_excursion_save, save_excursion_restore)
2436 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
2437 (format_time_string, general_insert_function)
2438 (make_buffer_string, make_buffer_string_both)
2439 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
2440 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
2441 (copy_text, insert_1, insert_1_both, insert_from_string)
2442 (insert_from_string_before_markers, insert_from_string_1)
2443 (insert_from_buffer, insert_from_buffer_1, replace_range)
2444 (replace_range_2, del_range_1, del_range_byte, del_range_both)
2445 (del_range_2, modify_region):
2446 * intervals.c (intervals_equal, balance_possible_root_interval)
2447 (adjust_intervals_for_insertion, merge_properties_sticky)
2448 (graft_intervals_into_buffer, lookup_char_property)
2449 (adjust_for_invis_intang, set_point_both)
2450 (get_property_and_range, compare_string_intervals)
2451 (set_intervals_multibyte_1, set_intervals_multibyte):
2452 * keyboard.c (decode_timer):
2453 Use bool for boolean.
2454 * intervals.h, lisp.h, systime.h: Reflect above API changes.
2455 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
2456
48c948de
CY
24572012-09-02 Chong Yidong <cyd@gnu.org>
2458
2459 * keymap.c (push_key_description): Print M-TAB as C-M-i
2460 (Bug#11758).
2461
6c49a40b
JB
24622012-09-02 Juanma Barranquero <lekktu@gmail.com>
2463
2464 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
2465 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
2466 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
2467 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
2468 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
2469 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
2470 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2471
4dfbd238
EZ
24722012-09-01 Eli Zaretskii <eliz@gnu.org>
2473
7e510e28
EZ
2474 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
2475 more than one grapheme cluster passed to the shaper: compute the
2476 offset adjustment values separately for each cluster. (Bug#11860)
2477
4dfbd238
EZ
2478 * image.c: Restore mistakenly removed inclusion of w32.h. Without
2479 it, GCC doesn't see prototypes of w32_delayed_load, and complains
2480 about implicit conversions from integer to pointer.
2481
86571ae0
DC
24822012-09-01 Daniel Colascione <dancol@dancol.org>
2483
2484 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
2485 system used too early.
2486
0e23ef9d
PE
24872012-09-01 Paul Eggert <eggert@cs.ucla.edu>
2488
2489 Better seed support for (random).
2490 * emacs.c (main): Call init_random.
2491 * fns.c (Frandom): Set the seed from a string argument, if given.
2492 Remove long-obsolete Gentzel cruft.
2493 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
2494 (init_random): New function.
2495
17a2cbbd
DC
24962012-09-01 Daniel Colascione <dancol@dancol.org>
2497
2498 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
2499 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
2500 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
2501 x_wm_set_size_hint, x_query_colors, x_real_positions,
2502 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
2503 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
2504 all of which have been moved to common code.
2505
2506 * xfaces.c: Include TERM_HEADER instead of listing all possible
2507 window-system headers.
2508
2509 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
2510 to match header.
2511
2512 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
2513 directly accessing frame internals.
2514
f18cbb28 2515 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
2516 globals_of_w32font.
2517
2518 * process.c: Include TERM_HEADER instead of listing all possible
2519 window-system headers.
2520
3a880af4
SM
2521 * nsterm.h: Remove declarations now in frame.h.
2522 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
2523
2524 * menu.c: Include TERM_HEADER instead of listing all possible
2525 window-system headers.
2526
2527 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
2528 window system.
2529
2530 * keyboard.c: Include TERM_HEADER instead of listing all possible
2531 window-system headers.
2532
2533 * image.c: Include TERM_HEADER instead of listing all possible
2534 window-system headers. Declare Vlibrary_cache when compiling for
2535 Windows.
2536
2537 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
2538 window system declarations.
2539
2540 * frame.h: Move common functions here: set_frame_menubar,
2541 x_set_window_size, x_sync, x_get_focus_frame,
2542 x_set_mouse_position, x_set_mouse_pixel_position,
2543 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
2544 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
2545 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
2546 x_activate_menubar, x_real_positions, x_bitmap_icon,
2547 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
2548 and x_query_colors.
2549
2550 * frame.c: Include TERM_HEADER instead of listing all possible
2551 window-system headers.
2552
2553 * font.c: Include TERM_HEADER instead of listing all possible
2554 window-system headers.
2555
2556 * emacs.c: Include TERM_HEADER.
2557
f18cbb28
EZ
2558 * dispnew.c: Include TERM_HEADER instead of listing all possible
2559 window-system headers.
17a2cbbd 2560
f18cbb28 2561 * ccl.h: Include character.h.
17a2cbbd
DC
2562
2563 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
2564 the current window system; include in list of objects to link into
2565 Emacs.
2566
c650a5de
DA
25672012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2568
2569 Remove mark_ttys function and fix tty_display_info initialization.
2570 * lisp.h (mark_ttys): Remove prototype.
2571 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
2572 to mark_ttys because all possible values of 'top_frame' slot are
2573 the frames which are reachable from Vframe_list.
2574 * term.c (mark_ttys): Remove.
2575 (init_tty): Safely initialize 'top_frame' slot with Qnil.
2576
4e0f6479
DA
25772012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2578
2579 Change struct frame bitfields from unsigned char to unsigned.
2580 * frame.h (struct frame): Change type of 'display_preempted',
2581 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
2582 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
2583 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
2584 bitfields from unsigned char to unsigned.
2585
8b96a52c
DA
25862012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2587
2588 Remove unused member of struct x_output and struct w32_output.
2589 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
2590 * w32term.h (struct w32_output): Likewise.
2591
b4444c8a
JD
25922012-08-30 Jan Djärv <jan.h.d@swipnet.se>
2593
2594 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
2595 does not become zero (Bug#12234).
2596
b98521db
PE
25972012-08-30 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
2600 for GCC 4.7.1 x86-64.
2601
31d02438
GM
26022012-08-30 Glenn Morris <rgm@gnu.org>
2603
2604 * lread.c (init_lread): For out-of-tree builds, only add the
2605 source directory's site-lisp dir to the load-path if it exists,
2606 consistent with in-tree builds. (Bug#12302)
2607
7f8941d8
JD
26082012-08-28 Jan Djärv <jan.h.d@swipnet.se>
2609
2610 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 2611 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
2612 (windowShouldClose:): Set window_closed.
2613 (dealloc): New member, free button_values.
fc0c31f8
JB
2614 (process_dialog:): Make member function. Remove window argument,
2615 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
2616 in button_values.
2617 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 2618 with tag. Remove return self, declare return value as void.
7f8941d8
JD
2619 (addString:row:): Remove return self, declare return value as void.
2620 (addSplit): Remove return self, declare return value as void.
2621 (clicked:): Remove return self, declare return value as void.
fc0c31f8 2622 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
2623 (initFromContents:isQuestion:): Adjust call to process_dialog.
2624 Code formatting change.
2625 (timeout_handler:): Set timer_fired to YES.
2626 (runDialogAt:): Set timer_fired to NO.
2627 Handle click on close button as quit.
2628
2629 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
2630 Add window_closed and button_values. Add void as return value for
2631 add(Button|String|Split). addButton takes int instead of Lisp_Object.
2632 Add process_dialog as new member.
2633
eada0861 26342012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 2635
eada0861
GM
2636 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
2637 is not one of the heaps we manage. (Bug#12242)
2638
26392012-08-28 Glenn Morris <rgm@gnu.org>
2640
2641 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
2642
457294dd
MR
26432012-08-28 Martin Rudalics <rudalics@gmx.at>
2644
2645 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
2646 auto-buffer-name window parameter. Install revision of reverted
2647 fix.
457294dd 2648
4f2daf31
DA
26492012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2650
2651 Do not allow to set major mode for a dead buffer.
2652 * buffer.c (Fset_buffer_major_mode): Signal an error
2653 if the buffer is dead.
2654 (Fother_buffer, other_buffer_safely): Remove redundant
2655 nested declaration.
2656
66322887
DA
26572012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2658
2659 Always use set_buffer_if_live to restore original buffer at unwind.
2660 * buffer.h (record_unwind_current_buffer): New function.
2661 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
2662 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
2663 * undo.c, window.c: Adjust users.
2664 * buffer.c (set_buffer_if_live): Fix comment.
2665
a3d794a1
DA
26662012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2667
2668 Fix usage of set_buffer_internal.
2669 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
2670 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
2671 * coding.c (decode_coding): Omit redundant test.
2672 * fileio.c (decide_coding_unwind): Likewise.
2673 * fns.c (secure_hash): Likewise.
2674 * insdel.c (modify_region): Likewise.
2675 * keyboard.c (command_loop_1): Likewise.
2676 * print.c (PRINTFINISH): Likewise.
2677 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
2678
59ea14cd
PE
26792012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 * dispnew.c: Use bool for boolean.
2682 (frame_garbaged, display_completed, delayed_size_change)
2683 (fonts_changed_p, add_window_display_history)
2684 (add_frame_display_history, verify_row_hash)
2685 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
2686 (row_equal_p, realloc_glyph_pool)
2687 (allocate_matrices_for_frame_redisplay)
2688 (showing_window_margins_p)
2689 (adjust_frame_glyphs_for_frame_redisplay)
2690 (build_frame_matrix_from_leaf_window, make_current)
2691 (mirrored_line_dance, mirror_line_dance, update_frame)
2692 (update_window_tree, update_single_window)
2693 (check_current_matrix_flags, update_window, update_text_area)
2694 (update_window_line, set_window_update_flags, scrolling_window)
2695 (update_frame_1, scrolling, buffer_posn_from_coords)
2696 (do_pending_window_change, change_frame_size)
2697 (change_frame_size_1, sit_for):
2698 Use bool for boolean.
2699 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
2700 and remove last int (actually boolean) argument, which was always 0.
2701 All callers changed.
2702 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
2703 * dispextern.h (struct composition_it): Use bool for boolean.
2704 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
2705 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
2706 * dired.c (file_name_completion):
2707 Use bool for boolean. (This was missed in an earlier change.)
2708
95072a94
MR
27092012-08-27 Martin Rudalics <rudalics@gmx.at>
2710
2711 * window.c (Fset_window_configuration): Revert first part of
2712 last change.
2713
0f19feff
JD
27142012-08-27 Jan Djärv <jan.h.d@swipnet.se>
2715
2716 * nsterm.h (NSPanel): New class variable dialog_return.
2717
3a880af4
SM
2718 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
2719 Initialize dialog_return.
0f19feff
JD
2720 (windowShouldClose:): Use stop instead of stopModalWithCode.
2721 (clicked:): Ditto, and also set dialog_return (Bug#12258).
2722 (timeout_handler:): Use stop instead of abortModal. Send a dummy
2723 event.
2724 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
2725 modal loop returns.
2726
f10fe38f
PE
27272012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2728
de1339b0
PE
2729 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
2730 * composite.c (find_composition, composition_gstring_p)
2731 (composition_reseat_it, find_automatic_composition):
2732 * data.c (let_shadows_buffer_binding_p)
2733 (let_shadows_global_binding_p, set_internal, make_blv)
2734 (Fmake_variable_buffer_local, Fmake_local_variable)
2735 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
2736 (cons_to_signed, arith_driver):
2737 * dbusbind.c (xd_in_read_queued_messages):
2738 * dired.c (directory_files_internal, file_name_completion):
2739 Use bool for booleans.
2740 * dired.c (file_name_completion):
2741 * process.h (fd_callback):
2742 Omit int (actually boolean) argument. It wasn't being used.
2743 All uses changed.
2744 * composite.h, lisp.h: Reflect above API changes.
2745
f10fe38f
PE
2746 * cmds.c, coding.c: Use bool for booleans.
2747 * cmds.c (move_point, Fself_insert_command):
2748 * coding.h (struct composition status, struct coding_system):
2749 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
2750 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
2751 (emacs_mule_char, decode_coding_emacs_mule)
2752 (encode_coding_emacs_mule, detect_coding_iso_2022)
2753 (decode_coding_iso_2022, encode_invocation_designation)
2754 (encode_designation_at_bol, encode_coding_iso_2022)
2755 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
2756 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
2757 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
2758 (encode_coding_raw_text, detect_coding_charset)
2759 (decode_coding_charset, encode_coding_charset, detect_eol)
2760 (detect_coding, get_translation_table, produce_chars)
2761 (consume_chars, reused_workbuf_in_use)
2762 (make_conversion_work_buffer, code_conversion_save)
2763 (decode_coding_object, encode_coding_object)
2764 (detect_coding_system, char_encodable_p)
2765 (Funencodable_char_position, code_convert_region)
2766 (code_convert_string, code_convert_string_norecord)
2767 (Fset_coding_system_priority):
2768 * fileio.c (Finsert_file_contents):
2769 Use bool for booleans.
2770 * coding.h, lisp.h: Reflect above API changes.
2771 * coding.c: Remove unnecessary static function decls.
2772 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
2773 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
2774 not a boolean 'int', since callers never look at the return value.
2775 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
2776 * coding.h (decoding_buffer_size, encoding_buffer_size)
2777 (emacs_mule_string_char): Remove unused extern decls.
2778 (struct iso_2022_spec, struct coding_system):
2779 Use 'unsigned int : 1' for boolean fields, since there's more than one.
2780 (struct emacs_mule_spec): Remove unused field 'full_support'.
2781 All initializations removed.
2782 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
2783
5474c384
DA
27842012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2785
f10fe38f 2786 Fix spare memory change (Bug#12286).
5474c384
DA
2787 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
2788 (valid_lisp_object_p): Likewise.
2789
c4b6914d
MR
27902012-08-27 Martin Rudalics <rudalics@gmx.at>
2791
2792 * window.c (Fset_window_configuration): Record any window's old
2793 buffer if it's replaced (see Bug#8789). If the new current
2794 buffer doesn't appear in the selected window, go to its old
2795 point (Bug#12208).
2796
35aaa1ea
DA
27972012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2798
2799 Special MEM_TYPE_SPARE to denote reserved memory.
2800 * alloc.c (enum mem_type): New memory type.
2801 (refill_memory_reserve): Use new type for spare memory.
2802 This prevents live_cons_p and live_string_p from incorrect
2803 detection of uninitialized objects from spare memory as live.
2804
6af64513
PE
28052012-08-26 Paul Eggert <eggert@cs.ucla.edu>
2806
8b2e00a3
PE
2807 Spelling fixes.
2808 * Makefile.in (.PHONY): versioclean -> versionclean.
2809
b52d6985
PE
2810 Remove unused external symbols.
2811 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
2812 * window.c (Qwindow_valid_p, decode_valid_window):
2813 Now static, not extern.
2814 * data.c (Qinterval): Remove; unused.
2815 (syms_of_data): Do not define 'interval'.
2816 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
2817 * window.h (decode_valid_window):
2818 Remove decls.
2819
d5172d4f
PE
2820 * character.c, charset.c, chartab.c: Use bool for booleans.
2821 * character.c (lisp_string_width, string_count_byte8)
2822 (string_escape_byte8):
2823 * charset.c (charset_map_loaded, load_charset_map, read_hex):
2824 (load_charset_map_from_file, map_charset_chars)
2825 (Fdefine_charset_internal, define_charset_internal)
2826 (Fdeclare_equiv_charset, find_charsets_in_text)
2827 (Ffind_charset_region, char_charset, Fiso_charset):
2828 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
2829 (sub_char_table_set, sub_char_table_set_range)
2830 (char_table_set_range, optimize_sub_char_table)
2831 (map_sub_char_table):
2832 Use bool for boolean.
2833 * character.c (str_to_unibyte): Omit last boolean argument; it was
2834 always 0. All callers changed.
2835 * character.h, charset.h: Adjust to match previous changes.
2836 * character.h (char_printable_p): Remove decl of nonexistent function.
2837 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
2838 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
2839 are all boolean, so make them single-bit bitfields.
2840
6af64513
PE
2841 * lisp.h (ASET): Remove attempt to detect side effects.
2842 It was meant to be temporary and it often doesn't work,
2843 because when IDX has side effects the behavior of IDX==IDX
2844 is undefined. See Stefan Monnier in
2845 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
2846
e1f29348
BR
28472012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2848
2849 * lisp.h (functionp): New function (extracted from Ffunctionp).
2850 (FUNCTIONP): Use it.
2851 * eval.c (Ffunctionp): Use it.
2852
17c05d74
PE
28532012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2854
0f46bc75
PE
2855 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
2856 as that's faster and simpler than static storage. Don't bother
2857 with the g_main_context_query overhead if g_main_context_pending
2858 says no events are pending.
2859 (gfds, gfds_size): Remove these static vars.
2860 (xgselect_initialize): Remove; no longer needed.
2861 All uses and decls removed.
2862
ee4c0f69
PE
2863 * emacs.c (fatal_error_signal_hook): Remove.
2864 All uses removed. This leftover from old code was always 0.
2865
17c05d74
PE
2866 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
2867 * casefiddle.c (casify_object, casify_region):
2868 * casetab.c (set_case_table):
2869 * category.c, category.h (word_boundary_p):
2870 * category.h (CHAR_HAS_CATEGORY):
2871 Use bool for booleans, instead of int.
2872
391ceac5
EZ
28732012-08-25 Eli Zaretskii <eliz@gnu.org>
2874
2875 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
2876
2f221583
PE
28772012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2878
f4a681b0
PE
2879 On assertion failure, print backtrace if available.
2880 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
2881 (die) [ENABLE_CHECKING]: Print a backtrace if available.
2882 * Makefile.in (LIB_EXECINFO): New macro.
2883 (LIBES): Use it.
2884
2f221583
PE
2885 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
2886 * bytecode.c (exec_byte_code):
2887 * callint.c (check_mark, Fcall_interactively):
2888 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
2889 (getenv_internal, sync_process_alive, call_process_exited):
2890 * lisp.h (USE_SAFE_ALLOCA):
2891 Use bool for booleans, instead of int.
2892 * lisp.h, process.h: Adjust prototypes to match above changes.
2893 * callint.c (Fcall_interactively): Don't assume the mark's
2894 offset fits in 'int'.
2895
37ef52bb
PE
28962012-08-24 Paul Eggert <eggert@cs.ucla.edu>
2897
2898 * buffer.c, buffer.h: Use bool for boolean.
2899 * buffer.c (reset_buffer_local_variables)
2900 (buffer_lisp_local_variables, Fset_buffer_modified_p)
2901 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
2902 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
2903 (overlay_touches_p, overlay_strings, Foverlay_put)
2904 (report_overlay_modification, call_overlay_mod_hooks):
2905 (mmap_enlarge, mmap_set_vars):
2906 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
2907 Use bool for booleans, instead of int.
2908 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
2909 since the 1-or-0 return value is always ignored anyway.
2910 (mmap_initialized_p):
2911 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
2912 * buffer.h, lisp.h: Adjust prototypes to match above changes.
2913
2cc21167
PE
29142012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 * bidi.c: Use bool for boolean.
2917 This is a bit more readable, and makes the text segment of bidi.o
2918 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
2919 Presumably it's faster too.
2920 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
2921 Now bool.
2922 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2923 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
2924 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
2925 (bidi_explicit_dir_char, bidi_level_of_next_char)
2926 (bidi_find_other_level_edge, bidi_move_to_visually_next):
2927 Use bool for booleans, instead of int.
2928 * dispextern.h (bidi_init_it, bidi_paragraph_init)
2929 (bidi_unshelve_cache): Adjust decls to match code.
2930
7db4ddf4
MR
29312012-08-23 Martin Rudalics <rudalics@gmx.at>
2932
2933 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
2934 argument.
2935
b1bb8011
PE
29362012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
2939 * atimer.h: Include <stdbool.h>.
2940
ff687885
DN
29412012-08-22 Dan Nicolaescu <dann@gnu.org>
2942
2943 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
2944 compile time tests instead of run time tests on systems that do
2945 not use them.
2946 (FRAME_MAC_P): Remove leftover from deleted code.
2947 * frame.c (syms_of_frame): Remove leftover from deleted code.
2948
4ce7a138
JD
29492012-08-22 Jan Djärv <jan.h.d@swipnet.se>
2950
2951 * nsterm.m (insertText:): Don't clear modifiers if code is space.
2952
d733ec6d
PE
29532012-08-22 Paul Eggert <eggert@cs.ucla.edu>
2954
2955 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2956 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2957 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2958 (fontset_add): Return void, for FONTSET_ADD.
2959
d0d2d26f
PE
29602012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2961
fce31d69
PE
2962 * alloc.c: Use bool for booleans.
2963 (gc_in_progress, abort_on_gc)
2964 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2965 (dont_register_blocks) [GC_MALLOC_CHECK]:
2966 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2967 (check_string_bytes, make_specified_string, memory_full)
2968 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2969 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2970 (mark_stack, valid_pointer_p, make_pure_string)
2971 (Fgarbage_collect, survives_gc_p, gc_sweep):
2972 Use bool for booleans, instead of int.
2973 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2974 Remove unused local.
2975 * alloc.c (PURE_POINTER_P):
2976 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2977 * editfns.c (Fformat):
2978 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2979 (Fdo_auto_save):
2980 * fns.c (sweep_weak_table):
2981 * lisp.h (suppress_checking, push_message, survives_gc_p)
2982 (make_pure_string, gc_in_progress, abort_on_gc):
2983 * lread.c (readchar, read1):
2984 * print.c (Fprin1_to_string):
2985 * xdisp.c (push_message):
2986 Use bool for booleans affected directly or indirectly by
2987 alloc.c's changes.
2988
d0d2d26f
PE
2989 Make recently-introduced setters macros.
2990 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2991 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2992 (set_fontset_default, set_fontset_fallback): Rename from their
2993 upper-case counterparts, and make them functions rather than macros.
2994 This is more consistent with the other recently-introduced setters.
2995 These don't need to be inline, since they're local.
2996
d18e2bb6
JD
29972012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2998
2999 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
3000 the loop (Bug#12247).
3001
1b9d9d16
PE
30022012-08-21 Paul Eggert <eggert@cs.ucla.edu>
3003
3004 * lisp.h (vcopy): Use memcpy rather than our own loop.
3005 This fixes a performance regression introduced by the recent
3006 addition of vcopy. This means 'vcopy' will need to be modified
3007 for a copying collector, but that's OK. Also, tighten the
3008 checking in the assertion.
3009
b2f09701
EZ
30102012-08-21 Eli Zaretskii <eliz@gnu.org>
3011
3012 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
3013 components for RTL text (Bug#11860). Adjust X-OFFSET of each
3014 non-base glyph for the width of the base character, according to
e1f29348
BR
3015 what x_draw_composite_glyph_string_foreground expects.
3016 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
3017 expectations, to produce correct width of the composed character.
3018 Reverse the sign of the DU offset produced by ScriptPlace.
3019
9b994fed
PE
30202012-08-21 Paul Eggert <eggert@cs.ucla.edu>
3021
3022 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
3023
086ca913
DA
30242012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
3025
3026 Avoid direct writes to contents member of struct Lisp_Vector.
3027 * lisp.h (vcopy): New function to copy data into vector.
3028 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
3029 * fns.c (Ffillarray): Use ASET.
3030 * keyboard.c (timer_check_2): Use AREF and ASET.
3031 (append_tool_bar_item, Frecent_keys): Use vcopy.
3032 * lread.c (read_vector): Use ASET.
3033 * msdos.c (Frecent_doskeys): Use vcopy.
3034 * xface.c (Finternal_copy_lisp_face): Use vcopy.
3035 (Finternal_merge_in_global_face): Use ASET and vcopy.
3036 * xfont.c (xfont_list_pattern): Likewise.
3037
5481664a
MR
30382012-08-21 Martin Rudalics <rudalics@gmx.at>
3039
3040 * window.c (Fwindow_point): For the selected window always return
3041 the position of its buffer's point.
3042 (Fset_window_point): For the selected window always go in its
3043 buffer to the specified position.
3044
6d470bdd
DA
30452012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
3046
3047 Setter macros for fontsets.
3048 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
3049 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
3050 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
3051 Adjust users.
3052
24564fe1
GM
30532012-08-20 Glenn Morris <rgm@gnu.org>
3054
3055 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3056 Don't assume that `ln -f' works.
3057
0a05a035
EZ
30582012-08-20 Eli Zaretskii <eliz@gnu.org>
3059
3060 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
3061 and later about non-assignments with no effect. See discussion at
3062 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
3063 details.
3064
e46f2325
DA
30652012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3066
3067 Inline setter functions for Lisp_Objects slots of struct specbinding.
3068 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
3069 Adjust users.
3070
734fbd86
MR
30712012-08-20 Martin Rudalics <rudalics@gmx.at>
3072
3073 * window.c (select_window): Always make selected window's buffer
3074 current.
3075
f1a95992
DA
30762012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3077
3078 Use AREF and ASET for docstrings of category tables.
3079 * category.h (CATEGORY_DOCSTRING): Use AREF.
3080 (SET_CATEGORY_DOCSTRING): Use ASET.
3081 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
3082
e83064be
DA
30832012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3084
3085 Inline setter functions for hash table members.
3086 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
3087 (set_hash_hash, set_hash_index): Rename with _slot suffix.
3088 (set_hash_key_and_value, set_hash_index, set_hash_next)
3089 (set_hash_hash): New functions.
3090 * charset.c, fns.c: Adjust users.
3091
4ce60d2e
DA
30922012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3093
3094 Inline getter and setter functions for per-buffer values.
3095 * buffer.h (per_buffer_default, set_per_buffer_default)
3096 (per_buffer_value, set_per_buffer_value): New functions.
3097 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
3098 * buffer.c, data.c: Adjust users.
3099
c06c9690
JB
31002012-08-20 Juanma Barranquero <lekktu@gmail.com>
3101
3102 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
3103
32bd4250
PE
31042012-08-19 Paul Eggert <eggert@cs.ucla.edu>
3105
bad03192 3106 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
3107 as gnulib does this if the system doesn't.
3108 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
3109 Remove declaration. MS-Windows declares it on stdlib.h which is
3110 included by conf_post.h.
b69a6d22
PE
3111 * emacs.c (environ) [DOUG_LEA_MALLOC]:
3112 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
3113 * vm-limit.c: Include <unistd.h>, for 'environ'.
3114
22d7feb2
PE
3115 * unexaix.c, unexcoff.c: Include "mem-limits.h".
3116 (start_of_data): Remove decl; mem-limits.h provides it.
3117
32bd4250
PE
3118 * xdisp.c (handle_invisible_prop): Make it a bit faster
3119 and avoid a gcc -Wmaybe-uninitialized diagnostic.
3120
450809af
CY
31212012-08-19 Chong Yidong <cyd@gnu.org>
3122
3123 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
3124 ends (Bug#3874).
3125
9e677988
AS
31262012-08-19 Andreas Schwab <schwab@linux-m68k.org>
3127
6b1319ce
AS
3128 * .gdbinit: Use call instead of set when calling a function in the
3129 inferior.
3130
9e677988
AS
3131 * data.c (set_internal): Don't use set_blv_found.
3132 (Fkill_local_variable): Likewise.
3133
d7191076
AA
31342012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
3135
3136 * nsfont.m (ns_ascii_average_width): Ensure the string
3137 ascii_printable is initialized with a null-terminated character
3138 array. Otherwise, it can contain undesired extra characters.
3139
e757f1c6
PE
31402012-08-18 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 port new setting code to Sun C 5.8 2005/10/13
3143 * chartab.c, lisp.h (char_table_set, char_table_set_range):
3144 Return void, not Lisp_Object. Otherwise, the compiler
3145 complains about (A?B:C) where B is void and C is Lisp_Object
3146 when compiling CHAR_TABLE_SET, due to the recent change to
3147 the API of sub_char_table_set_contents.
3148
a999ce26
CY
31492012-08-18 Chong Yidong <cyd@gnu.org>
3150
3151 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
3152 for the string case (Bug#3874).
3153
3f22b86f
PE
31542012-08-18 Paul Eggert <eggert@cs.ucla.edu>
3155
39eb03f1
PE
3156 * buffer.h (BSET): Remove (Bug#12215).
3157 Replace all uses with calls to new setter functions.
3158 (bset_bidi_paragraph_direction, bset_case_canon_table)
3159 (bset_case_eqv_table, bset_directory, bset_display_count)
3160 (bset_display_time, bset_downcase_table)
3161 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
3162 (bset_last_selected_window, bset_local_var_alist)
3163 (bset_mark_active, bset_point_before_scroll, bset_read_only)
3164 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
3165 (bset_width_table):
3166 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
3167 (bset_auto_fill_function, bset_auto_save_file_format)
3168 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
3169 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
3170 (bset_cache_long_line_scans, bset_case_fold_search)
3171 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
3172 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
3173 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
3174 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
3175 (bset_header_line_format, bset_indicate_buffer_boundaries)
3176 (bset_indicate_empty_lines, bset_invisibility_spec)
3177 (bset_left_fringe_width, bset_major_mode, bset_mark)
3178 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
3179 (bset_name, bset_overwrite_mode, bset_pt_marker)
3180 (bset_right_fringe_width, bset_save_length)
3181 (bset_scroll_bar_width, bset_scroll_down_aggressively)
3182 (bset_scroll_up_aggressively, bset_selective_display)
3183 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
3184 (bset_word_wrap, bset_zv_marker):
3185 * category.c (bset_category_table):
3186 * syntax.c (bset_syntax_table):
3187 New setter functions.
3188
6a09a33b
PE
3189 * process.h (PSET): Remove (Bug#12215).
3190 Replace all uses with calls to new setter functions.
3191 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3192 (PROCESS_INLINE): New macro.
3193 (pset_childp): New setter function.
3194 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
3195 * process.c (PROCESS_INLINE):
3196 Define to EXTERN_INLINE, so that the corresponding functions
3197 are compiled into code.
3198 (pset_buffer, pset_command, pset_decode_coding_system)
3199 (pset_decoding_buf, pset_encode_coding_system)
3200 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
3201 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
3202 (pset_type, pset_write_queue): New setter functions.
3203
e8c17b81
PE
3204 * window.h (WSET): Remove (Bug#12215).
3205 Replace all uses with calls to new setter functions.
3206 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3207 (WINDOW_INLINE): New macro.
3208 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
3209 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
3210 (wset_total_lines, wset_vertical_scroll_bar)
3211 (wset_window_end_pos, wset_window_end_valid)
3212 (wset_window_end_vpos): New setter functions.
3213 * window.c (WINDOW_INLINE):
3214 Define to EXTERN_INLINE, so that the corresponding functions
3215 are compiled into code.
3216 (wset_combination_limit, wset_dedicated, wset_display_table)
3217 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
3218 (wset_new_normal, wset_new_total, wset_next_buffers)
3219 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
3220 (wset_prev_buffers, wset_right_fringe_width)
3221 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
3222 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
3223 (wset_window_parameters):
3224 * xdisp.c (wset_base_line_number, wset_base_line_pos)
3225 (wset_column_number_displayed, wset_region_showing):
3226 New setter functions.
3227
3f22b86f
PE
3228 * termhooks.h (TSET): Remove (Bug#12215).
3229 Replace all uses with calls to new setter functions.
3230 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3231 (TERMHOOKS_INLINE): New macro.
3232 (tset_charset_list, tset_selection_alist): New setter functions.
3233 * terminal.c (TERMHOOKS_INLINE):
3234 Define to EXTERN_INLINE, so that the corresponding functions
3235 are compiled into code.
3236 (tset_param_alist): New setter function.
3237
742af32f
PE
32382012-08-17 Paul Eggert <eggert@cs.ucla.edu>
3239
15dbb4d6
PE
3240 * keyboard.h (KSET): Remove (Bug#12215).
3241 Replace all uses with calls to new setter functions.
3242 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3243 (KEYBOARD_INLINE): New macro.
3244 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
3245 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
3246 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
3247 New setter functions.
3248 * keyboard.c (KEYBOARD_INLINE):
3249 Define to EXTERN_INLINE, so that the corresponding functions
3250 are compiled into code.
3251 (kset_echo_string, kset_kbd_queue)
3252 (kset_keyboard_translate_table, kset_last_prefix_arg)
3253 (kset_last_repeatable_command, kset_local_function_key_map)
3254 (kset_overriding_terminal_local_map, kset_real_last_command)
3255 (kset_system_key_syms): New setter functions.
3256
f00af5b1
PE
3257 * frame.h (FSET): Remove (Bug#12215).
3258 Replace all uses with calls to new setter functions.
3259 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3260 (FRAME_INLINE): New macro.
3261 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
3262 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
3263 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
3264 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
3265 (fset_param_alist, fset_root_window, fset_scroll_bars)
3266 (fset_selected_window, fset_title, fset_tool_bar_items)
3267 (fset_tool_bar_position, fset_tool_bar_window): New functions.
3268 * frame.c (FRAME_INLINE):
3269 Define to EXTERN_INLINE, so that the corresponding functions
3270 are compiled into code.
3271 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
3272
0c94c8d6
PE
3273 A few more naming-convention fixes for getters and setters.
3274 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
3275 and rename from buffer_overlays_set_before.
3276 (set_buffer_overlays_after): Move here from buffer.h, and rename
3277 from buffer_overlays_set_after.
3278 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
3279 All uses changed.
3280 (set_buffer_intervals): Rename from buffer_set_intervals.
3281 * intervals.c (set_interval_object): Move here from intervals.h,
3282 and rename from interval_set_object.
3283 (set_interval_left): Move here from intervals.h, and rename from
3284 interval_set_left.
3285 (set_interval_right): Move here from intervals.h, and rename from
3286 interval_set_right.
3287 (copy_interval_parent): Move here from intervals.h, and rename from
3288 interval_copy_parent.
3289 * intervals.h (set_interval_parent): Rename from interval_set_parent.
3290 (set_interval_plist): Rename from interval_set_plist.
3291 Return void, not Lisp_Object, since no caller uses the result.
3292 * lisp.h (string_intervals): Rename from string_get_intervals.
3293 (set_string_intervals): Rename from string_set_intervals.
3294
34dabdb7
PE
3295 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
3296 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 3297 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
3298 All uses changed. See the end of
3299 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
3300
742af32f
PE
3301 * lisp.h (CSET): Remove (Bug#12215).
3302 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
3303 (set_char_table_purpose): New functions,
3304 replacing CSET. All uses changed. For example, replace
3305 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 3306 "set_char_table_parent (char_table, parent);".
742af32f
PE
3307 The old version was confusing because it used the same name
3308 'parent' for two different things.
3309
a04e2c62
DA
33102012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
3311
3312 Functions to get and set Lisp_Object fields of buffer-local variables.
3313 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
3314 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
3315 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
3316 * data.c, eval.c, frame.c: Adjust users.
3317
383dcbf9
CY
33182012-08-17 Chong Yidong <cyd@gnu.org>
3319
3320 * xfaces.c (merge_face_vectors): If the target font specfies a
3321 font spec, make the font's attributes take precedence over
3322 directly-specified attributes.
3323 (merge_face_ref): Recognize :font.
3324
44386687
DA
33252012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
3326
3327 Do not use memcpy for copying intervals.
3328 * intervals.c (reproduce_interval): New function.
3329 (reproduce_tree, reproduce_tree_obj): Use it.
3330 (reproduce_tree_obj): Remove prototype.
3331
927c7216
PE
33322012-08-17 Paul Eggert <eggert@cs.ucla.edu>
3333
3334 * lisp.h (duration_to_sec_usec): Remove unused decl.
3335
93044f7b
AA
33362012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
3337
3338 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
3339 to an allocated instance of NSString, not to the class itself.
3340
9851e4a5
JB
33412012-08-17 Juanma Barranquero <lekktu@gmail.com>
3342
3343 * makefile.w32-in (C_CTYPE_H): New macro.
3344 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
3345 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
3346 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
3347
620f13b0
PE
33482012-08-16 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 Use ASCII tests for character types.
3351 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
3352 * xfns.c, xterm.c:
3353 Don't include <ctype.h>; was not needed.
3354 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
3355 * sysdep.c, xfaces.c:
3356 Include <c-ctype.h> instead of <ctype.h>.
3357 * nsterm.m: Include <c-ctype.h>.
3358 * charset.c (read_hex):
3359 * doc.c (Fsnarf_documentation):
3360 * fileio.c (IS_DRIVE) [WINDOWSNT]:
3361 (DRIVE_LETTER) [DOS_NT]:
3362 (Ffile_name_directory, Fexpand_file_name)
3363 (Fsubstitute_in_file_name):
3364 * font.c (font_parse_xlfd, font_parse_fcname):
3365 * frame.c (x_set_font_backend):
3366 * gtkutil.c (xg_get_font):
3367 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
3368 * nsimage.m (hexchar):
3369 * nsterm.m (ns_xlfd_to_fontname):
3370 * sysdep.c (system_process_attributes):
3371 * xfaces.c (hash_string_case_insensitive):
3372 Use C-locale tests instead of locale-specific tests for character
3373 types, since we want the ASCII interpretation here, not the
3374 interpretation suitable for whatever happens to be the current locale.
3375
52162052
MR
33762012-08-16 Martin Rudalics <rudalics@gmx.at>
3377
3378 Consistently check windows for validity/liveness
3379 (Bug#11984, Bug#12025, Bug#12026).
3380 * lisp.h (CHECK_VALID_WINDOW): New macro.
3381 * window.c (decode_window): Rename to decode_live_window.
3382 (decode_valid_window, Fwindow_valid_p): New functions.
3383 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
3384 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
3385 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
3386 (Fwindow_prev_sibling, Fwindow_combination_limit)
3387 (Fset_window_combination_limit, Fwindow_use_time)
3388 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
3389 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
3390 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
3391 (Fwindow_hscroll, Fset_window_hscroll)
3392 (Fwindow_redisplay_end_trigger)
3393 (Fset_window_redisplay_end_trigger, Fwindow_edges)
3394 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
3395 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3396 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
3397 (Fwindow_end, Fset_window_point, Fset_window_start)
3398 (Fpos_visible_in_window_p, Fwindow_line_height)
3399 (Fwindow_dedicated_p, Fset_window_dedicated_p)
3400 (Fwindow_prev_buffers, Fset_window_prev_buffers)
3401 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
3402 (Fset_window_parameter, Fwindow_display_table)
3403 (Fset_window_display_table, Fdelete_other_windows_internal)
3404 (Fset_window_buffer, Fset_window_new_total)
3405 (Fset_window_new_normal, Fdelete_window_internal)
3406 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
3407 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
3408 (Fwindow_scroll_bars): Check whether argument window is a valid or
3409 live window. Update doc-strings.
3410 (syms_of_window): New symbol Qwindow_valid_p.
3411 * keyboard.c (Fposn_at_x_y): Check whether argument
3412 frame_or_window denotes a valid window.
3413
2751c80f
DA
34142012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3415
3416 Fix previous char table change.
3417 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
3418 * chartab.c (optimize_sub_char_table): Likewise.
3419
032a42c8
CY
34202012-08-16 Chong Yidong <cyd@gnu.org>
3421
a2d19368
CY
3422 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
3423
032a42c8
CY
3424 * xfont.c (xfont_open):
3425 * xftfont.c (xftfont_open): Set the font's max_width field.
3426
3427 * nsfont.m (nsfont_open): Similar to the Xft backend, set
3428 min_width to space_width and average_width to the average over
3429 printable ASCII characters.
3430 (ns_char_width): Code cleanup.
3431 (ns_ascii_average_width): New utility function.
3432
3433 * font.h (struct font): Update comments.
3434
a098c930
DA
34352012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3436
032a42c8 3437 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
3438 * lisp.h (CSET): New macro.
3439 (char_table_set_extras, char_table_set_contents)
3440 (sub_char_table_set_contents): New function.
3441 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
3442 * syntax.c: Adjust users.
3443
8be3a09c
SM
34442012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
3445
3446 * eval.c (eval_sub): Bind lexical-binding.
3447 * lread.c (Qlexical_binding): Make non-static.
3448
ac4845a6
JD
34492012-08-15 Jan Djärv <jan.h.d@swipnet.se>
3450
ddee6515
JD
3451 * nsmenu.m (popupSession): Remove.
3452 (pop_down_menu): Remove endModalSession.
3453 (timeout_handler:): New method.
3454 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
3455 Call runModalForWindow. Check timer_fired when it returns.
3456 If not set, cancel timer and break out of loop.
3457 Otherwise loop again, with a new timeout.
3458
3459 * nsterm.m: Include fcntl.h if present.
3460 (fd_entry, t_readfds, inNsSelect): Remove.
3461 (select_writefds, select_valid, select_timeout, selfds)
3462 (select_mutex, apploopnr): Add.
3463 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
3464 Otherwise call kbd_buffer_store_event.
3465 (ns_send_appdefined): Remove release of fd_entry.
3466 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
3467 Increment and decrement apploopnr.
3468 (ns_select): If no file descriptors, just do a NSTimer.
3469 Otherwise copy read/write masks and start select thread (fd_handler).
3470 Start main loop and wait for application defined event.
3471 Inform select thread to stop selecting after main loop is exited.
3472 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 3473 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
3474 (fd_handler:): Loop forever, wait for info from the main thread
3475 to either start or stop selecting. When select returns, send
3476 and appdefined event.
3477 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
3478 If not call kbd_buffer_store_event.
3479
3480 * nsterm.h (EmacsApp): fd_handler takes id argument.
3481 (EmacsDialogPanel): Add timer_fired and timeout_handler.
3482
ac4845a6
JD
3483 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
3484
eb424fe3
EZ
34852012-08-15 Eli Zaretskii <eliz@gnu.org>
3486
3487 * region-cache.c (move_cache_gap): Update gap_len using the actual
3488 growth of the boundaries array. Do not change cache_len.
3489 (Bug#12196)
3490
4e6a86c6
DA
34912012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3492
3493 Generalize and cleanup font subsystem checks.
3494 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
3495 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
3496 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 3497
5bf192ca
DA
34982012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3499
3500 * gtkutil.c (xg_get_font): Use pango_units_to_double.
3501
f2045622
CY
35022012-08-15 Chong Yidong <cyd@gnu.org>
3503
8be3a09c
SM
3504 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
3505 When using the new font chooser, use gtk_font_chooser_get_font_desc to
3506 extract the font descriptor instead of just the font name.
3507 In that case, return a font spec instead of a string.
f2045622
CY
3508 (x_last_font_name): Move to this file from xfns.c.
3509
3510 * xfns.c (Fx_select_font): The return value can also be a font
3511 spec. Move x_last_font_name management to gtkutil.c.
3512
3513 * xfaces.c: Make font weight and style symbols non-static.
3514
7f6feb56
SM
35152012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
3516
3517 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
3518 (bug#12117).
3519
fecbd8ff
SM
35202012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 * alloc.c (Fgarbage_collect): Use plural form consistently.
3523
9b8d5165
EZ
35242012-08-14 Eli Zaretskii <eliz@gnu.org>
3525
3526 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
3527 iteration through the command loop. Fixes a problem whereby mouse
3528 movements are ignored until the first mouse click.
3529
f5d9e83a
PE
35302012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3531
3532 Use bool, not int, for Lisp booleans.
3533 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
3534 makes Emacs a bit smaller and presumably a bit faster.
3535 * lisp.h: Include <stdbool.h>.
3536 (struct Lisp_Boolfwd, defvar_bool):
3537 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
3538 * regex.c [!emacs]: Include <stdbool.h>.
3539 (false, true): Remove; <stdbool.h> does this for us now.
3540
55802e4a
CY
35412012-08-14 Chong Yidong <cyd@gnu.org>
3542
4abcdac8
CY
3543 * character.c (Fcharacterp): Doc fix (Bug#12076).
3544
3545 * data.c (Findirect_variable): Doc fix (Bug#11040).
3546
55802e4a
CY
3547 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
3548
3549 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 3550 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 3551
8e99d072
BR
35522012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3553
3554 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
3555 (bug#12022).
3556
08908aca
MR
35572012-08-14 Martin Rudalics <rudalics@gmx.at>
3558
3559 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
3560 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
3561 * minibuf.c (choose_minibuf_frame, read_minibuf):
3562 * w32fns.c (x_create_tip_frame):
3563 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
3564 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
3565
56120d6f
PE
35662012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3567
3568 * intervals.c (offset_intervals): Remove obsolete comment.
3569
67b77c0b
AS
35702012-08-14 Andreas Schwab <schwab@linux-m68k.org>
3571
3572 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
3573
f48b82fd
GR
35742012-08-14 Gergely Risko <gergely@risko.hu>
3575
3576 * coding.c (decode_coding): Record buffer modification before
3577 disabling undo_list (Bug#11773).
3578
fd318b54
DA
35792012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3580
3581 Revert and cleanup some recent overlay changes.
3582 * buffer.h (enum overlay_type): Remove.
3583 (buffer_get_overlays, buffer_set_overlays): Likewise.
3584 (buffer_set_overlays_before, buffer_set_overlays_after):
3585 New function. Adjust users.
3586 (unchain_both): Add eassert.
3587
41a62dd9
DA
35882012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3589
3590 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
3591
5884c324
PE
35922012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3593
3594 * gtkutil.c (xg_mark_data): Don't assume C99.
3595
ca06f160
JD
35962012-08-13 Jan Djärv <jan.h.d@swipnet.se>
3597
3598 * gtkutil.c (xg_frame_tb_info): New struct.
3599 (TB_INFO_KEY): New define.
3600 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
3601 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
3602 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
3603 if not present.
3604 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 3605 is up to date. Otherwise store new data.
ca06f160
JD
3606 (free_frame_tool_bar): Free xg_frame_tb_info if present.
3607
7864a3f7
DA
36082012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3609
3610 Use KSET for write access to Lisp_Object members of struct kboard.
3611 * keyboard.h (KSET): New macro.
3612 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
3613 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
3614 * xterm.c: Adjust users.
3615
4c31be61
DA
36162012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3617
3618 Use BSET for write access to Lisp_Object members of struct buffer.
3619 * buffer.h (BSET): New macro.
3620 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
3621 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
3622 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
3623 * window.c, xdisp.c, xfns.c: Adjust users.
3624
14ae4239
BT
36252012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
3626
3627 * lread.c (syms_of_lread): Initialize Vlexical_binding.
3628
32bcadb4
JD
36292012-08-11 Jan Djärv <jan.h.d@swipnet.se>
3630
3d29b2ce 3631 * nsterm.m (not_in_argv): New function.
fc0c31f8 3632 (application:openFile, application:openTempFile:):
3d29b2ce
JD
3633 (application:openFileWithoutUI:, application:openFiles:): Open file
3634 if not_in_argv returns non-zero (bug#12171).
3635
32bcadb4 3636 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
3637 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
3638 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
3639 (xg_get_font_name): Use those functions/macros here.
3640 Reported by Frans Oilinki <moilinki@gmail.com>.
3641
9ff9402d 36422012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
3643
3644 * unexmacosx.c (copy_data_segment): Copy initialized data in
3645 statically linked libraries from input file rather than memory.
3646
db74a5fc
YM
3647 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
3648 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
3649 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
3650
25e65510
GM
36512012-08-10 Glenn Morris <rgm@gnu.org>
3652
3653 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
3654 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
3655
7961135c
DA
36562012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3657
3658 Fix last change to allow compilation with low optimization levels.
3659 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
3660 Reported by Jan Djärv <jan.h.d@swipnet.se>.
3661
42b3a444
DA
36622012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3663
3664 Use common inline syntax in intervals.h.
3665 * intervals.h (INTERVALS_INLINE): New macro.
3666 Change all users from LISP_INLINE.
3667
9fb0c957
DA
36682012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3669
3670 Define Qnone once for all platforms.
3671 * frame.c (Qnone): Define here.
3672 (syms_of_frame): DEFSYM it.
3673 * lisp.h (Qnone): New declaration.
3674 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
3675 * xfns.c: Remove duplication. Adjust users.
3676
65e8ee52
DA
36772012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3678
3679 Remove unused macros from intervals.h.
3680 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
3681 * intervals.c: Adjust comment.
3682
9b855fd6
EZ
36832012-08-10 Eli Zaretskii <eliz@gnu.org>
3684
3685 * w32fns.c <w32_unicode_gui>: New static variable.
3686 (globals_of_w32fns): Initialize it according to os_subtype.
3687 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
3688 testing os_subtype.
3689
39cb9e56 36902012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
3691 Eli Zaretskii <eliz@gnu.org>
3692
3693 Fix bug #10299 with Unicode characters sent by customized
3694 keyboards created by MSKLC.
3695 * w32fns.c (INIT_WINDOW_CLASS): New macro.
3696 (w32_init_class): Use it to initialize the Emacs class with either
3697 ANSI or Unicode API calls.
3698 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
3699 later.
3700 (w32_wnd_proc): If the character code sent by WM_CHAR or
3701 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
3702 original message. Call DefWindowProcW on NT and later.
3703
9374581a
GM
37042012-08-10 Glenn Morris <rgm@gnu.org>
3705
4b94e8cf
GM
3706 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
3707
9374581a
GM
3708 * lisp.h (DIRECTORY_SEP): Let configure set it.
3709
a2752828
DA
37102012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
3711
3712 Use TSET for write access to Lisp_Object slots of struct terminal.
3713 * termhooks.h (TSET): New macro.
3714 * coding.c, terminal.c, xselect.c: Adjust users.
3715
cc92c454
SM
37162012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
3717
3718 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
3719 the failing expression, include them in the error message.
3720 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
3721 * lisp.h (internal_condition_case_n): Update declaration.
3722
4cb3e6b3
DA
37232012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3724
3725 Inline functions to examine and change buffer overlays.
3726 * buffer.c (unchain_both): New function.
3727 * buffer.h (buffer_get_overlays, buffer_set_overlays):
3728 (buffer_has_overlays): New function.
3729 (enum overlay_type): New enum.
3730 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
3731 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
3732
8707c1e5
DA
37332012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3734
3735 Inline functions to examine and change buffer intervals.
3736 * alloc.c (mark_interval_tree): Remove.
3737 (MARK_INTERVAL_TREE): Simplify.
3738 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
3739 * intervals.c (buffer_balance_intervals): New function.
3740 (graft_intervals_into_buffer): Adjust indentation.
3741 (set_intervals_multibyte): Simplify.
3742 * buffer.h (BUF_INTERVALS): Remove.
3743 (buffer_get_intervals, buffer_set_intervals): New function.
3744 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
3745 * intervals.c, textprop.c: Adjust users.
3746
ad8c997f
DA
37472012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3748
3749 Inline functions to examine and change string intervals.
3750 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
3751 (string_get_intervals, string_set_intervals): New function.
3752 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3753 * lread.c, print.c, textprop.c: Adjust users.
3754
32ac3a6b
GM
37552012-08-08 Glenn Morris <rgm@gnu.org>
3756
3757 * lisp.mk (lisp): Remove language/persian.elc.
3758
77c7bcb1
DA
37592012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3760
3761 Cleanup intervals.
3762 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
3763 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
3764 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
3765 Adjust comment. Move under #if 0.
77c7bcb1
DA
3766 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3767 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
3768
9c08a8d4
DA
37692012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3770
3771 Check total length of intervals with eassert.
3772 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
3773 * intervals.c: Change all users to eassert.
3774
26d16b35
EZ
37752012-08-07 Eli Zaretskii <eliz@gnu.org>
3776
14ae4239
BT
3777 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
3778 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
3779 INTERNAL_FIELD in Lisp_Cons.
3780
c644523b
DA
37812012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3782
3783 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
3784 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
3785 name since all xname users are fixed long time ago. Do not
3786 use INTERNAL_FIELD.
3787 (set_symbol_name, set_symbol_function, set_symbol_plist):
3788 (set_symbol_next, set_overlay_plist): New function.
3789 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
3790 (struct Lisp_Overlay): Likewise.
3791 (CVAR, MVAR, SVAR): Remove.
3792 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
3793 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
3794 * xterm.c: Adjust users.
3795 * .gdbinit: Change to use name field of struct Lisp_Symbol
3796 where appropriate.
3797
6a3d20cc
DA
37982012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3799
3800 Basic functions to set Lisp_Object and pointer slots of intervals.
3801 * intervals.h (interval_set_parent, interval_set_object):
3802 (interval_set_left, interval_set_right, interval_set_plist):
3803 (interval_copy_parent): New function.
3804 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
3805 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
3806 Adjust indentation.
6a3d20cc
DA
3807 (INTERVAL_SIZE): Remove. Adjust users.
3808 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
3809
4d2b044c
DA
38102012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3811
3812 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
3813 * process.h (PGET): Remove.
3814 (struct Lisp_Process): Do not use INTERNAL_FIELD.
3815 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3816
d3d50620
DA
38172012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3818
3819 Drop WGET and revert read access to Lisp_Objects slots of struct window.
3820 * window.h (WGET): Remove.
3821 (struct window): Do not use INTERNAL_FIELD.
3822 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3823 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3824 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3825 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3826 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3827 Adjust users.
3828
d10a51dc
CY
38292012-08-07 Chong Yidong <cyd@gnu.org>
3830
3831 * window.c (Fwindow_edges, Fwindow_pixel_edges)
3832 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
3833 (Fdelete_window_internal): Signal an error if the window is not on
3834 a live frame (Bug#12025).
3835
e69b0960
DA
38362012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3837
3838 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
3839 * frame.h (FGET): Remove.
3840 (struct frame): Do not use INTERNAL_FIELD.
3841 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3842 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3843 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3844 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3845
25a20a3a
JB
38462012-08-06 Juanma Barranquero <lekktu@gmail.com>
3847
3848 * w32.c: Silence compiler warnings.
3849 (map_w32_filename): Remove unused variable `is_fat'.
3850 (chase_symlinks): Add parentheses around expression.
3851
1c6f11f4
GM
38522012-08-06 Glenn Morris <rgm@gnu.org>
3853
1db4583a
GM
3854 * sysdep.c: Respect BROKEN_GETWD.
3855
1c6f11f4
GM
3856 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
3857 Let configure handle it.
3858 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
3859
2b90362b
DA
38602012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3861
3862 Use GCALIGNMENT where appropriate.
3863 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
3864 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
3865 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
3866
5f50daf2
EZ
38672012-08-06 Eli Zaretskii <eliz@gnu.org>
3868
14ae4239
BT
3869 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
3870 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 3871
cbcc7007
SM
38722012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
3873
3874 * buffer.h (struct buffer): Revert `indirections' to a simple int;
3875 that should be sufficient for everyone.
3876
4d365fa4
JD
38772012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3878
3879 * keyboard.c (timer_check_2): Add break so timer_check returns next
3880 timeout.
3881
dd86bd82
DA
38822012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3883
3884 Fix Windows build errors introduced after converting to WGET and WSET.
3885 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
3886 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3887
054e1668
JD
38882012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3889
3890 * nsterm.m (ns_frame_rehighlight): Use FSET.
3891
3892 * nsmenu.m (ns_update_menubar): Use FSET.
3893
21238f11
DA
38942012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3895
3896 Separate read and write access to Lisp_Object slots of Lisp_Process.
3897 * process.h (PGET, PSET): New macros similar to AREF and ASET.
3898 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3899
077288cf
DA
39002012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3901
3902 Separate read and write access to Lisp_Object slots of struct window.
3903 * window.h (WGET, WSET): New macros similar to AREF and ASET.
3904 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3905 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3906 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3907 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3908 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3909 Adjust users.
3910
71688bd7
DA
39112012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3912
3913 Fix Windows build errors introduced after converting to FGET and FSET.
3914 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
3915 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
3916 (w32_judge_scroll_bars): Change to use FSET.
3917 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3918
f99bac93
DA
39192012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3920
3921 Fix replacement typo.
3922 * window.c (replace_window): Set root_window instead of
3923 selected_window. This fixes a total window subsystem
3924 malfunction reported by Bastien Guerry <bzg@gnu.org>.
3925
8c2a0f2d
GM
39262012-08-06 Glenn Morris <rgm@gnu.org>
3927
3928 * lisp.mk (lisp): Add language/persian.elc.
3929
edd74c35
DA
39302012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3931
3932 Separate read and write access to Lisp_Object slots of struct frame.
3933 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
3934 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3935 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3936 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3937 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3938
8671676c
AS
39392012-08-05 Andreas Schwab <schwab@linux-m68k.org>
3940
3941 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
3942
663e2b3f
DA
39432012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3944
3945 Generalize common compile-time constants.
3946 * lisp.h (header_size, bool_header_size, word_size): Now here.
3947 (struct Lisp_Vector): Add comment.
3948 (struct Lisp_Bool_Vector): Move up to define handy constants.
3949 (VECSIZE, PSEUDOVECSIZE): Simplify.
3950 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
3951 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
3952 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
3953 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
3954 * xfont.c, xmenu.c: Use word_size where appropriate.
3955
d32e47af
LM
39562012-08-05 Lawrence Mitchell <wence@gmx.li>
3957
3958 * search.c (Freplace_match): Treat \? in the replacement text
3959 literally (Bug#8161).
3960
e5d9c0d1
CY
39612012-08-05 Chong Yidong <cyd@gnu.org>
3962
3963 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3964 * frame.c (Vdelete_frame_functions):
3965 * emacs.c (Vkill_emacs_hook): Doc fix.
3966
8da0576b
EZ
39672012-08-04 Eli Zaretskii <eliz@gnu.org>
3968
3969 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3970 --with-x-toolkit=no builds.
3971 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3972
02676e5d
CY
39732012-08-04 Chong Yidong <cyd@gnu.org>
3974
3975 * syntax.c (Fmodify_syntax_entry): Doc fix.
3976
97147da9
EZ
39772012-08-04 Eli Zaretskii <eliz@gnu.org>
3978
76151e2c
EZ
3979 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3980 * w32.c (init_environment): Change the default values of many
3981 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3982 them into environment when they were not already defined.
3983 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3984 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3985 (check_windows_init_file): Now external, not static.
3986 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3987 called when Vload_path is already set up.
3988
3989 * w32.h (check_windows_init_file): Add prototype.
3990
3991 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3992 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3993 compatibility with Posix platforms.
3994 (main): Move the call to check_windows_init_file to here from
3995 w32.c.
3996 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3997 any, in the DEFALT argument into the root of the Emacs build or
3998 installation tree, as appropriate.
3999
4000 * callproc.c (init_callproc_1): Call decode_env_path instead of
4001 doing its equivalent by hand.
4002 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
4003 the code that sets Vexec_path run on MS-Windows.
4004
4005 * lread.c (init_lread): Add comments to #ifdef's.
4006
97147da9
EZ
4007 * msdos.c (dos_set_window_size, IT_update_begin)
4008 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
4009 instead of direct references.
4010
185ee146
PE
40112012-08-04 Paul Eggert <eggert@cs.ucla.edu>
4012
4013 Export DEFAULT_REHASH_* to GDB.
4014 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
4015 Now constants, not macros.
4016
8834c57a
PE
40172012-08-03 Paul Eggert <eggert@cs.ucla.edu>
4018
98c6f1e3
PE
4019 Remove unnecessary casts involving pointers.
4020 These casts are no longer needed now that we assume C89 or later,
4021 since they involve casting to or from void *.
4022 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
4023 (make_pure_float, make_pure_vector):
4024 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
4025 * macros.c (Fstart_kbd_macro):
4026 * menu.c (find_and_return_menu_selection):
4027 * minibuf.c (read_minibuf_noninteractive):
4028 * sysdep.c (closedir):
4029 * xdisp.c (x_produce_glyphs):
4030 * xfaces.c (compare_fonts_by_sort_order):
4031 * xfns.c (x_real_positions, select_visual):
4032 * xselect.c (x_stop_queuing_selection_requests)
4033 (x_get_window_property, x_get_window_property_as_lisp_data):
4034 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
4035 Remove unnecessary pointer casts.
4036 * alloc.c (record_xmalloc): New function.
4037 * lisp.h (record_xmalloc): New decl.
4038 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
4039 more like a function. This is because the pointer cast is not
4040 needed. All uses changed.
4041 * print.c (print_string, print_error_message): Avoid length recalc.
4042
8834c57a
PE
4043 Improve fix for macroexp crash with debugging (Bug#12118).
4044 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
4045 ARRAY_MARK_FLAG when checking subscripts, because ASET is
4046 not supposed to be invoked from the garbage collector.
4047 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
4048 (gc_aset): New function, which is like ASET but can be
4049 used in the garbage collector.
4050 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
4051 (set_hash_index): Use it instead of ASET.
4052
6dad7178
EZ
40532012-08-03 Eli Zaretskii <eliz@gnu.org>
4054
4055 Support symlinks on latest versions of MS-Windows.
4056 * w32.c: Include winioctl.h and aclapi.h.
4057 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
4058 (revert_to_self): Forward declarations of static functions.
4059 <static BOOL g_b_init_get_security_info>:
4060 <g_b_init_create_symbolic_link>: New static flags.
4061 (globals_of_w32): Initialize them to zero.
4062 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
4063 (map_w32_filename): Improve commentary. Simplify switch.
4064 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
4065 headers (most versions of MinGW w32api don't).
4066 (get_security_info, create_symbolic_link)
4067 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
4068 New functions.
4069 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
4070 in the argument file name.
4071 (sys_access): Call unc_volume_file_attributes only if
4072 GetFileAttributes fails with network-related error codes.
4073 (sys_rename): Diagnose renaming of a symlink when the user doesn't
4074 have the required privileges.
14ae4239 4075 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
4076 get_file_security_desc.
4077 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
4078 with addition of handling of symlinks and support for 'lstat'.
4079 If possible, get file's attributes and security information by
6dad7178
EZ
4080 handle, not by name. Produce S_IFLNK bit for symlinks, when
4081 called from 'lstat'.
4082 (stat, lstat): New functions, call 'stat_worker'.
4083 (symlink, readlink, careadlinkat): Rewritten to create and resolve
4084 symlinks when the underlying filesystem supports them.
4085
f162bcc3
PE
40862012-08-02 Paul Eggert <eggert@cs.ucla.edu>
4087
79ea6c20
PE
4088 Fix macroexp crash on Windows with debugging (Bug#12118).
4089 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
4090 checking subscripts; problem introduced with the recent
4091 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
4092 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
4093 since it's used in non-static inline functions now.
4094
c0ce93fd
PE
4095 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
4096 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 4097
f162bcc3
PE
4098 Use C99-style 'extern inline' if available.
4099 * buffer.h (BUFFER_INLINE):
4100 * category.h (CATEGORY_INLINE):
4101 * character.h (CHARACTER_INLINE):
4102 * charset.h (CHARSET_INLINE):
4103 * composite.h (COMPOSITE_INLINE):
4104 * dispextern.h (DISPEXTERN_INLINE):
4105 * lisp.h (LISP_INLINE):
4106 * systime.h (SYSTIME_INLINE):
4107 New macro, replacing 'static inline' in this header.
4108 * buffer.h, category.h, character.h, charset.h, composite.h:
4109 * dispextern.h, lisp.h, systime.h:
4110 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4111 * alloc.c (LISP_INLINE):
4112 * buffer.c (BUFFER_INLINE):
4113 * category.c (CATEGORY_INLINE):
4114 * character.c (CHARACTER_INLINE):
4115 * charset.c (CHARSET_INLINE):
4116 * composite.c (COMPOSITE_INLINE):
4117 * dispnew.c (DISPEXTERN_INLINE):
4118 * sysdep.c (SYSTIME_INLINE):
4119 Define to EXTERN_INLINE, so that the corresponding functions
4120 are compiled into code.
4121 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
4122 (INLINE_HEADER_END): New macros.
4123 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
4124 since it's used in non-static inline functions now.
a8333d03 4125 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 4126
837b365b
GM
41272012-08-02 Glenn Morris <rgm@gnu.org>
4128
d66b744d
GM
4129 * s/: Remove empty directory.
4130
837b365b
GM
4131 * s/ms-w32.h: Move to ../nt/inc.
4132 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
4133 Update for new ms-w32.h location.
4134
13294f95
PE
41352012-08-02 Paul Eggert <eggert@cs.ucla.edu>
4136
4137 Port to Solaris 8.
4138 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
4139
90df0db3
GM
41402012-08-02 Glenn Morris <rgm@gnu.org>
4141
4142 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
4143 hard-coding the path separator.
4144
4939150c
PE
41452012-08-01 Paul Eggert <eggert@cs.ucla.edu>
4146
4147 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
4148 This how ASET and AREF are supposed to work, and makes
4149 it easier to think about future improvements. See
4150 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
4151 * charset.h (set_charset_attr): New function.
4152 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
4153 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
4154 (aref_addr): New function. All uses of &AREF(...) changed.
4155 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
4156 (set_hash_index): New functions. All lvalue-style uses of
4157 HASH_KEY etc. changed.
4158 * keyboard.c (set_prop): New function. All lvalue-style uses
4159 of PROP changed.
4160
947b2afd
AA
41612012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
4162
4163 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
4164 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
4165 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
4166 * nsfns.m (ns_set_name_as_filename): Likewise.
4167 * nsmenu.m (ns_update_menubar): Likewise.
4168 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
4169
4f5d0325
EZ
41702012-08-01 Eli Zaretskii <eliz@gnu.org>
4171
2008beae
EZ
4172 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
4173 Adapt to latest changes in field names of the corresponding Lisp
288479f6 4174 objects.
2008beae 4175
4f5d0325
EZ
4176 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
4177
fe3cc771
GM
41782012-08-01 Glenn Morris <rgm@gnu.org>
4179
4180 * s/msdos.h: Remove file.
4181 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
4182 * Makefile.in (S_FILE): Remove.
4183 (config_h): Remove S_FILE.
4184
c90acc54
JB
41852012-08-01 Juanma Barranquero <lekktu@gmail.com>
4186
4187 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
4188 Remove; moved to nt/config.nt.
4189
d8a05828
DA
41902012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4191
4192 Use INTERNAL_FIELD for conses and overlays.
4193 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
4194 Remove obsolete comment.
4195 (MVAR): New macro.
4196 (struct Lisp_Overlay): Use INTERNAL_FIELD.
4197 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
4198
8271d590
DA
41992012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4200
4201 Use INTERNAL_FIELD for symbols.
4202 * lisp.h (SVAR): New macro. Adjust users.
4203 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
4204 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
4205
3193acd2
DA
42062012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4207
4208 Use INTERNAL_FIELD for processes.
4209 * process.h (PVAR): New macro. Adjust style.
4210 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
4211 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
4212
3a45383a
DA
42132012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4214
4215 Use INTERNAL_FIELD for windows.
4216 * window.h (WVAR): New macro.
4217 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
4218 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
4219 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
4220 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
4221 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
4222 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
4223
c1dbc63c
PE
42242012-08-01 Paul Eggert <eggert@cs.ucla.edu>
4225
4226 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
4227
5c0c0e8a
GM
42282012-08-01 Glenn Morris <rgm@gnu.org>
4229
4230 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
4231 Move to configure.ac.
4232
552a99b4
JB
42332012-08-01 Juanma Barranquero <lekktu@gmail.com>
4234
4235 * makefile.w32-in (CONFIG_H): Update dependencies.
4236 (CONF_POST_H): New macro.
4237
4238 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
4239
8d8e2dfe
GM
42402012-07-31 Glenn Morris <rgm@gnu.org>
4241
bc96620a
GM
4242 * Makefile.in (S_FILE): No longer set by configure.
4243
476b1b2d
GM
4244 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
4245 is available.
4246 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
4247
b2c7a106
GM
4248 * process.h (NULL_DEVICE):
4249 * emacs.c (SEPCHAR):
4250 * editfns.c (USER_FULL_NAME): Let configure set them.
4251
d53d062a
GM
4252 * s/README, s/template.h: Remove files.
4253
4515017f
GM
4254 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
4255
8d8e2dfe
GM
4256 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
4257 Move to configure.ac.
4258
5b20b3cc
EZ
42592012-07-31 Eli Zaretskii <eliz@gnu.org>
4260
1e0afd9a
EZ
4261 * .gdbinit (xframe): Adapt to introduction of FVAR and the
4262 resulting renaming of 'struct frame' members.
4263
5b20b3cc
EZ
4264 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
4265
4266 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
4267 after introduction of FVAR.
4268
f1310128
JD
42692012-07-31 Jan Djärv <jan.h.d@swipnet.se>
4270
79e721e0
JD
4271 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
4272
4273 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
4274 instead of compositeToPoint.
4275 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
4276
8d7c7eed 4277 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 4278
e34f7f79
DA
42792012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
4280
4281 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
4282 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 4283 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
4284 (BVAR): Change to use INTERNAL_FIELD.
4285 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
4286 (KVAR): Change to use INTERNAL_FIELD.
4287 * frame.h (FVAR): New macro.
4288 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
4289 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
4290 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
4291 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
4292 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
4293
c09bfb2f
DA
42942012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
4295
4296 Miscellaneous fixes for non-default X toolkits.
4297 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
4298 * xterm.c (x_frame_of_widget): Remove redundant prototype.
4299 Move under #ifdef USE_LUCID.
4300 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
4301 definition and usage to avoid warnings.
4302
14c114ae
JD
43032012-07-31 Jan Djärv <jan.h.d@swipnet.se>
4304
4305 * nsterm.m (openFiles): Fix previous checkin.
4306
3bd21e82
PE
43072012-07-31 Paul Eggert <eggert@cs.ucla.edu>
4308
4309 * indent.c (compute_motion): Remove unused local.
4310
c1529ded
GM
43112012-07-31 Glenn Morris <rgm@gnu.org>
4312
400d5621
GM
4313 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
4314
268e2432
GM
4315 * conf_post.h [USG5_4]:
4316 Move remaining contents of s/usg5-4-common.h here.
4317 * s/usg5-4-common.h: Remove file.
4318
7552f3ee
GM
4319 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
4320 * s/irix6-5.h: Remove file.
4321
6a381852
GM
4322 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
4323 * s/darwin.h: Remove file.
4324
c1529ded
GM
4325 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
4326 * s/hpux10-20.h: Remove file, which is now empty.
4327
b429a4ee
GM
43282012-07-30 Glenn Morris <rgm@gnu.org>
4329
4330 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
4331 * Makefile.in (config_h): Add conf_post.h.
4332 * makefile.w32-in (CONFIG_H): Add conf_post.h.
4333
adff3182
JD
43342012-07-30 Jan Djärv <jan.h.d@swipnet.se>
4335
4336 * nsterm.m (ns_do_open_file): New variable.
b9031d69 4337 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
4338 (openFile, openTempFile, openFileWithoutUI, openFiles):
4339 Open files only if ns_do_open_file.
adff3182 4340
c32af1e4
PE
43412012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4342
7393bcbb
PE
4343 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
4344 This no-op macro hasn't been needed for many years.
4345 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
4346
c32af1e4
PE
4347 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
4348 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
4349 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
4350 gdb_make_enums_visible.
4351 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
4352 (DIRECTORY_SEP): Now a constant, not a macro.
4353
302fc036
EZ
43542012-07-30 Eli Zaretskii <eliz@gnu.org>
4355
4356 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
4357 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
4358
4359 * w32term.c <w32_keyboard_codepage>: Renamed from
4360 keyboard_codepage and now external. All users changed.
4361
4362 * w32term.h: Add declaration of w32_keyboard_codepage.
4363
4364 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
4365 the codepage to translate keys to Unicode. If this argument is
4366 -1, use the value returned by GetConsoleCP. All callers changed.
4367
88fb40b4
PE
43682012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4369
0aee6912
PE
4370 Update .PHONY listings in makefiles.
4371 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
4372 bootstrap-clean, distclean, maintainer-clean, versioclean,
4373 extraclean, frc.
4374
88fb40b4
PE
4375 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
4376 This is a bit clearer. Fix some commentary typos.
4377
0a763bd1
GM
43782012-07-30 Glenn Morris <rgm@gnu.org>
4379
32bac6d6
GM
4380 * s/netbsd.h: Let configure include signal.h if needed.
4381 Remove file, which is now empty.
4382
b65e7c46
GM
4383 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
4384 Let configure set them.
4385 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
4386 No more need to undefine.
0a763bd1 4387
169304bd
AS
43882012-07-30 Andreas Schwab <schwab@linux-m68k.org>
4389
4390 * keymap.c (Fkey_description): Don't remove 0x80 bit from
4391 non-single-byte char when adding meta modifier. (Bug#12090)
4392
6cd7a139
DA
43932012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4394
4395 Convert safe_call to use variable number of arguments.
4396 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
4397 (safe_call2): Fix comment.
4398 * lisp.h (safe_call): Adjust prototype.
4399 * coding.c (encode_coding_object): Change to use safe_call2.
4400 * xfaces.c (merge_face_heights): Change to use safe_call1.
4401
d34d6ffc
GM
44022012-07-30 Glenn Morris <rgm@gnu.org>
4403
7b8a48e4 4404 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 4405 does that unconditionally. Remove file, which is now empty.
7b8a48e4 4406
d34d6ffc
GM
4407 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
4408 Remove empty files.
4409
03a660a6
PE
44102012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4411
4412 Export to GDB most of lisp.h's remaining object-like macros.
4413 * lisp.h (min, max): Move earlier, because they're used earlier now.
4414 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
4415 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
4416 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
4417 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
4418 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
4419 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
4420 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
4421 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
4422 Now constants, for GDB. They need not be macros.
4423 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
4424 Now constants, for GDB, as well as macros, for static initializers.
4425 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
4426 Move to after the definition of struct Lisp_Char_Table,
4427 since the former now needs that type defined.
4428 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
4429 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
4430 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
4431 New enums, for gdb_make_enums_visible.
4432 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 4433 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
4434 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
4435 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
4436 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
4437 enum maxargs, enum MAX_ALLOCA.
4438 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
4439 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
4440 no longer needed, now that they are done in lisp.h.
4441
e499d0ee
DA
44422012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4443
4444 Cleanup string bytes checking.
4445 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
4446 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
4447 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
4448 (check_sblock, compact_small_strings): Simplify.
4449
d5040d2d
PE
44502012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4451
4452 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
4453 These macros are confusing and no longer need to be defined, as
4454 the enum values now suffice. All uses replaced with definiens.
4455 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
4456
7f259ae6
JB
44572012-07-29 Juanma Barranquero <lekktu@gmail.com>
4458
4459 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
4460 ($(BLD)/w32console.$(O)): Update dependencies.
4461
7e63e0c3
DA
44622012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4463
4464 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
4465 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
4466 time. Adjust users.
4467 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
4468
ffd817eb
JD
44692012-07-29 Jan Djärv <jan.h.d@swipnet.se>
4470
4471 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
4472 setting sitelisp (Bug#12010).
4473
417a7a0e
EZ
44742012-07-29 Eli Zaretskii <eliz@gnu.org>
4475
14ae4239 4476 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
4477
4478 * w32heap.c (cache_system_info):
4479 * w32.c (sys_rename):
4480 * w32proc.c (find_child_console, sys_kill): All users changed.
4481
387d4d92
PE
44822012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
4485
55a6cca6
EZ
44862012-07-29 Eli Zaretskii <eliz@gnu.org>
4487
4488 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
4489
dbcf001c
DA
44902012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4491
4492 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
4493 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
4494 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 4495
e2688e4a
DA
44962012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4497
4498 Generalize marker debugging code under MARKER_DEBUG and use eassert.
4499 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
4500 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
4501 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
4502 (replace_range, replace_range_2, del_range_2): Change to eassert.
4503 * marker.c (byte_char_debug_check): Adjust style.
4504
b46a6a83
PE
45052012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4506
4507 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
4508 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
4509 long-ago-commented-out code that talks about "WIN32".
4510 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
4511 All uses changed.
4512
e32a5799
PE
45132012-07-28 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 Use Gnulib stdalign module (Bug#9772, Bug#9960).
4516 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
4517 Simplify by using alignof.
4518 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
4519 * lisp.h: Include <stdalign.h>.
4520 (GCALIGNMENT): New macro and constant.
4521 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
4522 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
4523 (stdalign): New macro, if not already defined.
4524
df81cd29
EZ
45252012-07-28 Eli Zaretskii <eliz@gnu.org>
4526
01bd1b0d
EZ
4527 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
4528 * w32inevt.c: Include w32inevt.h.
4529 (w32_read_console_input): New inline function, calls either
4530 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
4531 w32_console_unicode_input.
4532 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
4533 (w32_kbd_patch_key, key_event): Use the codepage returned by
4534 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
4535 (key_event): use uChar.UnicodeChar only if
4536 w32_console_unicode_input is non-zero.
4537
4538 * w32console.c: Include w32heap.h.
4539 <w32_console_unicode_input>: New global variable.
4540 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
4541 family of Windows, zero otherwise.
4542
4543 * w32inevt.h: Declare w32_console_unicode_input.
4544
df81cd29
EZ
4545 * xdisp.c (init_iterator): Don't reference tip_frame in a build
4546 --without-x. (Bug#11742)
4547
c20fdd9e
PE
45482012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4549
4550 Adjust GDB to reflect pvec_type changes (Bug#12036).
4551 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
4552 2012-07-04 changes to pseudovector representation.
4553 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 4554
32770973 45552012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
4556
4557 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
4558 bus address.
4559 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
4560
3438fe21
EZ
45612012-07-27 Eli Zaretskii <eliz@gnu.org>
4562
bcfbc9de
EZ
4563 * alloc.c (listn): Fix the order the arguments are consed onto the
4564 list.
4565
3438fe21
EZ
4566 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
4567 enumeration constants, as PURE and HEAP are too general, and clash
4568 with other headers and sources, such as gmalloc.c and the
4569 MS-Windows system headers. All users changed.
4570
eeaea515
DA
45712012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4572
4573 Revert last save_excursion_save and save_excursion_restore changes.
4574 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
4575 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
4576
073c88c2
DA
45772012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4578
4579 Fix recently-introduced typos in Windows port.
4580 Reported by Martin Rudalics <rudalics@gmx.at>.
4581 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 4582 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 4583
4706125e
PE
45842012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4585
4586 Improve GDB symbol export (Bug#12036).
4587 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
4588 arms of an 'if', not using conditional expressions; otherwise GDB
4589 complains about the types in the unevaluated arm when the argument
4590 is an integer literal.
4591 (xgetint): Simplify expression.
4592 * alloc.c (gdb_make_enums_visible): New constant. This ports to
4593 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
4594 Zaretskii in <http://bugs.gnu.org/12036#13>.
4595 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
4596 needed now that we have gdb_make_enums_visible.
4597 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
4598 (enum enum_USE_LSB_TAG):
4599 New enum types, packaging up enums that need to be exported to GDB.
4600
694b6c97
DA
46012012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4602
4603 Utility function to make a list from specified amount of objects.
4604 * lisp.h (enum constype): New datatype.
4605 (listn): New prototype.
4606 * alloc.c (listn): New function.
4607 (Fmemory_use_count, syms_of_alloc): Use it.
4608 * buffer.c (syms_of_buffer): Likewise.
4609 * callint.c (syms_of_callint): Likewise.
4610 * charset.c (define_charset_internal): Likewise.
4611 * coding.c (syms_of_coding): Likewise.
4612 * keymap.c (syms_of_keymap): Likewise.
4613 * search.c (syms_of_search): Likewise.
4614 * syntax.c (syms_of_syntax): Likewise.
4615 * w32.c (init_environment): Likewise.
4616 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
4617 * xdisp.c (syms_of_xdisp): Likewise.
4618 * xfns.c (syms_of_xfns): Likewise.
4619
6195f384
DA
46202012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4621
4622 Fast save_excursion_save and save_excursion_restore.
4623 * lisp.h (struct Lisp_Excursion): New data type.
4624 (PVEC_EXCURSION): New pseudovector type.
4625 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
4626 to deal with it. Adjust comments.
4627 (init_marker, attach_marker): New prototype.
4628 (unchain_marker): Adjust prototype.
4629 * marker.c (attach_marker): Change to global.
4630 (init_marker): New function.
4631 * alloc.c (Fmake_marker, build_marker): Use it.
4632 (build_marker): More easserts.
4633 (mark_object): Handle struct Lisp_Excursion.
4634 * editfns.c (save_excursion_save, save_excursion_restore):
4635 Reimplement to use struct Lisp_Excursion. Add comments.
4636
5eceb8fb
PE
46372012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4638
4639 Fix export of symbols to GDB (Bug#12036).
4640 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
4641 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
4642 emacs.c, as this is a more-suitable home. Had this been done earlier
4643 the fix for 12036 would have avoided some of the problems noted in
4644 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
4645 would have been more obvious.
562157c8
PE
4646 * emacs.c: Do not include <verify.h>; no longer needed.
4647 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
4648 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
4649 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4650 Remove; now done in lisp.h.
4651 * lisp.h (PUBLISH_TO_GDB): New macro.
4652 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
4653 (DATA_SEG_BITS): Use it.
4654 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
4655 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
4656 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
4657 not be usable in #if. This simplifies things.
4658
d6749401
JB
46592012-07-26 Juanma Barranquero <lekktu@gmail.com>
4660
4661 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
4662
1781b9e9
PE
46632012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4664
d89518db 4665 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
4666 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
4667 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
4668 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
4669 Adjust to changes in lisp.h and emacs.c, by using
4670 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
4671 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
4672 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
4673 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
4674 instead of gdb_valbits.
4675 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
4676 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
4677 instead of gdb_array_mark_flag.
4678 (xboolvector): Get size from $->size, not $->header.size.
4679 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
4680 (xreload, hook-run, hookpost-run): Remove.
4681 * emacs.c: Include <verify.h>.
4682 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
4683 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
4684 Remove.
4685 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
4686 (gdb_USE_LSB_TAG): New enum constants.
4687 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4688 Also define these as enum constants, so they're visible to GDB.
4689 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
4690 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
4691 as constants, so they're visible to GDB.
4692 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
4693 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
4694 Now enum constants, not macros, so they're visible to GDB.
4695 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
4696 more convenient now. All uses changed.
4697 (VALMASK) [USE_LSB_TAG]: Also define in this case.
4698 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
4699
3628596a
DA
47002012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
4701
4702 Explicitly free restriction data that are not needed anymore.
4703 * editfns.c (save_restriction_restore): Free restriction data.
4704
7abaf5cc
SM
47052012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
4706
4707 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
4708 add argument, tune behavior, and adjust all callers.
4709
71f88e00
PE
47102012-07-25 Paul Eggert <eggert@cs.ucla.edu>
4711
4712 Use typedef for EMACS_INT, EMACS_UINT.
4713 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
4714 than macros. This simplifies debugging in the usual case, since
4715 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
4716 and it allows expressions involving EMACS_INT casts.
4717 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
4718
57ec3034
JD
47192012-07-25 Jan Djärv <jan.h.d@swipnet.se>
4720
4721 * nsterm.m (ns_read_socket): Return early if there is a modal
4722 window (Bug#12043).
4723
8137e7b3
MR
47242012-07-25 Martin Rudalics <rudalics@gmx.at>
4725
4726 * frame.c (Fredirect_frame_focus): In doc-string don't mention
4727 that FOCUS-FRAME can be omitted.
4728
04e9897c
DA
47292012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
4730
4731 Adjust buffer text indirection counters at the end of Fkill_buffer.
4732 * buffer.c (Fkill_buffer): Adjust indirection counters when the
4733 buffer is definitely dead. This should really fix an issue reported
4734 by Christoph Scholtes again. (Bug#12007).
4735 (init_buffer_once): Initialize indirection counters of
4736 buffer_defaults and buffer_local_symbols (for sanity and safety).
4737
8a0484e1
EZ
47382012-07-24 Eli Zaretskii <eliz@gnu.org>
4739
4740 * xdisp.c (init_iterator): Don't compute dimensions of truncation
4741 and continuation glyphs on tooltip frames, leave them at zero.
4742 Avoids continued lines in tooltips. (Bug#11832)
4743
fa691a83
DA
47442012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
4745
4746 Simplify copy_overlay.
04e9897c 4747 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
4748 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
4749
436bc8e0
EZ
47502012-07-23 Eli Zaretskii <eliz@gnu.org>
4751
4752 * print.c (print_object): Don't crash when a frame's name is nil
4753 or invalid. (Bug#12025)
4754
4755 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
4756 it signals an error when a tooltip frame is being created.
4757
d7a7fda3
DA
47582012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
4759
4760 Cleanup miscellaneous objects allocation and initialization.
4761 * alloc.c (allocate_misc): Change to static. Add argument to
4762 specify the subtype. Adjust comment and users.
4763 (build_overlay): New function.
4764 * buffer.c (copy_overlays, Fmake_overlay): Use it.
4765 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
4766 (allocate_misc): Remove prototype.
4767 (build_overlay): Add prototype.
4768
47692012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
4770
4771 Swap buffer text indirection counters in Fbuffer_swap_text.
4772 * buffer.c (Fbuffer_swap_text): Swap indirections too.
4773 This avoids crash reported by Christoph Scholtes at
4774 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
4775
9d7fa573
JD
47762012-07-22 Jan Djärv <jan.h.d@swipnet.se>
4777
4778 * nsmenu.m (Popdown_data): New struct.
4779 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
4780 free Popdown_data.
4781 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
4782 (initWithContentRect): Make imgView and contentView non-static
4783 and autorelease them. Also autorelease img and matrix (Bug#12005).
4784 (dealloc): Remove (Bug#12005).
4785
0dd6d66d
DA
47862012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4787
4788 Adjust consing_since_gc when objects are explicitly freed.
4789 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
4790 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
4791 (free_cons, free_misc): Subtract object size from consing_since_gc.
4792
d36d71df
DA
47932012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4794
4795 Simplify and cleanup markers positioning code.
4796 * marker.c (attach_marker): More useful eassert.
4797 (live_buffer, set_marker_internal): New function.
4798 (Fset_marker, set_marker_restricted): Use set_marker_internal.
4799 (set_marker_both, set_marker_restricted_both): Use live_buffer.
4800
fb9ea40f
PE
48012012-07-22 Paul Eggert <eggert@cs.ucla.edu>
4802
4803 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
4804 as it's limited by the amount of memory, not by INT_MAX.
4805
2d5c5f7d
EZ
48062012-07-21 Eli Zaretskii <eliz@gnu.org>
4807
07fb592e
EZ
4808 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
4809 in special-event-map. See the discussion at
4810 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
4811 for the reasons.
4812
37a9eac8 4813 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
4814 info.dwItemData. Fixes crashes on 64-bit Windows.
4815 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 4816
c4328746
JD
48172012-07-21 Jan Djärv <jan.h.d@swipnet.se>
4818
fc0c31f8 4819 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 4820 (conversationIdentifier): Return value is NSInteger.
784051c4 4821 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 4822
6e5d1c12
CY
48232012-07-21 Chong Yidong <cyd@gnu.org>
4824
4825 * window.c (decode_any_window): Signal an error if the window is
4826 on a dead frame (Bug#11984).
4827
9928463d
DA
48282012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4829
4830 Add indirection counting to speed up Fkill_buffer.
4831 * buffer.h (struct buffer): New member.
4832 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
4833 (Fmake_indirect_buffer): Set indirection counter to -1, increment
4834 base buffer indirection counter.
4835 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
4836 (Fkill_buffer): Adjust indirection counters as needed, don't walk
4837 through buffer list if indirection counter is 0.
4838
f8643a6b
DA
48392012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4840
4841 Extend the value returned by Fgarbage_collect with heap statistics.
4842 * alloc.c (Qheap): New symbol.
4843 (syms_of_alloc): DEFSYM it.
4844 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
4845 (Fmemory_free): Remove.
4846 (syms_of_alloc): Don't defsubr it.
4847 * buffer.c (Fcompact_buffer): Remove.
4848 (syms_of_buffer): Don't defsubr it.
4849
dac616ff
DA
48502012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4851
4852 Make maybe_gc inline.
4853 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
4854 * lisp.h (consing_since_gc, gc_relative_threshold)
4855 (memory_full_cons_threshold): Revert declaration.
4856 (maybe_gc): Remove prototype, define as inline.
4857 * alloc.c: Remove old commented-out code.
4858 (consing_since_gc, gc_relative_threshold)
4859 (memory_full_cons_threshold): Revert to global.
4860 (maybe_gc): Remove.
4861
d7ea76b4
DA
48622012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4863
4864 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
4865 * lisp.h (build_unibyte_string): New function.
4866 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
4867 * sysdep.c, w32fns.c, xfns.c: Use it.
4868 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
4869 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
4870 Adjust users accordingly.
4871 * font.h (font_open_by_name): Adjust prototype.
4872
765e61e3
DA
48732012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4874
4875 Cleanup calls to Fgarbage_collect.
4876 * lisp.h (maybe_gc): New prototype.
4877 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4878 Remove declarations.
4879 * alloc.c (maybe_gc): New function.
4880 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4881 Make them static.
4882 * bytecode.c (MAYBE_GC): Use maybe_gc.
4883 * eval.c (eval_sub, Ffuncall): Likewise.
4884 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
4885 to avoid dependency from auto-save feature.
4886
52b852c7
PE
48872012-07-19 Paul Eggert <eggert@cs.ucla.edu>
4888
4889 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
4890 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
4891 'for_each_per_buffer_object_at'.
4892 All uses changed. It's better to use upper-case for macros that
4893 cannot be implemented as functions, to give the reader a clue
4894 that they're special.
4895
5db81e33
SM
48962012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
4897
4898 * alloc.c (Fgarbage_collect): Tweak docstring.
4899
5b835e1d
DA
49002012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4901
4902 Tweak the value returned from Fgarbage_collect again.
4903 * alloc.c (Fgarbage_collect): New return value, as confirmed in
4904 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
4905 Adjust documentation.
4906 (total_vector_bytes): Rename to total_vector_slots, adjust
4907 accounting.
4908 (total_free_vector_bytes): Rename to total_free_vector_slots,
4909 adjust accounting.
4910 (Qstring_bytes, Qvector_slots): New symbols.
4911 (syms_of_alloc): DEFSYM them.
4912
9cd47b72
DA
49132012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4914
4915 Buffer compaction primitive which may be used from Lisp.
4916 * buffer.c (compact_buffer, Fcompact_buffer): New function.
4917 (syms_of_buffer): Register Fcompact_buffer.
4918 * alloc.c (Fgarbage_collect): Use compact_buffer.
4919 * buffer.h (compact_buffer): New prototype.
4920 (struct buffer_text): New member.
4921
d17337e5
DA
49222012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4923
4924 New macro to iterate over all buffers, miscellaneous cleanups.
4925 * lisp.h (all_buffers): Remove declaration.
4926 * buffer.h (all_buffers): Add declaration, with comment.
4927 (for_each_buffer): New macro.
4928 * alloc.c (Fgarbage_collect, mark_object): Use it.
4929 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
4930 (init_buffer): Likewise.
4931 * data.c (Fset_default): Likewise.
4932 * coding.c (code_conversion_restore): Remove redundant check
4933 for dead buffer.
4934 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
4935
60cfd278
AS
49362012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4937
4938 Fix bug that created negative-length intervals.
4939 * intervals.c (merge_interval_right, merge_interval_left):
4940 Do not zero out this interval if it is absorbed by its children,
4941 as this interval's total length doesn't change in that case. See
4942 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
4943
d06714cb
PE
49442012-07-18 Paul Eggert <eggert@cs.ucla.edu>
4945
83713154
PE
4946 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
4947 when invoking (make-bool-vector N t) and N is a positive
4948 multiple of 8 -- the last 8 bits were mistakenly cleared.
4949
d06714cb
PE
4950 Remove some struct layout assumptions in bool vectors.
4951 * alloc.c (bool_header_size): New constant.
4952 (header_size, word_size): Move earlier, as they're now used earlier.
4953 Use 'word_size' in a few more places, where it's appropriate.
4954 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
4955 padding before the data member of a bool vector.
4956 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4957 than doing the check by hand with an abort ().
4958
464d5a5e
SM
49592012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4960
5fbc0409
SM
4961 * eval.c (Fdefvar): Don't check constants since we only set the var if
4962 it's not yet defined anyway (bug#11904).
4963
464d5a5e
SM
4964 * lisp.h (last_undo_boundary): Declare new var.
4965 * keyboard.c (command_loop_1): Set it.
4966 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4967 were auto-added by the command loop (bug#11774).
4968
8dc2e44a
AS
49692012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4970
4971 * w32font.c (Qsymbol): Remove local definition.
4972 (syms_of_w32font): Don't DEFSYM it.
4973
169925ec
DA
49742012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4975
4976 Fix sweep_vectors to handle large bool vectors correctly.
4977 * alloc.c (sweep_vectors): Account total_vector_bytes for
4978 bool vectors larger than VBLOCK_BYTES_MAX.
4979
5fbfb018
CY
49802012-07-18 Chong Yidong <cyd@gnu.org>
4981
4982 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4983 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4984
3ab6e069
DA
49852012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4986
4987 Return more descriptive data from Fgarbage_collect.
4988 Suggested by Stefan Monnier in
4989 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4990 * alloc.c (bounded_number): New function.
4991 (total_buffers, total_vectors): New variable.
4992 (total_string_size): Rename to total_string_bytes, adjust users.
4993 (total_vector_size): Rename to total_vector_bytes, adjust users.
4994 (sweep_vectors): Account total_vectors and total_vector_bytes.
4995 (Fgarbage_collect): New return value. Adjust documentation.
4996 (gc_sweep): Account total_buffers.
4997 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4998 (VECTOR_SIZE): Remove.
4999 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
5000 (Qinterval, Qmisc): New symbols.
5001 (syms_of_data): Initialize them.
5002 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
5003 (Qcons, Qbuffer): New declarations.
5004
6d02fe5b
PE
50052012-07-17 Paul Eggert <eggert@cs.ucla.edu>
5006
5007 * alloc.c (Fmemory_free): Account for memory-free's own storage.
5008 Round up, not down. Improve doc.
5009
b7ffe040
DA
50102012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5011
5012 Restore old code in allocate_string_data to avoid Faset breakage.
5013 Reported by Julien Danjou <julien@danjou.info> in
5014 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
5015 * alloc.c (allocate_string_data): Restore old code with minor
5016 adjustments, fix comment to explain this subtle issue.
5017
4dc7c8d5
SM
50182012-07-17 Eli Zaretskii <eliz@gnu.org>
5019
5020 Remove FILE_SYSTEM_CASE.
5021 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
5022
5023 * fileio.c (FILE_SYSTEM_CASE): Don't define.
5024 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
5025 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
5026 call-process-region passes it through expand-file-name.
5027
5028 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
5029
50302012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5031
5032 Fix crash when creating indirect buffer (Bug#11917)
5033 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
5034 Don't handle unbound variables specially if non-zero.
5035 (Fbuffer_local_variables): Pass zero.
5036 (clone_per_buffer_values): Pass non-zero.
5037
50382012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5039
5040 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
5041 to make the loop interruptible.
5042
50432012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5044
5045 * gnutls.c (emacs_gnutls_handshake): Only retry if
5046 GNUTLS_E_INTERRUPTED.
5047
cce7fefc
DA
50482012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5049
5050 Cleanup and convert miscellaneous checks to eassert.
5051 * alloc.c (mark_interval): Fix comment, partially rephrase
5052 old comment from intervals.h (see below).
5053 * intervals.c (find_interval, adjust_intervals_for_insertion)
5054 (delete_interval, adjust_intervals_for_deletion)
5055 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
5056 Convert to eassert.
5057 (adjust_intervals_for_insertion, make_new_interval):
5058 Remove obsolete and unused code.
5059 * intervals.h (struct interval): Remove obsolete comment.
5060 * textprotp.c (erase_properties): Remove unused code.
5061 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
5062 (Fremove_list_of_text_properties): Convert to eassert.
5063
9ea10cc3
CY
50642012-07-17 Chong Yidong <cyd@gnu.org>
5065
5066 * editfns.c (Finsert_char): Doc fix.
5067
3900d5de
DA
50682012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5069
5070 Fix previous change to make Fmemory_free always accurate.
5071 * alloc.c (make_interval): Update total_free_intervals.
5072 (make_float): Likewise for total_free_floats.
5073 (free_cons, Fcons): Likewise for total_free_conses.
5074 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
5075 Likewise for total_free_vector_bytes.
5076 (Fmake_symbol): Likewise for total_free_symbols.
5077 (bytes_free): Remove.
5078
7098646f
DA
50792012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5080
5081 Simple free memory accounting feature.
5082 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
5083 (sweep_vectors): Accumulate size of free vectors.
5084 (Fgarbage_collect): Setup bytes_free.
5085 (Fmemory_free): New function.
5086 (syms_of_alloc): Register it.
5087
22657b40
DA
50882012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5089
5090 Cleanup overlays checking.
5091 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
5092 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
5093 eassert and OVERLAYP.
5094 (sort_overlays): Change to use OVERLAYP.
5095
ddfc8813
RK
50962012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
5097
5098 * editfns.c (Finsert_char): Make it interactive, and make the
5099 second arg optional. Copy interactive spec and docstring from
5100 ucs-insert.
5101
7c26cf3c
PE
51022012-07-17 Paul Eggert <eggert@cs.ucla.edu>
5103
5104 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
5105 Unlike the other wrapped functions, fabs has an unspecified
5106 effect on errno.
5107
5d127af9
JD
51082012-07-16 Jan Djärv <jan.h.d@swipnet.se>
5109
5110 * nsterm.m (keyDown): Interpret flags without left/right bits
5111 as the left key (Bug#11670).
5112
6a0dd1d7
DA
51132012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
5114
5115 Remove empty and useless init functions.
5116 * lisp.h (init_character_once, init_fns, init_image)
5117 (init_filelock, init_sound): Remove prototype.
5118 * character.c (init_character_once): Remove.
5119 * filelock.c (init_filelock): Likewise.
5120 * fns.c (init_fns): Likewise.
5121 * image.c (init_image): Likewise.
5122 * sound.c (init_sound): Likewise.
5123 * emacs.c (main): Adjust accordingly.
5124
7a6136fd
DA
51252012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
5126
5127 * gtkutil.h: Tiny cleanups.
5128 (use_old_gtk_file_dialog): Remove useless declaration.
5129 (xg_uses_old_file_dialog): Add suggested const attribute.
5130
ce811ad9
EZ
51312012-07-15 Eli Zaretskii <eliz@gnu.org>
5132
5133 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
5134 (bidi_paragraph_init): Use it to limit search forward for a strong
5135 directional character in abnormally large paragraphs full of
5136 neutral or weak characters. (Bug#11943)
5137
c9adfeaa
SF
51382012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
5139
5140 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
5141 the toolbar (Bug#9451).
5142 (xg_make_tool_item): Give the widget event box a transparent
5143 background.
5144
fff62aa9
DA
51452012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
5146
5147 Cleanup basic allocation variables and functions.
5148 * alloc.c (ignore_warnings, init_intervals, init_float)
5149 (init_cons, init_symbol, init_marker): Remove.
5150 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
5151 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
5152 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
5153 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
5154 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
5155 (staticidx, init_alloc_once, init_strings, free_ablock):
5156 Remove redundant initialization.
5157 * fns.c (init_weak_hash_tables): Remove.
5158 * lisp.h (init_weak_hash_tables): Remove prototype.
5159
9730daca
DA
51602012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
5161
5162 Use zero_vector where appropriate.
5163 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
5164 accordingly.
5165 * lisp.h (zero_vector): New declaration.
5166 * font.c (null_vector): Remove.
5167 (syms_of_font): Remove initialization and staticpro.
5168 (font_list_entities, font_find_for_lface): Change to use zero_vector.
5169 * keymap.c (Faccessible_keymaps): Likewise.
5170
2e2d2a13
LL
51712012-07-15 Leo Liu <sdl.web@gmail.com>
5172
5173 * fringe.c: Fix typo in comments.
5174
cd276f6e
LL
51752012-07-14 Leo Liu <sdl.web@gmail.com>
5176
5177 * fringe.c: Add a new bitmap exclamation-mark.
5178
5a1131d9
EZ
51792012-07-14 Eli Zaretskii <eliz@gnu.org>
5180
5181 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
5182
5183 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
5184 (HAVE_MENUS): Don't define, defined by editing config.in with
5185 msdos/sed2v2.inp.
5186 (GMALLOC_INHIBIT_VALLOC): Don't define.
5187 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
5188
22e983b7
JB
51892012-07-14 Juanma Barranquero <lekktu@gmail.com>
5190
5191 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
5192
5b3f250f
GM
51932012-07-14 Glenn Morris <rgm@gnu.org>
5194
5195 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
5196 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
5197 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
5198
33d63ff4
GM
51992012-07-13 Glenn Morris <rgm@gnu.org>
5200
5b633342
GM
5201 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
5202
33d63ff4
GM
5203 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
5204 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
5205
b55b9f85
JD
52062012-07-13 Jan Djärv <jan.h.d@swipnet.se>
5207
0dc8cf50
JD
5208 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
5209 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
5210 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
5211 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
5212 where appropriate.
5213 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
5214 as boolean expression.
5215 (x_set_window_size): Remove unused variable toolbar.
5216 (ns_get_color_default, ns_mod_to_lisp): Remove.
5217 (ns_mouse_position): Remove unused variables xchar and ychar.
5218 (ns_compute_glyph_string_overhangs): Remove unused variable face.
5219 (ns_set_vertical_scroll_bar): Remove unused variable count.
5220 (ns_delete_terminal): Remove unused variable i.
5221 (ns_term_init): Remove unused variables r, g and b.
5222 (mouseDown): Remove unused variable window.
5223 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
5224 (initFrameFromEmacs): Remove unused variable vbextra.
5225 (mouseEntered): Remove unused variables p and dpyinfo.
5226 (mouseExited): Remove unused variables p and r.
5227 (ns_define_frame_cursor, ns_clear_frame_area)
5228 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
5229 (menuDown): Assign [sender tag] to variable and cast the variable.
5230
5231 * nsterm.h (menuDown): Add id as type to argument sender.
5232 (ns_display_info_for_name): Add Lisp_Object argument.
5233 (ns_term_init): Add Lisp_Object argument.
5234 (ns_map_event_to_object): Add void argument.
5235 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
5236 prototype with arguments and only declare if __OBJC__.
5237 (nxatoms_of_nsselect): Add void argument.
5238 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
5239 (ns_alloc_autorelease_pool): Add void argument.
5240 (ns_release_autorelease_pool): Add void* argument.
5241 (ns_get_defaults_value): Add const char* argument.
5242
5243 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
5244 (initFromContents): Use SSDATA where appropriate.
5245 (ns_update_menubar): Add braces to ambigous if-else.
5246 (initWithTitle): Put () around assignment in if statement.
5247 (ns_menu_show): Remove unused variables window and keymap.
5248 (update_frame_tool_bar): Remove unused variable selected_p.
5249 (initWithContentRect): Remove unused variable this_cmd_name.
5250
5251 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
5252 appropriate.
5253 (setXBMColor): Remove unused variable len.
5254 (setPixmapData): Put () around assignment in loop statement.
5255
5256 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
5257 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
5258 where appropriate.
5259 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
5260 around assignment in loop statement.
5261 (nsfont_open): Remove unused variable i.
5262 (nsfont_open): Remove unused variable len.
5263 (nsfont_draw): Remove unused variable cs.
5264
5265 * nsfns.m (x_set_icon_name, ns_set_name_internal)
5266 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
5267 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
5268 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
5269 (Fns_font_name, Fns_perform_service)
5270 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
5271 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
5272 (ns_set_name): Remove unused variable view.
5273 (x_set_menu_bar_lines): Remove unused variable olines.
5274 (x_set_tool_bar_lines): Remove unused variable root_window.
5275 (Fns_list_colors): Put () around assignment in while statement.
5276 (Fns_perform_service): Remove unused variable len.
5277 (Fns_display_usable_bounds): Remove unused variable top.
5278 (syms_of_nsfns): Remove unused variable i.
5279
b55b9f85
JD
5280 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
5281 memcpy (Bug#11907).
5282
ed9265fc 52832012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
5284
5285 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
5286 and free it with DestroyExceptionInfo (Bug#11558).
5287
ef099b57
JB
52882012-07-13 Juanma Barranquero <lekktu@gmail.com>
5289
5290 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
5291 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
5292 Set here, not in nt/config.nt.
5293
ea814a5d
EZ
52942012-07-13 Eli Zaretskii <eliz@gnu.org>
5295
5296 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
5297 cursor overflow into the last glyph on display line when the right
5298 fringe is off. (Bug#11832)
5299
1a952767
PE
53002012-07-13 Paul Eggert <eggert@cs.ucla.edu>
5301
5302 * xdisp.c (produce_special_glyphs): Now static.
5303 * dispextern.h (produce_special_glyphs): Remove decl.
5304
983188fd
GM
53052012-07-13 Glenn Morris <rgm@gnu.org>
5306
8d7c7eed 5307 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
5308 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
5309
983188fd
GM
5310 * s/usg5-4-common.h (USG, USG5):
5311 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
5312 * s/sol2-6.h (SOLARIS2):
5313 * s/irix6-5.h (IRIX6_5):
5314 * s/hpux10-20.h (USG, USG5, HPUX):
5315 * s/gnu-linux.h (USG, GNU_LINUX):
5316 * s/freebsd.h (BSD_SYSTEM):
5317 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
5318 * s/cygwin.h (CYGWIN):
5319 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
5320 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
5321
d1e68667 53222012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
5323
5324 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 5325
6de0e799
GM
53262012-07-13 Glenn Morris <rgm@gnu.org>
5327
739ae010
GM
5328 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
5329
dbee5793
GM
5330 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
5331
6de0e799
GM
5332 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
5333 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
5334
b82da769
GM
53352012-07-12 Glenn Morris <rgm@gnu.org>
5336
4fae5a7a 5337 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
5338
5339 * process.c (init_process_emacs): Rename from init_process.
5340 The old name is also the name of a Mach system call.
5341 * lisp.h, emacs.c: Update for this name change.
5342 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
5343 longer needed.
5344
5a979817
EZ
53452012-07-12 Eli Zaretskii <eliz@gnu.org>
5346
5347 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
5348 memmove call that removes glyphs covered by the left truncation
5349 glyph. Improve commentary.
5350 (display_line): Fix display of continuation glyphs on GUI frames
5351 when the right fringe is turned off and variable-size fonts are
5352 used in the window. Move the code that appends a stretch glyph to
5353 produce_special_glyphs, so that it could be used for truncation
5354 and continuation glyphs alike.
5355 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
5356 glyph of a suitably computed width, to align the special glyphs at
5357 the window margin. Code moved from display_line. (Bug#11832)
5358
3e91a053
GM
53592012-07-12 Glenn Morris <rgm@gnu.org>
5360
ba9e4b84
GM
5361 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
5362
5363 * s/gnu-linux.h, s/hpux10-20.h:
5364 Do not unconditionally define HAVE_XRMSETDATABASE.
5365
3e91a053
GM
5366 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
5367
b300b1f4
PE
53682012-07-12 Paul Eggert <eggert@cs.ucla.edu>
5369
5370 Fix typos that broke OS X build.
5371 Reported by Randal L. Schwartz in
5372 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
5373 * nsterm.m (ns_timeout): Add missing local decl.
5374 (ns_get_color): snprintf -> sprintf, to fix typo.
5375
6e777848
GM
53762012-07-12 Glenn Morris <rgm@gnu.org>
5377
3f922c37
GM
5378 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
5379 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
5380 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
5381 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
5382
0ab7b23a
GM
5383 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
5384 Move PTY_OPEN to configure.
5385
6e777848
GM
5386 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5387 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
5388 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
5389
4a7edc24
DA
53902012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
5391
5392 Use empty_unibyte_string where applicable.
5393 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
5394 * lread.c (read1): Likewise.
5395 * xsettings.c (syms_of_xsettings): Likewise.
5396
308aab79
GM
53972012-07-12 Glenn Morris <rgm@gnu.org>
5398
42bd1719
GM
5399 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
5400 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
5401 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
5402 * s/hpux10-20.h (RUN_TIME_REMAP):
5403 * s/bsd-common.h (TABDLY): Move to configure.
5404
5405 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
5406
5407 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
5408
ea0bbd17 5409 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 5410 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
5411
5412 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 5413
308aab79
GM
5414 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
5415 * s/template.h: Move NARROWPROTO to configure.
5416
ee1cf5cf
GM
54172012-07-11 Glenn Morris <rgm@gnu.org>
5418
30fe9bf4
GM
5419 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
5420 unused since 2011-01-17 change to systty.h.
5421
ee1cf5cf
GM
5422 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
5423 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5424 Move HAVE_PTYS and HAVE_SOCKETS to configure.
5425
63e47e07
PE
54262012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5427
5428 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
5429
c43fb4c3
GM
54302012-07-11 Glenn Morris <rgm@gnu.org>
5431
5432 * s/darwin.h, s/gnu-linux.h, s/template.h:
5433 Move INTERRUPT_INPUT to configure.
5434
e8df9267
DA
54352012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5436
5437 Minor adjustments to interning code.
5438 * lisp.h (intern, intern_c_string): Redefine as static inline
5439 wrappers for intern_1 and intern_c_string_1, respectively.
5440 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
5441 * lread.c (intern_1, intern_c_string_1, oblookup):
5442 Simplify Vobarray checking.
e8df9267
DA
5443 * font.c (font_intern_prop): Likewise. Adjust comment.
5444 * w32font.c (intern_font_name): Likewise.
5445
34348bd4
AS
54462012-07-11 Andreas Schwab <schwab@linux-m68k.org>
5447
d96a1e0c
AS
5448 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
5449
34348bd4
AS
5450 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
5451 of Fcar/Fcdr if possible.
5452 * font.c (check_otf_features): Likewise.
5453 * fontset.c (Fnew_fontset): Likewise.
5454 * gnutls.c (Fgnutls_boot): Likewise.
5455 * minibuf.c (read_minibuf): Likewise.
5456 * msdos.c (IT_set_frame_parameters): Likewise.
5457 * xmenu.c (Fx_popup_dialog): Likewise.
5458 * w32menu.c (Fx_popup_dialog): Likewise.
5459
c8add24e
GM
54602012-07-11 Glenn Morris <rgm@gnu.org>
5461
4b575b3c
GM
5462 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
5463 since nothing has defined it on these platforms.
5464
09f4e3b0
GM
5465 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
5466 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
5467
172bedef
GM
5468 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5469 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5470 Move CLASH_DETECTION to configure.
5471
249685df
GM
5472 * s/gnu.h: Remove file, which is now empty.
5473
c8add24e
GM
5474 * s/gnu.h, s/gnu-linux.h:
5475 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
5476
b41253a3
JW
54772012-07-11 John Wiegley <johnw@newartisans.com>
5478
5479 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
5480 function attribute, so we only use it if it exists in the
5481 compiler.
5482
d923b542
DA
54832012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5484
5485 Avoid call to strlen in fast_c_string_match_ignore_case.
5486 * search.c (fast_c_string_match_ignore_case): Change to use
5487 length argument. Adjust users accordingly.
5488 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
5489
5ebbef1d
PE
54902012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5491
bb352260
PE
5492 Assume mkdir, rmdir.
5493 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
5494 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
5495
57054ddd
PE
5496 Assume rename.
5497 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
5498
b747d3f7
PE
5499 Assume perror.
5500 * s/hpux10-20.h (HAVE_PERROR): Remove.
5501 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
5502 Remove dummy definition, as this problem was obsolete long ago.
5503
5ebbef1d
PE
5504 Assume strerror.
5505 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
5506
984e7f30
DA
55072012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5508
5509 Avoid calls to strlen in font processing functions.
5510 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
5511 (font_open_by_name): Change to use length argument.
5512 Adjust users accordingly.
d923b542
DA
5513 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
5514 Adjust prototypes.
5515 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
5516 Change to return ptrdiff_t.
984e7f30
DA
5517 (xfont_list_pattern, xfont_match): Use length returned by
5518 xfont_decode_coding_xlfd.
5519 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
5520
20e94fdd
GM
55212012-07-11 Glenn Morris <rgm@gnu.org>
5522
9d596af3
GM
5523 * s/darwin.h, s/freebsd.h, s/netbsd.h:
5524 Move DONT_REOPEN_PTY to configure.
5525
20e94fdd
GM
5526 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
5527 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
5528
e99a530f
PE
55292012-07-10 Paul Eggert <eggert@cs.ucla.edu>
5530
22ffb973
PE
5531 Remove "#define unix" that is no longer needed (Bug#11905).
5532 * s/aix4-2.h (unix): Remove; no longer needed.
5533
e9a9ae03
PE
5534 EMACS_TIME simplification (Bug#11875).
5535 This replaces macros (which typically do not work in GDB)
5536 with functions, typedefs and enums, making the code easier to debug.
5537 The functional style also makes code easier to read and maintain.
5538 * systime.h: Include <sys/time.h> on all hosts, not just if
5539 WINDOWSNT, since 'struct timeval' is needed in general.
5540 (EMACS_TIME): Now a typedef, not a macro.
5541 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
5542 not macros.
5543 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
5544 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
5545 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
5546 (EMACS_TIME_LE): Now functions, not macros.
5547 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
5548 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
5549 which are not functions. All uses rewritten to use:
5550 (make_emacs_time): New function.
5551 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
5552 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
5553 not functions. All uses rewritten to use the following, respectively:
5554 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
5555 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 5556 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
5557 * fileio.c (Fcopy_file):
5558 * xterm.c (XTflash): Get the current time closer to when it's used.
5559 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
5560
ffacb126
PE
5561 * bytecode.c (targets): Suppress -Woverride-init warnings.
5562
e99a530f
PE
5563 Simplify by avoiding confusing use of strncpy etc.
5564 * doc.c (Fsnarf_documentation):
5565 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
5566 * frame.c (Fmake_terminal_frame):
5567 * gtkutil.c (get_utf8_string):
5568 * lread.c (openp):
5569 * nsmenu.m (ns_update_menubar):
5570 * regex.c (regerror):
5571 Prefer memcpy to strncpy and strncat when either will do.
5572 * fileio.c (Fsubstitute_in_file_name):
5573 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
5574 (menu_separator_name_p):
5575 * nsmenu.m (ns_update_menubar):
5576 Prefer memcmp to strncmp when either will do.
5577 * nsterm.m: Include <ftoastr.h>.
5578 (ns_get_color):
5579 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
5580 Prefer snprintf to strncpy.
5581 * nsterm.m (ns_term_init):
5582 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
5583 * nsterm.m (ns_term_init):
5584 Avoid the need for strncpy, by using build_string or
5585 make_unibyte_string directly. Use dtoastr, not snprintf.
5586 * process.c (Fmake_network_process): Diagnose service names that
5587 are too long, rather than silently truncating them or creating
5588 non-null-terminated names.
5589 (Fnetwork_interface_info): Likewise, for interface names.
5590 * sysdep.c (system_process_attributes) [GNU_LINUX]:
5591 Prefer sprintf to strncat.
5592 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
5593 Prefer vsnprintf to vsprintf + strncpy.
5594
c59592b3
GM
55952012-07-10 Glenn Morris <rgm@gnu.org>
5596
5597 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
5598 Clarify fallback case.
5599
7d7bbefd
DA
56002012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5601
5602 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
5603 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
5604 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 5605 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
5606 where argument type is known to be a Lisp_Cons.
5607
3a4c8000
TT
56082012-07-10 Tom Tromey <tromey@redhat.com>
5609
5610 * bytecode.c (BYTE_CODE_THREADED): New macro.
5611 (BYTE_CODES): New macro. Replaces all old byte-code defines.
5612 (enum byte_code_op): New type.
5613 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
5614 (exec_byte_code): Use them. Use token threading when applicable.
5615
2a0213a6
DA
56162012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5617
5618 Optimize pure C strings initialization.
5619 * lisp.h (make_pure_string): Fix prototype.
5620 (build_pure_c_string): New function, defined as static inline. This
5621 provides a better opportunity to optimize away calls to strlen when
5622 the function is called with compile-time constant argument.
5623 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
5624 argument, adjust users accordingly. Use build_pure_c_string where
5625 appropriate.
5626 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
5627 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
5628 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
5629
cb1caeaf
DA
56302012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5631
5632 Avoid calls to strlen in miscellaneous functions.
5633 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
5634 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
5635 * lread.c (openp): Likewise.
5636
c293e30c
DA
56372012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5638
5639 Avoid calls to strlen in path processing functions.
5640 * fileio.c (file_name_as_directory): Add comment. Change to add
5641 srclen argument and return the length of result. Adjust users
5642 accordingly.
5643 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
5644 swap 1st and 2nd arguments to obey the common convention.
5645 Adjust users accordingly.
c293e30c
DA
5646 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
5647
9e059e3f
GM
56482012-07-10 Glenn Morris <rgm@gnu.org>
5649
d02eb359
GM
5650 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
5651 Move PENDING_OUTPUT_COUNT definition to configure.
5652
882cf227
GM
5653 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
5654 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
5655 * s/gnu.h (DATA_START): Move definitions to configure.
5656
af6e839f
GM
5657 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
5658 We include usg5-4-common.h, which defines them both.
5659
40289a12
GM
5660 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
5661 O_RDONLY already includes it).
5662
9e059e3f
GM
5663 Stop ns builds setting the EMACSLOADPATH environment variable.
5664 * nsterm.m (ns_load_path): Rename from ns_init_paths.
5665 Now it does not set EMACSLOADPATH, just returns the load-path string.
5666 * nsterm.h: Update accordingly.
5667 * lread.c [HAVE_NS]: Include nsterm.h.
5668 (init_lread) [HAVE_NS]: Use ns_load_path.
5669 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
5670
7c4e8ec0
GM
56712012-07-09 Glenn Morris <rgm@gnu.org>
5672
d4f600ff
GM
5673 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
5674 since the included bsd-common.h does so.
5675
cbb31951
GM
5676 Stop ns builds setting the EMACSPATH environment variable.
5677 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
5678 (ns_init_paths): Do not set EMACSPATH.
5679 * nsterm.h (ns_exec_path): Add it.
5680 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
5681 Use ns_exec_path.
5682
7c4e8ec0
GM
5683 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
5684
26bccfae
PE
56852012-07-09 Paul Eggert <eggert@cs.ucla.edu>
5686
a0bee46f
PE
5687 * process.c (wait_reading_process_output): 'waitchannels' was unset
5688 when read_kbd || !NILP (wait_for_cell); fix this.
5689
5994c183
PE
5690 Add GCC-style 'const' attribute to functions that can use it.
5691 * character.h (char_resolve_modifier_mask):
5692 * keyboard.h (make_ctrl_char):
5693 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
5694 (init_character_once, next_almost_prime, init_fns, init_image)
5695 (flush_pending_output, init_sound):
5696 * mem-limits.h (start_of_data):
5697 * menu.h (finish_menu_items):
5698 Add ATTRIBUTE_CONST.
5699 * emacs.c (DEFINE_DUMMY_FUNCTION):
5700 Declare the dummy function with ATTRIBUTE_CONST.
5701 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
5702 Add decls with ATTRIBUTE_CONST.
5703
26bccfae
PE
5704 Minor improvements to make_formatted_string.
5705 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
5706 where int is good enough, as vsprintf returns an int.
5707 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
5708
a8290ec3
DA
57092012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5710
5711 Use make_formatted_string to avoid double length calculation.
5712 * lisp.h (make_formatted_string): New prototype.
5713 * alloc.c (make_formatted_string): New function.
5714 * buffer.c (Fgenerate_new_buffer_name): Use it.
5715 * dbus.c (syms_of_dbusbind): Likewise.
5716 * editfns.c (Fcurrent_time_zone): Likewise.
5717 * filelock.c (get_boot_time): Likewise.
5718 * frame.c (make_terminal_frame, set_term_frame_name)
5719 (x_report_frame_params): Likewise.
5720 * image.c (gs_load): Likewise.
5721 * minibuf.c (get_minibuffer): Likewise.
5722 * msdos.c (dos_set_window_size): Likewise.
5723 * process.c (make_process): Likewise.
5724 * xdisp.c (ensure_echo_area_buffers): Likewise.
5725 * xsettings.c (apply_xft_settings): Likewise.
5726
d01ba2f1
GM
57272012-07-09 Glenn Morris <rgm@gnu.org>
5728
5729 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
5730 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
5731 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
5732 * nsterm.h (ns_etc_directory): Add it.
5733 * callproc.c [HAVE_NS]: Include nsterm.h.
5734 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
5735
f1f924b6
DA
57362012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5737
5738 Move marker debugging code under MARKER_DEBUG.
5739 * marker.c (MARKER_DEBUG): Move marker debugging code under
5740 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
5741 for bootstrap with --enable-checking (~3x slowdown reported
5742 by Juanma Barranquero <lekktu@gmail.com>).
5743 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
5744
ab531b66
PE
57452012-07-08 Paul Eggert <eggert@cs.ucla.edu>
5746
5747 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
5748 See <http://bugs.gnu.org/11825#29>.
5749
c4b3bc8a
EZ
57502012-07-08 Eli Zaretskii <eliz@gnu.org>
5751
5752 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
5753 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
5754 (display_line): Add commentary about displaying truncation glyphs
5755 on GUI frames.
5756 (produce_special_glyphs): Move here from term.c.
5757
5758 * term.c (produce_special_glyphs): Move to xdisp.c.
5759
5760 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
5761 section.
c4b3bc8a 5762
b676b881
AS
57632012-07-07 Andreas Schwab <schwab@linux-m68k.org>
5764
f17c5273
AS
5765 * xdisp.c (display_line): Avoid warning about implicit declaration
5766 of FRAME_FONT.
5767
298819b9
AS
5768 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
5769
b676b881
AS
5770 * lisp.h: Remove empty conditional.
5771
6045c4fd
PE
57722012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5773
b3350bf9
PE
5774 * lread.c (load_path_check): Now static.
5775
6045c4fd
PE
5776 Fix some minor --with-ns problems found by static checking.
5777 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
5778 (x_set_font) [!HAVE_X_WINDOWS]:
5779 * image.c (xpm_load_image) [HAVE_NS]:
5780 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
5781 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
5782 Remove unused local.
5783 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
5784 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
5785 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
5786 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
5787 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
5788 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
5789 Fix pointer signedness problem.
5790 * xfaces.c (FRAME_X_FONT_TABLE):
5791 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
5792
929e7845
GM
57932012-07-07 Glenn Morris <rgm@gnu.org>
5794
5795 * lread.c (load_path_check): New function, split from init_lread.
5796 (init_lread): Reorganize. Motivation:
5797 If EMACSLOADPATH is set, check/warn about that rather than the
5798 defaults, which we are not going to use. Hence we can remove
5799 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
5800 Don't warn if site-lisp directories are missing.
5801 If not installed, start from a blank load-path, since
5802 PATH_LOADSEARCH refers to the eventual installation directories.
5803
58dd0aa4
EZ
58042012-07-07 Eli Zaretskii <eliz@gnu.org>
5805
5806 Support truncation and continuation glyphs on GUI frames, when
5807 fringes are disabled. (Bug#11832)
5808 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
5809 continuation glyphs even if on GUI frames.
5810 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
5811 or both, are absent.
5812 (start_display, move_it_in_display_line_to): Handle the case of a
5813 GUI frame without a fringe to display continuation or truncation
5814 glyphs.
5815 (insert_left_trunc_glyphs): Support GUI frames: make sure
5816 truncation glyphs overwrite enough glyphs from the current line to
5817 have sufficient space in pixels.
5818 (display_line): Support truncation and continuation glyphs on GUI
5819 frames. If some spare pixels are left on the line after inserting
5820 the truncation glyphs, fill that space with a stretch glyph of a
5821 suitably computed width.
5822
5823 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
5824 produce_glyphs, to support GUI sessions.
5825
31571fd7
PE
58262012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5827
5a16b9bc
PE
5828 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
5829
f3047c75
PE
5830 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
5831
31571fd7
PE
5832 Do not require float-time's arg to fit in time_t (Bug#11825).
5833 This works better on hosts where time_t is unsigned, and where
5834 float-time is applied to the (negative) difference between two times.
5835 * editfns.c (decode_time_components): Last arg is now double *,
5836 not int *, and means to store all the result as a double, without
5837 worrying about whether the seconds part fits in time_t.
5838 All callers changed.
5839 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
5840 All callers changed.
5841 (Ffloat_time): Do not fail merely because the specified time falls
5842 outside of time_t range.
5843
4516fbef
GM
58442012-07-07 Glenn Morris <rgm@gnu.org>
5845
5846 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
5847 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
5848 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
5849
07adc2c6
JB
58502012-07-07 Juanma Barranquero <lekktu@gmail.com>
5851
5852 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
5853 Update dependencies.
5854
5855 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
5856
fd573f31
PE
58572012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5858
fee5959d
PE
5859 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
5860 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
5861 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
5862 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
5863 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
5864 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
5865
fd573f31
PE
5866 * xfont.c (compare_font_names): Redo to omit the need for casts.
5867
ddadbc0e
AS
58682012-07-06 Andreas Schwab <schwab@linux-m68k.org>
5869
fca8d6b6
AS
5870 * xfns.c (Fx_change_window_property): Doc fix.
5871 * w32fns.c (Fx_change_window_property): Doc fix.
5872
ddadbc0e
AS
5873 * w32fns.c (Fx_window_property): Accept the same arguments as the
5874 X Windows version. Doc fix.
5875 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
5876
ed9265fc 58772012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
5878 Eli Zaretskii <eliz@gnu.org>
5879
5880 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
5881 Windows-specific code from nt/config.nt moved here.
5882 Obsolete settings removed.
5883
216ee680
PE
58842012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5885
5886 * process.c: Avoid unnecessary calls to gettime.
5887 (wait_reading_process_output): Don't get the time of day
5888 when gobbling data immediately and not waiting, as there's no need
5889 for it in that case. This removes a FIXME.
5890
bdd091e4
JD
58912012-07-06 Jan Djärv <jan.h.d@swipnet.se>
5892
5893 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
5894 is defined (Bug#11768).
5895
9d44f8ce
DA
58962012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5897
5898 Fix marker debugging code.
5899 * marker.c (byte_char_debug_check): Do not perform the check
5900 if buffer is not multibyte.
090bd7cb
JB
5901 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5902 Call byte_char_debug_check with correct arguments.
9d44f8ce 5903
90fc4786
DA
59042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5905
5906 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
5907 * marker.c (byte_char_debug_check, count_markers):
5908 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
5909 (byte_debug_flag): Remove.
5910 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5911 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
5912
7b7ae965
DA
59132012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5914
4e57b342
DA
5915 Avoid code repetition in marker-related functions.
5916 * marker.c (attach_marker): New function.
5917 (Fset_marker, set_marker_restricted, set_marker_both)
5918 (set_marker_restricted_both): Use it.
5919 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
5920 Consistently rename charno to charpos.
5921 (marker_position): Add eassert.
5922 (marker_byte_position): Convert to eassert.
5923
59242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5925
5926 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 5927 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 5928 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 5929
657924ff
DA
59302012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5931
5932 Introduce fast path for the widely used marker operation.
5933 * alloc.c (build_marker): New function.
5934 * lisp.h (build_marker): New prototype.
5935 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
5936 * composite.c (autocmp_chars): Likewise.
5937 * editfns.c (buildmark): Remove.
5938 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
5939 (save_restriction_save): Use build_marker.
5940 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
5941 * window.c (save_window_save): Likewise.
5942
041a49a6
DA
59432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5944
5945 Do not use Fdelete_overlay in delete_all_overlays
5946 to avoid redundant calls to unchain_overlay.
5947 * buffer.c (drop_overlay): New function.
5948 (delete_all_overlays, Fdelete_overlay): Use it.
5949 * minibuf.c (get_minibuffer): Fix comment.
5950
7dca65a4
PE
59512012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5952
5953 Port to OpenBSD 5.1 amd64.
5954 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
5955 This is needed for OpenBSD, and should be harmless on all BSD systems.
5956 Also, include <sys/sysctl.h>, as it should be available on all
5957 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5958 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5959 use p_pid member, not kp_proc.pid.
5960
8eb876e2
GM
59612012-07-06 Glenn Morris <rgm@gnu.org>
5962
5963 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5964
38182d90
PE
59652012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5966
5967 More xmalloc and related cleanup.
5968 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5969 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5970 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5971 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5972 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5973 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5974 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5975 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5976 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5977 * xterm.c:
5978 Omit needless casts involving void * pointers and allocation.
5979 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5980 as the former is more robust if P's type is changed.
5981 Prefer xzalloc to xmalloc + memset 0.
5982 Simplify malloc-or-realloc to realloc.
5983 Don't worry about xmalloc returning a null pointer.
5984 Prefer xstrdup to xmalloc + strcpy.
5985 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5986 growing it.
5987 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5988 alloca of a constant.
5989
6dd5a677
EZ
59902012-07-05 Eli Zaretskii <eliz@gnu.org>
5991
5992 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5993 hscroll is larger than the line width. Fixes long and futile
5994 looping inside extend_face_to_end_of_line (on a TTY) producing
5995 glyphs that are not needed and thrown away.
5996
6b312f0f
DA
59972012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5998
5999 * marker.c (set_marker_restricted_both): Simplify by using
6000 clip_to_bounds.
6001
f520ef9b
PE
60022012-07-05 Paul Eggert <eggert@cs.ucla.edu>
6003
6004 * editfns.c (region_limit): Simplify by using clip_to_bounds.
6005
383b7c95
JD
60062012-07-05 Jan Djärv <jan.h.d@swipnet.se>
6007
6008 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
6009 not defined (Bug#11768).
6010 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
6011 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
6012 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
6013 followed by gtk_box_set_homogeneous (Bug#11768).
6014 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
6015 (update_theme_scrollbar_width, xg_create_scroll_bar):
6016 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
6017 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
6018 (is_box_type): New function (Bug#11768).
6019 (xg_tool_item_stale_p): Call is_box_type.
5293d758 6020 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
6021 with default display (Bug#11768).
6022
d6e7bf45
EZ
60232012-07-05 Eli Zaretskii <eliz@gnu.org>
6024
6025 * xdisp.c (window_hscroll_limited): New function.
6026 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
6027 coordinates when window's hscroll is set to insanely large
6028 values. (Bug#11857)
6029
431391ec
JB
60302012-07-05 Juanma Barranquero <lekktu@gmail.com>
6031
6032 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
6033 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
6034
23f86fce
DA
60352012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
6036
6037 Cleanup xmalloc.
6038 * lisp.h (xzalloc): New prototype. Omit needless casts.
6039 * alloc.c (xzalloc): New function. Omit needless casts.
6040 * charset.c: Omit needless casts. Convert all calls to
6041 xmalloc with following memset to xzalloc.
6042 * dispnew.c: Likewise.
6043 * fringe.c: Likewise.
6044 * image.c: Likewise.
6045 * sound.c: Likewise.
6046 * term.c: Likewise.
6047 * w32fns.c: Likewise.
6048 * w32font.c: Likewise.
6049 * w32term.c: Likewise.
6050 * xfaces.c: Likewise.
6051 * xfns.c: Likewise.
6052 * xterm.c: Likewise.
6053 * atimer.c: Omit needless casts.
6054 * buffer.c: Likewise.
6055 * callproc.c: Likewise.
6056 * ccl.c: Likewise.
6057 * coding.c: Likewise.
6058 * composite.c: Likewise.
6059 * doc.c: Likewise.
6060 * doprnt.c: Likewise.
6061 * editfns.c: Likewise.
6062 * emacs.c: Likewise.
6063 * eval.c: Likewise.
6064 * filelock.c: Likewise.
6065 * fns.c: Likewise.
6066 * gtkutil.c: Likewise.
6067 * keyboard.c: Likewise.
6068 * lisp.h: Likewise.
6069 * lread.c: Likewise.
6070 * minibuf.c: Likewise.
6071 * msdos.c: Likewise.
6072 * print.c: Likewise.
6073 * process.c: Likewise.
6074 * region-cache.c: Likewise.
6075 * search.c: Likewise.
6076 * sysdep.c: Likewise.
6077 * termcap.c: Likewise.
6078 * terminal.c: Likewise.
6079 * tparam.c: Likewise.
6080 * w16select.c: Likewise.
6081 * w32.c: Likewise.
6082 * w32reg.c: Likewise.
6083 * w32select.c: Likewise.
6084 * w32uniscribe.c: Likewise.
6085 * widget.c: Likewise.
6086 * xdisp.c: Likewise.
6087 * xmenu.c: Likewise.
6088 * xrdb.c: Likewise.
6089 * xselect.c: Likewise.
6090
0497dc44
PE
60912012-07-05 Paul Eggert <eggert@cs.ucla.edu>
6092
6093 * fileio.c (time_error_value): Check the right error number.
6094 Problem reported by Troels Nielsen in
6095 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
6096
356e7178
PE
60972012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6098
4e71fd89
PE
6099 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
6100 This should be fixed in a better way; see Eli Zaretskii in
6101 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
6102 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
6103
f0941253
PE
6104 * fileio.c (time_error_value): Rename from special_mtime.
6105 The old name's problems were noted by Eli Zaretskii in
6106 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
6107
065c9eb4
PE
6108 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
6109 This variable's comment says Emacs needs at least one GDB-visible
6110 symbol of type enum pvec_type, to work around GDB problems.
6111 The symbol's value doesn't matter.
6112
356e7178
PE
6113 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
6114 that causes compilation to fail on pre-C99 compilers.
6115
ed9265fc 61162012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
6117
6118 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
6119 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
6120
3884d954
DA
61212012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6122
d209e2fb 6123 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
6124 headers for buffer_defaults and buffer_local_symbols.
6125 Reported by Juanma Barranquero <lekktu@gmail.com>.
6126
ee28be33
SM
61272012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6128
6129 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
6130 * lisp.h (enum pvec_type): Use fewer bits.
6131 (PSEUDOVECTOR_SIZE_BITS): New constant.
6132 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
6133 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
6134 change in pvec_type.
6135 (PSEUDOVECTOR_TYPEP): New macro.
6136 (TYPED_PSEUDOVECTORP): Use it.
6137 * fns.c (internal_equal): Adapt code to extract pvectype.
6138 * emacs.c (gdb_pvec_type): Update type.
6139 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
6140 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
6141 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
6142 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
6143 (sweep_vectors): Use it. Use local var `total_bytes' instead of
6144 abusing vector->header.next.nbytes.
6145 (live_vector_p): Use PVEC_TYPE.
6146 (mark_object): Adapt code to extract pvectype. Use switch.
6147
c7f2cd7f
PE
61482012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6149
6150 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
6151 Tighten new eassert a bit.
6152
8ce70ed2
DA
61532012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6154
6155 Fix compilation with --enable-gcc-warnings and -O1
6156 optimization level.
6157 * doprnt.c (doprnt): Change type of tem to int, initialize
6158 to avoid compiler warning. Add eassert.
6159 * search.c (simple_search): Initialize match_byte to avoid
6160 compiler warning. Add eassert.
6161
dea7f1e5
PE
61622012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6163
24a212eb
PE
6164 Avoid weird behavior with large horizontal scrolls.
6165 Without this change, for example, large hscroll values would
6166 mess up Emacs's display on Fedora 15 x86, presumably due to
6167 overflows in int calculations in the display code.
6168 Also, if buffers had long lines, Emacs would freeze.
6169 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
6170 (set_window_hscroll): New function, containing the old guts of
6171 Fset_window_hscroll. Return the clipped value.
6172 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
6173 This avoids the need to check against PTRDIFF_MAX.
6174
dea7f1e5
PE
6175 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
6176
76046526
DA
61772012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6178
6179 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
6180
39adff0d
PE
61812012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6182
63807d47
PE
6183 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
6184 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
6185 since GCC 4.4.6 issues a bogus warning for them.
6186
39adff0d
PE
6187 Fix bugs in file timestamp newness comparisons.
6188 * fileio.c (Ffile_newer_than_file_p):
6189 * lread.c (Fload): Use full timestamp resolution of files,
6190 not just the 1-second resolution, so that files that are only
6191 slightly newer still count as newer.
6192 * fileio.c (Ffile_newer_than_file_p): Don't assume file
6193 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
6194
dbeed9a6
PE
61952012-07-03 Paul Eggert <eggert@cs.ucla.edu>
6196
6197 * fileio.c: Improve handling of file time marker. (Bug#11852)
6198 (special_mtime): New function.
6199 (Finsert_file_contents, Fverify_visited_file_modtime):
6200 Use it to set special mtime values consistently.
6201
636334d6
AS
62022012-07-03 Andreas Schwab <schwab@linux-m68k.org>
6203
6204 * fileio.c (Finsert_file_contents): Properly handle st_mtime
6205 marker for non-existing file. (Bug#11852)
6206
e2017fe2
GM
62072012-07-03 Glenn Morris <rgm@gnu.org>
6208
6209 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
6210 and did not make it into globals.h).
6211
404dbd37
TT
62122012-07-03 Tom Tromey <tromey@redhat.com>
6213
6214 * window.c (Fset_window_margins, Fset_window_fringes)
6215 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
6216 * textprop.c (Fprevious_property_change): No longer static.
6217 * syntax.c (Fsyntax_table_p): No longer static.
6218 * process.c (Fget_process, Fprocess_datagram_address): No longer
6219 static.
6220 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
6221 * keyboard.c (Fcommand_execute): No longer static.
6222 Remove EXFUN.
6223 * insdel.c (Fcombine_after_change_execute): No longer static.
6224 * image.c (Finit_image_library): No longer static.
6225 * fileio.c (Fmake_symbolic_link): No longer static.
6226 * eval.c (Ffetch_bytecode): No longer static.
6227 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
6228 * doc.c (Fdocumentation_property, Fsnarf_documentation):
6229 No longer static.
404dbd37
TT
6230 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
6231 static.
6232 * dired.c (Ffile_attributes): No longer static.
6233 * composite.c (Fcomposition_get_gstring): No longer static.
6234 * callproc.c (Fgetenv_internal): No longer static.
6235
6236 * ccl.h: Remove EXFUNs.
6237 * buffer.h: Remove EXFUNs.
6238 * dispextern.h: Remove EXFUNs.
6239 * intervals.h: Remove EXFUNs.
6240 * fontset.h: Remove EXFUN.
6241 * font.h: Remove EXFUNs.
6242 * dosfns.c (system_process_attributes): Remove EXFUN.
6243 * keymap.h: Remove EXFUNs.
6244 * lisp.h: Remove EXFUNs.
6245 * w32term.h: Remove EXFUNs.
6246 * window.h: Remove EXFUNs.
6247 * xsettings.h: Remove EXFUN.
6248 * xterm.h: Remove EXFUN.
6249
8e4fd1e1
GM
62502012-07-03 Glenn Morris <rgm@gnu.org>
6251
6252 * lisp.h (Frandom): Make it visible to C.
6253 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
6254 buffer for invisible buffers. (Bug#1229)
6255
ca95b3eb
DA
62562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6257
6258 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
6259 values which aren't power of 2.
14ae4239
BT
6260 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
6261 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
6262 accordingly.
6263
7555c33f
SM
62642012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
6265
6266 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
6267
6268 * alloc.c (mark_object): Revert part of last patch to use `switch'.
6269
d12e8f5a
DA
62702012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6271
6272 * alloc.c (allocate_vector_block): Remove redundant
6273 calls to mallopt if DOUG_LEA_MALLOC is defined.
6274 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
6275 avoid calls to mallopt if zero_vector is returned.
6276
296094c3
DA
62772012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6278
6279 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
6280 is enabled, avoid dereferencing NULL current_sblock if
6281 running undumped.
6282
36429c89
DA
62832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6284
6285 Cleanup basic buffer management.
6286 * buffer.h (struct buffer): Change layout to use generic vector
6287 marking code. Fix some comments. Change type of 'clip_changed'
6288 to bitfield. Remove unused #ifndef old.
6289 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
6290 (GET_OVERLAYS_AT): Fix indentation.
6291 (for_each_per_buffer_object_at): New macro.
6292 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
6293 (Fbuffer_local_variables): Use it.
6294 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
6295 * alloc.c (allocate_buffer): Adjust to match new layout of
6296 struct buffer. Fix comment.
6297 (mark_overlay): New function.
6298 (mark_buffer): Use it. Use mark_vectorlike to mark normal
6299 Lisp area of struct buffer.
6300 (mark_object): Use it. Adjust marking of misc objects
6301 and related comments.
6302
3b3e4cac
PE
63032012-07-02 Paul Eggert <eggert@cs.ucla.edu>
6304
6305 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
6306 wrapper that is not needed because the wrapped code is a no-op (zero
6307 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
6308 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
6309
cf5c0175
DA
63102012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
6311
6312 * alloc.c (mark_buffer): Simplify. Remove prototype.
6313 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 6314 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
6315 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
6316 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 6317
ca26824c
GM
63182012-06-30 Glenn Morris <rgm@gnu.org>
6319
2e4c5312
GM
6320 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
6321
ca26824c
GM
6322 * epaths.in (PATH_SITELOADSEARCH): New.
6323 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
6324 This is rather than relying on --enable-locallisppath elements
6325 having "site-lisp" in their names. (Bug#10208#25, 11658)
6326
0d23c240
EZ
63272012-06-30 Eli Zaretskii <eliz@gnu.org>
6328
c9240d7a
EZ
6329 * w32proc.c (sys_select): Accept and ignore one more argument.
6330
6331 * w32.c (emacs_gnutls_pull): Call select with one more argument.
6332
0d23c240 6333 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 6334 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
6335
6336 * sysdep.c: Don't include dos.h and dosfns.h.
6337
6338 * process.c (sys_select):
6339 * msdos.c (sys_select): Accept one more argument and ignore it.
6340
6341 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
6342 adapt data types and code to that.
6343
6344 * dosfns.c:
6345 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
6346 which clashes with the gnulib function of the same name.
6347
af5a5a98
AS
63482012-06-30 Andreas Schwab <schwab@linux-m68k.org>
6349
c5e4379c
AS
6350 * font.c (font_style_to_value, font_style_symbolic)
6351 (font_prop_validate_style): Add type checks for values in
6352 font_style_table.
6353
af5a5a98
AS
6354 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
6355 argument.
6356 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
6357 uses.
6358
8d38f461
EZ
63592012-06-29 Eli Zaretskii <eliz@gnu.org>
6360
2e5a6631
EZ
6361 * xdisp.c (try_window_id): Undo last change.
6362
8d38f461
EZ
6363 * w32.c (getwd): Adjust commentary about startup_dir.
6364 (init_environment): Always call sys_access, even in non-MSVC
6365 builds. Don't chdir to the directory of the Emacs executable.
6366 This undoes code from 1997 which was justified by the need to
6367 "avoid conflicts when removing and renaming directories". But its
6368 downside was that every relative file name was being interpreted
6369 relative to the directory of the Emacs executable, which can never
6370 be TRT. In particular, it broke sys_access when called with
6371 relative file names.
6372 (sys_access): Map GetLastError to errno.
6373
2af3565e
DA
63742012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6375
6376 * window.h (struct window): Change type of 'fringes_outside_margins'
6377 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 6378 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
6379 Adjust comment.
6380 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
6381 to ptrdiff_t.
6382
c8d3a25c 63832012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 6384
c8d3a25c
GM
6385 * gnutls.c (emacs_gnutls_handshake):
6386 Add QUIT to make the loop interruptible.
57570cd3 6387
c8d3a25c 63882012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 6389
c8d3a25c
GM
6390 * charset.c (init_charset): Make lack of etc/charsets fatal.
6391
3e984ee8
DA
63922012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6393
6394 * editfns.c (region_limit): Fix type mismatch.
6395
ef884f23
DA
63962012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6397
6398 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
6399 undefined. Convert from xassert to eassert.
6400 * nsmenu.m: Convert from xassert to eassert.
6401 * nsterm.m: Likewise.
6402
7d7e0027
SM
64032012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
6404
6405 * editfns.c (region_limit): Clip to narrowing (bug#11770).
6406
aa754e6a
PE
64072012-06-28 Paul Eggert <eggert@cs.ucla.edu>
6408
6409 Avoid integer overflow on scroll-left and scroll-right.
6410 * window.c (HSCROLL_MAX): New macro.
6411 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
6412 overflow when requested scroll falls outside ptrdiff_t range.
6413
80b00b08
DA
64142012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6415
6416 * window.h (struct window): Change type of 'hscroll',
6417 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
6418 'last_modified' and 'last_overlay_modified' to EMACS_INT.
6419 Adjust users accordingly.
6420 * xdisp.c (try_cursor_movement): Replace type check with eassert.
6421 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
6422 from EMACS_INT to ptrdiff_t.
6423 (make_window): Omit redundant initialization.
6424
62b2bcf6
JB
64252012-06-28 Juanma Barranquero <lekktu@gmail.com>
6426
6427 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
6428
45942c7d
DA
64292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6430
6431 * window.h (struct window): Change type of 'use_time' and
6432 'sequence_number' from Lisp_Object to int.
6433 * frame.c (make_frame): Adjust users accordingly.
6434 * print.c (print_object): Likewise.
6435 * window.c (select_window, Fwindow_use_time, make_parent_window)
6436 (make_window): Likewise.
6437
e509cfa6
DA
64382012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6439
6440 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
6441 enabled with --enable-checking=[all,glyphs] configure option.
6442 Fix GLYPH_DEBUG usage assuming that it may be undefined,
6443 adjust comments accordingly.
6444 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
6445 undefined, adjust comments accordingly.
6446 * image.c: Likewise.
6447 * scroll.c: Likewise.
6448 * w32fns.c: Likewise.
6449 * w32term.c: Likewise.
6450 * xdisp.c: Likewise.
6451 * xfaces.c: Likewise.
6452 * xfns.c: Likewise.
6453 * xterm.c: Likewise.
6454
a54e2c05
DA
64552012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6456
6457 Generalize run-time debugging checks.
6458 * dispextern.h (XASSERTS): Remove.
6459 * fontset.c (xassert): Remove.
6460 Convert from xassert to eassert.
6461 * alloc.c: Convert from xassert to eassert.
6462 * bidi.c: Likewise.
6463 * dispnew.c: Likewise.
6464 * fns.c: Likewise.
6465 * fringe.c: Likewise.
6466 * ftfont.c: Likewise.
6467 * gtkutil.c: Likewise.
6468 * image.c: Likewise.
6469 * keyboard.c: Likewise.
6470 * menu.c: Likewise.
6471 * process.c: Likewise.
6472 * scroll.c: Likewise.
6473 * sound.c: Likewise.
6474 * term.c: Likewise.
6475 * w32console.c: Likewise.
6476 * w32fns.c: Likewise.
6477 * w32term.c: Likewise.
6478 * window.c: Likewise.
6479 * xdisp.c: Likewise.
6480 * xfaces.c: Likewise.
6481 * xfns.c: Likewise.
6482 * xselect.c: Likewise.
6483 * xterm.c: Likewise.
6484
1ec4b7b2
SM
64852012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
6486
6487 * fns.c (maybe_resize_hash_table): Output message when growing the
6488 purify-hashtable.
6489
2014308a
DA
64902012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6491
6492 * alloc.c (allocate_string_data): Remove dead code.
6493 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
6494 avoid GCC warning about unused macro.
6495
246155eb
DA
64962012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6497
6498 * alloc.c (allocate_string): Omit intervals initialization.
6499 * alloc.c (make_uninit_multibyte_string): Initialize intervals
6500 as in make_pure_string and make_pure_c_string.
6501
43184b7b
DA
65022012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6503
d209e2fb 6504 * alloc.c (allocate_string): Fix last change.
43184b7b 6505
3fe6dd74
DA
65062012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6507
d209e2fb 6508 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
6509 to memset, add explicit initialization where appropriate.
6510
1ba6038a
GM
65112012-06-27 Glenn Morris <rgm@gnu.org>
6512
6513 * lisp.mk (lisp): Remove paths.elc.
6514
c89926a5
CY
65152012-06-27 Chong Yidong <cyd@gnu.org>
6516
6517 * doc.c (Fsubstitute_command_keys): Fix punctuation.
6518
ed6b3510
JW
65192012-06-26 John Wiegley <johnw@newartisans.com>
6520
1ec4b7b2 6521 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
6522 on Mac OS X Lion: __mod_init_func and __mod_term_func.
6523
ed6b3510
JW
6524 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
6525 when building with Clang.
6526
8edd4a2b
SM
65272012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
6528
6529 * eval.c (Fapply): Allow calling it with a single argument.
6530
f6f62d1b
EZ
65312012-06-26 Eli Zaretskii <eliz@gnu.org>
6532
6533 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
6534 _stricmp and _strnicmp.
6535 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
6536
62efea5e
DA
65372012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6538
6539 * alloc.c (allocate_window): Zero out non-Lisp part of newly
6540 allocated window.
6541 (allocate_process): Likewise for new process.
8edd4a2b 6542 (allocate_terminal): Change to use offsetof.
62efea5e
DA
6543 (allocate_frame): Likewise.
6544 * frame.c (make_frame): Omit redundant initialization.
6545 * window.c (make_parent_window): Use memset.
6546 (make_window): Omit redundant initialization.
6547 * process.c (make_process): Omit redundant initialization.
6548 * terminal.c (create_terminal): Likewise.
6549
42997f4d
DA
65502012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6551
6552 * term.c (delete_tty): Remove redundant call to memset.
6553
1130ecfc
DA
65542012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6555
6556 * alloc.c: Remove build_string.
6557 * lisp.h: Define build_string as static inline. This provides
6558 a better opportunity to optimize away calls to strlen when the
6559 function is called with compile-time constant argument.
6560 * image.c (imagemagick_error): Convert to build_string.
6561 * w32proc.c (sys_spawnve): Likewise.
6562 * xterm.c (x_term_init): Likewise.
6563
cf38a720
PE
65642012-06-26 Paul Eggert <eggert@cs.ucla.edu>
6565
99027bdd
PE
6566 Use sprintf return value instead of invoking strlen on result.
6567 In the old days this wasn't portable, since some sprintf
6568 implementations returned char *. But they died out years ago and
6569 Emacs already assumes sprintf returns int.
6570 Similarly for float_to_string.
6571 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
6572 * ccl.c (ccl_driver):
6573 * character.c (string_escape_byte8):
6574 * data.c (Fnumber_to_string):
6575 * doprnt.c (doprnt):
6576 * print.c (print_object):
6577 * xdisp.c (message_dolog):
6578 * xfns.c (syms_of_xfns):
6579 Use sprintf or float_to_string result to avoid need to call strlen.
6580 * data.c (Fnumber_to_string):
6581 Use make_unibyte_string, since the string must be ASCII.
6582 * lisp.h, print.c (float_to_string): Now returns int length.
6583 * term.c (produce_glyphless_glyph):
6584 Use sprintf result rather than recomputing it.
6585
cf38a720
PE
6586 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
6587 * Makefile.in (ALL_CFLAGS):
6588 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
6589 * gmalloc.c, regex.c: Include <config.h> unconditionally.
6590
3511c784
DA
65912012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6592
0a08eb21 6593 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
6594 strcasecmp if available.
6595 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
6596
fb7da12e
AS
65972012-06-25 Andreas Schwab <schwab@linux-m68k.org>
6598
6599 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
6600 Avoid comma operator.
6601 * menu.c (push_submenu_start, push_submenu_end)
6602 (push_left_right_boundary, push_menu_pane): Likewise.
6603 * msdos.c (dos_rawgetc): Likewise.
6604
afa2ffd8
DA
66052012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6606
6607 * xfns.c (xic_create_fontsetname): Remove redundant calls
6608 to memset.
6609
b3b4476b
PE
66102012-06-25 Paul Eggert <eggert@cs.ucla.edu>
6611
4495ff38
PE
6612 * gtkutil.c (get_utf8_string): Remove redundant assignment.
6613 sprintf already null-terminates its output.
6614
b3b4476b
PE
6615 * xfns.c (x_window): Remove redundant cast.
6616
b00876c9
DA
66172012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6618
6619 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
6620 `const char *' to `char *' to avoid compiler warning.
6621
d188e26b
PE
66222012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6623
885d1d74
PE
6624 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
6625 instead of truncating it to 63 (admittedly a generous limit).
6626
d188e26b
PE
6627 * process.c: Fix spelling and caps in comments.
6628
e2f560b1
DN
66292012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
6630
e86db54b 6631 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
6632 * sysdep.c (setpgrp): Remove definition, not used in this file.
6633
7583a3a1
JB
66342012-06-24 Juanma Barranquero <lekktu@gmail.com>
6635
6636 * makefile.w32-in: Update dependencies.
6637
696056c2
EZ
66382012-06-24 Eli Zaretskii <eliz@gnu.org>
6639
6640 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
6641 (SYSTIME_H): Add nt/inc/sys/time.h.
6642
6643 * systime.h [WINDOWSNT]: Include sys/time.h.
6644
6645 * s/ms-w32.h (struct timespec): Definition moved from
6646 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
6647
845ca893
PE
66482012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6649
6650 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
6651 * buffer.h (buffer_slot_type_mismatch):
6652 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6653 * eval.c (unwind_to_catch):
6654 * image.c (my_png_error, my_error_exit):
6655 * keyboard.c (quit_throw_to_read_char, user_error)
6656 (Fexit_recursive_edit, Fabort_recursive_edit):
6657 * lisp.h (die, args_out_of_range, args_out_of_range_3)
6658 (wrong_type_argument, buffer_overflow, __executable_start)
6659 (memory_full, buffer_memory_full, string_overflow, Fthrow)
6660 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
6661 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
6662 (fatal):
6663 (child_setup) [!DOS_NT]:
6664 * lread.c (end_of_file_error, invalid_syntax):
6665 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6666 * puresize.h (pure_write_error):
6667 * search.c (matcher_overflow):
6668 * sound.c (sound_perror, alsa_sound_perror):
6669 * sysdep.c, syssignal.h (croak):
6670 * term.c (maybe_fatal, vfatal):
6671 * textprop.c (text_read_only):
6672 * undo.c (user_error):
6673 * unexmacosx.c (unexec_error):
6674 * xterm.c (x_ins_del_lines, x_delete_glyphs):
6675 Use _Noreturn rather than NO_RETURN.
6676 No need for separate decl merely because of _Noreturn.
6677 * sound.c (sound_warning, parse_sound):
6678 Remove unnecessary forward decls.
6679
f1dd8073
PE
66802012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6681
6682 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
6683 * lisp.h (WAIT_READING_MAX): New macro.
6684 * dispnew.c (Fsleep_for, sit_for):
6685 * keyboard.c (kbd_buffer_get_event):
6686 * process.c (Faccept_process_output):
6687 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
6688 This improves on the previous patch, which introduced a bug
6689 when time_t is unsigned and as wide as intmax_t.
6690 See <http://bugs.gnu.org/9000#51>.
6691
b82c1755
EZ
66922012-06-23 Eli Zaretskii <eliz@gnu.org>
6693
6694 * dispnew.c (sit_for, Fsleep_for):
6695 * keyboard.c (kbd_buffer_get_event):
6696 * process.c (Faccept_process_output): Avoid compiler warnings when
6697 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
6698
ca300656
JB
66992012-06-23 Juanma Barranquero <lekktu@gmail.com>
6700
049ec95b
JB
6701 * makefile.w32-in: Update dependencies.
6702
ca300656
JB
6703 * w32.c (ltime): Add return type and declare static.
6704 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
6705
db7b8d06
PE
67062012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6707
6708 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
6709 Privately reported by Herbert J. Skuhra.
6710 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
6711 All uses changed.
6712 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
6713 not make_lisp_timeval, when the argument is of type EMACS_TIME.
6714
0bd8297f
EZ
67152012-06-23 Eli Zaretskii <eliz@gnu.org>
6716
96512555
EZ
6717 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
6718 last argument of make_unibyte_string.
6719
0bd8297f
EZ
6720 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
6721 language ID in the event parameters.
6722
6723 * w32term.c (w32_read_socket): Put the new keyboard codepage into
6724 event.code, not the obscure "character set ID".
6725
63def6b6
CY
67262012-06-23 Chong Yidong <cyd@gnu.org>
6727
6728 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
6729
e8a02204
EZ
67302012-06-23 Eli Zaretskii <eliz@gnu.org>
6731
388cdec0
EZ
6732 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
6733 * w32.c (fdutimens): New function.
6734
6735 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
6736
6737 * s/ms-w32.h (pselect): Redirect to sys_select.
6738
6739 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
6740
e8a02204
EZ
6741 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
6742 in the logic of incrementing and decrementing the value of
6743 use_relocatable_buffers.
6744
d054f3fb
PE
67452012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6746
6747 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
6748 Privately reported by Herbert J. Skuhra.
6749 [__FreeBSD__]: Remove "*/" typo after "#include".
6750 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
6751 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
6752 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
6753 Don't assume EMACS_TIME and struct timeval are the same type.
6754
d35af63c
PE
67552012-06-22 Paul Eggert <eggert@cs.ucla.edu>
6756
6757 Support higher-resolution time stamps (Bug#9000).
6758 The time stamps are only nanosecond-resolution at the C level,
6759 since that's the best that any real-world system supports now.
6760 But they are picosecond-resolution at the Lisp level, as that's
6761 easy, and leaves room for future OS improvements.
6762
6763 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
6764 (LIBES): Use it.
6765
6766 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
6767 Don't get current time unless it's needed.
6768
6769 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
6770 now provides it if it's absent.
6771 (start_atimer): Port to higher-res time stamps.
6772 Check for time stamp overflow. Don't get current time more
6773 often than is needed.
6774
6775 * buffer.h (struct buffer): Buffer modtime now has high resolution.
6776 Include systime.h, not time.h.
6777 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
6778
6779 * dired.c: Include stat-time.h.
6780 (Ffile-attributes): File times now have higher resolution.
6781
6782 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
6783 (struct image): Timestamp now has higher resolution.
6784
6785 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
6786 has at least microseconds now. All uses removed.
6787 (update_frame, update_single_window, update_window, update_frame_1)
6788 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 6789 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
6790
6791 * editfns.c (time_overflow): Now extern.
6792 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
6793 (float-time, Fformat_time_string, Fcurrent_time_string)
6794 (Fcurrent_time_zone): Accept and generate higher-resolution
6795 time stamps.
6796 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
6797 (decode_time_components, lisp_seconds_argument): New functions.
6798 (make_time): Now static.
6799 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
6800 Report an error if the time is invalid, rather than having the caller
6801 do that.
6802
6803 * fileio.c: Include <stat-time.h>
6804 (Fcopy_file): Copy higher-resolution time stamps.
6805 Prefer to set the time stamp via a file descriptor if that works.
6806 (Fset_file_times, Finsert_file_contents, Fwrite_region)
6807 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
6808 (Fvisited_file_modtime, Fset_visited_file_modtime):
6809 Support higher-resolution time stamps.
6810
6811 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
6812
6813 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
6814
6815 * image.c (prepare_image_for_display, clear_image_cache)
6816 (lookup_image): Port to higer-resolution time stamps.
6817
6818 * keyboard.c (start_polling, bind_polling_period):
6819 Check for time stamp overflow.
6820 (read_char, kbd_buffer_get_event, timer_start_idle)
6821 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
6822 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
6823 Port to higher-resolution time stamps. Do not assume time_t is signed.
6824 (decode_timer): New function. Timers are now vectors of length 9,
6825 not 8, to accommodate the picosecond component.
6826 (timer_check_2): Use it.
6827
6828 * nsterm.m (select_timeout, timeval_subtract): Remove.
6829 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
6830 as they're a bit more accurate and handle overflow better.
6831 (ns_select): Change prototype to be compatible with pselect.
6832 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
6833 * nsterm.h (ns_select): Adjust prototype.
6834
6835 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
6836 us-resolution time stamps.
6837 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
6838
6839 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
6840
6841 * lisp.h (time_overflow): New decl.
6842 (wait_reading_process_output): First arg is now intmax_t, not int,
6843 to accommodate larger waits.
6844
6845 * process.h (struct Lisp_Process.read_output_delay):
6846 Now counts nanoseconds, not microseconds.
6847 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
6848 EMACS_HAS_USECS.
6849 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
6850 (wait_reading_process_output):
6851 Port to ns-resolution time stamps.
6852 (Faccept_process_output, wait_reading_process_output):
6853 Check for time stamp overflow. Do not assume time_t is signed.
6854 (select_wrapper): Remove; we now use pselect.
6855 (Fprocess_attributes): Now generates ns-resolution time stamps.
6856
6857 * sysdep.c: Include utimens.h. Don't include utime.h
6858 or worry about struct utimbuf; gnulib does that for us now.
6859 (gettimeofday): Remove; gnulib provides a substitute.
6860 (make_timeval): New function.
6861 (set_file_times): Now sets ns-resolution time stamps.
6862 New arg FD; all uses changed.
6863 (time_from_jiffies, ltime_from_jiffies, get_up_time)
6864 (system_process_attributes):
6865 Now returns ns-resolution time stamp. All uses changed.
6866 Check for time stamp overflow.
6867
6868 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
6869 provides a substitute now.
6870
6871 * systime.h: Include timespec.h rather than sys/time.h and time.h,
6872 since it guarantees struct timespec.
6873 (EMACS_TIME): Now struct timespec, so that we can support
6874 ns-resolution time stamps.
6875 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
6876 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
6877 (EMACS_USECS): Remove.
6878 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
6879 so multiply the arg by 1000 before storing it.
6880 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
6881 New macros.
6882 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
6883 Port to ns-resolution time stamps.
6884 (EMACS_TIME_NEG_P): Remove; replaced by....
6885 (EMACS_TIME_SIGN): New macro.
6886 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
6887 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
6888 (set_file_times, make_time, lisp_time_argument): Adjust signature.
6889 (make_timeval, make_lisp_time, decode_time_components): New decls.
6890 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
6891 that it mishandled time_t overflow. You can't compare by subtracting!
6892 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
6893 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
6894
6895 * term.c: Include <sys/time.h>.
6896 (timeval_to_Time): New function, for proper overflow wraparound.
6897 (term_mouse_position, term_mouse_click): Use it.
6898
6899 * undo.c (record_first_change): Support higher-resolution time stamps
6900 in the undo buffer.
6901 (Fprimitive_undo): Use them when restoring time stamps.
6902
6903 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
6904 (w32_get_internal_run_time):
6905 Port to higher-resolution Emacs time stamps.
6906 (ltime): Now accepts single 64-bit integer, as that's more convenient
6907 for callers.
6908
6909 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
6910
6911 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
6912 for compatibility with pselect. Support ns-resolution time stamps.
6913
6914 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
6915
6916 * xselect.c (wait_for_property_change, x_get_foreign_selection):
6917 Check for time stamp overflow, and support ns-resolution time stamps.
6918
6919 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
6920 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
6921 (timeval_subtract): Remove; no longer needed.
6922 (XTflash, XTring_bell, x_wait_for_event):
6923 Port to ns-resolution time stamps. Don't assume time_t is signed.
6924
b6a92dfe
CY
69252012-06-22 Chong Yidong <cyd@gnu.org>
6926
6927 * xdisp.c (x_consider_frame_title): Revert last change.
6928
d251c37c
EZ
69292012-06-22 Eli Zaretskii <eliz@gnu.org>
6930
6931 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
6932 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
6933 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
6934 staticidx goes up to 1597 out of 1600 = 0x640.)
6935
f10deafb
PE
69362012-06-20 Paul Eggert <eggert@cs.ucla.edu>
6937
6938 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
6939 Otherwise, the umask might be mistakenly 0 while handling input signals.
6940
ec6de1e2
SM
69412012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
6942
6943 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
6944
28be1ada
DA
69452012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6946
6947 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
6948 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
6949 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6950 access to `contents' member of Lisp_Vector objects with AREF and ASET
6951 where appropriate.
6952
c6bf3022
CY
69532012-06-19 Chong Yidong <cyd@gnu.org>
6954
6955 * frame.c (delete_frame): When selecting a frame on a different
6956 text terminal, do not alter the terminal's top-frame.
6957
6958 * xdisp.c (format_mode_line_unwind_data): Record the target
6959 frame's selected window and its terminal's top-frame.
6960 (unwind_format_mode_line): Restore them.
6961 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6962 Callers changed.
6963 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6964 since tty frames can be explicitly named.
6965 (prepare_menu_bars): Likewise.
6966
6967 * term.c (Ftty_top_frame): New function.
6968
defd4196
PE
69692012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6970
6971 Port byte-code-meter to modern targets.
6972 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6973 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6974 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6975 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6976 (METER_1, METER_2): Simplify.
6977
1053a871
SM
69782012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6979
6980 * data.c (Fdefalias): Return `symbol' (bug#11686).
6981
b7e8d081
MR
69822012-06-18 Martin Rudalics <rudalics@gmx.at>
6983
6984 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6985 gets killed during executing of this function (Bug#11665).
6986 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6987 (Vkill_buffer_query_functions): In doc-string say that functions
6988 run by this hook should not change the current buffer.
6989
7ea2b339
PE
69902012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6991
6992 Fix recently-introduced process.c problems found by static checking.
6993 * process.c (write_queue_push, write_queue_pop, send_process):
6994 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6995 (write_queue_pop): Fix pointer signedness problem.
6996 (send_process): Remove unused local.
6997
96a313a1
CY
69982012-06-17 Chong Yidong <cyd@gnu.org>
6999
7000 * xdisp.c (redisplay_internal): No need to redisplay terminal
7001 frames that are not on top.
7002
20ca2e94
TN
70032012-06-17 Troels Nielsen <bn.troels@gmail.com>
7004
7005 * process.c (make_process): Initialize write_queue.
7006 (write_queue_push, write_queue_pop): New functions.
7007 (send_process): Use them to maintain correct ordering of process
7008 writes (Bug#10815).
7009
9a900ca9
PE
70102012-06-17 Paul Eggert <eggert@cs.ucla.edu>
7011
310fbfa8
PE
7012 * lisp.h (eassert): Assume C89 or later.
7013 This removes the need for CHECK.
7014 (CHECK): Remove. Its comments about always evaluating its
7015 argument were confusing, as 'eassert' typically does not evaluate
7016 its argument.
7017
27bb1ca4
PE
7018 * coding.c (produce_chars): Use ptrdiff_t, not int.
7019
9a900ca9
PE
7020 * xterm.c (x_draw_underwave): Check for integer overflow.
7021 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
7022
41b7f8bc 70232012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
7024
7025 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
7026 referenced (Bug#11583).
7027
9b0e3eba
AA
70282012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
7029
7030 Implement wave-style variant of underlining.
7031 * dispextern.h (face_underline_type): New enum.
7032 (face): Add field for underline type.
7033 * nsterm.m (ns_draw_underwave): New function.
7034 (ns_draw_text_decoration): Use it.
7035 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
7036 New functions.
7037 (x_draw_glyph_string): Use them.
7038 * xfaces.c (Qline, Qwave): New Lisp objects.
7039 (check_lface_attrs, merge_face_ref)
1053a871
SM
7040 (Finternal_set_lisp_face_attribute, realize_x_face):
7041 Handle wave-style underline face attributes.
9b0e3eba
AA
7042 * xterm.c (x_draw_underwave): New function.
7043 (x_draw_glyph_string): Use it.
7044
0fb52f11
JB
70452012-06-16 Juanma Barranquero <lekktu@gmail.com>
7046
7047 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
7048 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
7049 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
7050 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
7051 ($(BLD)/w32select.$(O)): Update dependencies.
7052
e5560ff7
AS
70532012-06-16 Andreas Schwab <schwab@linux-m68k.org>
7054
7055 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
7056 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
7057 * character.c (_fetch_multibyte_char_p): Remove.
7058 * alloc.c: Include "character.h" before "buffer.h".
7059 * bidi.c: Likewise.
7060 * buffer.c: Likewise.
7061 * bytecode.c: Likewise.
7062 * callint.c: Likewise.
7063 * callproc.c: Likewise.
7064 * casefiddle.c: Likewise.
7065 * casetab.c: Likewise.
7066 * category.c: Likewise.
7067 * cmds.c: Likewise.
7068 * coding.c: Likewise.
7069 * composite.c: Likewise.
7070 * dired.c: Likewise.
7071 * dispnew.c: Likewise.
7072 * doc.c: Likewise.
7073 * dosfns.c: Likewise.
7074 * editfns.c: Likewise.
7075 * emacs.c: Likewise.
7076 * fileio.c: Likewise.
7077 * filelock.c: Likewise.
7078 * font.c: Likewise.
7079 * fontset.c: Likewise.
7080 * fringe.c: Likewise.
7081 * indent.c: Likewise.
7082 * insdel.c: Likewise.
7083 * intervals.c: Likewise.
7084 * keyboard.c: Likewise.
7085 * keymap.c: Likewise.
7086 * lread.c: Likewise.
7087 * macros.c: Likewise.
7088 * marker.c: Likewise.
7089 * minibuf.c: Likewise.
7090 * nsfns.m: Likewise.
7091 * nsmenu.m: Likewise.
7092 * print.c: Likewise.
7093 * process.c: Likewise.
7094 * regex.c: Likewise.
7095 * region-cache.c: Likewise.
7096 * search.c: Likewise.
7097 * syntax.c: Likewise.
7098 * term.c: Likewise.
7099 * textprop.c: Likewise.
7100 * undo.c: Likewise.
7101 * unexsol.c: Likewise.
7102 * w16select.c: Likewise.
7103 * w32fns.c: Likewise.
7104 * w32menu.c: Likewise.
7105 * window.c: Likewise.
7106 * xdisp.c: Likewise.
7107 * xfns.c: Likewise.
7108 * xmenu.c: Likewise.
7109 * xml.c: Likewise.
7110 * xselect.c: Likewise.
7111
2f07e6af
EZ
71122012-06-16 Eli Zaretskii <eliz@gnu.org>
7113
1053a871
SM
7114 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
7115 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 7116 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
7117 row.
7118 (handle_face_prop): Use chunk-relative overlay string index when
7119 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
7120 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
7121 the rightmost. (Bug#11720)
2f07e6af 7122
29b83cec
AS
71232012-06-16 Andreas Schwab <schwab@linux-m68k.org>
7124
7125 * category.h (CHAR_HAS_CATEGORY): Define as inline.
7126 (CATEGORY_MEMBER): Enforce 1/0 value.
7127 * category.c (_temp_category_set): Remove.
7128
4c5501e9
EZ
71292012-06-16 Eli Zaretskii <eliz@gnu.org>
7130
7131 * window.c (Fdelete_other_windows_internal)
7132 (Fdelete_window_internal): Don't access frame's mouse highlight
7133 info of the initial frame. (Bug#11677)
7134
2b570124
PE
71352012-06-14 Paul Eggert <eggert@cs.ucla.edu>
7136
e93864f9
PE
7137 * .gdbinit (xgetint): Fix recently-introduced paren typo.
7138 Assume USE_2_TAGS_FOR_INTS.
7139 (xreload): Adjust $tagmask width to match recent lisp.h change.
7140
2b570124
PE
7141 Simplify lisp.h in minor ways that should not affect code.
7142 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
7143 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
7144 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
7145 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
7146 (INTTYPEBITS): New macro, for clarity.
7147 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
7148 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
7149 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
7150 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
7151 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
7152
81755f69
JB
71532012-06-13 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
7156
16192a57
GM
71572012-06-13 Glenn Morris <rgm@gnu.org>
7158
7159 * s/bsd-common.h (BSD4_3):
7160 * s/usg5-4-common.h (USG5_4): No longer define; unused.
7161
646b5f55
AS
71622012-06-13 Andreas Schwab <schwab@linux-m68k.org>
7163
7164 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
7165 instead of union.
7166 (XLI, XIL): Define.
1053a871
SM
7167 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
7168 Use them.
7169 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 7170 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 7171 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
7172 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
7173 * frame.c (delete_frame): Remove outdated comment.
7174 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
7175 USE_LISP_UNION_TYPE.
7176 (Fw32_unregister_hot_key): Likewise.
7177 (Fw32_toggle_lock_key): Likewise.
7178 * w32menu.c (add_menu_item): Likewise.
7179 (w32_menu_display_help): Use XIL instead of checking
7180 USE_LISP_UNION_TYPE.
7181 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
7182 (init_heap): Likewise.
7183 * w32term.c (w32_read_socket): Update comment.
7184
1d3823c9
GM
71852012-06-13 Glenn Morris <rgm@gnu.org>
7186
c62ff706
GM
7187 * s/usg5-4-common.h, src/s/unixware.h:
7188 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
7189
1d3823c9
GM
7190 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
7191
bfe3e0a2
PE
71922012-06-13 Paul Eggert <eggert@cs.ucla.edu>
7193
7194 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
7195 * alloc.c (make_number) [!defined make_number]:
7196 Remove, as lisp.h always defines this now.
7197 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
7198 (roundup_size): Verify that it is a power of 2.
7199 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
7200 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
7201 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
7202 -DUSE_LSB_TAG=0, to override the automatically-selected default.
7203 USE_LSB_TAG now is always defined to be either 0 or 1.
7204 All uses changed.
7205 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
7206 code works fine either way, and efficiency is not a concern here,
7207 as the union type is for debugging, not for production.
7208 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
7209 Use an inline function on all platforms when using the union type,
7210 since this is simpler and 'static inline' can be used portably
7211 within Emacs now.
7212 (LISP_INITIALLY_ZERO): New macro.
7213 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
7214 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
7215
45fa9c0f
GM
72162012-06-12 Glenn Morris <rgm@gnu.org>
7217
b4492cba
GM
7218 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
7219
7220 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 7221
45fa9c0f
GM
7222 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
7223 Move BROKEN_SIGIO to configure.
7224
7225 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
7226 Move NO_TERMIO to configure.
7227
0e25d334
CY
72282012-06-12 Chong Yidong <cyd@gnu.org>
7229
7230 * image.c (imagemagick_load_image): Use MagickFlattenImage if
7231 MagickMergeImageLayers is undefined. Use pixel pusher loop if
7232 MagickExportImagePixels is undefined.
7233
43682bb6
PE
72342012-06-12 Paul Eggert <eggert@cs.ucla.edu>
7235
7236 * image.c (imagemagick_load_image): Remove unused label.
7237
a9be7d2b
GM
72382012-06-11 Glenn Morris <rgm@gnu.org>
7239
7240 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
7241 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
7242 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
7243 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
7244
3017f87f
SM
72452012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
7246
7247 * alloc.c (make_byte_code): New function.
7248 (Fmake_byte_code): Use it. Don't purify here.
7249 * lread.c (read1): Use it as well to avoid extra allocation.
7250
1b9b4cf4
CY
72512012-06-11 Chong Yidong <cyd@gnu.org>
7252
7253 * image.c (imagemagick_load_image): Implement transparency.
7254
95988fcf
AS
72552012-06-10 Andreas Schwab <schwab@linux-m68k.org>
7256
7257 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
7258 account for preceding backslashes. (Bug#11663)
7259
cd4eb164
CY
72602012-06-09 Chong Yidong <cyd@gnu.org>
7261
7262 * term.c: Support italics in capable terminals (Bug#9652).
7263 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
7264 (turn_on_face): Output using TS_enter_italic_mode if available.
7265 Don't handle unused blinking and alt-charset cases.
7266 (turn_off_face): Handle italic case; discard unused tty_blinking_p
7267 and tty_alt_charset_p cases.
7268 (tty_capable_p, init_tty): Support italics.
7269
7270 * termchar.h (struct tty_display_info): Add field for italics.
7271 Remove unused blink field.
7272
7273 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
7274 Handle slant.
7275
7276 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
7277 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
7278 tty_alt_charset_p. Add tty_italic_p.
7279
ff88beb8
MA
72802012-06-09 Michael Albinus <michael.albinus@gmx.de>
7281
7282 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
7283 dbus_type_is_basic if available.
7284 (xd_extract_signed, xd_extract_unsigned): Rename from
7285 extract_signed and extract_unsigned, respectively. Adapt callers.
7286
44286096
CY
72872012-06-09 Chong Yidong <cyd@gnu.org>
7288
1682701f
CY
7289 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
7290
44286096
CY
7291 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
7292 case (Bug#9752).
7293
d86feb17
PE
72942012-06-08 Paul Eggert <eggert@cs.ucla.edu>
7295
7296 * xdisp.c (vmessage): Treat frame message as multibyte.
7297 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
7298 would generate the diagnostic "Making \302\247 buffer-local while
7299 let-bound!".
7300
d5c20fe8
EZ
73012012-06-08 Eli Zaretskii <eliz@gnu.org>
7302
7303 * dispnew.c (showing_window_margins_p): Undo last change, which
7304 was done due to an inadvertent commit.
7305 (adjust_frame_glyphs_for_frame_redisplay): Do call
7306 showing_window_margins_p.
7307
513749ee
SM
73082012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
7309
7310 * eval.c (Fmake_var_non_special): New primitive.
7311 (syms_of_eval): Defsubr it.
7312 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
7313
d4a8f5c1
JB
73142012-06-08 Juanma Barranquero <lekktu@gmail.com>
7315
7316 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
7317 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
7318
8bbbc977
EZ
73192012-06-08 Eli Zaretskii <eliz@gnu.org>
7320
7321 * alloc.c (allocate_vectorlike): Fix last change.
7322
f3372c87
DA
73232012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
7324
7325 Block-based vector allocation of small vectors.
7326 * lisp.h (struct vectorlike_header): New field `nbytes',
7327 adjust comment accordingly.
7328 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 7329 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
7330 mark_maybe_pointer, valid_lisp_object_p) accordingly.
7331 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
7332 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
7333 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
7334 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
7335 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
7336 (roundup_size): New constant.
7337 (struct vector_block): New data type.
7338 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 7339 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
7340 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
7341 (sweep_vectors): New functions.
7342 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 7343 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
7344 or equal to VBLOCK_BYTES_MAX.
7345 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
7346 (init_alloc_once): Add call to init_vectors.
7347
4f18a4ed
SM
73482012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
7349
7350 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
7351
86f158bc
PE
73522012-06-07 Paul Eggert <eggert@cs.ucla.edu>
7353
7354 * doprnt.c (doprnt): Truncate multibyte char correctly.
7355 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
7356 would mishandle a string argument "Xc" if X was a multibyte
7357 character of length 2: it would truncate after X's first byte
7358 rather than including all of X.
7359
c5cfcbe0
CY
73602012-06-06 Chong Yidong <cyd@gnu.org>
7361
7362 * buffer.c (word_wrap): Doc fix.
7363
c05cf390
PE
73642012-06-04 Paul Eggert <eggert@cs.ucla.edu>
7365
7366 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
7367
0c3461de
GM
73682012-06-03 Glenn Morris <rgm@gnu.org>
7369
7370 * xdisp.c (tool-bar-style): Doc fix.
7371
c71232db
UM
73722012-06-03 Ulrich Müller <ulm@gentoo.org>
7373
7374 * Makefile.in (PAXCTL): Define.
7375 (temacs$(EXEEXT)): Disable memory randomization for the temacs
7376 binary via PaX flags if the paxctl utility is available.
7377 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
7378 Restore PaX flags to their default. (Bug#11398)
7379
383f7350
CY
73802012-06-03 Chong Yidong <cyd@gnu.org>
7381
7382 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
7383 buffer (Bug#11226).
7384
5f2c76c6
CY
73852012-06-03 Chong Yidong <cyd@gnu.org>
7386
7387 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
7388 (note_mode_line_or_margin_highlight): If there is no help echo,
7389 use mode-line-default-help-echo. Handle the case where the mouse
7390 position is past the end of the mode line string.
7391
7392 * buffer.c (buffer_local_value_1): New function, split from
7393 Fbuffer_local_value; can return Qunbound.
7394 (Fbuffer_local_value): Use it.
7395 (Vmode_line_format): Docstring tweaks.
7396
773d47f6
PE
73972012-06-02 Paul Eggert <eggert@cs.ucla.edu>
7398
7399 * sysdep.c (system_process_attributes): Improve comment.
7400
f2d6a3df
SM
74012012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
7402
7403 * keyboard.c: Export real-this-command to Elisp.
7404 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
7405 and DEFVAR it. Update all users.
7406
63810350
PE
74072012-06-02 Paul Eggert <eggert@cs.ucla.edu>
7408
7bd5c1f4
PE
7409 * minibuf.c (Fassoc_string): Remove duplicate declaration.
7410
63810350
PE
7411 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
7412 Convert pctcpu and pctmem to Lisp float properly.
7413 Let the compiler fold better, as 100.0/0x8000 is exact.
7414
a2821611
AS
74152012-06-02 Andreas Schwab <schwab@linux-m68k.org>
7416
7417 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
7418 cons_block.
7419
5fceba1d
PE
74202012-06-01 Paul Eggert <eggert@cs.ucla.edu>
7421
7422 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
7423
c98ff5dd
DA
74242012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
7425
7426 For a 'struct window', replace some Lisp_Object fields to
7427 bitfields where appropriate, remove unused fields.
7428 * window.h (struct window): Remove unused 'last_mark_x' and
7429 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
7430 change it's type from Lisp_Object to bitfield.
7431 Change type of 'force_start', 'optional_new_start',
7432 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 7433 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 7434
ca34e0be
PE
74352012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7436
7437 Pacify gcc -Wdouble-precision when using Xaw.
7438 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
7439 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
7440 Use 'float' consistently, rather than 'float' in most places
7441 and 'double' in a couple of places.
7442
efc00ab1 74432012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
7444
7445 * xdisp.c (handle_stop): Detect whether we have overlay strings
7446 loaded by testing it->current.overlay_string_index to be
7447 non-negative, instead of checking whether n_overlay_strings is
7448 positive. (Bug#11587)
7449
efc00ab1 74502012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
7451
7452 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
7453
7454 * doc.c (Fsubstitute_command_keys): Doc fix.
7455
efc00ab1 74562012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
7457
7458 * search.c (search_buffer): Remove calls to
7459 r_alloc_inhibit_buffer_relocation, as it is now called by
7460 maybe_unify_char, which was the cause of relocation of buffer text
7461 in bug#11519.
7462
efc00ab1 74632012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
7464
7465 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
7466 for the duration of call to load_charset, to avoid problems with
7467 callers of maybe_unify_char that access buffer text through C
7468 pointers.
7469
7470 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
7471 decrement the inhibition flag, instead of just setting or
7472 resetting it.
7473
ba93a187
PE
74742012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7475
7476 Remove obsolete '#define static' cruft.
7477 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
7478 This #undef was "temporary" in 2000; it is no longer needed
7479 now that '#define static' has gone away.
7480 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
7481 (gray_bitmap_bits): Remove; no longer needed.
7482 All uses replaced with definiens.
7483 * xterm.c: Include "bitmaps/gray.xbm".
7484
9e4bf381
PE
74852012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7486
7487 Clean up __executable_start, monstartup when --enable-profiling.
7488 The following changes affect the code only when profiling.
7489 * dispnew.c (__executable_start): Rename from safe_bcopy.
7490 Define only on platforms that need it.
7491 * emacs.c: Include <sys/gmon.h> when profiling.
7492 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
7493 (__executable_start): Remove decl, since lisp.h does it now.
7494 (safe_bcopy): Remove decl; no longer has that name.
7495 (main): Coalesce #if into single bit of code, for simplicity.
7496 Cast pointers to uintptr_t, since standard libraries want integers
7497 and not pointers.
7498 * lisp.h (__executable_start): New decl.
7499
32d72c2f
GM
75002012-05-31 Glenn Morris <rgm@gnu.org>
7501
7502 * image.c (Fimagemagick_types): Doc fix.
7503
baac5bc7
JM
75042012-05-30 Jim Meyering <meyering@redhat.com>
7505
7506 * callproc.c (Fcall_process_region): Include directory component
7507 in mkstemp error message (Bug#11586).
7508
72cb32cf
PE
75092012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7510
7511 * alloc.c, lisp.h (make_pure_vector): Now static.
7512
61b108cc
SM
75132012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
7514
7515 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
7516 Move to byte-run.el.
7517 (Fautoload): Do the hash-doc more carefully.
7518 * data.c (Fdefalias): Purify definition, except for keymaps.
7519 (Qdefun): Move from eval.c.
7520 * lisp.h (Qdefun): Remove.
7521 * lread.c (read1): Tiny simplification.
7522
471fe23d
TN
75232012-05-29 Troels Nielsen <bn.troels@gmail.com>
7524
934f3f58 7525 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
7526 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
7527 Bug#9642, but explicitly check that the buffer the overlay would
7528 be moved to is live and rearrange lines to make sure that errors
7529 will not put the overlay in an inconsistent state.
7530 (Fdelete_overlay): Cosmetics.
7531
85d0efd1
EZ
75322012-05-28 Eli Zaretskii <eliz@gnu.org>
7533
7534 * w32term.c (my_bring_window_to_top): New function.
7535 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
7536 could be different from the original one.
7537 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
7538 (Bug#11513)
7539
7540 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
7541 by calling BringWindowToTop.
7542
7543 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
7544 (WM_EMACS_END): Increase by one.
7545
da92a98c
PE
75462012-05-28 Paul Eggert <eggert@cs.ucla.edu>
7547
7548 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
7549 This avoids undefined behavior that might cause the eassert
7550 to not catch an out-of-range value.
7551
74d1f848
JB
75522012-05-28 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
7555 Update dependencies.
7556
9e1a06fc
EZ
75572012-05-27 Eli Zaretskii <eliz@gnu.org>
7558
7559 * bidi.c (bidi_mirror_char): Fix last change.
7560
f3dd7312
AS
75612012-05-27 Andreas Schwab <schwab@linux-m68k.org>
7562
7563 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
7564 when referring to sectname field in printf format.
7565
81899c91
PE
75662012-05-27 Paul Eggert <eggert@cs.ucla.edu>
7567
57b81a9f
PE
7568 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
7569 Only r_alloc_inhibit_buffer_relocation needed to be added;
7570 the others were already declared.
7571
81899c91
PE
7572 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
7573 before checking whether it's out of range. Put the check inside
7574 eassert. See
7575 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
7576
33017faf 75772012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
7578
7579 * callproc.c (Fcall_process): Restore a line that was accidentally
7580 commented out in the 2011-02-13 change (bug#11547).
7581
33017faf 75822012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
7583
7584 * lisp.h [REL_ALLOC]: Add prototypes for external functions
7585 defined on ralloc.c.
7586
7587 * buffer.c [REL_ALLOC]: Remove prototypes of
7588 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
7589 they are now on lisp.h.
7590
7591 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
7592
7593 * search.c (search_buffer): Use it to inhibit relocation of buffer
7594 text while re_search_2 is doing its job, because re_search_2 is
7595 passed C pointers to buffer text. (Bug#11519)
7596
23415acf
EZ
7597 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
7598 Update value to 24.
7599
44e27368
EZ
7600 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
7601 state after an additional call to move_it_in_display_line_to, keep
7602 the values of it->max_ascent and it->max_descent found for the
7603 entire line.
7604 (pos_visible_p): Revert the comparison against bottom_y to what it
7605 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
7606 (Bug#11464)
7607
c1892f11
PE
76082012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7609
7610 Fix coding-related core dumps with gcc -ftrapv.
7611 The code was computing A - B, where A and B are pointers, and B is
7612 random garbage. This can lead to core dumps on platforms that
7613 have special pointer registers, and it also leads to core dumps on
7614 x86-64 when compiled with gcc -ftrapv. The fix is to compute
7615 A - B only when B is initialized properly.
7616 * coding.c (coding_set_source, coding_set_destination): Return void.
7617 (coding_change_source, coding_change_destinations): New functions,
7618 with the old behaviors of coding_set_source and coding_set_destination.
7619 All callers that need an offset changed to use these new functions.
7620
eb7afdad
GM
76212012-05-26 Glenn Morris <rgm@gnu.org>
7622
7623 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
7624
f12fdf02
EZ
76252012-05-26 Eli Zaretskii <eliz@gnu.org>
7626
53a63be6 7627 Extend mouse support on W32 text-mode console.
61b108cc
SM
7628 * xdisp.c (draw_row_with_mouse_face):
7629 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 7630
eb3f6f01 7631 * w32console.c: Include window.h.
61b108cc
SM
7632 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
7633 New functions.
eb3f6f01
EZ
7634 (initialize_w32_display): Initialize mouse-highlight data.
7635
53a63be6
EZ
7636 * w32inevt.c: Include termchar.h and window.h.
7637 (do_mouse_event): Support mouse-autoselect-window. When the mouse
7638 moves, call note_mouse_highlight. If help_echo changed, call
7639 gen_help_event to produce help-echo message in the echo area.
7640 Call clear_mouse_face if mouse_face_hidden is set in the mouse
7641 highlight info.
7642
4cfd81f6
PE
76432012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7644
7645 * lread.c (read1): Simplify slightly to avoid an overflow warning
7646 with GCC 4.7.0 on x86-64.
7647
4446092a
EZ
76482012-05-26 Eli Zaretskii <eliz@gnu.org>
7649
7650 * bidi.c (bidi_mirror_char): Revert last change: an int is
7651 definitely wide enough here.
7652
42b2a986 76532012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 7654
42b2a986 7655 Fix integer width and related bugs (Bug#9874).
eb106a49 7656 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
7657 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
7658 (string_bytes, check_sblock, allocate_string_data):
7659 (compact_small_strings, Fmake_bool_vector, make_string)
7660 (make_unibyte_string, make_multibyte_string)
7661 (make_string_from_bytes, make_specified_string)
7662 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
7663 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
7664 (mark_vectorlike):
7665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7666 (allocate_pseudovector):
7667 Use int, not EMACS_INT, where int is wide enough.
7668 (inhibit_garbage_collection, Fgarbage_collect):
7669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7670 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
7671 int might not be wide enough.
7672 (bidi_cache_search, bidi_cache_find, bidi_init_it)
7673 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
7674 (bidi_at_paragraph_end, bidi_find_paragraph_start)
7675 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7676 (bidi_level_of_next_char, bidi_move_to_visually_next):
7677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7678 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
7679 (Fkill_buffer, Fset_buffer_major_mode)
7680 (advance_to_char_boundary, Fbuffer_swap_text)
7681 (Fset_buffer_multibyte, overlays_at, overlays_in)
7682 (overlay_touches_p, struct sortvec, record_overlay_string)
7683 (overlay_strings, recenter_overlay_lists)
7684 (adjust_overlays_for_insert, adjust_overlays_for_delete)
7685 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
7686 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
7687 (Foverlay_recenter, last_overlay_modification_hooks_used)
7688 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
7689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
7690 (validate_region): Omit unnecessary test for b <= e,
7691 since that's guaranteed by the previous test.
d311d28c
PE
7692 (adjust_overlays_for_delete): Avoid pos + length overflow.
7693 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
7694 (report_overlay_modification):
7695 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7696 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
7697 Omit pointer cast, which isn't needed anyway, and doesn't work
7698 after the EMACS_INT -> ptrdiff_t change.
02481186 7699 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
7700 * buffer.h: Adjust decls to match defn changes elsewhere.
7701 (struct buffer_text, struct buffer):
7702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7703 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
7704 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
7705 not int, to avoid needless 32-bit limit on 64-bit hosts.
7706 (exec_byte_code): Use tighter memory-full test, one that checks
7707 for alloca overflow. Don't compute the address of the object just
7708 before an array, as that's not portable. Use EMACS_INT, not
7709 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
7710 * callint.c (Fcall_interactively):
7711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7712 * callproc.c (call_process_kill, Fcall_process):
7713 Don't assume pid_t fits into an Emacs fixnum.
7714 (call_process_cleanup, Fcall_process, child_setup):
7715 Don't assume pid_t fits into int.
7716 (call_process_cleanup, Fcall_process, delete_temp_file)
7717 (Fcall_process_region):
7718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7719 (Fcall_process): Simplify handling of volatile integers.
7720 Use int, not EMACS_INT, where int will do.
7721 * casefiddle.c (casify_object, casify_region, operate_on_word)
7722 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
7723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7724 (casify_object): Avoid integer overflow when overallocating buffer.
7725 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 7726 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
7727 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
7728 * category.h (CATEGORYP): Don't assume arg is nonnegative.
7729 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
7730 integers are now checked earlier. All uses replaced with XINT.
7731 (ccl_driver):
7732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7733 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
7734 (ccl_driver, Fregister_code_conversion_map):
7735 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
7736 (resolve_symbol_ccl_program): Check that vector header is in range.
7737 Always copy the vector, so that we can check its contents reliably
7738 now rather than having to recheck each instruction as it's being
7739 executed. Check that vector words fit in 'int'.
7740 (ccl_get_compiled_code, Fregister_ccl_program)
7741 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
7742 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
7743 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
7744 contents are in range.
7745 (Fccl_execute_on_string): Check that status is in range.
7746 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
7747 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
7748 Accept and return EMACS_INT, not int, because callers can pass values
7749 out of 'int' range.
7750 (c_string_width, strwidth, lisp_string_width, chars_in_text)
7751 (multibyte_chars_in_text, parse_str_as_multibyte)
7752 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
7753 (str_as_unibyte, str_to_unibyte, string_count_byte8)
7754 (string_escape_byte8, Fget_byte):
7755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 7756 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
7757 avoid mishandling large integers.
7758 * character.h: Adjust decls to match defn changes elsewhere.
7759 * charset.c (load_charset_map_from_file, find_charsets_in_text)
7760 (Ffind_charset_region):
7761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7762 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
7763 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 7764 Don't assume fixnum fits in int.
d311d28c
PE
7765 (load_charset_map_from_vector, Fmap_charset_chars):
7766 Remove now-unnecessary CHECK_NATNUMs.
7767 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
7768 Don't rely on undefined behavior with signed left shift overflow.
7769 Don't assume unsigned int fits into fixnum, or that fixnum fits
7770 into unsigned int. Don't require max_code to be a valid fixnum;
7771 that's not true for gb10830 4-byte on a 32-bit host. Allow
7772 invalid_code to be a cons, for the same reason. Require code_offset
7773 to be a character. Avoid int overflow if max_char is close
7774 to INT_MAX.
7775 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
7776 this is intended anyway and avoids some undefined behavior.
7777 (load_charset_map): Pass unsigned, not int, as 2nd arg of
7778 INDEX_TO_CODE_POINT, as that's what it expects.
7779 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
7780 * charset.h (DECODE_CHAR): Return int, not unsigned;
7781 this is what was intended anyway, and it avoids undefined behavior.
7782 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
7783 integer-overflow issues.
7784 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
7785 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
7786 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
7787 * chartab.c (Fmake_char_table, Fset_char_table_range)
7788 (uniprop_get_decoder, uniprop_get_encoder):
7789 Don't assume fixnum fits in int.
7790 * cmds.c (move_point): New function, that does the gist of
7791 Fforward_char and Fbackward_char, but does so while checking
7792 for integer overflow more accurately.
c96e5d6a 7793 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
7794 (Fforward_line, Fend_of_line, internal_self_insert)
7795 (internal_self_insert):
7796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7797 Fix a FIXME, by checking for integer overflow when calculating
7798 target_clm and actual_clm.
7799 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 7800 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
7801 (ASSURE_DESTINATION, coding_alloc_by_realloc)
7802 (coding_alloc_by_making_gap, alloc_destination)
7803 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
7804 (encode_coding_utf_16, detect_coding_emacs_mule)
7805 (decode_coding_emacs_mule, encode_coding_emacs_mule)
7806 (detect_coding_iso_2022, decode_coding_iso_2022)
7807 (encode_invocation_designation, encode_designation_at_bol)
7808 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7809 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
7810 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
7811 (encode_coding_ccl, encode_coding_raw_text)
7812 (detect_coding_charset, decode_coding_charset)
7813 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
7814 (produce_composition, produce_charset, produce_annotation)
7815 (decode_coding, handle_composition_annotation)
7816 (handle_charset_annotation, consume_chars, decode_coding_gap)
7817 (decode_coding_object, encode_coding_object, detect_coding_system)
7818 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
7819 (code_convert_region, code_convert_string)
8f50130c
PE
7820 (Fdefine_coding_system_internal)
7821 (coding_set_source, coding_set_destination):
d311d28c
PE
7822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7823 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
7824 (Fdefine_coding_system_internal):
7825 Don't assume fixnums fit in int.
7826 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 7827 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
7828 (Funencodable_char_position, Fcheck_coding_systems_region)
7829 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 7830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 7831 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 7832 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 7833 Don't access memory outside of the args array.
d311d28c 7834 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
7835 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
7836 result of ENCODE_CHAR.
d311d28c
PE
7837 * coding.h: Adjust decls to match defn changes elsewhere.
7838 (struct coding_system):
7839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7840 * composite.c (get_composition_id, find_composition)
7841 (run_composition_function, update_compositions)
7842 (compose_text, composition_gstring_put_cache)
7843 (composition_gstring_p, composition_gstring_width)
7844 (fill_gstring_header, fill_gstring_body, autocmp_chars)
7845 (composition_compute_stop_pos, composition_reseat_it)
7846 (composition_update_it, struct position_record)
7847 (find_automatic_composition, composition_adjust_point)
7848 (Fcomposition_get_gstring, Ffind_composition_internal):
7849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7850 (update_compositions):
7851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7852 * composite.h: Adjust decls to match defn changes elsewhere.
7853 (struct composition):
7854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7855 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
7856 Do not attempt to compute the address of the object just before a
7857 buffer; this is not portable.
7858 (Faref, Faset):
7859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7860 (Faset): Use int, not EMACS_INT, where int is wide enough.
7861 (Fstring_to_number): Don't assume fixnums fit in int.
7862 (Frem): Don't assume arg is nonnegative.
7863 * dbusbind.c (xd_append_arg): Check for integers out of range.
7864 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 7865 (extract_signed, extract_unsigned): New functions.
243e0530
PE
7866 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
7867 (xd_get_connection_references): Return ptrdiff_t, not int.
7868 All uses changed.
7869 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
7870 (xd_read_message_1):
7871 Use int, not unsigned, where the dbus API uses int.
7872 (Fdbus_message_internal): Don't overflow mtype.
7873 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
7874 * dired.c (directory_files_internal, file_name_completion, scmp)
7875 (file_name_completion_stat):
7876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7877 (file_name_completion): Don't overflow matchcount.
7878 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
7879 * dispextern.h: Adjust decls to match defn changes elsewhere.
7880 (struct text_pos, struct glyph, struct bidi_saved_info)
7881 (struct bidi_string_data, struct bidi_it, struct composition_it)
7882 (struct it):
7883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7884 (struct display_pos, struct composition_it, struct it):
7885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7886 * dispnew.c (increment_matrix_positions)
7887 (increment_row_positions, mode_line_string)
7888 (marginal_area_string):
7889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 7890 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
7891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7892 (duration_to_sec_usec): New function, to check for overflow better.
7893 (Fsleep_for, sit_for): Use it.
7894 * doc.c (get_doc_string, store_function_docstring):
7895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7896 (get_doc_string, Fsnarf_documentation):
7897 Use int, not EMACS_INT, where int is wide enough.
7898 (get_doc_string):
7899 Use SAFE_ALLOCA, not alloca.
7900 Check for overflow when converting EMACS_INT to off_t.
7901 * doprnt.c (doprnt):
7902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7903 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
7904 Don't assume uid_t fits into fixnum.
7905 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
7906 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
7907 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
7908 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
7909 (general_insert_function)
7910 (Finsert_char, make_buffer_string, make_buffer_string_both)
7911 (update_buffer_properties, Fbuffer_substring)
7912 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
7913 (Fsubst_char_in_region, check_translation)
7914 (Ftranslate_region_internal, save_restriction_restore, Fformat)
7915 (transpose_markers, Ftranspose_regions):
7916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7917 (clip_to_bounds): Move to lisp.h as an inline function).
7918 (Fconstrain_to_field): Don't assume integers are nonnegative.
7919 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
7920 (Fsubst_char_in_region, Fsave_restriction):
7921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7922 (Femacs_pid): Don't assume pid_t fits into fixnum.
7923 (lo_time): Use int, not EMACS_INT, when int suffices.
7924 (lisp_time_argument): Check for usec out of range.
7925 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
7926 (Fuser_login_name, Fuser_full_name): Signal an error
7927 if a uid argument is out of range, rather than relying on
7928 undefined behavior.
c8d5c857
PE
7929 (Fformat_time_string): Remove now-unnecessary check.
7930 lisp_time_argument checks for out-of-range usec now.
243e0530 7931 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
7932 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
7933 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
7934 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
7935 (init_cmdargs, Fdump_emacs):
7936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7937 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
7938 the bottom (typically) 32 bits of the fixnum.
7939 * eval.c (specpdl_size, call_debugger):
7940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7941 (when_entered_debugger, Fbacktrace_debug):
7942 Don't assume fixnum can fit in int.
7943 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
7944 the object just before a buffer; this is not portable.
7945 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
7946 (grow_specpdl, unbind_to):
7947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7948 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
7949 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 7950 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
7951 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
7952 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
7953 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7954 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
7955 (a_write, e_write):
7956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7957 (Fcopy_file, non_regular_nbytes, read_non_regular)
7958 (Finsert_file_contents):
7959 Use int, not EMACS_INT, where int is wide enough.
7960 (READ_BUF_SIZE): Verify that it fits in int.
7961 (Finsert_file_contents): Check that counts are in proper range,
7962 rather than assuming fixnums fit into ptrdiff_t etc.
7963 Don't assume fixnums fit into int.
125b3835 7964 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7965 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7966 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7967 (string_char_to_byte, string_byte_to_char)
7968 (string_make_multibyte, string_to_multibyte)
7969 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7970 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7971 (substring_both, Fdelete, internal_equal, Ffillarray)
7972 (Fclear_string, mapcar1)
7973 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7974 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7975 (larger_vector, make_hash_table, maybe_resize_hash_table)
7976 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7977 (Fmaphash, secure_hash):
7978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7979 (concat): Check for string index and length overflow.
7980 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7981 (Frequire):
7982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7983 (larger_vector): New API (vec, incr_min, size_max) replaces old
7984 one (vec, new_size, init). This catches size overflow.
7985 INIT was removed because it was always Qnil.
7986 All callers changed.
7987 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7988 the upper bound on a hash table index size.
7989 (make_hash_table, maybe_resize_hash_table): Use it.
7990 (secure_hash): Computer start_byte and end_byte only after
7991 they're known to be in ptrdiff_t range.
7992 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7993 (Ffont_get_glyphs, Ffont_at):
7994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7995 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7996 (Flist_fonts, Fopen_font):
7997 Don't assume fixnum can fit in int.
7998 (check_gstring): Don't assume index can fit in int.
7999 (font_match_p): Check that fixnum is a character, not a nonnegative
8000 fixnum, since the later code needs to stuff it into an int.
8001 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
8002 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
8003 conversion overflow issues.
8004 (Fopen_font): Check for integer out of range.
8005 (Ffont_get_glyphs): Don't assume index can fit in int.
8006 * font.h: Adjust decls to match defn changes elsewhere.
8007 * fontset.c (reorder_font_vector): Redo score calculation to avoid
8008 integer overflow.
8009 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
8010 printmax_t, where ptrdiff_t is wide enough.
8011 (Finternal_char_font):
8012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8013 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
8014 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
8015 (Fset_frame_position, x_set_frame_parameters)
8016 (x_set_line_spacing, x_set_border_width)
8017 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
8018 Check that fixnums are in proper range for system types.
8019 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
8020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8021 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
8022 Use SAFE_ALLOCA_LISP, not alloca.
8023 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
8024 intptr_t is wide enough.
8025 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
8026 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
8027 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
8028 Check for fixnum out of range.
8029 * ftfont.c (ftfont_list): Don't assume index fits in int.
8030 Check that fixnums are in proper range for system types.
8031 (ftfont_shape_by_flt):
8032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
8033 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8035 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
8036 Check that fixnums are in proper range for system types.
8037 * gnutls.h: Adjust decls to match defn changes elsewhere.
8038 * gtkutil.c (xg_dialog_run):
8039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8040 (update_frame_tool_bar):
8041 Check that fixnums are in proper range for system types.
8042 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 8043 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
8044 * indent.c (last_known_column, last_known_column_point):
8045 (current_column_bol_cache):
8046 (skip_invisible, current_column, check_display_width):
8047 (check_display_width, scan_for_column, current_column_1)
8048 (Findent_to, Fcurrent_indentation, position_indentation)
8049 (indented_beyond_p, Fmove_to_column, compute_motion):
8050 (Fcompute_motion, Fvertical_motion):
8051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8052 (last_known_column_modified): Use EMACS_INT, not int.
8053 (check_display_width):
8054 (Fcompute_motion):
8055 Check that fixnums and floats are in proper range for system types.
8056 (compute_motion): Don't assume index or fixnum fits in int.
8057 (compute_motion, Fcompute_motion):
8058 Use int, not EMACS_INT, when it is wide enough.
8059 (vmotion): Omit local var start_hpos that is always 0; that way
8060 we don't need to worry about overflow in expressions involving it.
8061 * indent.h: Adjust decls to match defn changes elsewhere.
8062 (struct position):
8063 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8064 Use int, not EMACS_INT, where int is wide enough.
8065 Remove unused members ovstring_chars_done and tab_offset;
8066 all uses removed.
8067 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
8068 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
8069 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
8070 (make_gap, copy_text, insert, insert_and_inherit)
8071 (insert_before_markers, insert_before_markers_and_inherit)
8072 (insert_1, count_combining_before, count_combining_after)
8073 (insert_1_both, insert_from_string)
8074 (insert_from_string_before_markers, insert_from_string_1)
8075 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
8076 (adjust_after_replace, adjust_after_insert, replace_range)
8077 (replace_range_2, del_range, del_range_1, del_range_byte)
8078 (del_range_both, del_range_2, modify_region)
8079 (prepare_to_modify_buffer, signal_before_change)
8080 (signal_after_change, Fcombine_after_change_execute):
8081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8082 * intervals.c (traverse_intervals, rotate_right, rotate_left)
8083 (balance_an_interval, split_interval_right, split_interval_left)
8084 (find_interval, next_interval, update_interval)
8085 (adjust_intervals_for_insertion, delete_node, delete_interval)
8086 (interval_deletion_adjustment, adjust_intervals_for_deletion)
8087 (static_offset_intervals, offset_intervals)
8088 (merge_interval_right, merge_interval_left, make_new_interval)
8089 (graft_intervals_into_buffer, temp_set_point_both)
8090 (temp_set_point, set_point, adjust_for_invis_intang)
8091 (set_point_both, move_if_not_intangible, get_property_and_range)
8092 (get_local_map, copy_intervals, copy_intervals_to_string)
8093 (compare_string_intervals, set_intervals_multibyte_1):
8094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8095 * intervals.h: Adjust decls to match defn changes elsewhere.
8096 (struct interval):
8097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8098 * keyboard.c (this_command_key_count, this_single_command_key_start)
8099 (before_command_key_count, before_command_echo_length, echo_now)
8100 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
8101 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
8102 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
8103 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
8104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8105 (last_non_minibuf_size, last_point_position, echo_truncate)
8106 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
8107 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
8108 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
8109 (stuff_buffered_input):
8110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8111 (last_auto_save, command_loop_1, read_char):
8112 Use EMACS_INT, not int, to avoid integer overflow.
8113 (record_char): Avoid overflow in total_keys computation.
8114 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
8115 * keyboard.h: Adjust decls to match defn changes elsewhere.
8116 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
8117 (Fkey_description, Fdescribe_vector, Flookup_key):
8118 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8119 (click_position): New function, to check that positions are in range.
8120 (Fcurrent_active_maps):
8121 (describe_command):
8122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8123 (Faccessible_keymaps, Fkey_description):
8124 (preferred_sequence_p):
8125 Don't assume fixnum can fit into int.
8126 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
8127 Check for integer overflow in size calculations.
8128 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
8129 avoid mishandling large integers.
8130 * lisp.h: Adjust decls to match defn changes elsewhere.
8131 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
8132 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
8133 (struct Lisp_Marker):
8134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8135 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
8136 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
8137 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
8138 All callers changed.
8139 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
8140 Assume the arg has valid form, since it always does.
8141 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
8142 unsigned integer system type.
8143 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
8144 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
8145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8146 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
8147 (duration_to_sec_usec): New decl.
8148 * lread.c (read_from_string_index, read_from_string_index_byte)
8149 (read_from_string_limit, readchar, unreadchar, openp)
8150 (read_internal_start, read1, oblookup):
8151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8152 (Fload, readevalloop, Feval_buffer, Feval_region):
8153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8154 (openp): Check for out-of-range argument to 'access'.
8155 (read1): Use int, not EMACS_INT, where int is wide enough.
8156 Don't assume fixnum fits into int.
6efdadfd 8157 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
8158 (read_filtered_event): Use duration_to_sec_usec
8159 to do proper overflow checking on durations.
d311d28c
PE
8160 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
8161 in size calculation.
8162 (Fexecute_kbd_macro):
8163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8164 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
8165 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
8166 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
8167 (set_marker_both, set_marker_restricted_both, marker_position)
8168 (marker_byte_position, Fbuffer_has_markers_at):
8169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8170 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 8171 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
8172 It now merely ensures that the menu is large enough, without
8173 necessarily growing it, as this avoids some integer overflow issues.
8174 All callers changed.
8175 (keymap_panes, parse_single_submenu, Fx_popup_menu):
8176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8177 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
8178 Use SAFE_ALLOCA_LISP, not alloca.
8179 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
8180 to EMACS_INT. Check that fixnums are in proper range for system types.
8181 * minibuf.c (minibuf_prompt_width, string_to_object)
8182 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
8183 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
8184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8185 (get_minibuffer, read_minibuf_unwind):
8186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8187 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
8188 this simplifies overflow checking. All callers changed.
8189 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
8190 (Ftest_completion):
8191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8192 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
8193 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
8194 Check that fixnums are in proper range for system types.
8195 (Fx_create_frame, Fx_show_tip):
8196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8197 * nsfont.m (ns_findfonts, nsfont_list_family):
8198 Don't assume fixnum fits in long.
8199 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
8200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8201 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
8202 wide enough.
17fdb222 8203 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
8204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8205 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
8206 (PRINTDECLARE, PRINTPREPARE):
8207 (strout, print_string):
8208 (print, print_preprocess, print_check_string_charset_prop)
8209 (print_object):
8210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8211 (PRINTDECLARE):
8212 (temp_output_buffer_setup, Fprin1_to_string, print_object):
8213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8214 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 8215 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 8216 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
8217 (print_error_message): Use SAFE_ALLOCA, not alloca.
8218 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
8219 (print_depth, new_backquote_output, print_number_index):
8220 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
8221 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
8222 (Fset_process_window_size, Fformat_network_address)
8223 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 8224 (sigchld_handler):
d311d28c 8225 Check that fixnums are in proper range for system types.
d44287d4 8226 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
8227 Check for process-ids out of pid_t range rather than relying on
8228 undefined behavior.
e4d81efc 8229 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
8230 (Fformat_network_address, read_process_output, send_process)
8231 (Fprocess_send_region, status_notify):
8232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8233 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
8234 (wait_reading_process_output, read_process_output, exec_sentinel):
8235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8236 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
8237 (Faccept_process_output): Use duration_to_sec_usec to do proper
8238 overflow checking on durations.
dde14581
PE
8239 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
8240 Don't assume pid_t fits in int.
02481186
PE
8241 * process.h (struct Lisp_Process): Members tick and update_tick
8242 are now of type EMACS_INT, not int.
b62b53e8
PE
8243 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
8244 configured --with-wide-int.
d311d28c
PE
8245 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
8246 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
8247 * search.c (looking_at_1, string_match_1):
8248 (fast_string_match, fast_c_string_match_ignore_case)
8249 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
8250 (scan_newline, find_before_next_newline, search_command)
8251 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
8252 (set_search_regs, wordify):
8253 (Freplace_match):
8254 (Fmatch_data):
8255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8256 (string_match_1, search_buffer, set_search_regs):
8257 (Fmatch_data):
8258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8259 (wordify): Check for overflow in size calculation.
8260 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
8261 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
8262 Check that fixnums are in proper range for system types.
8263 * sound.c (struct sound_device)
8264 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
8265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8266 (Fplay_sound_internal):
8267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 8268 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
8269 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
8270 (Fparse_partial_sexp):
8271 Don't assume fixnums can fit in int.
8272 (struct lisp_parse_state, find_start_pos, find_start_value)
8273 (find_start_value_byte, find_start_begv)
8274 (update_syntax_table, char_quoted, dec_bytepos)
8275 (find_defun_start, prev_char_comend_first, back_comment):
8276 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
8277 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
8278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8279 (Finternal_describe_syntax_value): Check that match_lisp is a
8280 character, not an integer, since the code stuffs it into int.
8281 (scan_words, scan_sexps_forward):
8282 Check that fixnums are in proper range for system types.
8283 (Fforward_word):
8284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8285 (scan_sexps_forward):
8286 Use CHARACTERP, not INTEGERP, since the value must fit into int.
8287 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
8288 * syntax.h: Adjust decls to match defn changes elsewhere.
8289 (struct gl_state_s):
8290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
8291 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
8292 MOST_POSITIVE_FIXNUM.
d311d28c
PE
8293 * sysdep.c (wait_for_termination_1, wait_for_termination)
8294 (interruptible_wait_for_termination, mkdir):
8295 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
8296 (emacs_read, emacs_write):
8297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
8298 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
8299 and double all fit in int.
d311d28c
PE
8300 * term.c (set_tty_color_mode):
8301 Check that fixnums are in proper range for system types.
8302 * termhooks.h (struct input_event):
8303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8304 * textprop.c (validate_interval_range, interval_of)
8305 (Fadd_text_properties, set_text_properties_1)
8306 (Fremove_text_properties, Fremove_list_of_text_properties)
8307 (Ftext_property_any, Ftext_property_not_all)
8308 (copy_text_properties, text_property_list, extend_property_ranges)
8309 (verify_interval_modification):
8310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8311 (Fnext_single_char_property_change)
8312 (Fprevious_single_char_property_change):
8313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
8314 (copy_text_properties):
8315 Check for integer overflow in index calculation.
d311d28c
PE
8316 * undo.c (last_boundary_position, record_point, record_insert)
8317 (record_delete, record_marker_adjustment, record_change)
8318 (record_property_change):
8319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8320 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
8321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8322 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
8323 (Fx_hide_tip, Fx_file_dialog):
8324 * w32menu.c (set_frame_menubar):
8325 Use ptrdiff_t, not int, for consistency with rest of code.
8326 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
8327 (select_window, Fdelete_other_windows_internal)
8328 (window_scroll_pixel_based, window_scroll_line_based)
8329 (Frecenter, Fset_window_configuration):
8330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8331 (Fset_window_hscroll, run_window_configuration_change_hook)
8332 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 8333 (Fscroll_other_window, Frecenter):
d311d28c
PE
8334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8335 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
8336 Don't assume fixnum fits in int.
8337 (Fset_window_scroll_bars):
8338 Check that fixnums are in proper range for system types.
8339 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
8340 (string_pos, c_string_pos, number_of_chars, init_iterator)
8341 (in_ellipses_for_invisible_text_p, init_from_display_pos)
8342 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
8343 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
8344 (face_before_or_after_it_pos, handle_invisible_prop)
8345 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
8346 (display_prop_intangible_p, string_buffer_position_lim)
8347 (string_buffer_position, handle_composition_prop, load_overlay_strings)
8348 (get_overlay_strings_1, get_overlay_strings)
8349 (iterate_out_of_display_property, forward_to_next_line_start)
8350 (back_to_previous_visible_line_start, reseat, reseat_to_string)
8351 (get_next_display_element, set_iterator_to_next)
8352 (get_visually_first_element, compute_stop_pos_backwards)
8353 (handle_stop_backwards, next_element_from_buffer)
8354 (move_it_in_display_line_to, move_it_in_display_line)
8355 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8356 (add_to_log, message_dolog, message_log_check_duplicate)
8357 (message2, message2_nolog, message3, message3_nolog
8358 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
8359 (current_message_1, truncate_echo_area, truncate_message_1)
8360 (set_message, set_message_1, store_mode_line_noprop)
8361 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
8362 (text_outside_line_unchanged_p, check_point_in_composition)
8363 (reconsider_clip_changes)
8364 (redisplay_internal, set_cursor_from_row, try_scrolling)
8365 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
8366 (redisplay_window, find_last_unchanged_at_beg_row)
8367 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
8368 (trailing_whitespace_p, find_row_edges, display_line)
8369 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
8370 (display_mode_element, store_mode_line_string)
8371 (pint2str, pint2hrstr, decode_mode_spec)
8372 (display_count_lines, display_string, draw_glyphs)
8373 (x_produce_glyphs, x_insert_glyphs)
8374 (rows_from_pos_range, mouse_face_from_buffer_pos)
8375 (fast_find_string_pos, mouse_face_from_string_pos)
8376 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8378 (safe_call, init_from_display_pos, handle_fontified_prop)
8379 (handle_single_display_spec, load_overlay_strings)
8380 (with_echo_area_buffer, setup_echo_area_for_printing)
8381 (display_echo_area, echo_area_display)
8382 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
8383 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
8384 (redisplay_window, dump_glyph_row, display_mode_line)
8385 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 8386 (handle_display_spec, display_prop_string_p):
d311d28c
PE
8387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8388 (handle_single_display_spec, build_desired_tool_bar_string)
8389 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
8390 (get_specified_cursor_type):
8391 Check that fixnums are in proper range for system types.
8392 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
8393 (Flookup_image_map):
8394 Don't assume fixnums fit in int.
8395 (compare_overlay_entries):
8396 Avoid mishandling comparisons due to subtraction overflow.
8397 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
8398 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
8399 (handle_tool_bar_click):
8400 Use int, not unsigned, since we prefer signed and the signedness
8401 doesn't matter here.
8402 (get_next_display_element, next_element_from_display_vector):
8403 Use int, not EMACS_INT, when int is wide enough.
8404 (start_hourglass): Use duration_to_sec_usec to do proper
8405 overflow checking on durations.
8406 * xfaces.c (Fbitmap_spec_p):
8407 Check that fixnums are in proper range for system types.
8408 (compare_fonts_by_sort_order):
8409 Avoid mishandling comparisons due to subtraction overflow.
8410 (Fx_family_fonts, realize_basic_faces):
8411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8412 (Fx_family_fonts):
8413 Don't assume fixnum fits in int.
8414 Use SAFE_ALLOCA_LISP, not alloca.
8415 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
8416 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
8417 (face_at_buffer_position, face_for_overlay_string)
8418 (face_at_string_position):
8419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8420 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
8421 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
8422 (Fx_show_tip):
8423 Check that fixnums are in proper range for system types.
8424 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
8425 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
8426 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8427 (Fx_change_window_property): Don't assume fixnums fit in int.
8428 * xfont.c (xfont_chars_supported):
8429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8430 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
8431 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
8432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8433 * xml.c (parse_region):
8434 * xrdb.c (magic_file_p):
8435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8436 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
8437 (x_get_local_selection, x_reply_selection_request)
8438 (x_handle_selection_request, wait_for_property_change):
8439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8440 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
8441 short is wide enough.
8442 (x_send_client_event): Don't assume fixnum fits in int.
8443 * xterm.c (x_x_to_emacs_modifiers):
8444 Don't assume EMACS_INT overflows nicely into int.
8445 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
8446 may come from Lisp.
8447 (handle_one_xevent): NATNUMP can eval its arg twice.
8448 (x_connection_closed):
8449 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8450 * xterm.h: Adjust decls to match defn changes elsewhere.
8451 (struct scroll_bar): Use struct vectorlike_header
8452 rather than rolling our own approximation.
8453 (SCROLL_BAR_VEC_SIZE): Remove; not used.
8454
c6574eb5
GM
84552012-05-25 Glenn Morris <rgm@gnu.org>
8456
8457 * lisp.mk (lisp): Update for more files being compiled now.
8458
e8d32c7e
SM
84592012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
8460
48def666
SM
8461 * lread.c: Remove `read_pure' which makes no difference.
8462 (read_pure): Remove var.
8463 (unreadpure): Remove function.
8464 (readevalloop): Don't call read_list with -1 flag.
8465 (read1, read_vector): Don't test read_pure any more.
8466 (read_list): Simplify.
8467
e8d32c7e
SM
8468 * fileio.c, character.h: Minor style tweaks.
8469
4b2addb7
DA
84702012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
8471
8472 * window.h (clip_changed): Remove useless declaration.
8473
584461b2
JB
84742012-05-22 Juanma Barranquero <lekktu@gmail.com>
8475
8476 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
8477 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
8478
34374650
PE
84792012-05-22 Paul Eggert <eggert@cs.ucla.edu>
8480
8481 Remove src/m/*.
8482 This directory predates autoconf and is no longer needed nowadays.
8483 Move its few remaining bits of functionality to where they're needed.
8484 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
8485 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
8486 * m/template.h: Remove.
8487 * Makefile.in (M_FILE): Remove. All uses removed.
8488 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
8489 * lisp.h (USE_LSB_TAG):
8490 * mem-limits.h (EXCEEDS_LISP_PTR):
8491 Use VAL_MAX, not VALBITS, in #if.
8492 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
8493 (EMACS_UINT): Define unconditionally now.
8494 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
8495 (BITS_PER_EMACS_INT): New constants, replacing
8496 what used to be in config.h, but not useful in #if.
8497 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
8498 define them any more.
8499 (VAL_MAX): New macro.
8500 (VALMASK): Use it.
8501 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
8502 BITS_PER_EMACS_INT, in #if.
8503 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
8504 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
8505 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
8506 * s/ms-w32.h (DATA_START):
8507 Move here from removed file m/intel386.h.
8508 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
8509 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
8510
261cb4bb
PE
85112012-05-21 Paul Eggert <eggert@cs.ucla.edu>
8512
8513 Assume C89 or later.
8514 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
8515 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
8516 (xrealloc):
8517 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
8518 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
8519 * textprop.c, tparam.c (NULL): Remove.
8520 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
8521 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
8522 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
8523 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
8524 * xterm.c (input_signal_count): Assume volatile works.
8525
ff23cd9f
KB
85262012-05-21 Ken Brown <kbrown@cornell.edu>
8527
8528 * xgselect.c (xg_select): Fix first argument in call to 'select'
8529 (bug#11508).
8530
1b170bc6
KB
85312012-05-20 Ken Brown <kbrown@cornell.edu>
8532
8533 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 8534 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 8535
b2f4d39f
KB
85362012-05-19 Ken Brown <kbrown@cornell.edu>
8537
8538 * xfns.c (x_in_use): Remove `static' qualifier.
8539 * xterm.h (x_in_use): Declare.
8540 * xgselect.c: Include xterm.h.
8541 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
8542 and `display_arg' (bug#9754).
8543
003fdae2
PE
85442012-05-19 Paul Eggert <eggert@cs.ucla.edu>
8545
9232a6d9
PE
8546 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
8547
003fdae2
PE
8548 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
8549 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
8550
784b56e2
EZ
85512012-05-18 Eli Zaretskii <eliz@gnu.org>
8552
8553 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
8554
8555 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 8556 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
8557
8558 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
8559 reference to image_cache->refcount.
8560 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
8561
a0a79cde
JL
85622012-05-17 Juri Linkov <juri@jurta.org>
8563
8564 * search.c (Fword_search_regexp, Fword_search_backward)
8565 (Fword_search_forward, Fword_search_backward_lax)
8566 (Fword_search_forward_lax): Move functions to isearch.el
8567 (bug#10145, bug#11381).
8568
b0572523
PE
85692012-05-16 Paul Eggert <eggert@cs.ucla.edu>
8570
8571 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
8572
9660f5fc
SM
85732012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
8574
8575 * lread.c (init_obarray): Declare Qt and Qnil as special.
8576
4374de83
GM
85772012-05-14 Glenn Morris <rgm@gnu.org>
8578
8579 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 8580 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 8581
dc44c39a
PE
85822012-05-14 Paul Eggert <eggert@cs.ucla.edu>
8583
078c97cb
PE
8584 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
8585
dc44c39a
PE
8586 * unexaix.c: Port to more-recent AIX compilers.
8587 (report_error, report_error_1, make_hdr, copy_sym)
8588 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
8589 Make arguments const char *, not char *, to avoid violations of C
8590 standard and to fix some AIX warnings reported by Gilles Pion.
8591
e18afed7 85922012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
8593
8594 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
8595 already have overlays loaded.
8596 (handle_single_display_spec): Before returning without displaying
8597 fringe bitmap, synchronize the bidi iterator with the main display
8598 iterator, by calling iterate_out_of_display_property.
8599 (iterate_out_of_display_property): Detect buffer iteration by
8600 testing that it->string is a Lisp string.
8601 (get_next_display_element): When the current object is exhausted,
8602 and there's something on it->stack, call set_iterator_to_next to
8603 proceed with what's on the stack, instead of returning zero.
8604 (set_iterator_to_next): If called at the end of a Lisp string,
8605 proceed to consider_string_end without incrementing string
8606 position. Don't increment display vector index past the end of
8607 the display vector. (Bug#11417)
c8fb9dc6
EZ
8608 (pos_visible_p): Don't report a position visible when move_it_to
8609 stopped at the last line of window, which happens to be scanned
8610 backwards by the bidi iteration. (Bug#11464)
ac268e67 8611
e18afed7 86122012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
8613
8614 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
8615 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
8616 are on a TTY, and thus unable to display on the fringes.
8617 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
8618 so we need to signal to the caller that this is a "replacing"
8619 display spec. This fixes display when the spec is invalid or we
8620 are on a TTY.
8621
e18afed7 86222012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
8623
8624 * unexaix.c (make_hdr): Fix typo in prototype.
8625 This bug broke the build on AIX. Problem reported by Gilles Pion.
8626
9d0a235a
MA
86272012-05-14 Michael Albinus <michael.albinus@gmx.de>
8628
8629 * keyboard.c (kbd_buffer_get_event): Read special events also in
8630 batch mode. (Bug#11415)
8631
9e6b06ed
GM
86322012-05-12 Glenn Morris <rgm@gnu.org>
8633
8634 * ns.mk: Update for ns_appbindir no longer having trailing "/".
8635
c1a1d7a3
EZ
86362012-05-12 Eli Zaretskii <eliz@gnu.org>
8637
8638 * lisp.mk (lisp): Add newcomment.elc.
8639
3fe7cdc8
GM
86402012-05-12 Glenn Morris <rgm@gnu.org>
8641
8642 * Makefile.in (MKDIR_P): New, set by configure.
8643 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
8644
53f7d2c0
PE
86452012-05-11 Paul Eggert <eggert@cs.ucla.edu>
8646
8647 Remove unused function hourglass_started.
8648 * dispextern.h (hourglass_started):
8649 * w32fns.c (hourglass_started):
8650 * xdisp.c (hourglass_started): Remove.
8651
75aafb17
JB
86522012-05-10 Juanma Barranquero <lekktu@gmail.com>
8653
8654 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
8655 Update dependencies.
8656
12959e8e
PE
86572012-05-10 Paul Eggert <eggert@cs.ucla.edu>
8658
97107e2e
PE
8659 * xgselect.c (xg_select): Put maxfds+1 into a var.
8660 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
8661
12959e8e
PE
8662 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
8663
836d29b3
DA
86642012-05-10 Dave Abrahams <dave@boostpro.com>
8665
8666 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
8667 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
8668
5cb67954
MA
86692012-05-09 Michael Albinus <michael.albinus@gmx.de>
8670
8671 * dbusbind.c (xd_registered_buses): New internal Lisp object.
8672 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
8673 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
8674 Initialize xd_registered_buses.
8675
3478ec45
PE
86762012-05-09 Paul Eggert <eggert@cs.ucla.edu>
8677
b263a6b0
PE
8678 Untag more efficiently if USE_LSB_TAG.
8679 This is based on a proposal by YAMAMOTO Mitsuharu in
8680 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
8681 For an admittedly artificial (nth 8000 longlist) benchmark on
8682 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
8683 Emacs's overall text size by 1%.
8684 * lisp.h (XUNTAG): New macro.
8685 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
8686 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
8687 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
8688 * eval.c (Fautoload):
8689 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
8690 * frame.h (XFRAME): Use XUNTAG.
8691
3478ec45
PE
8692 Port recent dbusbind.c changes to 32-bit --with-wide-int.
8693 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
8694 Remove unportable assumptions about print widths of types like
8695 dbus_uint32_t.
8696 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
8697 intptr_t when converting between pointer and integer, to avoid GCC
8698 warnings about wrong width.
8699
666b903b 87002012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
8701
8702 * w32proc.c (new_child): Force Windows to reserve only 64KB of
8703 stack for each reader_thread, instead of defaulting to 8MB
8704 determined by the linker. This avoids failures in creating
8705 subprocesses on Windows 7, see the discussion in this thread:
8706 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
8707
b120cc17
JC
87082012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
8709
8710 Fix up display of the *Minibuf-0* buffer in the mini window.
8711 * keyboard.c (read_char): Don't clear the echo area if there's no
8712 message to clear.
8713 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 8714 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 8715
9a4b36f8
MA
87162012-05-07 Michael Albinus <michael.albinus@gmx.de>
8717
8718 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
8719 batch mode.
8720
e5f9458f
CY
87212012-05-06 Chong Yidong <cyd@gnu.org>
8722
8723 * lisp.mk (lisp): Update.
8724
eceeb5fc 87252012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
8726
8727 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
8728
71873e2b
SM
87292012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
8730
8731 * data.c (PUT_ERROR): New macro.
8732 (syms_of_data): Use it. Add new error type `user-error'.
8733 * undo.c (user_error): New function.
8734 (Fprimitive_undo): Use it.
8735 * print.c (print_error_message): Adjust print style for `user-error'.
8736 * keyboard.c (user_error): New function.
8737 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
8738
ab0fa4e4
PE
87392012-05-03 Paul Eggert <eggert@cs.ucla.edu>
8740
8741 Do not limit current-time-string to years 1000..9999.
8742 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
8743 (Fcurrent_time_string): Support any year that is supported by the
8744 underlying localtime representation. Don't use asctime, as it
8745 has undefined behavior for years outside the range -999..9999.
8746
7ed806a7
PE
87472012-05-02 Paul Eggert <eggert@cs.ucla.edu>
8748
8749 Fix race conditions involving setenv, gmtime, localtime, asctime.
8750 Without this fix, interrupts could mess up code that uses these
8751 nonreentrant functions, since setting TZ invalidates existing
8752 tm_zone or tzname values, and since most of these functions return
8753 pointers to static storage.
8754 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
8755 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
8756 Grow the critical sections to include not just invoking
8757 localtime/gmtime, but also accessing these functions' results
8758 including their tm_zone values if any, and any related TZ setting.
8759 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
8760 so that the struct tm is saved in the critical section.
8761 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
8762 motivated by the fact that memory allocation needs to be outside
8763 the critical section.
8764
0c16dfed
DA
87652012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
8766
8767 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
8768 with RESET_INTERVAL.
8769
8770 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8771 Remove duplicated buffer name initialization.
8772
3f83ace8
JM
87732012-05-02 Jim Meyering <jim@meyering.net>
8774
8775 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
8776
c7b8541e
JM
8777 * xfns.c (x_window): Use xstrdup (Bug#11375).
8778
90207a15 87792012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
8780
8781 * xdisp.c (pos_visible_p): If already at a newline from the
8782 display string before the 'while' loop, don't walk back the glyphs
8783 from it3.glyph_row. Solves assertion violation when the display
8784 string begins with a newline (egg.el). (Bug#11367)
8785
b593d6a9
AH
87862012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
8787
8788 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
8789 Move to simple.el.
8790
4737362e
GM
87912012-05-01 Glenn Morris <rgm@gnu.org>
8792
99cf43f9
GM
8793 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
8794 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
8795 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
8796 All were removed before 23.1.
8797
9311dcff
GM
8798 * dispnew.c: Remove HAVE_LIBNCURSES test;
8799 it is always true on relevant platforms.
8800
4d5c6349
GM
8801 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
8802 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
8803
4737362e
GM
8804 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
8805
74dd3a6b
AS
88062012-04-30 Andreas Schwab <schwab@linux-m68k.org>
8807
8808 * .gdbinit (xpr): Remove checks for no longer existing misc types.
8809 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
8810 Remove.
8811
13c379ee
PE
88122012-04-28 Paul Eggert <eggert@cs.ucla.edu>
8813
8814 Do not avoid creating empty evaporating overlays (Bug#9642).
8815 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
8816 That is, do not delete an evaporating overlay if it becomes
8817 empty after its bounds are adjusted to fit within its buffer.
8818 This fix caused other problems, and I'm reverting it until we get
8819 to the bottom of them.
8820
a8e7d6d7 88212012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
8822
8823 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
8824
a8e7d6d7 88252012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
8826
8827 * xdisp.c (pos_visible_p): If the window start position is beyond
8828 ZV, start the display from buffer beginning. Prevents assertion
8829 violation in init_iterator when the minibuffer window is scrolled
8830 via the scroll bar.
8831
8832 * window.c (window_scroll_pixel_based): Likewise.
8833
a8e7d6d7 88342012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
8835
8836 * keymap.c (where_is_internal): Doc fix (Bug#10872).
8837
a8e7d6d7 88382012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
8839
8840 * fileio.c (Fcopy_file, Fset_file_selinux_context):
8841 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
8842
a8e7d6d7 88432012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 8844
b593d6a9
AH
8845 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
8846 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 8847
1c6900d9
EZ
88482012-04-26 Eli Zaretskii <eliz@gnu.org>
8849
4c3fa1d9
EZ
8850 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
8851 display element, check also the underlying string or buffer
8852 character. (Bug#11341)
8853
1c6900d9
EZ
8854 * w32menu.c: Include w32heap.h.
8855 (add_menu_item): If the call to AppendMenuW (via
8856 unicode_append_menu) fails, disable Unicode menus only if we are
8857 running on Windows 9X/Me.
8858
42bf8205
AS
88592012-04-24 Andreas Schwab <schwab@linux-m68k.org>
8860
8861 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
8862 (xgetint): Add missing shift for LSB tags.
8863
b1bac16e
MR
88642012-04-24 Martin Rudalics <rudalics@gmx.at>
8865
8866 * keyboard.c (read_char): Don't wipe echo area for select window
8867 events: These might get delayed via `mouse-autoselect-window'
8868 (Bug#11304).
8869
d69621cc
JB
88702012-04-24 Juanma Barranquero <lekktu@gmail.com>
8871
8872 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
8873 manipulation of :loaded-from data.
8874
02fd101b
JB
88752012-04-23 Juanma Barranquero <lekktu@gmail.com>
8876
8877 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
8878 now a cons (bug#11311).
8879
888bec30
PE
88802012-04-23 Paul Eggert <eggert@cs.ucla.edu>
8881
89a438bd
PE
8882 Do not create empty overlays with the evaporate property (Bug#9642).
8883 * buffer.c (Fmove_overlay): Delete an evaporating overlay
8884 if it becomes empty after its bounds are adjusted to fit within
8885 its buffer. Without this fix, in a nonempty buffer (let ((o
8886 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
8887 yields an empty overlay that has the evaporate property, which is
8888 not supposed to happen.
8889
1068fe4d
PE
8890 Fix minor GTK3 problems found by static checking.
8891 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8892 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8893 (struct _EmacsFixedClass, emacs_fixed_get_type):
8894 Move decls here from emacsgtkfixed.h, since they needn't be public.
8895 (emacs_fixed_get_type): Now static.
8896 (emacs_fixed_class_init): Omit unused local.
8897 (emacs_fixed_child_type): Remove; unused.
8898 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8899 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8900 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
8901 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
8902 (EMACS_FIXED_GET_CLASS): Remove; unused.
8903 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
8904
888bec30
PE
8905 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
8906 Problem reported by Juanma Barranquero for Windows -Wunused-function.
8907
de85e130
PE
89082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8909
d0baac98 8910 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 8911 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
8912 (__malloc_size_t, __malloc_ptrdiff_t):
8913 Remove. All uses removed, replaced by the definiens if needed,
8914 since we can assume C89 or better now.
8915 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
8916 (protect_malloc_state, align, get_contiguous_space)
8917 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
8918 (malloc_atfork_handler_child, malloc_enable_thread)
8919 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
8920 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
8921 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
8922 (special_realloc, _realloc_internal_nolock, _realloc_internal)
8923 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
8924 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
8925 Define using prototypes, not old style.
8926 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
8927 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
8928 (align): Don't assume that signed integer overflow wraps around.
8929 Omit unused local var.
8930 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
8931 (_free_internal_nolock, memalign, mallochook, reallochook):
8932 Omit no-longer-needed casts.
8933 (valloc): Use getpagesize, not __getpagesize.
8934 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
8935 (struct hdr): The 'magic' member is now size_t, not unsigned long.
8936
de85e130
PE
8937 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
8938
dcbf5805
MA
89392012-04-22 Michael Albinus <michael.albinus@gmx.de>
8940
8941 Move functions from C to Lisp. Make non-blocking method calls
8942 the default. Implement further D-Bus standard interfaces.
8943
8944 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
8945 (QCdbus_request_name_allow_replacement)
8946 (QCdbus_request_name_replace_existing)
8947 (QCdbus_request_name_do_not_queue)
8948 (QCdbus_request_name_reply_primary_owner)
8949 (QCdbus_request_name_reply_in_queue)
8950 (QCdbus_request_name_reply_exists)
8951 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
8952 (QCdbus_registered_serial, QCdbus_registered_method)
8953 (QCdbus_registered_signal): New Lisp objects.
8954 (XD_DEBUG_MESSAGE): Use sizeof.
8955 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8956 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8957 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8958 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8959 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8960 (xd_signature, xd_append_arg): Allow float for integer types.
8961 (xd_get_connection_references): New function.
b593d6a9
AH
8962 (xd_get_connection_address): Rename from xd_initialize.
8963 Return cached address.
dcbf5805
MA
8964 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8965 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8966 level.
8967 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8968 Return number of refcounts.
dcbf5805
MA
8969 (Fdbus_get_unique_name): Make stronger parameter check.
8970 (Fdbus_message_internal): New defun.
8971 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8972 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8973 (Fdbus_send_signal, Fdbus_register_service)
8974 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8975 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8976 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8977 (Vdbus_compiled_version, Vdbus_runtime_version)
8978 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8979 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8980 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8981 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8982 Adapt docstring.
dcbf5805 8983
52828e02
PE
89842012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8985
da05bc4c
PE
8986 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8987 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8988 Do not assume ptrdiff_t is the same width as 'int'.
8989
52828e02
PE
8990 * alloc.c: Handle unusual debugging option combinations.
8991 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8992 since the two debugging options are incompatible.
8993 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8994 is defined.
8995 (mem_init, mem_insert, mem_insert_fixup):
8996 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8997 (NEED_MEM_INSERT): Remove; no longer needed.
8998
f01769f9
LL
89992012-04-22 Leo Liu <sdl.web@gmail.com>
9000
9001 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
9002
5790543d
PE
90032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
9004
9005 * sysdep.c [__FreeBSD__]: Minor cleanups.
9006 (list_system_processes, system_process_attributes) [__FreeBSD__]:
9007 Use Emacs indenting style more consistently. Avoid some casts.
9008 Use 'double' consistently rather than mixing 'float' and 'double'.
9009
b91b7e4d
EW
90102012-04-21 Eduard Wiebe <usenet@pusto.de>
9011
b593d6a9
AH
9012 * sysdep.c (list_system_processes, system_process_attributes):
9013 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 9014
6114eb15
AS
90152012-04-21 Andreas Schwab <schwab@linux-m68k.org>
9016
9017 * lisp.mk (lisp): Update.
9018
2f38dff7
PE
90192012-04-20 Paul Eggert <eggert@cs.ucla.edu>
9020
9021 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
9022 It is never used otherwise.
9023
4ae29f89
SM
90242012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
9025
9026 * print.c (print_preprocess): Only check print_depth if print-circle
9027 is nil.
9028 (print_object): Check for cycles even when print-circle is nil and
9029 print-gensym is t, but only check print_depth if print-circle is nil.
9030
f30d612a
CY
90312012-04-20 Chong Yidong <cyd@gnu.org>
9032
9033 * process.c (wait_reading_process_output): If EIO occurs on a pty,
9034 set the status to "failed" and ensure that sentinel is run.
9035
c07a4c0b 90362012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
9037
9038 * process.c (Fset_process_inherit_coding_system_flag)
9039 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 9040 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 9041
c07a4c0b 90422012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
9043
9044 * xdisp.c (string_buffer_position_lim): Limit starting position to
9045 BEGV.
9046 (set_cursor_from_row): If called for a mode-line or header-line
9047 row, return zero immediately.
9048 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
9049 farther than the first row after the header line, if any.
9050 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
9051 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
9052
c07a4c0b 90532012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 9054
4ae29f89
SM
9055 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
9056 (bug#11238).
ad3a2b41 9057
c07a4c0b 90582012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 90592012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
9060
9061 configure: new option --enable-gcc-warnings (Bug#11207)
9062 * Makefile.in (C_WARNINGS_SWITCH): Remove.
9063 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
9064 (ALL_CFLAGS): Use new macros rather than old.
9065 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
9066 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
9067 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
9068 -Wunused-result, -Wunused-variable. This should go away once
9069 the Emacs and Gnulib regex code is merged.
9070 (xmalloc, xrealloc): Now static.
9071
aba027e8
PE
90722012-04-17 Paul Eggert <eggert@cs.ucla.edu>
9073
9074 * dired.c (Fsystem_groups): Remove unused local.
9075
e5a36063
GM
90762012-04-17 Glenn Morris <rgm@gnu.org>
9077
9078 * dired.c (Fsystem_users): Doc fix.
9079
316411f0
DA
90802012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
9081
9082 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
9083 (syms_of_dired): Add them.
9084
9426aba4
PE
90852012-04-16 Paul Eggert <eggert@cs.ucla.edu>
9086
b62a57be
PE
9087 Fix minor alloc.c problems found by static checking.
9088 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
9089 New extern decls, to avoid calling undeclared functions.
9090 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
9091 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
9092 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
9093 (NEED_MEM_INSERT): New macro.
9094 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 9095 Remove one incorrect comment and fix another.
b62a57be 9096
3539f31f
PE
9097 Fix minor ralloc.c problems found by static checking.
9098 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
9099 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
9100 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
9101 (r_alloc_sbrk): Now static.
9102
a041960a
PE
9103 Improve ralloc.c interface checking.
9104 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
9105 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
9106 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
9107 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
9108 [REL_ALLOC]: ... to here, to check interface.
9109 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
9110 Remove decls. This fixes an "It stinks!".
9111
9426aba4
PE
9112 * alloc.c (which_symbols): Fix alignment issue / type clash.
9113
d55c12ed
AS
91142012-04-15 Andreas Schwab <schwab@linux-m68k.org>
9115
9116 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
9117 (struct Lisp_Misc_Any): Likewise.
9118 (struct Lisp_Free): Likewise.
9119 * alloc.c (union aligned_Lisp_Symbol): Define.
9120 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
9121 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
9122 (union aligned_Lisp_Misc): Define.
9123 (MARKER_BLOCK_SIZE, struct marker_block): Use union
9124 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 9125 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 9126
b948ce8b
PE
91272012-04-14 Paul Eggert <eggert@cs.ucla.edu>
9128
9129 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
9130 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
9131 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
9132 * s/netbsd.h, s/sol2-6.h:
9133 Remove definition of GC_MARK_STACK, since the default now works.
9134 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
9135 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
9136 no longer the default.
9137 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
9138
35dc09a1 91392012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 9140
35dc09a1
GM
9141 * lread.c (lisp_file_lexically_bound_p):
9142 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 9143
35dc09a1
GM
91442012-04-14 Eli Zaretskii <eliz@gnu.org>
9145
9146 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
9147 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
9148
91492012-04-14 Jan Djärv <jan.h.d@swipnet.se>
9150
9151 * nsterm.m (constrainFrameRect): Always constrain when there is only
9152 one screen (Bug#10962).
9153
bcd86815
KB
91542012-04-13 Ken Brown <kbrown@cornell.edu>
9155
9156 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
9157
c25df26e
RT
91582012-04-13 Reuben Thomas <rrt@sc3d.org>
9159
9160 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
9161
0fc59f1e
DC
91622012-04-11 Daniel Colascione <dancol@dancol.org>
9163
9164 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
9165 against is gone. It's better to use vfork now so that when Cygwin
9166 gains a new, working vfork, we use it automatically (bug#10398).
9167
de8c03dc
SM
91682012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
9169
9170 * window.c (save_window_save): Obey window-point-insertion-type.
9171
2f097256
GM
91722012-04-11 Glenn Morris <rgm@gnu.org>
9173
9174 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
9175
453b951e
SM
91762012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
9177
9178 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
9179
75f1671a 91802012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
9181
9182 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
9183 (force_quit_count): New var.
9184 (handle_interrupt): Use it.
9185
2a8ce227
JB
91862012-04-10 Juanma Barranquero <lekktu@gmail.com>
9187
9188 * w32.c (w32_delayed_load): Record the full path of the library
9189 being loaded (bug#10424).
9190
935396c0
GM
91912012-04-09 Glenn Morris <rgm@gnu.org>
9192
05920a43
GM
9193 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
9194 not just in the obarray, before snarfing them. (Bug#11036)
9195
935396c0
GM
9196 * Makefile.in ($(leimdir)/leim-list.el):
9197 Pass EMACS rather than BUILT_EMACS.
9198
a18ecafa
TZ
91992012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
9200
9201 * process.c (make_process):
9202 * process.h: Add integer `gnutls_handshakes_tried' member to
9203 process struct.
9204
6bbef4e5
JC
9205 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
9206 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
9207
9208 * gnutls.c (gnutls_log_function2i): Convenience log function.
9209 (emacs_gnutls_read): Use new log functions,
9210 `gnutls_handshakes_tried' process member, and
9211 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
9212 attempts per process (connection).
9213
b4d3bc10
CY
92142012-04-09 Chong Yidong <cyd@gnu.org>
9215
9216 * eval.c (Fuser_variable_p, user_variable_p_eh)
9217 (lisp_indirect_variable): Functions deleted.
9218 (Fdefvar): Caller changed.
9219
9220 * callint.c (Finteractive, Fcall_interactively):
9221 * minibuf.c (Fread_variable): Callers changed.
9222
70f4d973
EZ
92232012-04-09 Eli Zaretskii <eliz@gnu.org>
9224
9225 * xdisp.c (set_cursor_from_row): If the display string appears in
9226 the buffer at position that is closer to point than the position
9227 after the display string, display the cursor on the first glyph of
9228 the display string. Fixes cursor display when a 'display' text
9229 property immediately follows invisible text. (Bug#11094)
9230
cb3c2e3e
PE
92312012-04-09 Paul Eggert <eggert@cs.ucla.edu>
9232
9233 composite.c: use 'double' consistently
9234 * composite.c (get_composition_id): Use 'double' consistently
9235 instead of converting 'float' to 'double' and vice versa; this is
9236 easier to understand and avoids a GCC warning.
9237
fd06db5d
GM
92382012-04-09 Glenn Morris <rgm@gnu.org>
9239
50fe702a
GM
9240 * Makefile.in: Generate leim-list with bootstrap-emacs, in
9241 preparation for dumping it with emacs. (Bug#4789)
9242 (leimdir): New variable.
9243 ($(leimdir)/leim-list.el): New rule.
9244 (emacs$(EXEEXT)): Depend on leim-list.el.
9245
fd06db5d
GM
9246 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
9247 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
9248 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
9249
55c131ee
AS
92502012-04-08 Andreas Schwab <schwab@linux-m68k.org>
9251
9252 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
9253 proper alignment.
9254
9209588f
JB
92552012-04-07 Juanma Barranquero <lekktu@gmail.com>
9256
9257 * xml.c (init_libxml2_functions) [WINDOWSNT]:
9258 Remove unused local variable.
9259
e3fb2efb
PE
92602012-04-07 Paul Eggert <eggert@cs.ucla.edu>
9261
9262 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
9263 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
9264 (mark_memory): Mark Lisp_Objects only if pointers might hide in
9265 objects, as mark_maybe_pointer will catch them otherwise.
9266 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
9267 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
9268
b5385551
PE
92692012-04-07 Paul Eggert <eggert@cs.ucla.edu>
9270
9271 Fix typo that broke non-Windows builds.
9272 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
9273
9078ead6
EZ
92742012-04-07 Eli Zaretskii <eliz@gnu.org>
9275
9276 Support building on MS-Windows with libxml2.
9277
9278 * makefile.w32-in (OBJ2): Add xml.$(O).
9279 (GLOBAL_SOURCES): Add xml.c.
9280 ($(BLD)/xml.$(O)): New dependency list.
9281
9282 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
9283 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
9284 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
9285 [!WINDOWSNT]: New macros.
9286 (init_libxml2_functions, libxml2_loaded_p): New functions.
9287 (parse_region): Call fn_xmlCheckVersion instead of using the macro
9288 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
9289 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
9290 Calls xmlCleanupParser only if libxml2 was loaded (or statically
9291 linked in).
6bbef4e5
JC
9292 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
9293 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
9294 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
9295
9296 * emacs.c: Don't include libxml/parser.h.
9297 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
9298 xmlCleanupParser directly.
9299
9300 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
9301
3811fdf3
EZ
93022012-04-07 Eli Zaretskii <eliz@gnu.org>
9303
9304 * indent.c (Fvertical_motion): If there is a display string at
9305 point, use it.vpos to compute how many lines to backtrack after
9306 move_it_to point. (Bug#11133)
9307
2f8e16b2
EZ
93082012-04-06 Eli Zaretskii <eliz@gnu.org>
9309
9310 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
9311 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
9312 about subtle differences between FETCH_CHAR* and STRING_CHAR*
9313 macros related to unification of CJK characters. For the details,
9314 see the discussion following the message here:
9315 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
9316
3d439cd1
CY
93172012-04-04 Chong Yidong <cyd@gnu.org>
9318
9319 * keyboard.c (Vdelayed_warnings_list): Doc fix.
9320
8bc53d00
EZ
93212012-04-01 Eli Zaretskii <eliz@gnu.org>
9322
9323 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
9324 instead of alloca. (Bug#11138)
9325
3b0512a3
AS
93262012-04-01 Andreas Schwab <schwab@linux-m68k.org>
9327
9328 * w32menu.c (is_simple_dialog): Properly check lisp types.
9329 (Bug#11141)
9330
8427ddd2
EZ
93312012-03-31 Eli Zaretskii <eliz@gnu.org>
9332
979022ef
EZ
9333 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
9334 position we get to after a call to move_it_to fails the
9335 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
9336 only if we wind up in a string from display property. (Bug#11063)
9337
a6b1c7cc
EZ
9338 * window.c (Fdelete_other_windows_internal): Invalidate the row
9339 and column information about mouse highlight, so that redisplay
9340 restores it after reallocating the glyph matrices. (Bug#7464)
9341
8427ddd2
EZ
9342 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
9343 string comes from a `display' text property, use the buffer
9344 position of that property as if we actually saw that position in
9345 the row's glyphs.
697ba24b
EZ
9346 (move_it_by_lines): Remove the assertion that
9347 "it->current_x == 0 && it->hpos == 0" which can be legitimately
9348 violated when there's a before-string at the beginning of a line.
9349 (Bug#11063)
8427ddd2 9350
65a0a738
EZ
93512012-03-30 Eli Zaretskii <eliz@gnu.org>
9352
9353 * xdisp.c (append_space_for_newline): If the default face was
9354 remapped, use the remapped face for the appended newline.
9355 (extend_face_to_end_of_line): Use the remapped default face for
9356 extending the face to the end of the line.
9357 (display_line): Call extend_face_to_end_of_line when the default
9358 face was remapped. (Bug#11068)
9359
581355cc
EZ
93602012-03-29 Eli Zaretskii <eliz@gnu.org>
9361
9362 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
9363
e8fc049f
SM
93642012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9365
9366 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
9367
4fb9a543
GM
93682012-03-27 Glenn Morris <rgm@gnu.org>
9369
9370 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
9371 Doc fixes.
9372
679910f1
KH
93732012-03-26 Kenichi Handa <handa@m17n.org>
9374
9375 * dispextern.h (struct glyph): Fix previous change. Change the
9376 bit length of glyphless.ch to 25 (Bug#11082).
9377
90d49b7f
CY
93782012-03-26 Chong Yidong <cyd@gnu.org>
9379
9380 * keyboard.c (Vselection_inhibit_update_commands): New variable.
9381 (command_loop_1): Use it; inhibit selection update for
9382 handle-select-window too (Bug#8996).
9383
f514f6f0
FP
93842012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
9385
e8fc049f 9386 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 9387
bf43fa51
KH
93882012-03-25 Kenichi Handa <handa@m17n.org>
9389
9390 * dispextern.h (struct glyph): Change the bit length of
9391 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
9392
8a0c01dd
EZ
93932012-03-24 Eli Zaretskii <eliz@gnu.org>
9394
9395 * s/ms-w32.h (tzname): Include time.h before redirecting to
9396 _tzname. Fixes the MSVC build. (Bug#9960)
9397
7d1c3a76
AS
93982012-03-24 Andreas Schwab <schwab@linux-m68k.org>
9399
8ed79523
AS
9400 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
9401 characters.
9402
7d1c3a76
AS
9403 * xterm.c (XTread_socket): Only modify handling_signal if
9404 !SYNC_INPUT. (Bug#11080)
9405
e99a9b8b
EZ
94062012-03-23 Eli Zaretskii <eliz@gnu.org>
9407
9408 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
9409 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
9410 when fetching a multibyte character consumes more bytes than
9411 CHAR_BYTES returns, due to unification of CJK characters in
9412 string_char. (Bug#11073)
9413
5063c0e1
TN
94142012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
9415
9416 * process.c (wait_reading_process_output): Handle pty disconnect
9417 by refraining from sending oneself a SIGCHLD (bug#10933).
9418
9f851fbd
CY
94192012-03-22 Chong Yidong <cyd@gnu.org>
9420
9421 * dispextern.h (struct it): New member string_from_prefix_prop_p.
9422
5063c0e1 9423 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
9424 Mark string as coming from a prefix property.
9425 (handle_face_prop): Use default face for prefix strings (Bug#4281).
9426 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
9427
fb5b8aca
CY
94282012-03-21 Chong Yidong <cyd@gnu.org>
9429
9430 * xfaces.c (Vface_remapping_alist): Doc fix.
9431
62356a1b
EZ
94322012-03-20 Eli Zaretskii <eliz@gnu.org>
9433
9434 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
9435 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
9436 Doc fixes.
62356a1b 9437
025de85b
CY
94382012-03-20 Chong Yidong <cyd@gnu.org>
9439
9440 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
9441 to reflect default non-nil value of redisplay-dont-pause.
9442
4827f94e
KH
94432012-03-19 Kenichi Handa <handa@m17n.org>
9444
9445 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
9446 it fit in a valid range (Bug#11003).
9447
e50a24a2
EZ
94482012-03-18 Eli Zaretskii <eliz@gnu.org>
9449
9450 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
9451 that is not from display property, accept the row as a "cursor
9452 row" if one of the string's character has a non-nil `cursor'
9453 property. Fixes cursor positioning when there are newlines in
9454 overlay strings, e.g. in icomplete.el. (Bug#11035)
9455
9af5ed87
PE
94562012-03-12 Paul Eggert <eggert@cs.ucla.edu>
9457
9458 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
9459
d1f55f16
CY
94602012-03-12 Chong Yidong <cyd@gnu.org>
9461
9462 * eval.c (inhibit_lisp_code): Rename from
9463 inhibit_window_configuration_change_hook; move from window.c.
9464
9465 * xfns.c (unwind_create_frame_1, Fx_create_frame):
9466 * window.c (run_window_configuration_change_hook)
9467 (syms_of_window): Callers changed.
9468
66c5eebd
CY
94692012-03-11 Chong Yidong <cyd@gnu.org>
9470
413df973
CY
9471 * keymap.c (Fkey_description): Doc fix (Bug#9700).
9472
66c5eebd
CY
9473 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
9474
1de11f56
CY
94752012-03-10 Chong Yidong <cyd@gnu.org>
9476
9477 * frame.c (other_visible_frames): Don't assume the selected frame
9478 is visible (Bug#10955).
9479
cae07000
SM
94802012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
9481
9482 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
9483
89c94350
JD
94842012-03-08 Jan Djärv <jan.h.d@swipnet.se>
9485
9486 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
9487 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
9488 zero (Bug#10954).
9489
999dd333
GM
94902012-03-03 Glenn Morris <rgm@gnu.org>
9491
01a6dcc8 9492 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 9493
de0100f2
EZ
94942012-03-02 Eli Zaretskii <eliz@gnu.org>
9495
9496 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
9497 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
9498 (redisplay_window, next_element_from_string): Fix typos in
9499 comments.
3e441275
EZ
9500 (redisplay_window): Pass to move_it_vertically the margin in
9501 pixels, not in screen lines.
de0100f2 9502
96a72ee9
GM
95032012-03-02 Glenn Morris <rgm@gnu.org>
9504
9505 * buffer.c (buffer-list-update-hook): Doc fix.
9506
312508d7
EZ
95072012-02-29 Eli Zaretskii <eliz@gnu.org>
9508
9509 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
9510 push_it before setting up the iterator for the first overlay
9511 string, even if we have an empty string loaded.
9512 (next_overlay_string): If there's an empty string on the iterator
9513 stack, pop the stack. (Bug#10903)
9514
27f3c637
PE
95152012-02-25 Paul Eggert <eggert@cs.ucla.edu>
9516
9517 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
9518 Suggested by Stefan Monnier in
9519 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
9520 * alloc.c (widen_to_Lisp_Object): New static function.
9521 (mark_memory): Also mark Lisp_Objects by fetching pointer words
9522 and widening them to Lisp_Objects. This would work even if
9523 USE_LSB_TAG is defined and wide integers are used, which might
9524 happen in a future version of Emacs.
9525
3c9dfce6
CY
95262012-02-25 Chong Yidong <cyd@gnu.org>
9527
fa74b241
CY
9528 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
9529 Doc fix.
9530
3c9dfce6
CY
9531 * xselect.c (Fx_selection_exists_p): Doc fix.
9532 (x_clipboard_manager_save_all): Print an informative message
9533 before saving to clipboard manager.
9534
9486df08
CY
95352012-02-24 Chong Yidong <cyd@gnu.org>
9536
9537 * keyboard.c (process_special_events): Handle all X selection
9538 requests in kbd_buffer, not just the next one (Bug#8869).
9539
f01d3321
CY
95402012-02-23 Chong Yidong <cyd@gnu.org>
9541
9542 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
9543 call when setting menu-bar-lines and tool-bar-lines parameters.
9544 (unwind_create_frame_1): New helper function.
9545
9546 * window.c (inhibit_window_configuration_change_hook): New var.
9547 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 9548 (syms_of_window): Initialize it.
f01d3321 9549
86b847b6
CY
95502012-02-22 Chong Yidong <cyd@gnu.org>
9551
9552 * xterm.c (x_draw_image_relief): Add missing type check for
9553 Vtool_bar_button_margin (Bug#10743).
9554
a59225b1
CY
95552012-02-21 Chong Yidong <cyd@gnu.org>
9556
9557 * fileio.c (Vfile_name_handler_alist): Doc fix.
9558
9559 * buffer.c (Fget_file_buffer): Protect against invalid file
9560 handler return value.
9561
310f5bd4
PE
95622012-02-20 Paul Eggert <eggert@cs.ucla.edu>
9563
cb3a28cc
PE
9564 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
9565 when computing $valmask.
9566
310f5bd4
PE
9567 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
9568 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
9569 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
9570 It's useless in that case, and it can cause problems on hosts
9571 that allocate halves of EMACS_INT values separately.
9572 Reported by Dan Horák. Diagnosed by Andreas Schwab in
9573 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
9574 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
9575 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
9576 it avoids undefined behavior on hosts where shifting right by more
9577 than the word width has undefined behavior.
9578
2375c96a
CY
95792012-02-19 Chong Yidong <cyd@gnu.org>
9580
9581 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
9582 (Funhandled_file_name_directory, Ffile_name_as_directory)
9583 (Fdirectory_file_name, Fexpand_file_name)
9584 (Fsubstitute_in_file_name): Protect against invalid file handler
9585 return values (Bug#10845).
9586
3eb49e71
EZ
95872012-02-18 Eli Zaretskii <eliz@gnu.org>
9588
9589 * .gdbinit (pitx): Fix incorrect references to fields of the
9590 iterator stack.
9591
7b926f3f
CY
95922012-02-17 Chong Yidong <cyd@gnu.org>
9593
9594 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
9595
11273115
PE
95962012-02-15 Paul Eggert <eggert@cs.ucla.edu>
9597
9598 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
9599 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
9600
c3a70e2b
CY
96012012-02-15 Chong Yidong <cyd@gnu.org>
9602
9603 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
9604 marked as special. Also, starting docstrings with * is obsolete.
9605
0ca43699
AS
96062012-02-13 Andreas Schwab <schwab@linux-m68k.org>
9607
9608 * gnutls.c (emacs_gnutls_write): Fix last change.
9609
2e8f3c56
LI
96102012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
9611
9612 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
9613 send_process.
9614
af70074f
SM
96152012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
9616
9617 * keymap.c (Fsingle_key_description): Handle char ranges.
9618
95986d52
CY
96192012-02-12 Chong Yidong <cyd@gnu.org>
9620
afd83bd1
CY
9621 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
9622 as that creates a dangerous corner case.
9623
95986d52
CY
9624 * window.c (Fdelete_window_internal): Invalidate the mouse
9625 highlight (Bug#9904).
9626
bd7da63e
GM
96272012-02-12 Glenn Morris <rgm@gnu.org>
9628
9629 * xselect.c (Fx_own_selection_internal)
9630 (Fx_get_selection_internal, Fx_disown_selection_internal)
9631 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
9632 * nsselect.m (Fx_own_selection_internal)
9633 (Fx_disown_selection_internal, Fx_selection_exists_p)
9634 (Fx_selection_owner_p, Fx_get_selection_internal):
9635 Sync docs and argument specs with the xselect.c versions.
9636
77abcbc2
LI
96372012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
9638
9639 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
9640
90b671e2
EZ
96412012-02-11 Eli Zaretskii <eliz@gnu.org>
9642
1c0ca0b7
EZ
9643 * w32select.c (Fx_selection_exists_p): Sync doc string and
9644 argument list with xselect.c. (Bug#10783)
9645
9646 * w16select.c (Fx_selection_exists_p): Sync doc string and
9647 argument list with xselect.c. (Bug#10783)
90b671e2 9648
49241268
GM
96492012-02-10 Glenn Morris <rgm@gnu.org>
9650
9651 * fns.c (Fsecure_hash): Doc fix.
9652
f998bbe7 96532012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
9654
9655 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
9656
0992bd9c
CY
96572012-02-07 Chong Yidong <cyd@gnu.org>
9658
9659 * buffer.c (Fbuffer_local_variables)
9660 (buffer_lisp_local_variables): Handle unbound vars correctly;
9661 don't let Qunbound leak into Lisp.
9662
af008560
GM
96632012-02-07 Glenn Morris <rgm@gnu.org>
9664
dd605cc4
GM
9665 * image.c (Fimagemagick_types): Doc fix.
9666
af008560
GM
9667 * image.c (imagemagick-render-type): Change it from a lisp object
9668 to an integer. Move the doc here from the lisp manual.
9669 Treat all values not equal to 0 the same.
9670
1449fa1d
CY
96712012-02-06 Chong Yidong <cyd@gnu.org>
9672
9673 * doc.c (store_function_docstring): Avoid applying docstring of
9674 alias to base function (Bug#2603).
9675
3723ec07
AS
96762012-02-04 Andreas Schwab <schwab@linux-m68k.org>
9677
9678 * .gdbinit (pp1, pv1): Remove redundant defines.
9679 (pr): Use pp.
9680
79c1cc1e
CY
96812012-02-04 Chong Yidong <cyd@gnu.org>
9682
9683 * nsterm.m: Declare a global (Bug#10694).
9684
d7f29f8e
EZ
96852012-02-04 Eli Zaretskii <eliz@gnu.org>
9686
cae07000
SM
9687 * w32.c (get_emacs_configuration_options):
9688 Include --enable-checking, if specified, in the return value.
d7f29f8e 9689
3b95a6f9
MR
96902012-02-04 Martin Rudalics <rudalics@gmx.at>
9691
9692 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
9693 after rounding frame sizes. (Bug#9723)
9694
d6fa96a6
EZ
96952012-02-04 Eli Zaretskii <eliz@gnu.org>
9696
9697 * keyboard.c (adjust_point_for_property): Don't position point
9698 before BEGV. (Bug#10696)
9699
df0b2940
PE
97002012-02-03 Paul Eggert <eggert@cs.ucla.edu>
9701
9702 Handle overflow when computing char display width (Bug#9496).
9703 * character.c (char_width): Return EMACS_INT, not int.
9704 (char_width, c_string_width): Check for overflow when
9705 computing the width; this is possible now that individual
9706 characters can have unbounded width. Problem introduced
9707 by merge from Emacs 23 on 2012-01-19.
9708
6bee44d6
MA
97092012-02-02 Michael Albinus <michael.albinus@gmx.de>
9710
9711 * dbusbind.c (Fdbus_register_method): Mention the return value
9712 :ignore in the docstring.
9713
44f92739
GM
97142012-02-02 Glenn Morris <rgm@gnu.org>
9715
1b9f60cc
GM
9716 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
9717
44f92739
GM
9718 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9719 Unconditionally set to t. (Bug#10673)
9720 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9721 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
9722 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
9723
c5d3843c
KH
97242012-02-02 Kenichi Handa <handa@m17n.org>
9725
9726 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
9727 0, do not call append_composite_glyph.
9728
159462d4 97292012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
9730
9731 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
9732 NULL (Bug#6988).
9733 (x_produce_glyphs): If the component of a composition is a null
9734 string, set it->pixel_width to 1 to avoid zero-width glyph.
9735
78cef877
EZ
97362012-02-01 Eli Zaretskii <eliz@gnu.org>
9737
9738 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
9739 first 2 arguments are identical. This makes inserting large
9740 output from a subprocess an order of magnitude faster on
9741 MS-Windows, where all sbrk'ed memory is always contiguous.
9742
97897668
GM
97432012-01-31 Glenn Morris <rgm@gnu.org>
9744
9745 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 9746 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
9747 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
9748
31fd3586
GM
97492012-01-29 Glenn Morris <rgm@gnu.org>
9750
9751 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
9752
0e24a8b2
CY
97532012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
9754
9755 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
9756
cc0adcb0
CY
97572012-01-28 Chong Yidong <cyd@gnu.org>
9758
9759 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
9760
acc28cb9
CY
97612012-01-26 Chong Yidong <cyd@gnu.org>
9762
9c69cfb7
CY
9763 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
9764
acc28cb9
CY
9765 * search.c (Fsearch_forward, Fsearch_backward): Document negative
9766 repeat counts (Bug#10507).
9767
48da7392
GM
97682012-01-26 Glenn Morris <rgm@gnu.org>
9769
9770 * lread.c (syms_of_lread): Doc fix.
9771
14af5f7f
CY
97722012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
9773
9774 * coding.c (encode_designation_at_bol): Change return value to
9775 EMACS_INT.
9776
0b21c100
CY
97772012-01-25 Chong Yidong <cyd@gnu.org>
9778
9779 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
9780
3c2907f7
CY
97812012-01-21 Chong Yidong <cyd@gnu.org>
9782
9783 * floatfns.c (Fcopysign): Make the second argument non-optional,
9784 since nil is not allowed anyway.
9785
959ad23f
AS
97862012-01-21 Andreas Schwab <schwab@linux-m68k.org>
9787
9788 * process.c (read_process_output): Use p instead of XPROCESS (proc).
9789 (send_process): Likewise.
9790
34a02f46
MR
97912012-01-19 Martin Rudalics <rudalics@gmx.at>
9792
9793 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
9794 (Vwindow_persistent_parameters): Do not use Qstate.
9795 Rewrite doc-strings.
34a02f46 9796
1259009a 97972012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
9798
9799 * character.c (char_width): New function.
70d4fdf6
GM
9800 (Fchar_width, c_string_width, lisp_string_width):
9801 Use char_width (Bug#9496).
25ed9e61 9802
6a6ee00d
MR
98032012-01-16 Martin Rudalics <rudalics@gmx.at>
9804
9805 * window.c (Vwindow_persistent_parameters): New variable.
9806 (Fset_window_configuration, save_window_save): Handle persistent
9807 window parameters.
9808
c85efaf7
EZ
98092012-01-14 Eli Zaretskii <eliz@gnu.org>
9810
9811 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
9812 thrashing the stack of the thread. (Bug#9087)
9813
5944709e
PE
98142012-01-12 Paul Eggert <eggert@cs.ucla.edu>
9815
9816 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
9817
e71f5d99
EZ
98182012-01-11 Eli Zaretskii <eliz@gnu.org>
9819
9820 * xdisp.c (rows_from_pos_range): Handle the case where the
9821 highlight ends on a newline. (Bug#10464)
9822 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
9823 he end column for display of highlight that ends on a newline
9824 before a R2L line.
9825
ce316182
GM
98262012-01-11 Glenn Morris <rgm@gnu.org>
9827
9828 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
9829 from load-path also when installation-directory is nil. (Bug#10208)
9830
5b43da69
GM
98312012-01-10 Glenn Morris <rgm@gnu.org>
9832
74cc8ff9
GM
9833 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
9834
7d8d6e4e
GM
9835 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
9836 Update template values to be closer to their typical values these days.
5b43da69 9837
a0db8d43
EZ
98382012-01-09 Eli Zaretskii <eliz@gnu.org>
9839
9840 * xdisp.c (rows_from_pos_range): Accept additional argument
9841 DISP_STRING, and accept any glyph in a row whose object is that
9842 string as eligible for mouse highlight. Fixes mouse highlight of
9843 display strings from overlays. (Bug#10464)
9844
9a0115ab 98452012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 9846
b9110d6a 9847 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
9848 * fileio.c (auto_saving_dir_umask): New static var.
9849 (Fmake_directory_internal): Use it.
9850 (do_auto_save_make_dir): Set it, instead of invoking chmod after
9851 creating the directory. The old code temporarily assigns
9852 too-generous permissions to the directory.
9853 (do_auto_save_eh): Clear it.
b9110d6a 9854 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
9855 that the var is always cleared.
9856
6c1bd3f3
EZ
98572012-01-07 Eli Zaretskii <eliz@gnu.org>
9858
9859 * search.c (scan_buffer): Pass character positions to
9860 know_region_cache, not byte positions. (Bug#6540)
9861
069d2b50
L
98622012-01-07 LynX <_LynX@bk.ru> (tiny change)
9863
9864 * w32.c (sys_rename): Report EXDEV when rename of a directory
9865 fails because the target is on another logical disk. (Bug#10284)
9866
75bf0d33
DB
98672012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
9868
9869 * xterm.c (x_embed_request_focus): New function.
9870
9871 * xterm.h: Add prototype.
9872
9873 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
9874
1c6e5a32
GM
98752012-01-05 Glenn Morris <rgm@gnu.org>
9876
9877 * emacs.c (emacs_copyright): Update short copyright year to 2012.
9878
651e947e
EZ
98792012-01-01 Eli Zaretskii <eliz@gnu.org>
9880
9881 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
9882 Load gnutls_transport_set_lowat only if GnuTLS version is below
9883 2.11.1.
9884 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
9885 GnuTLS versions below 2.11.1.
9886
3778cdd8
AL
98872011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
9888
9889 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
9890 to the doc string advising against its use for altering the way
9891 windows are scrolled.
9892
0e5317f7
KH
98932011-12-28 Kenichi Handa <handa@m17n.org>
9894
9895 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
9896 coding-system ASCII compatible only when it does not produce BOM
9897 on encoding (Bug#10383).
9898
93d5ca1f
JD
98992011-12-26 Jan Djärv <jan.h.d@swipnet.se>
9900
9901 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
9902 can scroll.
9903 (create_and_show_popup_menu): Always use menu_position_func for
9904 Gtk3 (Bug#10361).
9905
ca22b785
AS
99062011-12-24 Andreas Schwab <schwab@linux-m68k.org>
9907
9908 * callint.c (Fcall_interactively): Don't truncate prompt string.
9909
d048e1e6
EZ
99102011-12-23 Eli Zaretskii <eliz@gnu.org>
9911
9912 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
9913 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 9914 resumed from there (after widening). (Bug#10360)
d048e1e6 9915
5ccaba1f
JD
99162011-12-22 Jan Djärv <jan.h.d@swipnet.se>
9917
9918 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
9919
204ee57f
JD
99202011-12-21 Jan Djärv <jan.h.d@swipnet.se>
9921
b81d40f0
JB
9922 * nsterm.m (x_free_frame_resources):
9923 Release f->output_data.ns->miniimage.
204ee57f
JD
9924 (ns_index_color): Fix indentation. Do not retain
9925 color_table->colors[i].
9926
9927 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
9928 before returning.
9929
9930 * nsfns.m (x_set_background_color): Assign return value from
9931 ns_index_color to face-background instead of NSColor*.
9932 (ns_implicitly_set_icon_type): Fix indentation.
9933 Change assignment in for loop to comparison.
9934
9935 * emacs.c (ns_pool): New variable.
9936 (main): Assign ns_pool.
9937 (Fkill_emacs): Call ns_release_autorelease_pool.
9938
9939 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
9940 autorelease fdesc, release fdAttrs and tdict.
9941 (ns_get_covering_families): Release charset.
9942 (ns_findfonts): Release NSFontDescriptor created with new.
9943 (ns_uni_to_glyphs): Fix indentation.
9944 (setString): Release attrStr before assigning new value.
9945
c803b2b7
JD
99462011-12-18 Jan Djärv <jan.h.d@swipnet.se>
9947
678f4426
JD
9948 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
9949 and NS_IMPL_COCOA.
9950 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
9951 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
9952
cd394be1 99532011-12-18 David Reitter <reitter@cmu.edu>
678f4426 9954
5fecd5fc
JD
9955 * nsterm.m (ns_term_init): Subscribe for notifications
9956 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9957 to method trackingNotification in EmacsMenu.
9958
9959 * nsmenu.m (trackingMenu): New variable.
3771cb17 9960 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9961 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9962 from Aquamacs (Bug#7030).
678f4426
JD
9963
99642011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9965
c803b2b7
JD
9966 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9967 (symbol_to_nsstring): Fix indentation.
9968 (ns_symbol_to_pb): New function.
cae07000
SM
9969 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9970 (Fns_rotate_cut_buffers_internal): Remove.
9971 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9972 Fns_store_cut_buffer_internal.
9973 (ns_get_foreign_selection, Fx_own_selection_internal)
9974 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9975 (Fns_get_selection_internal, Fns_store_selection_internal):
9976 Use ns_symbol_to_pb and check if return value is nil.
9977 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9978 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9979 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9980 renamed to Sns_store_selection_internal.
9981 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9982 and remove this function.
9983 (ns_handle_selection_clear): Remove, never used.
9984 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9985 here.
9986
e1b01a3a
KB
99872011-12-17 Ken Brown <kbrown@cornell.edu>
9988
9989 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9990 GID is unknown (Bug#10257).
9991
2adb6e85
PE
99922011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9993
9994 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9995 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9996 which caused a build failure on GNU/Linux IA-64. This problem was
9997 introduced by my 2011-10-07 patch.
9998
d1d7b339
JL
99992011-12-15 Juri Linkov <juri@jurta.org>
10000
10001 * image.c (imagemagick_error): New function. (Bug#10112)
10002 (imagemagick_load_image): Comment out `MagickSetResolution' call.
10003 Use `imagemagick_error' where ImageMagick functions return
10004 `MagickFalse'.
10005 (Fimagemagick_types): Add `Fnreverse' to return the list in the
10006 proper order.
10007
100d5755
KH
100082011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10009
10010 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
10011 fill background (Bug#8992).
10012
454592a6
MR
100132011-12-13 Martin Rudalics <rudalics@gmx.at>
10014
10015 * window.c (Vwindow_combination_resize)
10016 (Vwindow_combination_limit): Use t instead of non-nil in
10017 doc-strings.
61d4b438
MR
10018 (Vrecenter_redisplay): Add first sentence of doc-string on
10019 separate line.
53524d93 10020 (Frecenter): Fix doc-string typo.
454592a6 10021
3633e3aa
KH
100222011-12-11 Kenichi Handa <handa@m17n.org>
10023
10024 * coding.c (Funencodable_char_position): Pay attention to the
10025 buffer text relocation (Bug#9389).
10026
7b9d523a 100272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 10028
7b9d523a
JD
10029 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
10030 gtk_init (Bug#10100).
10031
b73189c6
EZ
100322011-12-10 Eli Zaretskii <eliz@gnu.org>
10033
10034 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
10035 IT->string is nil. (Bug#10263)
10036
f7dfe5d6
JD
100372011-12-10 Jan Djärv <jan.h.d@swipnet.se>
10038
83faebb4
JD
10039 * nsterm.h (x_free_frame_resources): Declare.
10040
f7dfe5d6
JD
10041 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
10042 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
10043
10044 * nsterm.h (ns_get_defaults_value): Declare.
10045
10046 * nsterm.m (ns_default): Call ns_get_defaults_value.
10047
7cd4e72c
EZ
100482011-12-09 Eli Zaretskii <eliz@gnu.org>
10049
10050 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
10051 (Bug#10170)
10052
b34d7317
YM
100532011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10054
10055 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
10056 that where the value of an _OBJC_* symbol points to is in the .bss
10057 section (Bug#10240).
10058
76470ad1
KH
100592011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
10060
10061 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 10062 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 10063
745fff94
KH
100642011-12-08 Kenichi Handa <handa@m17n.org>
10065
10066 * ftfont.c (get_adstyle_property): Fix previous change
10067 (Bug#10233).
10068
6e44397c
JB
100692011-12-07 Juanma Barranquero <lekktu@gmail.com>
10070
10071 * w32.c (init_environment): If no_site_lisp, remove site-lisp
10072 dirs from the default value of EMACSLOADPATH (bug#10208).
10073
7efa6272
GM
100742011-12-07 Glenn Morris <rgm@gnu.org>
10075
10076 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
10077 installation and source directories as well. (Bug#10208)
10078
f6fc4d87
CY
100792011-12-06 Chong Yidong <cyd@gnu.org>
10080
10081 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
10082
2bf26180
GM
100832011-12-06 Glenn Morris <rgm@gnu.org>
10084
10085 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
10086 as an error, not just -1. (Bug#10217)
10087
3a6ad4f0
CY
100882011-12-05 Chong Yidong <cyd@gnu.org>
10089
10090 * keyboard.c (process_special_events): New function.
10091 (swallow_events, Finput_pending_p): Use it (Bug#10195).
10092
75a3b399
PE
100932011-12-05 Paul Eggert <eggert@cs.ucla.edu>
10094
10095 * coding.c (encode_designation_at_bol): Don't use uninitialized
10096 local variable (Bug#9318).
10097
c3c9e25e
KH
100982011-12-05 Kenichi Handa <handa@m17n.org>
10099
10100 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
10101 return Qnil (Bug#8046, Bug#10193).
10102
5eb05ea3
KH
101032011-12-05 Kenichi Handa <handa@m17n.org>
10104
10105 * coding.c (encode_designation_at_bol): New args charbuf_end and
10106 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
10107 (coding_set_source): Return how many bytes coding->source was
10108 relocated.
10109 (coding_set_destination): Return how many bytes
10110 coding->destination was relocated.
10111 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 10112 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
10113
101142011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
10115
10116 * coding.c (CODING_CHAR_CHARSET_P): New macro.
10117 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
10118 macro (Bug#9318).
10119
101202011-12-05 Andreas Schwab <schwab@linux-m68k.org>
10121
10122 The following changes are to fix Bug#9318.
10123
a79703f5 10124 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
10125 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
10126 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 10127 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 10128
7dbda6df
JB
101292011-12-05 Juanma Barranquero <lekktu@gmail.com>
10130
10131 * lisp.h (process_quit_flag): Fix external declaration.
10132
6d5eb5b0
SM
101332011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
10134
10135 Don't macro-inline non-performance-critical code.
10136 * eval.c (process_quit_flag): New function.
10137 * lisp.h (QUIT): Use it.
10138
a0c3fad0
JD
101392011-12-04 Jan Djärv <jan.h.d@swipnet.se>
10140
10141 * nsfns.m (get_geometry_from_preferences): New function.
10142 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
10143
6c07aac2
AS
101442011-12-04 Andreas Schwab <schwab@linux-m68k.org>
10145
10146 * emacs.c (Qkill_emacs): Define.
10147 (syms_of_emacs): Initialize it.
10148 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
10149 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
10150 (quit_throw_to_read_char): Add parameter `from_signal'.
10151 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
10152 * lisp.h (QUIT): Call Fkill_emacs if requested.
10153
c052ead4
JD
101542011-12-03 Jan Djärv <jan.h.d@swipnet.se>
10155
10156 * widget.c (update_wm_hints): Return if wmshell is null.
10157 (widget_update_wm_size_hints): New function.
10158
10159 * widget.h (widget_update_wm_size_hints): Declare.
10160
10161 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
10162 widget_update_wm_size_hints (Bug#10104).
10163
9e49252b
EZ
101642011-12-03 Eli Zaretskii <eliz@gnu.org>
10165
10166 * xdisp.c (handle_invisible_prop): If the invisible text ends just
10167 before a newline, prepare the bidi iterator for consuming the
10168 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 10169 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 10170
02b16839
JL
101712011-12-02 Juri Linkov <juri@jurta.org>
10172
10173 * search.c (Fword_search_regexp): New Lisp function created from
10174 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
10175 (Fword_search_backward, Fword_search_forward)
10176 (Fword_search_backward_lax, Fword_search_forward_lax):
10177 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
10178 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
10179
0068070e
SM
101802011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
10181
10182 * fileio.c (Finsert_file_contents): Move after-change-function call
10183 to before the "handled:" label, since all "goto handled" appear in
10184 cases where the *-change-functions have already been properly called
10185 (bug#10117).
10186
3360a3fc
AS
101872011-12-01 Andreas Schwab <schwab@linux-m68k.org>
10188
10189 * keyboard.c (interrupt_signal): Don't call kill-emacs when
10190 waiting for input. (Bug#10169)
10191
73d6c093
EZ
101922011-11-30 Eli Zaretskii <eliz@gnu.org>
10193
10194 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
10195 verifies glyph row's hash code--we have just reallocated the
10196 glyphs, so their contents can be complete garbage. (Bug#10164)
10197
febe6bea
JB
101982011-11-30 Juanma Barranquero <lekktu@gmail.com>
10199
10200 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
10201
801a4313
EZ
102022011-11-30 Eli Zaretskii <eliz@gnu.org>
10203
10204 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
10205 attributes are tested _before_ calling verify_row_hash, to protect
10206 against GCC re-ordering of the tests. (Bug#10164)
10207
2b56b87e
JD
102082011-11-29 Jan Djärv <jan.h.d@swipnet.se>
10209
10210 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
10211
10212 * xterm.c (handle_one_xevent): Only set async_visible and friends
10213 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 10214 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
10215 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
10216
dbf31225
PE
102172011-11-28 Paul Eggert <eggert@cs.ucla.edu>
10218
10219 Remove GCPRO-related macros that exist only to avoid shadowing locals.
10220 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
10221 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
10222 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
10223 All uses changed to use GCPRO1 etc.
10224 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
10225 Revert to old implementation (i.e., before 2011-03-11).
10226
1305621b
YM
102272011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10228
10229 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
10230 of scroll runs so as to avoid assigning disabled bogus rows and
10231 unnecessary graphics copy operations.
10232
8c9afb46
EZ
102332011-11-27 Eli Zaretskii <eliz@gnu.org>
10234
10235 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
10236 (snprintf) [_MSC_VER]: Redirect to _snprintf.
10237 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
10238 (malloc, free, realloc, calloc): Redirect to e_* only when
10239 compiling Emacs.
10240
10241 * lisp.h (GCTYPEBITS): Move before first use.
10242 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
10243 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
10244 this macro definition.
10245
10246 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
10247 _MSC_VER.
10248
54e9e3bf
JD
102492011-11-27 Jan Djärv <jan.h.d@swipnet.se>
10250
6d5eb5b0
SM
10251 * gtkutil.c (xg_create_frame_widgets):
10252 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
10253 present with Gtk+ 2.0.
10254
83aca1cb
PE
102552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
10256
10257 * fileio.c (Finsert_file_contents): Undo previous change; see
10258 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
10259
5b76caa4
PE
102602011-11-26 Paul Eggert <eggert@cs.ucla.edu>
10261
10262 Rename locals to avoid shadowing.
10263 * fileio.c (Finsert_file_contents):
10264 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
10265 * process.c (wait_reading_process_output):
10266 Rename inner 'proc' to 'p' to avoid shadowing.
10267 Indent for consistency with usual Emacs style.
10268
8c535114
EZ
102692011-11-25 Eli Zaretskii <eliz@gnu.org>
10270
10271 * xdisp.c (redisplay_window): If cursor row is not fully visible
10272 after recentering, and scroll-conservatively is set to a large
10273 number, scroll window by a few more lines to make the cursor fully
10274 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
10275 (start_display): Don't move to the next line if the display should
10276 start at a newline that is part of a display vector or an overlay
10277 string. (Bug#10119)
8c535114 10278
fa4fdb5c
JL
102792011-11-24 Juri Linkov <juri@jurta.org>
10280
10281 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
10282 after the `MagickPingImage' call. (Bug#10112)
10283
90ec88df
CY
102842011-11-23 Chong Yidong <cyd@gnu.org>
10285
10286 * window.c (Fcoordinates_in_window_p): Accept only live windows.
10287
56e2e794
MR
102882011-11-23 Martin Rudalics <rudalics@gmx.at>
10289
10290 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
10291 making another buffer current. (Bug#10114)
10292
b6e64c41
GM
102932011-11-23 Glenn Morris <rgm@gnu.org>
10294
10295 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
10296
6b21de18
CY
102972011-11-23 Chong Yidong <cyd@gnu.org>
10298
10299 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
10300 using it (Bug#5984).
10301
b12cd789
EZ
103022011-11-22 Eli Zaretskii <eliz@gnu.org>
10303
10304 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
10305 and header-lines, as they don't have one computed for them.
10306 (Bug#10098)
10307
10308 * .gdbinit (prow): Make displayed values more self-explaining.
10309 Add row's hash code.
10310
261b6fd4
LMI
103112011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
10312
10313 * process.c (wait_reading_process_output): Fix asynchrounous
10314 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 10315 (wait_reading_process_output): Add comment and URL.
261b6fd4 10316
e7cfd277
JD
103172011-11-21 Jan Djärv <jan.h.d@swipnet.se>
10318
10319 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
10320
a9b9b7f5
CY
103212011-11-21 Chong Yidong <cyd@gnu.org>
10322
10323 * window.c (Fnext_window, Fprevious_window): Doc fix.
10324
b0d15b4f
SM
103252011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
10326
10327 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
10328
fe7a3057
JB
103292011-11-20 Juanma Barranquero <lekktu@gmail.com>
10330
10331 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
10332
d2999b1a
MR
103332011-11-20 Martin Rudalics <rudalics@gmx.at>
10334
10335 * window.c (Fset_window_combination_limit): Rename argument
10336 STATUS to LIMIT.
10337 (Vwindow_combination_limit): Remove "status" from doc-string.
10338
d5ff9cd0
AS
103392011-11-20 Andreas Schwab <schwab@linux-m68k.org>
10340
10341 * m/ibms390.h: Remove.
10342 * m/ibms390x.h: Don't include "ibms390.h".
10343
a5bb9bd3
SM
103442011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
10345
10346 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
10347 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
10348
cd1181db
JB
103492011-11-20 Juanma Barranquero <lekktu@gmail.com>
10350
10351 * casetab.c (Fset_case_table):
10352 * charset.c (Fcharset_after): Fix typos.
10353
615a3b8d 103542011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 10355
17e845af
PE
10356 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
10357 Otherwise, valgrind does not work on some platforms.
10358 Problem reported by Andreas Schwab in
6a0bf43d
PE
10359 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
10360 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
10361 is set, removing the need for VIRT_ADDRESS_VARIES.
10362 (PURE_P): Use a more-efficient implementation that needs just one
10363 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
10364 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
10365 to 4 (xorl, subq, cmpq, setbe).
10366 * alloc.c (pure): Always extern now, since that's the
10367 VIRT_ADDR_VARIES behavior.
10368 (PURE_POINTER_P): Use a single comparison, not two, for
10369 consistency with the new puresize.h.
10370 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
10371 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
10372 Remove VIRT_ADDR_VARIES no longer needed.
10373
f8fe6f96
EZ
103742011-11-19 Eli Zaretskii <eliz@gnu.org>
10375
10376 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
10377 (erase_phys_cursor, update_window_cursor, show_mouse_face)
10378 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
10379 behave as if the cursor position were at the window margin.
10380
10381 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
10382 and the cursor position is out of bounds, behave as if the cursor
10383 position were at the window margin. (Bug#10075)
10384
df05a53c
CY
103852011-11-18 Chong Yidong <cyd@gnu.org>
10386
10387 * window.c (Fwindow_combination_limit): Make first argument
10388 non-optional, since it is meaningless for live windows like the
10389 selected window.
61ccba97 10390
2071918e
DA
103912011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
10392
10393 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
10394
b50a28de
SM
103952011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
10396
10397 * intervals.c: Fix grafting over the whole buffer (bug#10071).
10398 (graft_intervals_into_buffer): Simplify.
10399
015137db
EZ
104002011-11-18 Eli Zaretskii <eliz@gnu.org>
10401
10402 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
10403 hash values of the two rows.
10404 (copy_row_except_pointers): Preserve the used[] arrays and the
10405 hash values of the two rows. (Bug#10035)
68c95424 10406 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
10407
10408 * xdisp.c (row_hash): New function, body extracted from
10409 compute_line_metrics.
10410 (compute_line_metrics): Call row_hash, instead of computing the
10411 hash code inline.
10412
10413 * dispnew.c (verify_row_hash): Call row_hash for computing the
10414 hash code of a row, instead of duplicating code from xdisp.c.
10415
10416 * dispextern.h (row_hash): Add prototype.
10417
a2addb04
TH
104182011-11-18 Tassilo Horn <tassilo@member.fsf.org>
10419
10420 * frame.c (delete_frame): Don't delete the terminal when the last
10421 X frame is closed if emacs is built with GTK toolkit.
10422
df85d315
JB
104232011-11-17 Juanma Barranquero <lekktu@gmail.com>
10424
10425 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
10426
a0c2d0ae
MR
104272011-11-17 Martin Rudalics <rudalics@gmx.at>
10428
10429 * window.c (Vwindow_splits): Rename to
10430 Vwindow_combination_resize. Suggested by Juri Linkov.
10431 (Fsplit_window_internal): Use Vwindow_combination_resize instead
10432 of Vwindow_splits.
10433
58179cce
JB
104342011-11-16 Juanma Barranquero <lekktu@gmail.com>
10435
7877f373
JB
10436 * nsfns.m (Fns_font_name):
10437 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 10438
b6f67890
MR
104392011-11-16 Martin Rudalics <rudalics@gmx.at>
10440
10441 * window.h (window): Rename slot "nest" to "combination_limit".
10442 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
10443 (Fset_window_nest): Rename to Fset_window_combination_limit.
10444 (Vwindow_nest): Rename to Vwindow_combination_limit.
10445 (recombine_windows, make_parent_window, make_window)
10446 (Fsplit_window_internal, saved_window)
10447 (Fset_window_configuration, save_window_save): Rename all
10448 occurrences of window_nest to window_combination_limit.
10449
c7015153
JB
104502011-11-15 Juanma Barranquero <lekktu@gmail.com>
10451
10452 * image.c (imagemagick_load_image): Fix typo.
10453
322ad6ec
EZ
104542011-11-14 Eli Zaretskii <eliz@gnu.org>
10455
10456 * xdisp.c (display_line): Move the call to
10457 highlight_trailing_whitespace before the call to
10458 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
10459 faces of all the glyphs to compute ROW's hash value.
10460 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 10461
f067b8ec
JB
104622011-11-14 Juanma Barranquero <lekktu@gmail.com>
10463
10464 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
10465 just return (bug#10044).
10466
1e5b2111
EZ
104672011-11-12 Eli Zaretskii <eliz@gnu.org>
10468
7ef3cbd5
EZ
10469 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
10470 with user-defined heap size. Bump the default size of the temacs
10471 heap to 27MB, to avoid memory warning when running temacs.
10472 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
10473
1e5b2111
EZ
10474 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
10475 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
10476 (verify_row_hash) [XASSERTS]: New function.
10477 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
10478 that the hash value of glyph rows is correct.
1e5b2111 10479
89d61221
MR
104802011-11-12 Martin Rudalics <rudalics@gmx.at>
10481
10482 * window.h (window): Remove splits slot.
10483 * window.c (Fwindow_splits, Fset_window_splits): Remove.
10484 (Fdelete_other_windows_internal, make_parent_window)
10485 (make_window, Fsplit_window_internal, Fdelete_window_internal)
10486 (Fset_window_configuration, save_window_save): Don't deal with
10487 split status of windows.
10488 (saved_window): Remove splits slot.
10489 (Vwindow_splits): Rewrite doc-string.
10490
97f18cc8
JD
104912011-11-11 Jan Djärv <jan.h.d@swipnet.se>
10492
10493 * xfns.c (unwind_create_frame):
10494 * nsfns.m (unwind_create_frame):
10495 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
10496 Vframe_list (Bug#9999).
10497
22a648b4
DA
104982011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
10499
0b381c7e 10500 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 10501
659afede
KH
105022011-11-11 Kenichi Handa <handa@m17n.org>
10503
10504 * callproc.c (Fcall_process): Set the member dst_multibyte of
10505 process_coding.
10506
9ac0394b
KH
105072011-11-11 Johan Bockgård <bojohan@gnu.org>
10508
10509 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
10510 avoid a crash (bug#9496).
10511
2fbdc249
CY
105122011-11-09 Chong Yidong <cyd@gnu.org>
10513
10514 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
10515 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
10516
ac6b1f81
PE
105172011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10518
10519 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
10520
09db192c
PE
105212011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10522
10523 Avoid some portability problems by eschewing 'extern inline' functions.
10524 The trivial performance wins aren't worth the portability hassles; see
10525 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
10526 et seq.
10527 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10528 (window_box_width, window_box_left, window_box_left_offset)
10529 (window_box_right, window_box_right_offset): Undo previous change,
10530 by removing the "extern"s.
10531 * intervals.c (adjust_intervals_for_insertion)
10532 (adjust_intervals_for_deletion): Undo previous change,
10533 making these static again.
10534 (offset_intervals, temp_set_point_both, temp_set_point)
10535 (copy_intervals_to_string): No longer inline.
10536 * xdisp.c (window_text_bottom_y, window_box_width)
10537 (window_box_height, window_box_left_offset)
10538 (window_box_right_offset, window_box_left, window_box_right)
10539 (window_box): No longer inline.
10540
105216ed
CY
105412011-11-08 Chong Yidong <cyd@gnu.org>
10542
10543 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
10544 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
10545 Signal an error if not a live window.
105216ed
CY
10546 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
10547 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
10548
ae9e237f
JB
105492011-11-07 Juanma Barranquero <lekktu@gmail.com>
10550
10551 * lisp.h (syms_of_abbrev): Remove declaration.
10552 Reported by CHENG Gao <chenggao@royau.me>.
10553
c7aa8333
EZ
105542011-11-07 Eli Zaretskii <eliz@gnu.org>
10555
10556 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
10557 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
10558 of temacs in GUI mode.
10559
be7f5545
MR
105602011-11-07 Martin Rudalics <rudalics@gmx.at>
10561
10562 * window.h: Declare delete_all_child_windows instead of
10563 delete_all_subwindows.
10564 * window.c (Fwindow_nest, Fset_window_nest)
10565 (Fset_window_new_total, Fset_window_new_normal)
10566 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
10567 (delete_all_subwindows): Rename to delete_all_child_windows.
10568 (Fdelete_other_windows_internal, Fset_window_configuration):
10569 Call delete_all_child_windows instead of delete_all_subwindows.
10570 * frame.c (delete_frame): Call delete_all_child_windows instead
10571 of delete_all_subwindows.
10572
ca78dc43
PE
105732011-11-07 Paul Eggert <eggert@cs.ucla.edu>
10574
10575 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
10576 This is also needed for porting to any host where GC_MARK_STACK is
10577 not GC_MAKE_GCPROS_NOOPS.
10578 (which_symbols): Use it.
10579
a0241d01
KH
105802011-11-07 Kenichi Handa <handa@m17n.org>
10581
10582 * coding.c (coding_set_destination): Check coding->src_pos only
10583 when coding->src_object is a buffer (bug#9910).
10584
10585 * process.c (send_process): Set the member src_multibyte of coding
10586 to 0 (bug#9911) when sending a unibyte text.
10587
10588 * callproc.c (Fcall_process): Set the member src_multibyte of
10589 process_coding to 0 (bug#9912).
10590
a64bfdfa 105912011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
10592
10593 * xmenu.c (cleanup_widget_value_tree): New function.
10594 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
10595 calling free_menubar_widget_value_tree directly (Bug#9830).
10596
cb41b32a
PE
105972011-11-06 Paul Eggert <eggert@cs.ucla.edu>
10598
10599 Fix some portability problems with 'inline'.
10600 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10601 (window_box_width, window_box_left, window_box_left_offset)
10602 (window_box_right, window_box_right_offset): Declare extern.
10603 Otherwise, these inline functions do not conform to C99 and
10604 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
10605 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
10606 * intervals.c (adjust_intervals_for_insertion)
10607 (adjust_intervals_for_deletion): Now extern, because otherwise the
10608 extern inline functions 'offset_intervals' couldn't refer to it.
10609 (static_offset_intervals): Remove.
10610 (offset_intervals): Rewrite using the old contents of
10611 static_offset_intervals. The old version didn't conform to C99
10612 because an extern inline function contained a reference to an
10613 identifier with static linkage.
10614
b7041366
AS
106152011-11-06 Andreas Schwab <schwab@linux-m68k.org>
10616
10617 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
10618 GC.
10619
88a37c4d
EZ
106202011-11-06 Eli Zaretskii <eliz@gnu.org>
10621
10622 * xdisp.c (init_iterator, reseat_to_string): Don't set the
10623 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
10624 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
10625 return Qleft_to_right.
10626
49745b39
CY
106272011-11-06 Chong Yidong <cyd@gnu.org>
10628
10629 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
10630 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
10631 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
10632 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
10633 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
10634 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
10635 (Fwindow_vscroll): Doc fix.
10636 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
10637 argument, since it makes no sense to pass a live window and for
10638 consistency with window-child.
10639
1f05cd82
CS
106402011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
10641
10642 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
10643 support MSVC.
10644
22610910
JR
106452011-11-05 Jason Rumney <jasonr@gnu.org>
10646
10647 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
10648 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
10649 fonts (Bug#6029).
10650 (add_font_entity_to_list): Fix logic errors in mixed boolean and
10651 bitwise arithmetic preventing use of unicode-sip and non-truetype
10652 opentype fonts.
10653
a06776b2
EZ
106542011-11-05 Eli Zaretskii <eliz@gnu.org>
10655
3ad924ba
EZ
10656 * s/ms-w32.h (fstat, stat, utime): Move redirections to
10657 "emacs"-only part.
10658
a06776b2
EZ
10659 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
10660 initialization code to keep similarity to xfns.c after changes
10661 from 2011-11-05.
10662
c9e7db78
JD
106632011-11-05 Jan Djärv <jan.h.d@swipnet.se>
10664
a97f8f3f
JD
10665 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
10666 (unwind_create_frame): New function (Bug#9943).
10667 (Fx_create_frame): Restructure code to be more similar to the one in
10668 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
10669 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
10670 Move terminal->reference_count++ just before making the frame official
10671 (Bug#9943).
10672
10673 * nsterm.m (x_free_frame_resources): New function.
10674 (x_destroy_window): Move code to x_free_frame_resources.
10675
c9e7db78 10676 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
10677 (Fx_create_frame, x_create_tip_frame):
10678 Move terminal->reference_count++ just before making the frame
75f1671a 10679 official. Move initialization of image_cache_refcount and
c9e7db78
JD
10680 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
10681
a6fc3b5c
EZ
106822011-11-05 Eli Zaretskii <eliz@gnu.org>
10683
10684 Support MSVC build with newer versions of Visual Studio.
10685 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
10686 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
10687 nt/gmake.defs.
10688
10689 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
10690 which are not supported by MSVC.
10691 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
10692 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
10693 bitfields.
10694 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
10695 types in bitfields.
10696 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
10697
10698 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
10699
58179cce 107002011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
10701
10702 Support MSVC build with newer versions of Visual Studio.
10703 * w32.c: Don't include w32api.h for MSVC.
10704 (init_environment) [_MSC_VER]: Call sys_access, not _access.
10705
10706 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
10707 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
10708 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
10709 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
10710 e_* cousins.
10711 (alloca) [_MSC_VER]: Define to _alloca.
10712
10713 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
10714
10715 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
10716
a58c13ed
EZ
107172011-11-04 Eli Zaretskii <eliz@gnu.org>
10718
10719 * xdisp.c (note_mouse_highlight): If either of
10720 previous/next-single-property-change returns nil, treat that as
10721 the beginning or the end of the buffer. (Bug#9955)
10722
fe0b6370
JD
107232011-11-04 Jan Djärv <jan.h.d@swipnet.se>
10724
a58c13ed 10725 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
10726 label is not null (Bug#9951).
10727 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
10728 may be NULL.
10729
89bd5ee1
EZ
107302011-11-04 Eli Zaretskii <eliz@gnu.org>
10731
10732 * window.c (Fwindow_body_size): Mention in the doc string that the
10733 return value is in frame's canonical units. (Bug#9949)
10734
84c3edb9
EZ
107352011-11-03 Eli Zaretskii <eliz@gnu.org>
10736
4e2fb5c7
EZ
10737 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
10738
84c3edb9 10739 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 10740 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 10741 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 10742
bc17a887
EZ
107432011-11-01 Eli Zaretskii <eliz@gnu.org>
10744
10745 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
10746 Don't stop backward scan on the continuation glyph, even though
10747 its CHARPOS is positive.
6d5eb5b0
SM
10748 (mouse_face_from_buffer_pos, note_mouse_highlight):
10749 Rename cover_string to disp_string.
bc17a887 10750
4ee88440
MR
107512011-11-01 Martin Rudalics <rudalics@gmx.at>
10752
10753 * window.c (temp_output_buffer_show): Don't use
10754 Vtemp_buffer_show_specifiers.
10755 (Vtemp_buffer_show_specifiers): Remove unused variable.
10756
c2ff3c02
EZ
107572011-10-30 Eli Zaretskii <eliz@gnu.org>
10758
10759 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
10760 past the beginning of the current glyph matrix.
10761
58179cce 107622011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
10763
10764 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
10765 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
10766 HAVE_GTK3 (Bug#9869).
b77a6a7f 10767
3b574623
JD
10768 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
10769 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
10770
b77a6a7f
JD
10771 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
10772
10773 * xterm.c: Declare x_handle_net_wm_state to return int.
10774 (handle_one_xevent): Check if we are iconified but don't have
10775 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
10776 (get_current_wm_state): Return non-zero if not hidden,
10777 check for _NET_WM_STATE_HIDDEN (Bug#9893).
10778 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
10779 (x_handle_net_wm_state): Return what get_current_wm_state returns.
10780 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
10781
196e41e4
PE
107822011-10-29 Paul Eggert <eggert@cs.ucla.edu>
10783
10784 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
10785 so that this new function doesn't get optimized away by a
10786 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
10787
021f2e1a
AS
107882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10789
10790 * frame.h (MOUSE_HL_INFO): Remove excess parens.
10791
8b058d44
EZ
107922011-10-29 Eli Zaretskii <eliz@gnu.org>
10793
10794 Fix the `xbytecode' command.
10795 * .gdbinit (xprintbytestr): New command.
b50a28de 10796 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
10797 (xbytecode): Print the byte-code string as well.
10798
4452fb80
EZ
107992011-10-29 Kim Storm <storm@cua.dk>
10800
8b058d44
EZ
10801 * alloc.c (which_symbols): New function.
10802
21b72067
AS
108032011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10804
10805 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
10806 line. (Bug#9903)
10807
83ed7b5c
GM
108082011-10-29 Glenn Morris <rgm@gnu.org>
10809
10810 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
10811 Not clear what it was for, and it causes various bugs. (Bug#9839)
10812
5a7a728b
EZ
108132011-10-28 Eli Zaretskii <eliz@gnu.org>
10814
10815 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
10816 possible random value that matches one of those tested as
10817 condition to clear the mouse face.
10818
d3d0842f
CY
108192011-10-28 Chong Yidong <cyd@gnu.org>
10820
10821 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
10822
31b39d13
DN
108232011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
10824
10825 * window.c (make_window): Initialize phys_cursor_on_p.
10826
9aba6043
SM
108272011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
10828
10829 * lisp.h (struct Lisp_Symbol): Update comments.
10830
c20992f4
JB
108312011-10-28 Juanma Barranquero <lekktu@gmail.com>
10832
10833 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
10834
db4f02f2
EZ
108352011-10-28 Eli Zaretskii <eliz@gnu.org>
10836
10837 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
10838 <oslsachem@gmail.com> for helping to debug this.
10839
10840 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
10841 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
10842 (g_b_init_get_glyph_outline_w): New static variables.
10843 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
10844 (GetGlyphOutlineW_Proc): New typedefs.
10845 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
10846 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
10847 New functions.
10848 (w32font_open_internal, compute_metrics):
10849 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
10850 instead of calling the "wide" APIs directly.
10851
10852 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
10853
10854 * w32.h (syms_of_w32font): Add prototype.
10855
87e68db4
JB
108562011-10-27 Juanma Barranquero <lekktu@gmail.com>
10857
10858 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
10859 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
10860 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
10861 (Fmove_to_window_line): Doc fix.
10862
435c1d67
CY
108632011-10-27 Chong Yidong <cyd@gnu.org>
10864
10865 * process.c (make_process): Set gnutls_state to NULL.
10866
10867 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
10868 non-NULL, regardless of GNUTLS_INITSTAGE.
10869 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
10870 an error. Set process slots as soon as we allocate them.
10871
10872 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
10873
9c6c6f49
CY
108742011-10-27 Chong Yidong <cyd@gnu.org>
10875
9aba6043
SM
10876 * gnutls.c (emacs_gnutls_deinit): New function.
10877 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
10878 (Fgnutls_deinit, Fgnutls_boot): Use it.
10879
10880 * process.c (make_process): Initialize GnuTLS credentials to NULL.
10881 (deactivate_process): Call emacs_gnutls_deinit.
10882
657d08d3
JB
108832011-10-27 Juanma Barranquero <lekktu@gmail.com>
10884
10885 * image.c (x_create_x_image_and_pixmap):
10886 * w32.c (sys_rename, w32_delayed_load):
10887 * w32font.c (fill_in_logfont):
10888 * w32reg.c (x_get_string_resource): Silence compiler warnings.
10889
5430d399
JB
108902011-10-26 Juanma Barranquero <lekktu@gmail.com>
10891
10892 * w32fns.c (w32_default_color_map): New function,
10893 extracted from Fw32_default_color_map.
a7ef684b 10894 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 10895
fe0055fa
PE
108962011-10-25 Paul Eggert <eggert@cs.ucla.edu>
10897
10898 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
10899
e6346438
SM
109002011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
10901
10902 * keyboard.c (test_undefined): New function (bug#9751).
10903 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
10904
e112cc37
ET
109052011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
10906
10907 * sysdep.c (init_sys_modes): Fix the check for the controlling
10908 terminal (Bug#6649).
10909
7b5d6677
EZ
109102011-10-20 Eli Zaretskii <eliz@gnu.org>
10911
10912 * dispextern.h (struct bidi_it): New member next_en_type.
10913
10914 * bidi.c (bidi_line_init): Initialize the next_en_type member.
10915 (bidi_resolve_explicit_1): When next_en_pos is valid for the
10916 current character, check also for next_en_type being WEAK_EN.
10917 (bidi_resolve_weak): Don't enter the expensive loop if the current
10918 position is before next_en_pos. Record the bidi type of the first
10919 non-ET, non-BN character we find, in addition to its position.
10920 (bidi_level_of_next_char): Invalidate next_en_type when
10921 next_en_pos is over-stepped.
10922
7da0b018
PE
109232011-10-20 Paul Eggert <eggert@cs.ucla.edu>
10924
10925 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
10926 * editfns.c: Rewrite current-time-zone so that it invokes
10927 the equivalent of (format-time-string "%Z") to get the time zone name.
10928 This fixes a bug when the time zone name contains characters that
10929 need converting from the system time locale to Emacs internal format.
10930 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
10931 that patch fixed format-time-string to do the conversion, but
10932 I forgot to fix current-time-zone.
10933 (format_time_string): New function, containing most of
10934 what Fformat_time_string used to contain.
10935 (Fformat_time_string): Rewrite in terms of format_time_string.
10936 This doesn't change this function's behavior.
10937 (current-time-zone): Rewrite to use format_time_string.
10938 This fixes the bug reported by Michael Schierl in
10939 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
10940 Jason Rumney's 2007-06-07 change worked around this bug, but
10941 didn't fix it.
10942 * systime.h (tzname, timezone): Remove no-longer-used declarations.
10943
8547b010
EZ
109442011-10-19 Eli Zaretskii <eliz@gnu.org>
10945
10946 * xdisp.c (start_display): If the character at POS is displayed
10947 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
10948 (try_window_reusing_current_matrix): If a line ends in a display
10949 vector or the next line starts in a display vector, continue
10950 redrawing the window even though the character position of
10951 start_row was reached.
8547b010
EZ
10952 (Bug#9771, part 2)
10953
4e948d15
CY
109542011-10-18 Chong Yidong <cyd@gnu.org>
10955
10956 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10957 with nobreak-char-display too.
10958
4787455f
EZ
109592011-10-18 Eli Zaretskii <eliz@gnu.org>
10960
10961 Fix part 3 of bug#9771.
10962 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10963 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10964 non-neutral characters if the current character is a paragraph
10965 separator (a.k.a. Newline). This avoids running the same
10966 expensive loop twice, once when we consume the preceding newline
10967 and the other time when the line actually needs to be displayed.
10968 Avoid the loop when we see neutrals on the base embedding level
10969 following a character whose directionality is the same as the
10970 paragraph's. This avoids running the expensive loop when a line
10971 ends in a long sequence of neutrals, like control characters.
10972 Add assertion against STRONG_AL type. Slightly rearrange code
10973 that determines the type of a neutral given the first non-neutral
10974 that follows it.
10975 (bidi_level_of_next_char): Set next_en_pos to zero when
10976 invalidating its info.
10977
2c91f553
EZ
109782011-10-17 Eli Zaretskii <eliz@gnu.org>
10979
10980 * xdisp.c (push_display_prop): Determine whether to record string
10981 or buffer position by IT->string, not by IT->method. Allow
10982 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10983 (move_it_vertically_backward): Don't look for character position
10984 immediately after the newline when in a continuation line.
10985 (Bug#9771, part 1)
2c91f553 10986
c7b08b0d
MR
109872011-10-15 Martin Rudalics <rudalics@gmx.at>
10988
10989 * window.c (coordinates_in_window): Rewrite and delabelize
10990 vertical border check. (Bug#5357) (Bug#9618)
10991
6b02f655
SM
109922011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10993
10994 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10995 errors in XSetWindowBorder (bug#9310).
10996
81d40c92
DA
109972011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10998
10999 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
11000 avoid crash when xmalloc overrun checking is enabled.
11001
d4172c3b
EZ
110022011-10-13 Eli Zaretskii <eliz@gnu.org>
11003
11004 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
11005 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
11006 cursor motion with <left> and <right> arrow keys.
11007
11008 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
11009 some callers set that themselves.
11010
b00eea75
EZ
110112011-10-12 Eli Zaretskii <eliz@gnu.org>
11012
11013 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
11014 display string and the previous row comes from the same string and
11015 is empty. (Bug#9739) (Bug#9738)
11016
8fe012c4
SM
110172011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
11018
11019 * doc.c (get_doc_string): Encode file name (bug#9735).
11020
0074aef2
EZ
110212011-10-12 Eli Zaretskii <eliz@gnu.org>
11022
79beb178
EZ
11023 * bidi.c (bidi_level_of_next_char):
11024 * xdisp.c (get_visually_first_element): Remove old incorrect
11025 comments regarding the Unicode Line Separator character.
11026
0074aef2
EZ
11027 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
11028
6e4b3fbe
DA
110292011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
11030
11031 * alloc.c (Fgc_status): Do not access beyond zombies array
11032 boundary if nzombies > MAX_ZOMBIES.
11033 * alloc.c (dump_zombies): Add missing format specifier.
11034
0324f3af
PE
110352011-10-12 Paul Eggert <eggert@cs.ucla.edu>
11036
b5525cac
PE
11037 * xdisp.c (set_cursor_from_row): Simplify conditionals,
11038 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
11039
0324f3af
PE
11040 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
11041 Some packages use them to denote characters with modifiers.
11042
e9b5f888
AS
110432011-10-11 Andreas Schwab <schwab@linux-m68k.org>
11044
11045 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
11046 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
11047 matching a pp-number. Rename parameter var to var1.
11048
127827c0
SM
110492011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
11050
11051 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
11052
c8fd3bd0
GM
110532011-10-08 Glenn Morris <rgm@gnu.org>
11054
11055 * callint.c (Fcall_interactively): Give a more explicit error for the
11056 'c' case with a non-character input. (Bug#8479)
11057
352ec8ff
EZ
110582011-10-08 Eli Zaretskii <eliz@gnu.org>
11059
03669ccb
EZ
11060 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
11061 lines.
7061c986
EZ
11062 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
11063 lines that are hscrolled on the left.
03669ccb 11064
352ec8ff
EZ
11065 * dispnew.c (buffer_posn_from_coords): Account for a possible
11066 presence of header-line. (Bug#4426)
11067
a66cfb1c
SM
110682011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
11069
6b02f655
SM
11070 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
11071 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 11072
7c5ee88e
PE
110732011-10-07 Paul Eggert <eggert@cs.ucla.edu>
11074
11075 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
11076 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
11077 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
11078 this makes Emacs dump core during garbage collection on rare
11079 occasions. sizeof is obviously inferior to offsetof here, so
11080 stick with offsetof.
11081 (GC_POINTER_ALIGNMENT): New macro.
11082 (mark_memory): Omit 3rd (offset) arg; caller changed.
11083 Don't assume EMACS_INT alignment is the same as pointer alignment.
11084
df1bbe5b
SM
110852011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
11086
11087 * keyboard.c (read_key_sequence_remapped): New var.
11088 (read_key_sequence): Compute remapping in the right buffer.
11089 (command_loop_1): Use read_key_sequence's remapping directly.
11090
51553db6
SM
110912011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
11092
32c1fffd
SM
11093 * dired.c (file_name_completion): Don't expand file name.
11094 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
11095 before checking file name handler.
11096
51553db6
SM
11097 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
11098 they've been requested explicitly (bug#9591).
11099
b6bd1599 111002011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
11101
11102 * keymap.c (Fsingle_key_description): Use make_specified_string
11103 instead of build_string to build string from push_key_description.
11104 (Bug#5193)
11105
f701dc2a
PE
111062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
11107
4222c55d
PE
11108 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
11109 This fixes a Y2038 bug on 64-bit hosts.
11110 * buffer.c (reset_buffer):
11111 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
11112 (Fclear_buffer_auto_save_failure):
11113 Use 0, not -1, to represent an unset failure time, since time_t
11114 might not be signed.
11115
f701dc2a
PE
11116 Remove dependency on glibc malloc internals.
11117 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11118 Move back here from lisp.h, but with their new implementations.
11119 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11120 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
11121 * charset.c (charset_table_init): New static var.
11122 (syms_of_charset): Use it instead of xmalloc. This removes a
11123 dependency on glibc malloc internals. See Eli Zaretskii's comment in
11124 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
11125 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11126 Move back to alloc.c.
11127 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11128 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
11129
9ceebf39
JD
111302011-09-30 Jan Djärv <jan.h.d@swipnet.se>
11131
11132 * nsterm.m (windowDidResize): Call x_set_window_size only when
11133 ns_in_resize is true. Otherwise set pixelwidth/height and
11134 call change_frame_size (Bug#9628).
11135
cb993c58
PE
111362011-09-30 Paul Eggert <eggert@cs.ucla.edu>
11137
3930c88b
PE
11138 Port --enable-checking=all to Fedora 14 x86-64.
11139 * charset.c (syms_of_charset): Also account for glibc malloc's
11140 internal overhead when calculating the initial malloc maximum.
11141
cb993c58
PE
11142 Port --enable-checking=all to Fedora 14 x86.
11143 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11144 Move to lisp.h.
11145 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
11146 (overrun_check_realloc, overrun_check_free):
11147 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
11148 That way, xmalloc returns a properly-aligned pointer even if
11149 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
11150 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
11151 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
11152 into account when calculating the initial malloc maximum.
11153 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11154 Move here from alloc.c, so that charset.c can use it too.
11155 Properly align; the old code wasn't right for common 32-bit hosts
11156 when configured with --enable-checking=all.
11157 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11158 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
11159
31bed486
EZ
111602011-09-29 Eli Zaretskii <eliz@gnu.org>
11161
04c70788 11162 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
11163 use EDOM.
11164
fbcaa2f3
EZ
111652011-09-28 Eli Zaretskii <eliz@gnu.org>
11166
11167 * xdisp.c (compute_display_string_end): If there's no display
11168 string at CHARPOS, return -1.
11169
11170 * bidi.c (bidi_fetch_char): When compute_display_string_end
11171 returns a negative value, treat the character as a normal
11172 character not covered by a display string. (Bug#9624)
11173
a239d4e9
JB
111742011-09-28 Juanma Barranquero <lekktu@gmail.com>
11175
11176 * lread.c (Fread_from_string): Fix typo in docstring.
11177
88652fd5
EZ
111782011-09-27 Eli Zaretskii <eliz@gnu.org>
11179
11180 * xdisp.c (handle_invisible_prop): If invisible text ends on a
11181 newline, reseat the iterator instead of bidi-iterating there one
11182 character at a time. (Bug#9610)
32c1fffd
SM
11183 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
11184 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 11185
ed497dd4
AS
111862011-09-27 Andreas Schwab <schwab@linux-m68k.org>
11187
11188 * lread.c (readevalloop): Use correct code for NBSP.
11189 (read1): Likewise. (Bug#9608)
11190
b2bf61aa
MA
111912011-09-25 Michael Albinus <michael.albinus@gmx.de>
11192
11193 * dbusbind.c (Fdbus_register_signal): When service is not
11194 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
11195
32bbb17c
GM
111962011-09-25 Glenn Morris <rgm@gnu.org>
11197
11198 * buffer.c (truncate-lines): Doc fix.
11199
94e0933e
CY
112002011-09-24 Chong Yidong <cyd@stupidchicken.com>
11201
11202 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
11203 (Fset_window_next_buffers): Doc fix.
11204
cddde921
GM
112052011-09-24 Glenn Morris <rgm@gnu.org>
11206
11207 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
11208
1260aef1
PE
112092011-09-24 Paul Eggert <eggert@cs.ucla.edu>
11210
25b4bfa0
PE
11211 Fix minor problems found by static checking.
11212 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
11213 * indent.c (Fvertical_motion): Fix == vs = typo.
11214
e3cbd34b
EZ
112152011-09-24 Eli Zaretskii <eliz@gnu.org>
11216
a66cfb1c
SM
11217 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
11218 Default value is now t. Doc fix.
6bf7006f 11219
e3cbd34b 11220 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 11221 logic when moving up, not only when moving down. Fix the
e3cbd34b 11222 confusing name and values of the it_overshoot_expected variable;
32c1fffd 11223 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
11224
11225 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
11226 CHARPOS is covered by a display string which includes newlines.
11227 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
11228 is covered by a display string with embedded newlines.
11229
a3de0cbd
MA
112302011-09-24 Michael Albinus <michael.albinus@gmx.de>
11231
11232 * dbusbind.c (Fdbus_register_signal): Add match rule to
11233 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
11234 (Fdbus_register_method, Vdbus_registered_objects_table):
11235 Fix docstring.
a3de0cbd 11236
b260039d
JM
112372011-09-24 Jim Meyering <meyering@redhat.com>
11238
32c1fffd 11239 do not ignore write error for any output size
b260039d
JM
11240 The previous change was incomplete.
11241 While it makes emacs --batch detect the vast majority of stdout
11242 write failures, errors were still ignored whenever the output size is
11243 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
11244 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
11245 && echo FAIL: ignored write error
11246 FAIL: ignored write error
11247 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
11248 && echo FAIL: ignored write error
11249 FAIL: ignored write error
11250 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
11251
8eca8a7c
AS
112522011-09-23 Andreas Schwab <schwab@linux-m68k.org>
11253
11254 * emacs.c (Fkill_emacs): In noninteractive mode exit
11255 non-successfully if a write error occurred on stdout. (Bug#9574)
11256
3341db62
EZ
112572011-09-21 Eli Zaretskii <eliz@gnu.org>
11258
11259 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
11260 the xassert test.
11261
11262 * dispextern.h (struct it): Update the comment documenting what
11263 can it->OBJECT be.
11264
8c203dbf
EZ
112652011-09-20 Eli Zaretskii <eliz@gnu.org>
11266
11267 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
11268 a display string, extend search for cursor position to end of row.
11269 (find_row_edges): If the row ends in a newline from a display
11270 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
11271 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
11272 (Fcurrent_bidi_paragraph_direction): Fix search for previous
11273 non-empty line. Fixes confusing cursor motion with arrow keys at
11274 the beginning of a line that starts with whitespace.
8c203dbf 11275
a4824228
LMI
112762011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11277
11278 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
11279 (bug#9493).
11280
33ed493b
CY
112812011-09-18 Chong Yidong <cyd@stupidchicken.com>
11282
11283 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
11284 boolean (Bug#9154).
11285
56cd55c8
EZ
112862011-09-18 Eli Zaretskii <eliz@gnu.org>
11287
11288 * xdisp.c (display_line): Record maximum and minimum buffer
11289 positions even if no glyphs were produced (e.g., by a zero-width
11290 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
11291 buffer positions that will be removed from the glyph row because
11292 they don't fit.
c02dcedf
EZ
11293 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
11294 column is beyond frame width: don't subtract 1 "pixel" when
11295 computing width of the stretch.
3e62b7e0
EZ
11296 (reseat_at_next_visible_line_start): Undo the change made on
11297 2011-09-17 that saved paragraph information and restored it after
11298 the call to `reseat'. (Bug#9545)
56cd55c8 11299
5ed99d36 113002011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
11301
11302 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
11303 and turn window cursor on if cleared (Bug#9415).
11304
5ed99d36 113052011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
11306
11307 * search.c (boyer_moore): Take unibyte characters from pattern
11308 literally. (Bug#9458)
11309
9bade7b2
EZ
113102011-09-18 Eli Zaretskii <eliz@gnu.org>
11311
11312 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
11313
e5e9d610
PE
113142011-09-18 Paul Eggert <eggert@cs.ucla.edu>
11315
87e4427a
PE
11316 Fix minor problem found by static checking.
11317 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
11318 initialized, to pacify gcc -Wuninitialized.
11319
e5e9d610
PE
11320 * fileio.c: Report proper errno when syscall falls.
11321 (Finsert_file_contents): Save and restore errno,
11322 so that report_file_error outputs the correct diagnostic.
11323 (Fwrite_region) [CLASH_DETECTION]: Likewise.
11324
a1674f0b
EZ
113252011-09-18 Eli Zaretskii <eliz@gnu.org>
11326
11327 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
11328
fbfb6dd4
EZ
113292011-09-17 Eli Zaretskii <eliz@gnu.org>
11330
11331 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
11332 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
11333
bb187662
EZ
113342011-09-17 Eli Zaretskii <eliz@gnu.org>
11335
1137e8b8 11336 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 11337 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
11338
11339 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
11340 (bidi_find_paragraph_start): Search back for paragraph beginning
11341 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
11342 (bidi_move_to_visually_next): Only trigger paragraph-related
11343 computations when the last character is a newline or at EOB, not
11344 just any NEUTRAL_B. (Bug#9470)
11345
bb187662
EZ
11346 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
11347 truncated lines if point is covered by a display string. (Bug#9524)
11348
2e621251
PE
113492011-09-16 Paul Eggert <eggert@cs.ucla.edu>
11350
11351 * xselect.c: Relax test for outgoing X longs (Bug#9498).
11352 (cons_to_x_long): New function.
11353 (lisp_data_to_selection_data): Use it. Correct the test for
11354 short-versus-long data; it was negated. Break out of vector
11355 loop, for efficiency, when a long datum is discovered.
11356
91a15bc6
SM
113572011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
11358
11359 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
11360
b41c3a35
EZ
113612011-09-16 Eli Zaretskii <eliz@gnu.org>
11362
11363 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
11364 GCC PR/17406) by declaring this function with external scope.
11365
7812ba2d
PE
113662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11367
11368 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
11369 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
11370
cf7edc2a
AS
113712011-09-15 Andreas Schwab <schwab@linux-m68k.org>
11372
11373 * editfns.c (Fformat): Correctly handle text properties on "%%".
11374
bd01620e
EZ
113752011-09-15 Eli Zaretskii <eliz@gnu.org>
11376
11377 * xterm.c (x_draw_composite_glyph_string_foreground):
11378 * w32term.c (x_draw_composite_glyph_string_foreground):
11379 * term.c (encode_terminal_code):
11380 * composite.c (composition_update_it, get_composition_id):
11381 * xdisp.c (get_next_display_element)
11382 (fill_composite_glyph_string): Add comments about special meaning
11383 of TAB characters in a composition.
11384
a02719a3
PE
113852011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11386
11387 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
11388 This occurs when processing a multibyte format.
11389 Problem reported by Wolfgang Jenker.
a02719a3 11390
72589a3c
JB
113912011-09-15 Johan Bockgård <bojohan@gnu.org>
11392
11393 * xdisp.c (try_cursor_movement): Only check for exact match if
11394 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
11395
1c14176c
PE
113962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
11397
11398 Remove unused external symbols.
11399 * dispextern.h (calc_pixel_width_or_height): Remove decl.
11400 * xdisp.c (calc_pixel_width_or_height): Now static.
11401 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
11402 * indent.c (check_display_width):
11403 * w32term.c: Fix comment to match code.
11404 * xterm.c, xterm.h (x_catching_errors): Remove.
11405
d2eea5b5
PE
114062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
11407
11408 * xselect.c: Use signed conversions more consistently (Bug#9498).
11409 (selection_data_to_lisp_data): Assume incoming selection data are
11410 signed integers, not unsigned. This is to be consistent with
11411 outgoing selection data, which was modified to use signed integers
11412 in as part of the fix to Bug#9196 in response to Jan D.'s comment
11413 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
11414 expects long, not unsigned long.
11415
46888499
EZ
114162011-09-14 Eli Zaretskii <eliz@gnu.org>
11417
11418 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
11419 computation of loop end. Reported by Johan Bockgård
11420 <bojohan@gnu.org>.
11421
ef8ef9fb
CY
114222011-09-13 Chong Yidong <cyd@stupidchicken.com>
11423
11424 * frame.c (Fother_visible_frames_p): Function deleted.
11425
fa819fed
EZ
114262011-09-12 Eli Zaretskii <eliz@gnu.org>
11427
11428 * indent.c (compute_motion): Process display vector front to back
11429 rather than the other way around. (Bug#2496)
11430
2ba8e008
SM
114312011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
11432
11433 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
11434
20f53c69
CY
114352011-09-11 Chong Yidong <cyd@stupidchicken.com>
11436
11437 * minibuf.c (Fread_from_minibuffer): Doc fix.
11438
d562d7a4
EZ
114392011-09-11 Eli Zaretskii <eliz@gnu.org>
11440
11441 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
11442 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
11443
1c4d7f3d
LMI
114442011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11445
11446 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
11447 value for non-existent files.
11448
b885bf36
EZ
114492011-09-11 Eli Zaretskii <eliz@gnu.org>
11450
11451 * fileio.c (Finsert_file_contents): If the file cannot be opened,
11452 set its "size" to -1. This will set the modtime_size field of
11453 the corresponding buffer to -1, which is what
11454 verify-visited-file-modtime expects for files that do not exist.
11455 (Bug#9139)
11456
6612f0bf
PE
114572011-09-11 Paul Eggert <eggert@cs.ucla.edu>
11458
11459 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
11460 here ...
11461 * lisp.h: ... from here. push_key_description is no longer
11462 defined in keyboard.c, so its declaration should not be in
11463 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
11464 logically belongs with push_key_description.
11465
dfb3f755
PE
114662011-09-10 Paul Eggert <eggert@cs.ucla.edu>
11467
11468 * buffer.h: Include <sys/types.h> instead of <time.h>.
11469 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
11470 Problem reported by Herbert J. Skuhra.
11471
3134906c
LMI
114722011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
11473
11474 * xml.c (parse_region): Make the parsing work for
11475 non-comment-starting XML files again (bug#9144).
11476
8d903f4e
AS
114772011-09-10 Andreas Schwab <schwab@linux-m68k.org>
11478
11479 * image.c (gif_load): Fix calculation of bottom and right corner.
11480 (Bug#9468)
11481
80ad64f4
EZ
114822011-09-10 Eli Zaretskii <eliz@gnu.org>
11483
11484 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
11485 redisplay in small windows.
11486
208a048d
EZ
114872011-09-09 Eli Zaretskii <eliz@gnu.org>
11488
11489 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
11490
9b1c252e
MR
114912011-09-08 Martin Rudalics <rudalics@gmx.at>
11492
11493 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
11494 Operate on live windows only.
11495
2949f33b
JB
114962011-09-08 Juanma Barranquero <lekktu@gmail.com>
11497
11498 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
11499
e08dcafd
EZ
115002011-09-07 Eli Zaretskii <eliz@gnu.org>
11501
11502 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
11503 only under bidi iteration.
11504
115b96bd
JD
115052011-09-07 Jan Djärv <jan.h.d@swipnet.se>
11506
11507 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
11508
c8199d0f
PE
115092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
11510
11511 isnan: Fix porting problem to Solaris 10 with bundled gcc.
11512 Without this fix, the command to link temacs failed due to an
11513 undefined symbol __builtin_isnan. This is because
11514 /usr/include/iso/math_c99.h #defines isnan(x) to
11515 __builtin_isnan(x), but the bundled gcc, which identifies itself
11516 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
11517 a __builtin_isnan.
11518 * floatfns.c (isnan): #undef, and then #define to a clone of
11519 what's in data.c.
11520 (Fisnan): Always define, since it's always available now.
11521 (syms_of_floatfns): Always define isnan at the Lisp level.
11522
e39b275c 115232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
11524
11525 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
11526
b2db44d9 115272011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 11528
f4af5137 11529 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
11530 The previous code assumed that file offsets (off_t values) fit in
11531 EMACS_INT variables, which is not true on typical 32-bit hosts.
11532 The code messed up by falsely reporting buffer overflow in cases
11533 such as (insert-file-contents "big" nil 1 2) into an empty buffer
11534 when "big" contains more than 2**29 bytes, even though this
11535 inserts just one byte and does not overflow the buffer.
11536 (Finsert_file_contents): Store file offsets as off_t
11537 values, not as EMACS_INT values. Check for overflow when
11538 converting between EMACS_INT and off_t. When checking for
11539 buffer overflow or for overlap, take the offsets into account.
11540 Don't use EMACS_INT for small values where int suffices.
11541 When checking for overlap, fix a typo: ZV was used where
11542 ZV_BYTE was intended.
11543 (Fwrite_region): Don't assume off_t fits into 'long'.
11544 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
11545
ecfc0a49
MA
115462011-09-05 Michael Albinus <michael.albinus@gmx.de>
11547
11548 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
11549
6511acf2 115502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 11551
0999621a 11552 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
11553
11554 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 11555 (esprintf, exprintf, evxprintf): New functions.
62f19c19 11556 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 11557 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
11558 (modify_event_symbol): Do not assume that the length of
11559 name_alist_or_stem is safe to alloca and fits in int.
11560 (Fexecute_extended_command): Likewise for function name and binding.
11561 (Frecursion_depth): Wrap around reliably on integer overflow.
11562 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
11563 since some callers pass EMACS_INT values.
11564 (Fsingle_key_description): Don't crash if symbol name contains more
11565 than MAX_ALLOCA bytes.
11566 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
11567 (get_minibuffer): Arg is now EMACS_INT, not int.
11568 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 11569 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
11570 * window.h (command_loop_level, minibuf_level): Reflect API changes.
11571
2be7d702
PE
11572 * dbusbind.c (signature_cat): New function.
11573 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
11574 Do not overrun buffer; instead, report string overflow.
11575
9d1df220
PE
11576 * dispnew.c (add_window_display_history): Don't overrun buffer.
11577 Truncate instead; this is OK since it's just a log.
11578
33ef5c64
PE
11579 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
11580 even if the time zone offset is outlandishly large.
11581 Don't mishandle offset == INT_MIN.
11582
66c6fdd5
PE
11583 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
11584 when creating daemon; the previous buffer-overflow check was incorrect.
11585
d749b01b
PE
11586 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
11587 which has the guts of the old verror function.
11588
b5cd1905
PE
11589 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
11590 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
11591
6e1a67fb
PE
11592 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
11593 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 11594 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 11595 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
11596 length of string rather than counting it via multiple sprintfs;
11597 that's simpler and more reliable.
c21721cc
PE
11598 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
11599 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
11600 sprintf, in case result does not fit in int.
11601
c57b67fc
PE
11602 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
11603 (fontset_from_font): Print it.
11604
8a401434
PE
11605 * frame.c (tty_frame_count): Now printmax_t, not int.
11606 (make_terminal_frame, set_term_frame_name): Print it.
11607 (x_report_frame_params): In X, window IDs are unsigned long,
11608 not signed long, so print them as unsigned.
11609 (validate_x_resource_name): Check for implausibly long names,
11610 and don't assume name length fits in 'int'.
11611 (x_get_resource_string): Don't blindly alloca invocation name;
11612 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
11613 not fit in int.
11614
6e1a67fb
PE
11615 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
11616 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
11617 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
11618
0df02bf3
PE
11619 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
11620 Use esprintf, not sprintf, in case result does not fit in int.
11621
48e30793
PE
11622 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11623 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
11624 it as a large positive number.
11625 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
11626 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11627
a66ff6d8
PE
11628 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
11629 in case result does not fit in int.
11630
aca216ff
PE
11631 * print.c (float_to_string): Detect width overflow more reliably.
11632 (print_object): Make sprintf buffer a bit bigger, to avoid potential
11633 buffer overrun. Don't assume list length fits in 'int'. Treat
11634 print length of 0 as 0, not as infinity; to be consistent with other
11635 uses of print length in this function. Don't overflow print length
11636 index. Don't assume hash table size fits in 'long', or that
11637 vectorlike size fits in 'unsigned long'.
11638
31c286f7
PE
11639 * process.c (make_process): Use printmax_t, not int, to format
11640 process-name gensyms.
11641
55e5faa1
PE
11642 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
11643
80f2e268
PE
11644 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
11645 to avoid potential buffer overrun.
11646
670741ab
PE
11647 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
11648 if X resource line is longer than 512 bytes.
11649
b7163a50
PE
11650 * xfns.c (x_window): Make sprintf buffer a bit bigger
11651 to avoid potential buffer overrun.
11652
ae58ff1f
PE
11653 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
11654
c43c8a6a
PE
11655 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
11656
3f8236f4
PE
116572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
11658
53e9fe90 11659 Integer overflow fixes for scrolling, etc.
6511acf2
PE
11660 Without these, Emacs silently mishandles large integers sometimes.
11661 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
11662 it were "C-u 1 M-x recenter" on a typical 64-bit host.
11663
6511acf2
PE
11664 * xdisp.c (try_window_id): Check Emacs fixnum range before
11665 converting to 'int'.
806add1d 11666
6511acf2 11667 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
11668 Check that an Emacs fixnum is in range before assigning it to 'int'.
11669 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
11670 values converted from Emacs fixnums.
11671 (Frecenter): Don't wrap around a line count if it is out of 'int'
11672 range; instead, treat it as an extreme value.
11673 (Fset_window_configuration, compare_window_configurations):
11674 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
11675
6511acf2
PE
11676 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
11677 that can exceed INT_MAX. Check that EMACS_INT value is in range
11678 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
11679 (match_limit): Don't assume that a fixnum can fit in 'int'.
11680
6511acf2 11681 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
11682 exceed INT_MAX.
11683
6511acf2 11684 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
11685 (Fvertical_motion): Don't wrap around LINES values that don't fit
11686 in 'int'. Instead, treat them as extreme values. This is good
11687 enough for windows, which can't have more than INT_MAX lines anyway.
11688
fcb901a7
LMI
116892011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11690
0f2f6b6d
LMI
11691 * Require libxml/parser.h to avoid compilation warning.
11692
fcb901a7
LMI
11693 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
11694
11695 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
11696 since this reportedly can destroy thread storage.
11697
6e20a0d4
CY
116982011-08-30 Chong Yidong <cyd@stupidchicken.com>
11699
11700 * syntax.c (find_defun_start): Update all cache variables if
11701 exiting early (Bug#9401).
11702
148ae00e
EZ
117032011-08-30 Eli Zaretskii <eliz@gnu.org>
11704
f6cfbd8f
EZ
11705 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
11706
148ae00e
EZ
11707 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
11708 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
11709 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
11710
11711 * term.c (tty_append_glyph): New function.
11712 (produce_stretch_glyph): Static function and its prototype deleted.
11713
a66cfb1c
SM
11714 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
11715 Add prototypes.
148ae00e 11716
c4a07a4c
PE
117172011-08-29 Paul Eggert <eggert@cs.ucla.edu>
11718
11719 * image.c (parse_image_spec): Check for nonnegative, not for positive,
11720 when checking :margin (Bug#9390).
11721 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 11722 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
11723 so that the name doesn't mislead. All uses changed.
11724
6bc8cd65
JB
117252011-08-28 Johan Bockgård <bojohan@gnu.org>
11726
11727 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
11728 set_tty_hooks.
11729
dca4927e
EZ
117302011-08-27 Eli Zaretskii <eliz@gnu.org>
11731
11732 * xdisp.c (move_it_to): Don't bail out early when reaching
11733 position beyond to_charpos, if we are scanning backwards.
11734 (move_it_vertically_backward): When DY == 0, make sure we get to
11735 the first character in the line after the newline.
11736
f2cad773
PE
117372011-08-27 Paul Eggert <eggert@cs.ucla.edu>
11738
11739 * ccl.c: Improve and simplify overflow checking (Bug#9196).
11740 (ccl_driver): Do not generate an out-of-range pointer.
11741 (Fccl_execute_on_string): Remove unnecessary check for
11742 integer overflow, noted by Stefan Monnier in
11743 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
11744 Remove a FIXME that didn't need fixing.
11745 Simplify the newly-introduced buffer reallocation code.
11746
0cae2cdb
JB
117472011-08-27 Juanma Barranquero <lekktu@gmail.com>
11748
11749 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
11750
5fc295a4 117512011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 11752
70c60eb2 11753 Integer and memory overflow issues (Bug#9196).
726e0ab1 11754
d31850da
PE
11755 * doc.c (get_doc_string): Rework so that
11756 get_doc_string_buffer_size is the actual buffer size, rather than
11757 being 1 less than the actual buffer size; this makes xpalloc more
11758 convenient.
11759
a69fbedb
PE
11760 * image.c (x_allocate_bitmap_record, cache_image):
11761 * xselect.c (Fx_register_dnd_atom):
11762 Simplify previous changes by using xpalloc.
11763
fe5c5d37
PE
11764 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
11765 since either will do and ptrdiff_t is convenient with xpalloc.
11766
0065d054
PE
11767 * charset.c (charset_table_size)
11768 (struct charset_sort_data.priority): Now ptrdiff_t.
11769 (charset_compare): Don't overflow if priorities differ greatly.
11770 (Fsort_charsets): Don't assume list length fits in int.
11771 Check for size-calculation overflow when allocating sort data.
11772 (syms_of_charset): Allocate an initial charset table that is
11773 just under 64 KiB, to avoid problems with glibc malloc and mmap.
11774
11775 * cmds.c (internal_self_insert): Check for size-calculation overflow.
11776
11777 * composite.h (struct composition.glyph_len): Now int, not unsigned.
11778 The actual value is always <= INT_MAX, and leaving it unsigned made
11779 overflow checking harder.
11780
11781 * dispextern.h (struct glyph_matrix.rows_allocated)
11782 (struct face_cache.size): Now ptrdiff_t, for convenience in use
11783 with xpalloc. The values are still always <= INT_MAX.
11784
11785 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
11786
11787 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
11788 (SAFE_NALLOCA): New macro.
11789
11790 * region-cache.c (struct boundary.pos, find_cache_boundary)
11791 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
11792 (set_cache_region, invalidate_region_cache)
11793 (revalidate_region_cache, know_region_cache, region_cache_forward)
11794 (region_cache_backward, pp_cache):
11795 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
11796 so that ptrdiff_t * can be passed to xpalloc.
11797 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
11798 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
11799 (pp_cache): Don't assume cache_len fits in int.
11800 * region-cache.h: Adjust extern decls to match.
11801
11802 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
11803 EMACS_INT, since either will do, for xpalloc.
11804
11805 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
11806 (xnmalloc, xnrealloc, xpalloc): New functions.
11807
726e0ab1
PE
11808 * bidi.c (bidi_shelve_header_size): New constant.
11809 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
11810 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
11811
51f30bc5 11812 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
11813 * buffer.c (overlays_at, overlays_in, record_overlay_string)
11814 (overlay_strings):
11815 Don't update size of array until after memory allocation succeeds,
11816 because xmalloc/xrealloc may not return.
0065d054
PE
11817 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
11818 now that we have proper integer overflow checking.
11819 (record_overlay_string, overlay_strings): Catch overflows when
11820 calculating size of overlay_str_buf.
726e0ab1 11821
0065d054
PE
11822 * callproc.c (Fcall_process): Check for size overflow when
11823 calculating size of args2.
11824 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
11825 Normally we prefer signed values, but sticking with ptrdiff_t would
11826 require adding more-complicated checks.
726e0ab1
PE
11827
11828 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
11829 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
11830 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 11831 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
11832
11833 * character.c (Fstring): Check for size-calculation overflow.
11834
11835 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
11836 unnecessary integer overflow. Check for size overflow.
11837 (encode_coding_object): Don't update size until xmalloc succeeds.
11838
11839 * composite.c (get_composition_id): Check for overflow in glyph
11840 length calculations.
11841
11842 Integer and memory overflow fixes for display code.
11843 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
11844 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
11845 (scrolling_window): Check for overflow in size calculations.
11846 (line_draw_cost, realloc_glyph_pool, add_row_entry):
11847 Don't assume glyph table len fits in int.
11848 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
11849 (row_table_size): Now ptrdiff_t, not int.
11850 (scrolling_window): Avoid overflow in size calculations.
11851 Don't update size until allocation succeeds.
11852 * fns.c (concat): Check for overflow in size calculations.
11853 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
11854 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11855 (NEXT_ALMOST_PRIME_LIMIT): New constant.
11856
11857 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
11858 (get_doc_string): Check for size calculation overflow.
11859 Don't update size until allocation succeeds.
11860 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
11861 EMACS_INT, where ptrdiff_t will do.
11862 (Fsubstitute_command_keys): Check for string overflow.
11863
11864 * editfns.c (set_time_zone_rule): Don't assume environment length
11865 fits in int.
11866 (message_length): Now ptrdiff_t, not int.
11867 (Fmessage_box): Don't update size until allocation succeeds.
11868 Don't assume message length fits in int.
11869 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
11870
0065d054
PE
11871 * emacs.c (main): Do not reallocate argv, since there is a null at
11872 the end that can be overwritten, and this way there's no need to
11873 worry about size-calculation overflow.
11874 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
11875
11876 * eval.c (init_eval_once, grow_specpdl): Don't update size until
11877 alloc succeeds.
11878 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
11879
11880 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
11881 (x_set_scroll_bar_width, x_figure_window_size):
11882 Check for integer overflow.
11883 (x_set_alpha): Do not assume XINT fits in int.
11884
11885 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
11886 This is for the members text_lines, text_cols, total_lines, total_cols,
11887 where the system imposes an 'int' limit.
11888
11889 * fringe.c (Fdefine_fringe_bitmap):
11890 Don't update size until alloc works.
11891
11892 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
11893 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
11894
11895 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
11896 Check for size-calculation overflow.
11897 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
11898 do, as we prefer signed integers.
11899 (id_to_widget.max_size, id_to_widget.used)
11900 (xg_store_widget_in_map, xg_remove_widget_from_map)
11901 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
11902 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
11903 Use and return ptrdiff_t, not int.
11904 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
11905 * gtkutil.h: Change prototypes to match the above.
11906
11907 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
11908 are duplicate now that they've been promoted to lisp.h.
11909 (x_allocate_bitmap_record, x_alloc_image_color)
11910 (make_image_cache, cache_image, xpm_load):
11911 Don't update size until alloc is done.
11912 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
11913 (x_detect_edges):
3256efce 11914 Check for size calculation overflow.
726e0ab1
PE
11915 (ct_colors_allocated_max): New constant.
11916 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
11917 overflow.
3256efce 11918
726e0ab1
PE
11919 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
11920 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
11921 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
11922 Use ptrdiff_t, not int, to count maps.
11923 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
11924 calculations. Don't update size until allocation succeeds.
11925 Redo calculations to avoid overflow.
726e0ab1
PE
11926 * keyboard.h: Change prototypes to match the above.
11927
11928 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
11929 to count maps.
11930 (current_minor_maps): Check for size calculation overflow.
11931 * keymap.h: Change prototypes to match the above.
11932
11933 * lread.c (read1, init_obarray): Don't update size until alloc done.
11934
11935 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
11936 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
11937
726e0ab1
PE
11938 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
11939 Now ptrdiff_t, not int.
11940 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
11941 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
11942
11943 * process.c (Fnetwork_interface_list): Check for overflow
11944 in size calculation.
11945
11946 * region-cache.c (move_cache_gap): Check for size calculation overflow.
11947
11948 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
11949 overflow. Don't bother calling xmalloc when xrealloc will do.
11950
11951 * search.c (Freplace_match): Check for size calculation overflow.
11952 (Fset_match_data): Don't assume list lengths fit in 'int'.
11953
11954 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
11955 for command line length. Do not attempt to address one before the
11956 beginning of an array, as that's not portable.
11957
11958 * term.c (max_frame_lines): Remove; unused.
11959 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11960 not int.
11961 (encode_terminal_code, calculate_costs): Check for size
11962 calculation overflow.
11963 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11964 table lengths and related sizes. Don't update size until alloc
11965 done. Redo calculations to avoid overflow.
11966 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11967
11968 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11969 subtracting pointers.
11970 (gobble_line): Check for overflow more carefully. Don't update size
11971 until alloc done.
11972
11973 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11974 Don't update size until alloc done.
11975 Redo size calculations to avoid overflow.
11976 Check for size calculation overflow.
0065d054 11977 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11978
11979 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11980 Use ptrdiff_t, not int, for sizes.
11981 (store_mode_line_noprop_char): Don't update size until alloc done.
11982
0065d054
PE
11983 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11984 Use ptrdiff_t, not int, for sizes.
11985 (Finternal_make_lisp_face, cache_face):
11986 Check for size calculation overflow.
11987 (cache_face): Treat size calculation overflows as if they were
11988 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11989
11990 * xfns.c (x_encode_text, x_set_name_internal)
11991 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11992 sizes, since they can exceed INT_MAX in size. Check for size
11993 calculation overflow.
11994
0065d054
PE
11995 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11996 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11997 Don't update size until alloc done.
11998
0065d054 11999 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 12000 as sprintf is limited to int lengths.
1d526e2f 12001
252c5ee1
PE
12002 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
12003 (X_LONG_MIN): New macros.
864d7ce7
PE
12004 Use them to make the following changes clearer.
12005 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
12006 This change doesn't affect the value now, but it may help remind
12007 future maintainers not to raise the value too much later.
12008 (SELECTION_QUANTUM): Remove, replacing with ...
12009 (selection_quantum): ... new function, which avoids overflow.
12010 All uses changed.
12011 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
12012 assumption that selection length fits in 'int'.
12013 (x_reply_selection_request, x_handle_selection_request)
12014 (x_get_window_property, receive_incremental_selection)
12015 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
12016 (lisp_data_to_selection_data, clean_local_selection_data):
12017 Use ptrdiff_t, not int, to record length of selection.
12018 (x_reply_selection_request, x_get_window_property)
12019 (receive_incremental_selection, x_property_data_to_lisp):
12020 Redo calculations to avoid overflow.
12021 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 12022 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
12023 something.
12024 (x_get_window_property, receive_incremental_selection)
12025 (lisp_data_to_selection_data, x_property_data_to_lisp):
12026 Check for size-calculation overflow.
12027 (x_get_window_property, receive_incremental_selection)
12028 (lisp_data_to_selection_data, Fx_register_dnd_atom):
12029 Don't store size until memory allocation succeeds.
12030 (x_get_window_property): Plug memory leak on memory exhaustion.
12031 Don't double-block input; malloc is safe here. Don't assume 2**34
12032 - 4 fits in unsigned long. Add an xassert to check
12033 XGetWindowProperty overflow. Be more careful about overflow
12034 calculations, and distinguish size from memory overflow better.
12035 (receive_incremental_selection): When tracing, don't assume
12036 unsigned int is less than INT_MAX.
12037 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
12038 harmful) conversions of unsigned short to int.
12039 (lisp_data_to_selection_data): Don't assume that integers
12040 in the range -65535 through -1 fit in an X unsigned short.
12041 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
12042 result parameters unless successful. Rely on cons_to_unsigned
12043 to report problems with elements; the old code wasn't right anyway.
12044 (x_check_property_data): Check for int overflow; we cannot use
12045 a wider type due to X limits.
12046 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
12047
726e0ab1 12048 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 12049
0065d054
PE
12050 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
12051 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
12052 (x_color_cells): Don't store size until memory allocation succeeds.
12053 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 12054 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
12055 (x_term_init): Don't assume length fits in int (sprintf is limited
12056 to int size).
bc18e09d 12057
ebfa62c0
PE
12058 Use ptrdiff_t for composition IDs.
12059 * character.c (lisp_string_width):
12060 * composite.c (composition_table_size, n_compositions)
12061 (get_composition_id, composition_gstring_from_id):
12062 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
12063 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
12064 * window.c (Frecenter):
12065 Use ptrdiff_t, not int, for composition IDs.
12066 * composite.c (get_composition_id): Check for integer overflow.
12067 * composite.h: Adjust prototypes to match the above changes.
12068
d3411f89
PE
12069 Use ptrdiff_t for hash table indexes.
12070 * category.c (hash_get_category_set):
12071 * ccl.c (ccl_driver):
12072 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
12073 * coding.c (coding_system_charset_list, detect_coding_system):
12074 * coding.h (struct coding_system.id):
12075 * composite.c (get_composition_id, gstring_lookup_cache):
12076 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
12077 * image.c (xpm_get_color_table_h):
12078 * lisp.h (hash_lookup, hash_put):
12079 * minibuf.c (Ftest_completion):
12080 Use ptrdiff_t for hash table indexes, not int (which is too
12081 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
12082 32-bit --with-wide-int hosts).
12083
e097a6fa
PE
12084 * charset.c (Fdefine_charset_internal): Check for integer overflow.
12085 Add a FIXME comment about memory leaks.
12086 (syms_of_charset): Don't assume xmalloc returns.
12087
5637687f
PE
12088 Don't assume that stated character widths fit in int.
12089 * character.c (Fchar_width, c_string_width, lisp_string_width):
12090 * character.h (CHAR_WIDTH):
12091 * indent.c (MULTIBYTE_BYTES_WIDTH):
12092 Use sanitize_char_width to avoid undefined and/or bad behavior
12093 with outlandish widths.
a66cfb1c 12094 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
12095 now that we have two such functions. All uses changed.
12096 (sanitize_char_width): New inline function.
12097
a2271ba2
PE
12098 Don't assume that tab-width fits in int.
12099 * character.h (sanitize_width): New inline function.
12100 (SANE_TAB_WIDTH): New macro.
12101 (ASCII_CHAR_WIDTH): Use it.
12102 * indent.c (sane_tab_width): Remove. All uses replaced by
12103 SANE_TAB_WIDTH (current_buffer).
12104 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
12105
18c52557
PE
12106 * fileio.c: Integer overflow issues with file modes.
12107 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
12108
caeeedc1
PE
12109 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
12110 Remove unreachable code.
12111 (read_hex, load_charset_map_from_file): Check for integer overflow.
12112
6df6ae42 12113 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
12114 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
12115 (x_send_scroll_bar_event): Likewise. Check that the size does not
12116 exceed limits imposed by XClientMessageEvent, as well as the usual
12117 ptrdiff_t and size_t limits.
12118
b13995db
PE
12119 * keyboard.c: Overflow, signedness and related fixes.
12120 (make_lispy_movement): Use same integer type in forward decl
12121 that is used in the definition.
12122 (read_key_sequence, keyremap_step):
12123 Change bufsize argument back to int, undoing my 2011-03-30 change.
12124 We prefer signed types, and int is wide enough here.
12125 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
12126 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
12127 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
12128 length, not size_t. Use ptrdiff_t for index, not int.
12129 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
12130 possibility of integer overflow.
12131
13464394
PE
12132 Overflow, signedness and related fixes for images.
12133
12134 * dispextern.h (struct it.stack[0].u.image.image_id)
12135 (struct_it.image_id, struct image.id, struct image_cache.size)
12136 (struct image_cache.used, struct image_cache.ref_count):
12137 * gtkutil.c (update_frame_tool_bar):
12138 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
12139 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
12140 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
12141 * nsmenu.m (update_frame_tool_bar):
12142 * xdisp.c (calc_pixel_width_or_height):
12143 * xfns.c (image_cache_refcount):
12144 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
12145 on typical 64-bit hosts.
12146
12147 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
12148 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
12149 Omit unnecessary casts to int.
12150 (parse_image_spec): Check that integers fall into 'int' range
12151 when the callers expect that.
12152 (image_ascent): Redo ascent calculation to avoid int overflow.
12153 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
12154 (lookup_image): Remove unnecessary tests.
12155 (xbm_image_p): Locals are now of int, not EMACS_INT,
12156 since parse_image_check makes sure they fit into int.
12157 (png_load, gif_load, svg_load_image):
12158 Prefer int to unsigned where either will do.
12159 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
12160 old tiff_error_handler and tiff_warning_handler.
12161 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
12162 stack buffer overflows. It uses only the features of vsnprintf
12163 that are common to both POSIX and native Microsoft.
12164 (tiff_error_handler, tiff_warning_handler): Use it.
12165 (tiff_load, gif_load, imagemagick_load_image):
12166 Don't assume :index value fits in 'int'.
12167 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
12168 (imagemagick_load_image): Check that crop parameters fit into
12169 the integer types that MagickCropImage accepts. Don't assume
12170 Vimagemagick_render_type has a nonnegative value. Don't assume
12171 size_t fits in 'long'.
12172 (gs_load): Use printmax_t to print the widest integers possible.
12173 Check for integer overflow when computing image height and width.
12174
c11821d4
EZ
121752011-08-26 Eli Zaretskii <eliz@gnu.org>
12176
12177 * xdisp.c (redisplay_window): Don't force window start if point
12178 will be invisible in the resulting window. (Bug#9324)
12179
0c95fcf7
EZ
121802011-08-25 Eli Zaretskii <eliz@gnu.org>
12181
12182 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
12183 the display spec is of the form `(space ...)'.
12184 (handle_display_spec): Return the value returned by
12185 handle_single_display_spec, not just 1 or zero.
12186 (handle_single_display_spec): If the display spec is of the form
12187 `(space ...)', and specifies display in the text area, return 2
12188 rather than 1.
fee65a97 12189 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
12190 accurately, and prefer exact match for point under bidi.
12191 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
12192
12193 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
12194 into disp_prop; all users changed.
12195
12196 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
12197 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
12198 for the text covered by the display property.
12199
e4ed06f1
CY
122002011-08-25 Chong Yidong <cyd@stupidchicken.com>
12201
12202 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
12203 Change return value to nil.
12204 (Frecord_buffer): Delete unused function.
12205
f67cdd7f
EZ
122062011-08-24 Eli Zaretskii <eliz@gnu.org>
12207
5980d4c6
EZ
12208 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
12209 buffers, return left-to-right.
8610fe8b
EZ
12210 (set_cursor_from_row): Consider candidate row a win if its glyph
12211 represents a newline and point is on that newline. Fixes cursor
12212 positioning on the newline at EOL of R2L text within L2R
12213 paragraph, and vice versa.
12214 (try_cursor_movement): Check continued rows, in addition to
12215 continuation rows. Fixes unwarranted scroll when point enters a
12216 continued line of R2L text within an L2R paragraph, or vice versa.
12217 (cursor_row_p): Consider the case of point being equal to
12218 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
12219 from the end of a short line to the beginning of a continued line
12220 of R2L text within L2R paragraph.
12221 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
12222 composed characters.
5980d4c6 12223
f67cdd7f
EZ
12224 * bidi.c (bidi_check_type): Use xassert.
12225 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
12226 members.
12227
bca633fb
EZ
122282011-08-23 Eli Zaretskii <eliz@gnu.org>
12229
12230 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
12231 a character.
12232
4a5885a7
CY
122332011-08-23 Chong Yidong <cyd@stupidchicken.com>
12234
12235 * nsfont.m (ns_otf_to_script): Fix typo.
12236
0902a04e
KH
122372011-08-22 Kenichi Handa <handa@m17n.org>
12238
12239 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
12240 extra slot even if the purpose is char-code-property-table.
12241
1a2e6670
EZ
122422011-08-23 Eli Zaretskii <eliz@gnu.org>
12243
8ddde651
EZ
12244 * xdisp.c (redisplay_window): When computing centering_position,
12245 account for the height of the header line. (Bug#8874)
12246
425cc014
EZ
12247 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
12248 instead of CHAR_TO_BYTE. Fixes a crash when a completion
12249 candidate is selected by the mouse, and that candidate has a
12250 composed character under the mouse.
12251
1a2e6670
EZ
12252 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
12253 coordinates reported by pos-visible-in-window-p for a composed
12254 character in column zero.
12255
8b76d6f8
SM
122562011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
12257
12258 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
12259
dac347dd
EZ
122602011-08-22 Eli Zaretskii <eliz@gnu.org>
12261
12262 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
12263 consider it a hit if to_charpos is anywhere in the range of the
12264 composed buffer positions.
12265
e013fb34
CY
122662011-08-22 Chong Yidong <cyd@stupidchicken.com>
12267
12268 * image.c (gif_load): Don't assume that each subimage has the same
12269 dimensions as the base image. Handle disposal method that is
12270 "undefined" by the gif spec (Bug#9335).
12271
bd1ba3e8
CY
122722011-08-20 Chong Yidong <cyd@stupidchicken.com>
12273
12274 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 12275 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 12276
54a1215b
EZ
122772011-08-19 Eli Zaretskii <eliz@gnu.org>
12278
823564e5
EZ
12279 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
12280 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
12281 from an Org mode buffer to a Speedbar frame.
12282
54a1215b
EZ
12283 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
12284 a composition, take its buffer position from IT->cmp_it.charpos.
12285 Fixes cursor positioning at the beginning of a line that begins
12286 with a composed character.
12287
9778ebcc
EZ
122882011-08-18 Eli Zaretskii <eliz@gnu.org>
12289
0be6ee06
EZ
12290 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
12291 character bidirectional type, use STRONG_L instead. Fixes crashes
12292 in a buffer produced by `describe-categories'.
12293
9778ebcc
EZ
12294 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
12295 members before the level stack, so they would be saved and
12296 restored when copying iterator state. Fixes incorrect reordering
12297 around TABs covered by display properties.
12298
156bffbe
AS
122992011-08-18 Andreas Schwab <schwab@linux-m68k.org>
12300
6b02f655 12301 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 12302
72ad093b
CY
123032011-08-17 Chong Yidong <cyd@stupidchicken.com>
12304
12305 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
12306 (internal_condition_case_2, internal_condition_case_n):
12307 Remove unnecessary aborts (Bug#9081).
72ad093b 12308
35774242
EZ
123092011-08-17 Eli Zaretskii <eliz@gnu.org>
12310
12311 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
12312 has no `load' handler, try opening the file locally. (Bug#9311)
12313
db76dd85
KB
123142011-08-16 Ken Brown <kbrown@cornell.edu>
12315
12316 * gmalloc.c: Expand comment.
12317
b215eee5
EZ
123182011-08-16 Eli Zaretskii <eliz@gnu.org>
12319
12320 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
12321 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
12322
a4579d33
KB
123232011-08-16 Ken Brown <kbrown@cornell.edu>
12324
12325 Fix memory allocation problems in Cygwin build (Bug#9273).
12326
12327 * unexcw.c ( __malloc_initialized): Declare external variable.
12328 (fixup_executable): Force the dumped emacs to reinitialize malloc.
12329
8b76d6f8
SM
12330 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
12331 New variables.
a4579d33
KB
12332 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
12333 dumped emacs.
12334 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
12335 in the static heap.
12336 [CYGWIN] (special_realloc): New function.
12337 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
12338 requests to realloc storage in the static heap.
12339
3ebec551
PE
123402011-08-15 Paul Eggert <eggert@cs.ucla.edu>
12341
12342 * bidi.c (bidi_initialize): Remove unused local.
12343
9fd8be00
EZ
123442011-08-15 Eli Zaretskii <eliz@gnu.org>
12345
6b02f655
SM
12346 * bidimirror.h:
12347 * biditype.h: Remove file.
12348 * makefile.w32-in ($(BLD)/bidi.$(O)):
12349 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
12350
12351 * dispextern.h: Fix a typo in the comment to bidi_type_t.
12352
12353 * chartab.c: Improve commentary for the uniprop_table API.
12354
32413314
EZ
12355 * bidi.c (bidi_paragraph_init): Support zero value of
12356 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
12357 (bidi_initialize): Use uniprop_table instead of including
12358 biditype.h and bidimirror.h.
32413314 12359
9fd8be00
EZ
12360 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
12361 coordinates of the iterator when restoring from ppos_it.
12362 (Bug#9296)
12363
5cf2b69b
KH
123642011-08-14 Kenichi Handa <handa@m17n.org>
12365
12366 * process.c (create_process): Call setup_process_coding_systems
72ad093b 12367 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 12368
daf17d00
EZ
123692011-08-14 Eli Zaretskii <eliz@gnu.org>
12370
12371 * xdisp.c (move_it_in_display_line_to): Don't invoke
12372 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
12373 ppos_it. Fixes vertical cursor motion when line beginning is
12374 covered by an image. (Bug#9296)
12375
08e3161a
JD
123762011-08-14 Jan Djärv <jan.h.d@swipnet.se>
12377
12378 * nsterm.h (ns_run_ascript): Declare.
12379 (NSAPP_DATA2_RUNASSCRIPT): Define.
12380
12381 * nsfns.m (as_script, as_result, as_status): New static variables.
12382 (ns_run_ascript): New function.
5e617bc2 12383 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
12384 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
12385 the event loop. Get status from as_status (Bug#7276).
12386
12387 * nsterm.m (sendEvent): If event is NSApplicationDefined and
12388 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
12389 the event loop (Bug#7276).
12390
a3720aa2
AS
123912011-08-14 Andreas Schwab <schwab@linux-m68k.org>
12392
12393 * gnutls.c (QCgnutls_bootprop_priority)
12394 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
12395 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
12396 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
12397 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
12398 (QCgnutls_bootprop_verify_hostname_error)
12399 (QCgnutls_bootprop_callbacks_verify): Rename from
12400 Qgnutls_bootprop_..., all uses changed.
12401
12402 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
12403 uses changed.
12404
0a0d27fb
PE
124052011-08-14 Paul Eggert <eggert@cs.ucla.edu>
12406
19d5c50c
PE
12407 * xfaces.c (Qframe_set_background_mode): Now static.
12408 * dispextern.h (Qframe_set_background_mode): Remove decl.
12409
0a0d27fb
PE
12410 * process.c (Fnetwork_interface_info): Declare local only if needed.
12411
377538cb
JD
124122011-08-13 Jan Djärv <jan.h.d@swipnet.se>
12413
12414 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
12415 (Fnetwork_interface_list): Allocate in increments of bytes instead
12416 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
12417 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
12418 sockaddr.
12419 (struct ifflag_def): notrailers is smart on OSX.
12420 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
12421 Get hardware address with getifaddrs if available.
12422
08fff70c
EZ
124232011-08-12 Eli Zaretskii <eliz@gnu.org>
12424
12425 * xdisp.c (iterate_out_of_display_property): xassert that
12426 IT->position is set to within IT->object's boundaries. Break from
12427 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
12428 when IT->position is set up wrongly due to some bug.
12429 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
12430 (push_display_prop): Allow GET_FROM_STRING as IT->method on
12431 entry. Force push_it to save on the stack the current
12432 buffer/string position, to be restored by pop_it. Fix flags in
12433 the iterator structure wrt the object coming from a display
12434 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
12435 properties. (Bug#9284)
12436
7be1c708 124372011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 12438
7be1c708
CY
12439 * fontset.c (fontset_get_font_group): Add proper type checks.
12440 (Bug#9172)
aac0c6e3 12441
7be1c708 124422011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 12443
7be1c708
CY
12444 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
12445 and LC_VERSION_MIN_MACOSX.
12446 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
12447 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 12448
97bb72a6
EZ
124492011-08-08 Eli Zaretskii <eliz@gnu.org>
12450
12451 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
12452 no-display-properties-and-no-overlays under bidi display.
12453 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 12454 properties and overlays.
97bb72a6 12455
d5617611
CY
124562011-08-08 Chong Yidong <cyd@stupidchicken.com>
12457
37e11a63
CY
12458 * editfns.c (Fset_time_zone_rule): Document relationship with the
12459 setenv function.
12460
d5617611
CY
12461 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
12462 the font entity extracted from the cache (Bug#8109).
12463
58872834
CY
124642011-08-07 Chong Yidong <cyd@stupidchicken.com>
12465
12466 * composite.c (autocmp_chars): Don't reset point. That is done by
12467 restore_point_unwind (Bug#5984).
12468
75bfc667
JL
124692011-08-07 Juri Linkov <juri@jurta.org>
12470
12471 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
12472 to show the arg `TIME' instead of `TIMEVAL'.
12473
d1410150
EZ
124742011-08-06 Eli Zaretskii <eliz@gnu.org>
12475
12476 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
12477 display property strides EOL and includes a newline, as in
12478 longlines-mode. (Bug#9254)
75b771e4
EZ
12479 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
12480 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
12481
12482 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
12483 is non-zero, even if the data buffer is NULL. Fixes a crash in
12484 vertical-motion with longlines-mode. (Bug#9254)
12485
35928349
EZ
124862011-08-05 Eli Zaretskii <eliz@gnu.org>
12487
ec7cc85b
EZ
12488 * bidi.c <bidi_cache_total_alloc>: Now static.
12489 (bidi_initialize): Initialize bidi_cache_total_alloc.
12490
8b76d6f8 12491 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
12492 cache. (Bug#9221)
12493
12494 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
12495 amount allocated this far in `bidi_cache_total_alloc'.
12496 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
12497 non-zero, only free the data buffer without restoring the cache
12498 contents. All callers changed.
12499
12500 * dispextern.h (bidi_unshelve_cache): Update prototype.
12501
12502 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
12503 (move_it_in_display_line, move_it_to)
12504 (move_it_vertically_backward, move_it_by_lines): Replace the call
12505 to xfree to an equivalent call to bidi_unshelve_cache.
12506 (move_it_in_display_line_to): Fix logic of returning
412b6358 12507 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 12508
e2e2423b
EZ
125092011-08-05 Eli Zaretskii <eliz@gnu.org>
12510
12511 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
12512 came from a string character with a `cursor' property. (Bug#9229)
12513
ae9e757a
JD
125142011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12515
12516 * Makefile.in (LIB_PTHREAD): New variable.
12517 (LIBES): Add LIB_PTHREAD (Bug#9216).
12518
12519 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
12520 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
12521
213bd7f2
AS
125222011-08-04 Andreas Schwab <schwab@linux-m68k.org>
12523
6b02f655 12524 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 12525
99aaf75f
JD
125262011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12527
12528 * xterm.c (x_find_topmost_parent): New function.
12529 (x_set_frame_alpha): Find topmost parent window with
12530 x_find_topmost_parent and set the property there also (bug#9181).
12531 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
12532
c74e9d86
PE
125332011-08-04 Paul Eggert <eggert@cs.ucla.edu>
12534
12535 * callproc.c (Fcall_process): Avoid vfork clobbering
12536 the local vars buffer, coding_systems, current_dir.
12537
640c8776
SM
125382011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
12539
12540 * keymap.c (Fmake_composed_keymap): Move to subr.el.
12541
f26d0e4c
PE
125422011-08-03 Paul Eggert <eggert@cs.ucla.edu>
12543
8a10d76c
PE
12544 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
12545 so that it is not optimized away.
12546
f26d0e4c
PE
12547 * xdisp.c (compute_display_string_pos): Remove unused local.
12548
55439c61
EZ
125492011-08-02 Eli Zaretskii <eliz@gnu.org>
12550
12551 Fix slow cursor motion and scrolling in large buffers with
12552 selective display, like Org Mode buffers. (Bug#9218)
12553
12554 * dispextern.h (struct bidi_it): New member disp_prop_p.
12555
12556 * xdisp.c: Remove one-slot cache of display string positions.
12557 (compute_display_string_pos): Accept an additional argument
5e617bc2 12558 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
12559 for a display string or property. If found, set DISP_PROP_P
12560 non-zero.
12561
12562 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
12563 DISP_PROP_P, and pass it to compute_display_string_pos.
12564 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
12565 non-zero. All callers of bidi_fetch_char changed.
12566
fb33fa43
SM
125672011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
12568
12569 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
12570
b099e063
DM
125712010-12-03 Don March <don@ohspite.net>
12572
12573 * keymap.c (Fdefine_key): Fix non-prefix key error message when
12574 last character M-[char] is translated to ESC [char] (bug#7541).
12575
5cc7f7af
KH
125762011-08-02 Kenichi Handa <handa@m17n.org>
12577
d0fffa3f 12578 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
12579
12580 * chartab.c (uniprop_table): Make it non-static.
12581
525d5e6e
EZ
125822011-08-01 Eli Zaretskii <eliz@gnu.org>
12583
12584 * xdisp.c (forward_to_next_line_start): Accept additional argument
12585 BIDI_IT_PREV, and store into it the state of the bidi iterator had
12586 on the newline.
12587 (reseat_at_next_visible_line_start): Use the bidi iterator state
12588 returned by forward_to_next_line_start to restore the state of
12589 it->bidi_it after backing up to previous newline. (Bug#9212)
12590
31011111
AS
125912011-07-30 Andreas Schwab <schwab@linux-m68k.org>
12592
12593 * regex.c (re_comp): Protoize.
12594 (re_exec): Fix return type.
12595 (regexec): Fix type of `ret'. (Bug#9203)
12596
476371c4
PE
125972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12598
e5d76069
PE
12599 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
12600 This is needed if max-image-size is a floating-point number.
12601
9a79b20c
AS
126022011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12603
12604 * print.c (print_object): Print empty symbol as ##.
12605
12606 * lread.c (read1): Read ## as empty symbol.
12607
d8c2fa78
AA
126082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
12609
12610 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
12611 setting frame foreground color (Bug#9175).
12612 (x_set_background_color): Likewise.
12613
ffe57a7a
AA
12614 * nsmenu.m (-setText): Size tooltip dimensions precisely to
12615 contents (Bug#9176).
12616 (EmacsTooltip -init): Remove bezels and add shadows to
12617 tooltip windows.
12618
bf3492a5
AA
12619 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
12620 or scroll bar (Bug#8470).
12621
d55e9c53
AA
12622 * nsfont.m (nsfont_open): Remove assignment to voffset and
12623 unnecessary vars hshink, expand, hd, full_height, min_height.
12624 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
12625
12626 * nsterm.h (nsfont_info): Remove voffset field.
12627
d8c2fa78 126282011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
12629
12630 Implement strike-through and overline on NextStep (Bug#8863).
12631
12632 * nsfont.m (nsfont_open): Use underline position provided by font,
12633 instead of hard-coded value of 2.
12634 (nsfont_draw): Call ns_draw_text_decoration instead.
12635
12636 * nsterm.h: Add declaration for ns_draw_text_decoration.
12637
12638 * nsterm.m (ns_draw_text_decoration): New function for drawing
12639 underline, overline, and strike-through.
12640 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
12641 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 12642 accommodate underlining, etc.
4843aac3 12643
4cc60b9b
EZ
126442011-07-28 Eli Zaretskii <eliz@gnu.org>
12645
bc7ece87
EZ
12646 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
12647 default.
4cc60b9b 12648
476371c4
PE
126492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12650
66606eea
PE
12651 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
12652 Without this fix, if a signal arrives just after memory fills up,
12653 'malloc' might be invoked reentrantly.
12654
476371c4
PE
12655 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
12656 In other words, assume that every image size is allowed, on non-X
12657 hosts. This assumption is probably wrong, but it lets Emacs compile.
12658
f3fcc40d
AS
126592011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12660
12661 * regex.c (re_iswctype): Convert return values to boolean.
12662
350c992f
EZ
126632011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
12664
12665 * xdisp.c (compute_display_string_pos): Don't use cached display
12666 string position if the buffer had its restriction changed.
12667 (Bug#9184)
12668
5266b4bb
PE
126692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12670
12671 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12672
2573a837 126732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 12674
41f55ccd 12675 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 12676
39e378da
PE
12677 * bidi.c: Integer size and overflow fixes.
12678 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
12679 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
12680 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12681 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
12682 (bidi_find_other_level_edge):
12683 Use ptrdiff_t instead of EMACS_INT where either will do.
12684 This works better on 32-bit hosts configured --with-wide-int.
12685 (bidi_cache_ensure_space): Check for size-calculation overflow.
12686 Use % rather than repeated addition, for better worst-case speed.
12687 Don't set bidi_cache_size until after xrealloc returns, because it
12688 might not return.
12689 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
12690 (bidi_cache_ensure_space): Also check that the bidi cache size
12691 does not exceed that of the largest Lisp string or buffer. See Eli
12692 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 12693
5e927815
PE
12694 * alloc.c (__malloc_size_t): Remove.
12695 All uses replaced by size_t. See Andreas Schwab's note
12696 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
12697
ca4aa935
PE
12698 * image.c: Improve checking for integer overflow.
12699 (check_image_size): Assume that f is nonnull, since
12700 it is always nonnull in practice. This is one less thing to
12701 worry about when checking for integer overflow later.
12702 (x_check_image_size): New function, which checks for integer
12703 overflow issues inside X.
12704 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
12705 This removes the need for a memory_full check.
12706 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
12707 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
12708 (xbm_read_bitmap_data): Change locals back to 'int', since
12709 their values must fit in 'int'.
12710 (xpm_load_image, png_load, tiff_load):
12711 Invoke x_create_x_image_and_pixmap earlier,
12712 to avoid much needless work if the image is too large.
12713 (tiff_load): Treat overly large images as if
12714 x_create_x_image_and_pixmap failed, not as malloc failures.
12715 (gs_load): Use x_check_image_size.
12716
5f8f9cc2
PE
12717 * gtkutil.c: Omit integer casts.
12718 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
12719 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
12720
5adf60bc
PE
12721 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
12722
c8907a93
PE
12723 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
12724 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
12725 would wrongly return t on a 64-bit host.
12726
e3c25c68
PE
12727 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
12728 The plain *_OVERFLOW macros run afoul of GCC bug 49705
12729 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
12730 and therefore cause GCC to emit a bogus diagnostic in some cases.
12731
3f791afe
PE
12732 * image.c: Integer signedness and overflow and related fixes.
12733 This is not an exhaustive set of fixes, but it's time to
12734 record what I've got.
12735 (lookup_pixel_color, check_image_size): Remove redundant decls.
12736 (check_image_size): Don't assume that arbitrary EMACS_INT values
12737 fit in 'int', or that arbitrary 'double' values fit in 'int'.
12738 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
12739 (tiff_load, imagemagick_load_image):
12740 Check for overflow in size calculations.
12741 (x_create_x_image_and_pixmap): Remove unnecessary test for
12742 xmalloc returning NULL; that can't happen.
12743 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
12744 (xpm_color_bucket): Use better integer hashing function.
12745 (xpm_cache_color): Don't possibly over-allocate memory.
12746 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
12747 (gif_memory_source):
12748 Use ptrdiff_t, not int or size_t, to record sizes.
12749 (png_load): Don't assume values greater than 2**31 fit in 'int'.
12750 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
12751 either works, as we prefer signed integers.
12752 (tiff_read_from_memory, tiff_write_from_memory):
12753 Return tsize_t, not size_t, since that's what the TIFF API wants.
12754 (tiff_read_from_memory): Don't fail simply because the read would
12755 go past EOF; instead, return a short read.
12756 (tiff_load): Omit no-longer-needed casts.
12757 (Fimagemagick_types): Don't assume size fits into 'int'.
12758
3cc5a532
PE
12759 Improve hashing quality when configured --with-wide-int.
12760 * fns.c (hash_string): New function, taken from sxhash_string.
12761 Do not discard information about ASCII character case; this
12762 discarding is no longer needed.
12763 (sxhash-string): Use it. Change sig to match it. Caller changed.
12764 * lisp.h: Declare it.
12765 * lread.c (hash_string): Remove, since we now use fns.c's version.
12766 The fns.c version returns a wider integer if --with-wide-int is
12767 specified, so this should help the quality of the hashing a bit.
12768
b312a492
PE
12769 * emacs.c: Integer overflow minor fix.
12770 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
12771 Define only if GNU_LINUX.
12772 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
12773
dfd153ae
PE
12774 * dispnew.c: Integer signedness and overflow fixes.
12775 Remove unnecessary forward decls, that were a maintenance hassle.
12776 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
12777 All uses changed.
12778 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
12779 (scrolling_window): Use ptrdiff_t, not int, for byte count.
12780 (prepare_desired_row, line_draw_cost):
12781 Use int, not unsigned, where either works.
12782 (save_current_matrix, restore_current_matrix):
12783 Use ptrdiff_t, not size_t, where either works.
12784 (init_display): Check for overflow more accurately, and without
12785 relying on undefined behavior.
12786
a81d11a3
PE
12787 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
12788 Remove, replacing with the new symbols in lisp.h. All uses changed.
12789 * fileio.c (make_temp_name):
12790 * filelock.c (lock_file_1, lock_file):
12791 * xdisp.c (message_dolog):
12792 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
12793 Use pMd etc. instead.
12794 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
12795 replacing the pWIDE etc. symbols removed from editfns.c.
12796
3300e6fd
PE
12797 * keyboard.h (num_input_events): Now uintmax_t.
12798 This is (very slightly) less likely to mess up due to wraparound.
12799 All uses changed.
12800
fd05c7e9
PE
12801 * buffer.c: Integer signedness fixes.
12802 (alloc_buffer_text, enlarge_buffer_text):
12803 Use ptrdiff_t rather than size_t when either will do, as we prefer
12804 signed integers.
12805
903fe15d
PE
12806 * alloc.c: Integer signedness and overflow fixes.
12807 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
12808 (__malloc_size_t): Default to size_t, not to int.
12809 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
12810 (Fgarbage_collect, mark_object_loop_halt, mark_object):
12811 Prefer ptrdiff_t to size_t when either would do, as we prefer
12812 signed integers.
12813 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
12814 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
12815 Now const. Initialize with values that are in range even if char
12816 is signed.
12817 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
12818 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
12819 These functions do the right thing with sizes > 2**32.
12820 (check_depth): Now ptrdiff_t, not int.
12821 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
12822 Adjust to new way of storing sizes. Check for size overflow bugs
12823 in rest of code.
12824 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
12825 slightly wrong anyway, as it missed one instance of
12826 XMALLOC_OVERRUN_CHECK_OVERHEAD.
12827 (refill_memory_reserve): Omit needless cast to size_t.
12828 (mark_object_loop_halt): Mark as externally visible.
12829
ac82cc6a
PE
12830 * xselect.c: Integer signedness and overflow fixes.
12831 (Fx_register_dnd_atom, x_handle_dnd_message):
12832 Use ptrdiff_t, not size_t, since we prefer signed.
12833 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
12834 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
12835 x_dnd_atoms_size and x_dnd_atoms_length.
12836
c2d1e36d
PE
12837 * doprnt.c: Prefer signed to unsigned when either works.
12838 * eval.c (verror):
12839 * doprnt.c (doprnt):
12840 * lisp.h (doprnt):
12841 * xdisp.c (vmessage):
12842 Use ptrdiff_t, not size_t, when using or implementing doprnt,
12843 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
12844 prefer signed arithmetic to avoid comparison confusion.
12845 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
12846 but is a bit tricky.
12847
0e926e56
PE
12848 Assume freestanding C89 headers, string.h, stdlib.h.
12849 * data.c, doprnt.c, floatfns.c, print.c:
12850 Include float.h unconditionally.
12851 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
12852 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
12853 * regex.c: Likewise for stddef.h, string.h.
12854 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
12855 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
12856 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
12857 (STDC_HEADERS): Remove obsolete defines.
12858 * sysdep.c: Include limits.h unconditionally.
12859
9cfdb3ec
PE
12860 Assume support for memcmp, memcpy, memmove, memset.
12861 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
12862 * regex.c (memcmp, memcpy):
12863 Remove; we assume C89 now.
12864
12865 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
12866 (__malloc_safe_bcopy): Remove; no longer needed.
12867
cf950e6b 12868 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
12869 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
12870 well either way, and we prefer signed to unsigned.
12871
dbf38e02
LMI
128722011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
12873
12874 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
12875 closes the connection while we're reading (bug#9182).
12876
d6f0886c 128772011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 12878
d6f0886c
JD
12879 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
12880 are specified (Bug#9168).
24e0f6b1 12881
2eb1f9e6
PE
128822011-07-25 Paul Eggert <eggert@cs.ucla.edu>
12883
12884 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
12885 Found by GCC static checking and --with-wide-int on a 32-bit host.
12886
22381272 128872011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
12888
12889 * xdisp.c (compute_display_string_pos): Fix logic of caching
12890 previous display string position. Initialize cached_prev_pos to
12891 -1. Fixes slow-down at the beginning of a buffer.
12892
f25e39b4
EZ
128932011-07-24 Eli Zaretskii <eliz@gnu.org>
12894
12895 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
12896 for attrs[LFACE_FONTSET_INDEX].
12897
04c4b52e
PE
128982011-07-23 Paul Eggert <eggert@cs.ucla.edu>
12899
12900 * xml.c (parse_region): Remove unused local
12901 that was recently introduced.
12902
c1734fbd
EZ
129032011-07-23 Eli Zaretskii <eliz@gnu.org>
12904
be18c5a5
EZ
12905 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
12906 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
12907
c1734fbd
EZ
12908 * xdisp.c (move_it_in_display_line_to): Record the best matching
12909 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
12910 exit if none of the characters scanned was an exact match.
12911 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
12912 when exact match is impossible due to invisible text, and the
12913 lines are truncated.
12914
a258d627
JD
129152011-07-23 Jan Djärv <jan.h.d@swipnet.se>
12916
12917 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
12918 for OSX >= 10.7.
12919
b6d5a689
EZ
129202011-07-22 Eli Zaretskii <eliz@gnu.org>
12921
0f74f785
EZ
12922 Fix a significant slow-down of cursor motion with C-n, C-p,
12923 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
12924 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 12925 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
12926 (next_element_from_buffer): Call compute_stop_pos_backwards to
12927 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
12928 base_level_stop.
12929 (reseat): Don't look for prev_stop, as that could mean a very long
12930 run.
12931 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
12932 <cached_disp_overlay_modiff>: Cache for last found display string
12933 position.
551918c1 12934 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
12935 about the same buffer in the same area of character positions, and
12936 the buffer wasn't changed since the time the display string
12937 position was cached.
551918c1 12938
b2d0c91a
EZ
129392011-07-22 Eli Zaretskii <eliz@gnu.org>
12940
12941 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
12942 is an integer, which is important for empty lines. (Bug#9149)
12943
043604ee
CY
129442011-07-22 Chong Yidong <cyd@stupidchicken.com>
12945
12946 * frame.c (Fmodify_frame_parameters): In tty case, update the
12947 default face if necessary (Bug#4238).
12948
da4adb04
CY
129492011-07-21 Chong Yidong <cyd@stupidchicken.com>
12950
12951 * editfns.c (Fstring_to_char): No need to explain what a character
12952 is in the docstring (Bug#6576).
12953
9abd0532
LMI
129542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12955
12956 * xml.c (parse_region): Make sure we always return a tree.
12957
36881d16
HK
129582011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12959
12960 * xml.c (parse_region): If a document contains only comments,
12961 return that, too.
12962
1e98674d
LMI
129632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12964
12965 * xml.c (make_dom): Return comments, too.
12966
590bd467
PE
129672011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12968
12969 Port to OpenBSD.
12970 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12971 and the surrounding thread.
12972 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12973 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12974 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12975 timer goes off.
12976 * s/openbsd.h (BROKEN_SIGIO): Define.
12977 * unexelf.c (unexec) [__OpenBSD__]:
12978 Don't update the .mdebug section of the Alpha COFF symbol table.
12979
f41628b2
LMI
129802011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12981
12982 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12983 (bug#8460).
12984
b59b67c5
PE
129852011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12986
15e3a074
PE
12987 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12988 This fixes some race conditions on the permissions of any newly
12989 created file.
12990
41bed37d
PE
12991 * alloc.c (valid_pointer_p): Use pipe, not open.
12992 This fixes some permissions issues when debugging.
12993
b59b67c5
PE
12994 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12995 If fchown fails to set both uid and gid, try to set just gid,
12996 as that is sometimes allowed. Adjust the file's mode to eliminate
12997 setuid or setgid bits that are inappropriate if fchown fails.
12998
925a6be7
SM
129992011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
13000
13001 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
13002 to compare Lisp_Objects.
13003 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
13004 global_gnutls_log_level, don't mistake it for a Lisp_Object.
13005 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
13006
52968808
AS
130072011-07-17 Andreas Schwab <schwab@linux-m68k.org>
13008
0a6a104b
AS
13009 * lread.c (read_integer): Unread even EOF character.
13010 (read1): Likewise. Properly record start position of symbol.
13011
52968808
AS
13012 * lread.c (read1): Read `#:' as empty uninterned symbol if no
13013 symbol character follows.
13014
9e381cdd
PE
130152011-07-17 Paul Eggert <eggert@cs.ucla.edu>
13016
13017 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
13018 This works around a problem with the previous change to Fcopy_file.
13019 Recent glibc declares fchown with __attribute__((warn_unused_result)),
13020 and without this change, GCC might complain about discarding
13021 fchown's return value.
13022
b5641435
JB
130232011-07-16 Juanma Barranquero <lekktu@gmail.com>
13024
13025 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
13026
a8031457
PE
130272011-07-16 Paul Eggert <eggert@cs.ucla.edu>
13028
13029 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
13030
dd889327
LMI
130312011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
13032
750c33f7
LMI
13033 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
13034 it's used from the C level.
13035
dd889327
LMI
13036 * process.c: Use the same condition for POLL_FOR_INPUT in both
13037 keyboard.c and process.c (bug#1858).
13038
87e86684
LM
130392011-07-09 Lawrence Mitchell <wence@gmx.li>
13040
13041 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
13042 (Fgnutls_boot): Use it.
13043
64348f40
AS
130442011-07-15 Andreas Schwab <schwab@linux-m68k.org>
13045
13046 * doc.c (Fsubstitute_command_keys): Revert last change.
13047
1d698799
LMI
130482011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
13049
f863868c
LMI
13050 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
13051 quotes the next character, and doesn't affect other longer
13052 sequences (bug#8935).
13053
1d698799
LMI
13054 * lread.c (syms_of_lread): Clarify that is isn't only
13055 `eval-buffer' and `eval-defun' that's affected by
13056 `lexical-binding' (bug#8460).
13057
aa4b6df6
EZ
130582011-07-15 Eli Zaretskii <eliz@gnu.org>
13059
13060 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 13061 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 13062
5d856da6
PE
130632011-07-14 Paul Eggert <eggert@cs.ucla.edu>
13064
ad6042bb
PE
13065 Fix minor problems found by static checking.
13066 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
13067 (elsz): Now a signed constant, not a size_t var. We prefer signed
13068 types to unsigned, to avoid integer comparison confusion. Without
13069 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
13070 "cannot optimize loop, the loop counter may overflow", a symptom
13071 of the confusion.
f00bbb22 13072 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
13073 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
13074
6468f31c
LMI
130752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
13076
49080b10
LMI
13077 * search.c (Fre_search_backward): Mention `case-fold-search' in
13078 all the re_search_* functions (bug#8138).
13079
6468f31c
LMI
13080 * keyboard.c (Fopen_dribble_file): Document when the file is
13081 closed (bug#8056).
13082
c965adc5
EZ
130832011-07-14 Eli Zaretskii <eliz@gnu.org>
13084
df9733bf
EZ
13085 * bidi.c (bidi_dump_cached_states): Fix format of displaying
13086 bidi_cache_idx.
13087
0bb23927
EZ
13088 Support bidi reordering of display and overlay strings.
13089 * xdisp.c (compute_display_string_pos)
13090 (compute_display_string_end): Accept additional argument STRING.
13091 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
13092 (reseat_to_string): Initialize bidi_it->string.s and
13093 bidi_it->string.schars.
13094 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
13095 NULL (avoids a crash in bidi_paragraph_init).
13096 Initialize itb.string.lstring.
0bb23927
EZ
13097 (init_iterator): Call bidi_init_it only of a valid
13098 buffer position was specified. Initialize paragraph_embedding to
13099 L2R.
13100 (reseat_to_string): Initialize the bidi iterator.
13101 (display_string): If we need to ignore text properties of
13102 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
13103 original value of -1 will not work with bidi.)
13104 (compute_display_string_pos): First arg is now struct
13105 `text_pos *'; all callers changed. Support display properties on
13106 Lisp strings.
13107 (compute_display_string_end): Support display properties on Lisp
13108 strings.
13109 (init_iterator, reseat_1, reseat_to_string): Initialize the
13110 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
13111 when iterating on a string not from display properties).
640c8776
SM
13112 (compute_display_string_pos, compute_display_string_end):
13113 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
13114 arrow keys.
13115 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
13116 base_level_stop; instead, set base_level_stop to BEGV.
13117 Fixes crashes in vertical-motion.
0bb23927
EZ
13118 (next_element_from_buffer): Improve commentary for when
13119 the iterator is before prev_stop.
13120 (init_iterator): Initialize bidi_p from the default value of
13121 bidi-display-reordering, not from buffer-local value. Use the
13122 buffer-local value only if initializing for buffer iteration.
13123 (handle_invisible_prop): Support invisible properties on strings
13124 that are being bidi-reordered.
13125 (set_iterator_to_next): Support bidi reordering of C strings and
13126 Lisp strings.
13127 (next_element_from_string): Support bidi reordering of Lisp
13128 strings.
13129 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
13130 (display_string): Support display of R2L glyph rows.
13131 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
13132 (init_iterator): Don't initialize it->bidi_p for strings
13133 here.
13134 (reseat_to_string): Initialize it->bidi_p for strings here.
13135 (next_element_from_string, next_element_from_c_string)
13136 (next_element_from_buffer): Add xassert's for correspondence
13137 between IT's object being iterated and it->bidi_it.string
13138 structure.
13139 (face_before_or_after_it_pos): Support bidi iteration.
13140 (next_element_from_c_string): Handle the case of the first string
13141 character that is not the first one in the visual order.
13142 (get_visually_first_element): New function, refactored from common
13143 parts of next_element_from_buffer, next_element_from_string, and
13144 next_element_from_c_string.
13145 (tool_bar_lines_needed, redisplay_tool_bar)
13146 (display_menu_bar): Force left-to-right direction. Add a FIXME
13147 comment for making that be controlled by a user option.
13148 (push_it, pop_it): Save and restore the state of the
13149 bidi iterator. Save and restore the bidi_p flag.
13150 (pop_it): Iterate out of display property for string iteration as
13151 well.
13152 (iterate_out_of_display_property): Support iteration over strings.
13153 (handle_single_display_spec): Set up it->bidi_it for iteration
13154 over a display string, and call bidi_init_it.
13155 (handle_single_display_spec, next_overlay_string)
13156 (get_overlay_strings_1, push_display_prop): Set up the bidi
13157 iterator for displaying display or overlay strings.
13158 (forward_to_next_line_start): Don't use the shortcut if
13159 bidi-iterating.
13160 (back_to_previous_visible_line_start): If handle_display_prop
13161 pushed the iterator stack, restore the internal state of the bidi
13162 iterator by calling bidi_pop_it same number of times.
13163 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
13164 and we are bidi-iterating, don't decrement the iterator position;
13165 instead, set the first_elt flag in the bidi iterator, to produce
13166 the same effect.
13167 (reseat_1): Remove redundant setting of string_from_display_prop_p.
13168 (push_display_prop): xassert that we are iterating a buffer.
13169 (push_it, pop_it): Save and restore paragraph_embedding member.
13170 (handle_single_display_spec, next_overlay_string)
13171 (get_overlay_strings_1, reseat_1, reseat_to_string)
13172 (push_display_prop): Set up the `unibyte' member of bidi_it.string
13173 correctly. Don't assume unibyte strings are not bidi-reordered.
13174 (compute_display_string_pos)
13175 (compute_display_string_end): Fix handling the case of C string.
13176 (push_it, pop_it): Save and restore from_disp_prop_p.
13177 (handle_single_display_spec, push_display_prop): Set the
13178 from_disp_prop_p flag.
13179 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
13180 (pop_it): Call iterate_out_of_display_property only if we are
13181 popping after iteration over a string that came from a display
13182 property. Fix a typo in popping stretch info. Add an assertion
13183 for verifying that the iterator position is in sync with the bidi
13184 iterator.
13185 (handle_single_display_spec, get_overlay_strings_1)
13186 (push_display_prop): Fix initialization of paragraph direction for
13187 string when that of the parent object is not yet determined.
13188 (reseat_1): Call bidi_init_it to resync the bidi
13189 iterator with IT's position. (Bug#7616)
13190 (find_row_edges): If ROW->start.pos gives position
13191 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
13192 (handle_stop, back_to_previous_visible_line_start, reseat_1):
13193 Reset the from_disp_prop_p flag.
13194 (SAVE_IT, RESTORE_IT): New macros.
13195 (pos_visible_p, face_before_or_after_it_pos)
13196 (back_to_previous_visible_line_start)
13197 (move_it_in_display_line_to, move_it_in_display_line)
13198 (move_it_to, move_it_vertically_backward, move_it_by_lines)
13199 (try_scrolling, redisplay_window, display_line): Use them when
13200 saving a temporary copy of the iterator and restoring it back.
13201 (back_to_previous_visible_line_start, reseat_1)
13202 (init_iterator): Empty the bidi cache "stack".
13203 (move_it_in_display_line_to): If iterator ended up at
13204 EOL, but we never saw any buffer positions smaller than
13205 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
13206 motion in bidi-reordered lines.
13207 (move_it_in_display_line_to): Record prev_method and prev_pos
13208 immediately before the call to set_iterator_to_next. Fixes cursor
13209 motion in bidi-reordered lines with stretch glyphs and strings
13210 displayed in margins. (Bug#8133) (Bug#8867)
13211 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
13212 TO_CHARPOS.
640c8776
SM
13213 (pos_visible_p): Support positions in bidi-reordered lines.
13214 Save and restore bidi cache.
0bb23927
EZ
13215
13216 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
13217 (bidi_paragraph_info): Delete unused struct.
13218 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
13219 (bidi_cache_start): New variable.
13220 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
13221 to zero.
13222 (bidi_cache_fetch_state, bidi_cache_search)
13223 (bidi_cache_find_level_change, bidi_cache_iterator_state)
13224 (bidi_cache_find, bidi_peek_at_next_level)
13225 (bidi_level_of_next_char, bidi_find_other_level_edge)
13226 (bidi_move_to_visually_next): Compare cache index with
13227 bidi_cache_start rather than with zero.
13228 (bidi_fetch_char): Accept new argument STRING; all callers
13229 changed. Support iteration over a string. Support strings with
13230 display properties. Support unibyte strings. Fix the type of
13231 `len' according to what STRING_CHAR_AND_LENGTH expects.
13232 (bidi_paragraph_init, bidi_resolve_explicit_1)
13233 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
13234 (bidi_level_of_next_char, bidi_move_to_visually_next):
13235 Support iteration over a string.
0bb23927
EZ
13236 (bidi_set_sor_type, bidi_resolve_explicit_1)
13237 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
13238 can now be zero (for strings); special values 0 and -1 were
13239 changed to -1 and -2, respectively.
13240 (bidi_char_at_pos): New function.
13241 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
13242 Call it instead of FETCH_MULTIBYTE_CHAR.
13243 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
13244 initialized to valid values.
13245 (bidi_init_it): Don't initialize charpos and bytepos with invalid
13246 values.
13247 (bidi_level_of_next_char): Allow the sentinel "position" to pass
13248 the test for valid cached positions. Fix the logic for looking up
13249 the sentinel state in the cache. GCPRO the Lisp string we are
13250 iterating.
13251 (bidi_push_it, bidi_pop_it): New functions.
13252 (bidi_initialize): Initialize the bidi cache start stack pointer.
13253 (bidi_cache_ensure_space): New function, refactored from part of
13254 bidi_cache_iterator_state. Don't assume the required size is just
13255 one BIDI_CACHE_CHUNK away.
13256 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
13257 (bidi_count_bytes, bidi_char_at_pos): New functions.
13258 (bidi_cache_search): Don't assume bidi_cache_last_idx is
13259 always valid if bidi_cache_idx is valid.
13260 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
13261 is valid if it's going to be used.
13262 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
13263 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
13264 (bidi_cache_find_level_change, bidi_cache_ensure_space)
13265 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
13266 (bidi_find_other_level_edge, bidi_cache_start_stack):
13267 All variables related to cache indices are now EMACS_INT.
c965adc5 13268
0bb23927
EZ
13269 * dispextern.h (struct bidi_string_data): New structure.
13270 (struct bidi_it): New member `string'. Make flag members be 1-bit
13271 fields, and put them last in the struct.
640c8776
SM
13272 (compute_display_string_pos, compute_display_string_end):
13273 Update prototypes.
0bb23927
EZ
13274 (bidi_push_it, bidi_pop_it): Add prototypes.
13275 (struct iterator_stack_entry): New members bidi_p,
13276 paragraph_embedding, and from_disp_prop_p.
13277 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
13278 (bidi_shelve_cache, bidi_unshelve_cache):
13279 Declare prototypes.
0bb23927
EZ
13280
13281 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
13282 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
13283 and vector-like objects.
13284
13285 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
13286 cache around display iteration.
13287
13288 * window.c (Fwindow_end, window_scroll_pixel_based)
13289 (displayed_window_lines, Frecenter): Save and restore the bidi
13290 cache around display iteration.
13291
3bbd2265
LMI
132922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
13293
13294 * editfns.c (Fdelete_region): Clarify the use of the named
13295 parameters (bug#6788).
13296
adc47434
MR
132972011-07-14 Martin Rudalics <rudalics@gmx.at>
13298
13299 * indent.c (Fvertical_motion): Set and restore w->pointm when
13300 saving and restoring the window's buffer (Bug#9006).
13301
837c31f8
LMI
133022011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
13303
13304 * editfns.c (Fstring_to_char): Clarify just what is returned
13305 (bug#6576). Text by Eli Zaretskii.
13306
ac389d0c
JB
133072011-07-13 Juanma Barranquero <lekktu@gmail.com>
13308
13309 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
13310
0be0ce47
EZ
133112011-07-13 Eli Zaretskii <eliz@gnu.org>
13312
13313 * buffer.c (mmap_find): Fix a typo.
13314
cd18e7e3
JB
133152011-07-13 Johan Bockgård <bojohan@gnu.org>
13316
13317 Fix execution of x selection hooks.
13318 * xselect.c (Qx_lost_selection_functions)
13319 (Qx_sent_selection_functions): New vars.
13320 (syms_of_xselect): DEFSYM them.
13321 (x_handle_selection_request): Pass Qx_sent_selection_functions
13322 rather than Vx_sent_selection_functions to Frun_hook_with_args.
13323 (x_handle_selection_clear,x_clear_frame_selections):
13324 Pass Qx_lost_selection_functions rather than
13325 Vx_lost_selection_functions to Frun_hook_with_args.
13326
47ea7f44
PE
133272011-07-13 Paul Eggert <eggert@cs.ucla.edu>
13328
ac389d0c 13329 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
13330 The old code sometimes used this field without initializing it.
13331
47ea7f44
PE
13332 * alloc.c (gc_sweep): Don't read past end of array.
13333 In theory, the old code could also have corrupted Emacs internals,
13334 though it'd be very unlikely.
13335
bc985c87
AS
133362011-07-12 Andreas Schwab <schwab@linux-m68k.org>
13337
13338 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 13339 argument. (Bug#4026)
bc985c87 13340
0cf34688
LMI
133412011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
13342
b3dadd76
LMI
13343 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
13344 key" (bug#4257).
13345
0cf34688
LMI
13346 * window.c (Fset_window_start): Doc fix (bug#4199).
13347 (Fset_window_hscroll): Ditto.
13348
270768cd
PE
133492011-07-12 Paul Eggert <eggert@cs.ucla.edu>
13350
077e3dda 13351 Fix minor new problems caught by GCC 4.6.1.
270768cd 13352 * term.c (init_tty): Remove unused local.
490011a6 13353 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 13354 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 13355 not used otherwise.
270768cd 13356
b1f58454
CY
133572011-07-12 Chong Yidong <cyd@stupidchicken.com>
13358
13359 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
13360
22b9578d
LMI
133612011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
13362
6e70ab07
LMI
13363 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
13364 are the mini-buffer and the echo area (bug#3320).
13365
22b9578d
LMI
13366 * term.c (init_tty): Remove support for supdup, c10 and perq
13367 terminals, which are no longer supported (bug#1482).
13368
8974cc9f
JB
133692011-07-10 Johan Bockgård <bojohan@gnu.org>
13370
13371 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
13372
a560d974
JD
133732011-07-10 Jan Djärv <jan.h.d@swipnet.se>
13374
13375 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
13376 for non-popups (Bug#3642).
13377
1dae0f0a
AS
133782011-07-10 Andreas Schwab <schwab@linux-m68k.org>
13379
268c2c36 13380 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 13381 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
13382 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
13383 * cm.c (losecursor): Likewise.
1dae0f0a
AS
13384 * data.c (fmod): Likewise.
13385 * dispnew.c (swap_glyphs_in_rows): Likewise.
13386 * emacs.c (memory_warning_signal): Likewise.
13387 * floatfns.c (float_error): Likewise.
13388 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
13389 (otf_open, font_otf_capability, generate_otf_features)
13390 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
13391 Likewise.
13392 * image.c (pbm_read_file): Likewise.
13393 * indent.c (string_display_width): Likewise.
13394 * intervals.c (check_for_interval, search_for_interval)
13395 (inc_interval_count, count_intervals, root_interval)
13396 (adjust_intervals_for_insertion, make_new_interval): Likewise.
13397 * lread.c (defalias): Likewise.
268c2c36 13398 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
13399 * regex.c (set_image_of_range_1, set_image_of_range)
13400 (regex_grow_registers): Likewise.
13401 * sysdep.c (strerror): Likewise.
13402 * termcap.c (valid_filename_p, tprint, main): Likewise.
13403 * tparam.c (main): Likewise.
13404 * unexhp9k800.c (run_time_remap, save_data_space)
13405 (update_file_ptrs, read_header, write_header, calculate_checksum)
13406 (copy_file, copy_rest, display_header): Likewise.
13407 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
13408 Likewise.
13409 * xdisp.c (check_it): Likewise.
13410 * xfaces.c (register_color, unregister_color, unregister_colors):
13411 Likewise.
13412 * xfns.c (print_fontset_result): Likewise.
13413 * xrdb.c (member, fatal, main): Likewise.
13414
99033785
PE
134152011-07-10 Paul Eggert <eggert@cs.ucla.edu>
13416
13417 Fix minor problems found by static checking (Bug#9031).
13418 * chartab.c (char_table_set_range, map_sub_char_table):
13419 Remove unused locals.
13420 (uniprop_table): Now static.
13421 * composite.c (_work_char): Remove unused static var.
13422
9cb2ac56
JB
134232011-07-09 Juanma Barranquero <lekktu@gmail.com>
13424
13425 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
13426
f25661f0
JD
134272011-07-09 Jan Djärv <jan.h.d@swipnet.se>
13428
13429 * gtkutil.c (qttip_cb): Remove code without function.
13430
8278c4fe
EZ
134312011-07-09 Eli Zaretskii <eliz@gnu.org>
13432
13433 * w32.c (pthread_sigmask): New stub.
13434
1692ae2d 134352011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 13436
8a6ebd58 13437 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
13438 sigprocmask is portable only for single-threaded applications, and
13439 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
13440 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
13441 (LIBES): Use it.
13442 * callproc.c (Fcall_process):
13443 * process.c (create_process):
13444 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
13445 Use pthread_sigmask, not sigprocmask.
123403e4 13446
1b854618
JD
134472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13448
13449 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
13450 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
13451 wrong (Bug#8591).
13452
3fe4b549
JD
134532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13454
0ce7e563
JD
13455 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
13456 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
13457 (xg_hide_tooltip): Fix comment.
13458
3fe4b549
JD
13459 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
13460 in registerServicesMenuSendTypes.
13461 (validRequestorForSendType): Don't check ns_return_types.
13462
13463 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
13464 ns_return_type.
13465
5df75e47
JR
134662011-07-08 Jason Rumney <jasonr@gnu.org>
13467
22610910
JR
13468 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
13469 SH_SHOW for hidden windows (Bug#5482).
13470
5df75e47
JR
13471 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
13472 frame struct members of non-existent frames (Bug#6284).
13473
699c10bd
JD
134742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13475
4393663b
JD
13476 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
13477 variable firstTime not needed on OSX >= 10.6.
13478 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
13479 >= 10.5. Use setKnobProportion, setDoubleValue.
13480
13481 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
13482 (MAC_OS_X_VERSION_10_5): Define if not defined.
13483 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
13484 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
13485 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
13486
13487 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 13488 cString and lossyCString on OSX >= 10.4.
4393663b 13489
58179cce 13490 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
13491 sizeToFit on OSX >= 10.2.
13492
13493 * nsimage.m (allocInitFromFile): Don't use deprecated method
13494 bestRepresentationForDevice on OSX >= 10.6.
13495
13496 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
13497 to avoid warning.
13498
13499 * emacs.c: Declare unexec_init_emacs_zone.
13500
a63e0781
JD
13501 * nsgui.h: Fix compiler warning about gnulib redefining verify.
13502
699c10bd
JD
13503 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
13504
13505 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
13506 on svcsMenu (Bug#8842).
13507
13508 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
13509 ns_return_types.
13510 (Fns_list_services): Just return Qnil on 10.6, code not working there.
13511
13512 * nsterm.m (QUTF8_STRING): Declare.
13513 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
13514 (validRequestorForSendType): Return type is (id).
13515 Change indexOfObjectIdenticalTo to indexOfObject.
13516 Check if we have local selection before returning self (Bug#8842).
13517 (writeSelectionToPasteboard): Put local selection into paste board
13518 if we have a local selection (Bug#8842).
13519 (syms_of_nsterm): DEFSYM QUTF8_STRING.
13520
13521 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
13522 (ns_get_local_selection): Declare.
13523
54e10184
LMI
135242011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
13525
9888ff71
LMI
13526 * keymap.c (describe_map_tree): Don't insert a double newline at
13527 the end of the buffer (bug#1169) and return whether we inserted
13528 something.
13529
54e10184
LMI
13530 * callint.c (Fcall_interactively): Change "reading args" to
13531 "providing args" to try to clarify what it does (bug#1010).
13532
15fa4783
KH
135332011-07-07 Kenichi Handa <handa@m17n.org>
13534
13535 * composite.c (composition_compute_stop_pos): Ignore a static
13536 composition starting before CHARPOS (Bug#8915).
13537
13538 * xdisp.c (handle_composition_prop): Likewise.
13539
a8815b00
EZ
135402011-07-07 Eli Zaretskii <eliz@gnu.org>
13541
13542 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
13543 (Bug#9015)
13544
ef7b981d 135452011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
13546
13547 * character.h (unicode_category_t): New enum type.
13548
13549 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
13550 (Qchar_code_property_table): New variable.
13551 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
13552 (UNIPROP_COMPRESSED_FORM_P): New macros.
13553 (char_table_ascii): Uncompress the compressed values.
13554 (sub_char_table_ref): New arg is_uniprop. Callers changed.
13555 Uncompress the compressed values.
ac389d0c 13556 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
13557 (char_table_ref_and_range): Uncompress the compressed values.
13558 (sub_char_table_set): New arg is_uniprop. Callers changed.
13559 Uncompress the compressed values.
13560 (sub_char_table_set_range): Args changed. Callers changed.
13561 (char_table_set_range): Adjuted for the above change.
13562 (map_sub_char_table): Delete args default_val and parent. Add arg
13563 top. Give decoded values to a Lisp function.
640c8776 13564 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
13565 values to a Lisp function. Gcpro more variables.
13566 (uniprop_table_uncompress)
13567 (uniprop_decode_value_run_length): New functions.
13568 (uniprop_decoder, uniprop_decoder_count): New variables.
13569 (uniprop_get_decoder, uniprop_encode_value_character)
13570 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
13571 New functions.
13572 (uniprop_encoder, uniprop_encoder_count): New variables.
13573 (uniprop_get_encoder, uniprop_table)
13574 (Funicode_property_table_internal, Fget_unicode_property_internal)
13575 (Fput_unicode_property_internal): New functions.
13576 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
13577 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 13578 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
13579 char-code-property-alist.
13580
640c8776 13581 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
13582 Vunicode_category_table.
13583
640c8776 13584 * font.c (font_range): Adjust for the change of
c805dec0
KH
13585 Vunicode_category_table.
13586
76b397fb
DN
135872011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
13588
13589 * m/iris4d.h: Remove file, move contents ...
13590 * s/irix6-5.h: ... here.
13591
22b4128e
PE
135922011-07-06 Paul Eggert <eggert@cs.ucla.edu>
13593
13594 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
13595 * alloc.c (mark_buffer):
13596 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
13597 (clone_per_buffer_values): Don't assume that
22b4128e
PE
13598 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
13599 This isn't true in general, and it's particularly not true
13600 if Emacs is configured with --with-wide-int.
13601 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
13602 New macros, used in the buffer.c change.
13603
869795d6
JD
136042011-07-05 Jan Djärv <jan.h.d@swipnet.se>
13605
13606 * xsettings.c: Use both GConf and GSettings if both are available.
13607 (store_config_changed_event): Add comment.
13608 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
13609 (store_tool_bar_style_changed): New functions.
5e617bc2 13610 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
13611 (struct xsettings): Move font inside HAVE_XFT.
13612 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 13613 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 13614 Move inside HAVE_XFT.
640c8776 13615 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
13616 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
13617 also.
13618 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 13619 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 13620 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
13621 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
13622 (parse_settings): Move check for font inside HAVE_XFT.
13623 (read_settings, apply_xft_settings): Add comment.
13624 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
13625 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
13626 call store_font_name_changed.
13627 (xft_settings_event): Add comment.
13628 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
13629 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
13630 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
13631 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
13632 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
13633 (xsettings_get_system_font, xsettings_get_system_normal_font):
13634 Add comment.
869795d6 13635
d8ed26bd
PE
136362011-07-05 Paul Eggert <eggert@cs.ucla.edu>
13637
13638 Random fixes. E.g., (random) never returned negative values.
13639 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
13640 subseconds part to the entropy, as that's a bit more random.
13641 Prefer signed to unsigned, since the signedness doesn't matter and
13642 in general we prefer signed. When given a limit, use a
13643 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
13644 latter isn't right if USE_2_TAGS_FOR_INTS.
13645 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
13646 not 0..VALMASK. Don't discard "excess" bits that random () returns.
13647
cabf1cac
SM
136482011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
13649
13650 * textprop.c (text_property_stickiness):
13651 Obey Vtext_property_default_nonsticky.
13652 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
13653 * w32fns.c (syms_of_w32fns):
13654 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
13655
6e9b2be9
PE
136562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13657
13658 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
13659 This is more efficient than Ffile_directory_p and avoids a minor race.
13660
90186c68
LMI
136612011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
13662
7c301272
LMI
13663 * buffer.c (Foverlay_put): Say what the return value is
13664 (bug#7835).
13665
c4f2d8d4
LMI
13666 * fileio.c (barf_or_query_if_file_exists): Check first if the file
13667 is a directory before asking whether to use the file name
13668 (bug#7564).
ad637907
LMI
13669 (barf_or_query_if_file_exists): Make the "File is a directory"
13670 error be more correct.
c4f2d8d4 13671
90186c68
LMI
13672 * fns.c (Frequire): Remove the mention of the .gz files, since
13673 that's installation-specific, but keep the mention of
13674 `get-load-suffixes'.
13675
da64016e
PE
136762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13677
13678 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
13679 Report string overflow if the output is too long.
13680
7d47b580
JB
136812011-07-04 Juanma Barranquero <lekktu@gmail.com>
13682
a555cb87
JB
13683 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
13684 (syms_of_gnutls): Remove duplicate DEFSYM for
13685 Qgnutls_bootprop_verify_hostname_error, an error for
13686 Qgnutls_bootprop_verify_error (which is no longer used).
13687
7d47b580
JB
13688 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
13689 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
13690 Also (re)move comments that are misplaced or no longer relevant.
13691
1e49bfab
LMI
136922011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13693
13694 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
13695
1485f4c0
CY
136962011-07-03 Chong Yidong <cyd@stupidchicken.com>
13697
13698 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
13699 and background color parameters if they have been changed.
13700
a9ab721e
LMI
137012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13702
13703 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
13704
cf7cff57
PE
137052011-07-03 Paul Eggert <eggert@cs.ucla.edu>
13706
2e13213d
PE
13707 * xsettings.c (SYSTEM_FONT): Define only when used.
13708 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
13709
cf7cff57
PE
13710 * keymap.c (access_keymap_1): Now static.
13711
7a8e04f7
CY
137122011-07-02 Chong Yidong <cyd@stupidchicken.com>
13713
13714 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
13715 leave any prefix arg for the up event (Bug#1586).
13716
61352f62
LMI
137172011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
13718
69bb1ef7
LMI
13719 * lread.c (syms_of_lread): Mention single symbols defined by
13720 `defvar' or `defconst' (bug#7154).
13721
61352f62 13722 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 13723 (Frequire): Mention get-load-suffixes.
61352f62 13724
28545e04
MR
137252011-07-02 Martin Rudalics <rudalics@gmx.at>
13726
13727 * window.h (window): Remove clone_number slot.
13728 * window.c (Fwindow_clone_number, Fset_window_clone_number):
13729 Remove.
13730 (make_parent_window, make_window, saved_window)
13731 (Fset_window_configuration, save_window_save): Don't deal with
13732 clone numbers.
13733 * buffer.c (Qclone_number): Remove declaration.
13734 (sort_overlays, overlay_strings): Don't deal with clone numbers.
13735
3349e122
SM
137362011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
13737
13738 Add multiple inheritance to keymaps.
13739 * keymap.c (Fmake_composed_keymap): New function.
13740 (Fset_keymap_parent): Simplify.
13741 (fix_submap_inheritance): Remove.
13742 (access_keymap_1): New function extracted from access_keymap to handle
13743 embedded parents and handle lists of maps.
13744 (access_keymap): Use it.
13745 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
13746 (Fcopy_keymap): Handle embedded parents.
13747 (Fcommand_remapping, define_as_prefix): Simplify.
13748 (Fkey_binding): Simplify.
13749 (syms_of_keymap): Move minibuffer-local-completion-map,
13750 minibuffer-local-filename-completion-map,
13751 minibuffer-local-must-match-map, and
13752 minibuffer-local-filename-must-match-map to Elisp.
13753 (syms_of_keymap): Defsubr make-composed-keymap.
13754 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
13755 (parse_menu_item): Trivial simplification.
13756
3279eb87
GM
137572011-07-01 Glenn Morris <rgm@gnu.org>
13758
13759 * Makefile.in (SETTINGS_LIBS): Fix typo.
13760
39cb9e56 137612011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
13762
13763 * coding.c (Fencode_coding_string): Record the last coding system
13764 used, as the function doc string says (bug#8738).
13765
0949d2b6
JD
137662011-07-01 Jan Djärv <jan.h.d@swipnet.se>
13767
13768 * xsettings.c (store_monospaced_changed): Take new font as arg and
13769 check for change against current_mono_font.
13770 (EMACS_TYPE_SETTINGS): Remove this and related defines.
13771 (emacs_settings_constructor, emacs_settings_get_property)
13772 (emacs_settings_set_property, emacs_settings_class_init)
13773 (emacs_settings_init, gsettings_obj): Remove.
13774 (something_changedCB): New function for HAVE_GSETTINGS.
13775 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
13776 with value as argument.
13777 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
13778 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 13779 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
13780 "changed".
13781
13782 * xgselect.c: Add defined (HAVE_GSETTINGS).
13783 (xgselect_initialize): Ditto.
13784
13785 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
13786 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
13787 xg_select.
13788
bbc6b304
PE
137892011-07-01 Paul Eggert <eggert@cs.ucla.edu>
13790
13791 * eval.c (struct backtrace): Simplify and port the data structure.
13792 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
13793 signed bit field, as this assumption is not portable and it makes
13794 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
13795 "char debug_on_exit : 1" as this is not portable either; instead,
13796 use the portable "unsigned int debug_on_exit : 1". Remove unused
13797 member evalargs. Remove obsolete comments about cc bombing out.
13798
9851bfc5
JD
137992011-06-30 Jan Djärv <jan.h.d@swipnet.se>
13800
51bb811f 13801 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
13802 Let HAVE_GSETTINGS override HAVE_GCONF.
13803 (store_monospaced_changed): New function.
13804 (EMACS_SETTINGS): A new type derived from GObject to handle
13805 GSettings notifications.
13806 (emacs_settings_constructor, emacs_settings_get_property)
13807 (emacs_settings_set_property, emacs_settings_class_init):
13808 New functions.
13809 (gsettings_client, gsettings_obj): New variables.
13810 (GSETTINGS_SCHEMA): New define.
13811 (something_changedCB): Call store_monospaced_changed.
13812 (init_gsettings): New function.
13813 (xsettings_initialize): Call init_gsettings.
13814 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
13815 to NULL.
13816
640c8776 13817 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
13818 GCONF_CFLAGS/LIBS.
13819
5386012d
MR
138202011-06-29 Martin Rudalics <rudalics@gmx.at>
13821
13822 * window.c (resize_root_window, grow_mini_window)
13823 (shrink_mini_window): Rename Qresize_root_window to
13824 Qwindow_resize_root_window and Qresize_root_window_vertically to
13825 Qwindow_resize_root_window_vertically.
13826
f13e0b08
PE
138272011-06-28 Paul Eggert <eggert@cs.ucla.edu>
13828
13829 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
13830
94515237
JB
138312011-06-27 Juanma Barranquero <lekktu@gmail.com>
13832
13833 * makefile.w32-in: Redesign dependencies so they reflect more
13834 clearly which files are directly included by each source file,
13835 and not through other includes.
13836
e43b6e43
MR
138372011-06-27 Martin Rudalics <rudalics@gmx.at>
13838
13839 * buffer.c (Qclone_number): Declare static and DEFSYM it.
13840 (sort_overlays, overlay_strings): When an overlay's clone number
13841 matches the window's clone number process the overlay even if
13842 the overlay's window property doesn't match the current window.
13843
d68443dc
MR
13844 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
13845 (Fwindow_hchild): Rename to Fwindow_left_child.
13846 (Fwindow_next): Rename to Fwindow_next_sibling.
13847 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
13848 (resize_window_check): Rename to window_resize_check.
13849 (resize_window_apply): Rename to window_resize_apply.
13850 (Fresize_window_apply): Rename to Fwindow_resize_apply.
13851 (Fdelete_other_windows_internal, resize_frame_windows)
13852 (Fsplit_window_internal, Fdelete_window_internal)
13853 (grow_mini_window, shrink_mini_window)
13854 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 13855
c7e73be5
JD
138562011-06-26 Jan Djärv <jan.h.d@swipnet.se>
13857
13858 * emacsgtkfixed.h: State that this is only used with Gtk+3.
13859 (emacs_fixed_set_min_size): Remove.
13860 (emacs_fixed_new): Take frame as argument.
13861
13862 * emacsgtkfixed.c: State that this is only used with Gtk+3.
13863 (_EmacsFixedPrivate): Remove minwidth/height.
13864 Add struct frame *f.
13865 (emacs_fixed_init): Initialize priv->f.
13866 (get_parent_class, emacs_fixed_set_min_size): Remove.
13867 (emacs_fixed_new): Set priv->f to argument.
13868 (emacs_fixed_get_preferred_width)
13869 (emacs_fixed_get_preferred_height): Use min_width/height from
13870 frames size_hint to set minimum and natural (Bug#8919).
13871 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
13872 and use min_width/height from frames size_hint to set
13873 min_width/height (Bug#8919).
13874
13875 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
13876 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
13877 Fix indentation.
c7e73be5 13878
cf99dcf8
EZ
138792011-06-26 Eli Zaretskii <eliz@gnu.org>
13880
13881 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
13882 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
13883 called at ZV.
13884
029529ac
CY
138852011-06-26 Chong Yidong <cyd@stupidchicken.com>
13886
13887 * process.c (wait_reading_process_output): Bypass select if
13888 waiting for a cell while ignoring keyboard input, and input is
13889 pending. Suggested by Jan Djärv (Bug#8869).
13890
7a7ef429
PE
138912011-06-25 Paul Eggert <eggert@cs.ucla.edu>
13892
13893 Use gnulib's dup2 module instead of rolling our own.
13894 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
13895
11fdef7d 138962011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
13897
13898 * dispnew.c (scrolling_window): Before scrolling, turn off a
13899 mouse-highlight in the window being scrolled.
13900
cd3520a4
JB
139012011-06-24 Juanma Barranquero <lekktu@gmail.com>
13902
13903 Move DEFSYM to lisp.h and use everywhere.
13904
13905 * character.h (DEFSYM): Move declaration...
13906 * lisp.h (DEFSYM): ...here.
13907
13908 * gnutls.c:
13909 * minibuf.c:
13910 * w32menu.c:
13911 * w32proc.c:
13912 * w32select.c: Don't include character.h.
13913
13914 * alloc.c (syms_of_alloc):
13915 * buffer.c (syms_of_buffer):
13916 * bytecode.c (syms_of_bytecode):
13917 * callint.c (syms_of_callint):
13918 * casefiddle.c (syms_of_casefiddle):
13919 * casetab.c (init_casetab_once):
13920 * category.c (init_category_once, syms_of_category):
13921 * ccl.c (syms_of_ccl):
13922 * cmds.c (syms_of_cmds):
13923 * composite.c (syms_of_composite):
13924 * dbusbind.c (syms_of_dbusbind):
13925 * dired.c (syms_of_dired):
13926 * dispnew.c (syms_of_display):
13927 * doc.c (syms_of_doc):
13928 * editfns.c (syms_of_editfns):
13929 * emacs.c (syms_of_emacs):
13930 * eval.c (syms_of_eval):
13931 * fileio.c (syms_of_fileio):
13932 * fns.c (syms_of_fns):
13933 * frame.c (syms_of_frame):
13934 * fringe.c (syms_of_fringe):
13935 * insdel.c (syms_of_insdel):
13936 * keymap.c (syms_of_keymap):
13937 * lread.c (init_obarray, syms_of_lread):
13938 * macros.c (syms_of_macros):
13939 * msdos.c (syms_of_msdos):
13940 * print.c (syms_of_print):
13941 * process.c (syms_of_process):
13942 * search.c (syms_of_search):
13943 * sound.c (syms_of_sound):
13944 * syntax.c (init_syntax_once, syms_of_syntax):
13945 * terminal.c (syms_of_terminal):
13946 * textprop.c (syms_of_textprop):
13947 * undo.c (syms_of_undo):
13948 * w32.c (globals_of_w32):
13949 * window.c (syms_of_window):
13950 * xdisp.c (syms_of_xdisp):
13951 * xfaces.c (syms_of_xfaces):
13952 * xfns.c (syms_of_xfns):
13953 * xmenu.c (syms_of_xmenu):
13954 * xsettings.c (syms_of_xsettings):
13955 * xterm.c (syms_of_xterm): Use DEFSYM.
13956
4228cf16
TZ
139572011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13958
cd3520a4 13959 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13960
7fcccf1e
PE
139612011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13962
7efb4e0e
PE
13963 Integer and buffer overflow fixes (Bug#8873).
13964
ff5844ad
PE
13965 * print.c (printchar, strout): Check for string overflow.
13966 (PRINTPREPARE, printchar, strout):
13967 Don't set size unless allocation succeeds.
13968
90532f02
PE
13969 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13970 for sizes. Check for string overflow more accurately.
13971 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13972
6d84508d
PE
13973 * macros.c: Integer and buffer overflow fixes.
13974 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13975 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13976 Use ptrdiff_t, not int, for sizes.
13977 Don't increment bufsize until after realloc succeeds.
13978 Check for size-calculation overflow.
13979 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13980
437b2cb4
PE
13981 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13982
8b9ac8b4
PE
13983 * lread.c: Integer overflow fixes.
13984 (read_integer): Radix is now EMACS_INT, not int,
13985 to improve quality of diagnostics for out-of-range radices.
13986 Calculate buffer size correctly for out-of-range radices.
13987 (read1): Check for integer overflow in radices, and in
13988 read-circle numbers.
82cb60d3
PE
13989 (read_escape): Avoid int overflow.
13990 (Fload, openp, read_buffer_size, read1)
13991 (substitute_object_recurse, read_vector, read_list, map_obarray):
13992 Use ptrdiff_t, not int, for sizes.
13993 (read1): Use EMACS_INT, not int, for sizes.
20270765 13994 Check for size overflow.
8b9ac8b4 13995
7fcccf1e
PE
13996 * image.c (cache_image): Check for size arithmetic overflow.
13997
bfbbd7e7
PE
13998 * lread.c: Integer overflow issues.
13999 (saved_doc_string_size, saved_doc_string_length)
14000 (prev_saved_doc_string_size, prev_saved_doc_string_length):
14001 Now ptrdiff_t, not int.
14002 (read1): Don't assume doc string length fits in int. Check for
14003 out-of-range doc string lengths.
14004 (read_list): Don't assume file position fits in int.
39019e54 14005 (read_escape): Check for hex character overflow.
bfbbd7e7 14006
4e323265
LL
140072011-06-22 Leo Liu <sdl.web@gmail.com>
14008
14009 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
14010 Move to minibuffer.el.
14011
85fece3e
PE
140122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
14013
20b84ce9 14014 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
14015 The following patches are for when GLYPH_DEBUG && !XASSERT.
14016 * dispextern.h (trace_redisplay_p, dump_glyph_string):
14017 * dispnew.c (flush_stdout):
14018 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
14019 Mark as externally visible.
14020 * dispnew.c (check_window_matrix_pointers): Now static.
14021 * dispnew.c (window_to_frame_vpos):
14022 * xfns.c (unwind_create_frame):
14023 * xterm.c (x_check_font): Remove unused local.
14024 * scroll.c (CHECK_BOUNDS):
14025 * xfaces.c (cache_fache): Rename local to avoid shadowing.
14026 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
14027 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
14028 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
14029 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
14030 Now static.
14031 (debug_method_add): Use va_list and vsprintf rather than relying
14032 on undefined behavior with wrong number of arguments.
14033 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
14034 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
14035 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
14036 since we're not interested in debugging glyphs with old libraries.
14037 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
14038 GCC 4.6.0's static checking.
14039
0766b489
PE
140402011-06-22 Paul Eggert <eggert@cs.ucla.edu>
14041
31fd4b32
PE
14042 Integer overflow and signedness fixes (Bug#8873).
14043 A few related buffer overrun fixes, too.
14044
b79e8648
PE
14045 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
14046
0766b489
PE
14047 * dispextern.h (struct face.stipple):
14048 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
14049 (x_bitmap_mask, x_allocate_bitmap_record)
14050 (x_create_bitmap_from_data, x_create_bitmap_from_file)
14051 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
14052 (x_create_bitmap_from_xpm_data):
14053 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
14054 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
14055 (.bitmaps_last):
14056 * xfaces.c (load_pixmap):
14057 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
14058 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
14059 (.bitmaps_last, struct x_output.icon_bitmap):
14060 Use ptrdiff_t, not int, for bitmap indexes.
14061 (x_allocate_bitmap_record): Check for size overflow.
14062 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
14063
b081724f
PE
14064 Use ptrdiff_t, not int, for overlay counts.
14065 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
14066 * editfns.c (overlays_around, get_pos_property):
14067 * textprop.c (get_char_property_and_overlay):
14068 * xdisp.c (next_overlay_change, note_mouse_highlight):
14069 * xfaces.c (face_at_buffer_position):
21514da7
PE
14070 * buffer.c (OVERLAY_COUNT_MAX): New macro.
14071 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
14072 (Fnext_overlay_change, Fprevious_overlay_change)
14073 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 14074 Use ptrdiff_t, not int, for sizes.
21514da7 14075 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 14076
3de73e5e
PE
14077 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
14078
2606c57b
PE
14079 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
14080 (x_session_initialize): Do not assume string length fits in int.
14081
aaafe47a
PE
14082 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
14083 This is unlikely, but can occur if DPI is outlandish.
14084
2674ddc8 14085 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
14086 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
14087
28154962
PE
14088 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
14089 * xrdb.c (magic_file_p, search_magic_path):
14090 Omit last arg SUFFIX; it was always 0. All callers changed.
14091 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
14092
7de51af5
PE
14093 * xfont.c (xfont_match): Avoid need for strlen.
14094
25ed6cc3
PE
14095 * xfns.c: Don't assume strlen fits in int.
14096 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
14097
4eab31dd
PE
14098 * xdisp.c (message_log_check_duplicate): Return intmax_t,
14099 not unsigned long, as we prefer signed integers. All callers changed.
14100 Detect integer overflow in repeat count.
14101 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 14102 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 14103
171e2a58
PE
14104 * termcap.c: Don't assume sizes fit in int and never overflow.
14105 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
14106 (gobble_line): Check for size-calculation overflow.
14107
ad39faca 14108 * minibuf.c (Fread_buffer):
6e5bb2dc 14109 * lread.c (intern, intern_c_string):
74ca2eb3
PE
14110 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
14111 Don't assume string length fits in int.
14112
52c61c22 14113 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
14114 * gtkutil.c (style_changed_cb): Avoid need for strlen.
14115
b5b8c9e5
PE
14116 * font.c: Don't assume string length fits in int.
14117 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
14118 Use ptrdiff_t, not int.
ccd6111c
PE
14119 (font_intern_prop): Don't assume string length fits in int.
14120 Don't assume integer property fits in fixnum.
14121 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 14122
882f0d81 14123 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 14124 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
14125 Reformulate so as not to need the command string.
14126 Invoke gzip -cd rather than gunzip, as it's more portable.
14127 (lock_info_type, lock_file_1, lock_file):
14128 Don't assume pid_t and time_t fit in unsigned long.
14129 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
14130 (current_lock_owner): Prefer signed type for sizes.
14131 Use memcpy, not strncpy, where memcpy is what is really wanted.
14132 Don't assume (via atoi) that time_t and pid_t fit in int.
14133 Check for time_t and/or pid_t out of range, e.g., via a network share.
14134 Don't alloca where an auto var works fine.
14135
93f4cf88
PE
14136 * fileio.c: Fix some integer overflow issues.
14137 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
14138 Don't assume string length fits in int.
14139 (directory_file_name): Don't assume string length fits in long.
14140 (make_temp_name): Don't assume pid fits in int, or that its print
14141 length is less than 20.
14142
f3e92b69
PE
14143 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
14144
1bfdaf10
PE
14145 * coding.c (make_subsidiaries): Don't assume string length fits in int.
14146
35016e9a
PE
14147 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
14148
3d1e65a1
PE
14149 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
14150 We prefer signed integers, even for size calculations.
14151
0b963a93
PE
14152 * emacs.c: Don't assume string length fits in 'int'.
14153 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
14154 (main): Don't invoke strlen when not needed.
14155
573f4b54
PE
14156 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
14157 (XD_DEBUG_MESSAGE): Don't waste a byte.
14158
989f33ba
PE
14159 * callproc.c (getenv_internal_1, getenv_internal)
14160 (Fgetenv_internal):
965d34eb
PE
14161 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
14162
e4d29b33
PE
14163 * lread.c (invalid_syntax): Omit length argument.
14164 All uses changed. This doesn't fix a bug, but it simplifies the
14165 code away from its former Hollerith-constant appearance, and it's
14166 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 14167 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 14168
eb49b136
PE
14169 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
14170 This didn't break anything, but it didn't help either.
14171 It's confusing to put a bogus integer in a place where the actual
14172 value does not matter.
9f62aeb1 14173 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 14174 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 14175
15375a22
PE
14176 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
14177 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
14178 implementation.
b61cc01c
PE
14179 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
14180 We prefer signed types, and the value cannot exceed the EMACS_INT
14181 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
14182 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
14183 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
14184 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 14185
53b2623d
PE
14186 * indent.c (sane_tab_width): New function.
14187 (current_column, scan_for_column, Findent_to, position_indentation)
14188 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 14189 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 14190
51cab52b 14191 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 14192
f2ed8a70
PE
14193 * lisp.h (lint_assume): New macro.
14194 * composite.c (composition_gstring_put_cache):
14195 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
14196
abe80cc6
PE
14197 * editfns.c, insdel.c:
14198 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 14199
b02c740e
PE
14200 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
14201
ebc96716
PE
14202 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
14203
b4e50fa0 14204 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 14205 Use much-faster test for byte-length change.
311d5d7c 14206 Don't assume string byte-length fits in 'int'.
a4cf38e4 14207 Check that character arg fits in 'int'.
85461888 14208 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 14209
c0c1ee9f
PE
14210 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
14211
a498d7f4
PE
14212 * fns.c (concat): Catch string overflow earlier.
14213 Do not rely on integer wraparound.
14214
51cab52b
PE
14215 * dispextern.h (struct it.overlay_strings_charpos)
14216 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
14217 * xdisp.c (forward_to_next_line_start)
14218 (back_to_previous_visible_line_start)
14219 (reseat_at_next_visible_line_start, next_element_from_buffer):
14220 Don't arbitrarily truncate the value of 'selective' to int.
14221
76031fad
PE
14222 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
14223
5eb55db9
PE
14224 * composite.c: Don't truncate sizes to 'int'.
14225 (composition_gstring_p, composition_reseat_it)
14226 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
14227 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
14228 not EMACS_UINT, for indexes.
5eb55db9 14229
0703a717
PE
14230 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
14231
d6202519
PE
14232 * buffer.c: Include <verify.h>.
14233 (struct sortvec.priority, struct sortstr.priority):
8961a454 14234 Now EMACS_INT, not int.
c20998a7 14235 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
14236 (struct sortstr.size, record_overlay_string)
14237 (struct sortstrlist.size, struct sortlist.used):
14238 Don't truncate size to int.
14239 (record_overlay_string): Check for size-calculation overflow.
d6202519 14240 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 14241
d5a19415
JM
142422011-06-22 Jim Meyering <meyering@redhat.com>
14243
029529ac 14244 Don't leak an XBM-image-sized buffer
d5a19415
JM
14245 * image.c (xbm_load): Free the image buffer after using it.
14246
a9041e6c
PE
142472011-06-21 Paul Eggert <eggert@cs.ucla.edu>
14248
14249 Port to Sun C.
14250 * composite.c (find_automatic_composition): Omit needless 'return 0;'
14251 that Sun C diagnosed.
14252 * fns.c (secure_hash): Fix pointer signedness issue.
14253 * intervals.c (static_offset_intervals): New function.
14254 (offset_intervals): Use it.
14255
7f3f739f
LL
142562011-06-21 Leo Liu <sdl.web@gmail.com>
14257
14258 * deps.mk (fns.o):
14259 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
14260 sha512.h.
14261
14262 * fns.c (secure_hash): Rename from crypto_hash_function and change
14263 the first arg to accept symbols.
5b66d427 14264 (Fsecure_hash): New primitive.
7f3f739f
LL
14265 (syms_of_fns): New symbols.
14266
76147d94
DD
142672011-06-20 Deniz Dogan <deniz@dogan.se>
14268
14269 * process.c (Fset_process_buffer): Clarify return value in
14270 docstring.
14271
7d7d0045
CY
142722011-06-18 Chong Yidong <cyd@stupidchicken.com>
14273
14274 * dispnew.c (add_window_display_history): Use BVAR.
14275
14276 * xdisp.c (debug_method_add): Use BVAR.
14277 (check_window_end, dump_glyph_matrix, dump_glyph)
14278 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
14279
14280 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
14281 Likewise.
14282
14283 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
14284 check till after the cache is created in init_frame_faces.
14285
ff2bc410
SM
142862011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
14287
14288 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
14289
28177add
PE
142902011-06-16 Paul Eggert <eggert@cs.ucla.edu>
14291
dd3482fe
PE
14292 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
14293 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
14294 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
14295
393d71f3 14296 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
14297 * fileio.c (Finsert_file_contents):
14298 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
14299 Remove the old (too-loose) buffer overflow checks.
14300 They weren't needed, since make_gap checks for buffer overflow.
14301 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
14302 The old code merely checked for Emacs fixnum overflow, and relied
14303 on undefined (wraparound) behavior. The new code avoids undefined
14304 behavior, and also checks for ptrdiff_t and/or size_t overflow.
14305
2e6813b0 14306 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
14307 Tune. Don't use wider integers than needed. Don't use alloca.
14308 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 14309
599a9e4f
PE
14310 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
14311
99561444
PE
14312 * insdel.c, lisp.h (buffer_overflow): New function.
14313 (insert_from_buffer_1, replace_range, replace_range_2):
14314 * insdel.c (make_gap_larger):
14315 * editfns.c (Finsert_char):
14316 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
14317
28177add
PE
14318 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
14319
e69dafad
PE
143202011-06-15 Paul Eggert <eggert@cs.ucla.edu>
14321
4baa020d 14322 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 14323
b1c46f02
PE
14324 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
14325 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
14326
e69dafad
PE
14327 * fileio.c: Don't assume EMACS_INT fits in off_t.
14328 (emacs_lseek): New static function.
14329 (Finsert_file_contents, Fwrite_region): Use it.
14330 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
14331
566684ea
PE
14332 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
14333
e6966cd6
PE
14334 * fns.c: Don't overflow int when computing a list length.
14335 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
14336 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
14337 truncation on 64-bit hosts. Check for QUIT every
14338 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
14339 faster and is responsive enough.
14340 (Flength): Report an error instead of overflowing an integer.
14341 (Fsafe_length): Return a float if the value is not representable
14342 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 14343 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 14344 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 14345
dd0b0efb
PE
14346 * alloc.c: Check that resized vectors' lengths fit in fixnums.
14347 (header_size, word_size): New constants.
14348 (allocate_vectorlike): Don't check size overflow here.
14349 (allocate_vector): Check it here instead, since this is the only
14350 caller of allocate_vectorlike that could cause overflow.
14351 Check that the new vector's length is representable as a fixnum.
14352
86fe5cfe
PE
14353 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
14354 The previous code was bogus. For example, next_almost_prime (32)
14355 returned 39, which is undesirable as it is a multiple of 3; and
14356 next_almost_prime (24) returned 25, which is a multiple of 5 so
14357 why was the code bothering to check for multiples of 7?
14358
80e88859
PE
14359 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
14360
4a2f0ad6
PE
14361 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
14362
f66c7cf8
PE
14363 Variadic C functions now count arguments with ptrdiff_t.
14364 This partly undoes my 2011-03-30 change, which replaced int with size_t.
14365 Back then I didn't know that the Emacs coding style prefers signed int.
14366 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
14367 were being counted with int, which may truncate counts on 64-bit
14368 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
14369 * lisp.h (struct Lisp_Subr.function.aMANY)
14370 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
14371 Arg counts are now ptrdiff_t, not size_t.
14372 All variadic functions and their callers changed accordingly.
14373 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
14374 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
14375 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
14376 * callint.c (Fcall_interactively): Check arg count for overflow,
14377 to avoid potential buffer overrun. Use signed char, not 'int',
14378 for 'varies' array, so that we needn't bother to check its size
14379 calculation for overflow.
14380 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
14381 * eval.c (apply_lambda):
14382 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
14383 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
14384 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
14385
a1759b76
PE
14386 * callint.c (Fcall_interactively): Don't use index var as event count.
14387
d96be9fc
PE
14388 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
14389 * mem-limits.h (SIZE): Remove; no longer used.
14390
a690a978 14391 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 14392
578c21e6
PE
14393 Remove unnecessary casts.
14394 * xterm.c (x_term_init):
14395 * xfns.c (x_set_border_pixel):
14396 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
14397 These aren't needed now that we assume ANSI C.
14398
96f53c6c
PE
14399 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
14400 It's more likely to cause problems (due to unsigned overflow)
14401 than to cure them.
14402
83c77d31
PE
14403 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
14404
ee2079f1
PE
14405 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
14406
6da65536
PE
14407 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
14408
7147c4a4
PE
14409 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
14410
193e32d9
PE
14411 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
14412
e5533da6
PE
14413 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
14414
9910e595
PE
14415 GLYPH_CODE_FACE returns EMACS_INT, not int.
14416 * dispextern.h (merge_faces):
14417 * xfaces.c (merge_faces):
01103c44
PE
14418 * xdisp.c (get_next_display_element, next_element_from_display_vector):
14419 Don't assume EMACS_INT fits in int.
9910e595 14420
2638320e
PE
14421 * character.h (CHAR_VALID_P): Remove unused parameter.
14422 * fontset.c, lisp.h, xdisp.c: All uses changed.
14423
045eb8d9
PE
14424 * editfns.c (Ftranslate_region_internal): Omit redundant test.
14425
c1f134b5
PE
14426 * fns.c (concat): Minor tuning based on overflow analysis.
14427 This doesn't fix any bugs. Use int to hold character, instead
14428 of constantly refetching from Emacs object. Use XFASTINT, not
14429 XINT, for value known to be a character. Don't bother comparing
14430 a single byte to 0400, as it's always less.
14431
395fcb93 14432 * floatfns.c (Fexpt):
327eeec8
PE
14433 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
14434
abbd3d23
PE
14435 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
14436 for characters.
14437
684a03ef
PE
14438 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
14439
0fed43f3
PE
14440 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
14441 Without this fix, on a 64-bit host (aset S 0 4294967386) would
14442 incorrectly succeed when S was a string, because 4294967386 was
14443 truncated before it was used.
14444
8fd02eb7
PE
14445 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
14446 Otherwise, an out-of-range integer could cause undefined behavior
14447 on a 64-bit host.
14448
f8c86b69
PE
14449 * composite.c: Use int, not EMACS_INT, for characters.
14450 (fill_gstring_body, composition_compute_stop_pos): Use int, not
14451 EMACS_INT, for values that are known to be in character range.
14452 This doesn't fix any bugs but is the usual style inside Emacs and
14453 may generate better code on 32-bit machines.
14454
34206dd2
PE
14455 Make sure a 64-bit char is never passed to ENCODE_CHAR.
14456 This is for reasons similar to the recent CHAR_STRING fix.
14457 * charset.c (Fencode_char): Check that character arg is actually
14458 a character. Pass an int to ENCODE_CHAR.
14459 * charset.h (ENCODE_CHAR): Verify that the character argument is no
14460 wider than 'int', as a compile-time check to prevent future regressions
14461 in this area.
14462
c5958d4c 14463 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
14464
14465 Make sure a 64-bit char is never passed to CHAR_STRING.
14466 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
14467 by silently ignoring the top 32 bits, allowing some values
14468 that were far too large to be valid characters.
14469 * character.h: Include <verify.h>.
14470 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
14471 arguments are no wider than unsigned, as a compile-time check
14472 to prevent future regressions in this area.
14473 * data.c (Faset):
01103c44 14474 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
14475 (Fsubst_char_in_region):
14476 * fns.c (concat):
14477 * xdisp.c (decode_mode_spec_coding):
14478 Adjust to CHAR_STRING's new requirement.
14479 * editfns.c (Finsert_char, Fsubst_char_in_region):
14480 * fns.c (concat): Check that character args are actually
14481 characters. Without this test, these functions did the wrong
14482 thing with wildly out-of-range values on 64-bit hosts.
14483
d37ca623
PE
14484 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
14485 These casts should not be needed on 32-bit hosts, either.
14486 * keyboard.c (read_char):
14487 * lread.c (Fload): Remove casts to unsigned.
14488
ea204efb
PE
14489 * lisp.h (UNSIGNED_CMP): New macro.
14490 This fixes comparison bugs on 64-bit hosts.
14491 (ASCII_CHAR_P): Use it.
14492 * casefiddle.c (casify_object):
01103c44 14493 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
14494 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
14495 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
14496 * dispextern.h (FACE_FROM_ID):
14497 * keyboard.c (read_char): Use UNSIGNED_CMP.
14498
41cb286c
PE
14499 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
14500 not to EMACS_INT, to avoid GCC warning.
14501
4a1b9832
PE
14502 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
14503
55daad71
PE
14504 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
14505 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
14506 isn't needed on 32-bit machines.
8f95c75c 14507
01103c44
PE
14508 * buffer.c (Fgenerate_new_buffer_name):
14509 Use EMACS_INT for count, not int.
0ceccced 14510 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
14511
14512 * data.c (Qcompiled_function): Now static.
14513
c6f072e7
PE
14514 * window.c (window_body_lines): Now static.
14515
20ce5912
PE
14516 * image.c (gif_load): Rename local to avoid shadowing.
14517
9c4c5f81
PE
14518 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
14519 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
14520 * alloc.c (make_save_value): Integer argument is now of type
14521 ptrdiff_t, not int.
14522 (mark_object): Use ptrdiff_t, not int.
14523 * lisp.h (pD): New macro.
14524 * print.c (print_object): Use it.
14525
c0c5c8ae
PE
14526 * alloc.c: Use EMACS_INT, not int, to count objects.
14527 (total_conses, total_markers, total_symbols, total_vector_size)
14528 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
14529 (total_free_floats, total_floats, total_free_intervals)
14530 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
14531 Now EMACS_INT, not int. All uses changed.
14532 (Fgarbage_collect): Compute overall total using a double, so that
14533 integer overflow is less likely to be a problem. Check for overflow
14534 when converting back to an integer.
5a25e253
PE
14535 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
14536 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
14537 These were 'int' variables that could overflow on 64-bit hosts;
14538 they were never used, so remove them instead of repairing them.
211a0b2a 14539 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
14540 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
14541 Previously, this ceilinged at INT_MAX, but that doesn't work on
14542 64-bit machines.
e46bb31a 14543 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 14544
c78baabf 14545 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 14546 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
14547 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
14548 when a (possibly-narrower) signed value would do just as well.
14549 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 14550
c9d624c6
PE
14551 * alloc.c: Catch some string size overflows that we were missing.
14552 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
14553 for convenience in STRING_BYTES_MAX.
14554 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
14555 The definition here is exact; the one in lisp.h was approximate.
14556 (allocate_string_data): Check for string overflow. This catches
14557 some instances we weren't catching before. Also, it catches
14558 size_t overflow on (unusual) hosts where SIZE_MAX <= min
14559 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
14560 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 14561
c9d624c6
PE
14562 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
14563 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 14564 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 14565
353032ce
PE
14566 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
14567
2bccce07
PE
14568 * alloc.c (Fmake_string): Check for out-of-range init.
14569
0ac30604
SM
145702011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
14571
14572 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
14573
c195f2de
JD
145742011-06-14 Jan Djärv <jan.h.d@swipnet.se>
14575
14576 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
14577 xg_get_default_scrollbar_width.
14578
14579 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
14580 (int_gtk_range_get_value): Move to the scroll bar part of the file.
14581 (style_changed_cb): Call update_theme_scrollbar_width and call
14582 x_set_scroll_bar_default_width and xg_frame_set_char_size for
14583 all frames (Bug#8505).
14584 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
14585 Call gtk_window_set_resizable if HAVE_GTK3.
14586 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
14587 and height if HAVE_GTK3 (Bug#8505).
14588 (scroll_bar_width_for_theme): New variable.
14589 (update_theme_scrollbar_width): New function.
14590 (xg_get_default_scrollbar_width): Move code to
14591 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
14592 (xg_initialize): Call update_theme_scrollbar_width.
14593
14594 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
14595
14596 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
14597
e10ac9f1
MR
145982011-06-12 Martin Rudalics <rudalics@gmx.at>
14599
14600 * frame.c (make_frame): Call other_buffer_safely instead of
14601 other_buffer.
14602
14603 * window.c (temp_output_buffer_show): Call display_buffer with
14604 second argument Vtemp_buffer_show_specifiers and reset latter
14605 immediately after the call.
14606 (Vtemp_buffer_show_specifiers): New variable.
14607 (auto_window_vscroll_p, next_screen_context_lines)
14608 (Vscroll_preserve_screen_position): Remove leading asterisks from
14609 doc-strings.
14610
2d3c217e 146112011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 14612
7b7f97e8 14613 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
14614 * buffer.c (Qclone_number): Remove for now, as it's unused.
14615 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
14616 (record_buffer): Remove unused local.
14617 * frame.c (other_visible_frames, frame_buffer_list): Now static.
14618 (set_frame_buffer_list): Remove; unused.
14619 * frame.h (other_visible_frames): Remove decl.
14620 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
14621 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
14622 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
14623 if HAVE_GPM.
14624 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
14625 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
14626 Define only if HAVE_GPM.
14627 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
14628 (update_hints_inhibit): Remove; never set. All uses removed.
14629 * widgetprv.h (emacsFrameClassRec): Remove decl.
14630 * window.c (delete_deletable_window): Now returns void, since it
14631 wasn't returning anything.
14632 (compare_window_configurations): Remove unused locals.
14633 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
14634 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
14635 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
14636 the same widths as pointers. This follows up on the 2011-05-06 patch.
14637 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
14638 * xterm.h: Likewise.
14639 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
14640
1384b89e
JB
146412011-06-12 Juanma Barranquero <lekktu@gmail.com>
14642
14643 * makefile.w32-in: Update dependencies.
14644 (LISP_H): Add lib/intprops.h.
14645
1100a63c
CY
146462011-06-11 Chong Yidong <cyd@stupidchicken.com>
14647
14648 * image.c (gif_load): Add animation frame delay to the metadata.
14649 (syms_of_image): Use DEFSYM. New symbol `delay'.
14650
6198ccd0
MR
146512011-06-11 Martin Rudalics <rudalics@gmx.at>
14652
14653 * window.c (delete_deletable_window): Re-add.
14654 (Fset_window_configuration): Rewrite to handle dead buffers and
14655 consequently deletable windows.
14656 (window_tree, Fwindow_tree): Remove. Supply functionality in
14657 window.el.
14658 (compare_window_configurations): Simplify code.
14659
b6e3633c
AS
146602011-06-11 Andreas Schwab <schwab@linux-m68k.org>
14661
1ab0dee5
AS
14662 * image.c (imagemagick_load_image): Fix type mismatch.
14663 (Fimagemagick_types): Likewise.
14664
b6e3633c
AS
14665 * window.h (replace_buffer_in_windows): Declare.
14666
9397e56f
MR
146672011-06-11 Martin Rudalics <rudalics@gmx.at>
14668
14669 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
14670 Qclone_number. Remove external declaration of Qdelete_window.
14671 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
14672 code.
640c8776
SM
14673 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
14674 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
14675 (Fother_buffer): Rewrite doc-string. Major rewrite for new
14676 buffer list implementation.
14677 (other_buffer_safely): New function.
14678 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
14679 calls to replace_buffer_in_windows and
14680 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
14681 if allowed.
14682 (record_buffer): Inhibit quitting and rewrite using quittable
14683 functions. Run Qbuffer_list_update_hook if allowed.
14684 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
14685 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
14686 Move switch-to-buffer to window.el.
9397e56f
MR
14687 (bury-buffer): Move to window.el.
14688 (Vbuffer_list_update_hook): New variable.
14689
14690 * lisp.h (other_buffer_safely): Add prototype in buffer.c
14691 section.
14692
14693 * window.h (resize_frame_windows): Move up in code.
14694 (Fwindow_frame): Remove EXFUN.
14695 (replace_buffer_in_all_windows): Remove prototype.
14696 (replace_buffer_in_windows_safely): Add prototype.
14697
14698 * window.c: Declare Qdelete_window static again. Move down
14699 declaration of select_count.
14700 (Fnext_window, Fprevious_window): Rewrite doc-strings.
14701 (Fother_window): Move to window.el.
14702 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
14703 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
14704 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
14705 window.el.
14706 (replace_buffer_in_windows): Implement by calling
14707 Qreplace_buffer_in_windows.
14708 (replace_buffer_in_all_windows): Remove with some functionality
14709 moved into replace_buffer_in_windows_safely.
14710 (replace_buffer_in_windows_safely): New function.
14711 (select_window_norecord, select_frame_norecord): Move in front
14712 of run_window_configuration_change_hook. Remove now obsolete
14713 declarations.
640c8776
SM
14714 (Fset_window_buffer): Rewrite doc-string.
14715 Call Qrecord_window_buffer.
9397e56f
MR
14716 (keys_of_window): Move binding for other-window to window.el.
14717
b50691aa
CY
147182011-06-11 Chong Yidong <cyd@stupidchicken.com>
14719
14720 * dispextern.h (struct image): Replace data member, whose int_val
14721 and ptr_val fields were not used by anything, with a single
14722 lisp_val object.
14723
14724 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
14725 (gif_clear_image, gif_load, imagemagick_load_image)
14726 (gs_clear_image, gs_load): Callers changed.
14727
3f754b86
PE
147282011-06-10 Paul Eggert <eggert@cs.ucla.edu>
14729
cca69397
PE
14730 * buffer.h: Include <time.h>, for time_t.
14731 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
14732
109e28d0
PE
14733 Fix minor problems found by static checking.
14734
60737f02
PE
14735 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
14736
4b66faf3
PE
14737 Make identifiers static if they are not used in other modules.
14738 * data.c (Qcompiled_function, Qframe, Qvector):
14739 * image.c (QimageMagick, Qsvg):
14740 * minibuf.c (Qmetadata):
14741 * window.c (resize_window_check, resize_root_window): Now static.
14742 * window.h (resize_window_check, resize_root_window): Remove decls.
14743
109e28d0
PE
14744 * window.c (window_deletion_count, delete_deletable_window):
14745 Remove; unused.
46a4ce9e
PE
14746 (window_body_lines): Now static.
14747 (Fdelete_other_windows_internal): Mark vars as initialized.
14748 Make sure 'resize_failed' is initialized.
14749 (run_window_configuration_change_hook): Rename local to avoid shadowing.
14750 (resize_window_apply): Remove unused local.
14751 * window.h (delete_deletable_window): Remove decl.
14752
109e28d0 14753 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
14754 (imagemagick_load_image): Fix pointer signedness problem by changing
14755 last arg from unsigned char * to char *. All uses changed.
14756 Also, fix a local for similar reasons.
14757 Remove unused locals. Remove locals to avoid shadowing.
14758 (fn_rsvg_handle_free): Remove; unused.
14759 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 14760 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 14761
3f754b86
PE
14762 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
14763
2547adb1
CY
147642011-06-10 Chong Yidong <cyd@stupidchicken.com>
14765
14766 * image.c (gif_load): Fix omitted cast error introduced by
14767 2011-06-06 change.
14768
2c8e37d4
MR
147692011-06-10 Martin Rudalics <rudalics@gmx.at>
14770
14771 * window.h (resize_proportionally, orig_total_lines)
14772 (orig_top_line): Remove from window structure.
14773 (set_window_height, set_window_width, change_window_heights)
14774 (Fdelete_window): Remove prototypes.
14775 (resize_frame_windows): Remove duplicate declaration.
14776
440a42e3
EZ
147772011-06-10 Eli Zaretskii <eliz@gnu.org>
14778
14779 * window.h (resize_frame_windows, resize_window_check)
14780 (delete_deletable_window, resize_root_window)
14781 (resize_frame_windows): Declare prototypes.
14782
14783 * window.c (resize_window_apply): Make definition be "static" to
14784 match the prototype.
14785
562dd5e9
MR
147862011-06-10 Martin Rudalics <rudalics@gmx.at>
14787
14788 * window.c: Remove declarations of Qwindow_size_fixed,
14789 window_min_size_1, window_min_size_2, window_min_size,
14790 size_window, window_fixed_size_p, enlarge_window, delete_window.
14791 Remove static from declaration of Qdelete_window, it's
14792 temporarily needed by Fbury_buffer.
14793 (replace_window): Don't assign orig_top_line and
14794 orig_total_lines.
14795 (Fdelete_window, delete_window): Remove. Window deletion is
14796 handled by window.el.
640c8776
SM
14797 (window_loop): Remove DELETE_OTHER_WINDOWS case.
14798 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
14799 (Fdelete_other_windows): Remove. Deleting other windows is
14800 handled by window.el.
14801 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
14802 handled in window.el.
14803 (window_min_size_2, window_min_size_1, window_min_size): Remove.
14804 Window minimum sizes are handled in window.el.
14805 (shrink_windows, size_window, set_window_height)
14806 (set_window_width, change_window_heights, window_height)
14807 (window_width, CURBEG, CURSIZE, enlarge_window)
14808 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
14809 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
14810 handled in window.el.
14811 (make_dummy_parent): Rename to make_parent_window and give it a
14812 second argument horflag.
14813 (make_window): Don't set resize_proportionally any more.
14814 (Fsplit_window): Remove. Windows are split in window.el.
14815 (save_restore_action, save_restore_orig_size)
14816 (shrink_window_lowest_first, save_restore_orig_size): Remove.
14817 Resize mini windows in window.el.
14818 (grow_mini_window, shrink_mini_window): Implement by calling
14819 Qresize_root_window_vertically, resize_window_check and
14820 resize_window_apply.
640c8776
SM
14821 (saved_window, Fset_window_configuration, save_window_save):
14822 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
14823 resize_proportionally.
14824 (window_min_height, window_min_width): Move to window.el.
14825 (keys_of_window): Move bindings for delete-other-windows,
14826 split-window, delete-window and enlarge-window to window.el.
14827
14828 * buffer.c: Temporarily extern Qdelete_window.
14829 (Fbury_buffer): Temporarily call Qdelete_window instead of
14830 Fdelete_window (Fbury_buffer will move to window.el soon).
14831
14832 * frame.c (set_menu_bar_lines_1): Remove code handling
14833 orig_top_line and orig_total_lines.
14834
14835 * dispnew.c (adjust_frame_glyphs_initially): Don't use
14836 set_window_height but set heights directly.
14837 (change_frame_size_1): Use resize_frame_windows.
14838
14839 * xdisp.c (init_xdisp): Don't use set_window_height but set
14840 heights directly.
14841
640c8776
SM
14842 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
14843 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
14844 run_window_configuration_change_hook.
14845
14846 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
14847 instead of change_window_heights and run
14848 run_window_configuration_change_hook.
14849
1a13852e
MR
148502011-06-09 Martin Rudalics <rudalics@gmx.at>
14851
14852 * window.c (replace_window): Rename second argument REPLACEMENT to
14853 NEW. New third argument SETFLAG. Rewrite.
14854 (delete_window, make_dummy_parent): Call replace_window with
14855 third argument 1.
14856 (window_list_1): Move down in code.
14857 (run_window_configuration_change_hook): Move set_buffer part
14858 before select_frame_norecord part in order to unwind correctly.
14859 Rename count1 to count.
14860 (recombine_windows, delete_deletable_window, resize_root_window)
14861 (Fdelete_other_windows_internal)
14862 (Frun_window_configuration_change_hook, make_parent_window)
14863 (resize_window_check, resize_window_apply, Fresize_window_apply)
14864 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
14865 (Fdelete_window_internal, Fresize_mini_window_internal):
14866 New functions.
1a13852e
MR
14867 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
14868
f3d1777e
MR
148692011-06-08 Martin Rudalics <rudalics@gmx.at>
14870
496e208e
MR
14871 * window.h (window): Add some new members to window structure -
14872 normal_lines, normal_cols, new_total, new_normal, clone_number,
14873 splits, nest, prev_buffers, next_buffers.
14874 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 14875 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 14876
f3d1777e
MR
14877 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
14878 Remove.
496e208e
MR
14879 (make_dummy_parent): Set new members of windows structure.
14880 (make_window): Move down in code. Handle new members of window
14881 structure.
14882 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
14883 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
14884 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
14885 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
14886 (Fset_window_next_buffers, Fset_window_clone_number):
14887 New functions.
496e208e
MR
14888 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
14889 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
14890 Doc-string fixes.
14891 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
14892 Argument WINDOW can be now internal window too.
14893 (Fwindow_use_time): Move up in code.
14894 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
14895 Rewrite doc-string.
14896 (Fset_window_configuration, saved_window)
14897 (Fcurrent_window_configuration, save_window_save): Handle new
14898 members of window structure.
b9e809c2
MR
14899 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
14900 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
14901 (syms_of_window): New Lisp objects Qrecord_window_buffer,
14902 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
14903 Qget_mru_window, Qresize_root_window,
14904 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
14905 Qauto_buffer_name; staticpro them.
f3d1777e 14906
abde8f8c
MR
149072011-06-07 Martin Rudalics <rudalics@gmx.at>
14908
14909 * window.c (Fwindow_total_size, Fwindow_left_column)
14910 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
14911 (Fwindow_list_1): New functions.
14912 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
14913 (Fwindow_width, Fscroll_left, Fscroll_right):
14914 Use window_body_cols instead of window_box_text_cols.
14915 (delete_window, Fset_window_configuration):
14916 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
14917 (delete_all_subwindows): Take a window as argument and not a
14918 structure. Rewrite.
190b47e6
MR
14919 (window_loop): Remove handling of GET_LRU_WINDOW and
14920 GET_LARGEST_WINDOW.
14921 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
14922
14923 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
14924 window_box_text_cols. delete_all_subwindows now takes a
14925 Lisp_Object as argument.
abde8f8c 14926
640c8776
SM
14927 * indent.c (compute_motion, Fcompute_motion):
14928 Use window_body_cols instead of window_box_text_cols.
abde8f8c 14929
fa8a67e6
MR
14930 * frame.c (delete_frame): Call delete_all_subwindows with root
14931 window as argument.
14932
a54e3482
DC
149332011-06-07 Daniel Colascione <dan.colascione@gmail.com>
14934
14935 * fns.c (Fputhash): Document return value.
14936
60002bf5
CY
149372011-06-06 Chong Yidong <cyd@stupidchicken.com>
14938
14939 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14940
0c671da6 149412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 14942
b862a52a 14943 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 14944
be44ca6c
PE
14945 Check for overflow when converting integer to cons and back.
14946 * charset.c (Fdefine_charset_internal, Fdecode_char):
14947 Use cons_to_unsigned to catch overflow.
14948 (Fencode_char): Use INTEGER_TO_CONS.
14949 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
14950 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
14951 * data.c (long_to_cons, cons_to_long): Remove.
14952 (cons_to_unsigned, cons_to_signed): New functions.
14953 These signal an error for invalid or out-of-range values.
14954 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
14955 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14956 * font.c (Ffont_variation_glyphs):
14957 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14958 * lisp.h: Include <intprops.h>.
14959 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14960 (cons_to_signed, cons_to_unsigned): New decls.
14961 (long_to_cons, cons_to_long): Remove decls.
14962 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14963 (Fprimitive_undo): Use CONS_TO_INTEGER.
14964 * xfns.c (Fx_window_property): Likewise.
14965 * xselect.c: Include <limits.h>.
14966 (x_own_selection, selection_data_to_lisp_data):
14967 Use INTEGER_TO_CONS.
14968 (x_handle_selection_request, x_handle_selection_clear)
14969 (x_get_foreign_selection, Fx_disown_selection_internal)
14970 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14971 (lisp_data_to_selection_data): Use cons_to_unsigned.
14972 (x_fill_property_data): Use cons_to_signed.
14973 Report values out of range.
14974
d1f3d2af
PE
14975 Check for buffer and string overflow more precisely.
14976 * buffer.h (BUF_BYTES_MAX): New macro.
14977 * lisp.h (STRING_BYTES_MAX): New macro.
14978 * alloc.c (Fmake_string):
14979 * character.c (string_escape_byte8):
14980 * coding.c (coding_alloc_by_realloc):
14981 * doprnt.c (doprnt):
14982 * editfns.c (Fformat):
14983 * eval.c (verror):
14984 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14985 since they may not be the same number.
14986 * editfns.c (Finsert_char):
14987 * fileio.c (Finsert_file_contents):
14988 Likewise for BUF_BYTES_MAX.
14989
dd52fcea
PE
14990 * image.c: Use ptrdiff_t, not int, for sizes.
14991 (slurp_file): Switch from int to ptrdiff_t.
14992 All uses changed.
14993 (slurp_file): Check that file size fits in both size_t (for
14994 malloc) and ptrdiff_t (for sanity and safety).
14995
7f9bbdbb
PE
14996 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14997 if b->modtime has its maximal value.
14998
dfe18f82
PE
14999 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
15000
84acfcf0
PE
15001 Don't assume time_t can fit into int.
15002 * buffer.h (struct buffer.modtime): Now time_t, not int.
15003 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
15004 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
15005
ccd9a01a
PE
15006 Minor fixes for signed vs unsigned integers.
15007 * character.h (MAYBE_UNIFY_CHAR):
15008 * charset.c (maybe_unify_char):
15009 * keyboard.c (read_char, reorder_modifiers):
15010 XINT -> XFASTINT, since the integer must be nonnegative.
15011 * ftfont.c (ftfont_spec_pattern):
15012 * keymap.c (access_keymap, silly_event_symbol_error):
15013 XUINT -> XFASTINT, since the integer must be nonnegative.
15014 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
15015 since it makes no difference and we prefer signed.
15016 * keyboard.c (record_char): Use XUINT when all the neighbors do.
15017 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
15018 nonnegative.
15019
d6d100dd
SM
150202011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
15021
15022 * window.h (Fwindow_frame): Declare.
15023
2b6148e4
PE
150242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
15025
15026 * alloc.c: Simplify handling of large-request failures (Bug#8800).
15027 (SPARE_MEMORY): Always define.
15028 (LARGE_REQUEST): Remove.
15029 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
15030
f230ecc9
MR
150312011-06-06 Martin Rudalics <rudalics@gmx.at>
15032
727e958e
MR
15033 * lisp.h: Move EXFUNS for Fframe_root_window,
15034 Fframe_first_window and Fset_frame_selected_window to window.h.
15035
15036 * window.h: Move EXFUNS for Fframe_root_window,
15037 Fframe_first_window and Fset_frame_selected_window here from
15038 lisp.h.
15039
15040 * frame.c (Fwindow_frame, Fframe_first_window)
15041 (Fframe_root_window, Fframe_selected_window)
15042 (Fset_frame_selected_window): Move to window.c.
15043 (Factive_minibuffer_window): Move to minibuf.c.
15044 (Fother_visible_frames_p): New function.
15045
15046 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
15047
f230ecc9
MR
15048 * window.c (decode_window, decode_any_window): Move up in code.
15049 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
15050 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
15051 (Fwindow_buffer): Move up and rewrite doc-string.
15052 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
15053 (Fwindow_prev): New functions.
727e958e
MR
15054 (Fwindow_frame): Move here from frame.c. Accept any window as
15055 argument.
15056 (Fframe_root_window, Fframe_first_window)
15057 (Fframe_selected_window): Move here from frame.c. Accept frame
15058 or arbitrary window as argument. Update doc-strings.
15059 (Fminibuffer_window): Move up in code.
15060 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
15061 (Fset_frame_selected_window): Move here from frame.c.
15062 Marginal rewrite.
727e958e
MR
15063 (Fselected_window, select_window, Fselect_window): Move up in
15064 code. Minor doc-string fixes.
f230ecc9 15065
4d09bcf6
PE
150662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
15067
15068 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
15069 Do not assume that spare memory exists; that assumption is valid
15070 only if SYSTEM_MALLOC.
15071 (LARGE_REQUEST): New macro, so that the issue of large requests
15072 is separated from the issue of spare memory.
15073
810928a2
AS
150742011-06-05 Andreas Schwab <schwab@linux-m68k.org>
15075
172418ad
AS
15076 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
15077 format. (Bug#8806)
15078
43f862f7
AS
15079 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
15080
810928a2
AS
15081 * xfns.c (x_set_scroll_bar_default_width): Move declarations
15082 before statements.
15083
a059fe24
JD
150842011-06-05 Jan Djärv <jan.h.d@swipnet.se>
15085
15086 * gtkutil.c (xg_get_default_scrollbar_width): New function.
15087
15088 * gtkutil.h: Declare xg_get_default_scrollbar_width.
15089
15090 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
15091 min width by calling x_set_scroll_bar_default_width (Bug#8505).
15092
989bf368
JB
150932011-06-05 Juanma Barranquero <lekktu@gmail.com>
15094
15095 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
15096
4b80f674
CY
150972011-06-04 Chong Yidong <cyd@stupidchicken.com>
15098
15099 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
15100 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
15101 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
15102 New error handlers.
4b80f674
CY
15103 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
15104 Obey Vx_select_enable_clipboard_manager. Catch errors in
15105 x_clipboard_manager_save (Bug#8779).
15106 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 15107 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 15108
99a33b77 151092011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
15110
15111 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
15112
99a33b77 151132011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
15114
15115 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
15116 in the current matrix if keep_current_p is non-zero.
15117
8264569d
EZ
151182011-06-04 Eli Zaretskii <eliz@gnu.org>
15119
15120 * bidi.c (bidi_level_of_next_char): Fix last change.
15121
57f97249
EZ
151222011-06-03 Eli Zaretskii <eliz@gnu.org>
15123
fec2107c 15124 Support bidi reordering of text covered by display properties.
57f97249 15125
fec2107c
EZ
15126 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
15127 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
15128 (bidi_cache_search, bidi_cache_iterator_state)
15129 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
15130 (bidi_level_of_next_char, bidi_move_to_visually_next):
15131 Support character positions inside a run of characters covered by a
fec2107c
EZ
15132 display string.
15133 (bidi_paragraph_init, bidi_resolve_explicit_1)
15134 (bidi_level_of_next_char): Call bidi_fetch_char and
15135 bidi_fetch_char_advance instead of FETCH_CHAR and
15136 FETCH_CHAR_ADVANCE.
15137 (bidi_init_it): Initialize new members.
15138 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
15139 definitions.
15140 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
15141 instead of using explicit *_CHAR codes.
d6d100dd
SM
15142 (bidi_resolve_explicit, bidi_resolve_weak):
15143 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
15144 bidirectional text is supported only in multibyte buffers.
15145 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
15146 it to initialize the frame_window_p member of struct bidi_it.
15147 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
15148 (bidi_resolve_explicit, bidi_resolve_weak)
15149 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
15150 bidi_it->nchars is non-positive.
15151 (bidi_level_of_next_char): Don't try to lookup the cache for the
15152 next/previous character if nothing is cached there yet, or if we
15153 were just reseat()'ed to a new position.
c40e2fb2 15154
0e14fe90
EZ
15155 * xdisp.c (set_cursor_from_row): Set start and stop points
15156 according to the row's direction when priming the loop that looks
15157 for the glyph on which to display cursor.
15158 (single_display_spec_intangible_p): Function deleted.
15159 (display_prop_intangible_p): Reimplement to call
15160 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
15161 Accept 3 additional arguments needed by handle_display_spec.
15162 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
15163 values: lists, `(when COND...)' forms, etc.
15164 (single_display_spec_string_p): Support property values that are
15165 lists with the argument STRING its top-level element.
15166 (display_prop_string_p): Fix the condition for processing a
15167 property that is a list to be consistent with handle_display_spec.
fec2107c 15168 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
15169 last portion of handle_display_prop.
15170 (compute_display_string_pos): Accept additional argument
15171 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
15172 value of a `display' property is a "replacing spec".
15173 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
15174 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
15175 the display property, but just return a value indicating whether
15176 the display property will replace the characters it covers.
15177 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
15178 frame_window_p members of struct bidi_it.
d6d100dd
SM
15179 (compute_display_string_pos, compute_display_string_end):
15180 New functions.
fec2107c
EZ
15181 (push_it): Accept second argument POSITION, where pop_it should
15182 jump to continue iteration.
15183 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 15184
fec2107c
EZ
15185 * keyboard.c (adjust_point_for_property): Adjust the call to
15186 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
15187
15188 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
15189 (bidi_init_it): Update prototypes.
15190 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
15191 (compute_display_string_pos, compute_display_string_end):
15192 Declare prototypes.
fec2107c
EZ
15193 (struct bidi_it): New members nchars and disp_pos. ch_len is now
15194 EMACS_INT.
fc6f18ce 15195
40087514 151962011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 15197
57f53182
PE
15198 Malloc failure behavior now depends on size of allocation.
15199 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
15200 * lisp.h: Change signatures accordingly.
15201 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
15202 All callers changed. (Bug#8762)
15203
15204 * gnutls.c: Use Emacs's memory allocators.
15205 Without this change, the gnutls library would invoke malloc etc.
15206 directly, which causes problems on non-SYNC_INPUT hosts, and which
15207 runs afoul of improving memory_full behavior. (Bug#8761)
15208 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
15209 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
15210 xfree instead of the default malloc, realloc, free.
15211 (Fgnutls_boot): No need to check for memory allocation failure,
15212 since xmalloc does that for us.
15213
ac32cd99 15214 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
15215 * category.c (hash_get_category_set):
15216 * ccl.c (ccl_driver):
15217 * charset.c (Fdefine_charset_internal):
15218 * charset.h (struct charset.hash_index):
15219 * composite.c (get_composition_id, gstring_lookup_cache)
15220 (composition_gstring_put_cache):
15221 * composite.h (struct composition.hash_index):
15222 * dispextern.h (struct image.hash):
15223 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
15224 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
15225 (hashfn_equal, hashfn_user_defined, make_hash_table)
15226 (maybe_resize_hash_table, hash_lookup, hash_put)
15227 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
15228 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
15229 (Fsxhash, Fgethash, Fputhash, Fmaphash):
15230 * image.c (make_image, search_image_cache, lookup_image)
15231 (xpm_put_color_table_h):
15232 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 15233 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 15234 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 15235 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
15236 * alloc.c (allocate_vectorlike):
15237 Check for overflow in vector size calculations.
15238 * ccl.c (ccl_driver):
15239 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
15240 * fns.c, image.c: Remove unnecessary static decls that would otherwise
15241 need to be updated by these changes.
40087514
PE
15242 * fns.c (make_hash_table, maybe_resize_hash_table):
15243 Check for integer overflow with large hash tables.
0de4bb68
PE
15244 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
15245 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
15246 (SXHASH_REDUCE): New macro.
15247 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
15248 Use it instead of discarding useful hash info with large hash values.
15249 (sxhash_float): New function.
15250 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
15251 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
15252 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
15253 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
15254 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
15255 Adjust signatures to match updated version of code.
15256 (consing_since_gc): Now EMACS_INT, since a single hash table can
15257 use more than INT_MAX bytes.
15258
698d32e2
DN
152592011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
15260
15261 Make it possible to build with GCC-4.6+ -O2 -flto.
15262
15263 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
15264
fd6fa53f
SM
152652011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
15266
15267 * minibuf.c (get_minibuffer, read_minibuf_unwind):
15268 Call minibuffer-inactive-mode.
15269
864db017
JB
152702011-05-31 Juanma Barranquero <lekktu@gmail.com>
15271
15272 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
15273 Update dependencies.
15274
2ad0baf4
DN
152752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15276
15277 * data.c (init_data): Remove code for UTS, this system is not
15278 supported anymore.
15279
4fcc2638
DN
152802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15281
15282 Don't force ./temacs to start in terminal mode.
15283
15284 * frame.c (make_initial_frame): Initialize faces in all cases, not
15285 only when CANNOT_DUMP is defined.
15286 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
15287
c56e0fd5
DN
152882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15289
15290 * dispnew.c (add_window_display_history): Use const for the string
15291 pointer. Remove declaration, not needed.
15292
333d54da 152932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 15294
55d4c1b2 15295 Use 'inline', not 'INLINE'.
333d54da 15296 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
15297 * alloc.c, fontset.c (INLINE): Remove.
15298 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
15299 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
15300 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
15301 * gmalloc.c (register_heapinfo): Use inline unconditionally.
15302 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
15303
738db178
DN
153042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15305
15306 Make it possible to run ./temacs.
15307
15308 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
15309 syms_of_callproc does the same thing. Remove test for
15310 "initialized", do it in the caller.
15311 * emacs.c (main): Avoid calling set_initial_environment when dumping.
15312
620c53a6
SM
153132011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
15314
15315 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
15316 (read_minibuf): Use get_minibuffer.
15317 (syms_of_minibuf): Use DEFSYM.
15318 (Qmetadata): New var.
15319 * data.c (Qbuffer): Don't make it static.
15320 (syms_of_data): Use DEFSYM.
15321
e003a292
PE
153222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
15323
15324 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
15325 (CCL_CODE_MIN): New macro.
15326
ed008a6d
PE
153272011-05-30 Paul Eggert <eggert@cs.ucla.edu>
15328
3687c2ef
PE
15329 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
15330
ed008a6d
PE
15331 * eval.c (Qdebug): Now static.
15332 * lisp.h (Qdebug): Remove decl. This reverts a part of the
15333 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
15334 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
15335
d66c4c7c
CY
153362011-05-29 Chong Yidong <cyd@stupidchicken.com>
15337
15338 * image.c: Various fixes to ImageMagick code comments.
15339 (Fimagemagick_types): Doc fix.
15340
5fbc2025
PE
153412011-05-29 Paul Eggert <eggert@cs.ucla.edu>
15342
0196f88a
PE
15343 Minor fixes prompted by GCC 4.6.0 warnings.
15344
15345 * xselect.c (converted_selections, conversion_fail_tag): Now static.
15346
5fbc2025
PE
15347 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
15348 (x_clipboard_manager_save_all): Move extern decl to ...
15349 * xterm.h: ... here, so that it can be checked for consistency.
15350
1dd3c2d9
CY
153512011-05-29 Chong Yidong <cyd@stupidchicken.com>
15352
15353 * xselect.c (x_clipboard_manager_save_frame)
15354 (x_clipboard_manager_save_all): New functions.
15355 (Fx_clipboard_manager_save): Lisp function deleted.
15356
15357 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
15358 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
15359
15360 * xterm.h: Update prototype.
15361
5ba6571d
WX
153622011-05-28 William Xu <william.xwl@gmail.com>
15363
15364 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
15365 exiting (Bug#8239).
15366
3eaff834
JM
153672011-05-28 Jim Meyering <meyering@redhat.com>
15368
e1900994 15369 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
15370 * fns.c (to_uchar): Define.
15371 (crypto_hash_function): Use it to convert some newly-signed
15372 variables to unsigned, to avoid sign-extension bugs. For example,
15373 without this change, (md5 "truc") would evaluate to
15374 45723a2aff78ff4fff7fff1114760e62 rather than the expected
15375 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 15376 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 15377
0f6990a7
PE
153782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15379
15380 Integer overflow fixes.
c8a9ca5a 15381
08686060
PE
15382 * dbusbind.c: Serial number integer overflow fixes.
15383 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
15384 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
15385 to hold a serial number that is too large for a fixnum.
15386 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15387 Check for serial numbers out of range. Decode any serial number
59568bf0 15388 that was so large that it became a float. (Bug#8722)
08686060 15389
2d1fc3c7
PE
15390 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
15391 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15392 Use XFASTINT rather than XUINT when numbers are nonnegative.
15393 (xd_append_arg, Fdbus_method_return_internal):
15394 (Fdbus_method_error_internal): Likewise. Also, for unsigned
15395 arguments, check that Lisp number is nonnegative, rather than
59568bf0 15396 silently wrapping negative numbers around. (Bug#8722)
30217ff0 15397 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 15398 (Bug#8722)
2d1fc3c7 15399
c8a9ca5a
PE
15400 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
15401
519e1d69
PE
15402 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
15403
6df6ae42 15404 ccl: Add integer overflow checks.
30569699
PE
15405 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
15406 (IN_INT_RANGE): New macros.
15407 (ccl_driver): Use them to check for integer overflow when
15408 decoding a CCL program. Many of the new checks are whether XINT (x)
15409 fits in int; it doesn't always, on 64-bit hosts. The new version
15410 doesn't catch all possible integer overflows, but it's an
847044ea 15411 improvement. (Bug#8719)
30569699 15412
c11285dc
PE
15413 * alloc.c (make_event_array): Use XINT, not XUINT.
15414 There's no need for unsigned here.
15415
fdccd48e
PE
15416 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
15417 This follows up to the 2011-05-06 change that substituted uintptr_t
15418 for EMACS_INT. This case wasn't caught back then.
15419
37910ab2
PE
15420 Rework Fformat to avoid integer overflow issues.
15421 * editfns.c: Include <float.h> unconditionally, as it's everywhere
15422 now (part of C89). Include <verify.h>.
15423 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
15424 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
15425 (Fformat): Avoid the prepass trying to compute sizes; it was only
15426 approximate and thus did not catch overflow reliably. Instead, walk
15427 through the format just once, formatting and computing sizes as we go,
15428 checking for integer overflow at every step, and allocating a larger
15429 buffer as needed. Keep track separately whether the format is
15430 multibyte. Keep only the most-recently calculated precision, rather
15431 than them all. Record whether each argument has been converted to
15432 string. Use EMACS_INT, not int, for byte and char and arg counts.
15433 Support field widths and precisions larger than INT_MAX. Avoid
15434 sprintf's undefined behavior with conversion specifications such as %#d
15435 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
15436 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
15437 formatting out-of-range floating point numbers with int
9173deec 15438 formats. (Bug#8668)
37910ab2 15439
2e6578fb
PE
15440 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
15441
0ae6bdee
PE
15442 * data.c: Avoid integer truncation in expressions involving floats.
15443 * data.c: Include <intprops.h>.
15444 (arith_driver): When there's an integer overflow in an expression
15445 involving floating point, convert the integers to floating point
15446 so that the resulting value does not suffer from catastrophic
15447 integer truncation. For example, on a 64-bit host (* 4
15448 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
15449 Do not rely on undefined behavior after integer overflow.
15450
de883a70
PE
15451 merge count_size_as_multibyte, parse_str_to_multibyte
15452 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 15453 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
15454 Check for integer overflow.
15455 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
15456 since it's now a duplicate of the other. This is more of
15457 a character than a buffer op, so better that it's in character.c.
15458 * fns.c, print.c: Adjust to above changes.
15459
2ff916cb
PE
154602011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
15461
15462 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
15463
f1b54466
PE
154642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15465
fb1ac845
PE
15466 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15467 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
15468 (x_clipboard_manager_save): Now static.
15469 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
15470
f1b54466
PE
15471 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15472 (crypto_hash_function): Now static.
15473 Fix pointer signedness problems. Avoid unnecessary initializations.
15474
a9f737ee
CY
154752011-05-27 Chong Yidong <cyd@stupidchicken.com>
15476
15477 * termhooks.h (Vselection_alist): Make it terminal-local.
15478
15479 * terminal.c (create_terminal): Initialize it.
15480
15481 * xselect.c: Support for clipboard managers.
15482 (Vselection_alist): Move to termhooks.h as terminal-local var.
15483 (LOCAL_SELECTION): New macro.
15484 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
15485 (symbol_to_x_atom): Remove gratuitous arg.
15486 (x_handle_selection_request, lisp_data_to_selection_data)
15487 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
15488 (x_own_selection, x_get_local_selection, x_convert_selection):
15489 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
15490 (some_frame_on_display): Delete unused function.
15491 (Fx_own_selection_internal, Fx_get_selection_internal)
15492 (Fx_disown_selection_internal, Fx_selection_owner_p)
15493 (Fx_selection_exists_p): New optional frame arg.
15494 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
15495 (x_handle_selection_clear): Don't treat other terminals with the
15496 same keyboard specially. Use the terminal-local Vselection_alist.
15497 (x_clear_frame_selections): Use Frun_hook_with_args.
15498
15499 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
15500
15501 * xterm.h: Add support for those atoms.
15502
e067f0c1
CY
155032011-05-26 Chong Yidong <cyd@stupidchicken.com>
15504
15505 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
15506 (converted_selections, conversion_fail_tag): New global variables.
15507 (x_selection_request_lisp_error): Free the above.
15508 (x_get_local_selection): Remove unnecessary code.
15509 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
15510 of converted selections stored in converted_selections.
15511 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
15512 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
15513 (x_convert_selection): New function.
15514 (x_handle_selection_event): Simplify.
15515 (x_get_foreign_selection): Don't ignore incoming requests while
15516 waiting for an answer; this will fail when we implement
15517 SAVE_TARGETS, and seems unnecessary anyway.
15518 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
15519 (Vx_sent_selection_functions): Doc fix.
15520
0f4aebc0
LL
155212011-05-26 Leo Liu <sdl.web@gmail.com>
15522
15523 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
15524
e61124cd
YM
155252011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15526
15527 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
15528
15529 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
15530 for fringe update if it has periodic bitmap.
ac389d0c 15531 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
15532 and fringe_bitmap_periodic_p.
15533
15534 * fringe.c (get_fringe_bitmap_data): New function.
15535 (draw_fringe_bitmap_1, update_window_fringes): Use it.
15536 (update_window_fringes): Record periodicity of fringe bitmap in glyph
15537 row. Mark glyph row for fringe update if periodicity changed.
15538
15539 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
15540 for fringe update unless it has periodic bitmap.
15541
f16d9837
KH
155422011-05-25 Kenichi Handa <handa@m17n.org>
15543
15544 * xdisp.c (get_next_display_element): Set correct it->face_id for
15545 a static composition.
15546
e1b90ef6
LL
155472011-05-24 Leo Liu <sdl.web@gmail.com>
15548
15549 * deps.mk (fns.o):
15550 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
15551
15552 * fns.c (crypto_hash_function, Fsha1): New function.
15553 (Fmd5): Use crypto_hash_function.
15554 (syms_of_fns): Add Ssha1.
15555
7400048f
PE
155562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15557
15558 * gnutls.c: Remove unused macros.
15559 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
15560 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
15561 Remove macros that are defined and never used.
15562 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
15563
abb71cf4
CY
155642011-05-22 Chong Yidong <cyd@stupidchicken.com>
15565
15566 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
15567 (Fx_get_selection_internal): Minor cleanup.
15568 (Fx_own_selection_internal): Rename arguments for consistency with
15569 select.el.
15570
6307db39
PE
155712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15572
15573 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
15574
f3d4e0a4
CY
155752011-05-22 Chong Yidong <cyd@stupidchicken.com>
15576
15577 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
15578
4d8ade89
YM
155792011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15580
15581 * dispnew.c (scrolling_window): Don't exclude the case that the
15582 last enabled row in the desired matrix touches the bottom boundary.
15583
32078c8d
GM
155842011-05-21 Glenn Morris <rgm@gnu.org>
15585
15586 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
15587 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
15588 and add some more files.
32078c8d 15589
7285dc67
EZ
155902011-05-20 Eli Zaretskii <eliz@gnu.org>
15591
15592 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
15593 report_file_error introduced by the change from 2011-05-07.
15594
89d1bd22
PE
155952011-05-20 Paul Eggert <eggert@cs.ucla.edu>
15596
15597 * systime.h (Time): Define only if emacs is defined.
15598 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
15599 where the include path doesn't have X11/X.h by default. See
15600 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
15601
cd394be1 156022011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
15603
15604 * composite.c (find_automatic_composition): Fix previous change.
15605
b9704ad9
GM
156062011-05-20 Glenn Morris <rgm@gnu.org>
15607
15608 * lisp.mk: New file, split from Makefile.in.
15609 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
15610 (shortlisp): Remove.
15611 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
15612
4a720484
GM
156132011-05-19 Glenn Morris <rgm@gnu.org>
15614
15615 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
15616 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
15617 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
15618 (lisp): Set the order to that of loadup.el.
15619 (shortlisp): Make it a copy of $lisp.
15620 (SOME_MACHINE_LISP): Remove.
15621 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
15622 Use just $shortlisp, not $SOME_MACHINE_LISP too.
15623
a28d4396
KH
156242011-05-18 Kenichi Handa <handa@m17n.org>
15625
15626 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
15627 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
15628 (find_automatic_composition): Mostly rewrite for efficiency.
15629
a2b1fa8e
JB
156302011-05-18 Juanma Barranquero <lekktu@gmail.com>
15631
15632 * makefile.w32-in: Update dependencies.
15633
8e1f5610
CS
156342011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
15635
15636 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 15637 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 15638
7025ee00 156392011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 15640
cdfa6eab
PE
15641 Fix some integer overflow issues, such as string length overflow.
15642
06d6db33
PE
15643 * insdel.c (count_size_as_multibyte): Check for string overflow.
15644
2b4560a8
PE
15645 * character.c (lisp_string_width): Check for string overflow.
15646 Use EMACS_INT, not int, for string indexes and lengths; in
15647 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
15648 the resulting string length overflows an EMACS_INT; instead,
15649 report a string overflow if no precision given. When checking for
15650 precision exhaustion, use a check that cannot possibly have
15651 integer overflow. (Bug#8675)
15652 * character.h (lisp_string_width): Adjust to new signature.
15653
cb93f9be
PE
15654 * alloc.c (string_overflow): New function.
15655 (Fmake_string): Use it. This doesn't change behavior, but saves
15656 a few bytes and will simplify future changes.
15657 * character.c (string_escape_byte8): Likewise.
15658 * lisp.h (string_overflow): New decl.
15659
1a1f3366
PE
15660 Fixups, following up to the user-interface timestamp change.
15661 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
15662 for UI timestamps, instead of unsigned long.
9fbd6841
PE
15663 * msdos.c (mouse_get_pos): Likewise.
15664 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
15665 * w32gui.h (Time): Define by including "systime.h" rather than by
15666 declaring it ourselves. (Bug#8664)
15667
d4e3e4d3
PE
15668 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
15669 * image.c (clear_image_cache): Likewise.
15670
f6a24d19
PE
15671 * term.c (term_mouse_position): Don't assume time_t wraparound.
15672
08dc5ae6
PE
15673 Be more systematic about user-interface timestamps.
15674 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
15675 and sometimes 'EMACS_UINT', to represent these timestamps.
15676 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
15677 This makes the code easier to follow, and makes it easier to catch
15678 integer overflow bugs such as Bug#8664.
15679 * frame.c (Fmouse_position, Fmouse_pixel_position):
15680 Use Time, not unsigned long, for user-interface timestamps.
15681 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
15682 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
15683 * keyboard.h (last_event_timestamp): Likewise.
15684 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
15685 * menu.h (xmenu_show): Likewise.
15686 * term.c (term_mouse_position): Likewise.
15687 * termhooks.h (struct input_event.timestamp): Likewise.
15688 (struct terminal.mouse_position_hook): Likewise.
15689 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
15690 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
15691 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
15692 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
15693 what it was before.
15694 * menu.h, termhooks.h: Include "systime.h", for Time.
15695
8e55734a
PE
15696 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
15697 Don't assume that the difference between two unsigned long values
15698 can fit into an integer. At this point, we know button_down_time
15699 <= event->timestamp, so the difference must be nonnegative, so
15700 there's no need to cast the result if double-click-time is
15701 nonnegative, as it should be; check that it's nonnegative, just in
15702 case. This bug is triggered when events are more than 2**31 ms
86db42d2 15703 apart (about 25 days). (Bug#8664)
8e55734a 15704
841f1b75 15705 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 15706 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 15707
3e26f69c
PE
15708 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
15709 that always fit in int. Use a sentinel instead of a counter, to
15710 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
15711 * frame.h (struct frame): Use int for menu_bar_items_used
15712 instead of EMACS_INT, since it always fits in int.
3e26f69c 15713
5cc152c0
PE
15714 * menu.c (grow_menu_items): Check for int overflow.
15715
d89eb65e
PE
15716 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
15717
5235bd3e
PE
15718 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
15719 Before, the code was not consistent. These values cannot exceed
15720 2**31 - 1 so there's no need to make them unsigned.
15721 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
15722 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
15723 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
15724 as modifiers.
15725 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
15726
bc827e23
PE
15727 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
15728 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
15729 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
15730 presumably because the widths might not match.
15731
78eb494e
PE
15732 * window.c (size_window): Avoid needless test at loop start.
15733
04f2d78b
CB
157342011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
15735
15736 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
15737
d2fc7e3d 157382011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
15739
15740 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
15741
d2fc7e3d 157422011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
15743
15744 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
15745 `width' to `bar_area_x' and `bar_area_width', respectively.
15746 (x_scroll_run): Take account of fringe background extension.
15747
04f2d78b
CB
15748 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
15749 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
15750 `bar_area_width', respectively.
15751 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
15752 background extension.
15753
79b70037
GM
157542011-05-10 Jim Meyering <meyering@redhat.com>
15755
15756 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
15757
2f142cc5
JB
157582011-05-10 Juanma Barranquero <lekktu@gmail.com>
15759
15760 * image.c (Finit_image_library): Return t for built-in image types,
15761 like pbm and xbm. (Bug#8640)
15762
57679c86
AS
157632011-05-09 Andreas Schwab <schwab@linux-m68k.org>
15764
15765 * w32menu.c (set_frame_menubar): Fix submenu allocation.
15766
888c9e86
EZ
157672011-05-07 Eli Zaretskii <eliz@gnu.org>
15768
b0512a1d
EZ
15769 * w32console.c (Fset_screen_color): Doc fix.
15770 (Fget_screen_color): New function.
15771 (syms_of_ntterm): Defsubr it.
15772
7285dc67
EZ
15773 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
15774 unlink the temporary file if Fcall_process didn't create it in the
15775 first place.
15776 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
15777 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
15778 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
15779 cue to call_process_cleanup not to close that handle.
15780
4d3fcc8e
BK
157812011-05-07 Ben Key <bkey76@gmail.com>
15782
15783 * makefile.w32-in: The bootstrap-temacs rule now makes use of
15784 one of two shell specific rules, either bootstrap-temacs-CMD or
15785 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
15786 to the previous implementation of the bootstrap-temacs rule.
15787 The bootstrap-temacs-CMD rule is similar to the previous
15788 implementation of the bootstrap-temacs rule except that it
15789 makes use of the ESC_CFLAGS variable instead of the CFLAGS
15790 variable.
15791
15792 These changes, along with some changes to nt/configure.bat,
15793 nt/gmake.defs, and nt/nmake.defs, are required to extend my
15794 earlier fix to add support for --cflags and --ldflags options
15795 that include quotes so that it works whether make uses cmd or
15796 sh as the shell.
15797
b4289b64
MA
157982011-05-06 Michael Albinus <michael.albinus@gmx.de>
15799
15800 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
15801 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
15802 is a constant.
15803 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
15804 a string. Handle both cases.
15805 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
15806 (Fdbus_register_method): Use Qinvalid_function.
15807
af4c0e28
JB
158082011-05-06 Juanma Barranquero <lekktu@gmail.com>
15809
15810 * makefile.w32-in: Update dependencies.
15811 (LISP_H): Add inttypes.h and stdin.h.
15812 (PROCESS_H): Add unistd.h.
15813
c51453d9
EZ
158142011-05-06 Eli Zaretskii <eliz@gnu.org>
15815
15816 * lread.c: Include limits.h (fixes the MS-Windows build broken by
15817 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
15818
8ff0ac3c 158192011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 15820
4c4b566b
PE
15821 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
15822
aab2b9b5
PE
15823 * term.c (vfatal): Remove stray call to va_end.
15824 It's not needed and the C Standard doesn't allow it here anyway.
15825
c378da0b
PE
15826 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
15827 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
15828
288b08c7
PE
15829 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
15830 bytes.
15831
e3601888
PE
15832 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
15833
db6c0e74
PE
15834 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
15835
dd5963ea
PE
15836 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
15837
88c9450f
PE
15838 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
15839
2f9442b8
PE
15840 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
15841
c032b5f8
PE
15842 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
15843 * charset.c (Fdefine_charset_internal): Don't initialize
15844 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 15845 32-bit int (Bug#8600).
a108c10b
PE
15846
15847 * lread.c (read_integer): Be more consistent with string-to-number.
15848 Use string_to_number to do the actual conversion; this avoids
15849 rounding errors and fixes some other screwups. Without this fix,
15850 for example, #x1fffffffffffffff was misread as -2305843009213693952.
15851 (digit_to_number): Move earlier, for benefit of read_integer.
15852 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 15853 not a digit in any supported base. (Bug#8602)
a108c10b 15854
ad5f9eea
PE
15855 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
15856
aec1708a
PE
15857 * dispnew.c (scrolling_window): Return 1 if we scrolled,
15858 to match comment at start of function. This also removes a
15859 GCC warning about overflow in a 32+64-bit port.
15860
47be4ab5
PE
15861 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
15862
371cac43
PE
15863 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
15864 Reported by Stefan Monnier in
15865 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
15866 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15867 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 15868
d01a7826
PE
15869 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
15870 (EMACS_UINTPTR): Likewise, with uintptr_t.
15871
7fd47d5c
PE
15872 * lisp.h: Prefer 64-bit EMACS_INT if available.
15873 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
15874 on 32-bit hosts that have 64-bit int, so that they can access
15875 large files.
122b0c86
PE
15876 However, temporarily disable this change unless the temporary
15877 symbol WIDE_EMACS_INT is defined.
7fd47d5c 15878
8727937b
PE
15879 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
15880
8ac068ac
PE
15881 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
15882 This removes an assumption that EMACS_INT and long are the same
15883 width as pointers. The assumption is true for Emacs porting targets
15884 now, but we want to make other targets possible.
15885 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
15886 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
15887 In the rest of the code, change types of integers that hold casted
15888 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
15889 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
15890 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
15891 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
15892 No need to cast type when ORing.
15893 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
15894 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
15895 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
15896 assume EMACS_INT is the same width as char *.
15897 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
15898 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
15899 Remove no-longer-needed casts.
15900 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
15901 (xg_tool_bar_help_callback, xg_make_tool_item):
15902 Use EMACS_INTPTR to hold an integer
15903 that will be cast to void *; this can avoid a GCC warning
15904 if EMACS_INT is not the same width as void *.
15905 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
15906 * xdisp.c (display_echo_area_1, resize_mini_window_1):
15907 (current_message_1, set_message_1):
15908 Use a local to convert to proper width without a cast.
15909 * xmenu.c (dialog_selection_callback): Likewise.
15910
ede49d71
PE
15911 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
15912 Also, don't assume VALBITS / RAND_BITS is less than 5,
15913 and don't rely on undefined behavior when shifting a 1 left into
15914 the sign bit.
15915 * lisp.h (get_random): Change signature to match.
15916
2f30ecd0
PE
15917 * lread.c (hash_string): Use size_t, not int, for hash computation.
15918 Normally we prefer signed values; but hashing is special, because
15919 it's better to use unsigned division on hash table sizes so that
15920 the remainder is nonnegative. Also, size_t is the natural width
15921 for hashing into memory. The previous code used 'int', which doesn't
15922 retain enough info to hash well into very large tables.
15923 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
15924
2a866e7b
PE
15925 * dbusbind.c: Don't possibly lose pointer info when converting.
15926 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15927 Use XPNTR rather than XHASH, so that the high-order bits of
15928 the pointer aren't lost when converting through void *.
15929
51639eac
PE
15930 * eval.c (Fautoload): Don't double-shift a pointer.
15931
92394119
PE
15932 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
15933
dbdb9a7c
JB
159342011-05-06 Juanma Barranquero <lekktu@gmail.com>
15935
15936 * gnutls.c (DEF_GNUTLS_FN):
15937 * image.c (DEF_IMGLIB_FN): Make function pointers static.
15938
db7a0b4f
AS
159392011-05-05 Andreas Schwab <schwab@linux-m68k.org>
15940
15941 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
15942 marker. (Bug#8610)
15943
cd394be1 159442011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
15945
15946 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
15947 New version that can reserve upto 2GB of heap space.
15948
f7ff1b0f 159492011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
15950
15951 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
15952
639c109b
TZ
159532011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
15954
15955 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15956 `gnutls_certificate_set_x509_key_file'.
15957
d2127135
JB
159582011-05-05 Juanma Barranquero <lekktu@gmail.com>
15959
15960 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15961 Update dependencies.
15962
e968f4f3
JB
159632011-05-04 Juanma Barranquero <lekktu@gmail.com>
15964
15965 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15966 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15967 Remove unused parameter `fildes'.
15968 * process.c (read_process_output, send_process): Don't pass it.
15969
84d358f0
JB
159702011-05-04 Juanma Barranquero <lekktu@gmail.com>
15971
15972 Fix previous change: the library cache is defined in w32.c.
15973 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15974 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15975
0898ca10
JB
159762011-05-04 Juanma Barranquero <lekktu@gmail.com>
15977
15978 Implement dynamic loading of GnuTLS on Windows.
15979
15980 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15981 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15982 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15983 Declare.
15984
15985 * gnutls.c (Qgnutls_dll): Define.
15986 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15987 (gnutls_*): Declare function pointers.
15988 (init_gnutls_functions): New function to initialize function pointers.
15989 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15990 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15991 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15992 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15993 (emacs_gnutls_write, emacs_gnutls_read)
15994 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15995 (Fgnutls_available_p): New function.
15996 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15997 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15998 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15999
16000 * image.c: Include w32.h.
16001 (Vimage_type_cache): Delete.
16002 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
16003 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
16004 (w32_delayed_load): Move to w32.c.
16005
16006 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
16007
16008 * w32.c (QCloaded_from, Vlibrary_cache): Define.
16009 (w32_delayed_load): Move from image.c. When loading a library, record
16010 its filename in the :loaded-from property of the library id.
16011 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
16012 Initialize and staticpro them.
16013 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
16014
16015 * process.c: Include lisp.h before w32.h, not after.
16016 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
16017 instead of gnutls_record_check_pending.
16018
16019 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
16020
ff4de4aa
TZ
160212011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
16022
16023 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
16024 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
16025 as passed in.
16026
abe95abb
JD
160272011-05-03 Jan Djärv <jan.h.d@swipnet.se>
16028
16029 * xterm.c (x_set_frame_alpha): Do not set property on anything
16030 else than FRAME_X_OUTER_WINDOW (Bug#8608).
16031
e16e55d4
JB
160322011-05-02 Juanma Barranquero <lekktu@gmail.com>
16033
16034 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
16035
bafcf6a5
JB
160362011-05-02 Juanma Barranquero <lekktu@gmail.com>
16037
16038 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
16039 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
16040 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
16041 (gnutls_global_initialized, Qgnutls_bootprop_priority)
16042 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
16043 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
16044 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
16045 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
16046 (Qgnutls_bootprop_callbacks_verify): Make static.
16047
e7a6747f
AS
160482011-05-01 Andreas Schwab <schwab@linux-m68k.org>
16049
19ed11ba
AS
16050 * callproc.c: Indentation fixup.
16051
e7a6747f 16052 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
16053 (wait_for_termination, interruptible_wait_for_termination):
16054 Move after wait_for_termination_1.
e7a6747f 16055
1ef14cb4
LMI
160562011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
16057
16058 * sysdep.c (interruptible_wait_for_termination): New function
16059 which is like wait_for_termination, but allows keyboard
16060 interruptions.
16061
16062 * callproc.c (Fcall_process): Add (:file "file") as an option for
16063 the STDOUT buffer.
16064 (Fcall_process_region): Ditto.
16065
330d880c
EZ
160662011-04-30 Eli Zaretskii <eliz@gnu.org>
16067
8db90b73
EZ
16068 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
16069 rather than `XVECTOR (FOO)->size'.
16070
330d880c
EZ
16071 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
16072 inttypes.h, as a gnulib replacement is used if it not available in
16073 system headers.
16074
15cbd324
EZ
160752011-04-21 Eli Zaretskii <eliz@gnu.org>
16076
16077 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
16078 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
16079 of MOST_POSITIVE_FIXNUM. (Bug#8528)
16080
16081 * coding.c (coding_alloc_by_realloc): Error out if destination
16082 will grow beyond MOST_POSITIVE_FIXNUM.
16083 (decode_coding_emacs_mule): Abort if there isn't enough place in
16084 charbuf for the composition carryover bytes. Reserve an extra
16085 space for up to 2 characters produced in a loop.
16086 (decode_coding_iso_2022): Abort if there isn't enough place in
16087 charbuf for the composition carryover bytes.
16088
160892011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 16090
ae940cca
EZ
16091 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
16092 aborting when %lld or %lll format is passed.
16093 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
16094 %llo or %llx format is passed. (Bug#8545)
16095
03ab8921
EZ
16096 * window.c (window_scroll_line_based): Use a marker instead of
16097 simple variables to record original value of point. (Bug#7952)
16098
afda1437
EZ
16099 * doprnt.c (doprnt): Fix the case where a multibyte sequence
16100 produced by %s or %c overflows available buffer space. (Bug#8545)
16101
f76dee0c
PE
161022011-04-28 Paul Eggert <eggert@cs.ucla.edu>
16103
16104 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 16105 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 16106
fdc5744d
JB
161072011-04-28 Juanma Barranquero <lekktu@gmail.com>
16108
16109 * w32.c (init_environment): Warn about defaulting HOME to C:\.
16110
638f053a
JB
161112011-04-28 Juanma Barranquero <lekktu@gmail.com>
16112
16113 * keyboard.c (Qdelayed_warnings_hook): Define.
16114 (command_loop_1): Run `delayed-warnings-hook'
16115 if Vdelayed_warnings_list is non-nil.
16116 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
16117 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
16118
d178f871
EZ
161192011-04-28 Eli Zaretskii <eliz@gnu.org>
16120
16121 * doprnt.c (doprnt): Don't return value smaller than the buffer
16122 size if the message was truncated. (Bug#8545).
16123
b124fd93
JB
161242011-04-28 Juanma Barranquero <lekktu@gmail.com>
16125
16126 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
16127 (Fx_window_property): #if-0 the whole functions, not just the bodies.
16128
e810457d
PE
161292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
16130
16131 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
16132
ea51cceb
JB
161332011-04-27 Juanma Barranquero <lekktu@gmail.com>
16134
16135 * makefile.w32-in: Update dependencies.
16136
94dcfacf
EZ
161372011-04-27 Eli Zaretskii <eliz@gnu.org>
16138
16139 Improve `doprnt' and its usage. (Bug#8545)
16140 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
16141 `format_end'. Remove support for %l as a conversion specifier.
16142 Don't use xrealloc. Improve diagnostics when the %l size modifier
16143 is used. Update the commentary.
16144
16145 * eval.c (verror): Simplify calculation of size_t.
16146
16147 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
16148 messages.
16149
f61f41d7
PE
161502011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
16151
16152 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
16153 change.
16154
96fb4434
PE
161552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
16156
16157 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
16158 This makes this file independent of the recent pseudovector change.
16159
671875da 161602011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 16161
69e9b5a3
PE
16162 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
16163
b5f869a7 16164 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 16165 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 16166 Remove unused local.
c8926152 16167 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 16168
841a1577 16169 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
16170 GCC 4.6.0 optimizes based on type-based alias analysis.
16171 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
16172 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
16173 != &v->size, and therefore "v->size = 1; b->size = 2; return
16174 v->size;" must therefore return 1. This assumption is incorrect
16175 for Emacs, since it type-puns struct Lisp_Vector * with many other
16176 types. To fix this problem, this patch adds a new type struct
f904488f 16177 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
16178 and pseudovectors, and helps optimizing compilers not get fooled
16179 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
16180 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
16181 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
16182 the size member.
eab3844f
PE
16183 (XSETPVECTYPE): Rewrite in terms of new macro.
16184 (XSETPVECTYPESIZE): New macro, specifying both type and size.
16185 This is a bit clearer, and further avoids the possibility of
16186 undesirable aliasing.
16187 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 16188 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
16189 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
16190 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
16191 (ASIZE): Now uses header.size rather than size.
16192 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
16193 to avoid the hassle of writing XVECTOR (foo)->header.size.
16194 (struct vectorlike_header): New type.
eab3844f
PE
16195 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
16196 object, to help avoid aliasing.
16197 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
16198 (SUBRP): Likewise, since Lisp_Subr is a special case.
16199 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
16200 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
16201 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 16202 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
16203 changed to be "header.size" and "header.next".
16204 * buffer.h (struct buffer): Likewise.
16205 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
16206 * frame.h (struct frame): Likewise.
16207 * process.h (struct Lisp_Process): Likewise.
16208 * termhooks.h (struct terminal): Likewise.
16209 * window.c (struct save_window_data, struct saved_window): Likewise.
16210 * window.h (struct window): Likewise.
16211 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
16212 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
16213 * buffer.c (init_buffer_once): Likewise.
16214 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
16215 special case.
16216 * process.c (Fformat_network_address): Use local var for size,
16217 for brevity.
16218
0df1eac5
PE
16219 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
16220
847ab9d1 16221 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
16222 * data.c (atof): Remove decl; no longer used or needed.
16223 (digit_to_number): Move to lread.c.
16224 (Fstring_to_number): Use new string_to_number function, to be
16225 consistent with how the Lisp reader treats infinities and NaNs.
16226 Do not assume that floating-point numbers represent EMACS_INT
16227 without losing information; this is not true on most 64-bit hosts.
16228 Avoid double-rounding errors, by insisting on integers when
16229 parsing non-base-10 numbers, as the documentation specifies.
16230 * lisp.h (string_to_number): New decl, replacing ...
16231 (isfloat_string): Remove.
bc0a5c13 16232 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 16233 (read1): Do not accept +. and -. as integers; this
452f4150
PE
16234 appears to have been a coding error. Similarly, do not accept
16235 strings like +-1e0 as floating point numbers. Do not report
16236 overflow for integer overflows unless the base is not 10 which
16237 means we have no simple and reliable way to continue.
16238 Break out the floating-point parsing into a new
16239 function string_to_number, so that Fstring_to_number parses
16240 floating point numbers consistently with the Lisp reader.
04f2d78b 16241 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
16242 (E_CHAR, EXP_INT): Remove, replacing with ...
16243 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
16244 (string_to_number): New function, replacing isfloat_string.
16245 This function checks for valid syntax and produces the resulting
16246 Lisp float number too. Rework it so that string-to-number
bc0a5c13 16247 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
16248 so that overflow for non-base-10 numbers is reported only when
16249 there's no portable and simple way to convert to floating point.
452f4150 16250
67769ffc
PE
16251 * textprop.c (set_text_properties_1): Rewrite for clarity,
16252 and to avoid GCC warning about integer overflow.
16253
c20db43f
PE
16254 * intervals.h (struct interval): Use EMACS_INT for members
16255 where EMACS_UINT might cause problems. See
16256 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
16257 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
16258 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
16259 All uses changed.
37aa2f85
PE
16260 (offset_intervals): Tell GCC not to worry about length overflow
16261 when negating a negative length.
c20db43f 16262
2538aa2f
PE
16263 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
16264 (overrun_check_free): Likewise.
16265
f2d3008d
PE
16266 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
16267 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
16268 word size.
16269
ec8df744
PE
16270 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
16271 (gnutls_make_error): Rename local to avoid shadowing.
16272 (gnutls_emacs_global_deinit): ifdef out; not used.
16273 (Fgnutls_boot): Use const for pointer to readonly storage.
16274 Comment out unused local. Fix pointer signedness problems.
16275
640ee02d
PE
16276 * lread.c (openp): Don't stuff size_t into an 'int'.
16277 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
16278 about possible signed overflow.
16279
6048fb2a
PE
16280 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
16281 (GDK_KEY_g): Don't define if already defined.
16282 (xg_prepare_tooltip): Avoid pointer signedness problem.
16283 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
16284
fa3c87e1
PE
16285 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
16286 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
16287
2172544b
PE
16288 * xfns.c (Fx_window_property): Simplify a bit,
16289 to make a bit faster and to avoid GCC 4.6.0 warning.
16290 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
16291
9b821a21
PE
16292 * fns.c (internal_equal): Don't assume size_t fits in int.
16293
3c616cfa
PE
16294 * alloc.c (compact_small_strings): Tighten assertion a little.
16295
c2982e87
PE
16296 Replace pEd with more-general pI, and fix some printf arg casts.
16297 * lisp.h (pI): New macro, generalizing old pEd macro to other
16298 conversion specifiers. For example, use "...%"pI"d..." rather
16299 than "...%"pEd"...".
16300 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 16301 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
16302 * alloc.c (check_pure_size): Don't overflow by converting size to int.
16303 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
16304 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
16305 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
16306 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
16307 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
16308 64-bit hosts.
16309 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
16310 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
16311 * print.c (safe_debug_print, print_object): Likewise.
16312 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
16313 to int.
6f04d126
PE
16314 Use pI instead of if-then-else-abort. Use %p to avoid casts,
16315 avoiding the 0 flag, which is not portable.
c2982e87
PE
16316 * process.c (Fmake_network_process): Use pI to avoid cast.
16317 * region-cache.c (pp_cache): Likewise.
16318 * xdisp.c (decode_mode_spec): Likewise.
16319 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
16320 behavior on 64-bit hosts with printf arg.
6f04d126 16321 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
16322 (x_stop_queuing_selection_requests): Likewise.
16323 (x_get_window_property): Don't truncate byte count to an 'int'
16324 when tracing.
0b432f21 16325
5e073ec7
PE
16326 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
16327 here, since it parses constructs like leading '-' and spaces,
16328 which are not wanted; and it overflows with large numbers.
16329 Instead, simply match F[0-9]+, which is what is wanted anyway.
16330
36372bf9
PE
16331 * alloc.c: Remove unportable assumptions about struct layout.
16332 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
16333 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
16334 (allocate_vectorlike, make_pure_vector): Use the new macros,
16335 plus offsetof, to remove unportable assumptions about struct layout.
16336 These assumptions hold on all porting targets that I know of, but
16337 they are not guaranteed, they're easy to remove, and removing them
16338 makes further changes easier.
16339
0b432f21
PE
16340 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
16341 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
16342 (string_overrun_cookie): Now const. Use initializers that
16343 don't formally overflow signed char, to avoid warnings.
000098c1
PE
16344 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
16345 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
16346 (allocate_buffer): Don't assume sizeof (struct buffer) is a
16347 multiple of sizeof (EMACS_INT); it need not be, if
16348 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 16349 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 16350
895009e1
JB
163512011-04-26 Juanma Barranquero <lekktu@gmail.com>
16352
16353 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
16354
6a7a1b0b
TZ
163552011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
16356
16357 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 16358 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
16359 Reported by Paul Eggert <eggert@cs.ucla.edu>.
16360
841a1577 163612011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
16362
16363 * lisp.h (Qdebug): List symbol.
895009e1 16364 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
16365 * keyboard.c (debug-on-event): New variable.
16366 (handle_user_signal): Break into debugger when debug-on-event
16367 matches the current signal symbol.
16368
f2d3ba6f
DN
163692011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
16370
16371 * alloc.c (check_sblock, check_string_bytes)
16372 (check_string_free_list): Convert to standard C.
16373
42ce4c63
TZ
163742011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
16375
16376 * w32.c (emacs_gnutls_push): Fix typo.
16377
825cd63c
EZ
163782011-04-25 Eli Zaretskii <eliz@gnu.org>
16379
fb11d64d
EZ
16380 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
16381 "cast to pointer from integer of different size".
16382
825cd63c
EZ
16383 Improve doprnt and its use in verror. (Bug#8545)
16384 * doprnt.c (doprnt): Document the set of format control sequences
16385 supported by the function. Use SAFE_ALLOCA instead of always
16386 using `alloca'.
16387
16388 * eval.c (verror): Don't limit the buffer size at size_max-1, that
16389 is one byte too soon. Don't use xrealloc; instead xfree and
16390 xmalloc anew.
16391
e061a11b
TZ
163922011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
16393
16394 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
16395 callbacks stage.
16396
16397 * gnutls.c: Renamed global_initialized to
16398 gnutls_global_initialized. Added internals for the
16399 :verify-hostname-error, :verify-error, and :verify-flags
16400 parameters of `gnutls-boot' and documented those parameters in the
16401 docstring. Start callback support.
9173deec
JB
16402 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
16403 unless a fatal error occurred. Call gnutls_alert_send_appropriate
16404 on error. Return error code.
e061a11b
TZ
16405 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
16406 (emacs_gnutls_read): Likewise.
16407 (Fgnutls_boot): Return handshake error code.
16408 (emacs_gnutls_handle_error): New function.
16409 (wsaerror_to_errno): Likewise.
16410
16411 * w32.h (emacs_gnutls_pull): Add prototype.
16412 (emacs_gnutls_push): Likewise.
16413
16414 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
16415 (emacs_gnutls_push): Likewise.
16416
164172011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
16418
16419 * process.c (wait_reading_process_output): Check if GnuTLS
16420 buffered some data internally if no FDs are set for TLS
16421 connections.
16422
16423 * makefile.w32-in (OBJ2): Add gnutls.$(O).
16424 (LIBS): Link to USER_LIBS.
16425 ($(BLD)/gnutls.$(0)): New target.
16426
fa6996bc
EZ
164272011-04-24 Eli Zaretskii <eliz@gnu.org>
16428
eb35682e
EZ
16429 * xdisp.c (handle_single_display_spec): Rename the
16430 display_replaced_before_p argument into display_replaced_p, to
16431 make it consistent with the commentary. Fix typos in the
16432 commentary.
16433
e2ad650c
EZ
16434 * textprop.c (syms_of_textprop): Remove dead code.
16435 (copy_text_properties): Delete obsolete commentary about an
16436 interface that was deleted long ago. Fix typos in the description
16437 of arguments.
16438
1b2de274
EZ
16439 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
16440 to changes in oldXMenu/XMenu.h from 2011-04-16.
16441 <menu_help_message, prev_menu_help_message>: Constify.
16442 (IT_menu_make_room): menu->help_text is now `const char **';
16443 adjust.
16444
16445 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
16446 to changes in oldXMenu/XMenu.h from 2011-04-16.
16447 (struct XMenu): Declare `help_text' `const char **'.
16448
16449 * xfaces.c <Qunspecified>: Make extern again.
16450
16451 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 16452 required by POSIX.
1b2de274 16453
762b15be
EZ
16454 * doc.c (get_doc_string): Improve the format passed to `error'.
16455
16456 * doprnt.c (doprnt): Improve commentary.
16457
16458 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
16459
16460 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
16461 them with etags.
16462
f1052e5d
EZ
16463 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
16464 changes in globals.h immediately force recompilation.
762b15be
EZ
16465 (TAGS): Depend on $(CURDIR)/m/intel386.h and
16466 $(CURDIR)/s/ms-w32.h.
16467 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 16468
fa6996bc
EZ
16469 * character.c (Fchar_direction): Function deleted.
16470 (syms_of_character): Don't defsubr it.
16471 <char-direction-table>: Deleted.
16472
e6c3da20
EZ
164732011-04-23 Eli Zaretskii <eliz@gnu.org>
16474
16475 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
16476 * doprnt.c: Include limits.h.
16477 (SIZE_MAX): New macro.
04f2d78b
CB
16478 (doprnt): Return a size_t value. 2nd arg is now size_t.
16479 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
16480 Improve overflow protection. Support `l' modifier for integer
16481 conversions. Support %l conversion. Don't assume an EMACS_INT
16482 argument for integer conversions and for %c.
16483
16484 * lisp.h (doprnt): Restore prototype.
16485
16486 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
16487 $(SRC)/character.h.
16488
16489 * Makefile.in (base_obj): Add back doprnt.o.
16490
16491 * deps.mk (doprnt.o): Add back prerequisites.
16492 (callint.o): Depend on character.h.
16493
16494 * eval.c (internal_lisp_condition_case): Include the handler
16495 representation in the error message.
16496 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
16497 when breaking from the loop.
16498
16499 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
16500
16501 * callint.c (Fcall_interactively): When displaying error message
16502 about invalid control letter, pass the character's codepoint, not
16503 a pointer to its multibyte form. Improve display of the character
16504 in octal and display also its hex code.
16505
16506 * character.c (char_string): Use %x to display the (unsigned)
16507 codepoint of an invalid character, to avoid displaying a bogus
16508 negative value.
16509
16510 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
16511 `error', not SYMBOL_NAME itself.
16512
16513 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
16514 character arguments to `error'.
16515
16516 * charset.c (check_iso_charset_parameter): Fix incorrect argument
16517 to `error' in error message about FINAL_CHAR argument. Make sure
16518 FINAL_CHAR is a character, and use %c when it is passed as
16519 argument to `error'.
16520
4ffd0d6b 165212011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
16522
16523 * s/ms-w32.h (localtime): Redirect to sys_localtime.
16524
16525 * w32.c: Include <time.h>.
16526 (sys_localtime): New function.
16527
4ffd0d6b 165282011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
16529
16530 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
16531
4ffd0d6b 16532 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 16533
4ffd0d6b 165342011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 16535
4ffd0d6b
GM
16536 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
16537 zombies (Bug#8467).
aac0c6e3 16538
04c56954
EZ
165392011-04-19 Eli Zaretskii <eliz@gnu.org>
16540
16541 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
16542 gl_state.e_property when gl_state.object is Qt.
16543
16544 * insdel.c (make_gap_larger): Remove limitation of buffer size
16545 to <= INT_MAX.
16546
16a43933
CY
165472011-04-18 Chong Yidong <cyd@stupidchicken.com>
16548
16549 * xdisp.c (lookup_glyphless_char_display)
16550 (produce_glyphless_glyph): Handle cons cell entry in
16551 glyphless-char-display.
16552 (Vglyphless_char_display): Document it.
16553
16554 * term.c (produce_glyphless_glyph): Handle cons cell entry in
16555 glyphless-char-display.
16556
4581706e
CY
165572011-04-17 Chong Yidong <cyd@stupidchicken.com>
16558
16559 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
16560
16561 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
16562
16563 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
16564 definition for no-X builds.
16565
4887c6e2 165662011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 16567
fd35b6f9
PE
16568 Static checks with GCC 4.6.0 and non-default toolkits.
16569
5c1ccb01
PE
16570 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
16571
006c5daa
PE
16572 * process.c (keyboard_bit_set): Define only if SIGIO.
16573 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
16574 (send_process): Repair possible setjmp clobbering.
16575
efc736d3
PE
16576 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
16577
4e2fe2e6
PE
16578 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
16579
f97334a2
PE
16580 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
16581
4e75f29d
PE
16582 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
16583 Define only if needed.
16584
90efadd1
PE
16585 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
16586 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 16587 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 16588
3c647824
PE
16589 * dispextern.h (struct redisplay_interface): Rename param
16590 to avoid shadowing.
e264f262 16591 * termhooks.h (struct terminal): Likewise.
761383f4 16592 * xterm.c (xembed_send_message): Likewise.
3c647824 16593
b58c5c4a
PE
16594 * insdel.c (make_gap_smaller): Define only if
16595 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
16596
cad59032
PE
16597 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
16598 it.
16599
c339dc2e
PE
16600 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
16601 so that we aren't warned about unused symbols.
16602
91a3e27b
PE
16603 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
16604
399c71d3 16605 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 16606
8ffc96f5
PE
16607 * xfns.c (x_real_positions): Mark locals as initialized.
16608
eef9bc79
PE
16609 * xmenu.c (xmenu_show): Don't use uninitialized vars.
16610
098db9dd
PE
16611 * xterm.c: Fix problems found by static analysis with other toolkits.
16612 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
16613 (x_dispatch_event): Declare static if USE_GTK, and
16614 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 16615 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 16616 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
16617 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
16618 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 16619
eb18f6cc
PE
16620 * xmenu.c (menu_help_callback): Pointer type fixes.
16621 Use const pointers when pointing at readonly data. Avoid pointer
16622 signedness clashes.
16623 (FALSE): Remove unused macro.
16624 (update_frame_menubar): Remove unused decl.
16625
1fe72bf8
PE
16626 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
16627
60d9e1db
PE
16628 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
16629 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
16630 (single_menu_item): Rename local to avoid shadowing.
16631
39261c26
PE
16632 * keyboard.c (make_lispy_event): Remove unused local var.
16633
018c5e19
PE
16634 * frame.c, frame.h (x_get_resource_string): Bring this back, but
16635 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
16636
63d2b86e
PE
16637 * bitmaps: Change bitmaps from unsigned char back to the X11
16638 compatible char. Avoid the old compiler warnings about
16639 out-of-range initializers by using, for example, '\xab' rather
16640 than 0xab.
16641
aefd87e1
PE
16642 * xgselect.c (xgselect_initialize): Check vs interface
16643 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
16644
bf501fb9
PE
16645 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
16646
e9829fdf
PE
16647 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
16648 to read-only memory.
16649
1086c095
PE
16650 * fns.c (vector): Remove; this old hack is no longer needed.
16651
2baccd04 16652 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 16653 Remove unused var.
dde42981 16654 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 16655
72391843 16656 * xrdb.c (x_load_resources): Omit unused local.
3565b346 16657
436c16df 16658 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 16659 (x_window): Rename locals to avoid shadowing.
dc5ddd85 16660 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 16661
92bb796d 16662 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 16663 (x_term_init): Remove local to avoid shadowing.
92bb796d 16664
764430a3 16665 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
16666
16667 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
16668 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
16669
d1dfb56c
EZ
166702011-04-16 Eli Zaretskii <eliz@gnu.org>
16671
c4354cb4
EZ
16672 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
16673
d1dfb56c
EZ
16674 Fix regex.c, syntax.c and friends for buffers > 2GB.
16675 * syntax.h (struct gl_state_s): Declare character position members
16676 EMACS_INT.
16677
16678 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
16679
04f2d78b
CB
16680 * textprop.c (verify_interval_modification, interval_of):
16681 Declare arguments EMACS_INT.
d1dfb56c
EZ
16682
16683 * intervals.c (adjust_intervals_for_insertion): Declare arguments
16684 EMACS_INT.
16685
16686 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
16687
16688 * indent.c (Fvertical_motion): Local variable it_start is now
16689 EMACS_INT.
16690
16691 * regex.c (re_match, re_match_2, re_match_2_internal)
16692 (bcmp_translate, regcomp, regexec, print_double_string)
16693 (group_in_compile_stack, re_search, re_search_2, regex_compile)
16694 (re_compile_pattern, re_exec): Declare arguments and local
16695 variables `size_t' and `ssize_t' and return values `regoff_t', as
16696 appropriate.
16697 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
16698 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
16699 <compile_stack_type>: `size' and `avail' are now `size_t'.
16700
16701 * regex.h <regoff_t>: Use ssize_t, not int.
16702 (re_search, re_search_2, re_match, re_match_2): Arguments that
16703 specify buffer/string position and length are now ssize_t and
16704 size_t. Return type is regoff_t.
16705
613052cd
BK
167062011-04-16 Ben Key <bkey76@gmail.com>
16707
16708 * nsfont.m: Fixed bugs in ns_get_family and
16709 ns_descriptor_to_entity that were caused by using free to
16710 deallocate memory blocks that were allocated by xmalloc (via
16711 xstrdup). This caused Emacs to crash when compiled with
16712 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
16713 --enable-checking=xmallocoverrun). xfree is now used to
16714 deallocate these memory blocks.
16715
4170f62f 167162011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 16717
71b41406
PE
16718 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
16719
9587a89d
PE
16720 emacs_write: Accept and return EMACS_INT for sizes.
16721 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
16722 et seq.
16723 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
16724 Accept and return EMACS_INT.
16725 (emacs_gnutls_write): Return the number of bytes written on
16726 partial writes.
16727 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
16728 (emacs_read, emacs_write): Remove check for negative size, as the
16729 Emacs source code has been audited now.
9587a89d
PE
16730 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
16731 (emacs_read, emacs_write): Use it.
273a5f82
PE
16732 * process.c (send_process): Adjust to the new signatures of
16733 emacs_write and emacs_gnutls_write. Do not attempt to store
16734 a byte offset into an 'int'; it might overflow.
9587a89d 16735 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 16736
3e047f51
PE
16737 * sound.c: Don't assume sizes fit in 'int'.
16738 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 16739 Return EMACS_INT, not int.
3e047f51 16740 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
16741 Accept EMACS_INT, not int.
16742 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
16743 record read return values.
16744
cc39a9db
BK
167452011-04-15 Ben Key <bkey76@gmail.com>
16746
c9d0ec6d
JB
16747 * keyboard.c (Qundefined): Don't declare static since it is used
16748 in nsfns.m.
16749 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
16750 static since they are used in nsfont.m.
cc39a9db 16751
6c60eb9f
SM
167522011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
16753
16754 * process.c (Qprocessp): Don't declare static.
16755 * lisp.h (Qprocessp): Declare again.
16756
7990b61a
JB
167572011-04-15 Juanma Barranquero <lekktu@gmail.com>
16758
16759 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
16760
5d4cb038
PE
167612011-04-14 Paul Eggert <eggert@cs.ucla.edu>
16762
8bd7b830 16763 Improve C-level modularity by making more things 'static'.
cd64ea1d 16764
e3b27b31
PE
16765 Don't publish debugger-only interfaces to other modules.
16766 * lisp.h (safe_debug_print, debug_output_compilation_hack):
16767 (verify_bytepos, count_markers): Move decls to the only modules
16768 that need them.
16769 * region-cache.h (pp_cache): Likewise.
16770 * window.h (check_all_windows): Likewise.
16771 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
16772
5d4cb038
PE
16773 * sysdep.c (croak): Now static, if
16774 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
16775 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
16776
16777 * alloc.c (refill_memory_reserve): Now static if
16778 !defined REL_ALLOC || defined SYSTEM_MALLOC.
16779 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 16780
e87b6180
PE
16781 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
16782 Define only if USE_LUCID.
16783
ac64929e
PE
16784 * xrdb.c (x_customization_string, x_rm_string): Now static.
16785
6f37259d
PE
16786 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
16787 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
16788
1683e3ab
PE
16789 * xdisp.c (draw_row_with_mouse_face): Now static.
16790 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
16791
de9c2632
PE
16792 * window.h (check_all_windows): Mark externally visible.
16793
2b96acb7
PE
16794 * window.c (window_deletion_count): Now static.
16795
16796 * undo.c: Make symbols static if they're not exported.
16797 (last_undo_buffer, last_boundary_position, pending_boundary):
16798 Now static.
16799
50436f33
PE
16800 * textprop.c (interval_insert_behind_hooks): Now static.
16801 (interval_insert_in_front_hooks): Likewise.
16802
64520e5c
PE
16803 * term.c: Make symbols static if they're not exported.
16804 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
16805 (max_frame_lines, tty_set_terminal_modes):
16806 (tty_reset_terminal_modes, tty_turn_off_highlight):
16807 (get_tty_terminal): Now static.
16808 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
16809 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 16810 HAVE_WINDOW_SYSTEM.
64520e5c
PE
16811 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
16812 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
16813
1fa53021
PE
16814 * sysdep.c: Make symbols static if they're not exported.
16815 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
16816 Now static.
16817 (sigprocmask_set, full_mask): Remove; unused.
16818 (wait_debugging): Mark as visible.
16819 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
16820 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
16821
d4b43b22
PE
16822 * syntax.c (syntax_temp): Define only if !__GNUC__.
16823
b7c513d0
PE
16824 * sound.c (current_sound_device, current_sound): Now static.
16825
989b29ad
PE
16826 * search.c (searchbufs, searchbuf_head): Now static.
16827
13a55a78
PE
16828 * scroll.c (scroll_cost): Remove; unused.
16829 * dispextern.h (scroll_cost): Remove decl.
16830
de68a1fc
PE
16831 * region-cache.h (pp_cache): Mark as externally visible.
16832
40ccffa6
PE
16833 * process.c: Make symbols static if they're not exported.
16834 (process_tick, update_tick, create_process, chan_process):
16835 (Vprocess_alist, proc_buffered_char, datagram_access):
16836 (fd_callback_data, send_process_frame, process_sent_to): Now static.
16837 (deactivate_process): Mark defn as static, as well as decl.
16838 * lisp.h (create_process): Remove decl.
16839 * process.h (chan_process, Vprocess_alist): Remove decls.
16840
ad64fc97
PE
16841 * print.c: Make symbols static if they're not exported.
16842 (print_depth, new_backquote_output, being_printed, print_buffer):
16843 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
16844 (print_interval, print_number_index, initial_stderr_stream):
16845 Now static.
16846 * lisp.h (Fprinc): Remove decl.
16847 (debug_output_compilation_hack): Mark as externally visible.
16848
adddb265
PE
16849 * sysdep.c (croak): Move decl from here to syssignal.h.
16850 * syssignal.h (croak): Put it here, so the API can be checked when
16851 'croak' is called from dissociate_if_controlling_tty.
16852
1717ede2
PE
16853 * minibuf.c: Make symbols static if they're not exported.
16854 (minibuf_save_list, choose_minibuf_frame): Now static.
16855 * lisp.h (choose_minibuf_frame): Remove decl.
16856
fa5fb2bc
PE
16857 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
16858
1e3890d1
PE
16859 * lread.c: Make symbols static if they're not exported.
16860 (read_objects, initial_obarray, oblookup_last_bucket_number):
16861 Now static.
16862 (make_symbol): Remove; unused.
16863 * lisp.h (initial_obarray, make_symbol): Remove decls.
16864
8a1414fa
PE
16865 * keyboard.c: Make symbols static if they're not exported.
16866 (single_kboard, recent_keys_index, total_keys, recent_keys):
16867 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
16868 (this_single_command_key_start, echoing, last_auto_save):
16869 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
16870 (command_loop, echo_now, keyboard_init_hook, help_char_p):
16871 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
16872 (Vlispy_mouse_stem, double_click_count):
16873 Now static.
16874 (force_auto_save_soon): Define only if SIGDANGER.
16875 (ignore_mouse_drag_p): Now static if
16876 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
16877 (print_help): Remove; unused.
16878 (stop_character, last_timer_event): Mark as externally visible.
16879 * keyboard.h (ignore_mouse_drag_p): Declare only if
16880 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
16881 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
16882 * lisp.h (echoing): Remove decl.
16883 (force_auto_save_soon): Declare only if SIGDANGER.
16884 * xdisp.c (redisplay_window): Simplify code, to make it more
16885 obvious that ignore_mouse_drag_p is not accessed if !defined
16886 USE_GTK && !defined HAVE_NS.
16887
93ea6e8f
PE
16888 * intervals.c: Make symbols static if they're not exported.
16889 (merge_properties_sticky, merge_interval_right, delete_interval):
16890 Now static.
16891 * intervals.h (merge_interval_right, delete_interval): Remove decls.
16892
77382fcc
PE
16893 * insdel.c: Make symbols static if they're not exported.
16894 However, leave prepare_to_modify_buffer alone. It's never
16895 called from outside this function, but that appears to be a bug.
16896 (combine_after_change_list, combine_after_change_buffer):
4889fc82 16897 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
16898 (adjust_after_replace_noundo): Remove; unused.
16899 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 16900 (signal_before_change): Remove decls.
77382fcc 16901
9306c32e
PE
16902 * indent.c (val_compute_motion, val_vmotion): Now static.
16903
cd44d2eb
PE
16904 * image.c: Make symbols static if they're not exported.
16905 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
16906 if USE_GTK.
16907 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
16908 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
16909
ad9a7a06
PE
16910 * fringe.c (standard_bitmaps): Now static.
16911 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
16912
81626931
PE
16913 * frame.c: Make symbols static if they're not exported.
16914 (x_report_frame_params, make_terminal_frame): Now static.
16915 (get_frame_param): Now static, unless HAVE_NS.
16916 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
16917 (x_get_resource_string): Remove; not used.
16918 * frame.h (make_terminal_frame, x_report_frame_params):
16919 (x_get_resource_string); Remove decls.
16920 (x_fullscreen_adjust): Declare only if WINDOWSNT.
16921 * lisp.h (get_frame_param): Declare only if HAVE_NS.
16922
239f9db9
PE
16923 * font.c, fontset.c: Make symbols static if they're not exported.
16924 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
16925 (FACE_SUITABLE_FOR_CHAR_P): Use it.
16926 * font.c (font_close_object): Now static.
16927 * font.h (font_close_object): Remove.
16928 * fontset.c (FONTSET_OBJLIST): Remove.
16929 (free_realized_fontset) #if-0 the body, which does nothing.
16930 (face_suitable_for_char_p): #if-0, as it's never called.
16931 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
16932 * xfaces.c (face_at_string_position):
16933 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
16934 since 0 is always ASCII.
16935
dfcf3579
PE
16936 * fns.c (weak_hash_tables): Now static.
16937
5045092b
PE
16938 * fileio.c: Make symbols static if they're not exported.
16939 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
16940 (Vwrite_region_annotation_buffers): Now static.
16941
57a96f5c
PE
16942 * eval.c: Make symbols static if they're not exported.
16943 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
16944 * lisp.h (backtrace_list): Remove decl.
16945
35f08c38
PE
16946 * emacs.c: Make symbols static if they're not exported.
16947 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
16948 (fatal_error_code, fatal_error_signal_hook, standard_args):
16949 Now static.
16950 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
16951 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
16952 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
16953 * lisp.h (fatal_error_signal_hook): Remove decl.
16954 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
16955
f44bd759
PE
16956 * editfns.c: Move a (normally-unused) function to its only use.
16957 * editfns.c, lisp.h (get_operating_system_release): Remove.
16958 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16959 worth the hassle of breaking this out.
16960
b532497d
PE
16961 * xterm.c: Make symbols static if they're not exported.
16962 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16963 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16964 (x_destroy_window, x_delete_display):
16965 Now static.
16966 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16967 (x_mouse_leave): Remove; unused.
16968 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16969 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16970 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16971 Remove decls.
16972 (x_mouse_leave): Declare only if WINDOWSNT.
16973 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16974 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16975 USE_X_TOOLKIT.
16976
1675728f
PE
16977 * ftxfont.c: Make symbols static if they're not exported.
16978 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16979 HAVE_FREETYPE.
16980 * font.h (ftxfont_driver): Likewise.
16981
e4cebfca
PE
16982 * xfns.c: Make symbols static if they're not exported.
16983 (x_last_font_name, x_display_info_for_name):
16984 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16985 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16986 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16987 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16988 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16989 (last_show_tip_args): Now static.
16990 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16991 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16992 (x_screen_planes): Remove; unused.
16993 * dispextern.h (x_screen_planes): Remove decl.
16994
5bf46f05
PE
16995 * dispnew.c: Make symbols static if they're not exported.
16996 * dispextern.h (redraw_garbaged_frames, scrolling):
16997 (increment_row_positions): Remove.
16998 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16999 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
17000 Now static.
17001 (redraw_garbaged_frames): Remove; unused.
17002
435f4c28
PE
17003 * xfaces.c: Make symbols static if they're not exported.
17004 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
17005 Remove decls.
17006 * xterm.h (defined_color): Remove decls.
17007 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
17008 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
17009 (menu_face_changed_default, defined_color, free_realized_face):
17010 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
17011 (ascii_face_of_lisp_face): Remove; unused.
17012
8524aef3
PE
17013 * xdisp.c: Make symbols static if they're not exported.
17014 * dispextern.h (scratch_glyph_row, window_box_edges):
17015 (glyph_to_pixel_coords, set_cursor_from_row):
17016 (get_next_display_element, set_iterator_to_next):
17017 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
17018 (show_mouse_face): Remove decls
17019 * frame.h (message_buf_print): Likewise.
17020 * lisp.h (pop_message, set_message, check_point_in_composition):
17021 Likewise.
17022 * xterm.h (set_vertical_scroll_bar): Likewise.
17023 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
17024 (message_buf_print, scratch_glyph_row, displayed_buffer):
17025 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
17026 (get_next_display_element, show_mouse_face, window_box_edges):
17027 (frame_to_window_pixel_xy, check_point_in_composition):
17028 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
17029 (glyph_to_pixel_coords): Remove; unused.
17030
16390cd2
PE
17031 * dired.c (file_name_completion): Now static.
17032
17033 * dbusbind.c (xd_in_read_queued_messages): Now static.
17034
a25f4dfa
PE
17035 * lisp.h (circular_list_error, FOREACH): Remove; unused.
17036 * data.c (circular_list_error): Remove.
17037
14a9c8df
PE
17038 * commands.h (last_point_position, last_point_position_buffer):
17039 (last_point_position_window): Remove decls.
17040 * keyboard.c: Make these variables static.
17041
04f2d78b
CB
17042 * coding.h (coding, code_convert_region, encode_coding_gap):
17043 Remove decls.
74ab6df5
PE
17044 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
17045 (iso_code_class, detect_coding, code_convert_region): Now static.
17046 (encode_coding_gap): Remove; unused.
17047
38dfbee1
PE
17048 * chartab.c (chartab_chars, chartab_bits): Now static.
17049
a2cb4e63
PE
17050 * charset.h (charset_iso_8859_1): Remove decl.
17051 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
17052 Now static.
17053
127198fd
PE
17054 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
17055 * ccl.c (Vccl_program_table): Now static.
17056 (check_ccl_update): Remove; unused.
17057
d85b608f
PE
17058 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
17059 * category.h: ... from here.
17060 * category.c (check_category_table, set_category_set): Now static.
17061
31cd66f3
PE
17062 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
17063 * lisp.h: Remove these decls.
17064
c358e587
PE
17065 * buffer.c (buffer_count): Remove unused var.
17066
e78aecca
PE
17067 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
17068 so that it's not optimized away.
17069 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
17070 * dispextern.h (bidi_dump_cached_states): Remove, since it's
17071 exported only to the debugger.
17072
e192d7d3 17073 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 17074 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 17075
92470028
PE
17076 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
17077 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
17078 was inaccessible from Lisp.
17079 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
17080 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
17081
244ed907
PE
17082 alloc.c: Import and export fewer symbols, and remove unused items.
17083 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
17084 is defined.
17085 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
17086 it's not optimized away by whole-program optimization.
17087 (message_enable_multibyte, free_misc): Remove.
17088 (catchlist, handlerlist, mark_backtrace):
17089 Declare only if BYTE_MARK_STACK.
17090 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
17091 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
17092 (message_enable_multibyte): Remove decl.
17093 (free_misc, interval_free_list, float_block, float_block_index):
17094 (n_float_blocks, float_free_list, cons_block, cons_block_index):
17095 (cons_free_list, last_marked_index):
17096 Now static.
17097 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
17098 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
17099 (mark_backtrace): Define only if BYTE_MARK_STACK.
17100 * xdisp.c (message_enable_multibyte): Now static.
17101
61c2b50e 17102 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
17103 This makes it easier for human readers (and static analyzers)
17104 to see whether these variables are used from other modules.
17105 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
17106 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
17107 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
17108 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
17109 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
17110 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
17111 * xmenu.c, xselect.c:
17112 Declare Q* vars static if they are not used in other modules.
17113 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
17114 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
17115 Remove decls of unexported vars.
17116 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
17117
95c82688
PE
17118 * lisp.h (DEFINE_FUNC): Make sname 'static'.
17119
16a97296
PE
17120 Make Emacs functions such as Fatom 'static' by default.
17121 This makes it easier for human readers (and static analyzers)
17122 to see whether these functions can be called from other modules.
17123 DEFUN now defines a static function. To make the function external
17124 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
17125 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
17126 (Finit_image_library):
16a97296
PE
17127 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
17128 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
17129 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
17130 Remove decls, since these functions are now static.
17131 (Funintern, Fget_internal_run_time): New decls, since these functions
17132 were already external.
95c82688 17133
16a97296
PE
17134 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
17135 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
17136 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
17137 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
17138 * keyboard.c, keymap.c, lread.c:
17139 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
17140 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
17141 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
17142 Mark functions with DEFUE instead of DEFUN,
17143 if they are used in other modules.
17144 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
17145 decls for now-static functions.
17146 * buffer.h (Fdelete_overlay): Remove decl.
17147 * callproc.c (Fgetenv_internal): Mark as internal.
17148 * composite.c (Fremove_list_of_text_properties): Remove decl.
17149 (Fcomposition_get_gstring): New forward static decl.
17150 * composite.h (Fcomposite_get_gstring): Remove decl.
17151 * dired.c (Ffile_attributes): New forward static decl.
17152 * doc.c (Fdocumntation_property): New forward static decl.
17153 * eval.c (Ffetch_bytecode): New forward static decl.
17154 (Funintern): Remove extern decl; now in .h file where it belongs.
17155 * fileio.c (Fmake_symbolic_link): New forward static decl.
17156 * image.c (Finit_image_library): New forward static decl.
17157 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
17158 * intervals.h (Fprevious_property_change):
17159 (Fremove_list_of_text_properties): Remove decls.
17160 * keyboard.c (Fthis_command_keys): Remove decl.
17161 (Fcommand_execute): New forward static decl.
17162 * keymap.c (Flookup_key): New forward static decl.
17163 (Fcopy_keymap): Now static.
17164 * keymap.h (Flookup_key): Remove decl.
17165 * process.c (Fget_process): New forward static decl.
17166 (Fprocess_datagram_address): Mark as internal.
17167 * syntax.c (Fsyntax_table_p): New forward static decl.
17168 (skip_chars): Remove duplicate decl.
17169 * textprop.c (Fprevious_property_change): New forward static decl.
17170 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
17171 Now internal.
17172 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
17173 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
17174
785bbd42
PE
17175 * editfns.c (Fformat): Remove unreachable code.
17176
8b913b57
AS
171772011-04-14 Andreas Schwab <schwab@linux-m68k.org>
17178
17179 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
17180 change. (Bug#8496)
17181
a6744a35
EZ
171822011-04-13 Eli Zaretskii <eliz@gnu.org>
17183
17184 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
17185 when at ZV. (Bug#8487)
17186
e7974947
AS
171872011-04-12 Andreas Schwab <schwab@linux-m68k.org>
17188
baad03f0
AS
17189 * charset.c (Fclear_charset_maps): Use xfree instead of free.
17190 (Bug#8437)
17191 * keyboard.c (parse_tool_bar_item): Likewise.
17192 * sound.c (sound_cleanup, alsa_close): Likewise.
17193 * termcap.c (tgetent): Likewise.
17194 * xfns.c (x_default_font_parameter): Likewise.
17195 * xsettings.c (read_and_apply_settings): Likewise.
17196
e7974947
AS
17197 * alloc.c (overrun_check_malloc, overrun_check_realloc)
17198 (overrun_check_free): Protoize.
17199
28272684
PE
172002011-04-12 Paul Eggert <eggert@cs.ucla.edu>
17201
17202 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
17203 since callers should never pass a negative size.
17204 Change the signature to match that of plain 'read' and 'write'; see
17205 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
17206 * lisp.h: Update prototypes of emacs_write and emacs_read.
17207
11997c76
EZ
172082011-04-11 Eli Zaretskii <eliz@gnu.org>
17209
17210 * xdisp.c (redisplay_window): Don't try to determine the character
17211 position of the scroll margin if the window start point w->startp
e896f03c 17212 is outside the buffer's accessible region. (Bug#8468)
11997c76 17213
8a2cbd72
EZ
172142011-04-10 Eli Zaretskii <eliz@gnu.org>
17215
17216 Fix write-region and its subroutines for buffers > 2GB.
17217 * fileio.c (a_write, e_write): Modify declaration of arguments and
17218 local variables to support buffers larger than 2GB.
17219 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
17220
17221 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
17222 argument, local variables, and return value.
17223
17224 * lisp.h: Update prototypes of emacs_write and emacs_read.
17225
17226 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
17227
4073e537 172282011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 17229
1ebfdcb6
PE
17230 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
17231
b2ded58d
PE
17232 Fix more problems found by GCC 4.6.0's static checks.
17233
7d66342c
PE
17234 * xdisp.c (vmessage): Use a better test for character truncation.
17235
bbf47d44
PE
17236 * charset.c (load_charset_map): <, not <=, for optimization,
17237 and to avoid potential problems with integer overflow.
9248994d 17238 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 17239 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 17240 * editfns.c (Fformat): Likewise.
1e69125e 17241 * syntax.c (skip_chars): Likewise.
3befa583 17242
e3019616
PE
17243 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
17244 This also lets GCC 4.6.0 generate slightly better loop code.
17245
becfa255
PE
17246 * callint.c (Fcall_interactively): <, not <=, for optimization.
17247 (Fcall_interactively): Count the number of arguments produced,
17248 not the number of arguments given. This is simpler and lets GCC
17249 4.6.0 generate slightly better code.
17250
dae0cd48
PE
17251 * ftfont.c: Distingish more carefully between FcChar8 and char.
17252 The previous code passed unsigned char * to a functions like
17253 strlen and xstrcasecmp that expect char *, which does not
17254 conform to the C standard.
17255 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
17256 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
17257 char * when the C standard requires it.
17258
76032d70
PE
17259 * keyboard.c (read_char): Remove unused var.
17260
eb3f1cc8
PE
17261 * eval.c: Port to Windows vsnprintf (Bug#8435).
17262 Include <limits.h>.
17263 (SIZE_MAX): Define if the headers do not.
17264 (verror): Do not give up if vsnprintf returns a negative count.
17265 Instead, grow the buffer. This ports to Windows vsnprintf, which
17266 does not conform to C99. Problem reported by Eli Zaretskii.
17267 Also, simplify the allocation scheme, by avoiding the need for
17268 calling realloc, and removing the ALLOCATED variable.
17269
70476b54
PE
17270 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
17271
12020a9e
PE
17272 Remove invocations of doprnt, as Emacs now uses vsnprintf.
17273 But keep the doprint source code for now, as we might revamp it
17274 and use it again (Bug#8435).
ea6c7ae6
PE
17275 * lisp.h (doprnt): Remove.
17276 * Makefile.in (base_obj): Remove doprnt.o.
17277 * deps.mk (doprnt.o): Remove.
17278
5fdb398c
PE
17279 error: Print 32- and 64-bit integers portably (Bug#8435).
17280 Without this change, on typical 64-bit hosts error ("...%d...", N)
17281 was used to print both 32- and 64-bit integers N, which relied on
17282 undefined behavior.
61bdb816 17283 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
17284 * lisp.h (error, verror): Mark as printf-like functions.
17285 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
17286 Report overflow in size calculations when allocating printf buffer.
17287 Do not truncate output string at its first null byte.
17288 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
17289 Truncate the output at a character boundary, since vsnprintf does not
17290 do that.
17291 * charset.c (check_iso_charset_parameter): Convert internal
17292 character to string before calling 'error', since %c now has the
17293 printf meaning.
17294 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
17295 overflow when computing char to be passed to 'error'. Do not
17296 pass Lisp_Object to 'error'; pass the integer instead.
17297 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
17298 formatted with plain %d.
17299
b189fa66
PE
17300 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
17301
bff87ef0
PE
17302 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
17303
7e2cac20
PE
17304 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
17305
ce4d90b5
PE
17306 * xterm.c (x_catch_errors): Remove duplicate declaration.
17307
266c9547
PE
17308 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
17309
79c49ad2
PE
17310 * xdisp.c, lisp.h (message_nolog): Remove; unused.
17311
368f4090
JM
173122011-04-10 Jim Meyering <meyering@redhat.com>
17313
17314 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
17315 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
17316 return ssize_t not "int", and use size_t as the buffer length.
17317 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
17318 * gnutls.h: Update declarations.
17319 * process.c (read_process_output): Use ssize_t, to match.
17320 (send_process): Likewise.
17321
a32d4040
CY
173222011-04-09 Chong Yidong <cyd@stupidchicken.com>
17323
17324 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
17325
8546720e 173262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 17327
04f2d78b
CB
17328 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
17329 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 17330
8546720e
GM
17331 * xterm.c (handle_one_xevent):
17332 * xmenu.c (create_and_show_popup_menu):
17333 * xselect.c (x_decline_selection_request)
17334 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 17335
0a2f5c1a 173362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
17337
17338 Fix some uses of `int' instead of EMACS_INT.
17339 * search.c (string_match_1, fast_string_match)
17340 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
17341 (scan_buffer, find_next_newline_no_quit)
17342 (find_before_next_newline, search_command, Freplace_match)
17343 (Fmatch_data): Make some `int' variables be EMACS_INT.
17344
17345 * xdisp.c (display_count_lines): 3rd argument and return value now
17346 EMACS_INT. All callers changed.
17347 (pint2hrstr): Last argument is now EMACS_INT.
17348
17349 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
17350 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
17351 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
17352 (decode_coding_utf_16, decode_coding_emacs_mule)
17353 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
17354 (decode_coding_ccl, decode_coding_charset)
17355 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
17356 (decode_coding_iso_2022, decode_coding_emacs_mule)
17357 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
17358 <char_offset, last_offset>: Declare EMACS_INT.
17359 (encode_coding_utf_8, encode_coding_utf_16)
17360 (encode_coding_emacs_mule, encode_invocation_designation)
17361 (encode_designation_at_bol, encode_coding_iso_2022)
17362 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
17363 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
17364 Declare EMACS_INT.
17365 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
17366 (encode_invocation_designation): Last argument P_NCHARS is now
17367 EMACS_INT.
17368 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
17369 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
17370
17371 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
17372 All users changed.
17373
17374 * ccl.c (Fccl_execute_on_string): Declare some variables
17375 EMACS_INT.
17376
8546720e 173772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
17378
17379 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
17380
4e19a977
CS
173812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
17382
17383 * process.c (Fformat_network_address): Doc fix.
17384
87302331
R
173852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
17386
ee7683eb 17387 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 17388
cbb59342
CY
173892011-04-08 Chong Yidong <cyd@stupidchicken.com>
17390
17391 * keyboard.c (read_char): Call Lisp function help-form-show,
17392 instead of using internal_with_output_to_temp_buffer.
17393 (Qhelp_form_show): New var.
e0d38eeb 17394 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
17395
17396 * print.c (internal_with_output_to_temp_buffer): Function deleted.
17397
17398 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
17399
e67a13ab
CY
174002011-04-06 Chong Yidong <cyd@stupidchicken.com>
17401
04f2d78b
CB
17402 * process.c (Flist_processes): Remove to Lisp.
17403 (list_processes_1): Delete.
e67a13ab 17404
973f782d
EZ
174052011-04-06 Eli Zaretskii <eliz@gnu.org>
17406
7c106b1e
EZ
17407 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
17408
973f782d
EZ
17409 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
17410
41cf7d1a 174112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 17412
ca23cc88
PE
17413 Fix more problems found by GCC 4.6.0's static checks.
17414
f390e2d5
PE
17415 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
17416
42eea0d0
PE
17417 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
17418
b69769da 17419 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 17420
f9541e84
PE
17421 * xdisp.c (vmessage): Mark as a printf-like function.
17422
13841b55
PE
17423 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
17424
c136c10f
PE
17425 * sound.c (sound_warning): Don't crash if arg contains a printf format.
17426
5e2d4a30
PE
17427 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
17428 printf-like functions.
17429 (tiff_load): Add casts to remove these marks before passing them
17430 to system-supplied API.
17431
583f48b9
PE
17432 * eval.c (Fsignal): Remove excess argument to 'fatal'.
17433
b25d760e
PE
17434 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
17435 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
17436 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
17437 directly, rather than having caller test rule sign. This avoids
17438 some unnecessary tests.
17439 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
17440 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
17441 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 17442
bc7b6697 17443 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 17444 (xfont_open): Avoid unnecessary tests.
bc7b6697 17445
27ccc379
PE
17446 * composite.c (composition_gstring_put_cache): Use unsigned integer.
17447
dcd5c89a
PE
17448 * composite.h, composite.c (composition_gstring_put_cache):
17449 Use EMACS_INT, not int, for length.
17450
b13a45c6
PE
17451 * composite.h (COMPOSITION_DECODE_REFS): New macro,
17452 breaking out part of COMPOSITION_DECODE_RULE.
17453 (COMPOSITION_DECODE_RULE): Use it.
17454 * composite.c (get_composition_id): Remove unused local vars,
17455 by using the new macro.
17456
1e792e4d
PE
17457 * textprop.c (set_text_properties_1): Change while to do-while,
17458 since the condition is always true at first.
17459
dc6c6455 17460 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
17461 (interval_deletion_adjustment): Return unsigned value.
17462 All uses changed.
dc6c6455 17463
aba7731a
PE
17464 * process.c (list_processes_1, create_pty, read_process_output):
17465 (exec_sentinel): Remove vars that were set but not used.
afd4052b 17466 (create_pty): Remove unnecessary "volatile"s.
bc57d757 17467 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 17468 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 17469 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 17470
fdfc4bf3
PE
17471 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
17472
fca8fe46 17473 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 17474 (update_syntax_table): Use unsigned instead of int.
fca8fe46 17475
06a0259a 17476 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 17477 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 17478 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 17479
e7b9e80f
PE
17480 * print.c (print_error_message): Avoid int overflow.
17481
56201685
PE
17482 * font.c (font_list_entities): Redo for clarity,
17483 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
17484
78834453 17485 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 17486 (font_score): Avoid potential overflow in diff calculation.
78834453 17487
0bc0b309 17488 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 17489 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 17490
e610eaca
PE
17491 * eval.c (funcall_lambda): Rename local to avoid shadowing.
17492
b895abce
PE
17493 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
17494 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
17495 can always succeed if overflow has undefined behavior.
17496
1f1d9321 17497 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 17498 (wordify): Omit three unnecessary tests.
1f1d9321 17499
c59478bc
PE
17500 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
17501 All callers changed. This avoids the need for an unused var.
17502
79b73827
PE
17503 * casefiddle.c (casify_region): Remove var that is set but not used.
17504
a4db5dfe
PE
17505 * dired.c (file_name_completion): Remove var that is set but not used.
17506
43aae36e
PE
17507 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
17508
2a47c44d 17509 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 17510 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 17511
a37c69bf
PE
17512 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
17513 Check for integer overflow on size calculations.
17514
328ab8e7
PE
17515 * buffer.c (Fprevious_overlay_change): Remove var that is set
17516 but not used.
17517
e5a2a5cb
PE
17518 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
17519 Remove vars that are set but not used.
8d84a6eb 17520 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 17521 (timer_check_2): Mark vars as initialized.
e5a2a5cb 17522
a60e5f68
PE
17523 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
17524
f661cb61 17525 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 17526 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 17527
f0397f5a
PE
17528 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
17529 that are set but not used.
17530
8664db06 17531 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 17532 if XCreateBitmapFromData fails (Bug#8410).
8664db06 17533
6abdaa4a
PE
17534 * xselect.c (x_get_local_selection, x_handle_property_notify):
17535 Remove vars that are set but not used.
17536
0ce7538d 17537 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 17538 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 17539
9ae848fc
PE
17540 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
17541 Remove var that is set but not used.
0b918413
PE
17542 (scroll_bar_windows_size): Now size_t, not int.
17543 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
17544 Check for overflow.
9ae848fc 17545
a5a62657
PE
17546 * xfaces.c (realize_named_face): Remove vars that are set but not used.
17547 (map_tty_color) [!defined MSDOS]: Likewise.
17548
5c5cdd39
PE
17549 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
17550
66ebf983
PE
17551 * coding.c: Remove vars that are set but not used.
17552 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
17553 All callers changed.
17554 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
17555 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
17556 (decode_coding_charset): Remove vars that are set but not used.
17557
1be4d761
PE
17558 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
17559 that is set but not used.
17560
47553fa8
PE
17561 * print.c (print_object): Remove var that is set but not used.
17562
1f7196bf 17563 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
17564 The gnulib version avoids calling malloc in the usual case,
17565 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
17566 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
17567 * filelock.c (current_lock_owner): Likewise.
17568 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
17569 * sysdep.c: Include allocator.h, careadlinkat.h.
17570 (emacs_no_realloc_allocator): New static constant.
17571 (emacs_readlink): New function.
fdb61804
PE
17572 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
17573 ../lib/careadlinkat.h.
d1fdcab7 17574
f84c17c7
SM
175752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
17576
17577 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
17578 first non-nil return value).
17579
ef3862ad
JD
175802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
17581
17582 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
17583 if not defined (Bug#8403).
17584
376a7006
JB
175852011-04-02 Juanma Barranquero <lekktu@gmail.com>
17586
17587 * xdisp.c (display_count_lines): Remove parameter `start',
17588 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17589 (get_char_face_and_encoding): Remove parameter `multibyte_p',
17590 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17591 (fill_stretch_glyph_string): Remove parameters `row' and `area',
17592 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
17593 and thereabouts. All callers changed.
17594 (get_per_char_metric): Remove parameter `f', unused since
17595 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17596
6ca3801d
JM
175972011-04-02 Jim Meyering <meyering@redhat.com>
17598
17599 do not dereference NULL upon failed strdup
17600 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
17601 (ns_get_family): Likewise.
17602
d8e2b5ba
JB
176032011-04-02 Juanma Barranquero <lekktu@gmail.com>
17604
17605 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
17606
8c74fcbd
JD
176072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
17608
17609 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
17610 later (Bug#8403).
17611
7200d79c
SM
176122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
17613
03408648 17614 Add lexical binding.
7200d79c 17615
03408648
SM
17616 * window.c (Ftemp_output_buffer_show): New fun.
17617 (Fsave_window_excursion):
17618 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
17619
17620 * lread.c (lisp_file_lexically_bound_p): New function.
17621 (Fload): Bind Qlexical_binding.
17622 (readevalloop): Remove `evalfun' arg.
17623 Bind Qinternal_interpreter_environment.
17624 (Feval_buffer): Bind Qlexical_binding.
17625 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
17626 Mark as dynamic.
17627 (syms_of_lread): Declare `lexical-binding'.
17628
17629 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
17630
17631 * keyboard.c (eval_dyn): New fun.
17632 (menu_item_eval_property): Use it.
ca105506
SM
17633
17634 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 17635
03408648
SM
17636 * fns.c (concat, mapcar1): Accept byte-code-functions.
17637
17638 * eval.c (Fsetq): Handle lexical vars.
17639 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
17640 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
17641 (FletX, Flet): Obey lexical binding.
17642 (Fcommandp): Handle closures.
17643 (Feval): New `lexical' arg.
17644 (eval_sub): New function extracted from Feval. Use it almost
17645 everywhere where Feval was used. Look up vars in lexical env.
17646 Handle closures.
17647 (Ffunctionp): Move from subr.el.
17648 (Ffuncall): Handle closures.
17649 (apply_lambda): Remove `eval_flags'.
17650 (funcall_lambda): Handle closures and new byte-code-functions.
17651 (Fspecial_variable_p): New function.
17652 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
17653 but without exporting it to Lisp.
23aba0ea 17654
23aba0ea 17655 * doc.c (Fdocumentation, store_function_docstring):
03408648 17656 * data.c (Finteractive_form): Handle closures.
23aba0ea 17657
03408648
SM
17658 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
17659 interactive spec.
ba83908c 17660
04f2d78b
CB
17661 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
17662 New byte-codes.
03408648
SM
17663 (exec_byte_code): New function extracted from Fbyte_code to handle new
17664 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 17665
03408648 17666 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 17667
03408648 17668 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 17669
e2abce01
JB
176702011-03-31 Juanma Barranquero <lekktu@gmail.com>
17671
17672 * xdisp.c (redisplay_internal): Fix prototype.
17673
63696a73 176742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 17675
63696a73 17676 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
17677 (try_scrolling): Use it when setting scroll_limit.
17678 Limit scrolling to 100 screen lines.
63696a73
EZ
17679 (redisplay_window): Even when falling back on "recentering",
17680 position point in the window according to scroll-conservatively,
17681 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
17682
17683 (try_scrolling): When point is above the window, allow searching
17684 as far as scroll_max, or one screenful, to compute vertical
17685 distance from PT to the scroll margin position. This prevents
17686 try_scrolling from unnecessarily failing when
17687 scroll-conservatively is set to a value slightly larger than the
17688 window height. Clean up the case of PT below the margin at bottom
17689 of window: scroll_max can no longer be INT_MAX. When aggressive
17690 scrolling is in use, don't let point enter the opposite scroll
17691 margin as result of the scroll.
17692 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
17693 threshold of 100 lines for never-recentering scrolling.
17694
e4cc2dfc
JB
176952011-03-31 Juanma Barranquero <lekktu@gmail.com>
17696
17697 * dispextern.h (move_it_by_lines):
17698 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
17699 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
17700 (message_log_check_duplicate): Remove parameters `prev_bol' and
17701 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17702 (redisplay_internal): Remove parameter `preserve_echo_area',
17703 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
17704
17705 * indent.c (Fvertical_motion):
17706 * window.c (window_scroll_pixel_based, Frecenter):
17707 Don't pass `need_y_p' to `move_it_by_lines'.
17708
1c470562
SM
177092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
17710
44f230aa
SM
17711 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
17712 steal a few bits to be more compact.
17713 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
17714 Remove unneeded casts.
17715
1c470562
SM
17716 * bytecode.c (Fbyte_code): CAR and CDR can GC.
17717
888adce9
ZK
177182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
17719
17720 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
17721 binding" message (bug#7967).
17722
f838ed7b
PE
177232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
17724
77861b95
PE
17725 Fix more problems found by GCC 4.6.0's static checks.
17726
de6dbc14
PE
17727 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
17728 Remove unused local var.
17729
f838ed7b
PE
17730 * editfns.c (Fmessage_box): Remove unused local var.
17731
792c7b2b
PE
17732 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
17733 (note_mode_line_or_margin_highlight, note_mouse_highlight):
17734 Omit unused local vars.
c499e557 17735 * window.c (shrink_windows): Omit unused local var.
b01a1c29 17736 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
17737 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
17738 Omit unused local var.
17739
ba0165e1
PE
17740 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
17741 Don't assume string length fits in int.
32ad8845 17742 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 17743 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 17744
3c59b4c9
PE
17745 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
17746 instead of alloca (Bug#8344).
17747
a3eed478 17748 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 17749 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 17750
eb4d412d
PE
17751 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
17752
1658b401
PE
17753 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
17754 concerns.
17755
17756 * term.c (produce_glyphless_glyph): Remove unnecessary test.
17757
17758 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 17759
9a2c6e05
PE
17760 * keyboard.c (syms_of_keyboard): Use the same style as later
17761 in this function when indexing through an array. This also
17762 works around GCC bug 48267.
17763
03d0a109
PE
17764 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
17765
44f730c8
PE
17766 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
17767
fe75f926
PE
17768 * chartab.c (sub_char_table_ref_and_range): Redo for slight
17769 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
17770
ffa8c828
PE
17771 * keyboard.c, keyboard.h (num_input_events): Now size_t.
17772 This avoids undefined behavior on integer overflow, and is a bit
17773 more convenient anyway since it is compared to a size_t variable.
17774
c5101a77
PE
17775 Variadic C functions now count arguments with size_t, not int.
17776 This avoids an unnecessary limitation on 64-bit machines, which
17777 caused (substring ...) to crash on large vectors (Bug#8344).
17778 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
17779 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 17780 All variadic functions and their callers changed accordingly.
c5101a77
PE
17781 (struct gcpro.nvars): Now size_t, not int. All uses changed.
17782 * data.c (arith_driver, float_arith_driver): Likewise.
17783 * editfns.c (general_insert_function): Likewise.
17784 * eval.c (struct backtrace.nargs, interactive_p)
17785 (internal_condition_case_n, run_hook_with_args, apply_lambda)
17786 (funcall_lambda, mark_backtrace): Likewise.
17787 * fns.c (concat): Likewise.
17788 * frame.c (x_set_frame_parameters): Likewise.
17789 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
17790 0 if not found, not -1. All callers changed.
17791
dd3f25f7
PE
17792 * alloc.c (garbage_collect): Don't assume stack size fits in int.
17793 (stack_copy_size): Now size_t, not int.
17794 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
17795
461c2ab9
JB
177962011-03-28 Juanma Barranquero <lekktu@gmail.com>
17797
17798 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
17799 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17800 All callers changed.
17801
17802 * lisp.h (multibyte_char_to_unibyte):
17803 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
17804 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17805 * character.h (CHAR_TO_BYTE8):
17806 * cmds.c (internal_self_insert):
17807 * editfns.c (general_insert_function):
17808 * keymap.c (push_key_description):
17809 * search.c (Freplace_match):
17810 * xdisp.c (message_dolog, set_message_1): All callers changed.
17811
f6d62986
SM
178122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
17813
17814 * keyboard.c (safe_run_hook_funcall): New function.
17815 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
17816 don't set the hook to nil, but remove the offending function instead.
17817 (Qcommand_hook_internal): Remove, unused.
17818 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
17819 Vcommand_hook_internal.
17820
17821 * eval.c (enum run_hooks_condition): Remove.
17822 (funcall_nil, funcall_not): New functions.
17823 (run_hook_with_args): Call each function through a `funcall' argument.
17824 Remove `cond' argument, now redundant.
17825 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
17826 (Frun_hook_with_args_until_failure): Adjust accordingly.
17827 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
17828
1db5b1ad
JB
178292011-03-28 Juanma Barranquero <lekktu@gmail.com>
17830
17831 * dispextern.h (string_buffer_position): Remove declaration.
17832
17833 * print.c (strout): Remove parameter `multibyte', unused since
17834 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
17835
17836 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
17837 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
17838 All callers changed.
17839
17840 * w32.c (_wsa_errlist): Use braces for struct initializers.
17841
17842 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
17843 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
17844 All callers changed.
17845 (string_buffer_position): Likewise. Also, make static (it's never
17846 used outside xdisp.c).
17847 (cursor_row_p): Remove parameter `w', unused since
17848 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
17849 (decode_mode_spec): Remove parameter `precision', introduced during
17850 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
17851 All callers changed.
17852
5ffb62aa
JD
178532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17854
17855 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
17856
461c2ab9 178572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
17858
17859 * nsterm.m (ns_menu_bar_is_hidden): New variable.
17860 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
17861 (ns_update_auto_hide_menu_bar): New functions.
17862 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
17863 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
17864 ns_constrain_all_frames.
17865 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
17866 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
17867
5c380ffb
JD
178682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17869
17870 * nsmenu.m (runDialogAt): Remove argument to timer_check.
17871
9af30bdf
GM
178722011-03-27 Glenn Morris <rgm@gnu.org>
17873
17874 * syssignal.h: Replace RETSIGTYPE with void.
17875 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
17876 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
17877 Replace SIGTYPE with void everywhere.
17878 * s/usg5-4-common.h (SIGTYPE): Remove definition.
17879 * s/template.h (SIGTYPE): Remove commented out definition.
17880
e2abce01
JB
178812011-03-26 Eli Zaretskii <eliz@gnu.org>
17882
17883 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
17884 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
17885
f868cd8a
JB
178862011-03-26 Juanma Barranquero <lekktu@gmail.com>
17887
59eb0929
JB
17888 * w32.c (read_unc_volume): Use parameter `henum', instead of
17889 global variable `wget_enum_handle'.
17890
17891 * keymap.c (describe_vector): Remove parameters `indices' and
17892 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
17893 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
17894
f868cd8a
JB
17895 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
17896
17897 * keyboard.c (timer_check): Remove parameter `do_it_now',
17898 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
17899 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
17900 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
17901
17902 * keyboard.c (read_char):
17903 * w32menu.c (w32_menu_display_help):
17904 * xmenu.c (show_help_event, menu_help_callback):
17905 Adjust calls to `show_help_echo'.
17906
17907 * gtkutil.c (xg_maybe_add_timer):
17908 * keyboard.c (readable_events):
17909 * process.c (wait_reading_process_output):
17910 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
17911
17912 * insdel.c (adjust_markers_gap_motion):
17913 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
17914 (gap_left, gap_right): Don't call it.
17915
2ecf6fdb
CY
179162011-03-25 Chong Yidong <cyd@stupidchicken.com>
17917
17918 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
17919 incurred during fontification.
17920
6b1f9ba4
JB
179212011-03-25 Juanma Barranquero <lekktu@gmail.com>
17922
17923 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
17924 (DEFVAR_PER_BUFFER): Don't pass it.
17925
17926 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
17927 (scrolling_window): Don't pass it.
17928
0f4a96b5
JB
179292011-03-25 Juanma Barranquero <lekktu@gmail.com>
17930
17931 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
17932
17933 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
17934 and `suffix'.
17935 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
17936 of variables specific to SELinux and computation of `encoded_absname'.
17937
17938 * image.c (XPutPixel): Remove unused variable `height'.
17939
17940 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
17941
17942 * unexw32.c (get_section_info): Remove unused variable `section'.
17943
17944 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
17945 (system_process_attributes): Remove unused variable `sess'.
17946 (sys_read): Remove unused variable `err'.
17947
17948 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
17949 (w32_wnd_proc): Remove unused variable `isdead'.
17950 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
17951 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
17952 (x_create_tip_frame): Remove unused variable `tem'.
17953
17954 * w32inevt.c (w32_console_read_socket):
17955 Remove unused variable `no_events'.
17956
17957 * w32term.c (x_draw_composite_glyph_string_foreground):
17958 Remove unused variable `width'.
17959
1149507c
JB
179602011-03-24 Juanma Barranquero <lekktu@gmail.com>
17961
17962 * w32term.c (x_set_glyph_string_clipping):
17963 Don't pass uninitialized region to CombineRgn.
17964
9c88f339
JB
179652011-03-23 Juanma Barranquero <lekktu@gmail.com>
17966
17967 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17968 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17969 (Fx_close_connection): Remove unused variable `i'.
17970
17971 * w32font.c (w32font_draw): Return number of glyphs.
17972 (w32font_open_internal): Remove unused variable `i'.
17973 (w32font_driver): Add missing initializer.
17974
17975 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17976 (fill_in_menu): Remove unused variable `items_added'.
17977
17978 * w32term.c (last_mouse_press_frame): Remove static global variable.
17979 (w32_clip_to_row): Remove unused variable `f'.
17980 (x_delete_terminal): Remove unused variable `i'.
17981
17982 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17983 (NOTHING): Remove unused static global variable.
17984 (uniscribe_check_otf): Remove unused variable `table'.
17985 (uniscribe_font_driver): Add missing initializers.
17986
dee091a3
JD
179872011-03-23 Julien Danjou <julien@danjou.info>
17988
17989 * term.c (Fsuspend_tty, Fresume_tty):
17990 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17991 * window.c (temp_output_buffer_show):
17992 * insdel.c (signal_before_change):
17993 * frame.c (Fhandle_switch_frame):
17994 * fileio.c (Fdo_auto_save):
17995 * emacs.c (Fkill_emacs):
17996 * editfns.c (save_excursion_restore):
17997 * cmds.c (internal_self_insert):
17998 * callint.c (Fcall_interactively):
17999 * buffer.c (Fkill_all_local_variables):
18000 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
18001 Use Frun_hooks.
0f4a96b5 18002 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 18003 unconditionally since it does the check itself.
dee091a3 18004
2c520ab5 180052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 18006
c9c49752
PE
18007 Fix more problems found by GCC 4.5.2's static checks.
18008
8abc3f12
PE
18009 * coding.c (encode_coding_raw_text): Avoid unnecessary test
18010 the first time through the loop, since we know p0 < p1 then.
18011 This also avoids a gcc -Wstrict-overflow warning.
18012
a2d26660
PE
18013 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
18014 leading to a memory leak, possible in functions like
18015 load_charset_map_from_file that can allocate an unbounded number
b12ef411 18016 of objects (Bug#8318).
a2d26660 18017
916c72e9
PE
18018 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
18019 that could (at least in theory) be that large.
18020
19ab8a18
PE
18021 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
18022 This is less likely to overflow, and avoids undefined behavior if
18023 overflow does occur. All callers changed. Use strtoul to scan
18024 for the unsigned long integer.
b7cbbd6f
PE
18025 (pint2hrstr): Simplify and tune code slightly.
18026 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 18027
f0641eff
PE
18028 * scroll.c (do_scrolling): Work around GCC bug 48228.
18029 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
18030
7f650bb9
PE
18031 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
18032 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
18033 (validate_x_resource_name): Simplify count usage.
18034 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 18035
37dd57d1
PE
18036 * fileio.c (Fcopy_file): Report error if fchown or fchmod
18037 fail (Bug#8306).
81e56e61 18038
699979fc 18039 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 18040
401bf9b4
PE
18041 * process.c (Fmake_network_process): Use socklen_t, not int,
18042 where POSIX says socklen_t is required in portable programs.
18043 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 18044 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
18045 (Fmake_network_process, server_accept_connection):
18046 (wait_reading_process_output, read_process_output):
18047 Likewise.
18048
b93aacde
PE
18049 * process.c: Rename or move locals to avoid shadowing.
18050 (list_processes_1, Fmake_network_process):
18051 (read_process_output_error_handler, exec_sentinel_error_handler):
18052 Rename or move locals.
4dc343ee 18053 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 18054 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 18055 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 18056 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 18057 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 18058
af8a867c 18059 Make tparam.h and terminfo.c consistent.
44f230aa
SM
18060 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
18061 Include tparam.h instead, since it declares them.
af8a867c
PE
18062 * cm.h (PC): Remove extern decl; tparam.h now does this.
18063 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
18064 * terminfo.c: Include tparam.h, to check interfaces.
18065 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
18066 (tparam): Adjust signature to match interface in tparam.h;
18067 this removes some undefined behavior. Check that outstring and len
18068 are zero, which they always are with Emacs.
18069 * tparam.h (PC, BC, UP): New extern decls.
18070
0248044d 18071 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 18072 (xftfont_open): Rename locals to avoid shadowing.
0248044d 18073
8ff096c1 18074 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
18075 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
18076 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 18077 (ftfont_list): Remove unused local.
49eaafba
PE
18078 (get_adstyle_property, ftfont_pattern_entity):
18079 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
18080 Rename locals to avoid shadowing.
8ff096c1 18081
e2be39f6
PE
18082 * xfont.c (xfont_list_family): Mark var as initialized.
18083
c9735e30
PE
18084 * xml.c (make_dom): Now static.
18085
8f5201ae
PE
18086 * composite.c (composition_compute_stop_pos): Rename local to
18087 avoid shadowing.
b246f932
PE
18088 (composition_reseat_it): Remove unused locals.
18089 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 18090 (composition_update_it): Mark var as initialized.
11b61122
PE
18091 (find_automatic_composition): Mark vars as initialized,
18092 with a FIXME (Bug#8290).
8f5201ae 18093
760fbc2c
PE
18094 character.h: Rename locals to avoid shadowing.
18095 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
18096 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
18097 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
18098 (BUF_DEC_POS): Be more systematic about renaming local temporaries
18099 to avoid shadowing.
18100
ff08eb85
PE
18101 * textprop.c (property_change_between_p): Remove; unused.
18102
fc7bf025
PE
18103 * intervals.c (interval_start_pos): Now static.
18104
235d7abc
PE
18105 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
18106
44f230aa
SM
18107 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
18108 Rename locals to avoid shadowing.
3e7d6594 18109
50060332
PE
18110 * sound.c (wav_play, au_play, Fplay_sound_internal):
18111 Fix pointer signedness.
d01f234b 18112 (alsa_choose_format): Remove unused local var.
c83b8872
PE
18113 (wav_play): Initialize a variable to 0, to prevent undefined
18114 behavior (Bug#8278).
50060332 18115
c4fc4e30
PE
18116 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
18117
918436ed
PE
18118 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
18119
c939f91b
PE
18120 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
18121 clobbering (Bug#8298).
b9c7f648
PE
18122 * sysdep.c (sys_subshell): Likewise.
18123 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 18124
6bd8c144
PE
18125 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
18126 This should get cleaned up, so that child_setup has the
18127 same signature on all platforms.
18128
7710357c 18129 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 18130 (relocate_fd): Rename locals to avoid shadowing.
7710357c 18131
c59da222
CY
181322011-03-22 Chong Yidong <cyd@stupidchicken.com>
18133
18134 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
18135 not to be necessary, and produces flickering.
18136
66b87493
GM
181372011-03-20 Glenn Morris <rgm@gnu.org>
18138
18139 * config.in: Remove file.
18140
45b6f6d5
JB
181412011-03-20 Juanma Barranquero <lekktu@gmail.com>
18142
18143 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
18144 are now in src/globals.h.
18145 (syms_of_minibuf): Remove spurious & from previous change.
18146
cd394be1 181472011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
18148
18149 * minibuf.c (completing-read-function): New variable.
18150 (completing-read-default): Rename from completing-read.
18151 (completing-read): Call completing-read-function.
18152
b14e3e21
CY
181532011-03-19 Juanma Barranquero <lekktu@gmail.com>
18154
18155 * xfaces.c (Fx_load_color_file):
18156 Read color file from absolute filename (bug#8250).
18157
f2b726e6
JB
181582011-03-19 Juanma Barranquero <lekktu@gmail.com>
18159
18160 * makefile.w32-in: Update dependencies.
18161
09f6ff02
EZ
181622011-03-17 Eli Zaretskii <eliz@gnu.org>
18163
18164 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
18165
29a6015a
PE
181662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
18167
a3a6c54e
PE
18168 Fix more problems found by GCC 4.5.2's static checks.
18169
b766f867
PE
18170 * process.c (make_serial_process_unwind, send_process_trap):
18171 (sigchld_handler): Now static.
18172
be02381c
PE
18173 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
18174 That way, the code declares only the vars that it needs.
18175 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
18176 * s/cygwin.h (PTY_ITERATION): Likewise.
18177 * s/darwin.h (PTY_ITERATION): Likewise.
18178 * s/gnu-linux.h (PTY_ITERATION): Likewise.
18179
57048744
PE
18180 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
18181 * process.c (allocate_pty): Don't declare stb unless it's needed.
18182
7914961c 18183 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
18184 (CONSTANTLIM): Remove; unused.
18185 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
18186 Define only if needed.
7914961c 18187
b3967b18
PE
18188 * unexelf.c (unexec): Name an expression,
18189 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
18190 Use a different way to cause a compilation error if anyone uses
18191 n rather than nn, a way that does not involve shadowing.
73366a00 18192 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 18193
29a6015a
PE
18194 * deps.mk (unexalpha.o): Remove; unused.
18195
43cfc33e 18196 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 18197 * unexec.h: New file.
ce701a33
PE
18198 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
18199 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
18200 Depend on unexec.h.
18201 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
18202 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
18203 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 18204 Change as necessary to match prototype in unexec.h.
ce701a33 18205
01f44d5a
PE
18206 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
18207 shadowing.
4f63c6bb 18208 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 18209
a6670b0b
PE
18210 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
18211 Rename locals to avoid shadowing.
18212
cef2010d 18213 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 18214 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 18215
d4d7173a
PE
18216 * print.c (Fredirect_debugging_output): Fix pointer signedess.
18217
f08b802a
PE
18218 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
18219 warning when compiling print.c.
18220
3ddb0639
PE
18221 * font.c (font_unparse_fcname): Abort in an "impossible" situation
18222 instead of using an uninitialized var.
5ad03b97 18223 (font_sort_entities): Mark var as initialized.
3ddb0639 18224
170a2692
PE
18225 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
18226
e663c700
PE
18227 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
18228 pointers to constants.
89bc529a 18229 (font_parse_fcname): Remove unused vars.
7b81e2d0 18230 (font_delete_unmatched): Now static.
ea838e10 18231 (font_get_spec): Remove; unused.
13a547c6
PE
18232 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
18233 (font_update_drivers, Ffont_get_glyphs, font_add_log):
18234 Rename or move locals to avoid shadowing.
e663c700 18235
2a80c887 18236 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 18237 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 18238
1384fa33 18239 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 18240 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 18241
8b2c52e9
PE
18242 * alloc.c (mark_backtrace): Move decl from here ...
18243 * lisp.h: ... to here, so that it can be checked.
18244
475545b5 18245 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 18246 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
18247 (lisp_indirect_variable): Name an expression,
18248 to avoid gcc -Wbad-function-cast warning.
1faed8ae 18249 (Fdefvar): Rename locals to avoid shadowing.
475545b5 18250
b1349114 18251 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 18252 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 18253 Use const pointer when appropriate.
b1349114 18254
a2928364
PE
18255 * lisp.h (get_system_name, get_operating_system_release):
18256 Move decls here, to check interfaces.
18257 * process.c (get_operating_system_release): Move decl to lisp.h.
18258 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
18259 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
18260 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
18261 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
18262 (Fformat_time_string, Fencode_time, Finsert_char):
18263 (Ftranslate_region_internal, Fformat):
18264 Rename or remove local vars to avoid shadowing.
9710023e 18265 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 18266
a415e694
PE
18267 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
18268 avoid shadowing.
18269
8ef4622d
PE
18270 * lisp.h (eassert): Check that the argument compiles, even if
18271 ENABLE_CHECKING is not defined.
18272
946f9a5b
PE
18273 * data.c (Findirect_variable): Name an expression, to avoid
18274 gcc -Wbad-function-cast warning.
112396d6 18275 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 18276 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
18277 (Fmake_variable_buffer_local, Fmake_local_variable):
18278 Mark variables as initialized.
52746918 18279 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 18280
e5aab7e7 18281 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
18282 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
18283 Rename locals to avoid shadowing.
dff45157
PE
18284 (mark_stack): Move local variables into the #ifdef region where
18285 they're used.
7bc26fdb
PE
18286 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
18287 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
18288 needed otherwise.
18289 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
18290 (GC_STRING_CHARS): Remove; not used.
d40d4be1 18291 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 18292
e5aab7e7
PE
18293 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
18294 avoids undefined behavior in theory.
18295
4da60324
PE
18296 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
18297
88043301
PE
18298 Use functions, not macros, for up- and down-casing (Bug#8254).
18299 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
18300 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
18301 to use the following functions instead of these macros.
18302 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
18303 EMACS_INT, since callers assume the returned value fits in int.
18304 (upcase1): Likewise, for UPCASE_TABLE.
18305 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 18306 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 18307 the race-condition problem in the old DOWNCASE.
88043301 18308
19ed5445
PE
18309 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
18310 Rename locals to avoid shadowing.
18311 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
18312 (regex_compile, re_search_2, re_match_2_internal):
18313 Remove unused local vars.
952db0d7
PE
18314 (FREE_VAR): Rewrite so as not to use empty "else",
18315 which gcc can warn about.
da053e48 18316 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
18317 (RETALLOC_IF): Define only if needed.
18318 (WORDCHAR_P): Likewise. This one is never needed, but is used
18319 only in a comment talking about a compiler bug, so put inside
18320 the #if 0 of that comment.
18321 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
18322 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
18323 Remove; unused.
19ed5445 18324
1f3561e4 18325 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
18326 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
18327 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 18328
ded6f8f7
PE
18329 * search.c (simple_search): Remove unused var.
18330
dbd37a95
PE
18331 * dired.c (compile_pattern): Move decl from here ...
18332 * lisp.h: ... to here, so that it can be checked.
18333 (struct re_registers): New forward decl.
18334
7e47afad
PE
18335 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
18336
85f24f61
PE
18337 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
18338 All uses changed.
18339 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
18340 Rename locals to avoid shadowing.
5671df8f 18341 (Fvertical_motion): Mark locals as initialized.
85f24f61 18342
181aa2be 18343 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 18344 (casify_region): Mark local as initialized.
181aa2be 18345
930d429c
PE
18346 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
18347
7082eac6
PE
18348 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
18349 New macros, so that the caller can use some names other than
18350 gcpro1, gcpro2, etc.
18351 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
18352 of the new macros.
18353 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
18354 argument, for consistency with GCPRO2_VAR, etc: it is now the
18355 prefix of the variable, not the variable itself. All uses
18356 changed.
38b2c076
PE
18357 * dired.c (directory_files_internal, file_name_completion):
18358 Rename locals to avoid shadowing.
18359
15206ed9
PE
18360 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
18361 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
18362 dired.c's scmp function, had undefined behavior.
18363 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
18364 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
18365 * buffer.h: ... to here, because these macros use current_buffer,
18366 and the new implementation with inline functions needs to have
18367 current_buffer in scope now, rather than later when the macros
18368 are used.
18369 (downcase, upcase1): New static inline functions.
18370 (DOWNCASE, UPCASE1): Reimplement using these functions.
18371 This avoids undefined behavior in expressions like
18372 DOWNCASE (x) == DOWNCASE (y), which previously suffered
18373 from race conditions in accessing the global variables
18374 case_temp1 and case_temp2.
18375 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
18376 * lisp.h (case_temp1, case_temp2): Remove their decls.
18377 * character.h (ASCII_CHAR_P): Move from here ...
18378 * lisp.h: ... to here, so that the inline functions mentioned
18379 above can use them.
18380
4a6bea26
PE
18381 * dired.c (directory_files_internal_unwind): Now static.
18382
f14b7e14
PE
18383 * fileio.c (file_name_as_directory, directory_file_name):
18384 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
18385 Now static.
2893f146
PE
18386 (file_name_as_directory): Use const pointers when appropriate.
18387 (Fexpand_file_name): Likewise. In particular, newdir might
18388 point at constant storage, so make it a const pointer.
fd4ead52 18389 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
18390 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
18391 signedness issues.
f839df0c
PE
18392 (Fset_file_times, Finsert_file_contents, auto_save_error):
18393 Rename locals to avoid shadowing.
f14b7e14 18394
5716756e 18395 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
18396 (Ftry_completion, Fall_completions): Rename or remove locals
18397 to avoid shadowing.
5716756e 18398
b4c3046a
PE
18399 * marker.c (bytepos_to_charpos): Remove; unused.
18400
b45db522
PE
18401 * lisp.h (verify_bytepos, count_markers): New decls,
18402 so that gcc does not warn that these functions aren't declared.
18403
85876d07
PE
18404 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
18405 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 18406 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 18407 (copy_text): Remove unused local var.
85876d07 18408
03d78a21 18409 * filelock.c (within_one_second): Now static.
b3dd38ab 18410 (lock_file_1): Rename local to avoid shadowing.
03d78a21 18411
5df8f01b
PE
18412 * buffer.c (fix_overlays_before): Mark locals as initialized.
18413 (fix_start_end_in_overlays): Likewise. This function should be
18414 simplified by using pointers-to-pointers, but that's a different
18415 matter.
b1d876f1 18416 (switch_to_buffer_1): Now static.
8f54f30a
PE
18417 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
18418 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 18419
a70072c9 18420 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 18421 Fix pointer signedness issue.
edced198
PE
18422 (sys_subshell): Mark local as volatile if checking for lint,
18423 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 18424 (MAXPATHLEN): Define only if needed.
a70072c9 18425
a0977c44
PE
18426 * process.c (serial_open, serial_configure): Move decls from here ...
18427 * systty.h: ... to here, so that they can be checked.
18428
a884fdcc
PE
18429 * fns.c (get_random, seed_random): Move extern decls from here ...
18430 * lisp.h: ... to here, so that they can be checked.
18431
604efe86 18432 * sysdep.c (reset_io): Now static.
b8950c94 18433 (wait_for_termination_signal): Remove; unused.
604efe86 18434
38fc62d9
PE
18435 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
18436 (copy_keymap_item, append_key, push_text_char_description):
18437 Now static.
1004a21a 18438 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 18439 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
18440 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
18441 (describe_map_tree):
18442 Rename locals to avoid shadowing.
38fc62d9 18443
2f2650da
PE
18444 * keyboard.c: Declare functions static if they are not used elsewhere.
18445 (echo_char, echo_dash, cmd_error, top_level_2):
18446 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
18447 (read_char, kbd_buffer_get_event, make_lispy_position):
18448 (make_lispy_event, make_lispy_movement, apply_modifiers):
18449 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
18450 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
18451 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 18452 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 18453 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 18454
a053e86c 18455 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
18456 (mark_kboards): Move decl here ...
18457 * alloc.c (mark_kboards): ... from here.
a053e86c 18458
4752793e
PE
18459 * lisp.h (force_auto_save_soon): New decl.
18460
74f10ca7 18461 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
18462 (DEFINE_DUMMY_FUNCTION): New macro.
18463 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
18464 Use it.
c03cd23f
PE
18465 (main): Add casts to avoid warnings
18466 if GCC considers string literals to be constants.
74f10ca7 18467
022e70d4
PE
18468 * lisp.h (fatal_error_signal): Add decl, since it's exported.
18469
59d6fe83
PE
18470 * dbusbind.c: Pointer signedness fixes.
18471 (xd_signature, xd_append_arg, xd_initialize):
18472 (Fdbus_call_method, Fdbus_call_method_asynchronously):
18473 (Fdbus_method_return_internal, Fdbus_method_error_internal):
18474 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
18475 (Fdbus_register_signal): Use SSDATA when the context wants char *.
18476
78320123
PE
18477 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
18478 if GCC considers string literals to be constants.
49cebcca 18479 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 18480
35ac2a97
SM
184812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
18482
fb103ca9
SM
18483 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
18484 (print_preprocess, print_object): New macro to fix last change.
18485
35ac2a97
SM
18486 * print.c (print_preprocess): Don't forget font objects.
18487
62973b41
JB
184882011-03-16 Juanma Barranquero <lekktu@gmail.com>
18489
18490 * emacs.c (USAGE3): Doc fixes.
18491
0e48bb22
AS
184922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
18493
18494 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
18495 structure.
18496
7684e57b
JB
184972011-03-14 Juanma Barranquero <lekktu@gmail.com>
18498
18499 * lisp.h (VWindow_system, Qfile_name_history):
18500 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
18501 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
18502 (w32_system_caret_x, w32_system_caret_y): Declare extern.
18503
18504 * w32select.c: Don't #include "keyboard.h".
c96bbc66 18505 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
18506
18507 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
18508 * w32console.c (detect_input_pending, read_input_pending)
18509 (encode_terminal_code):
18510 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
18511 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
18512 (w32_system_caret_y, Qfile_name_history):
18513 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
18514 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
18515 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
18516 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
18517 * w32proc.c (Qlocal, report_file_error):
18518 * w32term.c (Vwindow_system, updating_frame):
18519 * w32uniscribe.c (initialized, uniscribe_font_driver):
18520 Remove unneeded extern declarations.
18521
2aa46d6c
CY
185222011-03-14 Chong Yidong <cyd@stupidchicken.com>
18523
c96bbc66 18524 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 18525
cffc6f3b
CY
185262011-03-13 Chong Yidong <cyd@stupidchicken.com>
18527
18528 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
18529 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
18530 These macros can no longer be used for assignment.
18531
44f230aa
SM
18532 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
18533 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
18534 (record_buffer_markers, fetch_buffer_markers): New functions for
18535 recording and fetching special buffer markers.
18536 (set_buffer_internal_1, set_buffer_temp): Use them.
18537
18538 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
18539
18540 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
18541
18542 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
18543 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
18544
18545 * xdisp.c (hscroll_window_tree):
18546 (reconsider_clip_changes): Use PT instead of BUF_PT.
18547
d251f04b
EZ
185482011-03-13 Eli Zaretskii <eliz@gnu.org>
18549
18550 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
18551 $(EMACS_ROOT)/lib/intprops.h.
18552
f0c77cd1
PE
185532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
18554
3eca4629
PE
18555 Fix more problems found by GCC 4.5.2's static checks.
18556
7c86ee98
PE
18557 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
18558 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
18559 (xg_free_frame_widgets): Make it clear that a local variable is
18560 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
18561 (gdk_window_get_screen): Make it clear that this macro is needed
18562 only if USE_GTK_TOOLTIP.
1e5524e7
PE
18563 (int_gtk_range_get_value): New function, which avoids a diagnostic
18564 from gcc -Wbad-function-cast.
18565 (xg_set_toolkit_scroll_bar_thumb): Use it.
18566 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
18567 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
18568 (get_utf8_string, xg_get_file_with_chooser):
18569 Rename locals to avoid shadowing.
18570 (create_dialog): Move locals to avoid shadowing.
7c86ee98 18571
41729b81
PE
18572 * xgselect.c (xg_select): Remove unused var.
18573
f0c77cd1
PE
18574 * image.c (four_corners_best): Mark locals as initialized.
18575 (gif_load): Initialize transparent_p to zero (Bug#8238).
18576 Mark another local as initialized.
ec6cf4c6 18577 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 18578
ce0ad53d 18579 * image.c (clear_image_cache): Now static.
d5d5a617 18580 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 18581 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
18582 (x_edge_detection): Remove unnecessary cast that
18583 gcc -Wbad-function-cast diagnoses.
2037898d 18584 (gif_load): Fix pointer signedness.
6ae141d6
PE
18585 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
18586 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 18587
33383987 185882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 18589
d32df629
PE
18590 Improve quality of tests for time stamp overflow.
18591 For example, without this patch (encode-time 0 0 0 1 1
18592 1152921504606846976) returns the obviously-bogus value (-948597
18593 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
18594 reports time overflow. See
18595 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
18596 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
18597 * editfns.c: Include limits.h and intprops.h.
18598 (TIME_T_MIN, TIME_T_MAX): New macros.
18599 (time_overflow): Move earlier, to before first use.
18600 (hi_time, lo_time): New functions, for an accurate test for
18601 out-of-range times.
18602 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
18603 (Fget_internal_run_time): Don't assume time_t fits in int.
18604 (make_time): Use list2 instead of Fcons twice.
18605 (Fdecode_time): More accurate test for out-of-range times.
18606 (check_tm_member): New function.
18607 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
18608 (lisp_time_argument): Don't rely on undefined left-shift and
18609 right-shift behavior when checking for time stamp overflow.
8be6f318 18610
fe31d94c
PE
18611 * editfns.c (time_overflow): New function, refactoring common code.
18612 (Fformat_time_string, Fdecode_time, Fencode_time):
18613 (Fcurrent_time_string): Use it.
18614
8be6f318
PE
18615 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
18616 * dired.c (make_time): Move to ...
18617 * editfns.c (make_time): ... here.
18618 * systime.h: Note the move.
18619
09d9db2c 186202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 18621
126bc0dc
YM
18622 * fringe.c (update_window_fringes): Remove unused variables.
18623
c47cbdfd
YM
18624 * unexmacosx.c (copy_data_segment): Also copy __got section.
18625 (Bug#8223)
18626
7ac80be9
EZ
186272011-03-12 Eli Zaretskii <eliz@gnu.org>
18628
c96bbc66 18629 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
18630 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
18631 Constify `char *' arguments and their references according to
18632 prototypes in tparam.h.
18633
ecb0f94d 18634 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 18635
7ac80be9
EZ
18636 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
18637 Adapt all references accordingly.
18638
18639 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
18640
ef1fd07e
TT
186412011-03-11 Tom Tromey <tromey@redhat.com>
18642
18643 * buffer.c (syms_of_buffer): Remove obsolete comment.
18644
7ef4b50c
EZ
186452011-03-11 Eli Zaretskii <eliz@gnu.org>
18646
18647 * termhooks.h (encode_terminal_code): Declare prototype.
18648
18649 * msdos.c (encode_terminal_code): Don't declare prototype.
18650
18651 * term.c (encode_terminal_code): Now external again, used by
18652 w32console.c and msdos.c.
18653
44f230aa
SM
18654 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
18655 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 18656
4b1ec863 186572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 18658
1714f52b 18659 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 18660
4b1ec863
PE
18661 * fringe.c (update_window_fringes): Mark locals as initialized
18662 (Bug#8227).
18663 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 18664
524c7aa6
PE
18665 * alloc.c (mark_fringe_data): Move decl from here ...
18666 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
18667 to check its interface.
18668 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
18669
a5c0af81 18670 * fontset.c (free_realized_fontset): Now static.
7519b8cd 18671 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 18672 (fontset_font): Mark local as initialized.
a9a06e0b 18673 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 18674
b4716021
PE
18675 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
18676
811e9bac 18677 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 18678 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
18679 (x_own_selection, Fx_disown_selection_internal): Rename locals
18680 to avoid shadowing.
18681 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 18682
7e3ab302
PE
18683 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
18684 so that the caller can use some name other than gcpro1.
18685 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
18686 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18687 (Fx_backspace_delete_keys_p):
18688 Use them to avoid shadowing, and rename vars to avoid shadowing.
18689 (x_decode_color, x_set_name, x_window): Now static.
6b437900 18690 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 18691 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
18692 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
18693 Remove unused locals.
7e3ab302
PE
18694 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18695 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
18696 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
18697 macros.
f78faa98 18698
e2b13473
PE
18699 * xterm.h (x_mouse_leave): New decl.
18700
77f23912
PE
18701 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
18702 Remove unused functions.
cdf4ba58
PE
18703 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
18704 (x_calc_absolute_position): Now static.
7411c686 18705 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 18706 Don't declare local "event" unless it's used.
ed7bf3a5
PE
18707 (x_iconify_frame, x_free_frame_resources): Don't declare locals
18708 unless they are used.
38d0b34a
PE
18709 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
18710 (x_fatal_error_signal): Remove; not used.
a6067996
PE
18711 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
18712 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
18713 (x_error_catcher, x_connection_closed, x_error_handler):
18714 (x_error_quitter, xembed_send_message, x_iconify_frame):
18715 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 18716 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 18717 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 18718
44f230aa
SM
18719 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
18720 Rename or move locals to avoid shadowing.
6b463e58 18721 (tty_defined_color, merge_face_heights): Now static.
5967d051 18722 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
18723 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
18724 does not deduce is never used uninitialized.
73719eba
PE
18725 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
18726 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 18727
426994c3 18728 * terminal.c (store_terminal_param): Now static.
5489860b 18729
032f1620 18730 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 18731 (set_frame_menubar): Remove unused local.
d4323972 18732 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
18733 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
18734 since they might point to immutable storage.
281585b0
PE
18735 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
18736 since it's unused otherwise.
032f1620 18737
367c19e5 18738 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 18739 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
18740 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
18741 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 18742 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
18743 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
18744 does not deduce are never used uninitialized.
70739cbe 18745
07b48fa9
PE
18746 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
18747
8868a238 18748 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
18749 * window.c (window_loop, size_window):
18750 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 18751
7e5cf297 18752 * window.c (display_buffer): Now static.
d6550a9f
PE
18753 (size_window): Mark variables that gcc -Wuninitialized
18754 does not deduce are never used uninitialized.
a586633d
PE
18755 * window.h (check_all_windows): New decl, to forestall
18756 gcc -Wmissing-prototypes diagnostic.
5b555da1 18757 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 18758
f6095868
PE
18759 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
18760 shadowing.
18761 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
18762 Include <limits.h>.
18763 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
18764 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
18765 (load_charset_map): Mark variables that gcc -Wuninitialized
18766 does not deduce are never used uninitialized.
53df7c11 18767 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 18768
f38b440c
PE
18769 * coding.c (coding_set_source, coding_set_destination):
18770 Use "else { /* comment */ }" rather than "else /* comment */;"
18771 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
18772 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
18773 a block, when the outer 'i' will do.
18774 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
18775 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
18776 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
18777 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
18778 (Fdecode_sjis_char, Fdefine_coding_system_internal):
18779 Rename locals to avoid shadowing.
18780 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
18781 * coding.c (emacs_mule_char, encode_invocation_designation):
18782 Now static, since they're not used elsewhere.
413bb2db 18783 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 18784 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
18785 (decode_coding_emacs_mule): Mark variables that gcc
18786 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
18787 (detect_coding_iso_2022): Initialize a local variable that might
18788 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 18789 this initialization is needed. (Bug#8211)
5f58e762
PE
18790 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
18791 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
18792 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
18793 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
18794 Remove unused macros.
f38b440c 18795
232b38b9 18796 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 18797 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 18798 * character.c (string_count_byte8): Likewise.
232b38b9 18799
fb90da1b
PE
18800 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
18801 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
18802
fb93dbc2
PE
18803 * chartab.c (copy_sub_char_table): Now static, since it's not used
18804 elsewhere.
5c156ace
PE
18805 (sub_char_table_ref_and_range, char_table_ref_and_range):
18806 Rename locals to avoid shadowing.
bbcd0949 18807 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 18808
7d3b3862 18809 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 18810 (BIDI_BOB): Remove unused macro.
7d3b3862 18811
6be7d3da
PE
18812 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
18813 deduce are never used uninitialized.
c2ed9c8b 18814 * term.c (encode_terminal_code): Likewise.
6be7d3da 18815
75f8807f 18816 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 18817
50938595
PE
18818 * tparam.h: New file.
18819 * term.c, tparam.h: Include it.
18820 * deps.mk (term.o, tparam.o): Depend on tparam.h.
18821 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
18822 Move these decls to tparam.h, and make them agree with what
18823 is actually in tparam.c. The previous trick of using incompatible
18824 decls in different modules does not conform to the C standard.
18825 All callers of tparam changed to use tparam's actual API.
18826 * tparam.c (tparam1, tparam, tgoto):
18827 Use const pointers where appropriate.
18828
fbceeba2
PE
18829 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
18830 * cm.h (struct cm): Likewise.
18831 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
18832 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
18833 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
18834 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
18835 (turn_on_face, init_tty): Likewise.
18836 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 18837
7f3f1250
PE
18838 * term.c (term_mouse_position): Rename local to avoid shadowing.
18839
e6ca6543
PE
18840 * alloc.c (mark_ttys): Move decl from here ...
18841 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
18842
c40f8d15
AS
188432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
18844
18845 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
18846
cfe0661d
JB
188472011-03-09 Juanma Barranquero <lekktu@gmail.com>
18848
18849 * search.c (compile_pattern_1): Remove argument regp, unused since
18850 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
18851 (compile_pattern): Don't pass it.
18852
0afb4571
J
188532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
18854
18855 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
18856 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
18857 for ! HAVE_GTK3.
18858 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
18859
18860 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
18861
18862 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
18863 gdk_window_get_screen, gdk_window_get_geometry,
18864 gdk_x11_window_lookup_for_display and GDK_KEY_g.
18865 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
18866 (xg_get_pixbuf_from_pixmap): New function.
18867 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
18868 to Pixmap, take frame as parameter, remove GdkColormap parameter.
18869 Call xg_get_pixbuf_from_pixmap instead of
18870 gdk_pixbuf_get_from_drawable.
18871 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
18872 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
18873 (xg_check_special_colors): Use GtkStyleContext and its functions
18874 for HAVE_GTK3.
18875 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
18876 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
18877 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
18878 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
18879 Call gtk_widget_get_preferred_size.
0afb4571
J
18880 (xg_frame_resized): gdk_window_get_geometry only takes 5
18881 parameters.
44f230aa
SM
18882 (xg_win_to_widget, xg_event_is_for_menubar):
18883 Call gdk_x11_window_lookup_for_display.
0afb4571
J
18884 (xg_set_widget_bg): New function.
18885 (delete_cb): New function.
895009e1 18886 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 18887 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
18888 (xg_set_background_color): Call xg_set_widget_bg.
18889 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
18890 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
18891 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
18892 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
18893 if ! HAVE_GTK3.
18894 (update_frame_tool_bar): Call gtk_widget_hide.
18895 (xg_initialize): Use GDK_KEY_g.
18896
18897 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
18898 if ! HAVE_GTK3
18899 (x_session_initialize): Call gdk_x11_set_sm_client_id.
18900
18901 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
18902 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
18903 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
18904
1c2cc4ef
JB
189052011-03-08 Juanma Barranquero <lekktu@gmail.com>
18906
18907 * w32xfns.c (select_palette): Check success of RealizePalette against
18908 GDI_ERROR, not zero.
18909
33383987 18910See ChangeLog.11 for earlier changes.
aac0c6e3
MR
18911
18912;; Local Variables:
18913;; coding: utf-8
aac0c6e3
MR
18914;; End:
18915
2f097256 18916 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
18917
18918 This file is part of GNU Emacs.
18919
18920 GNU Emacs is free software: you can redistribute it and/or modify
18921 it under the terms of the GNU General Public License as published by
18922 the Free Software Foundation, either version 3 of the License, or
18923 (at your option) any later version.
18924
18925 GNU Emacs is distributed in the hope that it will be useful,
18926 but WITHOUT ANY WARRANTY; without even the implied warranty of
18927 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18928 GNU General Public License for more details.
18929
18930 You should have received a copy of the GNU General Public License
18931 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.