* sysdep.c: Make symbols static if they're not exported.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
93ea6e8f
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
1fa53021
PE
3 * sysdep.c: Make symbols static if they're not exported.
4 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5 Now static.
6 (sigprocmask_set, full_mask): Remove; unused.
7 (wait_debugging): Mark as visible.
8 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10
d4b43b22
PE
11 * syntax.c (syntax_temp): Define only if !__GNUC__.
12
b7c513d0
PE
13 * sound.c (current_sound_device, current_sound): Now static.
14
989b29ad
PE
15 * search.c (searchbufs, searchbuf_head): Now static.
16
13a55a78
PE
17 * scroll.c (scroll_cost): Remove; unused.
18 * dispextern.h (scroll_cost): Remove decl.
19
de68a1fc
PE
20 * region-cache.h (pp_cache): Mark as externally visible.
21
40ccffa6
PE
22 * process.c: Make symbols static if they're not exported.
23 (process_tick, update_tick, create_process, chan_process):
24 (Vprocess_alist, proc_buffered_char, datagram_access):
25 (fd_callback_data, send_process_frame, process_sent_to): Now static.
26 (deactivate_process): Mark defn as static, as well as decl.
27 * lisp.h (create_process): Remove decl.
28 * process.h (chan_process, Vprocess_alist): Remove decls.
29
ad64fc97
PE
30 * print.c: Make symbols static if they're not exported.
31 (print_depth, new_backquote_output, being_printed, print_buffer):
32 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
33 (print_interval, print_number_index, initial_stderr_stream):
34 Now static.
35 * lisp.h (Fprinc): Remove decl.
36 (debug_output_compilation_hack): Mark as externally visible.
37
adddb265
PE
38 * sysdep.c (croak): Move decl from here to syssignal.h.
39 * syssignal.h (croak): Put it here, so the API can be checked when
40 'croak' is called from dissociate_if_controlling_tty.
41
1717ede2
PE
42 * minibuf.c: Make symbols static if they're not exported.
43 (minibuf_save_list, choose_minibuf_frame): Now static.
44 * lisp.h (choose_minibuf_frame): Remove decl.
45
fa5fb2bc
PE
46 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
47
1e3890d1
PE
48 * lread.c: Make symbols static if they're not exported.
49 (read_objects, initial_obarray, oblookup_last_bucket_number):
50 Now static.
51 (make_symbol): Remove; unused.
52 * lisp.h (initial_obarray, make_symbol): Remove decls.
53
8a1414fa
PE
54 * keyboard.c: Make symbols static if they're not exported.
55 (single_kboard, recent_keys_index, total_keys, recent_keys):
56 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
57 (this_single_command_key_start, echoing, last_auto_save):
58 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
59 (command_loop, echo_now, keyboard_init_hook, help_char_p):
60 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
61 (Vlispy_mouse_stem, double_click_count):
62 Now static.
63 (force_auto_save_soon): Define only if SIGDANGER.
64 (ignore_mouse_drag_p): Now static if
65 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
66 (print_help): Remove; unused.
67 (stop_character, last_timer_event): Mark as externally visible.
68 * keyboard.h (ignore_mouse_drag_p): Declare only if
69 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
70 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
71 * lisp.h (echoing): Remove decl.
72 (force_auto_save_soon): Declare only if SIGDANGER.
73 * xdisp.c (redisplay_window): Simplify code, to make it more
74 obvious that ignore_mouse_drag_p is not accessed if !defined
75 USE_GTK && !defined HAVE_NS.
76
93ea6e8f
PE
77 * intervals.c: Make symbols static if they're not exported.
78 (merge_properties_sticky, merge_interval_right, delete_interval):
79 Now static.
80 * intervals.h (merge_interval_right, delete_interval): Remove decls.
81
b532497d
PE
822011-04-13 Paul Eggert <eggert@cs.ucla.edu>
83
77382fcc
PE
84 * insdel.c: Make symbols static if they're not exported.
85 However, leave prepare_to_modify_buffer alone. It's never
86 called from outside this function, but that appears to be a bug.
87 (combine_after_change_list, combine_after_change_buffer):
4889fc82 88 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
89 (adjust_after_replace_noundo): Remove; unused.
90 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 91 (signal_before_change): Remove decls.
77382fcc 92
9306c32e
PE
93 * indent.c (val_compute_motion, val_vmotion): Now static.
94
cd44d2eb
PE
95 * image.c: Make symbols static if they're not exported.
96 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
97 if USE_GTK.
98 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
99 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
100
ad9a7a06
PE
101 * fringe.c (standard_bitmaps): Now static.
102 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
103
81626931
PE
104 * frame.c: Make symbols static if they're not exported.
105 (x_report_frame_params, make_terminal_frame): Now static.
106 (get_frame_param): Now static, unless HAVE_NS.
107 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
108 (x_get_resource_string): Remove; not used.
109 * frame.h (make_terminal_frame, x_report_frame_params):
110 (x_get_resource_string); Remove decls.
111 (x_fullscreen_adjust): Declare only if WINDOWSNT.
112 * lisp.h (get_frame_param): Declare only if HAVE_NS.
113
239f9db9
PE
114 * font.c, fontset.c: Make symbols static if they're not exported.
115 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
116 (FACE_SUITABLE_FOR_CHAR_P): Use it.
117 * font.c (font_close_object): Now static.
118 * font.h (font_close_object): Remove.
119 * fontset.c (FONTSET_OBJLIST): Remove.
120 (free_realized_fontset) #if-0 the body, which does nothing.
121 (face_suitable_for_char_p): #if-0, as it's never called.
122 * fontset.h (face_suitable_for_char_p): Remove decl.
123 * xfaces.c (face_at_string_position): Use
124 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
125 since 0 is always ASCII.
126
dfcf3579
PE
127 * fns.c (weak_hash_tables): Now static.
128
5045092b
PE
129 * fileio.c: Make symbols static if they're not exported.
130 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
131 (Vwrite_region_annotation_buffers): Now static.
132
57a96f5c
PE
133 * eval.c: Make symbols static if they're not exported.
134 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
135 * lisp.h (backtrace_list): Remove decl.
136
35f08c38
PE
137 * emacs.c: Make symbols static if they're not exported.
138 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
139 (fatal_error_code, fatal_error_signal_hook, standard_args):
140 Now static.
141 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
142 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
143 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
144 * lisp.h (fatal_error_signal_hook): Remove decl.
145 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
146
f44bd759
PE
147 * editfns.c: Move a (normally-unused) function to its only use.
148 * editfns.c, lisp.h (get_operating_system_release): Remove.
149 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
150 worth the hassle of breaking this out.
151
b532497d
PE
152 * xterm.c: Make symbols static if they're not exported.
153 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
154 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
155 (x_destroy_window, x_delete_display):
156 Now static.
157 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
158 (x_mouse_leave): Remove; unused.
159 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
160 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
161 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
162 Remove decls.
163 (x_mouse_leave): Declare only if WINDOWSNT.
164 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
165 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
166 USE_X_TOOLKIT.
167
a25f4dfa
PE
1682011-04-12 Paul Eggert <eggert@cs.ucla.edu>
169
1675728f
PE
170 * ftxfont.c: Make symbols static if they're not exported.
171 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
172 HAVE_FREETYPE.
173 * font.h (ftxfont_driver): Likewise.
174
e4cebfca
PE
175 * xfns.c: Make symbols static if they're not exported.
176 (x_last_font_name, x_display_info_for_name):
177 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
178 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
179 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
180 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
181 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
182 (last_show_tip_args): Now static.
183 (xic_defaut_fontset, xic_create_fontsetname): Define only if
184 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
185 (x_screen_planes): Remove; unused.
186 * dispextern.h (x_screen_planes): Remove decl.
187
5bf46f05
PE
188 * dispnew.c: Make symbols static if they're not exported.
189 * dispextern.h (redraw_garbaged_frames, scrolling):
190 (increment_row_positions): Remove.
191 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
192 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
193 Now static.
194 (redraw_garbaged_frames): Remove; unused.
195
435f4c28
PE
196 * xfaces.c: Make symbols static if they're not exported.
197 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
198 Remove decls.
199 * xterm.h (defined_color): Remove decls.
200 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
201 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
202 (menu_face_changed_default, defined_color, free_realized_face):
203 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
204 (ascii_face_of_lisp_face): Remove; unused.
205
8524aef3
PE
206 * xdisp.c: Make symbols static if they're not exported.
207 * dispextern.h (scratch_glyph_row, window_box_edges):
208 (glyph_to_pixel_coords, set_cursor_from_row):
209 (get_next_display_element, set_iterator_to_next):
210 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
211 (show_mouse_face): Remove decls
212 * frame.h (message_buf_print): Likewise.
213 * lisp.h (pop_message, set_message, check_point_in_composition):
214 Likewise.
215 * xterm.h (set_vertical_scroll_bar): Likewise.
216 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
217 (message_buf_print, scratch_glyph_row, displayed_buffer):
218 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
219 (get_next_display_element, show_mouse_face, window_box_edges):
220 (frame_to_window_pixel_xy, check_point_in_composition):
221 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
222 (glyph_to_pixel_coords): Remove; unused.
223
16390cd2
PE
224 * dired.c (file_name_completion): Now static.
225
226 * dbusbind.c (xd_in_read_queued_messages): Now static.
227
a25f4dfa
PE
228 * lisp.h (circular_list_error, FOREACH): Remove; unused.
229 * data.c (circular_list_error): Remove.
230
16a97296
PE
2312011-04-11 Paul Eggert <eggert@cs.ucla.edu>
232
14a9c8df
PE
233 * commands.h (last_point_position, last_point_position_buffer):
234 (last_point_position_window): Remove decls.
235 * keyboard.c: Make these variables static.
236
74ab6df5
PE
237 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
238 decls.
239 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
240 (iso_code_class, detect_coding, code_convert_region): Now static.
241 (encode_coding_gap): Remove; unused.
242
38dfbee1
PE
243 * chartab.c (chartab_chars, chartab_bits): Now static.
244
a2cb4e63
PE
245 * charset.h (charset_iso_8859_1): Remove decl.
246 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
247 Now static.
248
127198fd
PE
249 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
250 * ccl.c (Vccl_program_table): Now static.
251 (check_ccl_update): Remove; unused.
252
d85b608f
PE
253 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
254 * category.h: ... from here.
255 * category.c (check_category_table, set_category_set): Now static.
256
31cd66f3
PE
257 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
258 * lisp.h: Remove these decls.
259
c358e587
PE
260 * buffer.c (buffer_count): Remove unused var.
261
e78aecca
PE
262 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
263 so that it's not optimized away.
264 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
265 * dispextern.h (bidi_dump_cached_states): Remove, since it's
266 exported only to the debugger.
267
e192d7d3
PE
268 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
269 * atimer.h (run_all_atimers): Removed; not exported.
270
92470028
PE
271 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
272 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
273 was inaccessible from Lisp.
274 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
275 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
276
244ed907
PE
277 alloc.c: Import and export fewer symbols, and remove unused items.
278 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
279 is defined.
280 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
281 it's not optimized away by whole-program optimization.
282 (message_enable_multibyte, free_misc): Remove.
283 (catchlist, handlerlist, mark_backtrace):
284 Declare only if BYTE_MARK_STACK.
285 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
286 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
287 (message_enable_multibyte): Remove decl.
288 (free_misc, interval_free_list, float_block, float_block_index):
289 (n_float_blocks, float_free_list, cons_block, cons_block_index):
290 (cons_free_list, last_marked_index):
291 Now static.
292 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
293 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
294 (mark_backtrace): Define only if BYTE_MARK_STACK.
295 * xdisp.c (message_enable_multibyte): Now static.
296
955cbe7b
PE
297 Declare Lisp_Object Q* variables to be 'static' if not exproted.
298 This makes it easier for human readers (and static analyzers)
299 to see whether these variables are used from other modules.
300 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
301 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
302 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
303 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
304 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
305 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
306 * xmenu.c, xselect.c:
307 Declare Q* vars static if they are not used in other modules.
308 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
309 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
310 Remove decls of unexported vars.
311 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
312
95c82688
PE
313 * lisp.h (DEFINE_FUNC): Make sname 'static'.
314
16a97296
PE
315 Make Emacs functions such as Fatom 'static' by default.
316 This makes it easier for human readers (and static analyzers)
317 to see whether these functions can be called from other modules.
318 DEFUN now defines a static function. To make the function external
319 so that it can be used in other C modules, use the new macro DEFUE.
320 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
321 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
322 static function definition. Use DEFUE if you want an extern one.
323 (DEFUE, INFUN): New macros.
324 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
325 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
326 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
327 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
328 Remove decls, since these functions are now static.
329 (Funintern, Fget_internal_run_time): New decls, since these functions
330 were already external.
95c82688 331
16a97296
PE
332 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
333 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
334 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
335 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
336 * keyboard.c, keymap.c, lread.c:
337 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
338 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
339 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
340 Mark functions with DEFUE instead of DEFUN,
341 if they are used in other modules.
342 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
343 decls for now-static functions.
344 * buffer.h (Fdelete_overlay): Remove decl.
345 * callproc.c (Fgetenv_internal): Mark as internal.
346 * composite.c (Fremove_list_of_text_properties): Remove decl.
347 (Fcomposition_get_gstring): New forward static decl.
348 * composite.h (Fcomposite_get_gstring): Remove decl.
349 * dired.c (Ffile_attributes): New forward static decl.
350 * doc.c (Fdocumntation_property): New forward static decl.
351 * eval.c (Ffetch_bytecode): New forward static decl.
352 (Funintern): Remove extern decl; now in .h file where it belongs.
353 * fileio.c (Fmake_symbolic_link): New forward static decl.
354 * image.c (Finit_image_library): New forward static decl.
355 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
356 * intervals.h (Fprevious_property_change):
357 (Fremove_list_of_text_properties): Remove decls.
358 * keyboard.c (Fthis_command_keys): Remove decl.
359 (Fcommand_execute): New forward static decl.
360 * keymap.c (Flookup_key): New forward static decl.
361 (Fcopy_keymap): Now static.
362 * keymap.h (Flookup_key): Remove decl.
363 * process.c (Fget_process): New forward static decl.
364 (Fprocess_datagram_address): Mark as internal.
365 * syntax.c (Fsyntax_table_p): New forward static decl.
366 (skip_chars): Remove duplicate decl.
367 * textprop.c (Fprevious_property_change): New forward static decl.
368 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
369 Now internal.
370 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
371 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
372
785bbd42
PE
3732011-04-10 Paul Eggert <eggert@cs.ucla.edu>
374
375 * editfns.c (Fformat): Remove unreachable code.
376
4073e537 3772011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 378
b2ded58d
PE
379 Fix more problems found by GCC 4.6.0's static checks.
380
7d66342c
PE
381 * xdisp.c (vmessage): Use a better test for character truncation.
382
bbf47d44
PE
383 * charset.c (load_charset_map): <, not <=, for optimization,
384 and to avoid potential problems with integer overflow.
9248994d 385 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 386 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 387 * editfns.c (Fformat): Likewise.
1e69125e 388 * syntax.c (skip_chars): Likewise.
3befa583 389
e3019616
PE
390 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
391 This also lets GCC 4.6.0 generate slightly better loop code.
392
becfa255
PE
393 * callint.c (Fcall_interactively): <, not <=, for optimization.
394 (Fcall_interactively): Count the number of arguments produced,
395 not the number of arguments given. This is simpler and lets GCC
396 4.6.0 generate slightly better code.
397
dae0cd48
PE
398 * ftfont.c: Distingish more carefully between FcChar8 and char.
399 The previous code passed unsigned char * to a functions like
400 strlen and xstrcasecmp that expect char *, which does not
401 conform to the C standard.
402 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
403 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
404 char * when the C standard requires it.
405
76032d70
PE
406 * keyboard.c (read_char): Remove unused var.
407
eb3f1cc8
PE
408 * eval.c: Port to Windows vsnprintf (Bug#8435).
409 Include <limits.h>.
410 (SIZE_MAX): Define if the headers do not.
411 (verror): Do not give up if vsnprintf returns a negative count.
412 Instead, grow the buffer. This ports to Windows vsnprintf, which
413 does not conform to C99. Problem reported by Eli Zaretskii.
414 Also, simplify the allocation scheme, by avoiding the need for
415 calling realloc, and removing the ALLOCATED variable.
416
70476b54
PE
417 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
418
12020a9e
PE
419 Remove invocations of doprnt, as Emacs now uses vsnprintf.
420 But keep the doprint source code for now, as we might revamp it
421 and use it again (Bug#8435).
ea6c7ae6
PE
422 * lisp.h (doprnt): Remove.
423 * Makefile.in (base_obj): Remove doprnt.o.
424 * deps.mk (doprnt.o): Remove.
425
5fdb398c
PE
426 error: Print 32- and 64-bit integers portably (Bug#8435).
427 Without this change, on typical 64-bit hosts error ("...%d...", N)
428 was used to print both 32- and 64-bit integers N, which relied on
429 undefined behavior.
430 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
431 New macro.
432 * lisp.h (error, verror): Mark as printf-like functions.
433 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
434 Report overflow in size calculations when allocating printf buffer.
435 Do not truncate output string at its first null byte.
436 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
437 Truncate the output at a character boundary, since vsnprintf does not
438 do that.
439 * charset.c (check_iso_charset_parameter): Convert internal
440 character to string before calling 'error', since %c now has the
441 printf meaning.
442 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
443 overflow when computing char to be passed to 'error'. Do not
444 pass Lisp_Object to 'error'; pass the integer instead.
445 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
446 formatted with plain %d.
447
b189fa66
PE
448 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
449
bff87ef0
PE
450 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
451
7e2cac20
PE
452 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
453
ce4d90b5
PE
454 * xterm.c (x_catch_errors): Remove duplicate declaration.
455
266c9547
PE
456 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
457
79c49ad2
PE
458 * xdisp.c, lisp.h (message_nolog): Remove; unused.
459
368f4090
JM
4602011-04-10 Jim Meyering <meyering@redhat.com>
461
462 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
463 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
464 return ssize_t not "int", and use size_t as the buffer length.
465 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
466 * gnutls.h: Update declarations.
467 * process.c (read_process_output): Use ssize_t, to match.
468 (send_process): Likewise.
469
a32d4040
CY
4702011-04-09 Chong Yidong <cyd@stupidchicken.com>
471
472 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
473
8546720e 4742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 475
8546720e
GM
476 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
477 unsigned char, to match FcChar8 type definition.
aac0c6e3 478
8546720e
GM
479 * xterm.c (handle_one_xevent):
480 * xmenu.c (create_and_show_popup_menu):
481 * xselect.c (x_decline_selection_request)
482 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 483
a53e2e89
EZ
4842011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
485
486 Fix some uses of `int' instead of EMACS_INT.
487 * search.c (string_match_1, fast_string_match)
488 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
489 (scan_buffer, find_next_newline_no_quit)
490 (find_before_next_newline, search_command, Freplace_match)
491 (Fmatch_data): Make some `int' variables be EMACS_INT.
492
493 * xdisp.c (display_count_lines): 3rd argument and return value now
494 EMACS_INT. All callers changed.
495 (pint2hrstr): Last argument is now EMACS_INT.
496
497 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
498 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
499 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
500 (decode_coding_utf_16, decode_coding_emacs_mule)
501 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
502 (decode_coding_ccl, decode_coding_charset)
503 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
504 (decode_coding_iso_2022, decode_coding_emacs_mule)
505 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
506 <char_offset, last_offset>: Declare EMACS_INT.
507 (encode_coding_utf_8, encode_coding_utf_16)
508 (encode_coding_emacs_mule, encode_invocation_designation)
509 (encode_designation_at_bol, encode_coding_iso_2022)
510 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
511 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
512 Declare EMACS_INT.
513 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
514 (encode_invocation_designation): Last argument P_NCHARS is now
515 EMACS_INT.
516 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
517 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
518
519 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
520 All users changed.
521
522 * ccl.c (Fccl_execute_on_string): Declare some variables
523 EMACS_INT.
524
8546720e 5252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
526
527 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
528
4e19a977
CS
5292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
530
531 * process.c (Fformat_network_address): Doc fix.
532
87302331
R
5332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
534
535 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
536
cbb59342
CY
5372011-04-08 Chong Yidong <cyd@stupidchicken.com>
538
539 * keyboard.c (read_char): Call Lisp function help-form-show,
540 instead of using internal_with_output_to_temp_buffer.
541 (Qhelp_form_show): New var.
e0d38eeb 542 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
543
544 * print.c (internal_with_output_to_temp_buffer): Function deleted.
545
546 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
547
e67a13ab
CY
5482011-04-06 Chong Yidong <cyd@stupidchicken.com>
549
550 * process.c (Flist_processes): Removed to Lisp.
551 (list_processes_1): Deleted.
552
973f782d
EZ
5532011-04-06 Eli Zaretskii <eliz@gnu.org>
554
7c106b1e
EZ
555 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
556
973f782d
EZ
557 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
558
41cf7d1a 5592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 560
ca23cc88
PE
561 Fix more problems found by GCC 4.6.0's static checks.
562
f390e2d5
PE
563 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
564
42eea0d0
PE
565 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
566
b69769da 567 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 568
f9541e84
PE
569 * xdisp.c (vmessage): Mark as a printf-like function.
570
13841b55
PE
571 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
572
c136c10f
PE
573 * sound.c (sound_warning): Don't crash if arg contains a printf format.
574
5e2d4a30
PE
575 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
576 printf-like functions.
577 (tiff_load): Add casts to remove these marks before passing them
578 to system-supplied API.
579
583f48b9
PE
580 * eval.c (Fsignal): Remove excess argument to 'fatal'.
581
b25d760e
PE
582 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
583 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
584 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
585 directly, rather than having caller test rule sign. This avoids
586 some unnecessary tests.
587 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
588 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
589 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 590
bc7b6697 591 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 592 (xfont_open): Avoid unnecessary tests.
bc7b6697 593
27ccc379
PE
594 * composite.c (composition_gstring_put_cache): Use unsigned integer.
595
dcd5c89a
PE
596 * composite.h, composite.c (composition_gstring_put_cache):
597 Use EMACS_INT, not int, for length.
598
b13a45c6
PE
599 * composite.h (COMPOSITION_DECODE_REFS): New macro,
600 breaking out part of COMPOSITION_DECODE_RULE.
601 (COMPOSITION_DECODE_RULE): Use it.
602 * composite.c (get_composition_id): Remove unused local vars,
603 by using the new macro.
604
1e792e4d
PE
605 * textprop.c (set_text_properties_1): Change while to do-while,
606 since the condition is always true at first.
607
dc6c6455 608 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
609 (interval_deletion_adjustment): Return unsigned value.
610 All uses changed.
dc6c6455 611
aba7731a
PE
612 * process.c (list_processes_1, create_pty, read_process_output):
613 (exec_sentinel): Remove vars that were set but not used.
afd4052b 614 (create_pty): Remove unnecessary "volatile"s.
bc57d757 615 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 616 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 617 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 618
fdfc4bf3
PE
619 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
620
fca8fe46 621 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 622 (update_syntax_table): Use unsigned instead of int.
fca8fe46 623
06a0259a 624 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 625 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 626 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 627
e7b9e80f
PE
628 * print.c (print_error_message): Avoid int overflow.
629
56201685
PE
630 * font.c (font_list_entities): Redo for clarity,
631 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
632
78834453 633 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 634 (font_score): Avoid potential overflow in diff calculation.
78834453 635
0bc0b309 636 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 637 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 638
e610eaca
PE
639 * eval.c (funcall_lambda): Rename local to avoid shadowing.
640
b895abce
PE
641 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
642 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
643 can always succeed if overflow has undefined behavior.
644
1f1d9321 645 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 646 (wordify): Omit three unnecessary tests.
1f1d9321 647
c59478bc
PE
648 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
649 All callers changed. This avoids the need for an unused var.
650
79b73827
PE
651 * casefiddle.c (casify_region): Remove var that is set but not used.
652
a4db5dfe
PE
653 * dired.c (file_name_completion): Remove var that is set but not used.
654
43aae36e
PE
655 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
656
2a47c44d 657 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 658 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 659
a37c69bf
PE
660 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
661 Check for integer overflow on size calculations.
662
328ab8e7
PE
663 * buffer.c (Fprevious_overlay_change): Remove var that is set
664 but not used.
665
e5a2a5cb
PE
666 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
667 Remove vars that are set but not used.
8d84a6eb 668 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 669 (timer_check_2): Mark vars as initialized.
e5a2a5cb 670
a60e5f68
PE
671 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
672
f661cb61 673 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 674 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 675
f0397f5a
PE
676 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
677 that are set but not used.
678
8664db06 679 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 680 if XCreateBitmapFromData fails (Bug#8410).
8664db06 681
6abdaa4a
PE
682 * xselect.c (x_get_local_selection, x_handle_property_notify):
683 Remove vars that are set but not used.
684
0ce7538d 685 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 686 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 687
9ae848fc
PE
688 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
689 Remove var that is set but not used.
0b918413
PE
690 (scroll_bar_windows_size): Now size_t, not int.
691 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
692 Check for overflow.
9ae848fc 693
a5a62657
PE
694 * xfaces.c (realize_named_face): Remove vars that are set but not used.
695 (map_tty_color) [!defined MSDOS]: Likewise.
696
5c5cdd39
PE
697 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
698
66ebf983
PE
699 * coding.c: Remove vars that are set but not used.
700 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
701 All callers changed.
702 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
703 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
704 (decode_coding_charset): Remove vars that are set but not used.
705
1be4d761
PE
706 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
707 that is set but not used.
708
47553fa8
PE
709 * print.c (print_object): Remove var that is set but not used.
710
1f7196bf 711 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
712 The gnulib version avoids calling malloc in the usual case,
713 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
714 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
715 * filelock.c (current_lock_owner): Likewise.
716 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
717 * sysdep.c: Include allocator.h, careadlinkat.h.
718 (emacs_no_realloc_allocator): New static constant.
719 (emacs_readlink): New function.
fdb61804
PE
720 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
721 ../lib/careadlinkat.h.
d1fdcab7 722
f84c17c7
SM
7232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
724
725 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
726 first non-nil return value).
727
ef3862ad
JD
7282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
729
730 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
731 if not defined (Bug#8403).
732
376a7006
JB
7332011-04-02 Juanma Barranquero <lekktu@gmail.com>
734
735 * xdisp.c (display_count_lines): Remove parameter `start',
736 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
737 (get_char_face_and_encoding): Remove parameter `multibyte_p',
738 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
739 (fill_stretch_glyph_string): Remove parameters `row' and `area',
740 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
741 and thereabouts. All callers changed.
742 (get_per_char_metric): Remove parameter `f', unused since
743 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
744
6ca3801d
JM
7452011-04-02 Jim Meyering <meyering@redhat.com>
746
747 do not dereference NULL upon failed strdup
748 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
749 (ns_get_family): Likewise.
750
d8e2b5ba
JB
7512011-04-02 Juanma Barranquero <lekktu@gmail.com>
752
753 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
754
8c74fcbd
JD
7552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
756
757 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
758 later (Bug#8403).
759
7200d79c
SM
7602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
761
03408648 762 Add lexical binding.
7200d79c 763
03408648
SM
764 * window.c (Ftemp_output_buffer_show): New fun.
765 (Fsave_window_excursion):
766 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
767
768 * lread.c (lisp_file_lexically_bound_p): New function.
769 (Fload): Bind Qlexical_binding.
770 (readevalloop): Remove `evalfun' arg.
771 Bind Qinternal_interpreter_environment.
772 (Feval_buffer): Bind Qlexical_binding.
773 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
774 Mark as dynamic.
775 (syms_of_lread): Declare `lexical-binding'.
776
777 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
778
779 * keyboard.c (eval_dyn): New fun.
780 (menu_item_eval_property): Use it.
ca105506
SM
781
782 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 783
03408648
SM
784 * fns.c (concat, mapcar1): Accept byte-code-functions.
785
786 * eval.c (Fsetq): Handle lexical vars.
787 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
788 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
789 (FletX, Flet): Obey lexical binding.
790 (Fcommandp): Handle closures.
791 (Feval): New `lexical' arg.
792 (eval_sub): New function extracted from Feval. Use it almost
793 everywhere where Feval was used. Look up vars in lexical env.
794 Handle closures.
795 (Ffunctionp): Move from subr.el.
796 (Ffuncall): Handle closures.
797 (apply_lambda): Remove `eval_flags'.
798 (funcall_lambda): Handle closures and new byte-code-functions.
799 (Fspecial_variable_p): New function.
800 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
801 but without exporting it to Lisp.
23aba0ea 802
23aba0ea 803 * doc.c (Fdocumentation, store_function_docstring):
03408648 804 * data.c (Finteractive_form): Handle closures.
23aba0ea 805
03408648
SM
806 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
807 interactive spec.
ba83908c 808
03408648
SM
809 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
810 byte-codes.
811 (exec_byte_code): New function extracted from Fbyte_code to handle new
812 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 813
03408648 814 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 815
03408648 816 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 817
e2abce01
JB
8182011-03-31 Juanma Barranquero <lekktu@gmail.com>
819
820 * xdisp.c (redisplay_internal): Fix prototype.
821
63696a73 8222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 823
63696a73
EZ
824 * xdisp.c (SCROLL_LIMIT): New macro.
825 (try_scrolling): Use it when setting scroll_limit. Limit
826 scrolling to 100 screen lines.
827 (redisplay_window): Even when falling back on "recentering",
828 position point in the window according to scroll-conservatively,
829 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
830
831 (try_scrolling): When point is above the window, allow searching
832 as far as scroll_max, or one screenful, to compute vertical
833 distance from PT to the scroll margin position. This prevents
834 try_scrolling from unnecessarily failing when
835 scroll-conservatively is set to a value slightly larger than the
836 window height. Clean up the case of PT below the margin at bottom
837 of window: scroll_max can no longer be INT_MAX. When aggressive
838 scrolling is in use, don't let point enter the opposite scroll
839 margin as result of the scroll.
840 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
841 threshold of 100 lines for never-recentering scrolling.
842
e4cc2dfc
JB
8432011-03-31 Juanma Barranquero <lekktu@gmail.com>
844
845 * dispextern.h (move_it_by_lines):
846 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
847 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
848 (message_log_check_duplicate): Remove parameters `prev_bol' and
849 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
850 (redisplay_internal): Remove parameter `preserve_echo_area',
851 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
852
853 * indent.c (Fvertical_motion):
854 * window.c (window_scroll_pixel_based, Frecenter):
855 Don't pass `need_y_p' to `move_it_by_lines'.
856
1c470562
SM
8572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
858
44f230aa
SM
859 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
860 steal a few bits to be more compact.
861 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
862 Remove unneeded casts.
863
1c470562
SM
864 * bytecode.c (Fbyte_code): CAR and CDR can GC.
865
888adce9
ZK
8662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
867
868 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
869 binding" message (bug#7967).
870
f838ed7b
PE
8712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
872
77861b95
PE
873 Fix more problems found by GCC 4.6.0's static checks.
874
de6dbc14
PE
875 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
876 Remove unused local var.
877
f838ed7b
PE
878 * editfns.c (Fmessage_box): Remove unused local var.
879
792c7b2b
PE
880 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
881 (note_mode_line_or_margin_highlight, note_mouse_highlight):
882 Omit unused local vars.
c499e557 883 * window.c (shrink_windows): Omit unused local var.
b01a1c29 884 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
885 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
886 Omit unused local var.
887
ba0165e1
PE
888 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
889 Don't assume string length fits in int.
32ad8845 890 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 891 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 892
3c59b4c9
PE
893 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
894 instead of alloca (Bug#8344).
895
a3eed478 896 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 897 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 898
eb4d412d
PE
899 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
900
1658b401
PE
901 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
902 concerns.
903
904 * term.c (produce_glyphless_glyph): Remove unnecessary test.
905
906 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 907
9a2c6e05
PE
908 * keyboard.c (syms_of_keyboard): Use the same style as later
909 in this function when indexing through an array. This also
910 works around GCC bug 48267.
911
03d0a109
PE
912 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
913
44f730c8
PE
914 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
915
fe75f926
PE
916 * chartab.c (sub_char_table_ref_and_range): Redo for slight
917 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
918
ffa8c828
PE
919 * keyboard.c, keyboard.h (num_input_events): Now size_t.
920 This avoids undefined behavior on integer overflow, and is a bit
921 more convenient anyway since it is compared to a size_t variable.
922
c5101a77
PE
923 Variadic C functions now count arguments with size_t, not int.
924 This avoids an unnecessary limitation on 64-bit machines, which
925 caused (substring ...) to crash on large vectors (Bug#8344).
926 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
927 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 928 All variadic functions and their callers changed accordingly.
c5101a77
PE
929 (struct gcpro.nvars): Now size_t, not int. All uses changed.
930 * data.c (arith_driver, float_arith_driver): Likewise.
931 * editfns.c (general_insert_function): Likewise.
932 * eval.c (struct backtrace.nargs, interactive_p)
933 (internal_condition_case_n, run_hook_with_args, apply_lambda)
934 (funcall_lambda, mark_backtrace): Likewise.
935 * fns.c (concat): Likewise.
936 * frame.c (x_set_frame_parameters): Likewise.
937 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
938 0 if not found, not -1. All callers changed.
939
dd3f25f7
PE
940 * alloc.c (garbage_collect): Don't assume stack size fits in int.
941 (stack_copy_size): Now size_t, not int.
942 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
943
461c2ab9
JB
9442011-03-28 Juanma Barranquero <lekktu@gmail.com>
945
946 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
947 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
948 All callers changed.
949
950 * lisp.h (multibyte_char_to_unibyte):
951 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
952 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
953 * character.h (CHAR_TO_BYTE8):
954 * cmds.c (internal_self_insert):
955 * editfns.c (general_insert_function):
956 * keymap.c (push_key_description):
957 * search.c (Freplace_match):
958 * xdisp.c (message_dolog, set_message_1): All callers changed.
959
f6d62986
SM
9602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
961
962 * keyboard.c (safe_run_hook_funcall): New function.
963 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
964 don't set the hook to nil, but remove the offending function instead.
965 (Qcommand_hook_internal): Remove, unused.
966 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
967 Vcommand_hook_internal.
968
969 * eval.c (enum run_hooks_condition): Remove.
970 (funcall_nil, funcall_not): New functions.
971 (run_hook_with_args): Call each function through a `funcall' argument.
972 Remove `cond' argument, now redundant.
973 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
974 (Frun_hook_with_args_until_failure): Adjust accordingly.
975 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
976
1db5b1ad
JB
9772011-03-28 Juanma Barranquero <lekktu@gmail.com>
978
979 * dispextern.h (string_buffer_position): Remove declaration.
980
981 * print.c (strout): Remove parameter `multibyte', unused since
982 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
983
984 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
985 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
986 All callers changed.
987
988 * w32.c (_wsa_errlist): Use braces for struct initializers.
989
990 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
991 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
992 All callers changed.
993 (string_buffer_position): Likewise. Also, make static (it's never
994 used outside xdisp.c).
995 (cursor_row_p): Remove parameter `w', unused since
996 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
997 (decode_mode_spec): Remove parameter `precision', introduced during
998 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
999 All callers changed.
1000
5ffb62aa
JD
10012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1002
1003 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1004
461c2ab9 10052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1006
1007 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1008 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1009 (ns_update_auto_hide_menu_bar): New functions.
1010 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1011 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1012 ns_constrain_all_frames.
1013 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1014 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1015
5c380ffb
JD
10162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1017
1018 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1019
9af30bdf
GM
10202011-03-27 Glenn Morris <rgm@gnu.org>
1021
1022 * syssignal.h: Replace RETSIGTYPE with void.
1023 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1024 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1025 Replace SIGTYPE with void everywhere.
1026 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1027 * s/template.h (SIGTYPE): Remove commented out definition.
1028
e2abce01
JB
10292011-03-26 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1032 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1033
f868cd8a
JB
10342011-03-26 Juanma Barranquero <lekktu@gmail.com>
1035
59eb0929
JB
1036 * w32.c (read_unc_volume): Use parameter `henum', instead of
1037 global variable `wget_enum_handle'.
1038
1039 * keymap.c (describe_vector): Remove parameters `indices' and
1040 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1041 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1042
f868cd8a
JB
1043 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1044
1045 * keyboard.c (timer_check): Remove parameter `do_it_now',
1046 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1047 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1048 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1049
1050 * keyboard.c (read_char):
1051 * w32menu.c (w32_menu_display_help):
1052 * xmenu.c (show_help_event, menu_help_callback):
1053 Adjust calls to `show_help_echo'.
1054
1055 * gtkutil.c (xg_maybe_add_timer):
1056 * keyboard.c (readable_events):
1057 * process.c (wait_reading_process_output):
1058 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1059
1060 * insdel.c (adjust_markers_gap_motion):
1061 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1062 (gap_left, gap_right): Don't call it.
1063
2ecf6fdb
CY
10642011-03-25 Chong Yidong <cyd@stupidchicken.com>
1065
1066 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1067 incurred during fontification.
1068
6b1f9ba4
JB
10692011-03-25 Juanma Barranquero <lekktu@gmail.com>
1070
1071 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1072 (DEFVAR_PER_BUFFER): Don't pass it.
1073
1074 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1075 (scrolling_window): Don't pass it.
1076
0f4a96b5
JB
10772011-03-25 Juanma Barranquero <lekktu@gmail.com>
1078
1079 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1080
1081 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1082 and `suffix'.
1083 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1084 of variables specific to SELinux and computation of `encoded_absname'.
1085
1086 * image.c (XPutPixel): Remove unused variable `height'.
1087
1088 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1089
1090 * unexw32.c (get_section_info): Remove unused variable `section'.
1091
1092 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1093 (system_process_attributes): Remove unused variable `sess'.
1094 (sys_read): Remove unused variable `err'.
1095
1096 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1097 (w32_wnd_proc): Remove unused variable `isdead'.
1098 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1099 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1100 (x_create_tip_frame): Remove unused variable `tem'.
1101
1102 * w32inevt.c (w32_console_read_socket):
1103 Remove unused variable `no_events'.
1104
1105 * w32term.c (x_draw_composite_glyph_string_foreground):
1106 Remove unused variable `width'.
1107
1149507c
JB
11082011-03-24 Juanma Barranquero <lekktu@gmail.com>
1109
1110 * w32term.c (x_set_glyph_string_clipping):
1111 Don't pass uninitialized region to CombineRgn.
1112
9c88f339
JB
11132011-03-23 Juanma Barranquero <lekktu@gmail.com>
1114
1115 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1116 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1117 (Fx_close_connection): Remove unused variable `i'.
1118
1119 * w32font.c (w32font_draw): Return number of glyphs.
1120 (w32font_open_internal): Remove unused variable `i'.
1121 (w32font_driver): Add missing initializer.
1122
1123 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1124 (fill_in_menu): Remove unused variable `items_added'.
1125
1126 * w32term.c (last_mouse_press_frame): Remove static global variable.
1127 (w32_clip_to_row): Remove unused variable `f'.
1128 (x_delete_terminal): Remove unused variable `i'.
1129
1130 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1131 (NOTHING): Remove unused static global variable.
1132 (uniscribe_check_otf): Remove unused variable `table'.
1133 (uniscribe_font_driver): Add missing initializers.
1134
dee091a3
JD
11352011-03-23 Julien Danjou <julien@danjou.info>
1136
1137 * term.c (Fsuspend_tty, Fresume_tty):
1138 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1139 * window.c (temp_output_buffer_show):
1140 * insdel.c (signal_before_change):
1141 * frame.c (Fhandle_switch_frame):
1142 * fileio.c (Fdo_auto_save):
1143 * emacs.c (Fkill_emacs):
1144 * editfns.c (save_excursion_restore):
1145 * cmds.c (internal_self_insert):
1146 * callint.c (Fcall_interactively):
1147 * buffer.c (Fkill_all_local_variables):
1148 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1149 Use Frun_hooks.
0f4a96b5 1150 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1151 unconditionnaly since it does the check itself.
1152
2c520ab5 11532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1154
c9c49752
PE
1155 Fix more problems found by GCC 4.5.2's static checks.
1156
8abc3f12
PE
1157 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1158 the first time through the loop, since we know p0 < p1 then.
1159 This also avoids a gcc -Wstrict-overflow warning.
1160
a2d26660
PE
1161 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1162 leading to a memory leak, possible in functions like
1163 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1164 of objects (Bug#8318).
a2d26660 1165
916c72e9
PE
1166 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1167 that could (at least in theory) be that large.
1168
19ab8a18
PE
1169 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1170 This is less likely to overflow, and avoids undefined behavior if
1171 overflow does occur. All callers changed. Use strtoul to scan
1172 for the unsigned long integer.
b7cbbd6f
PE
1173 (pint2hrstr): Simplify and tune code slightly.
1174 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1175
f0641eff
PE
1176 * scroll.c (do_scrolling): Work around GCC bug 48228.
1177 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1178
7f650bb9
PE
1179 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1180 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1181 (validate_x_resource_name): Simplify count usage.
1182 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1183
37dd57d1
PE
1184 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1185 fail (Bug#8306).
81e56e61 1186
699979fc 1187 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1188
401bf9b4
PE
1189 * process.c (Fmake_network_process): Use socklen_t, not int,
1190 where POSIX says socklen_t is required in portable programs.
1191 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1192 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1193 (Fmake_network_process, server_accept_connection):
1194 (wait_reading_process_output, read_process_output):
1195 Likewise.
1196
b93aacde
PE
1197 * process.c: Rename or move locals to avoid shadowing.
1198 (list_processes_1, Fmake_network_process):
1199 (read_process_output_error_handler, exec_sentinel_error_handler):
1200 Rename or move locals.
4dc343ee 1201 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1202 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1203 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1204 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1205 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1206
af8a867c 1207 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1208 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1209 Include tparam.h instead, since it declares them.
af8a867c
PE
1210 * cm.h (PC): Remove extern decl; tparam.h now does this.
1211 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1212 * terminfo.c: Include tparam.h, to check interfaces.
1213 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1214 (tparam): Adjust signature to match interface in tparam.h;
1215 this removes some undefined behavior. Check that outstring and len
1216 are zero, which they always are with Emacs.
1217 * tparam.h (PC, BC, UP): New extern decls.
1218
0248044d 1219 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1220 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1221
8ff096c1 1222 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1223 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1224 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1225 (ftfont_list): Remove unused local.
49eaafba
PE
1226 (get_adstyle_property, ftfont_pattern_entity):
1227 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1228 Rename locals to avoid shadowing.
8ff096c1 1229
e2be39f6
PE
1230 * xfont.c (xfont_list_family): Mark var as initialized.
1231
c9735e30
PE
1232 * xml.c (make_dom): Now static.
1233
8f5201ae
PE
1234 * composite.c (composition_compute_stop_pos): Rename local to
1235 avoid shadowing.
b246f932
PE
1236 (composition_reseat_it): Remove unused locals.
1237 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1238 (composition_update_it): Mark var as initialized.
11b61122
PE
1239 (find_automatic_composition): Mark vars as initialized,
1240 with a FIXME (Bug#8290).
8f5201ae 1241
760fbc2c
PE
1242 character.h: Rename locals to avoid shadowing.
1243 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1244 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1245 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1246 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1247 to avoid shadowing.
1248
ff08eb85
PE
1249 * textprop.c (property_change_between_p): Remove; unused.
1250
fc7bf025
PE
1251 * intervals.c (interval_start_pos): Now static.
1252
235d7abc
PE
1253 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1254
44f230aa
SM
1255 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1256 Rename locals to avoid shadowing.
3e7d6594 1257
50060332
PE
1258 * sound.c (wav_play, au_play, Fplay_sound_internal):
1259 Fix pointer signedness.
d01f234b 1260 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1261 (wav_play): Initialize a variable to 0, to prevent undefined
1262 behavior (Bug#8278).
50060332 1263
c4fc4e30
PE
1264 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1265
918436ed
PE
1266 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1267
c939f91b
PE
1268 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1269 clobbering (Bug#8298).
b9c7f648
PE
1270 * sysdep.c (sys_subshell): Likewise.
1271 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1272
6bd8c144
PE
1273 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1274 This should get cleaned up, so that child_setup has the
1275 same signature on all platforms.
1276
7710357c 1277 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1278 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1279
c59da222
CY
12802011-03-22 Chong Yidong <cyd@stupidchicken.com>
1281
1282 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1283 not to be necessary, and produces flickering.
1284
66b87493
GM
12852011-03-20 Glenn Morris <rgm@gnu.org>
1286
1287 * config.in: Remove file.
1288
45b6f6d5
JB
12892011-03-20 Juanma Barranquero <lekktu@gmail.com>
1290
1291 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1292 are now in src/globals.h.
1293 (syms_of_minibuf): Remove spurious & from previous change.
1294
3ec03f7e
LL
12952011-03-20 Leo <sdl.web@gmail.com>
1296
1297 * minibuf.c (completing-read-function): New variable.
1298 (completing-read-default): Rename from completing-read.
1299 (completing-read): Call completing-read-function.
1300
b14e3e21
CY
13012011-03-19 Juanma Barranquero <lekktu@gmail.com>
1302
1303 * xfaces.c (Fx_load_color_file):
1304 Read color file from absolute filename (bug#8250).
1305
f2b726e6
JB
13062011-03-19 Juanma Barranquero <lekktu@gmail.com>
1307
1308 * makefile.w32-in: Update dependencies.
1309
09f6ff02
EZ
13102011-03-17 Eli Zaretskii <eliz@gnu.org>
1311
1312 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1313
29a6015a
PE
13142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1315
a3a6c54e
PE
1316 Fix more problems found by GCC 4.5.2's static checks.
1317
b766f867
PE
1318 * process.c (make_serial_process_unwind, send_process_trap):
1319 (sigchld_handler): Now static.
1320
be02381c
PE
1321 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1322 That way, the code declares only the vars that it needs.
1323 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1324 * s/cygwin.h (PTY_ITERATION): Likewise.
1325 * s/darwin.h (PTY_ITERATION): Likewise.
1326 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1327
57048744
PE
1328 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1329 * process.c (allocate_pty): Don't declare stb unless it's needed.
1330
7914961c 1331 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1332 (CONSTANTLIM): Remove; unused.
1333 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1334 Define only if needed.
7914961c 1335
b3967b18
PE
1336 * unexelf.c (unexec): Name an expression,
1337 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1338 Use a different way to cause a compilation error if anyone uses
1339 n rather than nn, a way that does not involve shadowing.
73366a00 1340 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1341
29a6015a
PE
1342 * deps.mk (unexalpha.o): Remove; unused.
1343
43cfc33e 1344 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1345 * unexec.h: New file.
ce701a33
PE
1346 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1347 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1348 Depend on unexec.h.
1349 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1350 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1351 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1352 Change as necessary to match prototype in unexec.h.
ce701a33 1353
01f44d5a
PE
1354 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1355 shadowing.
4f63c6bb 1356 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1357
a6670b0b
PE
1358 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1359 Rename locals to avoid shadowing.
1360
cef2010d 1361 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1362 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1363
d4d7173a
PE
1364 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1365
f08b802a
PE
1366 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1367 warning when compiling print.c.
1368
3ddb0639
PE
1369 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1370 instead of using an uninitialized var.
5ad03b97 1371 (font_sort_entities): Mark var as initialized.
3ddb0639 1372
170a2692
PE
1373 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1374
e663c700
PE
1375 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1376 pointers to constants.
89bc529a 1377 (font_parse_fcname): Remove unused vars.
7b81e2d0 1378 (font_delete_unmatched): Now static.
ea838e10 1379 (font_get_spec): Remove; unused.
13a547c6
PE
1380 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1381 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1382 Rename or move locals to avoid shadowing.
e663c700 1383
2a80c887 1384 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1385 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1386
1384fa33 1387 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1388 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1389
8b2c52e9
PE
1390 * alloc.c (mark_backtrace): Move decl from here ...
1391 * lisp.h: ... to here, so that it can be checked.
1392
475545b5 1393 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1394 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1395 (lisp_indirect_variable): Name an expression,
1396 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1397 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1398
b1349114 1399 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1400 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1401 Use const pointer when appropriate.
b1349114 1402
a2928364
PE
1403 * lisp.h (get_system_name, get_operating_system_release):
1404 Move decls here, to check interfaces.
1405 * process.c (get_operating_system_release): Move decl to lisp.h.
1406 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1407 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1408 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1409 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1410 (Fformat_time_string, Fencode_time, Finsert_char):
1411 (Ftranslate_region_internal, Fformat):
1412 Rename or remove local vars to avoid shadowing.
9710023e 1413 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1414
a415e694
PE
1415 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1416 avoid shadowing.
1417
8ef4622d
PE
1418 * lisp.h (eassert): Check that the argument compiles, even if
1419 ENABLE_CHECKING is not defined.
1420
946f9a5b
PE
1421 * data.c (Findirect_variable): Name an expression, to avoid
1422 gcc -Wbad-function-cast warning.
112396d6 1423 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1424 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1425 (Fmake_variable_buffer_local, Fmake_local_variable):
1426 Mark variables as initialized.
52746918 1427 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1428
e5aab7e7 1429 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1430 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1431 Rename locals to avoid shadowing.
dff45157
PE
1432 (mark_stack): Move local variables into the #ifdef region where
1433 they're used.
7bc26fdb
PE
1434 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1435 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1436 needed otherwise.
1437 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1438 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1439 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1440
e5aab7e7
PE
1441 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1442 avoids undefined behavior in theory.
1443
4da60324
PE
1444 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1445
88043301
PE
1446 Use functions, not macros, for up- and down-casing (Bug#8254).
1447 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1448 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1449 to use the following functions instead of these macros.
1450 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1451 EMACS_INT, since callers assume the returned value fits in int.
1452 (upcase1): Likewise, for UPCASE_TABLE.
1453 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1454 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1455 the race-condition problem in the old DOWNCASE.
88043301 1456
19ed5445
PE
1457 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1458 Rename locals to avoid shadowing.
1459 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1460 (regex_compile, re_search_2, re_match_2_internal):
1461 Remove unused local vars.
952db0d7
PE
1462 (FREE_VAR): Rewrite so as not to use empty "else",
1463 which gcc can warn about.
da053e48 1464 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1465 (RETALLOC_IF): Define only if needed.
1466 (WORDCHAR_P): Likewise. This one is never needed, but is used
1467 only in a comment talking about a compiler bug, so put inside
1468 the #if 0 of that comment.
1469 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1470 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1471 Remove; unused.
19ed5445 1472
1f3561e4 1473 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1474 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1475 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1476
ded6f8f7
PE
1477 * search.c (simple_search): Remove unused var.
1478
dbd37a95
PE
1479 * dired.c (compile_pattern): Move decl from here ...
1480 * lisp.h: ... to here, so that it can be checked.
1481 (struct re_registers): New forward decl.
1482
7e47afad
PE
1483 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1484
85f24f61
PE
1485 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1486 All uses changed.
1487 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1488 Rename locals to avoid shadowing.
5671df8f 1489 (Fvertical_motion): Mark locals as initialized.
85f24f61 1490
181aa2be 1491 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1492 (casify_region): Mark local as initialized.
181aa2be 1493
930d429c
PE
1494 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1495
7082eac6
PE
1496 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1497 New macros, so that the caller can use some names other than
1498 gcpro1, gcpro2, etc.
1499 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1500 of the new macros.
1501 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1502 argument, for consistency with GCPRO2_VAR, etc: it is now the
1503 prefix of the variable, not the variable itself. All uses
1504 changed.
38b2c076
PE
1505 * dired.c (directory_files_internal, file_name_completion):
1506 Rename locals to avoid shadowing.
1507
15206ed9
PE
1508 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1509 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1510 dired.c's scmp function, had undefined behavior.
1511 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1512 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1513 * buffer.h: ... to here, because these macros use current_buffer,
1514 and the new implementation with inline functions needs to have
1515 current_buffer in scope now, rather than later when the macros
1516 are used.
1517 (downcase, upcase1): New static inline functions.
1518 (DOWNCASE, UPCASE1): Reimplement using these functions.
1519 This avoids undefined behavior in expressions like
1520 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1521 from race conditions in accessing the global variables
1522 case_temp1 and case_temp2.
1523 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1524 * lisp.h (case_temp1, case_temp2): Remove their decls.
1525 * character.h (ASCII_CHAR_P): Move from here ...
1526 * lisp.h: ... to here, so that the inline functions mentioned
1527 above can use them.
1528
4a6bea26
PE
1529 * dired.c (directory_files_internal_unwind): Now static.
1530
f14b7e14
PE
1531 * fileio.c (file_name_as_directory, directory_file_name):
1532 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1533 Now static.
2893f146
PE
1534 (file_name_as_directory): Use const pointers when appropriate.
1535 (Fexpand_file_name): Likewise. In particular, newdir might
1536 point at constant storage, so make it a const pointer.
fd4ead52 1537 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1538 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1539 signedness issues.
f839df0c
PE
1540 (Fset_file_times, Finsert_file_contents, auto_save_error):
1541 Rename locals to avoid shadowing.
f14b7e14 1542
5716756e 1543 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1544 (Ftry_completion, Fall_completions): Rename or remove locals
1545 to avoid shadowing.
5716756e 1546
b4c3046a
PE
1547 * marker.c (bytepos_to_charpos): Remove; unused.
1548
b45db522
PE
1549 * lisp.h (verify_bytepos, count_markers): New decls,
1550 so that gcc does not warn that these functions aren't declared.
1551
85876d07
PE
1552 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1553 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1554 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1555 (copy_text): Remove unused local var.
85876d07 1556
03d78a21 1557 * filelock.c (within_one_second): Now static.
b3dd38ab 1558 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1559
5df8f01b
PE
1560 * buffer.c (fix_overlays_before): Mark locals as initialized.
1561 (fix_start_end_in_overlays): Likewise. This function should be
1562 simplified by using pointers-to-pointers, but that's a different
1563 matter.
b1d876f1 1564 (switch_to_buffer_1): Now static.
8f54f30a
PE
1565 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1566 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1567
a70072c9 1568 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1569 Fix pointer signedness issue.
edced198
PE
1570 (sys_subshell): Mark local as volatile if checking for lint,
1571 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1572 (MAXPATHLEN): Define only if needed.
a70072c9 1573
a0977c44
PE
1574 * process.c (serial_open, serial_configure): Move decls from here ...
1575 * systty.h: ... to here, so that they can be checked.
1576
a884fdcc
PE
1577 * fns.c (get_random, seed_random): Move extern decls from here ...
1578 * lisp.h: ... to here, so that they can be checked.
1579
604efe86 1580 * sysdep.c (reset_io): Now static.
b8950c94 1581 (wait_for_termination_signal): Remove; unused.
604efe86 1582
38fc62d9
PE
1583 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1584 (copy_keymap_item, append_key, push_text_char_description):
1585 Now static.
1004a21a 1586 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1587 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1588 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1589 (describe_map_tree):
1590 Rename locals to avoid shadowing.
38fc62d9 1591
2f2650da
PE
1592 * keyboard.c: Declare functions static if they are not used elsewhere.
1593 (echo_char, echo_dash, cmd_error, top_level_2):
1594 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1595 (read_char, kbd_buffer_get_event, make_lispy_position):
1596 (make_lispy_event, make_lispy_movement, apply_modifiers):
1597 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1598 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1599 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1600 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1601 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1602
a053e86c 1603 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1604 (mark_kboards): Move decl here ...
1605 * alloc.c (mark_kboards): ... from here.
a053e86c 1606
4752793e
PE
1607 * lisp.h (force_auto_save_soon): New decl.
1608
74f10ca7 1609 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1610 (DEFINE_DUMMY_FUNCTION): New macro.
1611 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1612 Use it.
c03cd23f
PE
1613 (main): Add casts to avoid warnings
1614 if GCC considers string literals to be constants.
74f10ca7 1615
022e70d4
PE
1616 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1617
59d6fe83
PE
1618 * dbusbind.c: Pointer signedness fixes.
1619 (xd_signature, xd_append_arg, xd_initialize):
1620 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1621 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1622 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1623 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1624
78320123
PE
1625 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1626 if GCC considers string literals to be constants.
49cebcca 1627 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1628
35ac2a97
SM
16292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1630
fb103ca9
SM
1631 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1632 (print_preprocess, print_object): New macro to fix last change.
1633
35ac2a97
SM
1634 * print.c (print_preprocess): Don't forget font objects.
1635
62973b41
JB
16362011-03-16 Juanma Barranquero <lekktu@gmail.com>
1637
1638 * emacs.c (USAGE3): Doc fixes.
1639
0e48bb22
AS
16402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1641
1642 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1643 structure.
1644
7684e57b
JB
16452011-03-14 Juanma Barranquero <lekktu@gmail.com>
1646
1647 * lisp.h (VWindow_system, Qfile_name_history):
1648 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1649 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1650 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1651
1652 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1653 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1654
1655 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1656 * w32console.c (detect_input_pending, read_input_pending)
1657 (encode_terminal_code):
1658 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1659 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1660 (w32_system_caret_y, Qfile_name_history):
1661 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1662 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1663 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1664 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1665 * w32proc.c (Qlocal, report_file_error):
1666 * w32term.c (Vwindow_system, updating_frame):
1667 * w32uniscribe.c (initialized, uniscribe_font_driver):
1668 Remove unneeded extern declarations.
1669
2aa46d6c
CY
16702011-03-14 Chong Yidong <cyd@stupidchicken.com>
1671
c96bbc66 1672 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1673
cffc6f3b
CY
16742011-03-13 Chong Yidong <cyd@stupidchicken.com>
1675
1676 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1677 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1678 These macros can no longer be used for assignment.
1679
44f230aa
SM
1680 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1681 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1682 (record_buffer_markers, fetch_buffer_markers): New functions for
1683 recording and fetching special buffer markers.
1684 (set_buffer_internal_1, set_buffer_temp): Use them.
1685
1686 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1687
1688 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1689
1690 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1691 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1692
1693 * xdisp.c (hscroll_window_tree):
1694 (reconsider_clip_changes): Use PT instead of BUF_PT.
1695
d251f04b
EZ
16962011-03-13 Eli Zaretskii <eliz@gnu.org>
1697
1698 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1699 $(EMACS_ROOT)/lib/intprops.h.
1700
f0c77cd1
PE
17012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1702
3eca4629
PE
1703 Fix more problems found by GCC 4.5.2's static checks.
1704
7c86ee98
PE
1705 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1706 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1707 (xg_free_frame_widgets): Make it clear that a local variable is
1708 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1709 (gdk_window_get_screen): Make it clear that this macro is needed
1710 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1711 (int_gtk_range_get_value): New function, which avoids a diagnostic
1712 from gcc -Wbad-function-cast.
1713 (xg_set_toolkit_scroll_bar_thumb): Use it.
1714 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1715 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1716 (get_utf8_string, xg_get_file_with_chooser):
1717 Rename locals to avoid shadowing.
1718 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1719
41729b81
PE
1720 * xgselect.c (xg_select): Remove unused var.
1721
f0c77cd1
PE
1722 * image.c (four_corners_best): Mark locals as initialized.
1723 (gif_load): Initialize transparent_p to zero (Bug#8238).
1724 Mark another local as initialized.
ec6cf4c6 1725 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1726
ce0ad53d 1727 * image.c (clear_image_cache): Now static.
d5d5a617 1728 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1729 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1730 (x_edge_detection): Remove unnecessary cast that
1731 gcc -Wbad-function-cast diagnoses.
2037898d 1732 (gif_load): Fix pointer signedness.
6ae141d6
PE
1733 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1734 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1735
33383987 17362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1737
d32df629
PE
1738 Improve quality of tests for time stamp overflow.
1739 For example, without this patch (encode-time 0 0 0 1 1
1740 1152921504606846976) returns the obviously-bogus value (-948597
1741 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1742 reports time overflow. See
1743 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1744 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1745 * editfns.c: Include limits.h and intprops.h.
1746 (TIME_T_MIN, TIME_T_MAX): New macros.
1747 (time_overflow): Move earlier, to before first use.
1748 (hi_time, lo_time): New functions, for an accurate test for
1749 out-of-range times.
1750 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1751 (Fget_internal_run_time): Don't assume time_t fits in int.
1752 (make_time): Use list2 instead of Fcons twice.
1753 (Fdecode_time): More accurate test for out-of-range times.
1754 (check_tm_member): New function.
1755 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1756 (lisp_time_argument): Don't rely on undefined left-shift and
1757 right-shift behavior when checking for time stamp overflow.
8be6f318 1758
fe31d94c
PE
1759 * editfns.c (time_overflow): New function, refactoring common code.
1760 (Fformat_time_string, Fdecode_time, Fencode_time):
1761 (Fcurrent_time_string): Use it.
1762
8be6f318
PE
1763 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1764 * dired.c (make_time): Move to ...
1765 * editfns.c (make_time): ... here.
1766 * systime.h: Note the move.
1767
09d9db2c 17682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1769
126bc0dc
YM
1770 * fringe.c (update_window_fringes): Remove unused variables.
1771
c47cbdfd
YM
1772 * unexmacosx.c (copy_data_segment): Also copy __got section.
1773 (Bug#8223)
1774
7ac80be9
EZ
17752011-03-12 Eli Zaretskii <eliz@gnu.org>
1776
c96bbc66 1777 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1778 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1779 Constify `char *' arguments and their references according to
1780 prototypes in tparam.h.
1781
ecb0f94d 1782 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1783
7ac80be9
EZ
1784 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1785 Adapt all references accordingly.
1786
1787 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1788
ef1fd07e
TT
17892011-03-11 Tom Tromey <tromey@redhat.com>
1790
1791 * buffer.c (syms_of_buffer): Remove obsolete comment.
1792
7ef4b50c
EZ
17932011-03-11 Eli Zaretskii <eliz@gnu.org>
1794
1795 * termhooks.h (encode_terminal_code): Declare prototype.
1796
1797 * msdos.c (encode_terminal_code): Don't declare prototype.
1798
1799 * term.c (encode_terminal_code): Now external again, used by
1800 w32console.c and msdos.c.
1801
44f230aa
SM
1802 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1803 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1804
4b1ec863 18052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1806
1714f52b 1807 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1808
4b1ec863
PE
1809 * fringe.c (update_window_fringes): Mark locals as initialized
1810 (Bug#8227).
1811 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1812
524c7aa6
PE
1813 * alloc.c (mark_fringe_data): Move decl from here ...
1814 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1815 to check its interface.
1816 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1817
a5c0af81 1818 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1819 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1820 (fontset_font): Mark local as initialized.
a9a06e0b 1821 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1822
b4716021
PE
1823 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1824
811e9bac 1825 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1826 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1827 (x_own_selection, Fx_disown_selection_internal): Rename locals
1828 to avoid shadowing.
1829 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1830
7e3ab302
PE
1831 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1832 so that the caller can use some name other than gcpro1.
1833 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1834 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1835 (Fx_backspace_delete_keys_p):
1836 Use them to avoid shadowing, and rename vars to avoid shadowing.
1837 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1838 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1839 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1840 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1841 Remove unused locals.
7e3ab302
PE
1842 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1843 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1844 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1845 macros.
f78faa98 1846
e2b13473
PE
1847 * xterm.h (x_mouse_leave): New decl.
1848
77f23912
PE
1849 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1850 Remove unused functions.
cdf4ba58
PE
1851 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1852 (x_calc_absolute_position): Now static.
7411c686 1853 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1854 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1855 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1856 unless they are used.
38d0b34a
PE
1857 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1858 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1859 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1860 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1861 (x_error_catcher, x_connection_closed, x_error_handler):
1862 (x_error_quitter, xembed_send_message, x_iconify_frame):
1863 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1864 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1865 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1866
44f230aa
SM
1867 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1868 Rename or move locals to avoid shadowing.
6b463e58 1869 (tty_defined_color, merge_face_heights): Now static.
5967d051 1870 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1871 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1872 does not deduce is never used uninitialized.
73719eba
PE
1873 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1874 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1875
426994c3 1876 * terminal.c (store_terminal_param): Now static.
5489860b 1877
032f1620 1878 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1879 (set_frame_menubar): Remove unused local.
d4323972 1880 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1881 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1882 since they might point to immutable storage.
281585b0
PE
1883 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1884 since it's unused otherwise.
032f1620 1885
367c19e5 1886 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1887 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1888 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1889 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1890 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1891 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1892 does not deduce are never used uninitialized.
70739cbe 1893
07b48fa9
PE
1894 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1895
8868a238 1896 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1897 * window.c (window_loop, size_window):
1898 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1899
7e5cf297 1900 * window.c (display_buffer): Now static.
d6550a9f
PE
1901 (size_window): Mark variables that gcc -Wuninitialized
1902 does not deduce are never used uninitialized.
a586633d
PE
1903 * window.h (check_all_windows): New decl, to forestall
1904 gcc -Wmissing-prototypes diagnostic.
5b555da1 1905 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1906
f6095868
PE
1907 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1908 shadowing.
1909 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1910 Include <limits.h>.
1911 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1912 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1913 (load_charset_map): Mark variables that gcc -Wuninitialized
1914 does not deduce are never used uninitialized.
53df7c11 1915 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1916
f38b440c
PE
1917 * coding.c (coding_set_source, coding_set_destination):
1918 Use "else { /* comment */ }" rather than "else /* comment */;"
1919 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1920 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1921 a block, when the outer 'i' will do.
1922 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1923 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1924 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1925 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1926 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1927 Rename locals to avoid shadowing.
1928 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1929 * coding.c (emacs_mule_char, encode_invocation_designation):
1930 Now static, since they're not used elsewhere.
413bb2db 1931 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1932 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1933 (decode_coding_emacs_mule): Mark variables that gcc
1934 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1935 (detect_coding_iso_2022): Initialize a local variable that might
1936 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1937 this initialization is needed. (Bug#8211)
5f58e762
PE
1938 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1939 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1940 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1941 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1942 Remove unused macros.
f38b440c 1943
232b38b9 1944 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1945 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1946 * character.c (string_count_byte8): Likewise.
232b38b9 1947
fb90da1b
PE
1948 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1949 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1950
fb93dbc2
PE
1951 * chartab.c (copy_sub_char_table): Now static, since it's not used
1952 elsewhere.
5c156ace
PE
1953 (sub_char_table_ref_and_range, char_table_ref_and_range):
1954 Rename locals to avoid shadowing.
bbcd0949 1955 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1956
7d3b3862 1957 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1958 (BIDI_BOB): Remove unused macro.
7d3b3862 1959
6be7d3da
PE
1960 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1961 deduce are never used uninitialized.
c2ed9c8b 1962 * term.c (encode_terminal_code): Likewise.
6be7d3da 1963
75f8807f 1964 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1965
50938595
PE
1966 * tparam.h: New file.
1967 * term.c, tparam.h: Include it.
1968 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1969 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1970 Move these decls to tparam.h, and make them agree with what
1971 is actually in tparam.c. The previous trick of using incompatible
1972 decls in different modules does not conform to the C standard.
1973 All callers of tparam changed to use tparam's actual API.
1974 * tparam.c (tparam1, tparam, tgoto):
1975 Use const pointers where appropriate.
1976
fbceeba2
PE
1977 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1978 * cm.h (struct cm): Likewise.
1979 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1980 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1981 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1982 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1983 (turn_on_face, init_tty): Likewise.
1984 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1985
7f3f1250
PE
1986 * term.c (term_mouse_position): Rename local to avoid shadowing.
1987
e6ca6543
PE
1988 * alloc.c (mark_ttys): Move decl from here ...
1989 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1990
c40f8d15
AS
19912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1992
1993 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1994
cfe0661d
JB
19952011-03-09 Juanma Barranquero <lekktu@gmail.com>
1996
1997 * search.c (compile_pattern_1): Remove argument regp, unused since
1998 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1999 (compile_pattern): Don't pass it.
2000
0afb4571
J
20012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2002
2003 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2004 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2005 for ! HAVE_GTK3.
2006 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2007
2008 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2009
2010 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2011 gdk_window_get_screen, gdk_window_get_geometry,
2012 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2013 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2014 (xg_get_pixbuf_from_pixmap): New function.
2015 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2016 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2017 Call xg_get_pixbuf_from_pixmap instead of
2018 gdk_pixbuf_get_from_drawable.
2019 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2020 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2021 (xg_check_special_colors): Use GtkStyleContext and its functions
2022 for HAVE_GTK3.
2023 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2024 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2025 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2026 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2027 Call gtk_widget_get_preferred_size.
0afb4571
J
2028 (xg_frame_resized): gdk_window_get_geometry only takes 5
2029 parameters.
44f230aa
SM
2030 (xg_win_to_widget, xg_event_is_for_menubar):
2031 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2032 (xg_set_widget_bg): New function.
2033 (delete_cb): New function.
2034 (xg_create_frame_widgets): connect delete-event to delete_cb.
2035 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2036 (xg_set_background_color): Call xg_set_widget_bg.
2037 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2038 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2039 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2040 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2041 if ! HAVE_GTK3.
2042 (update_frame_tool_bar): Call gtk_widget_hide.
2043 (xg_initialize): Use GDK_KEY_g.
2044
2045 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2046 if ! HAVE_GTK3
2047 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2048
2049 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2050 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2051 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2052
1c2cc4ef
JB
20532011-03-08 Juanma Barranquero <lekktu@gmail.com>
2054
2055 * w32xfns.c (select_palette): Check success of RealizePalette against
2056 GDI_ERROR, not zero.
2057
33383987 2058See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2059
2060;; Local Variables:
2061;; coding: utf-8
aac0c6e3
MR
2062;; End:
2063
33383987 2064 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2065
2066 This file is part of GNU Emacs.
2067
2068 GNU Emacs is free software: you can redistribute it and/or modify
2069 it under the terms of the GNU General Public License as published by
2070 the Free Software Foundation, either version 3 of the License, or
2071 (at your option) any later version.
2072
2073 GNU Emacs is distributed in the hope that it will be useful,
2074 but WITHOUT ANY WARRANTY; without even the implied warranty of
2075 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2076 GNU General Public License for more details.
2077
2078 You should have received a copy of the GNU General Public License
2079 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.