Fix another crash due to incorrect hash value of glyph rows, bug #10035.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
015137db
EZ
12011-11-18 Eli Zaretskii <eliz@gnu.org>
2
3 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4 hash values of the two rows.
5 (copy_row_except_pointers): Preserve the used[] arrays and the
6 hash values of the two rows. (Bug#10035)
7
8 * xdisp.c (row_hash): New function, body extracted from
9 compute_line_metrics.
10 (compute_line_metrics): Call row_hash, instead of computing the
11 hash code inline.
12
13 * dispnew.c (verify_row_hash): Call row_hash for computing the
14 hash code of a row, instead of duplicating code from xdisp.c.
15
16 * dispextern.h (row_hash): Add prototype.
17
a2addb04
TH
182011-11-18 Tassilo Horn <tassilo@member.fsf.org>
19
20 * frame.c (delete_frame): Don't delete the terminal when the last
21 X frame is closed if emacs is built with GTK toolkit.
22
df85d315
JB
232011-11-17 Juanma Barranquero <lekktu@gmail.com>
24
25 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
26
a0c2d0ae
MR
272011-11-17 Martin Rudalics <rudalics@gmx.at>
28
29 * window.c (Vwindow_splits): Rename to
30 Vwindow_combination_resize. Suggested by Juri Linkov.
31 (Fsplit_window_internal): Use Vwindow_combination_resize instead
32 of Vwindow_splits.
33
58179cce
JB
342011-11-16 Juanma Barranquero <lekktu@gmail.com>
35
7877f373
JB
36 * nsfns.m (Fns_font_name):
37 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 38
b6f67890
MR
392011-11-16 Martin Rudalics <rudalics@gmx.at>
40
41 * window.h (window): Rename slot "nest" to "combination_limit".
42 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
43 (Fset_window_nest): Rename to Fset_window_combination_limit.
44 (Vwindow_nest): Rename to Vwindow_combination_limit.
45 (recombine_windows, make_parent_window, make_window)
46 (Fsplit_window_internal, saved_window)
47 (Fset_window_configuration, save_window_save): Rename all
48 occurrences of window_nest to window_combination_limit.
49
c7015153
JB
502011-11-15 Juanma Barranquero <lekktu@gmail.com>
51
52 * image.c (imagemagick_load_image): Fix typo.
53
322ad6ec
EZ
542011-11-14 Eli Zaretskii <eliz@gnu.org>
55
56 * xdisp.c (display_line): Move the call to
57 highlight_trailing_whitespace before the call to
58 compute_line_metrics, since the latter needs to see the final
59 faces of all the glyphs to compute ROW's hash value. Fixes
60 assertion violations in row_equal_p. (Bug#10035)
61
f067b8ec
JB
622011-11-14 Juanma Barranquero <lekktu@gmail.com>
63
64 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
65 just return (bug#10044).
66
1e5b2111
EZ
672011-11-12 Eli Zaretskii <eliz@gnu.org>
68
7ef3cbd5
EZ
69 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
70 with user-defined heap size. Bump the default size of the temacs
71 heap to 27MB, to avoid memory warning when running temacs.
72 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
73
1e5b2111
EZ
74 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
75 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
76 (verify_row_hash) [XASSERTS]: New function.
77 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
78 that the hash value of glyph rows is correct.
1e5b2111 79
89d61221
MR
802011-11-12 Martin Rudalics <rudalics@gmx.at>
81
82 * window.h (window): Remove splits slot.
83 * window.c (Fwindow_splits, Fset_window_splits): Remove.
84 (Fdelete_other_windows_internal, make_parent_window)
85 (make_window, Fsplit_window_internal, Fdelete_window_internal)
86 (Fset_window_configuration, save_window_save): Don't deal with
87 split status of windows.
88 (saved_window): Remove splits slot.
89 (Vwindow_splits): Rewrite doc-string.
90
97f18cc8
JD
912011-11-11 Jan Djärv <jan.h.d@swipnet.se>
92
93 * xfns.c (unwind_create_frame):
94 * nsfns.m (unwind_create_frame):
95 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
96 Vframe_list (Bug#9999).
97
22a648b4
DA
982011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
99
0b381c7e 100 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 101
659afede
KH
1022011-11-11 Kenichi Handa <handa@m17n.org>
103
104 * callproc.c (Fcall_process): Set the member dst_multibyte of
105 process_coding.
106
9ac0394b
KH
1072011-11-11 Johan Bockgård <bojohan@gnu.org>
108
109 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
110 avoid a crash (bug#9496).
111
2fbdc249
CY
1122011-11-09 Chong Yidong <cyd@gnu.org>
113
114 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
115 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
116
ac6b1f81
PE
1172011-11-08 Paul Eggert <eggert@cs.ucla.edu>
118
119 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
120
09db192c
PE
1212011-11-08 Paul Eggert <eggert@cs.ucla.edu>
122
123 Avoid some portability problems by eschewing 'extern inline' functions.
124 The trivial performance wins aren't worth the portability hassles; see
125 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
126 et seq.
127 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
128 (window_box_width, window_box_left, window_box_left_offset)
129 (window_box_right, window_box_right_offset): Undo previous change,
130 by removing the "extern"s.
131 * intervals.c (adjust_intervals_for_insertion)
132 (adjust_intervals_for_deletion): Undo previous change,
133 making these static again.
134 (offset_intervals, temp_set_point_both, temp_set_point)
135 (copy_intervals_to_string): No longer inline.
136 * xdisp.c (window_text_bottom_y, window_box_width)
137 (window_box_height, window_box_left_offset)
138 (window_box_right_offset, window_box_left, window_box_right)
139 (window_box): No longer inline.
140
105216ed
CY
1412011-11-08 Chong Yidong <cyd@gnu.org>
142
143 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
144 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
145 an error if not a live window.
146 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
147 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
148
ae9e237f
JB
1492011-11-07 Juanma Barranquero <lekktu@gmail.com>
150
151 * lisp.h (syms_of_abbrev): Remove declaration.
152 Reported by CHENG Gao <chenggao@royau.me>.
153
c7aa8333
EZ
1542011-11-07 Eli Zaretskii <eliz@gnu.org>
155
156 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
157 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
158 of temacs in GUI mode.
159
be7f5545
MR
1602011-11-07 Martin Rudalics <rudalics@gmx.at>
161
162 * window.h: Declare delete_all_child_windows instead of
163 delete_all_subwindows.
164 * window.c (Fwindow_nest, Fset_window_nest)
165 (Fset_window_new_total, Fset_window_new_normal)
166 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
167 (delete_all_subwindows): Rename to delete_all_child_windows.
168 (Fdelete_other_windows_internal, Fset_window_configuration):
169 Call delete_all_child_windows instead of delete_all_subwindows.
170 * frame.c (delete_frame): Call delete_all_child_windows instead
171 of delete_all_subwindows.
172
ca78dc43
PE
1732011-11-07 Paul Eggert <eggert@cs.ucla.edu>
174
175 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
176 This is also needed for porting to any host where GC_MARK_STACK is
177 not GC_MAKE_GCPROS_NOOPS.
178 (which_symbols): Use it.
179
a0241d01
KH
1802011-11-07 Kenichi Handa <handa@m17n.org>
181
182 * coding.c (coding_set_destination): Check coding->src_pos only
183 when coding->src_object is a buffer (bug#9910).
184
185 * process.c (send_process): Set the member src_multibyte of coding
186 to 0 (bug#9911) when sending a unibyte text.
187
188 * callproc.c (Fcall_process): Set the member src_multibyte of
189 process_coding to 0 (bug#9912).
190
a64bfdfa 1912011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
192
193 * xmenu.c (cleanup_widget_value_tree): New function.
194 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
195 calling free_menubar_widget_value_tree directly (Bug#9830).
196
cb41b32a
PE
1972011-11-06 Paul Eggert <eggert@cs.ucla.edu>
198
199 Fix some portability problems with 'inline'.
200 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
201 (window_box_width, window_box_left, window_box_left_offset)
202 (window_box_right, window_box_right_offset): Declare extern.
203 Otherwise, these inline functions do not conform to C99 and
204 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
205 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
206 * intervals.c (adjust_intervals_for_insertion)
207 (adjust_intervals_for_deletion): Now extern, because otherwise the
208 extern inline functions 'offset_intervals' couldn't refer to it.
209 (static_offset_intervals): Remove.
210 (offset_intervals): Rewrite using the old contents of
211 static_offset_intervals. The old version didn't conform to C99
212 because an extern inline function contained a reference to an
213 identifier with static linkage.
214
b7041366
AS
2152011-11-06 Andreas Schwab <schwab@linux-m68k.org>
216
217 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
218 GC.
219
88a37c4d
EZ
2202011-11-06 Eli Zaretskii <eliz@gnu.org>
221
222 * xdisp.c (init_iterator, reseat_to_string): Don't set the
223 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
224 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
225 return Qleft_to_right.
226
49745b39
CY
2272011-11-06 Chong Yidong <cyd@gnu.org>
228
229 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
230 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
231 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
232 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
233 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
234 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
235 (Fwindow_vscroll): Doc fix.
236 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
237 argument, since it makes no sense to pass a live window and for
238 consistency with window-child.
239
1f05cd82
CS
2402011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
241
242 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
243 support MSVC.
244
22610910
JR
2452011-11-05 Jason Rumney <jasonr@gnu.org>
246
247 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
248 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
249 fonts (Bug#6029).
250 (add_font_entity_to_list): Fix logic errors in mixed boolean and
251 bitwise arithmetic preventing use of unicode-sip and non-truetype
252 opentype fonts.
253
a06776b2
EZ
2542011-11-05 Eli Zaretskii <eliz@gnu.org>
255
3ad924ba
EZ
256 * s/ms-w32.h (fstat, stat, utime): Move redirections to
257 "emacs"-only part.
258
a06776b2
EZ
259 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
260 initialization code to keep similarity to xfns.c after changes
261 from 2011-11-05.
262
c9e7db78
JD
2632011-11-05 Jan Djärv <jan.h.d@swipnet.se>
264
a97f8f3f
JD
265 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
266 (unwind_create_frame): New function (Bug#9943).
267 (Fx_create_frame): Restructure code to be more similar to the one in
268 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
269 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
270 Move terminal->reference_count++ just before making the frame official
271 (Bug#9943).
272
273 * nsterm.m (x_free_frame_resources): New function.
274 (x_destroy_window): Move code to x_free_frame_resources.
275
c9e7db78
JD
276 * xfns.c (unwind_create_frame): Fix comment.
277 (Fx_create_frame, x_create_tip_frame): Move
278 terminal->reference_count++ just before making the frame
279 official. Move initialization of image_cache_refcount and
280 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
281
a6fc3b5c
EZ
2822011-11-05 Eli Zaretskii <eliz@gnu.org>
283
284 Support MSVC build with newer versions of Visual Studio.
285 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
286 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
287 nt/gmake.defs.
288
289 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
290 which are not supported by MSVC.
291 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
292 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
293 bitfields.
294 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
295 types in bitfields.
296 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
297
298 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
299
58179cce 3002011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
301
302 Support MSVC build with newer versions of Visual Studio.
303 * w32.c: Don't include w32api.h for MSVC.
304 (init_environment) [_MSC_VER]: Call sys_access, not _access.
305
306 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
307 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
308 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
309 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
310 e_* cousins.
311 (alloca) [_MSC_VER]: Define to _alloca.
312
313 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
314
315 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
316
a58c13ed
EZ
3172011-11-04 Eli Zaretskii <eliz@gnu.org>
318
319 * xdisp.c (note_mouse_highlight): If either of
320 previous/next-single-property-change returns nil, treat that as
321 the beginning or the end of the buffer. (Bug#9955)
322
fe0b6370
JD
3232011-11-04 Jan Djärv <jan.h.d@swipnet.se>
324
a58c13ed 325 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
326 label is not null (Bug#9951).
327 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
328 may be NULL.
329
89bd5ee1
EZ
3302011-11-04 Eli Zaretskii <eliz@gnu.org>
331
332 * window.c (Fwindow_body_size): Mention in the doc string that the
333 return value is in frame's canonical units. (Bug#9949)
334
84c3edb9
EZ
3352011-11-03 Eli Zaretskii <eliz@gnu.org>
336
4e2fb5c7
EZ
337 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
338
84c3edb9 339 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 340 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 341 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 342
bc17a887
EZ
3432011-11-01 Eli Zaretskii <eliz@gnu.org>
344
345 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
346 Don't stop backward scan on the continuation glyph, even though
347 its CHARPOS is positive.
26b46e51
EZ
348 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
349 cover_string to disp_string.
bc17a887 350
4ee88440
MR
3512011-11-01 Martin Rudalics <rudalics@gmx.at>
352
353 * window.c (temp_output_buffer_show): Don't use
354 Vtemp_buffer_show_specifiers.
355 (Vtemp_buffer_show_specifiers): Remove unused variable.
356
c2ff3c02
EZ
3572011-10-30 Eli Zaretskii <eliz@gnu.org>
358
359 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
360 past the beginning of the current glyph matrix.
361
58179cce 3622011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
363
364 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
365 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
366 HAVE_GTK3 (Bug#9869).
b77a6a7f 367
3b574623
JD
368 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
369 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
370
b77a6a7f
JD
371 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
372
373 * xterm.c: Declare x_handle_net_wm_state to return int.
374 (handle_one_xevent): Check if we are iconified but don't have
375 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
376 (get_current_wm_state): Return non-zero if not hidden,
377 check for _NET_WM_STATE_HIDDEN (Bug#9893).
378 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
379 (x_handle_net_wm_state): Return what get_current_wm_state returns.
380 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
381
196e41e4
PE
3822011-10-29 Paul Eggert <eggert@cs.ucla.edu>
383
384 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
385 so that this new function doesn't get optimized away by a
386 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
387
021f2e1a
AS
3882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
389
390 * frame.h (MOUSE_HL_INFO): Remove excess parens.
391
8b058d44
EZ
3922011-10-29 Eli Zaretskii <eliz@gnu.org>
393
394 Fix the `xbytecode' command.
395 * .gdbinit (xprintbytestr): New command.
396 (xwhichsymbols): Renamed from `which'; all callers changed.
397 (xbytecode): Print the byte-code string as well.
398
4452fb80
EZ
3992011-10-29 Kim Storm <storm@cua.dk>
400
8b058d44
EZ
401 * alloc.c (which_symbols): New function.
402
21b72067
AS
4032011-10-29 Andreas Schwab <schwab@linux-m68k.org>
404
405 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
406 line. (Bug#9903)
407
83ed7b5c
GM
4082011-10-29 Glenn Morris <rgm@gnu.org>
409
410 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
411 Not clear what it was for, and it causes various bugs. (Bug#9839)
412
5a7a728b
EZ
4132011-10-28 Eli Zaretskii <eliz@gnu.org>
414
415 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
416 possible random value that matches one of those tested as
417 condition to clear the mouse face.
418
d3d0842f
CY
4192011-10-28 Chong Yidong <cyd@gnu.org>
420
421 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
422
31b39d13
DN
4232011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
424
425 * window.c (make_window): Initialize phys_cursor_on_p.
426
9aba6043
SM
4272011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
428
429 * lisp.h (struct Lisp_Symbol): Update comments.
430
c20992f4
JB
4312011-10-28 Juanma Barranquero <lekktu@gmail.com>
432
433 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
434
db4f02f2
EZ
4352011-10-28 Eli Zaretskii <eliz@gnu.org>
436
437 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
438 <oslsachem@gmail.com> for helping to debug this.
439
440 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
441 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
442 (g_b_init_get_glyph_outline_w): New static variables.
443 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
444 (GetGlyphOutlineW_Proc): New typedefs.
445 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
446 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
447 New functions.
448 (w32font_open_internal, compute_metrics):
449 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
450 instead of calling the "wide" APIs directly.
451
452 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
453
454 * w32.h (syms_of_w32font): Add prototype.
455
87e68db4
JB
4562011-10-27 Juanma Barranquero <lekktu@gmail.com>
457
458 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
459 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
460 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
461 (Fmove_to_window_line): Doc fix.
462
435c1d67
CY
4632011-10-27 Chong Yidong <cyd@gnu.org>
464
465 * process.c (make_process): Set gnutls_state to NULL.
466
467 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
468 non-NULL, regardless of GNUTLS_INITSTAGE.
469 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
470 an error. Set process slots as soon as we allocate them.
471
472 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
473
9c6c6f49
CY
4742011-10-27 Chong Yidong <cyd@gnu.org>
475
9aba6043
SM
476 * gnutls.c (emacs_gnutls_deinit): New function.
477 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
478 (Fgnutls_deinit, Fgnutls_boot): Use it.
479
480 * process.c (make_process): Initialize GnuTLS credentials to NULL.
481 (deactivate_process): Call emacs_gnutls_deinit.
482
657d08d3
JB
4832011-10-27 Juanma Barranquero <lekktu@gmail.com>
484
485 * image.c (x_create_x_image_and_pixmap):
486 * w32.c (sys_rename, w32_delayed_load):
487 * w32font.c (fill_in_logfont):
488 * w32reg.c (x_get_string_resource): Silence compiler warnings.
489
5430d399
JB
4902011-10-26 Juanma Barranquero <lekktu@gmail.com>
491
492 * w32fns.c (w32_default_color_map): New function,
493 extracted from Fw32_default_color_map.
a7ef684b 494 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 495
fe0055fa
PE
4962011-10-25 Paul Eggert <eggert@cs.ucla.edu>
497
498 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
499
e6346438
SM
5002011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
501
502 * keyboard.c (test_undefined): New function (bug#9751).
503 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
504
e112cc37
ET
5052011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
506
507 * sysdep.c (init_sys_modes): Fix the check for the controlling
508 terminal (Bug#6649).
509
7b5d6677
EZ
5102011-10-20 Eli Zaretskii <eliz@gnu.org>
511
512 * dispextern.h (struct bidi_it): New member next_en_type.
513
514 * bidi.c (bidi_line_init): Initialize the next_en_type member.
515 (bidi_resolve_explicit_1): When next_en_pos is valid for the
516 current character, check also for next_en_type being WEAK_EN.
517 (bidi_resolve_weak): Don't enter the expensive loop if the current
518 position is before next_en_pos. Record the bidi type of the first
519 non-ET, non-BN character we find, in addition to its position.
520 (bidi_level_of_next_char): Invalidate next_en_type when
521 next_en_pos is over-stepped.
522
7da0b018
PE
5232011-10-20 Paul Eggert <eggert@cs.ucla.edu>
524
525 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
526 * editfns.c: Rewrite current-time-zone so that it invokes
527 the equivalent of (format-time-string "%Z") to get the time zone name.
528 This fixes a bug when the time zone name contains characters that
529 need converting from the system time locale to Emacs internal format.
530 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
531 that patch fixed format-time-string to do the conversion, but
532 I forgot to fix current-time-zone.
533 (format_time_string): New function, containing most of
534 what Fformat_time_string used to contain.
535 (Fformat_time_string): Rewrite in terms of format_time_string.
536 This doesn't change this function's behavior.
537 (current-time-zone): Rewrite to use format_time_string.
538 This fixes the bug reported by Michael Schierl in
539 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
540 Jason Rumney's 2007-06-07 change worked around this bug, but
541 didn't fix it.
542 * systime.h (tzname, timezone): Remove no-longer-used declarations.
543
8547b010
EZ
5442011-10-19 Eli Zaretskii <eliz@gnu.org>
545
546 * xdisp.c (start_display): If the character at POS is displayed
547 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
548 (try_window_reusing_current_matrix): If a line ends in a display
549 vector or the next line starts in a display vector, continue
550 redrawing the window even though the character position of
551 start_row was reached.
8547b010
EZ
552 (Bug#9771, part 2)
553
4e948d15
CY
5542011-10-18 Chong Yidong <cyd@gnu.org>
555
556 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
557 with nobreak-char-display too.
558
4787455f
EZ
5592011-10-18 Eli Zaretskii <eliz@gnu.org>
560
561 Fix part 3 of bug#9771.
562 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
563 (bidi_resolve_neutral): Don't enter the expensive loop looking for
564 non-neutral characters if the current character is a paragraph
565 separator (a.k.a. Newline). This avoids running the same
566 expensive loop twice, once when we consume the preceding newline
567 and the other time when the line actually needs to be displayed.
568 Avoid the loop when we see neutrals on the base embedding level
569 following a character whose directionality is the same as the
570 paragraph's. This avoids running the expensive loop when a line
571 ends in a long sequence of neutrals, like control characters.
572 Add assertion against STRONG_AL type. Slightly rearrange code
573 that determines the type of a neutral given the first non-neutral
574 that follows it.
575 (bidi_level_of_next_char): Set next_en_pos to zero when
576 invalidating its info.
577
2c91f553
EZ
5782011-10-17 Eli Zaretskii <eliz@gnu.org>
579
580 * xdisp.c (push_display_prop): Determine whether to record string
581 or buffer position by IT->string, not by IT->method. Allow
582 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
583 (move_it_vertically_backward): Don't look for character position
584 immediately after the newline when in a continuation line.
585 (Bug#9771, part 1)
2c91f553 586
c7b08b0d
MR
5872011-10-15 Martin Rudalics <rudalics@gmx.at>
588
589 * window.c (coordinates_in_window): Rewrite and delabelize
590 vertical border check. (Bug#5357) (Bug#9618)
591
6b02f655
SM
5922011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
593
594 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
595 errors in XSetWindowBorder (bug#9310).
596
81d40c92
DA
5972011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
598
599 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
600 avoid crash when xmalloc overrun checking is enabled.
601
d4172c3b
EZ
6022011-10-13 Eli Zaretskii <eliz@gnu.org>
603
604 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
605 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
606 cursor motion with <left> and <right> arrow keys.
607
608 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
609 some callers set that themselves.
610
b00eea75
EZ
6112011-10-12 Eli Zaretskii <eliz@gnu.org>
612
613 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
614 display string and the previous row comes from the same string and
615 is empty. (Bug#9739) (Bug#9738)
616
8fe012c4
SM
6172011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
618
619 * doc.c (get_doc_string): Encode file name (bug#9735).
620
0074aef2
EZ
6212011-10-12 Eli Zaretskii <eliz@gnu.org>
622
79beb178
EZ
623 * bidi.c (bidi_level_of_next_char):
624 * xdisp.c (get_visually_first_element): Remove old incorrect
625 comments regarding the Unicode Line Separator character.
626
0074aef2
EZ
627 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
628
6e4b3fbe
DA
6292011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
630
631 * alloc.c (Fgc_status): Do not access beyond zombies array
632 boundary if nzombies > MAX_ZOMBIES.
633 * alloc.c (dump_zombies): Add missing format specifier.
634
0324f3af
PE
6352011-10-12 Paul Eggert <eggert@cs.ucla.edu>
636
b5525cac
PE
637 * xdisp.c (set_cursor_from_row): Simplify conditionals,
638 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
639
0324f3af
PE
640 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
641 Some packages use them to denote characters with modifiers.
642
e9b5f888
AS
6432011-10-11 Andreas Schwab <schwab@linux-m68k.org>
644
645 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
646 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
647 matching a pp-number. Rename parameter var to var1.
648
127827c0
SM
6492011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
650
651 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
652
c8fd3bd0
GM
6532011-10-08 Glenn Morris <rgm@gnu.org>
654
655 * callint.c (Fcall_interactively): Give a more explicit error for the
656 'c' case with a non-character input. (Bug#8479)
657
352ec8ff
EZ
6582011-10-08 Eli Zaretskii <eliz@gnu.org>
659
03669ccb
EZ
660 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
661 lines.
7061c986
EZ
662 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
663 lines that are hscrolled on the left.
03669ccb 664
352ec8ff
EZ
665 * dispnew.c (buffer_posn_from_coords): Account for a possible
666 presence of header-line. (Bug#4426)
667
a66cfb1c
SM
6682011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
669
6b02f655
SM
670 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
671 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 672
7c5ee88e
PE
6732011-10-07 Paul Eggert <eggert@cs.ucla.edu>
674
675 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
676 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
677 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
678 this makes Emacs dump core during garbage collection on rare
679 occasions. sizeof is obviously inferior to offsetof here, so
680 stick with offsetof.
681 (GC_POINTER_ALIGNMENT): New macro.
682 (mark_memory): Omit 3rd (offset) arg; caller changed.
683 Don't assume EMACS_INT alignment is the same as pointer alignment.
684
df1bbe5b
SM
6852011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
686
687 * keyboard.c (read_key_sequence_remapped): New var.
688 (read_key_sequence): Compute remapping in the right buffer.
689 (command_loop_1): Use read_key_sequence's remapping directly.
690
51553db6
SM
6912011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
692
32c1fffd
SM
693 * dired.c (file_name_completion): Don't expand file name.
694 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
695 before checking file name handler.
696
51553db6
SM
697 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
698 they've been requested explicitly (bug#9591).
699
b6bd1599 7002011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
701
702 * keymap.c (Fsingle_key_description): Use make_specified_string
703 instead of build_string to build string from push_key_description.
704 (Bug#5193)
705
f701dc2a
PE
7062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
707
4222c55d
PE
708 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
709 This fixes a Y2038 bug on 64-bit hosts.
710 * buffer.c (reset_buffer):
711 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
712 (Fclear_buffer_auto_save_failure):
713 Use 0, not -1, to represent an unset failure time, since time_t
714 might not be signed.
715
f701dc2a
PE
716 Remove dependency on glibc malloc internals.
717 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
718 Move back here from lisp.h, but with their new implementations.
719 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
720 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
721 * charset.c (charset_table_init): New static var.
722 (syms_of_charset): Use it instead of xmalloc. This removes a
723 dependency on glibc malloc internals. See Eli Zaretskii's comment in
724 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
725 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
726 Move back to alloc.c.
727 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
728 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
729
9ceebf39
JD
7302011-09-30 Jan Djärv <jan.h.d@swipnet.se>
731
732 * nsterm.m (windowDidResize): Call x_set_window_size only when
733 ns_in_resize is true. Otherwise set pixelwidth/height and
734 call change_frame_size (Bug#9628).
735
cb993c58
PE
7362011-09-30 Paul Eggert <eggert@cs.ucla.edu>
737
3930c88b
PE
738 Port --enable-checking=all to Fedora 14 x86-64.
739 * charset.c (syms_of_charset): Also account for glibc malloc's
740 internal overhead when calculating the initial malloc maximum.
741
cb993c58
PE
742 Port --enable-checking=all to Fedora 14 x86.
743 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
744 Move to lisp.h.
745 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
746 (overrun_check_realloc, overrun_check_free):
747 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
748 That way, xmalloc returns a properly-aligned pointer even if
749 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
750 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
751 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
752 into account when calculating the initial malloc maximum.
753 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
754 Move here from alloc.c, so that charset.c can use it too.
755 Properly align; the old code wasn't right for common 32-bit hosts
756 when configured with --enable-checking=all.
757 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
758 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
759
31bed486
EZ
7602011-09-29 Eli Zaretskii <eliz@gnu.org>
761
04c70788 762 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
763 use EDOM.
764
fbcaa2f3
EZ
7652011-09-28 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (compute_display_string_end): If there's no display
768 string at CHARPOS, return -1.
769
770 * bidi.c (bidi_fetch_char): When compute_display_string_end
771 returns a negative value, treat the character as a normal
772 character not covered by a display string. (Bug#9624)
773
a239d4e9
JB
7742011-09-28 Juanma Barranquero <lekktu@gmail.com>
775
776 * lread.c (Fread_from_string): Fix typo in docstring.
777
88652fd5
EZ
7782011-09-27 Eli Zaretskii <eliz@gnu.org>
779
780 * xdisp.c (handle_invisible_prop): If invisible text ends on a
781 newline, reseat the iterator instead of bidi-iterating there one
782 character at a time. (Bug#9610)
32c1fffd
SM
783 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
784 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 785
ed497dd4
AS
7862011-09-27 Andreas Schwab <schwab@linux-m68k.org>
787
788 * lread.c (readevalloop): Use correct code for NBSP.
789 (read1): Likewise. (Bug#9608)
790
b2bf61aa
MA
7912011-09-25 Michael Albinus <michael.albinus@gmx.de>
792
793 * dbusbind.c (Fdbus_register_signal): When service is not
794 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
795
32bbb17c
GM
7962011-09-25 Glenn Morris <rgm@gnu.org>
797
798 * buffer.c (truncate-lines): Doc fix.
799
94e0933e
CY
8002011-09-24 Chong Yidong <cyd@stupidchicken.com>
801
802 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
803 (Fset_window_next_buffers): Doc fix.
804
cddde921
GM
8052011-09-24 Glenn Morris <rgm@gnu.org>
806
807 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
808
1260aef1
PE
8092011-09-24 Paul Eggert <eggert@cs.ucla.edu>
810
25b4bfa0
PE
811 Fix minor problems found by static checking.
812 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
813 * indent.c (Fvertical_motion): Fix == vs = typo.
814
e3cbd34b
EZ
8152011-09-24 Eli Zaretskii <eliz@gnu.org>
816
a66cfb1c
SM
817 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
818 Default value is now t. Doc fix.
6bf7006f 819
e3cbd34b 820 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 821 logic when moving up, not only when moving down. Fix the
e3cbd34b 822 confusing name and values of the it_overshoot_expected variable;
32c1fffd 823 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
824
825 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
826 CHARPOS is covered by a display string which includes newlines.
827 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
828 is covered by a display string with embedded newlines.
829
a3de0cbd
MA
8302011-09-24 Michael Albinus <michael.albinus@gmx.de>
831
832 * dbusbind.c (Fdbus_register_signal): Add match rule to
833 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
834 (Fdbus_register_method, Vdbus_registered_objects_table):
835 Fix docstring.
a3de0cbd 836
b260039d
JM
8372011-09-24 Jim Meyering <meyering@redhat.com>
838
32c1fffd 839 do not ignore write error for any output size
b260039d
JM
840 The previous change was incomplete.
841 While it makes emacs --batch detect the vast majority of stdout
842 write failures, errors were still ignored whenever the output size is
843 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
844 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
845 && echo FAIL: ignored write error
846 FAIL: ignored write error
847 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
848 && echo FAIL: ignored write error
849 FAIL: ignored write error
850 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
851
8eca8a7c
AS
8522011-09-23 Andreas Schwab <schwab@linux-m68k.org>
853
854 * emacs.c (Fkill_emacs): In noninteractive mode exit
855 non-successfully if a write error occurred on stdout. (Bug#9574)
856
3341db62
EZ
8572011-09-21 Eli Zaretskii <eliz@gnu.org>
858
859 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
860 the xassert test.
861
862 * dispextern.h (struct it): Update the comment documenting what
863 can it->OBJECT be.
864
8c203dbf
EZ
8652011-09-20 Eli Zaretskii <eliz@gnu.org>
866
867 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
868 a display string, extend search for cursor position to end of row.
869 (find_row_edges): If the row ends in a newline from a display
870 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
871 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
872 (Fcurrent_bidi_paragraph_direction): Fix search for previous
873 non-empty line. Fixes confusing cursor motion with arrow keys at
874 the beginning of a line that starts with whitespace.
8c203dbf 875
a4824228
LMI
8762011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
877
878 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
879 (bug#9493).
880
33ed493b
CY
8812011-09-18 Chong Yidong <cyd@stupidchicken.com>
882
883 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
884 boolean (Bug#9154).
885
56cd55c8
EZ
8862011-09-18 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (display_line): Record maximum and minimum buffer
889 positions even if no glyphs were produced (e.g., by a zero-width
890 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
891 buffer positions that will be removed from the glyph row because
892 they don't fit.
c02dcedf
EZ
893 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
894 column is beyond frame width: don't subtract 1 "pixel" when
895 computing width of the stretch.
3e62b7e0
EZ
896 (reseat_at_next_visible_line_start): Undo the change made on
897 2011-09-17 that saved paragraph information and restored it after
898 the call to `reseat'. (Bug#9545)
56cd55c8 899
5ed99d36 9002011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
901
902 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
903 and turn window cursor on if cleared (Bug#9415).
904
5ed99d36 9052011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
906
907 * search.c (boyer_moore): Take unibyte characters from pattern
908 literally. (Bug#9458)
909
9bade7b2
EZ
9102011-09-18 Eli Zaretskii <eliz@gnu.org>
911
912 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
913
e5e9d610
PE
9142011-09-18 Paul Eggert <eggert@cs.ucla.edu>
915
87e4427a
PE
916 Fix minor problem found by static checking.
917 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
918 initialized, to pacify gcc -Wuninitialized.
919
e5e9d610
PE
920 * fileio.c: Report proper errno when syscall falls.
921 (Finsert_file_contents): Save and restore errno,
922 so that report_file_error outputs the correct diagnostic.
923 (Fwrite_region) [CLASH_DETECTION]: Likewise.
924
a1674f0b
EZ
9252011-09-18 Eli Zaretskii <eliz@gnu.org>
926
927 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
928
fbfb6dd4
EZ
9292011-09-17 Eli Zaretskii <eliz@gnu.org>
930
931 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
932 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
933
bb187662
EZ
9342011-09-17 Eli Zaretskii <eliz@gnu.org>
935
1137e8b8 936 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 937 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
938
939 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
940 (bidi_find_paragraph_start): Search back for paragraph beginning
941 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
942 (bidi_move_to_visually_next): Only trigger paragraph-related
943 computations when the last character is a newline or at EOB, not
944 just any NEUTRAL_B. (Bug#9470)
945
bb187662
EZ
946 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
947 truncated lines if point is covered by a display string. (Bug#9524)
948
2e621251
PE
9492011-09-16 Paul Eggert <eggert@cs.ucla.edu>
950
951 * xselect.c: Relax test for outgoing X longs (Bug#9498).
952 (cons_to_x_long): New function.
953 (lisp_data_to_selection_data): Use it. Correct the test for
954 short-versus-long data; it was negated. Break out of vector
955 loop, for efficiency, when a long datum is discovered.
956
91a15bc6
SM
9572011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
958
959 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
960
b41c3a35
EZ
9612011-09-16 Eli Zaretskii <eliz@gnu.org>
962
963 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
964 GCC PR/17406) by declaring this function with external scope.
965
7812ba2d
PE
9662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
967
968 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
969 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
970
cf7edc2a
AS
9712011-09-15 Andreas Schwab <schwab@linux-m68k.org>
972
973 * editfns.c (Fformat): Correctly handle text properties on "%%".
974
bd01620e
EZ
9752011-09-15 Eli Zaretskii <eliz@gnu.org>
976
977 * xterm.c (x_draw_composite_glyph_string_foreground):
978 * w32term.c (x_draw_composite_glyph_string_foreground):
979 * term.c (encode_terminal_code):
980 * composite.c (composition_update_it, get_composition_id):
981 * xdisp.c (get_next_display_element)
982 (fill_composite_glyph_string): Add comments about special meaning
983 of TAB characters in a composition.
984
a02719a3
PE
9852011-09-15 Paul Eggert <eggert@cs.ucla.edu>
986
987 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
988 This occurs when processing a multibyte format.
989 Problem reported by Wolfgang Jenker.
a02719a3 990
72589a3c
JB
9912011-09-15 Johan Bockgård <bojohan@gnu.org>
992
993 * xdisp.c (try_cursor_movement): Only check for exact match if
994 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
995
1c14176c
PE
9962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
997
998 Remove unused external symbols.
999 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1000 * xdisp.c (calc_pixel_width_or_height): Now static.
1001 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1002 * indent.c (check_display_width):
1003 * w32term.c: Fix comment to match code.
1004 * xterm.c, xterm.h (x_catching_errors): Remove.
1005
d2eea5b5
PE
10062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 * xselect.c: Use signed conversions more consistently (Bug#9498).
1009 (selection_data_to_lisp_data): Assume incoming selection data are
1010 signed integers, not unsigned. This is to be consistent with
1011 outgoing selection data, which was modified to use signed integers
1012 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1013 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1014 expects long, not unsigned long.
1015
46888499
EZ
10162011-09-14 Eli Zaretskii <eliz@gnu.org>
1017
1018 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1019 computation of loop end. Reported by Johan Bockgård
1020 <bojohan@gnu.org>.
1021
ef8ef9fb
CY
10222011-09-13 Chong Yidong <cyd@stupidchicken.com>
1023
1024 * frame.c (Fother_visible_frames_p): Function deleted.
1025
fa819fed
EZ
10262011-09-12 Eli Zaretskii <eliz@gnu.org>
1027
1028 * indent.c (compute_motion): Process display vector front to back
1029 rather than the other way around. (Bug#2496)
1030
2ba8e008
SM
10312011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1032
1033 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1034
20f53c69
CY
10352011-09-11 Chong Yidong <cyd@stupidchicken.com>
1036
1037 * minibuf.c (Fread_from_minibuffer): Doc fix.
1038
d562d7a4
EZ
10392011-09-11 Eli Zaretskii <eliz@gnu.org>
1040
1041 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1042 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1043
1c4d7f3d
LMI
10442011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1045
1046 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1047 value for non-existent files.
1048
b885bf36
EZ
10492011-09-11 Eli Zaretskii <eliz@gnu.org>
1050
1051 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1052 set its "size" to -1. This will set the modtime_size field of
1053 the corresponding buffer to -1, which is what
1054 verify-visited-file-modtime expects for files that do not exist.
1055 (Bug#9139)
1056
6612f0bf
PE
10572011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1060 here ...
1061 * lisp.h: ... from here. push_key_description is no longer
1062 defined in keyboard.c, so its declaration should not be in
1063 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1064 logically belongs with push_key_description.
1065
dfb3f755
PE
10662011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 * buffer.h: Include <sys/types.h> instead of <time.h>.
1069 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1070 Problem reported by Herbert J. Skuhra.
1071
3134906c
LMI
10722011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1073
1074 * xml.c (parse_region): Make the parsing work for
1075 non-comment-starting XML files again (bug#9144).
1076
8d903f4e
AS
10772011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1078
1079 * image.c (gif_load): Fix calculation of bottom and right corner.
1080 (Bug#9468)
1081
80ad64f4
EZ
10822011-09-10 Eli Zaretskii <eliz@gnu.org>
1083
1084 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1085 redisplay in small windows.
1086
208a048d
EZ
10872011-09-09 Eli Zaretskii <eliz@gnu.org>
1088
1089 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1090
9b1c252e
MR
10912011-09-08 Martin Rudalics <rudalics@gmx.at>
1092
1093 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1094 Operate on live windows only.
1095
2949f33b
JB
10962011-09-08 Juanma Barranquero <lekktu@gmail.com>
1097
1098 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1099
e08dcafd
EZ
11002011-09-07 Eli Zaretskii <eliz@gnu.org>
1101
1102 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1103 only under bidi iteration.
1104
115b96bd
JD
11052011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1106
1107 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1108
c8199d0f
PE
11092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1110
1111 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1112 Without this fix, the command to link temacs failed due to an
1113 undefined symbol __builtin_isnan. This is because
1114 /usr/include/iso/math_c99.h #defines isnan(x) to
1115 __builtin_isnan(x), but the bundled gcc, which identifies itself
1116 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1117 a __builtin_isnan.
1118 * floatfns.c (isnan): #undef, and then #define to a clone of
1119 what's in data.c.
1120 (Fisnan): Always define, since it's always available now.
1121 (syms_of_floatfns): Always define isnan at the Lisp level.
1122
e39b275c 11232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1124
1125 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1126
b2db44d9 11272011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1128
f4af5137 1129 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1130 The previous code assumed that file offsets (off_t values) fit in
1131 EMACS_INT variables, which is not true on typical 32-bit hosts.
1132 The code messed up by falsely reporting buffer overflow in cases
1133 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1134 when "big" contains more than 2**29 bytes, even though this
1135 inserts just one byte and does not overflow the buffer.
1136 (Finsert_file_contents): Store file offsets as off_t
1137 values, not as EMACS_INT values. Check for overflow when
1138 converting between EMACS_INT and off_t. When checking for
1139 buffer overflow or for overlap, take the offsets into account.
1140 Don't use EMACS_INT for small values where int suffices.
1141 When checking for overlap, fix a typo: ZV was used where
1142 ZV_BYTE was intended.
1143 (Fwrite_region): Don't assume off_t fits into 'long'.
1144 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1145
ecfc0a49
MA
11462011-09-05 Michael Albinus <michael.albinus@gmx.de>
1147
1148 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1149
6511acf2 11502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1151
0999621a 1152 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1153
1154 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1155 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1156 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1157 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1158 (modify_event_symbol): Do not assume that the length of
1159 name_alist_or_stem is safe to alloca and fits in int.
1160 (Fexecute_extended_command): Likewise for function name and binding.
1161 (Frecursion_depth): Wrap around reliably on integer overflow.
1162 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1163 since some callers pass EMACS_INT values.
1164 (Fsingle_key_description): Don't crash if symbol name contains more
1165 than MAX_ALLOCA bytes.
1166 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1167 (get_minibuffer): Arg is now EMACS_INT, not int.
1168 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1169 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1170 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1171
2be7d702
PE
1172 * dbusbind.c (signature_cat): New function.
1173 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1174 Do not overrun buffer; instead, report string overflow.
1175
9d1df220
PE
1176 * dispnew.c (add_window_display_history): Don't overrun buffer.
1177 Truncate instead; this is OK since it's just a log.
1178
33ef5c64
PE
1179 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1180 even if the time zone offset is outlandishly large.
1181 Don't mishandle offset == INT_MIN.
1182
66c6fdd5
PE
1183 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1184 when creating daemon; the previous buffer-overflow check was incorrect.
1185
d749b01b
PE
1186 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1187 which has the guts of the old verror function.
1188
b5cd1905
PE
1189 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1190 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1191
6e1a67fb
PE
1192 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1193 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1194 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1195 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1196 length of string rather than counting it via multiple sprintfs;
1197 that's simpler and more reliable.
c21721cc
PE
1198 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1199 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1200 sprintf, in case result does not fit in int.
1201
c57b67fc
PE
1202 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1203 (fontset_from_font): Print it.
1204
8a401434
PE
1205 * frame.c (tty_frame_count): Now printmax_t, not int.
1206 (make_terminal_frame, set_term_frame_name): Print it.
1207 (x_report_frame_params): In X, window IDs are unsigned long,
1208 not signed long, so print them as unsigned.
1209 (validate_x_resource_name): Check for implausibly long names,
1210 and don't assume name length fits in 'int'.
1211 (x_get_resource_string): Don't blindly alloca invocation name;
1212 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1213 not fit in int.
1214
6e1a67fb
PE
1215 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1216 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1217 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1218
0df02bf3
PE
1219 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1220 Use esprintf, not sprintf, in case result does not fit in int.
1221
48e30793
PE
1222 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1223 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1224 it as a large positive number.
1225 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1226 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1227
a66ff6d8
PE
1228 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1229 in case result does not fit in int.
1230
aca216ff
PE
1231 * print.c (float_to_string): Detect width overflow more reliably.
1232 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1233 buffer overrun. Don't assume list length fits in 'int'. Treat
1234 print length of 0 as 0, not as infinity; to be consistent with other
1235 uses of print length in this function. Don't overflow print length
1236 index. Don't assume hash table size fits in 'long', or that
1237 vectorlike size fits in 'unsigned long'.
1238
31c286f7
PE
1239 * process.c (make_process): Use printmax_t, not int, to format
1240 process-name gensyms.
1241
55e5faa1
PE
1242 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1243
80f2e268
PE
1244 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1245 to avoid potential buffer overrun.
1246
670741ab
PE
1247 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1248 if X resource line is longer than 512 bytes.
1249
b7163a50
PE
1250 * xfns.c (x_window): Make sprintf buffer a bit bigger
1251 to avoid potential buffer overrun.
1252
ae58ff1f
PE
1253 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1254
c43c8a6a
PE
1255 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1256
3f8236f4
PE
12572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1258
53e9fe90 1259 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1260 Without these, Emacs silently mishandles large integers sometimes.
1261 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1262 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1263
6511acf2
PE
1264 * xdisp.c (try_window_id): Check Emacs fixnum range before
1265 converting to 'int'.
806add1d 1266
6511acf2 1267 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1268 Check that an Emacs fixnum is in range before assigning it to 'int'.
1269 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1270 values converted from Emacs fixnums.
1271 (Frecenter): Don't wrap around a line count if it is out of 'int'
1272 range; instead, treat it as an extreme value.
1273 (Fset_window_configuration, compare_window_configurations):
1274 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1275
6511acf2
PE
1276 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1277 that can exceed INT_MAX. Check that EMACS_INT value is in range
1278 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1279 (match_limit): Don't assume that a fixnum can fit in 'int'.
1280
6511acf2 1281 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1282 exceed INT_MAX.
1283
6511acf2 1284 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1285 (Fvertical_motion): Don't wrap around LINES values that don't fit
1286 in 'int'. Instead, treat them as extreme values. This is good
1287 enough for windows, which can't have more than INT_MAX lines anyway.
1288
fcb901a7
LMI
12892011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1290
0f2f6b6d
LMI
1291 * Require libxml/parser.h to avoid compilation warning.
1292
fcb901a7
LMI
1293 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1294
1295 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1296 since this reportedly can destroy thread storage.
1297
6e20a0d4
CY
12982011-08-30 Chong Yidong <cyd@stupidchicken.com>
1299
1300 * syntax.c (find_defun_start): Update all cache variables if
1301 exiting early (Bug#9401).
1302
148ae00e
EZ
13032011-08-30 Eli Zaretskii <eliz@gnu.org>
1304
f6cfbd8f
EZ
1305 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1306
148ae00e
EZ
1307 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1308 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1309 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1310
1311 * term.c (tty_append_glyph): New function.
1312 (produce_stretch_glyph): Static function and its prototype deleted.
1313
a66cfb1c
SM
1314 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1315 Add prototypes.
148ae00e 1316
c4a07a4c
PE
13172011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1320 when checking :margin (Bug#9390).
1321 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1322 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1323 so that the name doesn't mislead. All uses changed.
1324
6bc8cd65
JB
13252011-08-28 Johan Bockgård <bojohan@gnu.org>
1326
1327 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1328 set_tty_hooks.
1329
dca4927e
EZ
13302011-08-27 Eli Zaretskii <eliz@gnu.org>
1331
1332 * xdisp.c (move_it_to): Don't bail out early when reaching
1333 position beyond to_charpos, if we are scanning backwards.
1334 (move_it_vertically_backward): When DY == 0, make sure we get to
1335 the first character in the line after the newline.
1336
f2cad773
PE
13372011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1338
1339 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1340 (ccl_driver): Do not generate an out-of-range pointer.
1341 (Fccl_execute_on_string): Remove unnecessary check for
1342 integer overflow, noted by Stefan Monnier in
1343 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1344 Remove a FIXME that didn't need fixing.
1345 Simplify the newly-introduced buffer reallocation code.
1346
0cae2cdb
JB
13472011-08-27 Juanma Barranquero <lekktu@gmail.com>
1348
1349 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1350
5fc295a4 13512011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1352
70c60eb2 1353 Integer and memory overflow issues (Bug#9196).
726e0ab1 1354
d31850da
PE
1355 * doc.c (get_doc_string): Rework so that
1356 get_doc_string_buffer_size is the actual buffer size, rather than
1357 being 1 less than the actual buffer size; this makes xpalloc more
1358 convenient.
1359
a69fbedb
PE
1360 * image.c (x_allocate_bitmap_record, cache_image):
1361 * xselect.c (Fx_register_dnd_atom):
1362 Simplify previous changes by using xpalloc.
1363
fe5c5d37
PE
1364 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1365 since either will do and ptrdiff_t is convenient with xpalloc.
1366
0065d054
PE
1367 * charset.c (charset_table_size)
1368 (struct charset_sort_data.priority): Now ptrdiff_t.
1369 (charset_compare): Don't overflow if priorities differ greatly.
1370 (Fsort_charsets): Don't assume list length fits in int.
1371 Check for size-calculation overflow when allocating sort data.
1372 (syms_of_charset): Allocate an initial charset table that is
1373 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1374
1375 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1376
1377 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1378 The actual value is always <= INT_MAX, and leaving it unsigned made
1379 overflow checking harder.
1380
1381 * dispextern.h (struct glyph_matrix.rows_allocated)
1382 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1383 with xpalloc. The values are still always <= INT_MAX.
1384
1385 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1386
1387 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1388 (SAFE_NALLOCA): New macro.
1389
1390 * region-cache.c (struct boundary.pos, find_cache_boundary)
1391 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1392 (set_cache_region, invalidate_region_cache)
1393 (revalidate_region_cache, know_region_cache, region_cache_forward)
1394 (region_cache_backward, pp_cache):
1395 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1396 so that ptrdiff_t * can be passed to xpalloc.
1397 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1398 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1399 (pp_cache): Don't assume cache_len fits in int.
1400 * region-cache.h: Adjust extern decls to match.
1401
1402 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1403 EMACS_INT, since either will do, for xpalloc.
1404
1405 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1406 (xnmalloc, xnrealloc, xpalloc): New functions.
1407
726e0ab1
PE
1408 * bidi.c (bidi_shelve_header_size): New constant.
1409 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1410 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1411
51f30bc5 1412 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1413 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1414 (overlay_strings):
1415 Don't update size of array until after memory allocation succeeds,
1416 because xmalloc/xrealloc may not return.
0065d054
PE
1417 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1418 now that we have proper integer overflow checking.
1419 (record_overlay_string, overlay_strings): Catch overflows when
1420 calculating size of overlay_str_buf.
726e0ab1 1421
0065d054
PE
1422 * callproc.c (Fcall_process): Check for size overflow when
1423 calculating size of args2.
1424 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1425 Normally we prefer signed values, but sticking with ptrdiff_t would
1426 require adding more-complicated checks.
726e0ab1
PE
1427
1428 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1429 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1430 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1431 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1432
1433 * character.c (Fstring): Check for size-calculation overflow.
1434
1435 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1436 unnecessary integer overflow. Check for size overflow.
1437 (encode_coding_object): Don't update size until xmalloc succeeds.
1438
1439 * composite.c (get_composition_id): Check for overflow in glyph
1440 length calculations.
1441
1442 Integer and memory overflow fixes for display code.
1443 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1444 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1445 (scrolling_window): Check for overflow in size calculations.
1446 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1447 Don't assume glyph table len fits in int.
1448 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1449 (row_table_size): Now ptrdiff_t, not int.
1450 (scrolling_window): Avoid overflow in size calculations.
1451 Don't update size until allocation succeeds.
1452 * fns.c (concat): Check for overflow in size calculations.
1453 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1454 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1455 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1456
1457 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1458 (get_doc_string): Check for size calculation overflow.
1459 Don't update size until allocation succeeds.
1460 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1461 EMACS_INT, where ptrdiff_t will do.
1462 (Fsubstitute_command_keys): Check for string overflow.
1463
1464 * editfns.c (set_time_zone_rule): Don't assume environment length
1465 fits in int.
1466 (message_length): Now ptrdiff_t, not int.
1467 (Fmessage_box): Don't update size until allocation succeeds.
1468 Don't assume message length fits in int.
1469 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1470
0065d054
PE
1471 * emacs.c (main): Do not reallocate argv, since there is a null at
1472 the end that can be overwritten, and this way there's no need to
1473 worry about size-calculation overflow.
1474 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1475
1476 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1477 alloc succeeds.
1478 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1479
1480 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1481 (x_set_scroll_bar_width, x_figure_window_size):
1482 Check for integer overflow.
1483 (x_set_alpha): Do not assume XINT fits in int.
1484
1485 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1486 This is for the members text_lines, text_cols, total_lines, total_cols,
1487 where the system imposes an 'int' limit.
1488
1489 * fringe.c (Fdefine_fringe_bitmap):
1490 Don't update size until alloc works.
1491
1492 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1493 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1494
1495 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1496 Check for size-calculation overflow.
1497 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1498 do, as we prefer signed integers.
1499 (id_to_widget.max_size, id_to_widget.used)
1500 (xg_store_widget_in_map, xg_remove_widget_from_map)
1501 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1502 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1503 Use and return ptrdiff_t, not int.
1504 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1505 * gtkutil.h: Change prototypes to match the above.
1506
1507 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1508 are duplicate now that they've been promoted to lisp.h.
1509 (x_allocate_bitmap_record, x_alloc_image_color)
1510 (make_image_cache, cache_image, xpm_load):
1511 Don't update size until alloc is done.
1512 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1513 (x_detect_edges):
3256efce 1514 Check for size calculation overflow.
726e0ab1
PE
1515 (ct_colors_allocated_max): New constant.
1516 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1517 overflow.
3256efce 1518
726e0ab1
PE
1519 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1520 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1521 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1522 Use ptrdiff_t, not int, to count maps.
1523 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1524 calculations. Don't update size until allocation succeeds.
1525 Redo calculations to avoid overflow.
726e0ab1
PE
1526 * keyboard.h: Change prototypes to match the above.
1527
1528 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1529 to count maps.
1530 (current_minor_maps): Check for size calculation overflow.
1531 * keymap.h: Change prototypes to match the above.
1532
1533 * lread.c (read1, init_obarray): Don't update size until alloc done.
1534
1535 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1536 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1537
726e0ab1
PE
1538 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1539 Now ptrdiff_t, not int.
1540 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1541 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1542
1543 * process.c (Fnetwork_interface_list): Check for overflow
1544 in size calculation.
1545
1546 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1547
1548 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1549 overflow. Don't bother calling xmalloc when xrealloc will do.
1550
1551 * search.c (Freplace_match): Check for size calculation overflow.
1552 (Fset_match_data): Don't assume list lengths fit in 'int'.
1553
1554 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1555 for command line length. Do not attempt to address one before the
1556 beginning of an array, as that's not portable.
1557
1558 * term.c (max_frame_lines): Remove; unused.
1559 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1560 not int.
1561 (encode_terminal_code, calculate_costs): Check for size
1562 calculation overflow.
1563 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1564 table lengths and related sizes. Don't update size until alloc
1565 done. Redo calculations to avoid overflow.
1566 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1567
1568 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1569 subtracting pointers.
1570 (gobble_line): Check for overflow more carefully. Don't update size
1571 until alloc done.
1572
1573 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1574 Don't update size until alloc done.
1575 Redo size calculations to avoid overflow.
1576 Check for size calculation overflow.
0065d054 1577 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1578
1579 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1580 Use ptrdiff_t, not int, for sizes.
1581 (store_mode_line_noprop_char): Don't update size until alloc done.
1582
0065d054
PE
1583 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1584 Use ptrdiff_t, not int, for sizes.
1585 (Finternal_make_lisp_face, cache_face):
1586 Check for size calculation overflow.
1587 (cache_face): Treat size calculation overflows as if they were
1588 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1589
1590 * xfns.c (x_encode_text, x_set_name_internal)
1591 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1592 sizes, since they can exceed INT_MAX in size. Check for size
1593 calculation overflow.
1594
0065d054
PE
1595 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1596 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1597 Don't update size until alloc done.
1598
0065d054 1599 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1600 as sprintf is limited to int lengths.
1d526e2f 1601
252c5ee1
PE
1602 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1603 (X_LONG_MIN): New macros.
864d7ce7
PE
1604 Use them to make the following changes clearer.
1605 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1606 This change doesn't affect the value now, but it may help remind
1607 future maintainers not to raise the value too much later.
1608 (SELECTION_QUANTUM): Remove, replacing with ...
1609 (selection_quantum): ... new function, which avoids overflow.
1610 All uses changed.
1611 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1612 assumption that selection length fits in 'int'.
1613 (x_reply_selection_request, x_handle_selection_request)
1614 (x_get_window_property, receive_incremental_selection)
1615 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1616 (lisp_data_to_selection_data, clean_local_selection_data):
1617 Use ptrdiff_t, not int, to record length of selection.
1618 (x_reply_selection_request, x_get_window_property)
1619 (receive_incremental_selection, x_property_data_to_lisp):
1620 Redo calculations to avoid overflow.
1621 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1622 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1623 something.
1624 (x_get_window_property, receive_incremental_selection)
1625 (lisp_data_to_selection_data, x_property_data_to_lisp):
1626 Check for size-calculation overflow.
1627 (x_get_window_property, receive_incremental_selection)
1628 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1629 Don't store size until memory allocation succeeds.
1630 (x_get_window_property): Plug memory leak on memory exhaustion.
1631 Don't double-block input; malloc is safe here. Don't assume 2**34
1632 - 4 fits in unsigned long. Add an xassert to check
1633 XGetWindowProperty overflow. Be more careful about overflow
1634 calculations, and distinguish size from memory overflow better.
1635 (receive_incremental_selection): When tracing, don't assume
1636 unsigned int is less than INT_MAX.
1637 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1638 harmful) conversions of unsigned short to int.
1639 (lisp_data_to_selection_data): Don't assume that integers
1640 in the range -65535 through -1 fit in an X unsigned short.
1641 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1642 result parameters unless successful. Rely on cons_to_unsigned
1643 to report problems with elements; the old code wasn't right anyway.
1644 (x_check_property_data): Check for int overflow; we cannot use
1645 a wider type due to X limits.
1646 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1647
726e0ab1 1648 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1649
0065d054
PE
1650 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1651 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1652 (x_color_cells): Don't store size until memory allocation succeeds.
1653 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1654 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1655 (x_term_init): Don't assume length fits in int (sprintf is limited
1656 to int size).
bc18e09d 1657
ebfa62c0
PE
1658 Use ptrdiff_t for composition IDs.
1659 * character.c (lisp_string_width):
1660 * composite.c (composition_table_size, n_compositions)
1661 (get_composition_id, composition_gstring_from_id):
1662 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1663 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1664 * window.c (Frecenter):
1665 Use ptrdiff_t, not int, for composition IDs.
1666 * composite.c (get_composition_id): Check for integer overflow.
1667 * composite.h: Adjust prototypes to match the above changes.
1668
d3411f89
PE
1669 Use ptrdiff_t for hash table indexes.
1670 * category.c (hash_get_category_set):
1671 * ccl.c (ccl_driver):
1672 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1673 * coding.c (coding_system_charset_list, detect_coding_system):
1674 * coding.h (struct coding_system.id):
1675 * composite.c (get_composition_id, gstring_lookup_cache):
1676 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1677 * image.c (xpm_get_color_table_h):
1678 * lisp.h (hash_lookup, hash_put):
1679 * minibuf.c (Ftest_completion):
1680 Use ptrdiff_t for hash table indexes, not int (which is too
1681 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1682 32-bit --with-wide-int hosts).
1683
e097a6fa
PE
1684 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1685 Add a FIXME comment about memory leaks.
1686 (syms_of_charset): Don't assume xmalloc returns.
1687
5637687f
PE
1688 Don't assume that stated character widths fit in int.
1689 * character.c (Fchar_width, c_string_width, lisp_string_width):
1690 * character.h (CHAR_WIDTH):
1691 * indent.c (MULTIBYTE_BYTES_WIDTH):
1692 Use sanitize_char_width to avoid undefined and/or bad behavior
1693 with outlandish widths.
a66cfb1c 1694 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1695 now that we have two such functions. All uses changed.
1696 (sanitize_char_width): New inline function.
1697
a2271ba2
PE
1698 Don't assume that tab-width fits in int.
1699 * character.h (sanitize_width): New inline function.
1700 (SANE_TAB_WIDTH): New macro.
1701 (ASCII_CHAR_WIDTH): Use it.
1702 * indent.c (sane_tab_width): Remove. All uses replaced by
1703 SANE_TAB_WIDTH (current_buffer).
1704 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1705
18c52557
PE
1706 * fileio.c: Integer overflow issues with file modes.
1707 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1708
caeeedc1
PE
1709 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1710 Remove unreachable code.
1711 (read_hex, load_charset_map_from_file): Check for integer overflow.
1712
50849c52
PE
1713 * xterm.c: don't go over XClientMessageEvent limit
1714 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1715 (x_send_scroll_bar_event): Likewise. Check that the size does not
1716 exceed limits imposed by XClientMessageEvent, as well as the usual
1717 ptrdiff_t and size_t limits.
1718
b13995db
PE
1719 * keyboard.c: Overflow, signedness and related fixes.
1720 (make_lispy_movement): Use same integer type in forward decl
1721 that is used in the definition.
1722 (read_key_sequence, keyremap_step):
1723 Change bufsize argument back to int, undoing my 2011-03-30 change.
1724 We prefer signed types, and int is wide enough here.
1725 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1726 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1727 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1728 length, not size_t. Use ptrdiff_t for index, not int.
1729 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1730 possibility of integer overflow.
1731
13464394
PE
1732 Overflow, signedness and related fixes for images.
1733
1734 * dispextern.h (struct it.stack[0].u.image.image_id)
1735 (struct_it.image_id, struct image.id, struct image_cache.size)
1736 (struct image_cache.used, struct image_cache.ref_count):
1737 * gtkutil.c (update_frame_tool_bar):
1738 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1739 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1740 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1741 * nsmenu.m (update_frame_tool_bar):
1742 * xdisp.c (calc_pixel_width_or_height):
1743 * xfns.c (image_cache_refcount):
1744 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1745 on typical 64-bit hosts.
1746
1747 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1748 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1749 Omit unnecessary casts to int.
1750 (parse_image_spec): Check that integers fall into 'int' range
1751 when the callers expect that.
1752 (image_ascent): Redo ascent calculation to avoid int overflow.
1753 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1754 (lookup_image): Remove unnecessary tests.
1755 (xbm_image_p): Locals are now of int, not EMACS_INT,
1756 since parse_image_check makes sure they fit into int.
1757 (png_load, gif_load, svg_load_image):
1758 Prefer int to unsigned where either will do.
1759 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1760 old tiff_error_handler and tiff_warning_handler.
1761 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1762 stack buffer overflows. It uses only the features of vsnprintf
1763 that are common to both POSIX and native Microsoft.
1764 (tiff_error_handler, tiff_warning_handler): Use it.
1765 (tiff_load, gif_load, imagemagick_load_image):
1766 Don't assume :index value fits in 'int'.
1767 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1768 (imagemagick_load_image): Check that crop parameters fit into
1769 the integer types that MagickCropImage accepts. Don't assume
1770 Vimagemagick_render_type has a nonnegative value. Don't assume
1771 size_t fits in 'long'.
1772 (gs_load): Use printmax_t to print the widest integers possible.
1773 Check for integer overflow when computing image height and width.
1774
c11821d4
EZ
17752011-08-26 Eli Zaretskii <eliz@gnu.org>
1776
1777 * xdisp.c (redisplay_window): Don't force window start if point
1778 will be invisible in the resulting window. (Bug#9324)
1779
0c95fcf7
EZ
17802011-08-25 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1783 the display spec is of the form `(space ...)'.
1784 (handle_display_spec): Return the value returned by
1785 handle_single_display_spec, not just 1 or zero.
1786 (handle_single_display_spec): If the display spec is of the form
1787 `(space ...)', and specifies display in the text area, return 2
1788 rather than 1.
fee65a97 1789 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1790 accurately, and prefer exact match for point under bidi.
1791 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1792
1793 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1794 into disp_prop; all users changed.
1795
1796 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1797 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1798 for the text covered by the display property.
1799
e4ed06f1
CY
18002011-08-25 Chong Yidong <cyd@stupidchicken.com>
1801
1802 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1803 Change return value to nil.
1804 (Frecord_buffer): Delete unused function.
1805
f67cdd7f
EZ
18062011-08-24 Eli Zaretskii <eliz@gnu.org>
1807
5980d4c6
EZ
1808 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1809 buffers, return left-to-right.
8610fe8b
EZ
1810 (set_cursor_from_row): Consider candidate row a win if its glyph
1811 represents a newline and point is on that newline. Fixes cursor
1812 positioning on the newline at EOL of R2L text within L2R
1813 paragraph, and vice versa.
1814 (try_cursor_movement): Check continued rows, in addition to
1815 continuation rows. Fixes unwarranted scroll when point enters a
1816 continued line of R2L text within an L2R paragraph, or vice versa.
1817 (cursor_row_p): Consider the case of point being equal to
1818 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1819 from the end of a short line to the beginning of a continued line
1820 of R2L text within L2R paragraph.
1821 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1822 composed characters.
5980d4c6 1823
f67cdd7f
EZ
1824 * bidi.c (bidi_check_type): Use xassert.
1825 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1826 members.
1827
bca633fb
EZ
18282011-08-23 Eli Zaretskii <eliz@gnu.org>
1829
1830 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1831 a character.
1832
4a5885a7
CY
18332011-08-23 Chong Yidong <cyd@stupidchicken.com>
1834
1835 * nsfont.m (ns_otf_to_script): Fix typo.
1836
0902a04e
KH
18372011-08-22 Kenichi Handa <handa@m17n.org>
1838
1839 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1840 extra slot even if the purpose is char-code-property-table.
1841
1a2e6670
EZ
18422011-08-23 Eli Zaretskii <eliz@gnu.org>
1843
8ddde651
EZ
1844 * xdisp.c (redisplay_window): When computing centering_position,
1845 account for the height of the header line. (Bug#8874)
1846
425cc014
EZ
1847 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1848 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1849 candidate is selected by the mouse, and that candidate has a
1850 composed character under the mouse.
1851
1a2e6670
EZ
1852 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1853 coordinates reported by pos-visible-in-window-p for a composed
1854 character in column zero.
1855
8b76d6f8
SM
18562011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1857
1858 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1859
dac347dd
EZ
18602011-08-22 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1863 consider it a hit if to_charpos is anywhere in the range of the
1864 composed buffer positions.
1865
e013fb34
CY
18662011-08-22 Chong Yidong <cyd@stupidchicken.com>
1867
1868 * image.c (gif_load): Don't assume that each subimage has the same
1869 dimensions as the base image. Handle disposal method that is
1870 "undefined" by the gif spec (Bug#9335).
1871
bd1ba3e8
CY
18722011-08-20 Chong Yidong <cyd@stupidchicken.com>
1873
1874 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1875 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1876
54a1215b
EZ
18772011-08-19 Eli Zaretskii <eliz@gnu.org>
1878
823564e5
EZ
1879 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1880 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1881 from an Org mode buffer to a Speedbar frame.
1882
54a1215b
EZ
1883 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1884 a composition, take its buffer position from IT->cmp_it.charpos.
1885 Fixes cursor positioning at the beginning of a line that begins
1886 with a composed character.
1887
9778ebcc
EZ
18882011-08-18 Eli Zaretskii <eliz@gnu.org>
1889
0be6ee06
EZ
1890 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1891 character bidirectional type, use STRONG_L instead. Fixes crashes
1892 in a buffer produced by `describe-categories'.
1893
9778ebcc
EZ
1894 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1895 members before the level stack, so they would be saved and
1896 restored when copying iterator state. Fixes incorrect reordering
1897 around TABs covered by display properties.
1898
156bffbe
AS
18992011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1900
6b02f655 1901 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1902
72ad093b
CY
19032011-08-17 Chong Yidong <cyd@stupidchicken.com>
1904
1905 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1906 (internal_condition_case_2, internal_condition_case_n):
1907 Remove unnecessary aborts (Bug#9081).
72ad093b 1908
35774242
EZ
19092011-08-17 Eli Zaretskii <eliz@gnu.org>
1910
1911 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1912 has no `load' handler, try opening the file locally. (Bug#9311)
1913
db76dd85
KB
19142011-08-16 Ken Brown <kbrown@cornell.edu>
1915
1916 * gmalloc.c: Expand comment.
1917
b215eee5
EZ
19182011-08-16 Eli Zaretskii <eliz@gnu.org>
1919
1920 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1921 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1922
a4579d33
KB
19232011-08-16 Ken Brown <kbrown@cornell.edu>
1924
1925 Fix memory allocation problems in Cygwin build (Bug#9273).
1926
1927 * unexcw.c ( __malloc_initialized): Declare external variable.
1928 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1929
8b76d6f8
SM
1930 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1931 New variables.
a4579d33
KB
1932 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1933 dumped emacs.
1934 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1935 in the static heap.
1936 [CYGWIN] (special_realloc): New function.
1937 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1938 requests to realloc storage in the static heap.
1939
3ebec551
PE
19402011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * bidi.c (bidi_initialize): Remove unused local.
1943
9fd8be00
EZ
19442011-08-15 Eli Zaretskii <eliz@gnu.org>
1945
6b02f655
SM
1946 * bidimirror.h:
1947 * biditype.h: Remove file.
1948 * makefile.w32-in ($(BLD)/bidi.$(O)):
1949 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1950
1951 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1952
1953 * chartab.c: Improve commentary for the uniprop_table API.
1954
32413314
EZ
1955 * bidi.c (bidi_paragraph_init): Support zero value of
1956 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1957 (bidi_initialize): Use uniprop_table instead of including
1958 biditype.h and bidimirror.h.
32413314 1959
9fd8be00
EZ
1960 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1961 coordinates of the iterator when restoring from ppos_it.
1962 (Bug#9296)
1963
5cf2b69b
KH
19642011-08-14 Kenichi Handa <handa@m17n.org>
1965
1966 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1967 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1968
daf17d00
EZ
19692011-08-14 Eli Zaretskii <eliz@gnu.org>
1970
1971 * xdisp.c (move_it_in_display_line_to): Don't invoke
1972 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1973 ppos_it. Fixes vertical cursor motion when line beginning is
1974 covered by an image. (Bug#9296)
1975
08e3161a
JD
19762011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1977
1978 * nsterm.h (ns_run_ascript): Declare.
1979 (NSAPP_DATA2_RUNASSCRIPT): Define.
1980
1981 * nsfns.m (as_script, as_result, as_status): New static variables.
1982 (ns_run_ascript): New function.
5e617bc2 1983 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1984 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1985 the event loop. Get status from as_status (Bug#7276).
1986
1987 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1988 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1989 the event loop (Bug#7276).
1990
a3720aa2
AS
19912011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1992
1993 * gnutls.c (QCgnutls_bootprop_priority)
1994 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1995 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1996 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1997 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1998 (QCgnutls_bootprop_verify_hostname_error)
1999 (QCgnutls_bootprop_callbacks_verify): Rename from
2000 Qgnutls_bootprop_..., all uses changed.
2001
2002 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2003 uses changed.
2004
0a0d27fb
PE
20052011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2006
19d5c50c
PE
2007 * xfaces.c (Qframe_set_background_mode): Now static.
2008 * dispextern.h (Qframe_set_background_mode): Remove decl.
2009
0a0d27fb
PE
2010 * process.c (Fnetwork_interface_info): Declare local only if needed.
2011
377538cb
JD
20122011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2013
2014 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2015 (Fnetwork_interface_list): Allocate in increments of bytes instead
2016 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2017 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2018 sockaddr.
2019 (struct ifflag_def): notrailers is smart on OSX.
2020 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2021 Get hardware address with getifaddrs if available.
2022
08fff70c
EZ
20232011-08-12 Eli Zaretskii <eliz@gnu.org>
2024
2025 * xdisp.c (iterate_out_of_display_property): xassert that
2026 IT->position is set to within IT->object's boundaries. Break from
2027 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2028 when IT->position is set up wrongly due to some bug.
2029 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2030 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2031 entry. Force push_it to save on the stack the current
2032 buffer/string position, to be restored by pop_it. Fix flags in
2033 the iterator structure wrt the object coming from a display
2034 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2035 properties. (Bug#9284)
2036
7be1c708 20372011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2038
7be1c708
CY
2039 * fontset.c (fontset_get_font_group): Add proper type checks.
2040 (Bug#9172)
aac0c6e3 2041
7be1c708 20422011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2043
7be1c708
CY
2044 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2045 and LC_VERSION_MIN_MACOSX.
2046 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2047 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2048
97bb72a6
EZ
20492011-08-08 Eli Zaretskii <eliz@gnu.org>
2050
2051 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2052 no-display-properties-and-no-overlays under bidi display.
2053 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2054 properties and overlays.
97bb72a6 2055
d5617611
CY
20562011-08-08 Chong Yidong <cyd@stupidchicken.com>
2057
37e11a63
CY
2058 * editfns.c (Fset_time_zone_rule): Document relationship with the
2059 setenv function.
2060
d5617611
CY
2061 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2062 the font entity extracted from the cache (Bug#8109).
2063
58872834
CY
20642011-08-07 Chong Yidong <cyd@stupidchicken.com>
2065
2066 * composite.c (autocmp_chars): Don't reset point. That is done by
2067 restore_point_unwind (Bug#5984).
2068
75bfc667
JL
20692011-08-07 Juri Linkov <juri@jurta.org>
2070
2071 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2072 to show the arg `TIME' instead of `TIMEVAL'.
2073
d1410150
EZ
20742011-08-06 Eli Zaretskii <eliz@gnu.org>
2075
2076 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2077 display property strides EOL and includes a newline, as in
2078 longlines-mode. (Bug#9254)
75b771e4
EZ
2079 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2080 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2081
2082 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2083 is non-zero, even if the data buffer is NULL. Fixes a crash in
2084 vertical-motion with longlines-mode. (Bug#9254)
2085
35928349
EZ
20862011-08-05 Eli Zaretskii <eliz@gnu.org>
2087
ec7cc85b
EZ
2088 * bidi.c <bidi_cache_total_alloc>: Now static.
2089 (bidi_initialize): Initialize bidi_cache_total_alloc.
2090
8b76d6f8 2091 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2092 cache. (Bug#9221)
2093
2094 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2095 amount allocated this far in `bidi_cache_total_alloc'.
2096 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2097 non-zero, only free the data buffer without restoring the cache
2098 contents. All callers changed.
2099
2100 * dispextern.h (bidi_unshelve_cache): Update prototype.
2101
2102 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2103 (move_it_in_display_line, move_it_to)
2104 (move_it_vertically_backward, move_it_by_lines): Replace the call
2105 to xfree to an equivalent call to bidi_unshelve_cache.
2106 (move_it_in_display_line_to): Fix logic of returning
412b6358 2107 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2108
e2e2423b
EZ
21092011-08-05 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2112 came from a string character with a `cursor' property. (Bug#9229)
2113
ae9e757a
JD
21142011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2115
2116 * Makefile.in (LIB_PTHREAD): New variable.
2117 (LIBES): Add LIB_PTHREAD (Bug#9216).
2118
2119 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2120 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2121
213bd7f2
AS
21222011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2123
6b02f655 2124 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2125
99aaf75f
JD
21262011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2127
2128 * xterm.c (x_find_topmost_parent): New function.
2129 (x_set_frame_alpha): Find topmost parent window with
2130 x_find_topmost_parent and set the property there also (bug#9181).
2131 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2132
c74e9d86
PE
21332011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2134
2135 * callproc.c (Fcall_process): Avoid vfork clobbering
2136 the local vars buffer, coding_systems, current_dir.
2137
640c8776
SM
21382011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2139
2140 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2141
f26d0e4c
PE
21422011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2143
8a10d76c
PE
2144 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2145 so that it is not optimized away.
2146
f26d0e4c
PE
2147 * xdisp.c (compute_display_string_pos): Remove unused local.
2148
55439c61
EZ
21492011-08-02 Eli Zaretskii <eliz@gnu.org>
2150
2151 Fix slow cursor motion and scrolling in large buffers with
2152 selective display, like Org Mode buffers. (Bug#9218)
2153
2154 * dispextern.h (struct bidi_it): New member disp_prop_p.
2155
2156 * xdisp.c: Remove one-slot cache of display string positions.
2157 (compute_display_string_pos): Accept an additional argument
5e617bc2 2158 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2159 for a display string or property. If found, set DISP_PROP_P
2160 non-zero.
2161
2162 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2163 DISP_PROP_P, and pass it to compute_display_string_pos.
2164 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2165 non-zero. All callers of bidi_fetch_char changed.
2166
fb33fa43
SM
21672011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2168
2169 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2170
b099e063
DM
21712010-12-03 Don March <don@ohspite.net>
2172
2173 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2174 last character M-[char] is translated to ESC [char] (bug#7541).
2175
5cc7f7af
KH
21762011-08-02 Kenichi Handa <handa@m17n.org>
2177
d0fffa3f 2178 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2179
2180 * chartab.c (uniprop_table): Make it non-static.
2181
525d5e6e
EZ
21822011-08-01 Eli Zaretskii <eliz@gnu.org>
2183
2184 * xdisp.c (forward_to_next_line_start): Accept additional argument
2185 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2186 on the newline.
2187 (reseat_at_next_visible_line_start): Use the bidi iterator state
2188 returned by forward_to_next_line_start to restore the state of
2189 it->bidi_it after backing up to previous newline. (Bug#9212)
2190
31011111
AS
21912011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2192
2193 * regex.c (re_comp): Protoize.
2194 (re_exec): Fix return type.
2195 (regexec): Fix type of `ret'. (Bug#9203)
2196
476371c4
PE
21972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2198
e5d76069
PE
2199 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2200 This is needed if max-image-size is a floating-point number.
2201
9a79b20c
AS
22022011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2203
2204 * print.c (print_object): Print empty symbol as ##.
2205
2206 * lread.c (read1): Read ## as empty symbol.
2207
d8c2fa78
AA
22082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2209
2210 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2211 setting frame foreground color (Bug#9175).
2212 (x_set_background_color): Likewise.
2213
ffe57a7a
AA
2214 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2215 contents (Bug#9176).
2216 (EmacsTooltip -init): Remove bezels and add shadows to
2217 tooltip windows.
2218
bf3492a5
AA
2219 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2220 or scroll bar (Bug#8470).
2221
d55e9c53
AA
2222 * nsfont.m (nsfont_open): Remove assignment to voffset and
2223 unnecessary vars hshink, expand, hd, full_height, min_height.
2224 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2225
2226 * nsterm.h (nsfont_info): Remove voffset field.
2227
d8c2fa78 22282011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2229
2230 Implement strike-through and overline on NextStep (Bug#8863).
2231
2232 * nsfont.m (nsfont_open): Use underline position provided by font,
2233 instead of hard-coded value of 2.
2234 (nsfont_draw): Call ns_draw_text_decoration instead.
2235
2236 * nsterm.h: Add declaration for ns_draw_text_decoration.
2237
2238 * nsterm.m (ns_draw_text_decoration): New function for drawing
2239 underline, overline, and strike-through.
2240 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2241 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2242 accommodate underlining, etc.
4843aac3 2243
4cc60b9b
EZ
22442011-07-28 Eli Zaretskii <eliz@gnu.org>
2245
bc7ece87
EZ
2246 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2247 default.
4cc60b9b 2248
476371c4
PE
22492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2250
66606eea
PE
2251 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2252 Without this fix, if a signal arrives just after memory fills up,
2253 'malloc' might be invoked reentrantly.
2254
476371c4
PE
2255 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2256 In other words, assume that every image size is allowed, on non-X
2257 hosts. This assumption is probably wrong, but it lets Emacs compile.
2258
f3fcc40d
AS
22592011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2260
2261 * regex.c (re_iswctype): Convert return values to boolean.
2262
350c992f
EZ
22632011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2264
2265 * xdisp.c (compute_display_string_pos): Don't use cached display
2266 string position if the buffer had its restriction changed.
2267 (Bug#9184)
2268
5266b4bb
PE
22692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2270
2271 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2272
2573a837 22732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2274
41f55ccd 2275 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2276
39e378da
PE
2277 * bidi.c: Integer size and overflow fixes.
2278 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2279 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2280 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2281 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2282 (bidi_find_other_level_edge):
2283 Use ptrdiff_t instead of EMACS_INT where either will do.
2284 This works better on 32-bit hosts configured --with-wide-int.
2285 (bidi_cache_ensure_space): Check for size-calculation overflow.
2286 Use % rather than repeated addition, for better worst-case speed.
2287 Don't set bidi_cache_size until after xrealloc returns, because it
2288 might not return.
2289 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2290 (bidi_cache_ensure_space): Also check that the bidi cache size
2291 does not exceed that of the largest Lisp string or buffer. See Eli
2292 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2293
5e927815
PE
2294 * alloc.c (__malloc_size_t): Remove.
2295 All uses replaced by size_t. See Andreas Schwab's note
2296 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2297
ca4aa935
PE
2298 * image.c: Improve checking for integer overflow.
2299 (check_image_size): Assume that f is nonnull, since
2300 it is always nonnull in practice. This is one less thing to
2301 worry about when checking for integer overflow later.
2302 (x_check_image_size): New function, which checks for integer
2303 overflow issues inside X.
2304 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2305 This removes the need for a memory_full check.
2306 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2307 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2308 (xbm_read_bitmap_data): Change locals back to 'int', since
2309 their values must fit in 'int'.
2310 (xpm_load_image, png_load, tiff_load):
2311 Invoke x_create_x_image_and_pixmap earlier,
2312 to avoid much needless work if the image is too large.
2313 (tiff_load): Treat overly large images as if
2314 x_create_x_image_and_pixmap failed, not as malloc failures.
2315 (gs_load): Use x_check_image_size.
2316
5f8f9cc2
PE
2317 * gtkutil.c: Omit integer casts.
2318 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2319 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2320
5adf60bc
PE
2321 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2322
c8907a93
PE
2323 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2324 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2325 would wrongly return t on a 64-bit host.
2326
e3c25c68
PE
2327 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2328 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2329 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2330 and therefore cause GCC to emit a bogus diagnostic in some cases.
2331
3f791afe
PE
2332 * image.c: Integer signedness and overflow and related fixes.
2333 This is not an exhaustive set of fixes, but it's time to
2334 record what I've got.
2335 (lookup_pixel_color, check_image_size): Remove redundant decls.
2336 (check_image_size): Don't assume that arbitrary EMACS_INT values
2337 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2338 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2339 (tiff_load, imagemagick_load_image):
2340 Check for overflow in size calculations.
2341 (x_create_x_image_and_pixmap): Remove unnecessary test for
2342 xmalloc returning NULL; that can't happen.
2343 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2344 (xpm_color_bucket): Use better integer hashing function.
2345 (xpm_cache_color): Don't possibly over-allocate memory.
2346 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2347 (gif_memory_source):
2348 Use ptrdiff_t, not int or size_t, to record sizes.
2349 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2350 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2351 either works, as we prefer signed integers.
2352 (tiff_read_from_memory, tiff_write_from_memory):
2353 Return tsize_t, not size_t, since that's what the TIFF API wants.
2354 (tiff_read_from_memory): Don't fail simply because the read would
2355 go past EOF; instead, return a short read.
2356 (tiff_load): Omit no-longer-needed casts.
2357 (Fimagemagick_types): Don't assume size fits into 'int'.
2358
3cc5a532
PE
2359 Improve hashing quality when configured --with-wide-int.
2360 * fns.c (hash_string): New function, taken from sxhash_string.
2361 Do not discard information about ASCII character case; this
2362 discarding is no longer needed.
2363 (sxhash-string): Use it. Change sig to match it. Caller changed.
2364 * lisp.h: Declare it.
2365 * lread.c (hash_string): Remove, since we now use fns.c's version.
2366 The fns.c version returns a wider integer if --with-wide-int is
2367 specified, so this should help the quality of the hashing a bit.
2368
b312a492
PE
2369 * emacs.c: Integer overflow minor fix.
2370 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2371 Define only if GNU_LINUX.
2372 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2373
dfd153ae
PE
2374 * dispnew.c: Integer signedness and overflow fixes.
2375 Remove unnecessary forward decls, that were a maintenance hassle.
2376 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2377 All uses changed.
2378 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2379 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2380 (prepare_desired_row, line_draw_cost):
2381 Use int, not unsigned, where either works.
2382 (save_current_matrix, restore_current_matrix):
2383 Use ptrdiff_t, not size_t, where either works.
2384 (init_display): Check for overflow more accurately, and without
2385 relying on undefined behavior.
2386
a81d11a3
PE
2387 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2388 Remove, replacing with the new symbols in lisp.h. All uses changed.
2389 * fileio.c (make_temp_name):
2390 * filelock.c (lock_file_1, lock_file):
2391 * xdisp.c (message_dolog):
2392 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2393 Use pMd etc. instead.
2394 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2395 replacing the pWIDE etc. symbols removed from editfns.c.
2396
3300e6fd
PE
2397 * keyboard.h (num_input_events): Now uintmax_t.
2398 This is (very slightly) less likely to mess up due to wraparound.
2399 All uses changed.
2400
fd05c7e9
PE
2401 * buffer.c: Integer signedness fixes.
2402 (alloc_buffer_text, enlarge_buffer_text):
2403 Use ptrdiff_t rather than size_t when either will do, as we prefer
2404 signed integers.
2405
903fe15d
PE
2406 * alloc.c: Integer signedness and overflow fixes.
2407 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2408 (__malloc_size_t): Default to size_t, not to int.
2409 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2410 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2411 Prefer ptrdiff_t to size_t when either would do, as we prefer
2412 signed integers.
2413 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2414 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2415 Now const. Initialize with values that are in range even if char
2416 is signed.
2417 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2418 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2419 These functions do the right thing with sizes > 2**32.
2420 (check_depth): Now ptrdiff_t, not int.
2421 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2422 Adjust to new way of storing sizes. Check for size overflow bugs
2423 in rest of code.
2424 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2425 slightly wrong anyway, as it missed one instance of
2426 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2427 (refill_memory_reserve): Omit needless cast to size_t.
2428 (mark_object_loop_halt): Mark as externally visible.
2429
ac82cc6a
PE
2430 * xselect.c: Integer signedness and overflow fixes.
2431 (Fx_register_dnd_atom, x_handle_dnd_message):
2432 Use ptrdiff_t, not size_t, since we prefer signed.
2433 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2434 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2435 x_dnd_atoms_size and x_dnd_atoms_length.
2436
c2d1e36d
PE
2437 * doprnt.c: Prefer signed to unsigned when either works.
2438 * eval.c (verror):
2439 * doprnt.c (doprnt):
2440 * lisp.h (doprnt):
2441 * xdisp.c (vmessage):
2442 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2443 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2444 prefer signed arithmetic to avoid comparison confusion.
2445 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2446 but is a bit tricky.
2447
0e926e56
PE
2448 Assume freestanding C89 headers, string.h, stdlib.h.
2449 * data.c, doprnt.c, floatfns.c, print.c:
2450 Include float.h unconditionally.
2451 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2452 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2453 * regex.c: Likewise for stddef.h, string.h.
2454 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2455 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2456 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2457 (STDC_HEADERS): Remove obsolete defines.
2458 * sysdep.c: Include limits.h unconditionally.
2459
9cfdb3ec
PE
2460 Assume support for memcmp, memcpy, memmove, memset.
2461 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2462 * regex.c (memcmp, memcpy):
2463 Remove; we assume C89 now.
2464
2465 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2466 (__malloc_safe_bcopy): Remove; no longer needed.
2467
cf950e6b 2468 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2469 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2470 well either way, and we prefer signed to unsigned.
2471
dbf38e02
LMI
24722011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2473
2474 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2475 closes the connection while we're reading (bug#9182).
2476
d6f0886c 24772011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2478
d6f0886c
JD
2479 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2480 are specified (Bug#9168).
24e0f6b1 2481
2eb1f9e6
PE
24822011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2485 Found by GCC static checking and --with-wide-int on a 32-bit host.
2486
22381272 24872011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2488
2489 * xdisp.c (compute_display_string_pos): Fix logic of caching
2490 previous display string position. Initialize cached_prev_pos to
2491 -1. Fixes slow-down at the beginning of a buffer.
2492
f25e39b4
EZ
24932011-07-24 Eli Zaretskii <eliz@gnu.org>
2494
2495 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2496 for attrs[LFACE_FONTSET_INDEX].
2497
04c4b52e
PE
24982011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 * xml.c (parse_region): Remove unused local
2501 that was recently introduced.
2502
c1734fbd
EZ
25032011-07-23 Eli Zaretskii <eliz@gnu.org>
2504
be18c5a5
EZ
2505 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2506 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2507
c1734fbd
EZ
2508 * xdisp.c (move_it_in_display_line_to): Record the best matching
2509 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2510 exit if none of the characters scanned was an exact match.
2511 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2512 when exact match is impossible due to invisible text, and the
2513 lines are truncated.
2514
a258d627
JD
25152011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2516
2517 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2518 for OSX >= 10.7.
2519
b6d5a689
EZ
25202011-07-22 Eli Zaretskii <eliz@gnu.org>
2521
0f74f785
EZ
2522 Fix a significant slow-down of cursor motion with C-n, C-p,
2523 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2524 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2525 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2526 (next_element_from_buffer): Call compute_stop_pos_backwards to
2527 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2528 base_level_stop.
2529 (reseat): Don't look for prev_stop, as that could mean a very long
2530 run.
2531 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2532 <cached_disp_overlay_modiff>: Cache for last found display string
2533 position.
551918c1 2534 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2535 about the same buffer in the same area of character positions, and
2536 the buffer wasn't changed since the time the display string
2537 position was cached.
551918c1 2538
b2d0c91a
EZ
25392011-07-22 Eli Zaretskii <eliz@gnu.org>
2540
2541 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2542 is an integer, which is important for empty lines. (Bug#9149)
2543
043604ee
CY
25442011-07-22 Chong Yidong <cyd@stupidchicken.com>
2545
2546 * frame.c (Fmodify_frame_parameters): In tty case, update the
2547 default face if necessary (Bug#4238).
2548
da4adb04
CY
25492011-07-21 Chong Yidong <cyd@stupidchicken.com>
2550
2551 * editfns.c (Fstring_to_char): No need to explain what a character
2552 is in the docstring (Bug#6576).
2553
9abd0532
LMI
25542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2555
2556 * xml.c (parse_region): Make sure we always return a tree.
2557
36881d16
HK
25582011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2559
2560 * xml.c (parse_region): If a document contains only comments,
2561 return that, too.
2562
1e98674d
LMI
25632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2564
2565 * xml.c (make_dom): Return comments, too.
2566
590bd467
PE
25672011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 Port to OpenBSD.
2570 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2571 and the surrounding thread.
2572 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2573 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2574 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2575 timer goes off.
2576 * s/openbsd.h (BROKEN_SIGIO): Define.
2577 * unexelf.c (unexec) [__OpenBSD__]:
2578 Don't update the .mdebug section of the Alpha COFF symbol table.
2579
f41628b2
LMI
25802011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2581
2582 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2583 (bug#8460).
2584
b59b67c5
PE
25852011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2586
15e3a074
PE
2587 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2588 This fixes some race conditions on the permissions of any newly
2589 created file.
2590
41bed37d
PE
2591 * alloc.c (valid_pointer_p): Use pipe, not open.
2592 This fixes some permissions issues when debugging.
2593
b59b67c5
PE
2594 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2595 If fchown fails to set both uid and gid, try to set just gid,
2596 as that is sometimes allowed. Adjust the file's mode to eliminate
2597 setuid or setgid bits that are inappropriate if fchown fails.
2598
925a6be7
SM
25992011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2600
2601 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2602 to compare Lisp_Objects.
2603 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2604 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2605 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2606
52968808
AS
26072011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2608
0a6a104b
AS
2609 * lread.c (read_integer): Unread even EOF character.
2610 (read1): Likewise. Properly record start position of symbol.
2611
52968808
AS
2612 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2613 symbol character follows.
2614
9e381cdd
PE
26152011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2618 This works around a problem with the previous change to Fcopy_file.
2619 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2620 and without this change, GCC might complain about discarding
2621 fchown's return value.
2622
b5641435
JB
26232011-07-16 Juanma Barranquero <lekktu@gmail.com>
2624
2625 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2626
a8031457
PE
26272011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2630
dd889327
LMI
26312011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2632
750c33f7
LMI
2633 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2634 it's used from the C level.
2635
dd889327
LMI
2636 * process.c: Use the same condition for POLL_FOR_INPUT in both
2637 keyboard.c and process.c (bug#1858).
2638
87e86684
LM
26392011-07-09 Lawrence Mitchell <wence@gmx.li>
2640
2641 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2642 (Fgnutls_boot): Use it.
2643
64348f40
AS
26442011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2645
2646 * doc.c (Fsubstitute_command_keys): Revert last change.
2647
1d698799
LMI
26482011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2649
f863868c
LMI
2650 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2651 quotes the next character, and doesn't affect other longer
2652 sequences (bug#8935).
2653
1d698799
LMI
2654 * lread.c (syms_of_lread): Clarify that is isn't only
2655 `eval-buffer' and `eval-defun' that's affected by
2656 `lexical-binding' (bug#8460).
2657
aa4b6df6
EZ
26582011-07-15 Eli Zaretskii <eliz@gnu.org>
2659
2660 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2661 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2662
5d856da6
PE
26632011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2664
ad6042bb
PE
2665 Fix minor problems found by static checking.
2666 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2667 (elsz): Now a signed constant, not a size_t var. We prefer signed
2668 types to unsigned, to avoid integer comparison confusion. Without
2669 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2670 "cannot optimize loop, the loop counter may overflow", a symptom
2671 of the confusion.
f00bbb22 2672 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2673 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2674
6468f31c
LMI
26752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2676
49080b10
LMI
2677 * search.c (Fre_search_backward): Mention `case-fold-search' in
2678 all the re_search_* functions (bug#8138).
2679
6468f31c
LMI
2680 * keyboard.c (Fopen_dribble_file): Document when the file is
2681 closed (bug#8056).
2682
c965adc5
EZ
26832011-07-14 Eli Zaretskii <eliz@gnu.org>
2684
df9733bf
EZ
2685 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2686 bidi_cache_idx.
2687
0bb23927
EZ
2688 Support bidi reordering of display and overlay strings.
2689 * xdisp.c (compute_display_string_pos)
2690 (compute_display_string_end): Accept additional argument STRING.
2691 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2692 (reseat_to_string): Initialize bidi_it->string.s and
2693 bidi_it->string.schars.
2694 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2695 NULL (avoids a crash in bidi_paragraph_init).
2696 Initialize itb.string.lstring.
0bb23927
EZ
2697 (init_iterator): Call bidi_init_it only of a valid
2698 buffer position was specified. Initialize paragraph_embedding to
2699 L2R.
2700 (reseat_to_string): Initialize the bidi iterator.
2701 (display_string): If we need to ignore text properties of
2702 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2703 original value of -1 will not work with bidi.)
2704 (compute_display_string_pos): First arg is now struct
2705 `text_pos *'; all callers changed. Support display properties on
2706 Lisp strings.
2707 (compute_display_string_end): Support display properties on Lisp
2708 strings.
2709 (init_iterator, reseat_1, reseat_to_string): Initialize the
2710 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2711 when iterating on a string not from display properties).
640c8776
SM
2712 (compute_display_string_pos, compute_display_string_end):
2713 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2714 arrow keys.
2715 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2716 base_level_stop; instead, set base_level_stop to BEGV.
2717 Fixes crashes in vertical-motion.
0bb23927
EZ
2718 (next_element_from_buffer): Improve commentary for when
2719 the iterator is before prev_stop.
2720 (init_iterator): Initialize bidi_p from the default value of
2721 bidi-display-reordering, not from buffer-local value. Use the
2722 buffer-local value only if initializing for buffer iteration.
2723 (handle_invisible_prop): Support invisible properties on strings
2724 that are being bidi-reordered.
2725 (set_iterator_to_next): Support bidi reordering of C strings and
2726 Lisp strings.
2727 (next_element_from_string): Support bidi reordering of Lisp
2728 strings.
2729 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2730 (display_string): Support display of R2L glyph rows.
2731 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2732 (init_iterator): Don't initialize it->bidi_p for strings
2733 here.
2734 (reseat_to_string): Initialize it->bidi_p for strings here.
2735 (next_element_from_string, next_element_from_c_string)
2736 (next_element_from_buffer): Add xassert's for correspondence
2737 between IT's object being iterated and it->bidi_it.string
2738 structure.
2739 (face_before_or_after_it_pos): Support bidi iteration.
2740 (next_element_from_c_string): Handle the case of the first string
2741 character that is not the first one in the visual order.
2742 (get_visually_first_element): New function, refactored from common
2743 parts of next_element_from_buffer, next_element_from_string, and
2744 next_element_from_c_string.
2745 (tool_bar_lines_needed, redisplay_tool_bar)
2746 (display_menu_bar): Force left-to-right direction. Add a FIXME
2747 comment for making that be controlled by a user option.
2748 (push_it, pop_it): Save and restore the state of the
2749 bidi iterator. Save and restore the bidi_p flag.
2750 (pop_it): Iterate out of display property for string iteration as
2751 well.
2752 (iterate_out_of_display_property): Support iteration over strings.
2753 (handle_single_display_spec): Set up it->bidi_it for iteration
2754 over a display string, and call bidi_init_it.
2755 (handle_single_display_spec, next_overlay_string)
2756 (get_overlay_strings_1, push_display_prop): Set up the bidi
2757 iterator for displaying display or overlay strings.
2758 (forward_to_next_line_start): Don't use the shortcut if
2759 bidi-iterating.
2760 (back_to_previous_visible_line_start): If handle_display_prop
2761 pushed the iterator stack, restore the internal state of the bidi
2762 iterator by calling bidi_pop_it same number of times.
2763 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2764 and we are bidi-iterating, don't decrement the iterator position;
2765 instead, set the first_elt flag in the bidi iterator, to produce
2766 the same effect.
2767 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2768 (push_display_prop): xassert that we are iterating a buffer.
2769 (push_it, pop_it): Save and restore paragraph_embedding member.
2770 (handle_single_display_spec, next_overlay_string)
2771 (get_overlay_strings_1, reseat_1, reseat_to_string)
2772 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2773 correctly. Don't assume unibyte strings are not bidi-reordered.
2774 (compute_display_string_pos)
2775 (compute_display_string_end): Fix handling the case of C string.
2776 (push_it, pop_it): Save and restore from_disp_prop_p.
2777 (handle_single_display_spec, push_display_prop): Set the
2778 from_disp_prop_p flag.
2779 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2780 (pop_it): Call iterate_out_of_display_property only if we are
2781 popping after iteration over a string that came from a display
2782 property. Fix a typo in popping stretch info. Add an assertion
2783 for verifying that the iterator position is in sync with the bidi
2784 iterator.
2785 (handle_single_display_spec, get_overlay_strings_1)
2786 (push_display_prop): Fix initialization of paragraph direction for
2787 string when that of the parent object is not yet determined.
2788 (reseat_1): Call bidi_init_it to resync the bidi
2789 iterator with IT's position. (Bug#7616)
2790 (find_row_edges): If ROW->start.pos gives position
2791 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2792 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2793 Reset the from_disp_prop_p flag.
2794 (SAVE_IT, RESTORE_IT): New macros.
2795 (pos_visible_p, face_before_or_after_it_pos)
2796 (back_to_previous_visible_line_start)
2797 (move_it_in_display_line_to, move_it_in_display_line)
2798 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2799 (try_scrolling, redisplay_window, display_line): Use them when
2800 saving a temporary copy of the iterator and restoring it back.
2801 (back_to_previous_visible_line_start, reseat_1)
2802 (init_iterator): Empty the bidi cache "stack".
2803 (move_it_in_display_line_to): If iterator ended up at
2804 EOL, but we never saw any buffer positions smaller than
2805 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2806 motion in bidi-reordered lines.
2807 (move_it_in_display_line_to): Record prev_method and prev_pos
2808 immediately before the call to set_iterator_to_next. Fixes cursor
2809 motion in bidi-reordered lines with stretch glyphs and strings
2810 displayed in margins. (Bug#8133) (Bug#8867)
2811 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2812 TO_CHARPOS.
640c8776
SM
2813 (pos_visible_p): Support positions in bidi-reordered lines.
2814 Save and restore bidi cache.
0bb23927
EZ
2815
2816 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2817 (bidi_paragraph_info): Delete unused struct.
2818 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2819 (bidi_cache_start): New variable.
2820 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2821 to zero.
2822 (bidi_cache_fetch_state, bidi_cache_search)
2823 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2824 (bidi_cache_find, bidi_peek_at_next_level)
2825 (bidi_level_of_next_char, bidi_find_other_level_edge)
2826 (bidi_move_to_visually_next): Compare cache index with
2827 bidi_cache_start rather than with zero.
2828 (bidi_fetch_char): Accept new argument STRING; all callers
2829 changed. Support iteration over a string. Support strings with
2830 display properties. Support unibyte strings. Fix the type of
2831 `len' according to what STRING_CHAR_AND_LENGTH expects.
2832 (bidi_paragraph_init, bidi_resolve_explicit_1)
2833 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2834 (bidi_level_of_next_char, bidi_move_to_visually_next):
2835 Support iteration over a string.
0bb23927
EZ
2836 (bidi_set_sor_type, bidi_resolve_explicit_1)
2837 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2838 can now be zero (for strings); special values 0 and -1 were
2839 changed to -1 and -2, respectively.
2840 (bidi_char_at_pos): New function.
2841 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2842 Call it instead of FETCH_MULTIBYTE_CHAR.
2843 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2844 initialized to valid values.
2845 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2846 values.
2847 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2848 the test for valid cached positions. Fix the logic for looking up
2849 the sentinel state in the cache. GCPRO the Lisp string we are
2850 iterating.
2851 (bidi_push_it, bidi_pop_it): New functions.
2852 (bidi_initialize): Initialize the bidi cache start stack pointer.
2853 (bidi_cache_ensure_space): New function, refactored from part of
2854 bidi_cache_iterator_state. Don't assume the required size is just
2855 one BIDI_CACHE_CHUNK away.
2856 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2857 (bidi_count_bytes, bidi_char_at_pos): New functions.
2858 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2859 always valid if bidi_cache_idx is valid.
2860 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2861 is valid if it's going to be used.
2862 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2863 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2864 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2865 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2866 (bidi_find_other_level_edge, bidi_cache_start_stack):
2867 All variables related to cache indices are now EMACS_INT.
c965adc5 2868
0bb23927
EZ
2869 * dispextern.h (struct bidi_string_data): New structure.
2870 (struct bidi_it): New member `string'. Make flag members be 1-bit
2871 fields, and put them last in the struct.
640c8776
SM
2872 (compute_display_string_pos, compute_display_string_end):
2873 Update prototypes.
0bb23927
EZ
2874 (bidi_push_it, bidi_pop_it): Add prototypes.
2875 (struct iterator_stack_entry): New members bidi_p,
2876 paragraph_embedding, and from_disp_prop_p.
2877 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2878 (bidi_shelve_cache, bidi_unshelve_cache):
2879 Declare prototypes.
0bb23927
EZ
2880
2881 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2882 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2883 and vector-like objects.
2884
2885 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2886 cache around display iteration.
2887
2888 * window.c (Fwindow_end, window_scroll_pixel_based)
2889 (displayed_window_lines, Frecenter): Save and restore the bidi
2890 cache around display iteration.
2891
3bbd2265
LMI
28922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2893
2894 * editfns.c (Fdelete_region): Clarify the use of the named
2895 parameters (bug#6788).
2896
adc47434
MR
28972011-07-14 Martin Rudalics <rudalics@gmx.at>
2898
2899 * indent.c (Fvertical_motion): Set and restore w->pointm when
2900 saving and restoring the window's buffer (Bug#9006).
2901
837c31f8
LMI
29022011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2903
2904 * editfns.c (Fstring_to_char): Clarify just what is returned
2905 (bug#6576). Text by Eli Zaretskii.
2906
ac389d0c
JB
29072011-07-13 Juanma Barranquero <lekktu@gmail.com>
2908
2909 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2910
0be0ce47
EZ
29112011-07-13 Eli Zaretskii <eliz@gnu.org>
2912
2913 * buffer.c (mmap_find): Fix a typo.
2914
cd18e7e3
JB
29152011-07-13 Johan Bockgård <bojohan@gnu.org>
2916
2917 Fix execution of x selection hooks.
2918 * xselect.c (Qx_lost_selection_functions)
2919 (Qx_sent_selection_functions): New vars.
2920 (syms_of_xselect): DEFSYM them.
2921 (x_handle_selection_request): Pass Qx_sent_selection_functions
2922 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2923 (x_handle_selection_clear,x_clear_frame_selections):
2924 Pass Qx_lost_selection_functions rather than
2925 Vx_lost_selection_functions to Frun_hook_with_args.
2926
47ea7f44
PE
29272011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2928
ac389d0c 2929 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2930 The old code sometimes used this field without initializing it.
2931
47ea7f44
PE
2932 * alloc.c (gc_sweep): Don't read past end of array.
2933 In theory, the old code could also have corrupted Emacs internals,
2934 though it'd be very unlikely.
2935
bc985c87
AS
29362011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2937
2938 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2939 argument. (Bug#4026)
bc985c87 2940
0cf34688
LMI
29412011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2942
b3dadd76
LMI
2943 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2944 key" (bug#4257).
2945
0cf34688
LMI
2946 * window.c (Fset_window_start): Doc fix (bug#4199).
2947 (Fset_window_hscroll): Ditto.
2948
270768cd
PE
29492011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2950
077e3dda 2951 Fix minor new problems caught by GCC 4.6.1.
270768cd 2952 * term.c (init_tty): Remove unused local.
490011a6 2953 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2954 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2955 not used otherwise.
270768cd 2956
b1f58454
CY
29572011-07-12 Chong Yidong <cyd@stupidchicken.com>
2958
2959 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2960
22b9578d
LMI
29612011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2962
6e70ab07
LMI
2963 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2964 are the mini-buffer and the echo area (bug#3320).
2965
22b9578d
LMI
2966 * term.c (init_tty): Remove support for supdup, c10 and perq
2967 terminals, which are no longer supported (bug#1482).
2968
8974cc9f
JB
29692011-07-10 Johan Bockgård <bojohan@gnu.org>
2970
2971 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2972
a560d974
JD
29732011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2974
2975 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2976 for non-popups (Bug#3642).
2977
1dae0f0a
AS
29782011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2979
268c2c36 2980 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2981 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2982 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2983 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2984 * data.c (fmod): Likewise.
2985 * dispnew.c (swap_glyphs_in_rows): Likewise.
2986 * emacs.c (memory_warning_signal): Likewise.
2987 * floatfns.c (float_error): Likewise.
2988 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2989 (otf_open, font_otf_capability, generate_otf_features)
2990 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2991 Likewise.
2992 * image.c (pbm_read_file): Likewise.
2993 * indent.c (string_display_width): Likewise.
2994 * intervals.c (check_for_interval, search_for_interval)
2995 (inc_interval_count, count_intervals, root_interval)
2996 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2997 * lread.c (defalias): Likewise.
268c2c36 2998 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2999 * regex.c (set_image_of_range_1, set_image_of_range)
3000 (regex_grow_registers): Likewise.
3001 * sysdep.c (strerror): Likewise.
3002 * termcap.c (valid_filename_p, tprint, main): Likewise.
3003 * tparam.c (main): Likewise.
3004 * unexhp9k800.c (run_time_remap, save_data_space)
3005 (update_file_ptrs, read_header, write_header, calculate_checksum)
3006 (copy_file, copy_rest, display_header): Likewise.
3007 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3008 Likewise.
3009 * xdisp.c (check_it): Likewise.
3010 * xfaces.c (register_color, unregister_color, unregister_colors):
3011 Likewise.
3012 * xfns.c (print_fontset_result): Likewise.
3013 * xrdb.c (member, fatal, main): Likewise.
3014
99033785
PE
30152011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3016
3017 Fix minor problems found by static checking (Bug#9031).
3018 * chartab.c (char_table_set_range, map_sub_char_table):
3019 Remove unused locals.
3020 (uniprop_table): Now static.
3021 * composite.c (_work_char): Remove unused static var.
3022
9cb2ac56
JB
30232011-07-09 Juanma Barranquero <lekktu@gmail.com>
3024
3025 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3026
f25661f0
JD
30272011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3028
3029 * gtkutil.c (qttip_cb): Remove code without function.
3030
8278c4fe
EZ
30312011-07-09 Eli Zaretskii <eliz@gnu.org>
3032
3033 * w32.c (pthread_sigmask): New stub.
3034
1692ae2d 30352011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3036
8a6ebd58 3037 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3038 sigprocmask is portable only for single-threaded applications, and
3039 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3040 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3041 (LIBES): Use it.
3042 * callproc.c (Fcall_process):
3043 * process.c (create_process):
3044 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3045 Use pthread_sigmask, not sigprocmask.
123403e4 3046
1b854618
JD
30472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3048
3049 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3050 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3051 wrong (Bug#8591).
3052
3fe4b549
JD
30532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3054
0ce7e563
JD
3055 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3056 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3057 (xg_hide_tooltip): Fix comment.
3058
3fe4b549
JD
3059 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3060 in registerServicesMenuSendTypes.
3061 (validRequestorForSendType): Don't check ns_return_types.
3062
3063 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3064 ns_return_type.
3065
5df75e47
JR
30662011-07-08 Jason Rumney <jasonr@gnu.org>
3067
22610910
JR
3068 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3069 SH_SHOW for hidden windows (Bug#5482).
3070
5df75e47
JR
3071 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3072 frame struct members of non-existent frames (Bug#6284).
3073
699c10bd
JD
30742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3075
4393663b
JD
3076 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3077 variable firstTime not needed on OSX >= 10.6.
3078 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3079 >= 10.5. Use setKnobProportion, setDoubleValue.
3080
3081 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3082 (MAC_OS_X_VERSION_10_5): Define if not defined.
3083 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3084 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3085 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3086
3087 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3088 cString and lossyCString on OSX >= 10.4
3089
58179cce 3090 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3091 sizeToFit on OSX >= 10.2.
3092
3093 * nsimage.m (allocInitFromFile): Don't use deprecated method
3094 bestRepresentationForDevice on OSX >= 10.6.
3095
3096 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3097 to avoid warning.
3098
3099 * emacs.c: Declare unexec_init_emacs_zone.
3100
a63e0781
JD
3101 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3102
699c10bd
JD
3103 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3104
3105 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3106 on svcsMenu (Bug#8842).
3107
3108 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3109 ns_return_types.
3110 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3111
3112 * nsterm.m (QUTF8_STRING): Declare.
3113 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3114 (validRequestorForSendType): Return type is (id).
3115 Change indexOfObjectIdenticalTo to indexOfObject.
3116 Check if we have local selection before returning self (Bug#8842).
3117 (writeSelectionToPasteboard): Put local selection into paste board
3118 if we have a local selection (Bug#8842).
3119 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3120
3121 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3122 (ns_get_local_selection): Declare.
3123
54e10184
LMI
31242011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3125
9888ff71
LMI
3126 * keymap.c (describe_map_tree): Don't insert a double newline at
3127 the end of the buffer (bug#1169) and return whether we inserted
3128 something.
3129
54e10184
LMI
3130 * callint.c (Fcall_interactively): Change "reading args" to
3131 "providing args" to try to clarify what it does (bug#1010).
3132
15fa4783
KH
31332011-07-07 Kenichi Handa <handa@m17n.org>
3134
3135 * composite.c (composition_compute_stop_pos): Ignore a static
3136 composition starting before CHARPOS (Bug#8915).
3137
3138 * xdisp.c (handle_composition_prop): Likewise.
3139
a8815b00
EZ
31402011-07-07 Eli Zaretskii <eliz@gnu.org>
3141
3142 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3143 (Bug#9015)
3144
ef7b981d 31452011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3146
3147 * character.h (unicode_category_t): New enum type.
3148
3149 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3150 (Qchar_code_property_table): New variable.
3151 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3152 (UNIPROP_COMPRESSED_FORM_P): New macros.
3153 (char_table_ascii): Uncompress the compressed values.
3154 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3155 Uncompress the compressed values.
ac389d0c 3156 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3157 (char_table_ref_and_range): Uncompress the compressed values.
3158 (sub_char_table_set): New arg is_uniprop. Callers changed.
3159 Uncompress the compressed values.
3160 (sub_char_table_set_range): Args changed. Callers changed.
3161 (char_table_set_range): Adjuted for the above change.
3162 (map_sub_char_table): Delete args default_val and parent. Add arg
3163 top. Give decoded values to a Lisp function.
640c8776 3164 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3165 values to a Lisp function. Gcpro more variables.
3166 (uniprop_table_uncompress)
3167 (uniprop_decode_value_run_length): New functions.
3168 (uniprop_decoder, uniprop_decoder_count): New variables.
3169 (uniprop_get_decoder, uniprop_encode_value_character)
3170 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3171 New functions.
3172 (uniprop_encoder, uniprop_encoder_count): New variables.
3173 (uniprop_get_encoder, uniprop_table)
3174 (Funicode_property_table_internal, Fget_unicode_property_internal)
3175 (Fput_unicode_property_internal): New functions.
3176 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3177 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3178 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3179 char-code-property-alist.
3180
640c8776 3181 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3182 Vunicode_category_table.
3183
640c8776 3184 * font.c (font_range): Adjust for the change of
c805dec0
KH
3185 Vunicode_category_table.
3186
76b397fb
DN
31872011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3188
3189 * m/iris4d.h: Remove file, move contents ...
3190 * s/irix6-5.h: ... here.
3191
22b4128e
PE
31922011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3195 * alloc.c (mark_buffer):
3196 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3197 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3198 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3199 This isn't true in general, and it's particularly not true
3200 if Emacs is configured with --with-wide-int.
3201 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3202 New macros, used in the buffer.c change.
3203
869795d6
JD
32042011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3205
3206 * xsettings.c: Use both GConf and GSettings if both are available.
3207 (store_config_changed_event): Add comment.
3208 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3209 (store_tool_bar_style_changed): New functions.
5e617bc2 3210 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3211 (struct xsettings): Move font inside HAVE_XFT.
3212 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3213 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3214 Move inside HAVE_XFT.
640c8776 3215 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3216 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3217 also.
3218 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3219 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3220 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3221 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3222 (parse_settings): Move check for font inside HAVE_XFT.
3223 (read_settings, apply_xft_settings): Add comment.
3224 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3225 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3226 call store_font_name_changed.
3227 (xft_settings_event): Add comment.
3228 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3229 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3230 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3231 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3232 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3233 (xsettings_get_system_font, xsettings_get_system_normal_font):
3234 Add comment.
869795d6 3235
d8ed26bd
PE
32362011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3237
3238 Random fixes. E.g., (random) never returned negative values.
3239 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3240 subseconds part to the entropy, as that's a bit more random.
3241 Prefer signed to unsigned, since the signedness doesn't matter and
3242 in general we prefer signed. When given a limit, use a
3243 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3244 latter isn't right if USE_2_TAGS_FOR_INTS.
3245 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3246 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3247
cabf1cac
SM
32482011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3249
3250 * textprop.c (text_property_stickiness):
3251 Obey Vtext_property_default_nonsticky.
3252 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3253 * w32fns.c (syms_of_w32fns):
3254 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3255
6e9b2be9
PE
32562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3259 This is more efficient than Ffile_directory_p and avoids a minor race.
3260
90186c68
LMI
32612011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3262
7c301272
LMI
3263 * buffer.c (Foverlay_put): Say what the return value is
3264 (bug#7835).
3265
c4f2d8d4
LMI
3266 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3267 is a directory before asking whether to use the file name
3268 (bug#7564).
ad637907
LMI
3269 (barf_or_query_if_file_exists): Make the "File is a directory"
3270 error be more correct.
c4f2d8d4 3271
90186c68
LMI
3272 * fns.c (Frequire): Remove the mention of the .gz files, since
3273 that's installation-specific, but keep the mention of
3274 `get-load-suffixes'.
3275
da64016e
PE
32762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3277
3278 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3279 Report string overflow if the output is too long.
3280
7d47b580
JB
32812011-07-04 Juanma Barranquero <lekktu@gmail.com>
3282
a555cb87
JB
3283 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3284 (syms_of_gnutls): Remove duplicate DEFSYM for
3285 Qgnutls_bootprop_verify_hostname_error, an error for
3286 Qgnutls_bootprop_verify_error (which is no longer used).
3287
7d47b580
JB
3288 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3289 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3290 Also (re)move comments that are misplaced or no longer relevant.
3291
1e49bfab
LMI
32922011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3293
3294 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3295
1485f4c0
CY
32962011-07-03 Chong Yidong <cyd@stupidchicken.com>
3297
3298 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3299 and background color parameters if they have been changed.
3300
a9ab721e
LMI
33012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3302
3303 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3304
cf7cff57
PE
33052011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3306
2e13213d
PE
3307 * xsettings.c (SYSTEM_FONT): Define only when used.
3308 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3309
cf7cff57
PE
3310 * keymap.c (access_keymap_1): Now static.
3311
7a8e04f7
CY
33122011-07-02 Chong Yidong <cyd@stupidchicken.com>
3313
3314 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3315 leave any prefix arg for the up event (Bug#1586).
3316
61352f62
LMI
33172011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3318
69bb1ef7
LMI
3319 * lread.c (syms_of_lread): Mention single symbols defined by
3320 `defvar' or `defconst' (bug#7154).
3321
61352f62 3322 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3323 (Frequire): Mention get-load-suffixes.
61352f62 3324
28545e04
MR
33252011-07-02 Martin Rudalics <rudalics@gmx.at>
3326
3327 * window.h (window): Remove clone_number slot.
3328 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3329 Remove.
3330 (make_parent_window, make_window, saved_window)
3331 (Fset_window_configuration, save_window_save): Don't deal with
3332 clone numbers.
3333 * buffer.c (Qclone_number): Remove declaration.
3334 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3335
3349e122
SM
33362011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3337
3338 Add multiple inheritance to keymaps.
3339 * keymap.c (Fmake_composed_keymap): New function.
3340 (Fset_keymap_parent): Simplify.
3341 (fix_submap_inheritance): Remove.
3342 (access_keymap_1): New function extracted from access_keymap to handle
3343 embedded parents and handle lists of maps.
3344 (access_keymap): Use it.
3345 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3346 (Fcopy_keymap): Handle embedded parents.
3347 (Fcommand_remapping, define_as_prefix): Simplify.
3348 (Fkey_binding): Simplify.
3349 (syms_of_keymap): Move minibuffer-local-completion-map,
3350 minibuffer-local-filename-completion-map,
3351 minibuffer-local-must-match-map, and
3352 minibuffer-local-filename-must-match-map to Elisp.
3353 (syms_of_keymap): Defsubr make-composed-keymap.
3354 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3355 (parse_menu_item): Trivial simplification.
3356
3279eb87
GM
33572011-07-01 Glenn Morris <rgm@gnu.org>
3358
3359 * Makefile.in (SETTINGS_LIBS): Fix typo.
3360
4550efdf
KI
33612011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3362
3363 * coding.c (Fencode_coding_string): Record the last coding system
3364 used, as the function doc string says (bug#8738).
3365
0949d2b6
JD
33662011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3367
3368 * xsettings.c (store_monospaced_changed): Take new font as arg and
3369 check for change against current_mono_font.
3370 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3371 (emacs_settings_constructor, emacs_settings_get_property)
3372 (emacs_settings_set_property, emacs_settings_class_init)
3373 (emacs_settings_init, gsettings_obj): Remove.
3374 (something_changedCB): New function for HAVE_GSETTINGS.
3375 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3376 with value as argument.
3377 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3378 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3379 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3380 "changed".
3381
3382 * xgselect.c: Add defined (HAVE_GSETTINGS).
3383 (xgselect_initialize): Ditto.
3384
3385 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3386 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3387 xg_select.
3388
bbc6b304
PE
33892011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 * eval.c (struct backtrace): Simplify and port the data structure.
3392 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3393 signed bit field, as this assumption is not portable and it makes
3394 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3395 "char debug_on_exit : 1" as this is not portable either; instead,
3396 use the portable "unsigned int debug_on_exit : 1". Remove unused
3397 member evalargs. Remove obsolete comments about cc bombing out.
3398
9851bfc5
JD
33992011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3400
51bb811f 3401 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3402 Let HAVE_GSETTINGS override HAVE_GCONF.
3403 (store_monospaced_changed): New function.
3404 (EMACS_SETTINGS): A new type derived from GObject to handle
3405 GSettings notifications.
3406 (emacs_settings_constructor, emacs_settings_get_property)
3407 (emacs_settings_set_property, emacs_settings_class_init):
3408 New functions.
3409 (gsettings_client, gsettings_obj): New variables.
3410 (GSETTINGS_SCHEMA): New define.
3411 (something_changedCB): Call store_monospaced_changed.
3412 (init_gsettings): New function.
3413 (xsettings_initialize): Call init_gsettings.
3414 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3415 to NULL.
3416
640c8776 3417 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3418 GCONF_CFLAGS/LIBS.
3419
5386012d
MR
34202011-06-29 Martin Rudalics <rudalics@gmx.at>
3421
3422 * window.c (resize_root_window, grow_mini_window)
3423 (shrink_mini_window): Rename Qresize_root_window to
3424 Qwindow_resize_root_window and Qresize_root_window_vertically to
3425 Qwindow_resize_root_window_vertically.
3426
f13e0b08
PE
34272011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3428
3429 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3430
94515237
JB
34312011-06-27 Juanma Barranquero <lekktu@gmail.com>
3432
3433 * makefile.w32-in: Redesign dependencies so they reflect more
3434 clearly which files are directly included by each source file,
3435 and not through other includes.
3436
e43b6e43
MR
34372011-06-27 Martin Rudalics <rudalics@gmx.at>
3438
3439 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3440 (sort_overlays, overlay_strings): When an overlay's clone number
3441 matches the window's clone number process the overlay even if
3442 the overlay's window property doesn't match the current window.
3443
d68443dc
MR
3444 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3445 (Fwindow_hchild): Rename to Fwindow_left_child.
3446 (Fwindow_next): Rename to Fwindow_next_sibling.
3447 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3448 (resize_window_check): Rename to window_resize_check.
3449 (resize_window_apply): Rename to window_resize_apply.
3450 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3451 (Fdelete_other_windows_internal, resize_frame_windows)
3452 (Fsplit_window_internal, Fdelete_window_internal)
3453 (grow_mini_window, shrink_mini_window)
3454 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3455
c7e73be5
JD
34562011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3457
3458 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3459 (emacs_fixed_set_min_size): Remove.
3460 (emacs_fixed_new): Take frame as argument.
3461
3462 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3463 (_EmacsFixedPrivate): Remove minwidth/height.
3464 Add struct frame *f.
3465 (emacs_fixed_init): Initialize priv->f.
3466 (get_parent_class, emacs_fixed_set_min_size): Remove.
3467 (emacs_fixed_new): Set priv->f to argument.
3468 (emacs_fixed_get_preferred_width)
3469 (emacs_fixed_get_preferred_height): Use min_width/height from
3470 frames size_hint to set minimum and natural (Bug#8919).
3471 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3472 and use min_width/height from frames size_hint to set
3473 min_width/height (Bug#8919).
3474
3475 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3476 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3477 Fix indentation.
c7e73be5 3478
cf99dcf8
EZ
34792011-06-26 Eli Zaretskii <eliz@gnu.org>
3480
3481 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3482 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3483 called at ZV.
3484
029529ac
CY
34852011-06-26 Chong Yidong <cyd@stupidchicken.com>
3486
3487 * process.c (wait_reading_process_output): Bypass select if
3488 waiting for a cell while ignoring keyboard input, and input is
3489 pending. Suggested by Jan Djärv (Bug#8869).
3490
7a7ef429
PE
34912011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3492
3493 Use gnulib's dup2 module instead of rolling our own.
3494 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3495
11fdef7d 34962011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3497
3498 * dispnew.c (scrolling_window): Before scrolling, turn off a
3499 mouse-highlight in the window being scrolled.
3500
cd3520a4
JB
35012011-06-24 Juanma Barranquero <lekktu@gmail.com>
3502
3503 Move DEFSYM to lisp.h and use everywhere.
3504
3505 * character.h (DEFSYM): Move declaration...
3506 * lisp.h (DEFSYM): ...here.
3507
3508 * gnutls.c:
3509 * minibuf.c:
3510 * w32menu.c:
3511 * w32proc.c:
3512 * w32select.c: Don't include character.h.
3513
3514 * alloc.c (syms_of_alloc):
3515 * buffer.c (syms_of_buffer):
3516 * bytecode.c (syms_of_bytecode):
3517 * callint.c (syms_of_callint):
3518 * casefiddle.c (syms_of_casefiddle):
3519 * casetab.c (init_casetab_once):
3520 * category.c (init_category_once, syms_of_category):
3521 * ccl.c (syms_of_ccl):
3522 * cmds.c (syms_of_cmds):
3523 * composite.c (syms_of_composite):
3524 * dbusbind.c (syms_of_dbusbind):
3525 * dired.c (syms_of_dired):
3526 * dispnew.c (syms_of_display):
3527 * doc.c (syms_of_doc):
3528 * editfns.c (syms_of_editfns):
3529 * emacs.c (syms_of_emacs):
3530 * eval.c (syms_of_eval):
3531 * fileio.c (syms_of_fileio):
3532 * fns.c (syms_of_fns):
3533 * frame.c (syms_of_frame):
3534 * fringe.c (syms_of_fringe):
3535 * insdel.c (syms_of_insdel):
3536 * keymap.c (syms_of_keymap):
3537 * lread.c (init_obarray, syms_of_lread):
3538 * macros.c (syms_of_macros):
3539 * msdos.c (syms_of_msdos):
3540 * print.c (syms_of_print):
3541 * process.c (syms_of_process):
3542 * search.c (syms_of_search):
3543 * sound.c (syms_of_sound):
3544 * syntax.c (init_syntax_once, syms_of_syntax):
3545 * terminal.c (syms_of_terminal):
3546 * textprop.c (syms_of_textprop):
3547 * undo.c (syms_of_undo):
3548 * w32.c (globals_of_w32):
3549 * window.c (syms_of_window):
3550 * xdisp.c (syms_of_xdisp):
3551 * xfaces.c (syms_of_xfaces):
3552 * xfns.c (syms_of_xfns):
3553 * xmenu.c (syms_of_xmenu):
3554 * xsettings.c (syms_of_xsettings):
3555 * xterm.c (syms_of_xterm): Use DEFSYM.
3556
4228cf16
TZ
35572011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3558
cd3520a4 3559 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3560
7fcccf1e
PE
35612011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3562
7efb4e0e
PE
3563 Integer and buffer overflow fixes (Bug#8873).
3564
ff5844ad
PE
3565 * print.c (printchar, strout): Check for string overflow.
3566 (PRINTPREPARE, printchar, strout):
3567 Don't set size unless allocation succeeds.
3568
90532f02
PE
3569 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3570 for sizes. Check for string overflow more accurately.
3571 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3572
6d84508d
PE
3573 * macros.c: Integer and buffer overflow fixes.
3574 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3575 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3576 Use ptrdiff_t, not int, for sizes.
3577 Don't increment bufsize until after realloc succeeds.
3578 Check for size-calculation overflow.
3579 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3580
437b2cb4
PE
3581 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3582
8b9ac8b4
PE
3583 * lread.c: Integer overflow fixes.
3584 (read_integer): Radix is now EMACS_INT, not int,
3585 to improve quality of diagnostics for out-of-range radices.
3586 Calculate buffer size correctly for out-of-range radices.
3587 (read1): Check for integer overflow in radices, and in
3588 read-circle numbers.
82cb60d3
PE
3589 (read_escape): Avoid int overflow.
3590 (Fload, openp, read_buffer_size, read1)
3591 (substitute_object_recurse, read_vector, read_list, map_obarray):
3592 Use ptrdiff_t, not int, for sizes.
3593 (read1): Use EMACS_INT, not int, for sizes.
20270765 3594 Check for size overflow.
8b9ac8b4 3595
7fcccf1e
PE
3596 * image.c (cache_image): Check for size arithmetic overflow.
3597
bfbbd7e7
PE
3598 * lread.c: Integer overflow issues.
3599 (saved_doc_string_size, saved_doc_string_length)
3600 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3601 Now ptrdiff_t, not int.
3602 (read1): Don't assume doc string length fits in int. Check for
3603 out-of-range doc string lengths.
3604 (read_list): Don't assume file position fits in int.
39019e54 3605 (read_escape): Check for hex character overflow.
bfbbd7e7 3606
4e323265
LL
36072011-06-22 Leo Liu <sdl.web@gmail.com>
3608
3609 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3610 Move to minibuffer.el.
3611
85fece3e
PE
36122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3613
20b84ce9 3614 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3615 The following patches are for when GLYPH_DEBUG && !XASSERT.
3616 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3617 * dispnew.c (flush_stdout):
3618 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3619 Mark as externally visible.
3620 * dispnew.c (check_window_matrix_pointers): Now static.
3621 * dispnew.c (window_to_frame_vpos):
3622 * xfns.c (unwind_create_frame):
3623 * xterm.c (x_check_font): Remove unused local.
3624 * scroll.c (CHECK_BOUNDS):
3625 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3626 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3627 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3628 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3629 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3630 Now static.
3631 (debug_method_add): Use va_list and vsprintf rather than relying
3632 on undefined behavior with wrong number of arguments.
3633 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3634 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3635 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3636 since we're not interested in debugging glyphs with old libraries.
3637 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3638 GCC 4.6.0's static checking.
3639
0766b489
PE
36402011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3641
31fd4b32
PE
3642 Integer overflow and signedness fixes (Bug#8873).
3643 A few related buffer overrun fixes, too.
3644
b79e8648
PE
3645 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3646
0766b489
PE
3647 * dispextern.h (struct face.stipple):
3648 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3649 (x_bitmap_mask, x_allocate_bitmap_record)
3650 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3651 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3652 (x_create_bitmap_from_xpm_data):
3653 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3654 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3655 (.bitmaps_last):
3656 * xfaces.c (load_pixmap):
3657 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3658 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3659 (.bitmaps_last, struct x_output.icon_bitmap):
3660 Use ptrdiff_t, not int, for bitmap indexes.
3661 (x_allocate_bitmap_record): Check for size overflow.
3662 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3663
b081724f
PE
3664 Use ptrdiff_t, not int, for overlay counts.
3665 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3666 * editfns.c (overlays_around, get_pos_property):
3667 * textprop.c (get_char_property_and_overlay):
3668 * xdisp.c (next_overlay_change, note_mouse_highlight):
3669 * xfaces.c (face_at_buffer_position):
21514da7
PE
3670 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3671 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3672 (Fnext_overlay_change, Fprevious_overlay_change)
3673 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3674 Use ptrdiff_t, not int, for sizes.
21514da7 3675 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3676
3de73e5e
PE
3677 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3678
2606c57b
PE
3679 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3680 (x_session_initialize): Do not assume string length fits in int.
3681
aaafe47a
PE
3682 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3683 This is unlikely, but can occur if DPI is outlandish.
3684
2674ddc8 3685 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3686 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3687
28154962
PE
3688 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3689 * xrdb.c (magic_file_p, search_magic_path):
3690 Omit last arg SUFFIX; it was always 0. All callers changed.
3691 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3692
7de51af5
PE
3693 * xfont.c (xfont_match): Avoid need for strlen.
3694
25ed6cc3
PE
3695 * xfns.c: Don't assume strlen fits in int.
3696 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3697
4eab31dd
PE
3698 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3699 not unsigned long, as we prefer signed integers. All callers changed.
3700 Detect integer overflow in repeat count.
3701 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3702 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3703
171e2a58
PE
3704 * termcap.c: Don't assume sizes fit in int and never overflow.
3705 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3706 (gobble_line): Check for size-calculation overflow.
3707
ad39faca 3708 * minibuf.c (Fread_buffer):
6e5bb2dc 3709 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3710 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3711 Don't assume string length fits in int.
3712
52c61c22 3713 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3714 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3715
b5b8c9e5
PE
3716 * font.c: Don't assume string length fits in int.
3717 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3718 Use ptrdiff_t, not int.
ccd6111c
PE
3719 (font_intern_prop): Don't assume string length fits in int.
3720 Don't assume integer property fits in fixnum.
3721 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3722
882f0d81 3723 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3724 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3725 Reformulate so as not to need the command string.
3726 Invoke gzip -cd rather than gunzip, as it's more portable.
3727 (lock_info_type, lock_file_1, lock_file):
3728 Don't assume pid_t and time_t fit in unsigned long.
3729 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3730 (current_lock_owner): Prefer signed type for sizes.
3731 Use memcpy, not strncpy, where memcpy is what is really wanted.
3732 Don't assume (via atoi) that time_t and pid_t fit in int.
3733 Check for time_t and/or pid_t out of range, e.g., via a network share.
3734 Don't alloca where an auto var works fine.
3735
93f4cf88
PE
3736 * fileio.c: Fix some integer overflow issues.
3737 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3738 Don't assume string length fits in int.
3739 (directory_file_name): Don't assume string length fits in long.
3740 (make_temp_name): Don't assume pid fits in int, or that its print
3741 length is less than 20.
3742
f3e92b69
PE
3743 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3744
1bfdaf10
PE
3745 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3746
35016e9a
PE
3747 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3748
3d1e65a1
PE
3749 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3750 We prefer signed integers, even for size calculations.
3751
0b963a93
PE
3752 * emacs.c: Don't assume string length fits in 'int'.
3753 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3754 (main): Don't invoke strlen when not needed.
3755
573f4b54
PE
3756 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3757 (XD_DEBUG_MESSAGE): Don't waste a byte.
3758
989f33ba
PE
3759 * callproc.c (getenv_internal_1, getenv_internal)
3760 (Fgetenv_internal):
965d34eb
PE
3761 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3762
e4d29b33
PE
3763 * lread.c (invalid_syntax): Omit length argument.
3764 All uses changed. This doesn't fix a bug, but it simplifies the
3765 code away from its former Hollerith-constant appearance, and it's
3766 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3767 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3768
eb49b136
PE
3769 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3770 This didn't break anything, but it didn't help either.
3771 It's confusing to put a bogus integer in a place where the actual
3772 value does not matter.
9f62aeb1 3773 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3774 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3775
15375a22
PE
3776 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3777 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3778 implementation.
b61cc01c
PE
3779 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3780 We prefer signed types, and the value cannot exceed the EMACS_INT
3781 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3782 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3783 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3784 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3785
53b2623d
PE
3786 * indent.c (sane_tab_width): New function.
3787 (current_column, scan_for_column, Findent_to, position_indentation)
3788 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3789 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3790
51cab52b 3791 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3792
f2ed8a70
PE
3793 * lisp.h (lint_assume): New macro.
3794 * composite.c (composition_gstring_put_cache):
3795 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3796
abe80cc6
PE
3797 * editfns.c, insdel.c:
3798 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3799
b02c740e
PE
3800 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3801
ebc96716
PE
3802 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3803
b4e50fa0 3804 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3805 Use much-faster test for byte-length change.
311d5d7c 3806 Don't assume string byte-length fits in 'int'.
a4cf38e4 3807 Check that character arg fits in 'int'.
85461888 3808 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3809
c0c1ee9f
PE
3810 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3811
a498d7f4
PE
3812 * fns.c (concat): Catch string overflow earlier.
3813 Do not rely on integer wraparound.
3814
51cab52b
PE
3815 * dispextern.h (struct it.overlay_strings_charpos)
3816 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3817 * xdisp.c (forward_to_next_line_start)
3818 (back_to_previous_visible_line_start)
3819 (reseat_at_next_visible_line_start, next_element_from_buffer):
3820 Don't arbitrarily truncate the value of 'selective' to int.
3821
76031fad
PE
3822 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3823
5eb55db9
PE
3824 * composite.c: Don't truncate sizes to 'int'.
3825 (composition_gstring_p, composition_reseat_it)
3826 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3827 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3828 not EMACS_UINT, for indexes.
5eb55db9 3829
0703a717
PE
3830 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3831
d6202519
PE
3832 * buffer.c: Include <verify.h>.
3833 (struct sortvec.priority, struct sortstr.priority):
8961a454 3834 Now EMACS_INT, not int.
c20998a7 3835 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3836 (struct sortstr.size, record_overlay_string)
3837 (struct sortstrlist.size, struct sortlist.used):
3838 Don't truncate size to int.
3839 (record_overlay_string): Check for size-calculation overflow.
d6202519 3840 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3841
d5a19415
JM
38422011-06-22 Jim Meyering <meyering@redhat.com>
3843
029529ac 3844 Don't leak an XBM-image-sized buffer
d5a19415
JM
3845 * image.c (xbm_load): Free the image buffer after using it.
3846
a9041e6c
PE
38472011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3848
3849 Port to Sun C.
3850 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3851 that Sun C diagnosed.
3852 * fns.c (secure_hash): Fix pointer signedness issue.
3853 * intervals.c (static_offset_intervals): New function.
3854 (offset_intervals): Use it.
3855
7f3f739f
LL
38562011-06-21 Leo Liu <sdl.web@gmail.com>
3857
3858 * deps.mk (fns.o):
3859 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3860 sha512.h.
3861
3862 * fns.c (secure_hash): Rename from crypto_hash_function and change
3863 the first arg to accept symbols.
5b66d427 3864 (Fsecure_hash): New primitive.
7f3f739f
LL
3865 (syms_of_fns): New symbols.
3866
76147d94
DD
38672011-06-20 Deniz Dogan <deniz@dogan.se>
3868
3869 * process.c (Fset_process_buffer): Clarify return value in
3870 docstring.
3871
7d7d0045
CY
38722011-06-18 Chong Yidong <cyd@stupidchicken.com>
3873
3874 * dispnew.c (add_window_display_history): Use BVAR.
3875
3876 * xdisp.c (debug_method_add): Use BVAR.
3877 (check_window_end, dump_glyph_matrix, dump_glyph)
3878 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3879
3880 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3881 Likewise.
3882
3883 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3884 check till after the cache is created in init_frame_faces.
3885
ff2bc410
SM
38862011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3887
3888 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3889
28177add
PE
38902011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3891
dd3482fe
PE
3892 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3893 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3894 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3895
393d71f3 3896 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3897 * fileio.c (Finsert_file_contents):
3898 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3899 Remove the old (too-loose) buffer overflow checks.
3900 They weren't needed, since make_gap checks for buffer overflow.
3901 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3902 The old code merely checked for Emacs fixnum overflow, and relied
3903 on undefined (wraparound) behavior. The new code avoids undefined
3904 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3905
2e6813b0 3906 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3907 Tune. Don't use wider integers than needed. Don't use alloca.
3908 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3909
599a9e4f
PE
3910 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3911
99561444
PE
3912 * insdel.c, lisp.h (buffer_overflow): New function.
3913 (insert_from_buffer_1, replace_range, replace_range_2):
3914 * insdel.c (make_gap_larger):
3915 * editfns.c (Finsert_char):
3916 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3917
28177add
PE
3918 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3919
e69dafad
PE
39202011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3921
a7af7fde 3922 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3923
b1c46f02
PE
3924 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3925 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3926
e69dafad
PE
3927 * fileio.c: Don't assume EMACS_INT fits in off_t.
3928 (emacs_lseek): New static function.
3929 (Finsert_file_contents, Fwrite_region): Use it.
3930 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3931
566684ea
PE
3932 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3933
e6966cd6
PE
3934 * fns.c: Don't overflow int when computing a list length.
3935 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3936 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3937 truncation on 64-bit hosts. Check for QUIT every
3938 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3939 faster and is responsive enough.
3940 (Flength): Report an error instead of overflowing an integer.
3941 (Fsafe_length): Return a float if the value is not representable
3942 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3943 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3944 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3945
dd0b0efb
PE
3946 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3947 (header_size, word_size): New constants.
3948 (allocate_vectorlike): Don't check size overflow here.
3949 (allocate_vector): Check it here instead, since this is the only
3950 caller of allocate_vectorlike that could cause overflow.
3951 Check that the new vector's length is representable as a fixnum.
3952
86fe5cfe
PE
3953 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3954 The previous code was bogus. For example, next_almost_prime (32)
3955 returned 39, which is undesirable as it is a multiple of 3; and
3956 next_almost_prime (24) returned 25, which is a multiple of 5 so
3957 why was the code bothering to check for multiples of 7?
3958
80e88859
PE
3959 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3960
4a2f0ad6
PE
3961 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3962
f66c7cf8
PE
3963 Variadic C functions now count arguments with ptrdiff_t.
3964 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3965 Back then I didn't know that the Emacs coding style prefers signed int.
3966 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3967 were being counted with int, which may truncate counts on 64-bit
3968 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3969 * lisp.h (struct Lisp_Subr.function.aMANY)
3970 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3971 Arg counts are now ptrdiff_t, not size_t.
3972 All variadic functions and their callers changed accordingly.
3973 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3974 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3975 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3976 * callint.c (Fcall_interactively): Check arg count for overflow,
3977 to avoid potential buffer overrun. Use signed char, not 'int',
3978 for 'varies' array, so that we needn't bother to check its size
3979 calculation for overflow.
3980 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3981 * eval.c (apply_lambda):
3982 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3983 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3984 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3985
a1759b76
PE
3986 * callint.c (Fcall_interactively): Don't use index var as event count.
3987
d96be9fc
PE
3988 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3989 * mem-limits.h (SIZE): Remove; no longer used.
3990
a690a978 3991 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3992
578c21e6
PE
3993 Remove unnecessary casts.
3994 * xterm.c (x_term_init):
3995 * xfns.c (x_set_border_pixel):
3996 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3997 These aren't needed now that we assume ANSI C.
3998
96f53c6c
PE
3999 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4000 It's more likely to cause problems (due to unsigned overflow)
4001 than to cure them.
4002
83c77d31
PE
4003 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4004
ee2079f1
PE
4005 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4006
6da65536
PE
4007 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4008
7147c4a4
PE
4009 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4010
193e32d9
PE
4011 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4012
e5533da6
PE
4013 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4014
9910e595
PE
4015 GLYPH_CODE_FACE returns EMACS_INT, not int.
4016 * dispextern.h (merge_faces):
4017 * xfaces.c (merge_faces):
01103c44
PE
4018 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4019 Don't assume EMACS_INT fits in int.
9910e595 4020
2638320e
PE
4021 * character.h (CHAR_VALID_P): Remove unused parameter.
4022 * fontset.c, lisp.h, xdisp.c: All uses changed.
4023
045eb8d9
PE
4024 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4025
c1f134b5
PE
4026 * fns.c (concat): Minor tuning based on overflow analysis.
4027 This doesn't fix any bugs. Use int to hold character, instead
4028 of constantly refetching from Emacs object. Use XFASTINT, not
4029 XINT, for value known to be a character. Don't bother comparing
4030 a single byte to 0400, as it's always less.
4031
395fcb93 4032 * floatfns.c (Fexpt):
327eeec8
PE
4033 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4034
abbd3d23
PE
4035 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4036 for characters.
4037
684a03ef
PE
4038 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4039
0fed43f3
PE
4040 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4041 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4042 incorrectly succeed when S was a string, because 4294967386 was
4043 truncated before it was used.
4044
8fd02eb7
PE
4045 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4046 Otherwise, an out-of-range integer could cause undefined behavior
4047 on a 64-bit host.
4048
f8c86b69
PE
4049 * composite.c: Use int, not EMACS_INT, for characters.
4050 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4051 EMACS_INT, for values that are known to be in character range.
4052 This doesn't fix any bugs but is the usual style inside Emacs and
4053 may generate better code on 32-bit machines.
4054
34206dd2
PE
4055 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4056 This is for reasons similar to the recent CHAR_STRING fix.
4057 * charset.c (Fencode_char): Check that character arg is actually
4058 a character. Pass an int to ENCODE_CHAR.
4059 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4060 wider than 'int', as a compile-time check to prevent future regressions
4061 in this area.
4062
c5958d4c 4063 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4064
4065 Make sure a 64-bit char is never passed to CHAR_STRING.
4066 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4067 by silently ignoring the top 32 bits, allowing some values
4068 that were far too large to be valid characters.
4069 * character.h: Include <verify.h>.
4070 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4071 arguments are no wider than unsigned, as a compile-time check
4072 to prevent future regressions in this area.
4073 * data.c (Faset):
01103c44 4074 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4075 (Fsubst_char_in_region):
4076 * fns.c (concat):
4077 * xdisp.c (decode_mode_spec_coding):
4078 Adjust to CHAR_STRING's new requirement.
4079 * editfns.c (Finsert_char, Fsubst_char_in_region):
4080 * fns.c (concat): Check that character args are actually
4081 characters. Without this test, these functions did the wrong
4082 thing with wildly out-of-range values on 64-bit hosts.
4083
d37ca623
PE
4084 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4085 These casts should not be needed on 32-bit hosts, either.
4086 * keyboard.c (read_char):
4087 * lread.c (Fload): Remove casts to unsigned.
4088
ea204efb
PE
4089 * lisp.h (UNSIGNED_CMP): New macro.
4090 This fixes comparison bugs on 64-bit hosts.
4091 (ASCII_CHAR_P): Use it.
4092 * casefiddle.c (casify_object):
01103c44 4093 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4094 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4095 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4096 * dispextern.h (FACE_FROM_ID):
4097 * keyboard.c (read_char): Use UNSIGNED_CMP.
4098
41cb286c
PE
4099 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4100 not to EMACS_INT, to avoid GCC warning.
4101
4a1b9832
PE
4102 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4103
55daad71
PE
4104 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4105 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4106 isn't needed on 32-bit machines.
8f95c75c 4107
01103c44
PE
4108 * buffer.c (Fgenerate_new_buffer_name):
4109 Use EMACS_INT for count, not int.
0ceccced 4110 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4111
4112 * data.c (Qcompiled_function): Now static.
4113
c6f072e7
PE
4114 * window.c (window_body_lines): Now static.
4115
20ce5912
PE
4116 * image.c (gif_load): Rename local to avoid shadowing.
4117
9c4c5f81
PE
4118 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4119 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4120 * alloc.c (make_save_value): Integer argument is now of type
4121 ptrdiff_t, not int.
4122 (mark_object): Use ptrdiff_t, not int.
4123 * lisp.h (pD): New macro.
4124 * print.c (print_object): Use it.
4125
c0c5c8ae
PE
4126 * alloc.c: Use EMACS_INT, not int, to count objects.
4127 (total_conses, total_markers, total_symbols, total_vector_size)
4128 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4129 (total_free_floats, total_floats, total_free_intervals)
4130 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4131 Now EMACS_INT, not int. All uses changed.
4132 (Fgarbage_collect): Compute overall total using a double, so that
4133 integer overflow is less likely to be a problem. Check for overflow
4134 when converting back to an integer.
5a25e253
PE
4135 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4136 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4137 These were 'int' variables that could overflow on 64-bit hosts;
4138 they were never used, so remove them instead of repairing them.
211a0b2a 4139 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4140 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4141 Previously, this ceilinged at INT_MAX, but that doesn't work on
4142 64-bit machines.
e46bb31a 4143 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4144
c78baabf 4145 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4146 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4147 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4148 when a (possibly-narrower) signed value would do just as well.
4149 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4150
c9d624c6
PE
4151 * alloc.c: Catch some string size overflows that we were missing.
4152 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4153 for convenience in STRING_BYTES_MAX.
4154 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4155 The definition here is exact; the one in lisp.h was approximate.
4156 (allocate_string_data): Check for string overflow. This catches
4157 some instances we weren't catching before. Also, it catches
4158 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4159 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4160 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4161
c9d624c6
PE
4162 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4163 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4164 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4165
353032ce
PE
4166 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4167
2bccce07
PE
4168 * alloc.c (Fmake_string): Check for out-of-range init.
4169
0ac30604
SM
41702011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4171
4172 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4173
c195f2de
JD
41742011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4175
4176 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4177 xg_get_default_scrollbar_width.
4178
4179 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4180 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4181 (style_changed_cb): Call update_theme_scrollbar_width and call
4182 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4183 all frames (Bug#8505).
4184 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4185 Call gtk_window_set_resizable if HAVE_GTK3.
4186 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4187 and height if HAVE_GTK3 (Bug#8505).
4188 (scroll_bar_width_for_theme): New variable.
4189 (update_theme_scrollbar_width): New function.
4190 (xg_get_default_scrollbar_width): Move code to
4191 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4192 (xg_initialize): Call update_theme_scrollbar_width.
4193
4194 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4195
4196 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4197
e10ac9f1
MR
41982011-06-12 Martin Rudalics <rudalics@gmx.at>
4199
4200 * frame.c (make_frame): Call other_buffer_safely instead of
4201 other_buffer.
4202
4203 * window.c (temp_output_buffer_show): Call display_buffer with
4204 second argument Vtemp_buffer_show_specifiers and reset latter
4205 immediately after the call.
4206 (Vtemp_buffer_show_specifiers): New variable.
4207 (auto_window_vscroll_p, next_screen_context_lines)
4208 (Vscroll_preserve_screen_position): Remove leading asterisks from
4209 doc-strings.
4210
2d3c217e 42112011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4212
7b7f97e8 4213 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4214 * buffer.c (Qclone_number): Remove for now, as it's unused.
4215 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4216 (record_buffer): Remove unused local.
4217 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4218 (set_frame_buffer_list): Remove; unused.
4219 * frame.h (other_visible_frames): Remove decl.
4220 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4221 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4222 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4223 if HAVE_GPM.
4224 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4225 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4226 Define only if HAVE_GPM.
4227 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4228 (update_hints_inhibit): Remove; never set. All uses removed.
4229 * widgetprv.h (emacsFrameClassRec): Remove decl.
4230 * window.c (delete_deletable_window): Now returns void, since it
4231 wasn't returning anything.
4232 (compare_window_configurations): Remove unused locals.
4233 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4234 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4235 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4236 the same widths as pointers. This follows up on the 2011-05-06 patch.
4237 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4238 * xterm.h: Likewise.
4239 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4240
1384b89e
JB
42412011-06-12 Juanma Barranquero <lekktu@gmail.com>
4242
4243 * makefile.w32-in: Update dependencies.
4244 (LISP_H): Add lib/intprops.h.
4245
1100a63c
CY
42462011-06-11 Chong Yidong <cyd@stupidchicken.com>
4247
4248 * image.c (gif_load): Add animation frame delay to the metadata.
4249 (syms_of_image): Use DEFSYM. New symbol `delay'.
4250
6198ccd0
MR
42512011-06-11 Martin Rudalics <rudalics@gmx.at>
4252
4253 * window.c (delete_deletable_window): Re-add.
4254 (Fset_window_configuration): Rewrite to handle dead buffers and
4255 consequently deletable windows.
4256 (window_tree, Fwindow_tree): Remove. Supply functionality in
4257 window.el.
4258 (compare_window_configurations): Simplify code.
4259
b6e3633c
AS
42602011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4261
1ab0dee5
AS
4262 * image.c (imagemagick_load_image): Fix type mismatch.
4263 (Fimagemagick_types): Likewise.
4264
b6e3633c
AS
4265 * window.h (replace_buffer_in_windows): Declare.
4266
9397e56f
MR
42672011-06-11 Martin Rudalics <rudalics@gmx.at>
4268
4269 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4270 Qclone_number. Remove external declaration of Qdelete_window.
4271 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4272 code.
640c8776
SM
4273 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4274 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4275 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4276 buffer list implementation.
4277 (other_buffer_safely): New function.
4278 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4279 calls to replace_buffer_in_windows and
4280 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4281 if allowed.
4282 (record_buffer): Inhibit quitting and rewrite using quittable
4283 functions. Run Qbuffer_list_update_hook if allowed.
4284 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4285 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4286 Move switch-to-buffer to window.el.
9397e56f
MR
4287 (bury-buffer): Move to window.el.
4288 (Vbuffer_list_update_hook): New variable.
4289
4290 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4291 section.
4292
4293 * window.h (resize_frame_windows): Move up in code.
4294 (Fwindow_frame): Remove EXFUN.
4295 (replace_buffer_in_all_windows): Remove prototype.
4296 (replace_buffer_in_windows_safely): Add prototype.
4297
4298 * window.c: Declare Qdelete_window static again. Move down
4299 declaration of select_count.
4300 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4301 (Fother_window): Move to window.el.
4302 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4303 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4304 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4305 window.el.
4306 (replace_buffer_in_windows): Implement by calling
4307 Qreplace_buffer_in_windows.
4308 (replace_buffer_in_all_windows): Remove with some functionality
4309 moved into replace_buffer_in_windows_safely.
4310 (replace_buffer_in_windows_safely): New function.
4311 (select_window_norecord, select_frame_norecord): Move in front
4312 of run_window_configuration_change_hook. Remove now obsolete
4313 declarations.
640c8776
SM
4314 (Fset_window_buffer): Rewrite doc-string.
4315 Call Qrecord_window_buffer.
9397e56f
MR
4316 (keys_of_window): Move binding for other-window to window.el.
4317
b50691aa
CY
43182011-06-11 Chong Yidong <cyd@stupidchicken.com>
4319
4320 * dispextern.h (struct image): Replace data member, whose int_val
4321 and ptr_val fields were not used by anything, with a single
4322 lisp_val object.
4323
4324 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4325 (gif_clear_image, gif_load, imagemagick_load_image)
4326 (gs_clear_image, gs_load): Callers changed.
4327
3f754b86
PE
43282011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4329
cca69397
PE
4330 * buffer.h: Include <time.h>, for time_t.
4331 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4332
109e28d0
PE
4333 Fix minor problems found by static checking.
4334
60737f02
PE
4335 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4336
4b66faf3
PE
4337 Make identifiers static if they are not used in other modules.
4338 * data.c (Qcompiled_function, Qframe, Qvector):
4339 * image.c (QimageMagick, Qsvg):
4340 * minibuf.c (Qmetadata):
4341 * window.c (resize_window_check, resize_root_window): Now static.
4342 * window.h (resize_window_check, resize_root_window): Remove decls.
4343
109e28d0
PE
4344 * window.c (window_deletion_count, delete_deletable_window):
4345 Remove; unused.
46a4ce9e
PE
4346 (window_body_lines): Now static.
4347 (Fdelete_other_windows_internal): Mark vars as initialized.
4348 Make sure 'resize_failed' is initialized.
4349 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4350 (resize_window_apply): Remove unused local.
4351 * window.h (delete_deletable_window): Remove decl.
4352
109e28d0 4353 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4354 (imagemagick_load_image): Fix pointer signedness problem by changing
4355 last arg from unsigned char * to char *. All uses changed.
4356 Also, fix a local for similar reasons.
4357 Remove unused locals. Remove locals to avoid shadowing.
4358 (fn_rsvg_handle_free): Remove; unused.
4359 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4360 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4361
3f754b86
PE
4362 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4363
2547adb1
CY
43642011-06-10 Chong Yidong <cyd@stupidchicken.com>
4365
4366 * image.c (gif_load): Fix omitted cast error introduced by
4367 2011-06-06 change.
4368
2c8e37d4
MR
43692011-06-10 Martin Rudalics <rudalics@gmx.at>
4370
4371 * window.h (resize_proportionally, orig_total_lines)
4372 (orig_top_line): Remove from window structure.
4373 (set_window_height, set_window_width, change_window_heights)
4374 (Fdelete_window): Remove prototypes.
4375 (resize_frame_windows): Remove duplicate declaration.
4376
440a42e3
EZ
43772011-06-10 Eli Zaretskii <eliz@gnu.org>
4378
4379 * window.h (resize_frame_windows, resize_window_check)
4380 (delete_deletable_window, resize_root_window)
4381 (resize_frame_windows): Declare prototypes.
4382
4383 * window.c (resize_window_apply): Make definition be "static" to
4384 match the prototype.
4385
562dd5e9
MR
43862011-06-10 Martin Rudalics <rudalics@gmx.at>
4387
4388 * window.c: Remove declarations of Qwindow_size_fixed,
4389 window_min_size_1, window_min_size_2, window_min_size,
4390 size_window, window_fixed_size_p, enlarge_window, delete_window.
4391 Remove static from declaration of Qdelete_window, it's
4392 temporarily needed by Fbury_buffer.
4393 (replace_window): Don't assign orig_top_line and
4394 orig_total_lines.
4395 (Fdelete_window, delete_window): Remove. Window deletion is
4396 handled by window.el.
640c8776
SM
4397 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4398 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4399 (Fdelete_other_windows): Remove. Deleting other windows is
4400 handled by window.el.
4401 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4402 handled in window.el.
4403 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4404 Window minimum sizes are handled in window.el.
4405 (shrink_windows, size_window, set_window_height)
4406 (set_window_width, change_window_heights, window_height)
4407 (window_width, CURBEG, CURSIZE, enlarge_window)
4408 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4409 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4410 handled in window.el.
4411 (make_dummy_parent): Rename to make_parent_window and give it a
4412 second argument horflag.
4413 (make_window): Don't set resize_proportionally any more.
4414 (Fsplit_window): Remove. Windows are split in window.el.
4415 (save_restore_action, save_restore_orig_size)
4416 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4417 Resize mini windows in window.el.
4418 (grow_mini_window, shrink_mini_window): Implement by calling
4419 Qresize_root_window_vertically, resize_window_check and
4420 resize_window_apply.
640c8776
SM
4421 (saved_window, Fset_window_configuration, save_window_save):
4422 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4423 resize_proportionally.
4424 (window_min_height, window_min_width): Move to window.el.
4425 (keys_of_window): Move bindings for delete-other-windows,
4426 split-window, delete-window and enlarge-window to window.el.
4427
4428 * buffer.c: Temporarily extern Qdelete_window.
4429 (Fbury_buffer): Temporarily call Qdelete_window instead of
4430 Fdelete_window (Fbury_buffer will move to window.el soon).
4431
4432 * frame.c (set_menu_bar_lines_1): Remove code handling
4433 orig_top_line and orig_total_lines.
4434
4435 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4436 set_window_height but set heights directly.
4437 (change_frame_size_1): Use resize_frame_windows.
4438
4439 * xdisp.c (init_xdisp): Don't use set_window_height but set
4440 heights directly.
4441
640c8776
SM
4442 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4443 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4444 run_window_configuration_change_hook.
4445
4446 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4447 instead of change_window_heights and run
4448 run_window_configuration_change_hook.
4449
1a13852e
MR
44502011-06-09 Martin Rudalics <rudalics@gmx.at>
4451
4452 * window.c (replace_window): Rename second argument REPLACEMENT to
4453 NEW. New third argument SETFLAG. Rewrite.
4454 (delete_window, make_dummy_parent): Call replace_window with
4455 third argument 1.
4456 (window_list_1): Move down in code.
4457 (run_window_configuration_change_hook): Move set_buffer part
4458 before select_frame_norecord part in order to unwind correctly.
4459 Rename count1 to count.
4460 (recombine_windows, delete_deletable_window, resize_root_window)
4461 (Fdelete_other_windows_internal)
4462 (Frun_window_configuration_change_hook, make_parent_window)
4463 (resize_window_check, resize_window_apply, Fresize_window_apply)
4464 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4465 (Fdelete_window_internal, Fresize_mini_window_internal):
4466 New functions.
1a13852e
MR
4467 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4468
f3d1777e
MR
44692011-06-08 Martin Rudalics <rudalics@gmx.at>
4470
496e208e
MR
4471 * window.h (window): Add some new members to window structure -
4472 normal_lines, normal_cols, new_total, new_normal, clone_number,
4473 splits, nest, prev_buffers, next_buffers.
4474 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4475 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4476
f3d1777e
MR
4477 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4478 Remove.
496e208e
MR
4479 (make_dummy_parent): Set new members of windows structure.
4480 (make_window): Move down in code. Handle new members of window
4481 structure.
4482 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4483 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4484 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4485 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4486 (Fset_window_next_buffers, Fset_window_clone_number):
4487 New functions.
496e208e
MR
4488 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4489 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4490 Doc-string fixes.
4491 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4492 Argument WINDOW can be now internal window too.
4493 (Fwindow_use_time): Move up in code.
4494 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4495 Rewrite doc-string.
4496 (Fset_window_configuration, saved_window)
4497 (Fcurrent_window_configuration, save_window_save): Handle new
4498 members of window structure.
b9e809c2
MR
4499 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4500 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4501 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4502 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4503 Qget_mru_window, Qresize_root_window,
4504 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4505 Qauto_buffer_name; staticpro them.
f3d1777e 4506
abde8f8c
MR
45072011-06-07 Martin Rudalics <rudalics@gmx.at>
4508
4509 * window.c (Fwindow_total_size, Fwindow_left_column)
4510 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4511 (Fwindow_list_1): New functions.
4512 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4513 (Fwindow_width, Fscroll_left, Fscroll_right):
4514 Use window_body_cols instead of window_box_text_cols.
4515 (delete_window, Fset_window_configuration):
4516 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4517 (delete_all_subwindows): Take a window as argument and not a
4518 structure. Rewrite.
190b47e6
MR
4519 (window_loop): Remove handling of GET_LRU_WINDOW and
4520 GET_LARGEST_WINDOW.
4521 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4522
4523 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4524 window_box_text_cols. delete_all_subwindows now takes a
4525 Lisp_Object as argument.
abde8f8c 4526
640c8776
SM
4527 * indent.c (compute_motion, Fcompute_motion):
4528 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4529
fa8a67e6
MR
4530 * frame.c (delete_frame): Call delete_all_subwindows with root
4531 window as argument.
4532
a54e3482
DC
45332011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4534
4535 * fns.c (Fputhash): Document return value.
4536
60002bf5
CY
45372011-06-06 Chong Yidong <cyd@stupidchicken.com>
4538
4539 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4540
0c671da6 45412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4542
b862a52a 4543 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4544
be44ca6c
PE
4545 Check for overflow when converting integer to cons and back.
4546 * charset.c (Fdefine_charset_internal, Fdecode_char):
4547 Use cons_to_unsigned to catch overflow.
4548 (Fencode_char): Use INTEGER_TO_CONS.
4549 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4550 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4551 * data.c (long_to_cons, cons_to_long): Remove.
4552 (cons_to_unsigned, cons_to_signed): New functions.
4553 These signal an error for invalid or out-of-range values.
4554 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4555 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4556 * font.c (Ffont_variation_glyphs):
4557 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4558 * lisp.h: Include <intprops.h>.
4559 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4560 (cons_to_signed, cons_to_unsigned): New decls.
4561 (long_to_cons, cons_to_long): Remove decls.
4562 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4563 (Fprimitive_undo): Use CONS_TO_INTEGER.
4564 * xfns.c (Fx_window_property): Likewise.
4565 * xselect.c: Include <limits.h>.
4566 (x_own_selection, selection_data_to_lisp_data):
4567 Use INTEGER_TO_CONS.
4568 (x_handle_selection_request, x_handle_selection_clear)
4569 (x_get_foreign_selection, Fx_disown_selection_internal)
4570 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4571 (lisp_data_to_selection_data): Use cons_to_unsigned.
4572 (x_fill_property_data): Use cons_to_signed.
4573 Report values out of range.
4574
d1f3d2af
PE
4575 Check for buffer and string overflow more precisely.
4576 * buffer.h (BUF_BYTES_MAX): New macro.
4577 * lisp.h (STRING_BYTES_MAX): New macro.
4578 * alloc.c (Fmake_string):
4579 * character.c (string_escape_byte8):
4580 * coding.c (coding_alloc_by_realloc):
4581 * doprnt.c (doprnt):
4582 * editfns.c (Fformat):
4583 * eval.c (verror):
4584 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4585 since they may not be the same number.
4586 * editfns.c (Finsert_char):
4587 * fileio.c (Finsert_file_contents):
4588 Likewise for BUF_BYTES_MAX.
4589
dd52fcea
PE
4590 * image.c: Use ptrdiff_t, not int, for sizes.
4591 (slurp_file): Switch from int to ptrdiff_t.
4592 All uses changed.
4593 (slurp_file): Check that file size fits in both size_t (for
4594 malloc) and ptrdiff_t (for sanity and safety).
4595
7f9bbdbb
PE
4596 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4597 if b->modtime has its maximal value.
4598
dfe18f82
PE
4599 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4600
84acfcf0
PE
4601 Don't assume time_t can fit into int.
4602 * buffer.h (struct buffer.modtime): Now time_t, not int.
4603 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4604 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4605
ccd9a01a
PE
4606 Minor fixes for signed vs unsigned integers.
4607 * character.h (MAYBE_UNIFY_CHAR):
4608 * charset.c (maybe_unify_char):
4609 * keyboard.c (read_char, reorder_modifiers):
4610 XINT -> XFASTINT, since the integer must be nonnegative.
4611 * ftfont.c (ftfont_spec_pattern):
4612 * keymap.c (access_keymap, silly_event_symbol_error):
4613 XUINT -> XFASTINT, since the integer must be nonnegative.
4614 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4615 since it makes no difference and we prefer signed.
4616 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4617 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4618 nonnegative.
4619
d6d100dd
SM
46202011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4621
4622 * window.h (Fwindow_frame): Declare.
4623
2b6148e4
PE
46242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4625
4626 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4627 (SPARE_MEMORY): Always define.
4628 (LARGE_REQUEST): Remove.
4629 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4630
f230ecc9
MR
46312011-06-06 Martin Rudalics <rudalics@gmx.at>
4632
727e958e
MR
4633 * lisp.h: Move EXFUNS for Fframe_root_window,
4634 Fframe_first_window and Fset_frame_selected_window to window.h.
4635
4636 * window.h: Move EXFUNS for Fframe_root_window,
4637 Fframe_first_window and Fset_frame_selected_window here from
4638 lisp.h.
4639
4640 * frame.c (Fwindow_frame, Fframe_first_window)
4641 (Fframe_root_window, Fframe_selected_window)
4642 (Fset_frame_selected_window): Move to window.c.
4643 (Factive_minibuffer_window): Move to minibuf.c.
4644 (Fother_visible_frames_p): New function.
4645
4646 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4647
f230ecc9
MR
4648 * window.c (decode_window, decode_any_window): Move up in code.
4649 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4650 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4651 (Fwindow_buffer): Move up and rewrite doc-string.
4652 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4653 (Fwindow_prev): New functions.
727e958e
MR
4654 (Fwindow_frame): Move here from frame.c. Accept any window as
4655 argument.
4656 (Fframe_root_window, Fframe_first_window)
4657 (Fframe_selected_window): Move here from frame.c. Accept frame
4658 or arbitrary window as argument. Update doc-strings.
4659 (Fminibuffer_window): Move up in code.
4660 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4661 (Fset_frame_selected_window): Move here from frame.c.
4662 Marginal rewrite.
727e958e
MR
4663 (Fselected_window, select_window, Fselect_window): Move up in
4664 code. Minor doc-string fixes.
f230ecc9 4665
4d09bcf6
PE
46662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4667
4668 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4669 Do not assume that spare memory exists; that assumption is valid
4670 only if SYSTEM_MALLOC.
4671 (LARGE_REQUEST): New macro, so that the issue of large requests
4672 is separated from the issue of spare memory.
4673
810928a2
AS
46742011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4675
172418ad
AS
4676 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4677 format. (Bug#8806)
4678
43f862f7
AS
4679 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4680
810928a2
AS
4681 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4682 before statements.
4683
a059fe24
JD
46842011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4685
4686 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4687
4688 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4689
4690 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4691 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4692
989bf368
JB
46932011-06-05 Juanma Barranquero <lekktu@gmail.com>
4694
4695 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4696
4b80f674
CY
46972011-06-04 Chong Yidong <cyd@stupidchicken.com>
4698
4699 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4700 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4701 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4702 New error handlers.
4b80f674
CY
4703 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4704 Obey Vx_select_enable_clipboard_manager. Catch errors in
4705 x_clipboard_manager_save (Bug#8779).
4706 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4707 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4708
99a33b77 47092011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4710
4711 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4712
99a33b77 47132011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4714
4715 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4716 in the current matrix if keep_current_p is non-zero.
4717
8264569d
EZ
47182011-06-04 Eli Zaretskii <eliz@gnu.org>
4719
4720 * bidi.c (bidi_level_of_next_char): Fix last change.
4721
57f97249
EZ
47222011-06-03 Eli Zaretskii <eliz@gnu.org>
4723
fec2107c 4724 Support bidi reordering of text covered by display properties.
57f97249 4725
fec2107c
EZ
4726 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4727 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4728 (bidi_cache_search, bidi_cache_iterator_state)
4729 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4730 (bidi_level_of_next_char, bidi_move_to_visually_next):
4731 Support character positions inside a run of characters covered by a
fec2107c
EZ
4732 display string.
4733 (bidi_paragraph_init, bidi_resolve_explicit_1)
4734 (bidi_level_of_next_char): Call bidi_fetch_char and
4735 bidi_fetch_char_advance instead of FETCH_CHAR and
4736 FETCH_CHAR_ADVANCE.
4737 (bidi_init_it): Initialize new members.
4738 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4739 definitions.
4740 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4741 instead of using explicit *_CHAR codes.
d6d100dd
SM
4742 (bidi_resolve_explicit, bidi_resolve_weak):
4743 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4744 bidirectional text is supported only in multibyte buffers.
4745 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4746 it to initialize the frame_window_p member of struct bidi_it.
4747 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4748 (bidi_resolve_explicit, bidi_resolve_weak)
4749 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4750 bidi_it->nchars is non-positive.
4751 (bidi_level_of_next_char): Don't try to lookup the cache for the
4752 next/previous character if nothing is cached there yet, or if we
4753 were just reseat()'ed to a new position.
c40e2fb2 4754
0e14fe90
EZ
4755 * xdisp.c (set_cursor_from_row): Set start and stop points
4756 according to the row's direction when priming the loop that looks
4757 for the glyph on which to display cursor.
4758 (single_display_spec_intangible_p): Function deleted.
4759 (display_prop_intangible_p): Reimplement to call
4760 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4761 Accept 3 additional arguments needed by handle_display_spec.
4762 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4763 values: lists, `(when COND...)' forms, etc.
4764 (single_display_spec_string_p): Support property values that are
4765 lists with the argument STRING its top-level element.
4766 (display_prop_string_p): Fix the condition for processing a
4767 property that is a list to be consistent with handle_display_spec.
fec2107c 4768 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4769 last portion of handle_display_prop.
4770 (compute_display_string_pos): Accept additional argument
4771 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4772 value of a `display' property is a "replacing spec".
4773 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4774 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4775 the display property, but just return a value indicating whether
4776 the display property will replace the characters it covers.
4777 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4778 frame_window_p members of struct bidi_it.
d6d100dd
SM
4779 (compute_display_string_pos, compute_display_string_end):
4780 New functions.
fec2107c
EZ
4781 (push_it): Accept second argument POSITION, where pop_it should
4782 jump to continue iteration.
4783 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4784
fec2107c
EZ
4785 * keyboard.c (adjust_point_for_property): Adjust the call to
4786 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4787
4788 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4789 (bidi_init_it): Update prototypes.
4790 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4791 (compute_display_string_pos, compute_display_string_end):
4792 Declare prototypes.
fec2107c
EZ
4793 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4794 EMACS_INT.
fc6f18ce 4795
40087514 47962011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4797
57f53182
PE
4798 Malloc failure behavior now depends on size of allocation.
4799 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4800 * lisp.h: Change signatures accordingly.
4801 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4802 All callers changed. (Bug#8762)
4803
4804 * gnutls.c: Use Emacs's memory allocators.
4805 Without this change, the gnutls library would invoke malloc etc.
4806 directly, which causes problems on non-SYNC_INPUT hosts, and which
4807 runs afoul of improving memory_full behavior. (Bug#8761)
4808 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4809 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4810 xfree instead of the default malloc, realloc, free.
4811 (Fgnutls_boot): No need to check for memory allocation failure,
4812 since xmalloc does that for us.
4813
ac32cd99 4814 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4815 * category.c (hash_get_category_set):
4816 * ccl.c (ccl_driver):
4817 * charset.c (Fdefine_charset_internal):
4818 * charset.h (struct charset.hash_index):
4819 * composite.c (get_composition_id, gstring_lookup_cache)
4820 (composition_gstring_put_cache):
4821 * composite.h (struct composition.hash_index):
4822 * dispextern.h (struct image.hash):
4823 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4824 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4825 (hashfn_equal, hashfn_user_defined, make_hash_table)
4826 (maybe_resize_hash_table, hash_lookup, hash_put)
4827 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4828 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4829 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4830 * image.c (make_image, search_image_cache, lookup_image)
4831 (xpm_put_color_table_h):
4832 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4833 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4834 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4835 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4836 * alloc.c (allocate_vectorlike):
4837 Check for overflow in vector size calculations.
4838 * ccl.c (ccl_driver):
4839 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4840 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4841 need to be updated by these changes.
40087514
PE
4842 * fns.c (make_hash_table, maybe_resize_hash_table):
4843 Check for integer overflow with large hash tables.
0de4bb68
PE
4844 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4845 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4846 (SXHASH_REDUCE): New macro.
4847 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4848 Use it instead of discarding useful hash info with large hash values.
4849 (sxhash_float): New function.
4850 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4851 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4852 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4853 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4854 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4855 Adjust signatures to match updated version of code.
4856 (consing_since_gc): Now EMACS_INT, since a single hash table can
4857 use more than INT_MAX bytes.
4858
698d32e2
DN
48592011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4860
4861 Make it possible to build with GCC-4.6+ -O2 -flto.
4862
4863 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4864
fd6fa53f
SM
48652011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4866
4867 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4868 Call minibuffer-inactive-mode.
4869
864db017
JB
48702011-05-31 Juanma Barranquero <lekktu@gmail.com>
4871
4872 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4873 Update dependencies.
4874
2ad0baf4
DN
48752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4876
4877 * data.c (init_data): Remove code for UTS, this system is not
4878 supported anymore.
4879
4fcc2638
DN
48802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4881
4882 Don't force ./temacs to start in terminal mode.
4883
4884 * frame.c (make_initial_frame): Initialize faces in all cases, not
4885 only when CANNOT_DUMP is defined.
4886 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4887
c56e0fd5
DN
48882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4889
4890 * dispnew.c (add_window_display_history): Use const for the string
4891 pointer. Remove declaration, not needed.
4892
333d54da 48932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4894
55d4c1b2 4895 Use 'inline', not 'INLINE'.
333d54da 4896 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4897 * alloc.c, fontset.c (INLINE): Remove.
4898 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4899 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4900 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4901 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4902 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4903
738db178
DN
49042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4905
4906 Make it possible to run ./temacs.
4907
4908 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4909 syms_of_callproc does the same thing. Remove test for
4910 "initialized", do it in the caller.
4911 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4912
620c53a6
SM
49132011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4914
4915 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4916 (read_minibuf): Use get_minibuffer.
4917 (syms_of_minibuf): Use DEFSYM.
4918 (Qmetadata): New var.
4919 * data.c (Qbuffer): Don't make it static.
4920 (syms_of_data): Use DEFSYM.
4921
e003a292
PE
49222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4923
4924 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4925 (CCL_CODE_MIN): New macro.
4926
ed008a6d
PE
49272011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4928
3687c2ef
PE
4929 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4930
ed008a6d
PE
4931 * eval.c (Qdebug): Now static.
4932 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4933 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4934 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4935
d66c4c7c
CY
49362011-05-29 Chong Yidong <cyd@stupidchicken.com>
4937
4938 * image.c: Various fixes to ImageMagick code comments.
4939 (Fimagemagick_types): Doc fix.
4940
5fbc2025
PE
49412011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4942
0196f88a
PE
4943 Minor fixes prompted by GCC 4.6.0 warnings.
4944
4945 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4946
5fbc2025
PE
4947 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4948 (x_clipboard_manager_save_all): Move extern decl to ...
4949 * xterm.h: ... here, so that it can be checked for consistency.
4950
1dd3c2d9
CY
49512011-05-29 Chong Yidong <cyd@stupidchicken.com>
4952
4953 * xselect.c (x_clipboard_manager_save_frame)
4954 (x_clipboard_manager_save_all): New functions.
4955 (Fx_clipboard_manager_save): Lisp function deleted.
4956
4957 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4958 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4959
4960 * xterm.h: Update prototype.
4961
5ba6571d
WX
49622011-05-28 William Xu <william.xwl@gmail.com>
4963
4964 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4965 exiting (Bug#8239).
4966
3eaff834
JM
49672011-05-28 Jim Meyering <meyering@redhat.com>
4968
e1900994 4969 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4970 * fns.c (to_uchar): Define.
4971 (crypto_hash_function): Use it to convert some newly-signed
4972 variables to unsigned, to avoid sign-extension bugs. For example,
4973 without this change, (md5 "truc") would evaluate to
4974 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4975 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4976 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4977
0f6990a7
PE
49782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4979
4980 Integer overflow fixes.
c8a9ca5a 4981
08686060
PE
4982 * dbusbind.c: Serial number integer overflow fixes.
4983 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4984 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4985 to hold a serial number that is too large for a fixnum.
4986 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4987 Check for serial numbers out of range. Decode any serial number
59568bf0 4988 that was so large that it became a float. (Bug#8722)
08686060 4989
2d1fc3c7
PE
4990 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4991 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4992 Use XFASTINT rather than XUINT when numbers are nonnegative.
4993 (xd_append_arg, Fdbus_method_return_internal):
4994 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4995 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4996 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4997 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4998 (Bug#8722)
2d1fc3c7 4999
c8a9ca5a
PE
5000 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5001
519e1d69
PE
5002 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5003
30569699
PE
5004 ccl: add integer overflow checks
5005 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5006 (IN_INT_RANGE): New macros.
5007 (ccl_driver): Use them to check for integer overflow when
5008 decoding a CCL program. Many of the new checks are whether XINT (x)
5009 fits in int; it doesn't always, on 64-bit hosts. The new version
5010 doesn't catch all possible integer overflows, but it's an
847044ea 5011 improvement. (Bug#8719)
30569699 5012
c11285dc
PE
5013 * alloc.c (make_event_array): Use XINT, not XUINT.
5014 There's no need for unsigned here.
5015
fdccd48e
PE
5016 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5017 This follows up to the 2011-05-06 change that substituted uintptr_t
5018 for EMACS_INT. This case wasn't caught back then.
5019
37910ab2
PE
5020 Rework Fformat to avoid integer overflow issues.
5021 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5022 now (part of C89). Include <verify.h>.
5023 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5024 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5025 (Fformat): Avoid the prepass trying to compute sizes; it was only
5026 approximate and thus did not catch overflow reliably. Instead, walk
5027 through the format just once, formatting and computing sizes as we go,
5028 checking for integer overflow at every step, and allocating a larger
5029 buffer as needed. Keep track separately whether the format is
5030 multibyte. Keep only the most-recently calculated precision, rather
5031 than them all. Record whether each argument has been converted to
5032 string. Use EMACS_INT, not int, for byte and char and arg counts.
5033 Support field widths and precisions larger than INT_MAX. Avoid
5034 sprintf's undefined behavior with conversion specifications such as %#d
5035 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5036 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5037 formatting out-of-range floating point numbers with int
9173deec 5038 formats. (Bug#8668)
37910ab2 5039
2e6578fb
PE
5040 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5041
0ae6bdee
PE
5042 * data.c: Avoid integer truncation in expressions involving floats.
5043 * data.c: Include <intprops.h>.
5044 (arith_driver): When there's an integer overflow in an expression
5045 involving floating point, convert the integers to floating point
5046 so that the resulting value does not suffer from catastrophic
5047 integer truncation. For example, on a 64-bit host (* 4
5048 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5049 Do not rely on undefined behavior after integer overflow.
5050
de883a70
PE
5051 merge count_size_as_multibyte, parse_str_to_multibyte
5052 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5053 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5054 Check for integer overflow.
5055 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5056 since it's now a duplicate of the other. This is more of
5057 a character than a buffer op, so better that it's in character.c.
5058 * fns.c, print.c: Adjust to above changes.
5059
2ff916cb
PE
50602011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5061
5062 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5063
f1b54466
PE
50642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5065
fb1ac845
PE
5066 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5067 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5068 (x_clipboard_manager_save): Now static.
5069 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5070
f1b54466
PE
5071 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5072 (crypto_hash_function): Now static.
5073 Fix pointer signedness problems. Avoid unnecessary initializations.
5074
a9f737ee
CY
50752011-05-27 Chong Yidong <cyd@stupidchicken.com>
5076
5077 * termhooks.h (Vselection_alist): Make it terminal-local.
5078
5079 * terminal.c (create_terminal): Initialize it.
5080
5081 * xselect.c: Support for clipboard managers.
5082 (Vselection_alist): Move to termhooks.h as terminal-local var.
5083 (LOCAL_SELECTION): New macro.
5084 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5085 (symbol_to_x_atom): Remove gratuitous arg.
5086 (x_handle_selection_request, lisp_data_to_selection_data)
5087 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5088 (x_own_selection, x_get_local_selection, x_convert_selection):
5089 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5090 (some_frame_on_display): Delete unused function.
5091 (Fx_own_selection_internal, Fx_get_selection_internal)
5092 (Fx_disown_selection_internal, Fx_selection_owner_p)
5093 (Fx_selection_exists_p): New optional frame arg.
5094 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5095 (x_handle_selection_clear): Don't treat other terminals with the
5096 same keyboard specially. Use the terminal-local Vselection_alist.
5097 (x_clear_frame_selections): Use Frun_hook_with_args.
5098
5099 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5100
5101 * xterm.h: Add support for those atoms.
5102
e067f0c1
CY
51032011-05-26 Chong Yidong <cyd@stupidchicken.com>
5104
5105 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5106 (converted_selections, conversion_fail_tag): New global variables.
5107 (x_selection_request_lisp_error): Free the above.
5108 (x_get_local_selection): Remove unnecessary code.
5109 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5110 of converted selections stored in converted_selections.
5111 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5112 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5113 (x_convert_selection): New function.
5114 (x_handle_selection_event): Simplify.
5115 (x_get_foreign_selection): Don't ignore incoming requests while
5116 waiting for an answer; this will fail when we implement
5117 SAVE_TARGETS, and seems unnecessary anyway.
5118 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5119 (Vx_sent_selection_functions): Doc fix.
5120
0f4aebc0
LL
51212011-05-26 Leo Liu <sdl.web@gmail.com>
5122
5123 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5124
e61124cd
YM
51252011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5126
5127 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5128
5129 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5130 for fringe update if it has periodic bitmap.
ac389d0c 5131 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5132 and fringe_bitmap_periodic_p.
5133
5134 * fringe.c (get_fringe_bitmap_data): New function.
5135 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5136 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5137 row. Mark glyph row for fringe update if periodicity changed.
5138
5139 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5140 for fringe update unless it has periodic bitmap.
5141
f16d9837
KH
51422011-05-25 Kenichi Handa <handa@m17n.org>
5143
5144 * xdisp.c (get_next_display_element): Set correct it->face_id for
5145 a static composition.
5146
e1b90ef6
LL
51472011-05-24 Leo Liu <sdl.web@gmail.com>
5148
5149 * deps.mk (fns.o):
5150 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5151
5152 * fns.c (crypto_hash_function, Fsha1): New function.
5153 (Fmd5): Use crypto_hash_function.
5154 (syms_of_fns): Add Ssha1.
5155
7400048f
PE
51562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5157
5158 * gnutls.c: Remove unused macros.
5159 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5160 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5161 Remove macros that are defined and never used.
5162 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5163
abb71cf4
CY
51642011-05-22 Chong Yidong <cyd@stupidchicken.com>
5165
5166 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5167 (Fx_get_selection_internal): Minor cleanup.
5168 (Fx_own_selection_internal): Rename arguments for consistency with
5169 select.el.
5170
6307db39
PE
51712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5172
5173 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5174
f3d4e0a4
CY
51752011-05-22 Chong Yidong <cyd@stupidchicken.com>
5176
5177 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5178
4d8ade89
YM
51792011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5180
5181 * dispnew.c (scrolling_window): Don't exclude the case that the
5182 last enabled row in the desired matrix touches the bottom boundary.
5183
32078c8d
GM
51842011-05-21 Glenn Morris <rgm@gnu.org>
5185
5186 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5187 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5188 and add some more files.
32078c8d 5189
7285dc67
EZ
51902011-05-20 Eli Zaretskii <eliz@gnu.org>
5191
5192 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5193 report_file_error introduced by the change from 2011-05-07.
5194
89d1bd22
PE
51952011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5196
5197 * systime.h (Time): Define only if emacs is defined.
5198 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5199 where the include path doesn't have X11/X.h by default. See
5200 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5201
e23640bb 52022011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5203
5204 * composite.c (find_automatic_composition): Fix previous change.
5205
b9704ad9
GM
52062011-05-20 Glenn Morris <rgm@gnu.org>
5207
5208 * lisp.mk: New file, split from Makefile.in.
5209 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5210 (shortlisp): Remove.
5211 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5212
4a720484
GM
52132011-05-19 Glenn Morris <rgm@gnu.org>
5214
5215 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5216 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5217 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5218 (lisp): Set the order to that of loadup.el.
5219 (shortlisp): Make it a copy of $lisp.
5220 (SOME_MACHINE_LISP): Remove.
5221 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5222 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5223
a28d4396
KH
52242011-05-18 Kenichi Handa <handa@m17n.org>
5225
5226 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5227 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5228 (find_automatic_composition): Mostly rewrite for efficiency.
5229
a2b1fa8e
JB
52302011-05-18 Juanma Barranquero <lekktu@gmail.com>
5231
5232 * makefile.w32-in: Update dependencies.
5233
8e1f5610
CS
52342011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5235
5236 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5237 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5238
7025ee00 52392011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5240
cdfa6eab
PE
5241 Fix some integer overflow issues, such as string length overflow.
5242
06d6db33
PE
5243 * insdel.c (count_size_as_multibyte): Check for string overflow.
5244
2b4560a8
PE
5245 * character.c (lisp_string_width): Check for string overflow.
5246 Use EMACS_INT, not int, for string indexes and lengths; in
5247 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5248 the resulting string length overflows an EMACS_INT; instead,
5249 report a string overflow if no precision given. When checking for
5250 precision exhaustion, use a check that cannot possibly have
5251 integer overflow. (Bug#8675)
5252 * character.h (lisp_string_width): Adjust to new signature.
5253
cb93f9be
PE
5254 * alloc.c (string_overflow): New function.
5255 (Fmake_string): Use it. This doesn't change behavior, but saves
5256 a few bytes and will simplify future changes.
5257 * character.c (string_escape_byte8): Likewise.
5258 * lisp.h (string_overflow): New decl.
5259
1a1f3366
PE
5260 Fixups, following up to the user-interface timestamp change.
5261 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5262 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5263 * msdos.c (mouse_get_pos): Likewise.
5264 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5265 * w32gui.h (Time): Define by including "systime.h" rather than by
5266 declaring it ourselves. (Bug#8664)
5267
d4e3e4d3
PE
5268 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5269 * image.c (clear_image_cache): Likewise.
5270
f6a24d19
PE
5271 * term.c (term_mouse_position): Don't assume time_t wraparound.
5272
08dc5ae6
PE
5273 Be more systematic about user-interface timestamps.
5274 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5275 and sometimes 'EMACS_UINT', to represent these timestamps.
5276 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5277 This makes the code easier to follow, and makes it easier to catch
5278 integer overflow bugs such as Bug#8664.
5279 * frame.c (Fmouse_position, Fmouse_pixel_position):
5280 Use Time, not unsigned long, for user-interface timestamps.
5281 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5282 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5283 * keyboard.h (last_event_timestamp): Likewise.
5284 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5285 * menu.h (xmenu_show): Likewise.
5286 * term.c (term_mouse_position): Likewise.
5287 * termhooks.h (struct input_event.timestamp): Likewise.
5288 (struct terminal.mouse_position_hook): Likewise.
5289 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5290 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5291 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5292 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5293 what it was before.
5294 * menu.h, termhooks.h: Include "systime.h", for Time.
5295
8e55734a
PE
5296 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5297 Don't assume that the difference between two unsigned long values
5298 can fit into an integer. At this point, we know button_down_time
5299 <= event->timestamp, so the difference must be nonnegative, so
5300 there's no need to cast the result if double-click-time is
5301 nonnegative, as it should be; check that it's nonnegative, just in
5302 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5303 apart (about 25 days). (Bug#8664)
8e55734a 5304
841f1b75 5305 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5306 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5307
3e26f69c
PE
5308 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5309 that always fit in int. Use a sentinel instead of a counter, to
5310 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5311 * frame.h (struct frame): Use int for menu_bar_items_used
5312 instead of EMACS_INT, since it always fits in int.
3e26f69c 5313
5cc152c0
PE
5314 * menu.c (grow_menu_items): Check for int overflow.
5315
d89eb65e
PE
5316 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5317
5235bd3e
PE
5318 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5319 Before, the code was not consistent. These values cannot exceed
5320 2**31 - 1 so there's no need to make them unsigned.
5321 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5322 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5323 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5324 as modifiers.
5325 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5326
bc827e23
PE
5327 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5328 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5329 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5330 presumably because the widths might not match.
5331
78eb494e
PE
5332 * window.c (size_window): Avoid needless test at loop start.
5333
04f2d78b
CB
53342011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5335
5336 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5337
d2fc7e3d 53382011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5339
5340 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5341
d2fc7e3d 53422011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5343
5344 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5345 `width' to `bar_area_x' and `bar_area_width', respectively.
5346 (x_scroll_run): Take account of fringe background extension.
5347
04f2d78b
CB
5348 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5349 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5350 `bar_area_width', respectively.
5351 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5352 background extension.
5353
79b70037
GM
53542011-05-10 Jim Meyering <meyering@redhat.com>
5355
5356 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5357
2f142cc5
JB
53582011-05-10 Juanma Barranquero <lekktu@gmail.com>
5359
5360 * image.c (Finit_image_library): Return t for built-in image types,
5361 like pbm and xbm. (Bug#8640)
5362
57679c86
AS
53632011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5364
5365 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5366
888c9e86
EZ
53672011-05-07 Eli Zaretskii <eliz@gnu.org>
5368
b0512a1d
EZ
5369 * w32console.c (Fset_screen_color): Doc fix.
5370 (Fget_screen_color): New function.
5371 (syms_of_ntterm): Defsubr it.
5372
7285dc67
EZ
5373 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5374 unlink the temporary file if Fcall_process didn't create it in the
5375 first place.
5376 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5377 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5378 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5379 cue to call_process_cleanup not to close that handle.
5380
4d3fcc8e
BK
53812011-05-07 Ben Key <bkey76@gmail.com>
5382
5383 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5384 one of two shell specific rules, either bootstrap-temacs-CMD or
5385 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5386 to the previous implementation of the bootstrap-temacs rule.
5387 The bootstrap-temacs-CMD rule is similar to the previous
5388 implementation of the bootstrap-temacs rule except that it
5389 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5390 variable.
5391
5392 These changes, along with some changes to nt/configure.bat,
5393 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5394 earlier fix to add support for --cflags and --ldflags options
5395 that include quotes so that it works whether make uses cmd or
5396 sh as the shell.
5397
b4289b64
MA
53982011-05-06 Michael Albinus <michael.albinus@gmx.de>
5399
5400 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5401 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5402 is a constant.
5403 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5404 a string. Handle both cases.
5405 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5406 (Fdbus_register_method): Use Qinvalid_function.
5407
af4c0e28
JB
54082011-05-06 Juanma Barranquero <lekktu@gmail.com>
5409
5410 * makefile.w32-in: Update dependencies.
5411 (LISP_H): Add inttypes.h and stdin.h.
5412 (PROCESS_H): Add unistd.h.
5413
c51453d9
EZ
54142011-05-06 Eli Zaretskii <eliz@gnu.org>
5415
5416 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5417 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5418
8ff0ac3c 54192011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5420
4c4b566b
PE
5421 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5422
aab2b9b5
PE
5423 * term.c (vfatal): Remove stray call to va_end.
5424 It's not needed and the C Standard doesn't allow it here anyway.
5425
c378da0b
PE
5426 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5427 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5428
288b08c7
PE
5429 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5430 bytes.
5431
e3601888
PE
5432 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5433
db6c0e74
PE
5434 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5435
dd5963ea
PE
5436 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5437
88c9450f
PE
5438 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5439
2f9442b8
PE
5440 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5441
c032b5f8
PE
5442 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5443 * charset.c (Fdefine_charset_internal): Don't initialize
5444 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5445 32-bit int (Bug#8600).
a108c10b
PE
5446
5447 * lread.c (read_integer): Be more consistent with string-to-number.
5448 Use string_to_number to do the actual conversion; this avoids
5449 rounding errors and fixes some other screwups. Without this fix,
5450 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5451 (digit_to_number): Move earlier, for benefit of read_integer.
5452 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5453 not a digit in any supported base. (Bug#8602)
a108c10b 5454
ad5f9eea
PE
5455 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5456
aec1708a
PE
5457 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5458 to match comment at start of function. This also removes a
5459 GCC warning about overflow in a 32+64-bit port.
5460
47be4ab5
PE
5461 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5462
371cac43
PE
5463 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5464 Reported by Stefan Monnier in
5465 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5466 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5467 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5468
d01a7826
PE
5469 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5470 (EMACS_UINTPTR): Likewise, with uintptr_t.
5471
7fd47d5c
PE
5472 * lisp.h: Prefer 64-bit EMACS_INT if available.
5473 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5474 on 32-bit hosts that have 64-bit int, so that they can access
5475 large files.
122b0c86
PE
5476 However, temporarily disable this change unless the temporary
5477 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5478
8727937b
PE
5479 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5480
8ac068ac
PE
5481 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5482 This removes an assumption that EMACS_INT and long are the same
5483 width as pointers. The assumption is true for Emacs porting targets
5484 now, but we want to make other targets possible.
5485 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5486 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5487 In the rest of the code, change types of integers that hold casted
5488 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5489 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5490 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5491 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5492 No need to cast type when ORing.
5493 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5494 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5495 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5496 assume EMACS_INT is the same width as char *.
5497 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5498 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5499 Remove no-longer-needed casts.
5500 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5501 (xg_tool_bar_help_callback, xg_make_tool_item):
5502 Use EMACS_INTPTR to hold an integer
5503 that will be cast to void *; this can avoid a GCC warning
5504 if EMACS_INT is not the same width as void *.
5505 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5506 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5507 (current_message_1, set_message_1):
5508 Use a local to convert to proper width without a cast.
5509 * xmenu.c (dialog_selection_callback): Likewise.
5510
ede49d71
PE
5511 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5512 Also, don't assume VALBITS / RAND_BITS is less than 5,
5513 and don't rely on undefined behavior when shifting a 1 left into
5514 the sign bit.
5515 * lisp.h (get_random): Change signature to match.
5516
2f30ecd0
PE
5517 * lread.c (hash_string): Use size_t, not int, for hash computation.
5518 Normally we prefer signed values; but hashing is special, because
5519 it's better to use unsigned division on hash table sizes so that
5520 the remainder is nonnegative. Also, size_t is the natural width
5521 for hashing into memory. The previous code used 'int', which doesn't
5522 retain enough info to hash well into very large tables.
5523 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5524
2a866e7b
PE
5525 * dbusbind.c: Don't possibly lose pointer info when converting.
5526 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5527 Use XPNTR rather than XHASH, so that the high-order bits of
5528 the pointer aren't lost when converting through void *.
5529
51639eac
PE
5530 * eval.c (Fautoload): Don't double-shift a pointer.
5531
92394119
PE
5532 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5533
dbdb9a7c
JB
55342011-05-06 Juanma Barranquero <lekktu@gmail.com>
5535
5536 * gnutls.c (DEF_GNUTLS_FN):
5537 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5538
db7a0b4f
AS
55392011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5540
5541 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5542 marker. (Bug#8610)
5543
f7ff1b0f 55442011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5545
5546 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5547 New version that can reserve upto 2GB of heap space.
5548
f7ff1b0f 55492011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5550
5551 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5552
639c109b
TZ
55532011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5554
5555 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5556 `gnutls_certificate_set_x509_key_file'.
5557
d2127135
JB
55582011-05-05 Juanma Barranquero <lekktu@gmail.com>
5559
5560 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5561 Update dependencies.
5562
e968f4f3
JB
55632011-05-04 Juanma Barranquero <lekktu@gmail.com>
5564
5565 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5566 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5567 Remove unused parameter `fildes'.
5568 * process.c (read_process_output, send_process): Don't pass it.
5569
84d358f0
JB
55702011-05-04 Juanma Barranquero <lekktu@gmail.com>
5571
5572 Fix previous change: the library cache is defined in w32.c.
5573 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5574 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5575
0898ca10
JB
55762011-05-04 Juanma Barranquero <lekktu@gmail.com>
5577
5578 Implement dynamic loading of GnuTLS on Windows.
5579
5580 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5581 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5582 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5583 Declare.
5584
5585 * gnutls.c (Qgnutls_dll): Define.
5586 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5587 (gnutls_*): Declare function pointers.
5588 (init_gnutls_functions): New function to initialize function pointers.
5589 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5590 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5591 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5592 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5593 (emacs_gnutls_write, emacs_gnutls_read)
5594 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5595 (Fgnutls_available_p): New function.
5596 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5597 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5598 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5599
5600 * image.c: Include w32.h.
5601 (Vimage_type_cache): Delete.
5602 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5603 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5604 (w32_delayed_load): Move to w32.c.
5605
5606 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5607
5608 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5609 (w32_delayed_load): Move from image.c. When loading a library, record
5610 its filename in the :loaded-from property of the library id.
5611 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5612 Initialize and staticpro them.
5613 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5614
5615 * process.c: Include lisp.h before w32.h, not after.
5616 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5617 instead of gnutls_record_check_pending.
5618
5619 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5620
ff4de4aa
TZ
56212011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5622
5623 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5624 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5625 as passed in.
5626
abe95abb
JD
56272011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5628
5629 * xterm.c (x_set_frame_alpha): Do not set property on anything
5630 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5631
e16e55d4
JB
56322011-05-02 Juanma Barranquero <lekktu@gmail.com>
5633
5634 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5635
bafcf6a5
JB
56362011-05-02 Juanma Barranquero <lekktu@gmail.com>
5637
5638 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5639 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5640 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5641 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5642 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5643 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5644 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5645 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5646 (Qgnutls_bootprop_callbacks_verify): Make static.
5647
e7a6747f
AS
56482011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5649
19ed11ba
AS
5650 * callproc.c: Indentation fixup.
5651
e7a6747f 5652 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5653 (wait_for_termination, interruptible_wait_for_termination):
5654 Move after wait_for_termination_1.
e7a6747f 5655
1ef14cb4
LMI
56562011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5657
5658 * sysdep.c (interruptible_wait_for_termination): New function
5659 which is like wait_for_termination, but allows keyboard
5660 interruptions.
5661
5662 * callproc.c (Fcall_process): Add (:file "file") as an option for
5663 the STDOUT buffer.
5664 (Fcall_process_region): Ditto.
5665
330d880c
EZ
56662011-04-30 Eli Zaretskii <eliz@gnu.org>
5667
8db90b73
EZ
5668 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5669 rather than `XVECTOR (FOO)->size'.
5670
330d880c
EZ
5671 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5672 inttypes.h, as a gnulib replacement is used if it not available in
5673 system headers.
5674
15cbd324
EZ
56752011-04-21 Eli Zaretskii <eliz@gnu.org>
5676
5677 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5678 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5679 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5680
5681 * coding.c (coding_alloc_by_realloc): Error out if destination
5682 will grow beyond MOST_POSITIVE_FIXNUM.
5683 (decode_coding_emacs_mule): Abort if there isn't enough place in
5684 charbuf for the composition carryover bytes. Reserve an extra
5685 space for up to 2 characters produced in a loop.
5686 (decode_coding_iso_2022): Abort if there isn't enough place in
5687 charbuf for the composition carryover bytes.
5688
56892011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5690
ae940cca
EZ
5691 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5692 aborting when %lld or %lll format is passed.
5693 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5694 %llo or %llx format is passed. (Bug#8545)
5695
03ab8921
EZ
5696 * window.c (window_scroll_line_based): Use a marker instead of
5697 simple variables to record original value of point. (Bug#7952)
5698
afda1437
EZ
5699 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5700 produced by %s or %c overflows available buffer space. (Bug#8545)
5701
f76dee0c
PE
57022011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5703
5704 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5705 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5706
fdc5744d
JB
57072011-04-28 Juanma Barranquero <lekktu@gmail.com>
5708
5709 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5710
638f053a
JB
57112011-04-28 Juanma Barranquero <lekktu@gmail.com>
5712
5713 * keyboard.c (Qdelayed_warnings_hook): Define.
5714 (command_loop_1): Run `delayed-warnings-hook'
5715 if Vdelayed_warnings_list is non-nil.
5716 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5717 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5718
d178f871
EZ
57192011-04-28 Eli Zaretskii <eliz@gnu.org>
5720
5721 * doprnt.c (doprnt): Don't return value smaller than the buffer
5722 size if the message was truncated. (Bug#8545).
5723
b124fd93
JB
57242011-04-28 Juanma Barranquero <lekktu@gmail.com>
5725
5726 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5727 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5728
e810457d
PE
57292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5732
ea51cceb
JB
57332011-04-27 Juanma Barranquero <lekktu@gmail.com>
5734
5735 * makefile.w32-in: Update dependencies.
5736
94dcfacf
EZ
57372011-04-27 Eli Zaretskii <eliz@gnu.org>
5738
5739 Improve `doprnt' and its usage. (Bug#8545)
5740 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5741 `format_end'. Remove support for %l as a conversion specifier.
5742 Don't use xrealloc. Improve diagnostics when the %l size modifier
5743 is used. Update the commentary.
5744
5745 * eval.c (verror): Simplify calculation of size_t.
5746
5747 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5748 messages.
5749
f61f41d7
PE
57502011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5751
5752 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5753 change.
5754
96fb4434
PE
57552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5756
5757 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5758 This makes this file independent of the recent pseudovector change.
5759
671875da 57602011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5761
69e9b5a3
PE
5762 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5763
b5f869a7 5764 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5765 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5766 Remove unused local.
c8926152 5767 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5768
841a1577 5769 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5770 GCC 4.6.0 optimizes based on type-based alias analysis.
5771 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5772 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5773 != &v->size, and therefore "v->size = 1; b->size = 2; return
5774 v->size;" must therefore return 1. This assumption is incorrect
5775 for Emacs, since it type-puns struct Lisp_Vector * with many other
5776 types. To fix this problem, this patch adds a new type struct
f904488f 5777 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5778 and pseudovectors, and helps optimizing compilers not get fooled
5779 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5780 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5781 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5782 the size member.
eab3844f
PE
5783 (XSETPVECTYPE): Rewrite in terms of new macro.
5784 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5785 This is a bit clearer, and further avoids the possibility of
5786 undesirable aliasing.
5787 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5788 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5789 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5790 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5791 (ASIZE): Now uses header.size rather than size.
5792 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5793 to avoid the hassle of writing XVECTOR (foo)->header.size.
5794 (struct vectorlike_header): New type.
eab3844f
PE
5795 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5796 object, to help avoid aliasing.
5797 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5798 (SUBRP): Likewise, since Lisp_Subr is a special case.
5799 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5800 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5801 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5802 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5803 changed to be "header.size" and "header.next".
5804 * buffer.h (struct buffer): Likewise.
5805 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5806 * frame.h (struct frame): Likewise.
5807 * process.h (struct Lisp_Process): Likewise.
5808 * termhooks.h (struct terminal): Likewise.
5809 * window.c (struct save_window_data, struct saved_window): Likewise.
5810 * window.h (struct window): Likewise.
5811 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5812 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5813 * buffer.c (init_buffer_once): Likewise.
5814 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5815 special case.
5816 * process.c (Fformat_network_address): Use local var for size,
5817 for brevity.
5818
0df1eac5
PE
5819 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5820
847ab9d1 5821 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5822 * data.c (atof): Remove decl; no longer used or needed.
5823 (digit_to_number): Move to lread.c.
5824 (Fstring_to_number): Use new string_to_number function, to be
5825 consistent with how the Lisp reader treats infinities and NaNs.
5826 Do not assume that floating-point numbers represent EMACS_INT
5827 without losing information; this is not true on most 64-bit hosts.
5828 Avoid double-rounding errors, by insisting on integers when
5829 parsing non-base-10 numbers, as the documentation specifies.
5830 * lisp.h (string_to_number): New decl, replacing ...
5831 (isfloat_string): Remove.
bc0a5c13 5832 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5833 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5834 appears to have been a coding error. Similarly, do not accept
5835 strings like +-1e0 as floating point numbers. Do not report
5836 overflow for integer overflows unless the base is not 10 which
5837 means we have no simple and reliable way to continue.
5838 Break out the floating-point parsing into a new
5839 function string_to_number, so that Fstring_to_number parses
5840 floating point numbers consistently with the Lisp reader.
04f2d78b 5841 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5842 (E_CHAR, EXP_INT): Remove, replacing with ...
5843 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5844 (string_to_number): New function, replacing isfloat_string.
5845 This function checks for valid syntax and produces the resulting
5846 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5847 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5848 so that overflow for non-base-10 numbers is reported only when
5849 there's no portable and simple way to convert to floating point.
452f4150 5850
67769ffc
PE
5851 * textprop.c (set_text_properties_1): Rewrite for clarity,
5852 and to avoid GCC warning about integer overflow.
5853
c20db43f
PE
5854 * intervals.h (struct interval): Use EMACS_INT for members
5855 where EMACS_UINT might cause problems. See
5856 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5857 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5858 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5859 All uses changed.
37aa2f85
PE
5860 (offset_intervals): Tell GCC not to worry about length overflow
5861 when negating a negative length.
c20db43f 5862
2538aa2f
PE
5863 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5864 (overrun_check_free): Likewise.
5865
f2d3008d
PE
5866 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5867 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5868 word size.
5869
ec8df744
PE
5870 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5871 (gnutls_make_error): Rename local to avoid shadowing.
5872 (gnutls_emacs_global_deinit): ifdef out; not used.
5873 (Fgnutls_boot): Use const for pointer to readonly storage.
5874 Comment out unused local. Fix pointer signedness problems.
5875
640ee02d
PE
5876 * lread.c (openp): Don't stuff size_t into an 'int'.
5877 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5878 about possible signed overflow.
5879
6048fb2a
PE
5880 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5881 (GDK_KEY_g): Don't define if already defined.
5882 (xg_prepare_tooltip): Avoid pointer signedness problem.
5883 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5884
fa3c87e1
PE
5885 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5886 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5887
2172544b
PE
5888 * xfns.c (Fx_window_property): Simplify a bit,
5889 to make a bit faster and to avoid GCC 4.6.0 warning.
5890 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5891
9b821a21
PE
5892 * fns.c (internal_equal): Don't assume size_t fits in int.
5893
3c616cfa
PE
5894 * alloc.c (compact_small_strings): Tighten assertion a little.
5895
c2982e87
PE
5896 Replace pEd with more-general pI, and fix some printf arg casts.
5897 * lisp.h (pI): New macro, generalizing old pEd macro to other
5898 conversion specifiers. For example, use "...%"pI"d..." rather
5899 than "...%"pEd"...".
5900 (pEd): Remove. All uses replaced with similar uses of pI.
5901 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5902 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5903 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5904 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5905 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5906 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5907 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5908 64-bit hosts.
5909 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5910 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5911 * print.c (safe_debug_print, print_object): Likewise.
5912 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5913 to int.
6f04d126
PE
5914 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5915 avoiding the 0 flag, which is not portable.
c2982e87
PE
5916 * process.c (Fmake_network_process): Use pI to avoid cast.
5917 * region-cache.c (pp_cache): Likewise.
5918 * xdisp.c (decode_mode_spec): Likewise.
5919 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5920 behavior on 64-bit hosts with printf arg.
6f04d126 5921 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5922 (x_stop_queuing_selection_requests): Likewise.
5923 (x_get_window_property): Don't truncate byte count to an 'int'
5924 when tracing.
0b432f21 5925
5e073ec7
PE
5926 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5927 here, since it parses constructs like leading '-' and spaces,
5928 which are not wanted; and it overflows with large numbers.
5929 Instead, simply match F[0-9]+, which is what is wanted anyway.
5930
36372bf9
PE
5931 * alloc.c: Remove unportable assumptions about struct layout.
5932 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5933 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5934 (allocate_vectorlike, make_pure_vector): Use the new macros,
5935 plus offsetof, to remove unportable assumptions about struct layout.
5936 These assumptions hold on all porting targets that I know of, but
5937 they are not guaranteed, they're easy to remove, and removing them
5938 makes further changes easier.
5939
0b432f21
PE
5940 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5941 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5942 (string_overrun_cookie): Now const. Use initializers that
5943 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5944 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5945 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5946 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5947 multiple of sizeof (EMACS_INT); it need not be, if
5948 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5949 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5950
895009e1
JB
59512011-04-26 Juanma Barranquero <lekktu@gmail.com>
5952
5953 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5954
6a7a1b0b
TZ
59552011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5956
5957 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5958 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5959 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5960
841a1577 59612011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5962
5963 * lisp.h (Qdebug): List symbol.
895009e1 5964 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5965 * keyboard.c (debug-on-event): New variable.
5966 (handle_user_signal): Break into debugger when debug-on-event
5967 matches the current signal symbol.
5968
f2d3ba6f
DN
59692011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5970
5971 * alloc.c (check_sblock, check_string_bytes)
5972 (check_string_free_list): Convert to standard C.
5973
42ce4c63
TZ
59742011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5975
5976 * w32.c (emacs_gnutls_push): Fix typo.
5977
825cd63c
EZ
59782011-04-25 Eli Zaretskii <eliz@gnu.org>
5979
fb11d64d
EZ
5980 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5981 "cast to pointer from integer of different size".
5982
825cd63c
EZ
5983 Improve doprnt and its use in verror. (Bug#8545)
5984 * doprnt.c (doprnt): Document the set of format control sequences
5985 supported by the function. Use SAFE_ALLOCA instead of always
5986 using `alloca'.
5987
5988 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5989 is one byte too soon. Don't use xrealloc; instead xfree and
5990 xmalloc anew.
5991
e061a11b
TZ
59922011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5993
5994 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5995 callbacks stage.
5996
5997 * gnutls.c: Renamed global_initialized to
5998 gnutls_global_initialized. Added internals for the
5999 :verify-hostname-error, :verify-error, and :verify-flags
6000 parameters of `gnutls-boot' and documented those parameters in the
6001 docstring. Start callback support.
9173deec
JB
6002 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6003 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6004 on error. Return error code.
e061a11b
TZ
6005 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6006 (emacs_gnutls_read): Likewise.
6007 (Fgnutls_boot): Return handshake error code.
6008 (emacs_gnutls_handle_error): New function.
6009 (wsaerror_to_errno): Likewise.
6010
6011 * w32.h (emacs_gnutls_pull): Add prototype.
6012 (emacs_gnutls_push): Likewise.
6013
6014 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6015 (emacs_gnutls_push): Likewise.
6016
60172011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6018
6019 * process.c (wait_reading_process_output): Check if GnuTLS
6020 buffered some data internally if no FDs are set for TLS
6021 connections.
6022
6023 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6024 (LIBS): Link to USER_LIBS.
6025 ($(BLD)/gnutls.$(0)): New target.
6026
fa6996bc
EZ
60272011-04-24 Eli Zaretskii <eliz@gnu.org>
6028
eb35682e
EZ
6029 * xdisp.c (handle_single_display_spec): Rename the
6030 display_replaced_before_p argument into display_replaced_p, to
6031 make it consistent with the commentary. Fix typos in the
6032 commentary.
6033
e2ad650c
EZ
6034 * textprop.c (syms_of_textprop): Remove dead code.
6035 (copy_text_properties): Delete obsolete commentary about an
6036 interface that was deleted long ago. Fix typos in the description
6037 of arguments.
6038
1b2de274
EZ
6039 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6040 to changes in oldXMenu/XMenu.h from 2011-04-16.
6041 <menu_help_message, prev_menu_help_message>: Constify.
6042 (IT_menu_make_room): menu->help_text is now `const char **';
6043 adjust.
6044
6045 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6046 to changes in oldXMenu/XMenu.h from 2011-04-16.
6047 (struct XMenu): Declare `help_text' `const char **'.
6048
6049 * xfaces.c <Qunspecified>: Make extern again.
6050
6051 * syntax.c: Include sys/types.h before including regex.h, as
6052 required by Posix.
6053
762b15be
EZ
6054 * doc.c (get_doc_string): Improve the format passed to `error'.
6055
6056 * doprnt.c (doprnt): Improve commentary.
6057
6058 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6059
6060 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6061 them with etags.
6062
f1052e5d
EZ
6063 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6064 changes in globals.h immediately force recompilation.
762b15be
EZ
6065 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6066 $(CURDIR)/s/ms-w32.h.
6067 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6068
fa6996bc
EZ
6069 * character.c (Fchar_direction): Function deleted.
6070 (syms_of_character): Don't defsubr it.
6071 <char-direction-table>: Deleted.
6072
e6c3da20
EZ
60732011-04-23 Eli Zaretskii <eliz@gnu.org>
6074
6075 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6076 * doprnt.c: Include limits.h.
6077 (SIZE_MAX): New macro.
04f2d78b
CB
6078 (doprnt): Return a size_t value. 2nd arg is now size_t.
6079 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6080 Improve overflow protection. Support `l' modifier for integer
6081 conversions. Support %l conversion. Don't assume an EMACS_INT
6082 argument for integer conversions and for %c.
6083
6084 * lisp.h (doprnt): Restore prototype.
6085
6086 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6087 $(SRC)/character.h.
6088
6089 * Makefile.in (base_obj): Add back doprnt.o.
6090
6091 * deps.mk (doprnt.o): Add back prerequisites.
6092 (callint.o): Depend on character.h.
6093
6094 * eval.c (internal_lisp_condition_case): Include the handler
6095 representation in the error message.
6096 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6097 when breaking from the loop.
6098
6099 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6100
6101 * callint.c (Fcall_interactively): When displaying error message
6102 about invalid control letter, pass the character's codepoint, not
6103 a pointer to its multibyte form. Improve display of the character
6104 in octal and display also its hex code.
6105
6106 * character.c (char_string): Use %x to display the (unsigned)
6107 codepoint of an invalid character, to avoid displaying a bogus
6108 negative value.
6109
6110 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6111 `error', not SYMBOL_NAME itself.
6112
6113 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6114 character arguments to `error'.
6115
6116 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6117 to `error' in error message about FINAL_CHAR argument. Make sure
6118 FINAL_CHAR is a character, and use %c when it is passed as
6119 argument to `error'.
6120
4ffd0d6b 61212011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6122
6123 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6124
6125 * w32.c: Include <time.h>.
6126 (sys_localtime): New function.
6127
4ffd0d6b 61282011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6129
6130 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6131
4ffd0d6b 6132 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6133
4ffd0d6b 61342011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6135
4ffd0d6b
GM
6136 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6137 zombies (Bug#8467).
aac0c6e3 6138
04c56954
EZ
61392011-04-19 Eli Zaretskii <eliz@gnu.org>
6140
6141 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6142 gl_state.e_property when gl_state.object is Qt.
6143
6144 * insdel.c (make_gap_larger): Remove limitation of buffer size
6145 to <= INT_MAX.
6146
16a43933
CY
61472011-04-18 Chong Yidong <cyd@stupidchicken.com>
6148
6149 * xdisp.c (lookup_glyphless_char_display)
6150 (produce_glyphless_glyph): Handle cons cell entry in
6151 glyphless-char-display.
6152 (Vglyphless_char_display): Document it.
6153
6154 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6155 glyphless-char-display.
6156
4581706e
CY
61572011-04-17 Chong Yidong <cyd@stupidchicken.com>
6158
6159 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6160
6161 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6162
6163 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6164 definition for no-X builds.
6165
4887c6e2 61662011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6167
fd35b6f9
PE
6168 Static checks with GCC 4.6.0 and non-default toolkits.
6169
5c1ccb01
PE
6170 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6171
006c5daa
PE
6172 * process.c (keyboard_bit_set): Define only if SIGIO.
6173 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6174 (send_process): Repair possible setjmp clobbering.
6175
efc736d3
PE
6176 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6177
4e2fe2e6
PE
6178 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6179
f97334a2
PE
6180 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6181
4e75f29d
PE
6182 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6183 Define only if needed.
6184
90efadd1
PE
6185 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6186 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6187 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6188
3c647824
PE
6189 * dispextern.h (struct redisplay_interface): Rename param
6190 to avoid shadowing.
e264f262 6191 * termhooks.h (struct terminal): Likewise.
761383f4 6192 * xterm.c (xembed_send_message): Likewise.
3c647824 6193
b58c5c4a
PE
6194 * insdel.c (make_gap_smaller): Define only if
6195 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6196
cad59032
PE
6197 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6198 it.
6199
c339dc2e
PE
6200 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6201 so that we aren't warned about unused symbols.
6202
91a3e27b
PE
6203 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6204
399c71d3 6205 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6206
8ffc96f5
PE
6207 * xfns.c (x_real_positions): Mark locals as initialized.
6208
eef9bc79
PE
6209 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6210
098db9dd
PE
6211 * xterm.c: Fix problems found by static analysis with other toolkits.
6212 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6213 (x_dispatch_event): Declare static if USE_GTK, and
6214 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6215 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6216 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6217 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6218 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6219
eb18f6cc
PE
6220 * xmenu.c (menu_help_callback): Pointer type fixes.
6221 Use const pointers when pointing at readonly data. Avoid pointer
6222 signedness clashes.
6223 (FALSE): Remove unused macro.
6224 (update_frame_menubar): Remove unused decl.
6225
1fe72bf8
PE
6226 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6227
60d9e1db
PE
6228 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6229 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6230 (single_menu_item): Rename local to avoid shadowing.
6231
39261c26
PE
6232 * keyboard.c (make_lispy_event): Remove unused local var.
6233
018c5e19
PE
6234 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6235 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6236
63d2b86e
PE
6237 * bitmaps: Change bitmaps from unsigned char back to the X11
6238 compatible char. Avoid the old compiler warnings about
6239 out-of-range initializers by using, for example, '\xab' rather
6240 than 0xab.
6241
aefd87e1
PE
6242 * xgselect.c (xgselect_initialize): Check vs interface
6243 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6244
bf501fb9
PE
6245 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6246
e9829fdf
PE
6247 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6248 to read-only memory.
6249
1086c095
PE
6250 * fns.c (vector): Remove; this old hack is no longer needed.
6251
2baccd04 6252 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6253 Remove unused var.
dde42981 6254 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6255
72391843 6256 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6257
436c16df 6258 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6259 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6260 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6261
92bb796d 6262 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6263 (x_term_init): Remove local to avoid shadowing.
92bb796d 6264
764430a3 6265 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6266
6267 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6268 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6269
d1dfb56c
EZ
62702011-04-16 Eli Zaretskii <eliz@gnu.org>
6271
c4354cb4
EZ
6272 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6273
d1dfb56c
EZ
6274 Fix regex.c, syntax.c and friends for buffers > 2GB.
6275 * syntax.h (struct gl_state_s): Declare character position members
6276 EMACS_INT.
6277
6278 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6279
04f2d78b
CB
6280 * textprop.c (verify_interval_modification, interval_of):
6281 Declare arguments EMACS_INT.
d1dfb56c
EZ
6282
6283 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6284 EMACS_INT.
6285
6286 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6287
6288 * indent.c (Fvertical_motion): Local variable it_start is now
6289 EMACS_INT.
6290
6291 * regex.c (re_match, re_match_2, re_match_2_internal)
6292 (bcmp_translate, regcomp, regexec, print_double_string)
6293 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6294 (re_compile_pattern, re_exec): Declare arguments and local
6295 variables `size_t' and `ssize_t' and return values `regoff_t', as
6296 appropriate.
6297 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6298 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6299 <compile_stack_type>: `size' and `avail' are now `size_t'.
6300
6301 * regex.h <regoff_t>: Use ssize_t, not int.
6302 (re_search, re_search_2, re_match, re_match_2): Arguments that
6303 specify buffer/string position and length are now ssize_t and
6304 size_t. Return type is regoff_t.
6305
613052cd
BK
63062011-04-16 Ben Key <bkey76@gmail.com>
6307
6308 * nsfont.m: Fixed bugs in ns_get_family and
6309 ns_descriptor_to_entity that were caused by using free to
6310 deallocate memory blocks that were allocated by xmalloc (via
6311 xstrdup). This caused Emacs to crash when compiled with
6312 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6313 --enable-checking=xmallocoverrun). xfree is now used to
6314 deallocate these memory blocks.
6315
4170f62f 63162011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6317
71b41406
PE
6318 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6319
9587a89d
PE
6320 emacs_write: Accept and return EMACS_INT for sizes.
6321 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6322 et seq.
6323 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6324 Accept and return EMACS_INT.
6325 (emacs_gnutls_write): Return the number of bytes written on
6326 partial writes.
6327 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6328 (emacs_read, emacs_write): Remove check for negative size, as the
6329 Emacs source code has been audited now.
9587a89d
PE
6330 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6331 (emacs_read, emacs_write): Use it.
273a5f82
PE
6332 * process.c (send_process): Adjust to the new signatures of
6333 emacs_write and emacs_gnutls_write. Do not attempt to store
6334 a byte offset into an 'int'; it might overflow.
9587a89d 6335 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6336
3e047f51
PE
6337 * sound.c: Don't assume sizes fit in 'int'.
6338 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6339 Return EMACS_INT, not int.
3e047f51 6340 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6341 Accept EMACS_INT, not int.
6342 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6343 record read return values.
6344
cc39a9db
BK
63452011-04-15 Ben Key <bkey76@gmail.com>
6346
c9d0ec6d
JB
6347 * keyboard.c (Qundefined): Don't declare static since it is used
6348 in nsfns.m.
6349 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6350 static since they are used in nsfont.m.
cc39a9db 6351
6c60eb9f
SM
63522011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6353
6354 * process.c (Qprocessp): Don't declare static.
6355 * lisp.h (Qprocessp): Declare again.
6356
7990b61a
JB
63572011-04-15 Juanma Barranquero <lekktu@gmail.com>
6358
6359 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6360
5d4cb038
PE
63612011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6362
8bd7b830 6363 Improve C-level modularity by making more things 'static'.
cd64ea1d 6364
e3b27b31
PE
6365 Don't publish debugger-only interfaces to other modules.
6366 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6367 (verify_bytepos, count_markers): Move decls to the only modules
6368 that need them.
6369 * region-cache.h (pp_cache): Likewise.
6370 * window.h (check_all_windows): Likewise.
6371 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6372
5d4cb038
PE
6373 * sysdep.c (croak): Now static, if
6374 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6375 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6376
6377 * alloc.c (refill_memory_reserve): Now static if
6378 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6379 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6380
e87b6180
PE
6381 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6382 Define only if USE_LUCID.
6383
ac64929e
PE
6384 * xrdb.c (x_customization_string, x_rm_string): Now static.
6385
6f37259d
PE
6386 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6387 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6388
1683e3ab
PE
6389 * xdisp.c (draw_row_with_mouse_face): Now static.
6390 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6391
de9c2632
PE
6392 * window.h (check_all_windows): Mark externally visible.
6393
2b96acb7
PE
6394 * window.c (window_deletion_count): Now static.
6395
6396 * undo.c: Make symbols static if they're not exported.
6397 (last_undo_buffer, last_boundary_position, pending_boundary):
6398 Now static.
6399
50436f33
PE
6400 * textprop.c (interval_insert_behind_hooks): Now static.
6401 (interval_insert_in_front_hooks): Likewise.
6402
64520e5c
PE
6403 * term.c: Make symbols static if they're not exported.
6404 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6405 (max_frame_lines, tty_set_terminal_modes):
6406 (tty_reset_terminal_modes, tty_turn_off_highlight):
6407 (get_tty_terminal): Now static.
6408 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6409 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6410 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6411 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6412 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6413
1fa53021
PE
6414 * sysdep.c: Make symbols static if they're not exported.
6415 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6416 Now static.
6417 (sigprocmask_set, full_mask): Remove; unused.
6418 (wait_debugging): Mark as visible.
6419 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6420 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6421
d4b43b22
PE
6422 * syntax.c (syntax_temp): Define only if !__GNUC__.
6423
b7c513d0
PE
6424 * sound.c (current_sound_device, current_sound): Now static.
6425
989b29ad
PE
6426 * search.c (searchbufs, searchbuf_head): Now static.
6427
13a55a78
PE
6428 * scroll.c (scroll_cost): Remove; unused.
6429 * dispextern.h (scroll_cost): Remove decl.
6430
de68a1fc
PE
6431 * region-cache.h (pp_cache): Mark as externally visible.
6432
40ccffa6
PE
6433 * process.c: Make symbols static if they're not exported.
6434 (process_tick, update_tick, create_process, chan_process):
6435 (Vprocess_alist, proc_buffered_char, datagram_access):
6436 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6437 (deactivate_process): Mark defn as static, as well as decl.
6438 * lisp.h (create_process): Remove decl.
6439 * process.h (chan_process, Vprocess_alist): Remove decls.
6440
ad64fc97
PE
6441 * print.c: Make symbols static if they're not exported.
6442 (print_depth, new_backquote_output, being_printed, print_buffer):
6443 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6444 (print_interval, print_number_index, initial_stderr_stream):
6445 Now static.
6446 * lisp.h (Fprinc): Remove decl.
6447 (debug_output_compilation_hack): Mark as externally visible.
6448
adddb265
PE
6449 * sysdep.c (croak): Move decl from here to syssignal.h.
6450 * syssignal.h (croak): Put it here, so the API can be checked when
6451 'croak' is called from dissociate_if_controlling_tty.
6452
1717ede2
PE
6453 * minibuf.c: Make symbols static if they're not exported.
6454 (minibuf_save_list, choose_minibuf_frame): Now static.
6455 * lisp.h (choose_minibuf_frame): Remove decl.
6456
fa5fb2bc
PE
6457 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6458
1e3890d1
PE
6459 * lread.c: Make symbols static if they're not exported.
6460 (read_objects, initial_obarray, oblookup_last_bucket_number):
6461 Now static.
6462 (make_symbol): Remove; unused.
6463 * lisp.h (initial_obarray, make_symbol): Remove decls.
6464
8a1414fa
PE
6465 * keyboard.c: Make symbols static if they're not exported.
6466 (single_kboard, recent_keys_index, total_keys, recent_keys):
6467 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6468 (this_single_command_key_start, echoing, last_auto_save):
6469 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6470 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6471 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6472 (Vlispy_mouse_stem, double_click_count):
6473 Now static.
6474 (force_auto_save_soon): Define only if SIGDANGER.
6475 (ignore_mouse_drag_p): Now static if
6476 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6477 (print_help): Remove; unused.
6478 (stop_character, last_timer_event): Mark as externally visible.
6479 * keyboard.h (ignore_mouse_drag_p): Declare only if
6480 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6481 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6482 * lisp.h (echoing): Remove decl.
6483 (force_auto_save_soon): Declare only if SIGDANGER.
6484 * xdisp.c (redisplay_window): Simplify code, to make it more
6485 obvious that ignore_mouse_drag_p is not accessed if !defined
6486 USE_GTK && !defined HAVE_NS.
6487
93ea6e8f
PE
6488 * intervals.c: Make symbols static if they're not exported.
6489 (merge_properties_sticky, merge_interval_right, delete_interval):
6490 Now static.
6491 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6492
77382fcc
PE
6493 * insdel.c: Make symbols static if they're not exported.
6494 However, leave prepare_to_modify_buffer alone. It's never
6495 called from outside this function, but that appears to be a bug.
6496 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6497 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6498 (adjust_after_replace_noundo): Remove; unused.
6499 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6500 (signal_before_change): Remove decls.
77382fcc 6501
9306c32e
PE
6502 * indent.c (val_compute_motion, val_vmotion): Now static.
6503
cd44d2eb
PE
6504 * image.c: Make symbols static if they're not exported.
6505 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6506 if USE_GTK.
6507 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6508 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6509
ad9a7a06
PE
6510 * fringe.c (standard_bitmaps): Now static.
6511 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6512
81626931
PE
6513 * frame.c: Make symbols static if they're not exported.
6514 (x_report_frame_params, make_terminal_frame): Now static.
6515 (get_frame_param): Now static, unless HAVE_NS.
6516 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6517 (x_get_resource_string): Remove; not used.
6518 * frame.h (make_terminal_frame, x_report_frame_params):
6519 (x_get_resource_string); Remove decls.
6520 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6521 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6522
239f9db9
PE
6523 * font.c, fontset.c: Make symbols static if they're not exported.
6524 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6525 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6526 * font.c (font_close_object): Now static.
6527 * font.h (font_close_object): Remove.
6528 * fontset.c (FONTSET_OBJLIST): Remove.
6529 (free_realized_fontset) #if-0 the body, which does nothing.
6530 (face_suitable_for_char_p): #if-0, as it's never called.
6531 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6532 * xfaces.c (face_at_string_position):
6533 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6534 since 0 is always ASCII.
6535
dfcf3579
PE
6536 * fns.c (weak_hash_tables): Now static.
6537
5045092b
PE
6538 * fileio.c: Make symbols static if they're not exported.
6539 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6540 (Vwrite_region_annotation_buffers): Now static.
6541
57a96f5c
PE
6542 * eval.c: Make symbols static if they're not exported.
6543 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6544 * lisp.h (backtrace_list): Remove decl.
6545
35f08c38
PE
6546 * emacs.c: Make symbols static if they're not exported.
6547 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6548 (fatal_error_code, fatal_error_signal_hook, standard_args):
6549 Now static.
6550 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6551 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6552 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6553 * lisp.h (fatal_error_signal_hook): Remove decl.
6554 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6555
f44bd759
PE
6556 * editfns.c: Move a (normally-unused) function to its only use.
6557 * editfns.c, lisp.h (get_operating_system_release): Remove.
6558 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6559 worth the hassle of breaking this out.
6560
b532497d
PE
6561 * xterm.c: Make symbols static if they're not exported.
6562 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6563 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6564 (x_destroy_window, x_delete_display):
6565 Now static.
6566 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6567 (x_mouse_leave): Remove; unused.
6568 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6569 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6570 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6571 Remove decls.
6572 (x_mouse_leave): Declare only if WINDOWSNT.
6573 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6574 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6575 USE_X_TOOLKIT.
6576
1675728f
PE
6577 * ftxfont.c: Make symbols static if they're not exported.
6578 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6579 HAVE_FREETYPE.
6580 * font.h (ftxfont_driver): Likewise.
6581
e4cebfca
PE
6582 * xfns.c: Make symbols static if they're not exported.
6583 (x_last_font_name, x_display_info_for_name):
6584 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6585 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6586 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6587 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6588 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6589 (last_show_tip_args): Now static.
6590 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6591 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6592 (x_screen_planes): Remove; unused.
6593 * dispextern.h (x_screen_planes): Remove decl.
6594
5bf46f05
PE
6595 * dispnew.c: Make symbols static if they're not exported.
6596 * dispextern.h (redraw_garbaged_frames, scrolling):
6597 (increment_row_positions): Remove.
6598 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6599 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6600 Now static.
6601 (redraw_garbaged_frames): Remove; unused.
6602
435f4c28
PE
6603 * xfaces.c: Make symbols static if they're not exported.
6604 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6605 Remove decls.
6606 * xterm.h (defined_color): Remove decls.
6607 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6608 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6609 (menu_face_changed_default, defined_color, free_realized_face):
6610 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6611 (ascii_face_of_lisp_face): Remove; unused.
6612
8524aef3
PE
6613 * xdisp.c: Make symbols static if they're not exported.
6614 * dispextern.h (scratch_glyph_row, window_box_edges):
6615 (glyph_to_pixel_coords, set_cursor_from_row):
6616 (get_next_display_element, set_iterator_to_next):
6617 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6618 (show_mouse_face): Remove decls
6619 * frame.h (message_buf_print): Likewise.
6620 * lisp.h (pop_message, set_message, check_point_in_composition):
6621 Likewise.
6622 * xterm.h (set_vertical_scroll_bar): Likewise.
6623 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6624 (message_buf_print, scratch_glyph_row, displayed_buffer):
6625 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6626 (get_next_display_element, show_mouse_face, window_box_edges):
6627 (frame_to_window_pixel_xy, check_point_in_composition):
6628 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6629 (glyph_to_pixel_coords): Remove; unused.
6630
16390cd2
PE
6631 * dired.c (file_name_completion): Now static.
6632
6633 * dbusbind.c (xd_in_read_queued_messages): Now static.
6634
a25f4dfa
PE
6635 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6636 * data.c (circular_list_error): Remove.
6637
14a9c8df
PE
6638 * commands.h (last_point_position, last_point_position_buffer):
6639 (last_point_position_window): Remove decls.
6640 * keyboard.c: Make these variables static.
6641
04f2d78b
CB
6642 * coding.h (coding, code_convert_region, encode_coding_gap):
6643 Remove decls.
74ab6df5
PE
6644 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6645 (iso_code_class, detect_coding, code_convert_region): Now static.
6646 (encode_coding_gap): Remove; unused.
6647
38dfbee1
PE
6648 * chartab.c (chartab_chars, chartab_bits): Now static.
6649
a2cb4e63
PE
6650 * charset.h (charset_iso_8859_1): Remove decl.
6651 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6652 Now static.
6653
127198fd
PE
6654 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6655 * ccl.c (Vccl_program_table): Now static.
6656 (check_ccl_update): Remove; unused.
6657
d85b608f
PE
6658 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6659 * category.h: ... from here.
6660 * category.c (check_category_table, set_category_set): Now static.
6661
31cd66f3
PE
6662 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6663 * lisp.h: Remove these decls.
6664
c358e587
PE
6665 * buffer.c (buffer_count): Remove unused var.
6666
e78aecca
PE
6667 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6668 so that it's not optimized away.
6669 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6670 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6671 exported only to the debugger.
6672
e192d7d3 6673 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6674 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6675
92470028
PE
6676 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6677 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6678 was inaccessible from Lisp.
6679 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6680 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6681
244ed907
PE
6682 alloc.c: Import and export fewer symbols, and remove unused items.
6683 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6684 is defined.
6685 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6686 it's not optimized away by whole-program optimization.
6687 (message_enable_multibyte, free_misc): Remove.
6688 (catchlist, handlerlist, mark_backtrace):
6689 Declare only if BYTE_MARK_STACK.
6690 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6691 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6692 (message_enable_multibyte): Remove decl.
6693 (free_misc, interval_free_list, float_block, float_block_index):
6694 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6695 (cons_free_list, last_marked_index):
6696 Now static.
6697 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6698 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6699 (mark_backtrace): Define only if BYTE_MARK_STACK.
6700 * xdisp.c (message_enable_multibyte): Now static.
6701
61c2b50e 6702 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6703 This makes it easier for human readers (and static analyzers)
6704 to see whether these variables are used from other modules.
6705 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6706 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6707 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6708 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6709 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6710 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6711 * xmenu.c, xselect.c:
6712 Declare Q* vars static if they are not used in other modules.
6713 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6714 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6715 Remove decls of unexported vars.
6716 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6717
95c82688
PE
6718 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6719
16a97296
PE
6720 Make Emacs functions such as Fatom 'static' by default.
6721 This makes it easier for human readers (and static analyzers)
6722 to see whether these functions can be called from other modules.
6723 DEFUN now defines a static function. To make the function external
6724 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6725 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6726 (Finit_image_library):
16a97296
PE
6727 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6728 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6729 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6730 Remove decls, since these functions are now static.
6731 (Funintern, Fget_internal_run_time): New decls, since these functions
6732 were already external.
95c82688 6733
16a97296
PE
6734 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6735 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6736 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6737 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6738 * keyboard.c, keymap.c, lread.c:
6739 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6740 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6741 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6742 Mark functions with DEFUE instead of DEFUN,
6743 if they are used in other modules.
6744 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6745 decls for now-static functions.
6746 * buffer.h (Fdelete_overlay): Remove decl.
6747 * callproc.c (Fgetenv_internal): Mark as internal.
6748 * composite.c (Fremove_list_of_text_properties): Remove decl.
6749 (Fcomposition_get_gstring): New forward static decl.
6750 * composite.h (Fcomposite_get_gstring): Remove decl.
6751 * dired.c (Ffile_attributes): New forward static decl.
6752 * doc.c (Fdocumntation_property): New forward static decl.
6753 * eval.c (Ffetch_bytecode): New forward static decl.
6754 (Funintern): Remove extern decl; now in .h file where it belongs.
6755 * fileio.c (Fmake_symbolic_link): New forward static decl.
6756 * image.c (Finit_image_library): New forward static decl.
6757 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6758 * intervals.h (Fprevious_property_change):
6759 (Fremove_list_of_text_properties): Remove decls.
6760 * keyboard.c (Fthis_command_keys): Remove decl.
6761 (Fcommand_execute): New forward static decl.
6762 * keymap.c (Flookup_key): New forward static decl.
6763 (Fcopy_keymap): Now static.
6764 * keymap.h (Flookup_key): Remove decl.
6765 * process.c (Fget_process): New forward static decl.
6766 (Fprocess_datagram_address): Mark as internal.
6767 * syntax.c (Fsyntax_table_p): New forward static decl.
6768 (skip_chars): Remove duplicate decl.
6769 * textprop.c (Fprevious_property_change): New forward static decl.
6770 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6771 Now internal.
6772 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6773 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6774
785bbd42
PE
6775 * editfns.c (Fformat): Remove unreachable code.
6776
8b913b57
AS
67772011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6778
6779 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6780 change. (Bug#8496)
6781
a6744a35
EZ
67822011-04-13 Eli Zaretskii <eliz@gnu.org>
6783
6784 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6785 when at ZV. (Bug#8487)
6786
e7974947
AS
67872011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6788
baad03f0
AS
6789 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6790 (Bug#8437)
6791 * keyboard.c (parse_tool_bar_item): Likewise.
6792 * sound.c (sound_cleanup, alsa_close): Likewise.
6793 * termcap.c (tgetent): Likewise.
6794 * xfns.c (x_default_font_parameter): Likewise.
6795 * xsettings.c (read_and_apply_settings): Likewise.
6796
e7974947
AS
6797 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6798 (overrun_check_free): Protoize.
6799
28272684
PE
68002011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6801
6802 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6803 since callers should never pass a negative size.
6804 Change the signature to match that of plain 'read' and 'write'; see
6805 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6806 * lisp.h: Update prototypes of emacs_write and emacs_read.
6807
11997c76
EZ
68082011-04-11 Eli Zaretskii <eliz@gnu.org>
6809
6810 * xdisp.c (redisplay_window): Don't try to determine the character
6811 position of the scroll margin if the window start point w->startp
e896f03c 6812 is outside the buffer's accessible region. (Bug#8468)
11997c76 6813
8a2cbd72
EZ
68142011-04-10 Eli Zaretskii <eliz@gnu.org>
6815
6816 Fix write-region and its subroutines for buffers > 2GB.
6817 * fileio.c (a_write, e_write): Modify declaration of arguments and
6818 local variables to support buffers larger than 2GB.
6819 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6820
6821 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6822 argument, local variables, and return value.
6823
6824 * lisp.h: Update prototypes of emacs_write and emacs_read.
6825
6826 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6827
4073e537 68282011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6829
1ebfdcb6
PE
6830 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6831
b2ded58d
PE
6832 Fix more problems found by GCC 4.6.0's static checks.
6833
7d66342c
PE
6834 * xdisp.c (vmessage): Use a better test for character truncation.
6835
bbf47d44
PE
6836 * charset.c (load_charset_map): <, not <=, for optimization,
6837 and to avoid potential problems with integer overflow.
9248994d 6838 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6839 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6840 * editfns.c (Fformat): Likewise.
1e69125e 6841 * syntax.c (skip_chars): Likewise.
3befa583 6842
e3019616
PE
6843 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6844 This also lets GCC 4.6.0 generate slightly better loop code.
6845
becfa255
PE
6846 * callint.c (Fcall_interactively): <, not <=, for optimization.
6847 (Fcall_interactively): Count the number of arguments produced,
6848 not the number of arguments given. This is simpler and lets GCC
6849 4.6.0 generate slightly better code.
6850
dae0cd48
PE
6851 * ftfont.c: Distingish more carefully between FcChar8 and char.
6852 The previous code passed unsigned char * to a functions like
6853 strlen and xstrcasecmp that expect char *, which does not
6854 conform to the C standard.
6855 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6856 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6857 char * when the C standard requires it.
6858
76032d70
PE
6859 * keyboard.c (read_char): Remove unused var.
6860
eb3f1cc8
PE
6861 * eval.c: Port to Windows vsnprintf (Bug#8435).
6862 Include <limits.h>.
6863 (SIZE_MAX): Define if the headers do not.
6864 (verror): Do not give up if vsnprintf returns a negative count.
6865 Instead, grow the buffer. This ports to Windows vsnprintf, which
6866 does not conform to C99. Problem reported by Eli Zaretskii.
6867 Also, simplify the allocation scheme, by avoiding the need for
6868 calling realloc, and removing the ALLOCATED variable.
6869
70476b54
PE
6870 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6871
12020a9e
PE
6872 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6873 But keep the doprint source code for now, as we might revamp it
6874 and use it again (Bug#8435).
ea6c7ae6
PE
6875 * lisp.h (doprnt): Remove.
6876 * Makefile.in (base_obj): Remove doprnt.o.
6877 * deps.mk (doprnt.o): Remove.
6878
5fdb398c
PE
6879 error: Print 32- and 64-bit integers portably (Bug#8435).
6880 Without this change, on typical 64-bit hosts error ("...%d...", N)
6881 was used to print both 32- and 64-bit integers N, which relied on
6882 undefined behavior.
6883 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6884 New macro.
6885 * lisp.h (error, verror): Mark as printf-like functions.
6886 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6887 Report overflow in size calculations when allocating printf buffer.
6888 Do not truncate output string at its first null byte.
6889 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6890 Truncate the output at a character boundary, since vsnprintf does not
6891 do that.
6892 * charset.c (check_iso_charset_parameter): Convert internal
6893 character to string before calling 'error', since %c now has the
6894 printf meaning.
6895 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6896 overflow when computing char to be passed to 'error'. Do not
6897 pass Lisp_Object to 'error'; pass the integer instead.
6898 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6899 formatted with plain %d.
6900
b189fa66
PE
6901 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6902
bff87ef0
PE
6903 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6904
7e2cac20
PE
6905 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6906
ce4d90b5
PE
6907 * xterm.c (x_catch_errors): Remove duplicate declaration.
6908
266c9547
PE
6909 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6910
79c49ad2
PE
6911 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6912
368f4090
JM
69132011-04-10 Jim Meyering <meyering@redhat.com>
6914
6915 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6916 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6917 return ssize_t not "int", and use size_t as the buffer length.
6918 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6919 * gnutls.h: Update declarations.
6920 * process.c (read_process_output): Use ssize_t, to match.
6921 (send_process): Likewise.
6922
a32d4040
CY
69232011-04-09 Chong Yidong <cyd@stupidchicken.com>
6924
6925 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6926
8546720e 69272011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6928
04f2d78b
CB
6929 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6930 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6931
8546720e
GM
6932 * xterm.c (handle_one_xevent):
6933 * xmenu.c (create_and_show_popup_menu):
6934 * xselect.c (x_decline_selection_request)
6935 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6936
0a2f5c1a 69372011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6938
6939 Fix some uses of `int' instead of EMACS_INT.
6940 * search.c (string_match_1, fast_string_match)
6941 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6942 (scan_buffer, find_next_newline_no_quit)
6943 (find_before_next_newline, search_command, Freplace_match)
6944 (Fmatch_data): Make some `int' variables be EMACS_INT.
6945
6946 * xdisp.c (display_count_lines): 3rd argument and return value now
6947 EMACS_INT. All callers changed.
6948 (pint2hrstr): Last argument is now EMACS_INT.
6949
6950 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6951 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6952 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6953 (decode_coding_utf_16, decode_coding_emacs_mule)
6954 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6955 (decode_coding_ccl, decode_coding_charset)
6956 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6957 (decode_coding_iso_2022, decode_coding_emacs_mule)
6958 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6959 <char_offset, last_offset>: Declare EMACS_INT.
6960 (encode_coding_utf_8, encode_coding_utf_16)
6961 (encode_coding_emacs_mule, encode_invocation_designation)
6962 (encode_designation_at_bol, encode_coding_iso_2022)
6963 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6964 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6965 Declare EMACS_INT.
6966 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6967 (encode_invocation_designation): Last argument P_NCHARS is now
6968 EMACS_INT.
6969 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6970 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6971
6972 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6973 All users changed.
6974
6975 * ccl.c (Fccl_execute_on_string): Declare some variables
6976 EMACS_INT.
6977
8546720e 69782011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6979
6980 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6981
4e19a977
CS
69822011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6983
6984 * process.c (Fformat_network_address): Doc fix.
6985
87302331
R
69862011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6987
6988 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6989
cbb59342
CY
69902011-04-08 Chong Yidong <cyd@stupidchicken.com>
6991
6992 * keyboard.c (read_char): Call Lisp function help-form-show,
6993 instead of using internal_with_output_to_temp_buffer.
6994 (Qhelp_form_show): New var.
e0d38eeb 6995 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6996
6997 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6998
6999 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7000
e67a13ab
CY
70012011-04-06 Chong Yidong <cyd@stupidchicken.com>
7002
04f2d78b
CB
7003 * process.c (Flist_processes): Remove to Lisp.
7004 (list_processes_1): Delete.
e67a13ab 7005
973f782d
EZ
70062011-04-06 Eli Zaretskii <eliz@gnu.org>
7007
7c106b1e
EZ
7008 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7009
973f782d
EZ
7010 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7011
41cf7d1a 70122011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7013
ca23cc88
PE
7014 Fix more problems found by GCC 4.6.0's static checks.
7015
f390e2d5
PE
7016 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7017
42eea0d0
PE
7018 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7019
b69769da 7020 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7021
f9541e84
PE
7022 * xdisp.c (vmessage): Mark as a printf-like function.
7023
13841b55
PE
7024 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7025
c136c10f
PE
7026 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7027
5e2d4a30
PE
7028 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7029 printf-like functions.
7030 (tiff_load): Add casts to remove these marks before passing them
7031 to system-supplied API.
7032
583f48b9
PE
7033 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7034
b25d760e
PE
7035 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7036 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7037 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7038 directly, rather than having caller test rule sign. This avoids
7039 some unnecessary tests.
7040 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7041 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7042 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7043
bc7b6697 7044 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7045 (xfont_open): Avoid unnecessary tests.
bc7b6697 7046
27ccc379
PE
7047 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7048
dcd5c89a
PE
7049 * composite.h, composite.c (composition_gstring_put_cache):
7050 Use EMACS_INT, not int, for length.
7051
b13a45c6
PE
7052 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7053 breaking out part of COMPOSITION_DECODE_RULE.
7054 (COMPOSITION_DECODE_RULE): Use it.
7055 * composite.c (get_composition_id): Remove unused local vars,
7056 by using the new macro.
7057
1e792e4d
PE
7058 * textprop.c (set_text_properties_1): Change while to do-while,
7059 since the condition is always true at first.
7060
dc6c6455 7061 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7062 (interval_deletion_adjustment): Return unsigned value.
7063 All uses changed.
dc6c6455 7064
aba7731a
PE
7065 * process.c (list_processes_1, create_pty, read_process_output):
7066 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7067 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7068 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7069 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7070 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7071
fdfc4bf3
PE
7072 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7073
fca8fe46 7074 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7075 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7076
06a0259a 7077 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7078 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7079 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7080
e7b9e80f
PE
7081 * print.c (print_error_message): Avoid int overflow.
7082
56201685
PE
7083 * font.c (font_list_entities): Redo for clarity,
7084 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7085
78834453 7086 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7087 (font_score): Avoid potential overflow in diff calculation.
78834453 7088
0bc0b309 7089 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7090 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7091
e610eaca
PE
7092 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7093
b895abce
PE
7094 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7095 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7096 can always succeed if overflow has undefined behavior.
7097
1f1d9321 7098 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7099 (wordify): Omit three unnecessary tests.
1f1d9321 7100
c59478bc
PE
7101 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7102 All callers changed. This avoids the need for an unused var.
7103
79b73827
PE
7104 * casefiddle.c (casify_region): Remove var that is set but not used.
7105
a4db5dfe
PE
7106 * dired.c (file_name_completion): Remove var that is set but not used.
7107
43aae36e
PE
7108 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7109
2a47c44d 7110 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7111 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7112
a37c69bf
PE
7113 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7114 Check for integer overflow on size calculations.
7115
328ab8e7
PE
7116 * buffer.c (Fprevious_overlay_change): Remove var that is set
7117 but not used.
7118
e5a2a5cb
PE
7119 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7120 Remove vars that are set but not used.
8d84a6eb 7121 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7122 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7123
a60e5f68
PE
7124 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7125
f661cb61 7126 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7127 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7128
f0397f5a
PE
7129 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7130 that are set but not used.
7131
8664db06 7132 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7133 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7134
6abdaa4a
PE
7135 * xselect.c (x_get_local_selection, x_handle_property_notify):
7136 Remove vars that are set but not used.
7137
0ce7538d 7138 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7139 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7140
9ae848fc
PE
7141 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7142 Remove var that is set but not used.
0b918413
PE
7143 (scroll_bar_windows_size): Now size_t, not int.
7144 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7145 Check for overflow.
9ae848fc 7146
a5a62657
PE
7147 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7148 (map_tty_color) [!defined MSDOS]: Likewise.
7149
5c5cdd39
PE
7150 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7151
66ebf983
PE
7152 * coding.c: Remove vars that are set but not used.
7153 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7154 All callers changed.
7155 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7156 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7157 (decode_coding_charset): Remove vars that are set but not used.
7158
1be4d761
PE
7159 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7160 that is set but not used.
7161
47553fa8
PE
7162 * print.c (print_object): Remove var that is set but not used.
7163
1f7196bf 7164 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7165 The gnulib version avoids calling malloc in the usual case,
7166 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7167 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7168 * filelock.c (current_lock_owner): Likewise.
7169 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7170 * sysdep.c: Include allocator.h, careadlinkat.h.
7171 (emacs_no_realloc_allocator): New static constant.
7172 (emacs_readlink): New function.
fdb61804
PE
7173 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7174 ../lib/careadlinkat.h.
d1fdcab7 7175
f84c17c7
SM
71762011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7177
7178 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7179 first non-nil return value).
7180
ef3862ad
JD
71812011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7182
7183 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7184 if not defined (Bug#8403).
7185
376a7006
JB
71862011-04-02 Juanma Barranquero <lekktu@gmail.com>
7187
7188 * xdisp.c (display_count_lines): Remove parameter `start',
7189 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7190 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7191 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7192 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7193 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7194 and thereabouts. All callers changed.
7195 (get_per_char_metric): Remove parameter `f', unused since
7196 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7197
6ca3801d
JM
71982011-04-02 Jim Meyering <meyering@redhat.com>
7199
7200 do not dereference NULL upon failed strdup
7201 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7202 (ns_get_family): Likewise.
7203
d8e2b5ba
JB
72042011-04-02 Juanma Barranquero <lekktu@gmail.com>
7205
7206 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7207
8c74fcbd
JD
72082011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7209
7210 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7211 later (Bug#8403).
7212
7200d79c
SM
72132011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7214
03408648 7215 Add lexical binding.
7200d79c 7216
03408648
SM
7217 * window.c (Ftemp_output_buffer_show): New fun.
7218 (Fsave_window_excursion):
7219 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7220
7221 * lread.c (lisp_file_lexically_bound_p): New function.
7222 (Fload): Bind Qlexical_binding.
7223 (readevalloop): Remove `evalfun' arg.
7224 Bind Qinternal_interpreter_environment.
7225 (Feval_buffer): Bind Qlexical_binding.
7226 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7227 Mark as dynamic.
7228 (syms_of_lread): Declare `lexical-binding'.
7229
7230 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7231
7232 * keyboard.c (eval_dyn): New fun.
7233 (menu_item_eval_property): Use it.
ca105506
SM
7234
7235 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7236
03408648
SM
7237 * fns.c (concat, mapcar1): Accept byte-code-functions.
7238
7239 * eval.c (Fsetq): Handle lexical vars.
7240 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7241 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7242 (FletX, Flet): Obey lexical binding.
7243 (Fcommandp): Handle closures.
7244 (Feval): New `lexical' arg.
7245 (eval_sub): New function extracted from Feval. Use it almost
7246 everywhere where Feval was used. Look up vars in lexical env.
7247 Handle closures.
7248 (Ffunctionp): Move from subr.el.
7249 (Ffuncall): Handle closures.
7250 (apply_lambda): Remove `eval_flags'.
7251 (funcall_lambda): Handle closures and new byte-code-functions.
7252 (Fspecial_variable_p): New function.
7253 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7254 but without exporting it to Lisp.
23aba0ea 7255
23aba0ea 7256 * doc.c (Fdocumentation, store_function_docstring):
03408648 7257 * data.c (Finteractive_form): Handle closures.
23aba0ea 7258
03408648
SM
7259 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7260 interactive spec.
ba83908c 7261
04f2d78b
CB
7262 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7263 New byte-codes.
03408648
SM
7264 (exec_byte_code): New function extracted from Fbyte_code to handle new
7265 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7266
03408648 7267 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7268
03408648 7269 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7270
e2abce01
JB
72712011-03-31 Juanma Barranquero <lekktu@gmail.com>
7272
7273 * xdisp.c (redisplay_internal): Fix prototype.
7274
63696a73 72752011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7276
63696a73 7277 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7278 (try_scrolling): Use it when setting scroll_limit.
7279 Limit scrolling to 100 screen lines.
63696a73
EZ
7280 (redisplay_window): Even when falling back on "recentering",
7281 position point in the window according to scroll-conservatively,
7282 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7283
7284 (try_scrolling): When point is above the window, allow searching
7285 as far as scroll_max, or one screenful, to compute vertical
7286 distance from PT to the scroll margin position. This prevents
7287 try_scrolling from unnecessarily failing when
7288 scroll-conservatively is set to a value slightly larger than the
7289 window height. Clean up the case of PT below the margin at bottom
7290 of window: scroll_max can no longer be INT_MAX. When aggressive
7291 scrolling is in use, don't let point enter the opposite scroll
7292 margin as result of the scroll.
7293 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7294 threshold of 100 lines for never-recentering scrolling.
7295
e4cc2dfc
JB
72962011-03-31 Juanma Barranquero <lekktu@gmail.com>
7297
7298 * dispextern.h (move_it_by_lines):
7299 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7300 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7301 (message_log_check_duplicate): Remove parameters `prev_bol' and
7302 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7303 (redisplay_internal): Remove parameter `preserve_echo_area',
7304 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7305
7306 * indent.c (Fvertical_motion):
7307 * window.c (window_scroll_pixel_based, Frecenter):
7308 Don't pass `need_y_p' to `move_it_by_lines'.
7309
1c470562
SM
73102011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7311
44f230aa
SM
7312 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7313 steal a few bits to be more compact.
7314 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7315 Remove unneeded casts.
7316
1c470562
SM
7317 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7318
888adce9
ZK
73192011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7320
7321 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7322 binding" message (bug#7967).
7323
f838ed7b
PE
73242011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7325
77861b95
PE
7326 Fix more problems found by GCC 4.6.0's static checks.
7327
de6dbc14
PE
7328 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7329 Remove unused local var.
7330
f838ed7b
PE
7331 * editfns.c (Fmessage_box): Remove unused local var.
7332
792c7b2b
PE
7333 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7334 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7335 Omit unused local vars.
c499e557 7336 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7337 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7338 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7339 Omit unused local var.
7340
ba0165e1
PE
7341 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7342 Don't assume string length fits in int.
32ad8845 7343 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7344 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7345
3c59b4c9
PE
7346 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7347 instead of alloca (Bug#8344).
7348
a3eed478 7349 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7350 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7351
eb4d412d
PE
7352 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7353
1658b401
PE
7354 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7355 concerns.
7356
7357 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7358
7359 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7360
9a2c6e05
PE
7361 * keyboard.c (syms_of_keyboard): Use the same style as later
7362 in this function when indexing through an array. This also
7363 works around GCC bug 48267.
7364
03d0a109
PE
7365 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7366
44f730c8
PE
7367 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7368
fe75f926
PE
7369 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7370 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7371
ffa8c828
PE
7372 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7373 This avoids undefined behavior on integer overflow, and is a bit
7374 more convenient anyway since it is compared to a size_t variable.
7375
c5101a77
PE
7376 Variadic C functions now count arguments with size_t, not int.
7377 This avoids an unnecessary limitation on 64-bit machines, which
7378 caused (substring ...) to crash on large vectors (Bug#8344).
7379 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7380 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7381 All variadic functions and their callers changed accordingly.
c5101a77
PE
7382 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7383 * data.c (arith_driver, float_arith_driver): Likewise.
7384 * editfns.c (general_insert_function): Likewise.
7385 * eval.c (struct backtrace.nargs, interactive_p)
7386 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7387 (funcall_lambda, mark_backtrace): Likewise.
7388 * fns.c (concat): Likewise.
7389 * frame.c (x_set_frame_parameters): Likewise.
7390 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7391 0 if not found, not -1. All callers changed.
7392
dd3f25f7
PE
7393 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7394 (stack_copy_size): Now size_t, not int.
7395 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7396
461c2ab9
JB
73972011-03-28 Juanma Barranquero <lekktu@gmail.com>
7398
7399 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7400 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7401 All callers changed.
7402
7403 * lisp.h (multibyte_char_to_unibyte):
7404 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7405 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7406 * character.h (CHAR_TO_BYTE8):
7407 * cmds.c (internal_self_insert):
7408 * editfns.c (general_insert_function):
7409 * keymap.c (push_key_description):
7410 * search.c (Freplace_match):
7411 * xdisp.c (message_dolog, set_message_1): All callers changed.
7412
f6d62986
SM
74132011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7414
7415 * keyboard.c (safe_run_hook_funcall): New function.
7416 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7417 don't set the hook to nil, but remove the offending function instead.
7418 (Qcommand_hook_internal): Remove, unused.
7419 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7420 Vcommand_hook_internal.
7421
7422 * eval.c (enum run_hooks_condition): Remove.
7423 (funcall_nil, funcall_not): New functions.
7424 (run_hook_with_args): Call each function through a `funcall' argument.
7425 Remove `cond' argument, now redundant.
7426 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7427 (Frun_hook_with_args_until_failure): Adjust accordingly.
7428 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7429
1db5b1ad
JB
74302011-03-28 Juanma Barranquero <lekktu@gmail.com>
7431
7432 * dispextern.h (string_buffer_position): Remove declaration.
7433
7434 * print.c (strout): Remove parameter `multibyte', unused since
7435 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7436
7437 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7438 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7439 All callers changed.
7440
7441 * w32.c (_wsa_errlist): Use braces for struct initializers.
7442
7443 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7444 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7445 All callers changed.
7446 (string_buffer_position): Likewise. Also, make static (it's never
7447 used outside xdisp.c).
7448 (cursor_row_p): Remove parameter `w', unused since
7449 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7450 (decode_mode_spec): Remove parameter `precision', introduced during
7451 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7452 All callers changed.
7453
5ffb62aa
JD
74542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7455
7456 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7457
461c2ab9 74582011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7459
7460 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7461 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7462 (ns_update_auto_hide_menu_bar): New functions.
7463 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7464 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7465 ns_constrain_all_frames.
7466 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7467 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7468
5c380ffb
JD
74692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7470
7471 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7472
9af30bdf
GM
74732011-03-27 Glenn Morris <rgm@gnu.org>
7474
7475 * syssignal.h: Replace RETSIGTYPE with void.
7476 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7477 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7478 Replace SIGTYPE with void everywhere.
7479 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7480 * s/template.h (SIGTYPE): Remove commented out definition.
7481
e2abce01
JB
74822011-03-26 Eli Zaretskii <eliz@gnu.org>
7483
7484 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7485 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7486
f868cd8a
JB
74872011-03-26 Juanma Barranquero <lekktu@gmail.com>
7488
59eb0929
JB
7489 * w32.c (read_unc_volume): Use parameter `henum', instead of
7490 global variable `wget_enum_handle'.
7491
7492 * keymap.c (describe_vector): Remove parameters `indices' and
7493 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7494 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7495
f868cd8a
JB
7496 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7497
7498 * keyboard.c (timer_check): Remove parameter `do_it_now',
7499 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7500 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7501 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7502
7503 * keyboard.c (read_char):
7504 * w32menu.c (w32_menu_display_help):
7505 * xmenu.c (show_help_event, menu_help_callback):
7506 Adjust calls to `show_help_echo'.
7507
7508 * gtkutil.c (xg_maybe_add_timer):
7509 * keyboard.c (readable_events):
7510 * process.c (wait_reading_process_output):
7511 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7512
7513 * insdel.c (adjust_markers_gap_motion):
7514 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7515 (gap_left, gap_right): Don't call it.
7516
2ecf6fdb
CY
75172011-03-25 Chong Yidong <cyd@stupidchicken.com>
7518
7519 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7520 incurred during fontification.
7521
6b1f9ba4
JB
75222011-03-25 Juanma Barranquero <lekktu@gmail.com>
7523
7524 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7525 (DEFVAR_PER_BUFFER): Don't pass it.
7526
7527 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7528 (scrolling_window): Don't pass it.
7529
0f4a96b5
JB
75302011-03-25 Juanma Barranquero <lekktu@gmail.com>
7531
7532 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7533
7534 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7535 and `suffix'.
7536 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7537 of variables specific to SELinux and computation of `encoded_absname'.
7538
7539 * image.c (XPutPixel): Remove unused variable `height'.
7540
7541 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7542
7543 * unexw32.c (get_section_info): Remove unused variable `section'.
7544
7545 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7546 (system_process_attributes): Remove unused variable `sess'.
7547 (sys_read): Remove unused variable `err'.
7548
7549 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7550 (w32_wnd_proc): Remove unused variable `isdead'.
7551 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7552 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7553 (x_create_tip_frame): Remove unused variable `tem'.
7554
7555 * w32inevt.c (w32_console_read_socket):
7556 Remove unused variable `no_events'.
7557
7558 * w32term.c (x_draw_composite_glyph_string_foreground):
7559 Remove unused variable `width'.
7560
1149507c
JB
75612011-03-24 Juanma Barranquero <lekktu@gmail.com>
7562
7563 * w32term.c (x_set_glyph_string_clipping):
7564 Don't pass uninitialized region to CombineRgn.
7565
9c88f339
JB
75662011-03-23 Juanma Barranquero <lekktu@gmail.com>
7567
7568 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7569 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7570 (Fx_close_connection): Remove unused variable `i'.
7571
7572 * w32font.c (w32font_draw): Return number of glyphs.
7573 (w32font_open_internal): Remove unused variable `i'.
7574 (w32font_driver): Add missing initializer.
7575
7576 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7577 (fill_in_menu): Remove unused variable `items_added'.
7578
7579 * w32term.c (last_mouse_press_frame): Remove static global variable.
7580 (w32_clip_to_row): Remove unused variable `f'.
7581 (x_delete_terminal): Remove unused variable `i'.
7582
7583 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7584 (NOTHING): Remove unused static global variable.
7585 (uniscribe_check_otf): Remove unused variable `table'.
7586 (uniscribe_font_driver): Add missing initializers.
7587
dee091a3
JD
75882011-03-23 Julien Danjou <julien@danjou.info>
7589
7590 * term.c (Fsuspend_tty, Fresume_tty):
7591 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7592 * window.c (temp_output_buffer_show):
7593 * insdel.c (signal_before_change):
7594 * frame.c (Fhandle_switch_frame):
7595 * fileio.c (Fdo_auto_save):
7596 * emacs.c (Fkill_emacs):
7597 * editfns.c (save_excursion_restore):
7598 * cmds.c (internal_self_insert):
7599 * callint.c (Fcall_interactively):
7600 * buffer.c (Fkill_all_local_variables):
7601 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7602 Use Frun_hooks.
0f4a96b5 7603 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7604 unconditionnaly since it does the check itself.
7605
2c520ab5 76062011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7607
c9c49752
PE
7608 Fix more problems found by GCC 4.5.2's static checks.
7609
8abc3f12
PE
7610 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7611 the first time through the loop, since we know p0 < p1 then.
7612 This also avoids a gcc -Wstrict-overflow warning.
7613
a2d26660
PE
7614 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7615 leading to a memory leak, possible in functions like
7616 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7617 of objects (Bug#8318).
a2d26660 7618
916c72e9
PE
7619 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7620 that could (at least in theory) be that large.
7621
19ab8a18
PE
7622 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7623 This is less likely to overflow, and avoids undefined behavior if
7624 overflow does occur. All callers changed. Use strtoul to scan
7625 for the unsigned long integer.
b7cbbd6f
PE
7626 (pint2hrstr): Simplify and tune code slightly.
7627 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7628
f0641eff
PE
7629 * scroll.c (do_scrolling): Work around GCC bug 48228.
7630 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7631
7f650bb9
PE
7632 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7633 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7634 (validate_x_resource_name): Simplify count usage.
7635 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7636
37dd57d1
PE
7637 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7638 fail (Bug#8306).
81e56e61 7639
699979fc 7640 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7641
401bf9b4
PE
7642 * process.c (Fmake_network_process): Use socklen_t, not int,
7643 where POSIX says socklen_t is required in portable programs.
7644 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7645 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7646 (Fmake_network_process, server_accept_connection):
7647 (wait_reading_process_output, read_process_output):
7648 Likewise.
7649
b93aacde
PE
7650 * process.c: Rename or move locals to avoid shadowing.
7651 (list_processes_1, Fmake_network_process):
7652 (read_process_output_error_handler, exec_sentinel_error_handler):
7653 Rename or move locals.
4dc343ee 7654 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7655 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7656 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7657 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7658 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7659
af8a867c 7660 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7661 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7662 Include tparam.h instead, since it declares them.
af8a867c
PE
7663 * cm.h (PC): Remove extern decl; tparam.h now does this.
7664 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7665 * terminfo.c: Include tparam.h, to check interfaces.
7666 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7667 (tparam): Adjust signature to match interface in tparam.h;
7668 this removes some undefined behavior. Check that outstring and len
7669 are zero, which they always are with Emacs.
7670 * tparam.h (PC, BC, UP): New extern decls.
7671
0248044d 7672 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7673 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7674
8ff096c1 7675 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7676 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7677 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7678 (ftfont_list): Remove unused local.
49eaafba
PE
7679 (get_adstyle_property, ftfont_pattern_entity):
7680 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7681 Rename locals to avoid shadowing.
8ff096c1 7682
e2be39f6
PE
7683 * xfont.c (xfont_list_family): Mark var as initialized.
7684
c9735e30
PE
7685 * xml.c (make_dom): Now static.
7686
8f5201ae
PE
7687 * composite.c (composition_compute_stop_pos): Rename local to
7688 avoid shadowing.
b246f932
PE
7689 (composition_reseat_it): Remove unused locals.
7690 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7691 (composition_update_it): Mark var as initialized.
11b61122
PE
7692 (find_automatic_composition): Mark vars as initialized,
7693 with a FIXME (Bug#8290).
8f5201ae 7694
760fbc2c
PE
7695 character.h: Rename locals to avoid shadowing.
7696 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7697 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7698 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7699 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7700 to avoid shadowing.
7701
ff08eb85
PE
7702 * textprop.c (property_change_between_p): Remove; unused.
7703
fc7bf025
PE
7704 * intervals.c (interval_start_pos): Now static.
7705
235d7abc
PE
7706 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7707
44f230aa
SM
7708 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7709 Rename locals to avoid shadowing.
3e7d6594 7710
50060332
PE
7711 * sound.c (wav_play, au_play, Fplay_sound_internal):
7712 Fix pointer signedness.
d01f234b 7713 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7714 (wav_play): Initialize a variable to 0, to prevent undefined
7715 behavior (Bug#8278).
50060332 7716
c4fc4e30
PE
7717 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7718
918436ed
PE
7719 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7720
c939f91b
PE
7721 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7722 clobbering (Bug#8298).
b9c7f648
PE
7723 * sysdep.c (sys_subshell): Likewise.
7724 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7725
6bd8c144
PE
7726 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7727 This should get cleaned up, so that child_setup has the
7728 same signature on all platforms.
7729
7710357c 7730 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7731 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7732
c59da222
CY
77332011-03-22 Chong Yidong <cyd@stupidchicken.com>
7734
7735 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7736 not to be necessary, and produces flickering.
7737
66b87493
GM
77382011-03-20 Glenn Morris <rgm@gnu.org>
7739
7740 * config.in: Remove file.
7741
45b6f6d5
JB
77422011-03-20 Juanma Barranquero <lekktu@gmail.com>
7743
7744 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7745 are now in src/globals.h.
7746 (syms_of_minibuf): Remove spurious & from previous change.
7747
3ec03f7e
LL
77482011-03-20 Leo <sdl.web@gmail.com>
7749
7750 * minibuf.c (completing-read-function): New variable.
7751 (completing-read-default): Rename from completing-read.
7752 (completing-read): Call completing-read-function.
7753
b14e3e21
CY
77542011-03-19 Juanma Barranquero <lekktu@gmail.com>
7755
7756 * xfaces.c (Fx_load_color_file):
7757 Read color file from absolute filename (bug#8250).
7758
f2b726e6
JB
77592011-03-19 Juanma Barranquero <lekktu@gmail.com>
7760
7761 * makefile.w32-in: Update dependencies.
7762
09f6ff02
EZ
77632011-03-17 Eli Zaretskii <eliz@gnu.org>
7764
7765 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7766
29a6015a
PE
77672011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7768
a3a6c54e
PE
7769 Fix more problems found by GCC 4.5.2's static checks.
7770
b766f867
PE
7771 * process.c (make_serial_process_unwind, send_process_trap):
7772 (sigchld_handler): Now static.
7773
be02381c
PE
7774 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7775 That way, the code declares only the vars that it needs.
7776 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7777 * s/cygwin.h (PTY_ITERATION): Likewise.
7778 * s/darwin.h (PTY_ITERATION): Likewise.
7779 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7780
57048744
PE
7781 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7782 * process.c (allocate_pty): Don't declare stb unless it's needed.
7783
7914961c 7784 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7785 (CONSTANTLIM): Remove; unused.
7786 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7787 Define only if needed.
7914961c 7788
b3967b18
PE
7789 * unexelf.c (unexec): Name an expression,
7790 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7791 Use a different way to cause a compilation error if anyone uses
7792 n rather than nn, a way that does not involve shadowing.
73366a00 7793 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7794
29a6015a
PE
7795 * deps.mk (unexalpha.o): Remove; unused.
7796
43cfc33e 7797 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7798 * unexec.h: New file.
ce701a33
PE
7799 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7800 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7801 Depend on unexec.h.
7802 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7803 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7804 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7805 Change as necessary to match prototype in unexec.h.
ce701a33 7806
01f44d5a
PE
7807 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7808 shadowing.
4f63c6bb 7809 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7810
a6670b0b
PE
7811 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7812 Rename locals to avoid shadowing.
7813
cef2010d 7814 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7815 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7816
d4d7173a
PE
7817 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7818
f08b802a
PE
7819 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7820 warning when compiling print.c.
7821
3ddb0639
PE
7822 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7823 instead of using an uninitialized var.
5ad03b97 7824 (font_sort_entities): Mark var as initialized.
3ddb0639 7825
170a2692
PE
7826 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7827
e663c700
PE
7828 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7829 pointers to constants.
89bc529a 7830 (font_parse_fcname): Remove unused vars.
7b81e2d0 7831 (font_delete_unmatched): Now static.
ea838e10 7832 (font_get_spec): Remove; unused.
13a547c6
PE
7833 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7834 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7835 Rename or move locals to avoid shadowing.
e663c700 7836
2a80c887 7837 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7838 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7839
1384fa33 7840 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7841 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7842
8b2c52e9
PE
7843 * alloc.c (mark_backtrace): Move decl from here ...
7844 * lisp.h: ... to here, so that it can be checked.
7845
475545b5 7846 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7847 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7848 (lisp_indirect_variable): Name an expression,
7849 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7850 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7851
b1349114 7852 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7853 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7854 Use const pointer when appropriate.
b1349114 7855
a2928364
PE
7856 * lisp.h (get_system_name, get_operating_system_release):
7857 Move decls here, to check interfaces.
7858 * process.c (get_operating_system_release): Move decl to lisp.h.
7859 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7860 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7861 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7862 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7863 (Fformat_time_string, Fencode_time, Finsert_char):
7864 (Ftranslate_region_internal, Fformat):
7865 Rename or remove local vars to avoid shadowing.
9710023e 7866 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7867
a415e694
PE
7868 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7869 avoid shadowing.
7870
8ef4622d
PE
7871 * lisp.h (eassert): Check that the argument compiles, even if
7872 ENABLE_CHECKING is not defined.
7873
946f9a5b
PE
7874 * data.c (Findirect_variable): Name an expression, to avoid
7875 gcc -Wbad-function-cast warning.
112396d6 7876 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7877 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7878 (Fmake_variable_buffer_local, Fmake_local_variable):
7879 Mark variables as initialized.
52746918 7880 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7881
e5aab7e7 7882 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7883 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7884 Rename locals to avoid shadowing.
dff45157
PE
7885 (mark_stack): Move local variables into the #ifdef region where
7886 they're used.
7bc26fdb
PE
7887 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7888 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7889 needed otherwise.
7890 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7891 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7892 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7893
e5aab7e7
PE
7894 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7895 avoids undefined behavior in theory.
7896
4da60324
PE
7897 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7898
88043301
PE
7899 Use functions, not macros, for up- and down-casing (Bug#8254).
7900 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7901 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7902 to use the following functions instead of these macros.
7903 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7904 EMACS_INT, since callers assume the returned value fits in int.
7905 (upcase1): Likewise, for UPCASE_TABLE.
7906 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7907 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7908 the race-condition problem in the old DOWNCASE.
88043301 7909
19ed5445
PE
7910 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7911 Rename locals to avoid shadowing.
7912 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7913 (regex_compile, re_search_2, re_match_2_internal):
7914 Remove unused local vars.
952db0d7
PE
7915 (FREE_VAR): Rewrite so as not to use empty "else",
7916 which gcc can warn about.
da053e48 7917 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7918 (RETALLOC_IF): Define only if needed.
7919 (WORDCHAR_P): Likewise. This one is never needed, but is used
7920 only in a comment talking about a compiler bug, so put inside
7921 the #if 0 of that comment.
7922 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7923 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7924 Remove; unused.
19ed5445 7925
1f3561e4 7926 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7927 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7928 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7929
ded6f8f7
PE
7930 * search.c (simple_search): Remove unused var.
7931
dbd37a95
PE
7932 * dired.c (compile_pattern): Move decl from here ...
7933 * lisp.h: ... to here, so that it can be checked.
7934 (struct re_registers): New forward decl.
7935
7e47afad
PE
7936 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7937
85f24f61
PE
7938 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7939 All uses changed.
7940 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7941 Rename locals to avoid shadowing.
5671df8f 7942 (Fvertical_motion): Mark locals as initialized.
85f24f61 7943
181aa2be 7944 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7945 (casify_region): Mark local as initialized.
181aa2be 7946
930d429c
PE
7947 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7948
7082eac6
PE
7949 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7950 New macros, so that the caller can use some names other than
7951 gcpro1, gcpro2, etc.
7952 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7953 of the new macros.
7954 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7955 argument, for consistency with GCPRO2_VAR, etc: it is now the
7956 prefix of the variable, not the variable itself. All uses
7957 changed.
38b2c076
PE
7958 * dired.c (directory_files_internal, file_name_completion):
7959 Rename locals to avoid shadowing.
7960
15206ed9
PE
7961 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7962 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7963 dired.c's scmp function, had undefined behavior.
7964 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7965 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7966 * buffer.h: ... to here, because these macros use current_buffer,
7967 and the new implementation with inline functions needs to have
7968 current_buffer in scope now, rather than later when the macros
7969 are used.
7970 (downcase, upcase1): New static inline functions.
7971 (DOWNCASE, UPCASE1): Reimplement using these functions.
7972 This avoids undefined behavior in expressions like
7973 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7974 from race conditions in accessing the global variables
7975 case_temp1 and case_temp2.
7976 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7977 * lisp.h (case_temp1, case_temp2): Remove their decls.
7978 * character.h (ASCII_CHAR_P): Move from here ...
7979 * lisp.h: ... to here, so that the inline functions mentioned
7980 above can use them.
7981
4a6bea26
PE
7982 * dired.c (directory_files_internal_unwind): Now static.
7983
f14b7e14
PE
7984 * fileio.c (file_name_as_directory, directory_file_name):
7985 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7986 Now static.
2893f146
PE
7987 (file_name_as_directory): Use const pointers when appropriate.
7988 (Fexpand_file_name): Likewise. In particular, newdir might
7989 point at constant storage, so make it a const pointer.
fd4ead52 7990 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7991 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7992 signedness issues.
f839df0c
PE
7993 (Fset_file_times, Finsert_file_contents, auto_save_error):
7994 Rename locals to avoid shadowing.
f14b7e14 7995
5716756e 7996 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7997 (Ftry_completion, Fall_completions): Rename or remove locals
7998 to avoid shadowing.
5716756e 7999
b4c3046a
PE
8000 * marker.c (bytepos_to_charpos): Remove; unused.
8001
b45db522
PE
8002 * lisp.h (verify_bytepos, count_markers): New decls,
8003 so that gcc does not warn that these functions aren't declared.
8004
85876d07
PE
8005 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8006 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8007 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8008 (copy_text): Remove unused local var.
85876d07 8009
03d78a21 8010 * filelock.c (within_one_second): Now static.
b3dd38ab 8011 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8012
5df8f01b
PE
8013 * buffer.c (fix_overlays_before): Mark locals as initialized.
8014 (fix_start_end_in_overlays): Likewise. This function should be
8015 simplified by using pointers-to-pointers, but that's a different
8016 matter.
b1d876f1 8017 (switch_to_buffer_1): Now static.
8f54f30a
PE
8018 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8019 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8020
a70072c9 8021 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8022 Fix pointer signedness issue.
edced198
PE
8023 (sys_subshell): Mark local as volatile if checking for lint,
8024 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8025 (MAXPATHLEN): Define only if needed.
a70072c9 8026
a0977c44
PE
8027 * process.c (serial_open, serial_configure): Move decls from here ...
8028 * systty.h: ... to here, so that they can be checked.
8029
a884fdcc
PE
8030 * fns.c (get_random, seed_random): Move extern decls from here ...
8031 * lisp.h: ... to here, so that they can be checked.
8032
604efe86 8033 * sysdep.c (reset_io): Now static.
b8950c94 8034 (wait_for_termination_signal): Remove; unused.
604efe86 8035
38fc62d9
PE
8036 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8037 (copy_keymap_item, append_key, push_text_char_description):
8038 Now static.
1004a21a 8039 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8040 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8041 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8042 (describe_map_tree):
8043 Rename locals to avoid shadowing.
38fc62d9 8044
2f2650da
PE
8045 * keyboard.c: Declare functions static if they are not used elsewhere.
8046 (echo_char, echo_dash, cmd_error, top_level_2):
8047 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8048 (read_char, kbd_buffer_get_event, make_lispy_position):
8049 (make_lispy_event, make_lispy_movement, apply_modifiers):
8050 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8051 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8052 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8053 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8054 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8055
a053e86c 8056 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8057 (mark_kboards): Move decl here ...
8058 * alloc.c (mark_kboards): ... from here.
a053e86c 8059
4752793e
PE
8060 * lisp.h (force_auto_save_soon): New decl.
8061
74f10ca7 8062 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8063 (DEFINE_DUMMY_FUNCTION): New macro.
8064 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8065 Use it.
c03cd23f
PE
8066 (main): Add casts to avoid warnings
8067 if GCC considers string literals to be constants.
74f10ca7 8068
022e70d4
PE
8069 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8070
59d6fe83
PE
8071 * dbusbind.c: Pointer signedness fixes.
8072 (xd_signature, xd_append_arg, xd_initialize):
8073 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8074 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8075 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8076 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8077
78320123
PE
8078 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8079 if GCC considers string literals to be constants.
49cebcca 8080 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8081
35ac2a97
SM
80822011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8083
fb103ca9
SM
8084 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8085 (print_preprocess, print_object): New macro to fix last change.
8086
35ac2a97
SM
8087 * print.c (print_preprocess): Don't forget font objects.
8088
62973b41
JB
80892011-03-16 Juanma Barranquero <lekktu@gmail.com>
8090
8091 * emacs.c (USAGE3): Doc fixes.
8092
0e48bb22
AS
80932011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8094
8095 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8096 structure.
8097
7684e57b
JB
80982011-03-14 Juanma Barranquero <lekktu@gmail.com>
8099
8100 * lisp.h (VWindow_system, Qfile_name_history):
8101 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8102 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8103 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8104
8105 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8106 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8107
8108 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8109 * w32console.c (detect_input_pending, read_input_pending)
8110 (encode_terminal_code):
8111 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8112 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8113 (w32_system_caret_y, Qfile_name_history):
8114 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8115 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8116 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8117 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8118 * w32proc.c (Qlocal, report_file_error):
8119 * w32term.c (Vwindow_system, updating_frame):
8120 * w32uniscribe.c (initialized, uniscribe_font_driver):
8121 Remove unneeded extern declarations.
8122
2aa46d6c
CY
81232011-03-14 Chong Yidong <cyd@stupidchicken.com>
8124
c96bbc66 8125 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8126
cffc6f3b
CY
81272011-03-13 Chong Yidong <cyd@stupidchicken.com>
8128
8129 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8130 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8131 These macros can no longer be used for assignment.
8132
44f230aa
SM
8133 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8134 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8135 (record_buffer_markers, fetch_buffer_markers): New functions for
8136 recording and fetching special buffer markers.
8137 (set_buffer_internal_1, set_buffer_temp): Use them.
8138
8139 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8140
8141 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8142
8143 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8144 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8145
8146 * xdisp.c (hscroll_window_tree):
8147 (reconsider_clip_changes): Use PT instead of BUF_PT.
8148
d251f04b
EZ
81492011-03-13 Eli Zaretskii <eliz@gnu.org>
8150
8151 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8152 $(EMACS_ROOT)/lib/intprops.h.
8153
f0c77cd1
PE
81542011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8155
3eca4629
PE
8156 Fix more problems found by GCC 4.5.2's static checks.
8157
7c86ee98
PE
8158 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8159 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8160 (xg_free_frame_widgets): Make it clear that a local variable is
8161 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8162 (gdk_window_get_screen): Make it clear that this macro is needed
8163 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8164 (int_gtk_range_get_value): New function, which avoids a diagnostic
8165 from gcc -Wbad-function-cast.
8166 (xg_set_toolkit_scroll_bar_thumb): Use it.
8167 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8168 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8169 (get_utf8_string, xg_get_file_with_chooser):
8170 Rename locals to avoid shadowing.
8171 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8172
41729b81
PE
8173 * xgselect.c (xg_select): Remove unused var.
8174
f0c77cd1
PE
8175 * image.c (four_corners_best): Mark locals as initialized.
8176 (gif_load): Initialize transparent_p to zero (Bug#8238).
8177 Mark another local as initialized.
ec6cf4c6 8178 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8179
ce0ad53d 8180 * image.c (clear_image_cache): Now static.
d5d5a617 8181 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8182 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8183 (x_edge_detection): Remove unnecessary cast that
8184 gcc -Wbad-function-cast diagnoses.
2037898d 8185 (gif_load): Fix pointer signedness.
6ae141d6
PE
8186 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8187 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8188
33383987 81892011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8190
d32df629
PE
8191 Improve quality of tests for time stamp overflow.
8192 For example, without this patch (encode-time 0 0 0 1 1
8193 1152921504606846976) returns the obviously-bogus value (-948597
8194 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8195 reports time overflow. See
8196 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8197 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8198 * editfns.c: Include limits.h and intprops.h.
8199 (TIME_T_MIN, TIME_T_MAX): New macros.
8200 (time_overflow): Move earlier, to before first use.
8201 (hi_time, lo_time): New functions, for an accurate test for
8202 out-of-range times.
8203 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8204 (Fget_internal_run_time): Don't assume time_t fits in int.
8205 (make_time): Use list2 instead of Fcons twice.
8206 (Fdecode_time): More accurate test for out-of-range times.
8207 (check_tm_member): New function.
8208 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8209 (lisp_time_argument): Don't rely on undefined left-shift and
8210 right-shift behavior when checking for time stamp overflow.
8be6f318 8211
fe31d94c
PE
8212 * editfns.c (time_overflow): New function, refactoring common code.
8213 (Fformat_time_string, Fdecode_time, Fencode_time):
8214 (Fcurrent_time_string): Use it.
8215
8be6f318
PE
8216 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8217 * dired.c (make_time): Move to ...
8218 * editfns.c (make_time): ... here.
8219 * systime.h: Note the move.
8220
09d9db2c 82212011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8222
126bc0dc
YM
8223 * fringe.c (update_window_fringes): Remove unused variables.
8224
c47cbdfd
YM
8225 * unexmacosx.c (copy_data_segment): Also copy __got section.
8226 (Bug#8223)
8227
7ac80be9
EZ
82282011-03-12 Eli Zaretskii <eliz@gnu.org>
8229
c96bbc66 8230 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8231 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8232 Constify `char *' arguments and their references according to
8233 prototypes in tparam.h.
8234
ecb0f94d 8235 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8236
7ac80be9
EZ
8237 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8238 Adapt all references accordingly.
8239
8240 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8241
ef1fd07e
TT
82422011-03-11 Tom Tromey <tromey@redhat.com>
8243
8244 * buffer.c (syms_of_buffer): Remove obsolete comment.
8245
7ef4b50c
EZ
82462011-03-11 Eli Zaretskii <eliz@gnu.org>
8247
8248 * termhooks.h (encode_terminal_code): Declare prototype.
8249
8250 * msdos.c (encode_terminal_code): Don't declare prototype.
8251
8252 * term.c (encode_terminal_code): Now external again, used by
8253 w32console.c and msdos.c.
8254
44f230aa
SM
8255 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8256 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8257
4b1ec863 82582011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8259
1714f52b 8260 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8261
4b1ec863
PE
8262 * fringe.c (update_window_fringes): Mark locals as initialized
8263 (Bug#8227).
8264 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8265
524c7aa6
PE
8266 * alloc.c (mark_fringe_data): Move decl from here ...
8267 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8268 to check its interface.
8269 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8270
a5c0af81 8271 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8272 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8273 (fontset_font): Mark local as initialized.
a9a06e0b 8274 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8275
b4716021
PE
8276 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8277
811e9bac 8278 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8279 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8280 (x_own_selection, Fx_disown_selection_internal): Rename locals
8281 to avoid shadowing.
8282 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8283
7e3ab302
PE
8284 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8285 so that the caller can use some name other than gcpro1.
8286 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8287 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8288 (Fx_backspace_delete_keys_p):
8289 Use them to avoid shadowing, and rename vars to avoid shadowing.
8290 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8291 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8292 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8293 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8294 Remove unused locals.
7e3ab302
PE
8295 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8296 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8297 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8298 macros.
f78faa98 8299
e2b13473
PE
8300 * xterm.h (x_mouse_leave): New decl.
8301
77f23912
PE
8302 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8303 Remove unused functions.
cdf4ba58
PE
8304 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8305 (x_calc_absolute_position): Now static.
7411c686 8306 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8307 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8308 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8309 unless they are used.
38d0b34a
PE
8310 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8311 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8312 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8313 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8314 (x_error_catcher, x_connection_closed, x_error_handler):
8315 (x_error_quitter, xembed_send_message, x_iconify_frame):
8316 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8317 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8318 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8319
44f230aa
SM
8320 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8321 Rename or move locals to avoid shadowing.
6b463e58 8322 (tty_defined_color, merge_face_heights): Now static.
5967d051 8323 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8324 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8325 does not deduce is never used uninitialized.
73719eba
PE
8326 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8327 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8328
426994c3 8329 * terminal.c (store_terminal_param): Now static.
5489860b 8330
032f1620 8331 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8332 (set_frame_menubar): Remove unused local.
d4323972 8333 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8334 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8335 since they might point to immutable storage.
281585b0
PE
8336 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8337 since it's unused otherwise.
032f1620 8338
367c19e5 8339 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8340 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8341 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8342 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8343 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8344 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8345 does not deduce are never used uninitialized.
70739cbe 8346
07b48fa9
PE
8347 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8348
8868a238 8349 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8350 * window.c (window_loop, size_window):
8351 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8352
7e5cf297 8353 * window.c (display_buffer): Now static.
d6550a9f
PE
8354 (size_window): Mark variables that gcc -Wuninitialized
8355 does not deduce are never used uninitialized.
a586633d
PE
8356 * window.h (check_all_windows): New decl, to forestall
8357 gcc -Wmissing-prototypes diagnostic.
5b555da1 8358 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8359
f6095868
PE
8360 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8361 shadowing.
8362 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8363 Include <limits.h>.
8364 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8365 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8366 (load_charset_map): Mark variables that gcc -Wuninitialized
8367 does not deduce are never used uninitialized.
53df7c11 8368 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8369
f38b440c
PE
8370 * coding.c (coding_set_source, coding_set_destination):
8371 Use "else { /* comment */ }" rather than "else /* comment */;"
8372 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8373 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8374 a block, when the outer 'i' will do.
8375 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8376 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8377 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8378 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8379 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8380 Rename locals to avoid shadowing.
8381 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8382 * coding.c (emacs_mule_char, encode_invocation_designation):
8383 Now static, since they're not used elsewhere.
413bb2db 8384 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8385 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8386 (decode_coding_emacs_mule): Mark variables that gcc
8387 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8388 (detect_coding_iso_2022): Initialize a local variable that might
8389 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8390 this initialization is needed. (Bug#8211)
5f58e762
PE
8391 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8392 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8393 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8394 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8395 Remove unused macros.
f38b440c 8396
232b38b9 8397 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8398 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8399 * character.c (string_count_byte8): Likewise.
232b38b9 8400
fb90da1b
PE
8401 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8402 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8403
fb93dbc2
PE
8404 * chartab.c (copy_sub_char_table): Now static, since it's not used
8405 elsewhere.
5c156ace
PE
8406 (sub_char_table_ref_and_range, char_table_ref_and_range):
8407 Rename locals to avoid shadowing.
bbcd0949 8408 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8409
7d3b3862 8410 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8411 (BIDI_BOB): Remove unused macro.
7d3b3862 8412
6be7d3da
PE
8413 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8414 deduce are never used uninitialized.
c2ed9c8b 8415 * term.c (encode_terminal_code): Likewise.
6be7d3da 8416
75f8807f 8417 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8418
50938595
PE
8419 * tparam.h: New file.
8420 * term.c, tparam.h: Include it.
8421 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8422 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8423 Move these decls to tparam.h, and make them agree with what
8424 is actually in tparam.c. The previous trick of using incompatible
8425 decls in different modules does not conform to the C standard.
8426 All callers of tparam changed to use tparam's actual API.
8427 * tparam.c (tparam1, tparam, tgoto):
8428 Use const pointers where appropriate.
8429
fbceeba2
PE
8430 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8431 * cm.h (struct cm): Likewise.
8432 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8433 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8434 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8435 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8436 (turn_on_face, init_tty): Likewise.
8437 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8438
7f3f1250
PE
8439 * term.c (term_mouse_position): Rename local to avoid shadowing.
8440
e6ca6543
PE
8441 * alloc.c (mark_ttys): Move decl from here ...
8442 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8443
c40f8d15
AS
84442011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8445
8446 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8447
cfe0661d
JB
84482011-03-09 Juanma Barranquero <lekktu@gmail.com>
8449
8450 * search.c (compile_pattern_1): Remove argument regp, unused since
8451 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8452 (compile_pattern): Don't pass it.
8453
0afb4571
J
84542011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8455
8456 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8457 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8458 for ! HAVE_GTK3.
8459 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8460
8461 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8462
8463 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8464 gdk_window_get_screen, gdk_window_get_geometry,
8465 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8466 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8467 (xg_get_pixbuf_from_pixmap): New function.
8468 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8469 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8470 Call xg_get_pixbuf_from_pixmap instead of
8471 gdk_pixbuf_get_from_drawable.
8472 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8473 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8474 (xg_check_special_colors): Use GtkStyleContext and its functions
8475 for HAVE_GTK3.
8476 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8477 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8478 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8479 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8480 Call gtk_widget_get_preferred_size.
0afb4571
J
8481 (xg_frame_resized): gdk_window_get_geometry only takes 5
8482 parameters.
44f230aa
SM
8483 (xg_win_to_widget, xg_event_is_for_menubar):
8484 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8485 (xg_set_widget_bg): New function.
8486 (delete_cb): New function.
895009e1 8487 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8488 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8489 (xg_set_background_color): Call xg_set_widget_bg.
8490 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8491 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8492 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8493 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8494 if ! HAVE_GTK3.
8495 (update_frame_tool_bar): Call gtk_widget_hide.
8496 (xg_initialize): Use GDK_KEY_g.
8497
8498 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8499 if ! HAVE_GTK3
8500 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8501
8502 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8503 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8504 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8505
1c2cc4ef
JB
85062011-03-08 Juanma Barranquero <lekktu@gmail.com>
8507
8508 * w32xfns.c (select_palette): Check success of RealizePalette against
8509 GDI_ERROR, not zero.
8510
33383987 8511See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8512
8513;; Local Variables:
8514;; coding: utf-8
aac0c6e3
MR
8515;; End:
8516
33383987 8517 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8518
8519 This file is part of GNU Emacs.
8520
8521 GNU Emacs is free software: you can redistribute it and/or modify
8522 it under the terms of the GNU General Public License as published by
8523 the Free Software Foundation, either version 3 of the License, or
8524 (at your option) any later version.
8525
8526 GNU Emacs is distributed in the hope that it will be useful,
8527 but WITHOUT ANY WARRANTY; without even the implied warranty of
8528 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8529 GNU General Public License for more details.
8530
8531 You should have received a copy of the GNU General Public License
8532 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.