Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
df81cd29
EZ
12012-07-28 Eli Zaretskii <eliz@gnu.org>
2
01bd1b0d
EZ
3 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
4 * w32inevt.c: Include w32inevt.h.
5 (w32_read_console_input): New inline function, calls either
6 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
7 w32_console_unicode_input.
8 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
9 (w32_kbd_patch_key, key_event): Use the codepage returned by
10 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
11 (key_event): use uChar.UnicodeChar only if
12 w32_console_unicode_input is non-zero.
13
14 * w32console.c: Include w32heap.h.
15 <w32_console_unicode_input>: New global variable.
16 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
17 family of Windows, zero otherwise.
18
19 * w32inevt.h: Declare w32_console_unicode_input.
20
df81cd29
EZ
21 * xdisp.c (init_iterator): Don't reference tip_frame in a build
22 --without-x. (Bug#11742)
23
c20fdd9e
PE
242012-07-27 Paul Eggert <eggert@cs.ucla.edu>
25
26 Adjust GDB to reflect pvec_type changes (Bug#12036).
27 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
28 2012-07-04 changes to pseudovector representation. Problem
29 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
30
32770973 312012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
32
33 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
34 bus address.
35 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
36
3438fe21
EZ
372012-07-27 Eli Zaretskii <eliz@gnu.org>
38
bcfbc9de
EZ
39 * alloc.c (listn): Fix the order the arguments are consed onto the
40 list.
41
3438fe21
EZ
42 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
43 enumeration constants, as PURE and HEAP are too general, and clash
44 with other headers and sources, such as gmalloc.c and the
45 MS-Windows system headers. All users changed.
46
eeaea515
DA
472012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
48
49 Revert last save_excursion_save and save_excursion_restore changes.
50 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
51 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
52
073c88c2
DA
532012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
54
55 Fix recently-introduced typos in Windows port.
56 Reported by Martin Rudalics <rudalics@gmx.at>.
57 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 58 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 59
4706125e
PE
602012-07-27 Paul Eggert <eggert@cs.ucla.edu>
61
62 Improve GDB symbol export (Bug#12036).
63 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
64 arms of an 'if', not using conditional expressions; otherwise GDB
65 complains about the types in the unevaluated arm when the argument
66 is an integer literal.
67 (xgetint): Simplify expression.
68 * alloc.c (gdb_make_enums_visible): New constant. This ports to
69 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
70 Zaretskii in <http://bugs.gnu.org/12036#13>.
71 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
72 needed now that we have gdb_make_enums_visible.
73 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
74 (enum enum_USE_LSB_TAG):
75 New enum types, packaging up enums that need to be exported to GDB.
76
694b6c97
DA
772012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
78
79 Utility function to make a list from specified amount of objects.
80 * lisp.h (enum constype): New datatype.
81 (listn): New prototype.
82 * alloc.c (listn): New function.
83 (Fmemory_use_count, syms_of_alloc): Use it.
84 * buffer.c (syms_of_buffer): Likewise.
85 * callint.c (syms_of_callint): Likewise.
86 * charset.c (define_charset_internal): Likewise.
87 * coding.c (syms_of_coding): Likewise.
88 * keymap.c (syms_of_keymap): Likewise.
89 * search.c (syms_of_search): Likewise.
90 * syntax.c (syms_of_syntax): Likewise.
91 * w32.c (init_environment): Likewise.
92 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
93 * xdisp.c (syms_of_xdisp): Likewise.
94 * xfns.c (syms_of_xfns): Likewise.
95
6195f384
DA
962012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
97
98 Fast save_excursion_save and save_excursion_restore.
99 * lisp.h (struct Lisp_Excursion): New data type.
100 (PVEC_EXCURSION): New pseudovector type.
101 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
102 to deal with it. Adjust comments.
103 (init_marker, attach_marker): New prototype.
104 (unchain_marker): Adjust prototype.
105 * marker.c (attach_marker): Change to global.
106 (init_marker): New function.
107 * alloc.c (Fmake_marker, build_marker): Use it.
108 (build_marker): More easserts.
109 (mark_object): Handle struct Lisp_Excursion.
110 * editfns.c (save_excursion_save, save_excursion_restore):
111 Reimplement to use struct Lisp_Excursion. Add comments.
112
5eceb8fb
PE
1132012-07-26 Paul Eggert <eggert@cs.ucla.edu>
114
115 Fix export of symbols to GDB (Bug#12036).
116 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
117 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
118 emacs.c, as this is a more-suitable home. Had this been done earlier
119 the fix for 12036 would have avoided some of the problems noted in
120 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
121 would have been more obvious.
562157c8
PE
122 * emacs.c: Do not include <verify.h>; no longer needed.
123 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
124 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
125 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
126 Remove; now done in lisp.h.
127 * lisp.h (PUBLISH_TO_GDB): New macro.
128 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
129 (DATA_SEG_BITS): Use it.
130 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
131 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
132 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
133 not be usable in #if. This simplifies things.
134
d6749401
JB
1352012-07-26 Juanma Barranquero <lekktu@gmail.com>
136
137 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
138
1781b9e9
PE
1392012-07-26 Paul Eggert <eggert@cs.ucla.edu>
140
d89518db 141 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
142 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
143 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
144 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
145 Adjust to changes in lisp.h and emacs.c, by using
146 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
147 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
148 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
149 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
150 instead of gdb_valbits.
151 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
152 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
153 instead of gdb_array_mark_flag.
154 (xboolvector): Get size from $->size, not $->header.size.
155 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
156 (xreload, hook-run, hookpost-run): Remove.
157 * emacs.c: Include <verify.h>.
158 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
159 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
160 Remove.
161 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
162 (gdb_USE_LSB_TAG): New enum constants.
163 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
164 Also define these as enum constants, so they're visible to GDB.
165 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
166 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
167 as constants, so they're visible to GDB.
168 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
169 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
170 Now enum constants, not macros, so they're visible to GDB.
171 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
172 more convenient now. All uses changed.
173 (VALMASK) [USE_LSB_TAG]: Also define in this case.
174 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
175
3628596a
DA
1762012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
177
178 Explicitly free restriction data that are not needed anymore.
179 * editfns.c (save_restriction_restore): Free restriction data.
180
7abaf5cc
SM
1812012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
182
183 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
184 add argument, tune behavior, and adjust all callers.
185
71f88e00
PE
1862012-07-25 Paul Eggert <eggert@cs.ucla.edu>
187
188 Use typedef for EMACS_INT, EMACS_UINT.
189 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
190 than macros. This simplifies debugging in the usual case, since
191 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
192 and it allows expressions involving EMACS_INT casts.
193 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
194
57ec3034
JD
1952012-07-25 Jan Djärv <jan.h.d@swipnet.se>
196
197 * nsterm.m (ns_read_socket): Return early if there is a modal
198 window (Bug#12043).
199
8137e7b3
MR
2002012-07-25 Martin Rudalics <rudalics@gmx.at>
201
202 * frame.c (Fredirect_frame_focus): In doc-string don't mention
203 that FOCUS-FRAME can be omitted.
204
04e9897c
DA
2052012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
206
207 Adjust buffer text indirection counters at the end of Fkill_buffer.
208 * buffer.c (Fkill_buffer): Adjust indirection counters when the
209 buffer is definitely dead. This should really fix an issue reported
210 by Christoph Scholtes again. (Bug#12007).
211 (init_buffer_once): Initialize indirection counters of
212 buffer_defaults and buffer_local_symbols (for sanity and safety).
213
8a0484e1
EZ
2142012-07-24 Eli Zaretskii <eliz@gnu.org>
215
216 * xdisp.c (init_iterator): Don't compute dimensions of truncation
217 and continuation glyphs on tooltip frames, leave them at zero.
218 Avoids continued lines in tooltips. (Bug#11832)
219
fa691a83
DA
2202012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
221
222 Simplify copy_overlay.
04e9897c 223 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
224 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
225
436bc8e0
EZ
2262012-07-23 Eli Zaretskii <eliz@gnu.org>
227
228 * print.c (print_object): Don't crash when a frame's name is nil
229 or invalid. (Bug#12025)
230
231 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
232 it signals an error when a tooltip frame is being created.
233
d7a7fda3
DA
2342012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
235
236 Cleanup miscellaneous objects allocation and initialization.
237 * alloc.c (allocate_misc): Change to static. Add argument to
238 specify the subtype. Adjust comment and users.
239 (build_overlay): New function.
240 * buffer.c (copy_overlays, Fmake_overlay): Use it.
241 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
242 (allocate_misc): Remove prototype.
243 (build_overlay): Add prototype.
244
2452012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
246
247 Swap buffer text indirection counters in Fbuffer_swap_text.
248 * buffer.c (Fbuffer_swap_text): Swap indirections too.
249 This avoids crash reported by Christoph Scholtes at
250 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
251
9d7fa573
JD
2522012-07-22 Jan Djärv <jan.h.d@swipnet.se>
253
254 * nsmenu.m (Popdown_data): New struct.
255 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
256 free Popdown_data.
257 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
258 (initWithContentRect): Make imgView and contentView non-static
259 and autorelease them. Also autorelease img and matrix (Bug#12005).
260 (dealloc): Remove (Bug#12005).
261
0dd6d66d
DA
2622012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
263
264 Adjust consing_since_gc when objects are explicitly freed.
265 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
266 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
267 (free_cons, free_misc): Subtract object size from consing_since_gc.
268
d36d71df
DA
2692012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Simplify and cleanup markers positioning code.
272 * marker.c (attach_marker): More useful eassert.
273 (live_buffer, set_marker_internal): New function.
274 (Fset_marker, set_marker_restricted): Use set_marker_internal.
275 (set_marker_both, set_marker_restricted_both): Use live_buffer.
276
fb9ea40f
PE
2772012-07-22 Paul Eggert <eggert@cs.ucla.edu>
278
279 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
280 as it's limited by the amount of memory, not by INT_MAX.
281
2d5c5f7d
EZ
2822012-07-21 Eli Zaretskii <eliz@gnu.org>
283
07fb592e
EZ
284 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
285 in special-event-map. See the discussion at
286 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
287 for the reasons.
288
37a9eac8 289 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
290 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
291 Fabrice Popineau <fabrice.popineau@supelec.fr>.
292
c4328746
JD
2932012-07-21 Jan Djärv <jan.h.d@swipnet.se>
294
295 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 296 (conversationIdentifier): Return value is NSInteger.
784051c4 297 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 298
6e5d1c12
CY
2992012-07-21 Chong Yidong <cyd@gnu.org>
300
301 * window.c (decode_any_window): Signal an error if the window is
302 on a dead frame (Bug#11984).
303
9928463d
DA
3042012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
305
306 Add indirection counting to speed up Fkill_buffer.
307 * buffer.h (struct buffer): New member.
308 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
309 (Fmake_indirect_buffer): Set indirection counter to -1, increment
310 base buffer indirection counter.
311 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
312 (Fkill_buffer): Adjust indirection counters as needed, don't walk
313 through buffer list if indirection counter is 0.
314
f8643a6b
DA
3152012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
316
317 Extend the value returned by Fgarbage_collect with heap statistics.
318 * alloc.c (Qheap): New symbol.
319 (syms_of_alloc): DEFSYM it.
320 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
321 (Fmemory_free): Remove.
322 (syms_of_alloc): Don't defsubr it.
323 * buffer.c (Fcompact_buffer): Remove.
324 (syms_of_buffer): Don't defsubr it.
325
dac616ff
DA
3262012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
327
328 Make maybe_gc inline.
329 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
330 * lisp.h (consing_since_gc, gc_relative_threshold)
331 (memory_full_cons_threshold): Revert declaration.
332 (maybe_gc): Remove prototype, define as inline.
333 * alloc.c: Remove old commented-out code.
334 (consing_since_gc, gc_relative_threshold)
335 (memory_full_cons_threshold): Revert to global.
336 (maybe_gc): Remove.
337
d7ea76b4
DA
3382012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
339
340 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
341 * lisp.h (build_unibyte_string): New function.
342 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
343 * sysdep.c, w32fns.c, xfns.c: Use it.
344 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
345 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
346 Adjust users accordingly.
347 * font.h (font_open_by_name): Adjust prototype.
348
765e61e3
DA
3492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
350
351 Cleanup calls to Fgarbage_collect.
352 * lisp.h (maybe_gc): New prototype.
353 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
354 Remove declarations.
355 * alloc.c (maybe_gc): New function.
356 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
357 Make them static.
358 * bytecode.c (MAYBE_GC): Use maybe_gc.
359 * eval.c (eval_sub, Ffuncall): Likewise.
360 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
361 to avoid dependency from auto-save feature.
362
52b852c7
PE
3632012-07-19 Paul Eggert <eggert@cs.ucla.edu>
364
365 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
366 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
367 'for_each_per_buffer_object_at'.
368 All uses changed. It's better to use upper-case for macros that
369 cannot be implemented as functions, to give the reader a clue
370 that they're special.
371
5db81e33
SM
3722012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
373
374 * alloc.c (Fgarbage_collect): Tweak docstring.
375
5b835e1d
DA
3762012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
377
378 Tweak the value returned from Fgarbage_collect again.
379 * alloc.c (Fgarbage_collect): New return value, as confirmed in
380 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
381 Adjust documentation.
382 (total_vector_bytes): Rename to total_vector_slots, adjust
383 accounting.
384 (total_free_vector_bytes): Rename to total_free_vector_slots,
385 adjust accounting.
386 (Qstring_bytes, Qvector_slots): New symbols.
387 (syms_of_alloc): DEFSYM them.
388
9cd47b72
DA
3892012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
390
391 Buffer compaction primitive which may be used from Lisp.
392 * buffer.c (compact_buffer, Fcompact_buffer): New function.
393 (syms_of_buffer): Register Fcompact_buffer.
394 * alloc.c (Fgarbage_collect): Use compact_buffer.
395 * buffer.h (compact_buffer): New prototype.
396 (struct buffer_text): New member.
397
d17337e5
DA
3982012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
399
400 New macro to iterate over all buffers, miscellaneous cleanups.
401 * lisp.h (all_buffers): Remove declaration.
402 * buffer.h (all_buffers): Add declaration, with comment.
403 (for_each_buffer): New macro.
404 * alloc.c (Fgarbage_collect, mark_object): Use it.
405 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
406 (init_buffer): Likewise.
407 * data.c (Fset_default): Likewise.
408 * coding.c (code_conversion_restore): Remove redundant check
409 for dead buffer.
410 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
411
60cfd278
AS
4122012-07-18 Andreas Schwab <schwab@linux-m68k.org>
413
414 Fix bug that created negative-length intervals.
415 * intervals.c (merge_interval_right, merge_interval_left):
416 Do not zero out this interval if it is absorbed by its children,
417 as this interval's total length doesn't change in that case. See
418 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
419
d06714cb
PE
4202012-07-18 Paul Eggert <eggert@cs.ucla.edu>
421
83713154
PE
422 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
423 when invoking (make-bool-vector N t) and N is a positive
424 multiple of 8 -- the last 8 bits were mistakenly cleared.
425
d06714cb
PE
426 Remove some struct layout assumptions in bool vectors.
427 * alloc.c (bool_header_size): New constant.
428 (header_size, word_size): Move earlier, as they're now used earlier.
429 Use 'word_size' in a few more places, where it's appropriate.
430 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
431 padding before the data member of a bool vector.
432 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
433 than doing the check by hand with an abort ().
434
464d5a5e
SM
4352012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
436
5fbc0409
SM
437 * eval.c (Fdefvar): Don't check constants since we only set the var if
438 it's not yet defined anyway (bug#11904).
439
464d5a5e
SM
440 * lisp.h (last_undo_boundary): Declare new var.
441 * keyboard.c (command_loop_1): Set it.
442 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
443 were auto-added by the command loop (bug#11774).
444
8dc2e44a
AS
4452012-07-18 Andreas Schwab <schwab@linux-m68k.org>
446
447 * w32font.c (Qsymbol): Remove local definition.
448 (syms_of_w32font): Don't DEFSYM it.
449
169925ec
DA
4502012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
451
452 Fix sweep_vectors to handle large bool vectors correctly.
453 * alloc.c (sweep_vectors): Account total_vector_bytes for
454 bool vectors larger than VBLOCK_BYTES_MAX.
455
5fbfb018
CY
4562012-07-18 Chong Yidong <cyd@gnu.org>
457
458 * frame.c (x_set_frame_parameters): Revert bogus change introduced
459 in 2012-05-25 commit by Paul Eggert (Bug#11738).
460
3ab6e069
DA
4612012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Return more descriptive data from Fgarbage_collect.
464 Suggested by Stefan Monnier in
465 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
466 * alloc.c (bounded_number): New function.
467 (total_buffers, total_vectors): New variable.
468 (total_string_size): Rename to total_string_bytes, adjust users.
469 (total_vector_size): Rename to total_vector_bytes, adjust users.
470 (sweep_vectors): Account total_vectors and total_vector_bytes.
471 (Fgarbage_collect): New return value. Adjust documentation.
472 (gc_sweep): Account total_buffers.
473 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
474 (VECTOR_SIZE): Remove.
475 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
476 (Qinterval, Qmisc): New symbols.
477 (syms_of_data): Initialize them.
478 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
479 (Qcons, Qbuffer): New declarations.
480
6d02fe5b
PE
4812012-07-17 Paul Eggert <eggert@cs.ucla.edu>
482
483 * alloc.c (Fmemory_free): Account for memory-free's own storage.
484 Round up, not down. Improve doc.
485
b7ffe040
DA
4862012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Restore old code in allocate_string_data to avoid Faset breakage.
489 Reported by Julien Danjou <julien@danjou.info> in
490 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
491 * alloc.c (allocate_string_data): Restore old code with minor
492 adjustments, fix comment to explain this subtle issue.
493
4dc7c8d5
SM
4942012-07-17 Eli Zaretskii <eliz@gnu.org>
495
496 Remove FILE_SYSTEM_CASE.
497 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
498
499 * fileio.c (FILE_SYSTEM_CASE): Don't define.
500 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
501 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
502 call-process-region passes it through expand-file-name.
503
504 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
505
5062012-07-17 Andreas Schwab <schwab@linux-m68k.org>
507
508 Fix crash when creating indirect buffer (Bug#11917)
509 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
510 Don't handle unbound variables specially if non-zero.
511 (Fbuffer_local_variables): Pass zero.
512 (clone_per_buffer_values): Pass non-zero.
513
5142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
515
516 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
517 to make the loop interruptible.
518
5192012-07-17 Andreas Schwab <schwab@linux-m68k.org>
520
521 * gnutls.c (emacs_gnutls_handshake): Only retry if
522 GNUTLS_E_INTERRUPTED.
523
cce7fefc
DA
5242012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
525
526 Cleanup and convert miscellaneous checks to eassert.
527 * alloc.c (mark_interval): Fix comment, partially rephrase
528 old comment from intervals.h (see below).
529 * intervals.c (find_interval, adjust_intervals_for_insertion)
530 (delete_interval, adjust_intervals_for_deletion)
531 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
532 Convert to eassert.
533 (adjust_intervals_for_insertion, make_new_interval):
534 Remove obsolete and unused code.
535 * intervals.h (struct interval): Remove obsolete comment.
536 * textprotp.c (erase_properties): Remove unused code.
537 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
538 (Fremove_list_of_text_properties): Convert to eassert.
539
9ea10cc3
CY
5402012-07-17 Chong Yidong <cyd@gnu.org>
541
542 * editfns.c (Finsert_char): Doc fix.
543
3900d5de
DA
5442012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
545
546 Fix previous change to make Fmemory_free always accurate.
547 * alloc.c (make_interval): Update total_free_intervals.
548 (make_float): Likewise for total_free_floats.
549 (free_cons, Fcons): Likewise for total_free_conses.
550 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
551 Likewise for total_free_vector_bytes.
552 (Fmake_symbol): Likewise for total_free_symbols.
553 (bytes_free): Remove.
554
7098646f
DA
5552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
556
557 Simple free memory accounting feature.
558 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
559 (sweep_vectors): Accumulate size of free vectors.
560 (Fgarbage_collect): Setup bytes_free.
561 (Fmemory_free): New function.
562 (syms_of_alloc): Register it.
563
22657b40
DA
5642012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
565
566 Cleanup overlays checking.
567 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
568 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
569 eassert and OVERLAYP.
570 (sort_overlays): Change to use OVERLAYP.
571
ddfc8813
RK
5722012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
573
574 * editfns.c (Finsert_char): Make it interactive, and make the
575 second arg optional. Copy interactive spec and docstring from
576 ucs-insert.
577
7c26cf3c
PE
5782012-07-17 Paul Eggert <eggert@cs.ucla.edu>
579
580 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
581 Unlike the other wrapped functions, fabs has an unspecified
582 effect on errno.
583
5d127af9
JD
5842012-07-16 Jan Djärv <jan.h.d@swipnet.se>
585
586 * nsterm.m (keyDown): Interpret flags without left/right bits
587 as the left key (Bug#11670).
588
6a0dd1d7
DA
5892012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
590
591 Remove empty and useless init functions.
592 * lisp.h (init_character_once, init_fns, init_image)
593 (init_filelock, init_sound): Remove prototype.
594 * character.c (init_character_once): Remove.
595 * filelock.c (init_filelock): Likewise.
596 * fns.c (init_fns): Likewise.
597 * image.c (init_image): Likewise.
598 * sound.c (init_sound): Likewise.
599 * emacs.c (main): Adjust accordingly.
600
7a6136fd
DA
6012012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
602
603 * gtkutil.h: Tiny cleanups.
604 (use_old_gtk_file_dialog): Remove useless declaration.
605 (xg_uses_old_file_dialog): Add suggested const attribute.
606
ce811ad9
EZ
6072012-07-15 Eli Zaretskii <eliz@gnu.org>
608
609 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
610 (bidi_paragraph_init): Use it to limit search forward for a strong
611 directional character in abnormally large paragraphs full of
612 neutral or weak characters. (Bug#11943)
613
c9adfeaa
SF
6142012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
615
616 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
617 the toolbar (Bug#9451).
618 (xg_make_tool_item): Give the widget event box a transparent
619 background.
620
fff62aa9
DA
6212012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
622
623 Cleanup basic allocation variables and functions.
624 * alloc.c (ignore_warnings, init_intervals, init_float)
625 (init_cons, init_symbol, init_marker): Remove.
626 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
627 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
628 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
629 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
630 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
631 (staticidx, init_alloc_once, init_strings, free_ablock):
632 Remove redundant initialization.
633 * fns.c (init_weak_hash_tables): Remove.
634 * lisp.h (init_weak_hash_tables): Remove prototype.
635
9730daca
DA
6362012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
637
638 Use zero_vector where appropriate.
639 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
640 accordingly.
641 * lisp.h (zero_vector): New declaration.
642 * font.c (null_vector): Remove.
643 (syms_of_font): Remove initialization and staticpro.
644 (font_list_entities, font_find_for_lface): Change to use zero_vector.
645 * keymap.c (Faccessible_keymaps): Likewise.
646
2e2d2a13
LL
6472012-07-15 Leo Liu <sdl.web@gmail.com>
648
649 * fringe.c: Fix typo in comments.
650
cd276f6e
LL
6512012-07-14 Leo Liu <sdl.web@gmail.com>
652
653 * fringe.c: Add a new bitmap exclamation-mark.
654
5a1131d9
EZ
6552012-07-14 Eli Zaretskii <eliz@gnu.org>
656
657 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
658
659 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
660 (HAVE_MENUS): Don't define, defined by editing config.in with
661 msdos/sed2v2.inp.
662 (GMALLOC_INHIBIT_VALLOC): Don't define.
663 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
664
22e983b7
JB
6652012-07-14 Juanma Barranquero <lekktu@gmail.com>
666
667 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
668
5b3f250f
GM
6692012-07-14 Glenn Morris <rgm@gnu.org>
670
671 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
672 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
673 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
674
33d63ff4
GM
6752012-07-13 Glenn Morris <rgm@gnu.org>
676
5b633342
GM
677 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
678
33d63ff4
GM
679 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
680 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
681
b55b9f85
JD
6822012-07-13 Jan Djärv <jan.h.d@swipnet.se>
683
0dc8cf50
JD
684 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
685 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
686 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
687 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
688 where appropriate.
689 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
690 as boolean expression.
691 (x_set_window_size): Remove unused variable toolbar.
692 (ns_get_color_default, ns_mod_to_lisp): Remove.
693 (ns_mouse_position): Remove unused variables xchar and ychar.
694 (ns_compute_glyph_string_overhangs): Remove unused variable face.
695 (ns_set_vertical_scroll_bar): Remove unused variable count.
696 (ns_delete_terminal): Remove unused variable i.
697 (ns_term_init): Remove unused variables r, g and b.
698 (mouseDown): Remove unused variable window.
699 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
700 (initFrameFromEmacs): Remove unused variable vbextra.
701 (mouseEntered): Remove unused variables p and dpyinfo.
702 (mouseExited): Remove unused variables p and r.
703 (ns_define_frame_cursor, ns_clear_frame_area)
704 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
705 (menuDown): Assign [sender tag] to variable and cast the variable.
706
707 * nsterm.h (menuDown): Add id as type to argument sender.
708 (ns_display_info_for_name): Add Lisp_Object argument.
709 (ns_term_init): Add Lisp_Object argument.
710 (ns_map_event_to_object): Add void argument.
711 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
712 prototype with arguments and only declare if __OBJC__.
713 (nxatoms_of_nsselect): Add void argument.
714 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
715 (ns_alloc_autorelease_pool): Add void argument.
716 (ns_release_autorelease_pool): Add void* argument.
717 (ns_get_defaults_value): Add const char* argument.
718
719 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
720 (initFromContents): Use SSDATA where appropriate.
721 (ns_update_menubar): Add braces to ambigous if-else.
722 (initWithTitle): Put () around assignment in if statement.
723 (ns_menu_show): Remove unused variables window and keymap.
724 (update_frame_tool_bar): Remove unused variable selected_p.
725 (initWithContentRect): Remove unused variable this_cmd_name.
726
727 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
728 appropriate.
729 (setXBMColor): Remove unused variable len.
730 (setPixmapData): Put () around assignment in loop statement.
731
732 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
733 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
734 where appropriate.
735 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
736 around assignment in loop statement.
737 (nsfont_open): Remove unused variable i.
738 (nsfont_open): Remove unused variable len.
739 (nsfont_draw): Remove unused variable cs.
740
741 * nsfns.m (x_set_icon_name, ns_set_name_internal)
742 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
743 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
744 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
745 (Fns_font_name, Fns_perform_service)
746 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
747 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
748 (ns_set_name): Remove unused variable view.
749 (x_set_menu_bar_lines): Remove unused variable olines.
750 (x_set_tool_bar_lines): Remove unused variable root_window.
751 (Fns_list_colors): Put () around assignment in while statement.
752 (Fns_perform_service): Remove unused variable len.
753 (Fns_display_usable_bounds): Remove unused variable top.
754 (syms_of_nsfns): Remove unused variable i.
755
b55b9f85
JD
756 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
757 memcpy (Bug#11907).
758
ed9265fc 7592012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
760
761 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
762 and free it with DestroyExceptionInfo (Bug#11558).
763
ef099b57
JB
7642012-07-13 Juanma Barranquero <lekktu@gmail.com>
765
766 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
767 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
768 Set here, not in nt/config.nt.
769
ea814a5d
EZ
7702012-07-13 Eli Zaretskii <eliz@gnu.org>
771
772 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
773 cursor overflow into the last glyph on display line when the right
774 fringe is off. (Bug#11832)
775
1a952767
PE
7762012-07-13 Paul Eggert <eggert@cs.ucla.edu>
777
778 * xdisp.c (produce_special_glyphs): Now static.
779 * dispextern.h (produce_special_glyphs): Remove decl.
780
983188fd
GM
7812012-07-13 Glenn Morris <rgm@gnu.org>
782
32fb4bb6
GM
783 * s/bsd-common, s/cygwin.h: Remove empty files.
784 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
785
983188fd
GM
786 * s/usg5-4-common.h (USG, USG5):
787 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
788 * s/sol2-6.h (SOLARIS2):
789 * s/irix6-5.h (IRIX6_5):
790 * s/hpux10-20.h (USG, USG5, HPUX):
791 * s/gnu-linux.h (USG, GNU_LINUX):
792 * s/freebsd.h (BSD_SYSTEM):
793 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
794 * s/cygwin.h (CYGWIN):
795 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
796 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
797
d1e68667 7982012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
799
800 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 801
6de0e799
GM
8022012-07-13 Glenn Morris <rgm@gnu.org>
803
739ae010
GM
804 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
805
dbee5793
GM
806 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
807
6de0e799
GM
808 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
809 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
810
b82da769
GM
8112012-07-12 Glenn Morris <rgm@gnu.org>
812
4fae5a7a 813 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
814
815 * process.c (init_process_emacs): Rename from init_process.
816 The old name is also the name of a Mach system call.
817 * lisp.h, emacs.c: Update for this name change.
818 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
819 longer needed.
820
5a979817
EZ
8212012-07-12 Eli Zaretskii <eliz@gnu.org>
822
823 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
824 memmove call that removes glyphs covered by the left truncation
825 glyph. Improve commentary.
826 (display_line): Fix display of continuation glyphs on GUI frames
827 when the right fringe is turned off and variable-size fonts are
828 used in the window. Move the code that appends a stretch glyph to
829 produce_special_glyphs, so that it could be used for truncation
830 and continuation glyphs alike.
831 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
832 glyph of a suitably computed width, to align the special glyphs at
833 the window margin. Code moved from display_line. (Bug#11832)
834
3e91a053
GM
8352012-07-12 Glenn Morris <rgm@gnu.org>
836
ba9e4b84
GM
837 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
838
839 * s/gnu-linux.h, s/hpux10-20.h:
840 Do not unconditionally define HAVE_XRMSETDATABASE.
841
3e91a053
GM
842 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
843
b300b1f4
PE
8442012-07-12 Paul Eggert <eggert@cs.ucla.edu>
845
846 Fix typos that broke OS X build.
847 Reported by Randal L. Schwartz in
848 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
849 * nsterm.m (ns_timeout): Add missing local decl.
850 (ns_get_color): snprintf -> sprintf, to fix typo.
851
6e777848
GM
8522012-07-12 Glenn Morris <rgm@gnu.org>
853
3f922c37
GM
854 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
855 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
856 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
857 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
858
0ab7b23a
GM
859 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
860 Move PTY_OPEN to configure.
861
6e777848
GM
862 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
863 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
864 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
865
4a7edc24
DA
8662012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
867
868 Use empty_unibyte_string where applicable.
869 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
870 * lread.c (read1): Likewise.
871 * xsettings.c (syms_of_xsettings): Likewise.
872
308aab79
GM
8732012-07-12 Glenn Morris <rgm@gnu.org>
874
42bd1719
GM
875 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
876 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
877 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
878 * s/hpux10-20.h (RUN_TIME_REMAP):
879 * s/bsd-common.h (TABDLY): Move to configure.
880
881 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
882
883 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
884
ea0bbd17 885 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 886 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
887
888 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 889
308aab79
GM
890 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
891 * s/template.h: Move NARROWPROTO to configure.
892
ee1cf5cf
GM
8932012-07-11 Glenn Morris <rgm@gnu.org>
894
30fe9bf4
GM
895 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
896 unused since 2011-01-17 change to systty.h.
897
ee1cf5cf
GM
898 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
899 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
900 Move HAVE_PTYS and HAVE_SOCKETS to configure.
901
63e47e07
PE
9022012-07-11 Paul Eggert <eggert@cs.ucla.edu>
903
904 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
905
c43fb4c3
GM
9062012-07-11 Glenn Morris <rgm@gnu.org>
907
908 * s/darwin.h, s/gnu-linux.h, s/template.h:
909 Move INTERRUPT_INPUT to configure.
910
e8df9267
DA
9112012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
912
913 Minor adjustments to interning code.
914 * lisp.h (intern, intern_c_string): Redefine as static inline
915 wrappers for intern_1 and intern_c_string_1, respectively.
916 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
917 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
918 Vobarray checking.
e8df9267
DA
919 * font.c (font_intern_prop): Likewise. Adjust comment.
920 * w32font.c (intern_font_name): Likewise.
921
34348bd4
AS
9222012-07-11 Andreas Schwab <schwab@linux-m68k.org>
923
d96a1e0c
AS
924 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
925
34348bd4
AS
926 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
927 of Fcar/Fcdr if possible.
928 * font.c (check_otf_features): Likewise.
929 * fontset.c (Fnew_fontset): Likewise.
930 * gnutls.c (Fgnutls_boot): Likewise.
931 * minibuf.c (read_minibuf): Likewise.
932 * msdos.c (IT_set_frame_parameters): Likewise.
933 * xmenu.c (Fx_popup_dialog): Likewise.
934 * w32menu.c (Fx_popup_dialog): Likewise.
935
c8add24e
GM
9362012-07-11 Glenn Morris <rgm@gnu.org>
937
4b575b3c
GM
938 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
939 since nothing has defined it on these platforms.
940
09f4e3b0
GM
941 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
942 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
943
172bedef
GM
944 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
945 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
946 Move CLASH_DETECTION to configure.
947
249685df
GM
948 * s/gnu.h: Remove file, which is now empty.
949
c8add24e
GM
950 * s/gnu.h, s/gnu-linux.h:
951 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
952
b41253a3
JW
9532012-07-11 John Wiegley <johnw@newartisans.com>
954
955 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
956 function attribute, so we only use it if it exists in the
957 compiler.
958
d923b542
DA
9592012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
960
961 Avoid call to strlen in fast_c_string_match_ignore_case.
962 * search.c (fast_c_string_match_ignore_case): Change to use
963 length argument. Adjust users accordingly.
964 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
965
5ebbef1d
PE
9662012-07-11 Paul Eggert <eggert@cs.ucla.edu>
967
bb352260
PE
968 Assume mkdir, rmdir.
969 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
970 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
971
57054ddd
PE
972 Assume rename.
973 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
974
b747d3f7
PE
975 Assume perror.
976 * s/hpux10-20.h (HAVE_PERROR): Remove.
977 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
978 Remove dummy definition, as this problem was obsolete long ago.
979
5ebbef1d
PE
980 Assume strerror.
981 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
982
984e7f30
DA
9832012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
984
985 Avoid calls to strlen in font processing functions.
986 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 987 (font_open_by_name): Change to use length argument. Adjust
984e7f30 988 users accordingly.
d923b542
DA
989 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
990 Adjust prototypes.
991 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
992 Change to return ptrdiff_t.
984e7f30
DA
993 (xfont_list_pattern, xfont_match): Use length returned by
994 xfont_decode_coding_xlfd.
995 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
996
20e94fdd
GM
9972012-07-11 Glenn Morris <rgm@gnu.org>
998
9d596af3
GM
999 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1000 Move DONT_REOPEN_PTY to configure.
1001
20e94fdd
GM
1002 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1003 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1004
e99a530f
PE
10052012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1006
22ffb973
PE
1007 Remove "#define unix" that is no longer needed (Bug#11905).
1008 * s/aix4-2.h (unix): Remove; no longer needed.
1009
e9a9ae03
PE
1010 EMACS_TIME simplification (Bug#11875).
1011 This replaces macros (which typically do not work in GDB)
1012 with functions, typedefs and enums, making the code easier to debug.
1013 The functional style also makes code easier to read and maintain.
1014 * systime.h: Include <sys/time.h> on all hosts, not just if
1015 WINDOWSNT, since 'struct timeval' is needed in general.
1016 (EMACS_TIME): Now a typedef, not a macro.
1017 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1018 not macros.
1019 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1020 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1021 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1022 (EMACS_TIME_LE): Now functions, not macros.
1023 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1024 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1025 which are not functions. All uses rewritten to use:
1026 (make_emacs_time): New function.
1027 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1028 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1029 not functions. All uses rewritten to use the following, respectively:
1030 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1031 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1032 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1033 * fileio.c (Fcopy_file):
1034 * xterm.c (XTflash): Get the current time closer to when it's used.
1035 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1036
ffacb126
PE
1037 * bytecode.c (targets): Suppress -Woverride-init warnings.
1038
e99a530f
PE
1039 Simplify by avoiding confusing use of strncpy etc.
1040 * doc.c (Fsnarf_documentation):
1041 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1042 * frame.c (Fmake_terminal_frame):
1043 * gtkutil.c (get_utf8_string):
1044 * lread.c (openp):
1045 * nsmenu.m (ns_update_menubar):
1046 * regex.c (regerror):
1047 Prefer memcpy to strncpy and strncat when either will do.
1048 * fileio.c (Fsubstitute_in_file_name):
1049 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1050 (menu_separator_name_p):
1051 * nsmenu.m (ns_update_menubar):
1052 Prefer memcmp to strncmp when either will do.
1053 * nsterm.m: Include <ftoastr.h>.
1054 (ns_get_color):
1055 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1056 Prefer snprintf to strncpy.
1057 * nsterm.m (ns_term_init):
1058 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1059 * nsterm.m (ns_term_init):
1060 Avoid the need for strncpy, by using build_string or
1061 make_unibyte_string directly. Use dtoastr, not snprintf.
1062 * process.c (Fmake_network_process): Diagnose service names that
1063 are too long, rather than silently truncating them or creating
1064 non-null-terminated names.
1065 (Fnetwork_interface_info): Likewise, for interface names.
1066 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1067 Prefer sprintf to strncat.
1068 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1069 Prefer vsnprintf to vsprintf + strncpy.
1070
c59592b3
GM
10712012-07-10 Glenn Morris <rgm@gnu.org>
1072
1073 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1074 Clarify fallback case.
1075
7d7bbefd
DA
10762012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1079 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1080 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1081 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1082 where argument type is known to be a Lisp_Cons.
1083
3a4c8000
TT
10842012-07-10 Tom Tromey <tromey@redhat.com>
1085
1086 * bytecode.c (BYTE_CODE_THREADED): New macro.
1087 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1088 (enum byte_code_op): New type.
1089 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1090 (exec_byte_code): Use them. Use token threading when applicable.
1091
2a0213a6
DA
10922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1093
1094 Optimize pure C strings initialization.
1095 * lisp.h (make_pure_string): Fix prototype.
1096 (build_pure_c_string): New function, defined as static inline. This
1097 provides a better opportunity to optimize away calls to strlen when
1098 the function is called with compile-time constant argument.
1099 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1100 argument, adjust users accordingly. Use build_pure_c_string where
1101 appropriate.
1102 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1103 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1104 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1105
cb1caeaf
DA
11062012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1107
1108 Avoid calls to strlen in miscellaneous functions.
1109 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1110 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1111 * lread.c (openp): Likewise.
1112
c293e30c
DA
11132012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 Avoid calls to strlen in path processing functions.
1116 * fileio.c (file_name_as_directory): Add comment. Change to add
1117 srclen argument and return the length of result. Adjust users
1118 accordingly.
1119 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1120 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1121 users accordingly.
1122 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1123
9e059e3f
GM
11242012-07-10 Glenn Morris <rgm@gnu.org>
1125
d02eb359
GM
1126 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1127 Move PENDING_OUTPUT_COUNT definition to configure.
1128
882cf227
GM
1129 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1130 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1131 * s/gnu.h (DATA_START): Move definitions to configure.
1132
af6e839f
GM
1133 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1134 We include usg5-4-common.h, which defines them both.
1135
40289a12
GM
1136 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1137 O_RDONLY already includes it).
1138
9e059e3f
GM
1139 Stop ns builds setting the EMACSLOADPATH environment variable.
1140 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1141 Now it does not set EMACSLOADPATH, just returns the load-path string.
1142 * nsterm.h: Update accordingly.
1143 * lread.c [HAVE_NS]: Include nsterm.h.
1144 (init_lread) [HAVE_NS]: Use ns_load_path.
1145 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1146
7c4e8ec0
GM
11472012-07-09 Glenn Morris <rgm@gnu.org>
1148
d4f600ff
GM
1149 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1150 since the included bsd-common.h does so.
1151
cbb31951
GM
1152 Stop ns builds setting the EMACSPATH environment variable.
1153 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1154 (ns_init_paths): Do not set EMACSPATH.
1155 * nsterm.h (ns_exec_path): Add it.
1156 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1157 Use ns_exec_path.
1158
7c4e8ec0
GM
1159 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1160
26bccfae
PE
11612012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1162
a0bee46f
PE
1163 * process.c (wait_reading_process_output): 'waitchannels' was unset
1164 when read_kbd || !NILP (wait_for_cell); fix this.
1165
5994c183
PE
1166 Add GCC-style 'const' attribute to functions that can use it.
1167 * character.h (char_resolve_modifier_mask):
1168 * keyboard.h (make_ctrl_char):
1169 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1170 (init_character_once, next_almost_prime, init_fns, init_image)
1171 (flush_pending_output, init_sound):
1172 * mem-limits.h (start_of_data):
1173 * menu.h (finish_menu_items):
1174 Add ATTRIBUTE_CONST.
1175 * emacs.c (DEFINE_DUMMY_FUNCTION):
1176 Declare the dummy function with ATTRIBUTE_CONST.
1177 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1178 Add decls with ATTRIBUTE_CONST.
1179
26bccfae
PE
1180 Minor improvements to make_formatted_string.
1181 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1182 where int is good enough, as vsprintf returns an int.
1183 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1184
a8290ec3
DA
11852012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1186
1187 Use make_formatted_string to avoid double length calculation.
1188 * lisp.h (make_formatted_string): New prototype.
1189 * alloc.c (make_formatted_string): New function.
1190 * buffer.c (Fgenerate_new_buffer_name): Use it.
1191 * dbus.c (syms_of_dbusbind): Likewise.
1192 * editfns.c (Fcurrent_time_zone): Likewise.
1193 * filelock.c (get_boot_time): Likewise.
1194 * frame.c (make_terminal_frame, set_term_frame_name)
1195 (x_report_frame_params): Likewise.
1196 * image.c (gs_load): Likewise.
1197 * minibuf.c (get_minibuffer): Likewise.
1198 * msdos.c (dos_set_window_size): Likewise.
1199 * process.c (make_process): Likewise.
1200 * xdisp.c (ensure_echo_area_buffers): Likewise.
1201 * xsettings.c (apply_xft_settings): Likewise.
1202
d01ba2f1
GM
12032012-07-09 Glenn Morris <rgm@gnu.org>
1204
1205 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1206 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1207 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1208 * nsterm.h (ns_etc_directory): Add it.
1209 * callproc.c [HAVE_NS]: Include nsterm.h.
1210 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1211
f1f924b6
DA
12122012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 Move marker debugging code under MARKER_DEBUG.
1215 * marker.c (MARKER_DEBUG): Move marker debugging code under
1216 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1217 for bootstrap with --enable-checking (~3x slowdown reported
1218 by Juanma Barranquero <lekktu@gmail.com>).
1219 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1220
ab531b66
PE
12212012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1224 See <http://bugs.gnu.org/11825#29>.
1225
c4b3bc8a
EZ
12262012-07-08 Eli Zaretskii <eliz@gnu.org>
1227
1228 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1229 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1230 (display_line): Add commentary about displaying truncation glyphs
1231 on GUI frames.
1232 (produce_special_glyphs): Move here from term.c.
1233
1234 * term.c (produce_special_glyphs): Move to xdisp.c.
1235
1236 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1237 section.
c4b3bc8a 1238
b676b881
AS
12392012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1240
f17c5273
AS
1241 * xdisp.c (display_line): Avoid warning about implicit declaration
1242 of FRAME_FONT.
1243
298819b9
AS
1244 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1245
b676b881
AS
1246 * lisp.h: Remove empty conditional.
1247
6045c4fd
PE
12482012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1249
b3350bf9
PE
1250 * lread.c (load_path_check): Now static.
1251
6045c4fd
PE
1252 Fix some minor --with-ns problems found by static checking.
1253 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1254 (x_set_font) [!HAVE_X_WINDOWS]:
1255 * image.c (xpm_load_image) [HAVE_NS]:
1256 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1257 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1258 Remove unused local.
1259 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1260 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1261 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1262 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1263 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1264 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1265 Fix pointer signedness problem.
1266 * xfaces.c (FRAME_X_FONT_TABLE):
1267 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1268
929e7845
GM
12692012-07-07 Glenn Morris <rgm@gnu.org>
1270
1271 * lread.c (load_path_check): New function, split from init_lread.
1272 (init_lread): Reorganize. Motivation:
1273 If EMACSLOADPATH is set, check/warn about that rather than the
1274 defaults, which we are not going to use. Hence we can remove
1275 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1276 Don't warn if site-lisp directories are missing.
1277 If not installed, start from a blank load-path, since
1278 PATH_LOADSEARCH refers to the eventual installation directories.
1279
58dd0aa4
EZ
12802012-07-07 Eli Zaretskii <eliz@gnu.org>
1281
1282 Support truncation and continuation glyphs on GUI frames, when
1283 fringes are disabled. (Bug#11832)
1284 * xdisp.c (init_iterator): Get dimensions of truncation and
1285 continuation glyphs even if on GUI frames. Adjust
1286 it->last_visible_x on GUI frames when the left or right fringes,
1287 or both, are absent.
1288 (start_display, move_it_in_display_line_to): Handle the case of a
1289 GUI frame without a fringe to display continuation or truncation
1290 glyphs.
1291 (insert_left_trunc_glyphs): Support GUI frames: make sure
1292 truncation glyphs overwrite enough glyphs from the current line to
1293 have sufficient space in pixels.
1294 (display_line): Support truncation and continuation glyphs on GUI
1295 frames. If some spare pixels are left on the line after inserting
1296 the truncation glyphs, fill that space with a stretch glyph of a
1297 suitably computed width.
1298
1299 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1300 produce_glyphs, to support GUI sessions.
1301
31571fd7
PE
13022012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1303
5a16b9bc
PE
1304 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1305
f3047c75
PE
1306 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1307
31571fd7
PE
1308 Do not require float-time's arg to fit in time_t (Bug#11825).
1309 This works better on hosts where time_t is unsigned, and where
1310 float-time is applied to the (negative) difference between two times.
1311 * editfns.c (decode_time_components): Last arg is now double *,
1312 not int *, and means to store all the result as a double, without
1313 worrying about whether the seconds part fits in time_t.
1314 All callers changed.
1315 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1316 All callers changed.
1317 (Ffloat_time): Do not fail merely because the specified time falls
1318 outside of time_t range.
1319
4516fbef
GM
13202012-07-07 Glenn Morris <rgm@gnu.org>
1321
1322 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1323 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1324 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1325
07adc2c6
JB
13262012-07-07 Juanma Barranquero <lekktu@gmail.com>
1327
1328 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1329 Update dependencies.
1330
1331 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1332
fd573f31
PE
13332012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1334
fee5959d
PE
1335 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1336 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1337 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1338 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1339 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1340 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1341
fd573f31
PE
1342 * xfont.c (compare_font_names): Redo to omit the need for casts.
1343
ddadbc0e
AS
13442012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1345
fca8d6b6
AS
1346 * xfns.c (Fx_change_window_property): Doc fix.
1347 * w32fns.c (Fx_change_window_property): Doc fix.
1348
ddadbc0e
AS
1349 * w32fns.c (Fx_window_property): Accept the same arguments as the
1350 X Windows version. Doc fix.
1351 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1352
ed9265fc 13532012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1354 Eli Zaretskii <eliz@gnu.org>
1355
1356 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1357 Windows-specific code from nt/config.nt moved here.
1358 Obsolete settings removed.
1359
216ee680
PE
13602012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 * process.c: Avoid unnecessary calls to gettime.
1363 (wait_reading_process_output): Don't get the time of day
1364 when gobbling data immediately and not waiting, as there's no need
1365 for it in that case. This removes a FIXME.
1366
bdd091e4
JD
13672012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1368
1369 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1370 is defined (Bug#11768).
1371
9d44f8ce
DA
13722012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 Fix marker debugging code.
1375 * marker.c (byte_char_debug_check): Do not perform the check
1376 if buffer is not multibyte.
090bd7cb
JB
1377 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1378 Call byte_char_debug_check with correct arguments.
9d44f8ce 1379
90fc4786
DA
13802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1381
1382 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1383 * marker.c (byte_char_debug_check, count_markers):
1384 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1385 (byte_debug_flag): Remove.
1386 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1387 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1388
7b7ae965
DA
13892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1390
4e57b342
DA
1391 Avoid code repetition in marker-related functions.
1392 * marker.c (attach_marker): New function.
1393 (Fset_marker, set_marker_restricted, set_marker_both)
1394 (set_marker_restricted_both): Use it.
1395 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1396 Consistently rename charno to charpos.
1397 (marker_position): Add eassert.
1398 (marker_byte_position): Convert to eassert.
1399
14002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1401
1402 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1403 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1404 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1405
657924ff
DA
14062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1407
1408 Introduce fast path for the widely used marker operation.
1409 * alloc.c (build_marker): New function.
1410 * lisp.h (build_marker): New prototype.
1411 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1412 * composite.c (autocmp_chars): Likewise.
1413 * editfns.c (buildmark): Remove.
1414 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1415 (save_restriction_save): Use build_marker.
1416 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1417 * window.c (save_window_save): Likewise.
1418
041a49a6
DA
14192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1420
1421 Do not use Fdelete_overlay in delete_all_overlays
1422 to avoid redundant calls to unchain_overlay.
1423 * buffer.c (drop_overlay): New function.
1424 (delete_all_overlays, Fdelete_overlay): Use it.
1425 * minibuf.c (get_minibuffer): Fix comment.
1426
7dca65a4
PE
14272012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1428
1429 Port to OpenBSD 5.1 amd64.
1430 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1431 This is needed for OpenBSD, and should be harmless on all BSD systems.
1432 Also, include <sys/sysctl.h>, as it should be available on all
1433 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1434 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1435 use p_pid member, not kp_proc.pid.
1436
8eb876e2
GM
14372012-07-06 Glenn Morris <rgm@gnu.org>
1438
1439 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1440
38182d90
PE
14412012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1442
1443 More xmalloc and related cleanup.
1444 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1445 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1446 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1447 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1448 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1449 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1450 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1451 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1452 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1453 * xterm.c:
1454 Omit needless casts involving void * pointers and allocation.
1455 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1456 as the former is more robust if P's type is changed.
1457 Prefer xzalloc to xmalloc + memset 0.
1458 Simplify malloc-or-realloc to realloc.
1459 Don't worry about xmalloc returning a null pointer.
1460 Prefer xstrdup to xmalloc + strcpy.
1461 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1462 growing it.
1463 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1464 alloca of a constant.
1465
6dd5a677
EZ
14662012-07-05 Eli Zaretskii <eliz@gnu.org>
1467
1468 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1469 hscroll is larger than the line width. Fixes long and futile
1470 looping inside extend_face_to_end_of_line (on a TTY) producing
1471 glyphs that are not needed and thrown away.
1472
6b312f0f
DA
14732012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1474
1475 * marker.c (set_marker_restricted_both): Simplify by using
1476 clip_to_bounds.
1477
f520ef9b
PE
14782012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1481
383b7c95
JD
14822012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1483
1484 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1485 not defined (Bug#11768).
1486 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1487 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1488 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1489 followed by gtk_box_set_homogeneous (Bug#11768).
1490 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1491 (update_theme_scrollbar_width, xg_create_scroll_bar):
1492 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1493 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1494 (is_box_type): New function (Bug#11768).
1495 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1496 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1497 with default display (Bug#11768).
1498
d6e7bf45
EZ
14992012-07-05 Eli Zaretskii <eliz@gnu.org>
1500
1501 * xdisp.c (window_hscroll_limited): New function.
1502 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1503 coordinates when window's hscroll is set to insanely large
1504 values. (Bug#11857)
1505
431391ec
JB
15062012-07-05 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1509 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1510
23f86fce
DA
15112012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1512
1513 Cleanup xmalloc.
1514 * lisp.h (xzalloc): New prototype. Omit needless casts.
1515 * alloc.c (xzalloc): New function. Omit needless casts.
1516 * charset.c: Omit needless casts. Convert all calls to
1517 xmalloc with following memset to xzalloc.
1518 * dispnew.c: Likewise.
1519 * fringe.c: Likewise.
1520 * image.c: Likewise.
1521 * sound.c: Likewise.
1522 * term.c: Likewise.
1523 * w32fns.c: Likewise.
1524 * w32font.c: Likewise.
1525 * w32term.c: Likewise.
1526 * xfaces.c: Likewise.
1527 * xfns.c: Likewise.
1528 * xterm.c: Likewise.
1529 * atimer.c: Omit needless casts.
1530 * buffer.c: Likewise.
1531 * callproc.c: Likewise.
1532 * ccl.c: Likewise.
1533 * coding.c: Likewise.
1534 * composite.c: Likewise.
1535 * doc.c: Likewise.
1536 * doprnt.c: Likewise.
1537 * editfns.c: Likewise.
1538 * emacs.c: Likewise.
1539 * eval.c: Likewise.
1540 * filelock.c: Likewise.
1541 * fns.c: Likewise.
1542 * gtkutil.c: Likewise.
1543 * keyboard.c: Likewise.
1544 * lisp.h: Likewise.
1545 * lread.c: Likewise.
1546 * minibuf.c: Likewise.
1547 * msdos.c: Likewise.
1548 * print.c: Likewise.
1549 * process.c: Likewise.
1550 * region-cache.c: Likewise.
1551 * search.c: Likewise.
1552 * sysdep.c: Likewise.
1553 * termcap.c: Likewise.
1554 * terminal.c: Likewise.
1555 * tparam.c: Likewise.
1556 * w16select.c: Likewise.
1557 * w32.c: Likewise.
1558 * w32reg.c: Likewise.
1559 * w32select.c: Likewise.
1560 * w32uniscribe.c: Likewise.
1561 * widget.c: Likewise.
1562 * xdisp.c: Likewise.
1563 * xmenu.c: Likewise.
1564 * xrdb.c: Likewise.
1565 * xselect.c: Likewise.
1566
0497dc44
PE
15672012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 * fileio.c (time_error_value): Check the right error number.
1570 Problem reported by Troels Nielsen in
1571 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1572
356e7178
PE
15732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1574
4e71fd89
PE
1575 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1576 This should be fixed in a better way; see Eli Zaretskii in
1577 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1578 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1579
f0941253
PE
1580 * fileio.c (time_error_value): Rename from special_mtime.
1581 The old name's problems were noted by Eli Zaretskii in
1582 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1583
065c9eb4
PE
1584 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1585 This variable's comment says Emacs needs at least one GDB-visible
1586 symbol of type enum pvec_type, to work around GDB problems.
1587 The symbol's value doesn't matter.
1588
356e7178
PE
1589 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1590 that causes compilation to fail on pre-C99 compilers.
1591
ed9265fc 15922012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1593
1594 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1595 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1596
3884d954
DA
15972012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1598
d209e2fb 1599 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1600 headers for buffer_defaults and buffer_local_symbols.
1601 Reported by Juanma Barranquero <lekktu@gmail.com>.
1602
ee28be33
SM
16032012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1604
1605 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1606 * lisp.h (enum pvec_type): Use fewer bits.
1607 (PSEUDOVECTOR_SIZE_BITS): New constant.
1608 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1609 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1610 change in pvec_type.
1611 (PSEUDOVECTOR_TYPEP): New macro.
1612 (TYPED_PSEUDOVECTORP): Use it.
1613 * fns.c (internal_equal): Adapt code to extract pvectype.
1614 * emacs.c (gdb_pvec_type): Update type.
1615 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1616 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1617 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1618 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1619 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1620 abusing vector->header.next.nbytes.
1621 (live_vector_p): Use PVEC_TYPE.
1622 (mark_object): Adapt code to extract pvectype. Use switch.
1623
c7f2cd7f
PE
16242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1627 Tighten new eassert a bit.
1628
8ce70ed2
DA
16292012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1630
1631 Fix compilation with --enable-gcc-warnings and -O1
1632 optimization level.
1633 * doprnt.c (doprnt): Change type of tem to int, initialize
1634 to avoid compiler warning. Add eassert.
1635 * search.c (simple_search): Initialize match_byte to avoid
1636 compiler warning. Add eassert.
1637
dea7f1e5
PE
16382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1639
24a212eb
PE
1640 Avoid weird behavior with large horizontal scrolls.
1641 Without this change, for example, large hscroll values would
1642 mess up Emacs's display on Fedora 15 x86, presumably due to
1643 overflows in int calculations in the display code.
1644 Also, if buffers had long lines, Emacs would freeze.
1645 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1646 (set_window_hscroll): New function, containing the old guts of
1647 Fset_window_hscroll. Return the clipped value.
1648 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1649 This avoids the need to check against PTRDIFF_MAX.
1650
dea7f1e5
PE
1651 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1652
76046526
DA
16532012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1654
1655 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1656
39adff0d
PE
16572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1658
63807d47
PE
1659 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1660 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1661 since GCC 4.4.6 issues a bogus warning for them.
1662
39adff0d
PE
1663 Fix bugs in file timestamp newness comparisons.
1664 * fileio.c (Ffile_newer_than_file_p):
1665 * lread.c (Fload): Use full timestamp resolution of files,
1666 not just the 1-second resolution, so that files that are only
1667 slightly newer still count as newer.
1668 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1669 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1670
dbeed9a6
PE
16712012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 * fileio.c: Improve handling of file time marker. (Bug#11852)
1674 (special_mtime): New function.
1675 (Finsert_file_contents, Fverify_visited_file_modtime):
1676 Use it to set special mtime values consistently.
1677
636334d6
AS
16782012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1679
1680 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1681 marker for non-existing file. (Bug#11852)
1682
e2017fe2
GM
16832012-07-03 Glenn Morris <rgm@gnu.org>
1684
1685 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1686 and did not make it into globals.h).
1687
404dbd37
TT
16882012-07-03 Tom Tromey <tromey@redhat.com>
1689
1690 * window.c (Fset_window_margins, Fset_window_fringes)
1691 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1692 * textprop.c (Fprevious_property_change): No longer static.
1693 * syntax.c (Fsyntax_table_p): No longer static.
1694 * process.c (Fget_process, Fprocess_datagram_address): No longer
1695 static.
1696 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1697 * keyboard.c (Fcommand_execute): No longer static.
1698 Remove EXFUN.
1699 * insdel.c (Fcombine_after_change_execute): No longer static.
1700 * image.c (Finit_image_library): No longer static.
1701 * fileio.c (Fmake_symbolic_link): No longer static.
1702 * eval.c (Ffetch_bytecode): No longer static.
1703 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1704 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1705 No longer static.
404dbd37
TT
1706 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1707 static.
1708 * dired.c (Ffile_attributes): No longer static.
1709 * composite.c (Fcomposition_get_gstring): No longer static.
1710 * callproc.c (Fgetenv_internal): No longer static.
1711
1712 * ccl.h: Remove EXFUNs.
1713 * buffer.h: Remove EXFUNs.
1714 * dispextern.h: Remove EXFUNs.
1715 * intervals.h: Remove EXFUNs.
1716 * fontset.h: Remove EXFUN.
1717 * font.h: Remove EXFUNs.
1718 * dosfns.c (system_process_attributes): Remove EXFUN.
1719 * keymap.h: Remove EXFUNs.
1720 * lisp.h: Remove EXFUNs.
1721 * w32term.h: Remove EXFUNs.
1722 * window.h: Remove EXFUNs.
1723 * xsettings.h: Remove EXFUN.
1724 * xterm.h: Remove EXFUN.
1725
8e4fd1e1
GM
17262012-07-03 Glenn Morris <rgm@gnu.org>
1727
1728 * lisp.h (Frandom): Make it visible to C.
1729 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1730 buffer for invisible buffers. (Bug#1229)
1731
ca95b3eb
DA
17322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1733
1734 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1735 values which aren't power of 2.
1736 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1737 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1738 accordingly.
1739
7555c33f
SM
17402012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1741
1742 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1743
1744 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1745
d12e8f5a
DA
17462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1747
1748 * alloc.c (allocate_vector_block): Remove redundant
1749 calls to mallopt if DOUG_LEA_MALLOC is defined.
1750 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1751 avoid calls to mallopt if zero_vector is returned.
1752
296094c3
DA
17532012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1754
1755 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1756 is enabled, avoid dereferencing NULL current_sblock if
1757 running undumped.
1758
36429c89
DA
17592012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1760
1761 Cleanup basic buffer management.
1762 * buffer.h (struct buffer): Change layout to use generic vector
1763 marking code. Fix some comments. Change type of 'clip_changed'
1764 to bitfield. Remove unused #ifndef old.
1765 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1766 (GET_OVERLAYS_AT): Fix indentation.
1767 (for_each_per_buffer_object_at): New macro.
1768 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1769 (Fbuffer_local_variables): Use it.
1770 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1771 * alloc.c (allocate_buffer): Adjust to match new layout of
1772 struct buffer. Fix comment.
1773 (mark_overlay): New function.
1774 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1775 Lisp area of struct buffer.
1776 (mark_object): Use it. Adjust marking of misc objects
1777 and related comments.
1778
3b3e4cac
PE
17792012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1782 wrapper that is not needed because the wrapped code is a no-op (zero
1783 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1784 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1785
cf5c0175
DA
17862012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1787
1788 * alloc.c (mark_buffer): Simplify. Remove prototype.
1789 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1790 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1791 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1792 redundant calls to mark_vectorlike for bool vectors.
1793
ca26824c
GM
17942012-06-30 Glenn Morris <rgm@gnu.org>
1795
2e4c5312
GM
1796 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1797
ca26824c
GM
1798 * epaths.in (PATH_SITELOADSEARCH): New.
1799 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1800 This is rather than relying on --enable-locallisppath elements
1801 having "site-lisp" in their names. (Bug#10208#25, 11658)
1802
0d23c240
EZ
18032012-06-30 Eli Zaretskii <eliz@gnu.org>
1804
c9240d7a
EZ
1805 * w32proc.c (sys_select): Accept and ignore one more argument.
1806
1807 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1808
0d23c240 1809 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1810 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1811
1812 * sysdep.c: Don't include dos.h and dosfns.h.
1813
1814 * process.c (sys_select):
1815 * msdos.c (sys_select): Accept one more argument and ignore it.
1816
1817 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1818 adapt data types and code to that.
1819
1820 * dosfns.c:
1821 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1822 which clashes with the gnulib function of the same name.
1823
af5a5a98
AS
18242012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1825
c5e4379c
AS
1826 * font.c (font_style_to_value, font_style_symbolic)
1827 (font_prop_validate_style): Add type checks for values in
1828 font_style_table.
1829
af5a5a98
AS
1830 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1831 argument.
1832 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1833 uses.
1834
8d38f461
EZ
18352012-06-29 Eli Zaretskii <eliz@gnu.org>
1836
2e5a6631
EZ
1837 * xdisp.c (try_window_id): Undo last change.
1838
8d38f461
EZ
1839 * w32.c (getwd): Adjust commentary about startup_dir.
1840 (init_environment): Always call sys_access, even in non-MSVC
1841 builds. Don't chdir to the directory of the Emacs executable.
1842 This undoes code from 1997 which was justified by the need to
1843 "avoid conflicts when removing and renaming directories". But its
1844 downside was that every relative file name was being interpreted
1845 relative to the directory of the Emacs executable, which can never
1846 be TRT. In particular, it broke sys_access when called with
1847 relative file names.
1848 (sys_access): Map GetLastError to errno.
1849
2af3565e
DA
18502012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1851
1852 * window.h (struct window): Change type of 'fringes_outside_margins'
1853 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1854 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1855 Adjust comment.
1856 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1857 to ptrdiff_t.
1858
c8d3a25c 18592012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1860
c8d3a25c
GM
1861 * gnutls.c (emacs_gnutls_handshake):
1862 Add QUIT to make the loop interruptible.
57570cd3 1863
c8d3a25c 18642012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1865
c8d3a25c
GM
1866 * charset.c (init_charset): Make lack of etc/charsets fatal.
1867
3e984ee8
DA
18682012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1869
1870 * editfns.c (region_limit): Fix type mismatch.
1871
ef884f23
DA
18722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1873
1874 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1875 undefined. Convert from xassert to eassert.
1876 * nsmenu.m: Convert from xassert to eassert.
1877 * nsterm.m: Likewise.
1878
7d7e0027
SM
18792012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1880
1881 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1882
aa754e6a
PE
18832012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 Avoid integer overflow on scroll-left and scroll-right.
1886 * window.c (HSCROLL_MAX): New macro.
1887 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1888 overflow when requested scroll falls outside ptrdiff_t range.
1889
80b00b08
DA
18902012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1891
1892 * window.h (struct window): Change type of 'hscroll',
1893 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1894 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1895 Adjust users accordingly.
1896 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1897 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1898 from EMACS_INT to ptrdiff_t.
1899 (make_window): Omit redundant initialization.
1900
62b2bcf6
JB
19012012-06-28 Juanma Barranquero <lekktu@gmail.com>
1902
1903 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1904
45942c7d
DA
19052012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1906
1907 * window.h (struct window): Change type of 'use_time' and
1908 'sequence_number' from Lisp_Object to int.
1909 * frame.c (make_frame): Adjust users accordingly.
1910 * print.c (print_object): Likewise.
1911 * window.c (select_window, Fwindow_use_time, make_parent_window)
1912 (make_window): Likewise.
1913
e509cfa6
DA
19142012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1915
1916 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1917 enabled with --enable-checking=[all,glyphs] configure option.
1918 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1919 adjust comments accordingly.
1920 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1921 undefined, adjust comments accordingly.
1922 * image.c: Likewise.
1923 * scroll.c: Likewise.
1924 * w32fns.c: Likewise.
1925 * w32term.c: Likewise.
1926 * xdisp.c: Likewise.
1927 * xfaces.c: Likewise.
1928 * xfns.c: Likewise.
1929 * xterm.c: Likewise.
1930
a54e2c05
DA
19312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1932
1933 Generalize run-time debugging checks.
1934 * dispextern.h (XASSERTS): Remove.
1935 * fontset.c (xassert): Remove.
1936 Convert from xassert to eassert.
1937 * alloc.c: Convert from xassert to eassert.
1938 * bidi.c: Likewise.
1939 * dispnew.c: Likewise.
1940 * fns.c: Likewise.
1941 * fringe.c: Likewise.
1942 * ftfont.c: Likewise.
1943 * gtkutil.c: Likewise.
1944 * image.c: Likewise.
1945 * keyboard.c: Likewise.
1946 * menu.c: Likewise.
1947 * process.c: Likewise.
1948 * scroll.c: Likewise.
1949 * sound.c: Likewise.
1950 * term.c: Likewise.
1951 * w32console.c: Likewise.
1952 * w32fns.c: Likewise.
1953 * w32term.c: Likewise.
1954 * window.c: Likewise.
1955 * xdisp.c: Likewise.
1956 * xfaces.c: Likewise.
1957 * xfns.c: Likewise.
1958 * xselect.c: Likewise.
1959 * xterm.c: Likewise.
1960
1ec4b7b2
SM
19612012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1962
1963 * fns.c (maybe_resize_hash_table): Output message when growing the
1964 purify-hashtable.
1965
2014308a
DA
19662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1967
1968 * alloc.c (allocate_string_data): Remove dead code.
1969 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1970 avoid GCC warning about unused macro.
1971
246155eb
DA
19722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1973
1974 * alloc.c (allocate_string): Omit intervals initialization.
1975 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1976 as in make_pure_string and make_pure_c_string.
1977
43184b7b
DA
19782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1979
d209e2fb 1980 * alloc.c (allocate_string): Fix last change.
43184b7b 1981
3fe6dd74
DA
19822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1983
d209e2fb 1984 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1985 to memset, add explicit initialization where appropriate.
1986
1ba6038a
GM
19872012-06-27 Glenn Morris <rgm@gnu.org>
1988
1989 * lisp.mk (lisp): Remove paths.elc.
1990
c89926a5
CY
19912012-06-27 Chong Yidong <cyd@gnu.org>
1992
1993 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1994
ed6b3510
JW
19952012-06-26 John Wiegley <johnw@newartisans.com>
1996
1ec4b7b2 1997 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1998 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1999
ed6b3510
JW
2000 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2001 when building with Clang.
2002
8edd4a2b
SM
20032012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2004
2005 * eval.c (Fapply): Allow calling it with a single argument.
2006
f6f62d1b
EZ
20072012-06-26 Eli Zaretskii <eliz@gnu.org>
2008
2009 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2010 _stricmp and _strnicmp.
2011 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2012
62efea5e
DA
20132012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2014
2015 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2016 allocated window.
2017 (allocate_process): Likewise for new process.
8edd4a2b 2018 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2019 (allocate_frame): Likewise.
2020 * frame.c (make_frame): Omit redundant initialization.
2021 * window.c (make_parent_window): Use memset.
2022 (make_window): Omit redundant initialization.
2023 * process.c (make_process): Omit redundant initialization.
2024 * terminal.c (create_terminal): Likewise.
2025
42997f4d
DA
20262012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2027
2028 * term.c (delete_tty): Remove redundant call to memset.
2029
1130ecfc
DA
20302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2031
2032 * alloc.c: Remove build_string.
2033 * lisp.h: Define build_string as static inline. This provides
2034 a better opportunity to optimize away calls to strlen when the
2035 function is called with compile-time constant argument.
2036 * image.c (imagemagick_error): Convert to build_string.
2037 * w32proc.c (sys_spawnve): Likewise.
2038 * xterm.c (x_term_init): Likewise.
2039
cf38a720
PE
20402012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2041
99027bdd
PE
2042 Use sprintf return value instead of invoking strlen on result.
2043 In the old days this wasn't portable, since some sprintf
2044 implementations returned char *. But they died out years ago and
2045 Emacs already assumes sprintf returns int.
2046 Similarly for float_to_string.
2047 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2048 * ccl.c (ccl_driver):
2049 * character.c (string_escape_byte8):
2050 * data.c (Fnumber_to_string):
2051 * doprnt.c (doprnt):
2052 * print.c (print_object):
2053 * xdisp.c (message_dolog):
2054 * xfns.c (syms_of_xfns):
2055 Use sprintf or float_to_string result to avoid need to call strlen.
2056 * data.c (Fnumber_to_string):
2057 Use make_unibyte_string, since the string must be ASCII.
2058 * lisp.h, print.c (float_to_string): Now returns int length.
2059 * term.c (produce_glyphless_glyph):
2060 Use sprintf result rather than recomputing it.
2061
cf38a720
PE
2062 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2063 * Makefile.in (ALL_CFLAGS):
2064 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2065 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2066
3511c784
DA
20672012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2068
0a08eb21 2069 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2070 strcasecmp if available.
2071 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2072
fb7da12e
AS
20732012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2074
2075 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2076 Avoid comma operator.
2077 * menu.c (push_submenu_start, push_submenu_end)
2078 (push_left_right_boundary, push_menu_pane): Likewise.
2079 * msdos.c (dos_rawgetc): Likewise.
2080
afa2ffd8
DA
20812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2082
2083 * xfns.c (xic_create_fontsetname): Remove redundant calls
2084 to memset.
2085
b3b4476b
PE
20862012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2087
4495ff38
PE
2088 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2089 sprintf already null-terminates its output.
2090
b3b4476b
PE
2091 * xfns.c (x_window): Remove redundant cast.
2092
b00876c9
DA
20932012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2094
2095 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2096 `const char *' to `char *' to avoid compiler warning.
2097
d188e26b
PE
20982012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2099
885d1d74
PE
2100 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2101 instead of truncating it to 63 (admittedly a generous limit).
2102
d188e26b
PE
2103 * process.c: Fix spelling and caps in comments.
2104
e2f560b1
DN
21052012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2106
e86db54b 2107 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2108 * sysdep.c (setpgrp): Remove definition, not used in this file.
2109
7583a3a1
JB
21102012-06-24 Juanma Barranquero <lekktu@gmail.com>
2111
2112 * makefile.w32-in: Update dependencies.
2113
696056c2
EZ
21142012-06-24 Eli Zaretskii <eliz@gnu.org>
2115
2116 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2117 (SYSTIME_H): Add nt/inc/sys/time.h.
2118
2119 * systime.h [WINDOWSNT]: Include sys/time.h.
2120
2121 * s/ms-w32.h (struct timespec): Definition moved from
2122 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2123
845ca893
PE
21242012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2127 * buffer.h (buffer_slot_type_mismatch):
2128 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2129 * eval.c (unwind_to_catch):
2130 * image.c (my_png_error, my_error_exit):
2131 * keyboard.c (quit_throw_to_read_char, user_error)
2132 (Fexit_recursive_edit, Fabort_recursive_edit):
2133 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2134 (wrong_type_argument, buffer_overflow, __executable_start)
2135 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2136 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2137 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2138 (fatal):
2139 (child_setup) [!DOS_NT]:
2140 * lread.c (end_of_file_error, invalid_syntax):
2141 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2142 * puresize.h (pure_write_error):
2143 * search.c (matcher_overflow):
2144 * sound.c (sound_perror, alsa_sound_perror):
2145 * sysdep.c, syssignal.h (croak):
2146 * term.c (maybe_fatal, vfatal):
2147 * textprop.c (text_read_only):
2148 * undo.c (user_error):
2149 * unexmacosx.c (unexec_error):
2150 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2151 Use _Noreturn rather than NO_RETURN.
2152 No need for separate decl merely because of _Noreturn.
2153 * sound.c (sound_warning, parse_sound):
2154 Remove unnecessary forward decls.
2155
f1dd8073
PE
21562012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2159 * lisp.h (WAIT_READING_MAX): New macro.
2160 * dispnew.c (Fsleep_for, sit_for):
2161 * keyboard.c (kbd_buffer_get_event):
2162 * process.c (Faccept_process_output):
2163 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2164 This improves on the previous patch, which introduced a bug
2165 when time_t is unsigned and as wide as intmax_t.
2166 See <http://bugs.gnu.org/9000#51>.
2167
b82c1755
EZ
21682012-06-23 Eli Zaretskii <eliz@gnu.org>
2169
2170 * dispnew.c (sit_for, Fsleep_for):
2171 * keyboard.c (kbd_buffer_get_event):
2172 * process.c (Faccept_process_output): Avoid compiler warnings when
2173 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2174
ca300656
JB
21752012-06-23 Juanma Barranquero <lekktu@gmail.com>
2176
049ec95b
JB
2177 * makefile.w32-in: Update dependencies.
2178
ca300656
JB
2179 * w32.c (ltime): Add return type and declare static.
2180 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2181
db7b8d06
PE
21822012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2183
2184 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2185 Privately reported by Herbert J. Skuhra.
2186 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2187 All uses changed.
2188 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2189 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2190
0bd8297f
EZ
21912012-06-23 Eli Zaretskii <eliz@gnu.org>
2192
96512555
EZ
2193 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2194 last argument of make_unibyte_string.
2195
0bd8297f
EZ
2196 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2197 language ID in the event parameters.
2198
2199 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2200 event.code, not the obscure "character set ID".
2201
63def6b6
CY
22022012-06-23 Chong Yidong <cyd@gnu.org>
2203
2204 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2205
e8a02204
EZ
22062012-06-23 Eli Zaretskii <eliz@gnu.org>
2207
388cdec0
EZ
2208 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2209 * w32.c (fdutimens): New function.
2210
2211 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2212
2213 * s/ms-w32.h (pselect): Redirect to sys_select.
2214
2215 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2216
e8a02204
EZ
2217 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2218 in the logic of incrementing and decrementing the value of
2219 use_relocatable_buffers.
2220
d054f3fb
PE
22212012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2224 Privately reported by Herbert J. Skuhra.
2225 [__FreeBSD__]: Remove "*/" typo after "#include".
2226 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2227 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2228 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2229 Don't assume EMACS_TIME and struct timeval are the same type.
2230
d35af63c
PE
22312012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 Support higher-resolution time stamps (Bug#9000).
2234 The time stamps are only nanosecond-resolution at the C level,
2235 since that's the best that any real-world system supports now.
2236 But they are picosecond-resolution at the Lisp level, as that's
2237 easy, and leaves room for future OS improvements.
2238
2239 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2240 (LIBES): Use it.
2241
2242 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2243 Don't get current time unless it's needed.
2244
2245 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2246 now provides it if it's absent.
2247 (start_atimer): Port to higher-res time stamps.
2248 Check for time stamp overflow. Don't get current time more
2249 often than is needed.
2250
2251 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2252 Include systime.h, not time.h.
2253 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2254
2255 * dired.c: Include stat-time.h.
2256 (Ffile-attributes): File times now have higher resolution.
2257
2258 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2259 (struct image): Timestamp now has higher resolution.
2260
2261 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2262 has at least microseconds now. All uses removed.
2263 (update_frame, update_single_window, update_window, update_frame_1)
2264 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2265
2266 * editfns.c (time_overflow): Now extern.
2267 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2268 (float-time, Fformat_time_string, Fcurrent_time_string)
2269 (Fcurrent_time_zone): Accept and generate higher-resolution
2270 time stamps.
2271 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2272 (decode_time_components, lisp_seconds_argument): New functions.
2273 (make_time): Now static.
2274 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2275 Report an error if the time is invalid, rather than having the caller
2276 do that.
2277
2278 * fileio.c: Include <stat-time.h>
2279 (Fcopy_file): Copy higher-resolution time stamps.
2280 Prefer to set the time stamp via a file descriptor if that works.
2281 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2282 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2283 (Fvisited_file_modtime, Fset_visited_file_modtime):
2284 Support higher-resolution time stamps.
2285
2286 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2287
2288 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2289
2290 * image.c (prepare_image_for_display, clear_image_cache)
2291 (lookup_image): Port to higer-resolution time stamps.
2292
2293 * keyboard.c (start_polling, bind_polling_period):
2294 Check for time stamp overflow.
2295 (read_char, kbd_buffer_get_event, timer_start_idle)
2296 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2297 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2298 Port to higher-resolution time stamps. Do not assume time_t is signed.
2299 (decode_timer): New function. Timers are now vectors of length 9,
2300 not 8, to accommodate the picosecond component.
2301 (timer_check_2): Use it.
2302
2303 * nsterm.m (select_timeout, timeval_subtract): Remove.
2304 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2305 as they're a bit more accurate and handle overflow better.
2306 (ns_select): Change prototype to be compatible with pselect.
2307 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2308 * nsterm.h (ns_select): Adjust prototype.
2309
2310 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2311 us-resolution time stamps.
2312 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2313
2314 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2315
2316 * lisp.h (time_overflow): New decl.
2317 (wait_reading_process_output): First arg is now intmax_t, not int,
2318 to accommodate larger waits.
2319
2320 * process.h (struct Lisp_Process.read_output_delay):
2321 Now counts nanoseconds, not microseconds.
2322 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2323 EMACS_HAS_USECS.
2324 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2325 (wait_reading_process_output):
2326 Port to ns-resolution time stamps.
2327 (Faccept_process_output, wait_reading_process_output):
2328 Check for time stamp overflow. Do not assume time_t is signed.
2329 (select_wrapper): Remove; we now use pselect.
2330 (Fprocess_attributes): Now generates ns-resolution time stamps.
2331
2332 * sysdep.c: Include utimens.h. Don't include utime.h
2333 or worry about struct utimbuf; gnulib does that for us now.
2334 (gettimeofday): Remove; gnulib provides a substitute.
2335 (make_timeval): New function.
2336 (set_file_times): Now sets ns-resolution time stamps.
2337 New arg FD; all uses changed.
2338 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2339 (system_process_attributes):
2340 Now returns ns-resolution time stamp. All uses changed.
2341 Check for time stamp overflow.
2342
2343 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2344 provides a substitute now.
2345
2346 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2347 since it guarantees struct timespec.
2348 (EMACS_TIME): Now struct timespec, so that we can support
2349 ns-resolution time stamps.
2350 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2351 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2352 (EMACS_USECS): Remove.
2353 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2354 so multiply the arg by 1000 before storing it.
2355 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2356 New macros.
2357 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2358 Port to ns-resolution time stamps.
2359 (EMACS_TIME_NEG_P): Remove; replaced by....
2360 (EMACS_TIME_SIGN): New macro.
2361 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2362 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2363 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2364 (make_timeval, make_lisp_time, decode_time_components): New decls.
2365 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2366 that it mishandled time_t overflow. You can't compare by subtracting!
2367 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2368 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2369
2370 * term.c: Include <sys/time.h>.
2371 (timeval_to_Time): New function, for proper overflow wraparound.
2372 (term_mouse_position, term_mouse_click): Use it.
2373
2374 * undo.c (record_first_change): Support higher-resolution time stamps
2375 in the undo buffer.
2376 (Fprimitive_undo): Use them when restoring time stamps.
2377
2378 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2379 (w32_get_internal_run_time):
2380 Port to higher-resolution Emacs time stamps.
2381 (ltime): Now accepts single 64-bit integer, as that's more convenient
2382 for callers.
2383
2384 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2385
2386 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2387 for compatibility with pselect. Support ns-resolution time stamps.
2388
2389 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2390
2391 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2392 Check for time stamp overflow, and support ns-resolution time stamps.
2393
2394 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2395 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2396 (timeval_subtract): Remove; no longer needed.
2397 (XTflash, XTring_bell, x_wait_for_event):
2398 Port to ns-resolution time stamps. Don't assume time_t is signed.
2399
b6a92dfe
CY
24002012-06-22 Chong Yidong <cyd@gnu.org>
2401
2402 * xdisp.c (x_consider_frame_title): Revert last change.
2403
d251c37c
EZ
24042012-06-22 Eli Zaretskii <eliz@gnu.org>
2405
2406 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2407 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2408 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2409 staticidx goes up to 1597 out of 1600 = 0x640.)
2410
f10deafb
PE
24112012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2412
2413 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2414 Otherwise, the umask might be mistakenly 0 while handling input signals.
2415
ec6de1e2
SM
24162012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2417
2418 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2419
28be1ada
DA
24202012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2421
2422 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2423 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2424 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2425 access to `contents' member of Lisp_Vector objects with AREF and ASET
2426 where appropriate.
2427
c6bf3022
CY
24282012-06-19 Chong Yidong <cyd@gnu.org>
2429
2430 * frame.c (delete_frame): When selecting a frame on a different
2431 text terminal, do not alter the terminal's top-frame.
2432
2433 * xdisp.c (format_mode_line_unwind_data): Record the target
2434 frame's selected window and its terminal's top-frame.
2435 (unwind_format_mode_line): Restore them.
2436 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2437 Callers changed.
2438 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2439 since tty frames can be explicitly named.
2440 (prepare_menu_bars): Likewise.
2441
2442 * term.c (Ftty_top_frame): New function.
2443
defd4196
PE
24442012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2445
2446 Port byte-code-meter to modern targets.
2447 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2448 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2449 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2450 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2451 (METER_1, METER_2): Simplify.
2452
1053a871
SM
24532012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2454
2455 * data.c (Fdefalias): Return `symbol' (bug#11686).
2456
b7e8d081
MR
24572012-06-18 Martin Rudalics <rudalics@gmx.at>
2458
2459 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2460 gets killed during executing of this function (Bug#11665).
2461 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2462 (Vkill_buffer_query_functions): In doc-string say that functions
2463 run by this hook should not change the current buffer.
2464
7ea2b339
PE
24652012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 Fix recently-introduced process.c problems found by static checking.
2468 * process.c (write_queue_push, write_queue_pop, send_process):
2469 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2470 (write_queue_pop): Fix pointer signedness problem.
2471 (send_process): Remove unused local.
2472
96a313a1
CY
24732012-06-17 Chong Yidong <cyd@gnu.org>
2474
2475 * xdisp.c (redisplay_internal): No need to redisplay terminal
2476 frames that are not on top.
2477
20ca2e94
TN
24782012-06-17 Troels Nielsen <bn.troels@gmail.com>
2479
2480 * process.c (make_process): Initialize write_queue.
2481 (write_queue_push, write_queue_pop): New functions.
2482 (send_process): Use them to maintain correct ordering of process
2483 writes (Bug#10815).
2484
9a900ca9
PE
24852012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2486
310fbfa8
PE
2487 * lisp.h (eassert): Assume C89 or later.
2488 This removes the need for CHECK.
2489 (CHECK): Remove. Its comments about always evaluating its
2490 argument were confusing, as 'eassert' typically does not evaluate
2491 its argument.
2492
27bb1ca4
PE
2493 * coding.c (produce_chars): Use ptrdiff_t, not int.
2494
9a900ca9
PE
2495 * xterm.c (x_draw_underwave): Check for integer overflow.
2496 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2497
41b7f8bc 24982012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2499
2500 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2501 referenced (Bug#11583).
2502
9b0e3eba
AA
25032012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2504
2505 Implement wave-style variant of underlining.
2506 * dispextern.h (face_underline_type): New enum.
2507 (face): Add field for underline type.
2508 * nsterm.m (ns_draw_underwave): New function.
2509 (ns_draw_text_decoration): Use it.
2510 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2511 New functions.
2512 (x_draw_glyph_string): Use them.
2513 * xfaces.c (Qline, Qwave): New Lisp objects.
2514 (check_lface_attrs, merge_face_ref)
1053a871
SM
2515 (Finternal_set_lisp_face_attribute, realize_x_face):
2516 Handle wave-style underline face attributes.
9b0e3eba
AA
2517 * xterm.c (x_draw_underwave): New function.
2518 (x_draw_glyph_string): Use it.
2519
0fb52f11
JB
25202012-06-16 Juanma Barranquero <lekktu@gmail.com>
2521
2522 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2523 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2524 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2525 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2526 ($(BLD)/w32select.$(O)): Update dependencies.
2527
e5560ff7
AS
25282012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2529
2530 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2531 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2532 * character.c (_fetch_multibyte_char_p): Remove.
2533 * alloc.c: Include "character.h" before "buffer.h".
2534 * bidi.c: Likewise.
2535 * buffer.c: Likewise.
2536 * bytecode.c: Likewise.
2537 * callint.c: Likewise.
2538 * callproc.c: Likewise.
2539 * casefiddle.c: Likewise.
2540 * casetab.c: Likewise.
2541 * category.c: Likewise.
2542 * cmds.c: Likewise.
2543 * coding.c: Likewise.
2544 * composite.c: Likewise.
2545 * dired.c: Likewise.
2546 * dispnew.c: Likewise.
2547 * doc.c: Likewise.
2548 * dosfns.c: Likewise.
2549 * editfns.c: Likewise.
2550 * emacs.c: Likewise.
2551 * fileio.c: Likewise.
2552 * filelock.c: Likewise.
2553 * font.c: Likewise.
2554 * fontset.c: Likewise.
2555 * fringe.c: Likewise.
2556 * indent.c: Likewise.
2557 * insdel.c: Likewise.
2558 * intervals.c: Likewise.
2559 * keyboard.c: Likewise.
2560 * keymap.c: Likewise.
2561 * lread.c: Likewise.
2562 * macros.c: Likewise.
2563 * marker.c: Likewise.
2564 * minibuf.c: Likewise.
2565 * nsfns.m: Likewise.
2566 * nsmenu.m: Likewise.
2567 * print.c: Likewise.
2568 * process.c: Likewise.
2569 * regex.c: Likewise.
2570 * region-cache.c: Likewise.
2571 * search.c: Likewise.
2572 * syntax.c: Likewise.
2573 * term.c: Likewise.
2574 * textprop.c: Likewise.
2575 * undo.c: Likewise.
2576 * unexsol.c: Likewise.
2577 * w16select.c: Likewise.
2578 * w32fns.c: Likewise.
2579 * w32menu.c: Likewise.
2580 * window.c: Likewise.
2581 * xdisp.c: Likewise.
2582 * xfns.c: Likewise.
2583 * xmenu.c: Likewise.
2584 * xml.c: Likewise.
2585 * xselect.c: Likewise.
2586
2f07e6af
EZ
25872012-06-16 Eli Zaretskii <eliz@gnu.org>
2588
1053a871
SM
2589 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2590 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2591 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2592 row.
2593 (handle_face_prop): Use chunk-relative overlay string index when
2594 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2595 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2596 the rightmost. (Bug#11720)
2f07e6af 2597
29b83cec
AS
25982012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2599
2600 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2601 (CATEGORY_MEMBER): Enforce 1/0 value.
2602 * category.c (_temp_category_set): Remove.
2603
4c5501e9
EZ
26042012-06-16 Eli Zaretskii <eliz@gnu.org>
2605
2606 * window.c (Fdelete_other_windows_internal)
2607 (Fdelete_window_internal): Don't access frame's mouse highlight
2608 info of the initial frame. (Bug#11677)
2609
2b570124
PE
26102012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2611
e93864f9
PE
2612 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2613 Assume USE_2_TAGS_FOR_INTS.
2614 (xreload): Adjust $tagmask width to match recent lisp.h change.
2615
2b570124
PE
2616 Simplify lisp.h in minor ways that should not affect code.
2617 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2618 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2619 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2620 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2621 (INTTYPEBITS): New macro, for clarity.
2622 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2623 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2624 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2625 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2626 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2627
81755f69
JB
26282012-06-13 Juanma Barranquero <lekktu@gmail.com>
2629
2630 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2631
16192a57
GM
26322012-06-13 Glenn Morris <rgm@gnu.org>
2633
2634 * s/bsd-common.h (BSD4_3):
2635 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2636
646b5f55
AS
26372012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2638
2639 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2640 instead of union.
2641 (XLI, XIL): Define.
1053a871
SM
2642 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2643 Use them.
2644 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2645 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2646 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2647 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2648 * frame.c (delete_frame): Remove outdated comment.
2649 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2650 USE_LISP_UNION_TYPE.
2651 (Fw32_unregister_hot_key): Likewise.
2652 (Fw32_toggle_lock_key): Likewise.
2653 * w32menu.c (add_menu_item): Likewise.
2654 (w32_menu_display_help): Use XIL instead of checking
2655 USE_LISP_UNION_TYPE.
2656 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2657 (init_heap): Likewise.
2658 * w32term.c (w32_read_socket): Update comment.
2659
1d3823c9
GM
26602012-06-13 Glenn Morris <rgm@gnu.org>
2661
c62ff706
GM
2662 * s/usg5-4-common.h, src/s/unixware.h:
2663 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2664
1d3823c9
GM
2665 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2666
bfe3e0a2
PE
26672012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2668
2669 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2670 * alloc.c (make_number) [!defined make_number]:
2671 Remove, as lisp.h always defines this now.
2672 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2673 (roundup_size): Verify that it is a power of 2.
2674 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2675 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2676 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2677 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2678 USE_LSB_TAG now is always defined to be either 0 or 1.
2679 All uses changed.
2680 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2681 code works fine either way, and efficiency is not a concern here,
2682 as the union type is for debugging, not for production.
2683 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2684 Use an inline function on all platforms when using the union type,
2685 since this is simpler and 'static inline' can be used portably
2686 within Emacs now.
2687 (LISP_INITIALLY_ZERO): New macro.
2688 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2689 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2690
45fa9c0f
GM
26912012-06-12 Glenn Morris <rgm@gnu.org>
2692
b4492cba
GM
2693 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2694
2695 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2696
45fa9c0f
GM
2697 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2698 Move BROKEN_SIGIO to configure.
2699
2700 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2701 Move NO_TERMIO to configure.
2702
0e25d334
CY
27032012-06-12 Chong Yidong <cyd@gnu.org>
2704
2705 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2706 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2707 MagickExportImagePixels is undefined.
2708
43682bb6
PE
27092012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 * image.c (imagemagick_load_image): Remove unused label.
2712
a9be7d2b
GM
27132012-06-11 Glenn Morris <rgm@gnu.org>
2714
2715 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2716 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2717 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2718 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2719
3017f87f
SM
27202012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2721
2722 * alloc.c (make_byte_code): New function.
2723 (Fmake_byte_code): Use it. Don't purify here.
2724 * lread.c (read1): Use it as well to avoid extra allocation.
2725
1b9b4cf4
CY
27262012-06-11 Chong Yidong <cyd@gnu.org>
2727
2728 * image.c (imagemagick_load_image): Implement transparency.
2729
95988fcf
AS
27302012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2731
2732 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2733 account for preceding backslashes. (Bug#11663)
2734
cd4eb164
CY
27352012-06-09 Chong Yidong <cyd@gnu.org>
2736
2737 * term.c: Support italics in capable terminals (Bug#9652).
2738 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2739 (turn_on_face): Output using TS_enter_italic_mode if available.
2740 Don't handle unused blinking and alt-charset cases.
2741 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2742 and tty_alt_charset_p cases.
2743 (tty_capable_p, init_tty): Support italics.
2744
2745 * termchar.h (struct tty_display_info): Add field for italics.
2746 Remove unused blink field.
2747
2748 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2749 Handle slant.
2750
2751 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2752 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2753 tty_alt_charset_p. Add tty_italic_p.
2754
ff88beb8
MA
27552012-06-09 Michael Albinus <michael.albinus@gmx.de>
2756
2757 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2758 dbus_type_is_basic if available.
2759 (xd_extract_signed, xd_extract_unsigned): Rename from
2760 extract_signed and extract_unsigned, respectively. Adapt callers.
2761
44286096
CY
27622012-06-09 Chong Yidong <cyd@gnu.org>
2763
1682701f
CY
2764 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2765
44286096
CY
2766 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2767 case (Bug#9752).
2768
d86feb17
PE
27692012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2770
2771 * xdisp.c (vmessage): Treat frame message as multibyte.
2772 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2773 would generate the diagnostic "Making \302\247 buffer-local while
2774 let-bound!".
2775
d5c20fe8
EZ
27762012-06-08 Eli Zaretskii <eliz@gnu.org>
2777
2778 * dispnew.c (showing_window_margins_p): Undo last change, which
2779 was done due to an inadvertent commit.
2780 (adjust_frame_glyphs_for_frame_redisplay): Do call
2781 showing_window_margins_p.
2782
513749ee
SM
27832012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2784
2785 * eval.c (Fmake_var_non_special): New primitive.
2786 (syms_of_eval): Defsubr it.
2787 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2788
d4a8f5c1
JB
27892012-06-08 Juanma Barranquero <lekktu@gmail.com>
2790
2791 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2792 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2793
8bbbc977
EZ
27942012-06-08 Eli Zaretskii <eliz@gnu.org>
2795
2796 * alloc.c (allocate_vectorlike): Fix last change.
2797
f3372c87
DA
27982012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2799
2800 Block-based vector allocation of small vectors.
2801 * lisp.h (struct vectorlike_header): New field `nbytes',
2802 adjust comment accordingly.
2803 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2804 to denote vector blocks. Adjust users (live_vector_p,
2805 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2806 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2807 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2808 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2809 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2810 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2811 (roundup_size): New constant.
2812 (struct vector_block): New data type.
2813 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2814 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2815 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2816 (sweep_vectors): New functions.
2817 (allocate_vectorlike): Return `zero_vector' as the only vector of
2818 0 items. Allocate new vector from block if vector size is less than
2819 or equal to VBLOCK_BYTES_MAX.
2820 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2821 (init_alloc_once): Add call to init_vectors.
2822
4f18a4ed
SM
28232012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2824
2825 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2826
86f158bc
PE
28272012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2828
2829 * doprnt.c (doprnt): Truncate multibyte char correctly.
2830 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2831 would mishandle a string argument "Xc" if X was a multibyte
2832 character of length 2: it would truncate after X's first byte
2833 rather than including all of X.
2834
c5cfcbe0
CY
28352012-06-06 Chong Yidong <cyd@gnu.org>
2836
2837 * buffer.c (word_wrap): Doc fix.
2838
c05cf390
PE
28392012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2840
2841 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2842
0c3461de
GM
28432012-06-03 Glenn Morris <rgm@gnu.org>
2844
2845 * xdisp.c (tool-bar-style): Doc fix.
2846
c71232db
UM
28472012-06-03 Ulrich Müller <ulm@gentoo.org>
2848
2849 * Makefile.in (PAXCTL): Define.
2850 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2851 binary via PaX flags if the paxctl utility is available.
2852 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2853 Restore PaX flags to their default. (Bug#11398)
2854
383f7350
CY
28552012-06-03 Chong Yidong <cyd@gnu.org>
2856
2857 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2858 buffer (Bug#11226).
2859
5f2c76c6
CY
28602012-06-03 Chong Yidong <cyd@gnu.org>
2861
2862 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2863 (note_mode_line_or_margin_highlight): If there is no help echo,
2864 use mode-line-default-help-echo. Handle the case where the mouse
2865 position is past the end of the mode line string.
2866
2867 * buffer.c (buffer_local_value_1): New function, split from
2868 Fbuffer_local_value; can return Qunbound.
2869 (Fbuffer_local_value): Use it.
2870 (Vmode_line_format): Docstring tweaks.
2871
773d47f6
PE
28722012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 * sysdep.c (system_process_attributes): Improve comment.
2875
f2d6a3df
SM
28762012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2877
2878 * keyboard.c: Export real-this-command to Elisp.
2879 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2880 and DEFVAR it. Update all users.
2881
63810350
PE
28822012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2883
7bd5c1f4
PE
2884 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2885
63810350
PE
2886 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2887 Convert pctcpu and pctmem to Lisp float properly.
2888 Let the compiler fold better, as 100.0/0x8000 is exact.
2889
a2821611
AS
28902012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2891
2892 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2893 cons_block.
2894
5fceba1d
PE
28952012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2898
c98ff5dd
DA
28992012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2900
2901 For a 'struct window', replace some Lisp_Object fields to
2902 bitfields where appropriate, remove unused fields.
2903 * window.h (struct window): Remove unused 'last_mark_x' and
2904 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2905 change it's type from Lisp_Object to bitfield.
2906 Change type of 'force_start', 'optional_new_start',
2907 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2908 fields from Lisp_Object to bitfield. Adjust users accordingly.
2909
ca34e0be
PE
29102012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 Pacify gcc -Wdouble-precision when using Xaw.
2913 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2914 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2915 Use 'float' consistently, rather than 'float' in most places
2916 and 'double' in a couple of places.
2917
efc00ab1 29182012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2919
2920 * xdisp.c (handle_stop): Detect whether we have overlay strings
2921 loaded by testing it->current.overlay_string_index to be
2922 non-negative, instead of checking whether n_overlay_strings is
2923 positive. (Bug#11587)
2924
efc00ab1 29252012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2926
2927 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2928
2929 * doc.c (Fsubstitute_command_keys): Doc fix.
2930
efc00ab1 29312012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2932
2933 * search.c (search_buffer): Remove calls to
2934 r_alloc_inhibit_buffer_relocation, as it is now called by
2935 maybe_unify_char, which was the cause of relocation of buffer text
2936 in bug#11519.
2937
efc00ab1 29382012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2939
2940 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2941 for the duration of call to load_charset, to avoid problems with
2942 callers of maybe_unify_char that access buffer text through C
2943 pointers.
2944
2945 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2946 decrement the inhibition flag, instead of just setting or
2947 resetting it.
2948
ba93a187
PE
29492012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2950
2951 Remove obsolete '#define static' cruft.
2952 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2953 This #undef was "temporary" in 2000; it is no longer needed
2954 now that '#define static' has gone away.
2955 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2956 (gray_bitmap_bits): Remove; no longer needed.
2957 All uses replaced with definiens.
2958 * xterm.c: Include "bitmaps/gray.xbm".
2959
9e4bf381
PE
29602012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2961
2962 Clean up __executable_start, monstartup when --enable-profiling.
2963 The following changes affect the code only when profiling.
2964 * dispnew.c (__executable_start): Rename from safe_bcopy.
2965 Define only on platforms that need it.
2966 * emacs.c: Include <sys/gmon.h> when profiling.
2967 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2968 (__executable_start): Remove decl, since lisp.h does it now.
2969 (safe_bcopy): Remove decl; no longer has that name.
2970 (main): Coalesce #if into single bit of code, for simplicity.
2971 Cast pointers to uintptr_t, since standard libraries want integers
2972 and not pointers.
2973 * lisp.h (__executable_start): New decl.
2974
32d72c2f
GM
29752012-05-31 Glenn Morris <rgm@gnu.org>
2976
2977 * image.c (Fimagemagick_types): Doc fix.
2978
baac5bc7
JM
29792012-05-30 Jim Meyering <meyering@redhat.com>
2980
2981 * callproc.c (Fcall_process_region): Include directory component
2982 in mkstemp error message (Bug#11586).
2983
72cb32cf
PE
29842012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2985
2986 * alloc.c, lisp.h (make_pure_vector): Now static.
2987
61b108cc
SM
29882012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2989
2990 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2991 Move to byte-run.el.
2992 (Fautoload): Do the hash-doc more carefully.
2993 * data.c (Fdefalias): Purify definition, except for keymaps.
2994 (Qdefun): Move from eval.c.
2995 * lisp.h (Qdefun): Remove.
2996 * lread.c (read1): Tiny simplification.
2997
471fe23d
TN
29982012-05-29 Troels Nielsen <bn.troels@gmail.com>
2999
934f3f58 3000 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3001 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3002 Bug#9642, but explicitly check that the buffer the overlay would
3003 be moved to is live and rearrange lines to make sure that errors
3004 will not put the overlay in an inconsistent state.
3005 (Fdelete_overlay): Cosmetics.
3006
85d0efd1
EZ
30072012-05-28 Eli Zaretskii <eliz@gnu.org>
3008
3009 * w32term.c (my_bring_window_to_top): New function.
3010 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3011 could be different from the original one.
3012 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3013 (Bug#11513)
3014
3015 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3016 by calling BringWindowToTop.
3017
3018 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3019 (WM_EMACS_END): Increase by one.
3020
da92a98c
PE
30212012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3024 This avoids undefined behavior that might cause the eassert
3025 to not catch an out-of-range value.
3026
74d1f848
JB
30272012-05-28 Juanma Barranquero <lekktu@gmail.com>
3028
3029 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3030 Update dependencies.
3031
9e1a06fc
EZ
30322012-05-27 Eli Zaretskii <eliz@gnu.org>
3033
3034 * bidi.c (bidi_mirror_char): Fix last change.
3035
f3dd7312
AS
30362012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3037
3038 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3039 when referring to sectname field in printf format.
3040
81899c91
PE
30412012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3042
57b81a9f
PE
3043 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3044 Only r_alloc_inhibit_buffer_relocation needed to be added;
3045 the others were already declared.
3046
81899c91
PE
3047 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3048 before checking whether it's out of range. Put the check inside
3049 eassert. See
3050 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3051
33017faf 30522012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3053
3054 * callproc.c (Fcall_process): Restore a line that was accidentally
3055 commented out in the 2011-02-13 change (bug#11547).
3056
33017faf 30572012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3058
3059 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3060 defined on ralloc.c.
3061
3062 * buffer.c [REL_ALLOC]: Remove prototypes of
3063 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3064 they are now on lisp.h.
3065
3066 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3067
3068 * search.c (search_buffer): Use it to inhibit relocation of buffer
3069 text while re_search_2 is doing its job, because re_search_2 is
3070 passed C pointers to buffer text. (Bug#11519)
3071
23415acf
EZ
3072 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3073 Update value to 24.
3074
44e27368
EZ
3075 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3076 state after an additional call to move_it_in_display_line_to, keep
3077 the values of it->max_ascent and it->max_descent found for the
3078 entire line.
3079 (pos_visible_p): Revert the comparison against bottom_y to what it
3080 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3081 (Bug#11464)
3082
c1892f11
PE
30832012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 Fix coding-related core dumps with gcc -ftrapv.
3086 The code was computing A - B, where A and B are pointers, and B is
3087 random garbage. This can lead to core dumps on platforms that
3088 have special pointer registers, and it also leads to core dumps on
3089 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3090 A - B only when B is initialized properly.
3091 * coding.c (coding_set_source, coding_set_destination): Return void.
3092 (coding_change_source, coding_change_destinations): New functions,
3093 with the old behaviors of coding_set_source and coding_set_destination.
3094 All callers that need an offset changed to use these new functions.
3095
eb7afdad
GM
30962012-05-26 Glenn Morris <rgm@gnu.org>
3097
3098 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3099
f12fdf02
EZ
31002012-05-26 Eli Zaretskii <eliz@gnu.org>
3101
53a63be6 3102 Extend mouse support on W32 text-mode console.
61b108cc
SM
3103 * xdisp.c (draw_row_with_mouse_face):
3104 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3105
eb3f6f01 3106 * w32console.c: Include window.h.
61b108cc
SM
3107 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3108 New functions.
eb3f6f01
EZ
3109 (initialize_w32_display): Initialize mouse-highlight data.
3110
53a63be6
EZ
3111 * w32inevt.c: Include termchar.h and window.h.
3112 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3113 moves, call note_mouse_highlight. If help_echo changed, call
3114 gen_help_event to produce help-echo message in the echo area.
3115 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3116 highlight info.
3117
4cfd81f6
PE
31182012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3119
3120 * lread.c (read1): Simplify slightly to avoid an overflow warning
3121 with GCC 4.7.0 on x86-64.
3122
4446092a
EZ
31232012-05-26 Eli Zaretskii <eliz@gnu.org>
3124
3125 * bidi.c (bidi_mirror_char): Revert last change: an int is
3126 definitely wide enough here.
3127
42b2a986 31282012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3129
42b2a986 3130 Fix integer width and related bugs (Bug#9874).
eb106a49 3131 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3132 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3133 (string_bytes, check_sblock, allocate_string_data):
3134 (compact_small_strings, Fmake_bool_vector, make_string)
3135 (make_unibyte_string, make_multibyte_string)
3136 (make_string_from_bytes, make_specified_string)
3137 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3138 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3139 (mark_vectorlike):
3140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3141 (allocate_pseudovector):
3142 Use int, not EMACS_INT, where int is wide enough.
3143 (inhibit_garbage_collection, Fgarbage_collect):
3144 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3145 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3146 int might not be wide enough.
3147 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3148 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3149 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3150 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3151 (bidi_level_of_next_char, bidi_move_to_visually_next):
3152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3153 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3154 (Fkill_buffer, Fset_buffer_major_mode)
3155 (advance_to_char_boundary, Fbuffer_swap_text)
3156 (Fset_buffer_multibyte, overlays_at, overlays_in)
3157 (overlay_touches_p, struct sortvec, record_overlay_string)
3158 (overlay_strings, recenter_overlay_lists)
3159 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3160 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3161 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3162 (Foverlay_recenter, last_overlay_modification_hooks_used)
3163 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3165 (validate_region): Omit unnecessary test for b <= e,
3166 since that's guaranteed by the previous test.
d311d28c
PE
3167 (adjust_overlays_for_delete): Avoid pos + length overflow.
3168 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3169 (report_overlay_modification):
3170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3171 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3172 Omit pointer cast, which isn't needed anyway, and doesn't work
3173 after the EMACS_INT -> ptrdiff_t change.
02481186 3174 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3175 * buffer.h: Adjust decls to match defn changes elsewhere.
3176 (struct buffer_text, struct buffer):
3177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3178 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3179 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3180 not int, to avoid needless 32-bit limit on 64-bit hosts.
3181 (exec_byte_code): Use tighter memory-full test, one that checks
3182 for alloca overflow. Don't compute the address of the object just
3183 before an array, as that's not portable. Use EMACS_INT, not
3184 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3185 * callint.c (Fcall_interactively):
3186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3187 * callproc.c (call_process_kill, Fcall_process):
3188 Don't assume pid_t fits into an Emacs fixnum.
3189 (call_process_cleanup, Fcall_process, child_setup):
3190 Don't assume pid_t fits into int.
3191 (call_process_cleanup, Fcall_process, delete_temp_file)
3192 (Fcall_process_region):
3193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3194 (Fcall_process): Simplify handling of volatile integers.
3195 Use int, not EMACS_INT, where int will do.
3196 * casefiddle.c (casify_object, casify_region, operate_on_word)
3197 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3199 (casify_object): Avoid integer overflow when overallocating buffer.
3200 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3201 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3202 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3203 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3204 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3205 integers are now checked earlier. All uses replaced with XINT.
3206 (ccl_driver):
3207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3208 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3209 (ccl_driver, Fregister_code_conversion_map):
3210 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3211 (resolve_symbol_ccl_program): Check that vector header is in range.
3212 Always copy the vector, so that we can check its contents reliably
3213 now rather than having to recheck each instruction as it's being
3214 executed. Check that vector words fit in 'int'.
3215 (ccl_get_compiled_code, Fregister_ccl_program)
3216 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3217 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3218 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3219 contents are in range.
3220 (Fccl_execute_on_string): Check that status is in range.
3221 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3222 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3223 Accept and return EMACS_INT, not int, because callers can pass values
3224 out of 'int' range.
3225 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3226 (multibyte_chars_in_text, parse_str_as_multibyte)
3227 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3228 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3229 (string_escape_byte8, Fget_byte):
3230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3231 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3232 avoid mishandling large integers.
3233 * character.h: Adjust decls to match defn changes elsewhere.
3234 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3235 (Ffind_charset_region):
3236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3237 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3238 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3239 Don't assume fixnum fits in int.
d311d28c
PE
3240 (load_charset_map_from_vector, Fmap_charset_chars):
3241 Remove now-unnecessary CHECK_NATNUMs.
3242 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3243 Don't rely on undefined behavior with signed left shift overflow.
3244 Don't assume unsigned int fits into fixnum, or that fixnum fits
3245 into unsigned int. Don't require max_code to be a valid fixnum;
3246 that's not true for gb10830 4-byte on a 32-bit host. Allow
3247 invalid_code to be a cons, for the same reason. Require code_offset
3248 to be a character. Avoid int overflow if max_char is close
3249 to INT_MAX.
3250 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3251 this is intended anyway and avoids some undefined behavior.
3252 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3253 INDEX_TO_CODE_POINT, as that's what it expects.
3254 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3255 * charset.h (DECODE_CHAR): Return int, not unsigned;
3256 this is what was intended anyway, and it avoids undefined behavior.
3257 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3258 integer-overflow issues.
3259 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3260 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3261 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3262 * chartab.c (Fmake_char_table, Fset_char_table_range)
3263 (uniprop_get_decoder, uniprop_get_encoder):
3264 Don't assume fixnum fits in int.
3265 * cmds.c (move_point): New function, that does the gist of
3266 Fforward_char and Fbackward_char, but does so while checking
3267 for integer overflow more accurately.
c96e5d6a 3268 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3269 (Fforward_line, Fend_of_line, internal_self_insert)
3270 (internal_self_insert):
3271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3272 Fix a FIXME, by checking for integer overflow when calculating
3273 target_clm and actual_clm.
3274 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3275 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3276 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3277 (coding_alloc_by_making_gap, alloc_destination)
3278 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3279 (encode_coding_utf_16, detect_coding_emacs_mule)
3280 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3281 (detect_coding_iso_2022, decode_coding_iso_2022)
3282 (encode_invocation_designation, encode_designation_at_bol)
3283 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3284 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3285 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3286 (encode_coding_ccl, encode_coding_raw_text)
3287 (detect_coding_charset, decode_coding_charset)
3288 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3289 (produce_composition, produce_charset, produce_annotation)
3290 (decode_coding, handle_composition_annotation)
3291 (handle_charset_annotation, consume_chars, decode_coding_gap)
3292 (decode_coding_object, encode_coding_object, detect_coding_system)
3293 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3294 (code_convert_region, code_convert_string)
8f50130c
PE
3295 (Fdefine_coding_system_internal)
3296 (coding_set_source, coding_set_destination):
d311d28c
PE
3297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3298 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3299 (Fdefine_coding_system_internal):
3300 Don't assume fixnums fit in int.
3301 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3302 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3303 (Funencodable_char_position, Fcheck_coding_systems_region)
3304 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3306 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3307 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3308 Don't access memory outside of the args array.
d311d28c 3309 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3310 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3311 result of ENCODE_CHAR.
d311d28c
PE
3312 * coding.h: Adjust decls to match defn changes elsewhere.
3313 (struct coding_system):
3314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3315 * composite.c (get_composition_id, find_composition)
3316 (run_composition_function, update_compositions)
3317 (compose_text, composition_gstring_put_cache)
3318 (composition_gstring_p, composition_gstring_width)
3319 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3320 (composition_compute_stop_pos, composition_reseat_it)
3321 (composition_update_it, struct position_record)
3322 (find_automatic_composition, composition_adjust_point)
3323 (Fcomposition_get_gstring, Ffind_composition_internal):
3324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3325 (update_compositions):
3326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3327 * composite.h: Adjust decls to match defn changes elsewhere.
3328 (struct composition):
3329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3330 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3331 Do not attempt to compute the address of the object just before a
3332 buffer; this is not portable.
3333 (Faref, Faset):
3334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3335 (Faset): Use int, not EMACS_INT, where int is wide enough.
3336 (Fstring_to_number): Don't assume fixnums fit in int.
3337 (Frem): Don't assume arg is nonnegative.
3338 * dbusbind.c (xd_append_arg): Check for integers out of range.
3339 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3340 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3341 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3342 (xd_get_connection_references): Return ptrdiff_t, not int.
3343 All uses changed.
3344 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3345 (xd_read_message_1):
3346 Use int, not unsigned, where the dbus API uses int.
3347 (Fdbus_message_internal): Don't overflow mtype.
3348 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3349 * dired.c (directory_files_internal, file_name_completion, scmp)
3350 (file_name_completion_stat):
3351 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3352 (file_name_completion): Don't overflow matchcount.
3353 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3354 * dispextern.h: Adjust decls to match defn changes elsewhere.
3355 (struct text_pos, struct glyph, struct bidi_saved_info)
3356 (struct bidi_string_data, struct bidi_it, struct composition_it)
3357 (struct it):
3358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3359 (struct display_pos, struct composition_it, struct it):
3360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3361 * dispnew.c (increment_matrix_positions)
3362 (increment_row_positions, mode_line_string)
3363 (marginal_area_string):
3364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3365 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3367 (duration_to_sec_usec): New function, to check for overflow better.
3368 (Fsleep_for, sit_for): Use it.
3369 * doc.c (get_doc_string, store_function_docstring):
3370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3371 (get_doc_string, Fsnarf_documentation):
3372 Use int, not EMACS_INT, where int is wide enough.
3373 (get_doc_string):
3374 Use SAFE_ALLOCA, not alloca.
3375 Check for overflow when converting EMACS_INT to off_t.
3376 * doprnt.c (doprnt):
3377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3378 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3379 Don't assume uid_t fits into fixnum.
3380 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3381 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3382 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3383 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3384 (general_insert_function)
3385 (Finsert_char, make_buffer_string, make_buffer_string_both)
3386 (update_buffer_properties, Fbuffer_substring)
3387 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3388 (Fsubst_char_in_region, check_translation)
3389 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3390 (transpose_markers, Ftranspose_regions):
3391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3392 (clip_to_bounds): Move to lisp.h as an inline function).
3393 (Fconstrain_to_field): Don't assume integers are nonnegative.
3394 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3395 (Fsubst_char_in_region, Fsave_restriction):
3396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3397 (Femacs_pid): Don't assume pid_t fits into fixnum.
3398 (lo_time): Use int, not EMACS_INT, when int suffices.
3399 (lisp_time_argument): Check for usec out of range.
3400 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3401 (Fuser_login_name, Fuser_full_name): Signal an error
3402 if a uid argument is out of range, rather than relying on
3403 undefined behavior.
c8d5c857
PE
3404 (Fformat_time_string): Remove now-unnecessary check.
3405 lisp_time_argument checks for out-of-range usec now.
243e0530 3406 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3407 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3408 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3409 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3410 (init_cmdargs, Fdump_emacs):
3411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3412 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3413 the bottom (typically) 32 bits of the fixnum.
3414 * eval.c (specpdl_size, call_debugger):
3415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3416 (when_entered_debugger, Fbacktrace_debug):
3417 Don't assume fixnum can fit in int.
3418 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3419 the object just before a buffer; this is not portable.
3420 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3421 (grow_specpdl, unbind_to):
3422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3423 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3424 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3425 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3426 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3427 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3429 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3430 (a_write, e_write):
3431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3432 (Fcopy_file, non_regular_nbytes, read_non_regular)
3433 (Finsert_file_contents):
3434 Use int, not EMACS_INT, where int is wide enough.
3435 (READ_BUF_SIZE): Verify that it fits in int.
3436 (Finsert_file_contents): Check that counts are in proper range,
3437 rather than assuming fixnums fit into ptrdiff_t etc.
3438 Don't assume fixnums fit into int.
125b3835 3439 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3440 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3441 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3442 (string_char_to_byte, string_byte_to_char)
3443 (string_make_multibyte, string_to_multibyte)
3444 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3445 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3446 (substring_both, Fdelete, internal_equal, Ffillarray)
3447 (Fclear_string, mapcar1)
3448 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3449 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3450 (larger_vector, make_hash_table, maybe_resize_hash_table)
3451 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3452 (Fmaphash, secure_hash):
3453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3454 (concat): Check for string index and length overflow.
3455 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3456 (Frequire):
3457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3458 (larger_vector): New API (vec, incr_min, size_max) replaces old
3459 one (vec, new_size, init). This catches size overflow.
3460 INIT was removed because it was always Qnil.
3461 All callers changed.
3462 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3463 the upper bound on a hash table index size.
3464 (make_hash_table, maybe_resize_hash_table): Use it.
3465 (secure_hash): Computer start_byte and end_byte only after
3466 they're known to be in ptrdiff_t range.
3467 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3468 (Ffont_get_glyphs, Ffont_at):
3469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3470 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3471 (Flist_fonts, Fopen_font):
3472 Don't assume fixnum can fit in int.
3473 (check_gstring): Don't assume index can fit in int.
3474 (font_match_p): Check that fixnum is a character, not a nonnegative
3475 fixnum, since the later code needs to stuff it into an int.
3476 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3477 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3478 conversion overflow issues.
3479 (Fopen_font): Check for integer out of range.
3480 (Ffont_get_glyphs): Don't assume index can fit in int.
3481 * font.h: Adjust decls to match defn changes elsewhere.
3482 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3483 integer overflow.
3484 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3485 printmax_t, where ptrdiff_t is wide enough.
3486 (Finternal_char_font):
3487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3488 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3489 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3490 (Fset_frame_position, x_set_frame_parameters)
3491 (x_set_line_spacing, x_set_border_width)
3492 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3493 Check that fixnums are in proper range for system types.
3494 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3496 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3497 Use SAFE_ALLOCA_LISP, not alloca.
3498 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3499 intptr_t is wide enough.
3500 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3501 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3502 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3503 Check for fixnum out of range.
3504 * ftfont.c (ftfont_list): Don't assume index fits in int.
3505 Check that fixnums are in proper range for system types.
3506 (ftfont_shape_by_flt):
3507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3508 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3510 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3511 Check that fixnums are in proper range for system types.
3512 * gnutls.h: Adjust decls to match defn changes elsewhere.
3513 * gtkutil.c (xg_dialog_run):
3514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3515 (update_frame_tool_bar):
3516 Check that fixnums are in proper range for system types.
3517 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3518 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3519 * indent.c (last_known_column, last_known_column_point):
3520 (current_column_bol_cache):
3521 (skip_invisible, current_column, check_display_width):
3522 (check_display_width, scan_for_column, current_column_1)
3523 (Findent_to, Fcurrent_indentation, position_indentation)
3524 (indented_beyond_p, Fmove_to_column, compute_motion):
3525 (Fcompute_motion, Fvertical_motion):
3526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3527 (last_known_column_modified): Use EMACS_INT, not int.
3528 (check_display_width):
3529 (Fcompute_motion):
3530 Check that fixnums and floats are in proper range for system types.
3531 (compute_motion): Don't assume index or fixnum fits in int.
3532 (compute_motion, Fcompute_motion):
3533 Use int, not EMACS_INT, when it is wide enough.
3534 (vmotion): Omit local var start_hpos that is always 0; that way
3535 we don't need to worry about overflow in expressions involving it.
3536 * indent.h: Adjust decls to match defn changes elsewhere.
3537 (struct position):
3538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3539 Use int, not EMACS_INT, where int is wide enough.
3540 Remove unused members ovstring_chars_done and tab_offset;
3541 all uses removed.
3542 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3543 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3544 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3545 (make_gap, copy_text, insert, insert_and_inherit)
3546 (insert_before_markers, insert_before_markers_and_inherit)
3547 (insert_1, count_combining_before, count_combining_after)
3548 (insert_1_both, insert_from_string)
3549 (insert_from_string_before_markers, insert_from_string_1)
3550 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3551 (adjust_after_replace, adjust_after_insert, replace_range)
3552 (replace_range_2, del_range, del_range_1, del_range_byte)
3553 (del_range_both, del_range_2, modify_region)
3554 (prepare_to_modify_buffer, signal_before_change)
3555 (signal_after_change, Fcombine_after_change_execute):
3556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3557 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3558 (balance_an_interval, split_interval_right, split_interval_left)
3559 (find_interval, next_interval, update_interval)
3560 (adjust_intervals_for_insertion, delete_node, delete_interval)
3561 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3562 (static_offset_intervals, offset_intervals)
3563 (merge_interval_right, merge_interval_left, make_new_interval)
3564 (graft_intervals_into_buffer, temp_set_point_both)
3565 (temp_set_point, set_point, adjust_for_invis_intang)
3566 (set_point_both, move_if_not_intangible, get_property_and_range)
3567 (get_local_map, copy_intervals, copy_intervals_to_string)
3568 (compare_string_intervals, set_intervals_multibyte_1):
3569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3570 * intervals.h: Adjust decls to match defn changes elsewhere.
3571 (struct interval):
3572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3573 * keyboard.c (this_command_key_count, this_single_command_key_start)
3574 (before_command_key_count, before_command_echo_length, echo_now)
3575 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3576 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3577 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3578 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3580 (last_non_minibuf_size, last_point_position, echo_truncate)
3581 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3582 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3583 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3584 (stuff_buffered_input):
3585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3586 (last_auto_save, command_loop_1, read_char):
3587 Use EMACS_INT, not int, to avoid integer overflow.
3588 (record_char): Avoid overflow in total_keys computation.
3589 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3590 * keyboard.h: Adjust decls to match defn changes elsewhere.
3591 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3592 (Fkey_description, Fdescribe_vector, Flookup_key):
3593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3594 (click_position): New function, to check that positions are in range.
3595 (Fcurrent_active_maps):
3596 (describe_command):
3597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3598 (Faccessible_keymaps, Fkey_description):
3599 (preferred_sequence_p):
3600 Don't assume fixnum can fit into int.
3601 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3602 Check for integer overflow in size calculations.
3603 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3604 avoid mishandling large integers.
3605 * lisp.h: Adjust decls to match defn changes elsewhere.
3606 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3607 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3608 (struct Lisp_Marker):
3609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3610 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3611 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3612 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3613 All callers changed.
3614 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3615 Assume the arg has valid form, since it always does.
3616 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3617 unsigned integer system type.
3618 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3619 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3621 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3622 (duration_to_sec_usec): New decl.
3623 * lread.c (read_from_string_index, read_from_string_index_byte)
3624 (read_from_string_limit, readchar, unreadchar, openp)
3625 (read_internal_start, read1, oblookup):
3626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3627 (Fload, readevalloop, Feval_buffer, Feval_region):
3628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3629 (openp): Check for out-of-range argument to 'access'.
3630 (read1): Use int, not EMACS_INT, where int is wide enough.
3631 Don't assume fixnum fits into int.
6efdadfd 3632 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3633 (read_filtered_event): Use duration_to_sec_usec
3634 to do proper overflow checking on durations.
d311d28c
PE
3635 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3636 in size calculation.
3637 (Fexecute_kbd_macro):
3638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3639 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3640 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3641 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3642 (set_marker_both, set_marker_restricted_both, marker_position)
3643 (marker_byte_position, Fbuffer_has_markers_at):
3644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3645 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3646 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3647 It now merely ensures that the menu is large enough, without
3648 necessarily growing it, as this avoids some integer overflow issues.
3649 All callers changed.
3650 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3652 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3653 Use SAFE_ALLOCA_LISP, not alloca.
3654 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3655 to EMACS_INT. Check that fixnums are in proper range for system types.
3656 * minibuf.c (minibuf_prompt_width, string_to_object)
3657 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3658 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3660 (get_minibuffer, read_minibuf_unwind):
3661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3662 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3663 this simplifies overflow checking. All callers changed.
3664 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3665 (Ftest_completion):
3666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3667 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3668 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3669 Check that fixnums are in proper range for system types.
3670 (Fx_create_frame, Fx_show_tip):
3671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3672 * nsfont.m (ns_findfonts, nsfont_list_family):
3673 Don't assume fixnum fits in long.
3674 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3676 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3677 wide enough.
17fdb222 3678 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3680 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3681 (PRINTDECLARE, PRINTPREPARE):
3682 (strout, print_string):
3683 (print, print_preprocess, print_check_string_charset_prop)
3684 (print_object):
3685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3686 (PRINTDECLARE):
3687 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3689 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3690 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3691 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3692 (print_error_message): Use SAFE_ALLOCA, not alloca.
3693 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3694 (print_depth, new_backquote_output, print_number_index):
3695 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3696 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3697 (Fset_process_window_size, Fformat_network_address)
3698 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3699 (sigchld_handler):
d311d28c 3700 Check that fixnums are in proper range for system types.
d44287d4 3701 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3702 Check for process-ids out of pid_t range rather than relying on
3703 undefined behavior.
e4d81efc 3704 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3705 (Fformat_network_address, read_process_output, send_process)
3706 (Fprocess_send_region, status_notify):
3707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3708 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3709 (wait_reading_process_output, read_process_output, exec_sentinel):
3710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3711 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3712 (Faccept_process_output): Use duration_to_sec_usec to do proper
3713 overflow checking on durations.
dde14581
PE
3714 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3715 Don't assume pid_t fits in int.
02481186
PE
3716 * process.h (struct Lisp_Process): Members tick and update_tick
3717 are now of type EMACS_INT, not int.
b62b53e8
PE
3718 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3719 configured --with-wide-int.
d311d28c
PE
3720 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3721 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3722 * search.c (looking_at_1, string_match_1):
3723 (fast_string_match, fast_c_string_match_ignore_case)
3724 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3725 (scan_newline, find_before_next_newline, search_command)
3726 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3727 (set_search_regs, wordify):
3728 (Freplace_match):
3729 (Fmatch_data):
3730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3731 (string_match_1, search_buffer, set_search_regs):
3732 (Fmatch_data):
3733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3734 (wordify): Check for overflow in size calculation.
3735 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3736 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3737 Check that fixnums are in proper range for system types.
3738 * sound.c (struct sound_device)
3739 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3741 (Fplay_sound_internal):
3742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3743 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3744 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3745 (Fparse_partial_sexp):
3746 Don't assume fixnums can fit in int.
3747 (struct lisp_parse_state, find_start_pos, find_start_value)
3748 (find_start_value_byte, find_start_begv)
3749 (update_syntax_table, char_quoted, dec_bytepos)
3750 (find_defun_start, prev_char_comend_first, back_comment):
3751 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3752 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3754 (Finternal_describe_syntax_value): Check that match_lisp is a
3755 character, not an integer, since the code stuffs it into int.
3756 (scan_words, scan_sexps_forward):
3757 Check that fixnums are in proper range for system types.
3758 (Fforward_word):
3759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3760 (scan_sexps_forward):
3761 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3762 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3763 * syntax.h: Adjust decls to match defn changes elsewhere.
3764 (struct gl_state_s):
3765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3766 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3767 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3768 * sysdep.c (wait_for_termination_1, wait_for_termination)
3769 (interruptible_wait_for_termination, mkdir):
3770 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3771 (emacs_read, emacs_write):
3772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3773 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3774 and double all fit in int.
d311d28c
PE
3775 * term.c (set_tty_color_mode):
3776 Check that fixnums are in proper range for system types.
3777 * termhooks.h (struct input_event):
3778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3779 * textprop.c (validate_interval_range, interval_of)
3780 (Fadd_text_properties, set_text_properties_1)
3781 (Fremove_text_properties, Fremove_list_of_text_properties)
3782 (Ftext_property_any, Ftext_property_not_all)
3783 (copy_text_properties, text_property_list, extend_property_ranges)
3784 (verify_interval_modification):
3785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3786 (Fnext_single_char_property_change)
3787 (Fprevious_single_char_property_change):
3788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3789 (copy_text_properties):
3790 Check for integer overflow in index calculation.
d311d28c
PE
3791 * undo.c (last_boundary_position, record_point, record_insert)
3792 (record_delete, record_marker_adjustment, record_change)
3793 (record_property_change):
3794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3795 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3797 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3798 (Fx_hide_tip, Fx_file_dialog):
3799 * w32menu.c (set_frame_menubar):
3800 Use ptrdiff_t, not int, for consistency with rest of code.
3801 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3802 (select_window, Fdelete_other_windows_internal)
3803 (window_scroll_pixel_based, window_scroll_line_based)
3804 (Frecenter, Fset_window_configuration):
3805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3806 (Fset_window_hscroll, run_window_configuration_change_hook)
3807 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3808 (Fscroll_other_window, Frecenter):
d311d28c
PE
3809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3810 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3811 Don't assume fixnum fits in int.
3812 (Fset_window_scroll_bars):
3813 Check that fixnums are in proper range for system types.
3814 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3815 (string_pos, c_string_pos, number_of_chars, init_iterator)
3816 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3817 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3818 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3819 (face_before_or_after_it_pos, handle_invisible_prop)
3820 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3821 (display_prop_intangible_p, string_buffer_position_lim)
3822 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3823 (get_overlay_strings_1, get_overlay_strings)
3824 (iterate_out_of_display_property, forward_to_next_line_start)
3825 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3826 (get_next_display_element, set_iterator_to_next)
3827 (get_visually_first_element, compute_stop_pos_backwards)
3828 (handle_stop_backwards, next_element_from_buffer)
3829 (move_it_in_display_line_to, move_it_in_display_line)
3830 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3831 (add_to_log, message_dolog, message_log_check_duplicate)
3832 (message2, message2_nolog, message3, message3_nolog
3833 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3834 (current_message_1, truncate_echo_area, truncate_message_1)
3835 (set_message, set_message_1, store_mode_line_noprop)
3836 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3837 (text_outside_line_unchanged_p, check_point_in_composition)
3838 (reconsider_clip_changes)
3839 (redisplay_internal, set_cursor_from_row, try_scrolling)
3840 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3841 (redisplay_window, find_last_unchanged_at_beg_row)
3842 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3843 (trailing_whitespace_p, find_row_edges, display_line)
3844 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3845 (display_mode_element, store_mode_line_string)
3846 (pint2str, pint2hrstr, decode_mode_spec)
3847 (display_count_lines, display_string, draw_glyphs)
3848 (x_produce_glyphs, x_insert_glyphs)
3849 (rows_from_pos_range, mouse_face_from_buffer_pos)
3850 (fast_find_string_pos, mouse_face_from_string_pos)
3851 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3853 (safe_call, init_from_display_pos, handle_fontified_prop)
3854 (handle_single_display_spec, load_overlay_strings)
3855 (with_echo_area_buffer, setup_echo_area_for_printing)
3856 (display_echo_area, echo_area_display)
3857 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3858 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3859 (redisplay_window, dump_glyph_row, display_mode_line)
3860 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3861 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3863 (handle_single_display_spec, build_desired_tool_bar_string)
3864 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3865 (get_specified_cursor_type):
3866 Check that fixnums are in proper range for system types.
3867 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3868 (Flookup_image_map):
3869 Don't assume fixnums fit in int.
3870 (compare_overlay_entries):
3871 Avoid mishandling comparisons due to subtraction overflow.
3872 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3873 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3874 (handle_tool_bar_click):
3875 Use int, not unsigned, since we prefer signed and the signedness
3876 doesn't matter here.
3877 (get_next_display_element, next_element_from_display_vector):
3878 Use int, not EMACS_INT, when int is wide enough.
3879 (start_hourglass): Use duration_to_sec_usec to do proper
3880 overflow checking on durations.
3881 * xfaces.c (Fbitmap_spec_p):
3882 Check that fixnums are in proper range for system types.
3883 (compare_fonts_by_sort_order):
3884 Avoid mishandling comparisons due to subtraction overflow.
3885 (Fx_family_fonts, realize_basic_faces):
3886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3887 (Fx_family_fonts):
3888 Don't assume fixnum fits in int.
3889 Use SAFE_ALLOCA_LISP, not alloca.
3890 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3891 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3892 (face_at_buffer_position, face_for_overlay_string)
3893 (face_at_string_position):
3894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3895 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3896 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3897 (Fx_show_tip):
3898 Check that fixnums are in proper range for system types.
3899 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3900 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3902 (Fx_change_window_property): Don't assume fixnums fit in int.
3903 * xfont.c (xfont_chars_supported):
3904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3905 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3906 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3908 * xml.c (parse_region):
3909 * xrdb.c (magic_file_p):
3910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3911 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3912 (x_get_local_selection, x_reply_selection_request)
3913 (x_handle_selection_request, wait_for_property_change):
3914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3915 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3916 short is wide enough.
3917 (x_send_client_event): Don't assume fixnum fits in int.
3918 * xterm.c (x_x_to_emacs_modifiers):
3919 Don't assume EMACS_INT overflows nicely into int.
3920 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3921 may come from Lisp.
3922 (handle_one_xevent): NATNUMP can eval its arg twice.
3923 (x_connection_closed):
3924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3925 * xterm.h: Adjust decls to match defn changes elsewhere.
3926 (struct scroll_bar): Use struct vectorlike_header
3927 rather than rolling our own approximation.
3928 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3929
c6574eb5
GM
39302012-05-25 Glenn Morris <rgm@gnu.org>
3931
3932 * lisp.mk (lisp): Update for more files being compiled now.
3933
e8d32c7e
SM
39342012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3935
48def666
SM
3936 * lread.c: Remove `read_pure' which makes no difference.
3937 (read_pure): Remove var.
3938 (unreadpure): Remove function.
3939 (readevalloop): Don't call read_list with -1 flag.
3940 (read1, read_vector): Don't test read_pure any more.
3941 (read_list): Simplify.
3942
e8d32c7e
SM
3943 * fileio.c, character.h: Minor style tweaks.
3944
4b2addb7
DA
39452012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3946
3947 * window.h (clip_changed): Remove useless declaration.
3948
584461b2
JB
39492012-05-22 Juanma Barranquero <lekktu@gmail.com>
3950
3951 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3952 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3953
34374650
PE
39542012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3955
3956 Remove src/m/*.
3957 This directory predates autoconf and is no longer needed nowadays.
3958 Move its few remaining bits of functionality to where they're needed.
3959 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3960 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3961 * m/template.h: Remove.
3962 * Makefile.in (M_FILE): Remove. All uses removed.
3963 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3964 * lisp.h (USE_LSB_TAG):
3965 * mem-limits.h (EXCEEDS_LISP_PTR):
3966 Use VAL_MAX, not VALBITS, in #if.
3967 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3968 (EMACS_UINT): Define unconditionally now.
3969 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3970 (BITS_PER_EMACS_INT): New constants, replacing
3971 what used to be in config.h, but not useful in #if.
3972 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3973 define them any more.
3974 (VAL_MAX): New macro.
3975 (VALMASK): Use it.
3976 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3977 BITS_PER_EMACS_INT, in #if.
3978 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3979 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3980 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3981 * s/ms-w32.h (DATA_START):
3982 Move here from removed file m/intel386.h.
3983 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3984 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3985
261cb4bb
PE
39862012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Assume C89 or later.
3989 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3990 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3991 (xrealloc):
3992 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3993 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3994 * textprop.c, tparam.c (NULL): Remove.
3995 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3996 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3997 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3998 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3999 * xterm.c (input_signal_count): Assume volatile works.
4000
ff23cd9f
KB
40012012-05-21 Ken Brown <kbrown@cornell.edu>
4002
4003 * xgselect.c (xg_select): Fix first argument in call to 'select'
4004 (bug#11508).
4005
1b170bc6
KB
40062012-05-20 Ken Brown <kbrown@cornell.edu>
4007
4008 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4009 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4010
b2f4d39f
KB
40112012-05-19 Ken Brown <kbrown@cornell.edu>
4012
4013 * xfns.c (x_in_use): Remove `static' qualifier.
4014 * xterm.h (x_in_use): Declare.
4015 * xgselect.c: Include xterm.h.
4016 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4017 and `display_arg' (bug#9754).
4018
003fdae2
PE
40192012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4020
9232a6d9
PE
4021 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4022
003fdae2
PE
4023 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4024 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4025
784b56e2
EZ
40262012-05-18 Eli Zaretskii <eliz@gnu.org>
4027
4028 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4029
4030 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4031 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4032
4033 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4034 reference to image_cache->refcount.
4035 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4036
a0a79cde
JL
40372012-05-17 Juri Linkov <juri@jurta.org>
4038
4039 * search.c (Fword_search_regexp, Fword_search_backward)
4040 (Fword_search_forward, Fword_search_backward_lax)
4041 (Fword_search_forward_lax): Move functions to isearch.el
4042 (bug#10145, bug#11381).
4043
b0572523
PE
40442012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4047
9660f5fc
SM
40482012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4049
4050 * lread.c (init_obarray): Declare Qt and Qnil as special.
4051
4374de83
GM
40522012-05-14 Glenn Morris <rgm@gnu.org>
4053
4054 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4055 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4056
dc44c39a
PE
40572012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4058
078c97cb
PE
4059 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4060
dc44c39a
PE
4061 * unexaix.c: Port to more-recent AIX compilers.
4062 (report_error, report_error_1, make_hdr, copy_sym)
4063 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4064 Make arguments const char *, not char *, to avoid violations of C
4065 standard and to fix some AIX warnings reported by Gilles Pion.
4066
e18afed7 40672012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4068
4069 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4070 already have overlays loaded.
4071 (handle_single_display_spec): Before returning without displaying
4072 fringe bitmap, synchronize the bidi iterator with the main display
4073 iterator, by calling iterate_out_of_display_property.
4074 (iterate_out_of_display_property): Detect buffer iteration by
4075 testing that it->string is a Lisp string.
4076 (get_next_display_element): When the current object is exhausted,
4077 and there's something on it->stack, call set_iterator_to_next to
4078 proceed with what's on the stack, instead of returning zero.
4079 (set_iterator_to_next): If called at the end of a Lisp string,
4080 proceed to consider_string_end without incrementing string
4081 position. Don't increment display vector index past the end of
4082 the display vector. (Bug#11417)
c8fb9dc6
EZ
4083 (pos_visible_p): Don't report a position visible when move_it_to
4084 stopped at the last line of window, which happens to be scanned
4085 backwards by the bidi iteration. (Bug#11464)
ac268e67 4086
e18afed7 40872012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4088
4089 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4090 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4091 are on a TTY, and thus unable to display on the fringes.
4092 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4093 so we need to signal to the caller that this is a "replacing"
4094 display spec. This fixes display when the spec is invalid or we
4095 are on a TTY.
4096
e18afed7 40972012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4098
4099 * unexaix.c (make_hdr): Fix typo in prototype.
4100 This bug broke the build on AIX. Problem reported by Gilles Pion.
4101
9d0a235a
MA
41022012-05-14 Michael Albinus <michael.albinus@gmx.de>
4103
4104 * keyboard.c (kbd_buffer_get_event): Read special events also in
4105 batch mode. (Bug#11415)
4106
9e6b06ed
GM
41072012-05-12 Glenn Morris <rgm@gnu.org>
4108
4109 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4110
c1a1d7a3
EZ
41112012-05-12 Eli Zaretskii <eliz@gnu.org>
4112
4113 * lisp.mk (lisp): Add newcomment.elc.
4114
3fe7cdc8
GM
41152012-05-12 Glenn Morris <rgm@gnu.org>
4116
4117 * Makefile.in (MKDIR_P): New, set by configure.
4118 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4119
53f7d2c0
PE
41202012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4121
4122 Remove unused function hourglass_started.
4123 * dispextern.h (hourglass_started):
4124 * w32fns.c (hourglass_started):
4125 * xdisp.c (hourglass_started): Remove.
4126
75aafb17
JB
41272012-05-10 Juanma Barranquero <lekktu@gmail.com>
4128
4129 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4130 Update dependencies.
4131
12959e8e
PE
41322012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4133
97107e2e
PE
4134 * xgselect.c (xg_select): Put maxfds+1 into a var.
4135 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4136
12959e8e
PE
4137 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4138
836d29b3
DA
41392012-05-10 Dave Abrahams <dave@boostpro.com>
4140
4141 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4142 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4143
5cb67954
MA
41442012-05-09 Michael Albinus <michael.albinus@gmx.de>
4145
4146 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4147 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4148 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4149 Initialize xd_registered_buses.
4150
3478ec45
PE
41512012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4152
b263a6b0
PE
4153 Untag more efficiently if USE_LSB_TAG.
4154 This is based on a proposal by YAMAMOTO Mitsuharu in
4155 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4156 For an admittedly artificial (nth 8000 longlist) benchmark on
4157 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4158 Emacs's overall text size by 1%.
4159 * lisp.h (XUNTAG): New macro.
4160 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4161 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4162 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4163 * eval.c (Fautoload):
4164 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4165 * frame.h (XFRAME): Use XUNTAG.
4166
3478ec45
PE
4167 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4168 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4169 Remove unportable assumptions about print widths of types like
4170 dbus_uint32_t.
4171 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4172 intptr_t when converting between pointer and integer, to avoid GCC
4173 warnings about wrong width.
4174
666b903b 41752012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4176
4177 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4178 stack for each reader_thread, instead of defaulting to 8MB
4179 determined by the linker. This avoids failures in creating
4180 subprocesses on Windows 7, see the discussion in this thread:
4181 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4182
b120cc17
JC
41832012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4184
4185 Fix up display of the *Minibuf-0* buffer in the mini window.
4186 * keyboard.c (read_char): Don't clear the echo area if there's no
4187 message to clear.
4188 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4189 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4190
9a4b36f8
MA
41912012-05-07 Michael Albinus <michael.albinus@gmx.de>
4192
4193 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4194 batch mode.
4195
e5f9458f
CY
41962012-05-06 Chong Yidong <cyd@gnu.org>
4197
4198 * lisp.mk (lisp): Update.
4199
eceeb5fc 42002012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4201
4202 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4203
71873e2b
SM
42042012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4205
4206 * data.c (PUT_ERROR): New macro.
4207 (syms_of_data): Use it. Add new error type `user-error'.
4208 * undo.c (user_error): New function.
4209 (Fprimitive_undo): Use it.
4210 * print.c (print_error_message): Adjust print style for `user-error'.
4211 * keyboard.c (user_error): New function.
4212 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4213
ab0fa4e4
PE
42142012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 Do not limit current-time-string to years 1000..9999.
4217 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4218 (Fcurrent_time_string): Support any year that is supported by the
4219 underlying localtime representation. Don't use asctime, as it
4220 has undefined behavior for years outside the range -999..9999.
4221
7ed806a7
PE
42222012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4223
4224 Fix race conditions involving setenv, gmtime, localtime, asctime.
4225 Without this fix, interrupts could mess up code that uses these
4226 nonreentrant functions, since setting TZ invalidates existing
4227 tm_zone or tzname values, and since most of these functions return
4228 pointers to static storage.
4229 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4230 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4231 Grow the critical sections to include not just invoking
4232 localtime/gmtime, but also accessing these functions' results
4233 including their tm_zone values if any, and any related TZ setting.
4234 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4235 so that the struct tm is saved in the critical section.
4236 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4237 motivated by the fact that memory allocation needs to be outside
4238 the critical section.
4239
0c16dfed
DA
42402012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4241
4242 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4243 with RESET_INTERVAL.
4244
4245 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4246 Remove duplicated buffer name initialization.
4247
3f83ace8
JM
42482012-05-02 Jim Meyering <jim@meyering.net>
4249
4250 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4251
c7b8541e
JM
4252 * xfns.c (x_window): Use xstrdup (Bug#11375).
4253
90207a15 42542012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4255
4256 * xdisp.c (pos_visible_p): If already at a newline from the
4257 display string before the 'while' loop, don't walk back the glyphs
4258 from it3.glyph_row. Solves assertion violation when the display
4259 string begins with a newline (egg.el). (Bug#11367)
4260
b593d6a9
AH
42612012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4262
4263 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4264 Move to simple.el.
4265
4737362e
GM
42662012-05-01 Glenn Morris <rgm@gnu.org>
4267
99cf43f9
GM
4268 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4269 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4270 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4271 All were removed before 23.1.
4272
9311dcff
GM
4273 * dispnew.c: Remove HAVE_LIBNCURSES test;
4274 it is always true on relevant platforms.
4275
4d5c6349
GM
4276 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4277 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4278
4737362e
GM
4279 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4280
74dd3a6b
AS
42812012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4282
4283 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4284 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4285 Remove.
4286
13c379ee
PE
42872012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4288
4289 Do not avoid creating empty evaporating overlays (Bug#9642).
4290 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4291 That is, do not delete an evaporating overlay if it becomes
4292 empty after its bounds are adjusted to fit within its buffer.
4293 This fix caused other problems, and I'm reverting it until we get
4294 to the bottom of them.
4295
a8e7d6d7 42962012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4297
4298 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4299
a8e7d6d7 43002012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4301
4302 * xdisp.c (pos_visible_p): If the window start position is beyond
4303 ZV, start the display from buffer beginning. Prevents assertion
4304 violation in init_iterator when the minibuffer window is scrolled
4305 via the scroll bar.
4306
4307 * window.c (window_scroll_pixel_based): Likewise.
4308
a8e7d6d7 43092012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4310
4311 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4312
a8e7d6d7 43132012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4314
4315 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4316 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4317
a8e7d6d7 43182012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4319
b593d6a9
AH
4320 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4321 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4322
1c6900d9
EZ
43232012-04-26 Eli Zaretskii <eliz@gnu.org>
4324
4c3fa1d9
EZ
4325 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4326 display element, check also the underlying string or buffer
4327 character. (Bug#11341)
4328
1c6900d9
EZ
4329 * w32menu.c: Include w32heap.h.
4330 (add_menu_item): If the call to AppendMenuW (via
4331 unicode_append_menu) fails, disable Unicode menus only if we are
4332 running on Windows 9X/Me.
4333
42bf8205
AS
43342012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4335
4336 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4337 (xgetint): Add missing shift for LSB tags.
4338
b1bac16e
MR
43392012-04-24 Martin Rudalics <rudalics@gmx.at>
4340
4341 * keyboard.c (read_char): Don't wipe echo area for select window
4342 events: These might get delayed via `mouse-autoselect-window'
4343 (Bug#11304).
4344
d69621cc
JB
43452012-04-24 Juanma Barranquero <lekktu@gmail.com>
4346
4347 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4348 manipulation of :loaded-from data.
4349
02fd101b
JB
43502012-04-23 Juanma Barranquero <lekktu@gmail.com>
4351
4352 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4353 now a cons (bug#11311).
4354
888bec30
PE
43552012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4356
89a438bd
PE
4357 Do not create empty overlays with the evaporate property (Bug#9642).
4358 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4359 if it becomes empty after its bounds are adjusted to fit within
4360 its buffer. Without this fix, in a nonempty buffer (let ((o
4361 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4362 yields an empty overlay that has the evaporate property, which is
4363 not supposed to happen.
4364
1068fe4d
PE
4365 Fix minor GTK3 problems found by static checking.
4366 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4367 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4368 (struct _EmacsFixedClass, emacs_fixed_get_type):
4369 Move decls here from emacsgtkfixed.h, since they needn't be public.
4370 (emacs_fixed_get_type): Now static.
4371 (emacs_fixed_class_init): Omit unused local.
4372 (emacs_fixed_child_type): Remove; unused.
4373 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4374 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4375 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4376 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4377 (EMACS_FIXED_GET_CLASS): Remove; unused.
4378 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4379
888bec30
PE
4380 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4381 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4382
de85e130
PE
43832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4384
d0baac98 4385 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4386 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4387 (__malloc_size_t, __malloc_ptrdiff_t):
4388 Remove. All uses removed, replaced by the definiens if needed,
4389 since we can assume C89 or better now.
4390 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4391 (protect_malloc_state, align, get_contiguous_space)
4392 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4393 (malloc_atfork_handler_child, malloc_enable_thread)
4394 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4395 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4396 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4397 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4398 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4399 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4400 Define using prototypes, not old style.
4401 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4402 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4403 (align): Don't assume that signed integer overflow wraps around.
4404 Omit unused local var.
4405 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4406 (_free_internal_nolock, memalign, mallochook, reallochook):
4407 Omit no-longer-needed casts.
4408 (valloc): Use getpagesize, not __getpagesize.
4409 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4410 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4411
de85e130
PE
4412 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4413
dcbf5805
MA
44142012-04-22 Michael Albinus <michael.albinus@gmx.de>
4415
4416 Move functions from C to Lisp. Make non-blocking method calls
4417 the default. Implement further D-Bus standard interfaces.
4418
4419 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4420 (QCdbus_request_name_allow_replacement)
4421 (QCdbus_request_name_replace_existing)
4422 (QCdbus_request_name_do_not_queue)
4423 (QCdbus_request_name_reply_primary_owner)
4424 (QCdbus_request_name_reply_in_queue)
4425 (QCdbus_request_name_reply_exists)
4426 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4427 (QCdbus_registered_serial, QCdbus_registered_method)
4428 (QCdbus_registered_signal): New Lisp objects.
4429 (XD_DEBUG_MESSAGE): Use sizeof.
4430 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4431 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4432 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4433 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4434 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4435 (xd_signature, xd_append_arg): Allow float for integer types.
4436 (xd_get_connection_references): New function.
b593d6a9
AH
4437 (xd_get_connection_address): Rename from xd_initialize.
4438 Return cached address.
dcbf5805
MA
4439 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4440 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4441 level.
4442 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4443 Return number of refcounts.
dcbf5805
MA
4444 (Fdbus_get_unique_name): Make stronger parameter check.
4445 (Fdbus_message_internal): New defun.
4446 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4447 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4448 (Fdbus_send_signal, Fdbus_register_service)
4449 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4450 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4451 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4452 (Vdbus_compiled_version, Vdbus_runtime_version)
4453 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4454 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4455 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4456 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4457 Adapt docstring.
dcbf5805 4458
52828e02
PE
44592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4460
da05bc4c
PE
4461 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4462 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4463 Do not assume ptrdiff_t is the same width as 'int'.
4464
52828e02
PE
4465 * alloc.c: Handle unusual debugging option combinations.
4466 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4467 since the two debugging options are incompatible.
4468 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4469 is defined.
4470 (mem_init, mem_insert, mem_insert_fixup):
4471 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4472 (NEED_MEM_INSERT): Remove; no longer needed.
4473
f01769f9
LL
44742012-04-22 Leo Liu <sdl.web@gmail.com>
4475
4476 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4477
5790543d
PE
44782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4479
4480 * sysdep.c [__FreeBSD__]: Minor cleanups.
4481 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4482 Use Emacs indenting style more consistently. Avoid some casts.
4483 Use 'double' consistently rather than mixing 'float' and 'double'.
4484
b91b7e4d
EW
44852012-04-21 Eduard Wiebe <usenet@pusto.de>
4486
b593d6a9
AH
4487 * sysdep.c (list_system_processes, system_process_attributes):
4488 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4489
6114eb15
AS
44902012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4491
4492 * lisp.mk (lisp): Update.
4493
2f38dff7
PE
44942012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4495
4496 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4497 It is never used otherwise.
4498
4ae29f89
SM
44992012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4500
4501 * print.c (print_preprocess): Only check print_depth if print-circle
4502 is nil.
4503 (print_object): Check for cycles even when print-circle is nil and
4504 print-gensym is t, but only check print_depth if print-circle is nil.
4505
f30d612a
CY
45062012-04-20 Chong Yidong <cyd@gnu.org>
4507
4508 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4509 set the status to "failed" and ensure that sentinel is run.
4510
c07a4c0b 45112012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4512
4513 * process.c (Fset_process_inherit_coding_system_flag)
4514 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4515 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4516
c07a4c0b 45172012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4518
4519 * xdisp.c (string_buffer_position_lim): Limit starting position to
4520 BEGV.
4521 (set_cursor_from_row): If called for a mode-line or header-line
4522 row, return zero immediately.
4523 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4524 farther than the first row after the header line, if any.
4525 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4526 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4527
c07a4c0b 45282012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4529
4ae29f89
SM
4530 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4531 (bug#11238).
ad3a2b41 4532
c07a4c0b 45332012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 45342012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4535
4536 configure: new option --enable-gcc-warnings (Bug#11207)
4537 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4538 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4539 (ALL_CFLAGS): Use new macros rather than old.
4540 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4541 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4542 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4543 -Wunused-result, -Wunused-variable. This should go away once
4544 the Emacs and Gnulib regex code is merged.
4545 (xmalloc, xrealloc): Now static.
4546
aba027e8
PE
45472012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4548
4549 * dired.c (Fsystem_groups): Remove unused local.
4550
e5a36063
GM
45512012-04-17 Glenn Morris <rgm@gnu.org>
4552
4553 * dired.c (Fsystem_users): Doc fix.
4554
316411f0
DA
45552012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4556
4557 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4558 (syms_of_dired): Add them.
4559
9426aba4
PE
45602012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4561
b62a57be
PE
4562 Fix minor alloc.c problems found by static checking.
4563 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4564 New extern decls, to avoid calling undeclared functions.
4565 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4566 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4567 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4568 (NEED_MEM_INSERT): New macro.
4569 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4570 Remove one incorrect comment and fix another.
b62a57be 4571
3539f31f
PE
4572 Fix minor ralloc.c problems found by static checking.
4573 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4574 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4575 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4576 (r_alloc_sbrk): Now static.
4577
a041960a
PE
4578 Improve ralloc.c interface checking.
4579 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4580 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4581 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4582 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4583 [REL_ALLOC]: ... to here, to check interface.
4584 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4585 Remove decls. This fixes an "It stinks!".
4586
9426aba4
PE
4587 * alloc.c (which_symbols): Fix alignment issue / type clash.
4588
d55c12ed
AS
45892012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4590
4591 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4592 (struct Lisp_Misc_Any): Likewise.
4593 (struct Lisp_Free): Likewise.
4594 * alloc.c (union aligned_Lisp_Symbol): Define.
4595 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4596 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4597 (union aligned_Lisp_Misc): Define.
4598 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4599 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4600 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4601
b948ce8b
PE
46022012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4603
4604 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4605 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4606 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4607 * s/netbsd.h, s/sol2-6.h:
4608 Remove definition of GC_MARK_STACK, since the default now works.
4609 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4610 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4611 no longer the default.
4612 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4613
35dc09a1 46142012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4615
35dc09a1
GM
4616 * lread.c (lisp_file_lexically_bound_p):
4617 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4618
35dc09a1
GM
46192012-04-14 Eli Zaretskii <eliz@gnu.org>
4620
4621 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4622 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4623
46242012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4625
4626 * nsterm.m (constrainFrameRect): Always constrain when there is only
4627 one screen (Bug#10962).
4628
bcd86815
KB
46292012-04-13 Ken Brown <kbrown@cornell.edu>
4630
4631 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4632
c25df26e
RT
46332012-04-13 Reuben Thomas <rrt@sc3d.org>
4634
4635 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4636
0fc59f1e
DC
46372012-04-11 Daniel Colascione <dancol@dancol.org>
4638
4639 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4640 against is gone. It's better to use vfork now so that when Cygwin
4641 gains a new, working vfork, we use it automatically (bug#10398).
4642
de8c03dc
SM
46432012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4644
4645 * window.c (save_window_save): Obey window-point-insertion-type.
4646
2f097256
GM
46472012-04-11 Glenn Morris <rgm@gnu.org>
4648
4649 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4650
453b951e
SM
46512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4652
4653 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4654
75f1671a 46552012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4656
4657 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4658 (force_quit_count): New var.
4659 (handle_interrupt): Use it.
4660
2a8ce227
JB
46612012-04-10 Juanma Barranquero <lekktu@gmail.com>
4662
4663 * w32.c (w32_delayed_load): Record the full path of the library
4664 being loaded (bug#10424).
4665
935396c0
GM
46662012-04-09 Glenn Morris <rgm@gnu.org>
4667
05920a43
GM
4668 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4669 not just in the obarray, before snarfing them. (Bug#11036)
4670
935396c0
GM
4671 * Makefile.in ($(leimdir)/leim-list.el):
4672 Pass EMACS rather than BUILT_EMACS.
4673
a18ecafa
TZ
46742012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4675
4676 * process.c (make_process):
4677 * process.h: Add integer `gnutls_handshakes_tried' member to
4678 process struct.
4679
6bbef4e5
JC
4680 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4681 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4682
4683 * gnutls.c (gnutls_log_function2i): Convenience log function.
4684 (emacs_gnutls_read): Use new log functions,
4685 `gnutls_handshakes_tried' process member, and
4686 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4687 attempts per process (connection).
4688
b4d3bc10
CY
46892012-04-09 Chong Yidong <cyd@gnu.org>
4690
4691 * eval.c (Fuser_variable_p, user_variable_p_eh)
4692 (lisp_indirect_variable): Functions deleted.
4693 (Fdefvar): Caller changed.
4694
4695 * callint.c (Finteractive, Fcall_interactively):
4696 * minibuf.c (Fread_variable): Callers changed.
4697
70f4d973
EZ
46982012-04-09 Eli Zaretskii <eliz@gnu.org>
4699
4700 * xdisp.c (set_cursor_from_row): If the display string appears in
4701 the buffer at position that is closer to point than the position
4702 after the display string, display the cursor on the first glyph of
4703 the display string. Fixes cursor display when a 'display' text
4704 property immediately follows invisible text. (Bug#11094)
4705
cb3c2e3e
PE
47062012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4707
4708 composite.c: use 'double' consistently
4709 * composite.c (get_composition_id): Use 'double' consistently
4710 instead of converting 'float' to 'double' and vice versa; this is
4711 easier to understand and avoids a GCC warning.
4712
fd06db5d
GM
47132012-04-09 Glenn Morris <rgm@gnu.org>
4714
50fe702a
GM
4715 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4716 preparation for dumping it with emacs. (Bug#4789)
4717 (leimdir): New variable.
4718 ($(leimdir)/leim-list.el): New rule.
4719 (emacs$(EXEEXT)): Depend on leim-list.el.
4720
fd06db5d
GM
4721 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4722 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4723 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4724
55c131ee
AS
47252012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4726
4727 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4728 proper alignment.
4729
9209588f
JB
47302012-04-07 Juanma Barranquero <lekktu@gmail.com>
4731
4732 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4733 Remove unused local variable.
4734
e3fb2efb
PE
47352012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4736
4737 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4738 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4739 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4740 objects, as mark_maybe_pointer will catch them otherwise.
4741 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4742 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4743
b5385551
PE
47442012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4745
4746 Fix typo that broke non-Windows builds.
4747 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4748
9078ead6
EZ
47492012-04-07 Eli Zaretskii <eliz@gnu.org>
4750
4751 Support building on MS-Windows with libxml2.
4752
4753 * makefile.w32-in (OBJ2): Add xml.$(O).
4754 (GLOBAL_SOURCES): Add xml.c.
4755 ($(BLD)/xml.$(O)): New dependency list.
4756
4757 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4758 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4759 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4760 [!WINDOWSNT]: New macros.
4761 (init_libxml2_functions, libxml2_loaded_p): New functions.
4762 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4763 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4764 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4765 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4766 linked in).
6bbef4e5
JC
4767 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4768 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4769 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4770
4771 * emacs.c: Don't include libxml/parser.h.
4772 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4773 xmlCleanupParser directly.
4774
4775 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4776
3811fdf3
EZ
47772012-04-07 Eli Zaretskii <eliz@gnu.org>
4778
4779 * indent.c (Fvertical_motion): If there is a display string at
4780 point, use it.vpos to compute how many lines to backtrack after
4781 move_it_to point. (Bug#11133)
4782
2f8e16b2
EZ
47832012-04-06 Eli Zaretskii <eliz@gnu.org>
4784
4785 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4786 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4787 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4788 macros related to unification of CJK characters. For the details,
4789 see the discussion following the message here:
4790 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4791
3d439cd1
CY
47922012-04-04 Chong Yidong <cyd@gnu.org>
4793
4794 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4795
8bc53d00
EZ
47962012-04-01 Eli Zaretskii <eliz@gnu.org>
4797
4798 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4799 instead of alloca. (Bug#11138)
4800
3b0512a3
AS
48012012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4802
4803 * w32menu.c (is_simple_dialog): Properly check lisp types.
4804 (Bug#11141)
4805
8427ddd2
EZ
48062012-03-31 Eli Zaretskii <eliz@gnu.org>
4807
979022ef
EZ
4808 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4809 position we get to after a call to move_it_to fails the
4810 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4811 only if we wind up in a string from display property. (Bug#11063)
4812
a6b1c7cc
EZ
4813 * window.c (Fdelete_other_windows_internal): Invalidate the row
4814 and column information about mouse highlight, so that redisplay
4815 restores it after reallocating the glyph matrices. (Bug#7464)
4816
8427ddd2
EZ
4817 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4818 string comes from a `display' text property, use the buffer
4819 position of that property as if we actually saw that position in
4820 the row's glyphs.
697ba24b
EZ
4821 (move_it_by_lines): Remove the assertion that
4822 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4823 violated when there's a before-string at the beginning of a line.
4824 (Bug#11063)
8427ddd2 4825
65a0a738
EZ
48262012-03-30 Eli Zaretskii <eliz@gnu.org>
4827
4828 * xdisp.c (append_space_for_newline): If the default face was
4829 remapped, use the remapped face for the appended newline.
4830 (extend_face_to_end_of_line): Use the remapped default face for
4831 extending the face to the end of the line.
4832 (display_line): Call extend_face_to_end_of_line when the default
4833 face was remapped. (Bug#11068)
4834
581355cc
EZ
48352012-03-29 Eli Zaretskii <eliz@gnu.org>
4836
4837 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4838
e8fc049f
SM
48392012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4840
4841 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4842
4fb9a543
GM
48432012-03-27 Glenn Morris <rgm@gnu.org>
4844
4845 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4846 Doc fixes.
4847
679910f1
KH
48482012-03-26 Kenichi Handa <handa@m17n.org>
4849
4850 * dispextern.h (struct glyph): Fix previous change. Change the
4851 bit length of glyphless.ch to 25 (Bug#11082).
4852
90d49b7f
CY
48532012-03-26 Chong Yidong <cyd@gnu.org>
4854
4855 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4856 (command_loop_1): Use it; inhibit selection update for
4857 handle-select-window too (Bug#8996).
4858
f514f6f0
FP
48592012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4860
e8fc049f 4861 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4862
bf43fa51
KH
48632012-03-25 Kenichi Handa <handa@m17n.org>
4864
4865 * dispextern.h (struct glyph): Change the bit length of
4866 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4867
8a0c01dd
EZ
48682012-03-24 Eli Zaretskii <eliz@gnu.org>
4869
4870 * s/ms-w32.h (tzname): Include time.h before redirecting to
4871 _tzname. Fixes the MSVC build. (Bug#9960)
4872
7d1c3a76
AS
48732012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4874
8ed79523
AS
4875 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4876 characters.
4877
7d1c3a76
AS
4878 * xterm.c (XTread_socket): Only modify handling_signal if
4879 !SYNC_INPUT. (Bug#11080)
4880
e99a9b8b
EZ
48812012-03-23 Eli Zaretskii <eliz@gnu.org>
4882
4883 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4884 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4885 when fetching a multibyte character consumes more bytes than
4886 CHAR_BYTES returns, due to unification of CJK characters in
4887 string_char. (Bug#11073)
4888
5063c0e1
TN
48892012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4890
4891 * process.c (wait_reading_process_output): Handle pty disconnect
4892 by refraining from sending oneself a SIGCHLD (bug#10933).
4893
9f851fbd
CY
48942012-03-22 Chong Yidong <cyd@gnu.org>
4895
4896 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4897
5063c0e1 4898 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4899 Mark string as coming from a prefix property.
4900 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4901 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4902
fb5b8aca
CY
49032012-03-21 Chong Yidong <cyd@gnu.org>
4904
4905 * xfaces.c (Vface_remapping_alist): Doc fix.
4906
62356a1b
EZ
49072012-03-20 Eli Zaretskii <eliz@gnu.org>
4908
4909 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4910 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4911 Doc fixes.
62356a1b 4912
025de85b
CY
49132012-03-20 Chong Yidong <cyd@gnu.org>
4914
4915 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4916 to reflect default non-nil value of redisplay-dont-pause.
4917
4827f94e
KH
49182012-03-19 Kenichi Handa <handa@m17n.org>
4919
4920 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4921 it fit in a valid range (Bug#11003).
4922
e50a24a2
EZ
49232012-03-18 Eli Zaretskii <eliz@gnu.org>
4924
4925 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4926 that is not from display property, accept the row as a "cursor
4927 row" if one of the string's character has a non-nil `cursor'
4928 property. Fixes cursor positioning when there are newlines in
4929 overlay strings, e.g. in icomplete.el. (Bug#11035)
4930
9af5ed87
PE
49312012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4932
4933 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4934
d1f55f16
CY
49352012-03-12 Chong Yidong <cyd@gnu.org>
4936
4937 * eval.c (inhibit_lisp_code): Rename from
4938 inhibit_window_configuration_change_hook; move from window.c.
4939
4940 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4941 * window.c (run_window_configuration_change_hook)
4942 (syms_of_window): Callers changed.
4943
66c5eebd
CY
49442012-03-11 Chong Yidong <cyd@gnu.org>
4945
413df973
CY
4946 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4947
66c5eebd
CY
4948 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4949
1de11f56
CY
49502012-03-10 Chong Yidong <cyd@gnu.org>
4951
4952 * frame.c (other_visible_frames): Don't assume the selected frame
4953 is visible (Bug#10955).
4954
cae07000
SM
49552012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4956
4957 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4958
89c94350
JD
49592012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4960
4961 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4962 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4963 zero (Bug#10954).
4964
999dd333
GM
49652012-03-03 Glenn Morris <rgm@gnu.org>
4966
01a6dcc8 4967 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4968
de0100f2
EZ
49692012-03-02 Eli Zaretskii <eliz@gnu.org>
4970
4971 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4972 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4973 (redisplay_window, next_element_from_string): Fix typos in
4974 comments.
3e441275
EZ
4975 (redisplay_window): Pass to move_it_vertically the margin in
4976 pixels, not in screen lines.
de0100f2 4977
96a72ee9
GM
49782012-03-02 Glenn Morris <rgm@gnu.org>
4979
4980 * buffer.c (buffer-list-update-hook): Doc fix.
4981
312508d7
EZ
49822012-02-29 Eli Zaretskii <eliz@gnu.org>
4983
4984 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4985 push_it before setting up the iterator for the first overlay
4986 string, even if we have an empty string loaded.
4987 (next_overlay_string): If there's an empty string on the iterator
4988 stack, pop the stack. (Bug#10903)
4989
27f3c637
PE
49902012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4991
4992 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4993 Suggested by Stefan Monnier in
4994 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4995 * alloc.c (widen_to_Lisp_Object): New static function.
4996 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4997 and widening them to Lisp_Objects. This would work even if
4998 USE_LSB_TAG is defined and wide integers are used, which might
4999 happen in a future version of Emacs.
5000
3c9dfce6
CY
50012012-02-25 Chong Yidong <cyd@gnu.org>
5002
fa74b241
CY
5003 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5004 Doc fix.
5005
3c9dfce6
CY
5006 * xselect.c (Fx_selection_exists_p): Doc fix.
5007 (x_clipboard_manager_save_all): Print an informative message
5008 before saving to clipboard manager.
5009
9486df08
CY
50102012-02-24 Chong Yidong <cyd@gnu.org>
5011
5012 * keyboard.c (process_special_events): Handle all X selection
5013 requests in kbd_buffer, not just the next one (Bug#8869).
5014
f01d3321
CY
50152012-02-23 Chong Yidong <cyd@gnu.org>
5016
5017 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5018 call when setting menu-bar-lines and tool-bar-lines parameters.
5019 (unwind_create_frame_1): New helper function.
5020
5021 * window.c (inhibit_window_configuration_change_hook): New var.
5022 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5023 (syms_of_window): Initialize it.
f01d3321 5024
86b847b6
CY
50252012-02-22 Chong Yidong <cyd@gnu.org>
5026
5027 * xterm.c (x_draw_image_relief): Add missing type check for
5028 Vtool_bar_button_margin (Bug#10743).
5029
a59225b1
CY
50302012-02-21 Chong Yidong <cyd@gnu.org>
5031
5032 * fileio.c (Vfile_name_handler_alist): Doc fix.
5033
5034 * buffer.c (Fget_file_buffer): Protect against invalid file
5035 handler return value.
5036
310f5bd4
PE
50372012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5038
cb3a28cc
PE
5039 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5040 when computing $valmask.
5041
310f5bd4
PE
5042 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5043 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5044 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5045 It's useless in that case, and it can cause problems on hosts
5046 that allocate halves of EMACS_INT values separately.
5047 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5048 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5049 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5050 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5051 it avoids undefined behavior on hosts where shifting right by more
5052 than the word width has undefined behavior.
5053
2375c96a
CY
50542012-02-19 Chong Yidong <cyd@gnu.org>
5055
5056 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5057 (Funhandled_file_name_directory, Ffile_name_as_directory)
5058 (Fdirectory_file_name, Fexpand_file_name)
5059 (Fsubstitute_in_file_name): Protect against invalid file handler
5060 return values (Bug#10845).
5061
3eb49e71
EZ
50622012-02-18 Eli Zaretskii <eliz@gnu.org>
5063
5064 * .gdbinit (pitx): Fix incorrect references to fields of the
5065 iterator stack.
5066
7b926f3f
CY
50672012-02-17 Chong Yidong <cyd@gnu.org>
5068
5069 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5070
11273115
PE
50712012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5072
5073 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5074 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5075
c3a70e2b
CY
50762012-02-15 Chong Yidong <cyd@gnu.org>
5077
5078 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5079 marked as special. Also, starting docstrings with * is obsolete.
5080
0ca43699
AS
50812012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5082
5083 * gnutls.c (emacs_gnutls_write): Fix last change.
5084
2e8f3c56
LI
50852012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5086
5087 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5088 send_process.
5089
af70074f
SM
50902012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5091
5092 * keymap.c (Fsingle_key_description): Handle char ranges.
5093
95986d52
CY
50942012-02-12 Chong Yidong <cyd@gnu.org>
5095
afd83bd1
CY
5096 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5097 as that creates a dangerous corner case.
5098
95986d52
CY
5099 * window.c (Fdelete_window_internal): Invalidate the mouse
5100 highlight (Bug#9904).
5101
bd7da63e
GM
51022012-02-12 Glenn Morris <rgm@gnu.org>
5103
5104 * xselect.c (Fx_own_selection_internal)
5105 (Fx_get_selection_internal, Fx_disown_selection_internal)
5106 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5107 * nsselect.m (Fx_own_selection_internal)
5108 (Fx_disown_selection_internal, Fx_selection_exists_p)
5109 (Fx_selection_owner_p, Fx_get_selection_internal):
5110 Sync docs and argument specs with the xselect.c versions.
5111
77abcbc2
LI
51122012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5113
5114 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5115
90b671e2
EZ
51162012-02-11 Eli Zaretskii <eliz@gnu.org>
5117
1c0ca0b7
EZ
5118 * w32select.c (Fx_selection_exists_p): Sync doc string and
5119 argument list with xselect.c. (Bug#10783)
5120
5121 * w16select.c (Fx_selection_exists_p): Sync doc string and
5122 argument list with xselect.c. (Bug#10783)
90b671e2 5123
49241268
GM
51242012-02-10 Glenn Morris <rgm@gnu.org>
5125
5126 * fns.c (Fsecure_hash): Doc fix.
5127
f998bbe7 51282012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5129
5130 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5131
0992bd9c
CY
51322012-02-07 Chong Yidong <cyd@gnu.org>
5133
5134 * buffer.c (Fbuffer_local_variables)
5135 (buffer_lisp_local_variables): Handle unbound vars correctly;
5136 don't let Qunbound leak into Lisp.
5137
af008560
GM
51382012-02-07 Glenn Morris <rgm@gnu.org>
5139
dd605cc4
GM
5140 * image.c (Fimagemagick_types): Doc fix.
5141
af008560
GM
5142 * image.c (imagemagick-render-type): Change it from a lisp object
5143 to an integer. Move the doc here from the lisp manual.
5144 Treat all values not equal to 0 the same.
5145
1449fa1d
CY
51462012-02-06 Chong Yidong <cyd@gnu.org>
5147
5148 * doc.c (store_function_docstring): Avoid applying docstring of
5149 alias to base function (Bug#2603).
5150
3723ec07
AS
51512012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5152
5153 * .gdbinit (pp1, pv1): Remove redundant defines.
5154 (pr): Use pp.
5155
79c1cc1e
CY
51562012-02-04 Chong Yidong <cyd@gnu.org>
5157
5158 * nsterm.m: Declare a global (Bug#10694).
5159
d7f29f8e
EZ
51602012-02-04 Eli Zaretskii <eliz@gnu.org>
5161
cae07000
SM
5162 * w32.c (get_emacs_configuration_options):
5163 Include --enable-checking, if specified, in the return value.
d7f29f8e 5164
3b95a6f9
MR
51652012-02-04 Martin Rudalics <rudalics@gmx.at>
5166
5167 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5168 after rounding frame sizes. (Bug#9723)
5169
d6fa96a6
EZ
51702012-02-04 Eli Zaretskii <eliz@gnu.org>
5171
5172 * keyboard.c (adjust_point_for_property): Don't position point
5173 before BEGV. (Bug#10696)
5174
df0b2940
PE
51752012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5176
5177 Handle overflow when computing char display width (Bug#9496).
5178 * character.c (char_width): Return EMACS_INT, not int.
5179 (char_width, c_string_width): Check for overflow when
5180 computing the width; this is possible now that individual
5181 characters can have unbounded width. Problem introduced
5182 by merge from Emacs 23 on 2012-01-19.
5183
6bee44d6
MA
51842012-02-02 Michael Albinus <michael.albinus@gmx.de>
5185
5186 * dbusbind.c (Fdbus_register_method): Mention the return value
5187 :ignore in the docstring.
5188
44f92739
GM
51892012-02-02 Glenn Morris <rgm@gnu.org>
5190
1b9f60cc
GM
5191 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5192
44f92739
GM
5193 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5194 Unconditionally set to t. (Bug#10673)
5195 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5196 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5197 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5198
c5d3843c
KH
51992012-02-02 Kenichi Handa <handa@m17n.org>
5200
5201 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5202 0, do not call append_composite_glyph.
5203
159462d4 52042012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5205
5206 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5207 NULL (Bug#6988).
5208 (x_produce_glyphs): If the component of a composition is a null
5209 string, set it->pixel_width to 1 to avoid zero-width glyph.
5210
78cef877
EZ
52112012-02-01 Eli Zaretskii <eliz@gnu.org>
5212
5213 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5214 first 2 arguments are identical. This makes inserting large
5215 output from a subprocess an order of magnitude faster on
5216 MS-Windows, where all sbrk'ed memory is always contiguous.
5217
97897668
GM
52182012-01-31 Glenn Morris <rgm@gnu.org>
5219
5220 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5221 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5222 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5223
31fd3586
GM
52242012-01-29 Glenn Morris <rgm@gnu.org>
5225
5226 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5227
0e24a8b2
CY
52282012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5229
5230 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5231
cc0adcb0
CY
52322012-01-28 Chong Yidong <cyd@gnu.org>
5233
5234 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5235
acc28cb9
CY
52362012-01-26 Chong Yidong <cyd@gnu.org>
5237
9c69cfb7
CY
5238 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5239
acc28cb9
CY
5240 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5241 repeat counts (Bug#10507).
5242
48da7392
GM
52432012-01-26 Glenn Morris <rgm@gnu.org>
5244
5245 * lread.c (syms_of_lread): Doc fix.
5246
14af5f7f
CY
52472012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5248
5249 * coding.c (encode_designation_at_bol): Change return value to
5250 EMACS_INT.
5251
0b21c100
CY
52522012-01-25 Chong Yidong <cyd@gnu.org>
5253
5254 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5255
3c2907f7
CY
52562012-01-21 Chong Yidong <cyd@gnu.org>
5257
5258 * floatfns.c (Fcopysign): Make the second argument non-optional,
5259 since nil is not allowed anyway.
5260
959ad23f
AS
52612012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5262
5263 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5264 (send_process): Likewise.
5265
34a02f46
MR
52662012-01-19 Martin Rudalics <rudalics@gmx.at>
5267
5268 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5269 (Vwindow_persistent_parameters): Do not use Qstate.
5270 Rewrite doc-strings.
34a02f46 5271
1259009a 52722012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5273
5274 * character.c (char_width): New function.
70d4fdf6
GM
5275 (Fchar_width, c_string_width, lisp_string_width):
5276 Use char_width (Bug#9496).
25ed9e61 5277
6a6ee00d
MR
52782012-01-16 Martin Rudalics <rudalics@gmx.at>
5279
5280 * window.c (Vwindow_persistent_parameters): New variable.
5281 (Fset_window_configuration, save_window_save): Handle persistent
5282 window parameters.
5283
c85efaf7
EZ
52842012-01-14 Eli Zaretskii <eliz@gnu.org>
5285
5286 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5287 thrashing the stack of the thread. (Bug#9087)
5288
5944709e
PE
52892012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5290
5291 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5292
e71f5d99
EZ
52932012-01-11 Eli Zaretskii <eliz@gnu.org>
5294
5295 * xdisp.c (rows_from_pos_range): Handle the case where the
5296 highlight ends on a newline. (Bug#10464)
5297 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5298 he end column for display of highlight that ends on a newline
5299 before a R2L line.
5300
ce316182
GM
53012012-01-11 Glenn Morris <rgm@gnu.org>
5302
5303 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5304 from load-path also when installation-directory is nil. (Bug#10208)
5305
5b43da69
GM
53062012-01-10 Glenn Morris <rgm@gnu.org>
5307
74cc8ff9
GM
5308 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5309
7d8d6e4e
GM
5310 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5311 Update template values to be closer to their typical values these days.
5b43da69 5312
a0db8d43
EZ
53132012-01-09 Eli Zaretskii <eliz@gnu.org>
5314
5315 * xdisp.c (rows_from_pos_range): Accept additional argument
5316 DISP_STRING, and accept any glyph in a row whose object is that
5317 string as eligible for mouse highlight. Fixes mouse highlight of
5318 display strings from overlays. (Bug#10464)
5319
9a0115ab 53202012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5321
b9110d6a 5322 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5323 * fileio.c (auto_saving_dir_umask): New static var.
5324 (Fmake_directory_internal): Use it.
5325 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5326 creating the directory. The old code temporarily assigns
5327 too-generous permissions to the directory.
5328 (do_auto_save_eh): Clear it.
b9110d6a 5329 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5330 that the var is always cleared.
5331
6c1bd3f3
EZ
53322012-01-07 Eli Zaretskii <eliz@gnu.org>
5333
5334 * search.c (scan_buffer): Pass character positions to
5335 know_region_cache, not byte positions. (Bug#6540)
5336
069d2b50
L
53372012-01-07 LynX <_LynX@bk.ru> (tiny change)
5338
5339 * w32.c (sys_rename): Report EXDEV when rename of a directory
5340 fails because the target is on another logical disk. (Bug#10284)
5341
75bf0d33
DB
53422012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5343
5344 * xterm.c (x_embed_request_focus): New function.
5345
5346 * xterm.h: Add prototype.
5347
5348 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5349
1c6e5a32
GM
53502012-01-05 Glenn Morris <rgm@gnu.org>
5351
5352 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5353
651e947e
EZ
53542012-01-01 Eli Zaretskii <eliz@gnu.org>
5355
5356 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5357 Load gnutls_transport_set_lowat only if GnuTLS version is below
5358 2.11.1.
5359 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5360 GnuTLS versions below 2.11.1.
5361
3778cdd8
AL
53622011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5363
5364 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5365 to the doc string advising against its use for altering the way
5366 windows are scrolled.
5367
0e5317f7
KH
53682011-12-28 Kenichi Handa <handa@m17n.org>
5369
5370 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5371 coding-system ASCII compatible only when it does not produce BOM
5372 on encoding (Bug#10383).
5373
93d5ca1f
JD
53742011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5375
5376 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5377 can scroll.
5378 (create_and_show_popup_menu): Always use menu_position_func for
5379 Gtk3 (Bug#10361).
5380
ca22b785
AS
53812011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5382
5383 * callint.c (Fcall_interactively): Don't truncate prompt string.
5384
d048e1e6
EZ
53852011-12-23 Eli Zaretskii <eliz@gnu.org>
5386
5387 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5388 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5389 resumed from there (after widening). (Bug#10360)
d048e1e6 5390
5ccaba1f
JD
53912011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5392
5393 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5394
204ee57f
JD
53952011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5396
b81d40f0
JB
5397 * nsterm.m (x_free_frame_resources):
5398 Release f->output_data.ns->miniimage.
204ee57f
JD
5399 (ns_index_color): Fix indentation. Do not retain
5400 color_table->colors[i].
5401
5402 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5403 before returning.
5404
5405 * nsfns.m (x_set_background_color): Assign return value from
5406 ns_index_color to face-background instead of NSColor*.
5407 (ns_implicitly_set_icon_type): Fix indentation.
5408 Change assignment in for loop to comparison.
5409
5410 * emacs.c (ns_pool): New variable.
5411 (main): Assign ns_pool.
5412 (Fkill_emacs): Call ns_release_autorelease_pool.
5413
5414 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5415 autorelease fdesc, release fdAttrs and tdict.
5416 (ns_get_covering_families): Release charset.
5417 (ns_findfonts): Release NSFontDescriptor created with new.
5418 (ns_uni_to_glyphs): Fix indentation.
5419 (setString): Release attrStr before assigning new value.
5420
c803b2b7
JD
54212011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5422
678f4426
JD
5423 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5424 and NS_IMPL_COCOA.
5425 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5426 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5427
cd394be1 54282011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5429
5fecd5fc
JD
5430 * nsterm.m (ns_term_init): Subscribe for notifications
5431 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5432 to method trackingNotification in EmacsMenu.
5433
5434 * nsmenu.m (trackingMenu): New variable.
3771cb17 5435 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5436 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5437 from Aquamacs (Bug#7030).
678f4426
JD
5438
54392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5440
c803b2b7
JD
5441 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5442 (symbol_to_nsstring): Fix indentation.
5443 (ns_symbol_to_pb): New function.
cae07000
SM
5444 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5445 (Fns_rotate_cut_buffers_internal): Remove.
5446 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5447 Fns_store_cut_buffer_internal.
5448 (ns_get_foreign_selection, Fx_own_selection_internal)
5449 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5450 (Fns_get_selection_internal, Fns_store_selection_internal):
5451 Use ns_symbol_to_pb and check if return value is nil.
5452 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5453 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5454 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5455 renamed to Sns_store_selection_internal.
5456 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5457 and remove this function.
5458 (ns_handle_selection_clear): Remove, never used.
5459 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5460 here.
5461
e1b01a3a
KB
54622011-12-17 Ken Brown <kbrown@cornell.edu>
5463
5464 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5465 GID is unknown (Bug#10257).
5466
2adb6e85
PE
54672011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5468
5469 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5470 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5471 which caused a build failure on GNU/Linux IA-64. This problem was
5472 introduced by my 2011-10-07 patch.
5473
d1d7b339
JL
54742011-12-15 Juri Linkov <juri@jurta.org>
5475
5476 * image.c (imagemagick_error): New function. (Bug#10112)
5477 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5478 Use `imagemagick_error' where ImageMagick functions return
5479 `MagickFalse'.
5480 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5481 proper order.
5482
100d5755
KH
54832011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5484
5485 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5486 fill background (Bug#8992).
5487
454592a6
MR
54882011-12-13 Martin Rudalics <rudalics@gmx.at>
5489
5490 * window.c (Vwindow_combination_resize)
5491 (Vwindow_combination_limit): Use t instead of non-nil in
5492 doc-strings.
61d4b438
MR
5493 (Vrecenter_redisplay): Add first sentence of doc-string on
5494 separate line.
53524d93 5495 (Frecenter): Fix doc-string typo.
454592a6 5496
3633e3aa
KH
54972011-12-11 Kenichi Handa <handa@m17n.org>
5498
5499 * coding.c (Funencodable_char_position): Pay attention to the
5500 buffer text relocation (Bug#9389).
5501
7b9d523a 55022011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5503
7b9d523a
JD
5504 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5505 gtk_init (Bug#10100).
5506
b73189c6
EZ
55072011-12-10 Eli Zaretskii <eliz@gnu.org>
5508
5509 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5510 IT->string is nil. (Bug#10263)
5511
f7dfe5d6
JD
55122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5513
83faebb4
JD
5514 * nsterm.h (x_free_frame_resources): Declare.
5515
f7dfe5d6
JD
5516 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5517 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5518
5519 * nsterm.h (ns_get_defaults_value): Declare.
5520
5521 * nsterm.m (ns_default): Call ns_get_defaults_value.
5522
7cd4e72c
EZ
55232011-12-09 Eli Zaretskii <eliz@gnu.org>
5524
5525 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5526 (Bug#10170)
5527
b34d7317
YM
55282011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5529
5530 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5531 that where the value of an _OBJC_* symbol points to is in the .bss
5532 section (Bug#10240).
5533
76470ad1
KH
55342011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5535
5536 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5537 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5538
745fff94
KH
55392011-12-08 Kenichi Handa <handa@m17n.org>
5540
5541 * ftfont.c (get_adstyle_property): Fix previous change
5542 (Bug#10233).
5543
6e44397c
JB
55442011-12-07 Juanma Barranquero <lekktu@gmail.com>
5545
5546 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5547 dirs from the default value of EMACSLOADPATH (bug#10208).
5548
7efa6272
GM
55492011-12-07 Glenn Morris <rgm@gnu.org>
5550
5551 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5552 installation and source directories as well. (Bug#10208)
5553
f6fc4d87
CY
55542011-12-06 Chong Yidong <cyd@gnu.org>
5555
5556 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5557
2bf26180
GM
55582011-12-06 Glenn Morris <rgm@gnu.org>
5559
5560 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5561 as an error, not just -1. (Bug#10217)
5562
3a6ad4f0
CY
55632011-12-05 Chong Yidong <cyd@gnu.org>
5564
5565 * keyboard.c (process_special_events): New function.
5566 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5567
75a3b399
PE
55682011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5569
5570 * coding.c (encode_designation_at_bol): Don't use uninitialized
5571 local variable (Bug#9318).
5572
c3c9e25e
KH
55732011-12-05 Kenichi Handa <handa@m17n.org>
5574
5575 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5576 return Qnil (Bug#8046, Bug#10193).
5577
5eb05ea3
KH
55782011-12-05 Kenichi Handa <handa@m17n.org>
5579
5580 * coding.c (encode_designation_at_bol): New args charbuf_end and
5581 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5582 (coding_set_source): Return how many bytes coding->source was
5583 relocated.
5584 (coding_set_destination): Return how many bytes
5585 coding->destination was relocated.
5586 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5587 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5588
55892011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5590
5591 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5592 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5593 macro (Bug#9318).
5594
55952011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5596
5597 The following changes are to fix Bug#9318.
5598
a79703f5 5599 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5600 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5601 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5602 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5603
7dbda6df
JB
56042011-12-05 Juanma Barranquero <lekktu@gmail.com>
5605
5606 * lisp.h (process_quit_flag): Fix external declaration.
5607
6d5eb5b0
SM
56082011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5609
5610 Don't macro-inline non-performance-critical code.
5611 * eval.c (process_quit_flag): New function.
5612 * lisp.h (QUIT): Use it.
5613
a0c3fad0
JD
56142011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5615
5616 * nsfns.m (get_geometry_from_preferences): New function.
5617 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5618
6c07aac2
AS
56192011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5620
5621 * emacs.c (Qkill_emacs): Define.
5622 (syms_of_emacs): Initialize it.
5623 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5624 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5625 (quit_throw_to_read_char): Add parameter `from_signal'.
5626 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5627 * lisp.h (QUIT): Call Fkill_emacs if requested.
5628
c052ead4
JD
56292011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5630
5631 * widget.c (update_wm_hints): Return if wmshell is null.
5632 (widget_update_wm_size_hints): New function.
5633
5634 * widget.h (widget_update_wm_size_hints): Declare.
5635
5636 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5637 widget_update_wm_size_hints (Bug#10104).
5638
9e49252b
EZ
56392011-12-03 Eli Zaretskii <eliz@gnu.org>
5640
5641 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5642 before a newline, prepare the bidi iterator for consuming the
5643 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5644 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5645
02b16839
JL
56462011-12-02 Juri Linkov <juri@jurta.org>
5647
5648 * search.c (Fword_search_regexp): New Lisp function created from
5649 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5650 (Fword_search_backward, Fword_search_forward)
5651 (Fword_search_backward_lax, Fword_search_forward_lax):
5652 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5653 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5654
0068070e
SM
56552011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5656
5657 * fileio.c (Finsert_file_contents): Move after-change-function call
5658 to before the "handled:" label, since all "goto handled" appear in
5659 cases where the *-change-functions have already been properly called
5660 (bug#10117).
5661
3360a3fc
AS
56622011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5663
5664 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5665 waiting for input. (Bug#10169)
5666
73d6c093
EZ
56672011-11-30 Eli Zaretskii <eliz@gnu.org>
5668
5669 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5670 verifies glyph row's hash code--we have just reallocated the
5671 glyphs, so their contents can be complete garbage. (Bug#10164)
5672
febe6bea
JB
56732011-11-30 Juanma Barranquero <lekktu@gmail.com>
5674
5675 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5676
801a4313
EZ
56772011-11-30 Eli Zaretskii <eliz@gnu.org>
5678
5679 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5680 attributes are tested _before_ calling verify_row_hash, to protect
5681 against GCC re-ordering of the tests. (Bug#10164)
5682
2b56b87e
JD
56832011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5684
5685 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5686
5687 * xterm.c (handle_one_xevent): Only set async_visible and friends
5688 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5689 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5690 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5691
dbf31225
PE
56922011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5693
5694 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5695 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5696 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5697 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5698 All uses changed to use GCPRO1 etc.
5699 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5700 Revert to old implementation (i.e., before 2011-03-11).
5701
1305621b
YM
57022011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5703
5704 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5705 of scroll runs so as to avoid assigning disabled bogus rows and
5706 unnecessary graphics copy operations.
5707
8c9afb46
EZ
57082011-11-27 Eli Zaretskii <eliz@gnu.org>
5709
5710 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5711 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5712 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5713 (malloc, free, realloc, calloc): Redirect to e_* only when
5714 compiling Emacs.
5715
5716 * lisp.h (GCTYPEBITS): Move before first use.
5717 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5718 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5719 this macro definition.
5720
5721 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5722 _MSC_VER.
5723
54e9e3bf
JD
57242011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5725
6d5eb5b0
SM
5726 * gtkutil.c (xg_create_frame_widgets):
5727 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5728 present with Gtk+ 2.0.
5729
83aca1cb
PE
57302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5731
5732 * fileio.c (Finsert_file_contents): Undo previous change; see
5733 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5734
5b76caa4
PE
57352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5736
5737 Rename locals to avoid shadowing.
5738 * fileio.c (Finsert_file_contents):
5739 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5740 * process.c (wait_reading_process_output):
5741 Rename inner 'proc' to 'p' to avoid shadowing.
5742 Indent for consistency with usual Emacs style.
5743
8c535114
EZ
57442011-11-25 Eli Zaretskii <eliz@gnu.org>
5745
5746 * xdisp.c (redisplay_window): If cursor row is not fully visible
5747 after recentering, and scroll-conservatively is set to a large
5748 number, scroll window by a few more lines to make the cursor fully
5749 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5750 (start_display): Don't move to the next line if the display should
5751 start at a newline that is part of a display vector or an overlay
5752 string. (Bug#10119)
8c535114 5753
fa4fdb5c
JL
57542011-11-24 Juri Linkov <juri@jurta.org>
5755
5756 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5757 after the `MagickPingImage' call. (Bug#10112)
5758
90ec88df
CY
57592011-11-23 Chong Yidong <cyd@gnu.org>
5760
5761 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5762
56e2e794
MR
57632011-11-23 Martin Rudalics <rudalics@gmx.at>
5764
5765 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5766 making another buffer current. (Bug#10114)
5767
b6e64c41
GM
57682011-11-23 Glenn Morris <rgm@gnu.org>
5769
5770 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5771
6b21de18
CY
57722011-11-23 Chong Yidong <cyd@gnu.org>
5773
5774 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5775 using it (Bug#5984).
5776
b12cd789
EZ
57772011-11-22 Eli Zaretskii <eliz@gnu.org>
5778
5779 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5780 and header-lines, as they don't have one computed for them.
5781 (Bug#10098)
5782
5783 * .gdbinit (prow): Make displayed values more self-explaining.
5784 Add row's hash code.
5785
261b6fd4
LMI
57862011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5787
5788 * process.c (wait_reading_process_output): Fix asynchrounous
5789 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5790 (wait_reading_process_output): Add comment and URL.
261b6fd4 5791
e7cfd277
JD
57922011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5793
5794 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5795
a9b9b7f5
CY
57962011-11-21 Chong Yidong <cyd@gnu.org>
5797
5798 * window.c (Fnext_window, Fprevious_window): Doc fix.
5799
b0d15b4f
SM
58002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5801
5802 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5803
fe7a3057
JB
58042011-11-20 Juanma Barranquero <lekktu@gmail.com>
5805
5806 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5807
d2999b1a
MR
58082011-11-20 Martin Rudalics <rudalics@gmx.at>
5809
5810 * window.c (Fset_window_combination_limit): Rename argument
5811 STATUS to LIMIT.
5812 (Vwindow_combination_limit): Remove "status" from doc-string.
5813
d5ff9cd0
AS
58142011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5815
5816 * m/ibms390.h: Remove.
5817 * m/ibms390x.h: Don't include "ibms390.h".
5818
a5bb9bd3
SM
58192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5820
5821 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5822 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5823
cd1181db
JB
58242011-11-20 Juanma Barranquero <lekktu@gmail.com>
5825
5826 * casetab.c (Fset_case_table):
5827 * charset.c (Fcharset_after): Fix typos.
5828
615a3b8d 58292011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5830
17e845af
PE
5831 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5832 Otherwise, valgrind does not work on some platforms.
5833 Problem reported by Andreas Schwab in
6a0bf43d
PE
5834 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5835 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5836 is set, removing the need for VIRT_ADDRESS_VARIES.
5837 (PURE_P): Use a more-efficient implementation that needs just one
5838 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5839 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5840 to 4 (xorl, subq, cmpq, setbe).
5841 * alloc.c (pure): Always extern now, since that's the
5842 VIRT_ADDR_VARIES behavior.
5843 (PURE_POINTER_P): Use a single comparison, not two, for
5844 consistency with the new puresize.h.
5845 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5846 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5847 Remove VIRT_ADDR_VARIES no longer needed.
5848
f8fe6f96
EZ
58492011-11-19 Eli Zaretskii <eliz@gnu.org>
5850
5851 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5852 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5853 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5854 behave as if the cursor position were at the window margin.
5855
5856 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5857 and the cursor position is out of bounds, behave as if the cursor
5858 position were at the window margin. (Bug#10075)
5859
df05a53c
CY
58602011-11-18 Chong Yidong <cyd@gnu.org>
5861
5862 * window.c (Fwindow_combination_limit): Make first argument
5863 non-optional, since it is meaningless for live windows like the
5864 selected window.
61ccba97 5865
2071918e
DA
58662011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5867
5868 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5869
b50a28de
SM
58702011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5871
5872 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5873 (graft_intervals_into_buffer): Simplify.
5874
015137db
EZ
58752011-11-18 Eli Zaretskii <eliz@gnu.org>
5876
5877 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5878 hash values of the two rows.
5879 (copy_row_except_pointers): Preserve the used[] arrays and the
5880 hash values of the two rows. (Bug#10035)
68c95424 5881 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5882
5883 * xdisp.c (row_hash): New function, body extracted from
5884 compute_line_metrics.
5885 (compute_line_metrics): Call row_hash, instead of computing the
5886 hash code inline.
5887
5888 * dispnew.c (verify_row_hash): Call row_hash for computing the
5889 hash code of a row, instead of duplicating code from xdisp.c.
5890
5891 * dispextern.h (row_hash): Add prototype.
5892
a2addb04
TH
58932011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5894
5895 * frame.c (delete_frame): Don't delete the terminal when the last
5896 X frame is closed if emacs is built with GTK toolkit.
5897
df85d315
JB
58982011-11-17 Juanma Barranquero <lekktu@gmail.com>
5899
5900 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5901
a0c2d0ae
MR
59022011-11-17 Martin Rudalics <rudalics@gmx.at>
5903
5904 * window.c (Vwindow_splits): Rename to
5905 Vwindow_combination_resize. Suggested by Juri Linkov.
5906 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5907 of Vwindow_splits.
5908
58179cce
JB
59092011-11-16 Juanma Barranquero <lekktu@gmail.com>
5910
7877f373
JB
5911 * nsfns.m (Fns_font_name):
5912 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5913
b6f67890
MR
59142011-11-16 Martin Rudalics <rudalics@gmx.at>
5915
5916 * window.h (window): Rename slot "nest" to "combination_limit".
5917 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5918 (Fset_window_nest): Rename to Fset_window_combination_limit.
5919 (Vwindow_nest): Rename to Vwindow_combination_limit.
5920 (recombine_windows, make_parent_window, make_window)
5921 (Fsplit_window_internal, saved_window)
5922 (Fset_window_configuration, save_window_save): Rename all
5923 occurrences of window_nest to window_combination_limit.
5924
c7015153
JB
59252011-11-15 Juanma Barranquero <lekktu@gmail.com>
5926
5927 * image.c (imagemagick_load_image): Fix typo.
5928
322ad6ec
EZ
59292011-11-14 Eli Zaretskii <eliz@gnu.org>
5930
5931 * xdisp.c (display_line): Move the call to
5932 highlight_trailing_whitespace before the call to
5933 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5934 faces of all the glyphs to compute ROW's hash value.
5935 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5936
f067b8ec
JB
59372011-11-14 Juanma Barranquero <lekktu@gmail.com>
5938
5939 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5940 just return (bug#10044).
5941
1e5b2111
EZ
59422011-11-12 Eli Zaretskii <eliz@gnu.org>
5943
7ef3cbd5
EZ
5944 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5945 with user-defined heap size. Bump the default size of the temacs
5946 heap to 27MB, to avoid memory warning when running temacs.
5947 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5948
1e5b2111
EZ
5949 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5950 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5951 (verify_row_hash) [XASSERTS]: New function.
5952 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5953 that the hash value of glyph rows is correct.
1e5b2111 5954
89d61221
MR
59552011-11-12 Martin Rudalics <rudalics@gmx.at>
5956
5957 * window.h (window): Remove splits slot.
5958 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5959 (Fdelete_other_windows_internal, make_parent_window)
5960 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5961 (Fset_window_configuration, save_window_save): Don't deal with
5962 split status of windows.
5963 (saved_window): Remove splits slot.
5964 (Vwindow_splits): Rewrite doc-string.
5965
97f18cc8
JD
59662011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5967
5968 * xfns.c (unwind_create_frame):
5969 * nsfns.m (unwind_create_frame):
5970 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5971 Vframe_list (Bug#9999).
5972
22a648b4
DA
59732011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5974
0b381c7e 5975 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5976
659afede
KH
59772011-11-11 Kenichi Handa <handa@m17n.org>
5978
5979 * callproc.c (Fcall_process): Set the member dst_multibyte of
5980 process_coding.
5981
9ac0394b
KH
59822011-11-11 Johan Bockgård <bojohan@gnu.org>
5983
5984 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5985 avoid a crash (bug#9496).
5986
2fbdc249
CY
59872011-11-09 Chong Yidong <cyd@gnu.org>
5988
5989 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5990 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5991
ac6b1f81
PE
59922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5993
5994 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5995
09db192c
PE
59962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5997
5998 Avoid some portability problems by eschewing 'extern inline' functions.
5999 The trivial performance wins aren't worth the portability hassles; see
6000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6001 et seq.
6002 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6003 (window_box_width, window_box_left, window_box_left_offset)
6004 (window_box_right, window_box_right_offset): Undo previous change,
6005 by removing the "extern"s.
6006 * intervals.c (adjust_intervals_for_insertion)
6007 (adjust_intervals_for_deletion): Undo previous change,
6008 making these static again.
6009 (offset_intervals, temp_set_point_both, temp_set_point)
6010 (copy_intervals_to_string): No longer inline.
6011 * xdisp.c (window_text_bottom_y, window_box_width)
6012 (window_box_height, window_box_left_offset)
6013 (window_box_right_offset, window_box_left, window_box_right)
6014 (window_box): No longer inline.
6015
105216ed
CY
60162011-11-08 Chong Yidong <cyd@gnu.org>
6017
6018 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6019 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6020 Signal an error if not a live window.
105216ed
CY
6021 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6022 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6023
ae9e237f
JB
60242011-11-07 Juanma Barranquero <lekktu@gmail.com>
6025
6026 * lisp.h (syms_of_abbrev): Remove declaration.
6027 Reported by CHENG Gao <chenggao@royau.me>.
6028
c7aa8333
EZ
60292011-11-07 Eli Zaretskii <eliz@gnu.org>
6030
6031 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6032 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6033 of temacs in GUI mode.
6034
be7f5545
MR
60352011-11-07 Martin Rudalics <rudalics@gmx.at>
6036
6037 * window.h: Declare delete_all_child_windows instead of
6038 delete_all_subwindows.
6039 * window.c (Fwindow_nest, Fset_window_nest)
6040 (Fset_window_new_total, Fset_window_new_normal)
6041 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6042 (delete_all_subwindows): Rename to delete_all_child_windows.
6043 (Fdelete_other_windows_internal, Fset_window_configuration):
6044 Call delete_all_child_windows instead of delete_all_subwindows.
6045 * frame.c (delete_frame): Call delete_all_child_windows instead
6046 of delete_all_subwindows.
6047
ca78dc43
PE
60482011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6049
6050 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6051 This is also needed for porting to any host where GC_MARK_STACK is
6052 not GC_MAKE_GCPROS_NOOPS.
6053 (which_symbols): Use it.
6054
a0241d01
KH
60552011-11-07 Kenichi Handa <handa@m17n.org>
6056
6057 * coding.c (coding_set_destination): Check coding->src_pos only
6058 when coding->src_object is a buffer (bug#9910).
6059
6060 * process.c (send_process): Set the member src_multibyte of coding
6061 to 0 (bug#9911) when sending a unibyte text.
6062
6063 * callproc.c (Fcall_process): Set the member src_multibyte of
6064 process_coding to 0 (bug#9912).
6065
a64bfdfa 60662011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6067
6068 * xmenu.c (cleanup_widget_value_tree): New function.
6069 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6070 calling free_menubar_widget_value_tree directly (Bug#9830).
6071
cb41b32a
PE
60722011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6073
6074 Fix some portability problems with 'inline'.
6075 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6076 (window_box_width, window_box_left, window_box_left_offset)
6077 (window_box_right, window_box_right_offset): Declare extern.
6078 Otherwise, these inline functions do not conform to C99 and
6079 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6080 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6081 * intervals.c (adjust_intervals_for_insertion)
6082 (adjust_intervals_for_deletion): Now extern, because otherwise the
6083 extern inline functions 'offset_intervals' couldn't refer to it.
6084 (static_offset_intervals): Remove.
6085 (offset_intervals): Rewrite using the old contents of
6086 static_offset_intervals. The old version didn't conform to C99
6087 because an extern inline function contained a reference to an
6088 identifier with static linkage.
6089
b7041366
AS
60902011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6091
6092 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6093 GC.
6094
88a37c4d
EZ
60952011-11-06 Eli Zaretskii <eliz@gnu.org>
6096
6097 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6098 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6099 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6100 return Qleft_to_right.
6101
49745b39
CY
61022011-11-06 Chong Yidong <cyd@gnu.org>
6103
6104 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6105 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6106 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6107 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6108 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6109 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6110 (Fwindow_vscroll): Doc fix.
6111 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6112 argument, since it makes no sense to pass a live window and for
6113 consistency with window-child.
6114
1f05cd82
CS
61152011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6116
6117 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6118 support MSVC.
6119
22610910
JR
61202011-11-05 Jason Rumney <jasonr@gnu.org>
6121
6122 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6123 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6124 fonts (Bug#6029).
6125 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6126 bitwise arithmetic preventing use of unicode-sip and non-truetype
6127 opentype fonts.
6128
a06776b2
EZ
61292011-11-05 Eli Zaretskii <eliz@gnu.org>
6130
3ad924ba
EZ
6131 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6132 "emacs"-only part.
6133
a06776b2
EZ
6134 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6135 initialization code to keep similarity to xfns.c after changes
6136 from 2011-11-05.
6137
c9e7db78
JD
61382011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6139
a97f8f3f
JD
6140 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6141 (unwind_create_frame): New function (Bug#9943).
6142 (Fx_create_frame): Restructure code to be more similar to the one in
6143 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6144 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6145 Move terminal->reference_count++ just before making the frame official
6146 (Bug#9943).
6147
6148 * nsterm.m (x_free_frame_resources): New function.
6149 (x_destroy_window): Move code to x_free_frame_resources.
6150
c9e7db78 6151 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6152 (Fx_create_frame, x_create_tip_frame):
6153 Move terminal->reference_count++ just before making the frame
75f1671a 6154 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6155 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6156
a6fc3b5c
EZ
61572011-11-05 Eli Zaretskii <eliz@gnu.org>
6158
6159 Support MSVC build with newer versions of Visual Studio.
6160 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6161 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6162 nt/gmake.defs.
6163
6164 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6165 which are not supported by MSVC.
6166 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6167 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6168 bitfields.
6169 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6170 types in bitfields.
6171 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6172
6173 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6174
58179cce 61752011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6176
6177 Support MSVC build with newer versions of Visual Studio.
6178 * w32.c: Don't include w32api.h for MSVC.
6179 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6180
6181 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6182 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6183 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6184 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6185 e_* cousins.
6186 (alloca) [_MSC_VER]: Define to _alloca.
6187
6188 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6189
6190 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6191
a58c13ed
EZ
61922011-11-04 Eli Zaretskii <eliz@gnu.org>
6193
6194 * xdisp.c (note_mouse_highlight): If either of
6195 previous/next-single-property-change returns nil, treat that as
6196 the beginning or the end of the buffer. (Bug#9955)
6197
fe0b6370
JD
61982011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6199
a58c13ed 6200 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6201 label is not null (Bug#9951).
6202 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6203 may be NULL.
6204
89bd5ee1
EZ
62052011-11-04 Eli Zaretskii <eliz@gnu.org>
6206
6207 * window.c (Fwindow_body_size): Mention in the doc string that the
6208 return value is in frame's canonical units. (Bug#9949)
6209
84c3edb9
EZ
62102011-11-03 Eli Zaretskii <eliz@gnu.org>
6211
4e2fb5c7
EZ
6212 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6213
84c3edb9 6214 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6215 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6216 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6217
bc17a887
EZ
62182011-11-01 Eli Zaretskii <eliz@gnu.org>
6219
6220 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6221 Don't stop backward scan on the continuation glyph, even though
6222 its CHARPOS is positive.
6d5eb5b0
SM
6223 (mouse_face_from_buffer_pos, note_mouse_highlight):
6224 Rename cover_string to disp_string.
bc17a887 6225
4ee88440
MR
62262011-11-01 Martin Rudalics <rudalics@gmx.at>
6227
6228 * window.c (temp_output_buffer_show): Don't use
6229 Vtemp_buffer_show_specifiers.
6230 (Vtemp_buffer_show_specifiers): Remove unused variable.
6231
c2ff3c02
EZ
62322011-10-30 Eli Zaretskii <eliz@gnu.org>
6233
6234 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6235 past the beginning of the current glyph matrix.
6236
58179cce 62372011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6238
6239 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6240 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6241 HAVE_GTK3 (Bug#9869).
b77a6a7f 6242
3b574623
JD
6243 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6244 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6245
b77a6a7f
JD
6246 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6247
6248 * xterm.c: Declare x_handle_net_wm_state to return int.
6249 (handle_one_xevent): Check if we are iconified but don't have
6250 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6251 (get_current_wm_state): Return non-zero if not hidden,
6252 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6253 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6254 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6255 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6256
196e41e4
PE
62572011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6258
6259 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6260 so that this new function doesn't get optimized away by a
6261 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6262
021f2e1a
AS
62632011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6264
6265 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6266
8b058d44
EZ
62672011-10-29 Eli Zaretskii <eliz@gnu.org>
6268
6269 Fix the `xbytecode' command.
6270 * .gdbinit (xprintbytestr): New command.
b50a28de 6271 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6272 (xbytecode): Print the byte-code string as well.
6273
4452fb80
EZ
62742011-10-29 Kim Storm <storm@cua.dk>
6275
8b058d44
EZ
6276 * alloc.c (which_symbols): New function.
6277
21b72067
AS
62782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6279
6280 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6281 line. (Bug#9903)
6282
83ed7b5c
GM
62832011-10-29 Glenn Morris <rgm@gnu.org>
6284
6285 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6286 Not clear what it was for, and it causes various bugs. (Bug#9839)
6287
5a7a728b
EZ
62882011-10-28 Eli Zaretskii <eliz@gnu.org>
6289
6290 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6291 possible random value that matches one of those tested as
6292 condition to clear the mouse face.
6293
d3d0842f
CY
62942011-10-28 Chong Yidong <cyd@gnu.org>
6295
6296 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6297
31b39d13
DN
62982011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6299
6300 * window.c (make_window): Initialize phys_cursor_on_p.
6301
9aba6043
SM
63022011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6303
6304 * lisp.h (struct Lisp_Symbol): Update comments.
6305
c20992f4
JB
63062011-10-28 Juanma Barranquero <lekktu@gmail.com>
6307
6308 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6309
db4f02f2
EZ
63102011-10-28 Eli Zaretskii <eliz@gnu.org>
6311
6312 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6313 <oslsachem@gmail.com> for helping to debug this.
6314
6315 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6316 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6317 (g_b_init_get_glyph_outline_w): New static variables.
6318 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6319 (GetGlyphOutlineW_Proc): New typedefs.
6320 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6321 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6322 New functions.
6323 (w32font_open_internal, compute_metrics):
6324 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6325 instead of calling the "wide" APIs directly.
6326
6327 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6328
6329 * w32.h (syms_of_w32font): Add prototype.
6330
87e68db4
JB
63312011-10-27 Juanma Barranquero <lekktu@gmail.com>
6332
6333 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6334 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6335 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6336 (Fmove_to_window_line): Doc fix.
6337
435c1d67
CY
63382011-10-27 Chong Yidong <cyd@gnu.org>
6339
6340 * process.c (make_process): Set gnutls_state to NULL.
6341
6342 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6343 non-NULL, regardless of GNUTLS_INITSTAGE.
6344 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6345 an error. Set process slots as soon as we allocate them.
6346
6347 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6348
9c6c6f49
CY
63492011-10-27 Chong Yidong <cyd@gnu.org>
6350
9aba6043
SM
6351 * gnutls.c (emacs_gnutls_deinit): New function.
6352 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6353 (Fgnutls_deinit, Fgnutls_boot): Use it.
6354
6355 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6356 (deactivate_process): Call emacs_gnutls_deinit.
6357
657d08d3
JB
63582011-10-27 Juanma Barranquero <lekktu@gmail.com>
6359
6360 * image.c (x_create_x_image_and_pixmap):
6361 * w32.c (sys_rename, w32_delayed_load):
6362 * w32font.c (fill_in_logfont):
6363 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6364
5430d399
JB
63652011-10-26 Juanma Barranquero <lekktu@gmail.com>
6366
6367 * w32fns.c (w32_default_color_map): New function,
6368 extracted from Fw32_default_color_map.
a7ef684b 6369 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6370
fe0055fa
PE
63712011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6372
6373 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6374
e6346438
SM
63752011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6376
6377 * keyboard.c (test_undefined): New function (bug#9751).
6378 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6379
e112cc37
ET
63802011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6381
6382 * sysdep.c (init_sys_modes): Fix the check for the controlling
6383 terminal (Bug#6649).
6384
7b5d6677
EZ
63852011-10-20 Eli Zaretskii <eliz@gnu.org>
6386
6387 * dispextern.h (struct bidi_it): New member next_en_type.
6388
6389 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6390 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6391 current character, check also for next_en_type being WEAK_EN.
6392 (bidi_resolve_weak): Don't enter the expensive loop if the current
6393 position is before next_en_pos. Record the bidi type of the first
6394 non-ET, non-BN character we find, in addition to its position.
6395 (bidi_level_of_next_char): Invalidate next_en_type when
6396 next_en_pos is over-stepped.
6397
7da0b018
PE
63982011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6399
6400 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6401 * editfns.c: Rewrite current-time-zone so that it invokes
6402 the equivalent of (format-time-string "%Z") to get the time zone name.
6403 This fixes a bug when the time zone name contains characters that
6404 need converting from the system time locale to Emacs internal format.
6405 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6406 that patch fixed format-time-string to do the conversion, but
6407 I forgot to fix current-time-zone.
6408 (format_time_string): New function, containing most of
6409 what Fformat_time_string used to contain.
6410 (Fformat_time_string): Rewrite in terms of format_time_string.
6411 This doesn't change this function's behavior.
6412 (current-time-zone): Rewrite to use format_time_string.
6413 This fixes the bug reported by Michael Schierl in
6414 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6415 Jason Rumney's 2007-06-07 change worked around this bug, but
6416 didn't fix it.
6417 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6418
8547b010
EZ
64192011-10-19 Eli Zaretskii <eliz@gnu.org>
6420
6421 * xdisp.c (start_display): If the character at POS is displayed
6422 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6423 (try_window_reusing_current_matrix): If a line ends in a display
6424 vector or the next line starts in a display vector, continue
6425 redrawing the window even though the character position of
6426 start_row was reached.
8547b010
EZ
6427 (Bug#9771, part 2)
6428
4e948d15
CY
64292011-10-18 Chong Yidong <cyd@gnu.org>
6430
6431 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6432 with nobreak-char-display too.
6433
4787455f
EZ
64342011-10-18 Eli Zaretskii <eliz@gnu.org>
6435
6436 Fix part 3 of bug#9771.
6437 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6438 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6439 non-neutral characters if the current character is a paragraph
6440 separator (a.k.a. Newline). This avoids running the same
6441 expensive loop twice, once when we consume the preceding newline
6442 and the other time when the line actually needs to be displayed.
6443 Avoid the loop when we see neutrals on the base embedding level
6444 following a character whose directionality is the same as the
6445 paragraph's. This avoids running the expensive loop when a line
6446 ends in a long sequence of neutrals, like control characters.
6447 Add assertion against STRONG_AL type. Slightly rearrange code
6448 that determines the type of a neutral given the first non-neutral
6449 that follows it.
6450 (bidi_level_of_next_char): Set next_en_pos to zero when
6451 invalidating its info.
6452
2c91f553
EZ
64532011-10-17 Eli Zaretskii <eliz@gnu.org>
6454
6455 * xdisp.c (push_display_prop): Determine whether to record string
6456 or buffer position by IT->string, not by IT->method. Allow
6457 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6458 (move_it_vertically_backward): Don't look for character position
6459 immediately after the newline when in a continuation line.
6460 (Bug#9771, part 1)
2c91f553 6461
c7b08b0d
MR
64622011-10-15 Martin Rudalics <rudalics@gmx.at>
6463
6464 * window.c (coordinates_in_window): Rewrite and delabelize
6465 vertical border check. (Bug#5357) (Bug#9618)
6466
6b02f655
SM
64672011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6468
6469 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6470 errors in XSetWindowBorder (bug#9310).
6471
81d40c92
DA
64722011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6473
6474 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6475 avoid crash when xmalloc overrun checking is enabled.
6476
d4172c3b
EZ
64772011-10-13 Eli Zaretskii <eliz@gnu.org>
6478
6479 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6480 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6481 cursor motion with <left> and <right> arrow keys.
6482
6483 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6484 some callers set that themselves.
6485
b00eea75
EZ
64862011-10-12 Eli Zaretskii <eliz@gnu.org>
6487
6488 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6489 display string and the previous row comes from the same string and
6490 is empty. (Bug#9739) (Bug#9738)
6491
8fe012c4
SM
64922011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6493
6494 * doc.c (get_doc_string): Encode file name (bug#9735).
6495
0074aef2
EZ
64962011-10-12 Eli Zaretskii <eliz@gnu.org>
6497
79beb178
EZ
6498 * bidi.c (bidi_level_of_next_char):
6499 * xdisp.c (get_visually_first_element): Remove old incorrect
6500 comments regarding the Unicode Line Separator character.
6501
0074aef2
EZ
6502 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6503
6e4b3fbe
DA
65042011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6505
6506 * alloc.c (Fgc_status): Do not access beyond zombies array
6507 boundary if nzombies > MAX_ZOMBIES.
6508 * alloc.c (dump_zombies): Add missing format specifier.
6509
0324f3af
PE
65102011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6511
b5525cac
PE
6512 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6513 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6514
0324f3af
PE
6515 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6516 Some packages use them to denote characters with modifiers.
6517
e9b5f888
AS
65182011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6519
6520 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6521 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6522 matching a pp-number. Rename parameter var to var1.
6523
127827c0
SM
65242011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6525
6526 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6527
c8fd3bd0
GM
65282011-10-08 Glenn Morris <rgm@gnu.org>
6529
6530 * callint.c (Fcall_interactively): Give a more explicit error for the
6531 'c' case with a non-character input. (Bug#8479)
6532
352ec8ff
EZ
65332011-10-08 Eli Zaretskii <eliz@gnu.org>
6534
03669ccb
EZ
6535 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6536 lines.
7061c986
EZ
6537 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6538 lines that are hscrolled on the left.
03669ccb 6539
352ec8ff
EZ
6540 * dispnew.c (buffer_posn_from_coords): Account for a possible
6541 presence of header-line. (Bug#4426)
6542
a66cfb1c
SM
65432011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6544
6b02f655
SM
6545 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6546 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6547
7c5ee88e
PE
65482011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6549
6550 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6551 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6552 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6553 this makes Emacs dump core during garbage collection on rare
6554 occasions. sizeof is obviously inferior to offsetof here, so
6555 stick with offsetof.
6556 (GC_POINTER_ALIGNMENT): New macro.
6557 (mark_memory): Omit 3rd (offset) arg; caller changed.
6558 Don't assume EMACS_INT alignment is the same as pointer alignment.
6559
df1bbe5b
SM
65602011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6561
6562 * keyboard.c (read_key_sequence_remapped): New var.
6563 (read_key_sequence): Compute remapping in the right buffer.
6564 (command_loop_1): Use read_key_sequence's remapping directly.
6565
51553db6
SM
65662011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6567
32c1fffd
SM
6568 * dired.c (file_name_completion): Don't expand file name.
6569 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6570 before checking file name handler.
6571
51553db6
SM
6572 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6573 they've been requested explicitly (bug#9591).
6574
b6bd1599 65752011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6576
6577 * keymap.c (Fsingle_key_description): Use make_specified_string
6578 instead of build_string to build string from push_key_description.
6579 (Bug#5193)
6580
f701dc2a
PE
65812011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6582
4222c55d
PE
6583 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6584 This fixes a Y2038 bug on 64-bit hosts.
6585 * buffer.c (reset_buffer):
6586 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6587 (Fclear_buffer_auto_save_failure):
6588 Use 0, not -1, to represent an unset failure time, since time_t
6589 might not be signed.
6590
f701dc2a
PE
6591 Remove dependency on glibc malloc internals.
6592 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6593 Move back here from lisp.h, but with their new implementations.
6594 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6595 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6596 * charset.c (charset_table_init): New static var.
6597 (syms_of_charset): Use it instead of xmalloc. This removes a
6598 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6599 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6600 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6601 Move back to alloc.c.
6602 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6603 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6604
9ceebf39
JD
66052011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6606
6607 * nsterm.m (windowDidResize): Call x_set_window_size only when
6608 ns_in_resize is true. Otherwise set pixelwidth/height and
6609 call change_frame_size (Bug#9628).
6610
cb993c58
PE
66112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6612
3930c88b
PE
6613 Port --enable-checking=all to Fedora 14 x86-64.
6614 * charset.c (syms_of_charset): Also account for glibc malloc's
6615 internal overhead when calculating the initial malloc maximum.
6616
cb993c58
PE
6617 Port --enable-checking=all to Fedora 14 x86.
6618 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6619 Move to lisp.h.
6620 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6621 (overrun_check_realloc, overrun_check_free):
6622 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6623 That way, xmalloc returns a properly-aligned pointer even if
6624 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6625 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6626 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6627 into account when calculating the initial malloc maximum.
6628 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6629 Move here from alloc.c, so that charset.c can use it too.
6630 Properly align; the old code wasn't right for common 32-bit hosts
6631 when configured with --enable-checking=all.
6632 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6633 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6634
31bed486
EZ
66352011-09-29 Eli Zaretskii <eliz@gnu.org>
6636
04c70788 6637 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6638 use EDOM.
6639
fbcaa2f3
EZ
66402011-09-28 Eli Zaretskii <eliz@gnu.org>
6641
6642 * xdisp.c (compute_display_string_end): If there's no display
6643 string at CHARPOS, return -1.
6644
6645 * bidi.c (bidi_fetch_char): When compute_display_string_end
6646 returns a negative value, treat the character as a normal
6647 character not covered by a display string. (Bug#9624)
6648
a239d4e9
JB
66492011-09-28 Juanma Barranquero <lekktu@gmail.com>
6650
6651 * lread.c (Fread_from_string): Fix typo in docstring.
6652
88652fd5
EZ
66532011-09-27 Eli Zaretskii <eliz@gnu.org>
6654
6655 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6656 newline, reseat the iterator instead of bidi-iterating there one
6657 character at a time. (Bug#9610)
32c1fffd
SM
6658 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6659 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6660
ed497dd4
AS
66612011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6662
6663 * lread.c (readevalloop): Use correct code for NBSP.
6664 (read1): Likewise. (Bug#9608)
6665
b2bf61aa
MA
66662011-09-25 Michael Albinus <michael.albinus@gmx.de>
6667
6668 * dbusbind.c (Fdbus_register_signal): When service is not
6669 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6670
32bbb17c
GM
66712011-09-25 Glenn Morris <rgm@gnu.org>
6672
6673 * buffer.c (truncate-lines): Doc fix.
6674
94e0933e
CY
66752011-09-24 Chong Yidong <cyd@stupidchicken.com>
6676
6677 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6678 (Fset_window_next_buffers): Doc fix.
6679
cddde921
GM
66802011-09-24 Glenn Morris <rgm@gnu.org>
6681
6682 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6683
1260aef1
PE
66842011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6685
25b4bfa0
PE
6686 Fix minor problems found by static checking.
6687 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6688 * indent.c (Fvertical_motion): Fix == vs = typo.
6689
e3cbd34b
EZ
66902011-09-24 Eli Zaretskii <eliz@gnu.org>
6691
a66cfb1c
SM
6692 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6693 Default value is now t. Doc fix.
6bf7006f 6694
e3cbd34b 6695 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6696 logic when moving up, not only when moving down. Fix the
e3cbd34b 6697 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6698 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6699
6700 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6701 CHARPOS is covered by a display string which includes newlines.
6702 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6703 is covered by a display string with embedded newlines.
6704
a3de0cbd
MA
67052011-09-24 Michael Albinus <michael.albinus@gmx.de>
6706
6707 * dbusbind.c (Fdbus_register_signal): Add match rule to
6708 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6709 (Fdbus_register_method, Vdbus_registered_objects_table):
6710 Fix docstring.
a3de0cbd 6711
b260039d
JM
67122011-09-24 Jim Meyering <meyering@redhat.com>
6713
32c1fffd 6714 do not ignore write error for any output size
b260039d
JM
6715 The previous change was incomplete.
6716 While it makes emacs --batch detect the vast majority of stdout
6717 write failures, errors were still ignored whenever the output size is
6718 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6719 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6720 && echo FAIL: ignored write error
6721 FAIL: ignored write error
6722 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6723 && echo FAIL: ignored write error
6724 FAIL: ignored write error
6725 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6726
8eca8a7c
AS
67272011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6728
6729 * emacs.c (Fkill_emacs): In noninteractive mode exit
6730 non-successfully if a write error occurred on stdout. (Bug#9574)
6731
3341db62
EZ
67322011-09-21 Eli Zaretskii <eliz@gnu.org>
6733
6734 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6735 the xassert test.
6736
6737 * dispextern.h (struct it): Update the comment documenting what
6738 can it->OBJECT be.
6739
8c203dbf
EZ
67402011-09-20 Eli Zaretskii <eliz@gnu.org>
6741
6742 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6743 a display string, extend search for cursor position to end of row.
6744 (find_row_edges): If the row ends in a newline from a display
6745 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6746 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6747 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6748 non-empty line. Fixes confusing cursor motion with arrow keys at
6749 the beginning of a line that starts with whitespace.
8c203dbf 6750
a4824228
LMI
67512011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6752
6753 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6754 (bug#9493).
6755
33ed493b
CY
67562011-09-18 Chong Yidong <cyd@stupidchicken.com>
6757
6758 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6759 boolean (Bug#9154).
6760
56cd55c8
EZ
67612011-09-18 Eli Zaretskii <eliz@gnu.org>
6762
6763 * xdisp.c (display_line): Record maximum and minimum buffer
6764 positions even if no glyphs were produced (e.g., by a zero-width
6765 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6766 buffer positions that will be removed from the glyph row because
6767 they don't fit.
c02dcedf
EZ
6768 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6769 column is beyond frame width: don't subtract 1 "pixel" when
6770 computing width of the stretch.
3e62b7e0
EZ
6771 (reseat_at_next_visible_line_start): Undo the change made on
6772 2011-09-17 that saved paragraph information and restored it after
6773 the call to `reseat'. (Bug#9545)
56cd55c8 6774
5ed99d36 67752011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6776
6777 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6778 and turn window cursor on if cleared (Bug#9415).
6779
5ed99d36 67802011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6781
6782 * search.c (boyer_moore): Take unibyte characters from pattern
6783 literally. (Bug#9458)
6784
9bade7b2
EZ
67852011-09-18 Eli Zaretskii <eliz@gnu.org>
6786
6787 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6788
e5e9d610
PE
67892011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6790
87e4427a
PE
6791 Fix minor problem found by static checking.
6792 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6793 initialized, to pacify gcc -Wuninitialized.
6794
e5e9d610
PE
6795 * fileio.c: Report proper errno when syscall falls.
6796 (Finsert_file_contents): Save and restore errno,
6797 so that report_file_error outputs the correct diagnostic.
6798 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6799
a1674f0b
EZ
68002011-09-18 Eli Zaretskii <eliz@gnu.org>
6801
6802 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6803
fbfb6dd4
EZ
68042011-09-17 Eli Zaretskii <eliz@gnu.org>
6805
6806 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6807 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6808
bb187662
EZ
68092011-09-17 Eli Zaretskii <eliz@gnu.org>
6810
1137e8b8 6811 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6812 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6813
6814 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6815 (bidi_find_paragraph_start): Search back for paragraph beginning
6816 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6817 (bidi_move_to_visually_next): Only trigger paragraph-related
6818 computations when the last character is a newline or at EOB, not
6819 just any NEUTRAL_B. (Bug#9470)
6820
bb187662
EZ
6821 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6822 truncated lines if point is covered by a display string. (Bug#9524)
6823
2e621251
PE
68242011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6825
6826 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6827 (cons_to_x_long): New function.
6828 (lisp_data_to_selection_data): Use it. Correct the test for
6829 short-versus-long data; it was negated. Break out of vector
6830 loop, for efficiency, when a long datum is discovered.
6831
91a15bc6
SM
68322011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6833
6834 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6835
b41c3a35
EZ
68362011-09-16 Eli Zaretskii <eliz@gnu.org>
6837
6838 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6839 GCC PR/17406) by declaring this function with external scope.
6840
7812ba2d
PE
68412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6842
6843 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6844 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6845
cf7edc2a
AS
68462011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6847
6848 * editfns.c (Fformat): Correctly handle text properties on "%%".
6849
bd01620e
EZ
68502011-09-15 Eli Zaretskii <eliz@gnu.org>
6851
6852 * xterm.c (x_draw_composite_glyph_string_foreground):
6853 * w32term.c (x_draw_composite_glyph_string_foreground):
6854 * term.c (encode_terminal_code):
6855 * composite.c (composition_update_it, get_composition_id):
6856 * xdisp.c (get_next_display_element)
6857 (fill_composite_glyph_string): Add comments about special meaning
6858 of TAB characters in a composition.
6859
a02719a3
PE
68602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6861
6862 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6863 This occurs when processing a multibyte format.
6864 Problem reported by Wolfgang Jenker.
a02719a3 6865
72589a3c
JB
68662011-09-15 Johan Bockgård <bojohan@gnu.org>
6867
6868 * xdisp.c (try_cursor_movement): Only check for exact match if
6869 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6870
1c14176c
PE
68712011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6872
6873 Remove unused external symbols.
6874 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6875 * xdisp.c (calc_pixel_width_or_height): Now static.
6876 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6877 * indent.c (check_display_width):
6878 * w32term.c: Fix comment to match code.
6879 * xterm.c, xterm.h (x_catching_errors): Remove.
6880
d2eea5b5
PE
68812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6882
6883 * xselect.c: Use signed conversions more consistently (Bug#9498).
6884 (selection_data_to_lisp_data): Assume incoming selection data are
6885 signed integers, not unsigned. This is to be consistent with
6886 outgoing selection data, which was modified to use signed integers
6887 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6888 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6889 expects long, not unsigned long.
6890
46888499
EZ
68912011-09-14 Eli Zaretskii <eliz@gnu.org>
6892
6893 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6894 computation of loop end. Reported by Johan Bockgård
6895 <bojohan@gnu.org>.
6896
ef8ef9fb
CY
68972011-09-13 Chong Yidong <cyd@stupidchicken.com>
6898
6899 * frame.c (Fother_visible_frames_p): Function deleted.
6900
fa819fed
EZ
69012011-09-12 Eli Zaretskii <eliz@gnu.org>
6902
6903 * indent.c (compute_motion): Process display vector front to back
6904 rather than the other way around. (Bug#2496)
6905
2ba8e008
SM
69062011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6907
6908 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6909
20f53c69
CY
69102011-09-11 Chong Yidong <cyd@stupidchicken.com>
6911
6912 * minibuf.c (Fread_from_minibuffer): Doc fix.
6913
d562d7a4
EZ
69142011-09-11 Eli Zaretskii <eliz@gnu.org>
6915
6916 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6917 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6918
1c4d7f3d
LMI
69192011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6920
6921 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6922 value for non-existent files.
6923
b885bf36
EZ
69242011-09-11 Eli Zaretskii <eliz@gnu.org>
6925
6926 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6927 set its "size" to -1. This will set the modtime_size field of
6928 the corresponding buffer to -1, which is what
6929 verify-visited-file-modtime expects for files that do not exist.
6930 (Bug#9139)
6931
6612f0bf
PE
69322011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6933
6934 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6935 here ...
6936 * lisp.h: ... from here. push_key_description is no longer
6937 defined in keyboard.c, so its declaration should not be in
6938 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6939 logically belongs with push_key_description.
6940
dfb3f755
PE
69412011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6942
6943 * buffer.h: Include <sys/types.h> instead of <time.h>.
6944 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6945 Problem reported by Herbert J. Skuhra.
6946
3134906c
LMI
69472011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6948
6949 * xml.c (parse_region): Make the parsing work for
6950 non-comment-starting XML files again (bug#9144).
6951
8d903f4e
AS
69522011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6953
6954 * image.c (gif_load): Fix calculation of bottom and right corner.
6955 (Bug#9468)
6956
80ad64f4
EZ
69572011-09-10 Eli Zaretskii <eliz@gnu.org>
6958
6959 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6960 redisplay in small windows.
6961
208a048d
EZ
69622011-09-09 Eli Zaretskii <eliz@gnu.org>
6963
6964 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6965
9b1c252e
MR
69662011-09-08 Martin Rudalics <rudalics@gmx.at>
6967
6968 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6969 Operate on live windows only.
6970
2949f33b
JB
69712011-09-08 Juanma Barranquero <lekktu@gmail.com>
6972
6973 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6974
e08dcafd
EZ
69752011-09-07 Eli Zaretskii <eliz@gnu.org>
6976
6977 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6978 only under bidi iteration.
6979
115b96bd
JD
69802011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6981
6982 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6983
c8199d0f
PE
69842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6985
6986 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6987 Without this fix, the command to link temacs failed due to an
6988 undefined symbol __builtin_isnan. This is because
6989 /usr/include/iso/math_c99.h #defines isnan(x) to
6990 __builtin_isnan(x), but the bundled gcc, which identifies itself
6991 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6992 a __builtin_isnan.
6993 * floatfns.c (isnan): #undef, and then #define to a clone of
6994 what's in data.c.
6995 (Fisnan): Always define, since it's always available now.
6996 (syms_of_floatfns): Always define isnan at the Lisp level.
6997
e39b275c 69982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6999
7000 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7001
b2db44d9 70022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7003
f4af5137 7004 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7005 The previous code assumed that file offsets (off_t values) fit in
7006 EMACS_INT variables, which is not true on typical 32-bit hosts.
7007 The code messed up by falsely reporting buffer overflow in cases
7008 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7009 when "big" contains more than 2**29 bytes, even though this
7010 inserts just one byte and does not overflow the buffer.
7011 (Finsert_file_contents): Store file offsets as off_t
7012 values, not as EMACS_INT values. Check for overflow when
7013 converting between EMACS_INT and off_t. When checking for
7014 buffer overflow or for overlap, take the offsets into account.
7015 Don't use EMACS_INT for small values where int suffices.
7016 When checking for overlap, fix a typo: ZV was used where
7017 ZV_BYTE was intended.
7018 (Fwrite_region): Don't assume off_t fits into 'long'.
7019 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7020
ecfc0a49
MA
70212011-09-05 Michael Albinus <michael.albinus@gmx.de>
7022
7023 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7024
6511acf2 70252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7026
0999621a 7027 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7028
7029 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7030 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7031 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7032 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7033 (modify_event_symbol): Do not assume that the length of
7034 name_alist_or_stem is safe to alloca and fits in int.
7035 (Fexecute_extended_command): Likewise for function name and binding.
7036 (Frecursion_depth): Wrap around reliably on integer overflow.
7037 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7038 since some callers pass EMACS_INT values.
7039 (Fsingle_key_description): Don't crash if symbol name contains more
7040 than MAX_ALLOCA bytes.
7041 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7042 (get_minibuffer): Arg is now EMACS_INT, not int.
7043 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7044 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7045 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7046
2be7d702
PE
7047 * dbusbind.c (signature_cat): New function.
7048 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7049 Do not overrun buffer; instead, report string overflow.
7050
9d1df220
PE
7051 * dispnew.c (add_window_display_history): Don't overrun buffer.
7052 Truncate instead; this is OK since it's just a log.
7053
33ef5c64
PE
7054 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7055 even if the time zone offset is outlandishly large.
7056 Don't mishandle offset == INT_MIN.
7057
66c6fdd5
PE
7058 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7059 when creating daemon; the previous buffer-overflow check was incorrect.
7060
d749b01b
PE
7061 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7062 which has the guts of the old verror function.
7063
b5cd1905
PE
7064 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7065 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7066
6e1a67fb
PE
7067 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7068 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7069 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7070 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7071 length of string rather than counting it via multiple sprintfs;
7072 that's simpler and more reliable.
c21721cc
PE
7073 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7074 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7075 sprintf, in case result does not fit in int.
7076
c57b67fc
PE
7077 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7078 (fontset_from_font): Print it.
7079
8a401434
PE
7080 * frame.c (tty_frame_count): Now printmax_t, not int.
7081 (make_terminal_frame, set_term_frame_name): Print it.
7082 (x_report_frame_params): In X, window IDs are unsigned long,
7083 not signed long, so print them as unsigned.
7084 (validate_x_resource_name): Check for implausibly long names,
7085 and don't assume name length fits in 'int'.
7086 (x_get_resource_string): Don't blindly alloca invocation name;
7087 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7088 not fit in int.
7089
6e1a67fb
PE
7090 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7091 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7092 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7093
0df02bf3
PE
7094 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7095 Use esprintf, not sprintf, in case result does not fit in int.
7096
48e30793
PE
7097 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7098 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7099 it as a large positive number.
7100 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7101 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7102
a66ff6d8
PE
7103 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7104 in case result does not fit in int.
7105
aca216ff
PE
7106 * print.c (float_to_string): Detect width overflow more reliably.
7107 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7108 buffer overrun. Don't assume list length fits in 'int'. Treat
7109 print length of 0 as 0, not as infinity; to be consistent with other
7110 uses of print length in this function. Don't overflow print length
7111 index. Don't assume hash table size fits in 'long', or that
7112 vectorlike size fits in 'unsigned long'.
7113
31c286f7
PE
7114 * process.c (make_process): Use printmax_t, not int, to format
7115 process-name gensyms.
7116
55e5faa1
PE
7117 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7118
80f2e268
PE
7119 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7120 to avoid potential buffer overrun.
7121
670741ab
PE
7122 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7123 if X resource line is longer than 512 bytes.
7124
b7163a50
PE
7125 * xfns.c (x_window): Make sprintf buffer a bit bigger
7126 to avoid potential buffer overrun.
7127
ae58ff1f
PE
7128 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7129
c43c8a6a
PE
7130 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7131
3f8236f4
PE
71322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7133
53e9fe90 7134 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7135 Without these, Emacs silently mishandles large integers sometimes.
7136 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7137 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7138
6511acf2
PE
7139 * xdisp.c (try_window_id): Check Emacs fixnum range before
7140 converting to 'int'.
806add1d 7141
6511acf2 7142 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7143 Check that an Emacs fixnum is in range before assigning it to 'int'.
7144 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7145 values converted from Emacs fixnums.
7146 (Frecenter): Don't wrap around a line count if it is out of 'int'
7147 range; instead, treat it as an extreme value.
7148 (Fset_window_configuration, compare_window_configurations):
7149 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7150
6511acf2
PE
7151 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7152 that can exceed INT_MAX. Check that EMACS_INT value is in range
7153 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7154 (match_limit): Don't assume that a fixnum can fit in 'int'.
7155
6511acf2 7156 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7157 exceed INT_MAX.
7158
6511acf2 7159 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7160 (Fvertical_motion): Don't wrap around LINES values that don't fit
7161 in 'int'. Instead, treat them as extreme values. This is good
7162 enough for windows, which can't have more than INT_MAX lines anyway.
7163
fcb901a7
LMI
71642011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7165
0f2f6b6d
LMI
7166 * Require libxml/parser.h to avoid compilation warning.
7167
fcb901a7
LMI
7168 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7169
7170 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7171 since this reportedly can destroy thread storage.
7172
6e20a0d4
CY
71732011-08-30 Chong Yidong <cyd@stupidchicken.com>
7174
7175 * syntax.c (find_defun_start): Update all cache variables if
7176 exiting early (Bug#9401).
7177
148ae00e
EZ
71782011-08-30 Eli Zaretskii <eliz@gnu.org>
7179
f6cfbd8f
EZ
7180 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7181
148ae00e
EZ
7182 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7183 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7184 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7185
7186 * term.c (tty_append_glyph): New function.
7187 (produce_stretch_glyph): Static function and its prototype deleted.
7188
a66cfb1c
SM
7189 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7190 Add prototypes.
148ae00e 7191
c4a07a4c
PE
71922011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7193
7194 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7195 when checking :margin (Bug#9390).
7196 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7197 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7198 so that the name doesn't mislead. All uses changed.
7199
6bc8cd65
JB
72002011-08-28 Johan Bockgård <bojohan@gnu.org>
7201
7202 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7203 set_tty_hooks.
7204
dca4927e
EZ
72052011-08-27 Eli Zaretskii <eliz@gnu.org>
7206
7207 * xdisp.c (move_it_to): Don't bail out early when reaching
7208 position beyond to_charpos, if we are scanning backwards.
7209 (move_it_vertically_backward): When DY == 0, make sure we get to
7210 the first character in the line after the newline.
7211
f2cad773
PE
72122011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7213
7214 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7215 (ccl_driver): Do not generate an out-of-range pointer.
7216 (Fccl_execute_on_string): Remove unnecessary check for
7217 integer overflow, noted by Stefan Monnier in
7218 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7219 Remove a FIXME that didn't need fixing.
7220 Simplify the newly-introduced buffer reallocation code.
7221
0cae2cdb
JB
72222011-08-27 Juanma Barranquero <lekktu@gmail.com>
7223
7224 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7225
5fc295a4 72262011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7227
70c60eb2 7228 Integer and memory overflow issues (Bug#9196).
726e0ab1 7229
d31850da
PE
7230 * doc.c (get_doc_string): Rework so that
7231 get_doc_string_buffer_size is the actual buffer size, rather than
7232 being 1 less than the actual buffer size; this makes xpalloc more
7233 convenient.
7234
a69fbedb
PE
7235 * image.c (x_allocate_bitmap_record, cache_image):
7236 * xselect.c (Fx_register_dnd_atom):
7237 Simplify previous changes by using xpalloc.
7238
fe5c5d37
PE
7239 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7240 since either will do and ptrdiff_t is convenient with xpalloc.
7241
0065d054
PE
7242 * charset.c (charset_table_size)
7243 (struct charset_sort_data.priority): Now ptrdiff_t.
7244 (charset_compare): Don't overflow if priorities differ greatly.
7245 (Fsort_charsets): Don't assume list length fits in int.
7246 Check for size-calculation overflow when allocating sort data.
7247 (syms_of_charset): Allocate an initial charset table that is
7248 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7249
7250 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7251
7252 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7253 The actual value is always <= INT_MAX, and leaving it unsigned made
7254 overflow checking harder.
7255
7256 * dispextern.h (struct glyph_matrix.rows_allocated)
7257 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7258 with xpalloc. The values are still always <= INT_MAX.
7259
7260 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7261
7262 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7263 (SAFE_NALLOCA): New macro.
7264
7265 * region-cache.c (struct boundary.pos, find_cache_boundary)
7266 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7267 (set_cache_region, invalidate_region_cache)
7268 (revalidate_region_cache, know_region_cache, region_cache_forward)
7269 (region_cache_backward, pp_cache):
7270 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7271 so that ptrdiff_t * can be passed to xpalloc.
7272 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7273 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7274 (pp_cache): Don't assume cache_len fits in int.
7275 * region-cache.h: Adjust extern decls to match.
7276
7277 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7278 EMACS_INT, since either will do, for xpalloc.
7279
7280 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7281 (xnmalloc, xnrealloc, xpalloc): New functions.
7282
726e0ab1
PE
7283 * bidi.c (bidi_shelve_header_size): New constant.
7284 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7285 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7286
51f30bc5 7287 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7288 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7289 (overlay_strings):
7290 Don't update size of array until after memory allocation succeeds,
7291 because xmalloc/xrealloc may not return.
0065d054
PE
7292 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7293 now that we have proper integer overflow checking.
7294 (record_overlay_string, overlay_strings): Catch overflows when
7295 calculating size of overlay_str_buf.
726e0ab1 7296
0065d054
PE
7297 * callproc.c (Fcall_process): Check for size overflow when
7298 calculating size of args2.
7299 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7300 Normally we prefer signed values, but sticking with ptrdiff_t would
7301 require adding more-complicated checks.
726e0ab1
PE
7302
7303 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7304 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7305 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7306 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7307
7308 * character.c (Fstring): Check for size-calculation overflow.
7309
7310 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7311 unnecessary integer overflow. Check for size overflow.
7312 (encode_coding_object): Don't update size until xmalloc succeeds.
7313
7314 * composite.c (get_composition_id): Check for overflow in glyph
7315 length calculations.
7316
7317 Integer and memory overflow fixes for display code.
7318 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7319 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7320 (scrolling_window): Check for overflow in size calculations.
7321 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7322 Don't assume glyph table len fits in int.
7323 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7324 (row_table_size): Now ptrdiff_t, not int.
7325 (scrolling_window): Avoid overflow in size calculations.
7326 Don't update size until allocation succeeds.
7327 * fns.c (concat): Check for overflow in size calculations.
7328 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7329 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7330 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7331
7332 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7333 (get_doc_string): Check for size calculation overflow.
7334 Don't update size until allocation succeeds.
7335 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7336 EMACS_INT, where ptrdiff_t will do.
7337 (Fsubstitute_command_keys): Check for string overflow.
7338
7339 * editfns.c (set_time_zone_rule): Don't assume environment length
7340 fits in int.
7341 (message_length): Now ptrdiff_t, not int.
7342 (Fmessage_box): Don't update size until allocation succeeds.
7343 Don't assume message length fits in int.
7344 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7345
0065d054
PE
7346 * emacs.c (main): Do not reallocate argv, since there is a null at
7347 the end that can be overwritten, and this way there's no need to
7348 worry about size-calculation overflow.
7349 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7350
7351 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7352 alloc succeeds.
7353 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7354
7355 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7356 (x_set_scroll_bar_width, x_figure_window_size):
7357 Check for integer overflow.
7358 (x_set_alpha): Do not assume XINT fits in int.
7359
7360 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7361 This is for the members text_lines, text_cols, total_lines, total_cols,
7362 where the system imposes an 'int' limit.
7363
7364 * fringe.c (Fdefine_fringe_bitmap):
7365 Don't update size until alloc works.
7366
7367 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7368 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7369
7370 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7371 Check for size-calculation overflow.
7372 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7373 do, as we prefer signed integers.
7374 (id_to_widget.max_size, id_to_widget.used)
7375 (xg_store_widget_in_map, xg_remove_widget_from_map)
7376 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7377 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7378 Use and return ptrdiff_t, not int.
7379 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7380 * gtkutil.h: Change prototypes to match the above.
7381
7382 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7383 are duplicate now that they've been promoted to lisp.h.
7384 (x_allocate_bitmap_record, x_alloc_image_color)
7385 (make_image_cache, cache_image, xpm_load):
7386 Don't update size until alloc is done.
7387 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7388 (x_detect_edges):
3256efce 7389 Check for size calculation overflow.
726e0ab1
PE
7390 (ct_colors_allocated_max): New constant.
7391 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7392 overflow.
3256efce 7393
726e0ab1
PE
7394 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7395 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7396 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7397 Use ptrdiff_t, not int, to count maps.
7398 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7399 calculations. Don't update size until allocation succeeds.
7400 Redo calculations to avoid overflow.
726e0ab1
PE
7401 * keyboard.h: Change prototypes to match the above.
7402
7403 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7404 to count maps.
7405 (current_minor_maps): Check for size calculation overflow.
7406 * keymap.h: Change prototypes to match the above.
7407
7408 * lread.c (read1, init_obarray): Don't update size until alloc done.
7409
7410 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7411 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7412
726e0ab1
PE
7413 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7414 Now ptrdiff_t, not int.
7415 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7416 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7417
7418 * process.c (Fnetwork_interface_list): Check for overflow
7419 in size calculation.
7420
7421 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7422
7423 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7424 overflow. Don't bother calling xmalloc when xrealloc will do.
7425
7426 * search.c (Freplace_match): Check for size calculation overflow.
7427 (Fset_match_data): Don't assume list lengths fit in 'int'.
7428
7429 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7430 for command line length. Do not attempt to address one before the
7431 beginning of an array, as that's not portable.
7432
7433 * term.c (max_frame_lines): Remove; unused.
7434 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7435 not int.
7436 (encode_terminal_code, calculate_costs): Check for size
7437 calculation overflow.
7438 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7439 table lengths and related sizes. Don't update size until alloc
7440 done. Redo calculations to avoid overflow.
7441 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7442
7443 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7444 subtracting pointers.
7445 (gobble_line): Check for overflow more carefully. Don't update size
7446 until alloc done.
7447
7448 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7449 Don't update size until alloc done.
7450 Redo size calculations to avoid overflow.
7451 Check for size calculation overflow.
0065d054 7452 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7453
7454 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7455 Use ptrdiff_t, not int, for sizes.
7456 (store_mode_line_noprop_char): Don't update size until alloc done.
7457
0065d054
PE
7458 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7459 Use ptrdiff_t, not int, for sizes.
7460 (Finternal_make_lisp_face, cache_face):
7461 Check for size calculation overflow.
7462 (cache_face): Treat size calculation overflows as if they were
7463 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7464
7465 * xfns.c (x_encode_text, x_set_name_internal)
7466 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7467 sizes, since they can exceed INT_MAX in size. Check for size
7468 calculation overflow.
7469
0065d054
PE
7470 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7471 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7472 Don't update size until alloc done.
7473
0065d054 7474 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7475 as sprintf is limited to int lengths.
1d526e2f 7476
252c5ee1
PE
7477 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7478 (X_LONG_MIN): New macros.
864d7ce7
PE
7479 Use them to make the following changes clearer.
7480 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7481 This change doesn't affect the value now, but it may help remind
7482 future maintainers not to raise the value too much later.
7483 (SELECTION_QUANTUM): Remove, replacing with ...
7484 (selection_quantum): ... new function, which avoids overflow.
7485 All uses changed.
7486 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7487 assumption that selection length fits in 'int'.
7488 (x_reply_selection_request, x_handle_selection_request)
7489 (x_get_window_property, receive_incremental_selection)
7490 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7491 (lisp_data_to_selection_data, clean_local_selection_data):
7492 Use ptrdiff_t, not int, to record length of selection.
7493 (x_reply_selection_request, x_get_window_property)
7494 (receive_incremental_selection, x_property_data_to_lisp):
7495 Redo calculations to avoid overflow.
7496 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7497 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7498 something.
7499 (x_get_window_property, receive_incremental_selection)
7500 (lisp_data_to_selection_data, x_property_data_to_lisp):
7501 Check for size-calculation overflow.
7502 (x_get_window_property, receive_incremental_selection)
7503 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7504 Don't store size until memory allocation succeeds.
7505 (x_get_window_property): Plug memory leak on memory exhaustion.
7506 Don't double-block input; malloc is safe here. Don't assume 2**34
7507 - 4 fits in unsigned long. Add an xassert to check
7508 XGetWindowProperty overflow. Be more careful about overflow
7509 calculations, and distinguish size from memory overflow better.
7510 (receive_incremental_selection): When tracing, don't assume
7511 unsigned int is less than INT_MAX.
7512 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7513 harmful) conversions of unsigned short to int.
7514 (lisp_data_to_selection_data): Don't assume that integers
7515 in the range -65535 through -1 fit in an X unsigned short.
7516 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7517 result parameters unless successful. Rely on cons_to_unsigned
7518 to report problems with elements; the old code wasn't right anyway.
7519 (x_check_property_data): Check for int overflow; we cannot use
7520 a wider type due to X limits.
7521 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7522
726e0ab1 7523 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7524
0065d054
PE
7525 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7526 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7527 (x_color_cells): Don't store size until memory allocation succeeds.
7528 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7529 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7530 (x_term_init): Don't assume length fits in int (sprintf is limited
7531 to int size).
bc18e09d 7532
ebfa62c0
PE
7533 Use ptrdiff_t for composition IDs.
7534 * character.c (lisp_string_width):
7535 * composite.c (composition_table_size, n_compositions)
7536 (get_composition_id, composition_gstring_from_id):
7537 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7538 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7539 * window.c (Frecenter):
7540 Use ptrdiff_t, not int, for composition IDs.
7541 * composite.c (get_composition_id): Check for integer overflow.
7542 * composite.h: Adjust prototypes to match the above changes.
7543
d3411f89
PE
7544 Use ptrdiff_t for hash table indexes.
7545 * category.c (hash_get_category_set):
7546 * ccl.c (ccl_driver):
7547 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7548 * coding.c (coding_system_charset_list, detect_coding_system):
7549 * coding.h (struct coding_system.id):
7550 * composite.c (get_composition_id, gstring_lookup_cache):
7551 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7552 * image.c (xpm_get_color_table_h):
7553 * lisp.h (hash_lookup, hash_put):
7554 * minibuf.c (Ftest_completion):
7555 Use ptrdiff_t for hash table indexes, not int (which is too
7556 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7557 32-bit --with-wide-int hosts).
7558
e097a6fa
PE
7559 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7560 Add a FIXME comment about memory leaks.
7561 (syms_of_charset): Don't assume xmalloc returns.
7562
5637687f
PE
7563 Don't assume that stated character widths fit in int.
7564 * character.c (Fchar_width, c_string_width, lisp_string_width):
7565 * character.h (CHAR_WIDTH):
7566 * indent.c (MULTIBYTE_BYTES_WIDTH):
7567 Use sanitize_char_width to avoid undefined and/or bad behavior
7568 with outlandish widths.
a66cfb1c 7569 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7570 now that we have two such functions. All uses changed.
7571 (sanitize_char_width): New inline function.
7572
a2271ba2
PE
7573 Don't assume that tab-width fits in int.
7574 * character.h (sanitize_width): New inline function.
7575 (SANE_TAB_WIDTH): New macro.
7576 (ASCII_CHAR_WIDTH): Use it.
7577 * indent.c (sane_tab_width): Remove. All uses replaced by
7578 SANE_TAB_WIDTH (current_buffer).
7579 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7580
18c52557
PE
7581 * fileio.c: Integer overflow issues with file modes.
7582 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7583
caeeedc1
PE
7584 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7585 Remove unreachable code.
7586 (read_hex, load_charset_map_from_file): Check for integer overflow.
7587
6df6ae42 7588 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7589 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7590 (x_send_scroll_bar_event): Likewise. Check that the size does not
7591 exceed limits imposed by XClientMessageEvent, as well as the usual
7592 ptrdiff_t and size_t limits.
7593
b13995db
PE
7594 * keyboard.c: Overflow, signedness and related fixes.
7595 (make_lispy_movement): Use same integer type in forward decl
7596 that is used in the definition.
7597 (read_key_sequence, keyremap_step):
7598 Change bufsize argument back to int, undoing my 2011-03-30 change.
7599 We prefer signed types, and int is wide enough here.
7600 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7601 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7602 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7603 length, not size_t. Use ptrdiff_t for index, not int.
7604 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7605 possibility of integer overflow.
7606
13464394
PE
7607 Overflow, signedness and related fixes for images.
7608
7609 * dispextern.h (struct it.stack[0].u.image.image_id)
7610 (struct_it.image_id, struct image.id, struct image_cache.size)
7611 (struct image_cache.used, struct image_cache.ref_count):
7612 * gtkutil.c (update_frame_tool_bar):
7613 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7614 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7615 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7616 * nsmenu.m (update_frame_tool_bar):
7617 * xdisp.c (calc_pixel_width_or_height):
7618 * xfns.c (image_cache_refcount):
7619 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7620 on typical 64-bit hosts.
7621
7622 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7623 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7624 Omit unnecessary casts to int.
7625 (parse_image_spec): Check that integers fall into 'int' range
7626 when the callers expect that.
7627 (image_ascent): Redo ascent calculation to avoid int overflow.
7628 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7629 (lookup_image): Remove unnecessary tests.
7630 (xbm_image_p): Locals are now of int, not EMACS_INT,
7631 since parse_image_check makes sure they fit into int.
7632 (png_load, gif_load, svg_load_image):
7633 Prefer int to unsigned where either will do.
7634 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7635 old tiff_error_handler and tiff_warning_handler.
7636 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7637 stack buffer overflows. It uses only the features of vsnprintf
7638 that are common to both POSIX and native Microsoft.
7639 (tiff_error_handler, tiff_warning_handler): Use it.
7640 (tiff_load, gif_load, imagemagick_load_image):
7641 Don't assume :index value fits in 'int'.
7642 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7643 (imagemagick_load_image): Check that crop parameters fit into
7644 the integer types that MagickCropImage accepts. Don't assume
7645 Vimagemagick_render_type has a nonnegative value. Don't assume
7646 size_t fits in 'long'.
7647 (gs_load): Use printmax_t to print the widest integers possible.
7648 Check for integer overflow when computing image height and width.
7649
c11821d4
EZ
76502011-08-26 Eli Zaretskii <eliz@gnu.org>
7651
7652 * xdisp.c (redisplay_window): Don't force window start if point
7653 will be invisible in the resulting window. (Bug#9324)
7654
0c95fcf7
EZ
76552011-08-25 Eli Zaretskii <eliz@gnu.org>
7656
7657 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7658 the display spec is of the form `(space ...)'.
7659 (handle_display_spec): Return the value returned by
7660 handle_single_display_spec, not just 1 or zero.
7661 (handle_single_display_spec): If the display spec is of the form
7662 `(space ...)', and specifies display in the text area, return 2
7663 rather than 1.
fee65a97 7664 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7665 accurately, and prefer exact match for point under bidi.
7666 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7667
7668 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7669 into disp_prop; all users changed.
7670
7671 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7672 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7673 for the text covered by the display property.
7674
e4ed06f1
CY
76752011-08-25 Chong Yidong <cyd@stupidchicken.com>
7676
7677 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7678 Change return value to nil.
7679 (Frecord_buffer): Delete unused function.
7680
f67cdd7f
EZ
76812011-08-24 Eli Zaretskii <eliz@gnu.org>
7682
5980d4c6
EZ
7683 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7684 buffers, return left-to-right.
8610fe8b
EZ
7685 (set_cursor_from_row): Consider candidate row a win if its glyph
7686 represents a newline and point is on that newline. Fixes cursor
7687 positioning on the newline at EOL of R2L text within L2R
7688 paragraph, and vice versa.
7689 (try_cursor_movement): Check continued rows, in addition to
7690 continuation rows. Fixes unwarranted scroll when point enters a
7691 continued line of R2L text within an L2R paragraph, or vice versa.
7692 (cursor_row_p): Consider the case of point being equal to
7693 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7694 from the end of a short line to the beginning of a continued line
7695 of R2L text within L2R paragraph.
7696 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7697 composed characters.
5980d4c6 7698
f67cdd7f
EZ
7699 * bidi.c (bidi_check_type): Use xassert.
7700 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7701 members.
7702
bca633fb
EZ
77032011-08-23 Eli Zaretskii <eliz@gnu.org>
7704
7705 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7706 a character.
7707
4a5885a7
CY
77082011-08-23 Chong Yidong <cyd@stupidchicken.com>
7709
7710 * nsfont.m (ns_otf_to_script): Fix typo.
7711
0902a04e
KH
77122011-08-22 Kenichi Handa <handa@m17n.org>
7713
7714 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7715 extra slot even if the purpose is char-code-property-table.
7716
1a2e6670
EZ
77172011-08-23 Eli Zaretskii <eliz@gnu.org>
7718
8ddde651
EZ
7719 * xdisp.c (redisplay_window): When computing centering_position,
7720 account for the height of the header line. (Bug#8874)
7721
425cc014
EZ
7722 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7723 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7724 candidate is selected by the mouse, and that candidate has a
7725 composed character under the mouse.
7726
1a2e6670
EZ
7727 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7728 coordinates reported by pos-visible-in-window-p for a composed
7729 character in column zero.
7730
8b76d6f8
SM
77312011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7732
7733 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7734
dac347dd
EZ
77352011-08-22 Eli Zaretskii <eliz@gnu.org>
7736
7737 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7738 consider it a hit if to_charpos is anywhere in the range of the
7739 composed buffer positions.
7740
e013fb34
CY
77412011-08-22 Chong Yidong <cyd@stupidchicken.com>
7742
7743 * image.c (gif_load): Don't assume that each subimage has the same
7744 dimensions as the base image. Handle disposal method that is
7745 "undefined" by the gif spec (Bug#9335).
7746
bd1ba3e8
CY
77472011-08-20 Chong Yidong <cyd@stupidchicken.com>
7748
7749 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7750 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7751
54a1215b
EZ
77522011-08-19 Eli Zaretskii <eliz@gnu.org>
7753
823564e5
EZ
7754 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7755 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7756 from an Org mode buffer to a Speedbar frame.
7757
54a1215b
EZ
7758 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7759 a composition, take its buffer position from IT->cmp_it.charpos.
7760 Fixes cursor positioning at the beginning of a line that begins
7761 with a composed character.
7762
9778ebcc
EZ
77632011-08-18 Eli Zaretskii <eliz@gnu.org>
7764
0be6ee06
EZ
7765 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7766 character bidirectional type, use STRONG_L instead. Fixes crashes
7767 in a buffer produced by `describe-categories'.
7768
9778ebcc
EZ
7769 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7770 members before the level stack, so they would be saved and
7771 restored when copying iterator state. Fixes incorrect reordering
7772 around TABs covered by display properties.
7773
156bffbe
AS
77742011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7775
6b02f655 7776 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7777
72ad093b
CY
77782011-08-17 Chong Yidong <cyd@stupidchicken.com>
7779
7780 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7781 (internal_condition_case_2, internal_condition_case_n):
7782 Remove unnecessary aborts (Bug#9081).
72ad093b 7783
35774242
EZ
77842011-08-17 Eli Zaretskii <eliz@gnu.org>
7785
7786 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7787 has no `load' handler, try opening the file locally. (Bug#9311)
7788
db76dd85
KB
77892011-08-16 Ken Brown <kbrown@cornell.edu>
7790
7791 * gmalloc.c: Expand comment.
7792
b215eee5
EZ
77932011-08-16 Eli Zaretskii <eliz@gnu.org>
7794
7795 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7796 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7797
a4579d33
KB
77982011-08-16 Ken Brown <kbrown@cornell.edu>
7799
7800 Fix memory allocation problems in Cygwin build (Bug#9273).
7801
7802 * unexcw.c ( __malloc_initialized): Declare external variable.
7803 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7804
8b76d6f8
SM
7805 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7806 New variables.
a4579d33
KB
7807 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7808 dumped emacs.
7809 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7810 in the static heap.
7811 [CYGWIN] (special_realloc): New function.
7812 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7813 requests to realloc storage in the static heap.
7814
3ebec551
PE
78152011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7816
7817 * bidi.c (bidi_initialize): Remove unused local.
7818
9fd8be00
EZ
78192011-08-15 Eli Zaretskii <eliz@gnu.org>
7820
6b02f655
SM
7821 * bidimirror.h:
7822 * biditype.h: Remove file.
7823 * makefile.w32-in ($(BLD)/bidi.$(O)):
7824 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7825
7826 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7827
7828 * chartab.c: Improve commentary for the uniprop_table API.
7829
32413314
EZ
7830 * bidi.c (bidi_paragraph_init): Support zero value of
7831 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7832 (bidi_initialize): Use uniprop_table instead of including
7833 biditype.h and bidimirror.h.
32413314 7834
9fd8be00
EZ
7835 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7836 coordinates of the iterator when restoring from ppos_it.
7837 (Bug#9296)
7838
5cf2b69b
KH
78392011-08-14 Kenichi Handa <handa@m17n.org>
7840
7841 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7842 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7843
daf17d00
EZ
78442011-08-14 Eli Zaretskii <eliz@gnu.org>
7845
7846 * xdisp.c (move_it_in_display_line_to): Don't invoke
7847 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7848 ppos_it. Fixes vertical cursor motion when line beginning is
7849 covered by an image. (Bug#9296)
7850
08e3161a
JD
78512011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7852
7853 * nsterm.h (ns_run_ascript): Declare.
7854 (NSAPP_DATA2_RUNASSCRIPT): Define.
7855
7856 * nsfns.m (as_script, as_result, as_status): New static variables.
7857 (ns_run_ascript): New function.
5e617bc2 7858 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7859 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7860 the event loop. Get status from as_status (Bug#7276).
7861
7862 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7863 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7864 the event loop (Bug#7276).
7865
a3720aa2
AS
78662011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7867
7868 * gnutls.c (QCgnutls_bootprop_priority)
7869 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7870 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7871 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7872 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7873 (QCgnutls_bootprop_verify_hostname_error)
7874 (QCgnutls_bootprop_callbacks_verify): Rename from
7875 Qgnutls_bootprop_..., all uses changed.
7876
7877 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7878 uses changed.
7879
0a0d27fb
PE
78802011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7881
19d5c50c
PE
7882 * xfaces.c (Qframe_set_background_mode): Now static.
7883 * dispextern.h (Qframe_set_background_mode): Remove decl.
7884
0a0d27fb
PE
7885 * process.c (Fnetwork_interface_info): Declare local only if needed.
7886
377538cb
JD
78872011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7888
7889 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7890 (Fnetwork_interface_list): Allocate in increments of bytes instead
7891 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7892 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7893 sockaddr.
7894 (struct ifflag_def): notrailers is smart on OSX.
7895 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7896 Get hardware address with getifaddrs if available.
7897
08fff70c
EZ
78982011-08-12 Eli Zaretskii <eliz@gnu.org>
7899
7900 * xdisp.c (iterate_out_of_display_property): xassert that
7901 IT->position is set to within IT->object's boundaries. Break from
7902 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7903 when IT->position is set up wrongly due to some bug.
7904 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7905 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7906 entry. Force push_it to save on the stack the current
7907 buffer/string position, to be restored by pop_it. Fix flags in
7908 the iterator structure wrt the object coming from a display
7909 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7910 properties. (Bug#9284)
7911
7be1c708 79122011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7913
7be1c708
CY
7914 * fontset.c (fontset_get_font_group): Add proper type checks.
7915 (Bug#9172)
aac0c6e3 7916
7be1c708 79172011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7918
7be1c708
CY
7919 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7920 and LC_VERSION_MIN_MACOSX.
7921 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7922 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7923
97bb72a6
EZ
79242011-08-08 Eli Zaretskii <eliz@gnu.org>
7925
7926 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7927 no-display-properties-and-no-overlays under bidi display.
7928 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7929 properties and overlays.
97bb72a6 7930
d5617611
CY
79312011-08-08 Chong Yidong <cyd@stupidchicken.com>
7932
37e11a63
CY
7933 * editfns.c (Fset_time_zone_rule): Document relationship with the
7934 setenv function.
7935
d5617611
CY
7936 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7937 the font entity extracted from the cache (Bug#8109).
7938
58872834
CY
79392011-08-07 Chong Yidong <cyd@stupidchicken.com>
7940
7941 * composite.c (autocmp_chars): Don't reset point. That is done by
7942 restore_point_unwind (Bug#5984).
7943
75bfc667
JL
79442011-08-07 Juri Linkov <juri@jurta.org>
7945
7946 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7947 to show the arg `TIME' instead of `TIMEVAL'.
7948
d1410150
EZ
79492011-08-06 Eli Zaretskii <eliz@gnu.org>
7950
7951 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7952 display property strides EOL and includes a newline, as in
7953 longlines-mode. (Bug#9254)
75b771e4
EZ
7954 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7955 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7956
7957 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7958 is non-zero, even if the data buffer is NULL. Fixes a crash in
7959 vertical-motion with longlines-mode. (Bug#9254)
7960
35928349
EZ
79612011-08-05 Eli Zaretskii <eliz@gnu.org>
7962
ec7cc85b
EZ
7963 * bidi.c <bidi_cache_total_alloc>: Now static.
7964 (bidi_initialize): Initialize bidi_cache_total_alloc.
7965
8b76d6f8 7966 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7967 cache. (Bug#9221)
7968
7969 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7970 amount allocated this far in `bidi_cache_total_alloc'.
7971 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7972 non-zero, only free the data buffer without restoring the cache
7973 contents. All callers changed.
7974
7975 * dispextern.h (bidi_unshelve_cache): Update prototype.
7976
7977 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7978 (move_it_in_display_line, move_it_to)
7979 (move_it_vertically_backward, move_it_by_lines): Replace the call
7980 to xfree to an equivalent call to bidi_unshelve_cache.
7981 (move_it_in_display_line_to): Fix logic of returning
412b6358 7982 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7983
e2e2423b
EZ
79842011-08-05 Eli Zaretskii <eliz@gnu.org>
7985
7986 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7987 came from a string character with a `cursor' property. (Bug#9229)
7988
ae9e757a
JD
79892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7990
7991 * Makefile.in (LIB_PTHREAD): New variable.
7992 (LIBES): Add LIB_PTHREAD (Bug#9216).
7993
7994 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7995 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7996
213bd7f2
AS
79972011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7998
6b02f655 7999 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8000
99aaf75f
JD
80012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8002
8003 * xterm.c (x_find_topmost_parent): New function.
8004 (x_set_frame_alpha): Find topmost parent window with
8005 x_find_topmost_parent and set the property there also (bug#9181).
8006 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8007
c74e9d86
PE
80082011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8009
8010 * callproc.c (Fcall_process): Avoid vfork clobbering
8011 the local vars buffer, coding_systems, current_dir.
8012
640c8776
SM
80132011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8014
8015 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8016
f26d0e4c
PE
80172011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8018
8a10d76c
PE
8019 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8020 so that it is not optimized away.
8021
f26d0e4c
PE
8022 * xdisp.c (compute_display_string_pos): Remove unused local.
8023
55439c61
EZ
80242011-08-02 Eli Zaretskii <eliz@gnu.org>
8025
8026 Fix slow cursor motion and scrolling in large buffers with
8027 selective display, like Org Mode buffers. (Bug#9218)
8028
8029 * dispextern.h (struct bidi_it): New member disp_prop_p.
8030
8031 * xdisp.c: Remove one-slot cache of display string positions.
8032 (compute_display_string_pos): Accept an additional argument
5e617bc2 8033 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8034 for a display string or property. If found, set DISP_PROP_P
8035 non-zero.
8036
8037 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8038 DISP_PROP_P, and pass it to compute_display_string_pos.
8039 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8040 non-zero. All callers of bidi_fetch_char changed.
8041
fb33fa43
SM
80422011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8043
8044 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8045
b099e063
DM
80462010-12-03 Don March <don@ohspite.net>
8047
8048 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8049 last character M-[char] is translated to ESC [char] (bug#7541).
8050
5cc7f7af
KH
80512011-08-02 Kenichi Handa <handa@m17n.org>
8052
d0fffa3f 8053 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8054
8055 * chartab.c (uniprop_table): Make it non-static.
8056
525d5e6e
EZ
80572011-08-01 Eli Zaretskii <eliz@gnu.org>
8058
8059 * xdisp.c (forward_to_next_line_start): Accept additional argument
8060 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8061 on the newline.
8062 (reseat_at_next_visible_line_start): Use the bidi iterator state
8063 returned by forward_to_next_line_start to restore the state of
8064 it->bidi_it after backing up to previous newline. (Bug#9212)
8065
31011111
AS
80662011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8067
8068 * regex.c (re_comp): Protoize.
8069 (re_exec): Fix return type.
8070 (regexec): Fix type of `ret'. (Bug#9203)
8071
476371c4
PE
80722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8073
e5d76069
PE
8074 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8075 This is needed if max-image-size is a floating-point number.
8076
9a79b20c
AS
80772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8078
8079 * print.c (print_object): Print empty symbol as ##.
8080
8081 * lread.c (read1): Read ## as empty symbol.
8082
d8c2fa78
AA
80832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8084
8085 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8086 setting frame foreground color (Bug#9175).
8087 (x_set_background_color): Likewise.
8088
ffe57a7a
AA
8089 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8090 contents (Bug#9176).
8091 (EmacsTooltip -init): Remove bezels and add shadows to
8092 tooltip windows.
8093
bf3492a5
AA
8094 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8095 or scroll bar (Bug#8470).
8096
d55e9c53
AA
8097 * nsfont.m (nsfont_open): Remove assignment to voffset and
8098 unnecessary vars hshink, expand, hd, full_height, min_height.
8099 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8100
8101 * nsterm.h (nsfont_info): Remove voffset field.
8102
d8c2fa78 81032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8104
8105 Implement strike-through and overline on NextStep (Bug#8863).
8106
8107 * nsfont.m (nsfont_open): Use underline position provided by font,
8108 instead of hard-coded value of 2.
8109 (nsfont_draw): Call ns_draw_text_decoration instead.
8110
8111 * nsterm.h: Add declaration for ns_draw_text_decoration.
8112
8113 * nsterm.m (ns_draw_text_decoration): New function for drawing
8114 underline, overline, and strike-through.
8115 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8116 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8117 accommodate underlining, etc.
4843aac3 8118
4cc60b9b
EZ
81192011-07-28 Eli Zaretskii <eliz@gnu.org>
8120
bc7ece87
EZ
8121 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8122 default.
4cc60b9b 8123
476371c4
PE
81242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8125
66606eea
PE
8126 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8127 Without this fix, if a signal arrives just after memory fills up,
8128 'malloc' might be invoked reentrantly.
8129
476371c4
PE
8130 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8131 In other words, assume that every image size is allowed, on non-X
8132 hosts. This assumption is probably wrong, but it lets Emacs compile.
8133
f3fcc40d
AS
81342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8135
8136 * regex.c (re_iswctype): Convert return values to boolean.
8137
350c992f
EZ
81382011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8139
8140 * xdisp.c (compute_display_string_pos): Don't use cached display
8141 string position if the buffer had its restriction changed.
8142 (Bug#9184)
8143
5266b4bb
PE
81442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8145
8146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8147
2573a837 81482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8149
41f55ccd 8150 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8151
39e378da
PE
8152 * bidi.c: Integer size and overflow fixes.
8153 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8154 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8155 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8156 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8157 (bidi_find_other_level_edge):
8158 Use ptrdiff_t instead of EMACS_INT where either will do.
8159 This works better on 32-bit hosts configured --with-wide-int.
8160 (bidi_cache_ensure_space): Check for size-calculation overflow.
8161 Use % rather than repeated addition, for better worst-case speed.
8162 Don't set bidi_cache_size until after xrealloc returns, because it
8163 might not return.
8164 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8165 (bidi_cache_ensure_space): Also check that the bidi cache size
8166 does not exceed that of the largest Lisp string or buffer. See Eli
8167 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8168
5e927815
PE
8169 * alloc.c (__malloc_size_t): Remove.
8170 All uses replaced by size_t. See Andreas Schwab's note
8171 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8172
ca4aa935
PE
8173 * image.c: Improve checking for integer overflow.
8174 (check_image_size): Assume that f is nonnull, since
8175 it is always nonnull in practice. This is one less thing to
8176 worry about when checking for integer overflow later.
8177 (x_check_image_size): New function, which checks for integer
8178 overflow issues inside X.
8179 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8180 This removes the need for a memory_full check.
8181 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8182 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8183 (xbm_read_bitmap_data): Change locals back to 'int', since
8184 their values must fit in 'int'.
8185 (xpm_load_image, png_load, tiff_load):
8186 Invoke x_create_x_image_and_pixmap earlier,
8187 to avoid much needless work if the image is too large.
8188 (tiff_load): Treat overly large images as if
8189 x_create_x_image_and_pixmap failed, not as malloc failures.
8190 (gs_load): Use x_check_image_size.
8191
5f8f9cc2
PE
8192 * gtkutil.c: Omit integer casts.
8193 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8194 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8195
5adf60bc
PE
8196 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8197
c8907a93
PE
8198 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8199 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8200 would wrongly return t on a 64-bit host.
8201
e3c25c68
PE
8202 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8203 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8204 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8205 and therefore cause GCC to emit a bogus diagnostic in some cases.
8206
3f791afe
PE
8207 * image.c: Integer signedness and overflow and related fixes.
8208 This is not an exhaustive set of fixes, but it's time to
8209 record what I've got.
8210 (lookup_pixel_color, check_image_size): Remove redundant decls.
8211 (check_image_size): Don't assume that arbitrary EMACS_INT values
8212 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8213 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8214 (tiff_load, imagemagick_load_image):
8215 Check for overflow in size calculations.
8216 (x_create_x_image_and_pixmap): Remove unnecessary test for
8217 xmalloc returning NULL; that can't happen.
8218 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8219 (xpm_color_bucket): Use better integer hashing function.
8220 (xpm_cache_color): Don't possibly over-allocate memory.
8221 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8222 (gif_memory_source):
8223 Use ptrdiff_t, not int or size_t, to record sizes.
8224 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8225 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8226 either works, as we prefer signed integers.
8227 (tiff_read_from_memory, tiff_write_from_memory):
8228 Return tsize_t, not size_t, since that's what the TIFF API wants.
8229 (tiff_read_from_memory): Don't fail simply because the read would
8230 go past EOF; instead, return a short read.
8231 (tiff_load): Omit no-longer-needed casts.
8232 (Fimagemagick_types): Don't assume size fits into 'int'.
8233
3cc5a532
PE
8234 Improve hashing quality when configured --with-wide-int.
8235 * fns.c (hash_string): New function, taken from sxhash_string.
8236 Do not discard information about ASCII character case; this
8237 discarding is no longer needed.
8238 (sxhash-string): Use it. Change sig to match it. Caller changed.
8239 * lisp.h: Declare it.
8240 * lread.c (hash_string): Remove, since we now use fns.c's version.
8241 The fns.c version returns a wider integer if --with-wide-int is
8242 specified, so this should help the quality of the hashing a bit.
8243
b312a492
PE
8244 * emacs.c: Integer overflow minor fix.
8245 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8246 Define only if GNU_LINUX.
8247 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8248
dfd153ae
PE
8249 * dispnew.c: Integer signedness and overflow fixes.
8250 Remove unnecessary forward decls, that were a maintenance hassle.
8251 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8252 All uses changed.
8253 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8254 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8255 (prepare_desired_row, line_draw_cost):
8256 Use int, not unsigned, where either works.
8257 (save_current_matrix, restore_current_matrix):
8258 Use ptrdiff_t, not size_t, where either works.
8259 (init_display): Check for overflow more accurately, and without
8260 relying on undefined behavior.
8261
a81d11a3
PE
8262 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8263 Remove, replacing with the new symbols in lisp.h. All uses changed.
8264 * fileio.c (make_temp_name):
8265 * filelock.c (lock_file_1, lock_file):
8266 * xdisp.c (message_dolog):
8267 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8268 Use pMd etc. instead.
8269 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8270 replacing the pWIDE etc. symbols removed from editfns.c.
8271
3300e6fd
PE
8272 * keyboard.h (num_input_events): Now uintmax_t.
8273 This is (very slightly) less likely to mess up due to wraparound.
8274 All uses changed.
8275
fd05c7e9
PE
8276 * buffer.c: Integer signedness fixes.
8277 (alloc_buffer_text, enlarge_buffer_text):
8278 Use ptrdiff_t rather than size_t when either will do, as we prefer
8279 signed integers.
8280
903fe15d
PE
8281 * alloc.c: Integer signedness and overflow fixes.
8282 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8283 (__malloc_size_t): Default to size_t, not to int.
8284 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8285 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8286 Prefer ptrdiff_t to size_t when either would do, as we prefer
8287 signed integers.
8288 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8289 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8290 Now const. Initialize with values that are in range even if char
8291 is signed.
8292 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8293 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8294 These functions do the right thing with sizes > 2**32.
8295 (check_depth): Now ptrdiff_t, not int.
8296 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8297 Adjust to new way of storing sizes. Check for size overflow bugs
8298 in rest of code.
8299 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8300 slightly wrong anyway, as it missed one instance of
8301 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8302 (refill_memory_reserve): Omit needless cast to size_t.
8303 (mark_object_loop_halt): Mark as externally visible.
8304
ac82cc6a
PE
8305 * xselect.c: Integer signedness and overflow fixes.
8306 (Fx_register_dnd_atom, x_handle_dnd_message):
8307 Use ptrdiff_t, not size_t, since we prefer signed.
8308 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8309 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8310 x_dnd_atoms_size and x_dnd_atoms_length.
8311
c2d1e36d
PE
8312 * doprnt.c: Prefer signed to unsigned when either works.
8313 * eval.c (verror):
8314 * doprnt.c (doprnt):
8315 * lisp.h (doprnt):
8316 * xdisp.c (vmessage):
8317 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8318 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8319 prefer signed arithmetic to avoid comparison confusion.
8320 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8321 but is a bit tricky.
8322
0e926e56
PE
8323 Assume freestanding C89 headers, string.h, stdlib.h.
8324 * data.c, doprnt.c, floatfns.c, print.c:
8325 Include float.h unconditionally.
8326 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8327 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8328 * regex.c: Likewise for stddef.h, string.h.
8329 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8330 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8331 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8332 (STDC_HEADERS): Remove obsolete defines.
8333 * sysdep.c: Include limits.h unconditionally.
8334
9cfdb3ec
PE
8335 Assume support for memcmp, memcpy, memmove, memset.
8336 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8337 * regex.c (memcmp, memcpy):
8338 Remove; we assume C89 now.
8339
8340 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8341 (__malloc_safe_bcopy): Remove; no longer needed.
8342
cf950e6b 8343 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8344 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8345 well either way, and we prefer signed to unsigned.
8346
dbf38e02
LMI
83472011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8348
8349 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8350 closes the connection while we're reading (bug#9182).
8351
d6f0886c 83522011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8353
d6f0886c
JD
8354 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8355 are specified (Bug#9168).
24e0f6b1 8356
2eb1f9e6
PE
83572011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8358
8359 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8360 Found by GCC static checking and --with-wide-int on a 32-bit host.
8361
22381272 83622011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8363
8364 * xdisp.c (compute_display_string_pos): Fix logic of caching
8365 previous display string position. Initialize cached_prev_pos to
8366 -1. Fixes slow-down at the beginning of a buffer.
8367
f25e39b4
EZ
83682011-07-24 Eli Zaretskii <eliz@gnu.org>
8369
8370 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8371 for attrs[LFACE_FONTSET_INDEX].
8372
04c4b52e
PE
83732011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8374
8375 * xml.c (parse_region): Remove unused local
8376 that was recently introduced.
8377
c1734fbd
EZ
83782011-07-23 Eli Zaretskii <eliz@gnu.org>
8379
be18c5a5
EZ
8380 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8381 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8382
c1734fbd
EZ
8383 * xdisp.c (move_it_in_display_line_to): Record the best matching
8384 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8385 exit if none of the characters scanned was an exact match.
8386 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8387 when exact match is impossible due to invisible text, and the
8388 lines are truncated.
8389
a258d627
JD
83902011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8391
8392 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8393 for OSX >= 10.7.
8394
b6d5a689
EZ
83952011-07-22 Eli Zaretskii <eliz@gnu.org>
8396
0f74f785
EZ
8397 Fix a significant slow-down of cursor motion with C-n, C-p,
8398 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8399 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8400 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8401 (next_element_from_buffer): Call compute_stop_pos_backwards to
8402 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8403 base_level_stop.
8404 (reseat): Don't look for prev_stop, as that could mean a very long
8405 run.
8406 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8407 <cached_disp_overlay_modiff>: Cache for last found display string
8408 position.
551918c1 8409 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8410 about the same buffer in the same area of character positions, and
8411 the buffer wasn't changed since the time the display string
8412 position was cached.
551918c1 8413
b2d0c91a
EZ
84142011-07-22 Eli Zaretskii <eliz@gnu.org>
8415
8416 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8417 is an integer, which is important for empty lines. (Bug#9149)
8418
043604ee
CY
84192011-07-22 Chong Yidong <cyd@stupidchicken.com>
8420
8421 * frame.c (Fmodify_frame_parameters): In tty case, update the
8422 default face if necessary (Bug#4238).
8423
da4adb04
CY
84242011-07-21 Chong Yidong <cyd@stupidchicken.com>
8425
8426 * editfns.c (Fstring_to_char): No need to explain what a character
8427 is in the docstring (Bug#6576).
8428
9abd0532
LMI
84292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8430
8431 * xml.c (parse_region): Make sure we always return a tree.
8432
36881d16
HK
84332011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8434
8435 * xml.c (parse_region): If a document contains only comments,
8436 return that, too.
8437
1e98674d
LMI
84382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8439
8440 * xml.c (make_dom): Return comments, too.
8441
590bd467
PE
84422011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8443
8444 Port to OpenBSD.
8445 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8446 and the surrounding thread.
8447 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8448 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8449 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8450 timer goes off.
8451 * s/openbsd.h (BROKEN_SIGIO): Define.
8452 * unexelf.c (unexec) [__OpenBSD__]:
8453 Don't update the .mdebug section of the Alpha COFF symbol table.
8454
f41628b2
LMI
84552011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8456
8457 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8458 (bug#8460).
8459
b59b67c5
PE
84602011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8461
15e3a074
PE
8462 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8463 This fixes some race conditions on the permissions of any newly
8464 created file.
8465
41bed37d
PE
8466 * alloc.c (valid_pointer_p): Use pipe, not open.
8467 This fixes some permissions issues when debugging.
8468
b59b67c5
PE
8469 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8470 If fchown fails to set both uid and gid, try to set just gid,
8471 as that is sometimes allowed. Adjust the file's mode to eliminate
8472 setuid or setgid bits that are inappropriate if fchown fails.
8473
925a6be7
SM
84742011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8475
8476 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8477 to compare Lisp_Objects.
8478 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8479 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8480 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8481
52968808
AS
84822011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8483
0a6a104b
AS
8484 * lread.c (read_integer): Unread even EOF character.
8485 (read1): Likewise. Properly record start position of symbol.
8486
52968808
AS
8487 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8488 symbol character follows.
8489
9e381cdd
PE
84902011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8491
8492 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8493 This works around a problem with the previous change to Fcopy_file.
8494 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8495 and without this change, GCC might complain about discarding
8496 fchown's return value.
8497
b5641435
JB
84982011-07-16 Juanma Barranquero <lekktu@gmail.com>
8499
8500 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8501
a8031457
PE
85022011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8503
8504 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8505
dd889327
LMI
85062011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8507
750c33f7
LMI
8508 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8509 it's used from the C level.
8510
dd889327
LMI
8511 * process.c: Use the same condition for POLL_FOR_INPUT in both
8512 keyboard.c and process.c (bug#1858).
8513
87e86684
LM
85142011-07-09 Lawrence Mitchell <wence@gmx.li>
8515
8516 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8517 (Fgnutls_boot): Use it.
8518
64348f40
AS
85192011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8520
8521 * doc.c (Fsubstitute_command_keys): Revert last change.
8522
1d698799
LMI
85232011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8524
f863868c
LMI
8525 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8526 quotes the next character, and doesn't affect other longer
8527 sequences (bug#8935).
8528
1d698799
LMI
8529 * lread.c (syms_of_lread): Clarify that is isn't only
8530 `eval-buffer' and `eval-defun' that's affected by
8531 `lexical-binding' (bug#8460).
8532
aa4b6df6
EZ
85332011-07-15 Eli Zaretskii <eliz@gnu.org>
8534
8535 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8536 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8537
5d856da6
PE
85382011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8539
ad6042bb
PE
8540 Fix minor problems found by static checking.
8541 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8542 (elsz): Now a signed constant, not a size_t var. We prefer signed
8543 types to unsigned, to avoid integer comparison confusion. Without
8544 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8545 "cannot optimize loop, the loop counter may overflow", a symptom
8546 of the confusion.
f00bbb22 8547 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8548 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8549
6468f31c
LMI
85502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8551
49080b10
LMI
8552 * search.c (Fre_search_backward): Mention `case-fold-search' in
8553 all the re_search_* functions (bug#8138).
8554
6468f31c
LMI
8555 * keyboard.c (Fopen_dribble_file): Document when the file is
8556 closed (bug#8056).
8557
c965adc5
EZ
85582011-07-14 Eli Zaretskii <eliz@gnu.org>
8559
df9733bf
EZ
8560 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8561 bidi_cache_idx.
8562
0bb23927
EZ
8563 Support bidi reordering of display and overlay strings.
8564 * xdisp.c (compute_display_string_pos)
8565 (compute_display_string_end): Accept additional argument STRING.
8566 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8567 (reseat_to_string): Initialize bidi_it->string.s and
8568 bidi_it->string.schars.
8569 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8570 NULL (avoids a crash in bidi_paragraph_init).
8571 Initialize itb.string.lstring.
0bb23927
EZ
8572 (init_iterator): Call bidi_init_it only of a valid
8573 buffer position was specified. Initialize paragraph_embedding to
8574 L2R.
8575 (reseat_to_string): Initialize the bidi iterator.
8576 (display_string): If we need to ignore text properties of
8577 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8578 original value of -1 will not work with bidi.)
8579 (compute_display_string_pos): First arg is now struct
8580 `text_pos *'; all callers changed. Support display properties on
8581 Lisp strings.
8582 (compute_display_string_end): Support display properties on Lisp
8583 strings.
8584 (init_iterator, reseat_1, reseat_to_string): Initialize the
8585 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8586 when iterating on a string not from display properties).
640c8776
SM
8587 (compute_display_string_pos, compute_display_string_end):
8588 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8589 arrow keys.
8590 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8591 base_level_stop; instead, set base_level_stop to BEGV.
8592 Fixes crashes in vertical-motion.
0bb23927
EZ
8593 (next_element_from_buffer): Improve commentary for when
8594 the iterator is before prev_stop.
8595 (init_iterator): Initialize bidi_p from the default value of
8596 bidi-display-reordering, not from buffer-local value. Use the
8597 buffer-local value only if initializing for buffer iteration.
8598 (handle_invisible_prop): Support invisible properties on strings
8599 that are being bidi-reordered.
8600 (set_iterator_to_next): Support bidi reordering of C strings and
8601 Lisp strings.
8602 (next_element_from_string): Support bidi reordering of Lisp
8603 strings.
8604 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8605 (display_string): Support display of R2L glyph rows.
8606 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8607 (init_iterator): Don't initialize it->bidi_p for strings
8608 here.
8609 (reseat_to_string): Initialize it->bidi_p for strings here.
8610 (next_element_from_string, next_element_from_c_string)
8611 (next_element_from_buffer): Add xassert's for correspondence
8612 between IT's object being iterated and it->bidi_it.string
8613 structure.
8614 (face_before_or_after_it_pos): Support bidi iteration.
8615 (next_element_from_c_string): Handle the case of the first string
8616 character that is not the first one in the visual order.
8617 (get_visually_first_element): New function, refactored from common
8618 parts of next_element_from_buffer, next_element_from_string, and
8619 next_element_from_c_string.
8620 (tool_bar_lines_needed, redisplay_tool_bar)
8621 (display_menu_bar): Force left-to-right direction. Add a FIXME
8622 comment for making that be controlled by a user option.
8623 (push_it, pop_it): Save and restore the state of the
8624 bidi iterator. Save and restore the bidi_p flag.
8625 (pop_it): Iterate out of display property for string iteration as
8626 well.
8627 (iterate_out_of_display_property): Support iteration over strings.
8628 (handle_single_display_spec): Set up it->bidi_it for iteration
8629 over a display string, and call bidi_init_it.
8630 (handle_single_display_spec, next_overlay_string)
8631 (get_overlay_strings_1, push_display_prop): Set up the bidi
8632 iterator for displaying display or overlay strings.
8633 (forward_to_next_line_start): Don't use the shortcut if
8634 bidi-iterating.
8635 (back_to_previous_visible_line_start): If handle_display_prop
8636 pushed the iterator stack, restore the internal state of the bidi
8637 iterator by calling bidi_pop_it same number of times.
8638 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8639 and we are bidi-iterating, don't decrement the iterator position;
8640 instead, set the first_elt flag in the bidi iterator, to produce
8641 the same effect.
8642 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8643 (push_display_prop): xassert that we are iterating a buffer.
8644 (push_it, pop_it): Save and restore paragraph_embedding member.
8645 (handle_single_display_spec, next_overlay_string)
8646 (get_overlay_strings_1, reseat_1, reseat_to_string)
8647 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8648 correctly. Don't assume unibyte strings are not bidi-reordered.
8649 (compute_display_string_pos)
8650 (compute_display_string_end): Fix handling the case of C string.
8651 (push_it, pop_it): Save and restore from_disp_prop_p.
8652 (handle_single_display_spec, push_display_prop): Set the
8653 from_disp_prop_p flag.
8654 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8655 (pop_it): Call iterate_out_of_display_property only if we are
8656 popping after iteration over a string that came from a display
8657 property. Fix a typo in popping stretch info. Add an assertion
8658 for verifying that the iterator position is in sync with the bidi
8659 iterator.
8660 (handle_single_display_spec, get_overlay_strings_1)
8661 (push_display_prop): Fix initialization of paragraph direction for
8662 string when that of the parent object is not yet determined.
8663 (reseat_1): Call bidi_init_it to resync the bidi
8664 iterator with IT's position. (Bug#7616)
8665 (find_row_edges): If ROW->start.pos gives position
8666 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8667 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8668 Reset the from_disp_prop_p flag.
8669 (SAVE_IT, RESTORE_IT): New macros.
8670 (pos_visible_p, face_before_or_after_it_pos)
8671 (back_to_previous_visible_line_start)
8672 (move_it_in_display_line_to, move_it_in_display_line)
8673 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8674 (try_scrolling, redisplay_window, display_line): Use them when
8675 saving a temporary copy of the iterator and restoring it back.
8676 (back_to_previous_visible_line_start, reseat_1)
8677 (init_iterator): Empty the bidi cache "stack".
8678 (move_it_in_display_line_to): If iterator ended up at
8679 EOL, but we never saw any buffer positions smaller than
8680 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8681 motion in bidi-reordered lines.
8682 (move_it_in_display_line_to): Record prev_method and prev_pos
8683 immediately before the call to set_iterator_to_next. Fixes cursor
8684 motion in bidi-reordered lines with stretch glyphs and strings
8685 displayed in margins. (Bug#8133) (Bug#8867)
8686 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8687 TO_CHARPOS.
640c8776
SM
8688 (pos_visible_p): Support positions in bidi-reordered lines.
8689 Save and restore bidi cache.
0bb23927
EZ
8690
8691 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8692 (bidi_paragraph_info): Delete unused struct.
8693 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8694 (bidi_cache_start): New variable.
8695 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8696 to zero.
8697 (bidi_cache_fetch_state, bidi_cache_search)
8698 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8699 (bidi_cache_find, bidi_peek_at_next_level)
8700 (bidi_level_of_next_char, bidi_find_other_level_edge)
8701 (bidi_move_to_visually_next): Compare cache index with
8702 bidi_cache_start rather than with zero.
8703 (bidi_fetch_char): Accept new argument STRING; all callers
8704 changed. Support iteration over a string. Support strings with
8705 display properties. Support unibyte strings. Fix the type of
8706 `len' according to what STRING_CHAR_AND_LENGTH expects.
8707 (bidi_paragraph_init, bidi_resolve_explicit_1)
8708 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8709 (bidi_level_of_next_char, bidi_move_to_visually_next):
8710 Support iteration over a string.
0bb23927
EZ
8711 (bidi_set_sor_type, bidi_resolve_explicit_1)
8712 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8713 can now be zero (for strings); special values 0 and -1 were
8714 changed to -1 and -2, respectively.
8715 (bidi_char_at_pos): New function.
8716 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8717 Call it instead of FETCH_MULTIBYTE_CHAR.
8718 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8719 initialized to valid values.
8720 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8721 values.
8722 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8723 the test for valid cached positions. Fix the logic for looking up
8724 the sentinel state in the cache. GCPRO the Lisp string we are
8725 iterating.
8726 (bidi_push_it, bidi_pop_it): New functions.
8727 (bidi_initialize): Initialize the bidi cache start stack pointer.
8728 (bidi_cache_ensure_space): New function, refactored from part of
8729 bidi_cache_iterator_state. Don't assume the required size is just
8730 one BIDI_CACHE_CHUNK away.
8731 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8732 (bidi_count_bytes, bidi_char_at_pos): New functions.
8733 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8734 always valid if bidi_cache_idx is valid.
8735 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8736 is valid if it's going to be used.
8737 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8738 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8739 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8740 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8741 (bidi_find_other_level_edge, bidi_cache_start_stack):
8742 All variables related to cache indices are now EMACS_INT.
c965adc5 8743
0bb23927
EZ
8744 * dispextern.h (struct bidi_string_data): New structure.
8745 (struct bidi_it): New member `string'. Make flag members be 1-bit
8746 fields, and put them last in the struct.
640c8776
SM
8747 (compute_display_string_pos, compute_display_string_end):
8748 Update prototypes.
0bb23927
EZ
8749 (bidi_push_it, bidi_pop_it): Add prototypes.
8750 (struct iterator_stack_entry): New members bidi_p,
8751 paragraph_embedding, and from_disp_prop_p.
8752 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8753 (bidi_shelve_cache, bidi_unshelve_cache):
8754 Declare prototypes.
0bb23927
EZ
8755
8756 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8757 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8758 and vector-like objects.
8759
8760 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8761 cache around display iteration.
8762
8763 * window.c (Fwindow_end, window_scroll_pixel_based)
8764 (displayed_window_lines, Frecenter): Save and restore the bidi
8765 cache around display iteration.
8766
3bbd2265
LMI
87672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8768
8769 * editfns.c (Fdelete_region): Clarify the use of the named
8770 parameters (bug#6788).
8771
adc47434
MR
87722011-07-14 Martin Rudalics <rudalics@gmx.at>
8773
8774 * indent.c (Fvertical_motion): Set and restore w->pointm when
8775 saving and restoring the window's buffer (Bug#9006).
8776
837c31f8
LMI
87772011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8778
8779 * editfns.c (Fstring_to_char): Clarify just what is returned
8780 (bug#6576). Text by Eli Zaretskii.
8781
ac389d0c
JB
87822011-07-13 Juanma Barranquero <lekktu@gmail.com>
8783
8784 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8785
0be0ce47
EZ
87862011-07-13 Eli Zaretskii <eliz@gnu.org>
8787
8788 * buffer.c (mmap_find): Fix a typo.
8789
cd18e7e3
JB
87902011-07-13 Johan Bockgård <bojohan@gnu.org>
8791
8792 Fix execution of x selection hooks.
8793 * xselect.c (Qx_lost_selection_functions)
8794 (Qx_sent_selection_functions): New vars.
8795 (syms_of_xselect): DEFSYM them.
8796 (x_handle_selection_request): Pass Qx_sent_selection_functions
8797 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8798 (x_handle_selection_clear,x_clear_frame_selections):
8799 Pass Qx_lost_selection_functions rather than
8800 Vx_lost_selection_functions to Frun_hook_with_args.
8801
47ea7f44
PE
88022011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8803
ac389d0c 8804 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8805 The old code sometimes used this field without initializing it.
8806
47ea7f44
PE
8807 * alloc.c (gc_sweep): Don't read past end of array.
8808 In theory, the old code could also have corrupted Emacs internals,
8809 though it'd be very unlikely.
8810
bc985c87
AS
88112011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8812
8813 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8814 argument. (Bug#4026)
bc985c87 8815
0cf34688
LMI
88162011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8817
b3dadd76
LMI
8818 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8819 key" (bug#4257).
8820
0cf34688
LMI
8821 * window.c (Fset_window_start): Doc fix (bug#4199).
8822 (Fset_window_hscroll): Ditto.
8823
270768cd
PE
88242011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8825
077e3dda 8826 Fix minor new problems caught by GCC 4.6.1.
270768cd 8827 * term.c (init_tty): Remove unused local.
490011a6 8828 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8829 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8830 not used otherwise.
270768cd 8831
b1f58454
CY
88322011-07-12 Chong Yidong <cyd@stupidchicken.com>
8833
8834 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8835
22b9578d
LMI
88362011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8837
6e70ab07
LMI
8838 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8839 are the mini-buffer and the echo area (bug#3320).
8840
22b9578d
LMI
8841 * term.c (init_tty): Remove support for supdup, c10 and perq
8842 terminals, which are no longer supported (bug#1482).
8843
8974cc9f
JB
88442011-07-10 Johan Bockgård <bojohan@gnu.org>
8845
8846 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8847
a560d974
JD
88482011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8849
8850 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8851 for non-popups (Bug#3642).
8852
1dae0f0a
AS
88532011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8854
268c2c36 8855 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8856 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8857 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8858 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8859 * data.c (fmod): Likewise.
8860 * dispnew.c (swap_glyphs_in_rows): Likewise.
8861 * emacs.c (memory_warning_signal): Likewise.
8862 * floatfns.c (float_error): Likewise.
8863 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8864 (otf_open, font_otf_capability, generate_otf_features)
8865 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8866 Likewise.
8867 * image.c (pbm_read_file): Likewise.
8868 * indent.c (string_display_width): Likewise.
8869 * intervals.c (check_for_interval, search_for_interval)
8870 (inc_interval_count, count_intervals, root_interval)
8871 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8872 * lread.c (defalias): Likewise.
268c2c36 8873 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8874 * regex.c (set_image_of_range_1, set_image_of_range)
8875 (regex_grow_registers): Likewise.
8876 * sysdep.c (strerror): Likewise.
8877 * termcap.c (valid_filename_p, tprint, main): Likewise.
8878 * tparam.c (main): Likewise.
8879 * unexhp9k800.c (run_time_remap, save_data_space)
8880 (update_file_ptrs, read_header, write_header, calculate_checksum)
8881 (copy_file, copy_rest, display_header): Likewise.
8882 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8883 Likewise.
8884 * xdisp.c (check_it): Likewise.
8885 * xfaces.c (register_color, unregister_color, unregister_colors):
8886 Likewise.
8887 * xfns.c (print_fontset_result): Likewise.
8888 * xrdb.c (member, fatal, main): Likewise.
8889
99033785
PE
88902011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8891
8892 Fix minor problems found by static checking (Bug#9031).
8893 * chartab.c (char_table_set_range, map_sub_char_table):
8894 Remove unused locals.
8895 (uniprop_table): Now static.
8896 * composite.c (_work_char): Remove unused static var.
8897
9cb2ac56
JB
88982011-07-09 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8901
f25661f0
JD
89022011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8903
8904 * gtkutil.c (qttip_cb): Remove code without function.
8905
8278c4fe
EZ
89062011-07-09 Eli Zaretskii <eliz@gnu.org>
8907
8908 * w32.c (pthread_sigmask): New stub.
8909
1692ae2d 89102011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8911
8a6ebd58 8912 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8913 sigprocmask is portable only for single-threaded applications, and
8914 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8915 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8916 (LIBES): Use it.
8917 * callproc.c (Fcall_process):
8918 * process.c (create_process):
8919 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8920 Use pthread_sigmask, not sigprocmask.
123403e4 8921
1b854618
JD
89222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8923
8924 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8925 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8926 wrong (Bug#8591).
8927
3fe4b549
JD
89282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8929
0ce7e563
JD
8930 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8931 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8932 (xg_hide_tooltip): Fix comment.
8933
3fe4b549
JD
8934 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8935 in registerServicesMenuSendTypes.
8936 (validRequestorForSendType): Don't check ns_return_types.
8937
8938 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8939 ns_return_type.
8940
5df75e47
JR
89412011-07-08 Jason Rumney <jasonr@gnu.org>
8942
22610910
JR
8943 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8944 SH_SHOW for hidden windows (Bug#5482).
8945
5df75e47
JR
8946 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8947 frame struct members of non-existent frames (Bug#6284).
8948
699c10bd
JD
89492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8950
4393663b
JD
8951 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8952 variable firstTime not needed on OSX >= 10.6.
8953 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8954 >= 10.5. Use setKnobProportion, setDoubleValue.
8955
8956 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8957 (MAC_OS_X_VERSION_10_5): Define if not defined.
8958 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8959 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8960 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8961
8962 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8963 cString and lossyCString on OSX >= 10.4.
4393663b 8964
58179cce 8965 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8966 sizeToFit on OSX >= 10.2.
8967
8968 * nsimage.m (allocInitFromFile): Don't use deprecated method
8969 bestRepresentationForDevice on OSX >= 10.6.
8970
8971 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8972 to avoid warning.
8973
8974 * emacs.c: Declare unexec_init_emacs_zone.
8975
a63e0781
JD
8976 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8977
699c10bd
JD
8978 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8979
8980 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8981 on svcsMenu (Bug#8842).
8982
8983 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8984 ns_return_types.
8985 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8986
8987 * nsterm.m (QUTF8_STRING): Declare.
8988 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8989 (validRequestorForSendType): Return type is (id).
8990 Change indexOfObjectIdenticalTo to indexOfObject.
8991 Check if we have local selection before returning self (Bug#8842).
8992 (writeSelectionToPasteboard): Put local selection into paste board
8993 if we have a local selection (Bug#8842).
8994 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8995
8996 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8997 (ns_get_local_selection): Declare.
8998
54e10184
LMI
89992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9000
9888ff71
LMI
9001 * keymap.c (describe_map_tree): Don't insert a double newline at
9002 the end of the buffer (bug#1169) and return whether we inserted
9003 something.
9004
54e10184
LMI
9005 * callint.c (Fcall_interactively): Change "reading args" to
9006 "providing args" to try to clarify what it does (bug#1010).
9007
15fa4783
KH
90082011-07-07 Kenichi Handa <handa@m17n.org>
9009
9010 * composite.c (composition_compute_stop_pos): Ignore a static
9011 composition starting before CHARPOS (Bug#8915).
9012
9013 * xdisp.c (handle_composition_prop): Likewise.
9014
a8815b00
EZ
90152011-07-07 Eli Zaretskii <eliz@gnu.org>
9016
9017 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9018 (Bug#9015)
9019
ef7b981d 90202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9021
9022 * character.h (unicode_category_t): New enum type.
9023
9024 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9025 (Qchar_code_property_table): New variable.
9026 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9027 (UNIPROP_COMPRESSED_FORM_P): New macros.
9028 (char_table_ascii): Uncompress the compressed values.
9029 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9030 Uncompress the compressed values.
ac389d0c 9031 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9032 (char_table_ref_and_range): Uncompress the compressed values.
9033 (sub_char_table_set): New arg is_uniprop. Callers changed.
9034 Uncompress the compressed values.
9035 (sub_char_table_set_range): Args changed. Callers changed.
9036 (char_table_set_range): Adjuted for the above change.
9037 (map_sub_char_table): Delete args default_val and parent. Add arg
9038 top. Give decoded values to a Lisp function.
640c8776 9039 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9040 values to a Lisp function. Gcpro more variables.
9041 (uniprop_table_uncompress)
9042 (uniprop_decode_value_run_length): New functions.
9043 (uniprop_decoder, uniprop_decoder_count): New variables.
9044 (uniprop_get_decoder, uniprop_encode_value_character)
9045 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9046 New functions.
9047 (uniprop_encoder, uniprop_encoder_count): New variables.
9048 (uniprop_get_encoder, uniprop_table)
9049 (Funicode_property_table_internal, Fget_unicode_property_internal)
9050 (Fput_unicode_property_internal): New functions.
9051 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9052 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9053 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9054 char-code-property-alist.
9055
640c8776 9056 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9057 Vunicode_category_table.
9058
640c8776 9059 * font.c (font_range): Adjust for the change of
c805dec0
KH
9060 Vunicode_category_table.
9061
76b397fb
DN
90622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9063
9064 * m/iris4d.h: Remove file, move contents ...
9065 * s/irix6-5.h: ... here.
9066
22b4128e
PE
90672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9068
9069 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9070 * alloc.c (mark_buffer):
9071 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9072 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9073 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9074 This isn't true in general, and it's particularly not true
9075 if Emacs is configured with --with-wide-int.
9076 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9077 New macros, used in the buffer.c change.
9078
869795d6
JD
90792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9080
9081 * xsettings.c: Use both GConf and GSettings if both are available.
9082 (store_config_changed_event): Add comment.
9083 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9084 (store_tool_bar_style_changed): New functions.
5e617bc2 9085 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9086 (struct xsettings): Move font inside HAVE_XFT.
9087 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9088 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9089 Move inside HAVE_XFT.
640c8776 9090 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9091 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9092 also.
9093 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9094 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9095 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9096 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9097 (parse_settings): Move check for font inside HAVE_XFT.
9098 (read_settings, apply_xft_settings): Add comment.
9099 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9100 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9101 call store_font_name_changed.
9102 (xft_settings_event): Add comment.
9103 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9104 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9105 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9106 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9107 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9108 (xsettings_get_system_font, xsettings_get_system_normal_font):
9109 Add comment.
869795d6 9110
d8ed26bd
PE
91112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9112
9113 Random fixes. E.g., (random) never returned negative values.
9114 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9115 subseconds part to the entropy, as that's a bit more random.
9116 Prefer signed to unsigned, since the signedness doesn't matter and
9117 in general we prefer signed. When given a limit, use a
9118 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9119 latter isn't right if USE_2_TAGS_FOR_INTS.
9120 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9121 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9122
cabf1cac
SM
91232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9124
9125 * textprop.c (text_property_stickiness):
9126 Obey Vtext_property_default_nonsticky.
9127 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9128 * w32fns.c (syms_of_w32fns):
9129 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9130
6e9b2be9
PE
91312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9132
9133 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9134 This is more efficient than Ffile_directory_p and avoids a minor race.
9135
90186c68
LMI
91362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9137
7c301272
LMI
9138 * buffer.c (Foverlay_put): Say what the return value is
9139 (bug#7835).
9140
c4f2d8d4
LMI
9141 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9142 is a directory before asking whether to use the file name
9143 (bug#7564).
ad637907
LMI
9144 (barf_or_query_if_file_exists): Make the "File is a directory"
9145 error be more correct.
c4f2d8d4 9146
90186c68
LMI
9147 * fns.c (Frequire): Remove the mention of the .gz files, since
9148 that's installation-specific, but keep the mention of
9149 `get-load-suffixes'.
9150
da64016e
PE
91512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9152
9153 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9154 Report string overflow if the output is too long.
9155
7d47b580
JB
91562011-07-04 Juanma Barranquero <lekktu@gmail.com>
9157
a555cb87
JB
9158 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9159 (syms_of_gnutls): Remove duplicate DEFSYM for
9160 Qgnutls_bootprop_verify_hostname_error, an error for
9161 Qgnutls_bootprop_verify_error (which is no longer used).
9162
7d47b580
JB
9163 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9164 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9165 Also (re)move comments that are misplaced or no longer relevant.
9166
1e49bfab
LMI
91672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9168
9169 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9170
1485f4c0
CY
91712011-07-03 Chong Yidong <cyd@stupidchicken.com>
9172
9173 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9174 and background color parameters if they have been changed.
9175
a9ab721e
LMI
91762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9177
9178 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9179
cf7cff57
PE
91802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9181
2e13213d
PE
9182 * xsettings.c (SYSTEM_FONT): Define only when used.
9183 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9184
cf7cff57
PE
9185 * keymap.c (access_keymap_1): Now static.
9186
7a8e04f7
CY
91872011-07-02 Chong Yidong <cyd@stupidchicken.com>
9188
9189 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9190 leave any prefix arg for the up event (Bug#1586).
9191
61352f62
LMI
91922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9193
69bb1ef7
LMI
9194 * lread.c (syms_of_lread): Mention single symbols defined by
9195 `defvar' or `defconst' (bug#7154).
9196
61352f62 9197 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9198 (Frequire): Mention get-load-suffixes.
61352f62 9199
28545e04
MR
92002011-07-02 Martin Rudalics <rudalics@gmx.at>
9201
9202 * window.h (window): Remove clone_number slot.
9203 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9204 Remove.
9205 (make_parent_window, make_window, saved_window)
9206 (Fset_window_configuration, save_window_save): Don't deal with
9207 clone numbers.
9208 * buffer.c (Qclone_number): Remove declaration.
9209 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9210
3349e122
SM
92112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9212
9213 Add multiple inheritance to keymaps.
9214 * keymap.c (Fmake_composed_keymap): New function.
9215 (Fset_keymap_parent): Simplify.
9216 (fix_submap_inheritance): Remove.
9217 (access_keymap_1): New function extracted from access_keymap to handle
9218 embedded parents and handle lists of maps.
9219 (access_keymap): Use it.
9220 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9221 (Fcopy_keymap): Handle embedded parents.
9222 (Fcommand_remapping, define_as_prefix): Simplify.
9223 (Fkey_binding): Simplify.
9224 (syms_of_keymap): Move minibuffer-local-completion-map,
9225 minibuffer-local-filename-completion-map,
9226 minibuffer-local-must-match-map, and
9227 minibuffer-local-filename-must-match-map to Elisp.
9228 (syms_of_keymap): Defsubr make-composed-keymap.
9229 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9230 (parse_menu_item): Trivial simplification.
9231
3279eb87
GM
92322011-07-01 Glenn Morris <rgm@gnu.org>
9233
9234 * Makefile.in (SETTINGS_LIBS): Fix typo.
9235
4550efdf
KI
92362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9237
9238 * coding.c (Fencode_coding_string): Record the last coding system
9239 used, as the function doc string says (bug#8738).
9240
0949d2b6
JD
92412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9242
9243 * xsettings.c (store_monospaced_changed): Take new font as arg and
9244 check for change against current_mono_font.
9245 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9246 (emacs_settings_constructor, emacs_settings_get_property)
9247 (emacs_settings_set_property, emacs_settings_class_init)
9248 (emacs_settings_init, gsettings_obj): Remove.
9249 (something_changedCB): New function for HAVE_GSETTINGS.
9250 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9251 with value as argument.
9252 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9253 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9254 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9255 "changed".
9256
9257 * xgselect.c: Add defined (HAVE_GSETTINGS).
9258 (xgselect_initialize): Ditto.
9259
9260 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9261 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9262 xg_select.
9263
bbc6b304
PE
92642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9265
9266 * eval.c (struct backtrace): Simplify and port the data structure.
9267 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9268 signed bit field, as this assumption is not portable and it makes
9269 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9270 "char debug_on_exit : 1" as this is not portable either; instead,
9271 use the portable "unsigned int debug_on_exit : 1". Remove unused
9272 member evalargs. Remove obsolete comments about cc bombing out.
9273
9851bfc5
JD
92742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9275
51bb811f 9276 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9277 Let HAVE_GSETTINGS override HAVE_GCONF.
9278 (store_monospaced_changed): New function.
9279 (EMACS_SETTINGS): A new type derived from GObject to handle
9280 GSettings notifications.
9281 (emacs_settings_constructor, emacs_settings_get_property)
9282 (emacs_settings_set_property, emacs_settings_class_init):
9283 New functions.
9284 (gsettings_client, gsettings_obj): New variables.
9285 (GSETTINGS_SCHEMA): New define.
9286 (something_changedCB): Call store_monospaced_changed.
9287 (init_gsettings): New function.
9288 (xsettings_initialize): Call init_gsettings.
9289 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9290 to NULL.
9291
640c8776 9292 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9293 GCONF_CFLAGS/LIBS.
9294
5386012d
MR
92952011-06-29 Martin Rudalics <rudalics@gmx.at>
9296
9297 * window.c (resize_root_window, grow_mini_window)
9298 (shrink_mini_window): Rename Qresize_root_window to
9299 Qwindow_resize_root_window and Qresize_root_window_vertically to
9300 Qwindow_resize_root_window_vertically.
9301
f13e0b08
PE
93022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9303
9304 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9305
94515237
JB
93062011-06-27 Juanma Barranquero <lekktu@gmail.com>
9307
9308 * makefile.w32-in: Redesign dependencies so they reflect more
9309 clearly which files are directly included by each source file,
9310 and not through other includes.
9311
e43b6e43
MR
93122011-06-27 Martin Rudalics <rudalics@gmx.at>
9313
9314 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9315 (sort_overlays, overlay_strings): When an overlay's clone number
9316 matches the window's clone number process the overlay even if
9317 the overlay's window property doesn't match the current window.
9318
d68443dc
MR
9319 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9320 (Fwindow_hchild): Rename to Fwindow_left_child.
9321 (Fwindow_next): Rename to Fwindow_next_sibling.
9322 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9323 (resize_window_check): Rename to window_resize_check.
9324 (resize_window_apply): Rename to window_resize_apply.
9325 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9326 (Fdelete_other_windows_internal, resize_frame_windows)
9327 (Fsplit_window_internal, Fdelete_window_internal)
9328 (grow_mini_window, shrink_mini_window)
9329 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9330
c7e73be5
JD
93312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9332
9333 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9334 (emacs_fixed_set_min_size): Remove.
9335 (emacs_fixed_new): Take frame as argument.
9336
9337 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9338 (_EmacsFixedPrivate): Remove minwidth/height.
9339 Add struct frame *f.
9340 (emacs_fixed_init): Initialize priv->f.
9341 (get_parent_class, emacs_fixed_set_min_size): Remove.
9342 (emacs_fixed_new): Set priv->f to argument.
9343 (emacs_fixed_get_preferred_width)
9344 (emacs_fixed_get_preferred_height): Use min_width/height from
9345 frames size_hint to set minimum and natural (Bug#8919).
9346 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9347 and use min_width/height from frames size_hint to set
9348 min_width/height (Bug#8919).
9349
9350 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9351 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9352 Fix indentation.
c7e73be5 9353
cf99dcf8
EZ
93542011-06-26 Eli Zaretskii <eliz@gnu.org>
9355
9356 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9357 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9358 called at ZV.
9359
029529ac
CY
93602011-06-26 Chong Yidong <cyd@stupidchicken.com>
9361
9362 * process.c (wait_reading_process_output): Bypass select if
9363 waiting for a cell while ignoring keyboard input, and input is
9364 pending. Suggested by Jan Djärv (Bug#8869).
9365
7a7ef429
PE
93662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9367
9368 Use gnulib's dup2 module instead of rolling our own.
9369 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9370
11fdef7d 93712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9372
9373 * dispnew.c (scrolling_window): Before scrolling, turn off a
9374 mouse-highlight in the window being scrolled.
9375
cd3520a4
JB
93762011-06-24 Juanma Barranquero <lekktu@gmail.com>
9377
9378 Move DEFSYM to lisp.h and use everywhere.
9379
9380 * character.h (DEFSYM): Move declaration...
9381 * lisp.h (DEFSYM): ...here.
9382
9383 * gnutls.c:
9384 * minibuf.c:
9385 * w32menu.c:
9386 * w32proc.c:
9387 * w32select.c: Don't include character.h.
9388
9389 * alloc.c (syms_of_alloc):
9390 * buffer.c (syms_of_buffer):
9391 * bytecode.c (syms_of_bytecode):
9392 * callint.c (syms_of_callint):
9393 * casefiddle.c (syms_of_casefiddle):
9394 * casetab.c (init_casetab_once):
9395 * category.c (init_category_once, syms_of_category):
9396 * ccl.c (syms_of_ccl):
9397 * cmds.c (syms_of_cmds):
9398 * composite.c (syms_of_composite):
9399 * dbusbind.c (syms_of_dbusbind):
9400 * dired.c (syms_of_dired):
9401 * dispnew.c (syms_of_display):
9402 * doc.c (syms_of_doc):
9403 * editfns.c (syms_of_editfns):
9404 * emacs.c (syms_of_emacs):
9405 * eval.c (syms_of_eval):
9406 * fileio.c (syms_of_fileio):
9407 * fns.c (syms_of_fns):
9408 * frame.c (syms_of_frame):
9409 * fringe.c (syms_of_fringe):
9410 * insdel.c (syms_of_insdel):
9411 * keymap.c (syms_of_keymap):
9412 * lread.c (init_obarray, syms_of_lread):
9413 * macros.c (syms_of_macros):
9414 * msdos.c (syms_of_msdos):
9415 * print.c (syms_of_print):
9416 * process.c (syms_of_process):
9417 * search.c (syms_of_search):
9418 * sound.c (syms_of_sound):
9419 * syntax.c (init_syntax_once, syms_of_syntax):
9420 * terminal.c (syms_of_terminal):
9421 * textprop.c (syms_of_textprop):
9422 * undo.c (syms_of_undo):
9423 * w32.c (globals_of_w32):
9424 * window.c (syms_of_window):
9425 * xdisp.c (syms_of_xdisp):
9426 * xfaces.c (syms_of_xfaces):
9427 * xfns.c (syms_of_xfns):
9428 * xmenu.c (syms_of_xmenu):
9429 * xsettings.c (syms_of_xsettings):
9430 * xterm.c (syms_of_xterm): Use DEFSYM.
9431
4228cf16
TZ
94322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9433
cd3520a4 9434 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9435
7fcccf1e
PE
94362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9437
7efb4e0e
PE
9438 Integer and buffer overflow fixes (Bug#8873).
9439
ff5844ad
PE
9440 * print.c (printchar, strout): Check for string overflow.
9441 (PRINTPREPARE, printchar, strout):
9442 Don't set size unless allocation succeeds.
9443
90532f02
PE
9444 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9445 for sizes. Check for string overflow more accurately.
9446 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9447
6d84508d
PE
9448 * macros.c: Integer and buffer overflow fixes.
9449 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9450 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9451 Use ptrdiff_t, not int, for sizes.
9452 Don't increment bufsize until after realloc succeeds.
9453 Check for size-calculation overflow.
9454 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9455
437b2cb4
PE
9456 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9457
8b9ac8b4
PE
9458 * lread.c: Integer overflow fixes.
9459 (read_integer): Radix is now EMACS_INT, not int,
9460 to improve quality of diagnostics for out-of-range radices.
9461 Calculate buffer size correctly for out-of-range radices.
9462 (read1): Check for integer overflow in radices, and in
9463 read-circle numbers.
82cb60d3
PE
9464 (read_escape): Avoid int overflow.
9465 (Fload, openp, read_buffer_size, read1)
9466 (substitute_object_recurse, read_vector, read_list, map_obarray):
9467 Use ptrdiff_t, not int, for sizes.
9468 (read1): Use EMACS_INT, not int, for sizes.
20270765 9469 Check for size overflow.
8b9ac8b4 9470
7fcccf1e
PE
9471 * image.c (cache_image): Check for size arithmetic overflow.
9472
bfbbd7e7
PE
9473 * lread.c: Integer overflow issues.
9474 (saved_doc_string_size, saved_doc_string_length)
9475 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9476 Now ptrdiff_t, not int.
9477 (read1): Don't assume doc string length fits in int. Check for
9478 out-of-range doc string lengths.
9479 (read_list): Don't assume file position fits in int.
39019e54 9480 (read_escape): Check for hex character overflow.
bfbbd7e7 9481
4e323265
LL
94822011-06-22 Leo Liu <sdl.web@gmail.com>
9483
9484 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9485 Move to minibuffer.el.
9486
85fece3e
PE
94872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9488
20b84ce9 9489 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9490 The following patches are for when GLYPH_DEBUG && !XASSERT.
9491 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9492 * dispnew.c (flush_stdout):
9493 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9494 Mark as externally visible.
9495 * dispnew.c (check_window_matrix_pointers): Now static.
9496 * dispnew.c (window_to_frame_vpos):
9497 * xfns.c (unwind_create_frame):
9498 * xterm.c (x_check_font): Remove unused local.
9499 * scroll.c (CHECK_BOUNDS):
9500 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9501 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9502 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9503 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9504 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9505 Now static.
9506 (debug_method_add): Use va_list and vsprintf rather than relying
9507 on undefined behavior with wrong number of arguments.
9508 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9509 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9510 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9511 since we're not interested in debugging glyphs with old libraries.
9512 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9513 GCC 4.6.0's static checking.
9514
0766b489
PE
95152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9516
31fd4b32
PE
9517 Integer overflow and signedness fixes (Bug#8873).
9518 A few related buffer overrun fixes, too.
9519
b79e8648
PE
9520 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9521
0766b489
PE
9522 * dispextern.h (struct face.stipple):
9523 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9524 (x_bitmap_mask, x_allocate_bitmap_record)
9525 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9526 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9527 (x_create_bitmap_from_xpm_data):
9528 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9529 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9530 (.bitmaps_last):
9531 * xfaces.c (load_pixmap):
9532 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9533 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9534 (.bitmaps_last, struct x_output.icon_bitmap):
9535 Use ptrdiff_t, not int, for bitmap indexes.
9536 (x_allocate_bitmap_record): Check for size overflow.
9537 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9538
b081724f
PE
9539 Use ptrdiff_t, not int, for overlay counts.
9540 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9541 * editfns.c (overlays_around, get_pos_property):
9542 * textprop.c (get_char_property_and_overlay):
9543 * xdisp.c (next_overlay_change, note_mouse_highlight):
9544 * xfaces.c (face_at_buffer_position):
21514da7
PE
9545 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9546 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9547 (Fnext_overlay_change, Fprevious_overlay_change)
9548 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9549 Use ptrdiff_t, not int, for sizes.
21514da7 9550 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9551
3de73e5e
PE
9552 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9553
2606c57b
PE
9554 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9555 (x_session_initialize): Do not assume string length fits in int.
9556
aaafe47a
PE
9557 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9558 This is unlikely, but can occur if DPI is outlandish.
9559
2674ddc8 9560 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9561 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9562
28154962
PE
9563 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9564 * xrdb.c (magic_file_p, search_magic_path):
9565 Omit last arg SUFFIX; it was always 0. All callers changed.
9566 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9567
7de51af5
PE
9568 * xfont.c (xfont_match): Avoid need for strlen.
9569
25ed6cc3
PE
9570 * xfns.c: Don't assume strlen fits in int.
9571 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9572
4eab31dd
PE
9573 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9574 not unsigned long, as we prefer signed integers. All callers changed.
9575 Detect integer overflow in repeat count.
9576 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9577 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9578
171e2a58
PE
9579 * termcap.c: Don't assume sizes fit in int and never overflow.
9580 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9581 (gobble_line): Check for size-calculation overflow.
9582
ad39faca 9583 * minibuf.c (Fread_buffer):
6e5bb2dc 9584 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9585 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9586 Don't assume string length fits in int.
9587
52c61c22 9588 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9589 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9590
b5b8c9e5
PE
9591 * font.c: Don't assume string length fits in int.
9592 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9593 Use ptrdiff_t, not int.
ccd6111c
PE
9594 (font_intern_prop): Don't assume string length fits in int.
9595 Don't assume integer property fits in fixnum.
9596 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9597
882f0d81 9598 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9599 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9600 Reformulate so as not to need the command string.
9601 Invoke gzip -cd rather than gunzip, as it's more portable.
9602 (lock_info_type, lock_file_1, lock_file):
9603 Don't assume pid_t and time_t fit in unsigned long.
9604 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9605 (current_lock_owner): Prefer signed type for sizes.
9606 Use memcpy, not strncpy, where memcpy is what is really wanted.
9607 Don't assume (via atoi) that time_t and pid_t fit in int.
9608 Check for time_t and/or pid_t out of range, e.g., via a network share.
9609 Don't alloca where an auto var works fine.
9610
93f4cf88
PE
9611 * fileio.c: Fix some integer overflow issues.
9612 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9613 Don't assume string length fits in int.
9614 (directory_file_name): Don't assume string length fits in long.
9615 (make_temp_name): Don't assume pid fits in int, or that its print
9616 length is less than 20.
9617
f3e92b69
PE
9618 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9619
1bfdaf10
PE
9620 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9621
35016e9a
PE
9622 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9623
3d1e65a1
PE
9624 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9625 We prefer signed integers, even for size calculations.
9626
0b963a93
PE
9627 * emacs.c: Don't assume string length fits in 'int'.
9628 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9629 (main): Don't invoke strlen when not needed.
9630
573f4b54
PE
9631 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9632 (XD_DEBUG_MESSAGE): Don't waste a byte.
9633
989f33ba
PE
9634 * callproc.c (getenv_internal_1, getenv_internal)
9635 (Fgetenv_internal):
965d34eb
PE
9636 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9637
e4d29b33
PE
9638 * lread.c (invalid_syntax): Omit length argument.
9639 All uses changed. This doesn't fix a bug, but it simplifies the
9640 code away from its former Hollerith-constant appearance, and it's
9641 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9642 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9643
eb49b136
PE
9644 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9645 This didn't break anything, but it didn't help either.
9646 It's confusing to put a bogus integer in a place where the actual
9647 value does not matter.
9f62aeb1 9648 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9649 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9650
15375a22
PE
9651 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9652 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9653 implementation.
b61cc01c
PE
9654 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9655 We prefer signed types, and the value cannot exceed the EMACS_INT
9656 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9657 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9658 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9659 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9660
53b2623d
PE
9661 * indent.c (sane_tab_width): New function.
9662 (current_column, scan_for_column, Findent_to, position_indentation)
9663 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9664 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9665
51cab52b 9666 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9667
f2ed8a70
PE
9668 * lisp.h (lint_assume): New macro.
9669 * composite.c (composition_gstring_put_cache):
9670 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9671
abe80cc6
PE
9672 * editfns.c, insdel.c:
9673 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9674
b02c740e
PE
9675 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9676
ebc96716
PE
9677 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9678
b4e50fa0 9679 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9680 Use much-faster test for byte-length change.
311d5d7c 9681 Don't assume string byte-length fits in 'int'.
a4cf38e4 9682 Check that character arg fits in 'int'.
85461888 9683 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9684
c0c1ee9f
PE
9685 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9686
a498d7f4
PE
9687 * fns.c (concat): Catch string overflow earlier.
9688 Do not rely on integer wraparound.
9689
51cab52b
PE
9690 * dispextern.h (struct it.overlay_strings_charpos)
9691 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9692 * xdisp.c (forward_to_next_line_start)
9693 (back_to_previous_visible_line_start)
9694 (reseat_at_next_visible_line_start, next_element_from_buffer):
9695 Don't arbitrarily truncate the value of 'selective' to int.
9696
76031fad
PE
9697 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9698
5eb55db9
PE
9699 * composite.c: Don't truncate sizes to 'int'.
9700 (composition_gstring_p, composition_reseat_it)
9701 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9702 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9703 not EMACS_UINT, for indexes.
5eb55db9 9704
0703a717
PE
9705 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9706
d6202519
PE
9707 * buffer.c: Include <verify.h>.
9708 (struct sortvec.priority, struct sortstr.priority):
8961a454 9709 Now EMACS_INT, not int.
c20998a7 9710 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9711 (struct sortstr.size, record_overlay_string)
9712 (struct sortstrlist.size, struct sortlist.used):
9713 Don't truncate size to int.
9714 (record_overlay_string): Check for size-calculation overflow.
d6202519 9715 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9716
d5a19415
JM
97172011-06-22 Jim Meyering <meyering@redhat.com>
9718
029529ac 9719 Don't leak an XBM-image-sized buffer
d5a19415
JM
9720 * image.c (xbm_load): Free the image buffer after using it.
9721
a9041e6c
PE
97222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9723
9724 Port to Sun C.
9725 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9726 that Sun C diagnosed.
9727 * fns.c (secure_hash): Fix pointer signedness issue.
9728 * intervals.c (static_offset_intervals): New function.
9729 (offset_intervals): Use it.
9730
7f3f739f
LL
97312011-06-21 Leo Liu <sdl.web@gmail.com>
9732
9733 * deps.mk (fns.o):
9734 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9735 sha512.h.
9736
9737 * fns.c (secure_hash): Rename from crypto_hash_function and change
9738 the first arg to accept symbols.
5b66d427 9739 (Fsecure_hash): New primitive.
7f3f739f
LL
9740 (syms_of_fns): New symbols.
9741
76147d94
DD
97422011-06-20 Deniz Dogan <deniz@dogan.se>
9743
9744 * process.c (Fset_process_buffer): Clarify return value in
9745 docstring.
9746
7d7d0045
CY
97472011-06-18 Chong Yidong <cyd@stupidchicken.com>
9748
9749 * dispnew.c (add_window_display_history): Use BVAR.
9750
9751 * xdisp.c (debug_method_add): Use BVAR.
9752 (check_window_end, dump_glyph_matrix, dump_glyph)
9753 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9754
9755 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9756 Likewise.
9757
9758 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9759 check till after the cache is created in init_frame_faces.
9760
ff2bc410
SM
97612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9762
9763 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9764
28177add
PE
97652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9766
dd3482fe
PE
9767 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9768 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9769 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9770
393d71f3 9771 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9772 * fileio.c (Finsert_file_contents):
9773 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9774 Remove the old (too-loose) buffer overflow checks.
9775 They weren't needed, since make_gap checks for buffer overflow.
9776 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9777 The old code merely checked for Emacs fixnum overflow, and relied
9778 on undefined (wraparound) behavior. The new code avoids undefined
9779 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9780
2e6813b0 9781 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9782 Tune. Don't use wider integers than needed. Don't use alloca.
9783 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9784
599a9e4f
PE
9785 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9786
99561444
PE
9787 * insdel.c, lisp.h (buffer_overflow): New function.
9788 (insert_from_buffer_1, replace_range, replace_range_2):
9789 * insdel.c (make_gap_larger):
9790 * editfns.c (Finsert_char):
9791 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9792
28177add
PE
9793 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9794
e69dafad
PE
97952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9796
4baa020d 9797 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9798
b1c46f02
PE
9799 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9800 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9801
e69dafad
PE
9802 * fileio.c: Don't assume EMACS_INT fits in off_t.
9803 (emacs_lseek): New static function.
9804 (Finsert_file_contents, Fwrite_region): Use it.
9805 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9806
566684ea
PE
9807 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9808
e6966cd6
PE
9809 * fns.c: Don't overflow int when computing a list length.
9810 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9811 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9812 truncation on 64-bit hosts. Check for QUIT every
9813 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9814 faster and is responsive enough.
9815 (Flength): Report an error instead of overflowing an integer.
9816 (Fsafe_length): Return a float if the value is not representable
9817 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9818 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9819 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9820
dd0b0efb
PE
9821 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9822 (header_size, word_size): New constants.
9823 (allocate_vectorlike): Don't check size overflow here.
9824 (allocate_vector): Check it here instead, since this is the only
9825 caller of allocate_vectorlike that could cause overflow.
9826 Check that the new vector's length is representable as a fixnum.
9827
86fe5cfe
PE
9828 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9829 The previous code was bogus. For example, next_almost_prime (32)
9830 returned 39, which is undesirable as it is a multiple of 3; and
9831 next_almost_prime (24) returned 25, which is a multiple of 5 so
9832 why was the code bothering to check for multiples of 7?
9833
80e88859
PE
9834 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9835
4a2f0ad6
PE
9836 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9837
f66c7cf8
PE
9838 Variadic C functions now count arguments with ptrdiff_t.
9839 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9840 Back then I didn't know that the Emacs coding style prefers signed int.
9841 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9842 were being counted with int, which may truncate counts on 64-bit
9843 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9844 * lisp.h (struct Lisp_Subr.function.aMANY)
9845 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9846 Arg counts are now ptrdiff_t, not size_t.
9847 All variadic functions and their callers changed accordingly.
9848 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9849 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9850 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9851 * callint.c (Fcall_interactively): Check arg count for overflow,
9852 to avoid potential buffer overrun. Use signed char, not 'int',
9853 for 'varies' array, so that we needn't bother to check its size
9854 calculation for overflow.
9855 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9856 * eval.c (apply_lambda):
9857 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9858 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9859 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9860
a1759b76
PE
9861 * callint.c (Fcall_interactively): Don't use index var as event count.
9862
d96be9fc
PE
9863 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9864 * mem-limits.h (SIZE): Remove; no longer used.
9865
a690a978 9866 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9867
578c21e6
PE
9868 Remove unnecessary casts.
9869 * xterm.c (x_term_init):
9870 * xfns.c (x_set_border_pixel):
9871 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9872 These aren't needed now that we assume ANSI C.
9873
96f53c6c
PE
9874 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9875 It's more likely to cause problems (due to unsigned overflow)
9876 than to cure them.
9877
83c77d31
PE
9878 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9879
ee2079f1
PE
9880 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9881
6da65536
PE
9882 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9883
7147c4a4
PE
9884 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9885
193e32d9
PE
9886 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9887
e5533da6
PE
9888 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9889
9910e595
PE
9890 GLYPH_CODE_FACE returns EMACS_INT, not int.
9891 * dispextern.h (merge_faces):
9892 * xfaces.c (merge_faces):
01103c44
PE
9893 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9894 Don't assume EMACS_INT fits in int.
9910e595 9895
2638320e
PE
9896 * character.h (CHAR_VALID_P): Remove unused parameter.
9897 * fontset.c, lisp.h, xdisp.c: All uses changed.
9898
045eb8d9
PE
9899 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9900
c1f134b5
PE
9901 * fns.c (concat): Minor tuning based on overflow analysis.
9902 This doesn't fix any bugs. Use int to hold character, instead
9903 of constantly refetching from Emacs object. Use XFASTINT, not
9904 XINT, for value known to be a character. Don't bother comparing
9905 a single byte to 0400, as it's always less.
9906
395fcb93 9907 * floatfns.c (Fexpt):
327eeec8
PE
9908 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9909
abbd3d23
PE
9910 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9911 for characters.
9912
684a03ef
PE
9913 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9914
0fed43f3
PE
9915 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9916 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9917 incorrectly succeed when S was a string, because 4294967386 was
9918 truncated before it was used.
9919
8fd02eb7
PE
9920 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9921 Otherwise, an out-of-range integer could cause undefined behavior
9922 on a 64-bit host.
9923
f8c86b69
PE
9924 * composite.c: Use int, not EMACS_INT, for characters.
9925 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9926 EMACS_INT, for values that are known to be in character range.
9927 This doesn't fix any bugs but is the usual style inside Emacs and
9928 may generate better code on 32-bit machines.
9929
34206dd2
PE
9930 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9931 This is for reasons similar to the recent CHAR_STRING fix.
9932 * charset.c (Fencode_char): Check that character arg is actually
9933 a character. Pass an int to ENCODE_CHAR.
9934 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9935 wider than 'int', as a compile-time check to prevent future regressions
9936 in this area.
9937
c5958d4c 9938 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9939
9940 Make sure a 64-bit char is never passed to CHAR_STRING.
9941 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9942 by silently ignoring the top 32 bits, allowing some values
9943 that were far too large to be valid characters.
9944 * character.h: Include <verify.h>.
9945 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9946 arguments are no wider than unsigned, as a compile-time check
9947 to prevent future regressions in this area.
9948 * data.c (Faset):
01103c44 9949 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9950 (Fsubst_char_in_region):
9951 * fns.c (concat):
9952 * xdisp.c (decode_mode_spec_coding):
9953 Adjust to CHAR_STRING's new requirement.
9954 * editfns.c (Finsert_char, Fsubst_char_in_region):
9955 * fns.c (concat): Check that character args are actually
9956 characters. Without this test, these functions did the wrong
9957 thing with wildly out-of-range values on 64-bit hosts.
9958
d37ca623
PE
9959 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9960 These casts should not be needed on 32-bit hosts, either.
9961 * keyboard.c (read_char):
9962 * lread.c (Fload): Remove casts to unsigned.
9963
ea204efb
PE
9964 * lisp.h (UNSIGNED_CMP): New macro.
9965 This fixes comparison bugs on 64-bit hosts.
9966 (ASCII_CHAR_P): Use it.
9967 * casefiddle.c (casify_object):
01103c44 9968 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9969 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9970 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9971 * dispextern.h (FACE_FROM_ID):
9972 * keyboard.c (read_char): Use UNSIGNED_CMP.
9973
41cb286c
PE
9974 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9975 not to EMACS_INT, to avoid GCC warning.
9976
4a1b9832
PE
9977 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9978
55daad71
PE
9979 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9980 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9981 isn't needed on 32-bit machines.
8f95c75c 9982
01103c44
PE
9983 * buffer.c (Fgenerate_new_buffer_name):
9984 Use EMACS_INT for count, not int.
0ceccced 9985 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9986
9987 * data.c (Qcompiled_function): Now static.
9988
c6f072e7
PE
9989 * window.c (window_body_lines): Now static.
9990
20ce5912
PE
9991 * image.c (gif_load): Rename local to avoid shadowing.
9992
9c4c5f81
PE
9993 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9994 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9995 * alloc.c (make_save_value): Integer argument is now of type
9996 ptrdiff_t, not int.
9997 (mark_object): Use ptrdiff_t, not int.
9998 * lisp.h (pD): New macro.
9999 * print.c (print_object): Use it.
10000
c0c5c8ae
PE
10001 * alloc.c: Use EMACS_INT, not int, to count objects.
10002 (total_conses, total_markers, total_symbols, total_vector_size)
10003 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10004 (total_free_floats, total_floats, total_free_intervals)
10005 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10006 Now EMACS_INT, not int. All uses changed.
10007 (Fgarbage_collect): Compute overall total using a double, so that
10008 integer overflow is less likely to be a problem. Check for overflow
10009 when converting back to an integer.
5a25e253
PE
10010 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10011 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10012 These were 'int' variables that could overflow on 64-bit hosts;
10013 they were never used, so remove them instead of repairing them.
211a0b2a 10014 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10015 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10016 Previously, this ceilinged at INT_MAX, but that doesn't work on
10017 64-bit machines.
e46bb31a 10018 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10019
c78baabf 10020 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10021 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10022 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10023 when a (possibly-narrower) signed value would do just as well.
10024 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10025
c9d624c6
PE
10026 * alloc.c: Catch some string size overflows that we were missing.
10027 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10028 for convenience in STRING_BYTES_MAX.
10029 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10030 The definition here is exact; the one in lisp.h was approximate.
10031 (allocate_string_data): Check for string overflow. This catches
10032 some instances we weren't catching before. Also, it catches
10033 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10034 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10035 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10036
c9d624c6
PE
10037 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10038 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10039 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10040
353032ce
PE
10041 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10042
2bccce07
PE
10043 * alloc.c (Fmake_string): Check for out-of-range init.
10044
0ac30604
SM
100452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10046
10047 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10048
c195f2de
JD
100492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10050
10051 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10052 xg_get_default_scrollbar_width.
10053
10054 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10055 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10056 (style_changed_cb): Call update_theme_scrollbar_width and call
10057 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10058 all frames (Bug#8505).
10059 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10060 Call gtk_window_set_resizable if HAVE_GTK3.
10061 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10062 and height if HAVE_GTK3 (Bug#8505).
10063 (scroll_bar_width_for_theme): New variable.
10064 (update_theme_scrollbar_width): New function.
10065 (xg_get_default_scrollbar_width): Move code to
10066 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10067 (xg_initialize): Call update_theme_scrollbar_width.
10068
10069 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10070
10071 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10072
e10ac9f1
MR
100732011-06-12 Martin Rudalics <rudalics@gmx.at>
10074
10075 * frame.c (make_frame): Call other_buffer_safely instead of
10076 other_buffer.
10077
10078 * window.c (temp_output_buffer_show): Call display_buffer with
10079 second argument Vtemp_buffer_show_specifiers and reset latter
10080 immediately after the call.
10081 (Vtemp_buffer_show_specifiers): New variable.
10082 (auto_window_vscroll_p, next_screen_context_lines)
10083 (Vscroll_preserve_screen_position): Remove leading asterisks from
10084 doc-strings.
10085
2d3c217e 100862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10087
7b7f97e8 10088 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10089 * buffer.c (Qclone_number): Remove for now, as it's unused.
10090 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10091 (record_buffer): Remove unused local.
10092 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10093 (set_frame_buffer_list): Remove; unused.
10094 * frame.h (other_visible_frames): Remove decl.
10095 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10096 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10097 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10098 if HAVE_GPM.
10099 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10100 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10101 Define only if HAVE_GPM.
10102 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10103 (update_hints_inhibit): Remove; never set. All uses removed.
10104 * widgetprv.h (emacsFrameClassRec): Remove decl.
10105 * window.c (delete_deletable_window): Now returns void, since it
10106 wasn't returning anything.
10107 (compare_window_configurations): Remove unused locals.
10108 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10109 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10110 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10111 the same widths as pointers. This follows up on the 2011-05-06 patch.
10112 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10113 * xterm.h: Likewise.
10114 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10115
1384b89e
JB
101162011-06-12 Juanma Barranquero <lekktu@gmail.com>
10117
10118 * makefile.w32-in: Update dependencies.
10119 (LISP_H): Add lib/intprops.h.
10120
1100a63c
CY
101212011-06-11 Chong Yidong <cyd@stupidchicken.com>
10122
10123 * image.c (gif_load): Add animation frame delay to the metadata.
10124 (syms_of_image): Use DEFSYM. New symbol `delay'.
10125
6198ccd0
MR
101262011-06-11 Martin Rudalics <rudalics@gmx.at>
10127
10128 * window.c (delete_deletable_window): Re-add.
10129 (Fset_window_configuration): Rewrite to handle dead buffers and
10130 consequently deletable windows.
10131 (window_tree, Fwindow_tree): Remove. Supply functionality in
10132 window.el.
10133 (compare_window_configurations): Simplify code.
10134
b6e3633c
AS
101352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10136
1ab0dee5
AS
10137 * image.c (imagemagick_load_image): Fix type mismatch.
10138 (Fimagemagick_types): Likewise.
10139
b6e3633c
AS
10140 * window.h (replace_buffer_in_windows): Declare.
10141
9397e56f
MR
101422011-06-11 Martin Rudalics <rudalics@gmx.at>
10143
10144 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10145 Qclone_number. Remove external declaration of Qdelete_window.
10146 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10147 code.
640c8776
SM
10148 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10149 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10150 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10151 buffer list implementation.
10152 (other_buffer_safely): New function.
10153 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10154 calls to replace_buffer_in_windows and
10155 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10156 if allowed.
10157 (record_buffer): Inhibit quitting and rewrite using quittable
10158 functions. Run Qbuffer_list_update_hook if allowed.
10159 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10160 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10161 Move switch-to-buffer to window.el.
9397e56f
MR
10162 (bury-buffer): Move to window.el.
10163 (Vbuffer_list_update_hook): New variable.
10164
10165 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10166 section.
10167
10168 * window.h (resize_frame_windows): Move up in code.
10169 (Fwindow_frame): Remove EXFUN.
10170 (replace_buffer_in_all_windows): Remove prototype.
10171 (replace_buffer_in_windows_safely): Add prototype.
10172
10173 * window.c: Declare Qdelete_window static again. Move down
10174 declaration of select_count.
10175 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10176 (Fother_window): Move to window.el.
10177 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10178 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10179 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10180 window.el.
10181 (replace_buffer_in_windows): Implement by calling
10182 Qreplace_buffer_in_windows.
10183 (replace_buffer_in_all_windows): Remove with some functionality
10184 moved into replace_buffer_in_windows_safely.
10185 (replace_buffer_in_windows_safely): New function.
10186 (select_window_norecord, select_frame_norecord): Move in front
10187 of run_window_configuration_change_hook. Remove now obsolete
10188 declarations.
640c8776
SM
10189 (Fset_window_buffer): Rewrite doc-string.
10190 Call Qrecord_window_buffer.
9397e56f
MR
10191 (keys_of_window): Move binding for other-window to window.el.
10192
b50691aa
CY
101932011-06-11 Chong Yidong <cyd@stupidchicken.com>
10194
10195 * dispextern.h (struct image): Replace data member, whose int_val
10196 and ptr_val fields were not used by anything, with a single
10197 lisp_val object.
10198
10199 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10200 (gif_clear_image, gif_load, imagemagick_load_image)
10201 (gs_clear_image, gs_load): Callers changed.
10202
3f754b86
PE
102032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10204
cca69397
PE
10205 * buffer.h: Include <time.h>, for time_t.
10206 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10207
109e28d0
PE
10208 Fix minor problems found by static checking.
10209
60737f02
PE
10210 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10211
4b66faf3
PE
10212 Make identifiers static if they are not used in other modules.
10213 * data.c (Qcompiled_function, Qframe, Qvector):
10214 * image.c (QimageMagick, Qsvg):
10215 * minibuf.c (Qmetadata):
10216 * window.c (resize_window_check, resize_root_window): Now static.
10217 * window.h (resize_window_check, resize_root_window): Remove decls.
10218
109e28d0
PE
10219 * window.c (window_deletion_count, delete_deletable_window):
10220 Remove; unused.
46a4ce9e
PE
10221 (window_body_lines): Now static.
10222 (Fdelete_other_windows_internal): Mark vars as initialized.
10223 Make sure 'resize_failed' is initialized.
10224 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10225 (resize_window_apply): Remove unused local.
10226 * window.h (delete_deletable_window): Remove decl.
10227
109e28d0 10228 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10229 (imagemagick_load_image): Fix pointer signedness problem by changing
10230 last arg from unsigned char * to char *. All uses changed.
10231 Also, fix a local for similar reasons.
10232 Remove unused locals. Remove locals to avoid shadowing.
10233 (fn_rsvg_handle_free): Remove; unused.
10234 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10235 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10236
3f754b86
PE
10237 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10238
2547adb1
CY
102392011-06-10 Chong Yidong <cyd@stupidchicken.com>
10240
10241 * image.c (gif_load): Fix omitted cast error introduced by
10242 2011-06-06 change.
10243
2c8e37d4
MR
102442011-06-10 Martin Rudalics <rudalics@gmx.at>
10245
10246 * window.h (resize_proportionally, orig_total_lines)
10247 (orig_top_line): Remove from window structure.
10248 (set_window_height, set_window_width, change_window_heights)
10249 (Fdelete_window): Remove prototypes.
10250 (resize_frame_windows): Remove duplicate declaration.
10251
440a42e3
EZ
102522011-06-10 Eli Zaretskii <eliz@gnu.org>
10253
10254 * window.h (resize_frame_windows, resize_window_check)
10255 (delete_deletable_window, resize_root_window)
10256 (resize_frame_windows): Declare prototypes.
10257
10258 * window.c (resize_window_apply): Make definition be "static" to
10259 match the prototype.
10260
562dd5e9
MR
102612011-06-10 Martin Rudalics <rudalics@gmx.at>
10262
10263 * window.c: Remove declarations of Qwindow_size_fixed,
10264 window_min_size_1, window_min_size_2, window_min_size,
10265 size_window, window_fixed_size_p, enlarge_window, delete_window.
10266 Remove static from declaration of Qdelete_window, it's
10267 temporarily needed by Fbury_buffer.
10268 (replace_window): Don't assign orig_top_line and
10269 orig_total_lines.
10270 (Fdelete_window, delete_window): Remove. Window deletion is
10271 handled by window.el.
640c8776
SM
10272 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10273 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10274 (Fdelete_other_windows): Remove. Deleting other windows is
10275 handled by window.el.
10276 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10277 handled in window.el.
10278 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10279 Window minimum sizes are handled in window.el.
10280 (shrink_windows, size_window, set_window_height)
10281 (set_window_width, change_window_heights, window_height)
10282 (window_width, CURBEG, CURSIZE, enlarge_window)
10283 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10284 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10285 handled in window.el.
10286 (make_dummy_parent): Rename to make_parent_window and give it a
10287 second argument horflag.
10288 (make_window): Don't set resize_proportionally any more.
10289 (Fsplit_window): Remove. Windows are split in window.el.
10290 (save_restore_action, save_restore_orig_size)
10291 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10292 Resize mini windows in window.el.
10293 (grow_mini_window, shrink_mini_window): Implement by calling
10294 Qresize_root_window_vertically, resize_window_check and
10295 resize_window_apply.
640c8776
SM
10296 (saved_window, Fset_window_configuration, save_window_save):
10297 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10298 resize_proportionally.
10299 (window_min_height, window_min_width): Move to window.el.
10300 (keys_of_window): Move bindings for delete-other-windows,
10301 split-window, delete-window and enlarge-window to window.el.
10302
10303 * buffer.c: Temporarily extern Qdelete_window.
10304 (Fbury_buffer): Temporarily call Qdelete_window instead of
10305 Fdelete_window (Fbury_buffer will move to window.el soon).
10306
10307 * frame.c (set_menu_bar_lines_1): Remove code handling
10308 orig_top_line and orig_total_lines.
10309
10310 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10311 set_window_height but set heights directly.
10312 (change_frame_size_1): Use resize_frame_windows.
10313
10314 * xdisp.c (init_xdisp): Don't use set_window_height but set
10315 heights directly.
10316
640c8776
SM
10317 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10318 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10319 run_window_configuration_change_hook.
10320
10321 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10322 instead of change_window_heights and run
10323 run_window_configuration_change_hook.
10324
1a13852e
MR
103252011-06-09 Martin Rudalics <rudalics@gmx.at>
10326
10327 * window.c (replace_window): Rename second argument REPLACEMENT to
10328 NEW. New third argument SETFLAG. Rewrite.
10329 (delete_window, make_dummy_parent): Call replace_window with
10330 third argument 1.
10331 (window_list_1): Move down in code.
10332 (run_window_configuration_change_hook): Move set_buffer part
10333 before select_frame_norecord part in order to unwind correctly.
10334 Rename count1 to count.
10335 (recombine_windows, delete_deletable_window, resize_root_window)
10336 (Fdelete_other_windows_internal)
10337 (Frun_window_configuration_change_hook, make_parent_window)
10338 (resize_window_check, resize_window_apply, Fresize_window_apply)
10339 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10340 (Fdelete_window_internal, Fresize_mini_window_internal):
10341 New functions.
1a13852e
MR
10342 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10343
f3d1777e
MR
103442011-06-08 Martin Rudalics <rudalics@gmx.at>
10345
496e208e
MR
10346 * window.h (window): Add some new members to window structure -
10347 normal_lines, normal_cols, new_total, new_normal, clone_number,
10348 splits, nest, prev_buffers, next_buffers.
10349 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10350 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10351
f3d1777e
MR
10352 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10353 Remove.
496e208e
MR
10354 (make_dummy_parent): Set new members of windows structure.
10355 (make_window): Move down in code. Handle new members of window
10356 structure.
10357 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10358 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10359 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10360 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10361 (Fset_window_next_buffers, Fset_window_clone_number):
10362 New functions.
496e208e
MR
10363 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10364 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10365 Doc-string fixes.
10366 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10367 Argument WINDOW can be now internal window too.
10368 (Fwindow_use_time): Move up in code.
10369 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10370 Rewrite doc-string.
10371 (Fset_window_configuration, saved_window)
10372 (Fcurrent_window_configuration, save_window_save): Handle new
10373 members of window structure.
b9e809c2
MR
10374 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10375 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10376 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10377 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10378 Qget_mru_window, Qresize_root_window,
10379 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10380 Qauto_buffer_name; staticpro them.
f3d1777e 10381
abde8f8c
MR
103822011-06-07 Martin Rudalics <rudalics@gmx.at>
10383
10384 * window.c (Fwindow_total_size, Fwindow_left_column)
10385 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10386 (Fwindow_list_1): New functions.
10387 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10388 (Fwindow_width, Fscroll_left, Fscroll_right):
10389 Use window_body_cols instead of window_box_text_cols.
10390 (delete_window, Fset_window_configuration):
10391 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10392 (delete_all_subwindows): Take a window as argument and not a
10393 structure. Rewrite.
190b47e6
MR
10394 (window_loop): Remove handling of GET_LRU_WINDOW and
10395 GET_LARGEST_WINDOW.
10396 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10397
10398 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10399 window_box_text_cols. delete_all_subwindows now takes a
10400 Lisp_Object as argument.
abde8f8c 10401
640c8776
SM
10402 * indent.c (compute_motion, Fcompute_motion):
10403 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10404
fa8a67e6
MR
10405 * frame.c (delete_frame): Call delete_all_subwindows with root
10406 window as argument.
10407
a54e3482
DC
104082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10409
10410 * fns.c (Fputhash): Document return value.
10411
60002bf5
CY
104122011-06-06 Chong Yidong <cyd@stupidchicken.com>
10413
10414 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10415
0c671da6 104162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10417
b862a52a 10418 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10419
be44ca6c
PE
10420 Check for overflow when converting integer to cons and back.
10421 * charset.c (Fdefine_charset_internal, Fdecode_char):
10422 Use cons_to_unsigned to catch overflow.
10423 (Fencode_char): Use INTEGER_TO_CONS.
10424 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10425 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10426 * data.c (long_to_cons, cons_to_long): Remove.
10427 (cons_to_unsigned, cons_to_signed): New functions.
10428 These signal an error for invalid or out-of-range values.
10429 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10430 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10431 * font.c (Ffont_variation_glyphs):
10432 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10433 * lisp.h: Include <intprops.h>.
10434 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10435 (cons_to_signed, cons_to_unsigned): New decls.
10436 (long_to_cons, cons_to_long): Remove decls.
10437 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10438 (Fprimitive_undo): Use CONS_TO_INTEGER.
10439 * xfns.c (Fx_window_property): Likewise.
10440 * xselect.c: Include <limits.h>.
10441 (x_own_selection, selection_data_to_lisp_data):
10442 Use INTEGER_TO_CONS.
10443 (x_handle_selection_request, x_handle_selection_clear)
10444 (x_get_foreign_selection, Fx_disown_selection_internal)
10445 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10446 (lisp_data_to_selection_data): Use cons_to_unsigned.
10447 (x_fill_property_data): Use cons_to_signed.
10448 Report values out of range.
10449
d1f3d2af
PE
10450 Check for buffer and string overflow more precisely.
10451 * buffer.h (BUF_BYTES_MAX): New macro.
10452 * lisp.h (STRING_BYTES_MAX): New macro.
10453 * alloc.c (Fmake_string):
10454 * character.c (string_escape_byte8):
10455 * coding.c (coding_alloc_by_realloc):
10456 * doprnt.c (doprnt):
10457 * editfns.c (Fformat):
10458 * eval.c (verror):
10459 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10460 since they may not be the same number.
10461 * editfns.c (Finsert_char):
10462 * fileio.c (Finsert_file_contents):
10463 Likewise for BUF_BYTES_MAX.
10464
dd52fcea
PE
10465 * image.c: Use ptrdiff_t, not int, for sizes.
10466 (slurp_file): Switch from int to ptrdiff_t.
10467 All uses changed.
10468 (slurp_file): Check that file size fits in both size_t (for
10469 malloc) and ptrdiff_t (for sanity and safety).
10470
7f9bbdbb
PE
10471 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10472 if b->modtime has its maximal value.
10473
dfe18f82
PE
10474 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10475
84acfcf0
PE
10476 Don't assume time_t can fit into int.
10477 * buffer.h (struct buffer.modtime): Now time_t, not int.
10478 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10479 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10480
ccd9a01a
PE
10481 Minor fixes for signed vs unsigned integers.
10482 * character.h (MAYBE_UNIFY_CHAR):
10483 * charset.c (maybe_unify_char):
10484 * keyboard.c (read_char, reorder_modifiers):
10485 XINT -> XFASTINT, since the integer must be nonnegative.
10486 * ftfont.c (ftfont_spec_pattern):
10487 * keymap.c (access_keymap, silly_event_symbol_error):
10488 XUINT -> XFASTINT, since the integer must be nonnegative.
10489 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10490 since it makes no difference and we prefer signed.
10491 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10492 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10493 nonnegative.
10494
d6d100dd
SM
104952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10496
10497 * window.h (Fwindow_frame): Declare.
10498
2b6148e4
PE
104992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10500
10501 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10502 (SPARE_MEMORY): Always define.
10503 (LARGE_REQUEST): Remove.
10504 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10505
f230ecc9
MR
105062011-06-06 Martin Rudalics <rudalics@gmx.at>
10507
727e958e
MR
10508 * lisp.h: Move EXFUNS for Fframe_root_window,
10509 Fframe_first_window and Fset_frame_selected_window to window.h.
10510
10511 * window.h: Move EXFUNS for Fframe_root_window,
10512 Fframe_first_window and Fset_frame_selected_window here from
10513 lisp.h.
10514
10515 * frame.c (Fwindow_frame, Fframe_first_window)
10516 (Fframe_root_window, Fframe_selected_window)
10517 (Fset_frame_selected_window): Move to window.c.
10518 (Factive_minibuffer_window): Move to minibuf.c.
10519 (Fother_visible_frames_p): New function.
10520
10521 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10522
f230ecc9
MR
10523 * window.c (decode_window, decode_any_window): Move up in code.
10524 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10525 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10526 (Fwindow_buffer): Move up and rewrite doc-string.
10527 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10528 (Fwindow_prev): New functions.
727e958e
MR
10529 (Fwindow_frame): Move here from frame.c. Accept any window as
10530 argument.
10531 (Fframe_root_window, Fframe_first_window)
10532 (Fframe_selected_window): Move here from frame.c. Accept frame
10533 or arbitrary window as argument. Update doc-strings.
10534 (Fminibuffer_window): Move up in code.
10535 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10536 (Fset_frame_selected_window): Move here from frame.c.
10537 Marginal rewrite.
727e958e
MR
10538 (Fselected_window, select_window, Fselect_window): Move up in
10539 code. Minor doc-string fixes.
f230ecc9 10540
4d09bcf6
PE
105412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10542
10543 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10544 Do not assume that spare memory exists; that assumption is valid
10545 only if SYSTEM_MALLOC.
10546 (LARGE_REQUEST): New macro, so that the issue of large requests
10547 is separated from the issue of spare memory.
10548
810928a2
AS
105492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10550
172418ad
AS
10551 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10552 format. (Bug#8806)
10553
43f862f7
AS
10554 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10555
810928a2
AS
10556 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10557 before statements.
10558
a059fe24
JD
105592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10560
10561 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10562
10563 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10564
10565 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10566 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10567
989bf368
JB
105682011-06-05 Juanma Barranquero <lekktu@gmail.com>
10569
10570 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10571
4b80f674
CY
105722011-06-04 Chong Yidong <cyd@stupidchicken.com>
10573
10574 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10575 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10576 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10577 New error handlers.
4b80f674
CY
10578 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10579 Obey Vx_select_enable_clipboard_manager. Catch errors in
10580 x_clipboard_manager_save (Bug#8779).
10581 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10582 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10583
99a33b77 105842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10585
10586 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10587
99a33b77 105882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10589
10590 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10591 in the current matrix if keep_current_p is non-zero.
10592
8264569d
EZ
105932011-06-04 Eli Zaretskii <eliz@gnu.org>
10594
10595 * bidi.c (bidi_level_of_next_char): Fix last change.
10596
57f97249
EZ
105972011-06-03 Eli Zaretskii <eliz@gnu.org>
10598
fec2107c 10599 Support bidi reordering of text covered by display properties.
57f97249 10600
fec2107c
EZ
10601 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10602 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10603 (bidi_cache_search, bidi_cache_iterator_state)
10604 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10605 (bidi_level_of_next_char, bidi_move_to_visually_next):
10606 Support character positions inside a run of characters covered by a
fec2107c
EZ
10607 display string.
10608 (bidi_paragraph_init, bidi_resolve_explicit_1)
10609 (bidi_level_of_next_char): Call bidi_fetch_char and
10610 bidi_fetch_char_advance instead of FETCH_CHAR and
10611 FETCH_CHAR_ADVANCE.
10612 (bidi_init_it): Initialize new members.
10613 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10614 definitions.
10615 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10616 instead of using explicit *_CHAR codes.
d6d100dd
SM
10617 (bidi_resolve_explicit, bidi_resolve_weak):
10618 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10619 bidirectional text is supported only in multibyte buffers.
10620 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10621 it to initialize the frame_window_p member of struct bidi_it.
10622 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10623 (bidi_resolve_explicit, bidi_resolve_weak)
10624 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10625 bidi_it->nchars is non-positive.
10626 (bidi_level_of_next_char): Don't try to lookup the cache for the
10627 next/previous character if nothing is cached there yet, or if we
10628 were just reseat()'ed to a new position.
c40e2fb2 10629
0e14fe90
EZ
10630 * xdisp.c (set_cursor_from_row): Set start and stop points
10631 according to the row's direction when priming the loop that looks
10632 for the glyph on which to display cursor.
10633 (single_display_spec_intangible_p): Function deleted.
10634 (display_prop_intangible_p): Reimplement to call
10635 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10636 Accept 3 additional arguments needed by handle_display_spec.
10637 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10638 values: lists, `(when COND...)' forms, etc.
10639 (single_display_spec_string_p): Support property values that are
10640 lists with the argument STRING its top-level element.
10641 (display_prop_string_p): Fix the condition for processing a
10642 property that is a list to be consistent with handle_display_spec.
fec2107c 10643 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10644 last portion of handle_display_prop.
10645 (compute_display_string_pos): Accept additional argument
10646 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10647 value of a `display' property is a "replacing spec".
10648 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10649 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10650 the display property, but just return a value indicating whether
10651 the display property will replace the characters it covers.
10652 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10653 frame_window_p members of struct bidi_it.
d6d100dd
SM
10654 (compute_display_string_pos, compute_display_string_end):
10655 New functions.
fec2107c
EZ
10656 (push_it): Accept second argument POSITION, where pop_it should
10657 jump to continue iteration.
10658 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10659
fec2107c
EZ
10660 * keyboard.c (adjust_point_for_property): Adjust the call to
10661 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10662
10663 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10664 (bidi_init_it): Update prototypes.
10665 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10666 (compute_display_string_pos, compute_display_string_end):
10667 Declare prototypes.
fec2107c
EZ
10668 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10669 EMACS_INT.
fc6f18ce 10670
40087514 106712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10672
57f53182
PE
10673 Malloc failure behavior now depends on size of allocation.
10674 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10675 * lisp.h: Change signatures accordingly.
10676 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10677 All callers changed. (Bug#8762)
10678
10679 * gnutls.c: Use Emacs's memory allocators.
10680 Without this change, the gnutls library would invoke malloc etc.
10681 directly, which causes problems on non-SYNC_INPUT hosts, and which
10682 runs afoul of improving memory_full behavior. (Bug#8761)
10683 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10684 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10685 xfree instead of the default malloc, realloc, free.
10686 (Fgnutls_boot): No need to check for memory allocation failure,
10687 since xmalloc does that for us.
10688
ac32cd99 10689 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10690 * category.c (hash_get_category_set):
10691 * ccl.c (ccl_driver):
10692 * charset.c (Fdefine_charset_internal):
10693 * charset.h (struct charset.hash_index):
10694 * composite.c (get_composition_id, gstring_lookup_cache)
10695 (composition_gstring_put_cache):
10696 * composite.h (struct composition.hash_index):
10697 * dispextern.h (struct image.hash):
10698 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10699 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10700 (hashfn_equal, hashfn_user_defined, make_hash_table)
10701 (maybe_resize_hash_table, hash_lookup, hash_put)
10702 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10703 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10704 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10705 * image.c (make_image, search_image_cache, lookup_image)
10706 (xpm_put_color_table_h):
10707 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10708 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10709 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10710 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10711 * alloc.c (allocate_vectorlike):
10712 Check for overflow in vector size calculations.
10713 * ccl.c (ccl_driver):
10714 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10715 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10716 need to be updated by these changes.
40087514
PE
10717 * fns.c (make_hash_table, maybe_resize_hash_table):
10718 Check for integer overflow with large hash tables.
0de4bb68
PE
10719 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10720 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10721 (SXHASH_REDUCE): New macro.
10722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10723 Use it instead of discarding useful hash info with large hash values.
10724 (sxhash_float): New function.
10725 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10726 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10727 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10728 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10729 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10730 Adjust signatures to match updated version of code.
10731 (consing_since_gc): Now EMACS_INT, since a single hash table can
10732 use more than INT_MAX bytes.
10733
698d32e2
DN
107342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10735
10736 Make it possible to build with GCC-4.6+ -O2 -flto.
10737
10738 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10739
fd6fa53f
SM
107402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10741
10742 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10743 Call minibuffer-inactive-mode.
10744
864db017
JB
107452011-05-31 Juanma Barranquero <lekktu@gmail.com>
10746
10747 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10748 Update dependencies.
10749
2ad0baf4
DN
107502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10751
10752 * data.c (init_data): Remove code for UTS, this system is not
10753 supported anymore.
10754
4fcc2638
DN
107552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10756
10757 Don't force ./temacs to start in terminal mode.
10758
10759 * frame.c (make_initial_frame): Initialize faces in all cases, not
10760 only when CANNOT_DUMP is defined.
10761 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10762
c56e0fd5
DN
107632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10764
10765 * dispnew.c (add_window_display_history): Use const for the string
10766 pointer. Remove declaration, not needed.
10767
333d54da 107682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10769
55d4c1b2 10770 Use 'inline', not 'INLINE'.
333d54da 10771 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10772 * alloc.c, fontset.c (INLINE): Remove.
10773 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10774 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10775 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10776 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10777 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10778
738db178
DN
107792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10780
10781 Make it possible to run ./temacs.
10782
10783 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10784 syms_of_callproc does the same thing. Remove test for
10785 "initialized", do it in the caller.
10786 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10787
620c53a6
SM
107882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10789
10790 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10791 (read_minibuf): Use get_minibuffer.
10792 (syms_of_minibuf): Use DEFSYM.
10793 (Qmetadata): New var.
10794 * data.c (Qbuffer): Don't make it static.
10795 (syms_of_data): Use DEFSYM.
10796
e003a292
PE
107972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10798
10799 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10800 (CCL_CODE_MIN): New macro.
10801
ed008a6d
PE
108022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10803
3687c2ef
PE
10804 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10805
ed008a6d
PE
10806 * eval.c (Qdebug): Now static.
10807 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10808 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10809 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10810
d66c4c7c
CY
108112011-05-29 Chong Yidong <cyd@stupidchicken.com>
10812
10813 * image.c: Various fixes to ImageMagick code comments.
10814 (Fimagemagick_types): Doc fix.
10815
5fbc2025
PE
108162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10817
0196f88a
PE
10818 Minor fixes prompted by GCC 4.6.0 warnings.
10819
10820 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10821
5fbc2025
PE
10822 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10823 (x_clipboard_manager_save_all): Move extern decl to ...
10824 * xterm.h: ... here, so that it can be checked for consistency.
10825
1dd3c2d9
CY
108262011-05-29 Chong Yidong <cyd@stupidchicken.com>
10827
10828 * xselect.c (x_clipboard_manager_save_frame)
10829 (x_clipboard_manager_save_all): New functions.
10830 (Fx_clipboard_manager_save): Lisp function deleted.
10831
10832 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10833 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10834
10835 * xterm.h: Update prototype.
10836
5ba6571d
WX
108372011-05-28 William Xu <william.xwl@gmail.com>
10838
10839 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10840 exiting (Bug#8239).
10841
3eaff834
JM
108422011-05-28 Jim Meyering <meyering@redhat.com>
10843
e1900994 10844 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10845 * fns.c (to_uchar): Define.
10846 (crypto_hash_function): Use it to convert some newly-signed
10847 variables to unsigned, to avoid sign-extension bugs. For example,
10848 without this change, (md5 "truc") would evaluate to
10849 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10850 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10851 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10852
0f6990a7
PE
108532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10854
10855 Integer overflow fixes.
c8a9ca5a 10856
08686060
PE
10857 * dbusbind.c: Serial number integer overflow fixes.
10858 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10859 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10860 to hold a serial number that is too large for a fixnum.
10861 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10862 Check for serial numbers out of range. Decode any serial number
59568bf0 10863 that was so large that it became a float. (Bug#8722)
08686060 10864
2d1fc3c7
PE
10865 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10866 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10867 Use XFASTINT rather than XUINT when numbers are nonnegative.
10868 (xd_append_arg, Fdbus_method_return_internal):
10869 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10870 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10871 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10872 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10873 (Bug#8722)
2d1fc3c7 10874
c8a9ca5a
PE
10875 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10876
519e1d69
PE
10877 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10878
6df6ae42 10879 ccl: Add integer overflow checks.
30569699
PE
10880 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10881 (IN_INT_RANGE): New macros.
10882 (ccl_driver): Use them to check for integer overflow when
10883 decoding a CCL program. Many of the new checks are whether XINT (x)
10884 fits in int; it doesn't always, on 64-bit hosts. The new version
10885 doesn't catch all possible integer overflows, but it's an
847044ea 10886 improvement. (Bug#8719)
30569699 10887
c11285dc
PE
10888 * alloc.c (make_event_array): Use XINT, not XUINT.
10889 There's no need for unsigned here.
10890
fdccd48e
PE
10891 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10892 This follows up to the 2011-05-06 change that substituted uintptr_t
10893 for EMACS_INT. This case wasn't caught back then.
10894
37910ab2
PE
10895 Rework Fformat to avoid integer overflow issues.
10896 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10897 now (part of C89). Include <verify.h>.
10898 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10899 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10900 (Fformat): Avoid the prepass trying to compute sizes; it was only
10901 approximate and thus did not catch overflow reliably. Instead, walk
10902 through the format just once, formatting and computing sizes as we go,
10903 checking for integer overflow at every step, and allocating a larger
10904 buffer as needed. Keep track separately whether the format is
10905 multibyte. Keep only the most-recently calculated precision, rather
10906 than them all. Record whether each argument has been converted to
10907 string. Use EMACS_INT, not int, for byte and char and arg counts.
10908 Support field widths and precisions larger than INT_MAX. Avoid
10909 sprintf's undefined behavior with conversion specifications such as %#d
10910 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10911 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10912 formatting out-of-range floating point numbers with int
9173deec 10913 formats. (Bug#8668)
37910ab2 10914
2e6578fb
PE
10915 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10916
0ae6bdee
PE
10917 * data.c: Avoid integer truncation in expressions involving floats.
10918 * data.c: Include <intprops.h>.
10919 (arith_driver): When there's an integer overflow in an expression
10920 involving floating point, convert the integers to floating point
10921 so that the resulting value does not suffer from catastrophic
10922 integer truncation. For example, on a 64-bit host (* 4
10923 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10924 Do not rely on undefined behavior after integer overflow.
10925
de883a70
PE
10926 merge count_size_as_multibyte, parse_str_to_multibyte
10927 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10928 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10929 Check for integer overflow.
10930 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10931 since it's now a duplicate of the other. This is more of
10932 a character than a buffer op, so better that it's in character.c.
10933 * fns.c, print.c: Adjust to above changes.
10934
2ff916cb
PE
109352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10936
10937 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10938
f1b54466
PE
109392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10940
fb1ac845
PE
10941 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10942 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10943 (x_clipboard_manager_save): Now static.
10944 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10945
f1b54466
PE
10946 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10947 (crypto_hash_function): Now static.
10948 Fix pointer signedness problems. Avoid unnecessary initializations.
10949
a9f737ee
CY
109502011-05-27 Chong Yidong <cyd@stupidchicken.com>
10951
10952 * termhooks.h (Vselection_alist): Make it terminal-local.
10953
10954 * terminal.c (create_terminal): Initialize it.
10955
10956 * xselect.c: Support for clipboard managers.
10957 (Vselection_alist): Move to termhooks.h as terminal-local var.
10958 (LOCAL_SELECTION): New macro.
10959 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10960 (symbol_to_x_atom): Remove gratuitous arg.
10961 (x_handle_selection_request, lisp_data_to_selection_data)
10962 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10963 (x_own_selection, x_get_local_selection, x_convert_selection):
10964 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10965 (some_frame_on_display): Delete unused function.
10966 (Fx_own_selection_internal, Fx_get_selection_internal)
10967 (Fx_disown_selection_internal, Fx_selection_owner_p)
10968 (Fx_selection_exists_p): New optional frame arg.
10969 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10970 (x_handle_selection_clear): Don't treat other terminals with the
10971 same keyboard specially. Use the terminal-local Vselection_alist.
10972 (x_clear_frame_selections): Use Frun_hook_with_args.
10973
10974 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10975
10976 * xterm.h: Add support for those atoms.
10977
e067f0c1
CY
109782011-05-26 Chong Yidong <cyd@stupidchicken.com>
10979
10980 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10981 (converted_selections, conversion_fail_tag): New global variables.
10982 (x_selection_request_lisp_error): Free the above.
10983 (x_get_local_selection): Remove unnecessary code.
10984 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10985 of converted selections stored in converted_selections.
10986 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10987 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10988 (x_convert_selection): New function.
10989 (x_handle_selection_event): Simplify.
10990 (x_get_foreign_selection): Don't ignore incoming requests while
10991 waiting for an answer; this will fail when we implement
10992 SAVE_TARGETS, and seems unnecessary anyway.
10993 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10994 (Vx_sent_selection_functions): Doc fix.
10995
0f4aebc0
LL
109962011-05-26 Leo Liu <sdl.web@gmail.com>
10997
10998 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10999
e61124cd
YM
110002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11001
11002 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11003
11004 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11005 for fringe update if it has periodic bitmap.
ac389d0c 11006 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11007 and fringe_bitmap_periodic_p.
11008
11009 * fringe.c (get_fringe_bitmap_data): New function.
11010 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11011 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11012 row. Mark glyph row for fringe update if periodicity changed.
11013
11014 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11015 for fringe update unless it has periodic bitmap.
11016
f16d9837
KH
110172011-05-25 Kenichi Handa <handa@m17n.org>
11018
11019 * xdisp.c (get_next_display_element): Set correct it->face_id for
11020 a static composition.
11021
e1b90ef6
LL
110222011-05-24 Leo Liu <sdl.web@gmail.com>
11023
11024 * deps.mk (fns.o):
11025 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11026
11027 * fns.c (crypto_hash_function, Fsha1): New function.
11028 (Fmd5): Use crypto_hash_function.
11029 (syms_of_fns): Add Ssha1.
11030
7400048f
PE
110312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11032
11033 * gnutls.c: Remove unused macros.
11034 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11035 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11036 Remove macros that are defined and never used.
11037 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11038
abb71cf4
CY
110392011-05-22 Chong Yidong <cyd@stupidchicken.com>
11040
11041 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11042 (Fx_get_selection_internal): Minor cleanup.
11043 (Fx_own_selection_internal): Rename arguments for consistency with
11044 select.el.
11045
6307db39
PE
110462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11047
11048 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11049
f3d4e0a4
CY
110502011-05-22 Chong Yidong <cyd@stupidchicken.com>
11051
11052 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11053
4d8ade89
YM
110542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11055
11056 * dispnew.c (scrolling_window): Don't exclude the case that the
11057 last enabled row in the desired matrix touches the bottom boundary.
11058
32078c8d
GM
110592011-05-21 Glenn Morris <rgm@gnu.org>
11060
11061 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11062 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11063 and add some more files.
32078c8d 11064
7285dc67
EZ
110652011-05-20 Eli Zaretskii <eliz@gnu.org>
11066
11067 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11068 report_file_error introduced by the change from 2011-05-07.
11069
89d1bd22
PE
110702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11071
11072 * systime.h (Time): Define only if emacs is defined.
11073 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11074 where the include path doesn't have X11/X.h by default. See
11075 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11076
cd394be1 110772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11078
11079 * composite.c (find_automatic_composition): Fix previous change.
11080
b9704ad9
GM
110812011-05-20 Glenn Morris <rgm@gnu.org>
11082
11083 * lisp.mk: New file, split from Makefile.in.
11084 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11085 (shortlisp): Remove.
11086 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11087
4a720484
GM
110882011-05-19 Glenn Morris <rgm@gnu.org>
11089
11090 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11091 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11092 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11093 (lisp): Set the order to that of loadup.el.
11094 (shortlisp): Make it a copy of $lisp.
11095 (SOME_MACHINE_LISP): Remove.
11096 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11097 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11098
a28d4396
KH
110992011-05-18 Kenichi Handa <handa@m17n.org>
11100
11101 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11102 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11103 (find_automatic_composition): Mostly rewrite for efficiency.
11104
a2b1fa8e
JB
111052011-05-18 Juanma Barranquero <lekktu@gmail.com>
11106
11107 * makefile.w32-in: Update dependencies.
11108
8e1f5610
CS
111092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11110
11111 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11112 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11113
7025ee00 111142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11115
cdfa6eab
PE
11116 Fix some integer overflow issues, such as string length overflow.
11117
06d6db33
PE
11118 * insdel.c (count_size_as_multibyte): Check for string overflow.
11119
2b4560a8
PE
11120 * character.c (lisp_string_width): Check for string overflow.
11121 Use EMACS_INT, not int, for string indexes and lengths; in
11122 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11123 the resulting string length overflows an EMACS_INT; instead,
11124 report a string overflow if no precision given. When checking for
11125 precision exhaustion, use a check that cannot possibly have
11126 integer overflow. (Bug#8675)
11127 * character.h (lisp_string_width): Adjust to new signature.
11128
cb93f9be
PE
11129 * alloc.c (string_overflow): New function.
11130 (Fmake_string): Use it. This doesn't change behavior, but saves
11131 a few bytes and will simplify future changes.
11132 * character.c (string_escape_byte8): Likewise.
11133 * lisp.h (string_overflow): New decl.
11134
1a1f3366
PE
11135 Fixups, following up to the user-interface timestamp change.
11136 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11137 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11138 * msdos.c (mouse_get_pos): Likewise.
11139 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11140 * w32gui.h (Time): Define by including "systime.h" rather than by
11141 declaring it ourselves. (Bug#8664)
11142
d4e3e4d3
PE
11143 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11144 * image.c (clear_image_cache): Likewise.
11145
f6a24d19
PE
11146 * term.c (term_mouse_position): Don't assume time_t wraparound.
11147
08dc5ae6
PE
11148 Be more systematic about user-interface timestamps.
11149 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11150 and sometimes 'EMACS_UINT', to represent these timestamps.
11151 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11152 This makes the code easier to follow, and makes it easier to catch
11153 integer overflow bugs such as Bug#8664.
11154 * frame.c (Fmouse_position, Fmouse_pixel_position):
11155 Use Time, not unsigned long, for user-interface timestamps.
11156 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11157 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11158 * keyboard.h (last_event_timestamp): Likewise.
11159 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11160 * menu.h (xmenu_show): Likewise.
11161 * term.c (term_mouse_position): Likewise.
11162 * termhooks.h (struct input_event.timestamp): Likewise.
11163 (struct terminal.mouse_position_hook): Likewise.
11164 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11165 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11166 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11167 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11168 what it was before.
11169 * menu.h, termhooks.h: Include "systime.h", for Time.
11170
8e55734a
PE
11171 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11172 Don't assume that the difference between two unsigned long values
11173 can fit into an integer. At this point, we know button_down_time
11174 <= event->timestamp, so the difference must be nonnegative, so
11175 there's no need to cast the result if double-click-time is
11176 nonnegative, as it should be; check that it's nonnegative, just in
11177 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11178 apart (about 25 days). (Bug#8664)
8e55734a 11179
841f1b75 11180 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11181 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11182
3e26f69c
PE
11183 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11184 that always fit in int. Use a sentinel instead of a counter, to
11185 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11186 * frame.h (struct frame): Use int for menu_bar_items_used
11187 instead of EMACS_INT, since it always fits in int.
3e26f69c 11188
5cc152c0
PE
11189 * menu.c (grow_menu_items): Check for int overflow.
11190
d89eb65e
PE
11191 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11192
5235bd3e
PE
11193 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11194 Before, the code was not consistent. These values cannot exceed
11195 2**31 - 1 so there's no need to make them unsigned.
11196 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11197 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11198 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11199 as modifiers.
11200 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11201
bc827e23
PE
11202 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11203 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11204 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11205 presumably because the widths might not match.
11206
78eb494e
PE
11207 * window.c (size_window): Avoid needless test at loop start.
11208
04f2d78b
CB
112092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11210
11211 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11212
d2fc7e3d 112132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11214
11215 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11216
d2fc7e3d 112172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11218
11219 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11220 `width' to `bar_area_x' and `bar_area_width', respectively.
11221 (x_scroll_run): Take account of fringe background extension.
11222
04f2d78b
CB
11223 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11224 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11225 `bar_area_width', respectively.
11226 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11227 background extension.
11228
79b70037
GM
112292011-05-10 Jim Meyering <meyering@redhat.com>
11230
11231 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11232
2f142cc5
JB
112332011-05-10 Juanma Barranquero <lekktu@gmail.com>
11234
11235 * image.c (Finit_image_library): Return t for built-in image types,
11236 like pbm and xbm. (Bug#8640)
11237
57679c86
AS
112382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11239
11240 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11241
888c9e86
EZ
112422011-05-07 Eli Zaretskii <eliz@gnu.org>
11243
b0512a1d
EZ
11244 * w32console.c (Fset_screen_color): Doc fix.
11245 (Fget_screen_color): New function.
11246 (syms_of_ntterm): Defsubr it.
11247
7285dc67
EZ
11248 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11249 unlink the temporary file if Fcall_process didn't create it in the
11250 first place.
11251 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11252 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11253 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11254 cue to call_process_cleanup not to close that handle.
11255
4d3fcc8e
BK
112562011-05-07 Ben Key <bkey76@gmail.com>
11257
11258 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11259 one of two shell specific rules, either bootstrap-temacs-CMD or
11260 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11261 to the previous implementation of the bootstrap-temacs rule.
11262 The bootstrap-temacs-CMD rule is similar to the previous
11263 implementation of the bootstrap-temacs rule except that it
11264 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11265 variable.
11266
11267 These changes, along with some changes to nt/configure.bat,
11268 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11269 earlier fix to add support for --cflags and --ldflags options
11270 that include quotes so that it works whether make uses cmd or
11271 sh as the shell.
11272
b4289b64
MA
112732011-05-06 Michael Albinus <michael.albinus@gmx.de>
11274
11275 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11276 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11277 is a constant.
11278 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11279 a string. Handle both cases.
11280 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11281 (Fdbus_register_method): Use Qinvalid_function.
11282
af4c0e28
JB
112832011-05-06 Juanma Barranquero <lekktu@gmail.com>
11284
11285 * makefile.w32-in: Update dependencies.
11286 (LISP_H): Add inttypes.h and stdin.h.
11287 (PROCESS_H): Add unistd.h.
11288
c51453d9
EZ
112892011-05-06 Eli Zaretskii <eliz@gnu.org>
11290
11291 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11292 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11293
8ff0ac3c 112942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11295
4c4b566b
PE
11296 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11297
aab2b9b5
PE
11298 * term.c (vfatal): Remove stray call to va_end.
11299 It's not needed and the C Standard doesn't allow it here anyway.
11300
c378da0b
PE
11301 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11302 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11303
288b08c7
PE
11304 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11305 bytes.
11306
e3601888
PE
11307 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11308
db6c0e74
PE
11309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11310
dd5963ea
PE
11311 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11312
88c9450f
PE
11313 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11314
2f9442b8
PE
11315 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11316
c032b5f8
PE
11317 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11318 * charset.c (Fdefine_charset_internal): Don't initialize
11319 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11320 32-bit int (Bug#8600).
a108c10b
PE
11321
11322 * lread.c (read_integer): Be more consistent with string-to-number.
11323 Use string_to_number to do the actual conversion; this avoids
11324 rounding errors and fixes some other screwups. Without this fix,
11325 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11326 (digit_to_number): Move earlier, for benefit of read_integer.
11327 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11328 not a digit in any supported base. (Bug#8602)
a108c10b 11329
ad5f9eea
PE
11330 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11331
aec1708a
PE
11332 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11333 to match comment at start of function. This also removes a
11334 GCC warning about overflow in a 32+64-bit port.
11335
47be4ab5
PE
11336 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11337
371cac43
PE
11338 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11339 Reported by Stefan Monnier in
11340 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11341 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11342 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11343
d01a7826
PE
11344 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11345 (EMACS_UINTPTR): Likewise, with uintptr_t.
11346
7fd47d5c
PE
11347 * lisp.h: Prefer 64-bit EMACS_INT if available.
11348 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11349 on 32-bit hosts that have 64-bit int, so that they can access
11350 large files.
122b0c86
PE
11351 However, temporarily disable this change unless the temporary
11352 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11353
8727937b
PE
11354 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11355
8ac068ac
PE
11356 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11357 This removes an assumption that EMACS_INT and long are the same
11358 width as pointers. The assumption is true for Emacs porting targets
11359 now, but we want to make other targets possible.
11360 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11361 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11362 In the rest of the code, change types of integers that hold casted
11363 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11364 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11365 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11366 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11367 No need to cast type when ORing.
11368 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11369 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11370 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11371 assume EMACS_INT is the same width as char *.
11372 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11373 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11374 Remove no-longer-needed casts.
11375 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11376 (xg_tool_bar_help_callback, xg_make_tool_item):
11377 Use EMACS_INTPTR to hold an integer
11378 that will be cast to void *; this can avoid a GCC warning
11379 if EMACS_INT is not the same width as void *.
11380 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11381 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11382 (current_message_1, set_message_1):
11383 Use a local to convert to proper width without a cast.
11384 * xmenu.c (dialog_selection_callback): Likewise.
11385
ede49d71
PE
11386 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11387 Also, don't assume VALBITS / RAND_BITS is less than 5,
11388 and don't rely on undefined behavior when shifting a 1 left into
11389 the sign bit.
11390 * lisp.h (get_random): Change signature to match.
11391
2f30ecd0
PE
11392 * lread.c (hash_string): Use size_t, not int, for hash computation.
11393 Normally we prefer signed values; but hashing is special, because
11394 it's better to use unsigned division on hash table sizes so that
11395 the remainder is nonnegative. Also, size_t is the natural width
11396 for hashing into memory. The previous code used 'int', which doesn't
11397 retain enough info to hash well into very large tables.
11398 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11399
2a866e7b
PE
11400 * dbusbind.c: Don't possibly lose pointer info when converting.
11401 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11402 Use XPNTR rather than XHASH, so that the high-order bits of
11403 the pointer aren't lost when converting through void *.
11404
51639eac
PE
11405 * eval.c (Fautoload): Don't double-shift a pointer.
11406
92394119
PE
11407 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11408
dbdb9a7c
JB
114092011-05-06 Juanma Barranquero <lekktu@gmail.com>
11410
11411 * gnutls.c (DEF_GNUTLS_FN):
11412 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11413
db7a0b4f
AS
114142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11415
11416 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11417 marker. (Bug#8610)
11418
cd394be1 114192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11420
11421 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11422 New version that can reserve upto 2GB of heap space.
11423
f7ff1b0f 114242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11425
11426 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11427
639c109b
TZ
114282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11429
11430 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11431 `gnutls_certificate_set_x509_key_file'.
11432
d2127135
JB
114332011-05-05 Juanma Barranquero <lekktu@gmail.com>
11434
11435 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11436 Update dependencies.
11437
e968f4f3
JB
114382011-05-04 Juanma Barranquero <lekktu@gmail.com>
11439
11440 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11441 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11442 Remove unused parameter `fildes'.
11443 * process.c (read_process_output, send_process): Don't pass it.
11444
84d358f0
JB
114452011-05-04 Juanma Barranquero <lekktu@gmail.com>
11446
11447 Fix previous change: the library cache is defined in w32.c.
11448 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11449 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11450
0898ca10
JB
114512011-05-04 Juanma Barranquero <lekktu@gmail.com>
11452
11453 Implement dynamic loading of GnuTLS on Windows.
11454
11455 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11456 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11457 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11458 Declare.
11459
11460 * gnutls.c (Qgnutls_dll): Define.
11461 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11462 (gnutls_*): Declare function pointers.
11463 (init_gnutls_functions): New function to initialize function pointers.
11464 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11465 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11466 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11467 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11468 (emacs_gnutls_write, emacs_gnutls_read)
11469 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11470 (Fgnutls_available_p): New function.
11471 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11472 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11473 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11474
11475 * image.c: Include w32.h.
11476 (Vimage_type_cache): Delete.
11477 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11478 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11479 (w32_delayed_load): Move to w32.c.
11480
11481 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11482
11483 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11484 (w32_delayed_load): Move from image.c. When loading a library, record
11485 its filename in the :loaded-from property of the library id.
11486 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11487 Initialize and staticpro them.
11488 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11489
11490 * process.c: Include lisp.h before w32.h, not after.
11491 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11492 instead of gnutls_record_check_pending.
11493
11494 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11495
ff4de4aa
TZ
114962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11497
11498 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11499 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11500 as passed in.
11501
abe95abb
JD
115022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11503
11504 * xterm.c (x_set_frame_alpha): Do not set property on anything
11505 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11506
e16e55d4
JB
115072011-05-02 Juanma Barranquero <lekktu@gmail.com>
11508
11509 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11510
bafcf6a5
JB
115112011-05-02 Juanma Barranquero <lekktu@gmail.com>
11512
11513 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11514 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11515 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11516 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11517 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11518 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11519 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11520 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11521 (Qgnutls_bootprop_callbacks_verify): Make static.
11522
e7a6747f
AS
115232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11524
19ed11ba
AS
11525 * callproc.c: Indentation fixup.
11526
e7a6747f 11527 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11528 (wait_for_termination, interruptible_wait_for_termination):
11529 Move after wait_for_termination_1.
e7a6747f 11530
1ef14cb4
LMI
115312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11532
11533 * sysdep.c (interruptible_wait_for_termination): New function
11534 which is like wait_for_termination, but allows keyboard
11535 interruptions.
11536
11537 * callproc.c (Fcall_process): Add (:file "file") as an option for
11538 the STDOUT buffer.
11539 (Fcall_process_region): Ditto.
11540
330d880c
EZ
115412011-04-30 Eli Zaretskii <eliz@gnu.org>
11542
8db90b73
EZ
11543 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11544 rather than `XVECTOR (FOO)->size'.
11545
330d880c
EZ
11546 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11547 inttypes.h, as a gnulib replacement is used if it not available in
11548 system headers.
11549
15cbd324
EZ
115502011-04-21 Eli Zaretskii <eliz@gnu.org>
11551
11552 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11553 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11554 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11555
11556 * coding.c (coding_alloc_by_realloc): Error out if destination
11557 will grow beyond MOST_POSITIVE_FIXNUM.
11558 (decode_coding_emacs_mule): Abort if there isn't enough place in
11559 charbuf for the composition carryover bytes. Reserve an extra
11560 space for up to 2 characters produced in a loop.
11561 (decode_coding_iso_2022): Abort if there isn't enough place in
11562 charbuf for the composition carryover bytes.
11563
115642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11565
ae940cca
EZ
11566 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11567 aborting when %lld or %lll format is passed.
11568 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11569 %llo or %llx format is passed. (Bug#8545)
11570
03ab8921
EZ
11571 * window.c (window_scroll_line_based): Use a marker instead of
11572 simple variables to record original value of point. (Bug#7952)
11573
afda1437
EZ
11574 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11575 produced by %s or %c overflows available buffer space. (Bug#8545)
11576
f76dee0c
PE
115772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11578
11579 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11580 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11581
fdc5744d
JB
115822011-04-28 Juanma Barranquero <lekktu@gmail.com>
11583
11584 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11585
638f053a
JB
115862011-04-28 Juanma Barranquero <lekktu@gmail.com>
11587
11588 * keyboard.c (Qdelayed_warnings_hook): Define.
11589 (command_loop_1): Run `delayed-warnings-hook'
11590 if Vdelayed_warnings_list is non-nil.
11591 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11592 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11593
d178f871
EZ
115942011-04-28 Eli Zaretskii <eliz@gnu.org>
11595
11596 * doprnt.c (doprnt): Don't return value smaller than the buffer
11597 size if the message was truncated. (Bug#8545).
11598
b124fd93
JB
115992011-04-28 Juanma Barranquero <lekktu@gmail.com>
11600
11601 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11602 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11603
e810457d
PE
116042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11605
11606 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11607
ea51cceb
JB
116082011-04-27 Juanma Barranquero <lekktu@gmail.com>
11609
11610 * makefile.w32-in: Update dependencies.
11611
94dcfacf
EZ
116122011-04-27 Eli Zaretskii <eliz@gnu.org>
11613
11614 Improve `doprnt' and its usage. (Bug#8545)
11615 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11616 `format_end'. Remove support for %l as a conversion specifier.
11617 Don't use xrealloc. Improve diagnostics when the %l size modifier
11618 is used. Update the commentary.
11619
11620 * eval.c (verror): Simplify calculation of size_t.
11621
11622 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11623 messages.
11624
f61f41d7
PE
116252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11626
11627 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11628 change.
11629
96fb4434
PE
116302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11631
11632 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11633 This makes this file independent of the recent pseudovector change.
11634
671875da 116352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11636
69e9b5a3
PE
11637 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11638
b5f869a7 11639 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11640 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11641 Remove unused local.
c8926152 11642 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11643
841a1577 11644 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11645 GCC 4.6.0 optimizes based on type-based alias analysis.
11646 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11647 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11648 != &v->size, and therefore "v->size = 1; b->size = 2; return
11649 v->size;" must therefore return 1. This assumption is incorrect
11650 for Emacs, since it type-puns struct Lisp_Vector * with many other
11651 types. To fix this problem, this patch adds a new type struct
f904488f 11652 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11653 and pseudovectors, and helps optimizing compilers not get fooled
11654 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11655 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11656 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11657 the size member.
eab3844f
PE
11658 (XSETPVECTYPE): Rewrite in terms of new macro.
11659 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11660 This is a bit clearer, and further avoids the possibility of
11661 undesirable aliasing.
11662 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11663 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11664 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11665 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11666 (ASIZE): Now uses header.size rather than size.
11667 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11668 to avoid the hassle of writing XVECTOR (foo)->header.size.
11669 (struct vectorlike_header): New type.
eab3844f
PE
11670 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11671 object, to help avoid aliasing.
11672 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11673 (SUBRP): Likewise, since Lisp_Subr is a special case.
11674 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11675 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11676 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11677 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11678 changed to be "header.size" and "header.next".
11679 * buffer.h (struct buffer): Likewise.
11680 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11681 * frame.h (struct frame): Likewise.
11682 * process.h (struct Lisp_Process): Likewise.
11683 * termhooks.h (struct terminal): Likewise.
11684 * window.c (struct save_window_data, struct saved_window): Likewise.
11685 * window.h (struct window): Likewise.
11686 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11687 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11688 * buffer.c (init_buffer_once): Likewise.
11689 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11690 special case.
11691 * process.c (Fformat_network_address): Use local var for size,
11692 for brevity.
11693
0df1eac5
PE
11694 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11695
847ab9d1 11696 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11697 * data.c (atof): Remove decl; no longer used or needed.
11698 (digit_to_number): Move to lread.c.
11699 (Fstring_to_number): Use new string_to_number function, to be
11700 consistent with how the Lisp reader treats infinities and NaNs.
11701 Do not assume that floating-point numbers represent EMACS_INT
11702 without losing information; this is not true on most 64-bit hosts.
11703 Avoid double-rounding errors, by insisting on integers when
11704 parsing non-base-10 numbers, as the documentation specifies.
11705 * lisp.h (string_to_number): New decl, replacing ...
11706 (isfloat_string): Remove.
bc0a5c13 11707 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11708 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11709 appears to have been a coding error. Similarly, do not accept
11710 strings like +-1e0 as floating point numbers. Do not report
11711 overflow for integer overflows unless the base is not 10 which
11712 means we have no simple and reliable way to continue.
11713 Break out the floating-point parsing into a new
11714 function string_to_number, so that Fstring_to_number parses
11715 floating point numbers consistently with the Lisp reader.
04f2d78b 11716 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11717 (E_CHAR, EXP_INT): Remove, replacing with ...
11718 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11719 (string_to_number): New function, replacing isfloat_string.
11720 This function checks for valid syntax and produces the resulting
11721 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11722 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11723 so that overflow for non-base-10 numbers is reported only when
11724 there's no portable and simple way to convert to floating point.
452f4150 11725
67769ffc
PE
11726 * textprop.c (set_text_properties_1): Rewrite for clarity,
11727 and to avoid GCC warning about integer overflow.
11728
c20db43f
PE
11729 * intervals.h (struct interval): Use EMACS_INT for members
11730 where EMACS_UINT might cause problems. See
11731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11732 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11733 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11734 All uses changed.
37aa2f85
PE
11735 (offset_intervals): Tell GCC not to worry about length overflow
11736 when negating a negative length.
c20db43f 11737
2538aa2f
PE
11738 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11739 (overrun_check_free): Likewise.
11740
f2d3008d
PE
11741 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11742 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11743 word size.
11744
ec8df744
PE
11745 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11746 (gnutls_make_error): Rename local to avoid shadowing.
11747 (gnutls_emacs_global_deinit): ifdef out; not used.
11748 (Fgnutls_boot): Use const for pointer to readonly storage.
11749 Comment out unused local. Fix pointer signedness problems.
11750
640ee02d
PE
11751 * lread.c (openp): Don't stuff size_t into an 'int'.
11752 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11753 about possible signed overflow.
11754
6048fb2a
PE
11755 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11756 (GDK_KEY_g): Don't define if already defined.
11757 (xg_prepare_tooltip): Avoid pointer signedness problem.
11758 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11759
fa3c87e1
PE
11760 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11761 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11762
2172544b
PE
11763 * xfns.c (Fx_window_property): Simplify a bit,
11764 to make a bit faster and to avoid GCC 4.6.0 warning.
11765 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11766
9b821a21
PE
11767 * fns.c (internal_equal): Don't assume size_t fits in int.
11768
3c616cfa
PE
11769 * alloc.c (compact_small_strings): Tighten assertion a little.
11770
c2982e87
PE
11771 Replace pEd with more-general pI, and fix some printf arg casts.
11772 * lisp.h (pI): New macro, generalizing old pEd macro to other
11773 conversion specifiers. For example, use "...%"pI"d..." rather
11774 than "...%"pEd"...".
11775 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11776 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11777 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11778 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11779 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11780 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11781 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11782 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11783 64-bit hosts.
11784 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11785 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11786 * print.c (safe_debug_print, print_object): Likewise.
11787 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11788 to int.
6f04d126
PE
11789 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11790 avoiding the 0 flag, which is not portable.
c2982e87
PE
11791 * process.c (Fmake_network_process): Use pI to avoid cast.
11792 * region-cache.c (pp_cache): Likewise.
11793 * xdisp.c (decode_mode_spec): Likewise.
11794 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11795 behavior on 64-bit hosts with printf arg.
6f04d126 11796 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11797 (x_stop_queuing_selection_requests): Likewise.
11798 (x_get_window_property): Don't truncate byte count to an 'int'
11799 when tracing.
0b432f21 11800
5e073ec7
PE
11801 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11802 here, since it parses constructs like leading '-' and spaces,
11803 which are not wanted; and it overflows with large numbers.
11804 Instead, simply match F[0-9]+, which is what is wanted anyway.
11805
36372bf9
PE
11806 * alloc.c: Remove unportable assumptions about struct layout.
11807 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11808 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11809 (allocate_vectorlike, make_pure_vector): Use the new macros,
11810 plus offsetof, to remove unportable assumptions about struct layout.
11811 These assumptions hold on all porting targets that I know of, but
11812 they are not guaranteed, they're easy to remove, and removing them
11813 makes further changes easier.
11814
0b432f21
PE
11815 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11816 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11817 (string_overrun_cookie): Now const. Use initializers that
11818 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11819 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11820 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11821 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11822 multiple of sizeof (EMACS_INT); it need not be, if
11823 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11824 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11825
895009e1
JB
118262011-04-26 Juanma Barranquero <lekktu@gmail.com>
11827
11828 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11829
6a7a1b0b
TZ
118302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11831
11832 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11833 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11834 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11835
841a1577 118362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11837
11838 * lisp.h (Qdebug): List symbol.
895009e1 11839 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11840 * keyboard.c (debug-on-event): New variable.
11841 (handle_user_signal): Break into debugger when debug-on-event
11842 matches the current signal symbol.
11843
f2d3ba6f
DN
118442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11845
11846 * alloc.c (check_sblock, check_string_bytes)
11847 (check_string_free_list): Convert to standard C.
11848
42ce4c63
TZ
118492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11850
11851 * w32.c (emacs_gnutls_push): Fix typo.
11852
825cd63c
EZ
118532011-04-25 Eli Zaretskii <eliz@gnu.org>
11854
fb11d64d
EZ
11855 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11856 "cast to pointer from integer of different size".
11857
825cd63c
EZ
11858 Improve doprnt and its use in verror. (Bug#8545)
11859 * doprnt.c (doprnt): Document the set of format control sequences
11860 supported by the function. Use SAFE_ALLOCA instead of always
11861 using `alloca'.
11862
11863 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11864 is one byte too soon. Don't use xrealloc; instead xfree and
11865 xmalloc anew.
11866
e061a11b
TZ
118672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11868
11869 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11870 callbacks stage.
11871
11872 * gnutls.c: Renamed global_initialized to
11873 gnutls_global_initialized. Added internals for the
11874 :verify-hostname-error, :verify-error, and :verify-flags
11875 parameters of `gnutls-boot' and documented those parameters in the
11876 docstring. Start callback support.
9173deec
JB
11877 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11878 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11879 on error. Return error code.
e061a11b
TZ
11880 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11881 (emacs_gnutls_read): Likewise.
11882 (Fgnutls_boot): Return handshake error code.
11883 (emacs_gnutls_handle_error): New function.
11884 (wsaerror_to_errno): Likewise.
11885
11886 * w32.h (emacs_gnutls_pull): Add prototype.
11887 (emacs_gnutls_push): Likewise.
11888
11889 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11890 (emacs_gnutls_push): Likewise.
11891
118922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11893
11894 * process.c (wait_reading_process_output): Check if GnuTLS
11895 buffered some data internally if no FDs are set for TLS
11896 connections.
11897
11898 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11899 (LIBS): Link to USER_LIBS.
11900 ($(BLD)/gnutls.$(0)): New target.
11901
fa6996bc
EZ
119022011-04-24 Eli Zaretskii <eliz@gnu.org>
11903
eb35682e
EZ
11904 * xdisp.c (handle_single_display_spec): Rename the
11905 display_replaced_before_p argument into display_replaced_p, to
11906 make it consistent with the commentary. Fix typos in the
11907 commentary.
11908
e2ad650c
EZ
11909 * textprop.c (syms_of_textprop): Remove dead code.
11910 (copy_text_properties): Delete obsolete commentary about an
11911 interface that was deleted long ago. Fix typos in the description
11912 of arguments.
11913
1b2de274
EZ
11914 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11915 to changes in oldXMenu/XMenu.h from 2011-04-16.
11916 <menu_help_message, prev_menu_help_message>: Constify.
11917 (IT_menu_make_room): menu->help_text is now `const char **';
11918 adjust.
11919
11920 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11921 to changes in oldXMenu/XMenu.h from 2011-04-16.
11922 (struct XMenu): Declare `help_text' `const char **'.
11923
11924 * xfaces.c <Qunspecified>: Make extern again.
11925
11926 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11927 required by POSIX.
1b2de274 11928
762b15be
EZ
11929 * doc.c (get_doc_string): Improve the format passed to `error'.
11930
11931 * doprnt.c (doprnt): Improve commentary.
11932
11933 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11934
11935 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11936 them with etags.
11937
f1052e5d
EZ
11938 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11939 changes in globals.h immediately force recompilation.
762b15be
EZ
11940 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11941 $(CURDIR)/s/ms-w32.h.
11942 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11943
fa6996bc
EZ
11944 * character.c (Fchar_direction): Function deleted.
11945 (syms_of_character): Don't defsubr it.
11946 <char-direction-table>: Deleted.
11947
e6c3da20
EZ
119482011-04-23 Eli Zaretskii <eliz@gnu.org>
11949
11950 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11951 * doprnt.c: Include limits.h.
11952 (SIZE_MAX): New macro.
04f2d78b
CB
11953 (doprnt): Return a size_t value. 2nd arg is now size_t.
11954 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11955 Improve overflow protection. Support `l' modifier for integer
11956 conversions. Support %l conversion. Don't assume an EMACS_INT
11957 argument for integer conversions and for %c.
11958
11959 * lisp.h (doprnt): Restore prototype.
11960
11961 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11962 $(SRC)/character.h.
11963
11964 * Makefile.in (base_obj): Add back doprnt.o.
11965
11966 * deps.mk (doprnt.o): Add back prerequisites.
11967 (callint.o): Depend on character.h.
11968
11969 * eval.c (internal_lisp_condition_case): Include the handler
11970 representation in the error message.
11971 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11972 when breaking from the loop.
11973
11974 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11975
11976 * callint.c (Fcall_interactively): When displaying error message
11977 about invalid control letter, pass the character's codepoint, not
11978 a pointer to its multibyte form. Improve display of the character
11979 in octal and display also its hex code.
11980
11981 * character.c (char_string): Use %x to display the (unsigned)
11982 codepoint of an invalid character, to avoid displaying a bogus
11983 negative value.
11984
11985 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11986 `error', not SYMBOL_NAME itself.
11987
11988 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11989 character arguments to `error'.
11990
11991 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11992 to `error' in error message about FINAL_CHAR argument. Make sure
11993 FINAL_CHAR is a character, and use %c when it is passed as
11994 argument to `error'.
11995
4ffd0d6b 119962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11997
11998 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11999
12000 * w32.c: Include <time.h>.
12001 (sys_localtime): New function.
12002
4ffd0d6b 120032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12004
12005 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12006
4ffd0d6b 12007 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12008
4ffd0d6b 120092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12010
4ffd0d6b
GM
12011 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12012 zombies (Bug#8467).
aac0c6e3 12013
04c56954
EZ
120142011-04-19 Eli Zaretskii <eliz@gnu.org>
12015
12016 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12017 gl_state.e_property when gl_state.object is Qt.
12018
12019 * insdel.c (make_gap_larger): Remove limitation of buffer size
12020 to <= INT_MAX.
12021
16a43933
CY
120222011-04-18 Chong Yidong <cyd@stupidchicken.com>
12023
12024 * xdisp.c (lookup_glyphless_char_display)
12025 (produce_glyphless_glyph): Handle cons cell entry in
12026 glyphless-char-display.
12027 (Vglyphless_char_display): Document it.
12028
12029 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12030 glyphless-char-display.
12031
4581706e
CY
120322011-04-17 Chong Yidong <cyd@stupidchicken.com>
12033
12034 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12035
12036 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12037
12038 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12039 definition for no-X builds.
12040
4887c6e2 120412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12042
fd35b6f9
PE
12043 Static checks with GCC 4.6.0 and non-default toolkits.
12044
5c1ccb01
PE
12045 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12046
006c5daa
PE
12047 * process.c (keyboard_bit_set): Define only if SIGIO.
12048 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12049 (send_process): Repair possible setjmp clobbering.
12050
efc736d3
PE
12051 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12052
4e2fe2e6
PE
12053 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12054
f97334a2
PE
12055 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12056
4e75f29d
PE
12057 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12058 Define only if needed.
12059
90efadd1
PE
12060 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12061 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12062 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12063
3c647824
PE
12064 * dispextern.h (struct redisplay_interface): Rename param
12065 to avoid shadowing.
e264f262 12066 * termhooks.h (struct terminal): Likewise.
761383f4 12067 * xterm.c (xembed_send_message): Likewise.
3c647824 12068
b58c5c4a
PE
12069 * insdel.c (make_gap_smaller): Define only if
12070 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12071
cad59032
PE
12072 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12073 it.
12074
c339dc2e
PE
12075 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12076 so that we aren't warned about unused symbols.
12077
91a3e27b
PE
12078 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12079
399c71d3 12080 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12081
8ffc96f5
PE
12082 * xfns.c (x_real_positions): Mark locals as initialized.
12083
eef9bc79
PE
12084 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12085
098db9dd
PE
12086 * xterm.c: Fix problems found by static analysis with other toolkits.
12087 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12088 (x_dispatch_event): Declare static if USE_GTK, and
12089 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12090 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12091 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12092 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12093 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12094
eb18f6cc
PE
12095 * xmenu.c (menu_help_callback): Pointer type fixes.
12096 Use const pointers when pointing at readonly data. Avoid pointer
12097 signedness clashes.
12098 (FALSE): Remove unused macro.
12099 (update_frame_menubar): Remove unused decl.
12100
1fe72bf8
PE
12101 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12102
60d9e1db
PE
12103 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12104 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12105 (single_menu_item): Rename local to avoid shadowing.
12106
39261c26
PE
12107 * keyboard.c (make_lispy_event): Remove unused local var.
12108
018c5e19
PE
12109 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12110 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12111
63d2b86e
PE
12112 * bitmaps: Change bitmaps from unsigned char back to the X11
12113 compatible char. Avoid the old compiler warnings about
12114 out-of-range initializers by using, for example, '\xab' rather
12115 than 0xab.
12116
aefd87e1
PE
12117 * xgselect.c (xgselect_initialize): Check vs interface
12118 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12119
bf501fb9
PE
12120 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12121
e9829fdf
PE
12122 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12123 to read-only memory.
12124
1086c095
PE
12125 * fns.c (vector): Remove; this old hack is no longer needed.
12126
2baccd04 12127 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12128 Remove unused var.
dde42981 12129 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12130
72391843 12131 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12132
436c16df 12133 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12134 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12135 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12136
92bb796d 12137 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12138 (x_term_init): Remove local to avoid shadowing.
92bb796d 12139
764430a3 12140 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12141
12142 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12143 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12144
d1dfb56c
EZ
121452011-04-16 Eli Zaretskii <eliz@gnu.org>
12146
c4354cb4
EZ
12147 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12148
d1dfb56c
EZ
12149 Fix regex.c, syntax.c and friends for buffers > 2GB.
12150 * syntax.h (struct gl_state_s): Declare character position members
12151 EMACS_INT.
12152
12153 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12154
04f2d78b
CB
12155 * textprop.c (verify_interval_modification, interval_of):
12156 Declare arguments EMACS_INT.
d1dfb56c
EZ
12157
12158 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12159 EMACS_INT.
12160
12161 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12162
12163 * indent.c (Fvertical_motion): Local variable it_start is now
12164 EMACS_INT.
12165
12166 * regex.c (re_match, re_match_2, re_match_2_internal)
12167 (bcmp_translate, regcomp, regexec, print_double_string)
12168 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12169 (re_compile_pattern, re_exec): Declare arguments and local
12170 variables `size_t' and `ssize_t' and return values `regoff_t', as
12171 appropriate.
12172 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12173 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12174 <compile_stack_type>: `size' and `avail' are now `size_t'.
12175
12176 * regex.h <regoff_t>: Use ssize_t, not int.
12177 (re_search, re_search_2, re_match, re_match_2): Arguments that
12178 specify buffer/string position and length are now ssize_t and
12179 size_t. Return type is regoff_t.
12180
613052cd
BK
121812011-04-16 Ben Key <bkey76@gmail.com>
12182
12183 * nsfont.m: Fixed bugs in ns_get_family and
12184 ns_descriptor_to_entity that were caused by using free to
12185 deallocate memory blocks that were allocated by xmalloc (via
12186 xstrdup). This caused Emacs to crash when compiled with
12187 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12188 --enable-checking=xmallocoverrun). xfree is now used to
12189 deallocate these memory blocks.
12190
4170f62f 121912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12192
71b41406
PE
12193 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12194
9587a89d
PE
12195 emacs_write: Accept and return EMACS_INT for sizes.
12196 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12197 et seq.
12198 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12199 Accept and return EMACS_INT.
12200 (emacs_gnutls_write): Return the number of bytes written on
12201 partial writes.
12202 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12203 (emacs_read, emacs_write): Remove check for negative size, as the
12204 Emacs source code has been audited now.
9587a89d
PE
12205 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12206 (emacs_read, emacs_write): Use it.
273a5f82
PE
12207 * process.c (send_process): Adjust to the new signatures of
12208 emacs_write and emacs_gnutls_write. Do not attempt to store
12209 a byte offset into an 'int'; it might overflow.
9587a89d 12210 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12211
3e047f51
PE
12212 * sound.c: Don't assume sizes fit in 'int'.
12213 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12214 Return EMACS_INT, not int.
3e047f51 12215 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12216 Accept EMACS_INT, not int.
12217 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12218 record read return values.
12219
cc39a9db
BK
122202011-04-15 Ben Key <bkey76@gmail.com>
12221
c9d0ec6d
JB
12222 * keyboard.c (Qundefined): Don't declare static since it is used
12223 in nsfns.m.
12224 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12225 static since they are used in nsfont.m.
cc39a9db 12226
6c60eb9f
SM
122272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12228
12229 * process.c (Qprocessp): Don't declare static.
12230 * lisp.h (Qprocessp): Declare again.
12231
7990b61a
JB
122322011-04-15 Juanma Barranquero <lekktu@gmail.com>
12233
12234 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12235
5d4cb038
PE
122362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12237
8bd7b830 12238 Improve C-level modularity by making more things 'static'.
cd64ea1d 12239
e3b27b31
PE
12240 Don't publish debugger-only interfaces to other modules.
12241 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12242 (verify_bytepos, count_markers): Move decls to the only modules
12243 that need them.
12244 * region-cache.h (pp_cache): Likewise.
12245 * window.h (check_all_windows): Likewise.
12246 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12247
5d4cb038
PE
12248 * sysdep.c (croak): Now static, if
12249 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12250 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12251
12252 * alloc.c (refill_memory_reserve): Now static if
12253 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12254 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12255
e87b6180
PE
12256 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12257 Define only if USE_LUCID.
12258
ac64929e
PE
12259 * xrdb.c (x_customization_string, x_rm_string): Now static.
12260
6f37259d
PE
12261 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12262 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12263
1683e3ab
PE
12264 * xdisp.c (draw_row_with_mouse_face): Now static.
12265 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12266
de9c2632
PE
12267 * window.h (check_all_windows): Mark externally visible.
12268
2b96acb7
PE
12269 * window.c (window_deletion_count): Now static.
12270
12271 * undo.c: Make symbols static if they're not exported.
12272 (last_undo_buffer, last_boundary_position, pending_boundary):
12273 Now static.
12274
50436f33
PE
12275 * textprop.c (interval_insert_behind_hooks): Now static.
12276 (interval_insert_in_front_hooks): Likewise.
12277
64520e5c
PE
12278 * term.c: Make symbols static if they're not exported.
12279 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12280 (max_frame_lines, tty_set_terminal_modes):
12281 (tty_reset_terminal_modes, tty_turn_off_highlight):
12282 (get_tty_terminal): Now static.
12283 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12284 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12285 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12286 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12287 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12288
1fa53021
PE
12289 * sysdep.c: Make symbols static if they're not exported.
12290 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12291 Now static.
12292 (sigprocmask_set, full_mask): Remove; unused.
12293 (wait_debugging): Mark as visible.
12294 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12295 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12296
d4b43b22
PE
12297 * syntax.c (syntax_temp): Define only if !__GNUC__.
12298
b7c513d0
PE
12299 * sound.c (current_sound_device, current_sound): Now static.
12300
989b29ad
PE
12301 * search.c (searchbufs, searchbuf_head): Now static.
12302
13a55a78
PE
12303 * scroll.c (scroll_cost): Remove; unused.
12304 * dispextern.h (scroll_cost): Remove decl.
12305
de68a1fc
PE
12306 * region-cache.h (pp_cache): Mark as externally visible.
12307
40ccffa6
PE
12308 * process.c: Make symbols static if they're not exported.
12309 (process_tick, update_tick, create_process, chan_process):
12310 (Vprocess_alist, proc_buffered_char, datagram_access):
12311 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12312 (deactivate_process): Mark defn as static, as well as decl.
12313 * lisp.h (create_process): Remove decl.
12314 * process.h (chan_process, Vprocess_alist): Remove decls.
12315
ad64fc97
PE
12316 * print.c: Make symbols static if they're not exported.
12317 (print_depth, new_backquote_output, being_printed, print_buffer):
12318 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12319 (print_interval, print_number_index, initial_stderr_stream):
12320 Now static.
12321 * lisp.h (Fprinc): Remove decl.
12322 (debug_output_compilation_hack): Mark as externally visible.
12323
adddb265
PE
12324 * sysdep.c (croak): Move decl from here to syssignal.h.
12325 * syssignal.h (croak): Put it here, so the API can be checked when
12326 'croak' is called from dissociate_if_controlling_tty.
12327
1717ede2
PE
12328 * minibuf.c: Make symbols static if they're not exported.
12329 (minibuf_save_list, choose_minibuf_frame): Now static.
12330 * lisp.h (choose_minibuf_frame): Remove decl.
12331
fa5fb2bc
PE
12332 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12333
1e3890d1
PE
12334 * lread.c: Make symbols static if they're not exported.
12335 (read_objects, initial_obarray, oblookup_last_bucket_number):
12336 Now static.
12337 (make_symbol): Remove; unused.
12338 * lisp.h (initial_obarray, make_symbol): Remove decls.
12339
8a1414fa
PE
12340 * keyboard.c: Make symbols static if they're not exported.
12341 (single_kboard, recent_keys_index, total_keys, recent_keys):
12342 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12343 (this_single_command_key_start, echoing, last_auto_save):
12344 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12345 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12346 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12347 (Vlispy_mouse_stem, double_click_count):
12348 Now static.
12349 (force_auto_save_soon): Define only if SIGDANGER.
12350 (ignore_mouse_drag_p): Now static if
12351 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12352 (print_help): Remove; unused.
12353 (stop_character, last_timer_event): Mark as externally visible.
12354 * keyboard.h (ignore_mouse_drag_p): Declare only if
12355 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12356 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12357 * lisp.h (echoing): Remove decl.
12358 (force_auto_save_soon): Declare only if SIGDANGER.
12359 * xdisp.c (redisplay_window): Simplify code, to make it more
12360 obvious that ignore_mouse_drag_p is not accessed if !defined
12361 USE_GTK && !defined HAVE_NS.
12362
93ea6e8f
PE
12363 * intervals.c: Make symbols static if they're not exported.
12364 (merge_properties_sticky, merge_interval_right, delete_interval):
12365 Now static.
12366 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12367
77382fcc
PE
12368 * insdel.c: Make symbols static if they're not exported.
12369 However, leave prepare_to_modify_buffer alone. It's never
12370 called from outside this function, but that appears to be a bug.
12371 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12372 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12373 (adjust_after_replace_noundo): Remove; unused.
12374 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12375 (signal_before_change): Remove decls.
77382fcc 12376
9306c32e
PE
12377 * indent.c (val_compute_motion, val_vmotion): Now static.
12378
cd44d2eb
PE
12379 * image.c: Make symbols static if they're not exported.
12380 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12381 if USE_GTK.
12382 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12383 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12384
ad9a7a06
PE
12385 * fringe.c (standard_bitmaps): Now static.
12386 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12387
81626931
PE
12388 * frame.c: Make symbols static if they're not exported.
12389 (x_report_frame_params, make_terminal_frame): Now static.
12390 (get_frame_param): Now static, unless HAVE_NS.
12391 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12392 (x_get_resource_string): Remove; not used.
12393 * frame.h (make_terminal_frame, x_report_frame_params):
12394 (x_get_resource_string); Remove decls.
12395 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12396 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12397
239f9db9
PE
12398 * font.c, fontset.c: Make symbols static if they're not exported.
12399 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12400 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12401 * font.c (font_close_object): Now static.
12402 * font.h (font_close_object): Remove.
12403 * fontset.c (FONTSET_OBJLIST): Remove.
12404 (free_realized_fontset) #if-0 the body, which does nothing.
12405 (face_suitable_for_char_p): #if-0, as it's never called.
12406 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12407 * xfaces.c (face_at_string_position):
12408 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12409 since 0 is always ASCII.
12410
dfcf3579
PE
12411 * fns.c (weak_hash_tables): Now static.
12412
5045092b
PE
12413 * fileio.c: Make symbols static if they're not exported.
12414 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12415 (Vwrite_region_annotation_buffers): Now static.
12416
57a96f5c
PE
12417 * eval.c: Make symbols static if they're not exported.
12418 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12419 * lisp.h (backtrace_list): Remove decl.
12420
35f08c38
PE
12421 * emacs.c: Make symbols static if they're not exported.
12422 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12423 (fatal_error_code, fatal_error_signal_hook, standard_args):
12424 Now static.
12425 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12426 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12427 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12428 * lisp.h (fatal_error_signal_hook): Remove decl.
12429 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12430
f44bd759
PE
12431 * editfns.c: Move a (normally-unused) function to its only use.
12432 * editfns.c, lisp.h (get_operating_system_release): Remove.
12433 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12434 worth the hassle of breaking this out.
12435
b532497d
PE
12436 * xterm.c: Make symbols static if they're not exported.
12437 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12438 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12439 (x_destroy_window, x_delete_display):
12440 Now static.
12441 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12442 (x_mouse_leave): Remove; unused.
12443 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12444 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12445 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12446 Remove decls.
12447 (x_mouse_leave): Declare only if WINDOWSNT.
12448 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12449 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12450 USE_X_TOOLKIT.
12451
1675728f
PE
12452 * ftxfont.c: Make symbols static if they're not exported.
12453 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12454 HAVE_FREETYPE.
12455 * font.h (ftxfont_driver): Likewise.
12456
e4cebfca
PE
12457 * xfns.c: Make symbols static if they're not exported.
12458 (x_last_font_name, x_display_info_for_name):
12459 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12460 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12461 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12462 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12463 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12464 (last_show_tip_args): Now static.
12465 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12466 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12467 (x_screen_planes): Remove; unused.
12468 * dispextern.h (x_screen_planes): Remove decl.
12469
5bf46f05
PE
12470 * dispnew.c: Make symbols static if they're not exported.
12471 * dispextern.h (redraw_garbaged_frames, scrolling):
12472 (increment_row_positions): Remove.
12473 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12474 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12475 Now static.
12476 (redraw_garbaged_frames): Remove; unused.
12477
435f4c28
PE
12478 * xfaces.c: Make symbols static if they're not exported.
12479 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12480 Remove decls.
12481 * xterm.h (defined_color): Remove decls.
12482 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12483 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12484 (menu_face_changed_default, defined_color, free_realized_face):
12485 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12486 (ascii_face_of_lisp_face): Remove; unused.
12487
8524aef3
PE
12488 * xdisp.c: Make symbols static if they're not exported.
12489 * dispextern.h (scratch_glyph_row, window_box_edges):
12490 (glyph_to_pixel_coords, set_cursor_from_row):
12491 (get_next_display_element, set_iterator_to_next):
12492 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12493 (show_mouse_face): Remove decls
12494 * frame.h (message_buf_print): Likewise.
12495 * lisp.h (pop_message, set_message, check_point_in_composition):
12496 Likewise.
12497 * xterm.h (set_vertical_scroll_bar): Likewise.
12498 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12499 (message_buf_print, scratch_glyph_row, displayed_buffer):
12500 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12501 (get_next_display_element, show_mouse_face, window_box_edges):
12502 (frame_to_window_pixel_xy, check_point_in_composition):
12503 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12504 (glyph_to_pixel_coords): Remove; unused.
12505
16390cd2
PE
12506 * dired.c (file_name_completion): Now static.
12507
12508 * dbusbind.c (xd_in_read_queued_messages): Now static.
12509
a25f4dfa
PE
12510 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12511 * data.c (circular_list_error): Remove.
12512
14a9c8df
PE
12513 * commands.h (last_point_position, last_point_position_buffer):
12514 (last_point_position_window): Remove decls.
12515 * keyboard.c: Make these variables static.
12516
04f2d78b
CB
12517 * coding.h (coding, code_convert_region, encode_coding_gap):
12518 Remove decls.
74ab6df5
PE
12519 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12520 (iso_code_class, detect_coding, code_convert_region): Now static.
12521 (encode_coding_gap): Remove; unused.
12522
38dfbee1
PE
12523 * chartab.c (chartab_chars, chartab_bits): Now static.
12524
a2cb4e63
PE
12525 * charset.h (charset_iso_8859_1): Remove decl.
12526 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12527 Now static.
12528
127198fd
PE
12529 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12530 * ccl.c (Vccl_program_table): Now static.
12531 (check_ccl_update): Remove; unused.
12532
d85b608f
PE
12533 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12534 * category.h: ... from here.
12535 * category.c (check_category_table, set_category_set): Now static.
12536
31cd66f3
PE
12537 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12538 * lisp.h: Remove these decls.
12539
c358e587
PE
12540 * buffer.c (buffer_count): Remove unused var.
12541
e78aecca
PE
12542 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12543 so that it's not optimized away.
12544 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12545 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12546 exported only to the debugger.
12547
e192d7d3 12548 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12549 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12550
92470028
PE
12551 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12552 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12553 was inaccessible from Lisp.
12554 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12555 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12556
244ed907
PE
12557 alloc.c: Import and export fewer symbols, and remove unused items.
12558 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12559 is defined.
12560 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12561 it's not optimized away by whole-program optimization.
12562 (message_enable_multibyte, free_misc): Remove.
12563 (catchlist, handlerlist, mark_backtrace):
12564 Declare only if BYTE_MARK_STACK.
12565 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12566 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12567 (message_enable_multibyte): Remove decl.
12568 (free_misc, interval_free_list, float_block, float_block_index):
12569 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12570 (cons_free_list, last_marked_index):
12571 Now static.
12572 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12573 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12574 (mark_backtrace): Define only if BYTE_MARK_STACK.
12575 * xdisp.c (message_enable_multibyte): Now static.
12576
61c2b50e 12577 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12578 This makes it easier for human readers (and static analyzers)
12579 to see whether these variables are used from other modules.
12580 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12581 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12582 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12583 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12584 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12585 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12586 * xmenu.c, xselect.c:
12587 Declare Q* vars static if they are not used in other modules.
12588 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12589 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12590 Remove decls of unexported vars.
12591 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12592
95c82688
PE
12593 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12594
16a97296
PE
12595 Make Emacs functions such as Fatom 'static' by default.
12596 This makes it easier for human readers (and static analyzers)
12597 to see whether these functions can be called from other modules.
12598 DEFUN now defines a static function. To make the function external
12599 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12600 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12601 (Finit_image_library):
16a97296
PE
12602 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12603 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12604 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12605 Remove decls, since these functions are now static.
12606 (Funintern, Fget_internal_run_time): New decls, since these functions
12607 were already external.
95c82688 12608
16a97296
PE
12609 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12610 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12611 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12612 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12613 * keyboard.c, keymap.c, lread.c:
12614 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12615 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12616 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12617 Mark functions with DEFUE instead of DEFUN,
12618 if they are used in other modules.
12619 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12620 decls for now-static functions.
12621 * buffer.h (Fdelete_overlay): Remove decl.
12622 * callproc.c (Fgetenv_internal): Mark as internal.
12623 * composite.c (Fremove_list_of_text_properties): Remove decl.
12624 (Fcomposition_get_gstring): New forward static decl.
12625 * composite.h (Fcomposite_get_gstring): Remove decl.
12626 * dired.c (Ffile_attributes): New forward static decl.
12627 * doc.c (Fdocumntation_property): New forward static decl.
12628 * eval.c (Ffetch_bytecode): New forward static decl.
12629 (Funintern): Remove extern decl; now in .h file where it belongs.
12630 * fileio.c (Fmake_symbolic_link): New forward static decl.
12631 * image.c (Finit_image_library): New forward static decl.
12632 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12633 * intervals.h (Fprevious_property_change):
12634 (Fremove_list_of_text_properties): Remove decls.
12635 * keyboard.c (Fthis_command_keys): Remove decl.
12636 (Fcommand_execute): New forward static decl.
12637 * keymap.c (Flookup_key): New forward static decl.
12638 (Fcopy_keymap): Now static.
12639 * keymap.h (Flookup_key): Remove decl.
12640 * process.c (Fget_process): New forward static decl.
12641 (Fprocess_datagram_address): Mark as internal.
12642 * syntax.c (Fsyntax_table_p): New forward static decl.
12643 (skip_chars): Remove duplicate decl.
12644 * textprop.c (Fprevious_property_change): New forward static decl.
12645 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12646 Now internal.
12647 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12648 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12649
785bbd42
PE
12650 * editfns.c (Fformat): Remove unreachable code.
12651
8b913b57
AS
126522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12653
12654 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12655 change. (Bug#8496)
12656
a6744a35
EZ
126572011-04-13 Eli Zaretskii <eliz@gnu.org>
12658
12659 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12660 when at ZV. (Bug#8487)
12661
e7974947
AS
126622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12663
baad03f0
AS
12664 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12665 (Bug#8437)
12666 * keyboard.c (parse_tool_bar_item): Likewise.
12667 * sound.c (sound_cleanup, alsa_close): Likewise.
12668 * termcap.c (tgetent): Likewise.
12669 * xfns.c (x_default_font_parameter): Likewise.
12670 * xsettings.c (read_and_apply_settings): Likewise.
12671
e7974947
AS
12672 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12673 (overrun_check_free): Protoize.
12674
28272684
PE
126752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12676
12677 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12678 since callers should never pass a negative size.
12679 Change the signature to match that of plain 'read' and 'write'; see
12680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12681 * lisp.h: Update prototypes of emacs_write and emacs_read.
12682
11997c76
EZ
126832011-04-11 Eli Zaretskii <eliz@gnu.org>
12684
12685 * xdisp.c (redisplay_window): Don't try to determine the character
12686 position of the scroll margin if the window start point w->startp
e896f03c 12687 is outside the buffer's accessible region. (Bug#8468)
11997c76 12688
8a2cbd72
EZ
126892011-04-10 Eli Zaretskii <eliz@gnu.org>
12690
12691 Fix write-region and its subroutines for buffers > 2GB.
12692 * fileio.c (a_write, e_write): Modify declaration of arguments and
12693 local variables to support buffers larger than 2GB.
12694 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12695
12696 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12697 argument, local variables, and return value.
12698
12699 * lisp.h: Update prototypes of emacs_write and emacs_read.
12700
12701 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12702
4073e537 127032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12704
1ebfdcb6
PE
12705 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12706
b2ded58d
PE
12707 Fix more problems found by GCC 4.6.0's static checks.
12708
7d66342c
PE
12709 * xdisp.c (vmessage): Use a better test for character truncation.
12710
bbf47d44
PE
12711 * charset.c (load_charset_map): <, not <=, for optimization,
12712 and to avoid potential problems with integer overflow.
9248994d 12713 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12714 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12715 * editfns.c (Fformat): Likewise.
1e69125e 12716 * syntax.c (skip_chars): Likewise.
3befa583 12717
e3019616
PE
12718 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12719 This also lets GCC 4.6.0 generate slightly better loop code.
12720
becfa255
PE
12721 * callint.c (Fcall_interactively): <, not <=, for optimization.
12722 (Fcall_interactively): Count the number of arguments produced,
12723 not the number of arguments given. This is simpler and lets GCC
12724 4.6.0 generate slightly better code.
12725
dae0cd48
PE
12726 * ftfont.c: Distingish more carefully between FcChar8 and char.
12727 The previous code passed unsigned char * to a functions like
12728 strlen and xstrcasecmp that expect char *, which does not
12729 conform to the C standard.
12730 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12731 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12732 char * when the C standard requires it.
12733
76032d70
PE
12734 * keyboard.c (read_char): Remove unused var.
12735
eb3f1cc8
PE
12736 * eval.c: Port to Windows vsnprintf (Bug#8435).
12737 Include <limits.h>.
12738 (SIZE_MAX): Define if the headers do not.
12739 (verror): Do not give up if vsnprintf returns a negative count.
12740 Instead, grow the buffer. This ports to Windows vsnprintf, which
12741 does not conform to C99. Problem reported by Eli Zaretskii.
12742 Also, simplify the allocation scheme, by avoiding the need for
12743 calling realloc, and removing the ALLOCATED variable.
12744
70476b54
PE
12745 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12746
12020a9e
PE
12747 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12748 But keep the doprint source code for now, as we might revamp it
12749 and use it again (Bug#8435).
ea6c7ae6
PE
12750 * lisp.h (doprnt): Remove.
12751 * Makefile.in (base_obj): Remove doprnt.o.
12752 * deps.mk (doprnt.o): Remove.
12753
5fdb398c
PE
12754 error: Print 32- and 64-bit integers portably (Bug#8435).
12755 Without this change, on typical 64-bit hosts error ("...%d...", N)
12756 was used to print both 32- and 64-bit integers N, which relied on
12757 undefined behavior.
61bdb816 12758 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12759 * lisp.h (error, verror): Mark as printf-like functions.
12760 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12761 Report overflow in size calculations when allocating printf buffer.
12762 Do not truncate output string at its first null byte.
12763 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12764 Truncate the output at a character boundary, since vsnprintf does not
12765 do that.
12766 * charset.c (check_iso_charset_parameter): Convert internal
12767 character to string before calling 'error', since %c now has the
12768 printf meaning.
12769 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12770 overflow when computing char to be passed to 'error'. Do not
12771 pass Lisp_Object to 'error'; pass the integer instead.
12772 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12773 formatted with plain %d.
12774
b189fa66
PE
12775 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12776
bff87ef0
PE
12777 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12778
7e2cac20
PE
12779 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12780
ce4d90b5
PE
12781 * xterm.c (x_catch_errors): Remove duplicate declaration.
12782
266c9547
PE
12783 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12784
79c49ad2
PE
12785 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12786
368f4090
JM
127872011-04-10 Jim Meyering <meyering@redhat.com>
12788
12789 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12790 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12791 return ssize_t not "int", and use size_t as the buffer length.
12792 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12793 * gnutls.h: Update declarations.
12794 * process.c (read_process_output): Use ssize_t, to match.
12795 (send_process): Likewise.
12796
a32d4040
CY
127972011-04-09 Chong Yidong <cyd@stupidchicken.com>
12798
12799 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12800
8546720e 128012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12802
04f2d78b
CB
12803 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12804 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12805
8546720e
GM
12806 * xterm.c (handle_one_xevent):
12807 * xmenu.c (create_and_show_popup_menu):
12808 * xselect.c (x_decline_selection_request)
12809 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12810
0a2f5c1a 128112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12812
12813 Fix some uses of `int' instead of EMACS_INT.
12814 * search.c (string_match_1, fast_string_match)
12815 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12816 (scan_buffer, find_next_newline_no_quit)
12817 (find_before_next_newline, search_command, Freplace_match)
12818 (Fmatch_data): Make some `int' variables be EMACS_INT.
12819
12820 * xdisp.c (display_count_lines): 3rd argument and return value now
12821 EMACS_INT. All callers changed.
12822 (pint2hrstr): Last argument is now EMACS_INT.
12823
12824 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12825 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12826 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12827 (decode_coding_utf_16, decode_coding_emacs_mule)
12828 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12829 (decode_coding_ccl, decode_coding_charset)
12830 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12831 (decode_coding_iso_2022, decode_coding_emacs_mule)
12832 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12833 <char_offset, last_offset>: Declare EMACS_INT.
12834 (encode_coding_utf_8, encode_coding_utf_16)
12835 (encode_coding_emacs_mule, encode_invocation_designation)
12836 (encode_designation_at_bol, encode_coding_iso_2022)
12837 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12838 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12839 Declare EMACS_INT.
12840 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12841 (encode_invocation_designation): Last argument P_NCHARS is now
12842 EMACS_INT.
12843 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12844 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12845
12846 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12847 All users changed.
12848
12849 * ccl.c (Fccl_execute_on_string): Declare some variables
12850 EMACS_INT.
12851
8546720e 128522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12853
12854 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12855
4e19a977
CS
128562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12857
12858 * process.c (Fformat_network_address): Doc fix.
12859
87302331
R
128602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12861
ee7683eb 12862 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12863
cbb59342
CY
128642011-04-08 Chong Yidong <cyd@stupidchicken.com>
12865
12866 * keyboard.c (read_char): Call Lisp function help-form-show,
12867 instead of using internal_with_output_to_temp_buffer.
12868 (Qhelp_form_show): New var.
e0d38eeb 12869 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12870
12871 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12872
12873 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12874
e67a13ab
CY
128752011-04-06 Chong Yidong <cyd@stupidchicken.com>
12876
04f2d78b
CB
12877 * process.c (Flist_processes): Remove to Lisp.
12878 (list_processes_1): Delete.
e67a13ab 12879
973f782d
EZ
128802011-04-06 Eli Zaretskii <eliz@gnu.org>
12881
7c106b1e
EZ
12882 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12883
973f782d
EZ
12884 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12885
41cf7d1a 128862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12887
ca23cc88
PE
12888 Fix more problems found by GCC 4.6.0's static checks.
12889
f390e2d5
PE
12890 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12891
42eea0d0
PE
12892 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12893
b69769da 12894 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12895
f9541e84
PE
12896 * xdisp.c (vmessage): Mark as a printf-like function.
12897
13841b55
PE
12898 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12899
c136c10f
PE
12900 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12901
5e2d4a30
PE
12902 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12903 printf-like functions.
12904 (tiff_load): Add casts to remove these marks before passing them
12905 to system-supplied API.
12906
583f48b9
PE
12907 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12908
b25d760e
PE
12909 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12910 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12911 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12912 directly, rather than having caller test rule sign. This avoids
12913 some unnecessary tests.
12914 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12915 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12916 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12917
bc7b6697 12918 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12919 (xfont_open): Avoid unnecessary tests.
bc7b6697 12920
27ccc379
PE
12921 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12922
dcd5c89a
PE
12923 * composite.h, composite.c (composition_gstring_put_cache):
12924 Use EMACS_INT, not int, for length.
12925
b13a45c6
PE
12926 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12927 breaking out part of COMPOSITION_DECODE_RULE.
12928 (COMPOSITION_DECODE_RULE): Use it.
12929 * composite.c (get_composition_id): Remove unused local vars,
12930 by using the new macro.
12931
1e792e4d
PE
12932 * textprop.c (set_text_properties_1): Change while to do-while,
12933 since the condition is always true at first.
12934
dc6c6455 12935 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12936 (interval_deletion_adjustment): Return unsigned value.
12937 All uses changed.
dc6c6455 12938
aba7731a
PE
12939 * process.c (list_processes_1, create_pty, read_process_output):
12940 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12941 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12942 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12943 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12944 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12945
fdfc4bf3
PE
12946 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12947
fca8fe46 12948 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12949 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12950
06a0259a 12951 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12952 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12953 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12954
e7b9e80f
PE
12955 * print.c (print_error_message): Avoid int overflow.
12956
56201685
PE
12957 * font.c (font_list_entities): Redo for clarity,
12958 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12959
78834453 12960 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12961 (font_score): Avoid potential overflow in diff calculation.
78834453 12962
0bc0b309 12963 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12964 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12965
e610eaca
PE
12966 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12967
b895abce
PE
12968 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12969 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12970 can always succeed if overflow has undefined behavior.
12971
1f1d9321 12972 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12973 (wordify): Omit three unnecessary tests.
1f1d9321 12974
c59478bc
PE
12975 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12976 All callers changed. This avoids the need for an unused var.
12977
79b73827
PE
12978 * casefiddle.c (casify_region): Remove var that is set but not used.
12979
a4db5dfe
PE
12980 * dired.c (file_name_completion): Remove var that is set but not used.
12981
43aae36e
PE
12982 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12983
2a47c44d 12984 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12985 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12986
a37c69bf
PE
12987 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12988 Check for integer overflow on size calculations.
12989
328ab8e7
PE
12990 * buffer.c (Fprevious_overlay_change): Remove var that is set
12991 but not used.
12992
e5a2a5cb
PE
12993 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12994 Remove vars that are set but not used.
8d84a6eb 12995 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12996 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12997
a60e5f68
PE
12998 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12999
f661cb61 13000 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13001 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13002
f0397f5a
PE
13003 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13004 that are set but not used.
13005
8664db06 13006 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13007 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13008
6abdaa4a
PE
13009 * xselect.c (x_get_local_selection, x_handle_property_notify):
13010 Remove vars that are set but not used.
13011
0ce7538d 13012 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13013 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13014
9ae848fc
PE
13015 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13016 Remove var that is set but not used.
0b918413
PE
13017 (scroll_bar_windows_size): Now size_t, not int.
13018 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13019 Check for overflow.
9ae848fc 13020
a5a62657
PE
13021 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13022 (map_tty_color) [!defined MSDOS]: Likewise.
13023
5c5cdd39
PE
13024 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13025
66ebf983
PE
13026 * coding.c: Remove vars that are set but not used.
13027 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13028 All callers changed.
13029 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13030 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13031 (decode_coding_charset): Remove vars that are set but not used.
13032
1be4d761
PE
13033 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13034 that is set but not used.
13035
47553fa8
PE
13036 * print.c (print_object): Remove var that is set but not used.
13037
1f7196bf 13038 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13039 The gnulib version avoids calling malloc in the usual case,
13040 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13041 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13042 * filelock.c (current_lock_owner): Likewise.
13043 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13044 * sysdep.c: Include allocator.h, careadlinkat.h.
13045 (emacs_no_realloc_allocator): New static constant.
13046 (emacs_readlink): New function.
fdb61804
PE
13047 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13048 ../lib/careadlinkat.h.
d1fdcab7 13049
f84c17c7
SM
130502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13051
13052 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13053 first non-nil return value).
13054
ef3862ad
JD
130552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13056
13057 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13058 if not defined (Bug#8403).
13059
376a7006
JB
130602011-04-02 Juanma Barranquero <lekktu@gmail.com>
13061
13062 * xdisp.c (display_count_lines): Remove parameter `start',
13063 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13064 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13065 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13066 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13067 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13068 and thereabouts. All callers changed.
13069 (get_per_char_metric): Remove parameter `f', unused since
13070 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13071
6ca3801d
JM
130722011-04-02 Jim Meyering <meyering@redhat.com>
13073
13074 do not dereference NULL upon failed strdup
13075 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13076 (ns_get_family): Likewise.
13077
d8e2b5ba
JB
130782011-04-02 Juanma Barranquero <lekktu@gmail.com>
13079
13080 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13081
8c74fcbd
JD
130822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13083
13084 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13085 later (Bug#8403).
13086
7200d79c
SM
130872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13088
03408648 13089 Add lexical binding.
7200d79c 13090
03408648
SM
13091 * window.c (Ftemp_output_buffer_show): New fun.
13092 (Fsave_window_excursion):
13093 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13094
13095 * lread.c (lisp_file_lexically_bound_p): New function.
13096 (Fload): Bind Qlexical_binding.
13097 (readevalloop): Remove `evalfun' arg.
13098 Bind Qinternal_interpreter_environment.
13099 (Feval_buffer): Bind Qlexical_binding.
13100 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13101 Mark as dynamic.
13102 (syms_of_lread): Declare `lexical-binding'.
13103
13104 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13105
13106 * keyboard.c (eval_dyn): New fun.
13107 (menu_item_eval_property): Use it.
ca105506
SM
13108
13109 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13110
03408648
SM
13111 * fns.c (concat, mapcar1): Accept byte-code-functions.
13112
13113 * eval.c (Fsetq): Handle lexical vars.
13114 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13115 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13116 (FletX, Flet): Obey lexical binding.
13117 (Fcommandp): Handle closures.
13118 (Feval): New `lexical' arg.
13119 (eval_sub): New function extracted from Feval. Use it almost
13120 everywhere where Feval was used. Look up vars in lexical env.
13121 Handle closures.
13122 (Ffunctionp): Move from subr.el.
13123 (Ffuncall): Handle closures.
13124 (apply_lambda): Remove `eval_flags'.
13125 (funcall_lambda): Handle closures and new byte-code-functions.
13126 (Fspecial_variable_p): New function.
13127 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13128 but without exporting it to Lisp.
23aba0ea 13129
23aba0ea 13130 * doc.c (Fdocumentation, store_function_docstring):
03408648 13131 * data.c (Finteractive_form): Handle closures.
23aba0ea 13132
03408648
SM
13133 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13134 interactive spec.
ba83908c 13135
04f2d78b
CB
13136 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13137 New byte-codes.
03408648
SM
13138 (exec_byte_code): New function extracted from Fbyte_code to handle new
13139 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13140
03408648 13141 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13142
03408648 13143 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13144
e2abce01
JB
131452011-03-31 Juanma Barranquero <lekktu@gmail.com>
13146
13147 * xdisp.c (redisplay_internal): Fix prototype.
13148
63696a73 131492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13150
63696a73 13151 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13152 (try_scrolling): Use it when setting scroll_limit.
13153 Limit scrolling to 100 screen lines.
63696a73
EZ
13154 (redisplay_window): Even when falling back on "recentering",
13155 position point in the window according to scroll-conservatively,
13156 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13157
13158 (try_scrolling): When point is above the window, allow searching
13159 as far as scroll_max, or one screenful, to compute vertical
13160 distance from PT to the scroll margin position. This prevents
13161 try_scrolling from unnecessarily failing when
13162 scroll-conservatively is set to a value slightly larger than the
13163 window height. Clean up the case of PT below the margin at bottom
13164 of window: scroll_max can no longer be INT_MAX. When aggressive
13165 scrolling is in use, don't let point enter the opposite scroll
13166 margin as result of the scroll.
13167 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13168 threshold of 100 lines for never-recentering scrolling.
13169
e4cc2dfc
JB
131702011-03-31 Juanma Barranquero <lekktu@gmail.com>
13171
13172 * dispextern.h (move_it_by_lines):
13173 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13174 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13175 (message_log_check_duplicate): Remove parameters `prev_bol' and
13176 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13177 (redisplay_internal): Remove parameter `preserve_echo_area',
13178 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13179
13180 * indent.c (Fvertical_motion):
13181 * window.c (window_scroll_pixel_based, Frecenter):
13182 Don't pass `need_y_p' to `move_it_by_lines'.
13183
1c470562
SM
131842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13185
44f230aa
SM
13186 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13187 steal a few bits to be more compact.
13188 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13189 Remove unneeded casts.
13190
1c470562
SM
13191 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13192
888adce9
ZK
131932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13194
13195 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13196 binding" message (bug#7967).
13197
f838ed7b
PE
131982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13199
77861b95
PE
13200 Fix more problems found by GCC 4.6.0's static checks.
13201
de6dbc14
PE
13202 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13203 Remove unused local var.
13204
f838ed7b
PE
13205 * editfns.c (Fmessage_box): Remove unused local var.
13206
792c7b2b
PE
13207 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13208 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13209 Omit unused local vars.
c499e557 13210 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13211 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13212 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13213 Omit unused local var.
13214
ba0165e1
PE
13215 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13216 Don't assume string length fits in int.
32ad8845 13217 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13218 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13219
3c59b4c9
PE
13220 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13221 instead of alloca (Bug#8344).
13222
a3eed478 13223 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13224 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13225
eb4d412d
PE
13226 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13227
1658b401
PE
13228 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13229 concerns.
13230
13231 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13232
13233 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13234
9a2c6e05
PE
13235 * keyboard.c (syms_of_keyboard): Use the same style as later
13236 in this function when indexing through an array. This also
13237 works around GCC bug 48267.
13238
03d0a109
PE
13239 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13240
44f730c8
PE
13241 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13242
fe75f926
PE
13243 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13244 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13245
ffa8c828
PE
13246 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13247 This avoids undefined behavior on integer overflow, and is a bit
13248 more convenient anyway since it is compared to a size_t variable.
13249
c5101a77
PE
13250 Variadic C functions now count arguments with size_t, not int.
13251 This avoids an unnecessary limitation on 64-bit machines, which
13252 caused (substring ...) to crash on large vectors (Bug#8344).
13253 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13254 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13255 All variadic functions and their callers changed accordingly.
c5101a77
PE
13256 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13257 * data.c (arith_driver, float_arith_driver): Likewise.
13258 * editfns.c (general_insert_function): Likewise.
13259 * eval.c (struct backtrace.nargs, interactive_p)
13260 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13261 (funcall_lambda, mark_backtrace): Likewise.
13262 * fns.c (concat): Likewise.
13263 * frame.c (x_set_frame_parameters): Likewise.
13264 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13265 0 if not found, not -1. All callers changed.
13266
dd3f25f7
PE
13267 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13268 (stack_copy_size): Now size_t, not int.
13269 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13270
461c2ab9
JB
132712011-03-28 Juanma Barranquero <lekktu@gmail.com>
13272
13273 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13274 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13275 All callers changed.
13276
13277 * lisp.h (multibyte_char_to_unibyte):
13278 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13279 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13280 * character.h (CHAR_TO_BYTE8):
13281 * cmds.c (internal_self_insert):
13282 * editfns.c (general_insert_function):
13283 * keymap.c (push_key_description):
13284 * search.c (Freplace_match):
13285 * xdisp.c (message_dolog, set_message_1): All callers changed.
13286
f6d62986
SM
132872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13288
13289 * keyboard.c (safe_run_hook_funcall): New function.
13290 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13291 don't set the hook to nil, but remove the offending function instead.
13292 (Qcommand_hook_internal): Remove, unused.
13293 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13294 Vcommand_hook_internal.
13295
13296 * eval.c (enum run_hooks_condition): Remove.
13297 (funcall_nil, funcall_not): New functions.
13298 (run_hook_with_args): Call each function through a `funcall' argument.
13299 Remove `cond' argument, now redundant.
13300 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13301 (Frun_hook_with_args_until_failure): Adjust accordingly.
13302 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13303
1db5b1ad
JB
133042011-03-28 Juanma Barranquero <lekktu@gmail.com>
13305
13306 * dispextern.h (string_buffer_position): Remove declaration.
13307
13308 * print.c (strout): Remove parameter `multibyte', unused since
13309 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13310
13311 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13312 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13313 All callers changed.
13314
13315 * w32.c (_wsa_errlist): Use braces for struct initializers.
13316
13317 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13318 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13319 All callers changed.
13320 (string_buffer_position): Likewise. Also, make static (it's never
13321 used outside xdisp.c).
13322 (cursor_row_p): Remove parameter `w', unused since
13323 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13324 (decode_mode_spec): Remove parameter `precision', introduced during
13325 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13326 All callers changed.
13327
5ffb62aa
JD
133282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13329
13330 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13331
461c2ab9 133322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13333
13334 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13335 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13336 (ns_update_auto_hide_menu_bar): New functions.
13337 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13338 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13339 ns_constrain_all_frames.
13340 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13341 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13342
5c380ffb
JD
133432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13344
13345 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13346
9af30bdf
GM
133472011-03-27 Glenn Morris <rgm@gnu.org>
13348
13349 * syssignal.h: Replace RETSIGTYPE with void.
13350 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13351 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13352 Replace SIGTYPE with void everywhere.
13353 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13354 * s/template.h (SIGTYPE): Remove commented out definition.
13355
e2abce01
JB
133562011-03-26 Eli Zaretskii <eliz@gnu.org>
13357
13358 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13359 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13360
f868cd8a
JB
133612011-03-26 Juanma Barranquero <lekktu@gmail.com>
13362
59eb0929
JB
13363 * w32.c (read_unc_volume): Use parameter `henum', instead of
13364 global variable `wget_enum_handle'.
13365
13366 * keymap.c (describe_vector): Remove parameters `indices' and
13367 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13368 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13369
f868cd8a
JB
13370 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13371
13372 * keyboard.c (timer_check): Remove parameter `do_it_now',
13373 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13374 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13375 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13376
13377 * keyboard.c (read_char):
13378 * w32menu.c (w32_menu_display_help):
13379 * xmenu.c (show_help_event, menu_help_callback):
13380 Adjust calls to `show_help_echo'.
13381
13382 * gtkutil.c (xg_maybe_add_timer):
13383 * keyboard.c (readable_events):
13384 * process.c (wait_reading_process_output):
13385 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13386
13387 * insdel.c (adjust_markers_gap_motion):
13388 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13389 (gap_left, gap_right): Don't call it.
13390
2ecf6fdb
CY
133912011-03-25 Chong Yidong <cyd@stupidchicken.com>
13392
13393 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13394 incurred during fontification.
13395
6b1f9ba4
JB
133962011-03-25 Juanma Barranquero <lekktu@gmail.com>
13397
13398 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13399 (DEFVAR_PER_BUFFER): Don't pass it.
13400
13401 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13402 (scrolling_window): Don't pass it.
13403
0f4a96b5
JB
134042011-03-25 Juanma Barranquero <lekktu@gmail.com>
13405
13406 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13407
13408 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13409 and `suffix'.
13410 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13411 of variables specific to SELinux and computation of `encoded_absname'.
13412
13413 * image.c (XPutPixel): Remove unused variable `height'.
13414
13415 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13416
13417 * unexw32.c (get_section_info): Remove unused variable `section'.
13418
13419 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13420 (system_process_attributes): Remove unused variable `sess'.
13421 (sys_read): Remove unused variable `err'.
13422
13423 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13424 (w32_wnd_proc): Remove unused variable `isdead'.
13425 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13426 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13427 (x_create_tip_frame): Remove unused variable `tem'.
13428
13429 * w32inevt.c (w32_console_read_socket):
13430 Remove unused variable `no_events'.
13431
13432 * w32term.c (x_draw_composite_glyph_string_foreground):
13433 Remove unused variable `width'.
13434
1149507c
JB
134352011-03-24 Juanma Barranquero <lekktu@gmail.com>
13436
13437 * w32term.c (x_set_glyph_string_clipping):
13438 Don't pass uninitialized region to CombineRgn.
13439
9c88f339
JB
134402011-03-23 Juanma Barranquero <lekktu@gmail.com>
13441
13442 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13443 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13444 (Fx_close_connection): Remove unused variable `i'.
13445
13446 * w32font.c (w32font_draw): Return number of glyphs.
13447 (w32font_open_internal): Remove unused variable `i'.
13448 (w32font_driver): Add missing initializer.
13449
13450 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13451 (fill_in_menu): Remove unused variable `items_added'.
13452
13453 * w32term.c (last_mouse_press_frame): Remove static global variable.
13454 (w32_clip_to_row): Remove unused variable `f'.
13455 (x_delete_terminal): Remove unused variable `i'.
13456
13457 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13458 (NOTHING): Remove unused static global variable.
13459 (uniscribe_check_otf): Remove unused variable `table'.
13460 (uniscribe_font_driver): Add missing initializers.
13461
dee091a3
JD
134622011-03-23 Julien Danjou <julien@danjou.info>
13463
13464 * term.c (Fsuspend_tty, Fresume_tty):
13465 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13466 * window.c (temp_output_buffer_show):
13467 * insdel.c (signal_before_change):
13468 * frame.c (Fhandle_switch_frame):
13469 * fileio.c (Fdo_auto_save):
13470 * emacs.c (Fkill_emacs):
13471 * editfns.c (save_excursion_restore):
13472 * cmds.c (internal_self_insert):
13473 * callint.c (Fcall_interactively):
13474 * buffer.c (Fkill_all_local_variables):
13475 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13476 Use Frun_hooks.
0f4a96b5 13477 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13478 unconditionally since it does the check itself.
dee091a3 13479
2c520ab5 134802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13481
c9c49752
PE
13482 Fix more problems found by GCC 4.5.2's static checks.
13483
8abc3f12
PE
13484 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13485 the first time through the loop, since we know p0 < p1 then.
13486 This also avoids a gcc -Wstrict-overflow warning.
13487
a2d26660
PE
13488 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13489 leading to a memory leak, possible in functions like
13490 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13491 of objects (Bug#8318).
a2d26660 13492
916c72e9
PE
13493 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13494 that could (at least in theory) be that large.
13495
19ab8a18
PE
13496 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13497 This is less likely to overflow, and avoids undefined behavior if
13498 overflow does occur. All callers changed. Use strtoul to scan
13499 for the unsigned long integer.
b7cbbd6f
PE
13500 (pint2hrstr): Simplify and tune code slightly.
13501 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13502
f0641eff
PE
13503 * scroll.c (do_scrolling): Work around GCC bug 48228.
13504 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13505
7f650bb9
PE
13506 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13507 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13508 (validate_x_resource_name): Simplify count usage.
13509 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13510
37dd57d1
PE
13511 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13512 fail (Bug#8306).
81e56e61 13513
699979fc 13514 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13515
401bf9b4
PE
13516 * process.c (Fmake_network_process): Use socklen_t, not int,
13517 where POSIX says socklen_t is required in portable programs.
13518 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13519 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13520 (Fmake_network_process, server_accept_connection):
13521 (wait_reading_process_output, read_process_output):
13522 Likewise.
13523
b93aacde
PE
13524 * process.c: Rename or move locals to avoid shadowing.
13525 (list_processes_1, Fmake_network_process):
13526 (read_process_output_error_handler, exec_sentinel_error_handler):
13527 Rename or move locals.
4dc343ee 13528 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13529 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13530 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13531 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13532 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13533
af8a867c 13534 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13535 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13536 Include tparam.h instead, since it declares them.
af8a867c
PE
13537 * cm.h (PC): Remove extern decl; tparam.h now does this.
13538 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13539 * terminfo.c: Include tparam.h, to check interfaces.
13540 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13541 (tparam): Adjust signature to match interface in tparam.h;
13542 this removes some undefined behavior. Check that outstring and len
13543 are zero, which they always are with Emacs.
13544 * tparam.h (PC, BC, UP): New extern decls.
13545
0248044d 13546 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13547 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13548
8ff096c1 13549 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13550 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13551 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13552 (ftfont_list): Remove unused local.
49eaafba
PE
13553 (get_adstyle_property, ftfont_pattern_entity):
13554 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13555 Rename locals to avoid shadowing.
8ff096c1 13556
e2be39f6
PE
13557 * xfont.c (xfont_list_family): Mark var as initialized.
13558
c9735e30
PE
13559 * xml.c (make_dom): Now static.
13560
8f5201ae
PE
13561 * composite.c (composition_compute_stop_pos): Rename local to
13562 avoid shadowing.
b246f932
PE
13563 (composition_reseat_it): Remove unused locals.
13564 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13565 (composition_update_it): Mark var as initialized.
11b61122
PE
13566 (find_automatic_composition): Mark vars as initialized,
13567 with a FIXME (Bug#8290).
8f5201ae 13568
760fbc2c
PE
13569 character.h: Rename locals to avoid shadowing.
13570 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13571 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13572 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13573 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13574 to avoid shadowing.
13575
ff08eb85
PE
13576 * textprop.c (property_change_between_p): Remove; unused.
13577
fc7bf025
PE
13578 * intervals.c (interval_start_pos): Now static.
13579
235d7abc
PE
13580 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13581
44f230aa
SM
13582 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13583 Rename locals to avoid shadowing.
3e7d6594 13584
50060332
PE
13585 * sound.c (wav_play, au_play, Fplay_sound_internal):
13586 Fix pointer signedness.
d01f234b 13587 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13588 (wav_play): Initialize a variable to 0, to prevent undefined
13589 behavior (Bug#8278).
50060332 13590
c4fc4e30
PE
13591 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13592
918436ed
PE
13593 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13594
c939f91b
PE
13595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13596 clobbering (Bug#8298).
b9c7f648
PE
13597 * sysdep.c (sys_subshell): Likewise.
13598 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13599
6bd8c144
PE
13600 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13601 This should get cleaned up, so that child_setup has the
13602 same signature on all platforms.
13603
7710357c 13604 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13605 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13606
c59da222
CY
136072011-03-22 Chong Yidong <cyd@stupidchicken.com>
13608
13609 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13610 not to be necessary, and produces flickering.
13611
66b87493
GM
136122011-03-20 Glenn Morris <rgm@gnu.org>
13613
13614 * config.in: Remove file.
13615
45b6f6d5
JB
136162011-03-20 Juanma Barranquero <lekktu@gmail.com>
13617
13618 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13619 are now in src/globals.h.
13620 (syms_of_minibuf): Remove spurious & from previous change.
13621
cd394be1 136222011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13623
13624 * minibuf.c (completing-read-function): New variable.
13625 (completing-read-default): Rename from completing-read.
13626 (completing-read): Call completing-read-function.
13627
b14e3e21
CY
136282011-03-19 Juanma Barranquero <lekktu@gmail.com>
13629
13630 * xfaces.c (Fx_load_color_file):
13631 Read color file from absolute filename (bug#8250).
13632
f2b726e6
JB
136332011-03-19 Juanma Barranquero <lekktu@gmail.com>
13634
13635 * makefile.w32-in: Update dependencies.
13636
09f6ff02
EZ
136372011-03-17 Eli Zaretskii <eliz@gnu.org>
13638
13639 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13640
29a6015a
PE
136412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13642
a3a6c54e
PE
13643 Fix more problems found by GCC 4.5.2's static checks.
13644
b766f867
PE
13645 * process.c (make_serial_process_unwind, send_process_trap):
13646 (sigchld_handler): Now static.
13647
be02381c
PE
13648 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13649 That way, the code declares only the vars that it needs.
13650 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13651 * s/cygwin.h (PTY_ITERATION): Likewise.
13652 * s/darwin.h (PTY_ITERATION): Likewise.
13653 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13654
57048744
PE
13655 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13656 * process.c (allocate_pty): Don't declare stb unless it's needed.
13657
7914961c 13658 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13659 (CONSTANTLIM): Remove; unused.
13660 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13661 Define only if needed.
7914961c 13662
b3967b18
PE
13663 * unexelf.c (unexec): Name an expression,
13664 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13665 Use a different way to cause a compilation error if anyone uses
13666 n rather than nn, a way that does not involve shadowing.
73366a00 13667 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13668
29a6015a
PE
13669 * deps.mk (unexalpha.o): Remove; unused.
13670
43cfc33e 13671 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13672 * unexec.h: New file.
ce701a33
PE
13673 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13674 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13675 Depend on unexec.h.
13676 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13677 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13678 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13679 Change as necessary to match prototype in unexec.h.
ce701a33 13680
01f44d5a
PE
13681 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13682 shadowing.
4f63c6bb 13683 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13684
a6670b0b
PE
13685 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13686 Rename locals to avoid shadowing.
13687
cef2010d 13688 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13689 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13690
d4d7173a
PE
13691 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13692
f08b802a
PE
13693 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13694 warning when compiling print.c.
13695
3ddb0639
PE
13696 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13697 instead of using an uninitialized var.
5ad03b97 13698 (font_sort_entities): Mark var as initialized.
3ddb0639 13699
170a2692
PE
13700 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13701
e663c700
PE
13702 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13703 pointers to constants.
89bc529a 13704 (font_parse_fcname): Remove unused vars.
7b81e2d0 13705 (font_delete_unmatched): Now static.
ea838e10 13706 (font_get_spec): Remove; unused.
13a547c6
PE
13707 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13708 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13709 Rename or move locals to avoid shadowing.
e663c700 13710
2a80c887 13711 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13712 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13713
1384fa33 13714 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13715 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13716
8b2c52e9
PE
13717 * alloc.c (mark_backtrace): Move decl from here ...
13718 * lisp.h: ... to here, so that it can be checked.
13719
475545b5 13720 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13721 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13722 (lisp_indirect_variable): Name an expression,
13723 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13724 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13725
b1349114 13726 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13727 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13728 Use const pointer when appropriate.
b1349114 13729
a2928364
PE
13730 * lisp.h (get_system_name, get_operating_system_release):
13731 Move decls here, to check interfaces.
13732 * process.c (get_operating_system_release): Move decl to lisp.h.
13733 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13734 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13735 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13736 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13737 (Fformat_time_string, Fencode_time, Finsert_char):
13738 (Ftranslate_region_internal, Fformat):
13739 Rename or remove local vars to avoid shadowing.
9710023e 13740 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13741
a415e694
PE
13742 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13743 avoid shadowing.
13744
8ef4622d
PE
13745 * lisp.h (eassert): Check that the argument compiles, even if
13746 ENABLE_CHECKING is not defined.
13747
946f9a5b
PE
13748 * data.c (Findirect_variable): Name an expression, to avoid
13749 gcc -Wbad-function-cast warning.
112396d6 13750 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13751 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13752 (Fmake_variable_buffer_local, Fmake_local_variable):
13753 Mark variables as initialized.
52746918 13754 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13755
e5aab7e7 13756 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13757 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13758 Rename locals to avoid shadowing.
dff45157
PE
13759 (mark_stack): Move local variables into the #ifdef region where
13760 they're used.
7bc26fdb
PE
13761 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13762 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13763 needed otherwise.
13764 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13765 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13766 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13767
e5aab7e7
PE
13768 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13769 avoids undefined behavior in theory.
13770
4da60324
PE
13771 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13772
88043301
PE
13773 Use functions, not macros, for up- and down-casing (Bug#8254).
13774 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13775 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13776 to use the following functions instead of these macros.
13777 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13778 EMACS_INT, since callers assume the returned value fits in int.
13779 (upcase1): Likewise, for UPCASE_TABLE.
13780 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13781 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13782 the race-condition problem in the old DOWNCASE.
88043301 13783
19ed5445
PE
13784 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13785 Rename locals to avoid shadowing.
13786 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13787 (regex_compile, re_search_2, re_match_2_internal):
13788 Remove unused local vars.
952db0d7
PE
13789 (FREE_VAR): Rewrite so as not to use empty "else",
13790 which gcc can warn about.
da053e48 13791 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13792 (RETALLOC_IF): Define only if needed.
13793 (WORDCHAR_P): Likewise. This one is never needed, but is used
13794 only in a comment talking about a compiler bug, so put inside
13795 the #if 0 of that comment.
13796 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13797 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13798 Remove; unused.
19ed5445 13799
1f3561e4 13800 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13801 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13802 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13803
ded6f8f7
PE
13804 * search.c (simple_search): Remove unused var.
13805
dbd37a95
PE
13806 * dired.c (compile_pattern): Move decl from here ...
13807 * lisp.h: ... to here, so that it can be checked.
13808 (struct re_registers): New forward decl.
13809
7e47afad
PE
13810 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13811
85f24f61
PE
13812 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13813 All uses changed.
13814 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13815 Rename locals to avoid shadowing.
5671df8f 13816 (Fvertical_motion): Mark locals as initialized.
85f24f61 13817
181aa2be 13818 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13819 (casify_region): Mark local as initialized.
181aa2be 13820
930d429c
PE
13821 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13822
7082eac6
PE
13823 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13824 New macros, so that the caller can use some names other than
13825 gcpro1, gcpro2, etc.
13826 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13827 of the new macros.
13828 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13829 argument, for consistency with GCPRO2_VAR, etc: it is now the
13830 prefix of the variable, not the variable itself. All uses
13831 changed.
38b2c076
PE
13832 * dired.c (directory_files_internal, file_name_completion):
13833 Rename locals to avoid shadowing.
13834
15206ed9
PE
13835 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13836 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13837 dired.c's scmp function, had undefined behavior.
13838 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13839 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13840 * buffer.h: ... to here, because these macros use current_buffer,
13841 and the new implementation with inline functions needs to have
13842 current_buffer in scope now, rather than later when the macros
13843 are used.
13844 (downcase, upcase1): New static inline functions.
13845 (DOWNCASE, UPCASE1): Reimplement using these functions.
13846 This avoids undefined behavior in expressions like
13847 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13848 from race conditions in accessing the global variables
13849 case_temp1 and case_temp2.
13850 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13851 * lisp.h (case_temp1, case_temp2): Remove their decls.
13852 * character.h (ASCII_CHAR_P): Move from here ...
13853 * lisp.h: ... to here, so that the inline functions mentioned
13854 above can use them.
13855
4a6bea26
PE
13856 * dired.c (directory_files_internal_unwind): Now static.
13857
f14b7e14
PE
13858 * fileio.c (file_name_as_directory, directory_file_name):
13859 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13860 Now static.
2893f146
PE
13861 (file_name_as_directory): Use const pointers when appropriate.
13862 (Fexpand_file_name): Likewise. In particular, newdir might
13863 point at constant storage, so make it a const pointer.
fd4ead52 13864 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13865 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13866 signedness issues.
f839df0c
PE
13867 (Fset_file_times, Finsert_file_contents, auto_save_error):
13868 Rename locals to avoid shadowing.
f14b7e14 13869
5716756e 13870 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13871 (Ftry_completion, Fall_completions): Rename or remove locals
13872 to avoid shadowing.
5716756e 13873
b4c3046a
PE
13874 * marker.c (bytepos_to_charpos): Remove; unused.
13875
b45db522
PE
13876 * lisp.h (verify_bytepos, count_markers): New decls,
13877 so that gcc does not warn that these functions aren't declared.
13878
85876d07
PE
13879 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13880 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13881 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13882 (copy_text): Remove unused local var.
85876d07 13883
03d78a21 13884 * filelock.c (within_one_second): Now static.
b3dd38ab 13885 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13886
5df8f01b
PE
13887 * buffer.c (fix_overlays_before): Mark locals as initialized.
13888 (fix_start_end_in_overlays): Likewise. This function should be
13889 simplified by using pointers-to-pointers, but that's a different
13890 matter.
b1d876f1 13891 (switch_to_buffer_1): Now static.
8f54f30a
PE
13892 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13893 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13894
a70072c9 13895 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13896 Fix pointer signedness issue.
edced198
PE
13897 (sys_subshell): Mark local as volatile if checking for lint,
13898 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13899 (MAXPATHLEN): Define only if needed.
a70072c9 13900
a0977c44
PE
13901 * process.c (serial_open, serial_configure): Move decls from here ...
13902 * systty.h: ... to here, so that they can be checked.
13903
a884fdcc
PE
13904 * fns.c (get_random, seed_random): Move extern decls from here ...
13905 * lisp.h: ... to here, so that they can be checked.
13906
604efe86 13907 * sysdep.c (reset_io): Now static.
b8950c94 13908 (wait_for_termination_signal): Remove; unused.
604efe86 13909
38fc62d9
PE
13910 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13911 (copy_keymap_item, append_key, push_text_char_description):
13912 Now static.
1004a21a 13913 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13914 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13915 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13916 (describe_map_tree):
13917 Rename locals to avoid shadowing.
38fc62d9 13918
2f2650da
PE
13919 * keyboard.c: Declare functions static if they are not used elsewhere.
13920 (echo_char, echo_dash, cmd_error, top_level_2):
13921 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13922 (read_char, kbd_buffer_get_event, make_lispy_position):
13923 (make_lispy_event, make_lispy_movement, apply_modifiers):
13924 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13925 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13926 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13927 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13928 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13929
a053e86c 13930 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13931 (mark_kboards): Move decl here ...
13932 * alloc.c (mark_kboards): ... from here.
a053e86c 13933
4752793e
PE
13934 * lisp.h (force_auto_save_soon): New decl.
13935
74f10ca7 13936 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13937 (DEFINE_DUMMY_FUNCTION): New macro.
13938 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13939 Use it.
c03cd23f
PE
13940 (main): Add casts to avoid warnings
13941 if GCC considers string literals to be constants.
74f10ca7 13942
022e70d4
PE
13943 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13944
59d6fe83
PE
13945 * dbusbind.c: Pointer signedness fixes.
13946 (xd_signature, xd_append_arg, xd_initialize):
13947 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13949 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13950 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13951
78320123
PE
13952 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13953 if GCC considers string literals to be constants.
49cebcca 13954 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13955
35ac2a97
SM
139562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13957
fb103ca9
SM
13958 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13959 (print_preprocess, print_object): New macro to fix last change.
13960
35ac2a97
SM
13961 * print.c (print_preprocess): Don't forget font objects.
13962
62973b41
JB
139632011-03-16 Juanma Barranquero <lekktu@gmail.com>
13964
13965 * emacs.c (USAGE3): Doc fixes.
13966
0e48bb22
AS
139672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13968
13969 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13970 structure.
13971
7684e57b
JB
139722011-03-14 Juanma Barranquero <lekktu@gmail.com>
13973
13974 * lisp.h (VWindow_system, Qfile_name_history):
13975 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13976 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13977 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13978
13979 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13980 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13981
13982 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13983 * w32console.c (detect_input_pending, read_input_pending)
13984 (encode_terminal_code):
13985 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13986 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13987 (w32_system_caret_y, Qfile_name_history):
13988 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13989 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13990 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13991 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13992 * w32proc.c (Qlocal, report_file_error):
13993 * w32term.c (Vwindow_system, updating_frame):
13994 * w32uniscribe.c (initialized, uniscribe_font_driver):
13995 Remove unneeded extern declarations.
13996
2aa46d6c
CY
139972011-03-14 Chong Yidong <cyd@stupidchicken.com>
13998
c96bbc66 13999 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14000
cffc6f3b
CY
140012011-03-13 Chong Yidong <cyd@stupidchicken.com>
14002
14003 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14004 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14005 These macros can no longer be used for assignment.
14006
44f230aa
SM
14007 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14008 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14009 (record_buffer_markers, fetch_buffer_markers): New functions for
14010 recording and fetching special buffer markers.
14011 (set_buffer_internal_1, set_buffer_temp): Use them.
14012
14013 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14014
14015 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14016
14017 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14018 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14019
14020 * xdisp.c (hscroll_window_tree):
14021 (reconsider_clip_changes): Use PT instead of BUF_PT.
14022
d251f04b
EZ
140232011-03-13 Eli Zaretskii <eliz@gnu.org>
14024
14025 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14026 $(EMACS_ROOT)/lib/intprops.h.
14027
f0c77cd1
PE
140282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14029
3eca4629
PE
14030 Fix more problems found by GCC 4.5.2's static checks.
14031
7c86ee98
PE
14032 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14033 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14034 (xg_free_frame_widgets): Make it clear that a local variable is
14035 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14036 (gdk_window_get_screen): Make it clear that this macro is needed
14037 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14038 (int_gtk_range_get_value): New function, which avoids a diagnostic
14039 from gcc -Wbad-function-cast.
14040 (xg_set_toolkit_scroll_bar_thumb): Use it.
14041 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14042 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14043 (get_utf8_string, xg_get_file_with_chooser):
14044 Rename locals to avoid shadowing.
14045 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14046
41729b81
PE
14047 * xgselect.c (xg_select): Remove unused var.
14048
f0c77cd1
PE
14049 * image.c (four_corners_best): Mark locals as initialized.
14050 (gif_load): Initialize transparent_p to zero (Bug#8238).
14051 Mark another local as initialized.
ec6cf4c6 14052 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14053
ce0ad53d 14054 * image.c (clear_image_cache): Now static.
d5d5a617 14055 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14056 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14057 (x_edge_detection): Remove unnecessary cast that
14058 gcc -Wbad-function-cast diagnoses.
2037898d 14059 (gif_load): Fix pointer signedness.
6ae141d6
PE
14060 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14061 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14062
33383987 140632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14064
d32df629
PE
14065 Improve quality of tests for time stamp overflow.
14066 For example, without this patch (encode-time 0 0 0 1 1
14067 1152921504606846976) returns the obviously-bogus value (-948597
14068 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14069 reports time overflow. See
14070 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14071 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14072 * editfns.c: Include limits.h and intprops.h.
14073 (TIME_T_MIN, TIME_T_MAX): New macros.
14074 (time_overflow): Move earlier, to before first use.
14075 (hi_time, lo_time): New functions, for an accurate test for
14076 out-of-range times.
14077 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14078 (Fget_internal_run_time): Don't assume time_t fits in int.
14079 (make_time): Use list2 instead of Fcons twice.
14080 (Fdecode_time): More accurate test for out-of-range times.
14081 (check_tm_member): New function.
14082 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14083 (lisp_time_argument): Don't rely on undefined left-shift and
14084 right-shift behavior when checking for time stamp overflow.
8be6f318 14085
fe31d94c
PE
14086 * editfns.c (time_overflow): New function, refactoring common code.
14087 (Fformat_time_string, Fdecode_time, Fencode_time):
14088 (Fcurrent_time_string): Use it.
14089
8be6f318
PE
14090 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14091 * dired.c (make_time): Move to ...
14092 * editfns.c (make_time): ... here.
14093 * systime.h: Note the move.
14094
09d9db2c 140952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14096
126bc0dc
YM
14097 * fringe.c (update_window_fringes): Remove unused variables.
14098
c47cbdfd
YM
14099 * unexmacosx.c (copy_data_segment): Also copy __got section.
14100 (Bug#8223)
14101
7ac80be9
EZ
141022011-03-12 Eli Zaretskii <eliz@gnu.org>
14103
c96bbc66 14104 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14105 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14106 Constify `char *' arguments and their references according to
14107 prototypes in tparam.h.
14108
ecb0f94d 14109 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14110
7ac80be9
EZ
14111 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14112 Adapt all references accordingly.
14113
14114 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14115
ef1fd07e
TT
141162011-03-11 Tom Tromey <tromey@redhat.com>
14117
14118 * buffer.c (syms_of_buffer): Remove obsolete comment.
14119
7ef4b50c
EZ
141202011-03-11 Eli Zaretskii <eliz@gnu.org>
14121
14122 * termhooks.h (encode_terminal_code): Declare prototype.
14123
14124 * msdos.c (encode_terminal_code): Don't declare prototype.
14125
14126 * term.c (encode_terminal_code): Now external again, used by
14127 w32console.c and msdos.c.
14128
44f230aa
SM
14129 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14130 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14131
4b1ec863 141322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14133
1714f52b 14134 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14135
4b1ec863
PE
14136 * fringe.c (update_window_fringes): Mark locals as initialized
14137 (Bug#8227).
14138 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14139
524c7aa6
PE
14140 * alloc.c (mark_fringe_data): Move decl from here ...
14141 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14142 to check its interface.
14143 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14144
a5c0af81 14145 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14146 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14147 (fontset_font): Mark local as initialized.
a9a06e0b 14148 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14149
b4716021
PE
14150 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14151
811e9bac 14152 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14153 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14154 (x_own_selection, Fx_disown_selection_internal): Rename locals
14155 to avoid shadowing.
14156 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14157
7e3ab302
PE
14158 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14159 so that the caller can use some name other than gcpro1.
14160 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14161 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14162 (Fx_backspace_delete_keys_p):
14163 Use them to avoid shadowing, and rename vars to avoid shadowing.
14164 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14165 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14166 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14167 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14168 Remove unused locals.
7e3ab302
PE
14169 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14170 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14171 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14172 macros.
f78faa98 14173
e2b13473
PE
14174 * xterm.h (x_mouse_leave): New decl.
14175
77f23912
PE
14176 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14177 Remove unused functions.
cdf4ba58
PE
14178 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14179 (x_calc_absolute_position): Now static.
7411c686 14180 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14181 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14182 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14183 unless they are used.
38d0b34a
PE
14184 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14185 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14186 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14187 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14188 (x_error_catcher, x_connection_closed, x_error_handler):
14189 (x_error_quitter, xembed_send_message, x_iconify_frame):
14190 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14191 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14192 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14193
44f230aa
SM
14194 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14195 Rename or move locals to avoid shadowing.
6b463e58 14196 (tty_defined_color, merge_face_heights): Now static.
5967d051 14197 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14198 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14199 does not deduce is never used uninitialized.
73719eba
PE
14200 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14201 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14202
426994c3 14203 * terminal.c (store_terminal_param): Now static.
5489860b 14204
032f1620 14205 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14206 (set_frame_menubar): Remove unused local.
d4323972 14207 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14208 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14209 since they might point to immutable storage.
281585b0
PE
14210 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14211 since it's unused otherwise.
032f1620 14212
367c19e5 14213 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14214 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14215 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14216 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14217 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14218 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14219 does not deduce are never used uninitialized.
70739cbe 14220
07b48fa9
PE
14221 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14222
8868a238 14223 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14224 * window.c (window_loop, size_window):
14225 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14226
7e5cf297 14227 * window.c (display_buffer): Now static.
d6550a9f
PE
14228 (size_window): Mark variables that gcc -Wuninitialized
14229 does not deduce are never used uninitialized.
a586633d
PE
14230 * window.h (check_all_windows): New decl, to forestall
14231 gcc -Wmissing-prototypes diagnostic.
5b555da1 14232 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14233
f6095868
PE
14234 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14235 shadowing.
14236 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14237 Include <limits.h>.
14238 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14239 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14240 (load_charset_map): Mark variables that gcc -Wuninitialized
14241 does not deduce are never used uninitialized.
53df7c11 14242 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14243
f38b440c
PE
14244 * coding.c (coding_set_source, coding_set_destination):
14245 Use "else { /* comment */ }" rather than "else /* comment */;"
14246 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14247 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14248 a block, when the outer 'i' will do.
14249 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14250 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14251 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14252 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14253 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14254 Rename locals to avoid shadowing.
14255 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14256 * coding.c (emacs_mule_char, encode_invocation_designation):
14257 Now static, since they're not used elsewhere.
413bb2db 14258 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14259 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14260 (decode_coding_emacs_mule): Mark variables that gcc
14261 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14262 (detect_coding_iso_2022): Initialize a local variable that might
14263 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14264 this initialization is needed. (Bug#8211)
5f58e762
PE
14265 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14266 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14267 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14268 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14269 Remove unused macros.
f38b440c 14270
232b38b9 14271 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14272 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14273 * character.c (string_count_byte8): Likewise.
232b38b9 14274
fb90da1b
PE
14275 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14276 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14277
fb93dbc2
PE
14278 * chartab.c (copy_sub_char_table): Now static, since it's not used
14279 elsewhere.
5c156ace
PE
14280 (sub_char_table_ref_and_range, char_table_ref_and_range):
14281 Rename locals to avoid shadowing.
bbcd0949 14282 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14283
7d3b3862 14284 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14285 (BIDI_BOB): Remove unused macro.
7d3b3862 14286
6be7d3da
PE
14287 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14288 deduce are never used uninitialized.
c2ed9c8b 14289 * term.c (encode_terminal_code): Likewise.
6be7d3da 14290
75f8807f 14291 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14292
50938595
PE
14293 * tparam.h: New file.
14294 * term.c, tparam.h: Include it.
14295 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14296 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14297 Move these decls to tparam.h, and make them agree with what
14298 is actually in tparam.c. The previous trick of using incompatible
14299 decls in different modules does not conform to the C standard.
14300 All callers of tparam changed to use tparam's actual API.
14301 * tparam.c (tparam1, tparam, tgoto):
14302 Use const pointers where appropriate.
14303
fbceeba2
PE
14304 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14305 * cm.h (struct cm): Likewise.
14306 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14307 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14308 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14309 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14310 (turn_on_face, init_tty): Likewise.
14311 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14312
7f3f1250
PE
14313 * term.c (term_mouse_position): Rename local to avoid shadowing.
14314
e6ca6543
PE
14315 * alloc.c (mark_ttys): Move decl from here ...
14316 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14317
c40f8d15
AS
143182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14319
14320 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14321
cfe0661d
JB
143222011-03-09 Juanma Barranquero <lekktu@gmail.com>
14323
14324 * search.c (compile_pattern_1): Remove argument regp, unused since
14325 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14326 (compile_pattern): Don't pass it.
14327
0afb4571
J
143282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14329
14330 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14331 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14332 for ! HAVE_GTK3.
14333 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14334
14335 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14336
14337 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14338 gdk_window_get_screen, gdk_window_get_geometry,
14339 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14340 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14341 (xg_get_pixbuf_from_pixmap): New function.
14342 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14343 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14344 Call xg_get_pixbuf_from_pixmap instead of
14345 gdk_pixbuf_get_from_drawable.
14346 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14347 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14348 (xg_check_special_colors): Use GtkStyleContext and its functions
14349 for HAVE_GTK3.
14350 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14351 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14352 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14353 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14354 Call gtk_widget_get_preferred_size.
0afb4571
J
14355 (xg_frame_resized): gdk_window_get_geometry only takes 5
14356 parameters.
44f230aa
SM
14357 (xg_win_to_widget, xg_event_is_for_menubar):
14358 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14359 (xg_set_widget_bg): New function.
14360 (delete_cb): New function.
895009e1 14361 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14362 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14363 (xg_set_background_color): Call xg_set_widget_bg.
14364 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14365 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14366 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14367 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14368 if ! HAVE_GTK3.
14369 (update_frame_tool_bar): Call gtk_widget_hide.
14370 (xg_initialize): Use GDK_KEY_g.
14371
14372 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14373 if ! HAVE_GTK3
14374 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14375
14376 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14377 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14378 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14379
1c2cc4ef
JB
143802011-03-08 Juanma Barranquero <lekktu@gmail.com>
14381
14382 * w32xfns.c (select_palette): Check success of RealizePalette against
14383 GDI_ERROR, not zero.
14384
33383987 14385See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14386
14387;; Local Variables:
14388;; coding: utf-8
aac0c6e3
MR
14389;; End:
14390
2f097256 14391 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14392
14393 This file is part of GNU Emacs.
14394
14395 GNU Emacs is free software: you can redistribute it and/or modify
14396 it under the terms of the GNU General Public License as published by
14397 the Free Software Foundation, either version 3 of the License, or
14398 (at your option) any later version.
14399
14400 GNU Emacs is distributed in the hope that it will be useful,
14401 but WITHOUT ANY WARRANTY; without even the implied warranty of
14402 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14403 GNU General Public License for more details.
14404
14405 You should have received a copy of the GNU General Public License
14406 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.