Use different faces for marked and flagged files in dired
[bpt/emacs.git] / src / ChangeLog
CommitLineData
fb33fa43
SM
12011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4
b099e063
DM
52010-12-03 Don March <don@ohspite.net>
6
7 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8 last character M-[char] is translated to ESC [char] (bug#7541).
9
5cc7f7af
KH
102011-08-02 Kenichi Handa <handa@m17n.org>
11
d0fffa3f 12 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
13
14 * chartab.c (uniprop_table): Make it non-static.
15
525d5e6e
EZ
162011-08-01 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (forward_to_next_line_start): Accept additional argument
19 BIDI_IT_PREV, and store into it the state of the bidi iterator had
20 on the newline.
21 (reseat_at_next_visible_line_start): Use the bidi iterator state
22 returned by forward_to_next_line_start to restore the state of
23 it->bidi_it after backing up to previous newline. (Bug#9212)
24
31011111
AS
252011-07-30 Andreas Schwab <schwab@linux-m68k.org>
26
27 * regex.c (re_comp): Protoize.
28 (re_exec): Fix return type.
29 (regexec): Fix type of `ret'. (Bug#9203)
30
e5d76069
PE
312011-07-29 Paul Eggert <eggert@cs.ucla.edu>
32
33 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
34 This is needed if max-image-size is a floating-point number.
35
9a79b20c
AS
362011-07-28 Andreas Schwab <schwab@linux-m68k.org>
37
38 * print.c (print_object): Print empty symbol as ##.
39
40 * lread.c (read1): Read ## as empty symbol.
41
d8c2fa78
AA
422011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
43
44 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
45 setting frame foreground color (Bug#9175).
46 (x_set_background_color): Likewise.
47
ffe57a7a
AA
48 * nsmenu.m (-setText): Size tooltip dimensions precisely to
49 contents (Bug#9176).
50 (EmacsTooltip -init): Remove bezels and add shadows to
51 tooltip windows.
52
bf3492a5
AA
53 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
54 or scroll bar (Bug#8470).
55
d55e9c53
AA
56 * nsfont.m (nsfont_open): Remove assignment to voffset and
57 unnecessary vars hshink, expand, hd, full_height, min_height.
58 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
59
60 * nsterm.h (nsfont_info): Remove voffset field.
61
d8c2fa78 622011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
63
64 Implement strike-through and overline on NextStep (Bug#8863).
65
66 * nsfont.m (nsfont_open): Use underline position provided by font,
67 instead of hard-coded value of 2.
68 (nsfont_draw): Call ns_draw_text_decoration instead.
69
70 * nsterm.h: Add declaration for ns_draw_text_decoration.
71
72 * nsterm.m (ns_draw_text_decoration): New function for drawing
73 underline, overline, and strike-through.
74 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
75 ns_draw_text_decoration. Change treatment of cursor drawing to
76 accomodate underlining, etc.
77
4cc60b9b
EZ
782011-07-28 Eli Zaretskii <eliz@gnu.org>
79
bc7ece87
EZ
80 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
81 default.
4cc60b9b 82
476371c4
PE
832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
84
66606eea
PE
85 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
86 Without this fix, if a signal arrives just after memory fills up,
87 'malloc' might be invoked reentrantly.
88
476371c4
PE
89 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
90 In other words, assume that every image size is allowed, on non-X
91 hosts. This assumption is probably wrong, but it lets Emacs compile.
92
f3fcc40d
AS
932011-07-28 Andreas Schwab <schwab@linux-m68k.org>
94
95 * regex.c (re_iswctype): Convert return values to boolean.
96
350c992f
EZ
972011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
98
99 * xdisp.c (compute_display_string_pos): Don't use cached display
100 string position if the buffer had its restriction changed.
101 (Bug#9184)
102
5266b4bb
PE
1032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
104
105 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
106
2573a837 1072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 108
41f55ccd 109 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 110
39e378da
PE
111 * bidi.c: Integer size and overflow fixes.
112 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
113 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
114 (bidi_cache_find_level_change, bidi_cache_ensure_space)
115 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
116 (bidi_find_other_level_edge):
117 Use ptrdiff_t instead of EMACS_INT where either will do.
118 This works better on 32-bit hosts configured --with-wide-int.
119 (bidi_cache_ensure_space): Check for size-calculation overflow.
120 Use % rather than repeated addition, for better worst-case speed.
121 Don't set bidi_cache_size until after xrealloc returns, because it
122 might not return.
123 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
124 (bidi_cache_ensure_space): Also check that the bidi cache size
125 does not exceed that of the largest Lisp string or buffer. See Eli
126 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 127
5e927815
PE
128 * alloc.c (__malloc_size_t): Remove.
129 All uses replaced by size_t. See Andreas Schwab's note
130 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
131
ca4aa935
PE
132 * image.c: Improve checking for integer overflow.
133 (check_image_size): Assume that f is nonnull, since
134 it is always nonnull in practice. This is one less thing to
135 worry about when checking for integer overflow later.
136 (x_check_image_size): New function, which checks for integer
137 overflow issues inside X.
138 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
139 This removes the need for a memory_full check.
140 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
141 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
142 (xbm_read_bitmap_data): Change locals back to 'int', since
143 their values must fit in 'int'.
144 (xpm_load_image, png_load, tiff_load):
145 Invoke x_create_x_image_and_pixmap earlier,
146 to avoid much needless work if the image is too large.
147 (tiff_load): Treat overly large images as if
148 x_create_x_image_and_pixmap failed, not as malloc failures.
149 (gs_load): Use x_check_image_size.
150
5f8f9cc2
PE
151 * gtkutil.c: Omit integer casts.
152 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
153 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
154
5adf60bc
PE
155 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
156
c8907a93
PE
157 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
158 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
159 would wrongly return t on a 64-bit host.
160
e3c25c68
PE
161 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
162 The plain *_OVERFLOW macros run afoul of GCC bug 49705
163 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
164 and therefore cause GCC to emit a bogus diagnostic in some cases.
165
3f791afe
PE
166 * image.c: Integer signedness and overflow and related fixes.
167 This is not an exhaustive set of fixes, but it's time to
168 record what I've got.
169 (lookup_pixel_color, check_image_size): Remove redundant decls.
170 (check_image_size): Don't assume that arbitrary EMACS_INT values
171 fit in 'int', or that arbitrary 'double' values fit in 'int'.
172 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
173 (tiff_load, imagemagick_load_image):
174 Check for overflow in size calculations.
175 (x_create_x_image_and_pixmap): Remove unnecessary test for
176 xmalloc returning NULL; that can't happen.
177 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
178 (xpm_color_bucket): Use better integer hashing function.
179 (xpm_cache_color): Don't possibly over-allocate memory.
180 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
181 (gif_memory_source):
182 Use ptrdiff_t, not int or size_t, to record sizes.
183 (png_load): Don't assume values greater than 2**31 fit in 'int'.
184 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
185 either works, as we prefer signed integers.
186 (tiff_read_from_memory, tiff_write_from_memory):
187 Return tsize_t, not size_t, since that's what the TIFF API wants.
188 (tiff_read_from_memory): Don't fail simply because the read would
189 go past EOF; instead, return a short read.
190 (tiff_load): Omit no-longer-needed casts.
191 (Fimagemagick_types): Don't assume size fits into 'int'.
192
3cc5a532
PE
193 Improve hashing quality when configured --with-wide-int.
194 * fns.c (hash_string): New function, taken from sxhash_string.
195 Do not discard information about ASCII character case; this
196 discarding is no longer needed.
197 (sxhash-string): Use it. Change sig to match it. Caller changed.
198 * lisp.h: Declare it.
199 * lread.c (hash_string): Remove, since we now use fns.c's version.
200 The fns.c version returns a wider integer if --with-wide-int is
201 specified, so this should help the quality of the hashing a bit.
202
b312a492
PE
203 * emacs.c: Integer overflow minor fix.
204 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
205 Define only if GNU_LINUX.
206 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
207
dfd153ae
PE
208 * dispnew.c: Integer signedness and overflow fixes.
209 Remove unnecessary forward decls, that were a maintenance hassle.
210 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
211 All uses changed.
212 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
213 (scrolling_window): Use ptrdiff_t, not int, for byte count.
214 (prepare_desired_row, line_draw_cost):
215 Use int, not unsigned, where either works.
216 (save_current_matrix, restore_current_matrix):
217 Use ptrdiff_t, not size_t, where either works.
218 (init_display): Check for overflow more accurately, and without
219 relying on undefined behavior.
220
a81d11a3
PE
221 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
222 Remove, replacing with the new symbols in lisp.h. All uses changed.
223 * fileio.c (make_temp_name):
224 * filelock.c (lock_file_1, lock_file):
225 * xdisp.c (message_dolog):
226 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
227 Use pMd etc. instead.
228 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
229 replacing the pWIDE etc. symbols removed from editfns.c.
230
3300e6fd
PE
231 * keyboard.h (num_input_events): Now uintmax_t.
232 This is (very slightly) less likely to mess up due to wraparound.
233 All uses changed.
234
fd05c7e9
PE
235 * buffer.c: Integer signedness fixes.
236 (alloc_buffer_text, enlarge_buffer_text):
237 Use ptrdiff_t rather than size_t when either will do, as we prefer
238 signed integers.
239
903fe15d
PE
240 * alloc.c: Integer signedness and overflow fixes.
241 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
242 (__malloc_size_t): Default to size_t, not to int.
243 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
244 (Fgarbage_collect, mark_object_loop_halt, mark_object):
245 Prefer ptrdiff_t to size_t when either would do, as we prefer
246 signed integers.
247 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
248 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
249 Now const. Initialize with values that are in range even if char
250 is signed.
251 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
252 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
253 These functions do the right thing with sizes > 2**32.
254 (check_depth): Now ptrdiff_t, not int.
255 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
256 Adjust to new way of storing sizes. Check for size overflow bugs
257 in rest of code.
258 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
259 slightly wrong anyway, as it missed one instance of
260 XMALLOC_OVERRUN_CHECK_OVERHEAD.
261 (refill_memory_reserve): Omit needless cast to size_t.
262 (mark_object_loop_halt): Mark as externally visible.
263
ac82cc6a
PE
264 * xselect.c: Integer signedness and overflow fixes.
265 (Fx_register_dnd_atom, x_handle_dnd_message):
266 Use ptrdiff_t, not size_t, since we prefer signed.
267 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
268 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
269 x_dnd_atoms_size and x_dnd_atoms_length.
270
c2d1e36d
PE
271 * doprnt.c: Prefer signed to unsigned when either works.
272 * eval.c (verror):
273 * doprnt.c (doprnt):
274 * lisp.h (doprnt):
275 * xdisp.c (vmessage):
276 Use ptrdiff_t, not size_t, when using or implementing doprnt,
277 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
278 prefer signed arithmetic to avoid comparison confusion.
279 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
280 but is a bit tricky.
281
0e926e56
PE
282 Assume freestanding C89 headers, string.h, stdlib.h.
283 * data.c, doprnt.c, floatfns.c, print.c:
284 Include float.h unconditionally.
285 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
286 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
287 * regex.c: Likewise for stddef.h, string.h.
288 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
289 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
290 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
291 (STDC_HEADERS): Remove obsolete defines.
292 * sysdep.c: Include limits.h unconditionally.
293
9cfdb3ec
PE
294 Assume support for memcmp, memcpy, memmove, memset.
295 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
296 * regex.c (memcmp, memcpy):
297 Remove; we assume C89 now.
298
299 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
300 (__malloc_safe_bcopy): Remove; no longer needed.
301
cf950e6b 302 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
303 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
304 well either way, and we prefer signed to unsigned.
305
dbf38e02
LMI
3062011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
307
308 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
309 closes the connection while we're reading (bug#9182).
310
d6f0886c
JD
3112011-07-25 Jan Djärv <jan.h.d@swipnet.se>
312
313 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
314 are specified (Bug#9168).
315
2eb1f9e6
PE
3162011-07-25 Paul Eggert <eggert@cs.ucla.edu>
317
318 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
319 Found by GCC static checking and --with-wide-int on a 32-bit host.
320
22381272 3212011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
322
323 * xdisp.c (compute_display_string_pos): Fix logic of caching
324 previous display string position. Initialize cached_prev_pos to
325 -1. Fixes slow-down at the beginning of a buffer.
326
f25e39b4
EZ
3272011-07-24 Eli Zaretskii <eliz@gnu.org>
328
329 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
330 for attrs[LFACE_FONTSET_INDEX].
331
04c4b52e
PE
3322011-07-23 Paul Eggert <eggert@cs.ucla.edu>
333
334 * xml.c (parse_region): Remove unused local
335 that was recently introduced.
336
c1734fbd
EZ
3372011-07-23 Eli Zaretskii <eliz@gnu.org>
338
be18c5a5
EZ
339 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
340 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
341
c1734fbd
EZ
342 * xdisp.c (move_it_in_display_line_to): Record the best matching
343 position for TO_CHARPOS while scanning the line, and restore it on
344 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
345 vertical-motion and pos-visible-in-window-p under bidi redisplay
346 when exact match is impossible due to invisible text, and the
347 lines are truncated.
348
a258d627
JD
3492011-07-23 Jan Djärv <jan.h.d@swipnet.se>
350
351 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
352 for OSX >= 10.7.
353
b6d5a689
EZ
3542011-07-22 Eli Zaretskii <eliz@gnu.org>
355
0f74f785
EZ
356 Fix a significant slow-down of cursor motion with C-n, C-p,
357 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
358 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 359 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
360 (next_element_from_buffer): Call compute_stop_pos_backwards to
361 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
362 base_level_stop.
363 (reseat): Don't look for prev_stop, as that could mean a very long
364 run.
365 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
366 <cached_disp_overlay_modiff>: Cache for last found display string
367 position.
551918c1 368 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
369 about the same buffer in the same area of character positions, and
370 the buffer wasn't changed since the time the display string
371 position was cached.
551918c1 372
b2d0c91a
EZ
3732011-07-22 Eli Zaretskii <eliz@gnu.org>
374
375 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
376 is an integer, which is important for empty lines. (Bug#9149)
377
043604ee
CY
3782011-07-22 Chong Yidong <cyd@stupidchicken.com>
379
380 * frame.c (Fmodify_frame_parameters): In tty case, update the
381 default face if necessary (Bug#4238).
382
da4adb04
CY
3832011-07-21 Chong Yidong <cyd@stupidchicken.com>
384
385 * editfns.c (Fstring_to_char): No need to explain what a character
386 is in the docstring (Bug#6576).
387
9abd0532
LMI
3882011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
389
390 * xml.c (parse_region): Make sure we always return a tree.
391
36881d16
HK
3922011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
393
394 * xml.c (parse_region): If a document contains only comments,
395 return that, too.
396
1e98674d
LMI
3972011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
398
399 * xml.c (make_dom): Return comments, too.
400
590bd467
PE
4012011-07-19 Paul Eggert <eggert@cs.ucla.edu>
402
403 Port to OpenBSD.
404 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
405 and the surrounding thread.
406 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
407 rather than fgets, and retry after EINTR. Otherwise, 'emacs
408 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
409 timer goes off.
410 * s/openbsd.h (BROKEN_SIGIO): Define.
411 * unexelf.c (unexec) [__OpenBSD__]:
412 Don't update the .mdebug section of the Alpha COFF symbol table.
413
f41628b2
LMI
4142011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
415
416 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
417 (bug#8460).
418
b59b67c5
PE
4192011-07-18 Paul Eggert <eggert@cs.ucla.edu>
420
15e3a074
PE
421 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
422 This fixes some race conditions on the permissions of any newly
423 created file.
424
41bed37d
PE
425 * alloc.c (valid_pointer_p): Use pipe, not open.
426 This fixes some permissions issues when debugging.
427
b59b67c5
PE
428 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
429 If fchown fails to set both uid and gid, try to set just gid,
430 as that is sometimes allowed. Adjust the file's mode to eliminate
431 setuid or setgid bits that are inappropriate if fchown fails.
432
925a6be7
SM
4332011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
434
435 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
436 to compare Lisp_Objects.
437 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
438 global_gnutls_log_level, don't mistake it for a Lisp_Object.
439 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
440
52968808
AS
4412011-07-17 Andreas Schwab <schwab@linux-m68k.org>
442
0a6a104b
AS
443 * lread.c (read_integer): Unread even EOF character.
444 (read1): Likewise. Properly record start position of symbol.
445
52968808
AS
446 * lread.c (read1): Read `#:' as empty uninterned symbol if no
447 symbol character follows.
448
9e381cdd
PE
4492011-07-17 Paul Eggert <eggert@cs.ucla.edu>
450
451 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
452 This works around a problem with the previous change to Fcopy_file.
453 Recent glibc declares fchown with __attribute__((warn_unused_result)),
454 and without this change, GCC might complain about discarding
455 fchown's return value.
456
b5641435
JB
4572011-07-16 Juanma Barranquero <lekktu@gmail.com>
458
459 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
460
a8031457
PE
4612011-07-16 Paul Eggert <eggert@cs.ucla.edu>
462
463 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
464
dd889327
LMI
4652011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
466
750c33f7
LMI
467 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
468 it's used from the C level.
469
dd889327
LMI
470 * process.c: Use the same condition for POLL_FOR_INPUT in both
471 keyboard.c and process.c (bug#1858).
472
87e86684
LM
4732011-07-09 Lawrence Mitchell <wence@gmx.li>
474
475 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
476 (Fgnutls_boot): Use it.
477
64348f40
AS
4782011-07-15 Andreas Schwab <schwab@linux-m68k.org>
479
480 * doc.c (Fsubstitute_command_keys): Revert last change.
481
1d698799
LMI
4822011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
483
f863868c
LMI
484 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
485 quotes the next character, and doesn't affect other longer
486 sequences (bug#8935).
487
1d698799
LMI
488 * lread.c (syms_of_lread): Clarify that is isn't only
489 `eval-buffer' and `eval-defun' that's affected by
490 `lexical-binding' (bug#8460).
491
aa4b6df6
EZ
4922011-07-15 Eli Zaretskii <eliz@gnu.org>
493
494 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
495 bidi redisplay when a line includes both an image and is
496 truncated.
497
5d856da6
PE
4982011-07-14 Paul Eggert <eggert@cs.ucla.edu>
499
ad6042bb
PE
500 Fix minor problems found by static checking.
501 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
502 (elsz): Now a signed constant, not a size_t var. We prefer signed
503 types to unsigned, to avoid integer comparison confusion. Without
504 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
505 "cannot optimize loop, the loop counter may overflow", a symptom
506 of the confusion.
f00bbb22 507 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
508 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
509
6468f31c
LMI
5102011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
511
49080b10
LMI
512 * search.c (Fre_search_backward): Mention `case-fold-search' in
513 all the re_search_* functions (bug#8138).
514
6468f31c
LMI
515 * keyboard.c (Fopen_dribble_file): Document when the file is
516 closed (bug#8056).
517
c965adc5
EZ
5182011-07-14 Eli Zaretskii <eliz@gnu.org>
519
df9733bf
EZ
520 * bidi.c (bidi_dump_cached_states): Fix format of displaying
521 bidi_cache_idx.
522
0bb23927
EZ
523 Support bidi reordering of display and overlay strings.
524 * xdisp.c (compute_display_string_pos)
525 (compute_display_string_end): Accept additional argument STRING.
526 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
527 (reseat_to_string): Initialize bidi_it->string.s and
528 bidi_it->string.schars.
529 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
530 NULL (avoids a crash in bidi_paragraph_init). Initialize
531 itb.string.lstring.
532 (init_iterator): Call bidi_init_it only of a valid
533 buffer position was specified. Initialize paragraph_embedding to
534 L2R.
535 (reseat_to_string): Initialize the bidi iterator.
536 (display_string): If we need to ignore text properties of
537 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
538 original value of -1 will not work with bidi.)
539 (compute_display_string_pos): First arg is now struct
540 `text_pos *'; all callers changed. Support display properties on
541 Lisp strings.
542 (compute_display_string_end): Support display properties on Lisp
543 strings.
544 (init_iterator, reseat_1, reseat_to_string): Initialize the
545 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
546 when iterating on a string not from display properties).
547 (compute_display_string_pos, compute_display_string_end): Fix
548 calculation of the object to scan. Fixes an error when using
549 arrow keys.
550 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
551 base_level_stop; instead, set base_level_stop to BEGV. Fixes
552 crashes in vertical-motion.
553 (next_element_from_buffer): Improve commentary for when
554 the iterator is before prev_stop.
555 (init_iterator): Initialize bidi_p from the default value of
556 bidi-display-reordering, not from buffer-local value. Use the
557 buffer-local value only if initializing for buffer iteration.
558 (handle_invisible_prop): Support invisible properties on strings
559 that are being bidi-reordered.
560 (set_iterator_to_next): Support bidi reordering of C strings and
561 Lisp strings.
562 (next_element_from_string): Support bidi reordering of Lisp
563 strings.
564 (handle_stop_backwards): Support Lisp strings as well.
565 (display_string): Support display of R2L glyph rows. Use
566 IT_STRING_CHARPOS when displaying from a Lisp string.
567 (init_iterator): Don't initialize it->bidi_p for strings
568 here.
569 (reseat_to_string): Initialize it->bidi_p for strings here.
570 (next_element_from_string, next_element_from_c_string)
571 (next_element_from_buffer): Add xassert's for correspondence
572 between IT's object being iterated and it->bidi_it.string
573 structure.
574 (face_before_or_after_it_pos): Support bidi iteration.
575 (next_element_from_c_string): Handle the case of the first string
576 character that is not the first one in the visual order.
577 (get_visually_first_element): New function, refactored from common
578 parts of next_element_from_buffer, next_element_from_string, and
579 next_element_from_c_string.
580 (tool_bar_lines_needed, redisplay_tool_bar)
581 (display_menu_bar): Force left-to-right direction. Add a FIXME
582 comment for making that be controlled by a user option.
583 (push_it, pop_it): Save and restore the state of the
584 bidi iterator. Save and restore the bidi_p flag.
585 (pop_it): Iterate out of display property for string iteration as
586 well.
587 (iterate_out_of_display_property): Support iteration over strings.
588 (handle_single_display_spec): Set up it->bidi_it for iteration
589 over a display string, and call bidi_init_it.
590 (handle_single_display_spec, next_overlay_string)
591 (get_overlay_strings_1, push_display_prop): Set up the bidi
592 iterator for displaying display or overlay strings.
593 (forward_to_next_line_start): Don't use the shortcut if
594 bidi-iterating.
595 (back_to_previous_visible_line_start): If handle_display_prop
596 pushed the iterator stack, restore the internal state of the bidi
597 iterator by calling bidi_pop_it same number of times.
598 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
599 and we are bidi-iterating, don't decrement the iterator position;
600 instead, set the first_elt flag in the bidi iterator, to produce
601 the same effect.
602 (reseat_1): Remove redundant setting of string_from_display_prop_p.
603 (push_display_prop): xassert that we are iterating a buffer.
604 (push_it, pop_it): Save and restore paragraph_embedding member.
605 (handle_single_display_spec, next_overlay_string)
606 (get_overlay_strings_1, reseat_1, reseat_to_string)
607 (push_display_prop): Set up the `unibyte' member of bidi_it.string
608 correctly. Don't assume unibyte strings are not bidi-reordered.
609 (compute_display_string_pos)
610 (compute_display_string_end): Fix handling the case of C string.
611 (push_it, pop_it): Save and restore from_disp_prop_p.
612 (handle_single_display_spec, push_display_prop): Set the
613 from_disp_prop_p flag.
614 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
615 (pop_it): Call iterate_out_of_display_property only if we are
616 popping after iteration over a string that came from a display
617 property. Fix a typo in popping stretch info. Add an assertion
618 for verifying that the iterator position is in sync with the bidi
619 iterator.
620 (handle_single_display_spec, get_overlay_strings_1)
621 (push_display_prop): Fix initialization of paragraph direction for
622 string when that of the parent object is not yet determined.
623 (reseat_1): Call bidi_init_it to resync the bidi
624 iterator with IT's position. (Bug#7616)
625 (find_row_edges): If ROW->start.pos gives position
626 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
627 (handle_stop, back_to_previous_visible_line_start, reseat_1):
628 Reset the from_disp_prop_p flag.
629 (SAVE_IT, RESTORE_IT): New macros.
630 (pos_visible_p, face_before_or_after_it_pos)
631 (back_to_previous_visible_line_start)
632 (move_it_in_display_line_to, move_it_in_display_line)
633 (move_it_to, move_it_vertically_backward, move_it_by_lines)
634 (try_scrolling, redisplay_window, display_line): Use them when
635 saving a temporary copy of the iterator and restoring it back.
636 (back_to_previous_visible_line_start, reseat_1)
637 (init_iterator): Empty the bidi cache "stack".
638 (move_it_in_display_line_to): If iterator ended up at
639 EOL, but we never saw any buffer positions smaller than
640 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
641 motion in bidi-reordered lines.
642 (move_it_in_display_line_to): Record prev_method and prev_pos
643 immediately before the call to set_iterator_to_next. Fixes cursor
644 motion in bidi-reordered lines with stretch glyphs and strings
645 displayed in margins. (Bug#8133) (Bug#8867)
646 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
647 TO_CHARPOS.
648 (pos_visible_p): Support positions in bidi-reordered lines. Save
649 and restore bidi cache.
650
651 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
652 (bidi_paragraph_info): Delete unused struct.
653 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
654 (bidi_cache_start): New variable.
655 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
656 to zero.
657 (bidi_cache_fetch_state, bidi_cache_search)
658 (bidi_cache_find_level_change, bidi_cache_iterator_state)
659 (bidi_cache_find, bidi_peek_at_next_level)
660 (bidi_level_of_next_char, bidi_find_other_level_edge)
661 (bidi_move_to_visually_next): Compare cache index with
662 bidi_cache_start rather than with zero.
663 (bidi_fetch_char): Accept new argument STRING; all callers
664 changed. Support iteration over a string. Support strings with
665 display properties. Support unibyte strings. Fix the type of
666 `len' according to what STRING_CHAR_AND_LENGTH expects.
667 (bidi_paragraph_init, bidi_resolve_explicit_1)
668 (bidi_resolve_explicit, bidi_resolve_weak)
669 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
670 iteration over a string.
671 (bidi_set_sor_type, bidi_resolve_explicit_1)
672 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
673 can now be zero (for strings); special values 0 and -1 were
674 changed to -1 and -2, respectively.
675 (bidi_char_at_pos): New function.
676 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
677 Call it instead of FETCH_MULTIBYTE_CHAR.
678 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
679 initialized to valid values.
680 (bidi_init_it): Don't initialize charpos and bytepos with invalid
681 values.
682 (bidi_level_of_next_char): Allow the sentinel "position" to pass
683 the test for valid cached positions. Fix the logic for looking up
684 the sentinel state in the cache. GCPRO the Lisp string we are
685 iterating.
686 (bidi_push_it, bidi_pop_it): New functions.
687 (bidi_initialize): Initialize the bidi cache start stack pointer.
688 (bidi_cache_ensure_space): New function, refactored from part of
689 bidi_cache_iterator_state. Don't assume the required size is just
690 one BIDI_CACHE_CHUNK away.
691 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
692 (bidi_count_bytes, bidi_char_at_pos): New functions.
693 (bidi_cache_search): Don't assume bidi_cache_last_idx is
694 always valid if bidi_cache_idx is valid.
695 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
696 is valid if it's going to be used.
697 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
698 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
699 (bidi_cache_find_level_change, bidi_cache_ensure_space)
700 (bidi_cache_iterator_state, bidi_cache_find)
701 (bidi_find_other_level_edge, bidi_cache_start_stack): All
702 variables related to cache indices are now EMACS_INT.
703
0bb23927
EZ
704 * dispextern.h (struct bidi_string_data): New structure.
705 (struct bidi_it): New member `string'. Make flag members be 1-bit
706 fields, and put them last in the struct.
707 (compute_display_string_pos, compute_display_string_end): Update
708 prototypes.
709 (bidi_push_it, bidi_pop_it): Add prototypes.
710 (struct iterator_stack_entry): New members bidi_p,
711 paragraph_embedding, and from_disp_prop_p.
712 (struct it): Member bidi_p is now a bit field 1 bit wide.
713 (bidi_shelve_cache, bidi_unshelve_cache): Declare
714 prototypes.
715
716 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
717 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
718 and vector-like objects.
719
720 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
721 cache around display iteration.
722
723 * window.c (Fwindow_end, window_scroll_pixel_based)
724 (displayed_window_lines, Frecenter): Save and restore the bidi
725 cache around display iteration.
726
3bbd2265
LMI
7272011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
728
729 * editfns.c (Fdelete_region): Clarify the use of the named
730 parameters (bug#6788).
731
adc47434
MR
7322011-07-14 Martin Rudalics <rudalics@gmx.at>
733
734 * indent.c (Fvertical_motion): Set and restore w->pointm when
735 saving and restoring the window's buffer (Bug#9006).
736
837c31f8
LMI
7372011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
738
739 * editfns.c (Fstring_to_char): Clarify just what is returned
740 (bug#6576). Text by Eli Zaretskii.
741
ac389d0c
JB
7422011-07-13 Juanma Barranquero <lekktu@gmail.com>
743
744 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
745
0be0ce47
EZ
7462011-07-13 Eli Zaretskii <eliz@gnu.org>
747
748 * buffer.c (mmap_find): Fix a typo.
749
cd18e7e3
JB
7502011-07-13 Johan Bockgård <bojohan@gnu.org>
751
752 Fix execution of x selection hooks.
753 * xselect.c (Qx_lost_selection_functions)
754 (Qx_sent_selection_functions): New vars.
755 (syms_of_xselect): DEFSYM them.
756 (x_handle_selection_request): Pass Qx_sent_selection_functions
757 rather than Vx_sent_selection_functions to Frun_hook_with_args.
758 (x_handle_selection_clear,x_clear_frame_selections):
759 Pass Qx_lost_selection_functions rather than
760 Vx_lost_selection_functions to Frun_hook_with_args.
761
47ea7f44
PE
7622011-07-13 Paul Eggert <eggert@cs.ucla.edu>
763
ac389d0c 764 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
765 The old code sometimes used this field without initializing it.
766
47ea7f44
PE
767 * alloc.c (gc_sweep): Don't read past end of array.
768 In theory, the old code could also have corrupted Emacs internals,
769 though it'd be very unlikely.
770
bc985c87
AS
7712011-07-12 Andreas Schwab <schwab@linux-m68k.org>
772
773 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 774 argument. (Bug#4026)
bc985c87 775
0cf34688
LMI
7762011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
777
b3dadd76
LMI
778 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
779 key" (bug#4257).
780
0cf34688
LMI
781 * window.c (Fset_window_start): Doc fix (bug#4199).
782 (Fset_window_hscroll): Ditto.
783
270768cd
PE
7842011-07-12 Paul Eggert <eggert@cs.ucla.edu>
785
077e3dda 786 Fix minor new problems caught by GCC 4.6.1.
270768cd 787 * term.c (init_tty): Remove unused local.
490011a6 788 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 789 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 790 not used otherwise.
270768cd 791
b1f58454
CY
7922011-07-12 Chong Yidong <cyd@stupidchicken.com>
793
794 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
795
22b9578d
LMI
7962011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
797
6e70ab07
LMI
798 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
799 are the mini-buffer and the echo area (bug#3320).
800
22b9578d
LMI
801 * term.c (init_tty): Remove support for supdup, c10 and perq
802 terminals, which are no longer supported (bug#1482).
803
8974cc9f
JB
8042011-07-10 Johan Bockgård <bojohan@gnu.org>
805
806 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
807
a560d974
JD
8082011-07-10 Jan Djärv <jan.h.d@swipnet.se>
809
810 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
811 for non-popups (Bug#3642).
812
1dae0f0a
AS
8132011-07-10 Andreas Schwab <schwab@linux-m68k.org>
814
268c2c36 815 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 816 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
817 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
818 * cm.c (losecursor): Likewise.
1dae0f0a
AS
819 * data.c (fmod): Likewise.
820 * dispnew.c (swap_glyphs_in_rows): Likewise.
821 * emacs.c (memory_warning_signal): Likewise.
822 * floatfns.c (float_error): Likewise.
823 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
824 (otf_open, font_otf_capability, generate_otf_features)
825 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
826 Likewise.
827 * image.c (pbm_read_file): Likewise.
828 * indent.c (string_display_width): Likewise.
829 * intervals.c (check_for_interval, search_for_interval)
830 (inc_interval_count, count_intervals, root_interval)
831 (adjust_intervals_for_insertion, make_new_interval): Likewise.
832 * lread.c (defalias): Likewise.
268c2c36 833 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
834 * regex.c (set_image_of_range_1, set_image_of_range)
835 (regex_grow_registers): Likewise.
836 * sysdep.c (strerror): Likewise.
837 * termcap.c (valid_filename_p, tprint, main): Likewise.
838 * tparam.c (main): Likewise.
839 * unexhp9k800.c (run_time_remap, save_data_space)
840 (update_file_ptrs, read_header, write_header, calculate_checksum)
841 (copy_file, copy_rest, display_header): Likewise.
842 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
843 Likewise.
844 * xdisp.c (check_it): Likewise.
845 * xfaces.c (register_color, unregister_color, unregister_colors):
846 Likewise.
847 * xfns.c (print_fontset_result): Likewise.
848 * xrdb.c (member, fatal, main): Likewise.
849
99033785
PE
8502011-07-10 Paul Eggert <eggert@cs.ucla.edu>
851
852 Fix minor problems found by static checking (Bug#9031).
853 * chartab.c (char_table_set_range, map_sub_char_table):
854 Remove unused locals.
855 (uniprop_table): Now static.
856 * composite.c (_work_char): Remove unused static var.
857
9cb2ac56
JB
8582011-07-09 Juanma Barranquero <lekktu@gmail.com>
859
860 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
861
f25661f0
JD
8622011-07-09 Jan Djärv <jan.h.d@swipnet.se>
863
864 * gtkutil.c (qttip_cb): Remove code without function.
865
8278c4fe
EZ
8662011-07-09 Eli Zaretskii <eliz@gnu.org>
867
868 * w32.c (pthread_sigmask): New stub.
869
1692ae2d 8702011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 871
8a6ebd58 872 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
873 sigprocmask is portable only for single-threaded applications, and
874 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
875 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
876 (LIBES): Use it.
877 * callproc.c (Fcall_process):
878 * process.c (create_process):
879 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
880 Use pthread_sigmask, not sigprocmask.
123403e4 881
1b854618
JD
8822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
883
884 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
885 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
886 wrong (Bug#8591).
887
3fe4b549
JD
8882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
889
0ce7e563
JD
890 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
891 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
892 (xg_hide_tooltip): Fix comment.
893
3fe4b549
JD
894 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
895 in registerServicesMenuSendTypes.
896 (validRequestorForSendType): Don't check ns_return_types.
897
898 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
899 ns_return_type.
900
5df75e47
JR
9012011-07-08 Jason Rumney <jasonr@gnu.org>
902
903 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
904 frame struct members of non-existent frames (Bug#6284).
905
699c10bd
JD
9062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
907
4393663b
JD
908 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
909 variable firstTime not needed on OSX >= 10.6.
910 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
911 >= 10.5. Use setKnobProportion, setDoubleValue.
912
913 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
914 (MAC_OS_X_VERSION_10_5): Define if not defined.
915 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
916 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
917 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
918
919 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
920 cString and lossyCString on OSX >= 10.4
921
922 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
923 sizeToFit on OSX >= 10.2.
924
925 * nsimage.m (allocInitFromFile): Don't use deprecated method
926 bestRepresentationForDevice on OSX >= 10.6.
927
928 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
929 to avoid warning.
930
931 * emacs.c: Declare unexec_init_emacs_zone.
932
a63e0781
JD
933 * nsgui.h: Fix compiler warning about gnulib redefining verify.
934
699c10bd
JD
935 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
936
937 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
938 on svcsMenu (Bug#8842).
939
940 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
941 ns_return_types.
942 (Fns_list_services): Just return Qnil on 10.6, code not working there.
943
944 * nsterm.m (QUTF8_STRING): Declare.
945 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
946 (validRequestorForSendType): Return type is (id).
947 Change indexOfObjectIdenticalTo to indexOfObject.
948 Check if we have local selection before returning self (Bug#8842).
949 (writeSelectionToPasteboard): Put local selection into paste board
950 if we have a local selection (Bug#8842).
951 (syms_of_nsterm): DEFSYM QUTF8_STRING.
952
953 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
954 (ns_get_local_selection): Declare.
955
54e10184
LMI
9562011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
957
9888ff71
LMI
958 * keymap.c (describe_map_tree): Don't insert a double newline at
959 the end of the buffer (bug#1169) and return whether we inserted
960 something.
961
54e10184
LMI
962 * callint.c (Fcall_interactively): Change "reading args" to
963 "providing args" to try to clarify what it does (bug#1010).
964
15fa4783
KH
9652011-07-07 Kenichi Handa <handa@m17n.org>
966
967 * composite.c (composition_compute_stop_pos): Ignore a static
968 composition starting before CHARPOS (Bug#8915).
969
970 * xdisp.c (handle_composition_prop): Likewise.
971
a8815b00
EZ
9722011-07-07 Eli Zaretskii <eliz@gnu.org>
973
974 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
975 (Bug#9015)
976
ef7b981d 9772011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
978
979 * character.h (unicode_category_t): New enum type.
980
981 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
982 (Qchar_code_property_table): New variable.
983 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
984 (UNIPROP_COMPRESSED_FORM_P): New macros.
985 (char_table_ascii): Uncompress the compressed values.
986 (sub_char_table_ref): New arg is_uniprop. Callers changed.
987 Uncompress the compressed values.
ac389d0c 988 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
989 (char_table_ref_and_range): Uncompress the compressed values.
990 (sub_char_table_set): New arg is_uniprop. Callers changed.
991 Uncompress the compressed values.
992 (sub_char_table_set_range): Args changed. Callers changed.
993 (char_table_set_range): Adjuted for the above change.
994 (map_sub_char_table): Delete args default_val and parent. Add arg
995 top. Give decoded values to a Lisp function.
996 (map_char_table): Adjusted for the above change. Give decoded
997 values to a Lisp function. Gcpro more variables.
998 (uniprop_table_uncompress)
999 (uniprop_decode_value_run_length): New functions.
1000 (uniprop_decoder, uniprop_decoder_count): New variables.
1001 (uniprop_get_decoder, uniprop_encode_value_character)
1002 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1003 New functions.
1004 (uniprop_encoder, uniprop_encoder_count): New variables.
1005 (uniprop_get_encoder, uniprop_table)
1006 (Funicode_property_table_internal, Fget_unicode_property_internal)
1007 (Fput_unicode_property_internal): New functions.
1008 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1009 Sunicode_property_table_internal, Sget_unicode_property_internal,
1010 and Sput_unicode_property_internal. Defvar_lisp
1011 char-code-property-alist.
1012
1013 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1014 Vunicode_category_table.
1015
1016 * font.c (font_range): Adjusted for the change of
1017 Vunicode_category_table.
1018
76b397fb
DN
10192011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1020
1021 * m/iris4d.h: Remove file, move contents ...
1022 * s/irix6-5.h: ... here.
1023
22b4128e
PE
10242011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1027 * alloc.c (mark_buffer):
1028 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1029 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1030 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1031 This isn't true in general, and it's particularly not true
1032 if Emacs is configured with --with-wide-int.
1033 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1034 New macros, used in the buffer.c change.
1035
869795d6
JD
10362011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1037
1038 * xsettings.c: Use both GConf and GSettings if both are available.
1039 (store_config_changed_event): Add comment.
1040 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1041 (store_tool_bar_style_changed): New functions.
1042 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1043 (struct xsettings): Move font inside HAVE_XFT.
1044 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1045 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1046 Move inside HAVE_XFT.
1047 (something_changed_gsettingsCB): Renamed from something_changedCB.
1048 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1049 also.
1050 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1051 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1052 (something_changed_gconfCB): Renamed from something_changedCB.
1053 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1054 (parse_settings): Move check for font inside HAVE_XFT.
1055 (read_settings, apply_xft_settings): Add comment.
1056 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1057 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1058 call store_font_name_changed.
1059 (xft_settings_event): Add comment.
1060 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1061 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1062 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1063 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1064 (xsettings_initialize): Call init_gsettings last.
1065 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1066 comment.
1067
d8ed26bd
PE
10682011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 Random fixes. E.g., (random) never returned negative values.
1071 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1072 subseconds part to the entropy, as that's a bit more random.
1073 Prefer signed to unsigned, since the signedness doesn't matter and
1074 in general we prefer signed. When given a limit, use a
1075 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1076 latter isn't right if USE_2_TAGS_FOR_INTS.
1077 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1078 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1079
cabf1cac
SM
10802011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1081
1082 * textprop.c (text_property_stickiness):
1083 Obey Vtext_property_default_nonsticky.
1084 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1085 * w32fns.c (syms_of_w32fns):
1086 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1087
6e9b2be9
PE
10882011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1091 This is more efficient than Ffile_directory_p and avoids a minor race.
1092
90186c68
LMI
10932011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1094
7c301272
LMI
1095 * buffer.c (Foverlay_put): Say what the return value is
1096 (bug#7835).
1097
c4f2d8d4
LMI
1098 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1099 is a directory before asking whether to use the file name
1100 (bug#7564).
ad637907
LMI
1101 (barf_or_query_if_file_exists): Make the "File is a directory"
1102 error be more correct.
c4f2d8d4 1103
90186c68
LMI
1104 * fns.c (Frequire): Remove the mention of the .gz files, since
1105 that's installation-specific, but keep the mention of
1106 `get-load-suffixes'.
1107
da64016e
PE
11082011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1111 Report string overflow if the output is too long.
1112
7d47b580
JB
11132011-07-04 Juanma Barranquero <lekktu@gmail.com>
1114
a555cb87
JB
1115 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1116 (syms_of_gnutls): Remove duplicate DEFSYM for
1117 Qgnutls_bootprop_verify_hostname_error, an error for
1118 Qgnutls_bootprop_verify_error (which is no longer used).
1119
7d47b580
JB
1120 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1121 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1122 Also (re)move comments that are misplaced or no longer relevant.
1123
1e49bfab
LMI
11242011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1125
1126 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1127
1485f4c0
CY
11282011-07-03 Chong Yidong <cyd@stupidchicken.com>
1129
1130 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1131 and background color parameters if they have been changed.
1132
a9ab721e
LMI
11332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1134
1135 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1136
cf7cff57
PE
11372011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1138
2e13213d
PE
1139 * xsettings.c (SYSTEM_FONT): Define only when used.
1140 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1141
cf7cff57
PE
1142 * keymap.c (access_keymap_1): Now static.
1143
7a8e04f7
CY
11442011-07-02 Chong Yidong <cyd@stupidchicken.com>
1145
1146 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1147 leave any prefix arg for the up event (Bug#1586).
1148
61352f62
LMI
11492011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1150
69bb1ef7
LMI
1151 * lread.c (syms_of_lread): Mention single symbols defined by
1152 `defvar' or `defconst' (bug#7154).
1153
61352f62 1154 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1155 (Frequire): Mention get-load-suffixes.
61352f62 1156
28545e04
MR
11572011-07-02 Martin Rudalics <rudalics@gmx.at>
1158
1159 * window.h (window): Remove clone_number slot.
1160 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1161 Remove.
1162 (make_parent_window, make_window, saved_window)
1163 (Fset_window_configuration, save_window_save): Don't deal with
1164 clone numbers.
1165 * buffer.c (Qclone_number): Remove declaration.
1166 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1167
3349e122
SM
11682011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1169
1170 Add multiple inheritance to keymaps.
1171 * keymap.c (Fmake_composed_keymap): New function.
1172 (Fset_keymap_parent): Simplify.
1173 (fix_submap_inheritance): Remove.
1174 (access_keymap_1): New function extracted from access_keymap to handle
1175 embedded parents and handle lists of maps.
1176 (access_keymap): Use it.
1177 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1178 (Fcopy_keymap): Handle embedded parents.
1179 (Fcommand_remapping, define_as_prefix): Simplify.
1180 (Fkey_binding): Simplify.
1181 (syms_of_keymap): Move minibuffer-local-completion-map,
1182 minibuffer-local-filename-completion-map,
1183 minibuffer-local-must-match-map, and
1184 minibuffer-local-filename-must-match-map to Elisp.
1185 (syms_of_keymap): Defsubr make-composed-keymap.
1186 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1187 (parse_menu_item): Trivial simplification.
1188
3279eb87
GM
11892011-07-01 Glenn Morris <rgm@gnu.org>
1190
1191 * Makefile.in (SETTINGS_LIBS): Fix typo.
1192
4550efdf
KI
11932011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1194
1195 * coding.c (Fencode_coding_string): Record the last coding system
1196 used, as the function doc string says (bug#8738).
1197
0949d2b6
JD
11982011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1199
1200 * xsettings.c (store_monospaced_changed): Take new font as arg and
1201 check for change against current_mono_font.
1202 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1203 (emacs_settings_constructor, emacs_settings_get_property)
1204 (emacs_settings_set_property, emacs_settings_class_init)
1205 (emacs_settings_init, gsettings_obj): Remove.
1206 (something_changedCB): New function for HAVE_GSETTINGS.
1207 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1208 with value as argument.
1209 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1210 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1211 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1212 "changed".
1213
1214 * xgselect.c: Add defined (HAVE_GSETTINGS).
1215 (xgselect_initialize): Ditto.
1216
1217 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1218 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1219 xg_select.
1220
bbc6b304
PE
12212011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * eval.c (struct backtrace): Simplify and port the data structure.
1224 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1225 signed bit field, as this assumption is not portable and it makes
1226 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1227 "char debug_on_exit : 1" as this is not portable either; instead,
1228 use the portable "unsigned int debug_on_exit : 1". Remove unused
1229 member evalargs. Remove obsolete comments about cc bombing out.
1230
9851bfc5
JD
12312011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1232
51bb811f 1233 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1234 Let HAVE_GSETTINGS override HAVE_GCONF.
1235 (store_monospaced_changed): New function.
1236 (EMACS_SETTINGS): A new type derived from GObject to handle
1237 GSettings notifications.
1238 (emacs_settings_constructor, emacs_settings_get_property)
1239 (emacs_settings_set_property, emacs_settings_class_init):
1240 New functions.
1241 (gsettings_client, gsettings_obj): New variables.
1242 (GSETTINGS_SCHEMA): New define.
1243 (something_changedCB): Call store_monospaced_changed.
1244 (init_gsettings): New function.
1245 (xsettings_initialize): Call init_gsettings.
1246 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1247 to NULL.
1248
1249 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1250 GCONF_CFLAGS/LIBS.
1251
5386012d
MR
12522011-06-29 Martin Rudalics <rudalics@gmx.at>
1253
1254 * window.c (resize_root_window, grow_mini_window)
1255 (shrink_mini_window): Rename Qresize_root_window to
1256 Qwindow_resize_root_window and Qresize_root_window_vertically to
1257 Qwindow_resize_root_window_vertically.
1258
f13e0b08
PE
12592011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1262
94515237
JB
12632011-06-27 Juanma Barranquero <lekktu@gmail.com>
1264
1265 * makefile.w32-in: Redesign dependencies so they reflect more
1266 clearly which files are directly included by each source file,
1267 and not through other includes.
1268
e43b6e43
MR
12692011-06-27 Martin Rudalics <rudalics@gmx.at>
1270
1271 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1272 (sort_overlays, overlay_strings): When an overlay's clone number
1273 matches the window's clone number process the overlay even if
1274 the overlay's window property doesn't match the current window.
1275
d68443dc
MR
1276 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1277 (Fwindow_hchild): Rename to Fwindow_left_child.
1278 (Fwindow_next): Rename to Fwindow_next_sibling.
1279 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1280 (resize_window_check): Rename to window_resize_check.
1281 (resize_window_apply): Rename to window_resize_apply.
1282 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1283 (Fdelete_other_windows_internal, resize_frame_windows)
1284 (Fsplit_window_internal, Fdelete_window_internal)
1285 (grow_mini_window, shrink_mini_window)
1286 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1287
c7e73be5
JD
12882011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1289
1290 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1291 (emacs_fixed_set_min_size): Remove.
1292 (emacs_fixed_new): Take frame as argument.
1293
1294 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1295 (_EmacsFixedPrivate): Remove minwidth/height.
1296 Add struct frame *f.
1297 (emacs_fixed_init): Initialize priv->f.
1298 (get_parent_class, emacs_fixed_set_min_size): Remove.
1299 (emacs_fixed_new): Set priv->f to argument.
1300 (emacs_fixed_get_preferred_width)
1301 (emacs_fixed_get_preferred_height): Use min_width/height from
1302 frames size_hint to set minimum and natural (Bug#8919).
1303 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1304 and use min_width/height from frames size_hint to set
1305 min_width/height (Bug#8919).
1306
1307 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1308 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1309 Fix indentation.
c7e73be5 1310
cf99dcf8
EZ
13112011-06-26 Eli Zaretskii <eliz@gnu.org>
1312
1313 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1314 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1315 called at ZV.
1316
029529ac
CY
13172011-06-26 Chong Yidong <cyd@stupidchicken.com>
1318
1319 * process.c (wait_reading_process_output): Bypass select if
1320 waiting for a cell while ignoring keyboard input, and input is
1321 pending. Suggested by Jan Djärv (Bug#8869).
1322
7a7ef429
PE
13232011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Use gnulib's dup2 module instead of rolling our own.
1326 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1327
11fdef7d 13282011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1329
1330 * dispnew.c (scrolling_window): Before scrolling, turn off a
1331 mouse-highlight in the window being scrolled.
1332
cd3520a4
JB
13332011-06-24 Juanma Barranquero <lekktu@gmail.com>
1334
1335 Move DEFSYM to lisp.h and use everywhere.
1336
1337 * character.h (DEFSYM): Move declaration...
1338 * lisp.h (DEFSYM): ...here.
1339
1340 * gnutls.c:
1341 * minibuf.c:
1342 * w32menu.c:
1343 * w32proc.c:
1344 * w32select.c: Don't include character.h.
1345
1346 * alloc.c (syms_of_alloc):
1347 * buffer.c (syms_of_buffer):
1348 * bytecode.c (syms_of_bytecode):
1349 * callint.c (syms_of_callint):
1350 * casefiddle.c (syms_of_casefiddle):
1351 * casetab.c (init_casetab_once):
1352 * category.c (init_category_once, syms_of_category):
1353 * ccl.c (syms_of_ccl):
1354 * cmds.c (syms_of_cmds):
1355 * composite.c (syms_of_composite):
1356 * dbusbind.c (syms_of_dbusbind):
1357 * dired.c (syms_of_dired):
1358 * dispnew.c (syms_of_display):
1359 * doc.c (syms_of_doc):
1360 * editfns.c (syms_of_editfns):
1361 * emacs.c (syms_of_emacs):
1362 * eval.c (syms_of_eval):
1363 * fileio.c (syms_of_fileio):
1364 * fns.c (syms_of_fns):
1365 * frame.c (syms_of_frame):
1366 * fringe.c (syms_of_fringe):
1367 * insdel.c (syms_of_insdel):
1368 * keymap.c (syms_of_keymap):
1369 * lread.c (init_obarray, syms_of_lread):
1370 * macros.c (syms_of_macros):
1371 * msdos.c (syms_of_msdos):
1372 * print.c (syms_of_print):
1373 * process.c (syms_of_process):
1374 * search.c (syms_of_search):
1375 * sound.c (syms_of_sound):
1376 * syntax.c (init_syntax_once, syms_of_syntax):
1377 * terminal.c (syms_of_terminal):
1378 * textprop.c (syms_of_textprop):
1379 * undo.c (syms_of_undo):
1380 * w32.c (globals_of_w32):
1381 * window.c (syms_of_window):
1382 * xdisp.c (syms_of_xdisp):
1383 * xfaces.c (syms_of_xfaces):
1384 * xfns.c (syms_of_xfns):
1385 * xmenu.c (syms_of_xmenu):
1386 * xsettings.c (syms_of_xsettings):
1387 * xterm.c (syms_of_xterm): Use DEFSYM.
1388
4228cf16
TZ
13892011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1390
cd3520a4 1391 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1392
7fcccf1e
PE
13932011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1394
7efb4e0e
PE
1395 Integer and buffer overflow fixes (Bug#8873).
1396
ff5844ad
PE
1397 * print.c (printchar, strout): Check for string overflow.
1398 (PRINTPREPARE, printchar, strout):
1399 Don't set size unless allocation succeeds.
1400
90532f02
PE
1401 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1402 for sizes. Check for string overflow more accurately.
1403 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1404
6d84508d
PE
1405 * macros.c: Integer and buffer overflow fixes.
1406 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1407 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1408 Use ptrdiff_t, not int, for sizes.
1409 Don't increment bufsize until after realloc succeeds.
1410 Check for size-calculation overflow.
1411 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1412
437b2cb4
PE
1413 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1414
8b9ac8b4
PE
1415 * lread.c: Integer overflow fixes.
1416 (read_integer): Radix is now EMACS_INT, not int,
1417 to improve quality of diagnostics for out-of-range radices.
1418 Calculate buffer size correctly for out-of-range radices.
1419 (read1): Check for integer overflow in radices, and in
1420 read-circle numbers.
82cb60d3
PE
1421 (read_escape): Avoid int overflow.
1422 (Fload, openp, read_buffer_size, read1)
1423 (substitute_object_recurse, read_vector, read_list, map_obarray):
1424 Use ptrdiff_t, not int, for sizes.
1425 (read1): Use EMACS_INT, not int, for sizes.
20270765 1426 Check for size overflow.
8b9ac8b4 1427
7fcccf1e
PE
1428 * image.c (cache_image): Check for size arithmetic overflow.
1429
bfbbd7e7
PE
1430 * lread.c: Integer overflow issues.
1431 (saved_doc_string_size, saved_doc_string_length)
1432 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1433 Now ptrdiff_t, not int.
1434 (read1): Don't assume doc string length fits in int. Check for
1435 out-of-range doc string lengths.
1436 (read_list): Don't assume file position fits in int.
39019e54 1437 (read_escape): Check for hex character overflow.
bfbbd7e7 1438
4e323265
LL
14392011-06-22 Leo Liu <sdl.web@gmail.com>
1440
1441 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1442 Move to minibuffer.el.
1443
85fece3e
PE
14442011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1445
20b84ce9 1446 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1447 The following patches are for when GLYPH_DEBUG && !XASSERT.
1448 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1449 * dispnew.c (flush_stdout):
1450 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1451 Mark as externally visible.
1452 * dispnew.c (check_window_matrix_pointers): Now static.
1453 * dispnew.c (window_to_frame_vpos):
1454 * xfns.c (unwind_create_frame):
1455 * xterm.c (x_check_font): Remove unused local.
1456 * scroll.c (CHECK_BOUNDS):
1457 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1458 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1459 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1460 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1461 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1462 Now static.
1463 (debug_method_add): Use va_list and vsprintf rather than relying
1464 on undefined behavior with wrong number of arguments.
1465 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1466 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1467 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1468 since we're not interested in debugging glyphs with old libraries.
1469 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1470 GCC 4.6.0's static checking.
1471
0766b489
PE
14722011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1473
31fd4b32
PE
1474 Integer overflow and signedness fixes (Bug#8873).
1475 A few related buffer overrun fixes, too.
1476
b79e8648
PE
1477 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1478
0766b489
PE
1479 * dispextern.h (struct face.stipple):
1480 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1481 (x_bitmap_mask, x_allocate_bitmap_record)
1482 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1483 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1484 (x_create_bitmap_from_xpm_data):
1485 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1486 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1487 (.bitmaps_last):
1488 * xfaces.c (load_pixmap):
1489 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1490 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1491 (.bitmaps_last, struct x_output.icon_bitmap):
1492 Use ptrdiff_t, not int, for bitmap indexes.
1493 (x_allocate_bitmap_record): Check for size overflow.
1494 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1495
b081724f
PE
1496 Use ptrdiff_t, not int, for overlay counts.
1497 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1498 * editfns.c (overlays_around, get_pos_property):
1499 * textprop.c (get_char_property_and_overlay):
1500 * xdisp.c (next_overlay_change, note_mouse_highlight):
1501 * xfaces.c (face_at_buffer_position):
21514da7
PE
1502 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1503 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1504 (Fnext_overlay_change, Fprevious_overlay_change)
1505 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1506 Use ptrdiff_t, not int, for sizes.
21514da7 1507 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1508
3de73e5e
PE
1509 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1510
2606c57b
PE
1511 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1512 (x_session_initialize): Do not assume string length fits in int.
1513
aaafe47a
PE
1514 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1515 This is unlikely, but can occur if DPI is outlandish.
1516
2674ddc8 1517 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1518 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1519
28154962
PE
1520 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1521 * xrdb.c (magic_file_p, search_magic_path):
1522 Omit last arg SUFFIX; it was always 0. All callers changed.
1523 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1524
7de51af5
PE
1525 * xfont.c (xfont_match): Avoid need for strlen.
1526
25ed6cc3
PE
1527 * xfns.c: Don't assume strlen fits in int.
1528 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1529
4eab31dd
PE
1530 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1531 not unsigned long, as we prefer signed integers. All callers changed.
1532 Detect integer overflow in repeat count.
1533 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1534 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1535
171e2a58
PE
1536 * termcap.c: Don't assume sizes fit in int and never overflow.
1537 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1538 (gobble_line): Check for size-calculation overflow.
1539
ad39faca 1540 * minibuf.c (Fread_buffer):
6e5bb2dc 1541 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1542 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1543 Don't assume string length fits in int.
1544
52c61c22 1545 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1546 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1547
b5b8c9e5
PE
1548 * font.c: Don't assume string length fits in int.
1549 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1550 Use ptrdiff_t, not int.
ccd6111c
PE
1551 (font_intern_prop): Don't assume string length fits in int.
1552 Don't assume integer property fits in fixnum.
1553 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1554
882f0d81 1555 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1556 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1557 Reformulate so as not to need the command string.
1558 Invoke gzip -cd rather than gunzip, as it's more portable.
1559 (lock_info_type, lock_file_1, lock_file):
1560 Don't assume pid_t and time_t fit in unsigned long.
1561 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1562 (current_lock_owner): Prefer signed type for sizes.
1563 Use memcpy, not strncpy, where memcpy is what is really wanted.
1564 Don't assume (via atoi) that time_t and pid_t fit in int.
1565 Check for time_t and/or pid_t out of range, e.g., via a network share.
1566 Don't alloca where an auto var works fine.
1567
93f4cf88
PE
1568 * fileio.c: Fix some integer overflow issues.
1569 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1570 Don't assume string length fits in int.
1571 (directory_file_name): Don't assume string length fits in long.
1572 (make_temp_name): Don't assume pid fits in int, or that its print
1573 length is less than 20.
1574
f3e92b69
PE
1575 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1576
1bfdaf10
PE
1577 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1578
35016e9a
PE
1579 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1580
3d1e65a1
PE
1581 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1582 We prefer signed integers, even for size calculations.
1583
0b963a93
PE
1584 * emacs.c: Don't assume string length fits in 'int'.
1585 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1586 (main): Don't invoke strlen when not needed.
1587
573f4b54
PE
1588 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1589 (XD_DEBUG_MESSAGE): Don't waste a byte.
1590
989f33ba
PE
1591 * callproc.c (getenv_internal_1, getenv_internal)
1592 (Fgetenv_internal):
965d34eb
PE
1593 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1594
e4d29b33
PE
1595 * lread.c (invalid_syntax): Omit length argument.
1596 All uses changed. This doesn't fix a bug, but it simplifies the
1597 code away from its former Hollerith-constant appearance, and it's
1598 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1599 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1600
eb49b136
PE
1601 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1602 This didn't break anything, but it didn't help either.
1603 It's confusing to put a bogus integer in a place where the actual
1604 value does not matter.
9f62aeb1 1605 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1606 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1607
15375a22
PE
1608 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1609 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1610 implementation.
b61cc01c
PE
1611 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1612 We prefer signed types, and the value cannot exceed the EMACS_INT
1613 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1614 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1615 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1616 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1617
53b2623d
PE
1618 * indent.c (sane_tab_width): New function.
1619 (current_column, scan_for_column, Findent_to, position_indentation)
1620 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1621 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1622
51cab52b 1623 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1624
f2ed8a70
PE
1625 * lisp.h (lint_assume): New macro.
1626 * composite.c (composition_gstring_put_cache):
1627 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1628
abe80cc6
PE
1629 * editfns.c, insdel.c:
1630 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1631
b02c740e
PE
1632 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1633
ebc96716
PE
1634 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1635
b4e50fa0 1636 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1637 Use much-faster test for byte-length change.
311d5d7c 1638 Don't assume string byte-length fits in 'int'.
a4cf38e4 1639 Check that character arg fits in 'int'.
85461888 1640 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1641
c0c1ee9f
PE
1642 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1643
a498d7f4
PE
1644 * fns.c (concat): Catch string overflow earlier.
1645 Do not rely on integer wraparound.
1646
51cab52b
PE
1647 * dispextern.h (struct it.overlay_strings_charpos)
1648 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1649 * xdisp.c (forward_to_next_line_start)
1650 (back_to_previous_visible_line_start)
1651 (reseat_at_next_visible_line_start, next_element_from_buffer):
1652 Don't arbitrarily truncate the value of 'selective' to int.
1653
76031fad
PE
1654 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1655
5eb55db9
PE
1656 * composite.c: Don't truncate sizes to 'int'.
1657 (composition_gstring_p, composition_reseat_it)
1658 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1659 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1660 not EMACS_UINT, for indexes.
5eb55db9 1661
0703a717
PE
1662 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1663
d6202519
PE
1664 * buffer.c: Include <verify.h>.
1665 (struct sortvec.priority, struct sortstr.priority):
8961a454 1666 Now EMACS_INT, not int.
c20998a7 1667 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1668 (struct sortstr.size, record_overlay_string)
1669 (struct sortstrlist.size, struct sortlist.used):
1670 Don't truncate size to int.
1671 (record_overlay_string): Check for size-calculation overflow.
d6202519 1672 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1673
d5a19415
JM
16742011-06-22 Jim Meyering <meyering@redhat.com>
1675
029529ac 1676 Don't leak an XBM-image-sized buffer
d5a19415
JM
1677 * image.c (xbm_load): Free the image buffer after using it.
1678
a9041e6c
PE
16792011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 Port to Sun C.
1682 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1683 that Sun C diagnosed.
1684 * fns.c (secure_hash): Fix pointer signedness issue.
1685 * intervals.c (static_offset_intervals): New function.
1686 (offset_intervals): Use it.
1687
7f3f739f
LL
16882011-06-21 Leo Liu <sdl.web@gmail.com>
1689
1690 * deps.mk (fns.o):
1691 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1692 sha512.h.
1693
1694 * fns.c (secure_hash): Rename from crypto_hash_function and change
1695 the first arg to accept symbols.
5b66d427 1696 (Fsecure_hash): New primitive.
7f3f739f
LL
1697 (syms_of_fns): New symbols.
1698
76147d94
DD
16992011-06-20 Deniz Dogan <deniz@dogan.se>
1700
1701 * process.c (Fset_process_buffer): Clarify return value in
1702 docstring.
1703
7d7d0045
CY
17042011-06-18 Chong Yidong <cyd@stupidchicken.com>
1705
1706 * dispnew.c (add_window_display_history): Use BVAR.
1707
1708 * xdisp.c (debug_method_add): Use BVAR.
1709 (check_window_end, dump_glyph_matrix, dump_glyph)
1710 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1711
1712 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1713 Likewise.
1714
1715 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1716 check till after the cache is created in init_frame_faces.
1717
ff2bc410
SM
17182011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1719
1720 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1721
28177add
PE
17222011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1723
dd3482fe
PE
1724 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1725 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1726 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1727
393d71f3 1728 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1729 * fileio.c (Finsert_file_contents):
1730 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1731 Remove the old (too-loose) buffer overflow checks.
1732 They weren't needed, since make_gap checks for buffer overflow.
1733 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1734 The old code merely checked for Emacs fixnum overflow, and relied
1735 on undefined (wraparound) behavior. The new code avoids undefined
1736 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1737
2e6813b0 1738 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1739 Tune. Don't use wider integers than needed. Don't use alloca.
1740 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1741
599a9e4f
PE
1742 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1743
99561444
PE
1744 * insdel.c, lisp.h (buffer_overflow): New function.
1745 (insert_from_buffer_1, replace_range, replace_range_2):
1746 * insdel.c (make_gap_larger):
1747 * editfns.c (Finsert_char):
1748 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1749
28177add
PE
1750 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1751
e69dafad
PE
17522011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1753
a7af7fde 1754 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1755
b1c46f02
PE
1756 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1757 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1758
e69dafad
PE
1759 * fileio.c: Don't assume EMACS_INT fits in off_t.
1760 (emacs_lseek): New static function.
1761 (Finsert_file_contents, Fwrite_region): Use it.
1762 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1763
566684ea
PE
1764 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1765
e6966cd6
PE
1766 * fns.c: Don't overflow int when computing a list length.
1767 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1768 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1769 truncation on 64-bit hosts. Check for QUIT every
1770 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1771 faster and is responsive enough.
1772 (Flength): Report an error instead of overflowing an integer.
1773 (Fsafe_length): Return a float if the value is not representable
1774 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1775 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1776 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1777
dd0b0efb
PE
1778 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1779 (header_size, word_size): New constants.
1780 (allocate_vectorlike): Don't check size overflow here.
1781 (allocate_vector): Check it here instead, since this is the only
1782 caller of allocate_vectorlike that could cause overflow.
1783 Check that the new vector's length is representable as a fixnum.
1784
86fe5cfe
PE
1785 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1786 The previous code was bogus. For example, next_almost_prime (32)
1787 returned 39, which is undesirable as it is a multiple of 3; and
1788 next_almost_prime (24) returned 25, which is a multiple of 5 so
1789 why was the code bothering to check for multiples of 7?
1790
80e88859
PE
1791 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1792
4a2f0ad6
PE
1793 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1794
f66c7cf8
PE
1795 Variadic C functions now count arguments with ptrdiff_t.
1796 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1797 Back then I didn't know that the Emacs coding style prefers signed int.
1798 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1799 were being counted with int, which may truncate counts on 64-bit
1800 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1801 * lisp.h (struct Lisp_Subr.function.aMANY)
1802 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1803 Arg counts are now ptrdiff_t, not size_t.
1804 All variadic functions and their callers changed accordingly.
1805 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1806 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1807 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1808 * callint.c (Fcall_interactively): Check arg count for overflow,
1809 to avoid potential buffer overrun. Use signed char, not 'int',
1810 for 'varies' array, so that we needn't bother to check its size
1811 calculation for overflow.
1812 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1813 * eval.c (apply_lambda):
1814 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1815 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1816 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1817
a1759b76
PE
1818 * callint.c (Fcall_interactively): Don't use index var as event count.
1819
d96be9fc
PE
1820 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1821 * mem-limits.h (SIZE): Remove; no longer used.
1822
a690a978 1823 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1824
578c21e6
PE
1825 Remove unnecessary casts.
1826 * xterm.c (x_term_init):
1827 * xfns.c (x_set_border_pixel):
1828 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1829 These aren't needed now that we assume ANSI C.
1830
96f53c6c
PE
1831 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1832 It's more likely to cause problems (due to unsigned overflow)
1833 than to cure them.
1834
83c77d31
PE
1835 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1836
ee2079f1
PE
1837 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1838
6da65536
PE
1839 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1840
7147c4a4
PE
1841 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1842
193e32d9
PE
1843 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1844
e5533da6
PE
1845 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1846
9910e595
PE
1847 GLYPH_CODE_FACE returns EMACS_INT, not int.
1848 * dispextern.h (merge_faces):
1849 * xfaces.c (merge_faces):
01103c44
PE
1850 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1851 Don't assume EMACS_INT fits in int.
9910e595 1852
2638320e
PE
1853 * character.h (CHAR_VALID_P): Remove unused parameter.
1854 * fontset.c, lisp.h, xdisp.c: All uses changed.
1855
045eb8d9
PE
1856 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1857
c1f134b5
PE
1858 * fns.c (concat): Minor tuning based on overflow analysis.
1859 This doesn't fix any bugs. Use int to hold character, instead
1860 of constantly refetching from Emacs object. Use XFASTINT, not
1861 XINT, for value known to be a character. Don't bother comparing
1862 a single byte to 0400, as it's always less.
1863
395fcb93 1864 * floatfns.c (Fexpt):
327eeec8
PE
1865 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1866
abbd3d23
PE
1867 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1868 for characters.
1869
684a03ef
PE
1870 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1871
0fed43f3
PE
1872 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1873 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1874 incorrectly succeed when S was a string, because 4294967386 was
1875 truncated before it was used.
1876
8fd02eb7
PE
1877 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1878 Otherwise, an out-of-range integer could cause undefined behavior
1879 on a 64-bit host.
1880
f8c86b69
PE
1881 * composite.c: Use int, not EMACS_INT, for characters.
1882 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1883 EMACS_INT, for values that are known to be in character range.
1884 This doesn't fix any bugs but is the usual style inside Emacs and
1885 may generate better code on 32-bit machines.
1886
34206dd2
PE
1887 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1888 This is for reasons similar to the recent CHAR_STRING fix.
1889 * charset.c (Fencode_char): Check that character arg is actually
1890 a character. Pass an int to ENCODE_CHAR.
1891 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1892 wider than 'int', as a compile-time check to prevent future regressions
1893 in this area.
1894
c5958d4c 1895 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1896
1897 Make sure a 64-bit char is never passed to CHAR_STRING.
1898 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1899 by silently ignoring the top 32 bits, allowing some values
1900 that were far too large to be valid characters.
1901 * character.h: Include <verify.h>.
1902 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1903 arguments are no wider than unsigned, as a compile-time check
1904 to prevent future regressions in this area.
1905 * data.c (Faset):
01103c44 1906 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1907 (Fsubst_char_in_region):
1908 * fns.c (concat):
1909 * xdisp.c (decode_mode_spec_coding):
1910 Adjust to CHAR_STRING's new requirement.
1911 * editfns.c (Finsert_char, Fsubst_char_in_region):
1912 * fns.c (concat): Check that character args are actually
1913 characters. Without this test, these functions did the wrong
1914 thing with wildly out-of-range values on 64-bit hosts.
1915
d37ca623
PE
1916 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1917 These casts should not be needed on 32-bit hosts, either.
1918 * keyboard.c (read_char):
1919 * lread.c (Fload): Remove casts to unsigned.
1920
ea204efb
PE
1921 * lisp.h (UNSIGNED_CMP): New macro.
1922 This fixes comparison bugs on 64-bit hosts.
1923 (ASCII_CHAR_P): Use it.
1924 * casefiddle.c (casify_object):
01103c44 1925 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1926 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1927 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1928 * dispextern.h (FACE_FROM_ID):
1929 * keyboard.c (read_char): Use UNSIGNED_CMP.
1930
41cb286c
PE
1931 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1932 not to EMACS_INT, to avoid GCC warning.
1933
4a1b9832
PE
1934 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1935
55daad71
PE
1936 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1937 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1938 isn't needed on 32-bit machines.
8f95c75c 1939
01103c44
PE
1940 * buffer.c (Fgenerate_new_buffer_name):
1941 Use EMACS_INT for count, not int.
0ceccced 1942 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1943
1944 * data.c (Qcompiled_function): Now static.
1945
c6f072e7
PE
1946 * window.c (window_body_lines): Now static.
1947
20ce5912
PE
1948 * image.c (gif_load): Rename local to avoid shadowing.
1949
9c4c5f81
PE
1950 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1951 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1952 * alloc.c (make_save_value): Integer argument is now of type
1953 ptrdiff_t, not int.
1954 (mark_object): Use ptrdiff_t, not int.
1955 * lisp.h (pD): New macro.
1956 * print.c (print_object): Use it.
1957
c0c5c8ae
PE
1958 * alloc.c: Use EMACS_INT, not int, to count objects.
1959 (total_conses, total_markers, total_symbols, total_vector_size)
1960 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1961 (total_free_floats, total_floats, total_free_intervals)
1962 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1963 Now EMACS_INT, not int. All uses changed.
1964 (Fgarbage_collect): Compute overall total using a double, so that
1965 integer overflow is less likely to be a problem. Check for overflow
1966 when converting back to an integer.
5a25e253
PE
1967 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1968 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1969 These were 'int' variables that could overflow on 64-bit hosts;
1970 they were never used, so remove them instead of repairing them.
211a0b2a 1971 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1972 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1973 Previously, this ceilinged at INT_MAX, but that doesn't work on
1974 64-bit machines.
e46bb31a 1975 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1976
c78baabf 1977 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1978 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1979 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1980 when a (possibly-narrower) signed value would do just as well.
1981 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1982
c9d624c6
PE
1983 * alloc.c: Catch some string size overflows that we were missing.
1984 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1985 for convenience in STRING_BYTES_MAX.
1986 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1987 The definition here is exact; the one in lisp.h was approximate.
1988 (allocate_string_data): Check for string overflow. This catches
1989 some instances we weren't catching before. Also, it catches
1990 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1991 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1992 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1993
c9d624c6
PE
1994 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1995 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1996 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1997
353032ce
PE
1998 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1999
2bccce07
PE
2000 * alloc.c (Fmake_string): Check for out-of-range init.
2001
0ac30604
SM
20022011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2003
2004 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2005
c195f2de
JD
20062011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2007
2008 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2009 xg_get_default_scrollbar_width.
2010
2011 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2012 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2013 (style_changed_cb): Call update_theme_scrollbar_width and call
2014 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2015 all frames (Bug#8505).
2016 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2017 Call gtk_window_set_resizable if HAVE_GTK3.
2018 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2019 and height if HAVE_GTK3 (Bug#8505).
2020 (scroll_bar_width_for_theme): New variable.
2021 (update_theme_scrollbar_width): New function.
2022 (xg_get_default_scrollbar_width): Move code to
2023 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2024 (xg_initialize): Call update_theme_scrollbar_width.
2025
2026 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2027
2028 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2029
e10ac9f1
MR
20302011-06-12 Martin Rudalics <rudalics@gmx.at>
2031
2032 * frame.c (make_frame): Call other_buffer_safely instead of
2033 other_buffer.
2034
2035 * window.c (temp_output_buffer_show): Call display_buffer with
2036 second argument Vtemp_buffer_show_specifiers and reset latter
2037 immediately after the call.
2038 (Vtemp_buffer_show_specifiers): New variable.
2039 (auto_window_vscroll_p, next_screen_context_lines)
2040 (Vscroll_preserve_screen_position): Remove leading asterisks from
2041 doc-strings.
2042
2d3c217e 20432011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2044
7b7f97e8 2045 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2046 * buffer.c (Qclone_number): Remove for now, as it's unused.
2047 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2048 (record_buffer): Remove unused local.
2049 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2050 (set_frame_buffer_list): Remove; unused.
2051 * frame.h (other_visible_frames): Remove decl.
2052 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2053 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2054 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2055 if HAVE_GPM.
2056 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2057 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2058 Define only if HAVE_GPM.
2059 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2060 (update_hints_inhibit): Remove; never set. All uses removed.
2061 * widgetprv.h (emacsFrameClassRec): Remove decl.
2062 * window.c (delete_deletable_window): Now returns void, since it
2063 wasn't returning anything.
2064 (compare_window_configurations): Remove unused locals.
2065 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2066 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2067 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2068 the same widths as pointers. This follows up on the 2011-05-06 patch.
2069 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2070 * xterm.h: Likewise.
2071 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2072
1384b89e
JB
20732011-06-12 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * makefile.w32-in: Update dependencies.
2076 (LISP_H): Add lib/intprops.h.
2077
1100a63c
CY
20782011-06-11 Chong Yidong <cyd@stupidchicken.com>
2079
2080 * image.c (gif_load): Add animation frame delay to the metadata.
2081 (syms_of_image): Use DEFSYM. New symbol `delay'.
2082
6198ccd0
MR
20832011-06-11 Martin Rudalics <rudalics@gmx.at>
2084
2085 * window.c (delete_deletable_window): Re-add.
2086 (Fset_window_configuration): Rewrite to handle dead buffers and
2087 consequently deletable windows.
2088 (window_tree, Fwindow_tree): Remove. Supply functionality in
2089 window.el.
2090 (compare_window_configurations): Simplify code.
2091
b6e3633c
AS
20922011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2093
1ab0dee5
AS
2094 * image.c (imagemagick_load_image): Fix type mismatch.
2095 (Fimagemagick_types): Likewise.
2096
b6e3633c
AS
2097 * window.h (replace_buffer_in_windows): Declare.
2098
9397e56f
MR
20992011-06-11 Martin Rudalics <rudalics@gmx.at>
2100
2101 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2102 Qclone_number. Remove external declaration of Qdelete_window.
2103 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2104 code.
2105 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2106 Qbuffer_list_update_hook if allowed.
2107 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2108 buffer list implementation.
2109 (other_buffer_safely): New function.
2110 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2111 calls to replace_buffer_in_windows and
2112 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2113 if allowed.
2114 (record_buffer): Inhibit quitting and rewrite using quittable
2115 functions. Run Qbuffer_list_update_hook if allowed.
2116 (Frecord_buffer, Funrecord_buffer): New functions.
2117 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2118 switch-to-buffer to window.el.
2119 (bury-buffer): Move to window.el.
2120 (Vbuffer_list_update_hook): New variable.
2121
2122 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2123 section.
2124
2125 * window.h (resize_frame_windows): Move up in code.
2126 (Fwindow_frame): Remove EXFUN.
2127 (replace_buffer_in_all_windows): Remove prototype.
2128 (replace_buffer_in_windows_safely): Add prototype.
2129
2130 * window.c: Declare Qdelete_window static again. Move down
2131 declaration of select_count.
2132 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2133 (Fother_window): Move to window.el.
2134 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2135 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2136 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2137 window.el.
2138 (replace_buffer_in_windows): Implement by calling
2139 Qreplace_buffer_in_windows.
2140 (replace_buffer_in_all_windows): Remove with some functionality
2141 moved into replace_buffer_in_windows_safely.
2142 (replace_buffer_in_windows_safely): New function.
2143 (select_window_norecord, select_frame_norecord): Move in front
2144 of run_window_configuration_change_hook. Remove now obsolete
2145 declarations.
2146 (Fset_window_buffer): Rewrite doc-string. Call
2147 Qrecord_window_buffer.
2148 (keys_of_window): Move binding for other-window to window.el.
2149
b50691aa
CY
21502011-06-11 Chong Yidong <cyd@stupidchicken.com>
2151
2152 * dispextern.h (struct image): Replace data member, whose int_val
2153 and ptr_val fields were not used by anything, with a single
2154 lisp_val object.
2155
2156 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2157 (gif_clear_image, gif_load, imagemagick_load_image)
2158 (gs_clear_image, gs_load): Callers changed.
2159
3f754b86
PE
21602011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2161
cca69397
PE
2162 * buffer.h: Include <time.h>, for time_t.
2163 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2164
109e28d0
PE
2165 Fix minor problems found by static checking.
2166
60737f02
PE
2167 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2168
4b66faf3
PE
2169 Make identifiers static if they are not used in other modules.
2170 * data.c (Qcompiled_function, Qframe, Qvector):
2171 * image.c (QimageMagick, Qsvg):
2172 * minibuf.c (Qmetadata):
2173 * window.c (resize_window_check, resize_root_window): Now static.
2174 * window.h (resize_window_check, resize_root_window): Remove decls.
2175
109e28d0
PE
2176 * window.c (window_deletion_count, delete_deletable_window):
2177 Remove; unused.
46a4ce9e
PE
2178 (window_body_lines): Now static.
2179 (Fdelete_other_windows_internal): Mark vars as initialized.
2180 Make sure 'resize_failed' is initialized.
2181 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2182 (resize_window_apply): Remove unused local.
2183 * window.h (delete_deletable_window): Remove decl.
2184
109e28d0 2185 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2186 (imagemagick_load_image): Fix pointer signedness problem by changing
2187 last arg from unsigned char * to char *. All uses changed.
2188 Also, fix a local for similar reasons.
2189 Remove unused locals. Remove locals to avoid shadowing.
2190 (fn_rsvg_handle_free): Remove; unused.
2191 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2192 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2193
3f754b86
PE
2194 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2195
2547adb1
CY
21962011-06-10 Chong Yidong <cyd@stupidchicken.com>
2197
2198 * image.c (gif_load): Fix omitted cast error introduced by
2199 2011-06-06 change.
2200
2c8e37d4
MR
22012011-06-10 Martin Rudalics <rudalics@gmx.at>
2202
2203 * window.h (resize_proportionally, orig_total_lines)
2204 (orig_top_line): Remove from window structure.
2205 (set_window_height, set_window_width, change_window_heights)
2206 (Fdelete_window): Remove prototypes.
2207 (resize_frame_windows): Remove duplicate declaration.
2208
440a42e3
EZ
22092011-06-10 Eli Zaretskii <eliz@gnu.org>
2210
2211 * window.h (resize_frame_windows, resize_window_check)
2212 (delete_deletable_window, resize_root_window)
2213 (resize_frame_windows): Declare prototypes.
2214
2215 * window.c (resize_window_apply): Make definition be "static" to
2216 match the prototype.
2217
562dd5e9
MR
22182011-06-10 Martin Rudalics <rudalics@gmx.at>
2219
2220 * window.c: Remove declarations of Qwindow_size_fixed,
2221 window_min_size_1, window_min_size_2, window_min_size,
2222 size_window, window_fixed_size_p, enlarge_window, delete_window.
2223 Remove static from declaration of Qdelete_window, it's
2224 temporarily needed by Fbury_buffer.
2225 (replace_window): Don't assign orig_top_line and
2226 orig_total_lines.
2227 (Fdelete_window, delete_window): Remove. Window deletion is
2228 handled by window.el.
2229 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2230 Fdelete_window calls with calls to Qdelete_window.
2231 (Fdelete_other_windows): Remove. Deleting other windows is
2232 handled by window.el.
2233 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2234 handled in window.el.
2235 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2236 Window minimum sizes are handled in window.el.
2237 (shrink_windows, size_window, set_window_height)
2238 (set_window_width, change_window_heights, window_height)
2239 (window_width, CURBEG, CURSIZE, enlarge_window)
2240 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2241 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2242 handled in window.el.
2243 (make_dummy_parent): Rename to make_parent_window and give it a
2244 second argument horflag.
2245 (make_window): Don't set resize_proportionally any more.
2246 (Fsplit_window): Remove. Windows are split in window.el.
2247 (save_restore_action, save_restore_orig_size)
2248 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2249 Resize mini windows in window.el.
2250 (grow_mini_window, shrink_mini_window): Implement by calling
2251 Qresize_root_window_vertically, resize_window_check and
2252 resize_window_apply.
2253 (saved_window, Fset_window_configuration, save_window_save): Do
2254 not handle orig_top_line, orig_total_lines, and
2255 resize_proportionally.
2256 (window_min_height, window_min_width): Move to window.el.
2257 (keys_of_window): Move bindings for delete-other-windows,
2258 split-window, delete-window and enlarge-window to window.el.
2259
2260 * buffer.c: Temporarily extern Qdelete_window.
2261 (Fbury_buffer): Temporarily call Qdelete_window instead of
2262 Fdelete_window (Fbury_buffer will move to window.el soon).
2263
2264 * frame.c (set_menu_bar_lines_1): Remove code handling
2265 orig_top_line and orig_total_lines.
2266
2267 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2268 set_window_height but set heights directly.
2269 (change_frame_size_1): Use resize_frame_windows.
2270
2271 * xdisp.c (init_xdisp): Don't use set_window_height but set
2272 heights directly.
2273
2274 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2275 resize_frame_windows instead of change_window_heights and run
2276 run_window_configuration_change_hook.
2277
2278 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2279 instead of change_window_heights and run
2280 run_window_configuration_change_hook.
2281
1a13852e
MR
22822011-06-09 Martin Rudalics <rudalics@gmx.at>
2283
2284 * window.c (replace_window): Rename second argument REPLACEMENT to
2285 NEW. New third argument SETFLAG. Rewrite.
2286 (delete_window, make_dummy_parent): Call replace_window with
2287 third argument 1.
2288 (window_list_1): Move down in code.
2289 (run_window_configuration_change_hook): Move set_buffer part
2290 before select_frame_norecord part in order to unwind correctly.
2291 Rename count1 to count.
2292 (recombine_windows, delete_deletable_window, resize_root_window)
2293 (Fdelete_other_windows_internal)
2294 (Frun_window_configuration_change_hook, make_parent_window)
2295 (resize_window_check, resize_window_apply, Fresize_window_apply)
2296 (resize_frame_windows, Fsplit_window_internal)
2297 (Fdelete_window_internal, Fresize_mini_window_internal): New
2298 functions.
2299 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2300
f3d1777e
MR
23012011-06-08 Martin Rudalics <rudalics@gmx.at>
2302
496e208e
MR
2303 * window.h (window): Add some new members to window structure -
2304 normal_lines, normal_cols, new_total, new_normal, clone_number,
2305 splits, nest, prev_buffers, next_buffers.
2306 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2307 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2308
f3d1777e
MR
2309 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2310 Remove.
496e208e
MR
2311 (make_dummy_parent): Set new members of windows structure.
2312 (make_window): Move down in code. Handle new members of window
2313 structure.
2314 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2315 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2316 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2317 (Fset_window_prev_buffers, Fwindow_next_buffers)
2318 (Fset_window_next_buffers, Fset_window_clone_number): New
2319 functions.
2320 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2321 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2322 Doc-string fixes.
2323 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2324 Argument WINDOW can be now internal window too.
2325 (Fwindow_use_time): Move up in code.
2326 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2327 Rewrite doc-string.
2328 (Fset_window_configuration, saved_window)
2329 (Fcurrent_window_configuration, save_window_save): Handle new
2330 members of window structure.
b9e809c2
MR
2331 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2332 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2333 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2334 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2335 Qget_mru_window, Qresize_root_window,
2336 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2337 Qauto_buffer_name; staticpro them.
f3d1777e 2338
abde8f8c
MR
23392011-06-07 Martin Rudalics <rudalics@gmx.at>
2340
2341 * window.c (Fwindow_total_size, Fwindow_left_column)
2342 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2343 (Fwindow_list_1): New functions.
2344 (window_box_text_cols): Replace with window_body_cols.
2345 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2346 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2347 (delete_window, Fset_window_configuration): Call
2348 delete_all_subwindows with window as argument.
2349 (delete_all_subwindows): Take a window as argument and not a
2350 structure. Rewrite.
190b47e6
MR
2351 (window_loop): Remove handling of GET_LRU_WINDOW and
2352 GET_LARGEST_WINDOW.
2353 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2354
2355 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2356 window_box_text_cols. delete_all_subwindows now takes a
2357 Lisp_Object as argument.
abde8f8c
MR
2358
2359 * indent.c (compute_motion, Fcompute_motion): Use
2360 window_body_cols instead of window_box_text_cols.
2361
fa8a67e6
MR
2362 * frame.c (delete_frame): Call delete_all_subwindows with root
2363 window as argument.
2364
a54e3482
DC
23652011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2366
2367 * fns.c (Fputhash): Document return value.
2368
60002bf5
CY
23692011-06-06 Chong Yidong <cyd@stupidchicken.com>
2370
2371 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2372
0c671da6 23732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2374
b862a52a 2375 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2376
be44ca6c
PE
2377 Check for overflow when converting integer to cons and back.
2378 * charset.c (Fdefine_charset_internal, Fdecode_char):
2379 Use cons_to_unsigned to catch overflow.
2380 (Fencode_char): Use INTEGER_TO_CONS.
2381 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2382 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2383 * data.c (long_to_cons, cons_to_long): Remove.
2384 (cons_to_unsigned, cons_to_signed): New functions.
2385 These signal an error for invalid or out-of-range values.
2386 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2387 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2388 * font.c (Ffont_variation_glyphs):
2389 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2390 * lisp.h: Include <intprops.h>.
2391 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2392 (cons_to_signed, cons_to_unsigned): New decls.
2393 (long_to_cons, cons_to_long): Remove decls.
2394 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2395 (Fprimitive_undo): Use CONS_TO_INTEGER.
2396 * xfns.c (Fx_window_property): Likewise.
2397 * xselect.c: Include <limits.h>.
2398 (x_own_selection, selection_data_to_lisp_data):
2399 Use INTEGER_TO_CONS.
2400 (x_handle_selection_request, x_handle_selection_clear)
2401 (x_get_foreign_selection, Fx_disown_selection_internal)
2402 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2403 (lisp_data_to_selection_data): Use cons_to_unsigned.
2404 (x_fill_property_data): Use cons_to_signed.
2405 Report values out of range.
2406
d1f3d2af
PE
2407 Check for buffer and string overflow more precisely.
2408 * buffer.h (BUF_BYTES_MAX): New macro.
2409 * lisp.h (STRING_BYTES_MAX): New macro.
2410 * alloc.c (Fmake_string):
2411 * character.c (string_escape_byte8):
2412 * coding.c (coding_alloc_by_realloc):
2413 * doprnt.c (doprnt):
2414 * editfns.c (Fformat):
2415 * eval.c (verror):
2416 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2417 since they may not be the same number.
2418 * editfns.c (Finsert_char):
2419 * fileio.c (Finsert_file_contents):
2420 Likewise for BUF_BYTES_MAX.
2421
dd52fcea
PE
2422 * image.c: Use ptrdiff_t, not int, for sizes.
2423 (slurp_file): Switch from int to ptrdiff_t.
2424 All uses changed.
2425 (slurp_file): Check that file size fits in both size_t (for
2426 malloc) and ptrdiff_t (for sanity and safety).
2427
7f9bbdbb
PE
2428 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2429 if b->modtime has its maximal value.
2430
dfe18f82
PE
2431 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2432
84acfcf0
PE
2433 Don't assume time_t can fit into int.
2434 * buffer.h (struct buffer.modtime): Now time_t, not int.
2435 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2436 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2437
ccd9a01a
PE
2438 Minor fixes for signed vs unsigned integers.
2439 * character.h (MAYBE_UNIFY_CHAR):
2440 * charset.c (maybe_unify_char):
2441 * keyboard.c (read_char, reorder_modifiers):
2442 XINT -> XFASTINT, since the integer must be nonnegative.
2443 * ftfont.c (ftfont_spec_pattern):
2444 * keymap.c (access_keymap, silly_event_symbol_error):
2445 XUINT -> XFASTINT, since the integer must be nonnegative.
2446 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2447 since it makes no difference and we prefer signed.
2448 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2449 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2450 nonnegative.
2451
d6d100dd
SM
24522011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2453
2454 * window.h (Fwindow_frame): Declare.
2455
2b6148e4
PE
24562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2457
2458 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2459 (SPARE_MEMORY): Always define.
2460 (LARGE_REQUEST): Remove.
2461 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2462
f230ecc9
MR
24632011-06-06 Martin Rudalics <rudalics@gmx.at>
2464
727e958e
MR
2465 * lisp.h: Move EXFUNS for Fframe_root_window,
2466 Fframe_first_window and Fset_frame_selected_window to window.h.
2467
2468 * window.h: Move EXFUNS for Fframe_root_window,
2469 Fframe_first_window and Fset_frame_selected_window here from
2470 lisp.h.
2471
2472 * frame.c (Fwindow_frame, Fframe_first_window)
2473 (Fframe_root_window, Fframe_selected_window)
2474 (Fset_frame_selected_window): Move to window.c.
2475 (Factive_minibuffer_window): Move to minibuf.c.
2476 (Fother_visible_frames_p): New function.
2477
2478 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2479
f230ecc9
MR
2480 * window.c (decode_window, decode_any_window): Move up in code.
2481 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2482 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2483 (Fwindow_buffer): Move up and rewrite doc-string.
2484 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2485 (Fwindow_prev): New functions.
727e958e
MR
2486 (Fwindow_frame): Move here from frame.c. Accept any window as
2487 argument.
2488 (Fframe_root_window, Fframe_first_window)
2489 (Fframe_selected_window): Move here from frame.c. Accept frame
2490 or arbitrary window as argument. Update doc-strings.
2491 (Fminibuffer_window): Move up in code.
2492 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2493 (Fset_frame_selected_window): Move here from frame.c.
2494 Marginal rewrite.
727e958e
MR
2495 (Fselected_window, select_window, Fselect_window): Move up in
2496 code. Minor doc-string fixes.
f230ecc9 2497
4d09bcf6
PE
24982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2501 Do not assume that spare memory exists; that assumption is valid
2502 only if SYSTEM_MALLOC.
2503 (LARGE_REQUEST): New macro, so that the issue of large requests
2504 is separated from the issue of spare memory.
2505
810928a2
AS
25062011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2507
172418ad
AS
2508 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2509 format. (Bug#8806)
2510
43f862f7
AS
2511 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2512
810928a2
AS
2513 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2514 before statements.
2515
a059fe24
JD
25162011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2517
2518 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2519
2520 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2521
2522 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2523 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2524
989bf368
JB
25252011-06-05 Juanma Barranquero <lekktu@gmail.com>
2526
2527 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2528
4b80f674
CY
25292011-06-04 Chong Yidong <cyd@stupidchicken.com>
2530
2531 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2532 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2533 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2534 New error handlers.
4b80f674
CY
2535 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2536 Obey Vx_select_enable_clipboard_manager. Catch errors in
2537 x_clipboard_manager_save (Bug#8779).
2538 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2539 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2540
99a33b77 25412011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2542
2543 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2544
99a33b77 25452011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2546
2547 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2548 in the current matrix if keep_current_p is non-zero.
2549
8264569d
EZ
25502011-06-04 Eli Zaretskii <eliz@gnu.org>
2551
2552 * bidi.c (bidi_level_of_next_char): Fix last change.
2553
57f97249
EZ
25542011-06-03 Eli Zaretskii <eliz@gnu.org>
2555
fec2107c 2556 Support bidi reordering of text covered by display properties.
57f97249 2557
fec2107c
EZ
2558 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2559 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2560 (bidi_cache_search, bidi_cache_iterator_state)
2561 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2562 (bidi_level_of_next_char, bidi_move_to_visually_next):
2563 Support character positions inside a run of characters covered by a
fec2107c
EZ
2564 display string.
2565 (bidi_paragraph_init, bidi_resolve_explicit_1)
2566 (bidi_level_of_next_char): Call bidi_fetch_char and
2567 bidi_fetch_char_advance instead of FETCH_CHAR and
2568 FETCH_CHAR_ADVANCE.
2569 (bidi_init_it): Initialize new members.
2570 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2571 definitions.
2572 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2573 instead of using explicit *_CHAR codes.
d6d100dd
SM
2574 (bidi_resolve_explicit, bidi_resolve_weak):
2575 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2576 bidirectional text is supported only in multibyte buffers.
2577 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2578 it to initialize the frame_window_p member of struct bidi_it.
2579 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2580 (bidi_resolve_explicit, bidi_resolve_weak)
2581 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2582 bidi_it->nchars is non-positive.
2583 (bidi_level_of_next_char): Don't try to lookup the cache for the
2584 next/previous character if nothing is cached there yet, or if we
2585 were just reseat()'ed to a new position.
c40e2fb2 2586
0e14fe90
EZ
2587 * xdisp.c (set_cursor_from_row): Set start and stop points
2588 according to the row's direction when priming the loop that looks
2589 for the glyph on which to display cursor.
2590 (single_display_spec_intangible_p): Function deleted.
2591 (display_prop_intangible_p): Reimplement to call
2592 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2593 Accept 3 additional arguments needed by handle_display_spec.
2594 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2595 values: lists, `(when COND...)' forms, etc.
2596 (single_display_spec_string_p): Support property values that are
2597 lists with the argument STRING its top-level element.
2598 (display_prop_string_p): Fix the condition for processing a
2599 property that is a list to be consistent with handle_display_spec.
fec2107c 2600 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2601 last portion of handle_display_prop.
2602 (compute_display_string_pos): Accept additional argument
2603 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2604 value of a `display' property is a "replacing spec".
2605 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2606 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2607 the display property, but just return a value indicating whether
2608 the display property will replace the characters it covers.
2609 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2610 frame_window_p members of struct bidi_it.
d6d100dd
SM
2611 (compute_display_string_pos, compute_display_string_end):
2612 New functions.
fec2107c
EZ
2613 (push_it): Accept second argument POSITION, where pop_it should
2614 jump to continue iteration.
2615 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2616
fec2107c
EZ
2617 * keyboard.c (adjust_point_for_property): Adjust the call to
2618 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2619
2620 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2621 (bidi_init_it): Update prototypes.
2622 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2623 (compute_display_string_pos, compute_display_string_end):
2624 Declare prototypes.
fec2107c
EZ
2625 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2626 EMACS_INT.
fc6f18ce 2627
40087514 26282011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2629
57f53182
PE
2630 Malloc failure behavior now depends on size of allocation.
2631 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2632 * lisp.h: Change signatures accordingly.
2633 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2634 All callers changed. (Bug#8762)
2635
2636 * gnutls.c: Use Emacs's memory allocators.
2637 Without this change, the gnutls library would invoke malloc etc.
2638 directly, which causes problems on non-SYNC_INPUT hosts, and which
2639 runs afoul of improving memory_full behavior. (Bug#8761)
2640 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2641 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2642 xfree instead of the default malloc, realloc, free.
2643 (Fgnutls_boot): No need to check for memory allocation failure,
2644 since xmalloc does that for us.
2645
ac32cd99 2646 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2647 * category.c (hash_get_category_set):
2648 * ccl.c (ccl_driver):
2649 * charset.c (Fdefine_charset_internal):
2650 * charset.h (struct charset.hash_index):
2651 * composite.c (get_composition_id, gstring_lookup_cache)
2652 (composition_gstring_put_cache):
2653 * composite.h (struct composition.hash_index):
2654 * dispextern.h (struct image.hash):
2655 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2656 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2657 (hashfn_equal, hashfn_user_defined, make_hash_table)
2658 (maybe_resize_hash_table, hash_lookup, hash_put)
2659 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2660 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2661 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2662 * image.c (make_image, search_image_cache, lookup_image)
2663 (xpm_put_color_table_h):
2664 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2665 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2666 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2667 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2668 * alloc.c (allocate_vectorlike):
2669 Check for overflow in vector size calculations.
2670 * ccl.c (ccl_driver):
2671 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2672 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2673 need to be updated by these changes.
40087514
PE
2674 * fns.c (make_hash_table, maybe_resize_hash_table):
2675 Check for integer overflow with large hash tables.
0de4bb68
PE
2676 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2677 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2678 (SXHASH_REDUCE): New macro.
2679 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2680 Use it instead of discarding useful hash info with large hash values.
2681 (sxhash_float): New function.
2682 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2683 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2684 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2685 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2686 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2687 Adjust signatures to match updated version of code.
2688 (consing_since_gc): Now EMACS_INT, since a single hash table can
2689 use more than INT_MAX bytes.
2690
698d32e2
DN
26912011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2692
2693 Make it possible to build with GCC-4.6+ -O2 -flto.
2694
2695 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2696
fd6fa53f
SM
26972011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2698
2699 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2700 Call minibuffer-inactive-mode.
2701
864db017
JB
27022011-05-31 Juanma Barranquero <lekktu@gmail.com>
2703
2704 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2705 Update dependencies.
2706
2ad0baf4
DN
27072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2708
2709 * data.c (init_data): Remove code for UTS, this system is not
2710 supported anymore.
2711
4fcc2638
DN
27122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2713
2714 Don't force ./temacs to start in terminal mode.
2715
2716 * frame.c (make_initial_frame): Initialize faces in all cases, not
2717 only when CANNOT_DUMP is defined.
2718 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2719
c56e0fd5
DN
27202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2721
2722 * dispnew.c (add_window_display_history): Use const for the string
2723 pointer. Remove declaration, not needed.
2724
333d54da 27252011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2726
55d4c1b2 2727 Use 'inline', not 'INLINE'.
333d54da 2728 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2729 * alloc.c, fontset.c (INLINE): Remove.
2730 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2731 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2732 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2733 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2734 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2735
738db178
DN
27362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2737
2738 Make it possible to run ./temacs.
2739
2740 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2741 syms_of_callproc does the same thing. Remove test for
2742 "initialized", do it in the caller.
2743 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2744
620c53a6
SM
27452011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2746
2747 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2748 (read_minibuf): Use get_minibuffer.
2749 (syms_of_minibuf): Use DEFSYM.
2750 (Qmetadata): New var.
2751 * data.c (Qbuffer): Don't make it static.
2752 (syms_of_data): Use DEFSYM.
2753
e003a292
PE
27542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2757 (CCL_CODE_MIN): New macro.
2758
ed008a6d
PE
27592011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2760
3687c2ef
PE
2761 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2762
ed008a6d
PE
2763 * eval.c (Qdebug): Now static.
2764 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2765 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2766 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2767
d66c4c7c
CY
27682011-05-29 Chong Yidong <cyd@stupidchicken.com>
2769
2770 * image.c: Various fixes to ImageMagick code comments.
2771 (Fimagemagick_types): Doc fix.
2772
5fbc2025
PE
27732011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2774
0196f88a
PE
2775 Minor fixes prompted by GCC 4.6.0 warnings.
2776
2777 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2778
5fbc2025
PE
2779 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2780 (x_clipboard_manager_save_all): Move extern decl to ...
2781 * xterm.h: ... here, so that it can be checked for consistency.
2782
1dd3c2d9
CY
27832011-05-29 Chong Yidong <cyd@stupidchicken.com>
2784
2785 * xselect.c (x_clipboard_manager_save_frame)
2786 (x_clipboard_manager_save_all): New functions.
2787 (Fx_clipboard_manager_save): Lisp function deleted.
2788
2789 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2790 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2791
2792 * xterm.h: Update prototype.
2793
5ba6571d
WX
27942011-05-28 William Xu <william.xwl@gmail.com>
2795
2796 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2797 exiting (Bug#8239).
2798
3eaff834
JM
27992011-05-28 Jim Meyering <meyering@redhat.com>
2800
e1900994 2801 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2802 * fns.c (to_uchar): Define.
2803 (crypto_hash_function): Use it to convert some newly-signed
2804 variables to unsigned, to avoid sign-extension bugs. For example,
2805 without this change, (md5 "truc") would evaluate to
2806 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2807 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2808 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2809
0f6990a7
PE
28102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2811
2812 Integer overflow fixes.
c8a9ca5a 2813
08686060
PE
2814 * dbusbind.c: Serial number integer overflow fixes.
2815 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2816 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2817 to hold a serial number that is too large for a fixnum.
2818 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2819 Check for serial numbers out of range. Decode any serial number
59568bf0 2820 that was so large that it became a float. (Bug#8722)
08686060 2821
2d1fc3c7
PE
2822 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2823 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2824 Use XFASTINT rather than XUINT when numbers are nonnegative.
2825 (xd_append_arg, Fdbus_method_return_internal):
2826 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2827 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2828 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2829 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2830 (Bug#8722)
2d1fc3c7 2831
c8a9ca5a
PE
2832 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2833
519e1d69
PE
2834 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2835
30569699
PE
2836 ccl: add integer overflow checks
2837 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2838 (IN_INT_RANGE): New macros.
2839 (ccl_driver): Use them to check for integer overflow when
2840 decoding a CCL program. Many of the new checks are whether XINT (x)
2841 fits in int; it doesn't always, on 64-bit hosts. The new version
2842 doesn't catch all possible integer overflows, but it's an
847044ea 2843 improvement. (Bug#8719)
30569699 2844
c11285dc
PE
2845 * alloc.c (make_event_array): Use XINT, not XUINT.
2846 There's no need for unsigned here.
2847
fdccd48e
PE
2848 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2849 This follows up to the 2011-05-06 change that substituted uintptr_t
2850 for EMACS_INT. This case wasn't caught back then.
2851
37910ab2
PE
2852 Rework Fformat to avoid integer overflow issues.
2853 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2854 now (part of C89). Include <verify.h>.
2855 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2856 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2857 (Fformat): Avoid the prepass trying to compute sizes; it was only
2858 approximate and thus did not catch overflow reliably. Instead, walk
2859 through the format just once, formatting and computing sizes as we go,
2860 checking for integer overflow at every step, and allocating a larger
2861 buffer as needed. Keep track separately whether the format is
2862 multibyte. Keep only the most-recently calculated precision, rather
2863 than them all. Record whether each argument has been converted to
2864 string. Use EMACS_INT, not int, for byte and char and arg counts.
2865 Support field widths and precisions larger than INT_MAX. Avoid
2866 sprintf's undefined behavior with conversion specifications such as %#d
2867 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2868 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2869 formatting out-of-range floating point numbers with int
9173deec 2870 formats. (Bug#8668)
37910ab2 2871
2e6578fb
PE
2872 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2873
0ae6bdee
PE
2874 * data.c: Avoid integer truncation in expressions involving floats.
2875 * data.c: Include <intprops.h>.
2876 (arith_driver): When there's an integer overflow in an expression
2877 involving floating point, convert the integers to floating point
2878 so that the resulting value does not suffer from catastrophic
2879 integer truncation. For example, on a 64-bit host (* 4
2880 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2881 Do not rely on undefined behavior after integer overflow.
2882
de883a70
PE
2883 merge count_size_as_multibyte, parse_str_to_multibyte
2884 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2885 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2886 Check for integer overflow.
2887 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2888 since it's now a duplicate of the other. This is more of
2889 a character than a buffer op, so better that it's in character.c.
2890 * fns.c, print.c: Adjust to above changes.
2891
2ff916cb
PE
28922011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2893
2894 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2895
f1b54466
PE
28962011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2897
fb1ac845
PE
2898 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2899 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2900 (x_clipboard_manager_save): Now static.
2901 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2902
f1b54466
PE
2903 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2904 (crypto_hash_function): Now static.
2905 Fix pointer signedness problems. Avoid unnecessary initializations.
2906
a9f737ee
CY
29072011-05-27 Chong Yidong <cyd@stupidchicken.com>
2908
2909 * termhooks.h (Vselection_alist): Make it terminal-local.
2910
2911 * terminal.c (create_terminal): Initialize it.
2912
2913 * xselect.c: Support for clipboard managers.
2914 (Vselection_alist): Move to termhooks.h as terminal-local var.
2915 (LOCAL_SELECTION): New macro.
2916 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2917 (symbol_to_x_atom): Remove gratuitous arg.
2918 (x_handle_selection_request, lisp_data_to_selection_data)
2919 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2920 (x_own_selection, x_get_local_selection, x_convert_selection):
2921 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2922 (some_frame_on_display): Delete unused function.
2923 (Fx_own_selection_internal, Fx_get_selection_internal)
2924 (Fx_disown_selection_internal, Fx_selection_owner_p)
2925 (Fx_selection_exists_p): New optional frame arg.
2926 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2927 (x_handle_selection_clear): Don't treat other terminals with the
2928 same keyboard specially. Use the terminal-local Vselection_alist.
2929 (x_clear_frame_selections): Use Frun_hook_with_args.
2930
2931 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2932
2933 * xterm.h: Add support for those atoms.
2934
e067f0c1
CY
29352011-05-26 Chong Yidong <cyd@stupidchicken.com>
2936
2937 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2938 (converted_selections, conversion_fail_tag): New global variables.
2939 (x_selection_request_lisp_error): Free the above.
2940 (x_get_local_selection): Remove unnecessary code.
2941 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2942 of converted selections stored in converted_selections.
2943 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2944 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2945 (x_convert_selection): New function.
2946 (x_handle_selection_event): Simplify.
2947 (x_get_foreign_selection): Don't ignore incoming requests while
2948 waiting for an answer; this will fail when we implement
2949 SAVE_TARGETS, and seems unnecessary anyway.
2950 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2951 (Vx_sent_selection_functions): Doc fix.
2952
0f4aebc0
LL
29532011-05-26 Leo Liu <sdl.web@gmail.com>
2954
2955 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2956
e61124cd
YM
29572011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2958
2959 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2960
2961 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2962 for fringe update if it has periodic bitmap.
ac389d0c 2963 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2964 and fringe_bitmap_periodic_p.
2965
2966 * fringe.c (get_fringe_bitmap_data): New function.
2967 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2968 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2969 row. Mark glyph row for fringe update if periodicity changed.
2970
2971 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2972 for fringe update unless it has periodic bitmap.
2973
f16d9837
KH
29742011-05-25 Kenichi Handa <handa@m17n.org>
2975
2976 * xdisp.c (get_next_display_element): Set correct it->face_id for
2977 a static composition.
2978
e1b90ef6
LL
29792011-05-24 Leo Liu <sdl.web@gmail.com>
2980
2981 * deps.mk (fns.o):
2982 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2983
2984 * fns.c (crypto_hash_function, Fsha1): New function.
2985 (Fmd5): Use crypto_hash_function.
2986 (syms_of_fns): Add Ssha1.
2987
7400048f
PE
29882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2989
2990 * gnutls.c: Remove unused macros.
2991 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2992 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2993 Remove macros that are defined and never used.
2994 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2995
abb71cf4
CY
29962011-05-22 Chong Yidong <cyd@stupidchicken.com>
2997
2998 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2999 (Fx_get_selection_internal): Minor cleanup.
3000 (Fx_own_selection_internal): Rename arguments for consistency with
3001 select.el.
3002
6307db39
PE
30032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3004
3005 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3006
f3d4e0a4
CY
30072011-05-22 Chong Yidong <cyd@stupidchicken.com>
3008
3009 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3010
4d8ade89
YM
30112011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3012
3013 * dispnew.c (scrolling_window): Don't exclude the case that the
3014 last enabled row in the desired matrix touches the bottom boundary.
3015
32078c8d
GM
30162011-05-21 Glenn Morris <rgm@gnu.org>
3017
3018 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3019 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3020 and add some more files.
32078c8d 3021
7285dc67
EZ
30222011-05-20 Eli Zaretskii <eliz@gnu.org>
3023
3024 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3025 report_file_error introduced by the change from 2011-05-07.
3026
89d1bd22
PE
30272011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3028
3029 * systime.h (Time): Define only if emacs is defined.
3030 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3031 where the include path doesn't have X11/X.h by default. See
3032 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3033
e23640bb 30342011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3035
3036 * composite.c (find_automatic_composition): Fix previous change.
3037
b9704ad9
GM
30382011-05-20 Glenn Morris <rgm@gnu.org>
3039
3040 * lisp.mk: New file, split from Makefile.in.
3041 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3042 (shortlisp): Remove.
3043 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3044
4a720484
GM
30452011-05-19 Glenn Morris <rgm@gnu.org>
3046
3047 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3048 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3049 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3050 (lisp): Set the order to that of loadup.el.
3051 (shortlisp): Make it a copy of $lisp.
3052 (SOME_MACHINE_LISP): Remove.
3053 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3054 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3055
a28d4396
KH
30562011-05-18 Kenichi Handa <handa@m17n.org>
3057
3058 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3059 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3060 (find_automatic_composition): Mostly rewrite for efficiency.
3061
a2b1fa8e
JB
30622011-05-18 Juanma Barranquero <lekktu@gmail.com>
3063
3064 * makefile.w32-in: Update dependencies.
3065
8e1f5610
CS
30662011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3067
3068 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3069 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3070
7025ee00 30712011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3072
cdfa6eab
PE
3073 Fix some integer overflow issues, such as string length overflow.
3074
06d6db33
PE
3075 * insdel.c (count_size_as_multibyte): Check for string overflow.
3076
2b4560a8
PE
3077 * character.c (lisp_string_width): Check for string overflow.
3078 Use EMACS_INT, not int, for string indexes and lengths; in
3079 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3080 the resulting string length overflows an EMACS_INT; instead,
3081 report a string overflow if no precision given. When checking for
3082 precision exhaustion, use a check that cannot possibly have
3083 integer overflow. (Bug#8675)
3084 * character.h (lisp_string_width): Adjust to new signature.
3085
cb93f9be
PE
3086 * alloc.c (string_overflow): New function.
3087 (Fmake_string): Use it. This doesn't change behavior, but saves
3088 a few bytes and will simplify future changes.
3089 * character.c (string_escape_byte8): Likewise.
3090 * lisp.h (string_overflow): New decl.
3091
1a1f3366
PE
3092 Fixups, following up to the user-interface timestamp change.
3093 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3094 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3095 * msdos.c (mouse_get_pos): Likewise.
3096 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3097 * w32gui.h (Time): Define by including "systime.h" rather than by
3098 declaring it ourselves. (Bug#8664)
3099
d4e3e4d3
PE
3100 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3101 * image.c (clear_image_cache): Likewise.
3102
f6a24d19
PE
3103 * term.c (term_mouse_position): Don't assume time_t wraparound.
3104
08dc5ae6
PE
3105 Be more systematic about user-interface timestamps.
3106 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3107 and sometimes 'EMACS_UINT', to represent these timestamps.
3108 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3109 This makes the code easier to follow, and makes it easier to catch
3110 integer overflow bugs such as Bug#8664.
3111 * frame.c (Fmouse_position, Fmouse_pixel_position):
3112 Use Time, not unsigned long, for user-interface timestamps.
3113 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3114 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3115 * keyboard.h (last_event_timestamp): Likewise.
3116 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3117 * menu.h (xmenu_show): Likewise.
3118 * term.c (term_mouse_position): Likewise.
3119 * termhooks.h (struct input_event.timestamp): Likewise.
3120 (struct terminal.mouse_position_hook): Likewise.
3121 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3122 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3123 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3124 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3125 what it was before.
3126 * menu.h, termhooks.h: Include "systime.h", for Time.
3127
8e55734a
PE
3128 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3129 Don't assume that the difference between two unsigned long values
3130 can fit into an integer. At this point, we know button_down_time
3131 <= event->timestamp, so the difference must be nonnegative, so
3132 there's no need to cast the result if double-click-time is
3133 nonnegative, as it should be; check that it's nonnegative, just in
3134 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3135 apart (about 25 days). (Bug#8664)
8e55734a 3136
841f1b75 3137 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3138 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3139
3e26f69c
PE
3140 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3141 that always fit in int. Use a sentinel instead of a counter, to
3142 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3143 * frame.h (struct frame): Use int for menu_bar_items_used
3144 instead of EMACS_INT, since it always fits in int.
3e26f69c 3145
5cc152c0
PE
3146 * menu.c (grow_menu_items): Check for int overflow.
3147
d89eb65e
PE
3148 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3149
5235bd3e
PE
3150 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3151 Before, the code was not consistent. These values cannot exceed
3152 2**31 - 1 so there's no need to make them unsigned.
3153 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3154 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3155 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3156 as modifiers.
3157 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3158
bc827e23
PE
3159 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3160 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3161 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3162 presumably because the widths might not match.
3163
78eb494e
PE
3164 * window.c (size_window): Avoid needless test at loop start.
3165
04f2d78b
CB
31662011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3167
3168 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3169
d2fc7e3d 31702011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3171
3172 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3173
d2fc7e3d 31742011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3175
3176 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3177 `width' to `bar_area_x' and `bar_area_width', respectively.
3178 (x_scroll_run): Take account of fringe background extension.
3179
04f2d78b
CB
3180 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3181 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3182 `bar_area_width', respectively.
3183 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3184 background extension.
3185
79b70037
GM
31862011-05-10 Jim Meyering <meyering@redhat.com>
3187
3188 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3189
2f142cc5
JB
31902011-05-10 Juanma Barranquero <lekktu@gmail.com>
3191
3192 * image.c (Finit_image_library): Return t for built-in image types,
3193 like pbm and xbm. (Bug#8640)
3194
57679c86
AS
31952011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3196
3197 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3198
888c9e86
EZ
31992011-05-07 Eli Zaretskii <eliz@gnu.org>
3200
b0512a1d
EZ
3201 * w32console.c (Fset_screen_color): Doc fix.
3202 (Fget_screen_color): New function.
3203 (syms_of_ntterm): Defsubr it.
3204
7285dc67
EZ
3205 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3206 unlink the temporary file if Fcall_process didn't create it in the
3207 first place.
3208 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3209 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3210 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3211 cue to call_process_cleanup not to close that handle.
3212
4d3fcc8e
BK
32132011-05-07 Ben Key <bkey76@gmail.com>
3214
3215 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3216 one of two shell specific rules, either bootstrap-temacs-CMD or
3217 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3218 to the previous implementation of the bootstrap-temacs rule.
3219 The bootstrap-temacs-CMD rule is similar to the previous
3220 implementation of the bootstrap-temacs rule except that it
3221 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3222 variable.
3223
3224 These changes, along with some changes to nt/configure.bat,
3225 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3226 earlier fix to add support for --cflags and --ldflags options
3227 that include quotes so that it works whether make uses cmd or
3228 sh as the shell.
3229
b4289b64
MA
32302011-05-06 Michael Albinus <michael.albinus@gmx.de>
3231
3232 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3233 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3234 is a constant.
3235 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3236 a string. Handle both cases.
3237 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3238 (Fdbus_register_method): Use Qinvalid_function.
3239
af4c0e28
JB
32402011-05-06 Juanma Barranquero <lekktu@gmail.com>
3241
3242 * makefile.w32-in: Update dependencies.
3243 (LISP_H): Add inttypes.h and stdin.h.
3244 (PROCESS_H): Add unistd.h.
3245
c51453d9
EZ
32462011-05-06 Eli Zaretskii <eliz@gnu.org>
3247
3248 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3249 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3250
8ff0ac3c 32512011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3252
4c4b566b
PE
3253 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3254
aab2b9b5
PE
3255 * term.c (vfatal): Remove stray call to va_end.
3256 It's not needed and the C Standard doesn't allow it here anyway.
3257
c378da0b
PE
3258 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3259 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3260
288b08c7
PE
3261 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3262 bytes.
3263
e3601888
PE
3264 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3265
db6c0e74
PE
3266 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3267
dd5963ea
PE
3268 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3269
88c9450f
PE
3270 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3271
2f9442b8
PE
3272 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3273
c032b5f8
PE
3274 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3275 * charset.c (Fdefine_charset_internal): Don't initialize
3276 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3277 32-bit int (Bug#8600).
a108c10b
PE
3278
3279 * lread.c (read_integer): Be more consistent with string-to-number.
3280 Use string_to_number to do the actual conversion; this avoids
3281 rounding errors and fixes some other screwups. Without this fix,
3282 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3283 (digit_to_number): Move earlier, for benefit of read_integer.
3284 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3285 not a digit in any supported base. (Bug#8602)
a108c10b 3286
ad5f9eea
PE
3287 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3288
aec1708a
PE
3289 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3290 to match comment at start of function. This also removes a
3291 GCC warning about overflow in a 32+64-bit port.
3292
47be4ab5
PE
3293 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3294
371cac43
PE
3295 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3296 Reported by Stefan Monnier in
3297 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3298 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3299 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3300
d01a7826
PE
3301 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3302 (EMACS_UINTPTR): Likewise, with uintptr_t.
3303
7fd47d5c
PE
3304 * lisp.h: Prefer 64-bit EMACS_INT if available.
3305 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3306 on 32-bit hosts that have 64-bit int, so that they can access
3307 large files.
122b0c86
PE
3308 However, temporarily disable this change unless the temporary
3309 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3310
8727937b
PE
3311 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3312
8ac068ac
PE
3313 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3314 This removes an assumption that EMACS_INT and long are the same
3315 width as pointers. The assumption is true for Emacs porting targets
3316 now, but we want to make other targets possible.
3317 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3318 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3319 In the rest of the code, change types of integers that hold casted
3320 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3321 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3322 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3323 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3324 No need to cast type when ORing.
3325 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3326 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3327 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3328 assume EMACS_INT is the same width as char *.
3329 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3330 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3331 Remove no-longer-needed casts.
3332 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3333 (xg_tool_bar_help_callback, xg_make_tool_item):
3334 Use EMACS_INTPTR to hold an integer
3335 that will be cast to void *; this can avoid a GCC warning
3336 if EMACS_INT is not the same width as void *.
3337 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3338 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3339 (current_message_1, set_message_1):
3340 Use a local to convert to proper width without a cast.
3341 * xmenu.c (dialog_selection_callback): Likewise.
3342
ede49d71
PE
3343 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3344 Also, don't assume VALBITS / RAND_BITS is less than 5,
3345 and don't rely on undefined behavior when shifting a 1 left into
3346 the sign bit.
3347 * lisp.h (get_random): Change signature to match.
3348
2f30ecd0
PE
3349 * lread.c (hash_string): Use size_t, not int, for hash computation.
3350 Normally we prefer signed values; but hashing is special, because
3351 it's better to use unsigned division on hash table sizes so that
3352 the remainder is nonnegative. Also, size_t is the natural width
3353 for hashing into memory. The previous code used 'int', which doesn't
3354 retain enough info to hash well into very large tables.
3355 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3356
2a866e7b
PE
3357 * dbusbind.c: Don't possibly lose pointer info when converting.
3358 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3359 Use XPNTR rather than XHASH, so that the high-order bits of
3360 the pointer aren't lost when converting through void *.
3361
51639eac
PE
3362 * eval.c (Fautoload): Don't double-shift a pointer.
3363
92394119
PE
3364 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3365
dbdb9a7c
JB
33662011-05-06 Juanma Barranquero <lekktu@gmail.com>
3367
3368 * gnutls.c (DEF_GNUTLS_FN):
3369 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3370
db7a0b4f
AS
33712011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3372
3373 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3374 marker. (Bug#8610)
3375
f7ff1b0f 33762011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3377
3378 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3379 New version that can reserve upto 2GB of heap space.
3380
f7ff1b0f 33812011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3382
3383 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3384
639c109b
TZ
33852011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3386
3387 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3388 `gnutls_certificate_set_x509_key_file'.
3389
d2127135
JB
33902011-05-05 Juanma Barranquero <lekktu@gmail.com>
3391
3392 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3393 Update dependencies.
3394
e968f4f3
JB
33952011-05-04 Juanma Barranquero <lekktu@gmail.com>
3396
3397 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3398 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3399 Remove unused parameter `fildes'.
3400 * process.c (read_process_output, send_process): Don't pass it.
3401
84d358f0
JB
34022011-05-04 Juanma Barranquero <lekktu@gmail.com>
3403
3404 Fix previous change: the library cache is defined in w32.c.
3405 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3406 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3407
0898ca10
JB
34082011-05-04 Juanma Barranquero <lekktu@gmail.com>
3409
3410 Implement dynamic loading of GnuTLS on Windows.
3411
3412 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3413 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3414 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3415 Declare.
3416
3417 * gnutls.c (Qgnutls_dll): Define.
3418 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3419 (gnutls_*): Declare function pointers.
3420 (init_gnutls_functions): New function to initialize function pointers.
3421 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3422 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3423 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3424 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3425 (emacs_gnutls_write, emacs_gnutls_read)
3426 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3427 (Fgnutls_available_p): New function.
3428 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3429 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3430 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3431
3432 * image.c: Include w32.h.
3433 (Vimage_type_cache): Delete.
3434 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3435 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3436 (w32_delayed_load): Move to w32.c.
3437
3438 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3439
3440 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3441 (w32_delayed_load): Move from image.c. When loading a library, record
3442 its filename in the :loaded-from property of the library id.
3443 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3444 Initialize and staticpro them.
3445 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3446
3447 * process.c: Include lisp.h before w32.h, not after.
3448 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3449 instead of gnutls_record_check_pending.
3450
3451 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3452
ff4de4aa
TZ
34532011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3454
3455 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3456 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3457 as passed in.
3458
abe95abb
JD
34592011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3460
3461 * xterm.c (x_set_frame_alpha): Do not set property on anything
3462 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3463
e16e55d4
JB
34642011-05-02 Juanma Barranquero <lekktu@gmail.com>
3465
3466 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3467
bafcf6a5
JB
34682011-05-02 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3471 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3472 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3473 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3474 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3475 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3476 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3477 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3478 (Qgnutls_bootprop_callbacks_verify): Make static.
3479
e7a6747f
AS
34802011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3481
19ed11ba
AS
3482 * callproc.c: Indentation fixup.
3483
e7a6747f 3484 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3485 (wait_for_termination, interruptible_wait_for_termination):
3486 Move after wait_for_termination_1.
e7a6747f 3487
1ef14cb4
LMI
34882011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3489
3490 * sysdep.c (interruptible_wait_for_termination): New function
3491 which is like wait_for_termination, but allows keyboard
3492 interruptions.
3493
3494 * callproc.c (Fcall_process): Add (:file "file") as an option for
3495 the STDOUT buffer.
3496 (Fcall_process_region): Ditto.
3497
330d880c
EZ
34982011-04-30 Eli Zaretskii <eliz@gnu.org>
3499
8db90b73
EZ
3500 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3501 rather than `XVECTOR (FOO)->size'.
3502
330d880c
EZ
3503 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3504 inttypes.h, as a gnulib replacement is used if it not available in
3505 system headers.
3506
15cbd324
EZ
35072011-04-21 Eli Zaretskii <eliz@gnu.org>
3508
3509 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3510 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3511 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3512
3513 * coding.c (coding_alloc_by_realloc): Error out if destination
3514 will grow beyond MOST_POSITIVE_FIXNUM.
3515 (decode_coding_emacs_mule): Abort if there isn't enough place in
3516 charbuf for the composition carryover bytes. Reserve an extra
3517 space for up to 2 characters produced in a loop.
3518 (decode_coding_iso_2022): Abort if there isn't enough place in
3519 charbuf for the composition carryover bytes.
3520
35212011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3522
ae940cca
EZ
3523 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3524 aborting when %lld or %lll format is passed.
3525 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3526 %llo or %llx format is passed. (Bug#8545)
3527
03ab8921
EZ
3528 * window.c (window_scroll_line_based): Use a marker instead of
3529 simple variables to record original value of point. (Bug#7952)
3530
afda1437
EZ
3531 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3532 produced by %s or %c overflows available buffer space. (Bug#8545)
3533
f76dee0c
PE
35342011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3535
3536 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3537 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3538
fdc5744d
JB
35392011-04-28 Juanma Barranquero <lekktu@gmail.com>
3540
3541 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3542
638f053a
JB
35432011-04-28 Juanma Barranquero <lekktu@gmail.com>
3544
3545 * keyboard.c (Qdelayed_warnings_hook): Define.
3546 (command_loop_1): Run `delayed-warnings-hook'
3547 if Vdelayed_warnings_list is non-nil.
3548 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3549 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3550
d178f871
EZ
35512011-04-28 Eli Zaretskii <eliz@gnu.org>
3552
3553 * doprnt.c (doprnt): Don't return value smaller than the buffer
3554 size if the message was truncated. (Bug#8545).
3555
b124fd93
JB
35562011-04-28 Juanma Barranquero <lekktu@gmail.com>
3557
3558 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3559 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3560
e810457d
PE
35612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3562
3563 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3564
ea51cceb
JB
35652011-04-27 Juanma Barranquero <lekktu@gmail.com>
3566
3567 * makefile.w32-in: Update dependencies.
3568
94dcfacf
EZ
35692011-04-27 Eli Zaretskii <eliz@gnu.org>
3570
3571 Improve `doprnt' and its usage. (Bug#8545)
3572 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3573 `format_end'. Remove support for %l as a conversion specifier.
3574 Don't use xrealloc. Improve diagnostics when the %l size modifier
3575 is used. Update the commentary.
3576
3577 * eval.c (verror): Simplify calculation of size_t.
3578
3579 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3580 messages.
3581
f61f41d7
PE
35822011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3583
3584 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3585 change.
3586
96fb4434
PE
35872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3590 This makes this file independent of the recent pseudovector change.
3591
671875da 35922011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3593
69e9b5a3
PE
3594 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3595
b5f869a7 3596 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3597 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3598 Remove unused local.
c8926152 3599 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3600
841a1577 3601 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3602 GCC 4.6.0 optimizes based on type-based alias analysis.
3603 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3604 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3605 != &v->size, and therefore "v->size = 1; b->size = 2; return
3606 v->size;" must therefore return 1. This assumption is incorrect
3607 for Emacs, since it type-puns struct Lisp_Vector * with many other
3608 types. To fix this problem, this patch adds a new type struct
f904488f 3609 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3610 and pseudovectors, and helps optimizing compilers not get fooled
3611 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3612 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3613 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3614 the size member.
eab3844f
PE
3615 (XSETPVECTYPE): Rewrite in terms of new macro.
3616 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3617 This is a bit clearer, and further avoids the possibility of
3618 undesirable aliasing.
3619 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3620 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3621 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3622 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3623 (ASIZE): Now uses header.size rather than size.
3624 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3625 to avoid the hassle of writing XVECTOR (foo)->header.size.
3626 (struct vectorlike_header): New type.
eab3844f
PE
3627 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3628 object, to help avoid aliasing.
3629 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3630 (SUBRP): Likewise, since Lisp_Subr is a special case.
3631 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3632 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3633 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3634 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3635 changed to be "header.size" and "header.next".
3636 * buffer.h (struct buffer): Likewise.
3637 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3638 * frame.h (struct frame): Likewise.
3639 * process.h (struct Lisp_Process): Likewise.
3640 * termhooks.h (struct terminal): Likewise.
3641 * window.c (struct save_window_data, struct saved_window): Likewise.
3642 * window.h (struct window): Likewise.
3643 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3644 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3645 * buffer.c (init_buffer_once): Likewise.
3646 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3647 special case.
3648 * process.c (Fformat_network_address): Use local var for size,
3649 for brevity.
3650
0df1eac5
PE
3651 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3652
847ab9d1 3653 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3654 * data.c (atof): Remove decl; no longer used or needed.
3655 (digit_to_number): Move to lread.c.
3656 (Fstring_to_number): Use new string_to_number function, to be
3657 consistent with how the Lisp reader treats infinities and NaNs.
3658 Do not assume that floating-point numbers represent EMACS_INT
3659 without losing information; this is not true on most 64-bit hosts.
3660 Avoid double-rounding errors, by insisting on integers when
3661 parsing non-base-10 numbers, as the documentation specifies.
3662 * lisp.h (string_to_number): New decl, replacing ...
3663 (isfloat_string): Remove.
bc0a5c13 3664 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3665 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3666 appears to have been a coding error. Similarly, do not accept
3667 strings like +-1e0 as floating point numbers. Do not report
3668 overflow for integer overflows unless the base is not 10 which
3669 means we have no simple and reliable way to continue.
3670 Break out the floating-point parsing into a new
3671 function string_to_number, so that Fstring_to_number parses
3672 floating point numbers consistently with the Lisp reader.
04f2d78b 3673 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3674 (E_CHAR, EXP_INT): Remove, replacing with ...
3675 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3676 (string_to_number): New function, replacing isfloat_string.
3677 This function checks for valid syntax and produces the resulting
3678 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3679 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3680 so that overflow for non-base-10 numbers is reported only when
3681 there's no portable and simple way to convert to floating point.
452f4150 3682
67769ffc
PE
3683 * textprop.c (set_text_properties_1): Rewrite for clarity,
3684 and to avoid GCC warning about integer overflow.
3685
c20db43f
PE
3686 * intervals.h (struct interval): Use EMACS_INT for members
3687 where EMACS_UINT might cause problems. See
3688 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3689 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3690 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3691 All uses changed.
37aa2f85
PE
3692 (offset_intervals): Tell GCC not to worry about length overflow
3693 when negating a negative length.
c20db43f 3694
2538aa2f
PE
3695 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3696 (overrun_check_free): Likewise.
3697
f2d3008d
PE
3698 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3699 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3700 word size.
3701
ec8df744
PE
3702 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3703 (gnutls_make_error): Rename local to avoid shadowing.
3704 (gnutls_emacs_global_deinit): ifdef out; not used.
3705 (Fgnutls_boot): Use const for pointer to readonly storage.
3706 Comment out unused local. Fix pointer signedness problems.
3707
640ee02d
PE
3708 * lread.c (openp): Don't stuff size_t into an 'int'.
3709 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3710 about possible signed overflow.
3711
6048fb2a
PE
3712 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3713 (GDK_KEY_g): Don't define if already defined.
3714 (xg_prepare_tooltip): Avoid pointer signedness problem.
3715 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3716
fa3c87e1
PE
3717 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3718 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3719
2172544b
PE
3720 * xfns.c (Fx_window_property): Simplify a bit,
3721 to make a bit faster and to avoid GCC 4.6.0 warning.
3722 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3723
9b821a21
PE
3724 * fns.c (internal_equal): Don't assume size_t fits in int.
3725
3c616cfa
PE
3726 * alloc.c (compact_small_strings): Tighten assertion a little.
3727
c2982e87
PE
3728 Replace pEd with more-general pI, and fix some printf arg casts.
3729 * lisp.h (pI): New macro, generalizing old pEd macro to other
3730 conversion specifiers. For example, use "...%"pI"d..." rather
3731 than "...%"pEd"...".
3732 (pEd): Remove. All uses replaced with similar uses of pI.
3733 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3734 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3735 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3736 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3737 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3738 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3739 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3740 64-bit hosts.
3741 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3742 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3743 * print.c (safe_debug_print, print_object): Likewise.
3744 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3745 to int.
6f04d126
PE
3746 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3747 avoiding the 0 flag, which is not portable.
c2982e87
PE
3748 * process.c (Fmake_network_process): Use pI to avoid cast.
3749 * region-cache.c (pp_cache): Likewise.
3750 * xdisp.c (decode_mode_spec): Likewise.
3751 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3752 behavior on 64-bit hosts with printf arg.
6f04d126 3753 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3754 (x_stop_queuing_selection_requests): Likewise.
3755 (x_get_window_property): Don't truncate byte count to an 'int'
3756 when tracing.
0b432f21 3757
5e073ec7
PE
3758 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3759 here, since it parses constructs like leading '-' and spaces,
3760 which are not wanted; and it overflows with large numbers.
3761 Instead, simply match F[0-9]+, which is what is wanted anyway.
3762
36372bf9
PE
3763 * alloc.c: Remove unportable assumptions about struct layout.
3764 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3765 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3766 (allocate_vectorlike, make_pure_vector): Use the new macros,
3767 plus offsetof, to remove unportable assumptions about struct layout.
3768 These assumptions hold on all porting targets that I know of, but
3769 they are not guaranteed, they're easy to remove, and removing them
3770 makes further changes easier.
3771
0b432f21
PE
3772 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3773 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3774 (string_overrun_cookie): Now const. Use initializers that
3775 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3776 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3777 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3778 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3779 multiple of sizeof (EMACS_INT); it need not be, if
3780 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3781 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3782
895009e1
JB
37832011-04-26 Juanma Barranquero <lekktu@gmail.com>
3784
3785 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3786
6a7a1b0b
TZ
37872011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3788
3789 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3790 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3791 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3792
841a1577 37932011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3794
3795 * lisp.h (Qdebug): List symbol.
895009e1 3796 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3797 * keyboard.c (debug-on-event): New variable.
3798 (handle_user_signal): Break into debugger when debug-on-event
3799 matches the current signal symbol.
3800
f2d3ba6f
DN
38012011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3802
3803 * alloc.c (check_sblock, check_string_bytes)
3804 (check_string_free_list): Convert to standard C.
3805
42ce4c63
TZ
38062011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3807
3808 * w32.c (emacs_gnutls_push): Fix typo.
3809
825cd63c
EZ
38102011-04-25 Eli Zaretskii <eliz@gnu.org>
3811
fb11d64d
EZ
3812 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3813 "cast to pointer from integer of different size".
3814
825cd63c
EZ
3815 Improve doprnt and its use in verror. (Bug#8545)
3816 * doprnt.c (doprnt): Document the set of format control sequences
3817 supported by the function. Use SAFE_ALLOCA instead of always
3818 using `alloca'.
3819
3820 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3821 is one byte too soon. Don't use xrealloc; instead xfree and
3822 xmalloc anew.
3823
e061a11b
TZ
38242011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3825
3826 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3827 callbacks stage.
3828
3829 * gnutls.c: Renamed global_initialized to
3830 gnutls_global_initialized. Added internals for the
3831 :verify-hostname-error, :verify-error, and :verify-flags
3832 parameters of `gnutls-boot' and documented those parameters in the
3833 docstring. Start callback support.
9173deec
JB
3834 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3835 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3836 on error. Return error code.
e061a11b
TZ
3837 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3838 (emacs_gnutls_read): Likewise.
3839 (Fgnutls_boot): Return handshake error code.
3840 (emacs_gnutls_handle_error): New function.
3841 (wsaerror_to_errno): Likewise.
3842
3843 * w32.h (emacs_gnutls_pull): Add prototype.
3844 (emacs_gnutls_push): Likewise.
3845
3846 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3847 (emacs_gnutls_push): Likewise.
3848
38492011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3850
3851 * process.c (wait_reading_process_output): Check if GnuTLS
3852 buffered some data internally if no FDs are set for TLS
3853 connections.
3854
3855 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3856 (LIBS): Link to USER_LIBS.
3857 ($(BLD)/gnutls.$(0)): New target.
3858
fa6996bc
EZ
38592011-04-24 Eli Zaretskii <eliz@gnu.org>
3860
eb35682e
EZ
3861 * xdisp.c (handle_single_display_spec): Rename the
3862 display_replaced_before_p argument into display_replaced_p, to
3863 make it consistent with the commentary. Fix typos in the
3864 commentary.
3865
e2ad650c
EZ
3866 * textprop.c (syms_of_textprop): Remove dead code.
3867 (copy_text_properties): Delete obsolete commentary about an
3868 interface that was deleted long ago. Fix typos in the description
3869 of arguments.
3870
1b2de274
EZ
3871 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3872 to changes in oldXMenu/XMenu.h from 2011-04-16.
3873 <menu_help_message, prev_menu_help_message>: Constify.
3874 (IT_menu_make_room): menu->help_text is now `const char **';
3875 adjust.
3876
3877 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3878 to changes in oldXMenu/XMenu.h from 2011-04-16.
3879 (struct XMenu): Declare `help_text' `const char **'.
3880
3881 * xfaces.c <Qunspecified>: Make extern again.
3882
3883 * syntax.c: Include sys/types.h before including regex.h, as
3884 required by Posix.
3885
762b15be
EZ
3886 * doc.c (get_doc_string): Improve the format passed to `error'.
3887
3888 * doprnt.c (doprnt): Improve commentary.
3889
3890 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3891
3892 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3893 them with etags.
3894
f1052e5d
EZ
3895 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3896 changes in globals.h immediately force recompilation.
762b15be
EZ
3897 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3898 $(CURDIR)/s/ms-w32.h.
3899 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3900
fa6996bc
EZ
3901 * character.c (Fchar_direction): Function deleted.
3902 (syms_of_character): Don't defsubr it.
3903 <char-direction-table>: Deleted.
3904
e6c3da20
EZ
39052011-04-23 Eli Zaretskii <eliz@gnu.org>
3906
3907 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3908 * doprnt.c: Include limits.h.
3909 (SIZE_MAX): New macro.
04f2d78b
CB
3910 (doprnt): Return a size_t value. 2nd arg is now size_t.
3911 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3912 Improve overflow protection. Support `l' modifier for integer
3913 conversions. Support %l conversion. Don't assume an EMACS_INT
3914 argument for integer conversions and for %c.
3915
3916 * lisp.h (doprnt): Restore prototype.
3917
3918 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3919 $(SRC)/character.h.
3920
3921 * Makefile.in (base_obj): Add back doprnt.o.
3922
3923 * deps.mk (doprnt.o): Add back prerequisites.
3924 (callint.o): Depend on character.h.
3925
3926 * eval.c (internal_lisp_condition_case): Include the handler
3927 representation in the error message.
3928 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3929 when breaking from the loop.
3930
3931 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3932
3933 * callint.c (Fcall_interactively): When displaying error message
3934 about invalid control letter, pass the character's codepoint, not
3935 a pointer to its multibyte form. Improve display of the character
3936 in octal and display also its hex code.
3937
3938 * character.c (char_string): Use %x to display the (unsigned)
3939 codepoint of an invalid character, to avoid displaying a bogus
3940 negative value.
3941
3942 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3943 `error', not SYMBOL_NAME itself.
3944
3945 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3946 character arguments to `error'.
3947
3948 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3949 to `error' in error message about FINAL_CHAR argument. Make sure
3950 FINAL_CHAR is a character, and use %c when it is passed as
3951 argument to `error'.
3952
4ffd0d6b 39532011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3954
3955 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3956
3957 * w32.c: Include <time.h>.
3958 (sys_localtime): New function.
3959
4ffd0d6b 39602011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3961
3962 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3963
4ffd0d6b 3964 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3965
4ffd0d6b 39662011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3967
4ffd0d6b
GM
3968 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3969 zombies (Bug#8467).
aac0c6e3 3970
04c56954
EZ
39712011-04-19 Eli Zaretskii <eliz@gnu.org>
3972
3973 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3974 gl_state.e_property when gl_state.object is Qt.
3975
3976 * insdel.c (make_gap_larger): Remove limitation of buffer size
3977 to <= INT_MAX.
3978
16a43933
CY
39792011-04-18 Chong Yidong <cyd@stupidchicken.com>
3980
3981 * xdisp.c (lookup_glyphless_char_display)
3982 (produce_glyphless_glyph): Handle cons cell entry in
3983 glyphless-char-display.
3984 (Vglyphless_char_display): Document it.
3985
3986 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3987 glyphless-char-display.
3988
4581706e
CY
39892011-04-17 Chong Yidong <cyd@stupidchicken.com>
3990
3991 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3992
3993 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3994
3995 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3996 definition for no-X builds.
3997
4887c6e2 39982011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3999
fd35b6f9
PE
4000 Static checks with GCC 4.6.0 and non-default toolkits.
4001
5c1ccb01
PE
4002 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4003
006c5daa
PE
4004 * process.c (keyboard_bit_set): Define only if SIGIO.
4005 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4006 (send_process): Repair possible setjmp clobbering.
4007
efc736d3
PE
4008 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4009
4e2fe2e6
PE
4010 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4011
f97334a2
PE
4012 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4013
4e75f29d
PE
4014 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4015 Define only if needed.
4016
90efadd1
PE
4017 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4018 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4019 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4020
3c647824
PE
4021 * dispextern.h (struct redisplay_interface): Rename param
4022 to avoid shadowing.
e264f262 4023 * termhooks.h (struct terminal): Likewise.
761383f4 4024 * xterm.c (xembed_send_message): Likewise.
3c647824 4025
b58c5c4a
PE
4026 * insdel.c (make_gap_smaller): Define only if
4027 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4028
cad59032
PE
4029 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4030 it.
4031
c339dc2e
PE
4032 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4033 so that we aren't warned about unused symbols.
4034
91a3e27b
PE
4035 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4036
399c71d3 4037 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4038
8ffc96f5
PE
4039 * xfns.c (x_real_positions): Mark locals as initialized.
4040
eef9bc79
PE
4041 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4042
098db9dd
PE
4043 * xterm.c: Fix problems found by static analysis with other toolkits.
4044 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4045 (x_dispatch_event): Declare static if USE_GTK, and
4046 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4047 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4048 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4049 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4050 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4051
eb18f6cc
PE
4052 * xmenu.c (menu_help_callback): Pointer type fixes.
4053 Use const pointers when pointing at readonly data. Avoid pointer
4054 signedness clashes.
4055 (FALSE): Remove unused macro.
4056 (update_frame_menubar): Remove unused decl.
4057
1fe72bf8
PE
4058 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4059
60d9e1db
PE
4060 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4061 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4062 (single_menu_item): Rename local to avoid shadowing.
4063
39261c26
PE
4064 * keyboard.c (make_lispy_event): Remove unused local var.
4065
018c5e19
PE
4066 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4067 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4068
63d2b86e
PE
4069 * bitmaps: Change bitmaps from unsigned char back to the X11
4070 compatible char. Avoid the old compiler warnings about
4071 out-of-range initializers by using, for example, '\xab' rather
4072 than 0xab.
4073
aefd87e1
PE
4074 * xgselect.c (xgselect_initialize): Check vs interface
4075 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4076
bf501fb9
PE
4077 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4078
e9829fdf
PE
4079 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4080 to read-only memory.
4081
1086c095
PE
4082 * fns.c (vector): Remove; this old hack is no longer needed.
4083
2baccd04 4084 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4085 Remove unused var.
dde42981 4086 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4087
72391843 4088 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4089
436c16df 4090 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4091 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4092 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4093
92bb796d 4094 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4095 (x_term_init): Remove local to avoid shadowing.
92bb796d 4096
764430a3 4097 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4098
4099 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4100 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4101
d1dfb56c
EZ
41022011-04-16 Eli Zaretskii <eliz@gnu.org>
4103
c4354cb4
EZ
4104 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4105
d1dfb56c
EZ
4106 Fix regex.c, syntax.c and friends for buffers > 2GB.
4107 * syntax.h (struct gl_state_s): Declare character position members
4108 EMACS_INT.
4109
4110 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4111
04f2d78b
CB
4112 * textprop.c (verify_interval_modification, interval_of):
4113 Declare arguments EMACS_INT.
d1dfb56c
EZ
4114
4115 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4116 EMACS_INT.
4117
4118 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4119
4120 * indent.c (Fvertical_motion): Local variable it_start is now
4121 EMACS_INT.
4122
4123 * regex.c (re_match, re_match_2, re_match_2_internal)
4124 (bcmp_translate, regcomp, regexec, print_double_string)
4125 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4126 (re_compile_pattern, re_exec): Declare arguments and local
4127 variables `size_t' and `ssize_t' and return values `regoff_t', as
4128 appropriate.
4129 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4130 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4131 <compile_stack_type>: `size' and `avail' are now `size_t'.
4132
4133 * regex.h <regoff_t>: Use ssize_t, not int.
4134 (re_search, re_search_2, re_match, re_match_2): Arguments that
4135 specify buffer/string position and length are now ssize_t and
4136 size_t. Return type is regoff_t.
4137
613052cd
BK
41382011-04-16 Ben Key <bkey76@gmail.com>
4139
4140 * nsfont.m: Fixed bugs in ns_get_family and
4141 ns_descriptor_to_entity that were caused by using free to
4142 deallocate memory blocks that were allocated by xmalloc (via
4143 xstrdup). This caused Emacs to crash when compiled with
4144 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4145 --enable-checking=xmallocoverrun). xfree is now used to
4146 deallocate these memory blocks.
4147
4170f62f 41482011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4149
71b41406
PE
4150 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4151
9587a89d
PE
4152 emacs_write: Accept and return EMACS_INT for sizes.
4153 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4154 et seq.
4155 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4156 Accept and return EMACS_INT.
4157 (emacs_gnutls_write): Return the number of bytes written on
4158 partial writes.
4159 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4160 (emacs_read, emacs_write): Remove check for negative size, as the
4161 Emacs source code has been audited now.
9587a89d
PE
4162 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4163 (emacs_read, emacs_write): Use it.
273a5f82
PE
4164 * process.c (send_process): Adjust to the new signatures of
4165 emacs_write and emacs_gnutls_write. Do not attempt to store
4166 a byte offset into an 'int'; it might overflow.
9587a89d 4167 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4168
3e047f51
PE
4169 * sound.c: Don't assume sizes fit in 'int'.
4170 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4171 Return EMACS_INT, not int.
3e047f51 4172 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4173 Accept EMACS_INT, not int.
4174 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4175 record read return values.
4176
cc39a9db
BK
41772011-04-15 Ben Key <bkey76@gmail.com>
4178
c9d0ec6d
JB
4179 * keyboard.c (Qundefined): Don't declare static since it is used
4180 in nsfns.m.
4181 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4182 static since they are used in nsfont.m.
cc39a9db 4183
6c60eb9f
SM
41842011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4185
4186 * process.c (Qprocessp): Don't declare static.
4187 * lisp.h (Qprocessp): Declare again.
4188
7990b61a
JB
41892011-04-15 Juanma Barranquero <lekktu@gmail.com>
4190
4191 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4192
5d4cb038
PE
41932011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4194
8bd7b830 4195 Improve C-level modularity by making more things 'static'.
cd64ea1d 4196
e3b27b31
PE
4197 Don't publish debugger-only interfaces to other modules.
4198 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4199 (verify_bytepos, count_markers): Move decls to the only modules
4200 that need them.
4201 * region-cache.h (pp_cache): Likewise.
4202 * window.h (check_all_windows): Likewise.
4203 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4204
5d4cb038
PE
4205 * sysdep.c (croak): Now static, if
4206 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4207 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4208
4209 * alloc.c (refill_memory_reserve): Now static if
4210 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4211 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4212
e87b6180
PE
4213 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4214 Define only if USE_LUCID.
4215
ac64929e
PE
4216 * xrdb.c (x_customization_string, x_rm_string): Now static.
4217
6f37259d
PE
4218 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4219 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4220
1683e3ab
PE
4221 * xdisp.c (draw_row_with_mouse_face): Now static.
4222 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4223
de9c2632
PE
4224 * window.h (check_all_windows): Mark externally visible.
4225
2b96acb7
PE
4226 * window.c (window_deletion_count): Now static.
4227
4228 * undo.c: Make symbols static if they're not exported.
4229 (last_undo_buffer, last_boundary_position, pending_boundary):
4230 Now static.
4231
50436f33
PE
4232 * textprop.c (interval_insert_behind_hooks): Now static.
4233 (interval_insert_in_front_hooks): Likewise.
4234
64520e5c
PE
4235 * term.c: Make symbols static if they're not exported.
4236 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4237 (max_frame_lines, tty_set_terminal_modes):
4238 (tty_reset_terminal_modes, tty_turn_off_highlight):
4239 (get_tty_terminal): Now static.
4240 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4241 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4242 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4243 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4244 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4245
1fa53021
PE
4246 * sysdep.c: Make symbols static if they're not exported.
4247 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4248 Now static.
4249 (sigprocmask_set, full_mask): Remove; unused.
4250 (wait_debugging): Mark as visible.
4251 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4252 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4253
d4b43b22
PE
4254 * syntax.c (syntax_temp): Define only if !__GNUC__.
4255
b7c513d0
PE
4256 * sound.c (current_sound_device, current_sound): Now static.
4257
989b29ad
PE
4258 * search.c (searchbufs, searchbuf_head): Now static.
4259
13a55a78
PE
4260 * scroll.c (scroll_cost): Remove; unused.
4261 * dispextern.h (scroll_cost): Remove decl.
4262
de68a1fc
PE
4263 * region-cache.h (pp_cache): Mark as externally visible.
4264
40ccffa6
PE
4265 * process.c: Make symbols static if they're not exported.
4266 (process_tick, update_tick, create_process, chan_process):
4267 (Vprocess_alist, proc_buffered_char, datagram_access):
4268 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4269 (deactivate_process): Mark defn as static, as well as decl.
4270 * lisp.h (create_process): Remove decl.
4271 * process.h (chan_process, Vprocess_alist): Remove decls.
4272
ad64fc97
PE
4273 * print.c: Make symbols static if they're not exported.
4274 (print_depth, new_backquote_output, being_printed, print_buffer):
4275 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4276 (print_interval, print_number_index, initial_stderr_stream):
4277 Now static.
4278 * lisp.h (Fprinc): Remove decl.
4279 (debug_output_compilation_hack): Mark as externally visible.
4280
adddb265
PE
4281 * sysdep.c (croak): Move decl from here to syssignal.h.
4282 * syssignal.h (croak): Put it here, so the API can be checked when
4283 'croak' is called from dissociate_if_controlling_tty.
4284
1717ede2
PE
4285 * minibuf.c: Make symbols static if they're not exported.
4286 (minibuf_save_list, choose_minibuf_frame): Now static.
4287 * lisp.h (choose_minibuf_frame): Remove decl.
4288
fa5fb2bc
PE
4289 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4290
1e3890d1
PE
4291 * lread.c: Make symbols static if they're not exported.
4292 (read_objects, initial_obarray, oblookup_last_bucket_number):
4293 Now static.
4294 (make_symbol): Remove; unused.
4295 * lisp.h (initial_obarray, make_symbol): Remove decls.
4296
8a1414fa
PE
4297 * keyboard.c: Make symbols static if they're not exported.
4298 (single_kboard, recent_keys_index, total_keys, recent_keys):
4299 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4300 (this_single_command_key_start, echoing, last_auto_save):
4301 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4302 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4303 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4304 (Vlispy_mouse_stem, double_click_count):
4305 Now static.
4306 (force_auto_save_soon): Define only if SIGDANGER.
4307 (ignore_mouse_drag_p): Now static if
4308 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4309 (print_help): Remove; unused.
4310 (stop_character, last_timer_event): Mark as externally visible.
4311 * keyboard.h (ignore_mouse_drag_p): Declare only if
4312 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4313 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4314 * lisp.h (echoing): Remove decl.
4315 (force_auto_save_soon): Declare only if SIGDANGER.
4316 * xdisp.c (redisplay_window): Simplify code, to make it more
4317 obvious that ignore_mouse_drag_p is not accessed if !defined
4318 USE_GTK && !defined HAVE_NS.
4319
93ea6e8f
PE
4320 * intervals.c: Make symbols static if they're not exported.
4321 (merge_properties_sticky, merge_interval_right, delete_interval):
4322 Now static.
4323 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4324
77382fcc
PE
4325 * insdel.c: Make symbols static if they're not exported.
4326 However, leave prepare_to_modify_buffer alone. It's never
4327 called from outside this function, but that appears to be a bug.
4328 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4329 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4330 (adjust_after_replace_noundo): Remove; unused.
4331 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4332 (signal_before_change): Remove decls.
77382fcc 4333
9306c32e
PE
4334 * indent.c (val_compute_motion, val_vmotion): Now static.
4335
cd44d2eb
PE
4336 * image.c: Make symbols static if they're not exported.
4337 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4338 if USE_GTK.
4339 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4340 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4341
ad9a7a06
PE
4342 * fringe.c (standard_bitmaps): Now static.
4343 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4344
81626931
PE
4345 * frame.c: Make symbols static if they're not exported.
4346 (x_report_frame_params, make_terminal_frame): Now static.
4347 (get_frame_param): Now static, unless HAVE_NS.
4348 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4349 (x_get_resource_string): Remove; not used.
4350 * frame.h (make_terminal_frame, x_report_frame_params):
4351 (x_get_resource_string); Remove decls.
4352 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4353 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4354
239f9db9
PE
4355 * font.c, fontset.c: Make symbols static if they're not exported.
4356 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4357 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4358 * font.c (font_close_object): Now static.
4359 * font.h (font_close_object): Remove.
4360 * fontset.c (FONTSET_OBJLIST): Remove.
4361 (free_realized_fontset) #if-0 the body, which does nothing.
4362 (face_suitable_for_char_p): #if-0, as it's never called.
4363 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4364 * xfaces.c (face_at_string_position):
4365 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4366 since 0 is always ASCII.
4367
dfcf3579
PE
4368 * fns.c (weak_hash_tables): Now static.
4369
5045092b
PE
4370 * fileio.c: Make symbols static if they're not exported.
4371 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4372 (Vwrite_region_annotation_buffers): Now static.
4373
57a96f5c
PE
4374 * eval.c: Make symbols static if they're not exported.
4375 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4376 * lisp.h (backtrace_list): Remove decl.
4377
35f08c38
PE
4378 * emacs.c: Make symbols static if they're not exported.
4379 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4380 (fatal_error_code, fatal_error_signal_hook, standard_args):
4381 Now static.
4382 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4383 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4384 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4385 * lisp.h (fatal_error_signal_hook): Remove decl.
4386 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4387
f44bd759
PE
4388 * editfns.c: Move a (normally-unused) function to its only use.
4389 * editfns.c, lisp.h (get_operating_system_release): Remove.
4390 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4391 worth the hassle of breaking this out.
4392
b532497d
PE
4393 * xterm.c: Make symbols static if they're not exported.
4394 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4395 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4396 (x_destroy_window, x_delete_display):
4397 Now static.
4398 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4399 (x_mouse_leave): Remove; unused.
4400 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4401 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4402 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4403 Remove decls.
4404 (x_mouse_leave): Declare only if WINDOWSNT.
4405 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4406 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4407 USE_X_TOOLKIT.
4408
1675728f
PE
4409 * ftxfont.c: Make symbols static if they're not exported.
4410 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4411 HAVE_FREETYPE.
4412 * font.h (ftxfont_driver): Likewise.
4413
e4cebfca
PE
4414 * xfns.c: Make symbols static if they're not exported.
4415 (x_last_font_name, x_display_info_for_name):
4416 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4417 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4418 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4419 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4420 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4421 (last_show_tip_args): Now static.
4422 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4423 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4424 (x_screen_planes): Remove; unused.
4425 * dispextern.h (x_screen_planes): Remove decl.
4426
5bf46f05
PE
4427 * dispnew.c: Make symbols static if they're not exported.
4428 * dispextern.h (redraw_garbaged_frames, scrolling):
4429 (increment_row_positions): Remove.
4430 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4431 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4432 Now static.
4433 (redraw_garbaged_frames): Remove; unused.
4434
435f4c28
PE
4435 * xfaces.c: Make symbols static if they're not exported.
4436 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4437 Remove decls.
4438 * xterm.h (defined_color): Remove decls.
4439 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4440 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4441 (menu_face_changed_default, defined_color, free_realized_face):
4442 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4443 (ascii_face_of_lisp_face): Remove; unused.
4444
8524aef3
PE
4445 * xdisp.c: Make symbols static if they're not exported.
4446 * dispextern.h (scratch_glyph_row, window_box_edges):
4447 (glyph_to_pixel_coords, set_cursor_from_row):
4448 (get_next_display_element, set_iterator_to_next):
4449 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4450 (show_mouse_face): Remove decls
4451 * frame.h (message_buf_print): Likewise.
4452 * lisp.h (pop_message, set_message, check_point_in_composition):
4453 Likewise.
4454 * xterm.h (set_vertical_scroll_bar): Likewise.
4455 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4456 (message_buf_print, scratch_glyph_row, displayed_buffer):
4457 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4458 (get_next_display_element, show_mouse_face, window_box_edges):
4459 (frame_to_window_pixel_xy, check_point_in_composition):
4460 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4461 (glyph_to_pixel_coords): Remove; unused.
4462
16390cd2
PE
4463 * dired.c (file_name_completion): Now static.
4464
4465 * dbusbind.c (xd_in_read_queued_messages): Now static.
4466
a25f4dfa
PE
4467 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4468 * data.c (circular_list_error): Remove.
4469
14a9c8df
PE
4470 * commands.h (last_point_position, last_point_position_buffer):
4471 (last_point_position_window): Remove decls.
4472 * keyboard.c: Make these variables static.
4473
04f2d78b
CB
4474 * coding.h (coding, code_convert_region, encode_coding_gap):
4475 Remove decls.
74ab6df5
PE
4476 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4477 (iso_code_class, detect_coding, code_convert_region): Now static.
4478 (encode_coding_gap): Remove; unused.
4479
38dfbee1
PE
4480 * chartab.c (chartab_chars, chartab_bits): Now static.
4481
a2cb4e63
PE
4482 * charset.h (charset_iso_8859_1): Remove decl.
4483 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4484 Now static.
4485
127198fd
PE
4486 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4487 * ccl.c (Vccl_program_table): Now static.
4488 (check_ccl_update): Remove; unused.
4489
d85b608f
PE
4490 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4491 * category.h: ... from here.
4492 * category.c (check_category_table, set_category_set): Now static.
4493
31cd66f3
PE
4494 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4495 * lisp.h: Remove these decls.
4496
c358e587
PE
4497 * buffer.c (buffer_count): Remove unused var.
4498
e78aecca
PE
4499 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4500 so that it's not optimized away.
4501 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4502 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4503 exported only to the debugger.
4504
e192d7d3 4505 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4506 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4507
92470028
PE
4508 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4509 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4510 was inaccessible from Lisp.
4511 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4512 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4513
244ed907
PE
4514 alloc.c: Import and export fewer symbols, and remove unused items.
4515 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4516 is defined.
4517 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4518 it's not optimized away by whole-program optimization.
4519 (message_enable_multibyte, free_misc): Remove.
4520 (catchlist, handlerlist, mark_backtrace):
4521 Declare only if BYTE_MARK_STACK.
4522 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4523 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4524 (message_enable_multibyte): Remove decl.
4525 (free_misc, interval_free_list, float_block, float_block_index):
4526 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4527 (cons_free_list, last_marked_index):
4528 Now static.
4529 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4530 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4531 (mark_backtrace): Define only if BYTE_MARK_STACK.
4532 * xdisp.c (message_enable_multibyte): Now static.
4533
61c2b50e 4534 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4535 This makes it easier for human readers (and static analyzers)
4536 to see whether these variables are used from other modules.
4537 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4538 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4539 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4540 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4541 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4542 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4543 * xmenu.c, xselect.c:
4544 Declare Q* vars static if they are not used in other modules.
4545 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4546 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4547 Remove decls of unexported vars.
4548 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4549
95c82688
PE
4550 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4551
16a97296
PE
4552 Make Emacs functions such as Fatom 'static' by default.
4553 This makes it easier for human readers (and static analyzers)
4554 to see whether these functions can be called from other modules.
4555 DEFUN now defines a static function. To make the function external
4556 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4557 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4558 (Finit_image_library):
16a97296
PE
4559 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4560 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4561 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4562 Remove decls, since these functions are now static.
4563 (Funintern, Fget_internal_run_time): New decls, since these functions
4564 were already external.
95c82688 4565
16a97296
PE
4566 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4567 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4568 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4569 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4570 * keyboard.c, keymap.c, lread.c:
4571 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4572 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4573 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4574 Mark functions with DEFUE instead of DEFUN,
4575 if they are used in other modules.
4576 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4577 decls for now-static functions.
4578 * buffer.h (Fdelete_overlay): Remove decl.
4579 * callproc.c (Fgetenv_internal): Mark as internal.
4580 * composite.c (Fremove_list_of_text_properties): Remove decl.
4581 (Fcomposition_get_gstring): New forward static decl.
4582 * composite.h (Fcomposite_get_gstring): Remove decl.
4583 * dired.c (Ffile_attributes): New forward static decl.
4584 * doc.c (Fdocumntation_property): New forward static decl.
4585 * eval.c (Ffetch_bytecode): New forward static decl.
4586 (Funintern): Remove extern decl; now in .h file where it belongs.
4587 * fileio.c (Fmake_symbolic_link): New forward static decl.
4588 * image.c (Finit_image_library): New forward static decl.
4589 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4590 * intervals.h (Fprevious_property_change):
4591 (Fremove_list_of_text_properties): Remove decls.
4592 * keyboard.c (Fthis_command_keys): Remove decl.
4593 (Fcommand_execute): New forward static decl.
4594 * keymap.c (Flookup_key): New forward static decl.
4595 (Fcopy_keymap): Now static.
4596 * keymap.h (Flookup_key): Remove decl.
4597 * process.c (Fget_process): New forward static decl.
4598 (Fprocess_datagram_address): Mark as internal.
4599 * syntax.c (Fsyntax_table_p): New forward static decl.
4600 (skip_chars): Remove duplicate decl.
4601 * textprop.c (Fprevious_property_change): New forward static decl.
4602 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4603 Now internal.
4604 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4605 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4606
785bbd42
PE
4607 * editfns.c (Fformat): Remove unreachable code.
4608
8b913b57
AS
46092011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4610
4611 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4612 change. (Bug#8496)
4613
a6744a35
EZ
46142011-04-13 Eli Zaretskii <eliz@gnu.org>
4615
4616 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4617 when at ZV. (Bug#8487)
4618
e7974947
AS
46192011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4620
baad03f0
AS
4621 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4622 (Bug#8437)
4623 * keyboard.c (parse_tool_bar_item): Likewise.
4624 * sound.c (sound_cleanup, alsa_close): Likewise.
4625 * termcap.c (tgetent): Likewise.
4626 * xfns.c (x_default_font_parameter): Likewise.
4627 * xsettings.c (read_and_apply_settings): Likewise.
4628
e7974947
AS
4629 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4630 (overrun_check_free): Protoize.
4631
28272684
PE
46322011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4633
4634 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4635 since callers should never pass a negative size.
4636 Change the signature to match that of plain 'read' and 'write'; see
4637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4638 * lisp.h: Update prototypes of emacs_write and emacs_read.
4639
11997c76
EZ
46402011-04-11 Eli Zaretskii <eliz@gnu.org>
4641
4642 * xdisp.c (redisplay_window): Don't try to determine the character
4643 position of the scroll margin if the window start point w->startp
e896f03c 4644 is outside the buffer's accessible region. (Bug#8468)
11997c76 4645
8a2cbd72
EZ
46462011-04-10 Eli Zaretskii <eliz@gnu.org>
4647
4648 Fix write-region and its subroutines for buffers > 2GB.
4649 * fileio.c (a_write, e_write): Modify declaration of arguments and
4650 local variables to support buffers larger than 2GB.
4651 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4652
4653 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4654 argument, local variables, and return value.
4655
4656 * lisp.h: Update prototypes of emacs_write and emacs_read.
4657
4658 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4659
4073e537 46602011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4661
1ebfdcb6
PE
4662 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4663
b2ded58d
PE
4664 Fix more problems found by GCC 4.6.0's static checks.
4665
7d66342c
PE
4666 * xdisp.c (vmessage): Use a better test for character truncation.
4667
bbf47d44
PE
4668 * charset.c (load_charset_map): <, not <=, for optimization,
4669 and to avoid potential problems with integer overflow.
9248994d 4670 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4671 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4672 * editfns.c (Fformat): Likewise.
1e69125e 4673 * syntax.c (skip_chars): Likewise.
3befa583 4674
e3019616
PE
4675 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4676 This also lets GCC 4.6.0 generate slightly better loop code.
4677
becfa255
PE
4678 * callint.c (Fcall_interactively): <, not <=, for optimization.
4679 (Fcall_interactively): Count the number of arguments produced,
4680 not the number of arguments given. This is simpler and lets GCC
4681 4.6.0 generate slightly better code.
4682
dae0cd48
PE
4683 * ftfont.c: Distingish more carefully between FcChar8 and char.
4684 The previous code passed unsigned char * to a functions like
4685 strlen and xstrcasecmp that expect char *, which does not
4686 conform to the C standard.
4687 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4688 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4689 char * when the C standard requires it.
4690
76032d70
PE
4691 * keyboard.c (read_char): Remove unused var.
4692
eb3f1cc8
PE
4693 * eval.c: Port to Windows vsnprintf (Bug#8435).
4694 Include <limits.h>.
4695 (SIZE_MAX): Define if the headers do not.
4696 (verror): Do not give up if vsnprintf returns a negative count.
4697 Instead, grow the buffer. This ports to Windows vsnprintf, which
4698 does not conform to C99. Problem reported by Eli Zaretskii.
4699 Also, simplify the allocation scheme, by avoiding the need for
4700 calling realloc, and removing the ALLOCATED variable.
4701
70476b54
PE
4702 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4703
12020a9e
PE
4704 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4705 But keep the doprint source code for now, as we might revamp it
4706 and use it again (Bug#8435).
ea6c7ae6
PE
4707 * lisp.h (doprnt): Remove.
4708 * Makefile.in (base_obj): Remove doprnt.o.
4709 * deps.mk (doprnt.o): Remove.
4710
5fdb398c
PE
4711 error: Print 32- and 64-bit integers portably (Bug#8435).
4712 Without this change, on typical 64-bit hosts error ("...%d...", N)
4713 was used to print both 32- and 64-bit integers N, which relied on
4714 undefined behavior.
4715 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4716 New macro.
4717 * lisp.h (error, verror): Mark as printf-like functions.
4718 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4719 Report overflow in size calculations when allocating printf buffer.
4720 Do not truncate output string at its first null byte.
4721 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4722 Truncate the output at a character boundary, since vsnprintf does not
4723 do that.
4724 * charset.c (check_iso_charset_parameter): Convert internal
4725 character to string before calling 'error', since %c now has the
4726 printf meaning.
4727 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4728 overflow when computing char to be passed to 'error'. Do not
4729 pass Lisp_Object to 'error'; pass the integer instead.
4730 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4731 formatted with plain %d.
4732
b189fa66
PE
4733 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4734
bff87ef0
PE
4735 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4736
7e2cac20
PE
4737 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4738
ce4d90b5
PE
4739 * xterm.c (x_catch_errors): Remove duplicate declaration.
4740
266c9547
PE
4741 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4742
79c49ad2
PE
4743 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4744
368f4090
JM
47452011-04-10 Jim Meyering <meyering@redhat.com>
4746
4747 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4748 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4749 return ssize_t not "int", and use size_t as the buffer length.
4750 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4751 * gnutls.h: Update declarations.
4752 * process.c (read_process_output): Use ssize_t, to match.
4753 (send_process): Likewise.
4754
a32d4040
CY
47552011-04-09 Chong Yidong <cyd@stupidchicken.com>
4756
4757 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4758
8546720e 47592011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4760
04f2d78b
CB
4761 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4762 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4763
8546720e
GM
4764 * xterm.c (handle_one_xevent):
4765 * xmenu.c (create_and_show_popup_menu):
4766 * xselect.c (x_decline_selection_request)
4767 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4768
0a2f5c1a 47692011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4770
4771 Fix some uses of `int' instead of EMACS_INT.
4772 * search.c (string_match_1, fast_string_match)
4773 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4774 (scan_buffer, find_next_newline_no_quit)
4775 (find_before_next_newline, search_command, Freplace_match)
4776 (Fmatch_data): Make some `int' variables be EMACS_INT.
4777
4778 * xdisp.c (display_count_lines): 3rd argument and return value now
4779 EMACS_INT. All callers changed.
4780 (pint2hrstr): Last argument is now EMACS_INT.
4781
4782 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4783 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4784 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4785 (decode_coding_utf_16, decode_coding_emacs_mule)
4786 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4787 (decode_coding_ccl, decode_coding_charset)
4788 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4789 (decode_coding_iso_2022, decode_coding_emacs_mule)
4790 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4791 <char_offset, last_offset>: Declare EMACS_INT.
4792 (encode_coding_utf_8, encode_coding_utf_16)
4793 (encode_coding_emacs_mule, encode_invocation_designation)
4794 (encode_designation_at_bol, encode_coding_iso_2022)
4795 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4796 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4797 Declare EMACS_INT.
4798 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4799 (encode_invocation_designation): Last argument P_NCHARS is now
4800 EMACS_INT.
4801 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4802 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4803
4804 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4805 All users changed.
4806
4807 * ccl.c (Fccl_execute_on_string): Declare some variables
4808 EMACS_INT.
4809
8546720e 48102011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4811
4812 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4813
4e19a977
CS
48142011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4815
4816 * process.c (Fformat_network_address): Doc fix.
4817
87302331
R
48182011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4819
4820 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4821
cbb59342
CY
48222011-04-08 Chong Yidong <cyd@stupidchicken.com>
4823
4824 * keyboard.c (read_char): Call Lisp function help-form-show,
4825 instead of using internal_with_output_to_temp_buffer.
4826 (Qhelp_form_show): New var.
e0d38eeb 4827 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4828
4829 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4830
4831 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4832
e67a13ab
CY
48332011-04-06 Chong Yidong <cyd@stupidchicken.com>
4834
04f2d78b
CB
4835 * process.c (Flist_processes): Remove to Lisp.
4836 (list_processes_1): Delete.
e67a13ab 4837
973f782d
EZ
48382011-04-06 Eli Zaretskii <eliz@gnu.org>
4839
7c106b1e
EZ
4840 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4841
973f782d
EZ
4842 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4843
41cf7d1a 48442011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4845
ca23cc88
PE
4846 Fix more problems found by GCC 4.6.0's static checks.
4847
f390e2d5
PE
4848 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4849
42eea0d0
PE
4850 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4851
b69769da 4852 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4853
f9541e84
PE
4854 * xdisp.c (vmessage): Mark as a printf-like function.
4855
13841b55
PE
4856 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4857
c136c10f
PE
4858 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4859
5e2d4a30
PE
4860 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4861 printf-like functions.
4862 (tiff_load): Add casts to remove these marks before passing them
4863 to system-supplied API.
4864
583f48b9
PE
4865 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4866
b25d760e
PE
4867 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4868 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4869 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4870 directly, rather than having caller test rule sign. This avoids
4871 some unnecessary tests.
4872 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4873 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4874 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4875
bc7b6697 4876 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4877 (xfont_open): Avoid unnecessary tests.
bc7b6697 4878
27ccc379
PE
4879 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4880
dcd5c89a
PE
4881 * composite.h, composite.c (composition_gstring_put_cache):
4882 Use EMACS_INT, not int, for length.
4883
b13a45c6
PE
4884 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4885 breaking out part of COMPOSITION_DECODE_RULE.
4886 (COMPOSITION_DECODE_RULE): Use it.
4887 * composite.c (get_composition_id): Remove unused local vars,
4888 by using the new macro.
4889
1e792e4d
PE
4890 * textprop.c (set_text_properties_1): Change while to do-while,
4891 since the condition is always true at first.
4892
dc6c6455 4893 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4894 (interval_deletion_adjustment): Return unsigned value.
4895 All uses changed.
dc6c6455 4896
aba7731a
PE
4897 * process.c (list_processes_1, create_pty, read_process_output):
4898 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4899 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4900 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4901 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4902 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4903
fdfc4bf3
PE
4904 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4905
fca8fe46 4906 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4907 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4908
06a0259a 4909 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4910 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4911 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4912
e7b9e80f
PE
4913 * print.c (print_error_message): Avoid int overflow.
4914
56201685
PE
4915 * font.c (font_list_entities): Redo for clarity,
4916 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4917
78834453 4918 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4919 (font_score): Avoid potential overflow in diff calculation.
78834453 4920
0bc0b309 4921 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4922 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4923
e610eaca
PE
4924 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4925
b895abce
PE
4926 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4927 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4928 can always succeed if overflow has undefined behavior.
4929
1f1d9321 4930 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4931 (wordify): Omit three unnecessary tests.
1f1d9321 4932
c59478bc
PE
4933 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4934 All callers changed. This avoids the need for an unused var.
4935
79b73827
PE
4936 * casefiddle.c (casify_region): Remove var that is set but not used.
4937
a4db5dfe
PE
4938 * dired.c (file_name_completion): Remove var that is set but not used.
4939
43aae36e
PE
4940 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4941
2a47c44d 4942 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4943 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4944
a37c69bf
PE
4945 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4946 Check for integer overflow on size calculations.
4947
328ab8e7
PE
4948 * buffer.c (Fprevious_overlay_change): Remove var that is set
4949 but not used.
4950
e5a2a5cb
PE
4951 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4952 Remove vars that are set but not used.
8d84a6eb 4953 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4954 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4955
a60e5f68
PE
4956 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4957
f661cb61 4958 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4959 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4960
f0397f5a
PE
4961 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4962 that are set but not used.
4963
8664db06 4964 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4965 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4966
6abdaa4a
PE
4967 * xselect.c (x_get_local_selection, x_handle_property_notify):
4968 Remove vars that are set but not used.
4969
0ce7538d 4970 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4971 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4972
9ae848fc
PE
4973 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4974 Remove var that is set but not used.
0b918413
PE
4975 (scroll_bar_windows_size): Now size_t, not int.
4976 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4977 Check for overflow.
9ae848fc 4978
a5a62657
PE
4979 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4980 (map_tty_color) [!defined MSDOS]: Likewise.
4981
5c5cdd39
PE
4982 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4983
66ebf983
PE
4984 * coding.c: Remove vars that are set but not used.
4985 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4986 All callers changed.
4987 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4988 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4989 (decode_coding_charset): Remove vars that are set but not used.
4990
1be4d761
PE
4991 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4992 that is set but not used.
4993
47553fa8
PE
4994 * print.c (print_object): Remove var that is set but not used.
4995
1f7196bf 4996 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4997 The gnulib version avoids calling malloc in the usual case,
4998 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4999 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5000 * filelock.c (current_lock_owner): Likewise.
5001 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5002 * sysdep.c: Include allocator.h, careadlinkat.h.
5003 (emacs_no_realloc_allocator): New static constant.
5004 (emacs_readlink): New function.
fdb61804
PE
5005 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5006 ../lib/careadlinkat.h.
d1fdcab7 5007
f84c17c7
SM
50082011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5009
5010 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5011 first non-nil return value).
5012
ef3862ad
JD
50132011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5014
5015 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5016 if not defined (Bug#8403).
5017
376a7006
JB
50182011-04-02 Juanma Barranquero <lekktu@gmail.com>
5019
5020 * xdisp.c (display_count_lines): Remove parameter `start',
5021 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5022 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5023 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5024 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5025 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5026 and thereabouts. All callers changed.
5027 (get_per_char_metric): Remove parameter `f', unused since
5028 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5029
6ca3801d
JM
50302011-04-02 Jim Meyering <meyering@redhat.com>
5031
5032 do not dereference NULL upon failed strdup
5033 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5034 (ns_get_family): Likewise.
5035
d8e2b5ba
JB
50362011-04-02 Juanma Barranquero <lekktu@gmail.com>
5037
5038 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5039
8c74fcbd
JD
50402011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5041
5042 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5043 later (Bug#8403).
5044
7200d79c
SM
50452011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5046
03408648 5047 Add lexical binding.
7200d79c 5048
03408648
SM
5049 * window.c (Ftemp_output_buffer_show): New fun.
5050 (Fsave_window_excursion):
5051 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5052
5053 * lread.c (lisp_file_lexically_bound_p): New function.
5054 (Fload): Bind Qlexical_binding.
5055 (readevalloop): Remove `evalfun' arg.
5056 Bind Qinternal_interpreter_environment.
5057 (Feval_buffer): Bind Qlexical_binding.
5058 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5059 Mark as dynamic.
5060 (syms_of_lread): Declare `lexical-binding'.
5061
5062 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5063
5064 * keyboard.c (eval_dyn): New fun.
5065 (menu_item_eval_property): Use it.
ca105506
SM
5066
5067 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5068
03408648
SM
5069 * fns.c (concat, mapcar1): Accept byte-code-functions.
5070
5071 * eval.c (Fsetq): Handle lexical vars.
5072 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5073 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5074 (FletX, Flet): Obey lexical binding.
5075 (Fcommandp): Handle closures.
5076 (Feval): New `lexical' arg.
5077 (eval_sub): New function extracted from Feval. Use it almost
5078 everywhere where Feval was used. Look up vars in lexical env.
5079 Handle closures.
5080 (Ffunctionp): Move from subr.el.
5081 (Ffuncall): Handle closures.
5082 (apply_lambda): Remove `eval_flags'.
5083 (funcall_lambda): Handle closures and new byte-code-functions.
5084 (Fspecial_variable_p): New function.
5085 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5086 but without exporting it to Lisp.
23aba0ea 5087
23aba0ea 5088 * doc.c (Fdocumentation, store_function_docstring):
03408648 5089 * data.c (Finteractive_form): Handle closures.
23aba0ea 5090
03408648
SM
5091 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5092 interactive spec.
ba83908c 5093
04f2d78b
CB
5094 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5095 New byte-codes.
03408648
SM
5096 (exec_byte_code): New function extracted from Fbyte_code to handle new
5097 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5098
03408648 5099 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5100
03408648 5101 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5102
e2abce01
JB
51032011-03-31 Juanma Barranquero <lekktu@gmail.com>
5104
5105 * xdisp.c (redisplay_internal): Fix prototype.
5106
63696a73 51072011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5108
63696a73 5109 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5110 (try_scrolling): Use it when setting scroll_limit.
5111 Limit scrolling to 100 screen lines.
63696a73
EZ
5112 (redisplay_window): Even when falling back on "recentering",
5113 position point in the window according to scroll-conservatively,
5114 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5115
5116 (try_scrolling): When point is above the window, allow searching
5117 as far as scroll_max, or one screenful, to compute vertical
5118 distance from PT to the scroll margin position. This prevents
5119 try_scrolling from unnecessarily failing when
5120 scroll-conservatively is set to a value slightly larger than the
5121 window height. Clean up the case of PT below the margin at bottom
5122 of window: scroll_max can no longer be INT_MAX. When aggressive
5123 scrolling is in use, don't let point enter the opposite scroll
5124 margin as result of the scroll.
5125 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5126 threshold of 100 lines for never-recentering scrolling.
5127
e4cc2dfc
JB
51282011-03-31 Juanma Barranquero <lekktu@gmail.com>
5129
5130 * dispextern.h (move_it_by_lines):
5131 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5132 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5133 (message_log_check_duplicate): Remove parameters `prev_bol' and
5134 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5135 (redisplay_internal): Remove parameter `preserve_echo_area',
5136 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5137
5138 * indent.c (Fvertical_motion):
5139 * window.c (window_scroll_pixel_based, Frecenter):
5140 Don't pass `need_y_p' to `move_it_by_lines'.
5141
1c470562
SM
51422011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5143
44f230aa
SM
5144 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5145 steal a few bits to be more compact.
5146 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5147 Remove unneeded casts.
5148
1c470562
SM
5149 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5150
888adce9
ZK
51512011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5152
5153 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5154 binding" message (bug#7967).
5155
f838ed7b
PE
51562011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5157
77861b95
PE
5158 Fix more problems found by GCC 4.6.0's static checks.
5159
de6dbc14
PE
5160 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5161 Remove unused local var.
5162
f838ed7b
PE
5163 * editfns.c (Fmessage_box): Remove unused local var.
5164
792c7b2b
PE
5165 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5166 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5167 Omit unused local vars.
c499e557 5168 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5169 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5170 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5171 Omit unused local var.
5172
ba0165e1
PE
5173 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5174 Don't assume string length fits in int.
32ad8845 5175 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5176 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5177
3c59b4c9
PE
5178 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5179 instead of alloca (Bug#8344).
5180
a3eed478 5181 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5182 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5183
eb4d412d
PE
5184 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5185
1658b401
PE
5186 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5187 concerns.
5188
5189 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5190
5191 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5192
9a2c6e05
PE
5193 * keyboard.c (syms_of_keyboard): Use the same style as later
5194 in this function when indexing through an array. This also
5195 works around GCC bug 48267.
5196
03d0a109
PE
5197 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5198
44f730c8
PE
5199 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5200
fe75f926
PE
5201 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5202 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5203
ffa8c828
PE
5204 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5205 This avoids undefined behavior on integer overflow, and is a bit
5206 more convenient anyway since it is compared to a size_t variable.
5207
c5101a77
PE
5208 Variadic C functions now count arguments with size_t, not int.
5209 This avoids an unnecessary limitation on 64-bit machines, which
5210 caused (substring ...) to crash on large vectors (Bug#8344).
5211 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5212 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5213 All variadic functions and their callers changed accordingly.
c5101a77
PE
5214 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5215 * data.c (arith_driver, float_arith_driver): Likewise.
5216 * editfns.c (general_insert_function): Likewise.
5217 * eval.c (struct backtrace.nargs, interactive_p)
5218 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5219 (funcall_lambda, mark_backtrace): Likewise.
5220 * fns.c (concat): Likewise.
5221 * frame.c (x_set_frame_parameters): Likewise.
5222 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5223 0 if not found, not -1. All callers changed.
5224
dd3f25f7
PE
5225 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5226 (stack_copy_size): Now size_t, not int.
5227 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5228
461c2ab9
JB
52292011-03-28 Juanma Barranquero <lekktu@gmail.com>
5230
5231 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5232 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5233 All callers changed.
5234
5235 * lisp.h (multibyte_char_to_unibyte):
5236 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5237 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5238 * character.h (CHAR_TO_BYTE8):
5239 * cmds.c (internal_self_insert):
5240 * editfns.c (general_insert_function):
5241 * keymap.c (push_key_description):
5242 * search.c (Freplace_match):
5243 * xdisp.c (message_dolog, set_message_1): All callers changed.
5244
f6d62986
SM
52452011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5246
5247 * keyboard.c (safe_run_hook_funcall): New function.
5248 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5249 don't set the hook to nil, but remove the offending function instead.
5250 (Qcommand_hook_internal): Remove, unused.
5251 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5252 Vcommand_hook_internal.
5253
5254 * eval.c (enum run_hooks_condition): Remove.
5255 (funcall_nil, funcall_not): New functions.
5256 (run_hook_with_args): Call each function through a `funcall' argument.
5257 Remove `cond' argument, now redundant.
5258 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5259 (Frun_hook_with_args_until_failure): Adjust accordingly.
5260 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5261
1db5b1ad
JB
52622011-03-28 Juanma Barranquero <lekktu@gmail.com>
5263
5264 * dispextern.h (string_buffer_position): Remove declaration.
5265
5266 * print.c (strout): Remove parameter `multibyte', unused since
5267 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5268
5269 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5270 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5271 All callers changed.
5272
5273 * w32.c (_wsa_errlist): Use braces for struct initializers.
5274
5275 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5276 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5277 All callers changed.
5278 (string_buffer_position): Likewise. Also, make static (it's never
5279 used outside xdisp.c).
5280 (cursor_row_p): Remove parameter `w', unused since
5281 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5282 (decode_mode_spec): Remove parameter `precision', introduced during
5283 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5284 All callers changed.
5285
5ffb62aa
JD
52862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5287
5288 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5289
461c2ab9 52902011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5291
5292 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5293 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5294 (ns_update_auto_hide_menu_bar): New functions.
5295 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5296 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5297 ns_constrain_all_frames.
5298 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5299 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5300
5c380ffb
JD
53012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5302
5303 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5304
9af30bdf
GM
53052011-03-27 Glenn Morris <rgm@gnu.org>
5306
5307 * syssignal.h: Replace RETSIGTYPE with void.
5308 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5309 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5310 Replace SIGTYPE with void everywhere.
5311 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5312 * s/template.h (SIGTYPE): Remove commented out definition.
5313
e2abce01
JB
53142011-03-26 Eli Zaretskii <eliz@gnu.org>
5315
5316 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5317 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5318
f868cd8a
JB
53192011-03-26 Juanma Barranquero <lekktu@gmail.com>
5320
59eb0929
JB
5321 * w32.c (read_unc_volume): Use parameter `henum', instead of
5322 global variable `wget_enum_handle'.
5323
5324 * keymap.c (describe_vector): Remove parameters `indices' and
5325 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5326 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5327
f868cd8a
JB
5328 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5329
5330 * keyboard.c (timer_check): Remove parameter `do_it_now',
5331 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5332 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5333 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5334
5335 * keyboard.c (read_char):
5336 * w32menu.c (w32_menu_display_help):
5337 * xmenu.c (show_help_event, menu_help_callback):
5338 Adjust calls to `show_help_echo'.
5339
5340 * gtkutil.c (xg_maybe_add_timer):
5341 * keyboard.c (readable_events):
5342 * process.c (wait_reading_process_output):
5343 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5344
5345 * insdel.c (adjust_markers_gap_motion):
5346 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5347 (gap_left, gap_right): Don't call it.
5348
2ecf6fdb
CY
53492011-03-25 Chong Yidong <cyd@stupidchicken.com>
5350
5351 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5352 incurred during fontification.
5353
6b1f9ba4
JB
53542011-03-25 Juanma Barranquero <lekktu@gmail.com>
5355
5356 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5357 (DEFVAR_PER_BUFFER): Don't pass it.
5358
5359 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5360 (scrolling_window): Don't pass it.
5361
0f4a96b5
JB
53622011-03-25 Juanma Barranquero <lekktu@gmail.com>
5363
5364 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5365
5366 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5367 and `suffix'.
5368 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5369 of variables specific to SELinux and computation of `encoded_absname'.
5370
5371 * image.c (XPutPixel): Remove unused variable `height'.
5372
5373 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5374
5375 * unexw32.c (get_section_info): Remove unused variable `section'.
5376
5377 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5378 (system_process_attributes): Remove unused variable `sess'.
5379 (sys_read): Remove unused variable `err'.
5380
5381 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5382 (w32_wnd_proc): Remove unused variable `isdead'.
5383 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5384 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5385 (x_create_tip_frame): Remove unused variable `tem'.
5386
5387 * w32inevt.c (w32_console_read_socket):
5388 Remove unused variable `no_events'.
5389
5390 * w32term.c (x_draw_composite_glyph_string_foreground):
5391 Remove unused variable `width'.
5392
1149507c
JB
53932011-03-24 Juanma Barranquero <lekktu@gmail.com>
5394
5395 * w32term.c (x_set_glyph_string_clipping):
5396 Don't pass uninitialized region to CombineRgn.
5397
9c88f339
JB
53982011-03-23 Juanma Barranquero <lekktu@gmail.com>
5399
5400 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5401 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5402 (Fx_close_connection): Remove unused variable `i'.
5403
5404 * w32font.c (w32font_draw): Return number of glyphs.
5405 (w32font_open_internal): Remove unused variable `i'.
5406 (w32font_driver): Add missing initializer.
5407
5408 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5409 (fill_in_menu): Remove unused variable `items_added'.
5410
5411 * w32term.c (last_mouse_press_frame): Remove static global variable.
5412 (w32_clip_to_row): Remove unused variable `f'.
5413 (x_delete_terminal): Remove unused variable `i'.
5414
5415 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5416 (NOTHING): Remove unused static global variable.
5417 (uniscribe_check_otf): Remove unused variable `table'.
5418 (uniscribe_font_driver): Add missing initializers.
5419
dee091a3
JD
54202011-03-23 Julien Danjou <julien@danjou.info>
5421
5422 * term.c (Fsuspend_tty, Fresume_tty):
5423 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5424 * window.c (temp_output_buffer_show):
5425 * insdel.c (signal_before_change):
5426 * frame.c (Fhandle_switch_frame):
5427 * fileio.c (Fdo_auto_save):
5428 * emacs.c (Fkill_emacs):
5429 * editfns.c (save_excursion_restore):
5430 * cmds.c (internal_self_insert):
5431 * callint.c (Fcall_interactively):
5432 * buffer.c (Fkill_all_local_variables):
5433 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5434 Use Frun_hooks.
0f4a96b5 5435 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5436 unconditionnaly since it does the check itself.
5437
2c520ab5 54382011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5439
c9c49752
PE
5440 Fix more problems found by GCC 4.5.2's static checks.
5441
8abc3f12
PE
5442 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5443 the first time through the loop, since we know p0 < p1 then.
5444 This also avoids a gcc -Wstrict-overflow warning.
5445
a2d26660
PE
5446 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5447 leading to a memory leak, possible in functions like
5448 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5449 of objects (Bug#8318).
a2d26660 5450
916c72e9
PE
5451 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5452 that could (at least in theory) be that large.
5453
19ab8a18
PE
5454 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5455 This is less likely to overflow, and avoids undefined behavior if
5456 overflow does occur. All callers changed. Use strtoul to scan
5457 for the unsigned long integer.
b7cbbd6f
PE
5458 (pint2hrstr): Simplify and tune code slightly.
5459 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5460
f0641eff
PE
5461 * scroll.c (do_scrolling): Work around GCC bug 48228.
5462 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5463
7f650bb9
PE
5464 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5465 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5466 (validate_x_resource_name): Simplify count usage.
5467 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5468
37dd57d1
PE
5469 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5470 fail (Bug#8306).
81e56e61 5471
699979fc 5472 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5473
401bf9b4
PE
5474 * process.c (Fmake_network_process): Use socklen_t, not int,
5475 where POSIX says socklen_t is required in portable programs.
5476 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5477 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5478 (Fmake_network_process, server_accept_connection):
5479 (wait_reading_process_output, read_process_output):
5480 Likewise.
5481
b93aacde
PE
5482 * process.c: Rename or move locals to avoid shadowing.
5483 (list_processes_1, Fmake_network_process):
5484 (read_process_output_error_handler, exec_sentinel_error_handler):
5485 Rename or move locals.
4dc343ee 5486 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5487 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5488 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5489 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5490 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5491
af8a867c 5492 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5493 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5494 Include tparam.h instead, since it declares them.
af8a867c
PE
5495 * cm.h (PC): Remove extern decl; tparam.h now does this.
5496 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5497 * terminfo.c: Include tparam.h, to check interfaces.
5498 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5499 (tparam): Adjust signature to match interface in tparam.h;
5500 this removes some undefined behavior. Check that outstring and len
5501 are zero, which they always are with Emacs.
5502 * tparam.h (PC, BC, UP): New extern decls.
5503
0248044d 5504 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5505 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5506
8ff096c1 5507 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5508 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5509 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5510 (ftfont_list): Remove unused local.
49eaafba
PE
5511 (get_adstyle_property, ftfont_pattern_entity):
5512 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5513 Rename locals to avoid shadowing.
8ff096c1 5514
e2be39f6
PE
5515 * xfont.c (xfont_list_family): Mark var as initialized.
5516
c9735e30
PE
5517 * xml.c (make_dom): Now static.
5518
8f5201ae
PE
5519 * composite.c (composition_compute_stop_pos): Rename local to
5520 avoid shadowing.
b246f932
PE
5521 (composition_reseat_it): Remove unused locals.
5522 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5523 (composition_update_it): Mark var as initialized.
11b61122
PE
5524 (find_automatic_composition): Mark vars as initialized,
5525 with a FIXME (Bug#8290).
8f5201ae 5526
760fbc2c
PE
5527 character.h: Rename locals to avoid shadowing.
5528 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5529 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5530 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5531 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5532 to avoid shadowing.
5533
ff08eb85
PE
5534 * textprop.c (property_change_between_p): Remove; unused.
5535
fc7bf025
PE
5536 * intervals.c (interval_start_pos): Now static.
5537
235d7abc
PE
5538 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5539
44f230aa
SM
5540 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5541 Rename locals to avoid shadowing.
3e7d6594 5542
50060332
PE
5543 * sound.c (wav_play, au_play, Fplay_sound_internal):
5544 Fix pointer signedness.
d01f234b 5545 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5546 (wav_play): Initialize a variable to 0, to prevent undefined
5547 behavior (Bug#8278).
50060332 5548
c4fc4e30
PE
5549 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5550
918436ed
PE
5551 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5552
c939f91b
PE
5553 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5554 clobbering (Bug#8298).
b9c7f648
PE
5555 * sysdep.c (sys_subshell): Likewise.
5556 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5557
6bd8c144
PE
5558 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5559 This should get cleaned up, so that child_setup has the
5560 same signature on all platforms.
5561
7710357c 5562 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5563 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5564
c59da222
CY
55652011-03-22 Chong Yidong <cyd@stupidchicken.com>
5566
5567 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5568 not to be necessary, and produces flickering.
5569
66b87493
GM
55702011-03-20 Glenn Morris <rgm@gnu.org>
5571
5572 * config.in: Remove file.
5573
45b6f6d5
JB
55742011-03-20 Juanma Barranquero <lekktu@gmail.com>
5575
5576 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5577 are now in src/globals.h.
5578 (syms_of_minibuf): Remove spurious & from previous change.
5579
3ec03f7e
LL
55802011-03-20 Leo <sdl.web@gmail.com>
5581
5582 * minibuf.c (completing-read-function): New variable.
5583 (completing-read-default): Rename from completing-read.
5584 (completing-read): Call completing-read-function.
5585
b14e3e21
CY
55862011-03-19 Juanma Barranquero <lekktu@gmail.com>
5587
5588 * xfaces.c (Fx_load_color_file):
5589 Read color file from absolute filename (bug#8250).
5590
f2b726e6
JB
55912011-03-19 Juanma Barranquero <lekktu@gmail.com>
5592
5593 * makefile.w32-in: Update dependencies.
5594
09f6ff02
EZ
55952011-03-17 Eli Zaretskii <eliz@gnu.org>
5596
5597 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5598
29a6015a
PE
55992011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5600
a3a6c54e
PE
5601 Fix more problems found by GCC 4.5.2's static checks.
5602
b766f867
PE
5603 * process.c (make_serial_process_unwind, send_process_trap):
5604 (sigchld_handler): Now static.
5605
be02381c
PE
5606 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5607 That way, the code declares only the vars that it needs.
5608 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5609 * s/cygwin.h (PTY_ITERATION): Likewise.
5610 * s/darwin.h (PTY_ITERATION): Likewise.
5611 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5612
57048744
PE
5613 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5614 * process.c (allocate_pty): Don't declare stb unless it's needed.
5615
7914961c 5616 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5617 (CONSTANTLIM): Remove; unused.
5618 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5619 Define only if needed.
7914961c 5620
b3967b18
PE
5621 * unexelf.c (unexec): Name an expression,
5622 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5623 Use a different way to cause a compilation error if anyone uses
5624 n rather than nn, a way that does not involve shadowing.
73366a00 5625 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5626
29a6015a
PE
5627 * deps.mk (unexalpha.o): Remove; unused.
5628
43cfc33e 5629 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5630 * unexec.h: New file.
ce701a33
PE
5631 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5632 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5633 Depend on unexec.h.
5634 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5635 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5636 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5637 Change as necessary to match prototype in unexec.h.
ce701a33 5638
01f44d5a
PE
5639 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5640 shadowing.
4f63c6bb 5641 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5642
a6670b0b
PE
5643 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5644 Rename locals to avoid shadowing.
5645
cef2010d 5646 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5647 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5648
d4d7173a
PE
5649 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5650
f08b802a
PE
5651 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5652 warning when compiling print.c.
5653
3ddb0639
PE
5654 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5655 instead of using an uninitialized var.
5ad03b97 5656 (font_sort_entities): Mark var as initialized.
3ddb0639 5657
170a2692
PE
5658 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5659
e663c700
PE
5660 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5661 pointers to constants.
89bc529a 5662 (font_parse_fcname): Remove unused vars.
7b81e2d0 5663 (font_delete_unmatched): Now static.
ea838e10 5664 (font_get_spec): Remove; unused.
13a547c6
PE
5665 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5666 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5667 Rename or move locals to avoid shadowing.
e663c700 5668
2a80c887 5669 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5670 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5671
1384fa33 5672 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5673 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5674
8b2c52e9
PE
5675 * alloc.c (mark_backtrace): Move decl from here ...
5676 * lisp.h: ... to here, so that it can be checked.
5677
475545b5 5678 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5679 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5680 (lisp_indirect_variable): Name an expression,
5681 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5682 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5683
b1349114 5684 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5685 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5686 Use const pointer when appropriate.
b1349114 5687
a2928364
PE
5688 * lisp.h (get_system_name, get_operating_system_release):
5689 Move decls here, to check interfaces.
5690 * process.c (get_operating_system_release): Move decl to lisp.h.
5691 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5692 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5693 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5694 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5695 (Fformat_time_string, Fencode_time, Finsert_char):
5696 (Ftranslate_region_internal, Fformat):
5697 Rename or remove local vars to avoid shadowing.
9710023e 5698 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5699
a415e694
PE
5700 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5701 avoid shadowing.
5702
8ef4622d
PE
5703 * lisp.h (eassert): Check that the argument compiles, even if
5704 ENABLE_CHECKING is not defined.
5705
946f9a5b
PE
5706 * data.c (Findirect_variable): Name an expression, to avoid
5707 gcc -Wbad-function-cast warning.
112396d6 5708 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5709 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5710 (Fmake_variable_buffer_local, Fmake_local_variable):
5711 Mark variables as initialized.
52746918 5712 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5713
e5aab7e7 5714 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5715 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5716 Rename locals to avoid shadowing.
dff45157
PE
5717 (mark_stack): Move local variables into the #ifdef region where
5718 they're used.
7bc26fdb
PE
5719 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5720 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5721 needed otherwise.
5722 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5723 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5724 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5725
e5aab7e7
PE
5726 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5727 avoids undefined behavior in theory.
5728
4da60324
PE
5729 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5730
88043301
PE
5731 Use functions, not macros, for up- and down-casing (Bug#8254).
5732 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5733 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5734 to use the following functions instead of these macros.
5735 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5736 EMACS_INT, since callers assume the returned value fits in int.
5737 (upcase1): Likewise, for UPCASE_TABLE.
5738 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5739 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5740 the race-condition problem in the old DOWNCASE.
88043301 5741
19ed5445
PE
5742 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5743 Rename locals to avoid shadowing.
5744 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5745 (regex_compile, re_search_2, re_match_2_internal):
5746 Remove unused local vars.
952db0d7
PE
5747 (FREE_VAR): Rewrite so as not to use empty "else",
5748 which gcc can warn about.
da053e48 5749 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5750 (RETALLOC_IF): Define only if needed.
5751 (WORDCHAR_P): Likewise. This one is never needed, but is used
5752 only in a comment talking about a compiler bug, so put inside
5753 the #if 0 of that comment.
5754 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5755 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5756 Remove; unused.
19ed5445 5757
1f3561e4 5758 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5759 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5760 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5761
ded6f8f7
PE
5762 * search.c (simple_search): Remove unused var.
5763
dbd37a95
PE
5764 * dired.c (compile_pattern): Move decl from here ...
5765 * lisp.h: ... to here, so that it can be checked.
5766 (struct re_registers): New forward decl.
5767
7e47afad
PE
5768 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5769
85f24f61
PE
5770 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5771 All uses changed.
5772 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5773 Rename locals to avoid shadowing.
5671df8f 5774 (Fvertical_motion): Mark locals as initialized.
85f24f61 5775
181aa2be 5776 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5777 (casify_region): Mark local as initialized.
181aa2be 5778
930d429c
PE
5779 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5780
7082eac6
PE
5781 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5782 New macros, so that the caller can use some names other than
5783 gcpro1, gcpro2, etc.
5784 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5785 of the new macros.
5786 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5787 argument, for consistency with GCPRO2_VAR, etc: it is now the
5788 prefix of the variable, not the variable itself. All uses
5789 changed.
38b2c076
PE
5790 * dired.c (directory_files_internal, file_name_completion):
5791 Rename locals to avoid shadowing.
5792
15206ed9
PE
5793 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5794 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5795 dired.c's scmp function, had undefined behavior.
5796 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5797 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5798 * buffer.h: ... to here, because these macros use current_buffer,
5799 and the new implementation with inline functions needs to have
5800 current_buffer in scope now, rather than later when the macros
5801 are used.
5802 (downcase, upcase1): New static inline functions.
5803 (DOWNCASE, UPCASE1): Reimplement using these functions.
5804 This avoids undefined behavior in expressions like
5805 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5806 from race conditions in accessing the global variables
5807 case_temp1 and case_temp2.
5808 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5809 * lisp.h (case_temp1, case_temp2): Remove their decls.
5810 * character.h (ASCII_CHAR_P): Move from here ...
5811 * lisp.h: ... to here, so that the inline functions mentioned
5812 above can use them.
5813
4a6bea26
PE
5814 * dired.c (directory_files_internal_unwind): Now static.
5815
f14b7e14
PE
5816 * fileio.c (file_name_as_directory, directory_file_name):
5817 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5818 Now static.
2893f146
PE
5819 (file_name_as_directory): Use const pointers when appropriate.
5820 (Fexpand_file_name): Likewise. In particular, newdir might
5821 point at constant storage, so make it a const pointer.
fd4ead52 5822 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5823 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5824 signedness issues.
f839df0c
PE
5825 (Fset_file_times, Finsert_file_contents, auto_save_error):
5826 Rename locals to avoid shadowing.
f14b7e14 5827
5716756e 5828 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5829 (Ftry_completion, Fall_completions): Rename or remove locals
5830 to avoid shadowing.
5716756e 5831
b4c3046a
PE
5832 * marker.c (bytepos_to_charpos): Remove; unused.
5833
b45db522
PE
5834 * lisp.h (verify_bytepos, count_markers): New decls,
5835 so that gcc does not warn that these functions aren't declared.
5836
85876d07
PE
5837 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5838 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5839 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5840 (copy_text): Remove unused local var.
85876d07 5841
03d78a21 5842 * filelock.c (within_one_second): Now static.
b3dd38ab 5843 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5844
5df8f01b
PE
5845 * buffer.c (fix_overlays_before): Mark locals as initialized.
5846 (fix_start_end_in_overlays): Likewise. This function should be
5847 simplified by using pointers-to-pointers, but that's a different
5848 matter.
b1d876f1 5849 (switch_to_buffer_1): Now static.
8f54f30a
PE
5850 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5851 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5852
a70072c9 5853 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5854 Fix pointer signedness issue.
edced198
PE
5855 (sys_subshell): Mark local as volatile if checking for lint,
5856 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5857 (MAXPATHLEN): Define only if needed.
a70072c9 5858
a0977c44
PE
5859 * process.c (serial_open, serial_configure): Move decls from here ...
5860 * systty.h: ... to here, so that they can be checked.
5861
a884fdcc
PE
5862 * fns.c (get_random, seed_random): Move extern decls from here ...
5863 * lisp.h: ... to here, so that they can be checked.
5864
604efe86 5865 * sysdep.c (reset_io): Now static.
b8950c94 5866 (wait_for_termination_signal): Remove; unused.
604efe86 5867
38fc62d9
PE
5868 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5869 (copy_keymap_item, append_key, push_text_char_description):
5870 Now static.
1004a21a 5871 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5872 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5873 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5874 (describe_map_tree):
5875 Rename locals to avoid shadowing.
38fc62d9 5876
2f2650da
PE
5877 * keyboard.c: Declare functions static if they are not used elsewhere.
5878 (echo_char, echo_dash, cmd_error, top_level_2):
5879 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5880 (read_char, kbd_buffer_get_event, make_lispy_position):
5881 (make_lispy_event, make_lispy_movement, apply_modifiers):
5882 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5883 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5884 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5885 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5886 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5887
a053e86c 5888 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5889 (mark_kboards): Move decl here ...
5890 * alloc.c (mark_kboards): ... from here.
a053e86c 5891
4752793e
PE
5892 * lisp.h (force_auto_save_soon): New decl.
5893
74f10ca7 5894 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5895 (DEFINE_DUMMY_FUNCTION): New macro.
5896 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5897 Use it.
c03cd23f
PE
5898 (main): Add casts to avoid warnings
5899 if GCC considers string literals to be constants.
74f10ca7 5900
022e70d4
PE
5901 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5902
59d6fe83
PE
5903 * dbusbind.c: Pointer signedness fixes.
5904 (xd_signature, xd_append_arg, xd_initialize):
5905 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5906 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5907 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5908 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5909
78320123
PE
5910 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5911 if GCC considers string literals to be constants.
49cebcca 5912 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5913
35ac2a97
SM
59142011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5915
fb103ca9
SM
5916 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5917 (print_preprocess, print_object): New macro to fix last change.
5918
35ac2a97
SM
5919 * print.c (print_preprocess): Don't forget font objects.
5920
62973b41
JB
59212011-03-16 Juanma Barranquero <lekktu@gmail.com>
5922
5923 * emacs.c (USAGE3): Doc fixes.
5924
0e48bb22
AS
59252011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5926
5927 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5928 structure.
5929
7684e57b
JB
59302011-03-14 Juanma Barranquero <lekktu@gmail.com>
5931
5932 * lisp.h (VWindow_system, Qfile_name_history):
5933 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5934 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5935 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5936
5937 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5938 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5939
5940 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5941 * w32console.c (detect_input_pending, read_input_pending)
5942 (encode_terminal_code):
5943 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5944 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5945 (w32_system_caret_y, Qfile_name_history):
5946 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5947 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5948 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5949 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5950 * w32proc.c (Qlocal, report_file_error):
5951 * w32term.c (Vwindow_system, updating_frame):
5952 * w32uniscribe.c (initialized, uniscribe_font_driver):
5953 Remove unneeded extern declarations.
5954
2aa46d6c
CY
59552011-03-14 Chong Yidong <cyd@stupidchicken.com>
5956
c96bbc66 5957 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5958
cffc6f3b
CY
59592011-03-13 Chong Yidong <cyd@stupidchicken.com>
5960
5961 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5962 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5963 These macros can no longer be used for assignment.
5964
44f230aa
SM
5965 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5966 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5967 (record_buffer_markers, fetch_buffer_markers): New functions for
5968 recording and fetching special buffer markers.
5969 (set_buffer_internal_1, set_buffer_temp): Use them.
5970
5971 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5972
5973 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5974
5975 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5976 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5977
5978 * xdisp.c (hscroll_window_tree):
5979 (reconsider_clip_changes): Use PT instead of BUF_PT.
5980
d251f04b
EZ
59812011-03-13 Eli Zaretskii <eliz@gnu.org>
5982
5983 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5984 $(EMACS_ROOT)/lib/intprops.h.
5985
f0c77cd1
PE
59862011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5987
3eca4629
PE
5988 Fix more problems found by GCC 4.5.2's static checks.
5989
7c86ee98
PE
5990 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5991 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5992 (xg_free_frame_widgets): Make it clear that a local variable is
5993 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5994 (gdk_window_get_screen): Make it clear that this macro is needed
5995 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5996 (int_gtk_range_get_value): New function, which avoids a diagnostic
5997 from gcc -Wbad-function-cast.
5998 (xg_set_toolkit_scroll_bar_thumb): Use it.
5999 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6000 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6001 (get_utf8_string, xg_get_file_with_chooser):
6002 Rename locals to avoid shadowing.
6003 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6004
41729b81
PE
6005 * xgselect.c (xg_select): Remove unused var.
6006
f0c77cd1
PE
6007 * image.c (four_corners_best): Mark locals as initialized.
6008 (gif_load): Initialize transparent_p to zero (Bug#8238).
6009 Mark another local as initialized.
ec6cf4c6 6010 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6011
ce0ad53d 6012 * image.c (clear_image_cache): Now static.
d5d5a617 6013 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6014 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6015 (x_edge_detection): Remove unnecessary cast that
6016 gcc -Wbad-function-cast diagnoses.
2037898d 6017 (gif_load): Fix pointer signedness.
6ae141d6
PE
6018 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6019 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6020
33383987 60212011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6022
d32df629
PE
6023 Improve quality of tests for time stamp overflow.
6024 For example, without this patch (encode-time 0 0 0 1 1
6025 1152921504606846976) returns the obviously-bogus value (-948597
6026 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6027 reports time overflow. See
6028 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6029 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6030 * editfns.c: Include limits.h and intprops.h.
6031 (TIME_T_MIN, TIME_T_MAX): New macros.
6032 (time_overflow): Move earlier, to before first use.
6033 (hi_time, lo_time): New functions, for an accurate test for
6034 out-of-range times.
6035 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6036 (Fget_internal_run_time): Don't assume time_t fits in int.
6037 (make_time): Use list2 instead of Fcons twice.
6038 (Fdecode_time): More accurate test for out-of-range times.
6039 (check_tm_member): New function.
6040 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6041 (lisp_time_argument): Don't rely on undefined left-shift and
6042 right-shift behavior when checking for time stamp overflow.
8be6f318 6043
fe31d94c
PE
6044 * editfns.c (time_overflow): New function, refactoring common code.
6045 (Fformat_time_string, Fdecode_time, Fencode_time):
6046 (Fcurrent_time_string): Use it.
6047
8be6f318
PE
6048 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6049 * dired.c (make_time): Move to ...
6050 * editfns.c (make_time): ... here.
6051 * systime.h: Note the move.
6052
09d9db2c 60532011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6054
126bc0dc
YM
6055 * fringe.c (update_window_fringes): Remove unused variables.
6056
c47cbdfd
YM
6057 * unexmacosx.c (copy_data_segment): Also copy __got section.
6058 (Bug#8223)
6059
7ac80be9
EZ
60602011-03-12 Eli Zaretskii <eliz@gnu.org>
6061
c96bbc66 6062 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6063 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6064 Constify `char *' arguments and their references according to
6065 prototypes in tparam.h.
6066
ecb0f94d 6067 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6068
7ac80be9
EZ
6069 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6070 Adapt all references accordingly.
6071
6072 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6073
ef1fd07e
TT
60742011-03-11 Tom Tromey <tromey@redhat.com>
6075
6076 * buffer.c (syms_of_buffer): Remove obsolete comment.
6077
7ef4b50c
EZ
60782011-03-11 Eli Zaretskii <eliz@gnu.org>
6079
6080 * termhooks.h (encode_terminal_code): Declare prototype.
6081
6082 * msdos.c (encode_terminal_code): Don't declare prototype.
6083
6084 * term.c (encode_terminal_code): Now external again, used by
6085 w32console.c and msdos.c.
6086
44f230aa
SM
6087 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6088 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6089
4b1ec863 60902011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6091
1714f52b 6092 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6093
4b1ec863
PE
6094 * fringe.c (update_window_fringes): Mark locals as initialized
6095 (Bug#8227).
6096 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6097
524c7aa6
PE
6098 * alloc.c (mark_fringe_data): Move decl from here ...
6099 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6100 to check its interface.
6101 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6102
a5c0af81 6103 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6104 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6105 (fontset_font): Mark local as initialized.
a9a06e0b 6106 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6107
b4716021
PE
6108 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6109
811e9bac 6110 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6111 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6112 (x_own_selection, Fx_disown_selection_internal): Rename locals
6113 to avoid shadowing.
6114 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6115
7e3ab302
PE
6116 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6117 so that the caller can use some name other than gcpro1.
6118 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6119 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6120 (Fx_backspace_delete_keys_p):
6121 Use them to avoid shadowing, and rename vars to avoid shadowing.
6122 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6123 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6124 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6125 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6126 Remove unused locals.
7e3ab302
PE
6127 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6128 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6129 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6130 macros.
f78faa98 6131
e2b13473
PE
6132 * xterm.h (x_mouse_leave): New decl.
6133
77f23912
PE
6134 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6135 Remove unused functions.
cdf4ba58
PE
6136 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6137 (x_calc_absolute_position): Now static.
7411c686 6138 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6139 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6140 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6141 unless they are used.
38d0b34a
PE
6142 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6143 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6144 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6145 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6146 (x_error_catcher, x_connection_closed, x_error_handler):
6147 (x_error_quitter, xembed_send_message, x_iconify_frame):
6148 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6149 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6150 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6151
44f230aa
SM
6152 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6153 Rename or move locals to avoid shadowing.
6b463e58 6154 (tty_defined_color, merge_face_heights): Now static.
5967d051 6155 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6156 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6157 does not deduce is never used uninitialized.
73719eba
PE
6158 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6159 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6160
426994c3 6161 * terminal.c (store_terminal_param): Now static.
5489860b 6162
032f1620 6163 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6164 (set_frame_menubar): Remove unused local.
d4323972 6165 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6166 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6167 since they might point to immutable storage.
281585b0
PE
6168 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6169 since it's unused otherwise.
032f1620 6170
367c19e5 6171 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6172 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6173 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6174 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6175 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6176 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6177 does not deduce are never used uninitialized.
70739cbe 6178
07b48fa9
PE
6179 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6180
8868a238 6181 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6182 * window.c (window_loop, size_window):
6183 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6184
7e5cf297 6185 * window.c (display_buffer): Now static.
d6550a9f
PE
6186 (size_window): Mark variables that gcc -Wuninitialized
6187 does not deduce are never used uninitialized.
a586633d
PE
6188 * window.h (check_all_windows): New decl, to forestall
6189 gcc -Wmissing-prototypes diagnostic.
5b555da1 6190 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6191
f6095868
PE
6192 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6193 shadowing.
6194 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6195 Include <limits.h>.
6196 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6197 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6198 (load_charset_map): Mark variables that gcc -Wuninitialized
6199 does not deduce are never used uninitialized.
53df7c11 6200 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6201
f38b440c
PE
6202 * coding.c (coding_set_source, coding_set_destination):
6203 Use "else { /* comment */ }" rather than "else /* comment */;"
6204 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6205 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6206 a block, when the outer 'i' will do.
6207 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6208 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6209 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6210 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6211 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6212 Rename locals to avoid shadowing.
6213 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6214 * coding.c (emacs_mule_char, encode_invocation_designation):
6215 Now static, since they're not used elsewhere.
413bb2db 6216 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6217 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6218 (decode_coding_emacs_mule): Mark variables that gcc
6219 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6220 (detect_coding_iso_2022): Initialize a local variable that might
6221 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6222 this initialization is needed. (Bug#8211)
5f58e762
PE
6223 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6224 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6225 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6226 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6227 Remove unused macros.
f38b440c 6228
232b38b9 6229 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6230 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6231 * character.c (string_count_byte8): Likewise.
232b38b9 6232
fb90da1b
PE
6233 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6234 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6235
fb93dbc2
PE
6236 * chartab.c (copy_sub_char_table): Now static, since it's not used
6237 elsewhere.
5c156ace
PE
6238 (sub_char_table_ref_and_range, char_table_ref_and_range):
6239 Rename locals to avoid shadowing.
bbcd0949 6240 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6241
7d3b3862 6242 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6243 (BIDI_BOB): Remove unused macro.
7d3b3862 6244
6be7d3da
PE
6245 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6246 deduce are never used uninitialized.
c2ed9c8b 6247 * term.c (encode_terminal_code): Likewise.
6be7d3da 6248
75f8807f 6249 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6250
50938595
PE
6251 * tparam.h: New file.
6252 * term.c, tparam.h: Include it.
6253 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6254 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6255 Move these decls to tparam.h, and make them agree with what
6256 is actually in tparam.c. The previous trick of using incompatible
6257 decls in different modules does not conform to the C standard.
6258 All callers of tparam changed to use tparam's actual API.
6259 * tparam.c (tparam1, tparam, tgoto):
6260 Use const pointers where appropriate.
6261
fbceeba2
PE
6262 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6263 * cm.h (struct cm): Likewise.
6264 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6265 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6266 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6267 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6268 (turn_on_face, init_tty): Likewise.
6269 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6270
7f3f1250
PE
6271 * term.c (term_mouse_position): Rename local to avoid shadowing.
6272
e6ca6543
PE
6273 * alloc.c (mark_ttys): Move decl from here ...
6274 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6275
c40f8d15
AS
62762011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6277
6278 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6279
cfe0661d
JB
62802011-03-09 Juanma Barranquero <lekktu@gmail.com>
6281
6282 * search.c (compile_pattern_1): Remove argument regp, unused since
6283 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6284 (compile_pattern): Don't pass it.
6285
0afb4571
J
62862011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6287
6288 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6289 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6290 for ! HAVE_GTK3.
6291 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6292
6293 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6294
6295 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6296 gdk_window_get_screen, gdk_window_get_geometry,
6297 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6298 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6299 (xg_get_pixbuf_from_pixmap): New function.
6300 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6301 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6302 Call xg_get_pixbuf_from_pixmap instead of
6303 gdk_pixbuf_get_from_drawable.
6304 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6305 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6306 (xg_check_special_colors): Use GtkStyleContext and its functions
6307 for HAVE_GTK3.
6308 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6309 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6310 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6311 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6312 Call gtk_widget_get_preferred_size.
0afb4571
J
6313 (xg_frame_resized): gdk_window_get_geometry only takes 5
6314 parameters.
44f230aa
SM
6315 (xg_win_to_widget, xg_event_is_for_menubar):
6316 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6317 (xg_set_widget_bg): New function.
6318 (delete_cb): New function.
895009e1 6319 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6320 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6321 (xg_set_background_color): Call xg_set_widget_bg.
6322 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6323 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6324 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6325 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6326 if ! HAVE_GTK3.
6327 (update_frame_tool_bar): Call gtk_widget_hide.
6328 (xg_initialize): Use GDK_KEY_g.
6329
6330 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6331 if ! HAVE_GTK3
6332 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6333
6334 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6335 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6336 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6337
1c2cc4ef
JB
63382011-03-08 Juanma Barranquero <lekktu@gmail.com>
6339
6340 * w32xfns.c (select_palette): Check success of RealizePalette against
6341 GDI_ERROR, not zero.
6342
33383987 6343See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6344
6345;; Local Variables:
6346;; coding: utf-8
aac0c6e3
MR
6347;; End:
6348
33383987 6349 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6350
6351 This file is part of GNU Emacs.
6352
6353 GNU Emacs is free software: you can redistribute it and/or modify
6354 it under the terms of the GNU General Public License as published by
6355 the Free Software Foundation, either version 3 of the License, or
6356 (at your option) any later version.
6357
6358 GNU Emacs is distributed in the hope that it will be useful,
6359 but WITHOUT ANY WARRANTY; without even the implied warranty of
6360 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6361 GNU General Public License for more details.
6362
6363 You should have received a copy of the GNU General Public License
6364 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.