lisp/gnus/message.el (message-setup-1): Return t (Bug#9392).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6e20a0d4
CY
12011-08-30 Chong Yidong <cyd@stupidchicken.com>
2
3 * syntax.c (find_defun_start): Update all cache variables if
4 exiting early (Bug#9401).
5
148ae00e
EZ
62011-08-30 Eli Zaretskii <eliz@gnu.org>
7
f6cfbd8f
EZ
8 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9
148ae00e
EZ
10 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
11 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
12 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
13
14 * term.c (tty_append_glyph): New function.
15 (produce_stretch_glyph): Static function and its prototype deleted.
16
17 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
18 prototypes.
19
c4a07a4c
PE
202011-08-29 Paul Eggert <eggert@cs.ucla.edu>
21
22 * image.c (parse_image_spec): Check for nonnegative, not for positive,
23 when checking :margin (Bug#9390).
24 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
25 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
26 so that the name doesn't mislead. All uses changed.
27
6bc8cd65
JB
282011-08-28 Johan Bockgård <bojohan@gnu.org>
29
30 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
31 set_tty_hooks.
32
dca4927e
EZ
332011-08-27 Eli Zaretskii <eliz@gnu.org>
34
35 * xdisp.c (move_it_to): Don't bail out early when reaching
36 position beyond to_charpos, if we are scanning backwards.
37 (move_it_vertically_backward): When DY == 0, make sure we get to
38 the first character in the line after the newline.
39
f2cad773
PE
402011-08-27 Paul Eggert <eggert@cs.ucla.edu>
41
42 * ccl.c: Improve and simplify overflow checking (Bug#9196).
43 (ccl_driver): Do not generate an out-of-range pointer.
44 (Fccl_execute_on_string): Remove unnecessary check for
45 integer overflow, noted by Stefan Monnier in
46 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
47 Remove a FIXME that didn't need fixing.
48 Simplify the newly-introduced buffer reallocation code.
49
0cae2cdb
JB
502011-08-27 Juanma Barranquero <lekktu@gmail.com>
51
52 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
53
5fc295a4 542011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 55
70c60eb2 56 Integer and memory overflow issues (Bug#9196).
726e0ab1 57
d31850da
PE
58 * doc.c (get_doc_string): Rework so that
59 get_doc_string_buffer_size is the actual buffer size, rather than
60 being 1 less than the actual buffer size; this makes xpalloc more
61 convenient.
62
a69fbedb
PE
63 * image.c (x_allocate_bitmap_record, cache_image):
64 * xselect.c (Fx_register_dnd_atom):
65 Simplify previous changes by using xpalloc.
66
fe5c5d37
PE
67 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
68 since either will do and ptrdiff_t is convenient with xpalloc.
69
0065d054
PE
70 * charset.c (charset_table_size)
71 (struct charset_sort_data.priority): Now ptrdiff_t.
72 (charset_compare): Don't overflow if priorities differ greatly.
73 (Fsort_charsets): Don't assume list length fits in int.
74 Check for size-calculation overflow when allocating sort data.
75 (syms_of_charset): Allocate an initial charset table that is
76 just under 64 KiB, to avoid problems with glibc malloc and mmap.
77
78 * cmds.c (internal_self_insert): Check for size-calculation overflow.
79
80 * composite.h (struct composition.glyph_len): Now int, not unsigned.
81 The actual value is always <= INT_MAX, and leaving it unsigned made
82 overflow checking harder.
83
84 * dispextern.h (struct glyph_matrix.rows_allocated)
85 (struct face_cache.size): Now ptrdiff_t, for convenience in use
86 with xpalloc. The values are still always <= INT_MAX.
87
88 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
89
90 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
91 (SAFE_NALLOCA): New macro.
92
93 * region-cache.c (struct boundary.pos, find_cache_boundary)
94 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
95 (set_cache_region, invalidate_region_cache)
96 (revalidate_region_cache, know_region_cache, region_cache_forward)
97 (region_cache_backward, pp_cache):
98 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
99 so that ptrdiff_t * can be passed to xpalloc.
100 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
101 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
102 (pp_cache): Don't assume cache_len fits in int.
103 * region-cache.h: Adjust extern decls to match.
104
105 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
106 EMACS_INT, since either will do, for xpalloc.
107
108 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
109 (xnmalloc, xnrealloc, xpalloc): New functions.
110
726e0ab1
PE
111 * bidi.c (bidi_shelve_header_size): New constant.
112 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
113 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
114
51f30bc5 115 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
116 * buffer.c (overlays_at, overlays_in, record_overlay_string)
117 (overlay_strings):
118 Don't update size of array until after memory allocation succeeds,
119 because xmalloc/xrealloc may not return.
0065d054
PE
120 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
121 now that we have proper integer overflow checking.
122 (record_overlay_string, overlay_strings): Catch overflows when
123 calculating size of overlay_str_buf.
726e0ab1 124
0065d054
PE
125 * callproc.c (Fcall_process): Check for size overflow when
126 calculating size of args2.
127 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
128 Normally we prefer signed values, but sticking with ptrdiff_t would
129 require adding more-complicated checks.
726e0ab1
PE
130
131 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
132 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
133 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 134 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
135
136 * character.c (Fstring): Check for size-calculation overflow.
137
138 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
139 unnecessary integer overflow. Check for size overflow.
140 (encode_coding_object): Don't update size until xmalloc succeeds.
141
142 * composite.c (get_composition_id): Check for overflow in glyph
143 length calculations.
144
145 Integer and memory overflow fixes for display code.
146 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
147 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
148 (scrolling_window): Check for overflow in size calculations.
149 (line_draw_cost, realloc_glyph_pool, add_row_entry):
150 Don't assume glyph table len fits in int.
151 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
152 (row_table_size): Now ptrdiff_t, not int.
153 (scrolling_window): Avoid overflow in size calculations.
154 Don't update size until allocation succeeds.
155 * fns.c (concat): Check for overflow in size calculations.
156 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
157 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
158 (NEXT_ALMOST_PRIME_LIMIT): New constant.
159
160 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
161 (get_doc_string): Check for size calculation overflow.
162 Don't update size until allocation succeeds.
163 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
164 EMACS_INT, where ptrdiff_t will do.
165 (Fsubstitute_command_keys): Check for string overflow.
166
167 * editfns.c (set_time_zone_rule): Don't assume environment length
168 fits in int.
169 (message_length): Now ptrdiff_t, not int.
170 (Fmessage_box): Don't update size until allocation succeeds.
171 Don't assume message length fits in int.
172 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
173
0065d054
PE
174 * emacs.c (main): Do not reallocate argv, since there is a null at
175 the end that can be overwritten, and this way there's no need to
176 worry about size-calculation overflow.
177 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
178
179 * eval.c (init_eval_once, grow_specpdl): Don't update size until
180 alloc succeeds.
181 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
182
183 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
184 (x_set_scroll_bar_width, x_figure_window_size):
185 Check for integer overflow.
186 (x_set_alpha): Do not assume XINT fits in int.
187
188 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
189 This is for the members text_lines, text_cols, total_lines, total_cols,
190 where the system imposes an 'int' limit.
191
192 * fringe.c (Fdefine_fringe_bitmap):
193 Don't update size until alloc works.
194
195 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
196 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
197
198 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
199 Check for size-calculation overflow.
200 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
201 do, as we prefer signed integers.
202 (id_to_widget.max_size, id_to_widget.used)
203 (xg_store_widget_in_map, xg_remove_widget_from_map)
204 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
205 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
206 Use and return ptrdiff_t, not int.
207 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
208 * gtkutil.h: Change prototypes to match the above.
209
210 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
211 are duplicate now that they've been promoted to lisp.h.
212 (x_allocate_bitmap_record, x_alloc_image_color)
213 (make_image_cache, cache_image, xpm_load):
214 Don't update size until alloc is done.
215 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
216 (x_detect_edges):
3256efce 217 Check for size calculation overflow.
726e0ab1
PE
218 (ct_colors_allocated_max): New constant.
219 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
220 overflow.
3256efce 221
726e0ab1
PE
222 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
223 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
224 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
225 Use ptrdiff_t, not int, to count maps.
226 (read_char_minibuf_menu_prompt): Check for overflow in size
227 calculations. Don't update size until allocation succeeds. Redo
228 calculations to avoid overflow.
229 * keyboard.h: Change prototypes to match the above.
230
231 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
232 to count maps.
233 (current_minor_maps): Check for size calculation overflow.
234 * keymap.h: Change prototypes to match the above.
235
236 * lread.c (read1, init_obarray): Don't update size until alloc done.
237
238 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
239 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
240
726e0ab1
PE
241 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
242 Now ptrdiff_t, not int.
243 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
244 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
245
246 * process.c (Fnetwork_interface_list): Check for overflow
247 in size calculation.
248
249 * region-cache.c (move_cache_gap): Check for size calculation overflow.
250
251 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
252 overflow. Don't bother calling xmalloc when xrealloc will do.
253
254 * search.c (Freplace_match): Check for size calculation overflow.
255 (Fset_match_data): Don't assume list lengths fit in 'int'.
256
257 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
258 for command line length. Do not attempt to address one before the
259 beginning of an array, as that's not portable.
260
261 * term.c (max_frame_lines): Remove; unused.
262 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
263 not int.
264 (encode_terminal_code, calculate_costs): Check for size
265 calculation overflow.
266 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
267 table lengths and related sizes. Don't update size until alloc
268 done. Redo calculations to avoid overflow.
269 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
270
271 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
272 subtracting pointers.
273 (gobble_line): Check for overflow more carefully. Don't update size
274 until alloc done.
275
276 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
277 Don't update size until alloc done.
278 Redo size calculations to avoid overflow.
279 Check for size calculation overflow.
0065d054 280 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
281
282 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
283 Use ptrdiff_t, not int, for sizes.
284 (store_mode_line_noprop_char): Don't update size until alloc done.
285
0065d054
PE
286 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
287 Use ptrdiff_t, not int, for sizes.
288 (Finternal_make_lisp_face, cache_face):
289 Check for size calculation overflow.
290 (cache_face): Treat size calculation overflows as if they were
291 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
292
293 * xfns.c (x_encode_text, x_set_name_internal)
294 (Fx_change_window_property): Use ptrdiff_t, not int, to count
295 sizes, since they can exceed INT_MAX in size. Check for size
296 calculation overflow.
297
0065d054
PE
298 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
299 (xg_select): Check for size calculation overflow.
726e0ab1
PE
300 Don't update size until alloc done.
301
0065d054 302 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 303 as sprintf is limited to int lengths.
1d526e2f 304
252c5ee1
PE
305 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
306 (X_LONG_MIN): New macros.
864d7ce7
PE
307 Use them to make the following changes clearer.
308 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
309 This change doesn't affect the value now, but it may help remind
310 future maintainers not to raise the value too much later.
311 (SELECTION_QUANTUM): Remove, replacing with ...
312 (selection_quantum): ... new function, which avoids overflow.
313 All uses changed.
314 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
315 assumption that selection length fits in 'int'.
316 (x_reply_selection_request, x_handle_selection_request)
317 (x_get_window_property, receive_incremental_selection)
318 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
319 (lisp_data_to_selection_data, clean_local_selection_data):
320 Use ptrdiff_t, not int, to record length of selection.
321 (x_reply_selection_request, x_get_window_property)
322 (receive_incremental_selection, x_property_data_to_lisp):
323 Redo calculations to avoid overflow.
324 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 325 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
326 something.
327 (x_get_window_property, receive_incremental_selection)
328 (lisp_data_to_selection_data, x_property_data_to_lisp):
329 Check for size-calculation overflow.
330 (x_get_window_property, receive_incremental_selection)
331 (lisp_data_to_selection_data, Fx_register_dnd_atom):
332 Don't store size until memory allocation succeeds.
333 (x_get_window_property): Plug memory leak on memory exhaustion.
334 Don't double-block input; malloc is safe here. Don't assume 2**34
335 - 4 fits in unsigned long. Add an xassert to check
336 XGetWindowProperty overflow. Be more careful about overflow
337 calculations, and distinguish size from memory overflow better.
338 (receive_incremental_selection): When tracing, don't assume
339 unsigned int is less than INT_MAX.
340 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
341 harmful) conversions of unsigned short to int.
342 (lisp_data_to_selection_data): Don't assume that integers
343 in the range -65535 through -1 fit in an X unsigned short.
344 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
345 result parameters unless successful. Rely on cons_to_unsigned
346 to report problems with elements; the old code wasn't right anyway.
347 (x_check_property_data): Check for int overflow; we cannot use
348 a wider type due to X limits.
349 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
350
726e0ab1 351 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 352
0065d054
PE
353 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
354 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
355 (x_color_cells): Don't store size until memory allocation succeeds.
356 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 357 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
358 (x_term_init): Don't assume length fits in int (sprintf is limited
359 to int size).
bc18e09d 360
ebfa62c0
PE
361 Use ptrdiff_t for composition IDs.
362 * character.c (lisp_string_width):
363 * composite.c (composition_table_size, n_compositions)
364 (get_composition_id, composition_gstring_from_id):
365 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
366 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
367 * window.c (Frecenter):
368 Use ptrdiff_t, not int, for composition IDs.
369 * composite.c (get_composition_id): Check for integer overflow.
370 * composite.h: Adjust prototypes to match the above changes.
371
d3411f89
PE
372 Use ptrdiff_t for hash table indexes.
373 * category.c (hash_get_category_set):
374 * ccl.c (ccl_driver):
375 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
376 * coding.c (coding_system_charset_list, detect_coding_system):
377 * coding.h (struct coding_system.id):
378 * composite.c (get_composition_id, gstring_lookup_cache):
379 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
380 * image.c (xpm_get_color_table_h):
381 * lisp.h (hash_lookup, hash_put):
382 * minibuf.c (Ftest_completion):
383 Use ptrdiff_t for hash table indexes, not int (which is too
384 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
385 32-bit --with-wide-int hosts).
386
e097a6fa
PE
387 * charset.c (Fdefine_charset_internal): Check for integer overflow.
388 Add a FIXME comment about memory leaks.
389 (syms_of_charset): Don't assume xmalloc returns.
390
5637687f
PE
391 Don't assume that stated character widths fit in int.
392 * character.c (Fchar_width, c_string_width, lisp_string_width):
393 * character.h (CHAR_WIDTH):
394 * indent.c (MULTIBYTE_BYTES_WIDTH):
395 Use sanitize_char_width to avoid undefined and/or bad behavior
396 with outlandish widths.
397 * character.h (sanitize_tab_width): Renamed from sanitize_width,
398 now that we have two such functions. All uses changed.
399 (sanitize_char_width): New inline function.
400
a2271ba2
PE
401 Don't assume that tab-width fits in int.
402 * character.h (sanitize_width): New inline function.
403 (SANE_TAB_WIDTH): New macro.
404 (ASCII_CHAR_WIDTH): Use it.
405 * indent.c (sane_tab_width): Remove. All uses replaced by
406 SANE_TAB_WIDTH (current_buffer).
407 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
408
18c52557
PE
409 * fileio.c: Integer overflow issues with file modes.
410 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
411
caeeedc1
PE
412 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
413 Remove unreachable code.
414 (read_hex, load_charset_map_from_file): Check for integer overflow.
415
50849c52
PE
416 * xterm.c: don't go over XClientMessageEvent limit
417 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
418 (x_send_scroll_bar_event): Likewise. Check that the size does not
419 exceed limits imposed by XClientMessageEvent, as well as the usual
420 ptrdiff_t and size_t limits.
421
b13995db
PE
422 * keyboard.c: Overflow, signedness and related fixes.
423 (make_lispy_movement): Use same integer type in forward decl
424 that is used in the definition.
425 (read_key_sequence, keyremap_step):
426 Change bufsize argument back to int, undoing my 2011-03-30 change.
427 We prefer signed types, and int is wide enough here.
428 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
429 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
430 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
431 length, not size_t. Use ptrdiff_t for index, not int.
432 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
433 possibility of integer overflow.
434
13464394
PE
435 Overflow, signedness and related fixes for images.
436
437 * dispextern.h (struct it.stack[0].u.image.image_id)
438 (struct_it.image_id, struct image.id, struct image_cache.size)
439 (struct image_cache.used, struct image_cache.ref_count):
440 * gtkutil.c (update_frame_tool_bar):
441 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
442 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
443 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
444 * nsmenu.m (update_frame_tool_bar):
445 * xdisp.c (calc_pixel_width_or_height):
446 * xfns.c (image_cache_refcount):
447 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
448 on typical 64-bit hosts.
449
450 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
451 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
452 Omit unnecessary casts to int.
453 (parse_image_spec): Check that integers fall into 'int' range
454 when the callers expect that.
455 (image_ascent): Redo ascent calculation to avoid int overflow.
456 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
457 (lookup_image): Remove unnecessary tests.
458 (xbm_image_p): Locals are now of int, not EMACS_INT,
459 since parse_image_check makes sure they fit into int.
460 (png_load, gif_load, svg_load_image):
461 Prefer int to unsigned where either will do.
462 (tiff_handler): New function, combining the cores of the
463 old tiff_error_handler and tiff_warning_handler. This
464 function is rewritten to use vsnprintf and thereby avoid
465 stack buffer overflows. It uses only the features of vsnprintf
466 that are common to both POSIX and native Microsoft.
467 (tiff_error_handler, tiff_warning_handler): Use it.
468 (tiff_load, gif_load, imagemagick_load_image):
469 Don't assume :index value fits in 'int'.
470 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
471 (imagemagick_load_image): Check that crop parameters fit into
472 the integer types that MagickCropImage accepts. Don't assume
473 Vimagemagick_render_type has a nonnegative value. Don't assume
474 size_t fits in 'long'.
475 (gs_load): Use printmax_t to print the widest integers possible.
476 Check for integer overflow when computing image height and width.
477
c11821d4
EZ
4782011-08-26 Eli Zaretskii <eliz@gnu.org>
479
480 * xdisp.c (redisplay_window): Don't force window start if point
481 will be invisible in the resulting window. (Bug#9324)
482
0c95fcf7
EZ
4832011-08-25 Eli Zaretskii <eliz@gnu.org>
484
485 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
486 the display spec is of the form `(space ...)'.
487 (handle_display_spec): Return the value returned by
488 handle_single_display_spec, not just 1 or zero.
489 (handle_single_display_spec): If the display spec is of the form
490 `(space ...)', and specifies display in the text area, return 2
491 rather than 1.
fee65a97 492 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
493 accurately, and prefer exact match for point under bidi. Don't
494 advance `row' beyond the last row of the window.
0c95fcf7
EZ
495
496 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
497 into disp_prop; all users changed.
498
499 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
500 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
501 for the text covered by the display property.
502
e4ed06f1
CY
5032011-08-25 Chong Yidong <cyd@stupidchicken.com>
504
505 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
506 Change return value to nil.
507 (Frecord_buffer): Delete unused function.
508
f67cdd7f
EZ
5092011-08-24 Eli Zaretskii <eliz@gnu.org>
510
5980d4c6
EZ
511 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
512 buffers, return left-to-right.
8610fe8b
EZ
513 (set_cursor_from_row): Consider candidate row a win if its glyph
514 represents a newline and point is on that newline. Fixes cursor
515 positioning on the newline at EOL of R2L text within L2R
516 paragraph, and vice versa.
517 (try_cursor_movement): Check continued rows, in addition to
518 continuation rows. Fixes unwarranted scroll when point enters a
519 continued line of R2L text within an L2R paragraph, or vice versa.
520 (cursor_row_p): Consider the case of point being equal to
521 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
522 from the end of a short line to the beginning of a continued line
523 of R2L text within L2R paragraph.
524 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
525 composed characters.
5980d4c6 526
f67cdd7f
EZ
527 * bidi.c (bidi_check_type): Use xassert.
528 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
529 members.
530
bca633fb
EZ
5312011-08-23 Eli Zaretskii <eliz@gnu.org>
532
533 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
534 a character.
535
4a5885a7
CY
5362011-08-23 Chong Yidong <cyd@stupidchicken.com>
537
538 * nsfont.m (ns_otf_to_script): Fix typo.
539
0902a04e
KH
5402011-08-22 Kenichi Handa <handa@m17n.org>
541
542 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
543 extra slot even if the purpose is char-code-property-table.
544
1a2e6670
EZ
5452011-08-23 Eli Zaretskii <eliz@gnu.org>
546
8ddde651
EZ
547 * xdisp.c (redisplay_window): When computing centering_position,
548 account for the height of the header line. (Bug#8874)
549
425cc014
EZ
550 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
551 instead of CHAR_TO_BYTE. Fixes a crash when a completion
552 candidate is selected by the mouse, and that candidate has a
553 composed character under the mouse.
554
1a2e6670
EZ
555 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
556 coordinates reported by pos-visible-in-window-p for a composed
557 character in column zero.
558
8b76d6f8
SM
5592011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
562
dac347dd
EZ
5632011-08-22 Eli Zaretskii <eliz@gnu.org>
564
565 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
566 consider it a hit if to_charpos is anywhere in the range of the
567 composed buffer positions.
568
e013fb34
CY
5692011-08-22 Chong Yidong <cyd@stupidchicken.com>
570
571 * image.c (gif_load): Don't assume that each subimage has the same
572 dimensions as the base image. Handle disposal method that is
573 "undefined" by the gif spec (Bug#9335).
574
bd1ba3e8
CY
5752011-08-20 Chong Yidong <cyd@stupidchicken.com>
576
577 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 578 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 579
54a1215b
EZ
5802011-08-19 Eli Zaretskii <eliz@gnu.org>
581
823564e5
EZ
582 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
583 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
584 from an Org mode buffer to a Speedbar frame.
585
54a1215b
EZ
586 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
587 a composition, take its buffer position from IT->cmp_it.charpos.
588 Fixes cursor positioning at the beginning of a line that begins
589 with a composed character.
590
9778ebcc
EZ
5912011-08-18 Eli Zaretskii <eliz@gnu.org>
592
0be6ee06
EZ
593 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
594 character bidirectional type, use STRONG_L instead. Fixes crashes
595 in a buffer produced by `describe-categories'.
596
9778ebcc
EZ
597 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
598 members before the level stack, so they would be saved and
599 restored when copying iterator state. Fixes incorrect reordering
600 around TABs covered by display properties.
601
156bffbe
AS
6022011-08-18 Andreas Schwab <schwab@linux-m68k.org>
603
604 * process.c (Fnetwork_interface_list): Correctly determine buffer
605 size.
606
72ad093b
CY
6072011-08-17 Chong Yidong <cyd@stupidchicken.com>
608
609 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
610 (internal_condition_case_2, internal_condition_case_n):
611 Remove unnecessary aborts (Bug#9081).
72ad093b 612
35774242
EZ
6132011-08-17 Eli Zaretskii <eliz@gnu.org>
614
615 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
616 has no `load' handler, try opening the file locally. (Bug#9311)
617
db76dd85
KB
6182011-08-16 Ken Brown <kbrown@cornell.edu>
619
620 * gmalloc.c: Expand comment.
621
b215eee5
EZ
6222011-08-16 Eli Zaretskii <eliz@gnu.org>
623
624 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
625 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
626
a4579d33
KB
6272011-08-16 Ken Brown <kbrown@cornell.edu>
628
629 Fix memory allocation problems in Cygwin build (Bug#9273).
630
631 * unexcw.c ( __malloc_initialized): Declare external variable.
632 (fixup_executable): Force the dumped emacs to reinitialize malloc.
633
8b76d6f8
SM
634 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
635 New variables.
a4579d33
KB
636 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
637 dumped emacs.
638 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
639 in the static heap.
640 [CYGWIN] (special_realloc): New function.
641 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
642 requests to realloc storage in the static heap.
643
3ebec551
PE
6442011-08-15 Paul Eggert <eggert@cs.ucla.edu>
645
646 * bidi.c (bidi_initialize): Remove unused local.
647
9fd8be00
EZ
6482011-08-15 Eli Zaretskii <eliz@gnu.org>
649
474a8465
EZ
650 * biditype.h: File removed.
651
652 * bidimirror.h: File removed.
653
654 * deps.mk (bidi.o): Remove biditype.h and
655 bidimirror.h.
656
657 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
658 bidimirror.h.
659
660 * dispextern.h: Fix a typo in the comment to bidi_type_t.
661
662 * chartab.c: Improve commentary for the uniprop_table API.
663
32413314
EZ
664 * bidi.c (bidi_paragraph_init): Support zero value of
665 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
666 (bidi_initialize): Use uniprop_table instead of including
667 biditype.h and bidimirror.h.
32413314 668
9fd8be00
EZ
669 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
670 coordinates of the iterator when restoring from ppos_it.
671 (Bug#9296)
672
5cf2b69b
KH
6732011-08-14 Kenichi Handa <handa@m17n.org>
674
675 * process.c (create_process): Call setup_process_coding_systems
72ad093b 676 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 677
daf17d00
EZ
6782011-08-14 Eli Zaretskii <eliz@gnu.org>
679
680 * xdisp.c (move_it_in_display_line_to): Don't invoke
681 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
682 ppos_it. Fixes vertical cursor motion when line beginning is
683 covered by an image. (Bug#9296)
684
08e3161a
JD
6852011-08-14 Jan Djärv <jan.h.d@swipnet.se>
686
687 * nsterm.h (ns_run_ascript): Declare.
688 (NSAPP_DATA2_RUNASSCRIPT): Define.
689
690 * nsfns.m (as_script, as_result, as_status): New static variables.
691 (ns_run_ascript): New function.
692 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
693 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
694 the event loop. Get status from as_status (Bug#7276).
695
696 * nsterm.m (sendEvent): If event is NSApplicationDefined and
697 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
698 the event loop (Bug#7276).
699
a3720aa2
AS
7002011-08-14 Andreas Schwab <schwab@linux-m68k.org>
701
702 * gnutls.c (QCgnutls_bootprop_priority)
703 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
704 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
705 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
706 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
707 (QCgnutls_bootprop_verify_hostname_error)
708 (QCgnutls_bootprop_callbacks_verify): Rename from
709 Qgnutls_bootprop_..., all uses changed.
710
711 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
712 uses changed.
713
0a0d27fb
PE
7142011-08-14 Paul Eggert <eggert@cs.ucla.edu>
715
19d5c50c
PE
716 * xfaces.c (Qframe_set_background_mode): Now static.
717 * dispextern.h (Qframe_set_background_mode): Remove decl.
718
0a0d27fb
PE
719 * process.c (Fnetwork_interface_info): Declare local only if needed.
720
377538cb
JD
7212011-08-13 Jan Djärv <jan.h.d@swipnet.se>
722
723 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
724 (Fnetwork_interface_list): Allocate in increments of bytes instead
725 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
726 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
727 sockaddr.
728 (struct ifflag_def): notrailers is smart on OSX.
729 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
730 Get hardware address with getifaddrs if available.
731
08fff70c
EZ
7322011-08-12 Eli Zaretskii <eliz@gnu.org>
733
734 * xdisp.c (iterate_out_of_display_property): xassert that
735 IT->position is set to within IT->object's boundaries. Break from
736 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
737 when IT->position is set up wrongly due to some bug.
738 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
739 (push_display_prop): Allow GET_FROM_STRING as IT->method on
740 entry. Force push_it to save on the stack the current
741 buffer/string position, to be restored by pop_it. Fix flags in
742 the iterator structure wrt the object coming from a display
743 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
744 properties. (Bug#9284)
745
7be1c708 7462011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 747
7be1c708
CY
748 * fontset.c (fontset_get_font_group): Add proper type checks.
749 (Bug#9172)
aac0c6e3 750
7be1c708 7512011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 752
7be1c708
CY
753 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
754 and LC_VERSION_MIN_MACOSX.
755 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
756 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 757
97bb72a6
EZ
7582011-08-08 Eli Zaretskii <eliz@gnu.org>
759
760 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
761 no-display-properties-and-no-overlays under bidi display.
762 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 763 properties and overlays.
97bb72a6 764
d5617611
CY
7652011-08-08 Chong Yidong <cyd@stupidchicken.com>
766
37e11a63
CY
767 * editfns.c (Fset_time_zone_rule): Document relationship with the
768 setenv function.
769
d5617611
CY
770 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
771 the font entity extracted from the cache (Bug#8109).
772
58872834
CY
7732011-08-07 Chong Yidong <cyd@stupidchicken.com>
774
775 * composite.c (autocmp_chars): Don't reset point. That is done by
776 restore_point_unwind (Bug#5984).
777
75bfc667
JL
7782011-08-07 Juri Linkov <juri@jurta.org>
779
780 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
781 to show the arg `TIME' instead of `TIMEVAL'.
782
d1410150
EZ
7832011-08-06 Eli Zaretskii <eliz@gnu.org>
784
785 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
786 display property strides EOL and includes a newline, as in
787 longlines-mode. (Bug#9254)
75b771e4
EZ
788 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
789 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
790
791 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
792 is non-zero, even if the data buffer is NULL. Fixes a crash in
793 vertical-motion with longlines-mode. (Bug#9254)
794
35928349
EZ
7952011-08-05 Eli Zaretskii <eliz@gnu.org>
796
ec7cc85b
EZ
797 * bidi.c <bidi_cache_total_alloc>: Now static.
798 (bidi_initialize): Initialize bidi_cache_total_alloc.
799
8b76d6f8 800 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
801 cache. (Bug#9221)
802
803 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
804 amount allocated this far in `bidi_cache_total_alloc'.
805 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
806 non-zero, only free the data buffer without restoring the cache
807 contents. All callers changed.
808
809 * dispextern.h (bidi_unshelve_cache): Update prototype.
810
811 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
812 (move_it_in_display_line, move_it_to)
813 (move_it_vertically_backward, move_it_by_lines): Replace the call
814 to xfree to an equivalent call to bidi_unshelve_cache.
815 (move_it_in_display_line_to): Fix logic of returning
412b6358 816 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 817
e2e2423b
EZ
8182011-08-05 Eli Zaretskii <eliz@gnu.org>
819
820 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
821 came from a string character with a `cursor' property. (Bug#9229)
822
ae9e757a
JD
8232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
824
825 * Makefile.in (LIB_PTHREAD): New variable.
826 (LIBES): Add LIB_PTHREAD (Bug#9216).
827
828 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
829 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
830
213bd7f2
AS
8312011-08-04 Andreas Schwab <schwab@linux-m68k.org>
832
833 * regex.c (re_iswctype): Remove some redundant boolean
834 conversions.
835
99aaf75f
JD
8362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
837
838 * xterm.c (x_find_topmost_parent): New function.
839 (x_set_frame_alpha): Find topmost parent window with
840 x_find_topmost_parent and set the property there also (bug#9181).
841 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
842
c74e9d86
PE
8432011-08-04 Paul Eggert <eggert@cs.ucla.edu>
844
845 * callproc.c (Fcall_process): Avoid vfork clobbering
846 the local vars buffer, coding_systems, current_dir.
847
640c8776
SM
8482011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
849
850 * keymap.c (Fmake_composed_keymap): Move to subr.el.
851
f26d0e4c
PE
8522011-08-03 Paul Eggert <eggert@cs.ucla.edu>
853
8a10d76c
PE
854 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
855 so that it is not optimized away.
856
f26d0e4c
PE
857 * xdisp.c (compute_display_string_pos): Remove unused local.
858
55439c61
EZ
8592011-08-02 Eli Zaretskii <eliz@gnu.org>
860
861 Fix slow cursor motion and scrolling in large buffers with
862 selective display, like Org Mode buffers. (Bug#9218)
863
864 * dispextern.h (struct bidi_it): New member disp_prop_p.
865
866 * xdisp.c: Remove one-slot cache of display string positions.
867 (compute_display_string_pos): Accept an additional argument
868 DISP_PROP_P; callers changed. Scan at most 5K characters forward
869 for a display string or property. If found, set DISP_PROP_P
870 non-zero.
871
872 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
873 DISP_PROP_P, and pass it to compute_display_string_pos.
874 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
875 non-zero. All callers of bidi_fetch_char changed.
876
fb33fa43
SM
8772011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
878
879 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
880
b099e063
DM
8812010-12-03 Don March <don@ohspite.net>
882
883 * keymap.c (Fdefine_key): Fix non-prefix key error message when
884 last character M-[char] is translated to ESC [char] (bug#7541).
885
5cc7f7af
KH
8862011-08-02 Kenichi Handa <handa@m17n.org>
887
d0fffa3f 888 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
889
890 * chartab.c (uniprop_table): Make it non-static.
891
525d5e6e
EZ
8922011-08-01 Eli Zaretskii <eliz@gnu.org>
893
894 * xdisp.c (forward_to_next_line_start): Accept additional argument
895 BIDI_IT_PREV, and store into it the state of the bidi iterator had
896 on the newline.
897 (reseat_at_next_visible_line_start): Use the bidi iterator state
898 returned by forward_to_next_line_start to restore the state of
899 it->bidi_it after backing up to previous newline. (Bug#9212)
900
31011111
AS
9012011-07-30 Andreas Schwab <schwab@linux-m68k.org>
902
903 * regex.c (re_comp): Protoize.
904 (re_exec): Fix return type.
905 (regexec): Fix type of `ret'. (Bug#9203)
906
e5d76069
PE
9072011-07-29 Paul Eggert <eggert@cs.ucla.edu>
908
909 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
910 This is needed if max-image-size is a floating-point number.
911
9a79b20c
AS
9122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
913
914 * print.c (print_object): Print empty symbol as ##.
915
916 * lread.c (read1): Read ## as empty symbol.
917
d8c2fa78
AA
9182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
919
920 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
921 setting frame foreground color (Bug#9175).
922 (x_set_background_color): Likewise.
923
ffe57a7a
AA
924 * nsmenu.m (-setText): Size tooltip dimensions precisely to
925 contents (Bug#9176).
926 (EmacsTooltip -init): Remove bezels and add shadows to
927 tooltip windows.
928
bf3492a5
AA
929 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
930 or scroll bar (Bug#8470).
931
d55e9c53
AA
932 * nsfont.m (nsfont_open): Remove assignment to voffset and
933 unnecessary vars hshink, expand, hd, full_height, min_height.
934 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
935
936 * nsterm.h (nsfont_info): Remove voffset field.
937
d8c2fa78 9382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
939
940 Implement strike-through and overline on NextStep (Bug#8863).
941
942 * nsfont.m (nsfont_open): Use underline position provided by font,
943 instead of hard-coded value of 2.
944 (nsfont_draw): Call ns_draw_text_decoration instead.
945
946 * nsterm.h: Add declaration for ns_draw_text_decoration.
947
948 * nsterm.m (ns_draw_text_decoration): New function for drawing
949 underline, overline, and strike-through.
950 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
951 ns_draw_text_decoration. Change treatment of cursor drawing to
952 accomodate underlining, etc.
953
4cc60b9b
EZ
9542011-07-28 Eli Zaretskii <eliz@gnu.org>
955
bc7ece87
EZ
956 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
957 default.
4cc60b9b 958
476371c4
PE
9592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
960
66606eea
PE
961 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
962 Without this fix, if a signal arrives just after memory fills up,
963 'malloc' might be invoked reentrantly.
964
476371c4
PE
965 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
966 In other words, assume that every image size is allowed, on non-X
967 hosts. This assumption is probably wrong, but it lets Emacs compile.
968
f3fcc40d
AS
9692011-07-28 Andreas Schwab <schwab@linux-m68k.org>
970
971 * regex.c (re_iswctype): Convert return values to boolean.
972
350c992f
EZ
9732011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
974
975 * xdisp.c (compute_display_string_pos): Don't use cached display
976 string position if the buffer had its restriction changed.
977 (Bug#9184)
978
5266b4bb
PE
9792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
980
981 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
982
2573a837 9832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 984
41f55ccd 985 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 986
39e378da
PE
987 * bidi.c: Integer size and overflow fixes.
988 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
989 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
990 (bidi_cache_find_level_change, bidi_cache_ensure_space)
991 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
992 (bidi_find_other_level_edge):
993 Use ptrdiff_t instead of EMACS_INT where either will do.
994 This works better on 32-bit hosts configured --with-wide-int.
995 (bidi_cache_ensure_space): Check for size-calculation overflow.
996 Use % rather than repeated addition, for better worst-case speed.
997 Don't set bidi_cache_size until after xrealloc returns, because it
998 might not return.
999 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1000 (bidi_cache_ensure_space): Also check that the bidi cache size
1001 does not exceed that of the largest Lisp string or buffer. See Eli
1002 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1003
5e927815
PE
1004 * alloc.c (__malloc_size_t): Remove.
1005 All uses replaced by size_t. See Andreas Schwab's note
1006 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1007
ca4aa935
PE
1008 * image.c: Improve checking for integer overflow.
1009 (check_image_size): Assume that f is nonnull, since
1010 it is always nonnull in practice. This is one less thing to
1011 worry about when checking for integer overflow later.
1012 (x_check_image_size): New function, which checks for integer
1013 overflow issues inside X.
1014 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1015 This removes the need for a memory_full check.
1016 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1017 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1018 (xbm_read_bitmap_data): Change locals back to 'int', since
1019 their values must fit in 'int'.
1020 (xpm_load_image, png_load, tiff_load):
1021 Invoke x_create_x_image_and_pixmap earlier,
1022 to avoid much needless work if the image is too large.
1023 (tiff_load): Treat overly large images as if
1024 x_create_x_image_and_pixmap failed, not as malloc failures.
1025 (gs_load): Use x_check_image_size.
1026
5f8f9cc2
PE
1027 * gtkutil.c: Omit integer casts.
1028 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1029 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1030
5adf60bc
PE
1031 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1032
c8907a93
PE
1033 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1034 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1035 would wrongly return t on a 64-bit host.
1036
e3c25c68
PE
1037 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1038 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1039 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1040 and therefore cause GCC to emit a bogus diagnostic in some cases.
1041
3f791afe
PE
1042 * image.c: Integer signedness and overflow and related fixes.
1043 This is not an exhaustive set of fixes, but it's time to
1044 record what I've got.
1045 (lookup_pixel_color, check_image_size): Remove redundant decls.
1046 (check_image_size): Don't assume that arbitrary EMACS_INT values
1047 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1048 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1049 (tiff_load, imagemagick_load_image):
1050 Check for overflow in size calculations.
1051 (x_create_x_image_and_pixmap): Remove unnecessary test for
1052 xmalloc returning NULL; that can't happen.
1053 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1054 (xpm_color_bucket): Use better integer hashing function.
1055 (xpm_cache_color): Don't possibly over-allocate memory.
1056 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1057 (gif_memory_source):
1058 Use ptrdiff_t, not int or size_t, to record sizes.
1059 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1060 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1061 either works, as we prefer signed integers.
1062 (tiff_read_from_memory, tiff_write_from_memory):
1063 Return tsize_t, not size_t, since that's what the TIFF API wants.
1064 (tiff_read_from_memory): Don't fail simply because the read would
1065 go past EOF; instead, return a short read.
1066 (tiff_load): Omit no-longer-needed casts.
1067 (Fimagemagick_types): Don't assume size fits into 'int'.
1068
3cc5a532
PE
1069 Improve hashing quality when configured --with-wide-int.
1070 * fns.c (hash_string): New function, taken from sxhash_string.
1071 Do not discard information about ASCII character case; this
1072 discarding is no longer needed.
1073 (sxhash-string): Use it. Change sig to match it. Caller changed.
1074 * lisp.h: Declare it.
1075 * lread.c (hash_string): Remove, since we now use fns.c's version.
1076 The fns.c version returns a wider integer if --with-wide-int is
1077 specified, so this should help the quality of the hashing a bit.
1078
b312a492
PE
1079 * emacs.c: Integer overflow minor fix.
1080 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1081 Define only if GNU_LINUX.
1082 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1083
dfd153ae
PE
1084 * dispnew.c: Integer signedness and overflow fixes.
1085 Remove unnecessary forward decls, that were a maintenance hassle.
1086 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1087 All uses changed.
1088 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1089 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1090 (prepare_desired_row, line_draw_cost):
1091 Use int, not unsigned, where either works.
1092 (save_current_matrix, restore_current_matrix):
1093 Use ptrdiff_t, not size_t, where either works.
1094 (init_display): Check for overflow more accurately, and without
1095 relying on undefined behavior.
1096
a81d11a3
PE
1097 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1098 Remove, replacing with the new symbols in lisp.h. All uses changed.
1099 * fileio.c (make_temp_name):
1100 * filelock.c (lock_file_1, lock_file):
1101 * xdisp.c (message_dolog):
1102 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1103 Use pMd etc. instead.
1104 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1105 replacing the pWIDE etc. symbols removed from editfns.c.
1106
3300e6fd
PE
1107 * keyboard.h (num_input_events): Now uintmax_t.
1108 This is (very slightly) less likely to mess up due to wraparound.
1109 All uses changed.
1110
fd05c7e9
PE
1111 * buffer.c: Integer signedness fixes.
1112 (alloc_buffer_text, enlarge_buffer_text):
1113 Use ptrdiff_t rather than size_t when either will do, as we prefer
1114 signed integers.
1115
903fe15d
PE
1116 * alloc.c: Integer signedness and overflow fixes.
1117 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1118 (__malloc_size_t): Default to size_t, not to int.
1119 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1120 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1121 Prefer ptrdiff_t to size_t when either would do, as we prefer
1122 signed integers.
1123 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1124 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1125 Now const. Initialize with values that are in range even if char
1126 is signed.
1127 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1128 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1129 These functions do the right thing with sizes > 2**32.
1130 (check_depth): Now ptrdiff_t, not int.
1131 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1132 Adjust to new way of storing sizes. Check for size overflow bugs
1133 in rest of code.
1134 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1135 slightly wrong anyway, as it missed one instance of
1136 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1137 (refill_memory_reserve): Omit needless cast to size_t.
1138 (mark_object_loop_halt): Mark as externally visible.
1139
ac82cc6a
PE
1140 * xselect.c: Integer signedness and overflow fixes.
1141 (Fx_register_dnd_atom, x_handle_dnd_message):
1142 Use ptrdiff_t, not size_t, since we prefer signed.
1143 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1144 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1145 x_dnd_atoms_size and x_dnd_atoms_length.
1146
c2d1e36d
PE
1147 * doprnt.c: Prefer signed to unsigned when either works.
1148 * eval.c (verror):
1149 * doprnt.c (doprnt):
1150 * lisp.h (doprnt):
1151 * xdisp.c (vmessage):
1152 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1153 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1154 prefer signed arithmetic to avoid comparison confusion.
1155 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1156 but is a bit tricky.
1157
0e926e56
PE
1158 Assume freestanding C89 headers, string.h, stdlib.h.
1159 * data.c, doprnt.c, floatfns.c, print.c:
1160 Include float.h unconditionally.
1161 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1162 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1163 * regex.c: Likewise for stddef.h, string.h.
1164 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1165 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1166 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1167 (STDC_HEADERS): Remove obsolete defines.
1168 * sysdep.c: Include limits.h unconditionally.
1169
9cfdb3ec
PE
1170 Assume support for memcmp, memcpy, memmove, memset.
1171 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1172 * regex.c (memcmp, memcpy):
1173 Remove; we assume C89 now.
1174
1175 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1176 (__malloc_safe_bcopy): Remove; no longer needed.
1177
cf950e6b 1178 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1179 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1180 well either way, and we prefer signed to unsigned.
1181
dbf38e02
LMI
11822011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1183
1184 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1185 closes the connection while we're reading (bug#9182).
1186
d6f0886c
JD
11872011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1188
1189 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1190 are specified (Bug#9168).
1191
2eb1f9e6
PE
11922011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1193
1194 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1195 Found by GCC static checking and --with-wide-int on a 32-bit host.
1196
22381272 11972011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1198
1199 * xdisp.c (compute_display_string_pos): Fix logic of caching
1200 previous display string position. Initialize cached_prev_pos to
1201 -1. Fixes slow-down at the beginning of a buffer.
1202
f25e39b4
EZ
12032011-07-24 Eli Zaretskii <eliz@gnu.org>
1204
1205 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1206 for attrs[LFACE_FONTSET_INDEX].
1207
04c4b52e
PE
12082011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 * xml.c (parse_region): Remove unused local
1211 that was recently introduced.
1212
c1734fbd
EZ
12132011-07-23 Eli Zaretskii <eliz@gnu.org>
1214
be18c5a5
EZ
1215 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1216 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1217
c1734fbd
EZ
1218 * xdisp.c (move_it_in_display_line_to): Record the best matching
1219 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1220 exit if none of the characters scanned was an exact match.
1221 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1222 when exact match is impossible due to invisible text, and the
1223 lines are truncated.
1224
a258d627
JD
12252011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1226
1227 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1228 for OSX >= 10.7.
1229
b6d5a689
EZ
12302011-07-22 Eli Zaretskii <eliz@gnu.org>
1231
0f74f785
EZ
1232 Fix a significant slow-down of cursor motion with C-n, C-p,
1233 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1234 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1235 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1236 (next_element_from_buffer): Call compute_stop_pos_backwards to
1237 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1238 base_level_stop.
1239 (reseat): Don't look for prev_stop, as that could mean a very long
1240 run.
1241 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1242 <cached_disp_overlay_modiff>: Cache for last found display string
1243 position.
551918c1 1244 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1245 about the same buffer in the same area of character positions, and
1246 the buffer wasn't changed since the time the display string
1247 position was cached.
551918c1 1248
b2d0c91a
EZ
12492011-07-22 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1252 is an integer, which is important for empty lines. (Bug#9149)
1253
043604ee
CY
12542011-07-22 Chong Yidong <cyd@stupidchicken.com>
1255
1256 * frame.c (Fmodify_frame_parameters): In tty case, update the
1257 default face if necessary (Bug#4238).
1258
da4adb04
CY
12592011-07-21 Chong Yidong <cyd@stupidchicken.com>
1260
1261 * editfns.c (Fstring_to_char): No need to explain what a character
1262 is in the docstring (Bug#6576).
1263
9abd0532
LMI
12642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1265
1266 * xml.c (parse_region): Make sure we always return a tree.
1267
36881d16
HK
12682011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1269
1270 * xml.c (parse_region): If a document contains only comments,
1271 return that, too.
1272
1e98674d
LMI
12732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1274
1275 * xml.c (make_dom): Return comments, too.
1276
590bd467
PE
12772011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1278
1279 Port to OpenBSD.
1280 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1281 and the surrounding thread.
1282 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1283 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1284 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1285 timer goes off.
1286 * s/openbsd.h (BROKEN_SIGIO): Define.
1287 * unexelf.c (unexec) [__OpenBSD__]:
1288 Don't update the .mdebug section of the Alpha COFF symbol table.
1289
f41628b2
LMI
12902011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1291
1292 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1293 (bug#8460).
1294
b59b67c5
PE
12952011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1296
15e3a074
PE
1297 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1298 This fixes some race conditions on the permissions of any newly
1299 created file.
1300
41bed37d
PE
1301 * alloc.c (valid_pointer_p): Use pipe, not open.
1302 This fixes some permissions issues when debugging.
1303
b59b67c5
PE
1304 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1305 If fchown fails to set both uid and gid, try to set just gid,
1306 as that is sometimes allowed. Adjust the file's mode to eliminate
1307 setuid or setgid bits that are inappropriate if fchown fails.
1308
925a6be7
SM
13092011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1310
1311 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1312 to compare Lisp_Objects.
1313 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1314 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1315 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1316
52968808
AS
13172011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1318
0a6a104b
AS
1319 * lread.c (read_integer): Unread even EOF character.
1320 (read1): Likewise. Properly record start position of symbol.
1321
52968808
AS
1322 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1323 symbol character follows.
1324
9e381cdd
PE
13252011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1328 This works around a problem with the previous change to Fcopy_file.
1329 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1330 and without this change, GCC might complain about discarding
1331 fchown's return value.
1332
b5641435
JB
13332011-07-16 Juanma Barranquero <lekktu@gmail.com>
1334
1335 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1336
a8031457
PE
13372011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1338
1339 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1340
dd889327
LMI
13412011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1342
750c33f7
LMI
1343 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1344 it's used from the C level.
1345
dd889327
LMI
1346 * process.c: Use the same condition for POLL_FOR_INPUT in both
1347 keyboard.c and process.c (bug#1858).
1348
87e86684
LM
13492011-07-09 Lawrence Mitchell <wence@gmx.li>
1350
1351 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1352 (Fgnutls_boot): Use it.
1353
64348f40
AS
13542011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1355
1356 * doc.c (Fsubstitute_command_keys): Revert last change.
1357
1d698799
LMI
13582011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1359
f863868c
LMI
1360 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1361 quotes the next character, and doesn't affect other longer
1362 sequences (bug#8935).
1363
1d698799
LMI
1364 * lread.c (syms_of_lread): Clarify that is isn't only
1365 `eval-buffer' and `eval-defun' that's affected by
1366 `lexical-binding' (bug#8460).
1367
aa4b6df6
EZ
13682011-07-15 Eli Zaretskii <eliz@gnu.org>
1369
1370 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1371 bidi redisplay when a line includes both an image and is
1372 truncated.
1373
5d856da6
PE
13742011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1375
ad6042bb
PE
1376 Fix minor problems found by static checking.
1377 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1378 (elsz): Now a signed constant, not a size_t var. We prefer signed
1379 types to unsigned, to avoid integer comparison confusion. Without
1380 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1381 "cannot optimize loop, the loop counter may overflow", a symptom
1382 of the confusion.
f00bbb22 1383 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1384 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1385
6468f31c
LMI
13862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1387
49080b10
LMI
1388 * search.c (Fre_search_backward): Mention `case-fold-search' in
1389 all the re_search_* functions (bug#8138).
1390
6468f31c
LMI
1391 * keyboard.c (Fopen_dribble_file): Document when the file is
1392 closed (bug#8056).
1393
c965adc5
EZ
13942011-07-14 Eli Zaretskii <eliz@gnu.org>
1395
df9733bf
EZ
1396 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1397 bidi_cache_idx.
1398
0bb23927
EZ
1399 Support bidi reordering of display and overlay strings.
1400 * xdisp.c (compute_display_string_pos)
1401 (compute_display_string_end): Accept additional argument STRING.
1402 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1403 (reseat_to_string): Initialize bidi_it->string.s and
1404 bidi_it->string.schars.
1405 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1406 NULL (avoids a crash in bidi_paragraph_init).
1407 Initialize itb.string.lstring.
0bb23927
EZ
1408 (init_iterator): Call bidi_init_it only of a valid
1409 buffer position was specified. Initialize paragraph_embedding to
1410 L2R.
1411 (reseat_to_string): Initialize the bidi iterator.
1412 (display_string): If we need to ignore text properties of
1413 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1414 original value of -1 will not work with bidi.)
1415 (compute_display_string_pos): First arg is now struct
1416 `text_pos *'; all callers changed. Support display properties on
1417 Lisp strings.
1418 (compute_display_string_end): Support display properties on Lisp
1419 strings.
1420 (init_iterator, reseat_1, reseat_to_string): Initialize the
1421 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1422 when iterating on a string not from display properties).
640c8776
SM
1423 (compute_display_string_pos, compute_display_string_end):
1424 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1425 arrow keys.
1426 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1427 base_level_stop; instead, set base_level_stop to BEGV.
1428 Fixes crashes in vertical-motion.
0bb23927
EZ
1429 (next_element_from_buffer): Improve commentary for when
1430 the iterator is before prev_stop.
1431 (init_iterator): Initialize bidi_p from the default value of
1432 bidi-display-reordering, not from buffer-local value. Use the
1433 buffer-local value only if initializing for buffer iteration.
1434 (handle_invisible_prop): Support invisible properties on strings
1435 that are being bidi-reordered.
1436 (set_iterator_to_next): Support bidi reordering of C strings and
1437 Lisp strings.
1438 (next_element_from_string): Support bidi reordering of Lisp
1439 strings.
1440 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1441 (display_string): Support display of R2L glyph rows.
1442 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1443 (init_iterator): Don't initialize it->bidi_p for strings
1444 here.
1445 (reseat_to_string): Initialize it->bidi_p for strings here.
1446 (next_element_from_string, next_element_from_c_string)
1447 (next_element_from_buffer): Add xassert's for correspondence
1448 between IT's object being iterated and it->bidi_it.string
1449 structure.
1450 (face_before_or_after_it_pos): Support bidi iteration.
1451 (next_element_from_c_string): Handle the case of the first string
1452 character that is not the first one in the visual order.
1453 (get_visually_first_element): New function, refactored from common
1454 parts of next_element_from_buffer, next_element_from_string, and
1455 next_element_from_c_string.
1456 (tool_bar_lines_needed, redisplay_tool_bar)
1457 (display_menu_bar): Force left-to-right direction. Add a FIXME
1458 comment for making that be controlled by a user option.
1459 (push_it, pop_it): Save and restore the state of the
1460 bidi iterator. Save and restore the bidi_p flag.
1461 (pop_it): Iterate out of display property for string iteration as
1462 well.
1463 (iterate_out_of_display_property): Support iteration over strings.
1464 (handle_single_display_spec): Set up it->bidi_it for iteration
1465 over a display string, and call bidi_init_it.
1466 (handle_single_display_spec, next_overlay_string)
1467 (get_overlay_strings_1, push_display_prop): Set up the bidi
1468 iterator for displaying display or overlay strings.
1469 (forward_to_next_line_start): Don't use the shortcut if
1470 bidi-iterating.
1471 (back_to_previous_visible_line_start): If handle_display_prop
1472 pushed the iterator stack, restore the internal state of the bidi
1473 iterator by calling bidi_pop_it same number of times.
1474 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1475 and we are bidi-iterating, don't decrement the iterator position;
1476 instead, set the first_elt flag in the bidi iterator, to produce
1477 the same effect.
1478 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1479 (push_display_prop): xassert that we are iterating a buffer.
1480 (push_it, pop_it): Save and restore paragraph_embedding member.
1481 (handle_single_display_spec, next_overlay_string)
1482 (get_overlay_strings_1, reseat_1, reseat_to_string)
1483 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1484 correctly. Don't assume unibyte strings are not bidi-reordered.
1485 (compute_display_string_pos)
1486 (compute_display_string_end): Fix handling the case of C string.
1487 (push_it, pop_it): Save and restore from_disp_prop_p.
1488 (handle_single_display_spec, push_display_prop): Set the
1489 from_disp_prop_p flag.
1490 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1491 (pop_it): Call iterate_out_of_display_property only if we are
1492 popping after iteration over a string that came from a display
1493 property. Fix a typo in popping stretch info. Add an assertion
1494 for verifying that the iterator position is in sync with the bidi
1495 iterator.
1496 (handle_single_display_spec, get_overlay_strings_1)
1497 (push_display_prop): Fix initialization of paragraph direction for
1498 string when that of the parent object is not yet determined.
1499 (reseat_1): Call bidi_init_it to resync the bidi
1500 iterator with IT's position. (Bug#7616)
1501 (find_row_edges): If ROW->start.pos gives position
1502 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1503 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1504 Reset the from_disp_prop_p flag.
1505 (SAVE_IT, RESTORE_IT): New macros.
1506 (pos_visible_p, face_before_or_after_it_pos)
1507 (back_to_previous_visible_line_start)
1508 (move_it_in_display_line_to, move_it_in_display_line)
1509 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1510 (try_scrolling, redisplay_window, display_line): Use them when
1511 saving a temporary copy of the iterator and restoring it back.
1512 (back_to_previous_visible_line_start, reseat_1)
1513 (init_iterator): Empty the bidi cache "stack".
1514 (move_it_in_display_line_to): If iterator ended up at
1515 EOL, but we never saw any buffer positions smaller than
1516 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1517 motion in bidi-reordered lines.
1518 (move_it_in_display_line_to): Record prev_method and prev_pos
1519 immediately before the call to set_iterator_to_next. Fixes cursor
1520 motion in bidi-reordered lines with stretch glyphs and strings
1521 displayed in margins. (Bug#8133) (Bug#8867)
1522 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1523 TO_CHARPOS.
640c8776
SM
1524 (pos_visible_p): Support positions in bidi-reordered lines.
1525 Save and restore bidi cache.
0bb23927
EZ
1526
1527 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1528 (bidi_paragraph_info): Delete unused struct.
1529 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1530 (bidi_cache_start): New variable.
1531 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1532 to zero.
1533 (bidi_cache_fetch_state, bidi_cache_search)
1534 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1535 (bidi_cache_find, bidi_peek_at_next_level)
1536 (bidi_level_of_next_char, bidi_find_other_level_edge)
1537 (bidi_move_to_visually_next): Compare cache index with
1538 bidi_cache_start rather than with zero.
1539 (bidi_fetch_char): Accept new argument STRING; all callers
1540 changed. Support iteration over a string. Support strings with
1541 display properties. Support unibyte strings. Fix the type of
1542 `len' according to what STRING_CHAR_AND_LENGTH expects.
1543 (bidi_paragraph_init, bidi_resolve_explicit_1)
1544 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1545 (bidi_level_of_next_char, bidi_move_to_visually_next):
1546 Support iteration over a string.
0bb23927
EZ
1547 (bidi_set_sor_type, bidi_resolve_explicit_1)
1548 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1549 can now be zero (for strings); special values 0 and -1 were
1550 changed to -1 and -2, respectively.
1551 (bidi_char_at_pos): New function.
1552 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1553 Call it instead of FETCH_MULTIBYTE_CHAR.
1554 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1555 initialized to valid values.
1556 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1557 values.
1558 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1559 the test for valid cached positions. Fix the logic for looking up
1560 the sentinel state in the cache. GCPRO the Lisp string we are
1561 iterating.
1562 (bidi_push_it, bidi_pop_it): New functions.
1563 (bidi_initialize): Initialize the bidi cache start stack pointer.
1564 (bidi_cache_ensure_space): New function, refactored from part of
1565 bidi_cache_iterator_state. Don't assume the required size is just
1566 one BIDI_CACHE_CHUNK away.
1567 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1568 (bidi_count_bytes, bidi_char_at_pos): New functions.
1569 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1570 always valid if bidi_cache_idx is valid.
1571 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1572 is valid if it's going to be used.
1573 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1574 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1575 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1576 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1577 (bidi_find_other_level_edge, bidi_cache_start_stack):
1578 All variables related to cache indices are now EMACS_INT.
c965adc5 1579
0bb23927
EZ
1580 * dispextern.h (struct bidi_string_data): New structure.
1581 (struct bidi_it): New member `string'. Make flag members be 1-bit
1582 fields, and put them last in the struct.
640c8776
SM
1583 (compute_display_string_pos, compute_display_string_end):
1584 Update prototypes.
0bb23927
EZ
1585 (bidi_push_it, bidi_pop_it): Add prototypes.
1586 (struct iterator_stack_entry): New members bidi_p,
1587 paragraph_embedding, and from_disp_prop_p.
1588 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1589 (bidi_shelve_cache, bidi_unshelve_cache):
1590 Declare prototypes.
0bb23927
EZ
1591
1592 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1593 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1594 and vector-like objects.
1595
1596 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1597 cache around display iteration.
1598
1599 * window.c (Fwindow_end, window_scroll_pixel_based)
1600 (displayed_window_lines, Frecenter): Save and restore the bidi
1601 cache around display iteration.
1602
3bbd2265
LMI
16032011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1604
1605 * editfns.c (Fdelete_region): Clarify the use of the named
1606 parameters (bug#6788).
1607
adc47434
MR
16082011-07-14 Martin Rudalics <rudalics@gmx.at>
1609
1610 * indent.c (Fvertical_motion): Set and restore w->pointm when
1611 saving and restoring the window's buffer (Bug#9006).
1612
837c31f8
LMI
16132011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1614
1615 * editfns.c (Fstring_to_char): Clarify just what is returned
1616 (bug#6576). Text by Eli Zaretskii.
1617
ac389d0c
JB
16182011-07-13 Juanma Barranquero <lekktu@gmail.com>
1619
1620 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1621
0be0ce47
EZ
16222011-07-13 Eli Zaretskii <eliz@gnu.org>
1623
1624 * buffer.c (mmap_find): Fix a typo.
1625
cd18e7e3
JB
16262011-07-13 Johan Bockgård <bojohan@gnu.org>
1627
1628 Fix execution of x selection hooks.
1629 * xselect.c (Qx_lost_selection_functions)
1630 (Qx_sent_selection_functions): New vars.
1631 (syms_of_xselect): DEFSYM them.
1632 (x_handle_selection_request): Pass Qx_sent_selection_functions
1633 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1634 (x_handle_selection_clear,x_clear_frame_selections):
1635 Pass Qx_lost_selection_functions rather than
1636 Vx_lost_selection_functions to Frun_hook_with_args.
1637
47ea7f44
PE
16382011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1639
ac389d0c 1640 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1641 The old code sometimes used this field without initializing it.
1642
47ea7f44
PE
1643 * alloc.c (gc_sweep): Don't read past end of array.
1644 In theory, the old code could also have corrupted Emacs internals,
1645 though it'd be very unlikely.
1646
bc985c87
AS
16472011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1648
1649 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1650 argument. (Bug#4026)
bc985c87 1651
0cf34688
LMI
16522011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1653
b3dadd76
LMI
1654 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1655 key" (bug#4257).
1656
0cf34688
LMI
1657 * window.c (Fset_window_start): Doc fix (bug#4199).
1658 (Fset_window_hscroll): Ditto.
1659
270768cd
PE
16602011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1661
077e3dda 1662 Fix minor new problems caught by GCC 4.6.1.
270768cd 1663 * term.c (init_tty): Remove unused local.
490011a6 1664 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1665 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1666 not used otherwise.
270768cd 1667
b1f58454
CY
16682011-07-12 Chong Yidong <cyd@stupidchicken.com>
1669
1670 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1671
22b9578d
LMI
16722011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1673
6e70ab07
LMI
1674 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1675 are the mini-buffer and the echo area (bug#3320).
1676
22b9578d
LMI
1677 * term.c (init_tty): Remove support for supdup, c10 and perq
1678 terminals, which are no longer supported (bug#1482).
1679
8974cc9f
JB
16802011-07-10 Johan Bockgård <bojohan@gnu.org>
1681
1682 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1683
a560d974
JD
16842011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1685
1686 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1687 for non-popups (Bug#3642).
1688
1dae0f0a
AS
16892011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1690
268c2c36 1691 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1692 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1693 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1694 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1695 * data.c (fmod): Likewise.
1696 * dispnew.c (swap_glyphs_in_rows): Likewise.
1697 * emacs.c (memory_warning_signal): Likewise.
1698 * floatfns.c (float_error): Likewise.
1699 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1700 (otf_open, font_otf_capability, generate_otf_features)
1701 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1702 Likewise.
1703 * image.c (pbm_read_file): Likewise.
1704 * indent.c (string_display_width): Likewise.
1705 * intervals.c (check_for_interval, search_for_interval)
1706 (inc_interval_count, count_intervals, root_interval)
1707 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1708 * lread.c (defalias): Likewise.
268c2c36 1709 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1710 * regex.c (set_image_of_range_1, set_image_of_range)
1711 (regex_grow_registers): Likewise.
1712 * sysdep.c (strerror): Likewise.
1713 * termcap.c (valid_filename_p, tprint, main): Likewise.
1714 * tparam.c (main): Likewise.
1715 * unexhp9k800.c (run_time_remap, save_data_space)
1716 (update_file_ptrs, read_header, write_header, calculate_checksum)
1717 (copy_file, copy_rest, display_header): Likewise.
1718 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1719 Likewise.
1720 * xdisp.c (check_it): Likewise.
1721 * xfaces.c (register_color, unregister_color, unregister_colors):
1722 Likewise.
1723 * xfns.c (print_fontset_result): Likewise.
1724 * xrdb.c (member, fatal, main): Likewise.
1725
99033785
PE
17262011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 Fix minor problems found by static checking (Bug#9031).
1729 * chartab.c (char_table_set_range, map_sub_char_table):
1730 Remove unused locals.
1731 (uniprop_table): Now static.
1732 * composite.c (_work_char): Remove unused static var.
1733
9cb2ac56
JB
17342011-07-09 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1737
f25661f0
JD
17382011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1739
1740 * gtkutil.c (qttip_cb): Remove code without function.
1741
8278c4fe
EZ
17422011-07-09 Eli Zaretskii <eliz@gnu.org>
1743
1744 * w32.c (pthread_sigmask): New stub.
1745
1692ae2d 17462011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1747
8a6ebd58 1748 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1749 sigprocmask is portable only for single-threaded applications, and
1750 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1751 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1752 (LIBES): Use it.
1753 * callproc.c (Fcall_process):
1754 * process.c (create_process):
1755 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1756 Use pthread_sigmask, not sigprocmask.
123403e4 1757
1b854618
JD
17582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1759
1760 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1761 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1762 wrong (Bug#8591).
1763
3fe4b549
JD
17642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1765
0ce7e563
JD
1766 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1767 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1768 (xg_hide_tooltip): Fix comment.
1769
3fe4b549
JD
1770 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1771 in registerServicesMenuSendTypes.
1772 (validRequestorForSendType): Don't check ns_return_types.
1773
1774 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1775 ns_return_type.
1776
5df75e47
JR
17772011-07-08 Jason Rumney <jasonr@gnu.org>
1778
1779 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1780 frame struct members of non-existent frames (Bug#6284).
1781
699c10bd
JD
17822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1783
4393663b
JD
1784 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1785 variable firstTime not needed on OSX >= 10.6.
1786 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1787 >= 10.5. Use setKnobProportion, setDoubleValue.
1788
1789 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1790 (MAC_OS_X_VERSION_10_5): Define if not defined.
1791 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1792 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1793 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1794
1795 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1796 cString and lossyCString on OSX >= 10.4
1797
1798 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1799 sizeToFit on OSX >= 10.2.
1800
1801 * nsimage.m (allocInitFromFile): Don't use deprecated method
1802 bestRepresentationForDevice on OSX >= 10.6.
1803
1804 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1805 to avoid warning.
1806
1807 * emacs.c: Declare unexec_init_emacs_zone.
1808
a63e0781
JD
1809 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1810
699c10bd
JD
1811 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1812
1813 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1814 on svcsMenu (Bug#8842).
1815
1816 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1817 ns_return_types.
1818 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1819
1820 * nsterm.m (QUTF8_STRING): Declare.
1821 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1822 (validRequestorForSendType): Return type is (id).
1823 Change indexOfObjectIdenticalTo to indexOfObject.
1824 Check if we have local selection before returning self (Bug#8842).
1825 (writeSelectionToPasteboard): Put local selection into paste board
1826 if we have a local selection (Bug#8842).
1827 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1828
1829 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1830 (ns_get_local_selection): Declare.
1831
54e10184
LMI
18322011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1833
9888ff71
LMI
1834 * keymap.c (describe_map_tree): Don't insert a double newline at
1835 the end of the buffer (bug#1169) and return whether we inserted
1836 something.
1837
54e10184
LMI
1838 * callint.c (Fcall_interactively): Change "reading args" to
1839 "providing args" to try to clarify what it does (bug#1010).
1840
15fa4783
KH
18412011-07-07 Kenichi Handa <handa@m17n.org>
1842
1843 * composite.c (composition_compute_stop_pos): Ignore a static
1844 composition starting before CHARPOS (Bug#8915).
1845
1846 * xdisp.c (handle_composition_prop): Likewise.
1847
a8815b00
EZ
18482011-07-07 Eli Zaretskii <eliz@gnu.org>
1849
1850 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1851 (Bug#9015)
1852
ef7b981d 18532011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1854
1855 * character.h (unicode_category_t): New enum type.
1856
1857 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1858 (Qchar_code_property_table): New variable.
1859 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1860 (UNIPROP_COMPRESSED_FORM_P): New macros.
1861 (char_table_ascii): Uncompress the compressed values.
1862 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1863 Uncompress the compressed values.
ac389d0c 1864 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1865 (char_table_ref_and_range): Uncompress the compressed values.
1866 (sub_char_table_set): New arg is_uniprop. Callers changed.
1867 Uncompress the compressed values.
1868 (sub_char_table_set_range): Args changed. Callers changed.
1869 (char_table_set_range): Adjuted for the above change.
1870 (map_sub_char_table): Delete args default_val and parent. Add arg
1871 top. Give decoded values to a Lisp function.
640c8776 1872 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1873 values to a Lisp function. Gcpro more variables.
1874 (uniprop_table_uncompress)
1875 (uniprop_decode_value_run_length): New functions.
1876 (uniprop_decoder, uniprop_decoder_count): New variables.
1877 (uniprop_get_decoder, uniprop_encode_value_character)
1878 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1879 New functions.
1880 (uniprop_encoder, uniprop_encoder_count): New variables.
1881 (uniprop_get_encoder, uniprop_table)
1882 (Funicode_property_table_internal, Fget_unicode_property_internal)
1883 (Fput_unicode_property_internal): New functions.
1884 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1885 Sunicode_property_table_internal, Sget_unicode_property_internal,
1886 and Sput_unicode_property_internal. Defvar_lisp
1887 char-code-property-alist.
1888
640c8776 1889 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1890 Vunicode_category_table.
1891
640c8776 1892 * font.c (font_range): Adjust for the change of
c805dec0
KH
1893 Vunicode_category_table.
1894
76b397fb
DN
18952011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1896
1897 * m/iris4d.h: Remove file, move contents ...
1898 * s/irix6-5.h: ... here.
1899
22b4128e
PE
19002011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1903 * alloc.c (mark_buffer):
1904 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1905 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1906 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1907 This isn't true in general, and it's particularly not true
1908 if Emacs is configured with --with-wide-int.
1909 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1910 New macros, used in the buffer.c change.
1911
869795d6
JD
19122011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1913
1914 * xsettings.c: Use both GConf and GSettings if both are available.
1915 (store_config_changed_event): Add comment.
1916 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1917 (store_tool_bar_style_changed): New functions.
1918 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1919 (struct xsettings): Move font inside HAVE_XFT.
1920 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1921 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1922 Move inside HAVE_XFT.
640c8776 1923 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1924 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1925 also.
1926 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1927 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1928 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1929 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1930 (parse_settings): Move check for font inside HAVE_XFT.
1931 (read_settings, apply_xft_settings): Add comment.
1932 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1933 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1934 call store_font_name_changed.
1935 (xft_settings_event): Add comment.
1936 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1937 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1938 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1939 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1940 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1941 (xsettings_get_system_font, xsettings_get_system_normal_font):
1942 Add comment.
869795d6 1943
d8ed26bd
PE
19442011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 Random fixes. E.g., (random) never returned negative values.
1947 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1948 subseconds part to the entropy, as that's a bit more random.
1949 Prefer signed to unsigned, since the signedness doesn't matter and
1950 in general we prefer signed. When given a limit, use a
1951 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1952 latter isn't right if USE_2_TAGS_FOR_INTS.
1953 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1954 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1955
cabf1cac
SM
19562011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1957
1958 * textprop.c (text_property_stickiness):
1959 Obey Vtext_property_default_nonsticky.
1960 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1961 * w32fns.c (syms_of_w32fns):
1962 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1963
6e9b2be9
PE
19642011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1967 This is more efficient than Ffile_directory_p and avoids a minor race.
1968
90186c68
LMI
19692011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1970
7c301272
LMI
1971 * buffer.c (Foverlay_put): Say what the return value is
1972 (bug#7835).
1973
c4f2d8d4
LMI
1974 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1975 is a directory before asking whether to use the file name
1976 (bug#7564).
ad637907
LMI
1977 (barf_or_query_if_file_exists): Make the "File is a directory"
1978 error be more correct.
c4f2d8d4 1979
90186c68
LMI
1980 * fns.c (Frequire): Remove the mention of the .gz files, since
1981 that's installation-specific, but keep the mention of
1982 `get-load-suffixes'.
1983
da64016e
PE
19842011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1987 Report string overflow if the output is too long.
1988
7d47b580
JB
19892011-07-04 Juanma Barranquero <lekktu@gmail.com>
1990
a555cb87
JB
1991 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1992 (syms_of_gnutls): Remove duplicate DEFSYM for
1993 Qgnutls_bootprop_verify_hostname_error, an error for
1994 Qgnutls_bootprop_verify_error (which is no longer used).
1995
7d47b580
JB
1996 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1997 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1998 Also (re)move comments that are misplaced or no longer relevant.
1999
1e49bfab
LMI
20002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2001
2002 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2003
1485f4c0
CY
20042011-07-03 Chong Yidong <cyd@stupidchicken.com>
2005
2006 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2007 and background color parameters if they have been changed.
2008
a9ab721e
LMI
20092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2010
2011 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2012
cf7cff57
PE
20132011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2014
2e13213d
PE
2015 * xsettings.c (SYSTEM_FONT): Define only when used.
2016 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2017
cf7cff57
PE
2018 * keymap.c (access_keymap_1): Now static.
2019
7a8e04f7
CY
20202011-07-02 Chong Yidong <cyd@stupidchicken.com>
2021
2022 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2023 leave any prefix arg for the up event (Bug#1586).
2024
61352f62
LMI
20252011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2026
69bb1ef7
LMI
2027 * lread.c (syms_of_lread): Mention single symbols defined by
2028 `defvar' or `defconst' (bug#7154).
2029
61352f62 2030 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2031 (Frequire): Mention get-load-suffixes.
61352f62 2032
28545e04
MR
20332011-07-02 Martin Rudalics <rudalics@gmx.at>
2034
2035 * window.h (window): Remove clone_number slot.
2036 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2037 Remove.
2038 (make_parent_window, make_window, saved_window)
2039 (Fset_window_configuration, save_window_save): Don't deal with
2040 clone numbers.
2041 * buffer.c (Qclone_number): Remove declaration.
2042 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2043
3349e122
SM
20442011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2045
2046 Add multiple inheritance to keymaps.
2047 * keymap.c (Fmake_composed_keymap): New function.
2048 (Fset_keymap_parent): Simplify.
2049 (fix_submap_inheritance): Remove.
2050 (access_keymap_1): New function extracted from access_keymap to handle
2051 embedded parents and handle lists of maps.
2052 (access_keymap): Use it.
2053 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2054 (Fcopy_keymap): Handle embedded parents.
2055 (Fcommand_remapping, define_as_prefix): Simplify.
2056 (Fkey_binding): Simplify.
2057 (syms_of_keymap): Move minibuffer-local-completion-map,
2058 minibuffer-local-filename-completion-map,
2059 minibuffer-local-must-match-map, and
2060 minibuffer-local-filename-must-match-map to Elisp.
2061 (syms_of_keymap): Defsubr make-composed-keymap.
2062 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2063 (parse_menu_item): Trivial simplification.
2064
3279eb87
GM
20652011-07-01 Glenn Morris <rgm@gnu.org>
2066
2067 * Makefile.in (SETTINGS_LIBS): Fix typo.
2068
4550efdf
KI
20692011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2070
2071 * coding.c (Fencode_coding_string): Record the last coding system
2072 used, as the function doc string says (bug#8738).
2073
0949d2b6
JD
20742011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2075
2076 * xsettings.c (store_monospaced_changed): Take new font as arg and
2077 check for change against current_mono_font.
2078 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2079 (emacs_settings_constructor, emacs_settings_get_property)
2080 (emacs_settings_set_property, emacs_settings_class_init)
2081 (emacs_settings_init, gsettings_obj): Remove.
2082 (something_changedCB): New function for HAVE_GSETTINGS.
2083 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2084 with value as argument.
2085 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2086 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2087 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2088 "changed".
2089
2090 * xgselect.c: Add defined (HAVE_GSETTINGS).
2091 (xgselect_initialize): Ditto.
2092
2093 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2094 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2095 xg_select.
2096
bbc6b304
PE
20972011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 * eval.c (struct backtrace): Simplify and port the data structure.
2100 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2101 signed bit field, as this assumption is not portable and it makes
2102 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2103 "char debug_on_exit : 1" as this is not portable either; instead,
2104 use the portable "unsigned int debug_on_exit : 1". Remove unused
2105 member evalargs. Remove obsolete comments about cc bombing out.
2106
9851bfc5
JD
21072011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2108
51bb811f 2109 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2110 Let HAVE_GSETTINGS override HAVE_GCONF.
2111 (store_monospaced_changed): New function.
2112 (EMACS_SETTINGS): A new type derived from GObject to handle
2113 GSettings notifications.
2114 (emacs_settings_constructor, emacs_settings_get_property)
2115 (emacs_settings_set_property, emacs_settings_class_init):
2116 New functions.
2117 (gsettings_client, gsettings_obj): New variables.
2118 (GSETTINGS_SCHEMA): New define.
2119 (something_changedCB): Call store_monospaced_changed.
2120 (init_gsettings): New function.
2121 (xsettings_initialize): Call init_gsettings.
2122 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2123 to NULL.
2124
640c8776 2125 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2126 GCONF_CFLAGS/LIBS.
2127
5386012d
MR
21282011-06-29 Martin Rudalics <rudalics@gmx.at>
2129
2130 * window.c (resize_root_window, grow_mini_window)
2131 (shrink_mini_window): Rename Qresize_root_window to
2132 Qwindow_resize_root_window and Qresize_root_window_vertically to
2133 Qwindow_resize_root_window_vertically.
2134
f13e0b08
PE
21352011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2138
94515237
JB
21392011-06-27 Juanma Barranquero <lekktu@gmail.com>
2140
2141 * makefile.w32-in: Redesign dependencies so they reflect more
2142 clearly which files are directly included by each source file,
2143 and not through other includes.
2144
e43b6e43
MR
21452011-06-27 Martin Rudalics <rudalics@gmx.at>
2146
2147 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2148 (sort_overlays, overlay_strings): When an overlay's clone number
2149 matches the window's clone number process the overlay even if
2150 the overlay's window property doesn't match the current window.
2151
d68443dc
MR
2152 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2153 (Fwindow_hchild): Rename to Fwindow_left_child.
2154 (Fwindow_next): Rename to Fwindow_next_sibling.
2155 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2156 (resize_window_check): Rename to window_resize_check.
2157 (resize_window_apply): Rename to window_resize_apply.
2158 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2159 (Fdelete_other_windows_internal, resize_frame_windows)
2160 (Fsplit_window_internal, Fdelete_window_internal)
2161 (grow_mini_window, shrink_mini_window)
2162 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2163
c7e73be5
JD
21642011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2165
2166 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2167 (emacs_fixed_set_min_size): Remove.
2168 (emacs_fixed_new): Take frame as argument.
2169
2170 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2171 (_EmacsFixedPrivate): Remove minwidth/height.
2172 Add struct frame *f.
2173 (emacs_fixed_init): Initialize priv->f.
2174 (get_parent_class, emacs_fixed_set_min_size): Remove.
2175 (emacs_fixed_new): Set priv->f to argument.
2176 (emacs_fixed_get_preferred_width)
2177 (emacs_fixed_get_preferred_height): Use min_width/height from
2178 frames size_hint to set minimum and natural (Bug#8919).
2179 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2180 and use min_width/height from frames size_hint to set
2181 min_width/height (Bug#8919).
2182
2183 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2184 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2185 Fix indentation.
c7e73be5 2186
cf99dcf8
EZ
21872011-06-26 Eli Zaretskii <eliz@gnu.org>
2188
2189 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2190 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2191 called at ZV.
2192
029529ac
CY
21932011-06-26 Chong Yidong <cyd@stupidchicken.com>
2194
2195 * process.c (wait_reading_process_output): Bypass select if
2196 waiting for a cell while ignoring keyboard input, and input is
2197 pending. Suggested by Jan Djärv (Bug#8869).
2198
7a7ef429
PE
21992011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 Use gnulib's dup2 module instead of rolling our own.
2202 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2203
11fdef7d 22042011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2205
2206 * dispnew.c (scrolling_window): Before scrolling, turn off a
2207 mouse-highlight in the window being scrolled.
2208
cd3520a4
JB
22092011-06-24 Juanma Barranquero <lekktu@gmail.com>
2210
2211 Move DEFSYM to lisp.h and use everywhere.
2212
2213 * character.h (DEFSYM): Move declaration...
2214 * lisp.h (DEFSYM): ...here.
2215
2216 * gnutls.c:
2217 * minibuf.c:
2218 * w32menu.c:
2219 * w32proc.c:
2220 * w32select.c: Don't include character.h.
2221
2222 * alloc.c (syms_of_alloc):
2223 * buffer.c (syms_of_buffer):
2224 * bytecode.c (syms_of_bytecode):
2225 * callint.c (syms_of_callint):
2226 * casefiddle.c (syms_of_casefiddle):
2227 * casetab.c (init_casetab_once):
2228 * category.c (init_category_once, syms_of_category):
2229 * ccl.c (syms_of_ccl):
2230 * cmds.c (syms_of_cmds):
2231 * composite.c (syms_of_composite):
2232 * dbusbind.c (syms_of_dbusbind):
2233 * dired.c (syms_of_dired):
2234 * dispnew.c (syms_of_display):
2235 * doc.c (syms_of_doc):
2236 * editfns.c (syms_of_editfns):
2237 * emacs.c (syms_of_emacs):
2238 * eval.c (syms_of_eval):
2239 * fileio.c (syms_of_fileio):
2240 * fns.c (syms_of_fns):
2241 * frame.c (syms_of_frame):
2242 * fringe.c (syms_of_fringe):
2243 * insdel.c (syms_of_insdel):
2244 * keymap.c (syms_of_keymap):
2245 * lread.c (init_obarray, syms_of_lread):
2246 * macros.c (syms_of_macros):
2247 * msdos.c (syms_of_msdos):
2248 * print.c (syms_of_print):
2249 * process.c (syms_of_process):
2250 * search.c (syms_of_search):
2251 * sound.c (syms_of_sound):
2252 * syntax.c (init_syntax_once, syms_of_syntax):
2253 * terminal.c (syms_of_terminal):
2254 * textprop.c (syms_of_textprop):
2255 * undo.c (syms_of_undo):
2256 * w32.c (globals_of_w32):
2257 * window.c (syms_of_window):
2258 * xdisp.c (syms_of_xdisp):
2259 * xfaces.c (syms_of_xfaces):
2260 * xfns.c (syms_of_xfns):
2261 * xmenu.c (syms_of_xmenu):
2262 * xsettings.c (syms_of_xsettings):
2263 * xterm.c (syms_of_xterm): Use DEFSYM.
2264
4228cf16
TZ
22652011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2266
cd3520a4 2267 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2268
7fcccf1e
PE
22692011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2270
7efb4e0e
PE
2271 Integer and buffer overflow fixes (Bug#8873).
2272
ff5844ad
PE
2273 * print.c (printchar, strout): Check for string overflow.
2274 (PRINTPREPARE, printchar, strout):
2275 Don't set size unless allocation succeeds.
2276
90532f02
PE
2277 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2278 for sizes. Check for string overflow more accurately.
2279 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2280
6d84508d
PE
2281 * macros.c: Integer and buffer overflow fixes.
2282 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2283 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2284 Use ptrdiff_t, not int, for sizes.
2285 Don't increment bufsize until after realloc succeeds.
2286 Check for size-calculation overflow.
2287 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2288
437b2cb4
PE
2289 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2290
8b9ac8b4
PE
2291 * lread.c: Integer overflow fixes.
2292 (read_integer): Radix is now EMACS_INT, not int,
2293 to improve quality of diagnostics for out-of-range radices.
2294 Calculate buffer size correctly for out-of-range radices.
2295 (read1): Check for integer overflow in radices, and in
2296 read-circle numbers.
82cb60d3
PE
2297 (read_escape): Avoid int overflow.
2298 (Fload, openp, read_buffer_size, read1)
2299 (substitute_object_recurse, read_vector, read_list, map_obarray):
2300 Use ptrdiff_t, not int, for sizes.
2301 (read1): Use EMACS_INT, not int, for sizes.
20270765 2302 Check for size overflow.
8b9ac8b4 2303
7fcccf1e
PE
2304 * image.c (cache_image): Check for size arithmetic overflow.
2305
bfbbd7e7
PE
2306 * lread.c: Integer overflow issues.
2307 (saved_doc_string_size, saved_doc_string_length)
2308 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2309 Now ptrdiff_t, not int.
2310 (read1): Don't assume doc string length fits in int. Check for
2311 out-of-range doc string lengths.
2312 (read_list): Don't assume file position fits in int.
39019e54 2313 (read_escape): Check for hex character overflow.
bfbbd7e7 2314
4e323265
LL
23152011-06-22 Leo Liu <sdl.web@gmail.com>
2316
2317 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2318 Move to minibuffer.el.
2319
85fece3e
PE
23202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2321
20b84ce9 2322 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2323 The following patches are for when GLYPH_DEBUG && !XASSERT.
2324 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2325 * dispnew.c (flush_stdout):
2326 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2327 Mark as externally visible.
2328 * dispnew.c (check_window_matrix_pointers): Now static.
2329 * dispnew.c (window_to_frame_vpos):
2330 * xfns.c (unwind_create_frame):
2331 * xterm.c (x_check_font): Remove unused local.
2332 * scroll.c (CHECK_BOUNDS):
2333 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2334 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2335 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2336 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2337 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2338 Now static.
2339 (debug_method_add): Use va_list and vsprintf rather than relying
2340 on undefined behavior with wrong number of arguments.
2341 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2342 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2343 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2344 since we're not interested in debugging glyphs with old libraries.
2345 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2346 GCC 4.6.0's static checking.
2347
0766b489
PE
23482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2349
31fd4b32
PE
2350 Integer overflow and signedness fixes (Bug#8873).
2351 A few related buffer overrun fixes, too.
2352
b79e8648
PE
2353 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2354
0766b489
PE
2355 * dispextern.h (struct face.stipple):
2356 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2357 (x_bitmap_mask, x_allocate_bitmap_record)
2358 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2359 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2360 (x_create_bitmap_from_xpm_data):
2361 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2362 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2363 (.bitmaps_last):
2364 * xfaces.c (load_pixmap):
2365 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2366 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2367 (.bitmaps_last, struct x_output.icon_bitmap):
2368 Use ptrdiff_t, not int, for bitmap indexes.
2369 (x_allocate_bitmap_record): Check for size overflow.
2370 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2371
b081724f
PE
2372 Use ptrdiff_t, not int, for overlay counts.
2373 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2374 * editfns.c (overlays_around, get_pos_property):
2375 * textprop.c (get_char_property_and_overlay):
2376 * xdisp.c (next_overlay_change, note_mouse_highlight):
2377 * xfaces.c (face_at_buffer_position):
21514da7
PE
2378 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2379 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2380 (Fnext_overlay_change, Fprevious_overlay_change)
2381 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2382 Use ptrdiff_t, not int, for sizes.
21514da7 2383 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2384
3de73e5e
PE
2385 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2386
2606c57b
PE
2387 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2388 (x_session_initialize): Do not assume string length fits in int.
2389
aaafe47a
PE
2390 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2391 This is unlikely, but can occur if DPI is outlandish.
2392
2674ddc8 2393 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2394 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2395
28154962
PE
2396 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2397 * xrdb.c (magic_file_p, search_magic_path):
2398 Omit last arg SUFFIX; it was always 0. All callers changed.
2399 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2400
7de51af5
PE
2401 * xfont.c (xfont_match): Avoid need for strlen.
2402
25ed6cc3
PE
2403 * xfns.c: Don't assume strlen fits in int.
2404 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2405
4eab31dd
PE
2406 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2407 not unsigned long, as we prefer signed integers. All callers changed.
2408 Detect integer overflow in repeat count.
2409 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2410 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2411
171e2a58
PE
2412 * termcap.c: Don't assume sizes fit in int and never overflow.
2413 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2414 (gobble_line): Check for size-calculation overflow.
2415
ad39faca 2416 * minibuf.c (Fread_buffer):
6e5bb2dc 2417 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2418 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2419 Don't assume string length fits in int.
2420
52c61c22 2421 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2422 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2423
b5b8c9e5
PE
2424 * font.c: Don't assume string length fits in int.
2425 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2426 Use ptrdiff_t, not int.
ccd6111c
PE
2427 (font_intern_prop): Don't assume string length fits in int.
2428 Don't assume integer property fits in fixnum.
2429 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2430
882f0d81 2431 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2432 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2433 Reformulate so as not to need the command string.
2434 Invoke gzip -cd rather than gunzip, as it's more portable.
2435 (lock_info_type, lock_file_1, lock_file):
2436 Don't assume pid_t and time_t fit in unsigned long.
2437 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2438 (current_lock_owner): Prefer signed type for sizes.
2439 Use memcpy, not strncpy, where memcpy is what is really wanted.
2440 Don't assume (via atoi) that time_t and pid_t fit in int.
2441 Check for time_t and/or pid_t out of range, e.g., via a network share.
2442 Don't alloca where an auto var works fine.
2443
93f4cf88
PE
2444 * fileio.c: Fix some integer overflow issues.
2445 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2446 Don't assume string length fits in int.
2447 (directory_file_name): Don't assume string length fits in long.
2448 (make_temp_name): Don't assume pid fits in int, or that its print
2449 length is less than 20.
2450
f3e92b69
PE
2451 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2452
1bfdaf10
PE
2453 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2454
35016e9a
PE
2455 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2456
3d1e65a1
PE
2457 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2458 We prefer signed integers, even for size calculations.
2459
0b963a93
PE
2460 * emacs.c: Don't assume string length fits in 'int'.
2461 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2462 (main): Don't invoke strlen when not needed.
2463
573f4b54
PE
2464 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2465 (XD_DEBUG_MESSAGE): Don't waste a byte.
2466
989f33ba
PE
2467 * callproc.c (getenv_internal_1, getenv_internal)
2468 (Fgetenv_internal):
965d34eb
PE
2469 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2470
e4d29b33
PE
2471 * lread.c (invalid_syntax): Omit length argument.
2472 All uses changed. This doesn't fix a bug, but it simplifies the
2473 code away from its former Hollerith-constant appearance, and it's
2474 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2475 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2476
eb49b136
PE
2477 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2478 This didn't break anything, but it didn't help either.
2479 It's confusing to put a bogus integer in a place where the actual
2480 value does not matter.
9f62aeb1 2481 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2482 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2483
15375a22
PE
2484 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2485 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2486 implementation.
b61cc01c
PE
2487 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2488 We prefer signed types, and the value cannot exceed the EMACS_INT
2489 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2490 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2491 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2492 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2493
53b2623d
PE
2494 * indent.c (sane_tab_width): New function.
2495 (current_column, scan_for_column, Findent_to, position_indentation)
2496 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2497 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2498
51cab52b 2499 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2500
f2ed8a70
PE
2501 * lisp.h (lint_assume): New macro.
2502 * composite.c (composition_gstring_put_cache):
2503 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2504
abe80cc6
PE
2505 * editfns.c, insdel.c:
2506 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2507
b02c740e
PE
2508 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2509
ebc96716
PE
2510 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2511
b4e50fa0 2512 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2513 Use much-faster test for byte-length change.
311d5d7c 2514 Don't assume string byte-length fits in 'int'.
a4cf38e4 2515 Check that character arg fits in 'int'.
85461888 2516 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2517
c0c1ee9f
PE
2518 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2519
a498d7f4
PE
2520 * fns.c (concat): Catch string overflow earlier.
2521 Do not rely on integer wraparound.
2522
51cab52b
PE
2523 * dispextern.h (struct it.overlay_strings_charpos)
2524 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2525 * xdisp.c (forward_to_next_line_start)
2526 (back_to_previous_visible_line_start)
2527 (reseat_at_next_visible_line_start, next_element_from_buffer):
2528 Don't arbitrarily truncate the value of 'selective' to int.
2529
76031fad
PE
2530 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2531
5eb55db9
PE
2532 * composite.c: Don't truncate sizes to 'int'.
2533 (composition_gstring_p, composition_reseat_it)
2534 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2535 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2536 not EMACS_UINT, for indexes.
5eb55db9 2537
0703a717
PE
2538 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2539
d6202519
PE
2540 * buffer.c: Include <verify.h>.
2541 (struct sortvec.priority, struct sortstr.priority):
8961a454 2542 Now EMACS_INT, not int.
c20998a7 2543 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2544 (struct sortstr.size, record_overlay_string)
2545 (struct sortstrlist.size, struct sortlist.used):
2546 Don't truncate size to int.
2547 (record_overlay_string): Check for size-calculation overflow.
d6202519 2548 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2549
d5a19415
JM
25502011-06-22 Jim Meyering <meyering@redhat.com>
2551
029529ac 2552 Don't leak an XBM-image-sized buffer
d5a19415
JM
2553 * image.c (xbm_load): Free the image buffer after using it.
2554
a9041e6c
PE
25552011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 Port to Sun C.
2558 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2559 that Sun C diagnosed.
2560 * fns.c (secure_hash): Fix pointer signedness issue.
2561 * intervals.c (static_offset_intervals): New function.
2562 (offset_intervals): Use it.
2563
7f3f739f
LL
25642011-06-21 Leo Liu <sdl.web@gmail.com>
2565
2566 * deps.mk (fns.o):
2567 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2568 sha512.h.
2569
2570 * fns.c (secure_hash): Rename from crypto_hash_function and change
2571 the first arg to accept symbols.
5b66d427 2572 (Fsecure_hash): New primitive.
7f3f739f
LL
2573 (syms_of_fns): New symbols.
2574
76147d94
DD
25752011-06-20 Deniz Dogan <deniz@dogan.se>
2576
2577 * process.c (Fset_process_buffer): Clarify return value in
2578 docstring.
2579
7d7d0045
CY
25802011-06-18 Chong Yidong <cyd@stupidchicken.com>
2581
2582 * dispnew.c (add_window_display_history): Use BVAR.
2583
2584 * xdisp.c (debug_method_add): Use BVAR.
2585 (check_window_end, dump_glyph_matrix, dump_glyph)
2586 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2587
2588 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2589 Likewise.
2590
2591 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2592 check till after the cache is created in init_frame_faces.
2593
ff2bc410
SM
25942011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2595
2596 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2597
28177add
PE
25982011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2599
dd3482fe
PE
2600 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2601 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2602 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2603
393d71f3 2604 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2605 * fileio.c (Finsert_file_contents):
2606 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2607 Remove the old (too-loose) buffer overflow checks.
2608 They weren't needed, since make_gap checks for buffer overflow.
2609 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2610 The old code merely checked for Emacs fixnum overflow, and relied
2611 on undefined (wraparound) behavior. The new code avoids undefined
2612 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2613
2e6813b0 2614 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2615 Tune. Don't use wider integers than needed. Don't use alloca.
2616 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2617
599a9e4f
PE
2618 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2619
99561444
PE
2620 * insdel.c, lisp.h (buffer_overflow): New function.
2621 (insert_from_buffer_1, replace_range, replace_range_2):
2622 * insdel.c (make_gap_larger):
2623 * editfns.c (Finsert_char):
2624 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2625
28177add
PE
2626 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2627
e69dafad
PE
26282011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2629
a7af7fde 2630 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2631
b1c46f02
PE
2632 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2633 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2634
e69dafad
PE
2635 * fileio.c: Don't assume EMACS_INT fits in off_t.
2636 (emacs_lseek): New static function.
2637 (Finsert_file_contents, Fwrite_region): Use it.
2638 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2639
566684ea
PE
2640 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2641
e6966cd6
PE
2642 * fns.c: Don't overflow int when computing a list length.
2643 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2644 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2645 truncation on 64-bit hosts. Check for QUIT every
2646 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2647 faster and is responsive enough.
2648 (Flength): Report an error instead of overflowing an integer.
2649 (Fsafe_length): Return a float if the value is not representable
2650 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2651 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2652 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2653
dd0b0efb
PE
2654 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2655 (header_size, word_size): New constants.
2656 (allocate_vectorlike): Don't check size overflow here.
2657 (allocate_vector): Check it here instead, since this is the only
2658 caller of allocate_vectorlike that could cause overflow.
2659 Check that the new vector's length is representable as a fixnum.
2660
86fe5cfe
PE
2661 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2662 The previous code was bogus. For example, next_almost_prime (32)
2663 returned 39, which is undesirable as it is a multiple of 3; and
2664 next_almost_prime (24) returned 25, which is a multiple of 5 so
2665 why was the code bothering to check for multiples of 7?
2666
80e88859
PE
2667 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2668
4a2f0ad6
PE
2669 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2670
f66c7cf8
PE
2671 Variadic C functions now count arguments with ptrdiff_t.
2672 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2673 Back then I didn't know that the Emacs coding style prefers signed int.
2674 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2675 were being counted with int, which may truncate counts on 64-bit
2676 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2677 * lisp.h (struct Lisp_Subr.function.aMANY)
2678 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2679 Arg counts are now ptrdiff_t, not size_t.
2680 All variadic functions and their callers changed accordingly.
2681 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2682 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2683 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2684 * callint.c (Fcall_interactively): Check arg count for overflow,
2685 to avoid potential buffer overrun. Use signed char, not 'int',
2686 for 'varies' array, so that we needn't bother to check its size
2687 calculation for overflow.
2688 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2689 * eval.c (apply_lambda):
2690 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2691 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2692 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2693
a1759b76
PE
2694 * callint.c (Fcall_interactively): Don't use index var as event count.
2695
d96be9fc
PE
2696 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2697 * mem-limits.h (SIZE): Remove; no longer used.
2698
a690a978 2699 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2700
578c21e6
PE
2701 Remove unnecessary casts.
2702 * xterm.c (x_term_init):
2703 * xfns.c (x_set_border_pixel):
2704 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2705 These aren't needed now that we assume ANSI C.
2706
96f53c6c
PE
2707 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2708 It's more likely to cause problems (due to unsigned overflow)
2709 than to cure them.
2710
83c77d31
PE
2711 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2712
ee2079f1
PE
2713 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2714
6da65536
PE
2715 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2716
7147c4a4
PE
2717 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2718
193e32d9
PE
2719 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2720
e5533da6
PE
2721 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2722
9910e595
PE
2723 GLYPH_CODE_FACE returns EMACS_INT, not int.
2724 * dispextern.h (merge_faces):
2725 * xfaces.c (merge_faces):
01103c44
PE
2726 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2727 Don't assume EMACS_INT fits in int.
9910e595 2728
2638320e
PE
2729 * character.h (CHAR_VALID_P): Remove unused parameter.
2730 * fontset.c, lisp.h, xdisp.c: All uses changed.
2731
045eb8d9
PE
2732 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2733
c1f134b5
PE
2734 * fns.c (concat): Minor tuning based on overflow analysis.
2735 This doesn't fix any bugs. Use int to hold character, instead
2736 of constantly refetching from Emacs object. Use XFASTINT, not
2737 XINT, for value known to be a character. Don't bother comparing
2738 a single byte to 0400, as it's always less.
2739
395fcb93 2740 * floatfns.c (Fexpt):
327eeec8
PE
2741 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2742
abbd3d23
PE
2743 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2744 for characters.
2745
684a03ef
PE
2746 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2747
0fed43f3
PE
2748 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2749 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2750 incorrectly succeed when S was a string, because 4294967386 was
2751 truncated before it was used.
2752
8fd02eb7
PE
2753 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2754 Otherwise, an out-of-range integer could cause undefined behavior
2755 on a 64-bit host.
2756
f8c86b69
PE
2757 * composite.c: Use int, not EMACS_INT, for characters.
2758 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2759 EMACS_INT, for values that are known to be in character range.
2760 This doesn't fix any bugs but is the usual style inside Emacs and
2761 may generate better code on 32-bit machines.
2762
34206dd2
PE
2763 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2764 This is for reasons similar to the recent CHAR_STRING fix.
2765 * charset.c (Fencode_char): Check that character arg is actually
2766 a character. Pass an int to ENCODE_CHAR.
2767 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2768 wider than 'int', as a compile-time check to prevent future regressions
2769 in this area.
2770
c5958d4c 2771 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2772
2773 Make sure a 64-bit char is never passed to CHAR_STRING.
2774 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2775 by silently ignoring the top 32 bits, allowing some values
2776 that were far too large to be valid characters.
2777 * character.h: Include <verify.h>.
2778 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2779 arguments are no wider than unsigned, as a compile-time check
2780 to prevent future regressions in this area.
2781 * data.c (Faset):
01103c44 2782 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2783 (Fsubst_char_in_region):
2784 * fns.c (concat):
2785 * xdisp.c (decode_mode_spec_coding):
2786 Adjust to CHAR_STRING's new requirement.
2787 * editfns.c (Finsert_char, Fsubst_char_in_region):
2788 * fns.c (concat): Check that character args are actually
2789 characters. Without this test, these functions did the wrong
2790 thing with wildly out-of-range values on 64-bit hosts.
2791
d37ca623
PE
2792 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2793 These casts should not be needed on 32-bit hosts, either.
2794 * keyboard.c (read_char):
2795 * lread.c (Fload): Remove casts to unsigned.
2796
ea204efb
PE
2797 * lisp.h (UNSIGNED_CMP): New macro.
2798 This fixes comparison bugs on 64-bit hosts.
2799 (ASCII_CHAR_P): Use it.
2800 * casefiddle.c (casify_object):
01103c44 2801 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2802 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2803 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2804 * dispextern.h (FACE_FROM_ID):
2805 * keyboard.c (read_char): Use UNSIGNED_CMP.
2806
41cb286c
PE
2807 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2808 not to EMACS_INT, to avoid GCC warning.
2809
4a1b9832
PE
2810 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2811
55daad71
PE
2812 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2813 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2814 isn't needed on 32-bit machines.
8f95c75c 2815
01103c44
PE
2816 * buffer.c (Fgenerate_new_buffer_name):
2817 Use EMACS_INT for count, not int.
0ceccced 2818 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2819
2820 * data.c (Qcompiled_function): Now static.
2821
c6f072e7
PE
2822 * window.c (window_body_lines): Now static.
2823
20ce5912
PE
2824 * image.c (gif_load): Rename local to avoid shadowing.
2825
9c4c5f81
PE
2826 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2827 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2828 * alloc.c (make_save_value): Integer argument is now of type
2829 ptrdiff_t, not int.
2830 (mark_object): Use ptrdiff_t, not int.
2831 * lisp.h (pD): New macro.
2832 * print.c (print_object): Use it.
2833
c0c5c8ae
PE
2834 * alloc.c: Use EMACS_INT, not int, to count objects.
2835 (total_conses, total_markers, total_symbols, total_vector_size)
2836 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2837 (total_free_floats, total_floats, total_free_intervals)
2838 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2839 Now EMACS_INT, not int. All uses changed.
2840 (Fgarbage_collect): Compute overall total using a double, so that
2841 integer overflow is less likely to be a problem. Check for overflow
2842 when converting back to an integer.
5a25e253
PE
2843 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2844 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2845 These were 'int' variables that could overflow on 64-bit hosts;
2846 they were never used, so remove them instead of repairing them.
211a0b2a 2847 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2848 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2849 Previously, this ceilinged at INT_MAX, but that doesn't work on
2850 64-bit machines.
e46bb31a 2851 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2852
c78baabf 2853 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2854 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2855 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2856 when a (possibly-narrower) signed value would do just as well.
2857 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2858
c9d624c6
PE
2859 * alloc.c: Catch some string size overflows that we were missing.
2860 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2861 for convenience in STRING_BYTES_MAX.
2862 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2863 The definition here is exact; the one in lisp.h was approximate.
2864 (allocate_string_data): Check for string overflow. This catches
2865 some instances we weren't catching before. Also, it catches
2866 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2867 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2868 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2869
c9d624c6
PE
2870 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2871 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2872 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2873
353032ce
PE
2874 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2875
2bccce07
PE
2876 * alloc.c (Fmake_string): Check for out-of-range init.
2877
0ac30604
SM
28782011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2879
2880 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2881
c195f2de
JD
28822011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2883
2884 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2885 xg_get_default_scrollbar_width.
2886
2887 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2888 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2889 (style_changed_cb): Call update_theme_scrollbar_width and call
2890 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2891 all frames (Bug#8505).
2892 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2893 Call gtk_window_set_resizable if HAVE_GTK3.
2894 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2895 and height if HAVE_GTK3 (Bug#8505).
2896 (scroll_bar_width_for_theme): New variable.
2897 (update_theme_scrollbar_width): New function.
2898 (xg_get_default_scrollbar_width): Move code to
2899 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2900 (xg_initialize): Call update_theme_scrollbar_width.
2901
2902 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2903
2904 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2905
e10ac9f1
MR
29062011-06-12 Martin Rudalics <rudalics@gmx.at>
2907
2908 * frame.c (make_frame): Call other_buffer_safely instead of
2909 other_buffer.
2910
2911 * window.c (temp_output_buffer_show): Call display_buffer with
2912 second argument Vtemp_buffer_show_specifiers and reset latter
2913 immediately after the call.
2914 (Vtemp_buffer_show_specifiers): New variable.
2915 (auto_window_vscroll_p, next_screen_context_lines)
2916 (Vscroll_preserve_screen_position): Remove leading asterisks from
2917 doc-strings.
2918
2d3c217e 29192011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2920
7b7f97e8 2921 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2922 * buffer.c (Qclone_number): Remove for now, as it's unused.
2923 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2924 (record_buffer): Remove unused local.
2925 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2926 (set_frame_buffer_list): Remove; unused.
2927 * frame.h (other_visible_frames): Remove decl.
2928 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2929 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2930 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2931 if HAVE_GPM.
2932 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2933 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2934 Define only if HAVE_GPM.
2935 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2936 (update_hints_inhibit): Remove; never set. All uses removed.
2937 * widgetprv.h (emacsFrameClassRec): Remove decl.
2938 * window.c (delete_deletable_window): Now returns void, since it
2939 wasn't returning anything.
2940 (compare_window_configurations): Remove unused locals.
2941 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2942 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2943 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2944 the same widths as pointers. This follows up on the 2011-05-06 patch.
2945 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2946 * xterm.h: Likewise.
2947 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2948
1384b89e
JB
29492011-06-12 Juanma Barranquero <lekktu@gmail.com>
2950
2951 * makefile.w32-in: Update dependencies.
2952 (LISP_H): Add lib/intprops.h.
2953
1100a63c
CY
29542011-06-11 Chong Yidong <cyd@stupidchicken.com>
2955
2956 * image.c (gif_load): Add animation frame delay to the metadata.
2957 (syms_of_image): Use DEFSYM. New symbol `delay'.
2958
6198ccd0
MR
29592011-06-11 Martin Rudalics <rudalics@gmx.at>
2960
2961 * window.c (delete_deletable_window): Re-add.
2962 (Fset_window_configuration): Rewrite to handle dead buffers and
2963 consequently deletable windows.
2964 (window_tree, Fwindow_tree): Remove. Supply functionality in
2965 window.el.
2966 (compare_window_configurations): Simplify code.
2967
b6e3633c
AS
29682011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2969
1ab0dee5
AS
2970 * image.c (imagemagick_load_image): Fix type mismatch.
2971 (Fimagemagick_types): Likewise.
2972
b6e3633c
AS
2973 * window.h (replace_buffer_in_windows): Declare.
2974
9397e56f
MR
29752011-06-11 Martin Rudalics <rudalics@gmx.at>
2976
2977 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2978 Qclone_number. Remove external declaration of Qdelete_window.
2979 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2980 code.
640c8776
SM
2981 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2982 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2983 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2984 buffer list implementation.
2985 (other_buffer_safely): New function.
2986 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2987 calls to replace_buffer_in_windows and
2988 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2989 if allowed.
2990 (record_buffer): Inhibit quitting and rewrite using quittable
2991 functions. Run Qbuffer_list_update_hook if allowed.
2992 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2993 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2994 Move switch-to-buffer to window.el.
9397e56f
MR
2995 (bury-buffer): Move to window.el.
2996 (Vbuffer_list_update_hook): New variable.
2997
2998 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2999 section.
3000
3001 * window.h (resize_frame_windows): Move up in code.
3002 (Fwindow_frame): Remove EXFUN.
3003 (replace_buffer_in_all_windows): Remove prototype.
3004 (replace_buffer_in_windows_safely): Add prototype.
3005
3006 * window.c: Declare Qdelete_window static again. Move down
3007 declaration of select_count.
3008 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3009 (Fother_window): Move to window.el.
3010 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3011 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3012 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3013 window.el.
3014 (replace_buffer_in_windows): Implement by calling
3015 Qreplace_buffer_in_windows.
3016 (replace_buffer_in_all_windows): Remove with some functionality
3017 moved into replace_buffer_in_windows_safely.
3018 (replace_buffer_in_windows_safely): New function.
3019 (select_window_norecord, select_frame_norecord): Move in front
3020 of run_window_configuration_change_hook. Remove now obsolete
3021 declarations.
640c8776
SM
3022 (Fset_window_buffer): Rewrite doc-string.
3023 Call Qrecord_window_buffer.
9397e56f
MR
3024 (keys_of_window): Move binding for other-window to window.el.
3025
b50691aa
CY
30262011-06-11 Chong Yidong <cyd@stupidchicken.com>
3027
3028 * dispextern.h (struct image): Replace data member, whose int_val
3029 and ptr_val fields were not used by anything, with a single
3030 lisp_val object.
3031
3032 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3033 (gif_clear_image, gif_load, imagemagick_load_image)
3034 (gs_clear_image, gs_load): Callers changed.
3035
3f754b86
PE
30362011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3037
cca69397
PE
3038 * buffer.h: Include <time.h>, for time_t.
3039 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3040
109e28d0
PE
3041 Fix minor problems found by static checking.
3042
60737f02
PE
3043 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3044
4b66faf3
PE
3045 Make identifiers static if they are not used in other modules.
3046 * data.c (Qcompiled_function, Qframe, Qvector):
3047 * image.c (QimageMagick, Qsvg):
3048 * minibuf.c (Qmetadata):
3049 * window.c (resize_window_check, resize_root_window): Now static.
3050 * window.h (resize_window_check, resize_root_window): Remove decls.
3051
109e28d0
PE
3052 * window.c (window_deletion_count, delete_deletable_window):
3053 Remove; unused.
46a4ce9e
PE
3054 (window_body_lines): Now static.
3055 (Fdelete_other_windows_internal): Mark vars as initialized.
3056 Make sure 'resize_failed' is initialized.
3057 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3058 (resize_window_apply): Remove unused local.
3059 * window.h (delete_deletable_window): Remove decl.
3060
109e28d0 3061 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3062 (imagemagick_load_image): Fix pointer signedness problem by changing
3063 last arg from unsigned char * to char *. All uses changed.
3064 Also, fix a local for similar reasons.
3065 Remove unused locals. Remove locals to avoid shadowing.
3066 (fn_rsvg_handle_free): Remove; unused.
3067 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3068 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3069
3f754b86
PE
3070 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3071
2547adb1
CY
30722011-06-10 Chong Yidong <cyd@stupidchicken.com>
3073
3074 * image.c (gif_load): Fix omitted cast error introduced by
3075 2011-06-06 change.
3076
2c8e37d4
MR
30772011-06-10 Martin Rudalics <rudalics@gmx.at>
3078
3079 * window.h (resize_proportionally, orig_total_lines)
3080 (orig_top_line): Remove from window structure.
3081 (set_window_height, set_window_width, change_window_heights)
3082 (Fdelete_window): Remove prototypes.
3083 (resize_frame_windows): Remove duplicate declaration.
3084
440a42e3
EZ
30852011-06-10 Eli Zaretskii <eliz@gnu.org>
3086
3087 * window.h (resize_frame_windows, resize_window_check)
3088 (delete_deletable_window, resize_root_window)
3089 (resize_frame_windows): Declare prototypes.
3090
3091 * window.c (resize_window_apply): Make definition be "static" to
3092 match the prototype.
3093
562dd5e9
MR
30942011-06-10 Martin Rudalics <rudalics@gmx.at>
3095
3096 * window.c: Remove declarations of Qwindow_size_fixed,
3097 window_min_size_1, window_min_size_2, window_min_size,
3098 size_window, window_fixed_size_p, enlarge_window, delete_window.
3099 Remove static from declaration of Qdelete_window, it's
3100 temporarily needed by Fbury_buffer.
3101 (replace_window): Don't assign orig_top_line and
3102 orig_total_lines.
3103 (Fdelete_window, delete_window): Remove. Window deletion is
3104 handled by window.el.
640c8776
SM
3105 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3106 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3107 (Fdelete_other_windows): Remove. Deleting other windows is
3108 handled by window.el.
3109 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3110 handled in window.el.
3111 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3112 Window minimum sizes are handled in window.el.
3113 (shrink_windows, size_window, set_window_height)
3114 (set_window_width, change_window_heights, window_height)
3115 (window_width, CURBEG, CURSIZE, enlarge_window)
3116 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3117 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3118 handled in window.el.
3119 (make_dummy_parent): Rename to make_parent_window and give it a
3120 second argument horflag.
3121 (make_window): Don't set resize_proportionally any more.
3122 (Fsplit_window): Remove. Windows are split in window.el.
3123 (save_restore_action, save_restore_orig_size)
3124 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3125 Resize mini windows in window.el.
3126 (grow_mini_window, shrink_mini_window): Implement by calling
3127 Qresize_root_window_vertically, resize_window_check and
3128 resize_window_apply.
640c8776
SM
3129 (saved_window, Fset_window_configuration, save_window_save):
3130 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3131 resize_proportionally.
3132 (window_min_height, window_min_width): Move to window.el.
3133 (keys_of_window): Move bindings for delete-other-windows,
3134 split-window, delete-window and enlarge-window to window.el.
3135
3136 * buffer.c: Temporarily extern Qdelete_window.
3137 (Fbury_buffer): Temporarily call Qdelete_window instead of
3138 Fdelete_window (Fbury_buffer will move to window.el soon).
3139
3140 * frame.c (set_menu_bar_lines_1): Remove code handling
3141 orig_top_line and orig_total_lines.
3142
3143 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3144 set_window_height but set heights directly.
3145 (change_frame_size_1): Use resize_frame_windows.
3146
3147 * xdisp.c (init_xdisp): Don't use set_window_height but set
3148 heights directly.
3149
640c8776
SM
3150 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3151 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3152 run_window_configuration_change_hook.
3153
3154 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3155 instead of change_window_heights and run
3156 run_window_configuration_change_hook.
3157
1a13852e
MR
31582011-06-09 Martin Rudalics <rudalics@gmx.at>
3159
3160 * window.c (replace_window): Rename second argument REPLACEMENT to
3161 NEW. New third argument SETFLAG. Rewrite.
3162 (delete_window, make_dummy_parent): Call replace_window with
3163 third argument 1.
3164 (window_list_1): Move down in code.
3165 (run_window_configuration_change_hook): Move set_buffer part
3166 before select_frame_norecord part in order to unwind correctly.
3167 Rename count1 to count.
3168 (recombine_windows, delete_deletable_window, resize_root_window)
3169 (Fdelete_other_windows_internal)
3170 (Frun_window_configuration_change_hook, make_parent_window)
3171 (resize_window_check, resize_window_apply, Fresize_window_apply)
3172 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3173 (Fdelete_window_internal, Fresize_mini_window_internal):
3174 New functions.
1a13852e
MR
3175 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3176
f3d1777e
MR
31772011-06-08 Martin Rudalics <rudalics@gmx.at>
3178
496e208e
MR
3179 * window.h (window): Add some new members to window structure -
3180 normal_lines, normal_cols, new_total, new_normal, clone_number,
3181 splits, nest, prev_buffers, next_buffers.
3182 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3183 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3184
f3d1777e
MR
3185 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3186 Remove.
496e208e
MR
3187 (make_dummy_parent): Set new members of windows structure.
3188 (make_window): Move down in code. Handle new members of window
3189 structure.
3190 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3191 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3192 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3193 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3194 (Fset_window_next_buffers, Fset_window_clone_number):
3195 New functions.
496e208e
MR
3196 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3197 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3198 Doc-string fixes.
3199 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3200 Argument WINDOW can be now internal window too.
3201 (Fwindow_use_time): Move up in code.
3202 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3203 Rewrite doc-string.
3204 (Fset_window_configuration, saved_window)
3205 (Fcurrent_window_configuration, save_window_save): Handle new
3206 members of window structure.
b9e809c2
MR
3207 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3208 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3209 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3210 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3211 Qget_mru_window, Qresize_root_window,
3212 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3213 Qauto_buffer_name; staticpro them.
f3d1777e 3214
abde8f8c
MR
32152011-06-07 Martin Rudalics <rudalics@gmx.at>
3216
3217 * window.c (Fwindow_total_size, Fwindow_left_column)
3218 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3219 (Fwindow_list_1): New functions.
3220 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3221 (Fwindow_width, Fscroll_left, Fscroll_right):
3222 Use window_body_cols instead of window_box_text_cols.
3223 (delete_window, Fset_window_configuration):
3224 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3225 (delete_all_subwindows): Take a window as argument and not a
3226 structure. Rewrite.
190b47e6
MR
3227 (window_loop): Remove handling of GET_LRU_WINDOW and
3228 GET_LARGEST_WINDOW.
3229 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3230
3231 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3232 window_box_text_cols. delete_all_subwindows now takes a
3233 Lisp_Object as argument.
abde8f8c 3234
640c8776
SM
3235 * indent.c (compute_motion, Fcompute_motion):
3236 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3237
fa8a67e6
MR
3238 * frame.c (delete_frame): Call delete_all_subwindows with root
3239 window as argument.
3240
a54e3482
DC
32412011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3242
3243 * fns.c (Fputhash): Document return value.
3244
60002bf5
CY
32452011-06-06 Chong Yidong <cyd@stupidchicken.com>
3246
3247 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3248
0c671da6 32492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3250
b862a52a 3251 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3252
be44ca6c
PE
3253 Check for overflow when converting integer to cons and back.
3254 * charset.c (Fdefine_charset_internal, Fdecode_char):
3255 Use cons_to_unsigned to catch overflow.
3256 (Fencode_char): Use INTEGER_TO_CONS.
3257 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3258 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3259 * data.c (long_to_cons, cons_to_long): Remove.
3260 (cons_to_unsigned, cons_to_signed): New functions.
3261 These signal an error for invalid or out-of-range values.
3262 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3263 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3264 * font.c (Ffont_variation_glyphs):
3265 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3266 * lisp.h: Include <intprops.h>.
3267 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3268 (cons_to_signed, cons_to_unsigned): New decls.
3269 (long_to_cons, cons_to_long): Remove decls.
3270 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3271 (Fprimitive_undo): Use CONS_TO_INTEGER.
3272 * xfns.c (Fx_window_property): Likewise.
3273 * xselect.c: Include <limits.h>.
3274 (x_own_selection, selection_data_to_lisp_data):
3275 Use INTEGER_TO_CONS.
3276 (x_handle_selection_request, x_handle_selection_clear)
3277 (x_get_foreign_selection, Fx_disown_selection_internal)
3278 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3279 (lisp_data_to_selection_data): Use cons_to_unsigned.
3280 (x_fill_property_data): Use cons_to_signed.
3281 Report values out of range.
3282
d1f3d2af
PE
3283 Check for buffer and string overflow more precisely.
3284 * buffer.h (BUF_BYTES_MAX): New macro.
3285 * lisp.h (STRING_BYTES_MAX): New macro.
3286 * alloc.c (Fmake_string):
3287 * character.c (string_escape_byte8):
3288 * coding.c (coding_alloc_by_realloc):
3289 * doprnt.c (doprnt):
3290 * editfns.c (Fformat):
3291 * eval.c (verror):
3292 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3293 since they may not be the same number.
3294 * editfns.c (Finsert_char):
3295 * fileio.c (Finsert_file_contents):
3296 Likewise for BUF_BYTES_MAX.
3297
dd52fcea
PE
3298 * image.c: Use ptrdiff_t, not int, for sizes.
3299 (slurp_file): Switch from int to ptrdiff_t.
3300 All uses changed.
3301 (slurp_file): Check that file size fits in both size_t (for
3302 malloc) and ptrdiff_t (for sanity and safety).
3303
7f9bbdbb
PE
3304 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3305 if b->modtime has its maximal value.
3306
dfe18f82
PE
3307 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3308
84acfcf0
PE
3309 Don't assume time_t can fit into int.
3310 * buffer.h (struct buffer.modtime): Now time_t, not int.
3311 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3312 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3313
ccd9a01a
PE
3314 Minor fixes for signed vs unsigned integers.
3315 * character.h (MAYBE_UNIFY_CHAR):
3316 * charset.c (maybe_unify_char):
3317 * keyboard.c (read_char, reorder_modifiers):
3318 XINT -> XFASTINT, since the integer must be nonnegative.
3319 * ftfont.c (ftfont_spec_pattern):
3320 * keymap.c (access_keymap, silly_event_symbol_error):
3321 XUINT -> XFASTINT, since the integer must be nonnegative.
3322 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3323 since it makes no difference and we prefer signed.
3324 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3325 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3326 nonnegative.
3327
d6d100dd
SM
33282011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3329
3330 * window.h (Fwindow_frame): Declare.
3331
2b6148e4
PE
33322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3333
3334 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3335 (SPARE_MEMORY): Always define.
3336 (LARGE_REQUEST): Remove.
3337 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3338
f230ecc9
MR
33392011-06-06 Martin Rudalics <rudalics@gmx.at>
3340
727e958e
MR
3341 * lisp.h: Move EXFUNS for Fframe_root_window,
3342 Fframe_first_window and Fset_frame_selected_window to window.h.
3343
3344 * window.h: Move EXFUNS for Fframe_root_window,
3345 Fframe_first_window and Fset_frame_selected_window here from
3346 lisp.h.
3347
3348 * frame.c (Fwindow_frame, Fframe_first_window)
3349 (Fframe_root_window, Fframe_selected_window)
3350 (Fset_frame_selected_window): Move to window.c.
3351 (Factive_minibuffer_window): Move to minibuf.c.
3352 (Fother_visible_frames_p): New function.
3353
3354 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3355
f230ecc9
MR
3356 * window.c (decode_window, decode_any_window): Move up in code.
3357 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3358 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3359 (Fwindow_buffer): Move up and rewrite doc-string.
3360 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3361 (Fwindow_prev): New functions.
727e958e
MR
3362 (Fwindow_frame): Move here from frame.c. Accept any window as
3363 argument.
3364 (Fframe_root_window, Fframe_first_window)
3365 (Fframe_selected_window): Move here from frame.c. Accept frame
3366 or arbitrary window as argument. Update doc-strings.
3367 (Fminibuffer_window): Move up in code.
3368 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3369 (Fset_frame_selected_window): Move here from frame.c.
3370 Marginal rewrite.
727e958e
MR
3371 (Fselected_window, select_window, Fselect_window): Move up in
3372 code. Minor doc-string fixes.
f230ecc9 3373
4d09bcf6
PE
33742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3375
3376 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3377 Do not assume that spare memory exists; that assumption is valid
3378 only if SYSTEM_MALLOC.
3379 (LARGE_REQUEST): New macro, so that the issue of large requests
3380 is separated from the issue of spare memory.
3381
810928a2
AS
33822011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3383
172418ad
AS
3384 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3385 format. (Bug#8806)
3386
43f862f7
AS
3387 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3388
810928a2
AS
3389 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3390 before statements.
3391
a059fe24
JD
33922011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3393
3394 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3395
3396 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3397
3398 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3399 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3400
989bf368
JB
34012011-06-05 Juanma Barranquero <lekktu@gmail.com>
3402
3403 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3404
4b80f674
CY
34052011-06-04 Chong Yidong <cyd@stupidchicken.com>
3406
3407 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3408 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3409 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3410 New error handlers.
4b80f674
CY
3411 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3412 Obey Vx_select_enable_clipboard_manager. Catch errors in
3413 x_clipboard_manager_save (Bug#8779).
3414 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3415 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3416
99a33b77 34172011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3418
3419 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3420
99a33b77 34212011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3422
3423 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3424 in the current matrix if keep_current_p is non-zero.
3425
8264569d
EZ
34262011-06-04 Eli Zaretskii <eliz@gnu.org>
3427
3428 * bidi.c (bidi_level_of_next_char): Fix last change.
3429
57f97249
EZ
34302011-06-03 Eli Zaretskii <eliz@gnu.org>
3431
fec2107c 3432 Support bidi reordering of text covered by display properties.
57f97249 3433
fec2107c
EZ
3434 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3435 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3436 (bidi_cache_search, bidi_cache_iterator_state)
3437 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3438 (bidi_level_of_next_char, bidi_move_to_visually_next):
3439 Support character positions inside a run of characters covered by a
fec2107c
EZ
3440 display string.
3441 (bidi_paragraph_init, bidi_resolve_explicit_1)
3442 (bidi_level_of_next_char): Call bidi_fetch_char and
3443 bidi_fetch_char_advance instead of FETCH_CHAR and
3444 FETCH_CHAR_ADVANCE.
3445 (bidi_init_it): Initialize new members.
3446 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3447 definitions.
3448 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3449 instead of using explicit *_CHAR codes.
d6d100dd
SM
3450 (bidi_resolve_explicit, bidi_resolve_weak):
3451 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3452 bidirectional text is supported only in multibyte buffers.
3453 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3454 it to initialize the frame_window_p member of struct bidi_it.
3455 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3456 (bidi_resolve_explicit, bidi_resolve_weak)
3457 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3458 bidi_it->nchars is non-positive.
3459 (bidi_level_of_next_char): Don't try to lookup the cache for the
3460 next/previous character if nothing is cached there yet, or if we
3461 were just reseat()'ed to a new position.
c40e2fb2 3462
0e14fe90
EZ
3463 * xdisp.c (set_cursor_from_row): Set start and stop points
3464 according to the row's direction when priming the loop that looks
3465 for the glyph on which to display cursor.
3466 (single_display_spec_intangible_p): Function deleted.
3467 (display_prop_intangible_p): Reimplement to call
3468 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3469 Accept 3 additional arguments needed by handle_display_spec.
3470 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3471 values: lists, `(when COND...)' forms, etc.
3472 (single_display_spec_string_p): Support property values that are
3473 lists with the argument STRING its top-level element.
3474 (display_prop_string_p): Fix the condition for processing a
3475 property that is a list to be consistent with handle_display_spec.
fec2107c 3476 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3477 last portion of handle_display_prop.
3478 (compute_display_string_pos): Accept additional argument
3479 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3480 value of a `display' property is a "replacing spec".
3481 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3482 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3483 the display property, but just return a value indicating whether
3484 the display property will replace the characters it covers.
3485 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3486 frame_window_p members of struct bidi_it.
d6d100dd
SM
3487 (compute_display_string_pos, compute_display_string_end):
3488 New functions.
fec2107c
EZ
3489 (push_it): Accept second argument POSITION, where pop_it should
3490 jump to continue iteration.
3491 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3492
fec2107c
EZ
3493 * keyboard.c (adjust_point_for_property): Adjust the call to
3494 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3495
3496 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3497 (bidi_init_it): Update prototypes.
3498 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3499 (compute_display_string_pos, compute_display_string_end):
3500 Declare prototypes.
fec2107c
EZ
3501 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3502 EMACS_INT.
fc6f18ce 3503
40087514 35042011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3505
57f53182
PE
3506 Malloc failure behavior now depends on size of allocation.
3507 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3508 * lisp.h: Change signatures accordingly.
3509 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3510 All callers changed. (Bug#8762)
3511
3512 * gnutls.c: Use Emacs's memory allocators.
3513 Without this change, the gnutls library would invoke malloc etc.
3514 directly, which causes problems on non-SYNC_INPUT hosts, and which
3515 runs afoul of improving memory_full behavior. (Bug#8761)
3516 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3517 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3518 xfree instead of the default malloc, realloc, free.
3519 (Fgnutls_boot): No need to check for memory allocation failure,
3520 since xmalloc does that for us.
3521
ac32cd99 3522 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3523 * category.c (hash_get_category_set):
3524 * ccl.c (ccl_driver):
3525 * charset.c (Fdefine_charset_internal):
3526 * charset.h (struct charset.hash_index):
3527 * composite.c (get_composition_id, gstring_lookup_cache)
3528 (composition_gstring_put_cache):
3529 * composite.h (struct composition.hash_index):
3530 * dispextern.h (struct image.hash):
3531 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3532 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3533 (hashfn_equal, hashfn_user_defined, make_hash_table)
3534 (maybe_resize_hash_table, hash_lookup, hash_put)
3535 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3536 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3537 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3538 * image.c (make_image, search_image_cache, lookup_image)
3539 (xpm_put_color_table_h):
3540 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3541 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3542 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3543 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3544 * alloc.c (allocate_vectorlike):
3545 Check for overflow in vector size calculations.
3546 * ccl.c (ccl_driver):
3547 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3548 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3549 need to be updated by these changes.
40087514
PE
3550 * fns.c (make_hash_table, maybe_resize_hash_table):
3551 Check for integer overflow with large hash tables.
0de4bb68
PE
3552 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3553 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3554 (SXHASH_REDUCE): New macro.
3555 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3556 Use it instead of discarding useful hash info with large hash values.
3557 (sxhash_float): New function.
3558 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3559 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3560 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3561 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3562 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3563 Adjust signatures to match updated version of code.
3564 (consing_since_gc): Now EMACS_INT, since a single hash table can
3565 use more than INT_MAX bytes.
3566
698d32e2
DN
35672011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3568
3569 Make it possible to build with GCC-4.6+ -O2 -flto.
3570
3571 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3572
fd6fa53f
SM
35732011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3574
3575 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3576 Call minibuffer-inactive-mode.
3577
864db017
JB
35782011-05-31 Juanma Barranquero <lekktu@gmail.com>
3579
3580 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3581 Update dependencies.
3582
2ad0baf4
DN
35832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3584
3585 * data.c (init_data): Remove code for UTS, this system is not
3586 supported anymore.
3587
4fcc2638
DN
35882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3589
3590 Don't force ./temacs to start in terminal mode.
3591
3592 * frame.c (make_initial_frame): Initialize faces in all cases, not
3593 only when CANNOT_DUMP is defined.
3594 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3595
c56e0fd5
DN
35962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3597
3598 * dispnew.c (add_window_display_history): Use const for the string
3599 pointer. Remove declaration, not needed.
3600
333d54da 36012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3602
55d4c1b2 3603 Use 'inline', not 'INLINE'.
333d54da 3604 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3605 * alloc.c, fontset.c (INLINE): Remove.
3606 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3607 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3608 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3609 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3610 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3611
738db178
DN
36122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3613
3614 Make it possible to run ./temacs.
3615
3616 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3617 syms_of_callproc does the same thing. Remove test for
3618 "initialized", do it in the caller.
3619 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3620
620c53a6
SM
36212011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3622
3623 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3624 (read_minibuf): Use get_minibuffer.
3625 (syms_of_minibuf): Use DEFSYM.
3626 (Qmetadata): New var.
3627 * data.c (Qbuffer): Don't make it static.
3628 (syms_of_data): Use DEFSYM.
3629
e003a292
PE
36302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3633 (CCL_CODE_MIN): New macro.
3634
ed008a6d
PE
36352011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3636
3687c2ef
PE
3637 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3638
ed008a6d
PE
3639 * eval.c (Qdebug): Now static.
3640 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3641 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3642 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3643
d66c4c7c
CY
36442011-05-29 Chong Yidong <cyd@stupidchicken.com>
3645
3646 * image.c: Various fixes to ImageMagick code comments.
3647 (Fimagemagick_types): Doc fix.
3648
5fbc2025
PE
36492011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3650
0196f88a
PE
3651 Minor fixes prompted by GCC 4.6.0 warnings.
3652
3653 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3654
5fbc2025
PE
3655 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3656 (x_clipboard_manager_save_all): Move extern decl to ...
3657 * xterm.h: ... here, so that it can be checked for consistency.
3658
1dd3c2d9
CY
36592011-05-29 Chong Yidong <cyd@stupidchicken.com>
3660
3661 * xselect.c (x_clipboard_manager_save_frame)
3662 (x_clipboard_manager_save_all): New functions.
3663 (Fx_clipboard_manager_save): Lisp function deleted.
3664
3665 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3666 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3667
3668 * xterm.h: Update prototype.
3669
5ba6571d
WX
36702011-05-28 William Xu <william.xwl@gmail.com>
3671
3672 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3673 exiting (Bug#8239).
3674
3eaff834
JM
36752011-05-28 Jim Meyering <meyering@redhat.com>
3676
e1900994 3677 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3678 * fns.c (to_uchar): Define.
3679 (crypto_hash_function): Use it to convert some newly-signed
3680 variables to unsigned, to avoid sign-extension bugs. For example,
3681 without this change, (md5 "truc") would evaluate to
3682 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3683 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3684 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3685
0f6990a7
PE
36862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3687
3688 Integer overflow fixes.
c8a9ca5a 3689
08686060
PE
3690 * dbusbind.c: Serial number integer overflow fixes.
3691 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3692 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3693 to hold a serial number that is too large for a fixnum.
3694 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3695 Check for serial numbers out of range. Decode any serial number
59568bf0 3696 that was so large that it became a float. (Bug#8722)
08686060 3697
2d1fc3c7
PE
3698 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3699 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3700 Use XFASTINT rather than XUINT when numbers are nonnegative.
3701 (xd_append_arg, Fdbus_method_return_internal):
3702 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3703 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3704 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3705 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3706 (Bug#8722)
2d1fc3c7 3707
c8a9ca5a
PE
3708 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3709
519e1d69
PE
3710 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3711
30569699
PE
3712 ccl: add integer overflow checks
3713 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3714 (IN_INT_RANGE): New macros.
3715 (ccl_driver): Use them to check for integer overflow when
3716 decoding a CCL program. Many of the new checks are whether XINT (x)
3717 fits in int; it doesn't always, on 64-bit hosts. The new version
3718 doesn't catch all possible integer overflows, but it's an
847044ea 3719 improvement. (Bug#8719)
30569699 3720
c11285dc
PE
3721 * alloc.c (make_event_array): Use XINT, not XUINT.
3722 There's no need for unsigned here.
3723
fdccd48e
PE
3724 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3725 This follows up to the 2011-05-06 change that substituted uintptr_t
3726 for EMACS_INT. This case wasn't caught back then.
3727
37910ab2
PE
3728 Rework Fformat to avoid integer overflow issues.
3729 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3730 now (part of C89). Include <verify.h>.
3731 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3732 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3733 (Fformat): Avoid the prepass trying to compute sizes; it was only
3734 approximate and thus did not catch overflow reliably. Instead, walk
3735 through the format just once, formatting and computing sizes as we go,
3736 checking for integer overflow at every step, and allocating a larger
3737 buffer as needed. Keep track separately whether the format is
3738 multibyte. Keep only the most-recently calculated precision, rather
3739 than them all. Record whether each argument has been converted to
3740 string. Use EMACS_INT, not int, for byte and char and arg counts.
3741 Support field widths and precisions larger than INT_MAX. Avoid
3742 sprintf's undefined behavior with conversion specifications such as %#d
3743 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3744 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3745 formatting out-of-range floating point numbers with int
9173deec 3746 formats. (Bug#8668)
37910ab2 3747
2e6578fb
PE
3748 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3749
0ae6bdee
PE
3750 * data.c: Avoid integer truncation in expressions involving floats.
3751 * data.c: Include <intprops.h>.
3752 (arith_driver): When there's an integer overflow in an expression
3753 involving floating point, convert the integers to floating point
3754 so that the resulting value does not suffer from catastrophic
3755 integer truncation. For example, on a 64-bit host (* 4
3756 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3757 Do not rely on undefined behavior after integer overflow.
3758
de883a70
PE
3759 merge count_size_as_multibyte, parse_str_to_multibyte
3760 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3761 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3762 Check for integer overflow.
3763 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3764 since it's now a duplicate of the other. This is more of
3765 a character than a buffer op, so better that it's in character.c.
3766 * fns.c, print.c: Adjust to above changes.
3767
2ff916cb
PE
37682011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3769
3770 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3771
f1b54466
PE
37722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3773
fb1ac845
PE
3774 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3775 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3776 (x_clipboard_manager_save): Now static.
3777 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3778
f1b54466
PE
3779 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3780 (crypto_hash_function): Now static.
3781 Fix pointer signedness problems. Avoid unnecessary initializations.
3782
a9f737ee
CY
37832011-05-27 Chong Yidong <cyd@stupidchicken.com>
3784
3785 * termhooks.h (Vselection_alist): Make it terminal-local.
3786
3787 * terminal.c (create_terminal): Initialize it.
3788
3789 * xselect.c: Support for clipboard managers.
3790 (Vselection_alist): Move to termhooks.h as terminal-local var.
3791 (LOCAL_SELECTION): New macro.
3792 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3793 (symbol_to_x_atom): Remove gratuitous arg.
3794 (x_handle_selection_request, lisp_data_to_selection_data)
3795 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3796 (x_own_selection, x_get_local_selection, x_convert_selection):
3797 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3798 (some_frame_on_display): Delete unused function.
3799 (Fx_own_selection_internal, Fx_get_selection_internal)
3800 (Fx_disown_selection_internal, Fx_selection_owner_p)
3801 (Fx_selection_exists_p): New optional frame arg.
3802 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3803 (x_handle_selection_clear): Don't treat other terminals with the
3804 same keyboard specially. Use the terminal-local Vselection_alist.
3805 (x_clear_frame_selections): Use Frun_hook_with_args.
3806
3807 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3808
3809 * xterm.h: Add support for those atoms.
3810
e067f0c1
CY
38112011-05-26 Chong Yidong <cyd@stupidchicken.com>
3812
3813 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3814 (converted_selections, conversion_fail_tag): New global variables.
3815 (x_selection_request_lisp_error): Free the above.
3816 (x_get_local_selection): Remove unnecessary code.
3817 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3818 of converted selections stored in converted_selections.
3819 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3820 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3821 (x_convert_selection): New function.
3822 (x_handle_selection_event): Simplify.
3823 (x_get_foreign_selection): Don't ignore incoming requests while
3824 waiting for an answer; this will fail when we implement
3825 SAVE_TARGETS, and seems unnecessary anyway.
3826 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3827 (Vx_sent_selection_functions): Doc fix.
3828
0f4aebc0
LL
38292011-05-26 Leo Liu <sdl.web@gmail.com>
3830
3831 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3832
e61124cd
YM
38332011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3834
3835 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3836
3837 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3838 for fringe update if it has periodic bitmap.
ac389d0c 3839 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3840 and fringe_bitmap_periodic_p.
3841
3842 * fringe.c (get_fringe_bitmap_data): New function.
3843 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3844 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3845 row. Mark glyph row for fringe update if periodicity changed.
3846
3847 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3848 for fringe update unless it has periodic bitmap.
3849
f16d9837
KH
38502011-05-25 Kenichi Handa <handa@m17n.org>
3851
3852 * xdisp.c (get_next_display_element): Set correct it->face_id for
3853 a static composition.
3854
e1b90ef6
LL
38552011-05-24 Leo Liu <sdl.web@gmail.com>
3856
3857 * deps.mk (fns.o):
3858 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3859
3860 * fns.c (crypto_hash_function, Fsha1): New function.
3861 (Fmd5): Use crypto_hash_function.
3862 (syms_of_fns): Add Ssha1.
3863
7400048f
PE
38642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 * gnutls.c: Remove unused macros.
3867 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3868 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3869 Remove macros that are defined and never used.
3870 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3871
abb71cf4
CY
38722011-05-22 Chong Yidong <cyd@stupidchicken.com>
3873
3874 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3875 (Fx_get_selection_internal): Minor cleanup.
3876 (Fx_own_selection_internal): Rename arguments for consistency with
3877 select.el.
3878
6307db39
PE
38792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3882
f3d4e0a4
CY
38832011-05-22 Chong Yidong <cyd@stupidchicken.com>
3884
3885 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3886
4d8ade89
YM
38872011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3888
3889 * dispnew.c (scrolling_window): Don't exclude the case that the
3890 last enabled row in the desired matrix touches the bottom boundary.
3891
32078c8d
GM
38922011-05-21 Glenn Morris <rgm@gnu.org>
3893
3894 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3895 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3896 and add some more files.
32078c8d 3897
7285dc67
EZ
38982011-05-20 Eli Zaretskii <eliz@gnu.org>
3899
3900 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3901 report_file_error introduced by the change from 2011-05-07.
3902
89d1bd22
PE
39032011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 * systime.h (Time): Define only if emacs is defined.
3906 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3907 where the include path doesn't have X11/X.h by default. See
3908 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3909
e23640bb 39102011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3911
3912 * composite.c (find_automatic_composition): Fix previous change.
3913
b9704ad9
GM
39142011-05-20 Glenn Morris <rgm@gnu.org>
3915
3916 * lisp.mk: New file, split from Makefile.in.
3917 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3918 (shortlisp): Remove.
3919 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3920
4a720484
GM
39212011-05-19 Glenn Morris <rgm@gnu.org>
3922
3923 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3924 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3925 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3926 (lisp): Set the order to that of loadup.el.
3927 (shortlisp): Make it a copy of $lisp.
3928 (SOME_MACHINE_LISP): Remove.
3929 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3930 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3931
a28d4396
KH
39322011-05-18 Kenichi Handa <handa@m17n.org>
3933
3934 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3935 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3936 (find_automatic_composition): Mostly rewrite for efficiency.
3937
a2b1fa8e
JB
39382011-05-18 Juanma Barranquero <lekktu@gmail.com>
3939
3940 * makefile.w32-in: Update dependencies.
3941
8e1f5610
CS
39422011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3943
3944 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3945 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3946
7025ee00 39472011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3948
cdfa6eab
PE
3949 Fix some integer overflow issues, such as string length overflow.
3950
06d6db33
PE
3951 * insdel.c (count_size_as_multibyte): Check for string overflow.
3952
2b4560a8
PE
3953 * character.c (lisp_string_width): Check for string overflow.
3954 Use EMACS_INT, not int, for string indexes and lengths; in
3955 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3956 the resulting string length overflows an EMACS_INT; instead,
3957 report a string overflow if no precision given. When checking for
3958 precision exhaustion, use a check that cannot possibly have
3959 integer overflow. (Bug#8675)
3960 * character.h (lisp_string_width): Adjust to new signature.
3961
cb93f9be
PE
3962 * alloc.c (string_overflow): New function.
3963 (Fmake_string): Use it. This doesn't change behavior, but saves
3964 a few bytes and will simplify future changes.
3965 * character.c (string_escape_byte8): Likewise.
3966 * lisp.h (string_overflow): New decl.
3967
1a1f3366
PE
3968 Fixups, following up to the user-interface timestamp change.
3969 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3970 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3971 * msdos.c (mouse_get_pos): Likewise.
3972 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3973 * w32gui.h (Time): Define by including "systime.h" rather than by
3974 declaring it ourselves. (Bug#8664)
3975
d4e3e4d3
PE
3976 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3977 * image.c (clear_image_cache): Likewise.
3978
f6a24d19
PE
3979 * term.c (term_mouse_position): Don't assume time_t wraparound.
3980
08dc5ae6
PE
3981 Be more systematic about user-interface timestamps.
3982 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3983 and sometimes 'EMACS_UINT', to represent these timestamps.
3984 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3985 This makes the code easier to follow, and makes it easier to catch
3986 integer overflow bugs such as Bug#8664.
3987 * frame.c (Fmouse_position, Fmouse_pixel_position):
3988 Use Time, not unsigned long, for user-interface timestamps.
3989 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3990 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3991 * keyboard.h (last_event_timestamp): Likewise.
3992 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3993 * menu.h (xmenu_show): Likewise.
3994 * term.c (term_mouse_position): Likewise.
3995 * termhooks.h (struct input_event.timestamp): Likewise.
3996 (struct terminal.mouse_position_hook): Likewise.
3997 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3998 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3999 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4000 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4001 what it was before.
4002 * menu.h, termhooks.h: Include "systime.h", for Time.
4003
8e55734a
PE
4004 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4005 Don't assume that the difference between two unsigned long values
4006 can fit into an integer. At this point, we know button_down_time
4007 <= event->timestamp, so the difference must be nonnegative, so
4008 there's no need to cast the result if double-click-time is
4009 nonnegative, as it should be; check that it's nonnegative, just in
4010 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4011 apart (about 25 days). (Bug#8664)
8e55734a 4012
841f1b75 4013 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4014 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4015
3e26f69c
PE
4016 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4017 that always fit in int. Use a sentinel instead of a counter, to
4018 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4019 * frame.h (struct frame): Use int for menu_bar_items_used
4020 instead of EMACS_INT, since it always fits in int.
3e26f69c 4021
5cc152c0
PE
4022 * menu.c (grow_menu_items): Check for int overflow.
4023
d89eb65e
PE
4024 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4025
5235bd3e
PE
4026 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4027 Before, the code was not consistent. These values cannot exceed
4028 2**31 - 1 so there's no need to make them unsigned.
4029 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4030 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4031 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4032 as modifiers.
4033 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4034
bc827e23
PE
4035 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4036 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4037 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4038 presumably because the widths might not match.
4039
78eb494e
PE
4040 * window.c (size_window): Avoid needless test at loop start.
4041
04f2d78b
CB
40422011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4043
4044 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4045
d2fc7e3d 40462011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4047
4048 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4049
d2fc7e3d 40502011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4051
4052 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4053 `width' to `bar_area_x' and `bar_area_width', respectively.
4054 (x_scroll_run): Take account of fringe background extension.
4055
04f2d78b
CB
4056 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4057 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4058 `bar_area_width', respectively.
4059 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4060 background extension.
4061
79b70037
GM
40622011-05-10 Jim Meyering <meyering@redhat.com>
4063
4064 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4065
2f142cc5
JB
40662011-05-10 Juanma Barranquero <lekktu@gmail.com>
4067
4068 * image.c (Finit_image_library): Return t for built-in image types,
4069 like pbm and xbm. (Bug#8640)
4070
57679c86
AS
40712011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4072
4073 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4074
888c9e86
EZ
40752011-05-07 Eli Zaretskii <eliz@gnu.org>
4076
b0512a1d
EZ
4077 * w32console.c (Fset_screen_color): Doc fix.
4078 (Fget_screen_color): New function.
4079 (syms_of_ntterm): Defsubr it.
4080
7285dc67
EZ
4081 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4082 unlink the temporary file if Fcall_process didn't create it in the
4083 first place.
4084 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4085 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4086 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4087 cue to call_process_cleanup not to close that handle.
4088
4d3fcc8e
BK
40892011-05-07 Ben Key <bkey76@gmail.com>
4090
4091 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4092 one of two shell specific rules, either bootstrap-temacs-CMD or
4093 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4094 to the previous implementation of the bootstrap-temacs rule.
4095 The bootstrap-temacs-CMD rule is similar to the previous
4096 implementation of the bootstrap-temacs rule except that it
4097 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4098 variable.
4099
4100 These changes, along with some changes to nt/configure.bat,
4101 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4102 earlier fix to add support for --cflags and --ldflags options
4103 that include quotes so that it works whether make uses cmd or
4104 sh as the shell.
4105
b4289b64
MA
41062011-05-06 Michael Albinus <michael.albinus@gmx.de>
4107
4108 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4109 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4110 is a constant.
4111 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4112 a string. Handle both cases.
4113 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4114 (Fdbus_register_method): Use Qinvalid_function.
4115
af4c0e28
JB
41162011-05-06 Juanma Barranquero <lekktu@gmail.com>
4117
4118 * makefile.w32-in: Update dependencies.
4119 (LISP_H): Add inttypes.h and stdin.h.
4120 (PROCESS_H): Add unistd.h.
4121
c51453d9
EZ
41222011-05-06 Eli Zaretskii <eliz@gnu.org>
4123
4124 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4125 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4126
8ff0ac3c 41272011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4128
4c4b566b
PE
4129 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4130
aab2b9b5
PE
4131 * term.c (vfatal): Remove stray call to va_end.
4132 It's not needed and the C Standard doesn't allow it here anyway.
4133
c378da0b
PE
4134 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4135 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4136
288b08c7
PE
4137 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4138 bytes.
4139
e3601888
PE
4140 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4141
db6c0e74
PE
4142 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4143
dd5963ea
PE
4144 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4145
88c9450f
PE
4146 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4147
2f9442b8
PE
4148 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4149
c032b5f8
PE
4150 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4151 * charset.c (Fdefine_charset_internal): Don't initialize
4152 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4153 32-bit int (Bug#8600).
a108c10b
PE
4154
4155 * lread.c (read_integer): Be more consistent with string-to-number.
4156 Use string_to_number to do the actual conversion; this avoids
4157 rounding errors and fixes some other screwups. Without this fix,
4158 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4159 (digit_to_number): Move earlier, for benefit of read_integer.
4160 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4161 not a digit in any supported base. (Bug#8602)
a108c10b 4162
ad5f9eea
PE
4163 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4164
aec1708a
PE
4165 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4166 to match comment at start of function. This also removes a
4167 GCC warning about overflow in a 32+64-bit port.
4168
47be4ab5
PE
4169 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4170
371cac43
PE
4171 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4172 Reported by Stefan Monnier in
4173 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4174 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4175 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4176
d01a7826
PE
4177 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4178 (EMACS_UINTPTR): Likewise, with uintptr_t.
4179
7fd47d5c
PE
4180 * lisp.h: Prefer 64-bit EMACS_INT if available.
4181 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4182 on 32-bit hosts that have 64-bit int, so that they can access
4183 large files.
122b0c86
PE
4184 However, temporarily disable this change unless the temporary
4185 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4186
8727937b
PE
4187 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4188
8ac068ac
PE
4189 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4190 This removes an assumption that EMACS_INT and long are the same
4191 width as pointers. The assumption is true for Emacs porting targets
4192 now, but we want to make other targets possible.
4193 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4194 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4195 In the rest of the code, change types of integers that hold casted
4196 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4197 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4198 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4199 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4200 No need to cast type when ORing.
4201 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4202 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4203 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4204 assume EMACS_INT is the same width as char *.
4205 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4206 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4207 Remove no-longer-needed casts.
4208 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4209 (xg_tool_bar_help_callback, xg_make_tool_item):
4210 Use EMACS_INTPTR to hold an integer
4211 that will be cast to void *; this can avoid a GCC warning
4212 if EMACS_INT is not the same width as void *.
4213 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4214 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4215 (current_message_1, set_message_1):
4216 Use a local to convert to proper width without a cast.
4217 * xmenu.c (dialog_selection_callback): Likewise.
4218
ede49d71
PE
4219 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4220 Also, don't assume VALBITS / RAND_BITS is less than 5,
4221 and don't rely on undefined behavior when shifting a 1 left into
4222 the sign bit.
4223 * lisp.h (get_random): Change signature to match.
4224
2f30ecd0
PE
4225 * lread.c (hash_string): Use size_t, not int, for hash computation.
4226 Normally we prefer signed values; but hashing is special, because
4227 it's better to use unsigned division on hash table sizes so that
4228 the remainder is nonnegative. Also, size_t is the natural width
4229 for hashing into memory. The previous code used 'int', which doesn't
4230 retain enough info to hash well into very large tables.
4231 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4232
2a866e7b
PE
4233 * dbusbind.c: Don't possibly lose pointer info when converting.
4234 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4235 Use XPNTR rather than XHASH, so that the high-order bits of
4236 the pointer aren't lost when converting through void *.
4237
51639eac
PE
4238 * eval.c (Fautoload): Don't double-shift a pointer.
4239
92394119
PE
4240 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4241
dbdb9a7c
JB
42422011-05-06 Juanma Barranquero <lekktu@gmail.com>
4243
4244 * gnutls.c (DEF_GNUTLS_FN):
4245 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4246
db7a0b4f
AS
42472011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4248
4249 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4250 marker. (Bug#8610)
4251
f7ff1b0f 42522011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4253
4254 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4255 New version that can reserve upto 2GB of heap space.
4256
f7ff1b0f 42572011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4258
4259 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4260
639c109b
TZ
42612011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4262
4263 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4264 `gnutls_certificate_set_x509_key_file'.
4265
d2127135
JB
42662011-05-05 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4269 Update dependencies.
4270
e968f4f3
JB
42712011-05-04 Juanma Barranquero <lekktu@gmail.com>
4272
4273 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4274 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4275 Remove unused parameter `fildes'.
4276 * process.c (read_process_output, send_process): Don't pass it.
4277
84d358f0
JB
42782011-05-04 Juanma Barranquero <lekktu@gmail.com>
4279
4280 Fix previous change: the library cache is defined in w32.c.
4281 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4282 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4283
0898ca10
JB
42842011-05-04 Juanma Barranquero <lekktu@gmail.com>
4285
4286 Implement dynamic loading of GnuTLS on Windows.
4287
4288 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4289 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4290 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4291 Declare.
4292
4293 * gnutls.c (Qgnutls_dll): Define.
4294 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4295 (gnutls_*): Declare function pointers.
4296 (init_gnutls_functions): New function to initialize function pointers.
4297 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4298 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4299 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4300 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4301 (emacs_gnutls_write, emacs_gnutls_read)
4302 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4303 (Fgnutls_available_p): New function.
4304 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4305 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4306 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4307
4308 * image.c: Include w32.h.
4309 (Vimage_type_cache): Delete.
4310 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4311 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4312 (w32_delayed_load): Move to w32.c.
4313
4314 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4315
4316 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4317 (w32_delayed_load): Move from image.c. When loading a library, record
4318 its filename in the :loaded-from property of the library id.
4319 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4320 Initialize and staticpro them.
4321 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4322
4323 * process.c: Include lisp.h before w32.h, not after.
4324 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4325 instead of gnutls_record_check_pending.
4326
4327 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4328
ff4de4aa
TZ
43292011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4330
4331 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4332 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4333 as passed in.
4334
abe95abb
JD
43352011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4336
4337 * xterm.c (x_set_frame_alpha): Do not set property on anything
4338 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4339
e16e55d4
JB
43402011-05-02 Juanma Barranquero <lekktu@gmail.com>
4341
4342 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4343
bafcf6a5
JB
43442011-05-02 Juanma Barranquero <lekktu@gmail.com>
4345
4346 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4347 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4348 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4349 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4350 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4351 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4352 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4353 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4354 (Qgnutls_bootprop_callbacks_verify): Make static.
4355
e7a6747f
AS
43562011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4357
19ed11ba
AS
4358 * callproc.c: Indentation fixup.
4359
e7a6747f 4360 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4361 (wait_for_termination, interruptible_wait_for_termination):
4362 Move after wait_for_termination_1.
e7a6747f 4363
1ef14cb4
LMI
43642011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4365
4366 * sysdep.c (interruptible_wait_for_termination): New function
4367 which is like wait_for_termination, but allows keyboard
4368 interruptions.
4369
4370 * callproc.c (Fcall_process): Add (:file "file") as an option for
4371 the STDOUT buffer.
4372 (Fcall_process_region): Ditto.
4373
330d880c
EZ
43742011-04-30 Eli Zaretskii <eliz@gnu.org>
4375
8db90b73
EZ
4376 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4377 rather than `XVECTOR (FOO)->size'.
4378
330d880c
EZ
4379 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4380 inttypes.h, as a gnulib replacement is used if it not available in
4381 system headers.
4382
15cbd324
EZ
43832011-04-21 Eli Zaretskii <eliz@gnu.org>
4384
4385 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4386 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4387 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4388
4389 * coding.c (coding_alloc_by_realloc): Error out if destination
4390 will grow beyond MOST_POSITIVE_FIXNUM.
4391 (decode_coding_emacs_mule): Abort if there isn't enough place in
4392 charbuf for the composition carryover bytes. Reserve an extra
4393 space for up to 2 characters produced in a loop.
4394 (decode_coding_iso_2022): Abort if there isn't enough place in
4395 charbuf for the composition carryover bytes.
4396
43972011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4398
ae940cca
EZ
4399 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4400 aborting when %lld or %lll format is passed.
4401 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4402 %llo or %llx format is passed. (Bug#8545)
4403
03ab8921
EZ
4404 * window.c (window_scroll_line_based): Use a marker instead of
4405 simple variables to record original value of point. (Bug#7952)
4406
afda1437
EZ
4407 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4408 produced by %s or %c overflows available buffer space. (Bug#8545)
4409
f76dee0c
PE
44102011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4411
4412 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4413 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4414
fdc5744d
JB
44152011-04-28 Juanma Barranquero <lekktu@gmail.com>
4416
4417 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4418
638f053a
JB
44192011-04-28 Juanma Barranquero <lekktu@gmail.com>
4420
4421 * keyboard.c (Qdelayed_warnings_hook): Define.
4422 (command_loop_1): Run `delayed-warnings-hook'
4423 if Vdelayed_warnings_list is non-nil.
4424 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4425 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4426
d178f871
EZ
44272011-04-28 Eli Zaretskii <eliz@gnu.org>
4428
4429 * doprnt.c (doprnt): Don't return value smaller than the buffer
4430 size if the message was truncated. (Bug#8545).
4431
b124fd93
JB
44322011-04-28 Juanma Barranquero <lekktu@gmail.com>
4433
4434 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4435 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4436
e810457d
PE
44372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4438
4439 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4440
ea51cceb
JB
44412011-04-27 Juanma Barranquero <lekktu@gmail.com>
4442
4443 * makefile.w32-in: Update dependencies.
4444
94dcfacf
EZ
44452011-04-27 Eli Zaretskii <eliz@gnu.org>
4446
4447 Improve `doprnt' and its usage. (Bug#8545)
4448 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4449 `format_end'. Remove support for %l as a conversion specifier.
4450 Don't use xrealloc. Improve diagnostics when the %l size modifier
4451 is used. Update the commentary.
4452
4453 * eval.c (verror): Simplify calculation of size_t.
4454
4455 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4456 messages.
4457
f61f41d7
PE
44582011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4459
4460 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4461 change.
4462
96fb4434
PE
44632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4466 This makes this file independent of the recent pseudovector change.
4467
671875da 44682011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4469
69e9b5a3
PE
4470 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4471
b5f869a7 4472 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4473 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4474 Remove unused local.
c8926152 4475 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4476
841a1577 4477 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4478 GCC 4.6.0 optimizes based on type-based alias analysis.
4479 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4480 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4481 != &v->size, and therefore "v->size = 1; b->size = 2; return
4482 v->size;" must therefore return 1. This assumption is incorrect
4483 for Emacs, since it type-puns struct Lisp_Vector * with many other
4484 types. To fix this problem, this patch adds a new type struct
f904488f 4485 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4486 and pseudovectors, and helps optimizing compilers not get fooled
4487 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4488 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4489 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4490 the size member.
eab3844f
PE
4491 (XSETPVECTYPE): Rewrite in terms of new macro.
4492 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4493 This is a bit clearer, and further avoids the possibility of
4494 undesirable aliasing.
4495 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4496 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4497 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4498 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4499 (ASIZE): Now uses header.size rather than size.
4500 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4501 to avoid the hassle of writing XVECTOR (foo)->header.size.
4502 (struct vectorlike_header): New type.
eab3844f
PE
4503 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4504 object, to help avoid aliasing.
4505 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4506 (SUBRP): Likewise, since Lisp_Subr is a special case.
4507 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4508 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4509 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4510 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4511 changed to be "header.size" and "header.next".
4512 * buffer.h (struct buffer): Likewise.
4513 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4514 * frame.h (struct frame): Likewise.
4515 * process.h (struct Lisp_Process): Likewise.
4516 * termhooks.h (struct terminal): Likewise.
4517 * window.c (struct save_window_data, struct saved_window): Likewise.
4518 * window.h (struct window): Likewise.
4519 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4520 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4521 * buffer.c (init_buffer_once): Likewise.
4522 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4523 special case.
4524 * process.c (Fformat_network_address): Use local var for size,
4525 for brevity.
4526
0df1eac5
PE
4527 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4528
847ab9d1 4529 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4530 * data.c (atof): Remove decl; no longer used or needed.
4531 (digit_to_number): Move to lread.c.
4532 (Fstring_to_number): Use new string_to_number function, to be
4533 consistent with how the Lisp reader treats infinities and NaNs.
4534 Do not assume that floating-point numbers represent EMACS_INT
4535 without losing information; this is not true on most 64-bit hosts.
4536 Avoid double-rounding errors, by insisting on integers when
4537 parsing non-base-10 numbers, as the documentation specifies.
4538 * lisp.h (string_to_number): New decl, replacing ...
4539 (isfloat_string): Remove.
bc0a5c13 4540 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4541 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4542 appears to have been a coding error. Similarly, do not accept
4543 strings like +-1e0 as floating point numbers. Do not report
4544 overflow for integer overflows unless the base is not 10 which
4545 means we have no simple and reliable way to continue.
4546 Break out the floating-point parsing into a new
4547 function string_to_number, so that Fstring_to_number parses
4548 floating point numbers consistently with the Lisp reader.
04f2d78b 4549 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4550 (E_CHAR, EXP_INT): Remove, replacing with ...
4551 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4552 (string_to_number): New function, replacing isfloat_string.
4553 This function checks for valid syntax and produces the resulting
4554 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4555 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4556 so that overflow for non-base-10 numbers is reported only when
4557 there's no portable and simple way to convert to floating point.
452f4150 4558
67769ffc
PE
4559 * textprop.c (set_text_properties_1): Rewrite for clarity,
4560 and to avoid GCC warning about integer overflow.
4561
c20db43f
PE
4562 * intervals.h (struct interval): Use EMACS_INT for members
4563 where EMACS_UINT might cause problems. See
4564 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4565 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4566 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4567 All uses changed.
37aa2f85
PE
4568 (offset_intervals): Tell GCC not to worry about length overflow
4569 when negating a negative length.
c20db43f 4570
2538aa2f
PE
4571 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4572 (overrun_check_free): Likewise.
4573
f2d3008d
PE
4574 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4575 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4576 word size.
4577
ec8df744
PE
4578 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4579 (gnutls_make_error): Rename local to avoid shadowing.
4580 (gnutls_emacs_global_deinit): ifdef out; not used.
4581 (Fgnutls_boot): Use const for pointer to readonly storage.
4582 Comment out unused local. Fix pointer signedness problems.
4583
640ee02d
PE
4584 * lread.c (openp): Don't stuff size_t into an 'int'.
4585 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4586 about possible signed overflow.
4587
6048fb2a
PE
4588 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4589 (GDK_KEY_g): Don't define if already defined.
4590 (xg_prepare_tooltip): Avoid pointer signedness problem.
4591 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4592
fa3c87e1
PE
4593 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4594 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4595
2172544b
PE
4596 * xfns.c (Fx_window_property): Simplify a bit,
4597 to make a bit faster and to avoid GCC 4.6.0 warning.
4598 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4599
9b821a21
PE
4600 * fns.c (internal_equal): Don't assume size_t fits in int.
4601
3c616cfa
PE
4602 * alloc.c (compact_small_strings): Tighten assertion a little.
4603
c2982e87
PE
4604 Replace pEd with more-general pI, and fix some printf arg casts.
4605 * lisp.h (pI): New macro, generalizing old pEd macro to other
4606 conversion specifiers. For example, use "...%"pI"d..." rather
4607 than "...%"pEd"...".
4608 (pEd): Remove. All uses replaced with similar uses of pI.
4609 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4610 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4611 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4612 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4613 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4614 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4615 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4616 64-bit hosts.
4617 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4618 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4619 * print.c (safe_debug_print, print_object): Likewise.
4620 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4621 to int.
6f04d126
PE
4622 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4623 avoiding the 0 flag, which is not portable.
c2982e87
PE
4624 * process.c (Fmake_network_process): Use pI to avoid cast.
4625 * region-cache.c (pp_cache): Likewise.
4626 * xdisp.c (decode_mode_spec): Likewise.
4627 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4628 behavior on 64-bit hosts with printf arg.
6f04d126 4629 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4630 (x_stop_queuing_selection_requests): Likewise.
4631 (x_get_window_property): Don't truncate byte count to an 'int'
4632 when tracing.
0b432f21 4633
5e073ec7
PE
4634 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4635 here, since it parses constructs like leading '-' and spaces,
4636 which are not wanted; and it overflows with large numbers.
4637 Instead, simply match F[0-9]+, which is what is wanted anyway.
4638
36372bf9
PE
4639 * alloc.c: Remove unportable assumptions about struct layout.
4640 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4641 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4642 (allocate_vectorlike, make_pure_vector): Use the new macros,
4643 plus offsetof, to remove unportable assumptions about struct layout.
4644 These assumptions hold on all porting targets that I know of, but
4645 they are not guaranteed, they're easy to remove, and removing them
4646 makes further changes easier.
4647
0b432f21
PE
4648 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4649 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4650 (string_overrun_cookie): Now const. Use initializers that
4651 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4652 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4653 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4654 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4655 multiple of sizeof (EMACS_INT); it need not be, if
4656 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4657 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4658
895009e1
JB
46592011-04-26 Juanma Barranquero <lekktu@gmail.com>
4660
4661 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4662
6a7a1b0b
TZ
46632011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4664
4665 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4666 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4667 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4668
841a1577 46692011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4670
4671 * lisp.h (Qdebug): List symbol.
895009e1 4672 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4673 * keyboard.c (debug-on-event): New variable.
4674 (handle_user_signal): Break into debugger when debug-on-event
4675 matches the current signal symbol.
4676
f2d3ba6f
DN
46772011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4678
4679 * alloc.c (check_sblock, check_string_bytes)
4680 (check_string_free_list): Convert to standard C.
4681
42ce4c63
TZ
46822011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4683
4684 * w32.c (emacs_gnutls_push): Fix typo.
4685
825cd63c
EZ
46862011-04-25 Eli Zaretskii <eliz@gnu.org>
4687
fb11d64d
EZ
4688 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4689 "cast to pointer from integer of different size".
4690
825cd63c
EZ
4691 Improve doprnt and its use in verror. (Bug#8545)
4692 * doprnt.c (doprnt): Document the set of format control sequences
4693 supported by the function. Use SAFE_ALLOCA instead of always
4694 using `alloca'.
4695
4696 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4697 is one byte too soon. Don't use xrealloc; instead xfree and
4698 xmalloc anew.
4699
e061a11b
TZ
47002011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4701
4702 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4703 callbacks stage.
4704
4705 * gnutls.c: Renamed global_initialized to
4706 gnutls_global_initialized. Added internals for the
4707 :verify-hostname-error, :verify-error, and :verify-flags
4708 parameters of `gnutls-boot' and documented those parameters in the
4709 docstring. Start callback support.
9173deec
JB
4710 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4711 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4712 on error. Return error code.
e061a11b
TZ
4713 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4714 (emacs_gnutls_read): Likewise.
4715 (Fgnutls_boot): Return handshake error code.
4716 (emacs_gnutls_handle_error): New function.
4717 (wsaerror_to_errno): Likewise.
4718
4719 * w32.h (emacs_gnutls_pull): Add prototype.
4720 (emacs_gnutls_push): Likewise.
4721
4722 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4723 (emacs_gnutls_push): Likewise.
4724
47252011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4726
4727 * process.c (wait_reading_process_output): Check if GnuTLS
4728 buffered some data internally if no FDs are set for TLS
4729 connections.
4730
4731 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4732 (LIBS): Link to USER_LIBS.
4733 ($(BLD)/gnutls.$(0)): New target.
4734
fa6996bc
EZ
47352011-04-24 Eli Zaretskii <eliz@gnu.org>
4736
eb35682e
EZ
4737 * xdisp.c (handle_single_display_spec): Rename the
4738 display_replaced_before_p argument into display_replaced_p, to
4739 make it consistent with the commentary. Fix typos in the
4740 commentary.
4741
e2ad650c
EZ
4742 * textprop.c (syms_of_textprop): Remove dead code.
4743 (copy_text_properties): Delete obsolete commentary about an
4744 interface that was deleted long ago. Fix typos in the description
4745 of arguments.
4746
1b2de274
EZ
4747 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4748 to changes in oldXMenu/XMenu.h from 2011-04-16.
4749 <menu_help_message, prev_menu_help_message>: Constify.
4750 (IT_menu_make_room): menu->help_text is now `const char **';
4751 adjust.
4752
4753 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4754 to changes in oldXMenu/XMenu.h from 2011-04-16.
4755 (struct XMenu): Declare `help_text' `const char **'.
4756
4757 * xfaces.c <Qunspecified>: Make extern again.
4758
4759 * syntax.c: Include sys/types.h before including regex.h, as
4760 required by Posix.
4761
762b15be
EZ
4762 * doc.c (get_doc_string): Improve the format passed to `error'.
4763
4764 * doprnt.c (doprnt): Improve commentary.
4765
4766 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4767
4768 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4769 them with etags.
4770
f1052e5d
EZ
4771 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4772 changes in globals.h immediately force recompilation.
762b15be
EZ
4773 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4774 $(CURDIR)/s/ms-w32.h.
4775 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4776
fa6996bc
EZ
4777 * character.c (Fchar_direction): Function deleted.
4778 (syms_of_character): Don't defsubr it.
4779 <char-direction-table>: Deleted.
4780
e6c3da20
EZ
47812011-04-23 Eli Zaretskii <eliz@gnu.org>
4782
4783 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4784 * doprnt.c: Include limits.h.
4785 (SIZE_MAX): New macro.
04f2d78b
CB
4786 (doprnt): Return a size_t value. 2nd arg is now size_t.
4787 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4788 Improve overflow protection. Support `l' modifier for integer
4789 conversions. Support %l conversion. Don't assume an EMACS_INT
4790 argument for integer conversions and for %c.
4791
4792 * lisp.h (doprnt): Restore prototype.
4793
4794 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4795 $(SRC)/character.h.
4796
4797 * Makefile.in (base_obj): Add back doprnt.o.
4798
4799 * deps.mk (doprnt.o): Add back prerequisites.
4800 (callint.o): Depend on character.h.
4801
4802 * eval.c (internal_lisp_condition_case): Include the handler
4803 representation in the error message.
4804 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4805 when breaking from the loop.
4806
4807 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4808
4809 * callint.c (Fcall_interactively): When displaying error message
4810 about invalid control letter, pass the character's codepoint, not
4811 a pointer to its multibyte form. Improve display of the character
4812 in octal and display also its hex code.
4813
4814 * character.c (char_string): Use %x to display the (unsigned)
4815 codepoint of an invalid character, to avoid displaying a bogus
4816 negative value.
4817
4818 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4819 `error', not SYMBOL_NAME itself.
4820
4821 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4822 character arguments to `error'.
4823
4824 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4825 to `error' in error message about FINAL_CHAR argument. Make sure
4826 FINAL_CHAR is a character, and use %c when it is passed as
4827 argument to `error'.
4828
4ffd0d6b 48292011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4830
4831 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4832
4833 * w32.c: Include <time.h>.
4834 (sys_localtime): New function.
4835
4ffd0d6b 48362011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4837
4838 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4839
4ffd0d6b 4840 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4841
4ffd0d6b 48422011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4843
4ffd0d6b
GM
4844 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4845 zombies (Bug#8467).
aac0c6e3 4846
04c56954
EZ
48472011-04-19 Eli Zaretskii <eliz@gnu.org>
4848
4849 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4850 gl_state.e_property when gl_state.object is Qt.
4851
4852 * insdel.c (make_gap_larger): Remove limitation of buffer size
4853 to <= INT_MAX.
4854
16a43933
CY
48552011-04-18 Chong Yidong <cyd@stupidchicken.com>
4856
4857 * xdisp.c (lookup_glyphless_char_display)
4858 (produce_glyphless_glyph): Handle cons cell entry in
4859 glyphless-char-display.
4860 (Vglyphless_char_display): Document it.
4861
4862 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4863 glyphless-char-display.
4864
4581706e
CY
48652011-04-17 Chong Yidong <cyd@stupidchicken.com>
4866
4867 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4868
4869 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4870
4871 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4872 definition for no-X builds.
4873
4887c6e2 48742011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4875
fd35b6f9
PE
4876 Static checks with GCC 4.6.0 and non-default toolkits.
4877
5c1ccb01
PE
4878 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4879
006c5daa
PE
4880 * process.c (keyboard_bit_set): Define only if SIGIO.
4881 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4882 (send_process): Repair possible setjmp clobbering.
4883
efc736d3
PE
4884 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4885
4e2fe2e6
PE
4886 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4887
f97334a2
PE
4888 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4889
4e75f29d
PE
4890 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4891 Define only if needed.
4892
90efadd1
PE
4893 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4894 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4895 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4896
3c647824
PE
4897 * dispextern.h (struct redisplay_interface): Rename param
4898 to avoid shadowing.
e264f262 4899 * termhooks.h (struct terminal): Likewise.
761383f4 4900 * xterm.c (xembed_send_message): Likewise.
3c647824 4901
b58c5c4a
PE
4902 * insdel.c (make_gap_smaller): Define only if
4903 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4904
cad59032
PE
4905 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4906 it.
4907
c339dc2e
PE
4908 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4909 so that we aren't warned about unused symbols.
4910
91a3e27b
PE
4911 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4912
399c71d3 4913 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4914
8ffc96f5
PE
4915 * xfns.c (x_real_positions): Mark locals as initialized.
4916
eef9bc79
PE
4917 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4918
098db9dd
PE
4919 * xterm.c: Fix problems found by static analysis with other toolkits.
4920 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4921 (x_dispatch_event): Declare static if USE_GTK, and
4922 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4923 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4924 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4925 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4926 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4927
eb18f6cc
PE
4928 * xmenu.c (menu_help_callback): Pointer type fixes.
4929 Use const pointers when pointing at readonly data. Avoid pointer
4930 signedness clashes.
4931 (FALSE): Remove unused macro.
4932 (update_frame_menubar): Remove unused decl.
4933
1fe72bf8
PE
4934 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4935
60d9e1db
PE
4936 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4937 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4938 (single_menu_item): Rename local to avoid shadowing.
4939
39261c26
PE
4940 * keyboard.c (make_lispy_event): Remove unused local var.
4941
018c5e19
PE
4942 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4943 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4944
63d2b86e
PE
4945 * bitmaps: Change bitmaps from unsigned char back to the X11
4946 compatible char. Avoid the old compiler warnings about
4947 out-of-range initializers by using, for example, '\xab' rather
4948 than 0xab.
4949
aefd87e1
PE
4950 * xgselect.c (xgselect_initialize): Check vs interface
4951 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4952
bf501fb9
PE
4953 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4954
e9829fdf
PE
4955 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4956 to read-only memory.
4957
1086c095
PE
4958 * fns.c (vector): Remove; this old hack is no longer needed.
4959
2baccd04 4960 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4961 Remove unused var.
dde42981 4962 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4963
72391843 4964 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4965
436c16df 4966 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4967 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4968 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4969
92bb796d 4970 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4971 (x_term_init): Remove local to avoid shadowing.
92bb796d 4972
764430a3 4973 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4974
4975 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4976 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4977
d1dfb56c
EZ
49782011-04-16 Eli Zaretskii <eliz@gnu.org>
4979
c4354cb4
EZ
4980 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4981
d1dfb56c
EZ
4982 Fix regex.c, syntax.c and friends for buffers > 2GB.
4983 * syntax.h (struct gl_state_s): Declare character position members
4984 EMACS_INT.
4985
4986 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4987
04f2d78b
CB
4988 * textprop.c (verify_interval_modification, interval_of):
4989 Declare arguments EMACS_INT.
d1dfb56c
EZ
4990
4991 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4992 EMACS_INT.
4993
4994 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4995
4996 * indent.c (Fvertical_motion): Local variable it_start is now
4997 EMACS_INT.
4998
4999 * regex.c (re_match, re_match_2, re_match_2_internal)
5000 (bcmp_translate, regcomp, regexec, print_double_string)
5001 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5002 (re_compile_pattern, re_exec): Declare arguments and local
5003 variables `size_t' and `ssize_t' and return values `regoff_t', as
5004 appropriate.
5005 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5006 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5007 <compile_stack_type>: `size' and `avail' are now `size_t'.
5008
5009 * regex.h <regoff_t>: Use ssize_t, not int.
5010 (re_search, re_search_2, re_match, re_match_2): Arguments that
5011 specify buffer/string position and length are now ssize_t and
5012 size_t. Return type is regoff_t.
5013
613052cd
BK
50142011-04-16 Ben Key <bkey76@gmail.com>
5015
5016 * nsfont.m: Fixed bugs in ns_get_family and
5017 ns_descriptor_to_entity that were caused by using free to
5018 deallocate memory blocks that were allocated by xmalloc (via
5019 xstrdup). This caused Emacs to crash when compiled with
5020 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5021 --enable-checking=xmallocoverrun). xfree is now used to
5022 deallocate these memory blocks.
5023
4170f62f 50242011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5025
71b41406
PE
5026 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5027
9587a89d
PE
5028 emacs_write: Accept and return EMACS_INT for sizes.
5029 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5030 et seq.
5031 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5032 Accept and return EMACS_INT.
5033 (emacs_gnutls_write): Return the number of bytes written on
5034 partial writes.
5035 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5036 (emacs_read, emacs_write): Remove check for negative size, as the
5037 Emacs source code has been audited now.
9587a89d
PE
5038 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5039 (emacs_read, emacs_write): Use it.
273a5f82
PE
5040 * process.c (send_process): Adjust to the new signatures of
5041 emacs_write and emacs_gnutls_write. Do not attempt to store
5042 a byte offset into an 'int'; it might overflow.
9587a89d 5043 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5044
3e047f51
PE
5045 * sound.c: Don't assume sizes fit in 'int'.
5046 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5047 Return EMACS_INT, not int.
3e047f51 5048 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5049 Accept EMACS_INT, not int.
5050 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5051 record read return values.
5052
cc39a9db
BK
50532011-04-15 Ben Key <bkey76@gmail.com>
5054
c9d0ec6d
JB
5055 * keyboard.c (Qundefined): Don't declare static since it is used
5056 in nsfns.m.
5057 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5058 static since they are used in nsfont.m.
cc39a9db 5059
6c60eb9f
SM
50602011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5061
5062 * process.c (Qprocessp): Don't declare static.
5063 * lisp.h (Qprocessp): Declare again.
5064
7990b61a
JB
50652011-04-15 Juanma Barranquero <lekktu@gmail.com>
5066
5067 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5068
5d4cb038
PE
50692011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5070
8bd7b830 5071 Improve C-level modularity by making more things 'static'.
cd64ea1d 5072
e3b27b31
PE
5073 Don't publish debugger-only interfaces to other modules.
5074 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5075 (verify_bytepos, count_markers): Move decls to the only modules
5076 that need them.
5077 * region-cache.h (pp_cache): Likewise.
5078 * window.h (check_all_windows): Likewise.
5079 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5080
5d4cb038
PE
5081 * sysdep.c (croak): Now static, if
5082 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5083 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5084
5085 * alloc.c (refill_memory_reserve): Now static if
5086 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5087 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5088
e87b6180
PE
5089 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5090 Define only if USE_LUCID.
5091
ac64929e
PE
5092 * xrdb.c (x_customization_string, x_rm_string): Now static.
5093
6f37259d
PE
5094 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5095 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5096
1683e3ab
PE
5097 * xdisp.c (draw_row_with_mouse_face): Now static.
5098 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5099
de9c2632
PE
5100 * window.h (check_all_windows): Mark externally visible.
5101
2b96acb7
PE
5102 * window.c (window_deletion_count): Now static.
5103
5104 * undo.c: Make symbols static if they're not exported.
5105 (last_undo_buffer, last_boundary_position, pending_boundary):
5106 Now static.
5107
50436f33
PE
5108 * textprop.c (interval_insert_behind_hooks): Now static.
5109 (interval_insert_in_front_hooks): Likewise.
5110
64520e5c
PE
5111 * term.c: Make symbols static if they're not exported.
5112 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5113 (max_frame_lines, tty_set_terminal_modes):
5114 (tty_reset_terminal_modes, tty_turn_off_highlight):
5115 (get_tty_terminal): Now static.
5116 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5117 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5118 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5119 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5120 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5121
1fa53021
PE
5122 * sysdep.c: Make symbols static if they're not exported.
5123 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5124 Now static.
5125 (sigprocmask_set, full_mask): Remove; unused.
5126 (wait_debugging): Mark as visible.
5127 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5128 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5129
d4b43b22
PE
5130 * syntax.c (syntax_temp): Define only if !__GNUC__.
5131
b7c513d0
PE
5132 * sound.c (current_sound_device, current_sound): Now static.
5133
989b29ad
PE
5134 * search.c (searchbufs, searchbuf_head): Now static.
5135
13a55a78
PE
5136 * scroll.c (scroll_cost): Remove; unused.
5137 * dispextern.h (scroll_cost): Remove decl.
5138
de68a1fc
PE
5139 * region-cache.h (pp_cache): Mark as externally visible.
5140
40ccffa6
PE
5141 * process.c: Make symbols static if they're not exported.
5142 (process_tick, update_tick, create_process, chan_process):
5143 (Vprocess_alist, proc_buffered_char, datagram_access):
5144 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5145 (deactivate_process): Mark defn as static, as well as decl.
5146 * lisp.h (create_process): Remove decl.
5147 * process.h (chan_process, Vprocess_alist): Remove decls.
5148
ad64fc97
PE
5149 * print.c: Make symbols static if they're not exported.
5150 (print_depth, new_backquote_output, being_printed, print_buffer):
5151 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5152 (print_interval, print_number_index, initial_stderr_stream):
5153 Now static.
5154 * lisp.h (Fprinc): Remove decl.
5155 (debug_output_compilation_hack): Mark as externally visible.
5156
adddb265
PE
5157 * sysdep.c (croak): Move decl from here to syssignal.h.
5158 * syssignal.h (croak): Put it here, so the API can be checked when
5159 'croak' is called from dissociate_if_controlling_tty.
5160
1717ede2
PE
5161 * minibuf.c: Make symbols static if they're not exported.
5162 (minibuf_save_list, choose_minibuf_frame): Now static.
5163 * lisp.h (choose_minibuf_frame): Remove decl.
5164
fa5fb2bc
PE
5165 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5166
1e3890d1
PE
5167 * lread.c: Make symbols static if they're not exported.
5168 (read_objects, initial_obarray, oblookup_last_bucket_number):
5169 Now static.
5170 (make_symbol): Remove; unused.
5171 * lisp.h (initial_obarray, make_symbol): Remove decls.
5172
8a1414fa
PE
5173 * keyboard.c: Make symbols static if they're not exported.
5174 (single_kboard, recent_keys_index, total_keys, recent_keys):
5175 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5176 (this_single_command_key_start, echoing, last_auto_save):
5177 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5178 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5179 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5180 (Vlispy_mouse_stem, double_click_count):
5181 Now static.
5182 (force_auto_save_soon): Define only if SIGDANGER.
5183 (ignore_mouse_drag_p): Now static if
5184 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5185 (print_help): Remove; unused.
5186 (stop_character, last_timer_event): Mark as externally visible.
5187 * keyboard.h (ignore_mouse_drag_p): Declare only if
5188 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5189 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5190 * lisp.h (echoing): Remove decl.
5191 (force_auto_save_soon): Declare only if SIGDANGER.
5192 * xdisp.c (redisplay_window): Simplify code, to make it more
5193 obvious that ignore_mouse_drag_p is not accessed if !defined
5194 USE_GTK && !defined HAVE_NS.
5195
93ea6e8f
PE
5196 * intervals.c: Make symbols static if they're not exported.
5197 (merge_properties_sticky, merge_interval_right, delete_interval):
5198 Now static.
5199 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5200
77382fcc
PE
5201 * insdel.c: Make symbols static if they're not exported.
5202 However, leave prepare_to_modify_buffer alone. It's never
5203 called from outside this function, but that appears to be a bug.
5204 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5205 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5206 (adjust_after_replace_noundo): Remove; unused.
5207 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5208 (signal_before_change): Remove decls.
77382fcc 5209
9306c32e
PE
5210 * indent.c (val_compute_motion, val_vmotion): Now static.
5211
cd44d2eb
PE
5212 * image.c: Make symbols static if they're not exported.
5213 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5214 if USE_GTK.
5215 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5216 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5217
ad9a7a06
PE
5218 * fringe.c (standard_bitmaps): Now static.
5219 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5220
81626931
PE
5221 * frame.c: Make symbols static if they're not exported.
5222 (x_report_frame_params, make_terminal_frame): Now static.
5223 (get_frame_param): Now static, unless HAVE_NS.
5224 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5225 (x_get_resource_string): Remove; not used.
5226 * frame.h (make_terminal_frame, x_report_frame_params):
5227 (x_get_resource_string); Remove decls.
5228 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5229 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5230
239f9db9
PE
5231 * font.c, fontset.c: Make symbols static if they're not exported.
5232 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5233 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5234 * font.c (font_close_object): Now static.
5235 * font.h (font_close_object): Remove.
5236 * fontset.c (FONTSET_OBJLIST): Remove.
5237 (free_realized_fontset) #if-0 the body, which does nothing.
5238 (face_suitable_for_char_p): #if-0, as it's never called.
5239 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5240 * xfaces.c (face_at_string_position):
5241 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5242 since 0 is always ASCII.
5243
dfcf3579
PE
5244 * fns.c (weak_hash_tables): Now static.
5245
5045092b
PE
5246 * fileio.c: Make symbols static if they're not exported.
5247 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5248 (Vwrite_region_annotation_buffers): Now static.
5249
57a96f5c
PE
5250 * eval.c: Make symbols static if they're not exported.
5251 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5252 * lisp.h (backtrace_list): Remove decl.
5253
35f08c38
PE
5254 * emacs.c: Make symbols static if they're not exported.
5255 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5256 (fatal_error_code, fatal_error_signal_hook, standard_args):
5257 Now static.
5258 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5259 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5260 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5261 * lisp.h (fatal_error_signal_hook): Remove decl.
5262 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5263
f44bd759
PE
5264 * editfns.c: Move a (normally-unused) function to its only use.
5265 * editfns.c, lisp.h (get_operating_system_release): Remove.
5266 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5267 worth the hassle of breaking this out.
5268
b532497d
PE
5269 * xterm.c: Make symbols static if they're not exported.
5270 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5271 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5272 (x_destroy_window, x_delete_display):
5273 Now static.
5274 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5275 (x_mouse_leave): Remove; unused.
5276 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5277 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5278 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5279 Remove decls.
5280 (x_mouse_leave): Declare only if WINDOWSNT.
5281 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5282 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5283 USE_X_TOOLKIT.
5284
1675728f
PE
5285 * ftxfont.c: Make symbols static if they're not exported.
5286 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5287 HAVE_FREETYPE.
5288 * font.h (ftxfont_driver): Likewise.
5289
e4cebfca
PE
5290 * xfns.c: Make symbols static if they're not exported.
5291 (x_last_font_name, x_display_info_for_name):
5292 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5293 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5294 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5295 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5296 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5297 (last_show_tip_args): Now static.
5298 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5299 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5300 (x_screen_planes): Remove; unused.
5301 * dispextern.h (x_screen_planes): Remove decl.
5302
5bf46f05
PE
5303 * dispnew.c: Make symbols static if they're not exported.
5304 * dispextern.h (redraw_garbaged_frames, scrolling):
5305 (increment_row_positions): Remove.
5306 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5307 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5308 Now static.
5309 (redraw_garbaged_frames): Remove; unused.
5310
435f4c28
PE
5311 * xfaces.c: Make symbols static if they're not exported.
5312 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5313 Remove decls.
5314 * xterm.h (defined_color): Remove decls.
5315 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5316 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5317 (menu_face_changed_default, defined_color, free_realized_face):
5318 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5319 (ascii_face_of_lisp_face): Remove; unused.
5320
8524aef3
PE
5321 * xdisp.c: Make symbols static if they're not exported.
5322 * dispextern.h (scratch_glyph_row, window_box_edges):
5323 (glyph_to_pixel_coords, set_cursor_from_row):
5324 (get_next_display_element, set_iterator_to_next):
5325 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5326 (show_mouse_face): Remove decls
5327 * frame.h (message_buf_print): Likewise.
5328 * lisp.h (pop_message, set_message, check_point_in_composition):
5329 Likewise.
5330 * xterm.h (set_vertical_scroll_bar): Likewise.
5331 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5332 (message_buf_print, scratch_glyph_row, displayed_buffer):
5333 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5334 (get_next_display_element, show_mouse_face, window_box_edges):
5335 (frame_to_window_pixel_xy, check_point_in_composition):
5336 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5337 (glyph_to_pixel_coords): Remove; unused.
5338
16390cd2
PE
5339 * dired.c (file_name_completion): Now static.
5340
5341 * dbusbind.c (xd_in_read_queued_messages): Now static.
5342
a25f4dfa
PE
5343 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5344 * data.c (circular_list_error): Remove.
5345
14a9c8df
PE
5346 * commands.h (last_point_position, last_point_position_buffer):
5347 (last_point_position_window): Remove decls.
5348 * keyboard.c: Make these variables static.
5349
04f2d78b
CB
5350 * coding.h (coding, code_convert_region, encode_coding_gap):
5351 Remove decls.
74ab6df5
PE
5352 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5353 (iso_code_class, detect_coding, code_convert_region): Now static.
5354 (encode_coding_gap): Remove; unused.
5355
38dfbee1
PE
5356 * chartab.c (chartab_chars, chartab_bits): Now static.
5357
a2cb4e63
PE
5358 * charset.h (charset_iso_8859_1): Remove decl.
5359 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5360 Now static.
5361
127198fd
PE
5362 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5363 * ccl.c (Vccl_program_table): Now static.
5364 (check_ccl_update): Remove; unused.
5365
d85b608f
PE
5366 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5367 * category.h: ... from here.
5368 * category.c (check_category_table, set_category_set): Now static.
5369
31cd66f3
PE
5370 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5371 * lisp.h: Remove these decls.
5372
c358e587
PE
5373 * buffer.c (buffer_count): Remove unused var.
5374
e78aecca
PE
5375 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5376 so that it's not optimized away.
5377 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5378 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5379 exported only to the debugger.
5380
e192d7d3 5381 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5382 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5383
92470028
PE
5384 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5385 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5386 was inaccessible from Lisp.
5387 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5388 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5389
244ed907
PE
5390 alloc.c: Import and export fewer symbols, and remove unused items.
5391 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5392 is defined.
5393 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5394 it's not optimized away by whole-program optimization.
5395 (message_enable_multibyte, free_misc): Remove.
5396 (catchlist, handlerlist, mark_backtrace):
5397 Declare only if BYTE_MARK_STACK.
5398 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5399 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5400 (message_enable_multibyte): Remove decl.
5401 (free_misc, interval_free_list, float_block, float_block_index):
5402 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5403 (cons_free_list, last_marked_index):
5404 Now static.
5405 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5406 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5407 (mark_backtrace): Define only if BYTE_MARK_STACK.
5408 * xdisp.c (message_enable_multibyte): Now static.
5409
61c2b50e 5410 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5411 This makes it easier for human readers (and static analyzers)
5412 to see whether these variables are used from other modules.
5413 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5414 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5415 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5416 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5417 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5418 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5419 * xmenu.c, xselect.c:
5420 Declare Q* vars static if they are not used in other modules.
5421 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5422 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5423 Remove decls of unexported vars.
5424 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5425
95c82688
PE
5426 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5427
16a97296
PE
5428 Make Emacs functions such as Fatom 'static' by default.
5429 This makes it easier for human readers (and static analyzers)
5430 to see whether these functions can be called from other modules.
5431 DEFUN now defines a static function. To make the function external
5432 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5433 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5434 (Finit_image_library):
16a97296
PE
5435 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5436 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5437 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5438 Remove decls, since these functions are now static.
5439 (Funintern, Fget_internal_run_time): New decls, since these functions
5440 were already external.
95c82688 5441
16a97296
PE
5442 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5443 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5444 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5445 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5446 * keyboard.c, keymap.c, lread.c:
5447 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5448 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5449 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5450 Mark functions with DEFUE instead of DEFUN,
5451 if they are used in other modules.
5452 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5453 decls for now-static functions.
5454 * buffer.h (Fdelete_overlay): Remove decl.
5455 * callproc.c (Fgetenv_internal): Mark as internal.
5456 * composite.c (Fremove_list_of_text_properties): Remove decl.
5457 (Fcomposition_get_gstring): New forward static decl.
5458 * composite.h (Fcomposite_get_gstring): Remove decl.
5459 * dired.c (Ffile_attributes): New forward static decl.
5460 * doc.c (Fdocumntation_property): New forward static decl.
5461 * eval.c (Ffetch_bytecode): New forward static decl.
5462 (Funintern): Remove extern decl; now in .h file where it belongs.
5463 * fileio.c (Fmake_symbolic_link): New forward static decl.
5464 * image.c (Finit_image_library): New forward static decl.
5465 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5466 * intervals.h (Fprevious_property_change):
5467 (Fremove_list_of_text_properties): Remove decls.
5468 * keyboard.c (Fthis_command_keys): Remove decl.
5469 (Fcommand_execute): New forward static decl.
5470 * keymap.c (Flookup_key): New forward static decl.
5471 (Fcopy_keymap): Now static.
5472 * keymap.h (Flookup_key): Remove decl.
5473 * process.c (Fget_process): New forward static decl.
5474 (Fprocess_datagram_address): Mark as internal.
5475 * syntax.c (Fsyntax_table_p): New forward static decl.
5476 (skip_chars): Remove duplicate decl.
5477 * textprop.c (Fprevious_property_change): New forward static decl.
5478 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5479 Now internal.
5480 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5481 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5482
785bbd42
PE
5483 * editfns.c (Fformat): Remove unreachable code.
5484
8b913b57
AS
54852011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5486
5487 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5488 change. (Bug#8496)
5489
a6744a35
EZ
54902011-04-13 Eli Zaretskii <eliz@gnu.org>
5491
5492 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5493 when at ZV. (Bug#8487)
5494
e7974947
AS
54952011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5496
baad03f0
AS
5497 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5498 (Bug#8437)
5499 * keyboard.c (parse_tool_bar_item): Likewise.
5500 * sound.c (sound_cleanup, alsa_close): Likewise.
5501 * termcap.c (tgetent): Likewise.
5502 * xfns.c (x_default_font_parameter): Likewise.
5503 * xsettings.c (read_and_apply_settings): Likewise.
5504
e7974947
AS
5505 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5506 (overrun_check_free): Protoize.
5507
28272684
PE
55082011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5509
5510 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5511 since callers should never pass a negative size.
5512 Change the signature to match that of plain 'read' and 'write'; see
5513 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5514 * lisp.h: Update prototypes of emacs_write and emacs_read.
5515
11997c76
EZ
55162011-04-11 Eli Zaretskii <eliz@gnu.org>
5517
5518 * xdisp.c (redisplay_window): Don't try to determine the character
5519 position of the scroll margin if the window start point w->startp
e896f03c 5520 is outside the buffer's accessible region. (Bug#8468)
11997c76 5521
8a2cbd72
EZ
55222011-04-10 Eli Zaretskii <eliz@gnu.org>
5523
5524 Fix write-region and its subroutines for buffers > 2GB.
5525 * fileio.c (a_write, e_write): Modify declaration of arguments and
5526 local variables to support buffers larger than 2GB.
5527 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5528
5529 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5530 argument, local variables, and return value.
5531
5532 * lisp.h: Update prototypes of emacs_write and emacs_read.
5533
5534 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5535
4073e537 55362011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5537
1ebfdcb6
PE
5538 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5539
b2ded58d
PE
5540 Fix more problems found by GCC 4.6.0's static checks.
5541
7d66342c
PE
5542 * xdisp.c (vmessage): Use a better test for character truncation.
5543
bbf47d44
PE
5544 * charset.c (load_charset_map): <, not <=, for optimization,
5545 and to avoid potential problems with integer overflow.
9248994d 5546 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5547 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5548 * editfns.c (Fformat): Likewise.
1e69125e 5549 * syntax.c (skip_chars): Likewise.
3befa583 5550
e3019616
PE
5551 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5552 This also lets GCC 4.6.0 generate slightly better loop code.
5553
becfa255
PE
5554 * callint.c (Fcall_interactively): <, not <=, for optimization.
5555 (Fcall_interactively): Count the number of arguments produced,
5556 not the number of arguments given. This is simpler and lets GCC
5557 4.6.0 generate slightly better code.
5558
dae0cd48
PE
5559 * ftfont.c: Distingish more carefully between FcChar8 and char.
5560 The previous code passed unsigned char * to a functions like
5561 strlen and xstrcasecmp that expect char *, which does not
5562 conform to the C standard.
5563 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5564 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5565 char * when the C standard requires it.
5566
76032d70
PE
5567 * keyboard.c (read_char): Remove unused var.
5568
eb3f1cc8
PE
5569 * eval.c: Port to Windows vsnprintf (Bug#8435).
5570 Include <limits.h>.
5571 (SIZE_MAX): Define if the headers do not.
5572 (verror): Do not give up if vsnprintf returns a negative count.
5573 Instead, grow the buffer. This ports to Windows vsnprintf, which
5574 does not conform to C99. Problem reported by Eli Zaretskii.
5575 Also, simplify the allocation scheme, by avoiding the need for
5576 calling realloc, and removing the ALLOCATED variable.
5577
70476b54
PE
5578 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5579
12020a9e
PE
5580 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5581 But keep the doprint source code for now, as we might revamp it
5582 and use it again (Bug#8435).
ea6c7ae6
PE
5583 * lisp.h (doprnt): Remove.
5584 * Makefile.in (base_obj): Remove doprnt.o.
5585 * deps.mk (doprnt.o): Remove.
5586
5fdb398c
PE
5587 error: Print 32- and 64-bit integers portably (Bug#8435).
5588 Without this change, on typical 64-bit hosts error ("...%d...", N)
5589 was used to print both 32- and 64-bit integers N, which relied on
5590 undefined behavior.
5591 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5592 New macro.
5593 * lisp.h (error, verror): Mark as printf-like functions.
5594 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5595 Report overflow in size calculations when allocating printf buffer.
5596 Do not truncate output string at its first null byte.
5597 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5598 Truncate the output at a character boundary, since vsnprintf does not
5599 do that.
5600 * charset.c (check_iso_charset_parameter): Convert internal
5601 character to string before calling 'error', since %c now has the
5602 printf meaning.
5603 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5604 overflow when computing char to be passed to 'error'. Do not
5605 pass Lisp_Object to 'error'; pass the integer instead.
5606 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5607 formatted with plain %d.
5608
b189fa66
PE
5609 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5610
bff87ef0
PE
5611 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5612
7e2cac20
PE
5613 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5614
ce4d90b5
PE
5615 * xterm.c (x_catch_errors): Remove duplicate declaration.
5616
266c9547
PE
5617 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5618
79c49ad2
PE
5619 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5620
368f4090
JM
56212011-04-10 Jim Meyering <meyering@redhat.com>
5622
5623 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5624 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5625 return ssize_t not "int", and use size_t as the buffer length.
5626 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5627 * gnutls.h: Update declarations.
5628 * process.c (read_process_output): Use ssize_t, to match.
5629 (send_process): Likewise.
5630
a32d4040
CY
56312011-04-09 Chong Yidong <cyd@stupidchicken.com>
5632
5633 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5634
8546720e 56352011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5636
04f2d78b
CB
5637 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5638 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5639
8546720e
GM
5640 * xterm.c (handle_one_xevent):
5641 * xmenu.c (create_and_show_popup_menu):
5642 * xselect.c (x_decline_selection_request)
5643 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5644
0a2f5c1a 56452011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5646
5647 Fix some uses of `int' instead of EMACS_INT.
5648 * search.c (string_match_1, fast_string_match)
5649 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5650 (scan_buffer, find_next_newline_no_quit)
5651 (find_before_next_newline, search_command, Freplace_match)
5652 (Fmatch_data): Make some `int' variables be EMACS_INT.
5653
5654 * xdisp.c (display_count_lines): 3rd argument and return value now
5655 EMACS_INT. All callers changed.
5656 (pint2hrstr): Last argument is now EMACS_INT.
5657
5658 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5659 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5660 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5661 (decode_coding_utf_16, decode_coding_emacs_mule)
5662 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5663 (decode_coding_ccl, decode_coding_charset)
5664 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5665 (decode_coding_iso_2022, decode_coding_emacs_mule)
5666 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5667 <char_offset, last_offset>: Declare EMACS_INT.
5668 (encode_coding_utf_8, encode_coding_utf_16)
5669 (encode_coding_emacs_mule, encode_invocation_designation)
5670 (encode_designation_at_bol, encode_coding_iso_2022)
5671 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5672 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5673 Declare EMACS_INT.
5674 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5675 (encode_invocation_designation): Last argument P_NCHARS is now
5676 EMACS_INT.
5677 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5678 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5679
5680 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5681 All users changed.
5682
5683 * ccl.c (Fccl_execute_on_string): Declare some variables
5684 EMACS_INT.
5685
8546720e 56862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5687
5688 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5689
4e19a977
CS
56902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5691
5692 * process.c (Fformat_network_address): Doc fix.
5693
87302331
R
56942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5695
5696 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5697
cbb59342
CY
56982011-04-08 Chong Yidong <cyd@stupidchicken.com>
5699
5700 * keyboard.c (read_char): Call Lisp function help-form-show,
5701 instead of using internal_with_output_to_temp_buffer.
5702 (Qhelp_form_show): New var.
e0d38eeb 5703 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5704
5705 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5706
5707 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5708
e67a13ab
CY
57092011-04-06 Chong Yidong <cyd@stupidchicken.com>
5710
04f2d78b
CB
5711 * process.c (Flist_processes): Remove to Lisp.
5712 (list_processes_1): Delete.
e67a13ab 5713
973f782d
EZ
57142011-04-06 Eli Zaretskii <eliz@gnu.org>
5715
7c106b1e
EZ
5716 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5717
973f782d
EZ
5718 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5719
41cf7d1a 57202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5721
ca23cc88
PE
5722 Fix more problems found by GCC 4.6.0's static checks.
5723
f390e2d5
PE
5724 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5725
42eea0d0
PE
5726 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5727
b69769da 5728 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5729
f9541e84
PE
5730 * xdisp.c (vmessage): Mark as a printf-like function.
5731
13841b55
PE
5732 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5733
c136c10f
PE
5734 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5735
5e2d4a30
PE
5736 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5737 printf-like functions.
5738 (tiff_load): Add casts to remove these marks before passing them
5739 to system-supplied API.
5740
583f48b9
PE
5741 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5742
b25d760e
PE
5743 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5744 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5745 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5746 directly, rather than having caller test rule sign. This avoids
5747 some unnecessary tests.
5748 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5749 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5750 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5751
bc7b6697 5752 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5753 (xfont_open): Avoid unnecessary tests.
bc7b6697 5754
27ccc379
PE
5755 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5756
dcd5c89a
PE
5757 * composite.h, composite.c (composition_gstring_put_cache):
5758 Use EMACS_INT, not int, for length.
5759
b13a45c6
PE
5760 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5761 breaking out part of COMPOSITION_DECODE_RULE.
5762 (COMPOSITION_DECODE_RULE): Use it.
5763 * composite.c (get_composition_id): Remove unused local vars,
5764 by using the new macro.
5765
1e792e4d
PE
5766 * textprop.c (set_text_properties_1): Change while to do-while,
5767 since the condition is always true at first.
5768
dc6c6455 5769 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5770 (interval_deletion_adjustment): Return unsigned value.
5771 All uses changed.
dc6c6455 5772
aba7731a
PE
5773 * process.c (list_processes_1, create_pty, read_process_output):
5774 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5775 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5776 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5777 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5778 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5779
fdfc4bf3
PE
5780 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5781
fca8fe46 5782 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5783 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5784
06a0259a 5785 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5786 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5787 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5788
e7b9e80f
PE
5789 * print.c (print_error_message): Avoid int overflow.
5790
56201685
PE
5791 * font.c (font_list_entities): Redo for clarity,
5792 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5793
78834453 5794 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5795 (font_score): Avoid potential overflow in diff calculation.
78834453 5796
0bc0b309 5797 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5798 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5799
e610eaca
PE
5800 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5801
b895abce
PE
5802 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5803 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5804 can always succeed if overflow has undefined behavior.
5805
1f1d9321 5806 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5807 (wordify): Omit three unnecessary tests.
1f1d9321 5808
c59478bc
PE
5809 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5810 All callers changed. This avoids the need for an unused var.
5811
79b73827
PE
5812 * casefiddle.c (casify_region): Remove var that is set but not used.
5813
a4db5dfe
PE
5814 * dired.c (file_name_completion): Remove var that is set but not used.
5815
43aae36e
PE
5816 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5817
2a47c44d 5818 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5819 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5820
a37c69bf
PE
5821 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5822 Check for integer overflow on size calculations.
5823
328ab8e7
PE
5824 * buffer.c (Fprevious_overlay_change): Remove var that is set
5825 but not used.
5826
e5a2a5cb
PE
5827 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5828 Remove vars that are set but not used.
8d84a6eb 5829 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5830 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5831
a60e5f68
PE
5832 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5833
f661cb61 5834 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5835 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5836
f0397f5a
PE
5837 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5838 that are set but not used.
5839
8664db06 5840 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5841 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5842
6abdaa4a
PE
5843 * xselect.c (x_get_local_selection, x_handle_property_notify):
5844 Remove vars that are set but not used.
5845
0ce7538d 5846 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5847 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5848
9ae848fc
PE
5849 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5850 Remove var that is set but not used.
0b918413
PE
5851 (scroll_bar_windows_size): Now size_t, not int.
5852 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5853 Check for overflow.
9ae848fc 5854
a5a62657
PE
5855 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5856 (map_tty_color) [!defined MSDOS]: Likewise.
5857
5c5cdd39
PE
5858 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5859
66ebf983
PE
5860 * coding.c: Remove vars that are set but not used.
5861 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5862 All callers changed.
5863 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5864 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5865 (decode_coding_charset): Remove vars that are set but not used.
5866
1be4d761
PE
5867 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5868 that is set but not used.
5869
47553fa8
PE
5870 * print.c (print_object): Remove var that is set but not used.
5871
1f7196bf 5872 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5873 The gnulib version avoids calling malloc in the usual case,
5874 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5875 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5876 * filelock.c (current_lock_owner): Likewise.
5877 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5878 * sysdep.c: Include allocator.h, careadlinkat.h.
5879 (emacs_no_realloc_allocator): New static constant.
5880 (emacs_readlink): New function.
fdb61804
PE
5881 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5882 ../lib/careadlinkat.h.
d1fdcab7 5883
f84c17c7
SM
58842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5885
5886 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5887 first non-nil return value).
5888
ef3862ad
JD
58892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5890
5891 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5892 if not defined (Bug#8403).
5893
376a7006
JB
58942011-04-02 Juanma Barranquero <lekktu@gmail.com>
5895
5896 * xdisp.c (display_count_lines): Remove parameter `start',
5897 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5898 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5899 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5900 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5901 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5902 and thereabouts. All callers changed.
5903 (get_per_char_metric): Remove parameter `f', unused since
5904 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5905
6ca3801d
JM
59062011-04-02 Jim Meyering <meyering@redhat.com>
5907
5908 do not dereference NULL upon failed strdup
5909 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5910 (ns_get_family): Likewise.
5911
d8e2b5ba
JB
59122011-04-02 Juanma Barranquero <lekktu@gmail.com>
5913
5914 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5915
8c74fcbd
JD
59162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5917
5918 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5919 later (Bug#8403).
5920
7200d79c
SM
59212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5922
03408648 5923 Add lexical binding.
7200d79c 5924
03408648
SM
5925 * window.c (Ftemp_output_buffer_show): New fun.
5926 (Fsave_window_excursion):
5927 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5928
5929 * lread.c (lisp_file_lexically_bound_p): New function.
5930 (Fload): Bind Qlexical_binding.
5931 (readevalloop): Remove `evalfun' arg.
5932 Bind Qinternal_interpreter_environment.
5933 (Feval_buffer): Bind Qlexical_binding.
5934 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5935 Mark as dynamic.
5936 (syms_of_lread): Declare `lexical-binding'.
5937
5938 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5939
5940 * keyboard.c (eval_dyn): New fun.
5941 (menu_item_eval_property): Use it.
ca105506
SM
5942
5943 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5944
03408648
SM
5945 * fns.c (concat, mapcar1): Accept byte-code-functions.
5946
5947 * eval.c (Fsetq): Handle lexical vars.
5948 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5949 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5950 (FletX, Flet): Obey lexical binding.
5951 (Fcommandp): Handle closures.
5952 (Feval): New `lexical' arg.
5953 (eval_sub): New function extracted from Feval. Use it almost
5954 everywhere where Feval was used. Look up vars in lexical env.
5955 Handle closures.
5956 (Ffunctionp): Move from subr.el.
5957 (Ffuncall): Handle closures.
5958 (apply_lambda): Remove `eval_flags'.
5959 (funcall_lambda): Handle closures and new byte-code-functions.
5960 (Fspecial_variable_p): New function.
5961 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5962 but without exporting it to Lisp.
23aba0ea 5963
23aba0ea 5964 * doc.c (Fdocumentation, store_function_docstring):
03408648 5965 * data.c (Finteractive_form): Handle closures.
23aba0ea 5966
03408648
SM
5967 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5968 interactive spec.
ba83908c 5969
04f2d78b
CB
5970 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5971 New byte-codes.
03408648
SM
5972 (exec_byte_code): New function extracted from Fbyte_code to handle new
5973 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5974
03408648 5975 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5976
03408648 5977 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5978
e2abce01
JB
59792011-03-31 Juanma Barranquero <lekktu@gmail.com>
5980
5981 * xdisp.c (redisplay_internal): Fix prototype.
5982
63696a73 59832011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5984
63696a73 5985 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5986 (try_scrolling): Use it when setting scroll_limit.
5987 Limit scrolling to 100 screen lines.
63696a73
EZ
5988 (redisplay_window): Even when falling back on "recentering",
5989 position point in the window according to scroll-conservatively,
5990 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5991
5992 (try_scrolling): When point is above the window, allow searching
5993 as far as scroll_max, or one screenful, to compute vertical
5994 distance from PT to the scroll margin position. This prevents
5995 try_scrolling from unnecessarily failing when
5996 scroll-conservatively is set to a value slightly larger than the
5997 window height. Clean up the case of PT below the margin at bottom
5998 of window: scroll_max can no longer be INT_MAX. When aggressive
5999 scrolling is in use, don't let point enter the opposite scroll
6000 margin as result of the scroll.
6001 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6002 threshold of 100 lines for never-recentering scrolling.
6003
e4cc2dfc
JB
60042011-03-31 Juanma Barranquero <lekktu@gmail.com>
6005
6006 * dispextern.h (move_it_by_lines):
6007 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6008 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6009 (message_log_check_duplicate): Remove parameters `prev_bol' and
6010 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6011 (redisplay_internal): Remove parameter `preserve_echo_area',
6012 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6013
6014 * indent.c (Fvertical_motion):
6015 * window.c (window_scroll_pixel_based, Frecenter):
6016 Don't pass `need_y_p' to `move_it_by_lines'.
6017
1c470562
SM
60182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6019
44f230aa
SM
6020 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6021 steal a few bits to be more compact.
6022 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6023 Remove unneeded casts.
6024
1c470562
SM
6025 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6026
888adce9
ZK
60272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6028
6029 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6030 binding" message (bug#7967).
6031
f838ed7b
PE
60322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6033
77861b95
PE
6034 Fix more problems found by GCC 4.6.0's static checks.
6035
de6dbc14
PE
6036 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6037 Remove unused local var.
6038
f838ed7b
PE
6039 * editfns.c (Fmessage_box): Remove unused local var.
6040
792c7b2b
PE
6041 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6042 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6043 Omit unused local vars.
c499e557 6044 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6045 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6046 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6047 Omit unused local var.
6048
ba0165e1
PE
6049 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6050 Don't assume string length fits in int.
32ad8845 6051 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6052 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6053
3c59b4c9
PE
6054 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6055 instead of alloca (Bug#8344).
6056
a3eed478 6057 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6058 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6059
eb4d412d
PE
6060 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6061
1658b401
PE
6062 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6063 concerns.
6064
6065 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6066
6067 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6068
9a2c6e05
PE
6069 * keyboard.c (syms_of_keyboard): Use the same style as later
6070 in this function when indexing through an array. This also
6071 works around GCC bug 48267.
6072
03d0a109
PE
6073 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6074
44f730c8
PE
6075 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6076
fe75f926
PE
6077 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6078 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6079
ffa8c828
PE
6080 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6081 This avoids undefined behavior on integer overflow, and is a bit
6082 more convenient anyway since it is compared to a size_t variable.
6083
c5101a77
PE
6084 Variadic C functions now count arguments with size_t, not int.
6085 This avoids an unnecessary limitation on 64-bit machines, which
6086 caused (substring ...) to crash on large vectors (Bug#8344).
6087 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6088 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6089 All variadic functions and their callers changed accordingly.
c5101a77
PE
6090 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6091 * data.c (arith_driver, float_arith_driver): Likewise.
6092 * editfns.c (general_insert_function): Likewise.
6093 * eval.c (struct backtrace.nargs, interactive_p)
6094 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6095 (funcall_lambda, mark_backtrace): Likewise.
6096 * fns.c (concat): Likewise.
6097 * frame.c (x_set_frame_parameters): Likewise.
6098 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6099 0 if not found, not -1. All callers changed.
6100
dd3f25f7
PE
6101 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6102 (stack_copy_size): Now size_t, not int.
6103 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6104
461c2ab9
JB
61052011-03-28 Juanma Barranquero <lekktu@gmail.com>
6106
6107 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6108 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6109 All callers changed.
6110
6111 * lisp.h (multibyte_char_to_unibyte):
6112 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6113 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6114 * character.h (CHAR_TO_BYTE8):
6115 * cmds.c (internal_self_insert):
6116 * editfns.c (general_insert_function):
6117 * keymap.c (push_key_description):
6118 * search.c (Freplace_match):
6119 * xdisp.c (message_dolog, set_message_1): All callers changed.
6120
f6d62986
SM
61212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6122
6123 * keyboard.c (safe_run_hook_funcall): New function.
6124 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6125 don't set the hook to nil, but remove the offending function instead.
6126 (Qcommand_hook_internal): Remove, unused.
6127 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6128 Vcommand_hook_internal.
6129
6130 * eval.c (enum run_hooks_condition): Remove.
6131 (funcall_nil, funcall_not): New functions.
6132 (run_hook_with_args): Call each function through a `funcall' argument.
6133 Remove `cond' argument, now redundant.
6134 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6135 (Frun_hook_with_args_until_failure): Adjust accordingly.
6136 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6137
1db5b1ad
JB
61382011-03-28 Juanma Barranquero <lekktu@gmail.com>
6139
6140 * dispextern.h (string_buffer_position): Remove declaration.
6141
6142 * print.c (strout): Remove parameter `multibyte', unused since
6143 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6144
6145 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6146 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6147 All callers changed.
6148
6149 * w32.c (_wsa_errlist): Use braces for struct initializers.
6150
6151 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6152 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6153 All callers changed.
6154 (string_buffer_position): Likewise. Also, make static (it's never
6155 used outside xdisp.c).
6156 (cursor_row_p): Remove parameter `w', unused since
6157 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6158 (decode_mode_spec): Remove parameter `precision', introduced during
6159 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6160 All callers changed.
6161
5ffb62aa
JD
61622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6163
6164 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6165
461c2ab9 61662011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6167
6168 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6169 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6170 (ns_update_auto_hide_menu_bar): New functions.
6171 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6172 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6173 ns_constrain_all_frames.
6174 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6175 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6176
5c380ffb
JD
61772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6178
6179 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6180
9af30bdf
GM
61812011-03-27 Glenn Morris <rgm@gnu.org>
6182
6183 * syssignal.h: Replace RETSIGTYPE with void.
6184 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6185 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6186 Replace SIGTYPE with void everywhere.
6187 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6188 * s/template.h (SIGTYPE): Remove commented out definition.
6189
e2abce01
JB
61902011-03-26 Eli Zaretskii <eliz@gnu.org>
6191
6192 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6193 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6194
f868cd8a
JB
61952011-03-26 Juanma Barranquero <lekktu@gmail.com>
6196
59eb0929
JB
6197 * w32.c (read_unc_volume): Use parameter `henum', instead of
6198 global variable `wget_enum_handle'.
6199
6200 * keymap.c (describe_vector): Remove parameters `indices' and
6201 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6202 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6203
f868cd8a
JB
6204 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6205
6206 * keyboard.c (timer_check): Remove parameter `do_it_now',
6207 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6208 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6209 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6210
6211 * keyboard.c (read_char):
6212 * w32menu.c (w32_menu_display_help):
6213 * xmenu.c (show_help_event, menu_help_callback):
6214 Adjust calls to `show_help_echo'.
6215
6216 * gtkutil.c (xg_maybe_add_timer):
6217 * keyboard.c (readable_events):
6218 * process.c (wait_reading_process_output):
6219 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6220
6221 * insdel.c (adjust_markers_gap_motion):
6222 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6223 (gap_left, gap_right): Don't call it.
6224
2ecf6fdb
CY
62252011-03-25 Chong Yidong <cyd@stupidchicken.com>
6226
6227 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6228 incurred during fontification.
6229
6b1f9ba4
JB
62302011-03-25 Juanma Barranquero <lekktu@gmail.com>
6231
6232 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6233 (DEFVAR_PER_BUFFER): Don't pass it.
6234
6235 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6236 (scrolling_window): Don't pass it.
6237
0f4a96b5
JB
62382011-03-25 Juanma Barranquero <lekktu@gmail.com>
6239
6240 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6241
6242 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6243 and `suffix'.
6244 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6245 of variables specific to SELinux and computation of `encoded_absname'.
6246
6247 * image.c (XPutPixel): Remove unused variable `height'.
6248
6249 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6250
6251 * unexw32.c (get_section_info): Remove unused variable `section'.
6252
6253 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6254 (system_process_attributes): Remove unused variable `sess'.
6255 (sys_read): Remove unused variable `err'.
6256
6257 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6258 (w32_wnd_proc): Remove unused variable `isdead'.
6259 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6260 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6261 (x_create_tip_frame): Remove unused variable `tem'.
6262
6263 * w32inevt.c (w32_console_read_socket):
6264 Remove unused variable `no_events'.
6265
6266 * w32term.c (x_draw_composite_glyph_string_foreground):
6267 Remove unused variable `width'.
6268
1149507c
JB
62692011-03-24 Juanma Barranquero <lekktu@gmail.com>
6270
6271 * w32term.c (x_set_glyph_string_clipping):
6272 Don't pass uninitialized region to CombineRgn.
6273
9c88f339
JB
62742011-03-23 Juanma Barranquero <lekktu@gmail.com>
6275
6276 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6277 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6278 (Fx_close_connection): Remove unused variable `i'.
6279
6280 * w32font.c (w32font_draw): Return number of glyphs.
6281 (w32font_open_internal): Remove unused variable `i'.
6282 (w32font_driver): Add missing initializer.
6283
6284 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6285 (fill_in_menu): Remove unused variable `items_added'.
6286
6287 * w32term.c (last_mouse_press_frame): Remove static global variable.
6288 (w32_clip_to_row): Remove unused variable `f'.
6289 (x_delete_terminal): Remove unused variable `i'.
6290
6291 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6292 (NOTHING): Remove unused static global variable.
6293 (uniscribe_check_otf): Remove unused variable `table'.
6294 (uniscribe_font_driver): Add missing initializers.
6295
dee091a3
JD
62962011-03-23 Julien Danjou <julien@danjou.info>
6297
6298 * term.c (Fsuspend_tty, Fresume_tty):
6299 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6300 * window.c (temp_output_buffer_show):
6301 * insdel.c (signal_before_change):
6302 * frame.c (Fhandle_switch_frame):
6303 * fileio.c (Fdo_auto_save):
6304 * emacs.c (Fkill_emacs):
6305 * editfns.c (save_excursion_restore):
6306 * cmds.c (internal_self_insert):
6307 * callint.c (Fcall_interactively):
6308 * buffer.c (Fkill_all_local_variables):
6309 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6310 Use Frun_hooks.
0f4a96b5 6311 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6312 unconditionnaly since it does the check itself.
6313
2c520ab5 63142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6315
c9c49752
PE
6316 Fix more problems found by GCC 4.5.2's static checks.
6317
8abc3f12
PE
6318 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6319 the first time through the loop, since we know p0 < p1 then.
6320 This also avoids a gcc -Wstrict-overflow warning.
6321
a2d26660
PE
6322 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6323 leading to a memory leak, possible in functions like
6324 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6325 of objects (Bug#8318).
a2d26660 6326
916c72e9
PE
6327 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6328 that could (at least in theory) be that large.
6329
19ab8a18
PE
6330 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6331 This is less likely to overflow, and avoids undefined behavior if
6332 overflow does occur. All callers changed. Use strtoul to scan
6333 for the unsigned long integer.
b7cbbd6f
PE
6334 (pint2hrstr): Simplify and tune code slightly.
6335 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6336
f0641eff
PE
6337 * scroll.c (do_scrolling): Work around GCC bug 48228.
6338 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6339
7f650bb9
PE
6340 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6341 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6342 (validate_x_resource_name): Simplify count usage.
6343 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6344
37dd57d1
PE
6345 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6346 fail (Bug#8306).
81e56e61 6347
699979fc 6348 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6349
401bf9b4
PE
6350 * process.c (Fmake_network_process): Use socklen_t, not int,
6351 where POSIX says socklen_t is required in portable programs.
6352 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6353 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6354 (Fmake_network_process, server_accept_connection):
6355 (wait_reading_process_output, read_process_output):
6356 Likewise.
6357
b93aacde
PE
6358 * process.c: Rename or move locals to avoid shadowing.
6359 (list_processes_1, Fmake_network_process):
6360 (read_process_output_error_handler, exec_sentinel_error_handler):
6361 Rename or move locals.
4dc343ee 6362 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6363 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6364 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6365 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6366 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6367
af8a867c 6368 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6369 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6370 Include tparam.h instead, since it declares them.
af8a867c
PE
6371 * cm.h (PC): Remove extern decl; tparam.h now does this.
6372 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6373 * terminfo.c: Include tparam.h, to check interfaces.
6374 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6375 (tparam): Adjust signature to match interface in tparam.h;
6376 this removes some undefined behavior. Check that outstring and len
6377 are zero, which they always are with Emacs.
6378 * tparam.h (PC, BC, UP): New extern decls.
6379
0248044d 6380 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6381 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6382
8ff096c1 6383 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6384 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6385 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6386 (ftfont_list): Remove unused local.
49eaafba
PE
6387 (get_adstyle_property, ftfont_pattern_entity):
6388 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6389 Rename locals to avoid shadowing.
8ff096c1 6390
e2be39f6
PE
6391 * xfont.c (xfont_list_family): Mark var as initialized.
6392
c9735e30
PE
6393 * xml.c (make_dom): Now static.
6394
8f5201ae
PE
6395 * composite.c (composition_compute_stop_pos): Rename local to
6396 avoid shadowing.
b246f932
PE
6397 (composition_reseat_it): Remove unused locals.
6398 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6399 (composition_update_it): Mark var as initialized.
11b61122
PE
6400 (find_automatic_composition): Mark vars as initialized,
6401 with a FIXME (Bug#8290).
8f5201ae 6402
760fbc2c
PE
6403 character.h: Rename locals to avoid shadowing.
6404 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6405 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6406 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6407 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6408 to avoid shadowing.
6409
ff08eb85
PE
6410 * textprop.c (property_change_between_p): Remove; unused.
6411
fc7bf025
PE
6412 * intervals.c (interval_start_pos): Now static.
6413
235d7abc
PE
6414 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6415
44f230aa
SM
6416 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6417 Rename locals to avoid shadowing.
3e7d6594 6418
50060332
PE
6419 * sound.c (wav_play, au_play, Fplay_sound_internal):
6420 Fix pointer signedness.
d01f234b 6421 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6422 (wav_play): Initialize a variable to 0, to prevent undefined
6423 behavior (Bug#8278).
50060332 6424
c4fc4e30
PE
6425 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6426
918436ed
PE
6427 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6428
c939f91b
PE
6429 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6430 clobbering (Bug#8298).
b9c7f648
PE
6431 * sysdep.c (sys_subshell): Likewise.
6432 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6433
6bd8c144
PE
6434 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6435 This should get cleaned up, so that child_setup has the
6436 same signature on all platforms.
6437
7710357c 6438 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6439 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6440
c59da222
CY
64412011-03-22 Chong Yidong <cyd@stupidchicken.com>
6442
6443 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6444 not to be necessary, and produces flickering.
6445
66b87493
GM
64462011-03-20 Glenn Morris <rgm@gnu.org>
6447
6448 * config.in: Remove file.
6449
45b6f6d5
JB
64502011-03-20 Juanma Barranquero <lekktu@gmail.com>
6451
6452 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6453 are now in src/globals.h.
6454 (syms_of_minibuf): Remove spurious & from previous change.
6455
3ec03f7e
LL
64562011-03-20 Leo <sdl.web@gmail.com>
6457
6458 * minibuf.c (completing-read-function): New variable.
6459 (completing-read-default): Rename from completing-read.
6460 (completing-read): Call completing-read-function.
6461
b14e3e21
CY
64622011-03-19 Juanma Barranquero <lekktu@gmail.com>
6463
6464 * xfaces.c (Fx_load_color_file):
6465 Read color file from absolute filename (bug#8250).
6466
f2b726e6
JB
64672011-03-19 Juanma Barranquero <lekktu@gmail.com>
6468
6469 * makefile.w32-in: Update dependencies.
6470
09f6ff02
EZ
64712011-03-17 Eli Zaretskii <eliz@gnu.org>
6472
6473 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6474
29a6015a
PE
64752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6476
a3a6c54e
PE
6477 Fix more problems found by GCC 4.5.2's static checks.
6478
b766f867
PE
6479 * process.c (make_serial_process_unwind, send_process_trap):
6480 (sigchld_handler): Now static.
6481
be02381c
PE
6482 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6483 That way, the code declares only the vars that it needs.
6484 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6485 * s/cygwin.h (PTY_ITERATION): Likewise.
6486 * s/darwin.h (PTY_ITERATION): Likewise.
6487 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6488
57048744
PE
6489 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6490 * process.c (allocate_pty): Don't declare stb unless it's needed.
6491
7914961c 6492 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6493 (CONSTANTLIM): Remove; unused.
6494 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6495 Define only if needed.
7914961c 6496
b3967b18
PE
6497 * unexelf.c (unexec): Name an expression,
6498 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6499 Use a different way to cause a compilation error if anyone uses
6500 n rather than nn, a way that does not involve shadowing.
73366a00 6501 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6502
29a6015a
PE
6503 * deps.mk (unexalpha.o): Remove; unused.
6504
43cfc33e 6505 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6506 * unexec.h: New file.
ce701a33
PE
6507 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6508 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6509 Depend on unexec.h.
6510 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6511 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6512 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6513 Change as necessary to match prototype in unexec.h.
ce701a33 6514
01f44d5a
PE
6515 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6516 shadowing.
4f63c6bb 6517 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6518
a6670b0b
PE
6519 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6520 Rename locals to avoid shadowing.
6521
cef2010d 6522 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6523 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6524
d4d7173a
PE
6525 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6526
f08b802a
PE
6527 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6528 warning when compiling print.c.
6529
3ddb0639
PE
6530 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6531 instead of using an uninitialized var.
5ad03b97 6532 (font_sort_entities): Mark var as initialized.
3ddb0639 6533
170a2692
PE
6534 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6535
e663c700
PE
6536 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6537 pointers to constants.
89bc529a 6538 (font_parse_fcname): Remove unused vars.
7b81e2d0 6539 (font_delete_unmatched): Now static.
ea838e10 6540 (font_get_spec): Remove; unused.
13a547c6
PE
6541 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6542 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6543 Rename or move locals to avoid shadowing.
e663c700 6544
2a80c887 6545 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6546 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6547
1384fa33 6548 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6549 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6550
8b2c52e9
PE
6551 * alloc.c (mark_backtrace): Move decl from here ...
6552 * lisp.h: ... to here, so that it can be checked.
6553
475545b5 6554 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6555 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6556 (lisp_indirect_variable): Name an expression,
6557 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6558 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6559
b1349114 6560 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6561 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6562 Use const pointer when appropriate.
b1349114 6563
a2928364
PE
6564 * lisp.h (get_system_name, get_operating_system_release):
6565 Move decls here, to check interfaces.
6566 * process.c (get_operating_system_release): Move decl to lisp.h.
6567 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6568 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6569 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6570 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6571 (Fformat_time_string, Fencode_time, Finsert_char):
6572 (Ftranslate_region_internal, Fformat):
6573 Rename or remove local vars to avoid shadowing.
9710023e 6574 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6575
a415e694
PE
6576 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6577 avoid shadowing.
6578
8ef4622d
PE
6579 * lisp.h (eassert): Check that the argument compiles, even if
6580 ENABLE_CHECKING is not defined.
6581
946f9a5b
PE
6582 * data.c (Findirect_variable): Name an expression, to avoid
6583 gcc -Wbad-function-cast warning.
112396d6 6584 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6585 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6586 (Fmake_variable_buffer_local, Fmake_local_variable):
6587 Mark variables as initialized.
52746918 6588 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6589
e5aab7e7 6590 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6591 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6592 Rename locals to avoid shadowing.
dff45157
PE
6593 (mark_stack): Move local variables into the #ifdef region where
6594 they're used.
7bc26fdb
PE
6595 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6596 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6597 needed otherwise.
6598 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6599 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6600 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6601
e5aab7e7
PE
6602 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6603 avoids undefined behavior in theory.
6604
4da60324
PE
6605 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6606
88043301
PE
6607 Use functions, not macros, for up- and down-casing (Bug#8254).
6608 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6609 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6610 to use the following functions instead of these macros.
6611 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6612 EMACS_INT, since callers assume the returned value fits in int.
6613 (upcase1): Likewise, for UPCASE_TABLE.
6614 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6615 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6616 the race-condition problem in the old DOWNCASE.
88043301 6617
19ed5445
PE
6618 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6619 Rename locals to avoid shadowing.
6620 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6621 (regex_compile, re_search_2, re_match_2_internal):
6622 Remove unused local vars.
952db0d7
PE
6623 (FREE_VAR): Rewrite so as not to use empty "else",
6624 which gcc can warn about.
da053e48 6625 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6626 (RETALLOC_IF): Define only if needed.
6627 (WORDCHAR_P): Likewise. This one is never needed, but is used
6628 only in a comment talking about a compiler bug, so put inside
6629 the #if 0 of that comment.
6630 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6631 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6632 Remove; unused.
19ed5445 6633
1f3561e4 6634 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6635 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6636 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6637
ded6f8f7
PE
6638 * search.c (simple_search): Remove unused var.
6639
dbd37a95
PE
6640 * dired.c (compile_pattern): Move decl from here ...
6641 * lisp.h: ... to here, so that it can be checked.
6642 (struct re_registers): New forward decl.
6643
7e47afad
PE
6644 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6645
85f24f61
PE
6646 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6647 All uses changed.
6648 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6649 Rename locals to avoid shadowing.
5671df8f 6650 (Fvertical_motion): Mark locals as initialized.
85f24f61 6651
181aa2be 6652 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6653 (casify_region): Mark local as initialized.
181aa2be 6654
930d429c
PE
6655 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6656
7082eac6
PE
6657 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6658 New macros, so that the caller can use some names other than
6659 gcpro1, gcpro2, etc.
6660 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6661 of the new macros.
6662 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6663 argument, for consistency with GCPRO2_VAR, etc: it is now the
6664 prefix of the variable, not the variable itself. All uses
6665 changed.
38b2c076
PE
6666 * dired.c (directory_files_internal, file_name_completion):
6667 Rename locals to avoid shadowing.
6668
15206ed9
PE
6669 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6670 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6671 dired.c's scmp function, had undefined behavior.
6672 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6673 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6674 * buffer.h: ... to here, because these macros use current_buffer,
6675 and the new implementation with inline functions needs to have
6676 current_buffer in scope now, rather than later when the macros
6677 are used.
6678 (downcase, upcase1): New static inline functions.
6679 (DOWNCASE, UPCASE1): Reimplement using these functions.
6680 This avoids undefined behavior in expressions like
6681 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6682 from race conditions in accessing the global variables
6683 case_temp1 and case_temp2.
6684 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6685 * lisp.h (case_temp1, case_temp2): Remove their decls.
6686 * character.h (ASCII_CHAR_P): Move from here ...
6687 * lisp.h: ... to here, so that the inline functions mentioned
6688 above can use them.
6689
4a6bea26
PE
6690 * dired.c (directory_files_internal_unwind): Now static.
6691
f14b7e14
PE
6692 * fileio.c (file_name_as_directory, directory_file_name):
6693 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6694 Now static.
2893f146
PE
6695 (file_name_as_directory): Use const pointers when appropriate.
6696 (Fexpand_file_name): Likewise. In particular, newdir might
6697 point at constant storage, so make it a const pointer.
fd4ead52 6698 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6699 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6700 signedness issues.
f839df0c
PE
6701 (Fset_file_times, Finsert_file_contents, auto_save_error):
6702 Rename locals to avoid shadowing.
f14b7e14 6703
5716756e 6704 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6705 (Ftry_completion, Fall_completions): Rename or remove locals
6706 to avoid shadowing.
5716756e 6707
b4c3046a
PE
6708 * marker.c (bytepos_to_charpos): Remove; unused.
6709
b45db522
PE
6710 * lisp.h (verify_bytepos, count_markers): New decls,
6711 so that gcc does not warn that these functions aren't declared.
6712
85876d07
PE
6713 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6714 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6715 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6716 (copy_text): Remove unused local var.
85876d07 6717
03d78a21 6718 * filelock.c (within_one_second): Now static.
b3dd38ab 6719 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6720
5df8f01b
PE
6721 * buffer.c (fix_overlays_before): Mark locals as initialized.
6722 (fix_start_end_in_overlays): Likewise. This function should be
6723 simplified by using pointers-to-pointers, but that's a different
6724 matter.
b1d876f1 6725 (switch_to_buffer_1): Now static.
8f54f30a
PE
6726 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6727 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6728
a70072c9 6729 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6730 Fix pointer signedness issue.
edced198
PE
6731 (sys_subshell): Mark local as volatile if checking for lint,
6732 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6733 (MAXPATHLEN): Define only if needed.
a70072c9 6734
a0977c44
PE
6735 * process.c (serial_open, serial_configure): Move decls from here ...
6736 * systty.h: ... to here, so that they can be checked.
6737
a884fdcc
PE
6738 * fns.c (get_random, seed_random): Move extern decls from here ...
6739 * lisp.h: ... to here, so that they can be checked.
6740
604efe86 6741 * sysdep.c (reset_io): Now static.
b8950c94 6742 (wait_for_termination_signal): Remove; unused.
604efe86 6743
38fc62d9
PE
6744 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6745 (copy_keymap_item, append_key, push_text_char_description):
6746 Now static.
1004a21a 6747 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6748 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6749 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6750 (describe_map_tree):
6751 Rename locals to avoid shadowing.
38fc62d9 6752
2f2650da
PE
6753 * keyboard.c: Declare functions static if they are not used elsewhere.
6754 (echo_char, echo_dash, cmd_error, top_level_2):
6755 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6756 (read_char, kbd_buffer_get_event, make_lispy_position):
6757 (make_lispy_event, make_lispy_movement, apply_modifiers):
6758 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6759 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6760 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6761 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6762 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6763
a053e86c 6764 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6765 (mark_kboards): Move decl here ...
6766 * alloc.c (mark_kboards): ... from here.
a053e86c 6767
4752793e
PE
6768 * lisp.h (force_auto_save_soon): New decl.
6769
74f10ca7 6770 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6771 (DEFINE_DUMMY_FUNCTION): New macro.
6772 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6773 Use it.
c03cd23f
PE
6774 (main): Add casts to avoid warnings
6775 if GCC considers string literals to be constants.
74f10ca7 6776
022e70d4
PE
6777 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6778
59d6fe83
PE
6779 * dbusbind.c: Pointer signedness fixes.
6780 (xd_signature, xd_append_arg, xd_initialize):
6781 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6782 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6783 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6784 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6785
78320123
PE
6786 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6787 if GCC considers string literals to be constants.
49cebcca 6788 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6789
35ac2a97
SM
67902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6791
fb103ca9
SM
6792 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6793 (print_preprocess, print_object): New macro to fix last change.
6794
35ac2a97
SM
6795 * print.c (print_preprocess): Don't forget font objects.
6796
62973b41
JB
67972011-03-16 Juanma Barranquero <lekktu@gmail.com>
6798
6799 * emacs.c (USAGE3): Doc fixes.
6800
0e48bb22
AS
68012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6802
6803 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6804 structure.
6805
7684e57b
JB
68062011-03-14 Juanma Barranquero <lekktu@gmail.com>
6807
6808 * lisp.h (VWindow_system, Qfile_name_history):
6809 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6810 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6811 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6812
6813 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6814 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6815
6816 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6817 * w32console.c (detect_input_pending, read_input_pending)
6818 (encode_terminal_code):
6819 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6820 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6821 (w32_system_caret_y, Qfile_name_history):
6822 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6823 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6824 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6825 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6826 * w32proc.c (Qlocal, report_file_error):
6827 * w32term.c (Vwindow_system, updating_frame):
6828 * w32uniscribe.c (initialized, uniscribe_font_driver):
6829 Remove unneeded extern declarations.
6830
2aa46d6c
CY
68312011-03-14 Chong Yidong <cyd@stupidchicken.com>
6832
c96bbc66 6833 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6834
cffc6f3b
CY
68352011-03-13 Chong Yidong <cyd@stupidchicken.com>
6836
6837 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6838 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6839 These macros can no longer be used for assignment.
6840
44f230aa
SM
6841 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6842 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6843 (record_buffer_markers, fetch_buffer_markers): New functions for
6844 recording and fetching special buffer markers.
6845 (set_buffer_internal_1, set_buffer_temp): Use them.
6846
6847 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6848
6849 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6850
6851 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6852 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6853
6854 * xdisp.c (hscroll_window_tree):
6855 (reconsider_clip_changes): Use PT instead of BUF_PT.
6856
d251f04b
EZ
68572011-03-13 Eli Zaretskii <eliz@gnu.org>
6858
6859 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6860 $(EMACS_ROOT)/lib/intprops.h.
6861
f0c77cd1
PE
68622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6863
3eca4629
PE
6864 Fix more problems found by GCC 4.5.2's static checks.
6865
7c86ee98
PE
6866 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6867 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6868 (xg_free_frame_widgets): Make it clear that a local variable is
6869 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6870 (gdk_window_get_screen): Make it clear that this macro is needed
6871 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6872 (int_gtk_range_get_value): New function, which avoids a diagnostic
6873 from gcc -Wbad-function-cast.
6874 (xg_set_toolkit_scroll_bar_thumb): Use it.
6875 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6876 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6877 (get_utf8_string, xg_get_file_with_chooser):
6878 Rename locals to avoid shadowing.
6879 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6880
41729b81
PE
6881 * xgselect.c (xg_select): Remove unused var.
6882
f0c77cd1
PE
6883 * image.c (four_corners_best): Mark locals as initialized.
6884 (gif_load): Initialize transparent_p to zero (Bug#8238).
6885 Mark another local as initialized.
ec6cf4c6 6886 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6887
ce0ad53d 6888 * image.c (clear_image_cache): Now static.
d5d5a617 6889 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6890 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6891 (x_edge_detection): Remove unnecessary cast that
6892 gcc -Wbad-function-cast diagnoses.
2037898d 6893 (gif_load): Fix pointer signedness.
6ae141d6
PE
6894 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6895 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6896
33383987 68972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6898
d32df629
PE
6899 Improve quality of tests for time stamp overflow.
6900 For example, without this patch (encode-time 0 0 0 1 1
6901 1152921504606846976) returns the obviously-bogus value (-948597
6902 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6903 reports time overflow. See
6904 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6905 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6906 * editfns.c: Include limits.h and intprops.h.
6907 (TIME_T_MIN, TIME_T_MAX): New macros.
6908 (time_overflow): Move earlier, to before first use.
6909 (hi_time, lo_time): New functions, for an accurate test for
6910 out-of-range times.
6911 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6912 (Fget_internal_run_time): Don't assume time_t fits in int.
6913 (make_time): Use list2 instead of Fcons twice.
6914 (Fdecode_time): More accurate test for out-of-range times.
6915 (check_tm_member): New function.
6916 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6917 (lisp_time_argument): Don't rely on undefined left-shift and
6918 right-shift behavior when checking for time stamp overflow.
8be6f318 6919
fe31d94c
PE
6920 * editfns.c (time_overflow): New function, refactoring common code.
6921 (Fformat_time_string, Fdecode_time, Fencode_time):
6922 (Fcurrent_time_string): Use it.
6923
8be6f318
PE
6924 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6925 * dired.c (make_time): Move to ...
6926 * editfns.c (make_time): ... here.
6927 * systime.h: Note the move.
6928
09d9db2c 69292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6930
126bc0dc
YM
6931 * fringe.c (update_window_fringes): Remove unused variables.
6932
c47cbdfd
YM
6933 * unexmacosx.c (copy_data_segment): Also copy __got section.
6934 (Bug#8223)
6935
7ac80be9
EZ
69362011-03-12 Eli Zaretskii <eliz@gnu.org>
6937
c96bbc66 6938 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6939 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6940 Constify `char *' arguments and their references according to
6941 prototypes in tparam.h.
6942
ecb0f94d 6943 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6944
7ac80be9
EZ
6945 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6946 Adapt all references accordingly.
6947
6948 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6949
ef1fd07e
TT
69502011-03-11 Tom Tromey <tromey@redhat.com>
6951
6952 * buffer.c (syms_of_buffer): Remove obsolete comment.
6953
7ef4b50c
EZ
69542011-03-11 Eli Zaretskii <eliz@gnu.org>
6955
6956 * termhooks.h (encode_terminal_code): Declare prototype.
6957
6958 * msdos.c (encode_terminal_code): Don't declare prototype.
6959
6960 * term.c (encode_terminal_code): Now external again, used by
6961 w32console.c and msdos.c.
6962
44f230aa
SM
6963 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6964 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6965
4b1ec863 69662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6967
1714f52b 6968 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6969
4b1ec863
PE
6970 * fringe.c (update_window_fringes): Mark locals as initialized
6971 (Bug#8227).
6972 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6973
524c7aa6
PE
6974 * alloc.c (mark_fringe_data): Move decl from here ...
6975 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6976 to check its interface.
6977 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6978
a5c0af81 6979 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6980 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6981 (fontset_font): Mark local as initialized.
a9a06e0b 6982 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6983
b4716021
PE
6984 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6985
811e9bac 6986 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6987 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6988 (x_own_selection, Fx_disown_selection_internal): Rename locals
6989 to avoid shadowing.
6990 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6991
7e3ab302
PE
6992 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6993 so that the caller can use some name other than gcpro1.
6994 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6995 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6996 (Fx_backspace_delete_keys_p):
6997 Use them to avoid shadowing, and rename vars to avoid shadowing.
6998 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6999 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7000 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7001 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7002 Remove unused locals.
7e3ab302
PE
7003 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7004 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7005 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7006 macros.
f78faa98 7007
e2b13473
PE
7008 * xterm.h (x_mouse_leave): New decl.
7009
77f23912
PE
7010 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7011 Remove unused functions.
cdf4ba58
PE
7012 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7013 (x_calc_absolute_position): Now static.
7411c686 7014 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7015 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7016 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7017 unless they are used.
38d0b34a
PE
7018 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7019 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7020 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7021 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7022 (x_error_catcher, x_connection_closed, x_error_handler):
7023 (x_error_quitter, xembed_send_message, x_iconify_frame):
7024 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7025 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7026 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7027
44f230aa
SM
7028 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7029 Rename or move locals to avoid shadowing.
6b463e58 7030 (tty_defined_color, merge_face_heights): Now static.
5967d051 7031 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7032 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7033 does not deduce is never used uninitialized.
73719eba
PE
7034 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7035 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7036
426994c3 7037 * terminal.c (store_terminal_param): Now static.
5489860b 7038
032f1620 7039 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7040 (set_frame_menubar): Remove unused local.
d4323972 7041 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7042 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7043 since they might point to immutable storage.
281585b0
PE
7044 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7045 since it's unused otherwise.
032f1620 7046
367c19e5 7047 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7048 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7049 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7050 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7051 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7052 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7053 does not deduce are never used uninitialized.
70739cbe 7054
07b48fa9
PE
7055 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7056
8868a238 7057 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7058 * window.c (window_loop, size_window):
7059 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7060
7e5cf297 7061 * window.c (display_buffer): Now static.
d6550a9f
PE
7062 (size_window): Mark variables that gcc -Wuninitialized
7063 does not deduce are never used uninitialized.
a586633d
PE
7064 * window.h (check_all_windows): New decl, to forestall
7065 gcc -Wmissing-prototypes diagnostic.
5b555da1 7066 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7067
f6095868
PE
7068 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7069 shadowing.
7070 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7071 Include <limits.h>.
7072 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7073 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7074 (load_charset_map): Mark variables that gcc -Wuninitialized
7075 does not deduce are never used uninitialized.
53df7c11 7076 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7077
f38b440c
PE
7078 * coding.c (coding_set_source, coding_set_destination):
7079 Use "else { /* comment */ }" rather than "else /* comment */;"
7080 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7081 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7082 a block, when the outer 'i' will do.
7083 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7084 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7085 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7086 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7087 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7088 Rename locals to avoid shadowing.
7089 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7090 * coding.c (emacs_mule_char, encode_invocation_designation):
7091 Now static, since they're not used elsewhere.
413bb2db 7092 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7093 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7094 (decode_coding_emacs_mule): Mark variables that gcc
7095 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7096 (detect_coding_iso_2022): Initialize a local variable that might
7097 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7098 this initialization is needed. (Bug#8211)
5f58e762
PE
7099 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7100 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7101 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7102 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7103 Remove unused macros.
f38b440c 7104
232b38b9 7105 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7106 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7107 * character.c (string_count_byte8): Likewise.
232b38b9 7108
fb90da1b
PE
7109 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7110 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7111
fb93dbc2
PE
7112 * chartab.c (copy_sub_char_table): Now static, since it's not used
7113 elsewhere.
5c156ace
PE
7114 (sub_char_table_ref_and_range, char_table_ref_and_range):
7115 Rename locals to avoid shadowing.
bbcd0949 7116 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7117
7d3b3862 7118 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7119 (BIDI_BOB): Remove unused macro.
7d3b3862 7120
6be7d3da
PE
7121 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7122 deduce are never used uninitialized.
c2ed9c8b 7123 * term.c (encode_terminal_code): Likewise.
6be7d3da 7124
75f8807f 7125 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7126
50938595
PE
7127 * tparam.h: New file.
7128 * term.c, tparam.h: Include it.
7129 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7130 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7131 Move these decls to tparam.h, and make them agree with what
7132 is actually in tparam.c. The previous trick of using incompatible
7133 decls in different modules does not conform to the C standard.
7134 All callers of tparam changed to use tparam's actual API.
7135 * tparam.c (tparam1, tparam, tgoto):
7136 Use const pointers where appropriate.
7137
fbceeba2
PE
7138 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7139 * cm.h (struct cm): Likewise.
7140 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7141 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7142 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7143 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7144 (turn_on_face, init_tty): Likewise.
7145 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7146
7f3f1250
PE
7147 * term.c (term_mouse_position): Rename local to avoid shadowing.
7148
e6ca6543
PE
7149 * alloc.c (mark_ttys): Move decl from here ...
7150 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7151
c40f8d15
AS
71522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7153
7154 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7155
cfe0661d
JB
71562011-03-09 Juanma Barranquero <lekktu@gmail.com>
7157
7158 * search.c (compile_pattern_1): Remove argument regp, unused since
7159 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7160 (compile_pattern): Don't pass it.
7161
0afb4571
J
71622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7163
7164 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7165 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7166 for ! HAVE_GTK3.
7167 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7168
7169 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7170
7171 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7172 gdk_window_get_screen, gdk_window_get_geometry,
7173 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7174 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7175 (xg_get_pixbuf_from_pixmap): New function.
7176 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7177 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7178 Call xg_get_pixbuf_from_pixmap instead of
7179 gdk_pixbuf_get_from_drawable.
7180 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7181 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7182 (xg_check_special_colors): Use GtkStyleContext and its functions
7183 for HAVE_GTK3.
7184 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7185 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7186 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7187 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7188 Call gtk_widget_get_preferred_size.
0afb4571
J
7189 (xg_frame_resized): gdk_window_get_geometry only takes 5
7190 parameters.
44f230aa
SM
7191 (xg_win_to_widget, xg_event_is_for_menubar):
7192 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7193 (xg_set_widget_bg): New function.
7194 (delete_cb): New function.
895009e1 7195 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7196 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7197 (xg_set_background_color): Call xg_set_widget_bg.
7198 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7199 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7200 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7201 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7202 if ! HAVE_GTK3.
7203 (update_frame_tool_bar): Call gtk_widget_hide.
7204 (xg_initialize): Use GDK_KEY_g.
7205
7206 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7207 if ! HAVE_GTK3
7208 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7209
7210 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7211 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7212 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7213
1c2cc4ef
JB
72142011-03-08 Juanma Barranquero <lekktu@gmail.com>
7215
7216 * w32xfns.c (select_palette): Check success of RealizePalette against
7217 GDI_ERROR, not zero.
7218
33383987 7219See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7220
7221;; Local Variables:
7222;; coding: utf-8
aac0c6e3
MR
7223;; End:
7224
33383987 7225 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7226
7227 This file is part of GNU Emacs.
7228
7229 GNU Emacs is free software: you can redistribute it and/or modify
7230 it under the terms of the GNU General Public License as published by
7231 the Free Software Foundation, either version 3 of the License, or
7232 (at your option) any later version.
7233
7234 GNU Emacs is distributed in the hope that it will be useful,
7235 but WITHOUT ANY WARRANTY; without even the implied warranty of
7236 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7237 GNU General Public License for more details.
7238
7239 You should have received a copy of the GNU General Public License
7240 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.