* src/eval.c (Fsignal): Handle `debug' symbol in error handler.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bd1ba3e8
CY
12011-08-20 Chong Yidong <cyd@stupidchicken.com>
2
3 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4
54a1215b
EZ
52011-08-19 Eli Zaretskii <eliz@gnu.org>
6
823564e5
EZ
7 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9 from an Org mode buffer to a Speedbar frame.
10
54a1215b
EZ
11 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
12 a composition, take its buffer position from IT->cmp_it.charpos.
13 Fixes cursor positioning at the beginning of a line that begins
14 with a composed character.
15
9778ebcc
EZ
162011-08-18 Eli Zaretskii <eliz@gnu.org>
17
0be6ee06
EZ
18 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
19 character bidirectional type, use STRONG_L instead. Fixes crashes
20 in a buffer produced by `describe-categories'.
21
9778ebcc
EZ
22 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
23 members before the level stack, so they would be saved and
24 restored when copying iterator state. Fixes incorrect reordering
25 around TABs covered by display properties.
26
156bffbe
AS
272011-08-18 Andreas Schwab <schwab@linux-m68k.org>
28
29 * process.c (Fnetwork_interface_list): Correctly determine buffer
30 size.
31
72ad093b
CY
322011-08-17 Chong Yidong <cyd@stupidchicken.com>
33
34 * eval.c (internal_condition_case, internal_condition_case_1)
35 (internal_condition_case_2, internal_condition_case_n): Remove
36 unnecessary aborts (Bug#9081).
37
35774242
EZ
382011-08-17 Eli Zaretskii <eliz@gnu.org>
39
40 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
41 has no `load' handler, try opening the file locally. (Bug#9311)
42
db76dd85
KB
432011-08-16 Ken Brown <kbrown@cornell.edu>
44
45 * gmalloc.c: Expand comment.
46
b215eee5
EZ
472011-08-16 Eli Zaretskii <eliz@gnu.org>
48
49 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
50 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
51
a4579d33
KB
522011-08-16 Ken Brown <kbrown@cornell.edu>
53
54 Fix memory allocation problems in Cygwin build (Bug#9273).
55
56 * unexcw.c ( __malloc_initialized): Declare external variable.
57 (fixup_executable): Force the dumped emacs to reinitialize malloc.
58
59 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
60 variables.
61 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
62 dumped emacs.
63 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
64 in the static heap.
65 [CYGWIN] (special_realloc): New function.
66 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
67 requests to realloc storage in the static heap.
68
3ebec551
PE
692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
70
71 * bidi.c (bidi_initialize): Remove unused local.
72
9fd8be00
EZ
732011-08-15 Eli Zaretskii <eliz@gnu.org>
74
474a8465
EZ
75 * biditype.h: File removed.
76
77 * bidimirror.h: File removed.
78
79 * deps.mk (bidi.o): Remove biditype.h and
80 bidimirror.h.
81
82 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
83 bidimirror.h.
84
85 * dispextern.h: Fix a typo in the comment to bidi_type_t.
86
87 * chartab.c: Improve commentary for the uniprop_table API.
88
32413314
EZ
89 * bidi.c (bidi_paragraph_init): Support zero value of
90 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
91 (bidi_initialize): Use uniprop_table instead of including
92 biditype.h and bidimirror.h.
32413314 93
9fd8be00
EZ
94 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
95 coordinates of the iterator when restoring from ppos_it.
96 (Bug#9296)
97
5cf2b69b
KH
982011-08-14 Kenichi Handa <handa@m17n.org>
99
100 * process.c (create_process): Call setup_process_coding_systems
72ad093b 101 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 102
daf17d00
EZ
1032011-08-14 Eli Zaretskii <eliz@gnu.org>
104
105 * xdisp.c (move_it_in_display_line_to): Don't invoke
106 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
107 ppos_it. Fixes vertical cursor motion when line beginning is
108 covered by an image. (Bug#9296)
109
08e3161a
JD
1102011-08-14 Jan Djärv <jan.h.d@swipnet.se>
111
112 * nsterm.h (ns_run_ascript): Declare.
113 (NSAPP_DATA2_RUNASSCRIPT): Define.
114
115 * nsfns.m (as_script, as_result, as_status): New static variables.
116 (ns_run_ascript): New function.
117 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
118 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
119 the event loop. Get status from as_status (Bug#7276).
120
121 * nsterm.m (sendEvent): If event is NSApplicationDefined and
122 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
123 the event loop (Bug#7276).
124
a3720aa2
AS
1252011-08-14 Andreas Schwab <schwab@linux-m68k.org>
126
127 * gnutls.c (QCgnutls_bootprop_priority)
128 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
129 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
130 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
131 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
132 (QCgnutls_bootprop_verify_hostname_error)
133 (QCgnutls_bootprop_callbacks_verify): Rename from
134 Qgnutls_bootprop_..., all uses changed.
135
136 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
137 uses changed.
138
0a0d27fb
PE
1392011-08-14 Paul Eggert <eggert@cs.ucla.edu>
140
19d5c50c
PE
141 * xfaces.c (Qframe_set_background_mode): Now static.
142 * dispextern.h (Qframe_set_background_mode): Remove decl.
143
0a0d27fb
PE
144 * process.c (Fnetwork_interface_info): Declare local only if needed.
145
377538cb
JD
1462011-08-13 Jan Djärv <jan.h.d@swipnet.se>
147
148 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
149 (Fnetwork_interface_list): Allocate in increments of bytes instead
150 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
151 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
152 sockaddr.
153 (struct ifflag_def): notrailers is smart on OSX.
154 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
155 Get hardware address with getifaddrs if available.
156
08fff70c
EZ
1572011-08-12 Eli Zaretskii <eliz@gnu.org>
158
159 * xdisp.c (iterate_out_of_display_property): xassert that
160 IT->position is set to within IT->object's boundaries. Break from
161 the loop as soon as EOB is reached; avoids infloops in redisplay
162 when IT->position is set up wrongly due to some bug. Set
163 IT->current to match the bidi iterator unconditionally.
164 (push_display_prop): Allow GET_FROM_STRING as IT->method on
165 entry. Force push_it to save on the stack the current
166 buffer/string position, to be restored by pop_it. Fix flags in
167 the iterator structure wrt the object coming from a display
168 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
169 properties. (Bug#9284)
170
7be1c708 1712011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 172
7be1c708
CY
173 * fontset.c (fontset_get_font_group): Add proper type checks.
174 (Bug#9172)
aac0c6e3 175
7be1c708 1762011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 177
7be1c708
CY
178 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
179 and LC_VERSION_MIN_MACOSX.
180 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
181 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 182
97bb72a6
EZ
1832011-08-08 Eli Zaretskii <eliz@gnu.org>
184
185 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
186 no-display-properties-and-no-overlays under bidi display. Set
187 disp_pos in the bidi iterator to avoid searches for display
188 properties and overlays.
97bb72a6 189
d5617611
CY
1902011-08-08 Chong Yidong <cyd@stupidchicken.com>
191
37e11a63
CY
192 * editfns.c (Fset_time_zone_rule): Document relationship with the
193 setenv function.
194
d5617611
CY
195 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
196 the font entity extracted from the cache (Bug#8109).
197
58872834
CY
1982011-08-07 Chong Yidong <cyd@stupidchicken.com>
199
200 * composite.c (autocmp_chars): Don't reset point. That is done by
201 restore_point_unwind (Bug#5984).
202
75bfc667
JL
2032011-08-07 Juri Linkov <juri@jurta.org>
204
205 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
206 to show the arg `TIME' instead of `TIMEVAL'.
207
d1410150
EZ
2082011-08-06 Eli Zaretskii <eliz@gnu.org>
209
210 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
211 display property strides EOL and includes a newline, as in
212 longlines-mode. (Bug#9254)
75b771e4
EZ
213 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
214 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
215
216 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
217 is non-zero, even if the data buffer is NULL. Fixes a crash in
218 vertical-motion with longlines-mode. (Bug#9254)
219
35928349
EZ
2202011-08-05 Eli Zaretskii <eliz@gnu.org>
221
ec7cc85b
EZ
222 * bidi.c <bidi_cache_total_alloc>: Now static.
223 (bidi_initialize): Initialize bidi_cache_total_alloc.
224
35928349
EZ
225 *xdisp.c (display_line): Release buffer allocated for shelved bidi
226 cache. (Bug#9221)
227
228 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
229 amount allocated this far in `bidi_cache_total_alloc'.
230 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
231 non-zero, only free the data buffer without restoring the cache
232 contents. All callers changed.
233
234 * dispextern.h (bidi_unshelve_cache): Update prototype.
235
236 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
237 (move_it_in_display_line, move_it_to)
238 (move_it_vertically_backward, move_it_by_lines): Replace the call
239 to xfree to an equivalent call to bidi_unshelve_cache.
240 (move_it_in_display_line_to): Fix logic of returning
412b6358 241 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 242
e2e2423b
EZ
2432011-08-05 Eli Zaretskii <eliz@gnu.org>
244
245 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
246 came from a string character with a `cursor' property. (Bug#9229)
247
ae9e757a
JD
2482011-08-04 Jan Djärv <jan.h.d@swipnet.se>
249
250 * Makefile.in (LIB_PTHREAD): New variable.
251 (LIBES): Add LIB_PTHREAD (Bug#9216).
252
253 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
254 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
255
213bd7f2
AS
2562011-08-04 Andreas Schwab <schwab@linux-m68k.org>
257
258 * regex.c (re_iswctype): Remove some redundant boolean
259 conversions.
260
99aaf75f
JD
2612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
262
263 * xterm.c (x_find_topmost_parent): New function.
264 (x_set_frame_alpha): Find topmost parent window with
265 x_find_topmost_parent and set the property there also (bug#9181).
266 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
267
c74e9d86
PE
2682011-08-04 Paul Eggert <eggert@cs.ucla.edu>
269
270 * callproc.c (Fcall_process): Avoid vfork clobbering
271 the local vars buffer, coding_systems, current_dir.
272
640c8776
SM
2732011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
274
275 * keymap.c (Fmake_composed_keymap): Move to subr.el.
276
f26d0e4c
PE
2772011-08-03 Paul Eggert <eggert@cs.ucla.edu>
278
8a10d76c
PE
279 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
280 so that it is not optimized away.
281
f26d0e4c
PE
282 * xdisp.c (compute_display_string_pos): Remove unused local.
283
55439c61
EZ
2842011-08-02 Eli Zaretskii <eliz@gnu.org>
285
286 Fix slow cursor motion and scrolling in large buffers with
287 selective display, like Org Mode buffers. (Bug#9218)
288
289 * dispextern.h (struct bidi_it): New member disp_prop_p.
290
291 * xdisp.c: Remove one-slot cache of display string positions.
292 (compute_display_string_pos): Accept an additional argument
293 DISP_PROP_P; callers changed. Scan at most 5K characters forward
294 for a display string or property. If found, set DISP_PROP_P
295 non-zero.
296
297 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
298 DISP_PROP_P, and pass it to compute_display_string_pos.
299 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
300 non-zero. All callers of bidi_fetch_char changed.
301
fb33fa43
SM
3022011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
303
304 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
305
b099e063
DM
3062010-12-03 Don March <don@ohspite.net>
307
308 * keymap.c (Fdefine_key): Fix non-prefix key error message when
309 last character M-[char] is translated to ESC [char] (bug#7541).
310
5cc7f7af
KH
3112011-08-02 Kenichi Handa <handa@m17n.org>
312
d0fffa3f 313 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
314
315 * chartab.c (uniprop_table): Make it non-static.
316
525d5e6e
EZ
3172011-08-01 Eli Zaretskii <eliz@gnu.org>
318
319 * xdisp.c (forward_to_next_line_start): Accept additional argument
320 BIDI_IT_PREV, and store into it the state of the bidi iterator had
321 on the newline.
322 (reseat_at_next_visible_line_start): Use the bidi iterator state
323 returned by forward_to_next_line_start to restore the state of
324 it->bidi_it after backing up to previous newline. (Bug#9212)
325
31011111
AS
3262011-07-30 Andreas Schwab <schwab@linux-m68k.org>
327
328 * regex.c (re_comp): Protoize.
329 (re_exec): Fix return type.
330 (regexec): Fix type of `ret'. (Bug#9203)
331
e5d76069
PE
3322011-07-29 Paul Eggert <eggert@cs.ucla.edu>
333
334 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
335 This is needed if max-image-size is a floating-point number.
336
9a79b20c
AS
3372011-07-28 Andreas Schwab <schwab@linux-m68k.org>
338
339 * print.c (print_object): Print empty symbol as ##.
340
341 * lread.c (read1): Read ## as empty symbol.
342
d8c2fa78
AA
3432011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
344
345 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
346 setting frame foreground color (Bug#9175).
347 (x_set_background_color): Likewise.
348
ffe57a7a
AA
349 * nsmenu.m (-setText): Size tooltip dimensions precisely to
350 contents (Bug#9176).
351 (EmacsTooltip -init): Remove bezels and add shadows to
352 tooltip windows.
353
bf3492a5
AA
354 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
355 or scroll bar (Bug#8470).
356
d55e9c53
AA
357 * nsfont.m (nsfont_open): Remove assignment to voffset and
358 unnecessary vars hshink, expand, hd, full_height, min_height.
359 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
360
361 * nsterm.h (nsfont_info): Remove voffset field.
362
d8c2fa78 3632011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
364
365 Implement strike-through and overline on NextStep (Bug#8863).
366
367 * nsfont.m (nsfont_open): Use underline position provided by font,
368 instead of hard-coded value of 2.
369 (nsfont_draw): Call ns_draw_text_decoration instead.
370
371 * nsterm.h: Add declaration for ns_draw_text_decoration.
372
373 * nsterm.m (ns_draw_text_decoration): New function for drawing
374 underline, overline, and strike-through.
375 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
376 ns_draw_text_decoration. Change treatment of cursor drawing to
377 accomodate underlining, etc.
378
4cc60b9b
EZ
3792011-07-28 Eli Zaretskii <eliz@gnu.org>
380
bc7ece87
EZ
381 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
382 default.
4cc60b9b 383
476371c4
PE
3842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
385
66606eea
PE
386 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
387 Without this fix, if a signal arrives just after memory fills up,
388 'malloc' might be invoked reentrantly.
389
476371c4
PE
390 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
391 In other words, assume that every image size is allowed, on non-X
392 hosts. This assumption is probably wrong, but it lets Emacs compile.
393
f3fcc40d
AS
3942011-07-28 Andreas Schwab <schwab@linux-m68k.org>
395
396 * regex.c (re_iswctype): Convert return values to boolean.
397
350c992f
EZ
3982011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
399
400 * xdisp.c (compute_display_string_pos): Don't use cached display
401 string position if the buffer had its restriction changed.
402 (Bug#9184)
403
5266b4bb
PE
4042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
405
406 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
407
2573a837 4082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 409
41f55ccd 410 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 411
39e378da
PE
412 * bidi.c: Integer size and overflow fixes.
413 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
414 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
415 (bidi_cache_find_level_change, bidi_cache_ensure_space)
416 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
417 (bidi_find_other_level_edge):
418 Use ptrdiff_t instead of EMACS_INT where either will do.
419 This works better on 32-bit hosts configured --with-wide-int.
420 (bidi_cache_ensure_space): Check for size-calculation overflow.
421 Use % rather than repeated addition, for better worst-case speed.
422 Don't set bidi_cache_size until after xrealloc returns, because it
423 might not return.
424 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
425 (bidi_cache_ensure_space): Also check that the bidi cache size
426 does not exceed that of the largest Lisp string or buffer. See Eli
427 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 428
5e927815
PE
429 * alloc.c (__malloc_size_t): Remove.
430 All uses replaced by size_t. See Andreas Schwab's note
431 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
432
ca4aa935
PE
433 * image.c: Improve checking for integer overflow.
434 (check_image_size): Assume that f is nonnull, since
435 it is always nonnull in practice. This is one less thing to
436 worry about when checking for integer overflow later.
437 (x_check_image_size): New function, which checks for integer
438 overflow issues inside X.
439 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
440 This removes the need for a memory_full check.
441 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
442 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
443 (xbm_read_bitmap_data): Change locals back to 'int', since
444 their values must fit in 'int'.
445 (xpm_load_image, png_load, tiff_load):
446 Invoke x_create_x_image_and_pixmap earlier,
447 to avoid much needless work if the image is too large.
448 (tiff_load): Treat overly large images as if
449 x_create_x_image_and_pixmap failed, not as malloc failures.
450 (gs_load): Use x_check_image_size.
451
5f8f9cc2
PE
452 * gtkutil.c: Omit integer casts.
453 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
454 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
455
5adf60bc
PE
456 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
457
c8907a93
PE
458 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
459 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
460 would wrongly return t on a 64-bit host.
461
e3c25c68
PE
462 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
463 The plain *_OVERFLOW macros run afoul of GCC bug 49705
464 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
465 and therefore cause GCC to emit a bogus diagnostic in some cases.
466
3f791afe
PE
467 * image.c: Integer signedness and overflow and related fixes.
468 This is not an exhaustive set of fixes, but it's time to
469 record what I've got.
470 (lookup_pixel_color, check_image_size): Remove redundant decls.
471 (check_image_size): Don't assume that arbitrary EMACS_INT values
472 fit in 'int', or that arbitrary 'double' values fit in 'int'.
473 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
474 (tiff_load, imagemagick_load_image):
475 Check for overflow in size calculations.
476 (x_create_x_image_and_pixmap): Remove unnecessary test for
477 xmalloc returning NULL; that can't happen.
478 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
479 (xpm_color_bucket): Use better integer hashing function.
480 (xpm_cache_color): Don't possibly over-allocate memory.
481 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
482 (gif_memory_source):
483 Use ptrdiff_t, not int or size_t, to record sizes.
484 (png_load): Don't assume values greater than 2**31 fit in 'int'.
485 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
486 either works, as we prefer signed integers.
487 (tiff_read_from_memory, tiff_write_from_memory):
488 Return tsize_t, not size_t, since that's what the TIFF API wants.
489 (tiff_read_from_memory): Don't fail simply because the read would
490 go past EOF; instead, return a short read.
491 (tiff_load): Omit no-longer-needed casts.
492 (Fimagemagick_types): Don't assume size fits into 'int'.
493
3cc5a532
PE
494 Improve hashing quality when configured --with-wide-int.
495 * fns.c (hash_string): New function, taken from sxhash_string.
496 Do not discard information about ASCII character case; this
497 discarding is no longer needed.
498 (sxhash-string): Use it. Change sig to match it. Caller changed.
499 * lisp.h: Declare it.
500 * lread.c (hash_string): Remove, since we now use fns.c's version.
501 The fns.c version returns a wider integer if --with-wide-int is
502 specified, so this should help the quality of the hashing a bit.
503
b312a492
PE
504 * emacs.c: Integer overflow minor fix.
505 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
506 Define only if GNU_LINUX.
507 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
508
dfd153ae
PE
509 * dispnew.c: Integer signedness and overflow fixes.
510 Remove unnecessary forward decls, that were a maintenance hassle.
511 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
512 All uses changed.
513 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
514 (scrolling_window): Use ptrdiff_t, not int, for byte count.
515 (prepare_desired_row, line_draw_cost):
516 Use int, not unsigned, where either works.
517 (save_current_matrix, restore_current_matrix):
518 Use ptrdiff_t, not size_t, where either works.
519 (init_display): Check for overflow more accurately, and without
520 relying on undefined behavior.
521
a81d11a3
PE
522 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
523 Remove, replacing with the new symbols in lisp.h. All uses changed.
524 * fileio.c (make_temp_name):
525 * filelock.c (lock_file_1, lock_file):
526 * xdisp.c (message_dolog):
527 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
528 Use pMd etc. instead.
529 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
530 replacing the pWIDE etc. symbols removed from editfns.c.
531
3300e6fd
PE
532 * keyboard.h (num_input_events): Now uintmax_t.
533 This is (very slightly) less likely to mess up due to wraparound.
534 All uses changed.
535
fd05c7e9
PE
536 * buffer.c: Integer signedness fixes.
537 (alloc_buffer_text, enlarge_buffer_text):
538 Use ptrdiff_t rather than size_t when either will do, as we prefer
539 signed integers.
540
903fe15d
PE
541 * alloc.c: Integer signedness and overflow fixes.
542 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
543 (__malloc_size_t): Default to size_t, not to int.
544 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
545 (Fgarbage_collect, mark_object_loop_halt, mark_object):
546 Prefer ptrdiff_t to size_t when either would do, as we prefer
547 signed integers.
548 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
549 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
550 Now const. Initialize with values that are in range even if char
551 is signed.
552 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
553 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
554 These functions do the right thing with sizes > 2**32.
555 (check_depth): Now ptrdiff_t, not int.
556 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
557 Adjust to new way of storing sizes. Check for size overflow bugs
558 in rest of code.
559 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
560 slightly wrong anyway, as it missed one instance of
561 XMALLOC_OVERRUN_CHECK_OVERHEAD.
562 (refill_memory_reserve): Omit needless cast to size_t.
563 (mark_object_loop_halt): Mark as externally visible.
564
ac82cc6a
PE
565 * xselect.c: Integer signedness and overflow fixes.
566 (Fx_register_dnd_atom, x_handle_dnd_message):
567 Use ptrdiff_t, not size_t, since we prefer signed.
568 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
569 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
570 x_dnd_atoms_size and x_dnd_atoms_length.
571
c2d1e36d
PE
572 * doprnt.c: Prefer signed to unsigned when either works.
573 * eval.c (verror):
574 * doprnt.c (doprnt):
575 * lisp.h (doprnt):
576 * xdisp.c (vmessage):
577 Use ptrdiff_t, not size_t, when using or implementing doprnt,
578 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
579 prefer signed arithmetic to avoid comparison confusion.
580 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
581 but is a bit tricky.
582
0e926e56
PE
583 Assume freestanding C89 headers, string.h, stdlib.h.
584 * data.c, doprnt.c, floatfns.c, print.c:
585 Include float.h unconditionally.
586 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
587 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
588 * regex.c: Likewise for stddef.h, string.h.
589 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
590 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
591 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
592 (STDC_HEADERS): Remove obsolete defines.
593 * sysdep.c: Include limits.h unconditionally.
594
9cfdb3ec
PE
595 Assume support for memcmp, memcpy, memmove, memset.
596 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
597 * regex.c (memcmp, memcpy):
598 Remove; we assume C89 now.
599
600 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
601 (__malloc_safe_bcopy): Remove; no longer needed.
602
cf950e6b 603 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
604 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
605 well either way, and we prefer signed to unsigned.
606
dbf38e02
LMI
6072011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
608
609 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
610 closes the connection while we're reading (bug#9182).
611
d6f0886c
JD
6122011-07-25 Jan Djärv <jan.h.d@swipnet.se>
613
614 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
615 are specified (Bug#9168).
616
2eb1f9e6
PE
6172011-07-25 Paul Eggert <eggert@cs.ucla.edu>
618
619 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
620 Found by GCC static checking and --with-wide-int on a 32-bit host.
621
22381272 6222011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
623
624 * xdisp.c (compute_display_string_pos): Fix logic of caching
625 previous display string position. Initialize cached_prev_pos to
626 -1. Fixes slow-down at the beginning of a buffer.
627
f25e39b4
EZ
6282011-07-24 Eli Zaretskii <eliz@gnu.org>
629
630 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
631 for attrs[LFACE_FONTSET_INDEX].
632
04c4b52e
PE
6332011-07-23 Paul Eggert <eggert@cs.ucla.edu>
634
635 * xml.c (parse_region): Remove unused local
636 that was recently introduced.
637
c1734fbd
EZ
6382011-07-23 Eli Zaretskii <eliz@gnu.org>
639
be18c5a5
EZ
640 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
641 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
642
c1734fbd
EZ
643 * xdisp.c (move_it_in_display_line_to): Record the best matching
644 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
645 exit if none of the characters scanned was an exact match.
646 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
647 when exact match is impossible due to invisible text, and the
648 lines are truncated.
649
a258d627
JD
6502011-07-23 Jan Djärv <jan.h.d@swipnet.se>
651
652 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
653 for OSX >= 10.7.
654
b6d5a689
EZ
6552011-07-22 Eli Zaretskii <eliz@gnu.org>
656
0f74f785
EZ
657 Fix a significant slow-down of cursor motion with C-n, C-p,
658 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
659 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 660 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
661 (next_element_from_buffer): Call compute_stop_pos_backwards to
662 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
663 base_level_stop.
664 (reseat): Don't look for prev_stop, as that could mean a very long
665 run.
666 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
667 <cached_disp_overlay_modiff>: Cache for last found display string
668 position.
551918c1 669 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
670 about the same buffer in the same area of character positions, and
671 the buffer wasn't changed since the time the display string
672 position was cached.
551918c1 673
b2d0c91a
EZ
6742011-07-22 Eli Zaretskii <eliz@gnu.org>
675
676 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
677 is an integer, which is important for empty lines. (Bug#9149)
678
043604ee
CY
6792011-07-22 Chong Yidong <cyd@stupidchicken.com>
680
681 * frame.c (Fmodify_frame_parameters): In tty case, update the
682 default face if necessary (Bug#4238).
683
da4adb04
CY
6842011-07-21 Chong Yidong <cyd@stupidchicken.com>
685
686 * editfns.c (Fstring_to_char): No need to explain what a character
687 is in the docstring (Bug#6576).
688
9abd0532
LMI
6892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
690
691 * xml.c (parse_region): Make sure we always return a tree.
692
36881d16
HK
6932011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
694
695 * xml.c (parse_region): If a document contains only comments,
696 return that, too.
697
1e98674d
LMI
6982011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
699
700 * xml.c (make_dom): Return comments, too.
701
590bd467
PE
7022011-07-19 Paul Eggert <eggert@cs.ucla.edu>
703
704 Port to OpenBSD.
705 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
706 and the surrounding thread.
707 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
708 rather than fgets, and retry after EINTR. Otherwise, 'emacs
709 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
710 timer goes off.
711 * s/openbsd.h (BROKEN_SIGIO): Define.
712 * unexelf.c (unexec) [__OpenBSD__]:
713 Don't update the .mdebug section of the Alpha COFF symbol table.
714
f41628b2
LMI
7152011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
716
717 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
718 (bug#8460).
719
b59b67c5
PE
7202011-07-18 Paul Eggert <eggert@cs.ucla.edu>
721
15e3a074
PE
722 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
723 This fixes some race conditions on the permissions of any newly
724 created file.
725
41bed37d
PE
726 * alloc.c (valid_pointer_p): Use pipe, not open.
727 This fixes some permissions issues when debugging.
728
b59b67c5
PE
729 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
730 If fchown fails to set both uid and gid, try to set just gid,
731 as that is sometimes allowed. Adjust the file's mode to eliminate
732 setuid or setgid bits that are inappropriate if fchown fails.
733
925a6be7
SM
7342011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
735
736 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
737 to compare Lisp_Objects.
738 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
739 global_gnutls_log_level, don't mistake it for a Lisp_Object.
740 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
741
52968808
AS
7422011-07-17 Andreas Schwab <schwab@linux-m68k.org>
743
0a6a104b
AS
744 * lread.c (read_integer): Unread even EOF character.
745 (read1): Likewise. Properly record start position of symbol.
746
52968808
AS
747 * lread.c (read1): Read `#:' as empty uninterned symbol if no
748 symbol character follows.
749
9e381cdd
PE
7502011-07-17 Paul Eggert <eggert@cs.ucla.edu>
751
752 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
753 This works around a problem with the previous change to Fcopy_file.
754 Recent glibc declares fchown with __attribute__((warn_unused_result)),
755 and without this change, GCC might complain about discarding
756 fchown's return value.
757
b5641435
JB
7582011-07-16 Juanma Barranquero <lekktu@gmail.com>
759
760 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
761
a8031457
PE
7622011-07-16 Paul Eggert <eggert@cs.ucla.edu>
763
764 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
765
dd889327
LMI
7662011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
767
750c33f7
LMI
768 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
769 it's used from the C level.
770
dd889327
LMI
771 * process.c: Use the same condition for POLL_FOR_INPUT in both
772 keyboard.c and process.c (bug#1858).
773
87e86684
LM
7742011-07-09 Lawrence Mitchell <wence@gmx.li>
775
776 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
777 (Fgnutls_boot): Use it.
778
64348f40
AS
7792011-07-15 Andreas Schwab <schwab@linux-m68k.org>
780
781 * doc.c (Fsubstitute_command_keys): Revert last change.
782
1d698799
LMI
7832011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
784
f863868c
LMI
785 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
786 quotes the next character, and doesn't affect other longer
787 sequences (bug#8935).
788
1d698799
LMI
789 * lread.c (syms_of_lread): Clarify that is isn't only
790 `eval-buffer' and `eval-defun' that's affected by
791 `lexical-binding' (bug#8460).
792
aa4b6df6
EZ
7932011-07-15 Eli Zaretskii <eliz@gnu.org>
794
795 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
796 bidi redisplay when a line includes both an image and is
797 truncated.
798
5d856da6
PE
7992011-07-14 Paul Eggert <eggert@cs.ucla.edu>
800
ad6042bb
PE
801 Fix minor problems found by static checking.
802 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
803 (elsz): Now a signed constant, not a size_t var. We prefer signed
804 types to unsigned, to avoid integer comparison confusion. Without
805 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
806 "cannot optimize loop, the loop counter may overflow", a symptom
807 of the confusion.
f00bbb22 808 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
809 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
810
6468f31c
LMI
8112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
812
49080b10
LMI
813 * search.c (Fre_search_backward): Mention `case-fold-search' in
814 all the re_search_* functions (bug#8138).
815
6468f31c
LMI
816 * keyboard.c (Fopen_dribble_file): Document when the file is
817 closed (bug#8056).
818
c965adc5
EZ
8192011-07-14 Eli Zaretskii <eliz@gnu.org>
820
df9733bf
EZ
821 * bidi.c (bidi_dump_cached_states): Fix format of displaying
822 bidi_cache_idx.
823
0bb23927
EZ
824 Support bidi reordering of display and overlay strings.
825 * xdisp.c (compute_display_string_pos)
826 (compute_display_string_end): Accept additional argument STRING.
827 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
828 (reseat_to_string): Initialize bidi_it->string.s and
829 bidi_it->string.schars.
830 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
831 NULL (avoids a crash in bidi_paragraph_init).
832 Initialize itb.string.lstring.
0bb23927
EZ
833 (init_iterator): Call bidi_init_it only of a valid
834 buffer position was specified. Initialize paragraph_embedding to
835 L2R.
836 (reseat_to_string): Initialize the bidi iterator.
837 (display_string): If we need to ignore text properties of
838 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
839 original value of -1 will not work with bidi.)
840 (compute_display_string_pos): First arg is now struct
841 `text_pos *'; all callers changed. Support display properties on
842 Lisp strings.
843 (compute_display_string_end): Support display properties on Lisp
844 strings.
845 (init_iterator, reseat_1, reseat_to_string): Initialize the
846 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
847 when iterating on a string not from display properties).
640c8776
SM
848 (compute_display_string_pos, compute_display_string_end):
849 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
850 arrow keys.
851 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
852 base_level_stop; instead, set base_level_stop to BEGV.
853 Fixes crashes in vertical-motion.
0bb23927
EZ
854 (next_element_from_buffer): Improve commentary for when
855 the iterator is before prev_stop.
856 (init_iterator): Initialize bidi_p from the default value of
857 bidi-display-reordering, not from buffer-local value. Use the
858 buffer-local value only if initializing for buffer iteration.
859 (handle_invisible_prop): Support invisible properties on strings
860 that are being bidi-reordered.
861 (set_iterator_to_next): Support bidi reordering of C strings and
862 Lisp strings.
863 (next_element_from_string): Support bidi reordering of Lisp
864 strings.
865 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
866 (display_string): Support display of R2L glyph rows.
867 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
868 (init_iterator): Don't initialize it->bidi_p for strings
869 here.
870 (reseat_to_string): Initialize it->bidi_p for strings here.
871 (next_element_from_string, next_element_from_c_string)
872 (next_element_from_buffer): Add xassert's for correspondence
873 between IT's object being iterated and it->bidi_it.string
874 structure.
875 (face_before_or_after_it_pos): Support bidi iteration.
876 (next_element_from_c_string): Handle the case of the first string
877 character that is not the first one in the visual order.
878 (get_visually_first_element): New function, refactored from common
879 parts of next_element_from_buffer, next_element_from_string, and
880 next_element_from_c_string.
881 (tool_bar_lines_needed, redisplay_tool_bar)
882 (display_menu_bar): Force left-to-right direction. Add a FIXME
883 comment for making that be controlled by a user option.
884 (push_it, pop_it): Save and restore the state of the
885 bidi iterator. Save and restore the bidi_p flag.
886 (pop_it): Iterate out of display property for string iteration as
887 well.
888 (iterate_out_of_display_property): Support iteration over strings.
889 (handle_single_display_spec): Set up it->bidi_it for iteration
890 over a display string, and call bidi_init_it.
891 (handle_single_display_spec, next_overlay_string)
892 (get_overlay_strings_1, push_display_prop): Set up the bidi
893 iterator for displaying display or overlay strings.
894 (forward_to_next_line_start): Don't use the shortcut if
895 bidi-iterating.
896 (back_to_previous_visible_line_start): If handle_display_prop
897 pushed the iterator stack, restore the internal state of the bidi
898 iterator by calling bidi_pop_it same number of times.
899 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
900 and we are bidi-iterating, don't decrement the iterator position;
901 instead, set the first_elt flag in the bidi iterator, to produce
902 the same effect.
903 (reseat_1): Remove redundant setting of string_from_display_prop_p.
904 (push_display_prop): xassert that we are iterating a buffer.
905 (push_it, pop_it): Save and restore paragraph_embedding member.
906 (handle_single_display_spec, next_overlay_string)
907 (get_overlay_strings_1, reseat_1, reseat_to_string)
908 (push_display_prop): Set up the `unibyte' member of bidi_it.string
909 correctly. Don't assume unibyte strings are not bidi-reordered.
910 (compute_display_string_pos)
911 (compute_display_string_end): Fix handling the case of C string.
912 (push_it, pop_it): Save and restore from_disp_prop_p.
913 (handle_single_display_spec, push_display_prop): Set the
914 from_disp_prop_p flag.
915 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
916 (pop_it): Call iterate_out_of_display_property only if we are
917 popping after iteration over a string that came from a display
918 property. Fix a typo in popping stretch info. Add an assertion
919 for verifying that the iterator position is in sync with the bidi
920 iterator.
921 (handle_single_display_spec, get_overlay_strings_1)
922 (push_display_prop): Fix initialization of paragraph direction for
923 string when that of the parent object is not yet determined.
924 (reseat_1): Call bidi_init_it to resync the bidi
925 iterator with IT's position. (Bug#7616)
926 (find_row_edges): If ROW->start.pos gives position
927 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
928 (handle_stop, back_to_previous_visible_line_start, reseat_1):
929 Reset the from_disp_prop_p flag.
930 (SAVE_IT, RESTORE_IT): New macros.
931 (pos_visible_p, face_before_or_after_it_pos)
932 (back_to_previous_visible_line_start)
933 (move_it_in_display_line_to, move_it_in_display_line)
934 (move_it_to, move_it_vertically_backward, move_it_by_lines)
935 (try_scrolling, redisplay_window, display_line): Use them when
936 saving a temporary copy of the iterator and restoring it back.
937 (back_to_previous_visible_line_start, reseat_1)
938 (init_iterator): Empty the bidi cache "stack".
939 (move_it_in_display_line_to): If iterator ended up at
940 EOL, but we never saw any buffer positions smaller than
941 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
942 motion in bidi-reordered lines.
943 (move_it_in_display_line_to): Record prev_method and prev_pos
944 immediately before the call to set_iterator_to_next. Fixes cursor
945 motion in bidi-reordered lines with stretch glyphs and strings
946 displayed in margins. (Bug#8133) (Bug#8867)
947 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
948 TO_CHARPOS.
640c8776
SM
949 (pos_visible_p): Support positions in bidi-reordered lines.
950 Save and restore bidi cache.
0bb23927
EZ
951
952 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
953 (bidi_paragraph_info): Delete unused struct.
954 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
955 (bidi_cache_start): New variable.
956 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
957 to zero.
958 (bidi_cache_fetch_state, bidi_cache_search)
959 (bidi_cache_find_level_change, bidi_cache_iterator_state)
960 (bidi_cache_find, bidi_peek_at_next_level)
961 (bidi_level_of_next_char, bidi_find_other_level_edge)
962 (bidi_move_to_visually_next): Compare cache index with
963 bidi_cache_start rather than with zero.
964 (bidi_fetch_char): Accept new argument STRING; all callers
965 changed. Support iteration over a string. Support strings with
966 display properties. Support unibyte strings. Fix the type of
967 `len' according to what STRING_CHAR_AND_LENGTH expects.
968 (bidi_paragraph_init, bidi_resolve_explicit_1)
969 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
970 (bidi_level_of_next_char, bidi_move_to_visually_next):
971 Support iteration over a string.
0bb23927
EZ
972 (bidi_set_sor_type, bidi_resolve_explicit_1)
973 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
974 can now be zero (for strings); special values 0 and -1 were
975 changed to -1 and -2, respectively.
976 (bidi_char_at_pos): New function.
977 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
978 Call it instead of FETCH_MULTIBYTE_CHAR.
979 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
980 initialized to valid values.
981 (bidi_init_it): Don't initialize charpos and bytepos with invalid
982 values.
983 (bidi_level_of_next_char): Allow the sentinel "position" to pass
984 the test for valid cached positions. Fix the logic for looking up
985 the sentinel state in the cache. GCPRO the Lisp string we are
986 iterating.
987 (bidi_push_it, bidi_pop_it): New functions.
988 (bidi_initialize): Initialize the bidi cache start stack pointer.
989 (bidi_cache_ensure_space): New function, refactored from part of
990 bidi_cache_iterator_state. Don't assume the required size is just
991 one BIDI_CACHE_CHUNK away.
992 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
993 (bidi_count_bytes, bidi_char_at_pos): New functions.
994 (bidi_cache_search): Don't assume bidi_cache_last_idx is
995 always valid if bidi_cache_idx is valid.
996 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
997 is valid if it's going to be used.
998 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
999 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1000 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1001 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1002 (bidi_find_other_level_edge, bidi_cache_start_stack):
1003 All variables related to cache indices are now EMACS_INT.
c965adc5 1004
0bb23927
EZ
1005 * dispextern.h (struct bidi_string_data): New structure.
1006 (struct bidi_it): New member `string'. Make flag members be 1-bit
1007 fields, and put them last in the struct.
640c8776
SM
1008 (compute_display_string_pos, compute_display_string_end):
1009 Update prototypes.
0bb23927
EZ
1010 (bidi_push_it, bidi_pop_it): Add prototypes.
1011 (struct iterator_stack_entry): New members bidi_p,
1012 paragraph_embedding, and from_disp_prop_p.
1013 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1014 (bidi_shelve_cache, bidi_unshelve_cache):
1015 Declare prototypes.
0bb23927
EZ
1016
1017 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1018 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1019 and vector-like objects.
1020
1021 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1022 cache around display iteration.
1023
1024 * window.c (Fwindow_end, window_scroll_pixel_based)
1025 (displayed_window_lines, Frecenter): Save and restore the bidi
1026 cache around display iteration.
1027
3bbd2265
LMI
10282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1029
1030 * editfns.c (Fdelete_region): Clarify the use of the named
1031 parameters (bug#6788).
1032
adc47434
MR
10332011-07-14 Martin Rudalics <rudalics@gmx.at>
1034
1035 * indent.c (Fvertical_motion): Set and restore w->pointm when
1036 saving and restoring the window's buffer (Bug#9006).
1037
837c31f8
LMI
10382011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1039
1040 * editfns.c (Fstring_to_char): Clarify just what is returned
1041 (bug#6576). Text by Eli Zaretskii.
1042
ac389d0c
JB
10432011-07-13 Juanma Barranquero <lekktu@gmail.com>
1044
1045 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1046
0be0ce47
EZ
10472011-07-13 Eli Zaretskii <eliz@gnu.org>
1048
1049 * buffer.c (mmap_find): Fix a typo.
1050
cd18e7e3
JB
10512011-07-13 Johan Bockgård <bojohan@gnu.org>
1052
1053 Fix execution of x selection hooks.
1054 * xselect.c (Qx_lost_selection_functions)
1055 (Qx_sent_selection_functions): New vars.
1056 (syms_of_xselect): DEFSYM them.
1057 (x_handle_selection_request): Pass Qx_sent_selection_functions
1058 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1059 (x_handle_selection_clear,x_clear_frame_selections):
1060 Pass Qx_lost_selection_functions rather than
1061 Vx_lost_selection_functions to Frun_hook_with_args.
1062
47ea7f44
PE
10632011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1064
ac389d0c 1065 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1066 The old code sometimes used this field without initializing it.
1067
47ea7f44
PE
1068 * alloc.c (gc_sweep): Don't read past end of array.
1069 In theory, the old code could also have corrupted Emacs internals,
1070 though it'd be very unlikely.
1071
bc985c87
AS
10722011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1073
1074 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1075 argument. (Bug#4026)
bc985c87 1076
0cf34688
LMI
10772011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1078
b3dadd76
LMI
1079 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1080 key" (bug#4257).
1081
0cf34688
LMI
1082 * window.c (Fset_window_start): Doc fix (bug#4199).
1083 (Fset_window_hscroll): Ditto.
1084
270768cd
PE
10852011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1086
077e3dda 1087 Fix minor new problems caught by GCC 4.6.1.
270768cd 1088 * term.c (init_tty): Remove unused local.
490011a6 1089 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1090 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1091 not used otherwise.
270768cd 1092
b1f58454
CY
10932011-07-12 Chong Yidong <cyd@stupidchicken.com>
1094
1095 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1096
22b9578d
LMI
10972011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1098
6e70ab07
LMI
1099 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1100 are the mini-buffer and the echo area (bug#3320).
1101
22b9578d
LMI
1102 * term.c (init_tty): Remove support for supdup, c10 and perq
1103 terminals, which are no longer supported (bug#1482).
1104
8974cc9f
JB
11052011-07-10 Johan Bockgård <bojohan@gnu.org>
1106
1107 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1108
a560d974
JD
11092011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1110
1111 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1112 for non-popups (Bug#3642).
1113
1dae0f0a
AS
11142011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1115
268c2c36 1116 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1117 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1118 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1119 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1120 * data.c (fmod): Likewise.
1121 * dispnew.c (swap_glyphs_in_rows): Likewise.
1122 * emacs.c (memory_warning_signal): Likewise.
1123 * floatfns.c (float_error): Likewise.
1124 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1125 (otf_open, font_otf_capability, generate_otf_features)
1126 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1127 Likewise.
1128 * image.c (pbm_read_file): Likewise.
1129 * indent.c (string_display_width): Likewise.
1130 * intervals.c (check_for_interval, search_for_interval)
1131 (inc_interval_count, count_intervals, root_interval)
1132 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1133 * lread.c (defalias): Likewise.
268c2c36 1134 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1135 * regex.c (set_image_of_range_1, set_image_of_range)
1136 (regex_grow_registers): Likewise.
1137 * sysdep.c (strerror): Likewise.
1138 * termcap.c (valid_filename_p, tprint, main): Likewise.
1139 * tparam.c (main): Likewise.
1140 * unexhp9k800.c (run_time_remap, save_data_space)
1141 (update_file_ptrs, read_header, write_header, calculate_checksum)
1142 (copy_file, copy_rest, display_header): Likewise.
1143 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1144 Likewise.
1145 * xdisp.c (check_it): Likewise.
1146 * xfaces.c (register_color, unregister_color, unregister_colors):
1147 Likewise.
1148 * xfns.c (print_fontset_result): Likewise.
1149 * xrdb.c (member, fatal, main): Likewise.
1150
99033785
PE
11512011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1152
1153 Fix minor problems found by static checking (Bug#9031).
1154 * chartab.c (char_table_set_range, map_sub_char_table):
1155 Remove unused locals.
1156 (uniprop_table): Now static.
1157 * composite.c (_work_char): Remove unused static var.
1158
9cb2ac56
JB
11592011-07-09 Juanma Barranquero <lekktu@gmail.com>
1160
1161 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1162
f25661f0
JD
11632011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1164
1165 * gtkutil.c (qttip_cb): Remove code without function.
1166
8278c4fe
EZ
11672011-07-09 Eli Zaretskii <eliz@gnu.org>
1168
1169 * w32.c (pthread_sigmask): New stub.
1170
1692ae2d 11712011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1172
8a6ebd58 1173 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1174 sigprocmask is portable only for single-threaded applications, and
1175 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1176 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1177 (LIBES): Use it.
1178 * callproc.c (Fcall_process):
1179 * process.c (create_process):
1180 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1181 Use pthread_sigmask, not sigprocmask.
123403e4 1182
1b854618
JD
11832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1184
1185 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1186 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1187 wrong (Bug#8591).
1188
3fe4b549
JD
11892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1190
0ce7e563
JD
1191 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1192 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1193 (xg_hide_tooltip): Fix comment.
1194
3fe4b549
JD
1195 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1196 in registerServicesMenuSendTypes.
1197 (validRequestorForSendType): Don't check ns_return_types.
1198
1199 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1200 ns_return_type.
1201
5df75e47
JR
12022011-07-08 Jason Rumney <jasonr@gnu.org>
1203
1204 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1205 frame struct members of non-existent frames (Bug#6284).
1206
699c10bd
JD
12072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1208
4393663b
JD
1209 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1210 variable firstTime not needed on OSX >= 10.6.
1211 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1212 >= 10.5. Use setKnobProportion, setDoubleValue.
1213
1214 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1215 (MAC_OS_X_VERSION_10_5): Define if not defined.
1216 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1217 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1218 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1219
1220 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1221 cString and lossyCString on OSX >= 10.4
1222
1223 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1224 sizeToFit on OSX >= 10.2.
1225
1226 * nsimage.m (allocInitFromFile): Don't use deprecated method
1227 bestRepresentationForDevice on OSX >= 10.6.
1228
1229 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1230 to avoid warning.
1231
1232 * emacs.c: Declare unexec_init_emacs_zone.
1233
a63e0781
JD
1234 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1235
699c10bd
JD
1236 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1237
1238 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1239 on svcsMenu (Bug#8842).
1240
1241 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1242 ns_return_types.
1243 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1244
1245 * nsterm.m (QUTF8_STRING): Declare.
1246 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1247 (validRequestorForSendType): Return type is (id).
1248 Change indexOfObjectIdenticalTo to indexOfObject.
1249 Check if we have local selection before returning self (Bug#8842).
1250 (writeSelectionToPasteboard): Put local selection into paste board
1251 if we have a local selection (Bug#8842).
1252 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1253
1254 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1255 (ns_get_local_selection): Declare.
1256
54e10184
LMI
12572011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1258
9888ff71
LMI
1259 * keymap.c (describe_map_tree): Don't insert a double newline at
1260 the end of the buffer (bug#1169) and return whether we inserted
1261 something.
1262
54e10184
LMI
1263 * callint.c (Fcall_interactively): Change "reading args" to
1264 "providing args" to try to clarify what it does (bug#1010).
1265
15fa4783
KH
12662011-07-07 Kenichi Handa <handa@m17n.org>
1267
1268 * composite.c (composition_compute_stop_pos): Ignore a static
1269 composition starting before CHARPOS (Bug#8915).
1270
1271 * xdisp.c (handle_composition_prop): Likewise.
1272
a8815b00
EZ
12732011-07-07 Eli Zaretskii <eliz@gnu.org>
1274
1275 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1276 (Bug#9015)
1277
ef7b981d 12782011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1279
1280 * character.h (unicode_category_t): New enum type.
1281
1282 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1283 (Qchar_code_property_table): New variable.
1284 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1285 (UNIPROP_COMPRESSED_FORM_P): New macros.
1286 (char_table_ascii): Uncompress the compressed values.
1287 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1288 Uncompress the compressed values.
ac389d0c 1289 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1290 (char_table_ref_and_range): Uncompress the compressed values.
1291 (sub_char_table_set): New arg is_uniprop. Callers changed.
1292 Uncompress the compressed values.
1293 (sub_char_table_set_range): Args changed. Callers changed.
1294 (char_table_set_range): Adjuted for the above change.
1295 (map_sub_char_table): Delete args default_val and parent. Add arg
1296 top. Give decoded values to a Lisp function.
640c8776 1297 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1298 values to a Lisp function. Gcpro more variables.
1299 (uniprop_table_uncompress)
1300 (uniprop_decode_value_run_length): New functions.
1301 (uniprop_decoder, uniprop_decoder_count): New variables.
1302 (uniprop_get_decoder, uniprop_encode_value_character)
1303 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1304 New functions.
1305 (uniprop_encoder, uniprop_encoder_count): New variables.
1306 (uniprop_get_encoder, uniprop_table)
1307 (Funicode_property_table_internal, Fget_unicode_property_internal)
1308 (Fput_unicode_property_internal): New functions.
1309 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1310 Sunicode_property_table_internal, Sget_unicode_property_internal,
1311 and Sput_unicode_property_internal. Defvar_lisp
1312 char-code-property-alist.
1313
640c8776 1314 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1315 Vunicode_category_table.
1316
640c8776 1317 * font.c (font_range): Adjust for the change of
c805dec0
KH
1318 Vunicode_category_table.
1319
76b397fb
DN
13202011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1321
1322 * m/iris4d.h: Remove file, move contents ...
1323 * s/irix6-5.h: ... here.
1324
22b4128e
PE
13252011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1328 * alloc.c (mark_buffer):
1329 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1330 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1331 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1332 This isn't true in general, and it's particularly not true
1333 if Emacs is configured with --with-wide-int.
1334 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1335 New macros, used in the buffer.c change.
1336
869795d6
JD
13372011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1338
1339 * xsettings.c: Use both GConf and GSettings if both are available.
1340 (store_config_changed_event): Add comment.
1341 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1342 (store_tool_bar_style_changed): New functions.
1343 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1344 (struct xsettings): Move font inside HAVE_XFT.
1345 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1346 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1347 Move inside HAVE_XFT.
640c8776 1348 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1349 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1350 also.
1351 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1352 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1353 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1354 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1355 (parse_settings): Move check for font inside HAVE_XFT.
1356 (read_settings, apply_xft_settings): Add comment.
1357 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1358 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1359 call store_font_name_changed.
1360 (xft_settings_event): Add comment.
1361 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1362 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1363 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1364 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1365 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1366 (xsettings_get_system_font, xsettings_get_system_normal_font):
1367 Add comment.
869795d6 1368
d8ed26bd
PE
13692011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 Random fixes. E.g., (random) never returned negative values.
1372 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1373 subseconds part to the entropy, as that's a bit more random.
1374 Prefer signed to unsigned, since the signedness doesn't matter and
1375 in general we prefer signed. When given a limit, use a
1376 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1377 latter isn't right if USE_2_TAGS_FOR_INTS.
1378 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1379 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1380
cabf1cac
SM
13812011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1382
1383 * textprop.c (text_property_stickiness):
1384 Obey Vtext_property_default_nonsticky.
1385 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1386 * w32fns.c (syms_of_w32fns):
1387 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1388
6e9b2be9
PE
13892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1390
1391 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1392 This is more efficient than Ffile_directory_p and avoids a minor race.
1393
90186c68
LMI
13942011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1395
7c301272
LMI
1396 * buffer.c (Foverlay_put): Say what the return value is
1397 (bug#7835).
1398
c4f2d8d4
LMI
1399 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1400 is a directory before asking whether to use the file name
1401 (bug#7564).
ad637907
LMI
1402 (barf_or_query_if_file_exists): Make the "File is a directory"
1403 error be more correct.
c4f2d8d4 1404
90186c68
LMI
1405 * fns.c (Frequire): Remove the mention of the .gz files, since
1406 that's installation-specific, but keep the mention of
1407 `get-load-suffixes'.
1408
da64016e
PE
14092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1412 Report string overflow if the output is too long.
1413
7d47b580
JB
14142011-07-04 Juanma Barranquero <lekktu@gmail.com>
1415
a555cb87
JB
1416 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1417 (syms_of_gnutls): Remove duplicate DEFSYM for
1418 Qgnutls_bootprop_verify_hostname_error, an error for
1419 Qgnutls_bootprop_verify_error (which is no longer used).
1420
7d47b580
JB
1421 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1422 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1423 Also (re)move comments that are misplaced or no longer relevant.
1424
1e49bfab
LMI
14252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1426
1427 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1428
1485f4c0
CY
14292011-07-03 Chong Yidong <cyd@stupidchicken.com>
1430
1431 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1432 and background color parameters if they have been changed.
1433
a9ab721e
LMI
14342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1435
1436 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1437
cf7cff57
PE
14382011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1439
2e13213d
PE
1440 * xsettings.c (SYSTEM_FONT): Define only when used.
1441 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1442
cf7cff57
PE
1443 * keymap.c (access_keymap_1): Now static.
1444
7a8e04f7
CY
14452011-07-02 Chong Yidong <cyd@stupidchicken.com>
1446
1447 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1448 leave any prefix arg for the up event (Bug#1586).
1449
61352f62
LMI
14502011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1451
69bb1ef7
LMI
1452 * lread.c (syms_of_lread): Mention single symbols defined by
1453 `defvar' or `defconst' (bug#7154).
1454
61352f62 1455 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1456 (Frequire): Mention get-load-suffixes.
61352f62 1457
28545e04
MR
14582011-07-02 Martin Rudalics <rudalics@gmx.at>
1459
1460 * window.h (window): Remove clone_number slot.
1461 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1462 Remove.
1463 (make_parent_window, make_window, saved_window)
1464 (Fset_window_configuration, save_window_save): Don't deal with
1465 clone numbers.
1466 * buffer.c (Qclone_number): Remove declaration.
1467 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1468
3349e122
SM
14692011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1470
1471 Add multiple inheritance to keymaps.
1472 * keymap.c (Fmake_composed_keymap): New function.
1473 (Fset_keymap_parent): Simplify.
1474 (fix_submap_inheritance): Remove.
1475 (access_keymap_1): New function extracted from access_keymap to handle
1476 embedded parents and handle lists of maps.
1477 (access_keymap): Use it.
1478 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1479 (Fcopy_keymap): Handle embedded parents.
1480 (Fcommand_remapping, define_as_prefix): Simplify.
1481 (Fkey_binding): Simplify.
1482 (syms_of_keymap): Move minibuffer-local-completion-map,
1483 minibuffer-local-filename-completion-map,
1484 minibuffer-local-must-match-map, and
1485 minibuffer-local-filename-must-match-map to Elisp.
1486 (syms_of_keymap): Defsubr make-composed-keymap.
1487 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1488 (parse_menu_item): Trivial simplification.
1489
3279eb87
GM
14902011-07-01 Glenn Morris <rgm@gnu.org>
1491
1492 * Makefile.in (SETTINGS_LIBS): Fix typo.
1493
4550efdf
KI
14942011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1495
1496 * coding.c (Fencode_coding_string): Record the last coding system
1497 used, as the function doc string says (bug#8738).
1498
0949d2b6
JD
14992011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1500
1501 * xsettings.c (store_monospaced_changed): Take new font as arg and
1502 check for change against current_mono_font.
1503 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1504 (emacs_settings_constructor, emacs_settings_get_property)
1505 (emacs_settings_set_property, emacs_settings_class_init)
1506 (emacs_settings_init, gsettings_obj): Remove.
1507 (something_changedCB): New function for HAVE_GSETTINGS.
1508 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1509 with value as argument.
1510 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1511 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1512 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1513 "changed".
1514
1515 * xgselect.c: Add defined (HAVE_GSETTINGS).
1516 (xgselect_initialize): Ditto.
1517
1518 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1519 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1520 xg_select.
1521
bbc6b304
PE
15222011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * eval.c (struct backtrace): Simplify and port the data structure.
1525 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1526 signed bit field, as this assumption is not portable and it makes
1527 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1528 "char debug_on_exit : 1" as this is not portable either; instead,
1529 use the portable "unsigned int debug_on_exit : 1". Remove unused
1530 member evalargs. Remove obsolete comments about cc bombing out.
1531
9851bfc5
JD
15322011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1533
51bb811f 1534 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1535 Let HAVE_GSETTINGS override HAVE_GCONF.
1536 (store_monospaced_changed): New function.
1537 (EMACS_SETTINGS): A new type derived from GObject to handle
1538 GSettings notifications.
1539 (emacs_settings_constructor, emacs_settings_get_property)
1540 (emacs_settings_set_property, emacs_settings_class_init):
1541 New functions.
1542 (gsettings_client, gsettings_obj): New variables.
1543 (GSETTINGS_SCHEMA): New define.
1544 (something_changedCB): Call store_monospaced_changed.
1545 (init_gsettings): New function.
1546 (xsettings_initialize): Call init_gsettings.
1547 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1548 to NULL.
1549
640c8776 1550 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1551 GCONF_CFLAGS/LIBS.
1552
5386012d
MR
15532011-06-29 Martin Rudalics <rudalics@gmx.at>
1554
1555 * window.c (resize_root_window, grow_mini_window)
1556 (shrink_mini_window): Rename Qresize_root_window to
1557 Qwindow_resize_root_window and Qresize_root_window_vertically to
1558 Qwindow_resize_root_window_vertically.
1559
f13e0b08
PE
15602011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1563
94515237
JB
15642011-06-27 Juanma Barranquero <lekktu@gmail.com>
1565
1566 * makefile.w32-in: Redesign dependencies so they reflect more
1567 clearly which files are directly included by each source file,
1568 and not through other includes.
1569
e43b6e43
MR
15702011-06-27 Martin Rudalics <rudalics@gmx.at>
1571
1572 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1573 (sort_overlays, overlay_strings): When an overlay's clone number
1574 matches the window's clone number process the overlay even if
1575 the overlay's window property doesn't match the current window.
1576
d68443dc
MR
1577 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1578 (Fwindow_hchild): Rename to Fwindow_left_child.
1579 (Fwindow_next): Rename to Fwindow_next_sibling.
1580 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1581 (resize_window_check): Rename to window_resize_check.
1582 (resize_window_apply): Rename to window_resize_apply.
1583 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1584 (Fdelete_other_windows_internal, resize_frame_windows)
1585 (Fsplit_window_internal, Fdelete_window_internal)
1586 (grow_mini_window, shrink_mini_window)
1587 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1588
c7e73be5
JD
15892011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1590
1591 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1592 (emacs_fixed_set_min_size): Remove.
1593 (emacs_fixed_new): Take frame as argument.
1594
1595 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1596 (_EmacsFixedPrivate): Remove minwidth/height.
1597 Add struct frame *f.
1598 (emacs_fixed_init): Initialize priv->f.
1599 (get_parent_class, emacs_fixed_set_min_size): Remove.
1600 (emacs_fixed_new): Set priv->f to argument.
1601 (emacs_fixed_get_preferred_width)
1602 (emacs_fixed_get_preferred_height): Use min_width/height from
1603 frames size_hint to set minimum and natural (Bug#8919).
1604 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1605 and use min_width/height from frames size_hint to set
1606 min_width/height (Bug#8919).
1607
1608 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1609 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1610 Fix indentation.
c7e73be5 1611
cf99dcf8
EZ
16122011-06-26 Eli Zaretskii <eliz@gnu.org>
1613
1614 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1615 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1616 called at ZV.
1617
029529ac
CY
16182011-06-26 Chong Yidong <cyd@stupidchicken.com>
1619
1620 * process.c (wait_reading_process_output): Bypass select if
1621 waiting for a cell while ignoring keyboard input, and input is
1622 pending. Suggested by Jan Djärv (Bug#8869).
1623
7a7ef429
PE
16242011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 Use gnulib's dup2 module instead of rolling our own.
1627 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1628
11fdef7d 16292011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1630
1631 * dispnew.c (scrolling_window): Before scrolling, turn off a
1632 mouse-highlight in the window being scrolled.
1633
cd3520a4
JB
16342011-06-24 Juanma Barranquero <lekktu@gmail.com>
1635
1636 Move DEFSYM to lisp.h and use everywhere.
1637
1638 * character.h (DEFSYM): Move declaration...
1639 * lisp.h (DEFSYM): ...here.
1640
1641 * gnutls.c:
1642 * minibuf.c:
1643 * w32menu.c:
1644 * w32proc.c:
1645 * w32select.c: Don't include character.h.
1646
1647 * alloc.c (syms_of_alloc):
1648 * buffer.c (syms_of_buffer):
1649 * bytecode.c (syms_of_bytecode):
1650 * callint.c (syms_of_callint):
1651 * casefiddle.c (syms_of_casefiddle):
1652 * casetab.c (init_casetab_once):
1653 * category.c (init_category_once, syms_of_category):
1654 * ccl.c (syms_of_ccl):
1655 * cmds.c (syms_of_cmds):
1656 * composite.c (syms_of_composite):
1657 * dbusbind.c (syms_of_dbusbind):
1658 * dired.c (syms_of_dired):
1659 * dispnew.c (syms_of_display):
1660 * doc.c (syms_of_doc):
1661 * editfns.c (syms_of_editfns):
1662 * emacs.c (syms_of_emacs):
1663 * eval.c (syms_of_eval):
1664 * fileio.c (syms_of_fileio):
1665 * fns.c (syms_of_fns):
1666 * frame.c (syms_of_frame):
1667 * fringe.c (syms_of_fringe):
1668 * insdel.c (syms_of_insdel):
1669 * keymap.c (syms_of_keymap):
1670 * lread.c (init_obarray, syms_of_lread):
1671 * macros.c (syms_of_macros):
1672 * msdos.c (syms_of_msdos):
1673 * print.c (syms_of_print):
1674 * process.c (syms_of_process):
1675 * search.c (syms_of_search):
1676 * sound.c (syms_of_sound):
1677 * syntax.c (init_syntax_once, syms_of_syntax):
1678 * terminal.c (syms_of_terminal):
1679 * textprop.c (syms_of_textprop):
1680 * undo.c (syms_of_undo):
1681 * w32.c (globals_of_w32):
1682 * window.c (syms_of_window):
1683 * xdisp.c (syms_of_xdisp):
1684 * xfaces.c (syms_of_xfaces):
1685 * xfns.c (syms_of_xfns):
1686 * xmenu.c (syms_of_xmenu):
1687 * xsettings.c (syms_of_xsettings):
1688 * xterm.c (syms_of_xterm): Use DEFSYM.
1689
4228cf16
TZ
16902011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1691
cd3520a4 1692 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1693
7fcccf1e
PE
16942011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1695
7efb4e0e
PE
1696 Integer and buffer overflow fixes (Bug#8873).
1697
ff5844ad
PE
1698 * print.c (printchar, strout): Check for string overflow.
1699 (PRINTPREPARE, printchar, strout):
1700 Don't set size unless allocation succeeds.
1701
90532f02
PE
1702 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1703 for sizes. Check for string overflow more accurately.
1704 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1705
6d84508d
PE
1706 * macros.c: Integer and buffer overflow fixes.
1707 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1708 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1709 Use ptrdiff_t, not int, for sizes.
1710 Don't increment bufsize until after realloc succeeds.
1711 Check for size-calculation overflow.
1712 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1713
437b2cb4
PE
1714 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1715
8b9ac8b4
PE
1716 * lread.c: Integer overflow fixes.
1717 (read_integer): Radix is now EMACS_INT, not int,
1718 to improve quality of diagnostics for out-of-range radices.
1719 Calculate buffer size correctly for out-of-range radices.
1720 (read1): Check for integer overflow in radices, and in
1721 read-circle numbers.
82cb60d3
PE
1722 (read_escape): Avoid int overflow.
1723 (Fload, openp, read_buffer_size, read1)
1724 (substitute_object_recurse, read_vector, read_list, map_obarray):
1725 Use ptrdiff_t, not int, for sizes.
1726 (read1): Use EMACS_INT, not int, for sizes.
20270765 1727 Check for size overflow.
8b9ac8b4 1728
7fcccf1e
PE
1729 * image.c (cache_image): Check for size arithmetic overflow.
1730
bfbbd7e7
PE
1731 * lread.c: Integer overflow issues.
1732 (saved_doc_string_size, saved_doc_string_length)
1733 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1734 Now ptrdiff_t, not int.
1735 (read1): Don't assume doc string length fits in int. Check for
1736 out-of-range doc string lengths.
1737 (read_list): Don't assume file position fits in int.
39019e54 1738 (read_escape): Check for hex character overflow.
bfbbd7e7 1739
4e323265
LL
17402011-06-22 Leo Liu <sdl.web@gmail.com>
1741
1742 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1743 Move to minibuffer.el.
1744
85fece3e
PE
17452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1746
20b84ce9 1747 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1748 The following patches are for when GLYPH_DEBUG && !XASSERT.
1749 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1750 * dispnew.c (flush_stdout):
1751 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1752 Mark as externally visible.
1753 * dispnew.c (check_window_matrix_pointers): Now static.
1754 * dispnew.c (window_to_frame_vpos):
1755 * xfns.c (unwind_create_frame):
1756 * xterm.c (x_check_font): Remove unused local.
1757 * scroll.c (CHECK_BOUNDS):
1758 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1759 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1760 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1761 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1762 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1763 Now static.
1764 (debug_method_add): Use va_list and vsprintf rather than relying
1765 on undefined behavior with wrong number of arguments.
1766 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1767 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1768 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1769 since we're not interested in debugging glyphs with old libraries.
1770 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1771 GCC 4.6.0's static checking.
1772
0766b489
PE
17732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1774
31fd4b32
PE
1775 Integer overflow and signedness fixes (Bug#8873).
1776 A few related buffer overrun fixes, too.
1777
b79e8648
PE
1778 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1779
0766b489
PE
1780 * dispextern.h (struct face.stipple):
1781 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1782 (x_bitmap_mask, x_allocate_bitmap_record)
1783 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1784 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1785 (x_create_bitmap_from_xpm_data):
1786 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1787 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1788 (.bitmaps_last):
1789 * xfaces.c (load_pixmap):
1790 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1791 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1792 (.bitmaps_last, struct x_output.icon_bitmap):
1793 Use ptrdiff_t, not int, for bitmap indexes.
1794 (x_allocate_bitmap_record): Check for size overflow.
1795 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1796
b081724f
PE
1797 Use ptrdiff_t, not int, for overlay counts.
1798 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1799 * editfns.c (overlays_around, get_pos_property):
1800 * textprop.c (get_char_property_and_overlay):
1801 * xdisp.c (next_overlay_change, note_mouse_highlight):
1802 * xfaces.c (face_at_buffer_position):
21514da7
PE
1803 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1804 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1805 (Fnext_overlay_change, Fprevious_overlay_change)
1806 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1807 Use ptrdiff_t, not int, for sizes.
21514da7 1808 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1809
3de73e5e
PE
1810 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1811
2606c57b
PE
1812 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1813 (x_session_initialize): Do not assume string length fits in int.
1814
aaafe47a
PE
1815 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1816 This is unlikely, but can occur if DPI is outlandish.
1817
2674ddc8 1818 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1819 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1820
28154962
PE
1821 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1822 * xrdb.c (magic_file_p, search_magic_path):
1823 Omit last arg SUFFIX; it was always 0. All callers changed.
1824 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1825
7de51af5
PE
1826 * xfont.c (xfont_match): Avoid need for strlen.
1827
25ed6cc3
PE
1828 * xfns.c: Don't assume strlen fits in int.
1829 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1830
4eab31dd
PE
1831 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1832 not unsigned long, as we prefer signed integers. All callers changed.
1833 Detect integer overflow in repeat count.
1834 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1835 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1836
171e2a58
PE
1837 * termcap.c: Don't assume sizes fit in int and never overflow.
1838 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1839 (gobble_line): Check for size-calculation overflow.
1840
ad39faca 1841 * minibuf.c (Fread_buffer):
6e5bb2dc 1842 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1843 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1844 Don't assume string length fits in int.
1845
52c61c22 1846 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1847 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1848
b5b8c9e5
PE
1849 * font.c: Don't assume string length fits in int.
1850 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1851 Use ptrdiff_t, not int.
ccd6111c
PE
1852 (font_intern_prop): Don't assume string length fits in int.
1853 Don't assume integer property fits in fixnum.
1854 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1855
882f0d81 1856 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1857 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1858 Reformulate so as not to need the command string.
1859 Invoke gzip -cd rather than gunzip, as it's more portable.
1860 (lock_info_type, lock_file_1, lock_file):
1861 Don't assume pid_t and time_t fit in unsigned long.
1862 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1863 (current_lock_owner): Prefer signed type for sizes.
1864 Use memcpy, not strncpy, where memcpy is what is really wanted.
1865 Don't assume (via atoi) that time_t and pid_t fit in int.
1866 Check for time_t and/or pid_t out of range, e.g., via a network share.
1867 Don't alloca where an auto var works fine.
1868
93f4cf88
PE
1869 * fileio.c: Fix some integer overflow issues.
1870 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1871 Don't assume string length fits in int.
1872 (directory_file_name): Don't assume string length fits in long.
1873 (make_temp_name): Don't assume pid fits in int, or that its print
1874 length is less than 20.
1875
f3e92b69
PE
1876 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1877
1bfdaf10
PE
1878 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1879
35016e9a
PE
1880 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1881
3d1e65a1
PE
1882 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1883 We prefer signed integers, even for size calculations.
1884
0b963a93
PE
1885 * emacs.c: Don't assume string length fits in 'int'.
1886 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1887 (main): Don't invoke strlen when not needed.
1888
573f4b54
PE
1889 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1890 (XD_DEBUG_MESSAGE): Don't waste a byte.
1891
989f33ba
PE
1892 * callproc.c (getenv_internal_1, getenv_internal)
1893 (Fgetenv_internal):
965d34eb
PE
1894 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1895
e4d29b33
PE
1896 * lread.c (invalid_syntax): Omit length argument.
1897 All uses changed. This doesn't fix a bug, but it simplifies the
1898 code away from its former Hollerith-constant appearance, and it's
1899 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1900 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1901
eb49b136
PE
1902 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1903 This didn't break anything, but it didn't help either.
1904 It's confusing to put a bogus integer in a place where the actual
1905 value does not matter.
9f62aeb1 1906 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1907 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1908
15375a22
PE
1909 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1910 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1911 implementation.
b61cc01c
PE
1912 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1913 We prefer signed types, and the value cannot exceed the EMACS_INT
1914 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1915 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1916 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1917 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1918
53b2623d
PE
1919 * indent.c (sane_tab_width): New function.
1920 (current_column, scan_for_column, Findent_to, position_indentation)
1921 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1922 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1923
51cab52b 1924 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1925
f2ed8a70
PE
1926 * lisp.h (lint_assume): New macro.
1927 * composite.c (composition_gstring_put_cache):
1928 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1929
abe80cc6
PE
1930 * editfns.c, insdel.c:
1931 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1932
b02c740e
PE
1933 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1934
ebc96716
PE
1935 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1936
b4e50fa0 1937 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1938 Use much-faster test for byte-length change.
311d5d7c 1939 Don't assume string byte-length fits in 'int'.
a4cf38e4 1940 Check that character arg fits in 'int'.
85461888 1941 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1942
c0c1ee9f
PE
1943 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1944
a498d7f4
PE
1945 * fns.c (concat): Catch string overflow earlier.
1946 Do not rely on integer wraparound.
1947
51cab52b
PE
1948 * dispextern.h (struct it.overlay_strings_charpos)
1949 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1950 * xdisp.c (forward_to_next_line_start)
1951 (back_to_previous_visible_line_start)
1952 (reseat_at_next_visible_line_start, next_element_from_buffer):
1953 Don't arbitrarily truncate the value of 'selective' to int.
1954
76031fad
PE
1955 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1956
5eb55db9
PE
1957 * composite.c: Don't truncate sizes to 'int'.
1958 (composition_gstring_p, composition_reseat_it)
1959 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1960 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1961 not EMACS_UINT, for indexes.
5eb55db9 1962
0703a717
PE
1963 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1964
d6202519
PE
1965 * buffer.c: Include <verify.h>.
1966 (struct sortvec.priority, struct sortstr.priority):
8961a454 1967 Now EMACS_INT, not int.
c20998a7 1968 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1969 (struct sortstr.size, record_overlay_string)
1970 (struct sortstrlist.size, struct sortlist.used):
1971 Don't truncate size to int.
1972 (record_overlay_string): Check for size-calculation overflow.
d6202519 1973 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1974
d5a19415
JM
19752011-06-22 Jim Meyering <meyering@redhat.com>
1976
029529ac 1977 Don't leak an XBM-image-sized buffer
d5a19415
JM
1978 * image.c (xbm_load): Free the image buffer after using it.
1979
a9041e6c
PE
19802011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 Port to Sun C.
1983 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1984 that Sun C diagnosed.
1985 * fns.c (secure_hash): Fix pointer signedness issue.
1986 * intervals.c (static_offset_intervals): New function.
1987 (offset_intervals): Use it.
1988
7f3f739f
LL
19892011-06-21 Leo Liu <sdl.web@gmail.com>
1990
1991 * deps.mk (fns.o):
1992 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1993 sha512.h.
1994
1995 * fns.c (secure_hash): Rename from crypto_hash_function and change
1996 the first arg to accept symbols.
5b66d427 1997 (Fsecure_hash): New primitive.
7f3f739f
LL
1998 (syms_of_fns): New symbols.
1999
76147d94
DD
20002011-06-20 Deniz Dogan <deniz@dogan.se>
2001
2002 * process.c (Fset_process_buffer): Clarify return value in
2003 docstring.
2004
7d7d0045
CY
20052011-06-18 Chong Yidong <cyd@stupidchicken.com>
2006
2007 * dispnew.c (add_window_display_history): Use BVAR.
2008
2009 * xdisp.c (debug_method_add): Use BVAR.
2010 (check_window_end, dump_glyph_matrix, dump_glyph)
2011 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2012
2013 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2014 Likewise.
2015
2016 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2017 check till after the cache is created in init_frame_faces.
2018
ff2bc410
SM
20192011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2020
2021 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2022
28177add
PE
20232011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2024
dd3482fe
PE
2025 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2026 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2027 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2028
393d71f3 2029 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2030 * fileio.c (Finsert_file_contents):
2031 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2032 Remove the old (too-loose) buffer overflow checks.
2033 They weren't needed, since make_gap checks for buffer overflow.
2034 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2035 The old code merely checked for Emacs fixnum overflow, and relied
2036 on undefined (wraparound) behavior. The new code avoids undefined
2037 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2038
2e6813b0 2039 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2040 Tune. Don't use wider integers than needed. Don't use alloca.
2041 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2042
599a9e4f
PE
2043 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2044
99561444
PE
2045 * insdel.c, lisp.h (buffer_overflow): New function.
2046 (insert_from_buffer_1, replace_range, replace_range_2):
2047 * insdel.c (make_gap_larger):
2048 * editfns.c (Finsert_char):
2049 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2050
28177add
PE
2051 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2052
e69dafad
PE
20532011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2054
a7af7fde 2055 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2056
b1c46f02
PE
2057 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2058 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2059
e69dafad
PE
2060 * fileio.c: Don't assume EMACS_INT fits in off_t.
2061 (emacs_lseek): New static function.
2062 (Finsert_file_contents, Fwrite_region): Use it.
2063 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2064
566684ea
PE
2065 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2066
e6966cd6
PE
2067 * fns.c: Don't overflow int when computing a list length.
2068 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2069 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2070 truncation on 64-bit hosts. Check for QUIT every
2071 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2072 faster and is responsive enough.
2073 (Flength): Report an error instead of overflowing an integer.
2074 (Fsafe_length): Return a float if the value is not representable
2075 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2076 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2077 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2078
dd0b0efb
PE
2079 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2080 (header_size, word_size): New constants.
2081 (allocate_vectorlike): Don't check size overflow here.
2082 (allocate_vector): Check it here instead, since this is the only
2083 caller of allocate_vectorlike that could cause overflow.
2084 Check that the new vector's length is representable as a fixnum.
2085
86fe5cfe
PE
2086 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2087 The previous code was bogus. For example, next_almost_prime (32)
2088 returned 39, which is undesirable as it is a multiple of 3; and
2089 next_almost_prime (24) returned 25, which is a multiple of 5 so
2090 why was the code bothering to check for multiples of 7?
2091
80e88859
PE
2092 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2093
4a2f0ad6
PE
2094 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2095
f66c7cf8
PE
2096 Variadic C functions now count arguments with ptrdiff_t.
2097 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2098 Back then I didn't know that the Emacs coding style prefers signed int.
2099 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2100 were being counted with int, which may truncate counts on 64-bit
2101 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2102 * lisp.h (struct Lisp_Subr.function.aMANY)
2103 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2104 Arg counts are now ptrdiff_t, not size_t.
2105 All variadic functions and their callers changed accordingly.
2106 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2107 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2108 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2109 * callint.c (Fcall_interactively): Check arg count for overflow,
2110 to avoid potential buffer overrun. Use signed char, not 'int',
2111 for 'varies' array, so that we needn't bother to check its size
2112 calculation for overflow.
2113 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2114 * eval.c (apply_lambda):
2115 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2116 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2117 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2118
a1759b76
PE
2119 * callint.c (Fcall_interactively): Don't use index var as event count.
2120
d96be9fc
PE
2121 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2122 * mem-limits.h (SIZE): Remove; no longer used.
2123
a690a978 2124 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2125
578c21e6
PE
2126 Remove unnecessary casts.
2127 * xterm.c (x_term_init):
2128 * xfns.c (x_set_border_pixel):
2129 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2130 These aren't needed now that we assume ANSI C.
2131
96f53c6c
PE
2132 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2133 It's more likely to cause problems (due to unsigned overflow)
2134 than to cure them.
2135
83c77d31
PE
2136 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2137
ee2079f1
PE
2138 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2139
6da65536
PE
2140 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2141
7147c4a4
PE
2142 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2143
193e32d9
PE
2144 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2145
e5533da6
PE
2146 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2147
9910e595
PE
2148 GLYPH_CODE_FACE returns EMACS_INT, not int.
2149 * dispextern.h (merge_faces):
2150 * xfaces.c (merge_faces):
01103c44
PE
2151 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2152 Don't assume EMACS_INT fits in int.
9910e595 2153
2638320e
PE
2154 * character.h (CHAR_VALID_P): Remove unused parameter.
2155 * fontset.c, lisp.h, xdisp.c: All uses changed.
2156
045eb8d9
PE
2157 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2158
c1f134b5
PE
2159 * fns.c (concat): Minor tuning based on overflow analysis.
2160 This doesn't fix any bugs. Use int to hold character, instead
2161 of constantly refetching from Emacs object. Use XFASTINT, not
2162 XINT, for value known to be a character. Don't bother comparing
2163 a single byte to 0400, as it's always less.
2164
395fcb93 2165 * floatfns.c (Fexpt):
327eeec8
PE
2166 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2167
abbd3d23
PE
2168 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2169 for characters.
2170
684a03ef
PE
2171 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2172
0fed43f3
PE
2173 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2174 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2175 incorrectly succeed when S was a string, because 4294967386 was
2176 truncated before it was used.
2177
8fd02eb7
PE
2178 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2179 Otherwise, an out-of-range integer could cause undefined behavior
2180 on a 64-bit host.
2181
f8c86b69
PE
2182 * composite.c: Use int, not EMACS_INT, for characters.
2183 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2184 EMACS_INT, for values that are known to be in character range.
2185 This doesn't fix any bugs but is the usual style inside Emacs and
2186 may generate better code on 32-bit machines.
2187
34206dd2
PE
2188 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2189 This is for reasons similar to the recent CHAR_STRING fix.
2190 * charset.c (Fencode_char): Check that character arg is actually
2191 a character. Pass an int to ENCODE_CHAR.
2192 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2193 wider than 'int', as a compile-time check to prevent future regressions
2194 in this area.
2195
c5958d4c 2196 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2197
2198 Make sure a 64-bit char is never passed to CHAR_STRING.
2199 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2200 by silently ignoring the top 32 bits, allowing some values
2201 that were far too large to be valid characters.
2202 * character.h: Include <verify.h>.
2203 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2204 arguments are no wider than unsigned, as a compile-time check
2205 to prevent future regressions in this area.
2206 * data.c (Faset):
01103c44 2207 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2208 (Fsubst_char_in_region):
2209 * fns.c (concat):
2210 * xdisp.c (decode_mode_spec_coding):
2211 Adjust to CHAR_STRING's new requirement.
2212 * editfns.c (Finsert_char, Fsubst_char_in_region):
2213 * fns.c (concat): Check that character args are actually
2214 characters. Without this test, these functions did the wrong
2215 thing with wildly out-of-range values on 64-bit hosts.
2216
d37ca623
PE
2217 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2218 These casts should not be needed on 32-bit hosts, either.
2219 * keyboard.c (read_char):
2220 * lread.c (Fload): Remove casts to unsigned.
2221
ea204efb
PE
2222 * lisp.h (UNSIGNED_CMP): New macro.
2223 This fixes comparison bugs on 64-bit hosts.
2224 (ASCII_CHAR_P): Use it.
2225 * casefiddle.c (casify_object):
01103c44 2226 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2227 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2228 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2229 * dispextern.h (FACE_FROM_ID):
2230 * keyboard.c (read_char): Use UNSIGNED_CMP.
2231
41cb286c
PE
2232 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2233 not to EMACS_INT, to avoid GCC warning.
2234
4a1b9832
PE
2235 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2236
55daad71
PE
2237 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2238 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2239 isn't needed on 32-bit machines.
8f95c75c 2240
01103c44
PE
2241 * buffer.c (Fgenerate_new_buffer_name):
2242 Use EMACS_INT for count, not int.
0ceccced 2243 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2244
2245 * data.c (Qcompiled_function): Now static.
2246
c6f072e7
PE
2247 * window.c (window_body_lines): Now static.
2248
20ce5912
PE
2249 * image.c (gif_load): Rename local to avoid shadowing.
2250
9c4c5f81
PE
2251 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2252 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2253 * alloc.c (make_save_value): Integer argument is now of type
2254 ptrdiff_t, not int.
2255 (mark_object): Use ptrdiff_t, not int.
2256 * lisp.h (pD): New macro.
2257 * print.c (print_object): Use it.
2258
c0c5c8ae
PE
2259 * alloc.c: Use EMACS_INT, not int, to count objects.
2260 (total_conses, total_markers, total_symbols, total_vector_size)
2261 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2262 (total_free_floats, total_floats, total_free_intervals)
2263 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2264 Now EMACS_INT, not int. All uses changed.
2265 (Fgarbage_collect): Compute overall total using a double, so that
2266 integer overflow is less likely to be a problem. Check for overflow
2267 when converting back to an integer.
5a25e253
PE
2268 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2269 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2270 These were 'int' variables that could overflow on 64-bit hosts;
2271 they were never used, so remove them instead of repairing them.
211a0b2a 2272 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2273 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2274 Previously, this ceilinged at INT_MAX, but that doesn't work on
2275 64-bit machines.
e46bb31a 2276 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2277
c78baabf 2278 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2279 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2280 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2281 when a (possibly-narrower) signed value would do just as well.
2282 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2283
c9d624c6
PE
2284 * alloc.c: Catch some string size overflows that we were missing.
2285 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2286 for convenience in STRING_BYTES_MAX.
2287 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2288 The definition here is exact; the one in lisp.h was approximate.
2289 (allocate_string_data): Check for string overflow. This catches
2290 some instances we weren't catching before. Also, it catches
2291 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2292 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2293 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2294
c9d624c6
PE
2295 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2296 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2297 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2298
353032ce
PE
2299 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2300
2bccce07
PE
2301 * alloc.c (Fmake_string): Check for out-of-range init.
2302
0ac30604
SM
23032011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2304
2305 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2306
c195f2de
JD
23072011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2308
2309 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2310 xg_get_default_scrollbar_width.
2311
2312 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2313 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2314 (style_changed_cb): Call update_theme_scrollbar_width and call
2315 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2316 all frames (Bug#8505).
2317 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2318 Call gtk_window_set_resizable if HAVE_GTK3.
2319 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2320 and height if HAVE_GTK3 (Bug#8505).
2321 (scroll_bar_width_for_theme): New variable.
2322 (update_theme_scrollbar_width): New function.
2323 (xg_get_default_scrollbar_width): Move code to
2324 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2325 (xg_initialize): Call update_theme_scrollbar_width.
2326
2327 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2328
2329 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2330
e10ac9f1
MR
23312011-06-12 Martin Rudalics <rudalics@gmx.at>
2332
2333 * frame.c (make_frame): Call other_buffer_safely instead of
2334 other_buffer.
2335
2336 * window.c (temp_output_buffer_show): Call display_buffer with
2337 second argument Vtemp_buffer_show_specifiers and reset latter
2338 immediately after the call.
2339 (Vtemp_buffer_show_specifiers): New variable.
2340 (auto_window_vscroll_p, next_screen_context_lines)
2341 (Vscroll_preserve_screen_position): Remove leading asterisks from
2342 doc-strings.
2343
2d3c217e 23442011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2345
7b7f97e8 2346 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2347 * buffer.c (Qclone_number): Remove for now, as it's unused.
2348 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2349 (record_buffer): Remove unused local.
2350 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2351 (set_frame_buffer_list): Remove; unused.
2352 * frame.h (other_visible_frames): Remove decl.
2353 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2354 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2355 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2356 if HAVE_GPM.
2357 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2358 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2359 Define only if HAVE_GPM.
2360 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2361 (update_hints_inhibit): Remove; never set. All uses removed.
2362 * widgetprv.h (emacsFrameClassRec): Remove decl.
2363 * window.c (delete_deletable_window): Now returns void, since it
2364 wasn't returning anything.
2365 (compare_window_configurations): Remove unused locals.
2366 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2367 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2368 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2369 the same widths as pointers. This follows up on the 2011-05-06 patch.
2370 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2371 * xterm.h: Likewise.
2372 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2373
1384b89e
JB
23742011-06-12 Juanma Barranquero <lekktu@gmail.com>
2375
2376 * makefile.w32-in: Update dependencies.
2377 (LISP_H): Add lib/intprops.h.
2378
1100a63c
CY
23792011-06-11 Chong Yidong <cyd@stupidchicken.com>
2380
2381 * image.c (gif_load): Add animation frame delay to the metadata.
2382 (syms_of_image): Use DEFSYM. New symbol `delay'.
2383
6198ccd0
MR
23842011-06-11 Martin Rudalics <rudalics@gmx.at>
2385
2386 * window.c (delete_deletable_window): Re-add.
2387 (Fset_window_configuration): Rewrite to handle dead buffers and
2388 consequently deletable windows.
2389 (window_tree, Fwindow_tree): Remove. Supply functionality in
2390 window.el.
2391 (compare_window_configurations): Simplify code.
2392
b6e3633c
AS
23932011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2394
1ab0dee5
AS
2395 * image.c (imagemagick_load_image): Fix type mismatch.
2396 (Fimagemagick_types): Likewise.
2397
b6e3633c
AS
2398 * window.h (replace_buffer_in_windows): Declare.
2399
9397e56f
MR
24002011-06-11 Martin Rudalics <rudalics@gmx.at>
2401
2402 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2403 Qclone_number. Remove external declaration of Qdelete_window.
2404 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2405 code.
640c8776
SM
2406 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2407 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2408 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2409 buffer list implementation.
2410 (other_buffer_safely): New function.
2411 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2412 calls to replace_buffer_in_windows and
2413 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2414 if allowed.
2415 (record_buffer): Inhibit quitting and rewrite using quittable
2416 functions. Run Qbuffer_list_update_hook if allowed.
2417 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2418 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2419 Move switch-to-buffer to window.el.
9397e56f
MR
2420 (bury-buffer): Move to window.el.
2421 (Vbuffer_list_update_hook): New variable.
2422
2423 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2424 section.
2425
2426 * window.h (resize_frame_windows): Move up in code.
2427 (Fwindow_frame): Remove EXFUN.
2428 (replace_buffer_in_all_windows): Remove prototype.
2429 (replace_buffer_in_windows_safely): Add prototype.
2430
2431 * window.c: Declare Qdelete_window static again. Move down
2432 declaration of select_count.
2433 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2434 (Fother_window): Move to window.el.
2435 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2436 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2437 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2438 window.el.
2439 (replace_buffer_in_windows): Implement by calling
2440 Qreplace_buffer_in_windows.
2441 (replace_buffer_in_all_windows): Remove with some functionality
2442 moved into replace_buffer_in_windows_safely.
2443 (replace_buffer_in_windows_safely): New function.
2444 (select_window_norecord, select_frame_norecord): Move in front
2445 of run_window_configuration_change_hook. Remove now obsolete
2446 declarations.
640c8776
SM
2447 (Fset_window_buffer): Rewrite doc-string.
2448 Call Qrecord_window_buffer.
9397e56f
MR
2449 (keys_of_window): Move binding for other-window to window.el.
2450
b50691aa
CY
24512011-06-11 Chong Yidong <cyd@stupidchicken.com>
2452
2453 * dispextern.h (struct image): Replace data member, whose int_val
2454 and ptr_val fields were not used by anything, with a single
2455 lisp_val object.
2456
2457 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2458 (gif_clear_image, gif_load, imagemagick_load_image)
2459 (gs_clear_image, gs_load): Callers changed.
2460
3f754b86
PE
24612011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2462
cca69397
PE
2463 * buffer.h: Include <time.h>, for time_t.
2464 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2465
109e28d0
PE
2466 Fix minor problems found by static checking.
2467
60737f02
PE
2468 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2469
4b66faf3
PE
2470 Make identifiers static if they are not used in other modules.
2471 * data.c (Qcompiled_function, Qframe, Qvector):
2472 * image.c (QimageMagick, Qsvg):
2473 * minibuf.c (Qmetadata):
2474 * window.c (resize_window_check, resize_root_window): Now static.
2475 * window.h (resize_window_check, resize_root_window): Remove decls.
2476
109e28d0
PE
2477 * window.c (window_deletion_count, delete_deletable_window):
2478 Remove; unused.
46a4ce9e
PE
2479 (window_body_lines): Now static.
2480 (Fdelete_other_windows_internal): Mark vars as initialized.
2481 Make sure 'resize_failed' is initialized.
2482 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2483 (resize_window_apply): Remove unused local.
2484 * window.h (delete_deletable_window): Remove decl.
2485
109e28d0 2486 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2487 (imagemagick_load_image): Fix pointer signedness problem by changing
2488 last arg from unsigned char * to char *. All uses changed.
2489 Also, fix a local for similar reasons.
2490 Remove unused locals. Remove locals to avoid shadowing.
2491 (fn_rsvg_handle_free): Remove; unused.
2492 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2493 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2494
3f754b86
PE
2495 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2496
2547adb1
CY
24972011-06-10 Chong Yidong <cyd@stupidchicken.com>
2498
2499 * image.c (gif_load): Fix omitted cast error introduced by
2500 2011-06-06 change.
2501
2c8e37d4
MR
25022011-06-10 Martin Rudalics <rudalics@gmx.at>
2503
2504 * window.h (resize_proportionally, orig_total_lines)
2505 (orig_top_line): Remove from window structure.
2506 (set_window_height, set_window_width, change_window_heights)
2507 (Fdelete_window): Remove prototypes.
2508 (resize_frame_windows): Remove duplicate declaration.
2509
440a42e3
EZ
25102011-06-10 Eli Zaretskii <eliz@gnu.org>
2511
2512 * window.h (resize_frame_windows, resize_window_check)
2513 (delete_deletable_window, resize_root_window)
2514 (resize_frame_windows): Declare prototypes.
2515
2516 * window.c (resize_window_apply): Make definition be "static" to
2517 match the prototype.
2518
562dd5e9
MR
25192011-06-10 Martin Rudalics <rudalics@gmx.at>
2520
2521 * window.c: Remove declarations of Qwindow_size_fixed,
2522 window_min_size_1, window_min_size_2, window_min_size,
2523 size_window, window_fixed_size_p, enlarge_window, delete_window.
2524 Remove static from declaration of Qdelete_window, it's
2525 temporarily needed by Fbury_buffer.
2526 (replace_window): Don't assign orig_top_line and
2527 orig_total_lines.
2528 (Fdelete_window, delete_window): Remove. Window deletion is
2529 handled by window.el.
640c8776
SM
2530 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2531 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2532 (Fdelete_other_windows): Remove. Deleting other windows is
2533 handled by window.el.
2534 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2535 handled in window.el.
2536 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2537 Window minimum sizes are handled in window.el.
2538 (shrink_windows, size_window, set_window_height)
2539 (set_window_width, change_window_heights, window_height)
2540 (window_width, CURBEG, CURSIZE, enlarge_window)
2541 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2542 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2543 handled in window.el.
2544 (make_dummy_parent): Rename to make_parent_window and give it a
2545 second argument horflag.
2546 (make_window): Don't set resize_proportionally any more.
2547 (Fsplit_window): Remove. Windows are split in window.el.
2548 (save_restore_action, save_restore_orig_size)
2549 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2550 Resize mini windows in window.el.
2551 (grow_mini_window, shrink_mini_window): Implement by calling
2552 Qresize_root_window_vertically, resize_window_check and
2553 resize_window_apply.
640c8776
SM
2554 (saved_window, Fset_window_configuration, save_window_save):
2555 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2556 resize_proportionally.
2557 (window_min_height, window_min_width): Move to window.el.
2558 (keys_of_window): Move bindings for delete-other-windows,
2559 split-window, delete-window and enlarge-window to window.el.
2560
2561 * buffer.c: Temporarily extern Qdelete_window.
2562 (Fbury_buffer): Temporarily call Qdelete_window instead of
2563 Fdelete_window (Fbury_buffer will move to window.el soon).
2564
2565 * frame.c (set_menu_bar_lines_1): Remove code handling
2566 orig_top_line and orig_total_lines.
2567
2568 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2569 set_window_height but set heights directly.
2570 (change_frame_size_1): Use resize_frame_windows.
2571
2572 * xdisp.c (init_xdisp): Don't use set_window_height but set
2573 heights directly.
2574
640c8776
SM
2575 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2576 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2577 run_window_configuration_change_hook.
2578
2579 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2580 instead of change_window_heights and run
2581 run_window_configuration_change_hook.
2582
1a13852e
MR
25832011-06-09 Martin Rudalics <rudalics@gmx.at>
2584
2585 * window.c (replace_window): Rename second argument REPLACEMENT to
2586 NEW. New third argument SETFLAG. Rewrite.
2587 (delete_window, make_dummy_parent): Call replace_window with
2588 third argument 1.
2589 (window_list_1): Move down in code.
2590 (run_window_configuration_change_hook): Move set_buffer part
2591 before select_frame_norecord part in order to unwind correctly.
2592 Rename count1 to count.
2593 (recombine_windows, delete_deletable_window, resize_root_window)
2594 (Fdelete_other_windows_internal)
2595 (Frun_window_configuration_change_hook, make_parent_window)
2596 (resize_window_check, resize_window_apply, Fresize_window_apply)
2597 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2598 (Fdelete_window_internal, Fresize_mini_window_internal):
2599 New functions.
1a13852e
MR
2600 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2601
f3d1777e
MR
26022011-06-08 Martin Rudalics <rudalics@gmx.at>
2603
496e208e
MR
2604 * window.h (window): Add some new members to window structure -
2605 normal_lines, normal_cols, new_total, new_normal, clone_number,
2606 splits, nest, prev_buffers, next_buffers.
2607 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2608 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2609
f3d1777e
MR
2610 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2611 Remove.
496e208e
MR
2612 (make_dummy_parent): Set new members of windows structure.
2613 (make_window): Move down in code. Handle new members of window
2614 structure.
2615 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2616 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2617 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2618 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2619 (Fset_window_next_buffers, Fset_window_clone_number):
2620 New functions.
496e208e
MR
2621 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2622 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2623 Doc-string fixes.
2624 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2625 Argument WINDOW can be now internal window too.
2626 (Fwindow_use_time): Move up in code.
2627 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2628 Rewrite doc-string.
2629 (Fset_window_configuration, saved_window)
2630 (Fcurrent_window_configuration, save_window_save): Handle new
2631 members of window structure.
b9e809c2
MR
2632 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2633 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2634 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2635 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2636 Qget_mru_window, Qresize_root_window,
2637 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2638 Qauto_buffer_name; staticpro them.
f3d1777e 2639
abde8f8c
MR
26402011-06-07 Martin Rudalics <rudalics@gmx.at>
2641
2642 * window.c (Fwindow_total_size, Fwindow_left_column)
2643 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2644 (Fwindow_list_1): New functions.
2645 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2646 (Fwindow_width, Fscroll_left, Fscroll_right):
2647 Use window_body_cols instead of window_box_text_cols.
2648 (delete_window, Fset_window_configuration):
2649 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2650 (delete_all_subwindows): Take a window as argument and not a
2651 structure. Rewrite.
190b47e6
MR
2652 (window_loop): Remove handling of GET_LRU_WINDOW and
2653 GET_LARGEST_WINDOW.
2654 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2655
2656 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2657 window_box_text_cols. delete_all_subwindows now takes a
2658 Lisp_Object as argument.
abde8f8c 2659
640c8776
SM
2660 * indent.c (compute_motion, Fcompute_motion):
2661 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2662
fa8a67e6
MR
2663 * frame.c (delete_frame): Call delete_all_subwindows with root
2664 window as argument.
2665
a54e3482
DC
26662011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2667
2668 * fns.c (Fputhash): Document return value.
2669
60002bf5
CY
26702011-06-06 Chong Yidong <cyd@stupidchicken.com>
2671
2672 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2673
0c671da6 26742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2675
b862a52a 2676 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2677
be44ca6c
PE
2678 Check for overflow when converting integer to cons and back.
2679 * charset.c (Fdefine_charset_internal, Fdecode_char):
2680 Use cons_to_unsigned to catch overflow.
2681 (Fencode_char): Use INTEGER_TO_CONS.
2682 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2683 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2684 * data.c (long_to_cons, cons_to_long): Remove.
2685 (cons_to_unsigned, cons_to_signed): New functions.
2686 These signal an error for invalid or out-of-range values.
2687 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2688 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2689 * font.c (Ffont_variation_glyphs):
2690 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2691 * lisp.h: Include <intprops.h>.
2692 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2693 (cons_to_signed, cons_to_unsigned): New decls.
2694 (long_to_cons, cons_to_long): Remove decls.
2695 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2696 (Fprimitive_undo): Use CONS_TO_INTEGER.
2697 * xfns.c (Fx_window_property): Likewise.
2698 * xselect.c: Include <limits.h>.
2699 (x_own_selection, selection_data_to_lisp_data):
2700 Use INTEGER_TO_CONS.
2701 (x_handle_selection_request, x_handle_selection_clear)
2702 (x_get_foreign_selection, Fx_disown_selection_internal)
2703 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2704 (lisp_data_to_selection_data): Use cons_to_unsigned.
2705 (x_fill_property_data): Use cons_to_signed.
2706 Report values out of range.
2707
d1f3d2af
PE
2708 Check for buffer and string overflow more precisely.
2709 * buffer.h (BUF_BYTES_MAX): New macro.
2710 * lisp.h (STRING_BYTES_MAX): New macro.
2711 * alloc.c (Fmake_string):
2712 * character.c (string_escape_byte8):
2713 * coding.c (coding_alloc_by_realloc):
2714 * doprnt.c (doprnt):
2715 * editfns.c (Fformat):
2716 * eval.c (verror):
2717 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2718 since they may not be the same number.
2719 * editfns.c (Finsert_char):
2720 * fileio.c (Finsert_file_contents):
2721 Likewise for BUF_BYTES_MAX.
2722
dd52fcea
PE
2723 * image.c: Use ptrdiff_t, not int, for sizes.
2724 (slurp_file): Switch from int to ptrdiff_t.
2725 All uses changed.
2726 (slurp_file): Check that file size fits in both size_t (for
2727 malloc) and ptrdiff_t (for sanity and safety).
2728
7f9bbdbb
PE
2729 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2730 if b->modtime has its maximal value.
2731
dfe18f82
PE
2732 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2733
84acfcf0
PE
2734 Don't assume time_t can fit into int.
2735 * buffer.h (struct buffer.modtime): Now time_t, not int.
2736 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2737 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2738
ccd9a01a
PE
2739 Minor fixes for signed vs unsigned integers.
2740 * character.h (MAYBE_UNIFY_CHAR):
2741 * charset.c (maybe_unify_char):
2742 * keyboard.c (read_char, reorder_modifiers):
2743 XINT -> XFASTINT, since the integer must be nonnegative.
2744 * ftfont.c (ftfont_spec_pattern):
2745 * keymap.c (access_keymap, silly_event_symbol_error):
2746 XUINT -> XFASTINT, since the integer must be nonnegative.
2747 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2748 since it makes no difference and we prefer signed.
2749 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2750 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2751 nonnegative.
2752
d6d100dd
SM
27532011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2754
2755 * window.h (Fwindow_frame): Declare.
2756
2b6148e4
PE
27572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2758
2759 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2760 (SPARE_MEMORY): Always define.
2761 (LARGE_REQUEST): Remove.
2762 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2763
f230ecc9
MR
27642011-06-06 Martin Rudalics <rudalics@gmx.at>
2765
727e958e
MR
2766 * lisp.h: Move EXFUNS for Fframe_root_window,
2767 Fframe_first_window and Fset_frame_selected_window to window.h.
2768
2769 * window.h: Move EXFUNS for Fframe_root_window,
2770 Fframe_first_window and Fset_frame_selected_window here from
2771 lisp.h.
2772
2773 * frame.c (Fwindow_frame, Fframe_first_window)
2774 (Fframe_root_window, Fframe_selected_window)
2775 (Fset_frame_selected_window): Move to window.c.
2776 (Factive_minibuffer_window): Move to minibuf.c.
2777 (Fother_visible_frames_p): New function.
2778
2779 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2780
f230ecc9
MR
2781 * window.c (decode_window, decode_any_window): Move up in code.
2782 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2783 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2784 (Fwindow_buffer): Move up and rewrite doc-string.
2785 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2786 (Fwindow_prev): New functions.
727e958e
MR
2787 (Fwindow_frame): Move here from frame.c. Accept any window as
2788 argument.
2789 (Fframe_root_window, Fframe_first_window)
2790 (Fframe_selected_window): Move here from frame.c. Accept frame
2791 or arbitrary window as argument. Update doc-strings.
2792 (Fminibuffer_window): Move up in code.
2793 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2794 (Fset_frame_selected_window): Move here from frame.c.
2795 Marginal rewrite.
727e958e
MR
2796 (Fselected_window, select_window, Fselect_window): Move up in
2797 code. Minor doc-string fixes.
f230ecc9 2798
4d09bcf6
PE
27992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2802 Do not assume that spare memory exists; that assumption is valid
2803 only if SYSTEM_MALLOC.
2804 (LARGE_REQUEST): New macro, so that the issue of large requests
2805 is separated from the issue of spare memory.
2806
810928a2
AS
28072011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2808
172418ad
AS
2809 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2810 format. (Bug#8806)
2811
43f862f7
AS
2812 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2813
810928a2
AS
2814 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2815 before statements.
2816
a059fe24
JD
28172011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2818
2819 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2820
2821 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2822
2823 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2824 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2825
989bf368
JB
28262011-06-05 Juanma Barranquero <lekktu@gmail.com>
2827
2828 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2829
4b80f674
CY
28302011-06-04 Chong Yidong <cyd@stupidchicken.com>
2831
2832 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2833 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2834 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2835 New error handlers.
4b80f674
CY
2836 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2837 Obey Vx_select_enable_clipboard_manager. Catch errors in
2838 x_clipboard_manager_save (Bug#8779).
2839 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2840 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2841
99a33b77 28422011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2843
2844 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2845
99a33b77 28462011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2847
2848 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2849 in the current matrix if keep_current_p is non-zero.
2850
8264569d
EZ
28512011-06-04 Eli Zaretskii <eliz@gnu.org>
2852
2853 * bidi.c (bidi_level_of_next_char): Fix last change.
2854
57f97249
EZ
28552011-06-03 Eli Zaretskii <eliz@gnu.org>
2856
fec2107c 2857 Support bidi reordering of text covered by display properties.
57f97249 2858
fec2107c
EZ
2859 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2860 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2861 (bidi_cache_search, bidi_cache_iterator_state)
2862 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2863 (bidi_level_of_next_char, bidi_move_to_visually_next):
2864 Support character positions inside a run of characters covered by a
fec2107c
EZ
2865 display string.
2866 (bidi_paragraph_init, bidi_resolve_explicit_1)
2867 (bidi_level_of_next_char): Call bidi_fetch_char and
2868 bidi_fetch_char_advance instead of FETCH_CHAR and
2869 FETCH_CHAR_ADVANCE.
2870 (bidi_init_it): Initialize new members.
2871 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2872 definitions.
2873 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2874 instead of using explicit *_CHAR codes.
d6d100dd
SM
2875 (bidi_resolve_explicit, bidi_resolve_weak):
2876 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2877 bidirectional text is supported only in multibyte buffers.
2878 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2879 it to initialize the frame_window_p member of struct bidi_it.
2880 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2881 (bidi_resolve_explicit, bidi_resolve_weak)
2882 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2883 bidi_it->nchars is non-positive.
2884 (bidi_level_of_next_char): Don't try to lookup the cache for the
2885 next/previous character if nothing is cached there yet, or if we
2886 were just reseat()'ed to a new position.
c40e2fb2 2887
0e14fe90
EZ
2888 * xdisp.c (set_cursor_from_row): Set start and stop points
2889 according to the row's direction when priming the loop that looks
2890 for the glyph on which to display cursor.
2891 (single_display_spec_intangible_p): Function deleted.
2892 (display_prop_intangible_p): Reimplement to call
2893 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2894 Accept 3 additional arguments needed by handle_display_spec.
2895 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2896 values: lists, `(when COND...)' forms, etc.
2897 (single_display_spec_string_p): Support property values that are
2898 lists with the argument STRING its top-level element.
2899 (display_prop_string_p): Fix the condition for processing a
2900 property that is a list to be consistent with handle_display_spec.
fec2107c 2901 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2902 last portion of handle_display_prop.
2903 (compute_display_string_pos): Accept additional argument
2904 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2905 value of a `display' property is a "replacing spec".
2906 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2907 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2908 the display property, but just return a value indicating whether
2909 the display property will replace the characters it covers.
2910 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2911 frame_window_p members of struct bidi_it.
d6d100dd
SM
2912 (compute_display_string_pos, compute_display_string_end):
2913 New functions.
fec2107c
EZ
2914 (push_it): Accept second argument POSITION, where pop_it should
2915 jump to continue iteration.
2916 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2917
fec2107c
EZ
2918 * keyboard.c (adjust_point_for_property): Adjust the call to
2919 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2920
2921 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2922 (bidi_init_it): Update prototypes.
2923 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2924 (compute_display_string_pos, compute_display_string_end):
2925 Declare prototypes.
fec2107c
EZ
2926 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2927 EMACS_INT.
fc6f18ce 2928
40087514 29292011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2930
57f53182
PE
2931 Malloc failure behavior now depends on size of allocation.
2932 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2933 * lisp.h: Change signatures accordingly.
2934 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2935 All callers changed. (Bug#8762)
2936
2937 * gnutls.c: Use Emacs's memory allocators.
2938 Without this change, the gnutls library would invoke malloc etc.
2939 directly, which causes problems on non-SYNC_INPUT hosts, and which
2940 runs afoul of improving memory_full behavior. (Bug#8761)
2941 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2942 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2943 xfree instead of the default malloc, realloc, free.
2944 (Fgnutls_boot): No need to check for memory allocation failure,
2945 since xmalloc does that for us.
2946
ac32cd99 2947 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2948 * category.c (hash_get_category_set):
2949 * ccl.c (ccl_driver):
2950 * charset.c (Fdefine_charset_internal):
2951 * charset.h (struct charset.hash_index):
2952 * composite.c (get_composition_id, gstring_lookup_cache)
2953 (composition_gstring_put_cache):
2954 * composite.h (struct composition.hash_index):
2955 * dispextern.h (struct image.hash):
2956 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2957 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2958 (hashfn_equal, hashfn_user_defined, make_hash_table)
2959 (maybe_resize_hash_table, hash_lookup, hash_put)
2960 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2961 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2962 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2963 * image.c (make_image, search_image_cache, lookup_image)
2964 (xpm_put_color_table_h):
2965 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2966 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2967 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2968 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2969 * alloc.c (allocate_vectorlike):
2970 Check for overflow in vector size calculations.
2971 * ccl.c (ccl_driver):
2972 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2973 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2974 need to be updated by these changes.
40087514
PE
2975 * fns.c (make_hash_table, maybe_resize_hash_table):
2976 Check for integer overflow with large hash tables.
0de4bb68
PE
2977 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2978 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2979 (SXHASH_REDUCE): New macro.
2980 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2981 Use it instead of discarding useful hash info with large hash values.
2982 (sxhash_float): New function.
2983 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2984 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2985 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2986 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2987 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2988 Adjust signatures to match updated version of code.
2989 (consing_since_gc): Now EMACS_INT, since a single hash table can
2990 use more than INT_MAX bytes.
2991
698d32e2
DN
29922011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2993
2994 Make it possible to build with GCC-4.6+ -O2 -flto.
2995
2996 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2997
fd6fa53f
SM
29982011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2999
3000 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3001 Call minibuffer-inactive-mode.
3002
864db017
JB
30032011-05-31 Juanma Barranquero <lekktu@gmail.com>
3004
3005 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3006 Update dependencies.
3007
2ad0baf4
DN
30082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3009
3010 * data.c (init_data): Remove code for UTS, this system is not
3011 supported anymore.
3012
4fcc2638
DN
30132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3014
3015 Don't force ./temacs to start in terminal mode.
3016
3017 * frame.c (make_initial_frame): Initialize faces in all cases, not
3018 only when CANNOT_DUMP is defined.
3019 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3020
c56e0fd5
DN
30212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3022
3023 * dispnew.c (add_window_display_history): Use const for the string
3024 pointer. Remove declaration, not needed.
3025
333d54da 30262011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3027
55d4c1b2 3028 Use 'inline', not 'INLINE'.
333d54da 3029 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3030 * alloc.c, fontset.c (INLINE): Remove.
3031 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3032 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3033 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3034 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3035 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3036
738db178
DN
30372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3038
3039 Make it possible to run ./temacs.
3040
3041 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3042 syms_of_callproc does the same thing. Remove test for
3043 "initialized", do it in the caller.
3044 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3045
620c53a6
SM
30462011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3047
3048 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3049 (read_minibuf): Use get_minibuffer.
3050 (syms_of_minibuf): Use DEFSYM.
3051 (Qmetadata): New var.
3052 * data.c (Qbuffer): Don't make it static.
3053 (syms_of_data): Use DEFSYM.
3054
e003a292
PE
30552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3058 (CCL_CODE_MIN): New macro.
3059
ed008a6d
PE
30602011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3061
3687c2ef
PE
3062 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3063
ed008a6d
PE
3064 * eval.c (Qdebug): Now static.
3065 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3066 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3067 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3068
d66c4c7c
CY
30692011-05-29 Chong Yidong <cyd@stupidchicken.com>
3070
3071 * image.c: Various fixes to ImageMagick code comments.
3072 (Fimagemagick_types): Doc fix.
3073
5fbc2025
PE
30742011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3075
0196f88a
PE
3076 Minor fixes prompted by GCC 4.6.0 warnings.
3077
3078 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3079
5fbc2025
PE
3080 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3081 (x_clipboard_manager_save_all): Move extern decl to ...
3082 * xterm.h: ... here, so that it can be checked for consistency.
3083
1dd3c2d9
CY
30842011-05-29 Chong Yidong <cyd@stupidchicken.com>
3085
3086 * xselect.c (x_clipboard_manager_save_frame)
3087 (x_clipboard_manager_save_all): New functions.
3088 (Fx_clipboard_manager_save): Lisp function deleted.
3089
3090 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3091 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3092
3093 * xterm.h: Update prototype.
3094
5ba6571d
WX
30952011-05-28 William Xu <william.xwl@gmail.com>
3096
3097 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3098 exiting (Bug#8239).
3099
3eaff834
JM
31002011-05-28 Jim Meyering <meyering@redhat.com>
3101
e1900994 3102 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3103 * fns.c (to_uchar): Define.
3104 (crypto_hash_function): Use it to convert some newly-signed
3105 variables to unsigned, to avoid sign-extension bugs. For example,
3106 without this change, (md5 "truc") would evaluate to
3107 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3108 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3109 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3110
0f6990a7
PE
31112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 Integer overflow fixes.
c8a9ca5a 3114
08686060
PE
3115 * dbusbind.c: Serial number integer overflow fixes.
3116 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3117 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3118 to hold a serial number that is too large for a fixnum.
3119 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3120 Check for serial numbers out of range. Decode any serial number
59568bf0 3121 that was so large that it became a float. (Bug#8722)
08686060 3122
2d1fc3c7
PE
3123 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3124 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3125 Use XFASTINT rather than XUINT when numbers are nonnegative.
3126 (xd_append_arg, Fdbus_method_return_internal):
3127 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3128 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3129 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3130 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3131 (Bug#8722)
2d1fc3c7 3132
c8a9ca5a
PE
3133 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3134
519e1d69
PE
3135 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3136
30569699
PE
3137 ccl: add integer overflow checks
3138 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3139 (IN_INT_RANGE): New macros.
3140 (ccl_driver): Use them to check for integer overflow when
3141 decoding a CCL program. Many of the new checks are whether XINT (x)
3142 fits in int; it doesn't always, on 64-bit hosts. The new version
3143 doesn't catch all possible integer overflows, but it's an
847044ea 3144 improvement. (Bug#8719)
30569699 3145
c11285dc
PE
3146 * alloc.c (make_event_array): Use XINT, not XUINT.
3147 There's no need for unsigned here.
3148
fdccd48e
PE
3149 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3150 This follows up to the 2011-05-06 change that substituted uintptr_t
3151 for EMACS_INT. This case wasn't caught back then.
3152
37910ab2
PE
3153 Rework Fformat to avoid integer overflow issues.
3154 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3155 now (part of C89). Include <verify.h>.
3156 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3157 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3158 (Fformat): Avoid the prepass trying to compute sizes; it was only
3159 approximate and thus did not catch overflow reliably. Instead, walk
3160 through the format just once, formatting and computing sizes as we go,
3161 checking for integer overflow at every step, and allocating a larger
3162 buffer as needed. Keep track separately whether the format is
3163 multibyte. Keep only the most-recently calculated precision, rather
3164 than them all. Record whether each argument has been converted to
3165 string. Use EMACS_INT, not int, for byte and char and arg counts.
3166 Support field widths and precisions larger than INT_MAX. Avoid
3167 sprintf's undefined behavior with conversion specifications such as %#d
3168 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3169 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3170 formatting out-of-range floating point numbers with int
9173deec 3171 formats. (Bug#8668)
37910ab2 3172
2e6578fb
PE
3173 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3174
0ae6bdee
PE
3175 * data.c: Avoid integer truncation in expressions involving floats.
3176 * data.c: Include <intprops.h>.
3177 (arith_driver): When there's an integer overflow in an expression
3178 involving floating point, convert the integers to floating point
3179 so that the resulting value does not suffer from catastrophic
3180 integer truncation. For example, on a 64-bit host (* 4
3181 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3182 Do not rely on undefined behavior after integer overflow.
3183
de883a70
PE
3184 merge count_size_as_multibyte, parse_str_to_multibyte
3185 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3186 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3187 Check for integer overflow.
3188 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3189 since it's now a duplicate of the other. This is more of
3190 a character than a buffer op, so better that it's in character.c.
3191 * fns.c, print.c: Adjust to above changes.
3192
2ff916cb
PE
31932011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3194
3195 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3196
f1b54466
PE
31972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3198
fb1ac845
PE
3199 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3200 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3201 (x_clipboard_manager_save): Now static.
3202 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3203
f1b54466
PE
3204 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3205 (crypto_hash_function): Now static.
3206 Fix pointer signedness problems. Avoid unnecessary initializations.
3207
a9f737ee
CY
32082011-05-27 Chong Yidong <cyd@stupidchicken.com>
3209
3210 * termhooks.h (Vselection_alist): Make it terminal-local.
3211
3212 * terminal.c (create_terminal): Initialize it.
3213
3214 * xselect.c: Support for clipboard managers.
3215 (Vselection_alist): Move to termhooks.h as terminal-local var.
3216 (LOCAL_SELECTION): New macro.
3217 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3218 (symbol_to_x_atom): Remove gratuitous arg.
3219 (x_handle_selection_request, lisp_data_to_selection_data)
3220 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3221 (x_own_selection, x_get_local_selection, x_convert_selection):
3222 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3223 (some_frame_on_display): Delete unused function.
3224 (Fx_own_selection_internal, Fx_get_selection_internal)
3225 (Fx_disown_selection_internal, Fx_selection_owner_p)
3226 (Fx_selection_exists_p): New optional frame arg.
3227 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3228 (x_handle_selection_clear): Don't treat other terminals with the
3229 same keyboard specially. Use the terminal-local Vselection_alist.
3230 (x_clear_frame_selections): Use Frun_hook_with_args.
3231
3232 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3233
3234 * xterm.h: Add support for those atoms.
3235
e067f0c1
CY
32362011-05-26 Chong Yidong <cyd@stupidchicken.com>
3237
3238 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3239 (converted_selections, conversion_fail_tag): New global variables.
3240 (x_selection_request_lisp_error): Free the above.
3241 (x_get_local_selection): Remove unnecessary code.
3242 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3243 of converted selections stored in converted_selections.
3244 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3245 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3246 (x_convert_selection): New function.
3247 (x_handle_selection_event): Simplify.
3248 (x_get_foreign_selection): Don't ignore incoming requests while
3249 waiting for an answer; this will fail when we implement
3250 SAVE_TARGETS, and seems unnecessary anyway.
3251 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3252 (Vx_sent_selection_functions): Doc fix.
3253
0f4aebc0
LL
32542011-05-26 Leo Liu <sdl.web@gmail.com>
3255
3256 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3257
e61124cd
YM
32582011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3259
3260 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3261
3262 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3263 for fringe update if it has periodic bitmap.
ac389d0c 3264 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3265 and fringe_bitmap_periodic_p.
3266
3267 * fringe.c (get_fringe_bitmap_data): New function.
3268 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3269 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3270 row. Mark glyph row for fringe update if periodicity changed.
3271
3272 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3273 for fringe update unless it has periodic bitmap.
3274
f16d9837
KH
32752011-05-25 Kenichi Handa <handa@m17n.org>
3276
3277 * xdisp.c (get_next_display_element): Set correct it->face_id for
3278 a static composition.
3279
e1b90ef6
LL
32802011-05-24 Leo Liu <sdl.web@gmail.com>
3281
3282 * deps.mk (fns.o):
3283 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3284
3285 * fns.c (crypto_hash_function, Fsha1): New function.
3286 (Fmd5): Use crypto_hash_function.
3287 (syms_of_fns): Add Ssha1.
3288
7400048f
PE
32892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3290
3291 * gnutls.c: Remove unused macros.
3292 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3293 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3294 Remove macros that are defined and never used.
3295 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3296
abb71cf4
CY
32972011-05-22 Chong Yidong <cyd@stupidchicken.com>
3298
3299 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3300 (Fx_get_selection_internal): Minor cleanup.
3301 (Fx_own_selection_internal): Rename arguments for consistency with
3302 select.el.
3303
6307db39
PE
33042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3307
f3d4e0a4
CY
33082011-05-22 Chong Yidong <cyd@stupidchicken.com>
3309
3310 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3311
4d8ade89
YM
33122011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3313
3314 * dispnew.c (scrolling_window): Don't exclude the case that the
3315 last enabled row in the desired matrix touches the bottom boundary.
3316
32078c8d
GM
33172011-05-21 Glenn Morris <rgm@gnu.org>
3318
3319 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3320 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3321 and add some more files.
32078c8d 3322
7285dc67
EZ
33232011-05-20 Eli Zaretskii <eliz@gnu.org>
3324
3325 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3326 report_file_error introduced by the change from 2011-05-07.
3327
89d1bd22
PE
33282011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3329
3330 * systime.h (Time): Define only if emacs is defined.
3331 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3332 where the include path doesn't have X11/X.h by default. See
3333 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3334
e23640bb 33352011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3336
3337 * composite.c (find_automatic_composition): Fix previous change.
3338
b9704ad9
GM
33392011-05-20 Glenn Morris <rgm@gnu.org>
3340
3341 * lisp.mk: New file, split from Makefile.in.
3342 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3343 (shortlisp): Remove.
3344 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3345
4a720484
GM
33462011-05-19 Glenn Morris <rgm@gnu.org>
3347
3348 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3349 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3350 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3351 (lisp): Set the order to that of loadup.el.
3352 (shortlisp): Make it a copy of $lisp.
3353 (SOME_MACHINE_LISP): Remove.
3354 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3355 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3356
a28d4396
KH
33572011-05-18 Kenichi Handa <handa@m17n.org>
3358
3359 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3360 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3361 (find_automatic_composition): Mostly rewrite for efficiency.
3362
a2b1fa8e
JB
33632011-05-18 Juanma Barranquero <lekktu@gmail.com>
3364
3365 * makefile.w32-in: Update dependencies.
3366
8e1f5610
CS
33672011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3368
3369 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3370 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3371
7025ee00 33722011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3373
cdfa6eab
PE
3374 Fix some integer overflow issues, such as string length overflow.
3375
06d6db33
PE
3376 * insdel.c (count_size_as_multibyte): Check for string overflow.
3377
2b4560a8
PE
3378 * character.c (lisp_string_width): Check for string overflow.
3379 Use EMACS_INT, not int, for string indexes and lengths; in
3380 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3381 the resulting string length overflows an EMACS_INT; instead,
3382 report a string overflow if no precision given. When checking for
3383 precision exhaustion, use a check that cannot possibly have
3384 integer overflow. (Bug#8675)
3385 * character.h (lisp_string_width): Adjust to new signature.
3386
cb93f9be
PE
3387 * alloc.c (string_overflow): New function.
3388 (Fmake_string): Use it. This doesn't change behavior, but saves
3389 a few bytes and will simplify future changes.
3390 * character.c (string_escape_byte8): Likewise.
3391 * lisp.h (string_overflow): New decl.
3392
1a1f3366
PE
3393 Fixups, following up to the user-interface timestamp change.
3394 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3395 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3396 * msdos.c (mouse_get_pos): Likewise.
3397 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3398 * w32gui.h (Time): Define by including "systime.h" rather than by
3399 declaring it ourselves. (Bug#8664)
3400
d4e3e4d3
PE
3401 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3402 * image.c (clear_image_cache): Likewise.
3403
f6a24d19
PE
3404 * term.c (term_mouse_position): Don't assume time_t wraparound.
3405
08dc5ae6
PE
3406 Be more systematic about user-interface timestamps.
3407 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3408 and sometimes 'EMACS_UINT', to represent these timestamps.
3409 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3410 This makes the code easier to follow, and makes it easier to catch
3411 integer overflow bugs such as Bug#8664.
3412 * frame.c (Fmouse_position, Fmouse_pixel_position):
3413 Use Time, not unsigned long, for user-interface timestamps.
3414 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3415 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3416 * keyboard.h (last_event_timestamp): Likewise.
3417 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3418 * menu.h (xmenu_show): Likewise.
3419 * term.c (term_mouse_position): Likewise.
3420 * termhooks.h (struct input_event.timestamp): Likewise.
3421 (struct terminal.mouse_position_hook): Likewise.
3422 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3423 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3424 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3425 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3426 what it was before.
3427 * menu.h, termhooks.h: Include "systime.h", for Time.
3428
8e55734a
PE
3429 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3430 Don't assume that the difference between two unsigned long values
3431 can fit into an integer. At this point, we know button_down_time
3432 <= event->timestamp, so the difference must be nonnegative, so
3433 there's no need to cast the result if double-click-time is
3434 nonnegative, as it should be; check that it's nonnegative, just in
3435 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3436 apart (about 25 days). (Bug#8664)
8e55734a 3437
841f1b75 3438 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3439 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3440
3e26f69c
PE
3441 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3442 that always fit in int. Use a sentinel instead of a counter, to
3443 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3444 * frame.h (struct frame): Use int for menu_bar_items_used
3445 instead of EMACS_INT, since it always fits in int.
3e26f69c 3446
5cc152c0
PE
3447 * menu.c (grow_menu_items): Check for int overflow.
3448
d89eb65e
PE
3449 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3450
5235bd3e
PE
3451 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3452 Before, the code was not consistent. These values cannot exceed
3453 2**31 - 1 so there's no need to make them unsigned.
3454 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3455 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3456 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3457 as modifiers.
3458 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3459
bc827e23
PE
3460 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3461 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3462 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3463 presumably because the widths might not match.
3464
78eb494e
PE
3465 * window.c (size_window): Avoid needless test at loop start.
3466
04f2d78b
CB
34672011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3468
3469 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3470
d2fc7e3d 34712011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3472
3473 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3474
d2fc7e3d 34752011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3476
3477 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3478 `width' to `bar_area_x' and `bar_area_width', respectively.
3479 (x_scroll_run): Take account of fringe background extension.
3480
04f2d78b
CB
3481 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3482 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3483 `bar_area_width', respectively.
3484 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3485 background extension.
3486
79b70037
GM
34872011-05-10 Jim Meyering <meyering@redhat.com>
3488
3489 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3490
2f142cc5
JB
34912011-05-10 Juanma Barranquero <lekktu@gmail.com>
3492
3493 * image.c (Finit_image_library): Return t for built-in image types,
3494 like pbm and xbm. (Bug#8640)
3495
57679c86
AS
34962011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3497
3498 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3499
888c9e86
EZ
35002011-05-07 Eli Zaretskii <eliz@gnu.org>
3501
b0512a1d
EZ
3502 * w32console.c (Fset_screen_color): Doc fix.
3503 (Fget_screen_color): New function.
3504 (syms_of_ntterm): Defsubr it.
3505
7285dc67
EZ
3506 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3507 unlink the temporary file if Fcall_process didn't create it in the
3508 first place.
3509 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3510 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3511 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3512 cue to call_process_cleanup not to close that handle.
3513
4d3fcc8e
BK
35142011-05-07 Ben Key <bkey76@gmail.com>
3515
3516 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3517 one of two shell specific rules, either bootstrap-temacs-CMD or
3518 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3519 to the previous implementation of the bootstrap-temacs rule.
3520 The bootstrap-temacs-CMD rule is similar to the previous
3521 implementation of the bootstrap-temacs rule except that it
3522 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3523 variable.
3524
3525 These changes, along with some changes to nt/configure.bat,
3526 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3527 earlier fix to add support for --cflags and --ldflags options
3528 that include quotes so that it works whether make uses cmd or
3529 sh as the shell.
3530
b4289b64
MA
35312011-05-06 Michael Albinus <michael.albinus@gmx.de>
3532
3533 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3534 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3535 is a constant.
3536 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3537 a string. Handle both cases.
3538 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3539 (Fdbus_register_method): Use Qinvalid_function.
3540
af4c0e28
JB
35412011-05-06 Juanma Barranquero <lekktu@gmail.com>
3542
3543 * makefile.w32-in: Update dependencies.
3544 (LISP_H): Add inttypes.h and stdin.h.
3545 (PROCESS_H): Add unistd.h.
3546
c51453d9
EZ
35472011-05-06 Eli Zaretskii <eliz@gnu.org>
3548
3549 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3550 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3551
8ff0ac3c 35522011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3553
4c4b566b
PE
3554 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3555
aab2b9b5
PE
3556 * term.c (vfatal): Remove stray call to va_end.
3557 It's not needed and the C Standard doesn't allow it here anyway.
3558
c378da0b
PE
3559 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3560 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3561
288b08c7
PE
3562 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3563 bytes.
3564
e3601888
PE
3565 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3566
db6c0e74
PE
3567 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3568
dd5963ea
PE
3569 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3570
88c9450f
PE
3571 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3572
2f9442b8
PE
3573 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3574
c032b5f8
PE
3575 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3576 * charset.c (Fdefine_charset_internal): Don't initialize
3577 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3578 32-bit int (Bug#8600).
a108c10b
PE
3579
3580 * lread.c (read_integer): Be more consistent with string-to-number.
3581 Use string_to_number to do the actual conversion; this avoids
3582 rounding errors and fixes some other screwups. Without this fix,
3583 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3584 (digit_to_number): Move earlier, for benefit of read_integer.
3585 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3586 not a digit in any supported base. (Bug#8602)
a108c10b 3587
ad5f9eea
PE
3588 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3589
aec1708a
PE
3590 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3591 to match comment at start of function. This also removes a
3592 GCC warning about overflow in a 32+64-bit port.
3593
47be4ab5
PE
3594 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3595
371cac43
PE
3596 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3597 Reported by Stefan Monnier in
3598 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3599 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3600 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3601
d01a7826
PE
3602 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3603 (EMACS_UINTPTR): Likewise, with uintptr_t.
3604
7fd47d5c
PE
3605 * lisp.h: Prefer 64-bit EMACS_INT if available.
3606 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3607 on 32-bit hosts that have 64-bit int, so that they can access
3608 large files.
122b0c86
PE
3609 However, temporarily disable this change unless the temporary
3610 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3611
8727937b
PE
3612 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3613
8ac068ac
PE
3614 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3615 This removes an assumption that EMACS_INT and long are the same
3616 width as pointers. The assumption is true for Emacs porting targets
3617 now, but we want to make other targets possible.
3618 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3619 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3620 In the rest of the code, change types of integers that hold casted
3621 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3622 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3623 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3624 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3625 No need to cast type when ORing.
3626 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3627 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3628 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3629 assume EMACS_INT is the same width as char *.
3630 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3631 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3632 Remove no-longer-needed casts.
3633 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3634 (xg_tool_bar_help_callback, xg_make_tool_item):
3635 Use EMACS_INTPTR to hold an integer
3636 that will be cast to void *; this can avoid a GCC warning
3637 if EMACS_INT is not the same width as void *.
3638 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3639 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3640 (current_message_1, set_message_1):
3641 Use a local to convert to proper width without a cast.
3642 * xmenu.c (dialog_selection_callback): Likewise.
3643
ede49d71
PE
3644 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3645 Also, don't assume VALBITS / RAND_BITS is less than 5,
3646 and don't rely on undefined behavior when shifting a 1 left into
3647 the sign bit.
3648 * lisp.h (get_random): Change signature to match.
3649
2f30ecd0
PE
3650 * lread.c (hash_string): Use size_t, not int, for hash computation.
3651 Normally we prefer signed values; but hashing is special, because
3652 it's better to use unsigned division on hash table sizes so that
3653 the remainder is nonnegative. Also, size_t is the natural width
3654 for hashing into memory. The previous code used 'int', which doesn't
3655 retain enough info to hash well into very large tables.
3656 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3657
2a866e7b
PE
3658 * dbusbind.c: Don't possibly lose pointer info when converting.
3659 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3660 Use XPNTR rather than XHASH, so that the high-order bits of
3661 the pointer aren't lost when converting through void *.
3662
51639eac
PE
3663 * eval.c (Fautoload): Don't double-shift a pointer.
3664
92394119
PE
3665 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3666
dbdb9a7c
JB
36672011-05-06 Juanma Barranquero <lekktu@gmail.com>
3668
3669 * gnutls.c (DEF_GNUTLS_FN):
3670 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3671
db7a0b4f
AS
36722011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3673
3674 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3675 marker. (Bug#8610)
3676
f7ff1b0f 36772011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3678
3679 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3680 New version that can reserve upto 2GB of heap space.
3681
f7ff1b0f 36822011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3683
3684 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3685
639c109b
TZ
36862011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3687
3688 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3689 `gnutls_certificate_set_x509_key_file'.
3690
d2127135
JB
36912011-05-05 Juanma Barranquero <lekktu@gmail.com>
3692
3693 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3694 Update dependencies.
3695
e968f4f3
JB
36962011-05-04 Juanma Barranquero <lekktu@gmail.com>
3697
3698 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3699 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3700 Remove unused parameter `fildes'.
3701 * process.c (read_process_output, send_process): Don't pass it.
3702
84d358f0
JB
37032011-05-04 Juanma Barranquero <lekktu@gmail.com>
3704
3705 Fix previous change: the library cache is defined in w32.c.
3706 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3707 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3708
0898ca10
JB
37092011-05-04 Juanma Barranquero <lekktu@gmail.com>
3710
3711 Implement dynamic loading of GnuTLS on Windows.
3712
3713 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3714 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3715 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3716 Declare.
3717
3718 * gnutls.c (Qgnutls_dll): Define.
3719 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3720 (gnutls_*): Declare function pointers.
3721 (init_gnutls_functions): New function to initialize function pointers.
3722 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3723 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3724 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3725 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3726 (emacs_gnutls_write, emacs_gnutls_read)
3727 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3728 (Fgnutls_available_p): New function.
3729 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3730 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3731 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3732
3733 * image.c: Include w32.h.
3734 (Vimage_type_cache): Delete.
3735 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3736 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3737 (w32_delayed_load): Move to w32.c.
3738
3739 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3740
3741 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3742 (w32_delayed_load): Move from image.c. When loading a library, record
3743 its filename in the :loaded-from property of the library id.
3744 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3745 Initialize and staticpro them.
3746 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3747
3748 * process.c: Include lisp.h before w32.h, not after.
3749 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3750 instead of gnutls_record_check_pending.
3751
3752 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3753
ff4de4aa
TZ
37542011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3755
3756 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3757 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3758 as passed in.
3759
abe95abb
JD
37602011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3761
3762 * xterm.c (x_set_frame_alpha): Do not set property on anything
3763 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3764
e16e55d4
JB
37652011-05-02 Juanma Barranquero <lekktu@gmail.com>
3766
3767 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3768
bafcf6a5
JB
37692011-05-02 Juanma Barranquero <lekktu@gmail.com>
3770
3771 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3772 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3773 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3774 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3775 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3776 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3777 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3778 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3779 (Qgnutls_bootprop_callbacks_verify): Make static.
3780
e7a6747f
AS
37812011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3782
19ed11ba
AS
3783 * callproc.c: Indentation fixup.
3784
e7a6747f 3785 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3786 (wait_for_termination, interruptible_wait_for_termination):
3787 Move after wait_for_termination_1.
e7a6747f 3788
1ef14cb4
LMI
37892011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3790
3791 * sysdep.c (interruptible_wait_for_termination): New function
3792 which is like wait_for_termination, but allows keyboard
3793 interruptions.
3794
3795 * callproc.c (Fcall_process): Add (:file "file") as an option for
3796 the STDOUT buffer.
3797 (Fcall_process_region): Ditto.
3798
330d880c
EZ
37992011-04-30 Eli Zaretskii <eliz@gnu.org>
3800
8db90b73
EZ
3801 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3802 rather than `XVECTOR (FOO)->size'.
3803
330d880c
EZ
3804 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3805 inttypes.h, as a gnulib replacement is used if it not available in
3806 system headers.
3807
15cbd324
EZ
38082011-04-21 Eli Zaretskii <eliz@gnu.org>
3809
3810 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3811 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3812 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3813
3814 * coding.c (coding_alloc_by_realloc): Error out if destination
3815 will grow beyond MOST_POSITIVE_FIXNUM.
3816 (decode_coding_emacs_mule): Abort if there isn't enough place in
3817 charbuf for the composition carryover bytes. Reserve an extra
3818 space for up to 2 characters produced in a loop.
3819 (decode_coding_iso_2022): Abort if there isn't enough place in
3820 charbuf for the composition carryover bytes.
3821
38222011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3823
ae940cca
EZ
3824 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3825 aborting when %lld or %lll format is passed.
3826 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3827 %llo or %llx format is passed. (Bug#8545)
3828
03ab8921
EZ
3829 * window.c (window_scroll_line_based): Use a marker instead of
3830 simple variables to record original value of point. (Bug#7952)
3831
afda1437
EZ
3832 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3833 produced by %s or %c overflows available buffer space. (Bug#8545)
3834
f76dee0c
PE
38352011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3836
3837 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3838 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3839
fdc5744d
JB
38402011-04-28 Juanma Barranquero <lekktu@gmail.com>
3841
3842 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3843
638f053a
JB
38442011-04-28 Juanma Barranquero <lekktu@gmail.com>
3845
3846 * keyboard.c (Qdelayed_warnings_hook): Define.
3847 (command_loop_1): Run `delayed-warnings-hook'
3848 if Vdelayed_warnings_list is non-nil.
3849 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3850 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3851
d178f871
EZ
38522011-04-28 Eli Zaretskii <eliz@gnu.org>
3853
3854 * doprnt.c (doprnt): Don't return value smaller than the buffer
3855 size if the message was truncated. (Bug#8545).
3856
b124fd93
JB
38572011-04-28 Juanma Barranquero <lekktu@gmail.com>
3858
3859 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3860 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3861
e810457d
PE
38622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3865
ea51cceb
JB
38662011-04-27 Juanma Barranquero <lekktu@gmail.com>
3867
3868 * makefile.w32-in: Update dependencies.
3869
94dcfacf
EZ
38702011-04-27 Eli Zaretskii <eliz@gnu.org>
3871
3872 Improve `doprnt' and its usage. (Bug#8545)
3873 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3874 `format_end'. Remove support for %l as a conversion specifier.
3875 Don't use xrealloc. Improve diagnostics when the %l size modifier
3876 is used. Update the commentary.
3877
3878 * eval.c (verror): Simplify calculation of size_t.
3879
3880 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3881 messages.
3882
f61f41d7
PE
38832011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3884
3885 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3886 change.
3887
96fb4434
PE
38882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3889
3890 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3891 This makes this file independent of the recent pseudovector change.
3892
671875da 38932011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3894
69e9b5a3
PE
3895 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3896
b5f869a7 3897 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3898 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3899 Remove unused local.
c8926152 3900 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3901
841a1577 3902 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3903 GCC 4.6.0 optimizes based on type-based alias analysis.
3904 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3905 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3906 != &v->size, and therefore "v->size = 1; b->size = 2; return
3907 v->size;" must therefore return 1. This assumption is incorrect
3908 for Emacs, since it type-puns struct Lisp_Vector * with many other
3909 types. To fix this problem, this patch adds a new type struct
f904488f 3910 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3911 and pseudovectors, and helps optimizing compilers not get fooled
3912 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3913 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3914 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3915 the size member.
eab3844f
PE
3916 (XSETPVECTYPE): Rewrite in terms of new macro.
3917 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3918 This is a bit clearer, and further avoids the possibility of
3919 undesirable aliasing.
3920 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3921 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3922 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3923 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3924 (ASIZE): Now uses header.size rather than size.
3925 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3926 to avoid the hassle of writing XVECTOR (foo)->header.size.
3927 (struct vectorlike_header): New type.
eab3844f
PE
3928 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3929 object, to help avoid aliasing.
3930 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3931 (SUBRP): Likewise, since Lisp_Subr is a special case.
3932 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3933 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3934 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3935 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3936 changed to be "header.size" and "header.next".
3937 * buffer.h (struct buffer): Likewise.
3938 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3939 * frame.h (struct frame): Likewise.
3940 * process.h (struct Lisp_Process): Likewise.
3941 * termhooks.h (struct terminal): Likewise.
3942 * window.c (struct save_window_data, struct saved_window): Likewise.
3943 * window.h (struct window): Likewise.
3944 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3945 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3946 * buffer.c (init_buffer_once): Likewise.
3947 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3948 special case.
3949 * process.c (Fformat_network_address): Use local var for size,
3950 for brevity.
3951
0df1eac5
PE
3952 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3953
847ab9d1 3954 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3955 * data.c (atof): Remove decl; no longer used or needed.
3956 (digit_to_number): Move to lread.c.
3957 (Fstring_to_number): Use new string_to_number function, to be
3958 consistent with how the Lisp reader treats infinities and NaNs.
3959 Do not assume that floating-point numbers represent EMACS_INT
3960 without losing information; this is not true on most 64-bit hosts.
3961 Avoid double-rounding errors, by insisting on integers when
3962 parsing non-base-10 numbers, as the documentation specifies.
3963 * lisp.h (string_to_number): New decl, replacing ...
3964 (isfloat_string): Remove.
bc0a5c13 3965 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3966 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3967 appears to have been a coding error. Similarly, do not accept
3968 strings like +-1e0 as floating point numbers. Do not report
3969 overflow for integer overflows unless the base is not 10 which
3970 means we have no simple and reliable way to continue.
3971 Break out the floating-point parsing into a new
3972 function string_to_number, so that Fstring_to_number parses
3973 floating point numbers consistently with the Lisp reader.
04f2d78b 3974 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3975 (E_CHAR, EXP_INT): Remove, replacing with ...
3976 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3977 (string_to_number): New function, replacing isfloat_string.
3978 This function checks for valid syntax and produces the resulting
3979 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3980 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3981 so that overflow for non-base-10 numbers is reported only when
3982 there's no portable and simple way to convert to floating point.
452f4150 3983
67769ffc
PE
3984 * textprop.c (set_text_properties_1): Rewrite for clarity,
3985 and to avoid GCC warning about integer overflow.
3986
c20db43f
PE
3987 * intervals.h (struct interval): Use EMACS_INT for members
3988 where EMACS_UINT might cause problems. See
3989 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3990 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3991 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3992 All uses changed.
37aa2f85
PE
3993 (offset_intervals): Tell GCC not to worry about length overflow
3994 when negating a negative length.
c20db43f 3995
2538aa2f
PE
3996 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3997 (overrun_check_free): Likewise.
3998
f2d3008d
PE
3999 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4000 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4001 word size.
4002
ec8df744
PE
4003 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4004 (gnutls_make_error): Rename local to avoid shadowing.
4005 (gnutls_emacs_global_deinit): ifdef out; not used.
4006 (Fgnutls_boot): Use const for pointer to readonly storage.
4007 Comment out unused local. Fix pointer signedness problems.
4008
640ee02d
PE
4009 * lread.c (openp): Don't stuff size_t into an 'int'.
4010 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4011 about possible signed overflow.
4012
6048fb2a
PE
4013 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4014 (GDK_KEY_g): Don't define if already defined.
4015 (xg_prepare_tooltip): Avoid pointer signedness problem.
4016 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4017
fa3c87e1
PE
4018 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4019 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4020
2172544b
PE
4021 * xfns.c (Fx_window_property): Simplify a bit,
4022 to make a bit faster and to avoid GCC 4.6.0 warning.
4023 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4024
9b821a21
PE
4025 * fns.c (internal_equal): Don't assume size_t fits in int.
4026
3c616cfa
PE
4027 * alloc.c (compact_small_strings): Tighten assertion a little.
4028
c2982e87
PE
4029 Replace pEd with more-general pI, and fix some printf arg casts.
4030 * lisp.h (pI): New macro, generalizing old pEd macro to other
4031 conversion specifiers. For example, use "...%"pI"d..." rather
4032 than "...%"pEd"...".
4033 (pEd): Remove. All uses replaced with similar uses of pI.
4034 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4035 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4036 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4037 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4038 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4039 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4040 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4041 64-bit hosts.
4042 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4043 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4044 * print.c (safe_debug_print, print_object): Likewise.
4045 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4046 to int.
6f04d126
PE
4047 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4048 avoiding the 0 flag, which is not portable.
c2982e87
PE
4049 * process.c (Fmake_network_process): Use pI to avoid cast.
4050 * region-cache.c (pp_cache): Likewise.
4051 * xdisp.c (decode_mode_spec): Likewise.
4052 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4053 behavior on 64-bit hosts with printf arg.
6f04d126 4054 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4055 (x_stop_queuing_selection_requests): Likewise.
4056 (x_get_window_property): Don't truncate byte count to an 'int'
4057 when tracing.
0b432f21 4058
5e073ec7
PE
4059 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4060 here, since it parses constructs like leading '-' and spaces,
4061 which are not wanted; and it overflows with large numbers.
4062 Instead, simply match F[0-9]+, which is what is wanted anyway.
4063
36372bf9
PE
4064 * alloc.c: Remove unportable assumptions about struct layout.
4065 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4066 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4067 (allocate_vectorlike, make_pure_vector): Use the new macros,
4068 plus offsetof, to remove unportable assumptions about struct layout.
4069 These assumptions hold on all porting targets that I know of, but
4070 they are not guaranteed, they're easy to remove, and removing them
4071 makes further changes easier.
4072
0b432f21
PE
4073 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4074 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4075 (string_overrun_cookie): Now const. Use initializers that
4076 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4077 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4078 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4079 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4080 multiple of sizeof (EMACS_INT); it need not be, if
4081 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4082 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4083
895009e1
JB
40842011-04-26 Juanma Barranquero <lekktu@gmail.com>
4085
4086 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4087
6a7a1b0b
TZ
40882011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4089
4090 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4091 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4092 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4093
841a1577 40942011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4095
4096 * lisp.h (Qdebug): List symbol.
895009e1 4097 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4098 * keyboard.c (debug-on-event): New variable.
4099 (handle_user_signal): Break into debugger when debug-on-event
4100 matches the current signal symbol.
4101
f2d3ba6f
DN
41022011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4103
4104 * alloc.c (check_sblock, check_string_bytes)
4105 (check_string_free_list): Convert to standard C.
4106
42ce4c63
TZ
41072011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4108
4109 * w32.c (emacs_gnutls_push): Fix typo.
4110
825cd63c
EZ
41112011-04-25 Eli Zaretskii <eliz@gnu.org>
4112
fb11d64d
EZ
4113 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4114 "cast to pointer from integer of different size".
4115
825cd63c
EZ
4116 Improve doprnt and its use in verror. (Bug#8545)
4117 * doprnt.c (doprnt): Document the set of format control sequences
4118 supported by the function. Use SAFE_ALLOCA instead of always
4119 using `alloca'.
4120
4121 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4122 is one byte too soon. Don't use xrealloc; instead xfree and
4123 xmalloc anew.
4124
e061a11b
TZ
41252011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4126
4127 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4128 callbacks stage.
4129
4130 * gnutls.c: Renamed global_initialized to
4131 gnutls_global_initialized. Added internals for the
4132 :verify-hostname-error, :verify-error, and :verify-flags
4133 parameters of `gnutls-boot' and documented those parameters in the
4134 docstring. Start callback support.
9173deec
JB
4135 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4136 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4137 on error. Return error code.
e061a11b
TZ
4138 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4139 (emacs_gnutls_read): Likewise.
4140 (Fgnutls_boot): Return handshake error code.
4141 (emacs_gnutls_handle_error): New function.
4142 (wsaerror_to_errno): Likewise.
4143
4144 * w32.h (emacs_gnutls_pull): Add prototype.
4145 (emacs_gnutls_push): Likewise.
4146
4147 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4148 (emacs_gnutls_push): Likewise.
4149
41502011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4151
4152 * process.c (wait_reading_process_output): Check if GnuTLS
4153 buffered some data internally if no FDs are set for TLS
4154 connections.
4155
4156 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4157 (LIBS): Link to USER_LIBS.
4158 ($(BLD)/gnutls.$(0)): New target.
4159
fa6996bc
EZ
41602011-04-24 Eli Zaretskii <eliz@gnu.org>
4161
eb35682e
EZ
4162 * xdisp.c (handle_single_display_spec): Rename the
4163 display_replaced_before_p argument into display_replaced_p, to
4164 make it consistent with the commentary. Fix typos in the
4165 commentary.
4166
e2ad650c
EZ
4167 * textprop.c (syms_of_textprop): Remove dead code.
4168 (copy_text_properties): Delete obsolete commentary about an
4169 interface that was deleted long ago. Fix typos in the description
4170 of arguments.
4171
1b2de274
EZ
4172 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4173 to changes in oldXMenu/XMenu.h from 2011-04-16.
4174 <menu_help_message, prev_menu_help_message>: Constify.
4175 (IT_menu_make_room): menu->help_text is now `const char **';
4176 adjust.
4177
4178 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4179 to changes in oldXMenu/XMenu.h from 2011-04-16.
4180 (struct XMenu): Declare `help_text' `const char **'.
4181
4182 * xfaces.c <Qunspecified>: Make extern again.
4183
4184 * syntax.c: Include sys/types.h before including regex.h, as
4185 required by Posix.
4186
762b15be
EZ
4187 * doc.c (get_doc_string): Improve the format passed to `error'.
4188
4189 * doprnt.c (doprnt): Improve commentary.
4190
4191 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4192
4193 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4194 them with etags.
4195
f1052e5d
EZ
4196 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4197 changes in globals.h immediately force recompilation.
762b15be
EZ
4198 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4199 $(CURDIR)/s/ms-w32.h.
4200 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4201
fa6996bc
EZ
4202 * character.c (Fchar_direction): Function deleted.
4203 (syms_of_character): Don't defsubr it.
4204 <char-direction-table>: Deleted.
4205
e6c3da20
EZ
42062011-04-23 Eli Zaretskii <eliz@gnu.org>
4207
4208 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4209 * doprnt.c: Include limits.h.
4210 (SIZE_MAX): New macro.
04f2d78b
CB
4211 (doprnt): Return a size_t value. 2nd arg is now size_t.
4212 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4213 Improve overflow protection. Support `l' modifier for integer
4214 conversions. Support %l conversion. Don't assume an EMACS_INT
4215 argument for integer conversions and for %c.
4216
4217 * lisp.h (doprnt): Restore prototype.
4218
4219 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4220 $(SRC)/character.h.
4221
4222 * Makefile.in (base_obj): Add back doprnt.o.
4223
4224 * deps.mk (doprnt.o): Add back prerequisites.
4225 (callint.o): Depend on character.h.
4226
4227 * eval.c (internal_lisp_condition_case): Include the handler
4228 representation in the error message.
4229 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4230 when breaking from the loop.
4231
4232 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4233
4234 * callint.c (Fcall_interactively): When displaying error message
4235 about invalid control letter, pass the character's codepoint, not
4236 a pointer to its multibyte form. Improve display of the character
4237 in octal and display also its hex code.
4238
4239 * character.c (char_string): Use %x to display the (unsigned)
4240 codepoint of an invalid character, to avoid displaying a bogus
4241 negative value.
4242
4243 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4244 `error', not SYMBOL_NAME itself.
4245
4246 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4247 character arguments to `error'.
4248
4249 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4250 to `error' in error message about FINAL_CHAR argument. Make sure
4251 FINAL_CHAR is a character, and use %c when it is passed as
4252 argument to `error'.
4253
4ffd0d6b 42542011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4255
4256 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4257
4258 * w32.c: Include <time.h>.
4259 (sys_localtime): New function.
4260
4ffd0d6b 42612011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4262
4263 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4264
4ffd0d6b 4265 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4266
4ffd0d6b 42672011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4268
4ffd0d6b
GM
4269 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4270 zombies (Bug#8467).
aac0c6e3 4271
04c56954
EZ
42722011-04-19 Eli Zaretskii <eliz@gnu.org>
4273
4274 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4275 gl_state.e_property when gl_state.object is Qt.
4276
4277 * insdel.c (make_gap_larger): Remove limitation of buffer size
4278 to <= INT_MAX.
4279
16a43933
CY
42802011-04-18 Chong Yidong <cyd@stupidchicken.com>
4281
4282 * xdisp.c (lookup_glyphless_char_display)
4283 (produce_glyphless_glyph): Handle cons cell entry in
4284 glyphless-char-display.
4285 (Vglyphless_char_display): Document it.
4286
4287 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4288 glyphless-char-display.
4289
4581706e
CY
42902011-04-17 Chong Yidong <cyd@stupidchicken.com>
4291
4292 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4293
4294 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4295
4296 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4297 definition for no-X builds.
4298
4887c6e2 42992011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4300
fd35b6f9
PE
4301 Static checks with GCC 4.6.0 and non-default toolkits.
4302
5c1ccb01
PE
4303 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4304
006c5daa
PE
4305 * process.c (keyboard_bit_set): Define only if SIGIO.
4306 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4307 (send_process): Repair possible setjmp clobbering.
4308
efc736d3
PE
4309 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4310
4e2fe2e6
PE
4311 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4312
f97334a2
PE
4313 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4314
4e75f29d
PE
4315 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4316 Define only if needed.
4317
90efadd1
PE
4318 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4319 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4320 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4321
3c647824
PE
4322 * dispextern.h (struct redisplay_interface): Rename param
4323 to avoid shadowing.
e264f262 4324 * termhooks.h (struct terminal): Likewise.
761383f4 4325 * xterm.c (xembed_send_message): Likewise.
3c647824 4326
b58c5c4a
PE
4327 * insdel.c (make_gap_smaller): Define only if
4328 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4329
cad59032
PE
4330 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4331 it.
4332
c339dc2e
PE
4333 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4334 so that we aren't warned about unused symbols.
4335
91a3e27b
PE
4336 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4337
399c71d3 4338 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4339
8ffc96f5
PE
4340 * xfns.c (x_real_positions): Mark locals as initialized.
4341
eef9bc79
PE
4342 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4343
098db9dd
PE
4344 * xterm.c: Fix problems found by static analysis with other toolkits.
4345 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4346 (x_dispatch_event): Declare static if USE_GTK, and
4347 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4348 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4349 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4350 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4351 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4352
eb18f6cc
PE
4353 * xmenu.c (menu_help_callback): Pointer type fixes.
4354 Use const pointers when pointing at readonly data. Avoid pointer
4355 signedness clashes.
4356 (FALSE): Remove unused macro.
4357 (update_frame_menubar): Remove unused decl.
4358
1fe72bf8
PE
4359 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4360
60d9e1db
PE
4361 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4362 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4363 (single_menu_item): Rename local to avoid shadowing.
4364
39261c26
PE
4365 * keyboard.c (make_lispy_event): Remove unused local var.
4366
018c5e19
PE
4367 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4368 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4369
63d2b86e
PE
4370 * bitmaps: Change bitmaps from unsigned char back to the X11
4371 compatible char. Avoid the old compiler warnings about
4372 out-of-range initializers by using, for example, '\xab' rather
4373 than 0xab.
4374
aefd87e1
PE
4375 * xgselect.c (xgselect_initialize): Check vs interface
4376 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4377
bf501fb9
PE
4378 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4379
e9829fdf
PE
4380 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4381 to read-only memory.
4382
1086c095
PE
4383 * fns.c (vector): Remove; this old hack is no longer needed.
4384
2baccd04 4385 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4386 Remove unused var.
dde42981 4387 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4388
72391843 4389 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4390
436c16df 4391 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4392 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4393 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4394
92bb796d 4395 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4396 (x_term_init): Remove local to avoid shadowing.
92bb796d 4397
764430a3 4398 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4399
4400 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4401 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4402
d1dfb56c
EZ
44032011-04-16 Eli Zaretskii <eliz@gnu.org>
4404
c4354cb4
EZ
4405 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4406
d1dfb56c
EZ
4407 Fix regex.c, syntax.c and friends for buffers > 2GB.
4408 * syntax.h (struct gl_state_s): Declare character position members
4409 EMACS_INT.
4410
4411 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4412
04f2d78b
CB
4413 * textprop.c (verify_interval_modification, interval_of):
4414 Declare arguments EMACS_INT.
d1dfb56c
EZ
4415
4416 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4417 EMACS_INT.
4418
4419 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4420
4421 * indent.c (Fvertical_motion): Local variable it_start is now
4422 EMACS_INT.
4423
4424 * regex.c (re_match, re_match_2, re_match_2_internal)
4425 (bcmp_translate, regcomp, regexec, print_double_string)
4426 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4427 (re_compile_pattern, re_exec): Declare arguments and local
4428 variables `size_t' and `ssize_t' and return values `regoff_t', as
4429 appropriate.
4430 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4431 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4432 <compile_stack_type>: `size' and `avail' are now `size_t'.
4433
4434 * regex.h <regoff_t>: Use ssize_t, not int.
4435 (re_search, re_search_2, re_match, re_match_2): Arguments that
4436 specify buffer/string position and length are now ssize_t and
4437 size_t. Return type is regoff_t.
4438
613052cd
BK
44392011-04-16 Ben Key <bkey76@gmail.com>
4440
4441 * nsfont.m: Fixed bugs in ns_get_family and
4442 ns_descriptor_to_entity that were caused by using free to
4443 deallocate memory blocks that were allocated by xmalloc (via
4444 xstrdup). This caused Emacs to crash when compiled with
4445 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4446 --enable-checking=xmallocoverrun). xfree is now used to
4447 deallocate these memory blocks.
4448
4170f62f 44492011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4450
71b41406
PE
4451 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4452
9587a89d
PE
4453 emacs_write: Accept and return EMACS_INT for sizes.
4454 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4455 et seq.
4456 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4457 Accept and return EMACS_INT.
4458 (emacs_gnutls_write): Return the number of bytes written on
4459 partial writes.
4460 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4461 (emacs_read, emacs_write): Remove check for negative size, as the
4462 Emacs source code has been audited now.
9587a89d
PE
4463 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4464 (emacs_read, emacs_write): Use it.
273a5f82
PE
4465 * process.c (send_process): Adjust to the new signatures of
4466 emacs_write and emacs_gnutls_write. Do not attempt to store
4467 a byte offset into an 'int'; it might overflow.
9587a89d 4468 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4469
3e047f51
PE
4470 * sound.c: Don't assume sizes fit in 'int'.
4471 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4472 Return EMACS_INT, not int.
3e047f51 4473 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4474 Accept EMACS_INT, not int.
4475 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4476 record read return values.
4477
cc39a9db
BK
44782011-04-15 Ben Key <bkey76@gmail.com>
4479
c9d0ec6d
JB
4480 * keyboard.c (Qundefined): Don't declare static since it is used
4481 in nsfns.m.
4482 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4483 static since they are used in nsfont.m.
cc39a9db 4484
6c60eb9f
SM
44852011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4486
4487 * process.c (Qprocessp): Don't declare static.
4488 * lisp.h (Qprocessp): Declare again.
4489
7990b61a
JB
44902011-04-15 Juanma Barranquero <lekktu@gmail.com>
4491
4492 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4493
5d4cb038
PE
44942011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4495
8bd7b830 4496 Improve C-level modularity by making more things 'static'.
cd64ea1d 4497
e3b27b31
PE
4498 Don't publish debugger-only interfaces to other modules.
4499 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4500 (verify_bytepos, count_markers): Move decls to the only modules
4501 that need them.
4502 * region-cache.h (pp_cache): Likewise.
4503 * window.h (check_all_windows): Likewise.
4504 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4505
5d4cb038
PE
4506 * sysdep.c (croak): Now static, if
4507 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4508 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4509
4510 * alloc.c (refill_memory_reserve): Now static if
4511 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4512 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4513
e87b6180
PE
4514 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4515 Define only if USE_LUCID.
4516
ac64929e
PE
4517 * xrdb.c (x_customization_string, x_rm_string): Now static.
4518
6f37259d
PE
4519 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4520 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4521
1683e3ab
PE
4522 * xdisp.c (draw_row_with_mouse_face): Now static.
4523 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4524
de9c2632
PE
4525 * window.h (check_all_windows): Mark externally visible.
4526
2b96acb7
PE
4527 * window.c (window_deletion_count): Now static.
4528
4529 * undo.c: Make symbols static if they're not exported.
4530 (last_undo_buffer, last_boundary_position, pending_boundary):
4531 Now static.
4532
50436f33
PE
4533 * textprop.c (interval_insert_behind_hooks): Now static.
4534 (interval_insert_in_front_hooks): Likewise.
4535
64520e5c
PE
4536 * term.c: Make symbols static if they're not exported.
4537 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4538 (max_frame_lines, tty_set_terminal_modes):
4539 (tty_reset_terminal_modes, tty_turn_off_highlight):
4540 (get_tty_terminal): Now static.
4541 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4542 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4543 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4544 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4545 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4546
1fa53021
PE
4547 * sysdep.c: Make symbols static if they're not exported.
4548 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4549 Now static.
4550 (sigprocmask_set, full_mask): Remove; unused.
4551 (wait_debugging): Mark as visible.
4552 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4553 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4554
d4b43b22
PE
4555 * syntax.c (syntax_temp): Define only if !__GNUC__.
4556
b7c513d0
PE
4557 * sound.c (current_sound_device, current_sound): Now static.
4558
989b29ad
PE
4559 * search.c (searchbufs, searchbuf_head): Now static.
4560
13a55a78
PE
4561 * scroll.c (scroll_cost): Remove; unused.
4562 * dispextern.h (scroll_cost): Remove decl.
4563
de68a1fc
PE
4564 * region-cache.h (pp_cache): Mark as externally visible.
4565
40ccffa6
PE
4566 * process.c: Make symbols static if they're not exported.
4567 (process_tick, update_tick, create_process, chan_process):
4568 (Vprocess_alist, proc_buffered_char, datagram_access):
4569 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4570 (deactivate_process): Mark defn as static, as well as decl.
4571 * lisp.h (create_process): Remove decl.
4572 * process.h (chan_process, Vprocess_alist): Remove decls.
4573
ad64fc97
PE
4574 * print.c: Make symbols static if they're not exported.
4575 (print_depth, new_backquote_output, being_printed, print_buffer):
4576 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4577 (print_interval, print_number_index, initial_stderr_stream):
4578 Now static.
4579 * lisp.h (Fprinc): Remove decl.
4580 (debug_output_compilation_hack): Mark as externally visible.
4581
adddb265
PE
4582 * sysdep.c (croak): Move decl from here to syssignal.h.
4583 * syssignal.h (croak): Put it here, so the API can be checked when
4584 'croak' is called from dissociate_if_controlling_tty.
4585
1717ede2
PE
4586 * minibuf.c: Make symbols static if they're not exported.
4587 (minibuf_save_list, choose_minibuf_frame): Now static.
4588 * lisp.h (choose_minibuf_frame): Remove decl.
4589
fa5fb2bc
PE
4590 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4591
1e3890d1
PE
4592 * lread.c: Make symbols static if they're not exported.
4593 (read_objects, initial_obarray, oblookup_last_bucket_number):
4594 Now static.
4595 (make_symbol): Remove; unused.
4596 * lisp.h (initial_obarray, make_symbol): Remove decls.
4597
8a1414fa
PE
4598 * keyboard.c: Make symbols static if they're not exported.
4599 (single_kboard, recent_keys_index, total_keys, recent_keys):
4600 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4601 (this_single_command_key_start, echoing, last_auto_save):
4602 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4603 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4604 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4605 (Vlispy_mouse_stem, double_click_count):
4606 Now static.
4607 (force_auto_save_soon): Define only if SIGDANGER.
4608 (ignore_mouse_drag_p): Now static if
4609 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4610 (print_help): Remove; unused.
4611 (stop_character, last_timer_event): Mark as externally visible.
4612 * keyboard.h (ignore_mouse_drag_p): Declare only if
4613 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4614 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4615 * lisp.h (echoing): Remove decl.
4616 (force_auto_save_soon): Declare only if SIGDANGER.
4617 * xdisp.c (redisplay_window): Simplify code, to make it more
4618 obvious that ignore_mouse_drag_p is not accessed if !defined
4619 USE_GTK && !defined HAVE_NS.
4620
93ea6e8f
PE
4621 * intervals.c: Make symbols static if they're not exported.
4622 (merge_properties_sticky, merge_interval_right, delete_interval):
4623 Now static.
4624 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4625
77382fcc
PE
4626 * insdel.c: Make symbols static if they're not exported.
4627 However, leave prepare_to_modify_buffer alone. It's never
4628 called from outside this function, but that appears to be a bug.
4629 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4630 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4631 (adjust_after_replace_noundo): Remove; unused.
4632 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4633 (signal_before_change): Remove decls.
77382fcc 4634
9306c32e
PE
4635 * indent.c (val_compute_motion, val_vmotion): Now static.
4636
cd44d2eb
PE
4637 * image.c: Make symbols static if they're not exported.
4638 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4639 if USE_GTK.
4640 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4641 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4642
ad9a7a06
PE
4643 * fringe.c (standard_bitmaps): Now static.
4644 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4645
81626931
PE
4646 * frame.c: Make symbols static if they're not exported.
4647 (x_report_frame_params, make_terminal_frame): Now static.
4648 (get_frame_param): Now static, unless HAVE_NS.
4649 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4650 (x_get_resource_string): Remove; not used.
4651 * frame.h (make_terminal_frame, x_report_frame_params):
4652 (x_get_resource_string); Remove decls.
4653 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4654 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4655
239f9db9
PE
4656 * font.c, fontset.c: Make symbols static if they're not exported.
4657 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4658 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4659 * font.c (font_close_object): Now static.
4660 * font.h (font_close_object): Remove.
4661 * fontset.c (FONTSET_OBJLIST): Remove.
4662 (free_realized_fontset) #if-0 the body, which does nothing.
4663 (face_suitable_for_char_p): #if-0, as it's never called.
4664 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4665 * xfaces.c (face_at_string_position):
4666 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4667 since 0 is always ASCII.
4668
dfcf3579
PE
4669 * fns.c (weak_hash_tables): Now static.
4670
5045092b
PE
4671 * fileio.c: Make symbols static if they're not exported.
4672 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4673 (Vwrite_region_annotation_buffers): Now static.
4674
57a96f5c
PE
4675 * eval.c: Make symbols static if they're not exported.
4676 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4677 * lisp.h (backtrace_list): Remove decl.
4678
35f08c38
PE
4679 * emacs.c: Make symbols static if they're not exported.
4680 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4681 (fatal_error_code, fatal_error_signal_hook, standard_args):
4682 Now static.
4683 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4684 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4685 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4686 * lisp.h (fatal_error_signal_hook): Remove decl.
4687 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4688
f44bd759
PE
4689 * editfns.c: Move a (normally-unused) function to its only use.
4690 * editfns.c, lisp.h (get_operating_system_release): Remove.
4691 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4692 worth the hassle of breaking this out.
4693
b532497d
PE
4694 * xterm.c: Make symbols static if they're not exported.
4695 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4696 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4697 (x_destroy_window, x_delete_display):
4698 Now static.
4699 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4700 (x_mouse_leave): Remove; unused.
4701 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4702 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4703 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4704 Remove decls.
4705 (x_mouse_leave): Declare only if WINDOWSNT.
4706 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4707 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4708 USE_X_TOOLKIT.
4709
1675728f
PE
4710 * ftxfont.c: Make symbols static if they're not exported.
4711 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4712 HAVE_FREETYPE.
4713 * font.h (ftxfont_driver): Likewise.
4714
e4cebfca
PE
4715 * xfns.c: Make symbols static if they're not exported.
4716 (x_last_font_name, x_display_info_for_name):
4717 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4718 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4719 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4720 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4721 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4722 (last_show_tip_args): Now static.
4723 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4724 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4725 (x_screen_planes): Remove; unused.
4726 * dispextern.h (x_screen_planes): Remove decl.
4727
5bf46f05
PE
4728 * dispnew.c: Make symbols static if they're not exported.
4729 * dispextern.h (redraw_garbaged_frames, scrolling):
4730 (increment_row_positions): Remove.
4731 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4732 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4733 Now static.
4734 (redraw_garbaged_frames): Remove; unused.
4735
435f4c28
PE
4736 * xfaces.c: Make symbols static if they're not exported.
4737 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4738 Remove decls.
4739 * xterm.h (defined_color): Remove decls.
4740 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4741 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4742 (menu_face_changed_default, defined_color, free_realized_face):
4743 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4744 (ascii_face_of_lisp_face): Remove; unused.
4745
8524aef3
PE
4746 * xdisp.c: Make symbols static if they're not exported.
4747 * dispextern.h (scratch_glyph_row, window_box_edges):
4748 (glyph_to_pixel_coords, set_cursor_from_row):
4749 (get_next_display_element, set_iterator_to_next):
4750 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4751 (show_mouse_face): Remove decls
4752 * frame.h (message_buf_print): Likewise.
4753 * lisp.h (pop_message, set_message, check_point_in_composition):
4754 Likewise.
4755 * xterm.h (set_vertical_scroll_bar): Likewise.
4756 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4757 (message_buf_print, scratch_glyph_row, displayed_buffer):
4758 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4759 (get_next_display_element, show_mouse_face, window_box_edges):
4760 (frame_to_window_pixel_xy, check_point_in_composition):
4761 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4762 (glyph_to_pixel_coords): Remove; unused.
4763
16390cd2
PE
4764 * dired.c (file_name_completion): Now static.
4765
4766 * dbusbind.c (xd_in_read_queued_messages): Now static.
4767
a25f4dfa
PE
4768 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4769 * data.c (circular_list_error): Remove.
4770
14a9c8df
PE
4771 * commands.h (last_point_position, last_point_position_buffer):
4772 (last_point_position_window): Remove decls.
4773 * keyboard.c: Make these variables static.
4774
04f2d78b
CB
4775 * coding.h (coding, code_convert_region, encode_coding_gap):
4776 Remove decls.
74ab6df5
PE
4777 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4778 (iso_code_class, detect_coding, code_convert_region): Now static.
4779 (encode_coding_gap): Remove; unused.
4780
38dfbee1
PE
4781 * chartab.c (chartab_chars, chartab_bits): Now static.
4782
a2cb4e63
PE
4783 * charset.h (charset_iso_8859_1): Remove decl.
4784 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4785 Now static.
4786
127198fd
PE
4787 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4788 * ccl.c (Vccl_program_table): Now static.
4789 (check_ccl_update): Remove; unused.
4790
d85b608f
PE
4791 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4792 * category.h: ... from here.
4793 * category.c (check_category_table, set_category_set): Now static.
4794
31cd66f3
PE
4795 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4796 * lisp.h: Remove these decls.
4797
c358e587
PE
4798 * buffer.c (buffer_count): Remove unused var.
4799
e78aecca
PE
4800 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4801 so that it's not optimized away.
4802 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4803 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4804 exported only to the debugger.
4805
e192d7d3 4806 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4807 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4808
92470028
PE
4809 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4810 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4811 was inaccessible from Lisp.
4812 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4813 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4814
244ed907
PE
4815 alloc.c: Import and export fewer symbols, and remove unused items.
4816 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4817 is defined.
4818 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4819 it's not optimized away by whole-program optimization.
4820 (message_enable_multibyte, free_misc): Remove.
4821 (catchlist, handlerlist, mark_backtrace):
4822 Declare only if BYTE_MARK_STACK.
4823 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4824 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4825 (message_enable_multibyte): Remove decl.
4826 (free_misc, interval_free_list, float_block, float_block_index):
4827 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4828 (cons_free_list, last_marked_index):
4829 Now static.
4830 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4831 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4832 (mark_backtrace): Define only if BYTE_MARK_STACK.
4833 * xdisp.c (message_enable_multibyte): Now static.
4834
61c2b50e 4835 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4836 This makes it easier for human readers (and static analyzers)
4837 to see whether these variables are used from other modules.
4838 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4839 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4840 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4841 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4842 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4843 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4844 * xmenu.c, xselect.c:
4845 Declare Q* vars static if they are not used in other modules.
4846 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4847 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4848 Remove decls of unexported vars.
4849 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4850
95c82688
PE
4851 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4852
16a97296
PE
4853 Make Emacs functions such as Fatom 'static' by default.
4854 This makes it easier for human readers (and static analyzers)
4855 to see whether these functions can be called from other modules.
4856 DEFUN now defines a static function. To make the function external
4857 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4858 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4859 (Finit_image_library):
16a97296
PE
4860 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4861 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4862 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4863 Remove decls, since these functions are now static.
4864 (Funintern, Fget_internal_run_time): New decls, since these functions
4865 were already external.
95c82688 4866
16a97296
PE
4867 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4868 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4869 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4870 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4871 * keyboard.c, keymap.c, lread.c:
4872 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4873 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4874 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4875 Mark functions with DEFUE instead of DEFUN,
4876 if they are used in other modules.
4877 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4878 decls for now-static functions.
4879 * buffer.h (Fdelete_overlay): Remove decl.
4880 * callproc.c (Fgetenv_internal): Mark as internal.
4881 * composite.c (Fremove_list_of_text_properties): Remove decl.
4882 (Fcomposition_get_gstring): New forward static decl.
4883 * composite.h (Fcomposite_get_gstring): Remove decl.
4884 * dired.c (Ffile_attributes): New forward static decl.
4885 * doc.c (Fdocumntation_property): New forward static decl.
4886 * eval.c (Ffetch_bytecode): New forward static decl.
4887 (Funintern): Remove extern decl; now in .h file where it belongs.
4888 * fileio.c (Fmake_symbolic_link): New forward static decl.
4889 * image.c (Finit_image_library): New forward static decl.
4890 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4891 * intervals.h (Fprevious_property_change):
4892 (Fremove_list_of_text_properties): Remove decls.
4893 * keyboard.c (Fthis_command_keys): Remove decl.
4894 (Fcommand_execute): New forward static decl.
4895 * keymap.c (Flookup_key): New forward static decl.
4896 (Fcopy_keymap): Now static.
4897 * keymap.h (Flookup_key): Remove decl.
4898 * process.c (Fget_process): New forward static decl.
4899 (Fprocess_datagram_address): Mark as internal.
4900 * syntax.c (Fsyntax_table_p): New forward static decl.
4901 (skip_chars): Remove duplicate decl.
4902 * textprop.c (Fprevious_property_change): New forward static decl.
4903 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4904 Now internal.
4905 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4906 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4907
785bbd42
PE
4908 * editfns.c (Fformat): Remove unreachable code.
4909
8b913b57
AS
49102011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4911
4912 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4913 change. (Bug#8496)
4914
a6744a35
EZ
49152011-04-13 Eli Zaretskii <eliz@gnu.org>
4916
4917 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4918 when at ZV. (Bug#8487)
4919
e7974947
AS
49202011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4921
baad03f0
AS
4922 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4923 (Bug#8437)
4924 * keyboard.c (parse_tool_bar_item): Likewise.
4925 * sound.c (sound_cleanup, alsa_close): Likewise.
4926 * termcap.c (tgetent): Likewise.
4927 * xfns.c (x_default_font_parameter): Likewise.
4928 * xsettings.c (read_and_apply_settings): Likewise.
4929
e7974947
AS
4930 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4931 (overrun_check_free): Protoize.
4932
28272684
PE
49332011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4934
4935 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4936 since callers should never pass a negative size.
4937 Change the signature to match that of plain 'read' and 'write'; see
4938 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4939 * lisp.h: Update prototypes of emacs_write and emacs_read.
4940
11997c76
EZ
49412011-04-11 Eli Zaretskii <eliz@gnu.org>
4942
4943 * xdisp.c (redisplay_window): Don't try to determine the character
4944 position of the scroll margin if the window start point w->startp
e896f03c 4945 is outside the buffer's accessible region. (Bug#8468)
11997c76 4946
8a2cbd72
EZ
49472011-04-10 Eli Zaretskii <eliz@gnu.org>
4948
4949 Fix write-region and its subroutines for buffers > 2GB.
4950 * fileio.c (a_write, e_write): Modify declaration of arguments and
4951 local variables to support buffers larger than 2GB.
4952 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4953
4954 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4955 argument, local variables, and return value.
4956
4957 * lisp.h: Update prototypes of emacs_write and emacs_read.
4958
4959 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4960
4073e537 49612011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4962
1ebfdcb6
PE
4963 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4964
b2ded58d
PE
4965 Fix more problems found by GCC 4.6.0's static checks.
4966
7d66342c
PE
4967 * xdisp.c (vmessage): Use a better test for character truncation.
4968
bbf47d44
PE
4969 * charset.c (load_charset_map): <, not <=, for optimization,
4970 and to avoid potential problems with integer overflow.
9248994d 4971 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4972 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4973 * editfns.c (Fformat): Likewise.
1e69125e 4974 * syntax.c (skip_chars): Likewise.
3befa583 4975
e3019616
PE
4976 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4977 This also lets GCC 4.6.0 generate slightly better loop code.
4978
becfa255
PE
4979 * callint.c (Fcall_interactively): <, not <=, for optimization.
4980 (Fcall_interactively): Count the number of arguments produced,
4981 not the number of arguments given. This is simpler and lets GCC
4982 4.6.0 generate slightly better code.
4983
dae0cd48
PE
4984 * ftfont.c: Distingish more carefully between FcChar8 and char.
4985 The previous code passed unsigned char * to a functions like
4986 strlen and xstrcasecmp that expect char *, which does not
4987 conform to the C standard.
4988 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4989 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4990 char * when the C standard requires it.
4991
76032d70
PE
4992 * keyboard.c (read_char): Remove unused var.
4993
eb3f1cc8
PE
4994 * eval.c: Port to Windows vsnprintf (Bug#8435).
4995 Include <limits.h>.
4996 (SIZE_MAX): Define if the headers do not.
4997 (verror): Do not give up if vsnprintf returns a negative count.
4998 Instead, grow the buffer. This ports to Windows vsnprintf, which
4999 does not conform to C99. Problem reported by Eli Zaretskii.
5000 Also, simplify the allocation scheme, by avoiding the need for
5001 calling realloc, and removing the ALLOCATED variable.
5002
70476b54
PE
5003 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5004
12020a9e
PE
5005 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5006 But keep the doprint source code for now, as we might revamp it
5007 and use it again (Bug#8435).
ea6c7ae6
PE
5008 * lisp.h (doprnt): Remove.
5009 * Makefile.in (base_obj): Remove doprnt.o.
5010 * deps.mk (doprnt.o): Remove.
5011
5fdb398c
PE
5012 error: Print 32- and 64-bit integers portably (Bug#8435).
5013 Without this change, on typical 64-bit hosts error ("...%d...", N)
5014 was used to print both 32- and 64-bit integers N, which relied on
5015 undefined behavior.
5016 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5017 New macro.
5018 * lisp.h (error, verror): Mark as printf-like functions.
5019 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5020 Report overflow in size calculations when allocating printf buffer.
5021 Do not truncate output string at its first null byte.
5022 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5023 Truncate the output at a character boundary, since vsnprintf does not
5024 do that.
5025 * charset.c (check_iso_charset_parameter): Convert internal
5026 character to string before calling 'error', since %c now has the
5027 printf meaning.
5028 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5029 overflow when computing char to be passed to 'error'. Do not
5030 pass Lisp_Object to 'error'; pass the integer instead.
5031 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5032 formatted with plain %d.
5033
b189fa66
PE
5034 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5035
bff87ef0
PE
5036 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5037
7e2cac20
PE
5038 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5039
ce4d90b5
PE
5040 * xterm.c (x_catch_errors): Remove duplicate declaration.
5041
266c9547
PE
5042 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5043
79c49ad2
PE
5044 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5045
368f4090
JM
50462011-04-10 Jim Meyering <meyering@redhat.com>
5047
5048 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5049 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5050 return ssize_t not "int", and use size_t as the buffer length.
5051 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5052 * gnutls.h: Update declarations.
5053 * process.c (read_process_output): Use ssize_t, to match.
5054 (send_process): Likewise.
5055
a32d4040
CY
50562011-04-09 Chong Yidong <cyd@stupidchicken.com>
5057
5058 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5059
8546720e 50602011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5061
04f2d78b
CB
5062 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5063 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5064
8546720e
GM
5065 * xterm.c (handle_one_xevent):
5066 * xmenu.c (create_and_show_popup_menu):
5067 * xselect.c (x_decline_selection_request)
5068 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5069
0a2f5c1a 50702011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5071
5072 Fix some uses of `int' instead of EMACS_INT.
5073 * search.c (string_match_1, fast_string_match)
5074 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5075 (scan_buffer, find_next_newline_no_quit)
5076 (find_before_next_newline, search_command, Freplace_match)
5077 (Fmatch_data): Make some `int' variables be EMACS_INT.
5078
5079 * xdisp.c (display_count_lines): 3rd argument and return value now
5080 EMACS_INT. All callers changed.
5081 (pint2hrstr): Last argument is now EMACS_INT.
5082
5083 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5084 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5085 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5086 (decode_coding_utf_16, decode_coding_emacs_mule)
5087 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5088 (decode_coding_ccl, decode_coding_charset)
5089 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5090 (decode_coding_iso_2022, decode_coding_emacs_mule)
5091 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5092 <char_offset, last_offset>: Declare EMACS_INT.
5093 (encode_coding_utf_8, encode_coding_utf_16)
5094 (encode_coding_emacs_mule, encode_invocation_designation)
5095 (encode_designation_at_bol, encode_coding_iso_2022)
5096 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5097 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5098 Declare EMACS_INT.
5099 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5100 (encode_invocation_designation): Last argument P_NCHARS is now
5101 EMACS_INT.
5102 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5103 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5104
5105 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5106 All users changed.
5107
5108 * ccl.c (Fccl_execute_on_string): Declare some variables
5109 EMACS_INT.
5110
8546720e 51112011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5112
5113 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5114
4e19a977
CS
51152011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5116
5117 * process.c (Fformat_network_address): Doc fix.
5118
87302331
R
51192011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5120
5121 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5122
cbb59342
CY
51232011-04-08 Chong Yidong <cyd@stupidchicken.com>
5124
5125 * keyboard.c (read_char): Call Lisp function help-form-show,
5126 instead of using internal_with_output_to_temp_buffer.
5127 (Qhelp_form_show): New var.
e0d38eeb 5128 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5129
5130 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5131
5132 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5133
e67a13ab
CY
51342011-04-06 Chong Yidong <cyd@stupidchicken.com>
5135
04f2d78b
CB
5136 * process.c (Flist_processes): Remove to Lisp.
5137 (list_processes_1): Delete.
e67a13ab 5138
973f782d
EZ
51392011-04-06 Eli Zaretskii <eliz@gnu.org>
5140
7c106b1e
EZ
5141 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5142
973f782d
EZ
5143 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5144
41cf7d1a 51452011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5146
ca23cc88
PE
5147 Fix more problems found by GCC 4.6.0's static checks.
5148
f390e2d5
PE
5149 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5150
42eea0d0
PE
5151 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5152
b69769da 5153 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5154
f9541e84
PE
5155 * xdisp.c (vmessage): Mark as a printf-like function.
5156
13841b55
PE
5157 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5158
c136c10f
PE
5159 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5160
5e2d4a30
PE
5161 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5162 printf-like functions.
5163 (tiff_load): Add casts to remove these marks before passing them
5164 to system-supplied API.
5165
583f48b9
PE
5166 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5167
b25d760e
PE
5168 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5169 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5170 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5171 directly, rather than having caller test rule sign. This avoids
5172 some unnecessary tests.
5173 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5174 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5175 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5176
bc7b6697 5177 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5178 (xfont_open): Avoid unnecessary tests.
bc7b6697 5179
27ccc379
PE
5180 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5181
dcd5c89a
PE
5182 * composite.h, composite.c (composition_gstring_put_cache):
5183 Use EMACS_INT, not int, for length.
5184
b13a45c6
PE
5185 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5186 breaking out part of COMPOSITION_DECODE_RULE.
5187 (COMPOSITION_DECODE_RULE): Use it.
5188 * composite.c (get_composition_id): Remove unused local vars,
5189 by using the new macro.
5190
1e792e4d
PE
5191 * textprop.c (set_text_properties_1): Change while to do-while,
5192 since the condition is always true at first.
5193
dc6c6455 5194 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5195 (interval_deletion_adjustment): Return unsigned value.
5196 All uses changed.
dc6c6455 5197
aba7731a
PE
5198 * process.c (list_processes_1, create_pty, read_process_output):
5199 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5200 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5201 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5202 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5203 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5204
fdfc4bf3
PE
5205 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5206
fca8fe46 5207 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5208 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5209
06a0259a 5210 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5211 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5212 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5213
e7b9e80f
PE
5214 * print.c (print_error_message): Avoid int overflow.
5215
56201685
PE
5216 * font.c (font_list_entities): Redo for clarity,
5217 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5218
78834453 5219 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5220 (font_score): Avoid potential overflow in diff calculation.
78834453 5221
0bc0b309 5222 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5223 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5224
e610eaca
PE
5225 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5226
b895abce
PE
5227 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5228 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5229 can always succeed if overflow has undefined behavior.
5230
1f1d9321 5231 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5232 (wordify): Omit three unnecessary tests.
1f1d9321 5233
c59478bc
PE
5234 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5235 All callers changed. This avoids the need for an unused var.
5236
79b73827
PE
5237 * casefiddle.c (casify_region): Remove var that is set but not used.
5238
a4db5dfe
PE
5239 * dired.c (file_name_completion): Remove var that is set but not used.
5240
43aae36e
PE
5241 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5242
2a47c44d 5243 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5244 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5245
a37c69bf
PE
5246 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5247 Check for integer overflow on size calculations.
5248
328ab8e7
PE
5249 * buffer.c (Fprevious_overlay_change): Remove var that is set
5250 but not used.
5251
e5a2a5cb
PE
5252 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5253 Remove vars that are set but not used.
8d84a6eb 5254 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5255 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5256
a60e5f68
PE
5257 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5258
f661cb61 5259 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5260 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5261
f0397f5a
PE
5262 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5263 that are set but not used.
5264
8664db06 5265 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5266 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5267
6abdaa4a
PE
5268 * xselect.c (x_get_local_selection, x_handle_property_notify):
5269 Remove vars that are set but not used.
5270
0ce7538d 5271 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5272 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5273
9ae848fc
PE
5274 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5275 Remove var that is set but not used.
0b918413
PE
5276 (scroll_bar_windows_size): Now size_t, not int.
5277 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5278 Check for overflow.
9ae848fc 5279
a5a62657
PE
5280 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5281 (map_tty_color) [!defined MSDOS]: Likewise.
5282
5c5cdd39
PE
5283 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5284
66ebf983
PE
5285 * coding.c: Remove vars that are set but not used.
5286 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5287 All callers changed.
5288 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5289 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5290 (decode_coding_charset): Remove vars that are set but not used.
5291
1be4d761
PE
5292 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5293 that is set but not used.
5294
47553fa8
PE
5295 * print.c (print_object): Remove var that is set but not used.
5296
1f7196bf 5297 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5298 The gnulib version avoids calling malloc in the usual case,
5299 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5300 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5301 * filelock.c (current_lock_owner): Likewise.
5302 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5303 * sysdep.c: Include allocator.h, careadlinkat.h.
5304 (emacs_no_realloc_allocator): New static constant.
5305 (emacs_readlink): New function.
fdb61804
PE
5306 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5307 ../lib/careadlinkat.h.
d1fdcab7 5308
f84c17c7
SM
53092011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5310
5311 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5312 first non-nil return value).
5313
ef3862ad
JD
53142011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5315
5316 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5317 if not defined (Bug#8403).
5318
376a7006
JB
53192011-04-02 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * xdisp.c (display_count_lines): Remove parameter `start',
5322 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5323 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5324 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5325 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5326 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5327 and thereabouts. All callers changed.
5328 (get_per_char_metric): Remove parameter `f', unused since
5329 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5330
6ca3801d
JM
53312011-04-02 Jim Meyering <meyering@redhat.com>
5332
5333 do not dereference NULL upon failed strdup
5334 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5335 (ns_get_family): Likewise.
5336
d8e2b5ba
JB
53372011-04-02 Juanma Barranquero <lekktu@gmail.com>
5338
5339 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5340
8c74fcbd
JD
53412011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5342
5343 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5344 later (Bug#8403).
5345
7200d79c
SM
53462011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5347
03408648 5348 Add lexical binding.
7200d79c 5349
03408648
SM
5350 * window.c (Ftemp_output_buffer_show): New fun.
5351 (Fsave_window_excursion):
5352 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5353
5354 * lread.c (lisp_file_lexically_bound_p): New function.
5355 (Fload): Bind Qlexical_binding.
5356 (readevalloop): Remove `evalfun' arg.
5357 Bind Qinternal_interpreter_environment.
5358 (Feval_buffer): Bind Qlexical_binding.
5359 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5360 Mark as dynamic.
5361 (syms_of_lread): Declare `lexical-binding'.
5362
5363 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5364
5365 * keyboard.c (eval_dyn): New fun.
5366 (menu_item_eval_property): Use it.
ca105506
SM
5367
5368 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5369
03408648
SM
5370 * fns.c (concat, mapcar1): Accept byte-code-functions.
5371
5372 * eval.c (Fsetq): Handle lexical vars.
5373 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5374 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5375 (FletX, Flet): Obey lexical binding.
5376 (Fcommandp): Handle closures.
5377 (Feval): New `lexical' arg.
5378 (eval_sub): New function extracted from Feval. Use it almost
5379 everywhere where Feval was used. Look up vars in lexical env.
5380 Handle closures.
5381 (Ffunctionp): Move from subr.el.
5382 (Ffuncall): Handle closures.
5383 (apply_lambda): Remove `eval_flags'.
5384 (funcall_lambda): Handle closures and new byte-code-functions.
5385 (Fspecial_variable_p): New function.
5386 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5387 but without exporting it to Lisp.
23aba0ea 5388
23aba0ea 5389 * doc.c (Fdocumentation, store_function_docstring):
03408648 5390 * data.c (Finteractive_form): Handle closures.
23aba0ea 5391
03408648
SM
5392 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5393 interactive spec.
ba83908c 5394
04f2d78b
CB
5395 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5396 New byte-codes.
03408648
SM
5397 (exec_byte_code): New function extracted from Fbyte_code to handle new
5398 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5399
03408648 5400 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5401
03408648 5402 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5403
e2abce01
JB
54042011-03-31 Juanma Barranquero <lekktu@gmail.com>
5405
5406 * xdisp.c (redisplay_internal): Fix prototype.
5407
63696a73 54082011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5409
63696a73 5410 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5411 (try_scrolling): Use it when setting scroll_limit.
5412 Limit scrolling to 100 screen lines.
63696a73
EZ
5413 (redisplay_window): Even when falling back on "recentering",
5414 position point in the window according to scroll-conservatively,
5415 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5416
5417 (try_scrolling): When point is above the window, allow searching
5418 as far as scroll_max, or one screenful, to compute vertical
5419 distance from PT to the scroll margin position. This prevents
5420 try_scrolling from unnecessarily failing when
5421 scroll-conservatively is set to a value slightly larger than the
5422 window height. Clean up the case of PT below the margin at bottom
5423 of window: scroll_max can no longer be INT_MAX. When aggressive
5424 scrolling is in use, don't let point enter the opposite scroll
5425 margin as result of the scroll.
5426 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5427 threshold of 100 lines for never-recentering scrolling.
5428
e4cc2dfc
JB
54292011-03-31 Juanma Barranquero <lekktu@gmail.com>
5430
5431 * dispextern.h (move_it_by_lines):
5432 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5433 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5434 (message_log_check_duplicate): Remove parameters `prev_bol' and
5435 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5436 (redisplay_internal): Remove parameter `preserve_echo_area',
5437 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5438
5439 * indent.c (Fvertical_motion):
5440 * window.c (window_scroll_pixel_based, Frecenter):
5441 Don't pass `need_y_p' to `move_it_by_lines'.
5442
1c470562
SM
54432011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5444
44f230aa
SM
5445 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5446 steal a few bits to be more compact.
5447 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5448 Remove unneeded casts.
5449
1c470562
SM
5450 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5451
888adce9
ZK
54522011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5453
5454 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5455 binding" message (bug#7967).
5456
f838ed7b
PE
54572011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5458
77861b95
PE
5459 Fix more problems found by GCC 4.6.0's static checks.
5460
de6dbc14
PE
5461 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5462 Remove unused local var.
5463
f838ed7b
PE
5464 * editfns.c (Fmessage_box): Remove unused local var.
5465
792c7b2b
PE
5466 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5467 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5468 Omit unused local vars.
c499e557 5469 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5470 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5471 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5472 Omit unused local var.
5473
ba0165e1
PE
5474 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5475 Don't assume string length fits in int.
32ad8845 5476 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5477 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5478
3c59b4c9
PE
5479 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5480 instead of alloca (Bug#8344).
5481
a3eed478 5482 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5483 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5484
eb4d412d
PE
5485 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5486
1658b401
PE
5487 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5488 concerns.
5489
5490 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5491
5492 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5493
9a2c6e05
PE
5494 * keyboard.c (syms_of_keyboard): Use the same style as later
5495 in this function when indexing through an array. This also
5496 works around GCC bug 48267.
5497
03d0a109
PE
5498 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5499
44f730c8
PE
5500 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5501
fe75f926
PE
5502 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5503 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5504
ffa8c828
PE
5505 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5506 This avoids undefined behavior on integer overflow, and is a bit
5507 more convenient anyway since it is compared to a size_t variable.
5508
c5101a77
PE
5509 Variadic C functions now count arguments with size_t, not int.
5510 This avoids an unnecessary limitation on 64-bit machines, which
5511 caused (substring ...) to crash on large vectors (Bug#8344).
5512 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5513 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5514 All variadic functions and their callers changed accordingly.
c5101a77
PE
5515 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5516 * data.c (arith_driver, float_arith_driver): Likewise.
5517 * editfns.c (general_insert_function): Likewise.
5518 * eval.c (struct backtrace.nargs, interactive_p)
5519 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5520 (funcall_lambda, mark_backtrace): Likewise.
5521 * fns.c (concat): Likewise.
5522 * frame.c (x_set_frame_parameters): Likewise.
5523 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5524 0 if not found, not -1. All callers changed.
5525
dd3f25f7
PE
5526 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5527 (stack_copy_size): Now size_t, not int.
5528 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5529
461c2ab9
JB
55302011-03-28 Juanma Barranquero <lekktu@gmail.com>
5531
5532 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5533 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5534 All callers changed.
5535
5536 * lisp.h (multibyte_char_to_unibyte):
5537 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5538 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5539 * character.h (CHAR_TO_BYTE8):
5540 * cmds.c (internal_self_insert):
5541 * editfns.c (general_insert_function):
5542 * keymap.c (push_key_description):
5543 * search.c (Freplace_match):
5544 * xdisp.c (message_dolog, set_message_1): All callers changed.
5545
f6d62986
SM
55462011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5547
5548 * keyboard.c (safe_run_hook_funcall): New function.
5549 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5550 don't set the hook to nil, but remove the offending function instead.
5551 (Qcommand_hook_internal): Remove, unused.
5552 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5553 Vcommand_hook_internal.
5554
5555 * eval.c (enum run_hooks_condition): Remove.
5556 (funcall_nil, funcall_not): New functions.
5557 (run_hook_with_args): Call each function through a `funcall' argument.
5558 Remove `cond' argument, now redundant.
5559 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5560 (Frun_hook_with_args_until_failure): Adjust accordingly.
5561 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5562
1db5b1ad
JB
55632011-03-28 Juanma Barranquero <lekktu@gmail.com>
5564
5565 * dispextern.h (string_buffer_position): Remove declaration.
5566
5567 * print.c (strout): Remove parameter `multibyte', unused since
5568 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5569
5570 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5571 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5572 All callers changed.
5573
5574 * w32.c (_wsa_errlist): Use braces for struct initializers.
5575
5576 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5577 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5578 All callers changed.
5579 (string_buffer_position): Likewise. Also, make static (it's never
5580 used outside xdisp.c).
5581 (cursor_row_p): Remove parameter `w', unused since
5582 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5583 (decode_mode_spec): Remove parameter `precision', introduced during
5584 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5585 All callers changed.
5586
5ffb62aa
JD
55872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5588
5589 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5590
461c2ab9 55912011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5592
5593 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5594 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5595 (ns_update_auto_hide_menu_bar): New functions.
5596 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5597 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5598 ns_constrain_all_frames.
5599 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5600 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5601
5c380ffb
JD
56022011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5603
5604 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5605
9af30bdf
GM
56062011-03-27 Glenn Morris <rgm@gnu.org>
5607
5608 * syssignal.h: Replace RETSIGTYPE with void.
5609 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5610 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5611 Replace SIGTYPE with void everywhere.
5612 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5613 * s/template.h (SIGTYPE): Remove commented out definition.
5614
e2abce01
JB
56152011-03-26 Eli Zaretskii <eliz@gnu.org>
5616
5617 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5618 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5619
f868cd8a
JB
56202011-03-26 Juanma Barranquero <lekktu@gmail.com>
5621
59eb0929
JB
5622 * w32.c (read_unc_volume): Use parameter `henum', instead of
5623 global variable `wget_enum_handle'.
5624
5625 * keymap.c (describe_vector): Remove parameters `indices' and
5626 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5627 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5628
f868cd8a
JB
5629 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5630
5631 * keyboard.c (timer_check): Remove parameter `do_it_now',
5632 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5633 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5634 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5635
5636 * keyboard.c (read_char):
5637 * w32menu.c (w32_menu_display_help):
5638 * xmenu.c (show_help_event, menu_help_callback):
5639 Adjust calls to `show_help_echo'.
5640
5641 * gtkutil.c (xg_maybe_add_timer):
5642 * keyboard.c (readable_events):
5643 * process.c (wait_reading_process_output):
5644 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5645
5646 * insdel.c (adjust_markers_gap_motion):
5647 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5648 (gap_left, gap_right): Don't call it.
5649
2ecf6fdb
CY
56502011-03-25 Chong Yidong <cyd@stupidchicken.com>
5651
5652 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5653 incurred during fontification.
5654
6b1f9ba4
JB
56552011-03-25 Juanma Barranquero <lekktu@gmail.com>
5656
5657 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5658 (DEFVAR_PER_BUFFER): Don't pass it.
5659
5660 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5661 (scrolling_window): Don't pass it.
5662
0f4a96b5
JB
56632011-03-25 Juanma Barranquero <lekktu@gmail.com>
5664
5665 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5666
5667 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5668 and `suffix'.
5669 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5670 of variables specific to SELinux and computation of `encoded_absname'.
5671
5672 * image.c (XPutPixel): Remove unused variable `height'.
5673
5674 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5675
5676 * unexw32.c (get_section_info): Remove unused variable `section'.
5677
5678 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5679 (system_process_attributes): Remove unused variable `sess'.
5680 (sys_read): Remove unused variable `err'.
5681
5682 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5683 (w32_wnd_proc): Remove unused variable `isdead'.
5684 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5685 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5686 (x_create_tip_frame): Remove unused variable `tem'.
5687
5688 * w32inevt.c (w32_console_read_socket):
5689 Remove unused variable `no_events'.
5690
5691 * w32term.c (x_draw_composite_glyph_string_foreground):
5692 Remove unused variable `width'.
5693
1149507c
JB
56942011-03-24 Juanma Barranquero <lekktu@gmail.com>
5695
5696 * w32term.c (x_set_glyph_string_clipping):
5697 Don't pass uninitialized region to CombineRgn.
5698
9c88f339
JB
56992011-03-23 Juanma Barranquero <lekktu@gmail.com>
5700
5701 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5702 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5703 (Fx_close_connection): Remove unused variable `i'.
5704
5705 * w32font.c (w32font_draw): Return number of glyphs.
5706 (w32font_open_internal): Remove unused variable `i'.
5707 (w32font_driver): Add missing initializer.
5708
5709 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5710 (fill_in_menu): Remove unused variable `items_added'.
5711
5712 * w32term.c (last_mouse_press_frame): Remove static global variable.
5713 (w32_clip_to_row): Remove unused variable `f'.
5714 (x_delete_terminal): Remove unused variable `i'.
5715
5716 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5717 (NOTHING): Remove unused static global variable.
5718 (uniscribe_check_otf): Remove unused variable `table'.
5719 (uniscribe_font_driver): Add missing initializers.
5720
dee091a3
JD
57212011-03-23 Julien Danjou <julien@danjou.info>
5722
5723 * term.c (Fsuspend_tty, Fresume_tty):
5724 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5725 * window.c (temp_output_buffer_show):
5726 * insdel.c (signal_before_change):
5727 * frame.c (Fhandle_switch_frame):
5728 * fileio.c (Fdo_auto_save):
5729 * emacs.c (Fkill_emacs):
5730 * editfns.c (save_excursion_restore):
5731 * cmds.c (internal_self_insert):
5732 * callint.c (Fcall_interactively):
5733 * buffer.c (Fkill_all_local_variables):
5734 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5735 Use Frun_hooks.
0f4a96b5 5736 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5737 unconditionnaly since it does the check itself.
5738
2c520ab5 57392011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5740
c9c49752
PE
5741 Fix more problems found by GCC 4.5.2's static checks.
5742
8abc3f12
PE
5743 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5744 the first time through the loop, since we know p0 < p1 then.
5745 This also avoids a gcc -Wstrict-overflow warning.
5746
a2d26660
PE
5747 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5748 leading to a memory leak, possible in functions like
5749 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5750 of objects (Bug#8318).
a2d26660 5751
916c72e9
PE
5752 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5753 that could (at least in theory) be that large.
5754
19ab8a18
PE
5755 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5756 This is less likely to overflow, and avoids undefined behavior if
5757 overflow does occur. All callers changed. Use strtoul to scan
5758 for the unsigned long integer.
b7cbbd6f
PE
5759 (pint2hrstr): Simplify and tune code slightly.
5760 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5761
f0641eff
PE
5762 * scroll.c (do_scrolling): Work around GCC bug 48228.
5763 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5764
7f650bb9
PE
5765 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5766 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5767 (validate_x_resource_name): Simplify count usage.
5768 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5769
37dd57d1
PE
5770 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5771 fail (Bug#8306).
81e56e61 5772
699979fc 5773 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5774
401bf9b4
PE
5775 * process.c (Fmake_network_process): Use socklen_t, not int,
5776 where POSIX says socklen_t is required in portable programs.
5777 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5778 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5779 (Fmake_network_process, server_accept_connection):
5780 (wait_reading_process_output, read_process_output):
5781 Likewise.
5782
b93aacde
PE
5783 * process.c: Rename or move locals to avoid shadowing.
5784 (list_processes_1, Fmake_network_process):
5785 (read_process_output_error_handler, exec_sentinel_error_handler):
5786 Rename or move locals.
4dc343ee 5787 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5788 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5789 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5790 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5791 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5792
af8a867c 5793 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5794 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5795 Include tparam.h instead, since it declares them.
af8a867c
PE
5796 * cm.h (PC): Remove extern decl; tparam.h now does this.
5797 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5798 * terminfo.c: Include tparam.h, to check interfaces.
5799 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5800 (tparam): Adjust signature to match interface in tparam.h;
5801 this removes some undefined behavior. Check that outstring and len
5802 are zero, which they always are with Emacs.
5803 * tparam.h (PC, BC, UP): New extern decls.
5804
0248044d 5805 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5806 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5807
8ff096c1 5808 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5809 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5810 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5811 (ftfont_list): Remove unused local.
49eaafba
PE
5812 (get_adstyle_property, ftfont_pattern_entity):
5813 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5814 Rename locals to avoid shadowing.
8ff096c1 5815
e2be39f6
PE
5816 * xfont.c (xfont_list_family): Mark var as initialized.
5817
c9735e30
PE
5818 * xml.c (make_dom): Now static.
5819
8f5201ae
PE
5820 * composite.c (composition_compute_stop_pos): Rename local to
5821 avoid shadowing.
b246f932
PE
5822 (composition_reseat_it): Remove unused locals.
5823 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5824 (composition_update_it): Mark var as initialized.
11b61122
PE
5825 (find_automatic_composition): Mark vars as initialized,
5826 with a FIXME (Bug#8290).
8f5201ae 5827
760fbc2c
PE
5828 character.h: Rename locals to avoid shadowing.
5829 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5830 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5831 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5832 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5833 to avoid shadowing.
5834
ff08eb85
PE
5835 * textprop.c (property_change_between_p): Remove; unused.
5836
fc7bf025
PE
5837 * intervals.c (interval_start_pos): Now static.
5838
235d7abc
PE
5839 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5840
44f230aa
SM
5841 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5842 Rename locals to avoid shadowing.
3e7d6594 5843
50060332
PE
5844 * sound.c (wav_play, au_play, Fplay_sound_internal):
5845 Fix pointer signedness.
d01f234b 5846 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5847 (wav_play): Initialize a variable to 0, to prevent undefined
5848 behavior (Bug#8278).
50060332 5849
c4fc4e30
PE
5850 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5851
918436ed
PE
5852 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5853
c939f91b
PE
5854 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5855 clobbering (Bug#8298).
b9c7f648
PE
5856 * sysdep.c (sys_subshell): Likewise.
5857 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5858
6bd8c144
PE
5859 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5860 This should get cleaned up, so that child_setup has the
5861 same signature on all platforms.
5862
7710357c 5863 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5864 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5865
c59da222
CY
58662011-03-22 Chong Yidong <cyd@stupidchicken.com>
5867
5868 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5869 not to be necessary, and produces flickering.
5870
66b87493
GM
58712011-03-20 Glenn Morris <rgm@gnu.org>
5872
5873 * config.in: Remove file.
5874
45b6f6d5
JB
58752011-03-20 Juanma Barranquero <lekktu@gmail.com>
5876
5877 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5878 are now in src/globals.h.
5879 (syms_of_minibuf): Remove spurious & from previous change.
5880
3ec03f7e
LL
58812011-03-20 Leo <sdl.web@gmail.com>
5882
5883 * minibuf.c (completing-read-function): New variable.
5884 (completing-read-default): Rename from completing-read.
5885 (completing-read): Call completing-read-function.
5886
b14e3e21
CY
58872011-03-19 Juanma Barranquero <lekktu@gmail.com>
5888
5889 * xfaces.c (Fx_load_color_file):
5890 Read color file from absolute filename (bug#8250).
5891
f2b726e6
JB
58922011-03-19 Juanma Barranquero <lekktu@gmail.com>
5893
5894 * makefile.w32-in: Update dependencies.
5895
09f6ff02
EZ
58962011-03-17 Eli Zaretskii <eliz@gnu.org>
5897
5898 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5899
29a6015a
PE
59002011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5901
a3a6c54e
PE
5902 Fix more problems found by GCC 4.5.2's static checks.
5903
b766f867
PE
5904 * process.c (make_serial_process_unwind, send_process_trap):
5905 (sigchld_handler): Now static.
5906
be02381c
PE
5907 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5908 That way, the code declares only the vars that it needs.
5909 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5910 * s/cygwin.h (PTY_ITERATION): Likewise.
5911 * s/darwin.h (PTY_ITERATION): Likewise.
5912 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5913
57048744
PE
5914 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5915 * process.c (allocate_pty): Don't declare stb unless it's needed.
5916
7914961c 5917 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5918 (CONSTANTLIM): Remove; unused.
5919 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5920 Define only if needed.
7914961c 5921
b3967b18
PE
5922 * unexelf.c (unexec): Name an expression,
5923 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5924 Use a different way to cause a compilation error if anyone uses
5925 n rather than nn, a way that does not involve shadowing.
73366a00 5926 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5927
29a6015a
PE
5928 * deps.mk (unexalpha.o): Remove; unused.
5929
43cfc33e 5930 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5931 * unexec.h: New file.
ce701a33
PE
5932 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5933 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5934 Depend on unexec.h.
5935 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5936 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5937 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5938 Change as necessary to match prototype in unexec.h.
ce701a33 5939
01f44d5a
PE
5940 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5941 shadowing.
4f63c6bb 5942 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5943
a6670b0b
PE
5944 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5945 Rename locals to avoid shadowing.
5946
cef2010d 5947 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5948 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5949
d4d7173a
PE
5950 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5951
f08b802a
PE
5952 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5953 warning when compiling print.c.
5954
3ddb0639
PE
5955 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5956 instead of using an uninitialized var.
5ad03b97 5957 (font_sort_entities): Mark var as initialized.
3ddb0639 5958
170a2692
PE
5959 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5960
e663c700
PE
5961 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5962 pointers to constants.
89bc529a 5963 (font_parse_fcname): Remove unused vars.
7b81e2d0 5964 (font_delete_unmatched): Now static.
ea838e10 5965 (font_get_spec): Remove; unused.
13a547c6
PE
5966 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5967 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5968 Rename or move locals to avoid shadowing.
e663c700 5969
2a80c887 5970 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5971 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5972
1384fa33 5973 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5974 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5975
8b2c52e9
PE
5976 * alloc.c (mark_backtrace): Move decl from here ...
5977 * lisp.h: ... to here, so that it can be checked.
5978
475545b5 5979 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5980 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5981 (lisp_indirect_variable): Name an expression,
5982 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5983 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5984
b1349114 5985 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5986 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5987 Use const pointer when appropriate.
b1349114 5988
a2928364
PE
5989 * lisp.h (get_system_name, get_operating_system_release):
5990 Move decls here, to check interfaces.
5991 * process.c (get_operating_system_release): Move decl to lisp.h.
5992 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5993 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5994 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5995 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5996 (Fformat_time_string, Fencode_time, Finsert_char):
5997 (Ftranslate_region_internal, Fformat):
5998 Rename or remove local vars to avoid shadowing.
9710023e 5999 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6000
a415e694
PE
6001 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6002 avoid shadowing.
6003
8ef4622d
PE
6004 * lisp.h (eassert): Check that the argument compiles, even if
6005 ENABLE_CHECKING is not defined.
6006
946f9a5b
PE
6007 * data.c (Findirect_variable): Name an expression, to avoid
6008 gcc -Wbad-function-cast warning.
112396d6 6009 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6010 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6011 (Fmake_variable_buffer_local, Fmake_local_variable):
6012 Mark variables as initialized.
52746918 6013 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6014
e5aab7e7 6015 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6016 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6017 Rename locals to avoid shadowing.
dff45157
PE
6018 (mark_stack): Move local variables into the #ifdef region where
6019 they're used.
7bc26fdb
PE
6020 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6021 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6022 needed otherwise.
6023 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6024 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6025 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6026
e5aab7e7
PE
6027 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6028 avoids undefined behavior in theory.
6029
4da60324
PE
6030 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6031
88043301
PE
6032 Use functions, not macros, for up- and down-casing (Bug#8254).
6033 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6034 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6035 to use the following functions instead of these macros.
6036 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6037 EMACS_INT, since callers assume the returned value fits in int.
6038 (upcase1): Likewise, for UPCASE_TABLE.
6039 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6040 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6041 the race-condition problem in the old DOWNCASE.
88043301 6042
19ed5445
PE
6043 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6044 Rename locals to avoid shadowing.
6045 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6046 (regex_compile, re_search_2, re_match_2_internal):
6047 Remove unused local vars.
952db0d7
PE
6048 (FREE_VAR): Rewrite so as not to use empty "else",
6049 which gcc can warn about.
da053e48 6050 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6051 (RETALLOC_IF): Define only if needed.
6052 (WORDCHAR_P): Likewise. This one is never needed, but is used
6053 only in a comment talking about a compiler bug, so put inside
6054 the #if 0 of that comment.
6055 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6056 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6057 Remove; unused.
19ed5445 6058
1f3561e4 6059 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6060 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6061 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6062
ded6f8f7
PE
6063 * search.c (simple_search): Remove unused var.
6064
dbd37a95
PE
6065 * dired.c (compile_pattern): Move decl from here ...
6066 * lisp.h: ... to here, so that it can be checked.
6067 (struct re_registers): New forward decl.
6068
7e47afad
PE
6069 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6070
85f24f61
PE
6071 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6072 All uses changed.
6073 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6074 Rename locals to avoid shadowing.
5671df8f 6075 (Fvertical_motion): Mark locals as initialized.
85f24f61 6076
181aa2be 6077 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6078 (casify_region): Mark local as initialized.
181aa2be 6079
930d429c
PE
6080 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6081
7082eac6
PE
6082 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6083 New macros, so that the caller can use some names other than
6084 gcpro1, gcpro2, etc.
6085 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6086 of the new macros.
6087 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6088 argument, for consistency with GCPRO2_VAR, etc: it is now the
6089 prefix of the variable, not the variable itself. All uses
6090 changed.
38b2c076
PE
6091 * dired.c (directory_files_internal, file_name_completion):
6092 Rename locals to avoid shadowing.
6093
15206ed9
PE
6094 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6095 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6096 dired.c's scmp function, had undefined behavior.
6097 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6098 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6099 * buffer.h: ... to here, because these macros use current_buffer,
6100 and the new implementation with inline functions needs to have
6101 current_buffer in scope now, rather than later when the macros
6102 are used.
6103 (downcase, upcase1): New static inline functions.
6104 (DOWNCASE, UPCASE1): Reimplement using these functions.
6105 This avoids undefined behavior in expressions like
6106 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6107 from race conditions in accessing the global variables
6108 case_temp1 and case_temp2.
6109 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6110 * lisp.h (case_temp1, case_temp2): Remove their decls.
6111 * character.h (ASCII_CHAR_P): Move from here ...
6112 * lisp.h: ... to here, so that the inline functions mentioned
6113 above can use them.
6114
4a6bea26
PE
6115 * dired.c (directory_files_internal_unwind): Now static.
6116
f14b7e14
PE
6117 * fileio.c (file_name_as_directory, directory_file_name):
6118 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6119 Now static.
2893f146
PE
6120 (file_name_as_directory): Use const pointers when appropriate.
6121 (Fexpand_file_name): Likewise. In particular, newdir might
6122 point at constant storage, so make it a const pointer.
fd4ead52 6123 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6124 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6125 signedness issues.
f839df0c
PE
6126 (Fset_file_times, Finsert_file_contents, auto_save_error):
6127 Rename locals to avoid shadowing.
f14b7e14 6128
5716756e 6129 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6130 (Ftry_completion, Fall_completions): Rename or remove locals
6131 to avoid shadowing.
5716756e 6132
b4c3046a
PE
6133 * marker.c (bytepos_to_charpos): Remove; unused.
6134
b45db522
PE
6135 * lisp.h (verify_bytepos, count_markers): New decls,
6136 so that gcc does not warn that these functions aren't declared.
6137
85876d07
PE
6138 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6139 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6140 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6141 (copy_text): Remove unused local var.
85876d07 6142
03d78a21 6143 * filelock.c (within_one_second): Now static.
b3dd38ab 6144 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6145
5df8f01b
PE
6146 * buffer.c (fix_overlays_before): Mark locals as initialized.
6147 (fix_start_end_in_overlays): Likewise. This function should be
6148 simplified by using pointers-to-pointers, but that's a different
6149 matter.
b1d876f1 6150 (switch_to_buffer_1): Now static.
8f54f30a
PE
6151 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6152 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6153
a70072c9 6154 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6155 Fix pointer signedness issue.
edced198
PE
6156 (sys_subshell): Mark local as volatile if checking for lint,
6157 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6158 (MAXPATHLEN): Define only if needed.
a70072c9 6159
a0977c44
PE
6160 * process.c (serial_open, serial_configure): Move decls from here ...
6161 * systty.h: ... to here, so that they can be checked.
6162
a884fdcc
PE
6163 * fns.c (get_random, seed_random): Move extern decls from here ...
6164 * lisp.h: ... to here, so that they can be checked.
6165
604efe86 6166 * sysdep.c (reset_io): Now static.
b8950c94 6167 (wait_for_termination_signal): Remove; unused.
604efe86 6168
38fc62d9
PE
6169 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6170 (copy_keymap_item, append_key, push_text_char_description):
6171 Now static.
1004a21a 6172 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6173 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6174 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6175 (describe_map_tree):
6176 Rename locals to avoid shadowing.
38fc62d9 6177
2f2650da
PE
6178 * keyboard.c: Declare functions static if they are not used elsewhere.
6179 (echo_char, echo_dash, cmd_error, top_level_2):
6180 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6181 (read_char, kbd_buffer_get_event, make_lispy_position):
6182 (make_lispy_event, make_lispy_movement, apply_modifiers):
6183 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6184 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6185 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6186 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6187 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6188
a053e86c 6189 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6190 (mark_kboards): Move decl here ...
6191 * alloc.c (mark_kboards): ... from here.
a053e86c 6192
4752793e
PE
6193 * lisp.h (force_auto_save_soon): New decl.
6194
74f10ca7 6195 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6196 (DEFINE_DUMMY_FUNCTION): New macro.
6197 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6198 Use it.
c03cd23f
PE
6199 (main): Add casts to avoid warnings
6200 if GCC considers string literals to be constants.
74f10ca7 6201
022e70d4
PE
6202 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6203
59d6fe83
PE
6204 * dbusbind.c: Pointer signedness fixes.
6205 (xd_signature, xd_append_arg, xd_initialize):
6206 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6207 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6208 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6209 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6210
78320123
PE
6211 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6212 if GCC considers string literals to be constants.
49cebcca 6213 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6214
35ac2a97
SM
62152011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6216
fb103ca9
SM
6217 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6218 (print_preprocess, print_object): New macro to fix last change.
6219
35ac2a97
SM
6220 * print.c (print_preprocess): Don't forget font objects.
6221
62973b41
JB
62222011-03-16 Juanma Barranquero <lekktu@gmail.com>
6223
6224 * emacs.c (USAGE3): Doc fixes.
6225
0e48bb22
AS
62262011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6227
6228 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6229 structure.
6230
7684e57b
JB
62312011-03-14 Juanma Barranquero <lekktu@gmail.com>
6232
6233 * lisp.h (VWindow_system, Qfile_name_history):
6234 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6235 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6236 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6237
6238 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6239 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6240
6241 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6242 * w32console.c (detect_input_pending, read_input_pending)
6243 (encode_terminal_code):
6244 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6245 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6246 (w32_system_caret_y, Qfile_name_history):
6247 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6248 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6249 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6250 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6251 * w32proc.c (Qlocal, report_file_error):
6252 * w32term.c (Vwindow_system, updating_frame):
6253 * w32uniscribe.c (initialized, uniscribe_font_driver):
6254 Remove unneeded extern declarations.
6255
2aa46d6c
CY
62562011-03-14 Chong Yidong <cyd@stupidchicken.com>
6257
c96bbc66 6258 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6259
cffc6f3b
CY
62602011-03-13 Chong Yidong <cyd@stupidchicken.com>
6261
6262 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6263 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6264 These macros can no longer be used for assignment.
6265
44f230aa
SM
6266 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6267 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6268 (record_buffer_markers, fetch_buffer_markers): New functions for
6269 recording and fetching special buffer markers.
6270 (set_buffer_internal_1, set_buffer_temp): Use them.
6271
6272 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6273
6274 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6275
6276 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6277 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6278
6279 * xdisp.c (hscroll_window_tree):
6280 (reconsider_clip_changes): Use PT instead of BUF_PT.
6281
d251f04b
EZ
62822011-03-13 Eli Zaretskii <eliz@gnu.org>
6283
6284 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6285 $(EMACS_ROOT)/lib/intprops.h.
6286
f0c77cd1
PE
62872011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6288
3eca4629
PE
6289 Fix more problems found by GCC 4.5.2's static checks.
6290
7c86ee98
PE
6291 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6292 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6293 (xg_free_frame_widgets): Make it clear that a local variable is
6294 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6295 (gdk_window_get_screen): Make it clear that this macro is needed
6296 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6297 (int_gtk_range_get_value): New function, which avoids a diagnostic
6298 from gcc -Wbad-function-cast.
6299 (xg_set_toolkit_scroll_bar_thumb): Use it.
6300 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6301 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6302 (get_utf8_string, xg_get_file_with_chooser):
6303 Rename locals to avoid shadowing.
6304 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6305
41729b81
PE
6306 * xgselect.c (xg_select): Remove unused var.
6307
f0c77cd1
PE
6308 * image.c (four_corners_best): Mark locals as initialized.
6309 (gif_load): Initialize transparent_p to zero (Bug#8238).
6310 Mark another local as initialized.
ec6cf4c6 6311 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6312
ce0ad53d 6313 * image.c (clear_image_cache): Now static.
d5d5a617 6314 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6315 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6316 (x_edge_detection): Remove unnecessary cast that
6317 gcc -Wbad-function-cast diagnoses.
2037898d 6318 (gif_load): Fix pointer signedness.
6ae141d6
PE
6319 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6320 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6321
33383987 63222011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6323
d32df629
PE
6324 Improve quality of tests for time stamp overflow.
6325 For example, without this patch (encode-time 0 0 0 1 1
6326 1152921504606846976) returns the obviously-bogus value (-948597
6327 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6328 reports time overflow. See
6329 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6330 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6331 * editfns.c: Include limits.h and intprops.h.
6332 (TIME_T_MIN, TIME_T_MAX): New macros.
6333 (time_overflow): Move earlier, to before first use.
6334 (hi_time, lo_time): New functions, for an accurate test for
6335 out-of-range times.
6336 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6337 (Fget_internal_run_time): Don't assume time_t fits in int.
6338 (make_time): Use list2 instead of Fcons twice.
6339 (Fdecode_time): More accurate test for out-of-range times.
6340 (check_tm_member): New function.
6341 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6342 (lisp_time_argument): Don't rely on undefined left-shift and
6343 right-shift behavior when checking for time stamp overflow.
8be6f318 6344
fe31d94c
PE
6345 * editfns.c (time_overflow): New function, refactoring common code.
6346 (Fformat_time_string, Fdecode_time, Fencode_time):
6347 (Fcurrent_time_string): Use it.
6348
8be6f318
PE
6349 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6350 * dired.c (make_time): Move to ...
6351 * editfns.c (make_time): ... here.
6352 * systime.h: Note the move.
6353
09d9db2c 63542011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6355
126bc0dc
YM
6356 * fringe.c (update_window_fringes): Remove unused variables.
6357
c47cbdfd
YM
6358 * unexmacosx.c (copy_data_segment): Also copy __got section.
6359 (Bug#8223)
6360
7ac80be9
EZ
63612011-03-12 Eli Zaretskii <eliz@gnu.org>
6362
c96bbc66 6363 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6364 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6365 Constify `char *' arguments and their references according to
6366 prototypes in tparam.h.
6367
ecb0f94d 6368 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6369
7ac80be9
EZ
6370 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6371 Adapt all references accordingly.
6372
6373 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6374
ef1fd07e
TT
63752011-03-11 Tom Tromey <tromey@redhat.com>
6376
6377 * buffer.c (syms_of_buffer): Remove obsolete comment.
6378
7ef4b50c
EZ
63792011-03-11 Eli Zaretskii <eliz@gnu.org>
6380
6381 * termhooks.h (encode_terminal_code): Declare prototype.
6382
6383 * msdos.c (encode_terminal_code): Don't declare prototype.
6384
6385 * term.c (encode_terminal_code): Now external again, used by
6386 w32console.c and msdos.c.
6387
44f230aa
SM
6388 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6389 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6390
4b1ec863 63912011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6392
1714f52b 6393 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6394
4b1ec863
PE
6395 * fringe.c (update_window_fringes): Mark locals as initialized
6396 (Bug#8227).
6397 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6398
524c7aa6
PE
6399 * alloc.c (mark_fringe_data): Move decl from here ...
6400 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6401 to check its interface.
6402 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6403
a5c0af81 6404 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6405 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6406 (fontset_font): Mark local as initialized.
a9a06e0b 6407 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6408
b4716021
PE
6409 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6410
811e9bac 6411 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6412 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6413 (x_own_selection, Fx_disown_selection_internal): Rename locals
6414 to avoid shadowing.
6415 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6416
7e3ab302
PE
6417 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6418 so that the caller can use some name other than gcpro1.
6419 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6420 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6421 (Fx_backspace_delete_keys_p):
6422 Use them to avoid shadowing, and rename vars to avoid shadowing.
6423 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6424 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6425 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6426 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6427 Remove unused locals.
7e3ab302
PE
6428 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6429 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6430 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6431 macros.
f78faa98 6432
e2b13473
PE
6433 * xterm.h (x_mouse_leave): New decl.
6434
77f23912
PE
6435 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6436 Remove unused functions.
cdf4ba58
PE
6437 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6438 (x_calc_absolute_position): Now static.
7411c686 6439 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6440 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6441 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6442 unless they are used.
38d0b34a
PE
6443 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6444 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6445 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6446 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6447 (x_error_catcher, x_connection_closed, x_error_handler):
6448 (x_error_quitter, xembed_send_message, x_iconify_frame):
6449 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6450 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6451 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6452
44f230aa
SM
6453 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6454 Rename or move locals to avoid shadowing.
6b463e58 6455 (tty_defined_color, merge_face_heights): Now static.
5967d051 6456 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6457 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6458 does not deduce is never used uninitialized.
73719eba
PE
6459 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6460 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6461
426994c3 6462 * terminal.c (store_terminal_param): Now static.
5489860b 6463
032f1620 6464 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6465 (set_frame_menubar): Remove unused local.
d4323972 6466 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6467 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6468 since they might point to immutable storage.
281585b0
PE
6469 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6470 since it's unused otherwise.
032f1620 6471
367c19e5 6472 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6473 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6474 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6475 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6476 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6477 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6478 does not deduce are never used uninitialized.
70739cbe 6479
07b48fa9
PE
6480 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6481
8868a238 6482 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6483 * window.c (window_loop, size_window):
6484 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6485
7e5cf297 6486 * window.c (display_buffer): Now static.
d6550a9f
PE
6487 (size_window): Mark variables that gcc -Wuninitialized
6488 does not deduce are never used uninitialized.
a586633d
PE
6489 * window.h (check_all_windows): New decl, to forestall
6490 gcc -Wmissing-prototypes diagnostic.
5b555da1 6491 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6492
f6095868
PE
6493 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6494 shadowing.
6495 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6496 Include <limits.h>.
6497 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6498 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6499 (load_charset_map): Mark variables that gcc -Wuninitialized
6500 does not deduce are never used uninitialized.
53df7c11 6501 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6502
f38b440c
PE
6503 * coding.c (coding_set_source, coding_set_destination):
6504 Use "else { /* comment */ }" rather than "else /* comment */;"
6505 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6506 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6507 a block, when the outer 'i' will do.
6508 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6509 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6510 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6511 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6512 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6513 Rename locals to avoid shadowing.
6514 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6515 * coding.c (emacs_mule_char, encode_invocation_designation):
6516 Now static, since they're not used elsewhere.
413bb2db 6517 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6518 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6519 (decode_coding_emacs_mule): Mark variables that gcc
6520 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6521 (detect_coding_iso_2022): Initialize a local variable that might
6522 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6523 this initialization is needed. (Bug#8211)
5f58e762
PE
6524 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6525 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6526 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6527 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6528 Remove unused macros.
f38b440c 6529
232b38b9 6530 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6531 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6532 * character.c (string_count_byte8): Likewise.
232b38b9 6533
fb90da1b
PE
6534 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6535 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6536
fb93dbc2
PE
6537 * chartab.c (copy_sub_char_table): Now static, since it's not used
6538 elsewhere.
5c156ace
PE
6539 (sub_char_table_ref_and_range, char_table_ref_and_range):
6540 Rename locals to avoid shadowing.
bbcd0949 6541 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6542
7d3b3862 6543 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6544 (BIDI_BOB): Remove unused macro.
7d3b3862 6545
6be7d3da
PE
6546 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6547 deduce are never used uninitialized.
c2ed9c8b 6548 * term.c (encode_terminal_code): Likewise.
6be7d3da 6549
75f8807f 6550 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6551
50938595
PE
6552 * tparam.h: New file.
6553 * term.c, tparam.h: Include it.
6554 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6555 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6556 Move these decls to tparam.h, and make them agree with what
6557 is actually in tparam.c. The previous trick of using incompatible
6558 decls in different modules does not conform to the C standard.
6559 All callers of tparam changed to use tparam's actual API.
6560 * tparam.c (tparam1, tparam, tgoto):
6561 Use const pointers where appropriate.
6562
fbceeba2
PE
6563 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6564 * cm.h (struct cm): Likewise.
6565 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6566 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6567 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6568 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6569 (turn_on_face, init_tty): Likewise.
6570 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6571
7f3f1250
PE
6572 * term.c (term_mouse_position): Rename local to avoid shadowing.
6573
e6ca6543
PE
6574 * alloc.c (mark_ttys): Move decl from here ...
6575 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6576
c40f8d15
AS
65772011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6578
6579 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6580
cfe0661d
JB
65812011-03-09 Juanma Barranquero <lekktu@gmail.com>
6582
6583 * search.c (compile_pattern_1): Remove argument regp, unused since
6584 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6585 (compile_pattern): Don't pass it.
6586
0afb4571
J
65872011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6588
6589 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6590 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6591 for ! HAVE_GTK3.
6592 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6593
6594 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6595
6596 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6597 gdk_window_get_screen, gdk_window_get_geometry,
6598 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6599 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6600 (xg_get_pixbuf_from_pixmap): New function.
6601 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6602 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6603 Call xg_get_pixbuf_from_pixmap instead of
6604 gdk_pixbuf_get_from_drawable.
6605 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6606 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6607 (xg_check_special_colors): Use GtkStyleContext and its functions
6608 for HAVE_GTK3.
6609 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6610 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6611 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6612 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6613 Call gtk_widget_get_preferred_size.
0afb4571
J
6614 (xg_frame_resized): gdk_window_get_geometry only takes 5
6615 parameters.
44f230aa
SM
6616 (xg_win_to_widget, xg_event_is_for_menubar):
6617 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6618 (xg_set_widget_bg): New function.
6619 (delete_cb): New function.
895009e1 6620 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6621 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6622 (xg_set_background_color): Call xg_set_widget_bg.
6623 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6624 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6625 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6626 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6627 if ! HAVE_GTK3.
6628 (update_frame_tool_bar): Call gtk_widget_hide.
6629 (xg_initialize): Use GDK_KEY_g.
6630
6631 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6632 if ! HAVE_GTK3
6633 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6634
6635 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6636 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6637 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6638
1c2cc4ef
JB
66392011-03-08 Juanma Barranquero <lekktu@gmail.com>
6640
6641 * w32xfns.c (select_palette): Check success of RealizePalette against
6642 GDI_ERROR, not zero.
6643
33383987 6644See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6645
6646;; Local Variables:
6647;; coding: utf-8
aac0c6e3
MR
6648;; End:
6649
33383987 6650 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6651
6652 This file is part of GNU Emacs.
6653
6654 GNU Emacs is free software: you can redistribute it and/or modify
6655 it under the terms of the GNU General Public License as published by
6656 the Free Software Foundation, either version 3 of the License, or
6657 (at your option) any later version.
6658
6659 GNU Emacs is distributed in the hope that it will be useful,
6660 but WITHOUT ANY WARRANTY; without even the implied warranty of
6661 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6662 GNU General Public License for more details.
6663
6664 You should have received a copy of the GNU General Public License
6665 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.