src/makefile.w32-in: Update dependencies.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ca300656
JB
12012-06-23 Juanma Barranquero <lekktu@gmail.com>
2
049ec95b
JB
3 * makefile.w32-in: Update dependencies.
4
ca300656
JB
5 * w32.c (ltime): Add return type and declare static.
6 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
7
db7b8d06
PE
82012-06-23 Paul Eggert <eggert@cs.ucla.edu>
9
10 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
11 Privately reported by Herbert J. Skuhra.
12 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
13 All uses changed.
14 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
15 not make_lisp_timeval, when the argument is of type EMACS_TIME.
16
0bd8297f
EZ
172012-06-23 Eli Zaretskii <eliz@gnu.org>
18
96512555
EZ
19 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
20 last argument of make_unibyte_string.
21
0bd8297f
EZ
22 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
23 language ID in the event parameters.
24
25 * w32term.c (w32_read_socket): Put the new keyboard codepage into
26 event.code, not the obscure "character set ID".
27
63def6b6
CY
282012-06-23 Chong Yidong <cyd@gnu.org>
29
30 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
31
e8a02204
EZ
322012-06-23 Eli Zaretskii <eliz@gnu.org>
33
388cdec0
EZ
34 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
35 * w32.c (fdutimens): New function.
36
37 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
38
39 * s/ms-w32.h (pselect): Redirect to sys_select.
40
41 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
42
e8a02204
EZ
43 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
44 in the logic of incrementing and decrementing the value of
45 use_relocatable_buffers.
46
d054f3fb
PE
472012-06-23 Paul Eggert <eggert@cs.ucla.edu>
48
49 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
50 Privately reported by Herbert J. Skuhra.
51 [__FreeBSD__]: Remove "*/" typo after "#include".
52 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
53 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
54 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
55 Don't assume EMACS_TIME and struct timeval are the same type.
56
d35af63c
PE
572012-06-22 Paul Eggert <eggert@cs.ucla.edu>
58
59 Support higher-resolution time stamps (Bug#9000).
60 The time stamps are only nanosecond-resolution at the C level,
61 since that's the best that any real-world system supports now.
62 But they are picosecond-resolution at the Lisp level, as that's
63 easy, and leaves room for future OS improvements.
64
65 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
66 (LIBES): Use it.
67
68 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
69 Don't get current time unless it's needed.
70
71 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
72 now provides it if it's absent.
73 (start_atimer): Port to higher-res time stamps.
74 Check for time stamp overflow. Don't get current time more
75 often than is needed.
76
77 * buffer.h (struct buffer): Buffer modtime now has high resolution.
78 Include systime.h, not time.h.
79 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
80
81 * dired.c: Include stat-time.h.
82 (Ffile-attributes): File times now have higher resolution.
83
84 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
85 (struct image): Timestamp now has higher resolution.
86
87 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
88 has at least microseconds now. All uses removed.
89 (update_frame, update_single_window, update_window, update_frame_1)
90 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
91
92 * editfns.c (time_overflow): Now extern.
93 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
94 (float-time, Fformat_time_string, Fcurrent_time_string)
95 (Fcurrent_time_zone): Accept and generate higher-resolution
96 time stamps.
97 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
98 (decode_time_components, lisp_seconds_argument): New functions.
99 (make_time): Now static.
100 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
101 Report an error if the time is invalid, rather than having the caller
102 do that.
103
104 * fileio.c: Include <stat-time.h>
105 (Fcopy_file): Copy higher-resolution time stamps.
106 Prefer to set the time stamp via a file descriptor if that works.
107 (Fset_file_times, Finsert_file_contents, Fwrite_region)
108 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
109 (Fvisited_file_modtime, Fset_visited_file_modtime):
110 Support higher-resolution time stamps.
111
112 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
113
114 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
115
116 * image.c (prepare_image_for_display, clear_image_cache)
117 (lookup_image): Port to higer-resolution time stamps.
118
119 * keyboard.c (start_polling, bind_polling_period):
120 Check for time stamp overflow.
121 (read_char, kbd_buffer_get_event, timer_start_idle)
122 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
123 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
124 Port to higher-resolution time stamps. Do not assume time_t is signed.
125 (decode_timer): New function. Timers are now vectors of length 9,
126 not 8, to accommodate the picosecond component.
127 (timer_check_2): Use it.
128
129 * nsterm.m (select_timeout, timeval_subtract): Remove.
130 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
131 as they're a bit more accurate and handle overflow better.
132 (ns_select): Change prototype to be compatible with pselect.
133 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
134 * nsterm.h (ns_select): Adjust prototype.
135
136 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
137 us-resolution time stamps.
138 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
139
140 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
141
142 * lisp.h (time_overflow): New decl.
143 (wait_reading_process_output): First arg is now intmax_t, not int,
144 to accommodate larger waits.
145
146 * process.h (struct Lisp_Process.read_output_delay):
147 Now counts nanoseconds, not microseconds.
148 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
149 EMACS_HAS_USECS.
150 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
151 (wait_reading_process_output):
152 Port to ns-resolution time stamps.
153 (Faccept_process_output, wait_reading_process_output):
154 Check for time stamp overflow. Do not assume time_t is signed.
155 (select_wrapper): Remove; we now use pselect.
156 (Fprocess_attributes): Now generates ns-resolution time stamps.
157
158 * sysdep.c: Include utimens.h. Don't include utime.h
159 or worry about struct utimbuf; gnulib does that for us now.
160 (gettimeofday): Remove; gnulib provides a substitute.
161 (make_timeval): New function.
162 (set_file_times): Now sets ns-resolution time stamps.
163 New arg FD; all uses changed.
164 (time_from_jiffies, ltime_from_jiffies, get_up_time)
165 (system_process_attributes):
166 Now returns ns-resolution time stamp. All uses changed.
167 Check for time stamp overflow.
168
169 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
170 provides a substitute now.
171
172 * systime.h: Include timespec.h rather than sys/time.h and time.h,
173 since it guarantees struct timespec.
174 (EMACS_TIME): Now struct timespec, so that we can support
175 ns-resolution time stamps.
176 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
177 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
178 (EMACS_USECS): Remove.
179 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
180 so multiply the arg by 1000 before storing it.
181 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
182 New macros.
183 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
184 Port to ns-resolution time stamps.
185 (EMACS_TIME_NEG_P): Remove; replaced by....
186 (EMACS_TIME_SIGN): New macro.
187 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
188 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
189 (set_file_times, make_time, lisp_time_argument): Adjust signature.
190 (make_timeval, make_lisp_time, decode_time_components): New decls.
191 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
192 that it mishandled time_t overflow. You can't compare by subtracting!
193 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
194 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
195
196 * term.c: Include <sys/time.h>.
197 (timeval_to_Time): New function, for proper overflow wraparound.
198 (term_mouse_position, term_mouse_click): Use it.
199
200 * undo.c (record_first_change): Support higher-resolution time stamps
201 in the undo buffer.
202 (Fprimitive_undo): Use them when restoring time stamps.
203
204 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
205 (w32_get_internal_run_time):
206 Port to higher-resolution Emacs time stamps.
207 (ltime): Now accepts single 64-bit integer, as that's more convenient
208 for callers.
209
210 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
211
212 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
213 for compatibility with pselect. Support ns-resolution time stamps.
214
215 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
216
217 * xselect.c (wait_for_property_change, x_get_foreign_selection):
218 Check for time stamp overflow, and support ns-resolution time stamps.
219
220 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
221 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
222 (timeval_subtract): Remove; no longer needed.
223 (XTflash, XTring_bell, x_wait_for_event):
224 Port to ns-resolution time stamps. Don't assume time_t is signed.
225
b6a92dfe
CY
2262012-06-22 Chong Yidong <cyd@gnu.org>
227
228 * xdisp.c (x_consider_frame_title): Revert last change.
229
d251c37c
EZ
2302012-06-22 Eli Zaretskii <eliz@gnu.org>
231
232 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
233 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
234 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
235 staticidx goes up to 1597 out of 1600 = 0x640.)
236
f10deafb
PE
2372012-06-20 Paul Eggert <eggert@cs.ucla.edu>
238
239 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
240 Otherwise, the umask might be mistakenly 0 while handling input signals.
241
ec6de1e2
SM
2422012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
243
244 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
245
28be1ada
DA
2462012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
247
248 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
249 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
250 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
251 access to `contents' member of Lisp_Vector objects with AREF and ASET
252 where appropriate.
253
c6bf3022
CY
2542012-06-19 Chong Yidong <cyd@gnu.org>
255
256 * frame.c (delete_frame): When selecting a frame on a different
257 text terminal, do not alter the terminal's top-frame.
258
259 * xdisp.c (format_mode_line_unwind_data): Record the target
260 frame's selected window and its terminal's top-frame.
261 (unwind_format_mode_line): Restore them.
262 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
263 Callers changed.
264 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
265 since tty frames can be explicitly named.
266 (prepare_menu_bars): Likewise.
267
268 * term.c (Ftty_top_frame): New function.
269
defd4196
PE
2702012-06-18 Paul Eggert <eggert@cs.ucla.edu>
271
272 Port byte-code-meter to modern targets.
273 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
274 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 275 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
276 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
277 (METER_1, METER_2): Simplify.
278
1053a871
SM
2792012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
280
281 * data.c (Fdefalias): Return `symbol' (bug#11686).
282
b7e8d081
MR
2832012-06-18 Martin Rudalics <rudalics@gmx.at>
284
285 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
286 gets killed during executing of this function (Bug#11665).
287 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
288 (Vkill_buffer_query_functions): In doc-string say that functions
289 run by this hook should not change the current buffer.
290
7ea2b339
PE
2912012-06-18 Paul Eggert <eggert@cs.ucla.edu>
292
293 Fix recently-introduced process.c problems found by static checking.
294 * process.c (write_queue_push, write_queue_pop, send_process):
295 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
296 (write_queue_pop): Fix pointer signedness problem.
297 (send_process): Remove unused local.
298
96a313a1
CY
2992012-06-17 Chong Yidong <cyd@gnu.org>
300
301 * xdisp.c (redisplay_internal): No need to redisplay terminal
302 frames that are not on top.
303
20ca2e94
TN
3042012-06-17 Troels Nielsen <bn.troels@gmail.com>
305
306 * process.c (make_process): Initialize write_queue.
307 (write_queue_push, write_queue_pop): New functions.
308 (send_process): Use them to maintain correct ordering of process
309 writes (Bug#10815).
310
9a900ca9
PE
3112012-06-17 Paul Eggert <eggert@cs.ucla.edu>
312
310fbfa8
PE
313 * lisp.h (eassert): Assume C89 or later.
314 This removes the need for CHECK.
315 (CHECK): Remove. Its comments about always evaluating its
316 argument were confusing, as 'eassert' typically does not evaluate
317 its argument.
318
27bb1ca4
PE
319 * coding.c (produce_chars): Use ptrdiff_t, not int.
320
9a900ca9
PE
321 * xterm.c (x_draw_underwave): Check for integer overflow.
322 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
323
41b7f8bc 3242012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
325
326 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
327 referenced (Bug#11583).
328
9b0e3eba
AA
3292012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
330
331 Implement wave-style variant of underlining.
332 * dispextern.h (face_underline_type): New enum.
333 (face): Add field for underline type.
334 * nsterm.m (ns_draw_underwave): New function.
335 (ns_draw_text_decoration): Use it.
336 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
337 New functions.
338 (x_draw_glyph_string): Use them.
339 * xfaces.c (Qline, Qwave): New Lisp objects.
340 (check_lface_attrs, merge_face_ref)
1053a871
SM
341 (Finternal_set_lisp_face_attribute, realize_x_face):
342 Handle wave-style underline face attributes.
9b0e3eba
AA
343 * xterm.c (x_draw_underwave): New function.
344 (x_draw_glyph_string): Use it.
345
0fb52f11
JB
3462012-06-16 Juanma Barranquero <lekktu@gmail.com>
347
348 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
349 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
350 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
351 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
352 ($(BLD)/w32select.$(O)): Update dependencies.
353
e5560ff7
AS
3542012-06-16 Andreas Schwab <schwab@linux-m68k.org>
355
356 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
357 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
358 * character.c (_fetch_multibyte_char_p): Remove.
359 * alloc.c: Include "character.h" before "buffer.h".
360 * bidi.c: Likewise.
361 * buffer.c: Likewise.
362 * bytecode.c: Likewise.
363 * callint.c: Likewise.
364 * callproc.c: Likewise.
365 * casefiddle.c: Likewise.
366 * casetab.c: Likewise.
367 * category.c: Likewise.
368 * cmds.c: Likewise.
369 * coding.c: Likewise.
370 * composite.c: Likewise.
371 * dired.c: Likewise.
372 * dispnew.c: Likewise.
373 * doc.c: Likewise.
374 * dosfns.c: Likewise.
375 * editfns.c: Likewise.
376 * emacs.c: Likewise.
377 * fileio.c: Likewise.
378 * filelock.c: Likewise.
379 * font.c: Likewise.
380 * fontset.c: Likewise.
381 * fringe.c: Likewise.
382 * indent.c: Likewise.
383 * insdel.c: Likewise.
384 * intervals.c: Likewise.
385 * keyboard.c: Likewise.
386 * keymap.c: Likewise.
387 * lread.c: Likewise.
388 * macros.c: Likewise.
389 * marker.c: Likewise.
390 * minibuf.c: Likewise.
391 * nsfns.m: Likewise.
392 * nsmenu.m: Likewise.
393 * print.c: Likewise.
394 * process.c: Likewise.
395 * regex.c: Likewise.
396 * region-cache.c: Likewise.
397 * search.c: Likewise.
398 * syntax.c: Likewise.
399 * term.c: Likewise.
400 * textprop.c: Likewise.
401 * undo.c: Likewise.
402 * unexsol.c: Likewise.
403 * w16select.c: Likewise.
404 * w32fns.c: Likewise.
405 * w32menu.c: Likewise.
406 * window.c: Likewise.
407 * xdisp.c: Likewise.
408 * xfns.c: Likewise.
409 * xmenu.c: Likewise.
410 * xml.c: Likewise.
411 * xselect.c: Likewise.
412
2f07e6af
EZ
4132012-06-16 Eli Zaretskii <eliz@gnu.org>
414
1053a871
SM
415 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
416 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 417 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
418 row.
419 (handle_face_prop): Use chunk-relative overlay string index when
420 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
421 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
422 the rightmost. (Bug#11720)
2f07e6af 423
29b83cec
AS
4242012-06-16 Andreas Schwab <schwab@linux-m68k.org>
425
426 * category.h (CHAR_HAS_CATEGORY): Define as inline.
427 (CATEGORY_MEMBER): Enforce 1/0 value.
428 * category.c (_temp_category_set): Remove.
429
4c5501e9
EZ
4302012-06-16 Eli Zaretskii <eliz@gnu.org>
431
432 * window.c (Fdelete_other_windows_internal)
433 (Fdelete_window_internal): Don't access frame's mouse highlight
434 info of the initial frame. (Bug#11677)
435
2b570124
PE
4362012-06-14 Paul Eggert <eggert@cs.ucla.edu>
437
e93864f9
PE
438 * .gdbinit (xgetint): Fix recently-introduced paren typo.
439 Assume USE_2_TAGS_FOR_INTS.
440 (xreload): Adjust $tagmask width to match recent lisp.h change.
441
2b570124
PE
442 Simplify lisp.h in minor ways that should not affect code.
443 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
444 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
445 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
446 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
447 (INTTYPEBITS): New macro, for clarity.
448 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
449 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
450 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
451 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
452 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
453
81755f69
JB
4542012-06-13 Juanma Barranquero <lekktu@gmail.com>
455
456 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
457
16192a57
GM
4582012-06-13 Glenn Morris <rgm@gnu.org>
459
460 * s/bsd-common.h (BSD4_3):
461 * s/usg5-4-common.h (USG5_4): No longer define; unused.
462
646b5f55
AS
4632012-06-13 Andreas Schwab <schwab@linux-m68k.org>
464
465 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
466 instead of union.
467 (XLI, XIL): Define.
1053a871
SM
468 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
469 Use them.
470 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 471 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 472 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
473 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
474 * frame.c (delete_frame): Remove outdated comment.
475 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
476 USE_LISP_UNION_TYPE.
477 (Fw32_unregister_hot_key): Likewise.
478 (Fw32_toggle_lock_key): Likewise.
479 * w32menu.c (add_menu_item): Likewise.
480 (w32_menu_display_help): Use XIL instead of checking
481 USE_LISP_UNION_TYPE.
482 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
483 (init_heap): Likewise.
484 * w32term.c (w32_read_socket): Update comment.
485
1d3823c9
GM
4862012-06-13 Glenn Morris <rgm@gnu.org>
487
c62ff706
GM
488 * s/usg5-4-common.h, src/s/unixware.h:
489 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
490
1d3823c9
GM
491 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
492
bfe3e0a2
PE
4932012-06-13 Paul Eggert <eggert@cs.ucla.edu>
494
495 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
496 * alloc.c (make_number) [!defined make_number]:
497 Remove, as lisp.h always defines this now.
498 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
499 (roundup_size): Verify that it is a power of 2.
500 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
501 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
502 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
503 -DUSE_LSB_TAG=0, to override the automatically-selected default.
504 USE_LSB_TAG now is always defined to be either 0 or 1.
505 All uses changed.
506 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
507 code works fine either way, and efficiency is not a concern here,
508 as the union type is for debugging, not for production.
509 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
510 Use an inline function on all platforms when using the union type,
511 since this is simpler and 'static inline' can be used portably
512 within Emacs now.
513 (LISP_INITIALLY_ZERO): New macro.
514 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
515 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
516
45fa9c0f
GM
5172012-06-12 Glenn Morris <rgm@gnu.org>
518
b4492cba
GM
519 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
520
521 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 522
45fa9c0f
GM
523 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
524 Move BROKEN_SIGIO to configure.
525
526 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
527 Move NO_TERMIO to configure.
528
0e25d334
CY
5292012-06-12 Chong Yidong <cyd@gnu.org>
530
531 * image.c (imagemagick_load_image): Use MagickFlattenImage if
532 MagickMergeImageLayers is undefined. Use pixel pusher loop if
533 MagickExportImagePixels is undefined.
534
43682bb6
PE
5352012-06-12 Paul Eggert <eggert@cs.ucla.edu>
536
537 * image.c (imagemagick_load_image): Remove unused label.
538
a9be7d2b
GM
5392012-06-11 Glenn Morris <rgm@gnu.org>
540
541 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
542 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
543 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
544 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
545
3017f87f
SM
5462012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
547
548 * alloc.c (make_byte_code): New function.
549 (Fmake_byte_code): Use it. Don't purify here.
550 * lread.c (read1): Use it as well to avoid extra allocation.
551
1b9b4cf4
CY
5522012-06-11 Chong Yidong <cyd@gnu.org>
553
554 * image.c (imagemagick_load_image): Implement transparency.
555
95988fcf
AS
5562012-06-10 Andreas Schwab <schwab@linux-m68k.org>
557
558 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
559 account for preceding backslashes. (Bug#11663)
560
cd4eb164
CY
5612012-06-09 Chong Yidong <cyd@gnu.org>
562
563 * term.c: Support italics in capable terminals (Bug#9652).
564 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
565 (turn_on_face): Output using TS_enter_italic_mode if available.
566 Don't handle unused blinking and alt-charset cases.
567 (turn_off_face): Handle italic case; discard unused tty_blinking_p
568 and tty_alt_charset_p cases.
569 (tty_capable_p, init_tty): Support italics.
570
571 * termchar.h (struct tty_display_info): Add field for italics.
572 Remove unused blink field.
573
574 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
575 Handle slant.
576
577 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
578 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
579 tty_alt_charset_p. Add tty_italic_p.
580
ff88beb8
MA
5812012-06-09 Michael Albinus <michael.albinus@gmx.de>
582
583 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
584 dbus_type_is_basic if available.
585 (xd_extract_signed, xd_extract_unsigned): Rename from
586 extract_signed and extract_unsigned, respectively. Adapt callers.
587
44286096
CY
5882012-06-09 Chong Yidong <cyd@gnu.org>
589
1682701f
CY
590 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
591
44286096
CY
592 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
593 case (Bug#9752).
594
d86feb17
PE
5952012-06-08 Paul Eggert <eggert@cs.ucla.edu>
596
597 * xdisp.c (vmessage): Treat frame message as multibyte.
598 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
599 would generate the diagnostic "Making \302\247 buffer-local while
600 let-bound!".
601
d5c20fe8
EZ
6022012-06-08 Eli Zaretskii <eliz@gnu.org>
603
604 * dispnew.c (showing_window_margins_p): Undo last change, which
605 was done due to an inadvertent commit.
606 (adjust_frame_glyphs_for_frame_redisplay): Do call
607 showing_window_margins_p.
608
513749ee
SM
6092012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
610
611 * eval.c (Fmake_var_non_special): New primitive.
612 (syms_of_eval): Defsubr it.
613 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
614
d4a8f5c1
JB
6152012-06-08 Juanma Barranquero <lekktu@gmail.com>
616
617 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
618 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
619
8bbbc977
EZ
6202012-06-08 Eli Zaretskii <eliz@gnu.org>
621
622 * alloc.c (allocate_vectorlike): Fix last change.
623
f3372c87
DA
6242012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
625
626 Block-based vector allocation of small vectors.
627 * lisp.h (struct vectorlike_header): New field `nbytes',
628 adjust comment accordingly.
629 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
630 to denote vector blocks. Adjust users (live_vector_p,
631 mark_maybe_pointer, valid_lisp_object_p) accordingly.
632 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
633 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
634 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
635 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
636 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
637 (roundup_size): New constant.
638 (struct vector_block): New data type.
639 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 640 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
641 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
642 (sweep_vectors): New functions.
643 (allocate_vectorlike): Return `zero_vector' as the only vector of
644 0 items. Allocate new vector from block if vector size is less than
645 or equal to VBLOCK_BYTES_MAX.
646 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
647 (init_alloc_once): Add call to init_vectors.
648
4f18a4ed
SM
6492012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
650
651 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
652
86f158bc
PE
6532012-06-07 Paul Eggert <eggert@cs.ucla.edu>
654
655 * doprnt.c (doprnt): Truncate multibyte char correctly.
656 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
657 would mishandle a string argument "Xc" if X was a multibyte
658 character of length 2: it would truncate after X's first byte
659 rather than including all of X.
660
c5cfcbe0
CY
6612012-06-06 Chong Yidong <cyd@gnu.org>
662
663 * buffer.c (word_wrap): Doc fix.
664
c05cf390
PE
6652012-06-04 Paul Eggert <eggert@cs.ucla.edu>
666
667 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
668
0c3461de
GM
6692012-06-03 Glenn Morris <rgm@gnu.org>
670
671 * xdisp.c (tool-bar-style): Doc fix.
672
c71232db
UM
6732012-06-03 Ulrich Müller <ulm@gentoo.org>
674
675 * Makefile.in (PAXCTL): Define.
676 (temacs$(EXEEXT)): Disable memory randomization for the temacs
677 binary via PaX flags if the paxctl utility is available.
678 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
679 Restore PaX flags to their default. (Bug#11398)
680
383f7350
CY
6812012-06-03 Chong Yidong <cyd@gnu.org>
682
683 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
684 buffer (Bug#11226).
685
5f2c76c6
CY
6862012-06-03 Chong Yidong <cyd@gnu.org>
687
688 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
689 (note_mode_line_or_margin_highlight): If there is no help echo,
690 use mode-line-default-help-echo. Handle the case where the mouse
691 position is past the end of the mode line string.
692
693 * buffer.c (buffer_local_value_1): New function, split from
694 Fbuffer_local_value; can return Qunbound.
695 (Fbuffer_local_value): Use it.
696 (Vmode_line_format): Docstring tweaks.
697
773d47f6
PE
6982012-06-02 Paul Eggert <eggert@cs.ucla.edu>
699
700 * sysdep.c (system_process_attributes): Improve comment.
701
f2d6a3df
SM
7022012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
703
704 * keyboard.c: Export real-this-command to Elisp.
705 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
706 and DEFVAR it. Update all users.
707
63810350
PE
7082012-06-02 Paul Eggert <eggert@cs.ucla.edu>
709
7bd5c1f4
PE
710 * minibuf.c (Fassoc_string): Remove duplicate declaration.
711
63810350
PE
712 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
713 Convert pctcpu and pctmem to Lisp float properly.
714 Let the compiler fold better, as 100.0/0x8000 is exact.
715
a2821611
AS
7162012-06-02 Andreas Schwab <schwab@linux-m68k.org>
717
718 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
719 cons_block.
720
5fceba1d
PE
7212012-06-01 Paul Eggert <eggert@cs.ucla.edu>
722
723 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
724
c98ff5dd
DA
7252012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
726
727 For a 'struct window', replace some Lisp_Object fields to
728 bitfields where appropriate, remove unused fields.
729 * window.h (struct window): Remove unused 'last_mark_x' and
730 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
731 change it's type from Lisp_Object to bitfield.
732 Change type of 'force_start', 'optional_new_start',
733 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
734 fields from Lisp_Object to bitfield. Adjust users accordingly.
735
ca34e0be
PE
7362012-05-31 Paul Eggert <eggert@cs.ucla.edu>
737
738 Pacify gcc -Wdouble-precision when using Xaw.
739 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
740 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
741 Use 'float' consistently, rather than 'float' in most places
742 and 'double' in a couple of places.
743
efc00ab1 7442012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
745
746 * xdisp.c (handle_stop): Detect whether we have overlay strings
747 loaded by testing it->current.overlay_string_index to be
748 non-negative, instead of checking whether n_overlay_strings is
749 positive. (Bug#11587)
750
efc00ab1 7512012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
752
753 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
754
755 * doc.c (Fsubstitute_command_keys): Doc fix.
756
efc00ab1 7572012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
758
759 * search.c (search_buffer): Remove calls to
760 r_alloc_inhibit_buffer_relocation, as it is now called by
761 maybe_unify_char, which was the cause of relocation of buffer text
762 in bug#11519.
763
efc00ab1 7642012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
765
766 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
767 for the duration of call to load_charset, to avoid problems with
768 callers of maybe_unify_char that access buffer text through C
769 pointers.
770
771 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
772 decrement the inhibition flag, instead of just setting or
773 resetting it.
774
ba93a187
PE
7752012-05-31 Paul Eggert <eggert@cs.ucla.edu>
776
777 Remove obsolete '#define static' cruft.
778 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
779 This #undef was "temporary" in 2000; it is no longer needed
780 now that '#define static' has gone away.
781 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
782 (gray_bitmap_bits): Remove; no longer needed.
783 All uses replaced with definiens.
784 * xterm.c: Include "bitmaps/gray.xbm".
785
9e4bf381
PE
7862012-05-30 Paul Eggert <eggert@cs.ucla.edu>
787
788 Clean up __executable_start, monstartup when --enable-profiling.
789 The following changes affect the code only when profiling.
790 * dispnew.c (__executable_start): Rename from safe_bcopy.
791 Define only on platforms that need it.
792 * emacs.c: Include <sys/gmon.h> when profiling.
793 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
794 (__executable_start): Remove decl, since lisp.h does it now.
795 (safe_bcopy): Remove decl; no longer has that name.
796 (main): Coalesce #if into single bit of code, for simplicity.
797 Cast pointers to uintptr_t, since standard libraries want integers
798 and not pointers.
799 * lisp.h (__executable_start): New decl.
800
32d72c2f
GM
8012012-05-31 Glenn Morris <rgm@gnu.org>
802
803 * image.c (Fimagemagick_types): Doc fix.
804
baac5bc7
JM
8052012-05-30 Jim Meyering <meyering@redhat.com>
806
807 * callproc.c (Fcall_process_region): Include directory component
808 in mkstemp error message (Bug#11586).
809
72cb32cf
PE
8102012-05-30 Paul Eggert <eggert@cs.ucla.edu>
811
812 * alloc.c, lisp.h (make_pure_vector): Now static.
813
61b108cc
SM
8142012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
815
816 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
817 Move to byte-run.el.
818 (Fautoload): Do the hash-doc more carefully.
819 * data.c (Fdefalias): Purify definition, except for keymaps.
820 (Qdefun): Move from eval.c.
821 * lisp.h (Qdefun): Remove.
822 * lread.c (read1): Tiny simplification.
823
471fe23d
TN
8242012-05-29 Troels Nielsen <bn.troels@gmail.com>
825
934f3f58 826 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
827 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
828 Bug#9642, but explicitly check that the buffer the overlay would
829 be moved to is live and rearrange lines to make sure that errors
830 will not put the overlay in an inconsistent state.
831 (Fdelete_overlay): Cosmetics.
832
85d0efd1
EZ
8332012-05-28 Eli Zaretskii <eliz@gnu.org>
834
835 * w32term.c (my_bring_window_to_top): New function.
836 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
837 could be different from the original one.
838 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
839 (Bug#11513)
840
841 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
842 by calling BringWindowToTop.
843
844 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
845 (WM_EMACS_END): Increase by one.
846
da92a98c
PE
8472012-05-28 Paul Eggert <eggert@cs.ucla.edu>
848
849 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
850 This avoids undefined behavior that might cause the eassert
851 to not catch an out-of-range value.
852
74d1f848
JB
8532012-05-28 Juanma Barranquero <lekktu@gmail.com>
854
855 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
856 Update dependencies.
857
9e1a06fc
EZ
8582012-05-27 Eli Zaretskii <eliz@gnu.org>
859
860 * bidi.c (bidi_mirror_char): Fix last change.
861
f3dd7312
AS
8622012-05-27 Andreas Schwab <schwab@linux-m68k.org>
863
864 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
865 when referring to sectname field in printf format.
866
81899c91
PE
8672012-05-27 Paul Eggert <eggert@cs.ucla.edu>
868
57b81a9f
PE
869 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
870 Only r_alloc_inhibit_buffer_relocation needed to be added;
871 the others were already declared.
872
81899c91
PE
873 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
874 before checking whether it's out of range. Put the check inside
875 eassert. See
876 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
877
33017faf 8782012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
879
880 * callproc.c (Fcall_process): Restore a line that was accidentally
881 commented out in the 2011-02-13 change (bug#11547).
882
33017faf 8832012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
884
885 * lisp.h [REL_ALLOC]: Add prototypes for external functions
886 defined on ralloc.c.
887
888 * buffer.c [REL_ALLOC]: Remove prototypes of
889 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
890 they are now on lisp.h.
891
892 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
893
894 * search.c (search_buffer): Use it to inhibit relocation of buffer
895 text while re_search_2 is doing its job, because re_search_2 is
896 passed C pointers to buffer text. (Bug#11519)
897
23415acf
EZ
898 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
899 Update value to 24.
900
44e27368
EZ
901 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
902 state after an additional call to move_it_in_display_line_to, keep
903 the values of it->max_ascent and it->max_descent found for the
904 entire line.
905 (pos_visible_p): Revert the comparison against bottom_y to what it
906 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
907 (Bug#11464)
908
c1892f11
PE
9092012-05-26 Paul Eggert <eggert@cs.ucla.edu>
910
911 Fix coding-related core dumps with gcc -ftrapv.
912 The code was computing A - B, where A and B are pointers, and B is
913 random garbage. This can lead to core dumps on platforms that
914 have special pointer registers, and it also leads to core dumps on
915 x86-64 when compiled with gcc -ftrapv. The fix is to compute
916 A - B only when B is initialized properly.
917 * coding.c (coding_set_source, coding_set_destination): Return void.
918 (coding_change_source, coding_change_destinations): New functions,
919 with the old behaviors of coding_set_source and coding_set_destination.
920 All callers that need an offset changed to use these new functions.
921
eb7afdad
GM
9222012-05-26 Glenn Morris <rgm@gnu.org>
923
924 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
925
f12fdf02
EZ
9262012-05-26 Eli Zaretskii <eliz@gnu.org>
927
53a63be6 928 Extend mouse support on W32 text-mode console.
61b108cc
SM
929 * xdisp.c (draw_row_with_mouse_face):
930 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 931
eb3f6f01 932 * w32console.c: Include window.h.
61b108cc
SM
933 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
934 New functions.
eb3f6f01
EZ
935 (initialize_w32_display): Initialize mouse-highlight data.
936
53a63be6
EZ
937 * w32inevt.c: Include termchar.h and window.h.
938 (do_mouse_event): Support mouse-autoselect-window. When the mouse
939 moves, call note_mouse_highlight. If help_echo changed, call
940 gen_help_event to produce help-echo message in the echo area.
941 Call clear_mouse_face if mouse_face_hidden is set in the mouse
942 highlight info.
943
4cfd81f6
PE
9442012-05-26 Paul Eggert <eggert@cs.ucla.edu>
945
946 * lread.c (read1): Simplify slightly to avoid an overflow warning
947 with GCC 4.7.0 on x86-64.
948
4446092a
EZ
9492012-05-26 Eli Zaretskii <eliz@gnu.org>
950
951 * bidi.c (bidi_mirror_char): Revert last change: an int is
952 definitely wide enough here.
953
42b2a986 9542012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 955
42b2a986 956 Fix integer width and related bugs (Bug#9874).
eb106a49 957 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
958 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
959 (string_bytes, check_sblock, allocate_string_data):
960 (compact_small_strings, Fmake_bool_vector, make_string)
961 (make_unibyte_string, make_multibyte_string)
962 (make_string_from_bytes, make_specified_string)
963 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
964 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
965 (mark_vectorlike):
966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
967 (allocate_pseudovector):
968 Use int, not EMACS_INT, where int is wide enough.
969 (inhibit_garbage_collection, Fgarbage_collect):
970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
971 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
972 int might not be wide enough.
973 (bidi_cache_search, bidi_cache_find, bidi_init_it)
974 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
975 (bidi_at_paragraph_end, bidi_find_paragraph_start)
976 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
977 (bidi_level_of_next_char, bidi_move_to_visually_next):
978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
979 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
980 (Fkill_buffer, Fset_buffer_major_mode)
981 (advance_to_char_boundary, Fbuffer_swap_text)
982 (Fset_buffer_multibyte, overlays_at, overlays_in)
983 (overlay_touches_p, struct sortvec, record_overlay_string)
984 (overlay_strings, recenter_overlay_lists)
985 (adjust_overlays_for_insert, adjust_overlays_for_delete)
986 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
987 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
988 (Foverlay_recenter, last_overlay_modification_hooks_used)
989 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
991 (validate_region): Omit unnecessary test for b <= e,
992 since that's guaranteed by the previous test.
d311d28c
PE
993 (adjust_overlays_for_delete): Avoid pos + length overflow.
994 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
995 (report_overlay_modification):
996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
997 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
998 Omit pointer cast, which isn't needed anyway, and doesn't work
999 after the EMACS_INT -> ptrdiff_t change.
02481186 1000 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1001 * buffer.h: Adjust decls to match defn changes elsewhere.
1002 (struct buffer_text, struct buffer):
1003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1004 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1005 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1006 not int, to avoid needless 32-bit limit on 64-bit hosts.
1007 (exec_byte_code): Use tighter memory-full test, one that checks
1008 for alloca overflow. Don't compute the address of the object just
1009 before an array, as that's not portable. Use EMACS_INT, not
1010 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1011 * callint.c (Fcall_interactively):
1012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1013 * callproc.c (call_process_kill, Fcall_process):
1014 Don't assume pid_t fits into an Emacs fixnum.
1015 (call_process_cleanup, Fcall_process, child_setup):
1016 Don't assume pid_t fits into int.
1017 (call_process_cleanup, Fcall_process, delete_temp_file)
1018 (Fcall_process_region):
1019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1020 (Fcall_process): Simplify handling of volatile integers.
1021 Use int, not EMACS_INT, where int will do.
1022 * casefiddle.c (casify_object, casify_region, operate_on_word)
1023 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1025 (casify_object): Avoid integer overflow when overallocating buffer.
1026 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1027 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1028 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1029 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1030 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1031 integers are now checked earlier. All uses replaced with XINT.
1032 (ccl_driver):
1033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1034 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1035 (ccl_driver, Fregister_code_conversion_map):
1036 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1037 (resolve_symbol_ccl_program): Check that vector header is in range.
1038 Always copy the vector, so that we can check its contents reliably
1039 now rather than having to recheck each instruction as it's being
1040 executed. Check that vector words fit in 'int'.
1041 (ccl_get_compiled_code, Fregister_ccl_program)
1042 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1043 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1044 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1045 contents are in range.
1046 (Fccl_execute_on_string): Check that status is in range.
1047 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1048 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1049 Accept and return EMACS_INT, not int, because callers can pass values
1050 out of 'int' range.
1051 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1052 (multibyte_chars_in_text, parse_str_as_multibyte)
1053 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1054 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1055 (string_escape_byte8, Fget_byte):
1056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1057 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1058 avoid mishandling large integers.
1059 * character.h: Adjust decls to match defn changes elsewhere.
1060 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1061 (Ffind_charset_region):
1062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1063 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1064 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1065 Don't assume fixnum fits in int.
d311d28c
PE
1066 (load_charset_map_from_vector, Fmap_charset_chars):
1067 Remove now-unnecessary CHECK_NATNUMs.
1068 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1069 Don't rely on undefined behavior with signed left shift overflow.
1070 Don't assume unsigned int fits into fixnum, or that fixnum fits
1071 into unsigned int. Don't require max_code to be a valid fixnum;
1072 that's not true for gb10830 4-byte on a 32-bit host. Allow
1073 invalid_code to be a cons, for the same reason. Require code_offset
1074 to be a character. Avoid int overflow if max_char is close
1075 to INT_MAX.
1076 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1077 this is intended anyway and avoids some undefined behavior.
1078 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1079 INDEX_TO_CODE_POINT, as that's what it expects.
1080 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1081 * charset.h (DECODE_CHAR): Return int, not unsigned;
1082 this is what was intended anyway, and it avoids undefined behavior.
1083 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1084 integer-overflow issues.
1085 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1086 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1087 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1088 * chartab.c (Fmake_char_table, Fset_char_table_range)
1089 (uniprop_get_decoder, uniprop_get_encoder):
1090 Don't assume fixnum fits in int.
1091 * cmds.c (move_point): New function, that does the gist of
1092 Fforward_char and Fbackward_char, but does so while checking
1093 for integer overflow more accurately.
c96e5d6a 1094 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1095 (Fforward_line, Fend_of_line, internal_self_insert)
1096 (internal_self_insert):
1097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1098 Fix a FIXME, by checking for integer overflow when calculating
1099 target_clm and actual_clm.
1100 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1101 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1102 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1103 (coding_alloc_by_making_gap, alloc_destination)
1104 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1105 (encode_coding_utf_16, detect_coding_emacs_mule)
1106 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1107 (detect_coding_iso_2022, decode_coding_iso_2022)
1108 (encode_invocation_designation, encode_designation_at_bol)
1109 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1110 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1111 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1112 (encode_coding_ccl, encode_coding_raw_text)
1113 (detect_coding_charset, decode_coding_charset)
1114 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1115 (produce_composition, produce_charset, produce_annotation)
1116 (decode_coding, handle_composition_annotation)
1117 (handle_charset_annotation, consume_chars, decode_coding_gap)
1118 (decode_coding_object, encode_coding_object, detect_coding_system)
1119 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1120 (code_convert_region, code_convert_string)
8f50130c
PE
1121 (Fdefine_coding_system_internal)
1122 (coding_set_source, coding_set_destination):
d311d28c
PE
1123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1124 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1125 (Fdefine_coding_system_internal):
1126 Don't assume fixnums fit in int.
1127 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1128 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1129 (Funencodable_char_position, Fcheck_coding_systems_region)
1130 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1132 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1133 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1134 Don't access memory outside of the args array.
d311d28c 1135 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1136 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1137 result of ENCODE_CHAR.
d311d28c
PE
1138 * coding.h: Adjust decls to match defn changes elsewhere.
1139 (struct coding_system):
1140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1141 * composite.c (get_composition_id, find_composition)
1142 (run_composition_function, update_compositions)
1143 (compose_text, composition_gstring_put_cache)
1144 (composition_gstring_p, composition_gstring_width)
1145 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1146 (composition_compute_stop_pos, composition_reseat_it)
1147 (composition_update_it, struct position_record)
1148 (find_automatic_composition, composition_adjust_point)
1149 (Fcomposition_get_gstring, Ffind_composition_internal):
1150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1151 (update_compositions):
1152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1153 * composite.h: Adjust decls to match defn changes elsewhere.
1154 (struct composition):
1155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1156 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1157 Do not attempt to compute the address of the object just before a
1158 buffer; this is not portable.
1159 (Faref, Faset):
1160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1161 (Faset): Use int, not EMACS_INT, where int is wide enough.
1162 (Fstring_to_number): Don't assume fixnums fit in int.
1163 (Frem): Don't assume arg is nonnegative.
1164 * dbusbind.c (xd_append_arg): Check for integers out of range.
1165 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1166 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1167 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1168 (xd_get_connection_references): Return ptrdiff_t, not int.
1169 All uses changed.
1170 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1171 (xd_read_message_1):
1172 Use int, not unsigned, where the dbus API uses int.
1173 (Fdbus_message_internal): Don't overflow mtype.
1174 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1175 * dired.c (directory_files_internal, file_name_completion, scmp)
1176 (file_name_completion_stat):
1177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1178 (file_name_completion): Don't overflow matchcount.
1179 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1180 * dispextern.h: Adjust decls to match defn changes elsewhere.
1181 (struct text_pos, struct glyph, struct bidi_saved_info)
1182 (struct bidi_string_data, struct bidi_it, struct composition_it)
1183 (struct it):
1184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1185 (struct display_pos, struct composition_it, struct it):
1186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1187 * dispnew.c (increment_matrix_positions)
1188 (increment_row_positions, mode_line_string)
1189 (marginal_area_string):
1190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1191 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1193 (duration_to_sec_usec): New function, to check for overflow better.
1194 (Fsleep_for, sit_for): Use it.
1195 * doc.c (get_doc_string, store_function_docstring):
1196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1197 (get_doc_string, Fsnarf_documentation):
1198 Use int, not EMACS_INT, where int is wide enough.
1199 (get_doc_string):
1200 Use SAFE_ALLOCA, not alloca.
1201 Check for overflow when converting EMACS_INT to off_t.
1202 * doprnt.c (doprnt):
1203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1204 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1205 Don't assume uid_t fits into fixnum.
1206 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1207 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1208 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1209 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1210 (general_insert_function)
1211 (Finsert_char, make_buffer_string, make_buffer_string_both)
1212 (update_buffer_properties, Fbuffer_substring)
1213 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1214 (Fsubst_char_in_region, check_translation)
1215 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1216 (transpose_markers, Ftranspose_regions):
1217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1218 (clip_to_bounds): Move to lisp.h as an inline function).
1219 (Fconstrain_to_field): Don't assume integers are nonnegative.
1220 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1221 (Fsubst_char_in_region, Fsave_restriction):
1222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1223 (Femacs_pid): Don't assume pid_t fits into fixnum.
1224 (lo_time): Use int, not EMACS_INT, when int suffices.
1225 (lisp_time_argument): Check for usec out of range.
1226 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1227 (Fuser_login_name, Fuser_full_name): Signal an error
1228 if a uid argument is out of range, rather than relying on
1229 undefined behavior.
c8d5c857
PE
1230 (Fformat_time_string): Remove now-unnecessary check.
1231 lisp_time_argument checks for out-of-range usec now.
243e0530 1232 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1233 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1234 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1235 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1236 (init_cmdargs, Fdump_emacs):
1237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1238 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1239 the bottom (typically) 32 bits of the fixnum.
1240 * eval.c (specpdl_size, call_debugger):
1241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1242 (when_entered_debugger, Fbacktrace_debug):
1243 Don't assume fixnum can fit in int.
1244 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1245 the object just before a buffer; this is not portable.
1246 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1247 (grow_specpdl, unbind_to):
1248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1249 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1250 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1251 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1252 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1253 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1255 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1256 (a_write, e_write):
1257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1258 (Fcopy_file, non_regular_nbytes, read_non_regular)
1259 (Finsert_file_contents):
1260 Use int, not EMACS_INT, where int is wide enough.
1261 (READ_BUF_SIZE): Verify that it fits in int.
1262 (Finsert_file_contents): Check that counts are in proper range,
1263 rather than assuming fixnums fit into ptrdiff_t etc.
1264 Don't assume fixnums fit into int.
125b3835 1265 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1266 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1267 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1268 (string_char_to_byte, string_byte_to_char)
1269 (string_make_multibyte, string_to_multibyte)
1270 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1271 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1272 (substring_both, Fdelete, internal_equal, Ffillarray)
1273 (Fclear_string, mapcar1)
1274 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1275 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1276 (larger_vector, make_hash_table, maybe_resize_hash_table)
1277 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1278 (Fmaphash, secure_hash):
1279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1280 (concat): Check for string index and length overflow.
1281 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1282 (Frequire):
1283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1284 (larger_vector): New API (vec, incr_min, size_max) replaces old
1285 one (vec, new_size, init). This catches size overflow.
1286 INIT was removed because it was always Qnil.
1287 All callers changed.
1288 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1289 the upper bound on a hash table index size.
1290 (make_hash_table, maybe_resize_hash_table): Use it.
1291 (secure_hash): Computer start_byte and end_byte only after
1292 they're known to be in ptrdiff_t range.
1293 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1294 (Ffont_get_glyphs, Ffont_at):
1295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1296 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1297 (Flist_fonts, Fopen_font):
1298 Don't assume fixnum can fit in int.
1299 (check_gstring): Don't assume index can fit in int.
1300 (font_match_p): Check that fixnum is a character, not a nonnegative
1301 fixnum, since the later code needs to stuff it into an int.
1302 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1303 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1304 conversion overflow issues.
1305 (Fopen_font): Check for integer out of range.
1306 (Ffont_get_glyphs): Don't assume index can fit in int.
1307 * font.h: Adjust decls to match defn changes elsewhere.
1308 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1309 integer overflow.
1310 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1311 printmax_t, where ptrdiff_t is wide enough.
1312 (Finternal_char_font):
1313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1314 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1315 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1316 (Fset_frame_position, x_set_frame_parameters)
1317 (x_set_line_spacing, x_set_border_width)
1318 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1319 Check that fixnums are in proper range for system types.
1320 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1322 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1323 Use SAFE_ALLOCA_LISP, not alloca.
1324 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1325 intptr_t is wide enough.
1326 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1327 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1328 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1329 Check for fixnum out of range.
1330 * ftfont.c (ftfont_list): Don't assume index fits in int.
1331 Check that fixnums are in proper range for system types.
1332 (ftfont_shape_by_flt):
1333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1334 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1336 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1337 Check that fixnums are in proper range for system types.
1338 * gnutls.h: Adjust decls to match defn changes elsewhere.
1339 * gtkutil.c (xg_dialog_run):
1340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1341 (update_frame_tool_bar):
1342 Check that fixnums are in proper range for system types.
1343 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1344 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1345 * indent.c (last_known_column, last_known_column_point):
1346 (current_column_bol_cache):
1347 (skip_invisible, current_column, check_display_width):
1348 (check_display_width, scan_for_column, current_column_1)
1349 (Findent_to, Fcurrent_indentation, position_indentation)
1350 (indented_beyond_p, Fmove_to_column, compute_motion):
1351 (Fcompute_motion, Fvertical_motion):
1352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1353 (last_known_column_modified): Use EMACS_INT, not int.
1354 (check_display_width):
1355 (Fcompute_motion):
1356 Check that fixnums and floats are in proper range for system types.
1357 (compute_motion): Don't assume index or fixnum fits in int.
1358 (compute_motion, Fcompute_motion):
1359 Use int, not EMACS_INT, when it is wide enough.
1360 (vmotion): Omit local var start_hpos that is always 0; that way
1361 we don't need to worry about overflow in expressions involving it.
1362 * indent.h: Adjust decls to match defn changes elsewhere.
1363 (struct position):
1364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1365 Use int, not EMACS_INT, where int is wide enough.
1366 Remove unused members ovstring_chars_done and tab_offset;
1367 all uses removed.
1368 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1369 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1370 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1371 (make_gap, copy_text, insert, insert_and_inherit)
1372 (insert_before_markers, insert_before_markers_and_inherit)
1373 (insert_1, count_combining_before, count_combining_after)
1374 (insert_1_both, insert_from_string)
1375 (insert_from_string_before_markers, insert_from_string_1)
1376 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1377 (adjust_after_replace, adjust_after_insert, replace_range)
1378 (replace_range_2, del_range, del_range_1, del_range_byte)
1379 (del_range_both, del_range_2, modify_region)
1380 (prepare_to_modify_buffer, signal_before_change)
1381 (signal_after_change, Fcombine_after_change_execute):
1382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1383 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1384 (balance_an_interval, split_interval_right, split_interval_left)
1385 (find_interval, next_interval, update_interval)
1386 (adjust_intervals_for_insertion, delete_node, delete_interval)
1387 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1388 (static_offset_intervals, offset_intervals)
1389 (merge_interval_right, merge_interval_left, make_new_interval)
1390 (graft_intervals_into_buffer, temp_set_point_both)
1391 (temp_set_point, set_point, adjust_for_invis_intang)
1392 (set_point_both, move_if_not_intangible, get_property_and_range)
1393 (get_local_map, copy_intervals, copy_intervals_to_string)
1394 (compare_string_intervals, set_intervals_multibyte_1):
1395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1396 * intervals.h: Adjust decls to match defn changes elsewhere.
1397 (struct interval):
1398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1399 * keyboard.c (this_command_key_count, this_single_command_key_start)
1400 (before_command_key_count, before_command_echo_length, echo_now)
1401 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1402 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1403 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1404 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1406 (last_non_minibuf_size, last_point_position, echo_truncate)
1407 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1408 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1409 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1410 (stuff_buffered_input):
1411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1412 (last_auto_save, command_loop_1, read_char):
1413 Use EMACS_INT, not int, to avoid integer overflow.
1414 (record_char): Avoid overflow in total_keys computation.
1415 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1416 * keyboard.h: Adjust decls to match defn changes elsewhere.
1417 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1418 (Fkey_description, Fdescribe_vector, Flookup_key):
1419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1420 (click_position): New function, to check that positions are in range.
1421 (Fcurrent_active_maps):
1422 (describe_command):
1423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1424 (Faccessible_keymaps, Fkey_description):
1425 (preferred_sequence_p):
1426 Don't assume fixnum can fit into int.
1427 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1428 Check for integer overflow in size calculations.
1429 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1430 avoid mishandling large integers.
1431 * lisp.h: Adjust decls to match defn changes elsewhere.
1432 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1433 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1434 (struct Lisp_Marker):
1435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1436 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1437 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1438 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1439 All callers changed.
1440 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1441 Assume the arg has valid form, since it always does.
1442 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1443 unsigned integer system type.
1444 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1445 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1447 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1448 (duration_to_sec_usec): New decl.
1449 * lread.c (read_from_string_index, read_from_string_index_byte)
1450 (read_from_string_limit, readchar, unreadchar, openp)
1451 (read_internal_start, read1, oblookup):
1452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1453 (Fload, readevalloop, Feval_buffer, Feval_region):
1454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1455 (openp): Check for out-of-range argument to 'access'.
1456 (read1): Use int, not EMACS_INT, where int is wide enough.
1457 Don't assume fixnum fits into int.
6efdadfd 1458 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1459 (read_filtered_event): Use duration_to_sec_usec
1460 to do proper overflow checking on durations.
d311d28c
PE
1461 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1462 in size calculation.
1463 (Fexecute_kbd_macro):
1464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1465 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1466 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1467 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1468 (set_marker_both, set_marker_restricted_both, marker_position)
1469 (marker_byte_position, Fbuffer_has_markers_at):
1470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1471 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1472 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1473 It now merely ensures that the menu is large enough, without
1474 necessarily growing it, as this avoids some integer overflow issues.
1475 All callers changed.
1476 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1478 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1479 Use SAFE_ALLOCA_LISP, not alloca.
1480 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1481 to EMACS_INT. Check that fixnums are in proper range for system types.
1482 * minibuf.c (minibuf_prompt_width, string_to_object)
1483 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1484 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1486 (get_minibuffer, read_minibuf_unwind):
1487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1488 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1489 this simplifies overflow checking. All callers changed.
1490 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1491 (Ftest_completion):
1492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1493 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1494 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1495 Check that fixnums are in proper range for system types.
1496 (Fx_create_frame, Fx_show_tip):
1497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1498 * nsfont.m (ns_findfonts, nsfont_list_family):
1499 Don't assume fixnum fits in long.
1500 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1502 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1503 wide enough.
17fdb222 1504 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1506 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1507 (PRINTDECLARE, PRINTPREPARE):
1508 (strout, print_string):
1509 (print, print_preprocess, print_check_string_charset_prop)
1510 (print_object):
1511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1512 (PRINTDECLARE):
1513 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1515 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1516 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1517 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1518 (print_error_message): Use SAFE_ALLOCA, not alloca.
1519 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1520 (print_depth, new_backquote_output, print_number_index):
1521 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1522 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1523 (Fset_process_window_size, Fformat_network_address)
1524 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1525 (sigchld_handler):
d311d28c 1526 Check that fixnums are in proper range for system types.
d44287d4 1527 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1528 Check for process-ids out of pid_t range rather than relying on
1529 undefined behavior.
e4d81efc 1530 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1531 (Fformat_network_address, read_process_output, send_process)
1532 (Fprocess_send_region, status_notify):
1533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1534 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1535 (wait_reading_process_output, read_process_output, exec_sentinel):
1536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1537 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1538 (Faccept_process_output): Use duration_to_sec_usec to do proper
1539 overflow checking on durations.
dde14581
PE
1540 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1541 Don't assume pid_t fits in int.
02481186
PE
1542 * process.h (struct Lisp_Process): Members tick and update_tick
1543 are now of type EMACS_INT, not int.
b62b53e8
PE
1544 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1545 configured --with-wide-int.
d311d28c
PE
1546 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1547 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1548 * search.c (looking_at_1, string_match_1):
1549 (fast_string_match, fast_c_string_match_ignore_case)
1550 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1551 (scan_newline, find_before_next_newline, search_command)
1552 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1553 (set_search_regs, wordify):
1554 (Freplace_match):
1555 (Fmatch_data):
1556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1557 (string_match_1, search_buffer, set_search_regs):
1558 (Fmatch_data):
1559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1560 (wordify): Check for overflow in size calculation.
1561 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1562 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1563 Check that fixnums are in proper range for system types.
1564 * sound.c (struct sound_device)
1565 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1567 (Fplay_sound_internal):
1568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1569 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1570 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1571 (Fparse_partial_sexp):
1572 Don't assume fixnums can fit in int.
1573 (struct lisp_parse_state, find_start_pos, find_start_value)
1574 (find_start_value_byte, find_start_begv)
1575 (update_syntax_table, char_quoted, dec_bytepos)
1576 (find_defun_start, prev_char_comend_first, back_comment):
1577 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1578 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1580 (Finternal_describe_syntax_value): Check that match_lisp is a
1581 character, not an integer, since the code stuffs it into int.
1582 (scan_words, scan_sexps_forward):
1583 Check that fixnums are in proper range for system types.
1584 (Fforward_word):
1585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1586 (scan_sexps_forward):
1587 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1588 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1589 * syntax.h: Adjust decls to match defn changes elsewhere.
1590 (struct gl_state_s):
1591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1592 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1593 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1594 * sysdep.c (wait_for_termination_1, wait_for_termination)
1595 (interruptible_wait_for_termination, mkdir):
1596 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1597 (emacs_read, emacs_write):
1598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1599 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1600 and double all fit in int.
d311d28c
PE
1601 * term.c (set_tty_color_mode):
1602 Check that fixnums are in proper range for system types.
1603 * termhooks.h (struct input_event):
1604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1605 * textprop.c (validate_interval_range, interval_of)
1606 (Fadd_text_properties, set_text_properties_1)
1607 (Fremove_text_properties, Fremove_list_of_text_properties)
1608 (Ftext_property_any, Ftext_property_not_all)
1609 (copy_text_properties, text_property_list, extend_property_ranges)
1610 (verify_interval_modification):
1611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1612 (Fnext_single_char_property_change)
1613 (Fprevious_single_char_property_change):
1614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1615 (copy_text_properties):
1616 Check for integer overflow in index calculation.
d311d28c
PE
1617 * undo.c (last_boundary_position, record_point, record_insert)
1618 (record_delete, record_marker_adjustment, record_change)
1619 (record_property_change):
1620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1621 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1623 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1624 (Fx_hide_tip, Fx_file_dialog):
1625 * w32menu.c (set_frame_menubar):
1626 Use ptrdiff_t, not int, for consistency with rest of code.
1627 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1628 (select_window, Fdelete_other_windows_internal)
1629 (window_scroll_pixel_based, window_scroll_line_based)
1630 (Frecenter, Fset_window_configuration):
1631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1632 (Fset_window_hscroll, run_window_configuration_change_hook)
1633 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1634 (Fscroll_other_window, Frecenter):
d311d28c
PE
1635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1636 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1637 Don't assume fixnum fits in int.
1638 (Fset_window_scroll_bars):
1639 Check that fixnums are in proper range for system types.
1640 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1641 (string_pos, c_string_pos, number_of_chars, init_iterator)
1642 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1643 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1644 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1645 (face_before_or_after_it_pos, handle_invisible_prop)
1646 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1647 (display_prop_intangible_p, string_buffer_position_lim)
1648 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1649 (get_overlay_strings_1, get_overlay_strings)
1650 (iterate_out_of_display_property, forward_to_next_line_start)
1651 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1652 (get_next_display_element, set_iterator_to_next)
1653 (get_visually_first_element, compute_stop_pos_backwards)
1654 (handle_stop_backwards, next_element_from_buffer)
1655 (move_it_in_display_line_to, move_it_in_display_line)
1656 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1657 (add_to_log, message_dolog, message_log_check_duplicate)
1658 (message2, message2_nolog, message3, message3_nolog
1659 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1660 (current_message_1, truncate_echo_area, truncate_message_1)
1661 (set_message, set_message_1, store_mode_line_noprop)
1662 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1663 (text_outside_line_unchanged_p, check_point_in_composition)
1664 (reconsider_clip_changes)
1665 (redisplay_internal, set_cursor_from_row, try_scrolling)
1666 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1667 (redisplay_window, find_last_unchanged_at_beg_row)
1668 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1669 (trailing_whitespace_p, find_row_edges, display_line)
1670 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1671 (display_mode_element, store_mode_line_string)
1672 (pint2str, pint2hrstr, decode_mode_spec)
1673 (display_count_lines, display_string, draw_glyphs)
1674 (x_produce_glyphs, x_insert_glyphs)
1675 (rows_from_pos_range, mouse_face_from_buffer_pos)
1676 (fast_find_string_pos, mouse_face_from_string_pos)
1677 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1679 (safe_call, init_from_display_pos, handle_fontified_prop)
1680 (handle_single_display_spec, load_overlay_strings)
1681 (with_echo_area_buffer, setup_echo_area_for_printing)
1682 (display_echo_area, echo_area_display)
1683 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1684 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1685 (redisplay_window, dump_glyph_row, display_mode_line)
1686 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1687 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1689 (handle_single_display_spec, build_desired_tool_bar_string)
1690 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1691 (get_specified_cursor_type):
1692 Check that fixnums are in proper range for system types.
1693 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1694 (Flookup_image_map):
1695 Don't assume fixnums fit in int.
1696 (compare_overlay_entries):
1697 Avoid mishandling comparisons due to subtraction overflow.
1698 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1699 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1700 (handle_tool_bar_click):
1701 Use int, not unsigned, since we prefer signed and the signedness
1702 doesn't matter here.
1703 (get_next_display_element, next_element_from_display_vector):
1704 Use int, not EMACS_INT, when int is wide enough.
1705 (start_hourglass): Use duration_to_sec_usec to do proper
1706 overflow checking on durations.
1707 * xfaces.c (Fbitmap_spec_p):
1708 Check that fixnums are in proper range for system types.
1709 (compare_fonts_by_sort_order):
1710 Avoid mishandling comparisons due to subtraction overflow.
1711 (Fx_family_fonts, realize_basic_faces):
1712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1713 (Fx_family_fonts):
1714 Don't assume fixnum fits in int.
1715 Use SAFE_ALLOCA_LISP, not alloca.
1716 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1717 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1718 (face_at_buffer_position, face_for_overlay_string)
1719 (face_at_string_position):
1720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1721 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1722 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1723 (Fx_show_tip):
1724 Check that fixnums are in proper range for system types.
1725 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1726 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1728 (Fx_change_window_property): Don't assume fixnums fit in int.
1729 * xfont.c (xfont_chars_supported):
1730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1731 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1732 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1734 * xml.c (parse_region):
1735 * xrdb.c (magic_file_p):
1736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1737 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1738 (x_get_local_selection, x_reply_selection_request)
1739 (x_handle_selection_request, wait_for_property_change):
1740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1741 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1742 short is wide enough.
1743 (x_send_client_event): Don't assume fixnum fits in int.
1744 * xterm.c (x_x_to_emacs_modifiers):
1745 Don't assume EMACS_INT overflows nicely into int.
1746 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1747 may come from Lisp.
1748 (handle_one_xevent): NATNUMP can eval its arg twice.
1749 (x_connection_closed):
1750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1751 * xterm.h: Adjust decls to match defn changes elsewhere.
1752 (struct scroll_bar): Use struct vectorlike_header
1753 rather than rolling our own approximation.
1754 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1755
c6574eb5
GM
17562012-05-25 Glenn Morris <rgm@gnu.org>
1757
1758 * lisp.mk (lisp): Update for more files being compiled now.
1759
e8d32c7e
SM
17602012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1761
48def666
SM
1762 * lread.c: Remove `read_pure' which makes no difference.
1763 (read_pure): Remove var.
1764 (unreadpure): Remove function.
1765 (readevalloop): Don't call read_list with -1 flag.
1766 (read1, read_vector): Don't test read_pure any more.
1767 (read_list): Simplify.
1768
e8d32c7e
SM
1769 * fileio.c, character.h: Minor style tweaks.
1770
4b2addb7
DA
17712012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1772
1773 * window.h (clip_changed): Remove useless declaration.
1774
584461b2
JB
17752012-05-22 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1778 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1779
34374650
PE
17802012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 Remove src/m/*.
1783 This directory predates autoconf and is no longer needed nowadays.
1784 Move its few remaining bits of functionality to where they're needed.
1785 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1786 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1787 * m/template.h: Remove.
1788 * Makefile.in (M_FILE): Remove. All uses removed.
1789 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1790 * lisp.h (USE_LSB_TAG):
1791 * mem-limits.h (EXCEEDS_LISP_PTR):
1792 Use VAL_MAX, not VALBITS, in #if.
1793 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1794 (EMACS_UINT): Define unconditionally now.
1795 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1796 (BITS_PER_EMACS_INT): New constants, replacing
1797 what used to be in config.h, but not useful in #if.
1798 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1799 define them any more.
1800 (VAL_MAX): New macro.
1801 (VALMASK): Use it.
1802 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1803 BITS_PER_EMACS_INT, in #if.
1804 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1805 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1806 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1807 * s/ms-w32.h (DATA_START):
1808 Move here from removed file m/intel386.h.
1809 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1810 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1811
261cb4bb
PE
18122012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1813
1814 Assume C89 or later.
1815 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1816 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1817 (xrealloc):
1818 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1819 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1820 * textprop.c, tparam.c (NULL): Remove.
1821 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1822 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1823 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1824 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1825 * xterm.c (input_signal_count): Assume volatile works.
1826
ff23cd9f
KB
18272012-05-21 Ken Brown <kbrown@cornell.edu>
1828
1829 * xgselect.c (xg_select): Fix first argument in call to 'select'
1830 (bug#11508).
1831
1b170bc6
KB
18322012-05-20 Ken Brown <kbrown@cornell.edu>
1833
1834 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1835 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1836
b2f4d39f
KB
18372012-05-19 Ken Brown <kbrown@cornell.edu>
1838
1839 * xfns.c (x_in_use): Remove `static' qualifier.
1840 * xterm.h (x_in_use): Declare.
1841 * xgselect.c: Include xterm.h.
1842 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1843 and `display_arg' (bug#9754).
1844
003fdae2
PE
18452012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1846
9232a6d9
PE
1847 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1848
003fdae2
PE
1849 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1850 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1851
784b56e2
EZ
18522012-05-18 Eli Zaretskii <eliz@gnu.org>
1853
1854 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1855
1856 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1857 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1858
1859 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1860 reference to image_cache->refcount.
1861 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1862
a0a79cde
JL
18632012-05-17 Juri Linkov <juri@jurta.org>
1864
1865 * search.c (Fword_search_regexp, Fword_search_backward)
1866 (Fword_search_forward, Fword_search_backward_lax)
1867 (Fword_search_forward_lax): Move functions to isearch.el
1868 (bug#10145, bug#11381).
1869
b0572523
PE
18702012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1873
9660f5fc
SM
18742012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1875
1876 * lread.c (init_obarray): Declare Qt and Qnil as special.
1877
4374de83
GM
18782012-05-14 Glenn Morris <rgm@gnu.org>
1879
1880 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1881 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1882
dc44c39a
PE
18832012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1884
078c97cb
PE
1885 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1886
dc44c39a
PE
1887 * unexaix.c: Port to more-recent AIX compilers.
1888 (report_error, report_error_1, make_hdr, copy_sym)
1889 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1890 Make arguments const char *, not char *, to avoid violations of C
1891 standard and to fix some AIX warnings reported by Gilles Pion.
1892
e18afed7 18932012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1894
1895 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1896 already have overlays loaded.
1897 (handle_single_display_spec): Before returning without displaying
1898 fringe bitmap, synchronize the bidi iterator with the main display
1899 iterator, by calling iterate_out_of_display_property.
1900 (iterate_out_of_display_property): Detect buffer iteration by
1901 testing that it->string is a Lisp string.
1902 (get_next_display_element): When the current object is exhausted,
1903 and there's something on it->stack, call set_iterator_to_next to
1904 proceed with what's on the stack, instead of returning zero.
1905 (set_iterator_to_next): If called at the end of a Lisp string,
1906 proceed to consider_string_end without incrementing string
1907 position. Don't increment display vector index past the end of
1908 the display vector. (Bug#11417)
c8fb9dc6
EZ
1909 (pos_visible_p): Don't report a position visible when move_it_to
1910 stopped at the last line of window, which happens to be scanned
1911 backwards by the bidi iteration. (Bug#11464)
ac268e67 1912
e18afed7 19132012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1914
1915 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1916 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1917 are on a TTY, and thus unable to display on the fringes.
1918 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1919 so we need to signal to the caller that this is a "replacing"
1920 display spec. This fixes display when the spec is invalid or we
1921 are on a TTY.
1922
e18afed7 19232012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1924
1925 * unexaix.c (make_hdr): Fix typo in prototype.
1926 This bug broke the build on AIX. Problem reported by Gilles Pion.
1927
9d0a235a
MA
19282012-05-14 Michael Albinus <michael.albinus@gmx.de>
1929
1930 * keyboard.c (kbd_buffer_get_event): Read special events also in
1931 batch mode. (Bug#11415)
1932
9e6b06ed
GM
19332012-05-12 Glenn Morris <rgm@gnu.org>
1934
1935 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1936
c1a1d7a3
EZ
19372012-05-12 Eli Zaretskii <eliz@gnu.org>
1938
1939 * lisp.mk (lisp): Add newcomment.elc.
1940
3fe7cdc8
GM
19412012-05-12 Glenn Morris <rgm@gnu.org>
1942
1943 * Makefile.in (MKDIR_P): New, set by configure.
1944 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1945
53f7d2c0
PE
19462012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1947
1948 Remove unused function hourglass_started.
1949 * dispextern.h (hourglass_started):
1950 * w32fns.c (hourglass_started):
1951 * xdisp.c (hourglass_started): Remove.
1952
75aafb17
JB
19532012-05-10 Juanma Barranquero <lekktu@gmail.com>
1954
1955 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1956 Update dependencies.
1957
12959e8e
PE
19582012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1959
97107e2e
PE
1960 * xgselect.c (xg_select): Put maxfds+1 into a var.
1961 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1962
12959e8e
PE
1963 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1964
836d29b3
DA
19652012-05-10 Dave Abrahams <dave@boostpro.com>
1966
1967 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1968 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1969
5cb67954
MA
19702012-05-09 Michael Albinus <michael.albinus@gmx.de>
1971
1972 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1973 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1974 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1975 Initialize xd_registered_buses.
1976
3478ec45
PE
19772012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1978
b263a6b0
PE
1979 Untag more efficiently if USE_LSB_TAG.
1980 This is based on a proposal by YAMAMOTO Mitsuharu in
1981 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1982 For an admittedly artificial (nth 8000 longlist) benchmark on
1983 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1984 Emacs's overall text size by 1%.
1985 * lisp.h (XUNTAG): New macro.
1986 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1987 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1988 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1989 * eval.c (Fautoload):
1990 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1991 * frame.h (XFRAME): Use XUNTAG.
1992
3478ec45
PE
1993 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1994 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1995 Remove unportable assumptions about print widths of types like
1996 dbus_uint32_t.
1997 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1998 intptr_t when converting between pointer and integer, to avoid GCC
1999 warnings about wrong width.
2000
666b903b 20012012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2002
2003 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2004 stack for each reader_thread, instead of defaulting to 8MB
2005 determined by the linker. This avoids failures in creating
2006 subprocesses on Windows 7, see the discussion in this thread:
2007 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2008
b120cc17
JC
20092012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2010
2011 Fix up display of the *Minibuf-0* buffer in the mini window.
2012 * keyboard.c (read_char): Don't clear the echo area if there's no
2013 message to clear.
2014 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2015 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2016
9a4b36f8
MA
20172012-05-07 Michael Albinus <michael.albinus@gmx.de>
2018
2019 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2020 batch mode.
2021
e5f9458f
CY
20222012-05-06 Chong Yidong <cyd@gnu.org>
2023
2024 * lisp.mk (lisp): Update.
2025
eceeb5fc 20262012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2027
2028 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2029
71873e2b
SM
20302012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2031
2032 * data.c (PUT_ERROR): New macro.
2033 (syms_of_data): Use it. Add new error type `user-error'.
2034 * undo.c (user_error): New function.
2035 (Fprimitive_undo): Use it.
2036 * print.c (print_error_message): Adjust print style for `user-error'.
2037 * keyboard.c (user_error): New function.
2038 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2039
ab0fa4e4
PE
20402012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2041
2042 Do not limit current-time-string to years 1000..9999.
2043 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2044 (Fcurrent_time_string): Support any year that is supported by the
2045 underlying localtime representation. Don't use asctime, as it
2046 has undefined behavior for years outside the range -999..9999.
2047
7ed806a7
PE
20482012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 Fix race conditions involving setenv, gmtime, localtime, asctime.
2051 Without this fix, interrupts could mess up code that uses these
2052 nonreentrant functions, since setting TZ invalidates existing
2053 tm_zone or tzname values, and since most of these functions return
2054 pointers to static storage.
2055 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2056 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2057 Grow the critical sections to include not just invoking
2058 localtime/gmtime, but also accessing these functions' results
2059 including their tm_zone values if any, and any related TZ setting.
2060 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2061 so that the struct tm is saved in the critical section.
2062 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2063 motivated by the fact that memory allocation needs to be outside
2064 the critical section.
2065
0c16dfed
DA
20662012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2067
2068 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2069 with RESET_INTERVAL.
2070
2071 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2072 Remove duplicated buffer name initialization.
2073
3f83ace8
JM
20742012-05-02 Jim Meyering <jim@meyering.net>
2075
2076 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2077
c7b8541e
JM
2078 * xfns.c (x_window): Use xstrdup (Bug#11375).
2079
90207a15 20802012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2081
2082 * xdisp.c (pos_visible_p): If already at a newline from the
2083 display string before the 'while' loop, don't walk back the glyphs
2084 from it3.glyph_row. Solves assertion violation when the display
2085 string begins with a newline (egg.el). (Bug#11367)
2086
b593d6a9
AH
20872012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2088
2089 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2090 Move to simple.el.
2091
4737362e
GM
20922012-05-01 Glenn Morris <rgm@gnu.org>
2093
99cf43f9
GM
2094 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2095 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2096 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2097 All were removed before 23.1.
2098
9311dcff
GM
2099 * dispnew.c: Remove HAVE_LIBNCURSES test;
2100 it is always true on relevant platforms.
2101
4d5c6349
GM
2102 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2103 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2104
4737362e
GM
2105 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2106
74dd3a6b
AS
21072012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2108
2109 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2110 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2111 Remove.
2112
13c379ee
PE
21132012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2114
2115 Do not avoid creating empty evaporating overlays (Bug#9642).
2116 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2117 That is, do not delete an evaporating overlay if it becomes
2118 empty after its bounds are adjusted to fit within its buffer.
2119 This fix caused other problems, and I'm reverting it until we get
2120 to the bottom of them.
2121
a8e7d6d7 21222012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2123
2124 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2125
a8e7d6d7 21262012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2127
2128 * xdisp.c (pos_visible_p): If the window start position is beyond
2129 ZV, start the display from buffer beginning. Prevents assertion
2130 violation in init_iterator when the minibuffer window is scrolled
2131 via the scroll bar.
2132
2133 * window.c (window_scroll_pixel_based): Likewise.
2134
a8e7d6d7 21352012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2136
2137 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2138
a8e7d6d7 21392012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2140
2141 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2142 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2143
a8e7d6d7 21442012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2145
b593d6a9
AH
2146 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2147 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2148
1c6900d9
EZ
21492012-04-26 Eli Zaretskii <eliz@gnu.org>
2150
4c3fa1d9
EZ
2151 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2152 display element, check also the underlying string or buffer
2153 character. (Bug#11341)
2154
1c6900d9
EZ
2155 * w32menu.c: Include w32heap.h.
2156 (add_menu_item): If the call to AppendMenuW (via
2157 unicode_append_menu) fails, disable Unicode menus only if we are
2158 running on Windows 9X/Me.
2159
42bf8205
AS
21602012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2161
2162 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2163 (xgetint): Add missing shift for LSB tags.
2164
b1bac16e
MR
21652012-04-24 Martin Rudalics <rudalics@gmx.at>
2166
2167 * keyboard.c (read_char): Don't wipe echo area for select window
2168 events: These might get delayed via `mouse-autoselect-window'
2169 (Bug#11304).
2170
d69621cc
JB
21712012-04-24 Juanma Barranquero <lekktu@gmail.com>
2172
2173 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2174 manipulation of :loaded-from data.
2175
02fd101b
JB
21762012-04-23 Juanma Barranquero <lekktu@gmail.com>
2177
2178 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2179 now a cons (bug#11311).
2180
888bec30
PE
21812012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2182
89a438bd
PE
2183 Do not create empty overlays with the evaporate property (Bug#9642).
2184 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2185 if it becomes empty after its bounds are adjusted to fit within
2186 its buffer. Without this fix, in a nonempty buffer (let ((o
2187 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2188 yields an empty overlay that has the evaporate property, which is
2189 not supposed to happen.
2190
1068fe4d
PE
2191 Fix minor GTK3 problems found by static checking.
2192 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2193 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2194 (struct _EmacsFixedClass, emacs_fixed_get_type):
2195 Move decls here from emacsgtkfixed.h, since they needn't be public.
2196 (emacs_fixed_get_type): Now static.
2197 (emacs_fixed_class_init): Omit unused local.
2198 (emacs_fixed_child_type): Remove; unused.
2199 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2200 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2201 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2202 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2203 (EMACS_FIXED_GET_CLASS): Remove; unused.
2204 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2205
888bec30
PE
2206 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2207 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2208
de85e130
PE
22092012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2210
d0baac98 2211 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2212 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2213 (__malloc_size_t, __malloc_ptrdiff_t):
2214 Remove. All uses removed, replaced by the definiens if needed,
2215 since we can assume C89 or better now.
2216 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2217 (protect_malloc_state, align, get_contiguous_space)
2218 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2219 (malloc_atfork_handler_child, malloc_enable_thread)
2220 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2221 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2222 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2223 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2224 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2225 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2226 Define using prototypes, not old style.
2227 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2228 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2229 (align): Don't assume that signed integer overflow wraps around.
2230 Omit unused local var.
2231 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2232 (_free_internal_nolock, memalign, mallochook, reallochook):
2233 Omit no-longer-needed casts.
2234 (valloc): Use getpagesize, not __getpagesize.
2235 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2236 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2237
de85e130
PE
2238 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2239
dcbf5805
MA
22402012-04-22 Michael Albinus <michael.albinus@gmx.de>
2241
2242 Move functions from C to Lisp. Make non-blocking method calls
2243 the default. Implement further D-Bus standard interfaces.
2244
2245 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2246 (QCdbus_request_name_allow_replacement)
2247 (QCdbus_request_name_replace_existing)
2248 (QCdbus_request_name_do_not_queue)
2249 (QCdbus_request_name_reply_primary_owner)
2250 (QCdbus_request_name_reply_in_queue)
2251 (QCdbus_request_name_reply_exists)
2252 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2253 (QCdbus_registered_serial, QCdbus_registered_method)
2254 (QCdbus_registered_signal): New Lisp objects.
2255 (XD_DEBUG_MESSAGE): Use sizeof.
2256 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2257 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2258 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2259 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2260 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2261 (xd_signature, xd_append_arg): Allow float for integer types.
2262 (xd_get_connection_references): New function.
b593d6a9
AH
2263 (xd_get_connection_address): Rename from xd_initialize.
2264 Return cached address.
dcbf5805
MA
2265 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2266 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2267 level.
2268 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2269 Return number of refcounts.
dcbf5805
MA
2270 (Fdbus_get_unique_name): Make stronger parameter check.
2271 (Fdbus_message_internal): New defun.
2272 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2273 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2274 (Fdbus_send_signal, Fdbus_register_service)
2275 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2276 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2277 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2278 (Vdbus_compiled_version, Vdbus_runtime_version)
2279 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2280 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2281 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2282 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2283 Adapt docstring.
dcbf5805 2284
52828e02
PE
22852012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2286
da05bc4c
PE
2287 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2288 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2289 Do not assume ptrdiff_t is the same width as 'int'.
2290
52828e02
PE
2291 * alloc.c: Handle unusual debugging option combinations.
2292 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2293 since the two debugging options are incompatible.
2294 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2295 is defined.
2296 (mem_init, mem_insert, mem_insert_fixup):
2297 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2298 (NEED_MEM_INSERT): Remove; no longer needed.
2299
f01769f9
LL
23002012-04-22 Leo Liu <sdl.web@gmail.com>
2301
2302 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2303
5790543d
PE
23042012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 * sysdep.c [__FreeBSD__]: Minor cleanups.
2307 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2308 Use Emacs indenting style more consistently. Avoid some casts.
2309 Use 'double' consistently rather than mixing 'float' and 'double'.
2310
b91b7e4d
EW
23112012-04-21 Eduard Wiebe <usenet@pusto.de>
2312
b593d6a9
AH
2313 * sysdep.c (list_system_processes, system_process_attributes):
2314 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2315
6114eb15
AS
23162012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2317
2318 * lisp.mk (lisp): Update.
2319
2f38dff7
PE
23202012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2321
2322 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2323 It is never used otherwise.
2324
4ae29f89
SM
23252012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2326
2327 * print.c (print_preprocess): Only check print_depth if print-circle
2328 is nil.
2329 (print_object): Check for cycles even when print-circle is nil and
2330 print-gensym is t, but only check print_depth if print-circle is nil.
2331
f30d612a
CY
23322012-04-20 Chong Yidong <cyd@gnu.org>
2333
2334 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2335 set the status to "failed" and ensure that sentinel is run.
2336
c07a4c0b 23372012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2338
2339 * process.c (Fset_process_inherit_coding_system_flag)
2340 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2341 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2342
c07a4c0b 23432012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2344
2345 * xdisp.c (string_buffer_position_lim): Limit starting position to
2346 BEGV.
2347 (set_cursor_from_row): If called for a mode-line or header-line
2348 row, return zero immediately.
2349 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2350 farther than the first row after the header line, if any.
2351 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2352 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2353
c07a4c0b 23542012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2355
4ae29f89
SM
2356 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2357 (bug#11238).
ad3a2b41 2358
c07a4c0b 23592012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 23602012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2361
2362 configure: new option --enable-gcc-warnings (Bug#11207)
2363 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2364 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2365 (ALL_CFLAGS): Use new macros rather than old.
2366 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2367 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2368 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2369 -Wunused-result, -Wunused-variable. This should go away once
2370 the Emacs and Gnulib regex code is merged.
2371 (xmalloc, xrealloc): Now static.
2372
aba027e8
PE
23732012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * dired.c (Fsystem_groups): Remove unused local.
2376
e5a36063
GM
23772012-04-17 Glenn Morris <rgm@gnu.org>
2378
2379 * dired.c (Fsystem_users): Doc fix.
2380
316411f0
DA
23812012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2382
2383 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2384 (syms_of_dired): Add them.
2385
9426aba4
PE
23862012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2387
b62a57be
PE
2388 Fix minor alloc.c problems found by static checking.
2389 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2390 New extern decls, to avoid calling undeclared functions.
2391 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2392 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2393 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2394 (NEED_MEM_INSERT): New macro.
2395 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2396 Remove one incorrect comment and fix another.
b62a57be 2397
3539f31f
PE
2398 Fix minor ralloc.c problems found by static checking.
2399 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2400 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2401 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2402 (r_alloc_sbrk): Now static.
2403
a041960a
PE
2404 Improve ralloc.c interface checking.
2405 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2406 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2407 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2408 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2409 [REL_ALLOC]: ... to here, to check interface.
2410 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2411 Remove decls. This fixes an "It stinks!".
2412
9426aba4
PE
2413 * alloc.c (which_symbols): Fix alignment issue / type clash.
2414
d55c12ed
AS
24152012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2416
2417 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2418 (struct Lisp_Misc_Any): Likewise.
2419 (struct Lisp_Free): Likewise.
2420 * alloc.c (union aligned_Lisp_Symbol): Define.
2421 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2422 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2423 (union aligned_Lisp_Misc): Define.
2424 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2425 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2426 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2427
b948ce8b
PE
24282012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2429
2430 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2431 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2432 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2433 * s/netbsd.h, s/sol2-6.h:
2434 Remove definition of GC_MARK_STACK, since the default now works.
2435 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2436 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2437 no longer the default.
2438 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2439
35dc09a1 24402012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2441
35dc09a1
GM
2442 * lread.c (lisp_file_lexically_bound_p):
2443 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2444
35dc09a1
GM
24452012-04-14 Eli Zaretskii <eliz@gnu.org>
2446
2447 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2448 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2449
24502012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2451
2452 * nsterm.m (constrainFrameRect): Always constrain when there is only
2453 one screen (Bug#10962).
2454
bcd86815
KB
24552012-04-13 Ken Brown <kbrown@cornell.edu>
2456
2457 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2458
c25df26e
RT
24592012-04-13 Reuben Thomas <rrt@sc3d.org>
2460
2461 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2462
0fc59f1e
DC
24632012-04-11 Daniel Colascione <dancol@dancol.org>
2464
2465 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2466 against is gone. It's better to use vfork now so that when Cygwin
2467 gains a new, working vfork, we use it automatically (bug#10398).
2468
de8c03dc
SM
24692012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2470
2471 * window.c (save_window_save): Obey window-point-insertion-type.
2472
2f097256
GM
24732012-04-11 Glenn Morris <rgm@gnu.org>
2474
2475 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2476
453b951e
SM
24772012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2478
2479 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2480
75f1671a 24812012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2482
2483 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2484 (force_quit_count): New var.
2485 (handle_interrupt): Use it.
2486
2a8ce227
JB
24872012-04-10 Juanma Barranquero <lekktu@gmail.com>
2488
2489 * w32.c (w32_delayed_load): Record the full path of the library
2490 being loaded (bug#10424).
2491
935396c0
GM
24922012-04-09 Glenn Morris <rgm@gnu.org>
2493
05920a43
GM
2494 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2495 not just in the obarray, before snarfing them. (Bug#11036)
2496
935396c0
GM
2497 * Makefile.in ($(leimdir)/leim-list.el):
2498 Pass EMACS rather than BUILT_EMACS.
2499
a18ecafa
TZ
25002012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2501
2502 * process.c (make_process):
2503 * process.h: Add integer `gnutls_handshakes_tried' member to
2504 process struct.
2505
6bbef4e5
JC
2506 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2507 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2508
2509 * gnutls.c (gnutls_log_function2i): Convenience log function.
2510 (emacs_gnutls_read): Use new log functions,
2511 `gnutls_handshakes_tried' process member, and
2512 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2513 attempts per process (connection).
2514
b4d3bc10
CY
25152012-04-09 Chong Yidong <cyd@gnu.org>
2516
2517 * eval.c (Fuser_variable_p, user_variable_p_eh)
2518 (lisp_indirect_variable): Functions deleted.
2519 (Fdefvar): Caller changed.
2520
2521 * callint.c (Finteractive, Fcall_interactively):
2522 * minibuf.c (Fread_variable): Callers changed.
2523
70f4d973
EZ
25242012-04-09 Eli Zaretskii <eliz@gnu.org>
2525
2526 * xdisp.c (set_cursor_from_row): If the display string appears in
2527 the buffer at position that is closer to point than the position
2528 after the display string, display the cursor on the first glyph of
2529 the display string. Fixes cursor display when a 'display' text
2530 property immediately follows invisible text. (Bug#11094)
2531
cb3c2e3e
PE
25322012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 composite.c: use 'double' consistently
2535 * composite.c (get_composition_id): Use 'double' consistently
2536 instead of converting 'float' to 'double' and vice versa; this is
2537 easier to understand and avoids a GCC warning.
2538
fd06db5d
GM
25392012-04-09 Glenn Morris <rgm@gnu.org>
2540
50fe702a
GM
2541 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2542 preparation for dumping it with emacs. (Bug#4789)
2543 (leimdir): New variable.
2544 ($(leimdir)/leim-list.el): New rule.
2545 (emacs$(EXEEXT)): Depend on leim-list.el.
2546
fd06db5d
GM
2547 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2548 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2549 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2550
55c131ee
AS
25512012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2552
2553 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2554 proper alignment.
2555
9209588f
JB
25562012-04-07 Juanma Barranquero <lekktu@gmail.com>
2557
2558 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2559 Remove unused local variable.
2560
e3fb2efb
PE
25612012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2564 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2565 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2566 objects, as mark_maybe_pointer will catch them otherwise.
2567 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2568 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2569
b5385551
PE
25702012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 Fix typo that broke non-Windows builds.
2573 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2574
9078ead6
EZ
25752012-04-07 Eli Zaretskii <eliz@gnu.org>
2576
2577 Support building on MS-Windows with libxml2.
2578
2579 * makefile.w32-in (OBJ2): Add xml.$(O).
2580 (GLOBAL_SOURCES): Add xml.c.
2581 ($(BLD)/xml.$(O)): New dependency list.
2582
2583 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2584 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2585 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2586 [!WINDOWSNT]: New macros.
2587 (init_libxml2_functions, libxml2_loaded_p): New functions.
2588 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2589 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2590 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2591 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2592 linked in).
6bbef4e5
JC
2593 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2594 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2595 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2596
2597 * emacs.c: Don't include libxml/parser.h.
2598 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2599 xmlCleanupParser directly.
2600
2601 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2602
3811fdf3
EZ
26032012-04-07 Eli Zaretskii <eliz@gnu.org>
2604
2605 * indent.c (Fvertical_motion): If there is a display string at
2606 point, use it.vpos to compute how many lines to backtrack after
2607 move_it_to point. (Bug#11133)
2608
2f8e16b2
EZ
26092012-04-06 Eli Zaretskii <eliz@gnu.org>
2610
2611 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2612 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2613 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2614 macros related to unification of CJK characters. For the details,
2615 see the discussion following the message here:
2616 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2617
3d439cd1
CY
26182012-04-04 Chong Yidong <cyd@gnu.org>
2619
2620 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2621
8bc53d00
EZ
26222012-04-01 Eli Zaretskii <eliz@gnu.org>
2623
2624 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2625 instead of alloca. (Bug#11138)
2626
3b0512a3
AS
26272012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2628
2629 * w32menu.c (is_simple_dialog): Properly check lisp types.
2630 (Bug#11141)
2631
8427ddd2
EZ
26322012-03-31 Eli Zaretskii <eliz@gnu.org>
2633
979022ef
EZ
2634 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2635 position we get to after a call to move_it_to fails the
2636 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2637 only if we wind up in a string from display property. (Bug#11063)
2638
a6b1c7cc
EZ
2639 * window.c (Fdelete_other_windows_internal): Invalidate the row
2640 and column information about mouse highlight, so that redisplay
2641 restores it after reallocating the glyph matrices. (Bug#7464)
2642
8427ddd2
EZ
2643 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2644 string comes from a `display' text property, use the buffer
2645 position of that property as if we actually saw that position in
2646 the row's glyphs.
697ba24b
EZ
2647 (move_it_by_lines): Remove the assertion that
2648 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2649 violated when there's a before-string at the beginning of a line.
2650 (Bug#11063)
8427ddd2 2651
65a0a738
EZ
26522012-03-30 Eli Zaretskii <eliz@gnu.org>
2653
2654 * xdisp.c (append_space_for_newline): If the default face was
2655 remapped, use the remapped face for the appended newline.
2656 (extend_face_to_end_of_line): Use the remapped default face for
2657 extending the face to the end of the line.
2658 (display_line): Call extend_face_to_end_of_line when the default
2659 face was remapped. (Bug#11068)
2660
581355cc
EZ
26612012-03-29 Eli Zaretskii <eliz@gnu.org>
2662
2663 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2664
e8fc049f
SM
26652012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2666
2667 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2668
4fb9a543
GM
26692012-03-27 Glenn Morris <rgm@gnu.org>
2670
2671 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2672 Doc fixes.
2673
679910f1
KH
26742012-03-26 Kenichi Handa <handa@m17n.org>
2675
2676 * dispextern.h (struct glyph): Fix previous change. Change the
2677 bit length of glyphless.ch to 25 (Bug#11082).
2678
90d49b7f
CY
26792012-03-26 Chong Yidong <cyd@gnu.org>
2680
2681 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2682 (command_loop_1): Use it; inhibit selection update for
2683 handle-select-window too (Bug#8996).
2684
f514f6f0
FP
26852012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2686
e8fc049f 2687 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2688
bf43fa51
KH
26892012-03-25 Kenichi Handa <handa@m17n.org>
2690
2691 * dispextern.h (struct glyph): Change the bit length of
2692 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2693
8a0c01dd
EZ
26942012-03-24 Eli Zaretskii <eliz@gnu.org>
2695
2696 * s/ms-w32.h (tzname): Include time.h before redirecting to
2697 _tzname. Fixes the MSVC build. (Bug#9960)
2698
7d1c3a76
AS
26992012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2700
8ed79523
AS
2701 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2702 characters.
2703
7d1c3a76
AS
2704 * xterm.c (XTread_socket): Only modify handling_signal if
2705 !SYNC_INPUT. (Bug#11080)
2706
e99a9b8b
EZ
27072012-03-23 Eli Zaretskii <eliz@gnu.org>
2708
2709 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2710 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2711 when fetching a multibyte character consumes more bytes than
2712 CHAR_BYTES returns, due to unification of CJK characters in
2713 string_char. (Bug#11073)
2714
5063c0e1
TN
27152012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2716
2717 * process.c (wait_reading_process_output): Handle pty disconnect
2718 by refraining from sending oneself a SIGCHLD (bug#10933).
2719
9f851fbd
CY
27202012-03-22 Chong Yidong <cyd@gnu.org>
2721
2722 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2723
5063c0e1 2724 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2725 Mark string as coming from a prefix property.
2726 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2727 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2728
fb5b8aca
CY
27292012-03-21 Chong Yidong <cyd@gnu.org>
2730
2731 * xfaces.c (Vface_remapping_alist): Doc fix.
2732
62356a1b
EZ
27332012-03-20 Eli Zaretskii <eliz@gnu.org>
2734
2735 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2736 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2737 Doc fixes.
62356a1b 2738
025de85b
CY
27392012-03-20 Chong Yidong <cyd@gnu.org>
2740
2741 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2742 to reflect default non-nil value of redisplay-dont-pause.
2743
4827f94e
KH
27442012-03-19 Kenichi Handa <handa@m17n.org>
2745
2746 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2747 it fit in a valid range (Bug#11003).
2748
e50a24a2
EZ
27492012-03-18 Eli Zaretskii <eliz@gnu.org>
2750
2751 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2752 that is not from display property, accept the row as a "cursor
2753 row" if one of the string's character has a non-nil `cursor'
2754 property. Fixes cursor positioning when there are newlines in
2755 overlay strings, e.g. in icomplete.el. (Bug#11035)
2756
9af5ed87
PE
27572012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2758
2759 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2760
d1f55f16
CY
27612012-03-12 Chong Yidong <cyd@gnu.org>
2762
2763 * eval.c (inhibit_lisp_code): Rename from
2764 inhibit_window_configuration_change_hook; move from window.c.
2765
2766 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2767 * window.c (run_window_configuration_change_hook)
2768 (syms_of_window): Callers changed.
2769
66c5eebd
CY
27702012-03-11 Chong Yidong <cyd@gnu.org>
2771
413df973
CY
2772 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2773
66c5eebd
CY
2774 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2775
1de11f56
CY
27762012-03-10 Chong Yidong <cyd@gnu.org>
2777
2778 * frame.c (other_visible_frames): Don't assume the selected frame
2779 is visible (Bug#10955).
2780
cae07000
SM
27812012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2782
2783 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2784
89c94350
JD
27852012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2786
2787 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2788 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2789 zero (Bug#10954).
2790
999dd333
GM
27912012-03-03 Glenn Morris <rgm@gnu.org>
2792
01a6dcc8 2793 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2794
de0100f2
EZ
27952012-03-02 Eli Zaretskii <eliz@gnu.org>
2796
2797 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2798 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2799 (redisplay_window, next_element_from_string): Fix typos in
2800 comments.
3e441275
EZ
2801 (redisplay_window): Pass to move_it_vertically the margin in
2802 pixels, not in screen lines.
de0100f2 2803
96a72ee9
GM
28042012-03-02 Glenn Morris <rgm@gnu.org>
2805
2806 * buffer.c (buffer-list-update-hook): Doc fix.
2807
312508d7
EZ
28082012-02-29 Eli Zaretskii <eliz@gnu.org>
2809
2810 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2811 push_it before setting up the iterator for the first overlay
2812 string, even if we have an empty string loaded.
2813 (next_overlay_string): If there's an empty string on the iterator
2814 stack, pop the stack. (Bug#10903)
2815
27f3c637
PE
28162012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2817
2818 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2819 Suggested by Stefan Monnier in
2820 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2821 * alloc.c (widen_to_Lisp_Object): New static function.
2822 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2823 and widening them to Lisp_Objects. This would work even if
2824 USE_LSB_TAG is defined and wide integers are used, which might
2825 happen in a future version of Emacs.
2826
3c9dfce6
CY
28272012-02-25 Chong Yidong <cyd@gnu.org>
2828
fa74b241
CY
2829 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2830 Doc fix.
2831
3c9dfce6
CY
2832 * xselect.c (Fx_selection_exists_p): Doc fix.
2833 (x_clipboard_manager_save_all): Print an informative message
2834 before saving to clipboard manager.
2835
9486df08
CY
28362012-02-24 Chong Yidong <cyd@gnu.org>
2837
2838 * keyboard.c (process_special_events): Handle all X selection
2839 requests in kbd_buffer, not just the next one (Bug#8869).
2840
f01d3321
CY
28412012-02-23 Chong Yidong <cyd@gnu.org>
2842
2843 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2844 call when setting menu-bar-lines and tool-bar-lines parameters.
2845 (unwind_create_frame_1): New helper function.
2846
2847 * window.c (inhibit_window_configuration_change_hook): New var.
2848 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2849 (syms_of_window): Initialize it.
f01d3321 2850
86b847b6
CY
28512012-02-22 Chong Yidong <cyd@gnu.org>
2852
2853 * xterm.c (x_draw_image_relief): Add missing type check for
2854 Vtool_bar_button_margin (Bug#10743).
2855
a59225b1
CY
28562012-02-21 Chong Yidong <cyd@gnu.org>
2857
2858 * fileio.c (Vfile_name_handler_alist): Doc fix.
2859
2860 * buffer.c (Fget_file_buffer): Protect against invalid file
2861 handler return value.
2862
310f5bd4
PE
28632012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2864
cb3a28cc
PE
2865 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2866 when computing $valmask.
2867
310f5bd4
PE
2868 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2869 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2870 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2871 It's useless in that case, and it can cause problems on hosts
2872 that allocate halves of EMACS_INT values separately.
2873 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2874 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2875 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2876 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2877 it avoids undefined behavior on hosts where shifting right by more
2878 than the word width has undefined behavior.
2879
2375c96a
CY
28802012-02-19 Chong Yidong <cyd@gnu.org>
2881
2882 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2883 (Funhandled_file_name_directory, Ffile_name_as_directory)
2884 (Fdirectory_file_name, Fexpand_file_name)
2885 (Fsubstitute_in_file_name): Protect against invalid file handler
2886 return values (Bug#10845).
2887
3eb49e71
EZ
28882012-02-18 Eli Zaretskii <eliz@gnu.org>
2889
2890 * .gdbinit (pitx): Fix incorrect references to fields of the
2891 iterator stack.
2892
7b926f3f
CY
28932012-02-17 Chong Yidong <cyd@gnu.org>
2894
2895 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2896
11273115
PE
28972012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2900 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2901
c3a70e2b
CY
29022012-02-15 Chong Yidong <cyd@gnu.org>
2903
2904 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2905 marked as special. Also, starting docstrings with * is obsolete.
2906
0ca43699
AS
29072012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2908
2909 * gnutls.c (emacs_gnutls_write): Fix last change.
2910
2e8f3c56
LI
29112012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2912
2913 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2914 send_process.
2915
af70074f
SM
29162012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2917
2918 * keymap.c (Fsingle_key_description): Handle char ranges.
2919
95986d52
CY
29202012-02-12 Chong Yidong <cyd@gnu.org>
2921
afd83bd1
CY
2922 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2923 as that creates a dangerous corner case.
2924
95986d52
CY
2925 * window.c (Fdelete_window_internal): Invalidate the mouse
2926 highlight (Bug#9904).
2927
bd7da63e
GM
29282012-02-12 Glenn Morris <rgm@gnu.org>
2929
2930 * xselect.c (Fx_own_selection_internal)
2931 (Fx_get_selection_internal, Fx_disown_selection_internal)
2932 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2933 * nsselect.m (Fx_own_selection_internal)
2934 (Fx_disown_selection_internal, Fx_selection_exists_p)
2935 (Fx_selection_owner_p, Fx_get_selection_internal):
2936 Sync docs and argument specs with the xselect.c versions.
2937
77abcbc2
LI
29382012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2939
2940 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2941
90b671e2
EZ
29422012-02-11 Eli Zaretskii <eliz@gnu.org>
2943
1c0ca0b7
EZ
2944 * w32select.c (Fx_selection_exists_p): Sync doc string and
2945 argument list with xselect.c. (Bug#10783)
2946
2947 * w16select.c (Fx_selection_exists_p): Sync doc string and
2948 argument list with xselect.c. (Bug#10783)
90b671e2 2949
49241268
GM
29502012-02-10 Glenn Morris <rgm@gnu.org>
2951
2952 * fns.c (Fsecure_hash): Doc fix.
2953
f998bbe7 29542012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2955
2956 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2957
0992bd9c
CY
29582012-02-07 Chong Yidong <cyd@gnu.org>
2959
2960 * buffer.c (Fbuffer_local_variables)
2961 (buffer_lisp_local_variables): Handle unbound vars correctly;
2962 don't let Qunbound leak into Lisp.
2963
af008560
GM
29642012-02-07 Glenn Morris <rgm@gnu.org>
2965
dd605cc4
GM
2966 * image.c (Fimagemagick_types): Doc fix.
2967
af008560
GM
2968 * image.c (imagemagick-render-type): Change it from a lisp object
2969 to an integer. Move the doc here from the lisp manual.
2970 Treat all values not equal to 0 the same.
2971
1449fa1d
CY
29722012-02-06 Chong Yidong <cyd@gnu.org>
2973
2974 * doc.c (store_function_docstring): Avoid applying docstring of
2975 alias to base function (Bug#2603).
2976
3723ec07
AS
29772012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2978
2979 * .gdbinit (pp1, pv1): Remove redundant defines.
2980 (pr): Use pp.
2981
79c1cc1e
CY
29822012-02-04 Chong Yidong <cyd@gnu.org>
2983
2984 * nsterm.m: Declare a global (Bug#10694).
2985
d7f29f8e
EZ
29862012-02-04 Eli Zaretskii <eliz@gnu.org>
2987
cae07000
SM
2988 * w32.c (get_emacs_configuration_options):
2989 Include --enable-checking, if specified, in the return value.
d7f29f8e 2990
3b95a6f9
MR
29912012-02-04 Martin Rudalics <rudalics@gmx.at>
2992
2993 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2994 after rounding frame sizes. (Bug#9723)
2995
d6fa96a6
EZ
29962012-02-04 Eli Zaretskii <eliz@gnu.org>
2997
2998 * keyboard.c (adjust_point_for_property): Don't position point
2999 before BEGV. (Bug#10696)
3000
df0b2940
PE
30012012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 Handle overflow when computing char display width (Bug#9496).
3004 * character.c (char_width): Return EMACS_INT, not int.
3005 (char_width, c_string_width): Check for overflow when
3006 computing the width; this is possible now that individual
3007 characters can have unbounded width. Problem introduced
3008 by merge from Emacs 23 on 2012-01-19.
3009
6bee44d6
MA
30102012-02-02 Michael Albinus <michael.albinus@gmx.de>
3011
3012 * dbusbind.c (Fdbus_register_method): Mention the return value
3013 :ignore in the docstring.
3014
44f92739
GM
30152012-02-02 Glenn Morris <rgm@gnu.org>
3016
1b9f60cc
GM
3017 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3018
44f92739
GM
3019 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3020 Unconditionally set to t. (Bug#10673)
3021 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3022 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3023 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3024
c5d3843c
KH
30252012-02-02 Kenichi Handa <handa@m17n.org>
3026
3027 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3028 0, do not call append_composite_glyph.
3029
159462d4 30302012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3031
3032 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3033 NULL (Bug#6988).
3034 (x_produce_glyphs): If the component of a composition is a null
3035 string, set it->pixel_width to 1 to avoid zero-width glyph.
3036
78cef877
EZ
30372012-02-01 Eli Zaretskii <eliz@gnu.org>
3038
3039 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3040 first 2 arguments are identical. This makes inserting large
3041 output from a subprocess an order of magnitude faster on
3042 MS-Windows, where all sbrk'ed memory is always contiguous.
3043
97897668
GM
30442012-01-31 Glenn Morris <rgm@gnu.org>
3045
3046 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3047 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3048 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3049
31fd3586
GM
30502012-01-29 Glenn Morris <rgm@gnu.org>
3051
3052 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3053
0e24a8b2
CY
30542012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3055
3056 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3057
cc0adcb0
CY
30582012-01-28 Chong Yidong <cyd@gnu.org>
3059
3060 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3061
acc28cb9
CY
30622012-01-26 Chong Yidong <cyd@gnu.org>
3063
9c69cfb7
CY
3064 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3065
acc28cb9
CY
3066 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3067 repeat counts (Bug#10507).
3068
48da7392
GM
30692012-01-26 Glenn Morris <rgm@gnu.org>
3070
3071 * lread.c (syms_of_lread): Doc fix.
3072
14af5f7f
CY
30732012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3074
3075 * coding.c (encode_designation_at_bol): Change return value to
3076 EMACS_INT.
3077
0b21c100
CY
30782012-01-25 Chong Yidong <cyd@gnu.org>
3079
3080 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3081
3c2907f7
CY
30822012-01-21 Chong Yidong <cyd@gnu.org>
3083
3084 * floatfns.c (Fcopysign): Make the second argument non-optional,
3085 since nil is not allowed anyway.
3086
959ad23f
AS
30872012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3088
3089 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3090 (send_process): Likewise.
3091
34a02f46
MR
30922012-01-19 Martin Rudalics <rudalics@gmx.at>
3093
3094 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3095 (Vwindow_persistent_parameters): Do not use Qstate.
3096 Rewrite doc-strings.
34a02f46 3097
1259009a 30982012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3099
3100 * character.c (char_width): New function.
70d4fdf6
GM
3101 (Fchar_width, c_string_width, lisp_string_width):
3102 Use char_width (Bug#9496).
25ed9e61 3103
6a6ee00d
MR
31042012-01-16 Martin Rudalics <rudalics@gmx.at>
3105
3106 * window.c (Vwindow_persistent_parameters): New variable.
3107 (Fset_window_configuration, save_window_save): Handle persistent
3108 window parameters.
3109
c85efaf7
EZ
31102012-01-14 Eli Zaretskii <eliz@gnu.org>
3111
3112 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3113 thrashing the stack of the thread. (Bug#9087)
3114
5944709e
PE
31152012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3118
e71f5d99
EZ
31192012-01-11 Eli Zaretskii <eliz@gnu.org>
3120
3121 * xdisp.c (rows_from_pos_range): Handle the case where the
3122 highlight ends on a newline. (Bug#10464)
3123 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3124 he end column for display of highlight that ends on a newline
3125 before a R2L line.
3126
ce316182
GM
31272012-01-11 Glenn Morris <rgm@gnu.org>
3128
3129 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3130 from load-path also when installation-directory is nil. (Bug#10208)
3131
5b43da69
GM
31322012-01-10 Glenn Morris <rgm@gnu.org>
3133
74cc8ff9
GM
3134 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3135
7d8d6e4e
GM
3136 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3137 Update template values to be closer to their typical values these days.
5b43da69 3138
a0db8d43
EZ
31392012-01-09 Eli Zaretskii <eliz@gnu.org>
3140
3141 * xdisp.c (rows_from_pos_range): Accept additional argument
3142 DISP_STRING, and accept any glyph in a row whose object is that
3143 string as eligible for mouse highlight. Fixes mouse highlight of
3144 display strings from overlays. (Bug#10464)
3145
9a0115ab 31462012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3147
b9110d6a 3148 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3149 * fileio.c (auto_saving_dir_umask): New static var.
3150 (Fmake_directory_internal): Use it.
3151 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3152 creating the directory. The old code temporarily assigns
3153 too-generous permissions to the directory.
3154 (do_auto_save_eh): Clear it.
b9110d6a 3155 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3156 that the var is always cleared.
3157
6c1bd3f3
EZ
31582012-01-07 Eli Zaretskii <eliz@gnu.org>
3159
3160 * search.c (scan_buffer): Pass character positions to
3161 know_region_cache, not byte positions. (Bug#6540)
3162
069d2b50
L
31632012-01-07 LynX <_LynX@bk.ru> (tiny change)
3164
3165 * w32.c (sys_rename): Report EXDEV when rename of a directory
3166 fails because the target is on another logical disk. (Bug#10284)
3167
75bf0d33
DB
31682012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3169
3170 * xterm.c (x_embed_request_focus): New function.
3171
3172 * xterm.h: Add prototype.
3173
3174 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3175
1c6e5a32
GM
31762012-01-05 Glenn Morris <rgm@gnu.org>
3177
3178 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3179
651e947e
EZ
31802012-01-01 Eli Zaretskii <eliz@gnu.org>
3181
3182 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3183 Load gnutls_transport_set_lowat only if GnuTLS version is below
3184 2.11.1.
3185 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3186 GnuTLS versions below 2.11.1.
3187
3778cdd8
AL
31882011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3189
3190 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3191 to the doc string advising against its use for altering the way
3192 windows are scrolled.
3193
0e5317f7
KH
31942011-12-28 Kenichi Handa <handa@m17n.org>
3195
3196 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3197 coding-system ASCII compatible only when it does not produce BOM
3198 on encoding (Bug#10383).
3199
93d5ca1f
JD
32002011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3201
3202 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3203 can scroll.
3204 (create_and_show_popup_menu): Always use menu_position_func for
3205 Gtk3 (Bug#10361).
3206
ca22b785
AS
32072011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3208
3209 * callint.c (Fcall_interactively): Don't truncate prompt string.
3210
d048e1e6
EZ
32112011-12-23 Eli Zaretskii <eliz@gnu.org>
3212
3213 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3214 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3215 resumed from there (after widening). (Bug#10360)
d048e1e6 3216
5ccaba1f
JD
32172011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3218
3219 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3220
204ee57f
JD
32212011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3222
b81d40f0
JB
3223 * nsterm.m (x_free_frame_resources):
3224 Release f->output_data.ns->miniimage.
204ee57f
JD
3225 (ns_index_color): Fix indentation. Do not retain
3226 color_table->colors[i].
3227
3228 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3229 before returning.
3230
3231 * nsfns.m (x_set_background_color): Assign return value from
3232 ns_index_color to face-background instead of NSColor*.
3233 (ns_implicitly_set_icon_type): Fix indentation.
3234 Change assignment in for loop to comparison.
3235
3236 * emacs.c (ns_pool): New variable.
3237 (main): Assign ns_pool.
3238 (Fkill_emacs): Call ns_release_autorelease_pool.
3239
3240 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3241 autorelease fdesc, release fdAttrs and tdict.
3242 (ns_get_covering_families): Release charset.
3243 (ns_findfonts): Release NSFontDescriptor created with new.
3244 (ns_uni_to_glyphs): Fix indentation.
3245 (setString): Release attrStr before assigning new value.
3246
c803b2b7
JD
32472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3248
678f4426
JD
3249 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3250 and NS_IMPL_COCOA.
3251 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3252 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3253
cd394be1 32542011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3255
5fecd5fc
JD
3256 * nsterm.m (ns_term_init): Subscribe for notifications
3257 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3258 to method trackingNotification in EmacsMenu.
3259
3260 * nsmenu.m (trackingMenu): New variable.
3771cb17 3261 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3262 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3263 from Aquamacs (Bug#7030).
678f4426
JD
3264
32652011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3266
c803b2b7
JD
3267 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3268 (symbol_to_nsstring): Fix indentation.
3269 (ns_symbol_to_pb): New function.
cae07000
SM
3270 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3271 (Fns_rotate_cut_buffers_internal): Remove.
3272 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3273 Fns_store_cut_buffer_internal.
3274 (ns_get_foreign_selection, Fx_own_selection_internal)
3275 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3276 (Fns_get_selection_internal, Fns_store_selection_internal):
3277 Use ns_symbol_to_pb and check if return value is nil.
3278 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3279 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3280 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3281 renamed to Sns_store_selection_internal.
3282 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3283 and remove this function.
3284 (ns_handle_selection_clear): Remove, never used.
3285 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3286 here.
3287
e1b01a3a
KB
32882011-12-17 Ken Brown <kbrown@cornell.edu>
3289
3290 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3291 GID is unknown (Bug#10257).
3292
2adb6e85
PE
32932011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3294
3295 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3296 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3297 which caused a build failure on GNU/Linux IA-64. This problem was
3298 introduced by my 2011-10-07 patch.
3299
d1d7b339
JL
33002011-12-15 Juri Linkov <juri@jurta.org>
3301
3302 * image.c (imagemagick_error): New function. (Bug#10112)
3303 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3304 Use `imagemagick_error' where ImageMagick functions return
3305 `MagickFalse'.
3306 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3307 proper order.
3308
100d5755
KH
33092011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3310
3311 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3312 fill background (Bug#8992).
3313
454592a6
MR
33142011-12-13 Martin Rudalics <rudalics@gmx.at>
3315
3316 * window.c (Vwindow_combination_resize)
3317 (Vwindow_combination_limit): Use t instead of non-nil in
3318 doc-strings.
61d4b438
MR
3319 (Vrecenter_redisplay): Add first sentence of doc-string on
3320 separate line.
53524d93 3321 (Frecenter): Fix doc-string typo.
454592a6 3322
3633e3aa
KH
33232011-12-11 Kenichi Handa <handa@m17n.org>
3324
3325 * coding.c (Funencodable_char_position): Pay attention to the
3326 buffer text relocation (Bug#9389).
3327
7b9d523a 33282011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3329
7b9d523a
JD
3330 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3331 gtk_init (Bug#10100).
3332
b73189c6
EZ
33332011-12-10 Eli Zaretskii <eliz@gnu.org>
3334
3335 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3336 IT->string is nil. (Bug#10263)
3337
f7dfe5d6
JD
33382011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3339
83faebb4
JD
3340 * nsterm.h (x_free_frame_resources): Declare.
3341
f7dfe5d6
JD
3342 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3343 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3344
3345 * nsterm.h (ns_get_defaults_value): Declare.
3346
3347 * nsterm.m (ns_default): Call ns_get_defaults_value.
3348
7cd4e72c
EZ
33492011-12-09 Eli Zaretskii <eliz@gnu.org>
3350
3351 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3352 (Bug#10170)
3353
b34d7317
YM
33542011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3355
3356 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3357 that where the value of an _OBJC_* symbol points to is in the .bss
3358 section (Bug#10240).
3359
76470ad1
KH
33602011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3361
3362 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3363 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3364
745fff94
KH
33652011-12-08 Kenichi Handa <handa@m17n.org>
3366
3367 * ftfont.c (get_adstyle_property): Fix previous change
3368 (Bug#10233).
3369
6e44397c
JB
33702011-12-07 Juanma Barranquero <lekktu@gmail.com>
3371
3372 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3373 dirs from the default value of EMACSLOADPATH (bug#10208).
3374
7efa6272
GM
33752011-12-07 Glenn Morris <rgm@gnu.org>
3376
3377 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3378 installation and source directories as well. (Bug#10208)
3379
f6fc4d87
CY
33802011-12-06 Chong Yidong <cyd@gnu.org>
3381
3382 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3383
2bf26180
GM
33842011-12-06 Glenn Morris <rgm@gnu.org>
3385
3386 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3387 as an error, not just -1. (Bug#10217)
3388
3a6ad4f0
CY
33892011-12-05 Chong Yidong <cyd@gnu.org>
3390
3391 * keyboard.c (process_special_events): New function.
3392 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3393
75a3b399
PE
33942011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3395
3396 * coding.c (encode_designation_at_bol): Don't use uninitialized
3397 local variable (Bug#9318).
3398
c3c9e25e
KH
33992011-12-05 Kenichi Handa <handa@m17n.org>
3400
3401 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3402 return Qnil (Bug#8046, Bug#10193).
3403
5eb05ea3
KH
34042011-12-05 Kenichi Handa <handa@m17n.org>
3405
3406 * coding.c (encode_designation_at_bol): New args charbuf_end and
3407 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3408 (coding_set_source): Return how many bytes coding->source was
3409 relocated.
3410 (coding_set_destination): Return how many bytes
3411 coding->destination was relocated.
3412 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3413 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3414
34152011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3416
3417 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3418 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3419 macro (Bug#9318).
3420
34212011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3422
3423 The following changes are to fix Bug#9318.
3424
a79703f5 3425 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3426 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3427 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3428 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3429
7dbda6df
JB
34302011-12-05 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * lisp.h (process_quit_flag): Fix external declaration.
3433
6d5eb5b0
SM
34342011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3435
3436 Don't macro-inline non-performance-critical code.
3437 * eval.c (process_quit_flag): New function.
3438 * lisp.h (QUIT): Use it.
3439
a0c3fad0
JD
34402011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3441
3442 * nsfns.m (get_geometry_from_preferences): New function.
3443 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3444
6c07aac2
AS
34452011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3446
3447 * emacs.c (Qkill_emacs): Define.
3448 (syms_of_emacs): Initialize it.
3449 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3450 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3451 (quit_throw_to_read_char): Add parameter `from_signal'.
3452 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3453 * lisp.h (QUIT): Call Fkill_emacs if requested.
3454
c052ead4
JD
34552011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3456
3457 * widget.c (update_wm_hints): Return if wmshell is null.
3458 (widget_update_wm_size_hints): New function.
3459
3460 * widget.h (widget_update_wm_size_hints): Declare.
3461
3462 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3463 widget_update_wm_size_hints (Bug#10104).
3464
9e49252b
EZ
34652011-12-03 Eli Zaretskii <eliz@gnu.org>
3466
3467 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3468 before a newline, prepare the bidi iterator for consuming the
3469 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3470 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3471
02b16839
JL
34722011-12-02 Juri Linkov <juri@jurta.org>
3473
3474 * search.c (Fword_search_regexp): New Lisp function created from
3475 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3476 (Fword_search_backward, Fword_search_forward)
3477 (Fword_search_backward_lax, Fword_search_forward_lax):
3478 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3479 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3480
0068070e
SM
34812011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3482
3483 * fileio.c (Finsert_file_contents): Move after-change-function call
3484 to before the "handled:" label, since all "goto handled" appear in
3485 cases where the *-change-functions have already been properly called
3486 (bug#10117).
3487
3360a3fc
AS
34882011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3489
3490 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3491 waiting for input. (Bug#10169)
3492
73d6c093
EZ
34932011-11-30 Eli Zaretskii <eliz@gnu.org>
3494
3495 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3496 verifies glyph row's hash code--we have just reallocated the
3497 glyphs, so their contents can be complete garbage. (Bug#10164)
3498
febe6bea
JB
34992011-11-30 Juanma Barranquero <lekktu@gmail.com>
3500
3501 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3502
801a4313
EZ
35032011-11-30 Eli Zaretskii <eliz@gnu.org>
3504
3505 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3506 attributes are tested _before_ calling verify_row_hash, to protect
3507 against GCC re-ordering of the tests. (Bug#10164)
3508
2b56b87e
JD
35092011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3510
3511 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3512
3513 * xterm.c (handle_one_xevent): Only set async_visible and friends
3514 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3515 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3516 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3517
dbf31225
PE
35182011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3519
3520 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3521 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3522 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3523 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3524 All uses changed to use GCPRO1 etc.
3525 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3526 Revert to old implementation (i.e., before 2011-03-11).
3527
1305621b
YM
35282011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3529
3530 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3531 of scroll runs so as to avoid assigning disabled bogus rows and
3532 unnecessary graphics copy operations.
3533
8c9afb46
EZ
35342011-11-27 Eli Zaretskii <eliz@gnu.org>
3535
3536 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3537 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3538 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3539 (malloc, free, realloc, calloc): Redirect to e_* only when
3540 compiling Emacs.
3541
3542 * lisp.h (GCTYPEBITS): Move before first use.
3543 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3544 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3545 this macro definition.
3546
3547 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3548 _MSC_VER.
3549
54e9e3bf
JD
35502011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3551
6d5eb5b0
SM
3552 * gtkutil.c (xg_create_frame_widgets):
3553 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3554 present with Gtk+ 2.0.
3555
83aca1cb
PE
35562011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 * fileio.c (Finsert_file_contents): Undo previous change; see
3559 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3560
5b76caa4
PE
35612011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3562
3563 Rename locals to avoid shadowing.
3564 * fileio.c (Finsert_file_contents):
3565 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3566 * process.c (wait_reading_process_output):
3567 Rename inner 'proc' to 'p' to avoid shadowing.
3568 Indent for consistency with usual Emacs style.
3569
8c535114
EZ
35702011-11-25 Eli Zaretskii <eliz@gnu.org>
3571
3572 * xdisp.c (redisplay_window): If cursor row is not fully visible
3573 after recentering, and scroll-conservatively is set to a large
3574 number, scroll window by a few more lines to make the cursor fully
3575 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3576 (start_display): Don't move to the next line if the display should
3577 start at a newline that is part of a display vector or an overlay
3578 string. (Bug#10119)
8c535114 3579
fa4fdb5c
JL
35802011-11-24 Juri Linkov <juri@jurta.org>
3581
3582 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3583 after the `MagickPingImage' call. (Bug#10112)
3584
90ec88df
CY
35852011-11-23 Chong Yidong <cyd@gnu.org>
3586
3587 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3588
56e2e794
MR
35892011-11-23 Martin Rudalics <rudalics@gmx.at>
3590
3591 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3592 making another buffer current. (Bug#10114)
3593
b6e64c41
GM
35942011-11-23 Glenn Morris <rgm@gnu.org>
3595
3596 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3597
6b21de18
CY
35982011-11-23 Chong Yidong <cyd@gnu.org>
3599
3600 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3601 using it (Bug#5984).
3602
b12cd789
EZ
36032011-11-22 Eli Zaretskii <eliz@gnu.org>
3604
3605 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3606 and header-lines, as they don't have one computed for them.
3607 (Bug#10098)
3608
3609 * .gdbinit (prow): Make displayed values more self-explaining.
3610 Add row's hash code.
3611
261b6fd4
LMI
36122011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3613
3614 * process.c (wait_reading_process_output): Fix asynchrounous
3615 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3616 (wait_reading_process_output): Add comment and URL.
261b6fd4 3617
e7cfd277
JD
36182011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3619
3620 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3621
a9b9b7f5
CY
36222011-11-21 Chong Yidong <cyd@gnu.org>
3623
3624 * window.c (Fnext_window, Fprevious_window): Doc fix.
3625
b0d15b4f
SM
36262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3627
3628 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3629
fe7a3057
JB
36302011-11-20 Juanma Barranquero <lekktu@gmail.com>
3631
3632 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3633
d2999b1a
MR
36342011-11-20 Martin Rudalics <rudalics@gmx.at>
3635
3636 * window.c (Fset_window_combination_limit): Rename argument
3637 STATUS to LIMIT.
3638 (Vwindow_combination_limit): Remove "status" from doc-string.
3639
d5ff9cd0
AS
36402011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3641
3642 * m/ibms390.h: Remove.
3643 * m/ibms390x.h: Don't include "ibms390.h".
3644
a5bb9bd3
SM
36452011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3646
3647 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3648 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3649
cd1181db
JB
36502011-11-20 Juanma Barranquero <lekktu@gmail.com>
3651
3652 * casetab.c (Fset_case_table):
3653 * charset.c (Fcharset_after): Fix typos.
3654
615a3b8d 36552011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3656
17e845af
PE
3657 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3658 Otherwise, valgrind does not work on some platforms.
3659 Problem reported by Andreas Schwab in
6a0bf43d
PE
3660 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3661 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3662 is set, removing the need for VIRT_ADDRESS_VARIES.
3663 (PURE_P): Use a more-efficient implementation that needs just one
3664 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3665 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3666 to 4 (xorl, subq, cmpq, setbe).
3667 * alloc.c (pure): Always extern now, since that's the
3668 VIRT_ADDR_VARIES behavior.
3669 (PURE_POINTER_P): Use a single comparison, not two, for
3670 consistency with the new puresize.h.
3671 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3672 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3673 Remove VIRT_ADDR_VARIES no longer needed.
3674
f8fe6f96
EZ
36752011-11-19 Eli Zaretskii <eliz@gnu.org>
3676
3677 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3678 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3679 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3680 behave as if the cursor position were at the window margin.
3681
3682 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3683 and the cursor position is out of bounds, behave as if the cursor
3684 position were at the window margin. (Bug#10075)
3685
df05a53c
CY
36862011-11-18 Chong Yidong <cyd@gnu.org>
3687
3688 * window.c (Fwindow_combination_limit): Make first argument
3689 non-optional, since it is meaningless for live windows like the
3690 selected window.
61ccba97 3691
2071918e
DA
36922011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3693
3694 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3695
b50a28de
SM
36962011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3697
3698 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3699 (graft_intervals_into_buffer): Simplify.
3700
015137db
EZ
37012011-11-18 Eli Zaretskii <eliz@gnu.org>
3702
3703 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3704 hash values of the two rows.
3705 (copy_row_except_pointers): Preserve the used[] arrays and the
3706 hash values of the two rows. (Bug#10035)
68c95424 3707 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3708
3709 * xdisp.c (row_hash): New function, body extracted from
3710 compute_line_metrics.
3711 (compute_line_metrics): Call row_hash, instead of computing the
3712 hash code inline.
3713
3714 * dispnew.c (verify_row_hash): Call row_hash for computing the
3715 hash code of a row, instead of duplicating code from xdisp.c.
3716
3717 * dispextern.h (row_hash): Add prototype.
3718
a2addb04
TH
37192011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3720
3721 * frame.c (delete_frame): Don't delete the terminal when the last
3722 X frame is closed if emacs is built with GTK toolkit.
3723
df85d315
JB
37242011-11-17 Juanma Barranquero <lekktu@gmail.com>
3725
3726 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3727
a0c2d0ae
MR
37282011-11-17 Martin Rudalics <rudalics@gmx.at>
3729
3730 * window.c (Vwindow_splits): Rename to
3731 Vwindow_combination_resize. Suggested by Juri Linkov.
3732 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3733 of Vwindow_splits.
3734
58179cce
JB
37352011-11-16 Juanma Barranquero <lekktu@gmail.com>
3736
7877f373
JB
3737 * nsfns.m (Fns_font_name):
3738 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3739
b6f67890
MR
37402011-11-16 Martin Rudalics <rudalics@gmx.at>
3741
3742 * window.h (window): Rename slot "nest" to "combination_limit".
3743 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3744 (Fset_window_nest): Rename to Fset_window_combination_limit.
3745 (Vwindow_nest): Rename to Vwindow_combination_limit.
3746 (recombine_windows, make_parent_window, make_window)
3747 (Fsplit_window_internal, saved_window)
3748 (Fset_window_configuration, save_window_save): Rename all
3749 occurrences of window_nest to window_combination_limit.
3750
c7015153
JB
37512011-11-15 Juanma Barranquero <lekktu@gmail.com>
3752
3753 * image.c (imagemagick_load_image): Fix typo.
3754
322ad6ec
EZ
37552011-11-14 Eli Zaretskii <eliz@gnu.org>
3756
3757 * xdisp.c (display_line): Move the call to
3758 highlight_trailing_whitespace before the call to
3759 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3760 faces of all the glyphs to compute ROW's hash value.
3761 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3762
f067b8ec
JB
37632011-11-14 Juanma Barranquero <lekktu@gmail.com>
3764
3765 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3766 just return (bug#10044).
3767
1e5b2111
EZ
37682011-11-12 Eli Zaretskii <eliz@gnu.org>
3769
7ef3cbd5
EZ
3770 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3771 with user-defined heap size. Bump the default size of the temacs
3772 heap to 27MB, to avoid memory warning when running temacs.
3773 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3774
1e5b2111
EZ
3775 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3776 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3777 (verify_row_hash) [XASSERTS]: New function.
3778 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3779 that the hash value of glyph rows is correct.
1e5b2111 3780
89d61221
MR
37812011-11-12 Martin Rudalics <rudalics@gmx.at>
3782
3783 * window.h (window): Remove splits slot.
3784 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3785 (Fdelete_other_windows_internal, make_parent_window)
3786 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3787 (Fset_window_configuration, save_window_save): Don't deal with
3788 split status of windows.
3789 (saved_window): Remove splits slot.
3790 (Vwindow_splits): Rewrite doc-string.
3791
97f18cc8
JD
37922011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3793
3794 * xfns.c (unwind_create_frame):
3795 * nsfns.m (unwind_create_frame):
3796 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3797 Vframe_list (Bug#9999).
3798
22a648b4
DA
37992011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3800
0b381c7e 3801 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3802
659afede
KH
38032011-11-11 Kenichi Handa <handa@m17n.org>
3804
3805 * callproc.c (Fcall_process): Set the member dst_multibyte of
3806 process_coding.
3807
9ac0394b
KH
38082011-11-11 Johan Bockgård <bojohan@gnu.org>
3809
3810 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3811 avoid a crash (bug#9496).
3812
2fbdc249
CY
38132011-11-09 Chong Yidong <cyd@gnu.org>
3814
3815 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3816 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3817
ac6b1f81
PE
38182011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3819
3820 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3821
09db192c
PE
38222011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3823
3824 Avoid some portability problems by eschewing 'extern inline' functions.
3825 The trivial performance wins aren't worth the portability hassles; see
3826 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3827 et seq.
3828 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3829 (window_box_width, window_box_left, window_box_left_offset)
3830 (window_box_right, window_box_right_offset): Undo previous change,
3831 by removing the "extern"s.
3832 * intervals.c (adjust_intervals_for_insertion)
3833 (adjust_intervals_for_deletion): Undo previous change,
3834 making these static again.
3835 (offset_intervals, temp_set_point_both, temp_set_point)
3836 (copy_intervals_to_string): No longer inline.
3837 * xdisp.c (window_text_bottom_y, window_box_width)
3838 (window_box_height, window_box_left_offset)
3839 (window_box_right_offset, window_box_left, window_box_right)
3840 (window_box): No longer inline.
3841
105216ed
CY
38422011-11-08 Chong Yidong <cyd@gnu.org>
3843
3844 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3845 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3846 Signal an error if not a live window.
105216ed
CY
3847 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3848 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3849
ae9e237f
JB
38502011-11-07 Juanma Barranquero <lekktu@gmail.com>
3851
3852 * lisp.h (syms_of_abbrev): Remove declaration.
3853 Reported by CHENG Gao <chenggao@royau.me>.
3854
c7aa8333
EZ
38552011-11-07 Eli Zaretskii <eliz@gnu.org>
3856
3857 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3858 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3859 of temacs in GUI mode.
3860
be7f5545
MR
38612011-11-07 Martin Rudalics <rudalics@gmx.at>
3862
3863 * window.h: Declare delete_all_child_windows instead of
3864 delete_all_subwindows.
3865 * window.c (Fwindow_nest, Fset_window_nest)
3866 (Fset_window_new_total, Fset_window_new_normal)
3867 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3868 (delete_all_subwindows): Rename to delete_all_child_windows.
3869 (Fdelete_other_windows_internal, Fset_window_configuration):
3870 Call delete_all_child_windows instead of delete_all_subwindows.
3871 * frame.c (delete_frame): Call delete_all_child_windows instead
3872 of delete_all_subwindows.
3873
ca78dc43
PE
38742011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3877 This is also needed for porting to any host where GC_MARK_STACK is
3878 not GC_MAKE_GCPROS_NOOPS.
3879 (which_symbols): Use it.
3880
a0241d01
KH
38812011-11-07 Kenichi Handa <handa@m17n.org>
3882
3883 * coding.c (coding_set_destination): Check coding->src_pos only
3884 when coding->src_object is a buffer (bug#9910).
3885
3886 * process.c (send_process): Set the member src_multibyte of coding
3887 to 0 (bug#9911) when sending a unibyte text.
3888
3889 * callproc.c (Fcall_process): Set the member src_multibyte of
3890 process_coding to 0 (bug#9912).
3891
a64bfdfa 38922011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3893
3894 * xmenu.c (cleanup_widget_value_tree): New function.
3895 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3896 calling free_menubar_widget_value_tree directly (Bug#9830).
3897
cb41b32a
PE
38982011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 Fix some portability problems with 'inline'.
3901 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3902 (window_box_width, window_box_left, window_box_left_offset)
3903 (window_box_right, window_box_right_offset): Declare extern.
3904 Otherwise, these inline functions do not conform to C99 and
3905 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3906 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3907 * intervals.c (adjust_intervals_for_insertion)
3908 (adjust_intervals_for_deletion): Now extern, because otherwise the
3909 extern inline functions 'offset_intervals' couldn't refer to it.
3910 (static_offset_intervals): Remove.
3911 (offset_intervals): Rewrite using the old contents of
3912 static_offset_intervals. The old version didn't conform to C99
3913 because an extern inline function contained a reference to an
3914 identifier with static linkage.
3915
b7041366
AS
39162011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3917
3918 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3919 GC.
3920
88a37c4d
EZ
39212011-11-06 Eli Zaretskii <eliz@gnu.org>
3922
3923 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3924 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3925 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3926 return Qleft_to_right.
3927
49745b39
CY
39282011-11-06 Chong Yidong <cyd@gnu.org>
3929
3930 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3931 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3932 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3933 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3934 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3935 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3936 (Fwindow_vscroll): Doc fix.
3937 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3938 argument, since it makes no sense to pass a live window and for
3939 consistency with window-child.
3940
1f05cd82
CS
39412011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3942
3943 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3944 support MSVC.
3945
22610910
JR
39462011-11-05 Jason Rumney <jasonr@gnu.org>
3947
3948 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3949 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3950 fonts (Bug#6029).
3951 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3952 bitwise arithmetic preventing use of unicode-sip and non-truetype
3953 opentype fonts.
3954
a06776b2
EZ
39552011-11-05 Eli Zaretskii <eliz@gnu.org>
3956
3ad924ba
EZ
3957 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3958 "emacs"-only part.
3959
a06776b2
EZ
3960 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3961 initialization code to keep similarity to xfns.c after changes
3962 from 2011-11-05.
3963
c9e7db78
JD
39642011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3965
a97f8f3f
JD
3966 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3967 (unwind_create_frame): New function (Bug#9943).
3968 (Fx_create_frame): Restructure code to be more similar to the one in
3969 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3970 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3971 Move terminal->reference_count++ just before making the frame official
3972 (Bug#9943).
3973
3974 * nsterm.m (x_free_frame_resources): New function.
3975 (x_destroy_window): Move code to x_free_frame_resources.
3976
c9e7db78 3977 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3978 (Fx_create_frame, x_create_tip_frame):
3979 Move terminal->reference_count++ just before making the frame
75f1671a 3980 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3981 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3982
a6fc3b5c
EZ
39832011-11-05 Eli Zaretskii <eliz@gnu.org>
3984
3985 Support MSVC build with newer versions of Visual Studio.
3986 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3987 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3988 nt/gmake.defs.
3989
3990 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3991 which are not supported by MSVC.
3992 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3993 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3994 bitfields.
3995 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3996 types in bitfields.
3997 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3998
3999 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4000
58179cce 40012011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4002
4003 Support MSVC build with newer versions of Visual Studio.
4004 * w32.c: Don't include w32api.h for MSVC.
4005 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4006
4007 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4008 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4009 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4010 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4011 e_* cousins.
4012 (alloca) [_MSC_VER]: Define to _alloca.
4013
4014 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4015
4016 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4017
a58c13ed
EZ
40182011-11-04 Eli Zaretskii <eliz@gnu.org>
4019
4020 * xdisp.c (note_mouse_highlight): If either of
4021 previous/next-single-property-change returns nil, treat that as
4022 the beginning or the end of the buffer. (Bug#9955)
4023
fe0b6370
JD
40242011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4025
a58c13ed 4026 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4027 label is not null (Bug#9951).
4028 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4029 may be NULL.
4030
89bd5ee1
EZ
40312011-11-04 Eli Zaretskii <eliz@gnu.org>
4032
4033 * window.c (Fwindow_body_size): Mention in the doc string that the
4034 return value is in frame's canonical units. (Bug#9949)
4035
84c3edb9
EZ
40362011-11-03 Eli Zaretskii <eliz@gnu.org>
4037
4e2fb5c7
EZ
4038 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4039
84c3edb9 4040 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4041 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4042 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4043
bc17a887
EZ
40442011-11-01 Eli Zaretskii <eliz@gnu.org>
4045
4046 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4047 Don't stop backward scan on the continuation glyph, even though
4048 its CHARPOS is positive.
6d5eb5b0
SM
4049 (mouse_face_from_buffer_pos, note_mouse_highlight):
4050 Rename cover_string to disp_string.
bc17a887 4051
4ee88440
MR
40522011-11-01 Martin Rudalics <rudalics@gmx.at>
4053
4054 * window.c (temp_output_buffer_show): Don't use
4055 Vtemp_buffer_show_specifiers.
4056 (Vtemp_buffer_show_specifiers): Remove unused variable.
4057
c2ff3c02
EZ
40582011-10-30 Eli Zaretskii <eliz@gnu.org>
4059
4060 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4061 past the beginning of the current glyph matrix.
4062
58179cce 40632011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4064
4065 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4066 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4067 HAVE_GTK3 (Bug#9869).
b77a6a7f 4068
3b574623
JD
4069 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4070 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4071
b77a6a7f
JD
4072 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4073
4074 * xterm.c: Declare x_handle_net_wm_state to return int.
4075 (handle_one_xevent): Check if we are iconified but don't have
4076 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4077 (get_current_wm_state): Return non-zero if not hidden,
4078 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4079 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4080 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4081 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4082
196e41e4
PE
40832011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4084
4085 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4086 so that this new function doesn't get optimized away by a
4087 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4088
021f2e1a
AS
40892011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4090
4091 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4092
8b058d44
EZ
40932011-10-29 Eli Zaretskii <eliz@gnu.org>
4094
4095 Fix the `xbytecode' command.
4096 * .gdbinit (xprintbytestr): New command.
b50a28de 4097 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4098 (xbytecode): Print the byte-code string as well.
4099
4452fb80
EZ
41002011-10-29 Kim Storm <storm@cua.dk>
4101
8b058d44
EZ
4102 * alloc.c (which_symbols): New function.
4103
21b72067
AS
41042011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4105
4106 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4107 line. (Bug#9903)
4108
83ed7b5c
GM
41092011-10-29 Glenn Morris <rgm@gnu.org>
4110
4111 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4112 Not clear what it was for, and it causes various bugs. (Bug#9839)
4113
5a7a728b
EZ
41142011-10-28 Eli Zaretskii <eliz@gnu.org>
4115
4116 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4117 possible random value that matches one of those tested as
4118 condition to clear the mouse face.
4119
d3d0842f
CY
41202011-10-28 Chong Yidong <cyd@gnu.org>
4121
4122 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4123
31b39d13
DN
41242011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4125
4126 * window.c (make_window): Initialize phys_cursor_on_p.
4127
9aba6043
SM
41282011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4129
4130 * lisp.h (struct Lisp_Symbol): Update comments.
4131
c20992f4
JB
41322011-10-28 Juanma Barranquero <lekktu@gmail.com>
4133
4134 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4135
db4f02f2
EZ
41362011-10-28 Eli Zaretskii <eliz@gnu.org>
4137
4138 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4139 <oslsachem@gmail.com> for helping to debug this.
4140
4141 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4142 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4143 (g_b_init_get_glyph_outline_w): New static variables.
4144 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4145 (GetGlyphOutlineW_Proc): New typedefs.
4146 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4147 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4148 New functions.
4149 (w32font_open_internal, compute_metrics):
4150 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4151 instead of calling the "wide" APIs directly.
4152
4153 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4154
4155 * w32.h (syms_of_w32font): Add prototype.
4156
87e68db4
JB
41572011-10-27 Juanma Barranquero <lekktu@gmail.com>
4158
4159 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4160 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4161 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4162 (Fmove_to_window_line): Doc fix.
4163
435c1d67
CY
41642011-10-27 Chong Yidong <cyd@gnu.org>
4165
4166 * process.c (make_process): Set gnutls_state to NULL.
4167
4168 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4169 non-NULL, regardless of GNUTLS_INITSTAGE.
4170 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4171 an error. Set process slots as soon as we allocate them.
4172
4173 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4174
9c6c6f49
CY
41752011-10-27 Chong Yidong <cyd@gnu.org>
4176
9aba6043
SM
4177 * gnutls.c (emacs_gnutls_deinit): New function.
4178 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4179 (Fgnutls_deinit, Fgnutls_boot): Use it.
4180
4181 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4182 (deactivate_process): Call emacs_gnutls_deinit.
4183
657d08d3
JB
41842011-10-27 Juanma Barranquero <lekktu@gmail.com>
4185
4186 * image.c (x_create_x_image_and_pixmap):
4187 * w32.c (sys_rename, w32_delayed_load):
4188 * w32font.c (fill_in_logfont):
4189 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4190
5430d399
JB
41912011-10-26 Juanma Barranquero <lekktu@gmail.com>
4192
4193 * w32fns.c (w32_default_color_map): New function,
4194 extracted from Fw32_default_color_map.
a7ef684b 4195 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4196
fe0055fa
PE
41972011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4200
e6346438
SM
42012011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4202
4203 * keyboard.c (test_undefined): New function (bug#9751).
4204 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4205
e112cc37
ET
42062011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4207
4208 * sysdep.c (init_sys_modes): Fix the check for the controlling
4209 terminal (Bug#6649).
4210
7b5d6677
EZ
42112011-10-20 Eli Zaretskii <eliz@gnu.org>
4212
4213 * dispextern.h (struct bidi_it): New member next_en_type.
4214
4215 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4216 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4217 current character, check also for next_en_type being WEAK_EN.
4218 (bidi_resolve_weak): Don't enter the expensive loop if the current
4219 position is before next_en_pos. Record the bidi type of the first
4220 non-ET, non-BN character we find, in addition to its position.
4221 (bidi_level_of_next_char): Invalidate next_en_type when
4222 next_en_pos is over-stepped.
4223
7da0b018
PE
42242011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4225
4226 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4227 * editfns.c: Rewrite current-time-zone so that it invokes
4228 the equivalent of (format-time-string "%Z") to get the time zone name.
4229 This fixes a bug when the time zone name contains characters that
4230 need converting from the system time locale to Emacs internal format.
4231 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4232 that patch fixed format-time-string to do the conversion, but
4233 I forgot to fix current-time-zone.
4234 (format_time_string): New function, containing most of
4235 what Fformat_time_string used to contain.
4236 (Fformat_time_string): Rewrite in terms of format_time_string.
4237 This doesn't change this function's behavior.
4238 (current-time-zone): Rewrite to use format_time_string.
4239 This fixes the bug reported by Michael Schierl in
4240 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4241 Jason Rumney's 2007-06-07 change worked around this bug, but
4242 didn't fix it.
4243 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4244
8547b010
EZ
42452011-10-19 Eli Zaretskii <eliz@gnu.org>
4246
4247 * xdisp.c (start_display): If the character at POS is displayed
4248 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4249 (try_window_reusing_current_matrix): If a line ends in a display
4250 vector or the next line starts in a display vector, continue
4251 redrawing the window even though the character position of
4252 start_row was reached.
8547b010
EZ
4253 (Bug#9771, part 2)
4254
4e948d15
CY
42552011-10-18 Chong Yidong <cyd@gnu.org>
4256
4257 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4258 with nobreak-char-display too.
4259
4787455f
EZ
42602011-10-18 Eli Zaretskii <eliz@gnu.org>
4261
4262 Fix part 3 of bug#9771.
4263 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4264 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4265 non-neutral characters if the current character is a paragraph
4266 separator (a.k.a. Newline). This avoids running the same
4267 expensive loop twice, once when we consume the preceding newline
4268 and the other time when the line actually needs to be displayed.
4269 Avoid the loop when we see neutrals on the base embedding level
4270 following a character whose directionality is the same as the
4271 paragraph's. This avoids running the expensive loop when a line
4272 ends in a long sequence of neutrals, like control characters.
4273 Add assertion against STRONG_AL type. Slightly rearrange code
4274 that determines the type of a neutral given the first non-neutral
4275 that follows it.
4276 (bidi_level_of_next_char): Set next_en_pos to zero when
4277 invalidating its info.
4278
2c91f553
EZ
42792011-10-17 Eli Zaretskii <eliz@gnu.org>
4280
4281 * xdisp.c (push_display_prop): Determine whether to record string
4282 or buffer position by IT->string, not by IT->method. Allow
4283 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4284 (move_it_vertically_backward): Don't look for character position
4285 immediately after the newline when in a continuation line.
4286 (Bug#9771, part 1)
2c91f553 4287
c7b08b0d
MR
42882011-10-15 Martin Rudalics <rudalics@gmx.at>
4289
4290 * window.c (coordinates_in_window): Rewrite and delabelize
4291 vertical border check. (Bug#5357) (Bug#9618)
4292
6b02f655
SM
42932011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4294
4295 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4296 errors in XSetWindowBorder (bug#9310).
4297
81d40c92
DA
42982011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4299
4300 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4301 avoid crash when xmalloc overrun checking is enabled.
4302
d4172c3b
EZ
43032011-10-13 Eli Zaretskii <eliz@gnu.org>
4304
4305 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4306 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4307 cursor motion with <left> and <right> arrow keys.
4308
4309 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4310 some callers set that themselves.
4311
b00eea75
EZ
43122011-10-12 Eli Zaretskii <eliz@gnu.org>
4313
4314 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4315 display string and the previous row comes from the same string and
4316 is empty. (Bug#9739) (Bug#9738)
4317
8fe012c4
SM
43182011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4319
4320 * doc.c (get_doc_string): Encode file name (bug#9735).
4321
0074aef2
EZ
43222011-10-12 Eli Zaretskii <eliz@gnu.org>
4323
79beb178
EZ
4324 * bidi.c (bidi_level_of_next_char):
4325 * xdisp.c (get_visually_first_element): Remove old incorrect
4326 comments regarding the Unicode Line Separator character.
4327
0074aef2
EZ
4328 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4329
6e4b3fbe
DA
43302011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4331
4332 * alloc.c (Fgc_status): Do not access beyond zombies array
4333 boundary if nzombies > MAX_ZOMBIES.
4334 * alloc.c (dump_zombies): Add missing format specifier.
4335
0324f3af
PE
43362011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4337
b5525cac
PE
4338 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4339 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4340
0324f3af
PE
4341 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4342 Some packages use them to denote characters with modifiers.
4343
e9b5f888
AS
43442011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4345
4346 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4347 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4348 matching a pp-number. Rename parameter var to var1.
4349
127827c0
SM
43502011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4351
4352 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4353
c8fd3bd0
GM
43542011-10-08 Glenn Morris <rgm@gnu.org>
4355
4356 * callint.c (Fcall_interactively): Give a more explicit error for the
4357 'c' case with a non-character input. (Bug#8479)
4358
352ec8ff
EZ
43592011-10-08 Eli Zaretskii <eliz@gnu.org>
4360
03669ccb
EZ
4361 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4362 lines.
7061c986
EZ
4363 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4364 lines that are hscrolled on the left.
03669ccb 4365
352ec8ff
EZ
4366 * dispnew.c (buffer_posn_from_coords): Account for a possible
4367 presence of header-line. (Bug#4426)
4368
a66cfb1c
SM
43692011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4370
6b02f655
SM
4371 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4372 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4373
7c5ee88e
PE
43742011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4375
4376 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4377 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4378 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4379 this makes Emacs dump core during garbage collection on rare
4380 occasions. sizeof is obviously inferior to offsetof here, so
4381 stick with offsetof.
4382 (GC_POINTER_ALIGNMENT): New macro.
4383 (mark_memory): Omit 3rd (offset) arg; caller changed.
4384 Don't assume EMACS_INT alignment is the same as pointer alignment.
4385
df1bbe5b
SM
43862011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4387
4388 * keyboard.c (read_key_sequence_remapped): New var.
4389 (read_key_sequence): Compute remapping in the right buffer.
4390 (command_loop_1): Use read_key_sequence's remapping directly.
4391
51553db6
SM
43922011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4393
32c1fffd
SM
4394 * dired.c (file_name_completion): Don't expand file name.
4395 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4396 before checking file name handler.
4397
51553db6
SM
4398 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4399 they've been requested explicitly (bug#9591).
4400
b6bd1599 44012011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4402
4403 * keymap.c (Fsingle_key_description): Use make_specified_string
4404 instead of build_string to build string from push_key_description.
4405 (Bug#5193)
4406
f701dc2a
PE
44072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4408
4222c55d
PE
4409 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4410 This fixes a Y2038 bug on 64-bit hosts.
4411 * buffer.c (reset_buffer):
4412 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4413 (Fclear_buffer_auto_save_failure):
4414 Use 0, not -1, to represent an unset failure time, since time_t
4415 might not be signed.
4416
f701dc2a
PE
4417 Remove dependency on glibc malloc internals.
4418 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4419 Move back here from lisp.h, but with their new implementations.
4420 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4421 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4422 * charset.c (charset_table_init): New static var.
4423 (syms_of_charset): Use it instead of xmalloc. This removes a
4424 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4425 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4426 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4427 Move back to alloc.c.
4428 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4429 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4430
9ceebf39
JD
44312011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4432
4433 * nsterm.m (windowDidResize): Call x_set_window_size only when
4434 ns_in_resize is true. Otherwise set pixelwidth/height and
4435 call change_frame_size (Bug#9628).
4436
cb993c58
PE
44372011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4438
3930c88b
PE
4439 Port --enable-checking=all to Fedora 14 x86-64.
4440 * charset.c (syms_of_charset): Also account for glibc malloc's
4441 internal overhead when calculating the initial malloc maximum.
4442
cb993c58
PE
4443 Port --enable-checking=all to Fedora 14 x86.
4444 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4445 Move to lisp.h.
4446 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4447 (overrun_check_realloc, overrun_check_free):
4448 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4449 That way, xmalloc returns a properly-aligned pointer even if
4450 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4451 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4452 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4453 into account when calculating the initial malloc maximum.
4454 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4455 Move here from alloc.c, so that charset.c can use it too.
4456 Properly align; the old code wasn't right for common 32-bit hosts
4457 when configured with --enable-checking=all.
4458 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4459 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4460
31bed486
EZ
44612011-09-29 Eli Zaretskii <eliz@gnu.org>
4462
04c70788 4463 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4464 use EDOM.
4465
fbcaa2f3
EZ
44662011-09-28 Eli Zaretskii <eliz@gnu.org>
4467
4468 * xdisp.c (compute_display_string_end): If there's no display
4469 string at CHARPOS, return -1.
4470
4471 * bidi.c (bidi_fetch_char): When compute_display_string_end
4472 returns a negative value, treat the character as a normal
4473 character not covered by a display string. (Bug#9624)
4474
a239d4e9
JB
44752011-09-28 Juanma Barranquero <lekktu@gmail.com>
4476
4477 * lread.c (Fread_from_string): Fix typo in docstring.
4478
88652fd5
EZ
44792011-09-27 Eli Zaretskii <eliz@gnu.org>
4480
4481 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4482 newline, reseat the iterator instead of bidi-iterating there one
4483 character at a time. (Bug#9610)
32c1fffd
SM
4484 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4485 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4486
ed497dd4
AS
44872011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4488
4489 * lread.c (readevalloop): Use correct code for NBSP.
4490 (read1): Likewise. (Bug#9608)
4491
b2bf61aa
MA
44922011-09-25 Michael Albinus <michael.albinus@gmx.de>
4493
4494 * dbusbind.c (Fdbus_register_signal): When service is not
4495 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4496
32bbb17c
GM
44972011-09-25 Glenn Morris <rgm@gnu.org>
4498
4499 * buffer.c (truncate-lines): Doc fix.
4500
94e0933e
CY
45012011-09-24 Chong Yidong <cyd@stupidchicken.com>
4502
4503 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4504 (Fset_window_next_buffers): Doc fix.
4505
cddde921
GM
45062011-09-24 Glenn Morris <rgm@gnu.org>
4507
4508 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4509
1260aef1
PE
45102011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4511
25b4bfa0
PE
4512 Fix minor problems found by static checking.
4513 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4514 * indent.c (Fvertical_motion): Fix == vs = typo.
4515
e3cbd34b
EZ
45162011-09-24 Eli Zaretskii <eliz@gnu.org>
4517
a66cfb1c
SM
4518 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4519 Default value is now t. Doc fix.
6bf7006f 4520
e3cbd34b 4521 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4522 logic when moving up, not only when moving down. Fix the
e3cbd34b 4523 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4524 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4525
4526 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4527 CHARPOS is covered by a display string which includes newlines.
4528 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4529 is covered by a display string with embedded newlines.
4530
a3de0cbd
MA
45312011-09-24 Michael Albinus <michael.albinus@gmx.de>
4532
4533 * dbusbind.c (Fdbus_register_signal): Add match rule to
4534 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4535 (Fdbus_register_method, Vdbus_registered_objects_table):
4536 Fix docstring.
a3de0cbd 4537
b260039d
JM
45382011-09-24 Jim Meyering <meyering@redhat.com>
4539
32c1fffd 4540 do not ignore write error for any output size
b260039d
JM
4541 The previous change was incomplete.
4542 While it makes emacs --batch detect the vast majority of stdout
4543 write failures, errors were still ignored whenever the output size is
4544 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4545 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4546 && echo FAIL: ignored write error
4547 FAIL: ignored write error
4548 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4549 && echo FAIL: ignored write error
4550 FAIL: ignored write error
4551 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4552
8eca8a7c
AS
45532011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4554
4555 * emacs.c (Fkill_emacs): In noninteractive mode exit
4556 non-successfully if a write error occurred on stdout. (Bug#9574)
4557
3341db62
EZ
45582011-09-21 Eli Zaretskii <eliz@gnu.org>
4559
4560 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4561 the xassert test.
4562
4563 * dispextern.h (struct it): Update the comment documenting what
4564 can it->OBJECT be.
4565
8c203dbf
EZ
45662011-09-20 Eli Zaretskii <eliz@gnu.org>
4567
4568 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4569 a display string, extend search for cursor position to end of row.
4570 (find_row_edges): If the row ends in a newline from a display
4571 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4572 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4573 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4574 non-empty line. Fixes confusing cursor motion with arrow keys at
4575 the beginning of a line that starts with whitespace.
8c203dbf 4576
a4824228
LMI
45772011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4578
4579 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4580 (bug#9493).
4581
33ed493b
CY
45822011-09-18 Chong Yidong <cyd@stupidchicken.com>
4583
4584 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4585 boolean (Bug#9154).
4586
56cd55c8
EZ
45872011-09-18 Eli Zaretskii <eliz@gnu.org>
4588
4589 * xdisp.c (display_line): Record maximum and minimum buffer
4590 positions even if no glyphs were produced (e.g., by a zero-width
4591 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4592 buffer positions that will be removed from the glyph row because
4593 they don't fit.
c02dcedf
EZ
4594 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4595 column is beyond frame width: don't subtract 1 "pixel" when
4596 computing width of the stretch.
3e62b7e0
EZ
4597 (reseat_at_next_visible_line_start): Undo the change made on
4598 2011-09-17 that saved paragraph information and restored it after
4599 the call to `reseat'. (Bug#9545)
56cd55c8 4600
5ed99d36 46012011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4602
4603 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4604 and turn window cursor on if cleared (Bug#9415).
4605
5ed99d36 46062011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4607
4608 * search.c (boyer_moore): Take unibyte characters from pattern
4609 literally. (Bug#9458)
4610
9bade7b2
EZ
46112011-09-18 Eli Zaretskii <eliz@gnu.org>
4612
4613 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4614
e5e9d610
PE
46152011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4616
87e4427a
PE
4617 Fix minor problem found by static checking.
4618 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4619 initialized, to pacify gcc -Wuninitialized.
4620
e5e9d610
PE
4621 * fileio.c: Report proper errno when syscall falls.
4622 (Finsert_file_contents): Save and restore errno,
4623 so that report_file_error outputs the correct diagnostic.
4624 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4625
a1674f0b
EZ
46262011-09-18 Eli Zaretskii <eliz@gnu.org>
4627
4628 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4629
fbfb6dd4
EZ
46302011-09-17 Eli Zaretskii <eliz@gnu.org>
4631
4632 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4633 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4634
bb187662
EZ
46352011-09-17 Eli Zaretskii <eliz@gnu.org>
4636
1137e8b8 4637 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4638 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4639
4640 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4641 (bidi_find_paragraph_start): Search back for paragraph beginning
4642 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4643 (bidi_move_to_visually_next): Only trigger paragraph-related
4644 computations when the last character is a newline or at EOB, not
4645 just any NEUTRAL_B. (Bug#9470)
4646
bb187662
EZ
4647 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4648 truncated lines if point is covered by a display string. (Bug#9524)
4649
2e621251
PE
46502011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4651
4652 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4653 (cons_to_x_long): New function.
4654 (lisp_data_to_selection_data): Use it. Correct the test for
4655 short-versus-long data; it was negated. Break out of vector
4656 loop, for efficiency, when a long datum is discovered.
4657
91a15bc6
SM
46582011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4659
4660 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4661
b41c3a35
EZ
46622011-09-16 Eli Zaretskii <eliz@gnu.org>
4663
4664 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4665 GCC PR/17406) by declaring this function with external scope.
4666
7812ba2d
PE
46672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4668
4669 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4670 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4671
cf7edc2a
AS
46722011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4673
4674 * editfns.c (Fformat): Correctly handle text properties on "%%".
4675
bd01620e
EZ
46762011-09-15 Eli Zaretskii <eliz@gnu.org>
4677
4678 * xterm.c (x_draw_composite_glyph_string_foreground):
4679 * w32term.c (x_draw_composite_glyph_string_foreground):
4680 * term.c (encode_terminal_code):
4681 * composite.c (composition_update_it, get_composition_id):
4682 * xdisp.c (get_next_display_element)
4683 (fill_composite_glyph_string): Add comments about special meaning
4684 of TAB characters in a composition.
4685
a02719a3
PE
46862011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4687
4688 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4689 This occurs when processing a multibyte format.
4690 Problem reported by Wolfgang Jenker.
a02719a3 4691
72589a3c
JB
46922011-09-15 Johan Bockgård <bojohan@gnu.org>
4693
4694 * xdisp.c (try_cursor_movement): Only check for exact match if
4695 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4696
1c14176c
PE
46972011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4698
4699 Remove unused external symbols.
4700 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4701 * xdisp.c (calc_pixel_width_or_height): Now static.
4702 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4703 * indent.c (check_display_width):
4704 * w32term.c: Fix comment to match code.
4705 * xterm.c, xterm.h (x_catching_errors): Remove.
4706
d2eea5b5
PE
47072011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4708
4709 * xselect.c: Use signed conversions more consistently (Bug#9498).
4710 (selection_data_to_lisp_data): Assume incoming selection data are
4711 signed integers, not unsigned. This is to be consistent with
4712 outgoing selection data, which was modified to use signed integers
4713 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4714 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4715 expects long, not unsigned long.
4716
46888499
EZ
47172011-09-14 Eli Zaretskii <eliz@gnu.org>
4718
4719 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4720 computation of loop end. Reported by Johan Bockgård
4721 <bojohan@gnu.org>.
4722
ef8ef9fb
CY
47232011-09-13 Chong Yidong <cyd@stupidchicken.com>
4724
4725 * frame.c (Fother_visible_frames_p): Function deleted.
4726
fa819fed
EZ
47272011-09-12 Eli Zaretskii <eliz@gnu.org>
4728
4729 * indent.c (compute_motion): Process display vector front to back
4730 rather than the other way around. (Bug#2496)
4731
2ba8e008
SM
47322011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4733
4734 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4735
20f53c69
CY
47362011-09-11 Chong Yidong <cyd@stupidchicken.com>
4737
4738 * minibuf.c (Fread_from_minibuffer): Doc fix.
4739
d562d7a4
EZ
47402011-09-11 Eli Zaretskii <eliz@gnu.org>
4741
4742 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4743 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4744
1c4d7f3d
LMI
47452011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4746
4747 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4748 value for non-existent files.
4749
b885bf36
EZ
47502011-09-11 Eli Zaretskii <eliz@gnu.org>
4751
4752 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4753 set its "size" to -1. This will set the modtime_size field of
4754 the corresponding buffer to -1, which is what
4755 verify-visited-file-modtime expects for files that do not exist.
4756 (Bug#9139)
4757
6612f0bf
PE
47582011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4759
4760 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4761 here ...
4762 * lisp.h: ... from here. push_key_description is no longer
4763 defined in keyboard.c, so its declaration should not be in
4764 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4765 logically belongs with push_key_description.
4766
dfb3f755
PE
47672011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4768
4769 * buffer.h: Include <sys/types.h> instead of <time.h>.
4770 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4771 Problem reported by Herbert J. Skuhra.
4772
3134906c
LMI
47732011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4774
4775 * xml.c (parse_region): Make the parsing work for
4776 non-comment-starting XML files again (bug#9144).
4777
8d903f4e
AS
47782011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4779
4780 * image.c (gif_load): Fix calculation of bottom and right corner.
4781 (Bug#9468)
4782
80ad64f4
EZ
47832011-09-10 Eli Zaretskii <eliz@gnu.org>
4784
4785 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4786 redisplay in small windows.
4787
208a048d
EZ
47882011-09-09 Eli Zaretskii <eliz@gnu.org>
4789
4790 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4791
9b1c252e
MR
47922011-09-08 Martin Rudalics <rudalics@gmx.at>
4793
4794 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4795 Operate on live windows only.
4796
2949f33b
JB
47972011-09-08 Juanma Barranquero <lekktu@gmail.com>
4798
4799 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4800
e08dcafd
EZ
48012011-09-07 Eli Zaretskii <eliz@gnu.org>
4802
4803 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4804 only under bidi iteration.
4805
115b96bd
JD
48062011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4807
4808 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4809
c8199d0f
PE
48102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4811
4812 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4813 Without this fix, the command to link temacs failed due to an
4814 undefined symbol __builtin_isnan. This is because
4815 /usr/include/iso/math_c99.h #defines isnan(x) to
4816 __builtin_isnan(x), but the bundled gcc, which identifies itself
4817 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4818 a __builtin_isnan.
4819 * floatfns.c (isnan): #undef, and then #define to a clone of
4820 what's in data.c.
4821 (Fisnan): Always define, since it's always available now.
4822 (syms_of_floatfns): Always define isnan at the Lisp level.
4823
e39b275c 48242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4825
4826 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4827
b2db44d9 48282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4829
f4af5137 4830 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4831 The previous code assumed that file offsets (off_t values) fit in
4832 EMACS_INT variables, which is not true on typical 32-bit hosts.
4833 The code messed up by falsely reporting buffer overflow in cases
4834 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4835 when "big" contains more than 2**29 bytes, even though this
4836 inserts just one byte and does not overflow the buffer.
4837 (Finsert_file_contents): Store file offsets as off_t
4838 values, not as EMACS_INT values. Check for overflow when
4839 converting between EMACS_INT and off_t. When checking for
4840 buffer overflow or for overlap, take the offsets into account.
4841 Don't use EMACS_INT for small values where int suffices.
4842 When checking for overlap, fix a typo: ZV was used where
4843 ZV_BYTE was intended.
4844 (Fwrite_region): Don't assume off_t fits into 'long'.
4845 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4846
ecfc0a49
MA
48472011-09-05 Michael Albinus <michael.albinus@gmx.de>
4848
4849 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4850
6511acf2 48512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4852
0999621a 4853 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4854
4855 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4856 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4857 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4858 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4859 (modify_event_symbol): Do not assume that the length of
4860 name_alist_or_stem is safe to alloca and fits in int.
4861 (Fexecute_extended_command): Likewise for function name and binding.
4862 (Frecursion_depth): Wrap around reliably on integer overflow.
4863 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4864 since some callers pass EMACS_INT values.
4865 (Fsingle_key_description): Don't crash if symbol name contains more
4866 than MAX_ALLOCA bytes.
4867 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4868 (get_minibuffer): Arg is now EMACS_INT, not int.
4869 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4870 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4871 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4872
2be7d702
PE
4873 * dbusbind.c (signature_cat): New function.
4874 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4875 Do not overrun buffer; instead, report string overflow.
4876
9d1df220
PE
4877 * dispnew.c (add_window_display_history): Don't overrun buffer.
4878 Truncate instead; this is OK since it's just a log.
4879
33ef5c64
PE
4880 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4881 even if the time zone offset is outlandishly large.
4882 Don't mishandle offset == INT_MIN.
4883
66c6fdd5
PE
4884 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4885 when creating daemon; the previous buffer-overflow check was incorrect.
4886
d749b01b
PE
4887 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4888 which has the guts of the old verror function.
4889
b5cd1905
PE
4890 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4891 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4892
6e1a67fb
PE
4893 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4894 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4895 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4896 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4897 length of string rather than counting it via multiple sprintfs;
4898 that's simpler and more reliable.
c21721cc
PE
4899 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4900 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4901 sprintf, in case result does not fit in int.
4902
c57b67fc
PE
4903 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4904 (fontset_from_font): Print it.
4905
8a401434
PE
4906 * frame.c (tty_frame_count): Now printmax_t, not int.
4907 (make_terminal_frame, set_term_frame_name): Print it.
4908 (x_report_frame_params): In X, window IDs are unsigned long,
4909 not signed long, so print them as unsigned.
4910 (validate_x_resource_name): Check for implausibly long names,
4911 and don't assume name length fits in 'int'.
4912 (x_get_resource_string): Don't blindly alloca invocation name;
4913 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4914 not fit in int.
4915
6e1a67fb
PE
4916 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4917 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4918 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4919
0df02bf3
PE
4920 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4921 Use esprintf, not sprintf, in case result does not fit in int.
4922
48e30793
PE
4923 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4924 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4925 it as a large positive number.
4926 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4927 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4928
a66ff6d8
PE
4929 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4930 in case result does not fit in int.
4931
aca216ff
PE
4932 * print.c (float_to_string): Detect width overflow more reliably.
4933 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4934 buffer overrun. Don't assume list length fits in 'int'. Treat
4935 print length of 0 as 0, not as infinity; to be consistent with other
4936 uses of print length in this function. Don't overflow print length
4937 index. Don't assume hash table size fits in 'long', or that
4938 vectorlike size fits in 'unsigned long'.
4939
31c286f7
PE
4940 * process.c (make_process): Use printmax_t, not int, to format
4941 process-name gensyms.
4942
55e5faa1
PE
4943 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4944
80f2e268
PE
4945 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4946 to avoid potential buffer overrun.
4947
670741ab
PE
4948 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4949 if X resource line is longer than 512 bytes.
4950
b7163a50
PE
4951 * xfns.c (x_window): Make sprintf buffer a bit bigger
4952 to avoid potential buffer overrun.
4953
ae58ff1f
PE
4954 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4955
c43c8a6a
PE
4956 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4957
3f8236f4
PE
49582011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4959
53e9fe90 4960 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4961 Without these, Emacs silently mishandles large integers sometimes.
4962 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4963 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4964
6511acf2
PE
4965 * xdisp.c (try_window_id): Check Emacs fixnum range before
4966 converting to 'int'.
806add1d 4967
6511acf2 4968 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4969 Check that an Emacs fixnum is in range before assigning it to 'int'.
4970 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4971 values converted from Emacs fixnums.
4972 (Frecenter): Don't wrap around a line count if it is out of 'int'
4973 range; instead, treat it as an extreme value.
4974 (Fset_window_configuration, compare_window_configurations):
4975 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4976
6511acf2
PE
4977 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4978 that can exceed INT_MAX. Check that EMACS_INT value is in range
4979 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4980 (match_limit): Don't assume that a fixnum can fit in 'int'.
4981
6511acf2 4982 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4983 exceed INT_MAX.
4984
6511acf2 4985 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4986 (Fvertical_motion): Don't wrap around LINES values that don't fit
4987 in 'int'. Instead, treat them as extreme values. This is good
4988 enough for windows, which can't have more than INT_MAX lines anyway.
4989
fcb901a7
LMI
49902011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4991
0f2f6b6d
LMI
4992 * Require libxml/parser.h to avoid compilation warning.
4993
fcb901a7
LMI
4994 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4995
4996 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4997 since this reportedly can destroy thread storage.
4998
6e20a0d4
CY
49992011-08-30 Chong Yidong <cyd@stupidchicken.com>
5000
5001 * syntax.c (find_defun_start): Update all cache variables if
5002 exiting early (Bug#9401).
5003
148ae00e
EZ
50042011-08-30 Eli Zaretskii <eliz@gnu.org>
5005
f6cfbd8f
EZ
5006 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5007
148ae00e
EZ
5008 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5009 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5010 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5011
5012 * term.c (tty_append_glyph): New function.
5013 (produce_stretch_glyph): Static function and its prototype deleted.
5014
a66cfb1c
SM
5015 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5016 Add prototypes.
148ae00e 5017
c4a07a4c
PE
50182011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5019
5020 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5021 when checking :margin (Bug#9390).
5022 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5023 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5024 so that the name doesn't mislead. All uses changed.
5025
6bc8cd65
JB
50262011-08-28 Johan Bockgård <bojohan@gnu.org>
5027
5028 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5029 set_tty_hooks.
5030
dca4927e
EZ
50312011-08-27 Eli Zaretskii <eliz@gnu.org>
5032
5033 * xdisp.c (move_it_to): Don't bail out early when reaching
5034 position beyond to_charpos, if we are scanning backwards.
5035 (move_it_vertically_backward): When DY == 0, make sure we get to
5036 the first character in the line after the newline.
5037
f2cad773
PE
50382011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5039
5040 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5041 (ccl_driver): Do not generate an out-of-range pointer.
5042 (Fccl_execute_on_string): Remove unnecessary check for
5043 integer overflow, noted by Stefan Monnier in
5044 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5045 Remove a FIXME that didn't need fixing.
5046 Simplify the newly-introduced buffer reallocation code.
5047
0cae2cdb
JB
50482011-08-27 Juanma Barranquero <lekktu@gmail.com>
5049
5050 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5051
5fc295a4 50522011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5053
70c60eb2 5054 Integer and memory overflow issues (Bug#9196).
726e0ab1 5055
d31850da
PE
5056 * doc.c (get_doc_string): Rework so that
5057 get_doc_string_buffer_size is the actual buffer size, rather than
5058 being 1 less than the actual buffer size; this makes xpalloc more
5059 convenient.
5060
a69fbedb
PE
5061 * image.c (x_allocate_bitmap_record, cache_image):
5062 * xselect.c (Fx_register_dnd_atom):
5063 Simplify previous changes by using xpalloc.
5064
fe5c5d37
PE
5065 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5066 since either will do and ptrdiff_t is convenient with xpalloc.
5067
0065d054
PE
5068 * charset.c (charset_table_size)
5069 (struct charset_sort_data.priority): Now ptrdiff_t.
5070 (charset_compare): Don't overflow if priorities differ greatly.
5071 (Fsort_charsets): Don't assume list length fits in int.
5072 Check for size-calculation overflow when allocating sort data.
5073 (syms_of_charset): Allocate an initial charset table that is
5074 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5075
5076 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5077
5078 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5079 The actual value is always <= INT_MAX, and leaving it unsigned made
5080 overflow checking harder.
5081
5082 * dispextern.h (struct glyph_matrix.rows_allocated)
5083 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5084 with xpalloc. The values are still always <= INT_MAX.
5085
5086 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5087
5088 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5089 (SAFE_NALLOCA): New macro.
5090
5091 * region-cache.c (struct boundary.pos, find_cache_boundary)
5092 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5093 (set_cache_region, invalidate_region_cache)
5094 (revalidate_region_cache, know_region_cache, region_cache_forward)
5095 (region_cache_backward, pp_cache):
5096 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5097 so that ptrdiff_t * can be passed to xpalloc.
5098 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5099 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5100 (pp_cache): Don't assume cache_len fits in int.
5101 * region-cache.h: Adjust extern decls to match.
5102
5103 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5104 EMACS_INT, since either will do, for xpalloc.
5105
5106 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5107 (xnmalloc, xnrealloc, xpalloc): New functions.
5108
726e0ab1
PE
5109 * bidi.c (bidi_shelve_header_size): New constant.
5110 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5111 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5112
51f30bc5 5113 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5114 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5115 (overlay_strings):
5116 Don't update size of array until after memory allocation succeeds,
5117 because xmalloc/xrealloc may not return.
0065d054
PE
5118 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5119 now that we have proper integer overflow checking.
5120 (record_overlay_string, overlay_strings): Catch overflows when
5121 calculating size of overlay_str_buf.
726e0ab1 5122
0065d054
PE
5123 * callproc.c (Fcall_process): Check for size overflow when
5124 calculating size of args2.
5125 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5126 Normally we prefer signed values, but sticking with ptrdiff_t would
5127 require adding more-complicated checks.
726e0ab1
PE
5128
5129 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5130 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5131 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5132 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5133
5134 * character.c (Fstring): Check for size-calculation overflow.
5135
5136 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5137 unnecessary integer overflow. Check for size overflow.
5138 (encode_coding_object): Don't update size until xmalloc succeeds.
5139
5140 * composite.c (get_composition_id): Check for overflow in glyph
5141 length calculations.
5142
5143 Integer and memory overflow fixes for display code.
5144 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5145 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5146 (scrolling_window): Check for overflow in size calculations.
5147 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5148 Don't assume glyph table len fits in int.
5149 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5150 (row_table_size): Now ptrdiff_t, not int.
5151 (scrolling_window): Avoid overflow in size calculations.
5152 Don't update size until allocation succeeds.
5153 * fns.c (concat): Check for overflow in size calculations.
5154 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5155 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5156 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5157
5158 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5159 (get_doc_string): Check for size calculation overflow.
5160 Don't update size until allocation succeeds.
5161 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5162 EMACS_INT, where ptrdiff_t will do.
5163 (Fsubstitute_command_keys): Check for string overflow.
5164
5165 * editfns.c (set_time_zone_rule): Don't assume environment length
5166 fits in int.
5167 (message_length): Now ptrdiff_t, not int.
5168 (Fmessage_box): Don't update size until allocation succeeds.
5169 Don't assume message length fits in int.
5170 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5171
0065d054
PE
5172 * emacs.c (main): Do not reallocate argv, since there is a null at
5173 the end that can be overwritten, and this way there's no need to
5174 worry about size-calculation overflow.
5175 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5176
5177 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5178 alloc succeeds.
5179 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5180
5181 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5182 (x_set_scroll_bar_width, x_figure_window_size):
5183 Check for integer overflow.
5184 (x_set_alpha): Do not assume XINT fits in int.
5185
5186 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5187 This is for the members text_lines, text_cols, total_lines, total_cols,
5188 where the system imposes an 'int' limit.
5189
5190 * fringe.c (Fdefine_fringe_bitmap):
5191 Don't update size until alloc works.
5192
5193 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5194 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5195
5196 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5197 Check for size-calculation overflow.
5198 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5199 do, as we prefer signed integers.
5200 (id_to_widget.max_size, id_to_widget.used)
5201 (xg_store_widget_in_map, xg_remove_widget_from_map)
5202 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5203 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5204 Use and return ptrdiff_t, not int.
5205 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5206 * gtkutil.h: Change prototypes to match the above.
5207
5208 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5209 are duplicate now that they've been promoted to lisp.h.
5210 (x_allocate_bitmap_record, x_alloc_image_color)
5211 (make_image_cache, cache_image, xpm_load):
5212 Don't update size until alloc is done.
5213 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5214 (x_detect_edges):
3256efce 5215 Check for size calculation overflow.
726e0ab1
PE
5216 (ct_colors_allocated_max): New constant.
5217 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5218 overflow.
3256efce 5219
726e0ab1
PE
5220 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5221 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5222 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5223 Use ptrdiff_t, not int, to count maps.
5224 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5225 calculations. Don't update size until allocation succeeds.
5226 Redo calculations to avoid overflow.
726e0ab1
PE
5227 * keyboard.h: Change prototypes to match the above.
5228
5229 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5230 to count maps.
5231 (current_minor_maps): Check for size calculation overflow.
5232 * keymap.h: Change prototypes to match the above.
5233
5234 * lread.c (read1, init_obarray): Don't update size until alloc done.
5235
5236 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5237 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5238
726e0ab1
PE
5239 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5240 Now ptrdiff_t, not int.
5241 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5242 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5243
5244 * process.c (Fnetwork_interface_list): Check for overflow
5245 in size calculation.
5246
5247 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5248
5249 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5250 overflow. Don't bother calling xmalloc when xrealloc will do.
5251
5252 * search.c (Freplace_match): Check for size calculation overflow.
5253 (Fset_match_data): Don't assume list lengths fit in 'int'.
5254
5255 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5256 for command line length. Do not attempt to address one before the
5257 beginning of an array, as that's not portable.
5258
5259 * term.c (max_frame_lines): Remove; unused.
5260 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5261 not int.
5262 (encode_terminal_code, calculate_costs): Check for size
5263 calculation overflow.
5264 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5265 table lengths and related sizes. Don't update size until alloc
5266 done. Redo calculations to avoid overflow.
5267 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5268
5269 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5270 subtracting pointers.
5271 (gobble_line): Check for overflow more carefully. Don't update size
5272 until alloc done.
5273
5274 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5275 Don't update size until alloc done.
5276 Redo size calculations to avoid overflow.
5277 Check for size calculation overflow.
0065d054 5278 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5279
5280 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5281 Use ptrdiff_t, not int, for sizes.
5282 (store_mode_line_noprop_char): Don't update size until alloc done.
5283
0065d054
PE
5284 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5285 Use ptrdiff_t, not int, for sizes.
5286 (Finternal_make_lisp_face, cache_face):
5287 Check for size calculation overflow.
5288 (cache_face): Treat size calculation overflows as if they were
5289 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5290
5291 * xfns.c (x_encode_text, x_set_name_internal)
5292 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5293 sizes, since they can exceed INT_MAX in size. Check for size
5294 calculation overflow.
5295
0065d054
PE
5296 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5297 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5298 Don't update size until alloc done.
5299
0065d054 5300 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5301 as sprintf is limited to int lengths.
1d526e2f 5302
252c5ee1
PE
5303 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5304 (X_LONG_MIN): New macros.
864d7ce7
PE
5305 Use them to make the following changes clearer.
5306 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5307 This change doesn't affect the value now, but it may help remind
5308 future maintainers not to raise the value too much later.
5309 (SELECTION_QUANTUM): Remove, replacing with ...
5310 (selection_quantum): ... new function, which avoids overflow.
5311 All uses changed.
5312 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5313 assumption that selection length fits in 'int'.
5314 (x_reply_selection_request, x_handle_selection_request)
5315 (x_get_window_property, receive_incremental_selection)
5316 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5317 (lisp_data_to_selection_data, clean_local_selection_data):
5318 Use ptrdiff_t, not int, to record length of selection.
5319 (x_reply_selection_request, x_get_window_property)
5320 (receive_incremental_selection, x_property_data_to_lisp):
5321 Redo calculations to avoid overflow.
5322 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5323 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5324 something.
5325 (x_get_window_property, receive_incremental_selection)
5326 (lisp_data_to_selection_data, x_property_data_to_lisp):
5327 Check for size-calculation overflow.
5328 (x_get_window_property, receive_incremental_selection)
5329 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5330 Don't store size until memory allocation succeeds.
5331 (x_get_window_property): Plug memory leak on memory exhaustion.
5332 Don't double-block input; malloc is safe here. Don't assume 2**34
5333 - 4 fits in unsigned long. Add an xassert to check
5334 XGetWindowProperty overflow. Be more careful about overflow
5335 calculations, and distinguish size from memory overflow better.
5336 (receive_incremental_selection): When tracing, don't assume
5337 unsigned int is less than INT_MAX.
5338 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5339 harmful) conversions of unsigned short to int.
5340 (lisp_data_to_selection_data): Don't assume that integers
5341 in the range -65535 through -1 fit in an X unsigned short.
5342 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5343 result parameters unless successful. Rely on cons_to_unsigned
5344 to report problems with elements; the old code wasn't right anyway.
5345 (x_check_property_data): Check for int overflow; we cannot use
5346 a wider type due to X limits.
5347 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5348
726e0ab1 5349 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5350
0065d054
PE
5351 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5352 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5353 (x_color_cells): Don't store size until memory allocation succeeds.
5354 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5355 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5356 (x_term_init): Don't assume length fits in int (sprintf is limited
5357 to int size).
bc18e09d 5358
ebfa62c0
PE
5359 Use ptrdiff_t for composition IDs.
5360 * character.c (lisp_string_width):
5361 * composite.c (composition_table_size, n_compositions)
5362 (get_composition_id, composition_gstring_from_id):
5363 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5364 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5365 * window.c (Frecenter):
5366 Use ptrdiff_t, not int, for composition IDs.
5367 * composite.c (get_composition_id): Check for integer overflow.
5368 * composite.h: Adjust prototypes to match the above changes.
5369
d3411f89
PE
5370 Use ptrdiff_t for hash table indexes.
5371 * category.c (hash_get_category_set):
5372 * ccl.c (ccl_driver):
5373 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5374 * coding.c (coding_system_charset_list, detect_coding_system):
5375 * coding.h (struct coding_system.id):
5376 * composite.c (get_composition_id, gstring_lookup_cache):
5377 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5378 * image.c (xpm_get_color_table_h):
5379 * lisp.h (hash_lookup, hash_put):
5380 * minibuf.c (Ftest_completion):
5381 Use ptrdiff_t for hash table indexes, not int (which is too
5382 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5383 32-bit --with-wide-int hosts).
5384
e097a6fa
PE
5385 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5386 Add a FIXME comment about memory leaks.
5387 (syms_of_charset): Don't assume xmalloc returns.
5388
5637687f
PE
5389 Don't assume that stated character widths fit in int.
5390 * character.c (Fchar_width, c_string_width, lisp_string_width):
5391 * character.h (CHAR_WIDTH):
5392 * indent.c (MULTIBYTE_BYTES_WIDTH):
5393 Use sanitize_char_width to avoid undefined and/or bad behavior
5394 with outlandish widths.
a66cfb1c 5395 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5396 now that we have two such functions. All uses changed.
5397 (sanitize_char_width): New inline function.
5398
a2271ba2
PE
5399 Don't assume that tab-width fits in int.
5400 * character.h (sanitize_width): New inline function.
5401 (SANE_TAB_WIDTH): New macro.
5402 (ASCII_CHAR_WIDTH): Use it.
5403 * indent.c (sane_tab_width): Remove. All uses replaced by
5404 SANE_TAB_WIDTH (current_buffer).
5405 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5406
18c52557
PE
5407 * fileio.c: Integer overflow issues with file modes.
5408 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5409
caeeedc1
PE
5410 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5411 Remove unreachable code.
5412 (read_hex, load_charset_map_from_file): Check for integer overflow.
5413
6df6ae42 5414 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5415 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5416 (x_send_scroll_bar_event): Likewise. Check that the size does not
5417 exceed limits imposed by XClientMessageEvent, as well as the usual
5418 ptrdiff_t and size_t limits.
5419
b13995db
PE
5420 * keyboard.c: Overflow, signedness and related fixes.
5421 (make_lispy_movement): Use same integer type in forward decl
5422 that is used in the definition.
5423 (read_key_sequence, keyremap_step):
5424 Change bufsize argument back to int, undoing my 2011-03-30 change.
5425 We prefer signed types, and int is wide enough here.
5426 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5427 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5428 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5429 length, not size_t. Use ptrdiff_t for index, not int.
5430 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5431 possibility of integer overflow.
5432
13464394
PE
5433 Overflow, signedness and related fixes for images.
5434
5435 * dispextern.h (struct it.stack[0].u.image.image_id)
5436 (struct_it.image_id, struct image.id, struct image_cache.size)
5437 (struct image_cache.used, struct image_cache.ref_count):
5438 * gtkutil.c (update_frame_tool_bar):
5439 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5440 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5441 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5442 * nsmenu.m (update_frame_tool_bar):
5443 * xdisp.c (calc_pixel_width_or_height):
5444 * xfns.c (image_cache_refcount):
5445 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5446 on typical 64-bit hosts.
5447
5448 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5449 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5450 Omit unnecessary casts to int.
5451 (parse_image_spec): Check that integers fall into 'int' range
5452 when the callers expect that.
5453 (image_ascent): Redo ascent calculation to avoid int overflow.
5454 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5455 (lookup_image): Remove unnecessary tests.
5456 (xbm_image_p): Locals are now of int, not EMACS_INT,
5457 since parse_image_check makes sure they fit into int.
5458 (png_load, gif_load, svg_load_image):
5459 Prefer int to unsigned where either will do.
5460 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5461 old tiff_error_handler and tiff_warning_handler.
5462 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5463 stack buffer overflows. It uses only the features of vsnprintf
5464 that are common to both POSIX and native Microsoft.
5465 (tiff_error_handler, tiff_warning_handler): Use it.
5466 (tiff_load, gif_load, imagemagick_load_image):
5467 Don't assume :index value fits in 'int'.
5468 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5469 (imagemagick_load_image): Check that crop parameters fit into
5470 the integer types that MagickCropImage accepts. Don't assume
5471 Vimagemagick_render_type has a nonnegative value. Don't assume
5472 size_t fits in 'long'.
5473 (gs_load): Use printmax_t to print the widest integers possible.
5474 Check for integer overflow when computing image height and width.
5475
c11821d4
EZ
54762011-08-26 Eli Zaretskii <eliz@gnu.org>
5477
5478 * xdisp.c (redisplay_window): Don't force window start if point
5479 will be invisible in the resulting window. (Bug#9324)
5480
0c95fcf7
EZ
54812011-08-25 Eli Zaretskii <eliz@gnu.org>
5482
5483 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5484 the display spec is of the form `(space ...)'.
5485 (handle_display_spec): Return the value returned by
5486 handle_single_display_spec, not just 1 or zero.
5487 (handle_single_display_spec): If the display spec is of the form
5488 `(space ...)', and specifies display in the text area, return 2
5489 rather than 1.
fee65a97 5490 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5491 accurately, and prefer exact match for point under bidi.
5492 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5493
5494 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5495 into disp_prop; all users changed.
5496
5497 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5498 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5499 for the text covered by the display property.
5500
e4ed06f1
CY
55012011-08-25 Chong Yidong <cyd@stupidchicken.com>
5502
5503 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5504 Change return value to nil.
5505 (Frecord_buffer): Delete unused function.
5506
f67cdd7f
EZ
55072011-08-24 Eli Zaretskii <eliz@gnu.org>
5508
5980d4c6
EZ
5509 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5510 buffers, return left-to-right.
8610fe8b
EZ
5511 (set_cursor_from_row): Consider candidate row a win if its glyph
5512 represents a newline and point is on that newline. Fixes cursor
5513 positioning on the newline at EOL of R2L text within L2R
5514 paragraph, and vice versa.
5515 (try_cursor_movement): Check continued rows, in addition to
5516 continuation rows. Fixes unwarranted scroll when point enters a
5517 continued line of R2L text within an L2R paragraph, or vice versa.
5518 (cursor_row_p): Consider the case of point being equal to
5519 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5520 from the end of a short line to the beginning of a continued line
5521 of R2L text within L2R paragraph.
5522 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5523 composed characters.
5980d4c6 5524
f67cdd7f
EZ
5525 * bidi.c (bidi_check_type): Use xassert.
5526 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5527 members.
5528
bca633fb
EZ
55292011-08-23 Eli Zaretskii <eliz@gnu.org>
5530
5531 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5532 a character.
5533
4a5885a7
CY
55342011-08-23 Chong Yidong <cyd@stupidchicken.com>
5535
5536 * nsfont.m (ns_otf_to_script): Fix typo.
5537
0902a04e
KH
55382011-08-22 Kenichi Handa <handa@m17n.org>
5539
5540 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5541 extra slot even if the purpose is char-code-property-table.
5542
1a2e6670
EZ
55432011-08-23 Eli Zaretskii <eliz@gnu.org>
5544
8ddde651
EZ
5545 * xdisp.c (redisplay_window): When computing centering_position,
5546 account for the height of the header line. (Bug#8874)
5547
425cc014
EZ
5548 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5549 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5550 candidate is selected by the mouse, and that candidate has a
5551 composed character under the mouse.
5552
1a2e6670
EZ
5553 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5554 coordinates reported by pos-visible-in-window-p for a composed
5555 character in column zero.
5556
8b76d6f8
SM
55572011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5558
5559 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5560
dac347dd
EZ
55612011-08-22 Eli Zaretskii <eliz@gnu.org>
5562
5563 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5564 consider it a hit if to_charpos is anywhere in the range of the
5565 composed buffer positions.
5566
e013fb34
CY
55672011-08-22 Chong Yidong <cyd@stupidchicken.com>
5568
5569 * image.c (gif_load): Don't assume that each subimage has the same
5570 dimensions as the base image. Handle disposal method that is
5571 "undefined" by the gif spec (Bug#9335).
5572
bd1ba3e8
CY
55732011-08-20 Chong Yidong <cyd@stupidchicken.com>
5574
5575 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5576 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5577
54a1215b
EZ
55782011-08-19 Eli Zaretskii <eliz@gnu.org>
5579
823564e5
EZ
5580 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5581 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5582 from an Org mode buffer to a Speedbar frame.
5583
54a1215b
EZ
5584 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5585 a composition, take its buffer position from IT->cmp_it.charpos.
5586 Fixes cursor positioning at the beginning of a line that begins
5587 with a composed character.
5588
9778ebcc
EZ
55892011-08-18 Eli Zaretskii <eliz@gnu.org>
5590
0be6ee06
EZ
5591 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5592 character bidirectional type, use STRONG_L instead. Fixes crashes
5593 in a buffer produced by `describe-categories'.
5594
9778ebcc
EZ
5595 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5596 members before the level stack, so they would be saved and
5597 restored when copying iterator state. Fixes incorrect reordering
5598 around TABs covered by display properties.
5599
156bffbe
AS
56002011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5601
6b02f655 5602 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5603
72ad093b
CY
56042011-08-17 Chong Yidong <cyd@stupidchicken.com>
5605
5606 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5607 (internal_condition_case_2, internal_condition_case_n):
5608 Remove unnecessary aborts (Bug#9081).
72ad093b 5609
35774242
EZ
56102011-08-17 Eli Zaretskii <eliz@gnu.org>
5611
5612 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5613 has no `load' handler, try opening the file locally. (Bug#9311)
5614
db76dd85
KB
56152011-08-16 Ken Brown <kbrown@cornell.edu>
5616
5617 * gmalloc.c: Expand comment.
5618
b215eee5
EZ
56192011-08-16 Eli Zaretskii <eliz@gnu.org>
5620
5621 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5622 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5623
a4579d33
KB
56242011-08-16 Ken Brown <kbrown@cornell.edu>
5625
5626 Fix memory allocation problems in Cygwin build (Bug#9273).
5627
5628 * unexcw.c ( __malloc_initialized): Declare external variable.
5629 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5630
8b76d6f8
SM
5631 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5632 New variables.
a4579d33
KB
5633 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5634 dumped emacs.
5635 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5636 in the static heap.
5637 [CYGWIN] (special_realloc): New function.
5638 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5639 requests to realloc storage in the static heap.
5640
3ebec551
PE
56412011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5642
5643 * bidi.c (bidi_initialize): Remove unused local.
5644
9fd8be00
EZ
56452011-08-15 Eli Zaretskii <eliz@gnu.org>
5646
6b02f655
SM
5647 * bidimirror.h:
5648 * biditype.h: Remove file.
5649 * makefile.w32-in ($(BLD)/bidi.$(O)):
5650 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5651
5652 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5653
5654 * chartab.c: Improve commentary for the uniprop_table API.
5655
32413314
EZ
5656 * bidi.c (bidi_paragraph_init): Support zero value of
5657 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5658 (bidi_initialize): Use uniprop_table instead of including
5659 biditype.h and bidimirror.h.
32413314 5660
9fd8be00
EZ
5661 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5662 coordinates of the iterator when restoring from ppos_it.
5663 (Bug#9296)
5664
5cf2b69b
KH
56652011-08-14 Kenichi Handa <handa@m17n.org>
5666
5667 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5668 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5669
daf17d00
EZ
56702011-08-14 Eli Zaretskii <eliz@gnu.org>
5671
5672 * xdisp.c (move_it_in_display_line_to): Don't invoke
5673 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5674 ppos_it. Fixes vertical cursor motion when line beginning is
5675 covered by an image. (Bug#9296)
5676
08e3161a
JD
56772011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5678
5679 * nsterm.h (ns_run_ascript): Declare.
5680 (NSAPP_DATA2_RUNASSCRIPT): Define.
5681
5682 * nsfns.m (as_script, as_result, as_status): New static variables.
5683 (ns_run_ascript): New function.
5e617bc2 5684 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5685 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5686 the event loop. Get status from as_status (Bug#7276).
5687
5688 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5689 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5690 the event loop (Bug#7276).
5691
a3720aa2
AS
56922011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5693
5694 * gnutls.c (QCgnutls_bootprop_priority)
5695 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5696 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5697 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5698 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5699 (QCgnutls_bootprop_verify_hostname_error)
5700 (QCgnutls_bootprop_callbacks_verify): Rename from
5701 Qgnutls_bootprop_..., all uses changed.
5702
5703 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5704 uses changed.
5705
0a0d27fb
PE
57062011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5707
19d5c50c
PE
5708 * xfaces.c (Qframe_set_background_mode): Now static.
5709 * dispextern.h (Qframe_set_background_mode): Remove decl.
5710
0a0d27fb
PE
5711 * process.c (Fnetwork_interface_info): Declare local only if needed.
5712
377538cb
JD
57132011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5714
5715 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5716 (Fnetwork_interface_list): Allocate in increments of bytes instead
5717 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5718 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5719 sockaddr.
5720 (struct ifflag_def): notrailers is smart on OSX.
5721 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5722 Get hardware address with getifaddrs if available.
5723
08fff70c
EZ
57242011-08-12 Eli Zaretskii <eliz@gnu.org>
5725
5726 * xdisp.c (iterate_out_of_display_property): xassert that
5727 IT->position is set to within IT->object's boundaries. Break from
5728 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5729 when IT->position is set up wrongly due to some bug.
5730 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5731 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5732 entry. Force push_it to save on the stack the current
5733 buffer/string position, to be restored by pop_it. Fix flags in
5734 the iterator structure wrt the object coming from a display
5735 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5736 properties. (Bug#9284)
5737
7be1c708 57382011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5739
7be1c708
CY
5740 * fontset.c (fontset_get_font_group): Add proper type checks.
5741 (Bug#9172)
aac0c6e3 5742
7be1c708 57432011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5744
7be1c708
CY
5745 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5746 and LC_VERSION_MIN_MACOSX.
5747 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5748 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5749
97bb72a6
EZ
57502011-08-08 Eli Zaretskii <eliz@gnu.org>
5751
5752 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5753 no-display-properties-and-no-overlays under bidi display.
5754 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5755 properties and overlays.
97bb72a6 5756
d5617611
CY
57572011-08-08 Chong Yidong <cyd@stupidchicken.com>
5758
37e11a63
CY
5759 * editfns.c (Fset_time_zone_rule): Document relationship with the
5760 setenv function.
5761
d5617611
CY
5762 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5763 the font entity extracted from the cache (Bug#8109).
5764
58872834
CY
57652011-08-07 Chong Yidong <cyd@stupidchicken.com>
5766
5767 * composite.c (autocmp_chars): Don't reset point. That is done by
5768 restore_point_unwind (Bug#5984).
5769
75bfc667
JL
57702011-08-07 Juri Linkov <juri@jurta.org>
5771
5772 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5773 to show the arg `TIME' instead of `TIMEVAL'.
5774
d1410150
EZ
57752011-08-06 Eli Zaretskii <eliz@gnu.org>
5776
5777 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5778 display property strides EOL and includes a newline, as in
5779 longlines-mode. (Bug#9254)
75b771e4
EZ
5780 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5781 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5782
5783 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5784 is non-zero, even if the data buffer is NULL. Fixes a crash in
5785 vertical-motion with longlines-mode. (Bug#9254)
5786
35928349
EZ
57872011-08-05 Eli Zaretskii <eliz@gnu.org>
5788
ec7cc85b
EZ
5789 * bidi.c <bidi_cache_total_alloc>: Now static.
5790 (bidi_initialize): Initialize bidi_cache_total_alloc.
5791
8b76d6f8 5792 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5793 cache. (Bug#9221)
5794
5795 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5796 amount allocated this far in `bidi_cache_total_alloc'.
5797 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5798 non-zero, only free the data buffer without restoring the cache
5799 contents. All callers changed.
5800
5801 * dispextern.h (bidi_unshelve_cache): Update prototype.
5802
5803 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5804 (move_it_in_display_line, move_it_to)
5805 (move_it_vertically_backward, move_it_by_lines): Replace the call
5806 to xfree to an equivalent call to bidi_unshelve_cache.
5807 (move_it_in_display_line_to): Fix logic of returning
412b6358 5808 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5809
e2e2423b
EZ
58102011-08-05 Eli Zaretskii <eliz@gnu.org>
5811
5812 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5813 came from a string character with a `cursor' property. (Bug#9229)
5814
ae9e757a
JD
58152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5816
5817 * Makefile.in (LIB_PTHREAD): New variable.
5818 (LIBES): Add LIB_PTHREAD (Bug#9216).
5819
5820 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5821 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5822
213bd7f2
AS
58232011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5824
6b02f655 5825 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5826
99aaf75f
JD
58272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5828
5829 * xterm.c (x_find_topmost_parent): New function.
5830 (x_set_frame_alpha): Find topmost parent window with
5831 x_find_topmost_parent and set the property there also (bug#9181).
5832 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5833
c74e9d86
PE
58342011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5835
5836 * callproc.c (Fcall_process): Avoid vfork clobbering
5837 the local vars buffer, coding_systems, current_dir.
5838
640c8776
SM
58392011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5840
5841 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5842
f26d0e4c
PE
58432011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5844
8a10d76c
PE
5845 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5846 so that it is not optimized away.
5847
f26d0e4c
PE
5848 * xdisp.c (compute_display_string_pos): Remove unused local.
5849
55439c61
EZ
58502011-08-02 Eli Zaretskii <eliz@gnu.org>
5851
5852 Fix slow cursor motion and scrolling in large buffers with
5853 selective display, like Org Mode buffers. (Bug#9218)
5854
5855 * dispextern.h (struct bidi_it): New member disp_prop_p.
5856
5857 * xdisp.c: Remove one-slot cache of display string positions.
5858 (compute_display_string_pos): Accept an additional argument
5e617bc2 5859 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5860 for a display string or property. If found, set DISP_PROP_P
5861 non-zero.
5862
5863 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5864 DISP_PROP_P, and pass it to compute_display_string_pos.
5865 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5866 non-zero. All callers of bidi_fetch_char changed.
5867
fb33fa43
SM
58682011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5869
5870 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5871
b099e063
DM
58722010-12-03 Don March <don@ohspite.net>
5873
5874 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5875 last character M-[char] is translated to ESC [char] (bug#7541).
5876
5cc7f7af
KH
58772011-08-02 Kenichi Handa <handa@m17n.org>
5878
d0fffa3f 5879 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5880
5881 * chartab.c (uniprop_table): Make it non-static.
5882
525d5e6e
EZ
58832011-08-01 Eli Zaretskii <eliz@gnu.org>
5884
5885 * xdisp.c (forward_to_next_line_start): Accept additional argument
5886 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5887 on the newline.
5888 (reseat_at_next_visible_line_start): Use the bidi iterator state
5889 returned by forward_to_next_line_start to restore the state of
5890 it->bidi_it after backing up to previous newline. (Bug#9212)
5891
31011111
AS
58922011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5893
5894 * regex.c (re_comp): Protoize.
5895 (re_exec): Fix return type.
5896 (regexec): Fix type of `ret'. (Bug#9203)
5897
476371c4
PE
58982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5899
e5d76069
PE
5900 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5901 This is needed if max-image-size is a floating-point number.
5902
9a79b20c
AS
59032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5904
5905 * print.c (print_object): Print empty symbol as ##.
5906
5907 * lread.c (read1): Read ## as empty symbol.
5908
d8c2fa78
AA
59092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5910
5911 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5912 setting frame foreground color (Bug#9175).
5913 (x_set_background_color): Likewise.
5914
ffe57a7a
AA
5915 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5916 contents (Bug#9176).
5917 (EmacsTooltip -init): Remove bezels and add shadows to
5918 tooltip windows.
5919
bf3492a5
AA
5920 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5921 or scroll bar (Bug#8470).
5922
d55e9c53
AA
5923 * nsfont.m (nsfont_open): Remove assignment to voffset and
5924 unnecessary vars hshink, expand, hd, full_height, min_height.
5925 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5926
5927 * nsterm.h (nsfont_info): Remove voffset field.
5928
d8c2fa78 59292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5930
5931 Implement strike-through and overline on NextStep (Bug#8863).
5932
5933 * nsfont.m (nsfont_open): Use underline position provided by font,
5934 instead of hard-coded value of 2.
5935 (nsfont_draw): Call ns_draw_text_decoration instead.
5936
5937 * nsterm.h: Add declaration for ns_draw_text_decoration.
5938
5939 * nsterm.m (ns_draw_text_decoration): New function for drawing
5940 underline, overline, and strike-through.
5941 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5942 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5943 accommodate underlining, etc.
4843aac3 5944
4cc60b9b
EZ
59452011-07-28 Eli Zaretskii <eliz@gnu.org>
5946
bc7ece87
EZ
5947 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5948 default.
4cc60b9b 5949
476371c4
PE
59502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5951
66606eea
PE
5952 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5953 Without this fix, if a signal arrives just after memory fills up,
5954 'malloc' might be invoked reentrantly.
5955
476371c4
PE
5956 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5957 In other words, assume that every image size is allowed, on non-X
5958 hosts. This assumption is probably wrong, but it lets Emacs compile.
5959
f3fcc40d
AS
59602011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5961
5962 * regex.c (re_iswctype): Convert return values to boolean.
5963
350c992f
EZ
59642011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5965
5966 * xdisp.c (compute_display_string_pos): Don't use cached display
5967 string position if the buffer had its restriction changed.
5968 (Bug#9184)
5969
5266b4bb
PE
59702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5971
5972 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5973
2573a837 59742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5975
41f55ccd 5976 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5977
39e378da
PE
5978 * bidi.c: Integer size and overflow fixes.
5979 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5980 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5981 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5982 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5983 (bidi_find_other_level_edge):
5984 Use ptrdiff_t instead of EMACS_INT where either will do.
5985 This works better on 32-bit hosts configured --with-wide-int.
5986 (bidi_cache_ensure_space): Check for size-calculation overflow.
5987 Use % rather than repeated addition, for better worst-case speed.
5988 Don't set bidi_cache_size until after xrealloc returns, because it
5989 might not return.
5990 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5991 (bidi_cache_ensure_space): Also check that the bidi cache size
5992 does not exceed that of the largest Lisp string or buffer. See Eli
5993 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5994
5e927815
PE
5995 * alloc.c (__malloc_size_t): Remove.
5996 All uses replaced by size_t. See Andreas Schwab's note
5997 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5998
ca4aa935
PE
5999 * image.c: Improve checking for integer overflow.
6000 (check_image_size): Assume that f is nonnull, since
6001 it is always nonnull in practice. This is one less thing to
6002 worry about when checking for integer overflow later.
6003 (x_check_image_size): New function, which checks for integer
6004 overflow issues inside X.
6005 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6006 This removes the need for a memory_full check.
6007 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6008 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6009 (xbm_read_bitmap_data): Change locals back to 'int', since
6010 their values must fit in 'int'.
6011 (xpm_load_image, png_load, tiff_load):
6012 Invoke x_create_x_image_and_pixmap earlier,
6013 to avoid much needless work if the image is too large.
6014 (tiff_load): Treat overly large images as if
6015 x_create_x_image_and_pixmap failed, not as malloc failures.
6016 (gs_load): Use x_check_image_size.
6017
5f8f9cc2
PE
6018 * gtkutil.c: Omit integer casts.
6019 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6020 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6021
5adf60bc
PE
6022 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6023
c8907a93
PE
6024 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6025 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6026 would wrongly return t on a 64-bit host.
6027
e3c25c68
PE
6028 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6029 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6030 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6031 and therefore cause GCC to emit a bogus diagnostic in some cases.
6032
3f791afe
PE
6033 * image.c: Integer signedness and overflow and related fixes.
6034 This is not an exhaustive set of fixes, but it's time to
6035 record what I've got.
6036 (lookup_pixel_color, check_image_size): Remove redundant decls.
6037 (check_image_size): Don't assume that arbitrary EMACS_INT values
6038 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6039 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6040 (tiff_load, imagemagick_load_image):
6041 Check for overflow in size calculations.
6042 (x_create_x_image_and_pixmap): Remove unnecessary test for
6043 xmalloc returning NULL; that can't happen.
6044 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6045 (xpm_color_bucket): Use better integer hashing function.
6046 (xpm_cache_color): Don't possibly over-allocate memory.
6047 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6048 (gif_memory_source):
6049 Use ptrdiff_t, not int or size_t, to record sizes.
6050 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6051 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6052 either works, as we prefer signed integers.
6053 (tiff_read_from_memory, tiff_write_from_memory):
6054 Return tsize_t, not size_t, since that's what the TIFF API wants.
6055 (tiff_read_from_memory): Don't fail simply because the read would
6056 go past EOF; instead, return a short read.
6057 (tiff_load): Omit no-longer-needed casts.
6058 (Fimagemagick_types): Don't assume size fits into 'int'.
6059
3cc5a532
PE
6060 Improve hashing quality when configured --with-wide-int.
6061 * fns.c (hash_string): New function, taken from sxhash_string.
6062 Do not discard information about ASCII character case; this
6063 discarding is no longer needed.
6064 (sxhash-string): Use it. Change sig to match it. Caller changed.
6065 * lisp.h: Declare it.
6066 * lread.c (hash_string): Remove, since we now use fns.c's version.
6067 The fns.c version returns a wider integer if --with-wide-int is
6068 specified, so this should help the quality of the hashing a bit.
6069
b312a492
PE
6070 * emacs.c: Integer overflow minor fix.
6071 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6072 Define only if GNU_LINUX.
6073 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6074
dfd153ae
PE
6075 * dispnew.c: Integer signedness and overflow fixes.
6076 Remove unnecessary forward decls, that were a maintenance hassle.
6077 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6078 All uses changed.
6079 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6080 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6081 (prepare_desired_row, line_draw_cost):
6082 Use int, not unsigned, where either works.
6083 (save_current_matrix, restore_current_matrix):
6084 Use ptrdiff_t, not size_t, where either works.
6085 (init_display): Check for overflow more accurately, and without
6086 relying on undefined behavior.
6087
a81d11a3
PE
6088 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6089 Remove, replacing with the new symbols in lisp.h. All uses changed.
6090 * fileio.c (make_temp_name):
6091 * filelock.c (lock_file_1, lock_file):
6092 * xdisp.c (message_dolog):
6093 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6094 Use pMd etc. instead.
6095 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6096 replacing the pWIDE etc. symbols removed from editfns.c.
6097
3300e6fd
PE
6098 * keyboard.h (num_input_events): Now uintmax_t.
6099 This is (very slightly) less likely to mess up due to wraparound.
6100 All uses changed.
6101
fd05c7e9
PE
6102 * buffer.c: Integer signedness fixes.
6103 (alloc_buffer_text, enlarge_buffer_text):
6104 Use ptrdiff_t rather than size_t when either will do, as we prefer
6105 signed integers.
6106
903fe15d
PE
6107 * alloc.c: Integer signedness and overflow fixes.
6108 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6109 (__malloc_size_t): Default to size_t, not to int.
6110 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6111 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6112 Prefer ptrdiff_t to size_t when either would do, as we prefer
6113 signed integers.
6114 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6115 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6116 Now const. Initialize with values that are in range even if char
6117 is signed.
6118 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6119 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6120 These functions do the right thing with sizes > 2**32.
6121 (check_depth): Now ptrdiff_t, not int.
6122 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6123 Adjust to new way of storing sizes. Check for size overflow bugs
6124 in rest of code.
6125 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6126 slightly wrong anyway, as it missed one instance of
6127 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6128 (refill_memory_reserve): Omit needless cast to size_t.
6129 (mark_object_loop_halt): Mark as externally visible.
6130
ac82cc6a
PE
6131 * xselect.c: Integer signedness and overflow fixes.
6132 (Fx_register_dnd_atom, x_handle_dnd_message):
6133 Use ptrdiff_t, not size_t, since we prefer signed.
6134 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6135 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6136 x_dnd_atoms_size and x_dnd_atoms_length.
6137
c2d1e36d
PE
6138 * doprnt.c: Prefer signed to unsigned when either works.
6139 * eval.c (verror):
6140 * doprnt.c (doprnt):
6141 * lisp.h (doprnt):
6142 * xdisp.c (vmessage):
6143 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6144 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6145 prefer signed arithmetic to avoid comparison confusion.
6146 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6147 but is a bit tricky.
6148
0e926e56
PE
6149 Assume freestanding C89 headers, string.h, stdlib.h.
6150 * data.c, doprnt.c, floatfns.c, print.c:
6151 Include float.h unconditionally.
6152 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6153 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6154 * regex.c: Likewise for stddef.h, string.h.
6155 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6156 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6157 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6158 (STDC_HEADERS): Remove obsolete defines.
6159 * sysdep.c: Include limits.h unconditionally.
6160
9cfdb3ec
PE
6161 Assume support for memcmp, memcpy, memmove, memset.
6162 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6163 * regex.c (memcmp, memcpy):
6164 Remove; we assume C89 now.
6165
6166 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6167 (__malloc_safe_bcopy): Remove; no longer needed.
6168
cf950e6b 6169 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6170 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6171 well either way, and we prefer signed to unsigned.
6172
dbf38e02
LMI
61732011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6174
6175 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6176 closes the connection while we're reading (bug#9182).
6177
d6f0886c 61782011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6179
d6f0886c
JD
6180 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6181 are specified (Bug#9168).
24e0f6b1 6182
2eb1f9e6
PE
61832011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6184
6185 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6186 Found by GCC static checking and --with-wide-int on a 32-bit host.
6187
22381272 61882011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6189
6190 * xdisp.c (compute_display_string_pos): Fix logic of caching
6191 previous display string position. Initialize cached_prev_pos to
6192 -1. Fixes slow-down at the beginning of a buffer.
6193
f25e39b4
EZ
61942011-07-24 Eli Zaretskii <eliz@gnu.org>
6195
6196 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6197 for attrs[LFACE_FONTSET_INDEX].
6198
04c4b52e
PE
61992011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6200
6201 * xml.c (parse_region): Remove unused local
6202 that was recently introduced.
6203
c1734fbd
EZ
62042011-07-23 Eli Zaretskii <eliz@gnu.org>
6205
be18c5a5
EZ
6206 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6207 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6208
c1734fbd
EZ
6209 * xdisp.c (move_it_in_display_line_to): Record the best matching
6210 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6211 exit if none of the characters scanned was an exact match.
6212 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6213 when exact match is impossible due to invisible text, and the
6214 lines are truncated.
6215
a258d627
JD
62162011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6217
6218 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6219 for OSX >= 10.7.
6220
b6d5a689
EZ
62212011-07-22 Eli Zaretskii <eliz@gnu.org>
6222
0f74f785
EZ
6223 Fix a significant slow-down of cursor motion with C-n, C-p,
6224 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6225 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6226 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6227 (next_element_from_buffer): Call compute_stop_pos_backwards to
6228 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6229 base_level_stop.
6230 (reseat): Don't look for prev_stop, as that could mean a very long
6231 run.
6232 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6233 <cached_disp_overlay_modiff>: Cache for last found display string
6234 position.
551918c1 6235 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6236 about the same buffer in the same area of character positions, and
6237 the buffer wasn't changed since the time the display string
6238 position was cached.
551918c1 6239
b2d0c91a
EZ
62402011-07-22 Eli Zaretskii <eliz@gnu.org>
6241
6242 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6243 is an integer, which is important for empty lines. (Bug#9149)
6244
043604ee
CY
62452011-07-22 Chong Yidong <cyd@stupidchicken.com>
6246
6247 * frame.c (Fmodify_frame_parameters): In tty case, update the
6248 default face if necessary (Bug#4238).
6249
da4adb04
CY
62502011-07-21 Chong Yidong <cyd@stupidchicken.com>
6251
6252 * editfns.c (Fstring_to_char): No need to explain what a character
6253 is in the docstring (Bug#6576).
6254
9abd0532
LMI
62552011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6256
6257 * xml.c (parse_region): Make sure we always return a tree.
6258
36881d16
HK
62592011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6260
6261 * xml.c (parse_region): If a document contains only comments,
6262 return that, too.
6263
1e98674d
LMI
62642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6265
6266 * xml.c (make_dom): Return comments, too.
6267
590bd467
PE
62682011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6269
6270 Port to OpenBSD.
6271 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6272 and the surrounding thread.
6273 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6274 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6275 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6276 timer goes off.
6277 * s/openbsd.h (BROKEN_SIGIO): Define.
6278 * unexelf.c (unexec) [__OpenBSD__]:
6279 Don't update the .mdebug section of the Alpha COFF symbol table.
6280
f41628b2
LMI
62812011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6282
6283 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6284 (bug#8460).
6285
b59b67c5
PE
62862011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6287
15e3a074
PE
6288 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6289 This fixes some race conditions on the permissions of any newly
6290 created file.
6291
41bed37d
PE
6292 * alloc.c (valid_pointer_p): Use pipe, not open.
6293 This fixes some permissions issues when debugging.
6294
b59b67c5
PE
6295 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6296 If fchown fails to set both uid and gid, try to set just gid,
6297 as that is sometimes allowed. Adjust the file's mode to eliminate
6298 setuid or setgid bits that are inappropriate if fchown fails.
6299
925a6be7
SM
63002011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6301
6302 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6303 to compare Lisp_Objects.
6304 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6305 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6306 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6307
52968808
AS
63082011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6309
0a6a104b
AS
6310 * lread.c (read_integer): Unread even EOF character.
6311 (read1): Likewise. Properly record start position of symbol.
6312
52968808
AS
6313 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6314 symbol character follows.
6315
9e381cdd
PE
63162011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6317
6318 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6319 This works around a problem with the previous change to Fcopy_file.
6320 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6321 and without this change, GCC might complain about discarding
6322 fchown's return value.
6323
b5641435
JB
63242011-07-16 Juanma Barranquero <lekktu@gmail.com>
6325
6326 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6327
a8031457
PE
63282011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6329
6330 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6331
dd889327
LMI
63322011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6333
750c33f7
LMI
6334 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6335 it's used from the C level.
6336
dd889327
LMI
6337 * process.c: Use the same condition for POLL_FOR_INPUT in both
6338 keyboard.c and process.c (bug#1858).
6339
87e86684
LM
63402011-07-09 Lawrence Mitchell <wence@gmx.li>
6341
6342 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6343 (Fgnutls_boot): Use it.
6344
64348f40
AS
63452011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6346
6347 * doc.c (Fsubstitute_command_keys): Revert last change.
6348
1d698799
LMI
63492011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6350
f863868c
LMI
6351 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6352 quotes the next character, and doesn't affect other longer
6353 sequences (bug#8935).
6354
1d698799
LMI
6355 * lread.c (syms_of_lread): Clarify that is isn't only
6356 `eval-buffer' and `eval-defun' that's affected by
6357 `lexical-binding' (bug#8460).
6358
aa4b6df6
EZ
63592011-07-15 Eli Zaretskii <eliz@gnu.org>
6360
6361 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6362 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6363
5d856da6
PE
63642011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6365
ad6042bb
PE
6366 Fix minor problems found by static checking.
6367 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6368 (elsz): Now a signed constant, not a size_t var. We prefer signed
6369 types to unsigned, to avoid integer comparison confusion. Without
6370 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6371 "cannot optimize loop, the loop counter may overflow", a symptom
6372 of the confusion.
f00bbb22 6373 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6374 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6375
6468f31c
LMI
63762011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6377
49080b10
LMI
6378 * search.c (Fre_search_backward): Mention `case-fold-search' in
6379 all the re_search_* functions (bug#8138).
6380
6468f31c
LMI
6381 * keyboard.c (Fopen_dribble_file): Document when the file is
6382 closed (bug#8056).
6383
c965adc5
EZ
63842011-07-14 Eli Zaretskii <eliz@gnu.org>
6385
df9733bf
EZ
6386 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6387 bidi_cache_idx.
6388
0bb23927
EZ
6389 Support bidi reordering of display and overlay strings.
6390 * xdisp.c (compute_display_string_pos)
6391 (compute_display_string_end): Accept additional argument STRING.
6392 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6393 (reseat_to_string): Initialize bidi_it->string.s and
6394 bidi_it->string.schars.
6395 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6396 NULL (avoids a crash in bidi_paragraph_init).
6397 Initialize itb.string.lstring.
0bb23927
EZ
6398 (init_iterator): Call bidi_init_it only of a valid
6399 buffer position was specified. Initialize paragraph_embedding to
6400 L2R.
6401 (reseat_to_string): Initialize the bidi iterator.
6402 (display_string): If we need to ignore text properties of
6403 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6404 original value of -1 will not work with bidi.)
6405 (compute_display_string_pos): First arg is now struct
6406 `text_pos *'; all callers changed. Support display properties on
6407 Lisp strings.
6408 (compute_display_string_end): Support display properties on Lisp
6409 strings.
6410 (init_iterator, reseat_1, reseat_to_string): Initialize the
6411 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6412 when iterating on a string not from display properties).
640c8776
SM
6413 (compute_display_string_pos, compute_display_string_end):
6414 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6415 arrow keys.
6416 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6417 base_level_stop; instead, set base_level_stop to BEGV.
6418 Fixes crashes in vertical-motion.
0bb23927
EZ
6419 (next_element_from_buffer): Improve commentary for when
6420 the iterator is before prev_stop.
6421 (init_iterator): Initialize bidi_p from the default value of
6422 bidi-display-reordering, not from buffer-local value. Use the
6423 buffer-local value only if initializing for buffer iteration.
6424 (handle_invisible_prop): Support invisible properties on strings
6425 that are being bidi-reordered.
6426 (set_iterator_to_next): Support bidi reordering of C strings and
6427 Lisp strings.
6428 (next_element_from_string): Support bidi reordering of Lisp
6429 strings.
6430 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6431 (display_string): Support display of R2L glyph rows.
6432 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6433 (init_iterator): Don't initialize it->bidi_p for strings
6434 here.
6435 (reseat_to_string): Initialize it->bidi_p for strings here.
6436 (next_element_from_string, next_element_from_c_string)
6437 (next_element_from_buffer): Add xassert's for correspondence
6438 between IT's object being iterated and it->bidi_it.string
6439 structure.
6440 (face_before_or_after_it_pos): Support bidi iteration.
6441 (next_element_from_c_string): Handle the case of the first string
6442 character that is not the first one in the visual order.
6443 (get_visually_first_element): New function, refactored from common
6444 parts of next_element_from_buffer, next_element_from_string, and
6445 next_element_from_c_string.
6446 (tool_bar_lines_needed, redisplay_tool_bar)
6447 (display_menu_bar): Force left-to-right direction. Add a FIXME
6448 comment for making that be controlled by a user option.
6449 (push_it, pop_it): Save and restore the state of the
6450 bidi iterator. Save and restore the bidi_p flag.
6451 (pop_it): Iterate out of display property for string iteration as
6452 well.
6453 (iterate_out_of_display_property): Support iteration over strings.
6454 (handle_single_display_spec): Set up it->bidi_it for iteration
6455 over a display string, and call bidi_init_it.
6456 (handle_single_display_spec, next_overlay_string)
6457 (get_overlay_strings_1, push_display_prop): Set up the bidi
6458 iterator for displaying display or overlay strings.
6459 (forward_to_next_line_start): Don't use the shortcut if
6460 bidi-iterating.
6461 (back_to_previous_visible_line_start): If handle_display_prop
6462 pushed the iterator stack, restore the internal state of the bidi
6463 iterator by calling bidi_pop_it same number of times.
6464 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6465 and we are bidi-iterating, don't decrement the iterator position;
6466 instead, set the first_elt flag in the bidi iterator, to produce
6467 the same effect.
6468 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6469 (push_display_prop): xassert that we are iterating a buffer.
6470 (push_it, pop_it): Save and restore paragraph_embedding member.
6471 (handle_single_display_spec, next_overlay_string)
6472 (get_overlay_strings_1, reseat_1, reseat_to_string)
6473 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6474 correctly. Don't assume unibyte strings are not bidi-reordered.
6475 (compute_display_string_pos)
6476 (compute_display_string_end): Fix handling the case of C string.
6477 (push_it, pop_it): Save and restore from_disp_prop_p.
6478 (handle_single_display_spec, push_display_prop): Set the
6479 from_disp_prop_p flag.
6480 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6481 (pop_it): Call iterate_out_of_display_property only if we are
6482 popping after iteration over a string that came from a display
6483 property. Fix a typo in popping stretch info. Add an assertion
6484 for verifying that the iterator position is in sync with the bidi
6485 iterator.
6486 (handle_single_display_spec, get_overlay_strings_1)
6487 (push_display_prop): Fix initialization of paragraph direction for
6488 string when that of the parent object is not yet determined.
6489 (reseat_1): Call bidi_init_it to resync the bidi
6490 iterator with IT's position. (Bug#7616)
6491 (find_row_edges): If ROW->start.pos gives position
6492 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6493 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6494 Reset the from_disp_prop_p flag.
6495 (SAVE_IT, RESTORE_IT): New macros.
6496 (pos_visible_p, face_before_or_after_it_pos)
6497 (back_to_previous_visible_line_start)
6498 (move_it_in_display_line_to, move_it_in_display_line)
6499 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6500 (try_scrolling, redisplay_window, display_line): Use them when
6501 saving a temporary copy of the iterator and restoring it back.
6502 (back_to_previous_visible_line_start, reseat_1)
6503 (init_iterator): Empty the bidi cache "stack".
6504 (move_it_in_display_line_to): If iterator ended up at
6505 EOL, but we never saw any buffer positions smaller than
6506 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6507 motion in bidi-reordered lines.
6508 (move_it_in_display_line_to): Record prev_method and prev_pos
6509 immediately before the call to set_iterator_to_next. Fixes cursor
6510 motion in bidi-reordered lines with stretch glyphs and strings
6511 displayed in margins. (Bug#8133) (Bug#8867)
6512 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6513 TO_CHARPOS.
640c8776
SM
6514 (pos_visible_p): Support positions in bidi-reordered lines.
6515 Save and restore bidi cache.
0bb23927
EZ
6516
6517 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6518 (bidi_paragraph_info): Delete unused struct.
6519 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6520 (bidi_cache_start): New variable.
6521 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6522 to zero.
6523 (bidi_cache_fetch_state, bidi_cache_search)
6524 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6525 (bidi_cache_find, bidi_peek_at_next_level)
6526 (bidi_level_of_next_char, bidi_find_other_level_edge)
6527 (bidi_move_to_visually_next): Compare cache index with
6528 bidi_cache_start rather than with zero.
6529 (bidi_fetch_char): Accept new argument STRING; all callers
6530 changed. Support iteration over a string. Support strings with
6531 display properties. Support unibyte strings. Fix the type of
6532 `len' according to what STRING_CHAR_AND_LENGTH expects.
6533 (bidi_paragraph_init, bidi_resolve_explicit_1)
6534 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6535 (bidi_level_of_next_char, bidi_move_to_visually_next):
6536 Support iteration over a string.
0bb23927
EZ
6537 (bidi_set_sor_type, bidi_resolve_explicit_1)
6538 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6539 can now be zero (for strings); special values 0 and -1 were
6540 changed to -1 and -2, respectively.
6541 (bidi_char_at_pos): New function.
6542 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6543 Call it instead of FETCH_MULTIBYTE_CHAR.
6544 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6545 initialized to valid values.
6546 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6547 values.
6548 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6549 the test for valid cached positions. Fix the logic for looking up
6550 the sentinel state in the cache. GCPRO the Lisp string we are
6551 iterating.
6552 (bidi_push_it, bidi_pop_it): New functions.
6553 (bidi_initialize): Initialize the bidi cache start stack pointer.
6554 (bidi_cache_ensure_space): New function, refactored from part of
6555 bidi_cache_iterator_state. Don't assume the required size is just
6556 one BIDI_CACHE_CHUNK away.
6557 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6558 (bidi_count_bytes, bidi_char_at_pos): New functions.
6559 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6560 always valid if bidi_cache_idx is valid.
6561 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6562 is valid if it's going to be used.
6563 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6564 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6565 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6566 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6567 (bidi_find_other_level_edge, bidi_cache_start_stack):
6568 All variables related to cache indices are now EMACS_INT.
c965adc5 6569
0bb23927
EZ
6570 * dispextern.h (struct bidi_string_data): New structure.
6571 (struct bidi_it): New member `string'. Make flag members be 1-bit
6572 fields, and put them last in the struct.
640c8776
SM
6573 (compute_display_string_pos, compute_display_string_end):
6574 Update prototypes.
0bb23927
EZ
6575 (bidi_push_it, bidi_pop_it): Add prototypes.
6576 (struct iterator_stack_entry): New members bidi_p,
6577 paragraph_embedding, and from_disp_prop_p.
6578 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6579 (bidi_shelve_cache, bidi_unshelve_cache):
6580 Declare prototypes.
0bb23927
EZ
6581
6582 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6583 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6584 and vector-like objects.
6585
6586 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6587 cache around display iteration.
6588
6589 * window.c (Fwindow_end, window_scroll_pixel_based)
6590 (displayed_window_lines, Frecenter): Save and restore the bidi
6591 cache around display iteration.
6592
3bbd2265
LMI
65932011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6594
6595 * editfns.c (Fdelete_region): Clarify the use of the named
6596 parameters (bug#6788).
6597
adc47434
MR
65982011-07-14 Martin Rudalics <rudalics@gmx.at>
6599
6600 * indent.c (Fvertical_motion): Set and restore w->pointm when
6601 saving and restoring the window's buffer (Bug#9006).
6602
837c31f8
LMI
66032011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6604
6605 * editfns.c (Fstring_to_char): Clarify just what is returned
6606 (bug#6576). Text by Eli Zaretskii.
6607
ac389d0c
JB
66082011-07-13 Juanma Barranquero <lekktu@gmail.com>
6609
6610 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6611
0be0ce47
EZ
66122011-07-13 Eli Zaretskii <eliz@gnu.org>
6613
6614 * buffer.c (mmap_find): Fix a typo.
6615
cd18e7e3
JB
66162011-07-13 Johan Bockgård <bojohan@gnu.org>
6617
6618 Fix execution of x selection hooks.
6619 * xselect.c (Qx_lost_selection_functions)
6620 (Qx_sent_selection_functions): New vars.
6621 (syms_of_xselect): DEFSYM them.
6622 (x_handle_selection_request): Pass Qx_sent_selection_functions
6623 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6624 (x_handle_selection_clear,x_clear_frame_selections):
6625 Pass Qx_lost_selection_functions rather than
6626 Vx_lost_selection_functions to Frun_hook_with_args.
6627
47ea7f44
PE
66282011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6629
ac389d0c 6630 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6631 The old code sometimes used this field without initializing it.
6632
47ea7f44
PE
6633 * alloc.c (gc_sweep): Don't read past end of array.
6634 In theory, the old code could also have corrupted Emacs internals,
6635 though it'd be very unlikely.
6636
bc985c87
AS
66372011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6638
6639 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6640 argument. (Bug#4026)
bc985c87 6641
0cf34688
LMI
66422011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6643
b3dadd76
LMI
6644 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6645 key" (bug#4257).
6646
0cf34688
LMI
6647 * window.c (Fset_window_start): Doc fix (bug#4199).
6648 (Fset_window_hscroll): Ditto.
6649
270768cd
PE
66502011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6651
077e3dda 6652 Fix minor new problems caught by GCC 4.6.1.
270768cd 6653 * term.c (init_tty): Remove unused local.
490011a6 6654 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6655 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6656 not used otherwise.
270768cd 6657
b1f58454
CY
66582011-07-12 Chong Yidong <cyd@stupidchicken.com>
6659
6660 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6661
22b9578d
LMI
66622011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6663
6e70ab07
LMI
6664 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6665 are the mini-buffer and the echo area (bug#3320).
6666
22b9578d
LMI
6667 * term.c (init_tty): Remove support for supdup, c10 and perq
6668 terminals, which are no longer supported (bug#1482).
6669
8974cc9f
JB
66702011-07-10 Johan Bockgård <bojohan@gnu.org>
6671
6672 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6673
a560d974
JD
66742011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6675
6676 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6677 for non-popups (Bug#3642).
6678
1dae0f0a
AS
66792011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6680
268c2c36 6681 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6682 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6683 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6684 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6685 * data.c (fmod): Likewise.
6686 * dispnew.c (swap_glyphs_in_rows): Likewise.
6687 * emacs.c (memory_warning_signal): Likewise.
6688 * floatfns.c (float_error): Likewise.
6689 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6690 (otf_open, font_otf_capability, generate_otf_features)
6691 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6692 Likewise.
6693 * image.c (pbm_read_file): Likewise.
6694 * indent.c (string_display_width): Likewise.
6695 * intervals.c (check_for_interval, search_for_interval)
6696 (inc_interval_count, count_intervals, root_interval)
6697 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6698 * lread.c (defalias): Likewise.
268c2c36 6699 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6700 * regex.c (set_image_of_range_1, set_image_of_range)
6701 (regex_grow_registers): Likewise.
6702 * sysdep.c (strerror): Likewise.
6703 * termcap.c (valid_filename_p, tprint, main): Likewise.
6704 * tparam.c (main): Likewise.
6705 * unexhp9k800.c (run_time_remap, save_data_space)
6706 (update_file_ptrs, read_header, write_header, calculate_checksum)
6707 (copy_file, copy_rest, display_header): Likewise.
6708 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6709 Likewise.
6710 * xdisp.c (check_it): Likewise.
6711 * xfaces.c (register_color, unregister_color, unregister_colors):
6712 Likewise.
6713 * xfns.c (print_fontset_result): Likewise.
6714 * xrdb.c (member, fatal, main): Likewise.
6715
99033785
PE
67162011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6717
6718 Fix minor problems found by static checking (Bug#9031).
6719 * chartab.c (char_table_set_range, map_sub_char_table):
6720 Remove unused locals.
6721 (uniprop_table): Now static.
6722 * composite.c (_work_char): Remove unused static var.
6723
9cb2ac56
JB
67242011-07-09 Juanma Barranquero <lekktu@gmail.com>
6725
6726 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6727
f25661f0
JD
67282011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6729
6730 * gtkutil.c (qttip_cb): Remove code without function.
6731
8278c4fe
EZ
67322011-07-09 Eli Zaretskii <eliz@gnu.org>
6733
6734 * w32.c (pthread_sigmask): New stub.
6735
1692ae2d 67362011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6737
8a6ebd58 6738 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6739 sigprocmask is portable only for single-threaded applications, and
6740 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6741 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6742 (LIBES): Use it.
6743 * callproc.c (Fcall_process):
6744 * process.c (create_process):
6745 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6746 Use pthread_sigmask, not sigprocmask.
123403e4 6747
1b854618
JD
67482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6749
6750 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6751 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6752 wrong (Bug#8591).
6753
3fe4b549
JD
67542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6755
0ce7e563
JD
6756 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6757 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6758 (xg_hide_tooltip): Fix comment.
6759
3fe4b549
JD
6760 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6761 in registerServicesMenuSendTypes.
6762 (validRequestorForSendType): Don't check ns_return_types.
6763
6764 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6765 ns_return_type.
6766
5df75e47
JR
67672011-07-08 Jason Rumney <jasonr@gnu.org>
6768
22610910
JR
6769 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6770 SH_SHOW for hidden windows (Bug#5482).
6771
5df75e47
JR
6772 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6773 frame struct members of non-existent frames (Bug#6284).
6774
699c10bd
JD
67752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6776
4393663b
JD
6777 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6778 variable firstTime not needed on OSX >= 10.6.
6779 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6780 >= 10.5. Use setKnobProportion, setDoubleValue.
6781
6782 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6783 (MAC_OS_X_VERSION_10_5): Define if not defined.
6784 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6785 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6786 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6787
6788 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6789 cString and lossyCString on OSX >= 10.4
6790
58179cce 6791 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6792 sizeToFit on OSX >= 10.2.
6793
6794 * nsimage.m (allocInitFromFile): Don't use deprecated method
6795 bestRepresentationForDevice on OSX >= 10.6.
6796
6797 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6798 to avoid warning.
6799
6800 * emacs.c: Declare unexec_init_emacs_zone.
6801
a63e0781
JD
6802 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6803
699c10bd
JD
6804 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6805
6806 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6807 on svcsMenu (Bug#8842).
6808
6809 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6810 ns_return_types.
6811 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6812
6813 * nsterm.m (QUTF8_STRING): Declare.
6814 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6815 (validRequestorForSendType): Return type is (id).
6816 Change indexOfObjectIdenticalTo to indexOfObject.
6817 Check if we have local selection before returning self (Bug#8842).
6818 (writeSelectionToPasteboard): Put local selection into paste board
6819 if we have a local selection (Bug#8842).
6820 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6821
6822 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6823 (ns_get_local_selection): Declare.
6824
54e10184
LMI
68252011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6826
9888ff71
LMI
6827 * keymap.c (describe_map_tree): Don't insert a double newline at
6828 the end of the buffer (bug#1169) and return whether we inserted
6829 something.
6830
54e10184
LMI
6831 * callint.c (Fcall_interactively): Change "reading args" to
6832 "providing args" to try to clarify what it does (bug#1010).
6833
15fa4783
KH
68342011-07-07 Kenichi Handa <handa@m17n.org>
6835
6836 * composite.c (composition_compute_stop_pos): Ignore a static
6837 composition starting before CHARPOS (Bug#8915).
6838
6839 * xdisp.c (handle_composition_prop): Likewise.
6840
a8815b00
EZ
68412011-07-07 Eli Zaretskii <eliz@gnu.org>
6842
6843 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6844 (Bug#9015)
6845
ef7b981d 68462011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6847
6848 * character.h (unicode_category_t): New enum type.
6849
6850 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6851 (Qchar_code_property_table): New variable.
6852 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6853 (UNIPROP_COMPRESSED_FORM_P): New macros.
6854 (char_table_ascii): Uncompress the compressed values.
6855 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6856 Uncompress the compressed values.
ac389d0c 6857 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6858 (char_table_ref_and_range): Uncompress the compressed values.
6859 (sub_char_table_set): New arg is_uniprop. Callers changed.
6860 Uncompress the compressed values.
6861 (sub_char_table_set_range): Args changed. Callers changed.
6862 (char_table_set_range): Adjuted for the above change.
6863 (map_sub_char_table): Delete args default_val and parent. Add arg
6864 top. Give decoded values to a Lisp function.
640c8776 6865 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6866 values to a Lisp function. Gcpro more variables.
6867 (uniprop_table_uncompress)
6868 (uniprop_decode_value_run_length): New functions.
6869 (uniprop_decoder, uniprop_decoder_count): New variables.
6870 (uniprop_get_decoder, uniprop_encode_value_character)
6871 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6872 New functions.
6873 (uniprop_encoder, uniprop_encoder_count): New variables.
6874 (uniprop_get_encoder, uniprop_table)
6875 (Funicode_property_table_internal, Fget_unicode_property_internal)
6876 (Fput_unicode_property_internal): New functions.
6877 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6878 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6879 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6880 char-code-property-alist.
6881
640c8776 6882 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6883 Vunicode_category_table.
6884
640c8776 6885 * font.c (font_range): Adjust for the change of
c805dec0
KH
6886 Vunicode_category_table.
6887
76b397fb
DN
68882011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6889
6890 * m/iris4d.h: Remove file, move contents ...
6891 * s/irix6-5.h: ... here.
6892
22b4128e
PE
68932011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6894
6895 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6896 * alloc.c (mark_buffer):
6897 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6898 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6899 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6900 This isn't true in general, and it's particularly not true
6901 if Emacs is configured with --with-wide-int.
6902 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6903 New macros, used in the buffer.c change.
6904
869795d6
JD
69052011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6906
6907 * xsettings.c: Use both GConf and GSettings if both are available.
6908 (store_config_changed_event): Add comment.
6909 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6910 (store_tool_bar_style_changed): New functions.
5e617bc2 6911 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6912 (struct xsettings): Move font inside HAVE_XFT.
6913 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6914 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6915 Move inside HAVE_XFT.
640c8776 6916 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6917 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6918 also.
6919 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6920 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6921 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6922 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6923 (parse_settings): Move check for font inside HAVE_XFT.
6924 (read_settings, apply_xft_settings): Add comment.
6925 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6926 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6927 call store_font_name_changed.
6928 (xft_settings_event): Add comment.
6929 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6930 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6931 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6932 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6933 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6934 (xsettings_get_system_font, xsettings_get_system_normal_font):
6935 Add comment.
869795d6 6936
d8ed26bd
PE
69372011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6938
6939 Random fixes. E.g., (random) never returned negative values.
6940 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6941 subseconds part to the entropy, as that's a bit more random.
6942 Prefer signed to unsigned, since the signedness doesn't matter and
6943 in general we prefer signed. When given a limit, use a
6944 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6945 latter isn't right if USE_2_TAGS_FOR_INTS.
6946 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6947 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6948
cabf1cac
SM
69492011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6950
6951 * textprop.c (text_property_stickiness):
6952 Obey Vtext_property_default_nonsticky.
6953 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6954 * w32fns.c (syms_of_w32fns):
6955 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6956
6e9b2be9
PE
69572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6958
6959 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6960 This is more efficient than Ffile_directory_p and avoids a minor race.
6961
90186c68
LMI
69622011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6963
7c301272
LMI
6964 * buffer.c (Foverlay_put): Say what the return value is
6965 (bug#7835).
6966
c4f2d8d4
LMI
6967 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6968 is a directory before asking whether to use the file name
6969 (bug#7564).
ad637907
LMI
6970 (barf_or_query_if_file_exists): Make the "File is a directory"
6971 error be more correct.
c4f2d8d4 6972
90186c68
LMI
6973 * fns.c (Frequire): Remove the mention of the .gz files, since
6974 that's installation-specific, but keep the mention of
6975 `get-load-suffixes'.
6976
da64016e
PE
69772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6978
6979 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6980 Report string overflow if the output is too long.
6981
7d47b580
JB
69822011-07-04 Juanma Barranquero <lekktu@gmail.com>
6983
a555cb87
JB
6984 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6985 (syms_of_gnutls): Remove duplicate DEFSYM for
6986 Qgnutls_bootprop_verify_hostname_error, an error for
6987 Qgnutls_bootprop_verify_error (which is no longer used).
6988
7d47b580
JB
6989 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6990 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6991 Also (re)move comments that are misplaced or no longer relevant.
6992
1e49bfab
LMI
69932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6994
6995 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6996
1485f4c0
CY
69972011-07-03 Chong Yidong <cyd@stupidchicken.com>
6998
6999 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7000 and background color parameters if they have been changed.
7001
a9ab721e
LMI
70022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7003
7004 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7005
cf7cff57
PE
70062011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7007
2e13213d
PE
7008 * xsettings.c (SYSTEM_FONT): Define only when used.
7009 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7010
cf7cff57
PE
7011 * keymap.c (access_keymap_1): Now static.
7012
7a8e04f7
CY
70132011-07-02 Chong Yidong <cyd@stupidchicken.com>
7014
7015 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7016 leave any prefix arg for the up event (Bug#1586).
7017
61352f62
LMI
70182011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7019
69bb1ef7
LMI
7020 * lread.c (syms_of_lread): Mention single symbols defined by
7021 `defvar' or `defconst' (bug#7154).
7022
61352f62 7023 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7024 (Frequire): Mention get-load-suffixes.
61352f62 7025
28545e04
MR
70262011-07-02 Martin Rudalics <rudalics@gmx.at>
7027
7028 * window.h (window): Remove clone_number slot.
7029 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7030 Remove.
7031 (make_parent_window, make_window, saved_window)
7032 (Fset_window_configuration, save_window_save): Don't deal with
7033 clone numbers.
7034 * buffer.c (Qclone_number): Remove declaration.
7035 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7036
3349e122
SM
70372011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7038
7039 Add multiple inheritance to keymaps.
7040 * keymap.c (Fmake_composed_keymap): New function.
7041 (Fset_keymap_parent): Simplify.
7042 (fix_submap_inheritance): Remove.
7043 (access_keymap_1): New function extracted from access_keymap to handle
7044 embedded parents and handle lists of maps.
7045 (access_keymap): Use it.
7046 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7047 (Fcopy_keymap): Handle embedded parents.
7048 (Fcommand_remapping, define_as_prefix): Simplify.
7049 (Fkey_binding): Simplify.
7050 (syms_of_keymap): Move minibuffer-local-completion-map,
7051 minibuffer-local-filename-completion-map,
7052 minibuffer-local-must-match-map, and
7053 minibuffer-local-filename-must-match-map to Elisp.
7054 (syms_of_keymap): Defsubr make-composed-keymap.
7055 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7056 (parse_menu_item): Trivial simplification.
7057
3279eb87
GM
70582011-07-01 Glenn Morris <rgm@gnu.org>
7059
7060 * Makefile.in (SETTINGS_LIBS): Fix typo.
7061
4550efdf
KI
70622011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7063
7064 * coding.c (Fencode_coding_string): Record the last coding system
7065 used, as the function doc string says (bug#8738).
7066
0949d2b6
JD
70672011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7068
7069 * xsettings.c (store_monospaced_changed): Take new font as arg and
7070 check for change against current_mono_font.
7071 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7072 (emacs_settings_constructor, emacs_settings_get_property)
7073 (emacs_settings_set_property, emacs_settings_class_init)
7074 (emacs_settings_init, gsettings_obj): Remove.
7075 (something_changedCB): New function for HAVE_GSETTINGS.
7076 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7077 with value as argument.
7078 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7079 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7080 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7081 "changed".
7082
7083 * xgselect.c: Add defined (HAVE_GSETTINGS).
7084 (xgselect_initialize): Ditto.
7085
7086 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7087 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7088 xg_select.
7089
bbc6b304
PE
70902011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7091
7092 * eval.c (struct backtrace): Simplify and port the data structure.
7093 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7094 signed bit field, as this assumption is not portable and it makes
7095 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7096 "char debug_on_exit : 1" as this is not portable either; instead,
7097 use the portable "unsigned int debug_on_exit : 1". Remove unused
7098 member evalargs. Remove obsolete comments about cc bombing out.
7099
9851bfc5
JD
71002011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7101
51bb811f 7102 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7103 Let HAVE_GSETTINGS override HAVE_GCONF.
7104 (store_monospaced_changed): New function.
7105 (EMACS_SETTINGS): A new type derived from GObject to handle
7106 GSettings notifications.
7107 (emacs_settings_constructor, emacs_settings_get_property)
7108 (emacs_settings_set_property, emacs_settings_class_init):
7109 New functions.
7110 (gsettings_client, gsettings_obj): New variables.
7111 (GSETTINGS_SCHEMA): New define.
7112 (something_changedCB): Call store_monospaced_changed.
7113 (init_gsettings): New function.
7114 (xsettings_initialize): Call init_gsettings.
7115 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7116 to NULL.
7117
640c8776 7118 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7119 GCONF_CFLAGS/LIBS.
7120
5386012d
MR
71212011-06-29 Martin Rudalics <rudalics@gmx.at>
7122
7123 * window.c (resize_root_window, grow_mini_window)
7124 (shrink_mini_window): Rename Qresize_root_window to
7125 Qwindow_resize_root_window and Qresize_root_window_vertically to
7126 Qwindow_resize_root_window_vertically.
7127
f13e0b08
PE
71282011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7129
7130 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7131
94515237
JB
71322011-06-27 Juanma Barranquero <lekktu@gmail.com>
7133
7134 * makefile.w32-in: Redesign dependencies so they reflect more
7135 clearly which files are directly included by each source file,
7136 and not through other includes.
7137
e43b6e43
MR
71382011-06-27 Martin Rudalics <rudalics@gmx.at>
7139
7140 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7141 (sort_overlays, overlay_strings): When an overlay's clone number
7142 matches the window's clone number process the overlay even if
7143 the overlay's window property doesn't match the current window.
7144
d68443dc
MR
7145 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7146 (Fwindow_hchild): Rename to Fwindow_left_child.
7147 (Fwindow_next): Rename to Fwindow_next_sibling.
7148 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7149 (resize_window_check): Rename to window_resize_check.
7150 (resize_window_apply): Rename to window_resize_apply.
7151 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7152 (Fdelete_other_windows_internal, resize_frame_windows)
7153 (Fsplit_window_internal, Fdelete_window_internal)
7154 (grow_mini_window, shrink_mini_window)
7155 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7156
c7e73be5
JD
71572011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7158
7159 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7160 (emacs_fixed_set_min_size): Remove.
7161 (emacs_fixed_new): Take frame as argument.
7162
7163 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7164 (_EmacsFixedPrivate): Remove minwidth/height.
7165 Add struct frame *f.
7166 (emacs_fixed_init): Initialize priv->f.
7167 (get_parent_class, emacs_fixed_set_min_size): Remove.
7168 (emacs_fixed_new): Set priv->f to argument.
7169 (emacs_fixed_get_preferred_width)
7170 (emacs_fixed_get_preferred_height): Use min_width/height from
7171 frames size_hint to set minimum and natural (Bug#8919).
7172 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7173 and use min_width/height from frames size_hint to set
7174 min_width/height (Bug#8919).
7175
7176 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7177 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7178 Fix indentation.
c7e73be5 7179
cf99dcf8
EZ
71802011-06-26 Eli Zaretskii <eliz@gnu.org>
7181
7182 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7183 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7184 called at ZV.
7185
029529ac
CY
71862011-06-26 Chong Yidong <cyd@stupidchicken.com>
7187
7188 * process.c (wait_reading_process_output): Bypass select if
7189 waiting for a cell while ignoring keyboard input, and input is
7190 pending. Suggested by Jan Djärv (Bug#8869).
7191
7a7ef429
PE
71922011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7193
7194 Use gnulib's dup2 module instead of rolling our own.
7195 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7196
11fdef7d 71972011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7198
7199 * dispnew.c (scrolling_window): Before scrolling, turn off a
7200 mouse-highlight in the window being scrolled.
7201
cd3520a4
JB
72022011-06-24 Juanma Barranquero <lekktu@gmail.com>
7203
7204 Move DEFSYM to lisp.h and use everywhere.
7205
7206 * character.h (DEFSYM): Move declaration...
7207 * lisp.h (DEFSYM): ...here.
7208
7209 * gnutls.c:
7210 * minibuf.c:
7211 * w32menu.c:
7212 * w32proc.c:
7213 * w32select.c: Don't include character.h.
7214
7215 * alloc.c (syms_of_alloc):
7216 * buffer.c (syms_of_buffer):
7217 * bytecode.c (syms_of_bytecode):
7218 * callint.c (syms_of_callint):
7219 * casefiddle.c (syms_of_casefiddle):
7220 * casetab.c (init_casetab_once):
7221 * category.c (init_category_once, syms_of_category):
7222 * ccl.c (syms_of_ccl):
7223 * cmds.c (syms_of_cmds):
7224 * composite.c (syms_of_composite):
7225 * dbusbind.c (syms_of_dbusbind):
7226 * dired.c (syms_of_dired):
7227 * dispnew.c (syms_of_display):
7228 * doc.c (syms_of_doc):
7229 * editfns.c (syms_of_editfns):
7230 * emacs.c (syms_of_emacs):
7231 * eval.c (syms_of_eval):
7232 * fileio.c (syms_of_fileio):
7233 * fns.c (syms_of_fns):
7234 * frame.c (syms_of_frame):
7235 * fringe.c (syms_of_fringe):
7236 * insdel.c (syms_of_insdel):
7237 * keymap.c (syms_of_keymap):
7238 * lread.c (init_obarray, syms_of_lread):
7239 * macros.c (syms_of_macros):
7240 * msdos.c (syms_of_msdos):
7241 * print.c (syms_of_print):
7242 * process.c (syms_of_process):
7243 * search.c (syms_of_search):
7244 * sound.c (syms_of_sound):
7245 * syntax.c (init_syntax_once, syms_of_syntax):
7246 * terminal.c (syms_of_terminal):
7247 * textprop.c (syms_of_textprop):
7248 * undo.c (syms_of_undo):
7249 * w32.c (globals_of_w32):
7250 * window.c (syms_of_window):
7251 * xdisp.c (syms_of_xdisp):
7252 * xfaces.c (syms_of_xfaces):
7253 * xfns.c (syms_of_xfns):
7254 * xmenu.c (syms_of_xmenu):
7255 * xsettings.c (syms_of_xsettings):
7256 * xterm.c (syms_of_xterm): Use DEFSYM.
7257
4228cf16
TZ
72582011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7259
cd3520a4 7260 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7261
7fcccf1e
PE
72622011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7263
7efb4e0e
PE
7264 Integer and buffer overflow fixes (Bug#8873).
7265
ff5844ad
PE
7266 * print.c (printchar, strout): Check for string overflow.
7267 (PRINTPREPARE, printchar, strout):
7268 Don't set size unless allocation succeeds.
7269
90532f02
PE
7270 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7271 for sizes. Check for string overflow more accurately.
7272 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7273
6d84508d
PE
7274 * macros.c: Integer and buffer overflow fixes.
7275 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7276 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7277 Use ptrdiff_t, not int, for sizes.
7278 Don't increment bufsize until after realloc succeeds.
7279 Check for size-calculation overflow.
7280 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7281
437b2cb4
PE
7282 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7283
8b9ac8b4
PE
7284 * lread.c: Integer overflow fixes.
7285 (read_integer): Radix is now EMACS_INT, not int,
7286 to improve quality of diagnostics for out-of-range radices.
7287 Calculate buffer size correctly for out-of-range radices.
7288 (read1): Check for integer overflow in radices, and in
7289 read-circle numbers.
82cb60d3
PE
7290 (read_escape): Avoid int overflow.
7291 (Fload, openp, read_buffer_size, read1)
7292 (substitute_object_recurse, read_vector, read_list, map_obarray):
7293 Use ptrdiff_t, not int, for sizes.
7294 (read1): Use EMACS_INT, not int, for sizes.
20270765 7295 Check for size overflow.
8b9ac8b4 7296
7fcccf1e
PE
7297 * image.c (cache_image): Check for size arithmetic overflow.
7298
bfbbd7e7
PE
7299 * lread.c: Integer overflow issues.
7300 (saved_doc_string_size, saved_doc_string_length)
7301 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7302 Now ptrdiff_t, not int.
7303 (read1): Don't assume doc string length fits in int. Check for
7304 out-of-range doc string lengths.
7305 (read_list): Don't assume file position fits in int.
39019e54 7306 (read_escape): Check for hex character overflow.
bfbbd7e7 7307
4e323265
LL
73082011-06-22 Leo Liu <sdl.web@gmail.com>
7309
7310 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7311 Move to minibuffer.el.
7312
85fece3e
PE
73132011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7314
20b84ce9 7315 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7316 The following patches are for when GLYPH_DEBUG && !XASSERT.
7317 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7318 * dispnew.c (flush_stdout):
7319 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7320 Mark as externally visible.
7321 * dispnew.c (check_window_matrix_pointers): Now static.
7322 * dispnew.c (window_to_frame_vpos):
7323 * xfns.c (unwind_create_frame):
7324 * xterm.c (x_check_font): Remove unused local.
7325 * scroll.c (CHECK_BOUNDS):
7326 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7327 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7328 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7329 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7330 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7331 Now static.
7332 (debug_method_add): Use va_list and vsprintf rather than relying
7333 on undefined behavior with wrong number of arguments.
7334 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7335 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7336 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7337 since we're not interested in debugging glyphs with old libraries.
7338 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7339 GCC 4.6.0's static checking.
7340
0766b489
PE
73412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7342
31fd4b32
PE
7343 Integer overflow and signedness fixes (Bug#8873).
7344 A few related buffer overrun fixes, too.
7345
b79e8648
PE
7346 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7347
0766b489
PE
7348 * dispextern.h (struct face.stipple):
7349 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7350 (x_bitmap_mask, x_allocate_bitmap_record)
7351 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7352 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7353 (x_create_bitmap_from_xpm_data):
7354 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7355 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7356 (.bitmaps_last):
7357 * xfaces.c (load_pixmap):
7358 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7359 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7360 (.bitmaps_last, struct x_output.icon_bitmap):
7361 Use ptrdiff_t, not int, for bitmap indexes.
7362 (x_allocate_bitmap_record): Check for size overflow.
7363 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7364
b081724f
PE
7365 Use ptrdiff_t, not int, for overlay counts.
7366 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7367 * editfns.c (overlays_around, get_pos_property):
7368 * textprop.c (get_char_property_and_overlay):
7369 * xdisp.c (next_overlay_change, note_mouse_highlight):
7370 * xfaces.c (face_at_buffer_position):
21514da7
PE
7371 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7372 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7373 (Fnext_overlay_change, Fprevious_overlay_change)
7374 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7375 Use ptrdiff_t, not int, for sizes.
21514da7 7376 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7377
3de73e5e
PE
7378 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7379
2606c57b
PE
7380 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7381 (x_session_initialize): Do not assume string length fits in int.
7382
aaafe47a
PE
7383 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7384 This is unlikely, but can occur if DPI is outlandish.
7385
2674ddc8 7386 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7387 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7388
28154962
PE
7389 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7390 * xrdb.c (magic_file_p, search_magic_path):
7391 Omit last arg SUFFIX; it was always 0. All callers changed.
7392 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7393
7de51af5
PE
7394 * xfont.c (xfont_match): Avoid need for strlen.
7395
25ed6cc3
PE
7396 * xfns.c: Don't assume strlen fits in int.
7397 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7398
4eab31dd
PE
7399 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7400 not unsigned long, as we prefer signed integers. All callers changed.
7401 Detect integer overflow in repeat count.
7402 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7403 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7404
171e2a58
PE
7405 * termcap.c: Don't assume sizes fit in int and never overflow.
7406 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7407 (gobble_line): Check for size-calculation overflow.
7408
ad39faca 7409 * minibuf.c (Fread_buffer):
6e5bb2dc 7410 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7411 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7412 Don't assume string length fits in int.
7413
52c61c22 7414 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7415 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7416
b5b8c9e5
PE
7417 * font.c: Don't assume string length fits in int.
7418 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7419 Use ptrdiff_t, not int.
ccd6111c
PE
7420 (font_intern_prop): Don't assume string length fits in int.
7421 Don't assume integer property fits in fixnum.
7422 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7423
882f0d81 7424 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7425 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7426 Reformulate so as not to need the command string.
7427 Invoke gzip -cd rather than gunzip, as it's more portable.
7428 (lock_info_type, lock_file_1, lock_file):
7429 Don't assume pid_t and time_t fit in unsigned long.
7430 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7431 (current_lock_owner): Prefer signed type for sizes.
7432 Use memcpy, not strncpy, where memcpy is what is really wanted.
7433 Don't assume (via atoi) that time_t and pid_t fit in int.
7434 Check for time_t and/or pid_t out of range, e.g., via a network share.
7435 Don't alloca where an auto var works fine.
7436
93f4cf88
PE
7437 * fileio.c: Fix some integer overflow issues.
7438 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7439 Don't assume string length fits in int.
7440 (directory_file_name): Don't assume string length fits in long.
7441 (make_temp_name): Don't assume pid fits in int, or that its print
7442 length is less than 20.
7443
f3e92b69
PE
7444 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7445
1bfdaf10
PE
7446 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7447
35016e9a
PE
7448 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7449
3d1e65a1
PE
7450 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7451 We prefer signed integers, even for size calculations.
7452
0b963a93
PE
7453 * emacs.c: Don't assume string length fits in 'int'.
7454 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7455 (main): Don't invoke strlen when not needed.
7456
573f4b54
PE
7457 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7458 (XD_DEBUG_MESSAGE): Don't waste a byte.
7459
989f33ba
PE
7460 * callproc.c (getenv_internal_1, getenv_internal)
7461 (Fgetenv_internal):
965d34eb
PE
7462 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7463
e4d29b33
PE
7464 * lread.c (invalid_syntax): Omit length argument.
7465 All uses changed. This doesn't fix a bug, but it simplifies the
7466 code away from its former Hollerith-constant appearance, and it's
7467 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7468 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7469
eb49b136
PE
7470 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7471 This didn't break anything, but it didn't help either.
7472 It's confusing to put a bogus integer in a place where the actual
7473 value does not matter.
9f62aeb1 7474 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7475 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7476
15375a22
PE
7477 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7478 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7479 implementation.
b61cc01c
PE
7480 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7481 We prefer signed types, and the value cannot exceed the EMACS_INT
7482 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7483 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7484 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7485 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7486
53b2623d
PE
7487 * indent.c (sane_tab_width): New function.
7488 (current_column, scan_for_column, Findent_to, position_indentation)
7489 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7490 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7491
51cab52b 7492 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7493
f2ed8a70
PE
7494 * lisp.h (lint_assume): New macro.
7495 * composite.c (composition_gstring_put_cache):
7496 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7497
abe80cc6
PE
7498 * editfns.c, insdel.c:
7499 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7500
b02c740e
PE
7501 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7502
ebc96716
PE
7503 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7504
b4e50fa0 7505 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7506 Use much-faster test for byte-length change.
311d5d7c 7507 Don't assume string byte-length fits in 'int'.
a4cf38e4 7508 Check that character arg fits in 'int'.
85461888 7509 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7510
c0c1ee9f
PE
7511 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7512
a498d7f4
PE
7513 * fns.c (concat): Catch string overflow earlier.
7514 Do not rely on integer wraparound.
7515
51cab52b
PE
7516 * dispextern.h (struct it.overlay_strings_charpos)
7517 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7518 * xdisp.c (forward_to_next_line_start)
7519 (back_to_previous_visible_line_start)
7520 (reseat_at_next_visible_line_start, next_element_from_buffer):
7521 Don't arbitrarily truncate the value of 'selective' to int.
7522
76031fad
PE
7523 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7524
5eb55db9
PE
7525 * composite.c: Don't truncate sizes to 'int'.
7526 (composition_gstring_p, composition_reseat_it)
7527 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7528 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7529 not EMACS_UINT, for indexes.
5eb55db9 7530
0703a717
PE
7531 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7532
d6202519
PE
7533 * buffer.c: Include <verify.h>.
7534 (struct sortvec.priority, struct sortstr.priority):
8961a454 7535 Now EMACS_INT, not int.
c20998a7 7536 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7537 (struct sortstr.size, record_overlay_string)
7538 (struct sortstrlist.size, struct sortlist.used):
7539 Don't truncate size to int.
7540 (record_overlay_string): Check for size-calculation overflow.
d6202519 7541 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7542
d5a19415
JM
75432011-06-22 Jim Meyering <meyering@redhat.com>
7544
029529ac 7545 Don't leak an XBM-image-sized buffer
d5a19415
JM
7546 * image.c (xbm_load): Free the image buffer after using it.
7547
a9041e6c
PE
75482011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7549
7550 Port to Sun C.
7551 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7552 that Sun C diagnosed.
7553 * fns.c (secure_hash): Fix pointer signedness issue.
7554 * intervals.c (static_offset_intervals): New function.
7555 (offset_intervals): Use it.
7556
7f3f739f
LL
75572011-06-21 Leo Liu <sdl.web@gmail.com>
7558
7559 * deps.mk (fns.o):
7560 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7561 sha512.h.
7562
7563 * fns.c (secure_hash): Rename from crypto_hash_function and change
7564 the first arg to accept symbols.
5b66d427 7565 (Fsecure_hash): New primitive.
7f3f739f
LL
7566 (syms_of_fns): New symbols.
7567
76147d94
DD
75682011-06-20 Deniz Dogan <deniz@dogan.se>
7569
7570 * process.c (Fset_process_buffer): Clarify return value in
7571 docstring.
7572
7d7d0045
CY
75732011-06-18 Chong Yidong <cyd@stupidchicken.com>
7574
7575 * dispnew.c (add_window_display_history): Use BVAR.
7576
7577 * xdisp.c (debug_method_add): Use BVAR.
7578 (check_window_end, dump_glyph_matrix, dump_glyph)
7579 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7580
7581 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7582 Likewise.
7583
7584 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7585 check till after the cache is created in init_frame_faces.
7586
ff2bc410
SM
75872011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7588
7589 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7590
28177add
PE
75912011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7592
dd3482fe
PE
7593 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7594 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7595 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7596
393d71f3 7597 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7598 * fileio.c (Finsert_file_contents):
7599 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7600 Remove the old (too-loose) buffer overflow checks.
7601 They weren't needed, since make_gap checks for buffer overflow.
7602 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7603 The old code merely checked for Emacs fixnum overflow, and relied
7604 on undefined (wraparound) behavior. The new code avoids undefined
7605 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7606
2e6813b0 7607 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7608 Tune. Don't use wider integers than needed. Don't use alloca.
7609 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7610
599a9e4f
PE
7611 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7612
99561444
PE
7613 * insdel.c, lisp.h (buffer_overflow): New function.
7614 (insert_from_buffer_1, replace_range, replace_range_2):
7615 * insdel.c (make_gap_larger):
7616 * editfns.c (Finsert_char):
7617 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7618
28177add
PE
7619 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7620
e69dafad
PE
76212011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7622
4baa020d 7623 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7624
b1c46f02
PE
7625 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7626 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7627
e69dafad
PE
7628 * fileio.c: Don't assume EMACS_INT fits in off_t.
7629 (emacs_lseek): New static function.
7630 (Finsert_file_contents, Fwrite_region): Use it.
7631 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7632
566684ea
PE
7633 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7634
e6966cd6
PE
7635 * fns.c: Don't overflow int when computing a list length.
7636 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7637 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7638 truncation on 64-bit hosts. Check for QUIT every
7639 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7640 faster and is responsive enough.
7641 (Flength): Report an error instead of overflowing an integer.
7642 (Fsafe_length): Return a float if the value is not representable
7643 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7644 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7645 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7646
dd0b0efb
PE
7647 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7648 (header_size, word_size): New constants.
7649 (allocate_vectorlike): Don't check size overflow here.
7650 (allocate_vector): Check it here instead, since this is the only
7651 caller of allocate_vectorlike that could cause overflow.
7652 Check that the new vector's length is representable as a fixnum.
7653
86fe5cfe
PE
7654 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7655 The previous code was bogus. For example, next_almost_prime (32)
7656 returned 39, which is undesirable as it is a multiple of 3; and
7657 next_almost_prime (24) returned 25, which is a multiple of 5 so
7658 why was the code bothering to check for multiples of 7?
7659
80e88859
PE
7660 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7661
4a2f0ad6
PE
7662 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7663
f66c7cf8
PE
7664 Variadic C functions now count arguments with ptrdiff_t.
7665 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7666 Back then I didn't know that the Emacs coding style prefers signed int.
7667 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7668 were being counted with int, which may truncate counts on 64-bit
7669 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7670 * lisp.h (struct Lisp_Subr.function.aMANY)
7671 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7672 Arg counts are now ptrdiff_t, not size_t.
7673 All variadic functions and their callers changed accordingly.
7674 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7675 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7676 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7677 * callint.c (Fcall_interactively): Check arg count for overflow,
7678 to avoid potential buffer overrun. Use signed char, not 'int',
7679 for 'varies' array, so that we needn't bother to check its size
7680 calculation for overflow.
7681 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7682 * eval.c (apply_lambda):
7683 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7684 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7685 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7686
a1759b76
PE
7687 * callint.c (Fcall_interactively): Don't use index var as event count.
7688
d96be9fc
PE
7689 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7690 * mem-limits.h (SIZE): Remove; no longer used.
7691
a690a978 7692 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7693
578c21e6
PE
7694 Remove unnecessary casts.
7695 * xterm.c (x_term_init):
7696 * xfns.c (x_set_border_pixel):
7697 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7698 These aren't needed now that we assume ANSI C.
7699
96f53c6c
PE
7700 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7701 It's more likely to cause problems (due to unsigned overflow)
7702 than to cure them.
7703
83c77d31
PE
7704 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7705
ee2079f1
PE
7706 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7707
6da65536
PE
7708 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7709
7147c4a4
PE
7710 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7711
193e32d9
PE
7712 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7713
e5533da6
PE
7714 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7715
9910e595
PE
7716 GLYPH_CODE_FACE returns EMACS_INT, not int.
7717 * dispextern.h (merge_faces):
7718 * xfaces.c (merge_faces):
01103c44
PE
7719 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7720 Don't assume EMACS_INT fits in int.
9910e595 7721
2638320e
PE
7722 * character.h (CHAR_VALID_P): Remove unused parameter.
7723 * fontset.c, lisp.h, xdisp.c: All uses changed.
7724
045eb8d9
PE
7725 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7726
c1f134b5
PE
7727 * fns.c (concat): Minor tuning based on overflow analysis.
7728 This doesn't fix any bugs. Use int to hold character, instead
7729 of constantly refetching from Emacs object. Use XFASTINT, not
7730 XINT, for value known to be a character. Don't bother comparing
7731 a single byte to 0400, as it's always less.
7732
395fcb93 7733 * floatfns.c (Fexpt):
327eeec8
PE
7734 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7735
abbd3d23
PE
7736 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7737 for characters.
7738
684a03ef
PE
7739 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7740
0fed43f3
PE
7741 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7742 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7743 incorrectly succeed when S was a string, because 4294967386 was
7744 truncated before it was used.
7745
8fd02eb7
PE
7746 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7747 Otherwise, an out-of-range integer could cause undefined behavior
7748 on a 64-bit host.
7749
f8c86b69
PE
7750 * composite.c: Use int, not EMACS_INT, for characters.
7751 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7752 EMACS_INT, for values that are known to be in character range.
7753 This doesn't fix any bugs but is the usual style inside Emacs and
7754 may generate better code on 32-bit machines.
7755
34206dd2
PE
7756 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7757 This is for reasons similar to the recent CHAR_STRING fix.
7758 * charset.c (Fencode_char): Check that character arg is actually
7759 a character. Pass an int to ENCODE_CHAR.
7760 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7761 wider than 'int', as a compile-time check to prevent future regressions
7762 in this area.
7763
c5958d4c 7764 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7765
7766 Make sure a 64-bit char is never passed to CHAR_STRING.
7767 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7768 by silently ignoring the top 32 bits, allowing some values
7769 that were far too large to be valid characters.
7770 * character.h: Include <verify.h>.
7771 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7772 arguments are no wider than unsigned, as a compile-time check
7773 to prevent future regressions in this area.
7774 * data.c (Faset):
01103c44 7775 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7776 (Fsubst_char_in_region):
7777 * fns.c (concat):
7778 * xdisp.c (decode_mode_spec_coding):
7779 Adjust to CHAR_STRING's new requirement.
7780 * editfns.c (Finsert_char, Fsubst_char_in_region):
7781 * fns.c (concat): Check that character args are actually
7782 characters. Without this test, these functions did the wrong
7783 thing with wildly out-of-range values on 64-bit hosts.
7784
d37ca623
PE
7785 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7786 These casts should not be needed on 32-bit hosts, either.
7787 * keyboard.c (read_char):
7788 * lread.c (Fload): Remove casts to unsigned.
7789
ea204efb
PE
7790 * lisp.h (UNSIGNED_CMP): New macro.
7791 This fixes comparison bugs on 64-bit hosts.
7792 (ASCII_CHAR_P): Use it.
7793 * casefiddle.c (casify_object):
01103c44 7794 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7795 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7796 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7797 * dispextern.h (FACE_FROM_ID):
7798 * keyboard.c (read_char): Use UNSIGNED_CMP.
7799
41cb286c
PE
7800 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7801 not to EMACS_INT, to avoid GCC warning.
7802
4a1b9832
PE
7803 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7804
55daad71
PE
7805 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7806 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7807 isn't needed on 32-bit machines.
8f95c75c 7808
01103c44
PE
7809 * buffer.c (Fgenerate_new_buffer_name):
7810 Use EMACS_INT for count, not int.
0ceccced 7811 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7812
7813 * data.c (Qcompiled_function): Now static.
7814
c6f072e7
PE
7815 * window.c (window_body_lines): Now static.
7816
20ce5912
PE
7817 * image.c (gif_load): Rename local to avoid shadowing.
7818
9c4c5f81
PE
7819 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7820 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7821 * alloc.c (make_save_value): Integer argument is now of type
7822 ptrdiff_t, not int.
7823 (mark_object): Use ptrdiff_t, not int.
7824 * lisp.h (pD): New macro.
7825 * print.c (print_object): Use it.
7826
c0c5c8ae
PE
7827 * alloc.c: Use EMACS_INT, not int, to count objects.
7828 (total_conses, total_markers, total_symbols, total_vector_size)
7829 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7830 (total_free_floats, total_floats, total_free_intervals)
7831 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7832 Now EMACS_INT, not int. All uses changed.
7833 (Fgarbage_collect): Compute overall total using a double, so that
7834 integer overflow is less likely to be a problem. Check for overflow
7835 when converting back to an integer.
5a25e253
PE
7836 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7837 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7838 These were 'int' variables that could overflow on 64-bit hosts;
7839 they were never used, so remove them instead of repairing them.
211a0b2a 7840 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7841 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7842 Previously, this ceilinged at INT_MAX, but that doesn't work on
7843 64-bit machines.
e46bb31a 7844 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7845
c78baabf 7846 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7847 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7848 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7849 when a (possibly-narrower) signed value would do just as well.
7850 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7851
c9d624c6
PE
7852 * alloc.c: Catch some string size overflows that we were missing.
7853 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7854 for convenience in STRING_BYTES_MAX.
7855 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7856 The definition here is exact; the one in lisp.h was approximate.
7857 (allocate_string_data): Check for string overflow. This catches
7858 some instances we weren't catching before. Also, it catches
7859 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7860 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7861 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7862
c9d624c6
PE
7863 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7864 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7865 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7866
353032ce
PE
7867 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7868
2bccce07
PE
7869 * alloc.c (Fmake_string): Check for out-of-range init.
7870
0ac30604
SM
78712011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7872
7873 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7874
c195f2de
JD
78752011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7876
7877 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7878 xg_get_default_scrollbar_width.
7879
7880 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7881 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7882 (style_changed_cb): Call update_theme_scrollbar_width and call
7883 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7884 all frames (Bug#8505).
7885 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7886 Call gtk_window_set_resizable if HAVE_GTK3.
7887 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7888 and height if HAVE_GTK3 (Bug#8505).
7889 (scroll_bar_width_for_theme): New variable.
7890 (update_theme_scrollbar_width): New function.
7891 (xg_get_default_scrollbar_width): Move code to
7892 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7893 (xg_initialize): Call update_theme_scrollbar_width.
7894
7895 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7896
7897 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7898
e10ac9f1
MR
78992011-06-12 Martin Rudalics <rudalics@gmx.at>
7900
7901 * frame.c (make_frame): Call other_buffer_safely instead of
7902 other_buffer.
7903
7904 * window.c (temp_output_buffer_show): Call display_buffer with
7905 second argument Vtemp_buffer_show_specifiers and reset latter
7906 immediately after the call.
7907 (Vtemp_buffer_show_specifiers): New variable.
7908 (auto_window_vscroll_p, next_screen_context_lines)
7909 (Vscroll_preserve_screen_position): Remove leading asterisks from
7910 doc-strings.
7911
2d3c217e 79122011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7913
7b7f97e8 7914 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7915 * buffer.c (Qclone_number): Remove for now, as it's unused.
7916 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7917 (record_buffer): Remove unused local.
7918 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7919 (set_frame_buffer_list): Remove; unused.
7920 * frame.h (other_visible_frames): Remove decl.
7921 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7922 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7923 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7924 if HAVE_GPM.
7925 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7926 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7927 Define only if HAVE_GPM.
7928 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7929 (update_hints_inhibit): Remove; never set. All uses removed.
7930 * widgetprv.h (emacsFrameClassRec): Remove decl.
7931 * window.c (delete_deletable_window): Now returns void, since it
7932 wasn't returning anything.
7933 (compare_window_configurations): Remove unused locals.
7934 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7935 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7936 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7937 the same widths as pointers. This follows up on the 2011-05-06 patch.
7938 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7939 * xterm.h: Likewise.
7940 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7941
1384b89e
JB
79422011-06-12 Juanma Barranquero <lekktu@gmail.com>
7943
7944 * makefile.w32-in: Update dependencies.
7945 (LISP_H): Add lib/intprops.h.
7946
1100a63c
CY
79472011-06-11 Chong Yidong <cyd@stupidchicken.com>
7948
7949 * image.c (gif_load): Add animation frame delay to the metadata.
7950 (syms_of_image): Use DEFSYM. New symbol `delay'.
7951
6198ccd0
MR
79522011-06-11 Martin Rudalics <rudalics@gmx.at>
7953
7954 * window.c (delete_deletable_window): Re-add.
7955 (Fset_window_configuration): Rewrite to handle dead buffers and
7956 consequently deletable windows.
7957 (window_tree, Fwindow_tree): Remove. Supply functionality in
7958 window.el.
7959 (compare_window_configurations): Simplify code.
7960
b6e3633c
AS
79612011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7962
1ab0dee5
AS
7963 * image.c (imagemagick_load_image): Fix type mismatch.
7964 (Fimagemagick_types): Likewise.
7965
b6e3633c
AS
7966 * window.h (replace_buffer_in_windows): Declare.
7967
9397e56f
MR
79682011-06-11 Martin Rudalics <rudalics@gmx.at>
7969
7970 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7971 Qclone_number. Remove external declaration of Qdelete_window.
7972 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7973 code.
640c8776
SM
7974 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7975 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7976 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7977 buffer list implementation.
7978 (other_buffer_safely): New function.
7979 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7980 calls to replace_buffer_in_windows and
7981 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7982 if allowed.
7983 (record_buffer): Inhibit quitting and rewrite using quittable
7984 functions. Run Qbuffer_list_update_hook if allowed.
7985 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7986 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7987 Move switch-to-buffer to window.el.
9397e56f
MR
7988 (bury-buffer): Move to window.el.
7989 (Vbuffer_list_update_hook): New variable.
7990
7991 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7992 section.
7993
7994 * window.h (resize_frame_windows): Move up in code.
7995 (Fwindow_frame): Remove EXFUN.
7996 (replace_buffer_in_all_windows): Remove prototype.
7997 (replace_buffer_in_windows_safely): Add prototype.
7998
7999 * window.c: Declare Qdelete_window static again. Move down
8000 declaration of select_count.
8001 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8002 (Fother_window): Move to window.el.
8003 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8004 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8005 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8006 window.el.
8007 (replace_buffer_in_windows): Implement by calling
8008 Qreplace_buffer_in_windows.
8009 (replace_buffer_in_all_windows): Remove with some functionality
8010 moved into replace_buffer_in_windows_safely.
8011 (replace_buffer_in_windows_safely): New function.
8012 (select_window_norecord, select_frame_norecord): Move in front
8013 of run_window_configuration_change_hook. Remove now obsolete
8014 declarations.
640c8776
SM
8015 (Fset_window_buffer): Rewrite doc-string.
8016 Call Qrecord_window_buffer.
9397e56f
MR
8017 (keys_of_window): Move binding for other-window to window.el.
8018
b50691aa
CY
80192011-06-11 Chong Yidong <cyd@stupidchicken.com>
8020
8021 * dispextern.h (struct image): Replace data member, whose int_val
8022 and ptr_val fields were not used by anything, with a single
8023 lisp_val object.
8024
8025 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8026 (gif_clear_image, gif_load, imagemagick_load_image)
8027 (gs_clear_image, gs_load): Callers changed.
8028
3f754b86
PE
80292011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8030
cca69397
PE
8031 * buffer.h: Include <time.h>, for time_t.
8032 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8033
109e28d0
PE
8034 Fix minor problems found by static checking.
8035
60737f02
PE
8036 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8037
4b66faf3
PE
8038 Make identifiers static if they are not used in other modules.
8039 * data.c (Qcompiled_function, Qframe, Qvector):
8040 * image.c (QimageMagick, Qsvg):
8041 * minibuf.c (Qmetadata):
8042 * window.c (resize_window_check, resize_root_window): Now static.
8043 * window.h (resize_window_check, resize_root_window): Remove decls.
8044
109e28d0
PE
8045 * window.c (window_deletion_count, delete_deletable_window):
8046 Remove; unused.
46a4ce9e
PE
8047 (window_body_lines): Now static.
8048 (Fdelete_other_windows_internal): Mark vars as initialized.
8049 Make sure 'resize_failed' is initialized.
8050 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8051 (resize_window_apply): Remove unused local.
8052 * window.h (delete_deletable_window): Remove decl.
8053
109e28d0 8054 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8055 (imagemagick_load_image): Fix pointer signedness problem by changing
8056 last arg from unsigned char * to char *. All uses changed.
8057 Also, fix a local for similar reasons.
8058 Remove unused locals. Remove locals to avoid shadowing.
8059 (fn_rsvg_handle_free): Remove; unused.
8060 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8061 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8062
3f754b86
PE
8063 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8064
2547adb1
CY
80652011-06-10 Chong Yidong <cyd@stupidchicken.com>
8066
8067 * image.c (gif_load): Fix omitted cast error introduced by
8068 2011-06-06 change.
8069
2c8e37d4
MR
80702011-06-10 Martin Rudalics <rudalics@gmx.at>
8071
8072 * window.h (resize_proportionally, orig_total_lines)
8073 (orig_top_line): Remove from window structure.
8074 (set_window_height, set_window_width, change_window_heights)
8075 (Fdelete_window): Remove prototypes.
8076 (resize_frame_windows): Remove duplicate declaration.
8077
440a42e3
EZ
80782011-06-10 Eli Zaretskii <eliz@gnu.org>
8079
8080 * window.h (resize_frame_windows, resize_window_check)
8081 (delete_deletable_window, resize_root_window)
8082 (resize_frame_windows): Declare prototypes.
8083
8084 * window.c (resize_window_apply): Make definition be "static" to
8085 match the prototype.
8086
562dd5e9
MR
80872011-06-10 Martin Rudalics <rudalics@gmx.at>
8088
8089 * window.c: Remove declarations of Qwindow_size_fixed,
8090 window_min_size_1, window_min_size_2, window_min_size,
8091 size_window, window_fixed_size_p, enlarge_window, delete_window.
8092 Remove static from declaration of Qdelete_window, it's
8093 temporarily needed by Fbury_buffer.
8094 (replace_window): Don't assign orig_top_line and
8095 orig_total_lines.
8096 (Fdelete_window, delete_window): Remove. Window deletion is
8097 handled by window.el.
640c8776
SM
8098 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8099 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8100 (Fdelete_other_windows): Remove. Deleting other windows is
8101 handled by window.el.
8102 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8103 handled in window.el.
8104 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8105 Window minimum sizes are handled in window.el.
8106 (shrink_windows, size_window, set_window_height)
8107 (set_window_width, change_window_heights, window_height)
8108 (window_width, CURBEG, CURSIZE, enlarge_window)
8109 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8110 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8111 handled in window.el.
8112 (make_dummy_parent): Rename to make_parent_window and give it a
8113 second argument horflag.
8114 (make_window): Don't set resize_proportionally any more.
8115 (Fsplit_window): Remove. Windows are split in window.el.
8116 (save_restore_action, save_restore_orig_size)
8117 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8118 Resize mini windows in window.el.
8119 (grow_mini_window, shrink_mini_window): Implement by calling
8120 Qresize_root_window_vertically, resize_window_check and
8121 resize_window_apply.
640c8776
SM
8122 (saved_window, Fset_window_configuration, save_window_save):
8123 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8124 resize_proportionally.
8125 (window_min_height, window_min_width): Move to window.el.
8126 (keys_of_window): Move bindings for delete-other-windows,
8127 split-window, delete-window and enlarge-window to window.el.
8128
8129 * buffer.c: Temporarily extern Qdelete_window.
8130 (Fbury_buffer): Temporarily call Qdelete_window instead of
8131 Fdelete_window (Fbury_buffer will move to window.el soon).
8132
8133 * frame.c (set_menu_bar_lines_1): Remove code handling
8134 orig_top_line and orig_total_lines.
8135
8136 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8137 set_window_height but set heights directly.
8138 (change_frame_size_1): Use resize_frame_windows.
8139
8140 * xdisp.c (init_xdisp): Don't use set_window_height but set
8141 heights directly.
8142
640c8776
SM
8143 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8144 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8145 run_window_configuration_change_hook.
8146
8147 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8148 instead of change_window_heights and run
8149 run_window_configuration_change_hook.
8150
1a13852e
MR
81512011-06-09 Martin Rudalics <rudalics@gmx.at>
8152
8153 * window.c (replace_window): Rename second argument REPLACEMENT to
8154 NEW. New third argument SETFLAG. Rewrite.
8155 (delete_window, make_dummy_parent): Call replace_window with
8156 third argument 1.
8157 (window_list_1): Move down in code.
8158 (run_window_configuration_change_hook): Move set_buffer part
8159 before select_frame_norecord part in order to unwind correctly.
8160 Rename count1 to count.
8161 (recombine_windows, delete_deletable_window, resize_root_window)
8162 (Fdelete_other_windows_internal)
8163 (Frun_window_configuration_change_hook, make_parent_window)
8164 (resize_window_check, resize_window_apply, Fresize_window_apply)
8165 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8166 (Fdelete_window_internal, Fresize_mini_window_internal):
8167 New functions.
1a13852e
MR
8168 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8169
f3d1777e
MR
81702011-06-08 Martin Rudalics <rudalics@gmx.at>
8171
496e208e
MR
8172 * window.h (window): Add some new members to window structure -
8173 normal_lines, normal_cols, new_total, new_normal, clone_number,
8174 splits, nest, prev_buffers, next_buffers.
8175 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8176 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8177
f3d1777e
MR
8178 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8179 Remove.
496e208e
MR
8180 (make_dummy_parent): Set new members of windows structure.
8181 (make_window): Move down in code. Handle new members of window
8182 structure.
8183 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8184 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8185 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8186 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8187 (Fset_window_next_buffers, Fset_window_clone_number):
8188 New functions.
496e208e
MR
8189 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8190 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8191 Doc-string fixes.
8192 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8193 Argument WINDOW can be now internal window too.
8194 (Fwindow_use_time): Move up in code.
8195 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8196 Rewrite doc-string.
8197 (Fset_window_configuration, saved_window)
8198 (Fcurrent_window_configuration, save_window_save): Handle new
8199 members of window structure.
b9e809c2
MR
8200 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8201 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8202 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8203 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8204 Qget_mru_window, Qresize_root_window,
8205 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8206 Qauto_buffer_name; staticpro them.
f3d1777e 8207
abde8f8c
MR
82082011-06-07 Martin Rudalics <rudalics@gmx.at>
8209
8210 * window.c (Fwindow_total_size, Fwindow_left_column)
8211 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8212 (Fwindow_list_1): New functions.
8213 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8214 (Fwindow_width, Fscroll_left, Fscroll_right):
8215 Use window_body_cols instead of window_box_text_cols.
8216 (delete_window, Fset_window_configuration):
8217 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8218 (delete_all_subwindows): Take a window as argument and not a
8219 structure. Rewrite.
190b47e6
MR
8220 (window_loop): Remove handling of GET_LRU_WINDOW and
8221 GET_LARGEST_WINDOW.
8222 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8223
8224 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8225 window_box_text_cols. delete_all_subwindows now takes a
8226 Lisp_Object as argument.
abde8f8c 8227
640c8776
SM
8228 * indent.c (compute_motion, Fcompute_motion):
8229 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8230
fa8a67e6
MR
8231 * frame.c (delete_frame): Call delete_all_subwindows with root
8232 window as argument.
8233
a54e3482
DC
82342011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8235
8236 * fns.c (Fputhash): Document return value.
8237
60002bf5
CY
82382011-06-06 Chong Yidong <cyd@stupidchicken.com>
8239
8240 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8241
0c671da6 82422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8243
b862a52a 8244 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8245
be44ca6c
PE
8246 Check for overflow when converting integer to cons and back.
8247 * charset.c (Fdefine_charset_internal, Fdecode_char):
8248 Use cons_to_unsigned to catch overflow.
8249 (Fencode_char): Use INTEGER_TO_CONS.
8250 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8251 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8252 * data.c (long_to_cons, cons_to_long): Remove.
8253 (cons_to_unsigned, cons_to_signed): New functions.
8254 These signal an error for invalid or out-of-range values.
8255 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8256 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8257 * font.c (Ffont_variation_glyphs):
8258 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8259 * lisp.h: Include <intprops.h>.
8260 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8261 (cons_to_signed, cons_to_unsigned): New decls.
8262 (long_to_cons, cons_to_long): Remove decls.
8263 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8264 (Fprimitive_undo): Use CONS_TO_INTEGER.
8265 * xfns.c (Fx_window_property): Likewise.
8266 * xselect.c: Include <limits.h>.
8267 (x_own_selection, selection_data_to_lisp_data):
8268 Use INTEGER_TO_CONS.
8269 (x_handle_selection_request, x_handle_selection_clear)
8270 (x_get_foreign_selection, Fx_disown_selection_internal)
8271 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8272 (lisp_data_to_selection_data): Use cons_to_unsigned.
8273 (x_fill_property_data): Use cons_to_signed.
8274 Report values out of range.
8275
d1f3d2af
PE
8276 Check for buffer and string overflow more precisely.
8277 * buffer.h (BUF_BYTES_MAX): New macro.
8278 * lisp.h (STRING_BYTES_MAX): New macro.
8279 * alloc.c (Fmake_string):
8280 * character.c (string_escape_byte8):
8281 * coding.c (coding_alloc_by_realloc):
8282 * doprnt.c (doprnt):
8283 * editfns.c (Fformat):
8284 * eval.c (verror):
8285 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8286 since they may not be the same number.
8287 * editfns.c (Finsert_char):
8288 * fileio.c (Finsert_file_contents):
8289 Likewise for BUF_BYTES_MAX.
8290
dd52fcea
PE
8291 * image.c: Use ptrdiff_t, not int, for sizes.
8292 (slurp_file): Switch from int to ptrdiff_t.
8293 All uses changed.
8294 (slurp_file): Check that file size fits in both size_t (for
8295 malloc) and ptrdiff_t (for sanity and safety).
8296
7f9bbdbb
PE
8297 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8298 if b->modtime has its maximal value.
8299
dfe18f82
PE
8300 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8301
84acfcf0
PE
8302 Don't assume time_t can fit into int.
8303 * buffer.h (struct buffer.modtime): Now time_t, not int.
8304 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8305 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8306
ccd9a01a
PE
8307 Minor fixes for signed vs unsigned integers.
8308 * character.h (MAYBE_UNIFY_CHAR):
8309 * charset.c (maybe_unify_char):
8310 * keyboard.c (read_char, reorder_modifiers):
8311 XINT -> XFASTINT, since the integer must be nonnegative.
8312 * ftfont.c (ftfont_spec_pattern):
8313 * keymap.c (access_keymap, silly_event_symbol_error):
8314 XUINT -> XFASTINT, since the integer must be nonnegative.
8315 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8316 since it makes no difference and we prefer signed.
8317 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8318 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8319 nonnegative.
8320
d6d100dd
SM
83212011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8322
8323 * window.h (Fwindow_frame): Declare.
8324
2b6148e4
PE
83252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8326
8327 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8328 (SPARE_MEMORY): Always define.
8329 (LARGE_REQUEST): Remove.
8330 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8331
f230ecc9
MR
83322011-06-06 Martin Rudalics <rudalics@gmx.at>
8333
727e958e
MR
8334 * lisp.h: Move EXFUNS for Fframe_root_window,
8335 Fframe_first_window and Fset_frame_selected_window to window.h.
8336
8337 * window.h: Move EXFUNS for Fframe_root_window,
8338 Fframe_first_window and Fset_frame_selected_window here from
8339 lisp.h.
8340
8341 * frame.c (Fwindow_frame, Fframe_first_window)
8342 (Fframe_root_window, Fframe_selected_window)
8343 (Fset_frame_selected_window): Move to window.c.
8344 (Factive_minibuffer_window): Move to minibuf.c.
8345 (Fother_visible_frames_p): New function.
8346
8347 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8348
f230ecc9
MR
8349 * window.c (decode_window, decode_any_window): Move up in code.
8350 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8351 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8352 (Fwindow_buffer): Move up and rewrite doc-string.
8353 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8354 (Fwindow_prev): New functions.
727e958e
MR
8355 (Fwindow_frame): Move here from frame.c. Accept any window as
8356 argument.
8357 (Fframe_root_window, Fframe_first_window)
8358 (Fframe_selected_window): Move here from frame.c. Accept frame
8359 or arbitrary window as argument. Update doc-strings.
8360 (Fminibuffer_window): Move up in code.
8361 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8362 (Fset_frame_selected_window): Move here from frame.c.
8363 Marginal rewrite.
727e958e
MR
8364 (Fselected_window, select_window, Fselect_window): Move up in
8365 code. Minor doc-string fixes.
f230ecc9 8366
4d09bcf6
PE
83672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8368
8369 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8370 Do not assume that spare memory exists; that assumption is valid
8371 only if SYSTEM_MALLOC.
8372 (LARGE_REQUEST): New macro, so that the issue of large requests
8373 is separated from the issue of spare memory.
8374
810928a2
AS
83752011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8376
172418ad
AS
8377 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8378 format. (Bug#8806)
8379
43f862f7
AS
8380 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8381
810928a2
AS
8382 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8383 before statements.
8384
a059fe24
JD
83852011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8386
8387 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8388
8389 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8390
8391 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8392 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8393
989bf368
JB
83942011-06-05 Juanma Barranquero <lekktu@gmail.com>
8395
8396 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8397
4b80f674
CY
83982011-06-04 Chong Yidong <cyd@stupidchicken.com>
8399
8400 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8401 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8402 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8403 New error handlers.
4b80f674
CY
8404 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8405 Obey Vx_select_enable_clipboard_manager. Catch errors in
8406 x_clipboard_manager_save (Bug#8779).
8407 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8408 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8409
99a33b77 84102011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8411
8412 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8413
99a33b77 84142011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8415
8416 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8417 in the current matrix if keep_current_p is non-zero.
8418
8264569d
EZ
84192011-06-04 Eli Zaretskii <eliz@gnu.org>
8420
8421 * bidi.c (bidi_level_of_next_char): Fix last change.
8422
57f97249
EZ
84232011-06-03 Eli Zaretskii <eliz@gnu.org>
8424
fec2107c 8425 Support bidi reordering of text covered by display properties.
57f97249 8426
fec2107c
EZ
8427 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8428 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8429 (bidi_cache_search, bidi_cache_iterator_state)
8430 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8431 (bidi_level_of_next_char, bidi_move_to_visually_next):
8432 Support character positions inside a run of characters covered by a
fec2107c
EZ
8433 display string.
8434 (bidi_paragraph_init, bidi_resolve_explicit_1)
8435 (bidi_level_of_next_char): Call bidi_fetch_char and
8436 bidi_fetch_char_advance instead of FETCH_CHAR and
8437 FETCH_CHAR_ADVANCE.
8438 (bidi_init_it): Initialize new members.
8439 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8440 definitions.
8441 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8442 instead of using explicit *_CHAR codes.
d6d100dd
SM
8443 (bidi_resolve_explicit, bidi_resolve_weak):
8444 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8445 bidirectional text is supported only in multibyte buffers.
8446 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8447 it to initialize the frame_window_p member of struct bidi_it.
8448 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8449 (bidi_resolve_explicit, bidi_resolve_weak)
8450 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8451 bidi_it->nchars is non-positive.
8452 (bidi_level_of_next_char): Don't try to lookup the cache for the
8453 next/previous character if nothing is cached there yet, or if we
8454 were just reseat()'ed to a new position.
c40e2fb2 8455
0e14fe90
EZ
8456 * xdisp.c (set_cursor_from_row): Set start and stop points
8457 according to the row's direction when priming the loop that looks
8458 for the glyph on which to display cursor.
8459 (single_display_spec_intangible_p): Function deleted.
8460 (display_prop_intangible_p): Reimplement to call
8461 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8462 Accept 3 additional arguments needed by handle_display_spec.
8463 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8464 values: lists, `(when COND...)' forms, etc.
8465 (single_display_spec_string_p): Support property values that are
8466 lists with the argument STRING its top-level element.
8467 (display_prop_string_p): Fix the condition for processing a
8468 property that is a list to be consistent with handle_display_spec.
fec2107c 8469 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8470 last portion of handle_display_prop.
8471 (compute_display_string_pos): Accept additional argument
8472 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8473 value of a `display' property is a "replacing spec".
8474 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8475 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8476 the display property, but just return a value indicating whether
8477 the display property will replace the characters it covers.
8478 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8479 frame_window_p members of struct bidi_it.
d6d100dd
SM
8480 (compute_display_string_pos, compute_display_string_end):
8481 New functions.
fec2107c
EZ
8482 (push_it): Accept second argument POSITION, where pop_it should
8483 jump to continue iteration.
8484 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8485
fec2107c
EZ
8486 * keyboard.c (adjust_point_for_property): Adjust the call to
8487 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8488
8489 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8490 (bidi_init_it): Update prototypes.
8491 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8492 (compute_display_string_pos, compute_display_string_end):
8493 Declare prototypes.
fec2107c
EZ
8494 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8495 EMACS_INT.
fc6f18ce 8496
40087514 84972011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8498
57f53182
PE
8499 Malloc failure behavior now depends on size of allocation.
8500 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8501 * lisp.h: Change signatures accordingly.
8502 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8503 All callers changed. (Bug#8762)
8504
8505 * gnutls.c: Use Emacs's memory allocators.
8506 Without this change, the gnutls library would invoke malloc etc.
8507 directly, which causes problems on non-SYNC_INPUT hosts, and which
8508 runs afoul of improving memory_full behavior. (Bug#8761)
8509 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8510 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8511 xfree instead of the default malloc, realloc, free.
8512 (Fgnutls_boot): No need to check for memory allocation failure,
8513 since xmalloc does that for us.
8514
ac32cd99 8515 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8516 * category.c (hash_get_category_set):
8517 * ccl.c (ccl_driver):
8518 * charset.c (Fdefine_charset_internal):
8519 * charset.h (struct charset.hash_index):
8520 * composite.c (get_composition_id, gstring_lookup_cache)
8521 (composition_gstring_put_cache):
8522 * composite.h (struct composition.hash_index):
8523 * dispextern.h (struct image.hash):
8524 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8525 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8526 (hashfn_equal, hashfn_user_defined, make_hash_table)
8527 (maybe_resize_hash_table, hash_lookup, hash_put)
8528 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8529 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8530 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8531 * image.c (make_image, search_image_cache, lookup_image)
8532 (xpm_put_color_table_h):
8533 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8534 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8535 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8536 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8537 * alloc.c (allocate_vectorlike):
8538 Check for overflow in vector size calculations.
8539 * ccl.c (ccl_driver):
8540 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8541 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8542 need to be updated by these changes.
40087514
PE
8543 * fns.c (make_hash_table, maybe_resize_hash_table):
8544 Check for integer overflow with large hash tables.
0de4bb68
PE
8545 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8546 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8547 (SXHASH_REDUCE): New macro.
8548 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8549 Use it instead of discarding useful hash info with large hash values.
8550 (sxhash_float): New function.
8551 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8552 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8553 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8554 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8555 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8556 Adjust signatures to match updated version of code.
8557 (consing_since_gc): Now EMACS_INT, since a single hash table can
8558 use more than INT_MAX bytes.
8559
698d32e2
DN
85602011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8561
8562 Make it possible to build with GCC-4.6+ -O2 -flto.
8563
8564 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8565
fd6fa53f
SM
85662011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8567
8568 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8569 Call minibuffer-inactive-mode.
8570
864db017
JB
85712011-05-31 Juanma Barranquero <lekktu@gmail.com>
8572
8573 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8574 Update dependencies.
8575
2ad0baf4
DN
85762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8577
8578 * data.c (init_data): Remove code for UTS, this system is not
8579 supported anymore.
8580
4fcc2638
DN
85812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8582
8583 Don't force ./temacs to start in terminal mode.
8584
8585 * frame.c (make_initial_frame): Initialize faces in all cases, not
8586 only when CANNOT_DUMP is defined.
8587 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8588
c56e0fd5
DN
85892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8590
8591 * dispnew.c (add_window_display_history): Use const for the string
8592 pointer. Remove declaration, not needed.
8593
333d54da 85942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8595
55d4c1b2 8596 Use 'inline', not 'INLINE'.
333d54da 8597 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8598 * alloc.c, fontset.c (INLINE): Remove.
8599 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8600 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8601 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8602 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8603 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8604
738db178
DN
86052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8606
8607 Make it possible to run ./temacs.
8608
8609 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8610 syms_of_callproc does the same thing. Remove test for
8611 "initialized", do it in the caller.
8612 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8613
620c53a6
SM
86142011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8615
8616 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8617 (read_minibuf): Use get_minibuffer.
8618 (syms_of_minibuf): Use DEFSYM.
8619 (Qmetadata): New var.
8620 * data.c (Qbuffer): Don't make it static.
8621 (syms_of_data): Use DEFSYM.
8622
e003a292
PE
86232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8624
8625 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8626 (CCL_CODE_MIN): New macro.
8627
ed008a6d
PE
86282011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8629
3687c2ef
PE
8630 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8631
ed008a6d
PE
8632 * eval.c (Qdebug): Now static.
8633 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8634 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8635 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8636
d66c4c7c
CY
86372011-05-29 Chong Yidong <cyd@stupidchicken.com>
8638
8639 * image.c: Various fixes to ImageMagick code comments.
8640 (Fimagemagick_types): Doc fix.
8641
5fbc2025
PE
86422011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8643
0196f88a
PE
8644 Minor fixes prompted by GCC 4.6.0 warnings.
8645
8646 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8647
5fbc2025
PE
8648 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8649 (x_clipboard_manager_save_all): Move extern decl to ...
8650 * xterm.h: ... here, so that it can be checked for consistency.
8651
1dd3c2d9
CY
86522011-05-29 Chong Yidong <cyd@stupidchicken.com>
8653
8654 * xselect.c (x_clipboard_manager_save_frame)
8655 (x_clipboard_manager_save_all): New functions.
8656 (Fx_clipboard_manager_save): Lisp function deleted.
8657
8658 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8659 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8660
8661 * xterm.h: Update prototype.
8662
5ba6571d
WX
86632011-05-28 William Xu <william.xwl@gmail.com>
8664
8665 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8666 exiting (Bug#8239).
8667
3eaff834
JM
86682011-05-28 Jim Meyering <meyering@redhat.com>
8669
e1900994 8670 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8671 * fns.c (to_uchar): Define.
8672 (crypto_hash_function): Use it to convert some newly-signed
8673 variables to unsigned, to avoid sign-extension bugs. For example,
8674 without this change, (md5 "truc") would evaluate to
8675 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8676 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8677 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8678
0f6990a7
PE
86792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8680
8681 Integer overflow fixes.
c8a9ca5a 8682
08686060
PE
8683 * dbusbind.c: Serial number integer overflow fixes.
8684 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8685 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8686 to hold a serial number that is too large for a fixnum.
8687 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8688 Check for serial numbers out of range. Decode any serial number
59568bf0 8689 that was so large that it became a float. (Bug#8722)
08686060 8690
2d1fc3c7
PE
8691 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8692 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8693 Use XFASTINT rather than XUINT when numbers are nonnegative.
8694 (xd_append_arg, Fdbus_method_return_internal):
8695 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8696 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8697 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8698 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8699 (Bug#8722)
2d1fc3c7 8700
c8a9ca5a
PE
8701 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8702
519e1d69
PE
8703 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8704
6df6ae42 8705 ccl: Add integer overflow checks.
30569699
PE
8706 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8707 (IN_INT_RANGE): New macros.
8708 (ccl_driver): Use them to check for integer overflow when
8709 decoding a CCL program. Many of the new checks are whether XINT (x)
8710 fits in int; it doesn't always, on 64-bit hosts. The new version
8711 doesn't catch all possible integer overflows, but it's an
847044ea 8712 improvement. (Bug#8719)
30569699 8713
c11285dc
PE
8714 * alloc.c (make_event_array): Use XINT, not XUINT.
8715 There's no need for unsigned here.
8716
fdccd48e
PE
8717 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8718 This follows up to the 2011-05-06 change that substituted uintptr_t
8719 for EMACS_INT. This case wasn't caught back then.
8720
37910ab2
PE
8721 Rework Fformat to avoid integer overflow issues.
8722 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8723 now (part of C89). Include <verify.h>.
8724 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8725 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8726 (Fformat): Avoid the prepass trying to compute sizes; it was only
8727 approximate and thus did not catch overflow reliably. Instead, walk
8728 through the format just once, formatting and computing sizes as we go,
8729 checking for integer overflow at every step, and allocating a larger
8730 buffer as needed. Keep track separately whether the format is
8731 multibyte. Keep only the most-recently calculated precision, rather
8732 than them all. Record whether each argument has been converted to
8733 string. Use EMACS_INT, not int, for byte and char and arg counts.
8734 Support field widths and precisions larger than INT_MAX. Avoid
8735 sprintf's undefined behavior with conversion specifications such as %#d
8736 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8737 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8738 formatting out-of-range floating point numbers with int
9173deec 8739 formats. (Bug#8668)
37910ab2 8740
2e6578fb
PE
8741 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8742
0ae6bdee
PE
8743 * data.c: Avoid integer truncation in expressions involving floats.
8744 * data.c: Include <intprops.h>.
8745 (arith_driver): When there's an integer overflow in an expression
8746 involving floating point, convert the integers to floating point
8747 so that the resulting value does not suffer from catastrophic
8748 integer truncation. For example, on a 64-bit host (* 4
8749 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8750 Do not rely on undefined behavior after integer overflow.
8751
de883a70
PE
8752 merge count_size_as_multibyte, parse_str_to_multibyte
8753 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8754 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8755 Check for integer overflow.
8756 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8757 since it's now a duplicate of the other. This is more of
8758 a character than a buffer op, so better that it's in character.c.
8759 * fns.c, print.c: Adjust to above changes.
8760
2ff916cb
PE
87612011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8762
8763 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8764
f1b54466
PE
87652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8766
fb1ac845
PE
8767 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8768 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8769 (x_clipboard_manager_save): Now static.
8770 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8771
f1b54466
PE
8772 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8773 (crypto_hash_function): Now static.
8774 Fix pointer signedness problems. Avoid unnecessary initializations.
8775
a9f737ee
CY
87762011-05-27 Chong Yidong <cyd@stupidchicken.com>
8777
8778 * termhooks.h (Vselection_alist): Make it terminal-local.
8779
8780 * terminal.c (create_terminal): Initialize it.
8781
8782 * xselect.c: Support for clipboard managers.
8783 (Vselection_alist): Move to termhooks.h as terminal-local var.
8784 (LOCAL_SELECTION): New macro.
8785 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8786 (symbol_to_x_atom): Remove gratuitous arg.
8787 (x_handle_selection_request, lisp_data_to_selection_data)
8788 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8789 (x_own_selection, x_get_local_selection, x_convert_selection):
8790 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8791 (some_frame_on_display): Delete unused function.
8792 (Fx_own_selection_internal, Fx_get_selection_internal)
8793 (Fx_disown_selection_internal, Fx_selection_owner_p)
8794 (Fx_selection_exists_p): New optional frame arg.
8795 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8796 (x_handle_selection_clear): Don't treat other terminals with the
8797 same keyboard specially. Use the terminal-local Vselection_alist.
8798 (x_clear_frame_selections): Use Frun_hook_with_args.
8799
8800 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8801
8802 * xterm.h: Add support for those atoms.
8803
e067f0c1
CY
88042011-05-26 Chong Yidong <cyd@stupidchicken.com>
8805
8806 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8807 (converted_selections, conversion_fail_tag): New global variables.
8808 (x_selection_request_lisp_error): Free the above.
8809 (x_get_local_selection): Remove unnecessary code.
8810 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8811 of converted selections stored in converted_selections.
8812 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8813 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8814 (x_convert_selection): New function.
8815 (x_handle_selection_event): Simplify.
8816 (x_get_foreign_selection): Don't ignore incoming requests while
8817 waiting for an answer; this will fail when we implement
8818 SAVE_TARGETS, and seems unnecessary anyway.
8819 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8820 (Vx_sent_selection_functions): Doc fix.
8821
0f4aebc0
LL
88222011-05-26 Leo Liu <sdl.web@gmail.com>
8823
8824 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8825
e61124cd
YM
88262011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8827
8828 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8829
8830 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8831 for fringe update if it has periodic bitmap.
ac389d0c 8832 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8833 and fringe_bitmap_periodic_p.
8834
8835 * fringe.c (get_fringe_bitmap_data): New function.
8836 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8837 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8838 row. Mark glyph row for fringe update if periodicity changed.
8839
8840 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8841 for fringe update unless it has periodic bitmap.
8842
f16d9837
KH
88432011-05-25 Kenichi Handa <handa@m17n.org>
8844
8845 * xdisp.c (get_next_display_element): Set correct it->face_id for
8846 a static composition.
8847
e1b90ef6
LL
88482011-05-24 Leo Liu <sdl.web@gmail.com>
8849
8850 * deps.mk (fns.o):
8851 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8852
8853 * fns.c (crypto_hash_function, Fsha1): New function.
8854 (Fmd5): Use crypto_hash_function.
8855 (syms_of_fns): Add Ssha1.
8856
7400048f
PE
88572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8858
8859 * gnutls.c: Remove unused macros.
8860 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8861 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8862 Remove macros that are defined and never used.
8863 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8864
abb71cf4
CY
88652011-05-22 Chong Yidong <cyd@stupidchicken.com>
8866
8867 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8868 (Fx_get_selection_internal): Minor cleanup.
8869 (Fx_own_selection_internal): Rename arguments for consistency with
8870 select.el.
8871
6307db39
PE
88722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8873
8874 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8875
f3d4e0a4
CY
88762011-05-22 Chong Yidong <cyd@stupidchicken.com>
8877
8878 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8879
4d8ade89
YM
88802011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8881
8882 * dispnew.c (scrolling_window): Don't exclude the case that the
8883 last enabled row in the desired matrix touches the bottom boundary.
8884
32078c8d
GM
88852011-05-21 Glenn Morris <rgm@gnu.org>
8886
8887 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8888 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8889 and add some more files.
32078c8d 8890
7285dc67
EZ
88912011-05-20 Eli Zaretskii <eliz@gnu.org>
8892
8893 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8894 report_file_error introduced by the change from 2011-05-07.
8895
89d1bd22
PE
88962011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8897
8898 * systime.h (Time): Define only if emacs is defined.
8899 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8900 where the include path doesn't have X11/X.h by default. See
8901 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8902
cd394be1 89032011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8904
8905 * composite.c (find_automatic_composition): Fix previous change.
8906
b9704ad9
GM
89072011-05-20 Glenn Morris <rgm@gnu.org>
8908
8909 * lisp.mk: New file, split from Makefile.in.
8910 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8911 (shortlisp): Remove.
8912 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8913
4a720484
GM
89142011-05-19 Glenn Morris <rgm@gnu.org>
8915
8916 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8917 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8918 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8919 (lisp): Set the order to that of loadup.el.
8920 (shortlisp): Make it a copy of $lisp.
8921 (SOME_MACHINE_LISP): Remove.
8922 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8923 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8924
a28d4396
KH
89252011-05-18 Kenichi Handa <handa@m17n.org>
8926
8927 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8928 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8929 (find_automatic_composition): Mostly rewrite for efficiency.
8930
a2b1fa8e
JB
89312011-05-18 Juanma Barranquero <lekktu@gmail.com>
8932
8933 * makefile.w32-in: Update dependencies.
8934
8e1f5610
CS
89352011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8936
8937 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8938 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8939
7025ee00 89402011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8941
cdfa6eab
PE
8942 Fix some integer overflow issues, such as string length overflow.
8943
06d6db33
PE
8944 * insdel.c (count_size_as_multibyte): Check for string overflow.
8945
2b4560a8
PE
8946 * character.c (lisp_string_width): Check for string overflow.
8947 Use EMACS_INT, not int, for string indexes and lengths; in
8948 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8949 the resulting string length overflows an EMACS_INT; instead,
8950 report a string overflow if no precision given. When checking for
8951 precision exhaustion, use a check that cannot possibly have
8952 integer overflow. (Bug#8675)
8953 * character.h (lisp_string_width): Adjust to new signature.
8954
cb93f9be
PE
8955 * alloc.c (string_overflow): New function.
8956 (Fmake_string): Use it. This doesn't change behavior, but saves
8957 a few bytes and will simplify future changes.
8958 * character.c (string_escape_byte8): Likewise.
8959 * lisp.h (string_overflow): New decl.
8960
1a1f3366
PE
8961 Fixups, following up to the user-interface timestamp change.
8962 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8963 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8964 * msdos.c (mouse_get_pos): Likewise.
8965 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8966 * w32gui.h (Time): Define by including "systime.h" rather than by
8967 declaring it ourselves. (Bug#8664)
8968
d4e3e4d3
PE
8969 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8970 * image.c (clear_image_cache): Likewise.
8971
f6a24d19
PE
8972 * term.c (term_mouse_position): Don't assume time_t wraparound.
8973
08dc5ae6
PE
8974 Be more systematic about user-interface timestamps.
8975 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8976 and sometimes 'EMACS_UINT', to represent these timestamps.
8977 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8978 This makes the code easier to follow, and makes it easier to catch
8979 integer overflow bugs such as Bug#8664.
8980 * frame.c (Fmouse_position, Fmouse_pixel_position):
8981 Use Time, not unsigned long, for user-interface timestamps.
8982 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8983 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8984 * keyboard.h (last_event_timestamp): Likewise.
8985 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8986 * menu.h (xmenu_show): Likewise.
8987 * term.c (term_mouse_position): Likewise.
8988 * termhooks.h (struct input_event.timestamp): Likewise.
8989 (struct terminal.mouse_position_hook): Likewise.
8990 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8991 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8992 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8993 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8994 what it was before.
8995 * menu.h, termhooks.h: Include "systime.h", for Time.
8996
8e55734a
PE
8997 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8998 Don't assume that the difference between two unsigned long values
8999 can fit into an integer. At this point, we know button_down_time
9000 <= event->timestamp, so the difference must be nonnegative, so
9001 there's no need to cast the result if double-click-time is
9002 nonnegative, as it should be; check that it's nonnegative, just in
9003 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9004 apart (about 25 days). (Bug#8664)
8e55734a 9005
841f1b75 9006 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9007 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9008
3e26f69c
PE
9009 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9010 that always fit in int. Use a sentinel instead of a counter, to
9011 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9012 * frame.h (struct frame): Use int for menu_bar_items_used
9013 instead of EMACS_INT, since it always fits in int.
3e26f69c 9014
5cc152c0
PE
9015 * menu.c (grow_menu_items): Check for int overflow.
9016
d89eb65e
PE
9017 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9018
5235bd3e
PE
9019 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9020 Before, the code was not consistent. These values cannot exceed
9021 2**31 - 1 so there's no need to make them unsigned.
9022 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9023 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9024 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9025 as modifiers.
9026 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9027
bc827e23
PE
9028 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9029 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9030 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9031 presumably because the widths might not match.
9032
78eb494e
PE
9033 * window.c (size_window): Avoid needless test at loop start.
9034
04f2d78b
CB
90352011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9036
9037 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9038
d2fc7e3d 90392011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9040
9041 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9042
d2fc7e3d 90432011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9044
9045 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9046 `width' to `bar_area_x' and `bar_area_width', respectively.
9047 (x_scroll_run): Take account of fringe background extension.
9048
04f2d78b
CB
9049 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9050 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9051 `bar_area_width', respectively.
9052 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9053 background extension.
9054
79b70037
GM
90552011-05-10 Jim Meyering <meyering@redhat.com>
9056
9057 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9058
2f142cc5
JB
90592011-05-10 Juanma Barranquero <lekktu@gmail.com>
9060
9061 * image.c (Finit_image_library): Return t for built-in image types,
9062 like pbm and xbm. (Bug#8640)
9063
57679c86
AS
90642011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9065
9066 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9067
888c9e86
EZ
90682011-05-07 Eli Zaretskii <eliz@gnu.org>
9069
b0512a1d
EZ
9070 * w32console.c (Fset_screen_color): Doc fix.
9071 (Fget_screen_color): New function.
9072 (syms_of_ntterm): Defsubr it.
9073
7285dc67
EZ
9074 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9075 unlink the temporary file if Fcall_process didn't create it in the
9076 first place.
9077 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9078 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9079 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9080 cue to call_process_cleanup not to close that handle.
9081
4d3fcc8e
BK
90822011-05-07 Ben Key <bkey76@gmail.com>
9083
9084 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9085 one of two shell specific rules, either bootstrap-temacs-CMD or
9086 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9087 to the previous implementation of the bootstrap-temacs rule.
9088 The bootstrap-temacs-CMD rule is similar to the previous
9089 implementation of the bootstrap-temacs rule except that it
9090 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9091 variable.
9092
9093 These changes, along with some changes to nt/configure.bat,
9094 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9095 earlier fix to add support for --cflags and --ldflags options
9096 that include quotes so that it works whether make uses cmd or
9097 sh as the shell.
9098
b4289b64
MA
90992011-05-06 Michael Albinus <michael.albinus@gmx.de>
9100
9101 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9102 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9103 is a constant.
9104 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9105 a string. Handle both cases.
9106 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9107 (Fdbus_register_method): Use Qinvalid_function.
9108
af4c0e28
JB
91092011-05-06 Juanma Barranquero <lekktu@gmail.com>
9110
9111 * makefile.w32-in: Update dependencies.
9112 (LISP_H): Add inttypes.h and stdin.h.
9113 (PROCESS_H): Add unistd.h.
9114
c51453d9
EZ
91152011-05-06 Eli Zaretskii <eliz@gnu.org>
9116
9117 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9118 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9119
8ff0ac3c 91202011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9121
4c4b566b
PE
9122 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9123
aab2b9b5
PE
9124 * term.c (vfatal): Remove stray call to va_end.
9125 It's not needed and the C Standard doesn't allow it here anyway.
9126
c378da0b
PE
9127 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9128 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9129
288b08c7
PE
9130 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9131 bytes.
9132
e3601888
PE
9133 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9134
db6c0e74
PE
9135 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9136
dd5963ea
PE
9137 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9138
88c9450f
PE
9139 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9140
2f9442b8
PE
9141 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9142
c032b5f8
PE
9143 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9144 * charset.c (Fdefine_charset_internal): Don't initialize
9145 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9146 32-bit int (Bug#8600).
a108c10b
PE
9147
9148 * lread.c (read_integer): Be more consistent with string-to-number.
9149 Use string_to_number to do the actual conversion; this avoids
9150 rounding errors and fixes some other screwups. Without this fix,
9151 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9152 (digit_to_number): Move earlier, for benefit of read_integer.
9153 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9154 not a digit in any supported base. (Bug#8602)
a108c10b 9155
ad5f9eea
PE
9156 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9157
aec1708a
PE
9158 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9159 to match comment at start of function. This also removes a
9160 GCC warning about overflow in a 32+64-bit port.
9161
47be4ab5
PE
9162 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9163
371cac43
PE
9164 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9165 Reported by Stefan Monnier in
9166 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9167 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9168 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9169
d01a7826
PE
9170 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9171 (EMACS_UINTPTR): Likewise, with uintptr_t.
9172
7fd47d5c
PE
9173 * lisp.h: Prefer 64-bit EMACS_INT if available.
9174 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9175 on 32-bit hosts that have 64-bit int, so that they can access
9176 large files.
122b0c86
PE
9177 However, temporarily disable this change unless the temporary
9178 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9179
8727937b
PE
9180 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9181
8ac068ac
PE
9182 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9183 This removes an assumption that EMACS_INT and long are the same
9184 width as pointers. The assumption is true for Emacs porting targets
9185 now, but we want to make other targets possible.
9186 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9187 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9188 In the rest of the code, change types of integers that hold casted
9189 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9190 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9191 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9192 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9193 No need to cast type when ORing.
9194 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9195 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9196 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9197 assume EMACS_INT is the same width as char *.
9198 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9199 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9200 Remove no-longer-needed casts.
9201 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9202 (xg_tool_bar_help_callback, xg_make_tool_item):
9203 Use EMACS_INTPTR to hold an integer
9204 that will be cast to void *; this can avoid a GCC warning
9205 if EMACS_INT is not the same width as void *.
9206 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9207 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9208 (current_message_1, set_message_1):
9209 Use a local to convert to proper width without a cast.
9210 * xmenu.c (dialog_selection_callback): Likewise.
9211
ede49d71
PE
9212 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9213 Also, don't assume VALBITS / RAND_BITS is less than 5,
9214 and don't rely on undefined behavior when shifting a 1 left into
9215 the sign bit.
9216 * lisp.h (get_random): Change signature to match.
9217
2f30ecd0
PE
9218 * lread.c (hash_string): Use size_t, not int, for hash computation.
9219 Normally we prefer signed values; but hashing is special, because
9220 it's better to use unsigned division on hash table sizes so that
9221 the remainder is nonnegative. Also, size_t is the natural width
9222 for hashing into memory. The previous code used 'int', which doesn't
9223 retain enough info to hash well into very large tables.
9224 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9225
2a866e7b
PE
9226 * dbusbind.c: Don't possibly lose pointer info when converting.
9227 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9228 Use XPNTR rather than XHASH, so that the high-order bits of
9229 the pointer aren't lost when converting through void *.
9230
51639eac
PE
9231 * eval.c (Fautoload): Don't double-shift a pointer.
9232
92394119
PE
9233 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9234
dbdb9a7c
JB
92352011-05-06 Juanma Barranquero <lekktu@gmail.com>
9236
9237 * gnutls.c (DEF_GNUTLS_FN):
9238 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9239
db7a0b4f
AS
92402011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9241
9242 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9243 marker. (Bug#8610)
9244
cd394be1 92452011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9246
9247 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9248 New version that can reserve upto 2GB of heap space.
9249
f7ff1b0f 92502011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9251
9252 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9253
639c109b
TZ
92542011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9255
9256 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9257 `gnutls_certificate_set_x509_key_file'.
9258
d2127135
JB
92592011-05-05 Juanma Barranquero <lekktu@gmail.com>
9260
9261 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9262 Update dependencies.
9263
e968f4f3
JB
92642011-05-04 Juanma Barranquero <lekktu@gmail.com>
9265
9266 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9267 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9268 Remove unused parameter `fildes'.
9269 * process.c (read_process_output, send_process): Don't pass it.
9270
84d358f0
JB
92712011-05-04 Juanma Barranquero <lekktu@gmail.com>
9272
9273 Fix previous change: the library cache is defined in w32.c.
9274 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9275 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9276
0898ca10
JB
92772011-05-04 Juanma Barranquero <lekktu@gmail.com>
9278
9279 Implement dynamic loading of GnuTLS on Windows.
9280
9281 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9282 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9283 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9284 Declare.
9285
9286 * gnutls.c (Qgnutls_dll): Define.
9287 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9288 (gnutls_*): Declare function pointers.
9289 (init_gnutls_functions): New function to initialize function pointers.
9290 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9291 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9292 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9293 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9294 (emacs_gnutls_write, emacs_gnutls_read)
9295 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9296 (Fgnutls_available_p): New function.
9297 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9298 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9299 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9300
9301 * image.c: Include w32.h.
9302 (Vimage_type_cache): Delete.
9303 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9304 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9305 (w32_delayed_load): Move to w32.c.
9306
9307 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9308
9309 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9310 (w32_delayed_load): Move from image.c. When loading a library, record
9311 its filename in the :loaded-from property of the library id.
9312 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9313 Initialize and staticpro them.
9314 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9315
9316 * process.c: Include lisp.h before w32.h, not after.
9317 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9318 instead of gnutls_record_check_pending.
9319
9320 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9321
ff4de4aa
TZ
93222011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9323
9324 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9325 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9326 as passed in.
9327
abe95abb
JD
93282011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9329
9330 * xterm.c (x_set_frame_alpha): Do not set property on anything
9331 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9332
e16e55d4
JB
93332011-05-02 Juanma Barranquero <lekktu@gmail.com>
9334
9335 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9336
bafcf6a5
JB
93372011-05-02 Juanma Barranquero <lekktu@gmail.com>
9338
9339 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9340 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9341 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9342 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9343 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9344 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9345 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9346 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9347 (Qgnutls_bootprop_callbacks_verify): Make static.
9348
e7a6747f
AS
93492011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9350
19ed11ba
AS
9351 * callproc.c: Indentation fixup.
9352
e7a6747f 9353 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9354 (wait_for_termination, interruptible_wait_for_termination):
9355 Move after wait_for_termination_1.
e7a6747f 9356
1ef14cb4
LMI
93572011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9358
9359 * sysdep.c (interruptible_wait_for_termination): New function
9360 which is like wait_for_termination, but allows keyboard
9361 interruptions.
9362
9363 * callproc.c (Fcall_process): Add (:file "file") as an option for
9364 the STDOUT buffer.
9365 (Fcall_process_region): Ditto.
9366
330d880c
EZ
93672011-04-30 Eli Zaretskii <eliz@gnu.org>
9368
8db90b73
EZ
9369 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9370 rather than `XVECTOR (FOO)->size'.
9371
330d880c
EZ
9372 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9373 inttypes.h, as a gnulib replacement is used if it not available in
9374 system headers.
9375
15cbd324
EZ
93762011-04-21 Eli Zaretskii <eliz@gnu.org>
9377
9378 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9379 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9380 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9381
9382 * coding.c (coding_alloc_by_realloc): Error out if destination
9383 will grow beyond MOST_POSITIVE_FIXNUM.
9384 (decode_coding_emacs_mule): Abort if there isn't enough place in
9385 charbuf for the composition carryover bytes. Reserve an extra
9386 space for up to 2 characters produced in a loop.
9387 (decode_coding_iso_2022): Abort if there isn't enough place in
9388 charbuf for the composition carryover bytes.
9389
93902011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9391
ae940cca
EZ
9392 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9393 aborting when %lld or %lll format is passed.
9394 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9395 %llo or %llx format is passed. (Bug#8545)
9396
03ab8921
EZ
9397 * window.c (window_scroll_line_based): Use a marker instead of
9398 simple variables to record original value of point. (Bug#7952)
9399
afda1437
EZ
9400 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9401 produced by %s or %c overflows available buffer space. (Bug#8545)
9402
f76dee0c
PE
94032011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9404
9405 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9406 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9407
fdc5744d
JB
94082011-04-28 Juanma Barranquero <lekktu@gmail.com>
9409
9410 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9411
638f053a
JB
94122011-04-28 Juanma Barranquero <lekktu@gmail.com>
9413
9414 * keyboard.c (Qdelayed_warnings_hook): Define.
9415 (command_loop_1): Run `delayed-warnings-hook'
9416 if Vdelayed_warnings_list is non-nil.
9417 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9418 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9419
d178f871
EZ
94202011-04-28 Eli Zaretskii <eliz@gnu.org>
9421
9422 * doprnt.c (doprnt): Don't return value smaller than the buffer
9423 size if the message was truncated. (Bug#8545).
9424
b124fd93
JB
94252011-04-28 Juanma Barranquero <lekktu@gmail.com>
9426
9427 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9428 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9429
e810457d
PE
94302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9431
9432 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9433
ea51cceb
JB
94342011-04-27 Juanma Barranquero <lekktu@gmail.com>
9435
9436 * makefile.w32-in: Update dependencies.
9437
94dcfacf
EZ
94382011-04-27 Eli Zaretskii <eliz@gnu.org>
9439
9440 Improve `doprnt' and its usage. (Bug#8545)
9441 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9442 `format_end'. Remove support for %l as a conversion specifier.
9443 Don't use xrealloc. Improve diagnostics when the %l size modifier
9444 is used. Update the commentary.
9445
9446 * eval.c (verror): Simplify calculation of size_t.
9447
9448 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9449 messages.
9450
f61f41d7
PE
94512011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9452
9453 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9454 change.
9455
96fb4434
PE
94562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9457
9458 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9459 This makes this file independent of the recent pseudovector change.
9460
671875da 94612011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9462
69e9b5a3
PE
9463 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9464
b5f869a7 9465 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9466 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9467 Remove unused local.
c8926152 9468 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9469
841a1577 9470 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9471 GCC 4.6.0 optimizes based on type-based alias analysis.
9472 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9473 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9474 != &v->size, and therefore "v->size = 1; b->size = 2; return
9475 v->size;" must therefore return 1. This assumption is incorrect
9476 for Emacs, since it type-puns struct Lisp_Vector * with many other
9477 types. To fix this problem, this patch adds a new type struct
f904488f 9478 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9479 and pseudovectors, and helps optimizing compilers not get fooled
9480 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9481 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9482 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9483 the size member.
eab3844f
PE
9484 (XSETPVECTYPE): Rewrite in terms of new macro.
9485 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9486 This is a bit clearer, and further avoids the possibility of
9487 undesirable aliasing.
9488 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9489 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9490 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9491 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9492 (ASIZE): Now uses header.size rather than size.
9493 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9494 to avoid the hassle of writing XVECTOR (foo)->header.size.
9495 (struct vectorlike_header): New type.
eab3844f
PE
9496 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9497 object, to help avoid aliasing.
9498 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9499 (SUBRP): Likewise, since Lisp_Subr is a special case.
9500 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9501 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9502 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9503 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9504 changed to be "header.size" and "header.next".
9505 * buffer.h (struct buffer): Likewise.
9506 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9507 * frame.h (struct frame): Likewise.
9508 * process.h (struct Lisp_Process): Likewise.
9509 * termhooks.h (struct terminal): Likewise.
9510 * window.c (struct save_window_data, struct saved_window): Likewise.
9511 * window.h (struct window): Likewise.
9512 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9513 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9514 * buffer.c (init_buffer_once): Likewise.
9515 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9516 special case.
9517 * process.c (Fformat_network_address): Use local var for size,
9518 for brevity.
9519
0df1eac5
PE
9520 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9521
847ab9d1 9522 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9523 * data.c (atof): Remove decl; no longer used or needed.
9524 (digit_to_number): Move to lread.c.
9525 (Fstring_to_number): Use new string_to_number function, to be
9526 consistent with how the Lisp reader treats infinities and NaNs.
9527 Do not assume that floating-point numbers represent EMACS_INT
9528 without losing information; this is not true on most 64-bit hosts.
9529 Avoid double-rounding errors, by insisting on integers when
9530 parsing non-base-10 numbers, as the documentation specifies.
9531 * lisp.h (string_to_number): New decl, replacing ...
9532 (isfloat_string): Remove.
bc0a5c13 9533 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9534 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9535 appears to have been a coding error. Similarly, do not accept
9536 strings like +-1e0 as floating point numbers. Do not report
9537 overflow for integer overflows unless the base is not 10 which
9538 means we have no simple and reliable way to continue.
9539 Break out the floating-point parsing into a new
9540 function string_to_number, so that Fstring_to_number parses
9541 floating point numbers consistently with the Lisp reader.
04f2d78b 9542 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9543 (E_CHAR, EXP_INT): Remove, replacing with ...
9544 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9545 (string_to_number): New function, replacing isfloat_string.
9546 This function checks for valid syntax and produces the resulting
9547 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9548 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9549 so that overflow for non-base-10 numbers is reported only when
9550 there's no portable and simple way to convert to floating point.
452f4150 9551
67769ffc
PE
9552 * textprop.c (set_text_properties_1): Rewrite for clarity,
9553 and to avoid GCC warning about integer overflow.
9554
c20db43f
PE
9555 * intervals.h (struct interval): Use EMACS_INT for members
9556 where EMACS_UINT might cause problems. See
9557 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9558 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9559 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9560 All uses changed.
37aa2f85
PE
9561 (offset_intervals): Tell GCC not to worry about length overflow
9562 when negating a negative length.
c20db43f 9563
2538aa2f
PE
9564 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9565 (overrun_check_free): Likewise.
9566
f2d3008d
PE
9567 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9568 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9569 word size.
9570
ec8df744
PE
9571 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9572 (gnutls_make_error): Rename local to avoid shadowing.
9573 (gnutls_emacs_global_deinit): ifdef out; not used.
9574 (Fgnutls_boot): Use const for pointer to readonly storage.
9575 Comment out unused local. Fix pointer signedness problems.
9576
640ee02d
PE
9577 * lread.c (openp): Don't stuff size_t into an 'int'.
9578 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9579 about possible signed overflow.
9580
6048fb2a
PE
9581 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9582 (GDK_KEY_g): Don't define if already defined.
9583 (xg_prepare_tooltip): Avoid pointer signedness problem.
9584 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9585
fa3c87e1
PE
9586 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9587 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9588
2172544b
PE
9589 * xfns.c (Fx_window_property): Simplify a bit,
9590 to make a bit faster and to avoid GCC 4.6.0 warning.
9591 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9592
9b821a21
PE
9593 * fns.c (internal_equal): Don't assume size_t fits in int.
9594
3c616cfa
PE
9595 * alloc.c (compact_small_strings): Tighten assertion a little.
9596
c2982e87
PE
9597 Replace pEd with more-general pI, and fix some printf arg casts.
9598 * lisp.h (pI): New macro, generalizing old pEd macro to other
9599 conversion specifiers. For example, use "...%"pI"d..." rather
9600 than "...%"pEd"...".
9601 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9602 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9603 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9604 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9605 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9606 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9607 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9608 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9609 64-bit hosts.
9610 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9611 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9612 * print.c (safe_debug_print, print_object): Likewise.
9613 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9614 to int.
6f04d126
PE
9615 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9616 avoiding the 0 flag, which is not portable.
c2982e87
PE
9617 * process.c (Fmake_network_process): Use pI to avoid cast.
9618 * region-cache.c (pp_cache): Likewise.
9619 * xdisp.c (decode_mode_spec): Likewise.
9620 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9621 behavior on 64-bit hosts with printf arg.
6f04d126 9622 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9623 (x_stop_queuing_selection_requests): Likewise.
9624 (x_get_window_property): Don't truncate byte count to an 'int'
9625 when tracing.
0b432f21 9626
5e073ec7
PE
9627 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9628 here, since it parses constructs like leading '-' and spaces,
9629 which are not wanted; and it overflows with large numbers.
9630 Instead, simply match F[0-9]+, which is what is wanted anyway.
9631
36372bf9
PE
9632 * alloc.c: Remove unportable assumptions about struct layout.
9633 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9634 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9635 (allocate_vectorlike, make_pure_vector): Use the new macros,
9636 plus offsetof, to remove unportable assumptions about struct layout.
9637 These assumptions hold on all porting targets that I know of, but
9638 they are not guaranteed, they're easy to remove, and removing them
9639 makes further changes easier.
9640
0b432f21
PE
9641 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9642 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9643 (string_overrun_cookie): Now const. Use initializers that
9644 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9645 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9646 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9647 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9648 multiple of sizeof (EMACS_INT); it need not be, if
9649 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9650 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9651
895009e1
JB
96522011-04-26 Juanma Barranquero <lekktu@gmail.com>
9653
9654 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9655
6a7a1b0b
TZ
96562011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9657
9658 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9659 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9660 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9661
841a1577 96622011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9663
9664 * lisp.h (Qdebug): List symbol.
895009e1 9665 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9666 * keyboard.c (debug-on-event): New variable.
9667 (handle_user_signal): Break into debugger when debug-on-event
9668 matches the current signal symbol.
9669
f2d3ba6f
DN
96702011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9671
9672 * alloc.c (check_sblock, check_string_bytes)
9673 (check_string_free_list): Convert to standard C.
9674
42ce4c63
TZ
96752011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9676
9677 * w32.c (emacs_gnutls_push): Fix typo.
9678
825cd63c
EZ
96792011-04-25 Eli Zaretskii <eliz@gnu.org>
9680
fb11d64d
EZ
9681 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9682 "cast to pointer from integer of different size".
9683
825cd63c
EZ
9684 Improve doprnt and its use in verror. (Bug#8545)
9685 * doprnt.c (doprnt): Document the set of format control sequences
9686 supported by the function. Use SAFE_ALLOCA instead of always
9687 using `alloca'.
9688
9689 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9690 is one byte too soon. Don't use xrealloc; instead xfree and
9691 xmalloc anew.
9692
e061a11b
TZ
96932011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9694
9695 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9696 callbacks stage.
9697
9698 * gnutls.c: Renamed global_initialized to
9699 gnutls_global_initialized. Added internals for the
9700 :verify-hostname-error, :verify-error, and :verify-flags
9701 parameters of `gnutls-boot' and documented those parameters in the
9702 docstring. Start callback support.
9173deec
JB
9703 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9704 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9705 on error. Return error code.
e061a11b
TZ
9706 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9707 (emacs_gnutls_read): Likewise.
9708 (Fgnutls_boot): Return handshake error code.
9709 (emacs_gnutls_handle_error): New function.
9710 (wsaerror_to_errno): Likewise.
9711
9712 * w32.h (emacs_gnutls_pull): Add prototype.
9713 (emacs_gnutls_push): Likewise.
9714
9715 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9716 (emacs_gnutls_push): Likewise.
9717
97182011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9719
9720 * process.c (wait_reading_process_output): Check if GnuTLS
9721 buffered some data internally if no FDs are set for TLS
9722 connections.
9723
9724 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9725 (LIBS): Link to USER_LIBS.
9726 ($(BLD)/gnutls.$(0)): New target.
9727
fa6996bc
EZ
97282011-04-24 Eli Zaretskii <eliz@gnu.org>
9729
eb35682e
EZ
9730 * xdisp.c (handle_single_display_spec): Rename the
9731 display_replaced_before_p argument into display_replaced_p, to
9732 make it consistent with the commentary. Fix typos in the
9733 commentary.
9734
e2ad650c
EZ
9735 * textprop.c (syms_of_textprop): Remove dead code.
9736 (copy_text_properties): Delete obsolete commentary about an
9737 interface that was deleted long ago. Fix typos in the description
9738 of arguments.
9739
1b2de274
EZ
9740 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9741 to changes in oldXMenu/XMenu.h from 2011-04-16.
9742 <menu_help_message, prev_menu_help_message>: Constify.
9743 (IT_menu_make_room): menu->help_text is now `const char **';
9744 adjust.
9745
9746 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9747 to changes in oldXMenu/XMenu.h from 2011-04-16.
9748 (struct XMenu): Declare `help_text' `const char **'.
9749
9750 * xfaces.c <Qunspecified>: Make extern again.
9751
9752 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9753 required by POSIX.
1b2de274 9754
762b15be
EZ
9755 * doc.c (get_doc_string): Improve the format passed to `error'.
9756
9757 * doprnt.c (doprnt): Improve commentary.
9758
9759 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9760
9761 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9762 them with etags.
9763
f1052e5d
EZ
9764 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9765 changes in globals.h immediately force recompilation.
762b15be
EZ
9766 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9767 $(CURDIR)/s/ms-w32.h.
9768 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9769
fa6996bc
EZ
9770 * character.c (Fchar_direction): Function deleted.
9771 (syms_of_character): Don't defsubr it.
9772 <char-direction-table>: Deleted.
9773
e6c3da20
EZ
97742011-04-23 Eli Zaretskii <eliz@gnu.org>
9775
9776 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9777 * doprnt.c: Include limits.h.
9778 (SIZE_MAX): New macro.
04f2d78b
CB
9779 (doprnt): Return a size_t value. 2nd arg is now size_t.
9780 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9781 Improve overflow protection. Support `l' modifier for integer
9782 conversions. Support %l conversion. Don't assume an EMACS_INT
9783 argument for integer conversions and for %c.
9784
9785 * lisp.h (doprnt): Restore prototype.
9786
9787 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9788 $(SRC)/character.h.
9789
9790 * Makefile.in (base_obj): Add back doprnt.o.
9791
9792 * deps.mk (doprnt.o): Add back prerequisites.
9793 (callint.o): Depend on character.h.
9794
9795 * eval.c (internal_lisp_condition_case): Include the handler
9796 representation in the error message.
9797 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9798 when breaking from the loop.
9799
9800 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9801
9802 * callint.c (Fcall_interactively): When displaying error message
9803 about invalid control letter, pass the character's codepoint, not
9804 a pointer to its multibyte form. Improve display of the character
9805 in octal and display also its hex code.
9806
9807 * character.c (char_string): Use %x to display the (unsigned)
9808 codepoint of an invalid character, to avoid displaying a bogus
9809 negative value.
9810
9811 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9812 `error', not SYMBOL_NAME itself.
9813
9814 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9815 character arguments to `error'.
9816
9817 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9818 to `error' in error message about FINAL_CHAR argument. Make sure
9819 FINAL_CHAR is a character, and use %c when it is passed as
9820 argument to `error'.
9821
4ffd0d6b 98222011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9823
9824 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9825
9826 * w32.c: Include <time.h>.
9827 (sys_localtime): New function.
9828
4ffd0d6b 98292011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9830
9831 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9832
4ffd0d6b 9833 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9834
4ffd0d6b 98352011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9836
4ffd0d6b
GM
9837 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9838 zombies (Bug#8467).
aac0c6e3 9839
04c56954
EZ
98402011-04-19 Eli Zaretskii <eliz@gnu.org>
9841
9842 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9843 gl_state.e_property when gl_state.object is Qt.
9844
9845 * insdel.c (make_gap_larger): Remove limitation of buffer size
9846 to <= INT_MAX.
9847
16a43933
CY
98482011-04-18 Chong Yidong <cyd@stupidchicken.com>
9849
9850 * xdisp.c (lookup_glyphless_char_display)
9851 (produce_glyphless_glyph): Handle cons cell entry in
9852 glyphless-char-display.
9853 (Vglyphless_char_display): Document it.
9854
9855 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9856 glyphless-char-display.
9857
4581706e
CY
98582011-04-17 Chong Yidong <cyd@stupidchicken.com>
9859
9860 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9861
9862 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9863
9864 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9865 definition for no-X builds.
9866
4887c6e2 98672011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9868
fd35b6f9
PE
9869 Static checks with GCC 4.6.0 and non-default toolkits.
9870
5c1ccb01
PE
9871 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9872
006c5daa
PE
9873 * process.c (keyboard_bit_set): Define only if SIGIO.
9874 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9875 (send_process): Repair possible setjmp clobbering.
9876
efc736d3
PE
9877 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9878
4e2fe2e6
PE
9879 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9880
f97334a2
PE
9881 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9882
4e75f29d
PE
9883 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9884 Define only if needed.
9885
90efadd1
PE
9886 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9887 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9888 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9889
3c647824
PE
9890 * dispextern.h (struct redisplay_interface): Rename param
9891 to avoid shadowing.
e264f262 9892 * termhooks.h (struct terminal): Likewise.
761383f4 9893 * xterm.c (xembed_send_message): Likewise.
3c647824 9894
b58c5c4a
PE
9895 * insdel.c (make_gap_smaller): Define only if
9896 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9897
cad59032
PE
9898 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9899 it.
9900
c339dc2e
PE
9901 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9902 so that we aren't warned about unused symbols.
9903
91a3e27b
PE
9904 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9905
399c71d3 9906 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9907
8ffc96f5
PE
9908 * xfns.c (x_real_positions): Mark locals as initialized.
9909
eef9bc79
PE
9910 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9911
098db9dd
PE
9912 * xterm.c: Fix problems found by static analysis with other toolkits.
9913 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9914 (x_dispatch_event): Declare static if USE_GTK, and
9915 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9916 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9917 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9918 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9919 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9920
eb18f6cc
PE
9921 * xmenu.c (menu_help_callback): Pointer type fixes.
9922 Use const pointers when pointing at readonly data. Avoid pointer
9923 signedness clashes.
9924 (FALSE): Remove unused macro.
9925 (update_frame_menubar): Remove unused decl.
9926
1fe72bf8
PE
9927 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9928
60d9e1db
PE
9929 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9930 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9931 (single_menu_item): Rename local to avoid shadowing.
9932
39261c26
PE
9933 * keyboard.c (make_lispy_event): Remove unused local var.
9934
018c5e19
PE
9935 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9936 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9937
63d2b86e
PE
9938 * bitmaps: Change bitmaps from unsigned char back to the X11
9939 compatible char. Avoid the old compiler warnings about
9940 out-of-range initializers by using, for example, '\xab' rather
9941 than 0xab.
9942
aefd87e1
PE
9943 * xgselect.c (xgselect_initialize): Check vs interface
9944 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9945
bf501fb9
PE
9946 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9947
e9829fdf
PE
9948 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9949 to read-only memory.
9950
1086c095
PE
9951 * fns.c (vector): Remove; this old hack is no longer needed.
9952
2baccd04 9953 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9954 Remove unused var.
dde42981 9955 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9956
72391843 9957 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9958
436c16df 9959 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9960 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9961 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9962
92bb796d 9963 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9964 (x_term_init): Remove local to avoid shadowing.
92bb796d 9965
764430a3 9966 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9967
9968 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9969 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9970
d1dfb56c
EZ
99712011-04-16 Eli Zaretskii <eliz@gnu.org>
9972
c4354cb4
EZ
9973 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9974
d1dfb56c
EZ
9975 Fix regex.c, syntax.c and friends for buffers > 2GB.
9976 * syntax.h (struct gl_state_s): Declare character position members
9977 EMACS_INT.
9978
9979 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9980
04f2d78b
CB
9981 * textprop.c (verify_interval_modification, interval_of):
9982 Declare arguments EMACS_INT.
d1dfb56c
EZ
9983
9984 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9985 EMACS_INT.
9986
9987 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9988
9989 * indent.c (Fvertical_motion): Local variable it_start is now
9990 EMACS_INT.
9991
9992 * regex.c (re_match, re_match_2, re_match_2_internal)
9993 (bcmp_translate, regcomp, regexec, print_double_string)
9994 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9995 (re_compile_pattern, re_exec): Declare arguments and local
9996 variables `size_t' and `ssize_t' and return values `regoff_t', as
9997 appropriate.
9998 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9999 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10000 <compile_stack_type>: `size' and `avail' are now `size_t'.
10001
10002 * regex.h <regoff_t>: Use ssize_t, not int.
10003 (re_search, re_search_2, re_match, re_match_2): Arguments that
10004 specify buffer/string position and length are now ssize_t and
10005 size_t. Return type is regoff_t.
10006
613052cd
BK
100072011-04-16 Ben Key <bkey76@gmail.com>
10008
10009 * nsfont.m: Fixed bugs in ns_get_family and
10010 ns_descriptor_to_entity that were caused by using free to
10011 deallocate memory blocks that were allocated by xmalloc (via
10012 xstrdup). This caused Emacs to crash when compiled with
10013 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10014 --enable-checking=xmallocoverrun). xfree is now used to
10015 deallocate these memory blocks.
10016
4170f62f 100172011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10018
71b41406
PE
10019 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10020
9587a89d
PE
10021 emacs_write: Accept and return EMACS_INT for sizes.
10022 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10023 et seq.
10024 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10025 Accept and return EMACS_INT.
10026 (emacs_gnutls_write): Return the number of bytes written on
10027 partial writes.
10028 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10029 (emacs_read, emacs_write): Remove check for negative size, as the
10030 Emacs source code has been audited now.
9587a89d
PE
10031 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10032 (emacs_read, emacs_write): Use it.
273a5f82
PE
10033 * process.c (send_process): Adjust to the new signatures of
10034 emacs_write and emacs_gnutls_write. Do not attempt to store
10035 a byte offset into an 'int'; it might overflow.
9587a89d 10036 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10037
3e047f51
PE
10038 * sound.c: Don't assume sizes fit in 'int'.
10039 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10040 Return EMACS_INT, not int.
3e047f51 10041 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10042 Accept EMACS_INT, not int.
10043 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10044 record read return values.
10045
cc39a9db
BK
100462011-04-15 Ben Key <bkey76@gmail.com>
10047
c9d0ec6d
JB
10048 * keyboard.c (Qundefined): Don't declare static since it is used
10049 in nsfns.m.
10050 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10051 static since they are used in nsfont.m.
cc39a9db 10052
6c60eb9f
SM
100532011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10054
10055 * process.c (Qprocessp): Don't declare static.
10056 * lisp.h (Qprocessp): Declare again.
10057
7990b61a
JB
100582011-04-15 Juanma Barranquero <lekktu@gmail.com>
10059
10060 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10061
5d4cb038
PE
100622011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10063
8bd7b830 10064 Improve C-level modularity by making more things 'static'.
cd64ea1d 10065
e3b27b31
PE
10066 Don't publish debugger-only interfaces to other modules.
10067 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10068 (verify_bytepos, count_markers): Move decls to the only modules
10069 that need them.
10070 * region-cache.h (pp_cache): Likewise.
10071 * window.h (check_all_windows): Likewise.
10072 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10073
5d4cb038
PE
10074 * sysdep.c (croak): Now static, if
10075 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10076 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10077
10078 * alloc.c (refill_memory_reserve): Now static if
10079 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10080 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10081
e87b6180
PE
10082 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10083 Define only if USE_LUCID.
10084
ac64929e
PE
10085 * xrdb.c (x_customization_string, x_rm_string): Now static.
10086
6f37259d
PE
10087 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10088 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10089
1683e3ab
PE
10090 * xdisp.c (draw_row_with_mouse_face): Now static.
10091 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10092
de9c2632
PE
10093 * window.h (check_all_windows): Mark externally visible.
10094
2b96acb7
PE
10095 * window.c (window_deletion_count): Now static.
10096
10097 * undo.c: Make symbols static if they're not exported.
10098 (last_undo_buffer, last_boundary_position, pending_boundary):
10099 Now static.
10100
50436f33
PE
10101 * textprop.c (interval_insert_behind_hooks): Now static.
10102 (interval_insert_in_front_hooks): Likewise.
10103
64520e5c
PE
10104 * term.c: Make symbols static if they're not exported.
10105 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10106 (max_frame_lines, tty_set_terminal_modes):
10107 (tty_reset_terminal_modes, tty_turn_off_highlight):
10108 (get_tty_terminal): Now static.
10109 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10110 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10111 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10112 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10113 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10114
1fa53021
PE
10115 * sysdep.c: Make symbols static if they're not exported.
10116 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10117 Now static.
10118 (sigprocmask_set, full_mask): Remove; unused.
10119 (wait_debugging): Mark as visible.
10120 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10121 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10122
d4b43b22
PE
10123 * syntax.c (syntax_temp): Define only if !__GNUC__.
10124
b7c513d0
PE
10125 * sound.c (current_sound_device, current_sound): Now static.
10126
989b29ad
PE
10127 * search.c (searchbufs, searchbuf_head): Now static.
10128
13a55a78
PE
10129 * scroll.c (scroll_cost): Remove; unused.
10130 * dispextern.h (scroll_cost): Remove decl.
10131
de68a1fc
PE
10132 * region-cache.h (pp_cache): Mark as externally visible.
10133
40ccffa6
PE
10134 * process.c: Make symbols static if they're not exported.
10135 (process_tick, update_tick, create_process, chan_process):
10136 (Vprocess_alist, proc_buffered_char, datagram_access):
10137 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10138 (deactivate_process): Mark defn as static, as well as decl.
10139 * lisp.h (create_process): Remove decl.
10140 * process.h (chan_process, Vprocess_alist): Remove decls.
10141
ad64fc97
PE
10142 * print.c: Make symbols static if they're not exported.
10143 (print_depth, new_backquote_output, being_printed, print_buffer):
10144 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10145 (print_interval, print_number_index, initial_stderr_stream):
10146 Now static.
10147 * lisp.h (Fprinc): Remove decl.
10148 (debug_output_compilation_hack): Mark as externally visible.
10149
adddb265
PE
10150 * sysdep.c (croak): Move decl from here to syssignal.h.
10151 * syssignal.h (croak): Put it here, so the API can be checked when
10152 'croak' is called from dissociate_if_controlling_tty.
10153
1717ede2
PE
10154 * minibuf.c: Make symbols static if they're not exported.
10155 (minibuf_save_list, choose_minibuf_frame): Now static.
10156 * lisp.h (choose_minibuf_frame): Remove decl.
10157
fa5fb2bc
PE
10158 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10159
1e3890d1
PE
10160 * lread.c: Make symbols static if they're not exported.
10161 (read_objects, initial_obarray, oblookup_last_bucket_number):
10162 Now static.
10163 (make_symbol): Remove; unused.
10164 * lisp.h (initial_obarray, make_symbol): Remove decls.
10165
8a1414fa
PE
10166 * keyboard.c: Make symbols static if they're not exported.
10167 (single_kboard, recent_keys_index, total_keys, recent_keys):
10168 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10169 (this_single_command_key_start, echoing, last_auto_save):
10170 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10171 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10172 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10173 (Vlispy_mouse_stem, double_click_count):
10174 Now static.
10175 (force_auto_save_soon): Define only if SIGDANGER.
10176 (ignore_mouse_drag_p): Now static if
10177 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10178 (print_help): Remove; unused.
10179 (stop_character, last_timer_event): Mark as externally visible.
10180 * keyboard.h (ignore_mouse_drag_p): Declare only if
10181 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10182 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10183 * lisp.h (echoing): Remove decl.
10184 (force_auto_save_soon): Declare only if SIGDANGER.
10185 * xdisp.c (redisplay_window): Simplify code, to make it more
10186 obvious that ignore_mouse_drag_p is not accessed if !defined
10187 USE_GTK && !defined HAVE_NS.
10188
93ea6e8f
PE
10189 * intervals.c: Make symbols static if they're not exported.
10190 (merge_properties_sticky, merge_interval_right, delete_interval):
10191 Now static.
10192 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10193
77382fcc
PE
10194 * insdel.c: Make symbols static if they're not exported.
10195 However, leave prepare_to_modify_buffer alone. It's never
10196 called from outside this function, but that appears to be a bug.
10197 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10198 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10199 (adjust_after_replace_noundo): Remove; unused.
10200 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10201 (signal_before_change): Remove decls.
77382fcc 10202
9306c32e
PE
10203 * indent.c (val_compute_motion, val_vmotion): Now static.
10204
cd44d2eb
PE
10205 * image.c: Make symbols static if they're not exported.
10206 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10207 if USE_GTK.
10208 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10209 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10210
ad9a7a06
PE
10211 * fringe.c (standard_bitmaps): Now static.
10212 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10213
81626931
PE
10214 * frame.c: Make symbols static if they're not exported.
10215 (x_report_frame_params, make_terminal_frame): Now static.
10216 (get_frame_param): Now static, unless HAVE_NS.
10217 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10218 (x_get_resource_string): Remove; not used.
10219 * frame.h (make_terminal_frame, x_report_frame_params):
10220 (x_get_resource_string); Remove decls.
10221 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10222 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10223
239f9db9
PE
10224 * font.c, fontset.c: Make symbols static if they're not exported.
10225 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10226 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10227 * font.c (font_close_object): Now static.
10228 * font.h (font_close_object): Remove.
10229 * fontset.c (FONTSET_OBJLIST): Remove.
10230 (free_realized_fontset) #if-0 the body, which does nothing.
10231 (face_suitable_for_char_p): #if-0, as it's never called.
10232 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10233 * xfaces.c (face_at_string_position):
10234 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10235 since 0 is always ASCII.
10236
dfcf3579
PE
10237 * fns.c (weak_hash_tables): Now static.
10238
5045092b
PE
10239 * fileio.c: Make symbols static if they're not exported.
10240 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10241 (Vwrite_region_annotation_buffers): Now static.
10242
57a96f5c
PE
10243 * eval.c: Make symbols static if they're not exported.
10244 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10245 * lisp.h (backtrace_list): Remove decl.
10246
35f08c38
PE
10247 * emacs.c: Make symbols static if they're not exported.
10248 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10249 (fatal_error_code, fatal_error_signal_hook, standard_args):
10250 Now static.
10251 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10252 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10253 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10254 * lisp.h (fatal_error_signal_hook): Remove decl.
10255 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10256
f44bd759
PE
10257 * editfns.c: Move a (normally-unused) function to its only use.
10258 * editfns.c, lisp.h (get_operating_system_release): Remove.
10259 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10260 worth the hassle of breaking this out.
10261
b532497d
PE
10262 * xterm.c: Make symbols static if they're not exported.
10263 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10264 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10265 (x_destroy_window, x_delete_display):
10266 Now static.
10267 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10268 (x_mouse_leave): Remove; unused.
10269 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10270 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10271 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10272 Remove decls.
10273 (x_mouse_leave): Declare only if WINDOWSNT.
10274 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10275 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10276 USE_X_TOOLKIT.
10277
1675728f
PE
10278 * ftxfont.c: Make symbols static if they're not exported.
10279 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10280 HAVE_FREETYPE.
10281 * font.h (ftxfont_driver): Likewise.
10282
e4cebfca
PE
10283 * xfns.c: Make symbols static if they're not exported.
10284 (x_last_font_name, x_display_info_for_name):
10285 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10286 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10287 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10288 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10289 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10290 (last_show_tip_args): Now static.
10291 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10292 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10293 (x_screen_planes): Remove; unused.
10294 * dispextern.h (x_screen_planes): Remove decl.
10295
5bf46f05
PE
10296 * dispnew.c: Make symbols static if they're not exported.
10297 * dispextern.h (redraw_garbaged_frames, scrolling):
10298 (increment_row_positions): Remove.
10299 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10300 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10301 Now static.
10302 (redraw_garbaged_frames): Remove; unused.
10303
435f4c28
PE
10304 * xfaces.c: Make symbols static if they're not exported.
10305 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10306 Remove decls.
10307 * xterm.h (defined_color): Remove decls.
10308 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10309 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10310 (menu_face_changed_default, defined_color, free_realized_face):
10311 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10312 (ascii_face_of_lisp_face): Remove; unused.
10313
8524aef3
PE
10314 * xdisp.c: Make symbols static if they're not exported.
10315 * dispextern.h (scratch_glyph_row, window_box_edges):
10316 (glyph_to_pixel_coords, set_cursor_from_row):
10317 (get_next_display_element, set_iterator_to_next):
10318 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10319 (show_mouse_face): Remove decls
10320 * frame.h (message_buf_print): Likewise.
10321 * lisp.h (pop_message, set_message, check_point_in_composition):
10322 Likewise.
10323 * xterm.h (set_vertical_scroll_bar): Likewise.
10324 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10325 (message_buf_print, scratch_glyph_row, displayed_buffer):
10326 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10327 (get_next_display_element, show_mouse_face, window_box_edges):
10328 (frame_to_window_pixel_xy, check_point_in_composition):
10329 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10330 (glyph_to_pixel_coords): Remove; unused.
10331
16390cd2
PE
10332 * dired.c (file_name_completion): Now static.
10333
10334 * dbusbind.c (xd_in_read_queued_messages): Now static.
10335
a25f4dfa
PE
10336 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10337 * data.c (circular_list_error): Remove.
10338
14a9c8df
PE
10339 * commands.h (last_point_position, last_point_position_buffer):
10340 (last_point_position_window): Remove decls.
10341 * keyboard.c: Make these variables static.
10342
04f2d78b
CB
10343 * coding.h (coding, code_convert_region, encode_coding_gap):
10344 Remove decls.
74ab6df5
PE
10345 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10346 (iso_code_class, detect_coding, code_convert_region): Now static.
10347 (encode_coding_gap): Remove; unused.
10348
38dfbee1
PE
10349 * chartab.c (chartab_chars, chartab_bits): Now static.
10350
a2cb4e63
PE
10351 * charset.h (charset_iso_8859_1): Remove decl.
10352 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10353 Now static.
10354
127198fd
PE
10355 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10356 * ccl.c (Vccl_program_table): Now static.
10357 (check_ccl_update): Remove; unused.
10358
d85b608f
PE
10359 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10360 * category.h: ... from here.
10361 * category.c (check_category_table, set_category_set): Now static.
10362
31cd66f3
PE
10363 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10364 * lisp.h: Remove these decls.
10365
c358e587
PE
10366 * buffer.c (buffer_count): Remove unused var.
10367
e78aecca
PE
10368 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10369 so that it's not optimized away.
10370 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10371 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10372 exported only to the debugger.
10373
e192d7d3 10374 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10375 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10376
92470028
PE
10377 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10378 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10379 was inaccessible from Lisp.
10380 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10381 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10382
244ed907
PE
10383 alloc.c: Import and export fewer symbols, and remove unused items.
10384 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10385 is defined.
10386 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10387 it's not optimized away by whole-program optimization.
10388 (message_enable_multibyte, free_misc): Remove.
10389 (catchlist, handlerlist, mark_backtrace):
10390 Declare only if BYTE_MARK_STACK.
10391 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10392 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10393 (message_enable_multibyte): Remove decl.
10394 (free_misc, interval_free_list, float_block, float_block_index):
10395 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10396 (cons_free_list, last_marked_index):
10397 Now static.
10398 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10399 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10400 (mark_backtrace): Define only if BYTE_MARK_STACK.
10401 * xdisp.c (message_enable_multibyte): Now static.
10402
61c2b50e 10403 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10404 This makes it easier for human readers (and static analyzers)
10405 to see whether these variables are used from other modules.
10406 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10407 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10408 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10409 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10410 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10411 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10412 * xmenu.c, xselect.c:
10413 Declare Q* vars static if they are not used in other modules.
10414 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10415 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10416 Remove decls of unexported vars.
10417 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10418
95c82688
PE
10419 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10420
16a97296
PE
10421 Make Emacs functions such as Fatom 'static' by default.
10422 This makes it easier for human readers (and static analyzers)
10423 to see whether these functions can be called from other modules.
10424 DEFUN now defines a static function. To make the function external
10425 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10426 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10427 (Finit_image_library):
16a97296
PE
10428 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10429 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10430 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10431 Remove decls, since these functions are now static.
10432 (Funintern, Fget_internal_run_time): New decls, since these functions
10433 were already external.
95c82688 10434
16a97296
PE
10435 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10436 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10437 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10438 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10439 * keyboard.c, keymap.c, lread.c:
10440 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10441 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10442 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10443 Mark functions with DEFUE instead of DEFUN,
10444 if they are used in other modules.
10445 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10446 decls for now-static functions.
10447 * buffer.h (Fdelete_overlay): Remove decl.
10448 * callproc.c (Fgetenv_internal): Mark as internal.
10449 * composite.c (Fremove_list_of_text_properties): Remove decl.
10450 (Fcomposition_get_gstring): New forward static decl.
10451 * composite.h (Fcomposite_get_gstring): Remove decl.
10452 * dired.c (Ffile_attributes): New forward static decl.
10453 * doc.c (Fdocumntation_property): New forward static decl.
10454 * eval.c (Ffetch_bytecode): New forward static decl.
10455 (Funintern): Remove extern decl; now in .h file where it belongs.
10456 * fileio.c (Fmake_symbolic_link): New forward static decl.
10457 * image.c (Finit_image_library): New forward static decl.
10458 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10459 * intervals.h (Fprevious_property_change):
10460 (Fremove_list_of_text_properties): Remove decls.
10461 * keyboard.c (Fthis_command_keys): Remove decl.
10462 (Fcommand_execute): New forward static decl.
10463 * keymap.c (Flookup_key): New forward static decl.
10464 (Fcopy_keymap): Now static.
10465 * keymap.h (Flookup_key): Remove decl.
10466 * process.c (Fget_process): New forward static decl.
10467 (Fprocess_datagram_address): Mark as internal.
10468 * syntax.c (Fsyntax_table_p): New forward static decl.
10469 (skip_chars): Remove duplicate decl.
10470 * textprop.c (Fprevious_property_change): New forward static decl.
10471 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10472 Now internal.
10473 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10474 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10475
785bbd42
PE
10476 * editfns.c (Fformat): Remove unreachable code.
10477
8b913b57
AS
104782011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10479
10480 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10481 change. (Bug#8496)
10482
a6744a35
EZ
104832011-04-13 Eli Zaretskii <eliz@gnu.org>
10484
10485 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10486 when at ZV. (Bug#8487)
10487
e7974947
AS
104882011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10489
baad03f0
AS
10490 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10491 (Bug#8437)
10492 * keyboard.c (parse_tool_bar_item): Likewise.
10493 * sound.c (sound_cleanup, alsa_close): Likewise.
10494 * termcap.c (tgetent): Likewise.
10495 * xfns.c (x_default_font_parameter): Likewise.
10496 * xsettings.c (read_and_apply_settings): Likewise.
10497
e7974947
AS
10498 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10499 (overrun_check_free): Protoize.
10500
28272684
PE
105012011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10502
10503 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10504 since callers should never pass a negative size.
10505 Change the signature to match that of plain 'read' and 'write'; see
10506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10507 * lisp.h: Update prototypes of emacs_write and emacs_read.
10508
11997c76
EZ
105092011-04-11 Eli Zaretskii <eliz@gnu.org>
10510
10511 * xdisp.c (redisplay_window): Don't try to determine the character
10512 position of the scroll margin if the window start point w->startp
e896f03c 10513 is outside the buffer's accessible region. (Bug#8468)
11997c76 10514
8a2cbd72
EZ
105152011-04-10 Eli Zaretskii <eliz@gnu.org>
10516
10517 Fix write-region and its subroutines for buffers > 2GB.
10518 * fileio.c (a_write, e_write): Modify declaration of arguments and
10519 local variables to support buffers larger than 2GB.
10520 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10521
10522 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10523 argument, local variables, and return value.
10524
10525 * lisp.h: Update prototypes of emacs_write and emacs_read.
10526
10527 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10528
4073e537 105292011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10530
1ebfdcb6
PE
10531 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10532
b2ded58d
PE
10533 Fix more problems found by GCC 4.6.0's static checks.
10534
7d66342c
PE
10535 * xdisp.c (vmessage): Use a better test for character truncation.
10536
bbf47d44
PE
10537 * charset.c (load_charset_map): <, not <=, for optimization,
10538 and to avoid potential problems with integer overflow.
9248994d 10539 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10540 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10541 * editfns.c (Fformat): Likewise.
1e69125e 10542 * syntax.c (skip_chars): Likewise.
3befa583 10543
e3019616
PE
10544 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10545 This also lets GCC 4.6.0 generate slightly better loop code.
10546
becfa255
PE
10547 * callint.c (Fcall_interactively): <, not <=, for optimization.
10548 (Fcall_interactively): Count the number of arguments produced,
10549 not the number of arguments given. This is simpler and lets GCC
10550 4.6.0 generate slightly better code.
10551
dae0cd48
PE
10552 * ftfont.c: Distingish more carefully between FcChar8 and char.
10553 The previous code passed unsigned char * to a functions like
10554 strlen and xstrcasecmp that expect char *, which does not
10555 conform to the C standard.
10556 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10557 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10558 char * when the C standard requires it.
10559
76032d70
PE
10560 * keyboard.c (read_char): Remove unused var.
10561
eb3f1cc8
PE
10562 * eval.c: Port to Windows vsnprintf (Bug#8435).
10563 Include <limits.h>.
10564 (SIZE_MAX): Define if the headers do not.
10565 (verror): Do not give up if vsnprintf returns a negative count.
10566 Instead, grow the buffer. This ports to Windows vsnprintf, which
10567 does not conform to C99. Problem reported by Eli Zaretskii.
10568 Also, simplify the allocation scheme, by avoiding the need for
10569 calling realloc, and removing the ALLOCATED variable.
10570
70476b54
PE
10571 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10572
12020a9e
PE
10573 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10574 But keep the doprint source code for now, as we might revamp it
10575 and use it again (Bug#8435).
ea6c7ae6
PE
10576 * lisp.h (doprnt): Remove.
10577 * Makefile.in (base_obj): Remove doprnt.o.
10578 * deps.mk (doprnt.o): Remove.
10579
5fdb398c
PE
10580 error: Print 32- and 64-bit integers portably (Bug#8435).
10581 Without this change, on typical 64-bit hosts error ("...%d...", N)
10582 was used to print both 32- and 64-bit integers N, which relied on
10583 undefined behavior.
61bdb816 10584 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10585 * lisp.h (error, verror): Mark as printf-like functions.
10586 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10587 Report overflow in size calculations when allocating printf buffer.
10588 Do not truncate output string at its first null byte.
10589 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10590 Truncate the output at a character boundary, since vsnprintf does not
10591 do that.
10592 * charset.c (check_iso_charset_parameter): Convert internal
10593 character to string before calling 'error', since %c now has the
10594 printf meaning.
10595 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10596 overflow when computing char to be passed to 'error'. Do not
10597 pass Lisp_Object to 'error'; pass the integer instead.
10598 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10599 formatted with plain %d.
10600
b189fa66
PE
10601 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10602
bff87ef0
PE
10603 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10604
7e2cac20
PE
10605 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10606
ce4d90b5
PE
10607 * xterm.c (x_catch_errors): Remove duplicate declaration.
10608
266c9547
PE
10609 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10610
79c49ad2
PE
10611 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10612
368f4090
JM
106132011-04-10 Jim Meyering <meyering@redhat.com>
10614
10615 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10616 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10617 return ssize_t not "int", and use size_t as the buffer length.
10618 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10619 * gnutls.h: Update declarations.
10620 * process.c (read_process_output): Use ssize_t, to match.
10621 (send_process): Likewise.
10622
a32d4040
CY
106232011-04-09 Chong Yidong <cyd@stupidchicken.com>
10624
10625 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10626
8546720e 106272011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10628
04f2d78b
CB
10629 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10630 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10631
8546720e
GM
10632 * xterm.c (handle_one_xevent):
10633 * xmenu.c (create_and_show_popup_menu):
10634 * xselect.c (x_decline_selection_request)
10635 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10636
0a2f5c1a 106372011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10638
10639 Fix some uses of `int' instead of EMACS_INT.
10640 * search.c (string_match_1, fast_string_match)
10641 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10642 (scan_buffer, find_next_newline_no_quit)
10643 (find_before_next_newline, search_command, Freplace_match)
10644 (Fmatch_data): Make some `int' variables be EMACS_INT.
10645
10646 * xdisp.c (display_count_lines): 3rd argument and return value now
10647 EMACS_INT. All callers changed.
10648 (pint2hrstr): Last argument is now EMACS_INT.
10649
10650 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10651 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10652 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10653 (decode_coding_utf_16, decode_coding_emacs_mule)
10654 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10655 (decode_coding_ccl, decode_coding_charset)
10656 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10657 (decode_coding_iso_2022, decode_coding_emacs_mule)
10658 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10659 <char_offset, last_offset>: Declare EMACS_INT.
10660 (encode_coding_utf_8, encode_coding_utf_16)
10661 (encode_coding_emacs_mule, encode_invocation_designation)
10662 (encode_designation_at_bol, encode_coding_iso_2022)
10663 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10664 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10665 Declare EMACS_INT.
10666 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10667 (encode_invocation_designation): Last argument P_NCHARS is now
10668 EMACS_INT.
10669 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10670 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10671
10672 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10673 All users changed.
10674
10675 * ccl.c (Fccl_execute_on_string): Declare some variables
10676 EMACS_INT.
10677
8546720e 106782011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10679
10680 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10681
4e19a977
CS
106822011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10683
10684 * process.c (Fformat_network_address): Doc fix.
10685
87302331
R
106862011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10687
ee7683eb 10688 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10689
cbb59342
CY
106902011-04-08 Chong Yidong <cyd@stupidchicken.com>
10691
10692 * keyboard.c (read_char): Call Lisp function help-form-show,
10693 instead of using internal_with_output_to_temp_buffer.
10694 (Qhelp_form_show): New var.
e0d38eeb 10695 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10696
10697 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10698
10699 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10700
e67a13ab
CY
107012011-04-06 Chong Yidong <cyd@stupidchicken.com>
10702
04f2d78b
CB
10703 * process.c (Flist_processes): Remove to Lisp.
10704 (list_processes_1): Delete.
e67a13ab 10705
973f782d
EZ
107062011-04-06 Eli Zaretskii <eliz@gnu.org>
10707
7c106b1e
EZ
10708 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10709
973f782d
EZ
10710 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10711
41cf7d1a 107122011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10713
ca23cc88
PE
10714 Fix more problems found by GCC 4.6.0's static checks.
10715
f390e2d5
PE
10716 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10717
42eea0d0
PE
10718 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10719
b69769da 10720 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10721
f9541e84
PE
10722 * xdisp.c (vmessage): Mark as a printf-like function.
10723
13841b55
PE
10724 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10725
c136c10f
PE
10726 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10727
5e2d4a30
PE
10728 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10729 printf-like functions.
10730 (tiff_load): Add casts to remove these marks before passing them
10731 to system-supplied API.
10732
583f48b9
PE
10733 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10734
b25d760e
PE
10735 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10736 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10737 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10738 directly, rather than having caller test rule sign. This avoids
10739 some unnecessary tests.
10740 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10741 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10742 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10743
bc7b6697 10744 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10745 (xfont_open): Avoid unnecessary tests.
bc7b6697 10746
27ccc379
PE
10747 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10748
dcd5c89a
PE
10749 * composite.h, composite.c (composition_gstring_put_cache):
10750 Use EMACS_INT, not int, for length.
10751
b13a45c6
PE
10752 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10753 breaking out part of COMPOSITION_DECODE_RULE.
10754 (COMPOSITION_DECODE_RULE): Use it.
10755 * composite.c (get_composition_id): Remove unused local vars,
10756 by using the new macro.
10757
1e792e4d
PE
10758 * textprop.c (set_text_properties_1): Change while to do-while,
10759 since the condition is always true at first.
10760
dc6c6455 10761 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10762 (interval_deletion_adjustment): Return unsigned value.
10763 All uses changed.
dc6c6455 10764
aba7731a
PE
10765 * process.c (list_processes_1, create_pty, read_process_output):
10766 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10767 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10768 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10769 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10770 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10771
fdfc4bf3
PE
10772 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10773
fca8fe46 10774 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10775 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10776
06a0259a 10777 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10778 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10779 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10780
e7b9e80f
PE
10781 * print.c (print_error_message): Avoid int overflow.
10782
56201685
PE
10783 * font.c (font_list_entities): Redo for clarity,
10784 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10785
78834453 10786 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10787 (font_score): Avoid potential overflow in diff calculation.
78834453 10788
0bc0b309 10789 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10790 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10791
e610eaca
PE
10792 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10793
b895abce
PE
10794 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10795 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10796 can always succeed if overflow has undefined behavior.
10797
1f1d9321 10798 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10799 (wordify): Omit three unnecessary tests.
1f1d9321 10800
c59478bc
PE
10801 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10802 All callers changed. This avoids the need for an unused var.
10803
79b73827
PE
10804 * casefiddle.c (casify_region): Remove var that is set but not used.
10805
a4db5dfe
PE
10806 * dired.c (file_name_completion): Remove var that is set but not used.
10807
43aae36e
PE
10808 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10809
2a47c44d 10810 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10811 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10812
a37c69bf
PE
10813 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10814 Check for integer overflow on size calculations.
10815
328ab8e7
PE
10816 * buffer.c (Fprevious_overlay_change): Remove var that is set
10817 but not used.
10818
e5a2a5cb
PE
10819 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10820 Remove vars that are set but not used.
8d84a6eb 10821 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10822 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10823
a60e5f68
PE
10824 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10825
f661cb61 10826 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10827 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10828
f0397f5a
PE
10829 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10830 that are set but not used.
10831
8664db06 10832 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10833 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10834
6abdaa4a
PE
10835 * xselect.c (x_get_local_selection, x_handle_property_notify):
10836 Remove vars that are set but not used.
10837
0ce7538d 10838 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10839 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10840
9ae848fc
PE
10841 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10842 Remove var that is set but not used.
0b918413
PE
10843 (scroll_bar_windows_size): Now size_t, not int.
10844 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10845 Check for overflow.
9ae848fc 10846
a5a62657
PE
10847 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10848 (map_tty_color) [!defined MSDOS]: Likewise.
10849
5c5cdd39
PE
10850 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10851
66ebf983
PE
10852 * coding.c: Remove vars that are set but not used.
10853 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10854 All callers changed.
10855 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10856 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10857 (decode_coding_charset): Remove vars that are set but not used.
10858
1be4d761
PE
10859 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10860 that is set but not used.
10861
47553fa8
PE
10862 * print.c (print_object): Remove var that is set but not used.
10863
1f7196bf 10864 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10865 The gnulib version avoids calling malloc in the usual case,
10866 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10867 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10868 * filelock.c (current_lock_owner): Likewise.
10869 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10870 * sysdep.c: Include allocator.h, careadlinkat.h.
10871 (emacs_no_realloc_allocator): New static constant.
10872 (emacs_readlink): New function.
fdb61804
PE
10873 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10874 ../lib/careadlinkat.h.
d1fdcab7 10875
f84c17c7
SM
108762011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10877
10878 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10879 first non-nil return value).
10880
ef3862ad
JD
108812011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10882
10883 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10884 if not defined (Bug#8403).
10885
376a7006
JB
108862011-04-02 Juanma Barranquero <lekktu@gmail.com>
10887
10888 * xdisp.c (display_count_lines): Remove parameter `start',
10889 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10890 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10891 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10892 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10893 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10894 and thereabouts. All callers changed.
10895 (get_per_char_metric): Remove parameter `f', unused since
10896 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10897
6ca3801d
JM
108982011-04-02 Jim Meyering <meyering@redhat.com>
10899
10900 do not dereference NULL upon failed strdup
10901 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10902 (ns_get_family): Likewise.
10903
d8e2b5ba
JB
109042011-04-02 Juanma Barranquero <lekktu@gmail.com>
10905
10906 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10907
8c74fcbd
JD
109082011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10909
10910 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10911 later (Bug#8403).
10912
7200d79c
SM
109132011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10914
03408648 10915 Add lexical binding.
7200d79c 10916
03408648
SM
10917 * window.c (Ftemp_output_buffer_show): New fun.
10918 (Fsave_window_excursion):
10919 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10920
10921 * lread.c (lisp_file_lexically_bound_p): New function.
10922 (Fload): Bind Qlexical_binding.
10923 (readevalloop): Remove `evalfun' arg.
10924 Bind Qinternal_interpreter_environment.
10925 (Feval_buffer): Bind Qlexical_binding.
10926 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10927 Mark as dynamic.
10928 (syms_of_lread): Declare `lexical-binding'.
10929
10930 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10931
10932 * keyboard.c (eval_dyn): New fun.
10933 (menu_item_eval_property): Use it.
ca105506
SM
10934
10935 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10936
03408648
SM
10937 * fns.c (concat, mapcar1): Accept byte-code-functions.
10938
10939 * eval.c (Fsetq): Handle lexical vars.
10940 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10941 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10942 (FletX, Flet): Obey lexical binding.
10943 (Fcommandp): Handle closures.
10944 (Feval): New `lexical' arg.
10945 (eval_sub): New function extracted from Feval. Use it almost
10946 everywhere where Feval was used. Look up vars in lexical env.
10947 Handle closures.
10948 (Ffunctionp): Move from subr.el.
10949 (Ffuncall): Handle closures.
10950 (apply_lambda): Remove `eval_flags'.
10951 (funcall_lambda): Handle closures and new byte-code-functions.
10952 (Fspecial_variable_p): New function.
10953 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10954 but without exporting it to Lisp.
23aba0ea 10955
23aba0ea 10956 * doc.c (Fdocumentation, store_function_docstring):
03408648 10957 * data.c (Finteractive_form): Handle closures.
23aba0ea 10958
03408648
SM
10959 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10960 interactive spec.
ba83908c 10961
04f2d78b
CB
10962 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10963 New byte-codes.
03408648
SM
10964 (exec_byte_code): New function extracted from Fbyte_code to handle new
10965 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10966
03408648 10967 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10968
03408648 10969 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10970
e2abce01
JB
109712011-03-31 Juanma Barranquero <lekktu@gmail.com>
10972
10973 * xdisp.c (redisplay_internal): Fix prototype.
10974
63696a73 109752011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10976
63696a73 10977 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10978 (try_scrolling): Use it when setting scroll_limit.
10979 Limit scrolling to 100 screen lines.
63696a73
EZ
10980 (redisplay_window): Even when falling back on "recentering",
10981 position point in the window according to scroll-conservatively,
10982 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10983
10984 (try_scrolling): When point is above the window, allow searching
10985 as far as scroll_max, or one screenful, to compute vertical
10986 distance from PT to the scroll margin position. This prevents
10987 try_scrolling from unnecessarily failing when
10988 scroll-conservatively is set to a value slightly larger than the
10989 window height. Clean up the case of PT below the margin at bottom
10990 of window: scroll_max can no longer be INT_MAX. When aggressive
10991 scrolling is in use, don't let point enter the opposite scroll
10992 margin as result of the scroll.
10993 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10994 threshold of 100 lines for never-recentering scrolling.
10995
e4cc2dfc
JB
109962011-03-31 Juanma Barranquero <lekktu@gmail.com>
10997
10998 * dispextern.h (move_it_by_lines):
10999 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11000 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11001 (message_log_check_duplicate): Remove parameters `prev_bol' and
11002 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11003 (redisplay_internal): Remove parameter `preserve_echo_area',
11004 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11005
11006 * indent.c (Fvertical_motion):
11007 * window.c (window_scroll_pixel_based, Frecenter):
11008 Don't pass `need_y_p' to `move_it_by_lines'.
11009
1c470562
SM
110102011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11011
44f230aa
SM
11012 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11013 steal a few bits to be more compact.
11014 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11015 Remove unneeded casts.
11016
1c470562
SM
11017 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11018
888adce9
ZK
110192011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11020
11021 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11022 binding" message (bug#7967).
11023
f838ed7b
PE
110242011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11025
77861b95
PE
11026 Fix more problems found by GCC 4.6.0's static checks.
11027
de6dbc14
PE
11028 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11029 Remove unused local var.
11030
f838ed7b
PE
11031 * editfns.c (Fmessage_box): Remove unused local var.
11032
792c7b2b
PE
11033 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11034 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11035 Omit unused local vars.
c499e557 11036 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11037 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11038 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11039 Omit unused local var.
11040
ba0165e1
PE
11041 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11042 Don't assume string length fits in int.
32ad8845 11043 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11044 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11045
3c59b4c9
PE
11046 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11047 instead of alloca (Bug#8344).
11048
a3eed478 11049 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11050 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11051
eb4d412d
PE
11052 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11053
1658b401
PE
11054 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11055 concerns.
11056
11057 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11058
11059 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11060
9a2c6e05
PE
11061 * keyboard.c (syms_of_keyboard): Use the same style as later
11062 in this function when indexing through an array. This also
11063 works around GCC bug 48267.
11064
03d0a109
PE
11065 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11066
44f730c8
PE
11067 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11068
fe75f926
PE
11069 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11070 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11071
ffa8c828
PE
11072 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11073 This avoids undefined behavior on integer overflow, and is a bit
11074 more convenient anyway since it is compared to a size_t variable.
11075
c5101a77
PE
11076 Variadic C functions now count arguments with size_t, not int.
11077 This avoids an unnecessary limitation on 64-bit machines, which
11078 caused (substring ...) to crash on large vectors (Bug#8344).
11079 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11080 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11081 All variadic functions and their callers changed accordingly.
c5101a77
PE
11082 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11083 * data.c (arith_driver, float_arith_driver): Likewise.
11084 * editfns.c (general_insert_function): Likewise.
11085 * eval.c (struct backtrace.nargs, interactive_p)
11086 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11087 (funcall_lambda, mark_backtrace): Likewise.
11088 * fns.c (concat): Likewise.
11089 * frame.c (x_set_frame_parameters): Likewise.
11090 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11091 0 if not found, not -1. All callers changed.
11092
dd3f25f7
PE
11093 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11094 (stack_copy_size): Now size_t, not int.
11095 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11096
461c2ab9
JB
110972011-03-28 Juanma Barranquero <lekktu@gmail.com>
11098
11099 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11100 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11101 All callers changed.
11102
11103 * lisp.h (multibyte_char_to_unibyte):
11104 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11105 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11106 * character.h (CHAR_TO_BYTE8):
11107 * cmds.c (internal_self_insert):
11108 * editfns.c (general_insert_function):
11109 * keymap.c (push_key_description):
11110 * search.c (Freplace_match):
11111 * xdisp.c (message_dolog, set_message_1): All callers changed.
11112
f6d62986
SM
111132011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11114
11115 * keyboard.c (safe_run_hook_funcall): New function.
11116 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11117 don't set the hook to nil, but remove the offending function instead.
11118 (Qcommand_hook_internal): Remove, unused.
11119 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11120 Vcommand_hook_internal.
11121
11122 * eval.c (enum run_hooks_condition): Remove.
11123 (funcall_nil, funcall_not): New functions.
11124 (run_hook_with_args): Call each function through a `funcall' argument.
11125 Remove `cond' argument, now redundant.
11126 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11127 (Frun_hook_with_args_until_failure): Adjust accordingly.
11128 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11129
1db5b1ad
JB
111302011-03-28 Juanma Barranquero <lekktu@gmail.com>
11131
11132 * dispextern.h (string_buffer_position): Remove declaration.
11133
11134 * print.c (strout): Remove parameter `multibyte', unused since
11135 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11136
11137 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11138 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11139 All callers changed.
11140
11141 * w32.c (_wsa_errlist): Use braces for struct initializers.
11142
11143 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11144 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11145 All callers changed.
11146 (string_buffer_position): Likewise. Also, make static (it's never
11147 used outside xdisp.c).
11148 (cursor_row_p): Remove parameter `w', unused since
11149 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11150 (decode_mode_spec): Remove parameter `precision', introduced during
11151 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11152 All callers changed.
11153
5ffb62aa
JD
111542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11155
11156 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11157
461c2ab9 111582011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11159
11160 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11161 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11162 (ns_update_auto_hide_menu_bar): New functions.
11163 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11164 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11165 ns_constrain_all_frames.
11166 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11167 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11168
5c380ffb
JD
111692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11170
11171 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11172
9af30bdf
GM
111732011-03-27 Glenn Morris <rgm@gnu.org>
11174
11175 * syssignal.h: Replace RETSIGTYPE with void.
11176 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11177 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11178 Replace SIGTYPE with void everywhere.
11179 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11180 * s/template.h (SIGTYPE): Remove commented out definition.
11181
e2abce01
JB
111822011-03-26 Eli Zaretskii <eliz@gnu.org>
11183
11184 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11185 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11186
f868cd8a
JB
111872011-03-26 Juanma Barranquero <lekktu@gmail.com>
11188
59eb0929
JB
11189 * w32.c (read_unc_volume): Use parameter `henum', instead of
11190 global variable `wget_enum_handle'.
11191
11192 * keymap.c (describe_vector): Remove parameters `indices' and
11193 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11194 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11195
f868cd8a
JB
11196 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11197
11198 * keyboard.c (timer_check): Remove parameter `do_it_now',
11199 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11200 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11201 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11202
11203 * keyboard.c (read_char):
11204 * w32menu.c (w32_menu_display_help):
11205 * xmenu.c (show_help_event, menu_help_callback):
11206 Adjust calls to `show_help_echo'.
11207
11208 * gtkutil.c (xg_maybe_add_timer):
11209 * keyboard.c (readable_events):
11210 * process.c (wait_reading_process_output):
11211 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11212
11213 * insdel.c (adjust_markers_gap_motion):
11214 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11215 (gap_left, gap_right): Don't call it.
11216
2ecf6fdb
CY
112172011-03-25 Chong Yidong <cyd@stupidchicken.com>
11218
11219 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11220 incurred during fontification.
11221
6b1f9ba4
JB
112222011-03-25 Juanma Barranquero <lekktu@gmail.com>
11223
11224 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11225 (DEFVAR_PER_BUFFER): Don't pass it.
11226
11227 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11228 (scrolling_window): Don't pass it.
11229
0f4a96b5
JB
112302011-03-25 Juanma Barranquero <lekktu@gmail.com>
11231
11232 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11233
11234 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11235 and `suffix'.
11236 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11237 of variables specific to SELinux and computation of `encoded_absname'.
11238
11239 * image.c (XPutPixel): Remove unused variable `height'.
11240
11241 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11242
11243 * unexw32.c (get_section_info): Remove unused variable `section'.
11244
11245 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11246 (system_process_attributes): Remove unused variable `sess'.
11247 (sys_read): Remove unused variable `err'.
11248
11249 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11250 (w32_wnd_proc): Remove unused variable `isdead'.
11251 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11252 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11253 (x_create_tip_frame): Remove unused variable `tem'.
11254
11255 * w32inevt.c (w32_console_read_socket):
11256 Remove unused variable `no_events'.
11257
11258 * w32term.c (x_draw_composite_glyph_string_foreground):
11259 Remove unused variable `width'.
11260
1149507c
JB
112612011-03-24 Juanma Barranquero <lekktu@gmail.com>
11262
11263 * w32term.c (x_set_glyph_string_clipping):
11264 Don't pass uninitialized region to CombineRgn.
11265
9c88f339
JB
112662011-03-23 Juanma Barranquero <lekktu@gmail.com>
11267
11268 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11269 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11270 (Fx_close_connection): Remove unused variable `i'.
11271
11272 * w32font.c (w32font_draw): Return number of glyphs.
11273 (w32font_open_internal): Remove unused variable `i'.
11274 (w32font_driver): Add missing initializer.
11275
11276 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11277 (fill_in_menu): Remove unused variable `items_added'.
11278
11279 * w32term.c (last_mouse_press_frame): Remove static global variable.
11280 (w32_clip_to_row): Remove unused variable `f'.
11281 (x_delete_terminal): Remove unused variable `i'.
11282
11283 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11284 (NOTHING): Remove unused static global variable.
11285 (uniscribe_check_otf): Remove unused variable `table'.
11286 (uniscribe_font_driver): Add missing initializers.
11287
dee091a3
JD
112882011-03-23 Julien Danjou <julien@danjou.info>
11289
11290 * term.c (Fsuspend_tty, Fresume_tty):
11291 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11292 * window.c (temp_output_buffer_show):
11293 * insdel.c (signal_before_change):
11294 * frame.c (Fhandle_switch_frame):
11295 * fileio.c (Fdo_auto_save):
11296 * emacs.c (Fkill_emacs):
11297 * editfns.c (save_excursion_restore):
11298 * cmds.c (internal_self_insert):
11299 * callint.c (Fcall_interactively):
11300 * buffer.c (Fkill_all_local_variables):
11301 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11302 Use Frun_hooks.
0f4a96b5 11303 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11304 unconditionally since it does the check itself.
dee091a3 11305
2c520ab5 113062011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11307
c9c49752
PE
11308 Fix more problems found by GCC 4.5.2's static checks.
11309
8abc3f12
PE
11310 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11311 the first time through the loop, since we know p0 < p1 then.
11312 This also avoids a gcc -Wstrict-overflow warning.
11313
a2d26660
PE
11314 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11315 leading to a memory leak, possible in functions like
11316 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11317 of objects (Bug#8318).
a2d26660 11318
916c72e9
PE
11319 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11320 that could (at least in theory) be that large.
11321
19ab8a18
PE
11322 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11323 This is less likely to overflow, and avoids undefined behavior if
11324 overflow does occur. All callers changed. Use strtoul to scan
11325 for the unsigned long integer.
b7cbbd6f
PE
11326 (pint2hrstr): Simplify and tune code slightly.
11327 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11328
f0641eff
PE
11329 * scroll.c (do_scrolling): Work around GCC bug 48228.
11330 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11331
7f650bb9
PE
11332 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11333 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11334 (validate_x_resource_name): Simplify count usage.
11335 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11336
37dd57d1
PE
11337 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11338 fail (Bug#8306).
81e56e61 11339
699979fc 11340 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11341
401bf9b4
PE
11342 * process.c (Fmake_network_process): Use socklen_t, not int,
11343 where POSIX says socklen_t is required in portable programs.
11344 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11345 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11346 (Fmake_network_process, server_accept_connection):
11347 (wait_reading_process_output, read_process_output):
11348 Likewise.
11349
b93aacde
PE
11350 * process.c: Rename or move locals to avoid shadowing.
11351 (list_processes_1, Fmake_network_process):
11352 (read_process_output_error_handler, exec_sentinel_error_handler):
11353 Rename or move locals.
4dc343ee 11354 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11355 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11356 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11357 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11358 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11359
af8a867c 11360 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11361 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11362 Include tparam.h instead, since it declares them.
af8a867c
PE
11363 * cm.h (PC): Remove extern decl; tparam.h now does this.
11364 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11365 * terminfo.c: Include tparam.h, to check interfaces.
11366 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11367 (tparam): Adjust signature to match interface in tparam.h;
11368 this removes some undefined behavior. Check that outstring and len
11369 are zero, which they always are with Emacs.
11370 * tparam.h (PC, BC, UP): New extern decls.
11371
0248044d 11372 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11373 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11374
8ff096c1 11375 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11376 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11377 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11378 (ftfont_list): Remove unused local.
49eaafba
PE
11379 (get_adstyle_property, ftfont_pattern_entity):
11380 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11381 Rename locals to avoid shadowing.
8ff096c1 11382
e2be39f6
PE
11383 * xfont.c (xfont_list_family): Mark var as initialized.
11384
c9735e30
PE
11385 * xml.c (make_dom): Now static.
11386
8f5201ae
PE
11387 * composite.c (composition_compute_stop_pos): Rename local to
11388 avoid shadowing.
b246f932
PE
11389 (composition_reseat_it): Remove unused locals.
11390 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11391 (composition_update_it): Mark var as initialized.
11b61122
PE
11392 (find_automatic_composition): Mark vars as initialized,
11393 with a FIXME (Bug#8290).
8f5201ae 11394
760fbc2c
PE
11395 character.h: Rename locals to avoid shadowing.
11396 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11397 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11398 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11399 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11400 to avoid shadowing.
11401
ff08eb85
PE
11402 * textprop.c (property_change_between_p): Remove; unused.
11403
fc7bf025
PE
11404 * intervals.c (interval_start_pos): Now static.
11405
235d7abc
PE
11406 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11407
44f230aa
SM
11408 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11409 Rename locals to avoid shadowing.
3e7d6594 11410
50060332
PE
11411 * sound.c (wav_play, au_play, Fplay_sound_internal):
11412 Fix pointer signedness.
d01f234b 11413 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11414 (wav_play): Initialize a variable to 0, to prevent undefined
11415 behavior (Bug#8278).
50060332 11416
c4fc4e30
PE
11417 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11418
918436ed
PE
11419 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11420
c939f91b
PE
11421 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11422 clobbering (Bug#8298).
b9c7f648
PE
11423 * sysdep.c (sys_subshell): Likewise.
11424 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11425
6bd8c144
PE
11426 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11427 This should get cleaned up, so that child_setup has the
11428 same signature on all platforms.
11429
7710357c 11430 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11431 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11432
c59da222
CY
114332011-03-22 Chong Yidong <cyd@stupidchicken.com>
11434
11435 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11436 not to be necessary, and produces flickering.
11437
66b87493
GM
114382011-03-20 Glenn Morris <rgm@gnu.org>
11439
11440 * config.in: Remove file.
11441
45b6f6d5
JB
114422011-03-20 Juanma Barranquero <lekktu@gmail.com>
11443
11444 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11445 are now in src/globals.h.
11446 (syms_of_minibuf): Remove spurious & from previous change.
11447
cd394be1 114482011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11449
11450 * minibuf.c (completing-read-function): New variable.
11451 (completing-read-default): Rename from completing-read.
11452 (completing-read): Call completing-read-function.
11453
b14e3e21
CY
114542011-03-19 Juanma Barranquero <lekktu@gmail.com>
11455
11456 * xfaces.c (Fx_load_color_file):
11457 Read color file from absolute filename (bug#8250).
11458
f2b726e6
JB
114592011-03-19 Juanma Barranquero <lekktu@gmail.com>
11460
11461 * makefile.w32-in: Update dependencies.
11462
09f6ff02
EZ
114632011-03-17 Eli Zaretskii <eliz@gnu.org>
11464
11465 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11466
29a6015a
PE
114672011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11468
a3a6c54e
PE
11469 Fix more problems found by GCC 4.5.2's static checks.
11470
b766f867
PE
11471 * process.c (make_serial_process_unwind, send_process_trap):
11472 (sigchld_handler): Now static.
11473
be02381c
PE
11474 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11475 That way, the code declares only the vars that it needs.
11476 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11477 * s/cygwin.h (PTY_ITERATION): Likewise.
11478 * s/darwin.h (PTY_ITERATION): Likewise.
11479 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11480
57048744
PE
11481 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11482 * process.c (allocate_pty): Don't declare stb unless it's needed.
11483
7914961c 11484 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11485 (CONSTANTLIM): Remove; unused.
11486 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11487 Define only if needed.
7914961c 11488
b3967b18
PE
11489 * unexelf.c (unexec): Name an expression,
11490 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11491 Use a different way to cause a compilation error if anyone uses
11492 n rather than nn, a way that does not involve shadowing.
73366a00 11493 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11494
29a6015a
PE
11495 * deps.mk (unexalpha.o): Remove; unused.
11496
43cfc33e 11497 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11498 * unexec.h: New file.
ce701a33
PE
11499 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11500 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11501 Depend on unexec.h.
11502 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11503 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11504 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11505 Change as necessary to match prototype in unexec.h.
ce701a33 11506
01f44d5a
PE
11507 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11508 shadowing.
4f63c6bb 11509 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11510
a6670b0b
PE
11511 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11512 Rename locals to avoid shadowing.
11513
cef2010d 11514 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11515 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11516
d4d7173a
PE
11517 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11518
f08b802a
PE
11519 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11520 warning when compiling print.c.
11521
3ddb0639
PE
11522 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11523 instead of using an uninitialized var.
5ad03b97 11524 (font_sort_entities): Mark var as initialized.
3ddb0639 11525
170a2692
PE
11526 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11527
e663c700
PE
11528 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11529 pointers to constants.
89bc529a 11530 (font_parse_fcname): Remove unused vars.
7b81e2d0 11531 (font_delete_unmatched): Now static.
ea838e10 11532 (font_get_spec): Remove; unused.
13a547c6
PE
11533 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11534 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11535 Rename or move locals to avoid shadowing.
e663c700 11536
2a80c887 11537 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11538 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11539
1384fa33 11540 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11541 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11542
8b2c52e9
PE
11543 * alloc.c (mark_backtrace): Move decl from here ...
11544 * lisp.h: ... to here, so that it can be checked.
11545
475545b5 11546 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11547 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11548 (lisp_indirect_variable): Name an expression,
11549 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11550 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11551
b1349114 11552 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11553 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11554 Use const pointer when appropriate.
b1349114 11555
a2928364
PE
11556 * lisp.h (get_system_name, get_operating_system_release):
11557 Move decls here, to check interfaces.
11558 * process.c (get_operating_system_release): Move decl to lisp.h.
11559 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11560 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11561 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11562 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11563 (Fformat_time_string, Fencode_time, Finsert_char):
11564 (Ftranslate_region_internal, Fformat):
11565 Rename or remove local vars to avoid shadowing.
9710023e 11566 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11567
a415e694
PE
11568 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11569 avoid shadowing.
11570
8ef4622d
PE
11571 * lisp.h (eassert): Check that the argument compiles, even if
11572 ENABLE_CHECKING is not defined.
11573
946f9a5b
PE
11574 * data.c (Findirect_variable): Name an expression, to avoid
11575 gcc -Wbad-function-cast warning.
112396d6 11576 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11577 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11578 (Fmake_variable_buffer_local, Fmake_local_variable):
11579 Mark variables as initialized.
52746918 11580 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11581
e5aab7e7 11582 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11583 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11584 Rename locals to avoid shadowing.
dff45157
PE
11585 (mark_stack): Move local variables into the #ifdef region where
11586 they're used.
7bc26fdb
PE
11587 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11588 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11589 needed otherwise.
11590 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11591 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11592 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11593
e5aab7e7
PE
11594 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11595 avoids undefined behavior in theory.
11596
4da60324
PE
11597 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11598
88043301
PE
11599 Use functions, not macros, for up- and down-casing (Bug#8254).
11600 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11601 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11602 to use the following functions instead of these macros.
11603 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11604 EMACS_INT, since callers assume the returned value fits in int.
11605 (upcase1): Likewise, for UPCASE_TABLE.
11606 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11607 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11608 the race-condition problem in the old DOWNCASE.
88043301 11609
19ed5445
PE
11610 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11611 Rename locals to avoid shadowing.
11612 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11613 (regex_compile, re_search_2, re_match_2_internal):
11614 Remove unused local vars.
952db0d7
PE
11615 (FREE_VAR): Rewrite so as not to use empty "else",
11616 which gcc can warn about.
da053e48 11617 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11618 (RETALLOC_IF): Define only if needed.
11619 (WORDCHAR_P): Likewise. This one is never needed, but is used
11620 only in a comment talking about a compiler bug, so put inside
11621 the #if 0 of that comment.
11622 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11623 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11624 Remove; unused.
19ed5445 11625
1f3561e4 11626 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11627 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11628 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11629
ded6f8f7
PE
11630 * search.c (simple_search): Remove unused var.
11631
dbd37a95
PE
11632 * dired.c (compile_pattern): Move decl from here ...
11633 * lisp.h: ... to here, so that it can be checked.
11634 (struct re_registers): New forward decl.
11635
7e47afad
PE
11636 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11637
85f24f61
PE
11638 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11639 All uses changed.
11640 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11641 Rename locals to avoid shadowing.
5671df8f 11642 (Fvertical_motion): Mark locals as initialized.
85f24f61 11643
181aa2be 11644 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11645 (casify_region): Mark local as initialized.
181aa2be 11646
930d429c
PE
11647 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11648
7082eac6
PE
11649 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11650 New macros, so that the caller can use some names other than
11651 gcpro1, gcpro2, etc.
11652 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11653 of the new macros.
11654 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11655 argument, for consistency with GCPRO2_VAR, etc: it is now the
11656 prefix of the variable, not the variable itself. All uses
11657 changed.
38b2c076
PE
11658 * dired.c (directory_files_internal, file_name_completion):
11659 Rename locals to avoid shadowing.
11660
15206ed9
PE
11661 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11662 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11663 dired.c's scmp function, had undefined behavior.
11664 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11665 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11666 * buffer.h: ... to here, because these macros use current_buffer,
11667 and the new implementation with inline functions needs to have
11668 current_buffer in scope now, rather than later when the macros
11669 are used.
11670 (downcase, upcase1): New static inline functions.
11671 (DOWNCASE, UPCASE1): Reimplement using these functions.
11672 This avoids undefined behavior in expressions like
11673 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11674 from race conditions in accessing the global variables
11675 case_temp1 and case_temp2.
11676 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11677 * lisp.h (case_temp1, case_temp2): Remove their decls.
11678 * character.h (ASCII_CHAR_P): Move from here ...
11679 * lisp.h: ... to here, so that the inline functions mentioned
11680 above can use them.
11681
4a6bea26
PE
11682 * dired.c (directory_files_internal_unwind): Now static.
11683
f14b7e14
PE
11684 * fileio.c (file_name_as_directory, directory_file_name):
11685 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11686 Now static.
2893f146
PE
11687 (file_name_as_directory): Use const pointers when appropriate.
11688 (Fexpand_file_name): Likewise. In particular, newdir might
11689 point at constant storage, so make it a const pointer.
fd4ead52 11690 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11691 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11692 signedness issues.
f839df0c
PE
11693 (Fset_file_times, Finsert_file_contents, auto_save_error):
11694 Rename locals to avoid shadowing.
f14b7e14 11695
5716756e 11696 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11697 (Ftry_completion, Fall_completions): Rename or remove locals
11698 to avoid shadowing.
5716756e 11699
b4c3046a
PE
11700 * marker.c (bytepos_to_charpos): Remove; unused.
11701
b45db522
PE
11702 * lisp.h (verify_bytepos, count_markers): New decls,
11703 so that gcc does not warn that these functions aren't declared.
11704
85876d07
PE
11705 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11706 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11707 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11708 (copy_text): Remove unused local var.
85876d07 11709
03d78a21 11710 * filelock.c (within_one_second): Now static.
b3dd38ab 11711 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11712
5df8f01b
PE
11713 * buffer.c (fix_overlays_before): Mark locals as initialized.
11714 (fix_start_end_in_overlays): Likewise. This function should be
11715 simplified by using pointers-to-pointers, but that's a different
11716 matter.
b1d876f1 11717 (switch_to_buffer_1): Now static.
8f54f30a
PE
11718 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11719 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11720
a70072c9 11721 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11722 Fix pointer signedness issue.
edced198
PE
11723 (sys_subshell): Mark local as volatile if checking for lint,
11724 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11725 (MAXPATHLEN): Define only if needed.
a70072c9 11726
a0977c44
PE
11727 * process.c (serial_open, serial_configure): Move decls from here ...
11728 * systty.h: ... to here, so that they can be checked.
11729
a884fdcc
PE
11730 * fns.c (get_random, seed_random): Move extern decls from here ...
11731 * lisp.h: ... to here, so that they can be checked.
11732
604efe86 11733 * sysdep.c (reset_io): Now static.
b8950c94 11734 (wait_for_termination_signal): Remove; unused.
604efe86 11735
38fc62d9
PE
11736 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11737 (copy_keymap_item, append_key, push_text_char_description):
11738 Now static.
1004a21a 11739 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11740 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11741 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11742 (describe_map_tree):
11743 Rename locals to avoid shadowing.
38fc62d9 11744
2f2650da
PE
11745 * keyboard.c: Declare functions static if they are not used elsewhere.
11746 (echo_char, echo_dash, cmd_error, top_level_2):
11747 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11748 (read_char, kbd_buffer_get_event, make_lispy_position):
11749 (make_lispy_event, make_lispy_movement, apply_modifiers):
11750 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11751 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11752 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11753 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11754 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11755
a053e86c 11756 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11757 (mark_kboards): Move decl here ...
11758 * alloc.c (mark_kboards): ... from here.
a053e86c 11759
4752793e
PE
11760 * lisp.h (force_auto_save_soon): New decl.
11761
74f10ca7 11762 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11763 (DEFINE_DUMMY_FUNCTION): New macro.
11764 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11765 Use it.
c03cd23f
PE
11766 (main): Add casts to avoid warnings
11767 if GCC considers string literals to be constants.
74f10ca7 11768
022e70d4
PE
11769 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11770
59d6fe83
PE
11771 * dbusbind.c: Pointer signedness fixes.
11772 (xd_signature, xd_append_arg, xd_initialize):
11773 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11774 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11775 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11776 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11777
78320123
PE
11778 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11779 if GCC considers string literals to be constants.
49cebcca 11780 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11781
35ac2a97
SM
117822011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11783
fb103ca9
SM
11784 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11785 (print_preprocess, print_object): New macro to fix last change.
11786
35ac2a97
SM
11787 * print.c (print_preprocess): Don't forget font objects.
11788
62973b41
JB
117892011-03-16 Juanma Barranquero <lekktu@gmail.com>
11790
11791 * emacs.c (USAGE3): Doc fixes.
11792
0e48bb22
AS
117932011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11794
11795 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11796 structure.
11797
7684e57b
JB
117982011-03-14 Juanma Barranquero <lekktu@gmail.com>
11799
11800 * lisp.h (VWindow_system, Qfile_name_history):
11801 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11802 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11803 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11804
11805 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11806 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11807
11808 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11809 * w32console.c (detect_input_pending, read_input_pending)
11810 (encode_terminal_code):
11811 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11812 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11813 (w32_system_caret_y, Qfile_name_history):
11814 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11815 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11816 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11817 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11818 * w32proc.c (Qlocal, report_file_error):
11819 * w32term.c (Vwindow_system, updating_frame):
11820 * w32uniscribe.c (initialized, uniscribe_font_driver):
11821 Remove unneeded extern declarations.
11822
2aa46d6c
CY
118232011-03-14 Chong Yidong <cyd@stupidchicken.com>
11824
c96bbc66 11825 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11826
cffc6f3b
CY
118272011-03-13 Chong Yidong <cyd@stupidchicken.com>
11828
11829 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11830 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11831 These macros can no longer be used for assignment.
11832
44f230aa
SM
11833 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11834 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11835 (record_buffer_markers, fetch_buffer_markers): New functions for
11836 recording and fetching special buffer markers.
11837 (set_buffer_internal_1, set_buffer_temp): Use them.
11838
11839 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11840
11841 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11842
11843 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11844 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11845
11846 * xdisp.c (hscroll_window_tree):
11847 (reconsider_clip_changes): Use PT instead of BUF_PT.
11848
d251f04b
EZ
118492011-03-13 Eli Zaretskii <eliz@gnu.org>
11850
11851 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11852 $(EMACS_ROOT)/lib/intprops.h.
11853
f0c77cd1
PE
118542011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11855
3eca4629
PE
11856 Fix more problems found by GCC 4.5.2's static checks.
11857
7c86ee98
PE
11858 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11859 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11860 (xg_free_frame_widgets): Make it clear that a local variable is
11861 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11862 (gdk_window_get_screen): Make it clear that this macro is needed
11863 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11864 (int_gtk_range_get_value): New function, which avoids a diagnostic
11865 from gcc -Wbad-function-cast.
11866 (xg_set_toolkit_scroll_bar_thumb): Use it.
11867 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11868 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11869 (get_utf8_string, xg_get_file_with_chooser):
11870 Rename locals to avoid shadowing.
11871 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11872
41729b81
PE
11873 * xgselect.c (xg_select): Remove unused var.
11874
f0c77cd1
PE
11875 * image.c (four_corners_best): Mark locals as initialized.
11876 (gif_load): Initialize transparent_p to zero (Bug#8238).
11877 Mark another local as initialized.
ec6cf4c6 11878 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11879
ce0ad53d 11880 * image.c (clear_image_cache): Now static.
d5d5a617 11881 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11882 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11883 (x_edge_detection): Remove unnecessary cast that
11884 gcc -Wbad-function-cast diagnoses.
2037898d 11885 (gif_load): Fix pointer signedness.
6ae141d6
PE
11886 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11887 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11888
33383987 118892011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11890
d32df629
PE
11891 Improve quality of tests for time stamp overflow.
11892 For example, without this patch (encode-time 0 0 0 1 1
11893 1152921504606846976) returns the obviously-bogus value (-948597
11894 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11895 reports time overflow. See
11896 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11897 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11898 * editfns.c: Include limits.h and intprops.h.
11899 (TIME_T_MIN, TIME_T_MAX): New macros.
11900 (time_overflow): Move earlier, to before first use.
11901 (hi_time, lo_time): New functions, for an accurate test for
11902 out-of-range times.
11903 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11904 (Fget_internal_run_time): Don't assume time_t fits in int.
11905 (make_time): Use list2 instead of Fcons twice.
11906 (Fdecode_time): More accurate test for out-of-range times.
11907 (check_tm_member): New function.
11908 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11909 (lisp_time_argument): Don't rely on undefined left-shift and
11910 right-shift behavior when checking for time stamp overflow.
8be6f318 11911
fe31d94c
PE
11912 * editfns.c (time_overflow): New function, refactoring common code.
11913 (Fformat_time_string, Fdecode_time, Fencode_time):
11914 (Fcurrent_time_string): Use it.
11915
8be6f318
PE
11916 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11917 * dired.c (make_time): Move to ...
11918 * editfns.c (make_time): ... here.
11919 * systime.h: Note the move.
11920
09d9db2c 119212011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11922
126bc0dc
YM
11923 * fringe.c (update_window_fringes): Remove unused variables.
11924
c47cbdfd
YM
11925 * unexmacosx.c (copy_data_segment): Also copy __got section.
11926 (Bug#8223)
11927
7ac80be9
EZ
119282011-03-12 Eli Zaretskii <eliz@gnu.org>
11929
c96bbc66 11930 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11931 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11932 Constify `char *' arguments and their references according to
11933 prototypes in tparam.h.
11934
ecb0f94d 11935 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11936
7ac80be9
EZ
11937 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11938 Adapt all references accordingly.
11939
11940 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11941
ef1fd07e
TT
119422011-03-11 Tom Tromey <tromey@redhat.com>
11943
11944 * buffer.c (syms_of_buffer): Remove obsolete comment.
11945
7ef4b50c
EZ
119462011-03-11 Eli Zaretskii <eliz@gnu.org>
11947
11948 * termhooks.h (encode_terminal_code): Declare prototype.
11949
11950 * msdos.c (encode_terminal_code): Don't declare prototype.
11951
11952 * term.c (encode_terminal_code): Now external again, used by
11953 w32console.c and msdos.c.
11954
44f230aa
SM
11955 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11956 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11957
4b1ec863 119582011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11959
1714f52b 11960 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11961
4b1ec863
PE
11962 * fringe.c (update_window_fringes): Mark locals as initialized
11963 (Bug#8227).
11964 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11965
524c7aa6
PE
11966 * alloc.c (mark_fringe_data): Move decl from here ...
11967 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11968 to check its interface.
11969 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11970
a5c0af81 11971 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11972 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11973 (fontset_font): Mark local as initialized.
a9a06e0b 11974 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11975
b4716021
PE
11976 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11977
811e9bac 11978 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11979 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11980 (x_own_selection, Fx_disown_selection_internal): Rename locals
11981 to avoid shadowing.
11982 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11983
7e3ab302
PE
11984 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11985 so that the caller can use some name other than gcpro1.
11986 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11987 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11988 (Fx_backspace_delete_keys_p):
11989 Use them to avoid shadowing, and rename vars to avoid shadowing.
11990 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11991 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11992 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11993 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11994 Remove unused locals.
7e3ab302
PE
11995 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11996 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11997 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11998 macros.
f78faa98 11999
e2b13473
PE
12000 * xterm.h (x_mouse_leave): New decl.
12001
77f23912
PE
12002 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12003 Remove unused functions.
cdf4ba58
PE
12004 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12005 (x_calc_absolute_position): Now static.
7411c686 12006 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12007 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12008 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12009 unless they are used.
38d0b34a
PE
12010 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12011 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12012 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12013 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12014 (x_error_catcher, x_connection_closed, x_error_handler):
12015 (x_error_quitter, xembed_send_message, x_iconify_frame):
12016 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12017 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12018 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12019
44f230aa
SM
12020 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12021 Rename or move locals to avoid shadowing.
6b463e58 12022 (tty_defined_color, merge_face_heights): Now static.
5967d051 12023 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12024 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12025 does not deduce is never used uninitialized.
73719eba
PE
12026 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12027 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12028
426994c3 12029 * terminal.c (store_terminal_param): Now static.
5489860b 12030
032f1620 12031 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12032 (set_frame_menubar): Remove unused local.
d4323972 12033 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12034 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12035 since they might point to immutable storage.
281585b0
PE
12036 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12037 since it's unused otherwise.
032f1620 12038
367c19e5 12039 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12040 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12041 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12042 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12043 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12044 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12045 does not deduce are never used uninitialized.
70739cbe 12046
07b48fa9
PE
12047 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12048
8868a238 12049 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12050 * window.c (window_loop, size_window):
12051 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12052
7e5cf297 12053 * window.c (display_buffer): Now static.
d6550a9f
PE
12054 (size_window): Mark variables that gcc -Wuninitialized
12055 does not deduce are never used uninitialized.
a586633d
PE
12056 * window.h (check_all_windows): New decl, to forestall
12057 gcc -Wmissing-prototypes diagnostic.
5b555da1 12058 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12059
f6095868
PE
12060 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12061 shadowing.
12062 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12063 Include <limits.h>.
12064 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12065 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12066 (load_charset_map): Mark variables that gcc -Wuninitialized
12067 does not deduce are never used uninitialized.
53df7c11 12068 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12069
f38b440c
PE
12070 * coding.c (coding_set_source, coding_set_destination):
12071 Use "else { /* comment */ }" rather than "else /* comment */;"
12072 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12073 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12074 a block, when the outer 'i' will do.
12075 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12076 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12077 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12078 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12079 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12080 Rename locals to avoid shadowing.
12081 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12082 * coding.c (emacs_mule_char, encode_invocation_designation):
12083 Now static, since they're not used elsewhere.
413bb2db 12084 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12085 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12086 (decode_coding_emacs_mule): Mark variables that gcc
12087 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12088 (detect_coding_iso_2022): Initialize a local variable that might
12089 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12090 this initialization is needed. (Bug#8211)
5f58e762
PE
12091 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12092 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12093 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12094 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12095 Remove unused macros.
f38b440c 12096
232b38b9 12097 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12098 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12099 * character.c (string_count_byte8): Likewise.
232b38b9 12100
fb90da1b
PE
12101 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12102 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12103
fb93dbc2
PE
12104 * chartab.c (copy_sub_char_table): Now static, since it's not used
12105 elsewhere.
5c156ace
PE
12106 (sub_char_table_ref_and_range, char_table_ref_and_range):
12107 Rename locals to avoid shadowing.
bbcd0949 12108 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12109
7d3b3862 12110 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12111 (BIDI_BOB): Remove unused macro.
7d3b3862 12112
6be7d3da
PE
12113 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12114 deduce are never used uninitialized.
c2ed9c8b 12115 * term.c (encode_terminal_code): Likewise.
6be7d3da 12116
75f8807f 12117 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12118
50938595
PE
12119 * tparam.h: New file.
12120 * term.c, tparam.h: Include it.
12121 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12122 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12123 Move these decls to tparam.h, and make them agree with what
12124 is actually in tparam.c. The previous trick of using incompatible
12125 decls in different modules does not conform to the C standard.
12126 All callers of tparam changed to use tparam's actual API.
12127 * tparam.c (tparam1, tparam, tgoto):
12128 Use const pointers where appropriate.
12129
fbceeba2
PE
12130 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12131 * cm.h (struct cm): Likewise.
12132 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12133 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12134 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12135 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12136 (turn_on_face, init_tty): Likewise.
12137 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12138
7f3f1250
PE
12139 * term.c (term_mouse_position): Rename local to avoid shadowing.
12140
e6ca6543
PE
12141 * alloc.c (mark_ttys): Move decl from here ...
12142 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12143
c40f8d15
AS
121442011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12145
12146 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12147
cfe0661d
JB
121482011-03-09 Juanma Barranquero <lekktu@gmail.com>
12149
12150 * search.c (compile_pattern_1): Remove argument regp, unused since
12151 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12152 (compile_pattern): Don't pass it.
12153
0afb4571
J
121542011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12155
12156 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12157 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12158 for ! HAVE_GTK3.
12159 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12160
12161 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12162
12163 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12164 gdk_window_get_screen, gdk_window_get_geometry,
12165 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12166 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12167 (xg_get_pixbuf_from_pixmap): New function.
12168 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12169 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12170 Call xg_get_pixbuf_from_pixmap instead of
12171 gdk_pixbuf_get_from_drawable.
12172 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12173 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12174 (xg_check_special_colors): Use GtkStyleContext and its functions
12175 for HAVE_GTK3.
12176 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12177 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12178 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12179 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12180 Call gtk_widget_get_preferred_size.
0afb4571
J
12181 (xg_frame_resized): gdk_window_get_geometry only takes 5
12182 parameters.
44f230aa
SM
12183 (xg_win_to_widget, xg_event_is_for_menubar):
12184 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12185 (xg_set_widget_bg): New function.
12186 (delete_cb): New function.
895009e1 12187 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12188 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12189 (xg_set_background_color): Call xg_set_widget_bg.
12190 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12191 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12192 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12193 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12194 if ! HAVE_GTK3.
12195 (update_frame_tool_bar): Call gtk_widget_hide.
12196 (xg_initialize): Use GDK_KEY_g.
12197
12198 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12199 if ! HAVE_GTK3
12200 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12201
12202 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12203 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12204 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12205
1c2cc4ef
JB
122062011-03-08 Juanma Barranquero <lekktu@gmail.com>
12207
12208 * w32xfns.c (select_palette): Check success of RealizePalette against
12209 GDI_ERROR, not zero.
12210
33383987 12211See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12212
12213;; Local Variables:
12214;; coding: utf-8
aac0c6e3
MR
12215;; End:
12216
2f097256 12217 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12218
12219 This file is part of GNU Emacs.
12220
12221 GNU Emacs is free software: you can redistribute it and/or modify
12222 it under the terms of the GNU General Public License as published by
12223 the Free Software Foundation, either version 3 of the License, or
12224 (at your option) any later version.
12225
12226 GNU Emacs is distributed in the hope that it will be useful,
12227 but WITHOUT ANY WARRANTY; without even the implied warranty of
12228 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12229 GNU General Public License for more details.
12230
12231 You should have received a copy of the GNU General Public License
12232 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.