New Tramp features.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
95988fcf
AS
12012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2
3 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4 account for preceding backslashes. (Bug#11663)
5
cd4eb164
CY
62012-06-09 Chong Yidong <cyd@gnu.org>
7
8 * term.c: Support italics in capable terminals (Bug#9652).
9 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
10 (turn_on_face): Output using TS_enter_italic_mode if available.
11 Don't handle unused blinking and alt-charset cases.
12 (turn_off_face): Handle italic case; discard unused tty_blinking_p
13 and tty_alt_charset_p cases.
14 (tty_capable_p, init_tty): Support italics.
15
16 * termchar.h (struct tty_display_info): Add field for italics.
17 Remove unused blink field.
18
19 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
20 Handle slant.
21
22 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
23 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
24 tty_alt_charset_p. Add tty_italic_p.
25
ff88beb8
MA
262012-06-09 Michael Albinus <michael.albinus@gmx.de>
27
28 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
29 dbus_type_is_basic if available.
30 (xd_extract_signed, xd_extract_unsigned): Rename from
31 extract_signed and extract_unsigned, respectively. Adapt callers.
32
44286096
CY
332012-06-09 Chong Yidong <cyd@gnu.org>
34
1682701f
CY
35 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
36
44286096
CY
37 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
38 case (Bug#9752).
39
d86feb17
PE
402012-06-08 Paul Eggert <eggert@cs.ucla.edu>
41
42 * xdisp.c (vmessage): Treat frame message as multibyte.
43 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
44 would generate the diagnostic "Making \302\247 buffer-local while
45 let-bound!".
46
d5c20fe8
EZ
472012-06-08 Eli Zaretskii <eliz@gnu.org>
48
49 * dispnew.c (showing_window_margins_p): Undo last change, which
50 was done due to an inadvertent commit.
51 (adjust_frame_glyphs_for_frame_redisplay): Do call
52 showing_window_margins_p.
53
513749ee
SM
542012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
55
56 * eval.c (Fmake_var_non_special): New primitive.
57 (syms_of_eval): Defsubr it.
58 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
59
d4a8f5c1
JB
602012-06-08 Juanma Barranquero <lekktu@gmail.com>
61
62 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
63 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
64
8bbbc977
EZ
652012-06-08 Eli Zaretskii <eliz@gnu.org>
66
67 * alloc.c (allocate_vectorlike): Fix last change.
68
f3372c87
DA
692012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
70
71 Block-based vector allocation of small vectors.
72 * lisp.h (struct vectorlike_header): New field `nbytes',
73 adjust comment accordingly.
74 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
75 to denote vector blocks. Adjust users (live_vector_p,
76 mark_maybe_pointer, valid_lisp_object_p) accordingly.
77 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
78 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
79 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
80 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
81 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
82 (roundup_size): New constant.
83 (struct vector_block): New data type.
84 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 85 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
86 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
87 (sweep_vectors): New functions.
88 (allocate_vectorlike): Return `zero_vector' as the only vector of
89 0 items. Allocate new vector from block if vector size is less than
90 or equal to VBLOCK_BYTES_MAX.
91 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
92 (init_alloc_once): Add call to init_vectors.
93
4f18a4ed
SM
942012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
95
96 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
97
86f158bc
PE
982012-06-07 Paul Eggert <eggert@cs.ucla.edu>
99
100 * doprnt.c (doprnt): Truncate multibyte char correctly.
101 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
102 would mishandle a string argument "Xc" if X was a multibyte
103 character of length 2: it would truncate after X's first byte
104 rather than including all of X.
105
c5cfcbe0
CY
1062012-06-06 Chong Yidong <cyd@gnu.org>
107
108 * buffer.c (word_wrap): Doc fix.
109
c05cf390
PE
1102012-06-04 Paul Eggert <eggert@cs.ucla.edu>
111
112 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
113
0c3461de
GM
1142012-06-03 Glenn Morris <rgm@gnu.org>
115
116 * xdisp.c (tool-bar-style): Doc fix.
117
c71232db
UM
1182012-06-03 Ulrich Müller <ulm@gentoo.org>
119
120 * Makefile.in (PAXCTL): Define.
121 (temacs$(EXEEXT)): Disable memory randomization for the temacs
122 binary via PaX flags if the paxctl utility is available.
123 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
124 Restore PaX flags to their default. (Bug#11398)
125
383f7350
CY
1262012-06-03 Chong Yidong <cyd@gnu.org>
127
128 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
129 buffer (Bug#11226).
130
5f2c76c6
CY
1312012-06-03 Chong Yidong <cyd@gnu.org>
132
133 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
134 (note_mode_line_or_margin_highlight): If there is no help echo,
135 use mode-line-default-help-echo. Handle the case where the mouse
136 position is past the end of the mode line string.
137
138 * buffer.c (buffer_local_value_1): New function, split from
139 Fbuffer_local_value; can return Qunbound.
140 (Fbuffer_local_value): Use it.
141 (Vmode_line_format): Docstring tweaks.
142
773d47f6
PE
1432012-06-02 Paul Eggert <eggert@cs.ucla.edu>
144
145 * sysdep.c (system_process_attributes): Improve comment.
146
f2d6a3df
SM
1472012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
148
149 * keyboard.c: Export real-this-command to Elisp.
150 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
151 and DEFVAR it. Update all users.
152
63810350
PE
1532012-06-02 Paul Eggert <eggert@cs.ucla.edu>
154
7bd5c1f4
PE
155 * minibuf.c (Fassoc_string): Remove duplicate declaration.
156
63810350
PE
157 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
158 Convert pctcpu and pctmem to Lisp float properly.
159 Let the compiler fold better, as 100.0/0x8000 is exact.
160
a2821611
AS
1612012-06-02 Andreas Schwab <schwab@linux-m68k.org>
162
163 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
164 cons_block.
165
5fceba1d
PE
1662012-06-01 Paul Eggert <eggert@cs.ucla.edu>
167
168 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
169
c98ff5dd
DA
1702012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
171
172 For a 'struct window', replace some Lisp_Object fields to
173 bitfields where appropriate, remove unused fields.
174 * window.h (struct window): Remove unused 'last_mark_x' and
175 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
176 change it's type from Lisp_Object to bitfield.
177 Change type of 'force_start', 'optional_new_start',
178 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
179 fields from Lisp_Object to bitfield. Adjust users accordingly.
180
ca34e0be
PE
1812012-05-31 Paul Eggert <eggert@cs.ucla.edu>
182
183 Pacify gcc -Wdouble-precision when using Xaw.
184 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
185 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
186 Use 'float' consistently, rather than 'float' in most places
187 and 'double' in a couple of places.
188
efc00ab1 1892012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
190
191 * xdisp.c (handle_stop): Detect whether we have overlay strings
192 loaded by testing it->current.overlay_string_index to be
193 non-negative, instead of checking whether n_overlay_strings is
194 positive. (Bug#11587)
195
efc00ab1 1962012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
197
198 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
199
200 * doc.c (Fsubstitute_command_keys): Doc fix.
201
efc00ab1 2022012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
203
204 * search.c (search_buffer): Remove calls to
205 r_alloc_inhibit_buffer_relocation, as it is now called by
206 maybe_unify_char, which was the cause of relocation of buffer text
207 in bug#11519.
208
efc00ab1 2092012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
210
211 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
212 for the duration of call to load_charset, to avoid problems with
213 callers of maybe_unify_char that access buffer text through C
214 pointers.
215
216 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
217 decrement the inhibition flag, instead of just setting or
218 resetting it.
219
ba93a187
PE
2202012-05-31 Paul Eggert <eggert@cs.ucla.edu>
221
222 Remove obsolete '#define static' cruft.
223 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
224 This #undef was "temporary" in 2000; it is no longer needed
225 now that '#define static' has gone away.
226 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
227 (gray_bitmap_bits): Remove; no longer needed.
228 All uses replaced with definiens.
229 * xterm.c: Include "bitmaps/gray.xbm".
230
9e4bf381
PE
2312012-05-30 Paul Eggert <eggert@cs.ucla.edu>
232
233 Clean up __executable_start, monstartup when --enable-profiling.
234 The following changes affect the code only when profiling.
235 * dispnew.c (__executable_start): Rename from safe_bcopy.
236 Define only on platforms that need it.
237 * emacs.c: Include <sys/gmon.h> when profiling.
238 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
239 (__executable_start): Remove decl, since lisp.h does it now.
240 (safe_bcopy): Remove decl; no longer has that name.
241 (main): Coalesce #if into single bit of code, for simplicity.
242 Cast pointers to uintptr_t, since standard libraries want integers
243 and not pointers.
244 * lisp.h (__executable_start): New decl.
245
32d72c2f
GM
2462012-05-31 Glenn Morris <rgm@gnu.org>
247
248 * image.c (Fimagemagick_types): Doc fix.
249
baac5bc7
JM
2502012-05-30 Jim Meyering <meyering@redhat.com>
251
252 * callproc.c (Fcall_process_region): Include directory component
253 in mkstemp error message (Bug#11586).
254
72cb32cf
PE
2552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
256
257 * alloc.c, lisp.h (make_pure_vector): Now static.
258
61b108cc
SM
2592012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
260
261 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
262 Move to byte-run.el.
263 (Fautoload): Do the hash-doc more carefully.
264 * data.c (Fdefalias): Purify definition, except for keymaps.
265 (Qdefun): Move from eval.c.
266 * lisp.h (Qdefun): Remove.
267 * lread.c (read1): Tiny simplification.
268
471fe23d
TN
2692012-05-29 Troels Nielsen <bn.troels@gmail.com>
270
934f3f58 271 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
272 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
273 Bug#9642, but explicitly check that the buffer the overlay would
274 be moved to is live and rearrange lines to make sure that errors
275 will not put the overlay in an inconsistent state.
276 (Fdelete_overlay): Cosmetics.
277
85d0efd1
EZ
2782012-05-28 Eli Zaretskii <eliz@gnu.org>
279
280 * w32term.c (my_bring_window_to_top): New function.
281 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
282 could be different from the original one.
283 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
284 (Bug#11513)
285
286 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
287 by calling BringWindowToTop.
288
289 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
290 (WM_EMACS_END): Increase by one.
291
da92a98c
PE
2922012-05-28 Paul Eggert <eggert@cs.ucla.edu>
293
294 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
295 This avoids undefined behavior that might cause the eassert
296 to not catch an out-of-range value.
297
74d1f848
JB
2982012-05-28 Juanma Barranquero <lekktu@gmail.com>
299
300 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
301 Update dependencies.
302
9e1a06fc
EZ
3032012-05-27 Eli Zaretskii <eliz@gnu.org>
304
305 * bidi.c (bidi_mirror_char): Fix last change.
306
f3dd7312
AS
3072012-05-27 Andreas Schwab <schwab@linux-m68k.org>
308
309 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
310 when referring to sectname field in printf format.
311
81899c91
PE
3122012-05-27 Paul Eggert <eggert@cs.ucla.edu>
313
57b81a9f
PE
314 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
315 Only r_alloc_inhibit_buffer_relocation needed to be added;
316 the others were already declared.
317
81899c91
PE
318 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
319 before checking whether it's out of range. Put the check inside
320 eassert. See
321 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
322
33017faf 3232012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
324
325 * callproc.c (Fcall_process): Restore a line that was accidentally
326 commented out in the 2011-02-13 change (bug#11547).
327
33017faf 3282012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
329
330 * lisp.h [REL_ALLOC]: Add prototypes for external functions
331 defined on ralloc.c.
332
333 * buffer.c [REL_ALLOC]: Remove prototypes of
334 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
335 they are now on lisp.h.
336
337 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
338
339 * search.c (search_buffer): Use it to inhibit relocation of buffer
340 text while re_search_2 is doing its job, because re_search_2 is
341 passed C pointers to buffer text. (Bug#11519)
342
23415acf
EZ
343 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
344 Update value to 24.
345
44e27368
EZ
346 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
347 state after an additional call to move_it_in_display_line_to, keep
348 the values of it->max_ascent and it->max_descent found for the
349 entire line.
350 (pos_visible_p): Revert the comparison against bottom_y to what it
351 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
352 (Bug#11464)
353
c1892f11
PE
3542012-05-26 Paul Eggert <eggert@cs.ucla.edu>
355
356 Fix coding-related core dumps with gcc -ftrapv.
357 The code was computing A - B, where A and B are pointers, and B is
358 random garbage. This can lead to core dumps on platforms that
359 have special pointer registers, and it also leads to core dumps on
360 x86-64 when compiled with gcc -ftrapv. The fix is to compute
361 A - B only when B is initialized properly.
362 * coding.c (coding_set_source, coding_set_destination): Return void.
363 (coding_change_source, coding_change_destinations): New functions,
364 with the old behaviors of coding_set_source and coding_set_destination.
365 All callers that need an offset changed to use these new functions.
366
eb7afdad
GM
3672012-05-26 Glenn Morris <rgm@gnu.org>
368
369 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
370
f12fdf02
EZ
3712012-05-26 Eli Zaretskii <eliz@gnu.org>
372
53a63be6 373 Extend mouse support on W32 text-mode console.
61b108cc
SM
374 * xdisp.c (draw_row_with_mouse_face):
375 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 376
eb3f6f01 377 * w32console.c: Include window.h.
61b108cc
SM
378 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
379 New functions.
eb3f6f01
EZ
380 (initialize_w32_display): Initialize mouse-highlight data.
381
53a63be6
EZ
382 * w32inevt.c: Include termchar.h and window.h.
383 (do_mouse_event): Support mouse-autoselect-window. When the mouse
384 moves, call note_mouse_highlight. If help_echo changed, call
385 gen_help_event to produce help-echo message in the echo area.
386 Call clear_mouse_face if mouse_face_hidden is set in the mouse
387 highlight info.
388
4cfd81f6
PE
3892012-05-26 Paul Eggert <eggert@cs.ucla.edu>
390
391 * lread.c (read1): Simplify slightly to avoid an overflow warning
392 with GCC 4.7.0 on x86-64.
393
4446092a
EZ
3942012-05-26 Eli Zaretskii <eliz@gnu.org>
395
396 * bidi.c (bidi_mirror_char): Revert last change: an int is
397 definitely wide enough here.
398
42b2a986 3992012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 400
42b2a986 401 Fix integer width and related bugs (Bug#9874).
eb106a49 402 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
403 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
404 (string_bytes, check_sblock, allocate_string_data):
405 (compact_small_strings, Fmake_bool_vector, make_string)
406 (make_unibyte_string, make_multibyte_string)
407 (make_string_from_bytes, make_specified_string)
408 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
409 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
410 (mark_vectorlike):
411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
412 (allocate_pseudovector):
413 Use int, not EMACS_INT, where int is wide enough.
414 (inhibit_garbage_collection, Fgarbage_collect):
415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
416 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
417 int might not be wide enough.
418 (bidi_cache_search, bidi_cache_find, bidi_init_it)
419 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
420 (bidi_at_paragraph_end, bidi_find_paragraph_start)
421 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
422 (bidi_level_of_next_char, bidi_move_to_visually_next):
423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
424 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
425 (Fkill_buffer, Fset_buffer_major_mode)
426 (advance_to_char_boundary, Fbuffer_swap_text)
427 (Fset_buffer_multibyte, overlays_at, overlays_in)
428 (overlay_touches_p, struct sortvec, record_overlay_string)
429 (overlay_strings, recenter_overlay_lists)
430 (adjust_overlays_for_insert, adjust_overlays_for_delete)
431 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
432 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
433 (Foverlay_recenter, last_overlay_modification_hooks_used)
434 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
436 (validate_region): Omit unnecessary test for b <= e,
437 since that's guaranteed by the previous test.
d311d28c
PE
438 (adjust_overlays_for_delete): Avoid pos + length overflow.
439 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
440 (report_overlay_modification):
441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
442 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
443 Omit pointer cast, which isn't needed anyway, and doesn't work
444 after the EMACS_INT -> ptrdiff_t change.
02481186 445 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
446 * buffer.h: Adjust decls to match defn changes elsewhere.
447 (struct buffer_text, struct buffer):
448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
449 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
450 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
451 not int, to avoid needless 32-bit limit on 64-bit hosts.
452 (exec_byte_code): Use tighter memory-full test, one that checks
453 for alloca overflow. Don't compute the address of the object just
454 before an array, as that's not portable. Use EMACS_INT, not
455 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
456 * callint.c (Fcall_interactively):
457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
458 * callproc.c (call_process_kill, Fcall_process):
459 Don't assume pid_t fits into an Emacs fixnum.
460 (call_process_cleanup, Fcall_process, child_setup):
461 Don't assume pid_t fits into int.
462 (call_process_cleanup, Fcall_process, delete_temp_file)
463 (Fcall_process_region):
464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
465 (Fcall_process): Simplify handling of volatile integers.
466 Use int, not EMACS_INT, where int will do.
467 * casefiddle.c (casify_object, casify_region, operate_on_word)
468 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
470 (casify_object): Avoid integer overflow when overallocating buffer.
471 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 472 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
473 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
474 * category.h (CATEGORYP): Don't assume arg is nonnegative.
475 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
476 integers are now checked earlier. All uses replaced with XINT.
477 (ccl_driver):
478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
479 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
480 (ccl_driver, Fregister_code_conversion_map):
481 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
482 (resolve_symbol_ccl_program): Check that vector header is in range.
483 Always copy the vector, so that we can check its contents reliably
484 now rather than having to recheck each instruction as it's being
485 executed. Check that vector words fit in 'int'.
486 (ccl_get_compiled_code, Fregister_ccl_program)
487 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
488 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
489 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
490 contents are in range.
491 (Fccl_execute_on_string): Check that status is in range.
492 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
493 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
494 Accept and return EMACS_INT, not int, because callers can pass values
495 out of 'int' range.
496 (c_string_width, strwidth, lisp_string_width, chars_in_text)
497 (multibyte_chars_in_text, parse_str_as_multibyte)
498 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
499 (str_as_unibyte, str_to_unibyte, string_count_byte8)
500 (string_escape_byte8, Fget_byte):
501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 502 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
503 avoid mishandling large integers.
504 * character.h: Adjust decls to match defn changes elsewhere.
505 * charset.c (load_charset_map_from_file, find_charsets_in_text)
506 (Ffind_charset_region):
507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
508 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
509 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 510 Don't assume fixnum fits in int.
d311d28c
PE
511 (load_charset_map_from_vector, Fmap_charset_chars):
512 Remove now-unnecessary CHECK_NATNUMs.
513 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
514 Don't rely on undefined behavior with signed left shift overflow.
515 Don't assume unsigned int fits into fixnum, or that fixnum fits
516 into unsigned int. Don't require max_code to be a valid fixnum;
517 that's not true for gb10830 4-byte on a 32-bit host. Allow
518 invalid_code to be a cons, for the same reason. Require code_offset
519 to be a character. Avoid int overflow if max_char is close
520 to INT_MAX.
521 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
522 this is intended anyway and avoids some undefined behavior.
523 (load_charset_map): Pass unsigned, not int, as 2nd arg of
524 INDEX_TO_CODE_POINT, as that's what it expects.
525 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
526 * charset.h (DECODE_CHAR): Return int, not unsigned;
527 this is what was intended anyway, and it avoids undefined behavior.
528 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
529 integer-overflow issues.
530 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
531 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
532 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
533 * chartab.c (Fmake_char_table, Fset_char_table_range)
534 (uniprop_get_decoder, uniprop_get_encoder):
535 Don't assume fixnum fits in int.
536 * cmds.c (move_point): New function, that does the gist of
537 Fforward_char and Fbackward_char, but does so while checking
538 for integer overflow more accurately.
c96e5d6a 539 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
540 (Fforward_line, Fend_of_line, internal_self_insert)
541 (internal_self_insert):
542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
543 Fix a FIXME, by checking for integer overflow when calculating
544 target_clm and actual_clm.
545 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 546 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
547 (ASSURE_DESTINATION, coding_alloc_by_realloc)
548 (coding_alloc_by_making_gap, alloc_destination)
549 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
550 (encode_coding_utf_16, detect_coding_emacs_mule)
551 (decode_coding_emacs_mule, encode_coding_emacs_mule)
552 (detect_coding_iso_2022, decode_coding_iso_2022)
553 (encode_invocation_designation, encode_designation_at_bol)
554 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
555 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
556 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
557 (encode_coding_ccl, encode_coding_raw_text)
558 (detect_coding_charset, decode_coding_charset)
559 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
560 (produce_composition, produce_charset, produce_annotation)
561 (decode_coding, handle_composition_annotation)
562 (handle_charset_annotation, consume_chars, decode_coding_gap)
563 (decode_coding_object, encode_coding_object, detect_coding_system)
564 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
565 (code_convert_region, code_convert_string)
8f50130c
PE
566 (Fdefine_coding_system_internal)
567 (coding_set_source, coding_set_destination):
d311d28c
PE
568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
569 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
570 (Fdefine_coding_system_internal):
571 Don't assume fixnums fit in int.
572 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 573 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
574 (Funencodable_char_position, Fcheck_coding_systems_region)
575 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 577 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 578 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 579 Don't access memory outside of the args array.
d311d28c 580 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
581 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
582 result of ENCODE_CHAR.
d311d28c
PE
583 * coding.h: Adjust decls to match defn changes elsewhere.
584 (struct coding_system):
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 * composite.c (get_composition_id, find_composition)
587 (run_composition_function, update_compositions)
588 (compose_text, composition_gstring_put_cache)
589 (composition_gstring_p, composition_gstring_width)
590 (fill_gstring_header, fill_gstring_body, autocmp_chars)
591 (composition_compute_stop_pos, composition_reseat_it)
592 (composition_update_it, struct position_record)
593 (find_automatic_composition, composition_adjust_point)
594 (Fcomposition_get_gstring, Ffind_composition_internal):
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 (update_compositions):
597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
598 * composite.h: Adjust decls to match defn changes elsewhere.
599 (struct composition):
600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
601 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
602 Do not attempt to compute the address of the object just before a
603 buffer; this is not portable.
604 (Faref, Faset):
605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
606 (Faset): Use int, not EMACS_INT, where int is wide enough.
607 (Fstring_to_number): Don't assume fixnums fit in int.
608 (Frem): Don't assume arg is nonnegative.
609 * dbusbind.c (xd_append_arg): Check for integers out of range.
610 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 611 (extract_signed, extract_unsigned): New functions.
243e0530
PE
612 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
613 (xd_get_connection_references): Return ptrdiff_t, not int.
614 All uses changed.
615 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
616 (xd_read_message_1):
617 Use int, not unsigned, where the dbus API uses int.
618 (Fdbus_message_internal): Don't overflow mtype.
619 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
620 * dired.c (directory_files_internal, file_name_completion, scmp)
621 (file_name_completion_stat):
622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
623 (file_name_completion): Don't overflow matchcount.
624 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
625 * dispextern.h: Adjust decls to match defn changes elsewhere.
626 (struct text_pos, struct glyph, struct bidi_saved_info)
627 (struct bidi_string_data, struct bidi_it, struct composition_it)
628 (struct it):
629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
630 (struct display_pos, struct composition_it, struct it):
631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
632 * dispnew.c (increment_matrix_positions)
633 (increment_row_positions, mode_line_string)
634 (marginal_area_string):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 636 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
638 (duration_to_sec_usec): New function, to check for overflow better.
639 (Fsleep_for, sit_for): Use it.
640 * doc.c (get_doc_string, store_function_docstring):
641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
642 (get_doc_string, Fsnarf_documentation):
643 Use int, not EMACS_INT, where int is wide enough.
644 (get_doc_string):
645 Use SAFE_ALLOCA, not alloca.
646 Check for overflow when converting EMACS_INT to off_t.
647 * doprnt.c (doprnt):
648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
649 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
650 Don't assume uid_t fits into fixnum.
651 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
652 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
653 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
654 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
655 (general_insert_function)
656 (Finsert_char, make_buffer_string, make_buffer_string_both)
657 (update_buffer_properties, Fbuffer_substring)
658 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
659 (Fsubst_char_in_region, check_translation)
660 (Ftranslate_region_internal, save_restriction_restore, Fformat)
661 (transpose_markers, Ftranspose_regions):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 (clip_to_bounds): Move to lisp.h as an inline function).
664 (Fconstrain_to_field): Don't assume integers are nonnegative.
665 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
666 (Fsubst_char_in_region, Fsave_restriction):
667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
668 (Femacs_pid): Don't assume pid_t fits into fixnum.
669 (lo_time): Use int, not EMACS_INT, when int suffices.
670 (lisp_time_argument): Check for usec out of range.
671 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
672 (Fuser_login_name, Fuser_full_name): Signal an error
673 if a uid argument is out of range, rather than relying on
674 undefined behavior.
c8d5c857
PE
675 (Fformat_time_string): Remove now-unnecessary check.
676 lisp_time_argument checks for out-of-range usec now.
243e0530 677 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
678 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
679 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
680 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
681 (init_cmdargs, Fdump_emacs):
682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
683 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
684 the bottom (typically) 32 bits of the fixnum.
685 * eval.c (specpdl_size, call_debugger):
686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
687 (when_entered_debugger, Fbacktrace_debug):
688 Don't assume fixnum can fit in int.
689 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
690 the object just before a buffer; this is not portable.
691 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
692 (grow_specpdl, unbind_to):
693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
694 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
695 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 696 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
697 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
698 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
700 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
701 (a_write, e_write):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
703 (Fcopy_file, non_regular_nbytes, read_non_regular)
704 (Finsert_file_contents):
705 Use int, not EMACS_INT, where int is wide enough.
706 (READ_BUF_SIZE): Verify that it fits in int.
707 (Finsert_file_contents): Check that counts are in proper range,
708 rather than assuming fixnums fit into ptrdiff_t etc.
709 Don't assume fixnums fit into int.
125b3835 710 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
711 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
712 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
713 (string_char_to_byte, string_byte_to_char)
714 (string_make_multibyte, string_to_multibyte)
715 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
716 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
717 (substring_both, Fdelete, internal_equal, Ffillarray)
718 (Fclear_string, mapcar1)
719 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
720 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
721 (larger_vector, make_hash_table, maybe_resize_hash_table)
722 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
723 (Fmaphash, secure_hash):
724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
725 (concat): Check for string index and length overflow.
726 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
727 (Frequire):
728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
729 (larger_vector): New API (vec, incr_min, size_max) replaces old
730 one (vec, new_size, init). This catches size overflow.
731 INIT was removed because it was always Qnil.
732 All callers changed.
733 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
734 the upper bound on a hash table index size.
735 (make_hash_table, maybe_resize_hash_table): Use it.
736 (secure_hash): Computer start_byte and end_byte only after
737 they're known to be in ptrdiff_t range.
738 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
739 (Ffont_get_glyphs, Ffont_at):
740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
741 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
742 (Flist_fonts, Fopen_font):
743 Don't assume fixnum can fit in int.
744 (check_gstring): Don't assume index can fit in int.
745 (font_match_p): Check that fixnum is a character, not a nonnegative
746 fixnum, since the later code needs to stuff it into an int.
747 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
748 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
749 conversion overflow issues.
750 (Fopen_font): Check for integer out of range.
751 (Ffont_get_glyphs): Don't assume index can fit in int.
752 * font.h: Adjust decls to match defn changes elsewhere.
753 * fontset.c (reorder_font_vector): Redo score calculation to avoid
754 integer overflow.
755 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
756 printmax_t, where ptrdiff_t is wide enough.
757 (Finternal_char_font):
758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
759 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
760 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
761 (Fset_frame_position, x_set_frame_parameters)
762 (x_set_line_spacing, x_set_border_width)
763 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
764 Check that fixnums are in proper range for system types.
765 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
767 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
768 Use SAFE_ALLOCA_LISP, not alloca.
769 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
770 intptr_t is wide enough.
771 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
772 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
773 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
774 Check for fixnum out of range.
775 * ftfont.c (ftfont_list): Don't assume index fits in int.
776 Check that fixnums are in proper range for system types.
777 (ftfont_shape_by_flt):
778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
779 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
781 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
782 Check that fixnums are in proper range for system types.
783 * gnutls.h: Adjust decls to match defn changes elsewhere.
784 * gtkutil.c (xg_dialog_run):
785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
786 (update_frame_tool_bar):
787 Check that fixnums are in proper range for system types.
788 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 789 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
790 * indent.c (last_known_column, last_known_column_point):
791 (current_column_bol_cache):
792 (skip_invisible, current_column, check_display_width):
793 (check_display_width, scan_for_column, current_column_1)
794 (Findent_to, Fcurrent_indentation, position_indentation)
795 (indented_beyond_p, Fmove_to_column, compute_motion):
796 (Fcompute_motion, Fvertical_motion):
797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
798 (last_known_column_modified): Use EMACS_INT, not int.
799 (check_display_width):
800 (Fcompute_motion):
801 Check that fixnums and floats are in proper range for system types.
802 (compute_motion): Don't assume index or fixnum fits in int.
803 (compute_motion, Fcompute_motion):
804 Use int, not EMACS_INT, when it is wide enough.
805 (vmotion): Omit local var start_hpos that is always 0; that way
806 we don't need to worry about overflow in expressions involving it.
807 * indent.h: Adjust decls to match defn changes elsewhere.
808 (struct position):
809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
810 Use int, not EMACS_INT, where int is wide enough.
811 Remove unused members ovstring_chars_done and tab_offset;
812 all uses removed.
813 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
814 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
815 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
816 (make_gap, copy_text, insert, insert_and_inherit)
817 (insert_before_markers, insert_before_markers_and_inherit)
818 (insert_1, count_combining_before, count_combining_after)
819 (insert_1_both, insert_from_string)
820 (insert_from_string_before_markers, insert_from_string_1)
821 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
822 (adjust_after_replace, adjust_after_insert, replace_range)
823 (replace_range_2, del_range, del_range_1, del_range_byte)
824 (del_range_both, del_range_2, modify_region)
825 (prepare_to_modify_buffer, signal_before_change)
826 (signal_after_change, Fcombine_after_change_execute):
827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
828 * intervals.c (traverse_intervals, rotate_right, rotate_left)
829 (balance_an_interval, split_interval_right, split_interval_left)
830 (find_interval, next_interval, update_interval)
831 (adjust_intervals_for_insertion, delete_node, delete_interval)
832 (interval_deletion_adjustment, adjust_intervals_for_deletion)
833 (static_offset_intervals, offset_intervals)
834 (merge_interval_right, merge_interval_left, make_new_interval)
835 (graft_intervals_into_buffer, temp_set_point_both)
836 (temp_set_point, set_point, adjust_for_invis_intang)
837 (set_point_both, move_if_not_intangible, get_property_and_range)
838 (get_local_map, copy_intervals, copy_intervals_to_string)
839 (compare_string_intervals, set_intervals_multibyte_1):
840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
841 * intervals.h: Adjust decls to match defn changes elsewhere.
842 (struct interval):
843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
844 * keyboard.c (this_command_key_count, this_single_command_key_start)
845 (before_command_key_count, before_command_echo_length, echo_now)
846 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
847 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
848 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
849 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
851 (last_non_minibuf_size, last_point_position, echo_truncate)
852 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
853 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
854 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
855 (stuff_buffered_input):
856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
857 (last_auto_save, command_loop_1, read_char):
858 Use EMACS_INT, not int, to avoid integer overflow.
859 (record_char): Avoid overflow in total_keys computation.
860 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
861 * keyboard.h: Adjust decls to match defn changes elsewhere.
862 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
863 (Fkey_description, Fdescribe_vector, Flookup_key):
864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
865 (click_position): New function, to check that positions are in range.
866 (Fcurrent_active_maps):
867 (describe_command):
868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
869 (Faccessible_keymaps, Fkey_description):
870 (preferred_sequence_p):
871 Don't assume fixnum can fit into int.
872 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
873 Check for integer overflow in size calculations.
874 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
875 avoid mishandling large integers.
876 * lisp.h: Adjust decls to match defn changes elsewhere.
877 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
878 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
879 (struct Lisp_Marker):
880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
881 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
882 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
883 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
884 All callers changed.
885 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
886 Assume the arg has valid form, since it always does.
887 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
888 unsigned integer system type.
889 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
890 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
892 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
893 (duration_to_sec_usec): New decl.
894 * lread.c (read_from_string_index, read_from_string_index_byte)
895 (read_from_string_limit, readchar, unreadchar, openp)
896 (read_internal_start, read1, oblookup):
897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
898 (Fload, readevalloop, Feval_buffer, Feval_region):
899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
900 (openp): Check for out-of-range argument to 'access'.
901 (read1): Use int, not EMACS_INT, where int is wide enough.
902 Don't assume fixnum fits into int.
6efdadfd 903 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
904 (read_filtered_event): Use duration_to_sec_usec
905 to do proper overflow checking on durations.
d311d28c
PE
906 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
907 in size calculation.
908 (Fexecute_kbd_macro):
909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
910 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
911 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
912 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
913 (set_marker_both, set_marker_restricted_both, marker_position)
914 (marker_byte_position, Fbuffer_has_markers_at):
915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
916 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 917 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
918 It now merely ensures that the menu is large enough, without
919 necessarily growing it, as this avoids some integer overflow issues.
920 All callers changed.
921 (keymap_panes, parse_single_submenu, Fx_popup_menu):
922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
923 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
924 Use SAFE_ALLOCA_LISP, not alloca.
925 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
926 to EMACS_INT. Check that fixnums are in proper range for system types.
927 * minibuf.c (minibuf_prompt_width, string_to_object)
928 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
929 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
931 (get_minibuffer, read_minibuf_unwind):
932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
933 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
934 this simplifies overflow checking. All callers changed.
935 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
936 (Ftest_completion):
937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
938 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
939 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
940 Check that fixnums are in proper range for system types.
941 (Fx_create_frame, Fx_show_tip):
942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
943 * nsfont.m (ns_findfonts, nsfont_list_family):
944 Don't assume fixnum fits in long.
945 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
947 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
948 wide enough.
17fdb222 949 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
951 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
952 (PRINTDECLARE, PRINTPREPARE):
953 (strout, print_string):
954 (print, print_preprocess, print_check_string_charset_prop)
955 (print_object):
956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
957 (PRINTDECLARE):
958 (temp_output_buffer_setup, Fprin1_to_string, print_object):
959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
960 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 961 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 962 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
963 (print_error_message): Use SAFE_ALLOCA, not alloca.
964 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
965 (print_depth, new_backquote_output, print_number_index):
966 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
967 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
968 (Fset_process_window_size, Fformat_network_address)
969 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 970 (sigchld_handler):
d311d28c 971 Check that fixnums are in proper range for system types.
d44287d4 972 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
973 Check for process-ids out of pid_t range rather than relying on
974 undefined behavior.
e4d81efc 975 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
976 (Fformat_network_address, read_process_output, send_process)
977 (Fprocess_send_region, status_notify):
978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
979 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
980 (wait_reading_process_output, read_process_output, exec_sentinel):
981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
982 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
983 (Faccept_process_output): Use duration_to_sec_usec to do proper
984 overflow checking on durations.
dde14581
PE
985 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
986 Don't assume pid_t fits in int.
02481186
PE
987 * process.h (struct Lisp_Process): Members tick and update_tick
988 are now of type EMACS_INT, not int.
b62b53e8
PE
989 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
990 configured --with-wide-int.
d311d28c
PE
991 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
992 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
993 * search.c (looking_at_1, string_match_1):
994 (fast_string_match, fast_c_string_match_ignore_case)
995 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
996 (scan_newline, find_before_next_newline, search_command)
997 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
998 (set_search_regs, wordify):
999 (Freplace_match):
1000 (Fmatch_data):
1001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1002 (string_match_1, search_buffer, set_search_regs):
1003 (Fmatch_data):
1004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1005 (wordify): Check for overflow in size calculation.
1006 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1007 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1008 Check that fixnums are in proper range for system types.
1009 * sound.c (struct sound_device)
1010 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1012 (Fplay_sound_internal):
1013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1014 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1015 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1016 (Fparse_partial_sexp):
1017 Don't assume fixnums can fit in int.
1018 (struct lisp_parse_state, find_start_pos, find_start_value)
1019 (find_start_value_byte, find_start_begv)
1020 (update_syntax_table, char_quoted, dec_bytepos)
1021 (find_defun_start, prev_char_comend_first, back_comment):
1022 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1023 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1025 (Finternal_describe_syntax_value): Check that match_lisp is a
1026 character, not an integer, since the code stuffs it into int.
1027 (scan_words, scan_sexps_forward):
1028 Check that fixnums are in proper range for system types.
1029 (Fforward_word):
1030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1031 (scan_sexps_forward):
1032 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1033 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1034 * syntax.h: Adjust decls to match defn changes elsewhere.
1035 (struct gl_state_s):
1036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1037 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1038 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1039 * sysdep.c (wait_for_termination_1, wait_for_termination)
1040 (interruptible_wait_for_termination, mkdir):
1041 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1042 (emacs_read, emacs_write):
1043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1044 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1045 and double all fit in int.
d311d28c
PE
1046 * term.c (set_tty_color_mode):
1047 Check that fixnums are in proper range for system types.
1048 * termhooks.h (struct input_event):
1049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1050 * textprop.c (validate_interval_range, interval_of)
1051 (Fadd_text_properties, set_text_properties_1)
1052 (Fremove_text_properties, Fremove_list_of_text_properties)
1053 (Ftext_property_any, Ftext_property_not_all)
1054 (copy_text_properties, text_property_list, extend_property_ranges)
1055 (verify_interval_modification):
1056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1057 (Fnext_single_char_property_change)
1058 (Fprevious_single_char_property_change):
1059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1060 (copy_text_properties):
1061 Check for integer overflow in index calculation.
d311d28c
PE
1062 * undo.c (last_boundary_position, record_point, record_insert)
1063 (record_delete, record_marker_adjustment, record_change)
1064 (record_property_change):
1065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1066 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1068 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1069 (Fx_hide_tip, Fx_file_dialog):
1070 * w32menu.c (set_frame_menubar):
1071 Use ptrdiff_t, not int, for consistency with rest of code.
1072 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1073 (select_window, Fdelete_other_windows_internal)
1074 (window_scroll_pixel_based, window_scroll_line_based)
1075 (Frecenter, Fset_window_configuration):
1076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1077 (Fset_window_hscroll, run_window_configuration_change_hook)
1078 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1079 (Fscroll_other_window, Frecenter):
d311d28c
PE
1080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1081 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1082 Don't assume fixnum fits in int.
1083 (Fset_window_scroll_bars):
1084 Check that fixnums are in proper range for system types.
1085 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1086 (string_pos, c_string_pos, number_of_chars, init_iterator)
1087 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1088 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1089 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1090 (face_before_or_after_it_pos, handle_invisible_prop)
1091 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1092 (display_prop_intangible_p, string_buffer_position_lim)
1093 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1094 (get_overlay_strings_1, get_overlay_strings)
1095 (iterate_out_of_display_property, forward_to_next_line_start)
1096 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1097 (get_next_display_element, set_iterator_to_next)
1098 (get_visually_first_element, compute_stop_pos_backwards)
1099 (handle_stop_backwards, next_element_from_buffer)
1100 (move_it_in_display_line_to, move_it_in_display_line)
1101 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1102 (add_to_log, message_dolog, message_log_check_duplicate)
1103 (message2, message2_nolog, message3, message3_nolog
1104 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1105 (current_message_1, truncate_echo_area, truncate_message_1)
1106 (set_message, set_message_1, store_mode_line_noprop)
1107 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1108 (text_outside_line_unchanged_p, check_point_in_composition)
1109 (reconsider_clip_changes)
1110 (redisplay_internal, set_cursor_from_row, try_scrolling)
1111 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1112 (redisplay_window, find_last_unchanged_at_beg_row)
1113 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1114 (trailing_whitespace_p, find_row_edges, display_line)
1115 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1116 (display_mode_element, store_mode_line_string)
1117 (pint2str, pint2hrstr, decode_mode_spec)
1118 (display_count_lines, display_string, draw_glyphs)
1119 (x_produce_glyphs, x_insert_glyphs)
1120 (rows_from_pos_range, mouse_face_from_buffer_pos)
1121 (fast_find_string_pos, mouse_face_from_string_pos)
1122 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1124 (safe_call, init_from_display_pos, handle_fontified_prop)
1125 (handle_single_display_spec, load_overlay_strings)
1126 (with_echo_area_buffer, setup_echo_area_for_printing)
1127 (display_echo_area, echo_area_display)
1128 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1129 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1130 (redisplay_window, dump_glyph_row, display_mode_line)
1131 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1132 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1134 (handle_single_display_spec, build_desired_tool_bar_string)
1135 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1136 (get_specified_cursor_type):
1137 Check that fixnums are in proper range for system types.
1138 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1139 (Flookup_image_map):
1140 Don't assume fixnums fit in int.
1141 (compare_overlay_entries):
1142 Avoid mishandling comparisons due to subtraction overflow.
1143 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1144 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1145 (handle_tool_bar_click):
1146 Use int, not unsigned, since we prefer signed and the signedness
1147 doesn't matter here.
1148 (get_next_display_element, next_element_from_display_vector):
1149 Use int, not EMACS_INT, when int is wide enough.
1150 (start_hourglass): Use duration_to_sec_usec to do proper
1151 overflow checking on durations.
1152 * xfaces.c (Fbitmap_spec_p):
1153 Check that fixnums are in proper range for system types.
1154 (compare_fonts_by_sort_order):
1155 Avoid mishandling comparisons due to subtraction overflow.
1156 (Fx_family_fonts, realize_basic_faces):
1157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1158 (Fx_family_fonts):
1159 Don't assume fixnum fits in int.
1160 Use SAFE_ALLOCA_LISP, not alloca.
1161 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1162 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1163 (face_at_buffer_position, face_for_overlay_string)
1164 (face_at_string_position):
1165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1166 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1167 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1168 (Fx_show_tip):
1169 Check that fixnums are in proper range for system types.
1170 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1171 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1173 (Fx_change_window_property): Don't assume fixnums fit in int.
1174 * xfont.c (xfont_chars_supported):
1175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1176 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1177 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1179 * xml.c (parse_region):
1180 * xrdb.c (magic_file_p):
1181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1182 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1183 (x_get_local_selection, x_reply_selection_request)
1184 (x_handle_selection_request, wait_for_property_change):
1185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1186 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1187 short is wide enough.
1188 (x_send_client_event): Don't assume fixnum fits in int.
1189 * xterm.c (x_x_to_emacs_modifiers):
1190 Don't assume EMACS_INT overflows nicely into int.
1191 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1192 may come from Lisp.
1193 (handle_one_xevent): NATNUMP can eval its arg twice.
1194 (x_connection_closed):
1195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1196 * xterm.h: Adjust decls to match defn changes elsewhere.
1197 (struct scroll_bar): Use struct vectorlike_header
1198 rather than rolling our own approximation.
1199 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1200
c6574eb5
GM
12012012-05-25 Glenn Morris <rgm@gnu.org>
1202
1203 * lisp.mk (lisp): Update for more files being compiled now.
1204
e8d32c7e
SM
12052012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1206
48def666
SM
1207 * lread.c: Remove `read_pure' which makes no difference.
1208 (read_pure): Remove var.
1209 (unreadpure): Remove function.
1210 (readevalloop): Don't call read_list with -1 flag.
1211 (read1, read_vector): Don't test read_pure any more.
1212 (read_list): Simplify.
1213
e8d32c7e
SM
1214 * fileio.c, character.h: Minor style tweaks.
1215
4b2addb7
DA
12162012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 * window.h (clip_changed): Remove useless declaration.
1219
584461b2
JB
12202012-05-22 Juanma Barranquero <lekktu@gmail.com>
1221
1222 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1223 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1224
34374650
PE
12252012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 Remove src/m/*.
1228 This directory predates autoconf and is no longer needed nowadays.
1229 Move its few remaining bits of functionality to where they're needed.
1230 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1231 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1232 * m/template.h: Remove.
1233 * Makefile.in (M_FILE): Remove. All uses removed.
1234 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1235 * lisp.h (USE_LSB_TAG):
1236 * mem-limits.h (EXCEEDS_LISP_PTR):
1237 Use VAL_MAX, not VALBITS, in #if.
1238 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1239 (EMACS_UINT): Define unconditionally now.
1240 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1241 (BITS_PER_EMACS_INT): New constants, replacing
1242 what used to be in config.h, but not useful in #if.
1243 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1244 define them any more.
1245 (VAL_MAX): New macro.
1246 (VALMASK): Use it.
1247 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1248 BITS_PER_EMACS_INT, in #if.
1249 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1250 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1251 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1252 * s/ms-w32.h (DATA_START):
1253 Move here from removed file m/intel386.h.
1254 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1255 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1256
261cb4bb
PE
12572012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 Assume C89 or later.
1260 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1261 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1262 (xrealloc):
1263 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1264 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1265 * textprop.c, tparam.c (NULL): Remove.
1266 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1267 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1268 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1269 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1270 * xterm.c (input_signal_count): Assume volatile works.
1271
ff23cd9f
KB
12722012-05-21 Ken Brown <kbrown@cornell.edu>
1273
1274 * xgselect.c (xg_select): Fix first argument in call to 'select'
1275 (bug#11508).
1276
1b170bc6
KB
12772012-05-20 Ken Brown <kbrown@cornell.edu>
1278
1279 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1280 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1281
b2f4d39f
KB
12822012-05-19 Ken Brown <kbrown@cornell.edu>
1283
1284 * xfns.c (x_in_use): Remove `static' qualifier.
1285 * xterm.h (x_in_use): Declare.
1286 * xgselect.c: Include xterm.h.
1287 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1288 and `display_arg' (bug#9754).
1289
003fdae2
PE
12902012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1291
9232a6d9
PE
1292 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1293
003fdae2
PE
1294 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1295 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1296
784b56e2
EZ
12972012-05-18 Eli Zaretskii <eliz@gnu.org>
1298
1299 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1300
1301 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1302 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1303
1304 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1305 reference to image_cache->refcount.
1306 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1307
a0a79cde
JL
13082012-05-17 Juri Linkov <juri@jurta.org>
1309
1310 * search.c (Fword_search_regexp, Fword_search_backward)
1311 (Fword_search_forward, Fword_search_backward_lax)
1312 (Fword_search_forward_lax): Move functions to isearch.el
1313 (bug#10145, bug#11381).
1314
b0572523
PE
13152012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1318
9660f5fc
SM
13192012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1320
1321 * lread.c (init_obarray): Declare Qt and Qnil as special.
1322
4374de83
GM
13232012-05-14 Glenn Morris <rgm@gnu.org>
1324
1325 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1326 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1327
dc44c39a
PE
13282012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1329
078c97cb
PE
1330 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1331
dc44c39a
PE
1332 * unexaix.c: Port to more-recent AIX compilers.
1333 (report_error, report_error_1, make_hdr, copy_sym)
1334 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1335 Make arguments const char *, not char *, to avoid violations of C
1336 standard and to fix some AIX warnings reported by Gilles Pion.
1337
e18afed7 13382012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1339
1340 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1341 already have overlays loaded.
1342 (handle_single_display_spec): Before returning without displaying
1343 fringe bitmap, synchronize the bidi iterator with the main display
1344 iterator, by calling iterate_out_of_display_property.
1345 (iterate_out_of_display_property): Detect buffer iteration by
1346 testing that it->string is a Lisp string.
1347 (get_next_display_element): When the current object is exhausted,
1348 and there's something on it->stack, call set_iterator_to_next to
1349 proceed with what's on the stack, instead of returning zero.
1350 (set_iterator_to_next): If called at the end of a Lisp string,
1351 proceed to consider_string_end without incrementing string
1352 position. Don't increment display vector index past the end of
1353 the display vector. (Bug#11417)
c8fb9dc6
EZ
1354 (pos_visible_p): Don't report a position visible when move_it_to
1355 stopped at the last line of window, which happens to be scanned
1356 backwards by the bidi iteration. (Bug#11464)
ac268e67 1357
e18afed7 13582012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1359
1360 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1361 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1362 are on a TTY, and thus unable to display on the fringes.
1363 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1364 so we need to signal to the caller that this is a "replacing"
1365 display spec. This fixes display when the spec is invalid or we
1366 are on a TTY.
1367
e18afed7 13682012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1369
1370 * unexaix.c (make_hdr): Fix typo in prototype.
1371 This bug broke the build on AIX. Problem reported by Gilles Pion.
1372
9d0a235a
MA
13732012-05-14 Michael Albinus <michael.albinus@gmx.de>
1374
1375 * keyboard.c (kbd_buffer_get_event): Read special events also in
1376 batch mode. (Bug#11415)
1377
9e6b06ed
GM
13782012-05-12 Glenn Morris <rgm@gnu.org>
1379
1380 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1381
c1a1d7a3
EZ
13822012-05-12 Eli Zaretskii <eliz@gnu.org>
1383
1384 * lisp.mk (lisp): Add newcomment.elc.
1385
3fe7cdc8
GM
13862012-05-12 Glenn Morris <rgm@gnu.org>
1387
1388 * Makefile.in (MKDIR_P): New, set by configure.
1389 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1390
53f7d2c0
PE
13912012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 Remove unused function hourglass_started.
1394 * dispextern.h (hourglass_started):
1395 * w32fns.c (hourglass_started):
1396 * xdisp.c (hourglass_started): Remove.
1397
75aafb17
JB
13982012-05-10 Juanma Barranquero <lekktu@gmail.com>
1399
1400 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1401 Update dependencies.
1402
12959e8e
PE
14032012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1404
97107e2e
PE
1405 * xgselect.c (xg_select): Put maxfds+1 into a var.
1406 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1407
12959e8e
PE
1408 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1409
836d29b3
DA
14102012-05-10 Dave Abrahams <dave@boostpro.com>
1411
1412 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1413 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1414
5cb67954
MA
14152012-05-09 Michael Albinus <michael.albinus@gmx.de>
1416
1417 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1418 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1419 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1420 Initialize xd_registered_buses.
1421
3478ec45
PE
14222012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1423
b263a6b0
PE
1424 Untag more efficiently if USE_LSB_TAG.
1425 This is based on a proposal by YAMAMOTO Mitsuharu in
1426 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1427 For an admittedly artificial (nth 8000 longlist) benchmark on
1428 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1429 Emacs's overall text size by 1%.
1430 * lisp.h (XUNTAG): New macro.
1431 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1432 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1433 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1434 * eval.c (Fautoload):
1435 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1436 * frame.h (XFRAME): Use XUNTAG.
1437
3478ec45
PE
1438 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1439 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1440 Remove unportable assumptions about print widths of types like
1441 dbus_uint32_t.
1442 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1443 intptr_t when converting between pointer and integer, to avoid GCC
1444 warnings about wrong width.
1445
666b903b 14462012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1447
1448 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1449 stack for each reader_thread, instead of defaulting to 8MB
1450 determined by the linker. This avoids failures in creating
1451 subprocesses on Windows 7, see the discussion in this thread:
1452 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1453
b120cc17
JC
14542012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1455
1456 Fix up display of the *Minibuf-0* buffer in the mini window.
1457 * keyboard.c (read_char): Don't clear the echo area if there's no
1458 message to clear.
1459 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1460 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1461
9a4b36f8
MA
14622012-05-07 Michael Albinus <michael.albinus@gmx.de>
1463
1464 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1465 batch mode.
1466
e5f9458f
CY
14672012-05-06 Chong Yidong <cyd@gnu.org>
1468
1469 * lisp.mk (lisp): Update.
1470
eceeb5fc 14712012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1472
1473 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1474
71873e2b
SM
14752012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1476
1477 * data.c (PUT_ERROR): New macro.
1478 (syms_of_data): Use it. Add new error type `user-error'.
1479 * undo.c (user_error): New function.
1480 (Fprimitive_undo): Use it.
1481 * print.c (print_error_message): Adjust print style for `user-error'.
1482 * keyboard.c (user_error): New function.
1483 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1484
ab0fa4e4
PE
14852012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 Do not limit current-time-string to years 1000..9999.
1488 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1489 (Fcurrent_time_string): Support any year that is supported by the
1490 underlying localtime representation. Don't use asctime, as it
1491 has undefined behavior for years outside the range -999..9999.
1492
7ed806a7
PE
14932012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 Fix race conditions involving setenv, gmtime, localtime, asctime.
1496 Without this fix, interrupts could mess up code that uses these
1497 nonreentrant functions, since setting TZ invalidates existing
1498 tm_zone or tzname values, and since most of these functions return
1499 pointers to static storage.
1500 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1501 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1502 Grow the critical sections to include not just invoking
1503 localtime/gmtime, but also accessing these functions' results
1504 including their tm_zone values if any, and any related TZ setting.
1505 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1506 so that the struct tm is saved in the critical section.
1507 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1508 motivated by the fact that memory allocation needs to be outside
1509 the critical section.
1510
0c16dfed
DA
15112012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1512
1513 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1514 with RESET_INTERVAL.
1515
1516 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1517 Remove duplicated buffer name initialization.
1518
3f83ace8
JM
15192012-05-02 Jim Meyering <jim@meyering.net>
1520
1521 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1522
c7b8541e
JM
1523 * xfns.c (x_window): Use xstrdup (Bug#11375).
1524
90207a15 15252012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1526
1527 * xdisp.c (pos_visible_p): If already at a newline from the
1528 display string before the 'while' loop, don't walk back the glyphs
1529 from it3.glyph_row. Solves assertion violation when the display
1530 string begins with a newline (egg.el). (Bug#11367)
1531
b593d6a9
AH
15322012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1533
1534 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1535 Move to simple.el.
1536
4737362e
GM
15372012-05-01 Glenn Morris <rgm@gnu.org>
1538
99cf43f9
GM
1539 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1540 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1541 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1542 All were removed before 23.1.
1543
9311dcff
GM
1544 * dispnew.c: Remove HAVE_LIBNCURSES test;
1545 it is always true on relevant platforms.
1546
4d5c6349
GM
1547 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1548 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1549
4737362e
GM
1550 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1551
74dd3a6b
AS
15522012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1553
1554 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1555 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1556 Remove.
1557
13c379ee
PE
15582012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 Do not avoid creating empty evaporating overlays (Bug#9642).
1561 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1562 That is, do not delete an evaporating overlay if it becomes
1563 empty after its bounds are adjusted to fit within its buffer.
1564 This fix caused other problems, and I'm reverting it until we get
1565 to the bottom of them.
1566
a8e7d6d7 15672012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1568
1569 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1570
a8e7d6d7 15712012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1572
1573 * xdisp.c (pos_visible_p): If the window start position is beyond
1574 ZV, start the display from buffer beginning. Prevents assertion
1575 violation in init_iterator when the minibuffer window is scrolled
1576 via the scroll bar.
1577
1578 * window.c (window_scroll_pixel_based): Likewise.
1579
a8e7d6d7 15802012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1581
1582 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1583
a8e7d6d7 15842012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1585
1586 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1587 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1588
a8e7d6d7 15892012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1590
b593d6a9
AH
1591 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1592 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1593
1c6900d9
EZ
15942012-04-26 Eli Zaretskii <eliz@gnu.org>
1595
4c3fa1d9
EZ
1596 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1597 display element, check also the underlying string or buffer
1598 character. (Bug#11341)
1599
1c6900d9
EZ
1600 * w32menu.c: Include w32heap.h.
1601 (add_menu_item): If the call to AppendMenuW (via
1602 unicode_append_menu) fails, disable Unicode menus only if we are
1603 running on Windows 9X/Me.
1604
42bf8205
AS
16052012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1606
1607 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1608 (xgetint): Add missing shift for LSB tags.
1609
b1bac16e
MR
16102012-04-24 Martin Rudalics <rudalics@gmx.at>
1611
1612 * keyboard.c (read_char): Don't wipe echo area for select window
1613 events: These might get delayed via `mouse-autoselect-window'
1614 (Bug#11304).
1615
d69621cc
JB
16162012-04-24 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1619 manipulation of :loaded-from data.
1620
02fd101b
JB
16212012-04-23 Juanma Barranquero <lekktu@gmail.com>
1622
1623 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1624 now a cons (bug#11311).
1625
888bec30
PE
16262012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1627
89a438bd
PE
1628 Do not create empty overlays with the evaporate property (Bug#9642).
1629 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1630 if it becomes empty after its bounds are adjusted to fit within
1631 its buffer. Without this fix, in a nonempty buffer (let ((o
1632 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1633 yields an empty overlay that has the evaporate property, which is
1634 not supposed to happen.
1635
1068fe4d
PE
1636 Fix minor GTK3 problems found by static checking.
1637 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1638 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1639 (struct _EmacsFixedClass, emacs_fixed_get_type):
1640 Move decls here from emacsgtkfixed.h, since they needn't be public.
1641 (emacs_fixed_get_type): Now static.
1642 (emacs_fixed_class_init): Omit unused local.
1643 (emacs_fixed_child_type): Remove; unused.
1644 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1645 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1646 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1647 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1648 (EMACS_FIXED_GET_CLASS): Remove; unused.
1649 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1650
888bec30
PE
1651 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1652 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1653
de85e130
PE
16542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1655
d0baac98 1656 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1657 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1658 (__malloc_size_t, __malloc_ptrdiff_t):
1659 Remove. All uses removed, replaced by the definiens if needed,
1660 since we can assume C89 or better now.
1661 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1662 (protect_malloc_state, align, get_contiguous_space)
1663 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1664 (malloc_atfork_handler_child, malloc_enable_thread)
1665 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1666 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1667 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1668 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1669 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1670 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1671 Define using prototypes, not old style.
1672 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1673 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1674 (align): Don't assume that signed integer overflow wraps around.
1675 Omit unused local var.
1676 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1677 (_free_internal_nolock, memalign, mallochook, reallochook):
1678 Omit no-longer-needed casts.
1679 (valloc): Use getpagesize, not __getpagesize.
1680 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1681 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1682
de85e130
PE
1683 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1684
dcbf5805
MA
16852012-04-22 Michael Albinus <michael.albinus@gmx.de>
1686
1687 Move functions from C to Lisp. Make non-blocking method calls
1688 the default. Implement further D-Bus standard interfaces.
1689
1690 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1691 (QCdbus_request_name_allow_replacement)
1692 (QCdbus_request_name_replace_existing)
1693 (QCdbus_request_name_do_not_queue)
1694 (QCdbus_request_name_reply_primary_owner)
1695 (QCdbus_request_name_reply_in_queue)
1696 (QCdbus_request_name_reply_exists)
1697 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1698 (QCdbus_registered_serial, QCdbus_registered_method)
1699 (QCdbus_registered_signal): New Lisp objects.
1700 (XD_DEBUG_MESSAGE): Use sizeof.
1701 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1702 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1703 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1704 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1705 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1706 (xd_signature, xd_append_arg): Allow float for integer types.
1707 (xd_get_connection_references): New function.
b593d6a9
AH
1708 (xd_get_connection_address): Rename from xd_initialize.
1709 Return cached address.
dcbf5805
MA
1710 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1711 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1712 level.
1713 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1714 Return number of refcounts.
dcbf5805
MA
1715 (Fdbus_get_unique_name): Make stronger parameter check.
1716 (Fdbus_message_internal): New defun.
1717 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1718 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1719 (Fdbus_send_signal, Fdbus_register_service)
1720 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1721 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1722 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1723 (Vdbus_compiled_version, Vdbus_runtime_version)
1724 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1725 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1726 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1727 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1728 Adapt docstring.
dcbf5805 1729
52828e02
PE
17302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1731
da05bc4c
PE
1732 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1733 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1734 Do not assume ptrdiff_t is the same width as 'int'.
1735
52828e02
PE
1736 * alloc.c: Handle unusual debugging option combinations.
1737 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1738 since the two debugging options are incompatible.
1739 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1740 is defined.
1741 (mem_init, mem_insert, mem_insert_fixup):
1742 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1743 (NEED_MEM_INSERT): Remove; no longer needed.
1744
f01769f9
LL
17452012-04-22 Leo Liu <sdl.web@gmail.com>
1746
1747 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1748
5790543d
PE
17492012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * sysdep.c [__FreeBSD__]: Minor cleanups.
1752 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1753 Use Emacs indenting style more consistently. Avoid some casts.
1754 Use 'double' consistently rather than mixing 'float' and 'double'.
1755
b91b7e4d
EW
17562012-04-21 Eduard Wiebe <usenet@pusto.de>
1757
b593d6a9
AH
1758 * sysdep.c (list_system_processes, system_process_attributes):
1759 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1760
6114eb15
AS
17612012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1762
1763 * lisp.mk (lisp): Update.
1764
2f38dff7
PE
17652012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1768 It is never used otherwise.
1769
4ae29f89
SM
17702012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1771
1772 * print.c (print_preprocess): Only check print_depth if print-circle
1773 is nil.
1774 (print_object): Check for cycles even when print-circle is nil and
1775 print-gensym is t, but only check print_depth if print-circle is nil.
1776
f30d612a
CY
17772012-04-20 Chong Yidong <cyd@gnu.org>
1778
1779 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1780 set the status to "failed" and ensure that sentinel is run.
1781
c07a4c0b 17822012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1783
1784 * process.c (Fset_process_inherit_coding_system_flag)
1785 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1786 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1787
c07a4c0b 17882012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1789
1790 * xdisp.c (string_buffer_position_lim): Limit starting position to
1791 BEGV.
1792 (set_cursor_from_row): If called for a mode-line or header-line
1793 row, return zero immediately.
1794 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1795 farther than the first row after the header line, if any.
1796 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1797 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1798
c07a4c0b 17992012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1800
4ae29f89
SM
1801 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1802 (bug#11238).
ad3a2b41 1803
c07a4c0b 18042012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 18052012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1806
1807 configure: new option --enable-gcc-warnings (Bug#11207)
1808 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1809 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1810 (ALL_CFLAGS): Use new macros rather than old.
1811 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1812 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1813 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1814 -Wunused-result, -Wunused-variable. This should go away once
1815 the Emacs and Gnulib regex code is merged.
1816 (xmalloc, xrealloc): Now static.
1817
aba027e8
PE
18182012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 * dired.c (Fsystem_groups): Remove unused local.
1821
e5a36063
GM
18222012-04-17 Glenn Morris <rgm@gnu.org>
1823
1824 * dired.c (Fsystem_users): Doc fix.
1825
316411f0
DA
18262012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1827
1828 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1829 (syms_of_dired): Add them.
1830
9426aba4
PE
18312012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1832
b62a57be
PE
1833 Fix minor alloc.c problems found by static checking.
1834 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1835 New extern decls, to avoid calling undeclared functions.
1836 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1837 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1838 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1839 (NEED_MEM_INSERT): New macro.
1840 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1841 Remove one incorrect comment and fix another.
b62a57be 1842
3539f31f
PE
1843 Fix minor ralloc.c problems found by static checking.
1844 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1845 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1846 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1847 (r_alloc_sbrk): Now static.
1848
a041960a
PE
1849 Improve ralloc.c interface checking.
1850 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1851 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1852 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1853 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1854 [REL_ALLOC]: ... to here, to check interface.
1855 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1856 Remove decls. This fixes an "It stinks!".
1857
9426aba4
PE
1858 * alloc.c (which_symbols): Fix alignment issue / type clash.
1859
d55c12ed
AS
18602012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1861
1862 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1863 (struct Lisp_Misc_Any): Likewise.
1864 (struct Lisp_Free): Likewise.
1865 * alloc.c (union aligned_Lisp_Symbol): Define.
1866 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1867 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1868 (union aligned_Lisp_Misc): Define.
1869 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1870 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1871 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1872
b948ce8b
PE
18732012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1876 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1877 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1878 * s/netbsd.h, s/sol2-6.h:
1879 Remove definition of GC_MARK_STACK, since the default now works.
1880 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1881 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1882 no longer the default.
1883 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1884
35dc09a1 18852012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1886
35dc09a1
GM
1887 * lread.c (lisp_file_lexically_bound_p):
1888 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1889
35dc09a1
GM
18902012-04-14 Eli Zaretskii <eliz@gnu.org>
1891
1892 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1893 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1894
18952012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1896
1897 * nsterm.m (constrainFrameRect): Always constrain when there is only
1898 one screen (Bug#10962).
1899
bcd86815
KB
19002012-04-13 Ken Brown <kbrown@cornell.edu>
1901
1902 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1903
c25df26e
RT
19042012-04-13 Reuben Thomas <rrt@sc3d.org>
1905
1906 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1907
0fc59f1e
DC
19082012-04-11 Daniel Colascione <dancol@dancol.org>
1909
1910 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1911 against is gone. It's better to use vfork now so that when Cygwin
1912 gains a new, working vfork, we use it automatically (bug#10398).
1913
de8c03dc
SM
19142012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1915
1916 * window.c (save_window_save): Obey window-point-insertion-type.
1917
2f097256
GM
19182012-04-11 Glenn Morris <rgm@gnu.org>
1919
1920 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1921
453b951e
SM
19222012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1923
1924 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1925
75f1671a 19262012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1927
1928 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1929 (force_quit_count): New var.
1930 (handle_interrupt): Use it.
1931
2a8ce227
JB
19322012-04-10 Juanma Barranquero <lekktu@gmail.com>
1933
1934 * w32.c (w32_delayed_load): Record the full path of the library
1935 being loaded (bug#10424).
1936
935396c0
GM
19372012-04-09 Glenn Morris <rgm@gnu.org>
1938
05920a43
GM
1939 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1940 not just in the obarray, before snarfing them. (Bug#11036)
1941
935396c0
GM
1942 * Makefile.in ($(leimdir)/leim-list.el):
1943 Pass EMACS rather than BUILT_EMACS.
1944
a18ecafa
TZ
19452012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1946
1947 * process.c (make_process):
1948 * process.h: Add integer `gnutls_handshakes_tried' member to
1949 process struct.
1950
6bbef4e5
JC
1951 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1952 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1953
1954 * gnutls.c (gnutls_log_function2i): Convenience log function.
1955 (emacs_gnutls_read): Use new log functions,
1956 `gnutls_handshakes_tried' process member, and
1957 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1958 attempts per process (connection).
1959
b4d3bc10
CY
19602012-04-09 Chong Yidong <cyd@gnu.org>
1961
1962 * eval.c (Fuser_variable_p, user_variable_p_eh)
1963 (lisp_indirect_variable): Functions deleted.
1964 (Fdefvar): Caller changed.
1965
1966 * callint.c (Finteractive, Fcall_interactively):
1967 * minibuf.c (Fread_variable): Callers changed.
1968
70f4d973
EZ
19692012-04-09 Eli Zaretskii <eliz@gnu.org>
1970
1971 * xdisp.c (set_cursor_from_row): If the display string appears in
1972 the buffer at position that is closer to point than the position
1973 after the display string, display the cursor on the first glyph of
1974 the display string. Fixes cursor display when a 'display' text
1975 property immediately follows invisible text. (Bug#11094)
1976
cb3c2e3e
PE
19772012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 composite.c: use 'double' consistently
1980 * composite.c (get_composition_id): Use 'double' consistently
1981 instead of converting 'float' to 'double' and vice versa; this is
1982 easier to understand and avoids a GCC warning.
1983
fd06db5d
GM
19842012-04-09 Glenn Morris <rgm@gnu.org>
1985
50fe702a
GM
1986 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1987 preparation for dumping it with emacs. (Bug#4789)
1988 (leimdir): New variable.
1989 ($(leimdir)/leim-list.el): New rule.
1990 (emacs$(EXEEXT)): Depend on leim-list.el.
1991
fd06db5d
GM
1992 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1993 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1994 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1995
55c131ee
AS
19962012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1997
1998 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1999 proper alignment.
2000
9209588f
JB
20012012-04-07 Juanma Barranquero <lekktu@gmail.com>
2002
2003 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2004 Remove unused local variable.
2005
e3fb2efb
PE
20062012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2007
2008 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2009 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2010 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2011 objects, as mark_maybe_pointer will catch them otherwise.
2012 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2013 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2014
b5385551
PE
20152012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2016
2017 Fix typo that broke non-Windows builds.
2018 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2019
9078ead6
EZ
20202012-04-07 Eli Zaretskii <eliz@gnu.org>
2021
2022 Support building on MS-Windows with libxml2.
2023
2024 * makefile.w32-in (OBJ2): Add xml.$(O).
2025 (GLOBAL_SOURCES): Add xml.c.
2026 ($(BLD)/xml.$(O)): New dependency list.
2027
2028 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2029 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2030 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2031 [!WINDOWSNT]: New macros.
2032 (init_libxml2_functions, libxml2_loaded_p): New functions.
2033 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2034 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2035 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2036 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2037 linked in).
6bbef4e5
JC
2038 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2039 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2040 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2041
2042 * emacs.c: Don't include libxml/parser.h.
2043 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2044 xmlCleanupParser directly.
2045
2046 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2047
3811fdf3
EZ
20482012-04-07 Eli Zaretskii <eliz@gnu.org>
2049
2050 * indent.c (Fvertical_motion): If there is a display string at
2051 point, use it.vpos to compute how many lines to backtrack after
2052 move_it_to point. (Bug#11133)
2053
2f8e16b2
EZ
20542012-04-06 Eli Zaretskii <eliz@gnu.org>
2055
2056 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2057 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2058 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2059 macros related to unification of CJK characters. For the details,
2060 see the discussion following the message here:
2061 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2062
3d439cd1
CY
20632012-04-04 Chong Yidong <cyd@gnu.org>
2064
2065 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2066
8bc53d00
EZ
20672012-04-01 Eli Zaretskii <eliz@gnu.org>
2068
2069 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2070 instead of alloca. (Bug#11138)
2071
3b0512a3
AS
20722012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2073
2074 * w32menu.c (is_simple_dialog): Properly check lisp types.
2075 (Bug#11141)
2076
8427ddd2
EZ
20772012-03-31 Eli Zaretskii <eliz@gnu.org>
2078
979022ef
EZ
2079 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2080 position we get to after a call to move_it_to fails the
2081 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2082 only if we wind up in a string from display property. (Bug#11063)
2083
a6b1c7cc
EZ
2084 * window.c (Fdelete_other_windows_internal): Invalidate the row
2085 and column information about mouse highlight, so that redisplay
2086 restores it after reallocating the glyph matrices. (Bug#7464)
2087
8427ddd2
EZ
2088 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2089 string comes from a `display' text property, use the buffer
2090 position of that property as if we actually saw that position in
2091 the row's glyphs.
697ba24b
EZ
2092 (move_it_by_lines): Remove the assertion that
2093 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2094 violated when there's a before-string at the beginning of a line.
2095 (Bug#11063)
8427ddd2 2096
65a0a738
EZ
20972012-03-30 Eli Zaretskii <eliz@gnu.org>
2098
2099 * xdisp.c (append_space_for_newline): If the default face was
2100 remapped, use the remapped face for the appended newline.
2101 (extend_face_to_end_of_line): Use the remapped default face for
2102 extending the face to the end of the line.
2103 (display_line): Call extend_face_to_end_of_line when the default
2104 face was remapped. (Bug#11068)
2105
581355cc
EZ
21062012-03-29 Eli Zaretskii <eliz@gnu.org>
2107
2108 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2109
e8fc049f
SM
21102012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2111
2112 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2113
4fb9a543
GM
21142012-03-27 Glenn Morris <rgm@gnu.org>
2115
2116 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2117 Doc fixes.
2118
679910f1
KH
21192012-03-26 Kenichi Handa <handa@m17n.org>
2120
2121 * dispextern.h (struct glyph): Fix previous change. Change the
2122 bit length of glyphless.ch to 25 (Bug#11082).
2123
90d49b7f
CY
21242012-03-26 Chong Yidong <cyd@gnu.org>
2125
2126 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2127 (command_loop_1): Use it; inhibit selection update for
2128 handle-select-window too (Bug#8996).
2129
f514f6f0
FP
21302012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2131
e8fc049f 2132 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2133
bf43fa51
KH
21342012-03-25 Kenichi Handa <handa@m17n.org>
2135
2136 * dispextern.h (struct glyph): Change the bit length of
2137 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2138
8a0c01dd
EZ
21392012-03-24 Eli Zaretskii <eliz@gnu.org>
2140
2141 * s/ms-w32.h (tzname): Include time.h before redirecting to
2142 _tzname. Fixes the MSVC build. (Bug#9960)
2143
7d1c3a76
AS
21442012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2145
8ed79523
AS
2146 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2147 characters.
2148
7d1c3a76
AS
2149 * xterm.c (XTread_socket): Only modify handling_signal if
2150 !SYNC_INPUT. (Bug#11080)
2151
e99a9b8b
EZ
21522012-03-23 Eli Zaretskii <eliz@gnu.org>
2153
2154 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2155 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2156 when fetching a multibyte character consumes more bytes than
2157 CHAR_BYTES returns, due to unification of CJK characters in
2158 string_char. (Bug#11073)
2159
5063c0e1
TN
21602012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2161
2162 * process.c (wait_reading_process_output): Handle pty disconnect
2163 by refraining from sending oneself a SIGCHLD (bug#10933).
2164
9f851fbd
CY
21652012-03-22 Chong Yidong <cyd@gnu.org>
2166
2167 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2168
5063c0e1 2169 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2170 Mark string as coming from a prefix property.
2171 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2172 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2173
fb5b8aca
CY
21742012-03-21 Chong Yidong <cyd@gnu.org>
2175
2176 * xfaces.c (Vface_remapping_alist): Doc fix.
2177
62356a1b
EZ
21782012-03-20 Eli Zaretskii <eliz@gnu.org>
2179
2180 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2181 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2182 Doc fixes.
62356a1b 2183
025de85b
CY
21842012-03-20 Chong Yidong <cyd@gnu.org>
2185
2186 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2187 to reflect default non-nil value of redisplay-dont-pause.
2188
4827f94e
KH
21892012-03-19 Kenichi Handa <handa@m17n.org>
2190
2191 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2192 it fit in a valid range (Bug#11003).
2193
e50a24a2
EZ
21942012-03-18 Eli Zaretskii <eliz@gnu.org>
2195
2196 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2197 that is not from display property, accept the row as a "cursor
2198 row" if one of the string's character has a non-nil `cursor'
2199 property. Fixes cursor positioning when there are newlines in
2200 overlay strings, e.g. in icomplete.el. (Bug#11035)
2201
9af5ed87
PE
22022012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2205
d1f55f16
CY
22062012-03-12 Chong Yidong <cyd@gnu.org>
2207
2208 * eval.c (inhibit_lisp_code): Rename from
2209 inhibit_window_configuration_change_hook; move from window.c.
2210
2211 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2212 * window.c (run_window_configuration_change_hook)
2213 (syms_of_window): Callers changed.
2214
66c5eebd
CY
22152012-03-11 Chong Yidong <cyd@gnu.org>
2216
413df973
CY
2217 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2218
66c5eebd
CY
2219 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2220
1de11f56
CY
22212012-03-10 Chong Yidong <cyd@gnu.org>
2222
2223 * frame.c (other_visible_frames): Don't assume the selected frame
2224 is visible (Bug#10955).
2225
cae07000
SM
22262012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2227
2228 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2229
89c94350
JD
22302012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2231
2232 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2233 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2234 zero (Bug#10954).
2235
999dd333
GM
22362012-03-03 Glenn Morris <rgm@gnu.org>
2237
01a6dcc8 2238 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2239
de0100f2
EZ
22402012-03-02 Eli Zaretskii <eliz@gnu.org>
2241
2242 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2243 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2244 (redisplay_window, next_element_from_string): Fix typos in
2245 comments.
3e441275
EZ
2246 (redisplay_window): Pass to move_it_vertically the margin in
2247 pixels, not in screen lines.
de0100f2 2248
96a72ee9
GM
22492012-03-02 Glenn Morris <rgm@gnu.org>
2250
2251 * buffer.c (buffer-list-update-hook): Doc fix.
2252
312508d7
EZ
22532012-02-29 Eli Zaretskii <eliz@gnu.org>
2254
2255 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2256 push_it before setting up the iterator for the first overlay
2257 string, even if we have an empty string loaded.
2258 (next_overlay_string): If there's an empty string on the iterator
2259 stack, pop the stack. (Bug#10903)
2260
27f3c637
PE
22612012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2262
2263 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2264 Suggested by Stefan Monnier in
2265 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2266 * alloc.c (widen_to_Lisp_Object): New static function.
2267 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2268 and widening them to Lisp_Objects. This would work even if
2269 USE_LSB_TAG is defined and wide integers are used, which might
2270 happen in a future version of Emacs.
2271
3c9dfce6
CY
22722012-02-25 Chong Yidong <cyd@gnu.org>
2273
fa74b241
CY
2274 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2275 Doc fix.
2276
3c9dfce6
CY
2277 * xselect.c (Fx_selection_exists_p): Doc fix.
2278 (x_clipboard_manager_save_all): Print an informative message
2279 before saving to clipboard manager.
2280
9486df08
CY
22812012-02-24 Chong Yidong <cyd@gnu.org>
2282
2283 * keyboard.c (process_special_events): Handle all X selection
2284 requests in kbd_buffer, not just the next one (Bug#8869).
2285
f01d3321
CY
22862012-02-23 Chong Yidong <cyd@gnu.org>
2287
2288 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2289 call when setting menu-bar-lines and tool-bar-lines parameters.
2290 (unwind_create_frame_1): New helper function.
2291
2292 * window.c (inhibit_window_configuration_change_hook): New var.
2293 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2294 (syms_of_window): Initialize it.
f01d3321 2295
86b847b6
CY
22962012-02-22 Chong Yidong <cyd@gnu.org>
2297
2298 * xterm.c (x_draw_image_relief): Add missing type check for
2299 Vtool_bar_button_margin (Bug#10743).
2300
a59225b1
CY
23012012-02-21 Chong Yidong <cyd@gnu.org>
2302
2303 * fileio.c (Vfile_name_handler_alist): Doc fix.
2304
2305 * buffer.c (Fget_file_buffer): Protect against invalid file
2306 handler return value.
2307
310f5bd4
PE
23082012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2309
cb3a28cc
PE
2310 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2311 when computing $valmask.
2312
310f5bd4
PE
2313 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2314 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2315 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2316 It's useless in that case, and it can cause problems on hosts
2317 that allocate halves of EMACS_INT values separately.
2318 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2319 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2320 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2321 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2322 it avoids undefined behavior on hosts where shifting right by more
2323 than the word width has undefined behavior.
2324
2375c96a
CY
23252012-02-19 Chong Yidong <cyd@gnu.org>
2326
2327 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2328 (Funhandled_file_name_directory, Ffile_name_as_directory)
2329 (Fdirectory_file_name, Fexpand_file_name)
2330 (Fsubstitute_in_file_name): Protect against invalid file handler
2331 return values (Bug#10845).
2332
3eb49e71
EZ
23332012-02-18 Eli Zaretskii <eliz@gnu.org>
2334
2335 * .gdbinit (pitx): Fix incorrect references to fields of the
2336 iterator stack.
2337
7b926f3f
CY
23382012-02-17 Chong Yidong <cyd@gnu.org>
2339
2340 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2341
11273115
PE
23422012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2343
2344 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2345 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2346
c3a70e2b
CY
23472012-02-15 Chong Yidong <cyd@gnu.org>
2348
2349 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2350 marked as special. Also, starting docstrings with * is obsolete.
2351
0ca43699
AS
23522012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2353
2354 * gnutls.c (emacs_gnutls_write): Fix last change.
2355
2e8f3c56
LI
23562012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2357
2358 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2359 send_process.
2360
af70074f
SM
23612012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2362
2363 * keymap.c (Fsingle_key_description): Handle char ranges.
2364
95986d52
CY
23652012-02-12 Chong Yidong <cyd@gnu.org>
2366
afd83bd1
CY
2367 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2368 as that creates a dangerous corner case.
2369
95986d52
CY
2370 * window.c (Fdelete_window_internal): Invalidate the mouse
2371 highlight (Bug#9904).
2372
bd7da63e
GM
23732012-02-12 Glenn Morris <rgm@gnu.org>
2374
2375 * xselect.c (Fx_own_selection_internal)
2376 (Fx_get_selection_internal, Fx_disown_selection_internal)
2377 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2378 * nsselect.m (Fx_own_selection_internal)
2379 (Fx_disown_selection_internal, Fx_selection_exists_p)
2380 (Fx_selection_owner_p, Fx_get_selection_internal):
2381 Sync docs and argument specs with the xselect.c versions.
2382
77abcbc2
LI
23832012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2384
2385 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2386
90b671e2
EZ
23872012-02-11 Eli Zaretskii <eliz@gnu.org>
2388
1c0ca0b7
EZ
2389 * w32select.c (Fx_selection_exists_p): Sync doc string and
2390 argument list with xselect.c. (Bug#10783)
2391
2392 * w16select.c (Fx_selection_exists_p): Sync doc string and
2393 argument list with xselect.c. (Bug#10783)
90b671e2 2394
49241268
GM
23952012-02-10 Glenn Morris <rgm@gnu.org>
2396
2397 * fns.c (Fsecure_hash): Doc fix.
2398
f998bbe7 23992012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2400
2401 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2402
0992bd9c
CY
24032012-02-07 Chong Yidong <cyd@gnu.org>
2404
2405 * buffer.c (Fbuffer_local_variables)
2406 (buffer_lisp_local_variables): Handle unbound vars correctly;
2407 don't let Qunbound leak into Lisp.
2408
af008560
GM
24092012-02-07 Glenn Morris <rgm@gnu.org>
2410
dd605cc4
GM
2411 * image.c (Fimagemagick_types): Doc fix.
2412
af008560
GM
2413 * image.c (imagemagick-render-type): Change it from a lisp object
2414 to an integer. Move the doc here from the lisp manual.
2415 Treat all values not equal to 0 the same.
2416
1449fa1d
CY
24172012-02-06 Chong Yidong <cyd@gnu.org>
2418
2419 * doc.c (store_function_docstring): Avoid applying docstring of
2420 alias to base function (Bug#2603).
2421
3723ec07
AS
24222012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2423
2424 * .gdbinit (pp1, pv1): Remove redundant defines.
2425 (pr): Use pp.
2426
79c1cc1e
CY
24272012-02-04 Chong Yidong <cyd@gnu.org>
2428
2429 * nsterm.m: Declare a global (Bug#10694).
2430
d7f29f8e
EZ
24312012-02-04 Eli Zaretskii <eliz@gnu.org>
2432
cae07000
SM
2433 * w32.c (get_emacs_configuration_options):
2434 Include --enable-checking, if specified, in the return value.
d7f29f8e 2435
3b95a6f9
MR
24362012-02-04 Martin Rudalics <rudalics@gmx.at>
2437
2438 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2439 after rounding frame sizes. (Bug#9723)
2440
d6fa96a6
EZ
24412012-02-04 Eli Zaretskii <eliz@gnu.org>
2442
2443 * keyboard.c (adjust_point_for_property): Don't position point
2444 before BEGV. (Bug#10696)
2445
df0b2940
PE
24462012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2447
2448 Handle overflow when computing char display width (Bug#9496).
2449 * character.c (char_width): Return EMACS_INT, not int.
2450 (char_width, c_string_width): Check for overflow when
2451 computing the width; this is possible now that individual
2452 characters can have unbounded width. Problem introduced
2453 by merge from Emacs 23 on 2012-01-19.
2454
6bee44d6
MA
24552012-02-02 Michael Albinus <michael.albinus@gmx.de>
2456
2457 * dbusbind.c (Fdbus_register_method): Mention the return value
2458 :ignore in the docstring.
2459
44f92739
GM
24602012-02-02 Glenn Morris <rgm@gnu.org>
2461
1b9f60cc
GM
2462 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2463
44f92739
GM
2464 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2465 Unconditionally set to t. (Bug#10673)
2466 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2467 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2468 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2469
c5d3843c
KH
24702012-02-02 Kenichi Handa <handa@m17n.org>
2471
2472 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2473 0, do not call append_composite_glyph.
2474
159462d4 24752012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2476
2477 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2478 NULL (Bug#6988).
2479 (x_produce_glyphs): If the component of a composition is a null
2480 string, set it->pixel_width to 1 to avoid zero-width glyph.
2481
78cef877
EZ
24822012-02-01 Eli Zaretskii <eliz@gnu.org>
2483
2484 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2485 first 2 arguments are identical. This makes inserting large
2486 output from a subprocess an order of magnitude faster on
2487 MS-Windows, where all sbrk'ed memory is always contiguous.
2488
97897668
GM
24892012-01-31 Glenn Morris <rgm@gnu.org>
2490
2491 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2492 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2493 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2494
31fd3586
GM
24952012-01-29 Glenn Morris <rgm@gnu.org>
2496
2497 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2498
0e24a8b2
CY
24992012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2500
2501 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2502
cc0adcb0
CY
25032012-01-28 Chong Yidong <cyd@gnu.org>
2504
2505 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2506
acc28cb9
CY
25072012-01-26 Chong Yidong <cyd@gnu.org>
2508
9c69cfb7
CY
2509 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2510
acc28cb9
CY
2511 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2512 repeat counts (Bug#10507).
2513
48da7392
GM
25142012-01-26 Glenn Morris <rgm@gnu.org>
2515
2516 * lread.c (syms_of_lread): Doc fix.
2517
14af5f7f
CY
25182012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2519
2520 * coding.c (encode_designation_at_bol): Change return value to
2521 EMACS_INT.
2522
0b21c100
CY
25232012-01-25 Chong Yidong <cyd@gnu.org>
2524
2525 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2526
3c2907f7
CY
25272012-01-21 Chong Yidong <cyd@gnu.org>
2528
2529 * floatfns.c (Fcopysign): Make the second argument non-optional,
2530 since nil is not allowed anyway.
2531
959ad23f
AS
25322012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2533
2534 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2535 (send_process): Likewise.
2536
34a02f46
MR
25372012-01-19 Martin Rudalics <rudalics@gmx.at>
2538
2539 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2540 (Vwindow_persistent_parameters): Do not use Qstate.
2541 Rewrite doc-strings.
34a02f46 2542
1259009a 25432012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2544
2545 * character.c (char_width): New function.
70d4fdf6
GM
2546 (Fchar_width, c_string_width, lisp_string_width):
2547 Use char_width (Bug#9496).
25ed9e61 2548
6a6ee00d
MR
25492012-01-16 Martin Rudalics <rudalics@gmx.at>
2550
2551 * window.c (Vwindow_persistent_parameters): New variable.
2552 (Fset_window_configuration, save_window_save): Handle persistent
2553 window parameters.
2554
c85efaf7
EZ
25552012-01-14 Eli Zaretskii <eliz@gnu.org>
2556
2557 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2558 thrashing the stack of the thread. (Bug#9087)
2559
5944709e
PE
25602012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2561
2562 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2563
e71f5d99
EZ
25642012-01-11 Eli Zaretskii <eliz@gnu.org>
2565
2566 * xdisp.c (rows_from_pos_range): Handle the case where the
2567 highlight ends on a newline. (Bug#10464)
2568 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2569 he end column for display of highlight that ends on a newline
2570 before a R2L line.
2571
ce316182
GM
25722012-01-11 Glenn Morris <rgm@gnu.org>
2573
2574 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2575 from load-path also when installation-directory is nil. (Bug#10208)
2576
5b43da69
GM
25772012-01-10 Glenn Morris <rgm@gnu.org>
2578
74cc8ff9
GM
2579 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2580
7d8d6e4e
GM
2581 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2582 Update template values to be closer to their typical values these days.
5b43da69 2583
a0db8d43
EZ
25842012-01-09 Eli Zaretskii <eliz@gnu.org>
2585
2586 * xdisp.c (rows_from_pos_range): Accept additional argument
2587 DISP_STRING, and accept any glyph in a row whose object is that
2588 string as eligible for mouse highlight. Fixes mouse highlight of
2589 display strings from overlays. (Bug#10464)
2590
9a0115ab 25912012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2592
b9110d6a 2593 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2594 * fileio.c (auto_saving_dir_umask): New static var.
2595 (Fmake_directory_internal): Use it.
2596 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2597 creating the directory. The old code temporarily assigns
2598 too-generous permissions to the directory.
2599 (do_auto_save_eh): Clear it.
b9110d6a 2600 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2601 that the var is always cleared.
2602
6c1bd3f3
EZ
26032012-01-07 Eli Zaretskii <eliz@gnu.org>
2604
2605 * search.c (scan_buffer): Pass character positions to
2606 know_region_cache, not byte positions. (Bug#6540)
2607
069d2b50
L
26082012-01-07 LynX <_LynX@bk.ru> (tiny change)
2609
2610 * w32.c (sys_rename): Report EXDEV when rename of a directory
2611 fails because the target is on another logical disk. (Bug#10284)
2612
75bf0d33
DB
26132012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2614
2615 * xterm.c (x_embed_request_focus): New function.
2616
2617 * xterm.h: Add prototype.
2618
2619 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2620
1c6e5a32
GM
26212012-01-05 Glenn Morris <rgm@gnu.org>
2622
2623 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2624
651e947e
EZ
26252012-01-01 Eli Zaretskii <eliz@gnu.org>
2626
2627 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2628 Load gnutls_transport_set_lowat only if GnuTLS version is below
2629 2.11.1.
2630 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2631 GnuTLS versions below 2.11.1.
2632
3778cdd8
AL
26332011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2634
2635 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2636 to the doc string advising against its use for altering the way
2637 windows are scrolled.
2638
0e5317f7
KH
26392011-12-28 Kenichi Handa <handa@m17n.org>
2640
2641 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2642 coding-system ASCII compatible only when it does not produce BOM
2643 on encoding (Bug#10383).
2644
93d5ca1f
JD
26452011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2646
2647 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2648 can scroll.
2649 (create_and_show_popup_menu): Always use menu_position_func for
2650 Gtk3 (Bug#10361).
2651
ca22b785
AS
26522011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2653
2654 * callint.c (Fcall_interactively): Don't truncate prompt string.
2655
d048e1e6
EZ
26562011-12-23 Eli Zaretskii <eliz@gnu.org>
2657
2658 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2659 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2660 resumed from there (after widening). (Bug#10360)
d048e1e6 2661
5ccaba1f
JD
26622011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2663
2664 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2665
204ee57f
JD
26662011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2667
b81d40f0
JB
2668 * nsterm.m (x_free_frame_resources):
2669 Release f->output_data.ns->miniimage.
204ee57f
JD
2670 (ns_index_color): Fix indentation. Do not retain
2671 color_table->colors[i].
2672
2673 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2674 before returning.
2675
2676 * nsfns.m (x_set_background_color): Assign return value from
2677 ns_index_color to face-background instead of NSColor*.
2678 (ns_implicitly_set_icon_type): Fix indentation.
2679 Change assignment in for loop to comparison.
2680
2681 * emacs.c (ns_pool): New variable.
2682 (main): Assign ns_pool.
2683 (Fkill_emacs): Call ns_release_autorelease_pool.
2684
2685 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2686 autorelease fdesc, release fdAttrs and tdict.
2687 (ns_get_covering_families): Release charset.
2688 (ns_findfonts): Release NSFontDescriptor created with new.
2689 (ns_uni_to_glyphs): Fix indentation.
2690 (setString): Release attrStr before assigning new value.
2691
c803b2b7
JD
26922011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2693
678f4426
JD
2694 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2695 and NS_IMPL_COCOA.
2696 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2697 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2698
cd394be1 26992011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2700
5fecd5fc
JD
2701 * nsterm.m (ns_term_init): Subscribe for notifications
2702 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2703 to method trackingNotification in EmacsMenu.
2704
2705 * nsmenu.m (trackingMenu): New variable.
3771cb17 2706 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2707 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2708 from Aquamacs (Bug#7030).
678f4426
JD
2709
27102011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2711
c803b2b7
JD
2712 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2713 (symbol_to_nsstring): Fix indentation.
2714 (ns_symbol_to_pb): New function.
cae07000
SM
2715 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2716 (Fns_rotate_cut_buffers_internal): Remove.
2717 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2718 Fns_store_cut_buffer_internal.
2719 (ns_get_foreign_selection, Fx_own_selection_internal)
2720 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2721 (Fns_get_selection_internal, Fns_store_selection_internal):
2722 Use ns_symbol_to_pb and check if return value is nil.
2723 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2724 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2725 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2726 renamed to Sns_store_selection_internal.
2727 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2728 and remove this function.
2729 (ns_handle_selection_clear): Remove, never used.
2730 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2731 here.
2732
e1b01a3a
KB
27332011-12-17 Ken Brown <kbrown@cornell.edu>
2734
2735 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2736 GID is unknown (Bug#10257).
2737
2adb6e85
PE
27382011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2741 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2742 which caused a build failure on GNU/Linux IA-64. This problem was
2743 introduced by my 2011-10-07 patch.
2744
d1d7b339
JL
27452011-12-15 Juri Linkov <juri@jurta.org>
2746
2747 * image.c (imagemagick_error): New function. (Bug#10112)
2748 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2749 Use `imagemagick_error' where ImageMagick functions return
2750 `MagickFalse'.
2751 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2752 proper order.
2753
100d5755
KH
27542011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2755
2756 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2757 fill background (Bug#8992).
2758
454592a6
MR
27592011-12-13 Martin Rudalics <rudalics@gmx.at>
2760
2761 * window.c (Vwindow_combination_resize)
2762 (Vwindow_combination_limit): Use t instead of non-nil in
2763 doc-strings.
61d4b438
MR
2764 (Vrecenter_redisplay): Add first sentence of doc-string on
2765 separate line.
53524d93 2766 (Frecenter): Fix doc-string typo.
454592a6 2767
3633e3aa
KH
27682011-12-11 Kenichi Handa <handa@m17n.org>
2769
2770 * coding.c (Funencodable_char_position): Pay attention to the
2771 buffer text relocation (Bug#9389).
2772
7b9d523a 27732011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2774
7b9d523a
JD
2775 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2776 gtk_init (Bug#10100).
2777
b73189c6
EZ
27782011-12-10 Eli Zaretskii <eliz@gnu.org>
2779
2780 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2781 IT->string is nil. (Bug#10263)
2782
f7dfe5d6
JD
27832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2784
83faebb4
JD
2785 * nsterm.h (x_free_frame_resources): Declare.
2786
f7dfe5d6
JD
2787 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2788 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2789
2790 * nsterm.h (ns_get_defaults_value): Declare.
2791
2792 * nsterm.m (ns_default): Call ns_get_defaults_value.
2793
7cd4e72c
EZ
27942011-12-09 Eli Zaretskii <eliz@gnu.org>
2795
2796 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2797 (Bug#10170)
2798
b34d7317
YM
27992011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2800
2801 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2802 that where the value of an _OBJC_* symbol points to is in the .bss
2803 section (Bug#10240).
2804
76470ad1
KH
28052011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2806
2807 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2808 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2809
745fff94
KH
28102011-12-08 Kenichi Handa <handa@m17n.org>
2811
2812 * ftfont.c (get_adstyle_property): Fix previous change
2813 (Bug#10233).
2814
6e44397c
JB
28152011-12-07 Juanma Barranquero <lekktu@gmail.com>
2816
2817 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2818 dirs from the default value of EMACSLOADPATH (bug#10208).
2819
7efa6272
GM
28202011-12-07 Glenn Morris <rgm@gnu.org>
2821
2822 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2823 installation and source directories as well. (Bug#10208)
2824
f6fc4d87
CY
28252011-12-06 Chong Yidong <cyd@gnu.org>
2826
2827 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2828
2bf26180
GM
28292011-12-06 Glenn Morris <rgm@gnu.org>
2830
2831 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2832 as an error, not just -1. (Bug#10217)
2833
3a6ad4f0
CY
28342011-12-05 Chong Yidong <cyd@gnu.org>
2835
2836 * keyboard.c (process_special_events): New function.
2837 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2838
75a3b399
PE
28392011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2840
2841 * coding.c (encode_designation_at_bol): Don't use uninitialized
2842 local variable (Bug#9318).
2843
c3c9e25e
KH
28442011-12-05 Kenichi Handa <handa@m17n.org>
2845
2846 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2847 return Qnil (Bug#8046, Bug#10193).
2848
5eb05ea3
KH
28492011-12-05 Kenichi Handa <handa@m17n.org>
2850
2851 * coding.c (encode_designation_at_bol): New args charbuf_end and
2852 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2853 (coding_set_source): Return how many bytes coding->source was
2854 relocated.
2855 (coding_set_destination): Return how many bytes
2856 coding->destination was relocated.
2857 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2858 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2859
28602011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2861
2862 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2863 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2864 macro (Bug#9318).
2865
28662011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2867
2868 The following changes are to fix Bug#9318.
2869
a79703f5 2870 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2871 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2872 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2873 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2874
7dbda6df
JB
28752011-12-05 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * lisp.h (process_quit_flag): Fix external declaration.
2878
6d5eb5b0
SM
28792011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2880
2881 Don't macro-inline non-performance-critical code.
2882 * eval.c (process_quit_flag): New function.
2883 * lisp.h (QUIT): Use it.
2884
a0c3fad0
JD
28852011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2886
2887 * nsfns.m (get_geometry_from_preferences): New function.
2888 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2889
6c07aac2
AS
28902011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2891
2892 * emacs.c (Qkill_emacs): Define.
2893 (syms_of_emacs): Initialize it.
2894 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2895 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2896 (quit_throw_to_read_char): Add parameter `from_signal'.
2897 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2898 * lisp.h (QUIT): Call Fkill_emacs if requested.
2899
c052ead4
JD
29002011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2901
2902 * widget.c (update_wm_hints): Return if wmshell is null.
2903 (widget_update_wm_size_hints): New function.
2904
2905 * widget.h (widget_update_wm_size_hints): Declare.
2906
2907 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2908 widget_update_wm_size_hints (Bug#10104).
2909
9e49252b
EZ
29102011-12-03 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2913 before a newline, prepare the bidi iterator for consuming the
2914 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2915 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2916
02b16839
JL
29172011-12-02 Juri Linkov <juri@jurta.org>
2918
2919 * search.c (Fword_search_regexp): New Lisp function created from
2920 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2921 (Fword_search_backward, Fword_search_forward)
2922 (Fword_search_backward_lax, Fword_search_forward_lax):
2923 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2924 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2925
0068070e
SM
29262011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2927
2928 * fileio.c (Finsert_file_contents): Move after-change-function call
2929 to before the "handled:" label, since all "goto handled" appear in
2930 cases where the *-change-functions have already been properly called
2931 (bug#10117).
2932
3360a3fc
AS
29332011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2934
2935 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2936 waiting for input. (Bug#10169)
2937
73d6c093
EZ
29382011-11-30 Eli Zaretskii <eliz@gnu.org>
2939
2940 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2941 verifies glyph row's hash code--we have just reallocated the
2942 glyphs, so their contents can be complete garbage. (Bug#10164)
2943
febe6bea
JB
29442011-11-30 Juanma Barranquero <lekktu@gmail.com>
2945
2946 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2947
801a4313
EZ
29482011-11-30 Eli Zaretskii <eliz@gnu.org>
2949
2950 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2951 attributes are tested _before_ calling verify_row_hash, to protect
2952 against GCC re-ordering of the tests. (Bug#10164)
2953
2b56b87e
JD
29542011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2955
2956 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2957
2958 * xterm.c (handle_one_xevent): Only set async_visible and friends
2959 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2960 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2961 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2962
dbf31225
PE
29632011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2964
2965 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2966 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2967 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2968 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2969 All uses changed to use GCPRO1 etc.
2970 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2971 Revert to old implementation (i.e., before 2011-03-11).
2972
1305621b
YM
29732011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2974
2975 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2976 of scroll runs so as to avoid assigning disabled bogus rows and
2977 unnecessary graphics copy operations.
2978
8c9afb46
EZ
29792011-11-27 Eli Zaretskii <eliz@gnu.org>
2980
2981 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2982 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2983 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2984 (malloc, free, realloc, calloc): Redirect to e_* only when
2985 compiling Emacs.
2986
2987 * lisp.h (GCTYPEBITS): Move before first use.
2988 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2989 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2990 this macro definition.
2991
2992 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2993 _MSC_VER.
2994
54e9e3bf
JD
29952011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2996
6d5eb5b0
SM
2997 * gtkutil.c (xg_create_frame_widgets):
2998 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2999 present with Gtk+ 2.0.
3000
83aca1cb
PE
30012011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 * fileio.c (Finsert_file_contents): Undo previous change; see
3004 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3005
5b76caa4
PE
30062011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3007
3008 Rename locals to avoid shadowing.
3009 * fileio.c (Finsert_file_contents):
3010 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3011 * process.c (wait_reading_process_output):
3012 Rename inner 'proc' to 'p' to avoid shadowing.
3013 Indent for consistency with usual Emacs style.
3014
8c535114
EZ
30152011-11-25 Eli Zaretskii <eliz@gnu.org>
3016
3017 * xdisp.c (redisplay_window): If cursor row is not fully visible
3018 after recentering, and scroll-conservatively is set to a large
3019 number, scroll window by a few more lines to make the cursor fully
3020 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3021 (start_display): Don't move to the next line if the display should
3022 start at a newline that is part of a display vector or an overlay
3023 string. (Bug#10119)
8c535114 3024
fa4fdb5c
JL
30252011-11-24 Juri Linkov <juri@jurta.org>
3026
3027 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3028 after the `MagickPingImage' call. (Bug#10112)
3029
90ec88df
CY
30302011-11-23 Chong Yidong <cyd@gnu.org>
3031
3032 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3033
56e2e794
MR
30342011-11-23 Martin Rudalics <rudalics@gmx.at>
3035
3036 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3037 making another buffer current. (Bug#10114)
3038
b6e64c41
GM
30392011-11-23 Glenn Morris <rgm@gnu.org>
3040
3041 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3042
6b21de18
CY
30432011-11-23 Chong Yidong <cyd@gnu.org>
3044
3045 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3046 using it (Bug#5984).
3047
b12cd789
EZ
30482011-11-22 Eli Zaretskii <eliz@gnu.org>
3049
3050 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3051 and header-lines, as they don't have one computed for them.
3052 (Bug#10098)
3053
3054 * .gdbinit (prow): Make displayed values more self-explaining.
3055 Add row's hash code.
3056
261b6fd4
LMI
30572011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3058
3059 * process.c (wait_reading_process_output): Fix asynchrounous
3060 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3061 (wait_reading_process_output): Add comment and URL.
261b6fd4 3062
e7cfd277
JD
30632011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3064
3065 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3066
a9b9b7f5
CY
30672011-11-21 Chong Yidong <cyd@gnu.org>
3068
3069 * window.c (Fnext_window, Fprevious_window): Doc fix.
3070
b0d15b4f
SM
30712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3072
3073 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3074
fe7a3057
JB
30752011-11-20 Juanma Barranquero <lekktu@gmail.com>
3076
3077 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3078
d2999b1a
MR
30792011-11-20 Martin Rudalics <rudalics@gmx.at>
3080
3081 * window.c (Fset_window_combination_limit): Rename argument
3082 STATUS to LIMIT.
3083 (Vwindow_combination_limit): Remove "status" from doc-string.
3084
d5ff9cd0
AS
30852011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3086
3087 * m/ibms390.h: Remove.
3088 * m/ibms390x.h: Don't include "ibms390.h".
3089
a5bb9bd3
SM
30902011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3091
3092 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3093 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3094
cd1181db
JB
30952011-11-20 Juanma Barranquero <lekktu@gmail.com>
3096
3097 * casetab.c (Fset_case_table):
3098 * charset.c (Fcharset_after): Fix typos.
3099
615a3b8d 31002011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3101
17e845af
PE
3102 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3103 Otherwise, valgrind does not work on some platforms.
3104 Problem reported by Andreas Schwab in
6a0bf43d
PE
3105 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3106 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3107 is set, removing the need for VIRT_ADDRESS_VARIES.
3108 (PURE_P): Use a more-efficient implementation that needs just one
3109 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3110 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3111 to 4 (xorl, subq, cmpq, setbe).
3112 * alloc.c (pure): Always extern now, since that's the
3113 VIRT_ADDR_VARIES behavior.
3114 (PURE_POINTER_P): Use a single comparison, not two, for
3115 consistency with the new puresize.h.
3116 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3117 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3118 Remove VIRT_ADDR_VARIES no longer needed.
3119
f8fe6f96
EZ
31202011-11-19 Eli Zaretskii <eliz@gnu.org>
3121
3122 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3123 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3124 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3125 behave as if the cursor position were at the window margin.
3126
3127 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3128 and the cursor position is out of bounds, behave as if the cursor
3129 position were at the window margin. (Bug#10075)
3130
df05a53c
CY
31312011-11-18 Chong Yidong <cyd@gnu.org>
3132
3133 * window.c (Fwindow_combination_limit): Make first argument
3134 non-optional, since it is meaningless for live windows like the
3135 selected window.
61ccba97 3136
2071918e
DA
31372011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3138
3139 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3140
b50a28de
SM
31412011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3142
3143 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3144 (graft_intervals_into_buffer): Simplify.
3145
015137db
EZ
31462011-11-18 Eli Zaretskii <eliz@gnu.org>
3147
3148 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3149 hash values of the two rows.
3150 (copy_row_except_pointers): Preserve the used[] arrays and the
3151 hash values of the two rows. (Bug#10035)
68c95424 3152 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3153
3154 * xdisp.c (row_hash): New function, body extracted from
3155 compute_line_metrics.
3156 (compute_line_metrics): Call row_hash, instead of computing the
3157 hash code inline.
3158
3159 * dispnew.c (verify_row_hash): Call row_hash for computing the
3160 hash code of a row, instead of duplicating code from xdisp.c.
3161
3162 * dispextern.h (row_hash): Add prototype.
3163
a2addb04
TH
31642011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3165
3166 * frame.c (delete_frame): Don't delete the terminal when the last
3167 X frame is closed if emacs is built with GTK toolkit.
3168
df85d315
JB
31692011-11-17 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3172
a0c2d0ae
MR
31732011-11-17 Martin Rudalics <rudalics@gmx.at>
3174
3175 * window.c (Vwindow_splits): Rename to
3176 Vwindow_combination_resize. Suggested by Juri Linkov.
3177 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3178 of Vwindow_splits.
3179
58179cce
JB
31802011-11-16 Juanma Barranquero <lekktu@gmail.com>
3181
7877f373
JB
3182 * nsfns.m (Fns_font_name):
3183 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3184
b6f67890
MR
31852011-11-16 Martin Rudalics <rudalics@gmx.at>
3186
3187 * window.h (window): Rename slot "nest" to "combination_limit".
3188 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3189 (Fset_window_nest): Rename to Fset_window_combination_limit.
3190 (Vwindow_nest): Rename to Vwindow_combination_limit.
3191 (recombine_windows, make_parent_window, make_window)
3192 (Fsplit_window_internal, saved_window)
3193 (Fset_window_configuration, save_window_save): Rename all
3194 occurrences of window_nest to window_combination_limit.
3195
c7015153
JB
31962011-11-15 Juanma Barranquero <lekktu@gmail.com>
3197
3198 * image.c (imagemagick_load_image): Fix typo.
3199
322ad6ec
EZ
32002011-11-14 Eli Zaretskii <eliz@gnu.org>
3201
3202 * xdisp.c (display_line): Move the call to
3203 highlight_trailing_whitespace before the call to
3204 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3205 faces of all the glyphs to compute ROW's hash value.
3206 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3207
f067b8ec
JB
32082011-11-14 Juanma Barranquero <lekktu@gmail.com>
3209
3210 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3211 just return (bug#10044).
3212
1e5b2111
EZ
32132011-11-12 Eli Zaretskii <eliz@gnu.org>
3214
7ef3cbd5
EZ
3215 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3216 with user-defined heap size. Bump the default size of the temacs
3217 heap to 27MB, to avoid memory warning when running temacs.
3218 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3219
1e5b2111
EZ
3220 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3221 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3222 (verify_row_hash) [XASSERTS]: New function.
3223 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3224 that the hash value of glyph rows is correct.
1e5b2111 3225
89d61221
MR
32262011-11-12 Martin Rudalics <rudalics@gmx.at>
3227
3228 * window.h (window): Remove splits slot.
3229 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3230 (Fdelete_other_windows_internal, make_parent_window)
3231 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3232 (Fset_window_configuration, save_window_save): Don't deal with
3233 split status of windows.
3234 (saved_window): Remove splits slot.
3235 (Vwindow_splits): Rewrite doc-string.
3236
97f18cc8
JD
32372011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3238
3239 * xfns.c (unwind_create_frame):
3240 * nsfns.m (unwind_create_frame):
3241 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3242 Vframe_list (Bug#9999).
3243
22a648b4
DA
32442011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3245
0b381c7e 3246 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3247
659afede
KH
32482011-11-11 Kenichi Handa <handa@m17n.org>
3249
3250 * callproc.c (Fcall_process): Set the member dst_multibyte of
3251 process_coding.
3252
9ac0394b
KH
32532011-11-11 Johan Bockgård <bojohan@gnu.org>
3254
3255 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3256 avoid a crash (bug#9496).
3257
2fbdc249
CY
32582011-11-09 Chong Yidong <cyd@gnu.org>
3259
3260 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3261 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3262
ac6b1f81
PE
32632011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3266
09db192c
PE
32672011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3268
3269 Avoid some portability problems by eschewing 'extern inline' functions.
3270 The trivial performance wins aren't worth the portability hassles; see
3271 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3272 et seq.
3273 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3274 (window_box_width, window_box_left, window_box_left_offset)
3275 (window_box_right, window_box_right_offset): Undo previous change,
3276 by removing the "extern"s.
3277 * intervals.c (adjust_intervals_for_insertion)
3278 (adjust_intervals_for_deletion): Undo previous change,
3279 making these static again.
3280 (offset_intervals, temp_set_point_both, temp_set_point)
3281 (copy_intervals_to_string): No longer inline.
3282 * xdisp.c (window_text_bottom_y, window_box_width)
3283 (window_box_height, window_box_left_offset)
3284 (window_box_right_offset, window_box_left, window_box_right)
3285 (window_box): No longer inline.
3286
105216ed
CY
32872011-11-08 Chong Yidong <cyd@gnu.org>
3288
3289 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3290 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3291 Signal an error if not a live window.
105216ed
CY
3292 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3293 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3294
ae9e237f
JB
32952011-11-07 Juanma Barranquero <lekktu@gmail.com>
3296
3297 * lisp.h (syms_of_abbrev): Remove declaration.
3298 Reported by CHENG Gao <chenggao@royau.me>.
3299
c7aa8333
EZ
33002011-11-07 Eli Zaretskii <eliz@gnu.org>
3301
3302 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3303 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3304 of temacs in GUI mode.
3305
be7f5545
MR
33062011-11-07 Martin Rudalics <rudalics@gmx.at>
3307
3308 * window.h: Declare delete_all_child_windows instead of
3309 delete_all_subwindows.
3310 * window.c (Fwindow_nest, Fset_window_nest)
3311 (Fset_window_new_total, Fset_window_new_normal)
3312 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3313 (delete_all_subwindows): Rename to delete_all_child_windows.
3314 (Fdelete_other_windows_internal, Fset_window_configuration):
3315 Call delete_all_child_windows instead of delete_all_subwindows.
3316 * frame.c (delete_frame): Call delete_all_child_windows instead
3317 of delete_all_subwindows.
3318
ca78dc43
PE
33192011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3322 This is also needed for porting to any host where GC_MARK_STACK is
3323 not GC_MAKE_GCPROS_NOOPS.
3324 (which_symbols): Use it.
3325
a0241d01
KH
33262011-11-07 Kenichi Handa <handa@m17n.org>
3327
3328 * coding.c (coding_set_destination): Check coding->src_pos only
3329 when coding->src_object is a buffer (bug#9910).
3330
3331 * process.c (send_process): Set the member src_multibyte of coding
3332 to 0 (bug#9911) when sending a unibyte text.
3333
3334 * callproc.c (Fcall_process): Set the member src_multibyte of
3335 process_coding to 0 (bug#9912).
3336
a64bfdfa 33372011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3338
3339 * xmenu.c (cleanup_widget_value_tree): New function.
3340 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3341 calling free_menubar_widget_value_tree directly (Bug#9830).
3342
cb41b32a
PE
33432011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 Fix some portability problems with 'inline'.
3346 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3347 (window_box_width, window_box_left, window_box_left_offset)
3348 (window_box_right, window_box_right_offset): Declare extern.
3349 Otherwise, these inline functions do not conform to C99 and
3350 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3351 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3352 * intervals.c (adjust_intervals_for_insertion)
3353 (adjust_intervals_for_deletion): Now extern, because otherwise the
3354 extern inline functions 'offset_intervals' couldn't refer to it.
3355 (static_offset_intervals): Remove.
3356 (offset_intervals): Rewrite using the old contents of
3357 static_offset_intervals. The old version didn't conform to C99
3358 because an extern inline function contained a reference to an
3359 identifier with static linkage.
3360
b7041366
AS
33612011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3362
3363 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3364 GC.
3365
88a37c4d
EZ
33662011-11-06 Eli Zaretskii <eliz@gnu.org>
3367
3368 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3369 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3370 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3371 return Qleft_to_right.
3372
49745b39
CY
33732011-11-06 Chong Yidong <cyd@gnu.org>
3374
3375 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3376 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3377 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3378 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3379 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3380 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3381 (Fwindow_vscroll): Doc fix.
3382 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3383 argument, since it makes no sense to pass a live window and for
3384 consistency with window-child.
3385
1f05cd82
CS
33862011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3387
3388 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3389 support MSVC.
3390
22610910
JR
33912011-11-05 Jason Rumney <jasonr@gnu.org>
3392
3393 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3394 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3395 fonts (Bug#6029).
3396 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3397 bitwise arithmetic preventing use of unicode-sip and non-truetype
3398 opentype fonts.
3399
a06776b2
EZ
34002011-11-05 Eli Zaretskii <eliz@gnu.org>
3401
3ad924ba
EZ
3402 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3403 "emacs"-only part.
3404
a06776b2
EZ
3405 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3406 initialization code to keep similarity to xfns.c after changes
3407 from 2011-11-05.
3408
c9e7db78
JD
34092011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3410
a97f8f3f
JD
3411 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3412 (unwind_create_frame): New function (Bug#9943).
3413 (Fx_create_frame): Restructure code to be more similar to the one in
3414 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3415 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3416 Move terminal->reference_count++ just before making the frame official
3417 (Bug#9943).
3418
3419 * nsterm.m (x_free_frame_resources): New function.
3420 (x_destroy_window): Move code to x_free_frame_resources.
3421
c9e7db78 3422 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3423 (Fx_create_frame, x_create_tip_frame):
3424 Move terminal->reference_count++ just before making the frame
75f1671a 3425 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3426 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3427
a6fc3b5c
EZ
34282011-11-05 Eli Zaretskii <eliz@gnu.org>
3429
3430 Support MSVC build with newer versions of Visual Studio.
3431 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3432 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3433 nt/gmake.defs.
3434
3435 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3436 which are not supported by MSVC.
3437 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3438 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3439 bitfields.
3440 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3441 types in bitfields.
3442 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3443
3444 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3445
58179cce 34462011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3447
3448 Support MSVC build with newer versions of Visual Studio.
3449 * w32.c: Don't include w32api.h for MSVC.
3450 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3451
3452 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3453 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3454 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3455 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3456 e_* cousins.
3457 (alloca) [_MSC_VER]: Define to _alloca.
3458
3459 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3460
3461 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3462
a58c13ed
EZ
34632011-11-04 Eli Zaretskii <eliz@gnu.org>
3464
3465 * xdisp.c (note_mouse_highlight): If either of
3466 previous/next-single-property-change returns nil, treat that as
3467 the beginning or the end of the buffer. (Bug#9955)
3468
fe0b6370
JD
34692011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3470
a58c13ed 3471 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3472 label is not null (Bug#9951).
3473 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3474 may be NULL.
3475
89bd5ee1
EZ
34762011-11-04 Eli Zaretskii <eliz@gnu.org>
3477
3478 * window.c (Fwindow_body_size): Mention in the doc string that the
3479 return value is in frame's canonical units. (Bug#9949)
3480
84c3edb9
EZ
34812011-11-03 Eli Zaretskii <eliz@gnu.org>
3482
4e2fb5c7
EZ
3483 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3484
84c3edb9 3485 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3486 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3487 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3488
bc17a887
EZ
34892011-11-01 Eli Zaretskii <eliz@gnu.org>
3490
3491 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3492 Don't stop backward scan on the continuation glyph, even though
3493 its CHARPOS is positive.
6d5eb5b0
SM
3494 (mouse_face_from_buffer_pos, note_mouse_highlight):
3495 Rename cover_string to disp_string.
bc17a887 3496
4ee88440
MR
34972011-11-01 Martin Rudalics <rudalics@gmx.at>
3498
3499 * window.c (temp_output_buffer_show): Don't use
3500 Vtemp_buffer_show_specifiers.
3501 (Vtemp_buffer_show_specifiers): Remove unused variable.
3502
c2ff3c02
EZ
35032011-10-30 Eli Zaretskii <eliz@gnu.org>
3504
3505 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3506 past the beginning of the current glyph matrix.
3507
58179cce 35082011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3509
3510 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3511 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3512 HAVE_GTK3 (Bug#9869).
b77a6a7f 3513
3b574623
JD
3514 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3515 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3516
b77a6a7f
JD
3517 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3518
3519 * xterm.c: Declare x_handle_net_wm_state to return int.
3520 (handle_one_xevent): Check if we are iconified but don't have
3521 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3522 (get_current_wm_state): Return non-zero if not hidden,
3523 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3524 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3525 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3526 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3527
196e41e4
PE
35282011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3529
3530 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3531 so that this new function doesn't get optimized away by a
3532 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3533
021f2e1a
AS
35342011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3535
3536 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3537
8b058d44
EZ
35382011-10-29 Eli Zaretskii <eliz@gnu.org>
3539
3540 Fix the `xbytecode' command.
3541 * .gdbinit (xprintbytestr): New command.
b50a28de 3542 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3543 (xbytecode): Print the byte-code string as well.
3544
4452fb80
EZ
35452011-10-29 Kim Storm <storm@cua.dk>
3546
8b058d44
EZ
3547 * alloc.c (which_symbols): New function.
3548
21b72067
AS
35492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3550
3551 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3552 line. (Bug#9903)
3553
83ed7b5c
GM
35542011-10-29 Glenn Morris <rgm@gnu.org>
3555
3556 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3557 Not clear what it was for, and it causes various bugs. (Bug#9839)
3558
5a7a728b
EZ
35592011-10-28 Eli Zaretskii <eliz@gnu.org>
3560
3561 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3562 possible random value that matches one of those tested as
3563 condition to clear the mouse face.
3564
d3d0842f
CY
35652011-10-28 Chong Yidong <cyd@gnu.org>
3566
3567 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3568
31b39d13
DN
35692011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3570
3571 * window.c (make_window): Initialize phys_cursor_on_p.
3572
9aba6043
SM
35732011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3574
3575 * lisp.h (struct Lisp_Symbol): Update comments.
3576
c20992f4
JB
35772011-10-28 Juanma Barranquero <lekktu@gmail.com>
3578
3579 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3580
db4f02f2
EZ
35812011-10-28 Eli Zaretskii <eliz@gnu.org>
3582
3583 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3584 <oslsachem@gmail.com> for helping to debug this.
3585
3586 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3587 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3588 (g_b_init_get_glyph_outline_w): New static variables.
3589 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3590 (GetGlyphOutlineW_Proc): New typedefs.
3591 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3592 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3593 New functions.
3594 (w32font_open_internal, compute_metrics):
3595 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3596 instead of calling the "wide" APIs directly.
3597
3598 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3599
3600 * w32.h (syms_of_w32font): Add prototype.
3601
87e68db4
JB
36022011-10-27 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3605 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3606 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3607 (Fmove_to_window_line): Doc fix.
3608
435c1d67
CY
36092011-10-27 Chong Yidong <cyd@gnu.org>
3610
3611 * process.c (make_process): Set gnutls_state to NULL.
3612
3613 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3614 non-NULL, regardless of GNUTLS_INITSTAGE.
3615 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3616 an error. Set process slots as soon as we allocate them.
3617
3618 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3619
9c6c6f49
CY
36202011-10-27 Chong Yidong <cyd@gnu.org>
3621
9aba6043
SM
3622 * gnutls.c (emacs_gnutls_deinit): New function.
3623 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3624 (Fgnutls_deinit, Fgnutls_boot): Use it.
3625
3626 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3627 (deactivate_process): Call emacs_gnutls_deinit.
3628
657d08d3
JB
36292011-10-27 Juanma Barranquero <lekktu@gmail.com>
3630
3631 * image.c (x_create_x_image_and_pixmap):
3632 * w32.c (sys_rename, w32_delayed_load):
3633 * w32font.c (fill_in_logfont):
3634 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3635
5430d399
JB
36362011-10-26 Juanma Barranquero <lekktu@gmail.com>
3637
3638 * w32fns.c (w32_default_color_map): New function,
3639 extracted from Fw32_default_color_map.
a7ef684b 3640 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3641
fe0055fa
PE
36422011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3643
3644 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3645
e6346438
SM
36462011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3647
3648 * keyboard.c (test_undefined): New function (bug#9751).
3649 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3650
e112cc37
ET
36512011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3652
3653 * sysdep.c (init_sys_modes): Fix the check for the controlling
3654 terminal (Bug#6649).
3655
7b5d6677
EZ
36562011-10-20 Eli Zaretskii <eliz@gnu.org>
3657
3658 * dispextern.h (struct bidi_it): New member next_en_type.
3659
3660 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3661 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3662 current character, check also for next_en_type being WEAK_EN.
3663 (bidi_resolve_weak): Don't enter the expensive loop if the current
3664 position is before next_en_pos. Record the bidi type of the first
3665 non-ET, non-BN character we find, in addition to its position.
3666 (bidi_level_of_next_char): Invalidate next_en_type when
3667 next_en_pos is over-stepped.
3668
7da0b018
PE
36692011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3672 * editfns.c: Rewrite current-time-zone so that it invokes
3673 the equivalent of (format-time-string "%Z") to get the time zone name.
3674 This fixes a bug when the time zone name contains characters that
3675 need converting from the system time locale to Emacs internal format.
3676 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3677 that patch fixed format-time-string to do the conversion, but
3678 I forgot to fix current-time-zone.
3679 (format_time_string): New function, containing most of
3680 what Fformat_time_string used to contain.
3681 (Fformat_time_string): Rewrite in terms of format_time_string.
3682 This doesn't change this function's behavior.
3683 (current-time-zone): Rewrite to use format_time_string.
3684 This fixes the bug reported by Michael Schierl in
3685 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3686 Jason Rumney's 2007-06-07 change worked around this bug, but
3687 didn't fix it.
3688 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3689
8547b010
EZ
36902011-10-19 Eli Zaretskii <eliz@gnu.org>
3691
3692 * xdisp.c (start_display): If the character at POS is displayed
3693 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3694 (try_window_reusing_current_matrix): If a line ends in a display
3695 vector or the next line starts in a display vector, continue
3696 redrawing the window even though the character position of
3697 start_row was reached.
8547b010
EZ
3698 (Bug#9771, part 2)
3699
4e948d15
CY
37002011-10-18 Chong Yidong <cyd@gnu.org>
3701
3702 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3703 with nobreak-char-display too.
3704
4787455f
EZ
37052011-10-18 Eli Zaretskii <eliz@gnu.org>
3706
3707 Fix part 3 of bug#9771.
3708 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3709 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3710 non-neutral characters if the current character is a paragraph
3711 separator (a.k.a. Newline). This avoids running the same
3712 expensive loop twice, once when we consume the preceding newline
3713 and the other time when the line actually needs to be displayed.
3714 Avoid the loop when we see neutrals on the base embedding level
3715 following a character whose directionality is the same as the
3716 paragraph's. This avoids running the expensive loop when a line
3717 ends in a long sequence of neutrals, like control characters.
3718 Add assertion against STRONG_AL type. Slightly rearrange code
3719 that determines the type of a neutral given the first non-neutral
3720 that follows it.
3721 (bidi_level_of_next_char): Set next_en_pos to zero when
3722 invalidating its info.
3723
2c91f553
EZ
37242011-10-17 Eli Zaretskii <eliz@gnu.org>
3725
3726 * xdisp.c (push_display_prop): Determine whether to record string
3727 or buffer position by IT->string, not by IT->method. Allow
3728 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3729 (move_it_vertically_backward): Don't look for character position
3730 immediately after the newline when in a continuation line.
3731 (Bug#9771, part 1)
2c91f553 3732
c7b08b0d
MR
37332011-10-15 Martin Rudalics <rudalics@gmx.at>
3734
3735 * window.c (coordinates_in_window): Rewrite and delabelize
3736 vertical border check. (Bug#5357) (Bug#9618)
3737
6b02f655
SM
37382011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3739
3740 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3741 errors in XSetWindowBorder (bug#9310).
3742
81d40c92
DA
37432011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3744
3745 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3746 avoid crash when xmalloc overrun checking is enabled.
3747
d4172c3b
EZ
37482011-10-13 Eli Zaretskii <eliz@gnu.org>
3749
3750 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3751 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3752 cursor motion with <left> and <right> arrow keys.
3753
3754 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3755 some callers set that themselves.
3756
b00eea75
EZ
37572011-10-12 Eli Zaretskii <eliz@gnu.org>
3758
3759 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3760 display string and the previous row comes from the same string and
3761 is empty. (Bug#9739) (Bug#9738)
3762
8fe012c4
SM
37632011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3764
3765 * doc.c (get_doc_string): Encode file name (bug#9735).
3766
0074aef2
EZ
37672011-10-12 Eli Zaretskii <eliz@gnu.org>
3768
79beb178
EZ
3769 * bidi.c (bidi_level_of_next_char):
3770 * xdisp.c (get_visually_first_element): Remove old incorrect
3771 comments regarding the Unicode Line Separator character.
3772
0074aef2
EZ
3773 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3774
6e4b3fbe
DA
37752011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3776
3777 * alloc.c (Fgc_status): Do not access beyond zombies array
3778 boundary if nzombies > MAX_ZOMBIES.
3779 * alloc.c (dump_zombies): Add missing format specifier.
3780
0324f3af
PE
37812011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3782
b5525cac
PE
3783 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3784 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3785
0324f3af
PE
3786 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3787 Some packages use them to denote characters with modifiers.
3788
e9b5f888
AS
37892011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3790
3791 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3792 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3793 matching a pp-number. Rename parameter var to var1.
3794
127827c0
SM
37952011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3796
3797 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3798
c8fd3bd0
GM
37992011-10-08 Glenn Morris <rgm@gnu.org>
3800
3801 * callint.c (Fcall_interactively): Give a more explicit error for the
3802 'c' case with a non-character input. (Bug#8479)
3803
352ec8ff
EZ
38042011-10-08 Eli Zaretskii <eliz@gnu.org>
3805
03669ccb
EZ
3806 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3807 lines.
7061c986
EZ
3808 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3809 lines that are hscrolled on the left.
03669ccb 3810
352ec8ff
EZ
3811 * dispnew.c (buffer_posn_from_coords): Account for a possible
3812 presence of header-line. (Bug#4426)
3813
a66cfb1c
SM
38142011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3815
6b02f655
SM
3816 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3817 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3818
7c5ee88e
PE
38192011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3820
3821 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3822 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3823 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3824 this makes Emacs dump core during garbage collection on rare
3825 occasions. sizeof is obviously inferior to offsetof here, so
3826 stick with offsetof.
3827 (GC_POINTER_ALIGNMENT): New macro.
3828 (mark_memory): Omit 3rd (offset) arg; caller changed.
3829 Don't assume EMACS_INT alignment is the same as pointer alignment.
3830
df1bbe5b
SM
38312011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3832
3833 * keyboard.c (read_key_sequence_remapped): New var.
3834 (read_key_sequence): Compute remapping in the right buffer.
3835 (command_loop_1): Use read_key_sequence's remapping directly.
3836
51553db6
SM
38372011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3838
32c1fffd
SM
3839 * dired.c (file_name_completion): Don't expand file name.
3840 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3841 before checking file name handler.
3842
51553db6
SM
3843 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3844 they've been requested explicitly (bug#9591).
3845
b6bd1599 38462011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3847
3848 * keymap.c (Fsingle_key_description): Use make_specified_string
3849 instead of build_string to build string from push_key_description.
3850 (Bug#5193)
3851
f701dc2a
PE
38522011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3853
4222c55d
PE
3854 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3855 This fixes a Y2038 bug on 64-bit hosts.
3856 * buffer.c (reset_buffer):
3857 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3858 (Fclear_buffer_auto_save_failure):
3859 Use 0, not -1, to represent an unset failure time, since time_t
3860 might not be signed.
3861
f701dc2a
PE
3862 Remove dependency on glibc malloc internals.
3863 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3864 Move back here from lisp.h, but with their new implementations.
3865 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3866 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3867 * charset.c (charset_table_init): New static var.
3868 (syms_of_charset): Use it instead of xmalloc. This removes a
3869 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3870 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3871 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3872 Move back to alloc.c.
3873 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3874 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3875
9ceebf39
JD
38762011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3877
3878 * nsterm.m (windowDidResize): Call x_set_window_size only when
3879 ns_in_resize is true. Otherwise set pixelwidth/height and
3880 call change_frame_size (Bug#9628).
3881
cb993c58
PE
38822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3883
3930c88b
PE
3884 Port --enable-checking=all to Fedora 14 x86-64.
3885 * charset.c (syms_of_charset): Also account for glibc malloc's
3886 internal overhead when calculating the initial malloc maximum.
3887
cb993c58
PE
3888 Port --enable-checking=all to Fedora 14 x86.
3889 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3890 Move to lisp.h.
3891 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3892 (overrun_check_realloc, overrun_check_free):
3893 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3894 That way, xmalloc returns a properly-aligned pointer even if
3895 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3896 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3897 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3898 into account when calculating the initial malloc maximum.
3899 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3900 Move here from alloc.c, so that charset.c can use it too.
3901 Properly align; the old code wasn't right for common 32-bit hosts
3902 when configured with --enable-checking=all.
3903 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3904 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3905
31bed486
EZ
39062011-09-29 Eli Zaretskii <eliz@gnu.org>
3907
04c70788 3908 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3909 use EDOM.
3910
fbcaa2f3
EZ
39112011-09-28 Eli Zaretskii <eliz@gnu.org>
3912
3913 * xdisp.c (compute_display_string_end): If there's no display
3914 string at CHARPOS, return -1.
3915
3916 * bidi.c (bidi_fetch_char): When compute_display_string_end
3917 returns a negative value, treat the character as a normal
3918 character not covered by a display string. (Bug#9624)
3919
a239d4e9
JB
39202011-09-28 Juanma Barranquero <lekktu@gmail.com>
3921
3922 * lread.c (Fread_from_string): Fix typo in docstring.
3923
88652fd5
EZ
39242011-09-27 Eli Zaretskii <eliz@gnu.org>
3925
3926 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3927 newline, reseat the iterator instead of bidi-iterating there one
3928 character at a time. (Bug#9610)
32c1fffd
SM
3929 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3930 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3931
ed497dd4
AS
39322011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3933
3934 * lread.c (readevalloop): Use correct code for NBSP.
3935 (read1): Likewise. (Bug#9608)
3936
b2bf61aa
MA
39372011-09-25 Michael Albinus <michael.albinus@gmx.de>
3938
3939 * dbusbind.c (Fdbus_register_signal): When service is not
3940 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3941
32bbb17c
GM
39422011-09-25 Glenn Morris <rgm@gnu.org>
3943
3944 * buffer.c (truncate-lines): Doc fix.
3945
94e0933e
CY
39462011-09-24 Chong Yidong <cyd@stupidchicken.com>
3947
3948 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3949 (Fset_window_next_buffers): Doc fix.
3950
cddde921
GM
39512011-09-24 Glenn Morris <rgm@gnu.org>
3952
3953 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3954
1260aef1
PE
39552011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3956
25b4bfa0
PE
3957 Fix minor problems found by static checking.
3958 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3959 * indent.c (Fvertical_motion): Fix == vs = typo.
3960
e3cbd34b
EZ
39612011-09-24 Eli Zaretskii <eliz@gnu.org>
3962
a66cfb1c
SM
3963 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3964 Default value is now t. Doc fix.
6bf7006f 3965
e3cbd34b 3966 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3967 logic when moving up, not only when moving down. Fix the
e3cbd34b 3968 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3969 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3970
3971 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3972 CHARPOS is covered by a display string which includes newlines.
3973 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3974 is covered by a display string with embedded newlines.
3975
a3de0cbd
MA
39762011-09-24 Michael Albinus <michael.albinus@gmx.de>
3977
3978 * dbusbind.c (Fdbus_register_signal): Add match rule to
3979 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3980 (Fdbus_register_method, Vdbus_registered_objects_table):
3981 Fix docstring.
a3de0cbd 3982
b260039d
JM
39832011-09-24 Jim Meyering <meyering@redhat.com>
3984
32c1fffd 3985 do not ignore write error for any output size
b260039d
JM
3986 The previous change was incomplete.
3987 While it makes emacs --batch detect the vast majority of stdout
3988 write failures, errors were still ignored whenever the output size is
3989 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3990 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3991 && echo FAIL: ignored write error
3992 FAIL: ignored write error
3993 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3994 && echo FAIL: ignored write error
3995 FAIL: ignored write error
3996 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3997
8eca8a7c
AS
39982011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3999
4000 * emacs.c (Fkill_emacs): In noninteractive mode exit
4001 non-successfully if a write error occurred on stdout. (Bug#9574)
4002
3341db62
EZ
40032011-09-21 Eli Zaretskii <eliz@gnu.org>
4004
4005 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4006 the xassert test.
4007
4008 * dispextern.h (struct it): Update the comment documenting what
4009 can it->OBJECT be.
4010
8c203dbf
EZ
40112011-09-20 Eli Zaretskii <eliz@gnu.org>
4012
4013 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4014 a display string, extend search for cursor position to end of row.
4015 (find_row_edges): If the row ends in a newline from a display
4016 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4017 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4018 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4019 non-empty line. Fixes confusing cursor motion with arrow keys at
4020 the beginning of a line that starts with whitespace.
8c203dbf 4021
a4824228
LMI
40222011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4023
4024 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4025 (bug#9493).
4026
33ed493b
CY
40272011-09-18 Chong Yidong <cyd@stupidchicken.com>
4028
4029 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4030 boolean (Bug#9154).
4031
56cd55c8
EZ
40322011-09-18 Eli Zaretskii <eliz@gnu.org>
4033
4034 * xdisp.c (display_line): Record maximum and minimum buffer
4035 positions even if no glyphs were produced (e.g., by a zero-width
4036 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4037 buffer positions that will be removed from the glyph row because
4038 they don't fit.
c02dcedf
EZ
4039 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4040 column is beyond frame width: don't subtract 1 "pixel" when
4041 computing width of the stretch.
3e62b7e0
EZ
4042 (reseat_at_next_visible_line_start): Undo the change made on
4043 2011-09-17 that saved paragraph information and restored it after
4044 the call to `reseat'. (Bug#9545)
56cd55c8 4045
5ed99d36 40462011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4047
4048 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4049 and turn window cursor on if cleared (Bug#9415).
4050
5ed99d36 40512011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4052
4053 * search.c (boyer_moore): Take unibyte characters from pattern
4054 literally. (Bug#9458)
4055
9bade7b2
EZ
40562011-09-18 Eli Zaretskii <eliz@gnu.org>
4057
4058 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4059
e5e9d610
PE
40602011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4061
87e4427a
PE
4062 Fix minor problem found by static checking.
4063 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4064 initialized, to pacify gcc -Wuninitialized.
4065
e5e9d610
PE
4066 * fileio.c: Report proper errno when syscall falls.
4067 (Finsert_file_contents): Save and restore errno,
4068 so that report_file_error outputs the correct diagnostic.
4069 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4070
a1674f0b
EZ
40712011-09-18 Eli Zaretskii <eliz@gnu.org>
4072
4073 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4074
fbfb6dd4
EZ
40752011-09-17 Eli Zaretskii <eliz@gnu.org>
4076
4077 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4078 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4079
bb187662
EZ
40802011-09-17 Eli Zaretskii <eliz@gnu.org>
4081
1137e8b8 4082 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4083 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4084
4085 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4086 (bidi_find_paragraph_start): Search back for paragraph beginning
4087 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4088 (bidi_move_to_visually_next): Only trigger paragraph-related
4089 computations when the last character is a newline or at EOB, not
4090 just any NEUTRAL_B. (Bug#9470)
4091
bb187662
EZ
4092 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4093 truncated lines if point is covered by a display string. (Bug#9524)
4094
2e621251
PE
40952011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4096
4097 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4098 (cons_to_x_long): New function.
4099 (lisp_data_to_selection_data): Use it. Correct the test for
4100 short-versus-long data; it was negated. Break out of vector
4101 loop, for efficiency, when a long datum is discovered.
4102
91a15bc6
SM
41032011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4104
4105 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4106
b41c3a35
EZ
41072011-09-16 Eli Zaretskii <eliz@gnu.org>
4108
4109 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4110 GCC PR/17406) by declaring this function with external scope.
4111
7812ba2d
PE
41122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4113
4114 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4115 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4116
cf7edc2a
AS
41172011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4118
4119 * editfns.c (Fformat): Correctly handle text properties on "%%".
4120
bd01620e
EZ
41212011-09-15 Eli Zaretskii <eliz@gnu.org>
4122
4123 * xterm.c (x_draw_composite_glyph_string_foreground):
4124 * w32term.c (x_draw_composite_glyph_string_foreground):
4125 * term.c (encode_terminal_code):
4126 * composite.c (composition_update_it, get_composition_id):
4127 * xdisp.c (get_next_display_element)
4128 (fill_composite_glyph_string): Add comments about special meaning
4129 of TAB characters in a composition.
4130
a02719a3
PE
41312011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4132
4133 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4134 This occurs when processing a multibyte format.
4135 Problem reported by Wolfgang Jenker.
a02719a3 4136
72589a3c
JB
41372011-09-15 Johan Bockgård <bojohan@gnu.org>
4138
4139 * xdisp.c (try_cursor_movement): Only check for exact match if
4140 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4141
1c14176c
PE
41422011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4143
4144 Remove unused external symbols.
4145 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4146 * xdisp.c (calc_pixel_width_or_height): Now static.
4147 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4148 * indent.c (check_display_width):
4149 * w32term.c: Fix comment to match code.
4150 * xterm.c, xterm.h (x_catching_errors): Remove.
4151
d2eea5b5
PE
41522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4153
4154 * xselect.c: Use signed conversions more consistently (Bug#9498).
4155 (selection_data_to_lisp_data): Assume incoming selection data are
4156 signed integers, not unsigned. This is to be consistent with
4157 outgoing selection data, which was modified to use signed integers
4158 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4159 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4160 expects long, not unsigned long.
4161
46888499
EZ
41622011-09-14 Eli Zaretskii <eliz@gnu.org>
4163
4164 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4165 computation of loop end. Reported by Johan Bockgård
4166 <bojohan@gnu.org>.
4167
ef8ef9fb
CY
41682011-09-13 Chong Yidong <cyd@stupidchicken.com>
4169
4170 * frame.c (Fother_visible_frames_p): Function deleted.
4171
fa819fed
EZ
41722011-09-12 Eli Zaretskii <eliz@gnu.org>
4173
4174 * indent.c (compute_motion): Process display vector front to back
4175 rather than the other way around. (Bug#2496)
4176
2ba8e008
SM
41772011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4178
4179 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4180
20f53c69
CY
41812011-09-11 Chong Yidong <cyd@stupidchicken.com>
4182
4183 * minibuf.c (Fread_from_minibuffer): Doc fix.
4184
d562d7a4
EZ
41852011-09-11 Eli Zaretskii <eliz@gnu.org>
4186
4187 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4188 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4189
1c4d7f3d
LMI
41902011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4191
4192 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4193 value for non-existent files.
4194
b885bf36
EZ
41952011-09-11 Eli Zaretskii <eliz@gnu.org>
4196
4197 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4198 set its "size" to -1. This will set the modtime_size field of
4199 the corresponding buffer to -1, which is what
4200 verify-visited-file-modtime expects for files that do not exist.
4201 (Bug#9139)
4202
6612f0bf
PE
42032011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4204
4205 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4206 here ...
4207 * lisp.h: ... from here. push_key_description is no longer
4208 defined in keyboard.c, so its declaration should not be in
4209 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4210 logically belongs with push_key_description.
4211
dfb3f755
PE
42122011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4213
4214 * buffer.h: Include <sys/types.h> instead of <time.h>.
4215 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4216 Problem reported by Herbert J. Skuhra.
4217
3134906c
LMI
42182011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4219
4220 * xml.c (parse_region): Make the parsing work for
4221 non-comment-starting XML files again (bug#9144).
4222
8d903f4e
AS
42232011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4224
4225 * image.c (gif_load): Fix calculation of bottom and right corner.
4226 (Bug#9468)
4227
80ad64f4
EZ
42282011-09-10 Eli Zaretskii <eliz@gnu.org>
4229
4230 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4231 redisplay in small windows.
4232
208a048d
EZ
42332011-09-09 Eli Zaretskii <eliz@gnu.org>
4234
4235 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4236
9b1c252e
MR
42372011-09-08 Martin Rudalics <rudalics@gmx.at>
4238
4239 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4240 Operate on live windows only.
4241
2949f33b
JB
42422011-09-08 Juanma Barranquero <lekktu@gmail.com>
4243
4244 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4245
e08dcafd
EZ
42462011-09-07 Eli Zaretskii <eliz@gnu.org>
4247
4248 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4249 only under bidi iteration.
4250
115b96bd
JD
42512011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4252
4253 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4254
c8199d0f
PE
42552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4258 Without this fix, the command to link temacs failed due to an
4259 undefined symbol __builtin_isnan. This is because
4260 /usr/include/iso/math_c99.h #defines isnan(x) to
4261 __builtin_isnan(x), but the bundled gcc, which identifies itself
4262 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4263 a __builtin_isnan.
4264 * floatfns.c (isnan): #undef, and then #define to a clone of
4265 what's in data.c.
4266 (Fisnan): Always define, since it's always available now.
4267 (syms_of_floatfns): Always define isnan at the Lisp level.
4268
e39b275c 42692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4270
4271 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4272
b2db44d9 42732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4274
f4af5137 4275 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4276 The previous code assumed that file offsets (off_t values) fit in
4277 EMACS_INT variables, which is not true on typical 32-bit hosts.
4278 The code messed up by falsely reporting buffer overflow in cases
4279 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4280 when "big" contains more than 2**29 bytes, even though this
4281 inserts just one byte and does not overflow the buffer.
4282 (Finsert_file_contents): Store file offsets as off_t
4283 values, not as EMACS_INT values. Check for overflow when
4284 converting between EMACS_INT and off_t. When checking for
4285 buffer overflow or for overlap, take the offsets into account.
4286 Don't use EMACS_INT for small values where int suffices.
4287 When checking for overlap, fix a typo: ZV was used where
4288 ZV_BYTE was intended.
4289 (Fwrite_region): Don't assume off_t fits into 'long'.
4290 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4291
ecfc0a49
MA
42922011-09-05 Michael Albinus <michael.albinus@gmx.de>
4293
4294 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4295
6511acf2 42962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4297
0999621a 4298 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4299
4300 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4301 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4302 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4303 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4304 (modify_event_symbol): Do not assume that the length of
4305 name_alist_or_stem is safe to alloca and fits in int.
4306 (Fexecute_extended_command): Likewise for function name and binding.
4307 (Frecursion_depth): Wrap around reliably on integer overflow.
4308 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4309 since some callers pass EMACS_INT values.
4310 (Fsingle_key_description): Don't crash if symbol name contains more
4311 than MAX_ALLOCA bytes.
4312 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4313 (get_minibuffer): Arg is now EMACS_INT, not int.
4314 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4315 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4316 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4317
2be7d702
PE
4318 * dbusbind.c (signature_cat): New function.
4319 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4320 Do not overrun buffer; instead, report string overflow.
4321
9d1df220
PE
4322 * dispnew.c (add_window_display_history): Don't overrun buffer.
4323 Truncate instead; this is OK since it's just a log.
4324
33ef5c64
PE
4325 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4326 even if the time zone offset is outlandishly large.
4327 Don't mishandle offset == INT_MIN.
4328
66c6fdd5
PE
4329 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4330 when creating daemon; the previous buffer-overflow check was incorrect.
4331
d749b01b
PE
4332 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4333 which has the guts of the old verror function.
4334
b5cd1905
PE
4335 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4336 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4337
6e1a67fb
PE
4338 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4339 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4340 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4341 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4342 length of string rather than counting it via multiple sprintfs;
4343 that's simpler and more reliable.
c21721cc
PE
4344 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4345 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4346 sprintf, in case result does not fit in int.
4347
c57b67fc
PE
4348 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4349 (fontset_from_font): Print it.
4350
8a401434
PE
4351 * frame.c (tty_frame_count): Now printmax_t, not int.
4352 (make_terminal_frame, set_term_frame_name): Print it.
4353 (x_report_frame_params): In X, window IDs are unsigned long,
4354 not signed long, so print them as unsigned.
4355 (validate_x_resource_name): Check for implausibly long names,
4356 and don't assume name length fits in 'int'.
4357 (x_get_resource_string): Don't blindly alloca invocation name;
4358 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4359 not fit in int.
4360
6e1a67fb
PE
4361 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4362 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4363 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4364
0df02bf3
PE
4365 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4366 Use esprintf, not sprintf, in case result does not fit in int.
4367
48e30793
PE
4368 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4369 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4370 it as a large positive number.
4371 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4372 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4373
a66ff6d8
PE
4374 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4375 in case result does not fit in int.
4376
aca216ff
PE
4377 * print.c (float_to_string): Detect width overflow more reliably.
4378 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4379 buffer overrun. Don't assume list length fits in 'int'. Treat
4380 print length of 0 as 0, not as infinity; to be consistent with other
4381 uses of print length in this function. Don't overflow print length
4382 index. Don't assume hash table size fits in 'long', or that
4383 vectorlike size fits in 'unsigned long'.
4384
31c286f7
PE
4385 * process.c (make_process): Use printmax_t, not int, to format
4386 process-name gensyms.
4387
55e5faa1
PE
4388 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4389
80f2e268
PE
4390 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4391 to avoid potential buffer overrun.
4392
670741ab
PE
4393 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4394 if X resource line is longer than 512 bytes.
4395
b7163a50
PE
4396 * xfns.c (x_window): Make sprintf buffer a bit bigger
4397 to avoid potential buffer overrun.
4398
ae58ff1f
PE
4399 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4400
c43c8a6a
PE
4401 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4402
3f8236f4
PE
44032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4404
53e9fe90 4405 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4406 Without these, Emacs silently mishandles large integers sometimes.
4407 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4408 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4409
6511acf2
PE
4410 * xdisp.c (try_window_id): Check Emacs fixnum range before
4411 converting to 'int'.
806add1d 4412
6511acf2 4413 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4414 Check that an Emacs fixnum is in range before assigning it to 'int'.
4415 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4416 values converted from Emacs fixnums.
4417 (Frecenter): Don't wrap around a line count if it is out of 'int'
4418 range; instead, treat it as an extreme value.
4419 (Fset_window_configuration, compare_window_configurations):
4420 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4421
6511acf2
PE
4422 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4423 that can exceed INT_MAX. Check that EMACS_INT value is in range
4424 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4425 (match_limit): Don't assume that a fixnum can fit in 'int'.
4426
6511acf2 4427 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4428 exceed INT_MAX.
4429
6511acf2 4430 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4431 (Fvertical_motion): Don't wrap around LINES values that don't fit
4432 in 'int'. Instead, treat them as extreme values. This is good
4433 enough for windows, which can't have more than INT_MAX lines anyway.
4434
fcb901a7
LMI
44352011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4436
0f2f6b6d
LMI
4437 * Require libxml/parser.h to avoid compilation warning.
4438
fcb901a7
LMI
4439 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4440
4441 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4442 since this reportedly can destroy thread storage.
4443
6e20a0d4
CY
44442011-08-30 Chong Yidong <cyd@stupidchicken.com>
4445
4446 * syntax.c (find_defun_start): Update all cache variables if
4447 exiting early (Bug#9401).
4448
148ae00e
EZ
44492011-08-30 Eli Zaretskii <eliz@gnu.org>
4450
f6cfbd8f
EZ
4451 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4452
148ae00e
EZ
4453 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4454 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4455 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4456
4457 * term.c (tty_append_glyph): New function.
4458 (produce_stretch_glyph): Static function and its prototype deleted.
4459
a66cfb1c
SM
4460 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4461 Add prototypes.
148ae00e 4462
c4a07a4c
PE
44632011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4466 when checking :margin (Bug#9390).
4467 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4468 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4469 so that the name doesn't mislead. All uses changed.
4470
6bc8cd65
JB
44712011-08-28 Johan Bockgård <bojohan@gnu.org>
4472
4473 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4474 set_tty_hooks.
4475
dca4927e
EZ
44762011-08-27 Eli Zaretskii <eliz@gnu.org>
4477
4478 * xdisp.c (move_it_to): Don't bail out early when reaching
4479 position beyond to_charpos, if we are scanning backwards.
4480 (move_it_vertically_backward): When DY == 0, make sure we get to
4481 the first character in the line after the newline.
4482
f2cad773
PE
44832011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4484
4485 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4486 (ccl_driver): Do not generate an out-of-range pointer.
4487 (Fccl_execute_on_string): Remove unnecessary check for
4488 integer overflow, noted by Stefan Monnier in
4489 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4490 Remove a FIXME that didn't need fixing.
4491 Simplify the newly-introduced buffer reallocation code.
4492
0cae2cdb
JB
44932011-08-27 Juanma Barranquero <lekktu@gmail.com>
4494
4495 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4496
5fc295a4 44972011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4498
70c60eb2 4499 Integer and memory overflow issues (Bug#9196).
726e0ab1 4500
d31850da
PE
4501 * doc.c (get_doc_string): Rework so that
4502 get_doc_string_buffer_size is the actual buffer size, rather than
4503 being 1 less than the actual buffer size; this makes xpalloc more
4504 convenient.
4505
a69fbedb
PE
4506 * image.c (x_allocate_bitmap_record, cache_image):
4507 * xselect.c (Fx_register_dnd_atom):
4508 Simplify previous changes by using xpalloc.
4509
fe5c5d37
PE
4510 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4511 since either will do and ptrdiff_t is convenient with xpalloc.
4512
0065d054
PE
4513 * charset.c (charset_table_size)
4514 (struct charset_sort_data.priority): Now ptrdiff_t.
4515 (charset_compare): Don't overflow if priorities differ greatly.
4516 (Fsort_charsets): Don't assume list length fits in int.
4517 Check for size-calculation overflow when allocating sort data.
4518 (syms_of_charset): Allocate an initial charset table that is
4519 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4520
4521 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4522
4523 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4524 The actual value is always <= INT_MAX, and leaving it unsigned made
4525 overflow checking harder.
4526
4527 * dispextern.h (struct glyph_matrix.rows_allocated)
4528 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4529 with xpalloc. The values are still always <= INT_MAX.
4530
4531 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4532
4533 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4534 (SAFE_NALLOCA): New macro.
4535
4536 * region-cache.c (struct boundary.pos, find_cache_boundary)
4537 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4538 (set_cache_region, invalidate_region_cache)
4539 (revalidate_region_cache, know_region_cache, region_cache_forward)
4540 (region_cache_backward, pp_cache):
4541 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4542 so that ptrdiff_t * can be passed to xpalloc.
4543 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4544 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4545 (pp_cache): Don't assume cache_len fits in int.
4546 * region-cache.h: Adjust extern decls to match.
4547
4548 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4549 EMACS_INT, since either will do, for xpalloc.
4550
4551 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4552 (xnmalloc, xnrealloc, xpalloc): New functions.
4553
726e0ab1
PE
4554 * bidi.c (bidi_shelve_header_size): New constant.
4555 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4556 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4557
51f30bc5 4558 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4559 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4560 (overlay_strings):
4561 Don't update size of array until after memory allocation succeeds,
4562 because xmalloc/xrealloc may not return.
0065d054
PE
4563 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4564 now that we have proper integer overflow checking.
4565 (record_overlay_string, overlay_strings): Catch overflows when
4566 calculating size of overlay_str_buf.
726e0ab1 4567
0065d054
PE
4568 * callproc.c (Fcall_process): Check for size overflow when
4569 calculating size of args2.
4570 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4571 Normally we prefer signed values, but sticking with ptrdiff_t would
4572 require adding more-complicated checks.
726e0ab1
PE
4573
4574 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4575 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4576 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4577 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4578
4579 * character.c (Fstring): Check for size-calculation overflow.
4580
4581 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4582 unnecessary integer overflow. Check for size overflow.
4583 (encode_coding_object): Don't update size until xmalloc succeeds.
4584
4585 * composite.c (get_composition_id): Check for overflow in glyph
4586 length calculations.
4587
4588 Integer and memory overflow fixes for display code.
4589 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4590 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4591 (scrolling_window): Check for overflow in size calculations.
4592 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4593 Don't assume glyph table len fits in int.
4594 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4595 (row_table_size): Now ptrdiff_t, not int.
4596 (scrolling_window): Avoid overflow in size calculations.
4597 Don't update size until allocation succeeds.
4598 * fns.c (concat): Check for overflow in size calculations.
4599 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4600 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4601 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4602
4603 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4604 (get_doc_string): Check for size calculation overflow.
4605 Don't update size until allocation succeeds.
4606 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4607 EMACS_INT, where ptrdiff_t will do.
4608 (Fsubstitute_command_keys): Check for string overflow.
4609
4610 * editfns.c (set_time_zone_rule): Don't assume environment length
4611 fits in int.
4612 (message_length): Now ptrdiff_t, not int.
4613 (Fmessage_box): Don't update size until allocation succeeds.
4614 Don't assume message length fits in int.
4615 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4616
0065d054
PE
4617 * emacs.c (main): Do not reallocate argv, since there is a null at
4618 the end that can be overwritten, and this way there's no need to
4619 worry about size-calculation overflow.
4620 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4621
4622 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4623 alloc succeeds.
4624 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4625
4626 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4627 (x_set_scroll_bar_width, x_figure_window_size):
4628 Check for integer overflow.
4629 (x_set_alpha): Do not assume XINT fits in int.
4630
4631 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4632 This is for the members text_lines, text_cols, total_lines, total_cols,
4633 where the system imposes an 'int' limit.
4634
4635 * fringe.c (Fdefine_fringe_bitmap):
4636 Don't update size until alloc works.
4637
4638 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4639 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4640
4641 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4642 Check for size-calculation overflow.
4643 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4644 do, as we prefer signed integers.
4645 (id_to_widget.max_size, id_to_widget.used)
4646 (xg_store_widget_in_map, xg_remove_widget_from_map)
4647 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4648 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4649 Use and return ptrdiff_t, not int.
4650 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4651 * gtkutil.h: Change prototypes to match the above.
4652
4653 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4654 are duplicate now that they've been promoted to lisp.h.
4655 (x_allocate_bitmap_record, x_alloc_image_color)
4656 (make_image_cache, cache_image, xpm_load):
4657 Don't update size until alloc is done.
4658 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4659 (x_detect_edges):
3256efce 4660 Check for size calculation overflow.
726e0ab1
PE
4661 (ct_colors_allocated_max): New constant.
4662 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4663 overflow.
3256efce 4664
726e0ab1
PE
4665 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4666 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4667 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4668 Use ptrdiff_t, not int, to count maps.
4669 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4670 calculations. Don't update size until allocation succeeds.
4671 Redo calculations to avoid overflow.
726e0ab1
PE
4672 * keyboard.h: Change prototypes to match the above.
4673
4674 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4675 to count maps.
4676 (current_minor_maps): Check for size calculation overflow.
4677 * keymap.h: Change prototypes to match the above.
4678
4679 * lread.c (read1, init_obarray): Don't update size until alloc done.
4680
4681 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4682 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4683
726e0ab1
PE
4684 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4685 Now ptrdiff_t, not int.
4686 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4687 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4688
4689 * process.c (Fnetwork_interface_list): Check for overflow
4690 in size calculation.
4691
4692 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4693
4694 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4695 overflow. Don't bother calling xmalloc when xrealloc will do.
4696
4697 * search.c (Freplace_match): Check for size calculation overflow.
4698 (Fset_match_data): Don't assume list lengths fit in 'int'.
4699
4700 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4701 for command line length. Do not attempt to address one before the
4702 beginning of an array, as that's not portable.
4703
4704 * term.c (max_frame_lines): Remove; unused.
4705 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4706 not int.
4707 (encode_terminal_code, calculate_costs): Check for size
4708 calculation overflow.
4709 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4710 table lengths and related sizes. Don't update size until alloc
4711 done. Redo calculations to avoid overflow.
4712 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4713
4714 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4715 subtracting pointers.
4716 (gobble_line): Check for overflow more carefully. Don't update size
4717 until alloc done.
4718
4719 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4720 Don't update size until alloc done.
4721 Redo size calculations to avoid overflow.
4722 Check for size calculation overflow.
0065d054 4723 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4724
4725 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4726 Use ptrdiff_t, not int, for sizes.
4727 (store_mode_line_noprop_char): Don't update size until alloc done.
4728
0065d054
PE
4729 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4730 Use ptrdiff_t, not int, for sizes.
4731 (Finternal_make_lisp_face, cache_face):
4732 Check for size calculation overflow.
4733 (cache_face): Treat size calculation overflows as if they were
4734 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4735
4736 * xfns.c (x_encode_text, x_set_name_internal)
4737 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4738 sizes, since they can exceed INT_MAX in size. Check for size
4739 calculation overflow.
4740
0065d054
PE
4741 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4742 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4743 Don't update size until alloc done.
4744
0065d054 4745 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4746 as sprintf is limited to int lengths.
1d526e2f 4747
252c5ee1
PE
4748 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4749 (X_LONG_MIN): New macros.
864d7ce7
PE
4750 Use them to make the following changes clearer.
4751 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4752 This change doesn't affect the value now, but it may help remind
4753 future maintainers not to raise the value too much later.
4754 (SELECTION_QUANTUM): Remove, replacing with ...
4755 (selection_quantum): ... new function, which avoids overflow.
4756 All uses changed.
4757 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4758 assumption that selection length fits in 'int'.
4759 (x_reply_selection_request, x_handle_selection_request)
4760 (x_get_window_property, receive_incremental_selection)
4761 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4762 (lisp_data_to_selection_data, clean_local_selection_data):
4763 Use ptrdiff_t, not int, to record length of selection.
4764 (x_reply_selection_request, x_get_window_property)
4765 (receive_incremental_selection, x_property_data_to_lisp):
4766 Redo calculations to avoid overflow.
4767 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4768 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4769 something.
4770 (x_get_window_property, receive_incremental_selection)
4771 (lisp_data_to_selection_data, x_property_data_to_lisp):
4772 Check for size-calculation overflow.
4773 (x_get_window_property, receive_incremental_selection)
4774 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4775 Don't store size until memory allocation succeeds.
4776 (x_get_window_property): Plug memory leak on memory exhaustion.
4777 Don't double-block input; malloc is safe here. Don't assume 2**34
4778 - 4 fits in unsigned long. Add an xassert to check
4779 XGetWindowProperty overflow. Be more careful about overflow
4780 calculations, and distinguish size from memory overflow better.
4781 (receive_incremental_selection): When tracing, don't assume
4782 unsigned int is less than INT_MAX.
4783 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4784 harmful) conversions of unsigned short to int.
4785 (lisp_data_to_selection_data): Don't assume that integers
4786 in the range -65535 through -1 fit in an X unsigned short.
4787 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4788 result parameters unless successful. Rely on cons_to_unsigned
4789 to report problems with elements; the old code wasn't right anyway.
4790 (x_check_property_data): Check for int overflow; we cannot use
4791 a wider type due to X limits.
4792 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4793
726e0ab1 4794 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4795
0065d054
PE
4796 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4797 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4798 (x_color_cells): Don't store size until memory allocation succeeds.
4799 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4800 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4801 (x_term_init): Don't assume length fits in int (sprintf is limited
4802 to int size).
bc18e09d 4803
ebfa62c0
PE
4804 Use ptrdiff_t for composition IDs.
4805 * character.c (lisp_string_width):
4806 * composite.c (composition_table_size, n_compositions)
4807 (get_composition_id, composition_gstring_from_id):
4808 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4809 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4810 * window.c (Frecenter):
4811 Use ptrdiff_t, not int, for composition IDs.
4812 * composite.c (get_composition_id): Check for integer overflow.
4813 * composite.h: Adjust prototypes to match the above changes.
4814
d3411f89
PE
4815 Use ptrdiff_t for hash table indexes.
4816 * category.c (hash_get_category_set):
4817 * ccl.c (ccl_driver):
4818 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4819 * coding.c (coding_system_charset_list, detect_coding_system):
4820 * coding.h (struct coding_system.id):
4821 * composite.c (get_composition_id, gstring_lookup_cache):
4822 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4823 * image.c (xpm_get_color_table_h):
4824 * lisp.h (hash_lookup, hash_put):
4825 * minibuf.c (Ftest_completion):
4826 Use ptrdiff_t for hash table indexes, not int (which is too
4827 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4828 32-bit --with-wide-int hosts).
4829
e097a6fa
PE
4830 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4831 Add a FIXME comment about memory leaks.
4832 (syms_of_charset): Don't assume xmalloc returns.
4833
5637687f
PE
4834 Don't assume that stated character widths fit in int.
4835 * character.c (Fchar_width, c_string_width, lisp_string_width):
4836 * character.h (CHAR_WIDTH):
4837 * indent.c (MULTIBYTE_BYTES_WIDTH):
4838 Use sanitize_char_width to avoid undefined and/or bad behavior
4839 with outlandish widths.
a66cfb1c 4840 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4841 now that we have two such functions. All uses changed.
4842 (sanitize_char_width): New inline function.
4843
a2271ba2
PE
4844 Don't assume that tab-width fits in int.
4845 * character.h (sanitize_width): New inline function.
4846 (SANE_TAB_WIDTH): New macro.
4847 (ASCII_CHAR_WIDTH): Use it.
4848 * indent.c (sane_tab_width): Remove. All uses replaced by
4849 SANE_TAB_WIDTH (current_buffer).
4850 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4851
18c52557
PE
4852 * fileio.c: Integer overflow issues with file modes.
4853 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4854
caeeedc1
PE
4855 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4856 Remove unreachable code.
4857 (read_hex, load_charset_map_from_file): Check for integer overflow.
4858
6df6ae42 4859 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4860 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4861 (x_send_scroll_bar_event): Likewise. Check that the size does not
4862 exceed limits imposed by XClientMessageEvent, as well as the usual
4863 ptrdiff_t and size_t limits.
4864
b13995db
PE
4865 * keyboard.c: Overflow, signedness and related fixes.
4866 (make_lispy_movement): Use same integer type in forward decl
4867 that is used in the definition.
4868 (read_key_sequence, keyremap_step):
4869 Change bufsize argument back to int, undoing my 2011-03-30 change.
4870 We prefer signed types, and int is wide enough here.
4871 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4872 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4873 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4874 length, not size_t. Use ptrdiff_t for index, not int.
4875 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4876 possibility of integer overflow.
4877
13464394
PE
4878 Overflow, signedness and related fixes for images.
4879
4880 * dispextern.h (struct it.stack[0].u.image.image_id)
4881 (struct_it.image_id, struct image.id, struct image_cache.size)
4882 (struct image_cache.used, struct image_cache.ref_count):
4883 * gtkutil.c (update_frame_tool_bar):
4884 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4885 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4886 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4887 * nsmenu.m (update_frame_tool_bar):
4888 * xdisp.c (calc_pixel_width_or_height):
4889 * xfns.c (image_cache_refcount):
4890 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4891 on typical 64-bit hosts.
4892
4893 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4894 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4895 Omit unnecessary casts to int.
4896 (parse_image_spec): Check that integers fall into 'int' range
4897 when the callers expect that.
4898 (image_ascent): Redo ascent calculation to avoid int overflow.
4899 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4900 (lookup_image): Remove unnecessary tests.
4901 (xbm_image_p): Locals are now of int, not EMACS_INT,
4902 since parse_image_check makes sure they fit into int.
4903 (png_load, gif_load, svg_load_image):
4904 Prefer int to unsigned where either will do.
4905 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4906 old tiff_error_handler and tiff_warning_handler.
4907 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4908 stack buffer overflows. It uses only the features of vsnprintf
4909 that are common to both POSIX and native Microsoft.
4910 (tiff_error_handler, tiff_warning_handler): Use it.
4911 (tiff_load, gif_load, imagemagick_load_image):
4912 Don't assume :index value fits in 'int'.
4913 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4914 (imagemagick_load_image): Check that crop parameters fit into
4915 the integer types that MagickCropImage accepts. Don't assume
4916 Vimagemagick_render_type has a nonnegative value. Don't assume
4917 size_t fits in 'long'.
4918 (gs_load): Use printmax_t to print the widest integers possible.
4919 Check for integer overflow when computing image height and width.
4920
c11821d4
EZ
49212011-08-26 Eli Zaretskii <eliz@gnu.org>
4922
4923 * xdisp.c (redisplay_window): Don't force window start if point
4924 will be invisible in the resulting window. (Bug#9324)
4925
0c95fcf7
EZ
49262011-08-25 Eli Zaretskii <eliz@gnu.org>
4927
4928 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4929 the display spec is of the form `(space ...)'.
4930 (handle_display_spec): Return the value returned by
4931 handle_single_display_spec, not just 1 or zero.
4932 (handle_single_display_spec): If the display spec is of the form
4933 `(space ...)', and specifies display in the text area, return 2
4934 rather than 1.
fee65a97 4935 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4936 accurately, and prefer exact match for point under bidi.
4937 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4938
4939 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4940 into disp_prop; all users changed.
4941
4942 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4943 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4944 for the text covered by the display property.
4945
e4ed06f1
CY
49462011-08-25 Chong Yidong <cyd@stupidchicken.com>
4947
4948 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4949 Change return value to nil.
4950 (Frecord_buffer): Delete unused function.
4951
f67cdd7f
EZ
49522011-08-24 Eli Zaretskii <eliz@gnu.org>
4953
5980d4c6
EZ
4954 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4955 buffers, return left-to-right.
8610fe8b
EZ
4956 (set_cursor_from_row): Consider candidate row a win if its glyph
4957 represents a newline and point is on that newline. Fixes cursor
4958 positioning on the newline at EOL of R2L text within L2R
4959 paragraph, and vice versa.
4960 (try_cursor_movement): Check continued rows, in addition to
4961 continuation rows. Fixes unwarranted scroll when point enters a
4962 continued line of R2L text within an L2R paragraph, or vice versa.
4963 (cursor_row_p): Consider the case of point being equal to
4964 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4965 from the end of a short line to the beginning of a continued line
4966 of R2L text within L2R paragraph.
4967 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4968 composed characters.
5980d4c6 4969
f67cdd7f
EZ
4970 * bidi.c (bidi_check_type): Use xassert.
4971 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4972 members.
4973
bca633fb
EZ
49742011-08-23 Eli Zaretskii <eliz@gnu.org>
4975
4976 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4977 a character.
4978
4a5885a7
CY
49792011-08-23 Chong Yidong <cyd@stupidchicken.com>
4980
4981 * nsfont.m (ns_otf_to_script): Fix typo.
4982
0902a04e
KH
49832011-08-22 Kenichi Handa <handa@m17n.org>
4984
4985 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4986 extra slot even if the purpose is char-code-property-table.
4987
1a2e6670
EZ
49882011-08-23 Eli Zaretskii <eliz@gnu.org>
4989
8ddde651
EZ
4990 * xdisp.c (redisplay_window): When computing centering_position,
4991 account for the height of the header line. (Bug#8874)
4992
425cc014
EZ
4993 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4994 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4995 candidate is selected by the mouse, and that candidate has a
4996 composed character under the mouse.
4997
1a2e6670
EZ
4998 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4999 coordinates reported by pos-visible-in-window-p for a composed
5000 character in column zero.
5001
8b76d6f8
SM
50022011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5003
5004 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5005
dac347dd
EZ
50062011-08-22 Eli Zaretskii <eliz@gnu.org>
5007
5008 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5009 consider it a hit if to_charpos is anywhere in the range of the
5010 composed buffer positions.
5011
e013fb34
CY
50122011-08-22 Chong Yidong <cyd@stupidchicken.com>
5013
5014 * image.c (gif_load): Don't assume that each subimage has the same
5015 dimensions as the base image. Handle disposal method that is
5016 "undefined" by the gif spec (Bug#9335).
5017
bd1ba3e8
CY
50182011-08-20 Chong Yidong <cyd@stupidchicken.com>
5019
5020 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5021 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5022
54a1215b
EZ
50232011-08-19 Eli Zaretskii <eliz@gnu.org>
5024
823564e5
EZ
5025 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5026 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5027 from an Org mode buffer to a Speedbar frame.
5028
54a1215b
EZ
5029 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5030 a composition, take its buffer position from IT->cmp_it.charpos.
5031 Fixes cursor positioning at the beginning of a line that begins
5032 with a composed character.
5033
9778ebcc
EZ
50342011-08-18 Eli Zaretskii <eliz@gnu.org>
5035
0be6ee06
EZ
5036 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5037 character bidirectional type, use STRONG_L instead. Fixes crashes
5038 in a buffer produced by `describe-categories'.
5039
9778ebcc
EZ
5040 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5041 members before the level stack, so they would be saved and
5042 restored when copying iterator state. Fixes incorrect reordering
5043 around TABs covered by display properties.
5044
156bffbe
AS
50452011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5046
6b02f655 5047 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5048
72ad093b
CY
50492011-08-17 Chong Yidong <cyd@stupidchicken.com>
5050
5051 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5052 (internal_condition_case_2, internal_condition_case_n):
5053 Remove unnecessary aborts (Bug#9081).
72ad093b 5054
35774242
EZ
50552011-08-17 Eli Zaretskii <eliz@gnu.org>
5056
5057 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5058 has no `load' handler, try opening the file locally. (Bug#9311)
5059
db76dd85
KB
50602011-08-16 Ken Brown <kbrown@cornell.edu>
5061
5062 * gmalloc.c: Expand comment.
5063
b215eee5
EZ
50642011-08-16 Eli Zaretskii <eliz@gnu.org>
5065
5066 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5067 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5068
a4579d33
KB
50692011-08-16 Ken Brown <kbrown@cornell.edu>
5070
5071 Fix memory allocation problems in Cygwin build (Bug#9273).
5072
5073 * unexcw.c ( __malloc_initialized): Declare external variable.
5074 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5075
8b76d6f8
SM
5076 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5077 New variables.
a4579d33
KB
5078 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5079 dumped emacs.
5080 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5081 in the static heap.
5082 [CYGWIN] (special_realloc): New function.
5083 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5084 requests to realloc storage in the static heap.
5085
3ebec551
PE
50862011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5087
5088 * bidi.c (bidi_initialize): Remove unused local.
5089
9fd8be00
EZ
50902011-08-15 Eli Zaretskii <eliz@gnu.org>
5091
6b02f655
SM
5092 * bidimirror.h:
5093 * biditype.h: Remove file.
5094 * makefile.w32-in ($(BLD)/bidi.$(O)):
5095 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5096
5097 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5098
5099 * chartab.c: Improve commentary for the uniprop_table API.
5100
32413314
EZ
5101 * bidi.c (bidi_paragraph_init): Support zero value of
5102 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5103 (bidi_initialize): Use uniprop_table instead of including
5104 biditype.h and bidimirror.h.
32413314 5105
9fd8be00
EZ
5106 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5107 coordinates of the iterator when restoring from ppos_it.
5108 (Bug#9296)
5109
5cf2b69b
KH
51102011-08-14 Kenichi Handa <handa@m17n.org>
5111
5112 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5113 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5114
daf17d00
EZ
51152011-08-14 Eli Zaretskii <eliz@gnu.org>
5116
5117 * xdisp.c (move_it_in_display_line_to): Don't invoke
5118 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5119 ppos_it. Fixes vertical cursor motion when line beginning is
5120 covered by an image. (Bug#9296)
5121
08e3161a
JD
51222011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5123
5124 * nsterm.h (ns_run_ascript): Declare.
5125 (NSAPP_DATA2_RUNASSCRIPT): Define.
5126
5127 * nsfns.m (as_script, as_result, as_status): New static variables.
5128 (ns_run_ascript): New function.
5e617bc2 5129 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5130 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5131 the event loop. Get status from as_status (Bug#7276).
5132
5133 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5134 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5135 the event loop (Bug#7276).
5136
a3720aa2
AS
51372011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5138
5139 * gnutls.c (QCgnutls_bootprop_priority)
5140 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5141 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5142 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5143 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5144 (QCgnutls_bootprop_verify_hostname_error)
5145 (QCgnutls_bootprop_callbacks_verify): Rename from
5146 Qgnutls_bootprop_..., all uses changed.
5147
5148 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5149 uses changed.
5150
0a0d27fb
PE
51512011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5152
19d5c50c
PE
5153 * xfaces.c (Qframe_set_background_mode): Now static.
5154 * dispextern.h (Qframe_set_background_mode): Remove decl.
5155
0a0d27fb
PE
5156 * process.c (Fnetwork_interface_info): Declare local only if needed.
5157
377538cb
JD
51582011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5159
5160 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5161 (Fnetwork_interface_list): Allocate in increments of bytes instead
5162 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5163 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5164 sockaddr.
5165 (struct ifflag_def): notrailers is smart on OSX.
5166 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5167 Get hardware address with getifaddrs if available.
5168
08fff70c
EZ
51692011-08-12 Eli Zaretskii <eliz@gnu.org>
5170
5171 * xdisp.c (iterate_out_of_display_property): xassert that
5172 IT->position is set to within IT->object's boundaries. Break from
5173 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5174 when IT->position is set up wrongly due to some bug.
5175 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5176 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5177 entry. Force push_it to save on the stack the current
5178 buffer/string position, to be restored by pop_it. Fix flags in
5179 the iterator structure wrt the object coming from a display
5180 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5181 properties. (Bug#9284)
5182
7be1c708 51832011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5184
7be1c708
CY
5185 * fontset.c (fontset_get_font_group): Add proper type checks.
5186 (Bug#9172)
aac0c6e3 5187
7be1c708 51882011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5189
7be1c708
CY
5190 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5191 and LC_VERSION_MIN_MACOSX.
5192 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5193 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5194
97bb72a6
EZ
51952011-08-08 Eli Zaretskii <eliz@gnu.org>
5196
5197 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5198 no-display-properties-and-no-overlays under bidi display.
5199 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5200 properties and overlays.
97bb72a6 5201
d5617611
CY
52022011-08-08 Chong Yidong <cyd@stupidchicken.com>
5203
37e11a63
CY
5204 * editfns.c (Fset_time_zone_rule): Document relationship with the
5205 setenv function.
5206
d5617611
CY
5207 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5208 the font entity extracted from the cache (Bug#8109).
5209
58872834
CY
52102011-08-07 Chong Yidong <cyd@stupidchicken.com>
5211
5212 * composite.c (autocmp_chars): Don't reset point. That is done by
5213 restore_point_unwind (Bug#5984).
5214
75bfc667
JL
52152011-08-07 Juri Linkov <juri@jurta.org>
5216
5217 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5218 to show the arg `TIME' instead of `TIMEVAL'.
5219
d1410150
EZ
52202011-08-06 Eli Zaretskii <eliz@gnu.org>
5221
5222 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5223 display property strides EOL and includes a newline, as in
5224 longlines-mode. (Bug#9254)
75b771e4
EZ
5225 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5226 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5227
5228 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5229 is non-zero, even if the data buffer is NULL. Fixes a crash in
5230 vertical-motion with longlines-mode. (Bug#9254)
5231
35928349
EZ
52322011-08-05 Eli Zaretskii <eliz@gnu.org>
5233
ec7cc85b
EZ
5234 * bidi.c <bidi_cache_total_alloc>: Now static.
5235 (bidi_initialize): Initialize bidi_cache_total_alloc.
5236
8b76d6f8 5237 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5238 cache. (Bug#9221)
5239
5240 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5241 amount allocated this far in `bidi_cache_total_alloc'.
5242 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5243 non-zero, only free the data buffer without restoring the cache
5244 contents. All callers changed.
5245
5246 * dispextern.h (bidi_unshelve_cache): Update prototype.
5247
5248 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5249 (move_it_in_display_line, move_it_to)
5250 (move_it_vertically_backward, move_it_by_lines): Replace the call
5251 to xfree to an equivalent call to bidi_unshelve_cache.
5252 (move_it_in_display_line_to): Fix logic of returning
412b6358 5253 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5254
e2e2423b
EZ
52552011-08-05 Eli Zaretskii <eliz@gnu.org>
5256
5257 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5258 came from a string character with a `cursor' property. (Bug#9229)
5259
ae9e757a
JD
52602011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5261
5262 * Makefile.in (LIB_PTHREAD): New variable.
5263 (LIBES): Add LIB_PTHREAD (Bug#9216).
5264
5265 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5266 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5267
213bd7f2
AS
52682011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5269
6b02f655 5270 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5271
99aaf75f
JD
52722011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5273
5274 * xterm.c (x_find_topmost_parent): New function.
5275 (x_set_frame_alpha): Find topmost parent window with
5276 x_find_topmost_parent and set the property there also (bug#9181).
5277 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5278
c74e9d86
PE
52792011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 * callproc.c (Fcall_process): Avoid vfork clobbering
5282 the local vars buffer, coding_systems, current_dir.
5283
640c8776
SM
52842011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5285
5286 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5287
f26d0e4c
PE
52882011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5289
8a10d76c
PE
5290 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5291 so that it is not optimized away.
5292
f26d0e4c
PE
5293 * xdisp.c (compute_display_string_pos): Remove unused local.
5294
55439c61
EZ
52952011-08-02 Eli Zaretskii <eliz@gnu.org>
5296
5297 Fix slow cursor motion and scrolling in large buffers with
5298 selective display, like Org Mode buffers. (Bug#9218)
5299
5300 * dispextern.h (struct bidi_it): New member disp_prop_p.
5301
5302 * xdisp.c: Remove one-slot cache of display string positions.
5303 (compute_display_string_pos): Accept an additional argument
5e617bc2 5304 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5305 for a display string or property. If found, set DISP_PROP_P
5306 non-zero.
5307
5308 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5309 DISP_PROP_P, and pass it to compute_display_string_pos.
5310 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5311 non-zero. All callers of bidi_fetch_char changed.
5312
fb33fa43
SM
53132011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5314
5315 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5316
b099e063
DM
53172010-12-03 Don March <don@ohspite.net>
5318
5319 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5320 last character M-[char] is translated to ESC [char] (bug#7541).
5321
5cc7f7af
KH
53222011-08-02 Kenichi Handa <handa@m17n.org>
5323
d0fffa3f 5324 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5325
5326 * chartab.c (uniprop_table): Make it non-static.
5327
525d5e6e
EZ
53282011-08-01 Eli Zaretskii <eliz@gnu.org>
5329
5330 * xdisp.c (forward_to_next_line_start): Accept additional argument
5331 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5332 on the newline.
5333 (reseat_at_next_visible_line_start): Use the bidi iterator state
5334 returned by forward_to_next_line_start to restore the state of
5335 it->bidi_it after backing up to previous newline. (Bug#9212)
5336
31011111
AS
53372011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5338
5339 * regex.c (re_comp): Protoize.
5340 (re_exec): Fix return type.
5341 (regexec): Fix type of `ret'. (Bug#9203)
5342
476371c4
PE
53432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5344
e5d76069
PE
5345 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5346 This is needed if max-image-size is a floating-point number.
5347
9a79b20c
AS
53482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5349
5350 * print.c (print_object): Print empty symbol as ##.
5351
5352 * lread.c (read1): Read ## as empty symbol.
5353
d8c2fa78
AA
53542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5355
5356 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5357 setting frame foreground color (Bug#9175).
5358 (x_set_background_color): Likewise.
5359
ffe57a7a
AA
5360 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5361 contents (Bug#9176).
5362 (EmacsTooltip -init): Remove bezels and add shadows to
5363 tooltip windows.
5364
bf3492a5
AA
5365 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5366 or scroll bar (Bug#8470).
5367
d55e9c53
AA
5368 * nsfont.m (nsfont_open): Remove assignment to voffset and
5369 unnecessary vars hshink, expand, hd, full_height, min_height.
5370 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5371
5372 * nsterm.h (nsfont_info): Remove voffset field.
5373
d8c2fa78 53742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5375
5376 Implement strike-through and overline on NextStep (Bug#8863).
5377
5378 * nsfont.m (nsfont_open): Use underline position provided by font,
5379 instead of hard-coded value of 2.
5380 (nsfont_draw): Call ns_draw_text_decoration instead.
5381
5382 * nsterm.h: Add declaration for ns_draw_text_decoration.
5383
5384 * nsterm.m (ns_draw_text_decoration): New function for drawing
5385 underline, overline, and strike-through.
5386 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5387 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5388 accommodate underlining, etc.
4843aac3 5389
4cc60b9b
EZ
53902011-07-28 Eli Zaretskii <eliz@gnu.org>
5391
bc7ece87
EZ
5392 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5393 default.
4cc60b9b 5394
476371c4
PE
53952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5396
66606eea
PE
5397 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5398 Without this fix, if a signal arrives just after memory fills up,
5399 'malloc' might be invoked reentrantly.
5400
476371c4
PE
5401 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5402 In other words, assume that every image size is allowed, on non-X
5403 hosts. This assumption is probably wrong, but it lets Emacs compile.
5404
f3fcc40d
AS
54052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5406
5407 * regex.c (re_iswctype): Convert return values to boolean.
5408
350c992f
EZ
54092011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5410
5411 * xdisp.c (compute_display_string_pos): Don't use cached display
5412 string position if the buffer had its restriction changed.
5413 (Bug#9184)
5414
5266b4bb
PE
54152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5416
5417 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5418
2573a837 54192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5420
41f55ccd 5421 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5422
39e378da
PE
5423 * bidi.c: Integer size and overflow fixes.
5424 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5425 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5426 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5427 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5428 (bidi_find_other_level_edge):
5429 Use ptrdiff_t instead of EMACS_INT where either will do.
5430 This works better on 32-bit hosts configured --with-wide-int.
5431 (bidi_cache_ensure_space): Check for size-calculation overflow.
5432 Use % rather than repeated addition, for better worst-case speed.
5433 Don't set bidi_cache_size until after xrealloc returns, because it
5434 might not return.
5435 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5436 (bidi_cache_ensure_space): Also check that the bidi cache size
5437 does not exceed that of the largest Lisp string or buffer. See Eli
5438 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5439
5e927815
PE
5440 * alloc.c (__malloc_size_t): Remove.
5441 All uses replaced by size_t. See Andreas Schwab's note
5442 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5443
ca4aa935
PE
5444 * image.c: Improve checking for integer overflow.
5445 (check_image_size): Assume that f is nonnull, since
5446 it is always nonnull in practice. This is one less thing to
5447 worry about when checking for integer overflow later.
5448 (x_check_image_size): New function, which checks for integer
5449 overflow issues inside X.
5450 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5451 This removes the need for a memory_full check.
5452 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5453 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5454 (xbm_read_bitmap_data): Change locals back to 'int', since
5455 their values must fit in 'int'.
5456 (xpm_load_image, png_load, tiff_load):
5457 Invoke x_create_x_image_and_pixmap earlier,
5458 to avoid much needless work if the image is too large.
5459 (tiff_load): Treat overly large images as if
5460 x_create_x_image_and_pixmap failed, not as malloc failures.
5461 (gs_load): Use x_check_image_size.
5462
5f8f9cc2
PE
5463 * gtkutil.c: Omit integer casts.
5464 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5465 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5466
5adf60bc
PE
5467 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5468
c8907a93
PE
5469 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5470 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5471 would wrongly return t on a 64-bit host.
5472
e3c25c68
PE
5473 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5474 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5475 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5476 and therefore cause GCC to emit a bogus diagnostic in some cases.
5477
3f791afe
PE
5478 * image.c: Integer signedness and overflow and related fixes.
5479 This is not an exhaustive set of fixes, but it's time to
5480 record what I've got.
5481 (lookup_pixel_color, check_image_size): Remove redundant decls.
5482 (check_image_size): Don't assume that arbitrary EMACS_INT values
5483 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5484 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5485 (tiff_load, imagemagick_load_image):
5486 Check for overflow in size calculations.
5487 (x_create_x_image_and_pixmap): Remove unnecessary test for
5488 xmalloc returning NULL; that can't happen.
5489 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5490 (xpm_color_bucket): Use better integer hashing function.
5491 (xpm_cache_color): Don't possibly over-allocate memory.
5492 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5493 (gif_memory_source):
5494 Use ptrdiff_t, not int or size_t, to record sizes.
5495 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5496 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5497 either works, as we prefer signed integers.
5498 (tiff_read_from_memory, tiff_write_from_memory):
5499 Return tsize_t, not size_t, since that's what the TIFF API wants.
5500 (tiff_read_from_memory): Don't fail simply because the read would
5501 go past EOF; instead, return a short read.
5502 (tiff_load): Omit no-longer-needed casts.
5503 (Fimagemagick_types): Don't assume size fits into 'int'.
5504
3cc5a532
PE
5505 Improve hashing quality when configured --with-wide-int.
5506 * fns.c (hash_string): New function, taken from sxhash_string.
5507 Do not discard information about ASCII character case; this
5508 discarding is no longer needed.
5509 (sxhash-string): Use it. Change sig to match it. Caller changed.
5510 * lisp.h: Declare it.
5511 * lread.c (hash_string): Remove, since we now use fns.c's version.
5512 The fns.c version returns a wider integer if --with-wide-int is
5513 specified, so this should help the quality of the hashing a bit.
5514
b312a492
PE
5515 * emacs.c: Integer overflow minor fix.
5516 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5517 Define only if GNU_LINUX.
5518 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5519
dfd153ae
PE
5520 * dispnew.c: Integer signedness and overflow fixes.
5521 Remove unnecessary forward decls, that were a maintenance hassle.
5522 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5523 All uses changed.
5524 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5525 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5526 (prepare_desired_row, line_draw_cost):
5527 Use int, not unsigned, where either works.
5528 (save_current_matrix, restore_current_matrix):
5529 Use ptrdiff_t, not size_t, where either works.
5530 (init_display): Check for overflow more accurately, and without
5531 relying on undefined behavior.
5532
a81d11a3
PE
5533 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5534 Remove, replacing with the new symbols in lisp.h. All uses changed.
5535 * fileio.c (make_temp_name):
5536 * filelock.c (lock_file_1, lock_file):
5537 * xdisp.c (message_dolog):
5538 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5539 Use pMd etc. instead.
5540 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5541 replacing the pWIDE etc. symbols removed from editfns.c.
5542
3300e6fd
PE
5543 * keyboard.h (num_input_events): Now uintmax_t.
5544 This is (very slightly) less likely to mess up due to wraparound.
5545 All uses changed.
5546
fd05c7e9
PE
5547 * buffer.c: Integer signedness fixes.
5548 (alloc_buffer_text, enlarge_buffer_text):
5549 Use ptrdiff_t rather than size_t when either will do, as we prefer
5550 signed integers.
5551
903fe15d
PE
5552 * alloc.c: Integer signedness and overflow fixes.
5553 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5554 (__malloc_size_t): Default to size_t, not to int.
5555 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5556 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5557 Prefer ptrdiff_t to size_t when either would do, as we prefer
5558 signed integers.
5559 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5560 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5561 Now const. Initialize with values that are in range even if char
5562 is signed.
5563 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5564 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5565 These functions do the right thing with sizes > 2**32.
5566 (check_depth): Now ptrdiff_t, not int.
5567 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5568 Adjust to new way of storing sizes. Check for size overflow bugs
5569 in rest of code.
5570 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5571 slightly wrong anyway, as it missed one instance of
5572 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5573 (refill_memory_reserve): Omit needless cast to size_t.
5574 (mark_object_loop_halt): Mark as externally visible.
5575
ac82cc6a
PE
5576 * xselect.c: Integer signedness and overflow fixes.
5577 (Fx_register_dnd_atom, x_handle_dnd_message):
5578 Use ptrdiff_t, not size_t, since we prefer signed.
5579 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5580 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5581 x_dnd_atoms_size and x_dnd_atoms_length.
5582
c2d1e36d
PE
5583 * doprnt.c: Prefer signed to unsigned when either works.
5584 * eval.c (verror):
5585 * doprnt.c (doprnt):
5586 * lisp.h (doprnt):
5587 * xdisp.c (vmessage):
5588 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5589 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5590 prefer signed arithmetic to avoid comparison confusion.
5591 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5592 but is a bit tricky.
5593
0e926e56
PE
5594 Assume freestanding C89 headers, string.h, stdlib.h.
5595 * data.c, doprnt.c, floatfns.c, print.c:
5596 Include float.h unconditionally.
5597 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5598 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5599 * regex.c: Likewise for stddef.h, string.h.
5600 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5601 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5602 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5603 (STDC_HEADERS): Remove obsolete defines.
5604 * sysdep.c: Include limits.h unconditionally.
5605
9cfdb3ec
PE
5606 Assume support for memcmp, memcpy, memmove, memset.
5607 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5608 * regex.c (memcmp, memcpy):
5609 Remove; we assume C89 now.
5610
5611 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5612 (__malloc_safe_bcopy): Remove; no longer needed.
5613
cf950e6b 5614 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5615 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5616 well either way, and we prefer signed to unsigned.
5617
dbf38e02
LMI
56182011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5619
5620 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5621 closes the connection while we're reading (bug#9182).
5622
d6f0886c 56232011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5624
d6f0886c
JD
5625 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5626 are specified (Bug#9168).
24e0f6b1 5627
2eb1f9e6
PE
56282011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5629
5630 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5631 Found by GCC static checking and --with-wide-int on a 32-bit host.
5632
22381272 56332011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5634
5635 * xdisp.c (compute_display_string_pos): Fix logic of caching
5636 previous display string position. Initialize cached_prev_pos to
5637 -1. Fixes slow-down at the beginning of a buffer.
5638
f25e39b4
EZ
56392011-07-24 Eli Zaretskii <eliz@gnu.org>
5640
5641 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5642 for attrs[LFACE_FONTSET_INDEX].
5643
04c4b52e
PE
56442011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 * xml.c (parse_region): Remove unused local
5647 that was recently introduced.
5648
c1734fbd
EZ
56492011-07-23 Eli Zaretskii <eliz@gnu.org>
5650
be18c5a5
EZ
5651 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5652 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5653
c1734fbd
EZ
5654 * xdisp.c (move_it_in_display_line_to): Record the best matching
5655 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5656 exit if none of the characters scanned was an exact match.
5657 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5658 when exact match is impossible due to invisible text, and the
5659 lines are truncated.
5660
a258d627
JD
56612011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5662
5663 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5664 for OSX >= 10.7.
5665
b6d5a689
EZ
56662011-07-22 Eli Zaretskii <eliz@gnu.org>
5667
0f74f785
EZ
5668 Fix a significant slow-down of cursor motion with C-n, C-p,
5669 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5670 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5671 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5672 (next_element_from_buffer): Call compute_stop_pos_backwards to
5673 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5674 base_level_stop.
5675 (reseat): Don't look for prev_stop, as that could mean a very long
5676 run.
5677 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5678 <cached_disp_overlay_modiff>: Cache for last found display string
5679 position.
551918c1 5680 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5681 about the same buffer in the same area of character positions, and
5682 the buffer wasn't changed since the time the display string
5683 position was cached.
551918c1 5684
b2d0c91a
EZ
56852011-07-22 Eli Zaretskii <eliz@gnu.org>
5686
5687 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5688 is an integer, which is important for empty lines. (Bug#9149)
5689
043604ee
CY
56902011-07-22 Chong Yidong <cyd@stupidchicken.com>
5691
5692 * frame.c (Fmodify_frame_parameters): In tty case, update the
5693 default face if necessary (Bug#4238).
5694
da4adb04
CY
56952011-07-21 Chong Yidong <cyd@stupidchicken.com>
5696
5697 * editfns.c (Fstring_to_char): No need to explain what a character
5698 is in the docstring (Bug#6576).
5699
9abd0532
LMI
57002011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5701
5702 * xml.c (parse_region): Make sure we always return a tree.
5703
36881d16
HK
57042011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5705
5706 * xml.c (parse_region): If a document contains only comments,
5707 return that, too.
5708
1e98674d
LMI
57092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5710
5711 * xml.c (make_dom): Return comments, too.
5712
590bd467
PE
57132011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5714
5715 Port to OpenBSD.
5716 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5717 and the surrounding thread.
5718 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5719 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5720 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5721 timer goes off.
5722 * s/openbsd.h (BROKEN_SIGIO): Define.
5723 * unexelf.c (unexec) [__OpenBSD__]:
5724 Don't update the .mdebug section of the Alpha COFF symbol table.
5725
f41628b2
LMI
57262011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5727
5728 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5729 (bug#8460).
5730
b59b67c5
PE
57312011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5732
15e3a074
PE
5733 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5734 This fixes some race conditions on the permissions of any newly
5735 created file.
5736
41bed37d
PE
5737 * alloc.c (valid_pointer_p): Use pipe, not open.
5738 This fixes some permissions issues when debugging.
5739
b59b67c5
PE
5740 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5741 If fchown fails to set both uid and gid, try to set just gid,
5742 as that is sometimes allowed. Adjust the file's mode to eliminate
5743 setuid or setgid bits that are inappropriate if fchown fails.
5744
925a6be7
SM
57452011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5746
5747 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5748 to compare Lisp_Objects.
5749 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5750 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5751 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5752
52968808
AS
57532011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5754
0a6a104b
AS
5755 * lread.c (read_integer): Unread even EOF character.
5756 (read1): Likewise. Properly record start position of symbol.
5757
52968808
AS
5758 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5759 symbol character follows.
5760
9e381cdd
PE
57612011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5762
5763 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5764 This works around a problem with the previous change to Fcopy_file.
5765 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5766 and without this change, GCC might complain about discarding
5767 fchown's return value.
5768
b5641435
JB
57692011-07-16 Juanma Barranquero <lekktu@gmail.com>
5770
5771 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5772
a8031457
PE
57732011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5774
5775 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5776
dd889327
LMI
57772011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5778
750c33f7
LMI
5779 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5780 it's used from the C level.
5781
dd889327
LMI
5782 * process.c: Use the same condition for POLL_FOR_INPUT in both
5783 keyboard.c and process.c (bug#1858).
5784
87e86684
LM
57852011-07-09 Lawrence Mitchell <wence@gmx.li>
5786
5787 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5788 (Fgnutls_boot): Use it.
5789
64348f40
AS
57902011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5791
5792 * doc.c (Fsubstitute_command_keys): Revert last change.
5793
1d698799
LMI
57942011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5795
f863868c
LMI
5796 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5797 quotes the next character, and doesn't affect other longer
5798 sequences (bug#8935).
5799
1d698799
LMI
5800 * lread.c (syms_of_lread): Clarify that is isn't only
5801 `eval-buffer' and `eval-defun' that's affected by
5802 `lexical-binding' (bug#8460).
5803
aa4b6df6
EZ
58042011-07-15 Eli Zaretskii <eliz@gnu.org>
5805
5806 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5807 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5808
5d856da6
PE
58092011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5810
ad6042bb
PE
5811 Fix minor problems found by static checking.
5812 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5813 (elsz): Now a signed constant, not a size_t var. We prefer signed
5814 types to unsigned, to avoid integer comparison confusion. Without
5815 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5816 "cannot optimize loop, the loop counter may overflow", a symptom
5817 of the confusion.
f00bbb22 5818 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5819 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5820
6468f31c
LMI
58212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5822
49080b10
LMI
5823 * search.c (Fre_search_backward): Mention `case-fold-search' in
5824 all the re_search_* functions (bug#8138).
5825
6468f31c
LMI
5826 * keyboard.c (Fopen_dribble_file): Document when the file is
5827 closed (bug#8056).
5828
c965adc5
EZ
58292011-07-14 Eli Zaretskii <eliz@gnu.org>
5830
df9733bf
EZ
5831 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5832 bidi_cache_idx.
5833
0bb23927
EZ
5834 Support bidi reordering of display and overlay strings.
5835 * xdisp.c (compute_display_string_pos)
5836 (compute_display_string_end): Accept additional argument STRING.
5837 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5838 (reseat_to_string): Initialize bidi_it->string.s and
5839 bidi_it->string.schars.
5840 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5841 NULL (avoids a crash in bidi_paragraph_init).
5842 Initialize itb.string.lstring.
0bb23927
EZ
5843 (init_iterator): Call bidi_init_it only of a valid
5844 buffer position was specified. Initialize paragraph_embedding to
5845 L2R.
5846 (reseat_to_string): Initialize the bidi iterator.
5847 (display_string): If we need to ignore text properties of
5848 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5849 original value of -1 will not work with bidi.)
5850 (compute_display_string_pos): First arg is now struct
5851 `text_pos *'; all callers changed. Support display properties on
5852 Lisp strings.
5853 (compute_display_string_end): Support display properties on Lisp
5854 strings.
5855 (init_iterator, reseat_1, reseat_to_string): Initialize the
5856 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5857 when iterating on a string not from display properties).
640c8776
SM
5858 (compute_display_string_pos, compute_display_string_end):
5859 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5860 arrow keys.
5861 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5862 base_level_stop; instead, set base_level_stop to BEGV.
5863 Fixes crashes in vertical-motion.
0bb23927
EZ
5864 (next_element_from_buffer): Improve commentary for when
5865 the iterator is before prev_stop.
5866 (init_iterator): Initialize bidi_p from the default value of
5867 bidi-display-reordering, not from buffer-local value. Use the
5868 buffer-local value only if initializing for buffer iteration.
5869 (handle_invisible_prop): Support invisible properties on strings
5870 that are being bidi-reordered.
5871 (set_iterator_to_next): Support bidi reordering of C strings and
5872 Lisp strings.
5873 (next_element_from_string): Support bidi reordering of Lisp
5874 strings.
5875 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5876 (display_string): Support display of R2L glyph rows.
5877 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5878 (init_iterator): Don't initialize it->bidi_p for strings
5879 here.
5880 (reseat_to_string): Initialize it->bidi_p for strings here.
5881 (next_element_from_string, next_element_from_c_string)
5882 (next_element_from_buffer): Add xassert's for correspondence
5883 between IT's object being iterated and it->bidi_it.string
5884 structure.
5885 (face_before_or_after_it_pos): Support bidi iteration.
5886 (next_element_from_c_string): Handle the case of the first string
5887 character that is not the first one in the visual order.
5888 (get_visually_first_element): New function, refactored from common
5889 parts of next_element_from_buffer, next_element_from_string, and
5890 next_element_from_c_string.
5891 (tool_bar_lines_needed, redisplay_tool_bar)
5892 (display_menu_bar): Force left-to-right direction. Add a FIXME
5893 comment for making that be controlled by a user option.
5894 (push_it, pop_it): Save and restore the state of the
5895 bidi iterator. Save and restore the bidi_p flag.
5896 (pop_it): Iterate out of display property for string iteration as
5897 well.
5898 (iterate_out_of_display_property): Support iteration over strings.
5899 (handle_single_display_spec): Set up it->bidi_it for iteration
5900 over a display string, and call bidi_init_it.
5901 (handle_single_display_spec, next_overlay_string)
5902 (get_overlay_strings_1, push_display_prop): Set up the bidi
5903 iterator for displaying display or overlay strings.
5904 (forward_to_next_line_start): Don't use the shortcut if
5905 bidi-iterating.
5906 (back_to_previous_visible_line_start): If handle_display_prop
5907 pushed the iterator stack, restore the internal state of the bidi
5908 iterator by calling bidi_pop_it same number of times.
5909 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5910 and we are bidi-iterating, don't decrement the iterator position;
5911 instead, set the first_elt flag in the bidi iterator, to produce
5912 the same effect.
5913 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5914 (push_display_prop): xassert that we are iterating a buffer.
5915 (push_it, pop_it): Save and restore paragraph_embedding member.
5916 (handle_single_display_spec, next_overlay_string)
5917 (get_overlay_strings_1, reseat_1, reseat_to_string)
5918 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5919 correctly. Don't assume unibyte strings are not bidi-reordered.
5920 (compute_display_string_pos)
5921 (compute_display_string_end): Fix handling the case of C string.
5922 (push_it, pop_it): Save and restore from_disp_prop_p.
5923 (handle_single_display_spec, push_display_prop): Set the
5924 from_disp_prop_p flag.
5925 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5926 (pop_it): Call iterate_out_of_display_property only if we are
5927 popping after iteration over a string that came from a display
5928 property. Fix a typo in popping stretch info. Add an assertion
5929 for verifying that the iterator position is in sync with the bidi
5930 iterator.
5931 (handle_single_display_spec, get_overlay_strings_1)
5932 (push_display_prop): Fix initialization of paragraph direction for
5933 string when that of the parent object is not yet determined.
5934 (reseat_1): Call bidi_init_it to resync the bidi
5935 iterator with IT's position. (Bug#7616)
5936 (find_row_edges): If ROW->start.pos gives position
5937 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5938 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5939 Reset the from_disp_prop_p flag.
5940 (SAVE_IT, RESTORE_IT): New macros.
5941 (pos_visible_p, face_before_or_after_it_pos)
5942 (back_to_previous_visible_line_start)
5943 (move_it_in_display_line_to, move_it_in_display_line)
5944 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5945 (try_scrolling, redisplay_window, display_line): Use them when
5946 saving a temporary copy of the iterator and restoring it back.
5947 (back_to_previous_visible_line_start, reseat_1)
5948 (init_iterator): Empty the bidi cache "stack".
5949 (move_it_in_display_line_to): If iterator ended up at
5950 EOL, but we never saw any buffer positions smaller than
5951 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5952 motion in bidi-reordered lines.
5953 (move_it_in_display_line_to): Record prev_method and prev_pos
5954 immediately before the call to set_iterator_to_next. Fixes cursor
5955 motion in bidi-reordered lines with stretch glyphs and strings
5956 displayed in margins. (Bug#8133) (Bug#8867)
5957 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5958 TO_CHARPOS.
640c8776
SM
5959 (pos_visible_p): Support positions in bidi-reordered lines.
5960 Save and restore bidi cache.
0bb23927
EZ
5961
5962 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5963 (bidi_paragraph_info): Delete unused struct.
5964 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5965 (bidi_cache_start): New variable.
5966 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5967 to zero.
5968 (bidi_cache_fetch_state, bidi_cache_search)
5969 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5970 (bidi_cache_find, bidi_peek_at_next_level)
5971 (bidi_level_of_next_char, bidi_find_other_level_edge)
5972 (bidi_move_to_visually_next): Compare cache index with
5973 bidi_cache_start rather than with zero.
5974 (bidi_fetch_char): Accept new argument STRING; all callers
5975 changed. Support iteration over a string. Support strings with
5976 display properties. Support unibyte strings. Fix the type of
5977 `len' according to what STRING_CHAR_AND_LENGTH expects.
5978 (bidi_paragraph_init, bidi_resolve_explicit_1)
5979 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5980 (bidi_level_of_next_char, bidi_move_to_visually_next):
5981 Support iteration over a string.
0bb23927
EZ
5982 (bidi_set_sor_type, bidi_resolve_explicit_1)
5983 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5984 can now be zero (for strings); special values 0 and -1 were
5985 changed to -1 and -2, respectively.
5986 (bidi_char_at_pos): New function.
5987 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5988 Call it instead of FETCH_MULTIBYTE_CHAR.
5989 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5990 initialized to valid values.
5991 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5992 values.
5993 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5994 the test for valid cached positions. Fix the logic for looking up
5995 the sentinel state in the cache. GCPRO the Lisp string we are
5996 iterating.
5997 (bidi_push_it, bidi_pop_it): New functions.
5998 (bidi_initialize): Initialize the bidi cache start stack pointer.
5999 (bidi_cache_ensure_space): New function, refactored from part of
6000 bidi_cache_iterator_state. Don't assume the required size is just
6001 one BIDI_CACHE_CHUNK away.
6002 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6003 (bidi_count_bytes, bidi_char_at_pos): New functions.
6004 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6005 always valid if bidi_cache_idx is valid.
6006 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6007 is valid if it's going to be used.
6008 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6009 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6010 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6011 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6012 (bidi_find_other_level_edge, bidi_cache_start_stack):
6013 All variables related to cache indices are now EMACS_INT.
c965adc5 6014
0bb23927
EZ
6015 * dispextern.h (struct bidi_string_data): New structure.
6016 (struct bidi_it): New member `string'. Make flag members be 1-bit
6017 fields, and put them last in the struct.
640c8776
SM
6018 (compute_display_string_pos, compute_display_string_end):
6019 Update prototypes.
0bb23927
EZ
6020 (bidi_push_it, bidi_pop_it): Add prototypes.
6021 (struct iterator_stack_entry): New members bidi_p,
6022 paragraph_embedding, and from_disp_prop_p.
6023 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6024 (bidi_shelve_cache, bidi_unshelve_cache):
6025 Declare prototypes.
0bb23927
EZ
6026
6027 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6028 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6029 and vector-like objects.
6030
6031 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6032 cache around display iteration.
6033
6034 * window.c (Fwindow_end, window_scroll_pixel_based)
6035 (displayed_window_lines, Frecenter): Save and restore the bidi
6036 cache around display iteration.
6037
3bbd2265
LMI
60382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6039
6040 * editfns.c (Fdelete_region): Clarify the use of the named
6041 parameters (bug#6788).
6042
adc47434
MR
60432011-07-14 Martin Rudalics <rudalics@gmx.at>
6044
6045 * indent.c (Fvertical_motion): Set and restore w->pointm when
6046 saving and restoring the window's buffer (Bug#9006).
6047
837c31f8
LMI
60482011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6049
6050 * editfns.c (Fstring_to_char): Clarify just what is returned
6051 (bug#6576). Text by Eli Zaretskii.
6052
ac389d0c
JB
60532011-07-13 Juanma Barranquero <lekktu@gmail.com>
6054
6055 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6056
0be0ce47
EZ
60572011-07-13 Eli Zaretskii <eliz@gnu.org>
6058
6059 * buffer.c (mmap_find): Fix a typo.
6060
cd18e7e3
JB
60612011-07-13 Johan Bockgård <bojohan@gnu.org>
6062
6063 Fix execution of x selection hooks.
6064 * xselect.c (Qx_lost_selection_functions)
6065 (Qx_sent_selection_functions): New vars.
6066 (syms_of_xselect): DEFSYM them.
6067 (x_handle_selection_request): Pass Qx_sent_selection_functions
6068 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6069 (x_handle_selection_clear,x_clear_frame_selections):
6070 Pass Qx_lost_selection_functions rather than
6071 Vx_lost_selection_functions to Frun_hook_with_args.
6072
47ea7f44
PE
60732011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6074
ac389d0c 6075 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6076 The old code sometimes used this field without initializing it.
6077
47ea7f44
PE
6078 * alloc.c (gc_sweep): Don't read past end of array.
6079 In theory, the old code could also have corrupted Emacs internals,
6080 though it'd be very unlikely.
6081
bc985c87
AS
60822011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6083
6084 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6085 argument. (Bug#4026)
bc985c87 6086
0cf34688
LMI
60872011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6088
b3dadd76
LMI
6089 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6090 key" (bug#4257).
6091
0cf34688
LMI
6092 * window.c (Fset_window_start): Doc fix (bug#4199).
6093 (Fset_window_hscroll): Ditto.
6094
270768cd
PE
60952011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6096
077e3dda 6097 Fix minor new problems caught by GCC 4.6.1.
270768cd 6098 * term.c (init_tty): Remove unused local.
490011a6 6099 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6100 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6101 not used otherwise.
270768cd 6102
b1f58454
CY
61032011-07-12 Chong Yidong <cyd@stupidchicken.com>
6104
6105 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6106
22b9578d
LMI
61072011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6108
6e70ab07
LMI
6109 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6110 are the mini-buffer and the echo area (bug#3320).
6111
22b9578d
LMI
6112 * term.c (init_tty): Remove support for supdup, c10 and perq
6113 terminals, which are no longer supported (bug#1482).
6114
8974cc9f
JB
61152011-07-10 Johan Bockgård <bojohan@gnu.org>
6116
6117 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6118
a560d974
JD
61192011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6120
6121 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6122 for non-popups (Bug#3642).
6123
1dae0f0a
AS
61242011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6125
268c2c36 6126 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6127 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6128 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6129 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6130 * data.c (fmod): Likewise.
6131 * dispnew.c (swap_glyphs_in_rows): Likewise.
6132 * emacs.c (memory_warning_signal): Likewise.
6133 * floatfns.c (float_error): Likewise.
6134 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6135 (otf_open, font_otf_capability, generate_otf_features)
6136 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6137 Likewise.
6138 * image.c (pbm_read_file): Likewise.
6139 * indent.c (string_display_width): Likewise.
6140 * intervals.c (check_for_interval, search_for_interval)
6141 (inc_interval_count, count_intervals, root_interval)
6142 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6143 * lread.c (defalias): Likewise.
268c2c36 6144 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6145 * regex.c (set_image_of_range_1, set_image_of_range)
6146 (regex_grow_registers): Likewise.
6147 * sysdep.c (strerror): Likewise.
6148 * termcap.c (valid_filename_p, tprint, main): Likewise.
6149 * tparam.c (main): Likewise.
6150 * unexhp9k800.c (run_time_remap, save_data_space)
6151 (update_file_ptrs, read_header, write_header, calculate_checksum)
6152 (copy_file, copy_rest, display_header): Likewise.
6153 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6154 Likewise.
6155 * xdisp.c (check_it): Likewise.
6156 * xfaces.c (register_color, unregister_color, unregister_colors):
6157 Likewise.
6158 * xfns.c (print_fontset_result): Likewise.
6159 * xrdb.c (member, fatal, main): Likewise.
6160
99033785
PE
61612011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6162
6163 Fix minor problems found by static checking (Bug#9031).
6164 * chartab.c (char_table_set_range, map_sub_char_table):
6165 Remove unused locals.
6166 (uniprop_table): Now static.
6167 * composite.c (_work_char): Remove unused static var.
6168
9cb2ac56
JB
61692011-07-09 Juanma Barranquero <lekktu@gmail.com>
6170
6171 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6172
f25661f0
JD
61732011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6174
6175 * gtkutil.c (qttip_cb): Remove code without function.
6176
8278c4fe
EZ
61772011-07-09 Eli Zaretskii <eliz@gnu.org>
6178
6179 * w32.c (pthread_sigmask): New stub.
6180
1692ae2d 61812011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6182
8a6ebd58 6183 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6184 sigprocmask is portable only for single-threaded applications, and
6185 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6186 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6187 (LIBES): Use it.
6188 * callproc.c (Fcall_process):
6189 * process.c (create_process):
6190 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6191 Use pthread_sigmask, not sigprocmask.
123403e4 6192
1b854618
JD
61932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6194
6195 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6196 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6197 wrong (Bug#8591).
6198
3fe4b549
JD
61992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6200
0ce7e563
JD
6201 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6202 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6203 (xg_hide_tooltip): Fix comment.
6204
3fe4b549
JD
6205 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6206 in registerServicesMenuSendTypes.
6207 (validRequestorForSendType): Don't check ns_return_types.
6208
6209 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6210 ns_return_type.
6211
5df75e47
JR
62122011-07-08 Jason Rumney <jasonr@gnu.org>
6213
22610910
JR
6214 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6215 SH_SHOW for hidden windows (Bug#5482).
6216
5df75e47
JR
6217 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6218 frame struct members of non-existent frames (Bug#6284).
6219
699c10bd
JD
62202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6221
4393663b
JD
6222 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6223 variable firstTime not needed on OSX >= 10.6.
6224 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6225 >= 10.5. Use setKnobProportion, setDoubleValue.
6226
6227 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6228 (MAC_OS_X_VERSION_10_5): Define if not defined.
6229 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6230 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6231 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6232
6233 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6234 cString and lossyCString on OSX >= 10.4
6235
58179cce 6236 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6237 sizeToFit on OSX >= 10.2.
6238
6239 * nsimage.m (allocInitFromFile): Don't use deprecated method
6240 bestRepresentationForDevice on OSX >= 10.6.
6241
6242 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6243 to avoid warning.
6244
6245 * emacs.c: Declare unexec_init_emacs_zone.
6246
a63e0781
JD
6247 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6248
699c10bd
JD
6249 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6250
6251 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6252 on svcsMenu (Bug#8842).
6253
6254 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6255 ns_return_types.
6256 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6257
6258 * nsterm.m (QUTF8_STRING): Declare.
6259 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6260 (validRequestorForSendType): Return type is (id).
6261 Change indexOfObjectIdenticalTo to indexOfObject.
6262 Check if we have local selection before returning self (Bug#8842).
6263 (writeSelectionToPasteboard): Put local selection into paste board
6264 if we have a local selection (Bug#8842).
6265 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6266
6267 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6268 (ns_get_local_selection): Declare.
6269
54e10184
LMI
62702011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6271
9888ff71
LMI
6272 * keymap.c (describe_map_tree): Don't insert a double newline at
6273 the end of the buffer (bug#1169) and return whether we inserted
6274 something.
6275
54e10184
LMI
6276 * callint.c (Fcall_interactively): Change "reading args" to
6277 "providing args" to try to clarify what it does (bug#1010).
6278
15fa4783
KH
62792011-07-07 Kenichi Handa <handa@m17n.org>
6280
6281 * composite.c (composition_compute_stop_pos): Ignore a static
6282 composition starting before CHARPOS (Bug#8915).
6283
6284 * xdisp.c (handle_composition_prop): Likewise.
6285
a8815b00
EZ
62862011-07-07 Eli Zaretskii <eliz@gnu.org>
6287
6288 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6289 (Bug#9015)
6290
ef7b981d 62912011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6292
6293 * character.h (unicode_category_t): New enum type.
6294
6295 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6296 (Qchar_code_property_table): New variable.
6297 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6298 (UNIPROP_COMPRESSED_FORM_P): New macros.
6299 (char_table_ascii): Uncompress the compressed values.
6300 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6301 Uncompress the compressed values.
ac389d0c 6302 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6303 (char_table_ref_and_range): Uncompress the compressed values.
6304 (sub_char_table_set): New arg is_uniprop. Callers changed.
6305 Uncompress the compressed values.
6306 (sub_char_table_set_range): Args changed. Callers changed.
6307 (char_table_set_range): Adjuted for the above change.
6308 (map_sub_char_table): Delete args default_val and parent. Add arg
6309 top. Give decoded values to a Lisp function.
640c8776 6310 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6311 values to a Lisp function. Gcpro more variables.
6312 (uniprop_table_uncompress)
6313 (uniprop_decode_value_run_length): New functions.
6314 (uniprop_decoder, uniprop_decoder_count): New variables.
6315 (uniprop_get_decoder, uniprop_encode_value_character)
6316 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6317 New functions.
6318 (uniprop_encoder, uniprop_encoder_count): New variables.
6319 (uniprop_get_encoder, uniprop_table)
6320 (Funicode_property_table_internal, Fget_unicode_property_internal)
6321 (Fput_unicode_property_internal): New functions.
6322 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6323 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6324 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6325 char-code-property-alist.
6326
640c8776 6327 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6328 Vunicode_category_table.
6329
640c8776 6330 * font.c (font_range): Adjust for the change of
c805dec0
KH
6331 Vunicode_category_table.
6332
76b397fb
DN
63332011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6334
6335 * m/iris4d.h: Remove file, move contents ...
6336 * s/irix6-5.h: ... here.
6337
22b4128e
PE
63382011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6341 * alloc.c (mark_buffer):
6342 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6343 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6344 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6345 This isn't true in general, and it's particularly not true
6346 if Emacs is configured with --with-wide-int.
6347 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6348 New macros, used in the buffer.c change.
6349
869795d6
JD
63502011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6351
6352 * xsettings.c: Use both GConf and GSettings if both are available.
6353 (store_config_changed_event): Add comment.
6354 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6355 (store_tool_bar_style_changed): New functions.
5e617bc2 6356 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6357 (struct xsettings): Move font inside HAVE_XFT.
6358 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6359 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6360 Move inside HAVE_XFT.
640c8776 6361 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6362 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6363 also.
6364 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6365 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6366 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6367 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6368 (parse_settings): Move check for font inside HAVE_XFT.
6369 (read_settings, apply_xft_settings): Add comment.
6370 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6371 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6372 call store_font_name_changed.
6373 (xft_settings_event): Add comment.
6374 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6375 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6376 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6377 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6378 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6379 (xsettings_get_system_font, xsettings_get_system_normal_font):
6380 Add comment.
869795d6 6381
d8ed26bd
PE
63822011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6383
6384 Random fixes. E.g., (random) never returned negative values.
6385 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6386 subseconds part to the entropy, as that's a bit more random.
6387 Prefer signed to unsigned, since the signedness doesn't matter and
6388 in general we prefer signed. When given a limit, use a
6389 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6390 latter isn't right if USE_2_TAGS_FOR_INTS.
6391 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6392 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6393
cabf1cac
SM
63942011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6395
6396 * textprop.c (text_property_stickiness):
6397 Obey Vtext_property_default_nonsticky.
6398 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6399 * w32fns.c (syms_of_w32fns):
6400 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6401
6e9b2be9
PE
64022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6403
6404 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6405 This is more efficient than Ffile_directory_p and avoids a minor race.
6406
90186c68
LMI
64072011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6408
7c301272
LMI
6409 * buffer.c (Foverlay_put): Say what the return value is
6410 (bug#7835).
6411
c4f2d8d4
LMI
6412 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6413 is a directory before asking whether to use the file name
6414 (bug#7564).
ad637907
LMI
6415 (barf_or_query_if_file_exists): Make the "File is a directory"
6416 error be more correct.
c4f2d8d4 6417
90186c68
LMI
6418 * fns.c (Frequire): Remove the mention of the .gz files, since
6419 that's installation-specific, but keep the mention of
6420 `get-load-suffixes'.
6421
da64016e
PE
64222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6423
6424 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6425 Report string overflow if the output is too long.
6426
7d47b580
JB
64272011-07-04 Juanma Barranquero <lekktu@gmail.com>
6428
a555cb87
JB
6429 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6430 (syms_of_gnutls): Remove duplicate DEFSYM for
6431 Qgnutls_bootprop_verify_hostname_error, an error for
6432 Qgnutls_bootprop_verify_error (which is no longer used).
6433
7d47b580
JB
6434 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6435 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6436 Also (re)move comments that are misplaced or no longer relevant.
6437
1e49bfab
LMI
64382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6439
6440 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6441
1485f4c0
CY
64422011-07-03 Chong Yidong <cyd@stupidchicken.com>
6443
6444 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6445 and background color parameters if they have been changed.
6446
a9ab721e
LMI
64472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6448
6449 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6450
cf7cff57
PE
64512011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6452
2e13213d
PE
6453 * xsettings.c (SYSTEM_FONT): Define only when used.
6454 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6455
cf7cff57
PE
6456 * keymap.c (access_keymap_1): Now static.
6457
7a8e04f7
CY
64582011-07-02 Chong Yidong <cyd@stupidchicken.com>
6459
6460 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6461 leave any prefix arg for the up event (Bug#1586).
6462
61352f62
LMI
64632011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6464
69bb1ef7
LMI
6465 * lread.c (syms_of_lread): Mention single symbols defined by
6466 `defvar' or `defconst' (bug#7154).
6467
61352f62 6468 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6469 (Frequire): Mention get-load-suffixes.
61352f62 6470
28545e04
MR
64712011-07-02 Martin Rudalics <rudalics@gmx.at>
6472
6473 * window.h (window): Remove clone_number slot.
6474 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6475 Remove.
6476 (make_parent_window, make_window, saved_window)
6477 (Fset_window_configuration, save_window_save): Don't deal with
6478 clone numbers.
6479 * buffer.c (Qclone_number): Remove declaration.
6480 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6481
3349e122
SM
64822011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6483
6484 Add multiple inheritance to keymaps.
6485 * keymap.c (Fmake_composed_keymap): New function.
6486 (Fset_keymap_parent): Simplify.
6487 (fix_submap_inheritance): Remove.
6488 (access_keymap_1): New function extracted from access_keymap to handle
6489 embedded parents and handle lists of maps.
6490 (access_keymap): Use it.
6491 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6492 (Fcopy_keymap): Handle embedded parents.
6493 (Fcommand_remapping, define_as_prefix): Simplify.
6494 (Fkey_binding): Simplify.
6495 (syms_of_keymap): Move minibuffer-local-completion-map,
6496 minibuffer-local-filename-completion-map,
6497 minibuffer-local-must-match-map, and
6498 minibuffer-local-filename-must-match-map to Elisp.
6499 (syms_of_keymap): Defsubr make-composed-keymap.
6500 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6501 (parse_menu_item): Trivial simplification.
6502
3279eb87
GM
65032011-07-01 Glenn Morris <rgm@gnu.org>
6504
6505 * Makefile.in (SETTINGS_LIBS): Fix typo.
6506
4550efdf
KI
65072011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6508
6509 * coding.c (Fencode_coding_string): Record the last coding system
6510 used, as the function doc string says (bug#8738).
6511
0949d2b6
JD
65122011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6513
6514 * xsettings.c (store_monospaced_changed): Take new font as arg and
6515 check for change against current_mono_font.
6516 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6517 (emacs_settings_constructor, emacs_settings_get_property)
6518 (emacs_settings_set_property, emacs_settings_class_init)
6519 (emacs_settings_init, gsettings_obj): Remove.
6520 (something_changedCB): New function for HAVE_GSETTINGS.
6521 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6522 with value as argument.
6523 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6524 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6525 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6526 "changed".
6527
6528 * xgselect.c: Add defined (HAVE_GSETTINGS).
6529 (xgselect_initialize): Ditto.
6530
6531 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6532 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6533 xg_select.
6534
bbc6b304
PE
65352011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6536
6537 * eval.c (struct backtrace): Simplify and port the data structure.
6538 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6539 signed bit field, as this assumption is not portable and it makes
6540 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6541 "char debug_on_exit : 1" as this is not portable either; instead,
6542 use the portable "unsigned int debug_on_exit : 1". Remove unused
6543 member evalargs. Remove obsolete comments about cc bombing out.
6544
9851bfc5
JD
65452011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6546
51bb811f 6547 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6548 Let HAVE_GSETTINGS override HAVE_GCONF.
6549 (store_monospaced_changed): New function.
6550 (EMACS_SETTINGS): A new type derived from GObject to handle
6551 GSettings notifications.
6552 (emacs_settings_constructor, emacs_settings_get_property)
6553 (emacs_settings_set_property, emacs_settings_class_init):
6554 New functions.
6555 (gsettings_client, gsettings_obj): New variables.
6556 (GSETTINGS_SCHEMA): New define.
6557 (something_changedCB): Call store_monospaced_changed.
6558 (init_gsettings): New function.
6559 (xsettings_initialize): Call init_gsettings.
6560 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6561 to NULL.
6562
640c8776 6563 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6564 GCONF_CFLAGS/LIBS.
6565
5386012d
MR
65662011-06-29 Martin Rudalics <rudalics@gmx.at>
6567
6568 * window.c (resize_root_window, grow_mini_window)
6569 (shrink_mini_window): Rename Qresize_root_window to
6570 Qwindow_resize_root_window and Qresize_root_window_vertically to
6571 Qwindow_resize_root_window_vertically.
6572
f13e0b08
PE
65732011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6574
6575 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6576
94515237
JB
65772011-06-27 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * makefile.w32-in: Redesign dependencies so they reflect more
6580 clearly which files are directly included by each source file,
6581 and not through other includes.
6582
e43b6e43
MR
65832011-06-27 Martin Rudalics <rudalics@gmx.at>
6584
6585 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6586 (sort_overlays, overlay_strings): When an overlay's clone number
6587 matches the window's clone number process the overlay even if
6588 the overlay's window property doesn't match the current window.
6589
d68443dc
MR
6590 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6591 (Fwindow_hchild): Rename to Fwindow_left_child.
6592 (Fwindow_next): Rename to Fwindow_next_sibling.
6593 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6594 (resize_window_check): Rename to window_resize_check.
6595 (resize_window_apply): Rename to window_resize_apply.
6596 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6597 (Fdelete_other_windows_internal, resize_frame_windows)
6598 (Fsplit_window_internal, Fdelete_window_internal)
6599 (grow_mini_window, shrink_mini_window)
6600 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6601
c7e73be5
JD
66022011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6603
6604 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6605 (emacs_fixed_set_min_size): Remove.
6606 (emacs_fixed_new): Take frame as argument.
6607
6608 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6609 (_EmacsFixedPrivate): Remove minwidth/height.
6610 Add struct frame *f.
6611 (emacs_fixed_init): Initialize priv->f.
6612 (get_parent_class, emacs_fixed_set_min_size): Remove.
6613 (emacs_fixed_new): Set priv->f to argument.
6614 (emacs_fixed_get_preferred_width)
6615 (emacs_fixed_get_preferred_height): Use min_width/height from
6616 frames size_hint to set minimum and natural (Bug#8919).
6617 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6618 and use min_width/height from frames size_hint to set
6619 min_width/height (Bug#8919).
6620
6621 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6622 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6623 Fix indentation.
c7e73be5 6624
cf99dcf8
EZ
66252011-06-26 Eli Zaretskii <eliz@gnu.org>
6626
6627 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6628 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6629 called at ZV.
6630
029529ac
CY
66312011-06-26 Chong Yidong <cyd@stupidchicken.com>
6632
6633 * process.c (wait_reading_process_output): Bypass select if
6634 waiting for a cell while ignoring keyboard input, and input is
6635 pending. Suggested by Jan Djärv (Bug#8869).
6636
7a7ef429
PE
66372011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6638
6639 Use gnulib's dup2 module instead of rolling our own.
6640 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6641
11fdef7d 66422011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6643
6644 * dispnew.c (scrolling_window): Before scrolling, turn off a
6645 mouse-highlight in the window being scrolled.
6646
cd3520a4
JB
66472011-06-24 Juanma Barranquero <lekktu@gmail.com>
6648
6649 Move DEFSYM to lisp.h and use everywhere.
6650
6651 * character.h (DEFSYM): Move declaration...
6652 * lisp.h (DEFSYM): ...here.
6653
6654 * gnutls.c:
6655 * minibuf.c:
6656 * w32menu.c:
6657 * w32proc.c:
6658 * w32select.c: Don't include character.h.
6659
6660 * alloc.c (syms_of_alloc):
6661 * buffer.c (syms_of_buffer):
6662 * bytecode.c (syms_of_bytecode):
6663 * callint.c (syms_of_callint):
6664 * casefiddle.c (syms_of_casefiddle):
6665 * casetab.c (init_casetab_once):
6666 * category.c (init_category_once, syms_of_category):
6667 * ccl.c (syms_of_ccl):
6668 * cmds.c (syms_of_cmds):
6669 * composite.c (syms_of_composite):
6670 * dbusbind.c (syms_of_dbusbind):
6671 * dired.c (syms_of_dired):
6672 * dispnew.c (syms_of_display):
6673 * doc.c (syms_of_doc):
6674 * editfns.c (syms_of_editfns):
6675 * emacs.c (syms_of_emacs):
6676 * eval.c (syms_of_eval):
6677 * fileio.c (syms_of_fileio):
6678 * fns.c (syms_of_fns):
6679 * frame.c (syms_of_frame):
6680 * fringe.c (syms_of_fringe):
6681 * insdel.c (syms_of_insdel):
6682 * keymap.c (syms_of_keymap):
6683 * lread.c (init_obarray, syms_of_lread):
6684 * macros.c (syms_of_macros):
6685 * msdos.c (syms_of_msdos):
6686 * print.c (syms_of_print):
6687 * process.c (syms_of_process):
6688 * search.c (syms_of_search):
6689 * sound.c (syms_of_sound):
6690 * syntax.c (init_syntax_once, syms_of_syntax):
6691 * terminal.c (syms_of_terminal):
6692 * textprop.c (syms_of_textprop):
6693 * undo.c (syms_of_undo):
6694 * w32.c (globals_of_w32):
6695 * window.c (syms_of_window):
6696 * xdisp.c (syms_of_xdisp):
6697 * xfaces.c (syms_of_xfaces):
6698 * xfns.c (syms_of_xfns):
6699 * xmenu.c (syms_of_xmenu):
6700 * xsettings.c (syms_of_xsettings):
6701 * xterm.c (syms_of_xterm): Use DEFSYM.
6702
4228cf16
TZ
67032011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6704
cd3520a4 6705 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6706
7fcccf1e
PE
67072011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6708
7efb4e0e
PE
6709 Integer and buffer overflow fixes (Bug#8873).
6710
ff5844ad
PE
6711 * print.c (printchar, strout): Check for string overflow.
6712 (PRINTPREPARE, printchar, strout):
6713 Don't set size unless allocation succeeds.
6714
90532f02
PE
6715 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6716 for sizes. Check for string overflow more accurately.
6717 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6718
6d84508d
PE
6719 * macros.c: Integer and buffer overflow fixes.
6720 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6721 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6722 Use ptrdiff_t, not int, for sizes.
6723 Don't increment bufsize until after realloc succeeds.
6724 Check for size-calculation overflow.
6725 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6726
437b2cb4
PE
6727 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6728
8b9ac8b4
PE
6729 * lread.c: Integer overflow fixes.
6730 (read_integer): Radix is now EMACS_INT, not int,
6731 to improve quality of diagnostics for out-of-range radices.
6732 Calculate buffer size correctly for out-of-range radices.
6733 (read1): Check for integer overflow in radices, and in
6734 read-circle numbers.
82cb60d3
PE
6735 (read_escape): Avoid int overflow.
6736 (Fload, openp, read_buffer_size, read1)
6737 (substitute_object_recurse, read_vector, read_list, map_obarray):
6738 Use ptrdiff_t, not int, for sizes.
6739 (read1): Use EMACS_INT, not int, for sizes.
20270765 6740 Check for size overflow.
8b9ac8b4 6741
7fcccf1e
PE
6742 * image.c (cache_image): Check for size arithmetic overflow.
6743
bfbbd7e7
PE
6744 * lread.c: Integer overflow issues.
6745 (saved_doc_string_size, saved_doc_string_length)
6746 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6747 Now ptrdiff_t, not int.
6748 (read1): Don't assume doc string length fits in int. Check for
6749 out-of-range doc string lengths.
6750 (read_list): Don't assume file position fits in int.
39019e54 6751 (read_escape): Check for hex character overflow.
bfbbd7e7 6752
4e323265
LL
67532011-06-22 Leo Liu <sdl.web@gmail.com>
6754
6755 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6756 Move to minibuffer.el.
6757
85fece3e
PE
67582011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6759
20b84ce9 6760 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6761 The following patches are for when GLYPH_DEBUG && !XASSERT.
6762 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6763 * dispnew.c (flush_stdout):
6764 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6765 Mark as externally visible.
6766 * dispnew.c (check_window_matrix_pointers): Now static.
6767 * dispnew.c (window_to_frame_vpos):
6768 * xfns.c (unwind_create_frame):
6769 * xterm.c (x_check_font): Remove unused local.
6770 * scroll.c (CHECK_BOUNDS):
6771 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6772 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6773 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6774 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6775 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6776 Now static.
6777 (debug_method_add): Use va_list and vsprintf rather than relying
6778 on undefined behavior with wrong number of arguments.
6779 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6780 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6781 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6782 since we're not interested in debugging glyphs with old libraries.
6783 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6784 GCC 4.6.0's static checking.
6785
0766b489
PE
67862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6787
31fd4b32
PE
6788 Integer overflow and signedness fixes (Bug#8873).
6789 A few related buffer overrun fixes, too.
6790
b79e8648
PE
6791 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6792
0766b489
PE
6793 * dispextern.h (struct face.stipple):
6794 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6795 (x_bitmap_mask, x_allocate_bitmap_record)
6796 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6797 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6798 (x_create_bitmap_from_xpm_data):
6799 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6800 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6801 (.bitmaps_last):
6802 * xfaces.c (load_pixmap):
6803 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6804 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6805 (.bitmaps_last, struct x_output.icon_bitmap):
6806 Use ptrdiff_t, not int, for bitmap indexes.
6807 (x_allocate_bitmap_record): Check for size overflow.
6808 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6809
b081724f
PE
6810 Use ptrdiff_t, not int, for overlay counts.
6811 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6812 * editfns.c (overlays_around, get_pos_property):
6813 * textprop.c (get_char_property_and_overlay):
6814 * xdisp.c (next_overlay_change, note_mouse_highlight):
6815 * xfaces.c (face_at_buffer_position):
21514da7
PE
6816 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6817 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6818 (Fnext_overlay_change, Fprevious_overlay_change)
6819 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6820 Use ptrdiff_t, not int, for sizes.
21514da7 6821 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6822
3de73e5e
PE
6823 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6824
2606c57b
PE
6825 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6826 (x_session_initialize): Do not assume string length fits in int.
6827
aaafe47a
PE
6828 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6829 This is unlikely, but can occur if DPI is outlandish.
6830
2674ddc8 6831 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6832 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6833
28154962
PE
6834 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6835 * xrdb.c (magic_file_p, search_magic_path):
6836 Omit last arg SUFFIX; it was always 0. All callers changed.
6837 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6838
7de51af5
PE
6839 * xfont.c (xfont_match): Avoid need for strlen.
6840
25ed6cc3
PE
6841 * xfns.c: Don't assume strlen fits in int.
6842 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6843
4eab31dd
PE
6844 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6845 not unsigned long, as we prefer signed integers. All callers changed.
6846 Detect integer overflow in repeat count.
6847 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6848 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6849
171e2a58
PE
6850 * termcap.c: Don't assume sizes fit in int and never overflow.
6851 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6852 (gobble_line): Check for size-calculation overflow.
6853
ad39faca 6854 * minibuf.c (Fread_buffer):
6e5bb2dc 6855 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6856 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6857 Don't assume string length fits in int.
6858
52c61c22 6859 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6860 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6861
b5b8c9e5
PE
6862 * font.c: Don't assume string length fits in int.
6863 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6864 Use ptrdiff_t, not int.
ccd6111c
PE
6865 (font_intern_prop): Don't assume string length fits in int.
6866 Don't assume integer property fits in fixnum.
6867 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6868
882f0d81 6869 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6870 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6871 Reformulate so as not to need the command string.
6872 Invoke gzip -cd rather than gunzip, as it's more portable.
6873 (lock_info_type, lock_file_1, lock_file):
6874 Don't assume pid_t and time_t fit in unsigned long.
6875 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6876 (current_lock_owner): Prefer signed type for sizes.
6877 Use memcpy, not strncpy, where memcpy is what is really wanted.
6878 Don't assume (via atoi) that time_t and pid_t fit in int.
6879 Check for time_t and/or pid_t out of range, e.g., via a network share.
6880 Don't alloca where an auto var works fine.
6881
93f4cf88
PE
6882 * fileio.c: Fix some integer overflow issues.
6883 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6884 Don't assume string length fits in int.
6885 (directory_file_name): Don't assume string length fits in long.
6886 (make_temp_name): Don't assume pid fits in int, or that its print
6887 length is less than 20.
6888
f3e92b69
PE
6889 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6890
1bfdaf10
PE
6891 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6892
35016e9a
PE
6893 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6894
3d1e65a1
PE
6895 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6896 We prefer signed integers, even for size calculations.
6897
0b963a93
PE
6898 * emacs.c: Don't assume string length fits in 'int'.
6899 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6900 (main): Don't invoke strlen when not needed.
6901
573f4b54
PE
6902 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6903 (XD_DEBUG_MESSAGE): Don't waste a byte.
6904
989f33ba
PE
6905 * callproc.c (getenv_internal_1, getenv_internal)
6906 (Fgetenv_internal):
965d34eb
PE
6907 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6908
e4d29b33
PE
6909 * lread.c (invalid_syntax): Omit length argument.
6910 All uses changed. This doesn't fix a bug, but it simplifies the
6911 code away from its former Hollerith-constant appearance, and it's
6912 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6913 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6914
eb49b136
PE
6915 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6916 This didn't break anything, but it didn't help either.
6917 It's confusing to put a bogus integer in a place where the actual
6918 value does not matter.
9f62aeb1 6919 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6920 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6921
15375a22
PE
6922 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6923 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6924 implementation.
b61cc01c
PE
6925 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6926 We prefer signed types, and the value cannot exceed the EMACS_INT
6927 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6928 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6929 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6930 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6931
53b2623d
PE
6932 * indent.c (sane_tab_width): New function.
6933 (current_column, scan_for_column, Findent_to, position_indentation)
6934 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6935 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6936
51cab52b 6937 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6938
f2ed8a70
PE
6939 * lisp.h (lint_assume): New macro.
6940 * composite.c (composition_gstring_put_cache):
6941 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6942
abe80cc6
PE
6943 * editfns.c, insdel.c:
6944 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6945
b02c740e
PE
6946 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6947
ebc96716
PE
6948 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6949
b4e50fa0 6950 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6951 Use much-faster test for byte-length change.
311d5d7c 6952 Don't assume string byte-length fits in 'int'.
a4cf38e4 6953 Check that character arg fits in 'int'.
85461888 6954 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6955
c0c1ee9f
PE
6956 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6957
a498d7f4
PE
6958 * fns.c (concat): Catch string overflow earlier.
6959 Do not rely on integer wraparound.
6960
51cab52b
PE
6961 * dispextern.h (struct it.overlay_strings_charpos)
6962 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6963 * xdisp.c (forward_to_next_line_start)
6964 (back_to_previous_visible_line_start)
6965 (reseat_at_next_visible_line_start, next_element_from_buffer):
6966 Don't arbitrarily truncate the value of 'selective' to int.
6967
76031fad
PE
6968 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6969
5eb55db9
PE
6970 * composite.c: Don't truncate sizes to 'int'.
6971 (composition_gstring_p, composition_reseat_it)
6972 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6973 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6974 not EMACS_UINT, for indexes.
5eb55db9 6975
0703a717
PE
6976 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6977
d6202519
PE
6978 * buffer.c: Include <verify.h>.
6979 (struct sortvec.priority, struct sortstr.priority):
8961a454 6980 Now EMACS_INT, not int.
c20998a7 6981 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6982 (struct sortstr.size, record_overlay_string)
6983 (struct sortstrlist.size, struct sortlist.used):
6984 Don't truncate size to int.
6985 (record_overlay_string): Check for size-calculation overflow.
d6202519 6986 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6987
d5a19415
JM
69882011-06-22 Jim Meyering <meyering@redhat.com>
6989
029529ac 6990 Don't leak an XBM-image-sized buffer
d5a19415
JM
6991 * image.c (xbm_load): Free the image buffer after using it.
6992
a9041e6c
PE
69932011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6994
6995 Port to Sun C.
6996 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6997 that Sun C diagnosed.
6998 * fns.c (secure_hash): Fix pointer signedness issue.
6999 * intervals.c (static_offset_intervals): New function.
7000 (offset_intervals): Use it.
7001
7f3f739f
LL
70022011-06-21 Leo Liu <sdl.web@gmail.com>
7003
7004 * deps.mk (fns.o):
7005 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7006 sha512.h.
7007
7008 * fns.c (secure_hash): Rename from crypto_hash_function and change
7009 the first arg to accept symbols.
5b66d427 7010 (Fsecure_hash): New primitive.
7f3f739f
LL
7011 (syms_of_fns): New symbols.
7012
76147d94
DD
70132011-06-20 Deniz Dogan <deniz@dogan.se>
7014
7015 * process.c (Fset_process_buffer): Clarify return value in
7016 docstring.
7017
7d7d0045
CY
70182011-06-18 Chong Yidong <cyd@stupidchicken.com>
7019
7020 * dispnew.c (add_window_display_history): Use BVAR.
7021
7022 * xdisp.c (debug_method_add): Use BVAR.
7023 (check_window_end, dump_glyph_matrix, dump_glyph)
7024 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7025
7026 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7027 Likewise.
7028
7029 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7030 check till after the cache is created in init_frame_faces.
7031
ff2bc410
SM
70322011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7033
7034 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7035
28177add
PE
70362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7037
dd3482fe
PE
7038 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7039 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7040 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7041
393d71f3 7042 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7043 * fileio.c (Finsert_file_contents):
7044 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7045 Remove the old (too-loose) buffer overflow checks.
7046 They weren't needed, since make_gap checks for buffer overflow.
7047 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7048 The old code merely checked for Emacs fixnum overflow, and relied
7049 on undefined (wraparound) behavior. The new code avoids undefined
7050 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7051
2e6813b0 7052 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7053 Tune. Don't use wider integers than needed. Don't use alloca.
7054 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7055
599a9e4f
PE
7056 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7057
99561444
PE
7058 * insdel.c, lisp.h (buffer_overflow): New function.
7059 (insert_from_buffer_1, replace_range, replace_range_2):
7060 * insdel.c (make_gap_larger):
7061 * editfns.c (Finsert_char):
7062 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7063
28177add
PE
7064 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7065
e69dafad
PE
70662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7067
4baa020d 7068 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7069
b1c46f02
PE
7070 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7071 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7072
e69dafad
PE
7073 * fileio.c: Don't assume EMACS_INT fits in off_t.
7074 (emacs_lseek): New static function.
7075 (Finsert_file_contents, Fwrite_region): Use it.
7076 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7077
566684ea
PE
7078 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7079
e6966cd6
PE
7080 * fns.c: Don't overflow int when computing a list length.
7081 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7082 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7083 truncation on 64-bit hosts. Check for QUIT every
7084 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7085 faster and is responsive enough.
7086 (Flength): Report an error instead of overflowing an integer.
7087 (Fsafe_length): Return a float if the value is not representable
7088 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7089 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7090 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7091
dd0b0efb
PE
7092 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7093 (header_size, word_size): New constants.
7094 (allocate_vectorlike): Don't check size overflow here.
7095 (allocate_vector): Check it here instead, since this is the only
7096 caller of allocate_vectorlike that could cause overflow.
7097 Check that the new vector's length is representable as a fixnum.
7098
86fe5cfe
PE
7099 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7100 The previous code was bogus. For example, next_almost_prime (32)
7101 returned 39, which is undesirable as it is a multiple of 3; and
7102 next_almost_prime (24) returned 25, which is a multiple of 5 so
7103 why was the code bothering to check for multiples of 7?
7104
80e88859
PE
7105 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7106
4a2f0ad6
PE
7107 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7108
f66c7cf8
PE
7109 Variadic C functions now count arguments with ptrdiff_t.
7110 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7111 Back then I didn't know that the Emacs coding style prefers signed int.
7112 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7113 were being counted with int, which may truncate counts on 64-bit
7114 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7115 * lisp.h (struct Lisp_Subr.function.aMANY)
7116 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7117 Arg counts are now ptrdiff_t, not size_t.
7118 All variadic functions and their callers changed accordingly.
7119 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7120 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7121 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7122 * callint.c (Fcall_interactively): Check arg count for overflow,
7123 to avoid potential buffer overrun. Use signed char, not 'int',
7124 for 'varies' array, so that we needn't bother to check its size
7125 calculation for overflow.
7126 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7127 * eval.c (apply_lambda):
7128 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7129 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7130 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7131
a1759b76
PE
7132 * callint.c (Fcall_interactively): Don't use index var as event count.
7133
d96be9fc
PE
7134 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7135 * mem-limits.h (SIZE): Remove; no longer used.
7136
a690a978 7137 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7138
578c21e6
PE
7139 Remove unnecessary casts.
7140 * xterm.c (x_term_init):
7141 * xfns.c (x_set_border_pixel):
7142 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7143 These aren't needed now that we assume ANSI C.
7144
96f53c6c
PE
7145 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7146 It's more likely to cause problems (due to unsigned overflow)
7147 than to cure them.
7148
83c77d31
PE
7149 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7150
ee2079f1
PE
7151 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7152
6da65536
PE
7153 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7154
7147c4a4
PE
7155 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7156
193e32d9
PE
7157 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7158
e5533da6
PE
7159 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7160
9910e595
PE
7161 GLYPH_CODE_FACE returns EMACS_INT, not int.
7162 * dispextern.h (merge_faces):
7163 * xfaces.c (merge_faces):
01103c44
PE
7164 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7165 Don't assume EMACS_INT fits in int.
9910e595 7166
2638320e
PE
7167 * character.h (CHAR_VALID_P): Remove unused parameter.
7168 * fontset.c, lisp.h, xdisp.c: All uses changed.
7169
045eb8d9
PE
7170 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7171
c1f134b5
PE
7172 * fns.c (concat): Minor tuning based on overflow analysis.
7173 This doesn't fix any bugs. Use int to hold character, instead
7174 of constantly refetching from Emacs object. Use XFASTINT, not
7175 XINT, for value known to be a character. Don't bother comparing
7176 a single byte to 0400, as it's always less.
7177
395fcb93 7178 * floatfns.c (Fexpt):
327eeec8
PE
7179 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7180
abbd3d23
PE
7181 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7182 for characters.
7183
684a03ef
PE
7184 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7185
0fed43f3
PE
7186 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7187 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7188 incorrectly succeed when S was a string, because 4294967386 was
7189 truncated before it was used.
7190
8fd02eb7
PE
7191 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7192 Otherwise, an out-of-range integer could cause undefined behavior
7193 on a 64-bit host.
7194
f8c86b69
PE
7195 * composite.c: Use int, not EMACS_INT, for characters.
7196 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7197 EMACS_INT, for values that are known to be in character range.
7198 This doesn't fix any bugs but is the usual style inside Emacs and
7199 may generate better code on 32-bit machines.
7200
34206dd2
PE
7201 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7202 This is for reasons similar to the recent CHAR_STRING fix.
7203 * charset.c (Fencode_char): Check that character arg is actually
7204 a character. Pass an int to ENCODE_CHAR.
7205 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7206 wider than 'int', as a compile-time check to prevent future regressions
7207 in this area.
7208
c5958d4c 7209 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7210
7211 Make sure a 64-bit char is never passed to CHAR_STRING.
7212 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7213 by silently ignoring the top 32 bits, allowing some values
7214 that were far too large to be valid characters.
7215 * character.h: Include <verify.h>.
7216 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7217 arguments are no wider than unsigned, as a compile-time check
7218 to prevent future regressions in this area.
7219 * data.c (Faset):
01103c44 7220 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7221 (Fsubst_char_in_region):
7222 * fns.c (concat):
7223 * xdisp.c (decode_mode_spec_coding):
7224 Adjust to CHAR_STRING's new requirement.
7225 * editfns.c (Finsert_char, Fsubst_char_in_region):
7226 * fns.c (concat): Check that character args are actually
7227 characters. Without this test, these functions did the wrong
7228 thing with wildly out-of-range values on 64-bit hosts.
7229
d37ca623
PE
7230 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7231 These casts should not be needed on 32-bit hosts, either.
7232 * keyboard.c (read_char):
7233 * lread.c (Fload): Remove casts to unsigned.
7234
ea204efb
PE
7235 * lisp.h (UNSIGNED_CMP): New macro.
7236 This fixes comparison bugs on 64-bit hosts.
7237 (ASCII_CHAR_P): Use it.
7238 * casefiddle.c (casify_object):
01103c44 7239 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7240 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7241 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7242 * dispextern.h (FACE_FROM_ID):
7243 * keyboard.c (read_char): Use UNSIGNED_CMP.
7244
41cb286c
PE
7245 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7246 not to EMACS_INT, to avoid GCC warning.
7247
4a1b9832
PE
7248 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7249
55daad71
PE
7250 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7251 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7252 isn't needed on 32-bit machines.
8f95c75c 7253
01103c44
PE
7254 * buffer.c (Fgenerate_new_buffer_name):
7255 Use EMACS_INT for count, not int.
0ceccced 7256 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7257
7258 * data.c (Qcompiled_function): Now static.
7259
c6f072e7
PE
7260 * window.c (window_body_lines): Now static.
7261
20ce5912
PE
7262 * image.c (gif_load): Rename local to avoid shadowing.
7263
9c4c5f81
PE
7264 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7265 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7266 * alloc.c (make_save_value): Integer argument is now of type
7267 ptrdiff_t, not int.
7268 (mark_object): Use ptrdiff_t, not int.
7269 * lisp.h (pD): New macro.
7270 * print.c (print_object): Use it.
7271
c0c5c8ae
PE
7272 * alloc.c: Use EMACS_INT, not int, to count objects.
7273 (total_conses, total_markers, total_symbols, total_vector_size)
7274 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7275 (total_free_floats, total_floats, total_free_intervals)
7276 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7277 Now EMACS_INT, not int. All uses changed.
7278 (Fgarbage_collect): Compute overall total using a double, so that
7279 integer overflow is less likely to be a problem. Check for overflow
7280 when converting back to an integer.
5a25e253
PE
7281 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7282 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7283 These were 'int' variables that could overflow on 64-bit hosts;
7284 they were never used, so remove them instead of repairing them.
211a0b2a 7285 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7286 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7287 Previously, this ceilinged at INT_MAX, but that doesn't work on
7288 64-bit machines.
e46bb31a 7289 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7290
c78baabf 7291 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7292 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7293 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7294 when a (possibly-narrower) signed value would do just as well.
7295 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7296
c9d624c6
PE
7297 * alloc.c: Catch some string size overflows that we were missing.
7298 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7299 for convenience in STRING_BYTES_MAX.
7300 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7301 The definition here is exact; the one in lisp.h was approximate.
7302 (allocate_string_data): Check for string overflow. This catches
7303 some instances we weren't catching before. Also, it catches
7304 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7305 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7306 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7307
c9d624c6
PE
7308 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7309 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7310 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7311
353032ce
PE
7312 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7313
2bccce07
PE
7314 * alloc.c (Fmake_string): Check for out-of-range init.
7315
0ac30604
SM
73162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7317
7318 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7319
c195f2de
JD
73202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7321
7322 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7323 xg_get_default_scrollbar_width.
7324
7325 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7326 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7327 (style_changed_cb): Call update_theme_scrollbar_width and call
7328 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7329 all frames (Bug#8505).
7330 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7331 Call gtk_window_set_resizable if HAVE_GTK3.
7332 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7333 and height if HAVE_GTK3 (Bug#8505).
7334 (scroll_bar_width_for_theme): New variable.
7335 (update_theme_scrollbar_width): New function.
7336 (xg_get_default_scrollbar_width): Move code to
7337 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7338 (xg_initialize): Call update_theme_scrollbar_width.
7339
7340 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7341
7342 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7343
e10ac9f1
MR
73442011-06-12 Martin Rudalics <rudalics@gmx.at>
7345
7346 * frame.c (make_frame): Call other_buffer_safely instead of
7347 other_buffer.
7348
7349 * window.c (temp_output_buffer_show): Call display_buffer with
7350 second argument Vtemp_buffer_show_specifiers and reset latter
7351 immediately after the call.
7352 (Vtemp_buffer_show_specifiers): New variable.
7353 (auto_window_vscroll_p, next_screen_context_lines)
7354 (Vscroll_preserve_screen_position): Remove leading asterisks from
7355 doc-strings.
7356
2d3c217e 73572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7358
7b7f97e8 7359 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7360 * buffer.c (Qclone_number): Remove for now, as it's unused.
7361 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7362 (record_buffer): Remove unused local.
7363 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7364 (set_frame_buffer_list): Remove; unused.
7365 * frame.h (other_visible_frames): Remove decl.
7366 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7367 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7368 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7369 if HAVE_GPM.
7370 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7371 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7372 Define only if HAVE_GPM.
7373 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7374 (update_hints_inhibit): Remove; never set. All uses removed.
7375 * widgetprv.h (emacsFrameClassRec): Remove decl.
7376 * window.c (delete_deletable_window): Now returns void, since it
7377 wasn't returning anything.
7378 (compare_window_configurations): Remove unused locals.
7379 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7380 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7381 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7382 the same widths as pointers. This follows up on the 2011-05-06 patch.
7383 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7384 * xterm.h: Likewise.
7385 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7386
1384b89e
JB
73872011-06-12 Juanma Barranquero <lekktu@gmail.com>
7388
7389 * makefile.w32-in: Update dependencies.
7390 (LISP_H): Add lib/intprops.h.
7391
1100a63c
CY
73922011-06-11 Chong Yidong <cyd@stupidchicken.com>
7393
7394 * image.c (gif_load): Add animation frame delay to the metadata.
7395 (syms_of_image): Use DEFSYM. New symbol `delay'.
7396
6198ccd0
MR
73972011-06-11 Martin Rudalics <rudalics@gmx.at>
7398
7399 * window.c (delete_deletable_window): Re-add.
7400 (Fset_window_configuration): Rewrite to handle dead buffers and
7401 consequently deletable windows.
7402 (window_tree, Fwindow_tree): Remove. Supply functionality in
7403 window.el.
7404 (compare_window_configurations): Simplify code.
7405
b6e3633c
AS
74062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7407
1ab0dee5
AS
7408 * image.c (imagemagick_load_image): Fix type mismatch.
7409 (Fimagemagick_types): Likewise.
7410
b6e3633c
AS
7411 * window.h (replace_buffer_in_windows): Declare.
7412
9397e56f
MR
74132011-06-11 Martin Rudalics <rudalics@gmx.at>
7414
7415 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7416 Qclone_number. Remove external declaration of Qdelete_window.
7417 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7418 code.
640c8776
SM
7419 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7420 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7421 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7422 buffer list implementation.
7423 (other_buffer_safely): New function.
7424 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7425 calls to replace_buffer_in_windows and
7426 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7427 if allowed.
7428 (record_buffer): Inhibit quitting and rewrite using quittable
7429 functions. Run Qbuffer_list_update_hook if allowed.
7430 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7431 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7432 Move switch-to-buffer to window.el.
9397e56f
MR
7433 (bury-buffer): Move to window.el.
7434 (Vbuffer_list_update_hook): New variable.
7435
7436 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7437 section.
7438
7439 * window.h (resize_frame_windows): Move up in code.
7440 (Fwindow_frame): Remove EXFUN.
7441 (replace_buffer_in_all_windows): Remove prototype.
7442 (replace_buffer_in_windows_safely): Add prototype.
7443
7444 * window.c: Declare Qdelete_window static again. Move down
7445 declaration of select_count.
7446 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7447 (Fother_window): Move to window.el.
7448 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7449 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7450 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7451 window.el.
7452 (replace_buffer_in_windows): Implement by calling
7453 Qreplace_buffer_in_windows.
7454 (replace_buffer_in_all_windows): Remove with some functionality
7455 moved into replace_buffer_in_windows_safely.
7456 (replace_buffer_in_windows_safely): New function.
7457 (select_window_norecord, select_frame_norecord): Move in front
7458 of run_window_configuration_change_hook. Remove now obsolete
7459 declarations.
640c8776
SM
7460 (Fset_window_buffer): Rewrite doc-string.
7461 Call Qrecord_window_buffer.
9397e56f
MR
7462 (keys_of_window): Move binding for other-window to window.el.
7463
b50691aa
CY
74642011-06-11 Chong Yidong <cyd@stupidchicken.com>
7465
7466 * dispextern.h (struct image): Replace data member, whose int_val
7467 and ptr_val fields were not used by anything, with a single
7468 lisp_val object.
7469
7470 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7471 (gif_clear_image, gif_load, imagemagick_load_image)
7472 (gs_clear_image, gs_load): Callers changed.
7473
3f754b86
PE
74742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7475
cca69397
PE
7476 * buffer.h: Include <time.h>, for time_t.
7477 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7478
109e28d0
PE
7479 Fix minor problems found by static checking.
7480
60737f02
PE
7481 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7482
4b66faf3
PE
7483 Make identifiers static if they are not used in other modules.
7484 * data.c (Qcompiled_function, Qframe, Qvector):
7485 * image.c (QimageMagick, Qsvg):
7486 * minibuf.c (Qmetadata):
7487 * window.c (resize_window_check, resize_root_window): Now static.
7488 * window.h (resize_window_check, resize_root_window): Remove decls.
7489
109e28d0
PE
7490 * window.c (window_deletion_count, delete_deletable_window):
7491 Remove; unused.
46a4ce9e
PE
7492 (window_body_lines): Now static.
7493 (Fdelete_other_windows_internal): Mark vars as initialized.
7494 Make sure 'resize_failed' is initialized.
7495 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7496 (resize_window_apply): Remove unused local.
7497 * window.h (delete_deletable_window): Remove decl.
7498
109e28d0 7499 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7500 (imagemagick_load_image): Fix pointer signedness problem by changing
7501 last arg from unsigned char * to char *. All uses changed.
7502 Also, fix a local for similar reasons.
7503 Remove unused locals. Remove locals to avoid shadowing.
7504 (fn_rsvg_handle_free): Remove; unused.
7505 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7506 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7507
3f754b86
PE
7508 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7509
2547adb1
CY
75102011-06-10 Chong Yidong <cyd@stupidchicken.com>
7511
7512 * image.c (gif_load): Fix omitted cast error introduced by
7513 2011-06-06 change.
7514
2c8e37d4
MR
75152011-06-10 Martin Rudalics <rudalics@gmx.at>
7516
7517 * window.h (resize_proportionally, orig_total_lines)
7518 (orig_top_line): Remove from window structure.
7519 (set_window_height, set_window_width, change_window_heights)
7520 (Fdelete_window): Remove prototypes.
7521 (resize_frame_windows): Remove duplicate declaration.
7522
440a42e3
EZ
75232011-06-10 Eli Zaretskii <eliz@gnu.org>
7524
7525 * window.h (resize_frame_windows, resize_window_check)
7526 (delete_deletable_window, resize_root_window)
7527 (resize_frame_windows): Declare prototypes.
7528
7529 * window.c (resize_window_apply): Make definition be "static" to
7530 match the prototype.
7531
562dd5e9
MR
75322011-06-10 Martin Rudalics <rudalics@gmx.at>
7533
7534 * window.c: Remove declarations of Qwindow_size_fixed,
7535 window_min_size_1, window_min_size_2, window_min_size,
7536 size_window, window_fixed_size_p, enlarge_window, delete_window.
7537 Remove static from declaration of Qdelete_window, it's
7538 temporarily needed by Fbury_buffer.
7539 (replace_window): Don't assign orig_top_line and
7540 orig_total_lines.
7541 (Fdelete_window, delete_window): Remove. Window deletion is
7542 handled by window.el.
640c8776
SM
7543 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7544 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7545 (Fdelete_other_windows): Remove. Deleting other windows is
7546 handled by window.el.
7547 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7548 handled in window.el.
7549 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7550 Window minimum sizes are handled in window.el.
7551 (shrink_windows, size_window, set_window_height)
7552 (set_window_width, change_window_heights, window_height)
7553 (window_width, CURBEG, CURSIZE, enlarge_window)
7554 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7555 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7556 handled in window.el.
7557 (make_dummy_parent): Rename to make_parent_window and give it a
7558 second argument horflag.
7559 (make_window): Don't set resize_proportionally any more.
7560 (Fsplit_window): Remove. Windows are split in window.el.
7561 (save_restore_action, save_restore_orig_size)
7562 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7563 Resize mini windows in window.el.
7564 (grow_mini_window, shrink_mini_window): Implement by calling
7565 Qresize_root_window_vertically, resize_window_check and
7566 resize_window_apply.
640c8776
SM
7567 (saved_window, Fset_window_configuration, save_window_save):
7568 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7569 resize_proportionally.
7570 (window_min_height, window_min_width): Move to window.el.
7571 (keys_of_window): Move bindings for delete-other-windows,
7572 split-window, delete-window and enlarge-window to window.el.
7573
7574 * buffer.c: Temporarily extern Qdelete_window.
7575 (Fbury_buffer): Temporarily call Qdelete_window instead of
7576 Fdelete_window (Fbury_buffer will move to window.el soon).
7577
7578 * frame.c (set_menu_bar_lines_1): Remove code handling
7579 orig_top_line and orig_total_lines.
7580
7581 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7582 set_window_height but set heights directly.
7583 (change_frame_size_1): Use resize_frame_windows.
7584
7585 * xdisp.c (init_xdisp): Don't use set_window_height but set
7586 heights directly.
7587
640c8776
SM
7588 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7589 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7590 run_window_configuration_change_hook.
7591
7592 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7593 instead of change_window_heights and run
7594 run_window_configuration_change_hook.
7595
1a13852e
MR
75962011-06-09 Martin Rudalics <rudalics@gmx.at>
7597
7598 * window.c (replace_window): Rename second argument REPLACEMENT to
7599 NEW. New third argument SETFLAG. Rewrite.
7600 (delete_window, make_dummy_parent): Call replace_window with
7601 third argument 1.
7602 (window_list_1): Move down in code.
7603 (run_window_configuration_change_hook): Move set_buffer part
7604 before select_frame_norecord part in order to unwind correctly.
7605 Rename count1 to count.
7606 (recombine_windows, delete_deletable_window, resize_root_window)
7607 (Fdelete_other_windows_internal)
7608 (Frun_window_configuration_change_hook, make_parent_window)
7609 (resize_window_check, resize_window_apply, Fresize_window_apply)
7610 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7611 (Fdelete_window_internal, Fresize_mini_window_internal):
7612 New functions.
1a13852e
MR
7613 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7614
f3d1777e
MR
76152011-06-08 Martin Rudalics <rudalics@gmx.at>
7616
496e208e
MR
7617 * window.h (window): Add some new members to window structure -
7618 normal_lines, normal_cols, new_total, new_normal, clone_number,
7619 splits, nest, prev_buffers, next_buffers.
7620 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7621 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7622
f3d1777e
MR
7623 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7624 Remove.
496e208e
MR
7625 (make_dummy_parent): Set new members of windows structure.
7626 (make_window): Move down in code. Handle new members of window
7627 structure.
7628 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7629 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7630 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7631 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7632 (Fset_window_next_buffers, Fset_window_clone_number):
7633 New functions.
496e208e
MR
7634 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7635 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7636 Doc-string fixes.
7637 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7638 Argument WINDOW can be now internal window too.
7639 (Fwindow_use_time): Move up in code.
7640 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7641 Rewrite doc-string.
7642 (Fset_window_configuration, saved_window)
7643 (Fcurrent_window_configuration, save_window_save): Handle new
7644 members of window structure.
b9e809c2
MR
7645 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7646 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7647 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7648 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7649 Qget_mru_window, Qresize_root_window,
7650 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7651 Qauto_buffer_name; staticpro them.
f3d1777e 7652
abde8f8c
MR
76532011-06-07 Martin Rudalics <rudalics@gmx.at>
7654
7655 * window.c (Fwindow_total_size, Fwindow_left_column)
7656 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7657 (Fwindow_list_1): New functions.
7658 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7659 (Fwindow_width, Fscroll_left, Fscroll_right):
7660 Use window_body_cols instead of window_box_text_cols.
7661 (delete_window, Fset_window_configuration):
7662 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7663 (delete_all_subwindows): Take a window as argument and not a
7664 structure. Rewrite.
190b47e6
MR
7665 (window_loop): Remove handling of GET_LRU_WINDOW and
7666 GET_LARGEST_WINDOW.
7667 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7668
7669 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7670 window_box_text_cols. delete_all_subwindows now takes a
7671 Lisp_Object as argument.
abde8f8c 7672
640c8776
SM
7673 * indent.c (compute_motion, Fcompute_motion):
7674 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7675
fa8a67e6
MR
7676 * frame.c (delete_frame): Call delete_all_subwindows with root
7677 window as argument.
7678
a54e3482
DC
76792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7680
7681 * fns.c (Fputhash): Document return value.
7682
60002bf5
CY
76832011-06-06 Chong Yidong <cyd@stupidchicken.com>
7684
7685 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7686
0c671da6 76872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7688
b862a52a 7689 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7690
be44ca6c
PE
7691 Check for overflow when converting integer to cons and back.
7692 * charset.c (Fdefine_charset_internal, Fdecode_char):
7693 Use cons_to_unsigned to catch overflow.
7694 (Fencode_char): Use INTEGER_TO_CONS.
7695 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7696 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7697 * data.c (long_to_cons, cons_to_long): Remove.
7698 (cons_to_unsigned, cons_to_signed): New functions.
7699 These signal an error for invalid or out-of-range values.
7700 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7701 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7702 * font.c (Ffont_variation_glyphs):
7703 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7704 * lisp.h: Include <intprops.h>.
7705 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7706 (cons_to_signed, cons_to_unsigned): New decls.
7707 (long_to_cons, cons_to_long): Remove decls.
7708 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7709 (Fprimitive_undo): Use CONS_TO_INTEGER.
7710 * xfns.c (Fx_window_property): Likewise.
7711 * xselect.c: Include <limits.h>.
7712 (x_own_selection, selection_data_to_lisp_data):
7713 Use INTEGER_TO_CONS.
7714 (x_handle_selection_request, x_handle_selection_clear)
7715 (x_get_foreign_selection, Fx_disown_selection_internal)
7716 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7717 (lisp_data_to_selection_data): Use cons_to_unsigned.
7718 (x_fill_property_data): Use cons_to_signed.
7719 Report values out of range.
7720
d1f3d2af
PE
7721 Check for buffer and string overflow more precisely.
7722 * buffer.h (BUF_BYTES_MAX): New macro.
7723 * lisp.h (STRING_BYTES_MAX): New macro.
7724 * alloc.c (Fmake_string):
7725 * character.c (string_escape_byte8):
7726 * coding.c (coding_alloc_by_realloc):
7727 * doprnt.c (doprnt):
7728 * editfns.c (Fformat):
7729 * eval.c (verror):
7730 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7731 since they may not be the same number.
7732 * editfns.c (Finsert_char):
7733 * fileio.c (Finsert_file_contents):
7734 Likewise for BUF_BYTES_MAX.
7735
dd52fcea
PE
7736 * image.c: Use ptrdiff_t, not int, for sizes.
7737 (slurp_file): Switch from int to ptrdiff_t.
7738 All uses changed.
7739 (slurp_file): Check that file size fits in both size_t (for
7740 malloc) and ptrdiff_t (for sanity and safety).
7741
7f9bbdbb
PE
7742 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7743 if b->modtime has its maximal value.
7744
dfe18f82
PE
7745 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7746
84acfcf0
PE
7747 Don't assume time_t can fit into int.
7748 * buffer.h (struct buffer.modtime): Now time_t, not int.
7749 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7750 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7751
ccd9a01a
PE
7752 Minor fixes for signed vs unsigned integers.
7753 * character.h (MAYBE_UNIFY_CHAR):
7754 * charset.c (maybe_unify_char):
7755 * keyboard.c (read_char, reorder_modifiers):
7756 XINT -> XFASTINT, since the integer must be nonnegative.
7757 * ftfont.c (ftfont_spec_pattern):
7758 * keymap.c (access_keymap, silly_event_symbol_error):
7759 XUINT -> XFASTINT, since the integer must be nonnegative.
7760 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7761 since it makes no difference and we prefer signed.
7762 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7763 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7764 nonnegative.
7765
d6d100dd
SM
77662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7767
7768 * window.h (Fwindow_frame): Declare.
7769
2b6148e4
PE
77702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7771
7772 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7773 (SPARE_MEMORY): Always define.
7774 (LARGE_REQUEST): Remove.
7775 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7776
f230ecc9
MR
77772011-06-06 Martin Rudalics <rudalics@gmx.at>
7778
727e958e
MR
7779 * lisp.h: Move EXFUNS for Fframe_root_window,
7780 Fframe_first_window and Fset_frame_selected_window to window.h.
7781
7782 * window.h: Move EXFUNS for Fframe_root_window,
7783 Fframe_first_window and Fset_frame_selected_window here from
7784 lisp.h.
7785
7786 * frame.c (Fwindow_frame, Fframe_first_window)
7787 (Fframe_root_window, Fframe_selected_window)
7788 (Fset_frame_selected_window): Move to window.c.
7789 (Factive_minibuffer_window): Move to minibuf.c.
7790 (Fother_visible_frames_p): New function.
7791
7792 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7793
f230ecc9
MR
7794 * window.c (decode_window, decode_any_window): Move up in code.
7795 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7796 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7797 (Fwindow_buffer): Move up and rewrite doc-string.
7798 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7799 (Fwindow_prev): New functions.
727e958e
MR
7800 (Fwindow_frame): Move here from frame.c. Accept any window as
7801 argument.
7802 (Fframe_root_window, Fframe_first_window)
7803 (Fframe_selected_window): Move here from frame.c. Accept frame
7804 or arbitrary window as argument. Update doc-strings.
7805 (Fminibuffer_window): Move up in code.
7806 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7807 (Fset_frame_selected_window): Move here from frame.c.
7808 Marginal rewrite.
727e958e
MR
7809 (Fselected_window, select_window, Fselect_window): Move up in
7810 code. Minor doc-string fixes.
f230ecc9 7811
4d09bcf6
PE
78122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7813
7814 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7815 Do not assume that spare memory exists; that assumption is valid
7816 only if SYSTEM_MALLOC.
7817 (LARGE_REQUEST): New macro, so that the issue of large requests
7818 is separated from the issue of spare memory.
7819
810928a2
AS
78202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7821
172418ad
AS
7822 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7823 format. (Bug#8806)
7824
43f862f7
AS
7825 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7826
810928a2
AS
7827 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7828 before statements.
7829
a059fe24
JD
78302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7831
7832 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7833
7834 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7835
7836 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7837 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7838
989bf368
JB
78392011-06-05 Juanma Barranquero <lekktu@gmail.com>
7840
7841 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7842
4b80f674
CY
78432011-06-04 Chong Yidong <cyd@stupidchicken.com>
7844
7845 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7846 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7847 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7848 New error handlers.
4b80f674
CY
7849 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7850 Obey Vx_select_enable_clipboard_manager. Catch errors in
7851 x_clipboard_manager_save (Bug#8779).
7852 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7853 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7854
99a33b77 78552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7856
7857 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7858
99a33b77 78592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7860
7861 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7862 in the current matrix if keep_current_p is non-zero.
7863
8264569d
EZ
78642011-06-04 Eli Zaretskii <eliz@gnu.org>
7865
7866 * bidi.c (bidi_level_of_next_char): Fix last change.
7867
57f97249
EZ
78682011-06-03 Eli Zaretskii <eliz@gnu.org>
7869
fec2107c 7870 Support bidi reordering of text covered by display properties.
57f97249 7871
fec2107c
EZ
7872 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7873 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7874 (bidi_cache_search, bidi_cache_iterator_state)
7875 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7876 (bidi_level_of_next_char, bidi_move_to_visually_next):
7877 Support character positions inside a run of characters covered by a
fec2107c
EZ
7878 display string.
7879 (bidi_paragraph_init, bidi_resolve_explicit_1)
7880 (bidi_level_of_next_char): Call bidi_fetch_char and
7881 bidi_fetch_char_advance instead of FETCH_CHAR and
7882 FETCH_CHAR_ADVANCE.
7883 (bidi_init_it): Initialize new members.
7884 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7885 definitions.
7886 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7887 instead of using explicit *_CHAR codes.
d6d100dd
SM
7888 (bidi_resolve_explicit, bidi_resolve_weak):
7889 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7890 bidirectional text is supported only in multibyte buffers.
7891 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7892 it to initialize the frame_window_p member of struct bidi_it.
7893 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7894 (bidi_resolve_explicit, bidi_resolve_weak)
7895 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7896 bidi_it->nchars is non-positive.
7897 (bidi_level_of_next_char): Don't try to lookup the cache for the
7898 next/previous character if nothing is cached there yet, or if we
7899 were just reseat()'ed to a new position.
c40e2fb2 7900
0e14fe90
EZ
7901 * xdisp.c (set_cursor_from_row): Set start and stop points
7902 according to the row's direction when priming the loop that looks
7903 for the glyph on which to display cursor.
7904 (single_display_spec_intangible_p): Function deleted.
7905 (display_prop_intangible_p): Reimplement to call
7906 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7907 Accept 3 additional arguments needed by handle_display_spec.
7908 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7909 values: lists, `(when COND...)' forms, etc.
7910 (single_display_spec_string_p): Support property values that are
7911 lists with the argument STRING its top-level element.
7912 (display_prop_string_p): Fix the condition for processing a
7913 property that is a list to be consistent with handle_display_spec.
fec2107c 7914 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7915 last portion of handle_display_prop.
7916 (compute_display_string_pos): Accept additional argument
7917 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7918 value of a `display' property is a "replacing spec".
7919 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7920 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7921 the display property, but just return a value indicating whether
7922 the display property will replace the characters it covers.
7923 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7924 frame_window_p members of struct bidi_it.
d6d100dd
SM
7925 (compute_display_string_pos, compute_display_string_end):
7926 New functions.
fec2107c
EZ
7927 (push_it): Accept second argument POSITION, where pop_it should
7928 jump to continue iteration.
7929 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7930
fec2107c
EZ
7931 * keyboard.c (adjust_point_for_property): Adjust the call to
7932 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7933
7934 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7935 (bidi_init_it): Update prototypes.
7936 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7937 (compute_display_string_pos, compute_display_string_end):
7938 Declare prototypes.
fec2107c
EZ
7939 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7940 EMACS_INT.
fc6f18ce 7941
40087514 79422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7943
57f53182
PE
7944 Malloc failure behavior now depends on size of allocation.
7945 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7946 * lisp.h: Change signatures accordingly.
7947 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7948 All callers changed. (Bug#8762)
7949
7950 * gnutls.c: Use Emacs's memory allocators.
7951 Without this change, the gnutls library would invoke malloc etc.
7952 directly, which causes problems on non-SYNC_INPUT hosts, and which
7953 runs afoul of improving memory_full behavior. (Bug#8761)
7954 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7955 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7956 xfree instead of the default malloc, realloc, free.
7957 (Fgnutls_boot): No need to check for memory allocation failure,
7958 since xmalloc does that for us.
7959
ac32cd99 7960 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7961 * category.c (hash_get_category_set):
7962 * ccl.c (ccl_driver):
7963 * charset.c (Fdefine_charset_internal):
7964 * charset.h (struct charset.hash_index):
7965 * composite.c (get_composition_id, gstring_lookup_cache)
7966 (composition_gstring_put_cache):
7967 * composite.h (struct composition.hash_index):
7968 * dispextern.h (struct image.hash):
7969 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7970 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7971 (hashfn_equal, hashfn_user_defined, make_hash_table)
7972 (maybe_resize_hash_table, hash_lookup, hash_put)
7973 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7974 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7975 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7976 * image.c (make_image, search_image_cache, lookup_image)
7977 (xpm_put_color_table_h):
7978 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7979 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7980 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7981 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7982 * alloc.c (allocate_vectorlike):
7983 Check for overflow in vector size calculations.
7984 * ccl.c (ccl_driver):
7985 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7986 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7987 need to be updated by these changes.
40087514
PE
7988 * fns.c (make_hash_table, maybe_resize_hash_table):
7989 Check for integer overflow with large hash tables.
0de4bb68
PE
7990 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7991 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7992 (SXHASH_REDUCE): New macro.
7993 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7994 Use it instead of discarding useful hash info with large hash values.
7995 (sxhash_float): New function.
7996 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7997 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7998 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7999 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8000 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8001 Adjust signatures to match updated version of code.
8002 (consing_since_gc): Now EMACS_INT, since a single hash table can
8003 use more than INT_MAX bytes.
8004
698d32e2
DN
80052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8006
8007 Make it possible to build with GCC-4.6+ -O2 -flto.
8008
8009 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8010
fd6fa53f
SM
80112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8012
8013 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8014 Call minibuffer-inactive-mode.
8015
864db017
JB
80162011-05-31 Juanma Barranquero <lekktu@gmail.com>
8017
8018 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8019 Update dependencies.
8020
2ad0baf4
DN
80212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8022
8023 * data.c (init_data): Remove code for UTS, this system is not
8024 supported anymore.
8025
4fcc2638
DN
80262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8027
8028 Don't force ./temacs to start in terminal mode.
8029
8030 * frame.c (make_initial_frame): Initialize faces in all cases, not
8031 only when CANNOT_DUMP is defined.
8032 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8033
c56e0fd5
DN
80342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8035
8036 * dispnew.c (add_window_display_history): Use const for the string
8037 pointer. Remove declaration, not needed.
8038
333d54da 80392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8040
55d4c1b2 8041 Use 'inline', not 'INLINE'.
333d54da 8042 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8043 * alloc.c, fontset.c (INLINE): Remove.
8044 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8045 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8046 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8047 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8048 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8049
738db178
DN
80502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8051
8052 Make it possible to run ./temacs.
8053
8054 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8055 syms_of_callproc does the same thing. Remove test for
8056 "initialized", do it in the caller.
8057 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8058
620c53a6
SM
80592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8060
8061 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8062 (read_minibuf): Use get_minibuffer.
8063 (syms_of_minibuf): Use DEFSYM.
8064 (Qmetadata): New var.
8065 * data.c (Qbuffer): Don't make it static.
8066 (syms_of_data): Use DEFSYM.
8067
e003a292
PE
80682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8069
8070 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8071 (CCL_CODE_MIN): New macro.
8072
ed008a6d
PE
80732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8074
3687c2ef
PE
8075 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8076
ed008a6d
PE
8077 * eval.c (Qdebug): Now static.
8078 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8079 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8080 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8081
d66c4c7c
CY
80822011-05-29 Chong Yidong <cyd@stupidchicken.com>
8083
8084 * image.c: Various fixes to ImageMagick code comments.
8085 (Fimagemagick_types): Doc fix.
8086
5fbc2025
PE
80872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8088
0196f88a
PE
8089 Minor fixes prompted by GCC 4.6.0 warnings.
8090
8091 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8092
5fbc2025
PE
8093 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8094 (x_clipboard_manager_save_all): Move extern decl to ...
8095 * xterm.h: ... here, so that it can be checked for consistency.
8096
1dd3c2d9
CY
80972011-05-29 Chong Yidong <cyd@stupidchicken.com>
8098
8099 * xselect.c (x_clipboard_manager_save_frame)
8100 (x_clipboard_manager_save_all): New functions.
8101 (Fx_clipboard_manager_save): Lisp function deleted.
8102
8103 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8104 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8105
8106 * xterm.h: Update prototype.
8107
5ba6571d
WX
81082011-05-28 William Xu <william.xwl@gmail.com>
8109
8110 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8111 exiting (Bug#8239).
8112
3eaff834
JM
81132011-05-28 Jim Meyering <meyering@redhat.com>
8114
e1900994 8115 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8116 * fns.c (to_uchar): Define.
8117 (crypto_hash_function): Use it to convert some newly-signed
8118 variables to unsigned, to avoid sign-extension bugs. For example,
8119 without this change, (md5 "truc") would evaluate to
8120 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8121 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8122 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8123
0f6990a7
PE
81242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8125
8126 Integer overflow fixes.
c8a9ca5a 8127
08686060
PE
8128 * dbusbind.c: Serial number integer overflow fixes.
8129 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8130 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8131 to hold a serial number that is too large for a fixnum.
8132 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8133 Check for serial numbers out of range. Decode any serial number
59568bf0 8134 that was so large that it became a float. (Bug#8722)
08686060 8135
2d1fc3c7
PE
8136 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8137 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8138 Use XFASTINT rather than XUINT when numbers are nonnegative.
8139 (xd_append_arg, Fdbus_method_return_internal):
8140 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8141 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8142 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8143 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8144 (Bug#8722)
2d1fc3c7 8145
c8a9ca5a
PE
8146 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8147
519e1d69
PE
8148 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8149
6df6ae42 8150 ccl: Add integer overflow checks.
30569699
PE
8151 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8152 (IN_INT_RANGE): New macros.
8153 (ccl_driver): Use them to check for integer overflow when
8154 decoding a CCL program. Many of the new checks are whether XINT (x)
8155 fits in int; it doesn't always, on 64-bit hosts. The new version
8156 doesn't catch all possible integer overflows, but it's an
847044ea 8157 improvement. (Bug#8719)
30569699 8158
c11285dc
PE
8159 * alloc.c (make_event_array): Use XINT, not XUINT.
8160 There's no need for unsigned here.
8161
fdccd48e
PE
8162 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8163 This follows up to the 2011-05-06 change that substituted uintptr_t
8164 for EMACS_INT. This case wasn't caught back then.
8165
37910ab2
PE
8166 Rework Fformat to avoid integer overflow issues.
8167 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8168 now (part of C89). Include <verify.h>.
8169 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8170 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8171 (Fformat): Avoid the prepass trying to compute sizes; it was only
8172 approximate and thus did not catch overflow reliably. Instead, walk
8173 through the format just once, formatting and computing sizes as we go,
8174 checking for integer overflow at every step, and allocating a larger
8175 buffer as needed. Keep track separately whether the format is
8176 multibyte. Keep only the most-recently calculated precision, rather
8177 than them all. Record whether each argument has been converted to
8178 string. Use EMACS_INT, not int, for byte and char and arg counts.
8179 Support field widths and precisions larger than INT_MAX. Avoid
8180 sprintf's undefined behavior with conversion specifications such as %#d
8181 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8182 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8183 formatting out-of-range floating point numbers with int
9173deec 8184 formats. (Bug#8668)
37910ab2 8185
2e6578fb
PE
8186 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8187
0ae6bdee
PE
8188 * data.c: Avoid integer truncation in expressions involving floats.
8189 * data.c: Include <intprops.h>.
8190 (arith_driver): When there's an integer overflow in an expression
8191 involving floating point, convert the integers to floating point
8192 so that the resulting value does not suffer from catastrophic
8193 integer truncation. For example, on a 64-bit host (* 4
8194 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8195 Do not rely on undefined behavior after integer overflow.
8196
de883a70
PE
8197 merge count_size_as_multibyte, parse_str_to_multibyte
8198 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8199 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8200 Check for integer overflow.
8201 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8202 since it's now a duplicate of the other. This is more of
8203 a character than a buffer op, so better that it's in character.c.
8204 * fns.c, print.c: Adjust to above changes.
8205
2ff916cb
PE
82062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8207
8208 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8209
f1b54466
PE
82102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8211
fb1ac845
PE
8212 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8213 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8214 (x_clipboard_manager_save): Now static.
8215 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8216
f1b54466
PE
8217 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8218 (crypto_hash_function): Now static.
8219 Fix pointer signedness problems. Avoid unnecessary initializations.
8220
a9f737ee
CY
82212011-05-27 Chong Yidong <cyd@stupidchicken.com>
8222
8223 * termhooks.h (Vselection_alist): Make it terminal-local.
8224
8225 * terminal.c (create_terminal): Initialize it.
8226
8227 * xselect.c: Support for clipboard managers.
8228 (Vselection_alist): Move to termhooks.h as terminal-local var.
8229 (LOCAL_SELECTION): New macro.
8230 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8231 (symbol_to_x_atom): Remove gratuitous arg.
8232 (x_handle_selection_request, lisp_data_to_selection_data)
8233 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8234 (x_own_selection, x_get_local_selection, x_convert_selection):
8235 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8236 (some_frame_on_display): Delete unused function.
8237 (Fx_own_selection_internal, Fx_get_selection_internal)
8238 (Fx_disown_selection_internal, Fx_selection_owner_p)
8239 (Fx_selection_exists_p): New optional frame arg.
8240 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8241 (x_handle_selection_clear): Don't treat other terminals with the
8242 same keyboard specially. Use the terminal-local Vselection_alist.
8243 (x_clear_frame_selections): Use Frun_hook_with_args.
8244
8245 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8246
8247 * xterm.h: Add support for those atoms.
8248
e067f0c1
CY
82492011-05-26 Chong Yidong <cyd@stupidchicken.com>
8250
8251 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8252 (converted_selections, conversion_fail_tag): New global variables.
8253 (x_selection_request_lisp_error): Free the above.
8254 (x_get_local_selection): Remove unnecessary code.
8255 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8256 of converted selections stored in converted_selections.
8257 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8258 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8259 (x_convert_selection): New function.
8260 (x_handle_selection_event): Simplify.
8261 (x_get_foreign_selection): Don't ignore incoming requests while
8262 waiting for an answer; this will fail when we implement
8263 SAVE_TARGETS, and seems unnecessary anyway.
8264 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8265 (Vx_sent_selection_functions): Doc fix.
8266
0f4aebc0
LL
82672011-05-26 Leo Liu <sdl.web@gmail.com>
8268
8269 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8270
e61124cd
YM
82712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8272
8273 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8274
8275 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8276 for fringe update if it has periodic bitmap.
ac389d0c 8277 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8278 and fringe_bitmap_periodic_p.
8279
8280 * fringe.c (get_fringe_bitmap_data): New function.
8281 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8282 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8283 row. Mark glyph row for fringe update if periodicity changed.
8284
8285 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8286 for fringe update unless it has periodic bitmap.
8287
f16d9837
KH
82882011-05-25 Kenichi Handa <handa@m17n.org>
8289
8290 * xdisp.c (get_next_display_element): Set correct it->face_id for
8291 a static composition.
8292
e1b90ef6
LL
82932011-05-24 Leo Liu <sdl.web@gmail.com>
8294
8295 * deps.mk (fns.o):
8296 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8297
8298 * fns.c (crypto_hash_function, Fsha1): New function.
8299 (Fmd5): Use crypto_hash_function.
8300 (syms_of_fns): Add Ssha1.
8301
7400048f
PE
83022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8303
8304 * gnutls.c: Remove unused macros.
8305 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8306 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8307 Remove macros that are defined and never used.
8308 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8309
abb71cf4
CY
83102011-05-22 Chong Yidong <cyd@stupidchicken.com>
8311
8312 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8313 (Fx_get_selection_internal): Minor cleanup.
8314 (Fx_own_selection_internal): Rename arguments for consistency with
8315 select.el.
8316
6307db39
PE
83172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8318
8319 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8320
f3d4e0a4
CY
83212011-05-22 Chong Yidong <cyd@stupidchicken.com>
8322
8323 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8324
4d8ade89
YM
83252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8326
8327 * dispnew.c (scrolling_window): Don't exclude the case that the
8328 last enabled row in the desired matrix touches the bottom boundary.
8329
32078c8d
GM
83302011-05-21 Glenn Morris <rgm@gnu.org>
8331
8332 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8333 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8334 and add some more files.
32078c8d 8335
7285dc67
EZ
83362011-05-20 Eli Zaretskii <eliz@gnu.org>
8337
8338 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8339 report_file_error introduced by the change from 2011-05-07.
8340
89d1bd22
PE
83412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8342
8343 * systime.h (Time): Define only if emacs is defined.
8344 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8345 where the include path doesn't have X11/X.h by default. See
8346 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8347
cd394be1 83482011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8349
8350 * composite.c (find_automatic_composition): Fix previous change.
8351
b9704ad9
GM
83522011-05-20 Glenn Morris <rgm@gnu.org>
8353
8354 * lisp.mk: New file, split from Makefile.in.
8355 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8356 (shortlisp): Remove.
8357 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8358
4a720484
GM
83592011-05-19 Glenn Morris <rgm@gnu.org>
8360
8361 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8362 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8363 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8364 (lisp): Set the order to that of loadup.el.
8365 (shortlisp): Make it a copy of $lisp.
8366 (SOME_MACHINE_LISP): Remove.
8367 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8368 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8369
a28d4396
KH
83702011-05-18 Kenichi Handa <handa@m17n.org>
8371
8372 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8373 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8374 (find_automatic_composition): Mostly rewrite for efficiency.
8375
a2b1fa8e
JB
83762011-05-18 Juanma Barranquero <lekktu@gmail.com>
8377
8378 * makefile.w32-in: Update dependencies.
8379
8e1f5610
CS
83802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8381
8382 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8383 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8384
7025ee00 83852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8386
cdfa6eab
PE
8387 Fix some integer overflow issues, such as string length overflow.
8388
06d6db33
PE
8389 * insdel.c (count_size_as_multibyte): Check for string overflow.
8390
2b4560a8
PE
8391 * character.c (lisp_string_width): Check for string overflow.
8392 Use EMACS_INT, not int, for string indexes and lengths; in
8393 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8394 the resulting string length overflows an EMACS_INT; instead,
8395 report a string overflow if no precision given. When checking for
8396 precision exhaustion, use a check that cannot possibly have
8397 integer overflow. (Bug#8675)
8398 * character.h (lisp_string_width): Adjust to new signature.
8399
cb93f9be
PE
8400 * alloc.c (string_overflow): New function.
8401 (Fmake_string): Use it. This doesn't change behavior, but saves
8402 a few bytes and will simplify future changes.
8403 * character.c (string_escape_byte8): Likewise.
8404 * lisp.h (string_overflow): New decl.
8405
1a1f3366
PE
8406 Fixups, following up to the user-interface timestamp change.
8407 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8408 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8409 * msdos.c (mouse_get_pos): Likewise.
8410 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8411 * w32gui.h (Time): Define by including "systime.h" rather than by
8412 declaring it ourselves. (Bug#8664)
8413
d4e3e4d3
PE
8414 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8415 * image.c (clear_image_cache): Likewise.
8416
f6a24d19
PE
8417 * term.c (term_mouse_position): Don't assume time_t wraparound.
8418
08dc5ae6
PE
8419 Be more systematic about user-interface timestamps.
8420 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8421 and sometimes 'EMACS_UINT', to represent these timestamps.
8422 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8423 This makes the code easier to follow, and makes it easier to catch
8424 integer overflow bugs such as Bug#8664.
8425 * frame.c (Fmouse_position, Fmouse_pixel_position):
8426 Use Time, not unsigned long, for user-interface timestamps.
8427 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8428 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8429 * keyboard.h (last_event_timestamp): Likewise.
8430 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8431 * menu.h (xmenu_show): Likewise.
8432 * term.c (term_mouse_position): Likewise.
8433 * termhooks.h (struct input_event.timestamp): Likewise.
8434 (struct terminal.mouse_position_hook): Likewise.
8435 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8436 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8437 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8438 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8439 what it was before.
8440 * menu.h, termhooks.h: Include "systime.h", for Time.
8441
8e55734a
PE
8442 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8443 Don't assume that the difference between two unsigned long values
8444 can fit into an integer. At this point, we know button_down_time
8445 <= event->timestamp, so the difference must be nonnegative, so
8446 there's no need to cast the result if double-click-time is
8447 nonnegative, as it should be; check that it's nonnegative, just in
8448 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8449 apart (about 25 days). (Bug#8664)
8e55734a 8450
841f1b75 8451 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8452 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8453
3e26f69c
PE
8454 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8455 that always fit in int. Use a sentinel instead of a counter, to
8456 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8457 * frame.h (struct frame): Use int for menu_bar_items_used
8458 instead of EMACS_INT, since it always fits in int.
3e26f69c 8459
5cc152c0
PE
8460 * menu.c (grow_menu_items): Check for int overflow.
8461
d89eb65e
PE
8462 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8463
5235bd3e
PE
8464 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8465 Before, the code was not consistent. These values cannot exceed
8466 2**31 - 1 so there's no need to make them unsigned.
8467 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8468 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8469 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8470 as modifiers.
8471 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8472
bc827e23
PE
8473 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8474 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8475 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8476 presumably because the widths might not match.
8477
78eb494e
PE
8478 * window.c (size_window): Avoid needless test at loop start.
8479
04f2d78b
CB
84802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8481
8482 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8483
d2fc7e3d 84842011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8485
8486 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8487
d2fc7e3d 84882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8489
8490 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8491 `width' to `bar_area_x' and `bar_area_width', respectively.
8492 (x_scroll_run): Take account of fringe background extension.
8493
04f2d78b
CB
8494 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8495 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8496 `bar_area_width', respectively.
8497 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8498 background extension.
8499
79b70037
GM
85002011-05-10 Jim Meyering <meyering@redhat.com>
8501
8502 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8503
2f142cc5
JB
85042011-05-10 Juanma Barranquero <lekktu@gmail.com>
8505
8506 * image.c (Finit_image_library): Return t for built-in image types,
8507 like pbm and xbm. (Bug#8640)
8508
57679c86
AS
85092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8510
8511 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8512
888c9e86
EZ
85132011-05-07 Eli Zaretskii <eliz@gnu.org>
8514
b0512a1d
EZ
8515 * w32console.c (Fset_screen_color): Doc fix.
8516 (Fget_screen_color): New function.
8517 (syms_of_ntterm): Defsubr it.
8518
7285dc67
EZ
8519 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8520 unlink the temporary file if Fcall_process didn't create it in the
8521 first place.
8522 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8523 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8524 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8525 cue to call_process_cleanup not to close that handle.
8526
4d3fcc8e
BK
85272011-05-07 Ben Key <bkey76@gmail.com>
8528
8529 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8530 one of two shell specific rules, either bootstrap-temacs-CMD or
8531 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8532 to the previous implementation of the bootstrap-temacs rule.
8533 The bootstrap-temacs-CMD rule is similar to the previous
8534 implementation of the bootstrap-temacs rule except that it
8535 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8536 variable.
8537
8538 These changes, along with some changes to nt/configure.bat,
8539 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8540 earlier fix to add support for --cflags and --ldflags options
8541 that include quotes so that it works whether make uses cmd or
8542 sh as the shell.
8543
b4289b64
MA
85442011-05-06 Michael Albinus <michael.albinus@gmx.de>
8545
8546 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8547 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8548 is a constant.
8549 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8550 a string. Handle both cases.
8551 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8552 (Fdbus_register_method): Use Qinvalid_function.
8553
af4c0e28
JB
85542011-05-06 Juanma Barranquero <lekktu@gmail.com>
8555
8556 * makefile.w32-in: Update dependencies.
8557 (LISP_H): Add inttypes.h and stdin.h.
8558 (PROCESS_H): Add unistd.h.
8559
c51453d9
EZ
85602011-05-06 Eli Zaretskii <eliz@gnu.org>
8561
8562 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8563 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8564
8ff0ac3c 85652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8566
4c4b566b
PE
8567 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8568
aab2b9b5
PE
8569 * term.c (vfatal): Remove stray call to va_end.
8570 It's not needed and the C Standard doesn't allow it here anyway.
8571
c378da0b
PE
8572 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8573 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8574
288b08c7
PE
8575 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8576 bytes.
8577
e3601888
PE
8578 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8579
db6c0e74
PE
8580 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8581
dd5963ea
PE
8582 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8583
88c9450f
PE
8584 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8585
2f9442b8
PE
8586 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8587
c032b5f8
PE
8588 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8589 * charset.c (Fdefine_charset_internal): Don't initialize
8590 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8591 32-bit int (Bug#8600).
a108c10b
PE
8592
8593 * lread.c (read_integer): Be more consistent with string-to-number.
8594 Use string_to_number to do the actual conversion; this avoids
8595 rounding errors and fixes some other screwups. Without this fix,
8596 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8597 (digit_to_number): Move earlier, for benefit of read_integer.
8598 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8599 not a digit in any supported base. (Bug#8602)
a108c10b 8600
ad5f9eea
PE
8601 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8602
aec1708a
PE
8603 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8604 to match comment at start of function. This also removes a
8605 GCC warning about overflow in a 32+64-bit port.
8606
47be4ab5
PE
8607 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8608
371cac43
PE
8609 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8610 Reported by Stefan Monnier in
8611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8612 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8613 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8614
d01a7826
PE
8615 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8616 (EMACS_UINTPTR): Likewise, with uintptr_t.
8617
7fd47d5c
PE
8618 * lisp.h: Prefer 64-bit EMACS_INT if available.
8619 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8620 on 32-bit hosts that have 64-bit int, so that they can access
8621 large files.
122b0c86
PE
8622 However, temporarily disable this change unless the temporary
8623 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8624
8727937b
PE
8625 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8626
8ac068ac
PE
8627 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8628 This removes an assumption that EMACS_INT and long are the same
8629 width as pointers. The assumption is true for Emacs porting targets
8630 now, but we want to make other targets possible.
8631 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8632 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8633 In the rest of the code, change types of integers that hold casted
8634 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8635 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8636 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8637 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8638 No need to cast type when ORing.
8639 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8640 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8641 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8642 assume EMACS_INT is the same width as char *.
8643 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8644 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8645 Remove no-longer-needed casts.
8646 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8647 (xg_tool_bar_help_callback, xg_make_tool_item):
8648 Use EMACS_INTPTR to hold an integer
8649 that will be cast to void *; this can avoid a GCC warning
8650 if EMACS_INT is not the same width as void *.
8651 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8652 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8653 (current_message_1, set_message_1):
8654 Use a local to convert to proper width without a cast.
8655 * xmenu.c (dialog_selection_callback): Likewise.
8656
ede49d71
PE
8657 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8658 Also, don't assume VALBITS / RAND_BITS is less than 5,
8659 and don't rely on undefined behavior when shifting a 1 left into
8660 the sign bit.
8661 * lisp.h (get_random): Change signature to match.
8662
2f30ecd0
PE
8663 * lread.c (hash_string): Use size_t, not int, for hash computation.
8664 Normally we prefer signed values; but hashing is special, because
8665 it's better to use unsigned division on hash table sizes so that
8666 the remainder is nonnegative. Also, size_t is the natural width
8667 for hashing into memory. The previous code used 'int', which doesn't
8668 retain enough info to hash well into very large tables.
8669 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8670
2a866e7b
PE
8671 * dbusbind.c: Don't possibly lose pointer info when converting.
8672 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8673 Use XPNTR rather than XHASH, so that the high-order bits of
8674 the pointer aren't lost when converting through void *.
8675
51639eac
PE
8676 * eval.c (Fautoload): Don't double-shift a pointer.
8677
92394119
PE
8678 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8679
dbdb9a7c
JB
86802011-05-06 Juanma Barranquero <lekktu@gmail.com>
8681
8682 * gnutls.c (DEF_GNUTLS_FN):
8683 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8684
db7a0b4f
AS
86852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8686
8687 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8688 marker. (Bug#8610)
8689
cd394be1 86902011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8691
8692 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8693 New version that can reserve upto 2GB of heap space.
8694
f7ff1b0f 86952011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8696
8697 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8698
639c109b
TZ
86992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8700
8701 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8702 `gnutls_certificate_set_x509_key_file'.
8703
d2127135
JB
87042011-05-05 Juanma Barranquero <lekktu@gmail.com>
8705
8706 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8707 Update dependencies.
8708
e968f4f3
JB
87092011-05-04 Juanma Barranquero <lekktu@gmail.com>
8710
8711 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8712 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8713 Remove unused parameter `fildes'.
8714 * process.c (read_process_output, send_process): Don't pass it.
8715
84d358f0
JB
87162011-05-04 Juanma Barranquero <lekktu@gmail.com>
8717
8718 Fix previous change: the library cache is defined in w32.c.
8719 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8720 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8721
0898ca10
JB
87222011-05-04 Juanma Barranquero <lekktu@gmail.com>
8723
8724 Implement dynamic loading of GnuTLS on Windows.
8725
8726 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8727 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8728 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8729 Declare.
8730
8731 * gnutls.c (Qgnutls_dll): Define.
8732 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8733 (gnutls_*): Declare function pointers.
8734 (init_gnutls_functions): New function to initialize function pointers.
8735 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8736 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8737 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8738 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8739 (emacs_gnutls_write, emacs_gnutls_read)
8740 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8741 (Fgnutls_available_p): New function.
8742 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8743 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8744 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8745
8746 * image.c: Include w32.h.
8747 (Vimage_type_cache): Delete.
8748 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8749 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8750 (w32_delayed_load): Move to w32.c.
8751
8752 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8753
8754 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8755 (w32_delayed_load): Move from image.c. When loading a library, record
8756 its filename in the :loaded-from property of the library id.
8757 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8758 Initialize and staticpro them.
8759 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8760
8761 * process.c: Include lisp.h before w32.h, not after.
8762 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8763 instead of gnutls_record_check_pending.
8764
8765 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8766
ff4de4aa
TZ
87672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8768
8769 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8770 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8771 as passed in.
8772
abe95abb
JD
87732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8774
8775 * xterm.c (x_set_frame_alpha): Do not set property on anything
8776 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8777
e16e55d4
JB
87782011-05-02 Juanma Barranquero <lekktu@gmail.com>
8779
8780 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8781
bafcf6a5
JB
87822011-05-02 Juanma Barranquero <lekktu@gmail.com>
8783
8784 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8785 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8786 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8787 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8788 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8789 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8790 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8791 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8792 (Qgnutls_bootprop_callbacks_verify): Make static.
8793
e7a6747f
AS
87942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8795
19ed11ba
AS
8796 * callproc.c: Indentation fixup.
8797
e7a6747f 8798 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8799 (wait_for_termination, interruptible_wait_for_termination):
8800 Move after wait_for_termination_1.
e7a6747f 8801
1ef14cb4
LMI
88022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8803
8804 * sysdep.c (interruptible_wait_for_termination): New function
8805 which is like wait_for_termination, but allows keyboard
8806 interruptions.
8807
8808 * callproc.c (Fcall_process): Add (:file "file") as an option for
8809 the STDOUT buffer.
8810 (Fcall_process_region): Ditto.
8811
330d880c
EZ
88122011-04-30 Eli Zaretskii <eliz@gnu.org>
8813
8db90b73
EZ
8814 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8815 rather than `XVECTOR (FOO)->size'.
8816
330d880c
EZ
8817 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8818 inttypes.h, as a gnulib replacement is used if it not available in
8819 system headers.
8820
15cbd324
EZ
88212011-04-21 Eli Zaretskii <eliz@gnu.org>
8822
8823 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8824 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8825 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8826
8827 * coding.c (coding_alloc_by_realloc): Error out if destination
8828 will grow beyond MOST_POSITIVE_FIXNUM.
8829 (decode_coding_emacs_mule): Abort if there isn't enough place in
8830 charbuf for the composition carryover bytes. Reserve an extra
8831 space for up to 2 characters produced in a loop.
8832 (decode_coding_iso_2022): Abort if there isn't enough place in
8833 charbuf for the composition carryover bytes.
8834
88352011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8836
ae940cca
EZ
8837 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8838 aborting when %lld or %lll format is passed.
8839 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8840 %llo or %llx format is passed. (Bug#8545)
8841
03ab8921
EZ
8842 * window.c (window_scroll_line_based): Use a marker instead of
8843 simple variables to record original value of point. (Bug#7952)
8844
afda1437
EZ
8845 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8846 produced by %s or %c overflows available buffer space. (Bug#8545)
8847
f76dee0c
PE
88482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8849
8850 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8851 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8852
fdc5744d
JB
88532011-04-28 Juanma Barranquero <lekktu@gmail.com>
8854
8855 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8856
638f053a
JB
88572011-04-28 Juanma Barranquero <lekktu@gmail.com>
8858
8859 * keyboard.c (Qdelayed_warnings_hook): Define.
8860 (command_loop_1): Run `delayed-warnings-hook'
8861 if Vdelayed_warnings_list is non-nil.
8862 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8863 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8864
d178f871
EZ
88652011-04-28 Eli Zaretskii <eliz@gnu.org>
8866
8867 * doprnt.c (doprnt): Don't return value smaller than the buffer
8868 size if the message was truncated. (Bug#8545).
8869
b124fd93
JB
88702011-04-28 Juanma Barranquero <lekktu@gmail.com>
8871
8872 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8873 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8874
e810457d
PE
88752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8876
8877 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8878
ea51cceb
JB
88792011-04-27 Juanma Barranquero <lekktu@gmail.com>
8880
8881 * makefile.w32-in: Update dependencies.
8882
94dcfacf
EZ
88832011-04-27 Eli Zaretskii <eliz@gnu.org>
8884
8885 Improve `doprnt' and its usage. (Bug#8545)
8886 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8887 `format_end'. Remove support for %l as a conversion specifier.
8888 Don't use xrealloc. Improve diagnostics when the %l size modifier
8889 is used. Update the commentary.
8890
8891 * eval.c (verror): Simplify calculation of size_t.
8892
8893 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8894 messages.
8895
f61f41d7
PE
88962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8897
8898 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8899 change.
8900
96fb4434
PE
89012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8902
8903 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8904 This makes this file independent of the recent pseudovector change.
8905
671875da 89062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8907
69e9b5a3
PE
8908 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8909
b5f869a7 8910 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8911 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8912 Remove unused local.
c8926152 8913 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8914
841a1577 8915 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8916 GCC 4.6.0 optimizes based on type-based alias analysis.
8917 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8918 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8919 != &v->size, and therefore "v->size = 1; b->size = 2; return
8920 v->size;" must therefore return 1. This assumption is incorrect
8921 for Emacs, since it type-puns struct Lisp_Vector * with many other
8922 types. To fix this problem, this patch adds a new type struct
f904488f 8923 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8924 and pseudovectors, and helps optimizing compilers not get fooled
8925 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8926 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8927 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8928 the size member.
eab3844f
PE
8929 (XSETPVECTYPE): Rewrite in terms of new macro.
8930 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8931 This is a bit clearer, and further avoids the possibility of
8932 undesirable aliasing.
8933 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8934 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8935 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8936 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8937 (ASIZE): Now uses header.size rather than size.
8938 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8939 to avoid the hassle of writing XVECTOR (foo)->header.size.
8940 (struct vectorlike_header): New type.
eab3844f
PE
8941 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8942 object, to help avoid aliasing.
8943 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8944 (SUBRP): Likewise, since Lisp_Subr is a special case.
8945 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8946 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8947 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8948 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8949 changed to be "header.size" and "header.next".
8950 * buffer.h (struct buffer): Likewise.
8951 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8952 * frame.h (struct frame): Likewise.
8953 * process.h (struct Lisp_Process): Likewise.
8954 * termhooks.h (struct terminal): Likewise.
8955 * window.c (struct save_window_data, struct saved_window): Likewise.
8956 * window.h (struct window): Likewise.
8957 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8958 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8959 * buffer.c (init_buffer_once): Likewise.
8960 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8961 special case.
8962 * process.c (Fformat_network_address): Use local var for size,
8963 for brevity.
8964
0df1eac5
PE
8965 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8966
847ab9d1 8967 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8968 * data.c (atof): Remove decl; no longer used or needed.
8969 (digit_to_number): Move to lread.c.
8970 (Fstring_to_number): Use new string_to_number function, to be
8971 consistent with how the Lisp reader treats infinities and NaNs.
8972 Do not assume that floating-point numbers represent EMACS_INT
8973 without losing information; this is not true on most 64-bit hosts.
8974 Avoid double-rounding errors, by insisting on integers when
8975 parsing non-base-10 numbers, as the documentation specifies.
8976 * lisp.h (string_to_number): New decl, replacing ...
8977 (isfloat_string): Remove.
bc0a5c13 8978 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8979 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8980 appears to have been a coding error. Similarly, do not accept
8981 strings like +-1e0 as floating point numbers. Do not report
8982 overflow for integer overflows unless the base is not 10 which
8983 means we have no simple and reliable way to continue.
8984 Break out the floating-point parsing into a new
8985 function string_to_number, so that Fstring_to_number parses
8986 floating point numbers consistently with the Lisp reader.
04f2d78b 8987 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8988 (E_CHAR, EXP_INT): Remove, replacing with ...
8989 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8990 (string_to_number): New function, replacing isfloat_string.
8991 This function checks for valid syntax and produces the resulting
8992 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8993 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8994 so that overflow for non-base-10 numbers is reported only when
8995 there's no portable and simple way to convert to floating point.
452f4150 8996
67769ffc
PE
8997 * textprop.c (set_text_properties_1): Rewrite for clarity,
8998 and to avoid GCC warning about integer overflow.
8999
c20db43f
PE
9000 * intervals.h (struct interval): Use EMACS_INT for members
9001 where EMACS_UINT might cause problems. See
9002 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9003 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9004 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9005 All uses changed.
37aa2f85
PE
9006 (offset_intervals): Tell GCC not to worry about length overflow
9007 when negating a negative length.
c20db43f 9008
2538aa2f
PE
9009 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9010 (overrun_check_free): Likewise.
9011
f2d3008d
PE
9012 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9013 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9014 word size.
9015
ec8df744
PE
9016 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9017 (gnutls_make_error): Rename local to avoid shadowing.
9018 (gnutls_emacs_global_deinit): ifdef out; not used.
9019 (Fgnutls_boot): Use const for pointer to readonly storage.
9020 Comment out unused local. Fix pointer signedness problems.
9021
640ee02d
PE
9022 * lread.c (openp): Don't stuff size_t into an 'int'.
9023 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9024 about possible signed overflow.
9025
6048fb2a
PE
9026 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9027 (GDK_KEY_g): Don't define if already defined.
9028 (xg_prepare_tooltip): Avoid pointer signedness problem.
9029 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9030
fa3c87e1
PE
9031 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9032 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9033
2172544b
PE
9034 * xfns.c (Fx_window_property): Simplify a bit,
9035 to make a bit faster and to avoid GCC 4.6.0 warning.
9036 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9037
9b821a21
PE
9038 * fns.c (internal_equal): Don't assume size_t fits in int.
9039
3c616cfa
PE
9040 * alloc.c (compact_small_strings): Tighten assertion a little.
9041
c2982e87
PE
9042 Replace pEd with more-general pI, and fix some printf arg casts.
9043 * lisp.h (pI): New macro, generalizing old pEd macro to other
9044 conversion specifiers. For example, use "...%"pI"d..." rather
9045 than "...%"pEd"...".
9046 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9047 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9048 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9049 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9050 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9051 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9052 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9053 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9054 64-bit hosts.
9055 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9056 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9057 * print.c (safe_debug_print, print_object): Likewise.
9058 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9059 to int.
6f04d126
PE
9060 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9061 avoiding the 0 flag, which is not portable.
c2982e87
PE
9062 * process.c (Fmake_network_process): Use pI to avoid cast.
9063 * region-cache.c (pp_cache): Likewise.
9064 * xdisp.c (decode_mode_spec): Likewise.
9065 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9066 behavior on 64-bit hosts with printf arg.
6f04d126 9067 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9068 (x_stop_queuing_selection_requests): Likewise.
9069 (x_get_window_property): Don't truncate byte count to an 'int'
9070 when tracing.
0b432f21 9071
5e073ec7
PE
9072 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9073 here, since it parses constructs like leading '-' and spaces,
9074 which are not wanted; and it overflows with large numbers.
9075 Instead, simply match F[0-9]+, which is what is wanted anyway.
9076
36372bf9
PE
9077 * alloc.c: Remove unportable assumptions about struct layout.
9078 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9079 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9080 (allocate_vectorlike, make_pure_vector): Use the new macros,
9081 plus offsetof, to remove unportable assumptions about struct layout.
9082 These assumptions hold on all porting targets that I know of, but
9083 they are not guaranteed, they're easy to remove, and removing them
9084 makes further changes easier.
9085
0b432f21
PE
9086 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9087 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9088 (string_overrun_cookie): Now const. Use initializers that
9089 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9090 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9091 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9092 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9093 multiple of sizeof (EMACS_INT); it need not be, if
9094 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9095 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9096
895009e1
JB
90972011-04-26 Juanma Barranquero <lekktu@gmail.com>
9098
9099 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9100
6a7a1b0b
TZ
91012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9102
9103 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9104 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9105 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9106
841a1577 91072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9108
9109 * lisp.h (Qdebug): List symbol.
895009e1 9110 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9111 * keyboard.c (debug-on-event): New variable.
9112 (handle_user_signal): Break into debugger when debug-on-event
9113 matches the current signal symbol.
9114
f2d3ba6f
DN
91152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9116
9117 * alloc.c (check_sblock, check_string_bytes)
9118 (check_string_free_list): Convert to standard C.
9119
42ce4c63
TZ
91202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9121
9122 * w32.c (emacs_gnutls_push): Fix typo.
9123
825cd63c
EZ
91242011-04-25 Eli Zaretskii <eliz@gnu.org>
9125
fb11d64d
EZ
9126 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9127 "cast to pointer from integer of different size".
9128
825cd63c
EZ
9129 Improve doprnt and its use in verror. (Bug#8545)
9130 * doprnt.c (doprnt): Document the set of format control sequences
9131 supported by the function. Use SAFE_ALLOCA instead of always
9132 using `alloca'.
9133
9134 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9135 is one byte too soon. Don't use xrealloc; instead xfree and
9136 xmalloc anew.
9137
e061a11b
TZ
91382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9139
9140 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9141 callbacks stage.
9142
9143 * gnutls.c: Renamed global_initialized to
9144 gnutls_global_initialized. Added internals for the
9145 :verify-hostname-error, :verify-error, and :verify-flags
9146 parameters of `gnutls-boot' and documented those parameters in the
9147 docstring. Start callback support.
9173deec
JB
9148 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9149 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9150 on error. Return error code.
e061a11b
TZ
9151 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9152 (emacs_gnutls_read): Likewise.
9153 (Fgnutls_boot): Return handshake error code.
9154 (emacs_gnutls_handle_error): New function.
9155 (wsaerror_to_errno): Likewise.
9156
9157 * w32.h (emacs_gnutls_pull): Add prototype.
9158 (emacs_gnutls_push): Likewise.
9159
9160 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9161 (emacs_gnutls_push): Likewise.
9162
91632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9164
9165 * process.c (wait_reading_process_output): Check if GnuTLS
9166 buffered some data internally if no FDs are set for TLS
9167 connections.
9168
9169 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9170 (LIBS): Link to USER_LIBS.
9171 ($(BLD)/gnutls.$(0)): New target.
9172
fa6996bc
EZ
91732011-04-24 Eli Zaretskii <eliz@gnu.org>
9174
eb35682e
EZ
9175 * xdisp.c (handle_single_display_spec): Rename the
9176 display_replaced_before_p argument into display_replaced_p, to
9177 make it consistent with the commentary. Fix typos in the
9178 commentary.
9179
e2ad650c
EZ
9180 * textprop.c (syms_of_textprop): Remove dead code.
9181 (copy_text_properties): Delete obsolete commentary about an
9182 interface that was deleted long ago. Fix typos in the description
9183 of arguments.
9184
1b2de274
EZ
9185 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9186 to changes in oldXMenu/XMenu.h from 2011-04-16.
9187 <menu_help_message, prev_menu_help_message>: Constify.
9188 (IT_menu_make_room): menu->help_text is now `const char **';
9189 adjust.
9190
9191 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9192 to changes in oldXMenu/XMenu.h from 2011-04-16.
9193 (struct XMenu): Declare `help_text' `const char **'.
9194
9195 * xfaces.c <Qunspecified>: Make extern again.
9196
9197 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9198 required by POSIX.
1b2de274 9199
762b15be
EZ
9200 * doc.c (get_doc_string): Improve the format passed to `error'.
9201
9202 * doprnt.c (doprnt): Improve commentary.
9203
9204 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9205
9206 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9207 them with etags.
9208
f1052e5d
EZ
9209 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9210 changes in globals.h immediately force recompilation.
762b15be
EZ
9211 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9212 $(CURDIR)/s/ms-w32.h.
9213 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9214
fa6996bc
EZ
9215 * character.c (Fchar_direction): Function deleted.
9216 (syms_of_character): Don't defsubr it.
9217 <char-direction-table>: Deleted.
9218
e6c3da20
EZ
92192011-04-23 Eli Zaretskii <eliz@gnu.org>
9220
9221 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9222 * doprnt.c: Include limits.h.
9223 (SIZE_MAX): New macro.
04f2d78b
CB
9224 (doprnt): Return a size_t value. 2nd arg is now size_t.
9225 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9226 Improve overflow protection. Support `l' modifier for integer
9227 conversions. Support %l conversion. Don't assume an EMACS_INT
9228 argument for integer conversions and for %c.
9229
9230 * lisp.h (doprnt): Restore prototype.
9231
9232 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9233 $(SRC)/character.h.
9234
9235 * Makefile.in (base_obj): Add back doprnt.o.
9236
9237 * deps.mk (doprnt.o): Add back prerequisites.
9238 (callint.o): Depend on character.h.
9239
9240 * eval.c (internal_lisp_condition_case): Include the handler
9241 representation in the error message.
9242 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9243 when breaking from the loop.
9244
9245 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9246
9247 * callint.c (Fcall_interactively): When displaying error message
9248 about invalid control letter, pass the character's codepoint, not
9249 a pointer to its multibyte form. Improve display of the character
9250 in octal and display also its hex code.
9251
9252 * character.c (char_string): Use %x to display the (unsigned)
9253 codepoint of an invalid character, to avoid displaying a bogus
9254 negative value.
9255
9256 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9257 `error', not SYMBOL_NAME itself.
9258
9259 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9260 character arguments to `error'.
9261
9262 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9263 to `error' in error message about FINAL_CHAR argument. Make sure
9264 FINAL_CHAR is a character, and use %c when it is passed as
9265 argument to `error'.
9266
4ffd0d6b 92672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9268
9269 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9270
9271 * w32.c: Include <time.h>.
9272 (sys_localtime): New function.
9273
4ffd0d6b 92742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9275
9276 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9277
4ffd0d6b 9278 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9279
4ffd0d6b 92802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9281
4ffd0d6b
GM
9282 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9283 zombies (Bug#8467).
aac0c6e3 9284
04c56954
EZ
92852011-04-19 Eli Zaretskii <eliz@gnu.org>
9286
9287 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9288 gl_state.e_property when gl_state.object is Qt.
9289
9290 * insdel.c (make_gap_larger): Remove limitation of buffer size
9291 to <= INT_MAX.
9292
16a43933
CY
92932011-04-18 Chong Yidong <cyd@stupidchicken.com>
9294
9295 * xdisp.c (lookup_glyphless_char_display)
9296 (produce_glyphless_glyph): Handle cons cell entry in
9297 glyphless-char-display.
9298 (Vglyphless_char_display): Document it.
9299
9300 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9301 glyphless-char-display.
9302
4581706e
CY
93032011-04-17 Chong Yidong <cyd@stupidchicken.com>
9304
9305 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9306
9307 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9308
9309 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9310 definition for no-X builds.
9311
4887c6e2 93122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9313
fd35b6f9
PE
9314 Static checks with GCC 4.6.0 and non-default toolkits.
9315
5c1ccb01
PE
9316 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9317
006c5daa
PE
9318 * process.c (keyboard_bit_set): Define only if SIGIO.
9319 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9320 (send_process): Repair possible setjmp clobbering.
9321
efc736d3
PE
9322 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9323
4e2fe2e6
PE
9324 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9325
f97334a2
PE
9326 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9327
4e75f29d
PE
9328 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9329 Define only if needed.
9330
90efadd1
PE
9331 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9332 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9333 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9334
3c647824
PE
9335 * dispextern.h (struct redisplay_interface): Rename param
9336 to avoid shadowing.
e264f262 9337 * termhooks.h (struct terminal): Likewise.
761383f4 9338 * xterm.c (xembed_send_message): Likewise.
3c647824 9339
b58c5c4a
PE
9340 * insdel.c (make_gap_smaller): Define only if
9341 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9342
cad59032
PE
9343 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9344 it.
9345
c339dc2e
PE
9346 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9347 so that we aren't warned about unused symbols.
9348
91a3e27b
PE
9349 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9350
399c71d3 9351 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9352
8ffc96f5
PE
9353 * xfns.c (x_real_positions): Mark locals as initialized.
9354
eef9bc79
PE
9355 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9356
098db9dd
PE
9357 * xterm.c: Fix problems found by static analysis with other toolkits.
9358 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9359 (x_dispatch_event): Declare static if USE_GTK, and
9360 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9361 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9362 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9363 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9364 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9365
eb18f6cc
PE
9366 * xmenu.c (menu_help_callback): Pointer type fixes.
9367 Use const pointers when pointing at readonly data. Avoid pointer
9368 signedness clashes.
9369 (FALSE): Remove unused macro.
9370 (update_frame_menubar): Remove unused decl.
9371
1fe72bf8
PE
9372 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9373
60d9e1db
PE
9374 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9375 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9376 (single_menu_item): Rename local to avoid shadowing.
9377
39261c26
PE
9378 * keyboard.c (make_lispy_event): Remove unused local var.
9379
018c5e19
PE
9380 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9381 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9382
63d2b86e
PE
9383 * bitmaps: Change bitmaps from unsigned char back to the X11
9384 compatible char. Avoid the old compiler warnings about
9385 out-of-range initializers by using, for example, '\xab' rather
9386 than 0xab.
9387
aefd87e1
PE
9388 * xgselect.c (xgselect_initialize): Check vs interface
9389 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9390
bf501fb9
PE
9391 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9392
e9829fdf
PE
9393 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9394 to read-only memory.
9395
1086c095
PE
9396 * fns.c (vector): Remove; this old hack is no longer needed.
9397
2baccd04 9398 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9399 Remove unused var.
dde42981 9400 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9401
72391843 9402 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9403
436c16df 9404 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9405 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9406 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9407
92bb796d 9408 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9409 (x_term_init): Remove local to avoid shadowing.
92bb796d 9410
764430a3 9411 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9412
9413 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9414 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9415
d1dfb56c
EZ
94162011-04-16 Eli Zaretskii <eliz@gnu.org>
9417
c4354cb4
EZ
9418 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9419
d1dfb56c
EZ
9420 Fix regex.c, syntax.c and friends for buffers > 2GB.
9421 * syntax.h (struct gl_state_s): Declare character position members
9422 EMACS_INT.
9423
9424 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9425
04f2d78b
CB
9426 * textprop.c (verify_interval_modification, interval_of):
9427 Declare arguments EMACS_INT.
d1dfb56c
EZ
9428
9429 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9430 EMACS_INT.
9431
9432 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9433
9434 * indent.c (Fvertical_motion): Local variable it_start is now
9435 EMACS_INT.
9436
9437 * regex.c (re_match, re_match_2, re_match_2_internal)
9438 (bcmp_translate, regcomp, regexec, print_double_string)
9439 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9440 (re_compile_pattern, re_exec): Declare arguments and local
9441 variables `size_t' and `ssize_t' and return values `regoff_t', as
9442 appropriate.
9443 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9444 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9445 <compile_stack_type>: `size' and `avail' are now `size_t'.
9446
9447 * regex.h <regoff_t>: Use ssize_t, not int.
9448 (re_search, re_search_2, re_match, re_match_2): Arguments that
9449 specify buffer/string position and length are now ssize_t and
9450 size_t. Return type is regoff_t.
9451
613052cd
BK
94522011-04-16 Ben Key <bkey76@gmail.com>
9453
9454 * nsfont.m: Fixed bugs in ns_get_family and
9455 ns_descriptor_to_entity that were caused by using free to
9456 deallocate memory blocks that were allocated by xmalloc (via
9457 xstrdup). This caused Emacs to crash when compiled with
9458 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9459 --enable-checking=xmallocoverrun). xfree is now used to
9460 deallocate these memory blocks.
9461
4170f62f 94622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9463
71b41406
PE
9464 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9465
9587a89d
PE
9466 emacs_write: Accept and return EMACS_INT for sizes.
9467 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9468 et seq.
9469 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9470 Accept and return EMACS_INT.
9471 (emacs_gnutls_write): Return the number of bytes written on
9472 partial writes.
9473 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9474 (emacs_read, emacs_write): Remove check for negative size, as the
9475 Emacs source code has been audited now.
9587a89d
PE
9476 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9477 (emacs_read, emacs_write): Use it.
273a5f82
PE
9478 * process.c (send_process): Adjust to the new signatures of
9479 emacs_write and emacs_gnutls_write. Do not attempt to store
9480 a byte offset into an 'int'; it might overflow.
9587a89d 9481 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9482
3e047f51
PE
9483 * sound.c: Don't assume sizes fit in 'int'.
9484 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9485 Return EMACS_INT, not int.
3e047f51 9486 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9487 Accept EMACS_INT, not int.
9488 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9489 record read return values.
9490
cc39a9db
BK
94912011-04-15 Ben Key <bkey76@gmail.com>
9492
c9d0ec6d
JB
9493 * keyboard.c (Qundefined): Don't declare static since it is used
9494 in nsfns.m.
9495 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9496 static since they are used in nsfont.m.
cc39a9db 9497
6c60eb9f
SM
94982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9499
9500 * process.c (Qprocessp): Don't declare static.
9501 * lisp.h (Qprocessp): Declare again.
9502
7990b61a
JB
95032011-04-15 Juanma Barranquero <lekktu@gmail.com>
9504
9505 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9506
5d4cb038
PE
95072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9508
8bd7b830 9509 Improve C-level modularity by making more things 'static'.
cd64ea1d 9510
e3b27b31
PE
9511 Don't publish debugger-only interfaces to other modules.
9512 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9513 (verify_bytepos, count_markers): Move decls to the only modules
9514 that need them.
9515 * region-cache.h (pp_cache): Likewise.
9516 * window.h (check_all_windows): Likewise.
9517 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9518
5d4cb038
PE
9519 * sysdep.c (croak): Now static, if
9520 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9521 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9522
9523 * alloc.c (refill_memory_reserve): Now static if
9524 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9525 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9526
e87b6180
PE
9527 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9528 Define only if USE_LUCID.
9529
ac64929e
PE
9530 * xrdb.c (x_customization_string, x_rm_string): Now static.
9531
6f37259d
PE
9532 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9533 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9534
1683e3ab
PE
9535 * xdisp.c (draw_row_with_mouse_face): Now static.
9536 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9537
de9c2632
PE
9538 * window.h (check_all_windows): Mark externally visible.
9539
2b96acb7
PE
9540 * window.c (window_deletion_count): Now static.
9541
9542 * undo.c: Make symbols static if they're not exported.
9543 (last_undo_buffer, last_boundary_position, pending_boundary):
9544 Now static.
9545
50436f33
PE
9546 * textprop.c (interval_insert_behind_hooks): Now static.
9547 (interval_insert_in_front_hooks): Likewise.
9548
64520e5c
PE
9549 * term.c: Make symbols static if they're not exported.
9550 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9551 (max_frame_lines, tty_set_terminal_modes):
9552 (tty_reset_terminal_modes, tty_turn_off_highlight):
9553 (get_tty_terminal): Now static.
9554 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9555 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9556 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9557 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9558 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9559
1fa53021
PE
9560 * sysdep.c: Make symbols static if they're not exported.
9561 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9562 Now static.
9563 (sigprocmask_set, full_mask): Remove; unused.
9564 (wait_debugging): Mark as visible.
9565 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9566 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9567
d4b43b22
PE
9568 * syntax.c (syntax_temp): Define only if !__GNUC__.
9569
b7c513d0
PE
9570 * sound.c (current_sound_device, current_sound): Now static.
9571
989b29ad
PE
9572 * search.c (searchbufs, searchbuf_head): Now static.
9573
13a55a78
PE
9574 * scroll.c (scroll_cost): Remove; unused.
9575 * dispextern.h (scroll_cost): Remove decl.
9576
de68a1fc
PE
9577 * region-cache.h (pp_cache): Mark as externally visible.
9578
40ccffa6
PE
9579 * process.c: Make symbols static if they're not exported.
9580 (process_tick, update_tick, create_process, chan_process):
9581 (Vprocess_alist, proc_buffered_char, datagram_access):
9582 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9583 (deactivate_process): Mark defn as static, as well as decl.
9584 * lisp.h (create_process): Remove decl.
9585 * process.h (chan_process, Vprocess_alist): Remove decls.
9586
ad64fc97
PE
9587 * print.c: Make symbols static if they're not exported.
9588 (print_depth, new_backquote_output, being_printed, print_buffer):
9589 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9590 (print_interval, print_number_index, initial_stderr_stream):
9591 Now static.
9592 * lisp.h (Fprinc): Remove decl.
9593 (debug_output_compilation_hack): Mark as externally visible.
9594
adddb265
PE
9595 * sysdep.c (croak): Move decl from here to syssignal.h.
9596 * syssignal.h (croak): Put it here, so the API can be checked when
9597 'croak' is called from dissociate_if_controlling_tty.
9598
1717ede2
PE
9599 * minibuf.c: Make symbols static if they're not exported.
9600 (minibuf_save_list, choose_minibuf_frame): Now static.
9601 * lisp.h (choose_minibuf_frame): Remove decl.
9602
fa5fb2bc
PE
9603 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9604
1e3890d1
PE
9605 * lread.c: Make symbols static if they're not exported.
9606 (read_objects, initial_obarray, oblookup_last_bucket_number):
9607 Now static.
9608 (make_symbol): Remove; unused.
9609 * lisp.h (initial_obarray, make_symbol): Remove decls.
9610
8a1414fa
PE
9611 * keyboard.c: Make symbols static if they're not exported.
9612 (single_kboard, recent_keys_index, total_keys, recent_keys):
9613 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9614 (this_single_command_key_start, echoing, last_auto_save):
9615 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9616 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9617 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9618 (Vlispy_mouse_stem, double_click_count):
9619 Now static.
9620 (force_auto_save_soon): Define only if SIGDANGER.
9621 (ignore_mouse_drag_p): Now static if
9622 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9623 (print_help): Remove; unused.
9624 (stop_character, last_timer_event): Mark as externally visible.
9625 * keyboard.h (ignore_mouse_drag_p): Declare only if
9626 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9627 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9628 * lisp.h (echoing): Remove decl.
9629 (force_auto_save_soon): Declare only if SIGDANGER.
9630 * xdisp.c (redisplay_window): Simplify code, to make it more
9631 obvious that ignore_mouse_drag_p is not accessed if !defined
9632 USE_GTK && !defined HAVE_NS.
9633
93ea6e8f
PE
9634 * intervals.c: Make symbols static if they're not exported.
9635 (merge_properties_sticky, merge_interval_right, delete_interval):
9636 Now static.
9637 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9638
77382fcc
PE
9639 * insdel.c: Make symbols static if they're not exported.
9640 However, leave prepare_to_modify_buffer alone. It's never
9641 called from outside this function, but that appears to be a bug.
9642 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9643 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9644 (adjust_after_replace_noundo): Remove; unused.
9645 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9646 (signal_before_change): Remove decls.
77382fcc 9647
9306c32e
PE
9648 * indent.c (val_compute_motion, val_vmotion): Now static.
9649
cd44d2eb
PE
9650 * image.c: Make symbols static if they're not exported.
9651 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9652 if USE_GTK.
9653 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9654 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9655
ad9a7a06
PE
9656 * fringe.c (standard_bitmaps): Now static.
9657 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9658
81626931
PE
9659 * frame.c: Make symbols static if they're not exported.
9660 (x_report_frame_params, make_terminal_frame): Now static.
9661 (get_frame_param): Now static, unless HAVE_NS.
9662 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9663 (x_get_resource_string): Remove; not used.
9664 * frame.h (make_terminal_frame, x_report_frame_params):
9665 (x_get_resource_string); Remove decls.
9666 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9667 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9668
239f9db9
PE
9669 * font.c, fontset.c: Make symbols static if they're not exported.
9670 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9671 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9672 * font.c (font_close_object): Now static.
9673 * font.h (font_close_object): Remove.
9674 * fontset.c (FONTSET_OBJLIST): Remove.
9675 (free_realized_fontset) #if-0 the body, which does nothing.
9676 (face_suitable_for_char_p): #if-0, as it's never called.
9677 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9678 * xfaces.c (face_at_string_position):
9679 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9680 since 0 is always ASCII.
9681
dfcf3579
PE
9682 * fns.c (weak_hash_tables): Now static.
9683
5045092b
PE
9684 * fileio.c: Make symbols static if they're not exported.
9685 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9686 (Vwrite_region_annotation_buffers): Now static.
9687
57a96f5c
PE
9688 * eval.c: Make symbols static if they're not exported.
9689 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9690 * lisp.h (backtrace_list): Remove decl.
9691
35f08c38
PE
9692 * emacs.c: Make symbols static if they're not exported.
9693 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9694 (fatal_error_code, fatal_error_signal_hook, standard_args):
9695 Now static.
9696 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9697 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9698 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9699 * lisp.h (fatal_error_signal_hook): Remove decl.
9700 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9701
f44bd759
PE
9702 * editfns.c: Move a (normally-unused) function to its only use.
9703 * editfns.c, lisp.h (get_operating_system_release): Remove.
9704 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9705 worth the hassle of breaking this out.
9706
b532497d
PE
9707 * xterm.c: Make symbols static if they're not exported.
9708 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9709 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9710 (x_destroy_window, x_delete_display):
9711 Now static.
9712 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9713 (x_mouse_leave): Remove; unused.
9714 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9715 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9716 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9717 Remove decls.
9718 (x_mouse_leave): Declare only if WINDOWSNT.
9719 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9720 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9721 USE_X_TOOLKIT.
9722
1675728f
PE
9723 * ftxfont.c: Make symbols static if they're not exported.
9724 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9725 HAVE_FREETYPE.
9726 * font.h (ftxfont_driver): Likewise.
9727
e4cebfca
PE
9728 * xfns.c: Make symbols static if they're not exported.
9729 (x_last_font_name, x_display_info_for_name):
9730 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9731 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9732 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9733 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9734 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9735 (last_show_tip_args): Now static.
9736 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9737 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9738 (x_screen_planes): Remove; unused.
9739 * dispextern.h (x_screen_planes): Remove decl.
9740
5bf46f05
PE
9741 * dispnew.c: Make symbols static if they're not exported.
9742 * dispextern.h (redraw_garbaged_frames, scrolling):
9743 (increment_row_positions): Remove.
9744 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9745 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9746 Now static.
9747 (redraw_garbaged_frames): Remove; unused.
9748
435f4c28
PE
9749 * xfaces.c: Make symbols static if they're not exported.
9750 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9751 Remove decls.
9752 * xterm.h (defined_color): Remove decls.
9753 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9754 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9755 (menu_face_changed_default, defined_color, free_realized_face):
9756 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9757 (ascii_face_of_lisp_face): Remove; unused.
9758
8524aef3
PE
9759 * xdisp.c: Make symbols static if they're not exported.
9760 * dispextern.h (scratch_glyph_row, window_box_edges):
9761 (glyph_to_pixel_coords, set_cursor_from_row):
9762 (get_next_display_element, set_iterator_to_next):
9763 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9764 (show_mouse_face): Remove decls
9765 * frame.h (message_buf_print): Likewise.
9766 * lisp.h (pop_message, set_message, check_point_in_composition):
9767 Likewise.
9768 * xterm.h (set_vertical_scroll_bar): Likewise.
9769 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9770 (message_buf_print, scratch_glyph_row, displayed_buffer):
9771 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9772 (get_next_display_element, show_mouse_face, window_box_edges):
9773 (frame_to_window_pixel_xy, check_point_in_composition):
9774 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9775 (glyph_to_pixel_coords): Remove; unused.
9776
16390cd2
PE
9777 * dired.c (file_name_completion): Now static.
9778
9779 * dbusbind.c (xd_in_read_queued_messages): Now static.
9780
a25f4dfa
PE
9781 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9782 * data.c (circular_list_error): Remove.
9783
14a9c8df
PE
9784 * commands.h (last_point_position, last_point_position_buffer):
9785 (last_point_position_window): Remove decls.
9786 * keyboard.c: Make these variables static.
9787
04f2d78b
CB
9788 * coding.h (coding, code_convert_region, encode_coding_gap):
9789 Remove decls.
74ab6df5
PE
9790 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9791 (iso_code_class, detect_coding, code_convert_region): Now static.
9792 (encode_coding_gap): Remove; unused.
9793
38dfbee1
PE
9794 * chartab.c (chartab_chars, chartab_bits): Now static.
9795
a2cb4e63
PE
9796 * charset.h (charset_iso_8859_1): Remove decl.
9797 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9798 Now static.
9799
127198fd
PE
9800 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9801 * ccl.c (Vccl_program_table): Now static.
9802 (check_ccl_update): Remove; unused.
9803
d85b608f
PE
9804 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9805 * category.h: ... from here.
9806 * category.c (check_category_table, set_category_set): Now static.
9807
31cd66f3
PE
9808 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9809 * lisp.h: Remove these decls.
9810
c358e587
PE
9811 * buffer.c (buffer_count): Remove unused var.
9812
e78aecca
PE
9813 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9814 so that it's not optimized away.
9815 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9816 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9817 exported only to the debugger.
9818
e192d7d3 9819 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9820 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9821
92470028
PE
9822 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9823 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9824 was inaccessible from Lisp.
9825 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9826 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9827
244ed907
PE
9828 alloc.c: Import and export fewer symbols, and remove unused items.
9829 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9830 is defined.
9831 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9832 it's not optimized away by whole-program optimization.
9833 (message_enable_multibyte, free_misc): Remove.
9834 (catchlist, handlerlist, mark_backtrace):
9835 Declare only if BYTE_MARK_STACK.
9836 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9837 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9838 (message_enable_multibyte): Remove decl.
9839 (free_misc, interval_free_list, float_block, float_block_index):
9840 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9841 (cons_free_list, last_marked_index):
9842 Now static.
9843 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9844 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9845 (mark_backtrace): Define only if BYTE_MARK_STACK.
9846 * xdisp.c (message_enable_multibyte): Now static.
9847
61c2b50e 9848 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9849 This makes it easier for human readers (and static analyzers)
9850 to see whether these variables are used from other modules.
9851 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9852 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9853 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9854 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9855 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9856 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9857 * xmenu.c, xselect.c:
9858 Declare Q* vars static if they are not used in other modules.
9859 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9860 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9861 Remove decls of unexported vars.
9862 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9863
95c82688
PE
9864 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9865
16a97296
PE
9866 Make Emacs functions such as Fatom 'static' by default.
9867 This makes it easier for human readers (and static analyzers)
9868 to see whether these functions can be called from other modules.
9869 DEFUN now defines a static function. To make the function external
9870 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9871 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9872 (Finit_image_library):
16a97296
PE
9873 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9874 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9875 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9876 Remove decls, since these functions are now static.
9877 (Funintern, Fget_internal_run_time): New decls, since these functions
9878 were already external.
95c82688 9879
16a97296
PE
9880 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9881 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9882 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9883 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9884 * keyboard.c, keymap.c, lread.c:
9885 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9886 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9887 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9888 Mark functions with DEFUE instead of DEFUN,
9889 if they are used in other modules.
9890 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9891 decls for now-static functions.
9892 * buffer.h (Fdelete_overlay): Remove decl.
9893 * callproc.c (Fgetenv_internal): Mark as internal.
9894 * composite.c (Fremove_list_of_text_properties): Remove decl.
9895 (Fcomposition_get_gstring): New forward static decl.
9896 * composite.h (Fcomposite_get_gstring): Remove decl.
9897 * dired.c (Ffile_attributes): New forward static decl.
9898 * doc.c (Fdocumntation_property): New forward static decl.
9899 * eval.c (Ffetch_bytecode): New forward static decl.
9900 (Funintern): Remove extern decl; now in .h file where it belongs.
9901 * fileio.c (Fmake_symbolic_link): New forward static decl.
9902 * image.c (Finit_image_library): New forward static decl.
9903 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9904 * intervals.h (Fprevious_property_change):
9905 (Fremove_list_of_text_properties): Remove decls.
9906 * keyboard.c (Fthis_command_keys): Remove decl.
9907 (Fcommand_execute): New forward static decl.
9908 * keymap.c (Flookup_key): New forward static decl.
9909 (Fcopy_keymap): Now static.
9910 * keymap.h (Flookup_key): Remove decl.
9911 * process.c (Fget_process): New forward static decl.
9912 (Fprocess_datagram_address): Mark as internal.
9913 * syntax.c (Fsyntax_table_p): New forward static decl.
9914 (skip_chars): Remove duplicate decl.
9915 * textprop.c (Fprevious_property_change): New forward static decl.
9916 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9917 Now internal.
9918 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9919 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9920
785bbd42
PE
9921 * editfns.c (Fformat): Remove unreachable code.
9922
8b913b57
AS
99232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9924
9925 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9926 change. (Bug#8496)
9927
a6744a35
EZ
99282011-04-13 Eli Zaretskii <eliz@gnu.org>
9929
9930 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9931 when at ZV. (Bug#8487)
9932
e7974947
AS
99332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9934
baad03f0
AS
9935 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9936 (Bug#8437)
9937 * keyboard.c (parse_tool_bar_item): Likewise.
9938 * sound.c (sound_cleanup, alsa_close): Likewise.
9939 * termcap.c (tgetent): Likewise.
9940 * xfns.c (x_default_font_parameter): Likewise.
9941 * xsettings.c (read_and_apply_settings): Likewise.
9942
e7974947
AS
9943 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9944 (overrun_check_free): Protoize.
9945
28272684
PE
99462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9947
9948 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9949 since callers should never pass a negative size.
9950 Change the signature to match that of plain 'read' and 'write'; see
9951 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9952 * lisp.h: Update prototypes of emacs_write and emacs_read.
9953
11997c76
EZ
99542011-04-11 Eli Zaretskii <eliz@gnu.org>
9955
9956 * xdisp.c (redisplay_window): Don't try to determine the character
9957 position of the scroll margin if the window start point w->startp
e896f03c 9958 is outside the buffer's accessible region. (Bug#8468)
11997c76 9959
8a2cbd72
EZ
99602011-04-10 Eli Zaretskii <eliz@gnu.org>
9961
9962 Fix write-region and its subroutines for buffers > 2GB.
9963 * fileio.c (a_write, e_write): Modify declaration of arguments and
9964 local variables to support buffers larger than 2GB.
9965 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9966
9967 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9968 argument, local variables, and return value.
9969
9970 * lisp.h: Update prototypes of emacs_write and emacs_read.
9971
9972 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9973
4073e537 99742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9975
1ebfdcb6
PE
9976 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9977
b2ded58d
PE
9978 Fix more problems found by GCC 4.6.0's static checks.
9979
7d66342c
PE
9980 * xdisp.c (vmessage): Use a better test for character truncation.
9981
bbf47d44
PE
9982 * charset.c (load_charset_map): <, not <=, for optimization,
9983 and to avoid potential problems with integer overflow.
9248994d 9984 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9985 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9986 * editfns.c (Fformat): Likewise.
1e69125e 9987 * syntax.c (skip_chars): Likewise.
3befa583 9988
e3019616
PE
9989 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9990 This also lets GCC 4.6.0 generate slightly better loop code.
9991
becfa255
PE
9992 * callint.c (Fcall_interactively): <, not <=, for optimization.
9993 (Fcall_interactively): Count the number of arguments produced,
9994 not the number of arguments given. This is simpler and lets GCC
9995 4.6.0 generate slightly better code.
9996
dae0cd48
PE
9997 * ftfont.c: Distingish more carefully between FcChar8 and char.
9998 The previous code passed unsigned char * to a functions like
9999 strlen and xstrcasecmp that expect char *, which does not
10000 conform to the C standard.
10001 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10002 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10003 char * when the C standard requires it.
10004
76032d70
PE
10005 * keyboard.c (read_char): Remove unused var.
10006
eb3f1cc8
PE
10007 * eval.c: Port to Windows vsnprintf (Bug#8435).
10008 Include <limits.h>.
10009 (SIZE_MAX): Define if the headers do not.
10010 (verror): Do not give up if vsnprintf returns a negative count.
10011 Instead, grow the buffer. This ports to Windows vsnprintf, which
10012 does not conform to C99. Problem reported by Eli Zaretskii.
10013 Also, simplify the allocation scheme, by avoiding the need for
10014 calling realloc, and removing the ALLOCATED variable.
10015
70476b54
PE
10016 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10017
12020a9e
PE
10018 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10019 But keep the doprint source code for now, as we might revamp it
10020 and use it again (Bug#8435).
ea6c7ae6
PE
10021 * lisp.h (doprnt): Remove.
10022 * Makefile.in (base_obj): Remove doprnt.o.
10023 * deps.mk (doprnt.o): Remove.
10024
5fdb398c
PE
10025 error: Print 32- and 64-bit integers portably (Bug#8435).
10026 Without this change, on typical 64-bit hosts error ("...%d...", N)
10027 was used to print both 32- and 64-bit integers N, which relied on
10028 undefined behavior.
61bdb816 10029 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10030 * lisp.h (error, verror): Mark as printf-like functions.
10031 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10032 Report overflow in size calculations when allocating printf buffer.
10033 Do not truncate output string at its first null byte.
10034 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10035 Truncate the output at a character boundary, since vsnprintf does not
10036 do that.
10037 * charset.c (check_iso_charset_parameter): Convert internal
10038 character to string before calling 'error', since %c now has the
10039 printf meaning.
10040 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10041 overflow when computing char to be passed to 'error'. Do not
10042 pass Lisp_Object to 'error'; pass the integer instead.
10043 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10044 formatted with plain %d.
10045
b189fa66
PE
10046 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10047
bff87ef0
PE
10048 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10049
7e2cac20
PE
10050 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10051
ce4d90b5
PE
10052 * xterm.c (x_catch_errors): Remove duplicate declaration.
10053
266c9547
PE
10054 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10055
79c49ad2
PE
10056 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10057
368f4090
JM
100582011-04-10 Jim Meyering <meyering@redhat.com>
10059
10060 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10061 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10062 return ssize_t not "int", and use size_t as the buffer length.
10063 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10064 * gnutls.h: Update declarations.
10065 * process.c (read_process_output): Use ssize_t, to match.
10066 (send_process): Likewise.
10067
a32d4040
CY
100682011-04-09 Chong Yidong <cyd@stupidchicken.com>
10069
10070 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10071
8546720e 100722011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10073
04f2d78b
CB
10074 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10075 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10076
8546720e
GM
10077 * xterm.c (handle_one_xevent):
10078 * xmenu.c (create_and_show_popup_menu):
10079 * xselect.c (x_decline_selection_request)
10080 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10081
0a2f5c1a 100822011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10083
10084 Fix some uses of `int' instead of EMACS_INT.
10085 * search.c (string_match_1, fast_string_match)
10086 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10087 (scan_buffer, find_next_newline_no_quit)
10088 (find_before_next_newline, search_command, Freplace_match)
10089 (Fmatch_data): Make some `int' variables be EMACS_INT.
10090
10091 * xdisp.c (display_count_lines): 3rd argument and return value now
10092 EMACS_INT. All callers changed.
10093 (pint2hrstr): Last argument is now EMACS_INT.
10094
10095 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10096 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10097 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10098 (decode_coding_utf_16, decode_coding_emacs_mule)
10099 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10100 (decode_coding_ccl, decode_coding_charset)
10101 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10102 (decode_coding_iso_2022, decode_coding_emacs_mule)
10103 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10104 <char_offset, last_offset>: Declare EMACS_INT.
10105 (encode_coding_utf_8, encode_coding_utf_16)
10106 (encode_coding_emacs_mule, encode_invocation_designation)
10107 (encode_designation_at_bol, encode_coding_iso_2022)
10108 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10109 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10110 Declare EMACS_INT.
10111 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10112 (encode_invocation_designation): Last argument P_NCHARS is now
10113 EMACS_INT.
10114 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10115 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10116
10117 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10118 All users changed.
10119
10120 * ccl.c (Fccl_execute_on_string): Declare some variables
10121 EMACS_INT.
10122
8546720e 101232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10124
10125 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10126
4e19a977
CS
101272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10128
10129 * process.c (Fformat_network_address): Doc fix.
10130
87302331
R
101312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10132
ee7683eb 10133 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10134
cbb59342
CY
101352011-04-08 Chong Yidong <cyd@stupidchicken.com>
10136
10137 * keyboard.c (read_char): Call Lisp function help-form-show,
10138 instead of using internal_with_output_to_temp_buffer.
10139 (Qhelp_form_show): New var.
e0d38eeb 10140 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10141
10142 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10143
10144 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10145
e67a13ab
CY
101462011-04-06 Chong Yidong <cyd@stupidchicken.com>
10147
04f2d78b
CB
10148 * process.c (Flist_processes): Remove to Lisp.
10149 (list_processes_1): Delete.
e67a13ab 10150
973f782d
EZ
101512011-04-06 Eli Zaretskii <eliz@gnu.org>
10152
7c106b1e
EZ
10153 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10154
973f782d
EZ
10155 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10156
41cf7d1a 101572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10158
ca23cc88
PE
10159 Fix more problems found by GCC 4.6.0's static checks.
10160
f390e2d5
PE
10161 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10162
42eea0d0
PE
10163 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10164
b69769da 10165 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10166
f9541e84
PE
10167 * xdisp.c (vmessage): Mark as a printf-like function.
10168
13841b55
PE
10169 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10170
c136c10f
PE
10171 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10172
5e2d4a30
PE
10173 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10174 printf-like functions.
10175 (tiff_load): Add casts to remove these marks before passing them
10176 to system-supplied API.
10177
583f48b9
PE
10178 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10179
b25d760e
PE
10180 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10181 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10182 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10183 directly, rather than having caller test rule sign. This avoids
10184 some unnecessary tests.
10185 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10186 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10187 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10188
bc7b6697 10189 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10190 (xfont_open): Avoid unnecessary tests.
bc7b6697 10191
27ccc379
PE
10192 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10193
dcd5c89a
PE
10194 * composite.h, composite.c (composition_gstring_put_cache):
10195 Use EMACS_INT, not int, for length.
10196
b13a45c6
PE
10197 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10198 breaking out part of COMPOSITION_DECODE_RULE.
10199 (COMPOSITION_DECODE_RULE): Use it.
10200 * composite.c (get_composition_id): Remove unused local vars,
10201 by using the new macro.
10202
1e792e4d
PE
10203 * textprop.c (set_text_properties_1): Change while to do-while,
10204 since the condition is always true at first.
10205
dc6c6455 10206 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10207 (interval_deletion_adjustment): Return unsigned value.
10208 All uses changed.
dc6c6455 10209
aba7731a
PE
10210 * process.c (list_processes_1, create_pty, read_process_output):
10211 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10212 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10213 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10214 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10215 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10216
fdfc4bf3
PE
10217 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10218
fca8fe46 10219 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10220 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10221
06a0259a 10222 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10223 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10224 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10225
e7b9e80f
PE
10226 * print.c (print_error_message): Avoid int overflow.
10227
56201685
PE
10228 * font.c (font_list_entities): Redo for clarity,
10229 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10230
78834453 10231 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10232 (font_score): Avoid potential overflow in diff calculation.
78834453 10233
0bc0b309 10234 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10235 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10236
e610eaca
PE
10237 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10238
b895abce
PE
10239 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10240 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10241 can always succeed if overflow has undefined behavior.
10242
1f1d9321 10243 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10244 (wordify): Omit three unnecessary tests.
1f1d9321 10245
c59478bc
PE
10246 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10247 All callers changed. This avoids the need for an unused var.
10248
79b73827
PE
10249 * casefiddle.c (casify_region): Remove var that is set but not used.
10250
a4db5dfe
PE
10251 * dired.c (file_name_completion): Remove var that is set but not used.
10252
43aae36e
PE
10253 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10254
2a47c44d 10255 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10256 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10257
a37c69bf
PE
10258 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10259 Check for integer overflow on size calculations.
10260
328ab8e7
PE
10261 * buffer.c (Fprevious_overlay_change): Remove var that is set
10262 but not used.
10263
e5a2a5cb
PE
10264 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10265 Remove vars that are set but not used.
8d84a6eb 10266 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10267 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10268
a60e5f68
PE
10269 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10270
f661cb61 10271 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10272 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10273
f0397f5a
PE
10274 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10275 that are set but not used.
10276
8664db06 10277 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10278 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10279
6abdaa4a
PE
10280 * xselect.c (x_get_local_selection, x_handle_property_notify):
10281 Remove vars that are set but not used.
10282
0ce7538d 10283 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10284 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10285
9ae848fc
PE
10286 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10287 Remove var that is set but not used.
0b918413
PE
10288 (scroll_bar_windows_size): Now size_t, not int.
10289 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10290 Check for overflow.
9ae848fc 10291
a5a62657
PE
10292 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10293 (map_tty_color) [!defined MSDOS]: Likewise.
10294
5c5cdd39
PE
10295 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10296
66ebf983
PE
10297 * coding.c: Remove vars that are set but not used.
10298 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10299 All callers changed.
10300 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10301 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10302 (decode_coding_charset): Remove vars that are set but not used.
10303
1be4d761
PE
10304 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10305 that is set but not used.
10306
47553fa8
PE
10307 * print.c (print_object): Remove var that is set but not used.
10308
1f7196bf 10309 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10310 The gnulib version avoids calling malloc in the usual case,
10311 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10312 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10313 * filelock.c (current_lock_owner): Likewise.
10314 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10315 * sysdep.c: Include allocator.h, careadlinkat.h.
10316 (emacs_no_realloc_allocator): New static constant.
10317 (emacs_readlink): New function.
fdb61804
PE
10318 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10319 ../lib/careadlinkat.h.
d1fdcab7 10320
f84c17c7
SM
103212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10322
10323 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10324 first non-nil return value).
10325
ef3862ad
JD
103262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10327
10328 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10329 if not defined (Bug#8403).
10330
376a7006
JB
103312011-04-02 Juanma Barranquero <lekktu@gmail.com>
10332
10333 * xdisp.c (display_count_lines): Remove parameter `start',
10334 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10335 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10336 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10337 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10338 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10339 and thereabouts. All callers changed.
10340 (get_per_char_metric): Remove parameter `f', unused since
10341 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10342
6ca3801d
JM
103432011-04-02 Jim Meyering <meyering@redhat.com>
10344
10345 do not dereference NULL upon failed strdup
10346 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10347 (ns_get_family): Likewise.
10348
d8e2b5ba
JB
103492011-04-02 Juanma Barranquero <lekktu@gmail.com>
10350
10351 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10352
8c74fcbd
JD
103532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10354
10355 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10356 later (Bug#8403).
10357
7200d79c
SM
103582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10359
03408648 10360 Add lexical binding.
7200d79c 10361
03408648
SM
10362 * window.c (Ftemp_output_buffer_show): New fun.
10363 (Fsave_window_excursion):
10364 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10365
10366 * lread.c (lisp_file_lexically_bound_p): New function.
10367 (Fload): Bind Qlexical_binding.
10368 (readevalloop): Remove `evalfun' arg.
10369 Bind Qinternal_interpreter_environment.
10370 (Feval_buffer): Bind Qlexical_binding.
10371 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10372 Mark as dynamic.
10373 (syms_of_lread): Declare `lexical-binding'.
10374
10375 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10376
10377 * keyboard.c (eval_dyn): New fun.
10378 (menu_item_eval_property): Use it.
ca105506
SM
10379
10380 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10381
03408648
SM
10382 * fns.c (concat, mapcar1): Accept byte-code-functions.
10383
10384 * eval.c (Fsetq): Handle lexical vars.
10385 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10386 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10387 (FletX, Flet): Obey lexical binding.
10388 (Fcommandp): Handle closures.
10389 (Feval): New `lexical' arg.
10390 (eval_sub): New function extracted from Feval. Use it almost
10391 everywhere where Feval was used. Look up vars in lexical env.
10392 Handle closures.
10393 (Ffunctionp): Move from subr.el.
10394 (Ffuncall): Handle closures.
10395 (apply_lambda): Remove `eval_flags'.
10396 (funcall_lambda): Handle closures and new byte-code-functions.
10397 (Fspecial_variable_p): New function.
10398 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10399 but without exporting it to Lisp.
23aba0ea 10400
23aba0ea 10401 * doc.c (Fdocumentation, store_function_docstring):
03408648 10402 * data.c (Finteractive_form): Handle closures.
23aba0ea 10403
03408648
SM
10404 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10405 interactive spec.
ba83908c 10406
04f2d78b
CB
10407 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10408 New byte-codes.
03408648
SM
10409 (exec_byte_code): New function extracted from Fbyte_code to handle new
10410 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10411
03408648 10412 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10413
03408648 10414 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10415
e2abce01
JB
104162011-03-31 Juanma Barranquero <lekktu@gmail.com>
10417
10418 * xdisp.c (redisplay_internal): Fix prototype.
10419
63696a73 104202011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10421
63696a73 10422 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10423 (try_scrolling): Use it when setting scroll_limit.
10424 Limit scrolling to 100 screen lines.
63696a73
EZ
10425 (redisplay_window): Even when falling back on "recentering",
10426 position point in the window according to scroll-conservatively,
10427 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10428
10429 (try_scrolling): When point is above the window, allow searching
10430 as far as scroll_max, or one screenful, to compute vertical
10431 distance from PT to the scroll margin position. This prevents
10432 try_scrolling from unnecessarily failing when
10433 scroll-conservatively is set to a value slightly larger than the
10434 window height. Clean up the case of PT below the margin at bottom
10435 of window: scroll_max can no longer be INT_MAX. When aggressive
10436 scrolling is in use, don't let point enter the opposite scroll
10437 margin as result of the scroll.
10438 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10439 threshold of 100 lines for never-recentering scrolling.
10440
e4cc2dfc
JB
104412011-03-31 Juanma Barranquero <lekktu@gmail.com>
10442
10443 * dispextern.h (move_it_by_lines):
10444 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10445 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10446 (message_log_check_duplicate): Remove parameters `prev_bol' and
10447 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10448 (redisplay_internal): Remove parameter `preserve_echo_area',
10449 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10450
10451 * indent.c (Fvertical_motion):
10452 * window.c (window_scroll_pixel_based, Frecenter):
10453 Don't pass `need_y_p' to `move_it_by_lines'.
10454
1c470562
SM
104552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10456
44f230aa
SM
10457 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10458 steal a few bits to be more compact.
10459 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10460 Remove unneeded casts.
10461
1c470562
SM
10462 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10463
888adce9
ZK
104642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10465
10466 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10467 binding" message (bug#7967).
10468
f838ed7b
PE
104692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10470
77861b95
PE
10471 Fix more problems found by GCC 4.6.0's static checks.
10472
de6dbc14
PE
10473 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10474 Remove unused local var.
10475
f838ed7b
PE
10476 * editfns.c (Fmessage_box): Remove unused local var.
10477
792c7b2b
PE
10478 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10479 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10480 Omit unused local vars.
c499e557 10481 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10482 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10483 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10484 Omit unused local var.
10485
ba0165e1
PE
10486 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10487 Don't assume string length fits in int.
32ad8845 10488 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10489 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10490
3c59b4c9
PE
10491 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10492 instead of alloca (Bug#8344).
10493
a3eed478 10494 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10495 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10496
eb4d412d
PE
10497 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10498
1658b401
PE
10499 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10500 concerns.
10501
10502 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10503
10504 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10505
9a2c6e05
PE
10506 * keyboard.c (syms_of_keyboard): Use the same style as later
10507 in this function when indexing through an array. This also
10508 works around GCC bug 48267.
10509
03d0a109
PE
10510 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10511
44f730c8
PE
10512 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10513
fe75f926
PE
10514 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10515 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10516
ffa8c828
PE
10517 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10518 This avoids undefined behavior on integer overflow, and is a bit
10519 more convenient anyway since it is compared to a size_t variable.
10520
c5101a77
PE
10521 Variadic C functions now count arguments with size_t, not int.
10522 This avoids an unnecessary limitation on 64-bit machines, which
10523 caused (substring ...) to crash on large vectors (Bug#8344).
10524 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10525 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10526 All variadic functions and their callers changed accordingly.
c5101a77
PE
10527 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10528 * data.c (arith_driver, float_arith_driver): Likewise.
10529 * editfns.c (general_insert_function): Likewise.
10530 * eval.c (struct backtrace.nargs, interactive_p)
10531 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10532 (funcall_lambda, mark_backtrace): Likewise.
10533 * fns.c (concat): Likewise.
10534 * frame.c (x_set_frame_parameters): Likewise.
10535 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10536 0 if not found, not -1. All callers changed.
10537
dd3f25f7
PE
10538 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10539 (stack_copy_size): Now size_t, not int.
10540 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10541
461c2ab9
JB
105422011-03-28 Juanma Barranquero <lekktu@gmail.com>
10543
10544 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10545 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10546 All callers changed.
10547
10548 * lisp.h (multibyte_char_to_unibyte):
10549 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10550 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10551 * character.h (CHAR_TO_BYTE8):
10552 * cmds.c (internal_self_insert):
10553 * editfns.c (general_insert_function):
10554 * keymap.c (push_key_description):
10555 * search.c (Freplace_match):
10556 * xdisp.c (message_dolog, set_message_1): All callers changed.
10557
f6d62986
SM
105582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10559
10560 * keyboard.c (safe_run_hook_funcall): New function.
10561 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10562 don't set the hook to nil, but remove the offending function instead.
10563 (Qcommand_hook_internal): Remove, unused.
10564 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10565 Vcommand_hook_internal.
10566
10567 * eval.c (enum run_hooks_condition): Remove.
10568 (funcall_nil, funcall_not): New functions.
10569 (run_hook_with_args): Call each function through a `funcall' argument.
10570 Remove `cond' argument, now redundant.
10571 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10572 (Frun_hook_with_args_until_failure): Adjust accordingly.
10573 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10574
1db5b1ad
JB
105752011-03-28 Juanma Barranquero <lekktu@gmail.com>
10576
10577 * dispextern.h (string_buffer_position): Remove declaration.
10578
10579 * print.c (strout): Remove parameter `multibyte', unused since
10580 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10581
10582 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10583 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10584 All callers changed.
10585
10586 * w32.c (_wsa_errlist): Use braces for struct initializers.
10587
10588 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10589 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10590 All callers changed.
10591 (string_buffer_position): Likewise. Also, make static (it's never
10592 used outside xdisp.c).
10593 (cursor_row_p): Remove parameter `w', unused since
10594 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10595 (decode_mode_spec): Remove parameter `precision', introduced during
10596 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10597 All callers changed.
10598
5ffb62aa
JD
105992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10600
10601 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10602
461c2ab9 106032011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10604
10605 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10606 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10607 (ns_update_auto_hide_menu_bar): New functions.
10608 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10609 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10610 ns_constrain_all_frames.
10611 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10612 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10613
5c380ffb
JD
106142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10615
10616 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10617
9af30bdf
GM
106182011-03-27 Glenn Morris <rgm@gnu.org>
10619
10620 * syssignal.h: Replace RETSIGTYPE with void.
10621 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10622 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10623 Replace SIGTYPE with void everywhere.
10624 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10625 * s/template.h (SIGTYPE): Remove commented out definition.
10626
e2abce01
JB
106272011-03-26 Eli Zaretskii <eliz@gnu.org>
10628
10629 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10630 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10631
f868cd8a
JB
106322011-03-26 Juanma Barranquero <lekktu@gmail.com>
10633
59eb0929
JB
10634 * w32.c (read_unc_volume): Use parameter `henum', instead of
10635 global variable `wget_enum_handle'.
10636
10637 * keymap.c (describe_vector): Remove parameters `indices' and
10638 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10639 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10640
f868cd8a
JB
10641 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10642
10643 * keyboard.c (timer_check): Remove parameter `do_it_now',
10644 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10645 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10646 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10647
10648 * keyboard.c (read_char):
10649 * w32menu.c (w32_menu_display_help):
10650 * xmenu.c (show_help_event, menu_help_callback):
10651 Adjust calls to `show_help_echo'.
10652
10653 * gtkutil.c (xg_maybe_add_timer):
10654 * keyboard.c (readable_events):
10655 * process.c (wait_reading_process_output):
10656 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10657
10658 * insdel.c (adjust_markers_gap_motion):
10659 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10660 (gap_left, gap_right): Don't call it.
10661
2ecf6fdb
CY
106622011-03-25 Chong Yidong <cyd@stupidchicken.com>
10663
10664 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10665 incurred during fontification.
10666
6b1f9ba4
JB
106672011-03-25 Juanma Barranquero <lekktu@gmail.com>
10668
10669 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10670 (DEFVAR_PER_BUFFER): Don't pass it.
10671
10672 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10673 (scrolling_window): Don't pass it.
10674
0f4a96b5
JB
106752011-03-25 Juanma Barranquero <lekktu@gmail.com>
10676
10677 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10678
10679 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10680 and `suffix'.
10681 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10682 of variables specific to SELinux and computation of `encoded_absname'.
10683
10684 * image.c (XPutPixel): Remove unused variable `height'.
10685
10686 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10687
10688 * unexw32.c (get_section_info): Remove unused variable `section'.
10689
10690 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10691 (system_process_attributes): Remove unused variable `sess'.
10692 (sys_read): Remove unused variable `err'.
10693
10694 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10695 (w32_wnd_proc): Remove unused variable `isdead'.
10696 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10697 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10698 (x_create_tip_frame): Remove unused variable `tem'.
10699
10700 * w32inevt.c (w32_console_read_socket):
10701 Remove unused variable `no_events'.
10702
10703 * w32term.c (x_draw_composite_glyph_string_foreground):
10704 Remove unused variable `width'.
10705
1149507c
JB
107062011-03-24 Juanma Barranquero <lekktu@gmail.com>
10707
10708 * w32term.c (x_set_glyph_string_clipping):
10709 Don't pass uninitialized region to CombineRgn.
10710
9c88f339
JB
107112011-03-23 Juanma Barranquero <lekktu@gmail.com>
10712
10713 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10714 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10715 (Fx_close_connection): Remove unused variable `i'.
10716
10717 * w32font.c (w32font_draw): Return number of glyphs.
10718 (w32font_open_internal): Remove unused variable `i'.
10719 (w32font_driver): Add missing initializer.
10720
10721 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10722 (fill_in_menu): Remove unused variable `items_added'.
10723
10724 * w32term.c (last_mouse_press_frame): Remove static global variable.
10725 (w32_clip_to_row): Remove unused variable `f'.
10726 (x_delete_terminal): Remove unused variable `i'.
10727
10728 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10729 (NOTHING): Remove unused static global variable.
10730 (uniscribe_check_otf): Remove unused variable `table'.
10731 (uniscribe_font_driver): Add missing initializers.
10732
dee091a3
JD
107332011-03-23 Julien Danjou <julien@danjou.info>
10734
10735 * term.c (Fsuspend_tty, Fresume_tty):
10736 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10737 * window.c (temp_output_buffer_show):
10738 * insdel.c (signal_before_change):
10739 * frame.c (Fhandle_switch_frame):
10740 * fileio.c (Fdo_auto_save):
10741 * emacs.c (Fkill_emacs):
10742 * editfns.c (save_excursion_restore):
10743 * cmds.c (internal_self_insert):
10744 * callint.c (Fcall_interactively):
10745 * buffer.c (Fkill_all_local_variables):
10746 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10747 Use Frun_hooks.
0f4a96b5 10748 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10749 unconditionally since it does the check itself.
dee091a3 10750
2c520ab5 107512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10752
c9c49752
PE
10753 Fix more problems found by GCC 4.5.2's static checks.
10754
8abc3f12
PE
10755 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10756 the first time through the loop, since we know p0 < p1 then.
10757 This also avoids a gcc -Wstrict-overflow warning.
10758
a2d26660
PE
10759 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10760 leading to a memory leak, possible in functions like
10761 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10762 of objects (Bug#8318).
a2d26660 10763
916c72e9
PE
10764 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10765 that could (at least in theory) be that large.
10766
19ab8a18
PE
10767 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10768 This is less likely to overflow, and avoids undefined behavior if
10769 overflow does occur. All callers changed. Use strtoul to scan
10770 for the unsigned long integer.
b7cbbd6f
PE
10771 (pint2hrstr): Simplify and tune code slightly.
10772 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10773
f0641eff
PE
10774 * scroll.c (do_scrolling): Work around GCC bug 48228.
10775 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10776
7f650bb9
PE
10777 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10778 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10779 (validate_x_resource_name): Simplify count usage.
10780 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10781
37dd57d1
PE
10782 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10783 fail (Bug#8306).
81e56e61 10784
699979fc 10785 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10786
401bf9b4
PE
10787 * process.c (Fmake_network_process): Use socklen_t, not int,
10788 where POSIX says socklen_t is required in portable programs.
10789 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10790 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10791 (Fmake_network_process, server_accept_connection):
10792 (wait_reading_process_output, read_process_output):
10793 Likewise.
10794
b93aacde
PE
10795 * process.c: Rename or move locals to avoid shadowing.
10796 (list_processes_1, Fmake_network_process):
10797 (read_process_output_error_handler, exec_sentinel_error_handler):
10798 Rename or move locals.
4dc343ee 10799 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10800 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10801 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10802 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10803 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10804
af8a867c 10805 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10806 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10807 Include tparam.h instead, since it declares them.
af8a867c
PE
10808 * cm.h (PC): Remove extern decl; tparam.h now does this.
10809 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10810 * terminfo.c: Include tparam.h, to check interfaces.
10811 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10812 (tparam): Adjust signature to match interface in tparam.h;
10813 this removes some undefined behavior. Check that outstring and len
10814 are zero, which they always are with Emacs.
10815 * tparam.h (PC, BC, UP): New extern decls.
10816
0248044d 10817 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10818 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10819
8ff096c1 10820 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10821 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10822 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10823 (ftfont_list): Remove unused local.
49eaafba
PE
10824 (get_adstyle_property, ftfont_pattern_entity):
10825 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10826 Rename locals to avoid shadowing.
8ff096c1 10827
e2be39f6
PE
10828 * xfont.c (xfont_list_family): Mark var as initialized.
10829
c9735e30
PE
10830 * xml.c (make_dom): Now static.
10831
8f5201ae
PE
10832 * composite.c (composition_compute_stop_pos): Rename local to
10833 avoid shadowing.
b246f932
PE
10834 (composition_reseat_it): Remove unused locals.
10835 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10836 (composition_update_it): Mark var as initialized.
11b61122
PE
10837 (find_automatic_composition): Mark vars as initialized,
10838 with a FIXME (Bug#8290).
8f5201ae 10839
760fbc2c
PE
10840 character.h: Rename locals to avoid shadowing.
10841 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10842 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10843 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10844 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10845 to avoid shadowing.
10846
ff08eb85
PE
10847 * textprop.c (property_change_between_p): Remove; unused.
10848
fc7bf025
PE
10849 * intervals.c (interval_start_pos): Now static.
10850
235d7abc
PE
10851 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10852
44f230aa
SM
10853 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10854 Rename locals to avoid shadowing.
3e7d6594 10855
50060332
PE
10856 * sound.c (wav_play, au_play, Fplay_sound_internal):
10857 Fix pointer signedness.
d01f234b 10858 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10859 (wav_play): Initialize a variable to 0, to prevent undefined
10860 behavior (Bug#8278).
50060332 10861
c4fc4e30
PE
10862 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10863
918436ed
PE
10864 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10865
c939f91b
PE
10866 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10867 clobbering (Bug#8298).
b9c7f648
PE
10868 * sysdep.c (sys_subshell): Likewise.
10869 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10870
6bd8c144
PE
10871 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10872 This should get cleaned up, so that child_setup has the
10873 same signature on all platforms.
10874
7710357c 10875 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10876 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10877
c59da222
CY
108782011-03-22 Chong Yidong <cyd@stupidchicken.com>
10879
10880 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10881 not to be necessary, and produces flickering.
10882
66b87493
GM
108832011-03-20 Glenn Morris <rgm@gnu.org>
10884
10885 * config.in: Remove file.
10886
45b6f6d5
JB
108872011-03-20 Juanma Barranquero <lekktu@gmail.com>
10888
10889 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10890 are now in src/globals.h.
10891 (syms_of_minibuf): Remove spurious & from previous change.
10892
cd394be1 108932011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10894
10895 * minibuf.c (completing-read-function): New variable.
10896 (completing-read-default): Rename from completing-read.
10897 (completing-read): Call completing-read-function.
10898
b14e3e21
CY
108992011-03-19 Juanma Barranquero <lekktu@gmail.com>
10900
10901 * xfaces.c (Fx_load_color_file):
10902 Read color file from absolute filename (bug#8250).
10903
f2b726e6
JB
109042011-03-19 Juanma Barranquero <lekktu@gmail.com>
10905
10906 * makefile.w32-in: Update dependencies.
10907
09f6ff02
EZ
109082011-03-17 Eli Zaretskii <eliz@gnu.org>
10909
10910 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10911
29a6015a
PE
109122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10913
a3a6c54e
PE
10914 Fix more problems found by GCC 4.5.2's static checks.
10915
b766f867
PE
10916 * process.c (make_serial_process_unwind, send_process_trap):
10917 (sigchld_handler): Now static.
10918
be02381c
PE
10919 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10920 That way, the code declares only the vars that it needs.
10921 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10922 * s/cygwin.h (PTY_ITERATION): Likewise.
10923 * s/darwin.h (PTY_ITERATION): Likewise.
10924 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10925
57048744
PE
10926 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10927 * process.c (allocate_pty): Don't declare stb unless it's needed.
10928
7914961c 10929 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10930 (CONSTANTLIM): Remove; unused.
10931 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10932 Define only if needed.
7914961c 10933
b3967b18
PE
10934 * unexelf.c (unexec): Name an expression,
10935 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10936 Use a different way to cause a compilation error if anyone uses
10937 n rather than nn, a way that does not involve shadowing.
73366a00 10938 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10939
29a6015a
PE
10940 * deps.mk (unexalpha.o): Remove; unused.
10941
43cfc33e 10942 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10943 * unexec.h: New file.
ce701a33
PE
10944 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10945 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10946 Depend on unexec.h.
10947 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10948 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10949 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10950 Change as necessary to match prototype in unexec.h.
ce701a33 10951
01f44d5a
PE
10952 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10953 shadowing.
4f63c6bb 10954 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10955
a6670b0b
PE
10956 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10957 Rename locals to avoid shadowing.
10958
cef2010d 10959 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10960 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10961
d4d7173a
PE
10962 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10963
f08b802a
PE
10964 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10965 warning when compiling print.c.
10966
3ddb0639
PE
10967 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10968 instead of using an uninitialized var.
5ad03b97 10969 (font_sort_entities): Mark var as initialized.
3ddb0639 10970
170a2692
PE
10971 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10972
e663c700
PE
10973 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10974 pointers to constants.
89bc529a 10975 (font_parse_fcname): Remove unused vars.
7b81e2d0 10976 (font_delete_unmatched): Now static.
ea838e10 10977 (font_get_spec): Remove; unused.
13a547c6
PE
10978 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10979 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10980 Rename or move locals to avoid shadowing.
e663c700 10981
2a80c887 10982 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10983 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10984
1384fa33 10985 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10986 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10987
8b2c52e9
PE
10988 * alloc.c (mark_backtrace): Move decl from here ...
10989 * lisp.h: ... to here, so that it can be checked.
10990
475545b5 10991 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10992 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10993 (lisp_indirect_variable): Name an expression,
10994 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10995 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10996
b1349114 10997 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10998 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10999 Use const pointer when appropriate.
b1349114 11000
a2928364
PE
11001 * lisp.h (get_system_name, get_operating_system_release):
11002 Move decls here, to check interfaces.
11003 * process.c (get_operating_system_release): Move decl to lisp.h.
11004 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11005 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11006 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11007 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11008 (Fformat_time_string, Fencode_time, Finsert_char):
11009 (Ftranslate_region_internal, Fformat):
11010 Rename or remove local vars to avoid shadowing.
9710023e 11011 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11012
a415e694
PE
11013 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11014 avoid shadowing.
11015
8ef4622d
PE
11016 * lisp.h (eassert): Check that the argument compiles, even if
11017 ENABLE_CHECKING is not defined.
11018
946f9a5b
PE
11019 * data.c (Findirect_variable): Name an expression, to avoid
11020 gcc -Wbad-function-cast warning.
112396d6 11021 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11022 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11023 (Fmake_variable_buffer_local, Fmake_local_variable):
11024 Mark variables as initialized.
52746918 11025 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11026
e5aab7e7 11027 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11028 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11029 Rename locals to avoid shadowing.
dff45157
PE
11030 (mark_stack): Move local variables into the #ifdef region where
11031 they're used.
7bc26fdb
PE
11032 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11033 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11034 needed otherwise.
11035 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11036 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11037 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11038
e5aab7e7
PE
11039 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11040 avoids undefined behavior in theory.
11041
4da60324
PE
11042 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11043
88043301
PE
11044 Use functions, not macros, for up- and down-casing (Bug#8254).
11045 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11046 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11047 to use the following functions instead of these macros.
11048 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11049 EMACS_INT, since callers assume the returned value fits in int.
11050 (upcase1): Likewise, for UPCASE_TABLE.
11051 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11052 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11053 the race-condition problem in the old DOWNCASE.
88043301 11054
19ed5445
PE
11055 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11056 Rename locals to avoid shadowing.
11057 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11058 (regex_compile, re_search_2, re_match_2_internal):
11059 Remove unused local vars.
952db0d7
PE
11060 (FREE_VAR): Rewrite so as not to use empty "else",
11061 which gcc can warn about.
da053e48 11062 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11063 (RETALLOC_IF): Define only if needed.
11064 (WORDCHAR_P): Likewise. This one is never needed, but is used
11065 only in a comment talking about a compiler bug, so put inside
11066 the #if 0 of that comment.
11067 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11068 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11069 Remove; unused.
19ed5445 11070
1f3561e4 11071 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11072 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11073 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11074
ded6f8f7
PE
11075 * search.c (simple_search): Remove unused var.
11076
dbd37a95
PE
11077 * dired.c (compile_pattern): Move decl from here ...
11078 * lisp.h: ... to here, so that it can be checked.
11079 (struct re_registers): New forward decl.
11080
7e47afad
PE
11081 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11082
85f24f61
PE
11083 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11084 All uses changed.
11085 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11086 Rename locals to avoid shadowing.
5671df8f 11087 (Fvertical_motion): Mark locals as initialized.
85f24f61 11088
181aa2be 11089 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11090 (casify_region): Mark local as initialized.
181aa2be 11091
930d429c
PE
11092 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11093
7082eac6
PE
11094 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11095 New macros, so that the caller can use some names other than
11096 gcpro1, gcpro2, etc.
11097 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11098 of the new macros.
11099 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11100 argument, for consistency with GCPRO2_VAR, etc: it is now the
11101 prefix of the variable, not the variable itself. All uses
11102 changed.
38b2c076
PE
11103 * dired.c (directory_files_internal, file_name_completion):
11104 Rename locals to avoid shadowing.
11105
15206ed9
PE
11106 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11107 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11108 dired.c's scmp function, had undefined behavior.
11109 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11110 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11111 * buffer.h: ... to here, because these macros use current_buffer,
11112 and the new implementation with inline functions needs to have
11113 current_buffer in scope now, rather than later when the macros
11114 are used.
11115 (downcase, upcase1): New static inline functions.
11116 (DOWNCASE, UPCASE1): Reimplement using these functions.
11117 This avoids undefined behavior in expressions like
11118 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11119 from race conditions in accessing the global variables
11120 case_temp1 and case_temp2.
11121 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11122 * lisp.h (case_temp1, case_temp2): Remove their decls.
11123 * character.h (ASCII_CHAR_P): Move from here ...
11124 * lisp.h: ... to here, so that the inline functions mentioned
11125 above can use them.
11126
4a6bea26
PE
11127 * dired.c (directory_files_internal_unwind): Now static.
11128
f14b7e14
PE
11129 * fileio.c (file_name_as_directory, directory_file_name):
11130 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11131 Now static.
2893f146
PE
11132 (file_name_as_directory): Use const pointers when appropriate.
11133 (Fexpand_file_name): Likewise. In particular, newdir might
11134 point at constant storage, so make it a const pointer.
fd4ead52 11135 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11136 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11137 signedness issues.
f839df0c
PE
11138 (Fset_file_times, Finsert_file_contents, auto_save_error):
11139 Rename locals to avoid shadowing.
f14b7e14 11140
5716756e 11141 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11142 (Ftry_completion, Fall_completions): Rename or remove locals
11143 to avoid shadowing.
5716756e 11144
b4c3046a
PE
11145 * marker.c (bytepos_to_charpos): Remove; unused.
11146
b45db522
PE
11147 * lisp.h (verify_bytepos, count_markers): New decls,
11148 so that gcc does not warn that these functions aren't declared.
11149
85876d07
PE
11150 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11151 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11152 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11153 (copy_text): Remove unused local var.
85876d07 11154
03d78a21 11155 * filelock.c (within_one_second): Now static.
b3dd38ab 11156 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11157
5df8f01b
PE
11158 * buffer.c (fix_overlays_before): Mark locals as initialized.
11159 (fix_start_end_in_overlays): Likewise. This function should be
11160 simplified by using pointers-to-pointers, but that's a different
11161 matter.
b1d876f1 11162 (switch_to_buffer_1): Now static.
8f54f30a
PE
11163 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11164 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11165
a70072c9 11166 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11167 Fix pointer signedness issue.
edced198
PE
11168 (sys_subshell): Mark local as volatile if checking for lint,
11169 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11170 (MAXPATHLEN): Define only if needed.
a70072c9 11171
a0977c44
PE
11172 * process.c (serial_open, serial_configure): Move decls from here ...
11173 * systty.h: ... to here, so that they can be checked.
11174
a884fdcc
PE
11175 * fns.c (get_random, seed_random): Move extern decls from here ...
11176 * lisp.h: ... to here, so that they can be checked.
11177
604efe86 11178 * sysdep.c (reset_io): Now static.
b8950c94 11179 (wait_for_termination_signal): Remove; unused.
604efe86 11180
38fc62d9
PE
11181 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11182 (copy_keymap_item, append_key, push_text_char_description):
11183 Now static.
1004a21a 11184 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11185 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11186 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11187 (describe_map_tree):
11188 Rename locals to avoid shadowing.
38fc62d9 11189
2f2650da
PE
11190 * keyboard.c: Declare functions static if they are not used elsewhere.
11191 (echo_char, echo_dash, cmd_error, top_level_2):
11192 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11193 (read_char, kbd_buffer_get_event, make_lispy_position):
11194 (make_lispy_event, make_lispy_movement, apply_modifiers):
11195 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11196 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11197 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11198 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11199 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11200
a053e86c 11201 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11202 (mark_kboards): Move decl here ...
11203 * alloc.c (mark_kboards): ... from here.
a053e86c 11204
4752793e
PE
11205 * lisp.h (force_auto_save_soon): New decl.
11206
74f10ca7 11207 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11208 (DEFINE_DUMMY_FUNCTION): New macro.
11209 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11210 Use it.
c03cd23f
PE
11211 (main): Add casts to avoid warnings
11212 if GCC considers string literals to be constants.
74f10ca7 11213
022e70d4
PE
11214 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11215
59d6fe83
PE
11216 * dbusbind.c: Pointer signedness fixes.
11217 (xd_signature, xd_append_arg, xd_initialize):
11218 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11219 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11220 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11221 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11222
78320123
PE
11223 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11224 if GCC considers string literals to be constants.
49cebcca 11225 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11226
35ac2a97
SM
112272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11228
fb103ca9
SM
11229 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11230 (print_preprocess, print_object): New macro to fix last change.
11231
35ac2a97
SM
11232 * print.c (print_preprocess): Don't forget font objects.
11233
62973b41
JB
112342011-03-16 Juanma Barranquero <lekktu@gmail.com>
11235
11236 * emacs.c (USAGE3): Doc fixes.
11237
0e48bb22
AS
112382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11239
11240 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11241 structure.
11242
7684e57b
JB
112432011-03-14 Juanma Barranquero <lekktu@gmail.com>
11244
11245 * lisp.h (VWindow_system, Qfile_name_history):
11246 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11247 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11248 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11249
11250 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11251 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11252
11253 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11254 * w32console.c (detect_input_pending, read_input_pending)
11255 (encode_terminal_code):
11256 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11257 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11258 (w32_system_caret_y, Qfile_name_history):
11259 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11260 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11261 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11262 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11263 * w32proc.c (Qlocal, report_file_error):
11264 * w32term.c (Vwindow_system, updating_frame):
11265 * w32uniscribe.c (initialized, uniscribe_font_driver):
11266 Remove unneeded extern declarations.
11267
2aa46d6c
CY
112682011-03-14 Chong Yidong <cyd@stupidchicken.com>
11269
c96bbc66 11270 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11271
cffc6f3b
CY
112722011-03-13 Chong Yidong <cyd@stupidchicken.com>
11273
11274 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11275 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11276 These macros can no longer be used for assignment.
11277
44f230aa
SM
11278 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11279 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11280 (record_buffer_markers, fetch_buffer_markers): New functions for
11281 recording and fetching special buffer markers.
11282 (set_buffer_internal_1, set_buffer_temp): Use them.
11283
11284 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11285
11286 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11287
11288 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11289 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11290
11291 * xdisp.c (hscroll_window_tree):
11292 (reconsider_clip_changes): Use PT instead of BUF_PT.
11293
d251f04b
EZ
112942011-03-13 Eli Zaretskii <eliz@gnu.org>
11295
11296 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11297 $(EMACS_ROOT)/lib/intprops.h.
11298
f0c77cd1
PE
112992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11300
3eca4629
PE
11301 Fix more problems found by GCC 4.5.2's static checks.
11302
7c86ee98
PE
11303 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11304 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11305 (xg_free_frame_widgets): Make it clear that a local variable is
11306 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11307 (gdk_window_get_screen): Make it clear that this macro is needed
11308 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11309 (int_gtk_range_get_value): New function, which avoids a diagnostic
11310 from gcc -Wbad-function-cast.
11311 (xg_set_toolkit_scroll_bar_thumb): Use it.
11312 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11313 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11314 (get_utf8_string, xg_get_file_with_chooser):
11315 Rename locals to avoid shadowing.
11316 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11317
41729b81
PE
11318 * xgselect.c (xg_select): Remove unused var.
11319
f0c77cd1
PE
11320 * image.c (four_corners_best): Mark locals as initialized.
11321 (gif_load): Initialize transparent_p to zero (Bug#8238).
11322 Mark another local as initialized.
ec6cf4c6 11323 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11324
ce0ad53d 11325 * image.c (clear_image_cache): Now static.
d5d5a617 11326 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11327 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11328 (x_edge_detection): Remove unnecessary cast that
11329 gcc -Wbad-function-cast diagnoses.
2037898d 11330 (gif_load): Fix pointer signedness.
6ae141d6
PE
11331 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11332 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11333
33383987 113342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11335
d32df629
PE
11336 Improve quality of tests for time stamp overflow.
11337 For example, without this patch (encode-time 0 0 0 1 1
11338 1152921504606846976) returns the obviously-bogus value (-948597
11339 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11340 reports time overflow. See
11341 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11342 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11343 * editfns.c: Include limits.h and intprops.h.
11344 (TIME_T_MIN, TIME_T_MAX): New macros.
11345 (time_overflow): Move earlier, to before first use.
11346 (hi_time, lo_time): New functions, for an accurate test for
11347 out-of-range times.
11348 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11349 (Fget_internal_run_time): Don't assume time_t fits in int.
11350 (make_time): Use list2 instead of Fcons twice.
11351 (Fdecode_time): More accurate test for out-of-range times.
11352 (check_tm_member): New function.
11353 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11354 (lisp_time_argument): Don't rely on undefined left-shift and
11355 right-shift behavior when checking for time stamp overflow.
8be6f318 11356
fe31d94c
PE
11357 * editfns.c (time_overflow): New function, refactoring common code.
11358 (Fformat_time_string, Fdecode_time, Fencode_time):
11359 (Fcurrent_time_string): Use it.
11360
8be6f318
PE
11361 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11362 * dired.c (make_time): Move to ...
11363 * editfns.c (make_time): ... here.
11364 * systime.h: Note the move.
11365
09d9db2c 113662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11367
126bc0dc
YM
11368 * fringe.c (update_window_fringes): Remove unused variables.
11369
c47cbdfd
YM
11370 * unexmacosx.c (copy_data_segment): Also copy __got section.
11371 (Bug#8223)
11372
7ac80be9
EZ
113732011-03-12 Eli Zaretskii <eliz@gnu.org>
11374
c96bbc66 11375 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11376 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11377 Constify `char *' arguments and their references according to
11378 prototypes in tparam.h.
11379
ecb0f94d 11380 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11381
7ac80be9
EZ
11382 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11383 Adapt all references accordingly.
11384
11385 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11386
ef1fd07e
TT
113872011-03-11 Tom Tromey <tromey@redhat.com>
11388
11389 * buffer.c (syms_of_buffer): Remove obsolete comment.
11390
7ef4b50c
EZ
113912011-03-11 Eli Zaretskii <eliz@gnu.org>
11392
11393 * termhooks.h (encode_terminal_code): Declare prototype.
11394
11395 * msdos.c (encode_terminal_code): Don't declare prototype.
11396
11397 * term.c (encode_terminal_code): Now external again, used by
11398 w32console.c and msdos.c.
11399
44f230aa
SM
11400 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11401 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11402
4b1ec863 114032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11404
1714f52b 11405 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11406
4b1ec863
PE
11407 * fringe.c (update_window_fringes): Mark locals as initialized
11408 (Bug#8227).
11409 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11410
524c7aa6
PE
11411 * alloc.c (mark_fringe_data): Move decl from here ...
11412 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11413 to check its interface.
11414 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11415
a5c0af81 11416 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11417 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11418 (fontset_font): Mark local as initialized.
a9a06e0b 11419 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11420
b4716021
PE
11421 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11422
811e9bac 11423 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11424 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11425 (x_own_selection, Fx_disown_selection_internal): Rename locals
11426 to avoid shadowing.
11427 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11428
7e3ab302
PE
11429 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11430 so that the caller can use some name other than gcpro1.
11431 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11432 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11433 (Fx_backspace_delete_keys_p):
11434 Use them to avoid shadowing, and rename vars to avoid shadowing.
11435 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11436 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11437 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11438 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11439 Remove unused locals.
7e3ab302
PE
11440 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11441 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11442 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11443 macros.
f78faa98 11444
e2b13473
PE
11445 * xterm.h (x_mouse_leave): New decl.
11446
77f23912
PE
11447 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11448 Remove unused functions.
cdf4ba58
PE
11449 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11450 (x_calc_absolute_position): Now static.
7411c686 11451 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11452 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11453 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11454 unless they are used.
38d0b34a
PE
11455 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11456 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11457 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11458 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11459 (x_error_catcher, x_connection_closed, x_error_handler):
11460 (x_error_quitter, xembed_send_message, x_iconify_frame):
11461 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11462 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11463 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11464
44f230aa
SM
11465 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11466 Rename or move locals to avoid shadowing.
6b463e58 11467 (tty_defined_color, merge_face_heights): Now static.
5967d051 11468 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11469 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11470 does not deduce is never used uninitialized.
73719eba
PE
11471 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11472 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11473
426994c3 11474 * terminal.c (store_terminal_param): Now static.
5489860b 11475
032f1620 11476 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11477 (set_frame_menubar): Remove unused local.
d4323972 11478 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11479 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11480 since they might point to immutable storage.
281585b0
PE
11481 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11482 since it's unused otherwise.
032f1620 11483
367c19e5 11484 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11485 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11486 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11487 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11488 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11489 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11490 does not deduce are never used uninitialized.
70739cbe 11491
07b48fa9
PE
11492 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11493
8868a238 11494 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11495 * window.c (window_loop, size_window):
11496 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11497
7e5cf297 11498 * window.c (display_buffer): Now static.
d6550a9f
PE
11499 (size_window): Mark variables that gcc -Wuninitialized
11500 does not deduce are never used uninitialized.
a586633d
PE
11501 * window.h (check_all_windows): New decl, to forestall
11502 gcc -Wmissing-prototypes diagnostic.
5b555da1 11503 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11504
f6095868
PE
11505 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11506 shadowing.
11507 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11508 Include <limits.h>.
11509 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11510 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11511 (load_charset_map): Mark variables that gcc -Wuninitialized
11512 does not deduce are never used uninitialized.
53df7c11 11513 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11514
f38b440c
PE
11515 * coding.c (coding_set_source, coding_set_destination):
11516 Use "else { /* comment */ }" rather than "else /* comment */;"
11517 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11518 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11519 a block, when the outer 'i' will do.
11520 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11521 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11522 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11523 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11524 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11525 Rename locals to avoid shadowing.
11526 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11527 * coding.c (emacs_mule_char, encode_invocation_designation):
11528 Now static, since they're not used elsewhere.
413bb2db 11529 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11530 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11531 (decode_coding_emacs_mule): Mark variables that gcc
11532 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11533 (detect_coding_iso_2022): Initialize a local variable that might
11534 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11535 this initialization is needed. (Bug#8211)
5f58e762
PE
11536 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11537 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11538 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11539 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11540 Remove unused macros.
f38b440c 11541
232b38b9 11542 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11543 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11544 * character.c (string_count_byte8): Likewise.
232b38b9 11545
fb90da1b
PE
11546 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11547 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11548
fb93dbc2
PE
11549 * chartab.c (copy_sub_char_table): Now static, since it's not used
11550 elsewhere.
5c156ace
PE
11551 (sub_char_table_ref_and_range, char_table_ref_and_range):
11552 Rename locals to avoid shadowing.
bbcd0949 11553 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11554
7d3b3862 11555 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11556 (BIDI_BOB): Remove unused macro.
7d3b3862 11557
6be7d3da
PE
11558 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11559 deduce are never used uninitialized.
c2ed9c8b 11560 * term.c (encode_terminal_code): Likewise.
6be7d3da 11561
75f8807f 11562 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11563
50938595
PE
11564 * tparam.h: New file.
11565 * term.c, tparam.h: Include it.
11566 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11567 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11568 Move these decls to tparam.h, and make them agree with what
11569 is actually in tparam.c. The previous trick of using incompatible
11570 decls in different modules does not conform to the C standard.
11571 All callers of tparam changed to use tparam's actual API.
11572 * tparam.c (tparam1, tparam, tgoto):
11573 Use const pointers where appropriate.
11574
fbceeba2
PE
11575 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11576 * cm.h (struct cm): Likewise.
11577 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11578 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11579 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11580 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11581 (turn_on_face, init_tty): Likewise.
11582 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11583
7f3f1250
PE
11584 * term.c (term_mouse_position): Rename local to avoid shadowing.
11585
e6ca6543
PE
11586 * alloc.c (mark_ttys): Move decl from here ...
11587 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11588
c40f8d15
AS
115892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11590
11591 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11592
cfe0661d
JB
115932011-03-09 Juanma Barranquero <lekktu@gmail.com>
11594
11595 * search.c (compile_pattern_1): Remove argument regp, unused since
11596 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11597 (compile_pattern): Don't pass it.
11598
0afb4571
J
115992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11600
11601 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11602 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11603 for ! HAVE_GTK3.
11604 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11605
11606 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11607
11608 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11609 gdk_window_get_screen, gdk_window_get_geometry,
11610 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11611 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11612 (xg_get_pixbuf_from_pixmap): New function.
11613 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11614 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11615 Call xg_get_pixbuf_from_pixmap instead of
11616 gdk_pixbuf_get_from_drawable.
11617 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11618 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11619 (xg_check_special_colors): Use GtkStyleContext and its functions
11620 for HAVE_GTK3.
11621 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11622 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11623 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11624 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11625 Call gtk_widget_get_preferred_size.
0afb4571
J
11626 (xg_frame_resized): gdk_window_get_geometry only takes 5
11627 parameters.
44f230aa
SM
11628 (xg_win_to_widget, xg_event_is_for_menubar):
11629 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11630 (xg_set_widget_bg): New function.
11631 (delete_cb): New function.
895009e1 11632 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11633 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11634 (xg_set_background_color): Call xg_set_widget_bg.
11635 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11636 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11637 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11638 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11639 if ! HAVE_GTK3.
11640 (update_frame_tool_bar): Call gtk_widget_hide.
11641 (xg_initialize): Use GDK_KEY_g.
11642
11643 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11644 if ! HAVE_GTK3
11645 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11646
11647 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11648 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11649 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11650
1c2cc4ef
JB
116512011-03-08 Juanma Barranquero <lekktu@gmail.com>
11652
11653 * w32xfns.c (select_palette): Check success of RealizePalette against
11654 GDI_ERROR, not zero.
11655
33383987 11656See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11657
11658;; Local Variables:
11659;; coding: utf-8
aac0c6e3
MR
11660;; End:
11661
2f097256 11662 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11663
11664 This file is part of GNU Emacs.
11665
11666 GNU Emacs is free software: you can redistribute it and/or modify
11667 it under the terms of the GNU General Public License as published by
11668 the Free Software Foundation, either version 3 of the License, or
11669 (at your option) any later version.
11670
11671 GNU Emacs is distributed in the hope that it will be useful,
11672 but WITHOUT ANY WARRANTY; without even the implied warranty of
11673 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11674 GNU General Public License for more details.
11675
11676 You should have received a copy of the GNU General Public License
11677 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.